gdb/ChangeLog

   1 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * symtab.c (filename_partial_match_opts): New struct type.
   4         (struct output_source_filename_data): New members
   5         regexp, c_regexp, partial_match.
   6         (output_source_filename): Use new members to decide to print file.
   7         (info_sources_option_defs): New variable.
   8         (make_info_sources_options_def_group, print_info_sources_header,
   9         info_sources_command_completer):
  10         New functions.
  11         (info_sources_command): Read new optional arguments.
  12         (_initialize_symtab): Update info sources help.
  13
  14 2019-08-02  Alexandre Oliva <oliva@adacore.com>
  15
  16         * ada-lang.c (exception_support_info_v0): Renamed from...
  17         (default_exception_support_info): ... this.  Create new
  18         definition for v1.
  19         (ada_has_this_exception_support): Look up catch_handlers_sym.
  20         (ada_exception_support_info_sniffer): Try v0 after default.
  21
  22 2019-08-01  Tom Tromey  <tromey@adacore.com>
  23
  24         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
  25         gdbarch.h.
  26
  27 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
  28
  29         * s12z-tdep.c: Fix include path for s12z-opc.h.
  30
  31 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
  32
  33         * NEWS: Require GNU make 3.82.
  34
  35 2019-07-16  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
  38         declare.
  39
  40 2019-07-30  Tom Tromey  <tromey@adacore.com>
  41
  42         * block.c (contained_in): Remove BLOCK_FUNCTION check.
  43
  44 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
  45
  46         * printcmd.c (print_address_symbolic): Print negative offsets.
  47         (build_address_symbolic): Force signed arithmetic when computing
  48         offset.
  49
  50 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
  51
  52         PR/24474: Add a function to lookup static variables.
  53         * NEWS: Mention this new function.
  54         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
  55         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
  56         * python/python.c (python_GdbMethods): Add new function.
  57
  58 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  59
  60         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
  61         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
  62         (objfpy_lookup_static_symbol): New function.
  63         (objfile_object_methods): Add new functions.
  64
  65 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  66
  67         * NEWS: Mention 'set|show print frame-info'.  Mention new
  68         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
  69         backtrace argument.  Mention that python frame filtering code
  70         is now consistent with what 'backtrace' command prints.
  71
  72 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  73
  74         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
  75         comments.
  76         (print_frame_info_auto, print_frame_info_source_line,
  77         print_frame_info_location, print_frame_info_source_and_location,
  78         print_frame_info_location_and_address, print_frame_info_short_location):
  79         New declarations.
  80         (struct frame_print_options): New member print_frame_info.
  81         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  82         * stack.h (get_user_print_what_frame_info): New declaration.
  83         (frame_show_address): New declaration.
  84         * stack.c (print_frame_arguments_choices): New value 'presence'.
  85         (print_frame_info_auto, print_frame_info_source_line,
  86         print_frame_info_location, print_frame_info_source_and_location,
  87         print_frame_info_location_and_address, print_frame_info_short_location,
  88         print_frame_info_choices, print_frame_info_print_what): New definitions.
  89         (print_frame_args): Only print dots for args if print frame-arguments
  90         is 'presence'.
  91         (frame_print_option_defs): New element for "frame-info".
  92         (get_user_print_what_frame_info): New function.
  93         (frame_show_address): Make non static.  Move comment to stack.h.
  94         (print_frame_info_to_print_what): New function.
  95         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  96         to decide what to print.
  97         (backtrace_command_1): Handle the new print_frame_arguments_presence
  98         value.
  99         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 100         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 101         (py_print_frame): In non-mi mode, use LOCATION as default for
 102         print_what, similarly to frame information printed directly by
 103         backtrace command. Handle frame-info user option in non MI mode.
 104
 105 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 106
 107         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 108         Add case for debugging 32-bit target on 64-bit host.  Revise
 109         comment.
 110
 111 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 112
 113         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 114         instead of find_function_entry_range_from_pc.
 115
 116 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 117
 118         * stack.c (find_frame_funname): Remove code which preferred
 119         minsym over symtab sym in "certain pathological cases".
 120
 121         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 122         parameter.  Change type of "do_demangle" to bool.
 123         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 124         Pass suitable "prefer_sym_over_minsym" flag to
 125         build_address_symbolic().  Don't output "+" for negative offsets.
 126         * printcmd.c (print_address_symbolic): Update invocation of
 127         build_address_symbolic to include a "prefer_sym_over_minsym"
 128         flag.
 129         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 130         Restrict cases in which use of minimal symbol is preferred to that
 131         of a found symbol.  Update comments.
 132
 133         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 134         for entry pc when entry pc is out of range for that FDE.
 135
 136 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 137
 138         PR gdb/24839:
 139         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 140         type.
 141
 142 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 143
 144         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 145         this function's Python signature.
 146
 147
 148 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 149
 150         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 151         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 152         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 153         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 154         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 155
 156
 157 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 158
 159         * h8300-tdep.c (h8300_register_name_common): New.
 160         h8300_register_name): Use h8300_register_name_common.
 161         (h8300s_register_name): Likewise.
 162         (h8300sx_register_name): Likewise.
 163         (h8300h_register_nam): New.
 164         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 165
 166
 167 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 168
 169         * arm-tdep.c (arm_skip_cmse_entry): New function.
 170         (arm_is_sgstubs_section): New function.
 171         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 172
 173 2019-07-22  Tom Tromey  <tom@tromey.com>
 174
 175         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 176         Don't self-assign.
 177
 178 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 179
 180         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 181         type_print.
 182
 183 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 184
 185         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 186         so that GDB doesn't match any msymbols when searching in the
 187         TYPES_DOMAIN.
 188         (print_symbol_info): Print using typedef_print or type_print based
 189         on the type of the symbol.  Add updated FIXME comment moved from...
 190         (_initialize_symtab): ... move and update FIXME comment to above.
 191
 192 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 193
 194         * NEWS: Mention adding -q option to "info types".
 195         * symtab.c (struct info_types_options): New struct.
 196         (info_types_options_defs): New variable.
 197         (make_info_types_options_def_group): New function.
 198         (info_types_command): Use gdb::option framework to parse options.
 199         (info_types_command_completer): New function.
 200         (_initialize_symtab): Extend the help text on "info types" and
 201         register command completer.
 202
 203 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 204
 205         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 206         (lookup_symbol_in_objfile): Change int to block_enum and add a
 207         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 208
 209 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 210
 211         * MAINTAINERS (Write After Approval): Add self.
 212
 213 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 214
 215         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 216         instruction to the dummy code region.
 217
 218 2019-07-19  Tom Tromey  <tromey@adacore.com>
 219
 220         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 221         (ARGSUSED, PARAMS, __func__): Remove rules.
 222
 223 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 224
 225         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 226         * features/arm/arm-with-iwmmxt.c: Remove.
 227         * features/arm/arm-with-iwmmxt.xml: Remove.
 228         * features/arm/arm-with-m-fpa-layout.c: Remove.
 229         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 230         * features/arm/arm-with-m-vfp-d16.c: Remove.
 231         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 232         * features/arm/arm-with-m.c: Remove.
 233         * features/arm/arm-with-m.xml: Remove.
 234         * features/arm/arm-with-neon.c: Remove.
 235         * features/arm/arm-with-neon.xml: Remove.
 236         * features/arm/arm-with-vfpv2.c: Remove.
 237         * features/arm/arm-with-vfpv2.xml: Remove.
 238         * features/arm/arm-with-vfpv3.c: Remove.
 239         * features/arm/arm-with-vfpv3.xml: Remove.
 240
 241 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 242
 243         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 244
 245 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 246
 247         * arch/aarch32.c (aarch32_create_target_description): Create
 248         target descriptions using features.
 249         * arch/arm.c (arm_create_target_description)
 250         (arm_create_mprofile_target_description): Likewise.
 251         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 252
 253 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 254
 255         * Makefile.in: Add new files.
 256         * aarch32-tdep.c: New file.
 257         * aarch32-tdep.h: New file.
 258         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 259         Call aarch32_read_description.
 260         * arch/aarch32.c: New file.
 261         * arch/aarch32.h: New file.
 262         * arch/arm.c (arm_create_target_description)
 263         (arm_create_mprofile_target_description): New function.
 264         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 265         (arm_create_target_description)
 266         (arm_create_mprofile_target_description): New declaration.
 267         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 268         read_description functions.
 269         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 270         Likewise.
 271         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 272         * arm-tdep.c (tdesc_arm_list): New variable.
 273         (arm_register_g_packet_guesses): Call create description functions.
 274         (arm_read_description) (arm_read_mprofile_description): New
 275         function.
 276         * arm-tdep.h (arm_read_description)
 277         (arm_read_mprofile_description): Add declaration.
 278         * configure.tgt: Add new files.
 279
 280 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 281
 282         * top.c (new_ui_command): Open specified terminal just once.
 283
 284 2019-07-18  Tom Tromey  <tromey@adacore.com>
 285
 286         * symtab.c (main_name): Constify return type.
 287         * symfile.c (set_initial_language): Update.
 288         * symtab.h (main_name): Constify return type.
 289
 290 2019-07-17  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-winsource.c (tui_update_source_window)
 293         (tui_update_source_window_as_is)
 294         (tui_update_source_windows_with_line): Remove return.
 295         * tui/tui-disasm.c (tui_show_disassem)
 296         (tui_show_disassem_and_update_source): Remove return.
 297         * tui/tui.c (tui_reset): Remove return.
 298         * tui/tui-wingeneral.c
 299         (tui_check_and_display_highlight_if_needed): Remove return.
 300
 301 2019-07-17  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 304
 305 2019-07-17  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-winsource.h (struct tui_exec_info_window)
 308         (struct tui_source_window_base): Move from tui-data.h.
 309         * tui/tui-winsource.c: Move many method definitions from
 310         elsewhere.  Remove "structuring" comments.
 311         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 312         (tui_source_window_base::refresh_window): Move to
 313         tui-winsource.c.
 314         * tui/tui-win.c (tui_source_window_base::refresh_all)
 315         (tui_source_window_base::update_tab_width)
 316         (tui_source_window_base::set_new_height)
 317         (tui_source_window_base::do_make_visible_with_new_height): Move to
 318         tui-winsource.c.
 319         * tui/tui-source.h: Update.
 320         * tui/tui-source.c (tui_source_window_base::reset): Move to
 321         tui-winsource.c.
 322         * tui/tui-disasm.h: Update.
 323         * tui/tui-data.h (struct tui_exec_info_window): Move to
 324         tui-winsource.h.
 325         (struct tui_source_window_base): Likewise.
 326         * tui/tui-data.c (tui_source_window_base::clear_detail)
 327         (tui_source_window_base, ~tui_source_window_base): Move to
 328         tui-winsource.c.
 329
 330 2019-07-17  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-win.c (tui_resize_all)
 333         (tui_source_window_base::update_tab_width)
 334         (tui_adjust_win_heights): Update.
 335         (tui_win_info::make_invisible_and_set_new_height): Rename from
 336         make_invisible_and_set_new_height.
 337         * tui/tui-data.h (struct tui_win_info)
 338         <make_invisible_and_set_new_height>: New method.
 339
 340 2019-07-17  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui.c: Update.
 343         * tui/tui-source.h (struct tui_source_window): Move from
 344         tui-data.h.
 345         * tui/tui-layout.c: Update.
 346         * tui/tui-disasm.c: Update.
 347         * tui/tui-data.h (struct tui_source_window): Move to
 348         tui-source.h.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 353         tui-data.h.
 354         * tui/tui-data.h (struct tui_disasm_window): Move to
 355         tui-disasm.h.
 356
 357 2019-07-17  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui-regs.h (struct tui_data_item_window): Move from
 360         tui-data.h.
 361         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 362         * tui/tui-data.h (struct tui_data_item_window): Move to
 363         tui-regs.h.
 364         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 365
 366 2019-07-17  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui.c: Update.
 369         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 370         (tui_cmd_window::max_height): Move to tui-command.c.
 371         * tui/tui-layout.c: Update.
 372         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 373         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 374         tui-command.c.
 375         * tui/tui-command.h (struct tui_cmd_window): Move from
 376         tui-data.h.
 377         * tui/tui-command.c: Remove "structuring" comments.
 378         (tui_cmd_window::clear_detail)
 379         (tui_cmd_window::do_make_visible_with_new_height)
 380         (tui_cmd_window::max_height): Move from elsewhere.
 381
 382 2019-07-17  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 385         Now static.
 386         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 387         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 388
 389 2019-07-17  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui.c: Update.
 392         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 393         tui-regs.c.
 394         * tui/tui-windata.h: Remove file.
 395         * tui/tui-windata.c: Remove file.
 396         * tui/tui-win.c (tui_data_window::set_new_height)
 397         (tui_data_window::do_make_visible_with_new_height): Move to
 398         tui-regs.c.
 399         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 400         * tui/tui-regs.c: Remove "structuring" comments.
 401         (tui_data_window::first_data_item_displayed)
 402         (tui_data_window::delete_data_content_windows)
 403         (tui_data_window::erase_data_content)
 404         (tui_data_window::display_all_data)
 405         (tui_data_window::refresh_all)
 406         (tui_data_window::do_scroll_vertical)
 407         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 408         (tui_data_window::do_make_visible_with_new_height)
 409         (tui_data_window::refresh_window): Move from elsewhere.
 410         (_initialize_tui_regs): Move to end of file.
 411         * tui/tui-layout.c: Update.
 412         * tui/tui-hooks.c: Update.
 413         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 414         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 415         tui-regs.c.
 416         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 417
 418 2019-07-17  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 421         seen.
 422
 423 2019-07-17  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-win.c (tui_source_window_base::set_new_height)
 426         (tui_source_window_base::do_make_visible_with_new_height): Use
 427         m_has_locator field directly.
 428         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 429         method.
 430         (struct tui_source_window_base) <has_locator>: Likewise.
 431
 432 2019-07-17  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 435         Don't declare.
 436         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 437         Remove.
 438         * tui/tui-win.c (tui_source_window_base::set_new_height)
 439         (tui_source_window_base::set_new_height)
 440         (make_invisible_and_set_new_height)
 441         (tui_source_window_base::do_make_visible_with_new_height)
 442         (tui_source_window_base::do_make_visible_with_new_height):
 443         Update.
 444         * tui/tui-layout.c (show_source_disasm_command, show_data)
 445         (show_source_or_disasm_and_command): Update.
 446         * tui/tui-layout.c (show_layout): Update.
 447
 448 2019-07-17  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-layout.c (make_data_window): Remove.
 451         (show_data): Unify creation and re-initialization cases.
 452
 453 2019-07-17  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-layout.c (make_source_window, make_disasm_window):
 456         Remove.
 457         (show_data): Unify creation and re-initialization cases.
 458
 459 2019-07-17  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-layout.c (make_command_window): Remove.
 462         (show_source_disasm_command, show_source_or_disasm_and_command):
 463         Unify creation and re-initialization cases.
 464
 465 2019-07-17  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 468         creation and re-initialization cases.
 469
 470 2019-07-17  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-regs.c (tui_get_register): Return void.
 473
 474 2019-07-17  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 477         Simplify.
 478
 479 2019-07-17  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 482         resetting.
 483
 484 2019-07-17  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 487         * tui/tui-regs.c (tui_reg_layout): New function.
 488         (tui_show_registers, tui_reg_command): Use it.
 489         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 490         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 491         parameters.
 492         (tui_layout_command): Remove.
 493
 494 2019-07-17  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-layout.h (tui/tui-layout): Return void.
 497         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 498
 499 2019-07-17  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-layout.c (show_source_disasm_command, show_data):
 502         Update.
 503         (reset_locator): Remove.
 504         (show_source_or_disasm_and_command): Update.
 505
 506 2019-07-17  Tom Tromey  <tom@tromey.com>
 507
 508         * tui/tui-source.c (tui_source_window_base::reset): Remove
 509         win_type parameter.
 510         * tui/tui-layout.c (make_command_window, make_source_window)
 511         (make_disasm_window, make_data_window)
 512         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 513         (reset_locator, show_source_or_disasm_and_command): Update.
 514         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 515         win_type parameter.
 516         (struct tui_source_window_base) <reset>: Likewise.
 517
 518 2019-07-17  Tom Tromey  <tom@tromey.com>
 519
 520         * tui/tui-layout.c (show_source_disasm_command): Use
 521         reset_locator.
 522         (reset_locator): New function.
 523         (init_and_make_win): Remove.
 524         (show_source_or_disasm_and_command): Use reset_locator.
 525
 526 2019-07-17  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 529         condition.
 530         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 531         Remove condition.
 532         * tui/tui-source.c (tui_source_window_base::reset): New method.
 533         * tui/tui-layout.c (make_command_window): Don't call
 534         init_and_make_win.
 535         (make_source_window, make_disasm_window): Don't call
 536         make_source_or_disasm_window.
 537         (make_data_window): Don't call init_and_make_win.  Change calling
 538         convention.
 539         (show_source_disasm_command, show_data): Simplify.
 540         (make_source_or_disasm_window): Remove.
 541         (show_source_or_disasm_and_command): Simplify.
 542         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 543         (struct tui_source_window_base) <reset>: Likewise.
 544         <execution_info>: Remove initializer.
 545         * tui/tui-data.c (tui_source_window_base): Initialize
 546         execution_info.
 547
 548 2019-07-17  Tom Tromey  <tom@tromey.com>
 549
 550         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 551         variable.
 552
 553 2019-07-17  Tom Tromey  <tom@tromey.com>
 554
 555         * tui/tui.c (tui_rl_other_window): Update.
 556         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 557         superclass method first.  Always iterate over regs_content.
 558         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 559         method.
 560         * tui/tui-win.c (tui_set_focus_command): Update.
 561
 562 2019-07-17  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-win.c (tui_set_focus_command): Rename from
 565         tui_set_focus.  Call tui_enable.
 566         (tui_set_focus_command): Remove.
 567
 568 2019-07-17  Tom Tromey  <tom@tromey.com>
 569
 570         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 571         refresh_window.
 572         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 573         touchwin.
 574         (tui_data_window::refresh_window): Call refresh_window on data
 575         items.  Always call superclass refresh_window.
 576         (tui_win_info::refresh): Remove.
 577         (tui_source_window_base::refresh_window): Update.
 578         (tui_refresh_all): Update.
 579         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 580         refresh_window.
 581         (show_source_or_disasm_and_command): Likewise.
 582         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 583         (struct tui_source_window_base) <refresh>: Likewise.
 584
 585 2019-07-17  Tom Tromey  <tom@tromey.com>
 586
 587         * tui/tui-winsource.c (tui_clear_source_content)
 588         (tui_show_source_content): Update.
 589         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 590         whether content is empty.
 591         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 592         Remove.
 593
 594 2019-07-17  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 597         window's contents.
 598         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 599         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 600
 601 2019-07-17  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 604         (struct tui_data_item_window): Update.
 605
 606 2019-07-17  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 609         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 610         defines.
 611
 612 2019-07-17  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-winsource.h (tui_erase_source_content)
 615         (tui_clear_source_content): Remove "display_prompt" parameter.
 616         * tui/tui-winsource.c (tui_update_source_window_as_is)
 617         (tui_update_source_windows_with_addr): Update.
 618         (tui_clear_source_content): Remove "display_prompt" parameter.
 619         (tui_erase_source_content): Likewise.  Simplify.
 620         (tui_show_source_content): Update.
 621         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 622         * tui/tui-stack.c (tui_show_frame_info): Update.
 623         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 624         Remove defines.
 625
 626 2019-07-17  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 629         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 630         parameter.
 631         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 632         parameter.
 633
 634 2019-07-17  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-winsource.c (tui_clear_source_content)
 637         (tui_show_source_content, tui_show_exec_info_content)
 638         (tui_clear_exec_info_content): Update.
 639         * tui/tui-stack.c (tui_show_locator_content): Update.
 640         (tui_show_frame_info): Update.
 641         * tui/tui-source.h (tui_source_window): Don't declare.
 642         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 643         from tui_source_is_displayed.
 644         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 645         Remove field.
 646         (struct tui_source_window_base) <content_in_use>: New field.  Now
 647         bool.
 648         (struct tui_source_window) <showing_source_p>: New method.
 649         (TUI_SRC_WIN): Change cast.
 650         * tui/tui-data.c (tui_initialize_static_data): Update.
 651
 652 2019-07-17  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 655         location_matches_p.
 656         * tui/tui-source.c (tui_source_window::location_matches_p): New
 657         method.
 658         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 659         method.
 660         * tui/tui-data.h (struct tui_source_window_base)
 661         <location_matches_p>: New method.
 662         (struct tui_source_window, struct tui_disasm_window)
 663         <location_matches_p>: Likewise.
 664
 665 2019-07-17  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-win.c (tui_set_win_height_command): Rename from
 668         tui_set_win_height.
 669         (tui_set_win_height_command): Remove.
 670
 671 2019-07-17  Tom Tromey  <tom@tromey.com>
 672
 673         * tui/tui-source.c (tui_source_window): New constructor.  Add
 674         observer.
 675         (~tui_source_window): New destructor.
 676         (tui_source_window::style_changed): New method.
 677         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 678         (tui_attach_detach_observers): Update.
 679         * tui/tui-data.h (struct tui_source_window): Make constructor not
 680         inline.  Add destructor.
 681         (struct tui_source_window) <style_changed>: New method.
 682         <m_observable>: New member.
 683
 684 2019-07-17  Tom Tromey  <tom@tromey.com>
 685
 686         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 687         * tui/tui-win.c (tui_resize_all): Fix typo.
 688
 689 2019-07-17  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 692         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 693         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 694         * tui/tui-win.c (window_name_completer): Use foreach.
 695         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 696         (update_tab_width): Likewise.
 697         * tui/tui-layout.c (show_layout): Update.
 698         * tui/tui-data.h (class tui_window_iterator): New.
 699         (struct all_tui_windows): New.
 700         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 701
 702 2019-07-17  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 705         parameter.  Don't reference globals.
 706         (tui_reg_command): Update.
 707
 708 2019-07-17  Tom Tromey  <tom@tromey.com>
 709
 710         * tui/tui-regs.c (tui_show_registers): Simplify.
 711
 712 2019-07-17  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-regs.c (tui_show_registers): Update.
 715         (tui_show_register_group): Add win_info parameter.
 716
 717 2019-07-17  Tom Tromey  <tom@tromey.com>
 718
 719         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 720         Rename from tui_display_reg_element_at_line.
 721         (tui_data_window::display_registers_from_line): Update.
 722         * tui/tui-data.h (struct tui_data_window)
 723         <display_reg_element_at_line>: New method.
 724
 725 2019-07-17  Tom Tromey  <tom@tromey.com>
 726
 727         * tui/tui-regs.h (tui_display_registers_from)
 728         (tui_display_registers_from_line): Don't declare.
 729         * tui/tui-windata.c (tui_data_window::display_all_data)
 730         (tui_data_window::refresh_all)
 731         (tui_data_window::do_scroll_vertical): Update.
 732         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 733         from tui_display_registers_from.
 734         (tui_display_reg_element_at_line): Update.
 735         (tui_data_window::display_registers_from_line): Rename from
 736         tui_display_registers_from_line.
 737         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 738         display_registers_from_line>: New methods.
 739
 740 2019-07-17  Tom Tromey  <tom@tromey.com>
 741
 742         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 743         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 744         from tui_erase_data_content.
 745         (tui_data_window::display_all_data)
 746         (tui_data_window::refresh_all)
 747         (tui_data_window::do_scroll_vertical): Update.
 748         * tui/tui-regs.c (tui_show_registers): Update.
 749         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 750         New method.
 751
 752 2019-07-17  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 755         declare.
 756         * tui/tui-windata.c
 757         (tui_data_window::delete_data_content_windows): Rename from
 758         tui_delete_data_content_windows.
 759         (tui_data_window::display_all_data)
 760         (tui_data_window::do_scroll_vertical): Update.
 761         * tui/tui-data.h (struct tui_data_window)
 762         <delete_data_content_windows>: New method.
 763
 764 2019-07-17  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 767         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 768
 769 2019-07-17  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 772         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 773         from tui_display_all_data.
 774         * tui/tui-win.c
 775         (tui_data_window::do_make_visible_with_new_height): Update.
 776         * tui/tui-regs.c (tui_show_registers): Update.
 777         * tui/tui-layout.c (tui_set_layout): Update.
 778         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 779         method.
 780
 781 2019-07-17  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 784         * tui/tui-windata.c (tui_display_data_from): Remove.
 785         (tui_data_window::refresh_all): Update.
 786
 787 2019-07-17  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 790         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 791         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 792         tui_display_registers_from_line.
 793         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 794         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 795         "force_display" parameter.
 796
 797 2019-07-17  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 800         declare.
 801         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 802         Rename from tui_first_reg_element_no_inline.
 803         (tui_display_reg_element_at_line)
 804         (tui_display_registers_from_line): Update.
 805         * tui/tui-data.h (struct tui_data_window)
 806         <first_reg_element_no_inline>: New method.
 807
 808 2019-07-17  Tom Tromey  <tom@tromey.com>
 809
 810         * tui/tui-windata.c (tui_display_data_from)
 811         (tui_data_window::do_scroll_vertical): Update.
 812         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 813         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 814         Rename from tui_line_from_reg_element_no.
 815         (tui_display_registers_from_line): Update.
 816         * tui/tui-data.h (struct tui_data_window)
 817         <line_from_reg_element_no>: New method.
 818
 819 2019-07-17  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 822         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 823         tui_last_regs_line_no.
 824         (tui_display_reg_element_at_line)
 825         (tui_display_registers_from_line): Update.
 826         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 827         method.
 828
 829 2019-07-17  Tom Tromey  <tom@tromey.com>
 830
 831         PR tui/24722:
 832         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 833         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 834         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 835         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 836         (tui_update_breakpoint_info): Likewise.
 837         * tui/tui-hooks.c (tui_event_create_breakpoint)
 838         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 839         Update.
 840
 841 2019-07-17  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 844
 845 2019-07-17  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-winsource.c (tui_update_source_window_as_is)
 848         (tui_update_source_windows_with_addr): Update.
 849         * tui/tui-source.h (tui_set_source_content)
 850         (tui_show_symtab_source): Add "win_info" parameter.
 851         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 852         parameter.
 853         (tui_show_symtab_source): Likewise.
 854
 855 2019-07-17  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-wingeneral.c
 858         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 859
 860 2019-07-17  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 863         (struct tui_cmd_window) <can_scroll>: New method.
 864         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 865         method.
 866
 867 2019-07-17  Tom Tromey  <tromey@adacore.com>
 868
 869         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 870         do_field_signed>: Rename.  Change type of "value".
 871         * ui-out.c (ui_out::field_signed): Rename from field_int.
 872         Change type of "value".
 873         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 874         type of "value".
 875         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 876         do_field_int.  Change type of "value".
 877         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 878         do_field_int.  Change type of "value".
 879         * tracepoint.c (trace_status_mi, tfind_1)
 880         (print_one_static_tracepoint_marker): Update.
 881         * thread.c (print_thread_info_1, print_selected_thread_frame):
 882         Update.
 883         * stack.c (print_frame, print_frame_info): Update.
 884         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 885         Update.
 886         * source.c (print_source_lines_base): Update.
 887         * skip.c (info_skip_command): Update.
 888         * record-btrace.c (btrace_ui_out_decode_error)
 889         (btrace_call_history_src_line): Update.
 890         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 891         Update.
 892         * progspace.c (print_program_space): Update.
 893         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 894         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 895         do_field_int.  Change type of "value".
 896         * mi/mi-out.c (mi_ui_out::do_table_begin)
 897         (mi_ui_out::do_table_header): Update.
 898         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 899         type of "value".
 900         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 901         (mi_cmd_data_list_changed_registers, output_register)
 902         (mi_cmd_data_read_memory, mi_load_progress)
 903         (mi_cmd_trace_frame_collected): Update.
 904         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 905         Update.
 906         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 907         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 908         (mi_cmd_var_list_children, varobj_update_one): Update.
 909         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 910         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 911         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 912         * inferior.c (print_inferior): Update.
 913         * gdb_bfd.c (print_one_bfd): Update.
 914         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 915         Update.
 916         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 917         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 918         do_field_int.  Change type of "value".
 919         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 920         do_field_int.  Change type of "value".
 921         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 922         (print_one_breakpoint_location, print_it_catch_fork)
 923         (print_one_catch_fork, print_it_catch_vfork)
 924         (print_one_catch_vfork, print_it_catch_solib)
 925         (print_it_catch_exec, print_it_ranged_breakpoint)
 926         (print_mention_watchpoint, print_mention_masked_watchpoint)
 927         (bkpt_print_it, update_static_tracepoint): Update.
 928         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 929         * break-catch-syscall.c (print_it_catch_syscall): Update.
 930         * ada-tasks.c (print_ada_task_info): Update.
 931         * ada-lang.c (print_it_exception, print_mention_exception):
 932         Update.
 933
 934 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 935
 936         PR breakpoints/24541
 937         * gdbarch.c: Regenerate.
 938         * gdbarch.h: Regenerate.
 939         * gdbarch.sh: Adjust return type and parameter types for
 940         'stap_adjust_register'.
 941         (i386_stap_adjust_register): Adjust signature and return new
 942         register name.
 943         * stap-probe.c (stap_parse_register_operand): Adjust use of
 944         'gdbarch_stap_adjust_register'.
 945
 946 2019-07-17  Tom Tromey  <tromey@adacore.com>
 947
 948         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 949         declare VEC.
 950         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 951         std::vector.
 952         (struct s390_process_info): Add initializers.
 953         (s390_add_process): Use new.
 954         (s390_linux_nat_target::low_forget_process): Use delete.
 955         (s390_linux_nat_target::low_new_fork)
 956         (s390_linux_nat_target::stopped_by_watchpoint)
 957         (s390_linux_nat_target::low_prepare_to_resume)
 958         (s390_linux_nat_target::insert_watchpoint)
 959         (s390_linux_nat_target::insert_hw_breakpoint)
 960         (s390_linux_nat_target::remove_watchpoint)
 961         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 962
 963 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 964
 965         * aarch64-fbsd-nat.c: Include regcache.h.
 966         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 967         argument.
 968         (aarch64_fbsd_nat_target::fetch_registers)
 969         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 970         variable.
 971         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 972
 973 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 974
 975         * fbsd-nat.c: Include gdbarch.h.
 976
 977 2019-07-15  Tom Tromey  <tromey@adacore.com>
 978
 979         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 980
 981 2019-07-15  Tom Tromey  <tromey@adacore.com>
 982
 983         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 984         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 985         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 986         * cli-out.c (cli_ui_out::do_field_int): New method.
 987         * ui-out.c (ui_out::field_unsigned): New method.
 988         * symfile.c (generic_load): Use field_unsigned.
 989         (print_transfer_performance): Likewise.
 990         * record-btrace.c (ui_out_field_uint): Remove.
 991         (btrace_call_history_insn_range, btrace_call_history): Use
 992         field_unsigned.
 993         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 994         field_unsigned.
 995         * ui-out.h (class ui_out) <field_unsigned>: New method.
 996         <do_field_unsigned>: Likewise.
 997
 998 2019-07-15  Tom Tromey  <tromey@adacore.com>
 999
1000         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1001         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1002         * target.c (flash_erase_command): Use field_string.
1003         * infrun.c (print_signal_received_reason): Use field_string.
1004         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1005         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1006         field_string.
1007         * ada-tasks.c (print_ada_task_info): Use field_string.
1008
1009 2019-07-15  Tom Tromey  <tromey@adacore.com>
1010
1011         * target.c (flash_erase_command): Use field_core_addr.
1012         * symfile.c (generic_load): Use field_core_addr.
1013         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1014         Use field_core_addr.
1015         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1016         field_core_addr.
1017
1018 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1021         value if its desired type is smaller than a CORE_ADDR and signed.
1022
1023 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1024
1025         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1026         of changes to field names, and use new is_reference field to
1027         decide if a property is a reference or not.
1028         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1029         field.
1030         (struct dwarf2_property_baton): Update header comment, rename
1031         'referenced_type' to 'property_type' and update comments.
1032         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1033         default property type, store in property baton, update to take
1034         accound of renamed field.
1035         (read_func_scope): Update call to attr_to_dynamic_prop.
1036         (read_array_type): Likewise.
1037         (dwarf2_per_cu_addr_sized_int_type): New function.
1038         (read_subrange_index_type): Move type finding code to
1039         dwarf2_per_cu_addr_sized_int_type.
1040         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1041         (dwarf2_per_cu_addr_type): New function.
1042         (set_die_type): Update calls to attr_to_dynamic_prop.
1043
1044 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * dwarf2read.c (read_subrange_index_type): New function.
1047         (read_subrange_type): Move code into new function and call it.
1048         * gdbtypes.c (create_range_type): Add some asserts.
1049
1050 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1053         update return statements.
1054         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1055         declaration, and update comment to match.
1056         * gdbtypes.c (resolve_dynamic_array): Update call to
1057         dwarf2_evaluate_property to match new return type.
1058
1059 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * valarith.c (value_subscripted_rvalue): Change lowerbound
1062         parameter type from int to LONGEST.
1063         * value.h (value_subscripted_rvalue): Likewise in declaration.
1064
1065 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * cli/cli-utils.c (info_print_command_completer): New function.
1068         * cli/cli-utils.h: Add 'completer.h' include, and forward
1069         declaration for 'struct cmd_list_element'.
1070         (info_print_command_completer): Declare.
1071         * stack.c (_initialize_stack): Add completer for 'info locals' and
1072         'info args'.
1073         * symtab.c (_initialize_symtab): Add completer for 'info
1074         variables' and 'info functions'.
1075         * NEWS: Mention completion for additional info commands.
1076
1077 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1078
1079         * cli/cli-utils.c (extract_info_print_args): Delete.
1080         (extract_arg_maybe_quoted): Delete.
1081         (info_print_options_defs): New variable.
1082         (make_info_print_options_def_group): New function.
1083         (extract_info_print_options): Define new function.
1084         * cli/cli-utils.h (extract_info_print_args): Delete.
1085         (struct info_print_options): New structure.
1086         (extract_info_print_options): Declare new function.
1087         * stack.c (info_locals_command): Update to use new
1088         extract_info_print_options, also add a header comment.
1089         (info_args_command): Likewise.
1090         * symtab.c (info_variables_command): Likewise.
1091         (info_functions_command): Likewise.
1092
1093 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1094
1095         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1096         to extract string arguments.
1097         * common/common-utils.c (extract_string_maybe_quoted): New function.
1098         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1099
1100 2019-07-11  Tom Tromey  <tromey@adacore.com>
1101
1102         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1103         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1104         * top.h (gdbinit): Don't declare.
1105         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1106         into...
1107         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1108         * top.c (gdb_init): Don't call init_cli_cmds.
1109         (gdbinit): Remove.
1110         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1111
1112 2019-07-11  Tom Tromey  <tromey@adacore.com>
1113
1114         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1115         after it has been moved.
1116
1117 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1118
1119         * valops.c (value_must_coerce_to_target): Change return type to
1120         bool.
1121         * value.h (value_must_coerce_to_target): Likewise.
1122
1123 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1124
1125         * breakpoint.c (is_hardware_watchpoint): Remove
1126         forward-declaration.
1127         (is_masked_watchpoint): Change return type to bool.
1128         (is_tracepoint): Likewise.
1129         (is_breakpoint): Likewise.
1130         (is_hardware_watchpoint): Likewise.
1131         (is_watchpoint): Likewise.
1132         (is_no_memory_software_watchpoint): Likewise.
1133         (is_catchpoint): Likewise.
1134         (breakpoint_1): Make FILTER parameter's return type bool.
1135         is_masked_watchpoint): Change return type to bool.
1136         (save_breakpoints): Make FILTER parameter's return type bool.
1137         * breakpoint.h (is_breakpoint): Change return type to bool.
1138         (is_watchpoint): Likewise.
1139         (is_catchpoint): Likewise.
1140         (is_tracepoint): Likewise.
1141
1142 2019-07-10  Tom Tromey  <tom@tromey.com>
1143
1144         * defs.h: Don't include gdbarch.h.
1145         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1146         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1147         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1148         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1149         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1150         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1151         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1152         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1153         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1154         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1155         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1156         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1157         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1158         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1159         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1160         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1161         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1162         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1163         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1164         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1165         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1166         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1167         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1168         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1169         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1170         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1171         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1172
1173 2019-07-10  Tom Tromey  <tromey@adacore.com>
1174
1175         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1176         * breakpoint.c (init_ada_exception_breakpoint): Register as
1177         bp_catchpoint.
1178         (print_one_breakpoint_location, print_one_breakpoint): Use
1179         is_ada_exception_catchpoint.
1180         * ada-lang.c (class ada_catchpoint_location): Pass
1181         bp_loc_software_breakpoint to bp_location constructor.
1182         (is_ada_exception_catchpoint): New function.
1183
1184 2019-07-10  Tom Tromey  <tromey@adacore.com>
1185
1186         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1187         VEC.
1188         (struct arm_exidx_entry): New method operator<.
1189         (struct arm_exidx_data) <section_maps>: Change type.
1190         (arm_exidx_data_free): Remove.
1191         (arm_exidx_data_key): Change type.  Move lower.
1192         (arm_exidx_new_objfile): Update.
1193         (arm_compare_exidx_entries): Remove.
1194         (arm_find_exidx_entry, _initialize_arm_tdep)
1195
1196 2019-07-10  Tom Tromey  <tromey@adacore.com>
1197
1198         * solib-spu.c (ocl_program_data_key): Change type.
1199         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1200         Update.
1201
1202 2019-07-10  Tom Tromey  <tromey@adacore.com>
1203
1204         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1205         (struct solib_aix_inferior_data) <library_list>: Change type.
1206         (solib_aix_inferior_data_handle): Change type.
1207         (get_solib_aix_inferior_data): Update.
1208         (solib_aix_free_library_list): Remove.
1209         (library_list_start_library): Update.
1210         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1211         return type.
1212         (solib_aix_get_library_list)
1213         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1214         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1215
1216 2019-07-10  Tom Tromey  <tromey@adacore.com>
1217
1218         * solib-dsbt.c (struct dsbt_info): Add initializers.
1219         (solib_dsbt_pspace_data): Change type.
1220         (dsbt_pspace_data_cleanup): Remove.
1221         (get_dsbt_info, _initialize_dsbt_solib): Update.
1222
1223 2019-07-10  Tom Tromey  <tromey@adacore.com>
1224
1225         * spu-tdep.c (spu_overlay_data): Change type.
1226         (spu_get_overlay_table, spu_overlay_new_objfile)
1227         (_initialize_spu_tdep): Update.
1228
1229 2019-07-10  Tom Tromey  <tromey@adacore.com>
1230
1231         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1232         destructor.
1233         (dbx_objfile_data_key): Change type and declare later.
1234         (DBX_SYMFILE_INFO): Rewrite.
1235         * dbxread.c (dbx_objfile_data_key): Change type.
1236         (dbx_symfile_init): Update.
1237         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1238         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1239         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1240
1241 2019-07-10  Tom Tromey  <tromey@adacore.com>
1242
1243         * jit.c (jit_program_space_key): Change type.  Move lower.
1244         (get_jit_program_space_data): Update.
1245         (jit_program_space_data_cleanup): Remove.
1246         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1247         Update.
1248         (struct jit_program_space_data): Add initializers.
1249
1250 2019-07-10  Tom Tromey  <tromey@adacore.com>
1251
1252         * solib-darwin.c (struct darwin_info): Add initializers.
1253         (solib_darwin_pspace_data): Change type.
1254         (darwin_pspace_data_cleanup): Remove.
1255         (get_darwin_info, _initialize_darwin_solib): Update.
1256
1257 2019-07-10  Tom Tromey  <tromey@adacore.com>
1258
1259         * remote-sim.c (struct sim_inferior_data): Add initializers,
1260         constructor, and destructor.
1261         (sim_inferior_data_key): Change type.  Move lower.
1262         (check_for_duplicate_sim_descriptor): Update.
1263         (get_sim_inferior_data): Use new.  Update.
1264         (~sim_inferior_data_cleanup): Rename from
1265         sim_inferior_data_cleanup.  Simplify.
1266         (gdbsim_close_inferior, simulator_command)
1267         (sim_command_completer, _initialize_remote_sim): Update.
1268         (next_pid, INITIAL_PID): Move earlier.
1269
1270 2019-07-10  Tom Tromey  <tromey@adacore.com>
1271
1272         * python/python-internal.h (create_thread_object): Return
1273         gdbpy_ref.
1274         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1275         * python/py-inferior.c (struct threadlist_entry): Add
1276         constructor.
1277         <thread_obj>: Now a gdbpy_ref.
1278         (thread_to_thread_object): Update.
1279         (add_thread_object): Use new.
1280         (delete_thread_object): Use delete.
1281         (infpy_threads): Update.
1282         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1283         GIL.
1284
1285 2019-07-10  Tom Tromey  <tromey@adacore.com>
1286
1287         * valops.c (value_cast): Specialize error message for Ada.
1288
1289 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1290
1291         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1292
1293 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1294
1295         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1296         bpstat_should_step): Return bool, adjust comments.
1297         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1298         bpstat_should_step): Likewise.
1299
1300 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1301
1302         * features/Makefile: Use feature target descriptions for Arm.
1303         * features/arm/arm-core.c: Generate new file.
1304         * features/arm/arm-fpa.c: Likewise.
1305         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1306         * features/arm/arm-m-profile.c: Likewise.
1307         * features/arm/arm-vfpv2.c: Likewise.
1308         * features/arm/arm-vfpv3.c: Likewise.
1309         * features/arm/xscale-iwmmxt.c: Likewise.
1310         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1311
1312 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1313
1314         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1315         ptrace earlier.
1316
1317 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1318
1319         * features/aarch64-pauth.c: Regenerate.
1320
1321 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1322
1323         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1324         bool.
1325         (bpstat_what): Use false instead of 0.
1326
1327 2019-07-09  Pedro Alves  <palves@redhat.com>
1328
1329         * break-catch-throw.c (is_exception_catchpoint): New.
1330         * breakpoint.c (print_one_breakpoint_location): New parameter
1331         'raw_loc'.  Handle it.  Use
1332         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1333         looking at the breakpoint's type.
1334         (print_one_breakpoint): If handling "maint info breakpoints", also
1335         print locations of exception catchpoints.
1336         * breakpoint.h (is_exception_catchpoint): Declare.
1337
1338 2019-07-09  Pedro Alves  <palves@redhat.com>
1339
1340         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1341         "addr" field.
1342         (allocate_location_exception_catchpoint): New.
1343         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1344         (initialize_throw_catchpoint_ops): Install
1345         allocate_location_exception_catchpoint as allocate_location
1346         method.
1347         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1348         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1349         bp_loc_other.
1350         (breakpoint_address_is_meaningful): Delete.
1351         (bl_address_is_meaningful): New.
1352         (breakpoint_locations_match): Adjust comment.
1353         (bp_location_from_bp_type): New, factored out of...
1354         (bp_location::bp_location(breakpoint *)): ... this.
1355         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1356         factored out of...
1357         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1358         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1359         breakpoint_address_is_meaningful.
1360         (bp_locations_compare): Adjust comment.
1361         (update_global_location_list): Use bl_address_is_meaningful
1362         instead of breakpoint_address_is_meaningful.
1363         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1364         explicit.
1365         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1366         * python/py-breakpoint.c (bppy_get_location): No longer check
1367         whether location is null.
1368
1369 2019-07-09  Pedro Alves  <palves@redhat.com>
1370
1371         PR c++/15468
1372         * breakpoint.c (print_one_breakpoint_location): Remove
1373         single-location assert.
1374
1375 2019-07-09  Tom Tromey  <tom@tromey.com>
1376
1377         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1378         * configure: Rebuild.
1379         * configure.ac: Change common to gdbsupport.
1380         * gdbsupport: Rename from common.
1381         * acinclude.m4: Change common to gdbsupport.
1382         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1383         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1384         gdbsupport.
1385         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1386         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1387         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1388         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1389         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1390         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1391         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1392         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1393         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1394         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1395         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1396         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1397         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1398         coff-pe-read.c, command.h, compile/compile-c-support.c,
1399         compile/compile-c.h, compile/compile-cplus-symbols.c,
1400         compile/compile-cplus-types.c, compile/compile-cplus.h,
1401         compile/compile-loc2c.c, compile/compile.c, completer.c,
1402         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1403         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1404         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1405         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1406         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1407         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1408         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1409         features/aarch64-core.c, features/aarch64-fpu.c,
1410         features/aarch64-pauth.c, features/aarch64-sve.c,
1411         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1412         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1413         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1414         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1415         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1416         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1417         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1418         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1419         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1420         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1421         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1422         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1423         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1424         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1425         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1426         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1427         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1428         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1429         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1430         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1431         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1432         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1433         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1434         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1435         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1436         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1437         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1438         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1439         minsyms.c, mips-linux-tdep.c, namespace.h,
1440         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1441         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1442         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1443         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1444         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1445         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1446         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1447         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1448         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1449         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1450         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1451         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1452         procfs.c, producer.c, progspace.h, psymtab.h,
1453         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1454         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1455         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1456         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1457         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1458         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1459         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1460         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1461         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1462         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1463         target-memory.c, target.c, target.h, target/waitstatus.c,
1464         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1465         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1466         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1467         unittests/array-view-selftests.c,
1468         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1469         unittests/common-utils-selftests.c,
1470         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1471         unittests/format_pieces-selftests.c,
1472         unittests/function-view-selftests.c,
1473         unittests/lookup_name_info-selftests.c,
1474         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1475         unittests/mkdir-recursive-selftests.c,
1476         unittests/observable-selftests.c,
1477         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1478         unittests/parse-connection-spec-selftests.c,
1479         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1480         unittests/scoped_fd-selftests.c,
1481         unittests/scoped_mmap-selftests.c,
1482         unittests/scoped_restore-selftests.c,
1483         unittests/string_view-selftests.c, unittests/style-selftests.c,
1484         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1485         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1486         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1487         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1488         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1489         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1490
1491 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1492
1493         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1494         bool value.
1495         (decode_digits_ordinary): Set explicit_line field in sal.
1496         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1497         symtab_and_line that was set on an explicit line number in
1498         assembler code.  Do always update the recorded symtab and line if
1499         we do skip the prologue.
1500
1501 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * breakpoint.c (set_breakpoint_location_function): Remove
1504         explicit_loc parameter.
1505         (momentary_breakpoint_from_master): Update call to
1506         set_breakpoint_location_function.
1507         (add_location_to_breakpoint): Likewise.
1508
1509 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1510
1511         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1512         required features based on default bfd type when no specific bfd
1513         is present.
1514
1515 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1516
1517         * NEWS: Mention that GDB printf and eval commands can now print
1518         C-style and Ada-style convenience var strings without
1519         calling the inferior.
1520         * printcmd.c (printf_c_string): Locally print GDB internal var
1521         instead of transiting via the inferior.
1522         (printf_wide_c_string): Likewise.
1523
1524 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1525
1526         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1527
1528 2019-07-04  Tom Tromey  <tom@tromey.com>
1529
1530         PR tui/24724:
1531         * tui/tui-winsource.c (tui_clear_source_content): Update.
1532         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1533         (tui_update_breakpoint_info): Update.
1534         (tui_set_exec_info_content): Update.
1535         * tui/tui-source.c (tui_set_source_content_nil): Update.
1536         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1537         has_break.
1538         * tui/tui-data.h (enum tui_bp_flag): New.
1539         (tui_bp_flags): New enum flags type.
1540         (struct tui_source_element) <break_mode>: Change type.  Rename
1541         from has_break.
1542         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1543         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1544         constants.
1545         * tui/tui-winsource.h: Fix comment.
1546
1547 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1548
1549         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1550         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1551         (store_fpregs_to_thread)
1552         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1553         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1554         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1555         (IWMMXT_REGS_SIZE): Add define.
1556         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1557         (fetch_vfp_regs, store_vfp_regs)
1558         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1559         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1560
1561 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1562
1563         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1564         defines.
1565         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1566         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1567         (ARM_INT_REGISTER_SIZE): ...to this.
1568         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1569         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1570         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1571         (arm_linux_collect_gregset, supply_nwfpe_register)
1572         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1573         defines.
1574         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1575         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1576         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1577         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1578         (arm_return_in_memory, arm_store_return_value)
1579         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1580         (arm_record_ld_st_multiple): Likewise.
1581         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1582         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1583
1584 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1585
1586         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1587         AARCH64_DISPLACED_MODIFIED_INSNS.
1588         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1589         (aarch64_displaced_step_copy_insn): Likewise.
1590         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1591         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1592         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1593         ARM_DISPLACED_MODIFIED_INSNS.
1594         * arm-tdep.c (arm_gdbarch_init): Likewise.
1595         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1596         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1597         (struct arm_displaced_step_closure): Use
1598         ARM_DISPLACED_MODIFIED_INSNS.
1599
1600 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1601
1602         * features/Makefile: Remove unused xml files.
1603         * features/aarch64.xml: Remove.
1604         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1605         * features/i386/amd64-avx-avx512.xml: Remove.
1606         * features/i386/amd64-avx-linux.xml: Remove.
1607         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1608         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1609         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1610         * features/i386/amd64-avx-mpx.xml: Remove.
1611         * features/i386/amd64-avx.xml: Remove.
1612         * features/i386/amd64-linux.xml: Remove.
1613         * features/i386/amd64-mpx-linux.xml: Remove.
1614         * features/i386/amd64-mpx.xml: Remove.
1615         * features/i386/amd64.xml: Remove.
1616         * features/i386/i386-avx-avx512-linux.xml: Remove.
1617         * features/i386/i386-avx-avx512.xml: Remove.
1618         * features/i386/i386-avx-linux.xml: Remove.
1619         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1620         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1621         * features/i386/i386-avx-mpx-linux.xml: Remove.
1622         * features/i386/i386-avx-mpx.xml: Remove.
1623         * features/i386/i386-avx.xml: Remove.
1624         * features/i386/i386-linux.xml: Remove.
1625         * features/i386/i386-mmx-linux.xml: Remove.
1626         * features/i386/i386-mmx.xml: Remove.
1627         * features/i386/i386-mpx-linux.xml: Remove.
1628         * features/i386/i386-mpx.xml: Remove.
1629         * features/i386/i386.xml: Remove.
1630         * features/i386/x32-avx-avx512-linux.xml: Remove.
1631         * features/i386/x32-avx-linux.xml: Remove.
1632         * features/i386/x32-linux.xml: Remove.
1633
1634 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1635
1636         * regformats/aarch64.dat: Remove.
1637         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1638         * regformats/i386/amd64-avx-linux.dat: Remove.
1639         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1640         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1641         * regformats/i386/amd64-linux.dat: Remove.
1642         * regformats/i386/amd64-mpx-linux.dat: Remove.
1643         * regformats/i386/amd64.dat: Remove.
1644         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1645         * regformats/i386/i386-avx-linux.dat: Remove.
1646         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1647         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1648         * regformats/i386/i386-linux.dat: Remove.
1649         * regformats/i386/i386-mmx-linux.dat: Remove.
1650         * regformats/i386/i386-mpx-linux.dat: Remove.
1651         * regformats/i386/i386.dat: Remove.
1652         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1653         * regformats/i386/x32-avx-linux.dat: Remove.
1654         * regformats/i386/x32-linux.dat: Remove.
1655
1656 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1657
1658         * aarch64-tdep.c: Remove xml self tests.
1659         * amd64-linux-tdep.c: Likewise.
1660         * amd64-tdep.c: Likewise.
1661         * i386-linux-tdep.c: Likewise.
1662         * i386-tdep.c: Likewise.
1663
1664 2019-07-03  Pedro Alves  <palves@redhat.com>
1665
1666         PR cli/24732
1667         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1668         (pipe_cmd_option_defs): New.
1669         (make_pipe_cmd_options_def_group): New.
1670         (pipe_command): Use gdb::option::process_options.
1671         (pipe_command_completer): New function.
1672         (_initialize_cli_cmds): Install completer for "pipe" command.
1673
1674 2019-07-03  Pedro Alves  <palves@redhat.com>
1675
1676         * cli/cli-option.c (union option_value) <string>: New field.
1677         (struct option_def_and_value): Add ctor, move ctor, dtor and
1678         use DISABLE_COPY_AND_ASSIGN.
1679         (option_def_and_value::clear_value): New.
1680         (parse_option, save_option_value_in_ctx, get_val_type_str)
1681         (add_setshow_cmds_for_options): Handle var_string.
1682         * cli-option.h (union option_def::var_address) <string>: New
1683         field.
1684         (struct string_option_def): New.
1685         * maint-test-options.c (struct test_options_opts): Add default
1686         ctor and use DISABLE_COPY_AND_ASSIGN.
1687         <string_opt>: New field.
1688         (test_options_opts::~test_options_opts): New.
1689         (test_options_opts::dump): Also dump "-string".
1690         (test_options_option_defs): Install "string.
1691
1692 2019-07-03  Pedro Alves  <palves@redhat.com>
1693
1694         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1695         option_value with a null enumeration.
1696         (complete_options): Save the option values in the context.
1697         (save_option_value_in_ctx): New, factored out from ...
1698         (process_options): ... here.
1699         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1700         of the function.
1701         * maint-test-options.c (test_options_opts::dump): New, factored
1702         out from ...
1703         (maintenance_test_options_command_mode): ... here.
1704         (maintenance_test_options_command_completion_result): Delete.
1705         (maintenance_test_options_command_completion_text): Update
1706         comment.
1707         (maintenance_show_test_options_completion_result): Change
1708         prototype.  Just print
1709         maintenance_test_options_command_completion_text.
1710         (save_completion_result): New.
1711         (maintenance_test_options_completer_mode): Pass options context to
1712         complete_options, and then save a dump.
1713         (_initialize_maint_test_options): Use add_cmd to install "maint
1714         show test-options-completion-result".
1715
1716 2019-07-03  Pedro Alves  <palves@redhat.com>
1717
1718         * NEWS (New commands): Mention "with" and "maint with".
1719         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1720         (with_command, with_command_completer): New.
1721         (pipe_command): Adjust to new repeat_previous
1722         interface.
1723         (_initialize_cli_cmds): Install the "with" command and its "w"
1724         alias.
1725         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1726         declarations.
1727         * cli/cli-setshow.c (parse_cli_var_uinteger)
1728         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1729         argument strings for all var_types.
1730         (get_setshow_command_value_string): New, factored out from ...
1731         (do_show_command): ... this.
1732         * cli/cli-setshow.h: Include <string>.
1733         (get_setshow_command_value_string): Declare.
1734         * command.h (repeat_previous): Now returns const char *.  Adjust
1735         comment.
1736         * maint.c: Include "cli/cli-cmds.h".
1737         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1738         (_initialize_maint_cmds): Register the "maintenance with" command.
1739         * top.c (repeat_previous): Move bits from pipe_command here:
1740         Return the saved command line, if any; error out if there's no
1741         command to relaunch.
1742
1743 2019-07-03  Pedro Alves  <palves@redhat.com>
1744
1745         * NEWS (New commands): Mention "maint set/show test-settings"
1746         instead of "maint test-settings".
1747         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1748         (maintenance_test_settings_set_list): Rename to ...
1749         (maintenance_set_test_settings_list): ... this.
1750         (maintenance_test_settings_show_list): Rename to  ...
1751         (maintenance_show_test_settings_list): ... this.
1752         (maintenance_test_settings_cmd): Delete.
1753         (maintenance_test_settings_set_cmd): ...
1754         (maintenance_set_test_settings_cmd): ... this.
1755         (maintenance_test_settings_show_cmd): ...
1756         (maintenance_show_test_settings_cmd): ... this.
1757         (maintenance_test_settings_show_value_cmd):
1758         (maintenance_show_test_settings_value_cmd): ... this.
1759         (_initialize_maint_test_settings): No longer install the "maint
1760         test-settings" prefix command.  Rename "maint test-settings set"
1761         to "maint set test-settings", and "maint test-settings show" to
1762         "maint show test-settings".  Adjust all subcommands.
1763
1764 2019-07-03  Pedro Alves  <palves@redhat.com>
1765
1766         * maint-test-settings.c: Fix file's intro comment.  Replace all
1767         references to "test-options" with references to "test-settings",
1768         in comments.
1769
1770 2019-07-03  Pedro Alves  <palves@redhat.com>
1771
1772         * maint-test-settings.c (maintenance_test_settings_xxx)
1773         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1774         New.
1775         (maintenance_test_settings_enums): Use them.
1776         (maintenance_test_settings_enum): Default to
1777         maintenance_test_settings_xxx.
1778         (_initialize_maint_test_settings): Initialize
1779         MAINTENANCE_TEST_SETTINGS_FILENAME.
1780
1781 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1782
1783         * breakpoint.h (remove_breakpoints_inf): Change return type to
1784         void, move function documentation here.
1785         * breakpoint.c (remove_breakpoints_inf): Change return type to
1786         void, move function documentation to header.
1787
1788 2019-07-02  Pedro Alves  <palves@redhat.com>
1789
1790         * NEWS (Completion improvements): Mention "info threads".
1791         * thread.c (struct info_threads_opts, info_threads_option_defs)
1792         (make_info_threads_options_def_group): New.
1793         (info_threads_command): Use gdb::option::process_options.
1794         (info_threads_command_completer): New.
1795         (_initialize_thread): Use gdb::option::build_help to build the
1796         help text for "info threads".
1797
1798 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1799
1800         * defs.h (generic_load): Move from here...
1801         * symfile.h (generic_load): ... to here.  Rename name parameter
1802         to args.
1803         * symfile.c (generic_load): Add comment.
1804
1805 2019-07-01  Tom Tromey  <tromey@adacore.com>
1806
1807         * dwarf2read.c
1808         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1809         declaration of without_params.  Fix formatting.
1810
1811 2019-07-01  Tom Tromey  <tromey@adacore.com>
1812
1813         * ada-exp.y (find_primitive_type): Update.
1814         * ada-lang.h (ada_lookup_symbol): Update.
1815         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1816         parameter.
1817         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1818
1819 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1820
1821         PR breakpoints/24541
1822         * gdbarch.c: Regenerate.
1823         * gdbarch.h: Regenerate.
1824         * gdbarch.sh: Add 'stap_adjust_register'.
1825         * i386-tdep.c: Include '<unordered_set>'.
1826         (i386_stap_adjust_register): New function.
1827         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1828         * stap-probe.c (stap_parse_register_operand): Call
1829         'gdbarch_stap_adjust_register'.
1830
1831 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1832
1833         PR python/24742
1834         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1835         * python/python.c (do_start_initialization): Use 'xmalloc'
1836         instead of 'PyMem_Malloc'.
1837
1838 2019-06-28  Tom Tromey  <tromey@adacore.com>
1839
1840         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1841         for Ada.
1842
1843 2019-06-27  Tom Tromey  <tromey@adacore.com>
1844
1845         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1846         objfile_key.
1847         (arm_find_mapping_symbol, arm_record_special_symbol)
1848         (_initialize_arm_tdep): Update.
1849         (arm_objfile_data_free): Remove.
1850
1851 2019-06-27  Tom Tromey  <tromey@adacore.com>
1852
1853         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1854         to cp_print_static_field.
1855
1856 2019-06-26  Tom Tromey  <tromey@adacore.com>
1857
1858         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1859         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1860         declare.
1861
1862 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1863
1864         * features/aarch64-core.c (create_feature_aarch64_core):
1865         Regenerate.
1866         * features/aarch64-core.xml: Add cpsr flags.
1867
1868 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1869
1870         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1871         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1872
1873 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1874
1875         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1876         field.
1877         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1878         use.
1879         (arm_record_special_symbol): Don't insert new symbol in sorted
1880         position, push it at the end.
1881
1882 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1883
1884         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1885         (arm_mapping_symbol_s): Remove.
1886         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1887         (arm_mapping_symbol_vec): New typedef.
1888         (struct arm_per_objfile): Add constructor.
1889         <section_maps>: Change type to
1890         std::unique_ptr<arm_mapping_symbol_vec[]>.
1891         (arm_compare_mapping_symbols): Remove.
1892         (arm_find_mapping_symbol): Adjust to section_maps type change.
1893         (arm_objfile_data_free): Call delete on arm_per_objfile.
1894         (arm_record_special_symbol): Adjust to section_maps type change.
1895         Allocate arm_per_objfile with new.
1896
1897 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1898
1899         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1900         with the command prefix.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1905         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1906
1907 2019-06-25  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1910         type.
1911         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1912         protected.
1913
1914 2019-06-25  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-winsource.c
1917         (tui_source_window_base::set_is_exec_point_at): Add check against
1918         LOA_ADDRESS.
1919
1920 2019-06-25  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-source.c (tui_set_source_content): Don't check before
1923         xfree.
1924         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1925
1926 2019-06-25  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-winsource.h (tui_update_source_window_as_is)
1929         (tui_alloc_source_buffer, tui_line_is_displayed)
1930         (tui_addr_is_displayed): Change type of win_info.
1931         * tui/tui-winsource.c (tui_update_source_window_as_is)
1932         (tui_clear_source_content, tui_show_source_line)
1933         (tui_show_source_content, tui_source_window_base::refill)
1934         (tui_source_window_base::set_is_exec_point_at)
1935         (tui_source_window_base::set_is_exec_point_at)
1936         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1937         (tui_alloc_source_buffer, tui_line_is_displayed)
1938         (tui_addr_is_displayed): Change type of win_info.  Update.
1939         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1940         (tui_source_window_base::do_make_visible_with_new_height):
1941         Update.
1942         * tui/tui-source.c (tui_set_source_content)
1943         (tui_set_source_content_nil)
1944         (tui_source_window::do_scroll_vertical): Update.
1945         * tui/tui-layout.c (show_layout): Update.
1946         * tui/tui-disasm.c (tui_set_disassem_content)
1947         (tui_disasm_window::do_scroll_vertical): Update.
1948         * tui/tui-data.h (tui_win_content): Remove.
1949         (struct tui_gen_win_info) <content, content_size>: Remove.
1950         (struct tui_source_element): Add initializers and destructor.
1951         (union tui_which_element, struct tui_win_element): Remove.
1952         (struct tui_source_window_base) <content>: New field.
1953         (struct tui_data_window): Remove destructor.
1954         (tui_alloc_content, tui_free_win_content)
1955         (tui_free_all_source_wins_content): Don't declare.
1956         * tui/tui-data.c (tui_initialize_static_data): Update.
1957         (init_content_element, tui_alloc_content): Remove.
1958         (~tui_gen_win_info): Update.
1959         (~tui_data_window, tui_free_all_source_wins_content)
1960         (tui_free_win_content, free_content, free_content_elements):
1961         Remove.
1962
1963 2019-06-25  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-winsource.h (tui_clear_source_content)
1966         (tui_erase_source_content, tui_show_source_content): Change type
1967         of win_info.
1968         * tui/tui-winsource.c (tui_clear_source_content)
1969         (tui_erase_source_content, tui_show_source_content): Change type
1970         of win_info.
1971         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1972         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1973         win_info.
1974         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1975         win_info.
1976         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1977
1978 2019-06-25  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-winsource.c (tui_clear_source_content)
1981         (tui_source_window_base::set_is_exec_point_at): Update.
1982         * tui/tui-source.c (tui_set_source_content_nil): Update.
1983         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1984         a bool.
1985         * tui/tui-data.c (init_content_element): Update.
1986
1987 2019-06-25  Tom Tromey  <tom@tromey.com>
1988
1989         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1990         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1991         * tui/tui-layout.c (init_and_make_win): Update.
1992         * tui/tui.h (enum tui_win_type): Update.
1993         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1994         tui_win_is_auxillary.
1995         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1996         tui_win_is_auxillary.
1997
1998 2019-06-25  Tom Tromey  <tom@tromey.com>
1999
2000         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2001         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2002         (tui_delete_data_content_windows, tui_display_all_data)
2003         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2004         Update.
2005         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2006         * tui/tui-regs.c (tui_last_regs_line_no)
2007         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2008         (tui_show_registers): Update.
2009         (tui_show_register_group): Return void.  Update.
2010         (tui_display_registers_from, tui_display_reg_element_at_line)
2011         (tui_display_registers_from_line, tui_check_register_values):
2012         Update.
2013         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2014         member.
2015         (struct tui_data_window) <regs_content>: Now a std::vector.
2016         <regs_content_count>: Remove.
2017         (tui_add_content_elements, tui_free_data_content): Don't declare.
2018         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2019         (init_content_element): Remove DATA_WIN case.  Add assert.
2020         (tui_add_content_elements): Remove.
2021         (tui_data_window): Update.
2022         (tui_free_data_content): Remove.
2023         (free_content_elements): Remove DATA_WIN case.
2024
2025 2019-06-25  Tom Tromey  <tom@tromey.com>
2026
2027         * tui/tui-data.c (tui_data_item_window): Update.
2028         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2029         * tui/tui-windata.c (tui_display_all_data)
2030         (tui_display_data_from_line): Update.
2031         (tui_check_data_values): Remove.
2032         * tui/tui-regs.c (tui_show_register_group)
2033         (tui_display_reg_element_at_line): Update.
2034         * tui/tui-hooks.c (tui_register_changed)
2035         (tui_refresh_frame_and_register_information): Call
2036         tui_check_register_values.
2037         * tui/tui-data.h (struct tui_data_window) <data_content,
2038         data_content_count, data_type>: Remove.
2039         (enum tui_data_type): Remove.
2040
2041         * tui/tui-data.c (tui_data_window::clear_detail)
2042         (~tui_data_window): Update.
2043
2044 2019-06-25  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2047         declare.
2048         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2049         Rename from tui_first_data_item_displayed.  Update.
2050         (tui_data_window::refresh_all)
2051         (tui_data_window::do_scroll_vertical): Update.
2052         * tui/tui-data.h (struct tui_data_window)
2053         <first_data_item_displayed>: Declare new method.
2054
2055 2019-06-25  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2058         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2059         contents...
2060         (tui_initialize_static_data): ...here.
2061
2062 2019-06-25  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2065         (tui_display_registers_from, tui_check_register_values): Update.
2066         (tui_display_register): Remove win_info parameter; update.
2067         (tui_get_register): Change type of parameters.
2068         * tui/tui-data.h (struct tui_data_element): Remove.
2069         (union tui_which_element) <data>: Remove.
2070         <data_window>: Change type.
2071         (struct tui_data_item_window): New.
2072         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2073         case.  Add assert.
2074         (~tui_data_item_window): New destructor.
2075         (free_content_elements): Remove DATA_ITEM_WIN case.
2076
2077 2019-06-25  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2080         Remove.
2081
2082 2019-06-25  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-data.h (struct tui_command_element): Remove.
2085         (union tui_which_element) <command>: Remove.
2086         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2087         assert.
2088         (free_content_elements): Remove CMD_WIN case.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-layout.c (tui_set_layout): Update.
2093         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2094         * tui/tui-data.c (layout_def): Update.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2099         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2100         (tui_source_window_base::set_new_height): Update.
2101         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2102         Update.
2103         (tui_set_locator_fullname, tui_set_locator_info)
2104         (tui_show_frame_info): Update.
2105         * tui/tui-source.c (tui_set_source_content)
2106         (tui_source_is_displayed): Update.
2107         * tui/tui-layout.c (show_source_disasm_command, show_data)
2108         (show_source_or_disasm_and_command): Update.
2109         * tui/tui-disasm.c (tui_set_disassem_content)
2110         (tui_get_begin_asm_address): Update.
2111         * tui/tui-data.h (struct tui_locator_element): Remove.
2112         (union tui_which_element) <locator>: Remove.
2113         (struct tui_locator_window): New.
2114         (tui_locator_win_info_ptr): Change return type.
2115         * tui/tui-data.c (_locator): Change type.
2116         (tui_locator_win_info_ptr): Change return type.
2117         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2118         (tui_alloc_content): Add assert.
2119
2120 2019-06-25  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-winsource.c
2123         (tui_exec_info_window::maybe_allocate_content): New method.
2124         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2125         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2126         (make_source_or_disasm_window): Add cast.
2127         * tui/tui-data.h (union tui_which_element) <simple_string>:
2128         Remove.
2129         (struct tui_source_info): New.
2130         (struct tui_source_window_base) <execution_info>: Change type.
2131         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2132         case, and add assert.
2133         (tui_alloc_content): Add assert.
2134
2135 2019-06-25  Tom Tromey  <tom@tromey.com>
2136
2137         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2138         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2139         * tui/tui-data.c (tui_alloc_win_info): Remove.
2140
2141 2019-06-25  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2144         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2145         can_highlight.
2146
2147 2019-06-25  Tom Tromey  <tom@tromey.com>
2148
2149         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2150         make_visible_with_new_height method.
2151         (tui_win_info::make_visible_with_new_height): New method.
2152         (tui_source_window_base::do_make_visible_with_new_height)
2153         (tui_data_window::do_make_visible_with_new_height)
2154         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2155         (make_visible_with_new_height): Remove.
2156         (tui_resize_all, tui_adjust_win_heights): Use
2157         make_visible_with_new_height method.
2158         * tui/tui-data.h (struct tui_win_info)
2159         <do_make_visible_with_new_height, make_visible_with_new_height>:
2160         New methods.
2161         (struct tui_source_window_base, struct tui_data_window)
2162         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2163         methods.
2164
2165 2019-06-25  Tom Tromey  <tom@tromey.com>
2166
2167         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2168         method.
2169         (update_tab_width): Call update_tab_width method.
2170         * tui/tui-data.h (struct tui_win_info)
2171         (struct tui_source_window_base) <update_tab_width>: New methods.
2172
2173 2019-06-25  Tom Tromey  <tom@tromey.com>
2174
2175         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2176         parameter.
2177         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2178         parameter.
2179         (tui_gen_win_info::make_visible): Update.
2180         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2181         parameter.
2182         * tui/tui-data.h (enum tui_box): New enum.
2183         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2184
2185 2019-06-25  Tom Tromey  <tom@tromey.com>
2186
2187         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2188         init_and_make_win for EXEC_INFO_WIN.
2189         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2190         longer inline.
2191         (struct tui_win_info) <~tui_win_info>: Inline.
2192         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2193         Don't declare.
2194         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2195         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2196         Remove.
2197         (tui_initialize_static_data): Update.
2198         (~tui_gen_win_info): Handle more cleanup here.
2199         (~tui_source_window_base): Delete "execution_info".
2200         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2201
2202 2019-06-25  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-layout.c (make_command_window): Don't set
2205         can_highlight.
2206         (show_source_disasm_command): Call the reset method.
2207         (show_data): Don't set can_highlight.  Call the reset method.
2208         (tui_gen_win_info::reset): Rename from init_gen_win_info
2209         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2210         (show_source_or_disasm_and_command): Call the reset method.
2211         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2212         (struct tui_cmd_window): Set can_highlight.
2213
2214 2019-06-25  Tom Tromey  <tom@tromey.com>
2215
2216         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2217         from make_visible.
2218         (tui_make_visible, tui_make_invisible): Rewrite.
2219         (tui_win_info::make_visible): Remove.
2220         (tui_source_window_base::make_visible): Update.
2221         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2222         method.  Moved from...
2223         (struct tui_win_info) <make_visible>: ...here.
2224
2225 2019-06-25  Tom Tromey  <tom@tromey.com>
2226
2227         * tui/tui-winsource.c
2228         (tui_source_window_base::do_scroll_horizontal): Remove direction
2229         parameter.
2230         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2231         direction parameter.
2232         * tui/tui-win.c (tui_win_info::forward_scroll)
2233         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2234         (tui_win_info::right_scroll): Update.
2235         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2236         direction parameter.
2237         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2238         direction parameter.
2239         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2240         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2241         Remove direction parameter.
2242         (struct tui_source_window_base, struct tui_source_window)
2243         (struct tui_disasm_window, struct tui_data_window)
2244         (struct tui_cmd_window): Update.
2245
2246 2019-06-25  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-winsource.h (tui_set_exec_info_content)
2249         (tui_show_exec_info_content, tui_erase_exec_info_content)
2250         (tui_clear_exec_info_content, tui_update_exec_info): Change
2251         argument to tui_source_window_base.
2252         * tui/tui-winsource.c (tui_set_exec_info_content)
2253         (tui_show_exec_info_content, tui_erase_exec_info_content)
2254         (tui_clear_exec_info_content, tui_update_exec_info): Change
2255         argument to tui_source_window_base.
2256
2257 2019-06-25  Tom Tromey  <tom@tromey.com>
2258
2259         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2260         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2261
2262 2019-06-25  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2265         check.
2266
2267 2019-06-25  Tom Tromey  <tom@tromey.com>
2268
2269         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2270         type to void.
2271         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2272         type to void.
2273         * tui/tui-source.c (tui_set_source_content): Update.
2274         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2275
2276 2019-06-25  Tom Tromey  <tom@tromey.com>
2277
2278         * tui/tui-win.c (window_name_completer, tui_set_focus)
2279         (tui_all_windows_info): Use name method.
2280         * tui/tui-data.h (struct tui_gen_win_info)
2281         (struct tui_source_window, struct tui_disasm_window)
2282         (struct tui_data_window, struct tui_cmd_window) <name>: New
2283         method.
2284         (tui_win_name): Don't declare.
2285         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2286         (tui_win_name): Remove.
2287
2288 2019-06-25  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-winsource.h (tui_update_source_window)
2291         (tui_update_source_window_as_is): Change parameter type.
2292         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2293         to be a tui_source_window_base.
2294         (tui_update_source_window_as_is): Likewise.
2295         * tui/tui-win.c (make_visible_with_new_height): Update.
2296
2297 2019-06-25  Tom Tromey  <tom@tromey.com>
2298
2299         * tui/tui-winsource.c (tui_erase_source_content)
2300         (tui_show_source_content, tui_show_exec_info_content)
2301         (tui_erase_exec_info_content): Use refresh_window method.
2302         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2303         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2304         from tui_refresh_win.
2305         (tui_data_window::refresh_window): New method.
2306         (tui_win_info::refresh, tui_source_window_base::refresh)
2307         (tui_refresh_all): Use refresh_window method.
2308         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2309         method.
2310         * tui/tui-regs.c (tui_display_register): Call refresh_window
2311         method.
2312         * tui/tui-layout.c (show_source_disasm_command)
2313         (show_source_or_disasm_and_command): Call refresh_window method.
2314         * tui/tui-data.h (struct tui_gen_win_info)
2315         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2316         New method.
2317
2318 2019-06-25  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui.c (tui_rl_other_window, tui_enable)
2321         (tui_is_window_visible, tui_get_command_dimension): Update.
2322         * tui/tui-winsource.c (tui_update_source_window_as_is)
2323         (tui_clear_source_content, tui_erase_source_content)
2324         (tui_show_source_line, tui_source_window_base::refill)
2325         (tui_source_window_base::do_scroll_horizontal)
2326         (tui_source_window_base::set_is_exec_point_at)
2327         (tui_update_breakpoint_info, tui_set_exec_info_content)
2328         (tui_alloc_source_buffer, tui_line_is_displayed)
2329         (tui_addr_is_displayed): Update.
2330         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2331         (tui_check_and_display_highlight_if_needed)
2332         (tui_win_info::make_visible, tui_win_info::refresh)
2333         (tui_refresh_all): Update.
2334         * tui/tui-windata.c (tui_first_data_item_displayed)
2335         (tui_delete_data_content_windows, tui_erase_data_content)
2336         (tui_display_all_data, tui_data_window::refresh_all)
2337         (tui_check_data_values): Update.
2338         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2339         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2340         (tui_win_info::backward_scroll, tui_refresh_all_win)
2341         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2342         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2343         (tui_source_window_base::set_new_height)
2344         (tui_data_window::set_new_height)
2345         (make_invisible_and_set_new_height)
2346         (make_visible_with_new_height, new_height_ok)
2347         (parse_scrolling_args): Update.
2348         * tui/tui-stack.c (tui_show_frame_info): Update.
2349         * tui/tui-source.c (tui_set_source_content)
2350         (tui_set_source_content_nil, tui_source_is_displayed)
2351         (tui_source_window::do_scroll_vertical): Update.
2352         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2353         (tui_display_registers_from, tui_display_reg_element_at_line)
2354         (tui_check_register_values, tui_reg_command): Update.
2355         * tui/tui-layout.c (tui_default_win_height)
2356         (show_source_disasm_command, show_data, init_and_make_win)
2357         (show_source_or_disasm_and_command): Update.
2358         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2359         (tui_redisplay_readline, tui_mld_flush)
2360         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2361         (tui_getc): Update.
2362         * tui/tui-disasm.c (tui_set_disassem_content)
2363         (tui_disasm_window::do_scroll_vertical): Update.
2364         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2365         Now virtual.
2366         (struct tui_win_info): Derive from tui_gen_win_info.
2367         <~tui_win_info>: Mark as override.
2368         <generic>: Remove member.
2369         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2370         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2371         (~tui_data_window, ~tui_win_info)
2372         (tui_free_all_source_wins_content): Update.
2373         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2374
2375 2019-06-25  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-layout.c (init_and_make_win): Use new.
2378         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2379         destructor, initializers.
2380         (tui_alloc_generic_win_info): Don't declare.
2381         * tui/tui-data.c (_locator): Add argument to constructor.
2382         (source_win, disasm_win): New globals.
2383         (exec_info): Remove.
2384         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2385         Update.
2386         (tui_alloc_generic_win_info): Remove.
2387         (init_content_element): Use new.
2388         (tui_win_info::tui_win_info): Update.
2389         (free_content_elements) <case DATA_WIN>: Use delete.
2390
2391 2019-06-25  Tom Tromey  <tom@tromey.com>
2392
2393         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2394         * tui/tui-windata.c (tui_first_data_item_displayed)
2395         (tui_delete_data_content_windows): Update.
2396         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2397         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2398         (tui_display_registers_from, tui_check_register_values): Update.
2399         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2400         pointer.
2401         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2402         window.
2403         (tui_free_data_content): Update.
2404         (free_content_elements) <case DATA_WIN>: Free the window.
2405
2406 2019-06-25  Tom Tromey  <tom@tromey.com>
2407
2408         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2409         Update.
2410         * tui/tui-layout.c (make_command_window)
2411         (show_source_disasm_command, show_data, init_and_make_win)
2412         (show_source_or_disasm_and_command): Update.
2413         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2414         method.
2415         <can_highight, is_highlighted>: Now bool.
2416         (tui_set_win_highlight): Don't declare.
2417         * tui/tui-data.c (tui_set_win_highlight): Remove.
2418
2419 2019-06-25  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-wingeneral.c (make_visible): Remove check of window
2422         type.
2423
2424 2019-06-25  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-win.c (tui_win_info::max_height)
2427         (tui_cmd_window::max_height): New methods.
2428         (new_height_ok): Call max_height.
2429         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2430         <max_height>: New method.
2431
2432 2019-06-25  Tom Tromey  <tom@tromey.com>
2433
2434         * tui/tui-win.c (tui_source_window_base::set_new_height)
2435         (tui_data_window::set_new_height): New methods.
2436         (make_invisible_and_set_new_height): Call set_new_height method.
2437         * tui/tui-data.h (struct tui_win_info)
2438         (struct tui_source_window_base, struct tui_data_window)
2439         <set_new_height>: New method.
2440
2441 2019-06-25  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2444         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2445         tui_refresh_data_win.
2446         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2447         method.
2448         (tui_refresh_all_win): Call the refresh_all method.
2449         (tui_set_focus): Likewise.
2450         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2451         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2452         Likewise.
2453
2454 2019-06-25  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-winsource.h (tui_refill_source_window)
2457         (tui_set_is_exec_point_at): Don't declare.
2458         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2459         (tui_source_window_base::refill): Rename from
2460         tui_refill_source_window.
2461         (tui_source_window_base::do_scroll_horizontal): Update.
2462         (tui_source_window_base::set_is_exec_point_at): Rename from
2463         tui_set_is_exec_point_at.
2464         (tui_update_all_breakpoint_info): Update.
2465         * tui/tui-stack.c (tui_show_frame_info): Update.
2466         * tui/tui-layout.c (show_data): Add cast.
2467         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2468         * tui/tui-data.h (struct tui_source_window_base) <refill,
2469         set_is_exec_point_at>: New methods.
2470         (tui_source_windows, tui_add_to_source_windows): Update types.
2471         (tui_add_to_source_windows): Remove redundant declaration.
2472         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2473         (tui_source_windows): Change return type.
2474         (tui_clear_source_windows_detail): Update.
2475         (tui_add_to_source_windows): Change type of parameter.
2476         (tui_free_all_source_wins_content): Update.
2477
2478 2019-06-25  Tom Tromey  <tom@tromey.com>
2479
2480         * tui/tui-wingeneral.c (tui_win_info::refresh)
2481         (tui_source_window_base::refresh): New methods.
2482         (tui_refresh_all): Call the refresh method.
2483         * tui/tui-data.h (struct tui_win_info)
2484         (struct tui_source_window_base) <refresh>: New method.
2485
2486 2019-06-25  Tom Tromey  <tom@tromey.com>
2487
2488         * tui/tui.h (tui_is_window_visible): Return bool.
2489         * tui/tui.c (tui_is_window_visible): Return bool.
2490         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2491         (tui_make_visible, tui_make_invisible)
2492         (tui_win_info::make_visible)
2493         (tui_source_window_base::make_visible, make_all_visible)
2494         (tui_make_all_visible, tui_make_all_invisible): Update.
2495         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2496         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2497         bool.
2498         (struct tui_win_info, struct tui_source_window_base)
2499         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2500         * tui/tui-data.c (tui_init_generic_part): Update.
2501
2502 2019-06-25  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2505         (tui_source_window_base::make_visible): New methods.
2506         (make_all_visible): Make method call.
2507         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2508         (struct tui_source_window_base, struct tui_cmd_window): Override
2509         make_visible.
2510         (tui_win_is_source_type): Don't declare.
2511         * tui/tui-data.c (tui_win_is_source_type): Remove.
2512
2513 2019-06-25  Tom Tromey  <tom@tromey.com>
2514
2515         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2516         NULL check.
2517
2518 2019-06-25  Tom Tromey  <tom@tromey.com>
2519
2520         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2521         Inline constructor.  Add initializers for members.
2522         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2523         constructors; now inline in class.
2524
2525 2019-06-25  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-regs.c (tui_show_registers): Update.
2528         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2529         bool.
2530         * tui/tui-data.c (tui_data_window::clear_detail)
2531         (tui_data_window): Update.
2532
2533 2019-06-25  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-windata.c (tui_display_all_data)
2536         (tui_display_data_from_line, tui_display_data_from)
2537         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2538         Update.
2539         * tui/tui-regs.c (tui_last_regs_line_no)
2540         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2541         (tui_show_registers, tui_show_register_group)
2542         (tui_display_registers_from, tui_display_reg_element_at_line)
2543         (tui_display_registers_from_line, tui_check_register_values)
2544         (tui_reg_next, tui_reg_prev): Update.
2545         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2546         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2547         tui_data_window.
2548         (struct tui_win_info) <detail>: Remove.  Add new fields from
2549         tui_data_info.
2550         (TUI_DATA_WIN): Add cast.
2551         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2552         (~tui_data_window): Simplify.
2553
2554 2019-06-25  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-layout.c (show_source_disasm_command)
2557         (show_source_or_disasm_and_command): Update.
2558         * tui/tui-io.c (update_cmdwin_start_line)
2559         (tui_redisplay_readline): Update.
2560         * tui/tui-data.h (struct tui_command_info): Remove.
2561         (struct tui_win_info) <detail>: Remove command_info member.
2562         (struct tui_data_window) <start_line>: New member, from
2563         tui_command_info.
2564         (TUI_CMD_WIN): Add casts.
2565
2566 2019-06-25  Tom Tromey  <tom@tromey.com>
2567
2568         * tui/tui-winsource.c (tui_update_source_window)
2569         (tui_refill_source_window)
2570         (tui_source_window_base::do_scroll_horizontal)
2571         (tui_update_breakpoint_info, tui_set_exec_info_content)
2572         (tui_show_exec_info_content, tui_erase_exec_info_content)
2573         (tui_clear_exec_info_content): Update.
2574         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2575         Update.
2576         * tui/tui-win.c (make_invisible_and_set_new_height)
2577         (make_visible_with_new_height): Update.
2578         * tui/tui-source.c (tui_set_source_content)
2579         (tui_show_symtab_source): Update.
2580         * tui/tui-layout.c (extract_display_start_addr)
2581         (show_source_disasm_command, show_data)
2582         (make_source_or_disasm_window)
2583         (show_source_or_disasm_and_command): Update.
2584         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2585         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2586         "gdbarch".
2587         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2588         to tui_source_window_base.
2589         (struct tui_win_info) <detail>: Remove source_info member.
2590         (struct tui_source_window_base) <has_locator>: Inline.
2591         Move contents from tui_source_info; rename has_locator member to
2592         m_has_locator.
2593         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2594         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2595         header file.
2596         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2597         Simplify.
2598         (tui_free_all_source_wins_content): Cast to
2599         tui_source_window_base.
2600
2601 2019-06-25  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-win.c (make_invisible_and_set_new_height)
2604         (make_visible_with_new_height): Call has_locator method.
2605         * tui/tui-layout.c (show_source_disasm_command, show_data)
2606         (show_source_or_disasm_and_command): Update for bool change.
2607         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2608         (tui_win_info) <has_locator>: New method.
2609         (struct tui_source_window_base) <has_locator>: New method.
2610         (tui_win_has_locator): Don't declare.
2611         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2612         from tui_win_has_locator.
2613         (tui_source_window_base): Use false, not FALSE.
2614
2615 2019-06-25  Tom Tromey  <tom@tromey.com>
2616
2617         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2618         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2619         clear_detail method directly.
2620         (tui_clear_win_detail): Remove.
2621
2622 2019-06-25  Tom Tromey  <tom@tromey.com>
2623
2624         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2625         "this", not TUI_DISASM_WIN.
2626
2627 2019-06-25  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2630         declare.
2631         * tui/tui-winsource.c
2632         (tui_source_window_base::do_scroll_horizontal): Rename from
2633         tui_horizontal_source_scroll.
2634         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2635         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2636         from tui_vertical_data_scroll.
2637         * tui/tui-win.h (tui_scroll): Don't declare.
2638         * tui/tui-win.c (tui_win_info::forward_scroll)
2639         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2640         (tui_win_info::right_scroll): Rename and update.
2641         (tui_scroll_forward_command, tui_scroll_backward_command)
2642         (tui_scroll_left_command, tui_scroll_right_command): Update.
2643         (tui_scroll): Remove.
2644         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2645         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2646         from tui_vertical_source_scroll.
2647         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2648         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2649         from tui_vertical_disassem_scroll.
2650         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2651         do_scroll_horizontal>: New methods.
2652         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2653         Likewise.
2654         (struct tui_source_window_base): Add do_scroll_horizontal.
2655         (struct tui_source_window, struct tui_disasm_window): Add
2656         do_scroll_vertical.
2657         (struct tui_data_window, struct tui_cmd_window): Add
2658         do_scroll_horizontal and do_scroll_vertical.
2659         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2660
2661 2019-06-25  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-data.h (struct tui_source_window_base): New struct.
2664         (struct tui_source_window): Derive from tui_source_window_base.
2665         (struct tui_disasm_window): New struct.
2666         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2667         from tui_source_window::clear_detail.
2668         (tui_source_window_base): Rename from tui_source_window.
2669         (~tui_source_window_base): Rename from ~tui_source_window.
2670         (tui_alloc_win_info): Create a tui_disasm_window.
2671
2672 2019-06-25  Tom Tromey  <tom@tromey.com>
2673
2674         * tui/tui-data.h (struct tui_source_window)
2675         (struct tui_data_window): Declare destructors.
2676         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2677         destructors.
2678         (tui_win_info): Simplify.
2679
2680 2019-06-25  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-winsource.c (tui_display_main)
2683         (tui_update_source_windows_with_addr)
2684         (tui_update_all_breakpoint_info): Update.
2685         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2686         (new_height_ok, parse_scrolling_args): Update.
2687         * tui/tui-stack.c (tui_show_frame_info): Update.
2688         * tui/tui-data.h (struct tui_list): Remove.
2689         (tui_source_windows): Return a reference to a std::vector.
2690         * tui/tui-data.c (source_windows): Now a std::vector.
2691         (tui_source_windows): Change return type.
2692         (tui_clear_source_windows): Rewrite.
2693         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2694         (tui_free_all_source_wins_content): Rewrite.
2695
2696 2019-06-25  Tom Tromey  <tom@tromey.com>
2697
2698         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2699         (struct tui_data_window, struct tui_cmd_window): Declare
2700         clear_detail method.
2701         * tui/tui-data.c (tui_source_window::clear_detail)
2702         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2703         methods.
2704         (tui_clear_win_detail): Simplify.
2705
2706 2019-06-25  Tom Tromey  <tom@tromey.com>
2707
2708         * tui/tui-layout.c (make_source_window, make_disasm_window)
2709         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2710         Return the new window.
2711         (show_source_disasm_command, show_data)
2712         (show_source_or_disasm_and_command): Update.
2713
2714 2019-06-25  Tom Tromey  <tom@tromey.com>
2715
2716         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2717         parameter.  Return the new window.
2718         (show_source_disasm_command): Update and remove NULL check.
2719         (show_source_or_disasm_and_command): Update.
2720
2721 2019-06-25  Tom Tromey  <tom@tromey.com>
2722
2723         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2724
2725 2019-06-25  Tom Tromey  <tom@tromey.com>
2726
2727         * tui/tui-data.h (struct tui_win_info): Make constructor
2728         protected.  Make destructor virtual.  Add initializers.
2729         (tui_source_window, tui_data_window, tui_cmd_window): New
2730         classes.
2731         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2732         constructor.  Add "type" parameter.
2733         (tui_source_window, tui_data_window, tui_cmd_window): New
2734         constructors.
2735         (tui_alloc_win_info): Instantiate the appropriate subclass.
2736
2737 2019-06-25  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-win.c (tui_resize_all): Use delete.
2740         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2741         destructor.
2742         (tui_free_window): Don't declare.
2743         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2744         Update.
2745
2746 2019-06-25  Tom Tromey  <tom@tromey.com>
2747
2748         * tui/tui-data.h (struct tui_win_info): Add constructor.
2749         * tui/tui-data.c (tui_alloc_win_info): Use new.
2750         (tui_free_window): Use delete.
2751
2752 2019-06-22  Tom Tromey  <tom@tromey.com>
2753
2754         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2755         declare.
2756         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2757
2758 2019-06-22  Tom Tromey  <tom@tromey.com>
2759
2760         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2761         declare.
2762         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2763
2764 2019-06-22  Tom de Vries  <tdevries@suse.de>
2765
2766         * dwarf2read.c (create_addrmap_from_aranges)
2767         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2768         instead of '%zu'.
2769
2770 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2771
2772         * dwarf2read.h (dwarf2_section_info_def): Remove.
2773         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2774         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2775         std::vector<dwarf2_section_info>.
2776         (struct dwo_file) <~dwo_file>: Remove.
2777         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2778         types field.
2779         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2780         (dwarf2_read_debug_names): Likewise.
2781         (create_debug_types_hash_table): Change parameter type to
2782         array_view, adjust code accordingly.
2783         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2784         (partial_die_info::fixup): Likewise.
2785         (determine_prefix): Likewise.
2786         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2787
2788 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2789
2790         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2791         gdb_bfd_ref_ptr.
2792         <~dwo_file>: Remove call to gdb_bfd_unref.
2793         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2794         gdb_bfd_ref_ptr::get.
2795
2796 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2797
2798         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2799         type to htab_up.
2800         * dwarf2read.c (struct dwo_file): Initialize fields.
2801         <~dwo_file>: New.
2802         (free_dwo_file): Remove, move content to ~dwo_file.
2803         (struct dwo_file_deleter): Remove.
2804         (dwo_file_up>: Remove custom deleter.
2805         (free_dwo_files): Remove.
2806         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2807         dwo_files.
2808         (process_skeletonless_type_units): Call unique_ptr::get.
2809         (allocate_dwo_file_hash_table): Add deleter to created hash
2810         table.  Change return type to htab_up.
2811         (lookup_dwo_file_slot): Don't memset dwo_file, call
2812         unique_ptr::get.
2813         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2814         (create_dwo_unit_in_dwp_v2): Likewise.
2815         (open_and_init_dwo_file): Likewise.
2816         (free_dwo_file_from_slot): Remove.
2817
2818 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2819
2820         * dwarf2read.h (struct dwarf2_section_info) <readin,
2821         is_virtual>: Change type to bool.
2822         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2823         true instead of 1.
2824
2825 2019-06-19  Tom Tromey  <tom@tromey.com>
2826
2827         * tui/tui-data.h (tui_init_content_element): Don't declare.
2828
2829 2019-06-19  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-data.h (tui_init_win_info): Don't declare.
2832
2833 2019-06-19  Tom de Vries  <tdevries@suse.de>
2834
2835         * dwarf2read.h (abstract_to_concrete): Change type to
2836         std::unordered_map<sect_offset, std::vector<sect_offset>,
2837         gdb::hash_enum<sect_offset>>.
2838
2839 2019-06-19  Tom Tromey  <tromey@adacore.com>
2840
2841         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2842         EVAL_AVOID_SIDE_EFFECTS specially.
2843
2844 2019-06-19  Tom Tromey  <tromey@adacore.com>
2845
2846         * source-cache.c (highlighter): New global.
2847         (source_cache::get_source_lines): Create a highlighter on demand.
2848
2849 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2850
2851         * defs.h (deprecated_interactive_hook): Delete declaration.
2852         * interps.c (clear_interpreter_hooks): Remove use of
2853         deprecated_interactive_hook.
2854         * top.c (deprecated_interactive_hook): Delete definition.
2855         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2856
2857 2019-06-18  Tom de Vries  <tdevries@suse.de>
2858
2859         PR gdb/24515
2860         * dwarf2read.h (abstract_to_concrete): Change type from
2861         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2862         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2863         * dwarf2read.c (read_variable): Update.
2864         (dwarf2_fetch_die_loc_sect_off): Update.
2865
2866 2019-06-17  Tom de Vries  <tdevries@suse.de>
2867
2868         PR gdb/24617
2869         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2870         accessing parent[parent_len - 1].
2871
2872 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2873
2874         PR gdb/24364
2875         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2876         call dtrace_process_dof with NULL dof.
2877
2878 2019-06-16  Tom de Vries  <tdevries@suse.de>
2879
2880         PR gdb/24445
2881         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2882
2883 2019-06-16  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2886         (make_all_visible): Use address of member.
2887
2888 2019-06-16  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2891         (tui_free_window, free_content, free_content_elements): Remove
2892         unnecessary cast.
2893         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2894         cast.
2895         * tui/tui-regs.c (tui_show_register_group)
2896         (tui_display_registers_from, tui_display_reg_element_at_line):
2897         Remove unnecessary cast.
2898
2899 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * linux-nat.c (normal_mask): Delete.
2902         (_initialize_linux_nat): Don't initialise normal_mask.
2903
2904 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2905
2906         PR gdb/24445
2907         * dwarf-index-write.h (write_psymtabs_to_index): Add
2908         dwz_basename parameter.
2909         * dwarf-index-write.c (write_gdbindex): Move file writing to
2910         write_gdbindex_1.  Change return type void.
2911         (assert_file_size): Move up, remove filename parameter.
2912         (write_gdbindex_1): New function.
2913         (write_debug_names): Change return type to void, call
2914         assert_file_size.
2915         (struct index_wip_file): New struct.
2916         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2917         file logic to index_wip_file.  Write index for dwz file if
2918         needed.
2919         (save_gdb_index_command): Pass basename of dwz file, if present.
2920         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2921         build-id of dwz file, if present.
2922         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2923         (dwarf2_get_dwz_file): Likewise.
2924         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2925         (dwarf2_get_dwz_file): Likewise.
2926
2927 2019-06-16  Tom Tromey  <tom@tromey.com>
2928
2929         * coffread.c (process_coff_symbol): Use xstrdup.
2930         * value.c (create_internalvar): Use xstrdup.
2931
2932 2019-06-16  Tom Tromey  <tom@tromey.com>
2933
2934         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2935         * breakpoint.c (stopin_command, stopat_command)
2936         (until_break_command, decode_location_default): Remove unnecessary
2937         cast.
2938         * utils.c (subset_compare): Remove unnecessary cast.
2939         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2940         cast.
2941         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2942         cast.
2943         * infcmd.c (path_command): Remove unnecessary cast.
2944         * coffread.c (decode_type): Remove unnecessary cast.
2945         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2946         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2947         * tui/tui-stack.c (tui_show_locator_content)
2948         (tui_show_frame_info): Remove unnecessary cast.
2949         * tui/tui-win.c (tui_scroll_forward_command)
2950         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2951         (parse_scrolling_args): Remove unnecessary cast.
2952         * tui/tui-data.c (init_win_info, tui_del_window)
2953         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2954         (free_content_elements): Remove unnecessary cast.
2955         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2956         unnecessary cast.
2957         * tui/tui-source.c (tui_set_source_content)
2958         (tui_vertical_source_scroll): Remove unnecessary cast.
2959         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2960         cast.
2961         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2962         * tui/tui-regs.c (tui_display_registers_from)
2963         (tui_display_register): Remove unnecessary cast.
2964         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2965         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2966         (make_visible): Remove unnecessary cast.
2967         * tui/tui-winsource.c (tui_erase_source_content)
2968         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2969         unnecessary cast.
2970         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2971         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2972         * stabsread.c (read_type, read_array_type, read_range_type):
2973         Remove unnecessary cast.
2974         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2975         (parse_symbol, parse_type, upgrade_type, parse_external)
2976         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2977         unnecessary cast.
2978         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2979
2980 2019-06-16  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui-data.c (tui_alloc_generic_win_info)
2983         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2984         checks.
2985
2986 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2987             Andrew Burgess  <andrew.burgess@embecosm.com>
2988
2989         * f-typeprint.c (f_print_type): Don't return early for not
2990         associated or not allocated types.
2991         (f_type_print_varspec_suffix): Add print_rank parameter and print
2992         ranks of array types in case they dangling.
2993         (f_type_print_base): Add print_rank parameter.
2994
2995 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * NEWS: Mention new MI commands.
2998         * break-catch-throw.c (enum exception_event_kind): Move to
2999         breakpoint.h.
3000         (print_mention_exception_catchpoint): Output text as a single
3001         message.
3002         (catch_exception_command_1): Rename to...
3003         (catch_exception_event): ...this, make non-static, update header
3004         command, and change some parameter types.
3005         (catch_catch_command): Update for changes to
3006         catch_exception_command_1.
3007         (catch_throw_command): Likewise.
3008         (catch_rethrow_command): Likewise.
3009         * breakpoint.c (enum exception_event_kind): Delete.
3010         * breakpoint.h (enum exception_event_kind): Moved here from
3011         break-catch-throw.c.
3012         (catch_exception_event): Declare.
3013         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3014         (mi_cmd_catch_throw): New function.
3015         (mi_cmd_catch_rethrow): New function.
3016         (mi_cmd_catch_catch): New function.
3017         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3018         'catch-catch' entries.
3019         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3020         (mi_cmd_catch_rethrow): Declare.
3021         (mi_cmd_catch_catch): Declare.
3022
3023 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3024
3025         * annotate.c (annotate_source_line): Change return type to void,
3026         update implementation to match.
3027         * annotate.h (annotate_source_line): Change return type to void,
3028         update header comment.
3029         * stack.c (print_frame_info): Don't change what frame information
3030         is printed based on whether annotations are on or not.
3031
3032 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3035         (annotate_source): Make static.
3036         (annotate_source_line): Moved from source.c and renamed from
3037         identify_source_line.  Update the return type.
3038         * annotate.h (annotate_source): Delete declaration.
3039         (annotate_source_line): Declaration moved from source.h, and
3040         renamed from identify_source_line.  Return type updated.
3041         * source.c (identify_source_line): Moved to annotate.c and renamed
3042         to annotate_source_line.
3043         (info_line_command): Remove check of annotation_level.
3044         * source.h (identify_source_line): Move declaration to annotate.h
3045         and rename to annotate_source_line.
3046         * stack.c: Add 'annotate.h' include.
3047         (print_frame_info): Remove check of annotation_level before
3048         calling annotate_source_line.
3049
3050 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3051
3052         * source-cache.c (source_cache::get_plain_source_lines): Use
3053         open_source_file_with_line_charpos instead of just
3054         open_source_file, remove call to find_source_lines.
3055         (source_cache::get_source_lines): Likewise.
3056         * source.c (find_source_lines): Make static.
3057         (get_filename_and_charpos): Renamed into...
3058         (open_source_file_with_line_charpos): ..this along with changes to
3059         return a scoped_fd, and some other minor clean ups.
3060         (identify_source_line): Use open_source_file_with_line_charpos.
3061         (search_command_helper): Use open_source_file_with_line_charpos
3062         instead of just open_source_file, remove call to
3063         find_source_lines.
3064         * source.h (open_source_file_with_line_charpos): Declare new
3065         function.
3066         (find_source_lines): Delete declaration.
3067
3068 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * source.c (get_filename_and_charpos): Remove fullname
3071         parameter.
3072         (identify_source_line): Update call to get_filename_and_charpos.
3073
3074 2019-06-14  Tom Tromey  <tromey@adacore.com>
3075
3076         PR gdb/24502:
3077         * ui-style.h (skip_ansi_escape): Update comment.
3078         * ui-file.h (class no_terminal_escape_file): New class.
3079         * ui-file.c (no_terminal_escape_file::write)
3080         (no_terminal_escape_file::puts): New methods.
3081         * cli/cli-logging.c (handle_redirections): Use
3082         no_terminal_escape_file.
3083
3084 2019-06-14  Tom Tromey  <tromey@adacore.com>
3085
3086         * NEWS: Move convenience variable news above Python news.
3087
3088 2019-06-14  Tom Tromey  <tom@tromey.com>
3089
3090         * gnulib: Move directory to top-level.
3091         * configure.ac: Don't configure gnulib.
3092         * configure: Rebuild.
3093         * common/common-defs.h: Use new path to gnulib.
3094         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3095         (GNULIB_H): Remove.
3096         (INCGNU): Look in new gnulib location.
3097         (HFILES_NO_SRCDIR): Remove gnulib files.
3098         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3099         (generated_files): Remove GNULIB_H.
3100         ($(LIBGNU), all-lib): Remove targets.
3101         (distclean): Don't mention GNULIB_BUILDDIR.
3102         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3103
3104 2019-06-14  Tom Tromey  <tromey@adacore.com>
3105
3106         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3107         Warn if symbol file does not provide any symbols.
3108
3109 2019-06-14  Tom Tromey  <tromey@adacore.com>
3110
3111         * source.c (find_and_open_source): Respect basenames_may_differ.
3112
3113 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3114
3115         * annotate.c (annotate_breakpoints_invalid): Make use of
3116         scoped_restore_terminal_state.
3117         (annotate_frames_invalid): Likewise.
3118
3119 2019-06-14  Tom Tromey  <tromey@adacore.com>
3120
3121         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3122         allow assignment to an internalvar.
3123
3124 2019-06-14  Tom Tromey  <tromey@adacore.com>
3125
3126         * ada-lex.l: Allow "_" in attribute names.
3127
3128 2019-06-14  Tom Tromey  <tromey@adacore.com>
3129
3130         PR gdb/24653:
3131         * regcache.c (registers_changed): Don't call alloca.
3132         * top.c (execute_command): Don't call alloca.
3133
3134 2019-06-13  Pedro Alves  <palves@redhat.com>
3135
3136         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3137         'expression'.  When parsing an expression, error out if there's
3138         junk after "unlimited".
3139         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3140         (do_set_command): Adjust calls to is_unlimited_literal.
3141
3142 2019-06-13  Pedro Alves  <palves@redhat.com>
3143
3144         * compile/compile.c (make_compile_options_def_group): Add braces
3145         around array_view initializer.
3146         * thread.c (make_thread_apply_all_options_def_group)
3147         (make_thread_apply_all_options_def_group): Likewise.
3148
3149 2019-06-13  Pedro Alves  <palves@redhat.com>
3150
3151         * NEWS (New commands): Mention "maint test-options
3152         require-delimiter", "maint test-options unknown-is-error", "maint
3153         test-options unknown-is-operand" and "maint show
3154         test-options-completion-result".
3155         (New command options, command completion): New section.
3156         (Completion improvements): New section.
3157         Mention that you can abbreviate "unlimited".
3158
3159 2019-06-13  Pedro Alves  <palves@redhat.com>
3160
3161         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3162         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3163         * unittests/cli-utils-selftests.c (test_parse_flags)
3164         (test_parse_flags_qcs): Delete.
3165         (test_cli_utils): Don't call deleted functions.
3166
3167 2019-06-13  Pedro Alves  <palves@redhat.com>
3168
3169         * thread.c: Include "cli/cli-option.h".
3170         (tp_array_compar_ascending): Global.
3171         (tp_array_compar): Delete function.
3172         (tp_array_compar_ascending, tp_array_compar_descending): New
3173         functions.
3174         (ascending_option_def, qcs_flag_option_def)
3175         (thr_qcs_flags_option_defs)
3176         (make_thread_apply_all_options_def_group)
3177         (make_thread_apply_options_def_group): New.
3178         (thread_apply_all_command): Use gdb::option::process_options.
3179         (thread_apply_command_completer)
3180         (thread_apply_all_command_completer): New.
3181         (thread_apply_command): Use gdb::option::process_options.
3182         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3183         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3184         to generate help text of "thread apply".  Adjust "taas"'s help.
3185         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3186         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3187
3188 2019-06-13  Pedro Alves  <palves@redhat.com>
3189
3190         * thread.c (thread_apply_command): Check for invalid TID with
3191         isdigit instead of !isalpha.
3192
3193 2019-06-13  Pedro Alves  <palves@redhat.com>
3194
3195         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3196         (validate_flags_qcs): New.
3197         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3198         (validate_flags_qcs): Declare.
3199         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3200         (make_frame_apply_options_def_group): New.
3201         (frame_apply_command_count): Process options with
3202         gdb::option::process_options.
3203         (frame_apply_completer): New.
3204         (frame_apply_level_completer, frame_apply_all_completer)
3205         (frame_apply_completer): New.
3206         (_initialize_stack): Update help of "frame apply", "frame apply
3207         level", "frame apply all" and "faas" to mention supported options
3208         and install command completers.
3209         * stack.h (frame_apply_all_completer): Declare.
3210         * thread.c: Include "stack.h".
3211         (tfaas_command): Add "--".
3212         (_initialize_thread): Update help "tfaas" to mention supported
3213         options and install command completer.
3214
3215 2019-06-13  Pedro Alves  <palves@redhat.com>
3216
3217         * completer.c (complete_nested_command_line): New.
3218         (gdb_completion_word_break_characters_throw): Add assertion.
3219         * completer.h (complete_nested_command_line): Declare.
3220
3221 2019-06-13  Pedro Alves  <palves@redhat.com>
3222
3223         * stack.c (parse_backtrace_qualifiers): New.
3224         (backtrace_command): Use it.
3225         (backtrace_command_completer): Complete on qualifiers.
3226
3227 2019-06-13  Pedro Alves  <palves@redhat.com>
3228
3229         * frame.c: Include "cli/cli-option.h.
3230         (user_set_backtrace_options): New.
3231         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3232         Delete.
3233         (get_prev_frame): Adjust.
3234         (boolean_option_def, uinteger_option_def)
3235         (set_backtrace_option_defs): New.
3236         (_initialize_frame): Adjust and use
3237         gdb::option::add_setshow_cmds_for_options to install "set
3238         backtrace past-main" and "set backtrace past-entry".
3239         * frame.h: Include "cli/cli-option.h".
3240         (struct frame_print_options): Forward declare.
3241         (print_frame_arguments_all, print_frame_arguments_scalars)
3242         (print_frame_arguments_none): Declare.
3243         (print_entry_values): Delete declaration.
3244         (struct frame_print_options, user_frame_print_options): New.
3245         (struct set_backtrace_options): New.
3246         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3247         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3248         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3249         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3250         (list_args_or_locals): Add frame_print_options parameter.
3251         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3252         * python/py-framefilter.c (enumerate_args): Pass down
3253         USER_FRAME_PRINT_OPTIONS.
3254         * stack.c: Include "cli/cli-option.h".
3255         (print_frame_arguments_all, print_frame_arguments_scalars)
3256         (print_frame_arguments_none): Declare.
3257         (print_raw_frame_arguments, print_entry_values): Delete.
3258         (user_frame_print_options): New.
3259         (boolean_option_def, enum_option_def, frame_print_option_defs):
3260         New.
3261         (struct backtrace_cmd_options): New.
3262         (bt_flag_option_def): New.
3263         (backtrace_command_option_defs): New.
3264         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3265         (print_frame_arg, read_frame_arg, print_frame_args)
3266         (print_frame_info, print_frame): Add frame_print_options parameter
3267         and use it.
3268         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3269         (backtrace_command_1): Add frame_print_options and
3270         backtrace_cmd_options parameters and use them.
3271         (make_backtrace_options_def_group): New.
3272         (backtrace_command): Process command options with
3273         gdb::option::process_options.
3274         (backtrace_command_completer): New.
3275         (_initialize_stack): Extend "backtrace"'s help to mention
3276         supported options.  Install completer for "backtrace".
3277         Install some settings commands with add_setshow_cmds_for_options.
3278
3279 2019-06-13  Pedro Alves  <palves@redhat.com>
3280
3281         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3282         and that "set/show print raw frame-arguments" are now deprecated.
3283
3284         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3285         command.
3286         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3287         * stack.c (_initialize_stack): Install "set/show print
3288         raw-frame-arguments", and deprecate "set/show print raw
3289         frame-arguments".
3290         * valprint.c (_initialize_valprint): Deprecate "set/show print
3291         raw".
3292
3293 2019-06-13  Pedro Alves  <palves@redhat.com>
3294
3295         * compile/compile.c (struct compile_options): New.
3296         (compile_flag_option_def, compile_command_option_defs)
3297         (make_compile_options_def_group): New.
3298         (compile_file_command): Handle options with
3299         gdb::option::process_options.
3300         (compile_file_command_completer): New function.
3301         (compile_code_command): Handle options with
3302         gdb::option::process_options.
3303         (compile_code_command_completer): New function.
3304         (_initialize_compiler): Install completers for "compile code" and
3305         "compile file".  Mention available options in "compile code" and
3306         "compile code"'s help.
3307         * completer.c (advance_to_completion_word): New, factored out from
3308         ...
3309         (advance_to_expression_complete_word_point): ... this.
3310         (advance_to_filename_complete_word_point): New.
3311         * completer.h (advance_to_filename_complete_word_point): New
3312         declaration.
3313
3314 2019-06-13  Pedro Alves  <palves@redhat.com>
3315
3316         * compile/compile.c: Include "cli/cli-option.h".
3317         (compile_print_value): Scope data pointer is now a
3318         value_print_options pointer; adjust.
3319         (compile_print_command): Process options.  Scope data pointer is
3320         now a value_print_options pointer; adjust.
3321         (_initialize_compile): Update "compile print"'s help to include
3322         supported options.  Install a completer for "compile print".
3323         * cp-valprint.c (show_vtblprint, show_objectprint)
3324         (show_static_field_print): Delete.
3325         (_initialize_cp_valprint): Don't install "set print
3326         static-members", "set print vtbl", "set print object" here.
3327         * printcmd.c: Include "cli/cli-option.h" and
3328         "common/gdb_optional.h".
3329         (print_command_parse_format): Rework to fill in a
3330         value_print_options instead of a format_data.
3331         (print_value): Change parameter type from format_data pointer to
3332         value_print_options reference.  Adjust.
3333         (print_command_1): Process options.  Adjust to pass down a
3334         value_print_options.
3335         (print_command_completer): New.
3336         (_initialize_printcmd): Install print_command_completer as
3337         handle_brkchars completer for the "print" command.  Update
3338         "print"'s help to include supported options.
3339         * valprint.c: Include "cli/cli-option.h".
3340         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3341         here from cp-valprint.c.
3342         (boolean_option_def, uinteger_option_def)
3343         (value_print_option_defs, make_value_print_options_def_group):
3344         New.  Use gdb::option::add_setshow_cmds_for_options to install
3345         "set print elements", "set print null-stop", "set print repeats",
3346         "set print pretty", "set print union", "set print array", "set
3347         print address", "set print symbol", "set print array-indexes".
3348         * valprint.h: Include <string> and "cli/cli-option.h".
3349         (make_value_print_options_def_group): Declare.
3350         (print_value): Change parameter type from format_data pointer to
3351         value_print_options reference.
3352         (print_command_completer): Declare.
3353
3354 2019-06-13  Pedro Alves  <palves@redhat.com>
3355
3356         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3357         (COMMON_SFILES): Add maint-test-settings.c.
3358         * cli/cli-decode.c (boolean_enums): New global, factored out from
3359         ...
3360         (add_setshow_boolean_cmd): ... here.
3361         * cli/cli-decode.h (boolean_enums): Declare.
3362         * cli/cli-option.c: New file.
3363         * cli/cli-option.h: New file.
3364         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3365         factored out from ...
3366         (parse_cli_boolean_value(const char *)): ... this.
3367         (is_unlimited_literal): Change parameter type to pointer to
3368         pointer.  Adjust and advance ARG pointer.
3369         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3370         (parse_cli_var_enum): New, factored out from ...
3371         (do_set_command): ... this.  Adjust.
3372         * cli/cli-setshow.h (parse_cli_boolean_value)
3373         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3374         (parse_cli_var_enum): Declare.
3375         * cli/cli-utils.c: Include "cli/cli-option.h".
3376         (get_ulongest): New.
3377         * cli/cli-utils.h (get_ulongest): Declare.
3378         (check_for_argument): New overloads.
3379         * maint-test-options.c: New file.
3380
3381 2019-06-13  Pedro Alves  <palves@redhat.com>
3382
3383         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3384         parse a range if "-" is at the end of the string.
3385
3386 2019-06-13  Pedro Alves  <palves@redhat.com>
3387
3388         * cli/cli-setshow.c (parse_auto_binary_operation)
3389         (parse_cli_boolean_value): Don't allow "o".
3390
3391 2019-06-13  Pedro Alves  <palves@redhat.com>
3392
3393         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3394         * NEWS: Mention maint test-settings KIND.
3395         * maint-test-settings.c: New file.
3396
3397 2019-06-13  Pedro Alves  <palves@redhat.com>
3398
3399         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3400         completer.
3401         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3402         "set" completers.
3403
3404 2019-06-13  Pedro Alves  <palves@redhat.com>
3405
3406         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3407         after item.
3408
3409 2019-06-13  Pedro Alves  <palves@redhat.com>
3410
3411         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3412
3413 2019-06-13  Pedro Alves <palves@redhat.com>
3414
3415         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3416         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3417         call.
3418         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3419         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3420         calls.
3421         (check_for_argument): Skip spaces after argument.
3422
3423 2019-06-13  Pedro Alves  <palves@redhat.com>
3424
3425         * thread.c (thread_apply_command): Adjust TID parsing.
3426         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3427         detected before end of string.
3428         (tid_is_in_list): Error out if LIST is invalid.
3429
3430 2019-06-13  Pedro Alves  <palves@redhat.com>
3431
3432         * completer.c (complete_line_internal_1): Rewind completion word
3433         point.
3434         (completion_tracker::advance_custom_word_point_by): Change
3435         parameter type to int.
3436         * completer.h (completion_tracker::advance_custom_word_point_by):
3437         Likewise.
3438
3439 2019-06-13  Pedro Alves  <palves@redhat.com>
3440
3441         * completer.c (advance_to_completion_word): Handle delimiters.
3442
3443 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3444
3445         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3446
3447 2019-06-11  Tom Tromey  <tom@tromey.com>
3448
3449         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3450         (xmalloc_failed): Move to alloc.c.
3451         * alloc.c: New file.
3452         * Makefile.in (COMMON_SFILES): Add alloc.c.
3453
3454 2019-06-11  Tom Tromey  <tom@tromey.com>
3455
3456         * nat/linux-waitpid.c: Don't include server.h.
3457         (linux_debug): Remove.
3458         (my_waitpid): Update.
3459
3460 2019-06-11  Tom Tromey  <tromey@adacore.com>
3461
3462         * infcall.c (_initialize_infcall): Remove trailing newline from
3463         help.
3464         * user-regs.c (_initialize_user_regs): Remove trailing newline
3465         from help.
3466         * typeprint.c (_initialize_typeprint): Remove trailing newline
3467         from help.
3468         * reverse.c (_initialize_reverse): Remove trailing newlines from
3469         help.
3470         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3471         from help.
3472         * language.c (add_set_language_command): Remove trailing newline
3473         from help.
3474         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3475         help.
3476         * disasm.c (_initialize_disasm): Remove trailing newline from
3477         help.
3478         * top.c (init_main): Remove trailing newline from help.
3479         * interps.c (_initialize_interpreter): Remove trailing newline
3480         from help.
3481         * btrace.c (_initialize_btrace): Remove trailing newlines from
3482         help.
3483         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3484         from help.
3485         * python/python.c (_initialize_python): Remove trailing newline
3486         from help.
3487         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3488         help.
3489         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3490         from help.  Reformat some text.
3491         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3492         from help.
3493         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3494         newline from help.
3495
3496 2019-06-11  Tom Tromey  <tromey@adacore.com>
3497
3498         * darwin-nat.c (darwin_decode_exception_message)
3499         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3500
3501 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3502
3503         * valops.c (value_slice): Check for not allocated or not
3504         associated values.
3505
3506 2019-06-10  Tom de Vries  <tdevries@suse.de>
3507
3508         PR gdb/24618
3509         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3510         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3511         invalid.
3512
3513 2019-06-10  Tom de Vries  <tdevries@suse.de>
3514
3515         PR gdb/24611
3516         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3517         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3518
3519 2019-06-10  Tom de Vries  <tdevries@suse.de>
3520
3521         PR symtab/24545
3522         * symtab.c (struct demangled_name_entry): Add language field.
3523         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3524         static minimal symbol".  Set and use language field.
3525
3526 2019-06-10  Tom Tromey  <tromey@adacore.com>
3527
3528         * ada-lang.c (_initialize_ada_language): Update help text.
3529
3530 2019-06-10  Tom Tromey  <tromey@adacore.com>
3531
3532         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3533         with a newline.
3534         * guile/guile.c (handle_boot_error): Don't end warning with a
3535         newline.
3536         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3537         warning with a newline.
3538         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3539         newline.
3540         (s12z_frame_cache): Likewise.
3541         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3542         a newline.
3543         * solib-svr4.c (disable_probes_interface): Don't end warning with
3544         a newline.
3545         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3546         newline.
3547         * python/python.c (do_finish_initialization): Don't end warning
3548         with a newline.
3549
3550 2019-06-10  Tom Tromey  <tom@tromey.com>
3551
3552         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3553         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3554         gdbpy_enter.
3555
3556 2019-06-10  Tom Tromey  <tromey@adacore.com>
3557
3558         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3559         data.
3560         (elf_new_init): Don't call stabsread_new_init.
3561         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3562         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3563         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3564
3565 2019-06-10  Tom de Vries  <tdevries@suse.de>
3566
3567         PR symtab/16264
3568         PR symtab/24517
3569         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3570
3571 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3572
3573         * source.c (find_and_open_source): Also rewrite relative file
3574         names.
3575
3576 2019-04-26  Amos Bird  <amosbird@gmail.com>
3577
3578         * annotate.c (annotate_thread_exited): Add "thread-exited"
3579         annotation.
3580
3581 2019-06-06  Tom Tromey  <tromey@adacore.com>
3582
3583         * maint.h (class scoped_command_stats): Use
3584         DISABLE_COPY_AND_ASSIGN.
3585         <print_time>: New method.
3586         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3587         print_time.
3588         (scoped_command_stats::print_time): New method.
3589
3590 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3591
3592         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3593         instructions of lengths 6 or 8 bytes.
3594
3595 2019-06-04  Pedro Alves  <palves@redhat.com>
3596
3597         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3598
3599         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3600         * breakpoint.c (condition_completer): Likewise.
3601         * cli/cli-dump.c (scan_expression): Likewise.
3602         * common/filestuff.c (mkdir_recursive): Likewise.
3603         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3604         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3605         (gdb_abspath): Likewise.
3606         * compile/compile-cplus-types.c
3607         (compile_cplus_instance::decl_name): Likewise.
3608         * completer.c (complete_explicit_location):
3609         (signal_completer, reg_or_group_completer_1): Likewise.
3610         * cp-support.c (cp_remove_params_if_any): Likewise.
3611         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3612         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3613         * infcmd.c (strip_bg_char): Likewise.
3614         * linespec.c (copy_token_string): Likewise.
3615         * mi/mi-main.c (output_cores): Likewise.
3616         * psymtab.c (psymtab_search_name):
3617         * symfile.c (test_set_ext_lang_command): Likewise.
3618         * target.c (target_fileio_read_stralloc): Likewise.
3619         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3620         * value.c (complete_internalvar): Likewise.
3621
3622 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3623
3624         Add objfile property to gdb.Type.
3625         * NEWS: Mention Python API addition.
3626         * python/py-type.c (typy_get_objfile): New method.
3627
3628 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3629
3630         * NEWS: Mention the new set|show style [title|highlight].
3631         Mention changes to "show style", "help" and "apropos".
3632
3633 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3634
3635         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3636         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3637         instead of print_help_for_command.
3638         (print_doc_of_command): New function.
3639         (help_list): Add 'apropos -v word' suggestion.
3640         (print_help_for_command): Style the command name using title style.
3641         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3642         (_initialize_cli_cmds): Describe -v in apropos_command help.
3643
3644 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3645
3646         * cli/cli-style.h (cli_style_option): Add name in constructor,
3647         add m_name class member, add constructor with intensity,
3648         add name class function.
3649         (cli_style_option::add_setshow_commands): Remove name argument.
3650         (highlight_style, title_style): New styles.
3651         * cli/cli-style.c (do_show): New function that shows a style
3652         characteristic styling the style name with itself.
3653         (set_style_name): New function.
3654         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3655         Update all callers according to the changes in cli/cli-style.h.
3656         * utils.h (fputs_highlighted): New function.
3657         * utils.c (fputs_highlighted): Likewise.
3658
3659 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3660
3661         * NEWS: Mention new pipe command and new convenience variables.
3662
3663 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3664
3665         * cli/cli-cmds.c (pipe_command): New function.
3666         (_initialize_cli_cmds): Call add_com for pipe_command.
3667         Define | as an alias for pipe.
3668         (exit_status_set_internal_vars): New function.
3669         (shell_escape): Call exit_status_set_internal_vars.
3670         cli/cli-decode.c (find_command_name_length): Recognize | as
3671         a single character command.
3672
3673 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3674
3675         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3676         top.c (execute_command_to_ui_file): New function, mostly a copy
3677         of execute_command_to_string.
3678         (execute_command_to_string): Implement by calling
3679         execute_command_to_ui_file.
3680
3681 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3682
3683         * top.h (saved_command_line): Remove declaration.
3684         * top.c (previous_saved_command_line, previous_repeat_arguments):
3685         New variables.
3686         (saved_command_line): Make static, define together with other
3687         'repeat variables'.
3688         (dont_repeat): Clear repeat_arguments.
3689         (repeat_previous, get_saved_command_line, save_command_line):
3690         New functions.
3691         (gdb_init): Initialize saved_command_line
3692         and previous_saved_command_line.
3693         * main.c (captured_main_1): Remove saved_command_line initialization.
3694         * event-top.c (handle_line_of_input): Update to use
3695         the new 'repeat' related functions instead of direct access to
3696         saved_command_line.
3697         * command.h (repeat_previous, get_saved_command_line,
3698         save_command_line): New declarations.
3699         (dont_repeat): Add comment.
3700
3701 2019-05-30  Tom Tromey  <tromey@adacore.com>
3702
3703         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3704         Fix comment.
3705         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3706
3707 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3708
3709         PR cli/24587
3710         * completer.c (complete): Initialize variable word.
3711
3712 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3713
3714         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3715         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3716         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3717         'body' is NULL to the outter 'if', protecting the '!is_define'
3718         situation as well.
3719
3720 2019-05-29  Tom Tromey  <tromey@adacore.com>
3721
3722         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3723         (dwarf_unknown): New function.
3724         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3725         (dwarf_type_encoding_name): Use dwarf_unknown.
3726
3727 2019-05-29  Tom Tromey  <tromey@adacore.com>
3728
3729         PR c++/20020:
3730         * cp-valprint.c (cp_print_value_fields): Call
3731         cp_print_static_field inside "try".
3732
3733 2019-05-29  Tom Tromey  <tromey@adacore.com>
3734
3735         * inflow.c (struct terminal_info): Add default operator=.
3736         * configure: Rebuild.
3737         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3738         -Wdeprecated-copy-dtor, -Wredundant-move.
3739
3740 2019-05-29  Tom Tromey  <tromey@adacore.com>
3741
3742         * NEWS: Add entry.
3743         * infcmd.c (print_return_value_1): Handle finish_print
3744         option.
3745         (show_print_finish): New function.
3746         (_initialize_infcmd): Add "set/show print finish" commands.
3747         * valprint.c (user_print_options): Initialize new member.
3748         * valprint.h (struct value_print_options) <finish_print>: New
3749         member.
3750
3751 2019-05-28  Tom Tromey  <tromey@adacore.com>
3752
3753         * ada-lang.c (ada_remove_Xbn_suffix)
3754         (find_old_style_renaming_symbol)
3755         (parse_old_style_renaming): Remove.
3756         (ada_find_renaming_symbol): Don't call
3757         find_old_style_renaming_symbol.
3758         (ada_is_renaming_symbol): Rename from
3759         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3760         bool.  Now static.
3761         (ada_read_var_value): Update and simplify.
3762         * ada-exp.y (write_var_or_type): Remove old code.
3763
3764 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3765
3766         * event-top.c: Remove include comment.
3767         * inflow.c (class scoped_ignore_sigttou): Move from here...
3768         * inflow.h (class scoped_ignore_sigttou): ...to here.
3769         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3770         * top.c:  Remove include comment.
3771
3772 2019-05-27  Tom Tromey  <tom@tromey.com>
3773
3774         * NEWS: Fix typo.
3775
3776 2019-05-22  Tom Tromey  <tromey@adacore.com>
3777
3778         * target.c (target_follow_exec): Constify parameter.
3779         * target-delegates.c: Rebuild.
3780         * remote.c (remote_target::follow_exec): Constify parameter.
3781         * infrun.c (follow_exec): Constify parameter.
3782         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3783         (target_follow_exec): Likewise.
3784
3785 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3786
3787         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3788         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3789
3790 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3791
3792         * NEWS: Add debugredirect and testsuite sections.
3793
3794 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3795
3796         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3797         target descriptions using exclusively floating point register name
3798         aliases.
3799
3800 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3801
3802         PR gdb/18644:
3803         * f-lang.c (build_fortran_types): Handle the case where
3804         gdbarch_floatformat_for_type returns a nullptr.
3805
3806 2019-05-21  Tom de Vries  <tdevries@suse.de>
3807
3808         PR cli/24587
3809         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3810
3811 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3812
3813         PR gdb/18644:
3814         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3815         16-byte floats.
3816         * i386-tdep.c (i386_floatformat_for_type): Use
3817         floatformats_ia64_quad for the 16-byte floating point component
3818         within a fortran 32-byte complex number.
3819
3820 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3821
3822         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3823         delete default constructor.
3824         (find_partial_die): Update to return const struct.
3825         (partial_die_parent_scope): Move variable declaration into scope
3826         of its use and change its type to auto.
3827         (guess_partial_die_structure_name): Likewise.
3828         (partial_die_info::fixup): Likewise.
3829
3830 2019-05-17  Tom Tromey  <tromey@adacore.com>
3831
3832         * source.c (find_and_open_source): Remove cast.
3833
3834 2019-05-17  Tom Tromey  <tromey@adacore.com>
3835
3836         * annotate.c (annotate_source): Make "filename" const.
3837         * annotate.h (annotate_source): Use const.
3838
3839 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3840
3841         * disasm.c (set_disassembler_options): Send errors to stderr.
3842
3843 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3844
3845         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3846         (cli_interp_base::set_logging): Check debug_redirect.
3847         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3848         * cli/cli-logging.c (debug_redirect): Add static variable.
3849         (pop_output_files): Add default param.
3850         (handle_redirections): Print debug setting.
3851         (show_logging_command): Likewise.
3852         (_initialize_cli_logging): Add debugredirect command.
3853         * interps.c (current_interp_set_logging): Add debug_redirect
3854         parameter.
3855         * interps.h (set_logging): Add debug_redirect parameter.
3856         (current_interp_set_logging): Likewise.
3857         * mi/mi-common.h: Likewise.
3858         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3859
3860 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3861             Tom Tromey  <tromey@adacore.com>
3862
3863         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3864         directly.
3865         * cli/cli-interp.h (make_logging_output): Remove declaration.
3866         * cli/cli-logging.c (make_logging_output): Remove function.
3867         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3868         directly.
3869         * ui-file.c (tee_file::tee_file): Remove bools.
3870         (tee_file::~tee_file): Remove deletes.
3871         * ui-file.h (tee_file): Remove bools.
3872
3873 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3874
3875         * mi/mi-cmds.h (mi_cmd_complete): New function.
3876         * mi/mi-main.c (mi_cmd_complete): Likewise.
3877         * mi/mi-cmds.c: Define new MI command -complete.
3878         * NEWS: Mention new -complete command.
3879
3880 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3881
3882         * completer.h (complete): New function.
3883         * completer.c (complete): Likewise.
3884         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3885         function defined in completer.h.
3886
3887 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3888
3889         * MAINTAINERS (Write After Approval): Add myself.
3890
3891 2019-05-17  Tom de Vries  <tdevries@suse.de>
3892
3893         PR gdb/24094
3894         * dwarf2read.c (struct cu_partial_die_info): New struct.
3895         (find_partial_die): Return cu_partial_die_info.
3896         (partial_die_parent_scope, guess_partial_die_structure_name)
3897         (partial_die_info::fixup): Handle new return type of find_partial_die.
3898
3899 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3900
3901         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3902         "std::string", simplifying the algorithm.
3903
3904 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3905
3906         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3907         (stap_static_probe_ops::get_probes): Likewise.
3908
3909 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3910
3911         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3912         '-')" and "else if".
3913         (stap_parse_single_operand): Join checks for
3914         "gdbarch_stap_parse_special_token_p" and
3915         "gdbarch_stap_parse_special_token" in the same "if" statement.
3916         Invert check when verifying for operation on register
3917         displacement.
3918
3919 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3920
3921         * stap-probe.c (stap_get_opcode): Update comment.
3922         (stap_get_expected_argument_type): Likewise.
3923         (handle_stap_probe): Likewise.
3924
3925 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3926
3927         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3928         return type to 'bool'.  Adjust comment.  Use 'bool' when
3929         appropriate.
3930         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3931         * stap-probe.c (stap_parse_argument_1): Likewise.
3932         (stap_is_operator): Likewise.
3933         (stap_is_generic_prefix): Likewise.
3934         (stap_is_register_prefix): Likewise.
3935         (stap_is_register_indirection_prefix): Likewise.
3936         (stap_is_integer_prefix): Likewise.
3937         (stap_generic_check_suffix): Likewise.
3938         (stap_check_integer_suffix): Likewise.
3939         (stap_check_register_suffix): Likewise.
3940         (stap_check_register_indirection_suffix): Likewise.
3941         (stap_parse_register_operand): Likewise.
3942         (stap_parse_single_operand): Likewise.
3943         (stap_parse_argument_1): Likewise.
3944         (stap_probe::get_argument_count): Likewise.
3945         (stap_is_operator): Likewise.
3946
3947 2019-05-16  Tom Tromey  <tromey@adacore.com>
3948
3949         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3950         keyword to foreach.
3951
3952 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3953
3954         * linux-thread-db.c (try_thread_db_load_1): Change return type
3955         to bool.
3956         (try_thread_db_load): Likewise.
3957         (try_thread_db_load_from_pdir_1): Likewise.
3958         (try_thread_db_load_from_pdir): Likewise.
3959         (try_thread_db_load_from_sdir): Likewise.
3960         (try_thread_db_load_from_dir): Likewise.
3961         (thread_db_load_search): Likewise.
3962         (has_libpthread): Likewise.
3963         (thread_db_load): Likewise.
3964
3965 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3966
3967         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3968         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3969         NULL, and complain/return if that's the case.
3970
3971 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3972
3973         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3974         (advance, posn, abstract_read_memory): New functions.
3975         [struct mem_read_abstraction]: New struct.
3976         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3977
3978 2019-05-14  Tom Tromey  <tromey@adacore.com>
3979
3980         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3981         value is not lval_memory.
3982
3983 2019-05-14  Tom Tromey  <tromey@adacore.com>
3984
3985         * solib.c (info_sharedlibrary_command): Style the file name.
3986
3987 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3988
3989         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3990         (aarch64_vnv_type): Likewise.
3991         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3992         * common/tdesc.c: Likewise.
3993         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3994         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3995         * features/aarch64-fpu.xml: Add ieee half view.
3996         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3997         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3998         * gdbtypes.h (struct builtin_type): Likewise.
3999         (struct objfile_type): Likewise.
4000
4001 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4002
4003         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4004         typo.
4005         * location.h (string_to_event_location): Likewise.
4006
4007 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4008
4009         GDB 8.3 released.
4010
4011 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4012
4013         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4014         New variable declaration.
4015         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4016         New variable.
4017         (print_one_breakpoint): Use ui_out::test_flags and new global
4018         variable to compute use_fixed_output.
4019         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4020         Remove.
4021         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4022         (mi_multi_location_breakpoint_output_fixed): Remove.
4023         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4024         new variable.
4025         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4026         fix_multi_location_breakpoint_output flag if version >= 3.
4027         * ui-out.h (enum ui_out_flag)
4028         <fix_multi_location_breakpoint_output>: New enumerator.
4029
4030 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4031
4032         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4033
4034 2019-05-10  Tom Tromey  <tromey@adacore.com>
4035
4036         * ada-lang.c (catch_ada_completer): New function.
4037         (_initialize_ada_language): Use it.
4038
4039 2019-05-10  Tom Tromey  <tromey@adacore.com>
4040
4041         * thread.c (print_thread_info): Make "requested_threads" const.
4042         * gdbthread.h (print_thread_info): Make "requested_threads"
4043         const.
4044         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4045         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4046
4047 2019-05-08  Tom Tromey  <tom@tromey.com>
4048
4049         * gdbtypes.c (objfile_type_data): Change type.
4050         (objfile_type, _initialize_gdbtypes): Update.
4051
4052 2019-05-08  Tom Tromey  <tom@tromey.com>
4053
4054         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4055         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4056         (_initialize_dwarf2_frame): Update.
4057
4058 2019-05-08  Tom Tromey  <tom@tromey.com>
4059
4060         * objc-lang.c (objc_objfile_data): Change type.
4061         (find_methods): Update.
4062         (_initialize_objc_lang): Remove.
4063
4064 2019-05-08  Tom Tromey  <tom@tromey.com>
4065
4066         * stabsread.c (rs6000_builtin_type_data): Change type.
4067         (rs6000_builtin_type, _initialize_stabsread): Update.
4068
4069 2019-05-08  Tom Tromey  <tom@tromey.com>
4070
4071         * mips-tdep.c (mips_pdr_data): Remove.
4072         (_initialize_mips_tdep): Update.
4073
4074 2019-05-08  Tom Tromey  <tom@tromey.com>
4075
4076         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4077         (hppa_init_objfile_priv_data, read_unwind_info)
4078         (find_unwind_entry, _initialize_hppa_tdep): Update.
4079
4080 2019-05-08  Tom Tromey  <tom@tromey.com>
4081
4082         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4083         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4084         on obstack.
4085         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4086
4087 2019-05-08  Tom Tromey  <tom@tromey.com>
4088
4089         * mdebugread.c (basic_type_data): Change type.
4090         (basic_type, _initialize_mdebugread): Update.
4091
4092 2019-05-08  Tom Tromey  <tom@tromey.com>
4093
4094         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4095
4096 2019-05-08  Tom Tromey  <tom@tromey.com>
4097
4098         * nto-tdep.c (nto_inferior_data_reg): Change type.
4099         (nto_inferior_data): Update.
4100         (nto_inferior_data_cleanup, nto_new_inferior_data)
4101         (_initialize_nto_tdep): Remove.
4102         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4103
4104 2019-05-08  Tom Tromey  <tom@tromey.com>
4105
4106         * ada-lang.c (struct ada_inferior_data): Add initializers.
4107         (ada_inferior_data): Change type.
4108         (ada_inferior_data_cleanup): Remove.
4109         (get_ada_inferior_data, ada_inferior_exit)
4110         (struct ada_pspace_data): Add initializers, destructor.
4111         (ada_pspace_data_handle): Change type.
4112         (get_ada_pspace_data): Update.
4113         (ada_pspace_data_cleanup): Remove.
4114
4115 2019-05-08  Tom Tromey  <tom@tromey.com>
4116
4117         * coffread.c (struct coff_symfile_info): Add initializers.
4118         (coff_objfile_data_key): Move lower.  Change type.
4119         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4120         Update.
4121         (coff_free_info): Remove.
4122
4123 2019-05-08  Tom Tromey  <tom@tromey.com>
4124
4125         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4126         (fbsd_pspace_data_handle): Move lower.  Change type.
4127         (get_fbsd_pspace_data): Update.
4128         (fbsd_pspace_data_cleanup): Remove.
4129         (_initialize_fbsd_tdep): Update.
4130
4131 2019-05-08  Tom Tromey  <tom@tromey.com>
4132
4133         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4134         (get_ada_tasks_pspace_data): Update.
4135         (ada_tasks_pspace_data_cleanup): Remove.
4136         (_initialize_tasks): Update.
4137         (ada_tasks_inferior_data_handle): Change type.
4138         (get_ada_tasks_inferior_data): Update.
4139         (ada_tasks_inferior_data_cleanup): Remove.
4140         (struct ada_tasks_pspace_data): Add initializers.
4141
4142 2019-05-08  Tom Tromey  <tom@tromey.com>
4143
4144         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4145         * symfile-debug.c (debug_sym_get_probes): Change type.
4146         * stap-probe.c (handle_stap_probe):
4147         (stap_static_probe_ops::get_probes): Change type.
4148         * probe.h (class static_probe_ops) <get_probes>: Change type.
4149         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4150         (parse_probes_in_pspace): Update.
4151         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4152         Update.
4153         (any_static_probe_ops::get_probes): Change type.
4154         * elfread.c (elfread_data): New typedef.
4155         (probe_key): Change type.
4156         (elf_get_probes): Likewise.  Update.
4157         (probe_key_free): Remove.
4158         (_initialize_elfread): Update.
4159         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4160         Change type.
4161         (dtrace_process_dof_probe, dtrace_process_dof)
4162         (dtrace_static_probe_ops::get_probe): Change type.
4163
4164 2019-05-08  Tom Tromey  <tom@tromey.com>
4165
4166         * xcoffread.c (struct xcoff_symfile_info): Rename from
4167         coff_symfile_info.  Add initializers.
4168         (xcoff_objfile_data_key): Move lower.  Change type.
4169         (XCOFF_DATA): Rewrite.
4170         (xcoff_free_info): Remove.
4171         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4172         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4173         (xcoff_initial_scan): Update.
4174
4175 2019-05-08  Tom Tromey  <tom@tromey.com>
4176
4177         * solib-svr4.c (struct svr4_info): Add initializers and
4178         destructor.
4179         <probes_table>: Now an htab_up.
4180         (solib_svr4_pspace_data): Change type.
4181         (free_probes_table): Simplify.
4182         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4183         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4184         (probes_table_remove_objfile_probes, register_solib_event_probe)
4185         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4186         (_initialize_svr4_solib): Update.
4187
4188 2019-05-08  Tom Tromey  <tom@tromey.com>
4189
4190         * remote.c (remote_pspace_data): Change type.
4191         (remote_pspace_data_cleanup): Remove.
4192         (get_remote_exec_file, set_pspace_remote_exec_file)
4193         (_initialize_remote): Update.
4194
4195 2019-05-08  Tom Tromey  <tom@tromey.com>
4196
4197         * breakpoint.c (breakpoint_objfile_key): Change type.
4198         (get_breakpoint_objfile_data): Update.
4199         (free_breakpoint_objfile_data): Remove.
4200         (_initialize_breakpoint): Update.
4201
4202 2019-05-08  Tom Tromey  <tom@tromey.com>
4203
4204         * linux-tdep.c (struct linux_info): Add initializers.
4205         (linux_inferior_data): Move.  Change type.
4206         (invalidate_linux_cache_inf): Update.
4207         (linux_inferior_data_cleanup): Remove.
4208         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4209
4210 2019-05-08  Tom Tromey  <tom@tromey.com>
4211
4212         * auxv.c (auxv_inferior_data): Move.  Change type.
4213         (auxv_inferior_data_cleanup): Remove.
4214         (invalidate_auxv_cache_inf): Rewrite.
4215         (get_auxv_inferior_data, _initialize_auxv): Update.
4216
4217 2019-05-08  Tom Tromey  <tom@tromey.com>
4218
4219         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4220         (symfile_debug_objfile_data_key): Change type.
4221         (symfile_debug_installed, debug_qf_has_symbols)
4222         (debug_qf_find_last_source_symtab)
4223         (debug_qf_forget_cached_source_info)
4224         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4225         (debug_qf_print_stats, debug_qf_dump)
4226         (debug_qf_expand_symtabs_for_function)
4227         (debug_qf_expand_all_symtabs)
4228         (debug_qf_expand_symtabs_with_fullname)
4229         (debug_qf_map_matching_symbols)
4230         (debug_qf_expand_symtabs_matching)
4231         (debug_qf_find_pc_sect_compunit_symtab)
4232         (debug_qf_map_symbol_filenames)
4233         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4234         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4235         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4236         (debug_sym_read_linetable, debug_sym_relocate): Update.
4237         (symfile_debug_free_objfile): Remove.
4238         (install_symfile_debug_logging, _initialize_symfile_debug):
4239         Update.
4240
4241 2019-05-08  Tom Tromey  <tom@tromey.com>
4242
4243         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4244         allocate_on_obstack.
4245         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4246         (get_dwarf2_per_objfile): Update.
4247         (set_dwarf2_per_objfile): Remove.
4248         (dwarf2_has_info, dwarf2_get_section_info): Update.
4249         (dwarf2_free_objfile): Remove.
4250         (_initialize_dwarf2_read): Update.
4251
4252 2019-05-08  Tom Tromey  <tom@tromey.com>
4253
4254         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4255         initializers.
4256         <unsupported_script_warning_printed,
4257         script_not_found_warning_printed>: Now bool.
4258         (auto_load_pspace_data): Change type.
4259         (~auto_load_pspace_info): Rename from
4260         auto_load_pspace_data_cleanup.
4261         (get_auto_load_pspace_data, init_loaded_scripts_info)
4262         (clear_section_scripts, maybe_print_unsupported_script_warning)
4263         (maybe_print_script_not_found_warning, _initialize_auto_load):
4264         Update.
4265
4266 2019-05-08  Tom Tromey  <tom@tromey.com>
4267
4268         * objfiles.c (objfile_pspace_info): Add destructor and
4269         initializers.
4270         (objfiles_pspace_data): Change type.
4271         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4272         (get_objfile_pspace_data): Update.
4273         (objfiles_bfd_data): Change type.
4274         (get_objfile_bfd_data): Update.
4275         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4276
4277 2019-05-08  Tom Tromey  <tom@tromey.com>
4278
4279         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4280         Change type.
4281         (get_catch_syscall_inferior_data): Update.
4282         (catch_syscall_inferior_data_cleanup): Remove.
4283         (_initialize_break_catch_syscall): Update.
4284
4285 2019-05-08  Tom Tromey  <tom@tromey.com>
4286
4287         * inflow.c (struct terminal_info): Add destructor and
4288         initializers.
4289         (inflow_inferior_data): Change type.
4290         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4291         (get_inflow_inferior_data, inflow_inferior_exit)
4292         (swap_terminal_info, _initialize_inflow): Update.
4293
4294 2019-05-08  Tom Tromey  <tom@tromey.com>
4295
4296         * target-dcache.c (target_dcache_cleanup): Remove.
4297         (target_dcache_aspace_key): Change type.
4298         (target_dcache_init_p, target_dcache_invalidate)
4299         (target_dcache_get, target_dcache_get_or_init)
4300         (_initialize_target_dcache): Update.
4301         * dcache.h (struct dcache_deleter): New.
4302
4303 2019-05-08  Tom Tromey  <tom@tromey.com>
4304
4305         * symtab.c (struct symbol_cache): Add destructor and
4306         initializers.
4307         (symbol_cache_key): Move.  Change type.
4308         (make_symbol_cache, free_symbol_cache): Remove.
4309         (get_symbol_cache): Update.
4310         (symbol_cache_cleanup): Remove.
4311         (ALL_PSPACES, symbol_cache_flush)
4312         (maintenance_print_symbol_cache)
4313         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4314         Update.
4315
4316 2019-05-08  Tom Tromey  <tom@tromey.com>
4317
4318         * symtab.c (struct main_info): Add destructor and initializers.
4319         (main_progspace_key): Move.  Change type.
4320         (get_main_info): Update.
4321         (main_info_cleanup): Remove.
4322         (_initialize_symtab): Update.
4323
4324 2019-05-08  Tom Tromey  <tom@tromey.com>
4325
4326         * registry.h (DECLARE_REGISTRY): Define the _key class.
4327
4328 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4329
4330         * NEWS: Merge two 'New commands' sections.
4331
4332 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4333
4334         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4335         parameter and use Ada language definition instead.
4336         (ada_val_print_ptr): Remove unused language parameter.
4337         (ada_val_print_num): Remove language parameter and use Ada language
4338         definition instead.
4339         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4340         parameter.
4341         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4342         parameter and use Ada language definition instead.
4343         (ada_val_print_1): Update all ada_val_print_xxx calls.
4344         Remove language parameter.
4345         (ada_val_print): Update ada_val_print_1 call.
4346
4347 2019-05-08  Tom Tromey  <tromey@adacore.com>
4348
4349         * remote.c (remote_hw_watchpoint_limit)
4350         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4351         Now static.
4352
4353 2019-05-08  Tom Tromey  <tromey@adacore.com>
4354
4355         * maint.c (_initialize_maint_cmds): Move initialization code to
4356         remote.c.
4357         (watchdog, show_watchdog): Move to remote.c.
4358         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4359         "watchdog" static.
4360         (_initialize_remote): Move initialization code from maint.c.
4361         * defs.h (watchdog): Don't declare.
4362
4363 2019-05-08  Tom Tromey  <tromey@adacore.com>
4364
4365         * tui/tui-interp.c: Include main.h.
4366         * interps.c: Include main.h.
4367         * main.h (interpreter_p): Declare.
4368         * defs.h (interpreter_p): Don't declare.
4369
4370 2019-05-08  Tom Tromey  <tromey@adacore.com>
4371
4372         * dwarf2loc.c: Include dwarf2read.h.
4373         * defs.h (read_unsigned_leb128): Don't declare.
4374         * dwarf2read.h (read_unsigned_leb128): Declare.
4375
4376 2019-05-08  Tom Tromey  <tromey@adacore.com>
4377
4378         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4379         method.
4380
4381 2019-05-08  Tom Tromey  <tromey@adacore.com>
4382
4383         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4384         when no wrap column is set.
4385
4386 2019-05-08  Tom Tromey  <tromey@adacore.com>
4387
4388         * c-lang.c (c_get_string): Handle non-C-style arrays.
4389
4390 2019-05-08  Tom Tromey  <tromey@adacore.com>
4391
4392         * typeprint.c (print_offset_data::update): Print the bit offset,
4393         not the number of bits remaining.
4394
4395 2019-05-08  Tom Tromey  <tromey@adacore.com>
4396
4397         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4398         padding at end of comment.
4399
4400 2019-05-08  Tom Tromey  <tromey@adacore.com>
4401
4402         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4403         Compare main types.
4404
4405 2019-05-06  Tom Tromey  <tom@tromey.com>
4406
4407         * common/scoped_mmap.c: Include common-defs.h.
4408         * common/scoped_mmap.h: Don't include config.h.
4409
4410 2019-05-04  Tom Tromey  <tom@tromey.com>
4411
4412         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4413         (struct aarch64_call_info): Add initializers.
4414         <si>: Now a std::vector.
4415         (pass_on_stack, aarch64_push_dummy_call): Update.
4416
4417 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4418             Tom Tromey  <tom@tromey.com>
4419
4420         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4421         (ppc_threads): Now a std::vector.  Now static.
4422         (hwdebug_find_thread_points_by_tid)
4423         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4424         Update.
4425
4426 2019-05-04  Tom Tromey  <tom@tromey.com>
4427
4428         * arc-tdep.c (arc_tdesc_init): Return bool.
4429
4430 2019-05-04  Tom Tromey  <tom@tromey.com>
4431
4432         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4433         Use gdb_assert_not_reached.
4434
4435 2019-05-04  Tom Tromey  <tom@tromey.com>
4436
4437         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4438         "false".
4439
4440 2019-05-04  Tom Tromey  <tom@tromey.com>
4441
4442         * arc-tdep.c (arc_tdesc_init): Use bool.
4443
4444 2019-05-04  Tom Tromey  <tom@tromey.com>
4445
4446         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4447
4448 2019-05-04  Tom Tromey  <tom@tromey.com>
4449
4450         * cli/cli-cmds.c (valid_command_p): Return bool.
4451
4452 2019-05-04  Tom Tromey  <tom@tromey.com>
4453
4454         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4455         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4456
4457 2019-05-04  Raul Tambre  <raul@tambre.ee>
4458
4459         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4460         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4461         operator for comparison.
4462
4463 2019-05-04  Tom Tromey  <tom@tromey.com>
4464
4465         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4466         (lookup_partial_symbol, print_partial_symbols)
4467         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4468         (psymbol_compare): Update.
4469         (add_psymbol_to_bcache): Clear the entire psymbol.
4470         (maintenance_check_psymtabs): Update.
4471         * psympriv.h (struct partial_symbol): Don't derive from
4472         general_symbol_info.
4473         <obj_section, unrelocated_address, address,
4474         set_unrelocated_address>: Update.
4475         <ginfo>: New member.
4476         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4477         (debug_names::write_psymbols): Update.
4478
4479 2019-05-04  Tom de Vries  <tdevries@suse.de>
4480
4481         * contrib/cc-with-tweaks.sh: Support -n arg.
4482
4483 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4484
4485         * corelow.c (core_target::detach): Ensure frame cache and
4486         register caches are cleared.
4487         inferior.c (exit_inferior_1): Likewise.
4488
4489 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4490             Tom Tromey  <tom@tromey.com>
4491
4492         * dictionary.c (collate_pending_symbols_by_language): Remove
4493         "struct" from foreach.
4494         * symtab.c (lookup_global_symbol_from_objfile)
4495         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4496         foreach.
4497         * ser-tcp.c (net_open): Remove "struct" from foreach.
4498         * objfiles.c (objfile_relocate, objfile_rebase)
4499         (objfile_has_symbols): Remove "struct" from foreach.
4500         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4501         from foreach.
4502         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4503         foreach.
4504         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4505         "struct" from foreach.
4506         * ada-lang.c (create_excep_cond_exprs)
4507         (ada_exception_catchpoint_cond_string): Remove "struct" from
4508         foreach.
4509
4510 2019-05-03  Tom Tromey  <tromey@adacore.com>
4511
4512         * ada-exp.y (convert_char_literal): Check suffix of each
4513         enumerator.
4514
4515 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4516
4517         PR ada/21406:
4518         * ada-exp.y (yywrap): Don't define.
4519         * ada-lex.l (%option): Add noyywrap
4520         (yywrap): Remove.
4521
4522 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4523
4524         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4525         _WIN32_WINNT to the XP level, unless already defined to a higher
4526         level.
4527
4528         * unittests/parse-connection-spec-selftests.c:
4529         * ser-tcp.c:
4530         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4531         override.
4532
4533         * symfile.c (find_separate_debug_file): Remove colon from the
4534         drive spec of DOS/Windows file names of the target, so that the
4535         file name produced from DEBUGDIR and the target's directory will
4536         be valid on DOS/Windows systems.
4537
4538 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * rust-lang.c (val_print_struct): Handle printing structures
4541         containing strings.
4542
4543 2019-05-02  Tom Tromey  <tromey@adacore.com>
4544
4545         * valarith.c (_initialize_valarith): Remove.
4546
4547 2019-05-01  Tom Tromey  <tromey@adacore.com>
4548
4549         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4550         bitfields.
4551
4552 2019-05-01  Tom Tromey  <tromey@adacore.com>
4553
4554         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4555         for big-endian copies.
4556
4557 2019-04-30  Ali Tamur  <tamur@google.com>
4558         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4559         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4560         (read_3_bytes): New function.
4561
4562 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4563
4564         * windows-nat.c (main_thread_id): Delete.
4565         (handle_output_debug_string): Replace main_thread_id by
4566         current_event.dwThreadId.
4567         (fake_create_process): Likewise.
4568         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4569         Do not set main_thread_id.
4570         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4571         current_event.dwThreadId.
4572         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4573
4574 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4575
4576         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4577         Use current_event.dwThreadId instead of main_thread_id.
4578
4579 2019-04-30  Tom Tromey  <tromey@adacore.com>
4580
4581         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4582         (create_excep_cond_exprs): Iterate over program spaces.
4583         (ada_exception_catchpoint_cond_string): Examine all minimal
4584         symbols for exception types.
4585
4586 2019-04-30  Tom Tromey  <tromey@adacore.com>
4587
4588         PR c++/24470:
4589         * dwarf2read.c (process_structure_scope): Handle case where type
4590         has template parameters but no symbol was created.
4591
4592 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4593             Chris January  <chris.january@arm.com>
4594
4595         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4596         qualifier.
4597         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4598
4599 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4600
4601         * f-typeprint.c (f_print_type): Update rules for printing
4602         whitespace.
4603         (f_type_print_varspec_suffix): Likewise.
4604
4605 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4606             Chris January  <chris.january@arm.com>
4607
4608         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4609         function arguments.
4610
4611 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4612
4613         * f-lang.c (build_fortran_types): Change name of void type to
4614         lower case.
4615         * f-typeprint.c (f_type_print_base): Print the name of the void
4616         type, rather than a fixed string.
4617         * f-valprint.c (f_decorations): Use lower case void string.
4618
4619 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4620             Chris January  <chris.january@arm.com>
4621
4622         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4623         types for Fortran.
4624
4625 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4626             Chris January  <chris.january@arm.com>
4627             David Lecomber  <david.lecomber@arm.com>
4628
4629         * f-exp.y (BINOP_INTRINSIC): New token.
4630         (exp): New parser rule handling BINOP_INTRINSIC.
4631         (f77_keywords): Add new builtin procedures.
4632         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4633         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4634         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4635         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4636         (print_unop_subexp_f): New function.
4637         (print_binop_subexp_f): New function.
4638         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4639         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4640         (dump_subexp_body_f): Likewise.
4641         (operator_check_f): Likewise.
4642         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4643         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4644
4645 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4646
4647         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4648         UNOP_KIND.
4649         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4650         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4651         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4652         (operator_length_f): New fuction.
4653         (print_subexp_f): New function.
4654         (op_name_f): New function.
4655         (dump_subexp_body_f): New function.
4656         (operator_check_f): New function.
4657         (exp_descriptor_f): Replace standard expression handling functions
4658         with new functions.
4659         * gdb/fortran-operator.def: New file.
4660         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4661         * gdb/std-operator.def: Remove UNOP_KIND.
4662
4663 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4664
4665         * std-operator.def: Remove unbalanced, stray double quote
4666         character.
4667
4668 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4669             Chris January  <chris.january@arm.com>
4670             Daniel Everett  <daniel.everett@arm.com>
4671             Nick Forrington  <nick.forrington@arm.com>
4672             Richard Bunt  <richard.bunt@arm.com>
4673
4674         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4675         of depth when printing anonymous structs or unions.
4676         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4677         Don't print either the top-level value, or the children if the
4678         max-depth is exceeded.
4679         (ppscm_print_children): When printing the key of a map, allow one
4680         extra level of depth.
4681         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4682         print either the top-level value, or the children if the max-depth
4683         is exceeded.
4684         (print_children): When printing the key of a map, allow one extra
4685         level of depth.
4686         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4687         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4688         (user_print_options): Initialise max_depth field.
4689         (val_print_scalar_or_string_type_p): New function.
4690         (val_print): Check to see if the max depth has been reached.
4691         (val_print_check_max_depth): Define new function.
4692         (show_print_max_depth): New function.
4693         (_initialize_valprint): Add 'print max-depth' option.
4694         * valprint.h (struct value_print_options) <max_depth>: New field.
4695         (val_print_check_max_depth): Declare new function.
4696         * NEWS: Document new feature.
4697
4698 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * ada-lang.c (ada_language_defn): Initialise new field.
4701         * c-lang.c (c_is_string_type_p): New function.
4702         (c_language_defn): Initialise new field.
4703         (cplus_language_defn): Initialise new field.
4704         (asm_language_defn): Initialise new field.
4705         (minimal_language_defn): Initialise new field.
4706         * c-lang.h (c_is_string_type_p): Declare new function.
4707         * d-lang.c (d_language_defn): Initialise new field.
4708         * f-lang.c (f_is_string_type_p): New function.
4709         (f_language_defn): Initialise new field.
4710         * go-lang.c (go_is_string_type_p): New function.
4711         (go_language_defn): Initialise new field.
4712         * language.c (default_is_string_type_p): New function.
4713         (unknown_language_defn): Initialise new field.
4714         (auto_language_defn): Initialise new field.
4715         * language.h (struct language_defn) <la_is_string_type_p>: New
4716         member variable.
4717         (default_is_string_type_p): Declare new function.
4718         * m2-lang.c (m2_language_defn): Initialise new field.
4719         * objc-lang.c (objc_language_defn): Initialise new field.
4720         * opencl-lang.c (opencl_language_defn): Initialise new field.
4721         * p-lang.c (pascal_is_string_type_p): New function.
4722         (pascal_language_defn): Initialise new field.
4723         * rust-lang.c (rust_is_string_type_p): New function.
4724         (rust_language_defn): Initialise new field.
4725
4726 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4727
4728         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4729         New field.
4730         * ada-lang.c (ada_language_defn): Initialise new field.
4731         * c-lang.c (c_language_defn): Likewise.
4732         (cplus_language_defn): Likewise.
4733         (asm_language_defn): Likewise.
4734         (minimal_language_defn): Likewise.
4735         * d-lang.c (d_language_defn): Likewise.
4736         * f-lang.c (f_language_defn): Likewise.
4737         * go-lang.c (go_language_defn): Likewise.
4738         * language.c (unknown_language_defn): Likewise.
4739         (auto_language_defn): Likewise.
4740         * m2-lang.c (m2_language_defn): Likewise.
4741         * objc-lang.c (objc_language_defn): Likewise.
4742         * opencl-lang.c (opencl_language_defn): Likewise.
4743         * p-lang.c (pascal_language_defn): Likewise.
4744         * rust-lang.c (rust_language_defn): Likewise.
4745
4746 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4747
4748         * ada-lang.c (ada_is_character_type): Change return type to bool.
4749         (ada_is_string_type): Likewise.
4750         * ada-lang.h (ada_is_character_type): Update declaration
4751         (ada_is_string_type): Likewise.
4752
4753 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4754
4755         Support style in 'frame|thread apply'
4756
4757         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4758         * record.c (record_start, record_stop): Update callers of
4759         execute_command_to_string with false.
4760         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4761         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4762         methods.
4763         (class string_file): New constructor with term_out parameter.
4764         Override methods term_out and can_emit_style_escape.  New member
4765         term_out.
4766         (class stdio_file): Override can_emit_style_escape.
4767         (class tee_file): Override term_out and can_emit_style_escape.
4768         * utils.h (can_emit_style_escape): Remove.
4769         * utils.c (can_emit_style_escape): Likewise.
4770         Update all callers of can_emit_style_escape (SOMESTREAM) to
4771         SOMESTREAM->can_emit_style_escape.
4772         * source-cache.c (source_cache::get_source_lines): Likewise.
4773         * stack.c (frame_apply_command_count): Call execute_command_to_string
4774         passing the term_out characteristic of the current gdb_stdout.
4775         * thread.c (thr_try_catch_cmd): Likewise.
4776         * top.c (execute_command_to_string): pass term_out parameter
4777         to construct the string_file for the command output.
4778         * ui-file.c (term_cli_styling): New function (most code moved
4779         from utils.c can_emit_style_escape).
4780         (string_file::string_file, string_file::can_emit_style_escape,
4781         stdio_file::can_emit_style_escape, tee_file::term_out,
4782         tee_file::can_emit_style_escape): New functions.
4783
4784 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4785
4786         * NEWS: Mention the new set|show may-call-functions.
4787         * infcall.c (may_call_functions_p): New variable.
4788         (show_may_call_functions_p): New function.
4789         (call_function_by_hand_dummy): Throws an error if not
4790         may-call-functions.
4791         (_initialize_infcall): Call add_setshow_boolean_cmd for
4792         may-call-functions.
4793
4794 2019-04-25  Keith Seitz  <keiths@redhat.com>
4795
4796         PR c++/24367
4797         * cp-support.c (inspect_type): Don't attempt substitutions
4798         of symbol with the same name.
4799
4800 2019-04-25  Tom Tromey  <tromey@adacore.com>
4801
4802         PR gdb/24475:
4803         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4804         static.
4805
4806 2019-04-25  Tom Tromey  <tromey@adacore.com>
4807
4808         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4809         rvalue reference.
4810         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4811         (gdb_xml_parser::parse): Use std::move.
4812         * python/python-internal.h (gdbpy_convert_exception): Take a const
4813         reference.
4814         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4815         std::move.
4816         * python/py-utils.c (gdbpy_convert_exception): Take a const
4817         reference.
4818         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4819         Use std::move.
4820         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4821         Use std::move.
4822         * mi/mi-main.c (mi_print_exception): Take a const reference.
4823         * main.c (handle_command_errors): Take a const reference.
4824         * linespec.c (parse_linespec): Use std::move.
4825         * infcall.c (run_inferior_call): Use std::move.
4826         (call_function_by_hand_dummy): Use std::move.
4827         * exec.c (try_open_exec_file): Use std::move.
4828         * exceptions.h (exception_print, exception_fprintf)
4829         (exception_print_same): Update.
4830         * exceptions.c (print_exception, exception_print)
4831         (exception_fprintf, exception_print_same): Change parameters to
4832         const reference.
4833         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4834         * common/new-op.c: Use std::move.
4835         * common/common-exceptions.h (struct gdb_exception): Add move
4836         constructor.
4837         (struct gdb_exception_error, struct gdb_exception_quit, struct
4838         gdb_quit_bad_alloc): Change constructor to move constructor.
4839         (throw_exception): Change parameter to rvalue reference.
4840         * common/common-exceptions.c (throw_exception): Take rvalue
4841         reference.
4842         * cli/cli-interp.c (safe_execute_command): Use std::move.
4843         * breakpoint.c (insert_bp_location, location_to_sals): Use
4844         std::move.
4845
4846 2019-04-25  Tom Tromey  <tromey@adacore.com>
4847
4848         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4849         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4850         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4851         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4852         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4853         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4854         guile/scm-value.c: Use unpack.
4855         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4856         gdbscm_gdb_exception.
4857         (gdbscm_throw_gdb_exception): Likewise.
4858         (struct gdbscm_gdb_exception): New.
4859         (unpack): New function.
4860         (gdbscm_wrap): Use unpack.
4861
4862 2019-04-25  Tom Tromey  <tromey@adacore.com>
4863
4864         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4865         (gdb_rl_callback_handler): Use std::move.
4866         * common/common-exceptions.h (struct gdb_exception): Add move
4867         assignment operator.
4868         (throw_exception_sjlj): Change "exception" to const reference.
4869         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4870         (throw_exception_sjlj): Change "exception" to const reference.
4871
4872 2019-04-25  Tom Tromey  <tromey@adacore.com>
4873
4874         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4875         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4876         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4877         Update.
4878         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4879         Update.
4880         * mi/mi-interp.c (mi_interp::exec): Update.
4881         * linespec.c (parse_linespec): Update.
4882         * infcall.c (run_inferior_call): Update.
4883         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4884         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4885         (gdbscm_lookup_global_symbol): Update.
4886         * guile/scm-param.c (gdbscm_parameter_value): Update.
4887         * guile/scm-frame.c (gdbscm_frame_read_register)
4888         (gdbscm_frame_read_var): Update.
4889         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4890         * exec.c (try_open_exec_file): Update.
4891         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4892         (gdb_rl_callback_handler): Update.
4893         * common/common-exceptions.h (exception_none): Don't declare.
4894         * common/common-exceptions.c (exception_none): Don't define.
4895         (struct catcher) <exception>: Update.
4896         * cli/cli-interp.c (safe_execute_command): Update.
4897         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4898
4899 2019-04-25  Ali Tamur  <tamur@google.com>
4900
4901         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4902         (read_attribute_value): Likewise.
4903         (dwarf2_read_addr_index): Update comment.
4904         (read_str_index): Add DW_FORM_strx.
4905         (dwarf2_string_attr): Likewise.
4906         (dwarf2_const_value_attr): Likewise.
4907         (dump_die_shallow): Likewise.
4908         (dwarf2_fetch_constant_bytes): Likewise.
4909         (skip_form_bytes): Likewise.
4910         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4911
4912 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4913
4914         PR corefiles/11608
4915         PR corefiles/18187
4916         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4917         OFFSET.  Verify if current mapping contains an ELF header.
4918         (linux_find_memory_regions_full): Adjust call to
4919         dump_mapping_p.
4920
4921 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4922             Kang Li <kanglictf@gmail.com>
4923
4924         PR gdb/21600
4925
4926         * dwarf2-frame.c (read_initial_length): Be consistent about using
4927         unsigned representation of length.
4928         (decode_frame_entry_1): Likewise.  Check for wraparound of
4929         end pointer as well as buffer overflow.
4930
4931 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4932
4933         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4934         "vq".
4935
4936 2019-04-24  Tom Tromey  <tromey@adacore.com>
4937
4938         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4939
4940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4941
4942         * s12z-tdep.c (s12z_unwind_pc): Delete.
4943         (s12z_unwind_sp): Delete.
4944         (s12z_gdbarch_init): Don't register deleted functions with
4945         gdbarch.
4946
4947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4948
4949         * rl78-tdep.c (rl78_unwind_sp): Delete.
4950         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4951
4952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4953
4954         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4955         (xstormy16_unwind_pc): Delete.
4956         (xstormy16_dummy_id): Delete.
4957         (xstormy16_gdbarch_init): Don't register deleted functions with
4958         gdbarch.
4959
4960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * vax-tdep.c (vax_unwind_pc): Delete.
4963         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4964
4965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4966
4967         * v850-tdep.c (v850_unwind_sp): Delete.
4968         (v850_unwind_pc): Delete.
4969         (v850_dummy_id): Delete.
4970         (v850_gdbarch_init): Don't register deleted functions with
4971         gdbarch.
4972
4973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4976         (tilegx_unwind_pc): Delete.
4977         (tilegx_unwind_dummy_id): Delete.
4978         (tilegx_gdbarch_init): Don't register deleted functions with
4979         gdbarch.
4980
4981 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4982
4983         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4984         (tic6x_dummy_id): Delete.
4985         (tic6x_gdbarch_init): Don't register deleted functions with
4986         gdbarch.
4987
4988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * sparc-tdep.c (sparc_unwind_pc): Delete.
4991         (sparc32_gdbarch_init): Don't register deleted function with
4992         gdbarch.
4993
4994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * sh-tdep.c (sh_unwind_sp): Delete.
4997         (sh_unwind_pc): Delete.
4998         (sh_dummy_id): Delete.
4999         (sh_gdbarch_init): Don't register deleted functions with
5000         gdbarch.
5001
5002 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5003
5004         * score-tdep.c (score_unwind_sp): Delete.
5005         (score_unwind_pc): Delete.
5006         (score_dummy_id): Delete.
5007         (score_gdbarch_init): Don't register deleted functions with
5008         gdbarch.
5009
5010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5011
5012         * rx-tdep.c (rx_unwind_pc): Delete.
5013         (rx_unwind_sp): Delete.
5014         (rx_dummy_id): Delete.
5015         (rx_gdbarch_init): Don't register deleted functions with
5016         gdbarch.  Update comment.
5017
5018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5019
5020         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5021         (rs6000_dummy_id): Delete.
5022         (rs6000_gdbarch_init): Don't register deleted functions with
5023         gdbarch.
5024
5025 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5026
5027         * or1k-tdep.c (or1k_dummy_id): Delete.
5028         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5029
5030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5031
5032         * nios2-tdep.c (nios2_dummy_id): Delete.
5033         (nios2_unwind_sp): Delete.
5034         (nios2_gdbarch_init): Don't register deleted functions with
5035         gdbarch.
5036
5037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5038
5039         * nds32-tdep.c (nds32_dummy_id): Delete.
5040         (nds32_unwind_pc): Delete.
5041         (nds32_unwind_sp): Delete.
5042         (nds32_gdbarch_init): Don't register deleted functions with
5043         gdbarch.
5044
5045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5046
5047         * msp430-tdep.c (msp430_unwind_pc): Delete.
5048         (msp430_unwind_sp): Delete.
5049         (msp430_dummy_id): Delete.
5050         (msp430_gdbarch_init): Don't register deleted functions with
5051         gdbarch.
5052
5053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5054
5055         * moxie-tdep.c (moxie_unwind_sp): Delete.
5056         (moxie_unwind_pc): Delete.
5057         (moxie_dummy_id): Delete.
5058         (moxie_gdbarch_init): Don't register deleted functions with
5059         gdbarch.
5060
5061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5062
5063         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5064         (mn10300_unwind_pc): Delete.
5065         (mn10300_unwind_sp): Delete.
5066         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5067         mn10300_unwind_sp.
5068         (mn10300_frame_unwind_init): Don't register deleted functions with
5069         gdbarch.
5070
5071 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5072
5073         * mep-tdep.c (mep_unwind_pc): Delete.
5074         (mep_unwind_sp): Delete.
5075         (mep_dummy_id): Delete.
5076         (mep_gdbarch_init): Don't register deleted functions with
5077         gdbarch.
5078
5079 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5080
5081         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5082         (m68hc11_unwind_sp): Delete.
5083         (m68hc11_gdbarch_init): Don't register deleted functions with
5084         gdbarch.
5085
5086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5087
5088         * m32r-tdep.c (m32r_unwind_sp): Delete.
5089         (m32r_unwind_pc): Delete.
5090         (m32r_dummy_id): Delete.
5091         (m32r_gdbarch_init): Don't register deleted functions with
5092         gdbarch.
5093
5094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5095
5096         * m32c-tdep.c (m32c_unwind_pc): Delete.
5097         (m32c_unwind_sp): Delete.
5098         (m32c_dummy_id): Delete.
5099         (m32c_gdbarch_init): Don't register deleted functions with
5100         gdbarch.
5101
5102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5103
5104         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5105         (lm32_unwind_pc): Delete.
5106         (lm32_dummy_id): Delete.
5107         (lm32_gdbarch_init): Don't register deleted functions with
5108         gdbarch.
5109
5110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5111
5112         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5113         (iq2000_unwind_pc): Delete.
5114         (iq2000_dummy_id): Delete.
5115         (iq2000_gdbarch_init): Don't register deleted functions with
5116         gdbarch.
5117
5118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5119
5120         * nds32-tdep.c (nds32_type_align): Delete.
5121         (nds32_push_dummy_call): Use type_align instead.
5122
5123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5124
5125         * arm-tdep.c (arm_type_align): Only handle vector override case.
5126         (arm_push_dummy_call): Use type_align.
5127         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5128
5129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5130
5131         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5132         case.
5133         (pass_on_stack): Use type_align.
5134         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5135         function.
5136
5137 2019-04-23  Tom Tromey  <tromey@adacore.com>
5138
5139         * dwarf2read.c (line_header::file_name_at): Remove unused
5140         overload.
5141
5142 2019-04-23  Tom de Vries  <tdevries@suse.de>
5143
5144         PR gdb/24438
5145         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5146         invocation.
5147
5148
5149 2019-03-27  Ali Tamur  <tamur@google.com>
5150
5151         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5152         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5153         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5154         (dwarf_expr_context::get_addr_index): Likewise
5155         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5156         (symbol_needs_eval_context::get_addr_index): Likewise
5157         (disassemble_dwarf_expression): Add DW_OP_addrx
5158         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5159         (read_cutu_die_from_dwo): Update comment
5160         (skip_one_die): Add DW_FORM_addrx
5161         (read_attribute_value): Likewise
5162         (var_decode_location): Add DW_OP_addrx
5163         (dwarf2_const_value_attr): Add DW_FORM_addrx
5164         (dump_die_shallow): Likewise
5165         (dwarf2_fetch_constant_bytes): Likewise
5166         (decode_locdesc): Add DW_OP_addrx
5167         (skip_form_bytes): Add DW_FORM_addrx
5168
5169 2019-04-22  Ali Tamur  <tamur@google.com>
5170
5171         * MAINTAINERS (Write After Approval): Add self.
5172
5173 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5174
5175         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5176         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5177         (open_symbol_file_object): Likewise.
5178         (svr4_default_sos): Add info parameter.
5179         (svr4_read_so_list): Likewise.
5180         (svr4_current_sos_direct): Adjust functions calls to pass down
5181         info.
5182         (svr4_current_sos_1): Add info parameter.
5183         (svr4_current_sos): Call get_svr4_info, pass info down to
5184         svr4_current_sos_1.
5185         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5186         get_svr4_info.
5187         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5188         get_svr4_info.
5189         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5190         to get_svr4_info.
5191         (probes_table_remove_objfile_probes): Likewise.
5192         (register_solib_event_probe): Add info parameter.
5193         (solist_update_incremental): Pass info parameter down to
5194         svr4_read_so_list.
5195         (disable_probes_interface): Add info parameter.
5196         (svr4_handle_solib_event): Pass current_program_space to
5197         get_svr4_info.  Adjust disable_probes_interface cleanup.
5198         (svr4_create_probe_breakpoints): Add info parameter, pass it
5199         down to register_solib_event_probe.
5200         (svr4_create_solib_event_breakpoints): Add info parameter,
5201         pass it down to svr4_create_probe_breakpoints.
5202         (enable_break): Pass info down to
5203         svr4_create_solib_event_breakpoints.
5204         (svr4_solib_create_inferior_hook): Pass current_program_space to
5205         get_svr4_info.
5206         (svr4_clear_solib): Likewise.
5207
5208 2019-04-22  Pedro Alves  <palves@redhat.com>
5209
5210         * solib-svr4.c (svr4_free_objfile_observer): New.
5211         (probe_and_action::objfile): New field.
5212         (probes_table_htab_remove_objfile_probes)
5213         (probes_table_remove_objfile_probes): New functions.
5214         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5215         in the new probe_and_action.  Don't store the probe in 'lookup'.
5216         (svr4_create_probe_breakpoints): Pass objfile to
5217         register_solib_event_probe.
5218         (_initialize_svr4_solib): Register a free_objfile observer.
5219
5220 2019-04-19  Tom Tromey  <tom@tromey.com>
5221
5222         * common/queue.h: Remove.
5223
5224 2019-04-19  Tom Tromey  <tom@tromey.com>
5225
5226         * event-loop.c: Don't include "common/queue.h".
5227
5228 2019-04-19  Tom Tromey  <tom@tromey.com>
5229
5230         * remote.c (remote_target): Use delete.
5231         * remote-notif.h: Include <list>, not "common/queue.h".
5232         (notif_client_p): Remove typedef.
5233         (remote_notif_state): Add constructor, destructor, initializer.
5234         <notif_queue>: Now a std::list.
5235         (remote_notif_state_xfree): Don't declare.
5236         * remote-notif.c (remote_notif_process, handle_notification)
5237         (remote_notif_state_allocate): Update.
5238         (~remote_notif_state): Rename from remote_notif_state_xfree.
5239
5240 2019-04-19  Tom Tromey  <tom@tromey.com>
5241
5242         * symfile.c (reread_symbols): Update.
5243         * objfiles.c (objfile_register_static_link)
5244         (objfile_lookup_static_link): Update
5245         (~objfile) Don't delete static_links.
5246         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5247
5248 2019-04-19  Tom Tromey  <tom@tromey.com>
5249
5250         * type-stack.h (struct type_stack) <insert>: Constify string.
5251         * type-stack.c (type_stack::insert): Constify string.
5252         * gdbtypes.h (lookup_template_type): Update.
5253         (address_space_name_to_int): Update.
5254         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5255         const.
5256         (lookup_template_type): Make name const.
5257         * c-exp.y: Update rules.
5258         (lex_one_token, classify_name, classify_inner_name)
5259         (c_print_token): Update.
5260         * p-exp.y: Update rules.
5261         (yylex): Update.
5262         * f-exp.y: Update rules.
5263         (yylex): Update.
5264         * d-exp.y: Update rules.
5265         (lex_one_token, classify_name, classify_inner_name): Update.
5266         * parse.c (write_dollar_variable, copy_name): Return std::string.
5267         * parser-defs.h (copy_name): Change return type.
5268         * m2-exp.y: Update rules.
5269         (yylex): Update.
5270         * go-exp.y (lex_one_token): Update.
5271         Update rules.
5272         (classify_unsafe_function, classify_packaged_name)
5273         (classify_name, yylex): Update.
5274
5275 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5276
5277         * configure.ac: add --enable-source-highlight switch.
5278         * configure: Regenerate.
5279         * top.c (print_gdb_version): plumb --enable-source-highlight
5280         status to "show configuration".
5281
5282 2019-04-19  Tom Tromey  <tromey@adacore.com>
5283
5284         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5285         Check ADA_TYPE_P.
5286         (empty_record, ada_template_to_fixed_record_type_1)
5287         (template_to_static_fixed_type)
5288         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5289         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5290         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5291         macros.
5292
5293 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5294
5295         PR symtab/24423:
5296         * source.c (print_source_lines_base): Advance "iter" when a
5297         control character is seen.
5298
5299 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5300
5301         * inferior.h (struct infcall_suspend_state_deleter):
5302         Catch exception in destructor to avoid crash.
5303
5304 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5305
5306         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5307         close to the add_com "shell".
5308
5309 2019-04-18  Tom Tromey  <tromey@adacore.com>
5310
5311         * process-stratum-target.h (class process_stratum_target)
5312         <stratum>: Add "final".
5313
5314 2019-04-17  Tom Tromey  <tromey@adacore.com>
5315
5316         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5317         against nullptr before use.
5318
5319 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5320
5321         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5322
5323 2019-04-17  Jim Wilson  <jimw@sifive.com>
5324             Andrew Burgess  <andrew.burgess@embecosm.com>
5325
5326         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5327         code read might fail, assume 4-byte breakpoint in that case.
5328
5329 2019-04-15  Leszek Swirski  <leszeks@google.com>
5330
5331         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5332         rather than a hand-rolled POD check when checking for forced MEMORY
5333         classification.
5334
5335 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5336
5337         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5338         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5339         function.
5340         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5341         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5342         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5343         declaration.
5344
5345 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5346
5347         * aarch64-linux-nat.c
5348         (aarch64_linux_nat_target::thread_architecture): Add override.
5349         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5350         each VQ.
5351
5352 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5353
5354         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5355
5356 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5359         target types of size 96-bits, add some additional comments, and
5360         check that the builtin type we found was the correct size.
5361
5362 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5363
5364         * utils.c (prompt_for_continue): Don't restore the styling at the
5365         end, as applied_style has the wrong value.  This fixes styling in
5366         long lists of file names that are interrupted by the "Continue?"
5367         prompt.
5368
5369 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5370
5371         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5372         * c-lang.c (c_language_defn): Likewise.
5373         (cplus_language_defn): Likewise.
5374         (asm_language_defn): Likewise.
5375         (minimal_language_defn): Likewise.
5376         * d-lang.c (d_language_defn): Likewise.
5377         * f-lang.c (f_language_defn): Likewise.
5378         * go-lang.c (go_language_defn): Likewise.
5379         * language.c (unknown_language_defn): Likewise.
5380         (auto_language_defn): Likewise.
5381         * language.h (struct language_defn): Remove la_magic field.
5382         (LANG_MAGIC): Delete.
5383         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5384         * objc-lang.c (objc_language_defn): Likewise.
5385         * opencl-lang.c (opencl_language_defn): Likewise.
5386         * p-lang.c (pascal_language_defn): Likewise.
5387         * rust-lang.c (rust_language_defn): Likewise.
5388
5389 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5390
5391         * riscv-tdep.c (riscv_type_align): New function.
5392         (riscv_type_alignment): Delete.
5393         (riscv_arg_location): Use 'type_align'.
5394         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5395
5396 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5397
5398         * gdbtypes.c (type_align): A struct with no non-static fields also
5399         has alignment of 1.
5400
5401 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5404         component to 0.
5405         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5406         member.
5407         (riscv_struct_info::analyse): New implementation using new
5408         analyse_inner member function.
5409         (riscv_struct_info::field_offset): New member function.
5410         (riscv_struct_info::m_offsets): New member variable.
5411         (riscv_struct_info::analyse_inner): New private member function,
5412         takes the old implementation of riscv_struct_info::analyse but
5413         extended to track field offsets.
5414         (riscv_call_arg_struct): Update the struct folding special cases
5415         to handle cases where empty C++ structs, which are non-zero
5416         length, are found.
5417         (riscv_arg_location): Initialise the length of each location, a
5418         non-zero length now indicates the location is in use.
5419         (riscv_push_dummy_call): Allow for the first location having a
5420         non-zero offset when setting up arguments.
5421         (riscv_return_value): Likewise, but for return values.
5422
5423 2019-04-11  Tom Tromey  <tromey@adacore.com>
5424
5425         * utils.c (internal_vproblem): Make "msg" const.
5426
5427 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5428
5429         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5430         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5431         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5432         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5433
5434 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5435
5436         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5437         function.
5438         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5439         of amd64_collect_native_gregset.
5440         (amd64_linux_nat_target::store_registers): Likewise.
5441
5442 2019-04-10  Tom Tromey  <tom@tromey.com>
5443
5444         * symtab.c (lookup_global_symbol_from_objfile)
5445         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5446         * objfiles.h (class separate_debug_iterator): New.
5447         (class separate_debug_range): New.
5448         (struct objfile) <separate_debug_objfiles>: New method.
5449         (objfile_separate_debug_iterate): Don't declare.
5450         * objfiles.c (separate_debug_iterator::operator++): Rename from
5451         objfile_separate_debug_iterate.
5452         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5453         iterator.
5454         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5455         iterator.
5456
5457 2019-04-10  Tom Tromey  <tom@tromey.com>
5458
5459         * symfile.c (reread_symbols): Remove old comment.
5460         * objfiles.c (free_all_objfiles): Fix a typo.
5461
5462 2019-04-10  Tom Tromey  <tom@tromey.com>
5463
5464         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5465         * minsyms.c (lookup_minimal_symbol): Use foreach.
5466         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5467         (lookup_minimal_symbol_solib_trampoline): Likewise.
5468         * symfile.c (reread_symbols): Use foreach.
5469
5470 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5471             Tom Tromey  <tromey@adacore.com>
5472
5473         PR rust/24414:
5474         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5475         (rust_lex_int_test): Change "value" to be LONGEST.
5476         (rust_lex_tests): Add test for long integer literal.
5477
5478 2019-04-09  Tom Tromey  <tromey@adacore.com>
5479
5480         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5481         to bool.
5482         (extended_remote_target::attach): Update.
5483         (remote_target::remote_notice_new_inferior): Update.
5484         (remote_target::add_current_inferior_and_thread): Update.
5485         * inferior.c (exit_inferior_1): Use "false".
5486         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5487
5488 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5489
5490         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5491         the "start" command.
5492
5493 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5494
5495         * python/py-inferior.c (infpy_thread_from_thread_handle):
5496         Adjust comments to reflect renaming of thread_from_thread_handle
5497         to thread_from_handle.  Adjust keywords.  Fix type error message.
5498         (inferior_object_methods): Add thread_from_handle.  Retain
5499         thread_from_thread_handle, but mark it as deprecated.
5500
5501 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5502
5503         * gdbthread.h (find_thread_by_handle): Revise declaration.
5504         * thread.c (find_thread_by_handle): Likewise.  Adjust
5505         implementation too.
5506         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5507         support for buffer objects as handles.
5508
5509 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5510
5511         * python/py-infthread.c (thpy_thread_handle): New function.
5512         (thread_object_methods): Register thpy_thread_handle.
5513
5514 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5515
5516         * gdbthread.h (thread_to_thread_handle): Declare.
5517         * thread.c (gdbtypes.h): Include.
5518         (thread_to_thread_handle): New function.
5519
5520         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5521         (target_thread_info_to_thread_handle): Declare.
5522         * target.c (target_thread_info_to_thread_handle): New function.
5523         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5524         * target-delegates.c: Regenerate.
5525
5526         * linux-thread-db.c (class thread_db_target): Add method
5527         thread_info_to_thread_handle.
5528         (thread_db_target::thread_info_to_thread_handle): Define.
5529         * remote.c (class remote_target): Add new method
5530         thread_info_to_thread_handle.
5531         (remote_target::thread_info_to_thread_handle): Define.
5532
5533 2019-04-08  Pedro Alves  <palves@redhat.com>
5534
5535         * common/common-exceptions.c (throw_exception): Don't create
5536         named object to throw; throw directly.
5537         (throw_it): Likewise.  Don't initialize gdb_exception::message
5538         here, with new; pass FMT and AP to the ctor instead.
5539         * common/common-exceptions.h: Include <string>.
5540         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5541         const char *, va_list)): New ctor.  Use std::make_shared.
5542         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5543         errors)): Delete.
5544         (gdb_exception_error::gdb_exception_error(enum errors, const char
5545         *, va_list)): New.
5546         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5547         Add assertion.
5548         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5549         errors)): Delete.
5550         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5551         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5552         Add assertion.
5553
5554 2019-04-08  Tom Tromey  <tom@tromey.com>
5555
5556         * valops.c (value_rtti_indirect_type): Replace throw_exception
5557         with throw.
5558         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5559         with throw.
5560         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5561         throw.
5562         * target.c (target_translate_tls_address): Replace throw_exception
5563         with throw.
5564         * stack.c (frame_apply_command_count): Replace throw_exception
5565         with throw.
5566         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5567         throw.
5568         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5569         with throw.
5570         * rs6000-tdep.c (rs6000_frame_cache)
5571         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5572         * remote.c: Replace throw_exception with throw.
5573         * record-full.c (record_full_message, record_full_wait_1)
5574         (record_full_restore): Replace throw_exception with throw.
5575         * record-btrace.c:
5576         (get_thread_current_frame_id, record_btrace_start_replaying)
5577         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5578         (cmd_record_btrace_start): Replace throw_exception with throw.
5579         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5580         throw.
5581         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5582         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5583         * linespec.c:
5584         (find_linespec_symbols): Replace throw_exception with throw.
5585         * infrun.c (displaced_step_prepare, resume): Replace
5586         throw_exception with throw.
5587         * infcmd.c (post_create_inferior): Replace throw_exception with
5588         throw.
5589         * inf-loop.c (inferior_event_handler): Replace throw_exception
5590         with throw.
5591         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5592         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5593         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5594         (get_prev_frame_always, get_frame_pc_if_available)
5595         (get_frame_address_in_block_if_available, get_frame_language):
5596         Replace throw_exception with throw.
5597         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5598         throw_exception with throw.
5599         * eval.c (fetch_subexp_value, evaluate_var_value)
5600         (evaluate_funcall, evaluate_subexp_standard): Replace
5601         throw_exception with throw.
5602         * dwarf2loc.c (call_site_find_chain)
5603         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5604         Replace throw_exception with throw.
5605         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5606         with throw.
5607         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5608         throw.
5609         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5610         * completer.c (complete_line_internal): Replace throw_exception
5611         with throw.
5612         * compile/compile-object-run.c (compile_object_run): Replace
5613         throw_exception with throw.
5614         * cli/cli-script.c (process_next_line): Replace throw_exception
5615         with throw.
5616         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5617         (btrace_enable, btrace_maint_update_pt_packets): Replace
5618         throw_exception with throw.
5619         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5620         throw_exception with throw.
5621         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5622         throw_exception with throw.
5623         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5624         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5625         * aarch64-tdep.c (aarch64_make_prologue_cache)
5626         (aarch64_make_stub_cache): Replace throw_exception with throw.
5627
5628 2019-04-08  Tom Tromey  <tom@tromey.com>
5629
5630         * common/common-exceptions.c (throw_exception): Rename from
5631         throw_exception_cxx.  Remove old copy.  Make argument const.
5632         (throw_it): Create and throw exception objects directly.
5633         * common/common-exceptions.h (throw_exception): Make argument
5634         const.
5635         (struct gdb_exception_error): Add constructor.
5636         (struct gdb_exception_quit): Add constructor.
5637
5638 2019-04-08  Tom Tromey  <tom@tromey.com>
5639
5640         * common/common-exceptions.h (exception_rethrow): Don't declare.
5641         (TRY_SJLJ): Update comment.
5642         (TRY, CATCH, END_CATCH): Remove.
5643         * common/common-exceptions.c (exception_rethrow): Remove.
5644
5645 2019-04-08  Tom Tromey  <tom@tromey.com>
5646
5647         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5648         Remove.
5649         (gdb_exception_error): Rename from
5650         gdb_exception_RETURN_MASK_ERROR.
5651         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5652         (gdb_quit_bad_alloc): Update.
5653         * aarch64-tdep.c: Update.
5654         * ada-lang.c: Update.
5655         * ada-typeprint.c: Update.
5656         * ada-valprint.c: Update.
5657         * amd64-tdep.c: Update.
5658         * arch-utils.c: Update.
5659         * break-catch-throw.c: Update.
5660         * breakpoint.c: Update.
5661         * btrace.c: Update.
5662         * c-varobj.c: Update.
5663         * cli/cli-cmds.c: Update.
5664         * cli/cli-interp.c: Update.
5665         * cli/cli-script.c: Update.
5666         * common/common-exceptions.c: Update.
5667         * common/new-op.c: Update.
5668         * common/selftest.c: Update.
5669         * compile/compile-c-symbols.c: Update.
5670         * compile/compile-cplus-symbols.c: Update.
5671         * compile/compile-object-load.c: Update.
5672         * compile/compile-object-run.c: Update.
5673         * completer.c: Update.
5674         * corelow.c: Update.
5675         * cp-abi.c: Update.
5676         * cp-support.c: Update.
5677         * cp-valprint.c: Update.
5678         * darwin-nat.c: Update.
5679         * disasm-selftests.c: Update.
5680         * dtrace-probe.c: Update.
5681         * dwarf-index-cache.c: Update.
5682         * dwarf-index-write.c: Update.
5683         * dwarf2-frame-tailcall.c: Update.
5684         * dwarf2-frame.c: Update.
5685         * dwarf2loc.c: Update.
5686         * dwarf2read.c: Update.
5687         * eval.c: Update.
5688         * event-loop.c: Update.
5689         * event-top.c: Update.
5690         * exec.c: Update.
5691         * f-valprint.c: Update.
5692         * fbsd-tdep.c: Update.
5693         * frame-unwind.c: Update.
5694         * frame.c: Update.
5695         * gdbtypes.c: Update.
5696         * gnu-v3-abi.c: Update.
5697         * guile/guile-internal.h: Update.
5698         * guile/scm-block.c: Update.
5699         * guile/scm-breakpoint.c: Update.
5700         * guile/scm-cmd.c: Update.
5701         * guile/scm-disasm.c: Update.
5702         * guile/scm-frame.c: Update.
5703         * guile/scm-lazy-string.c: Update.
5704         * guile/scm-math.c: Update.
5705         * guile/scm-param.c: Update.
5706         * guile/scm-ports.c: Update.
5707         * guile/scm-pretty-print.c: Update.
5708         * guile/scm-symbol.c: Update.
5709         * guile/scm-symtab.c: Update.
5710         * guile/scm-type.c: Update.
5711         * guile/scm-value.c: Update.
5712         * i386-linux-tdep.c: Update.
5713         * i386-tdep.c: Update.
5714         * inf-loop.c: Update.
5715         * infcall.c: Update.
5716         * infcmd.c: Update.
5717         * infrun.c: Update.
5718         * jit.c: Update.
5719         * language.c: Update.
5720         * linespec.c: Update.
5721         * linux-fork.c: Update.
5722         * linux-nat.c: Update.
5723         * linux-tdep.c: Update.
5724         * linux-thread-db.c: Update.
5725         * main.c: Update.
5726         * mi/mi-cmd-break.c: Update.
5727         * mi/mi-cmd-stack.c: Update.
5728         * mi/mi-interp.c: Update.
5729         * mi/mi-main.c: Update.
5730         * objc-lang.c: Update.
5731         * p-valprint.c: Update.
5732         * parse.c: Update.
5733         * ppc-linux-tdep.c: Update.
5734         * printcmd.c: Update.
5735         * python/py-arch.c: Update.
5736         * python/py-breakpoint.c: Update.
5737         * python/py-cmd.c: Update.
5738         * python/py-finishbreakpoint.c: Update.
5739         * python/py-frame.c: Update.
5740         * python/py-framefilter.c: Update.
5741         * python/py-gdb-readline.c: Update.
5742         * python/py-inferior.c: Update.
5743         * python/py-infthread.c: Update.
5744         * python/py-lazy-string.c: Update.
5745         * python/py-linetable.c: Update.
5746         * python/py-objfile.c: Update.
5747         * python/py-param.c: Update.
5748         * python/py-prettyprint.c: Update.
5749         * python/py-progspace.c: Update.
5750         * python/py-record-btrace.c: Update.
5751         * python/py-record.c: Update.
5752         * python/py-symbol.c: Update.
5753         * python/py-type.c: Update.
5754         * python/py-unwind.c: Update.
5755         * python/py-utils.c: Update.
5756         * python/py-value.c: Update.
5757         * python/python.c: Update.
5758         * record-btrace.c: Update.
5759         * record-full.c: Update.
5760         * remote-fileio.c: Update.
5761         * remote.c: Update.
5762         * riscv-tdep.c: Update.
5763         * rs6000-aix-tdep.c: Update.
5764         * rs6000-tdep.c: Update.
5765         * rust-exp.y: Update.
5766         * rust-lang.c: Update.
5767         * s390-tdep.c: Update.
5768         * selftest-arch.c: Update.
5769         * solib-dsbt.c: Update.
5770         * solib-frv.c: Update.
5771         * solib-spu.c: Update.
5772         * solib-svr4.c: Update.
5773         * solib.c: Update.
5774         * sparc64-linux-tdep.c: Update.
5775         * stack.c: Update.
5776         * symfile-mem.c: Update.
5777         * symmisc.c: Update.
5778         * target.c: Update.
5779         * thread.c: Update.
5780         * top.c: Update.
5781         * tracefile-tfile.c: Update.
5782         * tui/tui.c: Update.
5783         * typeprint.c: Update.
5784         * unittests/cli-utils-selftests.c: Update.
5785         * unittests/parse-connection-spec-selftests.c: Update.
5786         * valops.c: Update.
5787         * valprint.c: Update.
5788         * value.c: Update.
5789         * varobj.c: Update.
5790         * windows-nat.c: Update.
5791         * x86-linux-nat.c: Update.
5792         * xml-support.c: Update.
5793
5794 2019-04-08  Tom Tromey  <tom@tromey.com>
5795
5796         * xml-support.c: Use C++ exception handling.
5797         * x86-linux-nat.c: Use C++ exception handling.
5798         * windows-nat.c: Use C++ exception handling.
5799         * varobj.c: Use C++ exception handling.
5800         * value.c: Use C++ exception handling.
5801         * valprint.c: Use C++ exception handling.
5802         * valops.c: Use C++ exception handling.
5803         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5804         handling.
5805         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5806         * typeprint.c: Use C++ exception handling.
5807         * tui/tui.c: Use C++ exception handling.
5808         * tracefile-tfile.c: Use C++ exception handling.
5809         * top.c: Use C++ exception handling.
5810         * thread.c: Use C++ exception handling.
5811         * target.c: Use C++ exception handling.
5812         * symmisc.c: Use C++ exception handling.
5813         * symfile-mem.c: Use C++ exception handling.
5814         * stack.c: Use C++ exception handling.
5815         * sparc64-linux-tdep.c: Use C++ exception handling.
5816         * solib.c: Use C++ exception handling.
5817         * solib-svr4.c: Use C++ exception handling.
5818         * solib-spu.c: Use C++ exception handling.
5819         * solib-frv.c: Use C++ exception handling.
5820         * solib-dsbt.c: Use C++ exception handling.
5821         * selftest-arch.c: Use C++ exception handling.
5822         * s390-tdep.c: Use C++ exception handling.
5823         * rust-lang.c: Use C++ exception handling.
5824         * rust-exp.y: Use C++ exception handling.
5825         * rs6000-tdep.c: Use C++ exception handling.
5826         * rs6000-aix-tdep.c: Use C++ exception handling.
5827         * riscv-tdep.c: Use C++ exception handling.
5828         * remote.c: Use C++ exception handling.
5829         * remote-fileio.c: Use C++ exception handling.
5830         * record-full.c: Use C++ exception handling.
5831         * record-btrace.c: Use C++ exception handling.
5832         * python/python.c: Use C++ exception handling.
5833         * python/py-value.c: Use C++ exception handling.
5834         * python/py-utils.c: Use C++ exception handling.
5835         * python/py-unwind.c: Use C++ exception handling.
5836         * python/py-type.c: Use C++ exception handling.
5837         * python/py-symbol.c: Use C++ exception handling.
5838         * python/py-record.c: Use C++ exception handling.
5839         * python/py-record-btrace.c: Use C++ exception handling.
5840         * python/py-progspace.c: Use C++ exception handling.
5841         * python/py-prettyprint.c: Use C++ exception handling.
5842         * python/py-param.c: Use C++ exception handling.
5843         * python/py-objfile.c: Use C++ exception handling.
5844         * python/py-linetable.c: Use C++ exception handling.
5845         * python/py-lazy-string.c: Use C++ exception handling.
5846         * python/py-infthread.c: Use C++ exception handling.
5847         * python/py-inferior.c: Use C++ exception handling.
5848         * python/py-gdb-readline.c: Use C++ exception handling.
5849         * python/py-framefilter.c: Use C++ exception handling.
5850         * python/py-frame.c: Use C++ exception handling.
5851         * python/py-finishbreakpoint.c: Use C++ exception handling.
5852         * python/py-cmd.c: Use C++ exception handling.
5853         * python/py-breakpoint.c: Use C++ exception handling.
5854         * python/py-arch.c: Use C++ exception handling.
5855         * printcmd.c: Use C++ exception handling.
5856         * ppc-linux-tdep.c: Use C++ exception handling.
5857         * parse.c: Use C++ exception handling.
5858         * p-valprint.c: Use C++ exception handling.
5859         * objc-lang.c: Use C++ exception handling.
5860         * mi/mi-main.c: Use C++ exception handling.
5861         * mi/mi-interp.c: Use C++ exception handling.
5862         * mi/mi-cmd-stack.c: Use C++ exception handling.
5863         * mi/mi-cmd-break.c: Use C++ exception handling.
5864         * main.c: Use C++ exception handling.
5865         * linux-thread-db.c: Use C++ exception handling.
5866         * linux-tdep.c: Use C++ exception handling.
5867         * linux-nat.c: Use C++ exception handling.
5868         * linux-fork.c: Use C++ exception handling.
5869         * linespec.c: Use C++ exception handling.
5870         * language.c: Use C++ exception handling.
5871         * jit.c: Use C++ exception handling.
5872         * infrun.c: Use C++ exception handling.
5873         * infcmd.c: Use C++ exception handling.
5874         * infcall.c: Use C++ exception handling.
5875         * inf-loop.c: Use C++ exception handling.
5876         * i386-tdep.c: Use C++ exception handling.
5877         * i386-linux-tdep.c: Use C++ exception handling.
5878         * guile/scm-value.c: Use C++ exception handling.
5879         * guile/scm-type.c: Use C++ exception handling.
5880         * guile/scm-symtab.c: Use C++ exception handling.
5881         * guile/scm-symbol.c: Use C++ exception handling.
5882         * guile/scm-pretty-print.c: Use C++ exception handling.
5883         * guile/scm-ports.c: Use C++ exception handling.
5884         * guile/scm-param.c: Use C++ exception handling.
5885         * guile/scm-math.c: Use C++ exception handling.
5886         * guile/scm-lazy-string.c: Use C++ exception handling.
5887         * guile/scm-frame.c: Use C++ exception handling.
5888         * guile/scm-disasm.c: Use C++ exception handling.
5889         * guile/scm-cmd.c: Use C++ exception handling.
5890         * guile/scm-breakpoint.c: Use C++ exception handling.
5891         * guile/scm-block.c: Use C++ exception handling.
5892         * guile/guile-internal.h: Use C++ exception handling.
5893         * gnu-v3-abi.c: Use C++ exception handling.
5894         * gdbtypes.c: Use C++ exception handling.
5895         * frame.c: Use C++ exception handling.
5896         * frame-unwind.c: Use C++ exception handling.
5897         * fbsd-tdep.c: Use C++ exception handling.
5898         * f-valprint.c: Use C++ exception handling.
5899         * exec.c: Use C++ exception handling.
5900         * event-top.c: Use C++ exception handling.
5901         * event-loop.c: Use C++ exception handling.
5902         * eval.c: Use C++ exception handling.
5903         * dwarf2read.c: Use C++ exception handling.
5904         * dwarf2loc.c: Use C++ exception handling.
5905         * dwarf2-frame.c: Use C++ exception handling.
5906         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5907         * dwarf-index-write.c: Use C++ exception handling.
5908         * dwarf-index-cache.c: Use C++ exception handling.
5909         * dtrace-probe.c: Use C++ exception handling.
5910         * disasm-selftests.c: Use C++ exception handling.
5911         * darwin-nat.c: Use C++ exception handling.
5912         * cp-valprint.c: Use C++ exception handling.
5913         * cp-support.c: Use C++ exception handling.
5914         * cp-abi.c: Use C++ exception handling.
5915         * corelow.c: Use C++ exception handling.
5916         * completer.c: Use C++ exception handling.
5917         * compile/compile-object-run.c: Use C++ exception handling.
5918         * compile/compile-object-load.c: Use C++ exception handling.
5919         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5920         * compile/compile-c-symbols.c: Use C++ exception handling.
5921         * common/selftest.c: Use C++ exception handling.
5922         * common/new-op.c: Use C++ exception handling.
5923         * cli/cli-script.c: Use C++ exception handling.
5924         * cli/cli-interp.c: Use C++ exception handling.
5925         * cli/cli-cmds.c: Use C++ exception handling.
5926         * c-varobj.c: Use C++ exception handling.
5927         * btrace.c: Use C++ exception handling.
5928         * breakpoint.c: Use C++ exception handling.
5929         * break-catch-throw.c: Use C++ exception handling.
5930         * arch-utils.c: Use C++ exception handling.
5931         * amd64-tdep.c: Use C++ exception handling.
5932         * ada-valprint.c: Use C++ exception handling.
5933         * ada-typeprint.c: Use C++ exception handling.
5934         * ada-lang.c: Use C++ exception handling.
5935         * aarch64-tdep.c: Use C++ exception handling.
5936
5937 2019-04-08  Tom Tromey  <tom@tromey.com>
5938
5939         * xml-support.c (gdb_xml_parser::parse): Update.
5940         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5941         * value.c (show_convenience): Update.
5942         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5943         (test_parse_flags_qcs): Update.
5944         * thread.c (thr_try_catch_cmd): Update.
5945         * target.c (target_translate_tls_address): Update.
5946         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5947         (info_frame_command_core, frame_apply_command_count): Update.
5948         * rust-exp.y (rust_lex_exception_test): Update.
5949         * riscv-tdep.c (riscv_print_one_register_info): Update.
5950         * remote.c (remote_target::enable_btrace): Update.
5951         * record-btrace.c (record_btrace_enable_warn): Update.
5952         * python/py-utils.c (gdbpy_convert_exception): Update.
5953         * printcmd.c (do_one_display, print_variable_and_value): Update.
5954         * mi/mi-main.c (mi_print_exception): Update.
5955         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5956         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5957         * linux-nat.c (linux_nat_target::attach): Update.
5958         * linux-fork.c (class scoped_switch_fork_info): Update.
5959         * infrun.c (displaced_step_prepare): Update.
5960         * infcall.c (call_function_by_hand_dummy): Update.
5961         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5962         * gnu-v3-abi.c (print_one_vtable): Update.
5963         * frame.c (get_prev_frame_always): Update.
5964         * f-valprint.c (info_common_command_for_block): Update.
5965         * exec.c (try_open_exec_file): Update.
5966         * exceptions.c (print_exception, exception_print)
5967         (exception_fprintf, exception_print_same): Update.
5968         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5969         * dwarf-index-cache.c (index_cache::store)
5970         (index_cache::lookup_gdb_index): Update.
5971         * darwin-nat.c (maybe_cache_shell): Update.
5972         * cp-valprint.c (cp_print_value_fields): Update.
5973         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5974         (gcc_cplus_symbol_address): Update.
5975         * compile/compile-c-symbols.c (gcc_convert_symbol)
5976         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5977         * common/selftest.c: Update.
5978         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5979         a std::string.
5980         (exception_try_scope_entry, exception_try_scope_exit): Don't
5981         declare.
5982         (struct exception_try_scope): Remove.
5983         (TRY): Don't use exception_try_scope.
5984         (struct gdb_exception): Add constructor, operator=.
5985         <what>: New method.
5986         (struct gdb_exception_RETURN_MASK_ALL)
5987         (struct gdb_exception_RETURN_MASK_ERROR)
5988         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5989         (struct gdb_quit_bad_alloc): Update.
5990         * common/common-exceptions.c (exception_none): Change
5991         initializer.
5992         (struct catcher) <state, exception>: Initialize inline.
5993         <prev>: Remove member.
5994         (current_catcher): Remove.
5995         (catchers): New global.
5996         (exceptions_state_mc_init): Simplify.
5997         (catcher_pop): Remove.
5998         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5999         (try_scope_depth, exception_try_scope_entry)
6000         (exception_try_scope_exit): Remove.
6001         (throw_exception_sjlj): Update.
6002         (exception_messages, exception_messages_size): Remove.
6003         (throw_it): Simplify.
6004         (gdb_exception_sliced_copy): Remove.
6005         (throw_exception_cxx): Update.
6006         * cli/cli-script.c (script_from_file): Update.
6007         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6008         Update.
6009         * ada-valprint.c (ada_val_print): Update.
6010         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6011         (create_excep_cond_exprs): Update.
6012
6013 2019-04-08  Tom Tromey  <tom@tromey.com>
6014
6015         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6016         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6017         (TRY, CATCH, END_CATCH): Remove some definitions.
6018         * common/common-exceptions.c: Don't use GDB_XCPT.
6019         (catcher_list_size): Remove.
6020         (throw_exception, throw_it): Simplify.
6021
6022 2019-04-05  Tom Tromey  <tom@tromey.com>
6023
6024         Revert the header-sorting patch.
6025         * ft32-tdep.c: Revert.
6026         * frv-tdep.c: Revert.
6027         * frv-linux-tdep.c: Revert.
6028         * frame.c: Revert.
6029         * frame-unwind.c: Revert.
6030         * frame-base.c: Revert.
6031         * fork-child.c: Revert.
6032         * findvar.c: Revert.
6033         * findcmd.c: Revert.
6034         * filesystem.c: Revert.
6035         * filename-seen-cache.h: Revert.
6036         * filename-seen-cache.c: Revert.
6037         * fbsd-tdep.c: Revert.
6038         * fbsd-nat.h: Revert.
6039         * fbsd-nat.c: Revert.
6040         * f-valprint.c: Revert.
6041         * f-typeprint.c: Revert.
6042         * f-lang.c: Revert.
6043         * extension.h: Revert.
6044         * extension.c: Revert.
6045         * extension-priv.h: Revert.
6046         * expprint.c: Revert.
6047         * exec.h: Revert.
6048         * exec.c: Revert.
6049         * exceptions.c: Revert.
6050         * event-top.c: Revert.
6051         * event-loop.c: Revert.
6052         * eval.c: Revert.
6053         * elfread.c: Revert.
6054         * dwarf2read.h: Revert.
6055         * dwarf2read.c: Revert.
6056         * dwarf2loc.c: Revert.
6057         * dwarf2expr.h: Revert.
6058         * dwarf2expr.c: Revert.
6059         * dwarf2-frame.c: Revert.
6060         * dwarf2-frame-tailcall.c: Revert.
6061         * dwarf-index-write.h: Revert.
6062         * dwarf-index-write.c: Revert.
6063         * dwarf-index-common.c: Revert.
6064         * dwarf-index-cache.h: Revert.
6065         * dwarf-index-cache.c: Revert.
6066         * dummy-frame.c: Revert.
6067         * dtrace-probe.c: Revert.
6068         * disasm.h: Revert.
6069         * disasm.c: Revert.
6070         * disasm-selftests.c: Revert.
6071         * dictionary.c: Revert.
6072         * dicos-tdep.c: Revert.
6073         * demangle.c: Revert.
6074         * dcache.h: Revert.
6075         * dcache.c: Revert.
6076         * darwin-nat.h: Revert.
6077         * darwin-nat.c: Revert.
6078         * darwin-nat-info.c: Revert.
6079         * d-valprint.c: Revert.
6080         * d-namespace.c: Revert.
6081         * d-lang.c: Revert.
6082         * ctf.c: Revert.
6083         * csky-tdep.c: Revert.
6084         * csky-linux-tdep.c: Revert.
6085         * cris-tdep.c: Revert.
6086         * cris-linux-tdep.c: Revert.
6087         * cp-valprint.c: Revert.
6088         * cp-support.c: Revert.
6089         * cp-namespace.c: Revert.
6090         * cp-abi.c: Revert.
6091         * corelow.c: Revert.
6092         * corefile.c: Revert.
6093         * continuations.c: Revert.
6094         * completer.h: Revert.
6095         * completer.c: Revert.
6096         * complaints.c: Revert.
6097         * coffread.c: Revert.
6098         * coff-pe-read.c: Revert.
6099         * cli-out.h: Revert.
6100         * cli-out.c: Revert.
6101         * charset.c: Revert.
6102         * c-varobj.c: Revert.
6103         * c-valprint.c: Revert.
6104         * c-typeprint.c: Revert.
6105         * c-lang.c: Revert.
6106         * buildsym.c: Revert.
6107         * buildsym-legacy.c: Revert.
6108         * build-id.h: Revert.
6109         * build-id.c: Revert.
6110         * btrace.c: Revert.
6111         * bsd-uthread.c: Revert.
6112         * breakpoint.h: Revert.
6113         * breakpoint.c: Revert.
6114         * break-catch-throw.c: Revert.
6115         * break-catch-syscall.c: Revert.
6116         * break-catch-sig.c: Revert.
6117         * blockframe.c: Revert.
6118         * block.c: Revert.
6119         * bfin-tdep.c: Revert.
6120         * bfin-linux-tdep.c: Revert.
6121         * bfd-target.c: Revert.
6122         * bcache.c: Revert.
6123         * ax-general.c: Revert.
6124         * ax-gdb.h: Revert.
6125         * ax-gdb.c: Revert.
6126         * avr-tdep.c: Revert.
6127         * auxv.c: Revert.
6128         * auto-load.c: Revert.
6129         * arm-wince-tdep.c: Revert.
6130         * arm-tdep.c: Revert.
6131         * arm-symbian-tdep.c: Revert.
6132         * arm-pikeos-tdep.c: Revert.
6133         * arm-obsd-tdep.c: Revert.
6134         * arm-nbsd-tdep.c: Revert.
6135         * arm-nbsd-nat.c: Revert.
6136         * arm-linux-tdep.c: Revert.
6137         * arm-linux-nat.c: Revert.
6138         * arm-fbsd-tdep.c: Revert.
6139         * arm-fbsd-nat.c: Revert.
6140         * arm-bsd-tdep.c: Revert.
6141         * arch-utils.c: Revert.
6142         * arc-tdep.c: Revert.
6143         * arc-newlib-tdep.c: Revert.
6144         * annotate.h: Revert.
6145         * annotate.c: Revert.
6146         * amd64-windows-tdep.c: Revert.
6147         * amd64-windows-nat.c: Revert.
6148         * amd64-tdep.c: Revert.
6149         * amd64-sol2-tdep.c: Revert.
6150         * amd64-obsd-tdep.c: Revert.
6151         * amd64-obsd-nat.c: Revert.
6152         * amd64-nbsd-tdep.c: Revert.
6153         * amd64-nbsd-nat.c: Revert.
6154         * amd64-nat.c: Revert.
6155         * amd64-linux-tdep.c: Revert.
6156         * amd64-linux-nat.c: Revert.
6157         * amd64-fbsd-tdep.c: Revert.
6158         * amd64-fbsd-nat.c: Revert.
6159         * amd64-dicos-tdep.c: Revert.
6160         * amd64-darwin-tdep.c: Revert.
6161         * amd64-bsd-nat.c: Revert.
6162         * alpha-tdep.c: Revert.
6163         * alpha-obsd-tdep.c: Revert.
6164         * alpha-nbsd-tdep.c: Revert.
6165         * alpha-mdebug-tdep.c: Revert.
6166         * alpha-linux-tdep.c: Revert.
6167         * alpha-linux-nat.c: Revert.
6168         * alpha-bsd-tdep.c: Revert.
6169         * alpha-bsd-nat.c: Revert.
6170         * aix-thread.c: Revert.
6171         * agent.c: Revert.
6172         * addrmap.c: Revert.
6173         * ada-varobj.c: Revert.
6174         * ada-valprint.c: Revert.
6175         * ada-typeprint.c: Revert.
6176         * ada-tasks.c: Revert.
6177         * ada-lang.c: Revert.
6178         * aarch64-tdep.c: Revert.
6179         * aarch64-ravenscar-thread.c: Revert.
6180         * aarch64-newlib-tdep.c: Revert.
6181         * aarch64-linux-tdep.c: Revert.
6182         * aarch64-linux-nat.c: Revert.
6183         * aarch64-fbsd-tdep.c: Revert.
6184         * aarch64-fbsd-nat.c: Revert.
6185         * aarch32-linux-nat.c: Revert.
6186
6187 2019-04-05  Tom Tromey  <tom@tromey.com>
6188
6189         * ft32-tdep.c: Sort headers.
6190         * frv-tdep.c: Sort headers.
6191         * frv-linux-tdep.c: Sort headers.
6192         * frame.c: Sort headers.
6193         * frame-unwind.c: Sort headers.
6194         * frame-base.c: Sort headers.
6195         * fork-child.c: Sort headers.
6196         * findvar.c: Sort headers.
6197         * findcmd.c: Sort headers.
6198         * filesystem.c: Sort headers.
6199         * filename-seen-cache.h: Sort headers.
6200         * filename-seen-cache.c: Sort headers.
6201         * fbsd-tdep.c: Sort headers.
6202         * fbsd-nat.h: Sort headers.
6203         * fbsd-nat.c: Sort headers.
6204         * f-valprint.c: Sort headers.
6205         * f-typeprint.c: Sort headers.
6206         * f-lang.c: Sort headers.
6207         * extension.h: Sort headers.
6208         * extension.c: Sort headers.
6209         * extension-priv.h: Sort headers.
6210         * expprint.c: Sort headers.
6211         * exec.h: Sort headers.
6212         * exec.c: Sort headers.
6213         * exceptions.c: Sort headers.
6214         * event-top.c: Sort headers.
6215         * event-loop.c: Sort headers.
6216         * eval.c: Sort headers.
6217         * elfread.c: Sort headers.
6218         * dwarf2read.h: Sort headers.
6219         * dwarf2read.c: Sort headers.
6220         * dwarf2loc.c: Sort headers.
6221         * dwarf2expr.h: Sort headers.
6222         * dwarf2expr.c: Sort headers.
6223         * dwarf2-frame.c: Sort headers.
6224         * dwarf2-frame-tailcall.c: Sort headers.
6225         * dwarf-index-write.h: Sort headers.
6226         * dwarf-index-write.c: Sort headers.
6227         * dwarf-index-common.c: Sort headers.
6228         * dwarf-index-cache.h: Sort headers.
6229         * dwarf-index-cache.c: Sort headers.
6230         * dummy-frame.c: Sort headers.
6231         * dtrace-probe.c: Sort headers.
6232         * disasm.h: Sort headers.
6233         * disasm.c: Sort headers.
6234         * disasm-selftests.c: Sort headers.
6235         * dictionary.c: Sort headers.
6236         * dicos-tdep.c: Sort headers.
6237         * demangle.c: Sort headers.
6238         * dcache.h: Sort headers.
6239         * dcache.c: Sort headers.
6240         * darwin-nat.h: Sort headers.
6241         * darwin-nat.c: Sort headers.
6242         * darwin-nat-info.c: Sort headers.
6243         * d-valprint.c: Sort headers.
6244         * d-namespace.c: Sort headers.
6245         * d-lang.c: Sort headers.
6246         * ctf.c: Sort headers.
6247         * csky-tdep.c: Sort headers.
6248         * csky-linux-tdep.c: Sort headers.
6249         * cris-tdep.c: Sort headers.
6250         * cris-linux-tdep.c: Sort headers.
6251         * cp-valprint.c: Sort headers.
6252         * cp-support.c: Sort headers.
6253         * cp-namespace.c: Sort headers.
6254         * cp-abi.c: Sort headers.
6255         * corelow.c: Sort headers.
6256         * corefile.c: Sort headers.
6257         * continuations.c: Sort headers.
6258         * completer.h: Sort headers.
6259         * completer.c: Sort headers.
6260         * complaints.c: Sort headers.
6261         * coffread.c: Sort headers.
6262         * coff-pe-read.c: Sort headers.
6263         * cli-out.h: Sort headers.
6264         * cli-out.c: Sort headers.
6265         * charset.c: Sort headers.
6266         * c-varobj.c: Sort headers.
6267         * c-valprint.c: Sort headers.
6268         * c-typeprint.c: Sort headers.
6269         * c-lang.c: Sort headers.
6270         * buildsym.c: Sort headers.
6271         * buildsym-legacy.c: Sort headers.
6272         * build-id.h: Sort headers.
6273         * build-id.c: Sort headers.
6274         * btrace.c: Sort headers.
6275         * bsd-uthread.c: Sort headers.
6276         * breakpoint.h: Sort headers.
6277         * breakpoint.c: Sort headers.
6278         * break-catch-throw.c: Sort headers.
6279         * break-catch-syscall.c: Sort headers.
6280         * break-catch-sig.c: Sort headers.
6281         * blockframe.c: Sort headers.
6282         * block.c: Sort headers.
6283         * bfin-tdep.c: Sort headers.
6284         * bfin-linux-tdep.c: Sort headers.
6285         * bfd-target.c: Sort headers.
6286         * bcache.c: Sort headers.
6287         * ax-general.c: Sort headers.
6288         * ax-gdb.h: Sort headers.
6289         * ax-gdb.c: Sort headers.
6290         * avr-tdep.c: Sort headers.
6291         * auxv.c: Sort headers.
6292         * auto-load.c: Sort headers.
6293         * arm-wince-tdep.c: Sort headers.
6294         * arm-tdep.c: Sort headers.
6295         * arm-symbian-tdep.c: Sort headers.
6296         * arm-pikeos-tdep.c: Sort headers.
6297         * arm-obsd-tdep.c: Sort headers.
6298         * arm-nbsd-tdep.c: Sort headers.
6299         * arm-nbsd-nat.c: Sort headers.
6300         * arm-linux-tdep.c: Sort headers.
6301         * arm-linux-nat.c: Sort headers.
6302         * arm-fbsd-tdep.c: Sort headers.
6303         * arm-fbsd-nat.c: Sort headers.
6304         * arm-bsd-tdep.c: Sort headers.
6305         * arch-utils.c: Sort headers.
6306         * arc-tdep.c: Sort headers.
6307         * arc-newlib-tdep.c: Sort headers.
6308         * annotate.h: Sort headers.
6309         * annotate.c: Sort headers.
6310         * amd64-windows-tdep.c: Sort headers.
6311         * amd64-windows-nat.c: Sort headers.
6312         * amd64-tdep.c: Sort headers.
6313         * amd64-sol2-tdep.c: Sort headers.
6314         * amd64-obsd-tdep.c: Sort headers.
6315         * amd64-obsd-nat.c: Sort headers.
6316         * amd64-nbsd-tdep.c: Sort headers.
6317         * amd64-nbsd-nat.c: Sort headers.
6318         * amd64-nat.c: Sort headers.
6319         * amd64-linux-tdep.c: Sort headers.
6320         * amd64-linux-nat.c: Sort headers.
6321         * amd64-fbsd-tdep.c: Sort headers.
6322         * amd64-fbsd-nat.c: Sort headers.
6323         * amd64-dicos-tdep.c: Sort headers.
6324         * amd64-darwin-tdep.c: Sort headers.
6325         * amd64-bsd-nat.c: Sort headers.
6326         * alpha-tdep.c: Sort headers.
6327         * alpha-obsd-tdep.c: Sort headers.
6328         * alpha-nbsd-tdep.c: Sort headers.
6329         * alpha-mdebug-tdep.c: Sort headers.
6330         * alpha-linux-tdep.c: Sort headers.
6331         * alpha-linux-nat.c: Sort headers.
6332         * alpha-bsd-tdep.c: Sort headers.
6333         * alpha-bsd-nat.c: Sort headers.
6334         * aix-thread.c: Sort headers.
6335         * agent.c: Sort headers.
6336         * addrmap.c: Sort headers.
6337         * ada-varobj.c: Sort headers.
6338         * ada-valprint.c: Sort headers.
6339         * ada-typeprint.c: Sort headers.
6340         * ada-tasks.c: Sort headers.
6341         * ada-lang.c: Sort headers.
6342         * aarch64-tdep.c: Sort headers.
6343         * aarch64-ravenscar-thread.c: Sort headers.
6344         * aarch64-newlib-tdep.c: Sort headers.
6345         * aarch64-linux-tdep.c: Sort headers.
6346         * aarch64-linux-nat.c: Sort headers.
6347         * aarch64-fbsd-tdep.c: Sort headers.
6348         * aarch64-fbsd-nat.c: Sort headers.
6349         * aarch32-linux-nat.c: Sort headers.
6350
6351 2019-04-04  Tom Tromey  <tom@tromey.com>
6352
6353         * varobj.c (varobj_create): Update.
6354         * rust-exp.y (struct rust_parser) <update_innermost_block,
6355         lookup_symbol>: New methods.
6356         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6357         Rename.
6358         (rust_parser::rust_lookup_type)
6359         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6360         * printcmd.c (display_command, do_one_display): Update.
6361         * parser-defs.h (struct parser_state) <parser_state>: Add
6362         "tracker" parameter.
6363         (block_tracker): New member.
6364         (class innermost_block_tracker) <innermost_block_tracker>: Add
6365         "types" parameter.
6366         <reset>: Remove method.
6367         (innermost_block): Don't declare.
6368         (null_post_parser): Update.
6369         * parse.c (innermost_block): Remove global.
6370         (write_dollar_variable): Update.
6371         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6372         Remove "tracker_types" parameter.
6373         (parse_expression): Add "tracker" parameter.
6374         (parse_expression_for_completion): Update.
6375         (null_post_parser): Add "tracker" parameter.
6376         * p-exp.y: Update rules.
6377         * m2-exp.y: Update rules.
6378         * language.h (struct language_defn) <la_post_parser>: Add
6379         "tracker" parameter.
6380         * go-exp.y: Update rules.
6381         * f-exp.y: Update rules.
6382         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6383         parameter.
6384         * d-exp.y: Update rules.
6385         * c-exp.y: Update rules.
6386         * breakpoint.c (set_breakpoint_condition): Create an
6387         innermost_block_tracker.
6388         (watch_command_1): Likewise.
6389         * ada-lang.c (resolve): Add "tracker" parameter.
6390         (resolve_subexp): Likewise.
6391         * ada-exp.y (write_var_from_sym): Update.
6392
6393 2019-04-04  Tom Tromey  <tom@tromey.com>
6394
6395         * type-stack.h: New file.
6396         * type-stack.c: New file.
6397         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6398         type-stack.h.
6399         (insert_into_type_stack, insert_type, push_type, push_type_int)
6400         (insert_type_address_space, pop_type, pop_type_int)
6401         (pop_typelist, pop_type_stack, append_type_stack)
6402         (push_type_stack, get_type_stack, push_typelist)
6403         (follow_type_instance_flags, follow_types): Don't declare.
6404         * parse.c (type_stack): Remove global.
6405         (parse_exp_in_context): Update.
6406         (insert_into_type_stack, insert_type, push_type, push_type_int)
6407         (insert_type_address_space, pop_type, pop_type_int)
6408         (pop_typelist, pop_type_stack, append_type_stack)
6409         (push_type_stack, get_type_stack, push_typelist)
6410         (follow_type_instance_flags, follow_types): Remove (moved to
6411         type-stack.c).
6412         * f-exp.y (type_stack): New global.
6413         Update rules.
6414         (push_kind_type, f_parse): Update.
6415         * d-exp.y (type_stack): New global.
6416         Update rules.
6417         (d_parse): Update.
6418         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6419         Update rules.
6420         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6421         (HFILES_NO_SRCDIR): Add type-stack.h.
6422
6423 2019-04-04  Tom Tromey  <tom@tromey.com>
6424
6425         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6426         (rust_parser::convert_ast_to_expression, rust_parse)
6427         (rust_lex_test_completion, rust_lex_tests): Update.
6428         * parser-defs.h (struct expr_completion_state): New.
6429         (struct parser_state) <parser_state>: Add completion parameter.
6430         <mark_struct_expression, mark_completion_tag>: New methods.
6431         <parse_completion, m_completion_state>: New members.
6432         (prefixify_expression, null_post_parser): Update.
6433         (mark_struct_expression, mark_completion_tag): Don't declare.
6434         * parse.c (parse_completion, expout_last_struct)
6435         (expout_tag_completion_type, expout_completion_name): Remove
6436         globals.
6437         (parser_state::mark_struct_expression)
6438         (parser_state::mark_completion_tag): Now methods.
6439         (prefixify_expression): Add last_struct parameter.
6440         (prefixify_subexp): Likewise.
6441         (parse_exp_1): Update.
6442         (parse_exp_in_context): Add cstate parameter.  Update.
6443         (parse_expression_for_completion): Create an
6444         expr_completion_state.
6445         (null_post_parser): Add "completion" parameter.
6446         * p-exp.y: Update rules.
6447         (yylex): Update.
6448         * language.h (struct language_defn) <la_post_parser>: Add
6449         "completing" parameter.
6450         * go-exp.y: Update rules.
6451         (lex_one_token): Update.
6452         * expression.h (parse_completion): Don't declare.
6453         * d-exp.y: Update rules.
6454         (lex_one_token): Update rules.
6455         * c-exp.y: Update rules.
6456         (lex_one_token): Update.
6457         * ada-lang.c (resolve): Add "parse_completion" parameter.
6458         (resolve_subexp): Likewise.
6459         (ada_resolve_function): Likewise.
6460
6461 2019-04-04  Tom Tromey  <tom@tromey.com>
6462
6463         * parser-defs.h (struct parser_state) <start_arglist,
6464         end_arglist>: New methods.
6465         <arglist_len, m_funcall_chain>: New members.
6466         (arglist_len, start_arglist, end_arglist): Don't declare.
6467         * parse.c (arglist_len, funcall_chain): Remove global.
6468         (start_arglist, end_arglist): Remove functions.
6469         (parse_exp_in_context): Update.
6470         * p-exp.y: Update rules.
6471         * m2-exp.y: Update rules.
6472         * go-exp.y: Update rules.
6473         * f-exp.y: Update rules.
6474         * d-exp.y: Update rules.
6475         * c-exp.y: Update rules.
6476
6477 2019-04-04  Tom Tromey  <tom@tromey.com>
6478
6479         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6480         lex_operator, push_back>: New methods.
6481         Update all rules.
6482         (rust_parser::lex_hex, lex_escape): Rename and update.
6483         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6484         (rust_parser::lex_operator): Rename and update.
6485         (rust_parser::lex_number, rustyylex, rustyyerror)
6486         (rust_lex_test_init, rust_lex_test_sequence)
6487         (rust_lex_test_push_back, rust_lex_tests): Update.
6488         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6489         parameter.
6490         <lexptr, prev_lexptr>: New members.
6491         (lexptr, prev_lexptr): Don't declare.
6492         * parse.c (lexptr, prev_lexptr): Remove globals.
6493         (parse_exp_in_context): Update.
6494         * p-exp.y (yylex, yyerror): Update.
6495         * m2-exp.y (parse_number, yylex, yyerror): Update.
6496         * go-exp.y (lex_one_token, yyerror): Update.
6497         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6498         * d-exp.y (lex_one_token, yyerror): Update.
6499         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6500         (lex_one_token, yyerror): Update.
6501         * ada-lex.l (YY_INPUT): Update.
6502         (rewind_to_char): Update.
6503         * ada-exp.y (yyerror): Update.
6504
6505 2019-04-04  Tom Tromey  <tom@tromey.com>
6506
6507         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6508         * parser-defs.h (struct parser_state) <parser_state>: Add new
6509         parameter.
6510         <comma_terminates>: New member.
6511         (comma_terminates): Don't declare global.
6512         * parse.c (comma_terminates): Remove global.
6513         (parse_exp_in_context): Update.
6514         * p-exp.y (yylex): Update.
6515         * m2-exp.y (yylex): Update.
6516         * go-exp.y (lex_one_token): Update.
6517         * f-exp.y (yylex): Update.
6518         * d-exp.y (lex_one_token): Update.
6519         * c-exp.y (lex_one_token): Update.
6520         * ada-lex.l: Update.
6521
6522 2019-04-04  Tom Tromey  <tom@tromey.com>
6523
6524         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6525         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6526         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6527         * parser-defs.h (paren_depth): Don't declare.
6528         * parse.c (paren_depth): Remove global.
6529         (parse_exp_in_context): Update.
6530         * p-exp.y (paren_depth): New global.
6531         (pascal_parse): Initialize it.
6532         * m2-exp.y (paren_depth): New global.
6533         (m2_parse): Initialize it.
6534         * go-exp.y (paren_depth): New global.
6535         (go_parse): Initialize it.
6536         * f-exp.y (paren_depth): New global.
6537         (f_parse): Initialize it.
6538         * d-exp.y (paren_depth): New global.
6539         (d_parse): Initialize it.
6540         * c-exp.y (paren_depth): New global.
6541         (c_parse): Initialize it.
6542         * ada-lex.l (paren_depth): New global.
6543         (lexer_init): Initialize it.
6544
6545 2019-04-04  Tom Tromey  <tom@tromey.com>
6546
6547         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6548         (rust_parser::convert_ast_to_type)
6549         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6550         * parser-defs.h (struct parser_state) <parser_state>: Add
6551         parameters.  Initialize new members.
6552         <expression_context_block, expression_context_pc>: New members.
6553         * parse.c (expression_context_block, expression_context_pc):
6554         Remove globals.
6555         (parse_exp_in_context): Update.
6556         * p-exp.y: Update all rules.
6557         (yylex): Update.
6558         * m2-exp.y: Update all rules.
6559         (yylex): Update.
6560         * go-exp.y (yylex): Update.
6561         * f-exp.y (yylex): Update.
6562         * d-exp.y: Update all rules.
6563         (yylex): Update.
6564         * c-exp.y: Update all rules.
6565         (lex_one_token, classify_name, yylex, c_parse): Update.
6566         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6567
6568 2019-04-04  Tom Tromey  <tom@tromey.com>
6569
6570         * gdbarch.h, gdbarch.c: Rebuild.
6571         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6572         * stap-probe.h:
6573         (struct stap_parse_info): Replace "parser_state" with
6574         "expr_builder".
6575         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6576         (parser_state): New class.
6577         * parse.c (expr_builder): Rename.
6578         (expr_builder::release): Rename.
6579         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6580         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6581         (write_exp_elt_longcst, write_exp_elt_floatcst)
6582         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6583         (write_exp_string_vector, write_exp_bitstring)
6584         (write_exp_msymbol, mark_struct_expression)
6585         (write_dollar_variable)
6586         (insert_type_address_space, increase_expout_size): Replace
6587         "parser_state" with "expr_builder".
6588         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6589         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6590         "parser_state" with "expr_builder".
6591
6592 2019-04-04  Tom Tromey  <tom@tromey.com>
6593
6594         * rust-exp.y: Replace "parse_language" with method call.
6595         * p-exp.y:
6596         (yylex): Replace "parse_language" with method call.
6597         * m2-exp.y:
6598         (yylex): Replace "parse_language" with method call.
6599         * go-exp.y (classify_name): Replace "parse_language" with method
6600         call.
6601         * f-exp.y (yylex): Replace "parse_language" with method call.
6602         * d-exp.y (lex_one_token): Replace "parse_language" with method
6603         call.
6604         * c-exp.y:
6605         (lex_one_token, classify_name, yylex): Replace "parse_language"
6606         with method call.
6607         * ada-exp.y (find_primitive_type, type_char)
6608         (type_system_address): Replace "parse_language" with method call.
6609
6610 2019-04-04  Tom Tromey  <tom@tromey.com>
6611
6612         * rust-exp.y: Replace "parse_gdbarch" with method call.
6613         * parse.c (write_dollar_variable, insert_type_address_space):
6614         Replace "parse_gdbarch" with method call.
6615         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6616         call.
6617         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6618         call.
6619         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6620         "parse_gdbarch" with method call.
6621         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6622         with method call.
6623         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6624         "parse_gdbarch" with method call.
6625         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6626         "parse_gdbarch" with method call.
6627         * c-exp.y (parse_type, parse_number, classify_name): Replace
6628         "parse_gdbarch" with method call.
6629         * ada-lex.l: Replace "parse_gdbarch" with method call.
6630         * ada-exp.y (parse_type, find_primitive_type, type_char)
6631         (type_system_address): Replace "parse_gdbarch" with method call.
6632
6633 2019-04-04  Tom Tromey  <tom@tromey.com>
6634
6635         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6636         * stap-probe.c (stap_parse_argument): Update.
6637         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6638         initial_size parameter.
6639         * rust-exp.y (rust_lex_tests): Update.
6640         * parse.c (parser_state): Update.
6641         (parse_exp_in_context): Update.
6642         * parser-defs.h (struct parser_state) <parser_state>: Remove
6643         "initial_size" parameter.
6644
6645 2019-04-04  Tom Tromey  <tom@tromey.com>
6646
6647         * parser-defs.h (increase_expout_size): Don't declare.
6648         * parse.c (increase_expout_size): Now static.
6649
6650 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6651
6652         * gnu-nat.c (gnu_nat_target::wait): Fix
6653         target_waitstatus_to_string call.
6654
6655 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6656
6657         * eval.c (evaluate_subexp_standard): Handle internal functions
6658         during Fortran function call handling.
6659
6660 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * NEWS: Mention new internal functions.
6663         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6664         (read_base_type): Use dwarf2_init_complex_target_type.
6665         * value.c (creal_internal_fn): New function.
6666         (cimag_internal_fn): New function.
6667         (_initialize_values): Register new internal functions.
6668
6669 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6670
6671         * infrun.c (stop_all_threads): If debug_infrun, always
6672         trace the wait status after wait_one, using
6673         target_waitstatus_to_string and target_pid_to_str.
6674         (handle_inferior_event): Replace various trace of
6675         wait status kind by a single trace.
6676         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6677         wait status kind image by target_waitstatus_to_string.
6678         * target/waitstatus.c (target_waitstatus_to_string): Fix
6679         obsolete comment.
6680
6681 2019-04-01  Tom Tromey  <tromey@adacore.com>
6682
6683         PR symtab/23331:
6684         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6685
6686 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6687             Pedro Alves  <palves@redhat.com>
6688
6689         * top.c (quit_force): Call 'finalize_values'.
6690         * value.c (finalize_values): New function.
6691         * value.h (finalize_values): Declare.
6692
6693 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6694
6695         * NEWS: Announce $_gdb_major and $_gdb_minor.
6696
6697         * top.c (init_gdb_version_vars): New function.
6698         (gdb_init): Call init_gdb_version_vars.
6699
6700 2019-03-29  Tom Tromey  <tromey@adacore.com>
6701
6702         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6703         help text.  Remove dead code.
6704
6705 2019-03-29  Keith Seitz  <keiths@redhat.com>
6706
6707         From Siddhesh Poyarekar:
6708         * f-lang.h (f77_get_upperbound): Return LONGEST.
6709         (f77_get_lowerbound): Likewise.
6710         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6711         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6712         print them.
6713         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6714         plongest to format print it.
6715         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6716         (f77_get_upperbound): Likewise.
6717         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6718         LOWER_BOUND to LONGEST.
6719         (f77_create_arrayprint_offset_tbl): Likewise.
6720
6721 2019-03-29  Keith Seitz  <keiths@redhat.com>
6722
6723         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6724         %s/pulongest for TYPE_LENGTH instead of %d in format
6725         strings.
6726         * ada-typerint.c (ada_print_type): Likewise.
6727         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6728         * compile/compile-c-support.c (generate_register_struct): Likewise.
6729         * gdbtypes.c (recursive_dump_type): Likewise.
6730         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6731         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6732         instead of %d in format strings.
6733         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6734         to std::min to ULONGEST.
6735         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6736         instead of %d in format strings.
6737         * tracepoint.c (info_scope_command): Likewise.
6738         * typeprint.c (print_offset_data::update)
6739         (print_offset_data::finish): Likewise.
6740         * xtensa-tdep.c (xtensa_store_return_value)
6741         (xtensa_push_dummy_call): Likewise.
6742
6743 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6744
6745         * windows-nat.c (display_selector): Fixed format specifications
6746         for 64-bit Cygwin.
6747
6748 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6749
6750         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6751
6752 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6753
6754         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6755         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6756         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6757         (nios2_linux_init_abi): Install it.
6758
6759 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6760
6761         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6762
6763 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6764
6765         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6766
6767 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6768             Tom Tromey  <tromey@adacore.com>
6769
6770         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6771
6772 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6773
6774         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6775         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6776         method to compute the bounds of range types. Also print "[evaluated]"
6777         if the bounds' values come from a dynamic evaluation.
6778
6779 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6780
6781         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6782         whitespace when pretty printing is on.
6783
6784 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6785
6786         * ppc-linux-nat.c: Add include.
6787
6788 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6789
6790         * NEWS: Mention AArch64 Pointer Authentication.
6791
6792 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6793
6794         * arm-linux-nat.c: Add include.
6795
6796 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6797
6798         * source-cache.c (source_cache::get_source_lines): Re-read
6799         fullname after calling open_source_file.
6800
6801 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6802
6803         * NEWS: Mention TLS support for FreeBSD.
6804
6805 2019-03-25  Tom Tromey  <tromey@adacore.com>
6806
6807         * minsyms.c (BUNCH_SIZE): Update comment.
6808         (~minimal_symbol_reader): Remove old comment.
6809         (compact_minimal_symbols): Update comment.
6810         (minimal_symbol_reader::install): Remove old comment.  Update
6811         other comments.
6812
6813 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6814
6815         * s390-linux-nat.c: Add include.
6816
6817 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6818
6819         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6820         Call linux_get_hwcap.
6821         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6822         Likewise.
6823         (aarch64_linux_get_hwcap): Remove function.
6824         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6825         declaration.
6826         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6827         linux_get_hwcap.
6828         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6829         * linux-tdep.c (linux_get_hwcap): Add function.
6830         (linux_get_hwcap2): Likewise.
6831         * linux-tdep.h (linux_get_hwcap): Add declaration.
6832         (linux_get_hwcap2): Likewise.
6833         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6834         (ppc_linux_get_hwcap2): Likewise.
6835         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6836         linux_get_hwcap.
6837         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6838         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6839         (ppc_linux_nat_target::read_description): Likewise.
6840         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6841         * s390-linux-nat.c: Likewise.
6842         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6843
6844 2019-03-24  Tom Tromey  <tom@tromey.com>
6845
6846         * ada-lang.c (standard_lookup): Simplify initialization.
6847         (ada_lookup_symbol_nonlocal): Simplify return.
6848         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6849         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6850         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6851         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6852         initialization.
6853         * solib.c (solib_global_lookup): Simplify.
6854         * symtab.c (null_block_symbol): Remove.
6855         (symbol_cache_lookup): Simplify returns.
6856         (lookup_language_this): Simplify returns.
6857         (lookup_symbol_aux): Simplify return.
6858         (lookup_local_symbol): Simplify returns.
6859         (lookup_global_symbol_from_objfile): Simplify return.
6860         (lookup_symbol_in_objfile_symtabs)
6861         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6862         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6863         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6864         * cp-namespace.c (cp_lookup_bare_symbol)
6865         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6866         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6867         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6868         (cp_lookup_symbol_via_imports): Simplify initialization.
6869         (find_symbol_in_baseclass): Likewise.
6870         * symtab.h (null_block_symbol): Remove.
6871         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6872         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6873         (d_lookup_symbol_module): Likewise.
6874         (find_symbol_in_baseclass): Simplify initialization.
6875
6876 2019-03-24  Tom Tromey  <tom@tromey.com>
6877
6878         * expression.h: Don't include symtab.h.
6879         (struct block): Forward declare.
6880
6881 2019-03-24  Tom Tromey  <tom@tromey.com>
6882
6883         * c-exp.y (typebase): Remove casts.
6884         * gdbtypes.c (lookup_unsigned_typename, )
6885         (lookup_signed_typename): Remove cast.
6886         * eval.c (parse_to_comma_and_eval): Remove cast.
6887         * parse.c (write_dollar_variable): Remove cast.
6888         * block.h (struct block) <superblock>: Now const.
6889         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6890         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6891         (map_block): Make "block" const.
6892         * symfile.h (struct quick_symbol_functions)
6893         <map_matching_symbols>: Constify block argument to "callback".
6894         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6895         const.
6896         (find_pc_sect_compunit_symtab): Make "b" const.
6897         (find_symbol_at_address): Likewise.
6898         (search_symbols): Likewise.
6899         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6900         (dw2_debug_names_lookup_symbol): Likewise.
6901         (dw2_map_matching_symbols): Update.
6902         * p-valprint.c (pascal_val_print): Remove "block".
6903         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6904         (aux_add_nonlocal_symbols): Make "block" const.
6905         (resolve_subexp): Remove cast.
6906         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6907         const.
6908         (iterate_over_file_blocks): Likewise.
6909         * f-exp.y (%union) <bval>: Remove.
6910         * coffread.c (patch_opaque_types): Make "b" const.
6911         * spu-tdep.c (spu_catch_start): Make "block" const.
6912         * c-valprint.c (print_unpacked_pointer): Remove "block".
6913         * symmisc.c (dump_symtab_1): Make "b" const.
6914         (block_depth): Make "block" const.
6915         * d-exp.y (%union) <bval>: Remove.
6916         * cp-support.h (cp_lookup_rtti_type): Update.
6917         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6918         * psymtab.c (psym_lookup_symbol): Make "block" const.
6919         (maintenance_check_psymtabs): Make "b" const.
6920         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6921         (enumerate_locals, enumerate_args): Update.
6922         * python/py-symtab.c (stpy_global_block): Make "block" const.
6923         (stpy_static_block): Likewise.
6924         * inline-frame.c (block_starting_point_at): Make "new_block"
6925         const.
6926         * block.c (find_block_in_blockvector): Make return type const.
6927         (blockvector_for_pc_sect): Make "b" const.
6928         (find_block_in_blockvector): Make "b" const.
6929
6930 2019-03-23  Tom Tromey  <tom@tromey.com>
6931
6932         * varobj.c (varobj_create): Update.
6933         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6934         * printcmd.c (display_command, do_one_display): Don't reset
6935         innermost_block.
6936         * parser-defs.h (enum innermost_block_tracker_type): Move to
6937         expression.h.
6938         (innermost_block): Update comment.
6939         * parse.c (parse_exp_1): Add tracker_types parameter.
6940         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6941         tracker_types parameter.  Reset innermost_block.
6942         (parse_exp_in_context): Remove.
6943         (parse_expression_for_completion): Update.
6944         * objfiles.c (~objfile): Don't reset expression_context_block or
6945         innermost_block.
6946         * expression.h (enum innermost_block_tracker_type): Move from
6947         parser-defs.h.
6948         (parse_exp_1): Add tracker_types parameter.
6949         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6950         reset innermost_block.
6951
6952 2019-03-23  Tom Tromey  <tom@tromey.com>
6953
6954         * objfiles.h: Include bcache.h.
6955
6956 2019-03-23  Tom Tromey  <tom@tromey.com>
6957
6958         * linespec.c (get_current_search_block): Use
6959         scoped_restore_current_language.
6960         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6961
6962 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6963             Jiong Wang  <jiong.wang@arm.com>
6964
6965         * aarch64-linux-tdep.c
6966         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6967         section.
6968         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6969
6970 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6971             Jiong Wang  <jiong.wang@arm.com>
6972
6973         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6974         instructions.
6975         (aarch64_analyze_prologue_test): Add PACIASP test.
6976         (aarch64_prologue_prev_register): Unmask PC value.
6977
6978 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6979             Jiong Wang  <jiong.wang@arm.com>
6980
6981         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6982         (aarch64_dwarf2_prev_register): Unmask PC value.
6983         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6984         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6985         DW_CFA_AARCH64_negate_ra_state.
6986         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6987
6988 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6989             Jiong Wang  <jiong.wang@arm.com>
6990
6991         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6992         registers.
6993         (aarch64_pseudo_register_name): Likewise.
6994         (aarch64_pseudo_register_type): Likewise.
6995         (aarch64_pseudo_register_reggroup_p): Likewise.
6996         (aarch64_gdbarch_init): Add pauth registers.
6997         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6998         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6999         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7000         (struct gdbarch_tdep): Add regnum for ra_state.
7001
7002 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7003             Jiong Wang  <jiong.wang@arm.com>
7004
7005         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7006
7007 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7008             Jiong Wang  <jiong.wang@arm.com>
7009
7010         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7011         function.
7012         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7013         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7014         (aarch64_gdbarch_init): Add puth registers.
7015         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7016         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7017         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7018
7019 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7020             Jiong Wang  <jiong.wang@arm.com>
7021
7022         * aarch64-linux-nat.c
7023         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7024         * aarch64-linux-tdep.c
7025         (aarch64_linux_core_read_description): Likewise.
7026         (aarch64_linux_get_hwcap): New function.
7027         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7028         (aarch64_linux_get_hwcap): New declaration.
7029
7030 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7031             Jiong Wang  <jiong.wang@arm.com>
7032
7033         * aarch64-linux-nat.c
7034         (aarch64_linux_nat_target::read_description): Add pauth param.
7035         * aarch64-linux-tdep.c
7036         (aarch64_linux_core_read_description): Likewise.
7037         * aarch64-tdep.c (struct target_desc): Add in pauth.
7038         (aarch64_read_description): Add pauth param.
7039         (aarch64_gdbarch_init): Likewise.
7040         * aarch64-tdep.h (aarch64_read_description): Likewise.
7041         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7042         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7043         * features/Makefile: Add new files.
7044         * features/aarch64-pauth.c: New file.
7045         * features/aarch64-pauth.xml: New file.
7046
7047 2019-03-20  Tom Tromey  <tromey@adacore.com>
7048
7049         * infrun.c (handle_inferior_event): Rename from
7050         handle_inferior_event_1.  Create a scoped_value_mark.
7051         (handle_inferior_event): Remove.
7052
7053 2019-03-19  Tom Tromey  <tromey@adacore.com>
7054
7055         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7056         * infrun.h (print_stop_event): Add "displays" parameter.
7057         * infrun.c (print_stop_event): Add "displays" parameter.
7058
7059 2019-03-19  Pedro Alves  <palves@redhat.com>
7060
7061         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7062         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7063         to -1.  Fix TABs vs spaces.
7064         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7065         * tui/tui-out.h (tui_ui_out) Add intro comments.
7066         <m_line, m_start_of_line>: In-class initialize, and add describing
7067         comment.
7068
7069 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7070
7071         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7072         variable names.
7073         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7074
7075 2019-03-18  Pedro Alves  <palves@redhat.com>
7076             Eli Zaretskii <eliz@gnu.org>
7077
7078         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7079         m_line and m_start_of_line.
7080
7081 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7082
7083         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7084         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7085         it returns a newline.  This fixes a regression in TU mode, whereby
7086         the next line is output on the same screen line as the user input.
7087
7088 2019-03-18  Tom Tromey  <tromey@adacore.com>
7089
7090         * minsyms.c (minimal_symbol_reader::install): Remove call to
7091         obstack_blank.
7092
7093 2019-03-18  Pedro Alves  <palves@redhat.com>
7094
7095         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7096         New globals.
7097         (apply_style): New, factored out from ...
7098         (apply_ansi_escape): ... this.  Handle reverse video mode.
7099         (tui_set_reverse_mode): New function.
7100         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7101         * tui/tui-winsource.c (tui_show_source_line): Use
7102         tui_set_reverse_mode instead of setting A_STANDOUT.
7103         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7104         New setter methods.
7105
7106 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7107
7108         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7109         Handle tabs.
7110
7111 2019-03-18  Tom Tromey  <tromey@adacore.com>
7112
7113         * ada-lang.c (empty_array): Add "high" parameter.
7114         (ada_evaluate_subexp): Update.
7115
7116 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7117
7118         * unittests/string_view-selftests.c: Define
7119         _initialize_string_view_selftests unconditionally.
7120
7121 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7122
7123         PR gdb/24350
7124         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7125
7126 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7127
7128         PR gdb/24351
7129         * windows-nat.c (display_selector): Fix format specifiers.
7130
7131 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7132
7133         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7134         tui_refill_source_window instead of tui_refresh_win, to update the
7135         current execution line.  This fixes redisplay of the current line
7136         when stepping through the code with "next" or "step".
7137
7138 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7139
7140         * source-cache.c (source_cache::get_source_lines): Call
7141         find_source_lines to initialize s->nlines.  This fixes vertical
7142         scrolling of TUI source window when the DOWN arrow is pressed.
7143
7144 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7145
7146         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7147         linux-thread-db.c (_initialize_thread_db): Likewise.
7148
7149 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7150
7151         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7152         wclrtoeol in tui_show_source_line".  This reverts changes made in
7153         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7154
7155 2019-03-15  Tom Tromey  <tom@tromey.com>
7156
7157         * symtab.h (struct minimal_symbol): Derive from
7158         general_symbol_info.
7159         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7160         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7161         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7162         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7163         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7164         (MSYMBOL_SEARCH_NAME): Update.
7165         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7166         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7167         * minsyms.c (minimal_symbol_reader::record_full): Update.
7168
7169 2019-03-15  Tom Tromey  <tom@tromey.com>
7170
7171         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7172
7173 2019-03-15  Tom Tromey  <tom@tromey.com>
7174
7175         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7176         unique_xmalloc_ptr.
7177         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7178         Update.
7179         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7180         (build_minimal_symbol_hash_tables)
7181         (minimal_symbol_reader::install): Update.
7182
7183 2019-03-15  Tom Tromey  <tom@tromey.com>
7184
7185         * symtab.c (create_demangled_names_hash): Update.
7186         (symbol_set_names): Update.
7187         * objfiles.h (struct objfile_per_bfd_storage)
7188         <demangled_names_hash>: Now an htab_up.
7189         * objfiles.c (objfile_per_bfd_storage): Simplify.
7190
7191 2019-03-15  Tom Tromey  <tom@tromey.com>
7192
7193         * objfiles.h (struct objfile_per_bfd_storage): Declare
7194         destructor.
7195         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7196         New.
7197         (get_objfile_bfd_data): Use new.  Don't initialize
7198         language_of_main.
7199         (free_objfile_per_bfd_storage): Remove.
7200         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7201
7202 2019-03-15  Tom Tromey  <tom@tromey.com>
7203
7204         * symfile.c (reread_symbols): Update.
7205         * objfiles.c (objfile::objfile): Update.
7206         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7207         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7208         comment.
7209         (minimal_symbol_reader::install): Update.
7210         (terminate_minimal_symbol_table): Remove.
7211         * jit.c (jit_object_close_impl): Update.
7212
7213 2019-03-15  Tom Tromey  <tom@tromey.com>
7214
7215         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7216         initializations.
7217
7218 2019-03-15  Tom Tromey  <tom@tromey.com>
7219
7220         * objfiles.h (struct objfile_per_bfd_storage)
7221         <demangled_hash_languages>: Now a bitset.
7222         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7223         (lookup_minimal_symbol): Update.
7224
7225 2019-03-15  Tom Tromey  <tom@tromey.com>
7226
7227         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7228         Don't return the symbol.
7229         * coffread.c (record_minimal_symbol): Use record_full.
7230
7231 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7232
7233         The MS-Windows port of ncurses fails to switch to a color pair if
7234         one or both of the colors are the implicit default colors.  This
7235         change records the default colors when TUI is initialized, and
7236         then specifies them explicitly when a color pair uses the default
7237         colors.  This allows color styling in TUI mode on MS-Windows.
7238
7239         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7240         ncurses_norm_attr.
7241         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7242         colors in ncurses_norm_attr.
7243         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7244         "none", replace it with the default color recorded in
7245         ncurses_norm_attr.
7246
7247 2019-03-14  Tom Tromey  <tromey@adacore.com>
7248
7249         * source-cache.h (class source_cache) <get_source_lines>: Return
7250         std::string.
7251         * source-cache.c (source_cache::extract_lines): Handle case where
7252         first_pos==npos.  Return std::string.
7253         (source_cache::get_source_lines): Update.
7254
7255 2019-03-14  Tom Tromey  <tromey@adacore.com>
7256
7257         * NEWS: Add item for "style sources" commands.
7258         * source-cache.c (source_cache::get_source_lines): Check
7259         source_styling.
7260         * cli/cli-style.c (source_styling): New global.
7261         (_initialize_cli_style): Add "style sources" commands.
7262         (show_style_sources): New function.
7263         * cli/cli-style.h (source_styling): Declare.
7264
7265 2019-03-14  Pedro Alves  <palves@redhat.com>
7266             Tom Tromey  <tromey@adacore.com>
7267
7268         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7269         * tui/tui-winsource.c (tui_refill_source_window): New function,
7270         from...
7271         (tui_horizontal_source_scroll): ... here.  Move some logic.
7272         * cli/cli-style.c (set_style_enabled): Notify new observable.
7273         * tui/tui-hooks.c (tui_redisplay_source): New function.
7274         (tui_attach_detach_observers): Attach or detach
7275         tui_redisplay_source.
7276         * observable.h (source_styling_changed): New observable.
7277         * observable.c: Define source_styling_changed observable.
7278
7279 2019-03-13  Tom Tromey  <tromey@adacore.com>
7280
7281         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7282         (i386_gnu_nat_target::store_registers): Update.
7283         * target-debug.h (target_debug_print_std_string): New macro.
7284         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7285         * windows-tdep.c (display_one_tib): Update.
7286         * tui/tui-stack.c (tui_make_status_line): Update.
7287         * top.c (print_inferior_quit_action): Update.
7288         * thread.c (thr_try_catch_cmd): Update.
7289         (add_thread_with_info): Update.
7290         (thread_target_id_str): Update.
7291         (thr_try_catch_cmd): Update.
7292         (thread_command): Update.
7293         (thread_find_command): Update.
7294         * record-btrace.c (record_btrace_target::info_record)
7295         (record_btrace_resume_thread, record_btrace_target::resume)
7296         (record_btrace_cancel_resume, record_btrace_step_thread)
7297         (record_btrace_target::wait, record_btrace_target::wait)
7298         (record_btrace_target::wait, record_btrace_target::stop): Update.
7299         * progspace.c (print_program_space): Update.
7300         * process-stratum-target.c
7301         (process_stratum_target::thread_address_space): Update.
7302         * linux-fork.c (linux_fork_mourn_inferior)
7303         (detach_checkpoint_command, info_checkpoints_command)
7304         (linux_fork_context): Update.
7305         (linux_fork_detach): Update.
7306         (class scoped_switch_fork_info): Update.
7307         (delete_checkpoint_command): Update.
7308         * infrun.c (follow_fork_inferior): Update.
7309         (follow_fork_inferior): Update.
7310         (proceed_after_vfork_done): Update.
7311         (handle_vfork_child_exec_or_exit): Update.
7312         (follow_exec): Update.
7313         (displaced_step_prepare_throw): Update.
7314         (displaced_step_restore): Update.
7315         (start_step_over): Update.
7316         (resume_1): Update.
7317         (clear_proceed_status_thread): Update.
7318         (proceed): Update.
7319         (print_target_wait_results): Update.
7320         (do_target_wait): Update.
7321         (context_switch): Update.
7322         (stop_all_threads): Update.
7323         (restart_threads): Update.
7324         (finish_step_over): Update.
7325         (handle_signal_stop): Update.
7326         (switch_back_to_stepped_thread): Update.
7327         (keep_going_pass_signal): Update.
7328         (print_exited_reason): Update.
7329         (normal_stop): Update.
7330         * inferior.c (inferior_pid_to_str): Change return type.
7331         (print_selected_inferior): Update.
7332         (add_inferior): Update.
7333         (detach_inferior): Update.
7334         * dummy-frame.c (fprint_dummy_frames): Update.
7335         * dcache.c (dcache_info_1): Update.
7336         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7337         (btrace_fetch, btrace_clear): Update.
7338         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7339         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7340         type.
7341         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7342         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7343         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7344         * gdbarch.c, gdbarch.h: Rebuild.
7345         * gdbarch.sh (core_pid_to_str): Change return type.
7346         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7347         return type.
7348         (windows_nat_target::pid_to_str): Change return type.
7349         (windows_delete_thread): Update.
7350         (windows_nat_target::attach): Update.
7351         (windows_nat_target::files_info): Update.
7352         * target-delegates.c: Rebuild.
7353         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7354         return type.
7355         (sol_thread_target::pid_to_str): Change return type.
7356         * remote.c (class remote_target) <pid_to_str>: Change return
7357         type.
7358         (remote_target::pid_to_str): Change return type.
7359         (extended_remote_target::attach, remote_target::remote_stop_ns)
7360         (remote_target::remote_notif_remove_queued_reply)
7361         (remote_target::push_stop_reply, remote_target::disable_btrace):
7362         Update.
7363         (extended_remote_target::attach): Update.
7364         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7365         type.
7366         (gdbsim_target::pid_to_str): Change return type.
7367         * ravenscar-thread.c (struct ravenscar_thread_target)
7368         <pid_to_str>: Change return type.
7369         (ravenscar_thread_target::pid_to_str): Change return type.
7370         * procfs.c (class procfs_target) <pid_to_str>: Change return
7371         type.
7372         (procfs_target::pid_to_str): Change return type.
7373         (procfs_target::attach): Update.
7374         (procfs_target::detach): Update.
7375         (procfs_target::fetch_registers): Update.
7376         (procfs_target::store_registers): Update.
7377         (procfs_target::wait): Update.
7378         (procfs_target::files_info): Update.
7379         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7380         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7381         return type.
7382         (nto_procfs_target::pid_to_str): Change return type.
7383         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7384         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7385         return type.
7386         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7387         (exit_lwp): Update.
7388         (attach_proc_task_lwp_callback, get_detach_signal)
7389         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7390         (linux_nat_target::resume, wait_lwp, stop_callback)
7391         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7392         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7393         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7394         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7395         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7396         type.
7397         (inf_ptrace_target::attach): Update.
7398         (inf_ptrace_target::files_info): Update.
7399         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7400         type.
7401         (go32_nat_target::pid_to_str): Change return type.
7402         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7403         (gnu_nat_target::wait): Update.
7404         (gnu_nat_target::wait): Update.
7405         (gnu_nat_target::resume): Update.
7406         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7407         (fbsd_nat_target::wait): Update.
7408         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7409         type.
7410         (darwin_nat_target::attach): Update.
7411         * corelow.c (class core_target) <pid_to_str>: Change return type.
7412         (core_target::pid_to_str): Change return type.
7413         * target.c (normal_pid_to_str): Change return type.
7414         (default_pid_to_str): Likewise.
7415         (target_pid_to_str): Change return type.
7416         (target_translate_tls_address): Update.
7417         (target_announce_detach): Update.
7418         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7419         return type.
7420         (bsd_uthread_target::pid_to_str): Change return type.
7421         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7422         type.
7423         (bsd_kvm_target::pid_to_str): Change return type.
7424         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7425         return type.
7426         (aix_thread_target::pid_to_str): Change return type.
7427         * target.h (struct target_ops) <pid_to_str>: Change return type.
7428         (target_pid_to_str, normal_pid_to_str): Likewise.
7429         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7430         type.
7431         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7432         type.
7433         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7434         return type.
7435         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7436         type.
7437         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7438         type.
7439         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7440         return type.
7441
7442 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7443
7444         * NEWS: Mention that the new default MI version is 3.  Mention
7445         changes to the output of commands and events that deal with
7446         multi-location breakpoints.
7447         * breakpoint.c: Include "mi/mi-out.h".
7448         (print_one_breakpoint): Change output syntax if using MI version
7449         >= 3.
7450         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7451         New.
7452         (mi_multi_location_breakpoint_output_fixed): New.
7453         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7454         (mi_cmd_fix_multi_location_breakpoint_output): New.
7455         (mi_multi_location_breakpoint_output_fixed): New.
7456         * mi/mi-cmds.c (mi_cmds): Register command
7457         -fix-multi-location-breakpoint-output.
7458         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7459         interpreter "mi".
7460
7461 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7462
7463         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7464         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7465         instantiate mi_ui_out based on interpreter name.
7466         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7467         * mi/mi-main.c (mi_load_progress): Likewise.
7468
7469 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7470
7471         * NEWS: Combine separate "New targets" sections for 8.3.
7472
7473 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7474
7475         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7476         (ppcfbsd_init_abi): Install gdbarch
7477         "fetch_tls_load_module_address" and "get_thread_local_address"
7478         methods.
7479
7480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7481
7482         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7483         (riscv_fbsd_init_abi): Install gdbarch
7484         "fetch_tls_load_module_address" and "get_thread_local_address"
7485         methods.
7486
7487 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7488
7489         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7490         (i386fbsd_init_abi): Install gdbarch
7491         "fetch_tls_load_module_address" and "get_thread_local_address"
7492         methods.
7493
7494 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7495
7496         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7497         (amd64fbsd_init_abi): Install gdbarch
7498         "fetch_tls_load_module_address" and "get_thread_local_address"
7499         methods.
7500
7501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7502
7503         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7504         (struct fbsd_pspace_data): New type.
7505         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7506         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7507         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7508         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7509         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7510
7511 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7512
7513         * gdbtypes.c (lookup_struct_elt): New function.
7514         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7515         * gdbtypes.h (struct struct_elt): New type.
7516         (lookup_struct_elt): New prototype.
7517
7518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7519
7520         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7521         remove disabled code block.
7522
7523 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7524
7525         * gdbarch.sh (get_thread_local_address): New method.
7526         * gdbarch.h, gdbarch.c: Regenerate.
7527         * target.c (target_translate_tls_address): Use
7528         gdbarch_get_thread_local_address if present instead of
7529         target::get_thread_local_address.
7530
7531 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7532
7533         * target.h (target::get_thread_local_address): Update comment.
7534
7535 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7536
7537         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7538         objfile->separate_debug_objfile_backlink if not NULL.
7539
7540 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7541
7542         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7543         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7544         (amd64bsd_store_inferior_registers): Likewise.
7545         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7546         Enable segment base registers.
7547         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7548         PT_GETFSBASE and PT_GETGSBASE.
7549         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7550         PT_SETGSBASE.
7551         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7552         segment base registers.
7553         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7554
7555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7556
7557         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7558         Update calls to i386_target_description to add 'segments'
7559         parameter.
7560         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7561         add segment base registers.
7562         * arch/i386.c (i386_create_target_description): Add 'segments'
7563         parameter to enable segment base registers.
7564         * arch/i386.h (i386_create_target_description): Likewise.
7565         * features/i386/32bit-segments.xml: New file.
7566         * features/i386/32bit-segments.c: Generate.
7567         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7568         call to i386_target_description to add 'segments' parameter.
7569         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7570         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7571         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7572         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7573         if feature is present.
7574         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7575         Add 'segments' parameter to call to i386_target_description.
7576         (i386_target_description): Add 'segments' parameter to enable
7577         segment base registers.
7578         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7579         to call to i386_target_description.
7580         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7581         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7582         Define I386_NUM_REGS.
7583         (i386_target_description): Add 'segments' parameter to enable
7584         segment base registers.
7585
7586 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7587
7588         PR/24325
7589         * source-cache.c: #undef open and close, to avoid unresolved
7590         externals during linking.
7591
7592 2019-03-12  Tom Tromey  <tromey@adacore.com>
7593
7594         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7595         const.  Add initializers.
7596         (_initialize_remote): Don't initialize ptid globals.
7597
7598 2019-03-12  Pedro Alves  <palves@redhat.com>
7599
7600         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7601
7602 2019-03-12  Pedro Alves  <palves@redhat.com>
7603
7604         * cp-name-parser.y (main): Remove unused 'len' variable.
7605
7606 2019-03-12  Tom Tromey  <tromey@adacore.com>
7607
7608         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7609         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7610
7611 2019-03-12  Tom Tromey  <tromey@adacore.com>
7612
7613         * linux-nat.c (iterate_over_lwps): Update.
7614         (stop_callback): Remove parameter.
7615         (stop_wait_callback, detach_callback, resume_set_callback)
7616         (select_singlestep_lwp_callback, set_ignore_sigint)
7617         (status_callback, resumed_callback, resume_clear_callback)
7618         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7619         data parameter.
7620         (linux_nat_target::detach, linux_nat_target::resume)
7621         (linux_stop_and_wait_all_lwps, select_event_lwp)
7622         (linux_nat_filter_event, linux_nat_wait_1)
7623         (linux_nat_target::kill, linux_nat_target::stop)
7624         (linux_nat_target::stop): Update.
7625         (linux_nat_resume_callback): Change type.
7626         (resume_stopped_resumed_lwps, count_events_callback)
7627         (select_event_lwp_callback): Likewise.
7628         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7629         * arm-linux-nat.c (struct update_registers_data): Remove.
7630         (update_registers_callback): Change type.
7631         (arm_linux_insert_hw_breakpoint1): Update.
7632         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7633         parameter.
7634         (x86_linux_dr_set_addr): Update.
7635         (x86_linux_dr_set_control): Update.
7636         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7637         (iterate_over_lwps): Use gdb::function_view.
7638         * nat/aarch64-linux-hw-point.c (struct
7639         aarch64_dr_update_callback_param): Remove.
7640         (debug_reg_change_callback): Change type.
7641         (aarch64_notify_debug_reg_change): Update.
7642         * s390-linux-nat.c (s390_refresh_per_info): Update.
7643
7644 2019-03-11  Tom Tromey  <tromey@adacore.com>
7645
7646         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7647         redundant assignment to "this_cu".
7648
7649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7650
7651         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7652
7653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7654
7655         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7656         from...
7657         (rank_one_type): ... this.
7658
7659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7660
7661         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7662         from...
7663         (rank_one_type): ... this.
7664
7665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7666
7667         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7668         from...
7669         (rank_one_type): ... this.
7670
7671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7672
7673         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7674         from...
7675         (rank_one_type): ... this.
7676
7677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7678
7679         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7680         from...
7681         (rank_one_type): ... this.
7682
7683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7684
7685         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7686         from...
7687         (rank_one_type): ... this.
7688
7689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7690
7691         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7692         from...
7693         (rank_one_type): ... this.
7694
7695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7696
7697         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7698         from...
7699         (rank_one_type): ... this.
7700
7701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7702
7703         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7704         from...
7705         (rank_one_type): ... this.
7706
7707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7708
7709         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7710         from...
7711         (rank_one_type): ... this.
7712
7713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7714
7715         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7716         from...
7717         (rank_one_type): ... this.
7718
7719 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7720
7721         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7722         from...
7723         (rank_one_type): ... this.
7724
7725 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7726
7727         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7728         inferior-events' shows the example events.
7729
7730 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7731
7732         Support styling on native MS-Windows console
7733
7734         PR/24315
7735         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7736         on MS-Windows if $TERM is not defined.
7737
7738         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7739
7740         * posix-hdep.c (gdb_console_fputs):
7741         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7742         functions.
7743         * ui-file.h (gdb_console_fputs): Add prototype.
7744
7745         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7746         back to fputs only if the former returns zero.
7747
7748 2019-03-07  Tom Tromey  <tom@tromey.com>
7749
7750         * symmisc.c (print_symbol_bcache_statistics): Update.
7751         (print_objfile_statistics): Update.
7752         * symfile.c (allocate_symtab): Update.
7753         * stabsread.c: Don't include bcache.h.
7754         * psymtab.h (struct psymbol_bcache): Don't declare.
7755         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7756         (psymbol_bcache_init, psymbol_bcache_free)
7757         (psymbol_bcache_get_bcache): Don't declare.
7758         * psymtab.c (struct psymbol_bcache): Remove.
7759         (psymtab_storage::psymtab_storage): Update.
7760         (psymtab_storage::~psymtab_storage): Update.
7761         (psymbol_bcache_init, psymbol_bcache_free)
7762         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7763         (add_psymbol_to_bcache): Update.
7764         (allocate_psymtab): Update.
7765         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7766         macro_cache>: No longer pointers.
7767         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7768         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7769         * macrotab.c (macro_bcache): Update.
7770         * macroexp.c: Don't include bcache.h.
7771         * gdbtypes.c (check_types_worklist): Update.
7772         (types_deeply_equal): Remove TRY/CATCH.  Update.
7773         * elfread.c (elf_symtab_read): Update.
7774         * dwarf2read.c: Don't include bcache.h.
7775         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7776         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7777         (print_bcache_statistics, bcache_memory_used): Don't declare.
7778         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7779         methods.  Rename all data members.
7780         * bcache.c (struct bcache): Move to bcache.h.
7781         (bcache::expand_hash_table): Rename from expand_hash_table.
7782         (bcache): Remove.
7783         (bcache::insert): Rename from bcache_full.
7784         (bcache::compare): Rename from bcache_compare.
7785         (bcache_xmalloc): Remove.
7786         (bcache::~bcache): Rename from bcache_xfree.
7787         (bcache::print_statistics): Rename from print_bcache_statistics.
7788         (bcache::memory_used): Rename from bcache_memory_used.
7789
7790 2019-03-07  Pedro Alves  <palves@redhat.com>
7791
7792         * infrun.c (normal_stop): Also check for
7793         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7794
7795 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7796
7797         * f-lang.c (value_from_host_double): Moved to...
7798         * value.c (value_from_host_double): ...here.
7799         * value.h (value_from_host_double): Declare.
7800         * guile/scm-math.c (vlscm_convert_typed_number): Use
7801         value_from_host_double.
7802         (vlscm_convert_number): Likewise.
7803         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7804         * python/py-value.c (convert_value_from_python): Likewise.
7805
7806 2019-03-06  Tom Tromey  <tom@tromey.com>
7807
7808         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7809
7810 2019-03-06  Tom Tromey  <tom@tromey.com>
7811
7812         * utils.h (free_current_contents): Don't declare.
7813         * utils.c (free_current_contents): Remove.
7814
7815 2019-03-06  Tom Tromey  <tom@tromey.com>
7816
7817         * top.c (quit_force): Update.
7818         * main.c (captured_command_loop): Update.
7819         * common/new-op.c (operator new): Update.
7820         * common/common-exceptions.c (struct catcher)
7821         <save_cleanup_chain>: Remove member.
7822         (exceptions_state_mc_init): Update.
7823         (exception_try_scope_entry): Return nullptr.
7824         (exception_try_scope_exit, exception_rethrow)
7825         (throw_exception_sjlj, throw_exception_cxx): Update.
7826         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7827         (all_cleanups, do_cleanups, discard_cleanups)
7828         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7829         (restore_cleanups, restore_final_cleanups): Don't declare.
7830         (do_final_cleanups): Remove parameter.
7831         * common/cleanups.c (cleanup_chain, make_cleanup)
7832         (make_cleanup_dtor, all_cleanups, do_cleanups)
7833         (discard_my_cleanups, discard_cleanups)
7834         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7835         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7836         (null_cleanup): Remove.
7837         (do_final_cleanups): Remove parameter.
7838
7839 2019-03-06  Tom Tromey  <tom@tromey.com>
7840
7841         * remote.c (remote_target::remote_parse_stop_reply): Use
7842         unique_xmalloc_ptr.
7843
7844 2019-03-06  Tom Tromey  <tom@tromey.com>
7845
7846         * stabsread.c (struct stabs_field_info): Rename from field_info.
7847         <list, fnlist>: Add initializers.
7848         <obstack>: New member.
7849         (read_member_functions, read_struct_fields, read_baseclasses):
7850         Allocate on obstack.  Don't use cleanups.
7851         (read_one_struct_field, read_member_functions, read_struct_fields)
7852         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7853         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7854         (read_struct_type): Update.
7855
7856 2019-03-06  Tom Tromey  <tom@tromey.com>
7857
7858         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7859         * common/filestuff.h (make_cleanup_close): Don't declare.
7860         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7861         Remove.
7862
7863 2019-03-06  Tom Tromey  <tom@tromey.com>
7864
7865         * solib-aix.c: Use make_scope_exit.
7866
7867 2019-03-06  Tom Tromey  <tom@tromey.com>
7868
7869         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7870         Use make_scope_exit.
7871
7872 2019-03-06  Tom Tromey  <tom@tromey.com>
7873
7874         * solib-svr4.c (disable_probes_interface): Remove parameter.
7875         (svr4_handle_solib_event): Use make_scope_exit.
7876
7877 2019-03-06  Tom Tromey  <tom@tromey.com>
7878
7879         * remote.c (struct stop_reply_deleter): Remove.
7880         (stop_reply_up): Update.
7881         (struct stop_reply): Derive from notif_event.  Don't typedef.
7882         <regcache>: Now a std::vector.
7883         (stop_reply_xfree): Remove.
7884         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7885         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7886         (remote_target::discard_pending_stop_replies): Use delete.
7887         (remote_target::remote_parse_stop_reply): Update.
7888         (remote_target::process_stop_reply): Update.
7889         * remote-notif.h (struct notif_event): Add virtual destructor.
7890         Remove "dtr" member.
7891         (struct notif_client) <alloc_event>: Return a unique_ptr.
7892         (notif_event_xfree): Don't declare.
7893         (notif_event_up): New typedef.
7894         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7895         (notif_event_xfree, do_notif_event_xfree): Remove.
7896         (remote_notif_state_xfree): Update.
7897
7898 2019-03-06  Tom Tromey  <tom@tromey.com>
7899
7900         * infrun.c (displaced_step_clear_cleanup): Now a
7901         forward_scope_exit type.
7902         (displaced_step_prepare_throw): Update.
7903         (displaced_step_fixup): Update.
7904
7905 2019-03-06  Tom Tromey  <tom@tromey.com>
7906
7907         * inferior.h (class inferior): Update comment.
7908         * gdbthread.h (class thread_info): Update comment.
7909
7910 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7911             Tom Tromey  <tom@tromey.com>
7912
7913         * stabsread.h (struct stab_section_list): Remove.
7914         (coffstab_build_psymtabs): Update.
7915         * dbxread.c (symbuf_sections): Now a std::vector.
7916         (sect_idx): New global.
7917         (fill_symbuf): Update.
7918         (coffstab_build_psymtabs): Change type of stabsects parameter.
7919         Update.
7920         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7921         std::vector.
7922         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7923         (coff_locate_sections): Update.
7924         (coff_symfile_read): Remove cleanups.  Update.
7925         (init_stringtab): Add storage parameter.
7926         (free_stringtab, free_stringtab_cleanup): Remove.
7927         (init_lineno): Add storage parameter.
7928         (free_linetab, free_linetab_cleanup): Remove.
7929
7930 2019-03-06  Pedro Alves  <palves@redhat.com>
7931
7932         * linux-fork.c (fork_info::clobber_regs): Delete.
7933         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7934         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7935         comment.  Adjust.
7936         (scoped_switch_fork_info::scoped_switch_fork_info)
7937         (checkpoint_command, linux_fork_context): Adjust
7938         fork_save_infrun_state calls.
7939
7940 2019-03-06  Pedro Alves  <palves@redhat.com>
7941
7942         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7943         (inf_has_multiple_threads): Return 'bool' and rewrite using
7944         inferior_info::threads().
7945
7946 2019-03-06  Pedro Alves  <palves@redhat.com>
7947
7948         * linux-fork.c: Include <list>.
7949         (fork_list): Now a std::list instance.
7950         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7951         (forks_exist_p, find_last_fork): Adjust.
7952         (new_fork): Delete.
7953         (one_fork_p): New.
7954         (add_fork): Adjust.
7955         (free_fork): Delete, folded into fork_info::~fork_info().
7956         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7957         Adjust.
7958         (init_fork_list): Delete.
7959         (linux_fork_killall, linux_fork_mourn_inferior)
7960         (linux_fork_detach, info_checkpoints_command): Adjust.
7961         (_initialize_linux_fork): No longer call init_fork_list.
7962
7963 2019-03-06  Pedro Alves  <palves@redhat.com>
7964
7965         * linux-fork.c (new_fork): New, split out of ...
7966         (add_fork): ... this.  Return void.  Move "first fork" special
7967         case from here, to ...
7968         (checkpoint_command): ... here.
7969         * linux-linux.h (add_fork): Return void.
7970
7971 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7972
7973         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7974
7975 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7976             Chris January  <chris.january@arm.com>
7977             David Lecomber  <david.lecomber@arm.com>
7978
7979         * f-exp.y: New token, UNOP_INTRINSIC.
7980         (exp): New pattern using UNOP_INTRINSIC token.
7981         (f77_keywords): Add 'abs' keyword.
7982         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7983         (value_from_host_double): New function.
7984         (evaluate_subexp_f): Support UNOP_ABS.
7985
7986 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7987
7988         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7989         types.
7990
7991 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7992
7993         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7994         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7995         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7996
7997 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7998
7999         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8000
8001 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8002             Chris January  <chris.january@arm.com>
8003
8004         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8005         * f-exp.y: Define 'KIND' token.
8006         (exp): New pattern for KIND expressions.
8007         (ptype): Handle types with a kind extension.
8008         (direct_abs_decl): Extend to spot kind extensions.
8009         (f77_keywords): Add 'kind' to the list.
8010         (push_kind_type): New function.
8011         (convert_to_kind_type): New function.
8012         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8013         * parse.c (operator_length_standard): Likewise.
8014         * parser-defs.h (enum type_pieces): Add tp_kind.
8015         * std-operator.def: Add UNOP_KIND.
8016
8017 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8018
8019         * f-exp.y (f_parse): Set yydebug.
8020
8021 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8022
8023         * f-lang.c (evaluate_subexp_f): New function.
8024         (exp_descriptor_f): New global.
8025         (f_language_defn): Use exp_descriptor_f instead of
8026         exp_descriptor_standard.
8027
8028 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8029
8030         * f-exp.y (struct token): Add comments.
8031         (dot_ops): Remove uppercase versions and the end marker.
8032         (f77_keywords): Likewise.
8033         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8034         entries in the dot_ops array are case insensitive, and use
8035         strncasecmp to compare strings.  Also some whitespace cleanup in
8036         this area.  Similar for the f77_keywords array, except entries in
8037         this list might be case sensitive.
8038
8039 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8040
8041         * f-exp.y (struct f77_boolean_val): Add comments.
8042         (boolean_values): Remove uppercase versions, and end marker.
8043         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8044         and use strncasecmp to achieve case insensitivity.  Additionally,
8045         perform whitespace cleanup around this code.
8046
8047 2019-03-06  Tom Tromey  <tromey@adacore.com>
8048
8049         * remote-sim.c (gdbsim_target_open): Use result of
8050         gdb_argv::release.
8051
8052 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8053         Dirk Schubert  <dirk.schubert@arm.com>
8054         Chris January  <chris.january@arm.com>
8055
8056         * eval.c (evaluate_subexp_standard): Call Fortran argument
8057         wrapping logic.
8058         * f-lang.c (struct value): A value which can be passed into a
8059         Fortran function call.
8060         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8061         where appropriate.
8062         (struct type): Value ready for a Fortran function call.
8063         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8064         is needed.
8065         * f-lang.h (fortran_argument_convert): Declaration.
8066         (fortran_preserve_arg_pointer): Declaration.
8067         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8068
8069 2019-03-05  Tom Tromey  <tromey@adacore.com>
8070
8071         * python/py-prettyprint.c (print_string_repr): Remove #if.
8072         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8073
8074 2019-03-05  Tom Tromey  <tromey@adacore.com>
8075
8076         * target.c (the_dummy_target): Move later.  Change type to
8077         "dummy_target".
8078         (initialize_targets): Don't initialize the_dummy_target.
8079
8080 2019-03-05  Tom Tromey  <tromey@adacore.com>
8081
8082         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8083         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8084
8085 2019-03-05  Tom Tromey  <tromey@adacore.com>
8086
8087         * windows-nat.c (windows_nat_target::attach)
8088         (windows_nat_target::detach): Don't call gdb_flush.
8089         * valprint.c (generic_val_print, val_print, val_print_string):
8090         Don't call gdb_flush.
8091         * utils.c (defaulted_query): Don't call gdb_flush.
8092         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8093         * target.c (target_announce_detach): Don't call gdb_flush.
8094         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8095         * remote.c (extended_remote_target::attach): Don't call
8096         gdb_flush.
8097         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8098         * printcmd.c (do_examine): Don't call gdb_flush.
8099         (info_display_command): Don't call gdb_flush.
8100         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8101         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8102         * memattr.c (info_mem_command): Don't call gdb_flush.
8103         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8104         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8105         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8106         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8107         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8108         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8109         (gnu_nat_target::detach): Don't call gdb_flush.
8110         * f-valprint.c (f_val_print): Don't call gdb_flush.
8111         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8112         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8113         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8114         gdb_flush.
8115         * c-valprint.c (c_val_print): Don't call gdb_flush.
8116         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8117
8118 2019-03-05  Tom Tromey  <tromey@adacore.com>
8119
8120         * varobj.c (update_dynamic_varobj_children): Update.
8121         (install_default_visualizer): Use reset, not release.
8122         * value.c (set_internalvar): Update.
8123         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8124         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8125         ATTRIBUTE_UNUSED_RESULT.
8126
8127 2019-03-05  Tom Tromey  <tromey@adacore.com>
8128
8129         * remote.c (class scoped_remote_fd) <release>: Add
8130         ATTRIBUTE_UNUSED_RESULT.
8131
8132 2019-03-05  Tom Tromey  <tromey@adacore.com>
8133
8134         * macroexp.c (struct macro_buffer) <release>: Add
8135         ATTRIBUTE_UNUSED_RESULT.
8136
8137 2019-03-05  Tom Tromey  <tromey@adacore.com>
8138
8139         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8140         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8141         ATTRIBUTE_UNUSED_RESULT.
8142
8143 2019-03-05  Tom Tromey  <tromey@adacore.com>
8144
8145         * common/scoped_fd.h (class scoped_fd) <release>: Add
8146         ATTRIBUTE_UNUSED_RESULT.
8147
8148 2019-03-05  Tom Tromey  <tromey@adacore.com>
8149
8150         * parser-defs.h (struct parser_state) <release>: Add
8151         ATTRIBUTE_UNUSED_RESULT.
8152
8153 2019-03-05  Tom Tromey  <tromey@adacore.com>
8154
8155         * utils.h (class gdb_argv) <release>: Add
8156         ATTRIBUTE_UNUSED_RESULT.
8157         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8158
8159 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8160
8161         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8162         for-loop range, to avoid compiler warnings.
8163
8164         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8165         avoid compiler warnings about unused variables.
8166
8167         * NEWS: Mention end of support for native debugging on MS-Windows
8168         before XP.
8169
8170         PR gdb/24292
8171         * common/netstuff.c:
8172         * gdbserver/gdbreplay.c
8173         * gdbserver/remote-utils.c:
8174         * ser-tcp.c:
8175         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8176         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8177         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8178         'getaddrinfo' and 'freeaddrinfo' were not available before
8179         Windows XP, and mingw.org's MinGW headers by default define
8180         _WIN32_WINNT to 0x500.
8181
8182 2019-03-01  Gary Benson <gbenson@redhat.com>
8183
8184         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8185
8186 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8187             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8188
8189         PR gdb/8527
8190         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8191         set_sigint_trap, clear_sigint_trap.
8192
8193 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8194
8195         * target.c (target_detach): Clear the regcache and the
8196         frame cache.
8197
8198 2019-02-27  Pedro Alves  <palves@redhat.com>
8199
8200         * utils.c (set_screen_size): When we cap the height/width sizes,
8201         tweak the corresponding command variable to show "unlimited":
8202
8203 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8204             Pedro Alves  <palves@redhat.com>
8205
8206         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8207         before calling rl_set_screen_size.
8208
8209 2019-02-27  Tom Tromey  <tromey@adacore.com>
8210
8211         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8212         define.
8213         * python/py-value.c: Remove Python 2.4 workaround.
8214         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8215         workaround.
8216         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8217         Python 2.4 workaround.
8218         * python/python-internal.h: Remove Python 2.4 comment.
8219         (Py_ssize_t): Don't define.
8220         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8221         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8222         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8223         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8224         * python/python.c (do_start_initialization): Remove Python 2.4
8225         workaround.
8226         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8227         (print_children): Remove Python 2.4 workaround.
8228         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8229         workaround.
8230         (CHARBUFFERPROC_NAME): Remove.
8231         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8232         Python 2.4 workaround.
8233
8234 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8235
8236         * NEWS: Note minimum Python version.
8237
8238 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8239
8240         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8241         code from these functions.  Remove corresponding ifdefs.  Use
8242         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8243         Remove gotos and target of gotos.
8244         (infpy_search_memory): Likewise.
8245
8246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8247
8248         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8249         (hppa_gdbarch_init): Don't register deleted functions with
8250         gdbarch.
8251
8252 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8253
8254         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8255         (h8300_unwind_sp): Delete.
8256         (h8300_dummy_id): Delete.
8257         (h8300_gdbarch_init): Don't register deleted functions with
8258         gdbarch.
8259
8260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8261
8262         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8263         (ft32_unwind_pc): Delete.
8264         (ft32_unwind_sp): Delete.
8265         (ft32_gdbarch_init): Don't register deleted functions with
8266         gdbarch.
8267
8268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8269
8270         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8271         (frv_unwind_pc): Delete.
8272         (frv_unwind_sp): Delete.
8273         (frv_gdbarch_init): Don't register deleted functions with
8274         gdbarch.
8275
8276 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8277
8278         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8279         (riscv_unwind_pc): Delete.
8280         (riscv_unwind_sp): Delete.
8281         (riscv_gdbarch_init): Don't register deleted functions with
8282         gdbarch.
8283
8284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8285
8286         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8287         (csky_unwind_pc): Delete.
8288         (csky_unwind_sp): Delete.
8289         (csky_gdbarch_init): Don't register deleted functions with
8290         gdbarch.
8291
8292 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8293
8294         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8295         (cris_unwind_pc): Delete.
8296         (cris_unwind_sp): Delete.
8297         (cris_gdbarch_init): Don't register deleted functions with
8298         gdbarch.
8299
8300 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8303         (bfin_unwind_pc): Delete.
8304         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8305
8306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8309         (arm_unwind_pc): Delete.
8310         (arm_unwind_sp): Delete.
8311         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8312
8313 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8314
8315         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8316         (arc_unwind_pc): Delete.
8317         (arc_unwind_sp): Delete.
8318         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8319
8320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8321
8322         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8323         (alpha_unwind_pc): Delete.
8324         (alpha_gdbarch_init): Don't register deleted functions with
8325         gdbarch.
8326
8327 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8328
8329         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8330         (aarch64_unwind_pc): Delete.
8331         (aarch64_unwind_sp): Delete.
8332         (aarch64_gdbarch_init): Don't register deleted functions with
8333         gdbarch.
8334
8335 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8336
8337         * gdbtypes.c (type_align): Don't consider static members when
8338         computing structure alignment.
8339
8340 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8341
8342         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8343         return 0 for other types.
8344         * arch-utils.c (default_type_align): Always return 0.
8345         * gdbarch.h: Regenerate.
8346         * gdbarch.sh (type_align): Extend comment.
8347         * gdbtypes.c (type_align): Add additional comments, always call
8348         gdbarch_type_align before applying the default rules.
8349         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8350         generic code will then apply a suitable default.
8351         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8352         types, return 0 for other types.
8353
8354 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8355
8356         * NEWS: Create a new section for the next release branch.
8357         Rename the section of the current branch, now that it has
8358         been cut.
8359
8360 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8361
8362         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8363         * version.in: Bump version to 8.3.50.DATE-git.
8364
8365 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8366
8367         * aix-thread.c (ptid_cmp): Remove unused variable.
8368         (get_signaled_thread): Likewise.
8369         (store_regs_user_thread): Likewise.
8370         (store_regs_kernel_thread): Likewise.
8371         (fetch_regs_kernel_thread): Remove shadowed variable.
8372
8373 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8374
8375         * features/riscv/32bit-cpu.xml: Add register numbers.
8376         * features/riscv/32bit-fpu.c: Regenerate.
8377         * features/riscv/32bit-fpu.xml: Add register numbers.
8378         * features/riscv/64bit-cpu.xml: Add register numbers.
8379         * features/riscv/64bit-fpu.c: Regenerate.
8380         * features/riscv/64bit-fpu.xml: Add register numbers.
8381
8382 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8383
8384         * NEWS: Mention two argument form of gdb.Value constructor.
8385         * python/py-value.c (convert_buffer_and_type_to_value): New
8386         function.
8387         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8388         Add support for handling an optional second argument.  Call
8389         convert_buffer_and_type_to_value as appropriate.
8390         * python/python-internal.h (Py_buffer_deleter): New struct.
8391         (Py_buffer_up): New typedef.
8392
8393 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8394
8395         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8396         instead of releasing ownership.
8397
8398 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8399
8400         * dwarf2read.c (open_and_init_dwp_file): Call
8401         elf_numsections instead of bfd_count_sections to initialize
8402         dwp_file->num_sections.
8403
8404 2019-02-25  Tom Tromey  <tromey@adacore.com>
8405
8406         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8407
8408 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8409
8410         * gcore.in: Add '--readnever' option when invoking GDB.
8411
8412 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8413
8414         * MAINTAINERS: Update my email address.
8415
8416 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8417
8418         * build-id.c (build_id_to_debug_bfd_1): New function.
8419         (build_id_to_debug_bfd): Look for separate debug file in
8420         sysroot.
8421
8422 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8423
8424         * gdbarch.sh: Update the copyright year range that is placed into
8425         generated files.
8426
8427 2019-02-22  Keith Seitz  <keiths@redhat.com>
8428
8429         PR symtab/23853
8430         * linespec.c (create_sals_line_offset): Search for the default
8431         symtab's filename instead of its fullname.
8432
8433 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8434
8435         * NEWS: Update style defaults.
8436
8437 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8438
8439         * main.c (captured_main_1): Disable styling in batch mode.
8440
8441 2019-02-20  Tom Tromey  <tom@tromey.com>
8442
8443         * symtab.c (symtab_symbol_info): Fix typos.
8444
8445 2019-02-20  Tom Tromey  <tromey@adacore.com>
8446
8447         * findcmd.c (_initialize_mem_search): Use upper case for
8448         metasyntactic variables.
8449
8450 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8451
8452         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8453         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8454
8455 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8456
8457         * top.h (source_file_name): Change to std::string.
8458         * top.c (source_file_name): Likewise.
8459         (command_line_input): Adjust.
8460         * cli/cli-script.c (script_from_file): Adjust.
8461
8462 2019-02-19  Tom Tromey  <tromey@adacore.com>
8463
8464         * ravenscar-thread.c
8465         (ravenscar_thread_target::update_thread_list): Don't call
8466         ada_build_task_list.
8467         * ada-lang.h (ada_build_task_list): Don't declare.
8468         * ada-tasks.c (struct ada_tasks_inferior_data)
8469         <task_list_valid_p>: Now bool.
8470         (read_known_tasks, ada_task_list_changed)
8471         (ada_tasks_invalidate_inferior_data): Update.
8472         (read_known_tasks_array): Return bool.
8473         (read_known_tasks_list): Likewise.
8474         (read_known_tasks): Return void.
8475         (ada_build_task_list): Now static.
8476
8477 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8478
8479         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8480         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8481
8482 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8483
8484         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8485         variant for ada_tasks_pspace_data_handle and
8486         ada_tasks_inferior_data_handle.
8487         (ada_tasks_pspace_data_cleanup): New function.
8488         (ada_tasks_inferior_data_cleanup): New function.
8489
8490 2019-02-17  Tom Tromey  <tom@tromey.com>
8491
8492         * macrotab.h (macro_source_fullname): Return a std::string.
8493         * macrotab.c (macro_include, check_for_redefinition)
8494         (macro_undef, macro_lookup_definition, foreach_macro)
8495         (foreach_macro_in_scope): Update.
8496         (macro_source_fullname): Return a std::string.
8497         * macrocmd.c (show_pp_source_pos): Update.
8498
8499 2019-02-17  Tom Tromey  <tom@tromey.com>
8500
8501         * macrocmd.c (show_pp_source_pos): Style the file names.
8502
8503 2019-02-17  Tom Tromey  <tom@tromey.com>
8504
8505         PR tui/24197:
8506         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8507
8508 2019-02-17  Tom Tromey  <tom@tromey.com>
8509
8510         * ada-lang.c (user_select_syms): Use filtered printing.
8511         * utils.c (wrap_style): New global.
8512         (desired_style): Remove.
8513         (emit_style_escape): Add stream parameter.
8514         (set_output_style, reset_terminal_style, prompt_for_continue):
8515         Update.
8516         (flush_wrap_buffer): Only flush gdb_stdout.
8517         (wrap_here): Set wrap_style.
8518         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8519         treat escape sequences as a character.  Change when wrap buffer is
8520         flushed.
8521         (fputs_styled): Do not set the output style when the default is
8522         requested.
8523         * ui-style.h (struct ui_file_style) <is_default>: New method.
8524         * source.c (print_source_lines_base): Emit escape sequences in one
8525         piece.
8526
8527 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8528
8529         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8530         integers and enumeration types.
8531
8532 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8533
8534         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8535         instead of lookup_symbol_in_language
8536         (do_exact_match): New function.
8537         (ada_get_symbol_name_matcher): Return do_exact_match when
8538         doing a verbatim match.
8539
8540 2019-02-15  Tom Tromey  <tromey@adacore.com>
8541
8542         * ravenscar-thread.c (ravenscar_thread_target::resume)
8543         (ravenscar_thread_target::wait): Special case wildcard requests.
8544
8545 2019-02-15  Tom Tromey  <tromey@adacore.com>
8546
8547         * ravenscar-thread.c (base_ptid): Remove.
8548         (struct ravenscar_thread_target) <close>: New method.
8549         <m_base_ptid>: New member.
8550         <update_inferior_ptid, active_task, task_is_currently_active,
8551         runtime_initialized>: Declare methods.
8552         <ravenscar_thread_target>: Add constructor.
8553         (ravenscar_thread_target::task_is_currently_active)
8554         (ravenscar_thread_target::update_inferior_ptid)
8555         (ravenscar_runtime_initialized): Rename.  Now methods.
8556         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8557         (ravenscar_thread_target::update_thread_list): Update.
8558         (ravenscar_thread_target::active_task): Now method.
8559         (ravenscar_thread_target::store_registers)
8560         (ravenscar_thread_target::prepare_to_store)
8561         (ravenscar_thread_target::prepare_to_store)
8562         (ravenscar_thread_target::mourn_inferior): Update.
8563         (ravenscar_inferior_created): Use "new" to create target.
8564         (ravenscar_thread_target::get_ada_task_ptid): Update.
8565         (_initialize_ravenscar): Don't initialize base_ptid.
8566         (ravenscar_ops): Remove global.
8567
8568 2019-02-15  Tom Tromey  <tromey@adacore.com>
8569
8570         * target.h (push_target): Declare new overload.
8571         * target.c (push_target): New overload, taking an rvalue reference.
8572         * remote.c (remote_target::open_1): Use push_target overload.
8573         * corelow.c (core_target_open): Use push_target overload.
8574
8575 2019-02-15  Tom Tromey  <tromey@adacore.com>
8576
8577         * ravenscar-thread.c (is_ravenscar_task)
8578         (ravenscar_task_is_currently_active): Return bool.
8579         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8580         (_initialize_ravenscar): Remove "(void)".
8581         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8582         Return bool.
8583
8584 2019-02-15  Tom Tromey  <tromey@adacore.com>
8585
8586         * ravenscar-thread.c (ravenscar_runtime_initializer)
8587         (has_ravenscar_runtime, get_running_thread_id)
8588         (ravenscar_thread_target::resume): Fix indentation.
8589
8590 2019-02-15  Tom Tromey  <tromey@adacore.com>
8591
8592         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8593         from ravenscar_arch_ops.
8594         (sparc_ravenscar_ops::fetch_registers)
8595         (sparc_ravenscar_ops::store_registers): Now methods.
8596         (sparc_ravenscar_prepare_to_store): Remove.
8597         (sparc_ravenscar_ops): Redefine.
8598         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8599         methods and destructor.  Remove members.
8600         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8601         (ravenscar_thread_target::store_registers)
8602         (ravenscar_thread_target::prepare_to_store): Update.
8603         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8604         Remove.
8605         (struct ppc_ravenscar_powerpc_ops): Derive from
8606         ravenscar_arch_ops.
8607         (ppc_ravenscar_powerpc_ops::fetch_registers)
8608         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8609         (ppc_ravenscar_powerpc_ops): Redefine.
8610         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8611         (ppc_ravenscar_e500_ops::fetch_registers)
8612         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8613         (ppc_ravenscar_e500_ops): Redefine.
8614         * aarch64-ravenscar-thread.c
8615         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8616         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8617         (aarch64_ravenscar_fetch_registers)
8618         (aarch64_ravenscar_store_registers): Now methods.
8619         (aarch64_ravenscar_ops): Redefine.
8620
8621 2019-02-15  Tom Tromey  <tromey@adacore.com>
8622
8623         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8624         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8625         (ravenscar_thread_target::stopped_by_watchpoint)
8626         (ravenscar_thread_target::stopped_data_address)
8627         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8628
8629 2019-02-15  Tom Tromey  <tromey@adacore.com>
8630
8631         * ravenscar-thread.c: Fix some typos.
8632
8633 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8634             Tom Tromey  <tromey@adacore.com>
8635
8636         * ada-lang.c (ada_exception_sal): Change addr_string to a
8637         std::string.
8638         (create_ada_exception_catchpoint): Update.
8639
8640 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8641             Tom Tromey  <tromey@adacore.com>
8642
8643         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8644         (bp_location_ops): Remove.
8645         (base_breakpoint_allocate_location): Update.
8646         (free_bp_location): Update.
8647         * ada-lang.c (class ada_catchpoint_location)
8648         <ada_catchpoint_location>: Remove ops parameter.
8649         (ada_catchpoint_location_dtor): Remove.
8650         (ada_catchpoint_location_ops): Remove.
8651         (allocate_location_exception): Update.
8652         * breakpoint.h (struct bp_location_ops): Remove.
8653         (class bp_location) <bp_location>: Remove bp_location_ops
8654         parameter.
8655         <~bp_location>: Add destructor.
8656         <ops>: Remove.
8657
8658 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8659             Pedro Alves  <palves@redhat.com>
8660
8661         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8662         'PATH_MAX'.
8663
8664 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8665             Samuel Thibault  <samuel.thibault@gnu.org>
8666             Thomas Schwinge  <thomas@codesourcery.com>
8667
8668         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8669         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8670
8671 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8672
8673         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8674         (check_empty): Use "const char *".
8675
8676         * gnu-nat.c (gnu_nat_target::detach): Instead of
8677         'detach_inferior (pid)' call
8678         'detach_inferior (find_inferior_pid (pid))'.
8679
8680         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8681         'nat/fork-inferior.o'.
8682         * gnu-nat.c: #include "nat/fork-inferior.h".
8683
8684         * gnu-nat.c (gnu_nat_target::detach): Instead of
8685         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8686         * gnu-nat.h: #include "inf-child.h".
8687         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8688         'i386_gnu_nat_target::fetch_registers'.
8689         (gnu_store_registers): Rename/move to
8690         'i386_gnu_nat_target::store_registers'.
8691
8692         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8693         * gnu-nat.h (mach_thread_info): New function.
8694         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8695
8696         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8697
8698 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8699
8700         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8701
8702 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8703
8704         * windows-nat.c (windows_add_thread): Add new parameter
8705         "main_thread_p" with default value set to false.  Update
8706         function documentation as well as all callers.
8707         (windows_delete_thread): Likewise.
8708         (fake_create_process): Update call to windows_add_thread.
8709         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8710         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8711         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8712         call to windows_delete_thread.
8713
8714 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8715
8716         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8717
8718 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8719
8720         * symfile.c (find_separate_debug_file): Use canonical path of
8721         sysroot with child_path instead of gdb_sysroot if it is valid.
8722
8723 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8724
8725         * symfile.c (find_separate_debug_file): Use child_path to
8726         determine if an object file is under a sysroot.
8727
8728 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8729
8730         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8731         unittests/child-path-selftests.c.
8732         * common/pathstuff.c (child_path): New function.
8733         * common/pathstuff.h (child_path): New prototype.
8734         * unittests/child-path-selftests.c: New file.
8735
8736 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8737
8738         * symfile.c (find_separate_debug_file): Look for separate debug
8739         files in debug directories under the sysroot.
8740
8741 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8742
8743         * symtab.h (struct minimal_symbol data_p): New const method.
8744         (struct minimal_symbol text_p): Likewise.
8745         * symtab.c (output_source_filename): Use file name style
8746         to print file name.
8747         (print_symbol_info): Likewise.
8748         (print_msymbol_info): Use address style to print addresses.
8749         Use function name style to print executable text symbols.
8750         (expand_symtab_containing_pc): Use data_p.
8751         (find_pc_sect_compunit_symtab): Likewise.
8752
8753 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8754
8755         * breakpoint.c (describe_other_breakpoints): Use address style
8756         to print addresses.
8757         (say_where): Likewise.
8758
8759 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8760
8761         * ada-typeprint.c (print_func_type): Print function name
8762         style to print function name.
8763         * c-typeprint.c (c_print_type_1): Likewise.
8764
8765 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8766
8767         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8768         for execve.
8769
8770 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8771
8772         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8773         type_stack.
8774
8775 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8776
8777         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8778         TYPE_CODE_REF types.
8779
8780 2019-02-08  Jim Wilson  <jimw@sifive.com>
8781
8782         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8783         (riscv_linux_fregset): New.
8784         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8785
8786 2019-02-07  Tom Tromey  <tom@tromey.com>
8787
8788         * thread.c (thread_cancel_execution_command): Update.
8789         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8790         methods.
8791         (struct thread_fsm_ops): Remove.
8792         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8793         (thread_fsm_should_stop, thread_fsm_return_value)
8794         (thread_fsm_set_finished, thread_fsm_finished_p)
8795         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8796         Don't declare.
8797         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8798         * infrun.c (clear_proceed_status_thread)
8799         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8800         (print_stop_event): Update.
8801         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8802         Add constructor.
8803         (step_command_fsm_ops): Remove.
8804         (new_step_command_fsm): Remove.
8805         (step_1): Update.
8806         (step_command_fsm::should_stop): Rename from
8807         step_command_fsm_should_stop.
8808         (step_command_fsm::clean_up): Rename from
8809         step_command_fsm_clean_up.
8810         (step_command_fsm::do_async_reply_reason): Rename from
8811         step_command_fsm_async_reply_reason.
8812         (struct until_next_fsm): Inherit from thread_fsm.  Add
8813         constructor.
8814         (until_next_fsm_ops): Remove.
8815         (new_until_next_fsm): Remove.
8816         (until_next_fsm::should_stop): Rename from
8817         until_next_fsm_should_stop.
8818         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8819         (until_next_fsm::do_async_reply_reason): Rename from
8820         until_next_fsm_async_reply_reason.
8821         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8822         constructor.  Change type of breakpoint.
8823         (finish_command_fsm_ops): Remove.
8824         (new_finish_command_fsm): Remove.
8825         (finish_command_fsm::should_stop): Rename from
8826         finish_command_fsm_should_stop.
8827         (finish_command_fsm::clean_up): Rename from
8828         finish_command_fsm_clean_up.
8829         (finish_command_fsm::return_value): Rename from
8830         finish_command_fsm_return_value.
8831         (finish_command_fsm::do_async_reply_reason): Rename from
8832         finish_command_fsm_async_reply_reason.
8833         (finish_command): Update.
8834         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8835         Add constructor.
8836         (call_thread_fsm_ops): Remove.
8837         (call_thread_fsm::call_thread_fsm): Rename from
8838         new_call_thread_fsm.
8839         (call_thread_fsm::should_stop): Rename from
8840         call_thread_fsm_should_stop.
8841         (call_thread_fsm::should_notify_stop): Rename from
8842         call_thread_fsm_should_notify_stop.
8843         (run_inferior_call, call_function_by_hand_dummy): Update.
8844         * cli/cli-interp.c (should_print_stop_to_console): Update.
8845         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8846         Add constructor.  Change type of location_breakpoint,
8847         caller_breakpoint.
8848         (until_break_fsm_ops): Remove.
8849         (new_until_break_fsm): Remove.
8850         (until_break_fsm::should_stop): Rename from
8851         until_break_fsm_should_stop.
8852         (until_break_fsm::clean_up): Rename from
8853         until_break_fsm_clean_up.
8854         (until_break_fsm::do_async_reply_reason): Rename from
8855         until_break_fsm_async_reply_reason.
8856         (until_break_command): Update.
8857         * thread-fsm.c: Remove.
8858         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8859
8860 2019-02-07  Tom Tromey  <tom@tromey.com>
8861
8862         * yy-remap.h: Add include guard.
8863         * xtensa-tdep.h: Add include guard.
8864         * xcoffread.h: Rename include guard.
8865         * varobj-iter.h: Add include guard.
8866         * tui/tui.h: Rename include guard.
8867         * tui/tui-winsource.h: Rename include guard.
8868         * tui/tui-wingeneral.h: Rename include guard.
8869         * tui/tui-windata.h: Rename include guard.
8870         * tui/tui-win.h: Rename include guard.
8871         * tui/tui-stack.h: Rename include guard.
8872         * tui/tui-source.h: Rename include guard.
8873         * tui/tui-regs.h: Rename include guard.
8874         * tui/tui-out.h: Rename include guard.
8875         * tui/tui-layout.h: Rename include guard.
8876         * tui/tui-io.h: Rename include guard.
8877         * tui/tui-hooks.h: Rename include guard.
8878         * tui/tui-file.h: Rename include guard.
8879         * tui/tui-disasm.h: Rename include guard.
8880         * tui/tui-data.h: Rename include guard.
8881         * tui/tui-command.h: Rename include guard.
8882         * tic6x-tdep.h: Add include guard.
8883         * target/waitstatus.h: Rename include guard.
8884         * target/wait.h: Rename include guard.
8885         * target/target.h: Rename include guard.
8886         * target/resume.h: Rename include guard.
8887         * target-float.h: Rename include guard.
8888         * stabsread.h: Add include guard.
8889         * rs6000-tdep.h: Add include guard.
8890         * riscv-fbsd-tdep.h: Add include guard.
8891         * regformats/regdef.h: Rename include guard.
8892         * record.h: Rename include guard.
8893         * python/python.h: Rename include guard.
8894         * python/python-internal.h: Rename include guard.
8895         * python/py-stopevent.h: Rename include guard.
8896         * python/py-ref.h: Rename include guard.
8897         * python/py-record.h: Rename include guard.
8898         * python/py-record-full.h: Rename include guard.
8899         * python/py-record-btrace.h: Rename include guard.
8900         * python/py-instruction.h: Rename include guard.
8901         * python/py-events.h: Rename include guard.
8902         * python/py-event.h: Rename include guard.
8903         * procfs.h: Add include guard.
8904         * proc-utils.h: Add include guard.
8905         * p-lang.h: Add include guard.
8906         * or1k-tdep.h: Rename include guard.
8907         * observable.h: Rename include guard.
8908         * nto-tdep.h: Rename include guard.
8909         * nat/x86-linux.h: Rename include guard.
8910         * nat/x86-linux-dregs.h: Rename include guard.
8911         * nat/x86-gcc-cpuid.h: Add include guard.
8912         * nat/x86-dregs.h: Rename include guard.
8913         * nat/x86-cpuid.h: Rename include guard.
8914         * nat/ppc-linux.h: Rename include guard.
8915         * nat/mips-linux-watch.h: Rename include guard.
8916         * nat/linux-waitpid.h: Rename include guard.
8917         * nat/linux-ptrace.h: Rename include guard.
8918         * nat/linux-procfs.h: Rename include guard.
8919         * nat/linux-osdata.h: Rename include guard.
8920         * nat/linux-nat.h: Rename include guard.
8921         * nat/linux-namespaces.h: Rename include guard.
8922         * nat/linux-btrace.h: Rename include guard.
8923         * nat/glibc_thread_db.h: Rename include guard.
8924         * nat/gdb_thread_db.h: Rename include guard.
8925         * nat/gdb_ptrace.h: Rename include guard.
8926         * nat/fork-inferior.h: Rename include guard.
8927         * nat/amd64-linux-siginfo.h: Rename include guard.
8928         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8929         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8930         * nat/aarch64-linux.h: Rename include guard.
8931         * nat/aarch64-linux-hw-point.h: Rename include guard.
8932         * mn10300-tdep.h: Add include guard.
8933         * mips-linux-tdep.h: Add include guard.
8934         * mi/mi-parse.h: Rename include guard.
8935         * mi/mi-out.h: Rename include guard.
8936         * mi/mi-main.h: Rename include guard.
8937         * mi/mi-interp.h: Rename include guard.
8938         * mi/mi-getopt.h: Rename include guard.
8939         * mi/mi-console.h: Rename include guard.
8940         * mi/mi-common.h: Rename include guard.
8941         * mi/mi-cmds.h: Rename include guard.
8942         * mi/mi-cmd-break.h: Rename include guard.
8943         * m2-lang.h: Add include guard.
8944         * location.h: Rename include guard.
8945         * linux-record.h: Rename include guard.
8946         * linux-nat.h: Add include guard.
8947         * linux-fork.h: Add include guard.
8948         * i386-darwin-tdep.h: Rename include guard.
8949         * hppa-linux-offsets.h: Add include guard.
8950         * guile/guile.h: Rename include guard.
8951         * guile/guile-internal.h: Rename include guard.
8952         * gnu-nat.h: Rename include guard.
8953         * gdb-stabs.h: Rename include guard.
8954         * frv-tdep.h: Add include guard.
8955         * f-lang.h: Add include guard.
8956         * event-loop.h: Add include guard.
8957         * darwin-nat.h: Rename include guard.
8958         * cp-abi.h: Rename include guard.
8959         * config/sparc/nm-sol2.h: Rename include guard.
8960         * config/nm-nto.h: Rename include guard.
8961         * config/nm-linux.h: Add include guard.
8962         * config/i386/nm-i386gnu.h: Rename include guard.
8963         * config/djgpp/nl_types.h: Rename include guard.
8964         * config/djgpp/langinfo.h: Rename include guard.
8965         * compile/gcc-cp-plugin.h: Add include guard.
8966         * compile/gcc-c-plugin.h: Add include guard.
8967         * compile/compile.h: Rename include guard.
8968         * compile/compile-object-run.h: Rename include guard.
8969         * compile/compile-object-load.h: Rename include guard.
8970         * compile/compile-internal.h: Rename include guard.
8971         * compile/compile-cplus.h: Rename include guard.
8972         * compile/compile-c.h: Rename include guard.
8973         * common/xml-utils.h: Rename include guard.
8974         * common/x86-xstate.h: Rename include guard.
8975         * common/version.h: Rename include guard.
8976         * common/vec.h: Rename include guard.
8977         * common/tdesc.h: Rename include guard.
8978         * common/selftest.h: Rename include guard.
8979         * common/scoped_restore.h: Rename include guard.
8980         * common/scoped_mmap.h: Rename include guard.
8981         * common/scoped_fd.h: Rename include guard.
8982         * common/safe-iterator.h: Rename include guard.
8983         * common/run-time-clock.h: Rename include guard.
8984         * common/refcounted-object.h: Rename include guard.
8985         * common/queue.h: Rename include guard.
8986         * common/ptid.h: Rename include guard.
8987         * common/print-utils.h: Rename include guard.
8988         * common/preprocessor.h: Rename include guard.
8989         * common/pathstuff.h: Rename include guard.
8990         * common/observable.h: Rename include guard.
8991         * common/netstuff.h: Rename include guard.
8992         * common/job-control.h: Rename include guard.
8993         * common/host-defs.h: Rename include guard.
8994         * common/gdb_wait.h: Rename include guard.
8995         * common/gdb_vecs.h: Rename include guard.
8996         * common/gdb_unlinker.h: Rename include guard.
8997         * common/gdb_unique_ptr.h: Rename include guard.
8998         * common/gdb_tilde_expand.h: Rename include guard.
8999         * common/gdb_sys_time.h: Rename include guard.
9000         * common/gdb_string_view.h: Rename include guard.
9001         * common/gdb_splay_tree.h: Rename include guard.
9002         * common/gdb_setjmp.h: Rename include guard.
9003         * common/gdb_ref_ptr.h: Rename include guard.
9004         * common/gdb_optional.h: Rename include guard.
9005         * common/gdb_locale.h: Rename include guard.
9006         * common/gdb_assert.h: Rename include guard.
9007         * common/filtered-iterator.h: Rename include guard.
9008         * common/filestuff.h: Rename include guard.
9009         * common/fileio.h: Rename include guard.
9010         * common/environ.h: Rename include guard.
9011         * common/common-utils.h: Rename include guard.
9012         * common/common-types.h: Rename include guard.
9013         * common/common-regcache.h: Rename include guard.
9014         * common/common-inferior.h: Rename include guard.
9015         * common/common-gdbthread.h: Rename include guard.
9016         * common/common-exceptions.h: Rename include guard.
9017         * common/common-defs.h: Rename include guard.
9018         * common/common-debug.h: Rename include guard.
9019         * common/cleanups.h: Rename include guard.
9020         * common/buffer.h: Rename include guard.
9021         * common/btrace-common.h: Rename include guard.
9022         * common/break-common.h: Rename include guard.
9023         * cli/cli-utils.h: Rename include guard.
9024         * cli/cli-style.h: Rename include guard.
9025         * cli/cli-setshow.h: Rename include guard.
9026         * cli/cli-script.h: Rename include guard.
9027         * cli/cli-interp.h: Rename include guard.
9028         * cli/cli-decode.h: Rename include guard.
9029         * cli/cli-cmds.h: Rename include guard.
9030         * charset-list.h: Add include guard.
9031         * buildsym-legacy.h: Rename include guard.
9032         * bfin-tdep.h: Add include guard.
9033         * ax.h: Rename include guard.
9034         * arm-linux-tdep.h: Add include guard.
9035         * arm-fbsd-tdep.h: Add include guard.
9036         * arch/xtensa.h: Rename include guard.
9037         * arch/tic6x.h: Add include guard.
9038         * arch/i386.h: Add include guard.
9039         * arch/arm.h: Rename include guard.
9040         * arch/arm-linux.h: Rename include guard.
9041         * arch/arm-get-next-pcs.h: Rename include guard.
9042         * arch/amd64.h: Add include guard.
9043         * arch/aarch64-insn.h: Rename include guard.
9044         * arch-utils.h: Rename include guard.
9045         * annotate.h: Add include guard.
9046         * amd64-darwin-tdep.h: Rename include guard.
9047         * aarch64-linux-tdep.h: Add include guard.
9048         * aarch64-fbsd-tdep.h: Add include guard.
9049         * aarch32-linux-nat.h: Add include guard.
9050
9051 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9052
9053         * macrotab.c (macro_define_internal): New function that
9054         factorizes macro_define_object_internal and macro_define_function
9055         code.
9056         (macro_define_object_internal): Use macro_define_internal.
9057         (macro_define_function): Likewise.
9058
9059 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9060
9061         * macrocmd.c (extract_identifier): Return
9062         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9063         callers.
9064
9065 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9066
9067         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9068
9069 2019-02-05  Tom Tromey  <tom@tromey.com>
9070
9071         * target.c (target_stack::unpush): Move assertion earlier.
9072
9073 2019-01-30  Tom Tromey  <tom@tromey.com>
9074
9075         PR python/23615:
9076         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9077         (gdbpy_parse_and_eval): Likewise.
9078         * python/python-internal.h (gdbpy_allow_threads): New class.
9079
9080 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9081
9082         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9083         (aarch64_fbsd_fpregmap): Move earlier.
9084         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9085         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9086         instead of individual calls to trad_frame_set_reg_addr.
9087         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9088         earlier.
9089         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9090         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9091         instead of individual calls to trad_frame_set_reg_addr.
9092
9093 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9094
9095         * CONTRIBUTE: Replace contribution list with wiki link.
9096
9097 2019-01-25  Tom Tromey  <tom@tromey.com>
9098
9099         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9100
9101 2019-01-25  Tom Tromey  <tom@tromey.com>
9102
9103         * xtensa-linux-nat.c: Fix common/ includes.
9104         * xml-support.h: Fix common/ includes.
9105         * xml-support.c: Fix common/ includes.
9106         * x86-linux-nat.c: Fix common/ includes.
9107         * windows-nat.c: Fix common/ includes.
9108         * varobj.h: Fix common/ includes.
9109         * varobj.c: Fix common/ includes.
9110         * value.c: Fix common/ includes.
9111         * valops.c: Fix common/ includes.
9112         * utils.c: Fix common/ includes.
9113         * unittests/xml-utils-selftests.c: Fix common/ includes.
9114         * unittests/utils-selftests.c: Fix common/ includes.
9115         * unittests/unpack-selftests.c: Fix common/ includes.
9116         * unittests/tracepoint-selftests.c: Fix common/ includes.
9117         * unittests/style-selftests.c: Fix common/ includes.
9118         * unittests/string_view-selftests.c: Fix common/ includes.
9119         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9120         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9121         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9122         * unittests/rsp-low-selftests.c: Fix common/ includes.
9123         * unittests/parse-connection-spec-selftests.c: Fix common/
9124         includes.
9125         * unittests/optional-selftests.c: Fix common/ includes.
9126         * unittests/offset-type-selftests.c: Fix common/ includes.
9127         * unittests/observable-selftests.c: Fix common/ includes.
9128         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9129         * unittests/memrange-selftests.c: Fix common/ includes.
9130         * unittests/memory-map-selftests.c: Fix common/ includes.
9131         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9132         * unittests/function-view-selftests.c: Fix common/ includes.
9133         * unittests/environ-selftests.c: Fix common/ includes.
9134         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9135         * unittests/common-utils-selftests.c: Fix common/ includes.
9136         * unittests/cli-utils-selftests.c: Fix common/ includes.
9137         * unittests/array-view-selftests.c: Fix common/ includes.
9138         * ui-file.c: Fix common/ includes.
9139         * tui/tui-io.c: Fix common/ includes.
9140         * tracepoint.h: Fix common/ includes.
9141         * tracepoint.c: Fix common/ includes.
9142         * tracefile-tfile.c: Fix common/ includes.
9143         * top.h: Fix common/ includes.
9144         * top.c: Fix common/ includes.
9145         * thread.c: Fix common/ includes.
9146         * target/waitstatus.h: Fix common/ includes.
9147         * target/waitstatus.c: Fix common/ includes.
9148         * target.h: Fix common/ includes.
9149         * target.c: Fix common/ includes.
9150         * target-memory.c: Fix common/ includes.
9151         * target-descriptions.c: Fix common/ includes.
9152         * symtab.h: Fix common/ includes.
9153         * symfile.c: Fix common/ includes.
9154         * stap-probe.c: Fix common/ includes.
9155         * spu-linux-nat.c: Fix common/ includes.
9156         * sparc-nat.c: Fix common/ includes.
9157         * source.c: Fix common/ includes.
9158         * solib.c: Fix common/ includes.
9159         * solib-target.c: Fix common/ includes.
9160         * ser-unix.c: Fix common/ includes.
9161         * ser-tcp.c: Fix common/ includes.
9162         * ser-pipe.c: Fix common/ includes.
9163         * ser-base.c: Fix common/ includes.
9164         * selftest-arch.c: Fix common/ includes.
9165         * s12z-tdep.c: Fix common/ includes.
9166         * rust-exp.y: Fix common/ includes.
9167         * rs6000-aix-tdep.c: Fix common/ includes.
9168         * riscv-tdep.c: Fix common/ includes.
9169         * remote.c: Fix common/ includes.
9170         * remote-notif.h: Fix common/ includes.
9171         * remote-fileio.h: Fix common/ includes.
9172         * remote-fileio.c: Fix common/ includes.
9173         * regcache.h: Fix common/ includes.
9174         * regcache.c: Fix common/ includes.
9175         * record-btrace.c: Fix common/ includes.
9176         * python/python.c: Fix common/ includes.
9177         * python/py-type.c: Fix common/ includes.
9178         * python/py-inferior.c: Fix common/ includes.
9179         * progspace.h: Fix common/ includes.
9180         * producer.c: Fix common/ includes.
9181         * procfs.c: Fix common/ includes.
9182         * proc-api.c: Fix common/ includes.
9183         * printcmd.c: Fix common/ includes.
9184         * ppc-linux-nat.c: Fix common/ includes.
9185         * parser-defs.h: Fix common/ includes.
9186         * osdata.c: Fix common/ includes.
9187         * obsd-nat.c: Fix common/ includes.
9188         * nat/x86-linux.c: Fix common/ includes.
9189         * nat/x86-linux-dregs.c: Fix common/ includes.
9190         * nat/x86-dregs.h: Fix common/ includes.
9191         * nat/x86-dregs.c: Fix common/ includes.
9192         * nat/ppc-linux.c: Fix common/ includes.
9193         * nat/mips-linux-watch.h: Fix common/ includes.
9194         * nat/mips-linux-watch.c: Fix common/ includes.
9195         * nat/linux-waitpid.c: Fix common/ includes.
9196         * nat/linux-ptrace.h: Fix common/ includes.
9197         * nat/linux-ptrace.c: Fix common/ includes.
9198         * nat/linux-procfs.c: Fix common/ includes.
9199         * nat/linux-personality.c: Fix common/ includes.
9200         * nat/linux-osdata.c: Fix common/ includes.
9201         * nat/linux-namespaces.c: Fix common/ includes.
9202         * nat/linux-btrace.h: Fix common/ includes.
9203         * nat/linux-btrace.c: Fix common/ includes.
9204         * nat/fork-inferior.c: Fix common/ includes.
9205         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9206         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9207         * nat/aarch64-linux.c: Fix common/ includes.
9208         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9209         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9210         * namespace.h: Fix common/ includes.
9211         * mips-linux-tdep.c: Fix common/ includes.
9212         * minsyms.c: Fix common/ includes.
9213         * mi/mi-parse.h: Fix common/ includes.
9214         * mi/mi-main.c: Fix common/ includes.
9215         * mi/mi-cmd-env.c: Fix common/ includes.
9216         * memrange.h: Fix common/ includes.
9217         * memattr.c: Fix common/ includes.
9218         * maint.h: Fix common/ includes.
9219         * maint.c: Fix common/ includes.
9220         * main.c: Fix common/ includes.
9221         * machoread.c: Fix common/ includes.
9222         * location.c: Fix common/ includes.
9223         * linux-thread-db.c: Fix common/ includes.
9224         * linux-nat.c: Fix common/ includes.
9225         * linux-fork.c: Fix common/ includes.
9226         * inline-frame.c: Fix common/ includes.
9227         * infrun.c: Fix common/ includes.
9228         * inflow.c: Fix common/ includes.
9229         * inferior.h: Fix common/ includes.
9230         * inferior.c: Fix common/ includes.
9231         * infcmd.c: Fix common/ includes.
9232         * inf-ptrace.c: Fix common/ includes.
9233         * inf-child.c: Fix common/ includes.
9234         * ia64-linux-nat.c: Fix common/ includes.
9235         * i387-tdep.c: Fix common/ includes.
9236         * i386-tdep.c: Fix common/ includes.
9237         * i386-linux-tdep.c: Fix common/ includes.
9238         * i386-linux-nat.c: Fix common/ includes.
9239         * i386-go32-tdep.c: Fix common/ includes.
9240         * i386-fbsd-tdep.c: Fix common/ includes.
9241         * i386-fbsd-nat.c: Fix common/ includes.
9242         * guile/scm-type.c: Fix common/ includes.
9243         * guile/guile.c: Fix common/ includes.
9244         * go32-nat.c: Fix common/ includes.
9245         * gnu-nat.c: Fix common/ includes.
9246         * gdbthread.h: Fix common/ includes.
9247         * gdbarch-selftests.c: Fix common/ includes.
9248         * gdb_usleep.c: Fix common/ includes.
9249         * gdb_select.h: Fix common/ includes.
9250         * gdb_bfd.c: Fix common/ includes.
9251         * gcore.c: Fix common/ includes.
9252         * fork-child.c: Fix common/ includes.
9253         * findvar.c: Fix common/ includes.
9254         * fbsd-nat.c: Fix common/ includes.
9255         * event-top.c: Fix common/ includes.
9256         * event-loop.c: Fix common/ includes.
9257         * dwarf2read.c: Fix common/ includes.
9258         * dwarf2loc.c: Fix common/ includes.
9259         * dwarf2-frame.c: Fix common/ includes.
9260         * dwarf-index-cache.c: Fix common/ includes.
9261         * dtrace-probe.c: Fix common/ includes.
9262         * disasm-selftests.c: Fix common/ includes.
9263         * defs.h: Fix common/ includes.
9264         * csky-tdep.c: Fix common/ includes.
9265         * cp-valprint.c: Fix common/ includes.
9266         * cp-support.h: Fix common/ includes.
9267         * cp-support.c: Fix common/ includes.
9268         * corelow.c: Fix common/ includes.
9269         * completer.h: Fix common/ includes.
9270         * completer.c: Fix common/ includes.
9271         * compile/compile.c: Fix common/ includes.
9272         * compile/compile-loc2c.c: Fix common/ includes.
9273         * compile/compile-cplus-types.c: Fix common/ includes.
9274         * compile/compile-cplus-symbols.c: Fix common/ includes.
9275         * command.h: Fix common/ includes.
9276         * cli/cli-dump.c: Fix common/ includes.
9277         * cli/cli-cmds.c: Fix common/ includes.
9278         * charset.c: Fix common/ includes.
9279         * build-id.c: Fix common/ includes.
9280         * btrace.h: Fix common/ includes.
9281         * btrace.c: Fix common/ includes.
9282         * breakpoint.h: Fix common/ includes.
9283         * breakpoint.c: Fix common/ includes.
9284         * ax.h:
9285         (enum agent_op): Fix common/ includes.
9286         * ax-general.c (struct aop_map): Fix common/ includes.
9287         * ax-gdb.c: Fix common/ includes.
9288         * auxv.c: Fix common/ includes.
9289         * auto-load.c: Fix common/ includes.
9290         * arm-tdep.c: Fix common/ includes.
9291         * arch/riscv.c: Fix common/ includes.
9292         * arch/ppc-linux-common.c: Fix common/ includes.
9293         * arch/i386.c: Fix common/ includes.
9294         * arch/arm.c: Fix common/ includes.
9295         * arch/arm-linux.c: Fix common/ includes.
9296         * arch/arm-get-next-pcs.c: Fix common/ includes.
9297         * arch/amd64.c: Fix common/ includes.
9298         * arch/aarch64.c: Fix common/ includes.
9299         * arch/aarch64-insn.c: Fix common/ includes.
9300         * arch-utils.c: Fix common/ includes.
9301         * amd64-windows-tdep.c: Fix common/ includes.
9302         * amd64-tdep.c: Fix common/ includes.
9303         * amd64-sol2-tdep.c: Fix common/ includes.
9304         * amd64-obsd-tdep.c: Fix common/ includes.
9305         * amd64-nbsd-tdep.c: Fix common/ includes.
9306         * amd64-linux-tdep.c: Fix common/ includes.
9307         * amd64-linux-nat.c: Fix common/ includes.
9308         * amd64-fbsd-tdep.c: Fix common/ includes.
9309         * amd64-fbsd-nat.c: Fix common/ includes.
9310         * amd64-dicos-tdep.c: Fix common/ includes.
9311         * amd64-darwin-tdep.c: Fix common/ includes.
9312         * agent.c: Fix common/ includes.
9313         * ada-lang.h: Fix common/ includes.
9314         * ada-lang.c: Fix common/ includes.
9315         * aarch64-tdep.c: Fix common/ includes.
9316
9317 2019-01-25  Tom Tromey  <tom@tromey.com>
9318
9319         * common/create-version.sh: Use common/version.h.
9320
9321 2019-01-24  Pedro Alves  <palves@redhat.com>
9322
9323         * infrun.c (signal_stop, signal_print, signal_program)
9324         (signal_catch, signal_pass): Now arrays instead of pointers.
9325         (update_signals_program_target, do_target_resume)
9326         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9327         * linux-nat.c (linux_nat_target::pass_signals)
9328         (linux_nat_target::create_inferior, linux_nat_target::attach):
9329         Adjust.
9330         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9331         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9332         * procfs.c (procfs_target::pass_signals): Adjust.
9333         * record-full.c (record_full_target::resume): Adjust.
9334         * remote.c (remote_target::pass_signals)
9335         (remote_target::program_signals): Adjust.
9336         * target-debug.h (target_debug_print_signals): Now takes a
9337         gdb::array_view as parameter.  Adjust.
9338         * target.h (target_ops) <pass_signals, program_signals>: Replace
9339         pointer and length parameters with gdb::array_view.
9340         (target_pass_signals, target_program_signals): Likewise.
9341         * target-delegates.c: Regenerate.
9342
9343 2019-01-24  Pedro Alves  <palves@redhat.com>
9344
9345         * common/forward-scope-exit.h
9346         (forward_scope_exit::forward_scope_exit): Pass arguments to
9347         m_bind_function directly, instead of creating a std::bind and
9348         copying that.
9349
9350 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9351
9352         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9353         for static members.
9354         (pass_in_v_vfp_candidate): Likewise.
9355
9356 2019-01-23  Tom Tromey  <tom@tromey.com>
9357             Pedro Alves  <palves@redhat.com>
9358
9359         * regcache.c (class regcache_invalidator): Remove.
9360         (regcache::raw_write): Use make_scope_exit.
9361
9362 2019-01-23  Tom Tromey  <tom@tromey.com>
9363
9364         * ui-out.h (class ui_out_emit_type): Update comment.
9365
9366 2019-01-23  Tom Tromey  <tom@tromey.com>
9367
9368         * infrun.c (fetch_inferior_event): Update comment.
9369
9370 2019-01-23  Tom Tromey  <tom@tromey.com>
9371             Pedro Alves  <palves@redhat.com>
9372
9373         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9374         parameter.
9375         (fetch_inferior_event): Use SCOPE_EXIT.
9376
9377
9378 2019-01-23  Tom Tromey  <tom@tromey.com>
9379             Pedro Alves  <palves@redhat.com>
9380
9381         * infrun.c (disable_thread_events): Delete.
9382         (stop_all_threads): Use SCOPE_EXIT.
9383
9384 2019-01-23  Tom Tromey  <tom@tromey.com>
9385             Pedro Alves  <palves@redhat.com>
9386
9387         * symfile.c: Include forward-scope-exit.h.
9388         (clear_symtab_users_cleanup): Replace forward declaration with
9389         a FORWARD_SCOPE_EXIT.
9390         (syms_from_objfile_1): Use the forward_scope_exit and
9391         gdb::optional instead of cleanup_function.
9392         (reread_symbols): Use the forward_scope_exit instead of
9393         cleanup_function.
9394         (clear_symtab_users_cleanup): Remove function.
9395
9396 2019-01-23  Tom Tromey  <tom@tromey.com>
9397             Pedro Alves  <palves@redhat.com>
9398
9399         * linux-nat.c: Include scope-exit.h.
9400         (cleanup_target_stop): Remove.
9401         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9402         SCOPE_EXIT.
9403
9404 2019-01-23  Tom Tromey  <tom@tromey.com>
9405             Pedro Alves  <palves@redhat.com>
9406
9407         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9408         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9409
9410 2019-01-23  Tom Tromey  <tom@tromey.com>
9411             Andrew Burgess  <andrew.burgess@embecosm.com>
9412             Pedro Alves  <palves@redhat.com>
9413
9414         * infrun.c (fetch_inferior_event): Use scope_exit.
9415         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9416         * top.c (execute_command): Use scope_exit.
9417         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9418         * utils.c (do_bpstat_clear_actions_cleanup)
9419         (make_bpstat_clear_actions_cleanup): Remove.
9420
9421 2019-01-23  Tom Tromey  <tom@tromey.com>
9422             Pedro Alves  <palves@redhat.com>
9423
9424         * infrun.c: Include "common/scope-exit.h"
9425         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9426         (wait_for_inferior): Use SCOPE_EXIT.
9427         (fetch_inferior_event): Use scope_exit.
9428
9429 2019-01-23  Tom Tromey  <tom@tromey.com>
9430             Pedro Alves  <palves@redhat.com>
9431
9432         * breakpoint.c (create_breakpoint): Remove cleanup.
9433
9434 2019-01-23  Tom Tromey  <tom@tromey.com>
9435             Andrew Burgess  <andrew.burgess@embecosm.com>
9436             Pedro Alves  <palves@redhat.com>
9437
9438 2019-01-23  Pedro Alves  <palves@redhat.com>
9439
9440         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9441
9442 2019-01-23  Pedro Alves  <palves@redhat.com>
9443             Andrew Burgess  <andrew.burgess@embecosm.com>
9444
9445         * gdbthread.h: Include "common/forward-scope-exit.h".
9446         (scoped_finish_thread_state): Redefine custom class in terms of
9447         forward_scope_exit.
9448
9449 2019-01-23  Pedro Alves  <palves@redhat.com>
9450             Andrew Burgess  <andrew.burgess@embecosm.com>
9451
9452         * common/forward-scope-exit.h: New file.
9453
9454 2019-01-23  Pedro Alves  <palves@redhat.com>
9455             Andrew Burgess  <andrew.burgess@embecosm.com>
9456             Tom Tromey  <tom@tromey.com>
9457
9458         * common/scope-exit.h: New file.
9459
9460 2019-01-23  Pedro Alves  <palves@redhat.com>
9461
9462         * common/preprocessor.h (ESC): Rename to ...
9463         (ESC_PARENS): ... this.
9464         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9465         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9466
9467 2019-01-23  Tom Tromey  <tom@tromey.com>
9468
9469         * language.h (class scoped_switch_to_sym_language_if_auto):
9470         Initialize m_lang in both cases.
9471
9472 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9473
9474         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9475         with XCNEW.
9476
9477 2019-01-22  Tom Tromey  <tom@tromey.com>
9478
9479         * corelow.c: Do not include sys/file.h.
9480
9481 2019-01-22  Tom Tromey  <tom@tromey.com>
9482
9483         * tui/tui-wingeneral.h: Include gdb_curses.h.
9484
9485 2019-01-22  Tom Tromey  <tom@tromey.com>
9486
9487         * source-cache.h (class source_cache) <get_source_lines,
9488         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9489
9490 2019-01-22  Tom Tromey  <tom@tromey.com>
9491
9492         * remote-fileio.h (struct remote_target): Declare.
9493
9494 2019-01-22  Tom Tromey  <tom@tromey.com>
9495
9496         * python/py-arch.c: Do not include py-ref.h.
9497         * python/py-bpevent.c: Do not include py-ref.h.
9498         * python/py-cmd.c: Do not include py-ref.h.
9499         * python/py-continueevent.c: Do not include py-ref.h.
9500         * python/py-event.h: Do not include py-ref.h.
9501         * python/py-evtregistry.c: Do not include py-ref.h.
9502         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9503         * python/py-frame.c: Do not include py-ref.h.
9504         * python/py-framefilter.c: Do not include py-ref.h.
9505         * python/py-function.c: Do not include py-ref.h.
9506         * python/py-infevents.c: Do not include py-ref.h.
9507         * python/py-linetable.c: Do not include py-ref.h.
9508         * python/py-objfile.c: Do not include py-ref.h.
9509         * python/py-param.c: Do not include py-ref.h.
9510         * python/py-prettyprint.c: Do not include py-ref.h.
9511         * python/py-progspace.c: Do not include py-ref.h.
9512         * python/py-symbol.c: Do not include py-ref.h.
9513         * python/py-symtab.c: Do not include py-ref.h.
9514         * python/py-type.c: Do not include py-ref.h.
9515         * python/py-unwind.c: Do not include py-ref.h.
9516         * python/py-utils.c: Do not include py-ref.h.
9517         * python/py-value.c: Do not include py-ref.h.
9518         * python/py-varobj.c: Do not include py-ref.h.
9519         * python/py-xmethods.c: Do not include py-ref.h.
9520         * python/python.c: Do not include py-ref.h.
9521         * varobj.c: Do not include py-ref.h.
9522
9523 2019-01-22  Tom Tromey  <tom@tromey.com>
9524
9525         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9526         keyword for bcache.
9527
9528 2019-01-22  Tom Tromey  <tom@tromey.com>
9529
9530         * compile/compile-cplus-types.c: Remove a comment by #include.
9531
9532 2019-01-22  Tom Tromey  <tom@tromey.com>
9533
9534         * compile/gcc-c-plugin.h: Include compile-internal.h.
9535
9536 2019-01-22  Tom Tromey  <tom@tromey.com>
9537
9538         * stabsread.c (EXTERN): Do not define.
9539         (symnum, next_symbol_text_func, processing_gcc_compilation)
9540         (within_function, global_sym_chain, global_stabs)
9541         (previous_stab_code, this_object_header_files)
9542         (n_this_object_header_files)
9543         (n_allocated_this_object_header_files): Define.
9544         * stabsread.h (EXTERN): Never define.  Use "extern".
9545
9546 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9547
9548         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9549         history_value.
9550
9551 2019-01-21  Tom Tromey  <tom@tromey.com>
9552
9553         * ui-out.c: Fix includes.
9554         * tui/tui-source.c: Fix includes.
9555         * target.c: Fix includes.
9556         * remote.c: Fix includes.
9557         * regcache.c: Fix includes.
9558         * python/py-block.c: Fix includes.
9559         * printcmd.c: Fix includes.
9560         * or1k-tdep.c: Fix includes.
9561         * mi/mi-main.c: Fix includes.
9562         * m32r-tdep.c: Fix includes.
9563         * csky-tdep.c: Fix includes.
9564         * compile/compile-cplus-types.c: Fix includes.
9565         * cli/cli-interp.c: Fix includes.
9566
9567 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9568
9569         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9570         for padding.
9571
9572 2019-01-16  Tom Tromey  <tom@tromey.com>
9573
9574         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9575         earlier.
9576         (struct objfile) <msymbols_range>: Move from top level.
9577         <msymbols>: New method.
9578         (class objfile_msymbols): Remove.
9579         * symtab.c (default_collect_symbol_completion_matches_break_on):
9580         Update.
9581         * symmisc.c (dump_msymbols): Update.
9582         * stabsread.c (scan_file_globals): Update.
9583         * objc-lang.c (info_selectors_command, info_classes_command)
9584         (find_methods): Update.
9585         * minsyms.c (find_solib_trampoline_target): Update.
9586         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9587         * coffread.c (coff_symfile_read): Update.
9588         * ada-lang.c (ada_lookup_simple_minsym)
9589         (ada_collect_symbol_completion_matches): Update.
9590
9591 2019-01-16  Tom Tromey  <tom@tromey.com>
9592
9593         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9594         type.  Remove no-argument constructor.
9595         <iterator::operator++>: Simplify.
9596         <begin>: Update.
9597         <end>: Use minimal_symbol_count.
9598
9599 2019-01-16  Tom Tromey  <tom@tromey.com>
9600
9601         * objfiles.h (struct objfile) <psymtabs>: New method.
9602         (class objfile_psymtabs): Remove.
9603         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9604         typedef.
9605         <range>: New method.
9606         (require_partial_symbols): Change return type.
9607         * psymtab.c (require_partial_symbols)
9608         (psym_expand_symtabs_matching): Update.
9609         * mdebugread.c (parse_partial_symbols): Update.
9610         * dbxread.c (dbx_end_psymtab): Update.
9611
9612 2019-01-15  Tom Tromey  <tom@tromey.com>
9613
9614         * symtab.c (lookup_objfile_from_block)
9615         (lookup_symbol_in_objfile_symtabs)
9616         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9617         (find_line_symtab, info_sources_command)
9618         (default_collect_symbol_completion_matches_break_on)
9619         (make_source_files_completion_list): Update.
9620         * symmisc.c (print_objfile_statistics, dump_objfile)
9621         (maintenance_print_symbols, maintenance_info_symtabs)
9622         (maintenance_check_symtabs, maintenance_info_line_tables):
9623         Update.
9624         * source.c (select_source_symtab)
9625         (forget_cached_source_info_for_objfile): Update.
9626         * objfiles.h (class objfile_compunits): Remove.
9627         (struct objfile) <compunits_range>: New typedef.
9628         (compunits): New method.
9629         * objfiles.c (objfile_relocate1): Update.
9630         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9631         * maint.c (count_symtabs_and_blocks): Update.
9632         * linespec.c (iterate_over_all_matching_symtabs): Update.
9633         * cp-support.c (add_symbol_overload_list_qualified): Update.
9634         * coffread.c (coff_symtab_read): Update.
9635         * ada-lang.c (add_nonlocal_symbols)
9636         (ada_collect_symbol_completion_matches)
9637         (ada_add_global_exceptions): Update.
9638
9639 2019-01-15  Tom Tromey  <tom@tromey.com>
9640
9641         * progspace.h (program_space) <objfiles_safe_range>: New
9642         typedef.
9643         <objfiles_safe>: New method.
9644         * objfiles.h (class all_objfiles_safe): Remove.
9645         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9646         * jit.c (jit_inferior_exit_hook): Update.
9647
9648 2019-01-17  Tom Tromey  <tom@tromey.com>
9649
9650         * progspace.h (program_space) <objfiles_range>: New typedef.
9651         <objfiles>: New method.
9652         <objfiles_head>: Rename from objfiles.
9653         (object_files): Update.
9654         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9655         * guile/scm-pretty-print.c
9656         (ppscm_find_pretty_printer_from_objfiles): Update.
9657         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9658         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9659         Update.
9660         * python/py-progspace.c (pspy_get_objfiles): Update.
9661         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9662         Update.
9663         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9664         (objfpy_lookup_objfile_by_build_id): Update.
9665         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9666         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9667         Update.
9668         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9669         (expand_symtab_containing_pc, lookup_objfile_from_block)
9670         (lookup_static_symbol, basic_lookup_transparent_type)
9671         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9672         (find_line_symtab, info_sources_command)
9673         (default_collect_symbol_completion_matches_break_on)
9674         (make_source_files_completion_list, find_main_name): Update.
9675         * symmisc.c (print_symbol_bcache_statistics)
9676         (print_objfile_statistics, maintenance_print_symbols)
9677         (maintenance_print_msymbols, maintenance_print_objfiles)
9678         (maintenance_info_symtabs, maintenance_check_symtabs)
9679         (maintenance_expand_symtabs, maintenance_info_line_tables):
9680         Update.
9681         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9682         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9683         (map_overlay_command, unmap_overlay_command)
9684         (simple_overlay_update, expand_symtabs_matching)
9685         (map_symbol_filenames): Update.
9686         * symfile-debug.c (set_debug_symfile): Update.
9687         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9688         Update.
9689         * source.c (select_source_symtab, forget_cached_source_info):
9690         Update.
9691         * solib.c (solib_read_symbols): Update.
9692         * solib-spu.c (append_ocl_sos): Update.
9693         * psymtab.c (maintenance_print_psymbols)
9694         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9695         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9696         * printcmd.c (info_symbol_command): Update.
9697         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9698         Update.
9699         * objfiles.h (class all_objfiles): Remove.
9700         * objfiles.c (have_partial_symbols, have_full_symbols)
9701         (have_minimal_symbols, qsort_cmp, update_section_map)
9702         (shared_objfile_contains_address_p)
9703         (default_iterate_over_objfiles_in_search_order): Update.
9704         * objc-lang.c (info_selectors_command, info_classes_command)
9705         (find_methods): Update.
9706         * minsyms.c (find_solib_trampoline_target): Update.
9707         * maint.c (maintenance_info_sections)
9708         (maintenance_translate_address, count_symtabs_and_blocks):
9709         Update.
9710         * main.c (captured_main_1): Update.
9711         * linux-thread-db.c (try_thread_db_load_from_pdir)
9712         (has_libpthread): Update.
9713         * linespec.c (iterate_over_all_matching_symtabs)
9714         (search_minsyms_for_name): Update.
9715         * jit.c (jit_find_objf_with_entry_addr): Update.
9716         * hppa-tdep.c (find_unwind_entry)
9717         (hppa_lookup_stub_minimal_symbol): Update.
9718         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9719         Update.
9720         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9721         (elf_gnu_ifunc_resolve_by_got): Update.
9722         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9723         * dwarf-index-write.c (save_gdb_index_command): Update.
9724         * cp-support.c (add_symbol_overload_list_qualified): Update.
9725         * breakpoint.c (create_overlay_event_breakpoint)
9726         (create_longjmp_master_breakpoint)
9727         (create_std_terminate_master_breakpoint)
9728         (create_exception_master_breakpoint): Update.
9729         * blockframe.c (find_pc_partial_function): Update.
9730         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9731         (ada_collect_symbol_completion_matches)
9732         (ada_add_global_exceptions): Update.
9733
9734 2019-01-17  Tom Tromey  <tom@tromey.com>
9735
9736         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9737         declare VEC.
9738         (solib_target_parse_libraries): Change return type.
9739         (library_list_start_segment, library_list_start_section)
9740         (library_list_end_library, library_list_start_library); Update.
9741         (solib_target_free_library_list): Remove.
9742         (solib_target_parse_libraries): Remove cleanup.  Change return
9743         type.
9744         (solib_target_current_sos): Update.
9745
9746 2019-01-17  Tom Tromey  <tromey@bapiya>
9747
9748         * valprint.c: Replace "the the" with "the".
9749         * symtab.c: Replace "the the" with "the".
9750         * solib.c: Replace "the the" with "the".
9751         * solib-dsbt.c: Replace "the the" with "the".
9752         * linespec.c: Replace "the the" with "the".
9753         * dwarf2loc.h: Replace "the the" with "the".
9754         * amd64-windows-tdep.c: Replace "the the" with "the".
9755         * aarch64-tdep.c: Replace "the the" with "the".
9756
9757 2019-01-16  Keith Seitz  <keiths@redhat.com>
9758
9759         PR gdb/23773
9760         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9761         <builder>: Rename to ..
9762         <m_builder>: ... this and make private.
9763         (dwarf2_cu::get_builder): New method.  Change all users of
9764         `builder' to use this method.
9765         (dwarf2_start_symtab): Move to ...
9766         (dwarf2_cu::start_symtab): ... here.  Update all callers
9767         (setup_type_unit_groups): Move to ...
9768         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9769         callers.
9770         (dwarf2_cu::reset_builder): New method.
9771         (process_full_compunit, process_full_type_unit): Use
9772         dwarf2_cu::reset_builder.
9773         (follow_die_offset): Record the ancestor CU if it is different
9774         from the followed DIE's CU.
9775         (follow_die_sig_1): Likewise.
9776
9777 2019-01-15  Tom Tromey  <tom@tromey.com>
9778
9779         * remote.c (class remote_state) <buf>: Now a char_vector.
9780         <buf_size>: Remove.
9781         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9782         parameter.
9783         (remote_target::getpkt_or_notif_sane_1)
9784         (remote_target::getpkt_sane)
9785         (remote_target::getpkt_or_notif_sane): Likewise.
9786         (class remote_target) <putpkt>: New overload.
9787         (remote_target::read_frame): Change type of "buf_p".  Remove
9788         sizeof_p parameter.
9789         (packet_ok): New overload.
9790         (packet_check_result): New overload.
9791         Update all uses.
9792
9793 2019-01-14  Tom Tromey  <tom@tromey.com>
9794
9795         * remote-notif.c (handle_notification, remote_notif_ack)
9796         (remote_notif_parse): Make "buf" const.
9797         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9798         const.
9799         (remote_notif_parse, remote_notif_ack, handle_notification):
9800         Likewise.
9801         * remote.c (remote_notif_stop_parse): Make "buf" const.
9802         (remote_target::remote_parse_stop_reply): Make "buf" const.
9803         (remote_notif_stop_ack): Make "buf" const.
9804
9805 2019-01-14  Tom Tromey  <tom@tromey.com>
9806
9807         * remote.c (remote_console_output): Make parameter const.
9808
9809 2019-01-14  Tom Tromey  <tom@tromey.com>
9810
9811         * target-debug.h (target_debug_print_signals): Constify.
9812         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9813         * procfs.c (procfs_target::pass_signals): Update.
9814         * linux-nat.c (linux_nat_target::pass_signals): Update.
9815         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9816         * target-delegates.c: Rebuild.
9817         * remote.c (remote_target::program_signals): Update.
9818         (remote_target::pass_signals): Update.
9819         * target.c (target_pass_signals): Constify argument.
9820         (target_program_signals): Likewise.
9821         * target.h (struct target_ops) <pass_signals, program_signals>:
9822         Constify argument.
9823         (target_pass_signals, target_program_signals): Constify argument.
9824
9825 2019-01-14  Tom Tromey  <tom@tromey.com>
9826
9827         PR tui/28819:
9828         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9829
9830 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9831
9832         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9833         field.
9834         * rs6000-tdep.c: Include reggroups.h.
9835         (IS_V_ALIAS_PSEUDOREG): Define.
9836         (rs6000_register_name): Return names for the "vX" aliases.
9837         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9838         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9839         aliases.  Call default_register_reggroup_p for all other
9840         pseudo-registers.
9841         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9842         New functions.
9843         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9844         Handle "vX" aliases.
9845         (v_alias_pseudo_register_collect): New function.
9846         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9847         (rs6000_gdbarch_init): Initialize "vX" aliases as
9848         pseudo-registers.  Restore registration of
9849         rs6000_pseudo_register_reggroup_p with
9850         set_tdesc_pseudo_register_reggroup_p.
9851
9852 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9853
9854         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9855         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9856         set_gdbarch_num_pseudo_regs.
9857
9858 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9859
9860         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9861         Remove arg prefixname, add do_set and do_show.
9862         Add member functions set_list and show_list.
9863         * cli/cli-style.c (class cli_style_option): Update accordingly.
9864         (style_set_list): Move to file scope.
9865         (style_show_list): Likewise.
9866         (set_style): Call help_list.
9867         (show_style): Call cmd_show_list.
9868         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9869         Update to use the new macro.
9870
9871 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9872
9873         * ada-lang.c (_initialize_ada_language): Expand the help text
9874         for the "catch exception" command.
9875
9876 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9877
9878         * symtab.c (matching_obj_sections): Initialize obj,
9879         declare it closer to its usage.
9880
9881 2019-01-10  Tom Tromey  <tom@tromey.com>
9882
9883         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9884         (basic_inf_threads_range): Remove.
9885         (inf_threads_range, inf_non_exited_threads_range)
9886         (safe_inf_threads_range): Use next_adapter.
9887
9888 2019-01-10  Keith Seitz  <keiths@redhat.com>
9889
9890         PR gdb/23712
9891         PR symtab/23010
9892         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9893         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9894
9895 2019-01-10  Keith Seitz  <keiths@redhat.com>
9896
9897         PR gdb/23712
9898         PR symtab/23010
9899         * dictionary.c (pending_to_vector): Remove.
9900         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9901         Remove _1 suffix, replacing functions of the same name.  Update
9902         all callers.
9903         (dict_create_hashed, dict_create_hashed_expandable)
9904         (dict_create_linear, dict_create_linear_expandable, dict_free)
9905         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9906         Make functions static.
9907
9908 2019-01-10  Keith Seitz  <keiths@redhat.com>
9909
9910         PR gdb/23712
9911         PR symtab/23010
9912         * dictionary.h (struct dictionary): Replace declaration with
9913         multidictionary.
9914         (dict_create_hashed, dict_create_hashed_expandable)
9915         (dict_create_linear, dict_create_linear_expandable)
9916         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9917         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9918         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9919         taking multidictionary argument.
9920         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9921         * block.h (struct block) <dict>: Change to multidictionary
9922         and rename `multidict'.
9923         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9924         symmisc.c: Update all dictionary references to multidictionary.
9925
9926 2019-01-10  Keith Seitz  <keiths@redhat.com>
9927
9928         PR gdb/23712
9929         PR symtab/23010
9930         * dictionary.c: Include unordered_map.
9931         (pending_to_vector): New function.
9932         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9933         Rewrite the non-"_1" functions to take vector instead
9934         of linked list.
9935         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9936         "new" _1 versions of the same name.
9937         (multidictionary): Define.
9938         (std::hash<enum language): New definition.
9939         (collate_pending_symbols_by_language, mdict_create_hashed)
9940         (mdict_create_hashed_expandable, mdict_create_linear)
9941         (mdict_create_linear_expandable, mdict_free)
9942         (find_language_dictionary, create_new_language_dictionary)
9943         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9944         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9945         (mdict_size, mdict_empty): New functions.
9946         * dictionary.h (mdict_iterator): Define.
9947
9948 2019-01-10  Pedro Alves  <palves@redhat.com>
9949
9950         * breakpoint.c (read_uploaded_action)
9951         (create_tracepoint_from_upload): Adjust to use
9952         gdb::unique_xmalloc_ptr.
9953         * ctf.c (ctf_write_uploaded_tp):
9954         (SET_ARRAY_FIELD): Use emplace_back.
9955         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9956         * tracefile-tfile.c (tfile_write_uploaded_tp):
9957         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9958         gdb::unique_xmalloc_ptr.
9959         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9960         at_string, cond_string, cmd_strings>: Replace char pointers
9961         with gdb::unique_xmalloc_ptr.
9962
9963 2019-01-10  Pedro Alves  <palves@redhat.com>
9964
9965         * solib-target.c (library_list_start_library): Don't xstrdup name.
9966
9967 2019-01-10  Pedro Alves  <palves@redhat.com>
9968
9969         * mdebugread.c (parse_partial_symbols): Use
9970         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9971
9972 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9973
9974         * linux-fork.c (scoped_switch_fork_info)
9975         <~scoped_switch_fork_info>: Fix incorrect variable name.
9976
9977 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9978
9979         * linux-fork.c (scoped_switch_fork_info)
9980         <scoped_switch_fork_info>: Make explicit.
9981         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9982
9983 2019-01-10  Tom Tromey  <tom@tromey.com>
9984
9985         * objfiles.h (objfile::reset_psymtabs): Update.
9986         * objfiles.c (objfile::objfile): Update.
9987         * psymtab.h (psymtab_storage::obstack): Update.
9988         (psymtab_storage::m_obstack): Use gdb::optional.
9989         (class psymtab_storage): Update comment.  Remove objfile
9990         parameter.
9991         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9992
9993 2019-01-10  Tom Tromey  <tom@tromey.com>
9994
9995         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9996         <free_psymtabs>: Now private.
9997         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9998         (allocate_psymtab): Use new method.
9999
10000 2019-01-10  Tom Tromey  <tom@tromey.com>
10001
10002         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10003         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10004         * mdebugread.c (parse_partial_symbols): Use
10005         allocate_dependencies.
10006         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10007         allocate_dependencies.
10008         (process_psymtab_comp_unit_reader)
10009         (build_type_psymtab_dependencies): Likewise.
10010         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10011
10012 2019-01-10  Tom Tromey  <tom@tromey.com>
10013
10014         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10015         PSYMBOL_SET_LANGUAGE.
10016         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10017
10018 2019-01-10  Tom Tromey  <tom@tromey.com>
10019
10020         * psymtab.h (psymtab_storage::obstack): New method.
10021         <m_obstack>: Rename from obstack; now private.
10022         * psymtab.c (psymtab_storage): Update.
10023         * dwarf2read.c (create_addrmap_from_index)
10024         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10025         Update.
10026
10027 2019-01-10  Tom Tromey  <tom@tromey.com>
10028
10029         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10030         * objfiles.h (objfile::reset_psymtabs): New method.
10031
10032 2019-01-10  Tom Tromey  <tom@tromey.com>
10033
10034         * symmisc.c (print_symbol_bcache_statistics): Update.
10035         (print_objfile_statistics): Update.
10036         * symfile.c (reread_symbols): Update.
10037         * psymtab.h (class psymtab_storage): New.
10038         * psymtab.c (psymtab_storage): New constructor.
10039         (~psymtab_storage): New destructor.
10040         (require_partial_symbols): Update.
10041         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10042         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10043         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10044         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10045         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10046         (start_psymtab_common, end_psymtab_common)
10047         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10048         (allocate_psymtab): Update.
10049         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10050         Update.
10051         (dump_psymtab_addrmap, maintenance_print_psymbols)
10052         (maintenance_check_psymtabs): Update.
10053         (class objfile_psymtabs): Move to objfiles.h.
10054         * psympriv.h (discard_psymtab): Now inline.
10055         (psymtab_discarder::psymtab_discarder): Update.
10056         (psymtab_discarder::~psymtab_discarder): Update.
10057         (ALL_OBJFILE_PSYMTABS): Rewrite.
10058         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10059         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10060         Remove fields.
10061         <partial_symtabs>: New field.
10062         (class objfile_psymtabs): Move from psymtab.h.  Update.
10063         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10064         psymbol_cache.
10065         (objfile::~objfile): Don't destroy psymbol_cache.
10066         * mdebugread.c (parse_partial_symbols): Update.
10067         * dwarf2read.c (create_addrmap_from_index)
10068         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10069         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10070         (add_partial_subprogram, dwarf2_ranges_read): Update.
10071         * dwarf-index-write.c (write_address_map)
10072         (write_one_signatured_type, recursively_write_psymbols)
10073         (class debug_names, class debug_names, write_psymtabs_to_index):
10074         Update.
10075
10076 2019-01-10  Tom Tromey  <tom@tromey.com>
10077
10078         * symtab.h (SYMBOL_SET_NAMES): Update.
10079         (symbol_set_names): Update.
10080         (MSYMBOL_SET_NAMES): Update.
10081         * symtab.c (symbol_set_names): Change argument to be an
10082         objfile_per_bfd_storage.
10083         * psymtab.c (add_psymbol_to_bcache): Update.
10084         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10085
10086 2019-01-10  Tom Tromey  <tom@tromey.com>
10087
10088         * symtab.c (create_demangled_names_hash): Change argument to be an
10089         objfile_per_bfd_storage.
10090         (symbol_set_names): Update.
10091
10092 2019-01-10  Tom Tromey  <tom@tromey.com>
10093
10094         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10095         init_psymbol_list.
10096         * psymtab.c (init_psymbol_list): Do nothing if already called.
10097         * psympriv.h (init_psymbol_list): Add comment.
10098         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10099         init_psymbol_list.
10100         * dbxread.c (dbx_symfile_read): Unconditionally call
10101         init_psymbol_list.
10102
10103 2019-01-10  Tom Tromey  <tom@tromey.com>
10104
10105         * xcoffread.c (scan_xcoff_symtab): Update.
10106         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10107         "where".
10108         * mdebugread.c (parse_partial_symbols)
10109         (handle_psymbol_enumerators): Update.
10110         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10111         * dbxread.c (read_dbx_symtab): Update.
10112         * psympriv.h (psymbol_placement): New enum.
10113         (add_psymbol_to_list): Update.
10114
10115 2019-01-10  Tom Tromey  <tom@tromey.com>
10116
10117         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10118         static_psymbols parameters.
10119         (scan_xcoff_symtab): Update.
10120         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10121         static_psymbols parameters.
10122         * psympriv.h (start_psymtab_common): Update.
10123         * mdebugread.c (parse_partial_symbols): Update.
10124         * dwarf2read.c (create_partial_symtab): Update.
10125         * dbxread.c (read_dbx_symtab): Update.
10126         (start_psymtab): Remove global_psymbols and static_psymbols
10127         parameters.
10128
10129 2019-01-10  Tom Tromey  <tom@tromey.com>
10130
10131         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10132         * psymtab.c (allocate_psymtab): Add comment.
10133         * psympriv.h (allocate_psymtab): Add comment.
10134         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10135         initializations.
10136         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10137
10138 2019-01-10  Tom Tromey  <tom@tromey.com>
10139
10140         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10141         Don't declare.
10142         * mipsread.c: Include mdebugread.h.
10143         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10144         Declare.
10145         * elfread.c: Include mdebugread.h.
10146
10147 2019-01-09  Tom Tromey  <tom@tromey.com>
10148
10149         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10150         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10151         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10152         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10153         (psym_lookup_symbol, psym_find_last_source_symtab)
10154         (psym_forget_cached_source_info, psym_print_stats)
10155         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10156         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10157         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10158         (psym_find_compunit_symtab_by_address)
10159         (maintenance_print_psymbols, maintenance_info_psymtabs)
10160         (maintenance_check_psymtabs): Use ranged for.
10161         * psymtab.h (class objfile_psymtabs): New.
10162         (require_partial_symbols): Return objfile_psymtabs.
10163         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10164
10165 2019-01-09  Tom Tromey  <tom@tromey.com>
10166
10167         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10168         (find_pc_mapped_section, list_overlays_command)
10169         (map_overlay_command, unmap_overlay_command)
10170         (simple_overlay_update): Use all_objfiles.
10171         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10172         * printcmd.c (info_symbol_command): Use all_objfiles.
10173         * objfiles.h (ALL_OBJSECTIONS): Remove.
10174         * maint.c (maintenance_translate_address): Use all_objfiles.
10175         * gcore.c (gcore_create_callback): Use all_objfiles.
10176         (objfile_find_memory_regions): Likewise.
10177
10178 2019-01-09  Tom Tromey  <tom@tromey.com>
10179
10180         * symtab.c (find_line_symtab, info_sources_command)
10181         (make_source_files_completion_list): Use objfile_compunits.
10182         * source.c (select_source_symtab): Use objfile_compunits.
10183         * objfiles.h (struct objfile): Update comment.
10184         (ALL_OBJFILES): Remove.
10185         (ALL_FILETABS): Remove.
10186         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10187         objfile_compunits.
10188
10189 2019-01-09  Tom Tromey  <tom@tromey.com>
10190
10191         * symmisc.c (print_objfile_statistics, dump_objfile)
10192         (maintenance_print_symbols): Use compunit_filetabs.
10193         * source.c (forget_cached_source_info_for_objfile): Use
10194         compunit_filetabs.
10195         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10196         (ALL_FILETABS): Use compunit_filetabs.
10197         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10198         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10199
10200 2019-01-09  Tom Tromey  <tom@tromey.com>
10201
10202         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10203         (compunit_filetabs): New.
10204         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10205         compunit_filetabs.
10206         (info_sources_command, make_source_files_completion_list): Remove
10207         declaration.
10208         * symmisc.c (print_objfile_statistics, dump_objfile)
10209         (maintenance_print_symbols): Remove declaration.
10210         (maintenance_info_symtabs): Use compunit_filetabs.
10211         (maintenance_info_line_tables): Likewise.
10212         * source.c (select_source_symtab): Change local variable name.
10213         (forget_cached_source_info_for_objfile): Remove declaration.
10214         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10215         * objfiles.c (objfile_relocate1): Remove declaration.
10216         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10217         declaration.
10218         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10219         * coffread.c (coff_symtab_read): Remove declaration.
10220         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10221         compunit_filetabs.
10222
10223 2019-01-09  Tom Tromey  <tom@tromey.com>
10224
10225         * symtab.c (lookup_objfile_from_block)
10226         (find_pc_sect_compunit_symtab, search_symbols)
10227         (default_collect_symbol_completion_matches_break_on): Use
10228         objfile_compunits.
10229         * objfiles.h (ALL_COMPUNITS): Remove.
10230         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10231         * cp-support.c (add_symbol_overload_list_qualified): Use
10232         objfile_compunits.
10233         * ada-lang.c (ada_collect_symbol_completion_matches)
10234         (ada_add_global_exceptions): Use objfile_compunits.
10235
10236 2019-01-09  Tom Tromey  <tom@tromey.com>
10237
10238         * source.c (select_source_symtab)
10239         (forget_cached_source_info_for_objfile): Remove declaration.
10240         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10241         declaration.
10242         * maint.c (count_symtabs_and_blocks): Remove declaration.
10243         * cp-support.c (add_symbol_overload_list_qualified): Remove
10244         declaration.
10245         * coffread.c (coff_symtab_read): Remove declaration.
10246         * symtab.c (lookup_symbol_in_objfile_symtabs)
10247         (basic_lookup_transparent_type_1): Use objfile_compunits.
10248         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10249         (info_sources_command, search_symbols)
10250         (default_collect_symbol_completion_matches_break_on)
10251         (make_source_files_completion_list): Remove declaration.
10252         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10253         (ada_collect_symbol_completion_matches)
10254         (ada_add_global_exceptions): Remove declaration.
10255         * linespec.c (iterate_over_all_matching_symtabs): Use
10256         objfile_compunits.
10257         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10258         (class objfile_compunits): New.
10259         (ALL_COMPUNITS): Use objfile_compunits.
10260         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10261         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10262         objfile_compunits.
10263         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10264
10265 2019-01-09  Tom Tromey  <tom@tromey.com>
10266
10267         * symtab.c (search_symbols)
10268         (default_collect_symbol_completion_matches_break_on): Use
10269         objfile_msymbols.
10270         * ada-lang.c (ada_lookup_simple_minsym)
10271         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10272         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10273         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10274         objfile_msymbols.
10275         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10276         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10277         * objc-lang.c (find_methods): Use objfile_msymbols.
10278         (info_selectors_command, info_classes_command): Likewise.
10279         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10280         * objfiles.h (class objfile_msymbols): New.
10281         (ALL_OBJFILE_MSYMBOLS): Remove.
10282         (ALL_MSYMBOLS): Remove.
10283
10284 2019-01-09  Tom Tromey  <tom@tromey.com>
10285
10286         * common/next-iterator.h (next_adapter): Add Iterator template
10287         parameter.
10288         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10289         (class all_objfiles_safe): New.
10290         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10291         * objfiles.c (put_objfile_before): Update comment.
10292         (add_separate_debug_objfile): Likewise.
10293         (free_all_objfiles): Use all_objfiles_safe.
10294         (objfile_purge_solibs): Likewise.
10295
10296 2019-01-09  Tom Tromey  <tom@tromey.com>
10297
10298         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10299         (expand_symtab_containing_pc, lookup_static_symbol)
10300         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10301         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10302         all_objfiles.
10303         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10304         * breakpoint.c (create_overlay_event_breakpoint)
10305         (create_longjmp_master_breakpoint)
10306         (create_std_terminate_master_breakpoint)
10307         (create_exception_master_breakpoint): Use all_objfiles.
10308         * linux-thread-db.c (try_thread_db_load_from_pdir)
10309         (has_libpthread): Use all_objfiles.
10310         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10311         * linespec.c (iterate_over_all_matching_symtabs)
10312         (search_minsyms_for_name): Use all_objfiles.
10313         * maint.c (maintenance_info_sections): Use all_objfiles.
10314         * main.c (captured_main_1): Use all_objfiles.
10315         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10316         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10317         * guile/scm-pretty-print.c
10318         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10319         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10320         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10321         (maintenance_print_msymbols): Use all_objfiles.
10322         * source.c (select_source_symtab): Use all_objfiles.
10323         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10324         * symfile.c (remove_symbol_file_command)
10325         (expand_symtabs_matching, map_symbol_filenames): Use
10326         all_objfiles.
10327         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10328         all_objfiles.
10329         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10330         * objc-lang.c (find_methods): Use all_objfiles.
10331         * objfiles.c (have_partial_symbols, have_full_symbols)
10332         (have_minimal_symbols, qsort_cmp)
10333         (default_iterate_over_objfiles_in_search_order): Use
10334         all_objfiles.
10335         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10336         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10337         (maintenance_check_psymtabs): Use all_objfiles.
10338         (ALL_PSYMTABS): Remove.
10339         * compile/compile-object-run.c (do_module_cleanup): Use
10340         all_objfiles.
10341         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10342         * cp-support.c (add_symbol_overload_list_qualified): Use
10343         all_objfiles.
10344         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10345         Use all_objfiles.
10346         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10347         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10348         all_objfiles.
10349         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10350         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10351         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10352         Uses all_objfiles.
10353         * solib.c (solib_read_symbols): Use all_objfiles
10354
10355 2019-01-09  Tom Tromey  <tom@tromey.com>
10356
10357         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10358         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10359         all_objfiles.
10360         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10361         * symmisc.c (print_symbol_bcache_statistics)
10362         (print_objfile_statistics, maintenance_print_objfiles)
10363         (maintenance_info_symtabs, maintenance_check_symtabs)
10364         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10365         all_objfiles.
10366         * source.c (forget_cached_source_info): Use all_objfiles.
10367         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10368         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10369         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10370         * objfiles.c (update_section_map): Use all_objfiles.
10371         (shared_objfile_contains_address_p): Likewise.
10372         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10373         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10374
10375 2019-01-09  Tom Tromey  <tom@tromey.com>
10376
10377         * common/next-iterator.h: New file.
10378         * objfiles.h (class all_objfiles): New.
10379         (struct objfile_iterator): New.
10380
10381 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10382
10383         * NEWS: Move the description of the changed "frame", "select-frame",
10384          and "info frame" commands to the Changed commands section.
10385
10386 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10387
10388         * gdbtypes.c (check_stub_method_group): Remove handling of old
10389         mangling schemes.
10390         * linespec.c (find_methods): Likewise.
10391         * stabsread.c (read_member_functions): Likewise.
10392         * valops.c (search_struct_method): Likewise.
10393         (value_struct_elt_for_reference): Likewise.
10394         * NEWS: Mention this change.
10395
10396 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10397
10398         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10399         print_source_lines.
10400         * source.c (print_source_lines_base): Update line number check.
10401         (print_source_lines): New function.
10402         (source_lines_range::source_lines_range): New function.
10403         * source.h (class source_lines_range): New class.
10404         (print_source_lines): New declaration.
10405
10406 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10407
10408         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10409
10410 2019-01-08  Tom Tromey  <tom@tromey.com>
10411             Simon Marchi  <simon.marchi@ericsson.com>
10412
10413         PR gdb/24060
10414         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10415         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10416         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10417         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10418         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10419         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10420
10421 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10422
10423         * source.c (select_source_symtab): Move header comment to
10424         declaration in source.h.
10425         (forget_cached_source_info_for_objfile): Likewise.
10426         (forget_cached_source_info): Likewise.
10427         (identify_source_line): Likewise.
10428         * source.h (identify_source_line): Move declaration from symtab.h
10429         and add comment from source.c
10430         (print_source_lines): Likewise.
10431         (forget_cached_source_info_for_objfile): Likewise.
10432         (forget_cached_source_info): Likewise.
10433         (select_source_symtab): Likewise.
10434         (enum print_source_lines_flag): Move definition from symtab.h.
10435         * symtab.h (identify_source_line): Move declaration to source.h.
10436         (print_source_lines): Likewise.
10437         (forget_cached_source_info_for_objfile): Likewise.
10438         (forget_cached_source_info): Likewise.
10439         (select_source_symtab): Likewise.
10440         (enum print_source_lines_flag): Move definition to source.h.
10441         * tui/tui-hooks.c: Add 'source.h' include.
10442
10443 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10444
10445         * source.c (print_source_lines_base): Handle requests to print
10446         reverse line number sequences, and guard against empty lines
10447         string.
10448
10449 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10450
10451         * source.c (print_source_lines_base): Fix skip of '\r' if next
10452         character is '\n'.
10453
10454 2019-01-06  Tom Tromey  <tom@tromey.com>
10455
10456         * c-exp.y (struct c_parse_state) <macro_original_text,
10457         expansion_obstack>: New member.
10458         (macro_original_text, expansion_obstack): Remove globals.
10459         (scan_macro_expansion, scanning_macro_expansion)
10460         (finished_macro_expansion): Update.
10461         (scan_macro_cleanup): Remove.
10462         (yylex, c_parse): Update.
10463
10464 2019-01-06  Tom Tromey  <tom@tromey.com>
10465
10466         * c-exp.y (struct c_parse_state) <strings>: New member.
10467         (operator_stoken): Update.
10468
10469 2019-01-06  Tom Tromey  <tom@tromey.com>
10470
10471         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10472         (union type_stack_elt) <typelist_val>: Now a pointer to
10473         std::vector.
10474         (type_stack_cleanup): Don't declare.
10475         (push_typelist): Update.
10476         * parse.c (pop_typelist): Return a std::vector.
10477         (push_typelist): Take a std::vector.
10478         (follow_types): Update.  Do not free args.
10479         (type_stack_cleanup): Remove.
10480         * c-exp.y (struct c_parse_state): New.
10481         (cpstate): New global.
10482         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10483         (nonempty_typelist): Update.
10484         (func_mod): Create a new vector.
10485         (c_parse): Create a c_parse_state.
10486         (check_parameter_typelist): Do not delete params.
10487         (function_method): Update.  Do not delete type_list.
10488
10489 2019-01-06  Tom Tromey  <tom@tromey.com>
10490
10491         PR gdb/28155:
10492         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10493         check_typedef.
10494         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10495         (print_return_value): Likewise.
10496
10497 2019-01-05  Tom Tromey  <tom@tromey.com>
10498
10499         * contrib/cleanup_check.py: Remove.
10500         * contrib/gcc-with-excheck: Remove.
10501         * contrib/exsummary.py: Remove.
10502         * contrib/excheck.py: Remove.
10503
10504 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10505
10506         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10507         NULL. Initialize tpprev to NULL instead of assigning it
10508         to NULL on the next statement.
10509         * windows-nat.c (windows_delete_thread): Remove check for
10510         main_thread_id before printing thread exit notifications.
10511         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10512         Remove thread ID check against main_thread_id.
10513         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10514         windows_delete_thread.
10515         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10516
10517 2019-01-04  Tom Tromey  <tom@tromey.com>
10518
10519         * compile/compile.c (_initialize_compile): Use upper case for
10520         metasyntactic variables.
10521         * symmisc.c (_initialize_symmisc): Use upper case for
10522         metasyntactic variables.
10523         * psymtab.c (_initialize_psymtab): Use upper case for
10524         metasyntactic variables.
10525         * demangle.c (demangle_command): Use upper case for metasyntactic
10526         variables.
10527         (_initialize_demangler): Likewise.
10528         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10529         variables.
10530
10531 2019-01-03  Tom Tromey  <tom@tromey.com>
10532
10533         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10534
10535 2019-01-03  Tom Tromey  <tom@tromey.com>
10536
10537         * python/py-symtab.c (salpy_str): Update.
10538         (struct salpy_sal_object) <symtab>: Now a PyObject.
10539         (salpy_dealloc): Update.
10540         (del_objfile_sal): Use gdbpy_ref.
10541
10542 2019-01-03  Tom Tromey  <tom@tromey.com>
10543
10544         * python/py-type.c (convert_field): Use new_reference.  Return
10545         gdbpy_ref.
10546         (make_fielditem): Return gdbpy_ref.
10547         (typy_fields): Update.
10548         (typy_getitem): Update.
10549         (field_name): Return gdbpy_ref.  Use new_reference.
10550         (typy_iterator_iternext): Update.
10551
10552 2019-01-03  Tom Tromey  <tom@tromey.com>
10553
10554         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10555
10556 2019-01-03  Tom Tromey  <tom@tromey.com>
10557
10558         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10559         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10560         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10561         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10562         (pspy_set_type_printers): Likewise.
10563         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10564         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10565         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10566         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10567         (objfpy_set_type_printers): Likewise.
10568
10569 2019-01-03  Tom Tromey  <tom@tromey.com>
10570
10571         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10572         (gdbpy_print_stack): Use gdbpy_err_fetch.
10573         * python/python-internal.h (class gdbpy_err_fetch): New class.
10574         (class gdbpy_enter) <m_error_type, m_error_value,
10575         m_error_traceback>: Remove.
10576         <m_error>: New member.
10577         (gdbpy_exception_to_string): Don't declare.
10578         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10579         * python/py-value.c (convert_value_from_python): Use
10580         gdbpy_err_fetch.
10581         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10582         gdbpy_exception_to_string.
10583         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10584         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10585         gdbpy_err_fetch.
10586
10587 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10588
10589         * linux-nat.c (delete_lwp_cleanup): Delete.
10590         (struct lwp_deleter): New struct.
10591         (lwp_info_up): New typedef.
10592         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10593         lwp_info_up.
10594
10595 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10596
10597         * linux-fork.c (class scoped_switch_fork_info): New class.
10598         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10599
10600 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10601
10602         * valops.c (find_overload_match): Remove use of null_cleanup, and
10603         calls to do_cleanups.
10604
10605 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10606
10607         * compile/compile-cplus-types.c
10608         (compile_cplus_instance::decl_name): Handle changes to
10609         cp_func_name.
10610         * cp-support.c (cp_func_name): Update header comment, update
10611         return type.
10612         * cp-support.h (cp_func_name): Update return type in declaration.
10613         * valops.c (find_overload_match): Move temp_func local to top
10614         level of function and change its type.  Use temp_func to hold and
10615         delete temporary string obtained from cp_func_name.
10616
10617 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10618
10619         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10620         gdb::char_vector, remove cleanup, and update uses of `msg`.
10621
10622 2019-01-03  Jim Wilson  <jimw@sifive.com>
10623
10624         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10625
10626 2019-01-02  Tom Tromey  <tom@tromey.com>
10627
10628         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10629         (tdesc_parse_xml): Remove cleanups.
10630         * target-descriptions.h (make_cleanup_free_target_description):
10631         Don't declare.
10632         (target_desc_deleter): New struct.
10633         (target_desc_up): New typedef.
10634         * target-descriptions.c (target_desc_deleter::operator()): Rename
10635         from free_target_description.
10636         (make_cleanup_free_target_description): Remove.
10637
10638 2019-01-02  Tom Tromey  <tom@tromey.com>
10639
10640         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10641         constructor, destructor.
10642         (linespec_parser): Remove typedef.
10643         (~linespec_parser): Rename from linespec_parser_delete.
10644         (linespec_lex_to_end, linespec_complete_label)
10645         (linespec_complete): Update.
10646         (decode_line_full): Remove cleanups.
10647         (decode_line_1): Update.
10648
10649 2019-01-02  Tom Tromey  <tom@tromey.com>
10650
10651         * python/python-internal.h (inferior_to_inferior_object): Change
10652         return type.
10653         * python/py-exitedevent.c (create_exited_event_object): Update.
10654         * python/py-inferior.c (inferior_to_inferior_object): Return
10655         gdbpy_ref.
10656         (python_new_inferior, python_inferior_deleted)
10657         (thread_to_thread_object, delete_thread_object)
10658         (build_inferior_list, gdbpy_selected_inferior): Update.
10659         * python/py-infthread.c (create_thread_object): Update.  Also fail
10660         if inferior_to_inferior_object fails.
10661
10662 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10663
10664         * inferior.h (class inferior) <displaced_step_state>: New field.
10665         * infrun.h (struct displaced_step_state): Move here from
10666         infrun.c.  Initialize fields, add constructor.
10667         <inf>: Remove field.
10668         <reset>: New method.
10669         * infrun.c (struct displaced_step_inferior_state): Move to
10670         infrun.h.
10671         (displaced_step_inferior_states): Remove.
10672         (get_displaced_stepping_state): Adust.
10673         (displaced_step_in_progress_any_inferior): Adjust.
10674         (displaced_step_in_progress_thread): Adjust.
10675         (displaced_step_in_progress): Adjust.
10676         (add_displaced_stepping_state): Remove.
10677         (get_displaced_step_closure_by_addr): Adjust.
10678         (remove_displaced_stepping_state): Remove.
10679         (infrun_inferior_exit): Call displaced_step_state.reset.
10680         (use_displaced_stepping): Don't check for NULL.
10681         (displaced_step_prepare_throw): Call
10682         get_displaced_stepping_state.
10683         (displaced_step_fixup): Don't check for NULL.
10684         (prepare_for_detach): Don't check for NULL.
10685
10686 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10687
10688         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10689          in case of call that did not complete.
10690
10691 2019-01-02  Andrey Utkin  <autkin@undo.io>
10692
10693         * symfile.c (find_separate_debug_file): Fix search of debug files for
10694         remote debuggee.
10695
10696 2019-01-02  Tom Tromey  <tom@tromey.com>
10697
10698         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10699         indentation.
10700         * python/py-frame.c (frapy_older): Remove cast.
10701         (frapy_newer): Likewise.
10702         * python/py-breakpoint.c (local_setattro): Remove cast.
10703         * python/py-arch.c (archpy_name): Remove local variable.
10704         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10705
10706 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10707
10708         * unittests/basic_string_view/element_access/char/empty.cc:
10709         Fix year range in copyright header.
10710
10711 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10712
10713         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10714         Delete.
10715         <operator==>: Update with for removed field.
10716         <hash>: Likewise.
10717         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10718         <isa_features>: ...this.
10719         <abi_features>: New field.
10720         (riscv_isa_flen): Update comment.
10721         (riscv_abi_xlen): New declaration.
10722         (riscv_abi_flen): New declaration.
10723         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10724         isa_features.
10725         (riscv_abi_xlen): New function.
10726         (riscv_isa_flen): Update to get answer from isa_features.
10727         (riscv_abi_flen): New function.
10728         (riscv_has_fp_abi): Update to get answer from abi_features.
10729         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10730         xlen and flen.
10731         (riscv_call_info) <xlen, flen>: Update comment.
10732         (riscv_call_arg_struct): Remove invalid assertions
10733         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10734         is removed.
10735         (riscv_gdbarch_init): Gather isa features and abi features
10736         separately, ensure both match on the gdbarch when reusing an old
10737         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10738         a target with 64-bit float hardware.
10739
10740 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10741
10742         * source.c (search_command_helper): Stop reverse search
10743         when line 1 has been searched.
10744
10745 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10746
10747         * record-full.c (record_full_base_target::close): Rewrite
10748         record_full_core_buf_list free logic.
10749
10750 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10751
10752         * break-catch-syscall.c (print_one_catch_syscall): xfree
10753         the last text.
10754
10755 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10756
10757         * top.c (print_gdb_version): Update Copyright year in version
10758         message.
10759
10760 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10761
10762         Update copyright year range in all GDB files.
10763
10764 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10765
10766         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10767
10768 For older changes see ChangeLog-2018.
10769 \f
10770 Local Variables:
10771 mode: change-log
10772 left-margin: 8
10773 fill-column: 74
10774 version-control: never
10775 coding: utf-8
10776 End:
10777