gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
   4         (rustyylex, rust_lex_test_init, rust_lex_test_one)
   5         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
   6         * parser-defs.h (paren_depth): Don't declare.
   7         * parse.c (paren_depth): Remove global.
   8         (parse_exp_in_context): Update.
   9         * p-exp.y (paren_depth): New global.
  10         (pascal_parse): Initialize it.
  11         * m2-exp.y (paren_depth): New global.
  12         (m2_parse): Initialize it.
  13         * go-exp.y (paren_depth): New global.
  14         (go_parse): Initialize it.
  15         * f-exp.y (paren_depth): New global.
  16         (f_parse): Initialize it.
  17         * d-exp.y (paren_depth): New global.
  18         (d_parse): Initialize it.
  19         * c-exp.y (paren_depth): New global.
  20         (c_parse): Initialize it.
  21         * ada-lex.l (paren_depth): New global.
  22         (lexer_init): Initialize it.
  23
  24 2019-04-04  Tom Tromey  <tom@tromey.com>
  25
  26         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
  27         (rust_parser::convert_ast_to_type)
  28         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
  29         * parser-defs.h (struct parser_state) <parser_state>: Add
  30         parameters.  Initialize new members.
  31         <expression_context_block, expression_context_pc>: New members.
  32         * parse.c (expression_context_block, expression_context_pc):
  33         Remove globals.
  34         (parse_exp_in_context): Update.
  35         * p-exp.y: Update all rules.
  36         (yylex): Update.
  37         * m2-exp.y: Update all rules.
  38         (yylex): Update.
  39         * go-exp.y (yylex): Update.
  40         * f-exp.y (yylex): Update.
  41         * d-exp.y: Update all rules.
  42         (yylex): Update.
  43         * c-exp.y: Update all rules.
  44         (lex_one_token, classify_name, yylex, c_parse): Update.
  45         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
  46
  47 2019-04-04  Tom Tromey  <tom@tromey.com>
  48
  49         * gdbarch.h, gdbarch.c: Rebuild.
  50         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
  51         * stap-probe.h:
  52         (struct stap_parse_info): Replace "parser_state" with
  53         "expr_builder".
  54         * parser-defs.h (struct expr_builder): Rename from "parser_state".
  55         (parser_state): New class.
  56         * parse.c (expr_builder): Rename.
  57         (expr_builder::release): Rename.
  58         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
  59         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
  60         (write_exp_elt_longcst, write_exp_elt_floatcst)
  61         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
  62         (write_exp_string_vector, write_exp_bitstring)
  63         (write_exp_msymbol, mark_struct_expression)
  64         (write_dollar_variable)
  65         (insert_type_address_space, increase_expout_size): Replace
  66         "parser_state" with "expr_builder".
  67         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
  68         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
  69         "parser_state" with "expr_builder".
  70
  71 2019-04-04  Tom Tromey  <tom@tromey.com>
  72
  73         * rust-exp.y: Replace "parse_language" with method call.
  74         * p-exp.y:
  75         (yylex): Replace "parse_language" with method call.
  76         * m2-exp.y:
  77         (yylex): Replace "parse_language" with method call.
  78         * go-exp.y (classify_name): Replace "parse_language" with method
  79         call.
  80         * f-exp.y (yylex): Replace "parse_language" with method call.
  81         * d-exp.y (lex_one_token): Replace "parse_language" with method
  82         call.
  83         * c-exp.y:
  84         (lex_one_token, classify_name, yylex): Replace "parse_language"
  85         with method call.
  86         * ada-exp.y (find_primitive_type, type_char)
  87         (type_system_address): Replace "parse_language" with method call.
  88
  89 2019-04-04  Tom Tromey  <tom@tromey.com>
  90
  91         * rust-exp.y: Replace "parse_gdbarch" with method call.
  92         * parse.c (write_dollar_variable, insert_type_address_space):
  93         Replace "parse_gdbarch" with method call.
  94         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
  95         call.
  96         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
  97         call.
  98         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
  99         "parse_gdbarch" with method call.
 100         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
 101         with method call.
 102         * f-exp.y (parse_type, parse_f_type, yylex): Replace
 103         "parse_gdbarch" with method call.
 104         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
 105         "parse_gdbarch" with method call.
 106         * c-exp.y (parse_type, parse_number, classify_name): Replace
 107         "parse_gdbarch" with method call.
 108         * ada-lex.l: Replace "parse_gdbarch" with method call.
 109         * ada-exp.y (parse_type, find_primitive_type, type_char)
 110         (type_system_address): Replace "parse_gdbarch" with method call.
 111
 112 2019-04-04  Tom Tromey  <tom@tromey.com>
 113
 114         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
 115         * stap-probe.c (stap_parse_argument): Update.
 116         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
 117         initial_size parameter.
 118         * rust-exp.y (rust_lex_tests): Update.
 119         * parse.c (parser_state): Update.
 120         (parse_exp_in_context): Update.
 121         * parser-defs.h (struct parser_state) <parser_state>: Remove
 122         "initial_size" parameter.
 123
 124 2019-04-04  Tom Tromey  <tom@tromey.com>
 125
 126         * parser-defs.h (increase_expout_size): Don't declare.
 127         * parse.c (increase_expout_size): Now static.
 128
 129 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
 130
 131         * gnu-nat.c (gnu_nat_target::wait): Fix
 132         target_waitstatus_to_string call.
 133
 134 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 135
 136         * eval.c (evaluate_subexp_standard): Handle internal functions
 137         during Fortran function call handling.
 138
 139 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 140
 141         * NEWS: Mention new internal functions.
 142         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
 143         (read_base_type): Use dwarf2_init_complex_target_type.
 144         * value.c (creal_internal_fn): New function.
 145         (cimag_internal_fn): New function.
 146         (_initialize_values): Register new internal functions.
 147
 148 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 149
 150         * infrun.c (stop_all_threads): If debug_infrun, always
 151         trace the wait status after wait_one, using
 152         target_waitstatus_to_string and target_pid_to_str.
 153         (handle_inferior_event): Replace various trace of
 154         wait status kind by a single trace.
 155         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
 156         wait status kind image by target_waitstatus_to_string.
 157         * target/waitstatus.c (target_waitstatus_to_string): Fix
 158         obsolete comment.
 159
 160 2019-04-01  Tom Tromey  <tromey@adacore.com>
 161
 162         PR symtab/23331:
 163         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
 164
 165 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 166             Pedro Alves  <palves@redhat.com>
 167
 168         * top.c (quit_force): Call 'finalize_values'.
 169         * value.c (finalize_values): New function.
 170         * value.h (finalize_values): Declare.
 171
 172 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 173
 174         * NEWS: Announce $_gdb_major and $_gdb_minor.
 175
 176         * top.c (init_gdb_version_vars): New function.
 177         (gdb_init): Call init_gdb_version_vars.
 178
 179 2019-03-29  Tom Tromey  <tromey@adacore.com>
 180
 181         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 182         help text.  Remove dead code.
 183
 184 2019-03-29  Keith Seitz  <keiths@redhat.com>
 185
 186         From Siddhesh Poyarekar:
 187         * f-lang.h (f77_get_upperbound): Return LONGEST.
 188         (f77_get_lowerbound): Likewise.
 189         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 190         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 191         print them.
 192         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 193         plongest to format print it.
 194         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 195         (f77_get_upperbound): Likewise.
 196         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 197         LOWER_BOUND to LONGEST.
 198         (f77_create_arrayprint_offset_tbl): Likewise.
 199
 200 2019-03-29  Keith Seitz  <keiths@redhat.com>
 201
 202         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 203         %s/pulongest for TYPE_LENGTH instead of %d in format
 204         strings.
 205         * ada-typerint.c (ada_print_type): Likewise.
 206         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 207         * compile/compile-c-support.c (generate_register_struct): Likewise.
 208         * gdbtypes.c (recursive_dump_type): Likewise.
 209         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 210         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 211         instead of %d in format strings.
 212         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 213         to std::min to ULONGEST.
 214         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 215         instead of %d in format strings.
 216         * tracepoint.c (info_scope_command): Likewise.
 217         * typeprint.c (print_offset_data::update)
 218         (print_offset_data::finish): Likewise.
 219         * xtensa-tdep.c (xtensa_store_return_value)
 220         (xtensa_push_dummy_call): Likewise.
 221
 222 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 223
 224         * windows-nat.c (display_selector): Fixed format specifications
 225         for 64-bit Cygwin.
 226
 227 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 228
 229         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 230
 231 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 232
 233         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 234         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 235         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 236         (nios2_linux_init_abi): Install it.
 237
 238 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 239
 240         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 241
 242 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 243
 244         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 245
 246 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 247             Tom Tromey  <tromey@adacore.com>
 248
 249         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 250
 251 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 252
 253         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 254         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 255         method to compute the bounds of range types. Also print "[evaluated]"
 256         if the bounds' values come from a dynamic evaluation.
 257
 258 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 259
 260         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 261         whitespace when pretty printing is on.
 262
 263 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 264
 265         * ppc-linux-nat.c: Add include.
 266
 267 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 268
 269         * NEWS: Mention AArch64 Pointer Authentication.
 270
 271 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 272
 273         * arm-linux-nat.c: Add include.
 274
 275 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 276
 277         * source-cache.c (source_cache::get_source_lines): Re-read
 278         fullname after calling open_source_file.
 279
 280 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 281
 282         * NEWS: Mention TLS support for FreeBSD.
 283
 284 2019-03-25  Tom Tromey  <tromey@adacore.com>
 285
 286         * minsyms.c (BUNCH_SIZE): Update comment.
 287         (~minimal_symbol_reader): Remove old comment.
 288         (compact_minimal_symbols): Update comment.
 289         (minimal_symbol_reader::install): Remove old comment.  Update
 290         other comments.
 291
 292 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 293
 294         * s390-linux-nat.c: Add include.
 295
 296 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 297
 298         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 299         Call linux_get_hwcap.
 300         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 301         Likewise.
 302         (aarch64_linux_get_hwcap): Remove function.
 303         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 304         declaration.
 305         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 306         linux_get_hwcap.
 307         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 308         * linux-tdep.c (linux_get_hwcap): Add function.
 309         (linux_get_hwcap2): Likewise.
 310         * linux-tdep.h (linux_get_hwcap): Add declaration.
 311         (linux_get_hwcap2): Likewise.
 312         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 313         (ppc_linux_get_hwcap2): Likewise.
 314         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 315         linux_get_hwcap.
 316         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 317         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 318         (ppc_linux_nat_target::read_description): Likewise.
 319         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 320         * s390-linux-nat.c: Likewise.
 321         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 322
 323 2019-03-24  Tom Tromey  <tom@tromey.com>
 324
 325         * ada-lang.c (standard_lookup): Simplify initialization.
 326         (ada_lookup_symbol_nonlocal): Simplify return.
 327         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 328         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 329         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 330         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 331         initialization.
 332         * solib.c (solib_global_lookup): Simplify.
 333         * symtab.c (null_block_symbol): Remove.
 334         (symbol_cache_lookup): Simplify returns.
 335         (lookup_language_this): Simplify returns.
 336         (lookup_symbol_aux): Simplify return.
 337         (lookup_local_symbol): Simplify returns.
 338         (lookup_global_symbol_from_objfile): Simplify return.
 339         (lookup_symbol_in_objfile_symtabs)
 340         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 341         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 342         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 343         * cp-namespace.c (cp_lookup_bare_symbol)
 344         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 345         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 346         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 347         (cp_lookup_symbol_via_imports): Simplify initialization.
 348         (find_symbol_in_baseclass): Likewise.
 349         * symtab.h (null_block_symbol): Remove.
 350         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 351         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 352         (d_lookup_symbol_module): Likewise.
 353         (find_symbol_in_baseclass): Simplify initialization.
 354
 355 2019-03-24  Tom Tromey  <tom@tromey.com>
 356
 357         * expression.h: Don't include symtab.h.
 358         (struct block): Forward declare.
 359
 360 2019-03-24  Tom Tromey  <tom@tromey.com>
 361
 362         * c-exp.y (typebase): Remove casts.
 363         * gdbtypes.c (lookup_unsigned_typename, )
 364         (lookup_signed_typename): Remove cast.
 365         * eval.c (parse_to_comma_and_eval): Remove cast.
 366         * parse.c (write_dollar_variable): Remove cast.
 367         * block.h (struct block) <superblock>: Now const.
 368         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 369         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 370         (map_block): Make "block" const.
 371         * symfile.h (struct quick_symbol_functions)
 372         <map_matching_symbols>: Constify block argument to "callback".
 373         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 374         const.
 375         (find_pc_sect_compunit_symtab): Make "b" const.
 376         (find_symbol_at_address): Likewise.
 377         (search_symbols): Likewise.
 378         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 379         (dw2_debug_names_lookup_symbol): Likewise.
 380         (dw2_map_matching_symbols): Update.
 381         * p-valprint.c (pascal_val_print): Remove "block".
 382         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 383         (aux_add_nonlocal_symbols): Make "block" const.
 384         (resolve_subexp): Remove cast.
 385         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 386         const.
 387         (iterate_over_file_blocks): Likewise.
 388         * f-exp.y (%union) <bval>: Remove.
 389         * coffread.c (patch_opaque_types): Make "b" const.
 390         * spu-tdep.c (spu_catch_start): Make "block" const.
 391         * c-valprint.c (print_unpacked_pointer): Remove "block".
 392         * symmisc.c (dump_symtab_1): Make "b" const.
 393         (block_depth): Make "block" const.
 394         * d-exp.y (%union) <bval>: Remove.
 395         * cp-support.h (cp_lookup_rtti_type): Update.
 396         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 397         * psymtab.c (psym_lookup_symbol): Make "block" const.
 398         (maintenance_check_psymtabs): Make "b" const.
 399         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 400         (enumerate_locals, enumerate_args): Update.
 401         * python/py-symtab.c (stpy_global_block): Make "block" const.
 402         (stpy_static_block): Likewise.
 403         * inline-frame.c (block_starting_point_at): Make "new_block"
 404         const.
 405         * block.c (find_block_in_blockvector): Make return type const.
 406         (blockvector_for_pc_sect): Make "b" const.
 407         (find_block_in_blockvector): Make "b" const.
 408
 409 2019-03-23  Tom Tromey  <tom@tromey.com>
 410
 411         * varobj.c (varobj_create): Update.
 412         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 413         * printcmd.c (display_command, do_one_display): Don't reset
 414         innermost_block.
 415         * parser-defs.h (enum innermost_block_tracker_type): Move to
 416         expression.h.
 417         (innermost_block): Update comment.
 418         * parse.c (parse_exp_1): Add tracker_types parameter.
 419         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 420         tracker_types parameter.  Reset innermost_block.
 421         (parse_exp_in_context): Remove.
 422         (parse_expression_for_completion): Update.
 423         * objfiles.c (~objfile): Don't reset expression_context_block or
 424         innermost_block.
 425         * expression.h (enum innermost_block_tracker_type): Move from
 426         parser-defs.h.
 427         (parse_exp_1): Add tracker_types parameter.
 428         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 429         reset innermost_block.
 430
 431 2019-03-23  Tom Tromey  <tom@tromey.com>
 432
 433         * objfiles.h: Include bcache.h.
 434
 435 2019-03-23  Tom Tromey  <tom@tromey.com>
 436
 437         * linespec.c (get_current_search_block): Use
 438         scoped_restore_current_language.
 439         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 440
 441 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 442             Jiong Wang  <jiong.wang@arm.com>
 443
 444         * aarch64-linux-tdep.c
 445         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 446         section.
 447         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 448
 449 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 450             Jiong Wang  <jiong.wang@arm.com>
 451
 452         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 453         instructions.
 454         (aarch64_analyze_prologue_test): Add PACIASP test.
 455         (aarch64_prologue_prev_register): Unmask PC value.
 456
 457 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 458             Jiong Wang  <jiong.wang@arm.com>
 459
 460         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 461         (aarch64_dwarf2_prev_register): Unmask PC value.
 462         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 463         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 464         DW_CFA_AARCH64_negate_ra_state.
 465         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 466
 467 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 468             Jiong Wang  <jiong.wang@arm.com>
 469
 470         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 471         registers.
 472         (aarch64_pseudo_register_name): Likewise.
 473         (aarch64_pseudo_register_type): Likewise.
 474         (aarch64_pseudo_register_reggroup_p): Likewise.
 475         (aarch64_gdbarch_init): Add pauth registers.
 476         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 477         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 478         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 479         (struct gdbarch_tdep): Add regnum for ra_state.
 480
 481 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 482             Jiong Wang  <jiong.wang@arm.com>
 483
 484         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 485
 486 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 487             Jiong Wang  <jiong.wang@arm.com>
 488
 489         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 490         function.
 491         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 492         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 493         (aarch64_gdbarch_init): Add puth registers.
 494         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 495         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 496         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 497
 498 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 499             Jiong Wang  <jiong.wang@arm.com>
 500
 501         * aarch64-linux-nat.c
 502         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 503         * aarch64-linux-tdep.c
 504         (aarch64_linux_core_read_description): Likewise.
 505         (aarch64_linux_get_hwcap): New function.
 506         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 507         (aarch64_linux_get_hwcap): New declaration.
 508
 509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 510             Jiong Wang  <jiong.wang@arm.com>
 511
 512         * aarch64-linux-nat.c
 513         (aarch64_linux_nat_target::read_description): Add pauth param.
 514         * aarch64-linux-tdep.c
 515         (aarch64_linux_core_read_description): Likewise.
 516         * aarch64-tdep.c (struct target_desc): Add in pauth.
 517         (aarch64_read_description): Add pauth param.
 518         (aarch64_gdbarch_init): Likewise.
 519         * aarch64-tdep.h (aarch64_read_description): Likewise.
 520         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 521         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 522         * features/Makefile: Add new files.
 523         * features/aarch64-pauth.c: New file.
 524         * features/aarch64-pauth.xml: New file.
 525
 526 2019-03-20  Tom Tromey  <tromey@adacore.com>
 527
 528         * infrun.c (handle_inferior_event): Rename from
 529         handle_inferior_event_1.  Create a scoped_value_mark.
 530         (handle_inferior_event): Remove.
 531
 532 2019-03-19  Tom Tromey  <tromey@adacore.com>
 533
 534         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 535         * infrun.h (print_stop_event): Add "displays" parameter.
 536         * infrun.c (print_stop_event): Add "displays" parameter.
 537
 538 2019-03-19  Pedro Alves  <palves@redhat.com>
 539
 540         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 541         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 542         to -1.  Fix TABs vs spaces.
 543         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 544         * tui/tui-out.h (tui_ui_out) Add intro comments.
 545         <m_line, m_start_of_line>: In-class initialize, and add describing
 546         comment.
 547
 548 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 549
 550         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 551         variable names.
 552         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 553
 554 2019-03-18  Pedro Alves  <palves@redhat.com>
 555             Eli Zaretskii <eliz@gnu.org>
 556
 557         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 558         m_line and m_start_of_line.
 559
 560 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 561
 562         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 563         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 564         it returns a newline.  This fixes a regression in TU mode, whereby
 565         the next line is output on the same screen line as the user input.
 566
 567 2019-03-18  Tom Tromey  <tromey@adacore.com>
 568
 569         * minsyms.c (minimal_symbol_reader::install): Remove call to
 570         obstack_blank.
 571
 572 2019-03-18  Pedro Alves  <palves@redhat.com>
 573
 574         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 575         New globals.
 576         (apply_style): New, factored out from ...
 577         (apply_ansi_escape): ... this.  Handle reverse video mode.
 578         (tui_set_reverse_mode): New function.
 579         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 580         * tui/tui-winsource.c (tui_show_source_line): Use
 581         tui_set_reverse_mode instead of setting A_STANDOUT.
 582         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 583         New setter methods.
 584
 585 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 586
 587         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 588         Handle tabs.
 589
 590 2019-03-18  Tom Tromey  <tromey@adacore.com>
 591
 592         * ada-lang.c (empty_array): Add "high" parameter.
 593         (ada_evaluate_subexp): Update.
 594
 595 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 596
 597         * unittests/string_view-selftests.c: Define
 598         _initialize_string_view_selftests unconditionally.
 599
 600 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 601
 602         PR gdb/24350
 603         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 604
 605 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 606
 607         PR gdb/24351
 608         * windows-nat.c (display_selector): Fix format specifiers.
 609
 610 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 611
 612         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 613         tui_refill_source_window instead of tui_refresh_win, to update the
 614         current execution line.  This fixes redisplay of the current line
 615         when stepping through the code with "next" or "step".
 616
 617 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 618
 619         * source-cache.c (source_cache::get_source_lines): Call
 620         find_source_lines to initialize s->nlines.  This fixes vertical
 621         scrolling of TUI source window when the DOWN arrow is pressed.
 622
 623 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 624
 625         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 626         linux-thread-db.c (_initialize_thread_db): Likewise.
 627
 628 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 629
 630         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 631         wclrtoeol in tui_show_source_line".  This reverts changes made in
 632         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 633
 634 2019-03-15  Tom Tromey  <tom@tromey.com>
 635
 636         * symtab.h (struct minimal_symbol): Derive from
 637         general_symbol_info.
 638         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 639         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 640         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 641         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 642         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 643         (MSYMBOL_SEARCH_NAME): Update.
 644         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 645         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 646         * minsyms.c (minimal_symbol_reader::record_full): Update.
 647
 648 2019-03-15  Tom Tromey  <tom@tromey.com>
 649
 650         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 651
 652 2019-03-15  Tom Tromey  <tom@tromey.com>
 653
 654         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 655         unique_xmalloc_ptr.
 656         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 657         Update.
 658         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 659         (build_minimal_symbol_hash_tables)
 660         (minimal_symbol_reader::install): Update.
 661
 662 2019-03-15  Tom Tromey  <tom@tromey.com>
 663
 664         * symtab.c (create_demangled_names_hash): Update.
 665         (symbol_set_names): Update.
 666         * objfiles.h (struct objfile_per_bfd_storage)
 667         <demangled_names_hash>: Now an htab_up.
 668         * objfiles.c (objfile_per_bfd_storage): Simplify.
 669
 670 2019-03-15  Tom Tromey  <tom@tromey.com>
 671
 672         * objfiles.h (struct objfile_per_bfd_storage): Declare
 673         destructor.
 674         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 675         New.
 676         (get_objfile_bfd_data): Use new.  Don't initialize
 677         language_of_main.
 678         (free_objfile_per_bfd_storage): Remove.
 679         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 680
 681 2019-03-15  Tom Tromey  <tom@tromey.com>
 682
 683         * symfile.c (reread_symbols): Update.
 684         * objfiles.c (objfile::objfile): Update.
 685         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 686         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 687         comment.
 688         (minimal_symbol_reader::install): Update.
 689         (terminate_minimal_symbol_table): Remove.
 690         * jit.c (jit_object_close_impl): Update.
 691
 692 2019-03-15  Tom Tromey  <tom@tromey.com>
 693
 694         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 695         initializations.
 696
 697 2019-03-15  Tom Tromey  <tom@tromey.com>
 698
 699         * objfiles.h (struct objfile_per_bfd_storage)
 700         <demangled_hash_languages>: Now a bitset.
 701         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 702         (lookup_minimal_symbol): Update.
 703
 704 2019-03-15  Tom Tromey  <tom@tromey.com>
 705
 706         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 707         Don't return the symbol.
 708         * coffread.c (record_minimal_symbol): Use record_full.
 709
 710 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 711
 712         The MS-Windows port of ncurses fails to switch to a color pair if
 713         one or both of the colors are the implicit default colors.  This
 714         change records the default colors when TUI is initialized, and
 715         then specifies them explicitly when a color pair uses the default
 716         colors.  This allows color styling in TUI mode on MS-Windows.
 717
 718         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 719         ncurses_norm_attr.
 720         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 721         colors in ncurses_norm_attr.
 722         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 723         "none", replace it with the default color recorded in
 724         ncurses_norm_attr.
 725
 726 2019-03-14  Tom Tromey  <tromey@adacore.com>
 727
 728         * source-cache.h (class source_cache) <get_source_lines>: Return
 729         std::string.
 730         * source-cache.c (source_cache::extract_lines): Handle case where
 731         first_pos==npos.  Return std::string.
 732         (source_cache::get_source_lines): Update.
 733
 734 2019-03-14  Tom Tromey  <tromey@adacore.com>
 735
 736         * NEWS: Add item for "style sources" commands.
 737         * source-cache.c (source_cache::get_source_lines): Check
 738         source_styling.
 739         * cli/cli-style.c (source_styling): New global.
 740         (_initialize_cli_style): Add "style sources" commands.
 741         (show_style_sources): New function.
 742         * cli/cli-style.h (source_styling): Declare.
 743
 744 2019-03-14  Pedro Alves  <palves@redhat.com>
 745             Tom Tromey  <tromey@adacore.com>
 746
 747         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 748         * tui/tui-winsource.c (tui_refill_source_window): New function,
 749         from...
 750         (tui_horizontal_source_scroll): ... here.  Move some logic.
 751         * cli/cli-style.c (set_style_enabled): Notify new observable.
 752         * tui/tui-hooks.c (tui_redisplay_source): New function.
 753         (tui_attach_detach_observers): Attach or detach
 754         tui_redisplay_source.
 755         * observable.h (source_styling_changed): New observable.
 756         * observable.c: Define source_styling_changed observable.
 757
 758 2019-03-13  Tom Tromey  <tromey@adacore.com>
 759
 760         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 761         (i386_gnu_nat_target::store_registers): Update.
 762         * target-debug.h (target_debug_print_std_string): New macro.
 763         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 764         * windows-tdep.c (display_one_tib): Update.
 765         * tui/tui-stack.c (tui_make_status_line): Update.
 766         * top.c (print_inferior_quit_action): Update.
 767         * thread.c (thr_try_catch_cmd): Update.
 768         (add_thread_with_info): Update.
 769         (thread_target_id_str): Update.
 770         (thr_try_catch_cmd): Update.
 771         (thread_command): Update.
 772         (thread_find_command): Update.
 773         * record-btrace.c (record_btrace_target::info_record)
 774         (record_btrace_resume_thread, record_btrace_target::resume)
 775         (record_btrace_cancel_resume, record_btrace_step_thread)
 776         (record_btrace_target::wait, record_btrace_target::wait)
 777         (record_btrace_target::wait, record_btrace_target::stop): Update.
 778         * progspace.c (print_program_space): Update.
 779         * process-stratum-target.c
 780         (process_stratum_target::thread_address_space): Update.
 781         * linux-fork.c (linux_fork_mourn_inferior)
 782         (detach_checkpoint_command, info_checkpoints_command)
 783         (linux_fork_context): Update.
 784         (linux_fork_detach): Update.
 785         (class scoped_switch_fork_info): Update.
 786         (delete_checkpoint_command): Update.
 787         * infrun.c (follow_fork_inferior): Update.
 788         (follow_fork_inferior): Update.
 789         (proceed_after_vfork_done): Update.
 790         (handle_vfork_child_exec_or_exit): Update.
 791         (follow_exec): Update.
 792         (displaced_step_prepare_throw): Update.
 793         (displaced_step_restore): Update.
 794         (start_step_over): Update.
 795         (resume_1): Update.
 796         (clear_proceed_status_thread): Update.
 797         (proceed): Update.
 798         (print_target_wait_results): Update.
 799         (do_target_wait): Update.
 800         (context_switch): Update.
 801         (stop_all_threads): Update.
 802         (restart_threads): Update.
 803         (finish_step_over): Update.
 804         (handle_signal_stop): Update.
 805         (switch_back_to_stepped_thread): Update.
 806         (keep_going_pass_signal): Update.
 807         (print_exited_reason): Update.
 808         (normal_stop): Update.
 809         * inferior.c (inferior_pid_to_str): Change return type.
 810         (print_selected_inferior): Update.
 811         (add_inferior): Update.
 812         (detach_inferior): Update.
 813         * dummy-frame.c (fprint_dummy_frames): Update.
 814         * dcache.c (dcache_info_1): Update.
 815         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 816         (btrace_fetch, btrace_clear): Update.
 817         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 818         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 819         type.
 820         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 821         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 822         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 823         * gdbarch.c, gdbarch.h: Rebuild.
 824         * gdbarch.sh (core_pid_to_str): Change return type.
 825         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 826         return type.
 827         (windows_nat_target::pid_to_str): Change return type.
 828         (windows_delete_thread): Update.
 829         (windows_nat_target::attach): Update.
 830         (windows_nat_target::files_info): Update.
 831         * target-delegates.c: Rebuild.
 832         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 833         return type.
 834         (sol_thread_target::pid_to_str): Change return type.
 835         * remote.c (class remote_target) <pid_to_str>: Change return
 836         type.
 837         (remote_target::pid_to_str): Change return type.
 838         (extended_remote_target::attach, remote_target::remote_stop_ns)
 839         (remote_target::remote_notif_remove_queued_reply)
 840         (remote_target::push_stop_reply, remote_target::disable_btrace):
 841         Update.
 842         (extended_remote_target::attach): Update.
 843         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 844         type.
 845         (gdbsim_target::pid_to_str): Change return type.
 846         * ravenscar-thread.c (struct ravenscar_thread_target)
 847         <pid_to_str>: Change return type.
 848         (ravenscar_thread_target::pid_to_str): Change return type.
 849         * procfs.c (class procfs_target) <pid_to_str>: Change return
 850         type.
 851         (procfs_target::pid_to_str): Change return type.
 852         (procfs_target::attach): Update.
 853         (procfs_target::detach): Update.
 854         (procfs_target::fetch_registers): Update.
 855         (procfs_target::store_registers): Update.
 856         (procfs_target::wait): Update.
 857         (procfs_target::files_info): Update.
 858         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 859         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 860         return type.
 861         (nto_procfs_target::pid_to_str): Change return type.
 862         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 863         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 864         return type.
 865         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 866         (exit_lwp): Update.
 867         (attach_proc_task_lwp_callback, get_detach_signal)
 868         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 869         (linux_nat_target::resume, wait_lwp, stop_callback)
 870         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 871         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 872         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 873         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 874         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 875         type.
 876         (inf_ptrace_target::attach): Update.
 877         (inf_ptrace_target::files_info): Update.
 878         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 879         type.
 880         (go32_nat_target::pid_to_str): Change return type.
 881         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 882         (gnu_nat_target::wait): Update.
 883         (gnu_nat_target::wait): Update.
 884         (gnu_nat_target::resume): Update.
 885         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 886         (fbsd_nat_target::wait): Update.
 887         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 888         type.
 889         (darwin_nat_target::attach): Update.
 890         * corelow.c (class core_target) <pid_to_str>: Change return type.
 891         (core_target::pid_to_str): Change return type.
 892         * target.c (normal_pid_to_str): Change return type.
 893         (default_pid_to_str): Likewise.
 894         (target_pid_to_str): Change return type.
 895         (target_translate_tls_address): Update.
 896         (target_announce_detach): Update.
 897         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 898         return type.
 899         (bsd_uthread_target::pid_to_str): Change return type.
 900         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 901         type.
 902         (bsd_kvm_target::pid_to_str): Change return type.
 903         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 904         return type.
 905         (aix_thread_target::pid_to_str): Change return type.
 906         * target.h (struct target_ops) <pid_to_str>: Change return type.
 907         (target_pid_to_str, normal_pid_to_str): Likewise.
 908         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 909         type.
 910         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 911         type.
 912         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 913         return type.
 914         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 915         type.
 916         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 917         type.
 918         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 919         return type.
 920
 921 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 922
 923         * NEWS: Mention that the new default MI version is 3.  Mention
 924         changes to the output of commands and events that deal with
 925         multi-location breakpoints.
 926         * breakpoint.c: Include "mi/mi-out.h".
 927         (print_one_breakpoint): Change output syntax if using MI version
 928         >= 3.
 929         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 930         New.
 931         (mi_multi_location_breakpoint_output_fixed): New.
 932         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 933         (mi_cmd_fix_multi_location_breakpoint_output): New.
 934         (mi_multi_location_breakpoint_output_fixed): New.
 935         * mi/mi-cmds.c (mi_cmds): Register command
 936         -fix-multi-location-breakpoint-output.
 937         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 938         interpreter "mi".
 939
 940 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 941
 942         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 943         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 944         instantiate mi_ui_out based on interpreter name.
 945         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 946         * mi/mi-main.c (mi_load_progress): Likewise.
 947
 948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 949
 950         * NEWS: Combine separate "New targets" sections for 8.3.
 951
 952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 953
 954         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 955         (ppcfbsd_init_abi): Install gdbarch
 956         "fetch_tls_load_module_address" and "get_thread_local_address"
 957         methods.
 958
 959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 960
 961         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 962         (riscv_fbsd_init_abi): Install gdbarch
 963         "fetch_tls_load_module_address" and "get_thread_local_address"
 964         methods.
 965
 966 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 967
 968         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 969         (i386fbsd_init_abi): Install gdbarch
 970         "fetch_tls_load_module_address" and "get_thread_local_address"
 971         methods.
 972
 973 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 974
 975         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 976         (amd64fbsd_init_abi): Install gdbarch
 977         "fetch_tls_load_module_address" and "get_thread_local_address"
 978         methods.
 979
 980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 981
 982         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 983         (struct fbsd_pspace_data): New type.
 984         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 985         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 986         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 987         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 988         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 989
 990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 991
 992         * gdbtypes.c (lookup_struct_elt): New function.
 993         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 994         * gdbtypes.h (struct struct_elt): New type.
 995         (lookup_struct_elt): New prototype.
 996
 997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 998
 999         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1000         remove disabled code block.
1001
1002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1003
1004         * gdbarch.sh (get_thread_local_address): New method.
1005         * gdbarch.h, gdbarch.c: Regenerate.
1006         * target.c (target_translate_tls_address): Use
1007         gdbarch_get_thread_local_address if present instead of
1008         target::get_thread_local_address.
1009
1010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1011
1012         * target.h (target::get_thread_local_address): Update comment.
1013
1014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1015
1016         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1017         objfile->separate_debug_objfile_backlink if not NULL.
1018
1019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1020
1021         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1022         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1023         (amd64bsd_store_inferior_registers): Likewise.
1024         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1025         Enable segment base registers.
1026         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1027         PT_GETFSBASE and PT_GETGSBASE.
1028         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1029         PT_SETGSBASE.
1030         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1031         segment base registers.
1032         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1033
1034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1035
1036         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1037         Update calls to i386_target_description to add 'segments'
1038         parameter.
1039         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1040         add segment base registers.
1041         * arch/i386.c (i386_create_target_description): Add 'segments'
1042         parameter to enable segment base registers.
1043         * arch/i386.h (i386_create_target_description): Likewise.
1044         * features/i386/32bit-segments.xml: New file.
1045         * features/i386/32bit-segments.c: Generate.
1046         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1047         call to i386_target_description to add 'segments' parameter.
1048         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1049         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1050         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1051         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1052         if feature is present.
1053         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1054         Add 'segments' parameter to call to i386_target_description.
1055         (i386_target_description): Add 'segments' parameter to enable
1056         segment base registers.
1057         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1058         to call to i386_target_description.
1059         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1060         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1061         Define I386_NUM_REGS.
1062         (i386_target_description): Add 'segments' parameter to enable
1063         segment base registers.
1064
1065 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1066
1067         PR/24325
1068         * source-cache.c: #undef open and close, to avoid unresolved
1069         externals during linking.
1070
1071 2019-03-12  Tom Tromey  <tromey@adacore.com>
1072
1073         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1074         const.  Add initializers.
1075         (_initialize_remote): Don't initialize ptid globals.
1076
1077 2019-03-12  Pedro Alves  <palves@redhat.com>
1078
1079         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1080
1081 2019-03-12  Pedro Alves  <palves@redhat.com>
1082
1083         * cp-name-parser.y (main): Remove unused 'len' variable.
1084
1085 2019-03-12  Tom Tromey  <tromey@adacore.com>
1086
1087         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1088         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1089
1090 2019-03-12  Tom Tromey  <tromey@adacore.com>
1091
1092         * linux-nat.c (iterate_over_lwps): Update.
1093         (stop_callback): Remove parameter.
1094         (stop_wait_callback, detach_callback, resume_set_callback)
1095         (select_singlestep_lwp_callback, set_ignore_sigint)
1096         (status_callback, resumed_callback, resume_clear_callback)
1097         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1098         data parameter.
1099         (linux_nat_target::detach, linux_nat_target::resume)
1100         (linux_stop_and_wait_all_lwps, select_event_lwp)
1101         (linux_nat_filter_event, linux_nat_wait_1)
1102         (linux_nat_target::kill, linux_nat_target::stop)
1103         (linux_nat_target::stop): Update.
1104         (linux_nat_resume_callback): Change type.
1105         (resume_stopped_resumed_lwps, count_events_callback)
1106         (select_event_lwp_callback): Likewise.
1107         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1108         * arm-linux-nat.c (struct update_registers_data): Remove.
1109         (update_registers_callback): Change type.
1110         (arm_linux_insert_hw_breakpoint1): Update.
1111         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1112         parameter.
1113         (x86_linux_dr_set_addr): Update.
1114         (x86_linux_dr_set_control): Update.
1115         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1116         (iterate_over_lwps): Use gdb::function_view.
1117         * nat/aarch64-linux-hw-point.c (struct
1118         aarch64_dr_update_callback_param): Remove.
1119         (debug_reg_change_callback): Change type.
1120         (aarch64_notify_debug_reg_change): Update.
1121         * s390-linux-nat.c (s390_refresh_per_info): Update.
1122
1123 2019-03-11  Tom Tromey  <tromey@adacore.com>
1124
1125         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1126         redundant assignment to "this_cu".
1127
1128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1129
1130         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1131
1132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1133
1134         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1135         from...
1136         (rank_one_type): ... this.
1137
1138 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1139
1140         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1141         from...
1142         (rank_one_type): ... this.
1143
1144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1145
1146         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1147         from...
1148         (rank_one_type): ... this.
1149
1150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1151
1152         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1153         from...
1154         (rank_one_type): ... this.
1155
1156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1157
1158         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1159         from...
1160         (rank_one_type): ... this.
1161
1162 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1163
1164         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1165         from...
1166         (rank_one_type): ... this.
1167
1168 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1169
1170         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1171         from...
1172         (rank_one_type): ... this.
1173
1174 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1175
1176         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1177         from...
1178         (rank_one_type): ... this.
1179
1180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1181
1182         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1183         from...
1184         (rank_one_type): ... this.
1185
1186 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1187
1188         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1189         from...
1190         (rank_one_type): ... this.
1191
1192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1193
1194         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1195         from...
1196         (rank_one_type): ... this.
1197
1198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1199
1200         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1201         from...
1202         (rank_one_type): ... this.
1203
1204 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1205
1206         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1207         inferior-events' shows the example events.
1208
1209 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1210
1211         Support styling on native MS-Windows console
1212
1213         PR/24315
1214         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1215         on MS-Windows if $TERM is not defined.
1216
1217         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1218
1219         * posix-hdep.c (gdb_console_fputs):
1220         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1221         functions.
1222         * ui-file.h (gdb_console_fputs): Add prototype.
1223
1224         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1225         back to fputs only if the former returns zero.
1226
1227 2019-03-07  Tom Tromey  <tom@tromey.com>
1228
1229         * symmisc.c (print_symbol_bcache_statistics): Update.
1230         (print_objfile_statistics): Update.
1231         * symfile.c (allocate_symtab): Update.
1232         * stabsread.c: Don't include bcache.h.
1233         * psymtab.h (struct psymbol_bcache): Don't declare.
1234         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1235         (psymbol_bcache_init, psymbol_bcache_free)
1236         (psymbol_bcache_get_bcache): Don't declare.
1237         * psymtab.c (struct psymbol_bcache): Remove.
1238         (psymtab_storage::psymtab_storage): Update.
1239         (psymtab_storage::~psymtab_storage): Update.
1240         (psymbol_bcache_init, psymbol_bcache_free)
1241         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1242         (add_psymbol_to_bcache): Update.
1243         (allocate_psymtab): Update.
1244         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1245         macro_cache>: No longer pointers.
1246         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1247         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1248         * macrotab.c (macro_bcache): Update.
1249         * macroexp.c: Don't include bcache.h.
1250         * gdbtypes.c (check_types_worklist): Update.
1251         (types_deeply_equal): Remove TRY/CATCH.  Update.
1252         * elfread.c (elf_symtab_read): Update.
1253         * dwarf2read.c: Don't include bcache.h.
1254         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1255         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1256         (print_bcache_statistics, bcache_memory_used): Don't declare.
1257         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1258         methods.  Rename all data members.
1259         * bcache.c (struct bcache): Move to bcache.h.
1260         (bcache::expand_hash_table): Rename from expand_hash_table.
1261         (bcache): Remove.
1262         (bcache::insert): Rename from bcache_full.
1263         (bcache::compare): Rename from bcache_compare.
1264         (bcache_xmalloc): Remove.
1265         (bcache::~bcache): Rename from bcache_xfree.
1266         (bcache::print_statistics): Rename from print_bcache_statistics.
1267         (bcache::memory_used): Rename from bcache_memory_used.
1268
1269 2019-03-07  Pedro Alves  <palves@redhat.com>
1270
1271         * infrun.c (normal_stop): Also check for
1272         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1273
1274 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1275
1276         * f-lang.c (value_from_host_double): Moved to...
1277         * value.c (value_from_host_double): ...here.
1278         * value.h (value_from_host_double): Declare.
1279         * guile/scm-math.c (vlscm_convert_typed_number): Use
1280         value_from_host_double.
1281         (vlscm_convert_number): Likewise.
1282         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1283         * python/py-value.c (convert_value_from_python): Likewise.
1284
1285 2019-03-06  Tom Tromey  <tom@tromey.com>
1286
1287         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1288
1289 2019-03-06  Tom Tromey  <tom@tromey.com>
1290
1291         * utils.h (free_current_contents): Don't declare.
1292         * utils.c (free_current_contents): Remove.
1293
1294 2019-03-06  Tom Tromey  <tom@tromey.com>
1295
1296         * top.c (quit_force): Update.
1297         * main.c (captured_command_loop): Update.
1298         * common/new-op.c (operator new): Update.
1299         * common/common-exceptions.c (struct catcher)
1300         <save_cleanup_chain>: Remove member.
1301         (exceptions_state_mc_init): Update.
1302         (exception_try_scope_entry): Return nullptr.
1303         (exception_try_scope_exit, exception_rethrow)
1304         (throw_exception_sjlj, throw_exception_cxx): Update.
1305         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1306         (all_cleanups, do_cleanups, discard_cleanups)
1307         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1308         (restore_cleanups, restore_final_cleanups): Don't declare.
1309         (do_final_cleanups): Remove parameter.
1310         * common/cleanups.c (cleanup_chain, make_cleanup)
1311         (make_cleanup_dtor, all_cleanups, do_cleanups)
1312         (discard_my_cleanups, discard_cleanups)
1313         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1314         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1315         (null_cleanup): Remove.
1316         (do_final_cleanups): Remove parameter.
1317
1318 2019-03-06  Tom Tromey  <tom@tromey.com>
1319
1320         * remote.c (remote_target::remote_parse_stop_reply): Use
1321         unique_xmalloc_ptr.
1322
1323 2019-03-06  Tom Tromey  <tom@tromey.com>
1324
1325         * stabsread.c (struct stabs_field_info): Rename from field_info.
1326         <list, fnlist>: Add initializers.
1327         <obstack>: New member.
1328         (read_member_functions, read_struct_fields, read_baseclasses):
1329         Allocate on obstack.  Don't use cleanups.
1330         (read_one_struct_field, read_member_functions, read_struct_fields)
1331         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1332         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1333         (read_struct_type): Update.
1334
1335 2019-03-06  Tom Tromey  <tom@tromey.com>
1336
1337         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1338         * common/filestuff.h (make_cleanup_close): Don't declare.
1339         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1340         Remove.
1341
1342 2019-03-06  Tom Tromey  <tom@tromey.com>
1343
1344         * solib-aix.c: Use make_scope_exit.
1345
1346 2019-03-06  Tom Tromey  <tom@tromey.com>
1347
1348         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1349         Use make_scope_exit.
1350
1351 2019-03-06  Tom Tromey  <tom@tromey.com>
1352
1353         * solib-svr4.c (disable_probes_interface): Remove parameter.
1354         (svr4_handle_solib_event): Use make_scope_exit.
1355
1356 2019-03-06  Tom Tromey  <tom@tromey.com>
1357
1358         * remote.c (struct stop_reply_deleter): Remove.
1359         (stop_reply_up): Update.
1360         (struct stop_reply): Derive from notif_event.  Don't typedef.
1361         <regcache>: Now a std::vector.
1362         (stop_reply_xfree): Remove.
1363         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1364         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1365         (remote_target::discard_pending_stop_replies): Use delete.
1366         (remote_target::remote_parse_stop_reply): Update.
1367         (remote_target::process_stop_reply): Update.
1368         * remote-notif.h (struct notif_event): Add virtual destructor.
1369         Remove "dtr" member.
1370         (struct notif_client) <alloc_event>: Return a unique_ptr.
1371         (notif_event_xfree): Don't declare.
1372         (notif_event_up): New typedef.
1373         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1374         (notif_event_xfree, do_notif_event_xfree): Remove.
1375         (remote_notif_state_xfree): Update.
1376
1377 2019-03-06  Tom Tromey  <tom@tromey.com>
1378
1379         * infrun.c (displaced_step_clear_cleanup): Now a
1380         forward_scope_exit type.
1381         (displaced_step_prepare_throw): Update.
1382         (displaced_step_fixup): Update.
1383
1384 2019-03-06  Tom Tromey  <tom@tromey.com>
1385
1386         * inferior.h (class inferior): Update comment.
1387         * gdbthread.h (class thread_info): Update comment.
1388
1389 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1390             Tom Tromey  <tom@tromey.com>
1391
1392         * stabsread.h (struct stab_section_list): Remove.
1393         (coffstab_build_psymtabs): Update.
1394         * dbxread.c (symbuf_sections): Now a std::vector.
1395         (sect_idx): New global.
1396         (fill_symbuf): Update.
1397         (coffstab_build_psymtabs): Change type of stabsects parameter.
1398         Update.
1399         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1400         std::vector.
1401         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1402         (coff_locate_sections): Update.
1403         (coff_symfile_read): Remove cleanups.  Update.
1404         (init_stringtab): Add storage parameter.
1405         (free_stringtab, free_stringtab_cleanup): Remove.
1406         (init_lineno): Add storage parameter.
1407         (free_linetab, free_linetab_cleanup): Remove.
1408
1409 2019-03-06  Pedro Alves  <palves@redhat.com>
1410
1411         * linux-fork.c (fork_info::clobber_regs): Delete.
1412         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1413         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1414         comment.  Adjust.
1415         (scoped_switch_fork_info::scoped_switch_fork_info)
1416         (checkpoint_command, linux_fork_context): Adjust
1417         fork_save_infrun_state calls.
1418
1419 2019-03-06  Pedro Alves  <palves@redhat.com>
1420
1421         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1422         (inf_has_multiple_threads): Return 'bool' and rewrite using
1423         inferior_info::threads().
1424
1425 2019-03-06  Pedro Alves  <palves@redhat.com>
1426
1427         * linux-fork.c: Include <list>.
1428         (fork_list): Now a std::list instance.
1429         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1430         (forks_exist_p, find_last_fork): Adjust.
1431         (new_fork): Delete.
1432         (one_fork_p): New.
1433         (add_fork): Adjust.
1434         (free_fork): Delete, folded into fork_info::~fork_info().
1435         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1436         Adjust.
1437         (init_fork_list): Delete.
1438         (linux_fork_killall, linux_fork_mourn_inferior)
1439         (linux_fork_detach, info_checkpoints_command): Adjust.
1440         (_initialize_linux_fork): No longer call init_fork_list.
1441
1442 2019-03-06  Pedro Alves  <palves@redhat.com>
1443
1444         * linux-fork.c (new_fork): New, split out of ...
1445         (add_fork): ... this.  Return void.  Move "first fork" special
1446         case from here, to ...
1447         (checkpoint_command): ... here.
1448         * linux-linux.h (add_fork): Return void.
1449
1450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1451
1452         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1453
1454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1455             Chris January  <chris.january@arm.com>
1456             David Lecomber  <david.lecomber@arm.com>
1457
1458         * f-exp.y: New token, UNOP_INTRINSIC.
1459         (exp): New pattern using UNOP_INTRINSIC token.
1460         (f77_keywords): Add 'abs' keyword.
1461         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1462         (value_from_host_double): New function.
1463         (evaluate_subexp_f): Support UNOP_ABS.
1464
1465 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1468         types.
1469
1470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1471
1472         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1473         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1474         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1475
1476 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1477
1478         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1479
1480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1481             Chris January  <chris.january@arm.com>
1482
1483         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1484         * f-exp.y: Define 'KIND' token.
1485         (exp): New pattern for KIND expressions.
1486         (ptype): Handle types with a kind extension.
1487         (direct_abs_decl): Extend to spot kind extensions.
1488         (f77_keywords): Add 'kind' to the list.
1489         (push_kind_type): New function.
1490         (convert_to_kind_type): New function.
1491         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1492         * parse.c (operator_length_standard): Likewise.
1493         * parser-defs.h (enum type_pieces): Add tp_kind.
1494         * std-operator.def: Add UNOP_KIND.
1495
1496 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * f-exp.y (f_parse): Set yydebug.
1499
1500 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1501
1502         * f-lang.c (evaluate_subexp_f): New function.
1503         (exp_descriptor_f): New global.
1504         (f_language_defn): Use exp_descriptor_f instead of
1505         exp_descriptor_standard.
1506
1507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1508
1509         * f-exp.y (struct token): Add comments.
1510         (dot_ops): Remove uppercase versions and the end marker.
1511         (f77_keywords): Likewise.
1512         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1513         entries in the dot_ops array are case insensitive, and use
1514         strncasecmp to compare strings.  Also some whitespace cleanup in
1515         this area.  Similar for the f77_keywords array, except entries in
1516         this list might be case sensitive.
1517
1518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1519
1520         * f-exp.y (struct f77_boolean_val): Add comments.
1521         (boolean_values): Remove uppercase versions, and end marker.
1522         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1523         and use strncasecmp to achieve case insensitivity.  Additionally,
1524         perform whitespace cleanup around this code.
1525
1526 2019-03-06  Tom Tromey  <tromey@adacore.com>
1527
1528         * remote-sim.c (gdbsim_target_open): Use result of
1529         gdb_argv::release.
1530
1531 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1532         Dirk Schubert  <dirk.schubert@arm.com>
1533         Chris January  <chris.january@arm.com>
1534
1535         * eval.c (evaluate_subexp_standard): Call Fortran argument
1536         wrapping logic.
1537         * f-lang.c (struct value): A value which can be passed into a
1538         Fortran function call.
1539         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1540         where appropriate.
1541         (struct type): Value ready for a Fortran function call.
1542         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1543         is needed.
1544         * f-lang.h (fortran_argument_convert): Declaration.
1545         (fortran_preserve_arg_pointer): Declaration.
1546         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1547
1548 2019-03-05  Tom Tromey  <tromey@adacore.com>
1549
1550         * python/py-prettyprint.c (print_string_repr): Remove #if.
1551         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1552
1553 2019-03-05  Tom Tromey  <tromey@adacore.com>
1554
1555         * target.c (the_dummy_target): Move later.  Change type to
1556         "dummy_target".
1557         (initialize_targets): Don't initialize the_dummy_target.
1558
1559 2019-03-05  Tom Tromey  <tromey@adacore.com>
1560
1561         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1562         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1563
1564 2019-03-05  Tom Tromey  <tromey@adacore.com>
1565
1566         * windows-nat.c (windows_nat_target::attach)
1567         (windows_nat_target::detach): Don't call gdb_flush.
1568         * valprint.c (generic_val_print, val_print, val_print_string):
1569         Don't call gdb_flush.
1570         * utils.c (defaulted_query): Don't call gdb_flush.
1571         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1572         * target.c (target_announce_detach): Don't call gdb_flush.
1573         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1574         * remote.c (extended_remote_target::attach): Don't call
1575         gdb_flush.
1576         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1577         * printcmd.c (do_examine): Don't call gdb_flush.
1578         (info_display_command): Don't call gdb_flush.
1579         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1580         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1581         * memattr.c (info_mem_command): Don't call gdb_flush.
1582         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1583         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1584         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1585         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1586         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1587         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1588         (gnu_nat_target::detach): Don't call gdb_flush.
1589         * f-valprint.c (f_val_print): Don't call gdb_flush.
1590         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1591         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1592         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1593         gdb_flush.
1594         * c-valprint.c (c_val_print): Don't call gdb_flush.
1595         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1596
1597 2019-03-05  Tom Tromey  <tromey@adacore.com>
1598
1599         * varobj.c (update_dynamic_varobj_children): Update.
1600         (install_default_visualizer): Use reset, not release.
1601         * value.c (set_internalvar): Update.
1602         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1603         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1604         ATTRIBUTE_UNUSED_RESULT.
1605
1606 2019-03-05  Tom Tromey  <tromey@adacore.com>
1607
1608         * remote.c (class scoped_remote_fd) <release>: Add
1609         ATTRIBUTE_UNUSED_RESULT.
1610
1611 2019-03-05  Tom Tromey  <tromey@adacore.com>
1612
1613         * macroexp.c (struct macro_buffer) <release>: Add
1614         ATTRIBUTE_UNUSED_RESULT.
1615
1616 2019-03-05  Tom Tromey  <tromey@adacore.com>
1617
1618         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1619         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1620         ATTRIBUTE_UNUSED_RESULT.
1621
1622 2019-03-05  Tom Tromey  <tromey@adacore.com>
1623
1624         * common/scoped_fd.h (class scoped_fd) <release>: Add
1625         ATTRIBUTE_UNUSED_RESULT.
1626
1627 2019-03-05  Tom Tromey  <tromey@adacore.com>
1628
1629         * parser-defs.h (struct parser_state) <release>: Add
1630         ATTRIBUTE_UNUSED_RESULT.
1631
1632 2019-03-05  Tom Tromey  <tromey@adacore.com>
1633
1634         * utils.h (class gdb_argv) <release>: Add
1635         ATTRIBUTE_UNUSED_RESULT.
1636         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1637
1638 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1639
1640         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1641         for-loop range, to avoid compiler warnings.
1642
1643         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1644         avoid compiler warnings about unused variables.
1645
1646         * NEWS: Mention end of support for native debugging on MS-Windows
1647         before XP.
1648
1649         PR gdb/24292
1650         * common/netstuff.c:
1651         * gdbserver/gdbreplay.c
1652         * gdbserver/remote-utils.c:
1653         * ser-tcp.c:
1654         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1655         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1656         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1657         'getaddrinfo' and 'freeaddrinfo' were not available before
1658         Windows XP, and mingw.org's MinGW headers by default define
1659         _WIN32_WINNT to 0x500.
1660
1661 2019-03-01  Gary Benson <gbenson@redhat.com>
1662
1663         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1664
1665 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1666             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1667
1668         PR gdb/8527
1669         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1670         set_sigint_trap, clear_sigint_trap.
1671
1672 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1673
1674         * target.c (target_detach): Clear the regcache and the
1675         frame cache.
1676
1677 2019-02-27  Pedro Alves  <palves@redhat.com>
1678
1679         * utils.c (set_screen_size): When we cap the height/width sizes,
1680         tweak the corresponding command variable to show "unlimited":
1681
1682 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1683             Pedro Alves  <palves@redhat.com>
1684
1685         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1686         before calling rl_set_screen_size.
1687
1688 2019-02-27  Tom Tromey  <tromey@adacore.com>
1689
1690         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1691         define.
1692         * python/py-value.c: Remove Python 2.4 workaround.
1693         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1694         workaround.
1695         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1696         Python 2.4 workaround.
1697         * python/python-internal.h: Remove Python 2.4 comment.
1698         (Py_ssize_t): Don't define.
1699         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1700         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1701         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1702         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1703         * python/python.c (do_start_initialization): Remove Python 2.4
1704         workaround.
1705         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1706         (print_children): Remove Python 2.4 workaround.
1707         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1708         workaround.
1709         (CHARBUFFERPROC_NAME): Remove.
1710         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1711         Python 2.4 workaround.
1712
1713 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1714
1715         * NEWS: Note minimum Python version.
1716
1717 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1718
1719         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1720         code from these functions.  Remove corresponding ifdefs.  Use
1721         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1722         Remove gotos and target of gotos.
1723         (infpy_search_memory): Likewise.
1724
1725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1726
1727         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1728         (hppa_gdbarch_init): Don't register deleted functions with
1729         gdbarch.
1730
1731 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1732
1733         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1734         (h8300_unwind_sp): Delete.
1735         (h8300_dummy_id): Delete.
1736         (h8300_gdbarch_init): Don't register deleted functions with
1737         gdbarch.
1738
1739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1740
1741         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1742         (ft32_unwind_pc): Delete.
1743         (ft32_unwind_sp): Delete.
1744         (ft32_gdbarch_init): Don't register deleted functions with
1745         gdbarch.
1746
1747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1748
1749         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1750         (frv_unwind_pc): Delete.
1751         (frv_unwind_sp): Delete.
1752         (frv_gdbarch_init): Don't register deleted functions with
1753         gdbarch.
1754
1755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1758         (riscv_unwind_pc): Delete.
1759         (riscv_unwind_sp): Delete.
1760         (riscv_gdbarch_init): Don't register deleted functions with
1761         gdbarch.
1762
1763 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1764
1765         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1766         (csky_unwind_pc): Delete.
1767         (csky_unwind_sp): Delete.
1768         (csky_gdbarch_init): Don't register deleted functions with
1769         gdbarch.
1770
1771 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1772
1773         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1774         (cris_unwind_pc): Delete.
1775         (cris_unwind_sp): Delete.
1776         (cris_gdbarch_init): Don't register deleted functions with
1777         gdbarch.
1778
1779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1780
1781         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1782         (bfin_unwind_pc): Delete.
1783         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1784
1785 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1786
1787         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1788         (arm_unwind_pc): Delete.
1789         (arm_unwind_sp): Delete.
1790         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1791
1792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1793
1794         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1795         (arc_unwind_pc): Delete.
1796         (arc_unwind_sp): Delete.
1797         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1798
1799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1800
1801         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1802         (alpha_unwind_pc): Delete.
1803         (alpha_gdbarch_init): Don't register deleted functions with
1804         gdbarch.
1805
1806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1807
1808         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1809         (aarch64_unwind_pc): Delete.
1810         (aarch64_unwind_sp): Delete.
1811         (aarch64_gdbarch_init): Don't register deleted functions with
1812         gdbarch.
1813
1814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1815
1816         * gdbtypes.c (type_align): Don't consider static members when
1817         computing structure alignment.
1818
1819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1820
1821         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1822         return 0 for other types.
1823         * arch-utils.c (default_type_align): Always return 0.
1824         * gdbarch.h: Regenerate.
1825         * gdbarch.sh (type_align): Extend comment.
1826         * gdbtypes.c (type_align): Add additional comments, always call
1827         gdbarch_type_align before applying the default rules.
1828         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1829         generic code will then apply a suitable default.
1830         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1831         types, return 0 for other types.
1832
1833 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1834
1835         * NEWS: Create a new section for the next release branch.
1836         Rename the section of the current branch, now that it has
1837         been cut.
1838
1839 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1840
1841         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1842         * version.in: Bump version to 8.3.50.DATE-git.
1843
1844 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1845
1846         * aix-thread.c (ptid_cmp): Remove unused variable.
1847         (get_signaled_thread): Likewise.
1848         (store_regs_user_thread): Likewise.
1849         (store_regs_kernel_thread): Likewise.
1850         (fetch_regs_kernel_thread): Remove shadowed variable.
1851
1852 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1853
1854         * features/riscv/32bit-cpu.xml: Add register numbers.
1855         * features/riscv/32bit-fpu.c: Regenerate.
1856         * features/riscv/32bit-fpu.xml: Add register numbers.
1857         * features/riscv/64bit-cpu.xml: Add register numbers.
1858         * features/riscv/64bit-fpu.c: Regenerate.
1859         * features/riscv/64bit-fpu.xml: Add register numbers.
1860
1861 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1862
1863         * NEWS: Mention two argument form of gdb.Value constructor.
1864         * python/py-value.c (convert_buffer_and_type_to_value): New
1865         function.
1866         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1867         Add support for handling an optional second argument.  Call
1868         convert_buffer_and_type_to_value as appropriate.
1869         * python/python-internal.h (Py_buffer_deleter): New struct.
1870         (Py_buffer_up): New typedef.
1871
1872 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1873
1874         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1875         instead of releasing ownership.
1876
1877 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1878
1879         * dwarf2read.c (open_and_init_dwp_file): Call
1880         elf_numsections instead of bfd_count_sections to initialize
1881         dwp_file->num_sections.
1882
1883 2019-02-25  Tom Tromey  <tromey@adacore.com>
1884
1885         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1886
1887 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1888
1889         * gcore.in: Add '--readnever' option when invoking GDB.
1890
1891 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1892
1893         * MAINTAINERS: Update my email address.
1894
1895 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1896
1897         * build-id.c (build_id_to_debug_bfd_1): New function.
1898         (build_id_to_debug_bfd): Look for separate debug file in
1899         sysroot.
1900
1901 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1902
1903         * gdbarch.sh: Update the copyright year range that is placed into
1904         generated files.
1905
1906 2019-02-22  Keith Seitz  <keiths@redhat.com>
1907
1908         PR symtab/23853
1909         * linespec.c (create_sals_line_offset): Search for the default
1910         symtab's filename instead of its fullname.
1911
1912 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1913
1914         * NEWS: Update style defaults.
1915
1916 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1917
1918         * main.c (captured_main_1): Disable styling in batch mode.
1919
1920 2019-02-20  Tom Tromey  <tom@tromey.com>
1921
1922         * symtab.c (symtab_symbol_info): Fix typos.
1923
1924 2019-02-20  Tom Tromey  <tromey@adacore.com>
1925
1926         * findcmd.c (_initialize_mem_search): Use upper case for
1927         metasyntactic variables.
1928
1929 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1930
1931         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1932         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1933
1934 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1935
1936         * top.h (source_file_name): Change to std::string.
1937         * top.c (source_file_name): Likewise.
1938         (command_line_input): Adjust.
1939         * cli/cli-script.c (script_from_file): Adjust.
1940
1941 2019-02-19  Tom Tromey  <tromey@adacore.com>
1942
1943         * ravenscar-thread.c
1944         (ravenscar_thread_target::update_thread_list): Don't call
1945         ada_build_task_list.
1946         * ada-lang.h (ada_build_task_list): Don't declare.
1947         * ada-tasks.c (struct ada_tasks_inferior_data)
1948         <task_list_valid_p>: Now bool.
1949         (read_known_tasks, ada_task_list_changed)
1950         (ada_tasks_invalidate_inferior_data): Update.
1951         (read_known_tasks_array): Return bool.
1952         (read_known_tasks_list): Likewise.
1953         (read_known_tasks): Return void.
1954         (ada_build_task_list): Now static.
1955
1956 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1957
1958         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1959         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1960
1961 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1962
1963         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1964         variant for ada_tasks_pspace_data_handle and
1965         ada_tasks_inferior_data_handle.
1966         (ada_tasks_pspace_data_cleanup): New function.
1967         (ada_tasks_inferior_data_cleanup): New function.
1968
1969 2019-02-17  Tom Tromey  <tom@tromey.com>
1970
1971         * macrotab.h (macro_source_fullname): Return a std::string.
1972         * macrotab.c (macro_include, check_for_redefinition)
1973         (macro_undef, macro_lookup_definition, foreach_macro)
1974         (foreach_macro_in_scope): Update.
1975         (macro_source_fullname): Return a std::string.
1976         * macrocmd.c (show_pp_source_pos): Update.
1977
1978 2019-02-17  Tom Tromey  <tom@tromey.com>
1979
1980         * macrocmd.c (show_pp_source_pos): Style the file names.
1981
1982 2019-02-17  Tom Tromey  <tom@tromey.com>
1983
1984         PR tui/24197:
1985         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1986
1987 2019-02-17  Tom Tromey  <tom@tromey.com>
1988
1989         * ada-lang.c (user_select_syms): Use filtered printing.
1990         * utils.c (wrap_style): New global.
1991         (desired_style): Remove.
1992         (emit_style_escape): Add stream parameter.
1993         (set_output_style, reset_terminal_style, prompt_for_continue):
1994         Update.
1995         (flush_wrap_buffer): Only flush gdb_stdout.
1996         (wrap_here): Set wrap_style.
1997         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1998         treat escape sequences as a character.  Change when wrap buffer is
1999         flushed.
2000         (fputs_styled): Do not set the output style when the default is
2001         requested.
2002         * ui-style.h (struct ui_file_style) <is_default>: New method.
2003         * source.c (print_source_lines_base): Emit escape sequences in one
2004         piece.
2005
2006 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2007
2008         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2009         integers and enumeration types.
2010
2011 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2012
2013         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2014         instead of lookup_symbol_in_language
2015         (do_exact_match): New function.
2016         (ada_get_symbol_name_matcher): Return do_exact_match when
2017         doing a verbatim match.
2018
2019 2019-02-15  Tom Tromey  <tromey@adacore.com>
2020
2021         * ravenscar-thread.c (ravenscar_thread_target::resume)
2022         (ravenscar_thread_target::wait): Special case wildcard requests.
2023
2024 2019-02-15  Tom Tromey  <tromey@adacore.com>
2025
2026         * ravenscar-thread.c (base_ptid): Remove.
2027         (struct ravenscar_thread_target) <close>: New method.
2028         <m_base_ptid>: New member.
2029         <update_inferior_ptid, active_task, task_is_currently_active,
2030         runtime_initialized>: Declare methods.
2031         <ravenscar_thread_target>: Add constructor.
2032         (ravenscar_thread_target::task_is_currently_active)
2033         (ravenscar_thread_target::update_inferior_ptid)
2034         (ravenscar_runtime_initialized): Rename.  Now methods.
2035         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2036         (ravenscar_thread_target::update_thread_list): Update.
2037         (ravenscar_thread_target::active_task): Now method.
2038         (ravenscar_thread_target::store_registers)
2039         (ravenscar_thread_target::prepare_to_store)
2040         (ravenscar_thread_target::prepare_to_store)
2041         (ravenscar_thread_target::mourn_inferior): Update.
2042         (ravenscar_inferior_created): Use "new" to create target.
2043         (ravenscar_thread_target::get_ada_task_ptid): Update.
2044         (_initialize_ravenscar): Don't initialize base_ptid.
2045         (ravenscar_ops): Remove global.
2046
2047 2019-02-15  Tom Tromey  <tromey@adacore.com>
2048
2049         * target.h (push_target): Declare new overload.
2050         * target.c (push_target): New overload, taking an rvalue reference.
2051         * remote.c (remote_target::open_1): Use push_target overload.
2052         * corelow.c (core_target_open): Use push_target overload.
2053
2054 2019-02-15  Tom Tromey  <tromey@adacore.com>
2055
2056         * ravenscar-thread.c (is_ravenscar_task)
2057         (ravenscar_task_is_currently_active): Return bool.
2058         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2059         (_initialize_ravenscar): Remove "(void)".
2060         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2061         Return bool.
2062
2063 2019-02-15  Tom Tromey  <tromey@adacore.com>
2064
2065         * ravenscar-thread.c (ravenscar_runtime_initializer)
2066         (has_ravenscar_runtime, get_running_thread_id)
2067         (ravenscar_thread_target::resume): Fix indentation.
2068
2069 2019-02-15  Tom Tromey  <tromey@adacore.com>
2070
2071         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2072         from ravenscar_arch_ops.
2073         (sparc_ravenscar_ops::fetch_registers)
2074         (sparc_ravenscar_ops::store_registers): Now methods.
2075         (sparc_ravenscar_prepare_to_store): Remove.
2076         (sparc_ravenscar_ops): Redefine.
2077         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2078         methods and destructor.  Remove members.
2079         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2080         (ravenscar_thread_target::store_registers)
2081         (ravenscar_thread_target::prepare_to_store): Update.
2082         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2083         Remove.
2084         (struct ppc_ravenscar_powerpc_ops): Derive from
2085         ravenscar_arch_ops.
2086         (ppc_ravenscar_powerpc_ops::fetch_registers)
2087         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2088         (ppc_ravenscar_powerpc_ops): Redefine.
2089         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2090         (ppc_ravenscar_e500_ops::fetch_registers)
2091         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2092         (ppc_ravenscar_e500_ops): Redefine.
2093         * aarch64-ravenscar-thread.c
2094         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2095         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2096         (aarch64_ravenscar_fetch_registers)
2097         (aarch64_ravenscar_store_registers): Now methods.
2098         (aarch64_ravenscar_ops): Redefine.
2099
2100 2019-02-15  Tom Tromey  <tromey@adacore.com>
2101
2102         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2103         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2104         (ravenscar_thread_target::stopped_by_watchpoint)
2105         (ravenscar_thread_target::stopped_data_address)
2106         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2107
2108 2019-02-15  Tom Tromey  <tromey@adacore.com>
2109
2110         * ravenscar-thread.c: Fix some typos.
2111
2112 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2113             Tom Tromey  <tromey@adacore.com>
2114
2115         * ada-lang.c (ada_exception_sal): Change addr_string to a
2116         std::string.
2117         (create_ada_exception_catchpoint): Update.
2118
2119 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2120             Tom Tromey  <tromey@adacore.com>
2121
2122         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2123         (bp_location_ops): Remove.
2124         (base_breakpoint_allocate_location): Update.
2125         (free_bp_location): Update.
2126         * ada-lang.c (class ada_catchpoint_location)
2127         <ada_catchpoint_location>: Remove ops parameter.
2128         (ada_catchpoint_location_dtor): Remove.
2129         (ada_catchpoint_location_ops): Remove.
2130         (allocate_location_exception): Update.
2131         * breakpoint.h (struct bp_location_ops): Remove.
2132         (class bp_location) <bp_location>: Remove bp_location_ops
2133         parameter.
2134         <~bp_location>: Add destructor.
2135         <ops>: Remove.
2136
2137 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2138             Pedro Alves  <palves@redhat.com>
2139
2140         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2141         'PATH_MAX'.
2142
2143 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2144             Samuel Thibault  <samuel.thibault@gnu.org>
2145             Thomas Schwinge  <thomas@codesourcery.com>
2146
2147         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2148         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2149
2150 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2151
2152         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2153         (check_empty): Use "const char *".
2154
2155         * gnu-nat.c (gnu_nat_target::detach): Instead of
2156         'detach_inferior (pid)' call
2157         'detach_inferior (find_inferior_pid (pid))'.
2158
2159         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2160         'nat/fork-inferior.o'.
2161         * gnu-nat.c: #include "nat/fork-inferior.h".
2162
2163         * gnu-nat.c (gnu_nat_target::detach): Instead of
2164         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2165         * gnu-nat.h: #include "inf-child.h".
2166         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2167         'i386_gnu_nat_target::fetch_registers'.
2168         (gnu_store_registers): Rename/move to
2169         'i386_gnu_nat_target::store_registers'.
2170
2171         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2172         * gnu-nat.h (mach_thread_info): New function.
2173         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2174
2175         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2176
2177 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2178
2179         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2180
2181 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2182
2183         * windows-nat.c (windows_add_thread): Add new parameter
2184         "main_thread_p" with default value set to false.  Update
2185         function documentation as well as all callers.
2186         (windows_delete_thread): Likewise.
2187         (fake_create_process): Update call to windows_add_thread.
2188         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2189         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2190         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2191         call to windows_delete_thread.
2192
2193 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2194
2195         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2196
2197 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2198
2199         * symfile.c (find_separate_debug_file): Use canonical path of
2200         sysroot with child_path instead of gdb_sysroot if it is valid.
2201
2202 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2203
2204         * symfile.c (find_separate_debug_file): Use child_path to
2205         determine if an object file is under a sysroot.
2206
2207 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2208
2209         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2210         unittests/child-path-selftests.c.
2211         * common/pathstuff.c (child_path): New function.
2212         * common/pathstuff.h (child_path): New prototype.
2213         * unittests/child-path-selftests.c: New file.
2214
2215 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2216
2217         * symfile.c (find_separate_debug_file): Look for separate debug
2218         files in debug directories under the sysroot.
2219
2220 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2221
2222         * symtab.h (struct minimal_symbol data_p): New const method.
2223         (struct minimal_symbol text_p): Likewise.
2224         * symtab.c (output_source_filename): Use file name style
2225         to print file name.
2226         (print_symbol_info): Likewise.
2227         (print_msymbol_info): Use address style to print addresses.
2228         Use function name style to print executable text symbols.
2229         (expand_symtab_containing_pc): Use data_p.
2230         (find_pc_sect_compunit_symtab): Likewise.
2231
2232 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2233
2234         * breakpoint.c (describe_other_breakpoints): Use address style
2235         to print addresses.
2236         (say_where): Likewise.
2237
2238 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2239
2240         * ada-typeprint.c (print_func_type): Print function name
2241         style to print function name.
2242         * c-typeprint.c (c_print_type_1): Likewise.
2243
2244 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2245
2246         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2247         for execve.
2248
2249 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2250
2251         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2252         type_stack.
2253
2254 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2255
2256         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2257         TYPE_CODE_REF types.
2258
2259 2019-02-08  Jim Wilson  <jimw@sifive.com>
2260
2261         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2262         (riscv_linux_fregset): New.
2263         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2264
2265 2019-02-07  Tom Tromey  <tom@tromey.com>
2266
2267         * thread.c (thread_cancel_execution_command): Update.
2268         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2269         methods.
2270         (struct thread_fsm_ops): Remove.
2271         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2272         (thread_fsm_should_stop, thread_fsm_return_value)
2273         (thread_fsm_set_finished, thread_fsm_finished_p)
2274         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2275         Don't declare.
2276         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2277         * infrun.c (clear_proceed_status_thread)
2278         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2279         (print_stop_event): Update.
2280         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2281         Add constructor.
2282         (step_command_fsm_ops): Remove.
2283         (new_step_command_fsm): Remove.
2284         (step_1): Update.
2285         (step_command_fsm::should_stop): Rename from
2286         step_command_fsm_should_stop.
2287         (step_command_fsm::clean_up): Rename from
2288         step_command_fsm_clean_up.
2289         (step_command_fsm::do_async_reply_reason): Rename from
2290         step_command_fsm_async_reply_reason.
2291         (struct until_next_fsm): Inherit from thread_fsm.  Add
2292         constructor.
2293         (until_next_fsm_ops): Remove.
2294         (new_until_next_fsm): Remove.
2295         (until_next_fsm::should_stop): Rename from
2296         until_next_fsm_should_stop.
2297         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2298         (until_next_fsm::do_async_reply_reason): Rename from
2299         until_next_fsm_async_reply_reason.
2300         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2301         constructor.  Change type of breakpoint.
2302         (finish_command_fsm_ops): Remove.
2303         (new_finish_command_fsm): Remove.
2304         (finish_command_fsm::should_stop): Rename from
2305         finish_command_fsm_should_stop.
2306         (finish_command_fsm::clean_up): Rename from
2307         finish_command_fsm_clean_up.
2308         (finish_command_fsm::return_value): Rename from
2309         finish_command_fsm_return_value.
2310         (finish_command_fsm::do_async_reply_reason): Rename from
2311         finish_command_fsm_async_reply_reason.
2312         (finish_command): Update.
2313         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2314         Add constructor.
2315         (call_thread_fsm_ops): Remove.
2316         (call_thread_fsm::call_thread_fsm): Rename from
2317         new_call_thread_fsm.
2318         (call_thread_fsm::should_stop): Rename from
2319         call_thread_fsm_should_stop.
2320         (call_thread_fsm::should_notify_stop): Rename from
2321         call_thread_fsm_should_notify_stop.
2322         (run_inferior_call, call_function_by_hand_dummy): Update.
2323         * cli/cli-interp.c (should_print_stop_to_console): Update.
2324         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2325         Add constructor.  Change type of location_breakpoint,
2326         caller_breakpoint.
2327         (until_break_fsm_ops): Remove.
2328         (new_until_break_fsm): Remove.
2329         (until_break_fsm::should_stop): Rename from
2330         until_break_fsm_should_stop.
2331         (until_break_fsm::clean_up): Rename from
2332         until_break_fsm_clean_up.
2333         (until_break_fsm::do_async_reply_reason): Rename from
2334         until_break_fsm_async_reply_reason.
2335         (until_break_command): Update.
2336         * thread-fsm.c: Remove.
2337         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2338
2339 2019-02-07  Tom Tromey  <tom@tromey.com>
2340
2341         * yy-remap.h: Add include guard.
2342         * xtensa-tdep.h: Add include guard.
2343         * xcoffread.h: Rename include guard.
2344         * varobj-iter.h: Add include guard.
2345         * tui/tui.h: Rename include guard.
2346         * tui/tui-winsource.h: Rename include guard.
2347         * tui/tui-wingeneral.h: Rename include guard.
2348         * tui/tui-windata.h: Rename include guard.
2349         * tui/tui-win.h: Rename include guard.
2350         * tui/tui-stack.h: Rename include guard.
2351         * tui/tui-source.h: Rename include guard.
2352         * tui/tui-regs.h: Rename include guard.
2353         * tui/tui-out.h: Rename include guard.
2354         * tui/tui-layout.h: Rename include guard.
2355         * tui/tui-io.h: Rename include guard.
2356         * tui/tui-hooks.h: Rename include guard.
2357         * tui/tui-file.h: Rename include guard.
2358         * tui/tui-disasm.h: Rename include guard.
2359         * tui/tui-data.h: Rename include guard.
2360         * tui/tui-command.h: Rename include guard.
2361         * tic6x-tdep.h: Add include guard.
2362         * target/waitstatus.h: Rename include guard.
2363         * target/wait.h: Rename include guard.
2364         * target/target.h: Rename include guard.
2365         * target/resume.h: Rename include guard.
2366         * target-float.h: Rename include guard.
2367         * stabsread.h: Add include guard.
2368         * rs6000-tdep.h: Add include guard.
2369         * riscv-fbsd-tdep.h: Add include guard.
2370         * regformats/regdef.h: Rename include guard.
2371         * record.h: Rename include guard.
2372         * python/python.h: Rename include guard.
2373         * python/python-internal.h: Rename include guard.
2374         * python/py-stopevent.h: Rename include guard.
2375         * python/py-ref.h: Rename include guard.
2376         * python/py-record.h: Rename include guard.
2377         * python/py-record-full.h: Rename include guard.
2378         * python/py-record-btrace.h: Rename include guard.
2379         * python/py-instruction.h: Rename include guard.
2380         * python/py-events.h: Rename include guard.
2381         * python/py-event.h: Rename include guard.
2382         * procfs.h: Add include guard.
2383         * proc-utils.h: Add include guard.
2384         * p-lang.h: Add include guard.
2385         * or1k-tdep.h: Rename include guard.
2386         * observable.h: Rename include guard.
2387         * nto-tdep.h: Rename include guard.
2388         * nat/x86-linux.h: Rename include guard.
2389         * nat/x86-linux-dregs.h: Rename include guard.
2390         * nat/x86-gcc-cpuid.h: Add include guard.
2391         * nat/x86-dregs.h: Rename include guard.
2392         * nat/x86-cpuid.h: Rename include guard.
2393         * nat/ppc-linux.h: Rename include guard.
2394         * nat/mips-linux-watch.h: Rename include guard.
2395         * nat/linux-waitpid.h: Rename include guard.
2396         * nat/linux-ptrace.h: Rename include guard.
2397         * nat/linux-procfs.h: Rename include guard.
2398         * nat/linux-osdata.h: Rename include guard.
2399         * nat/linux-nat.h: Rename include guard.
2400         * nat/linux-namespaces.h: Rename include guard.
2401         * nat/linux-btrace.h: Rename include guard.
2402         * nat/glibc_thread_db.h: Rename include guard.
2403         * nat/gdb_thread_db.h: Rename include guard.
2404         * nat/gdb_ptrace.h: Rename include guard.
2405         * nat/fork-inferior.h: Rename include guard.
2406         * nat/amd64-linux-siginfo.h: Rename include guard.
2407         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2408         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2409         * nat/aarch64-linux.h: Rename include guard.
2410         * nat/aarch64-linux-hw-point.h: Rename include guard.
2411         * mn10300-tdep.h: Add include guard.
2412         * mips-linux-tdep.h: Add include guard.
2413         * mi/mi-parse.h: Rename include guard.
2414         * mi/mi-out.h: Rename include guard.
2415         * mi/mi-main.h: Rename include guard.
2416         * mi/mi-interp.h: Rename include guard.
2417         * mi/mi-getopt.h: Rename include guard.
2418         * mi/mi-console.h: Rename include guard.
2419         * mi/mi-common.h: Rename include guard.
2420         * mi/mi-cmds.h: Rename include guard.
2421         * mi/mi-cmd-break.h: Rename include guard.
2422         * m2-lang.h: Add include guard.
2423         * location.h: Rename include guard.
2424         * linux-record.h: Rename include guard.
2425         * linux-nat.h: Add include guard.
2426         * linux-fork.h: Add include guard.
2427         * i386-darwin-tdep.h: Rename include guard.
2428         * hppa-linux-offsets.h: Add include guard.
2429         * guile/guile.h: Rename include guard.
2430         * guile/guile-internal.h: Rename include guard.
2431         * gnu-nat.h: Rename include guard.
2432         * gdb-stabs.h: Rename include guard.
2433         * frv-tdep.h: Add include guard.
2434         * f-lang.h: Add include guard.
2435         * event-loop.h: Add include guard.
2436         * darwin-nat.h: Rename include guard.
2437         * cp-abi.h: Rename include guard.
2438         * config/sparc/nm-sol2.h: Rename include guard.
2439         * config/nm-nto.h: Rename include guard.
2440         * config/nm-linux.h: Add include guard.
2441         * config/i386/nm-i386gnu.h: Rename include guard.
2442         * config/djgpp/nl_types.h: Rename include guard.
2443         * config/djgpp/langinfo.h: Rename include guard.
2444         * compile/gcc-cp-plugin.h: Add include guard.
2445         * compile/gcc-c-plugin.h: Add include guard.
2446         * compile/compile.h: Rename include guard.
2447         * compile/compile-object-run.h: Rename include guard.
2448         * compile/compile-object-load.h: Rename include guard.
2449         * compile/compile-internal.h: Rename include guard.
2450         * compile/compile-cplus.h: Rename include guard.
2451         * compile/compile-c.h: Rename include guard.
2452         * common/xml-utils.h: Rename include guard.
2453         * common/x86-xstate.h: Rename include guard.
2454         * common/version.h: Rename include guard.
2455         * common/vec.h: Rename include guard.
2456         * common/tdesc.h: Rename include guard.
2457         * common/selftest.h: Rename include guard.
2458         * common/scoped_restore.h: Rename include guard.
2459         * common/scoped_mmap.h: Rename include guard.
2460         * common/scoped_fd.h: Rename include guard.
2461         * common/safe-iterator.h: Rename include guard.
2462         * common/run-time-clock.h: Rename include guard.
2463         * common/refcounted-object.h: Rename include guard.
2464         * common/queue.h: Rename include guard.
2465         * common/ptid.h: Rename include guard.
2466         * common/print-utils.h: Rename include guard.
2467         * common/preprocessor.h: Rename include guard.
2468         * common/pathstuff.h: Rename include guard.
2469         * common/observable.h: Rename include guard.
2470         * common/netstuff.h: Rename include guard.
2471         * common/job-control.h: Rename include guard.
2472         * common/host-defs.h: Rename include guard.
2473         * common/gdb_wait.h: Rename include guard.
2474         * common/gdb_vecs.h: Rename include guard.
2475         * common/gdb_unlinker.h: Rename include guard.
2476         * common/gdb_unique_ptr.h: Rename include guard.
2477         * common/gdb_tilde_expand.h: Rename include guard.
2478         * common/gdb_sys_time.h: Rename include guard.
2479         * common/gdb_string_view.h: Rename include guard.
2480         * common/gdb_splay_tree.h: Rename include guard.
2481         * common/gdb_setjmp.h: Rename include guard.
2482         * common/gdb_ref_ptr.h: Rename include guard.
2483         * common/gdb_optional.h: Rename include guard.
2484         * common/gdb_locale.h: Rename include guard.
2485         * common/gdb_assert.h: Rename include guard.
2486         * common/filtered-iterator.h: Rename include guard.
2487         * common/filestuff.h: Rename include guard.
2488         * common/fileio.h: Rename include guard.
2489         * common/environ.h: Rename include guard.
2490         * common/common-utils.h: Rename include guard.
2491         * common/common-types.h: Rename include guard.
2492         * common/common-regcache.h: Rename include guard.
2493         * common/common-inferior.h: Rename include guard.
2494         * common/common-gdbthread.h: Rename include guard.
2495         * common/common-exceptions.h: Rename include guard.
2496         * common/common-defs.h: Rename include guard.
2497         * common/common-debug.h: Rename include guard.
2498         * common/cleanups.h: Rename include guard.
2499         * common/buffer.h: Rename include guard.
2500         * common/btrace-common.h: Rename include guard.
2501         * common/break-common.h: Rename include guard.
2502         * cli/cli-utils.h: Rename include guard.
2503         * cli/cli-style.h: Rename include guard.
2504         * cli/cli-setshow.h: Rename include guard.
2505         * cli/cli-script.h: Rename include guard.
2506         * cli/cli-interp.h: Rename include guard.
2507         * cli/cli-decode.h: Rename include guard.
2508         * cli/cli-cmds.h: Rename include guard.
2509         * charset-list.h: Add include guard.
2510         * buildsym-legacy.h: Rename include guard.
2511         * bfin-tdep.h: Add include guard.
2512         * ax.h: Rename include guard.
2513         * arm-linux-tdep.h: Add include guard.
2514         * arm-fbsd-tdep.h: Add include guard.
2515         * arch/xtensa.h: Rename include guard.
2516         * arch/tic6x.h: Add include guard.
2517         * arch/i386.h: Add include guard.
2518         * arch/arm.h: Rename include guard.
2519         * arch/arm-linux.h: Rename include guard.
2520         * arch/arm-get-next-pcs.h: Rename include guard.
2521         * arch/amd64.h: Add include guard.
2522         * arch/aarch64-insn.h: Rename include guard.
2523         * arch-utils.h: Rename include guard.
2524         * annotate.h: Add include guard.
2525         * amd64-darwin-tdep.h: Rename include guard.
2526         * aarch64-linux-tdep.h: Add include guard.
2527         * aarch64-fbsd-tdep.h: Add include guard.
2528         * aarch32-linux-nat.h: Add include guard.
2529
2530 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2531
2532         * macrotab.c (macro_define_internal): New function that
2533         factorizes macro_define_object_internal and macro_define_function
2534         code.
2535         (macro_define_object_internal): Use macro_define_internal.
2536         (macro_define_function): Likewise.
2537
2538 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2539
2540         * macrocmd.c (extract_identifier): Return
2541         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2542         callers.
2543
2544 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2545
2546         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2547
2548 2019-02-05  Tom Tromey  <tom@tromey.com>
2549
2550         * target.c (target_stack::unpush): Move assertion earlier.
2551
2552 2019-01-30  Tom Tromey  <tom@tromey.com>
2553
2554         PR python/23615:
2555         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2556         (gdbpy_parse_and_eval): Likewise.
2557         * python/python-internal.h (gdbpy_allow_threads): New class.
2558
2559 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2560
2561         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2562         (aarch64_fbsd_fpregmap): Move earlier.
2563         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2564         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2565         instead of individual calls to trad_frame_set_reg_addr.
2566         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2567         earlier.
2568         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2569         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2570         instead of individual calls to trad_frame_set_reg_addr.
2571
2572 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2573
2574         * CONTRIBUTE: Replace contribution list with wiki link.
2575
2576 2019-01-25  Tom Tromey  <tom@tromey.com>
2577
2578         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2579
2580 2019-01-25  Tom Tromey  <tom@tromey.com>
2581
2582         * xtensa-linux-nat.c: Fix common/ includes.
2583         * xml-support.h: Fix common/ includes.
2584         * xml-support.c: Fix common/ includes.
2585         * x86-linux-nat.c: Fix common/ includes.
2586         * windows-nat.c: Fix common/ includes.
2587         * varobj.h: Fix common/ includes.
2588         * varobj.c: Fix common/ includes.
2589         * value.c: Fix common/ includes.
2590         * valops.c: Fix common/ includes.
2591         * utils.c: Fix common/ includes.
2592         * unittests/xml-utils-selftests.c: Fix common/ includes.
2593         * unittests/utils-selftests.c: Fix common/ includes.
2594         * unittests/unpack-selftests.c: Fix common/ includes.
2595         * unittests/tracepoint-selftests.c: Fix common/ includes.
2596         * unittests/style-selftests.c: Fix common/ includes.
2597         * unittests/string_view-selftests.c: Fix common/ includes.
2598         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2599         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2600         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2601         * unittests/rsp-low-selftests.c: Fix common/ includes.
2602         * unittests/parse-connection-spec-selftests.c: Fix common/
2603         includes.
2604         * unittests/optional-selftests.c: Fix common/ includes.
2605         * unittests/offset-type-selftests.c: Fix common/ includes.
2606         * unittests/observable-selftests.c: Fix common/ includes.
2607         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2608         * unittests/memrange-selftests.c: Fix common/ includes.
2609         * unittests/memory-map-selftests.c: Fix common/ includes.
2610         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2611         * unittests/function-view-selftests.c: Fix common/ includes.
2612         * unittests/environ-selftests.c: Fix common/ includes.
2613         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2614         * unittests/common-utils-selftests.c: Fix common/ includes.
2615         * unittests/cli-utils-selftests.c: Fix common/ includes.
2616         * unittests/array-view-selftests.c: Fix common/ includes.
2617         * ui-file.c: Fix common/ includes.
2618         * tui/tui-io.c: Fix common/ includes.
2619         * tracepoint.h: Fix common/ includes.
2620         * tracepoint.c: Fix common/ includes.
2621         * tracefile-tfile.c: Fix common/ includes.
2622         * top.h: Fix common/ includes.
2623         * top.c: Fix common/ includes.
2624         * thread.c: Fix common/ includes.
2625         * target/waitstatus.h: Fix common/ includes.
2626         * target/waitstatus.c: Fix common/ includes.
2627         * target.h: Fix common/ includes.
2628         * target.c: Fix common/ includes.
2629         * target-memory.c: Fix common/ includes.
2630         * target-descriptions.c: Fix common/ includes.
2631         * symtab.h: Fix common/ includes.
2632         * symfile.c: Fix common/ includes.
2633         * stap-probe.c: Fix common/ includes.
2634         * spu-linux-nat.c: Fix common/ includes.
2635         * sparc-nat.c: Fix common/ includes.
2636         * source.c: Fix common/ includes.
2637         * solib.c: Fix common/ includes.
2638         * solib-target.c: Fix common/ includes.
2639         * ser-unix.c: Fix common/ includes.
2640         * ser-tcp.c: Fix common/ includes.
2641         * ser-pipe.c: Fix common/ includes.
2642         * ser-base.c: Fix common/ includes.
2643         * selftest-arch.c: Fix common/ includes.
2644         * s12z-tdep.c: Fix common/ includes.
2645         * rust-exp.y: Fix common/ includes.
2646         * rs6000-aix-tdep.c: Fix common/ includes.
2647         * riscv-tdep.c: Fix common/ includes.
2648         * remote.c: Fix common/ includes.
2649         * remote-notif.h: Fix common/ includes.
2650         * remote-fileio.h: Fix common/ includes.
2651         * remote-fileio.c: Fix common/ includes.
2652         * regcache.h: Fix common/ includes.
2653         * regcache.c: Fix common/ includes.
2654         * record-btrace.c: Fix common/ includes.
2655         * python/python.c: Fix common/ includes.
2656         * python/py-type.c: Fix common/ includes.
2657         * python/py-inferior.c: Fix common/ includes.
2658         * progspace.h: Fix common/ includes.
2659         * producer.c: Fix common/ includes.
2660         * procfs.c: Fix common/ includes.
2661         * proc-api.c: Fix common/ includes.
2662         * printcmd.c: Fix common/ includes.
2663         * ppc-linux-nat.c: Fix common/ includes.
2664         * parser-defs.h: Fix common/ includes.
2665         * osdata.c: Fix common/ includes.
2666         * obsd-nat.c: Fix common/ includes.
2667         * nat/x86-linux.c: Fix common/ includes.
2668         * nat/x86-linux-dregs.c: Fix common/ includes.
2669         * nat/x86-dregs.h: Fix common/ includes.
2670         * nat/x86-dregs.c: Fix common/ includes.
2671         * nat/ppc-linux.c: Fix common/ includes.
2672         * nat/mips-linux-watch.h: Fix common/ includes.
2673         * nat/mips-linux-watch.c: Fix common/ includes.
2674         * nat/linux-waitpid.c: Fix common/ includes.
2675         * nat/linux-ptrace.h: Fix common/ includes.
2676         * nat/linux-ptrace.c: Fix common/ includes.
2677         * nat/linux-procfs.c: Fix common/ includes.
2678         * nat/linux-personality.c: Fix common/ includes.
2679         * nat/linux-osdata.c: Fix common/ includes.
2680         * nat/linux-namespaces.c: Fix common/ includes.
2681         * nat/linux-btrace.h: Fix common/ includes.
2682         * nat/linux-btrace.c: Fix common/ includes.
2683         * nat/fork-inferior.c: Fix common/ includes.
2684         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2685         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2686         * nat/aarch64-linux.c: Fix common/ includes.
2687         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2688         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2689         * namespace.h: Fix common/ includes.
2690         * mips-linux-tdep.c: Fix common/ includes.
2691         * minsyms.c: Fix common/ includes.
2692         * mi/mi-parse.h: Fix common/ includes.
2693         * mi/mi-main.c: Fix common/ includes.
2694         * mi/mi-cmd-env.c: Fix common/ includes.
2695         * memrange.h: Fix common/ includes.
2696         * memattr.c: Fix common/ includes.
2697         * maint.h: Fix common/ includes.
2698         * maint.c: Fix common/ includes.
2699         * main.c: Fix common/ includes.
2700         * machoread.c: Fix common/ includes.
2701         * location.c: Fix common/ includes.
2702         * linux-thread-db.c: Fix common/ includes.
2703         * linux-nat.c: Fix common/ includes.
2704         * linux-fork.c: Fix common/ includes.
2705         * inline-frame.c: Fix common/ includes.
2706         * infrun.c: Fix common/ includes.
2707         * inflow.c: Fix common/ includes.
2708         * inferior.h: Fix common/ includes.
2709         * inferior.c: Fix common/ includes.
2710         * infcmd.c: Fix common/ includes.
2711         * inf-ptrace.c: Fix common/ includes.
2712         * inf-child.c: Fix common/ includes.
2713         * ia64-linux-nat.c: Fix common/ includes.
2714         * i387-tdep.c: Fix common/ includes.
2715         * i386-tdep.c: Fix common/ includes.
2716         * i386-linux-tdep.c: Fix common/ includes.
2717         * i386-linux-nat.c: Fix common/ includes.
2718         * i386-go32-tdep.c: Fix common/ includes.
2719         * i386-fbsd-tdep.c: Fix common/ includes.
2720         * i386-fbsd-nat.c: Fix common/ includes.
2721         * guile/scm-type.c: Fix common/ includes.
2722         * guile/guile.c: Fix common/ includes.
2723         * go32-nat.c: Fix common/ includes.
2724         * gnu-nat.c: Fix common/ includes.
2725         * gdbthread.h: Fix common/ includes.
2726         * gdbarch-selftests.c: Fix common/ includes.
2727         * gdb_usleep.c: Fix common/ includes.
2728         * gdb_select.h: Fix common/ includes.
2729         * gdb_bfd.c: Fix common/ includes.
2730         * gcore.c: Fix common/ includes.
2731         * fork-child.c: Fix common/ includes.
2732         * findvar.c: Fix common/ includes.
2733         * fbsd-nat.c: Fix common/ includes.
2734         * event-top.c: Fix common/ includes.
2735         * event-loop.c: Fix common/ includes.
2736         * dwarf2read.c: Fix common/ includes.
2737         * dwarf2loc.c: Fix common/ includes.
2738         * dwarf2-frame.c: Fix common/ includes.
2739         * dwarf-index-cache.c: Fix common/ includes.
2740         * dtrace-probe.c: Fix common/ includes.
2741         * disasm-selftests.c: Fix common/ includes.
2742         * defs.h: Fix common/ includes.
2743         * csky-tdep.c: Fix common/ includes.
2744         * cp-valprint.c: Fix common/ includes.
2745         * cp-support.h: Fix common/ includes.
2746         * cp-support.c: Fix common/ includes.
2747         * corelow.c: Fix common/ includes.
2748         * completer.h: Fix common/ includes.
2749         * completer.c: Fix common/ includes.
2750         * compile/compile.c: Fix common/ includes.
2751         * compile/compile-loc2c.c: Fix common/ includes.
2752         * compile/compile-cplus-types.c: Fix common/ includes.
2753         * compile/compile-cplus-symbols.c: Fix common/ includes.
2754         * command.h: Fix common/ includes.
2755         * cli/cli-dump.c: Fix common/ includes.
2756         * cli/cli-cmds.c: Fix common/ includes.
2757         * charset.c: Fix common/ includes.
2758         * build-id.c: Fix common/ includes.
2759         * btrace.h: Fix common/ includes.
2760         * btrace.c: Fix common/ includes.
2761         * breakpoint.h: Fix common/ includes.
2762         * breakpoint.c: Fix common/ includes.
2763         * ax.h:
2764         (enum agent_op): Fix common/ includes.
2765         * ax-general.c (struct aop_map): Fix common/ includes.
2766         * ax-gdb.c: Fix common/ includes.
2767         * auxv.c: Fix common/ includes.
2768         * auto-load.c: Fix common/ includes.
2769         * arm-tdep.c: Fix common/ includes.
2770         * arch/riscv.c: Fix common/ includes.
2771         * arch/ppc-linux-common.c: Fix common/ includes.
2772         * arch/i386.c: Fix common/ includes.
2773         * arch/arm.c: Fix common/ includes.
2774         * arch/arm-linux.c: Fix common/ includes.
2775         * arch/arm-get-next-pcs.c: Fix common/ includes.
2776         * arch/amd64.c: Fix common/ includes.
2777         * arch/aarch64.c: Fix common/ includes.
2778         * arch/aarch64-insn.c: Fix common/ includes.
2779         * arch-utils.c: Fix common/ includes.
2780         * amd64-windows-tdep.c: Fix common/ includes.
2781         * amd64-tdep.c: Fix common/ includes.
2782         * amd64-sol2-tdep.c: Fix common/ includes.
2783         * amd64-obsd-tdep.c: Fix common/ includes.
2784         * amd64-nbsd-tdep.c: Fix common/ includes.
2785         * amd64-linux-tdep.c: Fix common/ includes.
2786         * amd64-linux-nat.c: Fix common/ includes.
2787         * amd64-fbsd-tdep.c: Fix common/ includes.
2788         * amd64-fbsd-nat.c: Fix common/ includes.
2789         * amd64-dicos-tdep.c: Fix common/ includes.
2790         * amd64-darwin-tdep.c: Fix common/ includes.
2791         * agent.c: Fix common/ includes.
2792         * ada-lang.h: Fix common/ includes.
2793         * ada-lang.c: Fix common/ includes.
2794         * aarch64-tdep.c: Fix common/ includes.
2795
2796 2019-01-25  Tom Tromey  <tom@tromey.com>
2797
2798         * common/create-version.sh: Use common/version.h.
2799
2800 2019-01-24  Pedro Alves  <palves@redhat.com>
2801
2802         * infrun.c (signal_stop, signal_print, signal_program)
2803         (signal_catch, signal_pass): Now arrays instead of pointers.
2804         (update_signals_program_target, do_target_resume)
2805         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2806         * linux-nat.c (linux_nat_target::pass_signals)
2807         (linux_nat_target::create_inferior, linux_nat_target::attach):
2808         Adjust.
2809         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2810         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2811         * procfs.c (procfs_target::pass_signals): Adjust.
2812         * record-full.c (record_full_target::resume): Adjust.
2813         * remote.c (remote_target::pass_signals)
2814         (remote_target::program_signals): Adjust.
2815         * target-debug.h (target_debug_print_signals): Now takes a
2816         gdb::array_view as parameter.  Adjust.
2817         * target.h (target_ops) <pass_signals, program_signals>: Replace
2818         pointer and length parameters with gdb::array_view.
2819         (target_pass_signals, target_program_signals): Likewise.
2820         * target-delegates.c: Regenerate.
2821
2822 2019-01-24  Pedro Alves  <palves@redhat.com>
2823
2824         * common/forward-scope-exit.h
2825         (forward_scope_exit::forward_scope_exit): Pass arguments to
2826         m_bind_function directly, instead of creating a std::bind and
2827         copying that.
2828
2829 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2830
2831         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2832         for static members.
2833         (pass_in_v_vfp_candidate): Likewise.
2834
2835 2019-01-23  Tom Tromey  <tom@tromey.com>
2836             Pedro Alves  <palves@redhat.com>
2837
2838         * regcache.c (class regcache_invalidator): Remove.
2839         (regcache::raw_write): Use make_scope_exit.
2840
2841 2019-01-23  Tom Tromey  <tom@tromey.com>
2842
2843         * ui-out.h (class ui_out_emit_type): Update comment.
2844
2845 2019-01-23  Tom Tromey  <tom@tromey.com>
2846
2847         * infrun.c (fetch_inferior_event): Update comment.
2848
2849 2019-01-23  Tom Tromey  <tom@tromey.com>
2850             Pedro Alves  <palves@redhat.com>
2851
2852         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2853         parameter.
2854         (fetch_inferior_event): Use SCOPE_EXIT.
2855
2856
2857 2019-01-23  Tom Tromey  <tom@tromey.com>
2858             Pedro Alves  <palves@redhat.com>
2859
2860         * infrun.c (disable_thread_events): Delete.
2861         (stop_all_threads): Use SCOPE_EXIT.
2862
2863 2019-01-23  Tom Tromey  <tom@tromey.com>
2864             Pedro Alves  <palves@redhat.com>
2865
2866         * symfile.c: Include forward-scope-exit.h.
2867         (clear_symtab_users_cleanup): Replace forward declaration with
2868         a FORWARD_SCOPE_EXIT.
2869         (syms_from_objfile_1): Use the forward_scope_exit and
2870         gdb::optional instead of cleanup_function.
2871         (reread_symbols): Use the forward_scope_exit instead of
2872         cleanup_function.
2873         (clear_symtab_users_cleanup): Remove function.
2874
2875 2019-01-23  Tom Tromey  <tom@tromey.com>
2876             Pedro Alves  <palves@redhat.com>
2877
2878         * linux-nat.c: Include scope-exit.h.
2879         (cleanup_target_stop): Remove.
2880         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2881         SCOPE_EXIT.
2882
2883 2019-01-23  Tom Tromey  <tom@tromey.com>
2884             Pedro Alves  <palves@redhat.com>
2885
2886         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2887         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2888
2889 2019-01-23  Tom Tromey  <tom@tromey.com>
2890             Andrew Burgess  <andrew.burgess@embecosm.com>
2891             Pedro Alves  <palves@redhat.com>
2892
2893         * infrun.c (fetch_inferior_event): Use scope_exit.
2894         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2895         * top.c (execute_command): Use scope_exit.
2896         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2897         * utils.c (do_bpstat_clear_actions_cleanup)
2898         (make_bpstat_clear_actions_cleanup): Remove.
2899
2900 2019-01-23  Tom Tromey  <tom@tromey.com>
2901             Pedro Alves  <palves@redhat.com>
2902
2903         * infrun.c: Include "common/scope-exit.h"
2904         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2905         (wait_for_inferior): Use SCOPE_EXIT.
2906         (fetch_inferior_event): Use scope_exit.
2907
2908 2019-01-23  Tom Tromey  <tom@tromey.com>
2909             Pedro Alves  <palves@redhat.com>
2910
2911         * breakpoint.c (create_breakpoint): Remove cleanup.
2912
2913 2019-01-23  Tom Tromey  <tom@tromey.com>
2914             Andrew Burgess  <andrew.burgess@embecosm.com>
2915             Pedro Alves  <palves@redhat.com>
2916
2917 2019-01-23  Pedro Alves  <palves@redhat.com>
2918
2919         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2920
2921 2019-01-23  Pedro Alves  <palves@redhat.com>
2922             Andrew Burgess  <andrew.burgess@embecosm.com>
2923
2924         * gdbthread.h: Include "common/forward-scope-exit.h".
2925         (scoped_finish_thread_state): Redefine custom class in terms of
2926         forward_scope_exit.
2927
2928 2019-01-23  Pedro Alves  <palves@redhat.com>
2929             Andrew Burgess  <andrew.burgess@embecosm.com>
2930
2931         * common/forward-scope-exit.h: New file.
2932
2933 2019-01-23  Pedro Alves  <palves@redhat.com>
2934             Andrew Burgess  <andrew.burgess@embecosm.com>
2935             Tom Tromey  <tom@tromey.com>
2936
2937         * common/scope-exit.h: New file.
2938
2939 2019-01-23  Pedro Alves  <palves@redhat.com>
2940
2941         * common/preprocessor.h (ESC): Rename to ...
2942         (ESC_PARENS): ... this.
2943         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2944         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2945
2946 2019-01-23  Tom Tromey  <tom@tromey.com>
2947
2948         * language.h (class scoped_switch_to_sym_language_if_auto):
2949         Initialize m_lang in both cases.
2950
2951 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2952
2953         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2954         with XCNEW.
2955
2956 2019-01-22  Tom Tromey  <tom@tromey.com>
2957
2958         * corelow.c: Do not include sys/file.h.
2959
2960 2019-01-22  Tom Tromey  <tom@tromey.com>
2961
2962         * tui/tui-wingeneral.h: Include gdb_curses.h.
2963
2964 2019-01-22  Tom Tromey  <tom@tromey.com>
2965
2966         * source-cache.h (class source_cache) <get_source_lines,
2967         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2968
2969 2019-01-22  Tom Tromey  <tom@tromey.com>
2970
2971         * remote-fileio.h (struct remote_target): Declare.
2972
2973 2019-01-22  Tom Tromey  <tom@tromey.com>
2974
2975         * python/py-arch.c: Do not include py-ref.h.
2976         * python/py-bpevent.c: Do not include py-ref.h.
2977         * python/py-cmd.c: Do not include py-ref.h.
2978         * python/py-continueevent.c: Do not include py-ref.h.
2979         * python/py-event.h: Do not include py-ref.h.
2980         * python/py-evtregistry.c: Do not include py-ref.h.
2981         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2982         * python/py-frame.c: Do not include py-ref.h.
2983         * python/py-framefilter.c: Do not include py-ref.h.
2984         * python/py-function.c: Do not include py-ref.h.
2985         * python/py-infevents.c: Do not include py-ref.h.
2986         * python/py-linetable.c: Do not include py-ref.h.
2987         * python/py-objfile.c: Do not include py-ref.h.
2988         * python/py-param.c: Do not include py-ref.h.
2989         * python/py-prettyprint.c: Do not include py-ref.h.
2990         * python/py-progspace.c: Do not include py-ref.h.
2991         * python/py-symbol.c: Do not include py-ref.h.
2992         * python/py-symtab.c: Do not include py-ref.h.
2993         * python/py-type.c: Do not include py-ref.h.
2994         * python/py-unwind.c: Do not include py-ref.h.
2995         * python/py-utils.c: Do not include py-ref.h.
2996         * python/py-value.c: Do not include py-ref.h.
2997         * python/py-varobj.c: Do not include py-ref.h.
2998         * python/py-xmethods.c: Do not include py-ref.h.
2999         * python/python.c: Do not include py-ref.h.
3000         * varobj.c: Do not include py-ref.h.
3001
3002 2019-01-22  Tom Tromey  <tom@tromey.com>
3003
3004         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3005         keyword for bcache.
3006
3007 2019-01-22  Tom Tromey  <tom@tromey.com>
3008
3009         * compile/compile-cplus-types.c: Remove a comment by #include.
3010
3011 2019-01-22  Tom Tromey  <tom@tromey.com>
3012
3013         * compile/gcc-c-plugin.h: Include compile-internal.h.
3014
3015 2019-01-22  Tom Tromey  <tom@tromey.com>
3016
3017         * stabsread.c (EXTERN): Do not define.
3018         (symnum, next_symbol_text_func, processing_gcc_compilation)
3019         (within_function, global_sym_chain, global_stabs)
3020         (previous_stab_code, this_object_header_files)
3021         (n_this_object_header_files)
3022         (n_allocated_this_object_header_files): Define.
3023         * stabsread.h (EXTERN): Never define.  Use "extern".
3024
3025 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3026
3027         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3028         history_value.
3029
3030 2019-01-21  Tom Tromey  <tom@tromey.com>
3031
3032         * ui-out.c: Fix includes.
3033         * tui/tui-source.c: Fix includes.
3034         * target.c: Fix includes.
3035         * remote.c: Fix includes.
3036         * regcache.c: Fix includes.
3037         * python/py-block.c: Fix includes.
3038         * printcmd.c: Fix includes.
3039         * or1k-tdep.c: Fix includes.
3040         * mi/mi-main.c: Fix includes.
3041         * m32r-tdep.c: Fix includes.
3042         * csky-tdep.c: Fix includes.
3043         * compile/compile-cplus-types.c: Fix includes.
3044         * cli/cli-interp.c: Fix includes.
3045
3046 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3047
3048         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3049         for padding.
3050
3051 2019-01-16  Tom Tromey  <tom@tromey.com>
3052
3053         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3054         earlier.
3055         (struct objfile) <msymbols_range>: Move from top level.
3056         <msymbols>: New method.
3057         (class objfile_msymbols): Remove.
3058         * symtab.c (default_collect_symbol_completion_matches_break_on):
3059         Update.
3060         * symmisc.c (dump_msymbols): Update.
3061         * stabsread.c (scan_file_globals): Update.
3062         * objc-lang.c (info_selectors_command, info_classes_command)
3063         (find_methods): Update.
3064         * minsyms.c (find_solib_trampoline_target): Update.
3065         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3066         * coffread.c (coff_symfile_read): Update.
3067         * ada-lang.c (ada_lookup_simple_minsym)
3068         (ada_collect_symbol_completion_matches): Update.
3069
3070 2019-01-16  Tom Tromey  <tom@tromey.com>
3071
3072         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3073         type.  Remove no-argument constructor.
3074         <iterator::operator++>: Simplify.
3075         <begin>: Update.
3076         <end>: Use minimal_symbol_count.
3077
3078 2019-01-16  Tom Tromey  <tom@tromey.com>
3079
3080         * objfiles.h (struct objfile) <psymtabs>: New method.
3081         (class objfile_psymtabs): Remove.
3082         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3083         typedef.
3084         <range>: New method.
3085         (require_partial_symbols): Change return type.
3086         * psymtab.c (require_partial_symbols)
3087         (psym_expand_symtabs_matching): Update.
3088         * mdebugread.c (parse_partial_symbols): Update.
3089         * dbxread.c (dbx_end_psymtab): Update.
3090
3091 2019-01-15  Tom Tromey  <tom@tromey.com>
3092
3093         * symtab.c (lookup_objfile_from_block)
3094         (lookup_symbol_in_objfile_symtabs)
3095         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3096         (find_line_symtab, info_sources_command)
3097         (default_collect_symbol_completion_matches_break_on)
3098         (make_source_files_completion_list): Update.
3099         * symmisc.c (print_objfile_statistics, dump_objfile)
3100         (maintenance_print_symbols, maintenance_info_symtabs)
3101         (maintenance_check_symtabs, maintenance_info_line_tables):
3102         Update.
3103         * source.c (select_source_symtab)
3104         (forget_cached_source_info_for_objfile): Update.
3105         * objfiles.h (class objfile_compunits): Remove.
3106         (struct objfile) <compunits_range>: New typedef.
3107         (compunits): New method.
3108         * objfiles.c (objfile_relocate1): Update.
3109         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3110         * maint.c (count_symtabs_and_blocks): Update.
3111         * linespec.c (iterate_over_all_matching_symtabs): Update.
3112         * cp-support.c (add_symbol_overload_list_qualified): Update.
3113         * coffread.c (coff_symtab_read): Update.
3114         * ada-lang.c (add_nonlocal_symbols)
3115         (ada_collect_symbol_completion_matches)
3116         (ada_add_global_exceptions): Update.
3117
3118 2019-01-15  Tom Tromey  <tom@tromey.com>
3119
3120         * progspace.h (program_space) <objfiles_safe_range>: New
3121         typedef.
3122         <objfiles_safe>: New method.
3123         * objfiles.h (class all_objfiles_safe): Remove.
3124         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3125         * jit.c (jit_inferior_exit_hook): Update.
3126
3127 2019-01-17  Tom Tromey  <tom@tromey.com>
3128
3129         * progspace.h (program_space) <objfiles_range>: New typedef.
3130         <objfiles>: New method.
3131         <objfiles_head>: Rename from objfiles.
3132         (object_files): Update.
3133         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3134         * guile/scm-pretty-print.c
3135         (ppscm_find_pretty_printer_from_objfiles): Update.
3136         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3137         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3138         Update.
3139         * python/py-progspace.c (pspy_get_objfiles): Update.
3140         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3141         Update.
3142         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3143         (objfpy_lookup_objfile_by_build_id): Update.
3144         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3145         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3146         Update.
3147         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3148         (expand_symtab_containing_pc, lookup_objfile_from_block)
3149         (lookup_static_symbol, basic_lookup_transparent_type)
3150         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3151         (find_line_symtab, info_sources_command)
3152         (default_collect_symbol_completion_matches_break_on)
3153         (make_source_files_completion_list, find_main_name): Update.
3154         * symmisc.c (print_symbol_bcache_statistics)
3155         (print_objfile_statistics, maintenance_print_symbols)
3156         (maintenance_print_msymbols, maintenance_print_objfiles)
3157         (maintenance_info_symtabs, maintenance_check_symtabs)
3158         (maintenance_expand_symtabs, maintenance_info_line_tables):
3159         Update.
3160         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3161         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3162         (map_overlay_command, unmap_overlay_command)
3163         (simple_overlay_update, expand_symtabs_matching)
3164         (map_symbol_filenames): Update.
3165         * symfile-debug.c (set_debug_symfile): Update.
3166         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3167         Update.
3168         * source.c (select_source_symtab, forget_cached_source_info):
3169         Update.
3170         * solib.c (solib_read_symbols): Update.
3171         * solib-spu.c (append_ocl_sos): Update.
3172         * psymtab.c (maintenance_print_psymbols)
3173         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3174         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3175         * printcmd.c (info_symbol_command): Update.
3176         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3177         Update.
3178         * objfiles.h (class all_objfiles): Remove.
3179         * objfiles.c (have_partial_symbols, have_full_symbols)
3180         (have_minimal_symbols, qsort_cmp, update_section_map)
3181         (shared_objfile_contains_address_p)
3182         (default_iterate_over_objfiles_in_search_order): Update.
3183         * objc-lang.c (info_selectors_command, info_classes_command)
3184         (find_methods): Update.
3185         * minsyms.c (find_solib_trampoline_target): Update.
3186         * maint.c (maintenance_info_sections)
3187         (maintenance_translate_address, count_symtabs_and_blocks):
3188         Update.
3189         * main.c (captured_main_1): Update.
3190         * linux-thread-db.c (try_thread_db_load_from_pdir)
3191         (has_libpthread): Update.
3192         * linespec.c (iterate_over_all_matching_symtabs)
3193         (search_minsyms_for_name): Update.
3194         * jit.c (jit_find_objf_with_entry_addr): Update.
3195         * hppa-tdep.c (find_unwind_entry)
3196         (hppa_lookup_stub_minimal_symbol): Update.
3197         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3198         Update.
3199         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3200         (elf_gnu_ifunc_resolve_by_got): Update.
3201         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3202         * dwarf-index-write.c (save_gdb_index_command): Update.
3203         * cp-support.c (add_symbol_overload_list_qualified): Update.
3204         * breakpoint.c (create_overlay_event_breakpoint)
3205         (create_longjmp_master_breakpoint)
3206         (create_std_terminate_master_breakpoint)
3207         (create_exception_master_breakpoint): Update.
3208         * blockframe.c (find_pc_partial_function): Update.
3209         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3210         (ada_collect_symbol_completion_matches)
3211         (ada_add_global_exceptions): Update.
3212
3213 2019-01-17  Tom Tromey  <tom@tromey.com>
3214
3215         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3216         declare VEC.
3217         (solib_target_parse_libraries): Change return type.
3218         (library_list_start_segment, library_list_start_section)
3219         (library_list_end_library, library_list_start_library); Update.
3220         (solib_target_free_library_list): Remove.
3221         (solib_target_parse_libraries): Remove cleanup.  Change return
3222         type.
3223         (solib_target_current_sos): Update.
3224
3225 2019-01-17  Tom Tromey  <tromey@bapiya>
3226
3227         * valprint.c: Replace "the the" with "the".
3228         * symtab.c: Replace "the the" with "the".
3229         * solib.c: Replace "the the" with "the".
3230         * solib-dsbt.c: Replace "the the" with "the".
3231         * linespec.c: Replace "the the" with "the".
3232         * dwarf2loc.h: Replace "the the" with "the".
3233         * amd64-windows-tdep.c: Replace "the the" with "the".
3234         * aarch64-tdep.c: Replace "the the" with "the".
3235
3236 2019-01-16  Keith Seitz  <keiths@redhat.com>
3237
3238         PR gdb/23773
3239         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3240         <builder>: Rename to ..
3241         <m_builder>: ... this and make private.
3242         (dwarf2_cu::get_builder): New method.  Change all users of
3243         `builder' to use this method.
3244         (dwarf2_start_symtab): Move to ...
3245         (dwarf2_cu::start_symtab): ... here.  Update all callers
3246         (setup_type_unit_groups): Move to ...
3247         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3248         callers.
3249         (dwarf2_cu::reset_builder): New method.
3250         (process_full_compunit, process_full_type_unit): Use
3251         dwarf2_cu::reset_builder.
3252         (follow_die_offset): Record the ancestor CU if it is different
3253         from the followed DIE's CU.
3254         (follow_die_sig_1): Likewise.
3255
3256 2019-01-15  Tom Tromey  <tom@tromey.com>
3257
3258         * remote.c (class remote_state) <buf>: Now a char_vector.
3259         <buf_size>: Remove.
3260         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3261         parameter.
3262         (remote_target::getpkt_or_notif_sane_1)
3263         (remote_target::getpkt_sane)
3264         (remote_target::getpkt_or_notif_sane): Likewise.
3265         (class remote_target) <putpkt>: New overload.
3266         (remote_target::read_frame): Change type of "buf_p".  Remove
3267         sizeof_p parameter.
3268         (packet_ok): New overload.
3269         (packet_check_result): New overload.
3270         Update all uses.
3271
3272 2019-01-14  Tom Tromey  <tom@tromey.com>
3273
3274         * remote-notif.c (handle_notification, remote_notif_ack)
3275         (remote_notif_parse): Make "buf" const.
3276         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3277         const.
3278         (remote_notif_parse, remote_notif_ack, handle_notification):
3279         Likewise.
3280         * remote.c (remote_notif_stop_parse): Make "buf" const.
3281         (remote_target::remote_parse_stop_reply): Make "buf" const.
3282         (remote_notif_stop_ack): Make "buf" const.
3283
3284 2019-01-14  Tom Tromey  <tom@tromey.com>
3285
3286         * remote.c (remote_console_output): Make parameter const.
3287
3288 2019-01-14  Tom Tromey  <tom@tromey.com>
3289
3290         * target-debug.h (target_debug_print_signals): Constify.
3291         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3292         * procfs.c (procfs_target::pass_signals): Update.
3293         * linux-nat.c (linux_nat_target::pass_signals): Update.
3294         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3295         * target-delegates.c: Rebuild.
3296         * remote.c (remote_target::program_signals): Update.
3297         (remote_target::pass_signals): Update.
3298         * target.c (target_pass_signals): Constify argument.
3299         (target_program_signals): Likewise.
3300         * target.h (struct target_ops) <pass_signals, program_signals>:
3301         Constify argument.
3302         (target_pass_signals, target_program_signals): Constify argument.
3303
3304 2019-01-14  Tom Tromey  <tom@tromey.com>
3305
3306         PR tui/28819:
3307         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3308
3309 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3310
3311         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3312         field.
3313         * rs6000-tdep.c: Include reggroups.h.
3314         (IS_V_ALIAS_PSEUDOREG): Define.
3315         (rs6000_register_name): Return names for the "vX" aliases.
3316         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3317         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3318         aliases.  Call default_register_reggroup_p for all other
3319         pseudo-registers.
3320         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3321         New functions.
3322         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3323         Handle "vX" aliases.
3324         (v_alias_pseudo_register_collect): New function.
3325         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3326         (rs6000_gdbarch_init): Initialize "vX" aliases as
3327         pseudo-registers.  Restore registration of
3328         rs6000_pseudo_register_reggroup_p with
3329         set_tdesc_pseudo_register_reggroup_p.
3330
3331 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3332
3333         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3334         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3335         set_gdbarch_num_pseudo_regs.
3336
3337 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3338
3339         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3340         Remove arg prefixname, add do_set and do_show.
3341         Add member functions set_list and show_list.
3342         * cli/cli-style.c (class cli_style_option): Update accordingly.
3343         (style_set_list): Move to file scope.
3344         (style_show_list): Likewise.
3345         (set_style): Call help_list.
3346         (show_style): Call cmd_show_list.
3347         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3348         Update to use the new macro.
3349
3350 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3351
3352         * ada-lang.c (_initialize_ada_language): Expand the help text
3353         for the "catch exception" command.
3354
3355 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3356
3357         * symtab.c (matching_obj_sections): Initialize obj,
3358         declare it closer to its usage.
3359
3360 2019-01-10  Tom Tromey  <tom@tromey.com>
3361
3362         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3363         (basic_inf_threads_range): Remove.
3364         (inf_threads_range, inf_non_exited_threads_range)
3365         (safe_inf_threads_range): Use next_adapter.
3366
3367 2019-01-10  Keith Seitz  <keiths@redhat.com>
3368
3369         PR gdb/23712
3370         PR symtab/23010
3371         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3372         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3373
3374 2019-01-10  Keith Seitz  <keiths@redhat.com>
3375
3376         PR gdb/23712
3377         PR symtab/23010
3378         * dictionary.c (pending_to_vector): Remove.
3379         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3380         Remove _1 suffix, replacing functions of the same name.  Update
3381         all callers.
3382         (dict_create_hashed, dict_create_hashed_expandable)
3383         (dict_create_linear, dict_create_linear_expandable, dict_free)
3384         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3385         Make functions static.
3386
3387 2019-01-10  Keith Seitz  <keiths@redhat.com>
3388
3389         PR gdb/23712
3390         PR symtab/23010
3391         * dictionary.h (struct dictionary): Replace declaration with
3392         multidictionary.
3393         (dict_create_hashed, dict_create_hashed_expandable)
3394         (dict_create_linear, dict_create_linear_expandable)
3395         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3396         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3397         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3398         taking multidictionary argument.
3399         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3400         * block.h (struct block) <dict>: Change to multidictionary
3401         and rename `multidict'.
3402         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3403         symmisc.c: Update all dictionary references to multidictionary.
3404
3405 2019-01-10  Keith Seitz  <keiths@redhat.com>
3406
3407         PR gdb/23712
3408         PR symtab/23010
3409         * dictionary.c: Include unordered_map.
3410         (pending_to_vector): New function.
3411         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3412         Rewrite the non-"_1" functions to take vector instead
3413         of linked list.
3414         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3415         "new" _1 versions of the same name.
3416         (multidictionary): Define.
3417         (std::hash<enum language): New definition.
3418         (collate_pending_symbols_by_language, mdict_create_hashed)
3419         (mdict_create_hashed_expandable, mdict_create_linear)
3420         (mdict_create_linear_expandable, mdict_free)
3421         (find_language_dictionary, create_new_language_dictionary)
3422         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3423         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3424         (mdict_size, mdict_empty): New functions.
3425         * dictionary.h (mdict_iterator): Define.
3426
3427 2019-01-10  Pedro Alves  <palves@redhat.com>
3428
3429         * breakpoint.c (read_uploaded_action)
3430         (create_tracepoint_from_upload): Adjust to use
3431         gdb::unique_xmalloc_ptr.
3432         * ctf.c (ctf_write_uploaded_tp):
3433         (SET_ARRAY_FIELD): Use emplace_back.
3434         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3435         * tracefile-tfile.c (tfile_write_uploaded_tp):
3436         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3437         gdb::unique_xmalloc_ptr.
3438         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3439         at_string, cond_string, cmd_strings>: Replace char pointers
3440         with gdb::unique_xmalloc_ptr.
3441
3442 2019-01-10  Pedro Alves  <palves@redhat.com>
3443
3444         * solib-target.c (library_list_start_library): Don't xstrdup name.
3445
3446 2019-01-10  Pedro Alves  <palves@redhat.com>
3447
3448         * mdebugread.c (parse_partial_symbols): Use
3449         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3450
3451 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3452
3453         * linux-fork.c (scoped_switch_fork_info)
3454         <~scoped_switch_fork_info>: Fix incorrect variable name.
3455
3456 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * linux-fork.c (scoped_switch_fork_info)
3459         <scoped_switch_fork_info>: Make explicit.
3460         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3461
3462 2019-01-10  Tom Tromey  <tom@tromey.com>
3463
3464         * objfiles.h (objfile::reset_psymtabs): Update.
3465         * objfiles.c (objfile::objfile): Update.
3466         * psymtab.h (psymtab_storage::obstack): Update.
3467         (psymtab_storage::m_obstack): Use gdb::optional.
3468         (class psymtab_storage): Update comment.  Remove objfile
3469         parameter.
3470         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3471
3472 2019-01-10  Tom Tromey  <tom@tromey.com>
3473
3474         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3475         <free_psymtabs>: Now private.
3476         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3477         (allocate_psymtab): Use new method.
3478
3479 2019-01-10  Tom Tromey  <tom@tromey.com>
3480
3481         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3482         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3483         * mdebugread.c (parse_partial_symbols): Use
3484         allocate_dependencies.
3485         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3486         allocate_dependencies.
3487         (process_psymtab_comp_unit_reader)
3488         (build_type_psymtab_dependencies): Likewise.
3489         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3490
3491 2019-01-10  Tom Tromey  <tom@tromey.com>
3492
3493         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3494         PSYMBOL_SET_LANGUAGE.
3495         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3496
3497 2019-01-10  Tom Tromey  <tom@tromey.com>
3498
3499         * psymtab.h (psymtab_storage::obstack): New method.
3500         <m_obstack>: Rename from obstack; now private.
3501         * psymtab.c (psymtab_storage): Update.
3502         * dwarf2read.c (create_addrmap_from_index)
3503         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3504         Update.
3505
3506 2019-01-10  Tom Tromey  <tom@tromey.com>
3507
3508         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3509         * objfiles.h (objfile::reset_psymtabs): New method.
3510
3511 2019-01-10  Tom Tromey  <tom@tromey.com>
3512
3513         * symmisc.c (print_symbol_bcache_statistics): Update.
3514         (print_objfile_statistics): Update.
3515         * symfile.c (reread_symbols): Update.
3516         * psymtab.h (class psymtab_storage): New.
3517         * psymtab.c (psymtab_storage): New constructor.
3518         (~psymtab_storage): New destructor.
3519         (require_partial_symbols): Update.
3520         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3521         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3522         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3523         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3524         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3525         (start_psymtab_common, end_psymtab_common)
3526         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3527         (allocate_psymtab): Update.
3528         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3529         Update.
3530         (dump_psymtab_addrmap, maintenance_print_psymbols)
3531         (maintenance_check_psymtabs): Update.
3532         (class objfile_psymtabs): Move to objfiles.h.
3533         * psympriv.h (discard_psymtab): Now inline.
3534         (psymtab_discarder::psymtab_discarder): Update.
3535         (psymtab_discarder::~psymtab_discarder): Update.
3536         (ALL_OBJFILE_PSYMTABS): Rewrite.
3537         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3538         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3539         Remove fields.
3540         <partial_symtabs>: New field.
3541         (class objfile_psymtabs): Move from psymtab.h.  Update.
3542         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3543         psymbol_cache.
3544         (objfile::~objfile): Don't destroy psymbol_cache.
3545         * mdebugread.c (parse_partial_symbols): Update.
3546         * dwarf2read.c (create_addrmap_from_index)
3547         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3548         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3549         (add_partial_subprogram, dwarf2_ranges_read): Update.
3550         * dwarf-index-write.c (write_address_map)
3551         (write_one_signatured_type, recursively_write_psymbols)
3552         (class debug_names, class debug_names, write_psymtabs_to_index):
3553         Update.
3554
3555 2019-01-10  Tom Tromey  <tom@tromey.com>
3556
3557         * symtab.h (SYMBOL_SET_NAMES): Update.
3558         (symbol_set_names): Update.
3559         (MSYMBOL_SET_NAMES): Update.
3560         * symtab.c (symbol_set_names): Change argument to be an
3561         objfile_per_bfd_storage.
3562         * psymtab.c (add_psymbol_to_bcache): Update.
3563         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3564
3565 2019-01-10  Tom Tromey  <tom@tromey.com>
3566
3567         * symtab.c (create_demangled_names_hash): Change argument to be an
3568         objfile_per_bfd_storage.
3569         (symbol_set_names): Update.
3570
3571 2019-01-10  Tom Tromey  <tom@tromey.com>
3572
3573         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3574         init_psymbol_list.
3575         * psymtab.c (init_psymbol_list): Do nothing if already called.
3576         * psympriv.h (init_psymbol_list): Add comment.
3577         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3578         init_psymbol_list.
3579         * dbxread.c (dbx_symfile_read): Unconditionally call
3580         init_psymbol_list.
3581
3582 2019-01-10  Tom Tromey  <tom@tromey.com>
3583
3584         * xcoffread.c (scan_xcoff_symtab): Update.
3585         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3586         "where".
3587         * mdebugread.c (parse_partial_symbols)
3588         (handle_psymbol_enumerators): Update.
3589         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3590         * dbxread.c (read_dbx_symtab): Update.
3591         * psympriv.h (psymbol_placement): New enum.
3592         (add_psymbol_to_list): Update.
3593
3594 2019-01-10  Tom Tromey  <tom@tromey.com>
3595
3596         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3597         static_psymbols parameters.
3598         (scan_xcoff_symtab): Update.
3599         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3600         static_psymbols parameters.
3601         * psympriv.h (start_psymtab_common): Update.
3602         * mdebugread.c (parse_partial_symbols): Update.
3603         * dwarf2read.c (create_partial_symtab): Update.
3604         * dbxread.c (read_dbx_symtab): Update.
3605         (start_psymtab): Remove global_psymbols and static_psymbols
3606         parameters.
3607
3608 2019-01-10  Tom Tromey  <tom@tromey.com>
3609
3610         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3611         * psymtab.c (allocate_psymtab): Add comment.
3612         * psympriv.h (allocate_psymtab): Add comment.
3613         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3614         initializations.
3615         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3616
3617 2019-01-10  Tom Tromey  <tom@tromey.com>
3618
3619         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3620         Don't declare.
3621         * mipsread.c: Include mdebugread.h.
3622         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3623         Declare.
3624         * elfread.c: Include mdebugread.h.
3625
3626 2019-01-09  Tom Tromey  <tom@tromey.com>
3627
3628         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3629         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3630         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3631         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3632         (psym_lookup_symbol, psym_find_last_source_symtab)
3633         (psym_forget_cached_source_info, psym_print_stats)
3634         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3635         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3636         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3637         (psym_find_compunit_symtab_by_address)
3638         (maintenance_print_psymbols, maintenance_info_psymtabs)
3639         (maintenance_check_psymtabs): Use ranged for.
3640         * psymtab.h (class objfile_psymtabs): New.
3641         (require_partial_symbols): Return objfile_psymtabs.
3642         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3643
3644 2019-01-09  Tom Tromey  <tom@tromey.com>
3645
3646         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3647         (find_pc_mapped_section, list_overlays_command)
3648         (map_overlay_command, unmap_overlay_command)
3649         (simple_overlay_update): Use all_objfiles.
3650         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3651         * printcmd.c (info_symbol_command): Use all_objfiles.
3652         * objfiles.h (ALL_OBJSECTIONS): Remove.
3653         * maint.c (maintenance_translate_address): Use all_objfiles.
3654         * gcore.c (gcore_create_callback): Use all_objfiles.
3655         (objfile_find_memory_regions): Likewise.
3656
3657 2019-01-09  Tom Tromey  <tom@tromey.com>
3658
3659         * symtab.c (find_line_symtab, info_sources_command)
3660         (make_source_files_completion_list): Use objfile_compunits.
3661         * source.c (select_source_symtab): Use objfile_compunits.
3662         * objfiles.h (struct objfile): Update comment.
3663         (ALL_OBJFILES): Remove.
3664         (ALL_FILETABS): Remove.
3665         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3666         objfile_compunits.
3667
3668 2019-01-09  Tom Tromey  <tom@tromey.com>
3669
3670         * symmisc.c (print_objfile_statistics, dump_objfile)
3671         (maintenance_print_symbols): Use compunit_filetabs.
3672         * source.c (forget_cached_source_info_for_objfile): Use
3673         compunit_filetabs.
3674         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3675         (ALL_FILETABS): Use compunit_filetabs.
3676         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3677         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3678
3679 2019-01-09  Tom Tromey  <tom@tromey.com>
3680
3681         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3682         (compunit_filetabs): New.
3683         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3684         compunit_filetabs.
3685         (info_sources_command, make_source_files_completion_list): Remove
3686         declaration.
3687         * symmisc.c (print_objfile_statistics, dump_objfile)
3688         (maintenance_print_symbols): Remove declaration.
3689         (maintenance_info_symtabs): Use compunit_filetabs.
3690         (maintenance_info_line_tables): Likewise.
3691         * source.c (select_source_symtab): Change local variable name.
3692         (forget_cached_source_info_for_objfile): Remove declaration.
3693         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3694         * objfiles.c (objfile_relocate1): Remove declaration.
3695         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3696         declaration.
3697         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3698         * coffread.c (coff_symtab_read): Remove declaration.
3699         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3700         compunit_filetabs.
3701
3702 2019-01-09  Tom Tromey  <tom@tromey.com>
3703
3704         * symtab.c (lookup_objfile_from_block)
3705         (find_pc_sect_compunit_symtab, search_symbols)
3706         (default_collect_symbol_completion_matches_break_on): Use
3707         objfile_compunits.
3708         * objfiles.h (ALL_COMPUNITS): Remove.
3709         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3710         * cp-support.c (add_symbol_overload_list_qualified): Use
3711         objfile_compunits.
3712         * ada-lang.c (ada_collect_symbol_completion_matches)
3713         (ada_add_global_exceptions): Use objfile_compunits.
3714
3715 2019-01-09  Tom Tromey  <tom@tromey.com>
3716
3717         * source.c (select_source_symtab)
3718         (forget_cached_source_info_for_objfile): Remove declaration.
3719         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3720         declaration.
3721         * maint.c (count_symtabs_and_blocks): Remove declaration.
3722         * cp-support.c (add_symbol_overload_list_qualified): Remove
3723         declaration.
3724         * coffread.c (coff_symtab_read): Remove declaration.
3725         * symtab.c (lookup_symbol_in_objfile_symtabs)
3726         (basic_lookup_transparent_type_1): Use objfile_compunits.
3727         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3728         (info_sources_command, search_symbols)
3729         (default_collect_symbol_completion_matches_break_on)
3730         (make_source_files_completion_list): Remove declaration.
3731         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3732         (ada_collect_symbol_completion_matches)
3733         (ada_add_global_exceptions): Remove declaration.
3734         * linespec.c (iterate_over_all_matching_symtabs): Use
3735         objfile_compunits.
3736         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3737         (class objfile_compunits): New.
3738         (ALL_COMPUNITS): Use objfile_compunits.
3739         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3740         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3741         objfile_compunits.
3742         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3743
3744 2019-01-09  Tom Tromey  <tom@tromey.com>
3745
3746         * symtab.c (search_symbols)
3747         (default_collect_symbol_completion_matches_break_on): Use
3748         objfile_msymbols.
3749         * ada-lang.c (ada_lookup_simple_minsym)
3750         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3751         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3752         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3753         objfile_msymbols.
3754         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3755         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3756         * objc-lang.c (find_methods): Use objfile_msymbols.
3757         (info_selectors_command, info_classes_command): Likewise.
3758         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3759         * objfiles.h (class objfile_msymbols): New.
3760         (ALL_OBJFILE_MSYMBOLS): Remove.
3761         (ALL_MSYMBOLS): Remove.
3762
3763 2019-01-09  Tom Tromey  <tom@tromey.com>
3764
3765         * common/next-iterator.h (next_adapter): Add Iterator template
3766         parameter.
3767         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3768         (class all_objfiles_safe): New.
3769         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3770         * objfiles.c (put_objfile_before): Update comment.
3771         (add_separate_debug_objfile): Likewise.
3772         (free_all_objfiles): Use all_objfiles_safe.
3773         (objfile_purge_solibs): Likewise.
3774
3775 2019-01-09  Tom Tromey  <tom@tromey.com>
3776
3777         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3778         (expand_symtab_containing_pc, lookup_static_symbol)
3779         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3780         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3781         all_objfiles.
3782         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3783         * breakpoint.c (create_overlay_event_breakpoint)
3784         (create_longjmp_master_breakpoint)
3785         (create_std_terminate_master_breakpoint)
3786         (create_exception_master_breakpoint): Use all_objfiles.
3787         * linux-thread-db.c (try_thread_db_load_from_pdir)
3788         (has_libpthread): Use all_objfiles.
3789         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3790         * linespec.c (iterate_over_all_matching_symtabs)
3791         (search_minsyms_for_name): Use all_objfiles.
3792         * maint.c (maintenance_info_sections): Use all_objfiles.
3793         * main.c (captured_main_1): Use all_objfiles.
3794         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3795         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3796         * guile/scm-pretty-print.c
3797         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3798         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3799         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3800         (maintenance_print_msymbols): Use all_objfiles.
3801         * source.c (select_source_symtab): Use all_objfiles.
3802         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3803         * symfile.c (remove_symbol_file_command)
3804         (expand_symtabs_matching, map_symbol_filenames): Use
3805         all_objfiles.
3806         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3807         all_objfiles.
3808         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3809         * objc-lang.c (find_methods): Use all_objfiles.
3810         * objfiles.c (have_partial_symbols, have_full_symbols)
3811         (have_minimal_symbols, qsort_cmp)
3812         (default_iterate_over_objfiles_in_search_order): Use
3813         all_objfiles.
3814         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3815         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3816         (maintenance_check_psymtabs): Use all_objfiles.
3817         (ALL_PSYMTABS): Remove.
3818         * compile/compile-object-run.c (do_module_cleanup): Use
3819         all_objfiles.
3820         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3821         * cp-support.c (add_symbol_overload_list_qualified): Use
3822         all_objfiles.
3823         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3824         Use all_objfiles.
3825         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3826         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3827         all_objfiles.
3828         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3829         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3830         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3831         Uses all_objfiles.
3832         * solib.c (solib_read_symbols): Use all_objfiles
3833
3834 2019-01-09  Tom Tromey  <tom@tromey.com>
3835
3836         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3837         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3838         all_objfiles.
3839         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3840         * symmisc.c (print_symbol_bcache_statistics)
3841         (print_objfile_statistics, maintenance_print_objfiles)
3842         (maintenance_info_symtabs, maintenance_check_symtabs)
3843         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3844         all_objfiles.
3845         * source.c (forget_cached_source_info): Use all_objfiles.
3846         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3847         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3848         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3849         * objfiles.c (update_section_map): Use all_objfiles.
3850         (shared_objfile_contains_address_p): Likewise.
3851         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3852         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3853
3854 2019-01-09  Tom Tromey  <tom@tromey.com>
3855
3856         * common/next-iterator.h: New file.
3857         * objfiles.h (class all_objfiles): New.
3858         (struct objfile_iterator): New.
3859
3860 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3861
3862         * NEWS: Move the description of the changed "frame", "select-frame",
3863          and "info frame" commands to the Changed commands section.
3864
3865 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3866
3867         * gdbtypes.c (check_stub_method_group): Remove handling of old
3868         mangling schemes.
3869         * linespec.c (find_methods): Likewise.
3870         * stabsread.c (read_member_functions): Likewise.
3871         * valops.c (search_struct_method): Likewise.
3872         (value_struct_elt_for_reference): Likewise.
3873         * NEWS: Mention this change.
3874
3875 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3876
3877         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3878         print_source_lines.
3879         * source.c (print_source_lines_base): Update line number check.
3880         (print_source_lines): New function.
3881         (source_lines_range::source_lines_range): New function.
3882         * source.h (class source_lines_range): New class.
3883         (print_source_lines): New declaration.
3884
3885 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3886
3887         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3888
3889 2019-01-08  Tom Tromey  <tom@tromey.com>
3890             Simon Marchi  <simon.marchi@ericsson.com>
3891
3892         PR gdb/24060
3893         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3894         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3895         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3896         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3897         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3898         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3899
3900 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3901
3902         * source.c (select_source_symtab): Move header comment to
3903         declaration in source.h.
3904         (forget_cached_source_info_for_objfile): Likewise.
3905         (forget_cached_source_info): Likewise.
3906         (identify_source_line): Likewise.
3907         * source.h (identify_source_line): Move declaration from symtab.h
3908         and add comment from source.c
3909         (print_source_lines): Likewise.
3910         (forget_cached_source_info_for_objfile): Likewise.
3911         (forget_cached_source_info): Likewise.
3912         (select_source_symtab): Likewise.
3913         (enum print_source_lines_flag): Move definition from symtab.h.
3914         * symtab.h (identify_source_line): Move declaration to source.h.
3915         (print_source_lines): Likewise.
3916         (forget_cached_source_info_for_objfile): Likewise.
3917         (forget_cached_source_info): Likewise.
3918         (select_source_symtab): Likewise.
3919         (enum print_source_lines_flag): Move definition to source.h.
3920         * tui/tui-hooks.c: Add 'source.h' include.
3921
3922 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3923
3924         * source.c (print_source_lines_base): Handle requests to print
3925         reverse line number sequences, and guard against empty lines
3926         string.
3927
3928 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * source.c (print_source_lines_base): Fix skip of '\r' if next
3931         character is '\n'.
3932
3933 2019-01-06  Tom Tromey  <tom@tromey.com>
3934
3935         * c-exp.y (struct c_parse_state) <macro_original_text,
3936         expansion_obstack>: New member.
3937         (macro_original_text, expansion_obstack): Remove globals.
3938         (scan_macro_expansion, scanning_macro_expansion)
3939         (finished_macro_expansion): Update.
3940         (scan_macro_cleanup): Remove.
3941         (yylex, c_parse): Update.
3942
3943 2019-01-06  Tom Tromey  <tom@tromey.com>
3944
3945         * c-exp.y (struct c_parse_state) <strings>: New member.
3946         (operator_stoken): Update.
3947
3948 2019-01-06  Tom Tromey  <tom@tromey.com>
3949
3950         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3951         (union type_stack_elt) <typelist_val>: Now a pointer to
3952         std::vector.
3953         (type_stack_cleanup): Don't declare.
3954         (push_typelist): Update.
3955         * parse.c (pop_typelist): Return a std::vector.
3956         (push_typelist): Take a std::vector.
3957         (follow_types): Update.  Do not free args.
3958         (type_stack_cleanup): Remove.
3959         * c-exp.y (struct c_parse_state): New.
3960         (cpstate): New global.
3961         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3962         (nonempty_typelist): Update.
3963         (func_mod): Create a new vector.
3964         (c_parse): Create a c_parse_state.
3965         (check_parameter_typelist): Do not delete params.
3966         (function_method): Update.  Do not delete type_list.
3967
3968 2019-01-06  Tom Tromey  <tom@tromey.com>
3969
3970         PR gdb/28155:
3971         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3972         check_typedef.
3973         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3974         (print_return_value): Likewise.
3975
3976 2019-01-05  Tom Tromey  <tom@tromey.com>
3977
3978         * contrib/cleanup_check.py: Remove.
3979         * contrib/gcc-with-excheck: Remove.
3980         * contrib/exsummary.py: Remove.
3981         * contrib/excheck.py: Remove.
3982
3983 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3984
3985         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3986         NULL. Initialize tpprev to NULL instead of assigning it
3987         to NULL on the next statement.
3988         * windows-nat.c (windows_delete_thread): Remove check for
3989         main_thread_id before printing thread exit notifications.
3990         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3991         Remove thread ID check against main_thread_id.
3992         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3993         windows_delete_thread.
3994         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3995
3996 2019-01-04  Tom Tromey  <tom@tromey.com>
3997
3998         * compile/compile.c (_initialize_compile): Use upper case for
3999         metasyntactic variables.
4000         * symmisc.c (_initialize_symmisc): Use upper case for
4001         metasyntactic variables.
4002         * psymtab.c (_initialize_psymtab): Use upper case for
4003         metasyntactic variables.
4004         * demangle.c (demangle_command): Use upper case for metasyntactic
4005         variables.
4006         (_initialize_demangler): Likewise.
4007         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4008         variables.
4009
4010 2019-01-03  Tom Tromey  <tom@tromey.com>
4011
4012         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4013
4014 2019-01-03  Tom Tromey  <tom@tromey.com>
4015
4016         * python/py-symtab.c (salpy_str): Update.
4017         (struct salpy_sal_object) <symtab>: Now a PyObject.
4018         (salpy_dealloc): Update.
4019         (del_objfile_sal): Use gdbpy_ref.
4020
4021 2019-01-03  Tom Tromey  <tom@tromey.com>
4022
4023         * python/py-type.c (convert_field): Use new_reference.  Return
4024         gdbpy_ref.
4025         (make_fielditem): Return gdbpy_ref.
4026         (typy_fields): Update.
4027         (typy_getitem): Update.
4028         (field_name): Return gdbpy_ref.  Use new_reference.
4029         (typy_iterator_iternext): Update.
4030
4031 2019-01-03  Tom Tromey  <tom@tromey.com>
4032
4033         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4034
4035 2019-01-03  Tom Tromey  <tom@tromey.com>
4036
4037         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4038         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4039         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4040         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4041         (pspy_set_type_printers): Likewise.
4042         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4043         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4044         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4045         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4046         (objfpy_set_type_printers): Likewise.
4047
4048 2019-01-03  Tom Tromey  <tom@tromey.com>
4049
4050         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4051         (gdbpy_print_stack): Use gdbpy_err_fetch.
4052         * python/python-internal.h (class gdbpy_err_fetch): New class.
4053         (class gdbpy_enter) <m_error_type, m_error_value,
4054         m_error_traceback>: Remove.
4055         <m_error>: New member.
4056         (gdbpy_exception_to_string): Don't declare.
4057         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4058         * python/py-value.c (convert_value_from_python): Use
4059         gdbpy_err_fetch.
4060         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4061         gdbpy_exception_to_string.
4062         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4063         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4064         gdbpy_err_fetch.
4065
4066 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4067
4068         * linux-nat.c (delete_lwp_cleanup): Delete.
4069         (struct lwp_deleter): New struct.
4070         (lwp_info_up): New typedef.
4071         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4072         lwp_info_up.
4073
4074 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4075
4076         * linux-fork.c (class scoped_switch_fork_info): New class.
4077         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4078
4079 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4080
4081         * valops.c (find_overload_match): Remove use of null_cleanup, and
4082         calls to do_cleanups.
4083
4084 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4085
4086         * compile/compile-cplus-types.c
4087         (compile_cplus_instance::decl_name): Handle changes to
4088         cp_func_name.
4089         * cp-support.c (cp_func_name): Update header comment, update
4090         return type.
4091         * cp-support.h (cp_func_name): Update return type in declaration.
4092         * valops.c (find_overload_match): Move temp_func local to top
4093         level of function and change its type.  Use temp_func to hold and
4094         delete temporary string obtained from cp_func_name.
4095
4096 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4099         gdb::char_vector, remove cleanup, and update uses of `msg`.
4100
4101 2019-01-03  Jim Wilson  <jimw@sifive.com>
4102
4103         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4104
4105 2019-01-02  Tom Tromey  <tom@tromey.com>
4106
4107         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4108         (tdesc_parse_xml): Remove cleanups.
4109         * target-descriptions.h (make_cleanup_free_target_description):
4110         Don't declare.
4111         (target_desc_deleter): New struct.
4112         (target_desc_up): New typedef.
4113         * target-descriptions.c (target_desc_deleter::operator()): Rename
4114         from free_target_description.
4115         (make_cleanup_free_target_description): Remove.
4116
4117 2019-01-02  Tom Tromey  <tom@tromey.com>
4118
4119         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4120         constructor, destructor.
4121         (linespec_parser): Remove typedef.
4122         (~linespec_parser): Rename from linespec_parser_delete.
4123         (linespec_lex_to_end, linespec_complete_label)
4124         (linespec_complete): Update.
4125         (decode_line_full): Remove cleanups.
4126         (decode_line_1): Update.
4127
4128 2019-01-02  Tom Tromey  <tom@tromey.com>
4129
4130         * python/python-internal.h (inferior_to_inferior_object): Change
4131         return type.
4132         * python/py-exitedevent.c (create_exited_event_object): Update.
4133         * python/py-inferior.c (inferior_to_inferior_object): Return
4134         gdbpy_ref.
4135         (python_new_inferior, python_inferior_deleted)
4136         (thread_to_thread_object, delete_thread_object)
4137         (build_inferior_list, gdbpy_selected_inferior): Update.
4138         * python/py-infthread.c (create_thread_object): Update.  Also fail
4139         if inferior_to_inferior_object fails.
4140
4141 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4142
4143         * inferior.h (class inferior) <displaced_step_state>: New field.
4144         * infrun.h (struct displaced_step_state): Move here from
4145         infrun.c.  Initialize fields, add constructor.
4146         <inf>: Remove field.
4147         <reset>: New method.
4148         * infrun.c (struct displaced_step_inferior_state): Move to
4149         infrun.h.
4150         (displaced_step_inferior_states): Remove.
4151         (get_displaced_stepping_state): Adust.
4152         (displaced_step_in_progress_any_inferior): Adjust.
4153         (displaced_step_in_progress_thread): Adjust.
4154         (displaced_step_in_progress): Adjust.
4155         (add_displaced_stepping_state): Remove.
4156         (get_displaced_step_closure_by_addr): Adjust.
4157         (remove_displaced_stepping_state): Remove.
4158         (infrun_inferior_exit): Call displaced_step_state.reset.
4159         (use_displaced_stepping): Don't check for NULL.
4160         (displaced_step_prepare_throw): Call
4161         get_displaced_stepping_state.
4162         (displaced_step_fixup): Don't check for NULL.
4163         (prepare_for_detach): Don't check for NULL.
4164
4165 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4166
4167         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4168          in case of call that did not complete.
4169
4170 2019-01-02  Andrey Utkin  <autkin@undo.io>
4171
4172         * symfile.c (find_separate_debug_file): Fix search of debug files for
4173         remote debuggee.
4174
4175 2019-01-02  Tom Tromey  <tom@tromey.com>
4176
4177         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4178         indentation.
4179         * python/py-frame.c (frapy_older): Remove cast.
4180         (frapy_newer): Likewise.
4181         * python/py-breakpoint.c (local_setattro): Remove cast.
4182         * python/py-arch.c (archpy_name): Remove local variable.
4183         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4184
4185 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4186
4187         * unittests/basic_string_view/element_access/char/empty.cc:
4188         Fix year range in copyright header.
4189
4190 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4191
4192         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4193         Delete.
4194         <operator==>: Update with for removed field.
4195         <hash>: Likewise.
4196         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4197         <isa_features>: ...this.
4198         <abi_features>: New field.
4199         (riscv_isa_flen): Update comment.
4200         (riscv_abi_xlen): New declaration.
4201         (riscv_abi_flen): New declaration.
4202         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4203         isa_features.
4204         (riscv_abi_xlen): New function.
4205         (riscv_isa_flen): Update to get answer from isa_features.
4206         (riscv_abi_flen): New function.
4207         (riscv_has_fp_abi): Update to get answer from abi_features.
4208         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4209         xlen and flen.
4210         (riscv_call_info) <xlen, flen>: Update comment.
4211         (riscv_call_arg_struct): Remove invalid assertions
4212         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4213         is removed.
4214         (riscv_gdbarch_init): Gather isa features and abi features
4215         separately, ensure both match on the gdbarch when reusing an old
4216         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4217         a target with 64-bit float hardware.
4218
4219 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4220
4221         * source.c (search_command_helper): Stop reverse search
4222         when line 1 has been searched.
4223
4224 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4225
4226         * record-full.c (record_full_base_target::close): Rewrite
4227         record_full_core_buf_list free logic.
4228
4229 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4230
4231         * break-catch-syscall.c (print_one_catch_syscall): xfree
4232         the last text.
4233
4234 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4235
4236         * top.c (print_gdb_version): Update Copyright year in version
4237         message.
4238
4239 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4240
4241         Update copyright year range in all GDB files.
4242
4243 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4244
4245         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4246
4247 For older changes see ChangeLog-2018.
4248 \f
4249 Local Variables:
4250 mode: change-log
4251 left-margin: 8
4252 fill-column: 74
4253 version-control: never
4254 coding: utf-8
4255 End:
4256