gdb/ChangeLog

   1 2019-03-29  Keith Seitz  <keiths@redhat.com>
   2
   3         From Siddhesh Poyarekar:
   4         * f-lang.h (f77_get_upperbound): Return LONGEST.
   5         (f77_get_lowerbound): Likewise.
   6         * f-typeprint.c (f_type_print_varspec_suffix): Expand
   7         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
   8         print them.
   9         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
  10         plongest to format print it.
  11         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
  12         (f77_get_upperbound): Likewise.
  13         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
  14         LOWER_BOUND to LONGEST.
  15         (f77_create_arrayprint_offset_tbl): Likewise.
  16
  17 2019-03-29  Keith Seitz  <keiths@redhat.com>
  18
  19         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
  20         %s/pulongest for TYPE_LENGTH instead of %d in format
  21         strings.
  22         * ada-typerint.c (ada_print_type): Likewise.
  23         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
  24         * compile/compile-c-support.c (generate_register_struct): Likewise.
  25         * gdbtypes.c (recursive_dump_type): Likewise.
  26         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  27         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
  28         instead of %d in format strings.
  29         * riscv-tdep.c (riscv_type_alignment): Cast second argument
  30         to std::min to ULONGEST.
  31         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
  32         instead of %d in format strings.
  33         * tracepoint.c (info_scope_command): Likewise.
  34         * typeprint.c (print_offset_data::update)
  35         (print_offset_data::finish): Likewise.
  36         * xtensa-tdep.c (xtensa_store_return_value)
  37         (xtensa_push_dummy_call): Likewise.
  38
  39 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
  40
  41         * windows-nat.c (display_selector): Fixed format specifications
  42         for 64-bit Cygwin.
  43
  44 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  45
  46         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
  47
  48 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
  49
  50         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
  51         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
  52         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
  53         (nios2_linux_init_abi): Install it.
  54
  55 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  56
  57         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
  58
  59 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  60
  61         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
  62
  63 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  64             Tom Tromey  <tromey@adacore.com>
  65
  66         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
  67
  68 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  69
  70         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  71         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  72         method to compute the bounds of range types. Also print "[evaluated]"
  73         if the bounds' values come from a dynamic evaluation.
  74
  75 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  76
  77         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  78         whitespace when pretty printing is on.
  79
  80 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  81
  82         * ppc-linux-nat.c: Add include.
  83
  84 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  85
  86         * NEWS: Mention AArch64 Pointer Authentication.
  87
  88 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  89
  90         * arm-linux-nat.c: Add include.
  91
  92 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  93
  94         * source-cache.c (source_cache::get_source_lines): Re-read
  95         fullname after calling open_source_file.
  96
  97 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  98
  99         * NEWS: Mention TLS support for FreeBSD.
 100
 101 2019-03-25  Tom Tromey  <tromey@adacore.com>
 102
 103         * minsyms.c (BUNCH_SIZE): Update comment.
 104         (~minimal_symbol_reader): Remove old comment.
 105         (compact_minimal_symbols): Update comment.
 106         (minimal_symbol_reader::install): Remove old comment.  Update
 107         other comments.
 108
 109 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 110
 111         * s390-linux-nat.c: Add include.
 112
 113 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 114
 115         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 116         Call linux_get_hwcap.
 117         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 118         Likewise.
 119         (aarch64_linux_get_hwcap): Remove function.
 120         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 121         declaration.
 122         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 123         linux_get_hwcap.
 124         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 125         * linux-tdep.c (linux_get_hwcap): Add function.
 126         (linux_get_hwcap2): Likewise.
 127         * linux-tdep.h (linux_get_hwcap): Add declaration.
 128         (linux_get_hwcap2): Likewise.
 129         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 130         (ppc_linux_get_hwcap2): Likewise.
 131         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 132         linux_get_hwcap.
 133         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 134         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 135         (ppc_linux_nat_target::read_description): Likewise.
 136         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 137         * s390-linux-nat.c: Likewise.
 138         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 139
 140 2019-03-24  Tom Tromey  <tom@tromey.com>
 141
 142         * ada-lang.c (standard_lookup): Simplify initialization.
 143         (ada_lookup_symbol_nonlocal): Simplify return.
 144         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 145         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 146         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 147         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 148         initialization.
 149         * solib.c (solib_global_lookup): Simplify.
 150         * symtab.c (null_block_symbol): Remove.
 151         (symbol_cache_lookup): Simplify returns.
 152         (lookup_language_this): Simplify returns.
 153         (lookup_symbol_aux): Simplify return.
 154         (lookup_local_symbol): Simplify returns.
 155         (lookup_global_symbol_from_objfile): Simplify return.
 156         (lookup_symbol_in_objfile_symtabs)
 157         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 158         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 159         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 160         * cp-namespace.c (cp_lookup_bare_symbol)
 161         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 162         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 163         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 164         (cp_lookup_symbol_via_imports): Simplify initialization.
 165         (find_symbol_in_baseclass): Likewise.
 166         * symtab.h (null_block_symbol): Remove.
 167         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 168         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 169         (d_lookup_symbol_module): Likewise.
 170         (find_symbol_in_baseclass): Simplify initialization.
 171
 172 2019-03-24  Tom Tromey  <tom@tromey.com>
 173
 174         * expression.h: Don't include symtab.h.
 175         (struct block): Forward declare.
 176
 177 2019-03-24  Tom Tromey  <tom@tromey.com>
 178
 179         * c-exp.y (typebase): Remove casts.
 180         * gdbtypes.c (lookup_unsigned_typename, )
 181         (lookup_signed_typename): Remove cast.
 182         * eval.c (parse_to_comma_and_eval): Remove cast.
 183         * parse.c (write_dollar_variable): Remove cast.
 184         * block.h (struct block) <superblock>: Now const.
 185         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 186         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 187         (map_block): Make "block" const.
 188         * symfile.h (struct quick_symbol_functions)
 189         <map_matching_symbols>: Constify block argument to "callback".
 190         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 191         const.
 192         (find_pc_sect_compunit_symtab): Make "b" const.
 193         (find_symbol_at_address): Likewise.
 194         (search_symbols): Likewise.
 195         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 196         (dw2_debug_names_lookup_symbol): Likewise.
 197         (dw2_map_matching_symbols): Update.
 198         * p-valprint.c (pascal_val_print): Remove "block".
 199         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 200         (aux_add_nonlocal_symbols): Make "block" const.
 201         (resolve_subexp): Remove cast.
 202         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 203         const.
 204         (iterate_over_file_blocks): Likewise.
 205         * f-exp.y (%union) <bval>: Remove.
 206         * coffread.c (patch_opaque_types): Make "b" const.
 207         * spu-tdep.c (spu_catch_start): Make "block" const.
 208         * c-valprint.c (print_unpacked_pointer): Remove "block".
 209         * symmisc.c (dump_symtab_1): Make "b" const.
 210         (block_depth): Make "block" const.
 211         * d-exp.y (%union) <bval>: Remove.
 212         * cp-support.h (cp_lookup_rtti_type): Update.
 213         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 214         * psymtab.c (psym_lookup_symbol): Make "block" const.
 215         (maintenance_check_psymtabs): Make "b" const.
 216         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 217         (enumerate_locals, enumerate_args): Update.
 218         * python/py-symtab.c (stpy_global_block): Make "block" const.
 219         (stpy_static_block): Likewise.
 220         * inline-frame.c (block_starting_point_at): Make "new_block"
 221         const.
 222         * block.c (find_block_in_blockvector): Make return type const.
 223         (blockvector_for_pc_sect): Make "b" const.
 224         (find_block_in_blockvector): Make "b" const.
 225
 226 2019-03-23  Tom Tromey  <tom@tromey.com>
 227
 228         * varobj.c (varobj_create): Update.
 229         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 230         * printcmd.c (display_command, do_one_display): Don't reset
 231         innermost_block.
 232         * parser-defs.h (enum innermost_block_tracker_type): Move to
 233         expression.h.
 234         (innermost_block): Update comment.
 235         * parse.c (parse_exp_1): Add tracker_types parameter.
 236         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 237         tracker_types parameter.  Reset innermost_block.
 238         (parse_exp_in_context): Remove.
 239         (parse_expression_for_completion): Update.
 240         * objfiles.c (~objfile): Don't reset expression_context_block or
 241         innermost_block.
 242         * expression.h (enum innermost_block_tracker_type): Move from
 243         parser-defs.h.
 244         (parse_exp_1): Add tracker_types parameter.
 245         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 246         reset innermost_block.
 247
 248 2019-03-23  Tom Tromey  <tom@tromey.com>
 249
 250         * objfiles.h: Include bcache.h.
 251
 252 2019-03-23  Tom Tromey  <tom@tromey.com>
 253
 254         * linespec.c (get_current_search_block): Use
 255         scoped_restore_current_language.
 256         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 257
 258 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 259             Jiong Wang  <jiong.wang@arm.com>
 260
 261         * aarch64-linux-tdep.c
 262         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 263         section.
 264         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 265
 266 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 267             Jiong Wang  <jiong.wang@arm.com>
 268
 269         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 270         instructions.
 271         (aarch64_analyze_prologue_test): Add PACIASP test.
 272         (aarch64_prologue_prev_register): Unmask PC value.
 273
 274 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 275             Jiong Wang  <jiong.wang@arm.com>
 276
 277         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 278         (aarch64_dwarf2_prev_register): Unmask PC value.
 279         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 280         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 281         DW_CFA_AARCH64_negate_ra_state.
 282         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 283
 284 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 285             Jiong Wang  <jiong.wang@arm.com>
 286
 287         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 288         registers.
 289         (aarch64_pseudo_register_name): Likewise.
 290         (aarch64_pseudo_register_type): Likewise.
 291         (aarch64_pseudo_register_reggroup_p): Likewise.
 292         (aarch64_gdbarch_init): Add pauth registers.
 293         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 294         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 295         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 296         (struct gdbarch_tdep): Add regnum for ra_state.
 297
 298 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 299             Jiong Wang  <jiong.wang@arm.com>
 300
 301         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 302
 303 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 304             Jiong Wang  <jiong.wang@arm.com>
 305
 306         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 307         function.
 308         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 309         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 310         (aarch64_gdbarch_init): Add puth registers.
 311         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 312         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 313         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 314
 315 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 316             Jiong Wang  <jiong.wang@arm.com>
 317
 318         * aarch64-linux-nat.c
 319         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 320         * aarch64-linux-tdep.c
 321         (aarch64_linux_core_read_description): Likewise.
 322         (aarch64_linux_get_hwcap): New function.
 323         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 324         (aarch64_linux_get_hwcap): New declaration.
 325
 326 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 327             Jiong Wang  <jiong.wang@arm.com>
 328
 329         * aarch64-linux-nat.c
 330         (aarch64_linux_nat_target::read_description): Add pauth param.
 331         * aarch64-linux-tdep.c
 332         (aarch64_linux_core_read_description): Likewise.
 333         * aarch64-tdep.c (struct target_desc): Add in pauth.
 334         (aarch64_read_description): Add pauth param.
 335         (aarch64_gdbarch_init): Likewise.
 336         * aarch64-tdep.h (aarch64_read_description): Likewise.
 337         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 338         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 339         * features/Makefile: Add new files.
 340         * features/aarch64-pauth.c: New file.
 341         * features/aarch64-pauth.xml: New file.
 342
 343 2019-03-20  Tom Tromey  <tromey@adacore.com>
 344
 345         * infrun.c (handle_inferior_event): Rename from
 346         handle_inferior_event_1.  Create a scoped_value_mark.
 347         (handle_inferior_event): Remove.
 348
 349 2019-03-19  Tom Tromey  <tromey@adacore.com>
 350
 351         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 352         * infrun.h (print_stop_event): Add "displays" parameter.
 353         * infrun.c (print_stop_event): Add "displays" parameter.
 354
 355 2019-03-19  Pedro Alves  <palves@redhat.com>
 356
 357         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 358         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 359         to -1.  Fix TABs vs spaces.
 360         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 361         * tui/tui-out.h (tui_ui_out) Add intro comments.
 362         <m_line, m_start_of_line>: In-class initialize, and add describing
 363         comment.
 364
 365 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 366
 367         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 368         variable names.
 369         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 370
 371 2019-03-18  Pedro Alves  <palves@redhat.com>
 372             Eli Zaretskii <eliz@gnu.org>
 373
 374         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 375         m_line and m_start_of_line.
 376
 377 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 378
 379         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 380         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 381         it returns a newline.  This fixes a regression in TU mode, whereby
 382         the next line is output on the same screen line as the user input.
 383
 384 2019-03-18  Tom Tromey  <tromey@adacore.com>
 385
 386         * minsyms.c (minimal_symbol_reader::install): Remove call to
 387         obstack_blank.
 388
 389 2019-03-18  Pedro Alves  <palves@redhat.com>
 390
 391         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 392         New globals.
 393         (apply_style): New, factored out from ...
 394         (apply_ansi_escape): ... this.  Handle reverse video mode.
 395         (tui_set_reverse_mode): New function.
 396         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 397         * tui/tui-winsource.c (tui_show_source_line): Use
 398         tui_set_reverse_mode instead of setting A_STANDOUT.
 399         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 400         New setter methods.
 401
 402 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 403
 404         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 405         Handle tabs.
 406
 407 2019-03-18  Tom Tromey  <tromey@adacore.com>
 408
 409         * ada-lang.c (empty_array): Add "high" parameter.
 410         (ada_evaluate_subexp): Update.
 411
 412 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 413
 414         * unittests/string_view-selftests.c: Define
 415         _initialize_string_view_selftests unconditionally.
 416
 417 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 418
 419         PR gdb/24350
 420         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 421
 422 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 423
 424         PR gdb/24351
 425         * windows-nat.c (display_selector): Fix format specifiers.
 426
 427 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 428
 429         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 430         tui_refill_source_window instead of tui_refresh_win, to update the
 431         current execution line.  This fixes redisplay of the current line
 432         when stepping through the code with "next" or "step".
 433
 434 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 435
 436         * source-cache.c (source_cache::get_source_lines): Call
 437         find_source_lines to initialize s->nlines.  This fixes vertical
 438         scrolling of TUI source window when the DOWN arrow is pressed.
 439
 440 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 441
 442         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 443         linux-thread-db.c (_initialize_thread_db): Likewise.
 444
 445 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 446
 447         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 448         wclrtoeol in tui_show_source_line".  This reverts changes made in
 449         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 450
 451 2019-03-15  Tom Tromey  <tom@tromey.com>
 452
 453         * symtab.h (struct minimal_symbol): Derive from
 454         general_symbol_info.
 455         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 456         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 457         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 458         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 459         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 460         (MSYMBOL_SEARCH_NAME): Update.
 461         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 462         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 463         * minsyms.c (minimal_symbol_reader::record_full): Update.
 464
 465 2019-03-15  Tom Tromey  <tom@tromey.com>
 466
 467         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 468
 469 2019-03-15  Tom Tromey  <tom@tromey.com>
 470
 471         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 472         unique_xmalloc_ptr.
 473         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 474         Update.
 475         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 476         (build_minimal_symbol_hash_tables)
 477         (minimal_symbol_reader::install): Update.
 478
 479 2019-03-15  Tom Tromey  <tom@tromey.com>
 480
 481         * symtab.c (create_demangled_names_hash): Update.
 482         (symbol_set_names): Update.
 483         * objfiles.h (struct objfile_per_bfd_storage)
 484         <demangled_names_hash>: Now an htab_up.
 485         * objfiles.c (objfile_per_bfd_storage): Simplify.
 486
 487 2019-03-15  Tom Tromey  <tom@tromey.com>
 488
 489         * objfiles.h (struct objfile_per_bfd_storage): Declare
 490         destructor.
 491         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 492         New.
 493         (get_objfile_bfd_data): Use new.  Don't initialize
 494         language_of_main.
 495         (free_objfile_per_bfd_storage): Remove.
 496         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 497
 498 2019-03-15  Tom Tromey  <tom@tromey.com>
 499
 500         * symfile.c (reread_symbols): Update.
 501         * objfiles.c (objfile::objfile): Update.
 502         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 503         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 504         comment.
 505         (minimal_symbol_reader::install): Update.
 506         (terminate_minimal_symbol_table): Remove.
 507         * jit.c (jit_object_close_impl): Update.
 508
 509 2019-03-15  Tom Tromey  <tom@tromey.com>
 510
 511         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 512         initializations.
 513
 514 2019-03-15  Tom Tromey  <tom@tromey.com>
 515
 516         * objfiles.h (struct objfile_per_bfd_storage)
 517         <demangled_hash_languages>: Now a bitset.
 518         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 519         (lookup_minimal_symbol): Update.
 520
 521 2019-03-15  Tom Tromey  <tom@tromey.com>
 522
 523         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 524         Don't return the symbol.
 525         * coffread.c (record_minimal_symbol): Use record_full.
 526
 527 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 528
 529         The MS-Windows port of ncurses fails to switch to a color pair if
 530         one or both of the colors are the implicit default colors.  This
 531         change records the default colors when TUI is initialized, and
 532         then specifies them explicitly when a color pair uses the default
 533         colors.  This allows color styling in TUI mode on MS-Windows.
 534
 535         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 536         ncurses_norm_attr.
 537         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 538         colors in ncurses_norm_attr.
 539         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 540         "none", replace it with the default color recorded in
 541         ncurses_norm_attr.
 542
 543 2019-03-14  Tom Tromey  <tromey@adacore.com>
 544
 545         * source-cache.h (class source_cache) <get_source_lines>: Return
 546         std::string.
 547         * source-cache.c (source_cache::extract_lines): Handle case where
 548         first_pos==npos.  Return std::string.
 549         (source_cache::get_source_lines): Update.
 550
 551 2019-03-14  Tom Tromey  <tromey@adacore.com>
 552
 553         * NEWS: Add item for "style sources" commands.
 554         * source-cache.c (source_cache::get_source_lines): Check
 555         source_styling.
 556         * cli/cli-style.c (source_styling): New global.
 557         (_initialize_cli_style): Add "style sources" commands.
 558         (show_style_sources): New function.
 559         * cli/cli-style.h (source_styling): Declare.
 560
 561 2019-03-14  Pedro Alves  <palves@redhat.com>
 562             Tom Tromey  <tromey@adacore.com>
 563
 564         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 565         * tui/tui-winsource.c (tui_refill_source_window): New function,
 566         from...
 567         (tui_horizontal_source_scroll): ... here.  Move some logic.
 568         * cli/cli-style.c (set_style_enabled): Notify new observable.
 569         * tui/tui-hooks.c (tui_redisplay_source): New function.
 570         (tui_attach_detach_observers): Attach or detach
 571         tui_redisplay_source.
 572         * observable.h (source_styling_changed): New observable.
 573         * observable.c: Define source_styling_changed observable.
 574
 575 2019-03-13  Tom Tromey  <tromey@adacore.com>
 576
 577         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 578         (i386_gnu_nat_target::store_registers): Update.
 579         * target-debug.h (target_debug_print_std_string): New macro.
 580         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 581         * windows-tdep.c (display_one_tib): Update.
 582         * tui/tui-stack.c (tui_make_status_line): Update.
 583         * top.c (print_inferior_quit_action): Update.
 584         * thread.c (thr_try_catch_cmd): Update.
 585         (add_thread_with_info): Update.
 586         (thread_target_id_str): Update.
 587         (thr_try_catch_cmd): Update.
 588         (thread_command): Update.
 589         (thread_find_command): Update.
 590         * record-btrace.c (record_btrace_target::info_record)
 591         (record_btrace_resume_thread, record_btrace_target::resume)
 592         (record_btrace_cancel_resume, record_btrace_step_thread)
 593         (record_btrace_target::wait, record_btrace_target::wait)
 594         (record_btrace_target::wait, record_btrace_target::stop): Update.
 595         * progspace.c (print_program_space): Update.
 596         * process-stratum-target.c
 597         (process_stratum_target::thread_address_space): Update.
 598         * linux-fork.c (linux_fork_mourn_inferior)
 599         (detach_checkpoint_command, info_checkpoints_command)
 600         (linux_fork_context): Update.
 601         (linux_fork_detach): Update.
 602         (class scoped_switch_fork_info): Update.
 603         (delete_checkpoint_command): Update.
 604         * infrun.c (follow_fork_inferior): Update.
 605         (follow_fork_inferior): Update.
 606         (proceed_after_vfork_done): Update.
 607         (handle_vfork_child_exec_or_exit): Update.
 608         (follow_exec): Update.
 609         (displaced_step_prepare_throw): Update.
 610         (displaced_step_restore): Update.
 611         (start_step_over): Update.
 612         (resume_1): Update.
 613         (clear_proceed_status_thread): Update.
 614         (proceed): Update.
 615         (print_target_wait_results): Update.
 616         (do_target_wait): Update.
 617         (context_switch): Update.
 618         (stop_all_threads): Update.
 619         (restart_threads): Update.
 620         (finish_step_over): Update.
 621         (handle_signal_stop): Update.
 622         (switch_back_to_stepped_thread): Update.
 623         (keep_going_pass_signal): Update.
 624         (print_exited_reason): Update.
 625         (normal_stop): Update.
 626         * inferior.c (inferior_pid_to_str): Change return type.
 627         (print_selected_inferior): Update.
 628         (add_inferior): Update.
 629         (detach_inferior): Update.
 630         * dummy-frame.c (fprint_dummy_frames): Update.
 631         * dcache.c (dcache_info_1): Update.
 632         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 633         (btrace_fetch, btrace_clear): Update.
 634         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 635         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 636         type.
 637         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 638         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 639         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 640         * gdbarch.c, gdbarch.h: Rebuild.
 641         * gdbarch.sh (core_pid_to_str): Change return type.
 642         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 643         return type.
 644         (windows_nat_target::pid_to_str): Change return type.
 645         (windows_delete_thread): Update.
 646         (windows_nat_target::attach): Update.
 647         (windows_nat_target::files_info): Update.
 648         * target-delegates.c: Rebuild.
 649         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 650         return type.
 651         (sol_thread_target::pid_to_str): Change return type.
 652         * remote.c (class remote_target) <pid_to_str>: Change return
 653         type.
 654         (remote_target::pid_to_str): Change return type.
 655         (extended_remote_target::attach, remote_target::remote_stop_ns)
 656         (remote_target::remote_notif_remove_queued_reply)
 657         (remote_target::push_stop_reply, remote_target::disable_btrace):
 658         Update.
 659         (extended_remote_target::attach): Update.
 660         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 661         type.
 662         (gdbsim_target::pid_to_str): Change return type.
 663         * ravenscar-thread.c (struct ravenscar_thread_target)
 664         <pid_to_str>: Change return type.
 665         (ravenscar_thread_target::pid_to_str): Change return type.
 666         * procfs.c (class procfs_target) <pid_to_str>: Change return
 667         type.
 668         (procfs_target::pid_to_str): Change return type.
 669         (procfs_target::attach): Update.
 670         (procfs_target::detach): Update.
 671         (procfs_target::fetch_registers): Update.
 672         (procfs_target::store_registers): Update.
 673         (procfs_target::wait): Update.
 674         (procfs_target::files_info): Update.
 675         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 676         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 677         return type.
 678         (nto_procfs_target::pid_to_str): Change return type.
 679         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 680         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 681         return type.
 682         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 683         (exit_lwp): Update.
 684         (attach_proc_task_lwp_callback, get_detach_signal)
 685         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 686         (linux_nat_target::resume, wait_lwp, stop_callback)
 687         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 688         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 689         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 690         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 691         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 692         type.
 693         (inf_ptrace_target::attach): Update.
 694         (inf_ptrace_target::files_info): Update.
 695         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 696         type.
 697         (go32_nat_target::pid_to_str): Change return type.
 698         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 699         (gnu_nat_target::wait): Update.
 700         (gnu_nat_target::wait): Update.
 701         (gnu_nat_target::resume): Update.
 702         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 703         (fbsd_nat_target::wait): Update.
 704         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 705         type.
 706         (darwin_nat_target::attach): Update.
 707         * corelow.c (class core_target) <pid_to_str>: Change return type.
 708         (core_target::pid_to_str): Change return type.
 709         * target.c (normal_pid_to_str): Change return type.
 710         (default_pid_to_str): Likewise.
 711         (target_pid_to_str): Change return type.
 712         (target_translate_tls_address): Update.
 713         (target_announce_detach): Update.
 714         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 715         return type.
 716         (bsd_uthread_target::pid_to_str): Change return type.
 717         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 718         type.
 719         (bsd_kvm_target::pid_to_str): Change return type.
 720         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 721         return type.
 722         (aix_thread_target::pid_to_str): Change return type.
 723         * target.h (struct target_ops) <pid_to_str>: Change return type.
 724         (target_pid_to_str, normal_pid_to_str): Likewise.
 725         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 726         type.
 727         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 728         type.
 729         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 730         return type.
 731         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 732         type.
 733         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 734         type.
 735         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 736         return type.
 737
 738 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 739
 740         * NEWS: Mention that the new default MI version is 3.  Mention
 741         changes to the output of commands and events that deal with
 742         multi-location breakpoints.
 743         * breakpoint.c: Include "mi/mi-out.h".
 744         (print_one_breakpoint): Change output syntax if using MI version
 745         >= 3.
 746         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 747         New.
 748         (mi_multi_location_breakpoint_output_fixed): New.
 749         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 750         (mi_cmd_fix_multi_location_breakpoint_output): New.
 751         (mi_multi_location_breakpoint_output_fixed): New.
 752         * mi/mi-cmds.c (mi_cmds): Register command
 753         -fix-multi-location-breakpoint-output.
 754         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 755         interpreter "mi".
 756
 757 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 758
 759         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 760         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 761         instantiate mi_ui_out based on interpreter name.
 762         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 763         * mi/mi-main.c (mi_load_progress): Likewise.
 764
 765 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 766
 767         * NEWS: Combine separate "New targets" sections for 8.3.
 768
 769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 770
 771         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 772         (ppcfbsd_init_abi): Install gdbarch
 773         "fetch_tls_load_module_address" and "get_thread_local_address"
 774         methods.
 775
 776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 777
 778         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 779         (riscv_fbsd_init_abi): Install gdbarch
 780         "fetch_tls_load_module_address" and "get_thread_local_address"
 781         methods.
 782
 783 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 784
 785         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 786         (i386fbsd_init_abi): Install gdbarch
 787         "fetch_tls_load_module_address" and "get_thread_local_address"
 788         methods.
 789
 790 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 791
 792         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 793         (amd64fbsd_init_abi): Install gdbarch
 794         "fetch_tls_load_module_address" and "get_thread_local_address"
 795         methods.
 796
 797 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 798
 799         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 800         (struct fbsd_pspace_data): New type.
 801         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 802         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 803         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 804         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 805         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 806
 807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 808
 809         * gdbtypes.c (lookup_struct_elt): New function.
 810         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 811         * gdbtypes.h (struct struct_elt): New type.
 812         (lookup_struct_elt): New prototype.
 813
 814 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 815
 816         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 817         remove disabled code block.
 818
 819 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 820
 821         * gdbarch.sh (get_thread_local_address): New method.
 822         * gdbarch.h, gdbarch.c: Regenerate.
 823         * target.c (target_translate_tls_address): Use
 824         gdbarch_get_thread_local_address if present instead of
 825         target::get_thread_local_address.
 826
 827 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 828
 829         * target.h (target::get_thread_local_address): Update comment.
 830
 831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 832
 833         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 834         objfile->separate_debug_objfile_backlink if not NULL.
 835
 836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 837
 838         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 839         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 840         (amd64bsd_store_inferior_registers): Likewise.
 841         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 842         Enable segment base registers.
 843         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 844         PT_GETFSBASE and PT_GETGSBASE.
 845         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 846         PT_SETGSBASE.
 847         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 848         segment base registers.
 849         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 850
 851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 852
 853         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 854         Update calls to i386_target_description to add 'segments'
 855         parameter.
 856         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 857         add segment base registers.
 858         * arch/i386.c (i386_create_target_description): Add 'segments'
 859         parameter to enable segment base registers.
 860         * arch/i386.h (i386_create_target_description): Likewise.
 861         * features/i386/32bit-segments.xml: New file.
 862         * features/i386/32bit-segments.c: Generate.
 863         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 864         call to i386_target_description to add 'segments' parameter.
 865         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 866         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 867         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 868         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 869         if feature is present.
 870         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 871         Add 'segments' parameter to call to i386_target_description.
 872         (i386_target_description): Add 'segments' parameter to enable
 873         segment base registers.
 874         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 875         to call to i386_target_description.
 876         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 877         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 878         Define I386_NUM_REGS.
 879         (i386_target_description): Add 'segments' parameter to enable
 880         segment base registers.
 881
 882 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 883
 884         PR/24325
 885         * source-cache.c: #undef open and close, to avoid unresolved
 886         externals during linking.
 887
 888 2019-03-12  Tom Tromey  <tromey@adacore.com>
 889
 890         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 891         const.  Add initializers.
 892         (_initialize_remote): Don't initialize ptid globals.
 893
 894 2019-03-12  Pedro Alves  <palves@redhat.com>
 895
 896         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 897
 898 2019-03-12  Pedro Alves  <palves@redhat.com>
 899
 900         * cp-name-parser.y (main): Remove unused 'len' variable.
 901
 902 2019-03-12  Tom Tromey  <tromey@adacore.com>
 903
 904         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 905         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 906
 907 2019-03-12  Tom Tromey  <tromey@adacore.com>
 908
 909         * linux-nat.c (iterate_over_lwps): Update.
 910         (stop_callback): Remove parameter.
 911         (stop_wait_callback, detach_callback, resume_set_callback)
 912         (select_singlestep_lwp_callback, set_ignore_sigint)
 913         (status_callback, resumed_callback, resume_clear_callback)
 914         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 915         data parameter.
 916         (linux_nat_target::detach, linux_nat_target::resume)
 917         (linux_stop_and_wait_all_lwps, select_event_lwp)
 918         (linux_nat_filter_event, linux_nat_wait_1)
 919         (linux_nat_target::kill, linux_nat_target::stop)
 920         (linux_nat_target::stop): Update.
 921         (linux_nat_resume_callback): Change type.
 922         (resume_stopped_resumed_lwps, count_events_callback)
 923         (select_event_lwp_callback): Likewise.
 924         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 925         * arm-linux-nat.c (struct update_registers_data): Remove.
 926         (update_registers_callback): Change type.
 927         (arm_linux_insert_hw_breakpoint1): Update.
 928         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 929         parameter.
 930         (x86_linux_dr_set_addr): Update.
 931         (x86_linux_dr_set_control): Update.
 932         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 933         (iterate_over_lwps): Use gdb::function_view.
 934         * nat/aarch64-linux-hw-point.c (struct
 935         aarch64_dr_update_callback_param): Remove.
 936         (debug_reg_change_callback): Change type.
 937         (aarch64_notify_debug_reg_change): Update.
 938         * s390-linux-nat.c (s390_refresh_per_info): Update.
 939
 940 2019-03-11  Tom Tromey  <tromey@adacore.com>
 941
 942         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 943         redundant assignment to "this_cu".
 944
 945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 946
 947         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 948
 949 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 950
 951         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 952         from...
 953         (rank_one_type): ... this.
 954
 955 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 956
 957         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 958         from...
 959         (rank_one_type): ... this.
 960
 961 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 962
 963         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 964         from...
 965         (rank_one_type): ... this.
 966
 967 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 968
 969         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 970         from...
 971         (rank_one_type): ... this.
 972
 973 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 974
 975         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 976         from...
 977         (rank_one_type): ... this.
 978
 979 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 980
 981         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 982         from...
 983         (rank_one_type): ... this.
 984
 985 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 986
 987         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 988         from...
 989         (rank_one_type): ... this.
 990
 991 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 992
 993         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 994         from...
 995         (rank_one_type): ... this.
 996
 997 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 998
 999         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1000         from...
1001         (rank_one_type): ... this.
1002
1003 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1004
1005         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1006         from...
1007         (rank_one_type): ... this.
1008
1009 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1010
1011         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1012         from...
1013         (rank_one_type): ... this.
1014
1015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1016
1017         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1018         from...
1019         (rank_one_type): ... this.
1020
1021 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1022
1023         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1024         inferior-events' shows the example events.
1025
1026 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1027
1028         Support styling on native MS-Windows console
1029
1030         PR/24315
1031         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1032         on MS-Windows if $TERM is not defined.
1033
1034         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1035
1036         * posix-hdep.c (gdb_console_fputs):
1037         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1038         functions.
1039         * ui-file.h (gdb_console_fputs): Add prototype.
1040
1041         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1042         back to fputs only if the former returns zero.
1043
1044 2019-03-07  Tom Tromey  <tom@tromey.com>
1045
1046         * symmisc.c (print_symbol_bcache_statistics): Update.
1047         (print_objfile_statistics): Update.
1048         * symfile.c (allocate_symtab): Update.
1049         * stabsread.c: Don't include bcache.h.
1050         * psymtab.h (struct psymbol_bcache): Don't declare.
1051         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1052         (psymbol_bcache_init, psymbol_bcache_free)
1053         (psymbol_bcache_get_bcache): Don't declare.
1054         * psymtab.c (struct psymbol_bcache): Remove.
1055         (psymtab_storage::psymtab_storage): Update.
1056         (psymtab_storage::~psymtab_storage): Update.
1057         (psymbol_bcache_init, psymbol_bcache_free)
1058         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1059         (add_psymbol_to_bcache): Update.
1060         (allocate_psymtab): Update.
1061         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1062         macro_cache>: No longer pointers.
1063         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1064         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1065         * macrotab.c (macro_bcache): Update.
1066         * macroexp.c: Don't include bcache.h.
1067         * gdbtypes.c (check_types_worklist): Update.
1068         (types_deeply_equal): Remove TRY/CATCH.  Update.
1069         * elfread.c (elf_symtab_read): Update.
1070         * dwarf2read.c: Don't include bcache.h.
1071         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1072         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1073         (print_bcache_statistics, bcache_memory_used): Don't declare.
1074         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1075         methods.  Rename all data members.
1076         * bcache.c (struct bcache): Move to bcache.h.
1077         (bcache::expand_hash_table): Rename from expand_hash_table.
1078         (bcache): Remove.
1079         (bcache::insert): Rename from bcache_full.
1080         (bcache::compare): Rename from bcache_compare.
1081         (bcache_xmalloc): Remove.
1082         (bcache::~bcache): Rename from bcache_xfree.
1083         (bcache::print_statistics): Rename from print_bcache_statistics.
1084         (bcache::memory_used): Rename from bcache_memory_used.
1085
1086 2019-03-07  Pedro Alves  <palves@redhat.com>
1087
1088         * infrun.c (normal_stop): Also check for
1089         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1090
1091 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1092
1093         * f-lang.c (value_from_host_double): Moved to...
1094         * value.c (value_from_host_double): ...here.
1095         * value.h (value_from_host_double): Declare.
1096         * guile/scm-math.c (vlscm_convert_typed_number): Use
1097         value_from_host_double.
1098         (vlscm_convert_number): Likewise.
1099         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1100         * python/py-value.c (convert_value_from_python): Likewise.
1101
1102 2019-03-06  Tom Tromey  <tom@tromey.com>
1103
1104         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1105
1106 2019-03-06  Tom Tromey  <tom@tromey.com>
1107
1108         * utils.h (free_current_contents): Don't declare.
1109         * utils.c (free_current_contents): Remove.
1110
1111 2019-03-06  Tom Tromey  <tom@tromey.com>
1112
1113         * top.c (quit_force): Update.
1114         * main.c (captured_command_loop): Update.
1115         * common/new-op.c (operator new): Update.
1116         * common/common-exceptions.c (struct catcher)
1117         <save_cleanup_chain>: Remove member.
1118         (exceptions_state_mc_init): Update.
1119         (exception_try_scope_entry): Return nullptr.
1120         (exception_try_scope_exit, exception_rethrow)
1121         (throw_exception_sjlj, throw_exception_cxx): Update.
1122         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1123         (all_cleanups, do_cleanups, discard_cleanups)
1124         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1125         (restore_cleanups, restore_final_cleanups): Don't declare.
1126         (do_final_cleanups): Remove parameter.
1127         * common/cleanups.c (cleanup_chain, make_cleanup)
1128         (make_cleanup_dtor, all_cleanups, do_cleanups)
1129         (discard_my_cleanups, discard_cleanups)
1130         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1131         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1132         (null_cleanup): Remove.
1133         (do_final_cleanups): Remove parameter.
1134
1135 2019-03-06  Tom Tromey  <tom@tromey.com>
1136
1137         * remote.c (remote_target::remote_parse_stop_reply): Use
1138         unique_xmalloc_ptr.
1139
1140 2019-03-06  Tom Tromey  <tom@tromey.com>
1141
1142         * stabsread.c (struct stabs_field_info): Rename from field_info.
1143         <list, fnlist>: Add initializers.
1144         <obstack>: New member.
1145         (read_member_functions, read_struct_fields, read_baseclasses):
1146         Allocate on obstack.  Don't use cleanups.
1147         (read_one_struct_field, read_member_functions, read_struct_fields)
1148         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1149         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1150         (read_struct_type): Update.
1151
1152 2019-03-06  Tom Tromey  <tom@tromey.com>
1153
1154         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1155         * common/filestuff.h (make_cleanup_close): Don't declare.
1156         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1157         Remove.
1158
1159 2019-03-06  Tom Tromey  <tom@tromey.com>
1160
1161         * solib-aix.c: Use make_scope_exit.
1162
1163 2019-03-06  Tom Tromey  <tom@tromey.com>
1164
1165         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1166         Use make_scope_exit.
1167
1168 2019-03-06  Tom Tromey  <tom@tromey.com>
1169
1170         * solib-svr4.c (disable_probes_interface): Remove parameter.
1171         (svr4_handle_solib_event): Use make_scope_exit.
1172
1173 2019-03-06  Tom Tromey  <tom@tromey.com>
1174
1175         * remote.c (struct stop_reply_deleter): Remove.
1176         (stop_reply_up): Update.
1177         (struct stop_reply): Derive from notif_event.  Don't typedef.
1178         <regcache>: Now a std::vector.
1179         (stop_reply_xfree): Remove.
1180         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1181         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1182         (remote_target::discard_pending_stop_replies): Use delete.
1183         (remote_target::remote_parse_stop_reply): Update.
1184         (remote_target::process_stop_reply): Update.
1185         * remote-notif.h (struct notif_event): Add virtual destructor.
1186         Remove "dtr" member.
1187         (struct notif_client) <alloc_event>: Return a unique_ptr.
1188         (notif_event_xfree): Don't declare.
1189         (notif_event_up): New typedef.
1190         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1191         (notif_event_xfree, do_notif_event_xfree): Remove.
1192         (remote_notif_state_xfree): Update.
1193
1194 2019-03-06  Tom Tromey  <tom@tromey.com>
1195
1196         * infrun.c (displaced_step_clear_cleanup): Now a
1197         forward_scope_exit type.
1198         (displaced_step_prepare_throw): Update.
1199         (displaced_step_fixup): Update.
1200
1201 2019-03-06  Tom Tromey  <tom@tromey.com>
1202
1203         * inferior.h (class inferior): Update comment.
1204         * gdbthread.h (class thread_info): Update comment.
1205
1206 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1207             Tom Tromey  <tom@tromey.com>
1208
1209         * stabsread.h (struct stab_section_list): Remove.
1210         (coffstab_build_psymtabs): Update.
1211         * dbxread.c (symbuf_sections): Now a std::vector.
1212         (sect_idx): New global.
1213         (fill_symbuf): Update.
1214         (coffstab_build_psymtabs): Change type of stabsects parameter.
1215         Update.
1216         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1217         std::vector.
1218         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1219         (coff_locate_sections): Update.
1220         (coff_symfile_read): Remove cleanups.  Update.
1221         (init_stringtab): Add storage parameter.
1222         (free_stringtab, free_stringtab_cleanup): Remove.
1223         (init_lineno): Add storage parameter.
1224         (free_linetab, free_linetab_cleanup): Remove.
1225
1226 2019-03-06  Pedro Alves  <palves@redhat.com>
1227
1228         * linux-fork.c (fork_info::clobber_regs): Delete.
1229         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1230         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1231         comment.  Adjust.
1232         (scoped_switch_fork_info::scoped_switch_fork_info)
1233         (checkpoint_command, linux_fork_context): Adjust
1234         fork_save_infrun_state calls.
1235
1236 2019-03-06  Pedro Alves  <palves@redhat.com>
1237
1238         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1239         (inf_has_multiple_threads): Return 'bool' and rewrite using
1240         inferior_info::threads().
1241
1242 2019-03-06  Pedro Alves  <palves@redhat.com>
1243
1244         * linux-fork.c: Include <list>.
1245         (fork_list): Now a std::list instance.
1246         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1247         (forks_exist_p, find_last_fork): Adjust.
1248         (new_fork): Delete.
1249         (one_fork_p): New.
1250         (add_fork): Adjust.
1251         (free_fork): Delete, folded into fork_info::~fork_info().
1252         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1253         Adjust.
1254         (init_fork_list): Delete.
1255         (linux_fork_killall, linux_fork_mourn_inferior)
1256         (linux_fork_detach, info_checkpoints_command): Adjust.
1257         (_initialize_linux_fork): No longer call init_fork_list.
1258
1259 2019-03-06  Pedro Alves  <palves@redhat.com>
1260
1261         * linux-fork.c (new_fork): New, split out of ...
1262         (add_fork): ... this.  Return void.  Move "first fork" special
1263         case from here, to ...
1264         (checkpoint_command): ... here.
1265         * linux-linux.h (add_fork): Return void.
1266
1267 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1268
1269         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1270
1271 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1272             Chris January  <chris.january@arm.com>
1273             David Lecomber  <david.lecomber@arm.com>
1274
1275         * f-exp.y: New token, UNOP_INTRINSIC.
1276         (exp): New pattern using UNOP_INTRINSIC token.
1277         (f77_keywords): Add 'abs' keyword.
1278         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1279         (value_from_host_double): New function.
1280         (evaluate_subexp_f): Support UNOP_ABS.
1281
1282 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1283
1284         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1285         types.
1286
1287 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1290         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1291         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1292
1293 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1294
1295         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1296
1297 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1298             Chris January  <chris.january@arm.com>
1299
1300         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1301         * f-exp.y: Define 'KIND' token.
1302         (exp): New pattern for KIND expressions.
1303         (ptype): Handle types with a kind extension.
1304         (direct_abs_decl): Extend to spot kind extensions.
1305         (f77_keywords): Add 'kind' to the list.
1306         (push_kind_type): New function.
1307         (convert_to_kind_type): New function.
1308         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1309         * parse.c (operator_length_standard): Likewise.
1310         * parser-defs.h (enum type_pieces): Add tp_kind.
1311         * std-operator.def: Add UNOP_KIND.
1312
1313 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1314
1315         * f-exp.y (f_parse): Set yydebug.
1316
1317 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * f-lang.c (evaluate_subexp_f): New function.
1320         (exp_descriptor_f): New global.
1321         (f_language_defn): Use exp_descriptor_f instead of
1322         exp_descriptor_standard.
1323
1324 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * f-exp.y (struct token): Add comments.
1327         (dot_ops): Remove uppercase versions and the end marker.
1328         (f77_keywords): Likewise.
1329         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1330         entries in the dot_ops array are case insensitive, and use
1331         strncasecmp to compare strings.  Also some whitespace cleanup in
1332         this area.  Similar for the f77_keywords array, except entries in
1333         this list might be case sensitive.
1334
1335 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * f-exp.y (struct f77_boolean_val): Add comments.
1338         (boolean_values): Remove uppercase versions, and end marker.
1339         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1340         and use strncasecmp to achieve case insensitivity.  Additionally,
1341         perform whitespace cleanup around this code.
1342
1343 2019-03-06  Tom Tromey  <tromey@adacore.com>
1344
1345         * remote-sim.c (gdbsim_target_open): Use result of
1346         gdb_argv::release.
1347
1348 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1349         Dirk Schubert  <dirk.schubert@arm.com>
1350         Chris January  <chris.january@arm.com>
1351
1352         * eval.c (evaluate_subexp_standard): Call Fortran argument
1353         wrapping logic.
1354         * f-lang.c (struct value): A value which can be passed into a
1355         Fortran function call.
1356         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1357         where appropriate.
1358         (struct type): Value ready for a Fortran function call.
1359         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1360         is needed.
1361         * f-lang.h (fortran_argument_convert): Declaration.
1362         (fortran_preserve_arg_pointer): Declaration.
1363         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1364
1365 2019-03-05  Tom Tromey  <tromey@adacore.com>
1366
1367         * python/py-prettyprint.c (print_string_repr): Remove #if.
1368         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1369
1370 2019-03-05  Tom Tromey  <tromey@adacore.com>
1371
1372         * target.c (the_dummy_target): Move later.  Change type to
1373         "dummy_target".
1374         (initialize_targets): Don't initialize the_dummy_target.
1375
1376 2019-03-05  Tom Tromey  <tromey@adacore.com>
1377
1378         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1379         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1380
1381 2019-03-05  Tom Tromey  <tromey@adacore.com>
1382
1383         * windows-nat.c (windows_nat_target::attach)
1384         (windows_nat_target::detach): Don't call gdb_flush.
1385         * valprint.c (generic_val_print, val_print, val_print_string):
1386         Don't call gdb_flush.
1387         * utils.c (defaulted_query): Don't call gdb_flush.
1388         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1389         * target.c (target_announce_detach): Don't call gdb_flush.
1390         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1391         * remote.c (extended_remote_target::attach): Don't call
1392         gdb_flush.
1393         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1394         * printcmd.c (do_examine): Don't call gdb_flush.
1395         (info_display_command): Don't call gdb_flush.
1396         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1397         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1398         * memattr.c (info_mem_command): Don't call gdb_flush.
1399         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1400         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1401         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1402         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1403         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1404         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1405         (gnu_nat_target::detach): Don't call gdb_flush.
1406         * f-valprint.c (f_val_print): Don't call gdb_flush.
1407         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1408         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1409         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1410         gdb_flush.
1411         * c-valprint.c (c_val_print): Don't call gdb_flush.
1412         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1413
1414 2019-03-05  Tom Tromey  <tromey@adacore.com>
1415
1416         * varobj.c (update_dynamic_varobj_children): Update.
1417         (install_default_visualizer): Use reset, not release.
1418         * value.c (set_internalvar): Update.
1419         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1420         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1421         ATTRIBUTE_UNUSED_RESULT.
1422
1423 2019-03-05  Tom Tromey  <tromey@adacore.com>
1424
1425         * remote.c (class scoped_remote_fd) <release>: Add
1426         ATTRIBUTE_UNUSED_RESULT.
1427
1428 2019-03-05  Tom Tromey  <tromey@adacore.com>
1429
1430         * macroexp.c (struct macro_buffer) <release>: Add
1431         ATTRIBUTE_UNUSED_RESULT.
1432
1433 2019-03-05  Tom Tromey  <tromey@adacore.com>
1434
1435         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1436         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1437         ATTRIBUTE_UNUSED_RESULT.
1438
1439 2019-03-05  Tom Tromey  <tromey@adacore.com>
1440
1441         * common/scoped_fd.h (class scoped_fd) <release>: Add
1442         ATTRIBUTE_UNUSED_RESULT.
1443
1444 2019-03-05  Tom Tromey  <tromey@adacore.com>
1445
1446         * parser-defs.h (struct parser_state) <release>: Add
1447         ATTRIBUTE_UNUSED_RESULT.
1448
1449 2019-03-05  Tom Tromey  <tromey@adacore.com>
1450
1451         * utils.h (class gdb_argv) <release>: Add
1452         ATTRIBUTE_UNUSED_RESULT.
1453         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1454
1455 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1456
1457         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1458         for-loop range, to avoid compiler warnings.
1459
1460         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1461         avoid compiler warnings about unused variables.
1462
1463         * NEWS: Mention end of support for native debugging on MS-Windows
1464         before XP.
1465
1466         PR gdb/24292
1467         * common/netstuff.c:
1468         * gdbserver/gdbreplay.c
1469         * gdbserver/remote-utils.c:
1470         * ser-tcp.c:
1471         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1472         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1473         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1474         'getaddrinfo' and 'freeaddrinfo' were not available before
1475         Windows XP, and mingw.org's MinGW headers by default define
1476         _WIN32_WINNT to 0x500.
1477
1478 2019-03-01  Gary Benson <gbenson@redhat.com>
1479
1480         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1481
1482 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1483             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1484
1485         PR gdb/8527
1486         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1487         set_sigint_trap, clear_sigint_trap.
1488
1489 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1490
1491         * target.c (target_detach): Clear the regcache and the
1492         frame cache.
1493
1494 2019-02-27  Pedro Alves  <palves@redhat.com>
1495
1496         * utils.c (set_screen_size): When we cap the height/width sizes,
1497         tweak the corresponding command variable to show "unlimited":
1498
1499 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1500             Pedro Alves  <palves@redhat.com>
1501
1502         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1503         before calling rl_set_screen_size.
1504
1505 2019-02-27  Tom Tromey  <tromey@adacore.com>
1506
1507         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1508         define.
1509         * python/py-value.c: Remove Python 2.4 workaround.
1510         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1511         workaround.
1512         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1513         Python 2.4 workaround.
1514         * python/python-internal.h: Remove Python 2.4 comment.
1515         (Py_ssize_t): Don't define.
1516         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1517         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1518         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1519         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1520         * python/python.c (do_start_initialization): Remove Python 2.4
1521         workaround.
1522         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1523         (print_children): Remove Python 2.4 workaround.
1524         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1525         workaround.
1526         (CHARBUFFERPROC_NAME): Remove.
1527         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1528         Python 2.4 workaround.
1529
1530 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1531
1532         * NEWS: Note minimum Python version.
1533
1534 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1535
1536         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1537         code from these functions.  Remove corresponding ifdefs.  Use
1538         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1539         Remove gotos and target of gotos.
1540         (infpy_search_memory): Likewise.
1541
1542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1545         (hppa_gdbarch_init): Don't register deleted functions with
1546         gdbarch.
1547
1548 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1549
1550         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1551         (h8300_unwind_sp): Delete.
1552         (h8300_dummy_id): Delete.
1553         (h8300_gdbarch_init): Don't register deleted functions with
1554         gdbarch.
1555
1556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1559         (ft32_unwind_pc): Delete.
1560         (ft32_unwind_sp): Delete.
1561         (ft32_gdbarch_init): Don't register deleted functions with
1562         gdbarch.
1563
1564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1565
1566         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1567         (frv_unwind_pc): Delete.
1568         (frv_unwind_sp): Delete.
1569         (frv_gdbarch_init): Don't register deleted functions with
1570         gdbarch.
1571
1572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1575         (riscv_unwind_pc): Delete.
1576         (riscv_unwind_sp): Delete.
1577         (riscv_gdbarch_init): Don't register deleted functions with
1578         gdbarch.
1579
1580 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1583         (csky_unwind_pc): Delete.
1584         (csky_unwind_sp): Delete.
1585         (csky_gdbarch_init): Don't register deleted functions with
1586         gdbarch.
1587
1588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1591         (cris_unwind_pc): Delete.
1592         (cris_unwind_sp): Delete.
1593         (cris_gdbarch_init): Don't register deleted functions with
1594         gdbarch.
1595
1596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1597
1598         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1599         (bfin_unwind_pc): Delete.
1600         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1601
1602 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1603
1604         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1605         (arm_unwind_pc): Delete.
1606         (arm_unwind_sp): Delete.
1607         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1608
1609 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1610
1611         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1612         (arc_unwind_pc): Delete.
1613         (arc_unwind_sp): Delete.
1614         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1615
1616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1617
1618         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1619         (alpha_unwind_pc): Delete.
1620         (alpha_gdbarch_init): Don't register deleted functions with
1621         gdbarch.
1622
1623 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1624
1625         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1626         (aarch64_unwind_pc): Delete.
1627         (aarch64_unwind_sp): Delete.
1628         (aarch64_gdbarch_init): Don't register deleted functions with
1629         gdbarch.
1630
1631 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1632
1633         * gdbtypes.c (type_align): Don't consider static members when
1634         computing structure alignment.
1635
1636 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1637
1638         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1639         return 0 for other types.
1640         * arch-utils.c (default_type_align): Always return 0.
1641         * gdbarch.h: Regenerate.
1642         * gdbarch.sh (type_align): Extend comment.
1643         * gdbtypes.c (type_align): Add additional comments, always call
1644         gdbarch_type_align before applying the default rules.
1645         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1646         generic code will then apply a suitable default.
1647         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1648         types, return 0 for other types.
1649
1650 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1651
1652         * NEWS: Create a new section for the next release branch.
1653         Rename the section of the current branch, now that it has
1654         been cut.
1655
1656 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1657
1658         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1659         * version.in: Bump version to 8.3.50.DATE-git.
1660
1661 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1662
1663         * aix-thread.c (ptid_cmp): Remove unused variable.
1664         (get_signaled_thread): Likewise.
1665         (store_regs_user_thread): Likewise.
1666         (store_regs_kernel_thread): Likewise.
1667         (fetch_regs_kernel_thread): Remove shadowed variable.
1668
1669 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1670
1671         * features/riscv/32bit-cpu.xml: Add register numbers.
1672         * features/riscv/32bit-fpu.c: Regenerate.
1673         * features/riscv/32bit-fpu.xml: Add register numbers.
1674         * features/riscv/64bit-cpu.xml: Add register numbers.
1675         * features/riscv/64bit-fpu.c: Regenerate.
1676         * features/riscv/64bit-fpu.xml: Add register numbers.
1677
1678 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1679
1680         * NEWS: Mention two argument form of gdb.Value constructor.
1681         * python/py-value.c (convert_buffer_and_type_to_value): New
1682         function.
1683         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1684         Add support for handling an optional second argument.  Call
1685         convert_buffer_and_type_to_value as appropriate.
1686         * python/python-internal.h (Py_buffer_deleter): New struct.
1687         (Py_buffer_up): New typedef.
1688
1689 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1690
1691         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1692         instead of releasing ownership.
1693
1694 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1695
1696         * dwarf2read.c (open_and_init_dwp_file): Call
1697         elf_numsections instead of bfd_count_sections to initialize
1698         dwp_file->num_sections.
1699
1700 2019-02-25  Tom Tromey  <tromey@adacore.com>
1701
1702         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1703
1704 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1705
1706         * gcore.in: Add '--readnever' option when invoking GDB.
1707
1708 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1709
1710         * MAINTAINERS: Update my email address.
1711
1712 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1713
1714         * build-id.c (build_id_to_debug_bfd_1): New function.
1715         (build_id_to_debug_bfd): Look for separate debug file in
1716         sysroot.
1717
1718 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1719
1720         * gdbarch.sh: Update the copyright year range that is placed into
1721         generated files.
1722
1723 2019-02-22  Keith Seitz  <keiths@redhat.com>
1724
1725         PR symtab/23853
1726         * linespec.c (create_sals_line_offset): Search for the default
1727         symtab's filename instead of its fullname.
1728
1729 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1730
1731         * NEWS: Update style defaults.
1732
1733 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1734
1735         * main.c (captured_main_1): Disable styling in batch mode.
1736
1737 2019-02-20  Tom Tromey  <tom@tromey.com>
1738
1739         * symtab.c (symtab_symbol_info): Fix typos.
1740
1741 2019-02-20  Tom Tromey  <tromey@adacore.com>
1742
1743         * findcmd.c (_initialize_mem_search): Use upper case for
1744         metasyntactic variables.
1745
1746 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1747
1748         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1749         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1750
1751 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1752
1753         * top.h (source_file_name): Change to std::string.
1754         * top.c (source_file_name): Likewise.
1755         (command_line_input): Adjust.
1756         * cli/cli-script.c (script_from_file): Adjust.
1757
1758 2019-02-19  Tom Tromey  <tromey@adacore.com>
1759
1760         * ravenscar-thread.c
1761         (ravenscar_thread_target::update_thread_list): Don't call
1762         ada_build_task_list.
1763         * ada-lang.h (ada_build_task_list): Don't declare.
1764         * ada-tasks.c (struct ada_tasks_inferior_data)
1765         <task_list_valid_p>: Now bool.
1766         (read_known_tasks, ada_task_list_changed)
1767         (ada_tasks_invalidate_inferior_data): Update.
1768         (read_known_tasks_array): Return bool.
1769         (read_known_tasks_list): Likewise.
1770         (read_known_tasks): Return void.
1771         (ada_build_task_list): Now static.
1772
1773 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1776         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1777
1778 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1779
1780         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1781         variant for ada_tasks_pspace_data_handle and
1782         ada_tasks_inferior_data_handle.
1783         (ada_tasks_pspace_data_cleanup): New function.
1784         (ada_tasks_inferior_data_cleanup): New function.
1785
1786 2019-02-17  Tom Tromey  <tom@tromey.com>
1787
1788         * macrotab.h (macro_source_fullname): Return a std::string.
1789         * macrotab.c (macro_include, check_for_redefinition)
1790         (macro_undef, macro_lookup_definition, foreach_macro)
1791         (foreach_macro_in_scope): Update.
1792         (macro_source_fullname): Return a std::string.
1793         * macrocmd.c (show_pp_source_pos): Update.
1794
1795 2019-02-17  Tom Tromey  <tom@tromey.com>
1796
1797         * macrocmd.c (show_pp_source_pos): Style the file names.
1798
1799 2019-02-17  Tom Tromey  <tom@tromey.com>
1800
1801         PR tui/24197:
1802         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1803
1804 2019-02-17  Tom Tromey  <tom@tromey.com>
1805
1806         * ada-lang.c (user_select_syms): Use filtered printing.
1807         * utils.c (wrap_style): New global.
1808         (desired_style): Remove.
1809         (emit_style_escape): Add stream parameter.
1810         (set_output_style, reset_terminal_style, prompt_for_continue):
1811         Update.
1812         (flush_wrap_buffer): Only flush gdb_stdout.
1813         (wrap_here): Set wrap_style.
1814         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1815         treat escape sequences as a character.  Change when wrap buffer is
1816         flushed.
1817         (fputs_styled): Do not set the output style when the default is
1818         requested.
1819         * ui-style.h (struct ui_file_style) <is_default>: New method.
1820         * source.c (print_source_lines_base): Emit escape sequences in one
1821         piece.
1822
1823 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1824
1825         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1826         integers and enumeration types.
1827
1828 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1829
1830         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1831         instead of lookup_symbol_in_language
1832         (do_exact_match): New function.
1833         (ada_get_symbol_name_matcher): Return do_exact_match when
1834         doing a verbatim match.
1835
1836 2019-02-15  Tom Tromey  <tromey@adacore.com>
1837
1838         * ravenscar-thread.c (ravenscar_thread_target::resume)
1839         (ravenscar_thread_target::wait): Special case wildcard requests.
1840
1841 2019-02-15  Tom Tromey  <tromey@adacore.com>
1842
1843         * ravenscar-thread.c (base_ptid): Remove.
1844         (struct ravenscar_thread_target) <close>: New method.
1845         <m_base_ptid>: New member.
1846         <update_inferior_ptid, active_task, task_is_currently_active,
1847         runtime_initialized>: Declare methods.
1848         <ravenscar_thread_target>: Add constructor.
1849         (ravenscar_thread_target::task_is_currently_active)
1850         (ravenscar_thread_target::update_inferior_ptid)
1851         (ravenscar_runtime_initialized): Rename.  Now methods.
1852         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1853         (ravenscar_thread_target::update_thread_list): Update.
1854         (ravenscar_thread_target::active_task): Now method.
1855         (ravenscar_thread_target::store_registers)
1856         (ravenscar_thread_target::prepare_to_store)
1857         (ravenscar_thread_target::prepare_to_store)
1858         (ravenscar_thread_target::mourn_inferior): Update.
1859         (ravenscar_inferior_created): Use "new" to create target.
1860         (ravenscar_thread_target::get_ada_task_ptid): Update.
1861         (_initialize_ravenscar): Don't initialize base_ptid.
1862         (ravenscar_ops): Remove global.
1863
1864 2019-02-15  Tom Tromey  <tromey@adacore.com>
1865
1866         * target.h (push_target): Declare new overload.
1867         * target.c (push_target): New overload, taking an rvalue reference.
1868         * remote.c (remote_target::open_1): Use push_target overload.
1869         * corelow.c (core_target_open): Use push_target overload.
1870
1871 2019-02-15  Tom Tromey  <tromey@adacore.com>
1872
1873         * ravenscar-thread.c (is_ravenscar_task)
1874         (ravenscar_task_is_currently_active): Return bool.
1875         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1876         (_initialize_ravenscar): Remove "(void)".
1877         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1878         Return bool.
1879
1880 2019-02-15  Tom Tromey  <tromey@adacore.com>
1881
1882         * ravenscar-thread.c (ravenscar_runtime_initializer)
1883         (has_ravenscar_runtime, get_running_thread_id)
1884         (ravenscar_thread_target::resume): Fix indentation.
1885
1886 2019-02-15  Tom Tromey  <tromey@adacore.com>
1887
1888         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1889         from ravenscar_arch_ops.
1890         (sparc_ravenscar_ops::fetch_registers)
1891         (sparc_ravenscar_ops::store_registers): Now methods.
1892         (sparc_ravenscar_prepare_to_store): Remove.
1893         (sparc_ravenscar_ops): Redefine.
1894         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1895         methods and destructor.  Remove members.
1896         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1897         (ravenscar_thread_target::store_registers)
1898         (ravenscar_thread_target::prepare_to_store): Update.
1899         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1900         Remove.
1901         (struct ppc_ravenscar_powerpc_ops): Derive from
1902         ravenscar_arch_ops.
1903         (ppc_ravenscar_powerpc_ops::fetch_registers)
1904         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1905         (ppc_ravenscar_powerpc_ops): Redefine.
1906         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1907         (ppc_ravenscar_e500_ops::fetch_registers)
1908         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1909         (ppc_ravenscar_e500_ops): Redefine.
1910         * aarch64-ravenscar-thread.c
1911         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1912         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1913         (aarch64_ravenscar_fetch_registers)
1914         (aarch64_ravenscar_store_registers): Now methods.
1915         (aarch64_ravenscar_ops): Redefine.
1916
1917 2019-02-15  Tom Tromey  <tromey@adacore.com>
1918
1919         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1920         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1921         (ravenscar_thread_target::stopped_by_watchpoint)
1922         (ravenscar_thread_target::stopped_data_address)
1923         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1924
1925 2019-02-15  Tom Tromey  <tromey@adacore.com>
1926
1927         * ravenscar-thread.c: Fix some typos.
1928
1929 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1930             Tom Tromey  <tromey@adacore.com>
1931
1932         * ada-lang.c (ada_exception_sal): Change addr_string to a
1933         std::string.
1934         (create_ada_exception_catchpoint): Update.
1935
1936 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1937             Tom Tromey  <tromey@adacore.com>
1938
1939         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1940         (bp_location_ops): Remove.
1941         (base_breakpoint_allocate_location): Update.
1942         (free_bp_location): Update.
1943         * ada-lang.c (class ada_catchpoint_location)
1944         <ada_catchpoint_location>: Remove ops parameter.
1945         (ada_catchpoint_location_dtor): Remove.
1946         (ada_catchpoint_location_ops): Remove.
1947         (allocate_location_exception): Update.
1948         * breakpoint.h (struct bp_location_ops): Remove.
1949         (class bp_location) <bp_location>: Remove bp_location_ops
1950         parameter.
1951         <~bp_location>: Add destructor.
1952         <ops>: Remove.
1953
1954 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1955             Pedro Alves  <palves@redhat.com>
1956
1957         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1958         'PATH_MAX'.
1959
1960 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1961             Samuel Thibault  <samuel.thibault@gnu.org>
1962             Thomas Schwinge  <thomas@codesourcery.com>
1963
1964         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1965         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1966
1967 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1968
1969         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1970         (check_empty): Use "const char *".
1971
1972         * gnu-nat.c (gnu_nat_target::detach): Instead of
1973         'detach_inferior (pid)' call
1974         'detach_inferior (find_inferior_pid (pid))'.
1975
1976         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1977         'nat/fork-inferior.o'.
1978         * gnu-nat.c: #include "nat/fork-inferior.h".
1979
1980         * gnu-nat.c (gnu_nat_target::detach): Instead of
1981         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1982         * gnu-nat.h: #include "inf-child.h".
1983         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1984         'i386_gnu_nat_target::fetch_registers'.
1985         (gnu_store_registers): Rename/move to
1986         'i386_gnu_nat_target::store_registers'.
1987
1988         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1989         * gnu-nat.h (mach_thread_info): New function.
1990         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1991
1992         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1993
1994 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1995
1996         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1997
1998 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1999
2000         * windows-nat.c (windows_add_thread): Add new parameter
2001         "main_thread_p" with default value set to false.  Update
2002         function documentation as well as all callers.
2003         (windows_delete_thread): Likewise.
2004         (fake_create_process): Update call to windows_add_thread.
2005         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2006         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2007         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2008         call to windows_delete_thread.
2009
2010 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2011
2012         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2013
2014 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2015
2016         * symfile.c (find_separate_debug_file): Use canonical path of
2017         sysroot with child_path instead of gdb_sysroot if it is valid.
2018
2019 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2020
2021         * symfile.c (find_separate_debug_file): Use child_path to
2022         determine if an object file is under a sysroot.
2023
2024 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2025
2026         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2027         unittests/child-path-selftests.c.
2028         * common/pathstuff.c (child_path): New function.
2029         * common/pathstuff.h (child_path): New prototype.
2030         * unittests/child-path-selftests.c: New file.
2031
2032 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2033
2034         * symfile.c (find_separate_debug_file): Look for separate debug
2035         files in debug directories under the sysroot.
2036
2037 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2038
2039         * symtab.h (struct minimal_symbol data_p): New const method.
2040         (struct minimal_symbol text_p): Likewise.
2041         * symtab.c (output_source_filename): Use file name style
2042         to print file name.
2043         (print_symbol_info): Likewise.
2044         (print_msymbol_info): Use address style to print addresses.
2045         Use function name style to print executable text symbols.
2046         (expand_symtab_containing_pc): Use data_p.
2047         (find_pc_sect_compunit_symtab): Likewise.
2048
2049 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2050
2051         * breakpoint.c (describe_other_breakpoints): Use address style
2052         to print addresses.
2053         (say_where): Likewise.
2054
2055 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2056
2057         * ada-typeprint.c (print_func_type): Print function name
2058         style to print function name.
2059         * c-typeprint.c (c_print_type_1): Likewise.
2060
2061 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2062
2063         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2064         for execve.
2065
2066 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2067
2068         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2069         type_stack.
2070
2071 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2072
2073         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2074         TYPE_CODE_REF types.
2075
2076 2019-02-08  Jim Wilson  <jimw@sifive.com>
2077
2078         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2079         (riscv_linux_fregset): New.
2080         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2081
2082 2019-02-07  Tom Tromey  <tom@tromey.com>
2083
2084         * thread.c (thread_cancel_execution_command): Update.
2085         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2086         methods.
2087         (struct thread_fsm_ops): Remove.
2088         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2089         (thread_fsm_should_stop, thread_fsm_return_value)
2090         (thread_fsm_set_finished, thread_fsm_finished_p)
2091         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2092         Don't declare.
2093         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2094         * infrun.c (clear_proceed_status_thread)
2095         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2096         (print_stop_event): Update.
2097         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2098         Add constructor.
2099         (step_command_fsm_ops): Remove.
2100         (new_step_command_fsm): Remove.
2101         (step_1): Update.
2102         (step_command_fsm::should_stop): Rename from
2103         step_command_fsm_should_stop.
2104         (step_command_fsm::clean_up): Rename from
2105         step_command_fsm_clean_up.
2106         (step_command_fsm::do_async_reply_reason): Rename from
2107         step_command_fsm_async_reply_reason.
2108         (struct until_next_fsm): Inherit from thread_fsm.  Add
2109         constructor.
2110         (until_next_fsm_ops): Remove.
2111         (new_until_next_fsm): Remove.
2112         (until_next_fsm::should_stop): Rename from
2113         until_next_fsm_should_stop.
2114         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2115         (until_next_fsm::do_async_reply_reason): Rename from
2116         until_next_fsm_async_reply_reason.
2117         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2118         constructor.  Change type of breakpoint.
2119         (finish_command_fsm_ops): Remove.
2120         (new_finish_command_fsm): Remove.
2121         (finish_command_fsm::should_stop): Rename from
2122         finish_command_fsm_should_stop.
2123         (finish_command_fsm::clean_up): Rename from
2124         finish_command_fsm_clean_up.
2125         (finish_command_fsm::return_value): Rename from
2126         finish_command_fsm_return_value.
2127         (finish_command_fsm::do_async_reply_reason): Rename from
2128         finish_command_fsm_async_reply_reason.
2129         (finish_command): Update.
2130         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2131         Add constructor.
2132         (call_thread_fsm_ops): Remove.
2133         (call_thread_fsm::call_thread_fsm): Rename from
2134         new_call_thread_fsm.
2135         (call_thread_fsm::should_stop): Rename from
2136         call_thread_fsm_should_stop.
2137         (call_thread_fsm::should_notify_stop): Rename from
2138         call_thread_fsm_should_notify_stop.
2139         (run_inferior_call, call_function_by_hand_dummy): Update.
2140         * cli/cli-interp.c (should_print_stop_to_console): Update.
2141         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2142         Add constructor.  Change type of location_breakpoint,
2143         caller_breakpoint.
2144         (until_break_fsm_ops): Remove.
2145         (new_until_break_fsm): Remove.
2146         (until_break_fsm::should_stop): Rename from
2147         until_break_fsm_should_stop.
2148         (until_break_fsm::clean_up): Rename from
2149         until_break_fsm_clean_up.
2150         (until_break_fsm::do_async_reply_reason): Rename from
2151         until_break_fsm_async_reply_reason.
2152         (until_break_command): Update.
2153         * thread-fsm.c: Remove.
2154         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2155
2156 2019-02-07  Tom Tromey  <tom@tromey.com>
2157
2158         * yy-remap.h: Add include guard.
2159         * xtensa-tdep.h: Add include guard.
2160         * xcoffread.h: Rename include guard.
2161         * varobj-iter.h: Add include guard.
2162         * tui/tui.h: Rename include guard.
2163         * tui/tui-winsource.h: Rename include guard.
2164         * tui/tui-wingeneral.h: Rename include guard.
2165         * tui/tui-windata.h: Rename include guard.
2166         * tui/tui-win.h: Rename include guard.
2167         * tui/tui-stack.h: Rename include guard.
2168         * tui/tui-source.h: Rename include guard.
2169         * tui/tui-regs.h: Rename include guard.
2170         * tui/tui-out.h: Rename include guard.
2171         * tui/tui-layout.h: Rename include guard.
2172         * tui/tui-io.h: Rename include guard.
2173         * tui/tui-hooks.h: Rename include guard.
2174         * tui/tui-file.h: Rename include guard.
2175         * tui/tui-disasm.h: Rename include guard.
2176         * tui/tui-data.h: Rename include guard.
2177         * tui/tui-command.h: Rename include guard.
2178         * tic6x-tdep.h: Add include guard.
2179         * target/waitstatus.h: Rename include guard.
2180         * target/wait.h: Rename include guard.
2181         * target/target.h: Rename include guard.
2182         * target/resume.h: Rename include guard.
2183         * target-float.h: Rename include guard.
2184         * stabsread.h: Add include guard.
2185         * rs6000-tdep.h: Add include guard.
2186         * riscv-fbsd-tdep.h: Add include guard.
2187         * regformats/regdef.h: Rename include guard.
2188         * record.h: Rename include guard.
2189         * python/python.h: Rename include guard.
2190         * python/python-internal.h: Rename include guard.
2191         * python/py-stopevent.h: Rename include guard.
2192         * python/py-ref.h: Rename include guard.
2193         * python/py-record.h: Rename include guard.
2194         * python/py-record-full.h: Rename include guard.
2195         * python/py-record-btrace.h: Rename include guard.
2196         * python/py-instruction.h: Rename include guard.
2197         * python/py-events.h: Rename include guard.
2198         * python/py-event.h: Rename include guard.
2199         * procfs.h: Add include guard.
2200         * proc-utils.h: Add include guard.
2201         * p-lang.h: Add include guard.
2202         * or1k-tdep.h: Rename include guard.
2203         * observable.h: Rename include guard.
2204         * nto-tdep.h: Rename include guard.
2205         * nat/x86-linux.h: Rename include guard.
2206         * nat/x86-linux-dregs.h: Rename include guard.
2207         * nat/x86-gcc-cpuid.h: Add include guard.
2208         * nat/x86-dregs.h: Rename include guard.
2209         * nat/x86-cpuid.h: Rename include guard.
2210         * nat/ppc-linux.h: Rename include guard.
2211         * nat/mips-linux-watch.h: Rename include guard.
2212         * nat/linux-waitpid.h: Rename include guard.
2213         * nat/linux-ptrace.h: Rename include guard.
2214         * nat/linux-procfs.h: Rename include guard.
2215         * nat/linux-osdata.h: Rename include guard.
2216         * nat/linux-nat.h: Rename include guard.
2217         * nat/linux-namespaces.h: Rename include guard.
2218         * nat/linux-btrace.h: Rename include guard.
2219         * nat/glibc_thread_db.h: Rename include guard.
2220         * nat/gdb_thread_db.h: Rename include guard.
2221         * nat/gdb_ptrace.h: Rename include guard.
2222         * nat/fork-inferior.h: Rename include guard.
2223         * nat/amd64-linux-siginfo.h: Rename include guard.
2224         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2225         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2226         * nat/aarch64-linux.h: Rename include guard.
2227         * nat/aarch64-linux-hw-point.h: Rename include guard.
2228         * mn10300-tdep.h: Add include guard.
2229         * mips-linux-tdep.h: Add include guard.
2230         * mi/mi-parse.h: Rename include guard.
2231         * mi/mi-out.h: Rename include guard.
2232         * mi/mi-main.h: Rename include guard.
2233         * mi/mi-interp.h: Rename include guard.
2234         * mi/mi-getopt.h: Rename include guard.
2235         * mi/mi-console.h: Rename include guard.
2236         * mi/mi-common.h: Rename include guard.
2237         * mi/mi-cmds.h: Rename include guard.
2238         * mi/mi-cmd-break.h: Rename include guard.
2239         * m2-lang.h: Add include guard.
2240         * location.h: Rename include guard.
2241         * linux-record.h: Rename include guard.
2242         * linux-nat.h: Add include guard.
2243         * linux-fork.h: Add include guard.
2244         * i386-darwin-tdep.h: Rename include guard.
2245         * hppa-linux-offsets.h: Add include guard.
2246         * guile/guile.h: Rename include guard.
2247         * guile/guile-internal.h: Rename include guard.
2248         * gnu-nat.h: Rename include guard.
2249         * gdb-stabs.h: Rename include guard.
2250         * frv-tdep.h: Add include guard.
2251         * f-lang.h: Add include guard.
2252         * event-loop.h: Add include guard.
2253         * darwin-nat.h: Rename include guard.
2254         * cp-abi.h: Rename include guard.
2255         * config/sparc/nm-sol2.h: Rename include guard.
2256         * config/nm-nto.h: Rename include guard.
2257         * config/nm-linux.h: Add include guard.
2258         * config/i386/nm-i386gnu.h: Rename include guard.
2259         * config/djgpp/nl_types.h: Rename include guard.
2260         * config/djgpp/langinfo.h: Rename include guard.
2261         * compile/gcc-cp-plugin.h: Add include guard.
2262         * compile/gcc-c-plugin.h: Add include guard.
2263         * compile/compile.h: Rename include guard.
2264         * compile/compile-object-run.h: Rename include guard.
2265         * compile/compile-object-load.h: Rename include guard.
2266         * compile/compile-internal.h: Rename include guard.
2267         * compile/compile-cplus.h: Rename include guard.
2268         * compile/compile-c.h: Rename include guard.
2269         * common/xml-utils.h: Rename include guard.
2270         * common/x86-xstate.h: Rename include guard.
2271         * common/version.h: Rename include guard.
2272         * common/vec.h: Rename include guard.
2273         * common/tdesc.h: Rename include guard.
2274         * common/selftest.h: Rename include guard.
2275         * common/scoped_restore.h: Rename include guard.
2276         * common/scoped_mmap.h: Rename include guard.
2277         * common/scoped_fd.h: Rename include guard.
2278         * common/safe-iterator.h: Rename include guard.
2279         * common/run-time-clock.h: Rename include guard.
2280         * common/refcounted-object.h: Rename include guard.
2281         * common/queue.h: Rename include guard.
2282         * common/ptid.h: Rename include guard.
2283         * common/print-utils.h: Rename include guard.
2284         * common/preprocessor.h: Rename include guard.
2285         * common/pathstuff.h: Rename include guard.
2286         * common/observable.h: Rename include guard.
2287         * common/netstuff.h: Rename include guard.
2288         * common/job-control.h: Rename include guard.
2289         * common/host-defs.h: Rename include guard.
2290         * common/gdb_wait.h: Rename include guard.
2291         * common/gdb_vecs.h: Rename include guard.
2292         * common/gdb_unlinker.h: Rename include guard.
2293         * common/gdb_unique_ptr.h: Rename include guard.
2294         * common/gdb_tilde_expand.h: Rename include guard.
2295         * common/gdb_sys_time.h: Rename include guard.
2296         * common/gdb_string_view.h: Rename include guard.
2297         * common/gdb_splay_tree.h: Rename include guard.
2298         * common/gdb_setjmp.h: Rename include guard.
2299         * common/gdb_ref_ptr.h: Rename include guard.
2300         * common/gdb_optional.h: Rename include guard.
2301         * common/gdb_locale.h: Rename include guard.
2302         * common/gdb_assert.h: Rename include guard.
2303         * common/filtered-iterator.h: Rename include guard.
2304         * common/filestuff.h: Rename include guard.
2305         * common/fileio.h: Rename include guard.
2306         * common/environ.h: Rename include guard.
2307         * common/common-utils.h: Rename include guard.
2308         * common/common-types.h: Rename include guard.
2309         * common/common-regcache.h: Rename include guard.
2310         * common/common-inferior.h: Rename include guard.
2311         * common/common-gdbthread.h: Rename include guard.
2312         * common/common-exceptions.h: Rename include guard.
2313         * common/common-defs.h: Rename include guard.
2314         * common/common-debug.h: Rename include guard.
2315         * common/cleanups.h: Rename include guard.
2316         * common/buffer.h: Rename include guard.
2317         * common/btrace-common.h: Rename include guard.
2318         * common/break-common.h: Rename include guard.
2319         * cli/cli-utils.h: Rename include guard.
2320         * cli/cli-style.h: Rename include guard.
2321         * cli/cli-setshow.h: Rename include guard.
2322         * cli/cli-script.h: Rename include guard.
2323         * cli/cli-interp.h: Rename include guard.
2324         * cli/cli-decode.h: Rename include guard.
2325         * cli/cli-cmds.h: Rename include guard.
2326         * charset-list.h: Add include guard.
2327         * buildsym-legacy.h: Rename include guard.
2328         * bfin-tdep.h: Add include guard.
2329         * ax.h: Rename include guard.
2330         * arm-linux-tdep.h: Add include guard.
2331         * arm-fbsd-tdep.h: Add include guard.
2332         * arch/xtensa.h: Rename include guard.
2333         * arch/tic6x.h: Add include guard.
2334         * arch/i386.h: Add include guard.
2335         * arch/arm.h: Rename include guard.
2336         * arch/arm-linux.h: Rename include guard.
2337         * arch/arm-get-next-pcs.h: Rename include guard.
2338         * arch/amd64.h: Add include guard.
2339         * arch/aarch64-insn.h: Rename include guard.
2340         * arch-utils.h: Rename include guard.
2341         * annotate.h: Add include guard.
2342         * amd64-darwin-tdep.h: Rename include guard.
2343         * aarch64-linux-tdep.h: Add include guard.
2344         * aarch64-fbsd-tdep.h: Add include guard.
2345         * aarch32-linux-nat.h: Add include guard.
2346
2347 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2348
2349         * macrotab.c (macro_define_internal): New function that
2350         factorizes macro_define_object_internal and macro_define_function
2351         code.
2352         (macro_define_object_internal): Use macro_define_internal.
2353         (macro_define_function): Likewise.
2354
2355 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2356
2357         * macrocmd.c (extract_identifier): Return
2358         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2359         callers.
2360
2361 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2362
2363         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2364
2365 2019-02-05  Tom Tromey  <tom@tromey.com>
2366
2367         * target.c (target_stack::unpush): Move assertion earlier.
2368
2369 2019-01-30  Tom Tromey  <tom@tromey.com>
2370
2371         PR python/23615:
2372         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2373         (gdbpy_parse_and_eval): Likewise.
2374         * python/python-internal.h (gdbpy_allow_threads): New class.
2375
2376 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2377
2378         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2379         (aarch64_fbsd_fpregmap): Move earlier.
2380         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2381         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2382         instead of individual calls to trad_frame_set_reg_addr.
2383         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2384         earlier.
2385         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2386         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2387         instead of individual calls to trad_frame_set_reg_addr.
2388
2389 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2390
2391         * CONTRIBUTE: Replace contribution list with wiki link.
2392
2393 2019-01-25  Tom Tromey  <tom@tromey.com>
2394
2395         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2396
2397 2019-01-25  Tom Tromey  <tom@tromey.com>
2398
2399         * xtensa-linux-nat.c: Fix common/ includes.
2400         * xml-support.h: Fix common/ includes.
2401         * xml-support.c: Fix common/ includes.
2402         * x86-linux-nat.c: Fix common/ includes.
2403         * windows-nat.c: Fix common/ includes.
2404         * varobj.h: Fix common/ includes.
2405         * varobj.c: Fix common/ includes.
2406         * value.c: Fix common/ includes.
2407         * valops.c: Fix common/ includes.
2408         * utils.c: Fix common/ includes.
2409         * unittests/xml-utils-selftests.c: Fix common/ includes.
2410         * unittests/utils-selftests.c: Fix common/ includes.
2411         * unittests/unpack-selftests.c: Fix common/ includes.
2412         * unittests/tracepoint-selftests.c: Fix common/ includes.
2413         * unittests/style-selftests.c: Fix common/ includes.
2414         * unittests/string_view-selftests.c: Fix common/ includes.
2415         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2416         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2417         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2418         * unittests/rsp-low-selftests.c: Fix common/ includes.
2419         * unittests/parse-connection-spec-selftests.c: Fix common/
2420         includes.
2421         * unittests/optional-selftests.c: Fix common/ includes.
2422         * unittests/offset-type-selftests.c: Fix common/ includes.
2423         * unittests/observable-selftests.c: Fix common/ includes.
2424         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2425         * unittests/memrange-selftests.c: Fix common/ includes.
2426         * unittests/memory-map-selftests.c: Fix common/ includes.
2427         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2428         * unittests/function-view-selftests.c: Fix common/ includes.
2429         * unittests/environ-selftests.c: Fix common/ includes.
2430         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2431         * unittests/common-utils-selftests.c: Fix common/ includes.
2432         * unittests/cli-utils-selftests.c: Fix common/ includes.
2433         * unittests/array-view-selftests.c: Fix common/ includes.
2434         * ui-file.c: Fix common/ includes.
2435         * tui/tui-io.c: Fix common/ includes.
2436         * tracepoint.h: Fix common/ includes.
2437         * tracepoint.c: Fix common/ includes.
2438         * tracefile-tfile.c: Fix common/ includes.
2439         * top.h: Fix common/ includes.
2440         * top.c: Fix common/ includes.
2441         * thread.c: Fix common/ includes.
2442         * target/waitstatus.h: Fix common/ includes.
2443         * target/waitstatus.c: Fix common/ includes.
2444         * target.h: Fix common/ includes.
2445         * target.c: Fix common/ includes.
2446         * target-memory.c: Fix common/ includes.
2447         * target-descriptions.c: Fix common/ includes.
2448         * symtab.h: Fix common/ includes.
2449         * symfile.c: Fix common/ includes.
2450         * stap-probe.c: Fix common/ includes.
2451         * spu-linux-nat.c: Fix common/ includes.
2452         * sparc-nat.c: Fix common/ includes.
2453         * source.c: Fix common/ includes.
2454         * solib.c: Fix common/ includes.
2455         * solib-target.c: Fix common/ includes.
2456         * ser-unix.c: Fix common/ includes.
2457         * ser-tcp.c: Fix common/ includes.
2458         * ser-pipe.c: Fix common/ includes.
2459         * ser-base.c: Fix common/ includes.
2460         * selftest-arch.c: Fix common/ includes.
2461         * s12z-tdep.c: Fix common/ includes.
2462         * rust-exp.y: Fix common/ includes.
2463         * rs6000-aix-tdep.c: Fix common/ includes.
2464         * riscv-tdep.c: Fix common/ includes.
2465         * remote.c: Fix common/ includes.
2466         * remote-notif.h: Fix common/ includes.
2467         * remote-fileio.h: Fix common/ includes.
2468         * remote-fileio.c: Fix common/ includes.
2469         * regcache.h: Fix common/ includes.
2470         * regcache.c: Fix common/ includes.
2471         * record-btrace.c: Fix common/ includes.
2472         * python/python.c: Fix common/ includes.
2473         * python/py-type.c: Fix common/ includes.
2474         * python/py-inferior.c: Fix common/ includes.
2475         * progspace.h: Fix common/ includes.
2476         * producer.c: Fix common/ includes.
2477         * procfs.c: Fix common/ includes.
2478         * proc-api.c: Fix common/ includes.
2479         * printcmd.c: Fix common/ includes.
2480         * ppc-linux-nat.c: Fix common/ includes.
2481         * parser-defs.h: Fix common/ includes.
2482         * osdata.c: Fix common/ includes.
2483         * obsd-nat.c: Fix common/ includes.
2484         * nat/x86-linux.c: Fix common/ includes.
2485         * nat/x86-linux-dregs.c: Fix common/ includes.
2486         * nat/x86-dregs.h: Fix common/ includes.
2487         * nat/x86-dregs.c: Fix common/ includes.
2488         * nat/ppc-linux.c: Fix common/ includes.
2489         * nat/mips-linux-watch.h: Fix common/ includes.
2490         * nat/mips-linux-watch.c: Fix common/ includes.
2491         * nat/linux-waitpid.c: Fix common/ includes.
2492         * nat/linux-ptrace.h: Fix common/ includes.
2493         * nat/linux-ptrace.c: Fix common/ includes.
2494         * nat/linux-procfs.c: Fix common/ includes.
2495         * nat/linux-personality.c: Fix common/ includes.
2496         * nat/linux-osdata.c: Fix common/ includes.
2497         * nat/linux-namespaces.c: Fix common/ includes.
2498         * nat/linux-btrace.h: Fix common/ includes.
2499         * nat/linux-btrace.c: Fix common/ includes.
2500         * nat/fork-inferior.c: Fix common/ includes.
2501         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2502         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2503         * nat/aarch64-linux.c: Fix common/ includes.
2504         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2505         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2506         * namespace.h: Fix common/ includes.
2507         * mips-linux-tdep.c: Fix common/ includes.
2508         * minsyms.c: Fix common/ includes.
2509         * mi/mi-parse.h: Fix common/ includes.
2510         * mi/mi-main.c: Fix common/ includes.
2511         * mi/mi-cmd-env.c: Fix common/ includes.
2512         * memrange.h: Fix common/ includes.
2513         * memattr.c: Fix common/ includes.
2514         * maint.h: Fix common/ includes.
2515         * maint.c: Fix common/ includes.
2516         * main.c: Fix common/ includes.
2517         * machoread.c: Fix common/ includes.
2518         * location.c: Fix common/ includes.
2519         * linux-thread-db.c: Fix common/ includes.
2520         * linux-nat.c: Fix common/ includes.
2521         * linux-fork.c: Fix common/ includes.
2522         * inline-frame.c: Fix common/ includes.
2523         * infrun.c: Fix common/ includes.
2524         * inflow.c: Fix common/ includes.
2525         * inferior.h: Fix common/ includes.
2526         * inferior.c: Fix common/ includes.
2527         * infcmd.c: Fix common/ includes.
2528         * inf-ptrace.c: Fix common/ includes.
2529         * inf-child.c: Fix common/ includes.
2530         * ia64-linux-nat.c: Fix common/ includes.
2531         * i387-tdep.c: Fix common/ includes.
2532         * i386-tdep.c: Fix common/ includes.
2533         * i386-linux-tdep.c: Fix common/ includes.
2534         * i386-linux-nat.c: Fix common/ includes.
2535         * i386-go32-tdep.c: Fix common/ includes.
2536         * i386-fbsd-tdep.c: Fix common/ includes.
2537         * i386-fbsd-nat.c: Fix common/ includes.
2538         * guile/scm-type.c: Fix common/ includes.
2539         * guile/guile.c: Fix common/ includes.
2540         * go32-nat.c: Fix common/ includes.
2541         * gnu-nat.c: Fix common/ includes.
2542         * gdbthread.h: Fix common/ includes.
2543         * gdbarch-selftests.c: Fix common/ includes.
2544         * gdb_usleep.c: Fix common/ includes.
2545         * gdb_select.h: Fix common/ includes.
2546         * gdb_bfd.c: Fix common/ includes.
2547         * gcore.c: Fix common/ includes.
2548         * fork-child.c: Fix common/ includes.
2549         * findvar.c: Fix common/ includes.
2550         * fbsd-nat.c: Fix common/ includes.
2551         * event-top.c: Fix common/ includes.
2552         * event-loop.c: Fix common/ includes.
2553         * dwarf2read.c: Fix common/ includes.
2554         * dwarf2loc.c: Fix common/ includes.
2555         * dwarf2-frame.c: Fix common/ includes.
2556         * dwarf-index-cache.c: Fix common/ includes.
2557         * dtrace-probe.c: Fix common/ includes.
2558         * disasm-selftests.c: Fix common/ includes.
2559         * defs.h: Fix common/ includes.
2560         * csky-tdep.c: Fix common/ includes.
2561         * cp-valprint.c: Fix common/ includes.
2562         * cp-support.h: Fix common/ includes.
2563         * cp-support.c: Fix common/ includes.
2564         * corelow.c: Fix common/ includes.
2565         * completer.h: Fix common/ includes.
2566         * completer.c: Fix common/ includes.
2567         * compile/compile.c: Fix common/ includes.
2568         * compile/compile-loc2c.c: Fix common/ includes.
2569         * compile/compile-cplus-types.c: Fix common/ includes.
2570         * compile/compile-cplus-symbols.c: Fix common/ includes.
2571         * command.h: Fix common/ includes.
2572         * cli/cli-dump.c: Fix common/ includes.
2573         * cli/cli-cmds.c: Fix common/ includes.
2574         * charset.c: Fix common/ includes.
2575         * build-id.c: Fix common/ includes.
2576         * btrace.h: Fix common/ includes.
2577         * btrace.c: Fix common/ includes.
2578         * breakpoint.h: Fix common/ includes.
2579         * breakpoint.c: Fix common/ includes.
2580         * ax.h:
2581         (enum agent_op): Fix common/ includes.
2582         * ax-general.c (struct aop_map): Fix common/ includes.
2583         * ax-gdb.c: Fix common/ includes.
2584         * auxv.c: Fix common/ includes.
2585         * auto-load.c: Fix common/ includes.
2586         * arm-tdep.c: Fix common/ includes.
2587         * arch/riscv.c: Fix common/ includes.
2588         * arch/ppc-linux-common.c: Fix common/ includes.
2589         * arch/i386.c: Fix common/ includes.
2590         * arch/arm.c: Fix common/ includes.
2591         * arch/arm-linux.c: Fix common/ includes.
2592         * arch/arm-get-next-pcs.c: Fix common/ includes.
2593         * arch/amd64.c: Fix common/ includes.
2594         * arch/aarch64.c: Fix common/ includes.
2595         * arch/aarch64-insn.c: Fix common/ includes.
2596         * arch-utils.c: Fix common/ includes.
2597         * amd64-windows-tdep.c: Fix common/ includes.
2598         * amd64-tdep.c: Fix common/ includes.
2599         * amd64-sol2-tdep.c: Fix common/ includes.
2600         * amd64-obsd-tdep.c: Fix common/ includes.
2601         * amd64-nbsd-tdep.c: Fix common/ includes.
2602         * amd64-linux-tdep.c: Fix common/ includes.
2603         * amd64-linux-nat.c: Fix common/ includes.
2604         * amd64-fbsd-tdep.c: Fix common/ includes.
2605         * amd64-fbsd-nat.c: Fix common/ includes.
2606         * amd64-dicos-tdep.c: Fix common/ includes.
2607         * amd64-darwin-tdep.c: Fix common/ includes.
2608         * agent.c: Fix common/ includes.
2609         * ada-lang.h: Fix common/ includes.
2610         * ada-lang.c: Fix common/ includes.
2611         * aarch64-tdep.c: Fix common/ includes.
2612
2613 2019-01-25  Tom Tromey  <tom@tromey.com>
2614
2615         * common/create-version.sh: Use common/version.h.
2616
2617 2019-01-24  Pedro Alves  <palves@redhat.com>
2618
2619         * infrun.c (signal_stop, signal_print, signal_program)
2620         (signal_catch, signal_pass): Now arrays instead of pointers.
2621         (update_signals_program_target, do_target_resume)
2622         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2623         * linux-nat.c (linux_nat_target::pass_signals)
2624         (linux_nat_target::create_inferior, linux_nat_target::attach):
2625         Adjust.
2626         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2627         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2628         * procfs.c (procfs_target::pass_signals): Adjust.
2629         * record-full.c (record_full_target::resume): Adjust.
2630         * remote.c (remote_target::pass_signals)
2631         (remote_target::program_signals): Adjust.
2632         * target-debug.h (target_debug_print_signals): Now takes a
2633         gdb::array_view as parameter.  Adjust.
2634         * target.h (target_ops) <pass_signals, program_signals>: Replace
2635         pointer and length parameters with gdb::array_view.
2636         (target_pass_signals, target_program_signals): Likewise.
2637         * target-delegates.c: Regenerate.
2638
2639 2019-01-24  Pedro Alves  <palves@redhat.com>
2640
2641         * common/forward-scope-exit.h
2642         (forward_scope_exit::forward_scope_exit): Pass arguments to
2643         m_bind_function directly, instead of creating a std::bind and
2644         copying that.
2645
2646 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2647
2648         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2649         for static members.
2650         (pass_in_v_vfp_candidate): Likewise.
2651
2652 2019-01-23  Tom Tromey  <tom@tromey.com>
2653             Pedro Alves  <palves@redhat.com>
2654
2655         * regcache.c (class regcache_invalidator): Remove.
2656         (regcache::raw_write): Use make_scope_exit.
2657
2658 2019-01-23  Tom Tromey  <tom@tromey.com>
2659
2660         * ui-out.h (class ui_out_emit_type): Update comment.
2661
2662 2019-01-23  Tom Tromey  <tom@tromey.com>
2663
2664         * infrun.c (fetch_inferior_event): Update comment.
2665
2666 2019-01-23  Tom Tromey  <tom@tromey.com>
2667             Pedro Alves  <palves@redhat.com>
2668
2669         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2670         parameter.
2671         (fetch_inferior_event): Use SCOPE_EXIT.
2672
2673
2674 2019-01-23  Tom Tromey  <tom@tromey.com>
2675             Pedro Alves  <palves@redhat.com>
2676
2677         * infrun.c (disable_thread_events): Delete.
2678         (stop_all_threads): Use SCOPE_EXIT.
2679
2680 2019-01-23  Tom Tromey  <tom@tromey.com>
2681             Pedro Alves  <palves@redhat.com>
2682
2683         * symfile.c: Include forward-scope-exit.h.
2684         (clear_symtab_users_cleanup): Replace forward declaration with
2685         a FORWARD_SCOPE_EXIT.
2686         (syms_from_objfile_1): Use the forward_scope_exit and
2687         gdb::optional instead of cleanup_function.
2688         (reread_symbols): Use the forward_scope_exit instead of
2689         cleanup_function.
2690         (clear_symtab_users_cleanup): Remove function.
2691
2692 2019-01-23  Tom Tromey  <tom@tromey.com>
2693             Pedro Alves  <palves@redhat.com>
2694
2695         * linux-nat.c: Include scope-exit.h.
2696         (cleanup_target_stop): Remove.
2697         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2698         SCOPE_EXIT.
2699
2700 2019-01-23  Tom Tromey  <tom@tromey.com>
2701             Pedro Alves  <palves@redhat.com>
2702
2703         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2704         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2705
2706 2019-01-23  Tom Tromey  <tom@tromey.com>
2707             Andrew Burgess  <andrew.burgess@embecosm.com>
2708             Pedro Alves  <palves@redhat.com>
2709
2710         * infrun.c (fetch_inferior_event): Use scope_exit.
2711         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2712         * top.c (execute_command): Use scope_exit.
2713         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2714         * utils.c (do_bpstat_clear_actions_cleanup)
2715         (make_bpstat_clear_actions_cleanup): Remove.
2716
2717 2019-01-23  Tom Tromey  <tom@tromey.com>
2718             Pedro Alves  <palves@redhat.com>
2719
2720         * infrun.c: Include "common/scope-exit.h"
2721         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2722         (wait_for_inferior): Use SCOPE_EXIT.
2723         (fetch_inferior_event): Use scope_exit.
2724
2725 2019-01-23  Tom Tromey  <tom@tromey.com>
2726             Pedro Alves  <palves@redhat.com>
2727
2728         * breakpoint.c (create_breakpoint): Remove cleanup.
2729
2730 2019-01-23  Tom Tromey  <tom@tromey.com>
2731             Andrew Burgess  <andrew.burgess@embecosm.com>
2732             Pedro Alves  <palves@redhat.com>
2733
2734 2019-01-23  Pedro Alves  <palves@redhat.com>
2735
2736         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2737
2738 2019-01-23  Pedro Alves  <palves@redhat.com>
2739             Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * gdbthread.h: Include "common/forward-scope-exit.h".
2742         (scoped_finish_thread_state): Redefine custom class in terms of
2743         forward_scope_exit.
2744
2745 2019-01-23  Pedro Alves  <palves@redhat.com>
2746             Andrew Burgess  <andrew.burgess@embecosm.com>
2747
2748         * common/forward-scope-exit.h: New file.
2749
2750 2019-01-23  Pedro Alves  <palves@redhat.com>
2751             Andrew Burgess  <andrew.burgess@embecosm.com>
2752             Tom Tromey  <tom@tromey.com>
2753
2754         * common/scope-exit.h: New file.
2755
2756 2019-01-23  Pedro Alves  <palves@redhat.com>
2757
2758         * common/preprocessor.h (ESC): Rename to ...
2759         (ESC_PARENS): ... this.
2760         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2761         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2762
2763 2019-01-23  Tom Tromey  <tom@tromey.com>
2764
2765         * language.h (class scoped_switch_to_sym_language_if_auto):
2766         Initialize m_lang in both cases.
2767
2768 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2769
2770         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2771         with XCNEW.
2772
2773 2019-01-22  Tom Tromey  <tom@tromey.com>
2774
2775         * corelow.c: Do not include sys/file.h.
2776
2777 2019-01-22  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-wingeneral.h: Include gdb_curses.h.
2780
2781 2019-01-22  Tom Tromey  <tom@tromey.com>
2782
2783         * source-cache.h (class source_cache) <get_source_lines,
2784         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2785
2786 2019-01-22  Tom Tromey  <tom@tromey.com>
2787
2788         * remote-fileio.h (struct remote_target): Declare.
2789
2790 2019-01-22  Tom Tromey  <tom@tromey.com>
2791
2792         * python/py-arch.c: Do not include py-ref.h.
2793         * python/py-bpevent.c: Do not include py-ref.h.
2794         * python/py-cmd.c: Do not include py-ref.h.
2795         * python/py-continueevent.c: Do not include py-ref.h.
2796         * python/py-event.h: Do not include py-ref.h.
2797         * python/py-evtregistry.c: Do not include py-ref.h.
2798         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2799         * python/py-frame.c: Do not include py-ref.h.
2800         * python/py-framefilter.c: Do not include py-ref.h.
2801         * python/py-function.c: Do not include py-ref.h.
2802         * python/py-infevents.c: Do not include py-ref.h.
2803         * python/py-linetable.c: Do not include py-ref.h.
2804         * python/py-objfile.c: Do not include py-ref.h.
2805         * python/py-param.c: Do not include py-ref.h.
2806         * python/py-prettyprint.c: Do not include py-ref.h.
2807         * python/py-progspace.c: Do not include py-ref.h.
2808         * python/py-symbol.c: Do not include py-ref.h.
2809         * python/py-symtab.c: Do not include py-ref.h.
2810         * python/py-type.c: Do not include py-ref.h.
2811         * python/py-unwind.c: Do not include py-ref.h.
2812         * python/py-utils.c: Do not include py-ref.h.
2813         * python/py-value.c: Do not include py-ref.h.
2814         * python/py-varobj.c: Do not include py-ref.h.
2815         * python/py-xmethods.c: Do not include py-ref.h.
2816         * python/python.c: Do not include py-ref.h.
2817         * varobj.c: Do not include py-ref.h.
2818
2819 2019-01-22  Tom Tromey  <tom@tromey.com>
2820
2821         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2822         keyword for bcache.
2823
2824 2019-01-22  Tom Tromey  <tom@tromey.com>
2825
2826         * compile/compile-cplus-types.c: Remove a comment by #include.
2827
2828 2019-01-22  Tom Tromey  <tom@tromey.com>
2829
2830         * compile/gcc-c-plugin.h: Include compile-internal.h.
2831
2832 2019-01-22  Tom Tromey  <tom@tromey.com>
2833
2834         * stabsread.c (EXTERN): Do not define.
2835         (symnum, next_symbol_text_func, processing_gcc_compilation)
2836         (within_function, global_sym_chain, global_stabs)
2837         (previous_stab_code, this_object_header_files)
2838         (n_this_object_header_files)
2839         (n_allocated_this_object_header_files): Define.
2840         * stabsread.h (EXTERN): Never define.  Use "extern".
2841
2842 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2843
2844         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2845         history_value.
2846
2847 2019-01-21  Tom Tromey  <tom@tromey.com>
2848
2849         * ui-out.c: Fix includes.
2850         * tui/tui-source.c: Fix includes.
2851         * target.c: Fix includes.
2852         * remote.c: Fix includes.
2853         * regcache.c: Fix includes.
2854         * python/py-block.c: Fix includes.
2855         * printcmd.c: Fix includes.
2856         * or1k-tdep.c: Fix includes.
2857         * mi/mi-main.c: Fix includes.
2858         * m32r-tdep.c: Fix includes.
2859         * csky-tdep.c: Fix includes.
2860         * compile/compile-cplus-types.c: Fix includes.
2861         * cli/cli-interp.c: Fix includes.
2862
2863 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2864
2865         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2866         for padding.
2867
2868 2019-01-16  Tom Tromey  <tom@tromey.com>
2869
2870         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2871         earlier.
2872         (struct objfile) <msymbols_range>: Move from top level.
2873         <msymbols>: New method.
2874         (class objfile_msymbols): Remove.
2875         * symtab.c (default_collect_symbol_completion_matches_break_on):
2876         Update.
2877         * symmisc.c (dump_msymbols): Update.
2878         * stabsread.c (scan_file_globals): Update.
2879         * objc-lang.c (info_selectors_command, info_classes_command)
2880         (find_methods): Update.
2881         * minsyms.c (find_solib_trampoline_target): Update.
2882         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2883         * coffread.c (coff_symfile_read): Update.
2884         * ada-lang.c (ada_lookup_simple_minsym)
2885         (ada_collect_symbol_completion_matches): Update.
2886
2887 2019-01-16  Tom Tromey  <tom@tromey.com>
2888
2889         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2890         type.  Remove no-argument constructor.
2891         <iterator::operator++>: Simplify.
2892         <begin>: Update.
2893         <end>: Use minimal_symbol_count.
2894
2895 2019-01-16  Tom Tromey  <tom@tromey.com>
2896
2897         * objfiles.h (struct objfile) <psymtabs>: New method.
2898         (class objfile_psymtabs): Remove.
2899         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2900         typedef.
2901         <range>: New method.
2902         (require_partial_symbols): Change return type.
2903         * psymtab.c (require_partial_symbols)
2904         (psym_expand_symtabs_matching): Update.
2905         * mdebugread.c (parse_partial_symbols): Update.
2906         * dbxread.c (dbx_end_psymtab): Update.
2907
2908 2019-01-15  Tom Tromey  <tom@tromey.com>
2909
2910         * symtab.c (lookup_objfile_from_block)
2911         (lookup_symbol_in_objfile_symtabs)
2912         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2913         (find_line_symtab, info_sources_command)
2914         (default_collect_symbol_completion_matches_break_on)
2915         (make_source_files_completion_list): Update.
2916         * symmisc.c (print_objfile_statistics, dump_objfile)
2917         (maintenance_print_symbols, maintenance_info_symtabs)
2918         (maintenance_check_symtabs, maintenance_info_line_tables):
2919         Update.
2920         * source.c (select_source_symtab)
2921         (forget_cached_source_info_for_objfile): Update.
2922         * objfiles.h (class objfile_compunits): Remove.
2923         (struct objfile) <compunits_range>: New typedef.
2924         (compunits): New method.
2925         * objfiles.c (objfile_relocate1): Update.
2926         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2927         * maint.c (count_symtabs_and_blocks): Update.
2928         * linespec.c (iterate_over_all_matching_symtabs): Update.
2929         * cp-support.c (add_symbol_overload_list_qualified): Update.
2930         * coffread.c (coff_symtab_read): Update.
2931         * ada-lang.c (add_nonlocal_symbols)
2932         (ada_collect_symbol_completion_matches)
2933         (ada_add_global_exceptions): Update.
2934
2935 2019-01-15  Tom Tromey  <tom@tromey.com>
2936
2937         * progspace.h (program_space) <objfiles_safe_range>: New
2938         typedef.
2939         <objfiles_safe>: New method.
2940         * objfiles.h (class all_objfiles_safe): Remove.
2941         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2942         * jit.c (jit_inferior_exit_hook): Update.
2943
2944 2019-01-17  Tom Tromey  <tom@tromey.com>
2945
2946         * progspace.h (program_space) <objfiles_range>: New typedef.
2947         <objfiles>: New method.
2948         <objfiles_head>: Rename from objfiles.
2949         (object_files): Update.
2950         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2951         * guile/scm-pretty-print.c
2952         (ppscm_find_pretty_printer_from_objfiles): Update.
2953         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2954         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2955         Update.
2956         * python/py-progspace.c (pspy_get_objfiles): Update.
2957         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2958         Update.
2959         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2960         (objfpy_lookup_objfile_by_build_id): Update.
2961         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2962         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2963         Update.
2964         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2965         (expand_symtab_containing_pc, lookup_objfile_from_block)
2966         (lookup_static_symbol, basic_lookup_transparent_type)
2967         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2968         (find_line_symtab, info_sources_command)
2969         (default_collect_symbol_completion_matches_break_on)
2970         (make_source_files_completion_list, find_main_name): Update.
2971         * symmisc.c (print_symbol_bcache_statistics)
2972         (print_objfile_statistics, maintenance_print_symbols)
2973         (maintenance_print_msymbols, maintenance_print_objfiles)
2974         (maintenance_info_symtabs, maintenance_check_symtabs)
2975         (maintenance_expand_symtabs, maintenance_info_line_tables):
2976         Update.
2977         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2978         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2979         (map_overlay_command, unmap_overlay_command)
2980         (simple_overlay_update, expand_symtabs_matching)
2981         (map_symbol_filenames): Update.
2982         * symfile-debug.c (set_debug_symfile): Update.
2983         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2984         Update.
2985         * source.c (select_source_symtab, forget_cached_source_info):
2986         Update.
2987         * solib.c (solib_read_symbols): Update.
2988         * solib-spu.c (append_ocl_sos): Update.
2989         * psymtab.c (maintenance_print_psymbols)
2990         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2991         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2992         * printcmd.c (info_symbol_command): Update.
2993         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2994         Update.
2995         * objfiles.h (class all_objfiles): Remove.
2996         * objfiles.c (have_partial_symbols, have_full_symbols)
2997         (have_minimal_symbols, qsort_cmp, update_section_map)
2998         (shared_objfile_contains_address_p)
2999         (default_iterate_over_objfiles_in_search_order): Update.
3000         * objc-lang.c (info_selectors_command, info_classes_command)
3001         (find_methods): Update.
3002         * minsyms.c (find_solib_trampoline_target): Update.
3003         * maint.c (maintenance_info_sections)
3004         (maintenance_translate_address, count_symtabs_and_blocks):
3005         Update.
3006         * main.c (captured_main_1): Update.
3007         * linux-thread-db.c (try_thread_db_load_from_pdir)
3008         (has_libpthread): Update.
3009         * linespec.c (iterate_over_all_matching_symtabs)
3010         (search_minsyms_for_name): Update.
3011         * jit.c (jit_find_objf_with_entry_addr): Update.
3012         * hppa-tdep.c (find_unwind_entry)
3013         (hppa_lookup_stub_minimal_symbol): Update.
3014         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3015         Update.
3016         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3017         (elf_gnu_ifunc_resolve_by_got): Update.
3018         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3019         * dwarf-index-write.c (save_gdb_index_command): Update.
3020         * cp-support.c (add_symbol_overload_list_qualified): Update.
3021         * breakpoint.c (create_overlay_event_breakpoint)
3022         (create_longjmp_master_breakpoint)
3023         (create_std_terminate_master_breakpoint)
3024         (create_exception_master_breakpoint): Update.
3025         * blockframe.c (find_pc_partial_function): Update.
3026         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3027         (ada_collect_symbol_completion_matches)
3028         (ada_add_global_exceptions): Update.
3029
3030 2019-01-17  Tom Tromey  <tom@tromey.com>
3031
3032         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3033         declare VEC.
3034         (solib_target_parse_libraries): Change return type.
3035         (library_list_start_segment, library_list_start_section)
3036         (library_list_end_library, library_list_start_library); Update.
3037         (solib_target_free_library_list): Remove.
3038         (solib_target_parse_libraries): Remove cleanup.  Change return
3039         type.
3040         (solib_target_current_sos): Update.
3041
3042 2019-01-17  Tom Tromey  <tromey@bapiya>
3043
3044         * valprint.c: Replace "the the" with "the".
3045         * symtab.c: Replace "the the" with "the".
3046         * solib.c: Replace "the the" with "the".
3047         * solib-dsbt.c: Replace "the the" with "the".
3048         * linespec.c: Replace "the the" with "the".
3049         * dwarf2loc.h: Replace "the the" with "the".
3050         * amd64-windows-tdep.c: Replace "the the" with "the".
3051         * aarch64-tdep.c: Replace "the the" with "the".
3052
3053 2019-01-16  Keith Seitz  <keiths@redhat.com>
3054
3055         PR gdb/23773
3056         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3057         <builder>: Rename to ..
3058         <m_builder>: ... this and make private.
3059         (dwarf2_cu::get_builder): New method.  Change all users of
3060         `builder' to use this method.
3061         (dwarf2_start_symtab): Move to ...
3062         (dwarf2_cu::start_symtab): ... here.  Update all callers
3063         (setup_type_unit_groups): Move to ...
3064         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3065         callers.
3066         (dwarf2_cu::reset_builder): New method.
3067         (process_full_compunit, process_full_type_unit): Use
3068         dwarf2_cu::reset_builder.
3069         (follow_die_offset): Record the ancestor CU if it is different
3070         from the followed DIE's CU.
3071         (follow_die_sig_1): Likewise.
3072
3073 2019-01-15  Tom Tromey  <tom@tromey.com>
3074
3075         * remote.c (class remote_state) <buf>: Now a char_vector.
3076         <buf_size>: Remove.
3077         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3078         parameter.
3079         (remote_target::getpkt_or_notif_sane_1)
3080         (remote_target::getpkt_sane)
3081         (remote_target::getpkt_or_notif_sane): Likewise.
3082         (class remote_target) <putpkt>: New overload.
3083         (remote_target::read_frame): Change type of "buf_p".  Remove
3084         sizeof_p parameter.
3085         (packet_ok): New overload.
3086         (packet_check_result): New overload.
3087         Update all uses.
3088
3089 2019-01-14  Tom Tromey  <tom@tromey.com>
3090
3091         * remote-notif.c (handle_notification, remote_notif_ack)
3092         (remote_notif_parse): Make "buf" const.
3093         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3094         const.
3095         (remote_notif_parse, remote_notif_ack, handle_notification):
3096         Likewise.
3097         * remote.c (remote_notif_stop_parse): Make "buf" const.
3098         (remote_target::remote_parse_stop_reply): Make "buf" const.
3099         (remote_notif_stop_ack): Make "buf" const.
3100
3101 2019-01-14  Tom Tromey  <tom@tromey.com>
3102
3103         * remote.c (remote_console_output): Make parameter const.
3104
3105 2019-01-14  Tom Tromey  <tom@tromey.com>
3106
3107         * target-debug.h (target_debug_print_signals): Constify.
3108         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3109         * procfs.c (procfs_target::pass_signals): Update.
3110         * linux-nat.c (linux_nat_target::pass_signals): Update.
3111         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3112         * target-delegates.c: Rebuild.
3113         * remote.c (remote_target::program_signals): Update.
3114         (remote_target::pass_signals): Update.
3115         * target.c (target_pass_signals): Constify argument.
3116         (target_program_signals): Likewise.
3117         * target.h (struct target_ops) <pass_signals, program_signals>:
3118         Constify argument.
3119         (target_pass_signals, target_program_signals): Constify argument.
3120
3121 2019-01-14  Tom Tromey  <tom@tromey.com>
3122
3123         PR tui/28819:
3124         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3125
3126 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3127
3128         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3129         field.
3130         * rs6000-tdep.c: Include reggroups.h.
3131         (IS_V_ALIAS_PSEUDOREG): Define.
3132         (rs6000_register_name): Return names for the "vX" aliases.
3133         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3134         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3135         aliases.  Call default_register_reggroup_p for all other
3136         pseudo-registers.
3137         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3138         New functions.
3139         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3140         Handle "vX" aliases.
3141         (v_alias_pseudo_register_collect): New function.
3142         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3143         (rs6000_gdbarch_init): Initialize "vX" aliases as
3144         pseudo-registers.  Restore registration of
3145         rs6000_pseudo_register_reggroup_p with
3146         set_tdesc_pseudo_register_reggroup_p.
3147
3148 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3149
3150         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3151         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3152         set_gdbarch_num_pseudo_regs.
3153
3154 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3155
3156         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3157         Remove arg prefixname, add do_set and do_show.
3158         Add member functions set_list and show_list.
3159         * cli/cli-style.c (class cli_style_option): Update accordingly.
3160         (style_set_list): Move to file scope.
3161         (style_show_list): Likewise.
3162         (set_style): Call help_list.
3163         (show_style): Call cmd_show_list.
3164         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3165         Update to use the new macro.
3166
3167 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3168
3169         * ada-lang.c (_initialize_ada_language): Expand the help text
3170         for the "catch exception" command.
3171
3172 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3173
3174         * symtab.c (matching_obj_sections): Initialize obj,
3175         declare it closer to its usage.
3176
3177 2019-01-10  Tom Tromey  <tom@tromey.com>
3178
3179         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3180         (basic_inf_threads_range): Remove.
3181         (inf_threads_range, inf_non_exited_threads_range)
3182         (safe_inf_threads_range): Use next_adapter.
3183
3184 2019-01-10  Keith Seitz  <keiths@redhat.com>
3185
3186         PR gdb/23712
3187         PR symtab/23010
3188         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3189         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3190
3191 2019-01-10  Keith Seitz  <keiths@redhat.com>
3192
3193         PR gdb/23712
3194         PR symtab/23010
3195         * dictionary.c (pending_to_vector): Remove.
3196         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3197         Remove _1 suffix, replacing functions of the same name.  Update
3198         all callers.
3199         (dict_create_hashed, dict_create_hashed_expandable)
3200         (dict_create_linear, dict_create_linear_expandable, dict_free)
3201         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3202         Make functions static.
3203
3204 2019-01-10  Keith Seitz  <keiths@redhat.com>
3205
3206         PR gdb/23712
3207         PR symtab/23010
3208         * dictionary.h (struct dictionary): Replace declaration with
3209         multidictionary.
3210         (dict_create_hashed, dict_create_hashed_expandable)
3211         (dict_create_linear, dict_create_linear_expandable)
3212         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3213         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3214         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3215         taking multidictionary argument.
3216         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3217         * block.h (struct block) <dict>: Change to multidictionary
3218         and rename `multidict'.
3219         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3220         symmisc.c: Update all dictionary references to multidictionary.
3221
3222 2019-01-10  Keith Seitz  <keiths@redhat.com>
3223
3224         PR gdb/23712
3225         PR symtab/23010
3226         * dictionary.c: Include unordered_map.
3227         (pending_to_vector): New function.
3228         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3229         Rewrite the non-"_1" functions to take vector instead
3230         of linked list.
3231         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3232         "new" _1 versions of the same name.
3233         (multidictionary): Define.
3234         (std::hash<enum language): New definition.
3235         (collate_pending_symbols_by_language, mdict_create_hashed)
3236         (mdict_create_hashed_expandable, mdict_create_linear)
3237         (mdict_create_linear_expandable, mdict_free)
3238         (find_language_dictionary, create_new_language_dictionary)
3239         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3240         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3241         (mdict_size, mdict_empty): New functions.
3242         * dictionary.h (mdict_iterator): Define.
3243
3244 2019-01-10  Pedro Alves  <palves@redhat.com>
3245
3246         * breakpoint.c (read_uploaded_action)
3247         (create_tracepoint_from_upload): Adjust to use
3248         gdb::unique_xmalloc_ptr.
3249         * ctf.c (ctf_write_uploaded_tp):
3250         (SET_ARRAY_FIELD): Use emplace_back.
3251         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3252         * tracefile-tfile.c (tfile_write_uploaded_tp):
3253         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3254         gdb::unique_xmalloc_ptr.
3255         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3256         at_string, cond_string, cmd_strings>: Replace char pointers
3257         with gdb::unique_xmalloc_ptr.
3258
3259 2019-01-10  Pedro Alves  <palves@redhat.com>
3260
3261         * solib-target.c (library_list_start_library): Don't xstrdup name.
3262
3263 2019-01-10  Pedro Alves  <palves@redhat.com>
3264
3265         * mdebugread.c (parse_partial_symbols): Use
3266         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3267
3268 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3269
3270         * linux-fork.c (scoped_switch_fork_info)
3271         <~scoped_switch_fork_info>: Fix incorrect variable name.
3272
3273 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3274
3275         * linux-fork.c (scoped_switch_fork_info)
3276         <scoped_switch_fork_info>: Make explicit.
3277         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3278
3279 2019-01-10  Tom Tromey  <tom@tromey.com>
3280
3281         * objfiles.h (objfile::reset_psymtabs): Update.
3282         * objfiles.c (objfile::objfile): Update.
3283         * psymtab.h (psymtab_storage::obstack): Update.
3284         (psymtab_storage::m_obstack): Use gdb::optional.
3285         (class psymtab_storage): Update comment.  Remove objfile
3286         parameter.
3287         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3288
3289 2019-01-10  Tom Tromey  <tom@tromey.com>
3290
3291         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3292         <free_psymtabs>: Now private.
3293         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3294         (allocate_psymtab): Use new method.
3295
3296 2019-01-10  Tom Tromey  <tom@tromey.com>
3297
3298         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3299         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3300         * mdebugread.c (parse_partial_symbols): Use
3301         allocate_dependencies.
3302         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3303         allocate_dependencies.
3304         (process_psymtab_comp_unit_reader)
3305         (build_type_psymtab_dependencies): Likewise.
3306         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3307
3308 2019-01-10  Tom Tromey  <tom@tromey.com>
3309
3310         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3311         PSYMBOL_SET_LANGUAGE.
3312         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3313
3314 2019-01-10  Tom Tromey  <tom@tromey.com>
3315
3316         * psymtab.h (psymtab_storage::obstack): New method.
3317         <m_obstack>: Rename from obstack; now private.
3318         * psymtab.c (psymtab_storage): Update.
3319         * dwarf2read.c (create_addrmap_from_index)
3320         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3321         Update.
3322
3323 2019-01-10  Tom Tromey  <tom@tromey.com>
3324
3325         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3326         * objfiles.h (objfile::reset_psymtabs): New method.
3327
3328 2019-01-10  Tom Tromey  <tom@tromey.com>
3329
3330         * symmisc.c (print_symbol_bcache_statistics): Update.
3331         (print_objfile_statistics): Update.
3332         * symfile.c (reread_symbols): Update.
3333         * psymtab.h (class psymtab_storage): New.
3334         * psymtab.c (psymtab_storage): New constructor.
3335         (~psymtab_storage): New destructor.
3336         (require_partial_symbols): Update.
3337         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3338         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3339         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3340         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3341         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3342         (start_psymtab_common, end_psymtab_common)
3343         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3344         (allocate_psymtab): Update.
3345         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3346         Update.
3347         (dump_psymtab_addrmap, maintenance_print_psymbols)
3348         (maintenance_check_psymtabs): Update.
3349         (class objfile_psymtabs): Move to objfiles.h.
3350         * psympriv.h (discard_psymtab): Now inline.
3351         (psymtab_discarder::psymtab_discarder): Update.
3352         (psymtab_discarder::~psymtab_discarder): Update.
3353         (ALL_OBJFILE_PSYMTABS): Rewrite.
3354         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3355         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3356         Remove fields.
3357         <partial_symtabs>: New field.
3358         (class objfile_psymtabs): Move from psymtab.h.  Update.
3359         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3360         psymbol_cache.
3361         (objfile::~objfile): Don't destroy psymbol_cache.
3362         * mdebugread.c (parse_partial_symbols): Update.
3363         * dwarf2read.c (create_addrmap_from_index)
3364         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3365         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3366         (add_partial_subprogram, dwarf2_ranges_read): Update.
3367         * dwarf-index-write.c (write_address_map)
3368         (write_one_signatured_type, recursively_write_psymbols)
3369         (class debug_names, class debug_names, write_psymtabs_to_index):
3370         Update.
3371
3372 2019-01-10  Tom Tromey  <tom@tromey.com>
3373
3374         * symtab.h (SYMBOL_SET_NAMES): Update.
3375         (symbol_set_names): Update.
3376         (MSYMBOL_SET_NAMES): Update.
3377         * symtab.c (symbol_set_names): Change argument to be an
3378         objfile_per_bfd_storage.
3379         * psymtab.c (add_psymbol_to_bcache): Update.
3380         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3381
3382 2019-01-10  Tom Tromey  <tom@tromey.com>
3383
3384         * symtab.c (create_demangled_names_hash): Change argument to be an
3385         objfile_per_bfd_storage.
3386         (symbol_set_names): Update.
3387
3388 2019-01-10  Tom Tromey  <tom@tromey.com>
3389
3390         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3391         init_psymbol_list.
3392         * psymtab.c (init_psymbol_list): Do nothing if already called.
3393         * psympriv.h (init_psymbol_list): Add comment.
3394         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3395         init_psymbol_list.
3396         * dbxread.c (dbx_symfile_read): Unconditionally call
3397         init_psymbol_list.
3398
3399 2019-01-10  Tom Tromey  <tom@tromey.com>
3400
3401         * xcoffread.c (scan_xcoff_symtab): Update.
3402         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3403         "where".
3404         * mdebugread.c (parse_partial_symbols)
3405         (handle_psymbol_enumerators): Update.
3406         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3407         * dbxread.c (read_dbx_symtab): Update.
3408         * psympriv.h (psymbol_placement): New enum.
3409         (add_psymbol_to_list): Update.
3410
3411 2019-01-10  Tom Tromey  <tom@tromey.com>
3412
3413         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3414         static_psymbols parameters.
3415         (scan_xcoff_symtab): Update.
3416         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3417         static_psymbols parameters.
3418         * psympriv.h (start_psymtab_common): Update.
3419         * mdebugread.c (parse_partial_symbols): Update.
3420         * dwarf2read.c (create_partial_symtab): Update.
3421         * dbxread.c (read_dbx_symtab): Update.
3422         (start_psymtab): Remove global_psymbols and static_psymbols
3423         parameters.
3424
3425 2019-01-10  Tom Tromey  <tom@tromey.com>
3426
3427         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3428         * psymtab.c (allocate_psymtab): Add comment.
3429         * psympriv.h (allocate_psymtab): Add comment.
3430         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3431         initializations.
3432         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3433
3434 2019-01-10  Tom Tromey  <tom@tromey.com>
3435
3436         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3437         Don't declare.
3438         * mipsread.c: Include mdebugread.h.
3439         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3440         Declare.
3441         * elfread.c: Include mdebugread.h.
3442
3443 2019-01-09  Tom Tromey  <tom@tromey.com>
3444
3445         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3446         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3447         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3448         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3449         (psym_lookup_symbol, psym_find_last_source_symtab)
3450         (psym_forget_cached_source_info, psym_print_stats)
3451         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3452         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3453         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3454         (psym_find_compunit_symtab_by_address)
3455         (maintenance_print_psymbols, maintenance_info_psymtabs)
3456         (maintenance_check_psymtabs): Use ranged for.
3457         * psymtab.h (class objfile_psymtabs): New.
3458         (require_partial_symbols): Return objfile_psymtabs.
3459         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3460
3461 2019-01-09  Tom Tromey  <tom@tromey.com>
3462
3463         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3464         (find_pc_mapped_section, list_overlays_command)
3465         (map_overlay_command, unmap_overlay_command)
3466         (simple_overlay_update): Use all_objfiles.
3467         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3468         * printcmd.c (info_symbol_command): Use all_objfiles.
3469         * objfiles.h (ALL_OBJSECTIONS): Remove.
3470         * maint.c (maintenance_translate_address): Use all_objfiles.
3471         * gcore.c (gcore_create_callback): Use all_objfiles.
3472         (objfile_find_memory_regions): Likewise.
3473
3474 2019-01-09  Tom Tromey  <tom@tromey.com>
3475
3476         * symtab.c (find_line_symtab, info_sources_command)
3477         (make_source_files_completion_list): Use objfile_compunits.
3478         * source.c (select_source_symtab): Use objfile_compunits.
3479         * objfiles.h (struct objfile): Update comment.
3480         (ALL_OBJFILES): Remove.
3481         (ALL_FILETABS): Remove.
3482         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3483         objfile_compunits.
3484
3485 2019-01-09  Tom Tromey  <tom@tromey.com>
3486
3487         * symmisc.c (print_objfile_statistics, dump_objfile)
3488         (maintenance_print_symbols): Use compunit_filetabs.
3489         * source.c (forget_cached_source_info_for_objfile): Use
3490         compunit_filetabs.
3491         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3492         (ALL_FILETABS): Use compunit_filetabs.
3493         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3494         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3495
3496 2019-01-09  Tom Tromey  <tom@tromey.com>
3497
3498         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3499         (compunit_filetabs): New.
3500         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3501         compunit_filetabs.
3502         (info_sources_command, make_source_files_completion_list): Remove
3503         declaration.
3504         * symmisc.c (print_objfile_statistics, dump_objfile)
3505         (maintenance_print_symbols): Remove declaration.
3506         (maintenance_info_symtabs): Use compunit_filetabs.
3507         (maintenance_info_line_tables): Likewise.
3508         * source.c (select_source_symtab): Change local variable name.
3509         (forget_cached_source_info_for_objfile): Remove declaration.
3510         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3511         * objfiles.c (objfile_relocate1): Remove declaration.
3512         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3513         declaration.
3514         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3515         * coffread.c (coff_symtab_read): Remove declaration.
3516         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3517         compunit_filetabs.
3518
3519 2019-01-09  Tom Tromey  <tom@tromey.com>
3520
3521         * symtab.c (lookup_objfile_from_block)
3522         (find_pc_sect_compunit_symtab, search_symbols)
3523         (default_collect_symbol_completion_matches_break_on): Use
3524         objfile_compunits.
3525         * objfiles.h (ALL_COMPUNITS): Remove.
3526         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3527         * cp-support.c (add_symbol_overload_list_qualified): Use
3528         objfile_compunits.
3529         * ada-lang.c (ada_collect_symbol_completion_matches)
3530         (ada_add_global_exceptions): Use objfile_compunits.
3531
3532 2019-01-09  Tom Tromey  <tom@tromey.com>
3533
3534         * source.c (select_source_symtab)
3535         (forget_cached_source_info_for_objfile): Remove declaration.
3536         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3537         declaration.
3538         * maint.c (count_symtabs_and_blocks): Remove declaration.
3539         * cp-support.c (add_symbol_overload_list_qualified): Remove
3540         declaration.
3541         * coffread.c (coff_symtab_read): Remove declaration.
3542         * symtab.c (lookup_symbol_in_objfile_symtabs)
3543         (basic_lookup_transparent_type_1): Use objfile_compunits.
3544         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3545         (info_sources_command, search_symbols)
3546         (default_collect_symbol_completion_matches_break_on)
3547         (make_source_files_completion_list): Remove declaration.
3548         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3549         (ada_collect_symbol_completion_matches)
3550         (ada_add_global_exceptions): Remove declaration.
3551         * linespec.c (iterate_over_all_matching_symtabs): Use
3552         objfile_compunits.
3553         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3554         (class objfile_compunits): New.
3555         (ALL_COMPUNITS): Use objfile_compunits.
3556         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3557         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3558         objfile_compunits.
3559         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3560
3561 2019-01-09  Tom Tromey  <tom@tromey.com>
3562
3563         * symtab.c (search_symbols)
3564         (default_collect_symbol_completion_matches_break_on): Use
3565         objfile_msymbols.
3566         * ada-lang.c (ada_lookup_simple_minsym)
3567         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3568         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3569         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3570         objfile_msymbols.
3571         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3572         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3573         * objc-lang.c (find_methods): Use objfile_msymbols.
3574         (info_selectors_command, info_classes_command): Likewise.
3575         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3576         * objfiles.h (class objfile_msymbols): New.
3577         (ALL_OBJFILE_MSYMBOLS): Remove.
3578         (ALL_MSYMBOLS): Remove.
3579
3580 2019-01-09  Tom Tromey  <tom@tromey.com>
3581
3582         * common/next-iterator.h (next_adapter): Add Iterator template
3583         parameter.
3584         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3585         (class all_objfiles_safe): New.
3586         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3587         * objfiles.c (put_objfile_before): Update comment.
3588         (add_separate_debug_objfile): Likewise.
3589         (free_all_objfiles): Use all_objfiles_safe.
3590         (objfile_purge_solibs): Likewise.
3591
3592 2019-01-09  Tom Tromey  <tom@tromey.com>
3593
3594         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3595         (expand_symtab_containing_pc, lookup_static_symbol)
3596         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3597         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3598         all_objfiles.
3599         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3600         * breakpoint.c (create_overlay_event_breakpoint)
3601         (create_longjmp_master_breakpoint)
3602         (create_std_terminate_master_breakpoint)
3603         (create_exception_master_breakpoint): Use all_objfiles.
3604         * linux-thread-db.c (try_thread_db_load_from_pdir)
3605         (has_libpthread): Use all_objfiles.
3606         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3607         * linespec.c (iterate_over_all_matching_symtabs)
3608         (search_minsyms_for_name): Use all_objfiles.
3609         * maint.c (maintenance_info_sections): Use all_objfiles.
3610         * main.c (captured_main_1): Use all_objfiles.
3611         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3612         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3613         * guile/scm-pretty-print.c
3614         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3615         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3616         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3617         (maintenance_print_msymbols): Use all_objfiles.
3618         * source.c (select_source_symtab): Use all_objfiles.
3619         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3620         * symfile.c (remove_symbol_file_command)
3621         (expand_symtabs_matching, map_symbol_filenames): Use
3622         all_objfiles.
3623         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3624         all_objfiles.
3625         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3626         * objc-lang.c (find_methods): Use all_objfiles.
3627         * objfiles.c (have_partial_symbols, have_full_symbols)
3628         (have_minimal_symbols, qsort_cmp)
3629         (default_iterate_over_objfiles_in_search_order): Use
3630         all_objfiles.
3631         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3632         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3633         (maintenance_check_psymtabs): Use all_objfiles.
3634         (ALL_PSYMTABS): Remove.
3635         * compile/compile-object-run.c (do_module_cleanup): Use
3636         all_objfiles.
3637         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3638         * cp-support.c (add_symbol_overload_list_qualified): Use
3639         all_objfiles.
3640         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3641         Use all_objfiles.
3642         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3643         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3644         all_objfiles.
3645         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3646         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3647         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3648         Uses all_objfiles.
3649         * solib.c (solib_read_symbols): Use all_objfiles
3650
3651 2019-01-09  Tom Tromey  <tom@tromey.com>
3652
3653         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3654         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3655         all_objfiles.
3656         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3657         * symmisc.c (print_symbol_bcache_statistics)
3658         (print_objfile_statistics, maintenance_print_objfiles)
3659         (maintenance_info_symtabs, maintenance_check_symtabs)
3660         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3661         all_objfiles.
3662         * source.c (forget_cached_source_info): Use all_objfiles.
3663         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3664         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3665         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3666         * objfiles.c (update_section_map): Use all_objfiles.
3667         (shared_objfile_contains_address_p): Likewise.
3668         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3669         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3670
3671 2019-01-09  Tom Tromey  <tom@tromey.com>
3672
3673         * common/next-iterator.h: New file.
3674         * objfiles.h (class all_objfiles): New.
3675         (struct objfile_iterator): New.
3676
3677 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3678
3679         * NEWS: Move the description of the changed "frame", "select-frame",
3680          and "info frame" commands to the Changed commands section.
3681
3682 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3683
3684         * gdbtypes.c (check_stub_method_group): Remove handling of old
3685         mangling schemes.
3686         * linespec.c (find_methods): Likewise.
3687         * stabsread.c (read_member_functions): Likewise.
3688         * valops.c (search_struct_method): Likewise.
3689         (value_struct_elt_for_reference): Likewise.
3690         * NEWS: Mention this change.
3691
3692 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3693
3694         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3695         print_source_lines.
3696         * source.c (print_source_lines_base): Update line number check.
3697         (print_source_lines): New function.
3698         (source_lines_range::source_lines_range): New function.
3699         * source.h (class source_lines_range): New class.
3700         (print_source_lines): New declaration.
3701
3702 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3703
3704         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3705
3706 2019-01-08  Tom Tromey  <tom@tromey.com>
3707             Simon Marchi  <simon.marchi@ericsson.com>
3708
3709         PR gdb/24060
3710         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3711         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3712         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3713         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3714         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3715         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3716
3717 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3718
3719         * source.c (select_source_symtab): Move header comment to
3720         declaration in source.h.
3721         (forget_cached_source_info_for_objfile): Likewise.
3722         (forget_cached_source_info): Likewise.
3723         (identify_source_line): Likewise.
3724         * source.h (identify_source_line): Move declaration from symtab.h
3725         and add comment from source.c
3726         (print_source_lines): Likewise.
3727         (forget_cached_source_info_for_objfile): Likewise.
3728         (forget_cached_source_info): Likewise.
3729         (select_source_symtab): Likewise.
3730         (enum print_source_lines_flag): Move definition from symtab.h.
3731         * symtab.h (identify_source_line): Move declaration to source.h.
3732         (print_source_lines): Likewise.
3733         (forget_cached_source_info_for_objfile): Likewise.
3734         (forget_cached_source_info): Likewise.
3735         (select_source_symtab): Likewise.
3736         (enum print_source_lines_flag): Move definition to source.h.
3737         * tui/tui-hooks.c: Add 'source.h' include.
3738
3739 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3740
3741         * source.c (print_source_lines_base): Handle requests to print
3742         reverse line number sequences, and guard against empty lines
3743         string.
3744
3745 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * source.c (print_source_lines_base): Fix skip of '\r' if next
3748         character is '\n'.
3749
3750 2019-01-06  Tom Tromey  <tom@tromey.com>
3751
3752         * c-exp.y (struct c_parse_state) <macro_original_text,
3753         expansion_obstack>: New member.
3754         (macro_original_text, expansion_obstack): Remove globals.
3755         (scan_macro_expansion, scanning_macro_expansion)
3756         (finished_macro_expansion): Update.
3757         (scan_macro_cleanup): Remove.
3758         (yylex, c_parse): Update.
3759
3760 2019-01-06  Tom Tromey  <tom@tromey.com>
3761
3762         * c-exp.y (struct c_parse_state) <strings>: New member.
3763         (operator_stoken): Update.
3764
3765 2019-01-06  Tom Tromey  <tom@tromey.com>
3766
3767         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3768         (union type_stack_elt) <typelist_val>: Now a pointer to
3769         std::vector.
3770         (type_stack_cleanup): Don't declare.
3771         (push_typelist): Update.
3772         * parse.c (pop_typelist): Return a std::vector.
3773         (push_typelist): Take a std::vector.
3774         (follow_types): Update.  Do not free args.
3775         (type_stack_cleanup): Remove.
3776         * c-exp.y (struct c_parse_state): New.
3777         (cpstate): New global.
3778         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3779         (nonempty_typelist): Update.
3780         (func_mod): Create a new vector.
3781         (c_parse): Create a c_parse_state.
3782         (check_parameter_typelist): Do not delete params.
3783         (function_method): Update.  Do not delete type_list.
3784
3785 2019-01-06  Tom Tromey  <tom@tromey.com>
3786
3787         PR gdb/28155:
3788         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3789         check_typedef.
3790         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3791         (print_return_value): Likewise.
3792
3793 2019-01-05  Tom Tromey  <tom@tromey.com>
3794
3795         * contrib/cleanup_check.py: Remove.
3796         * contrib/gcc-with-excheck: Remove.
3797         * contrib/exsummary.py: Remove.
3798         * contrib/excheck.py: Remove.
3799
3800 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3801
3802         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3803         NULL. Initialize tpprev to NULL instead of assigning it
3804         to NULL on the next statement.
3805         * windows-nat.c (windows_delete_thread): Remove check for
3806         main_thread_id before printing thread exit notifications.
3807         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3808         Remove thread ID check against main_thread_id.
3809         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3810         windows_delete_thread.
3811         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3812
3813 2019-01-04  Tom Tromey  <tom@tromey.com>
3814
3815         * compile/compile.c (_initialize_compile): Use upper case for
3816         metasyntactic variables.
3817         * symmisc.c (_initialize_symmisc): Use upper case for
3818         metasyntactic variables.
3819         * psymtab.c (_initialize_psymtab): Use upper case for
3820         metasyntactic variables.
3821         * demangle.c (demangle_command): Use upper case for metasyntactic
3822         variables.
3823         (_initialize_demangler): Likewise.
3824         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3825         variables.
3826
3827 2019-01-03  Tom Tromey  <tom@tromey.com>
3828
3829         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3830
3831 2019-01-03  Tom Tromey  <tom@tromey.com>
3832
3833         * python/py-symtab.c (salpy_str): Update.
3834         (struct salpy_sal_object) <symtab>: Now a PyObject.
3835         (salpy_dealloc): Update.
3836         (del_objfile_sal): Use gdbpy_ref.
3837
3838 2019-01-03  Tom Tromey  <tom@tromey.com>
3839
3840         * python/py-type.c (convert_field): Use new_reference.  Return
3841         gdbpy_ref.
3842         (make_fielditem): Return gdbpy_ref.
3843         (typy_fields): Update.
3844         (typy_getitem): Update.
3845         (field_name): Return gdbpy_ref.  Use new_reference.
3846         (typy_iterator_iternext): Update.
3847
3848 2019-01-03  Tom Tromey  <tom@tromey.com>
3849
3850         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3851
3852 2019-01-03  Tom Tromey  <tom@tromey.com>
3853
3854         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3855         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3856         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3857         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3858         (pspy_set_type_printers): Likewise.
3859         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3860         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3861         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3862         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3863         (objfpy_set_type_printers): Likewise.
3864
3865 2019-01-03  Tom Tromey  <tom@tromey.com>
3866
3867         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3868         (gdbpy_print_stack): Use gdbpy_err_fetch.
3869         * python/python-internal.h (class gdbpy_err_fetch): New class.
3870         (class gdbpy_enter) <m_error_type, m_error_value,
3871         m_error_traceback>: Remove.
3872         <m_error>: New member.
3873         (gdbpy_exception_to_string): Don't declare.
3874         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3875         * python/py-value.c (convert_value_from_python): Use
3876         gdbpy_err_fetch.
3877         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3878         gdbpy_exception_to_string.
3879         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3880         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3881         gdbpy_err_fetch.
3882
3883 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * linux-nat.c (delete_lwp_cleanup): Delete.
3886         (struct lwp_deleter): New struct.
3887         (lwp_info_up): New typedef.
3888         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3889         lwp_info_up.
3890
3891 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * linux-fork.c (class scoped_switch_fork_info): New class.
3894         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3895
3896 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * valops.c (find_overload_match): Remove use of null_cleanup, and
3899         calls to do_cleanups.
3900
3901 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * compile/compile-cplus-types.c
3904         (compile_cplus_instance::decl_name): Handle changes to
3905         cp_func_name.
3906         * cp-support.c (cp_func_name): Update header comment, update
3907         return type.
3908         * cp-support.h (cp_func_name): Update return type in declaration.
3909         * valops.c (find_overload_match): Move temp_func local to top
3910         level of function and change its type.  Use temp_func to hold and
3911         delete temporary string obtained from cp_func_name.
3912
3913 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3914
3915         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3916         gdb::char_vector, remove cleanup, and update uses of `msg`.
3917
3918 2019-01-03  Jim Wilson  <jimw@sifive.com>
3919
3920         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3921
3922 2019-01-02  Tom Tromey  <tom@tromey.com>
3923
3924         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3925         (tdesc_parse_xml): Remove cleanups.
3926         * target-descriptions.h (make_cleanup_free_target_description):
3927         Don't declare.
3928         (target_desc_deleter): New struct.
3929         (target_desc_up): New typedef.
3930         * target-descriptions.c (target_desc_deleter::operator()): Rename
3931         from free_target_description.
3932         (make_cleanup_free_target_description): Remove.
3933
3934 2019-01-02  Tom Tromey  <tom@tromey.com>
3935
3936         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3937         constructor, destructor.
3938         (linespec_parser): Remove typedef.
3939         (~linespec_parser): Rename from linespec_parser_delete.
3940         (linespec_lex_to_end, linespec_complete_label)
3941         (linespec_complete): Update.
3942         (decode_line_full): Remove cleanups.
3943         (decode_line_1): Update.
3944
3945 2019-01-02  Tom Tromey  <tom@tromey.com>
3946
3947         * python/python-internal.h (inferior_to_inferior_object): Change
3948         return type.
3949         * python/py-exitedevent.c (create_exited_event_object): Update.
3950         * python/py-inferior.c (inferior_to_inferior_object): Return
3951         gdbpy_ref.
3952         (python_new_inferior, python_inferior_deleted)
3953         (thread_to_thread_object, delete_thread_object)
3954         (build_inferior_list, gdbpy_selected_inferior): Update.
3955         * python/py-infthread.c (create_thread_object): Update.  Also fail
3956         if inferior_to_inferior_object fails.
3957
3958 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3959
3960         * inferior.h (class inferior) <displaced_step_state>: New field.
3961         * infrun.h (struct displaced_step_state): Move here from
3962         infrun.c.  Initialize fields, add constructor.
3963         <inf>: Remove field.
3964         <reset>: New method.
3965         * infrun.c (struct displaced_step_inferior_state): Move to
3966         infrun.h.
3967         (displaced_step_inferior_states): Remove.
3968         (get_displaced_stepping_state): Adust.
3969         (displaced_step_in_progress_any_inferior): Adjust.
3970         (displaced_step_in_progress_thread): Adjust.
3971         (displaced_step_in_progress): Adjust.
3972         (add_displaced_stepping_state): Remove.
3973         (get_displaced_step_closure_by_addr): Adjust.
3974         (remove_displaced_stepping_state): Remove.
3975         (infrun_inferior_exit): Call displaced_step_state.reset.
3976         (use_displaced_stepping): Don't check for NULL.
3977         (displaced_step_prepare_throw): Call
3978         get_displaced_stepping_state.
3979         (displaced_step_fixup): Don't check for NULL.
3980         (prepare_for_detach): Don't check for NULL.
3981
3982 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3983
3984         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3985          in case of call that did not complete.
3986
3987 2019-01-02  Andrey Utkin  <autkin@undo.io>
3988
3989         * symfile.c (find_separate_debug_file): Fix search of debug files for
3990         remote debuggee.
3991
3992 2019-01-02  Tom Tromey  <tom@tromey.com>
3993
3994         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3995         indentation.
3996         * python/py-frame.c (frapy_older): Remove cast.
3997         (frapy_newer): Likewise.
3998         * python/py-breakpoint.c (local_setattro): Remove cast.
3999         * python/py-arch.c (archpy_name): Remove local variable.
4000         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4001
4002 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4003
4004         * unittests/basic_string_view/element_access/char/empty.cc:
4005         Fix year range in copyright header.
4006
4007 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4008
4009         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4010         Delete.
4011         <operator==>: Update with for removed field.
4012         <hash>: Likewise.
4013         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4014         <isa_features>: ...this.
4015         <abi_features>: New field.
4016         (riscv_isa_flen): Update comment.
4017         (riscv_abi_xlen): New declaration.
4018         (riscv_abi_flen): New declaration.
4019         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4020         isa_features.
4021         (riscv_abi_xlen): New function.
4022         (riscv_isa_flen): Update to get answer from isa_features.
4023         (riscv_abi_flen): New function.
4024         (riscv_has_fp_abi): Update to get answer from abi_features.
4025         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4026         xlen and flen.
4027         (riscv_call_info) <xlen, flen>: Update comment.
4028         (riscv_call_arg_struct): Remove invalid assertions
4029         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4030         is removed.
4031         (riscv_gdbarch_init): Gather isa features and abi features
4032         separately, ensure both match on the gdbarch when reusing an old
4033         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4034         a target with 64-bit float hardware.
4035
4036 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4037
4038         * source.c (search_command_helper): Stop reverse search
4039         when line 1 has been searched.
4040
4041 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4042
4043         * record-full.c (record_full_base_target::close): Rewrite
4044         record_full_core_buf_list free logic.
4045
4046 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4047
4048         * break-catch-syscall.c (print_one_catch_syscall): xfree
4049         the last text.
4050
4051 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4052
4053         * top.c (print_gdb_version): Update Copyright year in version
4054         message.
4055
4056 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4057
4058         Update copyright year range in all GDB files.
4059
4060 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4061
4062         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4063
4064 For older changes see ChangeLog-2018.
4065 \f
4066 Local Variables:
4067 mode: change-log
4068 left-margin: 8
4069 fill-column: 74
4070 version-control: never
4071 coding: utf-8
4072 End:
4073