gdb/ChangeLog

   1 2019-08-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
   4         * ada-lang.c (ada_enum_name): Likewise.
   5
   6 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
   7
   8         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
   9         leading underscore.
  10         (GdbOutputErrorFile): Likewise.
  11         (global scope): Adjust constructor calls to GdbOutput{,Error}File
  12         accordingly.
  13         (execute_unwinders): Rename to have a leading underscore.
  14         (auto_load_packages): Likewise.
  15         (global scope): Adjust call to auto_load_packages accordingly.
  16         (GdbSetPythonDirectory): Likewise.
  17         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
  18         instead of execute_unwinders.
  19
  20 2019-08-15  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-layout.c (show_layout, show_source_disasm_command)
  23         (show_data): Don't change window visibility.
  24         (tui_gen_win_info::resize): Remove special case for command
  25         window.  Use wresize, when available.
  26         (show_source_or_disasm_and_command): Don't change window
  27         visibility.
  28         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
  29         <make_visible>: New method.
  30         * tui/tui-command.c (tui_cmd_window::resize): New method.
  31
  32 2019-08-15  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
  35         (struct tui_source_windows): New.
  36         * tui/tui-winsource.c (tui_display_main): Update.
  37         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  38         (new_height_ok, parse_scrolling_args): Update.
  39         * tui/tui-layout.c (show_layout, show_data): Update.
  40         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
  41         (tui_add_to_source_windows): Don't declare.
  42         * tui/tui-data.c (source_windows, tui_source_windows)
  43         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
  44
  45 2019-08-15  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
  48         Rename from reset.
  49         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
  50         * tui/tui-layout.c (show_source_disasm_command, show_data):
  51         Update.
  52         (tui_gen_win_info::resize): Rename.
  53         (show_source_or_disasm_and_command): Update.
  54         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
  55         reset.
  56
  57 2019-08-15  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-stack.c (tui_initialize_static_data): Remove.
  60         * tui/tui-interp.c (tui_interp::init): Don't call
  61         tui_initialize_static_data.
  62         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
  63
  64 2019-08-15  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
  67         examine tui_win_list.
  68
  69 2019-08-15  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
  72         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
  73         tui_clear_source_content.
  74         (tui_clear_source_content): Remove.
  75         (tui_source_window_base::do_erase_source_content): Hoist call to
  76         content.clear().
  77         * tui/tui-stack.c (tui_show_frame_info): Don't call
  78         tui_clear_source_content.
  79
  80 2019-08-15  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-winsource.h (struct tui_source_window_base)
  83         <do_erase_source_content>: New method.
  84         <erase_source_content>: New method.
  85         (tui_erase_source_content): Don't declare.
  86         * tui/tui-winsource.c (tui_clear_source_content): Update.
  87         (tui_source_window_base::do_erase_source_content): Rename from
  88         tui_erase_source_content.
  89         (tui_source_window_base::show_source_content): Update.
  90         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
  91         * tui/tui-source.h (struct tui_source_window)
  92         <erase_source_content>: New method.
  93         * tui/tui-disasm.h (struct tui_disasm_window)
  94         <erase_source_content>: New method.
  95
  96 2019-08-15  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
  99         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 100         constructor.
 101         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 102         * tui/tui-source.c (tui_set_source_content): Update.
 103         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 104
 105 2019-08-15  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 108         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 109         tui-source.c.
 110         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 111         Declare.
 112         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 113         method.
 114         (tui_source_window::maybe_update): Update.
 115
 116 2019-08-15  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 119         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 120         tui-disasm.c.
 121         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 122         Declare.
 123         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 124         method.
 125         (tui_disasm_window::maybe_update): Update.
 126
 127 2019-08-15  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-winsource.h (struct tui_source_window_base)
 130         <maybe_update>: Declare.
 131         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 132         method.
 133         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 134         Declare.
 135         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 136         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 137         Declare.
 138         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 139
 140 2019-08-15  Tom Tromey  <tom@tromey.com>
 141
 142         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 143
 144 2019-08-15  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-wingeneral.c: Include tui-stack.h.
 147         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 148         (struct tui_locator_window): Move from tui-data.h.
 149         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 150         (tui_initialize_static_data): Move from tui-data.c.
 151         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 152         (struct tui_locator_window): Move to tui-stack.c.
 153         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 154         (tui_initialize_static_data): Move to tui-stack.c.
 155
 156 2019-08-15  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-layout.c (show_source_disasm_command)
 159         (show_source_or_disasm_and_command): Use make_visible method, not
 160         tui_make_window.
 161         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 162         Remove.
 163
 164 2019-08-15  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-wingeneral.h (tui_make_window): Update.
 167         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 168         parameter.
 169         (tui_gen_win_info::make_visible): Update.
 170         * tui/tui-regs.c (tui_data_window::display_registers_from):
 171         Update.
 172         * tui/tui-layout.c (show_source_disasm_command)
 173         (show_source_or_disasm_and_command): Update.
 174         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 175         (enum tui_box): Remove.
 176         (struct tui_win_info) <can_box>: New method.
 177         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 178         method.
 179
 180 2019-08-15  Tom de Vries  <tdevries@suse.de>
 181
 182         * linux-nat-trad.c: Include gdbarch.h.
 183
 184 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 185
 186         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 187         register sizes.
 188
 189 2019-08-14  Tom Tromey  <tromey@adacore.com>
 190
 191         * darwin-nat.c: Include gdbarch.h.
 192         * darwin-nat-info.c: Include gdbarch.h.
 193
 194 2019-08-13  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 197         Remove.
 198         * tui/tui-data.c (tui_initialize_static_data): Update.
 199
 200 2019-08-13  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-winsource.h (struct tui_exec_info_window)
 203         <~tui_exec_info_window, maybe_allocate_content, get_content,
 204         m_content>: Remove.
 205         (struct tui_source_window_base) <set_exec_info_content,
 206         show_exec_info_content>: Don't declare.
 207         * tui/tui-winsource.c
 208         (tui_exec_info_window::maybe_allocate_content): Remove.
 209         (tui_source_window_base::update_exec_info): Rename from
 210         set_exec_info_content.
 211         (tui_source_window_base::show_exec_info_content)
 212         (tui_source_window_base::update_exec_info): Remove.
 213
 214 2019-08-13  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 217         declare.
 218         * tui/tui-winsource.c (tui_update_source_window_as_is)
 219         (tui_update_source_windows_with_addr, tui_erase_source_content):
 220         Update.
 221         (tui_clear_exec_info_content): Remove.
 222
 223 2019-08-13  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 226         declare.
 227         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 228         call tui_erase_exec_info_content.
 229         (tui_clear_exec_info_content): Rename from
 230         tui_erase_exec_info_content.
 231         (tui_clear_exec_info_content): Delete.
 232
 233 2019-08-13  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-winsource.h (struct tui_source_window_base)
 236         <show_exec_info_content>: Declare.
 237         (tui_show_exec_info_content): Don't declare.
 238         * tui/tui-winsource.c
 239         (tui_source_window_base::show_exec_info_content): Rename from
 240         tui_show_exec_info_content.
 241         (tui_source_window_base::update_exec_info): Update.
 242
 243 2019-08-13  Tom Tromey  <tom@tromey.com>
 244
 245         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 246         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 247         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 248         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 249         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 250         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 251         ... here.
 252
 253 2019-08-13  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-winsource.h (struct tui_source_window_base)
 256         <update_exec_info>: Declare.
 257         (tui_update_exec_info): Don't declare.
 258         * tui/tui-winsource.c (tui_update_source_window_as_is)
 259         (tui_source_window_base::refresh_all)
 260         (tui_update_all_breakpoint_info): Update.
 261         (tui_source_window_base::update_exec_info): Rename from
 262         tui_update_exec_info.
 263         * tui/tui-stack.c (tui_show_frame_info): Update.
 264
 265 2019-08-13  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-winsource.h (struct tui_source_window_base)
 268         <set_exec_info_content>: Declare.
 269         (tui_set_exec_info_content): Don't declare.
 270         * tui/tui-winsource.c
 271         (tui_source_window_base::set_exec_info_content): Rename from
 272         tui_set_exec_info_content.
 273         (tui_update_exec_info): Update.
 274
 275 2019-08-13  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-winsource.h (struct tui_source_window_base)
 278         <show_source_content>: Declare.
 279         (tui_show_source_content): Don't declare.
 280         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 281         (tui_source_window_base::show_source_content): Rename from
 282         tui_show_source_content.
 283         (tui_source_window_base::refresh_all): Update.
 284         * tui/tui-layout.c (show_source_disasm_command)
 285         (show_source_or_disasm_and_command): Update.
 286
 287 2019-08-13  Tom Tromey  <tom@tromey.com>
 288
 289         * tui/tui-winsource.c (tui_erase_source_content)
 290         (tui_show_source_content, tui_source_window_base::refresh_all):
 291         Update.
 292         * tui/tui-wingeneral.h
 293         (tui_check_and_display_highlight_if_needed): Don't declare.
 294         * tui/tui-wingeneral.c
 295         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 296         check_and_display_highlight_if_needed.
 297         * tui/tui-win.c (tui_rehighlight_all)
 298         (tui_win_info::make_visible_with_new_height): Update.
 299         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 300         (tui_data_window::erase_data_content)
 301         (tui_data_window::display_all_data): Update.
 302         * tui/tui-data.h (struct tui_win_info)
 303         <check_and_display_highlight_if_needed>: Declare.
 304
 305 2019-08-13  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-win.c (tui_resize_all): Call
 308         tui_delete_invisible_windows.
 309         * tui/tui-layout.c (show_layout): Call
 310         tui_delete_invisible_windows.
 311         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 312         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 313
 314 2019-08-13  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 317         tui_add_win_to_layout.
 318
 319 2019-08-13  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 322         * tui/tui-layout.c (tui_default_win_height): Now static.
 323
 324 2019-08-13  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 327         single switch.
 328         (show_source_disasm_command, show_source_or_disasm_and_command):
 329         Don't check current layout.
 330
 331 2019-08-13  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-wingeneral.c (make_all_visible): Remove.
 334         (tui_make_all_invisible): Simplify.
 335         * tui/tui-layout.c (tui_make_all_invisible): Move from
 336         tui-wingeneral.c; simplify.
 337         (show_layout): Hoist call to tui_make_all_invisible.
 338         (show_data): Don't call tui_make_all_invisible.
 339
 340 2019-08-13  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 343         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 344
 345 2019-08-13  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 348         tui-data.c.
 349         (show_source_disasm_command, show_data)
 350         (show_source_or_disasm_and_command): Don't use
 351         tui_set_current_layout_to.
 352         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 353         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 354         tui-layout.c.
 355         (tui_set_current_layout_to): Remove.
 356
 357 2019-08-13  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui-layout.c (tui_set_layout): Update.
 360         * tui/tui-data.h (struct tui_layout_def): Remove.
 361         (tui_layout_def): Don't declare.
 362         * tui/tui-data.c (layout_def): Remove.
 363         (tui_layout_def): Remove.
 364
 365 2019-08-13  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-winsource.h (struct tui_source_window_base)
 368         <clear_detail>: No longer "override".
 369         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 370         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 371         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 372         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 373         Remove.
 374         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 375
 376 2019-08-13  Tom Tromey  <tromey@adacore.com>
 377
 378         * tracepoint.c: Don't include readline.h or history.h.
 379
 380 2019-08-12  Tom Tromey  <tom@tromey.com>
 381
 382         * configure: Rebuild.
 383         * configure.ac: Check for readline 7.
 384         * NEWS: Mention readline 7 requirement.
 385         * README: Update.
 386
 387 2019-08-12  Tom Tromey  <tom@tromey.com>
 388
 389         * mingw-hdep.c (gdb_select): Remove readline hack.
 390
 391 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 392
 393         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 394         when the function fails.
 395
 396 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 397
 398         * s390-tdep.c (s390_type_align): New function.
 399         (s390_gdbarch_init): Set it as type_align gdbarch method.
 400
 401 2019-08-09  Tom de Vries  <tdevries@suse.de>
 402
 403         PR gdb/24591
 404         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 405         pc_low with relocation offset.
 406
 407 2019-08-07  Tom Tromey  <tromey@adacore.com>
 408
 409         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 410         (print_frame_args): Update.
 411         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 412         Update.
 413         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 414         * frame.h (struct frame_arg): Add initializers.
 415         <error>: Now a unique_xmalloc_ptr.
 416
 417 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 418
 419         * NEWS: Expand the Pointer Authentication entry.
 420         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 421         (aarch64_frame_unmask_lr): ... to this.
 422         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 423         Call aarch64_frame_unmask_lr.
 424         * frame.c (struct frame_info): Add "masked" variable.
 425         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 426         (fprint_frame): Check for masked pc.
 427         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 428         declarations.
 429         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 430         * stack.c (print_frame): Check for masked pc.
 431
 432 2019-08-06  Tom Tromey  <tom@tromey.com>
 433
 434         * stabsread.c (patch_block_stabs, read_one_struct_field)
 435         (read_enum_type): Use obstack_strndup.
 436         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 437         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 438         * dwarf2read.c (guess_full_die_structure_name)
 439         (anonymous_struct_prefix): Use obstack_strndup.
 440         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 441         * c-exp.y (yylex): Use obstack_strndup.
 442         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 443         (write_var_or_type): Use obstack_strndup.
 444
 445 2019-08-06  Tom Tromey  <tom@tromey.com>
 446
 447         * symfile.c (reread_symbols): Use obstack_strdup.
 448         * stabsread.c (read_type): Use obstack_strdup.
 449         * gdb_obstack.h (obstack_strdup): New overload.
 450         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 451         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 452         (dwarf2_canonicalize_name): Use obstack_strdup.
 453         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 454         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 455         Use obstack_strdup.
 456
 457 2019-08-06  Tom Tromey  <tom@tromey.com>
 458
 459         * gdb_obstack.h (obstack_strdup): Define.
 460         * gdb_obstack.c (obstack_strdup): Don't define.
 461
 462 2019-08-06  Tom Tromey  <tom@tromey.com>
 463
 464         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 465         obstack_strdup.
 466         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 467         obstack_strdup.
 468         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 469         * stabsread.c (common_block_start): Use obstack_strdup.
 470         * objfiles.c (set_objfile_main_name, objfile): Use
 471         obstack_strdup.
 472         * namespace.c (add_using_directive): Use obstack_strdup.
 473         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 474         * jit.c (finalize_symtab): Use obstack_strdup.
 475         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 476         (guess_partial_die_structure_name, partial_die_info::fixup)
 477         (dwarf2_name): Use obstack_strdup.
 478         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 479         obstack_strdup.
 480         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 481         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 482         obstack_strdup.
 483         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 484
 485 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 486
 487         * unittests/help-doc-selftests.c: New file.
 488         * Makefile.in: Add the new file.
 489
 490 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 491
 492         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 493         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 494         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 495         the trailing '.' is not output, and the first character is uppercased.
 496         (print_help_for_command): Update call to print_doc_line.
 497         (print_doc_of_command): Likewise.
 498         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 499         * cli/cli-option.c (append_indented_doc): Do not append newline.
 500         (build_help_option): Append newline after first appended_indented_doc
 501         only if a second call is done.
 502         (build_help): Append 2 new lines before each option, except the first
 503         one.
 504         * compile/compile.c (_initialize_compile): Add new lines after
 505         %OPTIONS%, when not at the end of the help.
 506         Change help doc or code
 507         producing the help doc to respect the invariants.
 508         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 509         Also removed the new line after 'Options:', as all other commands
 510         do not put an empty line between 'Options:' and the first option.
 511         * printcmd.c (_initialize_printcmd): Likewise.
 512         * stack.c (_initialize_stack): Likewise.
 513         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 514         incorrectly telling COMMAND is optional.
 515         * ada-lang.c (_initialize_ada_language): Change help doc or code
 516         producing the help doc to respect the invariants.
 517         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 518         * breakpoint.c (_initialize_breakpoint): Likewise.
 519         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 520         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 521         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 522         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 523         _initialize_cli_style): Likewise.
 524         * corelow.c (core_target_info): Likewise.
 525         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 526         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 527         * filesystem.c (_initialize_filesystem): Likewise.
 528         * frame.c (_initialize_frame): Likewise.
 529         * gnu-nat.c (add_task_commands): Likewise.
 530         * infcall.c (_initialize_infcall): Likewise.
 531         * infcmd.c (_initialize_infcmd): Likewise.
 532         * interps.c (_initialize_interpreter): Likewise.
 533         * language.c (_initialize_language): Likewise.
 534         * linux-fork.c (_initialize_linux_fork): Likewise.
 535         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 536         * maint.c (_initialize_maint_cmds): Likewise.
 537         * memattr.c (_initialize_mem): Likewise.
 538         * printcmd.c (_initialize_printcmd): Likewise.
 539         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 540         _RegEx): Likewise.
 541         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 542         * record-btrace.c (_initialize_record_btrace): Likewise.
 543         * record-full.c (_initialize_record_full): Likewise.
 544         * record.c (_initialize_record): Likewise.
 545         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 546         * regcache.c (_initialize_regcache): Likewise.
 547         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 548         _initialize_remote): Likewise.
 549         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 550         * serial.c (_initialize_serial): Likewise.
 551         * skip.c (_initialize_step_skip): Likewise.
 552         * source.c (_initialize_source): Likewise.
 553         * stack.c (_initialize_stack): Likewise.
 554         * symfile.c (_initialize_symfile): Likewise.
 555         * symtab.c (_initialize_symtab): Likewise.
 556         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 557         * top.c (init_main): Likewise.
 558         * tracefile-tfile.c (tfile_target_info): Likewise.
 559         * tracepoint.c (_initialize_tracepoint): Likewise.
 560         * tui/tui-win.c (_initialize_tui_win): Likewise.
 561         * utils.c (add_internal_problem_command): Likewise.
 562         * valprint.c (value_print_option_defs): Likewise.
 563
 564 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 565
 566         PR build/24886
 567         * configure.ac: Drop enable-libmcheck support.
 568         * configure, config.in: Rebuild.
 569         * libmcheck.m4: Remove.
 570         * acinclude.m4: Don't include it.
 571         * Makefile.in: Don't distribute it.
 572         * top.c (print_gdb_configuration): Don't mention it.
 573
 574 2019-08-06  Tom Tromey  <tom@tromey.com>
 575
 576         * utils.c (set_output_style): Sometimes pass stream to
 577         emit_style_escape.
 578         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 579         * record-btrace.c (btrace_insn_history): Update.
 580         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 581         method.
 582         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 583         Update initializers.
 584         <m_uiout>: New field.
 585         <m_di>: Move lower.
 586         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 587         Remove "uiout" parameter.
 588         (dump_insns): Update.
 589         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 590         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 591
 592 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 593
 594         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 595         (error_in_psymtab_expansion): Likewise.
 596         (lookup_symbol_via_quick_fns): Likewise.
 597         (basic_lookup_transparent_type_quick): Likewise.
 598         (basic_lookup_transparent_type_1): Likewise.
 599
 600 2019-08-06  Tom Tromey  <tromey@adacore.com>
 601
 602         * source.c (last_source_error): Now bool.
 603         (print_source_lines_base): Make "noprint" bool.  Only open
 604         source file when last_source_visited changes.
 605
 606 2019-08-06  Tom Tromey  <tromey@adacore.com>
 607
 608         * annotate.c (annotate_source_line): Use g_source_cache.
 609         * source-cache.c (source_cache::get_plain_source_lines): Change
 610         parameters.  Populate m_offset_cache.
 611         (source_cache::ensure): New method.
 612         (source_cache::get_line_charpos): New method.
 613         (extract_lines): Move lower.  Change parameters.
 614         (source_cache::get_source_lines): Move lower.
 615         * source-cache.h (class source_cache): Update comment.
 616         <get_line_charpos>: New method.
 617         <get_source_lines>: Update comment.
 618         <clear>: Clear m_offset_cache.
 619         <get_plain_source_lines>: Change parameters.
 620         <ensure>: New method
 621         <m_offset_cache>: New member.
 622         * source.c (forget_cached_source_info_for_objfile): Update.
 623         (info_source_command): Use g_source_cache.
 624         (find_source_lines, open_source_file_with_line_charpos): Remove.
 625         (print_source_lines_base, search_command_helper): Use g_source_cache.
 626         * source.h (open_source_file_with_line_charpos): Don't declare.
 627         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 628         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 629         Use g_source_cache.
 630
 631 2019-08-06  Tom Tromey  <tromey@adacore.com>
 632
 633         * source-cache.c (source_cache::get_plain_source_lines):
 634         Remove "first_line" and "last_line" parameters.
 635         (source_cache::get_source_lines): Cache plain text.
 636         * source-cache.h (class source_cache)
 637         <get_plain_source_lines>: Update.
 638
 639 2019-08-06  Tom Tromey  <tromey@adacore.com>
 640
 641         * source-cache.c (extract_lines): No longer a method.
 642         Changed type of parameter.  Include final newline.
 643         (selftests::extract_lines_test): New function.
 644         (_initialize_source_cache): Likewise.
 645         * source-cache.h (class source_cache)
 646         <extract_lines>: Don't declare.
 647
 648 2019-08-06  Tom Tromey  <tromey@adacore.com>
 649
 650         * breakpoint.c (init_breakpoint_sal): Update.
 651         (breakpoint): Update.
 652         * breakpoint.h (struct breakpoint) <filter>: Now a
 653         unique_xmalloc_ptr.
 654
 655 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 656
 657         * NEWS: Mention dictionary access on blocks.
 658         * python/py-block.c (blpy_getitem): New function.
 659         (block_object_as_mapping): New struct.
 660         (block_object_type): Use new struct for tp_as_mapping field.
 661
 662 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 663
 664         * objfiles.h (objfile): Add a comment describing partial symbols.
 665
 666 2019-08-05  Tom Tromey  <tromey@adacore.com>
 667
 668         * compile/compile.c (_initialize_compile): Use _(), not N_().
 669         * thread.c (_initialize_thread): Use _(), not N_().
 670         * stack.c (_initialize_stack): Use _(), not N_().
 671         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 672
 673 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 674
 675         * dwarf2read.c (struct dw2_symtab_iterator):
 676         <want_specific_block>: Remove.
 677         <block_index>: Change type to gdb::optional.
 678         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 679         change type of BLOCK_INDEX parameter to gdb::optional.
 680         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 681         (dw2_lookup_symbol): Don't pass argument for
 682         WANT_SPECIFIC_BLOCK.
 683         (dw2_expand_symtabs_for_function): Don't pass argument for
 684         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 685         (class dw2_debug_names_iterator)
 686         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 687         parameter, change BLOCK_INDEX type to gdb::optional.
 688         <m_want_specific_block>: Remove.
 689         <m_block_index>: Change type to gdb::optional.
 690         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 691         gdb::optional.  Re-write in function of gdb::optional.
 692         (dw2_debug_names_lookup_symbol): Don't pass argument for
 693         WANT_SPECIFIC_BLOCK.
 694         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 695         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 696         BLOCK_INDEX.
 697
 698 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 699
 700         * NEWS: Mention changes to "info sources" command.
 701
 702 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 703
 704         * symtab.c (filename_partial_match_opts): New struct type.
 705         (struct output_source_filename_data): New members
 706         regexp, c_regexp, partial_match.
 707         (output_source_filename): Use new members to decide to print file.
 708         (info_sources_option_defs): New variable.
 709         (make_info_sources_options_def_group, print_info_sources_header,
 710         info_sources_command_completer):
 711         New functions.
 712         (info_sources_command): Read new optional arguments.
 713         (_initialize_symtab): Update info sources help.
 714
 715 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 716
 717         * ada-lang.c (exception_support_info_v0): Renamed from...
 718         (default_exception_support_info): ... this.  Create new
 719         definition for v1.
 720         (ada_has_this_exception_support): Look up catch_handlers_sym.
 721         (ada_exception_support_info_sniffer): Try v0 after default.
 722
 723 2019-08-01  Tom Tromey  <tromey@adacore.com>
 724
 725         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 726         gdbarch.h.
 727
 728 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 729
 730         * s12z-tdep.c: Fix include path for s12z-opc.h.
 731
 732 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 733
 734         * NEWS: Require GNU make 3.82.
 735
 736 2019-07-16  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 739         declare.
 740
 741 2019-07-30  Tom Tromey  <tromey@adacore.com>
 742
 743         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 744
 745 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 746
 747         * printcmd.c (print_address_symbolic): Print negative offsets.
 748         (build_address_symbolic): Force signed arithmetic when computing
 749         offset.
 750
 751 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 752
 753         PR/24474: Add a function to lookup static variables.
 754         * NEWS: Mention this new function.
 755         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 756         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 757         * python/python.c (python_GdbMethods): Add new function.
 758
 759 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 760
 761         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 762         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 763         (objfpy_lookup_static_symbol): New function.
 764         (objfile_object_methods): Add new functions.
 765
 766 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 767
 768         * NEWS: Mention 'set|show print frame-info'.  Mention new
 769         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 770         backtrace argument.  Mention that python frame filtering code
 771         is now consistent with what 'backtrace' command prints.
 772
 773 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 774
 775         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 776         comments.
 777         (print_frame_info_auto, print_frame_info_source_line,
 778         print_frame_info_location, print_frame_info_source_and_location,
 779         print_frame_info_location_and_address, print_frame_info_short_location):
 780         New declarations.
 781         (struct frame_print_options): New member print_frame_info.
 782         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 783         * stack.h (get_user_print_what_frame_info): New declaration.
 784         (frame_show_address): New declaration.
 785         * stack.c (print_frame_arguments_choices): New value 'presence'.
 786         (print_frame_info_auto, print_frame_info_source_line,
 787         print_frame_info_location, print_frame_info_source_and_location,
 788         print_frame_info_location_and_address, print_frame_info_short_location,
 789         print_frame_info_choices, print_frame_info_print_what): New definitions.
 790         (print_frame_args): Only print dots for args if print frame-arguments
 791         is 'presence'.
 792         (frame_print_option_defs): New element for "frame-info".
 793         (get_user_print_what_frame_info): New function.
 794         (frame_show_address): Make non static.  Move comment to stack.h.
 795         (print_frame_info_to_print_what): New function.
 796         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 797         to decide what to print.
 798         (backtrace_command_1): Handle the new print_frame_arguments_presence
 799         value.
 800         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 801         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 802         (py_print_frame): In non-mi mode, use LOCATION as default for
 803         print_what, similarly to frame information printed directly by
 804         backtrace command. Handle frame-info user option in non MI mode.
 805
 806 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 807
 808         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 809         Add case for debugging 32-bit target on 64-bit host.  Revise
 810         comment.
 811
 812 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 813
 814         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 815         instead of find_function_entry_range_from_pc.
 816
 817 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 818
 819         * stack.c (find_frame_funname): Remove code which preferred
 820         minsym over symtab sym in "certain pathological cases".
 821
 822         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 823         parameter.  Change type of "do_demangle" to bool.
 824         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 825         Pass suitable "prefer_sym_over_minsym" flag to
 826         build_address_symbolic().  Don't output "+" for negative offsets.
 827         * printcmd.c (print_address_symbolic): Update invocation of
 828         build_address_symbolic to include a "prefer_sym_over_minsym"
 829         flag.
 830         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 831         Restrict cases in which use of minimal symbol is preferred to that
 832         of a found symbol.  Update comments.
 833
 834         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 835         for entry pc when entry pc is out of range for that FDE.
 836
 837 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 838
 839         PR gdb/24839:
 840         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 841         type.
 842
 843 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 844
 845         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 846         this function's Python signature.
 847
 848
 849 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 850
 851         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 852         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 853         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 854         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 855         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 856
 857
 858 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 859
 860         * h8300-tdep.c (h8300_register_name_common): New.
 861         h8300_register_name): Use h8300_register_name_common.
 862         (h8300s_register_name): Likewise.
 863         (h8300sx_register_name): Likewise.
 864         (h8300h_register_nam): New.
 865         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 866
 867
 868 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 869
 870         * arm-tdep.c (arm_skip_cmse_entry): New function.
 871         (arm_is_sgstubs_section): New function.
 872         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 873
 874 2019-07-22  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 877         Don't self-assign.
 878
 879 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 882         type_print.
 883
 884 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 885
 886         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 887         so that GDB doesn't match any msymbols when searching in the
 888         TYPES_DOMAIN.
 889         (print_symbol_info): Print using typedef_print or type_print based
 890         on the type of the symbol.  Add updated FIXME comment moved from...
 891         (_initialize_symtab): ... move and update FIXME comment to above.
 892
 893 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * NEWS: Mention adding -q option to "info types".
 896         * symtab.c (struct info_types_options): New struct.
 897         (info_types_options_defs): New variable.
 898         (make_info_types_options_def_group): New function.
 899         (info_types_command): Use gdb::option framework to parse options.
 900         (info_types_command_completer): New function.
 901         (_initialize_symtab): Extend the help text on "info types" and
 902         register command completer.
 903
 904 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 905
 906         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 907         (lookup_symbol_in_objfile): Change int to block_enum and add a
 908         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 909
 910 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 911
 912         * MAINTAINERS (Write After Approval): Add self.
 913
 914 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 915
 916         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 917         instruction to the dummy code region.
 918
 919 2019-07-19  Tom Tromey  <tromey@adacore.com>
 920
 921         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 922         (ARGSUSED, PARAMS, __func__): Remove rules.
 923
 924 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 925
 926         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 927         * features/arm/arm-with-iwmmxt.c: Remove.
 928         * features/arm/arm-with-iwmmxt.xml: Remove.
 929         * features/arm/arm-with-m-fpa-layout.c: Remove.
 930         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 931         * features/arm/arm-with-m-vfp-d16.c: Remove.
 932         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 933         * features/arm/arm-with-m.c: Remove.
 934         * features/arm/arm-with-m.xml: Remove.
 935         * features/arm/arm-with-neon.c: Remove.
 936         * features/arm/arm-with-neon.xml: Remove.
 937         * features/arm/arm-with-vfpv2.c: Remove.
 938         * features/arm/arm-with-vfpv2.xml: Remove.
 939         * features/arm/arm-with-vfpv3.c: Remove.
 940         * features/arm/arm-with-vfpv3.xml: Remove.
 941
 942 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 943
 944         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 945
 946 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 947
 948         * arch/aarch32.c (aarch32_create_target_description): Create
 949         target descriptions using features.
 950         * arch/arm.c (arm_create_target_description)
 951         (arm_create_mprofile_target_description): Likewise.
 952         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 953
 954 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 955
 956         * Makefile.in: Add new files.
 957         * aarch32-tdep.c: New file.
 958         * aarch32-tdep.h: New file.
 959         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 960         Call aarch32_read_description.
 961         * arch/aarch32.c: New file.
 962         * arch/aarch32.h: New file.
 963         * arch/arm.c (arm_create_target_description)
 964         (arm_create_mprofile_target_description): New function.
 965         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 966         (arm_create_target_description)
 967         (arm_create_mprofile_target_description): New declaration.
 968         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 969         read_description functions.
 970         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 971         Likewise.
 972         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 973         * arm-tdep.c (tdesc_arm_list): New variable.
 974         (arm_register_g_packet_guesses): Call create description functions.
 975         (arm_read_description) (arm_read_mprofile_description): New
 976         function.
 977         * arm-tdep.h (arm_read_description)
 978         (arm_read_mprofile_description): Add declaration.
 979         * configure.tgt: Add new files.
 980
 981 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 982
 983         * top.c (new_ui_command): Open specified terminal just once.
 984
 985 2019-07-18  Tom Tromey  <tromey@adacore.com>
 986
 987         * symtab.c (main_name): Constify return type.
 988         * symfile.c (set_initial_language): Update.
 989         * symtab.h (main_name): Constify return type.
 990
 991 2019-07-17  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-winsource.c (tui_update_source_window)
 994         (tui_update_source_window_as_is)
 995         (tui_update_source_windows_with_line): Remove return.
 996         * tui/tui-disasm.c (tui_show_disassem)
 997         (tui_show_disassem_and_update_source): Remove return.
 998         * tui/tui.c (tui_reset): Remove return.
 999         * tui/tui-wingeneral.c
1000         (tui_check_and_display_highlight_if_needed): Remove return.
1001
1002 2019-07-17  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1005
1006 2019-07-17  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-winsource.h (struct tui_exec_info_window)
1009         (struct tui_source_window_base): Move from tui-data.h.
1010         * tui/tui-winsource.c: Move many method definitions from
1011         elsewhere.  Remove "structuring" comments.
1012         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1013         (tui_source_window_base::refresh_window): Move to
1014         tui-winsource.c.
1015         * tui/tui-win.c (tui_source_window_base::refresh_all)
1016         (tui_source_window_base::update_tab_width)
1017         (tui_source_window_base::set_new_height)
1018         (tui_source_window_base::do_make_visible_with_new_height): Move to
1019         tui-winsource.c.
1020         * tui/tui-source.h: Update.
1021         * tui/tui-source.c (tui_source_window_base::reset): Move to
1022         tui-winsource.c.
1023         * tui/tui-disasm.h: Update.
1024         * tui/tui-data.h (struct tui_exec_info_window): Move to
1025         tui-winsource.h.
1026         (struct tui_source_window_base): Likewise.
1027         * tui/tui-data.c (tui_source_window_base::clear_detail)
1028         (tui_source_window_base, ~tui_source_window_base): Move to
1029         tui-winsource.c.
1030
1031 2019-07-17  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-win.c (tui_resize_all)
1034         (tui_source_window_base::update_tab_width)
1035         (tui_adjust_win_heights): Update.
1036         (tui_win_info::make_invisible_and_set_new_height): Rename from
1037         make_invisible_and_set_new_height.
1038         * tui/tui-data.h (struct tui_win_info)
1039         <make_invisible_and_set_new_height>: New method.
1040
1041 2019-07-17  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui.c: Update.
1044         * tui/tui-source.h (struct tui_source_window): Move from
1045         tui-data.h.
1046         * tui/tui-layout.c: Update.
1047         * tui/tui-disasm.c: Update.
1048         * tui/tui-data.h (struct tui_source_window): Move to
1049         tui-source.h.
1050
1051 2019-07-17  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1054         tui-data.h.
1055         * tui/tui-data.h (struct tui_disasm_window): Move to
1056         tui-disasm.h.
1057
1058 2019-07-17  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-regs.h (struct tui_data_item_window): Move from
1061         tui-data.h.
1062         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1063         * tui/tui-data.h (struct tui_data_item_window): Move to
1064         tui-regs.h.
1065         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1066
1067 2019-07-17  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui.c: Update.
1070         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1071         (tui_cmd_window::max_height): Move to tui-command.c.
1072         * tui/tui-layout.c: Update.
1073         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1074         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1075         tui-command.c.
1076         * tui/tui-command.h (struct tui_cmd_window): Move from
1077         tui-data.h.
1078         * tui/tui-command.c: Remove "structuring" comments.
1079         (tui_cmd_window::clear_detail)
1080         (tui_cmd_window::do_make_visible_with_new_height)
1081         (tui_cmd_window::max_height): Move from elsewhere.
1082
1083 2019-07-17  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1086         Now static.
1087         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1088         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1089
1090 2019-07-17  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui.c: Update.
1093         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1094         tui-regs.c.
1095         * tui/tui-windata.h: Remove file.
1096         * tui/tui-windata.c: Remove file.
1097         * tui/tui-win.c (tui_data_window::set_new_height)
1098         (tui_data_window::do_make_visible_with_new_height): Move to
1099         tui-regs.c.
1100         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1101         * tui/tui-regs.c: Remove "structuring" comments.
1102         (tui_data_window::first_data_item_displayed)
1103         (tui_data_window::delete_data_content_windows)
1104         (tui_data_window::erase_data_content)
1105         (tui_data_window::display_all_data)
1106         (tui_data_window::refresh_all)
1107         (tui_data_window::do_scroll_vertical)
1108         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1109         (tui_data_window::do_make_visible_with_new_height)
1110         (tui_data_window::refresh_window): Move from elsewhere.
1111         (_initialize_tui_regs): Move to end of file.
1112         * tui/tui-layout.c: Update.
1113         * tui/tui-hooks.c: Update.
1114         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1115         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1116         tui-regs.c.
1117         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1118
1119 2019-07-17  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1122         seen.
1123
1124 2019-07-17  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-win.c (tui_source_window_base::set_new_height)
1127         (tui_source_window_base::do_make_visible_with_new_height): Use
1128         m_has_locator field directly.
1129         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1130         method.
1131         (struct tui_source_window_base) <has_locator>: Likewise.
1132
1133 2019-07-17  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1136         Don't declare.
1137         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1138         Remove.
1139         * tui/tui-win.c (tui_source_window_base::set_new_height)
1140         (tui_source_window_base::set_new_height)
1141         (make_invisible_and_set_new_height)
1142         (tui_source_window_base::do_make_visible_with_new_height)
1143         (tui_source_window_base::do_make_visible_with_new_height):
1144         Update.
1145         * tui/tui-layout.c (show_source_disasm_command, show_data)
1146         (show_source_or_disasm_and_command): Update.
1147         * tui/tui-layout.c (show_layout): Update.
1148
1149 2019-07-17  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-layout.c (make_data_window): Remove.
1152         (show_data): Unify creation and re-initialization cases.
1153
1154 2019-07-17  Tom Tromey  <tom@tromey.com>
1155
1156         * tui/tui-layout.c (make_source_window, make_disasm_window):
1157         Remove.
1158         (show_data): Unify creation and re-initialization cases.
1159
1160 2019-07-17  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui-layout.c (make_command_window): Remove.
1163         (show_source_disasm_command, show_source_or_disasm_and_command):
1164         Unify creation and re-initialization cases.
1165
1166 2019-07-17  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1169         creation and re-initialization cases.
1170
1171 2019-07-17  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-regs.c (tui_get_register): Return void.
1174
1175 2019-07-17  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1178         Simplify.
1179
1180 2019-07-17  Tom Tromey  <tom@tromey.com>
1181
1182         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1183         resetting.
1184
1185 2019-07-17  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1188         * tui/tui-regs.c (tui_reg_layout): New function.
1189         (tui_show_registers, tui_reg_command): Use it.
1190         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1191         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1192         parameters.
1193         (tui_layout_command): Remove.
1194
1195 2019-07-17  Tom Tromey  <tom@tromey.com>
1196
1197         * tui/tui-layout.h (tui/tui-layout): Return void.
1198         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1199
1200 2019-07-17  Tom Tromey  <tom@tromey.com>
1201
1202         * tui/tui-layout.c (show_source_disasm_command, show_data):
1203         Update.
1204         (reset_locator): Remove.
1205         (show_source_or_disasm_and_command): Update.
1206
1207 2019-07-17  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-source.c (tui_source_window_base::reset): Remove
1210         win_type parameter.
1211         * tui/tui-layout.c (make_command_window, make_source_window)
1212         (make_disasm_window, make_data_window)
1213         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1214         (reset_locator, show_source_or_disasm_and_command): Update.
1215         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1216         win_type parameter.
1217         (struct tui_source_window_base) <reset>: Likewise.
1218
1219 2019-07-17  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-layout.c (show_source_disasm_command): Use
1222         reset_locator.
1223         (reset_locator): New function.
1224         (init_and_make_win): Remove.
1225         (show_source_or_disasm_and_command): Use reset_locator.
1226
1227 2019-07-17  Tom Tromey  <tom@tromey.com>
1228
1229         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1230         condition.
1231         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1232         Remove condition.
1233         * tui/tui-source.c (tui_source_window_base::reset): New method.
1234         * tui/tui-layout.c (make_command_window): Don't call
1235         init_and_make_win.
1236         (make_source_window, make_disasm_window): Don't call
1237         make_source_or_disasm_window.
1238         (make_data_window): Don't call init_and_make_win.  Change calling
1239         convention.
1240         (show_source_disasm_command, show_data): Simplify.
1241         (make_source_or_disasm_window): Remove.
1242         (show_source_or_disasm_and_command): Simplify.
1243         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1244         (struct tui_source_window_base) <reset>: Likewise.
1245         <execution_info>: Remove initializer.
1246         * tui/tui-data.c (tui_source_window_base): Initialize
1247         execution_info.
1248
1249 2019-07-17  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1252         variable.
1253
1254 2019-07-17  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui.c (tui_rl_other_window): Update.
1257         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1258         superclass method first.  Always iterate over regs_content.
1259         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1260         method.
1261         * tui/tui-win.c (tui_set_focus_command): Update.
1262
1263 2019-07-17  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-win.c (tui_set_focus_command): Rename from
1266         tui_set_focus.  Call tui_enable.
1267         (tui_set_focus_command): Remove.
1268
1269 2019-07-17  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1272         refresh_window.
1273         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1274         touchwin.
1275         (tui_data_window::refresh_window): Call refresh_window on data
1276         items.  Always call superclass refresh_window.
1277         (tui_win_info::refresh): Remove.
1278         (tui_source_window_base::refresh_window): Update.
1279         (tui_refresh_all): Update.
1280         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1281         refresh_window.
1282         (show_source_or_disasm_and_command): Likewise.
1283         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1284         (struct tui_source_window_base) <refresh>: Likewise.
1285
1286 2019-07-17  Tom Tromey  <tom@tromey.com>
1287
1288         * tui/tui-winsource.c (tui_clear_source_content)
1289         (tui_show_source_content): Update.
1290         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1291         whether content is empty.
1292         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1293         Remove.
1294
1295 2019-07-17  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1298         window's contents.
1299         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1300         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1301
1302 2019-07-17  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1305         (struct tui_data_item_window): Update.
1306
1307 2019-07-17  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1310         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1311         defines.
1312
1313 2019-07-17  Tom Tromey  <tom@tromey.com>
1314
1315         * tui/tui-winsource.h (tui_erase_source_content)
1316         (tui_clear_source_content): Remove "display_prompt" parameter.
1317         * tui/tui-winsource.c (tui_update_source_window_as_is)
1318         (tui_update_source_windows_with_addr): Update.
1319         (tui_clear_source_content): Remove "display_prompt" parameter.
1320         (tui_erase_source_content): Likewise.  Simplify.
1321         (tui_show_source_content): Update.
1322         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1323         * tui/tui-stack.c (tui_show_frame_info): Update.
1324         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1325         Remove defines.
1326
1327 2019-07-17  Tom Tromey  <tom@tromey.com>
1328
1329         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1330         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1331         parameter.
1332         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1333         parameter.
1334
1335 2019-07-17  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-winsource.c (tui_clear_source_content)
1338         (tui_show_source_content, tui_show_exec_info_content)
1339         (tui_clear_exec_info_content): Update.
1340         * tui/tui-stack.c (tui_show_locator_content): Update.
1341         (tui_show_frame_info): Update.
1342         * tui/tui-source.h (tui_source_window): Don't declare.
1343         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1344         from tui_source_is_displayed.
1345         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1346         Remove field.
1347         (struct tui_source_window_base) <content_in_use>: New field.  Now
1348         bool.
1349         (struct tui_source_window) <showing_source_p>: New method.
1350         (TUI_SRC_WIN): Change cast.
1351         * tui/tui-data.c (tui_initialize_static_data): Update.
1352
1353 2019-07-17  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1356         location_matches_p.
1357         * tui/tui-source.c (tui_source_window::location_matches_p): New
1358         method.
1359         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1360         method.
1361         * tui/tui-data.h (struct tui_source_window_base)
1362         <location_matches_p>: New method.
1363         (struct tui_source_window, struct tui_disasm_window)
1364         <location_matches_p>: Likewise.
1365
1366 2019-07-17  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-win.c (tui_set_win_height_command): Rename from
1369         tui_set_win_height.
1370         (tui_set_win_height_command): Remove.
1371
1372 2019-07-17  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui-source.c (tui_source_window): New constructor.  Add
1375         observer.
1376         (~tui_source_window): New destructor.
1377         (tui_source_window::style_changed): New method.
1378         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1379         (tui_attach_detach_observers): Update.
1380         * tui/tui-data.h (struct tui_source_window): Make constructor not
1381         inline.  Add destructor.
1382         (struct tui_source_window) <style_changed>: New method.
1383         <m_observable>: New member.
1384
1385 2019-07-17  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1388         * tui/tui-win.c (tui_resize_all): Fix typo.
1389
1390 2019-07-17  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1393         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1394         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1395         * tui/tui-win.c (window_name_completer): Use foreach.
1396         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1397         (update_tab_width): Likewise.
1398         * tui/tui-layout.c (show_layout): Update.
1399         * tui/tui-data.h (class tui_window_iterator): New.
1400         (struct all_tui_windows): New.
1401         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1402
1403 2019-07-17  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1406         parameter.  Don't reference globals.
1407         (tui_reg_command): Update.
1408
1409 2019-07-17  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-regs.c (tui_show_registers): Simplify.
1412
1413 2019-07-17  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-regs.c (tui_show_registers): Update.
1416         (tui_show_register_group): Add win_info parameter.
1417
1418 2019-07-17  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1421         Rename from tui_display_reg_element_at_line.
1422         (tui_data_window::display_registers_from_line): Update.
1423         * tui/tui-data.h (struct tui_data_window)
1424         <display_reg_element_at_line>: New method.
1425
1426 2019-07-17  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-regs.h (tui_display_registers_from)
1429         (tui_display_registers_from_line): Don't declare.
1430         * tui/tui-windata.c (tui_data_window::display_all_data)
1431         (tui_data_window::refresh_all)
1432         (tui_data_window::do_scroll_vertical): Update.
1433         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1434         from tui_display_registers_from.
1435         (tui_display_reg_element_at_line): Update.
1436         (tui_data_window::display_registers_from_line): Rename from
1437         tui_display_registers_from_line.
1438         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1439         display_registers_from_line>: New methods.
1440
1441 2019-07-17  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1444         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1445         from tui_erase_data_content.
1446         (tui_data_window::display_all_data)
1447         (tui_data_window::refresh_all)
1448         (tui_data_window::do_scroll_vertical): Update.
1449         * tui/tui-regs.c (tui_show_registers): Update.
1450         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1451         New method.
1452
1453 2019-07-17  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1456         declare.
1457         * tui/tui-windata.c
1458         (tui_data_window::delete_data_content_windows): Rename from
1459         tui_delete_data_content_windows.
1460         (tui_data_window::display_all_data)
1461         (tui_data_window::do_scroll_vertical): Update.
1462         * tui/tui-data.h (struct tui_data_window)
1463         <delete_data_content_windows>: New method.
1464
1465 2019-07-17  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1468         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1469
1470 2019-07-17  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1473         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1474         from tui_display_all_data.
1475         * tui/tui-win.c
1476         (tui_data_window::do_make_visible_with_new_height): Update.
1477         * tui/tui-regs.c (tui_show_registers): Update.
1478         * tui/tui-layout.c (tui_set_layout): Update.
1479         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1480         method.
1481
1482 2019-07-17  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1485         * tui/tui-windata.c (tui_display_data_from): Remove.
1486         (tui_data_window::refresh_all): Update.
1487
1488 2019-07-17  Tom Tromey  <tom@tromey.com>
1489
1490         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1491         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1492         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1493         tui_display_registers_from_line.
1494         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1495         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1496         "force_display" parameter.
1497
1498 2019-07-17  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1501         declare.
1502         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1503         Rename from tui_first_reg_element_no_inline.
1504         (tui_display_reg_element_at_line)
1505         (tui_display_registers_from_line): Update.
1506         * tui/tui-data.h (struct tui_data_window)
1507         <first_reg_element_no_inline>: New method.
1508
1509 2019-07-17  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-windata.c (tui_display_data_from)
1512         (tui_data_window::do_scroll_vertical): Update.
1513         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1514         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1515         Rename from tui_line_from_reg_element_no.
1516         (tui_display_registers_from_line): Update.
1517         * tui/tui-data.h (struct tui_data_window)
1518         <line_from_reg_element_no>: New method.
1519
1520 2019-07-17  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1523         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1524         tui_last_regs_line_no.
1525         (tui_display_reg_element_at_line)
1526         (tui_display_registers_from_line): Update.
1527         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1528         method.
1529
1530 2019-07-17  Tom Tromey  <tom@tromey.com>
1531
1532         PR tui/24722:
1533         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1534         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1535         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1536         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1537         (tui_update_breakpoint_info): Likewise.
1538         * tui/tui-hooks.c (tui_event_create_breakpoint)
1539         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1540         Update.
1541
1542 2019-07-17  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1545
1546 2019-07-17  Tom Tromey  <tom@tromey.com>
1547
1548         * tui/tui-winsource.c (tui_update_source_window_as_is)
1549         (tui_update_source_windows_with_addr): Update.
1550         * tui/tui-source.h (tui_set_source_content)
1551         (tui_show_symtab_source): Add "win_info" parameter.
1552         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1553         parameter.
1554         (tui_show_symtab_source): Likewise.
1555
1556 2019-07-17  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-wingeneral.c
1559         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1560
1561 2019-07-17  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1564         (struct tui_cmd_window) <can_scroll>: New method.
1565         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1566         method.
1567
1568 2019-07-17  Tom Tromey  <tromey@adacore.com>
1569
1570         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1571         do_field_signed>: Rename.  Change type of "value".
1572         * ui-out.c (ui_out::field_signed): Rename from field_int.
1573         Change type of "value".
1574         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1575         type of "value".
1576         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1577         do_field_int.  Change type of "value".
1578         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1579         do_field_int.  Change type of "value".
1580         * tracepoint.c (trace_status_mi, tfind_1)
1581         (print_one_static_tracepoint_marker): Update.
1582         * thread.c (print_thread_info_1, print_selected_thread_frame):
1583         Update.
1584         * stack.c (print_frame, print_frame_info): Update.
1585         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1586         Update.
1587         * source.c (print_source_lines_base): Update.
1588         * skip.c (info_skip_command): Update.
1589         * record-btrace.c (btrace_ui_out_decode_error)
1590         (btrace_call_history_src_line): Update.
1591         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1592         Update.
1593         * progspace.c (print_program_space): Update.
1594         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1595         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1596         do_field_int.  Change type of "value".
1597         * mi/mi-out.c (mi_ui_out::do_table_begin)
1598         (mi_ui_out::do_table_header): Update.
1599         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1600         type of "value".
1601         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1602         (mi_cmd_data_list_changed_registers, output_register)
1603         (mi_cmd_data_read_memory, mi_load_progress)
1604         (mi_cmd_trace_frame_collected): Update.
1605         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1606         Update.
1607         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1608         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1609         (mi_cmd_var_list_children, varobj_update_one): Update.
1610         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1611         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1612         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1613         * inferior.c (print_inferior): Update.
1614         * gdb_bfd.c (print_one_bfd): Update.
1615         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1616         Update.
1617         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1618         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1619         do_field_int.  Change type of "value".
1620         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1621         do_field_int.  Change type of "value".
1622         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1623         (print_one_breakpoint_location, print_it_catch_fork)
1624         (print_one_catch_fork, print_it_catch_vfork)
1625         (print_one_catch_vfork, print_it_catch_solib)
1626         (print_it_catch_exec, print_it_ranged_breakpoint)
1627         (print_mention_watchpoint, print_mention_masked_watchpoint)
1628         (bkpt_print_it, update_static_tracepoint): Update.
1629         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1630         * break-catch-syscall.c (print_it_catch_syscall): Update.
1631         * ada-tasks.c (print_ada_task_info): Update.
1632         * ada-lang.c (print_it_exception, print_mention_exception):
1633         Update.
1634
1635 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         PR breakpoints/24541
1638         * gdbarch.c: Regenerate.
1639         * gdbarch.h: Regenerate.
1640         * gdbarch.sh: Adjust return type and parameter types for
1641         'stap_adjust_register'.
1642         (i386_stap_adjust_register): Adjust signature and return new
1643         register name.
1644         * stap-probe.c (stap_parse_register_operand): Adjust use of
1645         'gdbarch_stap_adjust_register'.
1646
1647 2019-07-17  Tom Tromey  <tromey@adacore.com>
1648
1649         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1650         declare VEC.
1651         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1652         std::vector.
1653         (struct s390_process_info): Add initializers.
1654         (s390_add_process): Use new.
1655         (s390_linux_nat_target::low_forget_process): Use delete.
1656         (s390_linux_nat_target::low_new_fork)
1657         (s390_linux_nat_target::stopped_by_watchpoint)
1658         (s390_linux_nat_target::low_prepare_to_resume)
1659         (s390_linux_nat_target::insert_watchpoint)
1660         (s390_linux_nat_target::insert_hw_breakpoint)
1661         (s390_linux_nat_target::remove_watchpoint)
1662         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1663
1664 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1665
1666         * aarch64-fbsd-nat.c: Include regcache.h.
1667         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1668         argument.
1669         (aarch64_fbsd_nat_target::fetch_registers)
1670         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1671         variable.
1672         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1673
1674 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1675
1676         * fbsd-nat.c: Include gdbarch.h.
1677
1678 2019-07-15  Tom Tromey  <tromey@adacore.com>
1679
1680         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1681
1682 2019-07-15  Tom Tromey  <tromey@adacore.com>
1683
1684         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1685         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1686         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1687         * cli-out.c (cli_ui_out::do_field_int): New method.
1688         * ui-out.c (ui_out::field_unsigned): New method.
1689         * symfile.c (generic_load): Use field_unsigned.
1690         (print_transfer_performance): Likewise.
1691         * record-btrace.c (ui_out_field_uint): Remove.
1692         (btrace_call_history_insn_range, btrace_call_history): Use
1693         field_unsigned.
1694         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1695         field_unsigned.
1696         * ui-out.h (class ui_out) <field_unsigned>: New method.
1697         <do_field_unsigned>: Likewise.
1698
1699 2019-07-15  Tom Tromey  <tromey@adacore.com>
1700
1701         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1702         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1703         * target.c (flash_erase_command): Use field_string.
1704         * infrun.c (print_signal_received_reason): Use field_string.
1705         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1706         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1707         field_string.
1708         * ada-tasks.c (print_ada_task_info): Use field_string.
1709
1710 2019-07-15  Tom Tromey  <tromey@adacore.com>
1711
1712         * target.c (flash_erase_command): Use field_core_addr.
1713         * symfile.c (generic_load): Use field_core_addr.
1714         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1715         Use field_core_addr.
1716         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1717         field_core_addr.
1718
1719 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1720
1721         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1722         value if its desired type is smaller than a CORE_ADDR and signed.
1723
1724 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1725
1726         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1727         of changes to field names, and use new is_reference field to
1728         decide if a property is a reference or not.
1729         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1730         field.
1731         (struct dwarf2_property_baton): Update header comment, rename
1732         'referenced_type' to 'property_type' and update comments.
1733         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1734         default property type, store in property baton, update to take
1735         accound of renamed field.
1736         (read_func_scope): Update call to attr_to_dynamic_prop.
1737         (read_array_type): Likewise.
1738         (dwarf2_per_cu_addr_sized_int_type): New function.
1739         (read_subrange_index_type): Move type finding code to
1740         dwarf2_per_cu_addr_sized_int_type.
1741         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1742         (dwarf2_per_cu_addr_type): New function.
1743         (set_die_type): Update calls to attr_to_dynamic_prop.
1744
1745 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1746
1747         * dwarf2read.c (read_subrange_index_type): New function.
1748         (read_subrange_type): Move code into new function and call it.
1749         * gdbtypes.c (create_range_type): Add some asserts.
1750
1751 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1752
1753         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1754         update return statements.
1755         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1756         declaration, and update comment to match.
1757         * gdbtypes.c (resolve_dynamic_array): Update call to
1758         dwarf2_evaluate_property to match new return type.
1759
1760 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1761
1762         * valarith.c (value_subscripted_rvalue): Change lowerbound
1763         parameter type from int to LONGEST.
1764         * value.h (value_subscripted_rvalue): Likewise in declaration.
1765
1766 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1767
1768         * cli/cli-utils.c (info_print_command_completer): New function.
1769         * cli/cli-utils.h: Add 'completer.h' include, and forward
1770         declaration for 'struct cmd_list_element'.
1771         (info_print_command_completer): Declare.
1772         * stack.c (_initialize_stack): Add completer for 'info locals' and
1773         'info args'.
1774         * symtab.c (_initialize_symtab): Add completer for 'info
1775         variables' and 'info functions'.
1776         * NEWS: Mention completion for additional info commands.
1777
1778 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1779
1780         * cli/cli-utils.c (extract_info_print_args): Delete.
1781         (extract_arg_maybe_quoted): Delete.
1782         (info_print_options_defs): New variable.
1783         (make_info_print_options_def_group): New function.
1784         (extract_info_print_options): Define new function.
1785         * cli/cli-utils.h (extract_info_print_args): Delete.
1786         (struct info_print_options): New structure.
1787         (extract_info_print_options): Declare new function.
1788         * stack.c (info_locals_command): Update to use new
1789         extract_info_print_options, also add a header comment.
1790         (info_args_command): Likewise.
1791         * symtab.c (info_variables_command): Likewise.
1792         (info_functions_command): Likewise.
1793
1794 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1795
1796         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1797         to extract string arguments.
1798         * common/common-utils.c (extract_string_maybe_quoted): New function.
1799         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1800
1801 2019-07-11  Tom Tromey  <tromey@adacore.com>
1802
1803         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1804         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1805         * top.h (gdbinit): Don't declare.
1806         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1807         into...
1808         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1809         * top.c (gdb_init): Don't call init_cli_cmds.
1810         (gdbinit): Remove.
1811         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1812
1813 2019-07-11  Tom Tromey  <tromey@adacore.com>
1814
1815         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1816         after it has been moved.
1817
1818 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1819
1820         * valops.c (value_must_coerce_to_target): Change return type to
1821         bool.
1822         * value.h (value_must_coerce_to_target): Likewise.
1823
1824 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1825
1826         * breakpoint.c (is_hardware_watchpoint): Remove
1827         forward-declaration.
1828         (is_masked_watchpoint): Change return type to bool.
1829         (is_tracepoint): Likewise.
1830         (is_breakpoint): Likewise.
1831         (is_hardware_watchpoint): Likewise.
1832         (is_watchpoint): Likewise.
1833         (is_no_memory_software_watchpoint): Likewise.
1834         (is_catchpoint): Likewise.
1835         (breakpoint_1): Make FILTER parameter's return type bool.
1836         is_masked_watchpoint): Change return type to bool.
1837         (save_breakpoints): Make FILTER parameter's return type bool.
1838         * breakpoint.h (is_breakpoint): Change return type to bool.
1839         (is_watchpoint): Likewise.
1840         (is_catchpoint): Likewise.
1841         (is_tracepoint): Likewise.
1842
1843 2019-07-10  Tom Tromey  <tom@tromey.com>
1844
1845         * defs.h: Don't include gdbarch.h.
1846         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1847         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1848         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1849         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1850         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1851         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1852         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1853         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1854         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1855         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1856         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1857         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1858         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1859         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1860         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1861         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1862         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1863         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1864         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1865         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1866         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1867         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1868         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1869         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1870         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1871         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1872         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1873
1874 2019-07-10  Tom Tromey  <tromey@adacore.com>
1875
1876         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1877         * breakpoint.c (init_ada_exception_breakpoint): Register as
1878         bp_catchpoint.
1879         (print_one_breakpoint_location, print_one_breakpoint): Use
1880         is_ada_exception_catchpoint.
1881         * ada-lang.c (class ada_catchpoint_location): Pass
1882         bp_loc_software_breakpoint to bp_location constructor.
1883         (is_ada_exception_catchpoint): New function.
1884
1885 2019-07-10  Tom Tromey  <tromey@adacore.com>
1886
1887         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1888         VEC.
1889         (struct arm_exidx_entry): New method operator<.
1890         (struct arm_exidx_data) <section_maps>: Change type.
1891         (arm_exidx_data_free): Remove.
1892         (arm_exidx_data_key): Change type.  Move lower.
1893         (arm_exidx_new_objfile): Update.
1894         (arm_compare_exidx_entries): Remove.
1895         (arm_find_exidx_entry, _initialize_arm_tdep)
1896
1897 2019-07-10  Tom Tromey  <tromey@adacore.com>
1898
1899         * solib-spu.c (ocl_program_data_key): Change type.
1900         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1901         Update.
1902
1903 2019-07-10  Tom Tromey  <tromey@adacore.com>
1904
1905         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1906         (struct solib_aix_inferior_data) <library_list>: Change type.
1907         (solib_aix_inferior_data_handle): Change type.
1908         (get_solib_aix_inferior_data): Update.
1909         (solib_aix_free_library_list): Remove.
1910         (library_list_start_library): Update.
1911         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1912         return type.
1913         (solib_aix_get_library_list)
1914         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1915         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1916
1917 2019-07-10  Tom Tromey  <tromey@adacore.com>
1918
1919         * solib-dsbt.c (struct dsbt_info): Add initializers.
1920         (solib_dsbt_pspace_data): Change type.
1921         (dsbt_pspace_data_cleanup): Remove.
1922         (get_dsbt_info, _initialize_dsbt_solib): Update.
1923
1924 2019-07-10  Tom Tromey  <tromey@adacore.com>
1925
1926         * spu-tdep.c (spu_overlay_data): Change type.
1927         (spu_get_overlay_table, spu_overlay_new_objfile)
1928         (_initialize_spu_tdep): Update.
1929
1930 2019-07-10  Tom Tromey  <tromey@adacore.com>
1931
1932         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1933         destructor.
1934         (dbx_objfile_data_key): Change type and declare later.
1935         (DBX_SYMFILE_INFO): Rewrite.
1936         * dbxread.c (dbx_objfile_data_key): Change type.
1937         (dbx_symfile_init): Update.
1938         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1939         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1940         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1941
1942 2019-07-10  Tom Tromey  <tromey@adacore.com>
1943
1944         * jit.c (jit_program_space_key): Change type.  Move lower.
1945         (get_jit_program_space_data): Update.
1946         (jit_program_space_data_cleanup): Remove.
1947         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1948         Update.
1949         (struct jit_program_space_data): Add initializers.
1950
1951 2019-07-10  Tom Tromey  <tromey@adacore.com>
1952
1953         * solib-darwin.c (struct darwin_info): Add initializers.
1954         (solib_darwin_pspace_data): Change type.
1955         (darwin_pspace_data_cleanup): Remove.
1956         (get_darwin_info, _initialize_darwin_solib): Update.
1957
1958 2019-07-10  Tom Tromey  <tromey@adacore.com>
1959
1960         * remote-sim.c (struct sim_inferior_data): Add initializers,
1961         constructor, and destructor.
1962         (sim_inferior_data_key): Change type.  Move lower.
1963         (check_for_duplicate_sim_descriptor): Update.
1964         (get_sim_inferior_data): Use new.  Update.
1965         (~sim_inferior_data_cleanup): Rename from
1966         sim_inferior_data_cleanup.  Simplify.
1967         (gdbsim_close_inferior, simulator_command)
1968         (sim_command_completer, _initialize_remote_sim): Update.
1969         (next_pid, INITIAL_PID): Move earlier.
1970
1971 2019-07-10  Tom Tromey  <tromey@adacore.com>
1972
1973         * python/python-internal.h (create_thread_object): Return
1974         gdbpy_ref.
1975         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1976         * python/py-inferior.c (struct threadlist_entry): Add
1977         constructor.
1978         <thread_obj>: Now a gdbpy_ref.
1979         (thread_to_thread_object): Update.
1980         (add_thread_object): Use new.
1981         (delete_thread_object): Use delete.
1982         (infpy_threads): Update.
1983         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1984         GIL.
1985
1986 2019-07-10  Tom Tromey  <tromey@adacore.com>
1987
1988         * valops.c (value_cast): Specialize error message for Ada.
1989
1990 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1991
1992         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1993
1994 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1995
1996         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1997         bpstat_should_step): Return bool, adjust comments.
1998         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1999         bpstat_should_step): Likewise.
2000
2001 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2002
2003         * features/Makefile: Use feature target descriptions for Arm.
2004         * features/arm/arm-core.c: Generate new file.
2005         * features/arm/arm-fpa.c: Likewise.
2006         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2007         * features/arm/arm-m-profile.c: Likewise.
2008         * features/arm/arm-vfpv2.c: Likewise.
2009         * features/arm/arm-vfpv3.c: Likewise.
2010         * features/arm/xscale-iwmmxt.c: Likewise.
2011         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2012
2013 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2014
2015         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2016         ptrace earlier.
2017
2018 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2019
2020         * features/aarch64-pauth.c: Regenerate.
2021
2022 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2023
2024         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2025         bool.
2026         (bpstat_what): Use false instead of 0.
2027
2028 2019-07-09  Pedro Alves  <palves@redhat.com>
2029
2030         * break-catch-throw.c (is_exception_catchpoint): New.
2031         * breakpoint.c (print_one_breakpoint_location): New parameter
2032         'raw_loc'.  Handle it.  Use
2033         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2034         looking at the breakpoint's type.
2035         (print_one_breakpoint): If handling "maint info breakpoints", also
2036         print locations of exception catchpoints.
2037         * breakpoint.h (is_exception_catchpoint): Declare.
2038
2039 2019-07-09  Pedro Alves  <palves@redhat.com>
2040
2041         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2042         "addr" field.
2043         (allocate_location_exception_catchpoint): New.
2044         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2045         (initialize_throw_catchpoint_ops): Install
2046         allocate_location_exception_catchpoint as allocate_location
2047         method.
2048         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2049         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2050         bp_loc_other.
2051         (breakpoint_address_is_meaningful): Delete.
2052         (bl_address_is_meaningful): New.
2053         (breakpoint_locations_match): Adjust comment.
2054         (bp_location_from_bp_type): New, factored out of...
2055         (bp_location::bp_location(breakpoint *)): ... this.
2056         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2057         factored out of...
2058         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2059         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2060         breakpoint_address_is_meaningful.
2061         (bp_locations_compare): Adjust comment.
2062         (update_global_location_list): Use bl_address_is_meaningful
2063         instead of breakpoint_address_is_meaningful.
2064         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2065         explicit.
2066         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2067         * python/py-breakpoint.c (bppy_get_location): No longer check
2068         whether location is null.
2069
2070 2019-07-09  Pedro Alves  <palves@redhat.com>
2071
2072         PR c++/15468
2073         * breakpoint.c (print_one_breakpoint_location): Remove
2074         single-location assert.
2075
2076 2019-07-09  Tom Tromey  <tom@tromey.com>
2077
2078         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2079         * configure: Rebuild.
2080         * configure.ac: Change common to gdbsupport.
2081         * gdbsupport: Rename from common.
2082         * acinclude.m4: Change common to gdbsupport.
2083         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2084         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2085         gdbsupport.
2086         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2087         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2088         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2089         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2090         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2091         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2092         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2093         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2094         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2095         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2096         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2097         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2098         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2099         coff-pe-read.c, command.h, compile/compile-c-support.c,
2100         compile/compile-c.h, compile/compile-cplus-symbols.c,
2101         compile/compile-cplus-types.c, compile/compile-cplus.h,
2102         compile/compile-loc2c.c, compile/compile.c, completer.c,
2103         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2104         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2105         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2106         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2107         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2108         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2109         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2110         features/aarch64-core.c, features/aarch64-fpu.c,
2111         features/aarch64-pauth.c, features/aarch64-sve.c,
2112         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2113         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2114         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2115         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2116         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2117         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2118         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2119         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2120         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2121         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2122         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2123         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2124         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2125         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2126         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2127         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2128         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2129         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2130         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2131         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2132         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2133         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2134         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2135         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2136         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2137         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2138         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2139         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2140         minsyms.c, mips-linux-tdep.c, namespace.h,
2141         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2142         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2143         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2144         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2145         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2146         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2147         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2148         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2149         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2150         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2151         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2152         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2153         procfs.c, producer.c, progspace.h, psymtab.h,
2154         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2155         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2156         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2157         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2158         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2159         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2160         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2161         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2162         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2163         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2164         target-memory.c, target.c, target.h, target/waitstatus.c,
2165         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2166         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2167         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2168         unittests/array-view-selftests.c,
2169         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2170         unittests/common-utils-selftests.c,
2171         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2172         unittests/format_pieces-selftests.c,
2173         unittests/function-view-selftests.c,
2174         unittests/lookup_name_info-selftests.c,
2175         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2176         unittests/mkdir-recursive-selftests.c,
2177         unittests/observable-selftests.c,
2178         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2179         unittests/parse-connection-spec-selftests.c,
2180         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2181         unittests/scoped_fd-selftests.c,
2182         unittests/scoped_mmap-selftests.c,
2183         unittests/scoped_restore-selftests.c,
2184         unittests/string_view-selftests.c, unittests/style-selftests.c,
2185         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2186         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2187         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2188         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2189         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2190         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2191
2192 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2193
2194         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2195         bool value.
2196         (decode_digits_ordinary): Set explicit_line field in sal.
2197         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2198         symtab_and_line that was set on an explicit line number in
2199         assembler code.  Do always update the recorded symtab and line if
2200         we do skip the prologue.
2201
2202 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * breakpoint.c (set_breakpoint_location_function): Remove
2205         explicit_loc parameter.
2206         (momentary_breakpoint_from_master): Update call to
2207         set_breakpoint_location_function.
2208         (add_location_to_breakpoint): Likewise.
2209
2210 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2211
2212         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2213         required features based on default bfd type when no specific bfd
2214         is present.
2215
2216 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2217
2218         * NEWS: Mention that GDB printf and eval commands can now print
2219         C-style and Ada-style convenience var strings without
2220         calling the inferior.
2221         * printcmd.c (printf_c_string): Locally print GDB internal var
2222         instead of transiting via the inferior.
2223         (printf_wide_c_string): Likewise.
2224
2225 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2226
2227         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2228
2229 2019-07-04  Tom Tromey  <tom@tromey.com>
2230
2231         PR tui/24724:
2232         * tui/tui-winsource.c (tui_clear_source_content): Update.
2233         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2234         (tui_update_breakpoint_info): Update.
2235         (tui_set_exec_info_content): Update.
2236         * tui/tui-source.c (tui_set_source_content_nil): Update.
2237         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2238         has_break.
2239         * tui/tui-data.h (enum tui_bp_flag): New.
2240         (tui_bp_flags): New enum flags type.
2241         (struct tui_source_element) <break_mode>: Change type.  Rename
2242         from has_break.
2243         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2244         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2245         constants.
2246         * tui/tui-winsource.h: Fix comment.
2247
2248 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2249
2250         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2251         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2252         (store_fpregs_to_thread)
2253         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2254         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2255         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2256         (IWMMXT_REGS_SIZE): Add define.
2257         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2258         (fetch_vfp_regs, store_vfp_regs)
2259         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2260         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2261
2262 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2263
2264         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2265         defines.
2266         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2267         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2268         (ARM_INT_REGISTER_SIZE): ...to this.
2269         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2270         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2271         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2272         (arm_linux_collect_gregset, supply_nwfpe_register)
2273         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2274         defines.
2275         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2276         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2277         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2278         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2279         (arm_return_in_memory, arm_store_return_value)
2280         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2281         (arm_record_ld_st_multiple): Likewise.
2282         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2283         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2284
2285 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2286
2287         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2288         AARCH64_DISPLACED_MODIFIED_INSNS.
2289         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2290         (aarch64_displaced_step_copy_insn): Likewise.
2291         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2292         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2293         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2294         ARM_DISPLACED_MODIFIED_INSNS.
2295         * arm-tdep.c (arm_gdbarch_init): Likewise.
2296         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2297         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2298         (struct arm_displaced_step_closure): Use
2299         ARM_DISPLACED_MODIFIED_INSNS.
2300
2301 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2302
2303         * features/Makefile: Remove unused xml files.
2304         * features/aarch64.xml: Remove.
2305         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2306         * features/i386/amd64-avx-avx512.xml: Remove.
2307         * features/i386/amd64-avx-linux.xml: Remove.
2308         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2309         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2310         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2311         * features/i386/amd64-avx-mpx.xml: Remove.
2312         * features/i386/amd64-avx.xml: Remove.
2313         * features/i386/amd64-linux.xml: Remove.
2314         * features/i386/amd64-mpx-linux.xml: Remove.
2315         * features/i386/amd64-mpx.xml: Remove.
2316         * features/i386/amd64.xml: Remove.
2317         * features/i386/i386-avx-avx512-linux.xml: Remove.
2318         * features/i386/i386-avx-avx512.xml: Remove.
2319         * features/i386/i386-avx-linux.xml: Remove.
2320         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2321         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2322         * features/i386/i386-avx-mpx-linux.xml: Remove.
2323         * features/i386/i386-avx-mpx.xml: Remove.
2324         * features/i386/i386-avx.xml: Remove.
2325         * features/i386/i386-linux.xml: Remove.
2326         * features/i386/i386-mmx-linux.xml: Remove.
2327         * features/i386/i386-mmx.xml: Remove.
2328         * features/i386/i386-mpx-linux.xml: Remove.
2329         * features/i386/i386-mpx.xml: Remove.
2330         * features/i386/i386.xml: Remove.
2331         * features/i386/x32-avx-avx512-linux.xml: Remove.
2332         * features/i386/x32-avx-linux.xml: Remove.
2333         * features/i386/x32-linux.xml: Remove.
2334
2335 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2336
2337         * regformats/aarch64.dat: Remove.
2338         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2339         * regformats/i386/amd64-avx-linux.dat: Remove.
2340         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2341         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2342         * regformats/i386/amd64-linux.dat: Remove.
2343         * regformats/i386/amd64-mpx-linux.dat: Remove.
2344         * regformats/i386/amd64.dat: Remove.
2345         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2346         * regformats/i386/i386-avx-linux.dat: Remove.
2347         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2348         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2349         * regformats/i386/i386-linux.dat: Remove.
2350         * regformats/i386/i386-mmx-linux.dat: Remove.
2351         * regformats/i386/i386-mpx-linux.dat: Remove.
2352         * regformats/i386/i386.dat: Remove.
2353         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2354         * regformats/i386/x32-avx-linux.dat: Remove.
2355         * regformats/i386/x32-linux.dat: Remove.
2356
2357 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2358
2359         * aarch64-tdep.c: Remove xml self tests.
2360         * amd64-linux-tdep.c: Likewise.
2361         * amd64-tdep.c: Likewise.
2362         * i386-linux-tdep.c: Likewise.
2363         * i386-tdep.c: Likewise.
2364
2365 2019-07-03  Pedro Alves  <palves@redhat.com>
2366
2367         PR cli/24732
2368         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2369         (pipe_cmd_option_defs): New.
2370         (make_pipe_cmd_options_def_group): New.
2371         (pipe_command): Use gdb::option::process_options.
2372         (pipe_command_completer): New function.
2373         (_initialize_cli_cmds): Install completer for "pipe" command.
2374
2375 2019-07-03  Pedro Alves  <palves@redhat.com>
2376
2377         * cli/cli-option.c (union option_value) <string>: New field.
2378         (struct option_def_and_value): Add ctor, move ctor, dtor and
2379         use DISABLE_COPY_AND_ASSIGN.
2380         (option_def_and_value::clear_value): New.
2381         (parse_option, save_option_value_in_ctx, get_val_type_str)
2382         (add_setshow_cmds_for_options): Handle var_string.
2383         * cli-option.h (union option_def::var_address) <string>: New
2384         field.
2385         (struct string_option_def): New.
2386         * maint-test-options.c (struct test_options_opts): Add default
2387         ctor and use DISABLE_COPY_AND_ASSIGN.
2388         <string_opt>: New field.
2389         (test_options_opts::~test_options_opts): New.
2390         (test_options_opts::dump): Also dump "-string".
2391         (test_options_option_defs): Install "string.
2392
2393 2019-07-03  Pedro Alves  <palves@redhat.com>
2394
2395         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2396         option_value with a null enumeration.
2397         (complete_options): Save the option values in the context.
2398         (save_option_value_in_ctx): New, factored out from ...
2399         (process_options): ... here.
2400         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2401         of the function.
2402         * maint-test-options.c (test_options_opts::dump): New, factored
2403         out from ...
2404         (maintenance_test_options_command_mode): ... here.
2405         (maintenance_test_options_command_completion_result): Delete.
2406         (maintenance_test_options_command_completion_text): Update
2407         comment.
2408         (maintenance_show_test_options_completion_result): Change
2409         prototype.  Just print
2410         maintenance_test_options_command_completion_text.
2411         (save_completion_result): New.
2412         (maintenance_test_options_completer_mode): Pass options context to
2413         complete_options, and then save a dump.
2414         (_initialize_maint_test_options): Use add_cmd to install "maint
2415         show test-options-completion-result".
2416
2417 2019-07-03  Pedro Alves  <palves@redhat.com>
2418
2419         * NEWS (New commands): Mention "with" and "maint with".
2420         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2421         (with_command, with_command_completer): New.
2422         (pipe_command): Adjust to new repeat_previous
2423         interface.
2424         (_initialize_cli_cmds): Install the "with" command and its "w"
2425         alias.
2426         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2427         declarations.
2428         * cli/cli-setshow.c (parse_cli_var_uinteger)
2429         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2430         argument strings for all var_types.
2431         (get_setshow_command_value_string): New, factored out from ...
2432         (do_show_command): ... this.
2433         * cli/cli-setshow.h: Include <string>.
2434         (get_setshow_command_value_string): Declare.
2435         * command.h (repeat_previous): Now returns const char *.  Adjust
2436         comment.
2437         * maint.c: Include "cli/cli-cmds.h".
2438         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2439         (_initialize_maint_cmds): Register the "maintenance with" command.
2440         * top.c (repeat_previous): Move bits from pipe_command here:
2441         Return the saved command line, if any; error out if there's no
2442         command to relaunch.
2443
2444 2019-07-03  Pedro Alves  <palves@redhat.com>
2445
2446         * NEWS (New commands): Mention "maint set/show test-settings"
2447         instead of "maint test-settings".
2448         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2449         (maintenance_test_settings_set_list): Rename to ...
2450         (maintenance_set_test_settings_list): ... this.
2451         (maintenance_test_settings_show_list): Rename to  ...
2452         (maintenance_show_test_settings_list): ... this.
2453         (maintenance_test_settings_cmd): Delete.
2454         (maintenance_test_settings_set_cmd): ...
2455         (maintenance_set_test_settings_cmd): ... this.
2456         (maintenance_test_settings_show_cmd): ...
2457         (maintenance_show_test_settings_cmd): ... this.
2458         (maintenance_test_settings_show_value_cmd):
2459         (maintenance_show_test_settings_value_cmd): ... this.
2460         (_initialize_maint_test_settings): No longer install the "maint
2461         test-settings" prefix command.  Rename "maint test-settings set"
2462         to "maint set test-settings", and "maint test-settings show" to
2463         "maint show test-settings".  Adjust all subcommands.
2464
2465 2019-07-03  Pedro Alves  <palves@redhat.com>
2466
2467         * maint-test-settings.c: Fix file's intro comment.  Replace all
2468         references to "test-options" with references to "test-settings",
2469         in comments.
2470
2471 2019-07-03  Pedro Alves  <palves@redhat.com>
2472
2473         * maint-test-settings.c (maintenance_test_settings_xxx)
2474         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2475         New.
2476         (maintenance_test_settings_enums): Use them.
2477         (maintenance_test_settings_enum): Default to
2478         maintenance_test_settings_xxx.
2479         (_initialize_maint_test_settings): Initialize
2480         MAINTENANCE_TEST_SETTINGS_FILENAME.
2481
2482 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2483
2484         * breakpoint.h (remove_breakpoints_inf): Change return type to
2485         void, move function documentation here.
2486         * breakpoint.c (remove_breakpoints_inf): Change return type to
2487         void, move function documentation to header.
2488
2489 2019-07-02  Pedro Alves  <palves@redhat.com>
2490
2491         * NEWS (Completion improvements): Mention "info threads".
2492         * thread.c (struct info_threads_opts, info_threads_option_defs)
2493         (make_info_threads_options_def_group): New.
2494         (info_threads_command): Use gdb::option::process_options.
2495         (info_threads_command_completer): New.
2496         (_initialize_thread): Use gdb::option::build_help to build the
2497         help text for "info threads".
2498
2499 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2500
2501         * defs.h (generic_load): Move from here...
2502         * symfile.h (generic_load): ... to here.  Rename name parameter
2503         to args.
2504         * symfile.c (generic_load): Add comment.
2505
2506 2019-07-01  Tom Tromey  <tromey@adacore.com>
2507
2508         * dwarf2read.c
2509         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2510         declaration of without_params.  Fix formatting.
2511
2512 2019-07-01  Tom Tromey  <tromey@adacore.com>
2513
2514         * ada-exp.y (find_primitive_type): Update.
2515         * ada-lang.h (ada_lookup_symbol): Update.
2516         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2517         parameter.
2518         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2519
2520 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2521
2522         PR breakpoints/24541
2523         * gdbarch.c: Regenerate.
2524         * gdbarch.h: Regenerate.
2525         * gdbarch.sh: Add 'stap_adjust_register'.
2526         * i386-tdep.c: Include '<unordered_set>'.
2527         (i386_stap_adjust_register): New function.
2528         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2529         * stap-probe.c (stap_parse_register_operand): Call
2530         'gdbarch_stap_adjust_register'.
2531
2532 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2533
2534         PR python/24742
2535         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2536         * python/python.c (do_start_initialization): Use 'xmalloc'
2537         instead of 'PyMem_Malloc'.
2538
2539 2019-06-28  Tom Tromey  <tromey@adacore.com>
2540
2541         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2542         for Ada.
2543
2544 2019-06-27  Tom Tromey  <tromey@adacore.com>
2545
2546         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2547         objfile_key.
2548         (arm_find_mapping_symbol, arm_record_special_symbol)
2549         (_initialize_arm_tdep): Update.
2550         (arm_objfile_data_free): Remove.
2551
2552 2019-06-27  Tom Tromey  <tromey@adacore.com>
2553
2554         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2555         to cp_print_static_field.
2556
2557 2019-06-26  Tom Tromey  <tromey@adacore.com>
2558
2559         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2560         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2561         declare.
2562
2563 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2564
2565         * features/aarch64-core.c (create_feature_aarch64_core):
2566         Regenerate.
2567         * features/aarch64-core.xml: Add cpsr flags.
2568
2569 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2570
2571         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2572         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2573
2574 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2575
2576         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2577         field.
2578         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2579         use.
2580         (arm_record_special_symbol): Don't insert new symbol in sorted
2581         position, push it at the end.
2582
2583 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2584
2585         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2586         (arm_mapping_symbol_s): Remove.
2587         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2588         (arm_mapping_symbol_vec): New typedef.
2589         (struct arm_per_objfile): Add constructor.
2590         <section_maps>: Change type to
2591         std::unique_ptr<arm_mapping_symbol_vec[]>.
2592         (arm_compare_mapping_symbols): Remove.
2593         (arm_find_mapping_symbol): Adjust to section_maps type change.
2594         (arm_objfile_data_free): Call delete on arm_per_objfile.
2595         (arm_record_special_symbol): Adjust to section_maps type change.
2596         Allocate arm_per_objfile with new.
2597
2598 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2599
2600         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2601         with the command prefix.
2602
2603 2019-06-25  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2606         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2607
2608 2019-06-25  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2611         type.
2612         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2613         protected.
2614
2615 2019-06-25  Tom Tromey  <tom@tromey.com>
2616
2617         * tui/tui-winsource.c
2618         (tui_source_window_base::set_is_exec_point_at): Add check against
2619         LOA_ADDRESS.
2620
2621 2019-06-25  Tom Tromey  <tom@tromey.com>
2622
2623         * tui/tui-source.c (tui_set_source_content): Don't check before
2624         xfree.
2625         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2626
2627 2019-06-25  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui-winsource.h (tui_update_source_window_as_is)
2630         (tui_alloc_source_buffer, tui_line_is_displayed)
2631         (tui_addr_is_displayed): Change type of win_info.
2632         * tui/tui-winsource.c (tui_update_source_window_as_is)
2633         (tui_clear_source_content, tui_show_source_line)
2634         (tui_show_source_content, tui_source_window_base::refill)
2635         (tui_source_window_base::set_is_exec_point_at)
2636         (tui_source_window_base::set_is_exec_point_at)
2637         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2638         (tui_alloc_source_buffer, tui_line_is_displayed)
2639         (tui_addr_is_displayed): Change type of win_info.  Update.
2640         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2641         (tui_source_window_base::do_make_visible_with_new_height):
2642         Update.
2643         * tui/tui-source.c (tui_set_source_content)
2644         (tui_set_source_content_nil)
2645         (tui_source_window::do_scroll_vertical): Update.
2646         * tui/tui-layout.c (show_layout): Update.
2647         * tui/tui-disasm.c (tui_set_disassem_content)
2648         (tui_disasm_window::do_scroll_vertical): Update.
2649         * tui/tui-data.h (tui_win_content): Remove.
2650         (struct tui_gen_win_info) <content, content_size>: Remove.
2651         (struct tui_source_element): Add initializers and destructor.
2652         (union tui_which_element, struct tui_win_element): Remove.
2653         (struct tui_source_window_base) <content>: New field.
2654         (struct tui_data_window): Remove destructor.
2655         (tui_alloc_content, tui_free_win_content)
2656         (tui_free_all_source_wins_content): Don't declare.
2657         * tui/tui-data.c (tui_initialize_static_data): Update.
2658         (init_content_element, tui_alloc_content): Remove.
2659         (~tui_gen_win_info): Update.
2660         (~tui_data_window, tui_free_all_source_wins_content)
2661         (tui_free_win_content, free_content, free_content_elements):
2662         Remove.
2663
2664 2019-06-25  Tom Tromey  <tom@tromey.com>
2665
2666         * tui/tui-winsource.h (tui_clear_source_content)
2667         (tui_erase_source_content, tui_show_source_content): Change type
2668         of win_info.
2669         * tui/tui-winsource.c (tui_clear_source_content)
2670         (tui_erase_source_content, tui_show_source_content): Change type
2671         of win_info.
2672         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2673         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2674         win_info.
2675         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2676         win_info.
2677         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2678
2679 2019-06-25  Tom Tromey  <tom@tromey.com>
2680
2681         * tui/tui-winsource.c (tui_clear_source_content)
2682         (tui_source_window_base::set_is_exec_point_at): Update.
2683         * tui/tui-source.c (tui_set_source_content_nil): Update.
2684         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2685         a bool.
2686         * tui/tui-data.c (init_content_element): Update.
2687
2688 2019-06-25  Tom Tromey  <tom@tromey.com>
2689
2690         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2691         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2692         * tui/tui-layout.c (init_and_make_win): Update.
2693         * tui/tui.h (enum tui_win_type): Update.
2694         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2695         tui_win_is_auxillary.
2696         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2697         tui_win_is_auxillary.
2698
2699 2019-06-25  Tom Tromey  <tom@tromey.com>
2700
2701         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2702         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2703         (tui_delete_data_content_windows, tui_display_all_data)
2704         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2705         Update.
2706         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2707         * tui/tui-regs.c (tui_last_regs_line_no)
2708         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2709         (tui_show_registers): Update.
2710         (tui_show_register_group): Return void.  Update.
2711         (tui_display_registers_from, tui_display_reg_element_at_line)
2712         (tui_display_registers_from_line, tui_check_register_values):
2713         Update.
2714         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2715         member.
2716         (struct tui_data_window) <regs_content>: Now a std::vector.
2717         <regs_content_count>: Remove.
2718         (tui_add_content_elements, tui_free_data_content): Don't declare.
2719         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2720         (init_content_element): Remove DATA_WIN case.  Add assert.
2721         (tui_add_content_elements): Remove.
2722         (tui_data_window): Update.
2723         (tui_free_data_content): Remove.
2724         (free_content_elements): Remove DATA_WIN case.
2725
2726 2019-06-25  Tom Tromey  <tom@tromey.com>
2727
2728         * tui/tui-data.c (tui_data_item_window): Update.
2729         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2730         * tui/tui-windata.c (tui_display_all_data)
2731         (tui_display_data_from_line): Update.
2732         (tui_check_data_values): Remove.
2733         * tui/tui-regs.c (tui_show_register_group)
2734         (tui_display_reg_element_at_line): Update.
2735         * tui/tui-hooks.c (tui_register_changed)
2736         (tui_refresh_frame_and_register_information): Call
2737         tui_check_register_values.
2738         * tui/tui-data.h (struct tui_data_window) <data_content,
2739         data_content_count, data_type>: Remove.
2740         (enum tui_data_type): Remove.
2741
2742         * tui/tui-data.c (tui_data_window::clear_detail)
2743         (~tui_data_window): Update.
2744
2745 2019-06-25  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2748         declare.
2749         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2750         Rename from tui_first_data_item_displayed.  Update.
2751         (tui_data_window::refresh_all)
2752         (tui_data_window::do_scroll_vertical): Update.
2753         * tui/tui-data.h (struct tui_data_window)
2754         <first_data_item_displayed>: Declare new method.
2755
2756 2019-06-25  Tom Tromey  <tom@tromey.com>
2757
2758         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2759         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2760         contents...
2761         (tui_initialize_static_data): ...here.
2762
2763 2019-06-25  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2766         (tui_display_registers_from, tui_check_register_values): Update.
2767         (tui_display_register): Remove win_info parameter; update.
2768         (tui_get_register): Change type of parameters.
2769         * tui/tui-data.h (struct tui_data_element): Remove.
2770         (union tui_which_element) <data>: Remove.
2771         <data_window>: Change type.
2772         (struct tui_data_item_window): New.
2773         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2774         case.  Add assert.
2775         (~tui_data_item_window): New destructor.
2776         (free_content_elements): Remove DATA_ITEM_WIN case.
2777
2778 2019-06-25  Tom Tromey  <tom@tromey.com>
2779
2780         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2781         Remove.
2782
2783 2019-06-25  Tom Tromey  <tom@tromey.com>
2784
2785         * tui/tui-data.h (struct tui_command_element): Remove.
2786         (union tui_which_element) <command>: Remove.
2787         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2788         assert.
2789         (free_content_elements): Remove CMD_WIN case.
2790
2791 2019-06-25  Tom Tromey  <tom@tromey.com>
2792
2793         * tui/tui-layout.c (tui_set_layout): Update.
2794         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2795         * tui/tui-data.c (layout_def): Update.
2796
2797 2019-06-25  Tom Tromey  <tom@tromey.com>
2798
2799         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2800         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2801         (tui_source_window_base::set_new_height): Update.
2802         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2803         Update.
2804         (tui_set_locator_fullname, tui_set_locator_info)
2805         (tui_show_frame_info): Update.
2806         * tui/tui-source.c (tui_set_source_content)
2807         (tui_source_is_displayed): Update.
2808         * tui/tui-layout.c (show_source_disasm_command, show_data)
2809         (show_source_or_disasm_and_command): Update.
2810         * tui/tui-disasm.c (tui_set_disassem_content)
2811         (tui_get_begin_asm_address): Update.
2812         * tui/tui-data.h (struct tui_locator_element): Remove.
2813         (union tui_which_element) <locator>: Remove.
2814         (struct tui_locator_window): New.
2815         (tui_locator_win_info_ptr): Change return type.
2816         * tui/tui-data.c (_locator): Change type.
2817         (tui_locator_win_info_ptr): Change return type.
2818         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2819         (tui_alloc_content): Add assert.
2820
2821 2019-06-25  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-winsource.c
2824         (tui_exec_info_window::maybe_allocate_content): New method.
2825         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2826         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2827         (make_source_or_disasm_window): Add cast.
2828         * tui/tui-data.h (union tui_which_element) <simple_string>:
2829         Remove.
2830         (struct tui_source_info): New.
2831         (struct tui_source_window_base) <execution_info>: Change type.
2832         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2833         case, and add assert.
2834         (tui_alloc_content): Add assert.
2835
2836 2019-06-25  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2839         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2840         * tui/tui-data.c (tui_alloc_win_info): Remove.
2841
2842 2019-06-25  Tom Tromey  <tom@tromey.com>
2843
2844         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2845         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2846         can_highlight.
2847
2848 2019-06-25  Tom Tromey  <tom@tromey.com>
2849
2850         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2851         make_visible_with_new_height method.
2852         (tui_win_info::make_visible_with_new_height): New method.
2853         (tui_source_window_base::do_make_visible_with_new_height)
2854         (tui_data_window::do_make_visible_with_new_height)
2855         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2856         (make_visible_with_new_height): Remove.
2857         (tui_resize_all, tui_adjust_win_heights): Use
2858         make_visible_with_new_height method.
2859         * tui/tui-data.h (struct tui_win_info)
2860         <do_make_visible_with_new_height, make_visible_with_new_height>:
2861         New methods.
2862         (struct tui_source_window_base, struct tui_data_window)
2863         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2864         methods.
2865
2866 2019-06-25  Tom Tromey  <tom@tromey.com>
2867
2868         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2869         method.
2870         (update_tab_width): Call update_tab_width method.
2871         * tui/tui-data.h (struct tui_win_info)
2872         (struct tui_source_window_base) <update_tab_width>: New methods.
2873
2874 2019-06-25  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2877         parameter.
2878         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2879         parameter.
2880         (tui_gen_win_info::make_visible): Update.
2881         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2882         parameter.
2883         * tui/tui-data.h (enum tui_box): New enum.
2884         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2885
2886 2019-06-25  Tom Tromey  <tom@tromey.com>
2887
2888         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2889         init_and_make_win for EXEC_INFO_WIN.
2890         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2891         longer inline.
2892         (struct tui_win_info) <~tui_win_info>: Inline.
2893         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2894         Don't declare.
2895         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2896         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2897         Remove.
2898         (tui_initialize_static_data): Update.
2899         (~tui_gen_win_info): Handle more cleanup here.
2900         (~tui_source_window_base): Delete "execution_info".
2901         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2902
2903 2019-06-25  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-layout.c (make_command_window): Don't set
2906         can_highlight.
2907         (show_source_disasm_command): Call the reset method.
2908         (show_data): Don't set can_highlight.  Call the reset method.
2909         (tui_gen_win_info::reset): Rename from init_gen_win_info
2910         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2911         (show_source_or_disasm_and_command): Call the reset method.
2912         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2913         (struct tui_cmd_window): Set can_highlight.
2914
2915 2019-06-25  Tom Tromey  <tom@tromey.com>
2916
2917         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2918         from make_visible.
2919         (tui_make_visible, tui_make_invisible): Rewrite.
2920         (tui_win_info::make_visible): Remove.
2921         (tui_source_window_base::make_visible): Update.
2922         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2923         method.  Moved from...
2924         (struct tui_win_info) <make_visible>: ...here.
2925
2926 2019-06-25  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-winsource.c
2929         (tui_source_window_base::do_scroll_horizontal): Remove direction
2930         parameter.
2931         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2932         direction parameter.
2933         * tui/tui-win.c (tui_win_info::forward_scroll)
2934         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2935         (tui_win_info::right_scroll): Update.
2936         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2937         direction parameter.
2938         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2939         direction parameter.
2940         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2941         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2942         Remove direction parameter.
2943         (struct tui_source_window_base, struct tui_source_window)
2944         (struct tui_disasm_window, struct tui_data_window)
2945         (struct tui_cmd_window): Update.
2946
2947 2019-06-25  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-winsource.h (tui_set_exec_info_content)
2950         (tui_show_exec_info_content, tui_erase_exec_info_content)
2951         (tui_clear_exec_info_content, tui_update_exec_info): Change
2952         argument to tui_source_window_base.
2953         * tui/tui-winsource.c (tui_set_exec_info_content)
2954         (tui_show_exec_info_content, tui_erase_exec_info_content)
2955         (tui_clear_exec_info_content, tui_update_exec_info): Change
2956         argument to tui_source_window_base.
2957
2958 2019-06-25  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2961         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2966         check.
2967
2968 2019-06-25  Tom Tromey  <tom@tromey.com>
2969
2970         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2971         type to void.
2972         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2973         type to void.
2974         * tui/tui-source.c (tui_set_source_content): Update.
2975         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2976
2977 2019-06-25  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-win.c (window_name_completer, tui_set_focus)
2980         (tui_all_windows_info): Use name method.
2981         * tui/tui-data.h (struct tui_gen_win_info)
2982         (struct tui_source_window, struct tui_disasm_window)
2983         (struct tui_data_window, struct tui_cmd_window) <name>: New
2984         method.
2985         (tui_win_name): Don't declare.
2986         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2987         (tui_win_name): Remove.
2988
2989 2019-06-25  Tom Tromey  <tom@tromey.com>
2990
2991         * tui/tui-winsource.h (tui_update_source_window)
2992         (tui_update_source_window_as_is): Change parameter type.
2993         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2994         to be a tui_source_window_base.
2995         (tui_update_source_window_as_is): Likewise.
2996         * tui/tui-win.c (make_visible_with_new_height): Update.
2997
2998 2019-06-25  Tom Tromey  <tom@tromey.com>
2999
3000         * tui/tui-winsource.c (tui_erase_source_content)
3001         (tui_show_source_content, tui_show_exec_info_content)
3002         (tui_erase_exec_info_content): Use refresh_window method.
3003         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3004         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3005         from tui_refresh_win.
3006         (tui_data_window::refresh_window): New method.
3007         (tui_win_info::refresh, tui_source_window_base::refresh)
3008         (tui_refresh_all): Use refresh_window method.
3009         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3010         method.
3011         * tui/tui-regs.c (tui_display_register): Call refresh_window
3012         method.
3013         * tui/tui-layout.c (show_source_disasm_command)
3014         (show_source_or_disasm_and_command): Call refresh_window method.
3015         * tui/tui-data.h (struct tui_gen_win_info)
3016         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3017         New method.
3018
3019 2019-06-25  Tom Tromey  <tom@tromey.com>
3020
3021         * tui/tui.c (tui_rl_other_window, tui_enable)
3022         (tui_is_window_visible, tui_get_command_dimension): Update.
3023         * tui/tui-winsource.c (tui_update_source_window_as_is)
3024         (tui_clear_source_content, tui_erase_source_content)
3025         (tui_show_source_line, tui_source_window_base::refill)
3026         (tui_source_window_base::do_scroll_horizontal)
3027         (tui_source_window_base::set_is_exec_point_at)
3028         (tui_update_breakpoint_info, tui_set_exec_info_content)
3029         (tui_alloc_source_buffer, tui_line_is_displayed)
3030         (tui_addr_is_displayed): Update.
3031         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3032         (tui_check_and_display_highlight_if_needed)
3033         (tui_win_info::make_visible, tui_win_info::refresh)
3034         (tui_refresh_all): Update.
3035         * tui/tui-windata.c (tui_first_data_item_displayed)
3036         (tui_delete_data_content_windows, tui_erase_data_content)
3037         (tui_display_all_data, tui_data_window::refresh_all)
3038         (tui_check_data_values): Update.
3039         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3040         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3041         (tui_win_info::backward_scroll, tui_refresh_all_win)
3042         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3043         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3044         (tui_source_window_base::set_new_height)
3045         (tui_data_window::set_new_height)
3046         (make_invisible_and_set_new_height)
3047         (make_visible_with_new_height, new_height_ok)
3048         (parse_scrolling_args): Update.
3049         * tui/tui-stack.c (tui_show_frame_info): Update.
3050         * tui/tui-source.c (tui_set_source_content)
3051         (tui_set_source_content_nil, tui_source_is_displayed)
3052         (tui_source_window::do_scroll_vertical): Update.
3053         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3054         (tui_display_registers_from, tui_display_reg_element_at_line)
3055         (tui_check_register_values, tui_reg_command): Update.
3056         * tui/tui-layout.c (tui_default_win_height)
3057         (show_source_disasm_command, show_data, init_and_make_win)
3058         (show_source_or_disasm_and_command): Update.
3059         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3060         (tui_redisplay_readline, tui_mld_flush)
3061         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3062         (tui_getc): Update.
3063         * tui/tui-disasm.c (tui_set_disassem_content)
3064         (tui_disasm_window::do_scroll_vertical): Update.
3065         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3066         Now virtual.
3067         (struct tui_win_info): Derive from tui_gen_win_info.
3068         <~tui_win_info>: Mark as override.
3069         <generic>: Remove member.
3070         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3071         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3072         (~tui_data_window, ~tui_win_info)
3073         (tui_free_all_source_wins_content): Update.
3074         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3075
3076 2019-06-25  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-layout.c (init_and_make_win): Use new.
3079         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3080         destructor, initializers.
3081         (tui_alloc_generic_win_info): Don't declare.
3082         * tui/tui-data.c (_locator): Add argument to constructor.
3083         (source_win, disasm_win): New globals.
3084         (exec_info): Remove.
3085         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3086         Update.
3087         (tui_alloc_generic_win_info): Remove.
3088         (init_content_element): Use new.
3089         (tui_win_info::tui_win_info): Update.
3090         (free_content_elements) <case DATA_WIN>: Use delete.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3095         * tui/tui-windata.c (tui_first_data_item_displayed)
3096         (tui_delete_data_content_windows): Update.
3097         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3098         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3099         (tui_display_registers_from, tui_check_register_values): Update.
3100         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3101         pointer.
3102         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3103         window.
3104         (tui_free_data_content): Update.
3105         (free_content_elements) <case DATA_WIN>: Free the window.
3106
3107 2019-06-25  Tom Tromey  <tom@tromey.com>
3108
3109         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3110         Update.
3111         * tui/tui-layout.c (make_command_window)
3112         (show_source_disasm_command, show_data, init_and_make_win)
3113         (show_source_or_disasm_and_command): Update.
3114         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3115         method.
3116         <can_highight, is_highlighted>: Now bool.
3117         (tui_set_win_highlight): Don't declare.
3118         * tui/tui-data.c (tui_set_win_highlight): Remove.
3119
3120 2019-06-25  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-wingeneral.c (make_visible): Remove check of window
3123         type.
3124
3125 2019-06-25  Tom Tromey  <tom@tromey.com>
3126
3127         * tui/tui-win.c (tui_win_info::max_height)
3128         (tui_cmd_window::max_height): New methods.
3129         (new_height_ok): Call max_height.
3130         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3131         <max_height>: New method.
3132
3133 2019-06-25  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-win.c (tui_source_window_base::set_new_height)
3136         (tui_data_window::set_new_height): New methods.
3137         (make_invisible_and_set_new_height): Call set_new_height method.
3138         * tui/tui-data.h (struct tui_win_info)
3139         (struct tui_source_window_base, struct tui_data_window)
3140         <set_new_height>: New method.
3141
3142 2019-06-25  Tom Tromey  <tom@tromey.com>
3143
3144         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3145         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3146         tui_refresh_data_win.
3147         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3148         method.
3149         (tui_refresh_all_win): Call the refresh_all method.
3150         (tui_set_focus): Likewise.
3151         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3152         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3153         Likewise.
3154
3155 2019-06-25  Tom Tromey  <tom@tromey.com>
3156
3157         * tui/tui-winsource.h (tui_refill_source_window)
3158         (tui_set_is_exec_point_at): Don't declare.
3159         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3160         (tui_source_window_base::refill): Rename from
3161         tui_refill_source_window.
3162         (tui_source_window_base::do_scroll_horizontal): Update.
3163         (tui_source_window_base::set_is_exec_point_at): Rename from
3164         tui_set_is_exec_point_at.
3165         (tui_update_all_breakpoint_info): Update.
3166         * tui/tui-stack.c (tui_show_frame_info): Update.
3167         * tui/tui-layout.c (show_data): Add cast.
3168         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3169         * tui/tui-data.h (struct tui_source_window_base) <refill,
3170         set_is_exec_point_at>: New methods.
3171         (tui_source_windows, tui_add_to_source_windows): Update types.
3172         (tui_add_to_source_windows): Remove redundant declaration.
3173         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3174         (tui_source_windows): Change return type.
3175         (tui_clear_source_windows_detail): Update.
3176         (tui_add_to_source_windows): Change type of parameter.
3177         (tui_free_all_source_wins_content): Update.
3178
3179 2019-06-25  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-wingeneral.c (tui_win_info::refresh)
3182         (tui_source_window_base::refresh): New methods.
3183         (tui_refresh_all): Call the refresh method.
3184         * tui/tui-data.h (struct tui_win_info)
3185         (struct tui_source_window_base) <refresh>: New method.
3186
3187 2019-06-25  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui.h (tui_is_window_visible): Return bool.
3190         * tui/tui.c (tui_is_window_visible): Return bool.
3191         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3192         (tui_make_visible, tui_make_invisible)
3193         (tui_win_info::make_visible)
3194         (tui_source_window_base::make_visible, make_all_visible)
3195         (tui_make_all_visible, tui_make_all_invisible): Update.
3196         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3197         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3198         bool.
3199         (struct tui_win_info, struct tui_source_window_base)
3200         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3201         * tui/tui-data.c (tui_init_generic_part): Update.
3202
3203 2019-06-25  Tom Tromey  <tom@tromey.com>
3204
3205         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3206         (tui_source_window_base::make_visible): New methods.
3207         (make_all_visible): Make method call.
3208         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3209         (struct tui_source_window_base, struct tui_cmd_window): Override
3210         make_visible.
3211         (tui_win_is_source_type): Don't declare.
3212         * tui/tui-data.c (tui_win_is_source_type): Remove.
3213
3214 2019-06-25  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3217         NULL check.
3218
3219 2019-06-25  Tom Tromey  <tom@tromey.com>
3220
3221         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3222         Inline constructor.  Add initializers for members.
3223         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3224         constructors; now inline in class.
3225
3226 2019-06-25  Tom Tromey  <tom@tromey.com>
3227
3228         * tui/tui-regs.c (tui_show_registers): Update.
3229         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3230         bool.
3231         * tui/tui-data.c (tui_data_window::clear_detail)
3232         (tui_data_window): Update.
3233
3234 2019-06-25  Tom Tromey  <tom@tromey.com>
3235
3236         * tui/tui-windata.c (tui_display_all_data)
3237         (tui_display_data_from_line, tui_display_data_from)
3238         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3239         Update.
3240         * tui/tui-regs.c (tui_last_regs_line_no)
3241         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3242         (tui_show_registers, tui_show_register_group)
3243         (tui_display_registers_from, tui_display_reg_element_at_line)
3244         (tui_display_registers_from_line, tui_check_register_values)
3245         (tui_reg_next, tui_reg_prev): Update.
3246         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3247         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3248         tui_data_window.
3249         (struct tui_win_info) <detail>: Remove.  Add new fields from
3250         tui_data_info.
3251         (TUI_DATA_WIN): Add cast.
3252         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3253         (~tui_data_window): Simplify.
3254
3255 2019-06-25  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-layout.c (show_source_disasm_command)
3258         (show_source_or_disasm_and_command): Update.
3259         * tui/tui-io.c (update_cmdwin_start_line)
3260         (tui_redisplay_readline): Update.
3261         * tui/tui-data.h (struct tui_command_info): Remove.
3262         (struct tui_win_info) <detail>: Remove command_info member.
3263         (struct tui_data_window) <start_line>: New member, from
3264         tui_command_info.
3265         (TUI_CMD_WIN): Add casts.
3266
3267 2019-06-25  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-winsource.c (tui_update_source_window)
3270         (tui_refill_source_window)
3271         (tui_source_window_base::do_scroll_horizontal)
3272         (tui_update_breakpoint_info, tui_set_exec_info_content)
3273         (tui_show_exec_info_content, tui_erase_exec_info_content)
3274         (tui_clear_exec_info_content): Update.
3275         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3276         Update.
3277         * tui/tui-win.c (make_invisible_and_set_new_height)
3278         (make_visible_with_new_height): Update.
3279         * tui/tui-source.c (tui_set_source_content)
3280         (tui_show_symtab_source): Update.
3281         * tui/tui-layout.c (extract_display_start_addr)
3282         (show_source_disasm_command, show_data)
3283         (make_source_or_disasm_window)
3284         (show_source_or_disasm_and_command): Update.
3285         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3286         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3287         "gdbarch".
3288         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3289         to tui_source_window_base.
3290         (struct tui_win_info) <detail>: Remove source_info member.
3291         (struct tui_source_window_base) <has_locator>: Inline.
3292         Move contents from tui_source_info; rename has_locator member to
3293         m_has_locator.
3294         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3295         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3296         header file.
3297         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3298         Simplify.
3299         (tui_free_all_source_wins_content): Cast to
3300         tui_source_window_base.
3301
3302 2019-06-25  Tom Tromey  <tom@tromey.com>
3303
3304         * tui/tui-win.c (make_invisible_and_set_new_height)
3305         (make_visible_with_new_height): Call has_locator method.
3306         * tui/tui-layout.c (show_source_disasm_command, show_data)
3307         (show_source_or_disasm_and_command): Update for bool change.
3308         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3309         (tui_win_info) <has_locator>: New method.
3310         (struct tui_source_window_base) <has_locator>: New method.
3311         (tui_win_has_locator): Don't declare.
3312         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3313         from tui_win_has_locator.
3314         (tui_source_window_base): Use false, not FALSE.
3315
3316 2019-06-25  Tom Tromey  <tom@tromey.com>
3317
3318         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3319         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3320         clear_detail method directly.
3321         (tui_clear_win_detail): Remove.
3322
3323 2019-06-25  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3326         "this", not TUI_DISASM_WIN.
3327
3328 2019-06-25  Tom Tromey  <tom@tromey.com>
3329
3330         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3331         declare.
3332         * tui/tui-winsource.c
3333         (tui_source_window_base::do_scroll_horizontal): Rename from
3334         tui_horizontal_source_scroll.
3335         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3336         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3337         from tui_vertical_data_scroll.
3338         * tui/tui-win.h (tui_scroll): Don't declare.
3339         * tui/tui-win.c (tui_win_info::forward_scroll)
3340         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3341         (tui_win_info::right_scroll): Rename and update.
3342         (tui_scroll_forward_command, tui_scroll_backward_command)
3343         (tui_scroll_left_command, tui_scroll_right_command): Update.
3344         (tui_scroll): Remove.
3345         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3346         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3347         from tui_vertical_source_scroll.
3348         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3349         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3350         from tui_vertical_disassem_scroll.
3351         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3352         do_scroll_horizontal>: New methods.
3353         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3354         Likewise.
3355         (struct tui_source_window_base): Add do_scroll_horizontal.
3356         (struct tui_source_window, struct tui_disasm_window): Add
3357         do_scroll_vertical.
3358         (struct tui_data_window, struct tui_cmd_window): Add
3359         do_scroll_horizontal and do_scroll_vertical.
3360         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3361
3362 2019-06-25  Tom Tromey  <tom@tromey.com>
3363
3364         * tui/tui-data.h (struct tui_source_window_base): New struct.
3365         (struct tui_source_window): Derive from tui_source_window_base.
3366         (struct tui_disasm_window): New struct.
3367         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3368         from tui_source_window::clear_detail.
3369         (tui_source_window_base): Rename from tui_source_window.
3370         (~tui_source_window_base): Rename from ~tui_source_window.
3371         (tui_alloc_win_info): Create a tui_disasm_window.
3372
3373 2019-06-25  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-data.h (struct tui_source_window)
3376         (struct tui_data_window): Declare destructors.
3377         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3378         destructors.
3379         (tui_win_info): Simplify.
3380
3381 2019-06-25  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-winsource.c (tui_display_main)
3384         (tui_update_source_windows_with_addr)
3385         (tui_update_all_breakpoint_info): Update.
3386         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3387         (new_height_ok, parse_scrolling_args): Update.
3388         * tui/tui-stack.c (tui_show_frame_info): Update.
3389         * tui/tui-data.h (struct tui_list): Remove.
3390         (tui_source_windows): Return a reference to a std::vector.
3391         * tui/tui-data.c (source_windows): Now a std::vector.
3392         (tui_source_windows): Change return type.
3393         (tui_clear_source_windows): Rewrite.
3394         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3395         (tui_free_all_source_wins_content): Rewrite.
3396
3397 2019-06-25  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3400         (struct tui_data_window, struct tui_cmd_window): Declare
3401         clear_detail method.
3402         * tui/tui-data.c (tui_source_window::clear_detail)
3403         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3404         methods.
3405         (tui_clear_win_detail): Simplify.
3406
3407 2019-06-25  Tom Tromey  <tom@tromey.com>
3408
3409         * tui/tui-layout.c (make_source_window, make_disasm_window)
3410         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3411         Return the new window.
3412         (show_source_disasm_command, show_data)
3413         (show_source_or_disasm_and_command): Update.
3414
3415 2019-06-25  Tom Tromey  <tom@tromey.com>
3416
3417         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3418         parameter.  Return the new window.
3419         (show_source_disasm_command): Update and remove NULL check.
3420         (show_source_or_disasm_and_command): Update.
3421
3422 2019-06-25  Tom Tromey  <tom@tromey.com>
3423
3424         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3425
3426 2019-06-25  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-data.h (struct tui_win_info): Make constructor
3429         protected.  Make destructor virtual.  Add initializers.
3430         (tui_source_window, tui_data_window, tui_cmd_window): New
3431         classes.
3432         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3433         constructor.  Add "type" parameter.
3434         (tui_source_window, tui_data_window, tui_cmd_window): New
3435         constructors.
3436         (tui_alloc_win_info): Instantiate the appropriate subclass.
3437
3438 2019-06-25  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-win.c (tui_resize_all): Use delete.
3441         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3442         destructor.
3443         (tui_free_window): Don't declare.
3444         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3445         Update.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-data.h (struct tui_win_info): Add constructor.
3450         * tui/tui-data.c (tui_alloc_win_info): Use new.
3451         (tui_free_window): Use delete.
3452
3453 2019-06-22  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3456         declare.
3457         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3458
3459 2019-06-22  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3462         declare.
3463         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3464
3465 2019-06-22  Tom de Vries  <tdevries@suse.de>
3466
3467         * dwarf2read.c (create_addrmap_from_aranges)
3468         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3469         instead of '%zu'.
3470
3471 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3472
3473         * dwarf2read.h (dwarf2_section_info_def): Remove.
3474         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3475         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3476         std::vector<dwarf2_section_info>.
3477         (struct dwo_file) <~dwo_file>: Remove.
3478         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3479         types field.
3480         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3481         (dwarf2_read_debug_names): Likewise.
3482         (create_debug_types_hash_table): Change parameter type to
3483         array_view, adjust code accordingly.
3484         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3485         (partial_die_info::fixup): Likewise.
3486         (determine_prefix): Likewise.
3487         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3488
3489 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3490
3491         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3492         gdb_bfd_ref_ptr.
3493         <~dwo_file>: Remove call to gdb_bfd_unref.
3494         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3495         gdb_bfd_ref_ptr::get.
3496
3497 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3498
3499         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3500         type to htab_up.
3501         * dwarf2read.c (struct dwo_file): Initialize fields.
3502         <~dwo_file>: New.
3503         (free_dwo_file): Remove, move content to ~dwo_file.
3504         (struct dwo_file_deleter): Remove.
3505         (dwo_file_up>: Remove custom deleter.
3506         (free_dwo_files): Remove.
3507         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3508         dwo_files.
3509         (process_skeletonless_type_units): Call unique_ptr::get.
3510         (allocate_dwo_file_hash_table): Add deleter to created hash
3511         table.  Change return type to htab_up.
3512         (lookup_dwo_file_slot): Don't memset dwo_file, call
3513         unique_ptr::get.
3514         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3515         (create_dwo_unit_in_dwp_v2): Likewise.
3516         (open_and_init_dwo_file): Likewise.
3517         (free_dwo_file_from_slot): Remove.
3518
3519 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3520
3521         * dwarf2read.h (struct dwarf2_section_info) <readin,
3522         is_virtual>: Change type to bool.
3523         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3524         true instead of 1.
3525
3526 2019-06-19  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-data.h (tui_init_content_element): Don't declare.
3529
3530 2019-06-19  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-data.h (tui_init_win_info): Don't declare.
3533
3534 2019-06-19  Tom de Vries  <tdevries@suse.de>
3535
3536         * dwarf2read.h (abstract_to_concrete): Change type to
3537         std::unordered_map<sect_offset, std::vector<sect_offset>,
3538         gdb::hash_enum<sect_offset>>.
3539
3540 2019-06-19  Tom Tromey  <tromey@adacore.com>
3541
3542         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3543         EVAL_AVOID_SIDE_EFFECTS specially.
3544
3545 2019-06-19  Tom Tromey  <tromey@adacore.com>
3546
3547         * source-cache.c (highlighter): New global.
3548         (source_cache::get_source_lines): Create a highlighter on demand.
3549
3550 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3551
3552         * defs.h (deprecated_interactive_hook): Delete declaration.
3553         * interps.c (clear_interpreter_hooks): Remove use of
3554         deprecated_interactive_hook.
3555         * top.c (deprecated_interactive_hook): Delete definition.
3556         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3557
3558 2019-06-18  Tom de Vries  <tdevries@suse.de>
3559
3560         PR gdb/24515
3561         * dwarf2read.h (abstract_to_concrete): Change type from
3562         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3563         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3564         * dwarf2read.c (read_variable): Update.
3565         (dwarf2_fetch_die_loc_sect_off): Update.
3566
3567 2019-06-17  Tom de Vries  <tdevries@suse.de>
3568
3569         PR gdb/24617
3570         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3571         accessing parent[parent_len - 1].
3572
3573 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3574
3575         PR gdb/24364
3576         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3577         call dtrace_process_dof with NULL dof.
3578
3579 2019-06-16  Tom de Vries  <tdevries@suse.de>
3580
3581         PR gdb/24445
3582         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3583
3584 2019-06-16  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3587         (make_all_visible): Use address of member.
3588
3589 2019-06-16  Tom Tromey  <tom@tromey.com>
3590
3591         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3592         (tui_free_window, free_content, free_content_elements): Remove
3593         unnecessary cast.
3594         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3595         cast.
3596         * tui/tui-regs.c (tui_show_register_group)
3597         (tui_display_registers_from, tui_display_reg_element_at_line):
3598         Remove unnecessary cast.
3599
3600 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3601
3602         * linux-nat.c (normal_mask): Delete.
3603         (_initialize_linux_nat): Don't initialise normal_mask.
3604
3605 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3606
3607         PR gdb/24445
3608         * dwarf-index-write.h (write_psymtabs_to_index): Add
3609         dwz_basename parameter.
3610         * dwarf-index-write.c (write_gdbindex): Move file writing to
3611         write_gdbindex_1.  Change return type void.
3612         (assert_file_size): Move up, remove filename parameter.
3613         (write_gdbindex_1): New function.
3614         (write_debug_names): Change return type to void, call
3615         assert_file_size.
3616         (struct index_wip_file): New struct.
3617         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3618         file logic to index_wip_file.  Write index for dwz file if
3619         needed.
3620         (save_gdb_index_command): Pass basename of dwz file, if present.
3621         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3622         build-id of dwz file, if present.
3623         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3624         (dwarf2_get_dwz_file): Likewise.
3625         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3626         (dwarf2_get_dwz_file): Likewise.
3627
3628 2019-06-16  Tom Tromey  <tom@tromey.com>
3629
3630         * coffread.c (process_coff_symbol): Use xstrdup.
3631         * value.c (create_internalvar): Use xstrdup.
3632
3633 2019-06-16  Tom Tromey  <tom@tromey.com>
3634
3635         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3636         * breakpoint.c (stopin_command, stopat_command)
3637         (until_break_command, decode_location_default): Remove unnecessary
3638         cast.
3639         * utils.c (subset_compare): Remove unnecessary cast.
3640         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3641         cast.
3642         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3643         cast.
3644         * infcmd.c (path_command): Remove unnecessary cast.
3645         * coffread.c (decode_type): Remove unnecessary cast.
3646         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3647         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3648         * tui/tui-stack.c (tui_show_locator_content)
3649         (tui_show_frame_info): Remove unnecessary cast.
3650         * tui/tui-win.c (tui_scroll_forward_command)
3651         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3652         (parse_scrolling_args): Remove unnecessary cast.
3653         * tui/tui-data.c (init_win_info, tui_del_window)
3654         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3655         (free_content_elements): Remove unnecessary cast.
3656         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3657         unnecessary cast.
3658         * tui/tui-source.c (tui_set_source_content)
3659         (tui_vertical_source_scroll): Remove unnecessary cast.
3660         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3661         cast.
3662         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3663         * tui/tui-regs.c (tui_display_registers_from)
3664         (tui_display_register): Remove unnecessary cast.
3665         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3666         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3667         (make_visible): Remove unnecessary cast.
3668         * tui/tui-winsource.c (tui_erase_source_content)
3669         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3670         unnecessary cast.
3671         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3672         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3673         * stabsread.c (read_type, read_array_type, read_range_type):
3674         Remove unnecessary cast.
3675         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3676         (parse_symbol, parse_type, upgrade_type, parse_external)
3677         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3678         unnecessary cast.
3679         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3680
3681 2019-06-16  Tom Tromey  <tom@tromey.com>
3682
3683         * tui/tui-data.c (tui_alloc_generic_win_info)
3684         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3685         checks.
3686
3687 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3688             Andrew Burgess  <andrew.burgess@embecosm.com>
3689
3690         * f-typeprint.c (f_print_type): Don't return early for not
3691         associated or not allocated types.
3692         (f_type_print_varspec_suffix): Add print_rank parameter and print
3693         ranks of array types in case they dangling.
3694         (f_type_print_base): Add print_rank parameter.
3695
3696 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3697
3698         * NEWS: Mention new MI commands.
3699         * break-catch-throw.c (enum exception_event_kind): Move to
3700         breakpoint.h.
3701         (print_mention_exception_catchpoint): Output text as a single
3702         message.
3703         (catch_exception_command_1): Rename to...
3704         (catch_exception_event): ...this, make non-static, update header
3705         command, and change some parameter types.
3706         (catch_catch_command): Update for changes to
3707         catch_exception_command_1.
3708         (catch_throw_command): Likewise.
3709         (catch_rethrow_command): Likewise.
3710         * breakpoint.c (enum exception_event_kind): Delete.
3711         * breakpoint.h (enum exception_event_kind): Moved here from
3712         break-catch-throw.c.
3713         (catch_exception_event): Declare.
3714         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3715         (mi_cmd_catch_throw): New function.
3716         (mi_cmd_catch_rethrow): New function.
3717         (mi_cmd_catch_catch): New function.
3718         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3719         'catch-catch' entries.
3720         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3721         (mi_cmd_catch_rethrow): Declare.
3722         (mi_cmd_catch_catch): Declare.
3723
3724 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3725
3726         * annotate.c (annotate_source_line): Change return type to void,
3727         update implementation to match.
3728         * annotate.h (annotate_source_line): Change return type to void,
3729         update header comment.
3730         * stack.c (print_frame_info): Don't change what frame information
3731         is printed based on whether annotations are on or not.
3732
3733 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3736         (annotate_source): Make static.
3737         (annotate_source_line): Moved from source.c and renamed from
3738         identify_source_line.  Update the return type.
3739         * annotate.h (annotate_source): Delete declaration.
3740         (annotate_source_line): Declaration moved from source.h, and
3741         renamed from identify_source_line.  Return type updated.
3742         * source.c (identify_source_line): Moved to annotate.c and renamed
3743         to annotate_source_line.
3744         (info_line_command): Remove check of annotation_level.
3745         * source.h (identify_source_line): Move declaration to annotate.h
3746         and rename to annotate_source_line.
3747         * stack.c: Add 'annotate.h' include.
3748         (print_frame_info): Remove check of annotation_level before
3749         calling annotate_source_line.
3750
3751 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3752
3753         * source-cache.c (source_cache::get_plain_source_lines): Use
3754         open_source_file_with_line_charpos instead of just
3755         open_source_file, remove call to find_source_lines.
3756         (source_cache::get_source_lines): Likewise.
3757         * source.c (find_source_lines): Make static.
3758         (get_filename_and_charpos): Renamed into...
3759         (open_source_file_with_line_charpos): ..this along with changes to
3760         return a scoped_fd, and some other minor clean ups.
3761         (identify_source_line): Use open_source_file_with_line_charpos.
3762         (search_command_helper): Use open_source_file_with_line_charpos
3763         instead of just open_source_file, remove call to
3764         find_source_lines.
3765         * source.h (open_source_file_with_line_charpos): Declare new
3766         function.
3767         (find_source_lines): Delete declaration.
3768
3769 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         * source.c (get_filename_and_charpos): Remove fullname
3772         parameter.
3773         (identify_source_line): Update call to get_filename_and_charpos.
3774
3775 2019-06-14  Tom Tromey  <tromey@adacore.com>
3776
3777         PR gdb/24502:
3778         * ui-style.h (skip_ansi_escape): Update comment.
3779         * ui-file.h (class no_terminal_escape_file): New class.
3780         * ui-file.c (no_terminal_escape_file::write)
3781         (no_terminal_escape_file::puts): New methods.
3782         * cli/cli-logging.c (handle_redirections): Use
3783         no_terminal_escape_file.
3784
3785 2019-06-14  Tom Tromey  <tromey@adacore.com>
3786
3787         * NEWS: Move convenience variable news above Python news.
3788
3789 2019-06-14  Tom Tromey  <tom@tromey.com>
3790
3791         * gnulib: Move directory to top-level.
3792         * configure.ac: Don't configure gnulib.
3793         * configure: Rebuild.
3794         * common/common-defs.h: Use new path to gnulib.
3795         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3796         (GNULIB_H): Remove.
3797         (INCGNU): Look in new gnulib location.
3798         (HFILES_NO_SRCDIR): Remove gnulib files.
3799         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3800         (generated_files): Remove GNULIB_H.
3801         ($(LIBGNU), all-lib): Remove targets.
3802         (distclean): Don't mention GNULIB_BUILDDIR.
3803         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3804
3805 2019-06-14  Tom Tromey  <tromey@adacore.com>
3806
3807         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3808         Warn if symbol file does not provide any symbols.
3809
3810 2019-06-14  Tom Tromey  <tromey@adacore.com>
3811
3812         * source.c (find_and_open_source): Respect basenames_may_differ.
3813
3814 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3815
3816         * annotate.c (annotate_breakpoints_invalid): Make use of
3817         scoped_restore_terminal_state.
3818         (annotate_frames_invalid): Likewise.
3819
3820 2019-06-14  Tom Tromey  <tromey@adacore.com>
3821
3822         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3823         allow assignment to an internalvar.
3824
3825 2019-06-14  Tom Tromey  <tromey@adacore.com>
3826
3827         * ada-lex.l: Allow "_" in attribute names.
3828
3829 2019-06-14  Tom Tromey  <tromey@adacore.com>
3830
3831         PR gdb/24653:
3832         * regcache.c (registers_changed): Don't call alloca.
3833         * top.c (execute_command): Don't call alloca.
3834
3835 2019-06-13  Pedro Alves  <palves@redhat.com>
3836
3837         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3838         'expression'.  When parsing an expression, error out if there's
3839         junk after "unlimited".
3840         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3841         (do_set_command): Adjust calls to is_unlimited_literal.
3842
3843 2019-06-13  Pedro Alves  <palves@redhat.com>
3844
3845         * compile/compile.c (make_compile_options_def_group): Add braces
3846         around array_view initializer.
3847         * thread.c (make_thread_apply_all_options_def_group)
3848         (make_thread_apply_all_options_def_group): Likewise.
3849
3850 2019-06-13  Pedro Alves  <palves@redhat.com>
3851
3852         * NEWS (New commands): Mention "maint test-options
3853         require-delimiter", "maint test-options unknown-is-error", "maint
3854         test-options unknown-is-operand" and "maint show
3855         test-options-completion-result".
3856         (New command options, command completion): New section.
3857         (Completion improvements): New section.
3858         Mention that you can abbreviate "unlimited".
3859
3860 2019-06-13  Pedro Alves  <palves@redhat.com>
3861
3862         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3863         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3864         * unittests/cli-utils-selftests.c (test_parse_flags)
3865         (test_parse_flags_qcs): Delete.
3866         (test_cli_utils): Don't call deleted functions.
3867
3868 2019-06-13  Pedro Alves  <palves@redhat.com>
3869
3870         * thread.c: Include "cli/cli-option.h".
3871         (tp_array_compar_ascending): Global.
3872         (tp_array_compar): Delete function.
3873         (tp_array_compar_ascending, tp_array_compar_descending): New
3874         functions.
3875         (ascending_option_def, qcs_flag_option_def)
3876         (thr_qcs_flags_option_defs)
3877         (make_thread_apply_all_options_def_group)
3878         (make_thread_apply_options_def_group): New.
3879         (thread_apply_all_command): Use gdb::option::process_options.
3880         (thread_apply_command_completer)
3881         (thread_apply_all_command_completer): New.
3882         (thread_apply_command): Use gdb::option::process_options.
3883         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3884         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3885         to generate help text of "thread apply".  Adjust "taas"'s help.
3886         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3887         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3888
3889 2019-06-13  Pedro Alves  <palves@redhat.com>
3890
3891         * thread.c (thread_apply_command): Check for invalid TID with
3892         isdigit instead of !isalpha.
3893
3894 2019-06-13  Pedro Alves  <palves@redhat.com>
3895
3896         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3897         (validate_flags_qcs): New.
3898         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3899         (validate_flags_qcs): Declare.
3900         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3901         (make_frame_apply_options_def_group): New.
3902         (frame_apply_command_count): Process options with
3903         gdb::option::process_options.
3904         (frame_apply_completer): New.
3905         (frame_apply_level_completer, frame_apply_all_completer)
3906         (frame_apply_completer): New.
3907         (_initialize_stack): Update help of "frame apply", "frame apply
3908         level", "frame apply all" and "faas" to mention supported options
3909         and install command completers.
3910         * stack.h (frame_apply_all_completer): Declare.
3911         * thread.c: Include "stack.h".
3912         (tfaas_command): Add "--".
3913         (_initialize_thread): Update help "tfaas" to mention supported
3914         options and install command completer.
3915
3916 2019-06-13  Pedro Alves  <palves@redhat.com>
3917
3918         * completer.c (complete_nested_command_line): New.
3919         (gdb_completion_word_break_characters_throw): Add assertion.
3920         * completer.h (complete_nested_command_line): Declare.
3921
3922 2019-06-13  Pedro Alves  <palves@redhat.com>
3923
3924         * stack.c (parse_backtrace_qualifiers): New.
3925         (backtrace_command): Use it.
3926         (backtrace_command_completer): Complete on qualifiers.
3927
3928 2019-06-13  Pedro Alves  <palves@redhat.com>
3929
3930         * frame.c: Include "cli/cli-option.h.
3931         (user_set_backtrace_options): New.
3932         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3933         Delete.
3934         (get_prev_frame): Adjust.
3935         (boolean_option_def, uinteger_option_def)
3936         (set_backtrace_option_defs): New.
3937         (_initialize_frame): Adjust and use
3938         gdb::option::add_setshow_cmds_for_options to install "set
3939         backtrace past-main" and "set backtrace past-entry".
3940         * frame.h: Include "cli/cli-option.h".
3941         (struct frame_print_options): Forward declare.
3942         (print_frame_arguments_all, print_frame_arguments_scalars)
3943         (print_frame_arguments_none): Declare.
3944         (print_entry_values): Delete declaration.
3945         (struct frame_print_options, user_frame_print_options): New.
3946         (struct set_backtrace_options): New.
3947         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3948         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3949         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3950         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3951         (list_args_or_locals): Add frame_print_options parameter.
3952         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3953         * python/py-framefilter.c (enumerate_args): Pass down
3954         USER_FRAME_PRINT_OPTIONS.
3955         * stack.c: Include "cli/cli-option.h".
3956         (print_frame_arguments_all, print_frame_arguments_scalars)
3957         (print_frame_arguments_none): Declare.
3958         (print_raw_frame_arguments, print_entry_values): Delete.
3959         (user_frame_print_options): New.
3960         (boolean_option_def, enum_option_def, frame_print_option_defs):
3961         New.
3962         (struct backtrace_cmd_options): New.
3963         (bt_flag_option_def): New.
3964         (backtrace_command_option_defs): New.
3965         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3966         (print_frame_arg, read_frame_arg, print_frame_args)
3967         (print_frame_info, print_frame): Add frame_print_options parameter
3968         and use it.
3969         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3970         (backtrace_command_1): Add frame_print_options and
3971         backtrace_cmd_options parameters and use them.
3972         (make_backtrace_options_def_group): New.
3973         (backtrace_command): Process command options with
3974         gdb::option::process_options.
3975         (backtrace_command_completer): New.
3976         (_initialize_stack): Extend "backtrace"'s help to mention
3977         supported options.  Install completer for "backtrace".
3978         Install some settings commands with add_setshow_cmds_for_options.
3979
3980 2019-06-13  Pedro Alves  <palves@redhat.com>
3981
3982         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3983         and that "set/show print raw frame-arguments" are now deprecated.
3984
3985         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3986         command.
3987         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3988         * stack.c (_initialize_stack): Install "set/show print
3989         raw-frame-arguments", and deprecate "set/show print raw
3990         frame-arguments".
3991         * valprint.c (_initialize_valprint): Deprecate "set/show print
3992         raw".
3993
3994 2019-06-13  Pedro Alves  <palves@redhat.com>
3995
3996         * compile/compile.c (struct compile_options): New.
3997         (compile_flag_option_def, compile_command_option_defs)
3998         (make_compile_options_def_group): New.
3999         (compile_file_command): Handle options with
4000         gdb::option::process_options.
4001         (compile_file_command_completer): New function.
4002         (compile_code_command): Handle options with
4003         gdb::option::process_options.
4004         (compile_code_command_completer): New function.
4005         (_initialize_compiler): Install completers for "compile code" and
4006         "compile file".  Mention available options in "compile code" and
4007         "compile code"'s help.
4008         * completer.c (advance_to_completion_word): New, factored out from
4009         ...
4010         (advance_to_expression_complete_word_point): ... this.
4011         (advance_to_filename_complete_word_point): New.
4012         * completer.h (advance_to_filename_complete_word_point): New
4013         declaration.
4014
4015 2019-06-13  Pedro Alves  <palves@redhat.com>
4016
4017         * compile/compile.c: Include "cli/cli-option.h".
4018         (compile_print_value): Scope data pointer is now a
4019         value_print_options pointer; adjust.
4020         (compile_print_command): Process options.  Scope data pointer is
4021         now a value_print_options pointer; adjust.
4022         (_initialize_compile): Update "compile print"'s help to include
4023         supported options.  Install a completer for "compile print".
4024         * cp-valprint.c (show_vtblprint, show_objectprint)
4025         (show_static_field_print): Delete.
4026         (_initialize_cp_valprint): Don't install "set print
4027         static-members", "set print vtbl", "set print object" here.
4028         * printcmd.c: Include "cli/cli-option.h" and
4029         "common/gdb_optional.h".
4030         (print_command_parse_format): Rework to fill in a
4031         value_print_options instead of a format_data.
4032         (print_value): Change parameter type from format_data pointer to
4033         value_print_options reference.  Adjust.
4034         (print_command_1): Process options.  Adjust to pass down a
4035         value_print_options.
4036         (print_command_completer): New.
4037         (_initialize_printcmd): Install print_command_completer as
4038         handle_brkchars completer for the "print" command.  Update
4039         "print"'s help to include supported options.
4040         * valprint.c: Include "cli/cli-option.h".
4041         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4042         here from cp-valprint.c.
4043         (boolean_option_def, uinteger_option_def)
4044         (value_print_option_defs, make_value_print_options_def_group):
4045         New.  Use gdb::option::add_setshow_cmds_for_options to install
4046         "set print elements", "set print null-stop", "set print repeats",
4047         "set print pretty", "set print union", "set print array", "set
4048         print address", "set print symbol", "set print array-indexes".
4049         * valprint.h: Include <string> and "cli/cli-option.h".
4050         (make_value_print_options_def_group): Declare.
4051         (print_value): Change parameter type from format_data pointer to
4052         value_print_options reference.
4053         (print_command_completer): Declare.
4054
4055 2019-06-13  Pedro Alves  <palves@redhat.com>
4056
4057         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4058         (COMMON_SFILES): Add maint-test-settings.c.
4059         * cli/cli-decode.c (boolean_enums): New global, factored out from
4060         ...
4061         (add_setshow_boolean_cmd): ... here.
4062         * cli/cli-decode.h (boolean_enums): Declare.
4063         * cli/cli-option.c: New file.
4064         * cli/cli-option.h: New file.
4065         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4066         factored out from ...
4067         (parse_cli_boolean_value(const char *)): ... this.
4068         (is_unlimited_literal): Change parameter type to pointer to
4069         pointer.  Adjust and advance ARG pointer.
4070         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4071         (parse_cli_var_enum): New, factored out from ...
4072         (do_set_command): ... this.  Adjust.
4073         * cli/cli-setshow.h (parse_cli_boolean_value)
4074         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4075         (parse_cli_var_enum): Declare.
4076         * cli/cli-utils.c: Include "cli/cli-option.h".
4077         (get_ulongest): New.
4078         * cli/cli-utils.h (get_ulongest): Declare.
4079         (check_for_argument): New overloads.
4080         * maint-test-options.c: New file.
4081
4082 2019-06-13  Pedro Alves  <palves@redhat.com>
4083
4084         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4085         parse a range if "-" is at the end of the string.
4086
4087 2019-06-13  Pedro Alves  <palves@redhat.com>
4088
4089         * cli/cli-setshow.c (parse_auto_binary_operation)
4090         (parse_cli_boolean_value): Don't allow "o".
4091
4092 2019-06-13  Pedro Alves  <palves@redhat.com>
4093
4094         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4095         * NEWS: Mention maint test-settings KIND.
4096         * maint-test-settings.c: New file.
4097
4098 2019-06-13  Pedro Alves  <palves@redhat.com>
4099
4100         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4101         completer.
4102         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4103         "set" completers.
4104
4105 2019-06-13  Pedro Alves  <palves@redhat.com>
4106
4107         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4108         after item.
4109
4110 2019-06-13  Pedro Alves  <palves@redhat.com>
4111
4112         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4113
4114 2019-06-13  Pedro Alves <palves@redhat.com>
4115
4116         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4117         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4118         call.
4119         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4120         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4121         calls.
4122         (check_for_argument): Skip spaces after argument.
4123
4124 2019-06-13  Pedro Alves  <palves@redhat.com>
4125
4126         * thread.c (thread_apply_command): Adjust TID parsing.
4127         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4128         detected before end of string.
4129         (tid_is_in_list): Error out if LIST is invalid.
4130
4131 2019-06-13  Pedro Alves  <palves@redhat.com>
4132
4133         * completer.c (complete_line_internal_1): Rewind completion word
4134         point.
4135         (completion_tracker::advance_custom_word_point_by): Change
4136         parameter type to int.
4137         * completer.h (completion_tracker::advance_custom_word_point_by):
4138         Likewise.
4139
4140 2019-06-13  Pedro Alves  <palves@redhat.com>
4141
4142         * completer.c (advance_to_completion_word): Handle delimiters.
4143
4144 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4145
4146         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4147
4148 2019-06-11  Tom Tromey  <tom@tromey.com>
4149
4150         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4151         (xmalloc_failed): Move to alloc.c.
4152         * alloc.c: New file.
4153         * Makefile.in (COMMON_SFILES): Add alloc.c.
4154
4155 2019-06-11  Tom Tromey  <tom@tromey.com>
4156
4157         * nat/linux-waitpid.c: Don't include server.h.
4158         (linux_debug): Remove.
4159         (my_waitpid): Update.
4160
4161 2019-06-11  Tom Tromey  <tromey@adacore.com>
4162
4163         * infcall.c (_initialize_infcall): Remove trailing newline from
4164         help.
4165         * user-regs.c (_initialize_user_regs): Remove trailing newline
4166         from help.
4167         * typeprint.c (_initialize_typeprint): Remove trailing newline
4168         from help.
4169         * reverse.c (_initialize_reverse): Remove trailing newlines from
4170         help.
4171         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4172         from help.
4173         * language.c (add_set_language_command): Remove trailing newline
4174         from help.
4175         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4176         help.
4177         * disasm.c (_initialize_disasm): Remove trailing newline from
4178         help.
4179         * top.c (init_main): Remove trailing newline from help.
4180         * interps.c (_initialize_interpreter): Remove trailing newline
4181         from help.
4182         * btrace.c (_initialize_btrace): Remove trailing newlines from
4183         help.
4184         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4185         from help.
4186         * python/python.c (_initialize_python): Remove trailing newline
4187         from help.
4188         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4189         help.
4190         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4191         from help.  Reformat some text.
4192         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4193         from help.
4194         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4195         newline from help.
4196
4197 2019-06-11  Tom Tromey  <tromey@adacore.com>
4198
4199         * darwin-nat.c (darwin_decode_exception_message)
4200         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4201
4202 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * valops.c (value_slice): Check for not allocated or not
4205         associated values.
4206
4207 2019-06-10  Tom de Vries  <tdevries@suse.de>
4208
4209         PR gdb/24618
4210         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4211         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4212         invalid.
4213
4214 2019-06-10  Tom de Vries  <tdevries@suse.de>
4215
4216         PR gdb/24611
4217         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4218         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4219
4220 2019-06-10  Tom de Vries  <tdevries@suse.de>
4221
4222         PR symtab/24545
4223         * symtab.c (struct demangled_name_entry): Add language field.
4224         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4225         static minimal symbol".  Set and use language field.
4226
4227 2019-06-10  Tom Tromey  <tromey@adacore.com>
4228
4229         * ada-lang.c (_initialize_ada_language): Update help text.
4230
4231 2019-06-10  Tom Tromey  <tromey@adacore.com>
4232
4233         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4234         with a newline.
4235         * guile/guile.c (handle_boot_error): Don't end warning with a
4236         newline.
4237         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4238         warning with a newline.
4239         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4240         newline.
4241         (s12z_frame_cache): Likewise.
4242         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4243         a newline.
4244         * solib-svr4.c (disable_probes_interface): Don't end warning with
4245         a newline.
4246         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4247         newline.
4248         * python/python.c (do_finish_initialization): Don't end warning
4249         with a newline.
4250
4251 2019-06-10  Tom Tromey  <tom@tromey.com>
4252
4253         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4254         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4255         gdbpy_enter.
4256
4257 2019-06-10  Tom Tromey  <tromey@adacore.com>
4258
4259         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4260         data.
4261         (elf_new_init): Don't call stabsread_new_init.
4262         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4263         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4264         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4265
4266 2019-06-10  Tom de Vries  <tdevries@suse.de>
4267
4268         PR symtab/16264
4269         PR symtab/24517
4270         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4271
4272 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4273
4274         * source.c (find_and_open_source): Also rewrite relative file
4275         names.
4276
4277 2019-04-26  Amos Bird  <amosbird@gmail.com>
4278
4279         * annotate.c (annotate_thread_exited): Add "thread-exited"
4280         annotation.
4281
4282 2019-06-06  Tom Tromey  <tromey@adacore.com>
4283
4284         * maint.h (class scoped_command_stats): Use
4285         DISABLE_COPY_AND_ASSIGN.
4286         <print_time>: New method.
4287         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4288         print_time.
4289         (scoped_command_stats::print_time): New method.
4290
4291 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4292
4293         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4294         instructions of lengths 6 or 8 bytes.
4295
4296 2019-06-04  Pedro Alves  <palves@redhat.com>
4297
4298         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4299
4300         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4301         * breakpoint.c (condition_completer): Likewise.
4302         * cli/cli-dump.c (scan_expression): Likewise.
4303         * common/filestuff.c (mkdir_recursive): Likewise.
4304         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4305         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4306         (gdb_abspath): Likewise.
4307         * compile/compile-cplus-types.c
4308         (compile_cplus_instance::decl_name): Likewise.
4309         * completer.c (complete_explicit_location):
4310         (signal_completer, reg_or_group_completer_1): Likewise.
4311         * cp-support.c (cp_remove_params_if_any): Likewise.
4312         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4313         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4314         * infcmd.c (strip_bg_char): Likewise.
4315         * linespec.c (copy_token_string): Likewise.
4316         * mi/mi-main.c (output_cores): Likewise.
4317         * psymtab.c (psymtab_search_name):
4318         * symfile.c (test_set_ext_lang_command): Likewise.
4319         * target.c (target_fileio_read_stralloc): Likewise.
4320         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4321         * value.c (complete_internalvar): Likewise.
4322
4323 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4324
4325         Add objfile property to gdb.Type.
4326         * NEWS: Mention Python API addition.
4327         * python/py-type.c (typy_get_objfile): New method.
4328
4329 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4330
4331         * NEWS: Mention the new set|show style [title|highlight].
4332         Mention changes to "show style", "help" and "apropos".
4333
4334 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4335
4336         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4337         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4338         instead of print_help_for_command.
4339         (print_doc_of_command): New function.
4340         (help_list): Add 'apropos -v word' suggestion.
4341         (print_help_for_command): Style the command name using title style.
4342         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4343         (_initialize_cli_cmds): Describe -v in apropos_command help.
4344
4345 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4346
4347         * cli/cli-style.h (cli_style_option): Add name in constructor,
4348         add m_name class member, add constructor with intensity,
4349         add name class function.
4350         (cli_style_option::add_setshow_commands): Remove name argument.
4351         (highlight_style, title_style): New styles.
4352         * cli/cli-style.c (do_show): New function that shows a style
4353         characteristic styling the style name with itself.
4354         (set_style_name): New function.
4355         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4356         Update all callers according to the changes in cli/cli-style.h.
4357         * utils.h (fputs_highlighted): New function.
4358         * utils.c (fputs_highlighted): Likewise.
4359
4360 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4361
4362         * NEWS: Mention new pipe command and new convenience variables.
4363
4364 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4365
4366         * cli/cli-cmds.c (pipe_command): New function.
4367         (_initialize_cli_cmds): Call add_com for pipe_command.
4368         Define | as an alias for pipe.
4369         (exit_status_set_internal_vars): New function.
4370         (shell_escape): Call exit_status_set_internal_vars.
4371         cli/cli-decode.c (find_command_name_length): Recognize | as
4372         a single character command.
4373
4374 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4375
4376         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4377         top.c (execute_command_to_ui_file): New function, mostly a copy
4378         of execute_command_to_string.
4379         (execute_command_to_string): Implement by calling
4380         execute_command_to_ui_file.
4381
4382 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4383
4384         * top.h (saved_command_line): Remove declaration.
4385         * top.c (previous_saved_command_line, previous_repeat_arguments):
4386         New variables.
4387         (saved_command_line): Make static, define together with other
4388         'repeat variables'.
4389         (dont_repeat): Clear repeat_arguments.
4390         (repeat_previous, get_saved_command_line, save_command_line):
4391         New functions.
4392         (gdb_init): Initialize saved_command_line
4393         and previous_saved_command_line.
4394         * main.c (captured_main_1): Remove saved_command_line initialization.
4395         * event-top.c (handle_line_of_input): Update to use
4396         the new 'repeat' related functions instead of direct access to
4397         saved_command_line.
4398         * command.h (repeat_previous, get_saved_command_line,
4399         save_command_line): New declarations.
4400         (dont_repeat): Add comment.
4401
4402 2019-05-30  Tom Tromey  <tromey@adacore.com>
4403
4404         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4405         Fix comment.
4406         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4407
4408 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4409
4410         PR cli/24587
4411         * completer.c (complete): Initialize variable word.
4412
4413 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4414
4415         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4416         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4417         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4418         'body' is NULL to the outter 'if', protecting the '!is_define'
4419         situation as well.
4420
4421 2019-05-29  Tom Tromey  <tromey@adacore.com>
4422
4423         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4424         (dwarf_unknown): New function.
4425         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4426         (dwarf_type_encoding_name): Use dwarf_unknown.
4427
4428 2019-05-29  Tom Tromey  <tromey@adacore.com>
4429
4430         PR c++/20020:
4431         * cp-valprint.c (cp_print_value_fields): Call
4432         cp_print_static_field inside "try".
4433
4434 2019-05-29  Tom Tromey  <tromey@adacore.com>
4435
4436         * inflow.c (struct terminal_info): Add default operator=.
4437         * configure: Rebuild.
4438         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4439         -Wdeprecated-copy-dtor, -Wredundant-move.
4440
4441 2019-05-29  Tom Tromey  <tromey@adacore.com>
4442
4443         * NEWS: Add entry.
4444         * infcmd.c (print_return_value_1): Handle finish_print
4445         option.
4446         (show_print_finish): New function.
4447         (_initialize_infcmd): Add "set/show print finish" commands.
4448         * valprint.c (user_print_options): Initialize new member.
4449         * valprint.h (struct value_print_options) <finish_print>: New
4450         member.
4451
4452 2019-05-28  Tom Tromey  <tromey@adacore.com>
4453
4454         * ada-lang.c (ada_remove_Xbn_suffix)
4455         (find_old_style_renaming_symbol)
4456         (parse_old_style_renaming): Remove.
4457         (ada_find_renaming_symbol): Don't call
4458         find_old_style_renaming_symbol.
4459         (ada_is_renaming_symbol): Rename from
4460         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4461         bool.  Now static.
4462         (ada_read_var_value): Update and simplify.
4463         * ada-exp.y (write_var_or_type): Remove old code.
4464
4465 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4466
4467         * event-top.c: Remove include comment.
4468         * inflow.c (class scoped_ignore_sigttou): Move from here...
4469         * inflow.h (class scoped_ignore_sigttou): ...to here.
4470         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4471         * top.c:  Remove include comment.
4472
4473 2019-05-27  Tom Tromey  <tom@tromey.com>
4474
4475         * NEWS: Fix typo.
4476
4477 2019-05-22  Tom Tromey  <tromey@adacore.com>
4478
4479         * target.c (target_follow_exec): Constify parameter.
4480         * target-delegates.c: Rebuild.
4481         * remote.c (remote_target::follow_exec): Constify parameter.
4482         * infrun.c (follow_exec): Constify parameter.
4483         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4484         (target_follow_exec): Likewise.
4485
4486 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4487
4488         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4489         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4490
4491 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4492
4493         * NEWS: Add debugredirect and testsuite sections.
4494
4495 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4496
4497         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4498         target descriptions using exclusively floating point register name
4499         aliases.
4500
4501 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         PR gdb/18644:
4504         * f-lang.c (build_fortran_types): Handle the case where
4505         gdbarch_floatformat_for_type returns a nullptr.
4506
4507 2019-05-21  Tom de Vries  <tdevries@suse.de>
4508
4509         PR cli/24587
4510         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4511
4512 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4513
4514         PR gdb/18644:
4515         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4516         16-byte floats.
4517         * i386-tdep.c (i386_floatformat_for_type): Use
4518         floatformats_ia64_quad for the 16-byte floating point component
4519         within a fortran 32-byte complex number.
4520
4521 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4522
4523         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4524         delete default constructor.
4525         (find_partial_die): Update to return const struct.
4526         (partial_die_parent_scope): Move variable declaration into scope
4527         of its use and change its type to auto.
4528         (guess_partial_die_structure_name): Likewise.
4529         (partial_die_info::fixup): Likewise.
4530
4531 2019-05-17  Tom Tromey  <tromey@adacore.com>
4532
4533         * source.c (find_and_open_source): Remove cast.
4534
4535 2019-05-17  Tom Tromey  <tromey@adacore.com>
4536
4537         * annotate.c (annotate_source): Make "filename" const.
4538         * annotate.h (annotate_source): Use const.
4539
4540 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4541
4542         * disasm.c (set_disassembler_options): Send errors to stderr.
4543
4544 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4545
4546         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4547         (cli_interp_base::set_logging): Check debug_redirect.
4548         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4549         * cli/cli-logging.c (debug_redirect): Add static variable.
4550         (pop_output_files): Add default param.
4551         (handle_redirections): Print debug setting.
4552         (show_logging_command): Likewise.
4553         (_initialize_cli_logging): Add debugredirect command.
4554         * interps.c (current_interp_set_logging): Add debug_redirect
4555         parameter.
4556         * interps.h (set_logging): Add debug_redirect parameter.
4557         (current_interp_set_logging): Likewise.
4558         * mi/mi-common.h: Likewise.
4559         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4560
4561 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4562             Tom Tromey  <tromey@adacore.com>
4563
4564         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4565         directly.
4566         * cli/cli-interp.h (make_logging_output): Remove declaration.
4567         * cli/cli-logging.c (make_logging_output): Remove function.
4568         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4569         directly.
4570         * ui-file.c (tee_file::tee_file): Remove bools.
4571         (tee_file::~tee_file): Remove deletes.
4572         * ui-file.h (tee_file): Remove bools.
4573
4574 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4575
4576         * mi/mi-cmds.h (mi_cmd_complete): New function.
4577         * mi/mi-main.c (mi_cmd_complete): Likewise.
4578         * mi/mi-cmds.c: Define new MI command -complete.
4579         * NEWS: Mention new -complete command.
4580
4581 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4582
4583         * completer.h (complete): New function.
4584         * completer.c (complete): Likewise.
4585         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4586         function defined in completer.h.
4587
4588 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4589
4590         * MAINTAINERS (Write After Approval): Add myself.
4591
4592 2019-05-17  Tom de Vries  <tdevries@suse.de>
4593
4594         PR gdb/24094
4595         * dwarf2read.c (struct cu_partial_die_info): New struct.
4596         (find_partial_die): Return cu_partial_die_info.
4597         (partial_die_parent_scope, guess_partial_die_structure_name)
4598         (partial_die_info::fixup): Handle new return type of find_partial_die.
4599
4600 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4601
4602         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4603         "std::string", simplifying the algorithm.
4604
4605 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4606
4607         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4608         (stap_static_probe_ops::get_probes): Likewise.
4609
4610 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4611
4612         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4613         '-')" and "else if".
4614         (stap_parse_single_operand): Join checks for
4615         "gdbarch_stap_parse_special_token_p" and
4616         "gdbarch_stap_parse_special_token" in the same "if" statement.
4617         Invert check when verifying for operation on register
4618         displacement.
4619
4620 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4621
4622         * stap-probe.c (stap_get_opcode): Update comment.
4623         (stap_get_expected_argument_type): Likewise.
4624         (handle_stap_probe): Likewise.
4625
4626 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4627
4628         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4629         return type to 'bool'.  Adjust comment.  Use 'bool' when
4630         appropriate.
4631         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4632         * stap-probe.c (stap_parse_argument_1): Likewise.
4633         (stap_is_operator): Likewise.
4634         (stap_is_generic_prefix): Likewise.
4635         (stap_is_register_prefix): Likewise.
4636         (stap_is_register_indirection_prefix): Likewise.
4637         (stap_is_integer_prefix): Likewise.
4638         (stap_generic_check_suffix): Likewise.
4639         (stap_check_integer_suffix): Likewise.
4640         (stap_check_register_suffix): Likewise.
4641         (stap_check_register_indirection_suffix): Likewise.
4642         (stap_parse_register_operand): Likewise.
4643         (stap_parse_single_operand): Likewise.
4644         (stap_parse_argument_1): Likewise.
4645         (stap_probe::get_argument_count): Likewise.
4646         (stap_is_operator): Likewise.
4647
4648 2019-05-16  Tom Tromey  <tromey@adacore.com>
4649
4650         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4651         keyword to foreach.
4652
4653 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4654
4655         * linux-thread-db.c (try_thread_db_load_1): Change return type
4656         to bool.
4657         (try_thread_db_load): Likewise.
4658         (try_thread_db_load_from_pdir_1): Likewise.
4659         (try_thread_db_load_from_pdir): Likewise.
4660         (try_thread_db_load_from_sdir): Likewise.
4661         (try_thread_db_load_from_dir): Likewise.
4662         (thread_db_load_search): Likewise.
4663         (has_libpthread): Likewise.
4664         (thread_db_load): Likewise.
4665
4666 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4667
4668         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4669         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4670         NULL, and complain/return if that's the case.
4671
4672 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4673
4674         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4675         (advance, posn, abstract_read_memory): New functions.
4676         [struct mem_read_abstraction]: New struct.
4677         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4678
4679 2019-05-14  Tom Tromey  <tromey@adacore.com>
4680
4681         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4682         value is not lval_memory.
4683
4684 2019-05-14  Tom Tromey  <tromey@adacore.com>
4685
4686         * solib.c (info_sharedlibrary_command): Style the file name.
4687
4688 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4689
4690         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4691         (aarch64_vnv_type): Likewise.
4692         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4693         * common/tdesc.c: Likewise.
4694         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4695         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4696         * features/aarch64-fpu.xml: Add ieee half view.
4697         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4698         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4699         * gdbtypes.h (struct builtin_type): Likewise.
4700         (struct objfile_type): Likewise.
4701
4702 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4703
4704         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4705         typo.
4706         * location.h (string_to_event_location): Likewise.
4707
4708 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4709
4710         GDB 8.3 released.
4711
4712 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4713
4714         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4715         New variable declaration.
4716         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4717         New variable.
4718         (print_one_breakpoint): Use ui_out::test_flags and new global
4719         variable to compute use_fixed_output.
4720         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4721         Remove.
4722         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4723         (mi_multi_location_breakpoint_output_fixed): Remove.
4724         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4725         new variable.
4726         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4727         fix_multi_location_breakpoint_output flag if version >= 3.
4728         * ui-out.h (enum ui_out_flag)
4729         <fix_multi_location_breakpoint_output>: New enumerator.
4730
4731 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4732
4733         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4734
4735 2019-05-10  Tom Tromey  <tromey@adacore.com>
4736
4737         * ada-lang.c (catch_ada_completer): New function.
4738         (_initialize_ada_language): Use it.
4739
4740 2019-05-10  Tom Tromey  <tromey@adacore.com>
4741
4742         * thread.c (print_thread_info): Make "requested_threads" const.
4743         * gdbthread.h (print_thread_info): Make "requested_threads"
4744         const.
4745         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4746         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4747
4748 2019-05-08  Tom Tromey  <tom@tromey.com>
4749
4750         * gdbtypes.c (objfile_type_data): Change type.
4751         (objfile_type, _initialize_gdbtypes): Update.
4752
4753 2019-05-08  Tom Tromey  <tom@tromey.com>
4754
4755         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4756         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4757         (_initialize_dwarf2_frame): Update.
4758
4759 2019-05-08  Tom Tromey  <tom@tromey.com>
4760
4761         * objc-lang.c (objc_objfile_data): Change type.
4762         (find_methods): Update.
4763         (_initialize_objc_lang): Remove.
4764
4765 2019-05-08  Tom Tromey  <tom@tromey.com>
4766
4767         * stabsread.c (rs6000_builtin_type_data): Change type.
4768         (rs6000_builtin_type, _initialize_stabsread): Update.
4769
4770 2019-05-08  Tom Tromey  <tom@tromey.com>
4771
4772         * mips-tdep.c (mips_pdr_data): Remove.
4773         (_initialize_mips_tdep): Update.
4774
4775 2019-05-08  Tom Tromey  <tom@tromey.com>
4776
4777         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4778         (hppa_init_objfile_priv_data, read_unwind_info)
4779         (find_unwind_entry, _initialize_hppa_tdep): Update.
4780
4781 2019-05-08  Tom Tromey  <tom@tromey.com>
4782
4783         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4784         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4785         on obstack.
4786         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4787
4788 2019-05-08  Tom Tromey  <tom@tromey.com>
4789
4790         * mdebugread.c (basic_type_data): Change type.
4791         (basic_type, _initialize_mdebugread): Update.
4792
4793 2019-05-08  Tom Tromey  <tom@tromey.com>
4794
4795         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4796
4797 2019-05-08  Tom Tromey  <tom@tromey.com>
4798
4799         * nto-tdep.c (nto_inferior_data_reg): Change type.
4800         (nto_inferior_data): Update.
4801         (nto_inferior_data_cleanup, nto_new_inferior_data)
4802         (_initialize_nto_tdep): Remove.
4803         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4804
4805 2019-05-08  Tom Tromey  <tom@tromey.com>
4806
4807         * ada-lang.c (struct ada_inferior_data): Add initializers.
4808         (ada_inferior_data): Change type.
4809         (ada_inferior_data_cleanup): Remove.
4810         (get_ada_inferior_data, ada_inferior_exit)
4811         (struct ada_pspace_data): Add initializers, destructor.
4812         (ada_pspace_data_handle): Change type.
4813         (get_ada_pspace_data): Update.
4814         (ada_pspace_data_cleanup): Remove.
4815
4816 2019-05-08  Tom Tromey  <tom@tromey.com>
4817
4818         * coffread.c (struct coff_symfile_info): Add initializers.
4819         (coff_objfile_data_key): Move lower.  Change type.
4820         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4821         Update.
4822         (coff_free_info): Remove.
4823
4824 2019-05-08  Tom Tromey  <tom@tromey.com>
4825
4826         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4827         (fbsd_pspace_data_handle): Move lower.  Change type.
4828         (get_fbsd_pspace_data): Update.
4829         (fbsd_pspace_data_cleanup): Remove.
4830         (_initialize_fbsd_tdep): Update.
4831
4832 2019-05-08  Tom Tromey  <tom@tromey.com>
4833
4834         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4835         (get_ada_tasks_pspace_data): Update.
4836         (ada_tasks_pspace_data_cleanup): Remove.
4837         (_initialize_tasks): Update.
4838         (ada_tasks_inferior_data_handle): Change type.
4839         (get_ada_tasks_inferior_data): Update.
4840         (ada_tasks_inferior_data_cleanup): Remove.
4841         (struct ada_tasks_pspace_data): Add initializers.
4842
4843 2019-05-08  Tom Tromey  <tom@tromey.com>
4844
4845         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4846         * symfile-debug.c (debug_sym_get_probes): Change type.
4847         * stap-probe.c (handle_stap_probe):
4848         (stap_static_probe_ops::get_probes): Change type.
4849         * probe.h (class static_probe_ops) <get_probes>: Change type.
4850         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4851         (parse_probes_in_pspace): Update.
4852         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4853         Update.
4854         (any_static_probe_ops::get_probes): Change type.
4855         * elfread.c (elfread_data): New typedef.
4856         (probe_key): Change type.
4857         (elf_get_probes): Likewise.  Update.
4858         (probe_key_free): Remove.
4859         (_initialize_elfread): Update.
4860         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4861         Change type.
4862         (dtrace_process_dof_probe, dtrace_process_dof)
4863         (dtrace_static_probe_ops::get_probe): Change type.
4864
4865 2019-05-08  Tom Tromey  <tom@tromey.com>
4866
4867         * xcoffread.c (struct xcoff_symfile_info): Rename from
4868         coff_symfile_info.  Add initializers.
4869         (xcoff_objfile_data_key): Move lower.  Change type.
4870         (XCOFF_DATA): Rewrite.
4871         (xcoff_free_info): Remove.
4872         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4873         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4874         (xcoff_initial_scan): Update.
4875
4876 2019-05-08  Tom Tromey  <tom@tromey.com>
4877
4878         * solib-svr4.c (struct svr4_info): Add initializers and
4879         destructor.
4880         <probes_table>: Now an htab_up.
4881         (solib_svr4_pspace_data): Change type.
4882         (free_probes_table): Simplify.
4883         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4884         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4885         (probes_table_remove_objfile_probes, register_solib_event_probe)
4886         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4887         (_initialize_svr4_solib): Update.
4888
4889 2019-05-08  Tom Tromey  <tom@tromey.com>
4890
4891         * remote.c (remote_pspace_data): Change type.
4892         (remote_pspace_data_cleanup): Remove.
4893         (get_remote_exec_file, set_pspace_remote_exec_file)
4894         (_initialize_remote): Update.
4895
4896 2019-05-08  Tom Tromey  <tom@tromey.com>
4897
4898         * breakpoint.c (breakpoint_objfile_key): Change type.
4899         (get_breakpoint_objfile_data): Update.
4900         (free_breakpoint_objfile_data): Remove.
4901         (_initialize_breakpoint): Update.
4902
4903 2019-05-08  Tom Tromey  <tom@tromey.com>
4904
4905         * linux-tdep.c (struct linux_info): Add initializers.
4906         (linux_inferior_data): Move.  Change type.
4907         (invalidate_linux_cache_inf): Update.
4908         (linux_inferior_data_cleanup): Remove.
4909         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4910
4911 2019-05-08  Tom Tromey  <tom@tromey.com>
4912
4913         * auxv.c (auxv_inferior_data): Move.  Change type.
4914         (auxv_inferior_data_cleanup): Remove.
4915         (invalidate_auxv_cache_inf): Rewrite.
4916         (get_auxv_inferior_data, _initialize_auxv): Update.
4917
4918 2019-05-08  Tom Tromey  <tom@tromey.com>
4919
4920         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4921         (symfile_debug_objfile_data_key): Change type.
4922         (symfile_debug_installed, debug_qf_has_symbols)
4923         (debug_qf_find_last_source_symtab)
4924         (debug_qf_forget_cached_source_info)
4925         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4926         (debug_qf_print_stats, debug_qf_dump)
4927         (debug_qf_expand_symtabs_for_function)
4928         (debug_qf_expand_all_symtabs)
4929         (debug_qf_expand_symtabs_with_fullname)
4930         (debug_qf_map_matching_symbols)
4931         (debug_qf_expand_symtabs_matching)
4932         (debug_qf_find_pc_sect_compunit_symtab)
4933         (debug_qf_map_symbol_filenames)
4934         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4935         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4936         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4937         (debug_sym_read_linetable, debug_sym_relocate): Update.
4938         (symfile_debug_free_objfile): Remove.
4939         (install_symfile_debug_logging, _initialize_symfile_debug):
4940         Update.
4941
4942 2019-05-08  Tom Tromey  <tom@tromey.com>
4943
4944         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4945         allocate_on_obstack.
4946         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4947         (get_dwarf2_per_objfile): Update.
4948         (set_dwarf2_per_objfile): Remove.
4949         (dwarf2_has_info, dwarf2_get_section_info): Update.
4950         (dwarf2_free_objfile): Remove.
4951         (_initialize_dwarf2_read): Update.
4952
4953 2019-05-08  Tom Tromey  <tom@tromey.com>
4954
4955         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4956         initializers.
4957         <unsupported_script_warning_printed,
4958         script_not_found_warning_printed>: Now bool.
4959         (auto_load_pspace_data): Change type.
4960         (~auto_load_pspace_info): Rename from
4961         auto_load_pspace_data_cleanup.
4962         (get_auto_load_pspace_data, init_loaded_scripts_info)
4963         (clear_section_scripts, maybe_print_unsupported_script_warning)
4964         (maybe_print_script_not_found_warning, _initialize_auto_load):
4965         Update.
4966
4967 2019-05-08  Tom Tromey  <tom@tromey.com>
4968
4969         * objfiles.c (objfile_pspace_info): Add destructor and
4970         initializers.
4971         (objfiles_pspace_data): Change type.
4972         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4973         (get_objfile_pspace_data): Update.
4974         (objfiles_bfd_data): Change type.
4975         (get_objfile_bfd_data): Update.
4976         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4977
4978 2019-05-08  Tom Tromey  <tom@tromey.com>
4979
4980         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4981         Change type.
4982         (get_catch_syscall_inferior_data): Update.
4983         (catch_syscall_inferior_data_cleanup): Remove.
4984         (_initialize_break_catch_syscall): Update.
4985
4986 2019-05-08  Tom Tromey  <tom@tromey.com>
4987
4988         * inflow.c (struct terminal_info): Add destructor and
4989         initializers.
4990         (inflow_inferior_data): Change type.
4991         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4992         (get_inflow_inferior_data, inflow_inferior_exit)
4993         (swap_terminal_info, _initialize_inflow): Update.
4994
4995 2019-05-08  Tom Tromey  <tom@tromey.com>
4996
4997         * target-dcache.c (target_dcache_cleanup): Remove.
4998         (target_dcache_aspace_key): Change type.
4999         (target_dcache_init_p, target_dcache_invalidate)
5000         (target_dcache_get, target_dcache_get_or_init)
5001         (_initialize_target_dcache): Update.
5002         * dcache.h (struct dcache_deleter): New.
5003
5004 2019-05-08  Tom Tromey  <tom@tromey.com>
5005
5006         * symtab.c (struct symbol_cache): Add destructor and
5007         initializers.
5008         (symbol_cache_key): Move.  Change type.
5009         (make_symbol_cache, free_symbol_cache): Remove.
5010         (get_symbol_cache): Update.
5011         (symbol_cache_cleanup): Remove.
5012         (ALL_PSPACES, symbol_cache_flush)
5013         (maintenance_print_symbol_cache)
5014         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5015         Update.
5016
5017 2019-05-08  Tom Tromey  <tom@tromey.com>
5018
5019         * symtab.c (struct main_info): Add destructor and initializers.
5020         (main_progspace_key): Move.  Change type.
5021         (get_main_info): Update.
5022         (main_info_cleanup): Remove.
5023         (_initialize_symtab): Update.
5024
5025 2019-05-08  Tom Tromey  <tom@tromey.com>
5026
5027         * registry.h (DECLARE_REGISTRY): Define the _key class.
5028
5029 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5030
5031         * NEWS: Merge two 'New commands' sections.
5032
5033 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5034
5035         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5036         parameter and use Ada language definition instead.
5037         (ada_val_print_ptr): Remove unused language parameter.
5038         (ada_val_print_num): Remove language parameter and use Ada language
5039         definition instead.
5040         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5041         parameter.
5042         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5043         parameter and use Ada language definition instead.
5044         (ada_val_print_1): Update all ada_val_print_xxx calls.
5045         Remove language parameter.
5046         (ada_val_print): Update ada_val_print_1 call.
5047
5048 2019-05-08  Tom Tromey  <tromey@adacore.com>
5049
5050         * remote.c (remote_hw_watchpoint_limit)
5051         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5052         Now static.
5053
5054 2019-05-08  Tom Tromey  <tromey@adacore.com>
5055
5056         * maint.c (_initialize_maint_cmds): Move initialization code to
5057         remote.c.
5058         (watchdog, show_watchdog): Move to remote.c.
5059         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5060         "watchdog" static.
5061         (_initialize_remote): Move initialization code from maint.c.
5062         * defs.h (watchdog): Don't declare.
5063
5064 2019-05-08  Tom Tromey  <tromey@adacore.com>
5065
5066         * tui/tui-interp.c: Include main.h.
5067         * interps.c: Include main.h.
5068         * main.h (interpreter_p): Declare.
5069         * defs.h (interpreter_p): Don't declare.
5070
5071 2019-05-08  Tom Tromey  <tromey@adacore.com>
5072
5073         * dwarf2loc.c: Include dwarf2read.h.
5074         * defs.h (read_unsigned_leb128): Don't declare.
5075         * dwarf2read.h (read_unsigned_leb128): Declare.
5076
5077 2019-05-08  Tom Tromey  <tromey@adacore.com>
5078
5079         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5080         method.
5081
5082 2019-05-08  Tom Tromey  <tromey@adacore.com>
5083
5084         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5085         when no wrap column is set.
5086
5087 2019-05-08  Tom Tromey  <tromey@adacore.com>
5088
5089         * c-lang.c (c_get_string): Handle non-C-style arrays.
5090
5091 2019-05-08  Tom Tromey  <tromey@adacore.com>
5092
5093         * typeprint.c (print_offset_data::update): Print the bit offset,
5094         not the number of bits remaining.
5095
5096 2019-05-08  Tom Tromey  <tromey@adacore.com>
5097
5098         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5099         padding at end of comment.
5100
5101 2019-05-08  Tom Tromey  <tromey@adacore.com>
5102
5103         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5104         Compare main types.
5105
5106 2019-05-06  Tom Tromey  <tom@tromey.com>
5107
5108         * common/scoped_mmap.c: Include common-defs.h.
5109         * common/scoped_mmap.h: Don't include config.h.
5110
5111 2019-05-04  Tom Tromey  <tom@tromey.com>
5112
5113         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5114         (struct aarch64_call_info): Add initializers.
5115         <si>: Now a std::vector.
5116         (pass_on_stack, aarch64_push_dummy_call): Update.
5117
5118 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5119             Tom Tromey  <tom@tromey.com>
5120
5121         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5122         (ppc_threads): Now a std::vector.  Now static.
5123         (hwdebug_find_thread_points_by_tid)
5124         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5125         Update.
5126
5127 2019-05-04  Tom Tromey  <tom@tromey.com>
5128
5129         * arc-tdep.c (arc_tdesc_init): Return bool.
5130
5131 2019-05-04  Tom Tromey  <tom@tromey.com>
5132
5133         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5134         Use gdb_assert_not_reached.
5135
5136 2019-05-04  Tom Tromey  <tom@tromey.com>
5137
5138         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5139         "false".
5140
5141 2019-05-04  Tom Tromey  <tom@tromey.com>
5142
5143         * arc-tdep.c (arc_tdesc_init): Use bool.
5144
5145 2019-05-04  Tom Tromey  <tom@tromey.com>
5146
5147         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5148
5149 2019-05-04  Tom Tromey  <tom@tromey.com>
5150
5151         * cli/cli-cmds.c (valid_command_p): Return bool.
5152
5153 2019-05-04  Tom Tromey  <tom@tromey.com>
5154
5155         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5156         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5157
5158 2019-05-04  Raul Tambre  <raul@tambre.ee>
5159
5160         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5161         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5162         operator for comparison.
5163
5164 2019-05-04  Tom Tromey  <tom@tromey.com>
5165
5166         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5167         (lookup_partial_symbol, print_partial_symbols)
5168         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5169         (psymbol_compare): Update.
5170         (add_psymbol_to_bcache): Clear the entire psymbol.
5171         (maintenance_check_psymtabs): Update.
5172         * psympriv.h (struct partial_symbol): Don't derive from
5173         general_symbol_info.
5174         <obj_section, unrelocated_address, address,
5175         set_unrelocated_address>: Update.
5176         <ginfo>: New member.
5177         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5178         (debug_names::write_psymbols): Update.
5179
5180 2019-05-04  Tom de Vries  <tdevries@suse.de>
5181
5182         * contrib/cc-with-tweaks.sh: Support -n arg.
5183
5184 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5185
5186         * corelow.c (core_target::detach): Ensure frame cache and
5187         register caches are cleared.
5188         inferior.c (exit_inferior_1): Likewise.
5189
5190 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5191             Tom Tromey  <tom@tromey.com>
5192
5193         * dictionary.c (collate_pending_symbols_by_language): Remove
5194         "struct" from foreach.
5195         * symtab.c (lookup_global_symbol_from_objfile)
5196         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5197         foreach.
5198         * ser-tcp.c (net_open): Remove "struct" from foreach.
5199         * objfiles.c (objfile_relocate, objfile_rebase)
5200         (objfile_has_symbols): Remove "struct" from foreach.
5201         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5202         from foreach.
5203         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5204         foreach.
5205         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5206         "struct" from foreach.
5207         * ada-lang.c (create_excep_cond_exprs)
5208         (ada_exception_catchpoint_cond_string): Remove "struct" from
5209         foreach.
5210
5211 2019-05-03  Tom Tromey  <tromey@adacore.com>
5212
5213         * ada-exp.y (convert_char_literal): Check suffix of each
5214         enumerator.
5215
5216 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5217
5218         PR ada/21406:
5219         * ada-exp.y (yywrap): Don't define.
5220         * ada-lex.l (%option): Add noyywrap
5221         (yywrap): Remove.
5222
5223 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5224
5225         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5226         _WIN32_WINNT to the XP level, unless already defined to a higher
5227         level.
5228
5229         * unittests/parse-connection-spec-selftests.c:
5230         * ser-tcp.c:
5231         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5232         override.
5233
5234         * symfile.c (find_separate_debug_file): Remove colon from the
5235         drive spec of DOS/Windows file names of the target, so that the
5236         file name produced from DEBUGDIR and the target's directory will
5237         be valid on DOS/Windows systems.
5238
5239 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5240
5241         * rust-lang.c (val_print_struct): Handle printing structures
5242         containing strings.
5243
5244 2019-05-02  Tom Tromey  <tromey@adacore.com>
5245
5246         * valarith.c (_initialize_valarith): Remove.
5247
5248 2019-05-01  Tom Tromey  <tromey@adacore.com>
5249
5250         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5251         bitfields.
5252
5253 2019-05-01  Tom Tromey  <tromey@adacore.com>
5254
5255         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5256         for big-endian copies.
5257
5258 2019-04-30  Ali Tamur  <tamur@google.com>
5259         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5260         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5261         (read_3_bytes): New function.
5262
5263 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5264
5265         * windows-nat.c (main_thread_id): Delete.
5266         (handle_output_debug_string): Replace main_thread_id by
5267         current_event.dwThreadId.
5268         (fake_create_process): Likewise.
5269         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5270         Do not set main_thread_id.
5271         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5272         current_event.dwThreadId.
5273         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5274
5275 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5276
5277         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5278         Use current_event.dwThreadId instead of main_thread_id.
5279
5280 2019-04-30  Tom Tromey  <tromey@adacore.com>
5281
5282         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5283         (create_excep_cond_exprs): Iterate over program spaces.
5284         (ada_exception_catchpoint_cond_string): Examine all minimal
5285         symbols for exception types.
5286
5287 2019-04-30  Tom Tromey  <tromey@adacore.com>
5288
5289         PR c++/24470:
5290         * dwarf2read.c (process_structure_scope): Handle case where type
5291         has template parameters but no symbol was created.
5292
5293 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5294             Chris January  <chris.january@arm.com>
5295
5296         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5297         qualifier.
5298         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5299
5300 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5301
5302         * f-typeprint.c (f_print_type): Update rules for printing
5303         whitespace.
5304         (f_type_print_varspec_suffix): Likewise.
5305
5306 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5307             Chris January  <chris.january@arm.com>
5308
5309         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5310         function arguments.
5311
5312 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5313
5314         * f-lang.c (build_fortran_types): Change name of void type to
5315         lower case.
5316         * f-typeprint.c (f_type_print_base): Print the name of the void
5317         type, rather than a fixed string.
5318         * f-valprint.c (f_decorations): Use lower case void string.
5319
5320 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5321             Chris January  <chris.january@arm.com>
5322
5323         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5324         types for Fortran.
5325
5326 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5327             Chris January  <chris.january@arm.com>
5328             David Lecomber  <david.lecomber@arm.com>
5329
5330         * f-exp.y (BINOP_INTRINSIC): New token.
5331         (exp): New parser rule handling BINOP_INTRINSIC.
5332         (f77_keywords): Add new builtin procedures.
5333         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5334         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5335         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5336         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5337         (print_unop_subexp_f): New function.
5338         (print_binop_subexp_f): New function.
5339         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5340         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5341         (dump_subexp_body_f): Likewise.
5342         (operator_check_f): Likewise.
5343         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5344         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5345
5346 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5347
5348         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5349         UNOP_KIND.
5350         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5351         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5352         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5353         (operator_length_f): New fuction.
5354         (print_subexp_f): New function.
5355         (op_name_f): New function.
5356         (dump_subexp_body_f): New function.
5357         (operator_check_f): New function.
5358         (exp_descriptor_f): Replace standard expression handling functions
5359         with new functions.
5360         * gdb/fortran-operator.def: New file.
5361         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5362         * gdb/std-operator.def: Remove UNOP_KIND.
5363
5364 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * std-operator.def: Remove unbalanced, stray double quote
5367         character.
5368
5369 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5370             Chris January  <chris.january@arm.com>
5371             Daniel Everett  <daniel.everett@arm.com>
5372             Nick Forrington  <nick.forrington@arm.com>
5373             Richard Bunt  <richard.bunt@arm.com>
5374
5375         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5376         of depth when printing anonymous structs or unions.
5377         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5378         Don't print either the top-level value, or the children if the
5379         max-depth is exceeded.
5380         (ppscm_print_children): When printing the key of a map, allow one
5381         extra level of depth.
5382         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5383         print either the top-level value, or the children if the max-depth
5384         is exceeded.
5385         (print_children): When printing the key of a map, allow one extra
5386         level of depth.
5387         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5388         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5389         (user_print_options): Initialise max_depth field.
5390         (val_print_scalar_or_string_type_p): New function.
5391         (val_print): Check to see if the max depth has been reached.
5392         (val_print_check_max_depth): Define new function.
5393         (show_print_max_depth): New function.
5394         (_initialize_valprint): Add 'print max-depth' option.
5395         * valprint.h (struct value_print_options) <max_depth>: New field.
5396         (val_print_check_max_depth): Declare new function.
5397         * NEWS: Document new feature.
5398
5399 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * ada-lang.c (ada_language_defn): Initialise new field.
5402         * c-lang.c (c_is_string_type_p): New function.
5403         (c_language_defn): Initialise new field.
5404         (cplus_language_defn): Initialise new field.
5405         (asm_language_defn): Initialise new field.
5406         (minimal_language_defn): Initialise new field.
5407         * c-lang.h (c_is_string_type_p): Declare new function.
5408         * d-lang.c (d_language_defn): Initialise new field.
5409         * f-lang.c (f_is_string_type_p): New function.
5410         (f_language_defn): Initialise new field.
5411         * go-lang.c (go_is_string_type_p): New function.
5412         (go_language_defn): Initialise new field.
5413         * language.c (default_is_string_type_p): New function.
5414         (unknown_language_defn): Initialise new field.
5415         (auto_language_defn): Initialise new field.
5416         * language.h (struct language_defn) <la_is_string_type_p>: New
5417         member variable.
5418         (default_is_string_type_p): Declare new function.
5419         * m2-lang.c (m2_language_defn): Initialise new field.
5420         * objc-lang.c (objc_language_defn): Initialise new field.
5421         * opencl-lang.c (opencl_language_defn): Initialise new field.
5422         * p-lang.c (pascal_is_string_type_p): New function.
5423         (pascal_language_defn): Initialise new field.
5424         * rust-lang.c (rust_is_string_type_p): New function.
5425         (rust_language_defn): Initialise new field.
5426
5427 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5428
5429         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5430         New field.
5431         * ada-lang.c (ada_language_defn): Initialise new field.
5432         * c-lang.c (c_language_defn): Likewise.
5433         (cplus_language_defn): Likewise.
5434         (asm_language_defn): Likewise.
5435         (minimal_language_defn): Likewise.
5436         * d-lang.c (d_language_defn): Likewise.
5437         * f-lang.c (f_language_defn): Likewise.
5438         * go-lang.c (go_language_defn): Likewise.
5439         * language.c (unknown_language_defn): Likewise.
5440         (auto_language_defn): Likewise.
5441         * m2-lang.c (m2_language_defn): Likewise.
5442         * objc-lang.c (objc_language_defn): Likewise.
5443         * opencl-lang.c (opencl_language_defn): Likewise.
5444         * p-lang.c (pascal_language_defn): Likewise.
5445         * rust-lang.c (rust_language_defn): Likewise.
5446
5447 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5448
5449         * ada-lang.c (ada_is_character_type): Change return type to bool.
5450         (ada_is_string_type): Likewise.
5451         * ada-lang.h (ada_is_character_type): Update declaration
5452         (ada_is_string_type): Likewise.
5453
5454 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5455
5456         Support style in 'frame|thread apply'
5457
5458         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5459         * record.c (record_start, record_stop): Update callers of
5460         execute_command_to_string with false.
5461         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5462         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5463         methods.
5464         (class string_file): New constructor with term_out parameter.
5465         Override methods term_out and can_emit_style_escape.  New member
5466         term_out.
5467         (class stdio_file): Override can_emit_style_escape.
5468         (class tee_file): Override term_out and can_emit_style_escape.
5469         * utils.h (can_emit_style_escape): Remove.
5470         * utils.c (can_emit_style_escape): Likewise.
5471         Update all callers of can_emit_style_escape (SOMESTREAM) to
5472         SOMESTREAM->can_emit_style_escape.
5473         * source-cache.c (source_cache::get_source_lines): Likewise.
5474         * stack.c (frame_apply_command_count): Call execute_command_to_string
5475         passing the term_out characteristic of the current gdb_stdout.
5476         * thread.c (thr_try_catch_cmd): Likewise.
5477         * top.c (execute_command_to_string): pass term_out parameter
5478         to construct the string_file for the command output.
5479         * ui-file.c (term_cli_styling): New function (most code moved
5480         from utils.c can_emit_style_escape).
5481         (string_file::string_file, string_file::can_emit_style_escape,
5482         stdio_file::can_emit_style_escape, tee_file::term_out,
5483         tee_file::can_emit_style_escape): New functions.
5484
5485 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5486
5487         * NEWS: Mention the new set|show may-call-functions.
5488         * infcall.c (may_call_functions_p): New variable.
5489         (show_may_call_functions_p): New function.
5490         (call_function_by_hand_dummy): Throws an error if not
5491         may-call-functions.
5492         (_initialize_infcall): Call add_setshow_boolean_cmd for
5493         may-call-functions.
5494
5495 2019-04-25  Keith Seitz  <keiths@redhat.com>
5496
5497         PR c++/24367
5498         * cp-support.c (inspect_type): Don't attempt substitutions
5499         of symbol with the same name.
5500
5501 2019-04-25  Tom Tromey  <tromey@adacore.com>
5502
5503         PR gdb/24475:
5504         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5505         static.
5506
5507 2019-04-25  Tom Tromey  <tromey@adacore.com>
5508
5509         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5510         rvalue reference.
5511         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5512         (gdb_xml_parser::parse): Use std::move.
5513         * python/python-internal.h (gdbpy_convert_exception): Take a const
5514         reference.
5515         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5516         std::move.
5517         * python/py-utils.c (gdbpy_convert_exception): Take a const
5518         reference.
5519         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5520         Use std::move.
5521         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5522         Use std::move.
5523         * mi/mi-main.c (mi_print_exception): Take a const reference.
5524         * main.c (handle_command_errors): Take a const reference.
5525         * linespec.c (parse_linespec): Use std::move.
5526         * infcall.c (run_inferior_call): Use std::move.
5527         (call_function_by_hand_dummy): Use std::move.
5528         * exec.c (try_open_exec_file): Use std::move.
5529         * exceptions.h (exception_print, exception_fprintf)
5530         (exception_print_same): Update.
5531         * exceptions.c (print_exception, exception_print)
5532         (exception_fprintf, exception_print_same): Change parameters to
5533         const reference.
5534         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5535         * common/new-op.c: Use std::move.
5536         * common/common-exceptions.h (struct gdb_exception): Add move
5537         constructor.
5538         (struct gdb_exception_error, struct gdb_exception_quit, struct
5539         gdb_quit_bad_alloc): Change constructor to move constructor.
5540         (throw_exception): Change parameter to rvalue reference.
5541         * common/common-exceptions.c (throw_exception): Take rvalue
5542         reference.
5543         * cli/cli-interp.c (safe_execute_command): Use std::move.
5544         * breakpoint.c (insert_bp_location, location_to_sals): Use
5545         std::move.
5546
5547 2019-04-25  Tom Tromey  <tromey@adacore.com>
5548
5549         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5550         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5551         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5552         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5553         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5554         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5555         guile/scm-value.c: Use unpack.
5556         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5557         gdbscm_gdb_exception.
5558         (gdbscm_throw_gdb_exception): Likewise.
5559         (struct gdbscm_gdb_exception): New.
5560         (unpack): New function.
5561         (gdbscm_wrap): Use unpack.
5562
5563 2019-04-25  Tom Tromey  <tromey@adacore.com>
5564
5565         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5566         (gdb_rl_callback_handler): Use std::move.
5567         * common/common-exceptions.h (struct gdb_exception): Add move
5568         assignment operator.
5569         (throw_exception_sjlj): Change "exception" to const reference.
5570         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5571         (throw_exception_sjlj): Change "exception" to const reference.
5572
5573 2019-04-25  Tom Tromey  <tromey@adacore.com>
5574
5575         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5576         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5577         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5578         Update.
5579         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5580         Update.
5581         * mi/mi-interp.c (mi_interp::exec): Update.
5582         * linespec.c (parse_linespec): Update.
5583         * infcall.c (run_inferior_call): Update.
5584         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5585         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5586         (gdbscm_lookup_global_symbol): Update.
5587         * guile/scm-param.c (gdbscm_parameter_value): Update.
5588         * guile/scm-frame.c (gdbscm_frame_read_register)
5589         (gdbscm_frame_read_var): Update.
5590         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5591         * exec.c (try_open_exec_file): Update.
5592         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5593         (gdb_rl_callback_handler): Update.
5594         * common/common-exceptions.h (exception_none): Don't declare.
5595         * common/common-exceptions.c (exception_none): Don't define.
5596         (struct catcher) <exception>: Update.
5597         * cli/cli-interp.c (safe_execute_command): Update.
5598         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5599
5600 2019-04-25  Ali Tamur  <tamur@google.com>
5601
5602         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5603         (read_attribute_value): Likewise.
5604         (dwarf2_read_addr_index): Update comment.
5605         (read_str_index): Add DW_FORM_strx.
5606         (dwarf2_string_attr): Likewise.
5607         (dwarf2_const_value_attr): Likewise.
5608         (dump_die_shallow): Likewise.
5609         (dwarf2_fetch_constant_bytes): Likewise.
5610         (skip_form_bytes): Likewise.
5611         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5612
5613 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5614
5615         PR corefiles/11608
5616         PR corefiles/18187
5617         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5618         OFFSET.  Verify if current mapping contains an ELF header.
5619         (linux_find_memory_regions_full): Adjust call to
5620         dump_mapping_p.
5621
5622 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5623             Kang Li <kanglictf@gmail.com>
5624
5625         PR gdb/21600
5626
5627         * dwarf2-frame.c (read_initial_length): Be consistent about using
5628         unsigned representation of length.
5629         (decode_frame_entry_1): Likewise.  Check for wraparound of
5630         end pointer as well as buffer overflow.
5631
5632 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5633
5634         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5635         "vq".
5636
5637 2019-04-24  Tom Tromey  <tromey@adacore.com>
5638
5639         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5640
5641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5642
5643         * s12z-tdep.c (s12z_unwind_pc): Delete.
5644         (s12z_unwind_sp): Delete.
5645         (s12z_gdbarch_init): Don't register deleted functions with
5646         gdbarch.
5647
5648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5649
5650         * rl78-tdep.c (rl78_unwind_sp): Delete.
5651         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5652
5653 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5654
5655         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5656         (xstormy16_unwind_pc): Delete.
5657         (xstormy16_dummy_id): Delete.
5658         (xstormy16_gdbarch_init): Don't register deleted functions with
5659         gdbarch.
5660
5661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5662
5663         * vax-tdep.c (vax_unwind_pc): Delete.
5664         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5665
5666 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5667
5668         * v850-tdep.c (v850_unwind_sp): Delete.
5669         (v850_unwind_pc): Delete.
5670         (v850_dummy_id): Delete.
5671         (v850_gdbarch_init): Don't register deleted functions with
5672         gdbarch.
5673
5674 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5675
5676         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5677         (tilegx_unwind_pc): Delete.
5678         (tilegx_unwind_dummy_id): Delete.
5679         (tilegx_gdbarch_init): Don't register deleted functions with
5680         gdbarch.
5681
5682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5683
5684         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5685         (tic6x_dummy_id): Delete.
5686         (tic6x_gdbarch_init): Don't register deleted functions with
5687         gdbarch.
5688
5689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5690
5691         * sparc-tdep.c (sparc_unwind_pc): Delete.
5692         (sparc32_gdbarch_init): Don't register deleted function with
5693         gdbarch.
5694
5695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5696
5697         * sh-tdep.c (sh_unwind_sp): Delete.
5698         (sh_unwind_pc): Delete.
5699         (sh_dummy_id): Delete.
5700         (sh_gdbarch_init): Don't register deleted functions with
5701         gdbarch.
5702
5703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5704
5705         * score-tdep.c (score_unwind_sp): Delete.
5706         (score_unwind_pc): Delete.
5707         (score_dummy_id): Delete.
5708         (score_gdbarch_init): Don't register deleted functions with
5709         gdbarch.
5710
5711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5712
5713         * rx-tdep.c (rx_unwind_pc): Delete.
5714         (rx_unwind_sp): Delete.
5715         (rx_dummy_id): Delete.
5716         (rx_gdbarch_init): Don't register deleted functions with
5717         gdbarch.  Update comment.
5718
5719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5720
5721         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5722         (rs6000_dummy_id): Delete.
5723         (rs6000_gdbarch_init): Don't register deleted functions with
5724         gdbarch.
5725
5726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * or1k-tdep.c (or1k_dummy_id): Delete.
5729         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5730
5731 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5732
5733         * nios2-tdep.c (nios2_dummy_id): Delete.
5734         (nios2_unwind_sp): Delete.
5735         (nios2_gdbarch_init): Don't register deleted functions with
5736         gdbarch.
5737
5738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5739
5740         * nds32-tdep.c (nds32_dummy_id): Delete.
5741         (nds32_unwind_pc): Delete.
5742         (nds32_unwind_sp): Delete.
5743         (nds32_gdbarch_init): Don't register deleted functions with
5744         gdbarch.
5745
5746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5747
5748         * msp430-tdep.c (msp430_unwind_pc): Delete.
5749         (msp430_unwind_sp): Delete.
5750         (msp430_dummy_id): Delete.
5751         (msp430_gdbarch_init): Don't register deleted functions with
5752         gdbarch.
5753
5754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5755
5756         * moxie-tdep.c (moxie_unwind_sp): Delete.
5757         (moxie_unwind_pc): Delete.
5758         (moxie_dummy_id): Delete.
5759         (moxie_gdbarch_init): Don't register deleted functions with
5760         gdbarch.
5761
5762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5763
5764         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5765         (mn10300_unwind_pc): Delete.
5766         (mn10300_unwind_sp): Delete.
5767         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5768         mn10300_unwind_sp.
5769         (mn10300_frame_unwind_init): Don't register deleted functions with
5770         gdbarch.
5771
5772 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5773
5774         * mep-tdep.c (mep_unwind_pc): Delete.
5775         (mep_unwind_sp): Delete.
5776         (mep_dummy_id): Delete.
5777         (mep_gdbarch_init): Don't register deleted functions with
5778         gdbarch.
5779
5780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5781
5782         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5783         (m68hc11_unwind_sp): Delete.
5784         (m68hc11_gdbarch_init): Don't register deleted functions with
5785         gdbarch.
5786
5787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5788
5789         * m32r-tdep.c (m32r_unwind_sp): Delete.
5790         (m32r_unwind_pc): Delete.
5791         (m32r_dummy_id): Delete.
5792         (m32r_gdbarch_init): Don't register deleted functions with
5793         gdbarch.
5794
5795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5796
5797         * m32c-tdep.c (m32c_unwind_pc): Delete.
5798         (m32c_unwind_sp): Delete.
5799         (m32c_dummy_id): Delete.
5800         (m32c_gdbarch_init): Don't register deleted functions with
5801         gdbarch.
5802
5803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5804
5805         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5806         (lm32_unwind_pc): Delete.
5807         (lm32_dummy_id): Delete.
5808         (lm32_gdbarch_init): Don't register deleted functions with
5809         gdbarch.
5810
5811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5812
5813         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5814         (iq2000_unwind_pc): Delete.
5815         (iq2000_dummy_id): Delete.
5816         (iq2000_gdbarch_init): Don't register deleted functions with
5817         gdbarch.
5818
5819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5820
5821         * nds32-tdep.c (nds32_type_align): Delete.
5822         (nds32_push_dummy_call): Use type_align instead.
5823
5824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5825
5826         * arm-tdep.c (arm_type_align): Only handle vector override case.
5827         (arm_push_dummy_call): Use type_align.
5828         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5829
5830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5831
5832         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5833         case.
5834         (pass_on_stack): Use type_align.
5835         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5836         function.
5837
5838 2019-04-23  Tom Tromey  <tromey@adacore.com>
5839
5840         * dwarf2read.c (line_header::file_name_at): Remove unused
5841         overload.
5842
5843 2019-04-23  Tom de Vries  <tdevries@suse.de>
5844
5845         PR gdb/24438
5846         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5847         invocation.
5848
5849
5850 2019-03-27  Ali Tamur  <tamur@google.com>
5851
5852         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5853         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5854         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5855         (dwarf_expr_context::get_addr_index): Likewise
5856         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5857         (symbol_needs_eval_context::get_addr_index): Likewise
5858         (disassemble_dwarf_expression): Add DW_OP_addrx
5859         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5860         (read_cutu_die_from_dwo): Update comment
5861         (skip_one_die): Add DW_FORM_addrx
5862         (read_attribute_value): Likewise
5863         (var_decode_location): Add DW_OP_addrx
5864         (dwarf2_const_value_attr): Add DW_FORM_addrx
5865         (dump_die_shallow): Likewise
5866         (dwarf2_fetch_constant_bytes): Likewise
5867         (decode_locdesc): Add DW_OP_addrx
5868         (skip_form_bytes): Add DW_FORM_addrx
5869
5870 2019-04-22  Ali Tamur  <tamur@google.com>
5871
5872         * MAINTAINERS (Write After Approval): Add self.
5873
5874 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5875
5876         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5877         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5878         (open_symbol_file_object): Likewise.
5879         (svr4_default_sos): Add info parameter.
5880         (svr4_read_so_list): Likewise.
5881         (svr4_current_sos_direct): Adjust functions calls to pass down
5882         info.
5883         (svr4_current_sos_1): Add info parameter.
5884         (svr4_current_sos): Call get_svr4_info, pass info down to
5885         svr4_current_sos_1.
5886         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5887         get_svr4_info.
5888         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5889         get_svr4_info.
5890         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5891         to get_svr4_info.
5892         (probes_table_remove_objfile_probes): Likewise.
5893         (register_solib_event_probe): Add info parameter.
5894         (solist_update_incremental): Pass info parameter down to
5895         svr4_read_so_list.
5896         (disable_probes_interface): Add info parameter.
5897         (svr4_handle_solib_event): Pass current_program_space to
5898         get_svr4_info.  Adjust disable_probes_interface cleanup.
5899         (svr4_create_probe_breakpoints): Add info parameter, pass it
5900         down to register_solib_event_probe.
5901         (svr4_create_solib_event_breakpoints): Add info parameter,
5902         pass it down to svr4_create_probe_breakpoints.
5903         (enable_break): Pass info down to
5904         svr4_create_solib_event_breakpoints.
5905         (svr4_solib_create_inferior_hook): Pass current_program_space to
5906         get_svr4_info.
5907         (svr4_clear_solib): Likewise.
5908
5909 2019-04-22  Pedro Alves  <palves@redhat.com>
5910
5911         * solib-svr4.c (svr4_free_objfile_observer): New.
5912         (probe_and_action::objfile): New field.
5913         (probes_table_htab_remove_objfile_probes)
5914         (probes_table_remove_objfile_probes): New functions.
5915         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5916         in the new probe_and_action.  Don't store the probe in 'lookup'.
5917         (svr4_create_probe_breakpoints): Pass objfile to
5918         register_solib_event_probe.
5919         (_initialize_svr4_solib): Register a free_objfile observer.
5920
5921 2019-04-19  Tom Tromey  <tom@tromey.com>
5922
5923         * common/queue.h: Remove.
5924
5925 2019-04-19  Tom Tromey  <tom@tromey.com>
5926
5927         * event-loop.c: Don't include "common/queue.h".
5928
5929 2019-04-19  Tom Tromey  <tom@tromey.com>
5930
5931         * remote.c (remote_target): Use delete.
5932         * remote-notif.h: Include <list>, not "common/queue.h".
5933         (notif_client_p): Remove typedef.
5934         (remote_notif_state): Add constructor, destructor, initializer.
5935         <notif_queue>: Now a std::list.
5936         (remote_notif_state_xfree): Don't declare.
5937         * remote-notif.c (remote_notif_process, handle_notification)
5938         (remote_notif_state_allocate): Update.
5939         (~remote_notif_state): Rename from remote_notif_state_xfree.
5940
5941 2019-04-19  Tom Tromey  <tom@tromey.com>
5942
5943         * symfile.c (reread_symbols): Update.
5944         * objfiles.c (objfile_register_static_link)
5945         (objfile_lookup_static_link): Update
5946         (~objfile) Don't delete static_links.
5947         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5948
5949 2019-04-19  Tom Tromey  <tom@tromey.com>
5950
5951         * type-stack.h (struct type_stack) <insert>: Constify string.
5952         * type-stack.c (type_stack::insert): Constify string.
5953         * gdbtypes.h (lookup_template_type): Update.
5954         (address_space_name_to_int): Update.
5955         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5956         const.
5957         (lookup_template_type): Make name const.
5958         * c-exp.y: Update rules.
5959         (lex_one_token, classify_name, classify_inner_name)
5960         (c_print_token): Update.
5961         * p-exp.y: Update rules.
5962         (yylex): Update.
5963         * f-exp.y: Update rules.
5964         (yylex): Update.
5965         * d-exp.y: Update rules.
5966         (lex_one_token, classify_name, classify_inner_name): Update.
5967         * parse.c (write_dollar_variable, copy_name): Return std::string.
5968         * parser-defs.h (copy_name): Change return type.
5969         * m2-exp.y: Update rules.
5970         (yylex): Update.
5971         * go-exp.y (lex_one_token): Update.
5972         Update rules.
5973         (classify_unsafe_function, classify_packaged_name)
5974         (classify_name, yylex): Update.
5975
5976 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5977
5978         * configure.ac: add --enable-source-highlight switch.
5979         * configure: Regenerate.
5980         * top.c (print_gdb_version): plumb --enable-source-highlight
5981         status to "show configuration".
5982
5983 2019-04-19  Tom Tromey  <tromey@adacore.com>
5984
5985         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5986         Check ADA_TYPE_P.
5987         (empty_record, ada_template_to_fixed_record_type_1)
5988         (template_to_static_fixed_type)
5989         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5990         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5991         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5992         macros.
5993
5994 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5995
5996         PR symtab/24423:
5997         * source.c (print_source_lines_base): Advance "iter" when a
5998         control character is seen.
5999
6000 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6001
6002         * inferior.h (struct infcall_suspend_state_deleter):
6003         Catch exception in destructor to avoid crash.
6004
6005 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6006
6007         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6008         close to the add_com "shell".
6009
6010 2019-04-18  Tom Tromey  <tromey@adacore.com>
6011
6012         * process-stratum-target.h (class process_stratum_target)
6013         <stratum>: Add "final".
6014
6015 2019-04-17  Tom Tromey  <tromey@adacore.com>
6016
6017         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6018         against nullptr before use.
6019
6020 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6021
6022         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6023
6024 2019-04-17  Jim Wilson  <jimw@sifive.com>
6025             Andrew Burgess  <andrew.burgess@embecosm.com>
6026
6027         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6028         code read might fail, assume 4-byte breakpoint in that case.
6029
6030 2019-04-15  Leszek Swirski  <leszeks@google.com>
6031
6032         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6033         rather than a hand-rolled POD check when checking for forced MEMORY
6034         classification.
6035
6036 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6037
6038         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6039         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6040         function.
6041         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6042         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6043         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6044         declaration.
6045
6046 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6047
6048         * aarch64-linux-nat.c
6049         (aarch64_linux_nat_target::thread_architecture): Add override.
6050         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6051         each VQ.
6052
6053 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6054
6055         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6056
6057 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6058
6059         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6060         target types of size 96-bits, add some additional comments, and
6061         check that the builtin type we found was the correct size.
6062
6063 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6064
6065         * utils.c (prompt_for_continue): Don't restore the styling at the
6066         end, as applied_style has the wrong value.  This fixes styling in
6067         long lists of file names that are interrupted by the "Continue?"
6068         prompt.
6069
6070 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6071
6072         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6073         * c-lang.c (c_language_defn): Likewise.
6074         (cplus_language_defn): Likewise.
6075         (asm_language_defn): Likewise.
6076         (minimal_language_defn): Likewise.
6077         * d-lang.c (d_language_defn): Likewise.
6078         * f-lang.c (f_language_defn): Likewise.
6079         * go-lang.c (go_language_defn): Likewise.
6080         * language.c (unknown_language_defn): Likewise.
6081         (auto_language_defn): Likewise.
6082         * language.h (struct language_defn): Remove la_magic field.
6083         (LANG_MAGIC): Delete.
6084         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6085         * objc-lang.c (objc_language_defn): Likewise.
6086         * opencl-lang.c (opencl_language_defn): Likewise.
6087         * p-lang.c (pascal_language_defn): Likewise.
6088         * rust-lang.c (rust_language_defn): Likewise.
6089
6090 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * riscv-tdep.c (riscv_type_align): New function.
6093         (riscv_type_alignment): Delete.
6094         (riscv_arg_location): Use 'type_align'.
6095         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6096
6097 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6098
6099         * gdbtypes.c (type_align): A struct with no non-static fields also
6100         has alignment of 1.
6101
6102 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6103
6104         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6105         component to 0.
6106         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6107         member.
6108         (riscv_struct_info::analyse): New implementation using new
6109         analyse_inner member function.
6110         (riscv_struct_info::field_offset): New member function.
6111         (riscv_struct_info::m_offsets): New member variable.
6112         (riscv_struct_info::analyse_inner): New private member function,
6113         takes the old implementation of riscv_struct_info::analyse but
6114         extended to track field offsets.
6115         (riscv_call_arg_struct): Update the struct folding special cases
6116         to handle cases where empty C++ structs, which are non-zero
6117         length, are found.
6118         (riscv_arg_location): Initialise the length of each location, a
6119         non-zero length now indicates the location is in use.
6120         (riscv_push_dummy_call): Allow for the first location having a
6121         non-zero offset when setting up arguments.
6122         (riscv_return_value): Likewise, but for return values.
6123
6124 2019-04-11  Tom Tromey  <tromey@adacore.com>
6125
6126         * utils.c (internal_vproblem): Make "msg" const.
6127
6128 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6129
6130         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6131         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6132         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6133         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6134
6135 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6136
6137         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6138         function.
6139         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6140         of amd64_collect_native_gregset.
6141         (amd64_linux_nat_target::store_registers): Likewise.
6142
6143 2019-04-10  Tom Tromey  <tom@tromey.com>
6144
6145         * symtab.c (lookup_global_symbol_from_objfile)
6146         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6147         * objfiles.h (class separate_debug_iterator): New.
6148         (class separate_debug_range): New.
6149         (struct objfile) <separate_debug_objfiles>: New method.
6150         (objfile_separate_debug_iterate): Don't declare.
6151         * objfiles.c (separate_debug_iterator::operator++): Rename from
6152         objfile_separate_debug_iterate.
6153         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6154         iterator.
6155         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6156         iterator.
6157
6158 2019-04-10  Tom Tromey  <tom@tromey.com>
6159
6160         * symfile.c (reread_symbols): Remove old comment.
6161         * objfiles.c (free_all_objfiles): Fix a typo.
6162
6163 2019-04-10  Tom Tromey  <tom@tromey.com>
6164
6165         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6166         * minsyms.c (lookup_minimal_symbol): Use foreach.
6167         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6168         (lookup_minimal_symbol_solib_trampoline): Likewise.
6169         * symfile.c (reread_symbols): Use foreach.
6170
6171 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6172             Tom Tromey  <tromey@adacore.com>
6173
6174         PR rust/24414:
6175         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6176         (rust_lex_int_test): Change "value" to be LONGEST.
6177         (rust_lex_tests): Add test for long integer literal.
6178
6179 2019-04-09  Tom Tromey  <tromey@adacore.com>
6180
6181         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6182         to bool.
6183         (extended_remote_target::attach): Update.
6184         (remote_target::remote_notice_new_inferior): Update.
6185         (remote_target::add_current_inferior_and_thread): Update.
6186         * inferior.c (exit_inferior_1): Use "false".
6187         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6188
6189 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6190
6191         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6192         the "start" command.
6193
6194 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6195
6196         * python/py-inferior.c (infpy_thread_from_thread_handle):
6197         Adjust comments to reflect renaming of thread_from_thread_handle
6198         to thread_from_handle.  Adjust keywords.  Fix type error message.
6199         (inferior_object_methods): Add thread_from_handle.  Retain
6200         thread_from_thread_handle, but mark it as deprecated.
6201
6202 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6203
6204         * gdbthread.h (find_thread_by_handle): Revise declaration.
6205         * thread.c (find_thread_by_handle): Likewise.  Adjust
6206         implementation too.
6207         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6208         support for buffer objects as handles.
6209
6210 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6211
6212         * python/py-infthread.c (thpy_thread_handle): New function.
6213         (thread_object_methods): Register thpy_thread_handle.
6214
6215 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6216
6217         * gdbthread.h (thread_to_thread_handle): Declare.
6218         * thread.c (gdbtypes.h): Include.
6219         (thread_to_thread_handle): New function.
6220
6221         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6222         (target_thread_info_to_thread_handle): Declare.
6223         * target.c (target_thread_info_to_thread_handle): New function.
6224         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6225         * target-delegates.c: Regenerate.
6226
6227         * linux-thread-db.c (class thread_db_target): Add method
6228         thread_info_to_thread_handle.
6229         (thread_db_target::thread_info_to_thread_handle): Define.
6230         * remote.c (class remote_target): Add new method
6231         thread_info_to_thread_handle.
6232         (remote_target::thread_info_to_thread_handle): Define.
6233
6234 2019-04-08  Pedro Alves  <palves@redhat.com>
6235
6236         * common/common-exceptions.c (throw_exception): Don't create
6237         named object to throw; throw directly.
6238         (throw_it): Likewise.  Don't initialize gdb_exception::message
6239         here, with new; pass FMT and AP to the ctor instead.
6240         * common/common-exceptions.h: Include <string>.
6241         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6242         const char *, va_list)): New ctor.  Use std::make_shared.
6243         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6244         errors)): Delete.
6245         (gdb_exception_error::gdb_exception_error(enum errors, const char
6246         *, va_list)): New.
6247         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6248         Add assertion.
6249         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6250         errors)): Delete.
6251         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6252         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6253         Add assertion.
6254
6255 2019-04-08  Tom Tromey  <tom@tromey.com>
6256
6257         * valops.c (value_rtti_indirect_type): Replace throw_exception
6258         with throw.
6259         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6260         with throw.
6261         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6262         throw.
6263         * target.c (target_translate_tls_address): Replace throw_exception
6264         with throw.
6265         * stack.c (frame_apply_command_count): Replace throw_exception
6266         with throw.
6267         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6268         throw.
6269         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6270         with throw.
6271         * rs6000-tdep.c (rs6000_frame_cache)
6272         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6273         * remote.c: Replace throw_exception with throw.
6274         * record-full.c (record_full_message, record_full_wait_1)
6275         (record_full_restore): Replace throw_exception with throw.
6276         * record-btrace.c:
6277         (get_thread_current_frame_id, record_btrace_start_replaying)
6278         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6279         (cmd_record_btrace_start): Replace throw_exception with throw.
6280         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6281         throw.
6282         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6283         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6284         * linespec.c:
6285         (find_linespec_symbols): Replace throw_exception with throw.
6286         * infrun.c (displaced_step_prepare, resume): Replace
6287         throw_exception with throw.
6288         * infcmd.c (post_create_inferior): Replace throw_exception with
6289         throw.
6290         * inf-loop.c (inferior_event_handler): Replace throw_exception
6291         with throw.
6292         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6293         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6294         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6295         (get_prev_frame_always, get_frame_pc_if_available)
6296         (get_frame_address_in_block_if_available, get_frame_language):
6297         Replace throw_exception with throw.
6298         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6299         throw_exception with throw.
6300         * eval.c (fetch_subexp_value, evaluate_var_value)
6301         (evaluate_funcall, evaluate_subexp_standard): Replace
6302         throw_exception with throw.
6303         * dwarf2loc.c (call_site_find_chain)
6304         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6305         Replace throw_exception with throw.
6306         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6307         with throw.
6308         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6309         throw.
6310         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6311         * completer.c (complete_line_internal): Replace throw_exception
6312         with throw.
6313         * compile/compile-object-run.c (compile_object_run): Replace
6314         throw_exception with throw.
6315         * cli/cli-script.c (process_next_line): Replace throw_exception
6316         with throw.
6317         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6318         (btrace_enable, btrace_maint_update_pt_packets): Replace
6319         throw_exception with throw.
6320         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6321         throw_exception with throw.
6322         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6323         throw_exception with throw.
6324         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6325         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6326         * aarch64-tdep.c (aarch64_make_prologue_cache)
6327         (aarch64_make_stub_cache): Replace throw_exception with throw.
6328
6329 2019-04-08  Tom Tromey  <tom@tromey.com>
6330
6331         * common/common-exceptions.c (throw_exception): Rename from
6332         throw_exception_cxx.  Remove old copy.  Make argument const.
6333         (throw_it): Create and throw exception objects directly.
6334         * common/common-exceptions.h (throw_exception): Make argument
6335         const.
6336         (struct gdb_exception_error): Add constructor.
6337         (struct gdb_exception_quit): Add constructor.
6338
6339 2019-04-08  Tom Tromey  <tom@tromey.com>
6340
6341         * common/common-exceptions.h (exception_rethrow): Don't declare.
6342         (TRY_SJLJ): Update comment.
6343         (TRY, CATCH, END_CATCH): Remove.
6344         * common/common-exceptions.c (exception_rethrow): Remove.
6345
6346 2019-04-08  Tom Tromey  <tom@tromey.com>
6347
6348         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6349         Remove.
6350         (gdb_exception_error): Rename from
6351         gdb_exception_RETURN_MASK_ERROR.
6352         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6353         (gdb_quit_bad_alloc): Update.
6354         * aarch64-tdep.c: Update.
6355         * ada-lang.c: Update.
6356         * ada-typeprint.c: Update.
6357         * ada-valprint.c: Update.
6358         * amd64-tdep.c: Update.
6359         * arch-utils.c: Update.
6360         * break-catch-throw.c: Update.
6361         * breakpoint.c: Update.
6362         * btrace.c: Update.
6363         * c-varobj.c: Update.
6364         * cli/cli-cmds.c: Update.
6365         * cli/cli-interp.c: Update.
6366         * cli/cli-script.c: Update.
6367         * common/common-exceptions.c: Update.
6368         * common/new-op.c: Update.
6369         * common/selftest.c: Update.
6370         * compile/compile-c-symbols.c: Update.
6371         * compile/compile-cplus-symbols.c: Update.
6372         * compile/compile-object-load.c: Update.
6373         * compile/compile-object-run.c: Update.
6374         * completer.c: Update.
6375         * corelow.c: Update.
6376         * cp-abi.c: Update.
6377         * cp-support.c: Update.
6378         * cp-valprint.c: Update.
6379         * darwin-nat.c: Update.
6380         * disasm-selftests.c: Update.
6381         * dtrace-probe.c: Update.
6382         * dwarf-index-cache.c: Update.
6383         * dwarf-index-write.c: Update.
6384         * dwarf2-frame-tailcall.c: Update.
6385         * dwarf2-frame.c: Update.
6386         * dwarf2loc.c: Update.
6387         * dwarf2read.c: Update.
6388         * eval.c: Update.
6389         * event-loop.c: Update.
6390         * event-top.c: Update.
6391         * exec.c: Update.
6392         * f-valprint.c: Update.
6393         * fbsd-tdep.c: Update.
6394         * frame-unwind.c: Update.
6395         * frame.c: Update.
6396         * gdbtypes.c: Update.
6397         * gnu-v3-abi.c: Update.
6398         * guile/guile-internal.h: Update.
6399         * guile/scm-block.c: Update.
6400         * guile/scm-breakpoint.c: Update.
6401         * guile/scm-cmd.c: Update.
6402         * guile/scm-disasm.c: Update.
6403         * guile/scm-frame.c: Update.
6404         * guile/scm-lazy-string.c: Update.
6405         * guile/scm-math.c: Update.
6406         * guile/scm-param.c: Update.
6407         * guile/scm-ports.c: Update.
6408         * guile/scm-pretty-print.c: Update.
6409         * guile/scm-symbol.c: Update.
6410         * guile/scm-symtab.c: Update.
6411         * guile/scm-type.c: Update.
6412         * guile/scm-value.c: Update.
6413         * i386-linux-tdep.c: Update.
6414         * i386-tdep.c: Update.
6415         * inf-loop.c: Update.
6416         * infcall.c: Update.
6417         * infcmd.c: Update.
6418         * infrun.c: Update.
6419         * jit.c: Update.
6420         * language.c: Update.
6421         * linespec.c: Update.
6422         * linux-fork.c: Update.
6423         * linux-nat.c: Update.
6424         * linux-tdep.c: Update.
6425         * linux-thread-db.c: Update.
6426         * main.c: Update.
6427         * mi/mi-cmd-break.c: Update.
6428         * mi/mi-cmd-stack.c: Update.
6429         * mi/mi-interp.c: Update.
6430         * mi/mi-main.c: Update.
6431         * objc-lang.c: Update.
6432         * p-valprint.c: Update.
6433         * parse.c: Update.
6434         * ppc-linux-tdep.c: Update.
6435         * printcmd.c: Update.
6436         * python/py-arch.c: Update.
6437         * python/py-breakpoint.c: Update.
6438         * python/py-cmd.c: Update.
6439         * python/py-finishbreakpoint.c: Update.
6440         * python/py-frame.c: Update.
6441         * python/py-framefilter.c: Update.
6442         * python/py-gdb-readline.c: Update.
6443         * python/py-inferior.c: Update.
6444         * python/py-infthread.c: Update.
6445         * python/py-lazy-string.c: Update.
6446         * python/py-linetable.c: Update.
6447         * python/py-objfile.c: Update.
6448         * python/py-param.c: Update.
6449         * python/py-prettyprint.c: Update.
6450         * python/py-progspace.c: Update.
6451         * python/py-record-btrace.c: Update.
6452         * python/py-record.c: Update.
6453         * python/py-symbol.c: Update.
6454         * python/py-type.c: Update.
6455         * python/py-unwind.c: Update.
6456         * python/py-utils.c: Update.
6457         * python/py-value.c: Update.
6458         * python/python.c: Update.
6459         * record-btrace.c: Update.
6460         * record-full.c: Update.
6461         * remote-fileio.c: Update.
6462         * remote.c: Update.
6463         * riscv-tdep.c: Update.
6464         * rs6000-aix-tdep.c: Update.
6465         * rs6000-tdep.c: Update.
6466         * rust-exp.y: Update.
6467         * rust-lang.c: Update.
6468         * s390-tdep.c: Update.
6469         * selftest-arch.c: Update.
6470         * solib-dsbt.c: Update.
6471         * solib-frv.c: Update.
6472         * solib-spu.c: Update.
6473         * solib-svr4.c: Update.
6474         * solib.c: Update.
6475         * sparc64-linux-tdep.c: Update.
6476         * stack.c: Update.
6477         * symfile-mem.c: Update.
6478         * symmisc.c: Update.
6479         * target.c: Update.
6480         * thread.c: Update.
6481         * top.c: Update.
6482         * tracefile-tfile.c: Update.
6483         * tui/tui.c: Update.
6484         * typeprint.c: Update.
6485         * unittests/cli-utils-selftests.c: Update.
6486         * unittests/parse-connection-spec-selftests.c: Update.
6487         * valops.c: Update.
6488         * valprint.c: Update.
6489         * value.c: Update.
6490         * varobj.c: Update.
6491         * windows-nat.c: Update.
6492         * x86-linux-nat.c: Update.
6493         * xml-support.c: Update.
6494
6495 2019-04-08  Tom Tromey  <tom@tromey.com>
6496
6497         * xml-support.c: Use C++ exception handling.
6498         * x86-linux-nat.c: Use C++ exception handling.
6499         * windows-nat.c: Use C++ exception handling.
6500         * varobj.c: Use C++ exception handling.
6501         * value.c: Use C++ exception handling.
6502         * valprint.c: Use C++ exception handling.
6503         * valops.c: Use C++ exception handling.
6504         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6505         handling.
6506         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6507         * typeprint.c: Use C++ exception handling.
6508         * tui/tui.c: Use C++ exception handling.
6509         * tracefile-tfile.c: Use C++ exception handling.
6510         * top.c: Use C++ exception handling.
6511         * thread.c: Use C++ exception handling.
6512         * target.c: Use C++ exception handling.
6513         * symmisc.c: Use C++ exception handling.
6514         * symfile-mem.c: Use C++ exception handling.
6515         * stack.c: Use C++ exception handling.
6516         * sparc64-linux-tdep.c: Use C++ exception handling.
6517         * solib.c: Use C++ exception handling.
6518         * solib-svr4.c: Use C++ exception handling.
6519         * solib-spu.c: Use C++ exception handling.
6520         * solib-frv.c: Use C++ exception handling.
6521         * solib-dsbt.c: Use C++ exception handling.
6522         * selftest-arch.c: Use C++ exception handling.
6523         * s390-tdep.c: Use C++ exception handling.
6524         * rust-lang.c: Use C++ exception handling.
6525         * rust-exp.y: Use C++ exception handling.
6526         * rs6000-tdep.c: Use C++ exception handling.
6527         * rs6000-aix-tdep.c: Use C++ exception handling.
6528         * riscv-tdep.c: Use C++ exception handling.
6529         * remote.c: Use C++ exception handling.
6530         * remote-fileio.c: Use C++ exception handling.
6531         * record-full.c: Use C++ exception handling.
6532         * record-btrace.c: Use C++ exception handling.
6533         * python/python.c: Use C++ exception handling.
6534         * python/py-value.c: Use C++ exception handling.
6535         * python/py-utils.c: Use C++ exception handling.
6536         * python/py-unwind.c: Use C++ exception handling.
6537         * python/py-type.c: Use C++ exception handling.
6538         * python/py-symbol.c: Use C++ exception handling.
6539         * python/py-record.c: Use C++ exception handling.
6540         * python/py-record-btrace.c: Use C++ exception handling.
6541         * python/py-progspace.c: Use C++ exception handling.
6542         * python/py-prettyprint.c: Use C++ exception handling.
6543         * python/py-param.c: Use C++ exception handling.
6544         * python/py-objfile.c: Use C++ exception handling.
6545         * python/py-linetable.c: Use C++ exception handling.
6546         * python/py-lazy-string.c: Use C++ exception handling.
6547         * python/py-infthread.c: Use C++ exception handling.
6548         * python/py-inferior.c: Use C++ exception handling.
6549         * python/py-gdb-readline.c: Use C++ exception handling.
6550         * python/py-framefilter.c: Use C++ exception handling.
6551         * python/py-frame.c: Use C++ exception handling.
6552         * python/py-finishbreakpoint.c: Use C++ exception handling.
6553         * python/py-cmd.c: Use C++ exception handling.
6554         * python/py-breakpoint.c: Use C++ exception handling.
6555         * python/py-arch.c: Use C++ exception handling.
6556         * printcmd.c: Use C++ exception handling.
6557         * ppc-linux-tdep.c: Use C++ exception handling.
6558         * parse.c: Use C++ exception handling.
6559         * p-valprint.c: Use C++ exception handling.
6560         * objc-lang.c: Use C++ exception handling.
6561         * mi/mi-main.c: Use C++ exception handling.
6562         * mi/mi-interp.c: Use C++ exception handling.
6563         * mi/mi-cmd-stack.c: Use C++ exception handling.
6564         * mi/mi-cmd-break.c: Use C++ exception handling.
6565         * main.c: Use C++ exception handling.
6566         * linux-thread-db.c: Use C++ exception handling.
6567         * linux-tdep.c: Use C++ exception handling.
6568         * linux-nat.c: Use C++ exception handling.
6569         * linux-fork.c: Use C++ exception handling.
6570         * linespec.c: Use C++ exception handling.
6571         * language.c: Use C++ exception handling.
6572         * jit.c: Use C++ exception handling.
6573         * infrun.c: Use C++ exception handling.
6574         * infcmd.c: Use C++ exception handling.
6575         * infcall.c: Use C++ exception handling.
6576         * inf-loop.c: Use C++ exception handling.
6577         * i386-tdep.c: Use C++ exception handling.
6578         * i386-linux-tdep.c: Use C++ exception handling.
6579         * guile/scm-value.c: Use C++ exception handling.
6580         * guile/scm-type.c: Use C++ exception handling.
6581         * guile/scm-symtab.c: Use C++ exception handling.
6582         * guile/scm-symbol.c: Use C++ exception handling.
6583         * guile/scm-pretty-print.c: Use C++ exception handling.
6584         * guile/scm-ports.c: Use C++ exception handling.
6585         * guile/scm-param.c: Use C++ exception handling.
6586         * guile/scm-math.c: Use C++ exception handling.
6587         * guile/scm-lazy-string.c: Use C++ exception handling.
6588         * guile/scm-frame.c: Use C++ exception handling.
6589         * guile/scm-disasm.c: Use C++ exception handling.
6590         * guile/scm-cmd.c: Use C++ exception handling.
6591         * guile/scm-breakpoint.c: Use C++ exception handling.
6592         * guile/scm-block.c: Use C++ exception handling.
6593         * guile/guile-internal.h: Use C++ exception handling.
6594         * gnu-v3-abi.c: Use C++ exception handling.
6595         * gdbtypes.c: Use C++ exception handling.
6596         * frame.c: Use C++ exception handling.
6597         * frame-unwind.c: Use C++ exception handling.
6598         * fbsd-tdep.c: Use C++ exception handling.
6599         * f-valprint.c: Use C++ exception handling.
6600         * exec.c: Use C++ exception handling.
6601         * event-top.c: Use C++ exception handling.
6602         * event-loop.c: Use C++ exception handling.
6603         * eval.c: Use C++ exception handling.
6604         * dwarf2read.c: Use C++ exception handling.
6605         * dwarf2loc.c: Use C++ exception handling.
6606         * dwarf2-frame.c: Use C++ exception handling.
6607         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6608         * dwarf-index-write.c: Use C++ exception handling.
6609         * dwarf-index-cache.c: Use C++ exception handling.
6610         * dtrace-probe.c: Use C++ exception handling.
6611         * disasm-selftests.c: Use C++ exception handling.
6612         * darwin-nat.c: Use C++ exception handling.
6613         * cp-valprint.c: Use C++ exception handling.
6614         * cp-support.c: Use C++ exception handling.
6615         * cp-abi.c: Use C++ exception handling.
6616         * corelow.c: Use C++ exception handling.
6617         * completer.c: Use C++ exception handling.
6618         * compile/compile-object-run.c: Use C++ exception handling.
6619         * compile/compile-object-load.c: Use C++ exception handling.
6620         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6621         * compile/compile-c-symbols.c: Use C++ exception handling.
6622         * common/selftest.c: Use C++ exception handling.
6623         * common/new-op.c: Use C++ exception handling.
6624         * cli/cli-script.c: Use C++ exception handling.
6625         * cli/cli-interp.c: Use C++ exception handling.
6626         * cli/cli-cmds.c: Use C++ exception handling.
6627         * c-varobj.c: Use C++ exception handling.
6628         * btrace.c: Use C++ exception handling.
6629         * breakpoint.c: Use C++ exception handling.
6630         * break-catch-throw.c: Use C++ exception handling.
6631         * arch-utils.c: Use C++ exception handling.
6632         * amd64-tdep.c: Use C++ exception handling.
6633         * ada-valprint.c: Use C++ exception handling.
6634         * ada-typeprint.c: Use C++ exception handling.
6635         * ada-lang.c: Use C++ exception handling.
6636         * aarch64-tdep.c: Use C++ exception handling.
6637
6638 2019-04-08  Tom Tromey  <tom@tromey.com>
6639
6640         * xml-support.c (gdb_xml_parser::parse): Update.
6641         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6642         * value.c (show_convenience): Update.
6643         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6644         (test_parse_flags_qcs): Update.
6645         * thread.c (thr_try_catch_cmd): Update.
6646         * target.c (target_translate_tls_address): Update.
6647         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6648         (info_frame_command_core, frame_apply_command_count): Update.
6649         * rust-exp.y (rust_lex_exception_test): Update.
6650         * riscv-tdep.c (riscv_print_one_register_info): Update.
6651         * remote.c (remote_target::enable_btrace): Update.
6652         * record-btrace.c (record_btrace_enable_warn): Update.
6653         * python/py-utils.c (gdbpy_convert_exception): Update.
6654         * printcmd.c (do_one_display, print_variable_and_value): Update.
6655         * mi/mi-main.c (mi_print_exception): Update.
6656         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6657         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6658         * linux-nat.c (linux_nat_target::attach): Update.
6659         * linux-fork.c (class scoped_switch_fork_info): Update.
6660         * infrun.c (displaced_step_prepare): Update.
6661         * infcall.c (call_function_by_hand_dummy): Update.
6662         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6663         * gnu-v3-abi.c (print_one_vtable): Update.
6664         * frame.c (get_prev_frame_always): Update.
6665         * f-valprint.c (info_common_command_for_block): Update.
6666         * exec.c (try_open_exec_file): Update.
6667         * exceptions.c (print_exception, exception_print)
6668         (exception_fprintf, exception_print_same): Update.
6669         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6670         * dwarf-index-cache.c (index_cache::store)
6671         (index_cache::lookup_gdb_index): Update.
6672         * darwin-nat.c (maybe_cache_shell): Update.
6673         * cp-valprint.c (cp_print_value_fields): Update.
6674         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6675         (gcc_cplus_symbol_address): Update.
6676         * compile/compile-c-symbols.c (gcc_convert_symbol)
6677         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6678         * common/selftest.c: Update.
6679         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6680         a std::string.
6681         (exception_try_scope_entry, exception_try_scope_exit): Don't
6682         declare.
6683         (struct exception_try_scope): Remove.
6684         (TRY): Don't use exception_try_scope.
6685         (struct gdb_exception): Add constructor, operator=.
6686         <what>: New method.
6687         (struct gdb_exception_RETURN_MASK_ALL)
6688         (struct gdb_exception_RETURN_MASK_ERROR)
6689         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6690         (struct gdb_quit_bad_alloc): Update.
6691         * common/common-exceptions.c (exception_none): Change
6692         initializer.
6693         (struct catcher) <state, exception>: Initialize inline.
6694         <prev>: Remove member.
6695         (current_catcher): Remove.
6696         (catchers): New global.
6697         (exceptions_state_mc_init): Simplify.
6698         (catcher_pop): Remove.
6699         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6700         (try_scope_depth, exception_try_scope_entry)
6701         (exception_try_scope_exit): Remove.
6702         (throw_exception_sjlj): Update.
6703         (exception_messages, exception_messages_size): Remove.
6704         (throw_it): Simplify.
6705         (gdb_exception_sliced_copy): Remove.
6706         (throw_exception_cxx): Update.
6707         * cli/cli-script.c (script_from_file): Update.
6708         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6709         Update.
6710         * ada-valprint.c (ada_val_print): Update.
6711         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6712         (create_excep_cond_exprs): Update.
6713
6714 2019-04-08  Tom Tromey  <tom@tromey.com>
6715
6716         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6717         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6718         (TRY, CATCH, END_CATCH): Remove some definitions.
6719         * common/common-exceptions.c: Don't use GDB_XCPT.
6720         (catcher_list_size): Remove.
6721         (throw_exception, throw_it): Simplify.
6722
6723 2019-04-05  Tom Tromey  <tom@tromey.com>
6724
6725         Revert the header-sorting patch.
6726         * ft32-tdep.c: Revert.
6727         * frv-tdep.c: Revert.
6728         * frv-linux-tdep.c: Revert.
6729         * frame.c: Revert.
6730         * frame-unwind.c: Revert.
6731         * frame-base.c: Revert.
6732         * fork-child.c: Revert.
6733         * findvar.c: Revert.
6734         * findcmd.c: Revert.
6735         * filesystem.c: Revert.
6736         * filename-seen-cache.h: Revert.
6737         * filename-seen-cache.c: Revert.
6738         * fbsd-tdep.c: Revert.
6739         * fbsd-nat.h: Revert.
6740         * fbsd-nat.c: Revert.
6741         * f-valprint.c: Revert.
6742         * f-typeprint.c: Revert.
6743         * f-lang.c: Revert.
6744         * extension.h: Revert.
6745         * extension.c: Revert.
6746         * extension-priv.h: Revert.
6747         * expprint.c: Revert.
6748         * exec.h: Revert.
6749         * exec.c: Revert.
6750         * exceptions.c: Revert.
6751         * event-top.c: Revert.
6752         * event-loop.c: Revert.
6753         * eval.c: Revert.
6754         * elfread.c: Revert.
6755         * dwarf2read.h: Revert.
6756         * dwarf2read.c: Revert.
6757         * dwarf2loc.c: Revert.
6758         * dwarf2expr.h: Revert.
6759         * dwarf2expr.c: Revert.
6760         * dwarf2-frame.c: Revert.
6761         * dwarf2-frame-tailcall.c: Revert.
6762         * dwarf-index-write.h: Revert.
6763         * dwarf-index-write.c: Revert.
6764         * dwarf-index-common.c: Revert.
6765         * dwarf-index-cache.h: Revert.
6766         * dwarf-index-cache.c: Revert.
6767         * dummy-frame.c: Revert.
6768         * dtrace-probe.c: Revert.
6769         * disasm.h: Revert.
6770         * disasm.c: Revert.
6771         * disasm-selftests.c: Revert.
6772         * dictionary.c: Revert.
6773         * dicos-tdep.c: Revert.
6774         * demangle.c: Revert.
6775         * dcache.h: Revert.
6776         * dcache.c: Revert.
6777         * darwin-nat.h: Revert.
6778         * darwin-nat.c: Revert.
6779         * darwin-nat-info.c: Revert.
6780         * d-valprint.c: Revert.
6781         * d-namespace.c: Revert.
6782         * d-lang.c: Revert.
6783         * ctf.c: Revert.
6784         * csky-tdep.c: Revert.
6785         * csky-linux-tdep.c: Revert.
6786         * cris-tdep.c: Revert.
6787         * cris-linux-tdep.c: Revert.
6788         * cp-valprint.c: Revert.
6789         * cp-support.c: Revert.
6790         * cp-namespace.c: Revert.
6791         * cp-abi.c: Revert.
6792         * corelow.c: Revert.
6793         * corefile.c: Revert.
6794         * continuations.c: Revert.
6795         * completer.h: Revert.
6796         * completer.c: Revert.
6797         * complaints.c: Revert.
6798         * coffread.c: Revert.
6799         * coff-pe-read.c: Revert.
6800         * cli-out.h: Revert.
6801         * cli-out.c: Revert.
6802         * charset.c: Revert.
6803         * c-varobj.c: Revert.
6804         * c-valprint.c: Revert.
6805         * c-typeprint.c: Revert.
6806         * c-lang.c: Revert.
6807         * buildsym.c: Revert.
6808         * buildsym-legacy.c: Revert.
6809         * build-id.h: Revert.
6810         * build-id.c: Revert.
6811         * btrace.c: Revert.
6812         * bsd-uthread.c: Revert.
6813         * breakpoint.h: Revert.
6814         * breakpoint.c: Revert.
6815         * break-catch-throw.c: Revert.
6816         * break-catch-syscall.c: Revert.
6817         * break-catch-sig.c: Revert.
6818         * blockframe.c: Revert.
6819         * block.c: Revert.
6820         * bfin-tdep.c: Revert.
6821         * bfin-linux-tdep.c: Revert.
6822         * bfd-target.c: Revert.
6823         * bcache.c: Revert.
6824         * ax-general.c: Revert.
6825         * ax-gdb.h: Revert.
6826         * ax-gdb.c: Revert.
6827         * avr-tdep.c: Revert.
6828         * auxv.c: Revert.
6829         * auto-load.c: Revert.
6830         * arm-wince-tdep.c: Revert.
6831         * arm-tdep.c: Revert.
6832         * arm-symbian-tdep.c: Revert.
6833         * arm-pikeos-tdep.c: Revert.
6834         * arm-obsd-tdep.c: Revert.
6835         * arm-nbsd-tdep.c: Revert.
6836         * arm-nbsd-nat.c: Revert.
6837         * arm-linux-tdep.c: Revert.
6838         * arm-linux-nat.c: Revert.
6839         * arm-fbsd-tdep.c: Revert.
6840         * arm-fbsd-nat.c: Revert.
6841         * arm-bsd-tdep.c: Revert.
6842         * arch-utils.c: Revert.
6843         * arc-tdep.c: Revert.
6844         * arc-newlib-tdep.c: Revert.
6845         * annotate.h: Revert.
6846         * annotate.c: Revert.
6847         * amd64-windows-tdep.c: Revert.
6848         * amd64-windows-nat.c: Revert.
6849         * amd64-tdep.c: Revert.
6850         * amd64-sol2-tdep.c: Revert.
6851         * amd64-obsd-tdep.c: Revert.
6852         * amd64-obsd-nat.c: Revert.
6853         * amd64-nbsd-tdep.c: Revert.
6854         * amd64-nbsd-nat.c: Revert.
6855         * amd64-nat.c: Revert.
6856         * amd64-linux-tdep.c: Revert.
6857         * amd64-linux-nat.c: Revert.
6858         * amd64-fbsd-tdep.c: Revert.
6859         * amd64-fbsd-nat.c: Revert.
6860         * amd64-dicos-tdep.c: Revert.
6861         * amd64-darwin-tdep.c: Revert.
6862         * amd64-bsd-nat.c: Revert.
6863         * alpha-tdep.c: Revert.
6864         * alpha-obsd-tdep.c: Revert.
6865         * alpha-nbsd-tdep.c: Revert.
6866         * alpha-mdebug-tdep.c: Revert.
6867         * alpha-linux-tdep.c: Revert.
6868         * alpha-linux-nat.c: Revert.
6869         * alpha-bsd-tdep.c: Revert.
6870         * alpha-bsd-nat.c: Revert.
6871         * aix-thread.c: Revert.
6872         * agent.c: Revert.
6873         * addrmap.c: Revert.
6874         * ada-varobj.c: Revert.
6875         * ada-valprint.c: Revert.
6876         * ada-typeprint.c: Revert.
6877         * ada-tasks.c: Revert.
6878         * ada-lang.c: Revert.
6879         * aarch64-tdep.c: Revert.
6880         * aarch64-ravenscar-thread.c: Revert.
6881         * aarch64-newlib-tdep.c: Revert.
6882         * aarch64-linux-tdep.c: Revert.
6883         * aarch64-linux-nat.c: Revert.
6884         * aarch64-fbsd-tdep.c: Revert.
6885         * aarch64-fbsd-nat.c: Revert.
6886         * aarch32-linux-nat.c: Revert.
6887
6888 2019-04-05  Tom Tromey  <tom@tromey.com>
6889
6890         * ft32-tdep.c: Sort headers.
6891         * frv-tdep.c: Sort headers.
6892         * frv-linux-tdep.c: Sort headers.
6893         * frame.c: Sort headers.
6894         * frame-unwind.c: Sort headers.
6895         * frame-base.c: Sort headers.
6896         * fork-child.c: Sort headers.
6897         * findvar.c: Sort headers.
6898         * findcmd.c: Sort headers.
6899         * filesystem.c: Sort headers.
6900         * filename-seen-cache.h: Sort headers.
6901         * filename-seen-cache.c: Sort headers.
6902         * fbsd-tdep.c: Sort headers.
6903         * fbsd-nat.h: Sort headers.
6904         * fbsd-nat.c: Sort headers.
6905         * f-valprint.c: Sort headers.
6906         * f-typeprint.c: Sort headers.
6907         * f-lang.c: Sort headers.
6908         * extension.h: Sort headers.
6909         * extension.c: Sort headers.
6910         * extension-priv.h: Sort headers.
6911         * expprint.c: Sort headers.
6912         * exec.h: Sort headers.
6913         * exec.c: Sort headers.
6914         * exceptions.c: Sort headers.
6915         * event-top.c: Sort headers.
6916         * event-loop.c: Sort headers.
6917         * eval.c: Sort headers.
6918         * elfread.c: Sort headers.
6919         * dwarf2read.h: Sort headers.
6920         * dwarf2read.c: Sort headers.
6921         * dwarf2loc.c: Sort headers.
6922         * dwarf2expr.h: Sort headers.
6923         * dwarf2expr.c: Sort headers.
6924         * dwarf2-frame.c: Sort headers.
6925         * dwarf2-frame-tailcall.c: Sort headers.
6926         * dwarf-index-write.h: Sort headers.
6927         * dwarf-index-write.c: Sort headers.
6928         * dwarf-index-common.c: Sort headers.
6929         * dwarf-index-cache.h: Sort headers.
6930         * dwarf-index-cache.c: Sort headers.
6931         * dummy-frame.c: Sort headers.
6932         * dtrace-probe.c: Sort headers.
6933         * disasm.h: Sort headers.
6934         * disasm.c: Sort headers.
6935         * disasm-selftests.c: Sort headers.
6936         * dictionary.c: Sort headers.
6937         * dicos-tdep.c: Sort headers.
6938         * demangle.c: Sort headers.
6939         * dcache.h: Sort headers.
6940         * dcache.c: Sort headers.
6941         * darwin-nat.h: Sort headers.
6942         * darwin-nat.c: Sort headers.
6943         * darwin-nat-info.c: Sort headers.
6944         * d-valprint.c: Sort headers.
6945         * d-namespace.c: Sort headers.
6946         * d-lang.c: Sort headers.
6947         * ctf.c: Sort headers.
6948         * csky-tdep.c: Sort headers.
6949         * csky-linux-tdep.c: Sort headers.
6950         * cris-tdep.c: Sort headers.
6951         * cris-linux-tdep.c: Sort headers.
6952         * cp-valprint.c: Sort headers.
6953         * cp-support.c: Sort headers.
6954         * cp-namespace.c: Sort headers.
6955         * cp-abi.c: Sort headers.
6956         * corelow.c: Sort headers.
6957         * corefile.c: Sort headers.
6958         * continuations.c: Sort headers.
6959         * completer.h: Sort headers.
6960         * completer.c: Sort headers.
6961         * complaints.c: Sort headers.
6962         * coffread.c: Sort headers.
6963         * coff-pe-read.c: Sort headers.
6964         * cli-out.h: Sort headers.
6965         * cli-out.c: Sort headers.
6966         * charset.c: Sort headers.
6967         * c-varobj.c: Sort headers.
6968         * c-valprint.c: Sort headers.
6969         * c-typeprint.c: Sort headers.
6970         * c-lang.c: Sort headers.
6971         * buildsym.c: Sort headers.
6972         * buildsym-legacy.c: Sort headers.
6973         * build-id.h: Sort headers.
6974         * build-id.c: Sort headers.
6975         * btrace.c: Sort headers.
6976         * bsd-uthread.c: Sort headers.
6977         * breakpoint.h: Sort headers.
6978         * breakpoint.c: Sort headers.
6979         * break-catch-throw.c: Sort headers.
6980         * break-catch-syscall.c: Sort headers.
6981         * break-catch-sig.c: Sort headers.
6982         * blockframe.c: Sort headers.
6983         * block.c: Sort headers.
6984         * bfin-tdep.c: Sort headers.
6985         * bfin-linux-tdep.c: Sort headers.
6986         * bfd-target.c: Sort headers.
6987         * bcache.c: Sort headers.
6988         * ax-general.c: Sort headers.
6989         * ax-gdb.h: Sort headers.
6990         * ax-gdb.c: Sort headers.
6991         * avr-tdep.c: Sort headers.
6992         * auxv.c: Sort headers.
6993         * auto-load.c: Sort headers.
6994         * arm-wince-tdep.c: Sort headers.
6995         * arm-tdep.c: Sort headers.
6996         * arm-symbian-tdep.c: Sort headers.
6997         * arm-pikeos-tdep.c: Sort headers.
6998         * arm-obsd-tdep.c: Sort headers.
6999         * arm-nbsd-tdep.c: Sort headers.
7000         * arm-nbsd-nat.c: Sort headers.
7001         * arm-linux-tdep.c: Sort headers.
7002         * arm-linux-nat.c: Sort headers.
7003         * arm-fbsd-tdep.c: Sort headers.
7004         * arm-fbsd-nat.c: Sort headers.
7005         * arm-bsd-tdep.c: Sort headers.
7006         * arch-utils.c: Sort headers.
7007         * arc-tdep.c: Sort headers.
7008         * arc-newlib-tdep.c: Sort headers.
7009         * annotate.h: Sort headers.
7010         * annotate.c: Sort headers.
7011         * amd64-windows-tdep.c: Sort headers.
7012         * amd64-windows-nat.c: Sort headers.
7013         * amd64-tdep.c: Sort headers.
7014         * amd64-sol2-tdep.c: Sort headers.
7015         * amd64-obsd-tdep.c: Sort headers.
7016         * amd64-obsd-nat.c: Sort headers.
7017         * amd64-nbsd-tdep.c: Sort headers.
7018         * amd64-nbsd-nat.c: Sort headers.
7019         * amd64-nat.c: Sort headers.
7020         * amd64-linux-tdep.c: Sort headers.
7021         * amd64-linux-nat.c: Sort headers.
7022         * amd64-fbsd-tdep.c: Sort headers.
7023         * amd64-fbsd-nat.c: Sort headers.
7024         * amd64-dicos-tdep.c: Sort headers.
7025         * amd64-darwin-tdep.c: Sort headers.
7026         * amd64-bsd-nat.c: Sort headers.
7027         * alpha-tdep.c: Sort headers.
7028         * alpha-obsd-tdep.c: Sort headers.
7029         * alpha-nbsd-tdep.c: Sort headers.
7030         * alpha-mdebug-tdep.c: Sort headers.
7031         * alpha-linux-tdep.c: Sort headers.
7032         * alpha-linux-nat.c: Sort headers.
7033         * alpha-bsd-tdep.c: Sort headers.
7034         * alpha-bsd-nat.c: Sort headers.
7035         * aix-thread.c: Sort headers.
7036         * agent.c: Sort headers.
7037         * addrmap.c: Sort headers.
7038         * ada-varobj.c: Sort headers.
7039         * ada-valprint.c: Sort headers.
7040         * ada-typeprint.c: Sort headers.
7041         * ada-tasks.c: Sort headers.
7042         * ada-lang.c: Sort headers.
7043         * aarch64-tdep.c: Sort headers.
7044         * aarch64-ravenscar-thread.c: Sort headers.
7045         * aarch64-newlib-tdep.c: Sort headers.
7046         * aarch64-linux-tdep.c: Sort headers.
7047         * aarch64-linux-nat.c: Sort headers.
7048         * aarch64-fbsd-tdep.c: Sort headers.
7049         * aarch64-fbsd-nat.c: Sort headers.
7050         * aarch32-linux-nat.c: Sort headers.
7051
7052 2019-04-04  Tom Tromey  <tom@tromey.com>
7053
7054         * varobj.c (varobj_create): Update.
7055         * rust-exp.y (struct rust_parser) <update_innermost_block,
7056         lookup_symbol>: New methods.
7057         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7058         Rename.
7059         (rust_parser::rust_lookup_type)
7060         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7061         * printcmd.c (display_command, do_one_display): Update.
7062         * parser-defs.h (struct parser_state) <parser_state>: Add
7063         "tracker" parameter.
7064         (block_tracker): New member.
7065         (class innermost_block_tracker) <innermost_block_tracker>: Add
7066         "types" parameter.
7067         <reset>: Remove method.
7068         (innermost_block): Don't declare.
7069         (null_post_parser): Update.
7070         * parse.c (innermost_block): Remove global.
7071         (write_dollar_variable): Update.
7072         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7073         Remove "tracker_types" parameter.
7074         (parse_expression): Add "tracker" parameter.
7075         (parse_expression_for_completion): Update.
7076         (null_post_parser): Add "tracker" parameter.
7077         * p-exp.y: Update rules.
7078         * m2-exp.y: Update rules.
7079         * language.h (struct language_defn) <la_post_parser>: Add
7080         "tracker" parameter.
7081         * go-exp.y: Update rules.
7082         * f-exp.y: Update rules.
7083         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7084         parameter.
7085         * d-exp.y: Update rules.
7086         * c-exp.y: Update rules.
7087         * breakpoint.c (set_breakpoint_condition): Create an
7088         innermost_block_tracker.
7089         (watch_command_1): Likewise.
7090         * ada-lang.c (resolve): Add "tracker" parameter.
7091         (resolve_subexp): Likewise.
7092         * ada-exp.y (write_var_from_sym): Update.
7093
7094 2019-04-04  Tom Tromey  <tom@tromey.com>
7095
7096         * type-stack.h: New file.
7097         * type-stack.c: New file.
7098         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7099         type-stack.h.
7100         (insert_into_type_stack, insert_type, push_type, push_type_int)
7101         (insert_type_address_space, pop_type, pop_type_int)
7102         (pop_typelist, pop_type_stack, append_type_stack)
7103         (push_type_stack, get_type_stack, push_typelist)
7104         (follow_type_instance_flags, follow_types): Don't declare.
7105         * parse.c (type_stack): Remove global.
7106         (parse_exp_in_context): Update.
7107         (insert_into_type_stack, insert_type, push_type, push_type_int)
7108         (insert_type_address_space, pop_type, pop_type_int)
7109         (pop_typelist, pop_type_stack, append_type_stack)
7110         (push_type_stack, get_type_stack, push_typelist)
7111         (follow_type_instance_flags, follow_types): Remove (moved to
7112         type-stack.c).
7113         * f-exp.y (type_stack): New global.
7114         Update rules.
7115         (push_kind_type, f_parse): Update.
7116         * d-exp.y (type_stack): New global.
7117         Update rules.
7118         (d_parse): Update.
7119         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7120         Update rules.
7121         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7122         (HFILES_NO_SRCDIR): Add type-stack.h.
7123
7124 2019-04-04  Tom Tromey  <tom@tromey.com>
7125
7126         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7127         (rust_parser::convert_ast_to_expression, rust_parse)
7128         (rust_lex_test_completion, rust_lex_tests): Update.
7129         * parser-defs.h (struct expr_completion_state): New.
7130         (struct parser_state) <parser_state>: Add completion parameter.
7131         <mark_struct_expression, mark_completion_tag>: New methods.
7132         <parse_completion, m_completion_state>: New members.
7133         (prefixify_expression, null_post_parser): Update.
7134         (mark_struct_expression, mark_completion_tag): Don't declare.
7135         * parse.c (parse_completion, expout_last_struct)
7136         (expout_tag_completion_type, expout_completion_name): Remove
7137         globals.
7138         (parser_state::mark_struct_expression)
7139         (parser_state::mark_completion_tag): Now methods.
7140         (prefixify_expression): Add last_struct parameter.
7141         (prefixify_subexp): Likewise.
7142         (parse_exp_1): Update.
7143         (parse_exp_in_context): Add cstate parameter.  Update.
7144         (parse_expression_for_completion): Create an
7145         expr_completion_state.
7146         (null_post_parser): Add "completion" parameter.
7147         * p-exp.y: Update rules.
7148         (yylex): Update.
7149         * language.h (struct language_defn) <la_post_parser>: Add
7150         "completing" parameter.
7151         * go-exp.y: Update rules.
7152         (lex_one_token): Update.
7153         * expression.h (parse_completion): Don't declare.
7154         * d-exp.y: Update rules.
7155         (lex_one_token): Update rules.
7156         * c-exp.y: Update rules.
7157         (lex_one_token): Update.
7158         * ada-lang.c (resolve): Add "parse_completion" parameter.
7159         (resolve_subexp): Likewise.
7160         (ada_resolve_function): Likewise.
7161
7162 2019-04-04  Tom Tromey  <tom@tromey.com>
7163
7164         * parser-defs.h (struct parser_state) <start_arglist,
7165         end_arglist>: New methods.
7166         <arglist_len, m_funcall_chain>: New members.
7167         (arglist_len, start_arglist, end_arglist): Don't declare.
7168         * parse.c (arglist_len, funcall_chain): Remove global.
7169         (start_arglist, end_arglist): Remove functions.
7170         (parse_exp_in_context): Update.
7171         * p-exp.y: Update rules.
7172         * m2-exp.y: Update rules.
7173         * go-exp.y: Update rules.
7174         * f-exp.y: Update rules.
7175         * d-exp.y: Update rules.
7176         * c-exp.y: Update rules.
7177
7178 2019-04-04  Tom Tromey  <tom@tromey.com>
7179
7180         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7181         lex_operator, push_back>: New methods.
7182         Update all rules.
7183         (rust_parser::lex_hex, lex_escape): Rename and update.
7184         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7185         (rust_parser::lex_operator): Rename and update.
7186         (rust_parser::lex_number, rustyylex, rustyyerror)
7187         (rust_lex_test_init, rust_lex_test_sequence)
7188         (rust_lex_test_push_back, rust_lex_tests): Update.
7189         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7190         parameter.
7191         <lexptr, prev_lexptr>: New members.
7192         (lexptr, prev_lexptr): Don't declare.
7193         * parse.c (lexptr, prev_lexptr): Remove globals.
7194         (parse_exp_in_context): Update.
7195         * p-exp.y (yylex, yyerror): Update.
7196         * m2-exp.y (parse_number, yylex, yyerror): Update.
7197         * go-exp.y (lex_one_token, yyerror): Update.
7198         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7199         * d-exp.y (lex_one_token, yyerror): Update.
7200         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7201         (lex_one_token, yyerror): Update.
7202         * ada-lex.l (YY_INPUT): Update.
7203         (rewind_to_char): Update.
7204         * ada-exp.y (yyerror): Update.
7205
7206 2019-04-04  Tom Tromey  <tom@tromey.com>
7207
7208         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7209         * parser-defs.h (struct parser_state) <parser_state>: Add new
7210         parameter.
7211         <comma_terminates>: New member.
7212         (comma_terminates): Don't declare global.
7213         * parse.c (comma_terminates): Remove global.
7214         (parse_exp_in_context): Update.
7215         * p-exp.y (yylex): Update.
7216         * m2-exp.y (yylex): Update.
7217         * go-exp.y (lex_one_token): Update.
7218         * f-exp.y (yylex): Update.
7219         * d-exp.y (lex_one_token): Update.
7220         * c-exp.y (lex_one_token): Update.
7221         * ada-lex.l: Update.
7222
7223 2019-04-04  Tom Tromey  <tom@tromey.com>
7224
7225         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7226         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7227         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7228         * parser-defs.h (paren_depth): Don't declare.
7229         * parse.c (paren_depth): Remove global.
7230         (parse_exp_in_context): Update.
7231         * p-exp.y (paren_depth): New global.
7232         (pascal_parse): Initialize it.
7233         * m2-exp.y (paren_depth): New global.
7234         (m2_parse): Initialize it.
7235         * go-exp.y (paren_depth): New global.
7236         (go_parse): Initialize it.
7237         * f-exp.y (paren_depth): New global.
7238         (f_parse): Initialize it.
7239         * d-exp.y (paren_depth): New global.
7240         (d_parse): Initialize it.
7241         * c-exp.y (paren_depth): New global.
7242         (c_parse): Initialize it.
7243         * ada-lex.l (paren_depth): New global.
7244         (lexer_init): Initialize it.
7245
7246 2019-04-04  Tom Tromey  <tom@tromey.com>
7247
7248         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7249         (rust_parser::convert_ast_to_type)
7250         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7251         * parser-defs.h (struct parser_state) <parser_state>: Add
7252         parameters.  Initialize new members.
7253         <expression_context_block, expression_context_pc>: New members.
7254         * parse.c (expression_context_block, expression_context_pc):
7255         Remove globals.
7256         (parse_exp_in_context): Update.
7257         * p-exp.y: Update all rules.
7258         (yylex): Update.
7259         * m2-exp.y: Update all rules.
7260         (yylex): Update.
7261         * go-exp.y (yylex): Update.
7262         * f-exp.y (yylex): Update.
7263         * d-exp.y: Update all rules.
7264         (yylex): Update.
7265         * c-exp.y: Update all rules.
7266         (lex_one_token, classify_name, yylex, c_parse): Update.
7267         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7268
7269 2019-04-04  Tom Tromey  <tom@tromey.com>
7270
7271         * gdbarch.h, gdbarch.c: Rebuild.
7272         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7273         * stap-probe.h:
7274         (struct stap_parse_info): Replace "parser_state" with
7275         "expr_builder".
7276         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7277         (parser_state): New class.
7278         * parse.c (expr_builder): Rename.
7279         (expr_builder::release): Rename.
7280         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7281         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7282         (write_exp_elt_longcst, write_exp_elt_floatcst)
7283         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7284         (write_exp_string_vector, write_exp_bitstring)
7285         (write_exp_msymbol, mark_struct_expression)
7286         (write_dollar_variable)
7287         (insert_type_address_space, increase_expout_size): Replace
7288         "parser_state" with "expr_builder".
7289         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7290         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7291         "parser_state" with "expr_builder".
7292
7293 2019-04-04  Tom Tromey  <tom@tromey.com>
7294
7295         * rust-exp.y: Replace "parse_language" with method call.
7296         * p-exp.y:
7297         (yylex): Replace "parse_language" with method call.
7298         * m2-exp.y:
7299         (yylex): Replace "parse_language" with method call.
7300         * go-exp.y (classify_name): Replace "parse_language" with method
7301         call.
7302         * f-exp.y (yylex): Replace "parse_language" with method call.
7303         * d-exp.y (lex_one_token): Replace "parse_language" with method
7304         call.
7305         * c-exp.y:
7306         (lex_one_token, classify_name, yylex): Replace "parse_language"
7307         with method call.
7308         * ada-exp.y (find_primitive_type, type_char)
7309         (type_system_address): Replace "parse_language" with method call.
7310
7311 2019-04-04  Tom Tromey  <tom@tromey.com>
7312
7313         * rust-exp.y: Replace "parse_gdbarch" with method call.
7314         * parse.c (write_dollar_variable, insert_type_address_space):
7315         Replace "parse_gdbarch" with method call.
7316         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7317         call.
7318         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7319         call.
7320         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7321         "parse_gdbarch" with method call.
7322         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7323         with method call.
7324         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7325         "parse_gdbarch" with method call.
7326         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7327         "parse_gdbarch" with method call.
7328         * c-exp.y (parse_type, parse_number, classify_name): Replace
7329         "parse_gdbarch" with method call.
7330         * ada-lex.l: Replace "parse_gdbarch" with method call.
7331         * ada-exp.y (parse_type, find_primitive_type, type_char)
7332         (type_system_address): Replace "parse_gdbarch" with method call.
7333
7334 2019-04-04  Tom Tromey  <tom@tromey.com>
7335
7336         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7337         * stap-probe.c (stap_parse_argument): Update.
7338         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7339         initial_size parameter.
7340         * rust-exp.y (rust_lex_tests): Update.
7341         * parse.c (parser_state): Update.
7342         (parse_exp_in_context): Update.
7343         * parser-defs.h (struct parser_state) <parser_state>: Remove
7344         "initial_size" parameter.
7345
7346 2019-04-04  Tom Tromey  <tom@tromey.com>
7347
7348         * parser-defs.h (increase_expout_size): Don't declare.
7349         * parse.c (increase_expout_size): Now static.
7350
7351 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7352
7353         * gnu-nat.c (gnu_nat_target::wait): Fix
7354         target_waitstatus_to_string call.
7355
7356 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7357
7358         * eval.c (evaluate_subexp_standard): Handle internal functions
7359         during Fortran function call handling.
7360
7361 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7362
7363         * NEWS: Mention new internal functions.
7364         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7365         (read_base_type): Use dwarf2_init_complex_target_type.
7366         * value.c (creal_internal_fn): New function.
7367         (cimag_internal_fn): New function.
7368         (_initialize_values): Register new internal functions.
7369
7370 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7371
7372         * infrun.c (stop_all_threads): If debug_infrun, always
7373         trace the wait status after wait_one, using
7374         target_waitstatus_to_string and target_pid_to_str.
7375         (handle_inferior_event): Replace various trace of
7376         wait status kind by a single trace.
7377         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7378         wait status kind image by target_waitstatus_to_string.
7379         * target/waitstatus.c (target_waitstatus_to_string): Fix
7380         obsolete comment.
7381
7382 2019-04-01  Tom Tromey  <tromey@adacore.com>
7383
7384         PR symtab/23331:
7385         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7386
7387 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7388             Pedro Alves  <palves@redhat.com>
7389
7390         * top.c (quit_force): Call 'finalize_values'.
7391         * value.c (finalize_values): New function.
7392         * value.h (finalize_values): Declare.
7393
7394 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7395
7396         * NEWS: Announce $_gdb_major and $_gdb_minor.
7397
7398         * top.c (init_gdb_version_vars): New function.
7399         (gdb_init): Call init_gdb_version_vars.
7400
7401 2019-03-29  Tom Tromey  <tromey@adacore.com>
7402
7403         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7404         help text.  Remove dead code.
7405
7406 2019-03-29  Keith Seitz  <keiths@redhat.com>
7407
7408         From Siddhesh Poyarekar:
7409         * f-lang.h (f77_get_upperbound): Return LONGEST.
7410         (f77_get_lowerbound): Likewise.
7411         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7412         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7413         print them.
7414         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7415         plongest to format print it.
7416         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7417         (f77_get_upperbound): Likewise.
7418         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7419         LOWER_BOUND to LONGEST.
7420         (f77_create_arrayprint_offset_tbl): Likewise.
7421
7422 2019-03-29  Keith Seitz  <keiths@redhat.com>
7423
7424         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7425         %s/pulongest for TYPE_LENGTH instead of %d in format
7426         strings.
7427         * ada-typerint.c (ada_print_type): Likewise.
7428         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7429         * compile/compile-c-support.c (generate_register_struct): Likewise.
7430         * gdbtypes.c (recursive_dump_type): Likewise.
7431         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7432         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7433         instead of %d in format strings.
7434         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7435         to std::min to ULONGEST.
7436         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7437         instead of %d in format strings.
7438         * tracepoint.c (info_scope_command): Likewise.
7439         * typeprint.c (print_offset_data::update)
7440         (print_offset_data::finish): Likewise.
7441         * xtensa-tdep.c (xtensa_store_return_value)
7442         (xtensa_push_dummy_call): Likewise.
7443
7444 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7445
7446         * windows-nat.c (display_selector): Fixed format specifications
7447         for 64-bit Cygwin.
7448
7449 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7450
7451         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7452
7453 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7454
7455         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7456         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7457         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7458         (nios2_linux_init_abi): Install it.
7459
7460 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7461
7462         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7463
7464 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7465
7466         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7467
7468 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7469             Tom Tromey  <tromey@adacore.com>
7470
7471         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7472
7473 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7474
7475         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7476         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7477         method to compute the bounds of range types. Also print "[evaluated]"
7478         if the bounds' values come from a dynamic evaluation.
7479
7480 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7481
7482         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7483         whitespace when pretty printing is on.
7484
7485 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7486
7487         * ppc-linux-nat.c: Add include.
7488
7489 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7490
7491         * NEWS: Mention AArch64 Pointer Authentication.
7492
7493 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7494
7495         * arm-linux-nat.c: Add include.
7496
7497 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7498
7499         * source-cache.c (source_cache::get_source_lines): Re-read
7500         fullname after calling open_source_file.
7501
7502 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7503
7504         * NEWS: Mention TLS support for FreeBSD.
7505
7506 2019-03-25  Tom Tromey  <tromey@adacore.com>
7507
7508         * minsyms.c (BUNCH_SIZE): Update comment.
7509         (~minimal_symbol_reader): Remove old comment.
7510         (compact_minimal_symbols): Update comment.
7511         (minimal_symbol_reader::install): Remove old comment.  Update
7512         other comments.
7513
7514 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7515
7516         * s390-linux-nat.c: Add include.
7517
7518 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7519
7520         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7521         Call linux_get_hwcap.
7522         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7523         Likewise.
7524         (aarch64_linux_get_hwcap): Remove function.
7525         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7526         declaration.
7527         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7528         linux_get_hwcap.
7529         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7530         * linux-tdep.c (linux_get_hwcap): Add function.
7531         (linux_get_hwcap2): Likewise.
7532         * linux-tdep.h (linux_get_hwcap): Add declaration.
7533         (linux_get_hwcap2): Likewise.
7534         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7535         (ppc_linux_get_hwcap2): Likewise.
7536         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7537         linux_get_hwcap.
7538         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7539         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7540         (ppc_linux_nat_target::read_description): Likewise.
7541         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7542         * s390-linux-nat.c: Likewise.
7543         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7544
7545 2019-03-24  Tom Tromey  <tom@tromey.com>
7546
7547         * ada-lang.c (standard_lookup): Simplify initialization.
7548         (ada_lookup_symbol_nonlocal): Simplify return.
7549         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7550         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7551         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7552         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7553         initialization.
7554         * solib.c (solib_global_lookup): Simplify.
7555         * symtab.c (null_block_symbol): Remove.
7556         (symbol_cache_lookup): Simplify returns.
7557         (lookup_language_this): Simplify returns.
7558         (lookup_symbol_aux): Simplify return.
7559         (lookup_local_symbol): Simplify returns.
7560         (lookup_global_symbol_from_objfile): Simplify return.
7561         (lookup_symbol_in_objfile_symtabs)
7562         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7563         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7564         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7565         * cp-namespace.c (cp_lookup_bare_symbol)
7566         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7567         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7568         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7569         (cp_lookup_symbol_via_imports): Simplify initialization.
7570         (find_symbol_in_baseclass): Likewise.
7571         * symtab.h (null_block_symbol): Remove.
7572         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7573         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7574         (d_lookup_symbol_module): Likewise.
7575         (find_symbol_in_baseclass): Simplify initialization.
7576
7577 2019-03-24  Tom Tromey  <tom@tromey.com>
7578
7579         * expression.h: Don't include symtab.h.
7580         (struct block): Forward declare.
7581
7582 2019-03-24  Tom Tromey  <tom@tromey.com>
7583
7584         * c-exp.y (typebase): Remove casts.
7585         * gdbtypes.c (lookup_unsigned_typename, )
7586         (lookup_signed_typename): Remove cast.
7587         * eval.c (parse_to_comma_and_eval): Remove cast.
7588         * parse.c (write_dollar_variable): Remove cast.
7589         * block.h (struct block) <superblock>: Now const.
7590         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7591         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7592         (map_block): Make "block" const.
7593         * symfile.h (struct quick_symbol_functions)
7594         <map_matching_symbols>: Constify block argument to "callback".
7595         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7596         const.
7597         (find_pc_sect_compunit_symtab): Make "b" const.
7598         (find_symbol_at_address): Likewise.
7599         (search_symbols): Likewise.
7600         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7601         (dw2_debug_names_lookup_symbol): Likewise.
7602         (dw2_map_matching_symbols): Update.
7603         * p-valprint.c (pascal_val_print): Remove "block".
7604         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7605         (aux_add_nonlocal_symbols): Make "block" const.
7606         (resolve_subexp): Remove cast.
7607         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7608         const.
7609         (iterate_over_file_blocks): Likewise.
7610         * f-exp.y (%union) <bval>: Remove.
7611         * coffread.c (patch_opaque_types): Make "b" const.
7612         * spu-tdep.c (spu_catch_start): Make "block" const.
7613         * c-valprint.c (print_unpacked_pointer): Remove "block".
7614         * symmisc.c (dump_symtab_1): Make "b" const.
7615         (block_depth): Make "block" const.
7616         * d-exp.y (%union) <bval>: Remove.
7617         * cp-support.h (cp_lookup_rtti_type): Update.
7618         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7619         * psymtab.c (psym_lookup_symbol): Make "block" const.
7620         (maintenance_check_psymtabs): Make "b" const.
7621         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7622         (enumerate_locals, enumerate_args): Update.
7623         * python/py-symtab.c (stpy_global_block): Make "block" const.
7624         (stpy_static_block): Likewise.
7625         * inline-frame.c (block_starting_point_at): Make "new_block"
7626         const.
7627         * block.c (find_block_in_blockvector): Make return type const.
7628         (blockvector_for_pc_sect): Make "b" const.
7629         (find_block_in_blockvector): Make "b" const.
7630
7631 2019-03-23  Tom Tromey  <tom@tromey.com>
7632
7633         * varobj.c (varobj_create): Update.
7634         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7635         * printcmd.c (display_command, do_one_display): Don't reset
7636         innermost_block.
7637         * parser-defs.h (enum innermost_block_tracker_type): Move to
7638         expression.h.
7639         (innermost_block): Update comment.
7640         * parse.c (parse_exp_1): Add tracker_types parameter.
7641         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7642         tracker_types parameter.  Reset innermost_block.
7643         (parse_exp_in_context): Remove.
7644         (parse_expression_for_completion): Update.
7645         * objfiles.c (~objfile): Don't reset expression_context_block or
7646         innermost_block.
7647         * expression.h (enum innermost_block_tracker_type): Move from
7648         parser-defs.h.
7649         (parse_exp_1): Add tracker_types parameter.
7650         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7651         reset innermost_block.
7652
7653 2019-03-23  Tom Tromey  <tom@tromey.com>
7654
7655         * objfiles.h: Include bcache.h.
7656
7657 2019-03-23  Tom Tromey  <tom@tromey.com>
7658
7659         * linespec.c (get_current_search_block): Use
7660         scoped_restore_current_language.
7661         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7662
7663 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7664             Jiong Wang  <jiong.wang@arm.com>
7665
7666         * aarch64-linux-tdep.c
7667         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7668         section.
7669         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7670
7671 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7672             Jiong Wang  <jiong.wang@arm.com>
7673
7674         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7675         instructions.
7676         (aarch64_analyze_prologue_test): Add PACIASP test.
7677         (aarch64_prologue_prev_register): Unmask PC value.
7678
7679 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7680             Jiong Wang  <jiong.wang@arm.com>
7681
7682         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7683         (aarch64_dwarf2_prev_register): Unmask PC value.
7684         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7685         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7686         DW_CFA_AARCH64_negate_ra_state.
7687         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7688
7689 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7690             Jiong Wang  <jiong.wang@arm.com>
7691
7692         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7693         registers.
7694         (aarch64_pseudo_register_name): Likewise.
7695         (aarch64_pseudo_register_type): Likewise.
7696         (aarch64_pseudo_register_reggroup_p): Likewise.
7697         (aarch64_gdbarch_init): Add pauth registers.
7698         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7699         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7700         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7701         (struct gdbarch_tdep): Add regnum for ra_state.
7702
7703 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7704             Jiong Wang  <jiong.wang@arm.com>
7705
7706         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7707
7708 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7709             Jiong Wang  <jiong.wang@arm.com>
7710
7711         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7712         function.
7713         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7714         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7715         (aarch64_gdbarch_init): Add puth registers.
7716         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7717         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7718         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7719
7720 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7721             Jiong Wang  <jiong.wang@arm.com>
7722
7723         * aarch64-linux-nat.c
7724         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7725         * aarch64-linux-tdep.c
7726         (aarch64_linux_core_read_description): Likewise.
7727         (aarch64_linux_get_hwcap): New function.
7728         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7729         (aarch64_linux_get_hwcap): New declaration.
7730
7731 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7732             Jiong Wang  <jiong.wang@arm.com>
7733
7734         * aarch64-linux-nat.c
7735         (aarch64_linux_nat_target::read_description): Add pauth param.
7736         * aarch64-linux-tdep.c
7737         (aarch64_linux_core_read_description): Likewise.
7738         * aarch64-tdep.c (struct target_desc): Add in pauth.
7739         (aarch64_read_description): Add pauth param.
7740         (aarch64_gdbarch_init): Likewise.
7741         * aarch64-tdep.h (aarch64_read_description): Likewise.
7742         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7743         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7744         * features/Makefile: Add new files.
7745         * features/aarch64-pauth.c: New file.
7746         * features/aarch64-pauth.xml: New file.
7747
7748 2019-03-20  Tom Tromey  <tromey@adacore.com>
7749
7750         * infrun.c (handle_inferior_event): Rename from
7751         handle_inferior_event_1.  Create a scoped_value_mark.
7752         (handle_inferior_event): Remove.
7753
7754 2019-03-19  Tom Tromey  <tromey@adacore.com>
7755
7756         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7757         * infrun.h (print_stop_event): Add "displays" parameter.
7758         * infrun.c (print_stop_event): Add "displays" parameter.
7759
7760 2019-03-19  Pedro Alves  <palves@redhat.com>
7761
7762         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7763         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7764         to -1.  Fix TABs vs spaces.
7765         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7766         * tui/tui-out.h (tui_ui_out) Add intro comments.
7767         <m_line, m_start_of_line>: In-class initialize, and add describing
7768         comment.
7769
7770 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7771
7772         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7773         variable names.
7774         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7775
7776 2019-03-18  Pedro Alves  <palves@redhat.com>
7777             Eli Zaretskii <eliz@gnu.org>
7778
7779         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7780         m_line and m_start_of_line.
7781
7782 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7783
7784         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7785         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7786         it returns a newline.  This fixes a regression in TU mode, whereby
7787         the next line is output on the same screen line as the user input.
7788
7789 2019-03-18  Tom Tromey  <tromey@adacore.com>
7790
7791         * minsyms.c (minimal_symbol_reader::install): Remove call to
7792         obstack_blank.
7793
7794 2019-03-18  Pedro Alves  <palves@redhat.com>
7795
7796         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7797         New globals.
7798         (apply_style): New, factored out from ...
7799         (apply_ansi_escape): ... this.  Handle reverse video mode.
7800         (tui_set_reverse_mode): New function.
7801         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7802         * tui/tui-winsource.c (tui_show_source_line): Use
7803         tui_set_reverse_mode instead of setting A_STANDOUT.
7804         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7805         New setter methods.
7806
7807 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7808
7809         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7810         Handle tabs.
7811
7812 2019-03-18  Tom Tromey  <tromey@adacore.com>
7813
7814         * ada-lang.c (empty_array): Add "high" parameter.
7815         (ada_evaluate_subexp): Update.
7816
7817 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7818
7819         * unittests/string_view-selftests.c: Define
7820         _initialize_string_view_selftests unconditionally.
7821
7822 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7823
7824         PR gdb/24350
7825         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7826
7827 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7828
7829         PR gdb/24351
7830         * windows-nat.c (display_selector): Fix format specifiers.
7831
7832 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7833
7834         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7835         tui_refill_source_window instead of tui_refresh_win, to update the
7836         current execution line.  This fixes redisplay of the current line
7837         when stepping through the code with "next" or "step".
7838
7839 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7840
7841         * source-cache.c (source_cache::get_source_lines): Call
7842         find_source_lines to initialize s->nlines.  This fixes vertical
7843         scrolling of TUI source window when the DOWN arrow is pressed.
7844
7845 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7846
7847         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7848         linux-thread-db.c (_initialize_thread_db): Likewise.
7849
7850 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7851
7852         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7853         wclrtoeol in tui_show_source_line".  This reverts changes made in
7854         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7855
7856 2019-03-15  Tom Tromey  <tom@tromey.com>
7857
7858         * symtab.h (struct minimal_symbol): Derive from
7859         general_symbol_info.
7860         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7861         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7862         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7863         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7864         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7865         (MSYMBOL_SEARCH_NAME): Update.
7866         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7867         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7868         * minsyms.c (minimal_symbol_reader::record_full): Update.
7869
7870 2019-03-15  Tom Tromey  <tom@tromey.com>
7871
7872         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7873
7874 2019-03-15  Tom Tromey  <tom@tromey.com>
7875
7876         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7877         unique_xmalloc_ptr.
7878         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7879         Update.
7880         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7881         (build_minimal_symbol_hash_tables)
7882         (minimal_symbol_reader::install): Update.
7883
7884 2019-03-15  Tom Tromey  <tom@tromey.com>
7885
7886         * symtab.c (create_demangled_names_hash): Update.
7887         (symbol_set_names): Update.
7888         * objfiles.h (struct objfile_per_bfd_storage)
7889         <demangled_names_hash>: Now an htab_up.
7890         * objfiles.c (objfile_per_bfd_storage): Simplify.
7891
7892 2019-03-15  Tom Tromey  <tom@tromey.com>
7893
7894         * objfiles.h (struct objfile_per_bfd_storage): Declare
7895         destructor.
7896         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7897         New.
7898         (get_objfile_bfd_data): Use new.  Don't initialize
7899         language_of_main.
7900         (free_objfile_per_bfd_storage): Remove.
7901         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7902
7903 2019-03-15  Tom Tromey  <tom@tromey.com>
7904
7905         * symfile.c (reread_symbols): Update.
7906         * objfiles.c (objfile::objfile): Update.
7907         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7908         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7909         comment.
7910         (minimal_symbol_reader::install): Update.
7911         (terminate_minimal_symbol_table): Remove.
7912         * jit.c (jit_object_close_impl): Update.
7913
7914 2019-03-15  Tom Tromey  <tom@tromey.com>
7915
7916         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7917         initializations.
7918
7919 2019-03-15  Tom Tromey  <tom@tromey.com>
7920
7921         * objfiles.h (struct objfile_per_bfd_storage)
7922         <demangled_hash_languages>: Now a bitset.
7923         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7924         (lookup_minimal_symbol): Update.
7925
7926 2019-03-15  Tom Tromey  <tom@tromey.com>
7927
7928         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7929         Don't return the symbol.
7930         * coffread.c (record_minimal_symbol): Use record_full.
7931
7932 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7933
7934         The MS-Windows port of ncurses fails to switch to a color pair if
7935         one or both of the colors are the implicit default colors.  This
7936         change records the default colors when TUI is initialized, and
7937         then specifies them explicitly when a color pair uses the default
7938         colors.  This allows color styling in TUI mode on MS-Windows.
7939
7940         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7941         ncurses_norm_attr.
7942         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7943         colors in ncurses_norm_attr.
7944         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7945         "none", replace it with the default color recorded in
7946         ncurses_norm_attr.
7947
7948 2019-03-14  Tom Tromey  <tromey@adacore.com>
7949
7950         * source-cache.h (class source_cache) <get_source_lines>: Return
7951         std::string.
7952         * source-cache.c (source_cache::extract_lines): Handle case where
7953         first_pos==npos.  Return std::string.
7954         (source_cache::get_source_lines): Update.
7955
7956 2019-03-14  Tom Tromey  <tromey@adacore.com>
7957
7958         * NEWS: Add item for "style sources" commands.
7959         * source-cache.c (source_cache::get_source_lines): Check
7960         source_styling.
7961         * cli/cli-style.c (source_styling): New global.
7962         (_initialize_cli_style): Add "style sources" commands.
7963         (show_style_sources): New function.
7964         * cli/cli-style.h (source_styling): Declare.
7965
7966 2019-03-14  Pedro Alves  <palves@redhat.com>
7967             Tom Tromey  <tromey@adacore.com>
7968
7969         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7970         * tui/tui-winsource.c (tui_refill_source_window): New function,
7971         from...
7972         (tui_horizontal_source_scroll): ... here.  Move some logic.
7973         * cli/cli-style.c (set_style_enabled): Notify new observable.
7974         * tui/tui-hooks.c (tui_redisplay_source): New function.
7975         (tui_attach_detach_observers): Attach or detach
7976         tui_redisplay_source.
7977         * observable.h (source_styling_changed): New observable.
7978         * observable.c: Define source_styling_changed observable.
7979
7980 2019-03-13  Tom Tromey  <tromey@adacore.com>
7981
7982         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7983         (i386_gnu_nat_target::store_registers): Update.
7984         * target-debug.h (target_debug_print_std_string): New macro.
7985         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7986         * windows-tdep.c (display_one_tib): Update.
7987         * tui/tui-stack.c (tui_make_status_line): Update.
7988         * top.c (print_inferior_quit_action): Update.
7989         * thread.c (thr_try_catch_cmd): Update.
7990         (add_thread_with_info): Update.
7991         (thread_target_id_str): Update.
7992         (thr_try_catch_cmd): Update.
7993         (thread_command): Update.
7994         (thread_find_command): Update.
7995         * record-btrace.c (record_btrace_target::info_record)
7996         (record_btrace_resume_thread, record_btrace_target::resume)
7997         (record_btrace_cancel_resume, record_btrace_step_thread)
7998         (record_btrace_target::wait, record_btrace_target::wait)
7999         (record_btrace_target::wait, record_btrace_target::stop): Update.
8000         * progspace.c (print_program_space): Update.
8001         * process-stratum-target.c
8002         (process_stratum_target::thread_address_space): Update.
8003         * linux-fork.c (linux_fork_mourn_inferior)
8004         (detach_checkpoint_command, info_checkpoints_command)
8005         (linux_fork_context): Update.
8006         (linux_fork_detach): Update.
8007         (class scoped_switch_fork_info): Update.
8008         (delete_checkpoint_command): Update.
8009         * infrun.c (follow_fork_inferior): Update.
8010         (follow_fork_inferior): Update.
8011         (proceed_after_vfork_done): Update.
8012         (handle_vfork_child_exec_or_exit): Update.
8013         (follow_exec): Update.
8014         (displaced_step_prepare_throw): Update.
8015         (displaced_step_restore): Update.
8016         (start_step_over): Update.
8017         (resume_1): Update.
8018         (clear_proceed_status_thread): Update.
8019         (proceed): Update.
8020         (print_target_wait_results): Update.
8021         (do_target_wait): Update.
8022         (context_switch): Update.
8023         (stop_all_threads): Update.
8024         (restart_threads): Update.
8025         (finish_step_over): Update.
8026         (handle_signal_stop): Update.
8027         (switch_back_to_stepped_thread): Update.
8028         (keep_going_pass_signal): Update.
8029         (print_exited_reason): Update.
8030         (normal_stop): Update.
8031         * inferior.c (inferior_pid_to_str): Change return type.
8032         (print_selected_inferior): Update.
8033         (add_inferior): Update.
8034         (detach_inferior): Update.
8035         * dummy-frame.c (fprint_dummy_frames): Update.
8036         * dcache.c (dcache_info_1): Update.
8037         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8038         (btrace_fetch, btrace_clear): Update.
8039         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8040         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8041         type.
8042         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8043         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8044         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8045         * gdbarch.c, gdbarch.h: Rebuild.
8046         * gdbarch.sh (core_pid_to_str): Change return type.
8047         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8048         return type.
8049         (windows_nat_target::pid_to_str): Change return type.
8050         (windows_delete_thread): Update.
8051         (windows_nat_target::attach): Update.
8052         (windows_nat_target::files_info): Update.
8053         * target-delegates.c: Rebuild.
8054         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8055         return type.
8056         (sol_thread_target::pid_to_str): Change return type.
8057         * remote.c (class remote_target) <pid_to_str>: Change return
8058         type.
8059         (remote_target::pid_to_str): Change return type.
8060         (extended_remote_target::attach, remote_target::remote_stop_ns)
8061         (remote_target::remote_notif_remove_queued_reply)
8062         (remote_target::push_stop_reply, remote_target::disable_btrace):
8063         Update.
8064         (extended_remote_target::attach): Update.
8065         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8066         type.
8067         (gdbsim_target::pid_to_str): Change return type.
8068         * ravenscar-thread.c (struct ravenscar_thread_target)
8069         <pid_to_str>: Change return type.
8070         (ravenscar_thread_target::pid_to_str): Change return type.
8071         * procfs.c (class procfs_target) <pid_to_str>: Change return
8072         type.
8073         (procfs_target::pid_to_str): Change return type.
8074         (procfs_target::attach): Update.
8075         (procfs_target::detach): Update.
8076         (procfs_target::fetch_registers): Update.
8077         (procfs_target::store_registers): Update.
8078         (procfs_target::wait): Update.
8079         (procfs_target::files_info): Update.
8080         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8081         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8082         return type.
8083         (nto_procfs_target::pid_to_str): Change return type.
8084         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8085         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8086         return type.
8087         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8088         (exit_lwp): Update.
8089         (attach_proc_task_lwp_callback, get_detach_signal)
8090         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8091         (linux_nat_target::resume, wait_lwp, stop_callback)
8092         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8093         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8094         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8095         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8096         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8097         type.
8098         (inf_ptrace_target::attach): Update.
8099         (inf_ptrace_target::files_info): Update.
8100         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8101         type.
8102         (go32_nat_target::pid_to_str): Change return type.
8103         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8104         (gnu_nat_target::wait): Update.
8105         (gnu_nat_target::wait): Update.
8106         (gnu_nat_target::resume): Update.
8107         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8108         (fbsd_nat_target::wait): Update.
8109         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8110         type.
8111         (darwin_nat_target::attach): Update.
8112         * corelow.c (class core_target) <pid_to_str>: Change return type.
8113         (core_target::pid_to_str): Change return type.
8114         * target.c (normal_pid_to_str): Change return type.
8115         (default_pid_to_str): Likewise.
8116         (target_pid_to_str): Change return type.
8117         (target_translate_tls_address): Update.
8118         (target_announce_detach): Update.
8119         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8120         return type.
8121         (bsd_uthread_target::pid_to_str): Change return type.
8122         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8123         type.
8124         (bsd_kvm_target::pid_to_str): Change return type.
8125         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8126         return type.
8127         (aix_thread_target::pid_to_str): Change return type.
8128         * target.h (struct target_ops) <pid_to_str>: Change return type.
8129         (target_pid_to_str, normal_pid_to_str): Likewise.
8130         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8131         type.
8132         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8133         type.
8134         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8135         return type.
8136         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8137         type.
8138         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8139         type.
8140         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8141         return type.
8142
8143 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8144
8145         * NEWS: Mention that the new default MI version is 3.  Mention
8146         changes to the output of commands and events that deal with
8147         multi-location breakpoints.
8148         * breakpoint.c: Include "mi/mi-out.h".
8149         (print_one_breakpoint): Change output syntax if using MI version
8150         >= 3.
8151         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8152         New.
8153         (mi_multi_location_breakpoint_output_fixed): New.
8154         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8155         (mi_cmd_fix_multi_location_breakpoint_output): New.
8156         (mi_multi_location_breakpoint_output_fixed): New.
8157         * mi/mi-cmds.c (mi_cmds): Register command
8158         -fix-multi-location-breakpoint-output.
8159         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8160         interpreter "mi".
8161
8162 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8163
8164         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8165         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8166         instantiate mi_ui_out based on interpreter name.
8167         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8168         * mi/mi-main.c (mi_load_progress): Likewise.
8169
8170 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8171
8172         * NEWS: Combine separate "New targets" sections for 8.3.
8173
8174 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8175
8176         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8177         (ppcfbsd_init_abi): Install gdbarch
8178         "fetch_tls_load_module_address" and "get_thread_local_address"
8179         methods.
8180
8181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8182
8183         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8184         (riscv_fbsd_init_abi): Install gdbarch
8185         "fetch_tls_load_module_address" and "get_thread_local_address"
8186         methods.
8187
8188 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8189
8190         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8191         (i386fbsd_init_abi): Install gdbarch
8192         "fetch_tls_load_module_address" and "get_thread_local_address"
8193         methods.
8194
8195 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8196
8197         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8198         (amd64fbsd_init_abi): Install gdbarch
8199         "fetch_tls_load_module_address" and "get_thread_local_address"
8200         methods.
8201
8202 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8203
8204         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8205         (struct fbsd_pspace_data): New type.
8206         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8207         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8208         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8209         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8210         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8211
8212 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8213
8214         * gdbtypes.c (lookup_struct_elt): New function.
8215         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8216         * gdbtypes.h (struct struct_elt): New type.
8217         (lookup_struct_elt): New prototype.
8218
8219 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8220
8221         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8222         remove disabled code block.
8223
8224 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8225
8226         * gdbarch.sh (get_thread_local_address): New method.
8227         * gdbarch.h, gdbarch.c: Regenerate.
8228         * target.c (target_translate_tls_address): Use
8229         gdbarch_get_thread_local_address if present instead of
8230         target::get_thread_local_address.
8231
8232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8233
8234         * target.h (target::get_thread_local_address): Update comment.
8235
8236 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8237
8238         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8239         objfile->separate_debug_objfile_backlink if not NULL.
8240
8241 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8242
8243         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8244         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8245         (amd64bsd_store_inferior_registers): Likewise.
8246         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8247         Enable segment base registers.
8248         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8249         PT_GETFSBASE and PT_GETGSBASE.
8250         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8251         PT_SETGSBASE.
8252         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8253         segment base registers.
8254         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8255
8256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8257
8258         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8259         Update calls to i386_target_description to add 'segments'
8260         parameter.
8261         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8262         add segment base registers.
8263         * arch/i386.c (i386_create_target_description): Add 'segments'
8264         parameter to enable segment base registers.
8265         * arch/i386.h (i386_create_target_description): Likewise.
8266         * features/i386/32bit-segments.xml: New file.
8267         * features/i386/32bit-segments.c: Generate.
8268         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8269         call to i386_target_description to add 'segments' parameter.
8270         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8271         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8272         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8273         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8274         if feature is present.
8275         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8276         Add 'segments' parameter to call to i386_target_description.
8277         (i386_target_description): Add 'segments' parameter to enable
8278         segment base registers.
8279         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8280         to call to i386_target_description.
8281         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8282         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8283         Define I386_NUM_REGS.
8284         (i386_target_description): Add 'segments' parameter to enable
8285         segment base registers.
8286
8287 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8288
8289         PR/24325
8290         * source-cache.c: #undef open and close, to avoid unresolved
8291         externals during linking.
8292
8293 2019-03-12  Tom Tromey  <tromey@adacore.com>
8294
8295         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8296         const.  Add initializers.
8297         (_initialize_remote): Don't initialize ptid globals.
8298
8299 2019-03-12  Pedro Alves  <palves@redhat.com>
8300
8301         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8302
8303 2019-03-12  Pedro Alves  <palves@redhat.com>
8304
8305         * cp-name-parser.y (main): Remove unused 'len' variable.
8306
8307 2019-03-12  Tom Tromey  <tromey@adacore.com>
8308
8309         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8310         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8311
8312 2019-03-12  Tom Tromey  <tromey@adacore.com>
8313
8314         * linux-nat.c (iterate_over_lwps): Update.
8315         (stop_callback): Remove parameter.
8316         (stop_wait_callback, detach_callback, resume_set_callback)
8317         (select_singlestep_lwp_callback, set_ignore_sigint)
8318         (status_callback, resumed_callback, resume_clear_callback)
8319         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8320         data parameter.
8321         (linux_nat_target::detach, linux_nat_target::resume)
8322         (linux_stop_and_wait_all_lwps, select_event_lwp)
8323         (linux_nat_filter_event, linux_nat_wait_1)
8324         (linux_nat_target::kill, linux_nat_target::stop)
8325         (linux_nat_target::stop): Update.
8326         (linux_nat_resume_callback): Change type.
8327         (resume_stopped_resumed_lwps, count_events_callback)
8328         (select_event_lwp_callback): Likewise.
8329         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8330         * arm-linux-nat.c (struct update_registers_data): Remove.
8331         (update_registers_callback): Change type.
8332         (arm_linux_insert_hw_breakpoint1): Update.
8333         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8334         parameter.
8335         (x86_linux_dr_set_addr): Update.
8336         (x86_linux_dr_set_control): Update.
8337         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8338         (iterate_over_lwps): Use gdb::function_view.
8339         * nat/aarch64-linux-hw-point.c (struct
8340         aarch64_dr_update_callback_param): Remove.
8341         (debug_reg_change_callback): Change type.
8342         (aarch64_notify_debug_reg_change): Update.
8343         * s390-linux-nat.c (s390_refresh_per_info): Update.
8344
8345 2019-03-11  Tom Tromey  <tromey@adacore.com>
8346
8347         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8348         redundant assignment to "this_cu".
8349
8350 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8351
8352         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8353
8354 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8355
8356         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8357         from...
8358         (rank_one_type): ... this.
8359
8360 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8361
8362         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8363         from...
8364         (rank_one_type): ... this.
8365
8366 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8367
8368         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8369         from...
8370         (rank_one_type): ... this.
8371
8372 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8373
8374         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8375         from...
8376         (rank_one_type): ... this.
8377
8378 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8379
8380         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8381         from...
8382         (rank_one_type): ... this.
8383
8384 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8385
8386         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8387         from...
8388         (rank_one_type): ... this.
8389
8390 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8391
8392         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8393         from...
8394         (rank_one_type): ... this.
8395
8396 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8397
8398         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8399         from...
8400         (rank_one_type): ... this.
8401
8402 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8403
8404         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8405         from...
8406         (rank_one_type): ... this.
8407
8408 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8409
8410         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8411         from...
8412         (rank_one_type): ... this.
8413
8414 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8415
8416         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8417         from...
8418         (rank_one_type): ... this.
8419
8420 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8421
8422         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8423         from...
8424         (rank_one_type): ... this.
8425
8426 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8427
8428         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8429         inferior-events' shows the example events.
8430
8431 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8432
8433         Support styling on native MS-Windows console
8434
8435         PR/24315
8436         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8437         on MS-Windows if $TERM is not defined.
8438
8439         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8440
8441         * posix-hdep.c (gdb_console_fputs):
8442         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8443         functions.
8444         * ui-file.h (gdb_console_fputs): Add prototype.
8445
8446         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8447         back to fputs only if the former returns zero.
8448
8449 2019-03-07  Tom Tromey  <tom@tromey.com>
8450
8451         * symmisc.c (print_symbol_bcache_statistics): Update.
8452         (print_objfile_statistics): Update.
8453         * symfile.c (allocate_symtab): Update.
8454         * stabsread.c: Don't include bcache.h.
8455         * psymtab.h (struct psymbol_bcache): Don't declare.
8456         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8457         (psymbol_bcache_init, psymbol_bcache_free)
8458         (psymbol_bcache_get_bcache): Don't declare.
8459         * psymtab.c (struct psymbol_bcache): Remove.
8460         (psymtab_storage::psymtab_storage): Update.
8461         (psymtab_storage::~psymtab_storage): Update.
8462         (psymbol_bcache_init, psymbol_bcache_free)
8463         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8464         (add_psymbol_to_bcache): Update.
8465         (allocate_psymtab): Update.
8466         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8467         macro_cache>: No longer pointers.
8468         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8469         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8470         * macrotab.c (macro_bcache): Update.
8471         * macroexp.c: Don't include bcache.h.
8472         * gdbtypes.c (check_types_worklist): Update.
8473         (types_deeply_equal): Remove TRY/CATCH.  Update.
8474         * elfread.c (elf_symtab_read): Update.
8475         * dwarf2read.c: Don't include bcache.h.
8476         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8477         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8478         (print_bcache_statistics, bcache_memory_used): Don't declare.
8479         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8480         methods.  Rename all data members.
8481         * bcache.c (struct bcache): Move to bcache.h.
8482         (bcache::expand_hash_table): Rename from expand_hash_table.
8483         (bcache): Remove.
8484         (bcache::insert): Rename from bcache_full.
8485         (bcache::compare): Rename from bcache_compare.
8486         (bcache_xmalloc): Remove.
8487         (bcache::~bcache): Rename from bcache_xfree.
8488         (bcache::print_statistics): Rename from print_bcache_statistics.
8489         (bcache::memory_used): Rename from bcache_memory_used.
8490
8491 2019-03-07  Pedro Alves  <palves@redhat.com>
8492
8493         * infrun.c (normal_stop): Also check for
8494         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8495
8496 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8497
8498         * f-lang.c (value_from_host_double): Moved to...
8499         * value.c (value_from_host_double): ...here.
8500         * value.h (value_from_host_double): Declare.
8501         * guile/scm-math.c (vlscm_convert_typed_number): Use
8502         value_from_host_double.
8503         (vlscm_convert_number): Likewise.
8504         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8505         * python/py-value.c (convert_value_from_python): Likewise.
8506
8507 2019-03-06  Tom Tromey  <tom@tromey.com>
8508
8509         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8510
8511 2019-03-06  Tom Tromey  <tom@tromey.com>
8512
8513         * utils.h (free_current_contents): Don't declare.
8514         * utils.c (free_current_contents): Remove.
8515
8516 2019-03-06  Tom Tromey  <tom@tromey.com>
8517
8518         * top.c (quit_force): Update.
8519         * main.c (captured_command_loop): Update.
8520         * common/new-op.c (operator new): Update.
8521         * common/common-exceptions.c (struct catcher)
8522         <save_cleanup_chain>: Remove member.
8523         (exceptions_state_mc_init): Update.
8524         (exception_try_scope_entry): Return nullptr.
8525         (exception_try_scope_exit, exception_rethrow)
8526         (throw_exception_sjlj, throw_exception_cxx): Update.
8527         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8528         (all_cleanups, do_cleanups, discard_cleanups)
8529         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8530         (restore_cleanups, restore_final_cleanups): Don't declare.
8531         (do_final_cleanups): Remove parameter.
8532         * common/cleanups.c (cleanup_chain, make_cleanup)
8533         (make_cleanup_dtor, all_cleanups, do_cleanups)
8534         (discard_my_cleanups, discard_cleanups)
8535         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8536         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8537         (null_cleanup): Remove.
8538         (do_final_cleanups): Remove parameter.
8539
8540 2019-03-06  Tom Tromey  <tom@tromey.com>
8541
8542         * remote.c (remote_target::remote_parse_stop_reply): Use
8543         unique_xmalloc_ptr.
8544
8545 2019-03-06  Tom Tromey  <tom@tromey.com>
8546
8547         * stabsread.c (struct stabs_field_info): Rename from field_info.
8548         <list, fnlist>: Add initializers.
8549         <obstack>: New member.
8550         (read_member_functions, read_struct_fields, read_baseclasses):
8551         Allocate on obstack.  Don't use cleanups.
8552         (read_one_struct_field, read_member_functions, read_struct_fields)
8553         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8554         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8555         (read_struct_type): Update.
8556
8557 2019-03-06  Tom Tromey  <tom@tromey.com>
8558
8559         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8560         * common/filestuff.h (make_cleanup_close): Don't declare.
8561         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8562         Remove.
8563
8564 2019-03-06  Tom Tromey  <tom@tromey.com>
8565
8566         * solib-aix.c: Use make_scope_exit.
8567
8568 2019-03-06  Tom Tromey  <tom@tromey.com>
8569
8570         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8571         Use make_scope_exit.
8572
8573 2019-03-06  Tom Tromey  <tom@tromey.com>
8574
8575         * solib-svr4.c (disable_probes_interface): Remove parameter.
8576         (svr4_handle_solib_event): Use make_scope_exit.
8577
8578 2019-03-06  Tom Tromey  <tom@tromey.com>
8579
8580         * remote.c (struct stop_reply_deleter): Remove.
8581         (stop_reply_up): Update.
8582         (struct stop_reply): Derive from notif_event.  Don't typedef.
8583         <regcache>: Now a std::vector.
8584         (stop_reply_xfree): Remove.
8585         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8586         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8587         (remote_target::discard_pending_stop_replies): Use delete.
8588         (remote_target::remote_parse_stop_reply): Update.
8589         (remote_target::process_stop_reply): Update.
8590         * remote-notif.h (struct notif_event): Add virtual destructor.
8591         Remove "dtr" member.
8592         (struct notif_client) <alloc_event>: Return a unique_ptr.
8593         (notif_event_xfree): Don't declare.
8594         (notif_event_up): New typedef.
8595         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8596         (notif_event_xfree, do_notif_event_xfree): Remove.
8597         (remote_notif_state_xfree): Update.
8598
8599 2019-03-06  Tom Tromey  <tom@tromey.com>
8600
8601         * infrun.c (displaced_step_clear_cleanup): Now a
8602         forward_scope_exit type.
8603         (displaced_step_prepare_throw): Update.
8604         (displaced_step_fixup): Update.
8605
8606 2019-03-06  Tom Tromey  <tom@tromey.com>
8607
8608         * inferior.h (class inferior): Update comment.
8609         * gdbthread.h (class thread_info): Update comment.
8610
8611 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8612             Tom Tromey  <tom@tromey.com>
8613
8614         * stabsread.h (struct stab_section_list): Remove.
8615         (coffstab_build_psymtabs): Update.
8616         * dbxread.c (symbuf_sections): Now a std::vector.
8617         (sect_idx): New global.
8618         (fill_symbuf): Update.
8619         (coffstab_build_psymtabs): Change type of stabsects parameter.
8620         Update.
8621         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8622         std::vector.
8623         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8624         (coff_locate_sections): Update.
8625         (coff_symfile_read): Remove cleanups.  Update.
8626         (init_stringtab): Add storage parameter.
8627         (free_stringtab, free_stringtab_cleanup): Remove.
8628         (init_lineno): Add storage parameter.
8629         (free_linetab, free_linetab_cleanup): Remove.
8630
8631 2019-03-06  Pedro Alves  <palves@redhat.com>
8632
8633         * linux-fork.c (fork_info::clobber_regs): Delete.
8634         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8635         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8636         comment.  Adjust.
8637         (scoped_switch_fork_info::scoped_switch_fork_info)
8638         (checkpoint_command, linux_fork_context): Adjust
8639         fork_save_infrun_state calls.
8640
8641 2019-03-06  Pedro Alves  <palves@redhat.com>
8642
8643         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8644         (inf_has_multiple_threads): Return 'bool' and rewrite using
8645         inferior_info::threads().
8646
8647 2019-03-06  Pedro Alves  <palves@redhat.com>
8648
8649         * linux-fork.c: Include <list>.
8650         (fork_list): Now a std::list instance.
8651         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8652         (forks_exist_p, find_last_fork): Adjust.
8653         (new_fork): Delete.
8654         (one_fork_p): New.
8655         (add_fork): Adjust.
8656         (free_fork): Delete, folded into fork_info::~fork_info().
8657         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8658         Adjust.
8659         (init_fork_list): Delete.
8660         (linux_fork_killall, linux_fork_mourn_inferior)
8661         (linux_fork_detach, info_checkpoints_command): Adjust.
8662         (_initialize_linux_fork): No longer call init_fork_list.
8663
8664 2019-03-06  Pedro Alves  <palves@redhat.com>
8665
8666         * linux-fork.c (new_fork): New, split out of ...
8667         (add_fork): ... this.  Return void.  Move "first fork" special
8668         case from here, to ...
8669         (checkpoint_command): ... here.
8670         * linux-linux.h (add_fork): Return void.
8671
8672 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8673
8674         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8675
8676 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8677             Chris January  <chris.january@arm.com>
8678             David Lecomber  <david.lecomber@arm.com>
8679
8680         * f-exp.y: New token, UNOP_INTRINSIC.
8681         (exp): New pattern using UNOP_INTRINSIC token.
8682         (f77_keywords): Add 'abs' keyword.
8683         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8684         (value_from_host_double): New function.
8685         (evaluate_subexp_f): Support UNOP_ABS.
8686
8687 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8688
8689         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8690         types.
8691
8692 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8693
8694         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8695         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8696         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8697
8698 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8699
8700         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8701
8702 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8703             Chris January  <chris.january@arm.com>
8704
8705         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8706         * f-exp.y: Define 'KIND' token.
8707         (exp): New pattern for KIND expressions.
8708         (ptype): Handle types with a kind extension.
8709         (direct_abs_decl): Extend to spot kind extensions.
8710         (f77_keywords): Add 'kind' to the list.
8711         (push_kind_type): New function.
8712         (convert_to_kind_type): New function.
8713         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8714         * parse.c (operator_length_standard): Likewise.
8715         * parser-defs.h (enum type_pieces): Add tp_kind.
8716         * std-operator.def: Add UNOP_KIND.
8717
8718 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8719
8720         * f-exp.y (f_parse): Set yydebug.
8721
8722 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8723
8724         * f-lang.c (evaluate_subexp_f): New function.
8725         (exp_descriptor_f): New global.
8726         (f_language_defn): Use exp_descriptor_f instead of
8727         exp_descriptor_standard.
8728
8729 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8730
8731         * f-exp.y (struct token): Add comments.
8732         (dot_ops): Remove uppercase versions and the end marker.
8733         (f77_keywords): Likewise.
8734         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8735         entries in the dot_ops array are case insensitive, and use
8736         strncasecmp to compare strings.  Also some whitespace cleanup in
8737         this area.  Similar for the f77_keywords array, except entries in
8738         this list might be case sensitive.
8739
8740 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8741
8742         * f-exp.y (struct f77_boolean_val): Add comments.
8743         (boolean_values): Remove uppercase versions, and end marker.
8744         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8745         and use strncasecmp to achieve case insensitivity.  Additionally,
8746         perform whitespace cleanup around this code.
8747
8748 2019-03-06  Tom Tromey  <tromey@adacore.com>
8749
8750         * remote-sim.c (gdbsim_target_open): Use result of
8751         gdb_argv::release.
8752
8753 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8754         Dirk Schubert  <dirk.schubert@arm.com>
8755         Chris January  <chris.january@arm.com>
8756
8757         * eval.c (evaluate_subexp_standard): Call Fortran argument
8758         wrapping logic.
8759         * f-lang.c (struct value): A value which can be passed into a
8760         Fortran function call.
8761         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8762         where appropriate.
8763         (struct type): Value ready for a Fortran function call.
8764         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8765         is needed.
8766         * f-lang.h (fortran_argument_convert): Declaration.
8767         (fortran_preserve_arg_pointer): Declaration.
8768         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8769
8770 2019-03-05  Tom Tromey  <tromey@adacore.com>
8771
8772         * python/py-prettyprint.c (print_string_repr): Remove #if.
8773         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8774
8775 2019-03-05  Tom Tromey  <tromey@adacore.com>
8776
8777         * target.c (the_dummy_target): Move later.  Change type to
8778         "dummy_target".
8779         (initialize_targets): Don't initialize the_dummy_target.
8780
8781 2019-03-05  Tom Tromey  <tromey@adacore.com>
8782
8783         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8784         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8785
8786 2019-03-05  Tom Tromey  <tromey@adacore.com>
8787
8788         * windows-nat.c (windows_nat_target::attach)
8789         (windows_nat_target::detach): Don't call gdb_flush.
8790         * valprint.c (generic_val_print, val_print, val_print_string):
8791         Don't call gdb_flush.
8792         * utils.c (defaulted_query): Don't call gdb_flush.
8793         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8794         * target.c (target_announce_detach): Don't call gdb_flush.
8795         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8796         * remote.c (extended_remote_target::attach): Don't call
8797         gdb_flush.
8798         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8799         * printcmd.c (do_examine): Don't call gdb_flush.
8800         (info_display_command): Don't call gdb_flush.
8801         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8802         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8803         * memattr.c (info_mem_command): Don't call gdb_flush.
8804         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8805         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8806         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8807         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8808         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8809         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8810         (gnu_nat_target::detach): Don't call gdb_flush.
8811         * f-valprint.c (f_val_print): Don't call gdb_flush.
8812         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8813         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8814         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8815         gdb_flush.
8816         * c-valprint.c (c_val_print): Don't call gdb_flush.
8817         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8818
8819 2019-03-05  Tom Tromey  <tromey@adacore.com>
8820
8821         * varobj.c (update_dynamic_varobj_children): Update.
8822         (install_default_visualizer): Use reset, not release.
8823         * value.c (set_internalvar): Update.
8824         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8825         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8826         ATTRIBUTE_UNUSED_RESULT.
8827
8828 2019-03-05  Tom Tromey  <tromey@adacore.com>
8829
8830         * remote.c (class scoped_remote_fd) <release>: Add
8831         ATTRIBUTE_UNUSED_RESULT.
8832
8833 2019-03-05  Tom Tromey  <tromey@adacore.com>
8834
8835         * macroexp.c (struct macro_buffer) <release>: Add
8836         ATTRIBUTE_UNUSED_RESULT.
8837
8838 2019-03-05  Tom Tromey  <tromey@adacore.com>
8839
8840         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8841         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8842         ATTRIBUTE_UNUSED_RESULT.
8843
8844 2019-03-05  Tom Tromey  <tromey@adacore.com>
8845
8846         * common/scoped_fd.h (class scoped_fd) <release>: Add
8847         ATTRIBUTE_UNUSED_RESULT.
8848
8849 2019-03-05  Tom Tromey  <tromey@adacore.com>
8850
8851         * parser-defs.h (struct parser_state) <release>: Add
8852         ATTRIBUTE_UNUSED_RESULT.
8853
8854 2019-03-05  Tom Tromey  <tromey@adacore.com>
8855
8856         * utils.h (class gdb_argv) <release>: Add
8857         ATTRIBUTE_UNUSED_RESULT.
8858         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8859
8860 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8861
8862         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8863         for-loop range, to avoid compiler warnings.
8864
8865         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8866         avoid compiler warnings about unused variables.
8867
8868         * NEWS: Mention end of support for native debugging on MS-Windows
8869         before XP.
8870
8871         PR gdb/24292
8872         * common/netstuff.c:
8873         * gdbserver/gdbreplay.c
8874         * gdbserver/remote-utils.c:
8875         * ser-tcp.c:
8876         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8877         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8878         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8879         'getaddrinfo' and 'freeaddrinfo' were not available before
8880         Windows XP, and mingw.org's MinGW headers by default define
8881         _WIN32_WINNT to 0x500.
8882
8883 2019-03-01  Gary Benson <gbenson@redhat.com>
8884
8885         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8886
8887 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8888             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8889
8890         PR gdb/8527
8891         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8892         set_sigint_trap, clear_sigint_trap.
8893
8894 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8895
8896         * target.c (target_detach): Clear the regcache and the
8897         frame cache.
8898
8899 2019-02-27  Pedro Alves  <palves@redhat.com>
8900
8901         * utils.c (set_screen_size): When we cap the height/width sizes,
8902         tweak the corresponding command variable to show "unlimited":
8903
8904 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8905             Pedro Alves  <palves@redhat.com>
8906
8907         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8908         before calling rl_set_screen_size.
8909
8910 2019-02-27  Tom Tromey  <tromey@adacore.com>
8911
8912         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8913         define.
8914         * python/py-value.c: Remove Python 2.4 workaround.
8915         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8916         workaround.
8917         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8918         Python 2.4 workaround.
8919         * python/python-internal.h: Remove Python 2.4 comment.
8920         (Py_ssize_t): Don't define.
8921         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8922         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8923         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8924         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8925         * python/python.c (do_start_initialization): Remove Python 2.4
8926         workaround.
8927         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8928         (print_children): Remove Python 2.4 workaround.
8929         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8930         workaround.
8931         (CHARBUFFERPROC_NAME): Remove.
8932         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8933         Python 2.4 workaround.
8934
8935 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8936
8937         * NEWS: Note minimum Python version.
8938
8939 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8940
8941         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8942         code from these functions.  Remove corresponding ifdefs.  Use
8943         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8944         Remove gotos and target of gotos.
8945         (infpy_search_memory): Likewise.
8946
8947 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8948
8949         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8950         (hppa_gdbarch_init): Don't register deleted functions with
8951         gdbarch.
8952
8953 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8954
8955         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8956         (h8300_unwind_sp): Delete.
8957         (h8300_dummy_id): Delete.
8958         (h8300_gdbarch_init): Don't register deleted functions with
8959         gdbarch.
8960
8961 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8962
8963         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8964         (ft32_unwind_pc): Delete.
8965         (ft32_unwind_sp): Delete.
8966         (ft32_gdbarch_init): Don't register deleted functions with
8967         gdbarch.
8968
8969 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8970
8971         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8972         (frv_unwind_pc): Delete.
8973         (frv_unwind_sp): Delete.
8974         (frv_gdbarch_init): Don't register deleted functions with
8975         gdbarch.
8976
8977 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8978
8979         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8980         (riscv_unwind_pc): Delete.
8981         (riscv_unwind_sp): Delete.
8982         (riscv_gdbarch_init): Don't register deleted functions with
8983         gdbarch.
8984
8985 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8986
8987         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8988         (csky_unwind_pc): Delete.
8989         (csky_unwind_sp): Delete.
8990         (csky_gdbarch_init): Don't register deleted functions with
8991         gdbarch.
8992
8993 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8994
8995         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8996         (cris_unwind_pc): Delete.
8997         (cris_unwind_sp): Delete.
8998         (cris_gdbarch_init): Don't register deleted functions with
8999         gdbarch.
9000
9001 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9002
9003         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9004         (bfin_unwind_pc): Delete.
9005         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9006
9007 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9008
9009         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9010         (arm_unwind_pc): Delete.
9011         (arm_unwind_sp): Delete.
9012         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9013
9014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9015
9016         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9017         (arc_unwind_pc): Delete.
9018         (arc_unwind_sp): Delete.
9019         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9020
9021 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9022
9023         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9024         (alpha_unwind_pc): Delete.
9025         (alpha_gdbarch_init): Don't register deleted functions with
9026         gdbarch.
9027
9028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9029
9030         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9031         (aarch64_unwind_pc): Delete.
9032         (aarch64_unwind_sp): Delete.
9033         (aarch64_gdbarch_init): Don't register deleted functions with
9034         gdbarch.
9035
9036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9037
9038         * gdbtypes.c (type_align): Don't consider static members when
9039         computing structure alignment.
9040
9041 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9042
9043         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9044         return 0 for other types.
9045         * arch-utils.c (default_type_align): Always return 0.
9046         * gdbarch.h: Regenerate.
9047         * gdbarch.sh (type_align): Extend comment.
9048         * gdbtypes.c (type_align): Add additional comments, always call
9049         gdbarch_type_align before applying the default rules.
9050         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9051         generic code will then apply a suitable default.
9052         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9053         types, return 0 for other types.
9054
9055 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9056
9057         * NEWS: Create a new section for the next release branch.
9058         Rename the section of the current branch, now that it has
9059         been cut.
9060
9061 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9062
9063         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9064         * version.in: Bump version to 8.3.50.DATE-git.
9065
9066 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9067
9068         * aix-thread.c (ptid_cmp): Remove unused variable.
9069         (get_signaled_thread): Likewise.
9070         (store_regs_user_thread): Likewise.
9071         (store_regs_kernel_thread): Likewise.
9072         (fetch_regs_kernel_thread): Remove shadowed variable.
9073
9074 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9075
9076         * features/riscv/32bit-cpu.xml: Add register numbers.
9077         * features/riscv/32bit-fpu.c: Regenerate.
9078         * features/riscv/32bit-fpu.xml: Add register numbers.
9079         * features/riscv/64bit-cpu.xml: Add register numbers.
9080         * features/riscv/64bit-fpu.c: Regenerate.
9081         * features/riscv/64bit-fpu.xml: Add register numbers.
9082
9083 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9084
9085         * NEWS: Mention two argument form of gdb.Value constructor.
9086         * python/py-value.c (convert_buffer_and_type_to_value): New
9087         function.
9088         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9089         Add support for handling an optional second argument.  Call
9090         convert_buffer_and_type_to_value as appropriate.
9091         * python/python-internal.h (Py_buffer_deleter): New struct.
9092         (Py_buffer_up): New typedef.
9093
9094 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9095
9096         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9097         instead of releasing ownership.
9098
9099 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9100
9101         * dwarf2read.c (open_and_init_dwp_file): Call
9102         elf_numsections instead of bfd_count_sections to initialize
9103         dwp_file->num_sections.
9104
9105 2019-02-25  Tom Tromey  <tromey@adacore.com>
9106
9107         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9108
9109 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9110
9111         * gcore.in: Add '--readnever' option when invoking GDB.
9112
9113 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9114
9115         * MAINTAINERS: Update my email address.
9116
9117 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9118
9119         * build-id.c (build_id_to_debug_bfd_1): New function.
9120         (build_id_to_debug_bfd): Look for separate debug file in
9121         sysroot.
9122
9123 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9124
9125         * gdbarch.sh: Update the copyright year range that is placed into
9126         generated files.
9127
9128 2019-02-22  Keith Seitz  <keiths@redhat.com>
9129
9130         PR symtab/23853
9131         * linespec.c (create_sals_line_offset): Search for the default
9132         symtab's filename instead of its fullname.
9133
9134 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9135
9136         * NEWS: Update style defaults.
9137
9138 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9139
9140         * main.c (captured_main_1): Disable styling in batch mode.
9141
9142 2019-02-20  Tom Tromey  <tom@tromey.com>
9143
9144         * symtab.c (symtab_symbol_info): Fix typos.
9145
9146 2019-02-20  Tom Tromey  <tromey@adacore.com>
9147
9148         * findcmd.c (_initialize_mem_search): Use upper case for
9149         metasyntactic variables.
9150
9151 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9152
9153         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9154         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9155
9156 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9157
9158         * top.h (source_file_name): Change to std::string.
9159         * top.c (source_file_name): Likewise.
9160         (command_line_input): Adjust.
9161         * cli/cli-script.c (script_from_file): Adjust.
9162
9163 2019-02-19  Tom Tromey  <tromey@adacore.com>
9164
9165         * ravenscar-thread.c
9166         (ravenscar_thread_target::update_thread_list): Don't call
9167         ada_build_task_list.
9168         * ada-lang.h (ada_build_task_list): Don't declare.
9169         * ada-tasks.c (struct ada_tasks_inferior_data)
9170         <task_list_valid_p>: Now bool.
9171         (read_known_tasks, ada_task_list_changed)
9172         (ada_tasks_invalidate_inferior_data): Update.
9173         (read_known_tasks_array): Return bool.
9174         (read_known_tasks_list): Likewise.
9175         (read_known_tasks): Return void.
9176         (ada_build_task_list): Now static.
9177
9178 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9179
9180         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9181         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9182
9183 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9184
9185         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9186         variant for ada_tasks_pspace_data_handle and
9187         ada_tasks_inferior_data_handle.
9188         (ada_tasks_pspace_data_cleanup): New function.
9189         (ada_tasks_inferior_data_cleanup): New function.
9190
9191 2019-02-17  Tom Tromey  <tom@tromey.com>
9192
9193         * macrotab.h (macro_source_fullname): Return a std::string.
9194         * macrotab.c (macro_include, check_for_redefinition)
9195         (macro_undef, macro_lookup_definition, foreach_macro)
9196         (foreach_macro_in_scope): Update.
9197         (macro_source_fullname): Return a std::string.
9198         * macrocmd.c (show_pp_source_pos): Update.
9199
9200 2019-02-17  Tom Tromey  <tom@tromey.com>
9201
9202         * macrocmd.c (show_pp_source_pos): Style the file names.
9203
9204 2019-02-17  Tom Tromey  <tom@tromey.com>
9205
9206         PR tui/24197:
9207         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9208
9209 2019-02-17  Tom Tromey  <tom@tromey.com>
9210
9211         * ada-lang.c (user_select_syms): Use filtered printing.
9212         * utils.c (wrap_style): New global.
9213         (desired_style): Remove.
9214         (emit_style_escape): Add stream parameter.
9215         (set_output_style, reset_terminal_style, prompt_for_continue):
9216         Update.
9217         (flush_wrap_buffer): Only flush gdb_stdout.
9218         (wrap_here): Set wrap_style.
9219         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9220         treat escape sequences as a character.  Change when wrap buffer is
9221         flushed.
9222         (fputs_styled): Do not set the output style when the default is
9223         requested.
9224         * ui-style.h (struct ui_file_style) <is_default>: New method.
9225         * source.c (print_source_lines_base): Emit escape sequences in one
9226         piece.
9227
9228 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9229
9230         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9231         integers and enumeration types.
9232
9233 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9234
9235         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9236         instead of lookup_symbol_in_language
9237         (do_exact_match): New function.
9238         (ada_get_symbol_name_matcher): Return do_exact_match when
9239         doing a verbatim match.
9240
9241 2019-02-15  Tom Tromey  <tromey@adacore.com>
9242
9243         * ravenscar-thread.c (ravenscar_thread_target::resume)
9244         (ravenscar_thread_target::wait): Special case wildcard requests.
9245
9246 2019-02-15  Tom Tromey  <tromey@adacore.com>
9247
9248         * ravenscar-thread.c (base_ptid): Remove.
9249         (struct ravenscar_thread_target) <close>: New method.
9250         <m_base_ptid>: New member.
9251         <update_inferior_ptid, active_task, task_is_currently_active,
9252         runtime_initialized>: Declare methods.
9253         <ravenscar_thread_target>: Add constructor.
9254         (ravenscar_thread_target::task_is_currently_active)
9255         (ravenscar_thread_target::update_inferior_ptid)
9256         (ravenscar_runtime_initialized): Rename.  Now methods.
9257         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9258         (ravenscar_thread_target::update_thread_list): Update.
9259         (ravenscar_thread_target::active_task): Now method.
9260         (ravenscar_thread_target::store_registers)
9261         (ravenscar_thread_target::prepare_to_store)
9262         (ravenscar_thread_target::prepare_to_store)
9263         (ravenscar_thread_target::mourn_inferior): Update.
9264         (ravenscar_inferior_created): Use "new" to create target.
9265         (ravenscar_thread_target::get_ada_task_ptid): Update.
9266         (_initialize_ravenscar): Don't initialize base_ptid.
9267         (ravenscar_ops): Remove global.
9268
9269 2019-02-15  Tom Tromey  <tromey@adacore.com>
9270
9271         * target.h (push_target): Declare new overload.
9272         * target.c (push_target): New overload, taking an rvalue reference.
9273         * remote.c (remote_target::open_1): Use push_target overload.
9274         * corelow.c (core_target_open): Use push_target overload.
9275
9276 2019-02-15  Tom Tromey  <tromey@adacore.com>
9277
9278         * ravenscar-thread.c (is_ravenscar_task)
9279         (ravenscar_task_is_currently_active): Return bool.
9280         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9281         (_initialize_ravenscar): Remove "(void)".
9282         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9283         Return bool.
9284
9285 2019-02-15  Tom Tromey  <tromey@adacore.com>
9286
9287         * ravenscar-thread.c (ravenscar_runtime_initializer)
9288         (has_ravenscar_runtime, get_running_thread_id)
9289         (ravenscar_thread_target::resume): Fix indentation.
9290
9291 2019-02-15  Tom Tromey  <tromey@adacore.com>
9292
9293         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9294         from ravenscar_arch_ops.
9295         (sparc_ravenscar_ops::fetch_registers)
9296         (sparc_ravenscar_ops::store_registers): Now methods.
9297         (sparc_ravenscar_prepare_to_store): Remove.
9298         (sparc_ravenscar_ops): Redefine.
9299         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9300         methods and destructor.  Remove members.
9301         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9302         (ravenscar_thread_target::store_registers)
9303         (ravenscar_thread_target::prepare_to_store): Update.
9304         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9305         Remove.
9306         (struct ppc_ravenscar_powerpc_ops): Derive from
9307         ravenscar_arch_ops.
9308         (ppc_ravenscar_powerpc_ops::fetch_registers)
9309         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9310         (ppc_ravenscar_powerpc_ops): Redefine.
9311         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9312         (ppc_ravenscar_e500_ops::fetch_registers)
9313         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9314         (ppc_ravenscar_e500_ops): Redefine.
9315         * aarch64-ravenscar-thread.c
9316         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9317         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9318         (aarch64_ravenscar_fetch_registers)
9319         (aarch64_ravenscar_store_registers): Now methods.
9320         (aarch64_ravenscar_ops): Redefine.
9321
9322 2019-02-15  Tom Tromey  <tromey@adacore.com>
9323
9324         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9325         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9326         (ravenscar_thread_target::stopped_by_watchpoint)
9327         (ravenscar_thread_target::stopped_data_address)
9328         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9329
9330 2019-02-15  Tom Tromey  <tromey@adacore.com>
9331
9332         * ravenscar-thread.c: Fix some typos.
9333
9334 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9335             Tom Tromey  <tromey@adacore.com>
9336
9337         * ada-lang.c (ada_exception_sal): Change addr_string to a
9338         std::string.
9339         (create_ada_exception_catchpoint): Update.
9340
9341 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9342             Tom Tromey  <tromey@adacore.com>
9343
9344         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9345         (bp_location_ops): Remove.
9346         (base_breakpoint_allocate_location): Update.
9347         (free_bp_location): Update.
9348         * ada-lang.c (class ada_catchpoint_location)
9349         <ada_catchpoint_location>: Remove ops parameter.
9350         (ada_catchpoint_location_dtor): Remove.
9351         (ada_catchpoint_location_ops): Remove.
9352         (allocate_location_exception): Update.
9353         * breakpoint.h (struct bp_location_ops): Remove.
9354         (class bp_location) <bp_location>: Remove bp_location_ops
9355         parameter.
9356         <~bp_location>: Add destructor.
9357         <ops>: Remove.
9358
9359 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9360             Pedro Alves  <palves@redhat.com>
9361
9362         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9363         'PATH_MAX'.
9364
9365 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9366             Samuel Thibault  <samuel.thibault@gnu.org>
9367             Thomas Schwinge  <thomas@codesourcery.com>
9368
9369         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9370         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9371
9372 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9373
9374         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9375         (check_empty): Use "const char *".
9376
9377         * gnu-nat.c (gnu_nat_target::detach): Instead of
9378         'detach_inferior (pid)' call
9379         'detach_inferior (find_inferior_pid (pid))'.
9380
9381         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9382         'nat/fork-inferior.o'.
9383         * gnu-nat.c: #include "nat/fork-inferior.h".
9384
9385         * gnu-nat.c (gnu_nat_target::detach): Instead of
9386         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9387         * gnu-nat.h: #include "inf-child.h".
9388         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9389         'i386_gnu_nat_target::fetch_registers'.
9390         (gnu_store_registers): Rename/move to
9391         'i386_gnu_nat_target::store_registers'.
9392
9393         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9394         * gnu-nat.h (mach_thread_info): New function.
9395         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9396
9397         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9398
9399 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9400
9401         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9402
9403 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9404
9405         * windows-nat.c (windows_add_thread): Add new parameter
9406         "main_thread_p" with default value set to false.  Update
9407         function documentation as well as all callers.
9408         (windows_delete_thread): Likewise.
9409         (fake_create_process): Update call to windows_add_thread.
9410         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9411         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9412         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9413         call to windows_delete_thread.
9414
9415 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9416
9417         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9418
9419 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9420
9421         * symfile.c (find_separate_debug_file): Use canonical path of
9422         sysroot with child_path instead of gdb_sysroot if it is valid.
9423
9424 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9425
9426         * symfile.c (find_separate_debug_file): Use child_path to
9427         determine if an object file is under a sysroot.
9428
9429 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9430
9431         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9432         unittests/child-path-selftests.c.
9433         * common/pathstuff.c (child_path): New function.
9434         * common/pathstuff.h (child_path): New prototype.
9435         * unittests/child-path-selftests.c: New file.
9436
9437 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9438
9439         * symfile.c (find_separate_debug_file): Look for separate debug
9440         files in debug directories under the sysroot.
9441
9442 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9443
9444         * symtab.h (struct minimal_symbol data_p): New const method.
9445         (struct minimal_symbol text_p): Likewise.
9446         * symtab.c (output_source_filename): Use file name style
9447         to print file name.
9448         (print_symbol_info): Likewise.
9449         (print_msymbol_info): Use address style to print addresses.
9450         Use function name style to print executable text symbols.
9451         (expand_symtab_containing_pc): Use data_p.
9452         (find_pc_sect_compunit_symtab): Likewise.
9453
9454 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9455
9456         * breakpoint.c (describe_other_breakpoints): Use address style
9457         to print addresses.
9458         (say_where): Likewise.
9459
9460 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9461
9462         * ada-typeprint.c (print_func_type): Print function name
9463         style to print function name.
9464         * c-typeprint.c (c_print_type_1): Likewise.
9465
9466 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9467
9468         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9469         for execve.
9470
9471 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9472
9473         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9474         type_stack.
9475
9476 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9477
9478         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9479         TYPE_CODE_REF types.
9480
9481 2019-02-08  Jim Wilson  <jimw@sifive.com>
9482
9483         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9484         (riscv_linux_fregset): New.
9485         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9486
9487 2019-02-07  Tom Tromey  <tom@tromey.com>
9488
9489         * thread.c (thread_cancel_execution_command): Update.
9490         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9491         methods.
9492         (struct thread_fsm_ops): Remove.
9493         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9494         (thread_fsm_should_stop, thread_fsm_return_value)
9495         (thread_fsm_set_finished, thread_fsm_finished_p)
9496         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9497         Don't declare.
9498         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9499         * infrun.c (clear_proceed_status_thread)
9500         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9501         (print_stop_event): Update.
9502         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9503         Add constructor.
9504         (step_command_fsm_ops): Remove.
9505         (new_step_command_fsm): Remove.
9506         (step_1): Update.
9507         (step_command_fsm::should_stop): Rename from
9508         step_command_fsm_should_stop.
9509         (step_command_fsm::clean_up): Rename from
9510         step_command_fsm_clean_up.
9511         (step_command_fsm::do_async_reply_reason): Rename from
9512         step_command_fsm_async_reply_reason.
9513         (struct until_next_fsm): Inherit from thread_fsm.  Add
9514         constructor.
9515         (until_next_fsm_ops): Remove.
9516         (new_until_next_fsm): Remove.
9517         (until_next_fsm::should_stop): Rename from
9518         until_next_fsm_should_stop.
9519         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9520         (until_next_fsm::do_async_reply_reason): Rename from
9521         until_next_fsm_async_reply_reason.
9522         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9523         constructor.  Change type of breakpoint.
9524         (finish_command_fsm_ops): Remove.
9525         (new_finish_command_fsm): Remove.
9526         (finish_command_fsm::should_stop): Rename from
9527         finish_command_fsm_should_stop.
9528         (finish_command_fsm::clean_up): Rename from
9529         finish_command_fsm_clean_up.
9530         (finish_command_fsm::return_value): Rename from
9531         finish_command_fsm_return_value.
9532         (finish_command_fsm::do_async_reply_reason): Rename from
9533         finish_command_fsm_async_reply_reason.
9534         (finish_command): Update.
9535         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9536         Add constructor.
9537         (call_thread_fsm_ops): Remove.
9538         (call_thread_fsm::call_thread_fsm): Rename from
9539         new_call_thread_fsm.
9540         (call_thread_fsm::should_stop): Rename from
9541         call_thread_fsm_should_stop.
9542         (call_thread_fsm::should_notify_stop): Rename from
9543         call_thread_fsm_should_notify_stop.
9544         (run_inferior_call, call_function_by_hand_dummy): Update.
9545         * cli/cli-interp.c (should_print_stop_to_console): Update.
9546         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9547         Add constructor.  Change type of location_breakpoint,
9548         caller_breakpoint.
9549         (until_break_fsm_ops): Remove.
9550         (new_until_break_fsm): Remove.
9551         (until_break_fsm::should_stop): Rename from
9552         until_break_fsm_should_stop.
9553         (until_break_fsm::clean_up): Rename from
9554         until_break_fsm_clean_up.
9555         (until_break_fsm::do_async_reply_reason): Rename from
9556         until_break_fsm_async_reply_reason.
9557         (until_break_command): Update.
9558         * thread-fsm.c: Remove.
9559         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9560
9561 2019-02-07  Tom Tromey  <tom@tromey.com>
9562
9563         * yy-remap.h: Add include guard.
9564         * xtensa-tdep.h: Add include guard.
9565         * xcoffread.h: Rename include guard.
9566         * varobj-iter.h: Add include guard.
9567         * tui/tui.h: Rename include guard.
9568         * tui/tui-winsource.h: Rename include guard.
9569         * tui/tui-wingeneral.h: Rename include guard.
9570         * tui/tui-windata.h: Rename include guard.
9571         * tui/tui-win.h: Rename include guard.
9572         * tui/tui-stack.h: Rename include guard.
9573         * tui/tui-source.h: Rename include guard.
9574         * tui/tui-regs.h: Rename include guard.
9575         * tui/tui-out.h: Rename include guard.
9576         * tui/tui-layout.h: Rename include guard.
9577         * tui/tui-io.h: Rename include guard.
9578         * tui/tui-hooks.h: Rename include guard.
9579         * tui/tui-file.h: Rename include guard.
9580         * tui/tui-disasm.h: Rename include guard.
9581         * tui/tui-data.h: Rename include guard.
9582         * tui/tui-command.h: Rename include guard.
9583         * tic6x-tdep.h: Add include guard.
9584         * target/waitstatus.h: Rename include guard.
9585         * target/wait.h: Rename include guard.
9586         * target/target.h: Rename include guard.
9587         * target/resume.h: Rename include guard.
9588         * target-float.h: Rename include guard.
9589         * stabsread.h: Add include guard.
9590         * rs6000-tdep.h: Add include guard.
9591         * riscv-fbsd-tdep.h: Add include guard.
9592         * regformats/regdef.h: Rename include guard.
9593         * record.h: Rename include guard.
9594         * python/python.h: Rename include guard.
9595         * python/python-internal.h: Rename include guard.
9596         * python/py-stopevent.h: Rename include guard.
9597         * python/py-ref.h: Rename include guard.
9598         * python/py-record.h: Rename include guard.
9599         * python/py-record-full.h: Rename include guard.
9600         * python/py-record-btrace.h: Rename include guard.
9601         * python/py-instruction.h: Rename include guard.
9602         * python/py-events.h: Rename include guard.
9603         * python/py-event.h: Rename include guard.
9604         * procfs.h: Add include guard.
9605         * proc-utils.h: Add include guard.
9606         * p-lang.h: Add include guard.
9607         * or1k-tdep.h: Rename include guard.
9608         * observable.h: Rename include guard.
9609         * nto-tdep.h: Rename include guard.
9610         * nat/x86-linux.h: Rename include guard.
9611         * nat/x86-linux-dregs.h: Rename include guard.
9612         * nat/x86-gcc-cpuid.h: Add include guard.
9613         * nat/x86-dregs.h: Rename include guard.
9614         * nat/x86-cpuid.h: Rename include guard.
9615         * nat/ppc-linux.h: Rename include guard.
9616         * nat/mips-linux-watch.h: Rename include guard.
9617         * nat/linux-waitpid.h: Rename include guard.
9618         * nat/linux-ptrace.h: Rename include guard.
9619         * nat/linux-procfs.h: Rename include guard.
9620         * nat/linux-osdata.h: Rename include guard.
9621         * nat/linux-nat.h: Rename include guard.
9622         * nat/linux-namespaces.h: Rename include guard.
9623         * nat/linux-btrace.h: Rename include guard.
9624         * nat/glibc_thread_db.h: Rename include guard.
9625         * nat/gdb_thread_db.h: Rename include guard.
9626         * nat/gdb_ptrace.h: Rename include guard.
9627         * nat/fork-inferior.h: Rename include guard.
9628         * nat/amd64-linux-siginfo.h: Rename include guard.
9629         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9630         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9631         * nat/aarch64-linux.h: Rename include guard.
9632         * nat/aarch64-linux-hw-point.h: Rename include guard.
9633         * mn10300-tdep.h: Add include guard.
9634         * mips-linux-tdep.h: Add include guard.
9635         * mi/mi-parse.h: Rename include guard.
9636         * mi/mi-out.h: Rename include guard.
9637         * mi/mi-main.h: Rename include guard.
9638         * mi/mi-interp.h: Rename include guard.
9639         * mi/mi-getopt.h: Rename include guard.
9640         * mi/mi-console.h: Rename include guard.
9641         * mi/mi-common.h: Rename include guard.
9642         * mi/mi-cmds.h: Rename include guard.
9643         * mi/mi-cmd-break.h: Rename include guard.
9644         * m2-lang.h: Add include guard.
9645         * location.h: Rename include guard.
9646         * linux-record.h: Rename include guard.
9647         * linux-nat.h: Add include guard.
9648         * linux-fork.h: Add include guard.
9649         * i386-darwin-tdep.h: Rename include guard.
9650         * hppa-linux-offsets.h: Add include guard.
9651         * guile/guile.h: Rename include guard.
9652         * guile/guile-internal.h: Rename include guard.
9653         * gnu-nat.h: Rename include guard.
9654         * gdb-stabs.h: Rename include guard.
9655         * frv-tdep.h: Add include guard.
9656         * f-lang.h: Add include guard.
9657         * event-loop.h: Add include guard.
9658         * darwin-nat.h: Rename include guard.
9659         * cp-abi.h: Rename include guard.
9660         * config/sparc/nm-sol2.h: Rename include guard.
9661         * config/nm-nto.h: Rename include guard.
9662         * config/nm-linux.h: Add include guard.
9663         * config/i386/nm-i386gnu.h: Rename include guard.
9664         * config/djgpp/nl_types.h: Rename include guard.
9665         * config/djgpp/langinfo.h: Rename include guard.
9666         * compile/gcc-cp-plugin.h: Add include guard.
9667         * compile/gcc-c-plugin.h: Add include guard.
9668         * compile/compile.h: Rename include guard.
9669         * compile/compile-object-run.h: Rename include guard.
9670         * compile/compile-object-load.h: Rename include guard.
9671         * compile/compile-internal.h: Rename include guard.
9672         * compile/compile-cplus.h: Rename include guard.
9673         * compile/compile-c.h: Rename include guard.
9674         * common/xml-utils.h: Rename include guard.
9675         * common/x86-xstate.h: Rename include guard.
9676         * common/version.h: Rename include guard.
9677         * common/vec.h: Rename include guard.
9678         * common/tdesc.h: Rename include guard.
9679         * common/selftest.h: Rename include guard.
9680         * common/scoped_restore.h: Rename include guard.
9681         * common/scoped_mmap.h: Rename include guard.
9682         * common/scoped_fd.h: Rename include guard.
9683         * common/safe-iterator.h: Rename include guard.
9684         * common/run-time-clock.h: Rename include guard.
9685         * common/refcounted-object.h: Rename include guard.
9686         * common/queue.h: Rename include guard.
9687         * common/ptid.h: Rename include guard.
9688         * common/print-utils.h: Rename include guard.
9689         * common/preprocessor.h: Rename include guard.
9690         * common/pathstuff.h: Rename include guard.
9691         * common/observable.h: Rename include guard.
9692         * common/netstuff.h: Rename include guard.
9693         * common/job-control.h: Rename include guard.
9694         * common/host-defs.h: Rename include guard.
9695         * common/gdb_wait.h: Rename include guard.
9696         * common/gdb_vecs.h: Rename include guard.
9697         * common/gdb_unlinker.h: Rename include guard.
9698         * common/gdb_unique_ptr.h: Rename include guard.
9699         * common/gdb_tilde_expand.h: Rename include guard.
9700         * common/gdb_sys_time.h: Rename include guard.
9701         * common/gdb_string_view.h: Rename include guard.
9702         * common/gdb_splay_tree.h: Rename include guard.
9703         * common/gdb_setjmp.h: Rename include guard.
9704         * common/gdb_ref_ptr.h: Rename include guard.
9705         * common/gdb_optional.h: Rename include guard.
9706         * common/gdb_locale.h: Rename include guard.
9707         * common/gdb_assert.h: Rename include guard.
9708         * common/filtered-iterator.h: Rename include guard.
9709         * common/filestuff.h: Rename include guard.
9710         * common/fileio.h: Rename include guard.
9711         * common/environ.h: Rename include guard.
9712         * common/common-utils.h: Rename include guard.
9713         * common/common-types.h: Rename include guard.
9714         * common/common-regcache.h: Rename include guard.
9715         * common/common-inferior.h: Rename include guard.
9716         * common/common-gdbthread.h: Rename include guard.
9717         * common/common-exceptions.h: Rename include guard.
9718         * common/common-defs.h: Rename include guard.
9719         * common/common-debug.h: Rename include guard.
9720         * common/cleanups.h: Rename include guard.
9721         * common/buffer.h: Rename include guard.
9722         * common/btrace-common.h: Rename include guard.
9723         * common/break-common.h: Rename include guard.
9724         * cli/cli-utils.h: Rename include guard.
9725         * cli/cli-style.h: Rename include guard.
9726         * cli/cli-setshow.h: Rename include guard.
9727         * cli/cli-script.h: Rename include guard.
9728         * cli/cli-interp.h: Rename include guard.
9729         * cli/cli-decode.h: Rename include guard.
9730         * cli/cli-cmds.h: Rename include guard.
9731         * charset-list.h: Add include guard.
9732         * buildsym-legacy.h: Rename include guard.
9733         * bfin-tdep.h: Add include guard.
9734         * ax.h: Rename include guard.
9735         * arm-linux-tdep.h: Add include guard.
9736         * arm-fbsd-tdep.h: Add include guard.
9737         * arch/xtensa.h: Rename include guard.
9738         * arch/tic6x.h: Add include guard.
9739         * arch/i386.h: Add include guard.
9740         * arch/arm.h: Rename include guard.
9741         * arch/arm-linux.h: Rename include guard.
9742         * arch/arm-get-next-pcs.h: Rename include guard.
9743         * arch/amd64.h: Add include guard.
9744         * arch/aarch64-insn.h: Rename include guard.
9745         * arch-utils.h: Rename include guard.
9746         * annotate.h: Add include guard.
9747         * amd64-darwin-tdep.h: Rename include guard.
9748         * aarch64-linux-tdep.h: Add include guard.
9749         * aarch64-fbsd-tdep.h: Add include guard.
9750         * aarch32-linux-nat.h: Add include guard.
9751
9752 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9753
9754         * macrotab.c (macro_define_internal): New function that
9755         factorizes macro_define_object_internal and macro_define_function
9756         code.
9757         (macro_define_object_internal): Use macro_define_internal.
9758         (macro_define_function): Likewise.
9759
9760 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9761
9762         * macrocmd.c (extract_identifier): Return
9763         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9764         callers.
9765
9766 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9767
9768         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9769
9770 2019-02-05  Tom Tromey  <tom@tromey.com>
9771
9772         * target.c (target_stack::unpush): Move assertion earlier.
9773
9774 2019-01-30  Tom Tromey  <tom@tromey.com>
9775
9776         PR python/23615:
9777         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9778         (gdbpy_parse_and_eval): Likewise.
9779         * python/python-internal.h (gdbpy_allow_threads): New class.
9780
9781 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9782
9783         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9784         (aarch64_fbsd_fpregmap): Move earlier.
9785         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9786         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9787         instead of individual calls to trad_frame_set_reg_addr.
9788         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9789         earlier.
9790         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9791         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9792         instead of individual calls to trad_frame_set_reg_addr.
9793
9794 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9795
9796         * CONTRIBUTE: Replace contribution list with wiki link.
9797
9798 2019-01-25  Tom Tromey  <tom@tromey.com>
9799
9800         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9801
9802 2019-01-25  Tom Tromey  <tom@tromey.com>
9803
9804         * xtensa-linux-nat.c: Fix common/ includes.
9805         * xml-support.h: Fix common/ includes.
9806         * xml-support.c: Fix common/ includes.
9807         * x86-linux-nat.c: Fix common/ includes.
9808         * windows-nat.c: Fix common/ includes.
9809         * varobj.h: Fix common/ includes.
9810         * varobj.c: Fix common/ includes.
9811         * value.c: Fix common/ includes.
9812         * valops.c: Fix common/ includes.
9813         * utils.c: Fix common/ includes.
9814         * unittests/xml-utils-selftests.c: Fix common/ includes.
9815         * unittests/utils-selftests.c: Fix common/ includes.
9816         * unittests/unpack-selftests.c: Fix common/ includes.
9817         * unittests/tracepoint-selftests.c: Fix common/ includes.
9818         * unittests/style-selftests.c: Fix common/ includes.
9819         * unittests/string_view-selftests.c: Fix common/ includes.
9820         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9821         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9822         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9823         * unittests/rsp-low-selftests.c: Fix common/ includes.
9824         * unittests/parse-connection-spec-selftests.c: Fix common/
9825         includes.
9826         * unittests/optional-selftests.c: Fix common/ includes.
9827         * unittests/offset-type-selftests.c: Fix common/ includes.
9828         * unittests/observable-selftests.c: Fix common/ includes.
9829         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9830         * unittests/memrange-selftests.c: Fix common/ includes.
9831         * unittests/memory-map-selftests.c: Fix common/ includes.
9832         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9833         * unittests/function-view-selftests.c: Fix common/ includes.
9834         * unittests/environ-selftests.c: Fix common/ includes.
9835         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9836         * unittests/common-utils-selftests.c: Fix common/ includes.
9837         * unittests/cli-utils-selftests.c: Fix common/ includes.
9838         * unittests/array-view-selftests.c: Fix common/ includes.
9839         * ui-file.c: Fix common/ includes.
9840         * tui/tui-io.c: Fix common/ includes.
9841         * tracepoint.h: Fix common/ includes.
9842         * tracepoint.c: Fix common/ includes.
9843         * tracefile-tfile.c: Fix common/ includes.
9844         * top.h: Fix common/ includes.
9845         * top.c: Fix common/ includes.
9846         * thread.c: Fix common/ includes.
9847         * target/waitstatus.h: Fix common/ includes.
9848         * target/waitstatus.c: Fix common/ includes.
9849         * target.h: Fix common/ includes.
9850         * target.c: Fix common/ includes.
9851         * target-memory.c: Fix common/ includes.
9852         * target-descriptions.c: Fix common/ includes.
9853         * symtab.h: Fix common/ includes.
9854         * symfile.c: Fix common/ includes.
9855         * stap-probe.c: Fix common/ includes.
9856         * spu-linux-nat.c: Fix common/ includes.
9857         * sparc-nat.c: Fix common/ includes.
9858         * source.c: Fix common/ includes.
9859         * solib.c: Fix common/ includes.
9860         * solib-target.c: Fix common/ includes.
9861         * ser-unix.c: Fix common/ includes.
9862         * ser-tcp.c: Fix common/ includes.
9863         * ser-pipe.c: Fix common/ includes.
9864         * ser-base.c: Fix common/ includes.
9865         * selftest-arch.c: Fix common/ includes.
9866         * s12z-tdep.c: Fix common/ includes.
9867         * rust-exp.y: Fix common/ includes.
9868         * rs6000-aix-tdep.c: Fix common/ includes.
9869         * riscv-tdep.c: Fix common/ includes.
9870         * remote.c: Fix common/ includes.
9871         * remote-notif.h: Fix common/ includes.
9872         * remote-fileio.h: Fix common/ includes.
9873         * remote-fileio.c: Fix common/ includes.
9874         * regcache.h: Fix common/ includes.
9875         * regcache.c: Fix common/ includes.
9876         * record-btrace.c: Fix common/ includes.
9877         * python/python.c: Fix common/ includes.
9878         * python/py-type.c: Fix common/ includes.
9879         * python/py-inferior.c: Fix common/ includes.
9880         * progspace.h: Fix common/ includes.
9881         * producer.c: Fix common/ includes.
9882         * procfs.c: Fix common/ includes.
9883         * proc-api.c: Fix common/ includes.
9884         * printcmd.c: Fix common/ includes.
9885         * ppc-linux-nat.c: Fix common/ includes.
9886         * parser-defs.h: Fix common/ includes.
9887         * osdata.c: Fix common/ includes.
9888         * obsd-nat.c: Fix common/ includes.
9889         * nat/x86-linux.c: Fix common/ includes.
9890         * nat/x86-linux-dregs.c: Fix common/ includes.
9891         * nat/x86-dregs.h: Fix common/ includes.
9892         * nat/x86-dregs.c: Fix common/ includes.
9893         * nat/ppc-linux.c: Fix common/ includes.
9894         * nat/mips-linux-watch.h: Fix common/ includes.
9895         * nat/mips-linux-watch.c: Fix common/ includes.
9896         * nat/linux-waitpid.c: Fix common/ includes.
9897         * nat/linux-ptrace.h: Fix common/ includes.
9898         * nat/linux-ptrace.c: Fix common/ includes.
9899         * nat/linux-procfs.c: Fix common/ includes.
9900         * nat/linux-personality.c: Fix common/ includes.
9901         * nat/linux-osdata.c: Fix common/ includes.
9902         * nat/linux-namespaces.c: Fix common/ includes.
9903         * nat/linux-btrace.h: Fix common/ includes.
9904         * nat/linux-btrace.c: Fix common/ includes.
9905         * nat/fork-inferior.c: Fix common/ includes.
9906         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9907         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9908         * nat/aarch64-linux.c: Fix common/ includes.
9909         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9910         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9911         * namespace.h: Fix common/ includes.
9912         * mips-linux-tdep.c: Fix common/ includes.
9913         * minsyms.c: Fix common/ includes.
9914         * mi/mi-parse.h: Fix common/ includes.
9915         * mi/mi-main.c: Fix common/ includes.
9916         * mi/mi-cmd-env.c: Fix common/ includes.
9917         * memrange.h: Fix common/ includes.
9918         * memattr.c: Fix common/ includes.
9919         * maint.h: Fix common/ includes.
9920         * maint.c: Fix common/ includes.
9921         * main.c: Fix common/ includes.
9922         * machoread.c: Fix common/ includes.
9923         * location.c: Fix common/ includes.
9924         * linux-thread-db.c: Fix common/ includes.
9925         * linux-nat.c: Fix common/ includes.
9926         * linux-fork.c: Fix common/ includes.
9927         * inline-frame.c: Fix common/ includes.
9928         * infrun.c: Fix common/ includes.
9929         * inflow.c: Fix common/ includes.
9930         * inferior.h: Fix common/ includes.
9931         * inferior.c: Fix common/ includes.
9932         * infcmd.c: Fix common/ includes.
9933         * inf-ptrace.c: Fix common/ includes.
9934         * inf-child.c: Fix common/ includes.
9935         * ia64-linux-nat.c: Fix common/ includes.
9936         * i387-tdep.c: Fix common/ includes.
9937         * i386-tdep.c: Fix common/ includes.
9938         * i386-linux-tdep.c: Fix common/ includes.
9939         * i386-linux-nat.c: Fix common/ includes.
9940         * i386-go32-tdep.c: Fix common/ includes.
9941         * i386-fbsd-tdep.c: Fix common/ includes.
9942         * i386-fbsd-nat.c: Fix common/ includes.
9943         * guile/scm-type.c: Fix common/ includes.
9944         * guile/guile.c: Fix common/ includes.
9945         * go32-nat.c: Fix common/ includes.
9946         * gnu-nat.c: Fix common/ includes.
9947         * gdbthread.h: Fix common/ includes.
9948         * gdbarch-selftests.c: Fix common/ includes.
9949         * gdb_usleep.c: Fix common/ includes.
9950         * gdb_select.h: Fix common/ includes.
9951         * gdb_bfd.c: Fix common/ includes.
9952         * gcore.c: Fix common/ includes.
9953         * fork-child.c: Fix common/ includes.
9954         * findvar.c: Fix common/ includes.
9955         * fbsd-nat.c: Fix common/ includes.
9956         * event-top.c: Fix common/ includes.
9957         * event-loop.c: Fix common/ includes.
9958         * dwarf2read.c: Fix common/ includes.
9959         * dwarf2loc.c: Fix common/ includes.
9960         * dwarf2-frame.c: Fix common/ includes.
9961         * dwarf-index-cache.c: Fix common/ includes.
9962         * dtrace-probe.c: Fix common/ includes.
9963         * disasm-selftests.c: Fix common/ includes.
9964         * defs.h: Fix common/ includes.
9965         * csky-tdep.c: Fix common/ includes.
9966         * cp-valprint.c: Fix common/ includes.
9967         * cp-support.h: Fix common/ includes.
9968         * cp-support.c: Fix common/ includes.
9969         * corelow.c: Fix common/ includes.
9970         * completer.h: Fix common/ includes.
9971         * completer.c: Fix common/ includes.
9972         * compile/compile.c: Fix common/ includes.
9973         * compile/compile-loc2c.c: Fix common/ includes.
9974         * compile/compile-cplus-types.c: Fix common/ includes.
9975         * compile/compile-cplus-symbols.c: Fix common/ includes.
9976         * command.h: Fix common/ includes.
9977         * cli/cli-dump.c: Fix common/ includes.
9978         * cli/cli-cmds.c: Fix common/ includes.
9979         * charset.c: Fix common/ includes.
9980         * build-id.c: Fix common/ includes.
9981         * btrace.h: Fix common/ includes.
9982         * btrace.c: Fix common/ includes.
9983         * breakpoint.h: Fix common/ includes.
9984         * breakpoint.c: Fix common/ includes.
9985         * ax.h:
9986         (enum agent_op): Fix common/ includes.
9987         * ax-general.c (struct aop_map): Fix common/ includes.
9988         * ax-gdb.c: Fix common/ includes.
9989         * auxv.c: Fix common/ includes.
9990         * auto-load.c: Fix common/ includes.
9991         * arm-tdep.c: Fix common/ includes.
9992         * arch/riscv.c: Fix common/ includes.
9993         * arch/ppc-linux-common.c: Fix common/ includes.
9994         * arch/i386.c: Fix common/ includes.
9995         * arch/arm.c: Fix common/ includes.
9996         * arch/arm-linux.c: Fix common/ includes.
9997         * arch/arm-get-next-pcs.c: Fix common/ includes.
9998         * arch/amd64.c: Fix common/ includes.
9999         * arch/aarch64.c: Fix common/ includes.
10000         * arch/aarch64-insn.c: Fix common/ includes.
10001         * arch-utils.c: Fix common/ includes.
10002         * amd64-windows-tdep.c: Fix common/ includes.
10003         * amd64-tdep.c: Fix common/ includes.
10004         * amd64-sol2-tdep.c: Fix common/ includes.
10005         * amd64-obsd-tdep.c: Fix common/ includes.
10006         * amd64-nbsd-tdep.c: Fix common/ includes.
10007         * amd64-linux-tdep.c: Fix common/ includes.
10008         * amd64-linux-nat.c: Fix common/ includes.
10009         * amd64-fbsd-tdep.c: Fix common/ includes.
10010         * amd64-fbsd-nat.c: Fix common/ includes.
10011         * amd64-dicos-tdep.c: Fix common/ includes.
10012         * amd64-darwin-tdep.c: Fix common/ includes.
10013         * agent.c: Fix common/ includes.
10014         * ada-lang.h: Fix common/ includes.
10015         * ada-lang.c: Fix common/ includes.
10016         * aarch64-tdep.c: Fix common/ includes.
10017
10018 2019-01-25  Tom Tromey  <tom@tromey.com>
10019
10020         * common/create-version.sh: Use common/version.h.
10021
10022 2019-01-24  Pedro Alves  <palves@redhat.com>
10023
10024         * infrun.c (signal_stop, signal_print, signal_program)
10025         (signal_catch, signal_pass): Now arrays instead of pointers.
10026         (update_signals_program_target, do_target_resume)
10027         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10028         * linux-nat.c (linux_nat_target::pass_signals)
10029         (linux_nat_target::create_inferior, linux_nat_target::attach):
10030         Adjust.
10031         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10032         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10033         * procfs.c (procfs_target::pass_signals): Adjust.
10034         * record-full.c (record_full_target::resume): Adjust.
10035         * remote.c (remote_target::pass_signals)
10036         (remote_target::program_signals): Adjust.
10037         * target-debug.h (target_debug_print_signals): Now takes a
10038         gdb::array_view as parameter.  Adjust.
10039         * target.h (target_ops) <pass_signals, program_signals>: Replace
10040         pointer and length parameters with gdb::array_view.
10041         (target_pass_signals, target_program_signals): Likewise.
10042         * target-delegates.c: Regenerate.
10043
10044 2019-01-24  Pedro Alves  <palves@redhat.com>
10045
10046         * common/forward-scope-exit.h
10047         (forward_scope_exit::forward_scope_exit): Pass arguments to
10048         m_bind_function directly, instead of creating a std::bind and
10049         copying that.
10050
10051 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10052
10053         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10054         for static members.
10055         (pass_in_v_vfp_candidate): Likewise.
10056
10057 2019-01-23  Tom Tromey  <tom@tromey.com>
10058             Pedro Alves  <palves@redhat.com>
10059
10060         * regcache.c (class regcache_invalidator): Remove.
10061         (regcache::raw_write): Use make_scope_exit.
10062
10063 2019-01-23  Tom Tromey  <tom@tromey.com>
10064
10065         * ui-out.h (class ui_out_emit_type): Update comment.
10066
10067 2019-01-23  Tom Tromey  <tom@tromey.com>
10068
10069         * infrun.c (fetch_inferior_event): Update comment.
10070
10071 2019-01-23  Tom Tromey  <tom@tromey.com>
10072             Pedro Alves  <palves@redhat.com>
10073
10074         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10075         parameter.
10076         (fetch_inferior_event): Use SCOPE_EXIT.
10077
10078
10079 2019-01-23  Tom Tromey  <tom@tromey.com>
10080             Pedro Alves  <palves@redhat.com>
10081
10082         * infrun.c (disable_thread_events): Delete.
10083         (stop_all_threads): Use SCOPE_EXIT.
10084
10085 2019-01-23  Tom Tromey  <tom@tromey.com>
10086             Pedro Alves  <palves@redhat.com>
10087
10088         * symfile.c: Include forward-scope-exit.h.
10089         (clear_symtab_users_cleanup): Replace forward declaration with
10090         a FORWARD_SCOPE_EXIT.
10091         (syms_from_objfile_1): Use the forward_scope_exit and
10092         gdb::optional instead of cleanup_function.
10093         (reread_symbols): Use the forward_scope_exit instead of
10094         cleanup_function.
10095         (clear_symtab_users_cleanup): Remove function.
10096
10097 2019-01-23  Tom Tromey  <tom@tromey.com>
10098             Pedro Alves  <palves@redhat.com>
10099
10100         * linux-nat.c: Include scope-exit.h.
10101         (cleanup_target_stop): Remove.
10102         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10103         SCOPE_EXIT.
10104
10105 2019-01-23  Tom Tromey  <tom@tromey.com>
10106             Pedro Alves  <palves@redhat.com>
10107
10108         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10109         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10110
10111 2019-01-23  Tom Tromey  <tom@tromey.com>
10112             Andrew Burgess  <andrew.burgess@embecosm.com>
10113             Pedro Alves  <palves@redhat.com>
10114
10115         * infrun.c (fetch_inferior_event): Use scope_exit.
10116         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10117         * top.c (execute_command): Use scope_exit.
10118         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10119         * utils.c (do_bpstat_clear_actions_cleanup)
10120         (make_bpstat_clear_actions_cleanup): Remove.
10121
10122 2019-01-23  Tom Tromey  <tom@tromey.com>
10123             Pedro Alves  <palves@redhat.com>
10124
10125         * infrun.c: Include "common/scope-exit.h"
10126         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10127         (wait_for_inferior): Use SCOPE_EXIT.
10128         (fetch_inferior_event): Use scope_exit.
10129
10130 2019-01-23  Tom Tromey  <tom@tromey.com>
10131             Pedro Alves  <palves@redhat.com>
10132
10133         * breakpoint.c (create_breakpoint): Remove cleanup.
10134
10135 2019-01-23  Tom Tromey  <tom@tromey.com>
10136             Andrew Burgess  <andrew.burgess@embecosm.com>
10137             Pedro Alves  <palves@redhat.com>
10138
10139 2019-01-23  Pedro Alves  <palves@redhat.com>
10140
10141         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10142
10143 2019-01-23  Pedro Alves  <palves@redhat.com>
10144             Andrew Burgess  <andrew.burgess@embecosm.com>
10145
10146         * gdbthread.h: Include "common/forward-scope-exit.h".
10147         (scoped_finish_thread_state): Redefine custom class in terms of
10148         forward_scope_exit.
10149
10150 2019-01-23  Pedro Alves  <palves@redhat.com>
10151             Andrew Burgess  <andrew.burgess@embecosm.com>
10152
10153         * common/forward-scope-exit.h: New file.
10154
10155 2019-01-23  Pedro Alves  <palves@redhat.com>
10156             Andrew Burgess  <andrew.burgess@embecosm.com>
10157             Tom Tromey  <tom@tromey.com>
10158
10159         * common/scope-exit.h: New file.
10160
10161 2019-01-23  Pedro Alves  <palves@redhat.com>
10162
10163         * common/preprocessor.h (ESC): Rename to ...
10164         (ESC_PARENS): ... this.
10165         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10166         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10167
10168 2019-01-23  Tom Tromey  <tom@tromey.com>
10169
10170         * language.h (class scoped_switch_to_sym_language_if_auto):
10171         Initialize m_lang in both cases.
10172
10173 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10174
10175         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10176         with XCNEW.
10177
10178 2019-01-22  Tom Tromey  <tom@tromey.com>
10179
10180         * corelow.c: Do not include sys/file.h.
10181
10182 2019-01-22  Tom Tromey  <tom@tromey.com>
10183
10184         * tui/tui-wingeneral.h: Include gdb_curses.h.
10185
10186 2019-01-22  Tom Tromey  <tom@tromey.com>
10187
10188         * source-cache.h (class source_cache) <get_source_lines,
10189         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10190
10191 2019-01-22  Tom Tromey  <tom@tromey.com>
10192
10193         * remote-fileio.h (struct remote_target): Declare.
10194
10195 2019-01-22  Tom Tromey  <tom@tromey.com>
10196
10197         * python/py-arch.c: Do not include py-ref.h.
10198         * python/py-bpevent.c: Do not include py-ref.h.
10199         * python/py-cmd.c: Do not include py-ref.h.
10200         * python/py-continueevent.c: Do not include py-ref.h.
10201         * python/py-event.h: Do not include py-ref.h.
10202         * python/py-evtregistry.c: Do not include py-ref.h.
10203         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10204         * python/py-frame.c: Do not include py-ref.h.
10205         * python/py-framefilter.c: Do not include py-ref.h.
10206         * python/py-function.c: Do not include py-ref.h.
10207         * python/py-infevents.c: Do not include py-ref.h.
10208         * python/py-linetable.c: Do not include py-ref.h.
10209         * python/py-objfile.c: Do not include py-ref.h.
10210         * python/py-param.c: Do not include py-ref.h.
10211         * python/py-prettyprint.c: Do not include py-ref.h.
10212         * python/py-progspace.c: Do not include py-ref.h.
10213         * python/py-symbol.c: Do not include py-ref.h.
10214         * python/py-symtab.c: Do not include py-ref.h.
10215         * python/py-type.c: Do not include py-ref.h.
10216         * python/py-unwind.c: Do not include py-ref.h.
10217         * python/py-utils.c: Do not include py-ref.h.
10218         * python/py-value.c: Do not include py-ref.h.
10219         * python/py-varobj.c: Do not include py-ref.h.
10220         * python/py-xmethods.c: Do not include py-ref.h.
10221         * python/python.c: Do not include py-ref.h.
10222         * varobj.c: Do not include py-ref.h.
10223
10224 2019-01-22  Tom Tromey  <tom@tromey.com>
10225
10226         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10227         keyword for bcache.
10228
10229 2019-01-22  Tom Tromey  <tom@tromey.com>
10230
10231         * compile/compile-cplus-types.c: Remove a comment by #include.
10232
10233 2019-01-22  Tom Tromey  <tom@tromey.com>
10234
10235         * compile/gcc-c-plugin.h: Include compile-internal.h.
10236
10237 2019-01-22  Tom Tromey  <tom@tromey.com>
10238
10239         * stabsread.c (EXTERN): Do not define.
10240         (symnum, next_symbol_text_func, processing_gcc_compilation)
10241         (within_function, global_sym_chain, global_stabs)
10242         (previous_stab_code, this_object_header_files)
10243         (n_this_object_header_files)
10244         (n_allocated_this_object_header_files): Define.
10245         * stabsread.h (EXTERN): Never define.  Use "extern".
10246
10247 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10248
10249         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10250         history_value.
10251
10252 2019-01-21  Tom Tromey  <tom@tromey.com>
10253
10254         * ui-out.c: Fix includes.
10255         * tui/tui-source.c: Fix includes.
10256         * target.c: Fix includes.
10257         * remote.c: Fix includes.
10258         * regcache.c: Fix includes.
10259         * python/py-block.c: Fix includes.
10260         * printcmd.c: Fix includes.
10261         * or1k-tdep.c: Fix includes.
10262         * mi/mi-main.c: Fix includes.
10263         * m32r-tdep.c: Fix includes.
10264         * csky-tdep.c: Fix includes.
10265         * compile/compile-cplus-types.c: Fix includes.
10266         * cli/cli-interp.c: Fix includes.
10267
10268 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10269
10270         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10271         for padding.
10272
10273 2019-01-16  Tom Tromey  <tom@tromey.com>
10274
10275         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10276         earlier.
10277         (struct objfile) <msymbols_range>: Move from top level.
10278         <msymbols>: New method.
10279         (class objfile_msymbols): Remove.
10280         * symtab.c (default_collect_symbol_completion_matches_break_on):
10281         Update.
10282         * symmisc.c (dump_msymbols): Update.
10283         * stabsread.c (scan_file_globals): Update.
10284         * objc-lang.c (info_selectors_command, info_classes_command)
10285         (find_methods): Update.
10286         * minsyms.c (find_solib_trampoline_target): Update.
10287         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10288         * coffread.c (coff_symfile_read): Update.
10289         * ada-lang.c (ada_lookup_simple_minsym)
10290         (ada_collect_symbol_completion_matches): Update.
10291
10292 2019-01-16  Tom Tromey  <tom@tromey.com>
10293
10294         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10295         type.  Remove no-argument constructor.
10296         <iterator::operator++>: Simplify.
10297         <begin>: Update.
10298         <end>: Use minimal_symbol_count.
10299
10300 2019-01-16  Tom Tromey  <tom@tromey.com>
10301
10302         * objfiles.h (struct objfile) <psymtabs>: New method.
10303         (class objfile_psymtabs): Remove.
10304         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10305         typedef.
10306         <range>: New method.
10307         (require_partial_symbols): Change return type.
10308         * psymtab.c (require_partial_symbols)
10309         (psym_expand_symtabs_matching): Update.
10310         * mdebugread.c (parse_partial_symbols): Update.
10311         * dbxread.c (dbx_end_psymtab): Update.
10312
10313 2019-01-15  Tom Tromey  <tom@tromey.com>
10314
10315         * symtab.c (lookup_objfile_from_block)
10316         (lookup_symbol_in_objfile_symtabs)
10317         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10318         (find_line_symtab, info_sources_command)
10319         (default_collect_symbol_completion_matches_break_on)
10320         (make_source_files_completion_list): Update.
10321         * symmisc.c (print_objfile_statistics, dump_objfile)
10322         (maintenance_print_symbols, maintenance_info_symtabs)
10323         (maintenance_check_symtabs, maintenance_info_line_tables):
10324         Update.
10325         * source.c (select_source_symtab)
10326         (forget_cached_source_info_for_objfile): Update.
10327         * objfiles.h (class objfile_compunits): Remove.
10328         (struct objfile) <compunits_range>: New typedef.
10329         (compunits): New method.
10330         * objfiles.c (objfile_relocate1): Update.
10331         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10332         * maint.c (count_symtabs_and_blocks): Update.
10333         * linespec.c (iterate_over_all_matching_symtabs): Update.
10334         * cp-support.c (add_symbol_overload_list_qualified): Update.
10335         * coffread.c (coff_symtab_read): Update.
10336         * ada-lang.c (add_nonlocal_symbols)
10337         (ada_collect_symbol_completion_matches)
10338         (ada_add_global_exceptions): Update.
10339
10340 2019-01-15  Tom Tromey  <tom@tromey.com>
10341
10342         * progspace.h (program_space) <objfiles_safe_range>: New
10343         typedef.
10344         <objfiles_safe>: New method.
10345         * objfiles.h (class all_objfiles_safe): Remove.
10346         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10347         * jit.c (jit_inferior_exit_hook): Update.
10348
10349 2019-01-17  Tom Tromey  <tom@tromey.com>
10350
10351         * progspace.h (program_space) <objfiles_range>: New typedef.
10352         <objfiles>: New method.
10353         <objfiles_head>: Rename from objfiles.
10354         (object_files): Update.
10355         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10356         * guile/scm-pretty-print.c
10357         (ppscm_find_pretty_printer_from_objfiles): Update.
10358         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10359         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10360         Update.
10361         * python/py-progspace.c (pspy_get_objfiles): Update.
10362         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10363         Update.
10364         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10365         (objfpy_lookup_objfile_by_build_id): Update.
10366         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10367         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10368         Update.
10369         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10370         (expand_symtab_containing_pc, lookup_objfile_from_block)
10371         (lookup_static_symbol, basic_lookup_transparent_type)
10372         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10373         (find_line_symtab, info_sources_command)
10374         (default_collect_symbol_completion_matches_break_on)
10375         (make_source_files_completion_list, find_main_name): Update.
10376         * symmisc.c (print_symbol_bcache_statistics)
10377         (print_objfile_statistics, maintenance_print_symbols)
10378         (maintenance_print_msymbols, maintenance_print_objfiles)
10379         (maintenance_info_symtabs, maintenance_check_symtabs)
10380         (maintenance_expand_symtabs, maintenance_info_line_tables):
10381         Update.
10382         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10383         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10384         (map_overlay_command, unmap_overlay_command)
10385         (simple_overlay_update, expand_symtabs_matching)
10386         (map_symbol_filenames): Update.
10387         * symfile-debug.c (set_debug_symfile): Update.
10388         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10389         Update.
10390         * source.c (select_source_symtab, forget_cached_source_info):
10391         Update.
10392         * solib.c (solib_read_symbols): Update.
10393         * solib-spu.c (append_ocl_sos): Update.
10394         * psymtab.c (maintenance_print_psymbols)
10395         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10396         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10397         * printcmd.c (info_symbol_command): Update.
10398         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10399         Update.
10400         * objfiles.h (class all_objfiles): Remove.
10401         * objfiles.c (have_partial_symbols, have_full_symbols)
10402         (have_minimal_symbols, qsort_cmp, update_section_map)
10403         (shared_objfile_contains_address_p)
10404         (default_iterate_over_objfiles_in_search_order): Update.
10405         * objc-lang.c (info_selectors_command, info_classes_command)
10406         (find_methods): Update.
10407         * minsyms.c (find_solib_trampoline_target): Update.
10408         * maint.c (maintenance_info_sections)
10409         (maintenance_translate_address, count_symtabs_and_blocks):
10410         Update.
10411         * main.c (captured_main_1): Update.
10412         * linux-thread-db.c (try_thread_db_load_from_pdir)
10413         (has_libpthread): Update.
10414         * linespec.c (iterate_over_all_matching_symtabs)
10415         (search_minsyms_for_name): Update.
10416         * jit.c (jit_find_objf_with_entry_addr): Update.
10417         * hppa-tdep.c (find_unwind_entry)
10418         (hppa_lookup_stub_minimal_symbol): Update.
10419         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10420         Update.
10421         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10422         (elf_gnu_ifunc_resolve_by_got): Update.
10423         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10424         * dwarf-index-write.c (save_gdb_index_command): Update.
10425         * cp-support.c (add_symbol_overload_list_qualified): Update.
10426         * breakpoint.c (create_overlay_event_breakpoint)
10427         (create_longjmp_master_breakpoint)
10428         (create_std_terminate_master_breakpoint)
10429         (create_exception_master_breakpoint): Update.
10430         * blockframe.c (find_pc_partial_function): Update.
10431         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10432         (ada_collect_symbol_completion_matches)
10433         (ada_add_global_exceptions): Update.
10434
10435 2019-01-17  Tom Tromey  <tom@tromey.com>
10436
10437         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10438         declare VEC.
10439         (solib_target_parse_libraries): Change return type.
10440         (library_list_start_segment, library_list_start_section)
10441         (library_list_end_library, library_list_start_library); Update.
10442         (solib_target_free_library_list): Remove.
10443         (solib_target_parse_libraries): Remove cleanup.  Change return
10444         type.
10445         (solib_target_current_sos): Update.
10446
10447 2019-01-17  Tom Tromey  <tromey@bapiya>
10448
10449         * valprint.c: Replace "the the" with "the".
10450         * symtab.c: Replace "the the" with "the".
10451         * solib.c: Replace "the the" with "the".
10452         * solib-dsbt.c: Replace "the the" with "the".
10453         * linespec.c: Replace "the the" with "the".
10454         * dwarf2loc.h: Replace "the the" with "the".
10455         * amd64-windows-tdep.c: Replace "the the" with "the".
10456         * aarch64-tdep.c: Replace "the the" with "the".
10457
10458 2019-01-16  Keith Seitz  <keiths@redhat.com>
10459
10460         PR gdb/23773
10461         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10462         <builder>: Rename to ..
10463         <m_builder>: ... this and make private.
10464         (dwarf2_cu::get_builder): New method.  Change all users of
10465         `builder' to use this method.
10466         (dwarf2_start_symtab): Move to ...
10467         (dwarf2_cu::start_symtab): ... here.  Update all callers
10468         (setup_type_unit_groups): Move to ...
10469         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10470         callers.
10471         (dwarf2_cu::reset_builder): New method.
10472         (process_full_compunit, process_full_type_unit): Use
10473         dwarf2_cu::reset_builder.
10474         (follow_die_offset): Record the ancestor CU if it is different
10475         from the followed DIE's CU.
10476         (follow_die_sig_1): Likewise.
10477
10478 2019-01-15  Tom Tromey  <tom@tromey.com>
10479
10480         * remote.c (class remote_state) <buf>: Now a char_vector.
10481         <buf_size>: Remove.
10482         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10483         parameter.
10484         (remote_target::getpkt_or_notif_sane_1)
10485         (remote_target::getpkt_sane)
10486         (remote_target::getpkt_or_notif_sane): Likewise.
10487         (class remote_target) <putpkt>: New overload.
10488         (remote_target::read_frame): Change type of "buf_p".  Remove
10489         sizeof_p parameter.
10490         (packet_ok): New overload.
10491         (packet_check_result): New overload.
10492         Update all uses.
10493
10494 2019-01-14  Tom Tromey  <tom@tromey.com>
10495
10496         * remote-notif.c (handle_notification, remote_notif_ack)
10497         (remote_notif_parse): Make "buf" const.
10498         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10499         const.
10500         (remote_notif_parse, remote_notif_ack, handle_notification):
10501         Likewise.
10502         * remote.c (remote_notif_stop_parse): Make "buf" const.
10503         (remote_target::remote_parse_stop_reply): Make "buf" const.
10504         (remote_notif_stop_ack): Make "buf" const.
10505
10506 2019-01-14  Tom Tromey  <tom@tromey.com>
10507
10508         * remote.c (remote_console_output): Make parameter const.
10509
10510 2019-01-14  Tom Tromey  <tom@tromey.com>
10511
10512         * target-debug.h (target_debug_print_signals): Constify.
10513         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10514         * procfs.c (procfs_target::pass_signals): Update.
10515         * linux-nat.c (linux_nat_target::pass_signals): Update.
10516         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10517         * target-delegates.c: Rebuild.
10518         * remote.c (remote_target::program_signals): Update.
10519         (remote_target::pass_signals): Update.
10520         * target.c (target_pass_signals): Constify argument.
10521         (target_program_signals): Likewise.
10522         * target.h (struct target_ops) <pass_signals, program_signals>:
10523         Constify argument.
10524         (target_pass_signals, target_program_signals): Constify argument.
10525
10526 2019-01-14  Tom Tromey  <tom@tromey.com>
10527
10528         PR tui/28819:
10529         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10530
10531 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10532
10533         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10534         field.
10535         * rs6000-tdep.c: Include reggroups.h.
10536         (IS_V_ALIAS_PSEUDOREG): Define.
10537         (rs6000_register_name): Return names for the "vX" aliases.
10538         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10539         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10540         aliases.  Call default_register_reggroup_p for all other
10541         pseudo-registers.
10542         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10543         New functions.
10544         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10545         Handle "vX" aliases.
10546         (v_alias_pseudo_register_collect): New function.
10547         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10548         (rs6000_gdbarch_init): Initialize "vX" aliases as
10549         pseudo-registers.  Restore registration of
10550         rs6000_pseudo_register_reggroup_p with
10551         set_tdesc_pseudo_register_reggroup_p.
10552
10553 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10554
10555         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10556         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10557         set_gdbarch_num_pseudo_regs.
10558
10559 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10560
10561         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10562         Remove arg prefixname, add do_set and do_show.
10563         Add member functions set_list and show_list.
10564         * cli/cli-style.c (class cli_style_option): Update accordingly.
10565         (style_set_list): Move to file scope.
10566         (style_show_list): Likewise.
10567         (set_style): Call help_list.
10568         (show_style): Call cmd_show_list.
10569         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10570         Update to use the new macro.
10571
10572 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10573
10574         * ada-lang.c (_initialize_ada_language): Expand the help text
10575         for the "catch exception" command.
10576
10577 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10578
10579         * symtab.c (matching_obj_sections): Initialize obj,
10580         declare it closer to its usage.
10581
10582 2019-01-10  Tom Tromey  <tom@tromey.com>
10583
10584         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10585         (basic_inf_threads_range): Remove.
10586         (inf_threads_range, inf_non_exited_threads_range)
10587         (safe_inf_threads_range): Use next_adapter.
10588
10589 2019-01-10  Keith Seitz  <keiths@redhat.com>
10590
10591         PR gdb/23712
10592         PR symtab/23010
10593         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10594         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10595
10596 2019-01-10  Keith Seitz  <keiths@redhat.com>
10597
10598         PR gdb/23712
10599         PR symtab/23010
10600         * dictionary.c (pending_to_vector): Remove.
10601         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10602         Remove _1 suffix, replacing functions of the same name.  Update
10603         all callers.
10604         (dict_create_hashed, dict_create_hashed_expandable)
10605         (dict_create_linear, dict_create_linear_expandable, dict_free)
10606         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10607         Make functions static.
10608
10609 2019-01-10  Keith Seitz  <keiths@redhat.com>
10610
10611         PR gdb/23712
10612         PR symtab/23010
10613         * dictionary.h (struct dictionary): Replace declaration with
10614         multidictionary.
10615         (dict_create_hashed, dict_create_hashed_expandable)
10616         (dict_create_linear, dict_create_linear_expandable)
10617         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10618         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10619         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10620         taking multidictionary argument.
10621         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10622         * block.h (struct block) <dict>: Change to multidictionary
10623         and rename `multidict'.
10624         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10625         symmisc.c: Update all dictionary references to multidictionary.
10626
10627 2019-01-10  Keith Seitz  <keiths@redhat.com>
10628
10629         PR gdb/23712
10630         PR symtab/23010
10631         * dictionary.c: Include unordered_map.
10632         (pending_to_vector): New function.
10633         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10634         Rewrite the non-"_1" functions to take vector instead
10635         of linked list.
10636         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10637         "new" _1 versions of the same name.
10638         (multidictionary): Define.
10639         (std::hash<enum language): New definition.
10640         (collate_pending_symbols_by_language, mdict_create_hashed)
10641         (mdict_create_hashed_expandable, mdict_create_linear)
10642         (mdict_create_linear_expandable, mdict_free)
10643         (find_language_dictionary, create_new_language_dictionary)
10644         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10645         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10646         (mdict_size, mdict_empty): New functions.
10647         * dictionary.h (mdict_iterator): Define.
10648
10649 2019-01-10  Pedro Alves  <palves@redhat.com>
10650
10651         * breakpoint.c (read_uploaded_action)
10652         (create_tracepoint_from_upload): Adjust to use
10653         gdb::unique_xmalloc_ptr.
10654         * ctf.c (ctf_write_uploaded_tp):
10655         (SET_ARRAY_FIELD): Use emplace_back.
10656         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10657         * tracefile-tfile.c (tfile_write_uploaded_tp):
10658         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10659         gdb::unique_xmalloc_ptr.
10660         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10661         at_string, cond_string, cmd_strings>: Replace char pointers
10662         with gdb::unique_xmalloc_ptr.
10663
10664 2019-01-10  Pedro Alves  <palves@redhat.com>
10665
10666         * solib-target.c (library_list_start_library): Don't xstrdup name.
10667
10668 2019-01-10  Pedro Alves  <palves@redhat.com>
10669
10670         * mdebugread.c (parse_partial_symbols): Use
10671         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10672
10673 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10674
10675         * linux-fork.c (scoped_switch_fork_info)
10676         <~scoped_switch_fork_info>: Fix incorrect variable name.
10677
10678 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10679
10680         * linux-fork.c (scoped_switch_fork_info)
10681         <scoped_switch_fork_info>: Make explicit.
10682         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10683
10684 2019-01-10  Tom Tromey  <tom@tromey.com>
10685
10686         * objfiles.h (objfile::reset_psymtabs): Update.
10687         * objfiles.c (objfile::objfile): Update.
10688         * psymtab.h (psymtab_storage::obstack): Update.
10689         (psymtab_storage::m_obstack): Use gdb::optional.
10690         (class psymtab_storage): Update comment.  Remove objfile
10691         parameter.
10692         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10693
10694 2019-01-10  Tom Tromey  <tom@tromey.com>
10695
10696         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10697         <free_psymtabs>: Now private.
10698         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10699         (allocate_psymtab): Use new method.
10700
10701 2019-01-10  Tom Tromey  <tom@tromey.com>
10702
10703         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10704         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10705         * mdebugread.c (parse_partial_symbols): Use
10706         allocate_dependencies.
10707         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10708         allocate_dependencies.
10709         (process_psymtab_comp_unit_reader)
10710         (build_type_psymtab_dependencies): Likewise.
10711         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10712
10713 2019-01-10  Tom Tromey  <tom@tromey.com>
10714
10715         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10716         PSYMBOL_SET_LANGUAGE.
10717         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10718
10719 2019-01-10  Tom Tromey  <tom@tromey.com>
10720
10721         * psymtab.h (psymtab_storage::obstack): New method.
10722         <m_obstack>: Rename from obstack; now private.
10723         * psymtab.c (psymtab_storage): Update.
10724         * dwarf2read.c (create_addrmap_from_index)
10725         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10726         Update.
10727
10728 2019-01-10  Tom Tromey  <tom@tromey.com>
10729
10730         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10731         * objfiles.h (objfile::reset_psymtabs): New method.
10732
10733 2019-01-10  Tom Tromey  <tom@tromey.com>
10734
10735         * symmisc.c (print_symbol_bcache_statistics): Update.
10736         (print_objfile_statistics): Update.
10737         * symfile.c (reread_symbols): Update.
10738         * psymtab.h (class psymtab_storage): New.
10739         * psymtab.c (psymtab_storage): New constructor.
10740         (~psymtab_storage): New destructor.
10741         (require_partial_symbols): Update.
10742         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10743         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10744         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10745         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10746         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10747         (start_psymtab_common, end_psymtab_common)
10748         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10749         (allocate_psymtab): Update.
10750         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10751         Update.
10752         (dump_psymtab_addrmap, maintenance_print_psymbols)
10753         (maintenance_check_psymtabs): Update.
10754         (class objfile_psymtabs): Move to objfiles.h.
10755         * psympriv.h (discard_psymtab): Now inline.
10756         (psymtab_discarder::psymtab_discarder): Update.
10757         (psymtab_discarder::~psymtab_discarder): Update.
10758         (ALL_OBJFILE_PSYMTABS): Rewrite.
10759         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10760         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10761         Remove fields.
10762         <partial_symtabs>: New field.
10763         (class objfile_psymtabs): Move from psymtab.h.  Update.
10764         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10765         psymbol_cache.
10766         (objfile::~objfile): Don't destroy psymbol_cache.
10767         * mdebugread.c (parse_partial_symbols): Update.
10768         * dwarf2read.c (create_addrmap_from_index)
10769         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10770         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10771         (add_partial_subprogram, dwarf2_ranges_read): Update.
10772         * dwarf-index-write.c (write_address_map)
10773         (write_one_signatured_type, recursively_write_psymbols)
10774         (class debug_names, class debug_names, write_psymtabs_to_index):
10775         Update.
10776
10777 2019-01-10  Tom Tromey  <tom@tromey.com>
10778
10779         * symtab.h (SYMBOL_SET_NAMES): Update.
10780         (symbol_set_names): Update.
10781         (MSYMBOL_SET_NAMES): Update.
10782         * symtab.c (symbol_set_names): Change argument to be an
10783         objfile_per_bfd_storage.
10784         * psymtab.c (add_psymbol_to_bcache): Update.
10785         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10786
10787 2019-01-10  Tom Tromey  <tom@tromey.com>
10788
10789         * symtab.c (create_demangled_names_hash): Change argument to be an
10790         objfile_per_bfd_storage.
10791         (symbol_set_names): Update.
10792
10793 2019-01-10  Tom Tromey  <tom@tromey.com>
10794
10795         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10796         init_psymbol_list.
10797         * psymtab.c (init_psymbol_list): Do nothing if already called.
10798         * psympriv.h (init_psymbol_list): Add comment.
10799         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10800         init_psymbol_list.
10801         * dbxread.c (dbx_symfile_read): Unconditionally call
10802         init_psymbol_list.
10803
10804 2019-01-10  Tom Tromey  <tom@tromey.com>
10805
10806         * xcoffread.c (scan_xcoff_symtab): Update.
10807         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10808         "where".
10809         * mdebugread.c (parse_partial_symbols)
10810         (handle_psymbol_enumerators): Update.
10811         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10812         * dbxread.c (read_dbx_symtab): Update.
10813         * psympriv.h (psymbol_placement): New enum.
10814         (add_psymbol_to_list): Update.
10815
10816 2019-01-10  Tom Tromey  <tom@tromey.com>
10817
10818         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10819         static_psymbols parameters.
10820         (scan_xcoff_symtab): Update.
10821         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10822         static_psymbols parameters.
10823         * psympriv.h (start_psymtab_common): Update.
10824         * mdebugread.c (parse_partial_symbols): Update.
10825         * dwarf2read.c (create_partial_symtab): Update.
10826         * dbxread.c (read_dbx_symtab): Update.
10827         (start_psymtab): Remove global_psymbols and static_psymbols
10828         parameters.
10829
10830 2019-01-10  Tom Tromey  <tom@tromey.com>
10831
10832         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10833         * psymtab.c (allocate_psymtab): Add comment.
10834         * psympriv.h (allocate_psymtab): Add comment.
10835         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10836         initializations.
10837         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10838
10839 2019-01-10  Tom Tromey  <tom@tromey.com>
10840
10841         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10842         Don't declare.
10843         * mipsread.c: Include mdebugread.h.
10844         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10845         Declare.
10846         * elfread.c: Include mdebugread.h.
10847
10848 2019-01-09  Tom Tromey  <tom@tromey.com>
10849
10850         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10851         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10852         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10853         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10854         (psym_lookup_symbol, psym_find_last_source_symtab)
10855         (psym_forget_cached_source_info, psym_print_stats)
10856         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10857         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10858         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10859         (psym_find_compunit_symtab_by_address)
10860         (maintenance_print_psymbols, maintenance_info_psymtabs)
10861         (maintenance_check_psymtabs): Use ranged for.
10862         * psymtab.h (class objfile_psymtabs): New.
10863         (require_partial_symbols): Return objfile_psymtabs.
10864         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10865
10866 2019-01-09  Tom Tromey  <tom@tromey.com>
10867
10868         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10869         (find_pc_mapped_section, list_overlays_command)
10870         (map_overlay_command, unmap_overlay_command)
10871         (simple_overlay_update): Use all_objfiles.
10872         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10873         * printcmd.c (info_symbol_command): Use all_objfiles.
10874         * objfiles.h (ALL_OBJSECTIONS): Remove.
10875         * maint.c (maintenance_translate_address): Use all_objfiles.
10876         * gcore.c (gcore_create_callback): Use all_objfiles.
10877         (objfile_find_memory_regions): Likewise.
10878
10879 2019-01-09  Tom Tromey  <tom@tromey.com>
10880
10881         * symtab.c (find_line_symtab, info_sources_command)
10882         (make_source_files_completion_list): Use objfile_compunits.
10883         * source.c (select_source_symtab): Use objfile_compunits.
10884         * objfiles.h (struct objfile): Update comment.
10885         (ALL_OBJFILES): Remove.
10886         (ALL_FILETABS): Remove.
10887         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10888         objfile_compunits.
10889
10890 2019-01-09  Tom Tromey  <tom@tromey.com>
10891
10892         * symmisc.c (print_objfile_statistics, dump_objfile)
10893         (maintenance_print_symbols): Use compunit_filetabs.
10894         * source.c (forget_cached_source_info_for_objfile): Use
10895         compunit_filetabs.
10896         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10897         (ALL_FILETABS): Use compunit_filetabs.
10898         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10899         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10900
10901 2019-01-09  Tom Tromey  <tom@tromey.com>
10902
10903         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10904         (compunit_filetabs): New.
10905         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10906         compunit_filetabs.
10907         (info_sources_command, make_source_files_completion_list): Remove
10908         declaration.
10909         * symmisc.c (print_objfile_statistics, dump_objfile)
10910         (maintenance_print_symbols): Remove declaration.
10911         (maintenance_info_symtabs): Use compunit_filetabs.
10912         (maintenance_info_line_tables): Likewise.
10913         * source.c (select_source_symtab): Change local variable name.
10914         (forget_cached_source_info_for_objfile): Remove declaration.
10915         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10916         * objfiles.c (objfile_relocate1): Remove declaration.
10917         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10918         declaration.
10919         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10920         * coffread.c (coff_symtab_read): Remove declaration.
10921         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10922         compunit_filetabs.
10923
10924 2019-01-09  Tom Tromey  <tom@tromey.com>
10925
10926         * symtab.c (lookup_objfile_from_block)
10927         (find_pc_sect_compunit_symtab, search_symbols)
10928         (default_collect_symbol_completion_matches_break_on): Use
10929         objfile_compunits.
10930         * objfiles.h (ALL_COMPUNITS): Remove.
10931         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10932         * cp-support.c (add_symbol_overload_list_qualified): Use
10933         objfile_compunits.
10934         * ada-lang.c (ada_collect_symbol_completion_matches)
10935         (ada_add_global_exceptions): Use objfile_compunits.
10936
10937 2019-01-09  Tom Tromey  <tom@tromey.com>
10938
10939         * source.c (select_source_symtab)
10940         (forget_cached_source_info_for_objfile): Remove declaration.
10941         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10942         declaration.
10943         * maint.c (count_symtabs_and_blocks): Remove declaration.
10944         * cp-support.c (add_symbol_overload_list_qualified): Remove
10945         declaration.
10946         * coffread.c (coff_symtab_read): Remove declaration.
10947         * symtab.c (lookup_symbol_in_objfile_symtabs)
10948         (basic_lookup_transparent_type_1): Use objfile_compunits.
10949         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10950         (info_sources_command, search_symbols)
10951         (default_collect_symbol_completion_matches_break_on)
10952         (make_source_files_completion_list): Remove declaration.
10953         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10954         (ada_collect_symbol_completion_matches)
10955         (ada_add_global_exceptions): Remove declaration.
10956         * linespec.c (iterate_over_all_matching_symtabs): Use
10957         objfile_compunits.
10958         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10959         (class objfile_compunits): New.
10960         (ALL_COMPUNITS): Use objfile_compunits.
10961         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10962         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10963         objfile_compunits.
10964         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10965
10966 2019-01-09  Tom Tromey  <tom@tromey.com>
10967
10968         * symtab.c (search_symbols)
10969         (default_collect_symbol_completion_matches_break_on): Use
10970         objfile_msymbols.
10971         * ada-lang.c (ada_lookup_simple_minsym)
10972         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10973         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10974         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10975         objfile_msymbols.
10976         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10977         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10978         * objc-lang.c (find_methods): Use objfile_msymbols.
10979         (info_selectors_command, info_classes_command): Likewise.
10980         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10981         * objfiles.h (class objfile_msymbols): New.
10982         (ALL_OBJFILE_MSYMBOLS): Remove.
10983         (ALL_MSYMBOLS): Remove.
10984
10985 2019-01-09  Tom Tromey  <tom@tromey.com>
10986
10987         * common/next-iterator.h (next_adapter): Add Iterator template
10988         parameter.
10989         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10990         (class all_objfiles_safe): New.
10991         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10992         * objfiles.c (put_objfile_before): Update comment.
10993         (add_separate_debug_objfile): Likewise.
10994         (free_all_objfiles): Use all_objfiles_safe.
10995         (objfile_purge_solibs): Likewise.
10996
10997 2019-01-09  Tom Tromey  <tom@tromey.com>
10998
10999         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11000         (expand_symtab_containing_pc, lookup_static_symbol)
11001         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11002         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11003         all_objfiles.
11004         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11005         * breakpoint.c (create_overlay_event_breakpoint)
11006         (create_longjmp_master_breakpoint)
11007         (create_std_terminate_master_breakpoint)
11008         (create_exception_master_breakpoint): Use all_objfiles.
11009         * linux-thread-db.c (try_thread_db_load_from_pdir)
11010         (has_libpthread): Use all_objfiles.
11011         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11012         * linespec.c (iterate_over_all_matching_symtabs)
11013         (search_minsyms_for_name): Use all_objfiles.
11014         * maint.c (maintenance_info_sections): Use all_objfiles.
11015         * main.c (captured_main_1): Use all_objfiles.
11016         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11017         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11018         * guile/scm-pretty-print.c
11019         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11020         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11021         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11022         (maintenance_print_msymbols): Use all_objfiles.
11023         * source.c (select_source_symtab): Use all_objfiles.
11024         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11025         * symfile.c (remove_symbol_file_command)
11026         (expand_symtabs_matching, map_symbol_filenames): Use
11027         all_objfiles.
11028         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11029         all_objfiles.
11030         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11031         * objc-lang.c (find_methods): Use all_objfiles.
11032         * objfiles.c (have_partial_symbols, have_full_symbols)
11033         (have_minimal_symbols, qsort_cmp)
11034         (default_iterate_over_objfiles_in_search_order): Use
11035         all_objfiles.
11036         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11037         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11038         (maintenance_check_psymtabs): Use all_objfiles.
11039         (ALL_PSYMTABS): Remove.
11040         * compile/compile-object-run.c (do_module_cleanup): Use
11041         all_objfiles.
11042         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11043         * cp-support.c (add_symbol_overload_list_qualified): Use
11044         all_objfiles.
11045         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11046         Use all_objfiles.
11047         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11048         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11049         all_objfiles.
11050         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11051         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11052         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11053         Uses all_objfiles.
11054         * solib.c (solib_read_symbols): Use all_objfiles
11055
11056 2019-01-09  Tom Tromey  <tom@tromey.com>
11057
11058         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11059         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11060         all_objfiles.
11061         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11062         * symmisc.c (print_symbol_bcache_statistics)
11063         (print_objfile_statistics, maintenance_print_objfiles)
11064         (maintenance_info_symtabs, maintenance_check_symtabs)
11065         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11066         all_objfiles.
11067         * source.c (forget_cached_source_info): Use all_objfiles.
11068         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11069         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11070         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11071         * objfiles.c (update_section_map): Use all_objfiles.
11072         (shared_objfile_contains_address_p): Likewise.
11073         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11074         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11075
11076 2019-01-09  Tom Tromey  <tom@tromey.com>
11077
11078         * common/next-iterator.h: New file.
11079         * objfiles.h (class all_objfiles): New.
11080         (struct objfile_iterator): New.
11081
11082 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11083
11084         * NEWS: Move the description of the changed "frame", "select-frame",
11085          and "info frame" commands to the Changed commands section.
11086
11087 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11088
11089         * gdbtypes.c (check_stub_method_group): Remove handling of old
11090         mangling schemes.
11091         * linespec.c (find_methods): Likewise.
11092         * stabsread.c (read_member_functions): Likewise.
11093         * valops.c (search_struct_method): Likewise.
11094         (value_struct_elt_for_reference): Likewise.
11095         * NEWS: Mention this change.
11096
11097 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11098
11099         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11100         print_source_lines.
11101         * source.c (print_source_lines_base): Update line number check.
11102         (print_source_lines): New function.
11103         (source_lines_range::source_lines_range): New function.
11104         * source.h (class source_lines_range): New class.
11105         (print_source_lines): New declaration.
11106
11107 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11108
11109         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11110
11111 2019-01-08  Tom Tromey  <tom@tromey.com>
11112             Simon Marchi  <simon.marchi@ericsson.com>
11113
11114         PR gdb/24060
11115         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11116         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11117         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11118         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11119         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11120         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11121
11122 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11123
11124         * source.c (select_source_symtab): Move header comment to
11125         declaration in source.h.
11126         (forget_cached_source_info_for_objfile): Likewise.
11127         (forget_cached_source_info): Likewise.
11128         (identify_source_line): Likewise.
11129         * source.h (identify_source_line): Move declaration from symtab.h
11130         and add comment from source.c
11131         (print_source_lines): Likewise.
11132         (forget_cached_source_info_for_objfile): Likewise.
11133         (forget_cached_source_info): Likewise.
11134         (select_source_symtab): Likewise.
11135         (enum print_source_lines_flag): Move definition from symtab.h.
11136         * symtab.h (identify_source_line): Move declaration to source.h.
11137         (print_source_lines): Likewise.
11138         (forget_cached_source_info_for_objfile): Likewise.
11139         (forget_cached_source_info): Likewise.
11140         (select_source_symtab): Likewise.
11141         (enum print_source_lines_flag): Move definition to source.h.
11142         * tui/tui-hooks.c: Add 'source.h' include.
11143
11144 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11145
11146         * source.c (print_source_lines_base): Handle requests to print
11147         reverse line number sequences, and guard against empty lines
11148         string.
11149
11150 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11151
11152         * source.c (print_source_lines_base): Fix skip of '\r' if next
11153         character is '\n'.
11154
11155 2019-01-06  Tom Tromey  <tom@tromey.com>
11156
11157         * c-exp.y (struct c_parse_state) <macro_original_text,
11158         expansion_obstack>: New member.
11159         (macro_original_text, expansion_obstack): Remove globals.
11160         (scan_macro_expansion, scanning_macro_expansion)
11161         (finished_macro_expansion): Update.
11162         (scan_macro_cleanup): Remove.
11163         (yylex, c_parse): Update.
11164
11165 2019-01-06  Tom Tromey  <tom@tromey.com>
11166
11167         * c-exp.y (struct c_parse_state) <strings>: New member.
11168         (operator_stoken): Update.
11169
11170 2019-01-06  Tom Tromey  <tom@tromey.com>
11171
11172         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11173         (union type_stack_elt) <typelist_val>: Now a pointer to
11174         std::vector.
11175         (type_stack_cleanup): Don't declare.
11176         (push_typelist): Update.
11177         * parse.c (pop_typelist): Return a std::vector.
11178         (push_typelist): Take a std::vector.
11179         (follow_types): Update.  Do not free args.
11180         (type_stack_cleanup): Remove.
11181         * c-exp.y (struct c_parse_state): New.
11182         (cpstate): New global.
11183         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11184         (nonempty_typelist): Update.
11185         (func_mod): Create a new vector.
11186         (c_parse): Create a c_parse_state.
11187         (check_parameter_typelist): Do not delete params.
11188         (function_method): Update.  Do not delete type_list.
11189
11190 2019-01-06  Tom Tromey  <tom@tromey.com>
11191
11192         PR gdb/28155:
11193         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11194         check_typedef.
11195         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11196         (print_return_value): Likewise.
11197
11198 2019-01-05  Tom Tromey  <tom@tromey.com>
11199
11200         * contrib/cleanup_check.py: Remove.
11201         * contrib/gcc-with-excheck: Remove.
11202         * contrib/exsummary.py: Remove.
11203         * contrib/excheck.py: Remove.
11204
11205 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11206
11207         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11208         NULL. Initialize tpprev to NULL instead of assigning it
11209         to NULL on the next statement.
11210         * windows-nat.c (windows_delete_thread): Remove check for
11211         main_thread_id before printing thread exit notifications.
11212         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11213         Remove thread ID check against main_thread_id.
11214         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11215         windows_delete_thread.
11216         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11217
11218 2019-01-04  Tom Tromey  <tom@tromey.com>
11219
11220         * compile/compile.c (_initialize_compile): Use upper case for
11221         metasyntactic variables.
11222         * symmisc.c (_initialize_symmisc): Use upper case for
11223         metasyntactic variables.
11224         * psymtab.c (_initialize_psymtab): Use upper case for
11225         metasyntactic variables.
11226         * demangle.c (demangle_command): Use upper case for metasyntactic
11227         variables.
11228         (_initialize_demangler): Likewise.
11229         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11230         variables.
11231
11232 2019-01-03  Tom Tromey  <tom@tromey.com>
11233
11234         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11235
11236 2019-01-03  Tom Tromey  <tom@tromey.com>
11237
11238         * python/py-symtab.c (salpy_str): Update.
11239         (struct salpy_sal_object) <symtab>: Now a PyObject.
11240         (salpy_dealloc): Update.
11241         (del_objfile_sal): Use gdbpy_ref.
11242
11243 2019-01-03  Tom Tromey  <tom@tromey.com>
11244
11245         * python/py-type.c (convert_field): Use new_reference.  Return
11246         gdbpy_ref.
11247         (make_fielditem): Return gdbpy_ref.
11248         (typy_fields): Update.
11249         (typy_getitem): Update.
11250         (field_name): Return gdbpy_ref.  Use new_reference.
11251         (typy_iterator_iternext): Update.
11252
11253 2019-01-03  Tom Tromey  <tom@tromey.com>
11254
11255         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11256
11257 2019-01-03  Tom Tromey  <tom@tromey.com>
11258
11259         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11260         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11261         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11262         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11263         (pspy_set_type_printers): Likewise.
11264         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11265         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11266         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11267         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11268         (objfpy_set_type_printers): Likewise.
11269
11270 2019-01-03  Tom Tromey  <tom@tromey.com>
11271
11272         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11273         (gdbpy_print_stack): Use gdbpy_err_fetch.
11274         * python/python-internal.h (class gdbpy_err_fetch): New class.
11275         (class gdbpy_enter) <m_error_type, m_error_value,
11276         m_error_traceback>: Remove.
11277         <m_error>: New member.
11278         (gdbpy_exception_to_string): Don't declare.
11279         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11280         * python/py-value.c (convert_value_from_python): Use
11281         gdbpy_err_fetch.
11282         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11283         gdbpy_exception_to_string.
11284         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11285         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11286         gdbpy_err_fetch.
11287
11288 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11289
11290         * linux-nat.c (delete_lwp_cleanup): Delete.
11291         (struct lwp_deleter): New struct.
11292         (lwp_info_up): New typedef.
11293         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11294         lwp_info_up.
11295
11296 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11297
11298         * linux-fork.c (class scoped_switch_fork_info): New class.
11299         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11300
11301 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11302
11303         * valops.c (find_overload_match): Remove use of null_cleanup, and
11304         calls to do_cleanups.
11305
11306 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11307
11308         * compile/compile-cplus-types.c
11309         (compile_cplus_instance::decl_name): Handle changes to
11310         cp_func_name.
11311         * cp-support.c (cp_func_name): Update header comment, update
11312         return type.
11313         * cp-support.h (cp_func_name): Update return type in declaration.
11314         * valops.c (find_overload_match): Move temp_func local to top
11315         level of function and change its type.  Use temp_func to hold and
11316         delete temporary string obtained from cp_func_name.
11317
11318 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11319
11320         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11321         gdb::char_vector, remove cleanup, and update uses of `msg`.
11322
11323 2019-01-03  Jim Wilson  <jimw@sifive.com>
11324
11325         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11326
11327 2019-01-02  Tom Tromey  <tom@tromey.com>
11328
11329         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11330         (tdesc_parse_xml): Remove cleanups.
11331         * target-descriptions.h (make_cleanup_free_target_description):
11332         Don't declare.
11333         (target_desc_deleter): New struct.
11334         (target_desc_up): New typedef.
11335         * target-descriptions.c (target_desc_deleter::operator()): Rename
11336         from free_target_description.
11337         (make_cleanup_free_target_description): Remove.
11338
11339 2019-01-02  Tom Tromey  <tom@tromey.com>
11340
11341         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11342         constructor, destructor.
11343         (linespec_parser): Remove typedef.
11344         (~linespec_parser): Rename from linespec_parser_delete.
11345         (linespec_lex_to_end, linespec_complete_label)
11346         (linespec_complete): Update.
11347         (decode_line_full): Remove cleanups.
11348         (decode_line_1): Update.
11349
11350 2019-01-02  Tom Tromey  <tom@tromey.com>
11351
11352         * python/python-internal.h (inferior_to_inferior_object): Change
11353         return type.
11354         * python/py-exitedevent.c (create_exited_event_object): Update.
11355         * python/py-inferior.c (inferior_to_inferior_object): Return
11356         gdbpy_ref.
11357         (python_new_inferior, python_inferior_deleted)
11358         (thread_to_thread_object, delete_thread_object)
11359         (build_inferior_list, gdbpy_selected_inferior): Update.
11360         * python/py-infthread.c (create_thread_object): Update.  Also fail
11361         if inferior_to_inferior_object fails.
11362
11363 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11364
11365         * inferior.h (class inferior) <displaced_step_state>: New field.
11366         * infrun.h (struct displaced_step_state): Move here from
11367         infrun.c.  Initialize fields, add constructor.
11368         <inf>: Remove field.
11369         <reset>: New method.
11370         * infrun.c (struct displaced_step_inferior_state): Move to
11371         infrun.h.
11372         (displaced_step_inferior_states): Remove.
11373         (get_displaced_stepping_state): Adust.
11374         (displaced_step_in_progress_any_inferior): Adjust.
11375         (displaced_step_in_progress_thread): Adjust.
11376         (displaced_step_in_progress): Adjust.
11377         (add_displaced_stepping_state): Remove.
11378         (get_displaced_step_closure_by_addr): Adjust.
11379         (remove_displaced_stepping_state): Remove.
11380         (infrun_inferior_exit): Call displaced_step_state.reset.
11381         (use_displaced_stepping): Don't check for NULL.
11382         (displaced_step_prepare_throw): Call
11383         get_displaced_stepping_state.
11384         (displaced_step_fixup): Don't check for NULL.
11385         (prepare_for_detach): Don't check for NULL.
11386
11387 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11388
11389         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11390          in case of call that did not complete.
11391
11392 2019-01-02  Andrey Utkin  <autkin@undo.io>
11393
11394         * symfile.c (find_separate_debug_file): Fix search of debug files for
11395         remote debuggee.
11396
11397 2019-01-02  Tom Tromey  <tom@tromey.com>
11398
11399         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11400         indentation.
11401         * python/py-frame.c (frapy_older): Remove cast.
11402         (frapy_newer): Likewise.
11403         * python/py-breakpoint.c (local_setattro): Remove cast.
11404         * python/py-arch.c (archpy_name): Remove local variable.
11405         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11406
11407 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11408
11409         * unittests/basic_string_view/element_access/char/empty.cc:
11410         Fix year range in copyright header.
11411
11412 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11413
11414         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11415         Delete.
11416         <operator==>: Update with for removed field.
11417         <hash>: Likewise.
11418         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11419         <isa_features>: ...this.
11420         <abi_features>: New field.
11421         (riscv_isa_flen): Update comment.
11422         (riscv_abi_xlen): New declaration.
11423         (riscv_abi_flen): New declaration.
11424         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11425         isa_features.
11426         (riscv_abi_xlen): New function.
11427         (riscv_isa_flen): Update to get answer from isa_features.
11428         (riscv_abi_flen): New function.
11429         (riscv_has_fp_abi): Update to get answer from abi_features.
11430         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11431         xlen and flen.
11432         (riscv_call_info) <xlen, flen>: Update comment.
11433         (riscv_call_arg_struct): Remove invalid assertions
11434         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11435         is removed.
11436         (riscv_gdbarch_init): Gather isa features and abi features
11437         separately, ensure both match on the gdbarch when reusing an old
11438         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11439         a target with 64-bit float hardware.
11440
11441 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11442
11443         * source.c (search_command_helper): Stop reverse search
11444         when line 1 has been searched.
11445
11446 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11447
11448         * record-full.c (record_full_base_target::close): Rewrite
11449         record_full_core_buf_list free logic.
11450
11451 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11452
11453         * break-catch-syscall.c (print_one_catch_syscall): xfree
11454         the last text.
11455
11456 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11457
11458         * top.c (print_gdb_version): Update Copyright year in version
11459         message.
11460
11461 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11462
11463         Update copyright year range in all GDB files.
11464
11465 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11466
11467         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11468
11469 For older changes see ChangeLog-2018.
11470 \f
11471 Local Variables:
11472 mode: change-log
11473 left-margin: 8
11474 fill-column: 74
11475 version-control: never
11476 coding: utf-8
11477 End:
11478