gdb/ChangeLog

   1 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * python/python-internal.h (Py_buffer_deleter): New struct.
   4         (Py_buffer_up): New typedef.
   5
   6 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
   7
   8         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
   9         instead of releasing ownership.
  10
  11 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  12
  13         * dwarf2read.c (open_and_init_dwp_file): Call
  14         elf_numsections instead of bfd_count_sections to initialize
  15         dwp_file->num_sections.
  16
  17 2019-02-25  Tom Tromey  <tromey@adacore.com>
  18
  19         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  20
  21 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  22
  23         * gcore.in: Add '--readnever' option when invoking GDB.
  24
  25 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  26
  27         * MAINTAINERS: Update my email address.
  28
  29 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  30
  31         * build-id.c (build_id_to_debug_bfd_1): New function.
  32         (build_id_to_debug_bfd): Look for separate debug file in
  33         sysroot.
  34
  35 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * gdbarch.sh: Update the copyright year range that is placed into
  38         generated files.
  39
  40 2019-02-22  Keith Seitz  <keiths@redhat.com>
  41
  42         PR symtab/23853
  43         * linespec.c (create_sals_line_offset): Search for the default
  44         symtab's filename instead of its fullname.
  45
  46 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  47
  48         * NEWS: Update style defaults.
  49
  50 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  51
  52         * main.c (captured_main_1): Disable styling in batch mode.
  53
  54 2019-02-20  Tom Tromey  <tom@tromey.com>
  55
  56         * symtab.c (symtab_symbol_info): Fix typos.
  57
  58 2019-02-20  Tom Tromey  <tromey@adacore.com>
  59
  60         * findcmd.c (_initialize_mem_search): Use upper case for
  61         metasyntactic variables.
  62
  63 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  64
  65         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  66         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  67
  68 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  69
  70         * top.h (source_file_name): Change to std::string.
  71         * top.c (source_file_name): Likewise.
  72         (command_line_input): Adjust.
  73         * cli/cli-script.c (script_from_file): Adjust.
  74
  75 2019-02-19  Tom Tromey  <tromey@adacore.com>
  76
  77         * ravenscar-thread.c
  78         (ravenscar_thread_target::update_thread_list): Don't call
  79         ada_build_task_list.
  80         * ada-lang.h (ada_build_task_list): Don't declare.
  81         * ada-tasks.c (struct ada_tasks_inferior_data)
  82         <task_list_valid_p>: Now bool.
  83         (read_known_tasks, ada_task_list_changed)
  84         (ada_tasks_invalidate_inferior_data): Update.
  85         (read_known_tasks_array): Return bool.
  86         (read_known_tasks_list): Likewise.
  87         (read_known_tasks): Return void.
  88         (ada_build_task_list): Now static.
  89
  90 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  91
  92         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  93         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  94
  95 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  96
  97         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  98         variant for ada_tasks_pspace_data_handle and
  99         ada_tasks_inferior_data_handle.
 100         (ada_tasks_pspace_data_cleanup): New function.
 101         (ada_tasks_inferior_data_cleanup): New function.
 102
 103 2019-02-17  Tom Tromey  <tom@tromey.com>
 104
 105         * macrotab.h (macro_source_fullname): Return a std::string.
 106         * macrotab.c (macro_include, check_for_redefinition)
 107         (macro_undef, macro_lookup_definition, foreach_macro)
 108         (foreach_macro_in_scope): Update.
 109         (macro_source_fullname): Return a std::string.
 110         * macrocmd.c (show_pp_source_pos): Update.
 111
 112 2019-02-17  Tom Tromey  <tom@tromey.com>
 113
 114         * macrocmd.c (show_pp_source_pos): Style the file names.
 115
 116 2019-02-17  Tom Tromey  <tom@tromey.com>
 117
 118         PR tui/24197:
 119         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 120
 121 2019-02-17  Tom Tromey  <tom@tromey.com>
 122
 123         * ada-lang.c (user_select_syms): Use filtered printing.
 124         * utils.c (wrap_style): New global.
 125         (desired_style): Remove.
 126         (emit_style_escape): Add stream parameter.
 127         (set_output_style, reset_terminal_style, prompt_for_continue):
 128         Update.
 129         (flush_wrap_buffer): Only flush gdb_stdout.
 130         (wrap_here): Set wrap_style.
 131         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 132         treat escape sequences as a character.  Change when wrap buffer is
 133         flushed.
 134         (fputs_styled): Do not set the output style when the default is
 135         requested.
 136         * ui-style.h (struct ui_file_style) <is_default>: New method.
 137         * source.c (print_source_lines_base): Emit escape sequences in one
 138         piece.
 139
 140 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 141
 142         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 143         integers and enumeration types.
 144
 145 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 146
 147         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 148         instead of lookup_symbol_in_language
 149         (do_exact_match): New function.
 150         (ada_get_symbol_name_matcher): Return do_exact_match when
 151         doing a verbatim match.
 152
 153 2019-02-15  Tom Tromey  <tromey@adacore.com>
 154
 155         * ravenscar-thread.c (ravenscar_thread_target::resume)
 156         (ravenscar_thread_target::wait): Special case wildcard requests.
 157
 158 2019-02-15  Tom Tromey  <tromey@adacore.com>
 159
 160         * ravenscar-thread.c (base_ptid): Remove.
 161         (struct ravenscar_thread_target) <close>: New method.
 162         <m_base_ptid>: New member.
 163         <update_inferior_ptid, active_task, task_is_currently_active,
 164         runtime_initialized>: Declare methods.
 165         <ravenscar_thread_target>: Add constructor.
 166         (ravenscar_thread_target::task_is_currently_active)
 167         (ravenscar_thread_target::update_inferior_ptid)
 168         (ravenscar_runtime_initialized): Rename.  Now methods.
 169         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 170         (ravenscar_thread_target::update_thread_list): Update.
 171         (ravenscar_thread_target::active_task): Now method.
 172         (ravenscar_thread_target::store_registers)
 173         (ravenscar_thread_target::prepare_to_store)
 174         (ravenscar_thread_target::prepare_to_store)
 175         (ravenscar_thread_target::mourn_inferior): Update.
 176         (ravenscar_inferior_created): Use "new" to create target.
 177         (ravenscar_thread_target::get_ada_task_ptid): Update.
 178         (_initialize_ravenscar): Don't initialize base_ptid.
 179         (ravenscar_ops): Remove global.
 180
 181 2019-02-15  Tom Tromey  <tromey@adacore.com>
 182
 183         * target.h (push_target): Declare new overload.
 184         * target.c (push_target): New overload, taking an rvalue reference.
 185         * remote.c (remote_target::open_1): Use push_target overload.
 186         * corelow.c (core_target_open): Use push_target overload.
 187
 188 2019-02-15  Tom Tromey  <tromey@adacore.com>
 189
 190         * ravenscar-thread.c (is_ravenscar_task)
 191         (ravenscar_task_is_currently_active): Return bool.
 192         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 193         (_initialize_ravenscar): Remove "(void)".
 194         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 195         Return bool.
 196
 197 2019-02-15  Tom Tromey  <tromey@adacore.com>
 198
 199         * ravenscar-thread.c (ravenscar_runtime_initializer)
 200         (has_ravenscar_runtime, get_running_thread_id)
 201         (ravenscar_thread_target::resume): Fix indentation.
 202
 203 2019-02-15  Tom Tromey  <tromey@adacore.com>
 204
 205         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 206         from ravenscar_arch_ops.
 207         (sparc_ravenscar_ops::fetch_registers)
 208         (sparc_ravenscar_ops::store_registers): Now methods.
 209         (sparc_ravenscar_prepare_to_store): Remove.
 210         (sparc_ravenscar_ops): Redefine.
 211         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 212         methods and destructor.  Remove members.
 213         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 214         (ravenscar_thread_target::store_registers)
 215         (ravenscar_thread_target::prepare_to_store): Update.
 216         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 217         Remove.
 218         (struct ppc_ravenscar_powerpc_ops): Derive from
 219         ravenscar_arch_ops.
 220         (ppc_ravenscar_powerpc_ops::fetch_registers)
 221         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 222         (ppc_ravenscar_powerpc_ops): Redefine.
 223         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 224         (ppc_ravenscar_e500_ops::fetch_registers)
 225         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 226         (ppc_ravenscar_e500_ops): Redefine.
 227         * aarch64-ravenscar-thread.c
 228         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 229         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 230         (aarch64_ravenscar_fetch_registers)
 231         (aarch64_ravenscar_store_registers): Now methods.
 232         (aarch64_ravenscar_ops): Redefine.
 233
 234 2019-02-15  Tom Tromey  <tromey@adacore.com>
 235
 236         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 237         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 238         (ravenscar_thread_target::stopped_by_watchpoint)
 239         (ravenscar_thread_target::stopped_data_address)
 240         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 241
 242 2019-02-15  Tom Tromey  <tromey@adacore.com>
 243
 244         * ravenscar-thread.c: Fix some typos.
 245
 246 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 247             Tom Tromey  <tromey@adacore.com>
 248
 249         * ada-lang.c (ada_exception_sal): Change addr_string to a
 250         std::string.
 251         (create_ada_exception_catchpoint): Update.
 252
 253 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 254             Tom Tromey  <tromey@adacore.com>
 255
 256         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 257         (bp_location_ops): Remove.
 258         (base_breakpoint_allocate_location): Update.
 259         (free_bp_location): Update.
 260         * ada-lang.c (class ada_catchpoint_location)
 261         <ada_catchpoint_location>: Remove ops parameter.
 262         (ada_catchpoint_location_dtor): Remove.
 263         (ada_catchpoint_location_ops): Remove.
 264         (allocate_location_exception): Update.
 265         * breakpoint.h (struct bp_location_ops): Remove.
 266         (class bp_location) <bp_location>: Remove bp_location_ops
 267         parameter.
 268         <~bp_location>: Add destructor.
 269         <ops>: Remove.
 270
 271 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 272             Pedro Alves  <palves@redhat.com>
 273
 274         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 275         'PATH_MAX'.
 276
 277 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 278             Samuel Thibault  <samuel.thibault@gnu.org>
 279             Thomas Schwinge  <thomas@codesourcery.com>
 280
 281         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 282         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 283
 284 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 285
 286         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 287         (check_empty): Use "const char *".
 288
 289         * gnu-nat.c (gnu_nat_target::detach): Instead of
 290         'detach_inferior (pid)' call
 291         'detach_inferior (find_inferior_pid (pid))'.
 292
 293         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 294         'nat/fork-inferior.o'.
 295         * gnu-nat.c: #include "nat/fork-inferior.h".
 296
 297         * gnu-nat.c (gnu_nat_target::detach): Instead of
 298         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 299         * gnu-nat.h: #include "inf-child.h".
 300         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 301         'i386_gnu_nat_target::fetch_registers'.
 302         (gnu_store_registers): Rename/move to
 303         'i386_gnu_nat_target::store_registers'.
 304
 305         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 306         * gnu-nat.h (mach_thread_info): New function.
 307         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 308
 309         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 310
 311 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 312
 313         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 314
 315 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 316
 317         * windows-nat.c (windows_add_thread): Add new parameter
 318         "main_thread_p" with default value set to false.  Update
 319         function documentation as well as all callers.
 320         (windows_delete_thread): Likewise.
 321         (fake_create_process): Update call to windows_add_thread.
 322         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 323         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 324         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 325         call to windows_delete_thread.
 326
 327 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 328
 329         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 330
 331 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 332
 333         * symfile.c (find_separate_debug_file): Use canonical path of
 334         sysroot with child_path instead of gdb_sysroot if it is valid.
 335
 336 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 337
 338         * symfile.c (find_separate_debug_file): Use child_path to
 339         determine if an object file is under a sysroot.
 340
 341 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 342
 343         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 344         unittests/child-path-selftests.c.
 345         * common/pathstuff.c (child_path): New function.
 346         * common/pathstuff.h (child_path): New prototype.
 347         * unittests/child-path-selftests.c: New file.
 348
 349 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 350
 351         * symfile.c (find_separate_debug_file): Look for separate debug
 352         files in debug directories under the sysroot.
 353
 354 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 355
 356         * symtab.h (struct minimal_symbol data_p): New const method.
 357         (struct minimal_symbol text_p): Likewise.
 358         * symtab.c (output_source_filename): Use file name style
 359         to print file name.
 360         (print_symbol_info): Likewise.
 361         (print_msymbol_info): Use address style to print addresses.
 362         Use function name style to print executable text symbols.
 363         (expand_symtab_containing_pc): Use data_p.
 364         (find_pc_sect_compunit_symtab): Likewise.
 365
 366 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 367
 368         * breakpoint.c (describe_other_breakpoints): Use address style
 369         to print addresses.
 370         (say_where): Likewise.
 371
 372 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 373
 374         * ada-typeprint.c (print_func_type): Print function name
 375         style to print function name.
 376         * c-typeprint.c (c_print_type_1): Likewise.
 377
 378 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 379
 380         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 381         for execve.
 382
 383 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 384
 385         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 386         type_stack.
 387
 388 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 389
 390         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 391         TYPE_CODE_REF types.
 392
 393 2019-02-08  Jim Wilson  <jimw@sifive.com>
 394
 395         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 396         (riscv_linux_fregset): New.
 397         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 398
 399 2019-02-07  Tom Tromey  <tom@tromey.com>
 400
 401         * thread.c (thread_cancel_execution_command): Update.
 402         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 403         methods.
 404         (struct thread_fsm_ops): Remove.
 405         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 406         (thread_fsm_should_stop, thread_fsm_return_value)
 407         (thread_fsm_set_finished, thread_fsm_finished_p)
 408         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 409         Don't declare.
 410         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 411         * infrun.c (clear_proceed_status_thread)
 412         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 413         (print_stop_event): Update.
 414         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 415         Add constructor.
 416         (step_command_fsm_ops): Remove.
 417         (new_step_command_fsm): Remove.
 418         (step_1): Update.
 419         (step_command_fsm::should_stop): Rename from
 420         step_command_fsm_should_stop.
 421         (step_command_fsm::clean_up): Rename from
 422         step_command_fsm_clean_up.
 423         (step_command_fsm::do_async_reply_reason): Rename from
 424         step_command_fsm_async_reply_reason.
 425         (struct until_next_fsm): Inherit from thread_fsm.  Add
 426         constructor.
 427         (until_next_fsm_ops): Remove.
 428         (new_until_next_fsm): Remove.
 429         (until_next_fsm::should_stop): Rename from
 430         until_next_fsm_should_stop.
 431         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 432         (until_next_fsm::do_async_reply_reason): Rename from
 433         until_next_fsm_async_reply_reason.
 434         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 435         constructor.  Change type of breakpoint.
 436         (finish_command_fsm_ops): Remove.
 437         (new_finish_command_fsm): Remove.
 438         (finish_command_fsm::should_stop): Rename from
 439         finish_command_fsm_should_stop.
 440         (finish_command_fsm::clean_up): Rename from
 441         finish_command_fsm_clean_up.
 442         (finish_command_fsm::return_value): Rename from
 443         finish_command_fsm_return_value.
 444         (finish_command_fsm::do_async_reply_reason): Rename from
 445         finish_command_fsm_async_reply_reason.
 446         (finish_command): Update.
 447         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 448         Add constructor.
 449         (call_thread_fsm_ops): Remove.
 450         (call_thread_fsm::call_thread_fsm): Rename from
 451         new_call_thread_fsm.
 452         (call_thread_fsm::should_stop): Rename from
 453         call_thread_fsm_should_stop.
 454         (call_thread_fsm::should_notify_stop): Rename from
 455         call_thread_fsm_should_notify_stop.
 456         (run_inferior_call, call_function_by_hand_dummy): Update.
 457         * cli/cli-interp.c (should_print_stop_to_console): Update.
 458         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 459         Add constructor.  Change type of location_breakpoint,
 460         caller_breakpoint.
 461         (until_break_fsm_ops): Remove.
 462         (new_until_break_fsm): Remove.
 463         (until_break_fsm::should_stop): Rename from
 464         until_break_fsm_should_stop.
 465         (until_break_fsm::clean_up): Rename from
 466         until_break_fsm_clean_up.
 467         (until_break_fsm::do_async_reply_reason): Rename from
 468         until_break_fsm_async_reply_reason.
 469         (until_break_command): Update.
 470         * thread-fsm.c: Remove.
 471         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 472
 473 2019-02-07  Tom Tromey  <tom@tromey.com>
 474
 475         * yy-remap.h: Add include guard.
 476         * xtensa-tdep.h: Add include guard.
 477         * xcoffread.h: Rename include guard.
 478         * varobj-iter.h: Add include guard.
 479         * tui/tui.h: Rename include guard.
 480         * tui/tui-winsource.h: Rename include guard.
 481         * tui/tui-wingeneral.h: Rename include guard.
 482         * tui/tui-windata.h: Rename include guard.
 483         * tui/tui-win.h: Rename include guard.
 484         * tui/tui-stack.h: Rename include guard.
 485         * tui/tui-source.h: Rename include guard.
 486         * tui/tui-regs.h: Rename include guard.
 487         * tui/tui-out.h: Rename include guard.
 488         * tui/tui-layout.h: Rename include guard.
 489         * tui/tui-io.h: Rename include guard.
 490         * tui/tui-hooks.h: Rename include guard.
 491         * tui/tui-file.h: Rename include guard.
 492         * tui/tui-disasm.h: Rename include guard.
 493         * tui/tui-data.h: Rename include guard.
 494         * tui/tui-command.h: Rename include guard.
 495         * tic6x-tdep.h: Add include guard.
 496         * target/waitstatus.h: Rename include guard.
 497         * target/wait.h: Rename include guard.
 498         * target/target.h: Rename include guard.
 499         * target/resume.h: Rename include guard.
 500         * target-float.h: Rename include guard.
 501         * stabsread.h: Add include guard.
 502         * rs6000-tdep.h: Add include guard.
 503         * riscv-fbsd-tdep.h: Add include guard.
 504         * regformats/regdef.h: Rename include guard.
 505         * record.h: Rename include guard.
 506         * python/python.h: Rename include guard.
 507         * python/python-internal.h: Rename include guard.
 508         * python/py-stopevent.h: Rename include guard.
 509         * python/py-ref.h: Rename include guard.
 510         * python/py-record.h: Rename include guard.
 511         * python/py-record-full.h: Rename include guard.
 512         * python/py-record-btrace.h: Rename include guard.
 513         * python/py-instruction.h: Rename include guard.
 514         * python/py-events.h: Rename include guard.
 515         * python/py-event.h: Rename include guard.
 516         * procfs.h: Add include guard.
 517         * proc-utils.h: Add include guard.
 518         * p-lang.h: Add include guard.
 519         * or1k-tdep.h: Rename include guard.
 520         * observable.h: Rename include guard.
 521         * nto-tdep.h: Rename include guard.
 522         * nat/x86-linux.h: Rename include guard.
 523         * nat/x86-linux-dregs.h: Rename include guard.
 524         * nat/x86-gcc-cpuid.h: Add include guard.
 525         * nat/x86-dregs.h: Rename include guard.
 526         * nat/x86-cpuid.h: Rename include guard.
 527         * nat/ppc-linux.h: Rename include guard.
 528         * nat/mips-linux-watch.h: Rename include guard.
 529         * nat/linux-waitpid.h: Rename include guard.
 530         * nat/linux-ptrace.h: Rename include guard.
 531         * nat/linux-procfs.h: Rename include guard.
 532         * nat/linux-osdata.h: Rename include guard.
 533         * nat/linux-nat.h: Rename include guard.
 534         * nat/linux-namespaces.h: Rename include guard.
 535         * nat/linux-btrace.h: Rename include guard.
 536         * nat/glibc_thread_db.h: Rename include guard.
 537         * nat/gdb_thread_db.h: Rename include guard.
 538         * nat/gdb_ptrace.h: Rename include guard.
 539         * nat/fork-inferior.h: Rename include guard.
 540         * nat/amd64-linux-siginfo.h: Rename include guard.
 541         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 542         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 543         * nat/aarch64-linux.h: Rename include guard.
 544         * nat/aarch64-linux-hw-point.h: Rename include guard.
 545         * mn10300-tdep.h: Add include guard.
 546         * mips-linux-tdep.h: Add include guard.
 547         * mi/mi-parse.h: Rename include guard.
 548         * mi/mi-out.h: Rename include guard.
 549         * mi/mi-main.h: Rename include guard.
 550         * mi/mi-interp.h: Rename include guard.
 551         * mi/mi-getopt.h: Rename include guard.
 552         * mi/mi-console.h: Rename include guard.
 553         * mi/mi-common.h: Rename include guard.
 554         * mi/mi-cmds.h: Rename include guard.
 555         * mi/mi-cmd-break.h: Rename include guard.
 556         * m2-lang.h: Add include guard.
 557         * location.h: Rename include guard.
 558         * linux-record.h: Rename include guard.
 559         * linux-nat.h: Add include guard.
 560         * linux-fork.h: Add include guard.
 561         * i386-darwin-tdep.h: Rename include guard.
 562         * hppa-linux-offsets.h: Add include guard.
 563         * guile/guile.h: Rename include guard.
 564         * guile/guile-internal.h: Rename include guard.
 565         * gnu-nat.h: Rename include guard.
 566         * gdb-stabs.h: Rename include guard.
 567         * frv-tdep.h: Add include guard.
 568         * f-lang.h: Add include guard.
 569         * event-loop.h: Add include guard.
 570         * darwin-nat.h: Rename include guard.
 571         * cp-abi.h: Rename include guard.
 572         * config/sparc/nm-sol2.h: Rename include guard.
 573         * config/nm-nto.h: Rename include guard.
 574         * config/nm-linux.h: Add include guard.
 575         * config/i386/nm-i386gnu.h: Rename include guard.
 576         * config/djgpp/nl_types.h: Rename include guard.
 577         * config/djgpp/langinfo.h: Rename include guard.
 578         * compile/gcc-cp-plugin.h: Add include guard.
 579         * compile/gcc-c-plugin.h: Add include guard.
 580         * compile/compile.h: Rename include guard.
 581         * compile/compile-object-run.h: Rename include guard.
 582         * compile/compile-object-load.h: Rename include guard.
 583         * compile/compile-internal.h: Rename include guard.
 584         * compile/compile-cplus.h: Rename include guard.
 585         * compile/compile-c.h: Rename include guard.
 586         * common/xml-utils.h: Rename include guard.
 587         * common/x86-xstate.h: Rename include guard.
 588         * common/version.h: Rename include guard.
 589         * common/vec.h: Rename include guard.
 590         * common/tdesc.h: Rename include guard.
 591         * common/selftest.h: Rename include guard.
 592         * common/scoped_restore.h: Rename include guard.
 593         * common/scoped_mmap.h: Rename include guard.
 594         * common/scoped_fd.h: Rename include guard.
 595         * common/safe-iterator.h: Rename include guard.
 596         * common/run-time-clock.h: Rename include guard.
 597         * common/refcounted-object.h: Rename include guard.
 598         * common/queue.h: Rename include guard.
 599         * common/ptid.h: Rename include guard.
 600         * common/print-utils.h: Rename include guard.
 601         * common/preprocessor.h: Rename include guard.
 602         * common/pathstuff.h: Rename include guard.
 603         * common/observable.h: Rename include guard.
 604         * common/netstuff.h: Rename include guard.
 605         * common/job-control.h: Rename include guard.
 606         * common/host-defs.h: Rename include guard.
 607         * common/gdb_wait.h: Rename include guard.
 608         * common/gdb_vecs.h: Rename include guard.
 609         * common/gdb_unlinker.h: Rename include guard.
 610         * common/gdb_unique_ptr.h: Rename include guard.
 611         * common/gdb_tilde_expand.h: Rename include guard.
 612         * common/gdb_sys_time.h: Rename include guard.
 613         * common/gdb_string_view.h: Rename include guard.
 614         * common/gdb_splay_tree.h: Rename include guard.
 615         * common/gdb_setjmp.h: Rename include guard.
 616         * common/gdb_ref_ptr.h: Rename include guard.
 617         * common/gdb_optional.h: Rename include guard.
 618         * common/gdb_locale.h: Rename include guard.
 619         * common/gdb_assert.h: Rename include guard.
 620         * common/filtered-iterator.h: Rename include guard.
 621         * common/filestuff.h: Rename include guard.
 622         * common/fileio.h: Rename include guard.
 623         * common/environ.h: Rename include guard.
 624         * common/common-utils.h: Rename include guard.
 625         * common/common-types.h: Rename include guard.
 626         * common/common-regcache.h: Rename include guard.
 627         * common/common-inferior.h: Rename include guard.
 628         * common/common-gdbthread.h: Rename include guard.
 629         * common/common-exceptions.h: Rename include guard.
 630         * common/common-defs.h: Rename include guard.
 631         * common/common-debug.h: Rename include guard.
 632         * common/cleanups.h: Rename include guard.
 633         * common/buffer.h: Rename include guard.
 634         * common/btrace-common.h: Rename include guard.
 635         * common/break-common.h: Rename include guard.
 636         * cli/cli-utils.h: Rename include guard.
 637         * cli/cli-style.h: Rename include guard.
 638         * cli/cli-setshow.h: Rename include guard.
 639         * cli/cli-script.h: Rename include guard.
 640         * cli/cli-interp.h: Rename include guard.
 641         * cli/cli-decode.h: Rename include guard.
 642         * cli/cli-cmds.h: Rename include guard.
 643         * charset-list.h: Add include guard.
 644         * buildsym-legacy.h: Rename include guard.
 645         * bfin-tdep.h: Add include guard.
 646         * ax.h: Rename include guard.
 647         * arm-linux-tdep.h: Add include guard.
 648         * arm-fbsd-tdep.h: Add include guard.
 649         * arch/xtensa.h: Rename include guard.
 650         * arch/tic6x.h: Add include guard.
 651         * arch/i386.h: Add include guard.
 652         * arch/arm.h: Rename include guard.
 653         * arch/arm-linux.h: Rename include guard.
 654         * arch/arm-get-next-pcs.h: Rename include guard.
 655         * arch/amd64.h: Add include guard.
 656         * arch/aarch64-insn.h: Rename include guard.
 657         * arch-utils.h: Rename include guard.
 658         * annotate.h: Add include guard.
 659         * amd64-darwin-tdep.h: Rename include guard.
 660         * aarch64-linux-tdep.h: Add include guard.
 661         * aarch64-fbsd-tdep.h: Add include guard.
 662         * aarch32-linux-nat.h: Add include guard.
 663
 664 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 665
 666         * macrotab.c (macro_define_internal): New function that
 667         factorizes macro_define_object_internal and macro_define_function
 668         code.
 669         (macro_define_object_internal): Use macro_define_internal.
 670         (macro_define_function): Likewise.
 671
 672 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 673
 674         * macrocmd.c (extract_identifier): Return
 675         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 676         callers.
 677
 678 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 679
 680         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 681
 682 2019-02-05  Tom Tromey  <tom@tromey.com>
 683
 684         * target.c (target_stack::unpush): Move assertion earlier.
 685
 686 2019-01-30  Tom Tromey  <tom@tromey.com>
 687
 688         PR python/23615:
 689         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 690         (gdbpy_parse_and_eval): Likewise.
 691         * python/python-internal.h (gdbpy_allow_threads): New class.
 692
 693 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 694
 695         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 696         (aarch64_fbsd_fpregmap): Move earlier.
 697         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 698         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 699         instead of individual calls to trad_frame_set_reg_addr.
 700         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 701         earlier.
 702         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 703         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 704         instead of individual calls to trad_frame_set_reg_addr.
 705
 706 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 707
 708         * CONTRIBUTE: Replace contribution list with wiki link.
 709
 710 2019-01-25  Tom Tromey  <tom@tromey.com>
 711
 712         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 713
 714 2019-01-25  Tom Tromey  <tom@tromey.com>
 715
 716         * xtensa-linux-nat.c: Fix common/ includes.
 717         * xml-support.h: Fix common/ includes.
 718         * xml-support.c: Fix common/ includes.
 719         * x86-linux-nat.c: Fix common/ includes.
 720         * windows-nat.c: Fix common/ includes.
 721         * varobj.h: Fix common/ includes.
 722         * varobj.c: Fix common/ includes.
 723         * value.c: Fix common/ includes.
 724         * valops.c: Fix common/ includes.
 725         * utils.c: Fix common/ includes.
 726         * unittests/xml-utils-selftests.c: Fix common/ includes.
 727         * unittests/utils-selftests.c: Fix common/ includes.
 728         * unittests/unpack-selftests.c: Fix common/ includes.
 729         * unittests/tracepoint-selftests.c: Fix common/ includes.
 730         * unittests/style-selftests.c: Fix common/ includes.
 731         * unittests/string_view-selftests.c: Fix common/ includes.
 732         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 733         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 734         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 735         * unittests/rsp-low-selftests.c: Fix common/ includes.
 736         * unittests/parse-connection-spec-selftests.c: Fix common/
 737         includes.
 738         * unittests/optional-selftests.c: Fix common/ includes.
 739         * unittests/offset-type-selftests.c: Fix common/ includes.
 740         * unittests/observable-selftests.c: Fix common/ includes.
 741         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 742         * unittests/memrange-selftests.c: Fix common/ includes.
 743         * unittests/memory-map-selftests.c: Fix common/ includes.
 744         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 745         * unittests/function-view-selftests.c: Fix common/ includes.
 746         * unittests/environ-selftests.c: Fix common/ includes.
 747         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 748         * unittests/common-utils-selftests.c: Fix common/ includes.
 749         * unittests/cli-utils-selftests.c: Fix common/ includes.
 750         * unittests/array-view-selftests.c: Fix common/ includes.
 751         * ui-file.c: Fix common/ includes.
 752         * tui/tui-io.c: Fix common/ includes.
 753         * tracepoint.h: Fix common/ includes.
 754         * tracepoint.c: Fix common/ includes.
 755         * tracefile-tfile.c: Fix common/ includes.
 756         * top.h: Fix common/ includes.
 757         * top.c: Fix common/ includes.
 758         * thread.c: Fix common/ includes.
 759         * target/waitstatus.h: Fix common/ includes.
 760         * target/waitstatus.c: Fix common/ includes.
 761         * target.h: Fix common/ includes.
 762         * target.c: Fix common/ includes.
 763         * target-memory.c: Fix common/ includes.
 764         * target-descriptions.c: Fix common/ includes.
 765         * symtab.h: Fix common/ includes.
 766         * symfile.c: Fix common/ includes.
 767         * stap-probe.c: Fix common/ includes.
 768         * spu-linux-nat.c: Fix common/ includes.
 769         * sparc-nat.c: Fix common/ includes.
 770         * source.c: Fix common/ includes.
 771         * solib.c: Fix common/ includes.
 772         * solib-target.c: Fix common/ includes.
 773         * ser-unix.c: Fix common/ includes.
 774         * ser-tcp.c: Fix common/ includes.
 775         * ser-pipe.c: Fix common/ includes.
 776         * ser-base.c: Fix common/ includes.
 777         * selftest-arch.c: Fix common/ includes.
 778         * s12z-tdep.c: Fix common/ includes.
 779         * rust-exp.y: Fix common/ includes.
 780         * rs6000-aix-tdep.c: Fix common/ includes.
 781         * riscv-tdep.c: Fix common/ includes.
 782         * remote.c: Fix common/ includes.
 783         * remote-notif.h: Fix common/ includes.
 784         * remote-fileio.h: Fix common/ includes.
 785         * remote-fileio.c: Fix common/ includes.
 786         * regcache.h: Fix common/ includes.
 787         * regcache.c: Fix common/ includes.
 788         * record-btrace.c: Fix common/ includes.
 789         * python/python.c: Fix common/ includes.
 790         * python/py-type.c: Fix common/ includes.
 791         * python/py-inferior.c: Fix common/ includes.
 792         * progspace.h: Fix common/ includes.
 793         * producer.c: Fix common/ includes.
 794         * procfs.c: Fix common/ includes.
 795         * proc-api.c: Fix common/ includes.
 796         * printcmd.c: Fix common/ includes.
 797         * ppc-linux-nat.c: Fix common/ includes.
 798         * parser-defs.h: Fix common/ includes.
 799         * osdata.c: Fix common/ includes.
 800         * obsd-nat.c: Fix common/ includes.
 801         * nat/x86-linux.c: Fix common/ includes.
 802         * nat/x86-linux-dregs.c: Fix common/ includes.
 803         * nat/x86-dregs.h: Fix common/ includes.
 804         * nat/x86-dregs.c: Fix common/ includes.
 805         * nat/ppc-linux.c: Fix common/ includes.
 806         * nat/mips-linux-watch.h: Fix common/ includes.
 807         * nat/mips-linux-watch.c: Fix common/ includes.
 808         * nat/linux-waitpid.c: Fix common/ includes.
 809         * nat/linux-ptrace.h: Fix common/ includes.
 810         * nat/linux-ptrace.c: Fix common/ includes.
 811         * nat/linux-procfs.c: Fix common/ includes.
 812         * nat/linux-personality.c: Fix common/ includes.
 813         * nat/linux-osdata.c: Fix common/ includes.
 814         * nat/linux-namespaces.c: Fix common/ includes.
 815         * nat/linux-btrace.h: Fix common/ includes.
 816         * nat/linux-btrace.c: Fix common/ includes.
 817         * nat/fork-inferior.c: Fix common/ includes.
 818         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 819         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 820         * nat/aarch64-linux.c: Fix common/ includes.
 821         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 822         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 823         * namespace.h: Fix common/ includes.
 824         * mips-linux-tdep.c: Fix common/ includes.
 825         * minsyms.c: Fix common/ includes.
 826         * mi/mi-parse.h: Fix common/ includes.
 827         * mi/mi-main.c: Fix common/ includes.
 828         * mi/mi-cmd-env.c: Fix common/ includes.
 829         * memrange.h: Fix common/ includes.
 830         * memattr.c: Fix common/ includes.
 831         * maint.h: Fix common/ includes.
 832         * maint.c: Fix common/ includes.
 833         * main.c: Fix common/ includes.
 834         * machoread.c: Fix common/ includes.
 835         * location.c: Fix common/ includes.
 836         * linux-thread-db.c: Fix common/ includes.
 837         * linux-nat.c: Fix common/ includes.
 838         * linux-fork.c: Fix common/ includes.
 839         * inline-frame.c: Fix common/ includes.
 840         * infrun.c: Fix common/ includes.
 841         * inflow.c: Fix common/ includes.
 842         * inferior.h: Fix common/ includes.
 843         * inferior.c: Fix common/ includes.
 844         * infcmd.c: Fix common/ includes.
 845         * inf-ptrace.c: Fix common/ includes.
 846         * inf-child.c: Fix common/ includes.
 847         * ia64-linux-nat.c: Fix common/ includes.
 848         * i387-tdep.c: Fix common/ includes.
 849         * i386-tdep.c: Fix common/ includes.
 850         * i386-linux-tdep.c: Fix common/ includes.
 851         * i386-linux-nat.c: Fix common/ includes.
 852         * i386-go32-tdep.c: Fix common/ includes.
 853         * i386-fbsd-tdep.c: Fix common/ includes.
 854         * i386-fbsd-nat.c: Fix common/ includes.
 855         * guile/scm-type.c: Fix common/ includes.
 856         * guile/guile.c: Fix common/ includes.
 857         * go32-nat.c: Fix common/ includes.
 858         * gnu-nat.c: Fix common/ includes.
 859         * gdbthread.h: Fix common/ includes.
 860         * gdbarch-selftests.c: Fix common/ includes.
 861         * gdb_usleep.c: Fix common/ includes.
 862         * gdb_select.h: Fix common/ includes.
 863         * gdb_bfd.c: Fix common/ includes.
 864         * gcore.c: Fix common/ includes.
 865         * fork-child.c: Fix common/ includes.
 866         * findvar.c: Fix common/ includes.
 867         * fbsd-nat.c: Fix common/ includes.
 868         * event-top.c: Fix common/ includes.
 869         * event-loop.c: Fix common/ includes.
 870         * dwarf2read.c: Fix common/ includes.
 871         * dwarf2loc.c: Fix common/ includes.
 872         * dwarf2-frame.c: Fix common/ includes.
 873         * dwarf-index-cache.c: Fix common/ includes.
 874         * dtrace-probe.c: Fix common/ includes.
 875         * disasm-selftests.c: Fix common/ includes.
 876         * defs.h: Fix common/ includes.
 877         * csky-tdep.c: Fix common/ includes.
 878         * cp-valprint.c: Fix common/ includes.
 879         * cp-support.h: Fix common/ includes.
 880         * cp-support.c: Fix common/ includes.
 881         * corelow.c: Fix common/ includes.
 882         * completer.h: Fix common/ includes.
 883         * completer.c: Fix common/ includes.
 884         * compile/compile.c: Fix common/ includes.
 885         * compile/compile-loc2c.c: Fix common/ includes.
 886         * compile/compile-cplus-types.c: Fix common/ includes.
 887         * compile/compile-cplus-symbols.c: Fix common/ includes.
 888         * command.h: Fix common/ includes.
 889         * cli/cli-dump.c: Fix common/ includes.
 890         * cli/cli-cmds.c: Fix common/ includes.
 891         * charset.c: Fix common/ includes.
 892         * build-id.c: Fix common/ includes.
 893         * btrace.h: Fix common/ includes.
 894         * btrace.c: Fix common/ includes.
 895         * breakpoint.h: Fix common/ includes.
 896         * breakpoint.c: Fix common/ includes.
 897         * ax.h:
 898         (enum agent_op): Fix common/ includes.
 899         * ax-general.c (struct aop_map): Fix common/ includes.
 900         * ax-gdb.c: Fix common/ includes.
 901         * auxv.c: Fix common/ includes.
 902         * auto-load.c: Fix common/ includes.
 903         * arm-tdep.c: Fix common/ includes.
 904         * arch/riscv.c: Fix common/ includes.
 905         * arch/ppc-linux-common.c: Fix common/ includes.
 906         * arch/i386.c: Fix common/ includes.
 907         * arch/arm.c: Fix common/ includes.
 908         * arch/arm-linux.c: Fix common/ includes.
 909         * arch/arm-get-next-pcs.c: Fix common/ includes.
 910         * arch/amd64.c: Fix common/ includes.
 911         * arch/aarch64.c: Fix common/ includes.
 912         * arch/aarch64-insn.c: Fix common/ includes.
 913         * arch-utils.c: Fix common/ includes.
 914         * amd64-windows-tdep.c: Fix common/ includes.
 915         * amd64-tdep.c: Fix common/ includes.
 916         * amd64-sol2-tdep.c: Fix common/ includes.
 917         * amd64-obsd-tdep.c: Fix common/ includes.
 918         * amd64-nbsd-tdep.c: Fix common/ includes.
 919         * amd64-linux-tdep.c: Fix common/ includes.
 920         * amd64-linux-nat.c: Fix common/ includes.
 921         * amd64-fbsd-tdep.c: Fix common/ includes.
 922         * amd64-fbsd-nat.c: Fix common/ includes.
 923         * amd64-dicos-tdep.c: Fix common/ includes.
 924         * amd64-darwin-tdep.c: Fix common/ includes.
 925         * agent.c: Fix common/ includes.
 926         * ada-lang.h: Fix common/ includes.
 927         * ada-lang.c: Fix common/ includes.
 928         * aarch64-tdep.c: Fix common/ includes.
 929
 930 2019-01-25  Tom Tromey  <tom@tromey.com>
 931
 932         * common/create-version.sh: Use common/version.h.
 933
 934 2019-01-24  Pedro Alves  <palves@redhat.com>
 935
 936         * infrun.c (signal_stop, signal_print, signal_program)
 937         (signal_catch, signal_pass): Now arrays instead of pointers.
 938         (update_signals_program_target, do_target_resume)
 939         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 940         * linux-nat.c (linux_nat_target::pass_signals)
 941         (linux_nat_target::create_inferior, linux_nat_target::attach):
 942         Adjust.
 943         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 944         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 945         * procfs.c (procfs_target::pass_signals): Adjust.
 946         * record-full.c (record_full_target::resume): Adjust.
 947         * remote.c (remote_target::pass_signals)
 948         (remote_target::program_signals): Adjust.
 949         * target-debug.h (target_debug_print_signals): Now takes a
 950         gdb::array_view as parameter.  Adjust.
 951         * target.h (target_ops) <pass_signals, program_signals>: Replace
 952         pointer and length parameters with gdb::array_view.
 953         (target_pass_signals, target_program_signals): Likewise.
 954         * target-delegates.c: Regenerate.
 955
 956 2019-01-24  Pedro Alves  <palves@redhat.com>
 957
 958         * common/forward-scope-exit.h
 959         (forward_scope_exit::forward_scope_exit): Pass arguments to
 960         m_bind_function directly, instead of creating a std::bind and
 961         copying that.
 962
 963 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 964
 965         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 966         for static members.
 967         (pass_in_v_vfp_candidate): Likewise.
 968
 969 2019-01-23  Tom Tromey  <tom@tromey.com>
 970             Pedro Alves  <palves@redhat.com>
 971
 972         * regcache.c (class regcache_invalidator): Remove.
 973         (regcache::raw_write): Use make_scope_exit.
 974
 975 2019-01-23  Tom Tromey  <tom@tromey.com>
 976
 977         * ui-out.h (class ui_out_emit_type): Update comment.
 978
 979 2019-01-23  Tom Tromey  <tom@tromey.com>
 980
 981         * infrun.c (fetch_inferior_event): Update comment.
 982
 983 2019-01-23  Tom Tromey  <tom@tromey.com>
 984             Pedro Alves  <palves@redhat.com>
 985
 986         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 987         parameter.
 988         (fetch_inferior_event): Use SCOPE_EXIT.
 989
 990
 991 2019-01-23  Tom Tromey  <tom@tromey.com>
 992             Pedro Alves  <palves@redhat.com>
 993
 994         * infrun.c (disable_thread_events): Delete.
 995         (stop_all_threads): Use SCOPE_EXIT.
 996
 997 2019-01-23  Tom Tromey  <tom@tromey.com>
 998             Pedro Alves  <palves@redhat.com>
 999
1000         * symfile.c: Include forward-scope-exit.h.
1001         (clear_symtab_users_cleanup): Replace forward declaration with
1002         a FORWARD_SCOPE_EXIT.
1003         (syms_from_objfile_1): Use the forward_scope_exit and
1004         gdb::optional instead of cleanup_function.
1005         (reread_symbols): Use the forward_scope_exit instead of
1006         cleanup_function.
1007         (clear_symtab_users_cleanup): Remove function.
1008
1009 2019-01-23  Tom Tromey  <tom@tromey.com>
1010             Pedro Alves  <palves@redhat.com>
1011
1012         * linux-nat.c: Include scope-exit.h.
1013         (cleanup_target_stop): Remove.
1014         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1015         SCOPE_EXIT.
1016
1017 2019-01-23  Tom Tromey  <tom@tromey.com>
1018             Pedro Alves  <palves@redhat.com>
1019
1020         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1021         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1022
1023 2019-01-23  Tom Tromey  <tom@tromey.com>
1024             Andrew Burgess  <andrew.burgess@embecosm.com>
1025             Pedro Alves  <palves@redhat.com>
1026
1027         * infrun.c (fetch_inferior_event): Use scope_exit.
1028         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1029         * top.c (execute_command): Use scope_exit.
1030         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1031         * utils.c (do_bpstat_clear_actions_cleanup)
1032         (make_bpstat_clear_actions_cleanup): Remove.
1033
1034 2019-01-23  Tom Tromey  <tom@tromey.com>
1035             Pedro Alves  <palves@redhat.com>
1036
1037         * infrun.c: Include "common/scope-exit.h"
1038         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1039         (wait_for_inferior): Use SCOPE_EXIT.
1040         (fetch_inferior_event): Use scope_exit.
1041
1042 2019-01-23  Tom Tromey  <tom@tromey.com>
1043             Pedro Alves  <palves@redhat.com>
1044
1045         * breakpoint.c (create_breakpoint): Remove cleanup.
1046
1047 2019-01-23  Tom Tromey  <tom@tromey.com>
1048             Andrew Burgess  <andrew.burgess@embecosm.com>
1049             Pedro Alves  <palves@redhat.com>
1050
1051 2019-01-23  Pedro Alves  <palves@redhat.com>
1052
1053         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1054
1055 2019-01-23  Pedro Alves  <palves@redhat.com>
1056             Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * gdbthread.h: Include "common/forward-scope-exit.h".
1059         (scoped_finish_thread_state): Redefine custom class in terms of
1060         forward_scope_exit.
1061
1062 2019-01-23  Pedro Alves  <palves@redhat.com>
1063             Andrew Burgess  <andrew.burgess@embecosm.com>
1064
1065         * common/forward-scope-exit.h: New file.
1066
1067 2019-01-23  Pedro Alves  <palves@redhat.com>
1068             Andrew Burgess  <andrew.burgess@embecosm.com>
1069             Tom Tromey  <tom@tromey.com>
1070
1071         * common/scope-exit.h: New file.
1072
1073 2019-01-23  Pedro Alves  <palves@redhat.com>
1074
1075         * common/preprocessor.h (ESC): Rename to ...
1076         (ESC_PARENS): ... this.
1077         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1078         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1079
1080 2019-01-23  Tom Tromey  <tom@tromey.com>
1081
1082         * language.h (class scoped_switch_to_sym_language_if_auto):
1083         Initialize m_lang in both cases.
1084
1085 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1086
1087         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1088         with XCNEW.
1089
1090 2019-01-22  Tom Tromey  <tom@tromey.com>
1091
1092         * corelow.c: Do not include sys/file.h.
1093
1094 2019-01-22  Tom Tromey  <tom@tromey.com>
1095
1096         * tui/tui-wingeneral.h: Include gdb_curses.h.
1097
1098 2019-01-22  Tom Tromey  <tom@tromey.com>
1099
1100         * source-cache.h (class source_cache) <get_source_lines,
1101         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1102
1103 2019-01-22  Tom Tromey  <tom@tromey.com>
1104
1105         * remote-fileio.h (struct remote_target): Declare.
1106
1107 2019-01-22  Tom Tromey  <tom@tromey.com>
1108
1109         * python/py-arch.c: Do not include py-ref.h.
1110         * python/py-bpevent.c: Do not include py-ref.h.
1111         * python/py-cmd.c: Do not include py-ref.h.
1112         * python/py-continueevent.c: Do not include py-ref.h.
1113         * python/py-event.h: Do not include py-ref.h.
1114         * python/py-evtregistry.c: Do not include py-ref.h.
1115         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1116         * python/py-frame.c: Do not include py-ref.h.
1117         * python/py-framefilter.c: Do not include py-ref.h.
1118         * python/py-function.c: Do not include py-ref.h.
1119         * python/py-infevents.c: Do not include py-ref.h.
1120         * python/py-linetable.c: Do not include py-ref.h.
1121         * python/py-objfile.c: Do not include py-ref.h.
1122         * python/py-param.c: Do not include py-ref.h.
1123         * python/py-prettyprint.c: Do not include py-ref.h.
1124         * python/py-progspace.c: Do not include py-ref.h.
1125         * python/py-symbol.c: Do not include py-ref.h.
1126         * python/py-symtab.c: Do not include py-ref.h.
1127         * python/py-type.c: Do not include py-ref.h.
1128         * python/py-unwind.c: Do not include py-ref.h.
1129         * python/py-utils.c: Do not include py-ref.h.
1130         * python/py-value.c: Do not include py-ref.h.
1131         * python/py-varobj.c: Do not include py-ref.h.
1132         * python/py-xmethods.c: Do not include py-ref.h.
1133         * python/python.c: Do not include py-ref.h.
1134         * varobj.c: Do not include py-ref.h.
1135
1136 2019-01-22  Tom Tromey  <tom@tromey.com>
1137
1138         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1139         keyword for bcache.
1140
1141 2019-01-22  Tom Tromey  <tom@tromey.com>
1142
1143         * compile/compile-cplus-types.c: Remove a comment by #include.
1144
1145 2019-01-22  Tom Tromey  <tom@tromey.com>
1146
1147         * compile/gcc-c-plugin.h: Include compile-internal.h.
1148
1149 2019-01-22  Tom Tromey  <tom@tromey.com>
1150
1151         * stabsread.c (EXTERN): Do not define.
1152         (symnum, next_symbol_text_func, processing_gcc_compilation)
1153         (within_function, global_sym_chain, global_stabs)
1154         (previous_stab_code, this_object_header_files)
1155         (n_this_object_header_files)
1156         (n_allocated_this_object_header_files): Define.
1157         * stabsread.h (EXTERN): Never define.  Use "extern".
1158
1159 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1160
1161         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1162         history_value.
1163
1164 2019-01-21  Tom Tromey  <tom@tromey.com>
1165
1166         * ui-out.c: Fix includes.
1167         * tui/tui-source.c: Fix includes.
1168         * target.c: Fix includes.
1169         * remote.c: Fix includes.
1170         * regcache.c: Fix includes.
1171         * python/py-block.c: Fix includes.
1172         * printcmd.c: Fix includes.
1173         * or1k-tdep.c: Fix includes.
1174         * mi/mi-main.c: Fix includes.
1175         * m32r-tdep.c: Fix includes.
1176         * csky-tdep.c: Fix includes.
1177         * compile/compile-cplus-types.c: Fix includes.
1178         * cli/cli-interp.c: Fix includes.
1179
1180 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1181
1182         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1183         for padding.
1184
1185 2019-01-16  Tom Tromey  <tom@tromey.com>
1186
1187         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1188         earlier.
1189         (struct objfile) <msymbols_range>: Move from top level.
1190         <msymbols>: New method.
1191         (class objfile_msymbols): Remove.
1192         * symtab.c (default_collect_symbol_completion_matches_break_on):
1193         Update.
1194         * symmisc.c (dump_msymbols): Update.
1195         * stabsread.c (scan_file_globals): Update.
1196         * objc-lang.c (info_selectors_command, info_classes_command)
1197         (find_methods): Update.
1198         * minsyms.c (find_solib_trampoline_target): Update.
1199         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1200         * coffread.c (coff_symfile_read): Update.
1201         * ada-lang.c (ada_lookup_simple_minsym)
1202         (ada_collect_symbol_completion_matches): Update.
1203
1204 2019-01-16  Tom Tromey  <tom@tromey.com>
1205
1206         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1207         type.  Remove no-argument constructor.
1208         <iterator::operator++>: Simplify.
1209         <begin>: Update.
1210         <end>: Use minimal_symbol_count.
1211
1212 2019-01-16  Tom Tromey  <tom@tromey.com>
1213
1214         * objfiles.h (struct objfile) <psymtabs>: New method.
1215         (class objfile_psymtabs): Remove.
1216         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1217         typedef.
1218         <range>: New method.
1219         (require_partial_symbols): Change return type.
1220         * psymtab.c (require_partial_symbols)
1221         (psym_expand_symtabs_matching): Update.
1222         * mdebugread.c (parse_partial_symbols): Update.
1223         * dbxread.c (dbx_end_psymtab): Update.
1224
1225 2019-01-15  Tom Tromey  <tom@tromey.com>
1226
1227         * symtab.c (lookup_objfile_from_block)
1228         (lookup_symbol_in_objfile_symtabs)
1229         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1230         (find_line_symtab, info_sources_command)
1231         (default_collect_symbol_completion_matches_break_on)
1232         (make_source_files_completion_list): Update.
1233         * symmisc.c (print_objfile_statistics, dump_objfile)
1234         (maintenance_print_symbols, maintenance_info_symtabs)
1235         (maintenance_check_symtabs, maintenance_info_line_tables):
1236         Update.
1237         * source.c (select_source_symtab)
1238         (forget_cached_source_info_for_objfile): Update.
1239         * objfiles.h (class objfile_compunits): Remove.
1240         (struct objfile) <compunits_range>: New typedef.
1241         (compunits): New method.
1242         * objfiles.c (objfile_relocate1): Update.
1243         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1244         * maint.c (count_symtabs_and_blocks): Update.
1245         * linespec.c (iterate_over_all_matching_symtabs): Update.
1246         * cp-support.c (add_symbol_overload_list_qualified): Update.
1247         * coffread.c (coff_symtab_read): Update.
1248         * ada-lang.c (add_nonlocal_symbols)
1249         (ada_collect_symbol_completion_matches)
1250         (ada_add_global_exceptions): Update.
1251
1252 2019-01-15  Tom Tromey  <tom@tromey.com>
1253
1254         * progspace.h (program_space) <objfiles_safe_range>: New
1255         typedef.
1256         <objfiles_safe>: New method.
1257         * objfiles.h (class all_objfiles_safe): Remove.
1258         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1259         * jit.c (jit_inferior_exit_hook): Update.
1260
1261 2019-01-17  Tom Tromey  <tom@tromey.com>
1262
1263         * progspace.h (program_space) <objfiles_range>: New typedef.
1264         <objfiles>: New method.
1265         <objfiles_head>: Rename from objfiles.
1266         (object_files): Update.
1267         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1268         * guile/scm-pretty-print.c
1269         (ppscm_find_pretty_printer_from_objfiles): Update.
1270         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1271         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1272         Update.
1273         * python/py-progspace.c (pspy_get_objfiles): Update.
1274         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1275         Update.
1276         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1277         (objfpy_lookup_objfile_by_build_id): Update.
1278         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1279         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1280         Update.
1281         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1282         (expand_symtab_containing_pc, lookup_objfile_from_block)
1283         (lookup_static_symbol, basic_lookup_transparent_type)
1284         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1285         (find_line_symtab, info_sources_command)
1286         (default_collect_symbol_completion_matches_break_on)
1287         (make_source_files_completion_list, find_main_name): Update.
1288         * symmisc.c (print_symbol_bcache_statistics)
1289         (print_objfile_statistics, maintenance_print_symbols)
1290         (maintenance_print_msymbols, maintenance_print_objfiles)
1291         (maintenance_info_symtabs, maintenance_check_symtabs)
1292         (maintenance_expand_symtabs, maintenance_info_line_tables):
1293         Update.
1294         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1295         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1296         (map_overlay_command, unmap_overlay_command)
1297         (simple_overlay_update, expand_symtabs_matching)
1298         (map_symbol_filenames): Update.
1299         * symfile-debug.c (set_debug_symfile): Update.
1300         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1301         Update.
1302         * source.c (select_source_symtab, forget_cached_source_info):
1303         Update.
1304         * solib.c (solib_read_symbols): Update.
1305         * solib-spu.c (append_ocl_sos): Update.
1306         * psymtab.c (maintenance_print_psymbols)
1307         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1308         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1309         * printcmd.c (info_symbol_command): Update.
1310         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1311         Update.
1312         * objfiles.h (class all_objfiles): Remove.
1313         * objfiles.c (have_partial_symbols, have_full_symbols)
1314         (have_minimal_symbols, qsort_cmp, update_section_map)
1315         (shared_objfile_contains_address_p)
1316         (default_iterate_over_objfiles_in_search_order): Update.
1317         * objc-lang.c (info_selectors_command, info_classes_command)
1318         (find_methods): Update.
1319         * minsyms.c (find_solib_trampoline_target): Update.
1320         * maint.c (maintenance_info_sections)
1321         (maintenance_translate_address, count_symtabs_and_blocks):
1322         Update.
1323         * main.c (captured_main_1): Update.
1324         * linux-thread-db.c (try_thread_db_load_from_pdir)
1325         (has_libpthread): Update.
1326         * linespec.c (iterate_over_all_matching_symtabs)
1327         (search_minsyms_for_name): Update.
1328         * jit.c (jit_find_objf_with_entry_addr): Update.
1329         * hppa-tdep.c (find_unwind_entry)
1330         (hppa_lookup_stub_minimal_symbol): Update.
1331         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1332         Update.
1333         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1334         (elf_gnu_ifunc_resolve_by_got): Update.
1335         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1336         * dwarf-index-write.c (save_gdb_index_command): Update.
1337         * cp-support.c (add_symbol_overload_list_qualified): Update.
1338         * breakpoint.c (create_overlay_event_breakpoint)
1339         (create_longjmp_master_breakpoint)
1340         (create_std_terminate_master_breakpoint)
1341         (create_exception_master_breakpoint): Update.
1342         * blockframe.c (find_pc_partial_function): Update.
1343         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1344         (ada_collect_symbol_completion_matches)
1345         (ada_add_global_exceptions): Update.
1346
1347 2019-01-17  Tom Tromey  <tom@tromey.com>
1348
1349         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1350         declare VEC.
1351         (solib_target_parse_libraries): Change return type.
1352         (library_list_start_segment, library_list_start_section)
1353         (library_list_end_library, library_list_start_library); Update.
1354         (solib_target_free_library_list): Remove.
1355         (solib_target_parse_libraries): Remove cleanup.  Change return
1356         type.
1357         (solib_target_current_sos): Update.
1358
1359 2019-01-17  Tom Tromey  <tromey@bapiya>
1360
1361         * valprint.c: Replace "the the" with "the".
1362         * symtab.c: Replace "the the" with "the".
1363         * solib.c: Replace "the the" with "the".
1364         * solib-dsbt.c: Replace "the the" with "the".
1365         * linespec.c: Replace "the the" with "the".
1366         * dwarf2loc.h: Replace "the the" with "the".
1367         * amd64-windows-tdep.c: Replace "the the" with "the".
1368         * aarch64-tdep.c: Replace "the the" with "the".
1369
1370 2019-01-16  Keith Seitz  <keiths@redhat.com>
1371
1372         PR gdb/23773
1373         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1374         <builder>: Rename to ..
1375         <m_builder>: ... this and make private.
1376         (dwarf2_cu::get_builder): New method.  Change all users of
1377         `builder' to use this method.
1378         (dwarf2_start_symtab): Move to ...
1379         (dwarf2_cu::start_symtab): ... here.  Update all callers
1380         (setup_type_unit_groups): Move to ...
1381         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1382         callers.
1383         (dwarf2_cu::reset_builder): New method.
1384         (process_full_compunit, process_full_type_unit): Use
1385         dwarf2_cu::reset_builder.
1386         (follow_die_offset): Record the ancestor CU if it is different
1387         from the followed DIE's CU.
1388         (follow_die_sig_1): Likewise.
1389
1390 2019-01-15  Tom Tromey  <tom@tromey.com>
1391
1392         * remote.c (class remote_state) <buf>: Now a char_vector.
1393         <buf_size>: Remove.
1394         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1395         parameter.
1396         (remote_target::getpkt_or_notif_sane_1)
1397         (remote_target::getpkt_sane)
1398         (remote_target::getpkt_or_notif_sane): Likewise.
1399         (class remote_target) <putpkt>: New overload.
1400         (remote_target::read_frame): Change type of "buf_p".  Remove
1401         sizeof_p parameter.
1402         (packet_ok): New overload.
1403         (packet_check_result): New overload.
1404         Update all uses.
1405
1406 2019-01-14  Tom Tromey  <tom@tromey.com>
1407
1408         * remote-notif.c (handle_notification, remote_notif_ack)
1409         (remote_notif_parse): Make "buf" const.
1410         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1411         const.
1412         (remote_notif_parse, remote_notif_ack, handle_notification):
1413         Likewise.
1414         * remote.c (remote_notif_stop_parse): Make "buf" const.
1415         (remote_target::remote_parse_stop_reply): Make "buf" const.
1416         (remote_notif_stop_ack): Make "buf" const.
1417
1418 2019-01-14  Tom Tromey  <tom@tromey.com>
1419
1420         * remote.c (remote_console_output): Make parameter const.
1421
1422 2019-01-14  Tom Tromey  <tom@tromey.com>
1423
1424         * target-debug.h (target_debug_print_signals): Constify.
1425         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1426         * procfs.c (procfs_target::pass_signals): Update.
1427         * linux-nat.c (linux_nat_target::pass_signals): Update.
1428         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1429         * target-delegates.c: Rebuild.
1430         * remote.c (remote_target::program_signals): Update.
1431         (remote_target::pass_signals): Update.
1432         * target.c (target_pass_signals): Constify argument.
1433         (target_program_signals): Likewise.
1434         * target.h (struct target_ops) <pass_signals, program_signals>:
1435         Constify argument.
1436         (target_pass_signals, target_program_signals): Constify argument.
1437
1438 2019-01-14  Tom Tromey  <tom@tromey.com>
1439
1440         PR tui/28819:
1441         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1442
1443 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1444
1445         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1446         field.
1447         * rs6000-tdep.c: Include reggroups.h.
1448         (IS_V_ALIAS_PSEUDOREG): Define.
1449         (rs6000_register_name): Return names for the "vX" aliases.
1450         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1451         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1452         aliases.  Call default_register_reggroup_p for all other
1453         pseudo-registers.
1454         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1455         New functions.
1456         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1457         Handle "vX" aliases.
1458         (v_alias_pseudo_register_collect): New function.
1459         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1460         (rs6000_gdbarch_init): Initialize "vX" aliases as
1461         pseudo-registers.  Restore registration of
1462         rs6000_pseudo_register_reggroup_p with
1463         set_tdesc_pseudo_register_reggroup_p.
1464
1465 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1466
1467         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1468         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1469         set_gdbarch_num_pseudo_regs.
1470
1471 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1472
1473         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1474         Remove arg prefixname, add do_set and do_show.
1475         Add member functions set_list and show_list.
1476         * cli/cli-style.c (class cli_style_option): Update accordingly.
1477         (style_set_list): Move to file scope.
1478         (style_show_list): Likewise.
1479         (set_style): Call help_list.
1480         (show_style): Call cmd_show_list.
1481         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1482         Update to use the new macro.
1483
1484 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1485
1486         * ada-lang.c (_initialize_ada_language): Expand the help text
1487         for the "catch exception" command.
1488
1489 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1490
1491         * symtab.c (matching_obj_sections): Initialize obj,
1492         declare it closer to its usage.
1493
1494 2019-01-10  Tom Tromey  <tom@tromey.com>
1495
1496         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1497         (basic_inf_threads_range): Remove.
1498         (inf_threads_range, inf_non_exited_threads_range)
1499         (safe_inf_threads_range): Use next_adapter.
1500
1501 2019-01-10  Keith Seitz  <keiths@redhat.com>
1502
1503         PR gdb/23712
1504         PR symtab/23010
1505         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1506         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1507
1508 2019-01-10  Keith Seitz  <keiths@redhat.com>
1509
1510         PR gdb/23712
1511         PR symtab/23010
1512         * dictionary.c (pending_to_vector): Remove.
1513         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1514         Remove _1 suffix, replacing functions of the same name.  Update
1515         all callers.
1516         (dict_create_hashed, dict_create_hashed_expandable)
1517         (dict_create_linear, dict_create_linear_expandable, dict_free)
1518         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1519         Make functions static.
1520
1521 2019-01-10  Keith Seitz  <keiths@redhat.com>
1522
1523         PR gdb/23712
1524         PR symtab/23010
1525         * dictionary.h (struct dictionary): Replace declaration with
1526         multidictionary.
1527         (dict_create_hashed, dict_create_hashed_expandable)
1528         (dict_create_linear, dict_create_linear_expandable)
1529         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1530         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1531         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1532         taking multidictionary argument.
1533         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1534         * block.h (struct block) <dict>: Change to multidictionary
1535         and rename `multidict'.
1536         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1537         symmisc.c: Update all dictionary references to multidictionary.
1538
1539 2019-01-10  Keith Seitz  <keiths@redhat.com>
1540
1541         PR gdb/23712
1542         PR symtab/23010
1543         * dictionary.c: Include unordered_map.
1544         (pending_to_vector): New function.
1545         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1546         Rewrite the non-"_1" functions to take vector instead
1547         of linked list.
1548         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1549         "new" _1 versions of the same name.
1550         (multidictionary): Define.
1551         (std::hash<enum language): New definition.
1552         (collate_pending_symbols_by_language, mdict_create_hashed)
1553         (mdict_create_hashed_expandable, mdict_create_linear)
1554         (mdict_create_linear_expandable, mdict_free)
1555         (find_language_dictionary, create_new_language_dictionary)
1556         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1557         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1558         (mdict_size, mdict_empty): New functions.
1559         * dictionary.h (mdict_iterator): Define.
1560
1561 2019-01-10  Pedro Alves  <palves@redhat.com>
1562
1563         * breakpoint.c (read_uploaded_action)
1564         (create_tracepoint_from_upload): Adjust to use
1565         gdb::unique_xmalloc_ptr.
1566         * ctf.c (ctf_write_uploaded_tp):
1567         (SET_ARRAY_FIELD): Use emplace_back.
1568         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1569         * tracefile-tfile.c (tfile_write_uploaded_tp):
1570         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1571         gdb::unique_xmalloc_ptr.
1572         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1573         at_string, cond_string, cmd_strings>: Replace char pointers
1574         with gdb::unique_xmalloc_ptr.
1575
1576 2019-01-10  Pedro Alves  <palves@redhat.com>
1577
1578         * solib-target.c (library_list_start_library): Don't xstrdup name.
1579
1580 2019-01-10  Pedro Alves  <palves@redhat.com>
1581
1582         * mdebugread.c (parse_partial_symbols): Use
1583         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1584
1585 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * linux-fork.c (scoped_switch_fork_info)
1588         <~scoped_switch_fork_info>: Fix incorrect variable name.
1589
1590 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1591
1592         * linux-fork.c (scoped_switch_fork_info)
1593         <scoped_switch_fork_info>: Make explicit.
1594         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1595
1596 2019-01-10  Tom Tromey  <tom@tromey.com>
1597
1598         * objfiles.h (objfile::reset_psymtabs): Update.
1599         * objfiles.c (objfile::objfile): Update.
1600         * psymtab.h (psymtab_storage::obstack): Update.
1601         (psymtab_storage::m_obstack): Use gdb::optional.
1602         (class psymtab_storage): Update comment.  Remove objfile
1603         parameter.
1604         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1605
1606 2019-01-10  Tom Tromey  <tom@tromey.com>
1607
1608         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1609         <free_psymtabs>: Now private.
1610         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1611         (allocate_psymtab): Use new method.
1612
1613 2019-01-10  Tom Tromey  <tom@tromey.com>
1614
1615         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1616         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1617         * mdebugread.c (parse_partial_symbols): Use
1618         allocate_dependencies.
1619         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1620         allocate_dependencies.
1621         (process_psymtab_comp_unit_reader)
1622         (build_type_psymtab_dependencies): Likewise.
1623         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1624
1625 2019-01-10  Tom Tromey  <tom@tromey.com>
1626
1627         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1628         PSYMBOL_SET_LANGUAGE.
1629         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1630
1631 2019-01-10  Tom Tromey  <tom@tromey.com>
1632
1633         * psymtab.h (psymtab_storage::obstack): New method.
1634         <m_obstack>: Rename from obstack; now private.
1635         * psymtab.c (psymtab_storage): Update.
1636         * dwarf2read.c (create_addrmap_from_index)
1637         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1638         Update.
1639
1640 2019-01-10  Tom Tromey  <tom@tromey.com>
1641
1642         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1643         * objfiles.h (objfile::reset_psymtabs): New method.
1644
1645 2019-01-10  Tom Tromey  <tom@tromey.com>
1646
1647         * symmisc.c (print_symbol_bcache_statistics): Update.
1648         (print_objfile_statistics): Update.
1649         * symfile.c (reread_symbols): Update.
1650         * psymtab.h (class psymtab_storage): New.
1651         * psymtab.c (psymtab_storage): New constructor.
1652         (~psymtab_storage): New destructor.
1653         (require_partial_symbols): Update.
1654         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1655         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1656         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1657         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1658         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1659         (start_psymtab_common, end_psymtab_common)
1660         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1661         (allocate_psymtab): Update.
1662         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1663         Update.
1664         (dump_psymtab_addrmap, maintenance_print_psymbols)
1665         (maintenance_check_psymtabs): Update.
1666         (class objfile_psymtabs): Move to objfiles.h.
1667         * psympriv.h (discard_psymtab): Now inline.
1668         (psymtab_discarder::psymtab_discarder): Update.
1669         (psymtab_discarder::~psymtab_discarder): Update.
1670         (ALL_OBJFILE_PSYMTABS): Rewrite.
1671         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1672         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1673         Remove fields.
1674         <partial_symtabs>: New field.
1675         (class objfile_psymtabs): Move from psymtab.h.  Update.
1676         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1677         psymbol_cache.
1678         (objfile::~objfile): Don't destroy psymbol_cache.
1679         * mdebugread.c (parse_partial_symbols): Update.
1680         * dwarf2read.c (create_addrmap_from_index)
1681         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1682         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1683         (add_partial_subprogram, dwarf2_ranges_read): Update.
1684         * dwarf-index-write.c (write_address_map)
1685         (write_one_signatured_type, recursively_write_psymbols)
1686         (class debug_names, class debug_names, write_psymtabs_to_index):
1687         Update.
1688
1689 2019-01-10  Tom Tromey  <tom@tromey.com>
1690
1691         * symtab.h (SYMBOL_SET_NAMES): Update.
1692         (symbol_set_names): Update.
1693         (MSYMBOL_SET_NAMES): Update.
1694         * symtab.c (symbol_set_names): Change argument to be an
1695         objfile_per_bfd_storage.
1696         * psymtab.c (add_psymbol_to_bcache): Update.
1697         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1698
1699 2019-01-10  Tom Tromey  <tom@tromey.com>
1700
1701         * symtab.c (create_demangled_names_hash): Change argument to be an
1702         objfile_per_bfd_storage.
1703         (symbol_set_names): Update.
1704
1705 2019-01-10  Tom Tromey  <tom@tromey.com>
1706
1707         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1708         init_psymbol_list.
1709         * psymtab.c (init_psymbol_list): Do nothing if already called.
1710         * psympriv.h (init_psymbol_list): Add comment.
1711         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1712         init_psymbol_list.
1713         * dbxread.c (dbx_symfile_read): Unconditionally call
1714         init_psymbol_list.
1715
1716 2019-01-10  Tom Tromey  <tom@tromey.com>
1717
1718         * xcoffread.c (scan_xcoff_symtab): Update.
1719         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1720         "where".
1721         * mdebugread.c (parse_partial_symbols)
1722         (handle_psymbol_enumerators): Update.
1723         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1724         * dbxread.c (read_dbx_symtab): Update.
1725         * psympriv.h (psymbol_placement): New enum.
1726         (add_psymbol_to_list): Update.
1727
1728 2019-01-10  Tom Tromey  <tom@tromey.com>
1729
1730         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1731         static_psymbols parameters.
1732         (scan_xcoff_symtab): Update.
1733         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1734         static_psymbols parameters.
1735         * psympriv.h (start_psymtab_common): Update.
1736         * mdebugread.c (parse_partial_symbols): Update.
1737         * dwarf2read.c (create_partial_symtab): Update.
1738         * dbxread.c (read_dbx_symtab): Update.
1739         (start_psymtab): Remove global_psymbols and static_psymbols
1740         parameters.
1741
1742 2019-01-10  Tom Tromey  <tom@tromey.com>
1743
1744         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1745         * psymtab.c (allocate_psymtab): Add comment.
1746         * psympriv.h (allocate_psymtab): Add comment.
1747         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1748         initializations.
1749         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1750
1751 2019-01-10  Tom Tromey  <tom@tromey.com>
1752
1753         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1754         Don't declare.
1755         * mipsread.c: Include mdebugread.h.
1756         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1757         Declare.
1758         * elfread.c: Include mdebugread.h.
1759
1760 2019-01-09  Tom Tromey  <tom@tromey.com>
1761
1762         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1763         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1764         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1765         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1766         (psym_lookup_symbol, psym_find_last_source_symtab)
1767         (psym_forget_cached_source_info, psym_print_stats)
1768         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1769         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1770         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1771         (psym_find_compunit_symtab_by_address)
1772         (maintenance_print_psymbols, maintenance_info_psymtabs)
1773         (maintenance_check_psymtabs): Use ranged for.
1774         * psymtab.h (class objfile_psymtabs): New.
1775         (require_partial_symbols): Return objfile_psymtabs.
1776         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1777
1778 2019-01-09  Tom Tromey  <tom@tromey.com>
1779
1780         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1781         (find_pc_mapped_section, list_overlays_command)
1782         (map_overlay_command, unmap_overlay_command)
1783         (simple_overlay_update): Use all_objfiles.
1784         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1785         * printcmd.c (info_symbol_command): Use all_objfiles.
1786         * objfiles.h (ALL_OBJSECTIONS): Remove.
1787         * maint.c (maintenance_translate_address): Use all_objfiles.
1788         * gcore.c (gcore_create_callback): Use all_objfiles.
1789         (objfile_find_memory_regions): Likewise.
1790
1791 2019-01-09  Tom Tromey  <tom@tromey.com>
1792
1793         * symtab.c (find_line_symtab, info_sources_command)
1794         (make_source_files_completion_list): Use objfile_compunits.
1795         * source.c (select_source_symtab): Use objfile_compunits.
1796         * objfiles.h (struct objfile): Update comment.
1797         (ALL_OBJFILES): Remove.
1798         (ALL_FILETABS): Remove.
1799         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1800         objfile_compunits.
1801
1802 2019-01-09  Tom Tromey  <tom@tromey.com>
1803
1804         * symmisc.c (print_objfile_statistics, dump_objfile)
1805         (maintenance_print_symbols): Use compunit_filetabs.
1806         * source.c (forget_cached_source_info_for_objfile): Use
1807         compunit_filetabs.
1808         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1809         (ALL_FILETABS): Use compunit_filetabs.
1810         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1811         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1812
1813 2019-01-09  Tom Tromey  <tom@tromey.com>
1814
1815         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1816         (compunit_filetabs): New.
1817         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1818         compunit_filetabs.
1819         (info_sources_command, make_source_files_completion_list): Remove
1820         declaration.
1821         * symmisc.c (print_objfile_statistics, dump_objfile)
1822         (maintenance_print_symbols): Remove declaration.
1823         (maintenance_info_symtabs): Use compunit_filetabs.
1824         (maintenance_info_line_tables): Likewise.
1825         * source.c (select_source_symtab): Change local variable name.
1826         (forget_cached_source_info_for_objfile): Remove declaration.
1827         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1828         * objfiles.c (objfile_relocate1): Remove declaration.
1829         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1830         declaration.
1831         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1832         * coffread.c (coff_symtab_read): Remove declaration.
1833         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1834         compunit_filetabs.
1835
1836 2019-01-09  Tom Tromey  <tom@tromey.com>
1837
1838         * symtab.c (lookup_objfile_from_block)
1839         (find_pc_sect_compunit_symtab, search_symbols)
1840         (default_collect_symbol_completion_matches_break_on): Use
1841         objfile_compunits.
1842         * objfiles.h (ALL_COMPUNITS): Remove.
1843         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1844         * cp-support.c (add_symbol_overload_list_qualified): Use
1845         objfile_compunits.
1846         * ada-lang.c (ada_collect_symbol_completion_matches)
1847         (ada_add_global_exceptions): Use objfile_compunits.
1848
1849 2019-01-09  Tom Tromey  <tom@tromey.com>
1850
1851         * source.c (select_source_symtab)
1852         (forget_cached_source_info_for_objfile): Remove declaration.
1853         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1854         declaration.
1855         * maint.c (count_symtabs_and_blocks): Remove declaration.
1856         * cp-support.c (add_symbol_overload_list_qualified): Remove
1857         declaration.
1858         * coffread.c (coff_symtab_read): Remove declaration.
1859         * symtab.c (lookup_symbol_in_objfile_symtabs)
1860         (basic_lookup_transparent_type_1): Use objfile_compunits.
1861         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1862         (info_sources_command, search_symbols)
1863         (default_collect_symbol_completion_matches_break_on)
1864         (make_source_files_completion_list): Remove declaration.
1865         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1866         (ada_collect_symbol_completion_matches)
1867         (ada_add_global_exceptions): Remove declaration.
1868         * linespec.c (iterate_over_all_matching_symtabs): Use
1869         objfile_compunits.
1870         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1871         (class objfile_compunits): New.
1872         (ALL_COMPUNITS): Use objfile_compunits.
1873         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1874         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1875         objfile_compunits.
1876         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1877
1878 2019-01-09  Tom Tromey  <tom@tromey.com>
1879
1880         * symtab.c (search_symbols)
1881         (default_collect_symbol_completion_matches_break_on): Use
1882         objfile_msymbols.
1883         * ada-lang.c (ada_lookup_simple_minsym)
1884         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1885         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1886         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1887         objfile_msymbols.
1888         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1889         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1890         * objc-lang.c (find_methods): Use objfile_msymbols.
1891         (info_selectors_command, info_classes_command): Likewise.
1892         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1893         * objfiles.h (class objfile_msymbols): New.
1894         (ALL_OBJFILE_MSYMBOLS): Remove.
1895         (ALL_MSYMBOLS): Remove.
1896
1897 2019-01-09  Tom Tromey  <tom@tromey.com>
1898
1899         * common/next-iterator.h (next_adapter): Add Iterator template
1900         parameter.
1901         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1902         (class all_objfiles_safe): New.
1903         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1904         * objfiles.c (put_objfile_before): Update comment.
1905         (add_separate_debug_objfile): Likewise.
1906         (free_all_objfiles): Use all_objfiles_safe.
1907         (objfile_purge_solibs): Likewise.
1908
1909 2019-01-09  Tom Tromey  <tom@tromey.com>
1910
1911         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1912         (expand_symtab_containing_pc, lookup_static_symbol)
1913         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1914         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1915         all_objfiles.
1916         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1917         * breakpoint.c (create_overlay_event_breakpoint)
1918         (create_longjmp_master_breakpoint)
1919         (create_std_terminate_master_breakpoint)
1920         (create_exception_master_breakpoint): Use all_objfiles.
1921         * linux-thread-db.c (try_thread_db_load_from_pdir)
1922         (has_libpthread): Use all_objfiles.
1923         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1924         * linespec.c (iterate_over_all_matching_symtabs)
1925         (search_minsyms_for_name): Use all_objfiles.
1926         * maint.c (maintenance_info_sections): Use all_objfiles.
1927         * main.c (captured_main_1): Use all_objfiles.
1928         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1929         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1930         * guile/scm-pretty-print.c
1931         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1932         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1933         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1934         (maintenance_print_msymbols): Use all_objfiles.
1935         * source.c (select_source_symtab): Use all_objfiles.
1936         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1937         * symfile.c (remove_symbol_file_command)
1938         (expand_symtabs_matching, map_symbol_filenames): Use
1939         all_objfiles.
1940         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1941         all_objfiles.
1942         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1943         * objc-lang.c (find_methods): Use all_objfiles.
1944         * objfiles.c (have_partial_symbols, have_full_symbols)
1945         (have_minimal_symbols, qsort_cmp)
1946         (default_iterate_over_objfiles_in_search_order): Use
1947         all_objfiles.
1948         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1949         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1950         (maintenance_check_psymtabs): Use all_objfiles.
1951         (ALL_PSYMTABS): Remove.
1952         * compile/compile-object-run.c (do_module_cleanup): Use
1953         all_objfiles.
1954         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1955         * cp-support.c (add_symbol_overload_list_qualified): Use
1956         all_objfiles.
1957         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1958         Use all_objfiles.
1959         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1960         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1961         all_objfiles.
1962         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1963         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1964         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1965         Uses all_objfiles.
1966         * solib.c (solib_read_symbols): Use all_objfiles
1967
1968 2019-01-09  Tom Tromey  <tom@tromey.com>
1969
1970         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1971         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1972         all_objfiles.
1973         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1974         * symmisc.c (print_symbol_bcache_statistics)
1975         (print_objfile_statistics, maintenance_print_objfiles)
1976         (maintenance_info_symtabs, maintenance_check_symtabs)
1977         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1978         all_objfiles.
1979         * source.c (forget_cached_source_info): Use all_objfiles.
1980         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1981         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1982         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1983         * objfiles.c (update_section_map): Use all_objfiles.
1984         (shared_objfile_contains_address_p): Likewise.
1985         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1986         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1987
1988 2019-01-09  Tom Tromey  <tom@tromey.com>
1989
1990         * common/next-iterator.h: New file.
1991         * objfiles.h (class all_objfiles): New.
1992         (struct objfile_iterator): New.
1993
1994 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1995
1996         * NEWS: Move the description of the changed "frame", "select-frame",
1997          and "info frame" commands to the Changed commands section.
1998
1999 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2000
2001         * gdbtypes.c (check_stub_method_group): Remove handling of old
2002         mangling schemes.
2003         * linespec.c (find_methods): Likewise.
2004         * stabsread.c (read_member_functions): Likewise.
2005         * valops.c (search_struct_method): Likewise.
2006         (value_struct_elt_for_reference): Likewise.
2007         * NEWS: Mention this change.
2008
2009 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2010
2011         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2012         print_source_lines.
2013         * source.c (print_source_lines_base): Update line number check.
2014         (print_source_lines): New function.
2015         (source_lines_range::source_lines_range): New function.
2016         * source.h (class source_lines_range): New class.
2017         (print_source_lines): New declaration.
2018
2019 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2020
2021         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2022
2023 2019-01-08  Tom Tromey  <tom@tromey.com>
2024             Simon Marchi  <simon.marchi@ericsson.com>
2025
2026         PR gdb/24060
2027         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2028         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2029         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2030         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2031         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2032         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2033
2034 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2035
2036         * source.c (select_source_symtab): Move header comment to
2037         declaration in source.h.
2038         (forget_cached_source_info_for_objfile): Likewise.
2039         (forget_cached_source_info): Likewise.
2040         (identify_source_line): Likewise.
2041         * source.h (identify_source_line): Move declaration from symtab.h
2042         and add comment from source.c
2043         (print_source_lines): Likewise.
2044         (forget_cached_source_info_for_objfile): Likewise.
2045         (forget_cached_source_info): Likewise.
2046         (select_source_symtab): Likewise.
2047         (enum print_source_lines_flag): Move definition from symtab.h.
2048         * symtab.h (identify_source_line): Move declaration to source.h.
2049         (print_source_lines): Likewise.
2050         (forget_cached_source_info_for_objfile): Likewise.
2051         (forget_cached_source_info): Likewise.
2052         (select_source_symtab): Likewise.
2053         (enum print_source_lines_flag): Move definition to source.h.
2054         * tui/tui-hooks.c: Add 'source.h' include.
2055
2056 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * source.c (print_source_lines_base): Handle requests to print
2059         reverse line number sequences, and guard against empty lines
2060         string.
2061
2062 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2063
2064         * source.c (print_source_lines_base): Fix skip of '\r' if next
2065         character is '\n'.
2066
2067 2019-01-06  Tom Tromey  <tom@tromey.com>
2068
2069         * c-exp.y (struct c_parse_state) <macro_original_text,
2070         expansion_obstack>: New member.
2071         (macro_original_text, expansion_obstack): Remove globals.
2072         (scan_macro_expansion, scanning_macro_expansion)
2073         (finished_macro_expansion): Update.
2074         (scan_macro_cleanup): Remove.
2075         (yylex, c_parse): Update.
2076
2077 2019-01-06  Tom Tromey  <tom@tromey.com>
2078
2079         * c-exp.y (struct c_parse_state) <strings>: New member.
2080         (operator_stoken): Update.
2081
2082 2019-01-06  Tom Tromey  <tom@tromey.com>
2083
2084         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2085         (union type_stack_elt) <typelist_val>: Now a pointer to
2086         std::vector.
2087         (type_stack_cleanup): Don't declare.
2088         (push_typelist): Update.
2089         * parse.c (pop_typelist): Return a std::vector.
2090         (push_typelist): Take a std::vector.
2091         (follow_types): Update.  Do not free args.
2092         (type_stack_cleanup): Remove.
2093         * c-exp.y (struct c_parse_state): New.
2094         (cpstate): New global.
2095         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2096         (nonempty_typelist): Update.
2097         (func_mod): Create a new vector.
2098         (c_parse): Create a c_parse_state.
2099         (check_parameter_typelist): Do not delete params.
2100         (function_method): Update.  Do not delete type_list.
2101
2102 2019-01-06  Tom Tromey  <tom@tromey.com>
2103
2104         PR gdb/28155:
2105         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2106         check_typedef.
2107         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2108         (print_return_value): Likewise.
2109
2110 2019-01-05  Tom Tromey  <tom@tromey.com>
2111
2112         * contrib/cleanup_check.py: Remove.
2113         * contrib/gcc-with-excheck: Remove.
2114         * contrib/exsummary.py: Remove.
2115         * contrib/excheck.py: Remove.
2116
2117 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2118
2119         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2120         NULL. Initialize tpprev to NULL instead of assigning it
2121         to NULL on the next statement.
2122         * windows-nat.c (windows_delete_thread): Remove check for
2123         main_thread_id before printing thread exit notifications.
2124         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2125         Remove thread ID check against main_thread_id.
2126         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2127         windows_delete_thread.
2128         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2129
2130 2019-01-04  Tom Tromey  <tom@tromey.com>
2131
2132         * compile/compile.c (_initialize_compile): Use upper case for
2133         metasyntactic variables.
2134         * symmisc.c (_initialize_symmisc): Use upper case for
2135         metasyntactic variables.
2136         * psymtab.c (_initialize_psymtab): Use upper case for
2137         metasyntactic variables.
2138         * demangle.c (demangle_command): Use upper case for metasyntactic
2139         variables.
2140         (_initialize_demangler): Likewise.
2141         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2142         variables.
2143
2144 2019-01-03  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2147
2148 2019-01-03  Tom Tromey  <tom@tromey.com>
2149
2150         * python/py-symtab.c (salpy_str): Update.
2151         (struct salpy_sal_object) <symtab>: Now a PyObject.
2152         (salpy_dealloc): Update.
2153         (del_objfile_sal): Use gdbpy_ref.
2154
2155 2019-01-03  Tom Tromey  <tom@tromey.com>
2156
2157         * python/py-type.c (convert_field): Use new_reference.  Return
2158         gdbpy_ref.
2159         (make_fielditem): Return gdbpy_ref.
2160         (typy_fields): Update.
2161         (typy_getitem): Update.
2162         (field_name): Return gdbpy_ref.  Use new_reference.
2163         (typy_iterator_iternext): Update.
2164
2165 2019-01-03  Tom Tromey  <tom@tromey.com>
2166
2167         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2168
2169 2019-01-03  Tom Tromey  <tom@tromey.com>
2170
2171         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2172         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2173         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2174         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2175         (pspy_set_type_printers): Likewise.
2176         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2177         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2178         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2179         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2180         (objfpy_set_type_printers): Likewise.
2181
2182 2019-01-03  Tom Tromey  <tom@tromey.com>
2183
2184         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2185         (gdbpy_print_stack): Use gdbpy_err_fetch.
2186         * python/python-internal.h (class gdbpy_err_fetch): New class.
2187         (class gdbpy_enter) <m_error_type, m_error_value,
2188         m_error_traceback>: Remove.
2189         <m_error>: New member.
2190         (gdbpy_exception_to_string): Don't declare.
2191         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2192         * python/py-value.c (convert_value_from_python): Use
2193         gdbpy_err_fetch.
2194         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2195         gdbpy_exception_to_string.
2196         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2197         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2198         gdbpy_err_fetch.
2199
2200 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2201
2202         * linux-nat.c (delete_lwp_cleanup): Delete.
2203         (struct lwp_deleter): New struct.
2204         (lwp_info_up): New typedef.
2205         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2206         lwp_info_up.
2207
2208 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2209
2210         * linux-fork.c (class scoped_switch_fork_info): New class.
2211         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2212
2213 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2214
2215         * valops.c (find_overload_match): Remove use of null_cleanup, and
2216         calls to do_cleanups.
2217
2218 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2219
2220         * compile/compile-cplus-types.c
2221         (compile_cplus_instance::decl_name): Handle changes to
2222         cp_func_name.
2223         * cp-support.c (cp_func_name): Update header comment, update
2224         return type.
2225         * cp-support.h (cp_func_name): Update return type in declaration.
2226         * valops.c (find_overload_match): Move temp_func local to top
2227         level of function and change its type.  Use temp_func to hold and
2228         delete temporary string obtained from cp_func_name.
2229
2230 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2231
2232         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2233         gdb::char_vector, remove cleanup, and update uses of `msg`.
2234
2235 2019-01-03  Jim Wilson  <jimw@sifive.com>
2236
2237         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2238
2239 2019-01-02  Tom Tromey  <tom@tromey.com>
2240
2241         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2242         (tdesc_parse_xml): Remove cleanups.
2243         * target-descriptions.h (make_cleanup_free_target_description):
2244         Don't declare.
2245         (target_desc_deleter): New struct.
2246         (target_desc_up): New typedef.
2247         * target-descriptions.c (target_desc_deleter::operator()): Rename
2248         from free_target_description.
2249         (make_cleanup_free_target_description): Remove.
2250
2251 2019-01-02  Tom Tromey  <tom@tromey.com>
2252
2253         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2254         constructor, destructor.
2255         (linespec_parser): Remove typedef.
2256         (~linespec_parser): Rename from linespec_parser_delete.
2257         (linespec_lex_to_end, linespec_complete_label)
2258         (linespec_complete): Update.
2259         (decode_line_full): Remove cleanups.
2260         (decode_line_1): Update.
2261
2262 2019-01-02  Tom Tromey  <tom@tromey.com>
2263
2264         * python/python-internal.h (inferior_to_inferior_object): Change
2265         return type.
2266         * python/py-exitedevent.c (create_exited_event_object): Update.
2267         * python/py-inferior.c (inferior_to_inferior_object): Return
2268         gdbpy_ref.
2269         (python_new_inferior, python_inferior_deleted)
2270         (thread_to_thread_object, delete_thread_object)
2271         (build_inferior_list, gdbpy_selected_inferior): Update.
2272         * python/py-infthread.c (create_thread_object): Update.  Also fail
2273         if inferior_to_inferior_object fails.
2274
2275 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2276
2277         * inferior.h (class inferior) <displaced_step_state>: New field.
2278         * infrun.h (struct displaced_step_state): Move here from
2279         infrun.c.  Initialize fields, add constructor.
2280         <inf>: Remove field.
2281         <reset>: New method.
2282         * infrun.c (struct displaced_step_inferior_state): Move to
2283         infrun.h.
2284         (displaced_step_inferior_states): Remove.
2285         (get_displaced_stepping_state): Adust.
2286         (displaced_step_in_progress_any_inferior): Adjust.
2287         (displaced_step_in_progress_thread): Adjust.
2288         (displaced_step_in_progress): Adjust.
2289         (add_displaced_stepping_state): Remove.
2290         (get_displaced_step_closure_by_addr): Adjust.
2291         (remove_displaced_stepping_state): Remove.
2292         (infrun_inferior_exit): Call displaced_step_state.reset.
2293         (use_displaced_stepping): Don't check for NULL.
2294         (displaced_step_prepare_throw): Call
2295         get_displaced_stepping_state.
2296         (displaced_step_fixup): Don't check for NULL.
2297         (prepare_for_detach): Don't check for NULL.
2298
2299 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2300
2301         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2302          in case of call that did not complete.
2303
2304 2019-01-02  Andrey Utkin  <autkin@undo.io>
2305
2306         * symfile.c (find_separate_debug_file): Fix search of debug files for
2307         remote debuggee.
2308
2309 2019-01-02  Tom Tromey  <tom@tromey.com>
2310
2311         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2312         indentation.
2313         * python/py-frame.c (frapy_older): Remove cast.
2314         (frapy_newer): Likewise.
2315         * python/py-breakpoint.c (local_setattro): Remove cast.
2316         * python/py-arch.c (archpy_name): Remove local variable.
2317         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2318
2319 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2320
2321         * unittests/basic_string_view/element_access/char/empty.cc:
2322         Fix year range in copyright header.
2323
2324 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2325
2326         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2327         Delete.
2328         <operator==>: Update with for removed field.
2329         <hash>: Likewise.
2330         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2331         <isa_features>: ...this.
2332         <abi_features>: New field.
2333         (riscv_isa_flen): Update comment.
2334         (riscv_abi_xlen): New declaration.
2335         (riscv_abi_flen): New declaration.
2336         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2337         isa_features.
2338         (riscv_abi_xlen): New function.
2339         (riscv_isa_flen): Update to get answer from isa_features.
2340         (riscv_abi_flen): New function.
2341         (riscv_has_fp_abi): Update to get answer from abi_features.
2342         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2343         xlen and flen.
2344         (riscv_call_info) <xlen, flen>: Update comment.
2345         (riscv_call_arg_struct): Remove invalid assertions
2346         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2347         is removed.
2348         (riscv_gdbarch_init): Gather isa features and abi features
2349         separately, ensure both match on the gdbarch when reusing an old
2350         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2351         a target with 64-bit float hardware.
2352
2353 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2354
2355         * source.c (search_command_helper): Stop reverse search
2356         when line 1 has been searched.
2357
2358 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2359
2360         * record-full.c (record_full_base_target::close): Rewrite
2361         record_full_core_buf_list free logic.
2362
2363 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2364
2365         * break-catch-syscall.c (print_one_catch_syscall): xfree
2366         the last text.
2367
2368 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2369
2370         * top.c (print_gdb_version): Update Copyright year in version
2371         message.
2372
2373 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2374
2375         Update copyright year range in all GDB files.
2376
2377 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2378
2379         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2380
2381 For older changes see ChangeLog-2018.
2382 \f
2383 Local Variables:
2384 mode: change-log
2385 left-margin: 8
2386 fill-column: 74
2387 version-control: never
2388 coding: utf-8
2389 End:
2390