gdb/ChangeLog

   1 2019-05-06  Tom Tromey  <tom@tromey.com>
   2
   3         * common/scoped_mmap.c: Include common-defs.h.
   4         * common/scoped_mmap.h: Don't include config.h.
   5
   6 2019-05-04  Tom Tromey  <tom@tromey.com>
   7
   8         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
   9         (struct aarch64_call_info): Add initializers.
  10         <si>: Now a std::vector.
  11         (pass_on_stack, aarch64_push_dummy_call): Update.
  12
  13 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
  14             Tom Tromey  <tom@tromey.com>
  15
  16         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
  17         (ppc_threads): Now a std::vector.  Now static.
  18         (hwdebug_find_thread_points_by_tid)
  19         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
  20         Update.
  21
  22 2019-05-04  Tom Tromey  <tom@tromey.com>
  23
  24         * arc-tdep.c (arc_tdesc_init): Return bool.
  25
  26 2019-05-04  Tom Tromey  <tom@tromey.com>
  27
  28         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
  29         Use gdb_assert_not_reached.
  30
  31 2019-05-04  Tom Tromey  <tom@tromey.com>
  32
  33         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
  34         "false".
  35
  36 2019-05-04  Tom Tromey  <tom@tromey.com>
  37
  38         * arc-tdep.c (arc_tdesc_init): Use bool.
  39
  40 2019-05-04  Tom Tromey  <tom@tromey.com>
  41
  42         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  43
  44 2019-05-04  Tom Tromey  <tom@tromey.com>
  45
  46         * cli/cli-cmds.c (valid_command_p): Return bool.
  47
  48 2019-05-04  Tom Tromey  <tom@tromey.com>
  49
  50         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  51         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  52
  53 2019-05-04  Raul Tambre  <raul@tambre.ee>
  54
  55         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  56         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  57         operator for comparison.
  58
  59 2019-05-04  Tom Tromey  <tom@tromey.com>
  60
  61         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  62         (lookup_partial_symbol, print_partial_symbols)
  63         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  64         (psymbol_compare): Update.
  65         (add_psymbol_to_bcache): Clear the entire psymbol.
  66         (maintenance_check_psymtabs): Update.
  67         * psympriv.h (struct partial_symbol): Don't derive from
  68         general_symbol_info.
  69         <obj_section, unrelocated_address, address,
  70         set_unrelocated_address>: Update.
  71         <ginfo>: New member.
  72         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  73         (debug_names::write_psymbols): Update.
  74
  75 2019-05-04  Tom de Vries  <tdevries@suse.de>
  76
  77         * contrib/cc-with-tweaks.sh: Support -n arg.
  78
  79 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  80
  81         * corelow.c (core_target::detach): Ensure frame cache and
  82         register caches are cleared.
  83         inferior.c (exit_inferior_1): Likewise.
  84
  85 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  86             Tom Tromey  <tom@tromey.com>
  87
  88         * dictionary.c (collate_pending_symbols_by_language): Remove
  89         "struct" from foreach.
  90         * symtab.c (lookup_global_symbol_from_objfile)
  91         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  92         foreach.
  93         * ser-tcp.c (net_open): Remove "struct" from foreach.
  94         * objfiles.c (objfile_relocate, objfile_rebase)
  95         (objfile_has_symbols): Remove "struct" from foreach.
  96         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  97         from foreach.
  98         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  99         foreach.
 100         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 101         "struct" from foreach.
 102         * ada-lang.c (create_excep_cond_exprs)
 103         (ada_exception_catchpoint_cond_string): Remove "struct" from
 104         foreach.
 105
 106 2019-05-03  Tom Tromey  <tromey@adacore.com>
 107
 108         * ada-exp.y (convert_char_literal): Check suffix of each
 109         enumerator.
 110
 111 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 112
 113         PR ada/21406:
 114         * ada-exp.y (yywrap): Don't define.
 115         * ada-lex.l (%option): Add noyywrap
 116         (yywrap): Remove.
 117
 118 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 119
 120         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 121         _WIN32_WINNT to the XP level, unless already defined to a higher
 122         level.
 123
 124         * unittests/parse-connection-spec-selftests.c:
 125         * ser-tcp.c:
 126         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 127         override.
 128
 129         * symfile.c (find_separate_debug_file): Remove colon from the
 130         drive spec of DOS/Windows file names of the target, so that the
 131         file name produced from DEBUGDIR and the target's directory will
 132         be valid on DOS/Windows systems.
 133
 134 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 135
 136         * rust-lang.c (val_print_struct): Handle printing structures
 137         containing strings.
 138
 139 2019-05-02  Tom Tromey  <tromey@adacore.com>
 140
 141         * valarith.c (_initialize_valarith): Remove.
 142
 143 2019-05-01  Tom Tromey  <tromey@adacore.com>
 144
 145         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 146         bitfields.
 147
 148 2019-05-01  Tom Tromey  <tromey@adacore.com>
 149
 150         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 151         for big-endian copies.
 152
 153 2019-04-30  Ali Tamur  <tamur@google.com>
 154         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 155         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 156         (read_3_bytes): New function.
 157
 158 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 159
 160         * windows-nat.c (main_thread_id): Delete.
 161         (handle_output_debug_string): Replace main_thread_id by
 162         current_event.dwThreadId.
 163         (fake_create_process): Likewise.
 164         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 165         Do not set main_thread_id.
 166         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 167         current_event.dwThreadId.
 168         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 169
 170 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 171
 172         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 173         Use current_event.dwThreadId instead of main_thread_id.
 174
 175 2019-04-30  Tom Tromey  <tromey@adacore.com>
 176
 177         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 178         (create_excep_cond_exprs): Iterate over program spaces.
 179         (ada_exception_catchpoint_cond_string): Examine all minimal
 180         symbols for exception types.
 181
 182 2019-04-30  Tom Tromey  <tromey@adacore.com>
 183
 184         PR c++/24470:
 185         * dwarf2read.c (process_structure_scope): Handle case where type
 186         has template parameters but no symbol was created.
 187
 188 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 189             Chris January  <chris.january@arm.com>
 190
 191         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 192         qualifier.
 193         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 194
 195 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 196
 197         * f-typeprint.c (f_print_type): Update rules for printing
 198         whitespace.
 199         (f_type_print_varspec_suffix): Likewise.
 200
 201 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 202             Chris January  <chris.january@arm.com>
 203
 204         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 205         function arguments.
 206
 207 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * f-lang.c (build_fortran_types): Change name of void type to
 210         lower case.
 211         * f-typeprint.c (f_type_print_base): Print the name of the void
 212         type, rather than a fixed string.
 213         * f-valprint.c (f_decorations): Use lower case void string.
 214
 215 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 216             Chris January  <chris.january@arm.com>
 217
 218         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 219         types for Fortran.
 220
 221 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 222             Chris January  <chris.january@arm.com>
 223             David Lecomber  <david.lecomber@arm.com>
 224
 225         * f-exp.y (BINOP_INTRINSIC): New token.
 226         (exp): New parser rule handling BINOP_INTRINSIC.
 227         (f77_keywords): Add new builtin procedures.
 228         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 229         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 230         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 231         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 232         (print_unop_subexp_f): New function.
 233         (print_binop_subexp_f): New function.
 234         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 235         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 236         (dump_subexp_body_f): Likewise.
 237         (operator_check_f): Likewise.
 238         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 239         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 240
 241 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 242
 243         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 244         UNOP_KIND.
 245         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 246         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 247         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 248         (operator_length_f): New fuction.
 249         (print_subexp_f): New function.
 250         (op_name_f): New function.
 251         (dump_subexp_body_f): New function.
 252         (operator_check_f): New function.
 253         (exp_descriptor_f): Replace standard expression handling functions
 254         with new functions.
 255         * gdb/fortran-operator.def: New file.
 256         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 257         * gdb/std-operator.def: Remove UNOP_KIND.
 258
 259 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 260
 261         * std-operator.def: Remove unbalanced, stray double quote
 262         character.
 263
 264 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 265             Chris January  <chris.january@arm.com>
 266             Daniel Everett  <daniel.everett@arm.com>
 267             Nick Forrington  <nick.forrington@arm.com>
 268             Richard Bunt  <richard.bunt@arm.com>
 269
 270         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 271         of depth when printing anonymous structs or unions.
 272         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 273         Don't print either the top-level value, or the children if the
 274         max-depth is exceeded.
 275         (ppscm_print_children): When printing the key of a map, allow one
 276         extra level of depth.
 277         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 278         print either the top-level value, or the children if the max-depth
 279         is exceeded.
 280         (print_children): When printing the key of a map, allow one extra
 281         level of depth.
 282         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 283         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 284         (user_print_options): Initialise max_depth field.
 285         (val_print_scalar_or_string_type_p): New function.
 286         (val_print): Check to see if the max depth has been reached.
 287         (val_print_check_max_depth): Define new function.
 288         (show_print_max_depth): New function.
 289         (_initialize_valprint): Add 'print max-depth' option.
 290         * valprint.h (struct value_print_options) <max_depth>: New field.
 291         (val_print_check_max_depth): Declare new function.
 292         * NEWS: Document new feature.
 293
 294 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 295
 296         * ada-lang.c (ada_language_defn): Initialise new field.
 297         * c-lang.c (c_is_string_type_p): New function.
 298         (c_language_defn): Initialise new field.
 299         (cplus_language_defn): Initialise new field.
 300         (asm_language_defn): Initialise new field.
 301         (minimal_language_defn): Initialise new field.
 302         * c-lang.h (c_is_string_type_p): Declare new function.
 303         * d-lang.c (d_language_defn): Initialise new field.
 304         * f-lang.c (f_is_string_type_p): New function.
 305         (f_language_defn): Initialise new field.
 306         * go-lang.c (go_is_string_type_p): New function.
 307         (go_language_defn): Initialise new field.
 308         * language.c (default_is_string_type_p): New function.
 309         (unknown_language_defn): Initialise new field.
 310         (auto_language_defn): Initialise new field.
 311         * language.h (struct language_defn) <la_is_string_type_p>: New
 312         member variable.
 313         (default_is_string_type_p): Declare new function.
 314         * m2-lang.c (m2_language_defn): Initialise new field.
 315         * objc-lang.c (objc_language_defn): Initialise new field.
 316         * opencl-lang.c (opencl_language_defn): Initialise new field.
 317         * p-lang.c (pascal_is_string_type_p): New function.
 318         (pascal_language_defn): Initialise new field.
 319         * rust-lang.c (rust_is_string_type_p): New function.
 320         (rust_language_defn): Initialise new field.
 321
 322 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 323
 324         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 325         New field.
 326         * ada-lang.c (ada_language_defn): Initialise new field.
 327         * c-lang.c (c_language_defn): Likewise.
 328         (cplus_language_defn): Likewise.
 329         (asm_language_defn): Likewise.
 330         (minimal_language_defn): Likewise.
 331         * d-lang.c (d_language_defn): Likewise.
 332         * f-lang.c (f_language_defn): Likewise.
 333         * go-lang.c (go_language_defn): Likewise.
 334         * language.c (unknown_language_defn): Likewise.
 335         (auto_language_defn): Likewise.
 336         * m2-lang.c (m2_language_defn): Likewise.
 337         * objc-lang.c (objc_language_defn): Likewise.
 338         * opencl-lang.c (opencl_language_defn): Likewise.
 339         * p-lang.c (pascal_language_defn): Likewise.
 340         * rust-lang.c (rust_language_defn): Likewise.
 341
 342 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 343
 344         * ada-lang.c (ada_is_character_type): Change return type to bool.
 345         (ada_is_string_type): Likewise.
 346         * ada-lang.h (ada_is_character_type): Update declaration
 347         (ada_is_string_type): Likewise.
 348
 349 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 350
 351         Support style in 'frame|thread apply'
 352
 353         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 354         * record.c (record_start, record_stop): Update callers of
 355         execute_command_to_string with false.
 356         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 357         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 358         methods.
 359         (class string_file): New constructor with term_out parameter.
 360         Override methods term_out and can_emit_style_escape.  New member
 361         term_out.
 362         (class stdio_file): Override can_emit_style_escape.
 363         (class tee_file): Override term_out and can_emit_style_escape.
 364         * utils.h (can_emit_style_escape): Remove.
 365         * utils.c (can_emit_style_escape): Likewise.
 366         Update all callers of can_emit_style_escape (SOMESTREAM) to
 367         SOMESTREAM->can_emit_style_escape.
 368         * source-cache.c (source_cache::get_source_lines): Likewise.
 369         * stack.c (frame_apply_command_count): Call execute_command_to_string
 370         passing the term_out characteristic of the current gdb_stdout.
 371         * thread.c (thr_try_catch_cmd): Likewise.
 372         * top.c (execute_command_to_string): pass term_out parameter
 373         to construct the string_file for the command output.
 374         * ui-file.c (term_cli_styling): New function (most code moved
 375         from utils.c can_emit_style_escape).
 376         (string_file::string_file, string_file::can_emit_style_escape,
 377         stdio_file::can_emit_style_escape, tee_file::term_out,
 378         tee_file::can_emit_style_escape): New functions.
 379
 380 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 381
 382         * NEWS: Mention the new set|show may-call-functions.
 383         * infcall.c (may_call_functions_p): New variable.
 384         (show_may_call_functions_p): New function.
 385         (call_function_by_hand_dummy): Throws an error if not
 386         may-call-functions.
 387         (_initialize_infcall): Call add_setshow_boolean_cmd for
 388         may-call-functions.
 389
 390 2019-04-25  Keith Seitz  <keiths@redhat.com>
 391
 392         PR c++/24367
 393         * cp-support.c (inspect_type): Don't attempt substitutions
 394         of symbol with the same name.
 395
 396 2019-04-25  Tom Tromey  <tromey@adacore.com>
 397
 398         PR gdb/24475:
 399         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 400         static.
 401
 402 2019-04-25  Tom Tromey  <tromey@adacore.com>
 403
 404         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 405         rvalue reference.
 406         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 407         (gdb_xml_parser::parse): Use std::move.
 408         * python/python-internal.h (gdbpy_convert_exception): Take a const
 409         reference.
 410         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 411         std::move.
 412         * python/py-utils.c (gdbpy_convert_exception): Take a const
 413         reference.
 414         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 415         Use std::move.
 416         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 417         Use std::move.
 418         * mi/mi-main.c (mi_print_exception): Take a const reference.
 419         * main.c (handle_command_errors): Take a const reference.
 420         * linespec.c (parse_linespec): Use std::move.
 421         * infcall.c (run_inferior_call): Use std::move.
 422         (call_function_by_hand_dummy): Use std::move.
 423         * exec.c (try_open_exec_file): Use std::move.
 424         * exceptions.h (exception_print, exception_fprintf)
 425         (exception_print_same): Update.
 426         * exceptions.c (print_exception, exception_print)
 427         (exception_fprintf, exception_print_same): Change parameters to
 428         const reference.
 429         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 430         * common/new-op.c: Use std::move.
 431         * common/common-exceptions.h (struct gdb_exception): Add move
 432         constructor.
 433         (struct gdb_exception_error, struct gdb_exception_quit, struct
 434         gdb_quit_bad_alloc): Change constructor to move constructor.
 435         (throw_exception): Change parameter to rvalue reference.
 436         * common/common-exceptions.c (throw_exception): Take rvalue
 437         reference.
 438         * cli/cli-interp.c (safe_execute_command): Use std::move.
 439         * breakpoint.c (insert_bp_location, location_to_sals): Use
 440         std::move.
 441
 442 2019-04-25  Tom Tromey  <tromey@adacore.com>
 443
 444         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 445         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 446         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 447         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 448         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 449         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 450         guile/scm-value.c: Use unpack.
 451         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 452         gdbscm_gdb_exception.
 453         (gdbscm_throw_gdb_exception): Likewise.
 454         (struct gdbscm_gdb_exception): New.
 455         (unpack): New function.
 456         (gdbscm_wrap): Use unpack.
 457
 458 2019-04-25  Tom Tromey  <tromey@adacore.com>
 459
 460         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 461         (gdb_rl_callback_handler): Use std::move.
 462         * common/common-exceptions.h (struct gdb_exception): Add move
 463         assignment operator.
 464         (throw_exception_sjlj): Change "exception" to const reference.
 465         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 466         (throw_exception_sjlj): Change "exception" to const reference.
 467
 468 2019-04-25  Tom Tromey  <tromey@adacore.com>
 469
 470         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 471         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 472         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 473         Update.
 474         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 475         Update.
 476         * mi/mi-interp.c (mi_interp::exec): Update.
 477         * linespec.c (parse_linespec): Update.
 478         * infcall.c (run_inferior_call): Update.
 479         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 480         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 481         (gdbscm_lookup_global_symbol): Update.
 482         * guile/scm-param.c (gdbscm_parameter_value): Update.
 483         * guile/scm-frame.c (gdbscm_frame_read_register)
 484         (gdbscm_frame_read_var): Update.
 485         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 486         * exec.c (try_open_exec_file): Update.
 487         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 488         (gdb_rl_callback_handler): Update.
 489         * common/common-exceptions.h (exception_none): Don't declare.
 490         * common/common-exceptions.c (exception_none): Don't define.
 491         (struct catcher) <exception>: Update.
 492         * cli/cli-interp.c (safe_execute_command): Update.
 493         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 494
 495 2019-04-25  Ali Tamur  <tamur@google.com>
 496
 497         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 498         (read_attribute_value): Likewise.
 499         (dwarf2_read_addr_index): Update comment.
 500         (read_str_index): Add DW_FORM_strx.
 501         (dwarf2_string_attr): Likewise.
 502         (dwarf2_const_value_attr): Likewise.
 503         (dump_die_shallow): Likewise.
 504         (dwarf2_fetch_constant_bytes): Likewise.
 505         (skip_form_bytes): Likewise.
 506         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 507
 508 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 509
 510         PR corefiles/11608
 511         PR corefiles/18187
 512         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 513         OFFSET.  Verify if current mapping contains an ELF header.
 514         (linux_find_memory_regions_full): Adjust call to
 515         dump_mapping_p.
 516
 517 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 518             Kang Li <kanglictf@gmail.com>
 519
 520         PR gdb/21600
 521
 522         * dwarf2-frame.c (read_initial_length): Be consistent about using
 523         unsigned representation of length.
 524         (decode_frame_entry_1): Likewise.  Check for wraparound of
 525         end pointer as well as buffer overflow.
 526
 527 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 528
 529         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 530         "vq".
 531
 532 2019-04-24  Tom Tromey  <tromey@adacore.com>
 533
 534         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 535
 536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 537
 538         * s12z-tdep.c (s12z_unwind_pc): Delete.
 539         (s12z_unwind_sp): Delete.
 540         (s12z_gdbarch_init): Don't register deleted functions with
 541         gdbarch.
 542
 543 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 544
 545         * rl78-tdep.c (rl78_unwind_sp): Delete.
 546         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 547
 548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 549
 550         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 551         (xstormy16_unwind_pc): Delete.
 552         (xstormy16_dummy_id): Delete.
 553         (xstormy16_gdbarch_init): Don't register deleted functions with
 554         gdbarch.
 555
 556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * vax-tdep.c (vax_unwind_pc): Delete.
 559         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 560
 561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 562
 563         * v850-tdep.c (v850_unwind_sp): Delete.
 564         (v850_unwind_pc): Delete.
 565         (v850_dummy_id): Delete.
 566         (v850_gdbarch_init): Don't register deleted functions with
 567         gdbarch.
 568
 569 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 570
 571         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 572         (tilegx_unwind_pc): Delete.
 573         (tilegx_unwind_dummy_id): Delete.
 574         (tilegx_gdbarch_init): Don't register deleted functions with
 575         gdbarch.
 576
 577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 578
 579         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 580         (tic6x_dummy_id): Delete.
 581         (tic6x_gdbarch_init): Don't register deleted functions with
 582         gdbarch.
 583
 584 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 585
 586         * sparc-tdep.c (sparc_unwind_pc): Delete.
 587         (sparc32_gdbarch_init): Don't register deleted function with
 588         gdbarch.
 589
 590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 591
 592         * sh-tdep.c (sh_unwind_sp): Delete.
 593         (sh_unwind_pc): Delete.
 594         (sh_dummy_id): Delete.
 595         (sh_gdbarch_init): Don't register deleted functions with
 596         gdbarch.
 597
 598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 599
 600         * score-tdep.c (score_unwind_sp): Delete.
 601         (score_unwind_pc): Delete.
 602         (score_dummy_id): Delete.
 603         (score_gdbarch_init): Don't register deleted functions with
 604         gdbarch.
 605
 606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 607
 608         * rx-tdep.c (rx_unwind_pc): Delete.
 609         (rx_unwind_sp): Delete.
 610         (rx_dummy_id): Delete.
 611         (rx_gdbarch_init): Don't register deleted functions with
 612         gdbarch.  Update comment.
 613
 614 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 615
 616         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 617         (rs6000_dummy_id): Delete.
 618         (rs6000_gdbarch_init): Don't register deleted functions with
 619         gdbarch.
 620
 621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 622
 623         * or1k-tdep.c (or1k_dummy_id): Delete.
 624         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 625
 626 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 627
 628         * nios2-tdep.c (nios2_dummy_id): Delete.
 629         (nios2_unwind_sp): Delete.
 630         (nios2_gdbarch_init): Don't register deleted functions with
 631         gdbarch.
 632
 633 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 634
 635         * nds32-tdep.c (nds32_dummy_id): Delete.
 636         (nds32_unwind_pc): Delete.
 637         (nds32_unwind_sp): Delete.
 638         (nds32_gdbarch_init): Don't register deleted functions with
 639         gdbarch.
 640
 641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 642
 643         * msp430-tdep.c (msp430_unwind_pc): Delete.
 644         (msp430_unwind_sp): Delete.
 645         (msp430_dummy_id): Delete.
 646         (msp430_gdbarch_init): Don't register deleted functions with
 647         gdbarch.
 648
 649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 650
 651         * moxie-tdep.c (moxie_unwind_sp): Delete.
 652         (moxie_unwind_pc): Delete.
 653         (moxie_dummy_id): Delete.
 654         (moxie_gdbarch_init): Don't register deleted functions with
 655         gdbarch.
 656
 657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 658
 659         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 660         (mn10300_unwind_pc): Delete.
 661         (mn10300_unwind_sp): Delete.
 662         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 663         mn10300_unwind_sp.
 664         (mn10300_frame_unwind_init): Don't register deleted functions with
 665         gdbarch.
 666
 667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 668
 669         * mep-tdep.c (mep_unwind_pc): Delete.
 670         (mep_unwind_sp): Delete.
 671         (mep_dummy_id): Delete.
 672         (mep_gdbarch_init): Don't register deleted functions with
 673         gdbarch.
 674
 675 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 676
 677         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 678         (m68hc11_unwind_sp): Delete.
 679         (m68hc11_gdbarch_init): Don't register deleted functions with
 680         gdbarch.
 681
 682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 683
 684         * m32r-tdep.c (m32r_unwind_sp): Delete.
 685         (m32r_unwind_pc): Delete.
 686         (m32r_dummy_id): Delete.
 687         (m32r_gdbarch_init): Don't register deleted functions with
 688         gdbarch.
 689
 690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 691
 692         * m32c-tdep.c (m32c_unwind_pc): Delete.
 693         (m32c_unwind_sp): Delete.
 694         (m32c_dummy_id): Delete.
 695         (m32c_gdbarch_init): Don't register deleted functions with
 696         gdbarch.
 697
 698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 699
 700         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 701         (lm32_unwind_pc): Delete.
 702         (lm32_dummy_id): Delete.
 703         (lm32_gdbarch_init): Don't register deleted functions with
 704         gdbarch.
 705
 706 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 707
 708         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 709         (iq2000_unwind_pc): Delete.
 710         (iq2000_dummy_id): Delete.
 711         (iq2000_gdbarch_init): Don't register deleted functions with
 712         gdbarch.
 713
 714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * nds32-tdep.c (nds32_type_align): Delete.
 717         (nds32_push_dummy_call): Use type_align instead.
 718
 719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * arm-tdep.c (arm_type_align): Only handle vector override case.
 722         (arm_push_dummy_call): Use type_align.
 723         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 724
 725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 726
 727         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 728         case.
 729         (pass_on_stack): Use type_align.
 730         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 731         function.
 732
 733 2019-04-23  Tom Tromey  <tromey@adacore.com>
 734
 735         * dwarf2read.c (line_header::file_name_at): Remove unused
 736         overload.
 737
 738 2019-04-23  Tom de Vries  <tdevries@suse.de>
 739
 740         PR gdb/24438
 741         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 742         invocation.
 743
 744
 745 2019-03-27  Ali Tamur  <tamur@google.com>
 746
 747         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 748         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 749         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 750         (dwarf_expr_context::get_addr_index): Likewise
 751         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 752         (symbol_needs_eval_context::get_addr_index): Likewise
 753         (disassemble_dwarf_expression): Add DW_OP_addrx
 754         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 755         (read_cutu_die_from_dwo): Update comment
 756         (skip_one_die): Add DW_FORM_addrx
 757         (read_attribute_value): Likewise
 758         (var_decode_location): Add DW_OP_addrx
 759         (dwarf2_const_value_attr): Add DW_FORM_addrx
 760         (dump_die_shallow): Likewise
 761         (dwarf2_fetch_constant_bytes): Likewise
 762         (decode_locdesc): Add DW_OP_addrx
 763         (skip_form_bytes): Add DW_FORM_addrx
 764
 765 2019-04-22  Ali Tamur  <tamur@google.com>
 766
 767         * MAINTAINERS (Write After Approval): Add self.
 768
 769 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 770
 771         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 772         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 773         (open_symbol_file_object): Likewise.
 774         (svr4_default_sos): Add info parameter.
 775         (svr4_read_so_list): Likewise.
 776         (svr4_current_sos_direct): Adjust functions calls to pass down
 777         info.
 778         (svr4_current_sos_1): Add info parameter.
 779         (svr4_current_sos): Call get_svr4_info, pass info down to
 780         svr4_current_sos_1.
 781         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 782         get_svr4_info.
 783         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 784         get_svr4_info.
 785         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 786         to get_svr4_info.
 787         (probes_table_remove_objfile_probes): Likewise.
 788         (register_solib_event_probe): Add info parameter.
 789         (solist_update_incremental): Pass info parameter down to
 790         svr4_read_so_list.
 791         (disable_probes_interface): Add info parameter.
 792         (svr4_handle_solib_event): Pass current_program_space to
 793         get_svr4_info.  Adjust disable_probes_interface cleanup.
 794         (svr4_create_probe_breakpoints): Add info parameter, pass it
 795         down to register_solib_event_probe.
 796         (svr4_create_solib_event_breakpoints): Add info parameter,
 797         pass it down to svr4_create_probe_breakpoints.
 798         (enable_break): Pass info down to
 799         svr4_create_solib_event_breakpoints.
 800         (svr4_solib_create_inferior_hook): Pass current_program_space to
 801         get_svr4_info.
 802         (svr4_clear_solib): Likewise.
 803
 804 2019-04-22  Pedro Alves  <palves@redhat.com>
 805
 806         * solib-svr4.c (svr4_free_objfile_observer): New.
 807         (probe_and_action::objfile): New field.
 808         (probes_table_htab_remove_objfile_probes)
 809         (probes_table_remove_objfile_probes): New functions.
 810         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 811         in the new probe_and_action.  Don't store the probe in 'lookup'.
 812         (svr4_create_probe_breakpoints): Pass objfile to
 813         register_solib_event_probe.
 814         (_initialize_svr4_solib): Register a free_objfile observer.
 815
 816 2019-04-19  Tom Tromey  <tom@tromey.com>
 817
 818         * common/queue.h: Remove.
 819
 820 2019-04-19  Tom Tromey  <tom@tromey.com>
 821
 822         * event-loop.c: Don't include "common/queue.h".
 823
 824 2019-04-19  Tom Tromey  <tom@tromey.com>
 825
 826         * remote.c (remote_target): Use delete.
 827         * remote-notif.h: Include <list>, not "common/queue.h".
 828         (notif_client_p): Remove typedef.
 829         (remote_notif_state): Add constructor, destructor, initializer.
 830         <notif_queue>: Now a std::list.
 831         (remote_notif_state_xfree): Don't declare.
 832         * remote-notif.c (remote_notif_process, handle_notification)
 833         (remote_notif_state_allocate): Update.
 834         (~remote_notif_state): Rename from remote_notif_state_xfree.
 835
 836 2019-04-19  Tom Tromey  <tom@tromey.com>
 837
 838         * symfile.c (reread_symbols): Update.
 839         * objfiles.c (objfile_register_static_link)
 840         (objfile_lookup_static_link): Update
 841         (~objfile) Don't delete static_links.
 842         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 843
 844 2019-04-19  Tom Tromey  <tom@tromey.com>
 845
 846         * type-stack.h (struct type_stack) <insert>: Constify string.
 847         * type-stack.c (type_stack::insert): Constify string.
 848         * gdbtypes.h (lookup_template_type): Update.
 849         (address_space_name_to_int): Update.
 850         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 851         const.
 852         (lookup_template_type): Make name const.
 853         * c-exp.y: Update rules.
 854         (lex_one_token, classify_name, classify_inner_name)
 855         (c_print_token): Update.
 856         * p-exp.y: Update rules.
 857         (yylex): Update.
 858         * f-exp.y: Update rules.
 859         (yylex): Update.
 860         * d-exp.y: Update rules.
 861         (lex_one_token, classify_name, classify_inner_name): Update.
 862         * parse.c (write_dollar_variable, copy_name): Return std::string.
 863         * parser-defs.h (copy_name): Change return type.
 864         * m2-exp.y: Update rules.
 865         (yylex): Update.
 866         * go-exp.y (lex_one_token): Update.
 867         Update rules.
 868         (classify_unsafe_function, classify_packaged_name)
 869         (classify_name, yylex): Update.
 870
 871 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 872
 873         * configure.ac: add --enable-source-highlight switch.
 874         * configure: Regenerate.
 875         * top.c (print_gdb_version): plumb --enable-source-highlight
 876         status to "show configuration".
 877
 878 2019-04-19  Tom Tromey  <tromey@adacore.com>
 879
 880         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 881         Check ADA_TYPE_P.
 882         (empty_record, ada_template_to_fixed_record_type_1)
 883         (template_to_static_fixed_type)
 884         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 885         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 886         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 887         macros.
 888
 889 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 890
 891         PR symtab/24423:
 892         * source.c (print_source_lines_base): Advance "iter" when a
 893         control character is seen.
 894
 895 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 896
 897         * inferior.h (struct infcall_suspend_state_deleter):
 898         Catch exception in destructor to avoid crash.
 899
 900 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 901
 902         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 903         close to the add_com "shell".
 904
 905 2019-04-18  Tom Tromey  <tromey@adacore.com>
 906
 907         * process-stratum-target.h (class process_stratum_target)
 908         <stratum>: Add "final".
 909
 910 2019-04-17  Tom Tromey  <tromey@adacore.com>
 911
 912         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 913         against nullptr before use.
 914
 915 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 916
 917         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 918
 919 2019-04-17  Jim Wilson  <jimw@sifive.com>
 920             Andrew Burgess  <andrew.burgess@embecosm.com>
 921
 922         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 923         code read might fail, assume 4-byte breakpoint in that case.
 924
 925 2019-04-15  Leszek Swirski  <leszeks@google.com>
 926
 927         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 928         rather than a hand-rolled POD check when checking for forced MEMORY
 929         classification.
 930
 931 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 932
 933         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 934         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 935         function.
 936         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 937         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 938         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 939         declaration.
 940
 941 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 942
 943         * aarch64-linux-nat.c
 944         (aarch64_linux_nat_target::thread_architecture): Add override.
 945         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 946         each VQ.
 947
 948 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 949
 950         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 951
 952 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 953
 954         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 955         target types of size 96-bits, add some additional comments, and
 956         check that the builtin type we found was the correct size.
 957
 958 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 959
 960         * utils.c (prompt_for_continue): Don't restore the styling at the
 961         end, as applied_style has the wrong value.  This fixes styling in
 962         long lists of file names that are interrupted by the "Continue?"
 963         prompt.
 964
 965 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 966
 967         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 968         * c-lang.c (c_language_defn): Likewise.
 969         (cplus_language_defn): Likewise.
 970         (asm_language_defn): Likewise.
 971         (minimal_language_defn): Likewise.
 972         * d-lang.c (d_language_defn): Likewise.
 973         * f-lang.c (f_language_defn): Likewise.
 974         * go-lang.c (go_language_defn): Likewise.
 975         * language.c (unknown_language_defn): Likewise.
 976         (auto_language_defn): Likewise.
 977         * language.h (struct language_defn): Remove la_magic field.
 978         (LANG_MAGIC): Delete.
 979         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 980         * objc-lang.c (objc_language_defn): Likewise.
 981         * opencl-lang.c (opencl_language_defn): Likewise.
 982         * p-lang.c (pascal_language_defn): Likewise.
 983         * rust-lang.c (rust_language_defn): Likewise.
 984
 985 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 986
 987         * riscv-tdep.c (riscv_type_align): New function.
 988         (riscv_type_alignment): Delete.
 989         (riscv_arg_location): Use 'type_align'.
 990         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 991
 992 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 993
 994         * gdbtypes.c (type_align): A struct with no non-static fields also
 995         has alignment of 1.
 996
 997 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 998
 999         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1000         component to 0.
1001         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1002         member.
1003         (riscv_struct_info::analyse): New implementation using new
1004         analyse_inner member function.
1005         (riscv_struct_info::field_offset): New member function.
1006         (riscv_struct_info::m_offsets): New member variable.
1007         (riscv_struct_info::analyse_inner): New private member function,
1008         takes the old implementation of riscv_struct_info::analyse but
1009         extended to track field offsets.
1010         (riscv_call_arg_struct): Update the struct folding special cases
1011         to handle cases where empty C++ structs, which are non-zero
1012         length, are found.
1013         (riscv_arg_location): Initialise the length of each location, a
1014         non-zero length now indicates the location is in use.
1015         (riscv_push_dummy_call): Allow for the first location having a
1016         non-zero offset when setting up arguments.
1017         (riscv_return_value): Likewise, but for return values.
1018
1019 2019-04-11  Tom Tromey  <tromey@adacore.com>
1020
1021         * utils.c (internal_vproblem): Make "msg" const.
1022
1023 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1024
1025         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1026         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1027         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1028         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1029
1030 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1031
1032         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1033         function.
1034         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1035         of amd64_collect_native_gregset.
1036         (amd64_linux_nat_target::store_registers): Likewise.
1037
1038 2019-04-10  Tom Tromey  <tom@tromey.com>
1039
1040         * symtab.c (lookup_global_symbol_from_objfile)
1041         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1042         * objfiles.h (class separate_debug_iterator): New.
1043         (class separate_debug_range): New.
1044         (struct objfile) <separate_debug_objfiles>: New method.
1045         (objfile_separate_debug_iterate): Don't declare.
1046         * objfiles.c (separate_debug_iterator::operator++): Rename from
1047         objfile_separate_debug_iterate.
1048         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1049         iterator.
1050         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1051         iterator.
1052
1053 2019-04-10  Tom Tromey  <tom@tromey.com>
1054
1055         * symfile.c (reread_symbols): Remove old comment.
1056         * objfiles.c (free_all_objfiles): Fix a typo.
1057
1058 2019-04-10  Tom Tromey  <tom@tromey.com>
1059
1060         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1061         * minsyms.c (lookup_minimal_symbol): Use foreach.
1062         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1063         (lookup_minimal_symbol_solib_trampoline): Likewise.
1064         * symfile.c (reread_symbols): Use foreach.
1065
1066 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1067             Tom Tromey  <tromey@adacore.com>
1068
1069         PR rust/24414:
1070         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1071         (rust_lex_int_test): Change "value" to be LONGEST.
1072         (rust_lex_tests): Add test for long integer literal.
1073
1074 2019-04-09  Tom Tromey  <tromey@adacore.com>
1075
1076         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1077         to bool.
1078         (extended_remote_target::attach): Update.
1079         (remote_target::remote_notice_new_inferior): Update.
1080         (remote_target::add_current_inferior_and_thread): Update.
1081         * inferior.c (exit_inferior_1): Use "false".
1082         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1083
1084 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1085
1086         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1087         the "start" command.
1088
1089 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1090
1091         * python/py-inferior.c (infpy_thread_from_thread_handle):
1092         Adjust comments to reflect renaming of thread_from_thread_handle
1093         to thread_from_handle.  Adjust keywords.  Fix type error message.
1094         (inferior_object_methods): Add thread_from_handle.  Retain
1095         thread_from_thread_handle, but mark it as deprecated.
1096
1097 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1098
1099         * gdbthread.h (find_thread_by_handle): Revise declaration.
1100         * thread.c (find_thread_by_handle): Likewise.  Adjust
1101         implementation too.
1102         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1103         support for buffer objects as handles.
1104
1105 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1106
1107         * python/py-infthread.c (thpy_thread_handle): New function.
1108         (thread_object_methods): Register thpy_thread_handle.
1109
1110 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1111
1112         * gdbthread.h (thread_to_thread_handle): Declare.
1113         * thread.c (gdbtypes.h): Include.
1114         (thread_to_thread_handle): New function.
1115
1116         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1117         (target_thread_info_to_thread_handle): Declare.
1118         * target.c (target_thread_info_to_thread_handle): New function.
1119         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1120         * target-delegates.c: Regenerate.
1121
1122         * linux-thread-db.c (class thread_db_target): Add method
1123         thread_info_to_thread_handle.
1124         (thread_db_target::thread_info_to_thread_handle): Define.
1125         * remote.c (class remote_target): Add new method
1126         thread_info_to_thread_handle.
1127         (remote_target::thread_info_to_thread_handle): Define.
1128
1129 2019-04-08  Pedro Alves  <palves@redhat.com>
1130
1131         * common/common-exceptions.c (throw_exception): Don't create
1132         named object to throw; throw directly.
1133         (throw_it): Likewise.  Don't initialize gdb_exception::message
1134         here, with new; pass FMT and AP to the ctor instead.
1135         * common/common-exceptions.h: Include <string>.
1136         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1137         const char *, va_list)): New ctor.  Use std::make_shared.
1138         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1139         errors)): Delete.
1140         (gdb_exception_error::gdb_exception_error(enum errors, const char
1141         *, va_list)): New.
1142         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1143         Add assertion.
1144         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1145         errors)): Delete.
1146         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1147         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1148         Add assertion.
1149
1150 2019-04-08  Tom Tromey  <tom@tromey.com>
1151
1152         * valops.c (value_rtti_indirect_type): Replace throw_exception
1153         with throw.
1154         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1155         with throw.
1156         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1157         throw.
1158         * target.c (target_translate_tls_address): Replace throw_exception
1159         with throw.
1160         * stack.c (frame_apply_command_count): Replace throw_exception
1161         with throw.
1162         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1163         throw.
1164         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1165         with throw.
1166         * rs6000-tdep.c (rs6000_frame_cache)
1167         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1168         * remote.c: Replace throw_exception with throw.
1169         * record-full.c (record_full_message, record_full_wait_1)
1170         (record_full_restore): Replace throw_exception with throw.
1171         * record-btrace.c:
1172         (get_thread_current_frame_id, record_btrace_start_replaying)
1173         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1174         (cmd_record_btrace_start): Replace throw_exception with throw.
1175         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1176         throw.
1177         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1178         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1179         * linespec.c:
1180         (find_linespec_symbols): Replace throw_exception with throw.
1181         * infrun.c (displaced_step_prepare, resume): Replace
1182         throw_exception with throw.
1183         * infcmd.c (post_create_inferior): Replace throw_exception with
1184         throw.
1185         * inf-loop.c (inferior_event_handler): Replace throw_exception
1186         with throw.
1187         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1188         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1189         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1190         (get_prev_frame_always, get_frame_pc_if_available)
1191         (get_frame_address_in_block_if_available, get_frame_language):
1192         Replace throw_exception with throw.
1193         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1194         throw_exception with throw.
1195         * eval.c (fetch_subexp_value, evaluate_var_value)
1196         (evaluate_funcall, evaluate_subexp_standard): Replace
1197         throw_exception with throw.
1198         * dwarf2loc.c (call_site_find_chain)
1199         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1200         Replace throw_exception with throw.
1201         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1202         with throw.
1203         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1204         throw.
1205         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1206         * completer.c (complete_line_internal): Replace throw_exception
1207         with throw.
1208         * compile/compile-object-run.c (compile_object_run): Replace
1209         throw_exception with throw.
1210         * cli/cli-script.c (process_next_line): Replace throw_exception
1211         with throw.
1212         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1213         (btrace_enable, btrace_maint_update_pt_packets): Replace
1214         throw_exception with throw.
1215         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1216         throw_exception with throw.
1217         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1218         throw_exception with throw.
1219         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1220         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1221         * aarch64-tdep.c (aarch64_make_prologue_cache)
1222         (aarch64_make_stub_cache): Replace throw_exception with throw.
1223
1224 2019-04-08  Tom Tromey  <tom@tromey.com>
1225
1226         * common/common-exceptions.c (throw_exception): Rename from
1227         throw_exception_cxx.  Remove old copy.  Make argument const.
1228         (throw_it): Create and throw exception objects directly.
1229         * common/common-exceptions.h (throw_exception): Make argument
1230         const.
1231         (struct gdb_exception_error): Add constructor.
1232         (struct gdb_exception_quit): Add constructor.
1233
1234 2019-04-08  Tom Tromey  <tom@tromey.com>
1235
1236         * common/common-exceptions.h (exception_rethrow): Don't declare.
1237         (TRY_SJLJ): Update comment.
1238         (TRY, CATCH, END_CATCH): Remove.
1239         * common/common-exceptions.c (exception_rethrow): Remove.
1240
1241 2019-04-08  Tom Tromey  <tom@tromey.com>
1242
1243         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1244         Remove.
1245         (gdb_exception_error): Rename from
1246         gdb_exception_RETURN_MASK_ERROR.
1247         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1248         (gdb_quit_bad_alloc): Update.
1249         * aarch64-tdep.c: Update.
1250         * ada-lang.c: Update.
1251         * ada-typeprint.c: Update.
1252         * ada-valprint.c: Update.
1253         * amd64-tdep.c: Update.
1254         * arch-utils.c: Update.
1255         * break-catch-throw.c: Update.
1256         * breakpoint.c: Update.
1257         * btrace.c: Update.
1258         * c-varobj.c: Update.
1259         * cli/cli-cmds.c: Update.
1260         * cli/cli-interp.c: Update.
1261         * cli/cli-script.c: Update.
1262         * common/common-exceptions.c: Update.
1263         * common/new-op.c: Update.
1264         * common/selftest.c: Update.
1265         * compile/compile-c-symbols.c: Update.
1266         * compile/compile-cplus-symbols.c: Update.
1267         * compile/compile-object-load.c: Update.
1268         * compile/compile-object-run.c: Update.
1269         * completer.c: Update.
1270         * corelow.c: Update.
1271         * cp-abi.c: Update.
1272         * cp-support.c: Update.
1273         * cp-valprint.c: Update.
1274         * darwin-nat.c: Update.
1275         * disasm-selftests.c: Update.
1276         * dtrace-probe.c: Update.
1277         * dwarf-index-cache.c: Update.
1278         * dwarf-index-write.c: Update.
1279         * dwarf2-frame-tailcall.c: Update.
1280         * dwarf2-frame.c: Update.
1281         * dwarf2loc.c: Update.
1282         * dwarf2read.c: Update.
1283         * eval.c: Update.
1284         * event-loop.c: Update.
1285         * event-top.c: Update.
1286         * exec.c: Update.
1287         * f-valprint.c: Update.
1288         * fbsd-tdep.c: Update.
1289         * frame-unwind.c: Update.
1290         * frame.c: Update.
1291         * gdbtypes.c: Update.
1292         * gnu-v3-abi.c: Update.
1293         * guile/guile-internal.h: Update.
1294         * guile/scm-block.c: Update.
1295         * guile/scm-breakpoint.c: Update.
1296         * guile/scm-cmd.c: Update.
1297         * guile/scm-disasm.c: Update.
1298         * guile/scm-frame.c: Update.
1299         * guile/scm-lazy-string.c: Update.
1300         * guile/scm-math.c: Update.
1301         * guile/scm-param.c: Update.
1302         * guile/scm-ports.c: Update.
1303         * guile/scm-pretty-print.c: Update.
1304         * guile/scm-symbol.c: Update.
1305         * guile/scm-symtab.c: Update.
1306         * guile/scm-type.c: Update.
1307         * guile/scm-value.c: Update.
1308         * i386-linux-tdep.c: Update.
1309         * i386-tdep.c: Update.
1310         * inf-loop.c: Update.
1311         * infcall.c: Update.
1312         * infcmd.c: Update.
1313         * infrun.c: Update.
1314         * jit.c: Update.
1315         * language.c: Update.
1316         * linespec.c: Update.
1317         * linux-fork.c: Update.
1318         * linux-nat.c: Update.
1319         * linux-tdep.c: Update.
1320         * linux-thread-db.c: Update.
1321         * main.c: Update.
1322         * mi/mi-cmd-break.c: Update.
1323         * mi/mi-cmd-stack.c: Update.
1324         * mi/mi-interp.c: Update.
1325         * mi/mi-main.c: Update.
1326         * objc-lang.c: Update.
1327         * p-valprint.c: Update.
1328         * parse.c: Update.
1329         * ppc-linux-tdep.c: Update.
1330         * printcmd.c: Update.
1331         * python/py-arch.c: Update.
1332         * python/py-breakpoint.c: Update.
1333         * python/py-cmd.c: Update.
1334         * python/py-finishbreakpoint.c: Update.
1335         * python/py-frame.c: Update.
1336         * python/py-framefilter.c: Update.
1337         * python/py-gdb-readline.c: Update.
1338         * python/py-inferior.c: Update.
1339         * python/py-infthread.c: Update.
1340         * python/py-lazy-string.c: Update.
1341         * python/py-linetable.c: Update.
1342         * python/py-objfile.c: Update.
1343         * python/py-param.c: Update.
1344         * python/py-prettyprint.c: Update.
1345         * python/py-progspace.c: Update.
1346         * python/py-record-btrace.c: Update.
1347         * python/py-record.c: Update.
1348         * python/py-symbol.c: Update.
1349         * python/py-type.c: Update.
1350         * python/py-unwind.c: Update.
1351         * python/py-utils.c: Update.
1352         * python/py-value.c: Update.
1353         * python/python.c: Update.
1354         * record-btrace.c: Update.
1355         * record-full.c: Update.
1356         * remote-fileio.c: Update.
1357         * remote.c: Update.
1358         * riscv-tdep.c: Update.
1359         * rs6000-aix-tdep.c: Update.
1360         * rs6000-tdep.c: Update.
1361         * rust-exp.y: Update.
1362         * rust-lang.c: Update.
1363         * s390-tdep.c: Update.
1364         * selftest-arch.c: Update.
1365         * solib-dsbt.c: Update.
1366         * solib-frv.c: Update.
1367         * solib-spu.c: Update.
1368         * solib-svr4.c: Update.
1369         * solib.c: Update.
1370         * sparc64-linux-tdep.c: Update.
1371         * stack.c: Update.
1372         * symfile-mem.c: Update.
1373         * symmisc.c: Update.
1374         * target.c: Update.
1375         * thread.c: Update.
1376         * top.c: Update.
1377         * tracefile-tfile.c: Update.
1378         * tui/tui.c: Update.
1379         * typeprint.c: Update.
1380         * unittests/cli-utils-selftests.c: Update.
1381         * unittests/parse-connection-spec-selftests.c: Update.
1382         * valops.c: Update.
1383         * valprint.c: Update.
1384         * value.c: Update.
1385         * varobj.c: Update.
1386         * windows-nat.c: Update.
1387         * x86-linux-nat.c: Update.
1388         * xml-support.c: Update.
1389
1390 2019-04-08  Tom Tromey  <tom@tromey.com>
1391
1392         * xml-support.c: Use C++ exception handling.
1393         * x86-linux-nat.c: Use C++ exception handling.
1394         * windows-nat.c: Use C++ exception handling.
1395         * varobj.c: Use C++ exception handling.
1396         * value.c: Use C++ exception handling.
1397         * valprint.c: Use C++ exception handling.
1398         * valops.c: Use C++ exception handling.
1399         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1400         handling.
1401         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1402         * typeprint.c: Use C++ exception handling.
1403         * tui/tui.c: Use C++ exception handling.
1404         * tracefile-tfile.c: Use C++ exception handling.
1405         * top.c: Use C++ exception handling.
1406         * thread.c: Use C++ exception handling.
1407         * target.c: Use C++ exception handling.
1408         * symmisc.c: Use C++ exception handling.
1409         * symfile-mem.c: Use C++ exception handling.
1410         * stack.c: Use C++ exception handling.
1411         * sparc64-linux-tdep.c: Use C++ exception handling.
1412         * solib.c: Use C++ exception handling.
1413         * solib-svr4.c: Use C++ exception handling.
1414         * solib-spu.c: Use C++ exception handling.
1415         * solib-frv.c: Use C++ exception handling.
1416         * solib-dsbt.c: Use C++ exception handling.
1417         * selftest-arch.c: Use C++ exception handling.
1418         * s390-tdep.c: Use C++ exception handling.
1419         * rust-lang.c: Use C++ exception handling.
1420         * rust-exp.y: Use C++ exception handling.
1421         * rs6000-tdep.c: Use C++ exception handling.
1422         * rs6000-aix-tdep.c: Use C++ exception handling.
1423         * riscv-tdep.c: Use C++ exception handling.
1424         * remote.c: Use C++ exception handling.
1425         * remote-fileio.c: Use C++ exception handling.
1426         * record-full.c: Use C++ exception handling.
1427         * record-btrace.c: Use C++ exception handling.
1428         * python/python.c: Use C++ exception handling.
1429         * python/py-value.c: Use C++ exception handling.
1430         * python/py-utils.c: Use C++ exception handling.
1431         * python/py-unwind.c: Use C++ exception handling.
1432         * python/py-type.c: Use C++ exception handling.
1433         * python/py-symbol.c: Use C++ exception handling.
1434         * python/py-record.c: Use C++ exception handling.
1435         * python/py-record-btrace.c: Use C++ exception handling.
1436         * python/py-progspace.c: Use C++ exception handling.
1437         * python/py-prettyprint.c: Use C++ exception handling.
1438         * python/py-param.c: Use C++ exception handling.
1439         * python/py-objfile.c: Use C++ exception handling.
1440         * python/py-linetable.c: Use C++ exception handling.
1441         * python/py-lazy-string.c: Use C++ exception handling.
1442         * python/py-infthread.c: Use C++ exception handling.
1443         * python/py-inferior.c: Use C++ exception handling.
1444         * python/py-gdb-readline.c: Use C++ exception handling.
1445         * python/py-framefilter.c: Use C++ exception handling.
1446         * python/py-frame.c: Use C++ exception handling.
1447         * python/py-finishbreakpoint.c: Use C++ exception handling.
1448         * python/py-cmd.c: Use C++ exception handling.
1449         * python/py-breakpoint.c: Use C++ exception handling.
1450         * python/py-arch.c: Use C++ exception handling.
1451         * printcmd.c: Use C++ exception handling.
1452         * ppc-linux-tdep.c: Use C++ exception handling.
1453         * parse.c: Use C++ exception handling.
1454         * p-valprint.c: Use C++ exception handling.
1455         * objc-lang.c: Use C++ exception handling.
1456         * mi/mi-main.c: Use C++ exception handling.
1457         * mi/mi-interp.c: Use C++ exception handling.
1458         * mi/mi-cmd-stack.c: Use C++ exception handling.
1459         * mi/mi-cmd-break.c: Use C++ exception handling.
1460         * main.c: Use C++ exception handling.
1461         * linux-thread-db.c: Use C++ exception handling.
1462         * linux-tdep.c: Use C++ exception handling.
1463         * linux-nat.c: Use C++ exception handling.
1464         * linux-fork.c: Use C++ exception handling.
1465         * linespec.c: Use C++ exception handling.
1466         * language.c: Use C++ exception handling.
1467         * jit.c: Use C++ exception handling.
1468         * infrun.c: Use C++ exception handling.
1469         * infcmd.c: Use C++ exception handling.
1470         * infcall.c: Use C++ exception handling.
1471         * inf-loop.c: Use C++ exception handling.
1472         * i386-tdep.c: Use C++ exception handling.
1473         * i386-linux-tdep.c: Use C++ exception handling.
1474         * guile/scm-value.c: Use C++ exception handling.
1475         * guile/scm-type.c: Use C++ exception handling.
1476         * guile/scm-symtab.c: Use C++ exception handling.
1477         * guile/scm-symbol.c: Use C++ exception handling.
1478         * guile/scm-pretty-print.c: Use C++ exception handling.
1479         * guile/scm-ports.c: Use C++ exception handling.
1480         * guile/scm-param.c: Use C++ exception handling.
1481         * guile/scm-math.c: Use C++ exception handling.
1482         * guile/scm-lazy-string.c: Use C++ exception handling.
1483         * guile/scm-frame.c: Use C++ exception handling.
1484         * guile/scm-disasm.c: Use C++ exception handling.
1485         * guile/scm-cmd.c: Use C++ exception handling.
1486         * guile/scm-breakpoint.c: Use C++ exception handling.
1487         * guile/scm-block.c: Use C++ exception handling.
1488         * guile/guile-internal.h: Use C++ exception handling.
1489         * gnu-v3-abi.c: Use C++ exception handling.
1490         * gdbtypes.c: Use C++ exception handling.
1491         * frame.c: Use C++ exception handling.
1492         * frame-unwind.c: Use C++ exception handling.
1493         * fbsd-tdep.c: Use C++ exception handling.
1494         * f-valprint.c: Use C++ exception handling.
1495         * exec.c: Use C++ exception handling.
1496         * event-top.c: Use C++ exception handling.
1497         * event-loop.c: Use C++ exception handling.
1498         * eval.c: Use C++ exception handling.
1499         * dwarf2read.c: Use C++ exception handling.
1500         * dwarf2loc.c: Use C++ exception handling.
1501         * dwarf2-frame.c: Use C++ exception handling.
1502         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1503         * dwarf-index-write.c: Use C++ exception handling.
1504         * dwarf-index-cache.c: Use C++ exception handling.
1505         * dtrace-probe.c: Use C++ exception handling.
1506         * disasm-selftests.c: Use C++ exception handling.
1507         * darwin-nat.c: Use C++ exception handling.
1508         * cp-valprint.c: Use C++ exception handling.
1509         * cp-support.c: Use C++ exception handling.
1510         * cp-abi.c: Use C++ exception handling.
1511         * corelow.c: Use C++ exception handling.
1512         * completer.c: Use C++ exception handling.
1513         * compile/compile-object-run.c: Use C++ exception handling.
1514         * compile/compile-object-load.c: Use C++ exception handling.
1515         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1516         * compile/compile-c-symbols.c: Use C++ exception handling.
1517         * common/selftest.c: Use C++ exception handling.
1518         * common/new-op.c: Use C++ exception handling.
1519         * cli/cli-script.c: Use C++ exception handling.
1520         * cli/cli-interp.c: Use C++ exception handling.
1521         * cli/cli-cmds.c: Use C++ exception handling.
1522         * c-varobj.c: Use C++ exception handling.
1523         * btrace.c: Use C++ exception handling.
1524         * breakpoint.c: Use C++ exception handling.
1525         * break-catch-throw.c: Use C++ exception handling.
1526         * arch-utils.c: Use C++ exception handling.
1527         * amd64-tdep.c: Use C++ exception handling.
1528         * ada-valprint.c: Use C++ exception handling.
1529         * ada-typeprint.c: Use C++ exception handling.
1530         * ada-lang.c: Use C++ exception handling.
1531         * aarch64-tdep.c: Use C++ exception handling.
1532
1533 2019-04-08  Tom Tromey  <tom@tromey.com>
1534
1535         * xml-support.c (gdb_xml_parser::parse): Update.
1536         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1537         * value.c (show_convenience): Update.
1538         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1539         (test_parse_flags_qcs): Update.
1540         * thread.c (thr_try_catch_cmd): Update.
1541         * target.c (target_translate_tls_address): Update.
1542         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1543         (info_frame_command_core, frame_apply_command_count): Update.
1544         * rust-exp.y (rust_lex_exception_test): Update.
1545         * riscv-tdep.c (riscv_print_one_register_info): Update.
1546         * remote.c (remote_target::enable_btrace): Update.
1547         * record-btrace.c (record_btrace_enable_warn): Update.
1548         * python/py-utils.c (gdbpy_convert_exception): Update.
1549         * printcmd.c (do_one_display, print_variable_and_value): Update.
1550         * mi/mi-main.c (mi_print_exception): Update.
1551         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1552         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1553         * linux-nat.c (linux_nat_target::attach): Update.
1554         * linux-fork.c (class scoped_switch_fork_info): Update.
1555         * infrun.c (displaced_step_prepare): Update.
1556         * infcall.c (call_function_by_hand_dummy): Update.
1557         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1558         * gnu-v3-abi.c (print_one_vtable): Update.
1559         * frame.c (get_prev_frame_always): Update.
1560         * f-valprint.c (info_common_command_for_block): Update.
1561         * exec.c (try_open_exec_file): Update.
1562         * exceptions.c (print_exception, exception_print)
1563         (exception_fprintf, exception_print_same): Update.
1564         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1565         * dwarf-index-cache.c (index_cache::store)
1566         (index_cache::lookup_gdb_index): Update.
1567         * darwin-nat.c (maybe_cache_shell): Update.
1568         * cp-valprint.c (cp_print_value_fields): Update.
1569         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1570         (gcc_cplus_symbol_address): Update.
1571         * compile/compile-c-symbols.c (gcc_convert_symbol)
1572         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1573         * common/selftest.c: Update.
1574         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1575         a std::string.
1576         (exception_try_scope_entry, exception_try_scope_exit): Don't
1577         declare.
1578         (struct exception_try_scope): Remove.
1579         (TRY): Don't use exception_try_scope.
1580         (struct gdb_exception): Add constructor, operator=.
1581         <what>: New method.
1582         (struct gdb_exception_RETURN_MASK_ALL)
1583         (struct gdb_exception_RETURN_MASK_ERROR)
1584         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1585         (struct gdb_quit_bad_alloc): Update.
1586         * common/common-exceptions.c (exception_none): Change
1587         initializer.
1588         (struct catcher) <state, exception>: Initialize inline.
1589         <prev>: Remove member.
1590         (current_catcher): Remove.
1591         (catchers): New global.
1592         (exceptions_state_mc_init): Simplify.
1593         (catcher_pop): Remove.
1594         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1595         (try_scope_depth, exception_try_scope_entry)
1596         (exception_try_scope_exit): Remove.
1597         (throw_exception_sjlj): Update.
1598         (exception_messages, exception_messages_size): Remove.
1599         (throw_it): Simplify.
1600         (gdb_exception_sliced_copy): Remove.
1601         (throw_exception_cxx): Update.
1602         * cli/cli-script.c (script_from_file): Update.
1603         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1604         Update.
1605         * ada-valprint.c (ada_val_print): Update.
1606         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1607         (create_excep_cond_exprs): Update.
1608
1609 2019-04-08  Tom Tromey  <tom@tromey.com>
1610
1611         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1612         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1613         (TRY, CATCH, END_CATCH): Remove some definitions.
1614         * common/common-exceptions.c: Don't use GDB_XCPT.
1615         (catcher_list_size): Remove.
1616         (throw_exception, throw_it): Simplify.
1617
1618 2019-04-05  Tom Tromey  <tom@tromey.com>
1619
1620         Revert the header-sorting patch.
1621         * ft32-tdep.c: Revert.
1622         * frv-tdep.c: Revert.
1623         * frv-linux-tdep.c: Revert.
1624         * frame.c: Revert.
1625         * frame-unwind.c: Revert.
1626         * frame-base.c: Revert.
1627         * fork-child.c: Revert.
1628         * findvar.c: Revert.
1629         * findcmd.c: Revert.
1630         * filesystem.c: Revert.
1631         * filename-seen-cache.h: Revert.
1632         * filename-seen-cache.c: Revert.
1633         * fbsd-tdep.c: Revert.
1634         * fbsd-nat.h: Revert.
1635         * fbsd-nat.c: Revert.
1636         * f-valprint.c: Revert.
1637         * f-typeprint.c: Revert.
1638         * f-lang.c: Revert.
1639         * extension.h: Revert.
1640         * extension.c: Revert.
1641         * extension-priv.h: Revert.
1642         * expprint.c: Revert.
1643         * exec.h: Revert.
1644         * exec.c: Revert.
1645         * exceptions.c: Revert.
1646         * event-top.c: Revert.
1647         * event-loop.c: Revert.
1648         * eval.c: Revert.
1649         * elfread.c: Revert.
1650         * dwarf2read.h: Revert.
1651         * dwarf2read.c: Revert.
1652         * dwarf2loc.c: Revert.
1653         * dwarf2expr.h: Revert.
1654         * dwarf2expr.c: Revert.
1655         * dwarf2-frame.c: Revert.
1656         * dwarf2-frame-tailcall.c: Revert.
1657         * dwarf-index-write.h: Revert.
1658         * dwarf-index-write.c: Revert.
1659         * dwarf-index-common.c: Revert.
1660         * dwarf-index-cache.h: Revert.
1661         * dwarf-index-cache.c: Revert.
1662         * dummy-frame.c: Revert.
1663         * dtrace-probe.c: Revert.
1664         * disasm.h: Revert.
1665         * disasm.c: Revert.
1666         * disasm-selftests.c: Revert.
1667         * dictionary.c: Revert.
1668         * dicos-tdep.c: Revert.
1669         * demangle.c: Revert.
1670         * dcache.h: Revert.
1671         * dcache.c: Revert.
1672         * darwin-nat.h: Revert.
1673         * darwin-nat.c: Revert.
1674         * darwin-nat-info.c: Revert.
1675         * d-valprint.c: Revert.
1676         * d-namespace.c: Revert.
1677         * d-lang.c: Revert.
1678         * ctf.c: Revert.
1679         * csky-tdep.c: Revert.
1680         * csky-linux-tdep.c: Revert.
1681         * cris-tdep.c: Revert.
1682         * cris-linux-tdep.c: Revert.
1683         * cp-valprint.c: Revert.
1684         * cp-support.c: Revert.
1685         * cp-namespace.c: Revert.
1686         * cp-abi.c: Revert.
1687         * corelow.c: Revert.
1688         * corefile.c: Revert.
1689         * continuations.c: Revert.
1690         * completer.h: Revert.
1691         * completer.c: Revert.
1692         * complaints.c: Revert.
1693         * coffread.c: Revert.
1694         * coff-pe-read.c: Revert.
1695         * cli-out.h: Revert.
1696         * cli-out.c: Revert.
1697         * charset.c: Revert.
1698         * c-varobj.c: Revert.
1699         * c-valprint.c: Revert.
1700         * c-typeprint.c: Revert.
1701         * c-lang.c: Revert.
1702         * buildsym.c: Revert.
1703         * buildsym-legacy.c: Revert.
1704         * build-id.h: Revert.
1705         * build-id.c: Revert.
1706         * btrace.c: Revert.
1707         * bsd-uthread.c: Revert.
1708         * breakpoint.h: Revert.
1709         * breakpoint.c: Revert.
1710         * break-catch-throw.c: Revert.
1711         * break-catch-syscall.c: Revert.
1712         * break-catch-sig.c: Revert.
1713         * blockframe.c: Revert.
1714         * block.c: Revert.
1715         * bfin-tdep.c: Revert.
1716         * bfin-linux-tdep.c: Revert.
1717         * bfd-target.c: Revert.
1718         * bcache.c: Revert.
1719         * ax-general.c: Revert.
1720         * ax-gdb.h: Revert.
1721         * ax-gdb.c: Revert.
1722         * avr-tdep.c: Revert.
1723         * auxv.c: Revert.
1724         * auto-load.c: Revert.
1725         * arm-wince-tdep.c: Revert.
1726         * arm-tdep.c: Revert.
1727         * arm-symbian-tdep.c: Revert.
1728         * arm-pikeos-tdep.c: Revert.
1729         * arm-obsd-tdep.c: Revert.
1730         * arm-nbsd-tdep.c: Revert.
1731         * arm-nbsd-nat.c: Revert.
1732         * arm-linux-tdep.c: Revert.
1733         * arm-linux-nat.c: Revert.
1734         * arm-fbsd-tdep.c: Revert.
1735         * arm-fbsd-nat.c: Revert.
1736         * arm-bsd-tdep.c: Revert.
1737         * arch-utils.c: Revert.
1738         * arc-tdep.c: Revert.
1739         * arc-newlib-tdep.c: Revert.
1740         * annotate.h: Revert.
1741         * annotate.c: Revert.
1742         * amd64-windows-tdep.c: Revert.
1743         * amd64-windows-nat.c: Revert.
1744         * amd64-tdep.c: Revert.
1745         * amd64-sol2-tdep.c: Revert.
1746         * amd64-obsd-tdep.c: Revert.
1747         * amd64-obsd-nat.c: Revert.
1748         * amd64-nbsd-tdep.c: Revert.
1749         * amd64-nbsd-nat.c: Revert.
1750         * amd64-nat.c: Revert.
1751         * amd64-linux-tdep.c: Revert.
1752         * amd64-linux-nat.c: Revert.
1753         * amd64-fbsd-tdep.c: Revert.
1754         * amd64-fbsd-nat.c: Revert.
1755         * amd64-dicos-tdep.c: Revert.
1756         * amd64-darwin-tdep.c: Revert.
1757         * amd64-bsd-nat.c: Revert.
1758         * alpha-tdep.c: Revert.
1759         * alpha-obsd-tdep.c: Revert.
1760         * alpha-nbsd-tdep.c: Revert.
1761         * alpha-mdebug-tdep.c: Revert.
1762         * alpha-linux-tdep.c: Revert.
1763         * alpha-linux-nat.c: Revert.
1764         * alpha-bsd-tdep.c: Revert.
1765         * alpha-bsd-nat.c: Revert.
1766         * aix-thread.c: Revert.
1767         * agent.c: Revert.
1768         * addrmap.c: Revert.
1769         * ada-varobj.c: Revert.
1770         * ada-valprint.c: Revert.
1771         * ada-typeprint.c: Revert.
1772         * ada-tasks.c: Revert.
1773         * ada-lang.c: Revert.
1774         * aarch64-tdep.c: Revert.
1775         * aarch64-ravenscar-thread.c: Revert.
1776         * aarch64-newlib-tdep.c: Revert.
1777         * aarch64-linux-tdep.c: Revert.
1778         * aarch64-linux-nat.c: Revert.
1779         * aarch64-fbsd-tdep.c: Revert.
1780         * aarch64-fbsd-nat.c: Revert.
1781         * aarch32-linux-nat.c: Revert.
1782
1783 2019-04-05  Tom Tromey  <tom@tromey.com>
1784
1785         * ft32-tdep.c: Sort headers.
1786         * frv-tdep.c: Sort headers.
1787         * frv-linux-tdep.c: Sort headers.
1788         * frame.c: Sort headers.
1789         * frame-unwind.c: Sort headers.
1790         * frame-base.c: Sort headers.
1791         * fork-child.c: Sort headers.
1792         * findvar.c: Sort headers.
1793         * findcmd.c: Sort headers.
1794         * filesystem.c: Sort headers.
1795         * filename-seen-cache.h: Sort headers.
1796         * filename-seen-cache.c: Sort headers.
1797         * fbsd-tdep.c: Sort headers.
1798         * fbsd-nat.h: Sort headers.
1799         * fbsd-nat.c: Sort headers.
1800         * f-valprint.c: Sort headers.
1801         * f-typeprint.c: Sort headers.
1802         * f-lang.c: Sort headers.
1803         * extension.h: Sort headers.
1804         * extension.c: Sort headers.
1805         * extension-priv.h: Sort headers.
1806         * expprint.c: Sort headers.
1807         * exec.h: Sort headers.
1808         * exec.c: Sort headers.
1809         * exceptions.c: Sort headers.
1810         * event-top.c: Sort headers.
1811         * event-loop.c: Sort headers.
1812         * eval.c: Sort headers.
1813         * elfread.c: Sort headers.
1814         * dwarf2read.h: Sort headers.
1815         * dwarf2read.c: Sort headers.
1816         * dwarf2loc.c: Sort headers.
1817         * dwarf2expr.h: Sort headers.
1818         * dwarf2expr.c: Sort headers.
1819         * dwarf2-frame.c: Sort headers.
1820         * dwarf2-frame-tailcall.c: Sort headers.
1821         * dwarf-index-write.h: Sort headers.
1822         * dwarf-index-write.c: Sort headers.
1823         * dwarf-index-common.c: Sort headers.
1824         * dwarf-index-cache.h: Sort headers.
1825         * dwarf-index-cache.c: Sort headers.
1826         * dummy-frame.c: Sort headers.
1827         * dtrace-probe.c: Sort headers.
1828         * disasm.h: Sort headers.
1829         * disasm.c: Sort headers.
1830         * disasm-selftests.c: Sort headers.
1831         * dictionary.c: Sort headers.
1832         * dicos-tdep.c: Sort headers.
1833         * demangle.c: Sort headers.
1834         * dcache.h: Sort headers.
1835         * dcache.c: Sort headers.
1836         * darwin-nat.h: Sort headers.
1837         * darwin-nat.c: Sort headers.
1838         * darwin-nat-info.c: Sort headers.
1839         * d-valprint.c: Sort headers.
1840         * d-namespace.c: Sort headers.
1841         * d-lang.c: Sort headers.
1842         * ctf.c: Sort headers.
1843         * csky-tdep.c: Sort headers.
1844         * csky-linux-tdep.c: Sort headers.
1845         * cris-tdep.c: Sort headers.
1846         * cris-linux-tdep.c: Sort headers.
1847         * cp-valprint.c: Sort headers.
1848         * cp-support.c: Sort headers.
1849         * cp-namespace.c: Sort headers.
1850         * cp-abi.c: Sort headers.
1851         * corelow.c: Sort headers.
1852         * corefile.c: Sort headers.
1853         * continuations.c: Sort headers.
1854         * completer.h: Sort headers.
1855         * completer.c: Sort headers.
1856         * complaints.c: Sort headers.
1857         * coffread.c: Sort headers.
1858         * coff-pe-read.c: Sort headers.
1859         * cli-out.h: Sort headers.
1860         * cli-out.c: Sort headers.
1861         * charset.c: Sort headers.
1862         * c-varobj.c: Sort headers.
1863         * c-valprint.c: Sort headers.
1864         * c-typeprint.c: Sort headers.
1865         * c-lang.c: Sort headers.
1866         * buildsym.c: Sort headers.
1867         * buildsym-legacy.c: Sort headers.
1868         * build-id.h: Sort headers.
1869         * build-id.c: Sort headers.
1870         * btrace.c: Sort headers.
1871         * bsd-uthread.c: Sort headers.
1872         * breakpoint.h: Sort headers.
1873         * breakpoint.c: Sort headers.
1874         * break-catch-throw.c: Sort headers.
1875         * break-catch-syscall.c: Sort headers.
1876         * break-catch-sig.c: Sort headers.
1877         * blockframe.c: Sort headers.
1878         * block.c: Sort headers.
1879         * bfin-tdep.c: Sort headers.
1880         * bfin-linux-tdep.c: Sort headers.
1881         * bfd-target.c: Sort headers.
1882         * bcache.c: Sort headers.
1883         * ax-general.c: Sort headers.
1884         * ax-gdb.h: Sort headers.
1885         * ax-gdb.c: Sort headers.
1886         * avr-tdep.c: Sort headers.
1887         * auxv.c: Sort headers.
1888         * auto-load.c: Sort headers.
1889         * arm-wince-tdep.c: Sort headers.
1890         * arm-tdep.c: Sort headers.
1891         * arm-symbian-tdep.c: Sort headers.
1892         * arm-pikeos-tdep.c: Sort headers.
1893         * arm-obsd-tdep.c: Sort headers.
1894         * arm-nbsd-tdep.c: Sort headers.
1895         * arm-nbsd-nat.c: Sort headers.
1896         * arm-linux-tdep.c: Sort headers.
1897         * arm-linux-nat.c: Sort headers.
1898         * arm-fbsd-tdep.c: Sort headers.
1899         * arm-fbsd-nat.c: Sort headers.
1900         * arm-bsd-tdep.c: Sort headers.
1901         * arch-utils.c: Sort headers.
1902         * arc-tdep.c: Sort headers.
1903         * arc-newlib-tdep.c: Sort headers.
1904         * annotate.h: Sort headers.
1905         * annotate.c: Sort headers.
1906         * amd64-windows-tdep.c: Sort headers.
1907         * amd64-windows-nat.c: Sort headers.
1908         * amd64-tdep.c: Sort headers.
1909         * amd64-sol2-tdep.c: Sort headers.
1910         * amd64-obsd-tdep.c: Sort headers.
1911         * amd64-obsd-nat.c: Sort headers.
1912         * amd64-nbsd-tdep.c: Sort headers.
1913         * amd64-nbsd-nat.c: Sort headers.
1914         * amd64-nat.c: Sort headers.
1915         * amd64-linux-tdep.c: Sort headers.
1916         * amd64-linux-nat.c: Sort headers.
1917         * amd64-fbsd-tdep.c: Sort headers.
1918         * amd64-fbsd-nat.c: Sort headers.
1919         * amd64-dicos-tdep.c: Sort headers.
1920         * amd64-darwin-tdep.c: Sort headers.
1921         * amd64-bsd-nat.c: Sort headers.
1922         * alpha-tdep.c: Sort headers.
1923         * alpha-obsd-tdep.c: Sort headers.
1924         * alpha-nbsd-tdep.c: Sort headers.
1925         * alpha-mdebug-tdep.c: Sort headers.
1926         * alpha-linux-tdep.c: Sort headers.
1927         * alpha-linux-nat.c: Sort headers.
1928         * alpha-bsd-tdep.c: Sort headers.
1929         * alpha-bsd-nat.c: Sort headers.
1930         * aix-thread.c: Sort headers.
1931         * agent.c: Sort headers.
1932         * addrmap.c: Sort headers.
1933         * ada-varobj.c: Sort headers.
1934         * ada-valprint.c: Sort headers.
1935         * ada-typeprint.c: Sort headers.
1936         * ada-tasks.c: Sort headers.
1937         * ada-lang.c: Sort headers.
1938         * aarch64-tdep.c: Sort headers.
1939         * aarch64-ravenscar-thread.c: Sort headers.
1940         * aarch64-newlib-tdep.c: Sort headers.
1941         * aarch64-linux-tdep.c: Sort headers.
1942         * aarch64-linux-nat.c: Sort headers.
1943         * aarch64-fbsd-tdep.c: Sort headers.
1944         * aarch64-fbsd-nat.c: Sort headers.
1945         * aarch32-linux-nat.c: Sort headers.
1946
1947 2019-04-04  Tom Tromey  <tom@tromey.com>
1948
1949         * varobj.c (varobj_create): Update.
1950         * rust-exp.y (struct rust_parser) <update_innermost_block,
1951         lookup_symbol>: New methods.
1952         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1953         Rename.
1954         (rust_parser::rust_lookup_type)
1955         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1956         * printcmd.c (display_command, do_one_display): Update.
1957         * parser-defs.h (struct parser_state) <parser_state>: Add
1958         "tracker" parameter.
1959         (block_tracker): New member.
1960         (class innermost_block_tracker) <innermost_block_tracker>: Add
1961         "types" parameter.
1962         <reset>: Remove method.
1963         (innermost_block): Don't declare.
1964         (null_post_parser): Update.
1965         * parse.c (innermost_block): Remove global.
1966         (write_dollar_variable): Update.
1967         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1968         Remove "tracker_types" parameter.
1969         (parse_expression): Add "tracker" parameter.
1970         (parse_expression_for_completion): Update.
1971         (null_post_parser): Add "tracker" parameter.
1972         * p-exp.y: Update rules.
1973         * m2-exp.y: Update rules.
1974         * language.h (struct language_defn) <la_post_parser>: Add
1975         "tracker" parameter.
1976         * go-exp.y: Update rules.
1977         * f-exp.y: Update rules.
1978         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1979         parameter.
1980         * d-exp.y: Update rules.
1981         * c-exp.y: Update rules.
1982         * breakpoint.c (set_breakpoint_condition): Create an
1983         innermost_block_tracker.
1984         (watch_command_1): Likewise.
1985         * ada-lang.c (resolve): Add "tracker" parameter.
1986         (resolve_subexp): Likewise.
1987         * ada-exp.y (write_var_from_sym): Update.
1988
1989 2019-04-04  Tom Tromey  <tom@tromey.com>
1990
1991         * type-stack.h: New file.
1992         * type-stack.c: New file.
1993         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1994         type-stack.h.
1995         (insert_into_type_stack, insert_type, push_type, push_type_int)
1996         (insert_type_address_space, pop_type, pop_type_int)
1997         (pop_typelist, pop_type_stack, append_type_stack)
1998         (push_type_stack, get_type_stack, push_typelist)
1999         (follow_type_instance_flags, follow_types): Don't declare.
2000         * parse.c (type_stack): Remove global.
2001         (parse_exp_in_context): Update.
2002         (insert_into_type_stack, insert_type, push_type, push_type_int)
2003         (insert_type_address_space, pop_type, pop_type_int)
2004         (pop_typelist, pop_type_stack, append_type_stack)
2005         (push_type_stack, get_type_stack, push_typelist)
2006         (follow_type_instance_flags, follow_types): Remove (moved to
2007         type-stack.c).
2008         * f-exp.y (type_stack): New global.
2009         Update rules.
2010         (push_kind_type, f_parse): Update.
2011         * d-exp.y (type_stack): New global.
2012         Update rules.
2013         (d_parse): Update.
2014         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2015         Update rules.
2016         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2017         (HFILES_NO_SRCDIR): Add type-stack.h.
2018
2019 2019-04-04  Tom Tromey  <tom@tromey.com>
2020
2021         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2022         (rust_parser::convert_ast_to_expression, rust_parse)
2023         (rust_lex_test_completion, rust_lex_tests): Update.
2024         * parser-defs.h (struct expr_completion_state): New.
2025         (struct parser_state) <parser_state>: Add completion parameter.
2026         <mark_struct_expression, mark_completion_tag>: New methods.
2027         <parse_completion, m_completion_state>: New members.
2028         (prefixify_expression, null_post_parser): Update.
2029         (mark_struct_expression, mark_completion_tag): Don't declare.
2030         * parse.c (parse_completion, expout_last_struct)
2031         (expout_tag_completion_type, expout_completion_name): Remove
2032         globals.
2033         (parser_state::mark_struct_expression)
2034         (parser_state::mark_completion_tag): Now methods.
2035         (prefixify_expression): Add last_struct parameter.
2036         (prefixify_subexp): Likewise.
2037         (parse_exp_1): Update.
2038         (parse_exp_in_context): Add cstate parameter.  Update.
2039         (parse_expression_for_completion): Create an
2040         expr_completion_state.
2041         (null_post_parser): Add "completion" parameter.
2042         * p-exp.y: Update rules.
2043         (yylex): Update.
2044         * language.h (struct language_defn) <la_post_parser>: Add
2045         "completing" parameter.
2046         * go-exp.y: Update rules.
2047         (lex_one_token): Update.
2048         * expression.h (parse_completion): Don't declare.
2049         * d-exp.y: Update rules.
2050         (lex_one_token): Update rules.
2051         * c-exp.y: Update rules.
2052         (lex_one_token): Update.
2053         * ada-lang.c (resolve): Add "parse_completion" parameter.
2054         (resolve_subexp): Likewise.
2055         (ada_resolve_function): Likewise.
2056
2057 2019-04-04  Tom Tromey  <tom@tromey.com>
2058
2059         * parser-defs.h (struct parser_state) <start_arglist,
2060         end_arglist>: New methods.
2061         <arglist_len, m_funcall_chain>: New members.
2062         (arglist_len, start_arglist, end_arglist): Don't declare.
2063         * parse.c (arglist_len, funcall_chain): Remove global.
2064         (start_arglist, end_arglist): Remove functions.
2065         (parse_exp_in_context): Update.
2066         * p-exp.y: Update rules.
2067         * m2-exp.y: Update rules.
2068         * go-exp.y: Update rules.
2069         * f-exp.y: Update rules.
2070         * d-exp.y: Update rules.
2071         * c-exp.y: Update rules.
2072
2073 2019-04-04  Tom Tromey  <tom@tromey.com>
2074
2075         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2076         lex_operator, push_back>: New methods.
2077         Update all rules.
2078         (rust_parser::lex_hex, lex_escape): Rename and update.
2079         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2080         (rust_parser::lex_operator): Rename and update.
2081         (rust_parser::lex_number, rustyylex, rustyyerror)
2082         (rust_lex_test_init, rust_lex_test_sequence)
2083         (rust_lex_test_push_back, rust_lex_tests): Update.
2084         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2085         parameter.
2086         <lexptr, prev_lexptr>: New members.
2087         (lexptr, prev_lexptr): Don't declare.
2088         * parse.c (lexptr, prev_lexptr): Remove globals.
2089         (parse_exp_in_context): Update.
2090         * p-exp.y (yylex, yyerror): Update.
2091         * m2-exp.y (parse_number, yylex, yyerror): Update.
2092         * go-exp.y (lex_one_token, yyerror): Update.
2093         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2094         * d-exp.y (lex_one_token, yyerror): Update.
2095         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2096         (lex_one_token, yyerror): Update.
2097         * ada-lex.l (YY_INPUT): Update.
2098         (rewind_to_char): Update.
2099         * ada-exp.y (yyerror): Update.
2100
2101 2019-04-04  Tom Tromey  <tom@tromey.com>
2102
2103         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2104         * parser-defs.h (struct parser_state) <parser_state>: Add new
2105         parameter.
2106         <comma_terminates>: New member.
2107         (comma_terminates): Don't declare global.
2108         * parse.c (comma_terminates): Remove global.
2109         (parse_exp_in_context): Update.
2110         * p-exp.y (yylex): Update.
2111         * m2-exp.y (yylex): Update.
2112         * go-exp.y (lex_one_token): Update.
2113         * f-exp.y (yylex): Update.
2114         * d-exp.y (lex_one_token): Update.
2115         * c-exp.y (lex_one_token): Update.
2116         * ada-lex.l: Update.
2117
2118 2019-04-04  Tom Tromey  <tom@tromey.com>
2119
2120         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2121         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2122         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2123         * parser-defs.h (paren_depth): Don't declare.
2124         * parse.c (paren_depth): Remove global.
2125         (parse_exp_in_context): Update.
2126         * p-exp.y (paren_depth): New global.
2127         (pascal_parse): Initialize it.
2128         * m2-exp.y (paren_depth): New global.
2129         (m2_parse): Initialize it.
2130         * go-exp.y (paren_depth): New global.
2131         (go_parse): Initialize it.
2132         * f-exp.y (paren_depth): New global.
2133         (f_parse): Initialize it.
2134         * d-exp.y (paren_depth): New global.
2135         (d_parse): Initialize it.
2136         * c-exp.y (paren_depth): New global.
2137         (c_parse): Initialize it.
2138         * ada-lex.l (paren_depth): New global.
2139         (lexer_init): Initialize it.
2140
2141 2019-04-04  Tom Tromey  <tom@tromey.com>
2142
2143         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2144         (rust_parser::convert_ast_to_type)
2145         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2146         * parser-defs.h (struct parser_state) <parser_state>: Add
2147         parameters.  Initialize new members.
2148         <expression_context_block, expression_context_pc>: New members.
2149         * parse.c (expression_context_block, expression_context_pc):
2150         Remove globals.
2151         (parse_exp_in_context): Update.
2152         * p-exp.y: Update all rules.
2153         (yylex): Update.
2154         * m2-exp.y: Update all rules.
2155         (yylex): Update.
2156         * go-exp.y (yylex): Update.
2157         * f-exp.y (yylex): Update.
2158         * d-exp.y: Update all rules.
2159         (yylex): Update.
2160         * c-exp.y: Update all rules.
2161         (lex_one_token, classify_name, yylex, c_parse): Update.
2162         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2163
2164 2019-04-04  Tom Tromey  <tom@tromey.com>
2165
2166         * gdbarch.h, gdbarch.c: Rebuild.
2167         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2168         * stap-probe.h:
2169         (struct stap_parse_info): Replace "parser_state" with
2170         "expr_builder".
2171         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2172         (parser_state): New class.
2173         * parse.c (expr_builder): Rename.
2174         (expr_builder::release): Rename.
2175         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2176         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2177         (write_exp_elt_longcst, write_exp_elt_floatcst)
2178         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2179         (write_exp_string_vector, write_exp_bitstring)
2180         (write_exp_msymbol, mark_struct_expression)
2181         (write_dollar_variable)
2182         (insert_type_address_space, increase_expout_size): Replace
2183         "parser_state" with "expr_builder".
2184         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2185         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2186         "parser_state" with "expr_builder".
2187
2188 2019-04-04  Tom Tromey  <tom@tromey.com>
2189
2190         * rust-exp.y: Replace "parse_language" with method call.
2191         * p-exp.y:
2192         (yylex): Replace "parse_language" with method call.
2193         * m2-exp.y:
2194         (yylex): Replace "parse_language" with method call.
2195         * go-exp.y (classify_name): Replace "parse_language" with method
2196         call.
2197         * f-exp.y (yylex): Replace "parse_language" with method call.
2198         * d-exp.y (lex_one_token): Replace "parse_language" with method
2199         call.
2200         * c-exp.y:
2201         (lex_one_token, classify_name, yylex): Replace "parse_language"
2202         with method call.
2203         * ada-exp.y (find_primitive_type, type_char)
2204         (type_system_address): Replace "parse_language" with method call.
2205
2206 2019-04-04  Tom Tromey  <tom@tromey.com>
2207
2208         * rust-exp.y: Replace "parse_gdbarch" with method call.
2209         * parse.c (write_dollar_variable, insert_type_address_space):
2210         Replace "parse_gdbarch" with method call.
2211         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2212         call.
2213         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2214         call.
2215         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2216         "parse_gdbarch" with method call.
2217         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2218         with method call.
2219         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2220         "parse_gdbarch" with method call.
2221         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2222         "parse_gdbarch" with method call.
2223         * c-exp.y (parse_type, parse_number, classify_name): Replace
2224         "parse_gdbarch" with method call.
2225         * ada-lex.l: Replace "parse_gdbarch" with method call.
2226         * ada-exp.y (parse_type, find_primitive_type, type_char)
2227         (type_system_address): Replace "parse_gdbarch" with method call.
2228
2229 2019-04-04  Tom Tromey  <tom@tromey.com>
2230
2231         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2232         * stap-probe.c (stap_parse_argument): Update.
2233         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2234         initial_size parameter.
2235         * rust-exp.y (rust_lex_tests): Update.
2236         * parse.c (parser_state): Update.
2237         (parse_exp_in_context): Update.
2238         * parser-defs.h (struct parser_state) <parser_state>: Remove
2239         "initial_size" parameter.
2240
2241 2019-04-04  Tom Tromey  <tom@tromey.com>
2242
2243         * parser-defs.h (increase_expout_size): Don't declare.
2244         * parse.c (increase_expout_size): Now static.
2245
2246 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2247
2248         * gnu-nat.c (gnu_nat_target::wait): Fix
2249         target_waitstatus_to_string call.
2250
2251 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2252
2253         * eval.c (evaluate_subexp_standard): Handle internal functions
2254         during Fortran function call handling.
2255
2256 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2257
2258         * NEWS: Mention new internal functions.
2259         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2260         (read_base_type): Use dwarf2_init_complex_target_type.
2261         * value.c (creal_internal_fn): New function.
2262         (cimag_internal_fn): New function.
2263         (_initialize_values): Register new internal functions.
2264
2265 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2266
2267         * infrun.c (stop_all_threads): If debug_infrun, always
2268         trace the wait status after wait_one, using
2269         target_waitstatus_to_string and target_pid_to_str.
2270         (handle_inferior_event): Replace various trace of
2271         wait status kind by a single trace.
2272         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2273         wait status kind image by target_waitstatus_to_string.
2274         * target/waitstatus.c (target_waitstatus_to_string): Fix
2275         obsolete comment.
2276
2277 2019-04-01  Tom Tromey  <tromey@adacore.com>
2278
2279         PR symtab/23331:
2280         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2281
2282 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2283             Pedro Alves  <palves@redhat.com>
2284
2285         * top.c (quit_force): Call 'finalize_values'.
2286         * value.c (finalize_values): New function.
2287         * value.h (finalize_values): Declare.
2288
2289 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2290
2291         * NEWS: Announce $_gdb_major and $_gdb_minor.
2292
2293         * top.c (init_gdb_version_vars): New function.
2294         (gdb_init): Call init_gdb_version_vars.
2295
2296 2019-03-29  Tom Tromey  <tromey@adacore.com>
2297
2298         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2299         help text.  Remove dead code.
2300
2301 2019-03-29  Keith Seitz  <keiths@redhat.com>
2302
2303         From Siddhesh Poyarekar:
2304         * f-lang.h (f77_get_upperbound): Return LONGEST.
2305         (f77_get_lowerbound): Likewise.
2306         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2307         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2308         print them.
2309         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2310         plongest to format print it.
2311         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2312         (f77_get_upperbound): Likewise.
2313         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2314         LOWER_BOUND to LONGEST.
2315         (f77_create_arrayprint_offset_tbl): Likewise.
2316
2317 2019-03-29  Keith Seitz  <keiths@redhat.com>
2318
2319         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2320         %s/pulongest for TYPE_LENGTH instead of %d in format
2321         strings.
2322         * ada-typerint.c (ada_print_type): Likewise.
2323         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2324         * compile/compile-c-support.c (generate_register_struct): Likewise.
2325         * gdbtypes.c (recursive_dump_type): Likewise.
2326         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2327         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2328         instead of %d in format strings.
2329         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2330         to std::min to ULONGEST.
2331         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2332         instead of %d in format strings.
2333         * tracepoint.c (info_scope_command): Likewise.
2334         * typeprint.c (print_offset_data::update)
2335         (print_offset_data::finish): Likewise.
2336         * xtensa-tdep.c (xtensa_store_return_value)
2337         (xtensa_push_dummy_call): Likewise.
2338
2339 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2340
2341         * windows-nat.c (display_selector): Fixed format specifications
2342         for 64-bit Cygwin.
2343
2344 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2345
2346         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2347
2348 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2349
2350         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2351         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2352         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2353         (nios2_linux_init_abi): Install it.
2354
2355 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2356
2357         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2358
2359 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2360
2361         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2362
2363 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2364             Tom Tromey  <tromey@adacore.com>
2365
2366         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2367
2368 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2369
2370         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2371         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2372         method to compute the bounds of range types. Also print "[evaluated]"
2373         if the bounds' values come from a dynamic evaluation.
2374
2375 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2376
2377         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2378         whitespace when pretty printing is on.
2379
2380 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2381
2382         * ppc-linux-nat.c: Add include.
2383
2384 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2385
2386         * NEWS: Mention AArch64 Pointer Authentication.
2387
2388 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2389
2390         * arm-linux-nat.c: Add include.
2391
2392 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2393
2394         * source-cache.c (source_cache::get_source_lines): Re-read
2395         fullname after calling open_source_file.
2396
2397 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2398
2399         * NEWS: Mention TLS support for FreeBSD.
2400
2401 2019-03-25  Tom Tromey  <tromey@adacore.com>
2402
2403         * minsyms.c (BUNCH_SIZE): Update comment.
2404         (~minimal_symbol_reader): Remove old comment.
2405         (compact_minimal_symbols): Update comment.
2406         (minimal_symbol_reader::install): Remove old comment.  Update
2407         other comments.
2408
2409 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2410
2411         * s390-linux-nat.c: Add include.
2412
2413 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2414
2415         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2416         Call linux_get_hwcap.
2417         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2418         Likewise.
2419         (aarch64_linux_get_hwcap): Remove function.
2420         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2421         declaration.
2422         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2423         linux_get_hwcap.
2424         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2425         * linux-tdep.c (linux_get_hwcap): Add function.
2426         (linux_get_hwcap2): Likewise.
2427         * linux-tdep.h (linux_get_hwcap): Add declaration.
2428         (linux_get_hwcap2): Likewise.
2429         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2430         (ppc_linux_get_hwcap2): Likewise.
2431         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2432         linux_get_hwcap.
2433         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2434         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2435         (ppc_linux_nat_target::read_description): Likewise.
2436         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2437         * s390-linux-nat.c: Likewise.
2438         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2439
2440 2019-03-24  Tom Tromey  <tom@tromey.com>
2441
2442         * ada-lang.c (standard_lookup): Simplify initialization.
2443         (ada_lookup_symbol_nonlocal): Simplify return.
2444         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2445         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2446         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2447         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2448         initialization.
2449         * solib.c (solib_global_lookup): Simplify.
2450         * symtab.c (null_block_symbol): Remove.
2451         (symbol_cache_lookup): Simplify returns.
2452         (lookup_language_this): Simplify returns.
2453         (lookup_symbol_aux): Simplify return.
2454         (lookup_local_symbol): Simplify returns.
2455         (lookup_global_symbol_from_objfile): Simplify return.
2456         (lookup_symbol_in_objfile_symtabs)
2457         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2458         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2459         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2460         * cp-namespace.c (cp_lookup_bare_symbol)
2461         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2462         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2463         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2464         (cp_lookup_symbol_via_imports): Simplify initialization.
2465         (find_symbol_in_baseclass): Likewise.
2466         * symtab.h (null_block_symbol): Remove.
2467         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2468         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2469         (d_lookup_symbol_module): Likewise.
2470         (find_symbol_in_baseclass): Simplify initialization.
2471
2472 2019-03-24  Tom Tromey  <tom@tromey.com>
2473
2474         * expression.h: Don't include symtab.h.
2475         (struct block): Forward declare.
2476
2477 2019-03-24  Tom Tromey  <tom@tromey.com>
2478
2479         * c-exp.y (typebase): Remove casts.
2480         * gdbtypes.c (lookup_unsigned_typename, )
2481         (lookup_signed_typename): Remove cast.
2482         * eval.c (parse_to_comma_and_eval): Remove cast.
2483         * parse.c (write_dollar_variable): Remove cast.
2484         * block.h (struct block) <superblock>: Now const.
2485         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2486         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2487         (map_block): Make "block" const.
2488         * symfile.h (struct quick_symbol_functions)
2489         <map_matching_symbols>: Constify block argument to "callback".
2490         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2491         const.
2492         (find_pc_sect_compunit_symtab): Make "b" const.
2493         (find_symbol_at_address): Likewise.
2494         (search_symbols): Likewise.
2495         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2496         (dw2_debug_names_lookup_symbol): Likewise.
2497         (dw2_map_matching_symbols): Update.
2498         * p-valprint.c (pascal_val_print): Remove "block".
2499         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2500         (aux_add_nonlocal_symbols): Make "block" const.
2501         (resolve_subexp): Remove cast.
2502         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2503         const.
2504         (iterate_over_file_blocks): Likewise.
2505         * f-exp.y (%union) <bval>: Remove.
2506         * coffread.c (patch_opaque_types): Make "b" const.
2507         * spu-tdep.c (spu_catch_start): Make "block" const.
2508         * c-valprint.c (print_unpacked_pointer): Remove "block".
2509         * symmisc.c (dump_symtab_1): Make "b" const.
2510         (block_depth): Make "block" const.
2511         * d-exp.y (%union) <bval>: Remove.
2512         * cp-support.h (cp_lookup_rtti_type): Update.
2513         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2514         * psymtab.c (psym_lookup_symbol): Make "block" const.
2515         (maintenance_check_psymtabs): Make "b" const.
2516         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2517         (enumerate_locals, enumerate_args): Update.
2518         * python/py-symtab.c (stpy_global_block): Make "block" const.
2519         (stpy_static_block): Likewise.
2520         * inline-frame.c (block_starting_point_at): Make "new_block"
2521         const.
2522         * block.c (find_block_in_blockvector): Make return type const.
2523         (blockvector_for_pc_sect): Make "b" const.
2524         (find_block_in_blockvector): Make "b" const.
2525
2526 2019-03-23  Tom Tromey  <tom@tromey.com>
2527
2528         * varobj.c (varobj_create): Update.
2529         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2530         * printcmd.c (display_command, do_one_display): Don't reset
2531         innermost_block.
2532         * parser-defs.h (enum innermost_block_tracker_type): Move to
2533         expression.h.
2534         (innermost_block): Update comment.
2535         * parse.c (parse_exp_1): Add tracker_types parameter.
2536         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2537         tracker_types parameter.  Reset innermost_block.
2538         (parse_exp_in_context): Remove.
2539         (parse_expression_for_completion): Update.
2540         * objfiles.c (~objfile): Don't reset expression_context_block or
2541         innermost_block.
2542         * expression.h (enum innermost_block_tracker_type): Move from
2543         parser-defs.h.
2544         (parse_exp_1): Add tracker_types parameter.
2545         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2546         reset innermost_block.
2547
2548 2019-03-23  Tom Tromey  <tom@tromey.com>
2549
2550         * objfiles.h: Include bcache.h.
2551
2552 2019-03-23  Tom Tromey  <tom@tromey.com>
2553
2554         * linespec.c (get_current_search_block): Use
2555         scoped_restore_current_language.
2556         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2557
2558 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2559             Jiong Wang  <jiong.wang@arm.com>
2560
2561         * aarch64-linux-tdep.c
2562         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2563         section.
2564         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2565
2566 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2567             Jiong Wang  <jiong.wang@arm.com>
2568
2569         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2570         instructions.
2571         (aarch64_analyze_prologue_test): Add PACIASP test.
2572         (aarch64_prologue_prev_register): Unmask PC value.
2573
2574 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2575             Jiong Wang  <jiong.wang@arm.com>
2576
2577         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2578         (aarch64_dwarf2_prev_register): Unmask PC value.
2579         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2580         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2581         DW_CFA_AARCH64_negate_ra_state.
2582         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2583
2584 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2585             Jiong Wang  <jiong.wang@arm.com>
2586
2587         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2588         registers.
2589         (aarch64_pseudo_register_name): Likewise.
2590         (aarch64_pseudo_register_type): Likewise.
2591         (aarch64_pseudo_register_reggroup_p): Likewise.
2592         (aarch64_gdbarch_init): Add pauth registers.
2593         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2594         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2595         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2596         (struct gdbarch_tdep): Add regnum for ra_state.
2597
2598 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2599             Jiong Wang  <jiong.wang@arm.com>
2600
2601         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2602
2603 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2604             Jiong Wang  <jiong.wang@arm.com>
2605
2606         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2607         function.
2608         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2609         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2610         (aarch64_gdbarch_init): Add puth registers.
2611         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2612         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2613         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2614
2615 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2616             Jiong Wang  <jiong.wang@arm.com>
2617
2618         * aarch64-linux-nat.c
2619         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2620         * aarch64-linux-tdep.c
2621         (aarch64_linux_core_read_description): Likewise.
2622         (aarch64_linux_get_hwcap): New function.
2623         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2624         (aarch64_linux_get_hwcap): New declaration.
2625
2626 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2627             Jiong Wang  <jiong.wang@arm.com>
2628
2629         * aarch64-linux-nat.c
2630         (aarch64_linux_nat_target::read_description): Add pauth param.
2631         * aarch64-linux-tdep.c
2632         (aarch64_linux_core_read_description): Likewise.
2633         * aarch64-tdep.c (struct target_desc): Add in pauth.
2634         (aarch64_read_description): Add pauth param.
2635         (aarch64_gdbarch_init): Likewise.
2636         * aarch64-tdep.h (aarch64_read_description): Likewise.
2637         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2638         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2639         * features/Makefile: Add new files.
2640         * features/aarch64-pauth.c: New file.
2641         * features/aarch64-pauth.xml: New file.
2642
2643 2019-03-20  Tom Tromey  <tromey@adacore.com>
2644
2645         * infrun.c (handle_inferior_event): Rename from
2646         handle_inferior_event_1.  Create a scoped_value_mark.
2647         (handle_inferior_event): Remove.
2648
2649 2019-03-19  Tom Tromey  <tromey@adacore.com>
2650
2651         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2652         * infrun.h (print_stop_event): Add "displays" parameter.
2653         * infrun.c (print_stop_event): Add "displays" parameter.
2654
2655 2019-03-19  Pedro Alves  <palves@redhat.com>
2656
2657         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2658         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2659         to -1.  Fix TABs vs spaces.
2660         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2661         * tui/tui-out.h (tui_ui_out) Add intro comments.
2662         <m_line, m_start_of_line>: In-class initialize, and add describing
2663         comment.
2664
2665 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2666
2667         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2668         variable names.
2669         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2670
2671 2019-03-18  Pedro Alves  <palves@redhat.com>
2672             Eli Zaretskii <eliz@gnu.org>
2673
2674         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2675         m_line and m_start_of_line.
2676
2677 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2678
2679         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2680         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2681         it returns a newline.  This fixes a regression in TU mode, whereby
2682         the next line is output on the same screen line as the user input.
2683
2684 2019-03-18  Tom Tromey  <tromey@adacore.com>
2685
2686         * minsyms.c (minimal_symbol_reader::install): Remove call to
2687         obstack_blank.
2688
2689 2019-03-18  Pedro Alves  <palves@redhat.com>
2690
2691         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2692         New globals.
2693         (apply_style): New, factored out from ...
2694         (apply_ansi_escape): ... this.  Handle reverse video mode.
2695         (tui_set_reverse_mode): New function.
2696         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2697         * tui/tui-winsource.c (tui_show_source_line): Use
2698         tui_set_reverse_mode instead of setting A_STANDOUT.
2699         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2700         New setter methods.
2701
2702 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2703
2704         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2705         Handle tabs.
2706
2707 2019-03-18  Tom Tromey  <tromey@adacore.com>
2708
2709         * ada-lang.c (empty_array): Add "high" parameter.
2710         (ada_evaluate_subexp): Update.
2711
2712 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2713
2714         * unittests/string_view-selftests.c: Define
2715         _initialize_string_view_selftests unconditionally.
2716
2717 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2718
2719         PR gdb/24350
2720         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2721
2722 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2723
2724         PR gdb/24351
2725         * windows-nat.c (display_selector): Fix format specifiers.
2726
2727 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2728
2729         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2730         tui_refill_source_window instead of tui_refresh_win, to update the
2731         current execution line.  This fixes redisplay of the current line
2732         when stepping through the code with "next" or "step".
2733
2734 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2735
2736         * source-cache.c (source_cache::get_source_lines): Call
2737         find_source_lines to initialize s->nlines.  This fixes vertical
2738         scrolling of TUI source window when the DOWN arrow is pressed.
2739
2740 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2741
2742         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2743         linux-thread-db.c (_initialize_thread_db): Likewise.
2744
2745 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2746
2747         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2748         wclrtoeol in tui_show_source_line".  This reverts changes made in
2749         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2750
2751 2019-03-15  Tom Tromey  <tom@tromey.com>
2752
2753         * symtab.h (struct minimal_symbol): Derive from
2754         general_symbol_info.
2755         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2756         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2757         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2758         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2759         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2760         (MSYMBOL_SEARCH_NAME): Update.
2761         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2762         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2763         * minsyms.c (minimal_symbol_reader::record_full): Update.
2764
2765 2019-03-15  Tom Tromey  <tom@tromey.com>
2766
2767         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2768
2769 2019-03-15  Tom Tromey  <tom@tromey.com>
2770
2771         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2772         unique_xmalloc_ptr.
2773         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2774         Update.
2775         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2776         (build_minimal_symbol_hash_tables)
2777         (minimal_symbol_reader::install): Update.
2778
2779 2019-03-15  Tom Tromey  <tom@tromey.com>
2780
2781         * symtab.c (create_demangled_names_hash): Update.
2782         (symbol_set_names): Update.
2783         * objfiles.h (struct objfile_per_bfd_storage)
2784         <demangled_names_hash>: Now an htab_up.
2785         * objfiles.c (objfile_per_bfd_storage): Simplify.
2786
2787 2019-03-15  Tom Tromey  <tom@tromey.com>
2788
2789         * objfiles.h (struct objfile_per_bfd_storage): Declare
2790         destructor.
2791         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2792         New.
2793         (get_objfile_bfd_data): Use new.  Don't initialize
2794         language_of_main.
2795         (free_objfile_per_bfd_storage): Remove.
2796         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2797
2798 2019-03-15  Tom Tromey  <tom@tromey.com>
2799
2800         * symfile.c (reread_symbols): Update.
2801         * objfiles.c (objfile::objfile): Update.
2802         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2803         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2804         comment.
2805         (minimal_symbol_reader::install): Update.
2806         (terminate_minimal_symbol_table): Remove.
2807         * jit.c (jit_object_close_impl): Update.
2808
2809 2019-03-15  Tom Tromey  <tom@tromey.com>
2810
2811         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2812         initializations.
2813
2814 2019-03-15  Tom Tromey  <tom@tromey.com>
2815
2816         * objfiles.h (struct objfile_per_bfd_storage)
2817         <demangled_hash_languages>: Now a bitset.
2818         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2819         (lookup_minimal_symbol): Update.
2820
2821 2019-03-15  Tom Tromey  <tom@tromey.com>
2822
2823         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2824         Don't return the symbol.
2825         * coffread.c (record_minimal_symbol): Use record_full.
2826
2827 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2828
2829         The MS-Windows port of ncurses fails to switch to a color pair if
2830         one or both of the colors are the implicit default colors.  This
2831         change records the default colors when TUI is initialized, and
2832         then specifies them explicitly when a color pair uses the default
2833         colors.  This allows color styling in TUI mode on MS-Windows.
2834
2835         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2836         ncurses_norm_attr.
2837         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2838         colors in ncurses_norm_attr.
2839         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2840         "none", replace it with the default color recorded in
2841         ncurses_norm_attr.
2842
2843 2019-03-14  Tom Tromey  <tromey@adacore.com>
2844
2845         * source-cache.h (class source_cache) <get_source_lines>: Return
2846         std::string.
2847         * source-cache.c (source_cache::extract_lines): Handle case where
2848         first_pos==npos.  Return std::string.
2849         (source_cache::get_source_lines): Update.
2850
2851 2019-03-14  Tom Tromey  <tromey@adacore.com>
2852
2853         * NEWS: Add item for "style sources" commands.
2854         * source-cache.c (source_cache::get_source_lines): Check
2855         source_styling.
2856         * cli/cli-style.c (source_styling): New global.
2857         (_initialize_cli_style): Add "style sources" commands.
2858         (show_style_sources): New function.
2859         * cli/cli-style.h (source_styling): Declare.
2860
2861 2019-03-14  Pedro Alves  <palves@redhat.com>
2862             Tom Tromey  <tromey@adacore.com>
2863
2864         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2865         * tui/tui-winsource.c (tui_refill_source_window): New function,
2866         from...
2867         (tui_horizontal_source_scroll): ... here.  Move some logic.
2868         * cli/cli-style.c (set_style_enabled): Notify new observable.
2869         * tui/tui-hooks.c (tui_redisplay_source): New function.
2870         (tui_attach_detach_observers): Attach or detach
2871         tui_redisplay_source.
2872         * observable.h (source_styling_changed): New observable.
2873         * observable.c: Define source_styling_changed observable.
2874
2875 2019-03-13  Tom Tromey  <tromey@adacore.com>
2876
2877         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2878         (i386_gnu_nat_target::store_registers): Update.
2879         * target-debug.h (target_debug_print_std_string): New macro.
2880         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2881         * windows-tdep.c (display_one_tib): Update.
2882         * tui/tui-stack.c (tui_make_status_line): Update.
2883         * top.c (print_inferior_quit_action): Update.
2884         * thread.c (thr_try_catch_cmd): Update.
2885         (add_thread_with_info): Update.
2886         (thread_target_id_str): Update.
2887         (thr_try_catch_cmd): Update.
2888         (thread_command): Update.
2889         (thread_find_command): Update.
2890         * record-btrace.c (record_btrace_target::info_record)
2891         (record_btrace_resume_thread, record_btrace_target::resume)
2892         (record_btrace_cancel_resume, record_btrace_step_thread)
2893         (record_btrace_target::wait, record_btrace_target::wait)
2894         (record_btrace_target::wait, record_btrace_target::stop): Update.
2895         * progspace.c (print_program_space): Update.
2896         * process-stratum-target.c
2897         (process_stratum_target::thread_address_space): Update.
2898         * linux-fork.c (linux_fork_mourn_inferior)
2899         (detach_checkpoint_command, info_checkpoints_command)
2900         (linux_fork_context): Update.
2901         (linux_fork_detach): Update.
2902         (class scoped_switch_fork_info): Update.
2903         (delete_checkpoint_command): Update.
2904         * infrun.c (follow_fork_inferior): Update.
2905         (follow_fork_inferior): Update.
2906         (proceed_after_vfork_done): Update.
2907         (handle_vfork_child_exec_or_exit): Update.
2908         (follow_exec): Update.
2909         (displaced_step_prepare_throw): Update.
2910         (displaced_step_restore): Update.
2911         (start_step_over): Update.
2912         (resume_1): Update.
2913         (clear_proceed_status_thread): Update.
2914         (proceed): Update.
2915         (print_target_wait_results): Update.
2916         (do_target_wait): Update.
2917         (context_switch): Update.
2918         (stop_all_threads): Update.
2919         (restart_threads): Update.
2920         (finish_step_over): Update.
2921         (handle_signal_stop): Update.
2922         (switch_back_to_stepped_thread): Update.
2923         (keep_going_pass_signal): Update.
2924         (print_exited_reason): Update.
2925         (normal_stop): Update.
2926         * inferior.c (inferior_pid_to_str): Change return type.
2927         (print_selected_inferior): Update.
2928         (add_inferior): Update.
2929         (detach_inferior): Update.
2930         * dummy-frame.c (fprint_dummy_frames): Update.
2931         * dcache.c (dcache_info_1): Update.
2932         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2933         (btrace_fetch, btrace_clear): Update.
2934         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2935         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2936         type.
2937         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2938         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2939         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2940         * gdbarch.c, gdbarch.h: Rebuild.
2941         * gdbarch.sh (core_pid_to_str): Change return type.
2942         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2943         return type.
2944         (windows_nat_target::pid_to_str): Change return type.
2945         (windows_delete_thread): Update.
2946         (windows_nat_target::attach): Update.
2947         (windows_nat_target::files_info): Update.
2948         * target-delegates.c: Rebuild.
2949         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2950         return type.
2951         (sol_thread_target::pid_to_str): Change return type.
2952         * remote.c (class remote_target) <pid_to_str>: Change return
2953         type.
2954         (remote_target::pid_to_str): Change return type.
2955         (extended_remote_target::attach, remote_target::remote_stop_ns)
2956         (remote_target::remote_notif_remove_queued_reply)
2957         (remote_target::push_stop_reply, remote_target::disable_btrace):
2958         Update.
2959         (extended_remote_target::attach): Update.
2960         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2961         type.
2962         (gdbsim_target::pid_to_str): Change return type.
2963         * ravenscar-thread.c (struct ravenscar_thread_target)
2964         <pid_to_str>: Change return type.
2965         (ravenscar_thread_target::pid_to_str): Change return type.
2966         * procfs.c (class procfs_target) <pid_to_str>: Change return
2967         type.
2968         (procfs_target::pid_to_str): Change return type.
2969         (procfs_target::attach): Update.
2970         (procfs_target::detach): Update.
2971         (procfs_target::fetch_registers): Update.
2972         (procfs_target::store_registers): Update.
2973         (procfs_target::wait): Update.
2974         (procfs_target::files_info): Update.
2975         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2976         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2977         return type.
2978         (nto_procfs_target::pid_to_str): Change return type.
2979         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2980         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2981         return type.
2982         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2983         (exit_lwp): Update.
2984         (attach_proc_task_lwp_callback, get_detach_signal)
2985         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2986         (linux_nat_target::resume, wait_lwp, stop_callback)
2987         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2988         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2989         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2990         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2991         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2992         type.
2993         (inf_ptrace_target::attach): Update.
2994         (inf_ptrace_target::files_info): Update.
2995         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2996         type.
2997         (go32_nat_target::pid_to_str): Change return type.
2998         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2999         (gnu_nat_target::wait): Update.
3000         (gnu_nat_target::wait): Update.
3001         (gnu_nat_target::resume): Update.
3002         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3003         (fbsd_nat_target::wait): Update.
3004         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3005         type.
3006         (darwin_nat_target::attach): Update.
3007         * corelow.c (class core_target) <pid_to_str>: Change return type.
3008         (core_target::pid_to_str): Change return type.
3009         * target.c (normal_pid_to_str): Change return type.
3010         (default_pid_to_str): Likewise.
3011         (target_pid_to_str): Change return type.
3012         (target_translate_tls_address): Update.
3013         (target_announce_detach): Update.
3014         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3015         return type.
3016         (bsd_uthread_target::pid_to_str): Change return type.
3017         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3018         type.
3019         (bsd_kvm_target::pid_to_str): Change return type.
3020         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3021         return type.
3022         (aix_thread_target::pid_to_str): Change return type.
3023         * target.h (struct target_ops) <pid_to_str>: Change return type.
3024         (target_pid_to_str, normal_pid_to_str): Likewise.
3025         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3026         type.
3027         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3028         type.
3029         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3030         return type.
3031         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3032         type.
3033         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3034         type.
3035         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3036         return type.
3037
3038 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3039
3040         * NEWS: Mention that the new default MI version is 3.  Mention
3041         changes to the output of commands and events that deal with
3042         multi-location breakpoints.
3043         * breakpoint.c: Include "mi/mi-out.h".
3044         (print_one_breakpoint): Change output syntax if using MI version
3045         >= 3.
3046         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3047         New.
3048         (mi_multi_location_breakpoint_output_fixed): New.
3049         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3050         (mi_cmd_fix_multi_location_breakpoint_output): New.
3051         (mi_multi_location_breakpoint_output_fixed): New.
3052         * mi/mi-cmds.c (mi_cmds): Register command
3053         -fix-multi-location-breakpoint-output.
3054         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3055         interpreter "mi".
3056
3057 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3058
3059         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3060         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3061         instantiate mi_ui_out based on interpreter name.
3062         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3063         * mi/mi-main.c (mi_load_progress): Likewise.
3064
3065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3066
3067         * NEWS: Combine separate "New targets" sections for 8.3.
3068
3069 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3070
3071         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3072         (ppcfbsd_init_abi): Install gdbarch
3073         "fetch_tls_load_module_address" and "get_thread_local_address"
3074         methods.
3075
3076 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3077
3078         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3079         (riscv_fbsd_init_abi): Install gdbarch
3080         "fetch_tls_load_module_address" and "get_thread_local_address"
3081         methods.
3082
3083 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3084
3085         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3086         (i386fbsd_init_abi): Install gdbarch
3087         "fetch_tls_load_module_address" and "get_thread_local_address"
3088         methods.
3089
3090 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3091
3092         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3093         (amd64fbsd_init_abi): Install gdbarch
3094         "fetch_tls_load_module_address" and "get_thread_local_address"
3095         methods.
3096
3097 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3098
3099         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3100         (struct fbsd_pspace_data): New type.
3101         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3102         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3103         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3104         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3105         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3106
3107 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3108
3109         * gdbtypes.c (lookup_struct_elt): New function.
3110         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3111         * gdbtypes.h (struct struct_elt): New type.
3112         (lookup_struct_elt): New prototype.
3113
3114 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3115
3116         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3117         remove disabled code block.
3118
3119 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3120
3121         * gdbarch.sh (get_thread_local_address): New method.
3122         * gdbarch.h, gdbarch.c: Regenerate.
3123         * target.c (target_translate_tls_address): Use
3124         gdbarch_get_thread_local_address if present instead of
3125         target::get_thread_local_address.
3126
3127 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3128
3129         * target.h (target::get_thread_local_address): Update comment.
3130
3131 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3132
3133         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3134         objfile->separate_debug_objfile_backlink if not NULL.
3135
3136 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3137
3138         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3139         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3140         (amd64bsd_store_inferior_registers): Likewise.
3141         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3142         Enable segment base registers.
3143         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3144         PT_GETFSBASE and PT_GETGSBASE.
3145         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3146         PT_SETGSBASE.
3147         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3148         segment base registers.
3149         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3150
3151 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3152
3153         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3154         Update calls to i386_target_description to add 'segments'
3155         parameter.
3156         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3157         add segment base registers.
3158         * arch/i386.c (i386_create_target_description): Add 'segments'
3159         parameter to enable segment base registers.
3160         * arch/i386.h (i386_create_target_description): Likewise.
3161         * features/i386/32bit-segments.xml: New file.
3162         * features/i386/32bit-segments.c: Generate.
3163         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3164         call to i386_target_description to add 'segments' parameter.
3165         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3166         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3167         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3168         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3169         if feature is present.
3170         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3171         Add 'segments' parameter to call to i386_target_description.
3172         (i386_target_description): Add 'segments' parameter to enable
3173         segment base registers.
3174         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3175         to call to i386_target_description.
3176         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3177         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3178         Define I386_NUM_REGS.
3179         (i386_target_description): Add 'segments' parameter to enable
3180         segment base registers.
3181
3182 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3183
3184         PR/24325
3185         * source-cache.c: #undef open and close, to avoid unresolved
3186         externals during linking.
3187
3188 2019-03-12  Tom Tromey  <tromey@adacore.com>
3189
3190         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3191         const.  Add initializers.
3192         (_initialize_remote): Don't initialize ptid globals.
3193
3194 2019-03-12  Pedro Alves  <palves@redhat.com>
3195
3196         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3197
3198 2019-03-12  Pedro Alves  <palves@redhat.com>
3199
3200         * cp-name-parser.y (main): Remove unused 'len' variable.
3201
3202 2019-03-12  Tom Tromey  <tromey@adacore.com>
3203
3204         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3205         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3206
3207 2019-03-12  Tom Tromey  <tromey@adacore.com>
3208
3209         * linux-nat.c (iterate_over_lwps): Update.
3210         (stop_callback): Remove parameter.
3211         (stop_wait_callback, detach_callback, resume_set_callback)
3212         (select_singlestep_lwp_callback, set_ignore_sigint)
3213         (status_callback, resumed_callback, resume_clear_callback)
3214         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3215         data parameter.
3216         (linux_nat_target::detach, linux_nat_target::resume)
3217         (linux_stop_and_wait_all_lwps, select_event_lwp)
3218         (linux_nat_filter_event, linux_nat_wait_1)
3219         (linux_nat_target::kill, linux_nat_target::stop)
3220         (linux_nat_target::stop): Update.
3221         (linux_nat_resume_callback): Change type.
3222         (resume_stopped_resumed_lwps, count_events_callback)
3223         (select_event_lwp_callback): Likewise.
3224         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3225         * arm-linux-nat.c (struct update_registers_data): Remove.
3226         (update_registers_callback): Change type.
3227         (arm_linux_insert_hw_breakpoint1): Update.
3228         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3229         parameter.
3230         (x86_linux_dr_set_addr): Update.
3231         (x86_linux_dr_set_control): Update.
3232         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3233         (iterate_over_lwps): Use gdb::function_view.
3234         * nat/aarch64-linux-hw-point.c (struct
3235         aarch64_dr_update_callback_param): Remove.
3236         (debug_reg_change_callback): Change type.
3237         (aarch64_notify_debug_reg_change): Update.
3238         * s390-linux-nat.c (s390_refresh_per_info): Update.
3239
3240 2019-03-11  Tom Tromey  <tromey@adacore.com>
3241
3242         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3243         redundant assignment to "this_cu".
3244
3245 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3246
3247         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3248
3249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3250
3251         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3252         from...
3253         (rank_one_type): ... this.
3254
3255 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3256
3257         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3258         from...
3259         (rank_one_type): ... this.
3260
3261 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3262
3263         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3264         from...
3265         (rank_one_type): ... this.
3266
3267 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3268
3269         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3270         from...
3271         (rank_one_type): ... this.
3272
3273 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3274
3275         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3276         from...
3277         (rank_one_type): ... this.
3278
3279 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3280
3281         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3282         from...
3283         (rank_one_type): ... this.
3284
3285 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3286
3287         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3288         from...
3289         (rank_one_type): ... this.
3290
3291 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3292
3293         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3294         from...
3295         (rank_one_type): ... this.
3296
3297 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3298
3299         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3300         from...
3301         (rank_one_type): ... this.
3302
3303 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3304
3305         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3306         from...
3307         (rank_one_type): ... this.
3308
3309 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3310
3311         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3312         from...
3313         (rank_one_type): ... this.
3314
3315 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3316
3317         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3318         from...
3319         (rank_one_type): ... this.
3320
3321 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3322
3323         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3324         inferior-events' shows the example events.
3325
3326 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3327
3328         Support styling on native MS-Windows console
3329
3330         PR/24315
3331         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3332         on MS-Windows if $TERM is not defined.
3333
3334         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3335
3336         * posix-hdep.c (gdb_console_fputs):
3337         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3338         functions.
3339         * ui-file.h (gdb_console_fputs): Add prototype.
3340
3341         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3342         back to fputs only if the former returns zero.
3343
3344 2019-03-07  Tom Tromey  <tom@tromey.com>
3345
3346         * symmisc.c (print_symbol_bcache_statistics): Update.
3347         (print_objfile_statistics): Update.
3348         * symfile.c (allocate_symtab): Update.
3349         * stabsread.c: Don't include bcache.h.
3350         * psymtab.h (struct psymbol_bcache): Don't declare.
3351         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3352         (psymbol_bcache_init, psymbol_bcache_free)
3353         (psymbol_bcache_get_bcache): Don't declare.
3354         * psymtab.c (struct psymbol_bcache): Remove.
3355         (psymtab_storage::psymtab_storage): Update.
3356         (psymtab_storage::~psymtab_storage): Update.
3357         (psymbol_bcache_init, psymbol_bcache_free)
3358         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3359         (add_psymbol_to_bcache): Update.
3360         (allocate_psymtab): Update.
3361         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3362         macro_cache>: No longer pointers.
3363         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3364         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3365         * macrotab.c (macro_bcache): Update.
3366         * macroexp.c: Don't include bcache.h.
3367         * gdbtypes.c (check_types_worklist): Update.
3368         (types_deeply_equal): Remove TRY/CATCH.  Update.
3369         * elfread.c (elf_symtab_read): Update.
3370         * dwarf2read.c: Don't include bcache.h.
3371         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3372         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3373         (print_bcache_statistics, bcache_memory_used): Don't declare.
3374         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3375         methods.  Rename all data members.
3376         * bcache.c (struct bcache): Move to bcache.h.
3377         (bcache::expand_hash_table): Rename from expand_hash_table.
3378         (bcache): Remove.
3379         (bcache::insert): Rename from bcache_full.
3380         (bcache::compare): Rename from bcache_compare.
3381         (bcache_xmalloc): Remove.
3382         (bcache::~bcache): Rename from bcache_xfree.
3383         (bcache::print_statistics): Rename from print_bcache_statistics.
3384         (bcache::memory_used): Rename from bcache_memory_used.
3385
3386 2019-03-07  Pedro Alves  <palves@redhat.com>
3387
3388         * infrun.c (normal_stop): Also check for
3389         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3390
3391 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3392
3393         * f-lang.c (value_from_host_double): Moved to...
3394         * value.c (value_from_host_double): ...here.
3395         * value.h (value_from_host_double): Declare.
3396         * guile/scm-math.c (vlscm_convert_typed_number): Use
3397         value_from_host_double.
3398         (vlscm_convert_number): Likewise.
3399         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3400         * python/py-value.c (convert_value_from_python): Likewise.
3401
3402 2019-03-06  Tom Tromey  <tom@tromey.com>
3403
3404         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3405
3406 2019-03-06  Tom Tromey  <tom@tromey.com>
3407
3408         * utils.h (free_current_contents): Don't declare.
3409         * utils.c (free_current_contents): Remove.
3410
3411 2019-03-06  Tom Tromey  <tom@tromey.com>
3412
3413         * top.c (quit_force): Update.
3414         * main.c (captured_command_loop): Update.
3415         * common/new-op.c (operator new): Update.
3416         * common/common-exceptions.c (struct catcher)
3417         <save_cleanup_chain>: Remove member.
3418         (exceptions_state_mc_init): Update.
3419         (exception_try_scope_entry): Return nullptr.
3420         (exception_try_scope_exit, exception_rethrow)
3421         (throw_exception_sjlj, throw_exception_cxx): Update.
3422         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3423         (all_cleanups, do_cleanups, discard_cleanups)
3424         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3425         (restore_cleanups, restore_final_cleanups): Don't declare.
3426         (do_final_cleanups): Remove parameter.
3427         * common/cleanups.c (cleanup_chain, make_cleanup)
3428         (make_cleanup_dtor, all_cleanups, do_cleanups)
3429         (discard_my_cleanups, discard_cleanups)
3430         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3431         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3432         (null_cleanup): Remove.
3433         (do_final_cleanups): Remove parameter.
3434
3435 2019-03-06  Tom Tromey  <tom@tromey.com>
3436
3437         * remote.c (remote_target::remote_parse_stop_reply): Use
3438         unique_xmalloc_ptr.
3439
3440 2019-03-06  Tom Tromey  <tom@tromey.com>
3441
3442         * stabsread.c (struct stabs_field_info): Rename from field_info.
3443         <list, fnlist>: Add initializers.
3444         <obstack>: New member.
3445         (read_member_functions, read_struct_fields, read_baseclasses):
3446         Allocate on obstack.  Don't use cleanups.
3447         (read_one_struct_field, read_member_functions, read_struct_fields)
3448         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3449         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3450         (read_struct_type): Update.
3451
3452 2019-03-06  Tom Tromey  <tom@tromey.com>
3453
3454         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3455         * common/filestuff.h (make_cleanup_close): Don't declare.
3456         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3457         Remove.
3458
3459 2019-03-06  Tom Tromey  <tom@tromey.com>
3460
3461         * solib-aix.c: Use make_scope_exit.
3462
3463 2019-03-06  Tom Tromey  <tom@tromey.com>
3464
3465         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3466         Use make_scope_exit.
3467
3468 2019-03-06  Tom Tromey  <tom@tromey.com>
3469
3470         * solib-svr4.c (disable_probes_interface): Remove parameter.
3471         (svr4_handle_solib_event): Use make_scope_exit.
3472
3473 2019-03-06  Tom Tromey  <tom@tromey.com>
3474
3475         * remote.c (struct stop_reply_deleter): Remove.
3476         (stop_reply_up): Update.
3477         (struct stop_reply): Derive from notif_event.  Don't typedef.
3478         <regcache>: Now a std::vector.
3479         (stop_reply_xfree): Remove.
3480         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3481         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3482         (remote_target::discard_pending_stop_replies): Use delete.
3483         (remote_target::remote_parse_stop_reply): Update.
3484         (remote_target::process_stop_reply): Update.
3485         * remote-notif.h (struct notif_event): Add virtual destructor.
3486         Remove "dtr" member.
3487         (struct notif_client) <alloc_event>: Return a unique_ptr.
3488         (notif_event_xfree): Don't declare.
3489         (notif_event_up): New typedef.
3490         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3491         (notif_event_xfree, do_notif_event_xfree): Remove.
3492         (remote_notif_state_xfree): Update.
3493
3494 2019-03-06  Tom Tromey  <tom@tromey.com>
3495
3496         * infrun.c (displaced_step_clear_cleanup): Now a
3497         forward_scope_exit type.
3498         (displaced_step_prepare_throw): Update.
3499         (displaced_step_fixup): Update.
3500
3501 2019-03-06  Tom Tromey  <tom@tromey.com>
3502
3503         * inferior.h (class inferior): Update comment.
3504         * gdbthread.h (class thread_info): Update comment.
3505
3506 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3507             Tom Tromey  <tom@tromey.com>
3508
3509         * stabsread.h (struct stab_section_list): Remove.
3510         (coffstab_build_psymtabs): Update.
3511         * dbxread.c (symbuf_sections): Now a std::vector.
3512         (sect_idx): New global.
3513         (fill_symbuf): Update.
3514         (coffstab_build_psymtabs): Change type of stabsects parameter.
3515         Update.
3516         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3517         std::vector.
3518         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3519         (coff_locate_sections): Update.
3520         (coff_symfile_read): Remove cleanups.  Update.
3521         (init_stringtab): Add storage parameter.
3522         (free_stringtab, free_stringtab_cleanup): Remove.
3523         (init_lineno): Add storage parameter.
3524         (free_linetab, free_linetab_cleanup): Remove.
3525
3526 2019-03-06  Pedro Alves  <palves@redhat.com>
3527
3528         * linux-fork.c (fork_info::clobber_regs): Delete.
3529         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3530         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3531         comment.  Adjust.
3532         (scoped_switch_fork_info::scoped_switch_fork_info)
3533         (checkpoint_command, linux_fork_context): Adjust
3534         fork_save_infrun_state calls.
3535
3536 2019-03-06  Pedro Alves  <palves@redhat.com>
3537
3538         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3539         (inf_has_multiple_threads): Return 'bool' and rewrite using
3540         inferior_info::threads().
3541
3542 2019-03-06  Pedro Alves  <palves@redhat.com>
3543
3544         * linux-fork.c: Include <list>.
3545         (fork_list): Now a std::list instance.
3546         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3547         (forks_exist_p, find_last_fork): Adjust.
3548         (new_fork): Delete.
3549         (one_fork_p): New.
3550         (add_fork): Adjust.
3551         (free_fork): Delete, folded into fork_info::~fork_info().
3552         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3553         Adjust.
3554         (init_fork_list): Delete.
3555         (linux_fork_killall, linux_fork_mourn_inferior)
3556         (linux_fork_detach, info_checkpoints_command): Adjust.
3557         (_initialize_linux_fork): No longer call init_fork_list.
3558
3559 2019-03-06  Pedro Alves  <palves@redhat.com>
3560
3561         * linux-fork.c (new_fork): New, split out of ...
3562         (add_fork): ... this.  Return void.  Move "first fork" special
3563         case from here, to ...
3564         (checkpoint_command): ... here.
3565         * linux-linux.h (add_fork): Return void.
3566
3567 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3568
3569         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3570
3571 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3572             Chris January  <chris.january@arm.com>
3573             David Lecomber  <david.lecomber@arm.com>
3574
3575         * f-exp.y: New token, UNOP_INTRINSIC.
3576         (exp): New pattern using UNOP_INTRINSIC token.
3577         (f77_keywords): Add 'abs' keyword.
3578         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3579         (value_from_host_double): New function.
3580         (evaluate_subexp_f): Support UNOP_ABS.
3581
3582 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3585         types.
3586
3587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3588
3589         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3590         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3591         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3592
3593 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3594
3595         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3596
3597 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3598             Chris January  <chris.january@arm.com>
3599
3600         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3601         * f-exp.y: Define 'KIND' token.
3602         (exp): New pattern for KIND expressions.
3603         (ptype): Handle types with a kind extension.
3604         (direct_abs_decl): Extend to spot kind extensions.
3605         (f77_keywords): Add 'kind' to the list.
3606         (push_kind_type): New function.
3607         (convert_to_kind_type): New function.
3608         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3609         * parse.c (operator_length_standard): Likewise.
3610         * parser-defs.h (enum type_pieces): Add tp_kind.
3611         * std-operator.def: Add UNOP_KIND.
3612
3613 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3614
3615         * f-exp.y (f_parse): Set yydebug.
3616
3617 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3618
3619         * f-lang.c (evaluate_subexp_f): New function.
3620         (exp_descriptor_f): New global.
3621         (f_language_defn): Use exp_descriptor_f instead of
3622         exp_descriptor_standard.
3623
3624 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3625
3626         * f-exp.y (struct token): Add comments.
3627         (dot_ops): Remove uppercase versions and the end marker.
3628         (f77_keywords): Likewise.
3629         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3630         entries in the dot_ops array are case insensitive, and use
3631         strncasecmp to compare strings.  Also some whitespace cleanup in
3632         this area.  Similar for the f77_keywords array, except entries in
3633         this list might be case sensitive.
3634
3635 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3636
3637         * f-exp.y (struct f77_boolean_val): Add comments.
3638         (boolean_values): Remove uppercase versions, and end marker.
3639         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3640         and use strncasecmp to achieve case insensitivity.  Additionally,
3641         perform whitespace cleanup around this code.
3642
3643 2019-03-06  Tom Tromey  <tromey@adacore.com>
3644
3645         * remote-sim.c (gdbsim_target_open): Use result of
3646         gdb_argv::release.
3647
3648 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3649         Dirk Schubert  <dirk.schubert@arm.com>
3650         Chris January  <chris.january@arm.com>
3651
3652         * eval.c (evaluate_subexp_standard): Call Fortran argument
3653         wrapping logic.
3654         * f-lang.c (struct value): A value which can be passed into a
3655         Fortran function call.
3656         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3657         where appropriate.
3658         (struct type): Value ready for a Fortran function call.
3659         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3660         is needed.
3661         * f-lang.h (fortran_argument_convert): Declaration.
3662         (fortran_preserve_arg_pointer): Declaration.
3663         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3664
3665 2019-03-05  Tom Tromey  <tromey@adacore.com>
3666
3667         * python/py-prettyprint.c (print_string_repr): Remove #if.
3668         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3669
3670 2019-03-05  Tom Tromey  <tromey@adacore.com>
3671
3672         * target.c (the_dummy_target): Move later.  Change type to
3673         "dummy_target".
3674         (initialize_targets): Don't initialize the_dummy_target.
3675
3676 2019-03-05  Tom Tromey  <tromey@adacore.com>
3677
3678         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3679         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3680
3681 2019-03-05  Tom Tromey  <tromey@adacore.com>
3682
3683         * windows-nat.c (windows_nat_target::attach)
3684         (windows_nat_target::detach): Don't call gdb_flush.
3685         * valprint.c (generic_val_print, val_print, val_print_string):
3686         Don't call gdb_flush.
3687         * utils.c (defaulted_query): Don't call gdb_flush.
3688         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3689         * target.c (target_announce_detach): Don't call gdb_flush.
3690         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3691         * remote.c (extended_remote_target::attach): Don't call
3692         gdb_flush.
3693         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3694         * printcmd.c (do_examine): Don't call gdb_flush.
3695         (info_display_command): Don't call gdb_flush.
3696         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3697         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3698         * memattr.c (info_mem_command): Don't call gdb_flush.
3699         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3700         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3701         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3702         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3703         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3704         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3705         (gnu_nat_target::detach): Don't call gdb_flush.
3706         * f-valprint.c (f_val_print): Don't call gdb_flush.
3707         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3708         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3709         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3710         gdb_flush.
3711         * c-valprint.c (c_val_print): Don't call gdb_flush.
3712         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3713
3714 2019-03-05  Tom Tromey  <tromey@adacore.com>
3715
3716         * varobj.c (update_dynamic_varobj_children): Update.
3717         (install_default_visualizer): Use reset, not release.
3718         * value.c (set_internalvar): Update.
3719         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3720         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3721         ATTRIBUTE_UNUSED_RESULT.
3722
3723 2019-03-05  Tom Tromey  <tromey@adacore.com>
3724
3725         * remote.c (class scoped_remote_fd) <release>: Add
3726         ATTRIBUTE_UNUSED_RESULT.
3727
3728 2019-03-05  Tom Tromey  <tromey@adacore.com>
3729
3730         * macroexp.c (struct macro_buffer) <release>: Add
3731         ATTRIBUTE_UNUSED_RESULT.
3732
3733 2019-03-05  Tom Tromey  <tromey@adacore.com>
3734
3735         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3736         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3737         ATTRIBUTE_UNUSED_RESULT.
3738
3739 2019-03-05  Tom Tromey  <tromey@adacore.com>
3740
3741         * common/scoped_fd.h (class scoped_fd) <release>: Add
3742         ATTRIBUTE_UNUSED_RESULT.
3743
3744 2019-03-05  Tom Tromey  <tromey@adacore.com>
3745
3746         * parser-defs.h (struct parser_state) <release>: Add
3747         ATTRIBUTE_UNUSED_RESULT.
3748
3749 2019-03-05  Tom Tromey  <tromey@adacore.com>
3750
3751         * utils.h (class gdb_argv) <release>: Add
3752         ATTRIBUTE_UNUSED_RESULT.
3753         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3754
3755 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3756
3757         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3758         for-loop range, to avoid compiler warnings.
3759
3760         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3761         avoid compiler warnings about unused variables.
3762
3763         * NEWS: Mention end of support for native debugging on MS-Windows
3764         before XP.
3765
3766         PR gdb/24292
3767         * common/netstuff.c:
3768         * gdbserver/gdbreplay.c
3769         * gdbserver/remote-utils.c:
3770         * ser-tcp.c:
3771         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3772         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3773         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3774         'getaddrinfo' and 'freeaddrinfo' were not available before
3775         Windows XP, and mingw.org's MinGW headers by default define
3776         _WIN32_WINNT to 0x500.
3777
3778 2019-03-01  Gary Benson <gbenson@redhat.com>
3779
3780         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3781
3782 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3783             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3784
3785         PR gdb/8527
3786         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3787         set_sigint_trap, clear_sigint_trap.
3788
3789 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3790
3791         * target.c (target_detach): Clear the regcache and the
3792         frame cache.
3793
3794 2019-02-27  Pedro Alves  <palves@redhat.com>
3795
3796         * utils.c (set_screen_size): When we cap the height/width sizes,
3797         tweak the corresponding command variable to show "unlimited":
3798
3799 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3800             Pedro Alves  <palves@redhat.com>
3801
3802         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3803         before calling rl_set_screen_size.
3804
3805 2019-02-27  Tom Tromey  <tromey@adacore.com>
3806
3807         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3808         define.
3809         * python/py-value.c: Remove Python 2.4 workaround.
3810         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3811         workaround.
3812         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3813         Python 2.4 workaround.
3814         * python/python-internal.h: Remove Python 2.4 comment.
3815         (Py_ssize_t): Don't define.
3816         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3817         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3818         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3819         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3820         * python/python.c (do_start_initialization): Remove Python 2.4
3821         workaround.
3822         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3823         (print_children): Remove Python 2.4 workaround.
3824         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3825         workaround.
3826         (CHARBUFFERPROC_NAME): Remove.
3827         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3828         Python 2.4 workaround.
3829
3830 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3831
3832         * NEWS: Note minimum Python version.
3833
3834 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3835
3836         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3837         code from these functions.  Remove corresponding ifdefs.  Use
3838         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3839         Remove gotos and target of gotos.
3840         (infpy_search_memory): Likewise.
3841
3842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3843
3844         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3845         (hppa_gdbarch_init): Don't register deleted functions with
3846         gdbarch.
3847
3848 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3849
3850         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3851         (h8300_unwind_sp): Delete.
3852         (h8300_dummy_id): Delete.
3853         (h8300_gdbarch_init): Don't register deleted functions with
3854         gdbarch.
3855
3856 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3857
3858         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3859         (ft32_unwind_pc): Delete.
3860         (ft32_unwind_sp): Delete.
3861         (ft32_gdbarch_init): Don't register deleted functions with
3862         gdbarch.
3863
3864 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3865
3866         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3867         (frv_unwind_pc): Delete.
3868         (frv_unwind_sp): Delete.
3869         (frv_gdbarch_init): Don't register deleted functions with
3870         gdbarch.
3871
3872 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3873
3874         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3875         (riscv_unwind_pc): Delete.
3876         (riscv_unwind_sp): Delete.
3877         (riscv_gdbarch_init): Don't register deleted functions with
3878         gdbarch.
3879
3880 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3881
3882         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3883         (csky_unwind_pc): Delete.
3884         (csky_unwind_sp): Delete.
3885         (csky_gdbarch_init): Don't register deleted functions with
3886         gdbarch.
3887
3888 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3891         (cris_unwind_pc): Delete.
3892         (cris_unwind_sp): Delete.
3893         (cris_gdbarch_init): Don't register deleted functions with
3894         gdbarch.
3895
3896 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3899         (bfin_unwind_pc): Delete.
3900         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3901
3902 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3903
3904         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3905         (arm_unwind_pc): Delete.
3906         (arm_unwind_sp): Delete.
3907         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3908
3909 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3910
3911         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3912         (arc_unwind_pc): Delete.
3913         (arc_unwind_sp): Delete.
3914         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3915
3916 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3917
3918         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3919         (alpha_unwind_pc): Delete.
3920         (alpha_gdbarch_init): Don't register deleted functions with
3921         gdbarch.
3922
3923 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3924
3925         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3926         (aarch64_unwind_pc): Delete.
3927         (aarch64_unwind_sp): Delete.
3928         (aarch64_gdbarch_init): Don't register deleted functions with
3929         gdbarch.
3930
3931 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3932
3933         * gdbtypes.c (type_align): Don't consider static members when
3934         computing structure alignment.
3935
3936 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3937
3938         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3939         return 0 for other types.
3940         * arch-utils.c (default_type_align): Always return 0.
3941         * gdbarch.h: Regenerate.
3942         * gdbarch.sh (type_align): Extend comment.
3943         * gdbtypes.c (type_align): Add additional comments, always call
3944         gdbarch_type_align before applying the default rules.
3945         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3946         generic code will then apply a suitable default.
3947         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3948         types, return 0 for other types.
3949
3950 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3951
3952         * NEWS: Create a new section for the next release branch.
3953         Rename the section of the current branch, now that it has
3954         been cut.
3955
3956 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3957
3958         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3959         * version.in: Bump version to 8.3.50.DATE-git.
3960
3961 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3962
3963         * aix-thread.c (ptid_cmp): Remove unused variable.
3964         (get_signaled_thread): Likewise.
3965         (store_regs_user_thread): Likewise.
3966         (store_regs_kernel_thread): Likewise.
3967         (fetch_regs_kernel_thread): Remove shadowed variable.
3968
3969 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3970
3971         * features/riscv/32bit-cpu.xml: Add register numbers.
3972         * features/riscv/32bit-fpu.c: Regenerate.
3973         * features/riscv/32bit-fpu.xml: Add register numbers.
3974         * features/riscv/64bit-cpu.xml: Add register numbers.
3975         * features/riscv/64bit-fpu.c: Regenerate.
3976         * features/riscv/64bit-fpu.xml: Add register numbers.
3977
3978 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3979
3980         * NEWS: Mention two argument form of gdb.Value constructor.
3981         * python/py-value.c (convert_buffer_and_type_to_value): New
3982         function.
3983         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3984         Add support for handling an optional second argument.  Call
3985         convert_buffer_and_type_to_value as appropriate.
3986         * python/python-internal.h (Py_buffer_deleter): New struct.
3987         (Py_buffer_up): New typedef.
3988
3989 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3990
3991         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3992         instead of releasing ownership.
3993
3994 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3995
3996         * dwarf2read.c (open_and_init_dwp_file): Call
3997         elf_numsections instead of bfd_count_sections to initialize
3998         dwp_file->num_sections.
3999
4000 2019-02-25  Tom Tromey  <tromey@adacore.com>
4001
4002         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4003
4004 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4005
4006         * gcore.in: Add '--readnever' option when invoking GDB.
4007
4008 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4009
4010         * MAINTAINERS: Update my email address.
4011
4012 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4013
4014         * build-id.c (build_id_to_debug_bfd_1): New function.
4015         (build_id_to_debug_bfd): Look for separate debug file in
4016         sysroot.
4017
4018 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4019
4020         * gdbarch.sh: Update the copyright year range that is placed into
4021         generated files.
4022
4023 2019-02-22  Keith Seitz  <keiths@redhat.com>
4024
4025         PR symtab/23853
4026         * linespec.c (create_sals_line_offset): Search for the default
4027         symtab's filename instead of its fullname.
4028
4029 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4030
4031         * NEWS: Update style defaults.
4032
4033 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4034
4035         * main.c (captured_main_1): Disable styling in batch mode.
4036
4037 2019-02-20  Tom Tromey  <tom@tromey.com>
4038
4039         * symtab.c (symtab_symbol_info): Fix typos.
4040
4041 2019-02-20  Tom Tromey  <tromey@adacore.com>
4042
4043         * findcmd.c (_initialize_mem_search): Use upper case for
4044         metasyntactic variables.
4045
4046 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4047
4048         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4049         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4050
4051 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4052
4053         * top.h (source_file_name): Change to std::string.
4054         * top.c (source_file_name): Likewise.
4055         (command_line_input): Adjust.
4056         * cli/cli-script.c (script_from_file): Adjust.
4057
4058 2019-02-19  Tom Tromey  <tromey@adacore.com>
4059
4060         * ravenscar-thread.c
4061         (ravenscar_thread_target::update_thread_list): Don't call
4062         ada_build_task_list.
4063         * ada-lang.h (ada_build_task_list): Don't declare.
4064         * ada-tasks.c (struct ada_tasks_inferior_data)
4065         <task_list_valid_p>: Now bool.
4066         (read_known_tasks, ada_task_list_changed)
4067         (ada_tasks_invalidate_inferior_data): Update.
4068         (read_known_tasks_array): Return bool.
4069         (read_known_tasks_list): Likewise.
4070         (read_known_tasks): Return void.
4071         (ada_build_task_list): Now static.
4072
4073 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4074
4075         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4076         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4077
4078 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4079
4080         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4081         variant for ada_tasks_pspace_data_handle and
4082         ada_tasks_inferior_data_handle.
4083         (ada_tasks_pspace_data_cleanup): New function.
4084         (ada_tasks_inferior_data_cleanup): New function.
4085
4086 2019-02-17  Tom Tromey  <tom@tromey.com>
4087
4088         * macrotab.h (macro_source_fullname): Return a std::string.
4089         * macrotab.c (macro_include, check_for_redefinition)
4090         (macro_undef, macro_lookup_definition, foreach_macro)
4091         (foreach_macro_in_scope): Update.
4092         (macro_source_fullname): Return a std::string.
4093         * macrocmd.c (show_pp_source_pos): Update.
4094
4095 2019-02-17  Tom Tromey  <tom@tromey.com>
4096
4097         * macrocmd.c (show_pp_source_pos): Style the file names.
4098
4099 2019-02-17  Tom Tromey  <tom@tromey.com>
4100
4101         PR tui/24197:
4102         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4103
4104 2019-02-17  Tom Tromey  <tom@tromey.com>
4105
4106         * ada-lang.c (user_select_syms): Use filtered printing.
4107         * utils.c (wrap_style): New global.
4108         (desired_style): Remove.
4109         (emit_style_escape): Add stream parameter.
4110         (set_output_style, reset_terminal_style, prompt_for_continue):
4111         Update.
4112         (flush_wrap_buffer): Only flush gdb_stdout.
4113         (wrap_here): Set wrap_style.
4114         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4115         treat escape sequences as a character.  Change when wrap buffer is
4116         flushed.
4117         (fputs_styled): Do not set the output style when the default is
4118         requested.
4119         * ui-style.h (struct ui_file_style) <is_default>: New method.
4120         * source.c (print_source_lines_base): Emit escape sequences in one
4121         piece.
4122
4123 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4124
4125         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4126         integers and enumeration types.
4127
4128 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4129
4130         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4131         instead of lookup_symbol_in_language
4132         (do_exact_match): New function.
4133         (ada_get_symbol_name_matcher): Return do_exact_match when
4134         doing a verbatim match.
4135
4136 2019-02-15  Tom Tromey  <tromey@adacore.com>
4137
4138         * ravenscar-thread.c (ravenscar_thread_target::resume)
4139         (ravenscar_thread_target::wait): Special case wildcard requests.
4140
4141 2019-02-15  Tom Tromey  <tromey@adacore.com>
4142
4143         * ravenscar-thread.c (base_ptid): Remove.
4144         (struct ravenscar_thread_target) <close>: New method.
4145         <m_base_ptid>: New member.
4146         <update_inferior_ptid, active_task, task_is_currently_active,
4147         runtime_initialized>: Declare methods.
4148         <ravenscar_thread_target>: Add constructor.
4149         (ravenscar_thread_target::task_is_currently_active)
4150         (ravenscar_thread_target::update_inferior_ptid)
4151         (ravenscar_runtime_initialized): Rename.  Now methods.
4152         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4153         (ravenscar_thread_target::update_thread_list): Update.
4154         (ravenscar_thread_target::active_task): Now method.
4155         (ravenscar_thread_target::store_registers)
4156         (ravenscar_thread_target::prepare_to_store)
4157         (ravenscar_thread_target::prepare_to_store)
4158         (ravenscar_thread_target::mourn_inferior): Update.
4159         (ravenscar_inferior_created): Use "new" to create target.
4160         (ravenscar_thread_target::get_ada_task_ptid): Update.
4161         (_initialize_ravenscar): Don't initialize base_ptid.
4162         (ravenscar_ops): Remove global.
4163
4164 2019-02-15  Tom Tromey  <tromey@adacore.com>
4165
4166         * target.h (push_target): Declare new overload.
4167         * target.c (push_target): New overload, taking an rvalue reference.
4168         * remote.c (remote_target::open_1): Use push_target overload.
4169         * corelow.c (core_target_open): Use push_target overload.
4170
4171 2019-02-15  Tom Tromey  <tromey@adacore.com>
4172
4173         * ravenscar-thread.c (is_ravenscar_task)
4174         (ravenscar_task_is_currently_active): Return bool.
4175         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4176         (_initialize_ravenscar): Remove "(void)".
4177         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4178         Return bool.
4179
4180 2019-02-15  Tom Tromey  <tromey@adacore.com>
4181
4182         * ravenscar-thread.c (ravenscar_runtime_initializer)
4183         (has_ravenscar_runtime, get_running_thread_id)
4184         (ravenscar_thread_target::resume): Fix indentation.
4185
4186 2019-02-15  Tom Tromey  <tromey@adacore.com>
4187
4188         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4189         from ravenscar_arch_ops.
4190         (sparc_ravenscar_ops::fetch_registers)
4191         (sparc_ravenscar_ops::store_registers): Now methods.
4192         (sparc_ravenscar_prepare_to_store): Remove.
4193         (sparc_ravenscar_ops): Redefine.
4194         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4195         methods and destructor.  Remove members.
4196         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4197         (ravenscar_thread_target::store_registers)
4198         (ravenscar_thread_target::prepare_to_store): Update.
4199         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4200         Remove.
4201         (struct ppc_ravenscar_powerpc_ops): Derive from
4202         ravenscar_arch_ops.
4203         (ppc_ravenscar_powerpc_ops::fetch_registers)
4204         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4205         (ppc_ravenscar_powerpc_ops): Redefine.
4206         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4207         (ppc_ravenscar_e500_ops::fetch_registers)
4208         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4209         (ppc_ravenscar_e500_ops): Redefine.
4210         * aarch64-ravenscar-thread.c
4211         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4212         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4213         (aarch64_ravenscar_fetch_registers)
4214         (aarch64_ravenscar_store_registers): Now methods.
4215         (aarch64_ravenscar_ops): Redefine.
4216
4217 2019-02-15  Tom Tromey  <tromey@adacore.com>
4218
4219         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4220         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4221         (ravenscar_thread_target::stopped_by_watchpoint)
4222         (ravenscar_thread_target::stopped_data_address)
4223         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4224
4225 2019-02-15  Tom Tromey  <tromey@adacore.com>
4226
4227         * ravenscar-thread.c: Fix some typos.
4228
4229 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4230             Tom Tromey  <tromey@adacore.com>
4231
4232         * ada-lang.c (ada_exception_sal): Change addr_string to a
4233         std::string.
4234         (create_ada_exception_catchpoint): Update.
4235
4236 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4237             Tom Tromey  <tromey@adacore.com>
4238
4239         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4240         (bp_location_ops): Remove.
4241         (base_breakpoint_allocate_location): Update.
4242         (free_bp_location): Update.
4243         * ada-lang.c (class ada_catchpoint_location)
4244         <ada_catchpoint_location>: Remove ops parameter.
4245         (ada_catchpoint_location_dtor): Remove.
4246         (ada_catchpoint_location_ops): Remove.
4247         (allocate_location_exception): Update.
4248         * breakpoint.h (struct bp_location_ops): Remove.
4249         (class bp_location) <bp_location>: Remove bp_location_ops
4250         parameter.
4251         <~bp_location>: Add destructor.
4252         <ops>: Remove.
4253
4254 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4255             Pedro Alves  <palves@redhat.com>
4256
4257         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4258         'PATH_MAX'.
4259
4260 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4261             Samuel Thibault  <samuel.thibault@gnu.org>
4262             Thomas Schwinge  <thomas@codesourcery.com>
4263
4264         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4265         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4266
4267 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4268
4269         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4270         (check_empty): Use "const char *".
4271
4272         * gnu-nat.c (gnu_nat_target::detach): Instead of
4273         'detach_inferior (pid)' call
4274         'detach_inferior (find_inferior_pid (pid))'.
4275
4276         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4277         'nat/fork-inferior.o'.
4278         * gnu-nat.c: #include "nat/fork-inferior.h".
4279
4280         * gnu-nat.c (gnu_nat_target::detach): Instead of
4281         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4282         * gnu-nat.h: #include "inf-child.h".
4283         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4284         'i386_gnu_nat_target::fetch_registers'.
4285         (gnu_store_registers): Rename/move to
4286         'i386_gnu_nat_target::store_registers'.
4287
4288         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4289         * gnu-nat.h (mach_thread_info): New function.
4290         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4291
4292         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4293
4294 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4295
4296         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4297
4298 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4299
4300         * windows-nat.c (windows_add_thread): Add new parameter
4301         "main_thread_p" with default value set to false.  Update
4302         function documentation as well as all callers.
4303         (windows_delete_thread): Likewise.
4304         (fake_create_process): Update call to windows_add_thread.
4305         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4306         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4307         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4308         call to windows_delete_thread.
4309
4310 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4311
4312         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4313
4314 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4315
4316         * symfile.c (find_separate_debug_file): Use canonical path of
4317         sysroot with child_path instead of gdb_sysroot if it is valid.
4318
4319 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4320
4321         * symfile.c (find_separate_debug_file): Use child_path to
4322         determine if an object file is under a sysroot.
4323
4324 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4325
4326         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4327         unittests/child-path-selftests.c.
4328         * common/pathstuff.c (child_path): New function.
4329         * common/pathstuff.h (child_path): New prototype.
4330         * unittests/child-path-selftests.c: New file.
4331
4332 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4333
4334         * symfile.c (find_separate_debug_file): Look for separate debug
4335         files in debug directories under the sysroot.
4336
4337 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4338
4339         * symtab.h (struct minimal_symbol data_p): New const method.
4340         (struct minimal_symbol text_p): Likewise.
4341         * symtab.c (output_source_filename): Use file name style
4342         to print file name.
4343         (print_symbol_info): Likewise.
4344         (print_msymbol_info): Use address style to print addresses.
4345         Use function name style to print executable text symbols.
4346         (expand_symtab_containing_pc): Use data_p.
4347         (find_pc_sect_compunit_symtab): Likewise.
4348
4349 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4350
4351         * breakpoint.c (describe_other_breakpoints): Use address style
4352         to print addresses.
4353         (say_where): Likewise.
4354
4355 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4356
4357         * ada-typeprint.c (print_func_type): Print function name
4358         style to print function name.
4359         * c-typeprint.c (c_print_type_1): Likewise.
4360
4361 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4362
4363         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4364         for execve.
4365
4366 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4367
4368         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4369         type_stack.
4370
4371 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4372
4373         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4374         TYPE_CODE_REF types.
4375
4376 2019-02-08  Jim Wilson  <jimw@sifive.com>
4377
4378         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4379         (riscv_linux_fregset): New.
4380         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4381
4382 2019-02-07  Tom Tromey  <tom@tromey.com>
4383
4384         * thread.c (thread_cancel_execution_command): Update.
4385         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4386         methods.
4387         (struct thread_fsm_ops): Remove.
4388         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4389         (thread_fsm_should_stop, thread_fsm_return_value)
4390         (thread_fsm_set_finished, thread_fsm_finished_p)
4391         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4392         Don't declare.
4393         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4394         * infrun.c (clear_proceed_status_thread)
4395         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4396         (print_stop_event): Update.
4397         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4398         Add constructor.
4399         (step_command_fsm_ops): Remove.
4400         (new_step_command_fsm): Remove.
4401         (step_1): Update.
4402         (step_command_fsm::should_stop): Rename from
4403         step_command_fsm_should_stop.
4404         (step_command_fsm::clean_up): Rename from
4405         step_command_fsm_clean_up.
4406         (step_command_fsm::do_async_reply_reason): Rename from
4407         step_command_fsm_async_reply_reason.
4408         (struct until_next_fsm): Inherit from thread_fsm.  Add
4409         constructor.
4410         (until_next_fsm_ops): Remove.
4411         (new_until_next_fsm): Remove.
4412         (until_next_fsm::should_stop): Rename from
4413         until_next_fsm_should_stop.
4414         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4415         (until_next_fsm::do_async_reply_reason): Rename from
4416         until_next_fsm_async_reply_reason.
4417         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4418         constructor.  Change type of breakpoint.
4419         (finish_command_fsm_ops): Remove.
4420         (new_finish_command_fsm): Remove.
4421         (finish_command_fsm::should_stop): Rename from
4422         finish_command_fsm_should_stop.
4423         (finish_command_fsm::clean_up): Rename from
4424         finish_command_fsm_clean_up.
4425         (finish_command_fsm::return_value): Rename from
4426         finish_command_fsm_return_value.
4427         (finish_command_fsm::do_async_reply_reason): Rename from
4428         finish_command_fsm_async_reply_reason.
4429         (finish_command): Update.
4430         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4431         Add constructor.
4432         (call_thread_fsm_ops): Remove.
4433         (call_thread_fsm::call_thread_fsm): Rename from
4434         new_call_thread_fsm.
4435         (call_thread_fsm::should_stop): Rename from
4436         call_thread_fsm_should_stop.
4437         (call_thread_fsm::should_notify_stop): Rename from
4438         call_thread_fsm_should_notify_stop.
4439         (run_inferior_call, call_function_by_hand_dummy): Update.
4440         * cli/cli-interp.c (should_print_stop_to_console): Update.
4441         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4442         Add constructor.  Change type of location_breakpoint,
4443         caller_breakpoint.
4444         (until_break_fsm_ops): Remove.
4445         (new_until_break_fsm): Remove.
4446         (until_break_fsm::should_stop): Rename from
4447         until_break_fsm_should_stop.
4448         (until_break_fsm::clean_up): Rename from
4449         until_break_fsm_clean_up.
4450         (until_break_fsm::do_async_reply_reason): Rename from
4451         until_break_fsm_async_reply_reason.
4452         (until_break_command): Update.
4453         * thread-fsm.c: Remove.
4454         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4455
4456 2019-02-07  Tom Tromey  <tom@tromey.com>
4457
4458         * yy-remap.h: Add include guard.
4459         * xtensa-tdep.h: Add include guard.
4460         * xcoffread.h: Rename include guard.
4461         * varobj-iter.h: Add include guard.
4462         * tui/tui.h: Rename include guard.
4463         * tui/tui-winsource.h: Rename include guard.
4464         * tui/tui-wingeneral.h: Rename include guard.
4465         * tui/tui-windata.h: Rename include guard.
4466         * tui/tui-win.h: Rename include guard.
4467         * tui/tui-stack.h: Rename include guard.
4468         * tui/tui-source.h: Rename include guard.
4469         * tui/tui-regs.h: Rename include guard.
4470         * tui/tui-out.h: Rename include guard.
4471         * tui/tui-layout.h: Rename include guard.
4472         * tui/tui-io.h: Rename include guard.
4473         * tui/tui-hooks.h: Rename include guard.
4474         * tui/tui-file.h: Rename include guard.
4475         * tui/tui-disasm.h: Rename include guard.
4476         * tui/tui-data.h: Rename include guard.
4477         * tui/tui-command.h: Rename include guard.
4478         * tic6x-tdep.h: Add include guard.
4479         * target/waitstatus.h: Rename include guard.
4480         * target/wait.h: Rename include guard.
4481         * target/target.h: Rename include guard.
4482         * target/resume.h: Rename include guard.
4483         * target-float.h: Rename include guard.
4484         * stabsread.h: Add include guard.
4485         * rs6000-tdep.h: Add include guard.
4486         * riscv-fbsd-tdep.h: Add include guard.
4487         * regformats/regdef.h: Rename include guard.
4488         * record.h: Rename include guard.
4489         * python/python.h: Rename include guard.
4490         * python/python-internal.h: Rename include guard.
4491         * python/py-stopevent.h: Rename include guard.
4492         * python/py-ref.h: Rename include guard.
4493         * python/py-record.h: Rename include guard.
4494         * python/py-record-full.h: Rename include guard.
4495         * python/py-record-btrace.h: Rename include guard.
4496         * python/py-instruction.h: Rename include guard.
4497         * python/py-events.h: Rename include guard.
4498         * python/py-event.h: Rename include guard.
4499         * procfs.h: Add include guard.
4500         * proc-utils.h: Add include guard.
4501         * p-lang.h: Add include guard.
4502         * or1k-tdep.h: Rename include guard.
4503         * observable.h: Rename include guard.
4504         * nto-tdep.h: Rename include guard.
4505         * nat/x86-linux.h: Rename include guard.
4506         * nat/x86-linux-dregs.h: Rename include guard.
4507         * nat/x86-gcc-cpuid.h: Add include guard.
4508         * nat/x86-dregs.h: Rename include guard.
4509         * nat/x86-cpuid.h: Rename include guard.
4510         * nat/ppc-linux.h: Rename include guard.
4511         * nat/mips-linux-watch.h: Rename include guard.
4512         * nat/linux-waitpid.h: Rename include guard.
4513         * nat/linux-ptrace.h: Rename include guard.
4514         * nat/linux-procfs.h: Rename include guard.
4515         * nat/linux-osdata.h: Rename include guard.
4516         * nat/linux-nat.h: Rename include guard.
4517         * nat/linux-namespaces.h: Rename include guard.
4518         * nat/linux-btrace.h: Rename include guard.
4519         * nat/glibc_thread_db.h: Rename include guard.
4520         * nat/gdb_thread_db.h: Rename include guard.
4521         * nat/gdb_ptrace.h: Rename include guard.
4522         * nat/fork-inferior.h: Rename include guard.
4523         * nat/amd64-linux-siginfo.h: Rename include guard.
4524         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4525         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4526         * nat/aarch64-linux.h: Rename include guard.
4527         * nat/aarch64-linux-hw-point.h: Rename include guard.
4528         * mn10300-tdep.h: Add include guard.
4529         * mips-linux-tdep.h: Add include guard.
4530         * mi/mi-parse.h: Rename include guard.
4531         * mi/mi-out.h: Rename include guard.
4532         * mi/mi-main.h: Rename include guard.
4533         * mi/mi-interp.h: Rename include guard.
4534         * mi/mi-getopt.h: Rename include guard.
4535         * mi/mi-console.h: Rename include guard.
4536         * mi/mi-common.h: Rename include guard.
4537         * mi/mi-cmds.h: Rename include guard.
4538         * mi/mi-cmd-break.h: Rename include guard.
4539         * m2-lang.h: Add include guard.
4540         * location.h: Rename include guard.
4541         * linux-record.h: Rename include guard.
4542         * linux-nat.h: Add include guard.
4543         * linux-fork.h: Add include guard.
4544         * i386-darwin-tdep.h: Rename include guard.
4545         * hppa-linux-offsets.h: Add include guard.
4546         * guile/guile.h: Rename include guard.
4547         * guile/guile-internal.h: Rename include guard.
4548         * gnu-nat.h: Rename include guard.
4549         * gdb-stabs.h: Rename include guard.
4550         * frv-tdep.h: Add include guard.
4551         * f-lang.h: Add include guard.
4552         * event-loop.h: Add include guard.
4553         * darwin-nat.h: Rename include guard.
4554         * cp-abi.h: Rename include guard.
4555         * config/sparc/nm-sol2.h: Rename include guard.
4556         * config/nm-nto.h: Rename include guard.
4557         * config/nm-linux.h: Add include guard.
4558         * config/i386/nm-i386gnu.h: Rename include guard.
4559         * config/djgpp/nl_types.h: Rename include guard.
4560         * config/djgpp/langinfo.h: Rename include guard.
4561         * compile/gcc-cp-plugin.h: Add include guard.
4562         * compile/gcc-c-plugin.h: Add include guard.
4563         * compile/compile.h: Rename include guard.
4564         * compile/compile-object-run.h: Rename include guard.
4565         * compile/compile-object-load.h: Rename include guard.
4566         * compile/compile-internal.h: Rename include guard.
4567         * compile/compile-cplus.h: Rename include guard.
4568         * compile/compile-c.h: Rename include guard.
4569         * common/xml-utils.h: Rename include guard.
4570         * common/x86-xstate.h: Rename include guard.
4571         * common/version.h: Rename include guard.
4572         * common/vec.h: Rename include guard.
4573         * common/tdesc.h: Rename include guard.
4574         * common/selftest.h: Rename include guard.
4575         * common/scoped_restore.h: Rename include guard.
4576         * common/scoped_mmap.h: Rename include guard.
4577         * common/scoped_fd.h: Rename include guard.
4578         * common/safe-iterator.h: Rename include guard.
4579         * common/run-time-clock.h: Rename include guard.
4580         * common/refcounted-object.h: Rename include guard.
4581         * common/queue.h: Rename include guard.
4582         * common/ptid.h: Rename include guard.
4583         * common/print-utils.h: Rename include guard.
4584         * common/preprocessor.h: Rename include guard.
4585         * common/pathstuff.h: Rename include guard.
4586         * common/observable.h: Rename include guard.
4587         * common/netstuff.h: Rename include guard.
4588         * common/job-control.h: Rename include guard.
4589         * common/host-defs.h: Rename include guard.
4590         * common/gdb_wait.h: Rename include guard.
4591         * common/gdb_vecs.h: Rename include guard.
4592         * common/gdb_unlinker.h: Rename include guard.
4593         * common/gdb_unique_ptr.h: Rename include guard.
4594         * common/gdb_tilde_expand.h: Rename include guard.
4595         * common/gdb_sys_time.h: Rename include guard.
4596         * common/gdb_string_view.h: Rename include guard.
4597         * common/gdb_splay_tree.h: Rename include guard.
4598         * common/gdb_setjmp.h: Rename include guard.
4599         * common/gdb_ref_ptr.h: Rename include guard.
4600         * common/gdb_optional.h: Rename include guard.
4601         * common/gdb_locale.h: Rename include guard.
4602         * common/gdb_assert.h: Rename include guard.
4603         * common/filtered-iterator.h: Rename include guard.
4604         * common/filestuff.h: Rename include guard.
4605         * common/fileio.h: Rename include guard.
4606         * common/environ.h: Rename include guard.
4607         * common/common-utils.h: Rename include guard.
4608         * common/common-types.h: Rename include guard.
4609         * common/common-regcache.h: Rename include guard.
4610         * common/common-inferior.h: Rename include guard.
4611         * common/common-gdbthread.h: Rename include guard.
4612         * common/common-exceptions.h: Rename include guard.
4613         * common/common-defs.h: Rename include guard.
4614         * common/common-debug.h: Rename include guard.
4615         * common/cleanups.h: Rename include guard.
4616         * common/buffer.h: Rename include guard.
4617         * common/btrace-common.h: Rename include guard.
4618         * common/break-common.h: Rename include guard.
4619         * cli/cli-utils.h: Rename include guard.
4620         * cli/cli-style.h: Rename include guard.
4621         * cli/cli-setshow.h: Rename include guard.
4622         * cli/cli-script.h: Rename include guard.
4623         * cli/cli-interp.h: Rename include guard.
4624         * cli/cli-decode.h: Rename include guard.
4625         * cli/cli-cmds.h: Rename include guard.
4626         * charset-list.h: Add include guard.
4627         * buildsym-legacy.h: Rename include guard.
4628         * bfin-tdep.h: Add include guard.
4629         * ax.h: Rename include guard.
4630         * arm-linux-tdep.h: Add include guard.
4631         * arm-fbsd-tdep.h: Add include guard.
4632         * arch/xtensa.h: Rename include guard.
4633         * arch/tic6x.h: Add include guard.
4634         * arch/i386.h: Add include guard.
4635         * arch/arm.h: Rename include guard.
4636         * arch/arm-linux.h: Rename include guard.
4637         * arch/arm-get-next-pcs.h: Rename include guard.
4638         * arch/amd64.h: Add include guard.
4639         * arch/aarch64-insn.h: Rename include guard.
4640         * arch-utils.h: Rename include guard.
4641         * annotate.h: Add include guard.
4642         * amd64-darwin-tdep.h: Rename include guard.
4643         * aarch64-linux-tdep.h: Add include guard.
4644         * aarch64-fbsd-tdep.h: Add include guard.
4645         * aarch32-linux-nat.h: Add include guard.
4646
4647 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4648
4649         * macrotab.c (macro_define_internal): New function that
4650         factorizes macro_define_object_internal and macro_define_function
4651         code.
4652         (macro_define_object_internal): Use macro_define_internal.
4653         (macro_define_function): Likewise.
4654
4655 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4656
4657         * macrocmd.c (extract_identifier): Return
4658         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4659         callers.
4660
4661 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4662
4663         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4664
4665 2019-02-05  Tom Tromey  <tom@tromey.com>
4666
4667         * target.c (target_stack::unpush): Move assertion earlier.
4668
4669 2019-01-30  Tom Tromey  <tom@tromey.com>
4670
4671         PR python/23615:
4672         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4673         (gdbpy_parse_and_eval): Likewise.
4674         * python/python-internal.h (gdbpy_allow_threads): New class.
4675
4676 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4677
4678         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4679         (aarch64_fbsd_fpregmap): Move earlier.
4680         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4681         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4682         instead of individual calls to trad_frame_set_reg_addr.
4683         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4684         earlier.
4685         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4686         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4687         instead of individual calls to trad_frame_set_reg_addr.
4688
4689 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4690
4691         * CONTRIBUTE: Replace contribution list with wiki link.
4692
4693 2019-01-25  Tom Tromey  <tom@tromey.com>
4694
4695         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4696
4697 2019-01-25  Tom Tromey  <tom@tromey.com>
4698
4699         * xtensa-linux-nat.c: Fix common/ includes.
4700         * xml-support.h: Fix common/ includes.
4701         * xml-support.c: Fix common/ includes.
4702         * x86-linux-nat.c: Fix common/ includes.
4703         * windows-nat.c: Fix common/ includes.
4704         * varobj.h: Fix common/ includes.
4705         * varobj.c: Fix common/ includes.
4706         * value.c: Fix common/ includes.
4707         * valops.c: Fix common/ includes.
4708         * utils.c: Fix common/ includes.
4709         * unittests/xml-utils-selftests.c: Fix common/ includes.
4710         * unittests/utils-selftests.c: Fix common/ includes.
4711         * unittests/unpack-selftests.c: Fix common/ includes.
4712         * unittests/tracepoint-selftests.c: Fix common/ includes.
4713         * unittests/style-selftests.c: Fix common/ includes.
4714         * unittests/string_view-selftests.c: Fix common/ includes.
4715         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4716         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4717         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4718         * unittests/rsp-low-selftests.c: Fix common/ includes.
4719         * unittests/parse-connection-spec-selftests.c: Fix common/
4720         includes.
4721         * unittests/optional-selftests.c: Fix common/ includes.
4722         * unittests/offset-type-selftests.c: Fix common/ includes.
4723         * unittests/observable-selftests.c: Fix common/ includes.
4724         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4725         * unittests/memrange-selftests.c: Fix common/ includes.
4726         * unittests/memory-map-selftests.c: Fix common/ includes.
4727         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4728         * unittests/function-view-selftests.c: Fix common/ includes.
4729         * unittests/environ-selftests.c: Fix common/ includes.
4730         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4731         * unittests/common-utils-selftests.c: Fix common/ includes.
4732         * unittests/cli-utils-selftests.c: Fix common/ includes.
4733         * unittests/array-view-selftests.c: Fix common/ includes.
4734         * ui-file.c: Fix common/ includes.
4735         * tui/tui-io.c: Fix common/ includes.
4736         * tracepoint.h: Fix common/ includes.
4737         * tracepoint.c: Fix common/ includes.
4738         * tracefile-tfile.c: Fix common/ includes.
4739         * top.h: Fix common/ includes.
4740         * top.c: Fix common/ includes.
4741         * thread.c: Fix common/ includes.
4742         * target/waitstatus.h: Fix common/ includes.
4743         * target/waitstatus.c: Fix common/ includes.
4744         * target.h: Fix common/ includes.
4745         * target.c: Fix common/ includes.
4746         * target-memory.c: Fix common/ includes.
4747         * target-descriptions.c: Fix common/ includes.
4748         * symtab.h: Fix common/ includes.
4749         * symfile.c: Fix common/ includes.
4750         * stap-probe.c: Fix common/ includes.
4751         * spu-linux-nat.c: Fix common/ includes.
4752         * sparc-nat.c: Fix common/ includes.
4753         * source.c: Fix common/ includes.
4754         * solib.c: Fix common/ includes.
4755         * solib-target.c: Fix common/ includes.
4756         * ser-unix.c: Fix common/ includes.
4757         * ser-tcp.c: Fix common/ includes.
4758         * ser-pipe.c: Fix common/ includes.
4759         * ser-base.c: Fix common/ includes.
4760         * selftest-arch.c: Fix common/ includes.
4761         * s12z-tdep.c: Fix common/ includes.
4762         * rust-exp.y: Fix common/ includes.
4763         * rs6000-aix-tdep.c: Fix common/ includes.
4764         * riscv-tdep.c: Fix common/ includes.
4765         * remote.c: Fix common/ includes.
4766         * remote-notif.h: Fix common/ includes.
4767         * remote-fileio.h: Fix common/ includes.
4768         * remote-fileio.c: Fix common/ includes.
4769         * regcache.h: Fix common/ includes.
4770         * regcache.c: Fix common/ includes.
4771         * record-btrace.c: Fix common/ includes.
4772         * python/python.c: Fix common/ includes.
4773         * python/py-type.c: Fix common/ includes.
4774         * python/py-inferior.c: Fix common/ includes.
4775         * progspace.h: Fix common/ includes.
4776         * producer.c: Fix common/ includes.
4777         * procfs.c: Fix common/ includes.
4778         * proc-api.c: Fix common/ includes.
4779         * printcmd.c: Fix common/ includes.
4780         * ppc-linux-nat.c: Fix common/ includes.
4781         * parser-defs.h: Fix common/ includes.
4782         * osdata.c: Fix common/ includes.
4783         * obsd-nat.c: Fix common/ includes.
4784         * nat/x86-linux.c: Fix common/ includes.
4785         * nat/x86-linux-dregs.c: Fix common/ includes.
4786         * nat/x86-dregs.h: Fix common/ includes.
4787         * nat/x86-dregs.c: Fix common/ includes.
4788         * nat/ppc-linux.c: Fix common/ includes.
4789         * nat/mips-linux-watch.h: Fix common/ includes.
4790         * nat/mips-linux-watch.c: Fix common/ includes.
4791         * nat/linux-waitpid.c: Fix common/ includes.
4792         * nat/linux-ptrace.h: Fix common/ includes.
4793         * nat/linux-ptrace.c: Fix common/ includes.
4794         * nat/linux-procfs.c: Fix common/ includes.
4795         * nat/linux-personality.c: Fix common/ includes.
4796         * nat/linux-osdata.c: Fix common/ includes.
4797         * nat/linux-namespaces.c: Fix common/ includes.
4798         * nat/linux-btrace.h: Fix common/ includes.
4799         * nat/linux-btrace.c: Fix common/ includes.
4800         * nat/fork-inferior.c: Fix common/ includes.
4801         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4802         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4803         * nat/aarch64-linux.c: Fix common/ includes.
4804         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4805         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4806         * namespace.h: Fix common/ includes.
4807         * mips-linux-tdep.c: Fix common/ includes.
4808         * minsyms.c: Fix common/ includes.
4809         * mi/mi-parse.h: Fix common/ includes.
4810         * mi/mi-main.c: Fix common/ includes.
4811         * mi/mi-cmd-env.c: Fix common/ includes.
4812         * memrange.h: Fix common/ includes.
4813         * memattr.c: Fix common/ includes.
4814         * maint.h: Fix common/ includes.
4815         * maint.c: Fix common/ includes.
4816         * main.c: Fix common/ includes.
4817         * machoread.c: Fix common/ includes.
4818         * location.c: Fix common/ includes.
4819         * linux-thread-db.c: Fix common/ includes.
4820         * linux-nat.c: Fix common/ includes.
4821         * linux-fork.c: Fix common/ includes.
4822         * inline-frame.c: Fix common/ includes.
4823         * infrun.c: Fix common/ includes.
4824         * inflow.c: Fix common/ includes.
4825         * inferior.h: Fix common/ includes.
4826         * inferior.c: Fix common/ includes.
4827         * infcmd.c: Fix common/ includes.
4828         * inf-ptrace.c: Fix common/ includes.
4829         * inf-child.c: Fix common/ includes.
4830         * ia64-linux-nat.c: Fix common/ includes.
4831         * i387-tdep.c: Fix common/ includes.
4832         * i386-tdep.c: Fix common/ includes.
4833         * i386-linux-tdep.c: Fix common/ includes.
4834         * i386-linux-nat.c: Fix common/ includes.
4835         * i386-go32-tdep.c: Fix common/ includes.
4836         * i386-fbsd-tdep.c: Fix common/ includes.
4837         * i386-fbsd-nat.c: Fix common/ includes.
4838         * guile/scm-type.c: Fix common/ includes.
4839         * guile/guile.c: Fix common/ includes.
4840         * go32-nat.c: Fix common/ includes.
4841         * gnu-nat.c: Fix common/ includes.
4842         * gdbthread.h: Fix common/ includes.
4843         * gdbarch-selftests.c: Fix common/ includes.
4844         * gdb_usleep.c: Fix common/ includes.
4845         * gdb_select.h: Fix common/ includes.
4846         * gdb_bfd.c: Fix common/ includes.
4847         * gcore.c: Fix common/ includes.
4848         * fork-child.c: Fix common/ includes.
4849         * findvar.c: Fix common/ includes.
4850         * fbsd-nat.c: Fix common/ includes.
4851         * event-top.c: Fix common/ includes.
4852         * event-loop.c: Fix common/ includes.
4853         * dwarf2read.c: Fix common/ includes.
4854         * dwarf2loc.c: Fix common/ includes.
4855         * dwarf2-frame.c: Fix common/ includes.
4856         * dwarf-index-cache.c: Fix common/ includes.
4857         * dtrace-probe.c: Fix common/ includes.
4858         * disasm-selftests.c: Fix common/ includes.
4859         * defs.h: Fix common/ includes.
4860         * csky-tdep.c: Fix common/ includes.
4861         * cp-valprint.c: Fix common/ includes.
4862         * cp-support.h: Fix common/ includes.
4863         * cp-support.c: Fix common/ includes.
4864         * corelow.c: Fix common/ includes.
4865         * completer.h: Fix common/ includes.
4866         * completer.c: Fix common/ includes.
4867         * compile/compile.c: Fix common/ includes.
4868         * compile/compile-loc2c.c: Fix common/ includes.
4869         * compile/compile-cplus-types.c: Fix common/ includes.
4870         * compile/compile-cplus-symbols.c: Fix common/ includes.
4871         * command.h: Fix common/ includes.
4872         * cli/cli-dump.c: Fix common/ includes.
4873         * cli/cli-cmds.c: Fix common/ includes.
4874         * charset.c: Fix common/ includes.
4875         * build-id.c: Fix common/ includes.
4876         * btrace.h: Fix common/ includes.
4877         * btrace.c: Fix common/ includes.
4878         * breakpoint.h: Fix common/ includes.
4879         * breakpoint.c: Fix common/ includes.
4880         * ax.h:
4881         (enum agent_op): Fix common/ includes.
4882         * ax-general.c (struct aop_map): Fix common/ includes.
4883         * ax-gdb.c: Fix common/ includes.
4884         * auxv.c: Fix common/ includes.
4885         * auto-load.c: Fix common/ includes.
4886         * arm-tdep.c: Fix common/ includes.
4887         * arch/riscv.c: Fix common/ includes.
4888         * arch/ppc-linux-common.c: Fix common/ includes.
4889         * arch/i386.c: Fix common/ includes.
4890         * arch/arm.c: Fix common/ includes.
4891         * arch/arm-linux.c: Fix common/ includes.
4892         * arch/arm-get-next-pcs.c: Fix common/ includes.
4893         * arch/amd64.c: Fix common/ includes.
4894         * arch/aarch64.c: Fix common/ includes.
4895         * arch/aarch64-insn.c: Fix common/ includes.
4896         * arch-utils.c: Fix common/ includes.
4897         * amd64-windows-tdep.c: Fix common/ includes.
4898         * amd64-tdep.c: Fix common/ includes.
4899         * amd64-sol2-tdep.c: Fix common/ includes.
4900         * amd64-obsd-tdep.c: Fix common/ includes.
4901         * amd64-nbsd-tdep.c: Fix common/ includes.
4902         * amd64-linux-tdep.c: Fix common/ includes.
4903         * amd64-linux-nat.c: Fix common/ includes.
4904         * amd64-fbsd-tdep.c: Fix common/ includes.
4905         * amd64-fbsd-nat.c: Fix common/ includes.
4906         * amd64-dicos-tdep.c: Fix common/ includes.
4907         * amd64-darwin-tdep.c: Fix common/ includes.
4908         * agent.c: Fix common/ includes.
4909         * ada-lang.h: Fix common/ includes.
4910         * ada-lang.c: Fix common/ includes.
4911         * aarch64-tdep.c: Fix common/ includes.
4912
4913 2019-01-25  Tom Tromey  <tom@tromey.com>
4914
4915         * common/create-version.sh: Use common/version.h.
4916
4917 2019-01-24  Pedro Alves  <palves@redhat.com>
4918
4919         * infrun.c (signal_stop, signal_print, signal_program)
4920         (signal_catch, signal_pass): Now arrays instead of pointers.
4921         (update_signals_program_target, do_target_resume)
4922         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4923         * linux-nat.c (linux_nat_target::pass_signals)
4924         (linux_nat_target::create_inferior, linux_nat_target::attach):
4925         Adjust.
4926         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4927         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4928         * procfs.c (procfs_target::pass_signals): Adjust.
4929         * record-full.c (record_full_target::resume): Adjust.
4930         * remote.c (remote_target::pass_signals)
4931         (remote_target::program_signals): Adjust.
4932         * target-debug.h (target_debug_print_signals): Now takes a
4933         gdb::array_view as parameter.  Adjust.
4934         * target.h (target_ops) <pass_signals, program_signals>: Replace
4935         pointer and length parameters with gdb::array_view.
4936         (target_pass_signals, target_program_signals): Likewise.
4937         * target-delegates.c: Regenerate.
4938
4939 2019-01-24  Pedro Alves  <palves@redhat.com>
4940
4941         * common/forward-scope-exit.h
4942         (forward_scope_exit::forward_scope_exit): Pass arguments to
4943         m_bind_function directly, instead of creating a std::bind and
4944         copying that.
4945
4946 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4947
4948         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4949         for static members.
4950         (pass_in_v_vfp_candidate): Likewise.
4951
4952 2019-01-23  Tom Tromey  <tom@tromey.com>
4953             Pedro Alves  <palves@redhat.com>
4954
4955         * regcache.c (class regcache_invalidator): Remove.
4956         (regcache::raw_write): Use make_scope_exit.
4957
4958 2019-01-23  Tom Tromey  <tom@tromey.com>
4959
4960         * ui-out.h (class ui_out_emit_type): Update comment.
4961
4962 2019-01-23  Tom Tromey  <tom@tromey.com>
4963
4964         * infrun.c (fetch_inferior_event): Update comment.
4965
4966 2019-01-23  Tom Tromey  <tom@tromey.com>
4967             Pedro Alves  <palves@redhat.com>
4968
4969         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4970         parameter.
4971         (fetch_inferior_event): Use SCOPE_EXIT.
4972
4973
4974 2019-01-23  Tom Tromey  <tom@tromey.com>
4975             Pedro Alves  <palves@redhat.com>
4976
4977         * infrun.c (disable_thread_events): Delete.
4978         (stop_all_threads): Use SCOPE_EXIT.
4979
4980 2019-01-23  Tom Tromey  <tom@tromey.com>
4981             Pedro Alves  <palves@redhat.com>
4982
4983         * symfile.c: Include forward-scope-exit.h.
4984         (clear_symtab_users_cleanup): Replace forward declaration with
4985         a FORWARD_SCOPE_EXIT.
4986         (syms_from_objfile_1): Use the forward_scope_exit and
4987         gdb::optional instead of cleanup_function.
4988         (reread_symbols): Use the forward_scope_exit instead of
4989         cleanup_function.
4990         (clear_symtab_users_cleanup): Remove function.
4991
4992 2019-01-23  Tom Tromey  <tom@tromey.com>
4993             Pedro Alves  <palves@redhat.com>
4994
4995         * linux-nat.c: Include scope-exit.h.
4996         (cleanup_target_stop): Remove.
4997         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4998         SCOPE_EXIT.
4999
5000 2019-01-23  Tom Tromey  <tom@tromey.com>
5001             Pedro Alves  <palves@redhat.com>
5002
5003         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5004         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5005
5006 2019-01-23  Tom Tromey  <tom@tromey.com>
5007             Andrew Burgess  <andrew.burgess@embecosm.com>
5008             Pedro Alves  <palves@redhat.com>
5009
5010         * infrun.c (fetch_inferior_event): Use scope_exit.
5011         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5012         * top.c (execute_command): Use scope_exit.
5013         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5014         * utils.c (do_bpstat_clear_actions_cleanup)
5015         (make_bpstat_clear_actions_cleanup): Remove.
5016
5017 2019-01-23  Tom Tromey  <tom@tromey.com>
5018             Pedro Alves  <palves@redhat.com>
5019
5020         * infrun.c: Include "common/scope-exit.h"
5021         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5022         (wait_for_inferior): Use SCOPE_EXIT.
5023         (fetch_inferior_event): Use scope_exit.
5024
5025 2019-01-23  Tom Tromey  <tom@tromey.com>
5026             Pedro Alves  <palves@redhat.com>
5027
5028         * breakpoint.c (create_breakpoint): Remove cleanup.
5029
5030 2019-01-23  Tom Tromey  <tom@tromey.com>
5031             Andrew Burgess  <andrew.burgess@embecosm.com>
5032             Pedro Alves  <palves@redhat.com>
5033
5034 2019-01-23  Pedro Alves  <palves@redhat.com>
5035
5036         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5037
5038 2019-01-23  Pedro Alves  <palves@redhat.com>
5039             Andrew Burgess  <andrew.burgess@embecosm.com>
5040
5041         * gdbthread.h: Include "common/forward-scope-exit.h".
5042         (scoped_finish_thread_state): Redefine custom class in terms of
5043         forward_scope_exit.
5044
5045 2019-01-23  Pedro Alves  <palves@redhat.com>
5046             Andrew Burgess  <andrew.burgess@embecosm.com>
5047
5048         * common/forward-scope-exit.h: New file.
5049
5050 2019-01-23  Pedro Alves  <palves@redhat.com>
5051             Andrew Burgess  <andrew.burgess@embecosm.com>
5052             Tom Tromey  <tom@tromey.com>
5053
5054         * common/scope-exit.h: New file.
5055
5056 2019-01-23  Pedro Alves  <palves@redhat.com>
5057
5058         * common/preprocessor.h (ESC): Rename to ...
5059         (ESC_PARENS): ... this.
5060         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5061         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5062
5063 2019-01-23  Tom Tromey  <tom@tromey.com>
5064
5065         * language.h (class scoped_switch_to_sym_language_if_auto):
5066         Initialize m_lang in both cases.
5067
5068 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5069
5070         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5071         with XCNEW.
5072
5073 2019-01-22  Tom Tromey  <tom@tromey.com>
5074
5075         * corelow.c: Do not include sys/file.h.
5076
5077 2019-01-22  Tom Tromey  <tom@tromey.com>
5078
5079         * tui/tui-wingeneral.h: Include gdb_curses.h.
5080
5081 2019-01-22  Tom Tromey  <tom@tromey.com>
5082
5083         * source-cache.h (class source_cache) <get_source_lines,
5084         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5085
5086 2019-01-22  Tom Tromey  <tom@tromey.com>
5087
5088         * remote-fileio.h (struct remote_target): Declare.
5089
5090 2019-01-22  Tom Tromey  <tom@tromey.com>
5091
5092         * python/py-arch.c: Do not include py-ref.h.
5093         * python/py-bpevent.c: Do not include py-ref.h.
5094         * python/py-cmd.c: Do not include py-ref.h.
5095         * python/py-continueevent.c: Do not include py-ref.h.
5096         * python/py-event.h: Do not include py-ref.h.
5097         * python/py-evtregistry.c: Do not include py-ref.h.
5098         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5099         * python/py-frame.c: Do not include py-ref.h.
5100         * python/py-framefilter.c: Do not include py-ref.h.
5101         * python/py-function.c: Do not include py-ref.h.
5102         * python/py-infevents.c: Do not include py-ref.h.
5103         * python/py-linetable.c: Do not include py-ref.h.
5104         * python/py-objfile.c: Do not include py-ref.h.
5105         * python/py-param.c: Do not include py-ref.h.
5106         * python/py-prettyprint.c: Do not include py-ref.h.
5107         * python/py-progspace.c: Do not include py-ref.h.
5108         * python/py-symbol.c: Do not include py-ref.h.
5109         * python/py-symtab.c: Do not include py-ref.h.
5110         * python/py-type.c: Do not include py-ref.h.
5111         * python/py-unwind.c: Do not include py-ref.h.
5112         * python/py-utils.c: Do not include py-ref.h.
5113         * python/py-value.c: Do not include py-ref.h.
5114         * python/py-varobj.c: Do not include py-ref.h.
5115         * python/py-xmethods.c: Do not include py-ref.h.
5116         * python/python.c: Do not include py-ref.h.
5117         * varobj.c: Do not include py-ref.h.
5118
5119 2019-01-22  Tom Tromey  <tom@tromey.com>
5120
5121         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5122         keyword for bcache.
5123
5124 2019-01-22  Tom Tromey  <tom@tromey.com>
5125
5126         * compile/compile-cplus-types.c: Remove a comment by #include.
5127
5128 2019-01-22  Tom Tromey  <tom@tromey.com>
5129
5130         * compile/gcc-c-plugin.h: Include compile-internal.h.
5131
5132 2019-01-22  Tom Tromey  <tom@tromey.com>
5133
5134         * stabsread.c (EXTERN): Do not define.
5135         (symnum, next_symbol_text_func, processing_gcc_compilation)
5136         (within_function, global_sym_chain, global_stabs)
5137         (previous_stab_code, this_object_header_files)
5138         (n_this_object_header_files)
5139         (n_allocated_this_object_header_files): Define.
5140         * stabsread.h (EXTERN): Never define.  Use "extern".
5141
5142 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5143
5144         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5145         history_value.
5146
5147 2019-01-21  Tom Tromey  <tom@tromey.com>
5148
5149         * ui-out.c: Fix includes.
5150         * tui/tui-source.c: Fix includes.
5151         * target.c: Fix includes.
5152         * remote.c: Fix includes.
5153         * regcache.c: Fix includes.
5154         * python/py-block.c: Fix includes.
5155         * printcmd.c: Fix includes.
5156         * or1k-tdep.c: Fix includes.
5157         * mi/mi-main.c: Fix includes.
5158         * m32r-tdep.c: Fix includes.
5159         * csky-tdep.c: Fix includes.
5160         * compile/compile-cplus-types.c: Fix includes.
5161         * cli/cli-interp.c: Fix includes.
5162
5163 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5164
5165         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5166         for padding.
5167
5168 2019-01-16  Tom Tromey  <tom@tromey.com>
5169
5170         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5171         earlier.
5172         (struct objfile) <msymbols_range>: Move from top level.
5173         <msymbols>: New method.
5174         (class objfile_msymbols): Remove.
5175         * symtab.c (default_collect_symbol_completion_matches_break_on):
5176         Update.
5177         * symmisc.c (dump_msymbols): Update.
5178         * stabsread.c (scan_file_globals): Update.
5179         * objc-lang.c (info_selectors_command, info_classes_command)
5180         (find_methods): Update.
5181         * minsyms.c (find_solib_trampoline_target): Update.
5182         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5183         * coffread.c (coff_symfile_read): Update.
5184         * ada-lang.c (ada_lookup_simple_minsym)
5185         (ada_collect_symbol_completion_matches): Update.
5186
5187 2019-01-16  Tom Tromey  <tom@tromey.com>
5188
5189         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5190         type.  Remove no-argument constructor.
5191         <iterator::operator++>: Simplify.
5192         <begin>: Update.
5193         <end>: Use minimal_symbol_count.
5194
5195 2019-01-16  Tom Tromey  <tom@tromey.com>
5196
5197         * objfiles.h (struct objfile) <psymtabs>: New method.
5198         (class objfile_psymtabs): Remove.
5199         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5200         typedef.
5201         <range>: New method.
5202         (require_partial_symbols): Change return type.
5203         * psymtab.c (require_partial_symbols)
5204         (psym_expand_symtabs_matching): Update.
5205         * mdebugread.c (parse_partial_symbols): Update.
5206         * dbxread.c (dbx_end_psymtab): Update.
5207
5208 2019-01-15  Tom Tromey  <tom@tromey.com>
5209
5210         * symtab.c (lookup_objfile_from_block)
5211         (lookup_symbol_in_objfile_symtabs)
5212         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5213         (find_line_symtab, info_sources_command)
5214         (default_collect_symbol_completion_matches_break_on)
5215         (make_source_files_completion_list): Update.
5216         * symmisc.c (print_objfile_statistics, dump_objfile)
5217         (maintenance_print_symbols, maintenance_info_symtabs)
5218         (maintenance_check_symtabs, maintenance_info_line_tables):
5219         Update.
5220         * source.c (select_source_symtab)
5221         (forget_cached_source_info_for_objfile): Update.
5222         * objfiles.h (class objfile_compunits): Remove.
5223         (struct objfile) <compunits_range>: New typedef.
5224         (compunits): New method.
5225         * objfiles.c (objfile_relocate1): Update.
5226         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5227         * maint.c (count_symtabs_and_blocks): Update.
5228         * linespec.c (iterate_over_all_matching_symtabs): Update.
5229         * cp-support.c (add_symbol_overload_list_qualified): Update.
5230         * coffread.c (coff_symtab_read): Update.
5231         * ada-lang.c (add_nonlocal_symbols)
5232         (ada_collect_symbol_completion_matches)
5233         (ada_add_global_exceptions): Update.
5234
5235 2019-01-15  Tom Tromey  <tom@tromey.com>
5236
5237         * progspace.h (program_space) <objfiles_safe_range>: New
5238         typedef.
5239         <objfiles_safe>: New method.
5240         * objfiles.h (class all_objfiles_safe): Remove.
5241         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5242         * jit.c (jit_inferior_exit_hook): Update.
5243
5244 2019-01-17  Tom Tromey  <tom@tromey.com>
5245
5246         * progspace.h (program_space) <objfiles_range>: New typedef.
5247         <objfiles>: New method.
5248         <objfiles_head>: Rename from objfiles.
5249         (object_files): Update.
5250         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5251         * guile/scm-pretty-print.c
5252         (ppscm_find_pretty_printer_from_objfiles): Update.
5253         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5254         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5255         Update.
5256         * python/py-progspace.c (pspy_get_objfiles): Update.
5257         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5258         Update.
5259         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5260         (objfpy_lookup_objfile_by_build_id): Update.
5261         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5262         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5263         Update.
5264         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5265         (expand_symtab_containing_pc, lookup_objfile_from_block)
5266         (lookup_static_symbol, basic_lookup_transparent_type)
5267         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5268         (find_line_symtab, info_sources_command)
5269         (default_collect_symbol_completion_matches_break_on)
5270         (make_source_files_completion_list, find_main_name): Update.
5271         * symmisc.c (print_symbol_bcache_statistics)
5272         (print_objfile_statistics, maintenance_print_symbols)
5273         (maintenance_print_msymbols, maintenance_print_objfiles)
5274         (maintenance_info_symtabs, maintenance_check_symtabs)
5275         (maintenance_expand_symtabs, maintenance_info_line_tables):
5276         Update.
5277         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5278         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5279         (map_overlay_command, unmap_overlay_command)
5280         (simple_overlay_update, expand_symtabs_matching)
5281         (map_symbol_filenames): Update.
5282         * symfile-debug.c (set_debug_symfile): Update.
5283         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5284         Update.
5285         * source.c (select_source_symtab, forget_cached_source_info):
5286         Update.
5287         * solib.c (solib_read_symbols): Update.
5288         * solib-spu.c (append_ocl_sos): Update.
5289         * psymtab.c (maintenance_print_psymbols)
5290         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5291         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5292         * printcmd.c (info_symbol_command): Update.
5293         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5294         Update.
5295         * objfiles.h (class all_objfiles): Remove.
5296         * objfiles.c (have_partial_symbols, have_full_symbols)
5297         (have_minimal_symbols, qsort_cmp, update_section_map)
5298         (shared_objfile_contains_address_p)
5299         (default_iterate_over_objfiles_in_search_order): Update.
5300         * objc-lang.c (info_selectors_command, info_classes_command)
5301         (find_methods): Update.
5302         * minsyms.c (find_solib_trampoline_target): Update.
5303         * maint.c (maintenance_info_sections)
5304         (maintenance_translate_address, count_symtabs_and_blocks):
5305         Update.
5306         * main.c (captured_main_1): Update.
5307         * linux-thread-db.c (try_thread_db_load_from_pdir)
5308         (has_libpthread): Update.
5309         * linespec.c (iterate_over_all_matching_symtabs)
5310         (search_minsyms_for_name): Update.
5311         * jit.c (jit_find_objf_with_entry_addr): Update.
5312         * hppa-tdep.c (find_unwind_entry)
5313         (hppa_lookup_stub_minimal_symbol): Update.
5314         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5315         Update.
5316         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5317         (elf_gnu_ifunc_resolve_by_got): Update.
5318         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5319         * dwarf-index-write.c (save_gdb_index_command): Update.
5320         * cp-support.c (add_symbol_overload_list_qualified): Update.
5321         * breakpoint.c (create_overlay_event_breakpoint)
5322         (create_longjmp_master_breakpoint)
5323         (create_std_terminate_master_breakpoint)
5324         (create_exception_master_breakpoint): Update.
5325         * blockframe.c (find_pc_partial_function): Update.
5326         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5327         (ada_collect_symbol_completion_matches)
5328         (ada_add_global_exceptions): Update.
5329
5330 2019-01-17  Tom Tromey  <tom@tromey.com>
5331
5332         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5333         declare VEC.
5334         (solib_target_parse_libraries): Change return type.
5335         (library_list_start_segment, library_list_start_section)
5336         (library_list_end_library, library_list_start_library); Update.
5337         (solib_target_free_library_list): Remove.
5338         (solib_target_parse_libraries): Remove cleanup.  Change return
5339         type.
5340         (solib_target_current_sos): Update.
5341
5342 2019-01-17  Tom Tromey  <tromey@bapiya>
5343
5344         * valprint.c: Replace "the the" with "the".
5345         * symtab.c: Replace "the the" with "the".
5346         * solib.c: Replace "the the" with "the".
5347         * solib-dsbt.c: Replace "the the" with "the".
5348         * linespec.c: Replace "the the" with "the".
5349         * dwarf2loc.h: Replace "the the" with "the".
5350         * amd64-windows-tdep.c: Replace "the the" with "the".
5351         * aarch64-tdep.c: Replace "the the" with "the".
5352
5353 2019-01-16  Keith Seitz  <keiths@redhat.com>
5354
5355         PR gdb/23773
5356         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5357         <builder>: Rename to ..
5358         <m_builder>: ... this and make private.
5359         (dwarf2_cu::get_builder): New method.  Change all users of
5360         `builder' to use this method.
5361         (dwarf2_start_symtab): Move to ...
5362         (dwarf2_cu::start_symtab): ... here.  Update all callers
5363         (setup_type_unit_groups): Move to ...
5364         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5365         callers.
5366         (dwarf2_cu::reset_builder): New method.
5367         (process_full_compunit, process_full_type_unit): Use
5368         dwarf2_cu::reset_builder.
5369         (follow_die_offset): Record the ancestor CU if it is different
5370         from the followed DIE's CU.
5371         (follow_die_sig_1): Likewise.
5372
5373 2019-01-15  Tom Tromey  <tom@tromey.com>
5374
5375         * remote.c (class remote_state) <buf>: Now a char_vector.
5376         <buf_size>: Remove.
5377         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5378         parameter.
5379         (remote_target::getpkt_or_notif_sane_1)
5380         (remote_target::getpkt_sane)
5381         (remote_target::getpkt_or_notif_sane): Likewise.
5382         (class remote_target) <putpkt>: New overload.
5383         (remote_target::read_frame): Change type of "buf_p".  Remove
5384         sizeof_p parameter.
5385         (packet_ok): New overload.
5386         (packet_check_result): New overload.
5387         Update all uses.
5388
5389 2019-01-14  Tom Tromey  <tom@tromey.com>
5390
5391         * remote-notif.c (handle_notification, remote_notif_ack)
5392         (remote_notif_parse): Make "buf" const.
5393         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5394         const.
5395         (remote_notif_parse, remote_notif_ack, handle_notification):
5396         Likewise.
5397         * remote.c (remote_notif_stop_parse): Make "buf" const.
5398         (remote_target::remote_parse_stop_reply): Make "buf" const.
5399         (remote_notif_stop_ack): Make "buf" const.
5400
5401 2019-01-14  Tom Tromey  <tom@tromey.com>
5402
5403         * remote.c (remote_console_output): Make parameter const.
5404
5405 2019-01-14  Tom Tromey  <tom@tromey.com>
5406
5407         * target-debug.h (target_debug_print_signals): Constify.
5408         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5409         * procfs.c (procfs_target::pass_signals): Update.
5410         * linux-nat.c (linux_nat_target::pass_signals): Update.
5411         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5412         * target-delegates.c: Rebuild.
5413         * remote.c (remote_target::program_signals): Update.
5414         (remote_target::pass_signals): Update.
5415         * target.c (target_pass_signals): Constify argument.
5416         (target_program_signals): Likewise.
5417         * target.h (struct target_ops) <pass_signals, program_signals>:
5418         Constify argument.
5419         (target_pass_signals, target_program_signals): Constify argument.
5420
5421 2019-01-14  Tom Tromey  <tom@tromey.com>
5422
5423         PR tui/28819:
5424         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5425
5426 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5427
5428         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5429         field.
5430         * rs6000-tdep.c: Include reggroups.h.
5431         (IS_V_ALIAS_PSEUDOREG): Define.
5432         (rs6000_register_name): Return names for the "vX" aliases.
5433         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5434         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5435         aliases.  Call default_register_reggroup_p for all other
5436         pseudo-registers.
5437         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5438         New functions.
5439         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5440         Handle "vX" aliases.
5441         (v_alias_pseudo_register_collect): New function.
5442         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5443         (rs6000_gdbarch_init): Initialize "vX" aliases as
5444         pseudo-registers.  Restore registration of
5445         rs6000_pseudo_register_reggroup_p with
5446         set_tdesc_pseudo_register_reggroup_p.
5447
5448 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5449
5450         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5451         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5452         set_gdbarch_num_pseudo_regs.
5453
5454 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5455
5456         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5457         Remove arg prefixname, add do_set and do_show.
5458         Add member functions set_list and show_list.
5459         * cli/cli-style.c (class cli_style_option): Update accordingly.
5460         (style_set_list): Move to file scope.
5461         (style_show_list): Likewise.
5462         (set_style): Call help_list.
5463         (show_style): Call cmd_show_list.
5464         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5465         Update to use the new macro.
5466
5467 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5468
5469         * ada-lang.c (_initialize_ada_language): Expand the help text
5470         for the "catch exception" command.
5471
5472 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5473
5474         * symtab.c (matching_obj_sections): Initialize obj,
5475         declare it closer to its usage.
5476
5477 2019-01-10  Tom Tromey  <tom@tromey.com>
5478
5479         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5480         (basic_inf_threads_range): Remove.
5481         (inf_threads_range, inf_non_exited_threads_range)
5482         (safe_inf_threads_range): Use next_adapter.
5483
5484 2019-01-10  Keith Seitz  <keiths@redhat.com>
5485
5486         PR gdb/23712
5487         PR symtab/23010
5488         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5489         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5490
5491 2019-01-10  Keith Seitz  <keiths@redhat.com>
5492
5493         PR gdb/23712
5494         PR symtab/23010
5495         * dictionary.c (pending_to_vector): Remove.
5496         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5497         Remove _1 suffix, replacing functions of the same name.  Update
5498         all callers.
5499         (dict_create_hashed, dict_create_hashed_expandable)
5500         (dict_create_linear, dict_create_linear_expandable, dict_free)
5501         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5502         Make functions static.
5503
5504 2019-01-10  Keith Seitz  <keiths@redhat.com>
5505
5506         PR gdb/23712
5507         PR symtab/23010
5508         * dictionary.h (struct dictionary): Replace declaration with
5509         multidictionary.
5510         (dict_create_hashed, dict_create_hashed_expandable)
5511         (dict_create_linear, dict_create_linear_expandable)
5512         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5513         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5514         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5515         taking multidictionary argument.
5516         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5517         * block.h (struct block) <dict>: Change to multidictionary
5518         and rename `multidict'.
5519         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5520         symmisc.c: Update all dictionary references to multidictionary.
5521
5522 2019-01-10  Keith Seitz  <keiths@redhat.com>
5523
5524         PR gdb/23712
5525         PR symtab/23010
5526         * dictionary.c: Include unordered_map.
5527         (pending_to_vector): New function.
5528         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5529         Rewrite the non-"_1" functions to take vector instead
5530         of linked list.
5531         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5532         "new" _1 versions of the same name.
5533         (multidictionary): Define.
5534         (std::hash<enum language): New definition.
5535         (collate_pending_symbols_by_language, mdict_create_hashed)
5536         (mdict_create_hashed_expandable, mdict_create_linear)
5537         (mdict_create_linear_expandable, mdict_free)
5538         (find_language_dictionary, create_new_language_dictionary)
5539         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5540         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5541         (mdict_size, mdict_empty): New functions.
5542         * dictionary.h (mdict_iterator): Define.
5543
5544 2019-01-10  Pedro Alves  <palves@redhat.com>
5545
5546         * breakpoint.c (read_uploaded_action)
5547         (create_tracepoint_from_upload): Adjust to use
5548         gdb::unique_xmalloc_ptr.
5549         * ctf.c (ctf_write_uploaded_tp):
5550         (SET_ARRAY_FIELD): Use emplace_back.
5551         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5552         * tracefile-tfile.c (tfile_write_uploaded_tp):
5553         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5554         gdb::unique_xmalloc_ptr.
5555         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5556         at_string, cond_string, cmd_strings>: Replace char pointers
5557         with gdb::unique_xmalloc_ptr.
5558
5559 2019-01-10  Pedro Alves  <palves@redhat.com>
5560
5561         * solib-target.c (library_list_start_library): Don't xstrdup name.
5562
5563 2019-01-10  Pedro Alves  <palves@redhat.com>
5564
5565         * mdebugread.c (parse_partial_symbols): Use
5566         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5567
5568 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * linux-fork.c (scoped_switch_fork_info)
5571         <~scoped_switch_fork_info>: Fix incorrect variable name.
5572
5573 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5574
5575         * linux-fork.c (scoped_switch_fork_info)
5576         <scoped_switch_fork_info>: Make explicit.
5577         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5578
5579 2019-01-10  Tom Tromey  <tom@tromey.com>
5580
5581         * objfiles.h (objfile::reset_psymtabs): Update.
5582         * objfiles.c (objfile::objfile): Update.
5583         * psymtab.h (psymtab_storage::obstack): Update.
5584         (psymtab_storage::m_obstack): Use gdb::optional.
5585         (class psymtab_storage): Update comment.  Remove objfile
5586         parameter.
5587         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5588
5589 2019-01-10  Tom Tromey  <tom@tromey.com>
5590
5591         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5592         <free_psymtabs>: Now private.
5593         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5594         (allocate_psymtab): Use new method.
5595
5596 2019-01-10  Tom Tromey  <tom@tromey.com>
5597
5598         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5599         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5600         * mdebugread.c (parse_partial_symbols): Use
5601         allocate_dependencies.
5602         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5603         allocate_dependencies.
5604         (process_psymtab_comp_unit_reader)
5605         (build_type_psymtab_dependencies): Likewise.
5606         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5607
5608 2019-01-10  Tom Tromey  <tom@tromey.com>
5609
5610         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5611         PSYMBOL_SET_LANGUAGE.
5612         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5613
5614 2019-01-10  Tom Tromey  <tom@tromey.com>
5615
5616         * psymtab.h (psymtab_storage::obstack): New method.
5617         <m_obstack>: Rename from obstack; now private.
5618         * psymtab.c (psymtab_storage): Update.
5619         * dwarf2read.c (create_addrmap_from_index)
5620         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5621         Update.
5622
5623 2019-01-10  Tom Tromey  <tom@tromey.com>
5624
5625         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5626         * objfiles.h (objfile::reset_psymtabs): New method.
5627
5628 2019-01-10  Tom Tromey  <tom@tromey.com>
5629
5630         * symmisc.c (print_symbol_bcache_statistics): Update.
5631         (print_objfile_statistics): Update.
5632         * symfile.c (reread_symbols): Update.
5633         * psymtab.h (class psymtab_storage): New.
5634         * psymtab.c (psymtab_storage): New constructor.
5635         (~psymtab_storage): New destructor.
5636         (require_partial_symbols): Update.
5637         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5638         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5639         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5640         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5641         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5642         (start_psymtab_common, end_psymtab_common)
5643         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5644         (allocate_psymtab): Update.
5645         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5646         Update.
5647         (dump_psymtab_addrmap, maintenance_print_psymbols)
5648         (maintenance_check_psymtabs): Update.
5649         (class objfile_psymtabs): Move to objfiles.h.
5650         * psympriv.h (discard_psymtab): Now inline.
5651         (psymtab_discarder::psymtab_discarder): Update.
5652         (psymtab_discarder::~psymtab_discarder): Update.
5653         (ALL_OBJFILE_PSYMTABS): Rewrite.
5654         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5655         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5656         Remove fields.
5657         <partial_symtabs>: New field.
5658         (class objfile_psymtabs): Move from psymtab.h.  Update.
5659         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5660         psymbol_cache.
5661         (objfile::~objfile): Don't destroy psymbol_cache.
5662         * mdebugread.c (parse_partial_symbols): Update.
5663         * dwarf2read.c (create_addrmap_from_index)
5664         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5665         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5666         (add_partial_subprogram, dwarf2_ranges_read): Update.
5667         * dwarf-index-write.c (write_address_map)
5668         (write_one_signatured_type, recursively_write_psymbols)
5669         (class debug_names, class debug_names, write_psymtabs_to_index):
5670         Update.
5671
5672 2019-01-10  Tom Tromey  <tom@tromey.com>
5673
5674         * symtab.h (SYMBOL_SET_NAMES): Update.
5675         (symbol_set_names): Update.
5676         (MSYMBOL_SET_NAMES): Update.
5677         * symtab.c (symbol_set_names): Change argument to be an
5678         objfile_per_bfd_storage.
5679         * psymtab.c (add_psymbol_to_bcache): Update.
5680         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5681
5682 2019-01-10  Tom Tromey  <tom@tromey.com>
5683
5684         * symtab.c (create_demangled_names_hash): Change argument to be an
5685         objfile_per_bfd_storage.
5686         (symbol_set_names): Update.
5687
5688 2019-01-10  Tom Tromey  <tom@tromey.com>
5689
5690         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5691         init_psymbol_list.
5692         * psymtab.c (init_psymbol_list): Do nothing if already called.
5693         * psympriv.h (init_psymbol_list): Add comment.
5694         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5695         init_psymbol_list.
5696         * dbxread.c (dbx_symfile_read): Unconditionally call
5697         init_psymbol_list.
5698
5699 2019-01-10  Tom Tromey  <tom@tromey.com>
5700
5701         * xcoffread.c (scan_xcoff_symtab): Update.
5702         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5703         "where".
5704         * mdebugread.c (parse_partial_symbols)
5705         (handle_psymbol_enumerators): Update.
5706         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5707         * dbxread.c (read_dbx_symtab): Update.
5708         * psympriv.h (psymbol_placement): New enum.
5709         (add_psymbol_to_list): Update.
5710
5711 2019-01-10  Tom Tromey  <tom@tromey.com>
5712
5713         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5714         static_psymbols parameters.
5715         (scan_xcoff_symtab): Update.
5716         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5717         static_psymbols parameters.
5718         * psympriv.h (start_psymtab_common): Update.
5719         * mdebugread.c (parse_partial_symbols): Update.
5720         * dwarf2read.c (create_partial_symtab): Update.
5721         * dbxread.c (read_dbx_symtab): Update.
5722         (start_psymtab): Remove global_psymbols and static_psymbols
5723         parameters.
5724
5725 2019-01-10  Tom Tromey  <tom@tromey.com>
5726
5727         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5728         * psymtab.c (allocate_psymtab): Add comment.
5729         * psympriv.h (allocate_psymtab): Add comment.
5730         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5731         initializations.
5732         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5733
5734 2019-01-10  Tom Tromey  <tom@tromey.com>
5735
5736         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5737         Don't declare.
5738         * mipsread.c: Include mdebugread.h.
5739         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5740         Declare.
5741         * elfread.c: Include mdebugread.h.
5742
5743 2019-01-09  Tom Tromey  <tom@tromey.com>
5744
5745         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5746         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5747         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5748         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5749         (psym_lookup_symbol, psym_find_last_source_symtab)
5750         (psym_forget_cached_source_info, psym_print_stats)
5751         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5752         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5753         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5754         (psym_find_compunit_symtab_by_address)
5755         (maintenance_print_psymbols, maintenance_info_psymtabs)
5756         (maintenance_check_psymtabs): Use ranged for.
5757         * psymtab.h (class objfile_psymtabs): New.
5758         (require_partial_symbols): Return objfile_psymtabs.
5759         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5760
5761 2019-01-09  Tom Tromey  <tom@tromey.com>
5762
5763         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5764         (find_pc_mapped_section, list_overlays_command)
5765         (map_overlay_command, unmap_overlay_command)
5766         (simple_overlay_update): Use all_objfiles.
5767         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5768         * printcmd.c (info_symbol_command): Use all_objfiles.
5769         * objfiles.h (ALL_OBJSECTIONS): Remove.
5770         * maint.c (maintenance_translate_address): Use all_objfiles.
5771         * gcore.c (gcore_create_callback): Use all_objfiles.
5772         (objfile_find_memory_regions): Likewise.
5773
5774 2019-01-09  Tom Tromey  <tom@tromey.com>
5775
5776         * symtab.c (find_line_symtab, info_sources_command)
5777         (make_source_files_completion_list): Use objfile_compunits.
5778         * source.c (select_source_symtab): Use objfile_compunits.
5779         * objfiles.h (struct objfile): Update comment.
5780         (ALL_OBJFILES): Remove.
5781         (ALL_FILETABS): Remove.
5782         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5783         objfile_compunits.
5784
5785 2019-01-09  Tom Tromey  <tom@tromey.com>
5786
5787         * symmisc.c (print_objfile_statistics, dump_objfile)
5788         (maintenance_print_symbols): Use compunit_filetabs.
5789         * source.c (forget_cached_source_info_for_objfile): Use
5790         compunit_filetabs.
5791         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5792         (ALL_FILETABS): Use compunit_filetabs.
5793         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5794         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5795
5796 2019-01-09  Tom Tromey  <tom@tromey.com>
5797
5798         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5799         (compunit_filetabs): New.
5800         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5801         compunit_filetabs.
5802         (info_sources_command, make_source_files_completion_list): Remove
5803         declaration.
5804         * symmisc.c (print_objfile_statistics, dump_objfile)
5805         (maintenance_print_symbols): Remove declaration.
5806         (maintenance_info_symtabs): Use compunit_filetabs.
5807         (maintenance_info_line_tables): Likewise.
5808         * source.c (select_source_symtab): Change local variable name.
5809         (forget_cached_source_info_for_objfile): Remove declaration.
5810         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5811         * objfiles.c (objfile_relocate1): Remove declaration.
5812         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5813         declaration.
5814         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5815         * coffread.c (coff_symtab_read): Remove declaration.
5816         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5817         compunit_filetabs.
5818
5819 2019-01-09  Tom Tromey  <tom@tromey.com>
5820
5821         * symtab.c (lookup_objfile_from_block)
5822         (find_pc_sect_compunit_symtab, search_symbols)
5823         (default_collect_symbol_completion_matches_break_on): Use
5824         objfile_compunits.
5825         * objfiles.h (ALL_COMPUNITS): Remove.
5826         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5827         * cp-support.c (add_symbol_overload_list_qualified): Use
5828         objfile_compunits.
5829         * ada-lang.c (ada_collect_symbol_completion_matches)
5830         (ada_add_global_exceptions): Use objfile_compunits.
5831
5832 2019-01-09  Tom Tromey  <tom@tromey.com>
5833
5834         * source.c (select_source_symtab)
5835         (forget_cached_source_info_for_objfile): Remove declaration.
5836         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5837         declaration.
5838         * maint.c (count_symtabs_and_blocks): Remove declaration.
5839         * cp-support.c (add_symbol_overload_list_qualified): Remove
5840         declaration.
5841         * coffread.c (coff_symtab_read): Remove declaration.
5842         * symtab.c (lookup_symbol_in_objfile_symtabs)
5843         (basic_lookup_transparent_type_1): Use objfile_compunits.
5844         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5845         (info_sources_command, search_symbols)
5846         (default_collect_symbol_completion_matches_break_on)
5847         (make_source_files_completion_list): Remove declaration.
5848         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5849         (ada_collect_symbol_completion_matches)
5850         (ada_add_global_exceptions): Remove declaration.
5851         * linespec.c (iterate_over_all_matching_symtabs): Use
5852         objfile_compunits.
5853         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5854         (class objfile_compunits): New.
5855         (ALL_COMPUNITS): Use objfile_compunits.
5856         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5857         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5858         objfile_compunits.
5859         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5860
5861 2019-01-09  Tom Tromey  <tom@tromey.com>
5862
5863         * symtab.c (search_symbols)
5864         (default_collect_symbol_completion_matches_break_on): Use
5865         objfile_msymbols.
5866         * ada-lang.c (ada_lookup_simple_minsym)
5867         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5868         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5869         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5870         objfile_msymbols.
5871         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5872         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5873         * objc-lang.c (find_methods): Use objfile_msymbols.
5874         (info_selectors_command, info_classes_command): Likewise.
5875         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5876         * objfiles.h (class objfile_msymbols): New.
5877         (ALL_OBJFILE_MSYMBOLS): Remove.
5878         (ALL_MSYMBOLS): Remove.
5879
5880 2019-01-09  Tom Tromey  <tom@tromey.com>
5881
5882         * common/next-iterator.h (next_adapter): Add Iterator template
5883         parameter.
5884         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5885         (class all_objfiles_safe): New.
5886         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5887         * objfiles.c (put_objfile_before): Update comment.
5888         (add_separate_debug_objfile): Likewise.
5889         (free_all_objfiles): Use all_objfiles_safe.
5890         (objfile_purge_solibs): Likewise.
5891
5892 2019-01-09  Tom Tromey  <tom@tromey.com>
5893
5894         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5895         (expand_symtab_containing_pc, lookup_static_symbol)
5896         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5897         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5898         all_objfiles.
5899         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5900         * breakpoint.c (create_overlay_event_breakpoint)
5901         (create_longjmp_master_breakpoint)
5902         (create_std_terminate_master_breakpoint)
5903         (create_exception_master_breakpoint): Use all_objfiles.
5904         * linux-thread-db.c (try_thread_db_load_from_pdir)
5905         (has_libpthread): Use all_objfiles.
5906         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5907         * linespec.c (iterate_over_all_matching_symtabs)
5908         (search_minsyms_for_name): Use all_objfiles.
5909         * maint.c (maintenance_info_sections): Use all_objfiles.
5910         * main.c (captured_main_1): Use all_objfiles.
5911         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5912         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5913         * guile/scm-pretty-print.c
5914         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5915         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5916         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5917         (maintenance_print_msymbols): Use all_objfiles.
5918         * source.c (select_source_symtab): Use all_objfiles.
5919         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5920         * symfile.c (remove_symbol_file_command)
5921         (expand_symtabs_matching, map_symbol_filenames): Use
5922         all_objfiles.
5923         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5924         all_objfiles.
5925         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5926         * objc-lang.c (find_methods): Use all_objfiles.
5927         * objfiles.c (have_partial_symbols, have_full_symbols)
5928         (have_minimal_symbols, qsort_cmp)
5929         (default_iterate_over_objfiles_in_search_order): Use
5930         all_objfiles.
5931         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5932         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5933         (maintenance_check_psymtabs): Use all_objfiles.
5934         (ALL_PSYMTABS): Remove.
5935         * compile/compile-object-run.c (do_module_cleanup): Use
5936         all_objfiles.
5937         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5938         * cp-support.c (add_symbol_overload_list_qualified): Use
5939         all_objfiles.
5940         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5941         Use all_objfiles.
5942         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5943         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5944         all_objfiles.
5945         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5946         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5947         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5948         Uses all_objfiles.
5949         * solib.c (solib_read_symbols): Use all_objfiles
5950
5951 2019-01-09  Tom Tromey  <tom@tromey.com>
5952
5953         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5954         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5955         all_objfiles.
5956         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5957         * symmisc.c (print_symbol_bcache_statistics)
5958         (print_objfile_statistics, maintenance_print_objfiles)
5959         (maintenance_info_symtabs, maintenance_check_symtabs)
5960         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5961         all_objfiles.
5962         * source.c (forget_cached_source_info): Use all_objfiles.
5963         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5964         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5965         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5966         * objfiles.c (update_section_map): Use all_objfiles.
5967         (shared_objfile_contains_address_p): Likewise.
5968         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5969         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5970
5971 2019-01-09  Tom Tromey  <tom@tromey.com>
5972
5973         * common/next-iterator.h: New file.
5974         * objfiles.h (class all_objfiles): New.
5975         (struct objfile_iterator): New.
5976
5977 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5978
5979         * NEWS: Move the description of the changed "frame", "select-frame",
5980          and "info frame" commands to the Changed commands section.
5981
5982 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5983
5984         * gdbtypes.c (check_stub_method_group): Remove handling of old
5985         mangling schemes.
5986         * linespec.c (find_methods): Likewise.
5987         * stabsread.c (read_member_functions): Likewise.
5988         * valops.c (search_struct_method): Likewise.
5989         (value_struct_elt_for_reference): Likewise.
5990         * NEWS: Mention this change.
5991
5992 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5993
5994         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5995         print_source_lines.
5996         * source.c (print_source_lines_base): Update line number check.
5997         (print_source_lines): New function.
5998         (source_lines_range::source_lines_range): New function.
5999         * source.h (class source_lines_range): New class.
6000         (print_source_lines): New declaration.
6001
6002 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6003
6004         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6005
6006 2019-01-08  Tom Tromey  <tom@tromey.com>
6007             Simon Marchi  <simon.marchi@ericsson.com>
6008
6009         PR gdb/24060
6010         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6011         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6012         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6013         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6014         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6015         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6016
6017 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6018
6019         * source.c (select_source_symtab): Move header comment to
6020         declaration in source.h.
6021         (forget_cached_source_info_for_objfile): Likewise.
6022         (forget_cached_source_info): Likewise.
6023         (identify_source_line): Likewise.
6024         * source.h (identify_source_line): Move declaration from symtab.h
6025         and add comment from source.c
6026         (print_source_lines): Likewise.
6027         (forget_cached_source_info_for_objfile): Likewise.
6028         (forget_cached_source_info): Likewise.
6029         (select_source_symtab): Likewise.
6030         (enum print_source_lines_flag): Move definition from symtab.h.
6031         * symtab.h (identify_source_line): Move declaration to source.h.
6032         (print_source_lines): Likewise.
6033         (forget_cached_source_info_for_objfile): Likewise.
6034         (forget_cached_source_info): Likewise.
6035         (select_source_symtab): Likewise.
6036         (enum print_source_lines_flag): Move definition to source.h.
6037         * tui/tui-hooks.c: Add 'source.h' include.
6038
6039 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * source.c (print_source_lines_base): Handle requests to print
6042         reverse line number sequences, and guard against empty lines
6043         string.
6044
6045 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6046
6047         * source.c (print_source_lines_base): Fix skip of '\r' if next
6048         character is '\n'.
6049
6050 2019-01-06  Tom Tromey  <tom@tromey.com>
6051
6052         * c-exp.y (struct c_parse_state) <macro_original_text,
6053         expansion_obstack>: New member.
6054         (macro_original_text, expansion_obstack): Remove globals.
6055         (scan_macro_expansion, scanning_macro_expansion)
6056         (finished_macro_expansion): Update.
6057         (scan_macro_cleanup): Remove.
6058         (yylex, c_parse): Update.
6059
6060 2019-01-06  Tom Tromey  <tom@tromey.com>
6061
6062         * c-exp.y (struct c_parse_state) <strings>: New member.
6063         (operator_stoken): Update.
6064
6065 2019-01-06  Tom Tromey  <tom@tromey.com>
6066
6067         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6068         (union type_stack_elt) <typelist_val>: Now a pointer to
6069         std::vector.
6070         (type_stack_cleanup): Don't declare.
6071         (push_typelist): Update.
6072         * parse.c (pop_typelist): Return a std::vector.
6073         (push_typelist): Take a std::vector.
6074         (follow_types): Update.  Do not free args.
6075         (type_stack_cleanup): Remove.
6076         * c-exp.y (struct c_parse_state): New.
6077         (cpstate): New global.
6078         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6079         (nonempty_typelist): Update.
6080         (func_mod): Create a new vector.
6081         (c_parse): Create a c_parse_state.
6082         (check_parameter_typelist): Do not delete params.
6083         (function_method): Update.  Do not delete type_list.
6084
6085 2019-01-06  Tom Tromey  <tom@tromey.com>
6086
6087         PR gdb/28155:
6088         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6089         check_typedef.
6090         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6091         (print_return_value): Likewise.
6092
6093 2019-01-05  Tom Tromey  <tom@tromey.com>
6094
6095         * contrib/cleanup_check.py: Remove.
6096         * contrib/gcc-with-excheck: Remove.
6097         * contrib/exsummary.py: Remove.
6098         * contrib/excheck.py: Remove.
6099
6100 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6101
6102         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6103         NULL. Initialize tpprev to NULL instead of assigning it
6104         to NULL on the next statement.
6105         * windows-nat.c (windows_delete_thread): Remove check for
6106         main_thread_id before printing thread exit notifications.
6107         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6108         Remove thread ID check against main_thread_id.
6109         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6110         windows_delete_thread.
6111         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6112
6113 2019-01-04  Tom Tromey  <tom@tromey.com>
6114
6115         * compile/compile.c (_initialize_compile): Use upper case for
6116         metasyntactic variables.
6117         * symmisc.c (_initialize_symmisc): Use upper case for
6118         metasyntactic variables.
6119         * psymtab.c (_initialize_psymtab): Use upper case for
6120         metasyntactic variables.
6121         * demangle.c (demangle_command): Use upper case for metasyntactic
6122         variables.
6123         (_initialize_demangler): Likewise.
6124         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6125         variables.
6126
6127 2019-01-03  Tom Tromey  <tom@tromey.com>
6128
6129         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6130
6131 2019-01-03  Tom Tromey  <tom@tromey.com>
6132
6133         * python/py-symtab.c (salpy_str): Update.
6134         (struct salpy_sal_object) <symtab>: Now a PyObject.
6135         (salpy_dealloc): Update.
6136         (del_objfile_sal): Use gdbpy_ref.
6137
6138 2019-01-03  Tom Tromey  <tom@tromey.com>
6139
6140         * python/py-type.c (convert_field): Use new_reference.  Return
6141         gdbpy_ref.
6142         (make_fielditem): Return gdbpy_ref.
6143         (typy_fields): Update.
6144         (typy_getitem): Update.
6145         (field_name): Return gdbpy_ref.  Use new_reference.
6146         (typy_iterator_iternext): Update.
6147
6148 2019-01-03  Tom Tromey  <tom@tromey.com>
6149
6150         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6151
6152 2019-01-03  Tom Tromey  <tom@tromey.com>
6153
6154         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6155         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6156         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6157         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6158         (pspy_set_type_printers): Likewise.
6159         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6160         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6161         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6162         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6163         (objfpy_set_type_printers): Likewise.
6164
6165 2019-01-03  Tom Tromey  <tom@tromey.com>
6166
6167         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6168         (gdbpy_print_stack): Use gdbpy_err_fetch.
6169         * python/python-internal.h (class gdbpy_err_fetch): New class.
6170         (class gdbpy_enter) <m_error_type, m_error_value,
6171         m_error_traceback>: Remove.
6172         <m_error>: New member.
6173         (gdbpy_exception_to_string): Don't declare.
6174         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6175         * python/py-value.c (convert_value_from_python): Use
6176         gdbpy_err_fetch.
6177         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6178         gdbpy_exception_to_string.
6179         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6180         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6181         gdbpy_err_fetch.
6182
6183 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6184
6185         * linux-nat.c (delete_lwp_cleanup): Delete.
6186         (struct lwp_deleter): New struct.
6187         (lwp_info_up): New typedef.
6188         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6189         lwp_info_up.
6190
6191 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6192
6193         * linux-fork.c (class scoped_switch_fork_info): New class.
6194         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6195
6196 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6197
6198         * valops.c (find_overload_match): Remove use of null_cleanup, and
6199         calls to do_cleanups.
6200
6201 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * compile/compile-cplus-types.c
6204         (compile_cplus_instance::decl_name): Handle changes to
6205         cp_func_name.
6206         * cp-support.c (cp_func_name): Update header comment, update
6207         return type.
6208         * cp-support.h (cp_func_name): Update return type in declaration.
6209         * valops.c (find_overload_match): Move temp_func local to top
6210         level of function and change its type.  Use temp_func to hold and
6211         delete temporary string obtained from cp_func_name.
6212
6213 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6214
6215         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6216         gdb::char_vector, remove cleanup, and update uses of `msg`.
6217
6218 2019-01-03  Jim Wilson  <jimw@sifive.com>
6219
6220         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6221
6222 2019-01-02  Tom Tromey  <tom@tromey.com>
6223
6224         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6225         (tdesc_parse_xml): Remove cleanups.
6226         * target-descriptions.h (make_cleanup_free_target_description):
6227         Don't declare.
6228         (target_desc_deleter): New struct.
6229         (target_desc_up): New typedef.
6230         * target-descriptions.c (target_desc_deleter::operator()): Rename
6231         from free_target_description.
6232         (make_cleanup_free_target_description): Remove.
6233
6234 2019-01-02  Tom Tromey  <tom@tromey.com>
6235
6236         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6237         constructor, destructor.
6238         (linespec_parser): Remove typedef.
6239         (~linespec_parser): Rename from linespec_parser_delete.
6240         (linespec_lex_to_end, linespec_complete_label)
6241         (linespec_complete): Update.
6242         (decode_line_full): Remove cleanups.
6243         (decode_line_1): Update.
6244
6245 2019-01-02  Tom Tromey  <tom@tromey.com>
6246
6247         * python/python-internal.h (inferior_to_inferior_object): Change
6248         return type.
6249         * python/py-exitedevent.c (create_exited_event_object): Update.
6250         * python/py-inferior.c (inferior_to_inferior_object): Return
6251         gdbpy_ref.
6252         (python_new_inferior, python_inferior_deleted)
6253         (thread_to_thread_object, delete_thread_object)
6254         (build_inferior_list, gdbpy_selected_inferior): Update.
6255         * python/py-infthread.c (create_thread_object): Update.  Also fail
6256         if inferior_to_inferior_object fails.
6257
6258 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6259
6260         * inferior.h (class inferior) <displaced_step_state>: New field.
6261         * infrun.h (struct displaced_step_state): Move here from
6262         infrun.c.  Initialize fields, add constructor.
6263         <inf>: Remove field.
6264         <reset>: New method.
6265         * infrun.c (struct displaced_step_inferior_state): Move to
6266         infrun.h.
6267         (displaced_step_inferior_states): Remove.
6268         (get_displaced_stepping_state): Adust.
6269         (displaced_step_in_progress_any_inferior): Adjust.
6270         (displaced_step_in_progress_thread): Adjust.
6271         (displaced_step_in_progress): Adjust.
6272         (add_displaced_stepping_state): Remove.
6273         (get_displaced_step_closure_by_addr): Adjust.
6274         (remove_displaced_stepping_state): Remove.
6275         (infrun_inferior_exit): Call displaced_step_state.reset.
6276         (use_displaced_stepping): Don't check for NULL.
6277         (displaced_step_prepare_throw): Call
6278         get_displaced_stepping_state.
6279         (displaced_step_fixup): Don't check for NULL.
6280         (prepare_for_detach): Don't check for NULL.
6281
6282 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6283
6284         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6285          in case of call that did not complete.
6286
6287 2019-01-02  Andrey Utkin  <autkin@undo.io>
6288
6289         * symfile.c (find_separate_debug_file): Fix search of debug files for
6290         remote debuggee.
6291
6292 2019-01-02  Tom Tromey  <tom@tromey.com>
6293
6294         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6295         indentation.
6296         * python/py-frame.c (frapy_older): Remove cast.
6297         (frapy_newer): Likewise.
6298         * python/py-breakpoint.c (local_setattro): Remove cast.
6299         * python/py-arch.c (archpy_name): Remove local variable.
6300         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6301
6302 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6303
6304         * unittests/basic_string_view/element_access/char/empty.cc:
6305         Fix year range in copyright header.
6306
6307 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6308
6309         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6310         Delete.
6311         <operator==>: Update with for removed field.
6312         <hash>: Likewise.
6313         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6314         <isa_features>: ...this.
6315         <abi_features>: New field.
6316         (riscv_isa_flen): Update comment.
6317         (riscv_abi_xlen): New declaration.
6318         (riscv_abi_flen): New declaration.
6319         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6320         isa_features.
6321         (riscv_abi_xlen): New function.
6322         (riscv_isa_flen): Update to get answer from isa_features.
6323         (riscv_abi_flen): New function.
6324         (riscv_has_fp_abi): Update to get answer from abi_features.
6325         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6326         xlen and flen.
6327         (riscv_call_info) <xlen, flen>: Update comment.
6328         (riscv_call_arg_struct): Remove invalid assertions
6329         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6330         is removed.
6331         (riscv_gdbarch_init): Gather isa features and abi features
6332         separately, ensure both match on the gdbarch when reusing an old
6333         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6334         a target with 64-bit float hardware.
6335
6336 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6337
6338         * source.c (search_command_helper): Stop reverse search
6339         when line 1 has been searched.
6340
6341 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6342
6343         * record-full.c (record_full_base_target::close): Rewrite
6344         record_full_core_buf_list free logic.
6345
6346 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6347
6348         * break-catch-syscall.c (print_one_catch_syscall): xfree
6349         the last text.
6350
6351 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6352
6353         * top.c (print_gdb_version): Update Copyright year in version
6354         message.
6355
6356 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6357
6358         Update copyright year range in all GDB files.
6359
6360 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6361
6362         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6363
6364 For older changes see ChangeLog-2018.
6365 \f
6366 Local Variables:
6367 mode: change-log
6368 left-margin: 8
6369 fill-column: 74
6370 version-control: never
6371 coding: utf-8
6372 End:
6373