gdb/ChangeLog

   1 2019-08-06  Tom Tromey  <tromey@adacore.com>
   2
   3         * source-cache.c (extract_lines): No longer a method.
   4         Changed type of parameter.  Include final newline.
   5         (selftests::extract_lines_test): New function.
   6         (_initialize_source_cache): Likewise.
   7         * source-cache.h (class source_cache)
   8         <extract_lines>: Don't declare.
   9
  10 2019-08-06  Tom Tromey  <tromey@adacore.com>
  11
  12         * breakpoint.c (init_breakpoint_sal): Update.
  13         (breakpoint): Update.
  14         * breakpoint.h (struct breakpoint) <filter>: Now a
  15         unique_xmalloc_ptr.
  16
  17 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
  18
  19         * NEWS: Mention dictionary access on blocks.
  20         * python/py-block.c (blpy_getitem): New function.
  21         (block_object_as_mapping): New struct.
  22         (block_object_type): Use new struct for tp_as_mapping field.
  23
  24 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
  25
  26         * objfiles.h (objfile): Add a comment describing partial symbols.
  27
  28 2019-08-05  Tom Tromey  <tromey@adacore.com>
  29
  30         * compile/compile.c (_initialize_compile): Use _(), not N_().
  31         * thread.c (_initialize_thread): Use _(), not N_().
  32         * stack.c (_initialize_stack): Use _(), not N_().
  33         * printcmd.c (_initialize_printcmd): Use _(), not N_().
  34
  35 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
  36
  37         * dwarf2read.c (struct dw2_symtab_iterator):
  38         <want_specific_block>: Remove.
  39         <block_index>: Change type to gdb::optional.
  40         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
  41         change type of BLOCK_INDEX parameter to gdb::optional.
  42         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
  43         (dw2_lookup_symbol): Don't pass argument for
  44         WANT_SPECIFIC_BLOCK.
  45         (dw2_expand_symtabs_for_function): Don't pass argument for
  46         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
  47         (class dw2_debug_names_iterator)
  48         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
  49         parameter, change BLOCK_INDEX type to gdb::optional.
  50         <m_want_specific_block>: Remove.
  51         <m_block_index>: Change type to gdb::optional.
  52         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
  53         gdb::optional.  Re-write in function of gdb::optional.
  54         (dw2_debug_names_lookup_symbol): Don't pass argument for
  55         WANT_SPECIFIC_BLOCK.
  56         (dw2_debug_names_expand_symtabs_for_function): Don't pass
  57         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
  58         BLOCK_INDEX.
  59
  60 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  61
  62         * NEWS: Mention changes to "info sources" command.
  63
  64 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  65
  66         * symtab.c (filename_partial_match_opts): New struct type.
  67         (struct output_source_filename_data): New members
  68         regexp, c_regexp, partial_match.
  69         (output_source_filename): Use new members to decide to print file.
  70         (info_sources_option_defs): New variable.
  71         (make_info_sources_options_def_group, print_info_sources_header,
  72         info_sources_command_completer):
  73         New functions.
  74         (info_sources_command): Read new optional arguments.
  75         (_initialize_symtab): Update info sources help.
  76
  77 2019-08-02  Alexandre Oliva <oliva@adacore.com>
  78
  79         * ada-lang.c (exception_support_info_v0): Renamed from...
  80         (default_exception_support_info): ... this.  Create new
  81         definition for v1.
  82         (ada_has_this_exception_support): Look up catch_handlers_sym.
  83         (ada_exception_support_info_sniffer): Try v0 after default.
  84
  85 2019-08-01  Tom Tromey  <tromey@adacore.com>
  86
  87         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
  88         gdbarch.h.
  89
  90 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
  91
  92         * s12z-tdep.c: Fix include path for s12z-opc.h.
  93
  94 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
  95
  96         * NEWS: Require GNU make 3.82.
  97
  98 2019-07-16  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 101         declare.
 102
 103 2019-07-30  Tom Tromey  <tromey@adacore.com>
 104
 105         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 106
 107 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 108
 109         * printcmd.c (print_address_symbolic): Print negative offsets.
 110         (build_address_symbolic): Force signed arithmetic when computing
 111         offset.
 112
 113 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 114
 115         PR/24474: Add a function to lookup static variables.
 116         * NEWS: Mention this new function.
 117         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 118         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 119         * python/python.c (python_GdbMethods): Add new function.
 120
 121 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 122
 123         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 124         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 125         (objfpy_lookup_static_symbol): New function.
 126         (objfile_object_methods): Add new functions.
 127
 128 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 129
 130         * NEWS: Mention 'set|show print frame-info'.  Mention new
 131         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 132         backtrace argument.  Mention that python frame filtering code
 133         is now consistent with what 'backtrace' command prints.
 134
 135 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 136
 137         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 138         comments.
 139         (print_frame_info_auto, print_frame_info_source_line,
 140         print_frame_info_location, print_frame_info_source_and_location,
 141         print_frame_info_location_and_address, print_frame_info_short_location):
 142         New declarations.
 143         (struct frame_print_options): New member print_frame_info.
 144         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 145         * stack.h (get_user_print_what_frame_info): New declaration.
 146         (frame_show_address): New declaration.
 147         * stack.c (print_frame_arguments_choices): New value 'presence'.
 148         (print_frame_info_auto, print_frame_info_source_line,
 149         print_frame_info_location, print_frame_info_source_and_location,
 150         print_frame_info_location_and_address, print_frame_info_short_location,
 151         print_frame_info_choices, print_frame_info_print_what): New definitions.
 152         (print_frame_args): Only print dots for args if print frame-arguments
 153         is 'presence'.
 154         (frame_print_option_defs): New element for "frame-info".
 155         (get_user_print_what_frame_info): New function.
 156         (frame_show_address): Make non static.  Move comment to stack.h.
 157         (print_frame_info_to_print_what): New function.
 158         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 159         to decide what to print.
 160         (backtrace_command_1): Handle the new print_frame_arguments_presence
 161         value.
 162         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 163         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 164         (py_print_frame): In non-mi mode, use LOCATION as default for
 165         print_what, similarly to frame information printed directly by
 166         backtrace command. Handle frame-info user option in non MI mode.
 167
 168 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 169
 170         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 171         Add case for debugging 32-bit target on 64-bit host.  Revise
 172         comment.
 173
 174 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 175
 176         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 177         instead of find_function_entry_range_from_pc.
 178
 179 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 180
 181         * stack.c (find_frame_funname): Remove code which preferred
 182         minsym over symtab sym in "certain pathological cases".
 183
 184         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 185         parameter.  Change type of "do_demangle" to bool.
 186         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 187         Pass suitable "prefer_sym_over_minsym" flag to
 188         build_address_symbolic().  Don't output "+" for negative offsets.
 189         * printcmd.c (print_address_symbolic): Update invocation of
 190         build_address_symbolic to include a "prefer_sym_over_minsym"
 191         flag.
 192         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 193         Restrict cases in which use of minimal symbol is preferred to that
 194         of a found symbol.  Update comments.
 195
 196         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 197         for entry pc when entry pc is out of range for that FDE.
 198
 199 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 200
 201         PR gdb/24839:
 202         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 203         type.
 204
 205 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 206
 207         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 208         this function's Python signature.
 209
 210
 211 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 212
 213         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 214         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 215         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 216         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 217         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 218
 219
 220 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 221
 222         * h8300-tdep.c (h8300_register_name_common): New.
 223         h8300_register_name): Use h8300_register_name_common.
 224         (h8300s_register_name): Likewise.
 225         (h8300sx_register_name): Likewise.
 226         (h8300h_register_nam): New.
 227         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 228
 229
 230 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 231
 232         * arm-tdep.c (arm_skip_cmse_entry): New function.
 233         (arm_is_sgstubs_section): New function.
 234         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 235
 236 2019-07-22  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 239         Don't self-assign.
 240
 241 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 242
 243         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 244         type_print.
 245
 246 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 247
 248         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 249         so that GDB doesn't match any msymbols when searching in the
 250         TYPES_DOMAIN.
 251         (print_symbol_info): Print using typedef_print or type_print based
 252         on the type of the symbol.  Add updated FIXME comment moved from...
 253         (_initialize_symtab): ... move and update FIXME comment to above.
 254
 255 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 256
 257         * NEWS: Mention adding -q option to "info types".
 258         * symtab.c (struct info_types_options): New struct.
 259         (info_types_options_defs): New variable.
 260         (make_info_types_options_def_group): New function.
 261         (info_types_command): Use gdb::option framework to parse options.
 262         (info_types_command_completer): New function.
 263         (_initialize_symtab): Extend the help text on "info types" and
 264         register command completer.
 265
 266 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 267
 268         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 269         (lookup_symbol_in_objfile): Change int to block_enum and add a
 270         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 271
 272 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 273
 274         * MAINTAINERS (Write After Approval): Add self.
 275
 276 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 277
 278         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 279         instruction to the dummy code region.
 280
 281 2019-07-19  Tom Tromey  <tromey@adacore.com>
 282
 283         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 284         (ARGSUSED, PARAMS, __func__): Remove rules.
 285
 286 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 287
 288         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 289         * features/arm/arm-with-iwmmxt.c: Remove.
 290         * features/arm/arm-with-iwmmxt.xml: Remove.
 291         * features/arm/arm-with-m-fpa-layout.c: Remove.
 292         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 293         * features/arm/arm-with-m-vfp-d16.c: Remove.
 294         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 295         * features/arm/arm-with-m.c: Remove.
 296         * features/arm/arm-with-m.xml: Remove.
 297         * features/arm/arm-with-neon.c: Remove.
 298         * features/arm/arm-with-neon.xml: Remove.
 299         * features/arm/arm-with-vfpv2.c: Remove.
 300         * features/arm/arm-with-vfpv2.xml: Remove.
 301         * features/arm/arm-with-vfpv3.c: Remove.
 302         * features/arm/arm-with-vfpv3.xml: Remove.
 303
 304 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 305
 306         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 307
 308 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 309
 310         * arch/aarch32.c (aarch32_create_target_description): Create
 311         target descriptions using features.
 312         * arch/arm.c (arm_create_target_description)
 313         (arm_create_mprofile_target_description): Likewise.
 314         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 315
 316 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 317
 318         * Makefile.in: Add new files.
 319         * aarch32-tdep.c: New file.
 320         * aarch32-tdep.h: New file.
 321         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 322         Call aarch32_read_description.
 323         * arch/aarch32.c: New file.
 324         * arch/aarch32.h: New file.
 325         * arch/arm.c (arm_create_target_description)
 326         (arm_create_mprofile_target_description): New function.
 327         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 328         (arm_create_target_description)
 329         (arm_create_mprofile_target_description): New declaration.
 330         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 331         read_description functions.
 332         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 333         Likewise.
 334         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 335         * arm-tdep.c (tdesc_arm_list): New variable.
 336         (arm_register_g_packet_guesses): Call create description functions.
 337         (arm_read_description) (arm_read_mprofile_description): New
 338         function.
 339         * arm-tdep.h (arm_read_description)
 340         (arm_read_mprofile_description): Add declaration.
 341         * configure.tgt: Add new files.
 342
 343 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 344
 345         * top.c (new_ui_command): Open specified terminal just once.
 346
 347 2019-07-18  Tom Tromey  <tromey@adacore.com>
 348
 349         * symtab.c (main_name): Constify return type.
 350         * symfile.c (set_initial_language): Update.
 351         * symtab.h (main_name): Constify return type.
 352
 353 2019-07-17  Tom Tromey  <tom@tromey.com>
 354
 355         * tui/tui-winsource.c (tui_update_source_window)
 356         (tui_update_source_window_as_is)
 357         (tui_update_source_windows_with_line): Remove return.
 358         * tui/tui-disasm.c (tui_show_disassem)
 359         (tui_show_disassem_and_update_source): Remove return.
 360         * tui/tui.c (tui_reset): Remove return.
 361         * tui/tui-wingeneral.c
 362         (tui_check_and_display_highlight_if_needed): Remove return.
 363
 364 2019-07-17  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 367
 368 2019-07-17  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-winsource.h (struct tui_exec_info_window)
 371         (struct tui_source_window_base): Move from tui-data.h.
 372         * tui/tui-winsource.c: Move many method definitions from
 373         elsewhere.  Remove "structuring" comments.
 374         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 375         (tui_source_window_base::refresh_window): Move to
 376         tui-winsource.c.
 377         * tui/tui-win.c (tui_source_window_base::refresh_all)
 378         (tui_source_window_base::update_tab_width)
 379         (tui_source_window_base::set_new_height)
 380         (tui_source_window_base::do_make_visible_with_new_height): Move to
 381         tui-winsource.c.
 382         * tui/tui-source.h: Update.
 383         * tui/tui-source.c (tui_source_window_base::reset): Move to
 384         tui-winsource.c.
 385         * tui/tui-disasm.h: Update.
 386         * tui/tui-data.h (struct tui_exec_info_window): Move to
 387         tui-winsource.h.
 388         (struct tui_source_window_base): Likewise.
 389         * tui/tui-data.c (tui_source_window_base::clear_detail)
 390         (tui_source_window_base, ~tui_source_window_base): Move to
 391         tui-winsource.c.
 392
 393 2019-07-17  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-win.c (tui_resize_all)
 396         (tui_source_window_base::update_tab_width)
 397         (tui_adjust_win_heights): Update.
 398         (tui_win_info::make_invisible_and_set_new_height): Rename from
 399         make_invisible_and_set_new_height.
 400         * tui/tui-data.h (struct tui_win_info)
 401         <make_invisible_and_set_new_height>: New method.
 402
 403 2019-07-17  Tom Tromey  <tom@tromey.com>
 404
 405         * tui/tui.c: Update.
 406         * tui/tui-source.h (struct tui_source_window): Move from
 407         tui-data.h.
 408         * tui/tui-layout.c: Update.
 409         * tui/tui-disasm.c: Update.
 410         * tui/tui-data.h (struct tui_source_window): Move to
 411         tui-source.h.
 412
 413 2019-07-17  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 416         tui-data.h.
 417         * tui/tui-data.h (struct tui_disasm_window): Move to
 418         tui-disasm.h.
 419
 420 2019-07-17  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-regs.h (struct tui_data_item_window): Move from
 423         tui-data.h.
 424         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 425         * tui/tui-data.h (struct tui_data_item_window): Move to
 426         tui-regs.h.
 427         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui.c: Update.
 432         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 433         (tui_cmd_window::max_height): Move to tui-command.c.
 434         * tui/tui-layout.c: Update.
 435         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 436         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 437         tui-command.c.
 438         * tui/tui-command.h (struct tui_cmd_window): Move from
 439         tui-data.h.
 440         * tui/tui-command.c: Remove "structuring" comments.
 441         (tui_cmd_window::clear_detail)
 442         (tui_cmd_window::do_make_visible_with_new_height)
 443         (tui_cmd_window::max_height): Move from elsewhere.
 444
 445 2019-07-17  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 448         Now static.
 449         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 450         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 451
 452 2019-07-17  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui.c: Update.
 455         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 456         tui-regs.c.
 457         * tui/tui-windata.h: Remove file.
 458         * tui/tui-windata.c: Remove file.
 459         * tui/tui-win.c (tui_data_window::set_new_height)
 460         (tui_data_window::do_make_visible_with_new_height): Move to
 461         tui-regs.c.
 462         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 463         * tui/tui-regs.c: Remove "structuring" comments.
 464         (tui_data_window::first_data_item_displayed)
 465         (tui_data_window::delete_data_content_windows)
 466         (tui_data_window::erase_data_content)
 467         (tui_data_window::display_all_data)
 468         (tui_data_window::refresh_all)
 469         (tui_data_window::do_scroll_vertical)
 470         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 471         (tui_data_window::do_make_visible_with_new_height)
 472         (tui_data_window::refresh_window): Move from elsewhere.
 473         (_initialize_tui_regs): Move to end of file.
 474         * tui/tui-layout.c: Update.
 475         * tui/tui-hooks.c: Update.
 476         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 477         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 478         tui-regs.c.
 479         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 480
 481 2019-07-17  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 484         seen.
 485
 486 2019-07-17  Tom Tromey  <tom@tromey.com>
 487
 488         * tui/tui-win.c (tui_source_window_base::set_new_height)
 489         (tui_source_window_base::do_make_visible_with_new_height): Use
 490         m_has_locator field directly.
 491         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 492         method.
 493         (struct tui_source_window_base) <has_locator>: Likewise.
 494
 495 2019-07-17  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 498         Don't declare.
 499         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 500         Remove.
 501         * tui/tui-win.c (tui_source_window_base::set_new_height)
 502         (tui_source_window_base::set_new_height)
 503         (make_invisible_and_set_new_height)
 504         (tui_source_window_base::do_make_visible_with_new_height)
 505         (tui_source_window_base::do_make_visible_with_new_height):
 506         Update.
 507         * tui/tui-layout.c (show_source_disasm_command, show_data)
 508         (show_source_or_disasm_and_command): Update.
 509         * tui/tui-layout.c (show_layout): Update.
 510
 511 2019-07-17  Tom Tromey  <tom@tromey.com>
 512
 513         * tui/tui-layout.c (make_data_window): Remove.
 514         (show_data): Unify creation and re-initialization cases.
 515
 516 2019-07-17  Tom Tromey  <tom@tromey.com>
 517
 518         * tui/tui-layout.c (make_source_window, make_disasm_window):
 519         Remove.
 520         (show_data): Unify creation and re-initialization cases.
 521
 522 2019-07-17  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-layout.c (make_command_window): Remove.
 525         (show_source_disasm_command, show_source_or_disasm_and_command):
 526         Unify creation and re-initialization cases.
 527
 528 2019-07-17  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 531         creation and re-initialization cases.
 532
 533 2019-07-17  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-regs.c (tui_get_register): Return void.
 536
 537 2019-07-17  Tom Tromey  <tom@tromey.com>
 538
 539         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 540         Simplify.
 541
 542 2019-07-17  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 545         resetting.
 546
 547 2019-07-17  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 550         * tui/tui-regs.c (tui_reg_layout): New function.
 551         (tui_show_registers, tui_reg_command): Use it.
 552         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 553         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 554         parameters.
 555         (tui_layout_command): Remove.
 556
 557 2019-07-17  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-layout.h (tui/tui-layout): Return void.
 560         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 561
 562 2019-07-17  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-layout.c (show_source_disasm_command, show_data):
 565         Update.
 566         (reset_locator): Remove.
 567         (show_source_or_disasm_and_command): Update.
 568
 569 2019-07-17  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-source.c (tui_source_window_base::reset): Remove
 572         win_type parameter.
 573         * tui/tui-layout.c (make_command_window, make_source_window)
 574         (make_disasm_window, make_data_window)
 575         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 576         (reset_locator, show_source_or_disasm_and_command): Update.
 577         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 578         win_type parameter.
 579         (struct tui_source_window_base) <reset>: Likewise.
 580
 581 2019-07-17  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-layout.c (show_source_disasm_command): Use
 584         reset_locator.
 585         (reset_locator): New function.
 586         (init_and_make_win): Remove.
 587         (show_source_or_disasm_and_command): Use reset_locator.
 588
 589 2019-07-17  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 592         condition.
 593         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 594         Remove condition.
 595         * tui/tui-source.c (tui_source_window_base::reset): New method.
 596         * tui/tui-layout.c (make_command_window): Don't call
 597         init_and_make_win.
 598         (make_source_window, make_disasm_window): Don't call
 599         make_source_or_disasm_window.
 600         (make_data_window): Don't call init_and_make_win.  Change calling
 601         convention.
 602         (show_source_disasm_command, show_data): Simplify.
 603         (make_source_or_disasm_window): Remove.
 604         (show_source_or_disasm_and_command): Simplify.
 605         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 606         (struct tui_source_window_base) <reset>: Likewise.
 607         <execution_info>: Remove initializer.
 608         * tui/tui-data.c (tui_source_window_base): Initialize
 609         execution_info.
 610
 611 2019-07-17  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 614         variable.
 615
 616 2019-07-17  Tom Tromey  <tom@tromey.com>
 617
 618         * tui/tui.c (tui_rl_other_window): Update.
 619         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 620         superclass method first.  Always iterate over regs_content.
 621         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 622         method.
 623         * tui/tui-win.c (tui_set_focus_command): Update.
 624
 625 2019-07-17  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-win.c (tui_set_focus_command): Rename from
 628         tui_set_focus.  Call tui_enable.
 629         (tui_set_focus_command): Remove.
 630
 631 2019-07-17  Tom Tromey  <tom@tromey.com>
 632
 633         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 634         refresh_window.
 635         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 636         touchwin.
 637         (tui_data_window::refresh_window): Call refresh_window on data
 638         items.  Always call superclass refresh_window.
 639         (tui_win_info::refresh): Remove.
 640         (tui_source_window_base::refresh_window): Update.
 641         (tui_refresh_all): Update.
 642         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 643         refresh_window.
 644         (show_source_or_disasm_and_command): Likewise.
 645         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 646         (struct tui_source_window_base) <refresh>: Likewise.
 647
 648 2019-07-17  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-winsource.c (tui_clear_source_content)
 651         (tui_show_source_content): Update.
 652         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 653         whether content is empty.
 654         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 655         Remove.
 656
 657 2019-07-17  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 660         window's contents.
 661         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 662         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 663
 664 2019-07-17  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 667         (struct tui_data_item_window): Update.
 668
 669 2019-07-17  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 672         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 673         defines.
 674
 675 2019-07-17  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-winsource.h (tui_erase_source_content)
 678         (tui_clear_source_content): Remove "display_prompt" parameter.
 679         * tui/tui-winsource.c (tui_update_source_window_as_is)
 680         (tui_update_source_windows_with_addr): Update.
 681         (tui_clear_source_content): Remove "display_prompt" parameter.
 682         (tui_erase_source_content): Likewise.  Simplify.
 683         (tui_show_source_content): Update.
 684         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 685         * tui/tui-stack.c (tui_show_frame_info): Update.
 686         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 687         Remove defines.
 688
 689 2019-07-17  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 692         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 693         parameter.
 694         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 695         parameter.
 696
 697 2019-07-17  Tom Tromey  <tom@tromey.com>
 698
 699         * tui/tui-winsource.c (tui_clear_source_content)
 700         (tui_show_source_content, tui_show_exec_info_content)
 701         (tui_clear_exec_info_content): Update.
 702         * tui/tui-stack.c (tui_show_locator_content): Update.
 703         (tui_show_frame_info): Update.
 704         * tui/tui-source.h (tui_source_window): Don't declare.
 705         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 706         from tui_source_is_displayed.
 707         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 708         Remove field.
 709         (struct tui_source_window_base) <content_in_use>: New field.  Now
 710         bool.
 711         (struct tui_source_window) <showing_source_p>: New method.
 712         (TUI_SRC_WIN): Change cast.
 713         * tui/tui-data.c (tui_initialize_static_data): Update.
 714
 715 2019-07-17  Tom Tromey  <tom@tromey.com>
 716
 717         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 718         location_matches_p.
 719         * tui/tui-source.c (tui_source_window::location_matches_p): New
 720         method.
 721         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 722         method.
 723         * tui/tui-data.h (struct tui_source_window_base)
 724         <location_matches_p>: New method.
 725         (struct tui_source_window, struct tui_disasm_window)
 726         <location_matches_p>: Likewise.
 727
 728 2019-07-17  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-win.c (tui_set_win_height_command): Rename from
 731         tui_set_win_height.
 732         (tui_set_win_height_command): Remove.
 733
 734 2019-07-17  Tom Tromey  <tom@tromey.com>
 735
 736         * tui/tui-source.c (tui_source_window): New constructor.  Add
 737         observer.
 738         (~tui_source_window): New destructor.
 739         (tui_source_window::style_changed): New method.
 740         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 741         (tui_attach_detach_observers): Update.
 742         * tui/tui-data.h (struct tui_source_window): Make constructor not
 743         inline.  Add destructor.
 744         (struct tui_source_window) <style_changed>: New method.
 745         <m_observable>: New member.
 746
 747 2019-07-17  Tom Tromey  <tom@tromey.com>
 748
 749         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 750         * tui/tui-win.c (tui_resize_all): Fix typo.
 751
 752 2019-07-17  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 755         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 756         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 757         * tui/tui-win.c (window_name_completer): Use foreach.
 758         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 759         (update_tab_width): Likewise.
 760         * tui/tui-layout.c (show_layout): Update.
 761         * tui/tui-data.h (class tui_window_iterator): New.
 762         (struct all_tui_windows): New.
 763         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 764
 765 2019-07-17  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 768         parameter.  Don't reference globals.
 769         (tui_reg_command): Update.
 770
 771 2019-07-17  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-regs.c (tui_show_registers): Simplify.
 774
 775 2019-07-17  Tom Tromey  <tom@tromey.com>
 776
 777         * tui/tui-regs.c (tui_show_registers): Update.
 778         (tui_show_register_group): Add win_info parameter.
 779
 780 2019-07-17  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 783         Rename from tui_display_reg_element_at_line.
 784         (tui_data_window::display_registers_from_line): Update.
 785         * tui/tui-data.h (struct tui_data_window)
 786         <display_reg_element_at_line>: New method.
 787
 788 2019-07-17  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-regs.h (tui_display_registers_from)
 791         (tui_display_registers_from_line): Don't declare.
 792         * tui/tui-windata.c (tui_data_window::display_all_data)
 793         (tui_data_window::refresh_all)
 794         (tui_data_window::do_scroll_vertical): Update.
 795         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 796         from tui_display_registers_from.
 797         (tui_display_reg_element_at_line): Update.
 798         (tui_data_window::display_registers_from_line): Rename from
 799         tui_display_registers_from_line.
 800         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 801         display_registers_from_line>: New methods.
 802
 803 2019-07-17  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 806         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 807         from tui_erase_data_content.
 808         (tui_data_window::display_all_data)
 809         (tui_data_window::refresh_all)
 810         (tui_data_window::do_scroll_vertical): Update.
 811         * tui/tui-regs.c (tui_show_registers): Update.
 812         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 813         New method.
 814
 815 2019-07-17  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 818         declare.
 819         * tui/tui-windata.c
 820         (tui_data_window::delete_data_content_windows): Rename from
 821         tui_delete_data_content_windows.
 822         (tui_data_window::display_all_data)
 823         (tui_data_window::do_scroll_vertical): Update.
 824         * tui/tui-data.h (struct tui_data_window)
 825         <delete_data_content_windows>: New method.
 826
 827 2019-07-17  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 830         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 831
 832 2019-07-17  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 835         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 836         from tui_display_all_data.
 837         * tui/tui-win.c
 838         (tui_data_window::do_make_visible_with_new_height): Update.
 839         * tui/tui-regs.c (tui_show_registers): Update.
 840         * tui/tui-layout.c (tui_set_layout): Update.
 841         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 842         method.
 843
 844 2019-07-17  Tom Tromey  <tom@tromey.com>
 845
 846         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 847         * tui/tui-windata.c (tui_display_data_from): Remove.
 848         (tui_data_window::refresh_all): Update.
 849
 850 2019-07-17  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 853         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 854         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 855         tui_display_registers_from_line.
 856         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 857         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 858         "force_display" parameter.
 859
 860 2019-07-17  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 863         declare.
 864         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 865         Rename from tui_first_reg_element_no_inline.
 866         (tui_display_reg_element_at_line)
 867         (tui_display_registers_from_line): Update.
 868         * tui/tui-data.h (struct tui_data_window)
 869         <first_reg_element_no_inline>: New method.
 870
 871 2019-07-17  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-windata.c (tui_display_data_from)
 874         (tui_data_window::do_scroll_vertical): Update.
 875         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 876         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 877         Rename from tui_line_from_reg_element_no.
 878         (tui_display_registers_from_line): Update.
 879         * tui/tui-data.h (struct tui_data_window)
 880         <line_from_reg_element_no>: New method.
 881
 882 2019-07-17  Tom Tromey  <tom@tromey.com>
 883
 884         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 885         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 886         tui_last_regs_line_no.
 887         (tui_display_reg_element_at_line)
 888         (tui_display_registers_from_line): Update.
 889         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 890         method.
 891
 892 2019-07-17  Tom Tromey  <tom@tromey.com>
 893
 894         PR tui/24722:
 895         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 896         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 897         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 898         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 899         (tui_update_breakpoint_info): Likewise.
 900         * tui/tui-hooks.c (tui_event_create_breakpoint)
 901         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 902         Update.
 903
 904 2019-07-17  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 907
 908 2019-07-17  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-winsource.c (tui_update_source_window_as_is)
 911         (tui_update_source_windows_with_addr): Update.
 912         * tui/tui-source.h (tui_set_source_content)
 913         (tui_show_symtab_source): Add "win_info" parameter.
 914         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 915         parameter.
 916         (tui_show_symtab_source): Likewise.
 917
 918 2019-07-17  Tom Tromey  <tom@tromey.com>
 919
 920         * tui/tui-wingeneral.c
 921         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 922
 923 2019-07-17  Tom Tromey  <tom@tromey.com>
 924
 925         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 926         (struct tui_cmd_window) <can_scroll>: New method.
 927         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 928         method.
 929
 930 2019-07-17  Tom Tromey  <tromey@adacore.com>
 931
 932         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 933         do_field_signed>: Rename.  Change type of "value".
 934         * ui-out.c (ui_out::field_signed): Rename from field_int.
 935         Change type of "value".
 936         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 937         type of "value".
 938         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 939         do_field_int.  Change type of "value".
 940         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 941         do_field_int.  Change type of "value".
 942         * tracepoint.c (trace_status_mi, tfind_1)
 943         (print_one_static_tracepoint_marker): Update.
 944         * thread.c (print_thread_info_1, print_selected_thread_frame):
 945         Update.
 946         * stack.c (print_frame, print_frame_info): Update.
 947         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 948         Update.
 949         * source.c (print_source_lines_base): Update.
 950         * skip.c (info_skip_command): Update.
 951         * record-btrace.c (btrace_ui_out_decode_error)
 952         (btrace_call_history_src_line): Update.
 953         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 954         Update.
 955         * progspace.c (print_program_space): Update.
 956         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 957         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 958         do_field_int.  Change type of "value".
 959         * mi/mi-out.c (mi_ui_out::do_table_begin)
 960         (mi_ui_out::do_table_header): Update.
 961         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 962         type of "value".
 963         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 964         (mi_cmd_data_list_changed_registers, output_register)
 965         (mi_cmd_data_read_memory, mi_load_progress)
 966         (mi_cmd_trace_frame_collected): Update.
 967         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 968         Update.
 969         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 970         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 971         (mi_cmd_var_list_children, varobj_update_one): Update.
 972         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 973         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 974         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 975         * inferior.c (print_inferior): Update.
 976         * gdb_bfd.c (print_one_bfd): Update.
 977         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 978         Update.
 979         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 980         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 981         do_field_int.  Change type of "value".
 982         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 983         do_field_int.  Change type of "value".
 984         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 985         (print_one_breakpoint_location, print_it_catch_fork)
 986         (print_one_catch_fork, print_it_catch_vfork)
 987         (print_one_catch_vfork, print_it_catch_solib)
 988         (print_it_catch_exec, print_it_ranged_breakpoint)
 989         (print_mention_watchpoint, print_mention_masked_watchpoint)
 990         (bkpt_print_it, update_static_tracepoint): Update.
 991         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 992         * break-catch-syscall.c (print_it_catch_syscall): Update.
 993         * ada-tasks.c (print_ada_task_info): Update.
 994         * ada-lang.c (print_it_exception, print_mention_exception):
 995         Update.
 996
 997 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 998
 999         PR breakpoints/24541
1000         * gdbarch.c: Regenerate.
1001         * gdbarch.h: Regenerate.
1002         * gdbarch.sh: Adjust return type and parameter types for
1003         'stap_adjust_register'.
1004         (i386_stap_adjust_register): Adjust signature and return new
1005         register name.
1006         * stap-probe.c (stap_parse_register_operand): Adjust use of
1007         'gdbarch_stap_adjust_register'.
1008
1009 2019-07-17  Tom Tromey  <tromey@adacore.com>
1010
1011         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1012         declare VEC.
1013         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1014         std::vector.
1015         (struct s390_process_info): Add initializers.
1016         (s390_add_process): Use new.
1017         (s390_linux_nat_target::low_forget_process): Use delete.
1018         (s390_linux_nat_target::low_new_fork)
1019         (s390_linux_nat_target::stopped_by_watchpoint)
1020         (s390_linux_nat_target::low_prepare_to_resume)
1021         (s390_linux_nat_target::insert_watchpoint)
1022         (s390_linux_nat_target::insert_hw_breakpoint)
1023         (s390_linux_nat_target::remove_watchpoint)
1024         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1025
1026 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1027
1028         * aarch64-fbsd-nat.c: Include regcache.h.
1029         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1030         argument.
1031         (aarch64_fbsd_nat_target::fetch_registers)
1032         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1033         variable.
1034         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1035
1036 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1037
1038         * fbsd-nat.c: Include gdbarch.h.
1039
1040 2019-07-15  Tom Tromey  <tromey@adacore.com>
1041
1042         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1043
1044 2019-07-15  Tom Tromey  <tromey@adacore.com>
1045
1046         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1047         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1048         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1049         * cli-out.c (cli_ui_out::do_field_int): New method.
1050         * ui-out.c (ui_out::field_unsigned): New method.
1051         * symfile.c (generic_load): Use field_unsigned.
1052         (print_transfer_performance): Likewise.
1053         * record-btrace.c (ui_out_field_uint): Remove.
1054         (btrace_call_history_insn_range, btrace_call_history): Use
1055         field_unsigned.
1056         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1057         field_unsigned.
1058         * ui-out.h (class ui_out) <field_unsigned>: New method.
1059         <do_field_unsigned>: Likewise.
1060
1061 2019-07-15  Tom Tromey  <tromey@adacore.com>
1062
1063         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1064         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1065         * target.c (flash_erase_command): Use field_string.
1066         * infrun.c (print_signal_received_reason): Use field_string.
1067         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1068         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1069         field_string.
1070         * ada-tasks.c (print_ada_task_info): Use field_string.
1071
1072 2019-07-15  Tom Tromey  <tromey@adacore.com>
1073
1074         * target.c (flash_erase_command): Use field_core_addr.
1075         * symfile.c (generic_load): Use field_core_addr.
1076         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1077         Use field_core_addr.
1078         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1079         field_core_addr.
1080
1081 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1082
1083         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1084         value if its desired type is smaller than a CORE_ADDR and signed.
1085
1086 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1089         of changes to field names, and use new is_reference field to
1090         decide if a property is a reference or not.
1091         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1092         field.
1093         (struct dwarf2_property_baton): Update header comment, rename
1094         'referenced_type' to 'property_type' and update comments.
1095         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1096         default property type, store in property baton, update to take
1097         accound of renamed field.
1098         (read_func_scope): Update call to attr_to_dynamic_prop.
1099         (read_array_type): Likewise.
1100         (dwarf2_per_cu_addr_sized_int_type): New function.
1101         (read_subrange_index_type): Move type finding code to
1102         dwarf2_per_cu_addr_sized_int_type.
1103         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1104         (dwarf2_per_cu_addr_type): New function.
1105         (set_die_type): Update calls to attr_to_dynamic_prop.
1106
1107 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * dwarf2read.c (read_subrange_index_type): New function.
1110         (read_subrange_type): Move code into new function and call it.
1111         * gdbtypes.c (create_range_type): Add some asserts.
1112
1113 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1114
1115         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1116         update return statements.
1117         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1118         declaration, and update comment to match.
1119         * gdbtypes.c (resolve_dynamic_array): Update call to
1120         dwarf2_evaluate_property to match new return type.
1121
1122 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1123
1124         * valarith.c (value_subscripted_rvalue): Change lowerbound
1125         parameter type from int to LONGEST.
1126         * value.h (value_subscripted_rvalue): Likewise in declaration.
1127
1128 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1129
1130         * cli/cli-utils.c (info_print_command_completer): New function.
1131         * cli/cli-utils.h: Add 'completer.h' include, and forward
1132         declaration for 'struct cmd_list_element'.
1133         (info_print_command_completer): Declare.
1134         * stack.c (_initialize_stack): Add completer for 'info locals' and
1135         'info args'.
1136         * symtab.c (_initialize_symtab): Add completer for 'info
1137         variables' and 'info functions'.
1138         * NEWS: Mention completion for additional info commands.
1139
1140 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1141
1142         * cli/cli-utils.c (extract_info_print_args): Delete.
1143         (extract_arg_maybe_quoted): Delete.
1144         (info_print_options_defs): New variable.
1145         (make_info_print_options_def_group): New function.
1146         (extract_info_print_options): Define new function.
1147         * cli/cli-utils.h (extract_info_print_args): Delete.
1148         (struct info_print_options): New structure.
1149         (extract_info_print_options): Declare new function.
1150         * stack.c (info_locals_command): Update to use new
1151         extract_info_print_options, also add a header comment.
1152         (info_args_command): Likewise.
1153         * symtab.c (info_variables_command): Likewise.
1154         (info_functions_command): Likewise.
1155
1156 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1157
1158         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1159         to extract string arguments.
1160         * common/common-utils.c (extract_string_maybe_quoted): New function.
1161         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1162
1163 2019-07-11  Tom Tromey  <tromey@adacore.com>
1164
1165         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1166         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1167         * top.h (gdbinit): Don't declare.
1168         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1169         into...
1170         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1171         * top.c (gdb_init): Don't call init_cli_cmds.
1172         (gdbinit): Remove.
1173         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1174
1175 2019-07-11  Tom Tromey  <tromey@adacore.com>
1176
1177         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1178         after it has been moved.
1179
1180 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1181
1182         * valops.c (value_must_coerce_to_target): Change return type to
1183         bool.
1184         * value.h (value_must_coerce_to_target): Likewise.
1185
1186 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1187
1188         * breakpoint.c (is_hardware_watchpoint): Remove
1189         forward-declaration.
1190         (is_masked_watchpoint): Change return type to bool.
1191         (is_tracepoint): Likewise.
1192         (is_breakpoint): Likewise.
1193         (is_hardware_watchpoint): Likewise.
1194         (is_watchpoint): Likewise.
1195         (is_no_memory_software_watchpoint): Likewise.
1196         (is_catchpoint): Likewise.
1197         (breakpoint_1): Make FILTER parameter's return type bool.
1198         is_masked_watchpoint): Change return type to bool.
1199         (save_breakpoints): Make FILTER parameter's return type bool.
1200         * breakpoint.h (is_breakpoint): Change return type to bool.
1201         (is_watchpoint): Likewise.
1202         (is_catchpoint): Likewise.
1203         (is_tracepoint): Likewise.
1204
1205 2019-07-10  Tom Tromey  <tom@tromey.com>
1206
1207         * defs.h: Don't include gdbarch.h.
1208         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1209         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1210         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1211         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1212         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1213         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1214         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1215         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1216         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1217         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1218         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1219         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1220         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1221         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1222         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1223         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1224         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1225         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1226         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1227         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1228         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1229         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1230         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1231         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1232         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1233         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1234         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1235
1236 2019-07-10  Tom Tromey  <tromey@adacore.com>
1237
1238         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1239         * breakpoint.c (init_ada_exception_breakpoint): Register as
1240         bp_catchpoint.
1241         (print_one_breakpoint_location, print_one_breakpoint): Use
1242         is_ada_exception_catchpoint.
1243         * ada-lang.c (class ada_catchpoint_location): Pass
1244         bp_loc_software_breakpoint to bp_location constructor.
1245         (is_ada_exception_catchpoint): New function.
1246
1247 2019-07-10  Tom Tromey  <tromey@adacore.com>
1248
1249         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1250         VEC.
1251         (struct arm_exidx_entry): New method operator<.
1252         (struct arm_exidx_data) <section_maps>: Change type.
1253         (arm_exidx_data_free): Remove.
1254         (arm_exidx_data_key): Change type.  Move lower.
1255         (arm_exidx_new_objfile): Update.
1256         (arm_compare_exidx_entries): Remove.
1257         (arm_find_exidx_entry, _initialize_arm_tdep)
1258
1259 2019-07-10  Tom Tromey  <tromey@adacore.com>
1260
1261         * solib-spu.c (ocl_program_data_key): Change type.
1262         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1263         Update.
1264
1265 2019-07-10  Tom Tromey  <tromey@adacore.com>
1266
1267         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1268         (struct solib_aix_inferior_data) <library_list>: Change type.
1269         (solib_aix_inferior_data_handle): Change type.
1270         (get_solib_aix_inferior_data): Update.
1271         (solib_aix_free_library_list): Remove.
1272         (library_list_start_library): Update.
1273         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1274         return type.
1275         (solib_aix_get_library_list)
1276         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1277         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1278
1279 2019-07-10  Tom Tromey  <tromey@adacore.com>
1280
1281         * solib-dsbt.c (struct dsbt_info): Add initializers.
1282         (solib_dsbt_pspace_data): Change type.
1283         (dsbt_pspace_data_cleanup): Remove.
1284         (get_dsbt_info, _initialize_dsbt_solib): Update.
1285
1286 2019-07-10  Tom Tromey  <tromey@adacore.com>
1287
1288         * spu-tdep.c (spu_overlay_data): Change type.
1289         (spu_get_overlay_table, spu_overlay_new_objfile)
1290         (_initialize_spu_tdep): Update.
1291
1292 2019-07-10  Tom Tromey  <tromey@adacore.com>
1293
1294         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1295         destructor.
1296         (dbx_objfile_data_key): Change type and declare later.
1297         (DBX_SYMFILE_INFO): Rewrite.
1298         * dbxread.c (dbx_objfile_data_key): Change type.
1299         (dbx_symfile_init): Update.
1300         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1301         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1302         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1303
1304 2019-07-10  Tom Tromey  <tromey@adacore.com>
1305
1306         * jit.c (jit_program_space_key): Change type.  Move lower.
1307         (get_jit_program_space_data): Update.
1308         (jit_program_space_data_cleanup): Remove.
1309         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1310         Update.
1311         (struct jit_program_space_data): Add initializers.
1312
1313 2019-07-10  Tom Tromey  <tromey@adacore.com>
1314
1315         * solib-darwin.c (struct darwin_info): Add initializers.
1316         (solib_darwin_pspace_data): Change type.
1317         (darwin_pspace_data_cleanup): Remove.
1318         (get_darwin_info, _initialize_darwin_solib): Update.
1319
1320 2019-07-10  Tom Tromey  <tromey@adacore.com>
1321
1322         * remote-sim.c (struct sim_inferior_data): Add initializers,
1323         constructor, and destructor.
1324         (sim_inferior_data_key): Change type.  Move lower.
1325         (check_for_duplicate_sim_descriptor): Update.
1326         (get_sim_inferior_data): Use new.  Update.
1327         (~sim_inferior_data_cleanup): Rename from
1328         sim_inferior_data_cleanup.  Simplify.
1329         (gdbsim_close_inferior, simulator_command)
1330         (sim_command_completer, _initialize_remote_sim): Update.
1331         (next_pid, INITIAL_PID): Move earlier.
1332
1333 2019-07-10  Tom Tromey  <tromey@adacore.com>
1334
1335         * python/python-internal.h (create_thread_object): Return
1336         gdbpy_ref.
1337         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1338         * python/py-inferior.c (struct threadlist_entry): Add
1339         constructor.
1340         <thread_obj>: Now a gdbpy_ref.
1341         (thread_to_thread_object): Update.
1342         (add_thread_object): Use new.
1343         (delete_thread_object): Use delete.
1344         (infpy_threads): Update.
1345         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1346         GIL.
1347
1348 2019-07-10  Tom Tromey  <tromey@adacore.com>
1349
1350         * valops.c (value_cast): Specialize error message for Ada.
1351
1352 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1353
1354         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1355
1356 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1357
1358         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1359         bpstat_should_step): Return bool, adjust comments.
1360         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1361         bpstat_should_step): Likewise.
1362
1363 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1364
1365         * features/Makefile: Use feature target descriptions for Arm.
1366         * features/arm/arm-core.c: Generate new file.
1367         * features/arm/arm-fpa.c: Likewise.
1368         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1369         * features/arm/arm-m-profile.c: Likewise.
1370         * features/arm/arm-vfpv2.c: Likewise.
1371         * features/arm/arm-vfpv3.c: Likewise.
1372         * features/arm/xscale-iwmmxt.c: Likewise.
1373         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1374
1375 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1376
1377         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1378         ptrace earlier.
1379
1380 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1381
1382         * features/aarch64-pauth.c: Regenerate.
1383
1384 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1385
1386         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1387         bool.
1388         (bpstat_what): Use false instead of 0.
1389
1390 2019-07-09  Pedro Alves  <palves@redhat.com>
1391
1392         * break-catch-throw.c (is_exception_catchpoint): New.
1393         * breakpoint.c (print_one_breakpoint_location): New parameter
1394         'raw_loc'.  Handle it.  Use
1395         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1396         looking at the breakpoint's type.
1397         (print_one_breakpoint): If handling "maint info breakpoints", also
1398         print locations of exception catchpoints.
1399         * breakpoint.h (is_exception_catchpoint): Declare.
1400
1401 2019-07-09  Pedro Alves  <palves@redhat.com>
1402
1403         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1404         "addr" field.
1405         (allocate_location_exception_catchpoint): New.
1406         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1407         (initialize_throw_catchpoint_ops): Install
1408         allocate_location_exception_catchpoint as allocate_location
1409         method.
1410         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1411         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1412         bp_loc_other.
1413         (breakpoint_address_is_meaningful): Delete.
1414         (bl_address_is_meaningful): New.
1415         (breakpoint_locations_match): Adjust comment.
1416         (bp_location_from_bp_type): New, factored out of...
1417         (bp_location::bp_location(breakpoint *)): ... this.
1418         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1419         factored out of...
1420         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1421         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1422         breakpoint_address_is_meaningful.
1423         (bp_locations_compare): Adjust comment.
1424         (update_global_location_list): Use bl_address_is_meaningful
1425         instead of breakpoint_address_is_meaningful.
1426         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1427         explicit.
1428         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1429         * python/py-breakpoint.c (bppy_get_location): No longer check
1430         whether location is null.
1431
1432 2019-07-09  Pedro Alves  <palves@redhat.com>
1433
1434         PR c++/15468
1435         * breakpoint.c (print_one_breakpoint_location): Remove
1436         single-location assert.
1437
1438 2019-07-09  Tom Tromey  <tom@tromey.com>
1439
1440         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1441         * configure: Rebuild.
1442         * configure.ac: Change common to gdbsupport.
1443         * gdbsupport: Rename from common.
1444         * acinclude.m4: Change common to gdbsupport.
1445         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1446         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1447         gdbsupport.
1448         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1449         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1450         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1451         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1452         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1453         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1454         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1455         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1456         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1457         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1458         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1459         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1460         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1461         coff-pe-read.c, command.h, compile/compile-c-support.c,
1462         compile/compile-c.h, compile/compile-cplus-symbols.c,
1463         compile/compile-cplus-types.c, compile/compile-cplus.h,
1464         compile/compile-loc2c.c, compile/compile.c, completer.c,
1465         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1466         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1467         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1468         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1469         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1470         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1471         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1472         features/aarch64-core.c, features/aarch64-fpu.c,
1473         features/aarch64-pauth.c, features/aarch64-sve.c,
1474         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1475         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1476         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1477         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1478         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1479         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1480         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1481         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1482         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1483         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1484         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1485         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1486         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1487         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1488         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1489         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1490         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1491         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1492         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1493         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1494         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1495         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1496         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1497         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1498         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1499         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1500         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1501         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1502         minsyms.c, mips-linux-tdep.c, namespace.h,
1503         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1504         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1505         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1506         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1507         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1508         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1509         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1510         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1511         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1512         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1513         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1514         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1515         procfs.c, producer.c, progspace.h, psymtab.h,
1516         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1517         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1518         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1519         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1520         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1521         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1522         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1523         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1524         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1525         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1526         target-memory.c, target.c, target.h, target/waitstatus.c,
1527         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1528         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1529         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1530         unittests/array-view-selftests.c,
1531         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1532         unittests/common-utils-selftests.c,
1533         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1534         unittests/format_pieces-selftests.c,
1535         unittests/function-view-selftests.c,
1536         unittests/lookup_name_info-selftests.c,
1537         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1538         unittests/mkdir-recursive-selftests.c,
1539         unittests/observable-selftests.c,
1540         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1541         unittests/parse-connection-spec-selftests.c,
1542         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1543         unittests/scoped_fd-selftests.c,
1544         unittests/scoped_mmap-selftests.c,
1545         unittests/scoped_restore-selftests.c,
1546         unittests/string_view-selftests.c, unittests/style-selftests.c,
1547         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1548         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1549         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1550         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1551         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1552         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1553
1554 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1555
1556         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1557         bool value.
1558         (decode_digits_ordinary): Set explicit_line field in sal.
1559         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1560         symtab_and_line that was set on an explicit line number in
1561         assembler code.  Do always update the recorded symtab and line if
1562         we do skip the prologue.
1563
1564 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1565
1566         * breakpoint.c (set_breakpoint_location_function): Remove
1567         explicit_loc parameter.
1568         (momentary_breakpoint_from_master): Update call to
1569         set_breakpoint_location_function.
1570         (add_location_to_breakpoint): Likewise.
1571
1572 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1575         required features based on default bfd type when no specific bfd
1576         is present.
1577
1578 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1579
1580         * NEWS: Mention that GDB printf and eval commands can now print
1581         C-style and Ada-style convenience var strings without
1582         calling the inferior.
1583         * printcmd.c (printf_c_string): Locally print GDB internal var
1584         instead of transiting via the inferior.
1585         (printf_wide_c_string): Likewise.
1586
1587 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1588
1589         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1590
1591 2019-07-04  Tom Tromey  <tom@tromey.com>
1592
1593         PR tui/24724:
1594         * tui/tui-winsource.c (tui_clear_source_content): Update.
1595         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1596         (tui_update_breakpoint_info): Update.
1597         (tui_set_exec_info_content): Update.
1598         * tui/tui-source.c (tui_set_source_content_nil): Update.
1599         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1600         has_break.
1601         * tui/tui-data.h (enum tui_bp_flag): New.
1602         (tui_bp_flags): New enum flags type.
1603         (struct tui_source_element) <break_mode>: Change type.  Rename
1604         from has_break.
1605         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1606         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1607         constants.
1608         * tui/tui-winsource.h: Fix comment.
1609
1610 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1611
1612         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1613         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1614         (store_fpregs_to_thread)
1615         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1616         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1617         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1618         (IWMMXT_REGS_SIZE): Add define.
1619         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1620         (fetch_vfp_regs, store_vfp_regs)
1621         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1622         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1623
1624 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1625
1626         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1627         defines.
1628         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1629         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1630         (ARM_INT_REGISTER_SIZE): ...to this.
1631         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1632         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1633         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1634         (arm_linux_collect_gregset, supply_nwfpe_register)
1635         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1636         defines.
1637         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1638         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1639         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1640         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1641         (arm_return_in_memory, arm_store_return_value)
1642         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1643         (arm_record_ld_st_multiple): Likewise.
1644         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1645         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1646
1647 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1648
1649         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1650         AARCH64_DISPLACED_MODIFIED_INSNS.
1651         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1652         (aarch64_displaced_step_copy_insn): Likewise.
1653         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1654         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1655         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1656         ARM_DISPLACED_MODIFIED_INSNS.
1657         * arm-tdep.c (arm_gdbarch_init): Likewise.
1658         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1659         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1660         (struct arm_displaced_step_closure): Use
1661         ARM_DISPLACED_MODIFIED_INSNS.
1662
1663 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1664
1665         * features/Makefile: Remove unused xml files.
1666         * features/aarch64.xml: Remove.
1667         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1668         * features/i386/amd64-avx-avx512.xml: Remove.
1669         * features/i386/amd64-avx-linux.xml: Remove.
1670         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1671         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1672         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1673         * features/i386/amd64-avx-mpx.xml: Remove.
1674         * features/i386/amd64-avx.xml: Remove.
1675         * features/i386/amd64-linux.xml: Remove.
1676         * features/i386/amd64-mpx-linux.xml: Remove.
1677         * features/i386/amd64-mpx.xml: Remove.
1678         * features/i386/amd64.xml: Remove.
1679         * features/i386/i386-avx-avx512-linux.xml: Remove.
1680         * features/i386/i386-avx-avx512.xml: Remove.
1681         * features/i386/i386-avx-linux.xml: Remove.
1682         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1683         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1684         * features/i386/i386-avx-mpx-linux.xml: Remove.
1685         * features/i386/i386-avx-mpx.xml: Remove.
1686         * features/i386/i386-avx.xml: Remove.
1687         * features/i386/i386-linux.xml: Remove.
1688         * features/i386/i386-mmx-linux.xml: Remove.
1689         * features/i386/i386-mmx.xml: Remove.
1690         * features/i386/i386-mpx-linux.xml: Remove.
1691         * features/i386/i386-mpx.xml: Remove.
1692         * features/i386/i386.xml: Remove.
1693         * features/i386/x32-avx-avx512-linux.xml: Remove.
1694         * features/i386/x32-avx-linux.xml: Remove.
1695         * features/i386/x32-linux.xml: Remove.
1696
1697 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1698
1699         * regformats/aarch64.dat: Remove.
1700         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1701         * regformats/i386/amd64-avx-linux.dat: Remove.
1702         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1703         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1704         * regformats/i386/amd64-linux.dat: Remove.
1705         * regformats/i386/amd64-mpx-linux.dat: Remove.
1706         * regformats/i386/amd64.dat: Remove.
1707         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1708         * regformats/i386/i386-avx-linux.dat: Remove.
1709         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1710         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1711         * regformats/i386/i386-linux.dat: Remove.
1712         * regformats/i386/i386-mmx-linux.dat: Remove.
1713         * regformats/i386/i386-mpx-linux.dat: Remove.
1714         * regformats/i386/i386.dat: Remove.
1715         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1716         * regformats/i386/x32-avx-linux.dat: Remove.
1717         * regformats/i386/x32-linux.dat: Remove.
1718
1719 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1720
1721         * aarch64-tdep.c: Remove xml self tests.
1722         * amd64-linux-tdep.c: Likewise.
1723         * amd64-tdep.c: Likewise.
1724         * i386-linux-tdep.c: Likewise.
1725         * i386-tdep.c: Likewise.
1726
1727 2019-07-03  Pedro Alves  <palves@redhat.com>
1728
1729         PR cli/24732
1730         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1731         (pipe_cmd_option_defs): New.
1732         (make_pipe_cmd_options_def_group): New.
1733         (pipe_command): Use gdb::option::process_options.
1734         (pipe_command_completer): New function.
1735         (_initialize_cli_cmds): Install completer for "pipe" command.
1736
1737 2019-07-03  Pedro Alves  <palves@redhat.com>
1738
1739         * cli/cli-option.c (union option_value) <string>: New field.
1740         (struct option_def_and_value): Add ctor, move ctor, dtor and
1741         use DISABLE_COPY_AND_ASSIGN.
1742         (option_def_and_value::clear_value): New.
1743         (parse_option, save_option_value_in_ctx, get_val_type_str)
1744         (add_setshow_cmds_for_options): Handle var_string.
1745         * cli-option.h (union option_def::var_address) <string>: New
1746         field.
1747         (struct string_option_def): New.
1748         * maint-test-options.c (struct test_options_opts): Add default
1749         ctor and use DISABLE_COPY_AND_ASSIGN.
1750         <string_opt>: New field.
1751         (test_options_opts::~test_options_opts): New.
1752         (test_options_opts::dump): Also dump "-string".
1753         (test_options_option_defs): Install "string.
1754
1755 2019-07-03  Pedro Alves  <palves@redhat.com>
1756
1757         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1758         option_value with a null enumeration.
1759         (complete_options): Save the option values in the context.
1760         (save_option_value_in_ctx): New, factored out from ...
1761         (process_options): ... here.
1762         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1763         of the function.
1764         * maint-test-options.c (test_options_opts::dump): New, factored
1765         out from ...
1766         (maintenance_test_options_command_mode): ... here.
1767         (maintenance_test_options_command_completion_result): Delete.
1768         (maintenance_test_options_command_completion_text): Update
1769         comment.
1770         (maintenance_show_test_options_completion_result): Change
1771         prototype.  Just print
1772         maintenance_test_options_command_completion_text.
1773         (save_completion_result): New.
1774         (maintenance_test_options_completer_mode): Pass options context to
1775         complete_options, and then save a dump.
1776         (_initialize_maint_test_options): Use add_cmd to install "maint
1777         show test-options-completion-result".
1778
1779 2019-07-03  Pedro Alves  <palves@redhat.com>
1780
1781         * NEWS (New commands): Mention "with" and "maint with".
1782         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1783         (with_command, with_command_completer): New.
1784         (pipe_command): Adjust to new repeat_previous
1785         interface.
1786         (_initialize_cli_cmds): Install the "with" command and its "w"
1787         alias.
1788         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1789         declarations.
1790         * cli/cli-setshow.c (parse_cli_var_uinteger)
1791         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1792         argument strings for all var_types.
1793         (get_setshow_command_value_string): New, factored out from ...
1794         (do_show_command): ... this.
1795         * cli/cli-setshow.h: Include <string>.
1796         (get_setshow_command_value_string): Declare.
1797         * command.h (repeat_previous): Now returns const char *.  Adjust
1798         comment.
1799         * maint.c: Include "cli/cli-cmds.h".
1800         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1801         (_initialize_maint_cmds): Register the "maintenance with" command.
1802         * top.c (repeat_previous): Move bits from pipe_command here:
1803         Return the saved command line, if any; error out if there's no
1804         command to relaunch.
1805
1806 2019-07-03  Pedro Alves  <palves@redhat.com>
1807
1808         * NEWS (New commands): Mention "maint set/show test-settings"
1809         instead of "maint test-settings".
1810         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1811         (maintenance_test_settings_set_list): Rename to ...
1812         (maintenance_set_test_settings_list): ... this.
1813         (maintenance_test_settings_show_list): Rename to  ...
1814         (maintenance_show_test_settings_list): ... this.
1815         (maintenance_test_settings_cmd): Delete.
1816         (maintenance_test_settings_set_cmd): ...
1817         (maintenance_set_test_settings_cmd): ... this.
1818         (maintenance_test_settings_show_cmd): ...
1819         (maintenance_show_test_settings_cmd): ... this.
1820         (maintenance_test_settings_show_value_cmd):
1821         (maintenance_show_test_settings_value_cmd): ... this.
1822         (_initialize_maint_test_settings): No longer install the "maint
1823         test-settings" prefix command.  Rename "maint test-settings set"
1824         to "maint set test-settings", and "maint test-settings show" to
1825         "maint show test-settings".  Adjust all subcommands.
1826
1827 2019-07-03  Pedro Alves  <palves@redhat.com>
1828
1829         * maint-test-settings.c: Fix file's intro comment.  Replace all
1830         references to "test-options" with references to "test-settings",
1831         in comments.
1832
1833 2019-07-03  Pedro Alves  <palves@redhat.com>
1834
1835         * maint-test-settings.c (maintenance_test_settings_xxx)
1836         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1837         New.
1838         (maintenance_test_settings_enums): Use them.
1839         (maintenance_test_settings_enum): Default to
1840         maintenance_test_settings_xxx.
1841         (_initialize_maint_test_settings): Initialize
1842         MAINTENANCE_TEST_SETTINGS_FILENAME.
1843
1844 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1845
1846         * breakpoint.h (remove_breakpoints_inf): Change return type to
1847         void, move function documentation here.
1848         * breakpoint.c (remove_breakpoints_inf): Change return type to
1849         void, move function documentation to header.
1850
1851 2019-07-02  Pedro Alves  <palves@redhat.com>
1852
1853         * NEWS (Completion improvements): Mention "info threads".
1854         * thread.c (struct info_threads_opts, info_threads_option_defs)
1855         (make_info_threads_options_def_group): New.
1856         (info_threads_command): Use gdb::option::process_options.
1857         (info_threads_command_completer): New.
1858         (_initialize_thread): Use gdb::option::build_help to build the
1859         help text for "info threads".
1860
1861 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1862
1863         * defs.h (generic_load): Move from here...
1864         * symfile.h (generic_load): ... to here.  Rename name parameter
1865         to args.
1866         * symfile.c (generic_load): Add comment.
1867
1868 2019-07-01  Tom Tromey  <tromey@adacore.com>
1869
1870         * dwarf2read.c
1871         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1872         declaration of without_params.  Fix formatting.
1873
1874 2019-07-01  Tom Tromey  <tromey@adacore.com>
1875
1876         * ada-exp.y (find_primitive_type): Update.
1877         * ada-lang.h (ada_lookup_symbol): Update.
1878         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1879         parameter.
1880         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1881
1882 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1883
1884         PR breakpoints/24541
1885         * gdbarch.c: Regenerate.
1886         * gdbarch.h: Regenerate.
1887         * gdbarch.sh: Add 'stap_adjust_register'.
1888         * i386-tdep.c: Include '<unordered_set>'.
1889         (i386_stap_adjust_register): New function.
1890         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1891         * stap-probe.c (stap_parse_register_operand): Call
1892         'gdbarch_stap_adjust_register'.
1893
1894 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1895
1896         PR python/24742
1897         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1898         * python/python.c (do_start_initialization): Use 'xmalloc'
1899         instead of 'PyMem_Malloc'.
1900
1901 2019-06-28  Tom Tromey  <tromey@adacore.com>
1902
1903         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1904         for Ada.
1905
1906 2019-06-27  Tom Tromey  <tromey@adacore.com>
1907
1908         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1909         objfile_key.
1910         (arm_find_mapping_symbol, arm_record_special_symbol)
1911         (_initialize_arm_tdep): Update.
1912         (arm_objfile_data_free): Remove.
1913
1914 2019-06-27  Tom Tromey  <tromey@adacore.com>
1915
1916         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1917         to cp_print_static_field.
1918
1919 2019-06-26  Tom Tromey  <tromey@adacore.com>
1920
1921         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1922         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1923         declare.
1924
1925 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1926
1927         * features/aarch64-core.c (create_feature_aarch64_core):
1928         Regenerate.
1929         * features/aarch64-core.xml: Add cpsr flags.
1930
1931 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1932
1933         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1934         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1935
1936 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1937
1938         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1939         field.
1940         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1941         use.
1942         (arm_record_special_symbol): Don't insert new symbol in sorted
1943         position, push it at the end.
1944
1945 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1946
1947         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1948         (arm_mapping_symbol_s): Remove.
1949         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1950         (arm_mapping_symbol_vec): New typedef.
1951         (struct arm_per_objfile): Add constructor.
1952         <section_maps>: Change type to
1953         std::unique_ptr<arm_mapping_symbol_vec[]>.
1954         (arm_compare_mapping_symbols): Remove.
1955         (arm_find_mapping_symbol): Adjust to section_maps type change.
1956         (arm_objfile_data_free): Call delete on arm_per_objfile.
1957         (arm_record_special_symbol): Adjust to section_maps type change.
1958         Allocate arm_per_objfile with new.
1959
1960 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1961
1962         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1963         with the command prefix.
1964
1965 2019-06-25  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1968         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1969
1970 2019-06-25  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1973         type.
1974         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1975         protected.
1976
1977 2019-06-25  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-winsource.c
1980         (tui_source_window_base::set_is_exec_point_at): Add check against
1981         LOA_ADDRESS.
1982
1983 2019-06-25  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-source.c (tui_set_source_content): Don't check before
1986         xfree.
1987         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1988
1989 2019-06-25  Tom Tromey  <tom@tromey.com>
1990
1991         * tui/tui-winsource.h (tui_update_source_window_as_is)
1992         (tui_alloc_source_buffer, tui_line_is_displayed)
1993         (tui_addr_is_displayed): Change type of win_info.
1994         * tui/tui-winsource.c (tui_update_source_window_as_is)
1995         (tui_clear_source_content, tui_show_source_line)
1996         (tui_show_source_content, tui_source_window_base::refill)
1997         (tui_source_window_base::set_is_exec_point_at)
1998         (tui_source_window_base::set_is_exec_point_at)
1999         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2000         (tui_alloc_source_buffer, tui_line_is_displayed)
2001         (tui_addr_is_displayed): Change type of win_info.  Update.
2002         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2003         (tui_source_window_base::do_make_visible_with_new_height):
2004         Update.
2005         * tui/tui-source.c (tui_set_source_content)
2006         (tui_set_source_content_nil)
2007         (tui_source_window::do_scroll_vertical): Update.
2008         * tui/tui-layout.c (show_layout): Update.
2009         * tui/tui-disasm.c (tui_set_disassem_content)
2010         (tui_disasm_window::do_scroll_vertical): Update.
2011         * tui/tui-data.h (tui_win_content): Remove.
2012         (struct tui_gen_win_info) <content, content_size>: Remove.
2013         (struct tui_source_element): Add initializers and destructor.
2014         (union tui_which_element, struct tui_win_element): Remove.
2015         (struct tui_source_window_base) <content>: New field.
2016         (struct tui_data_window): Remove destructor.
2017         (tui_alloc_content, tui_free_win_content)
2018         (tui_free_all_source_wins_content): Don't declare.
2019         * tui/tui-data.c (tui_initialize_static_data): Update.
2020         (init_content_element, tui_alloc_content): Remove.
2021         (~tui_gen_win_info): Update.
2022         (~tui_data_window, tui_free_all_source_wins_content)
2023         (tui_free_win_content, free_content, free_content_elements):
2024         Remove.
2025
2026 2019-06-25  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-winsource.h (tui_clear_source_content)
2029         (tui_erase_source_content, tui_show_source_content): Change type
2030         of win_info.
2031         * tui/tui-winsource.c (tui_clear_source_content)
2032         (tui_erase_source_content, tui_show_source_content): Change type
2033         of win_info.
2034         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2035         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2036         win_info.
2037         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2038         win_info.
2039         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2040
2041 2019-06-25  Tom Tromey  <tom@tromey.com>
2042
2043         * tui/tui-winsource.c (tui_clear_source_content)
2044         (tui_source_window_base::set_is_exec_point_at): Update.
2045         * tui/tui-source.c (tui_set_source_content_nil): Update.
2046         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2047         a bool.
2048         * tui/tui-data.c (init_content_element): Update.
2049
2050 2019-06-25  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2053         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2054         * tui/tui-layout.c (init_and_make_win): Update.
2055         * tui/tui.h (enum tui_win_type): Update.
2056         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2057         tui_win_is_auxillary.
2058         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2059         tui_win_is_auxillary.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2064         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2065         (tui_delete_data_content_windows, tui_display_all_data)
2066         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2067         Update.
2068         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2069         * tui/tui-regs.c (tui_last_regs_line_no)
2070         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2071         (tui_show_registers): Update.
2072         (tui_show_register_group): Return void.  Update.
2073         (tui_display_registers_from, tui_display_reg_element_at_line)
2074         (tui_display_registers_from_line, tui_check_register_values):
2075         Update.
2076         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2077         member.
2078         (struct tui_data_window) <regs_content>: Now a std::vector.
2079         <regs_content_count>: Remove.
2080         (tui_add_content_elements, tui_free_data_content): Don't declare.
2081         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2082         (init_content_element): Remove DATA_WIN case.  Add assert.
2083         (tui_add_content_elements): Remove.
2084         (tui_data_window): Update.
2085         (tui_free_data_content): Remove.
2086         (free_content_elements): Remove DATA_WIN case.
2087
2088 2019-06-25  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-data.c (tui_data_item_window): Update.
2091         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2092         * tui/tui-windata.c (tui_display_all_data)
2093         (tui_display_data_from_line): Update.
2094         (tui_check_data_values): Remove.
2095         * tui/tui-regs.c (tui_show_register_group)
2096         (tui_display_reg_element_at_line): Update.
2097         * tui/tui-hooks.c (tui_register_changed)
2098         (tui_refresh_frame_and_register_information): Call
2099         tui_check_register_values.
2100         * tui/tui-data.h (struct tui_data_window) <data_content,
2101         data_content_count, data_type>: Remove.
2102         (enum tui_data_type): Remove.
2103
2104         * tui/tui-data.c (tui_data_window::clear_detail)
2105         (~tui_data_window): Update.
2106
2107 2019-06-25  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2110         declare.
2111         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2112         Rename from tui_first_data_item_displayed.  Update.
2113         (tui_data_window::refresh_all)
2114         (tui_data_window::do_scroll_vertical): Update.
2115         * tui/tui-data.h (struct tui_data_window)
2116         <first_data_item_displayed>: Declare new method.
2117
2118 2019-06-25  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2121         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2122         contents...
2123         (tui_initialize_static_data): ...here.
2124
2125 2019-06-25  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2128         (tui_display_registers_from, tui_check_register_values): Update.
2129         (tui_display_register): Remove win_info parameter; update.
2130         (tui_get_register): Change type of parameters.
2131         * tui/tui-data.h (struct tui_data_element): Remove.
2132         (union tui_which_element) <data>: Remove.
2133         <data_window>: Change type.
2134         (struct tui_data_item_window): New.
2135         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2136         case.  Add assert.
2137         (~tui_data_item_window): New destructor.
2138         (free_content_elements): Remove DATA_ITEM_WIN case.
2139
2140 2019-06-25  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2143         Remove.
2144
2145 2019-06-25  Tom Tromey  <tom@tromey.com>
2146
2147         * tui/tui-data.h (struct tui_command_element): Remove.
2148         (union tui_which_element) <command>: Remove.
2149         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2150         assert.
2151         (free_content_elements): Remove CMD_WIN case.
2152
2153 2019-06-25  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-layout.c (tui_set_layout): Update.
2156         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2157         * tui/tui-data.c (layout_def): Update.
2158
2159 2019-06-25  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2162         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2163         (tui_source_window_base::set_new_height): Update.
2164         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2165         Update.
2166         (tui_set_locator_fullname, tui_set_locator_info)
2167         (tui_show_frame_info): Update.
2168         * tui/tui-source.c (tui_set_source_content)
2169         (tui_source_is_displayed): Update.
2170         * tui/tui-layout.c (show_source_disasm_command, show_data)
2171         (show_source_or_disasm_and_command): Update.
2172         * tui/tui-disasm.c (tui_set_disassem_content)
2173         (tui_get_begin_asm_address): Update.
2174         * tui/tui-data.h (struct tui_locator_element): Remove.
2175         (union tui_which_element) <locator>: Remove.
2176         (struct tui_locator_window): New.
2177         (tui_locator_win_info_ptr): Change return type.
2178         * tui/tui-data.c (_locator): Change type.
2179         (tui_locator_win_info_ptr): Change return type.
2180         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2181         (tui_alloc_content): Add assert.
2182
2183 2019-06-25  Tom Tromey  <tom@tromey.com>
2184
2185         * tui/tui-winsource.c
2186         (tui_exec_info_window::maybe_allocate_content): New method.
2187         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2188         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2189         (make_source_or_disasm_window): Add cast.
2190         * tui/tui-data.h (union tui_which_element) <simple_string>:
2191         Remove.
2192         (struct tui_source_info): New.
2193         (struct tui_source_window_base) <execution_info>: Change type.
2194         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2195         case, and add assert.
2196         (tui_alloc_content): Add assert.
2197
2198 2019-06-25  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2201         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2202         * tui/tui-data.c (tui_alloc_win_info): Remove.
2203
2204 2019-06-25  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2207         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2208         can_highlight.
2209
2210 2019-06-25  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2213         make_visible_with_new_height method.
2214         (tui_win_info::make_visible_with_new_height): New method.
2215         (tui_source_window_base::do_make_visible_with_new_height)
2216         (tui_data_window::do_make_visible_with_new_height)
2217         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2218         (make_visible_with_new_height): Remove.
2219         (tui_resize_all, tui_adjust_win_heights): Use
2220         make_visible_with_new_height method.
2221         * tui/tui-data.h (struct tui_win_info)
2222         <do_make_visible_with_new_height, make_visible_with_new_height>:
2223         New methods.
2224         (struct tui_source_window_base, struct tui_data_window)
2225         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2226         methods.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2231         method.
2232         (update_tab_width): Call update_tab_width method.
2233         * tui/tui-data.h (struct tui_win_info)
2234         (struct tui_source_window_base) <update_tab_width>: New methods.
2235
2236 2019-06-25  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2239         parameter.
2240         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2241         parameter.
2242         (tui_gen_win_info::make_visible): Update.
2243         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2244         parameter.
2245         * tui/tui-data.h (enum tui_box): New enum.
2246         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2247
2248 2019-06-25  Tom Tromey  <tom@tromey.com>
2249
2250         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2251         init_and_make_win for EXEC_INFO_WIN.
2252         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2253         longer inline.
2254         (struct tui_win_info) <~tui_win_info>: Inline.
2255         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2256         Don't declare.
2257         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2258         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2259         Remove.
2260         (tui_initialize_static_data): Update.
2261         (~tui_gen_win_info): Handle more cleanup here.
2262         (~tui_source_window_base): Delete "execution_info".
2263         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2264
2265 2019-06-25  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-layout.c (make_command_window): Don't set
2268         can_highlight.
2269         (show_source_disasm_command): Call the reset method.
2270         (show_data): Don't set can_highlight.  Call the reset method.
2271         (tui_gen_win_info::reset): Rename from init_gen_win_info
2272         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2273         (show_source_or_disasm_and_command): Call the reset method.
2274         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2275         (struct tui_cmd_window): Set can_highlight.
2276
2277 2019-06-25  Tom Tromey  <tom@tromey.com>
2278
2279         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2280         from make_visible.
2281         (tui_make_visible, tui_make_invisible): Rewrite.
2282         (tui_win_info::make_visible): Remove.
2283         (tui_source_window_base::make_visible): Update.
2284         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2285         method.  Moved from...
2286         (struct tui_win_info) <make_visible>: ...here.
2287
2288 2019-06-25  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-winsource.c
2291         (tui_source_window_base::do_scroll_horizontal): Remove direction
2292         parameter.
2293         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2294         direction parameter.
2295         * tui/tui-win.c (tui_win_info::forward_scroll)
2296         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2297         (tui_win_info::right_scroll): Update.
2298         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2299         direction parameter.
2300         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2301         direction parameter.
2302         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2303         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2304         Remove direction parameter.
2305         (struct tui_source_window_base, struct tui_source_window)
2306         (struct tui_disasm_window, struct tui_data_window)
2307         (struct tui_cmd_window): Update.
2308
2309 2019-06-25  Tom Tromey  <tom@tromey.com>
2310
2311         * tui/tui-winsource.h (tui_set_exec_info_content)
2312         (tui_show_exec_info_content, tui_erase_exec_info_content)
2313         (tui_clear_exec_info_content, tui_update_exec_info): Change
2314         argument to tui_source_window_base.
2315         * tui/tui-winsource.c (tui_set_exec_info_content)
2316         (tui_show_exec_info_content, tui_erase_exec_info_content)
2317         (tui_clear_exec_info_content, tui_update_exec_info): Change
2318         argument to tui_source_window_base.
2319
2320 2019-06-25  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2323         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2324
2325 2019-06-25  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2328         check.
2329
2330 2019-06-25  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2333         type to void.
2334         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2335         type to void.
2336         * tui/tui-source.c (tui_set_source_content): Update.
2337         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2338
2339 2019-06-25  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-win.c (window_name_completer, tui_set_focus)
2342         (tui_all_windows_info): Use name method.
2343         * tui/tui-data.h (struct tui_gen_win_info)
2344         (struct tui_source_window, struct tui_disasm_window)
2345         (struct tui_data_window, struct tui_cmd_window) <name>: New
2346         method.
2347         (tui_win_name): Don't declare.
2348         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2349         (tui_win_name): Remove.
2350
2351 2019-06-25  Tom Tromey  <tom@tromey.com>
2352
2353         * tui/tui-winsource.h (tui_update_source_window)
2354         (tui_update_source_window_as_is): Change parameter type.
2355         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2356         to be a tui_source_window_base.
2357         (tui_update_source_window_as_is): Likewise.
2358         * tui/tui-win.c (make_visible_with_new_height): Update.
2359
2360 2019-06-25  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-winsource.c (tui_erase_source_content)
2363         (tui_show_source_content, tui_show_exec_info_content)
2364         (tui_erase_exec_info_content): Use refresh_window method.
2365         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2366         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2367         from tui_refresh_win.
2368         (tui_data_window::refresh_window): New method.
2369         (tui_win_info::refresh, tui_source_window_base::refresh)
2370         (tui_refresh_all): Use refresh_window method.
2371         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2372         method.
2373         * tui/tui-regs.c (tui_display_register): Call refresh_window
2374         method.
2375         * tui/tui-layout.c (show_source_disasm_command)
2376         (show_source_or_disasm_and_command): Call refresh_window method.
2377         * tui/tui-data.h (struct tui_gen_win_info)
2378         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2379         New method.
2380
2381 2019-06-25  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui.c (tui_rl_other_window, tui_enable)
2384         (tui_is_window_visible, tui_get_command_dimension): Update.
2385         * tui/tui-winsource.c (tui_update_source_window_as_is)
2386         (tui_clear_source_content, tui_erase_source_content)
2387         (tui_show_source_line, tui_source_window_base::refill)
2388         (tui_source_window_base::do_scroll_horizontal)
2389         (tui_source_window_base::set_is_exec_point_at)
2390         (tui_update_breakpoint_info, tui_set_exec_info_content)
2391         (tui_alloc_source_buffer, tui_line_is_displayed)
2392         (tui_addr_is_displayed): Update.
2393         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2394         (tui_check_and_display_highlight_if_needed)
2395         (tui_win_info::make_visible, tui_win_info::refresh)
2396         (tui_refresh_all): Update.
2397         * tui/tui-windata.c (tui_first_data_item_displayed)
2398         (tui_delete_data_content_windows, tui_erase_data_content)
2399         (tui_display_all_data, tui_data_window::refresh_all)
2400         (tui_check_data_values): Update.
2401         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2402         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2403         (tui_win_info::backward_scroll, tui_refresh_all_win)
2404         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2405         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2406         (tui_source_window_base::set_new_height)
2407         (tui_data_window::set_new_height)
2408         (make_invisible_and_set_new_height)
2409         (make_visible_with_new_height, new_height_ok)
2410         (parse_scrolling_args): Update.
2411         * tui/tui-stack.c (tui_show_frame_info): Update.
2412         * tui/tui-source.c (tui_set_source_content)
2413         (tui_set_source_content_nil, tui_source_is_displayed)
2414         (tui_source_window::do_scroll_vertical): Update.
2415         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2416         (tui_display_registers_from, tui_display_reg_element_at_line)
2417         (tui_check_register_values, tui_reg_command): Update.
2418         * tui/tui-layout.c (tui_default_win_height)
2419         (show_source_disasm_command, show_data, init_and_make_win)
2420         (show_source_or_disasm_and_command): Update.
2421         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2422         (tui_redisplay_readline, tui_mld_flush)
2423         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2424         (tui_getc): Update.
2425         * tui/tui-disasm.c (tui_set_disassem_content)
2426         (tui_disasm_window::do_scroll_vertical): Update.
2427         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2428         Now virtual.
2429         (struct tui_win_info): Derive from tui_gen_win_info.
2430         <~tui_win_info>: Mark as override.
2431         <generic>: Remove member.
2432         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2433         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2434         (~tui_data_window, ~tui_win_info)
2435         (tui_free_all_source_wins_content): Update.
2436         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2437
2438 2019-06-25  Tom Tromey  <tom@tromey.com>
2439
2440         * tui/tui-layout.c (init_and_make_win): Use new.
2441         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2442         destructor, initializers.
2443         (tui_alloc_generic_win_info): Don't declare.
2444         * tui/tui-data.c (_locator): Add argument to constructor.
2445         (source_win, disasm_win): New globals.
2446         (exec_info): Remove.
2447         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2448         Update.
2449         (tui_alloc_generic_win_info): Remove.
2450         (init_content_element): Use new.
2451         (tui_win_info::tui_win_info): Update.
2452         (free_content_elements) <case DATA_WIN>: Use delete.
2453
2454 2019-06-25  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2457         * tui/tui-windata.c (tui_first_data_item_displayed)
2458         (tui_delete_data_content_windows): Update.
2459         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2460         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2461         (tui_display_registers_from, tui_check_register_values): Update.
2462         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2463         pointer.
2464         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2465         window.
2466         (tui_free_data_content): Update.
2467         (free_content_elements) <case DATA_WIN>: Free the window.
2468
2469 2019-06-25  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2472         Update.
2473         * tui/tui-layout.c (make_command_window)
2474         (show_source_disasm_command, show_data, init_and_make_win)
2475         (show_source_or_disasm_and_command): Update.
2476         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2477         method.
2478         <can_highight, is_highlighted>: Now bool.
2479         (tui_set_win_highlight): Don't declare.
2480         * tui/tui-data.c (tui_set_win_highlight): Remove.
2481
2482 2019-06-25  Tom Tromey  <tom@tromey.com>
2483
2484         * tui/tui-wingeneral.c (make_visible): Remove check of window
2485         type.
2486
2487 2019-06-25  Tom Tromey  <tom@tromey.com>
2488
2489         * tui/tui-win.c (tui_win_info::max_height)
2490         (tui_cmd_window::max_height): New methods.
2491         (new_height_ok): Call max_height.
2492         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2493         <max_height>: New method.
2494
2495 2019-06-25  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-win.c (tui_source_window_base::set_new_height)
2498         (tui_data_window::set_new_height): New methods.
2499         (make_invisible_and_set_new_height): Call set_new_height method.
2500         * tui/tui-data.h (struct tui_win_info)
2501         (struct tui_source_window_base, struct tui_data_window)
2502         <set_new_height>: New method.
2503
2504 2019-06-25  Tom Tromey  <tom@tromey.com>
2505
2506         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2507         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2508         tui_refresh_data_win.
2509         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2510         method.
2511         (tui_refresh_all_win): Call the refresh_all method.
2512         (tui_set_focus): Likewise.
2513         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2514         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2515         Likewise.
2516
2517 2019-06-25  Tom Tromey  <tom@tromey.com>
2518
2519         * tui/tui-winsource.h (tui_refill_source_window)
2520         (tui_set_is_exec_point_at): Don't declare.
2521         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2522         (tui_source_window_base::refill): Rename from
2523         tui_refill_source_window.
2524         (tui_source_window_base::do_scroll_horizontal): Update.
2525         (tui_source_window_base::set_is_exec_point_at): Rename from
2526         tui_set_is_exec_point_at.
2527         (tui_update_all_breakpoint_info): Update.
2528         * tui/tui-stack.c (tui_show_frame_info): Update.
2529         * tui/tui-layout.c (show_data): Add cast.
2530         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2531         * tui/tui-data.h (struct tui_source_window_base) <refill,
2532         set_is_exec_point_at>: New methods.
2533         (tui_source_windows, tui_add_to_source_windows): Update types.
2534         (tui_add_to_source_windows): Remove redundant declaration.
2535         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2536         (tui_source_windows): Change return type.
2537         (tui_clear_source_windows_detail): Update.
2538         (tui_add_to_source_windows): Change type of parameter.
2539         (tui_free_all_source_wins_content): Update.
2540
2541 2019-06-25  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-wingeneral.c (tui_win_info::refresh)
2544         (tui_source_window_base::refresh): New methods.
2545         (tui_refresh_all): Call the refresh method.
2546         * tui/tui-data.h (struct tui_win_info)
2547         (struct tui_source_window_base) <refresh>: New method.
2548
2549 2019-06-25  Tom Tromey  <tom@tromey.com>
2550
2551         * tui/tui.h (tui_is_window_visible): Return bool.
2552         * tui/tui.c (tui_is_window_visible): Return bool.
2553         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2554         (tui_make_visible, tui_make_invisible)
2555         (tui_win_info::make_visible)
2556         (tui_source_window_base::make_visible, make_all_visible)
2557         (tui_make_all_visible, tui_make_all_invisible): Update.
2558         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2559         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2560         bool.
2561         (struct tui_win_info, struct tui_source_window_base)
2562         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2563         * tui/tui-data.c (tui_init_generic_part): Update.
2564
2565 2019-06-25  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2568         (tui_source_window_base::make_visible): New methods.
2569         (make_all_visible): Make method call.
2570         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2571         (struct tui_source_window_base, struct tui_cmd_window): Override
2572         make_visible.
2573         (tui_win_is_source_type): Don't declare.
2574         * tui/tui-data.c (tui_win_is_source_type): Remove.
2575
2576 2019-06-25  Tom Tromey  <tom@tromey.com>
2577
2578         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2579         NULL check.
2580
2581 2019-06-25  Tom Tromey  <tom@tromey.com>
2582
2583         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2584         Inline constructor.  Add initializers for members.
2585         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2586         constructors; now inline in class.
2587
2588 2019-06-25  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-regs.c (tui_show_registers): Update.
2591         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2592         bool.
2593         * tui/tui-data.c (tui_data_window::clear_detail)
2594         (tui_data_window): Update.
2595
2596 2019-06-25  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-windata.c (tui_display_all_data)
2599         (tui_display_data_from_line, tui_display_data_from)
2600         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2601         Update.
2602         * tui/tui-regs.c (tui_last_regs_line_no)
2603         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2604         (tui_show_registers, tui_show_register_group)
2605         (tui_display_registers_from, tui_display_reg_element_at_line)
2606         (tui_display_registers_from_line, tui_check_register_values)
2607         (tui_reg_next, tui_reg_prev): Update.
2608         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2609         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2610         tui_data_window.
2611         (struct tui_win_info) <detail>: Remove.  Add new fields from
2612         tui_data_info.
2613         (TUI_DATA_WIN): Add cast.
2614         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2615         (~tui_data_window): Simplify.
2616
2617 2019-06-25  Tom Tromey  <tom@tromey.com>
2618
2619         * tui/tui-layout.c (show_source_disasm_command)
2620         (show_source_or_disasm_and_command): Update.
2621         * tui/tui-io.c (update_cmdwin_start_line)
2622         (tui_redisplay_readline): Update.
2623         * tui/tui-data.h (struct tui_command_info): Remove.
2624         (struct tui_win_info) <detail>: Remove command_info member.
2625         (struct tui_data_window) <start_line>: New member, from
2626         tui_command_info.
2627         (TUI_CMD_WIN): Add casts.
2628
2629 2019-06-25  Tom Tromey  <tom@tromey.com>
2630
2631         * tui/tui-winsource.c (tui_update_source_window)
2632         (tui_refill_source_window)
2633         (tui_source_window_base::do_scroll_horizontal)
2634         (tui_update_breakpoint_info, tui_set_exec_info_content)
2635         (tui_show_exec_info_content, tui_erase_exec_info_content)
2636         (tui_clear_exec_info_content): Update.
2637         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2638         Update.
2639         * tui/tui-win.c (make_invisible_and_set_new_height)
2640         (make_visible_with_new_height): Update.
2641         * tui/tui-source.c (tui_set_source_content)
2642         (tui_show_symtab_source): Update.
2643         * tui/tui-layout.c (extract_display_start_addr)
2644         (show_source_disasm_command, show_data)
2645         (make_source_or_disasm_window)
2646         (show_source_or_disasm_and_command): Update.
2647         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2648         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2649         "gdbarch".
2650         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2651         to tui_source_window_base.
2652         (struct tui_win_info) <detail>: Remove source_info member.
2653         (struct tui_source_window_base) <has_locator>: Inline.
2654         Move contents from tui_source_info; rename has_locator member to
2655         m_has_locator.
2656         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2657         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2658         header file.
2659         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2660         Simplify.
2661         (tui_free_all_source_wins_content): Cast to
2662         tui_source_window_base.
2663
2664 2019-06-25  Tom Tromey  <tom@tromey.com>
2665
2666         * tui/tui-win.c (make_invisible_and_set_new_height)
2667         (make_visible_with_new_height): Call has_locator method.
2668         * tui/tui-layout.c (show_source_disasm_command, show_data)
2669         (show_source_or_disasm_and_command): Update for bool change.
2670         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2671         (tui_win_info) <has_locator>: New method.
2672         (struct tui_source_window_base) <has_locator>: New method.
2673         (tui_win_has_locator): Don't declare.
2674         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2675         from tui_win_has_locator.
2676         (tui_source_window_base): Use false, not FALSE.
2677
2678 2019-06-25  Tom Tromey  <tom@tromey.com>
2679
2680         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2681         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2682         clear_detail method directly.
2683         (tui_clear_win_detail): Remove.
2684
2685 2019-06-25  Tom Tromey  <tom@tromey.com>
2686
2687         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2688         "this", not TUI_DISASM_WIN.
2689
2690 2019-06-25  Tom Tromey  <tom@tromey.com>
2691
2692         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2693         declare.
2694         * tui/tui-winsource.c
2695         (tui_source_window_base::do_scroll_horizontal): Rename from
2696         tui_horizontal_source_scroll.
2697         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2698         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2699         from tui_vertical_data_scroll.
2700         * tui/tui-win.h (tui_scroll): Don't declare.
2701         * tui/tui-win.c (tui_win_info::forward_scroll)
2702         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2703         (tui_win_info::right_scroll): Rename and update.
2704         (tui_scroll_forward_command, tui_scroll_backward_command)
2705         (tui_scroll_left_command, tui_scroll_right_command): Update.
2706         (tui_scroll): Remove.
2707         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2708         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2709         from tui_vertical_source_scroll.
2710         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2711         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2712         from tui_vertical_disassem_scroll.
2713         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2714         do_scroll_horizontal>: New methods.
2715         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2716         Likewise.
2717         (struct tui_source_window_base): Add do_scroll_horizontal.
2718         (struct tui_source_window, struct tui_disasm_window): Add
2719         do_scroll_vertical.
2720         (struct tui_data_window, struct tui_cmd_window): Add
2721         do_scroll_horizontal and do_scroll_vertical.
2722         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2723
2724 2019-06-25  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-data.h (struct tui_source_window_base): New struct.
2727         (struct tui_source_window): Derive from tui_source_window_base.
2728         (struct tui_disasm_window): New struct.
2729         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2730         from tui_source_window::clear_detail.
2731         (tui_source_window_base): Rename from tui_source_window.
2732         (~tui_source_window_base): Rename from ~tui_source_window.
2733         (tui_alloc_win_info): Create a tui_disasm_window.
2734
2735 2019-06-25  Tom Tromey  <tom@tromey.com>
2736
2737         * tui/tui-data.h (struct tui_source_window)
2738         (struct tui_data_window): Declare destructors.
2739         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2740         destructors.
2741         (tui_win_info): Simplify.
2742
2743 2019-06-25  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-winsource.c (tui_display_main)
2746         (tui_update_source_windows_with_addr)
2747         (tui_update_all_breakpoint_info): Update.
2748         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2749         (new_height_ok, parse_scrolling_args): Update.
2750         * tui/tui-stack.c (tui_show_frame_info): Update.
2751         * tui/tui-data.h (struct tui_list): Remove.
2752         (tui_source_windows): Return a reference to a std::vector.
2753         * tui/tui-data.c (source_windows): Now a std::vector.
2754         (tui_source_windows): Change return type.
2755         (tui_clear_source_windows): Rewrite.
2756         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2757         (tui_free_all_source_wins_content): Rewrite.
2758
2759 2019-06-25  Tom Tromey  <tom@tromey.com>
2760
2761         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2762         (struct tui_data_window, struct tui_cmd_window): Declare
2763         clear_detail method.
2764         * tui/tui-data.c (tui_source_window::clear_detail)
2765         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2766         methods.
2767         (tui_clear_win_detail): Simplify.
2768
2769 2019-06-25  Tom Tromey  <tom@tromey.com>
2770
2771         * tui/tui-layout.c (make_source_window, make_disasm_window)
2772         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2773         Return the new window.
2774         (show_source_disasm_command, show_data)
2775         (show_source_or_disasm_and_command): Update.
2776
2777 2019-06-25  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2780         parameter.  Return the new window.
2781         (show_source_disasm_command): Update and remove NULL check.
2782         (show_source_or_disasm_and_command): Update.
2783
2784 2019-06-25  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2787
2788 2019-06-25  Tom Tromey  <tom@tromey.com>
2789
2790         * tui/tui-data.h (struct tui_win_info): Make constructor
2791         protected.  Make destructor virtual.  Add initializers.
2792         (tui_source_window, tui_data_window, tui_cmd_window): New
2793         classes.
2794         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2795         constructor.  Add "type" parameter.
2796         (tui_source_window, tui_data_window, tui_cmd_window): New
2797         constructors.
2798         (tui_alloc_win_info): Instantiate the appropriate subclass.
2799
2800 2019-06-25  Tom Tromey  <tom@tromey.com>
2801
2802         * tui/tui-win.c (tui_resize_all): Use delete.
2803         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2804         destructor.
2805         (tui_free_window): Don't declare.
2806         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2807         Update.
2808
2809 2019-06-25  Tom Tromey  <tom@tromey.com>
2810
2811         * tui/tui-data.h (struct tui_win_info): Add constructor.
2812         * tui/tui-data.c (tui_alloc_win_info): Use new.
2813         (tui_free_window): Use delete.
2814
2815 2019-06-22  Tom Tromey  <tom@tromey.com>
2816
2817         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2818         declare.
2819         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2820
2821 2019-06-22  Tom Tromey  <tom@tromey.com>
2822
2823         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2824         declare.
2825         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2826
2827 2019-06-22  Tom de Vries  <tdevries@suse.de>
2828
2829         * dwarf2read.c (create_addrmap_from_aranges)
2830         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2831         instead of '%zu'.
2832
2833 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2834
2835         * dwarf2read.h (dwarf2_section_info_def): Remove.
2836         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2837         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2838         std::vector<dwarf2_section_info>.
2839         (struct dwo_file) <~dwo_file>: Remove.
2840         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2841         types field.
2842         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2843         (dwarf2_read_debug_names): Likewise.
2844         (create_debug_types_hash_table): Change parameter type to
2845         array_view, adjust code accordingly.
2846         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2847         (partial_die_info::fixup): Likewise.
2848         (determine_prefix): Likewise.
2849         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2850
2851 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2852
2853         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2854         gdb_bfd_ref_ptr.
2855         <~dwo_file>: Remove call to gdb_bfd_unref.
2856         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2857         gdb_bfd_ref_ptr::get.
2858
2859 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2860
2861         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2862         type to htab_up.
2863         * dwarf2read.c (struct dwo_file): Initialize fields.
2864         <~dwo_file>: New.
2865         (free_dwo_file): Remove, move content to ~dwo_file.
2866         (struct dwo_file_deleter): Remove.
2867         (dwo_file_up>: Remove custom deleter.
2868         (free_dwo_files): Remove.
2869         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2870         dwo_files.
2871         (process_skeletonless_type_units): Call unique_ptr::get.
2872         (allocate_dwo_file_hash_table): Add deleter to created hash
2873         table.  Change return type to htab_up.
2874         (lookup_dwo_file_slot): Don't memset dwo_file, call
2875         unique_ptr::get.
2876         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2877         (create_dwo_unit_in_dwp_v2): Likewise.
2878         (open_and_init_dwo_file): Likewise.
2879         (free_dwo_file_from_slot): Remove.
2880
2881 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2882
2883         * dwarf2read.h (struct dwarf2_section_info) <readin,
2884         is_virtual>: Change type to bool.
2885         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2886         true instead of 1.
2887
2888 2019-06-19  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-data.h (tui_init_content_element): Don't declare.
2891
2892 2019-06-19  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-data.h (tui_init_win_info): Don't declare.
2895
2896 2019-06-19  Tom de Vries  <tdevries@suse.de>
2897
2898         * dwarf2read.h (abstract_to_concrete): Change type to
2899         std::unordered_map<sect_offset, std::vector<sect_offset>,
2900         gdb::hash_enum<sect_offset>>.
2901
2902 2019-06-19  Tom Tromey  <tromey@adacore.com>
2903
2904         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2905         EVAL_AVOID_SIDE_EFFECTS specially.
2906
2907 2019-06-19  Tom Tromey  <tromey@adacore.com>
2908
2909         * source-cache.c (highlighter): New global.
2910         (source_cache::get_source_lines): Create a highlighter on demand.
2911
2912 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2913
2914         * defs.h (deprecated_interactive_hook): Delete declaration.
2915         * interps.c (clear_interpreter_hooks): Remove use of
2916         deprecated_interactive_hook.
2917         * top.c (deprecated_interactive_hook): Delete definition.
2918         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2919
2920 2019-06-18  Tom de Vries  <tdevries@suse.de>
2921
2922         PR gdb/24515
2923         * dwarf2read.h (abstract_to_concrete): Change type from
2924         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2925         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2926         * dwarf2read.c (read_variable): Update.
2927         (dwarf2_fetch_die_loc_sect_off): Update.
2928
2929 2019-06-17  Tom de Vries  <tdevries@suse.de>
2930
2931         PR gdb/24617
2932         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2933         accessing parent[parent_len - 1].
2934
2935 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2936
2937         PR gdb/24364
2938         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2939         call dtrace_process_dof with NULL dof.
2940
2941 2019-06-16  Tom de Vries  <tdevries@suse.de>
2942
2943         PR gdb/24445
2944         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2945
2946 2019-06-16  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2949         (make_all_visible): Use address of member.
2950
2951 2019-06-16  Tom Tromey  <tom@tromey.com>
2952
2953         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2954         (tui_free_window, free_content, free_content_elements): Remove
2955         unnecessary cast.
2956         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2957         cast.
2958         * tui/tui-regs.c (tui_show_register_group)
2959         (tui_display_registers_from, tui_display_reg_element_at_line):
2960         Remove unnecessary cast.
2961
2962 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2963
2964         * linux-nat.c (normal_mask): Delete.
2965         (_initialize_linux_nat): Don't initialise normal_mask.
2966
2967 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2968
2969         PR gdb/24445
2970         * dwarf-index-write.h (write_psymtabs_to_index): Add
2971         dwz_basename parameter.
2972         * dwarf-index-write.c (write_gdbindex): Move file writing to
2973         write_gdbindex_1.  Change return type void.
2974         (assert_file_size): Move up, remove filename parameter.
2975         (write_gdbindex_1): New function.
2976         (write_debug_names): Change return type to void, call
2977         assert_file_size.
2978         (struct index_wip_file): New struct.
2979         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2980         file logic to index_wip_file.  Write index for dwz file if
2981         needed.
2982         (save_gdb_index_command): Pass basename of dwz file, if present.
2983         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2984         build-id of dwz file, if present.
2985         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2986         (dwarf2_get_dwz_file): Likewise.
2987         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2988         (dwarf2_get_dwz_file): Likewise.
2989
2990 2019-06-16  Tom Tromey  <tom@tromey.com>
2991
2992         * coffread.c (process_coff_symbol): Use xstrdup.
2993         * value.c (create_internalvar): Use xstrdup.
2994
2995 2019-06-16  Tom Tromey  <tom@tromey.com>
2996
2997         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2998         * breakpoint.c (stopin_command, stopat_command)
2999         (until_break_command, decode_location_default): Remove unnecessary
3000         cast.
3001         * utils.c (subset_compare): Remove unnecessary cast.
3002         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3003         cast.
3004         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3005         cast.
3006         * infcmd.c (path_command): Remove unnecessary cast.
3007         * coffread.c (decode_type): Remove unnecessary cast.
3008         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3009         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3010         * tui/tui-stack.c (tui_show_locator_content)
3011         (tui_show_frame_info): Remove unnecessary cast.
3012         * tui/tui-win.c (tui_scroll_forward_command)
3013         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3014         (parse_scrolling_args): Remove unnecessary cast.
3015         * tui/tui-data.c (init_win_info, tui_del_window)
3016         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3017         (free_content_elements): Remove unnecessary cast.
3018         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3019         unnecessary cast.
3020         * tui/tui-source.c (tui_set_source_content)
3021         (tui_vertical_source_scroll): Remove unnecessary cast.
3022         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3023         cast.
3024         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3025         * tui/tui-regs.c (tui_display_registers_from)
3026         (tui_display_register): Remove unnecessary cast.
3027         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3028         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3029         (make_visible): Remove unnecessary cast.
3030         * tui/tui-winsource.c (tui_erase_source_content)
3031         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3032         unnecessary cast.
3033         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3034         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3035         * stabsread.c (read_type, read_array_type, read_range_type):
3036         Remove unnecessary cast.
3037         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3038         (parse_symbol, parse_type, upgrade_type, parse_external)
3039         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3040         unnecessary cast.
3041         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3042
3043 2019-06-16  Tom Tromey  <tom@tromey.com>
3044
3045         * tui/tui-data.c (tui_alloc_generic_win_info)
3046         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3047         checks.
3048
3049 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3050             Andrew Burgess  <andrew.burgess@embecosm.com>
3051
3052         * f-typeprint.c (f_print_type): Don't return early for not
3053         associated or not allocated types.
3054         (f_type_print_varspec_suffix): Add print_rank parameter and print
3055         ranks of array types in case they dangling.
3056         (f_type_print_base): Add print_rank parameter.
3057
3058 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3059
3060         * NEWS: Mention new MI commands.
3061         * break-catch-throw.c (enum exception_event_kind): Move to
3062         breakpoint.h.
3063         (print_mention_exception_catchpoint): Output text as a single
3064         message.
3065         (catch_exception_command_1): Rename to...
3066         (catch_exception_event): ...this, make non-static, update header
3067         command, and change some parameter types.
3068         (catch_catch_command): Update for changes to
3069         catch_exception_command_1.
3070         (catch_throw_command): Likewise.
3071         (catch_rethrow_command): Likewise.
3072         * breakpoint.c (enum exception_event_kind): Delete.
3073         * breakpoint.h (enum exception_event_kind): Moved here from
3074         break-catch-throw.c.
3075         (catch_exception_event): Declare.
3076         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3077         (mi_cmd_catch_throw): New function.
3078         (mi_cmd_catch_rethrow): New function.
3079         (mi_cmd_catch_catch): New function.
3080         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3081         'catch-catch' entries.
3082         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3083         (mi_cmd_catch_rethrow): Declare.
3084         (mi_cmd_catch_catch): Declare.
3085
3086 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3087
3088         * annotate.c (annotate_source_line): Change return type to void,
3089         update implementation to match.
3090         * annotate.h (annotate_source_line): Change return type to void,
3091         update header comment.
3092         * stack.c (print_frame_info): Don't change what frame information
3093         is printed based on whether annotations are on or not.
3094
3095 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3096
3097         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3098         (annotate_source): Make static.
3099         (annotate_source_line): Moved from source.c and renamed from
3100         identify_source_line.  Update the return type.
3101         * annotate.h (annotate_source): Delete declaration.
3102         (annotate_source_line): Declaration moved from source.h, and
3103         renamed from identify_source_line.  Return type updated.
3104         * source.c (identify_source_line): Moved to annotate.c and renamed
3105         to annotate_source_line.
3106         (info_line_command): Remove check of annotation_level.
3107         * source.h (identify_source_line): Move declaration to annotate.h
3108         and rename to annotate_source_line.
3109         * stack.c: Add 'annotate.h' include.
3110         (print_frame_info): Remove check of annotation_level before
3111         calling annotate_source_line.
3112
3113 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3114
3115         * source-cache.c (source_cache::get_plain_source_lines): Use
3116         open_source_file_with_line_charpos instead of just
3117         open_source_file, remove call to find_source_lines.
3118         (source_cache::get_source_lines): Likewise.
3119         * source.c (find_source_lines): Make static.
3120         (get_filename_and_charpos): Renamed into...
3121         (open_source_file_with_line_charpos): ..this along with changes to
3122         return a scoped_fd, and some other minor clean ups.
3123         (identify_source_line): Use open_source_file_with_line_charpos.
3124         (search_command_helper): Use open_source_file_with_line_charpos
3125         instead of just open_source_file, remove call to
3126         find_source_lines.
3127         * source.h (open_source_file_with_line_charpos): Declare new
3128         function.
3129         (find_source_lines): Delete declaration.
3130
3131 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3132
3133         * source.c (get_filename_and_charpos): Remove fullname
3134         parameter.
3135         (identify_source_line): Update call to get_filename_and_charpos.
3136
3137 2019-06-14  Tom Tromey  <tromey@adacore.com>
3138
3139         PR gdb/24502:
3140         * ui-style.h (skip_ansi_escape): Update comment.
3141         * ui-file.h (class no_terminal_escape_file): New class.
3142         * ui-file.c (no_terminal_escape_file::write)
3143         (no_terminal_escape_file::puts): New methods.
3144         * cli/cli-logging.c (handle_redirections): Use
3145         no_terminal_escape_file.
3146
3147 2019-06-14  Tom Tromey  <tromey@adacore.com>
3148
3149         * NEWS: Move convenience variable news above Python news.
3150
3151 2019-06-14  Tom Tromey  <tom@tromey.com>
3152
3153         * gnulib: Move directory to top-level.
3154         * configure.ac: Don't configure gnulib.
3155         * configure: Rebuild.
3156         * common/common-defs.h: Use new path to gnulib.
3157         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3158         (GNULIB_H): Remove.
3159         (INCGNU): Look in new gnulib location.
3160         (HFILES_NO_SRCDIR): Remove gnulib files.
3161         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3162         (generated_files): Remove GNULIB_H.
3163         ($(LIBGNU), all-lib): Remove targets.
3164         (distclean): Don't mention GNULIB_BUILDDIR.
3165         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3166
3167 2019-06-14  Tom Tromey  <tromey@adacore.com>
3168
3169         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3170         Warn if symbol file does not provide any symbols.
3171
3172 2019-06-14  Tom Tromey  <tromey@adacore.com>
3173
3174         * source.c (find_and_open_source): Respect basenames_may_differ.
3175
3176 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3177
3178         * annotate.c (annotate_breakpoints_invalid): Make use of
3179         scoped_restore_terminal_state.
3180         (annotate_frames_invalid): Likewise.
3181
3182 2019-06-14  Tom Tromey  <tromey@adacore.com>
3183
3184         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3185         allow assignment to an internalvar.
3186
3187 2019-06-14  Tom Tromey  <tromey@adacore.com>
3188
3189         * ada-lex.l: Allow "_" in attribute names.
3190
3191 2019-06-14  Tom Tromey  <tromey@adacore.com>
3192
3193         PR gdb/24653:
3194         * regcache.c (registers_changed): Don't call alloca.
3195         * top.c (execute_command): Don't call alloca.
3196
3197 2019-06-13  Pedro Alves  <palves@redhat.com>
3198
3199         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3200         'expression'.  When parsing an expression, error out if there's
3201         junk after "unlimited".
3202         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3203         (do_set_command): Adjust calls to is_unlimited_literal.
3204
3205 2019-06-13  Pedro Alves  <palves@redhat.com>
3206
3207         * compile/compile.c (make_compile_options_def_group): Add braces
3208         around array_view initializer.
3209         * thread.c (make_thread_apply_all_options_def_group)
3210         (make_thread_apply_all_options_def_group): Likewise.
3211
3212 2019-06-13  Pedro Alves  <palves@redhat.com>
3213
3214         * NEWS (New commands): Mention "maint test-options
3215         require-delimiter", "maint test-options unknown-is-error", "maint
3216         test-options unknown-is-operand" and "maint show
3217         test-options-completion-result".
3218         (New command options, command completion): New section.
3219         (Completion improvements): New section.
3220         Mention that you can abbreviate "unlimited".
3221
3222 2019-06-13  Pedro Alves  <palves@redhat.com>
3223
3224         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3225         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3226         * unittests/cli-utils-selftests.c (test_parse_flags)
3227         (test_parse_flags_qcs): Delete.
3228         (test_cli_utils): Don't call deleted functions.
3229
3230 2019-06-13  Pedro Alves  <palves@redhat.com>
3231
3232         * thread.c: Include "cli/cli-option.h".
3233         (tp_array_compar_ascending): Global.
3234         (tp_array_compar): Delete function.
3235         (tp_array_compar_ascending, tp_array_compar_descending): New
3236         functions.
3237         (ascending_option_def, qcs_flag_option_def)
3238         (thr_qcs_flags_option_defs)
3239         (make_thread_apply_all_options_def_group)
3240         (make_thread_apply_options_def_group): New.
3241         (thread_apply_all_command): Use gdb::option::process_options.
3242         (thread_apply_command_completer)
3243         (thread_apply_all_command_completer): New.
3244         (thread_apply_command): Use gdb::option::process_options.
3245         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3246         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3247         to generate help text of "thread apply".  Adjust "taas"'s help.
3248         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3249         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3250
3251 2019-06-13  Pedro Alves  <palves@redhat.com>
3252
3253         * thread.c (thread_apply_command): Check for invalid TID with
3254         isdigit instead of !isalpha.
3255
3256 2019-06-13  Pedro Alves  <palves@redhat.com>
3257
3258         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3259         (validate_flags_qcs): New.
3260         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3261         (validate_flags_qcs): Declare.
3262         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3263         (make_frame_apply_options_def_group): New.
3264         (frame_apply_command_count): Process options with
3265         gdb::option::process_options.
3266         (frame_apply_completer): New.
3267         (frame_apply_level_completer, frame_apply_all_completer)
3268         (frame_apply_completer): New.
3269         (_initialize_stack): Update help of "frame apply", "frame apply
3270         level", "frame apply all" and "faas" to mention supported options
3271         and install command completers.
3272         * stack.h (frame_apply_all_completer): Declare.
3273         * thread.c: Include "stack.h".
3274         (tfaas_command): Add "--".
3275         (_initialize_thread): Update help "tfaas" to mention supported
3276         options and install command completer.
3277
3278 2019-06-13  Pedro Alves  <palves@redhat.com>
3279
3280         * completer.c (complete_nested_command_line): New.
3281         (gdb_completion_word_break_characters_throw): Add assertion.
3282         * completer.h (complete_nested_command_line): Declare.
3283
3284 2019-06-13  Pedro Alves  <palves@redhat.com>
3285
3286         * stack.c (parse_backtrace_qualifiers): New.
3287         (backtrace_command): Use it.
3288         (backtrace_command_completer): Complete on qualifiers.
3289
3290 2019-06-13  Pedro Alves  <palves@redhat.com>
3291
3292         * frame.c: Include "cli/cli-option.h.
3293         (user_set_backtrace_options): New.
3294         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3295         Delete.
3296         (get_prev_frame): Adjust.
3297         (boolean_option_def, uinteger_option_def)
3298         (set_backtrace_option_defs): New.
3299         (_initialize_frame): Adjust and use
3300         gdb::option::add_setshow_cmds_for_options to install "set
3301         backtrace past-main" and "set backtrace past-entry".
3302         * frame.h: Include "cli/cli-option.h".
3303         (struct frame_print_options): Forward declare.
3304         (print_frame_arguments_all, print_frame_arguments_scalars)
3305         (print_frame_arguments_none): Declare.
3306         (print_entry_values): Delete declaration.
3307         (struct frame_print_options, user_frame_print_options): New.
3308         (struct set_backtrace_options): New.
3309         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3310         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3311         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3312         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3313         (list_args_or_locals): Add frame_print_options parameter.
3314         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3315         * python/py-framefilter.c (enumerate_args): Pass down
3316         USER_FRAME_PRINT_OPTIONS.
3317         * stack.c: Include "cli/cli-option.h".
3318         (print_frame_arguments_all, print_frame_arguments_scalars)
3319         (print_frame_arguments_none): Declare.
3320         (print_raw_frame_arguments, print_entry_values): Delete.
3321         (user_frame_print_options): New.
3322         (boolean_option_def, enum_option_def, frame_print_option_defs):
3323         New.
3324         (struct backtrace_cmd_options): New.
3325         (bt_flag_option_def): New.
3326         (backtrace_command_option_defs): New.
3327         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3328         (print_frame_arg, read_frame_arg, print_frame_args)
3329         (print_frame_info, print_frame): Add frame_print_options parameter
3330         and use it.
3331         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3332         (backtrace_command_1): Add frame_print_options and
3333         backtrace_cmd_options parameters and use them.
3334         (make_backtrace_options_def_group): New.
3335         (backtrace_command): Process command options with
3336         gdb::option::process_options.
3337         (backtrace_command_completer): New.
3338         (_initialize_stack): Extend "backtrace"'s help to mention
3339         supported options.  Install completer for "backtrace".
3340         Install some settings commands with add_setshow_cmds_for_options.
3341
3342 2019-06-13  Pedro Alves  <palves@redhat.com>
3343
3344         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3345         and that "set/show print raw frame-arguments" are now deprecated.
3346
3347         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3348         command.
3349         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3350         * stack.c (_initialize_stack): Install "set/show print
3351         raw-frame-arguments", and deprecate "set/show print raw
3352         frame-arguments".
3353         * valprint.c (_initialize_valprint): Deprecate "set/show print
3354         raw".
3355
3356 2019-06-13  Pedro Alves  <palves@redhat.com>
3357
3358         * compile/compile.c (struct compile_options): New.
3359         (compile_flag_option_def, compile_command_option_defs)
3360         (make_compile_options_def_group): New.
3361         (compile_file_command): Handle options with
3362         gdb::option::process_options.
3363         (compile_file_command_completer): New function.
3364         (compile_code_command): Handle options with
3365         gdb::option::process_options.
3366         (compile_code_command_completer): New function.
3367         (_initialize_compiler): Install completers for "compile code" and
3368         "compile file".  Mention available options in "compile code" and
3369         "compile code"'s help.
3370         * completer.c (advance_to_completion_word): New, factored out from
3371         ...
3372         (advance_to_expression_complete_word_point): ... this.
3373         (advance_to_filename_complete_word_point): New.
3374         * completer.h (advance_to_filename_complete_word_point): New
3375         declaration.
3376
3377 2019-06-13  Pedro Alves  <palves@redhat.com>
3378
3379         * compile/compile.c: Include "cli/cli-option.h".
3380         (compile_print_value): Scope data pointer is now a
3381         value_print_options pointer; adjust.
3382         (compile_print_command): Process options.  Scope data pointer is
3383         now a value_print_options pointer; adjust.
3384         (_initialize_compile): Update "compile print"'s help to include
3385         supported options.  Install a completer for "compile print".
3386         * cp-valprint.c (show_vtblprint, show_objectprint)
3387         (show_static_field_print): Delete.
3388         (_initialize_cp_valprint): Don't install "set print
3389         static-members", "set print vtbl", "set print object" here.
3390         * printcmd.c: Include "cli/cli-option.h" and
3391         "common/gdb_optional.h".
3392         (print_command_parse_format): Rework to fill in a
3393         value_print_options instead of a format_data.
3394         (print_value): Change parameter type from format_data pointer to
3395         value_print_options reference.  Adjust.
3396         (print_command_1): Process options.  Adjust to pass down a
3397         value_print_options.
3398         (print_command_completer): New.
3399         (_initialize_printcmd): Install print_command_completer as
3400         handle_brkchars completer for the "print" command.  Update
3401         "print"'s help to include supported options.
3402         * valprint.c: Include "cli/cli-option.h".
3403         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3404         here from cp-valprint.c.
3405         (boolean_option_def, uinteger_option_def)
3406         (value_print_option_defs, make_value_print_options_def_group):
3407         New.  Use gdb::option::add_setshow_cmds_for_options to install
3408         "set print elements", "set print null-stop", "set print repeats",
3409         "set print pretty", "set print union", "set print array", "set
3410         print address", "set print symbol", "set print array-indexes".
3411         * valprint.h: Include <string> and "cli/cli-option.h".
3412         (make_value_print_options_def_group): Declare.
3413         (print_value): Change parameter type from format_data pointer to
3414         value_print_options reference.
3415         (print_command_completer): Declare.
3416
3417 2019-06-13  Pedro Alves  <palves@redhat.com>
3418
3419         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3420         (COMMON_SFILES): Add maint-test-settings.c.
3421         * cli/cli-decode.c (boolean_enums): New global, factored out from
3422         ...
3423         (add_setshow_boolean_cmd): ... here.
3424         * cli/cli-decode.h (boolean_enums): Declare.
3425         * cli/cli-option.c: New file.
3426         * cli/cli-option.h: New file.
3427         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3428         factored out from ...
3429         (parse_cli_boolean_value(const char *)): ... this.
3430         (is_unlimited_literal): Change parameter type to pointer to
3431         pointer.  Adjust and advance ARG pointer.
3432         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3433         (parse_cli_var_enum): New, factored out from ...
3434         (do_set_command): ... this.  Adjust.
3435         * cli/cli-setshow.h (parse_cli_boolean_value)
3436         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3437         (parse_cli_var_enum): Declare.
3438         * cli/cli-utils.c: Include "cli/cli-option.h".
3439         (get_ulongest): New.
3440         * cli/cli-utils.h (get_ulongest): Declare.
3441         (check_for_argument): New overloads.
3442         * maint-test-options.c: New file.
3443
3444 2019-06-13  Pedro Alves  <palves@redhat.com>
3445
3446         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3447         parse a range if "-" is at the end of the string.
3448
3449 2019-06-13  Pedro Alves  <palves@redhat.com>
3450
3451         * cli/cli-setshow.c (parse_auto_binary_operation)
3452         (parse_cli_boolean_value): Don't allow "o".
3453
3454 2019-06-13  Pedro Alves  <palves@redhat.com>
3455
3456         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3457         * NEWS: Mention maint test-settings KIND.
3458         * maint-test-settings.c: New file.
3459
3460 2019-06-13  Pedro Alves  <palves@redhat.com>
3461
3462         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3463         completer.
3464         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3465         "set" completers.
3466
3467 2019-06-13  Pedro Alves  <palves@redhat.com>
3468
3469         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3470         after item.
3471
3472 2019-06-13  Pedro Alves  <palves@redhat.com>
3473
3474         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3475
3476 2019-06-13  Pedro Alves <palves@redhat.com>
3477
3478         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3479         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3480         call.
3481         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3482         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3483         calls.
3484         (check_for_argument): Skip spaces after argument.
3485
3486 2019-06-13  Pedro Alves  <palves@redhat.com>
3487
3488         * thread.c (thread_apply_command): Adjust TID parsing.
3489         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3490         detected before end of string.
3491         (tid_is_in_list): Error out if LIST is invalid.
3492
3493 2019-06-13  Pedro Alves  <palves@redhat.com>
3494
3495         * completer.c (complete_line_internal_1): Rewind completion word
3496         point.
3497         (completion_tracker::advance_custom_word_point_by): Change
3498         parameter type to int.
3499         * completer.h (completion_tracker::advance_custom_word_point_by):
3500         Likewise.
3501
3502 2019-06-13  Pedro Alves  <palves@redhat.com>
3503
3504         * completer.c (advance_to_completion_word): Handle delimiters.
3505
3506 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3507
3508         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3509
3510 2019-06-11  Tom Tromey  <tom@tromey.com>
3511
3512         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3513         (xmalloc_failed): Move to alloc.c.
3514         * alloc.c: New file.
3515         * Makefile.in (COMMON_SFILES): Add alloc.c.
3516
3517 2019-06-11  Tom Tromey  <tom@tromey.com>
3518
3519         * nat/linux-waitpid.c: Don't include server.h.
3520         (linux_debug): Remove.
3521         (my_waitpid): Update.
3522
3523 2019-06-11  Tom Tromey  <tromey@adacore.com>
3524
3525         * infcall.c (_initialize_infcall): Remove trailing newline from
3526         help.
3527         * user-regs.c (_initialize_user_regs): Remove trailing newline
3528         from help.
3529         * typeprint.c (_initialize_typeprint): Remove trailing newline
3530         from help.
3531         * reverse.c (_initialize_reverse): Remove trailing newlines from
3532         help.
3533         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3534         from help.
3535         * language.c (add_set_language_command): Remove trailing newline
3536         from help.
3537         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3538         help.
3539         * disasm.c (_initialize_disasm): Remove trailing newline from
3540         help.
3541         * top.c (init_main): Remove trailing newline from help.
3542         * interps.c (_initialize_interpreter): Remove trailing newline
3543         from help.
3544         * btrace.c (_initialize_btrace): Remove trailing newlines from
3545         help.
3546         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3547         from help.
3548         * python/python.c (_initialize_python): Remove trailing newline
3549         from help.
3550         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3551         help.
3552         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3553         from help.  Reformat some text.
3554         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3555         from help.
3556         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3557         newline from help.
3558
3559 2019-06-11  Tom Tromey  <tromey@adacore.com>
3560
3561         * darwin-nat.c (darwin_decode_exception_message)
3562         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3563
3564 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3565
3566         * valops.c (value_slice): Check for not allocated or not
3567         associated values.
3568
3569 2019-06-10  Tom de Vries  <tdevries@suse.de>
3570
3571         PR gdb/24618
3572         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3573         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3574         invalid.
3575
3576 2019-06-10  Tom de Vries  <tdevries@suse.de>
3577
3578         PR gdb/24611
3579         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3580         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3581
3582 2019-06-10  Tom de Vries  <tdevries@suse.de>
3583
3584         PR symtab/24545
3585         * symtab.c (struct demangled_name_entry): Add language field.
3586         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3587         static minimal symbol".  Set and use language field.
3588
3589 2019-06-10  Tom Tromey  <tromey@adacore.com>
3590
3591         * ada-lang.c (_initialize_ada_language): Update help text.
3592
3593 2019-06-10  Tom Tromey  <tromey@adacore.com>
3594
3595         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3596         with a newline.
3597         * guile/guile.c (handle_boot_error): Don't end warning with a
3598         newline.
3599         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3600         warning with a newline.
3601         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3602         newline.
3603         (s12z_frame_cache): Likewise.
3604         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3605         a newline.
3606         * solib-svr4.c (disable_probes_interface): Don't end warning with
3607         a newline.
3608         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3609         newline.
3610         * python/python.c (do_finish_initialization): Don't end warning
3611         with a newline.
3612
3613 2019-06-10  Tom Tromey  <tom@tromey.com>
3614
3615         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3616         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3617         gdbpy_enter.
3618
3619 2019-06-10  Tom Tromey  <tromey@adacore.com>
3620
3621         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3622         data.
3623         (elf_new_init): Don't call stabsread_new_init.
3624         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3625         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3626         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3627
3628 2019-06-10  Tom de Vries  <tdevries@suse.de>
3629
3630         PR symtab/16264
3631         PR symtab/24517
3632         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3633
3634 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3635
3636         * source.c (find_and_open_source): Also rewrite relative file
3637         names.
3638
3639 2019-04-26  Amos Bird  <amosbird@gmail.com>
3640
3641         * annotate.c (annotate_thread_exited): Add "thread-exited"
3642         annotation.
3643
3644 2019-06-06  Tom Tromey  <tromey@adacore.com>
3645
3646         * maint.h (class scoped_command_stats): Use
3647         DISABLE_COPY_AND_ASSIGN.
3648         <print_time>: New method.
3649         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3650         print_time.
3651         (scoped_command_stats::print_time): New method.
3652
3653 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3654
3655         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3656         instructions of lengths 6 or 8 bytes.
3657
3658 2019-06-04  Pedro Alves  <palves@redhat.com>
3659
3660         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3661
3662         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3663         * breakpoint.c (condition_completer): Likewise.
3664         * cli/cli-dump.c (scan_expression): Likewise.
3665         * common/filestuff.c (mkdir_recursive): Likewise.
3666         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3667         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3668         (gdb_abspath): Likewise.
3669         * compile/compile-cplus-types.c
3670         (compile_cplus_instance::decl_name): Likewise.
3671         * completer.c (complete_explicit_location):
3672         (signal_completer, reg_or_group_completer_1): Likewise.
3673         * cp-support.c (cp_remove_params_if_any): Likewise.
3674         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3675         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3676         * infcmd.c (strip_bg_char): Likewise.
3677         * linespec.c (copy_token_string): Likewise.
3678         * mi/mi-main.c (output_cores): Likewise.
3679         * psymtab.c (psymtab_search_name):
3680         * symfile.c (test_set_ext_lang_command): Likewise.
3681         * target.c (target_fileio_read_stralloc): Likewise.
3682         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3683         * value.c (complete_internalvar): Likewise.
3684
3685 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3686
3687         Add objfile property to gdb.Type.
3688         * NEWS: Mention Python API addition.
3689         * python/py-type.c (typy_get_objfile): New method.
3690
3691 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3692
3693         * NEWS: Mention the new set|show style [title|highlight].
3694         Mention changes to "show style", "help" and "apropos".
3695
3696 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3697
3698         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3699         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3700         instead of print_help_for_command.
3701         (print_doc_of_command): New function.
3702         (help_list): Add 'apropos -v word' suggestion.
3703         (print_help_for_command): Style the command name using title style.
3704         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3705         (_initialize_cli_cmds): Describe -v in apropos_command help.
3706
3707 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3708
3709         * cli/cli-style.h (cli_style_option): Add name in constructor,
3710         add m_name class member, add constructor with intensity,
3711         add name class function.
3712         (cli_style_option::add_setshow_commands): Remove name argument.
3713         (highlight_style, title_style): New styles.
3714         * cli/cli-style.c (do_show): New function that shows a style
3715         characteristic styling the style name with itself.
3716         (set_style_name): New function.
3717         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3718         Update all callers according to the changes in cli/cli-style.h.
3719         * utils.h (fputs_highlighted): New function.
3720         * utils.c (fputs_highlighted): Likewise.
3721
3722 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3723
3724         * NEWS: Mention new pipe command and new convenience variables.
3725
3726 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3727
3728         * cli/cli-cmds.c (pipe_command): New function.
3729         (_initialize_cli_cmds): Call add_com for pipe_command.
3730         Define | as an alias for pipe.
3731         (exit_status_set_internal_vars): New function.
3732         (shell_escape): Call exit_status_set_internal_vars.
3733         cli/cli-decode.c (find_command_name_length): Recognize | as
3734         a single character command.
3735
3736 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3737
3738         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3739         top.c (execute_command_to_ui_file): New function, mostly a copy
3740         of execute_command_to_string.
3741         (execute_command_to_string): Implement by calling
3742         execute_command_to_ui_file.
3743
3744 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3745
3746         * top.h (saved_command_line): Remove declaration.
3747         * top.c (previous_saved_command_line, previous_repeat_arguments):
3748         New variables.
3749         (saved_command_line): Make static, define together with other
3750         'repeat variables'.
3751         (dont_repeat): Clear repeat_arguments.
3752         (repeat_previous, get_saved_command_line, save_command_line):
3753         New functions.
3754         (gdb_init): Initialize saved_command_line
3755         and previous_saved_command_line.
3756         * main.c (captured_main_1): Remove saved_command_line initialization.
3757         * event-top.c (handle_line_of_input): Update to use
3758         the new 'repeat' related functions instead of direct access to
3759         saved_command_line.
3760         * command.h (repeat_previous, get_saved_command_line,
3761         save_command_line): New declarations.
3762         (dont_repeat): Add comment.
3763
3764 2019-05-30  Tom Tromey  <tromey@adacore.com>
3765
3766         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3767         Fix comment.
3768         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3769
3770 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3771
3772         PR cli/24587
3773         * completer.c (complete): Initialize variable word.
3774
3775 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3776
3777         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3778         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3779         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3780         'body' is NULL to the outter 'if', protecting the '!is_define'
3781         situation as well.
3782
3783 2019-05-29  Tom Tromey  <tromey@adacore.com>
3784
3785         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3786         (dwarf_unknown): New function.
3787         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3788         (dwarf_type_encoding_name): Use dwarf_unknown.
3789
3790 2019-05-29  Tom Tromey  <tromey@adacore.com>
3791
3792         PR c++/20020:
3793         * cp-valprint.c (cp_print_value_fields): Call
3794         cp_print_static_field inside "try".
3795
3796 2019-05-29  Tom Tromey  <tromey@adacore.com>
3797
3798         * inflow.c (struct terminal_info): Add default operator=.
3799         * configure: Rebuild.
3800         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3801         -Wdeprecated-copy-dtor, -Wredundant-move.
3802
3803 2019-05-29  Tom Tromey  <tromey@adacore.com>
3804
3805         * NEWS: Add entry.
3806         * infcmd.c (print_return_value_1): Handle finish_print
3807         option.
3808         (show_print_finish): New function.
3809         (_initialize_infcmd): Add "set/show print finish" commands.
3810         * valprint.c (user_print_options): Initialize new member.
3811         * valprint.h (struct value_print_options) <finish_print>: New
3812         member.
3813
3814 2019-05-28  Tom Tromey  <tromey@adacore.com>
3815
3816         * ada-lang.c (ada_remove_Xbn_suffix)
3817         (find_old_style_renaming_symbol)
3818         (parse_old_style_renaming): Remove.
3819         (ada_find_renaming_symbol): Don't call
3820         find_old_style_renaming_symbol.
3821         (ada_is_renaming_symbol): Rename from
3822         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3823         bool.  Now static.
3824         (ada_read_var_value): Update and simplify.
3825         * ada-exp.y (write_var_or_type): Remove old code.
3826
3827 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3828
3829         * event-top.c: Remove include comment.
3830         * inflow.c (class scoped_ignore_sigttou): Move from here...
3831         * inflow.h (class scoped_ignore_sigttou): ...to here.
3832         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3833         * top.c:  Remove include comment.
3834
3835 2019-05-27  Tom Tromey  <tom@tromey.com>
3836
3837         * NEWS: Fix typo.
3838
3839 2019-05-22  Tom Tromey  <tromey@adacore.com>
3840
3841         * target.c (target_follow_exec): Constify parameter.
3842         * target-delegates.c: Rebuild.
3843         * remote.c (remote_target::follow_exec): Constify parameter.
3844         * infrun.c (follow_exec): Constify parameter.
3845         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3846         (target_follow_exec): Likewise.
3847
3848 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3849
3850         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3851         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3852
3853 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3854
3855         * NEWS: Add debugredirect and testsuite sections.
3856
3857 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3858
3859         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3860         target descriptions using exclusively floating point register name
3861         aliases.
3862
3863 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3864
3865         PR gdb/18644:
3866         * f-lang.c (build_fortran_types): Handle the case where
3867         gdbarch_floatformat_for_type returns a nullptr.
3868
3869 2019-05-21  Tom de Vries  <tdevries@suse.de>
3870
3871         PR cli/24587
3872         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3873
3874 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         PR gdb/18644:
3877         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3878         16-byte floats.
3879         * i386-tdep.c (i386_floatformat_for_type): Use
3880         floatformats_ia64_quad for the 16-byte floating point component
3881         within a fortran 32-byte complex number.
3882
3883 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3886         delete default constructor.
3887         (find_partial_die): Update to return const struct.
3888         (partial_die_parent_scope): Move variable declaration into scope
3889         of its use and change its type to auto.
3890         (guess_partial_die_structure_name): Likewise.
3891         (partial_die_info::fixup): Likewise.
3892
3893 2019-05-17  Tom Tromey  <tromey@adacore.com>
3894
3895         * source.c (find_and_open_source): Remove cast.
3896
3897 2019-05-17  Tom Tromey  <tromey@adacore.com>
3898
3899         * annotate.c (annotate_source): Make "filename" const.
3900         * annotate.h (annotate_source): Use const.
3901
3902 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3903
3904         * disasm.c (set_disassembler_options): Send errors to stderr.
3905
3906 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3907
3908         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3909         (cli_interp_base::set_logging): Check debug_redirect.
3910         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3911         * cli/cli-logging.c (debug_redirect): Add static variable.
3912         (pop_output_files): Add default param.
3913         (handle_redirections): Print debug setting.
3914         (show_logging_command): Likewise.
3915         (_initialize_cli_logging): Add debugredirect command.
3916         * interps.c (current_interp_set_logging): Add debug_redirect
3917         parameter.
3918         * interps.h (set_logging): Add debug_redirect parameter.
3919         (current_interp_set_logging): Likewise.
3920         * mi/mi-common.h: Likewise.
3921         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3922
3923 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3924             Tom Tromey  <tromey@adacore.com>
3925
3926         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3927         directly.
3928         * cli/cli-interp.h (make_logging_output): Remove declaration.
3929         * cli/cli-logging.c (make_logging_output): Remove function.
3930         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3931         directly.
3932         * ui-file.c (tee_file::tee_file): Remove bools.
3933         (tee_file::~tee_file): Remove deletes.
3934         * ui-file.h (tee_file): Remove bools.
3935
3936 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3937
3938         * mi/mi-cmds.h (mi_cmd_complete): New function.
3939         * mi/mi-main.c (mi_cmd_complete): Likewise.
3940         * mi/mi-cmds.c: Define new MI command -complete.
3941         * NEWS: Mention new -complete command.
3942
3943 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3944
3945         * completer.h (complete): New function.
3946         * completer.c (complete): Likewise.
3947         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3948         function defined in completer.h.
3949
3950 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3951
3952         * MAINTAINERS (Write After Approval): Add myself.
3953
3954 2019-05-17  Tom de Vries  <tdevries@suse.de>
3955
3956         PR gdb/24094
3957         * dwarf2read.c (struct cu_partial_die_info): New struct.
3958         (find_partial_die): Return cu_partial_die_info.
3959         (partial_die_parent_scope, guess_partial_die_structure_name)
3960         (partial_die_info::fixup): Handle new return type of find_partial_die.
3961
3962 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3963
3964         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3965         "std::string", simplifying the algorithm.
3966
3967 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3968
3969         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3970         (stap_static_probe_ops::get_probes): Likewise.
3971
3972 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3973
3974         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3975         '-')" and "else if".
3976         (stap_parse_single_operand): Join checks for
3977         "gdbarch_stap_parse_special_token_p" and
3978         "gdbarch_stap_parse_special_token" in the same "if" statement.
3979         Invert check when verifying for operation on register
3980         displacement.
3981
3982 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3983
3984         * stap-probe.c (stap_get_opcode): Update comment.
3985         (stap_get_expected_argument_type): Likewise.
3986         (handle_stap_probe): Likewise.
3987
3988 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3989
3990         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3991         return type to 'bool'.  Adjust comment.  Use 'bool' when
3992         appropriate.
3993         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3994         * stap-probe.c (stap_parse_argument_1): Likewise.
3995         (stap_is_operator): Likewise.
3996         (stap_is_generic_prefix): Likewise.
3997         (stap_is_register_prefix): Likewise.
3998         (stap_is_register_indirection_prefix): Likewise.
3999         (stap_is_integer_prefix): Likewise.
4000         (stap_generic_check_suffix): Likewise.
4001         (stap_check_integer_suffix): Likewise.
4002         (stap_check_register_suffix): Likewise.
4003         (stap_check_register_indirection_suffix): Likewise.
4004         (stap_parse_register_operand): Likewise.
4005         (stap_parse_single_operand): Likewise.
4006         (stap_parse_argument_1): Likewise.
4007         (stap_probe::get_argument_count): Likewise.
4008         (stap_is_operator): Likewise.
4009
4010 2019-05-16  Tom Tromey  <tromey@adacore.com>
4011
4012         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4013         keyword to foreach.
4014
4015 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4016
4017         * linux-thread-db.c (try_thread_db_load_1): Change return type
4018         to bool.
4019         (try_thread_db_load): Likewise.
4020         (try_thread_db_load_from_pdir_1): Likewise.
4021         (try_thread_db_load_from_pdir): Likewise.
4022         (try_thread_db_load_from_sdir): Likewise.
4023         (try_thread_db_load_from_dir): Likewise.
4024         (thread_db_load_search): Likewise.
4025         (has_libpthread): Likewise.
4026         (thread_db_load): Likewise.
4027
4028 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4029
4030         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4031         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4032         NULL, and complain/return if that's the case.
4033
4034 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4035
4036         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4037         (advance, posn, abstract_read_memory): New functions.
4038         [struct mem_read_abstraction]: New struct.
4039         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4040
4041 2019-05-14  Tom Tromey  <tromey@adacore.com>
4042
4043         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4044         value is not lval_memory.
4045
4046 2019-05-14  Tom Tromey  <tromey@adacore.com>
4047
4048         * solib.c (info_sharedlibrary_command): Style the file name.
4049
4050 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4051
4052         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4053         (aarch64_vnv_type): Likewise.
4054         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4055         * common/tdesc.c: Likewise.
4056         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4057         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4058         * features/aarch64-fpu.xml: Add ieee half view.
4059         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4060         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4061         * gdbtypes.h (struct builtin_type): Likewise.
4062         (struct objfile_type): Likewise.
4063
4064 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4065
4066         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4067         typo.
4068         * location.h (string_to_event_location): Likewise.
4069
4070 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4071
4072         GDB 8.3 released.
4073
4074 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4075
4076         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4077         New variable declaration.
4078         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4079         New variable.
4080         (print_one_breakpoint): Use ui_out::test_flags and new global
4081         variable to compute use_fixed_output.
4082         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4083         Remove.
4084         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4085         (mi_multi_location_breakpoint_output_fixed): Remove.
4086         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4087         new variable.
4088         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4089         fix_multi_location_breakpoint_output flag if version >= 3.
4090         * ui-out.h (enum ui_out_flag)
4091         <fix_multi_location_breakpoint_output>: New enumerator.
4092
4093 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4094
4095         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4096
4097 2019-05-10  Tom Tromey  <tromey@adacore.com>
4098
4099         * ada-lang.c (catch_ada_completer): New function.
4100         (_initialize_ada_language): Use it.
4101
4102 2019-05-10  Tom Tromey  <tromey@adacore.com>
4103
4104         * thread.c (print_thread_info): Make "requested_threads" const.
4105         * gdbthread.h (print_thread_info): Make "requested_threads"
4106         const.
4107         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4108         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4109
4110 2019-05-08  Tom Tromey  <tom@tromey.com>
4111
4112         * gdbtypes.c (objfile_type_data): Change type.
4113         (objfile_type, _initialize_gdbtypes): Update.
4114
4115 2019-05-08  Tom Tromey  <tom@tromey.com>
4116
4117         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4118         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4119         (_initialize_dwarf2_frame): Update.
4120
4121 2019-05-08  Tom Tromey  <tom@tromey.com>
4122
4123         * objc-lang.c (objc_objfile_data): Change type.
4124         (find_methods): Update.
4125         (_initialize_objc_lang): Remove.
4126
4127 2019-05-08  Tom Tromey  <tom@tromey.com>
4128
4129         * stabsread.c (rs6000_builtin_type_data): Change type.
4130         (rs6000_builtin_type, _initialize_stabsread): Update.
4131
4132 2019-05-08  Tom Tromey  <tom@tromey.com>
4133
4134         * mips-tdep.c (mips_pdr_data): Remove.
4135         (_initialize_mips_tdep): Update.
4136
4137 2019-05-08  Tom Tromey  <tom@tromey.com>
4138
4139         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4140         (hppa_init_objfile_priv_data, read_unwind_info)
4141         (find_unwind_entry, _initialize_hppa_tdep): Update.
4142
4143 2019-05-08  Tom Tromey  <tom@tromey.com>
4144
4145         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4146         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4147         on obstack.
4148         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4149
4150 2019-05-08  Tom Tromey  <tom@tromey.com>
4151
4152         * mdebugread.c (basic_type_data): Change type.
4153         (basic_type, _initialize_mdebugread): Update.
4154
4155 2019-05-08  Tom Tromey  <tom@tromey.com>
4156
4157         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4158
4159 2019-05-08  Tom Tromey  <tom@tromey.com>
4160
4161         * nto-tdep.c (nto_inferior_data_reg): Change type.
4162         (nto_inferior_data): Update.
4163         (nto_inferior_data_cleanup, nto_new_inferior_data)
4164         (_initialize_nto_tdep): Remove.
4165         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4166
4167 2019-05-08  Tom Tromey  <tom@tromey.com>
4168
4169         * ada-lang.c (struct ada_inferior_data): Add initializers.
4170         (ada_inferior_data): Change type.
4171         (ada_inferior_data_cleanup): Remove.
4172         (get_ada_inferior_data, ada_inferior_exit)
4173         (struct ada_pspace_data): Add initializers, destructor.
4174         (ada_pspace_data_handle): Change type.
4175         (get_ada_pspace_data): Update.
4176         (ada_pspace_data_cleanup): Remove.
4177
4178 2019-05-08  Tom Tromey  <tom@tromey.com>
4179
4180         * coffread.c (struct coff_symfile_info): Add initializers.
4181         (coff_objfile_data_key): Move lower.  Change type.
4182         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4183         Update.
4184         (coff_free_info): Remove.
4185
4186 2019-05-08  Tom Tromey  <tom@tromey.com>
4187
4188         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4189         (fbsd_pspace_data_handle): Move lower.  Change type.
4190         (get_fbsd_pspace_data): Update.
4191         (fbsd_pspace_data_cleanup): Remove.
4192         (_initialize_fbsd_tdep): Update.
4193
4194 2019-05-08  Tom Tromey  <tom@tromey.com>
4195
4196         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4197         (get_ada_tasks_pspace_data): Update.
4198         (ada_tasks_pspace_data_cleanup): Remove.
4199         (_initialize_tasks): Update.
4200         (ada_tasks_inferior_data_handle): Change type.
4201         (get_ada_tasks_inferior_data): Update.
4202         (ada_tasks_inferior_data_cleanup): Remove.
4203         (struct ada_tasks_pspace_data): Add initializers.
4204
4205 2019-05-08  Tom Tromey  <tom@tromey.com>
4206
4207         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4208         * symfile-debug.c (debug_sym_get_probes): Change type.
4209         * stap-probe.c (handle_stap_probe):
4210         (stap_static_probe_ops::get_probes): Change type.
4211         * probe.h (class static_probe_ops) <get_probes>: Change type.
4212         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4213         (parse_probes_in_pspace): Update.
4214         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4215         Update.
4216         (any_static_probe_ops::get_probes): Change type.
4217         * elfread.c (elfread_data): New typedef.
4218         (probe_key): Change type.
4219         (elf_get_probes): Likewise.  Update.
4220         (probe_key_free): Remove.
4221         (_initialize_elfread): Update.
4222         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4223         Change type.
4224         (dtrace_process_dof_probe, dtrace_process_dof)
4225         (dtrace_static_probe_ops::get_probe): Change type.
4226
4227 2019-05-08  Tom Tromey  <tom@tromey.com>
4228
4229         * xcoffread.c (struct xcoff_symfile_info): Rename from
4230         coff_symfile_info.  Add initializers.
4231         (xcoff_objfile_data_key): Move lower.  Change type.
4232         (XCOFF_DATA): Rewrite.
4233         (xcoff_free_info): Remove.
4234         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4235         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4236         (xcoff_initial_scan): Update.
4237
4238 2019-05-08  Tom Tromey  <tom@tromey.com>
4239
4240         * solib-svr4.c (struct svr4_info): Add initializers and
4241         destructor.
4242         <probes_table>: Now an htab_up.
4243         (solib_svr4_pspace_data): Change type.
4244         (free_probes_table): Simplify.
4245         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4246         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4247         (probes_table_remove_objfile_probes, register_solib_event_probe)
4248         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4249         (_initialize_svr4_solib): Update.
4250
4251 2019-05-08  Tom Tromey  <tom@tromey.com>
4252
4253         * remote.c (remote_pspace_data): Change type.
4254         (remote_pspace_data_cleanup): Remove.
4255         (get_remote_exec_file, set_pspace_remote_exec_file)
4256         (_initialize_remote): Update.
4257
4258 2019-05-08  Tom Tromey  <tom@tromey.com>
4259
4260         * breakpoint.c (breakpoint_objfile_key): Change type.
4261         (get_breakpoint_objfile_data): Update.
4262         (free_breakpoint_objfile_data): Remove.
4263         (_initialize_breakpoint): Update.
4264
4265 2019-05-08  Tom Tromey  <tom@tromey.com>
4266
4267         * linux-tdep.c (struct linux_info): Add initializers.
4268         (linux_inferior_data): Move.  Change type.
4269         (invalidate_linux_cache_inf): Update.
4270         (linux_inferior_data_cleanup): Remove.
4271         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4272
4273 2019-05-08  Tom Tromey  <tom@tromey.com>
4274
4275         * auxv.c (auxv_inferior_data): Move.  Change type.
4276         (auxv_inferior_data_cleanup): Remove.
4277         (invalidate_auxv_cache_inf): Rewrite.
4278         (get_auxv_inferior_data, _initialize_auxv): Update.
4279
4280 2019-05-08  Tom Tromey  <tom@tromey.com>
4281
4282         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4283         (symfile_debug_objfile_data_key): Change type.
4284         (symfile_debug_installed, debug_qf_has_symbols)
4285         (debug_qf_find_last_source_symtab)
4286         (debug_qf_forget_cached_source_info)
4287         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4288         (debug_qf_print_stats, debug_qf_dump)
4289         (debug_qf_expand_symtabs_for_function)
4290         (debug_qf_expand_all_symtabs)
4291         (debug_qf_expand_symtabs_with_fullname)
4292         (debug_qf_map_matching_symbols)
4293         (debug_qf_expand_symtabs_matching)
4294         (debug_qf_find_pc_sect_compunit_symtab)
4295         (debug_qf_map_symbol_filenames)
4296         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4297         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4298         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4299         (debug_sym_read_linetable, debug_sym_relocate): Update.
4300         (symfile_debug_free_objfile): Remove.
4301         (install_symfile_debug_logging, _initialize_symfile_debug):
4302         Update.
4303
4304 2019-05-08  Tom Tromey  <tom@tromey.com>
4305
4306         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4307         allocate_on_obstack.
4308         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4309         (get_dwarf2_per_objfile): Update.
4310         (set_dwarf2_per_objfile): Remove.
4311         (dwarf2_has_info, dwarf2_get_section_info): Update.
4312         (dwarf2_free_objfile): Remove.
4313         (_initialize_dwarf2_read): Update.
4314
4315 2019-05-08  Tom Tromey  <tom@tromey.com>
4316
4317         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4318         initializers.
4319         <unsupported_script_warning_printed,
4320         script_not_found_warning_printed>: Now bool.
4321         (auto_load_pspace_data): Change type.
4322         (~auto_load_pspace_info): Rename from
4323         auto_load_pspace_data_cleanup.
4324         (get_auto_load_pspace_data, init_loaded_scripts_info)
4325         (clear_section_scripts, maybe_print_unsupported_script_warning)
4326         (maybe_print_script_not_found_warning, _initialize_auto_load):
4327         Update.
4328
4329 2019-05-08  Tom Tromey  <tom@tromey.com>
4330
4331         * objfiles.c (objfile_pspace_info): Add destructor and
4332         initializers.
4333         (objfiles_pspace_data): Change type.
4334         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4335         (get_objfile_pspace_data): Update.
4336         (objfiles_bfd_data): Change type.
4337         (get_objfile_bfd_data): Update.
4338         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4339
4340 2019-05-08  Tom Tromey  <tom@tromey.com>
4341
4342         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4343         Change type.
4344         (get_catch_syscall_inferior_data): Update.
4345         (catch_syscall_inferior_data_cleanup): Remove.
4346         (_initialize_break_catch_syscall): Update.
4347
4348 2019-05-08  Tom Tromey  <tom@tromey.com>
4349
4350         * inflow.c (struct terminal_info): Add destructor and
4351         initializers.
4352         (inflow_inferior_data): Change type.
4353         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4354         (get_inflow_inferior_data, inflow_inferior_exit)
4355         (swap_terminal_info, _initialize_inflow): Update.
4356
4357 2019-05-08  Tom Tromey  <tom@tromey.com>
4358
4359         * target-dcache.c (target_dcache_cleanup): Remove.
4360         (target_dcache_aspace_key): Change type.
4361         (target_dcache_init_p, target_dcache_invalidate)
4362         (target_dcache_get, target_dcache_get_or_init)
4363         (_initialize_target_dcache): Update.
4364         * dcache.h (struct dcache_deleter): New.
4365
4366 2019-05-08  Tom Tromey  <tom@tromey.com>
4367
4368         * symtab.c (struct symbol_cache): Add destructor and
4369         initializers.
4370         (symbol_cache_key): Move.  Change type.
4371         (make_symbol_cache, free_symbol_cache): Remove.
4372         (get_symbol_cache): Update.
4373         (symbol_cache_cleanup): Remove.
4374         (ALL_PSPACES, symbol_cache_flush)
4375         (maintenance_print_symbol_cache)
4376         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4377         Update.
4378
4379 2019-05-08  Tom Tromey  <tom@tromey.com>
4380
4381         * symtab.c (struct main_info): Add destructor and initializers.
4382         (main_progspace_key): Move.  Change type.
4383         (get_main_info): Update.
4384         (main_info_cleanup): Remove.
4385         (_initialize_symtab): Update.
4386
4387 2019-05-08  Tom Tromey  <tom@tromey.com>
4388
4389         * registry.h (DECLARE_REGISTRY): Define the _key class.
4390
4391 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * NEWS: Merge two 'New commands' sections.
4394
4395 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4396
4397         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4398         parameter and use Ada language definition instead.
4399         (ada_val_print_ptr): Remove unused language parameter.
4400         (ada_val_print_num): Remove language parameter and use Ada language
4401         definition instead.
4402         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4403         parameter.
4404         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4405         parameter and use Ada language definition instead.
4406         (ada_val_print_1): Update all ada_val_print_xxx calls.
4407         Remove language parameter.
4408         (ada_val_print): Update ada_val_print_1 call.
4409
4410 2019-05-08  Tom Tromey  <tromey@adacore.com>
4411
4412         * remote.c (remote_hw_watchpoint_limit)
4413         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4414         Now static.
4415
4416 2019-05-08  Tom Tromey  <tromey@adacore.com>
4417
4418         * maint.c (_initialize_maint_cmds): Move initialization code to
4419         remote.c.
4420         (watchdog, show_watchdog): Move to remote.c.
4421         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4422         "watchdog" static.
4423         (_initialize_remote): Move initialization code from maint.c.
4424         * defs.h (watchdog): Don't declare.
4425
4426 2019-05-08  Tom Tromey  <tromey@adacore.com>
4427
4428         * tui/tui-interp.c: Include main.h.
4429         * interps.c: Include main.h.
4430         * main.h (interpreter_p): Declare.
4431         * defs.h (interpreter_p): Don't declare.
4432
4433 2019-05-08  Tom Tromey  <tromey@adacore.com>
4434
4435         * dwarf2loc.c: Include dwarf2read.h.
4436         * defs.h (read_unsigned_leb128): Don't declare.
4437         * dwarf2read.h (read_unsigned_leb128): Declare.
4438
4439 2019-05-08  Tom Tromey  <tromey@adacore.com>
4440
4441         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4442         method.
4443
4444 2019-05-08  Tom Tromey  <tromey@adacore.com>
4445
4446         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4447         when no wrap column is set.
4448
4449 2019-05-08  Tom Tromey  <tromey@adacore.com>
4450
4451         * c-lang.c (c_get_string): Handle non-C-style arrays.
4452
4453 2019-05-08  Tom Tromey  <tromey@adacore.com>
4454
4455         * typeprint.c (print_offset_data::update): Print the bit offset,
4456         not the number of bits remaining.
4457
4458 2019-05-08  Tom Tromey  <tromey@adacore.com>
4459
4460         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4461         padding at end of comment.
4462
4463 2019-05-08  Tom Tromey  <tromey@adacore.com>
4464
4465         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4466         Compare main types.
4467
4468 2019-05-06  Tom Tromey  <tom@tromey.com>
4469
4470         * common/scoped_mmap.c: Include common-defs.h.
4471         * common/scoped_mmap.h: Don't include config.h.
4472
4473 2019-05-04  Tom Tromey  <tom@tromey.com>
4474
4475         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4476         (struct aarch64_call_info): Add initializers.
4477         <si>: Now a std::vector.
4478         (pass_on_stack, aarch64_push_dummy_call): Update.
4479
4480 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4481             Tom Tromey  <tom@tromey.com>
4482
4483         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4484         (ppc_threads): Now a std::vector.  Now static.
4485         (hwdebug_find_thread_points_by_tid)
4486         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4487         Update.
4488
4489 2019-05-04  Tom Tromey  <tom@tromey.com>
4490
4491         * arc-tdep.c (arc_tdesc_init): Return bool.
4492
4493 2019-05-04  Tom Tromey  <tom@tromey.com>
4494
4495         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4496         Use gdb_assert_not_reached.
4497
4498 2019-05-04  Tom Tromey  <tom@tromey.com>
4499
4500         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4501         "false".
4502
4503 2019-05-04  Tom Tromey  <tom@tromey.com>
4504
4505         * arc-tdep.c (arc_tdesc_init): Use bool.
4506
4507 2019-05-04  Tom Tromey  <tom@tromey.com>
4508
4509         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4510
4511 2019-05-04  Tom Tromey  <tom@tromey.com>
4512
4513         * cli/cli-cmds.c (valid_command_p): Return bool.
4514
4515 2019-05-04  Tom Tromey  <tom@tromey.com>
4516
4517         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4518         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4519
4520 2019-05-04  Raul Tambre  <raul@tambre.ee>
4521
4522         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4523         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4524         operator for comparison.
4525
4526 2019-05-04  Tom Tromey  <tom@tromey.com>
4527
4528         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4529         (lookup_partial_symbol, print_partial_symbols)
4530         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4531         (psymbol_compare): Update.
4532         (add_psymbol_to_bcache): Clear the entire psymbol.
4533         (maintenance_check_psymtabs): Update.
4534         * psympriv.h (struct partial_symbol): Don't derive from
4535         general_symbol_info.
4536         <obj_section, unrelocated_address, address,
4537         set_unrelocated_address>: Update.
4538         <ginfo>: New member.
4539         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4540         (debug_names::write_psymbols): Update.
4541
4542 2019-05-04  Tom de Vries  <tdevries@suse.de>
4543
4544         * contrib/cc-with-tweaks.sh: Support -n arg.
4545
4546 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4547
4548         * corelow.c (core_target::detach): Ensure frame cache and
4549         register caches are cleared.
4550         inferior.c (exit_inferior_1): Likewise.
4551
4552 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4553             Tom Tromey  <tom@tromey.com>
4554
4555         * dictionary.c (collate_pending_symbols_by_language): Remove
4556         "struct" from foreach.
4557         * symtab.c (lookup_global_symbol_from_objfile)
4558         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4559         foreach.
4560         * ser-tcp.c (net_open): Remove "struct" from foreach.
4561         * objfiles.c (objfile_relocate, objfile_rebase)
4562         (objfile_has_symbols): Remove "struct" from foreach.
4563         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4564         from foreach.
4565         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4566         foreach.
4567         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4568         "struct" from foreach.
4569         * ada-lang.c (create_excep_cond_exprs)
4570         (ada_exception_catchpoint_cond_string): Remove "struct" from
4571         foreach.
4572
4573 2019-05-03  Tom Tromey  <tromey@adacore.com>
4574
4575         * ada-exp.y (convert_char_literal): Check suffix of each
4576         enumerator.
4577
4578 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4579
4580         PR ada/21406:
4581         * ada-exp.y (yywrap): Don't define.
4582         * ada-lex.l (%option): Add noyywrap
4583         (yywrap): Remove.
4584
4585 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4586
4587         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4588         _WIN32_WINNT to the XP level, unless already defined to a higher
4589         level.
4590
4591         * unittests/parse-connection-spec-selftests.c:
4592         * ser-tcp.c:
4593         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4594         override.
4595
4596         * symfile.c (find_separate_debug_file): Remove colon from the
4597         drive spec of DOS/Windows file names of the target, so that the
4598         file name produced from DEBUGDIR and the target's directory will
4599         be valid on DOS/Windows systems.
4600
4601 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * rust-lang.c (val_print_struct): Handle printing structures
4604         containing strings.
4605
4606 2019-05-02  Tom Tromey  <tromey@adacore.com>
4607
4608         * valarith.c (_initialize_valarith): Remove.
4609
4610 2019-05-01  Tom Tromey  <tromey@adacore.com>
4611
4612         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4613         bitfields.
4614
4615 2019-05-01  Tom Tromey  <tromey@adacore.com>
4616
4617         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4618         for big-endian copies.
4619
4620 2019-04-30  Ali Tamur  <tamur@google.com>
4621         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4622         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4623         (read_3_bytes): New function.
4624
4625 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4626
4627         * windows-nat.c (main_thread_id): Delete.
4628         (handle_output_debug_string): Replace main_thread_id by
4629         current_event.dwThreadId.
4630         (fake_create_process): Likewise.
4631         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4632         Do not set main_thread_id.
4633         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4634         current_event.dwThreadId.
4635         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4636
4637 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4638
4639         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4640         Use current_event.dwThreadId instead of main_thread_id.
4641
4642 2019-04-30  Tom Tromey  <tromey@adacore.com>
4643
4644         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4645         (create_excep_cond_exprs): Iterate over program spaces.
4646         (ada_exception_catchpoint_cond_string): Examine all minimal
4647         symbols for exception types.
4648
4649 2019-04-30  Tom Tromey  <tromey@adacore.com>
4650
4651         PR c++/24470:
4652         * dwarf2read.c (process_structure_scope): Handle case where type
4653         has template parameters but no symbol was created.
4654
4655 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4656             Chris January  <chris.january@arm.com>
4657
4658         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4659         qualifier.
4660         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4661
4662 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4663
4664         * f-typeprint.c (f_print_type): Update rules for printing
4665         whitespace.
4666         (f_type_print_varspec_suffix): Likewise.
4667
4668 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4669             Chris January  <chris.january@arm.com>
4670
4671         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4672         function arguments.
4673
4674 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4675
4676         * f-lang.c (build_fortran_types): Change name of void type to
4677         lower case.
4678         * f-typeprint.c (f_type_print_base): Print the name of the void
4679         type, rather than a fixed string.
4680         * f-valprint.c (f_decorations): Use lower case void string.
4681
4682 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4683             Chris January  <chris.january@arm.com>
4684
4685         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4686         types for Fortran.
4687
4688 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4689             Chris January  <chris.january@arm.com>
4690             David Lecomber  <david.lecomber@arm.com>
4691
4692         * f-exp.y (BINOP_INTRINSIC): New token.
4693         (exp): New parser rule handling BINOP_INTRINSIC.
4694         (f77_keywords): Add new builtin procedures.
4695         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4696         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4697         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4698         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4699         (print_unop_subexp_f): New function.
4700         (print_binop_subexp_f): New function.
4701         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4702         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4703         (dump_subexp_body_f): Likewise.
4704         (operator_check_f): Likewise.
4705         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4706         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4707
4708 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4711         UNOP_KIND.
4712         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4713         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4714         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4715         (operator_length_f): New fuction.
4716         (print_subexp_f): New function.
4717         (op_name_f): New function.
4718         (dump_subexp_body_f): New function.
4719         (operator_check_f): New function.
4720         (exp_descriptor_f): Replace standard expression handling functions
4721         with new functions.
4722         * gdb/fortran-operator.def: New file.
4723         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4724         * gdb/std-operator.def: Remove UNOP_KIND.
4725
4726 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4727
4728         * std-operator.def: Remove unbalanced, stray double quote
4729         character.
4730
4731 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4732             Chris January  <chris.january@arm.com>
4733             Daniel Everett  <daniel.everett@arm.com>
4734             Nick Forrington  <nick.forrington@arm.com>
4735             Richard Bunt  <richard.bunt@arm.com>
4736
4737         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4738         of depth when printing anonymous structs or unions.
4739         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4740         Don't print either the top-level value, or the children if the
4741         max-depth is exceeded.
4742         (ppscm_print_children): When printing the key of a map, allow one
4743         extra level of depth.
4744         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4745         print either the top-level value, or the children if the max-depth
4746         is exceeded.
4747         (print_children): When printing the key of a map, allow one extra
4748         level of depth.
4749         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4750         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4751         (user_print_options): Initialise max_depth field.
4752         (val_print_scalar_or_string_type_p): New function.
4753         (val_print): Check to see if the max depth has been reached.
4754         (val_print_check_max_depth): Define new function.
4755         (show_print_max_depth): New function.
4756         (_initialize_valprint): Add 'print max-depth' option.
4757         * valprint.h (struct value_print_options) <max_depth>: New field.
4758         (val_print_check_max_depth): Declare new function.
4759         * NEWS: Document new feature.
4760
4761 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4762
4763         * ada-lang.c (ada_language_defn): Initialise new field.
4764         * c-lang.c (c_is_string_type_p): New function.
4765         (c_language_defn): Initialise new field.
4766         (cplus_language_defn): Initialise new field.
4767         (asm_language_defn): Initialise new field.
4768         (minimal_language_defn): Initialise new field.
4769         * c-lang.h (c_is_string_type_p): Declare new function.
4770         * d-lang.c (d_language_defn): Initialise new field.
4771         * f-lang.c (f_is_string_type_p): New function.
4772         (f_language_defn): Initialise new field.
4773         * go-lang.c (go_is_string_type_p): New function.
4774         (go_language_defn): Initialise new field.
4775         * language.c (default_is_string_type_p): New function.
4776         (unknown_language_defn): Initialise new field.
4777         (auto_language_defn): Initialise new field.
4778         * language.h (struct language_defn) <la_is_string_type_p>: New
4779         member variable.
4780         (default_is_string_type_p): Declare new function.
4781         * m2-lang.c (m2_language_defn): Initialise new field.
4782         * objc-lang.c (objc_language_defn): Initialise new field.
4783         * opencl-lang.c (opencl_language_defn): Initialise new field.
4784         * p-lang.c (pascal_is_string_type_p): New function.
4785         (pascal_language_defn): Initialise new field.
4786         * rust-lang.c (rust_is_string_type_p): New function.
4787         (rust_language_defn): Initialise new field.
4788
4789 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4790
4791         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4792         New field.
4793         * ada-lang.c (ada_language_defn): Initialise new field.
4794         * c-lang.c (c_language_defn): Likewise.
4795         (cplus_language_defn): Likewise.
4796         (asm_language_defn): Likewise.
4797         (minimal_language_defn): Likewise.
4798         * d-lang.c (d_language_defn): Likewise.
4799         * f-lang.c (f_language_defn): Likewise.
4800         * go-lang.c (go_language_defn): Likewise.
4801         * language.c (unknown_language_defn): Likewise.
4802         (auto_language_defn): Likewise.
4803         * m2-lang.c (m2_language_defn): Likewise.
4804         * objc-lang.c (objc_language_defn): Likewise.
4805         * opencl-lang.c (opencl_language_defn): Likewise.
4806         * p-lang.c (pascal_language_defn): Likewise.
4807         * rust-lang.c (rust_language_defn): Likewise.
4808
4809 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4810
4811         * ada-lang.c (ada_is_character_type): Change return type to bool.
4812         (ada_is_string_type): Likewise.
4813         * ada-lang.h (ada_is_character_type): Update declaration
4814         (ada_is_string_type): Likewise.
4815
4816 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4817
4818         Support style in 'frame|thread apply'
4819
4820         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4821         * record.c (record_start, record_stop): Update callers of
4822         execute_command_to_string with false.
4823         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4824         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4825         methods.
4826         (class string_file): New constructor with term_out parameter.
4827         Override methods term_out and can_emit_style_escape.  New member
4828         term_out.
4829         (class stdio_file): Override can_emit_style_escape.
4830         (class tee_file): Override term_out and can_emit_style_escape.
4831         * utils.h (can_emit_style_escape): Remove.
4832         * utils.c (can_emit_style_escape): Likewise.
4833         Update all callers of can_emit_style_escape (SOMESTREAM) to
4834         SOMESTREAM->can_emit_style_escape.
4835         * source-cache.c (source_cache::get_source_lines): Likewise.
4836         * stack.c (frame_apply_command_count): Call execute_command_to_string
4837         passing the term_out characteristic of the current gdb_stdout.
4838         * thread.c (thr_try_catch_cmd): Likewise.
4839         * top.c (execute_command_to_string): pass term_out parameter
4840         to construct the string_file for the command output.
4841         * ui-file.c (term_cli_styling): New function (most code moved
4842         from utils.c can_emit_style_escape).
4843         (string_file::string_file, string_file::can_emit_style_escape,
4844         stdio_file::can_emit_style_escape, tee_file::term_out,
4845         tee_file::can_emit_style_escape): New functions.
4846
4847 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4848
4849         * NEWS: Mention the new set|show may-call-functions.
4850         * infcall.c (may_call_functions_p): New variable.
4851         (show_may_call_functions_p): New function.
4852         (call_function_by_hand_dummy): Throws an error if not
4853         may-call-functions.
4854         (_initialize_infcall): Call add_setshow_boolean_cmd for
4855         may-call-functions.
4856
4857 2019-04-25  Keith Seitz  <keiths@redhat.com>
4858
4859         PR c++/24367
4860         * cp-support.c (inspect_type): Don't attempt substitutions
4861         of symbol with the same name.
4862
4863 2019-04-25  Tom Tromey  <tromey@adacore.com>
4864
4865         PR gdb/24475:
4866         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4867         static.
4868
4869 2019-04-25  Tom Tromey  <tromey@adacore.com>
4870
4871         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4872         rvalue reference.
4873         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4874         (gdb_xml_parser::parse): Use std::move.
4875         * python/python-internal.h (gdbpy_convert_exception): Take a const
4876         reference.
4877         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4878         std::move.
4879         * python/py-utils.c (gdbpy_convert_exception): Take a const
4880         reference.
4881         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4882         Use std::move.
4883         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4884         Use std::move.
4885         * mi/mi-main.c (mi_print_exception): Take a const reference.
4886         * main.c (handle_command_errors): Take a const reference.
4887         * linespec.c (parse_linespec): Use std::move.
4888         * infcall.c (run_inferior_call): Use std::move.
4889         (call_function_by_hand_dummy): Use std::move.
4890         * exec.c (try_open_exec_file): Use std::move.
4891         * exceptions.h (exception_print, exception_fprintf)
4892         (exception_print_same): Update.
4893         * exceptions.c (print_exception, exception_print)
4894         (exception_fprintf, exception_print_same): Change parameters to
4895         const reference.
4896         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4897         * common/new-op.c: Use std::move.
4898         * common/common-exceptions.h (struct gdb_exception): Add move
4899         constructor.
4900         (struct gdb_exception_error, struct gdb_exception_quit, struct
4901         gdb_quit_bad_alloc): Change constructor to move constructor.
4902         (throw_exception): Change parameter to rvalue reference.
4903         * common/common-exceptions.c (throw_exception): Take rvalue
4904         reference.
4905         * cli/cli-interp.c (safe_execute_command): Use std::move.
4906         * breakpoint.c (insert_bp_location, location_to_sals): Use
4907         std::move.
4908
4909 2019-04-25  Tom Tromey  <tromey@adacore.com>
4910
4911         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4912         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4913         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4914         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4915         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4916         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4917         guile/scm-value.c: Use unpack.
4918         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4919         gdbscm_gdb_exception.
4920         (gdbscm_throw_gdb_exception): Likewise.
4921         (struct gdbscm_gdb_exception): New.
4922         (unpack): New function.
4923         (gdbscm_wrap): Use unpack.
4924
4925 2019-04-25  Tom Tromey  <tromey@adacore.com>
4926
4927         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4928         (gdb_rl_callback_handler): Use std::move.
4929         * common/common-exceptions.h (struct gdb_exception): Add move
4930         assignment operator.
4931         (throw_exception_sjlj): Change "exception" to const reference.
4932         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4933         (throw_exception_sjlj): Change "exception" to const reference.
4934
4935 2019-04-25  Tom Tromey  <tromey@adacore.com>
4936
4937         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4938         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4939         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4940         Update.
4941         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4942         Update.
4943         * mi/mi-interp.c (mi_interp::exec): Update.
4944         * linespec.c (parse_linespec): Update.
4945         * infcall.c (run_inferior_call): Update.
4946         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4947         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4948         (gdbscm_lookup_global_symbol): Update.
4949         * guile/scm-param.c (gdbscm_parameter_value): Update.
4950         * guile/scm-frame.c (gdbscm_frame_read_register)
4951         (gdbscm_frame_read_var): Update.
4952         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4953         * exec.c (try_open_exec_file): Update.
4954         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4955         (gdb_rl_callback_handler): Update.
4956         * common/common-exceptions.h (exception_none): Don't declare.
4957         * common/common-exceptions.c (exception_none): Don't define.
4958         (struct catcher) <exception>: Update.
4959         * cli/cli-interp.c (safe_execute_command): Update.
4960         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4961
4962 2019-04-25  Ali Tamur  <tamur@google.com>
4963
4964         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4965         (read_attribute_value): Likewise.
4966         (dwarf2_read_addr_index): Update comment.
4967         (read_str_index): Add DW_FORM_strx.
4968         (dwarf2_string_attr): Likewise.
4969         (dwarf2_const_value_attr): Likewise.
4970         (dump_die_shallow): Likewise.
4971         (dwarf2_fetch_constant_bytes): Likewise.
4972         (skip_form_bytes): Likewise.
4973         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4974
4975 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4976
4977         PR corefiles/11608
4978         PR corefiles/18187
4979         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4980         OFFSET.  Verify if current mapping contains an ELF header.
4981         (linux_find_memory_regions_full): Adjust call to
4982         dump_mapping_p.
4983
4984 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4985             Kang Li <kanglictf@gmail.com>
4986
4987         PR gdb/21600
4988
4989         * dwarf2-frame.c (read_initial_length): Be consistent about using
4990         unsigned representation of length.
4991         (decode_frame_entry_1): Likewise.  Check for wraparound of
4992         end pointer as well as buffer overflow.
4993
4994 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4995
4996         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4997         "vq".
4998
4999 2019-04-24  Tom Tromey  <tromey@adacore.com>
5000
5001         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5002
5003 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5004
5005         * s12z-tdep.c (s12z_unwind_pc): Delete.
5006         (s12z_unwind_sp): Delete.
5007         (s12z_gdbarch_init): Don't register deleted functions with
5008         gdbarch.
5009
5010 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5011
5012         * rl78-tdep.c (rl78_unwind_sp): Delete.
5013         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5014
5015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5016
5017         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5018         (xstormy16_unwind_pc): Delete.
5019         (xstormy16_dummy_id): Delete.
5020         (xstormy16_gdbarch_init): Don't register deleted functions with
5021         gdbarch.
5022
5023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5024
5025         * vax-tdep.c (vax_unwind_pc): Delete.
5026         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5027
5028 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5029
5030         * v850-tdep.c (v850_unwind_sp): Delete.
5031         (v850_unwind_pc): Delete.
5032         (v850_dummy_id): Delete.
5033         (v850_gdbarch_init): Don't register deleted functions with
5034         gdbarch.
5035
5036 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5037
5038         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5039         (tilegx_unwind_pc): Delete.
5040         (tilegx_unwind_dummy_id): Delete.
5041         (tilegx_gdbarch_init): Don't register deleted functions with
5042         gdbarch.
5043
5044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5045
5046         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5047         (tic6x_dummy_id): Delete.
5048         (tic6x_gdbarch_init): Don't register deleted functions with
5049         gdbarch.
5050
5051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5052
5053         * sparc-tdep.c (sparc_unwind_pc): Delete.
5054         (sparc32_gdbarch_init): Don't register deleted function with
5055         gdbarch.
5056
5057 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5058
5059         * sh-tdep.c (sh_unwind_sp): Delete.
5060         (sh_unwind_pc): Delete.
5061         (sh_dummy_id): Delete.
5062         (sh_gdbarch_init): Don't register deleted functions with
5063         gdbarch.
5064
5065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * score-tdep.c (score_unwind_sp): Delete.
5068         (score_unwind_pc): Delete.
5069         (score_dummy_id): Delete.
5070         (score_gdbarch_init): Don't register deleted functions with
5071         gdbarch.
5072
5073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5074
5075         * rx-tdep.c (rx_unwind_pc): Delete.
5076         (rx_unwind_sp): Delete.
5077         (rx_dummy_id): Delete.
5078         (rx_gdbarch_init): Don't register deleted functions with
5079         gdbarch.  Update comment.
5080
5081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5082
5083         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5084         (rs6000_dummy_id): Delete.
5085         (rs6000_gdbarch_init): Don't register deleted functions with
5086         gdbarch.
5087
5088 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * or1k-tdep.c (or1k_dummy_id): Delete.
5091         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5092
5093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5094
5095         * nios2-tdep.c (nios2_dummy_id): Delete.
5096         (nios2_unwind_sp): Delete.
5097         (nios2_gdbarch_init): Don't register deleted functions with
5098         gdbarch.
5099
5100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * nds32-tdep.c (nds32_dummy_id): Delete.
5103         (nds32_unwind_pc): Delete.
5104         (nds32_unwind_sp): Delete.
5105         (nds32_gdbarch_init): Don't register deleted functions with
5106         gdbarch.
5107
5108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * msp430-tdep.c (msp430_unwind_pc): Delete.
5111         (msp430_unwind_sp): Delete.
5112         (msp430_dummy_id): Delete.
5113         (msp430_gdbarch_init): Don't register deleted functions with
5114         gdbarch.
5115
5116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5117
5118         * moxie-tdep.c (moxie_unwind_sp): Delete.
5119         (moxie_unwind_pc): Delete.
5120         (moxie_dummy_id): Delete.
5121         (moxie_gdbarch_init): Don't register deleted functions with
5122         gdbarch.
5123
5124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5127         (mn10300_unwind_pc): Delete.
5128         (mn10300_unwind_sp): Delete.
5129         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5130         mn10300_unwind_sp.
5131         (mn10300_frame_unwind_init): Don't register deleted functions with
5132         gdbarch.
5133
5134 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         * mep-tdep.c (mep_unwind_pc): Delete.
5137         (mep_unwind_sp): Delete.
5138         (mep_dummy_id): Delete.
5139         (mep_gdbarch_init): Don't register deleted functions with
5140         gdbarch.
5141
5142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5143
5144         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5145         (m68hc11_unwind_sp): Delete.
5146         (m68hc11_gdbarch_init): Don't register deleted functions with
5147         gdbarch.
5148
5149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5150
5151         * m32r-tdep.c (m32r_unwind_sp): Delete.
5152         (m32r_unwind_pc): Delete.
5153         (m32r_dummy_id): Delete.
5154         (m32r_gdbarch_init): Don't register deleted functions with
5155         gdbarch.
5156
5157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         * m32c-tdep.c (m32c_unwind_pc): Delete.
5160         (m32c_unwind_sp): Delete.
5161         (m32c_dummy_id): Delete.
5162         (m32c_gdbarch_init): Don't register deleted functions with
5163         gdbarch.
5164
5165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5166
5167         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5168         (lm32_unwind_pc): Delete.
5169         (lm32_dummy_id): Delete.
5170         (lm32_gdbarch_init): Don't register deleted functions with
5171         gdbarch.
5172
5173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5174
5175         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5176         (iq2000_unwind_pc): Delete.
5177         (iq2000_dummy_id): Delete.
5178         (iq2000_gdbarch_init): Don't register deleted functions with
5179         gdbarch.
5180
5181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5182
5183         * nds32-tdep.c (nds32_type_align): Delete.
5184         (nds32_push_dummy_call): Use type_align instead.
5185
5186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5187
5188         * arm-tdep.c (arm_type_align): Only handle vector override case.
5189         (arm_push_dummy_call): Use type_align.
5190         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5191
5192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5193
5194         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5195         case.
5196         (pass_on_stack): Use type_align.
5197         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5198         function.
5199
5200 2019-04-23  Tom Tromey  <tromey@adacore.com>
5201
5202         * dwarf2read.c (line_header::file_name_at): Remove unused
5203         overload.
5204
5205 2019-04-23  Tom de Vries  <tdevries@suse.de>
5206
5207         PR gdb/24438
5208         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5209         invocation.
5210
5211
5212 2019-03-27  Ali Tamur  <tamur@google.com>
5213
5214         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5215         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5216         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5217         (dwarf_expr_context::get_addr_index): Likewise
5218         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5219         (symbol_needs_eval_context::get_addr_index): Likewise
5220         (disassemble_dwarf_expression): Add DW_OP_addrx
5221         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5222         (read_cutu_die_from_dwo): Update comment
5223         (skip_one_die): Add DW_FORM_addrx
5224         (read_attribute_value): Likewise
5225         (var_decode_location): Add DW_OP_addrx
5226         (dwarf2_const_value_attr): Add DW_FORM_addrx
5227         (dump_die_shallow): Likewise
5228         (dwarf2_fetch_constant_bytes): Likewise
5229         (decode_locdesc): Add DW_OP_addrx
5230         (skip_form_bytes): Add DW_FORM_addrx
5231
5232 2019-04-22  Ali Tamur  <tamur@google.com>
5233
5234         * MAINTAINERS (Write After Approval): Add self.
5235
5236 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5237
5238         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5239         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5240         (open_symbol_file_object): Likewise.
5241         (svr4_default_sos): Add info parameter.
5242         (svr4_read_so_list): Likewise.
5243         (svr4_current_sos_direct): Adjust functions calls to pass down
5244         info.
5245         (svr4_current_sos_1): Add info parameter.
5246         (svr4_current_sos): Call get_svr4_info, pass info down to
5247         svr4_current_sos_1.
5248         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5249         get_svr4_info.
5250         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5251         get_svr4_info.
5252         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5253         to get_svr4_info.
5254         (probes_table_remove_objfile_probes): Likewise.
5255         (register_solib_event_probe): Add info parameter.
5256         (solist_update_incremental): Pass info parameter down to
5257         svr4_read_so_list.
5258         (disable_probes_interface): Add info parameter.
5259         (svr4_handle_solib_event): Pass current_program_space to
5260         get_svr4_info.  Adjust disable_probes_interface cleanup.
5261         (svr4_create_probe_breakpoints): Add info parameter, pass it
5262         down to register_solib_event_probe.
5263         (svr4_create_solib_event_breakpoints): Add info parameter,
5264         pass it down to svr4_create_probe_breakpoints.
5265         (enable_break): Pass info down to
5266         svr4_create_solib_event_breakpoints.
5267         (svr4_solib_create_inferior_hook): Pass current_program_space to
5268         get_svr4_info.
5269         (svr4_clear_solib): Likewise.
5270
5271 2019-04-22  Pedro Alves  <palves@redhat.com>
5272
5273         * solib-svr4.c (svr4_free_objfile_observer): New.
5274         (probe_and_action::objfile): New field.
5275         (probes_table_htab_remove_objfile_probes)
5276         (probes_table_remove_objfile_probes): New functions.
5277         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5278         in the new probe_and_action.  Don't store the probe in 'lookup'.
5279         (svr4_create_probe_breakpoints): Pass objfile to
5280         register_solib_event_probe.
5281         (_initialize_svr4_solib): Register a free_objfile observer.
5282
5283 2019-04-19  Tom Tromey  <tom@tromey.com>
5284
5285         * common/queue.h: Remove.
5286
5287 2019-04-19  Tom Tromey  <tom@tromey.com>
5288
5289         * event-loop.c: Don't include "common/queue.h".
5290
5291 2019-04-19  Tom Tromey  <tom@tromey.com>
5292
5293         * remote.c (remote_target): Use delete.
5294         * remote-notif.h: Include <list>, not "common/queue.h".
5295         (notif_client_p): Remove typedef.
5296         (remote_notif_state): Add constructor, destructor, initializer.
5297         <notif_queue>: Now a std::list.
5298         (remote_notif_state_xfree): Don't declare.
5299         * remote-notif.c (remote_notif_process, handle_notification)
5300         (remote_notif_state_allocate): Update.
5301         (~remote_notif_state): Rename from remote_notif_state_xfree.
5302
5303 2019-04-19  Tom Tromey  <tom@tromey.com>
5304
5305         * symfile.c (reread_symbols): Update.
5306         * objfiles.c (objfile_register_static_link)
5307         (objfile_lookup_static_link): Update
5308         (~objfile) Don't delete static_links.
5309         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5310
5311 2019-04-19  Tom Tromey  <tom@tromey.com>
5312
5313         * type-stack.h (struct type_stack) <insert>: Constify string.
5314         * type-stack.c (type_stack::insert): Constify string.
5315         * gdbtypes.h (lookup_template_type): Update.
5316         (address_space_name_to_int): Update.
5317         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5318         const.
5319         (lookup_template_type): Make name const.
5320         * c-exp.y: Update rules.
5321         (lex_one_token, classify_name, classify_inner_name)
5322         (c_print_token): Update.
5323         * p-exp.y: Update rules.
5324         (yylex): Update.
5325         * f-exp.y: Update rules.
5326         (yylex): Update.
5327         * d-exp.y: Update rules.
5328         (lex_one_token, classify_name, classify_inner_name): Update.
5329         * parse.c (write_dollar_variable, copy_name): Return std::string.
5330         * parser-defs.h (copy_name): Change return type.
5331         * m2-exp.y: Update rules.
5332         (yylex): Update.
5333         * go-exp.y (lex_one_token): Update.
5334         Update rules.
5335         (classify_unsafe_function, classify_packaged_name)
5336         (classify_name, yylex): Update.
5337
5338 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5339
5340         * configure.ac: add --enable-source-highlight switch.
5341         * configure: Regenerate.
5342         * top.c (print_gdb_version): plumb --enable-source-highlight
5343         status to "show configuration".
5344
5345 2019-04-19  Tom Tromey  <tromey@adacore.com>
5346
5347         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5348         Check ADA_TYPE_P.
5349         (empty_record, ada_template_to_fixed_record_type_1)
5350         (template_to_static_fixed_type)
5351         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5352         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5353         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5354         macros.
5355
5356 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5357
5358         PR symtab/24423:
5359         * source.c (print_source_lines_base): Advance "iter" when a
5360         control character is seen.
5361
5362 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5363
5364         * inferior.h (struct infcall_suspend_state_deleter):
5365         Catch exception in destructor to avoid crash.
5366
5367 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5368
5369         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5370         close to the add_com "shell".
5371
5372 2019-04-18  Tom Tromey  <tromey@adacore.com>
5373
5374         * process-stratum-target.h (class process_stratum_target)
5375         <stratum>: Add "final".
5376
5377 2019-04-17  Tom Tromey  <tromey@adacore.com>
5378
5379         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5380         against nullptr before use.
5381
5382 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5383
5384         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5385
5386 2019-04-17  Jim Wilson  <jimw@sifive.com>
5387             Andrew Burgess  <andrew.burgess@embecosm.com>
5388
5389         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5390         code read might fail, assume 4-byte breakpoint in that case.
5391
5392 2019-04-15  Leszek Swirski  <leszeks@google.com>
5393
5394         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5395         rather than a hand-rolled POD check when checking for forced MEMORY
5396         classification.
5397
5398 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5399
5400         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5401         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5402         function.
5403         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5404         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5405         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5406         declaration.
5407
5408 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5409
5410         * aarch64-linux-nat.c
5411         (aarch64_linux_nat_target::thread_architecture): Add override.
5412         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5413         each VQ.
5414
5415 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5416
5417         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5418
5419 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5420
5421         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5422         target types of size 96-bits, add some additional comments, and
5423         check that the builtin type we found was the correct size.
5424
5425 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5426
5427         * utils.c (prompt_for_continue): Don't restore the styling at the
5428         end, as applied_style has the wrong value.  This fixes styling in
5429         long lists of file names that are interrupted by the "Continue?"
5430         prompt.
5431
5432 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5435         * c-lang.c (c_language_defn): Likewise.
5436         (cplus_language_defn): Likewise.
5437         (asm_language_defn): Likewise.
5438         (minimal_language_defn): Likewise.
5439         * d-lang.c (d_language_defn): Likewise.
5440         * f-lang.c (f_language_defn): Likewise.
5441         * go-lang.c (go_language_defn): Likewise.
5442         * language.c (unknown_language_defn): Likewise.
5443         (auto_language_defn): Likewise.
5444         * language.h (struct language_defn): Remove la_magic field.
5445         (LANG_MAGIC): Delete.
5446         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5447         * objc-lang.c (objc_language_defn): Likewise.
5448         * opencl-lang.c (opencl_language_defn): Likewise.
5449         * p-lang.c (pascal_language_defn): Likewise.
5450         * rust-lang.c (rust_language_defn): Likewise.
5451
5452 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5453
5454         * riscv-tdep.c (riscv_type_align): New function.
5455         (riscv_type_alignment): Delete.
5456         (riscv_arg_location): Use 'type_align'.
5457         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5458
5459 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5460
5461         * gdbtypes.c (type_align): A struct with no non-static fields also
5462         has alignment of 1.
5463
5464 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5465
5466         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5467         component to 0.
5468         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5469         member.
5470         (riscv_struct_info::analyse): New implementation using new
5471         analyse_inner member function.
5472         (riscv_struct_info::field_offset): New member function.
5473         (riscv_struct_info::m_offsets): New member variable.
5474         (riscv_struct_info::analyse_inner): New private member function,
5475         takes the old implementation of riscv_struct_info::analyse but
5476         extended to track field offsets.
5477         (riscv_call_arg_struct): Update the struct folding special cases
5478         to handle cases where empty C++ structs, which are non-zero
5479         length, are found.
5480         (riscv_arg_location): Initialise the length of each location, a
5481         non-zero length now indicates the location is in use.
5482         (riscv_push_dummy_call): Allow for the first location having a
5483         non-zero offset when setting up arguments.
5484         (riscv_return_value): Likewise, but for return values.
5485
5486 2019-04-11  Tom Tromey  <tromey@adacore.com>
5487
5488         * utils.c (internal_vproblem): Make "msg" const.
5489
5490 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5491
5492         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5493         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5494         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5495         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5496
5497 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5498
5499         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5500         function.
5501         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5502         of amd64_collect_native_gregset.
5503         (amd64_linux_nat_target::store_registers): Likewise.
5504
5505 2019-04-10  Tom Tromey  <tom@tromey.com>
5506
5507         * symtab.c (lookup_global_symbol_from_objfile)
5508         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5509         * objfiles.h (class separate_debug_iterator): New.
5510         (class separate_debug_range): New.
5511         (struct objfile) <separate_debug_objfiles>: New method.
5512         (objfile_separate_debug_iterate): Don't declare.
5513         * objfiles.c (separate_debug_iterator::operator++): Rename from
5514         objfile_separate_debug_iterate.
5515         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5516         iterator.
5517         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5518         iterator.
5519
5520 2019-04-10  Tom Tromey  <tom@tromey.com>
5521
5522         * symfile.c (reread_symbols): Remove old comment.
5523         * objfiles.c (free_all_objfiles): Fix a typo.
5524
5525 2019-04-10  Tom Tromey  <tom@tromey.com>
5526
5527         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5528         * minsyms.c (lookup_minimal_symbol): Use foreach.
5529         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5530         (lookup_minimal_symbol_solib_trampoline): Likewise.
5531         * symfile.c (reread_symbols): Use foreach.
5532
5533 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5534             Tom Tromey  <tromey@adacore.com>
5535
5536         PR rust/24414:
5537         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5538         (rust_lex_int_test): Change "value" to be LONGEST.
5539         (rust_lex_tests): Add test for long integer literal.
5540
5541 2019-04-09  Tom Tromey  <tromey@adacore.com>
5542
5543         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5544         to bool.
5545         (extended_remote_target::attach): Update.
5546         (remote_target::remote_notice_new_inferior): Update.
5547         (remote_target::add_current_inferior_and_thread): Update.
5548         * inferior.c (exit_inferior_1): Use "false".
5549         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5550
5551 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5552
5553         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5554         the "start" command.
5555
5556 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5557
5558         * python/py-inferior.c (infpy_thread_from_thread_handle):
5559         Adjust comments to reflect renaming of thread_from_thread_handle
5560         to thread_from_handle.  Adjust keywords.  Fix type error message.
5561         (inferior_object_methods): Add thread_from_handle.  Retain
5562         thread_from_thread_handle, but mark it as deprecated.
5563
5564 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5565
5566         * gdbthread.h (find_thread_by_handle): Revise declaration.
5567         * thread.c (find_thread_by_handle): Likewise.  Adjust
5568         implementation too.
5569         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5570         support for buffer objects as handles.
5571
5572 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5573
5574         * python/py-infthread.c (thpy_thread_handle): New function.
5575         (thread_object_methods): Register thpy_thread_handle.
5576
5577 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5578
5579         * gdbthread.h (thread_to_thread_handle): Declare.
5580         * thread.c (gdbtypes.h): Include.
5581         (thread_to_thread_handle): New function.
5582
5583         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5584         (target_thread_info_to_thread_handle): Declare.
5585         * target.c (target_thread_info_to_thread_handle): New function.
5586         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5587         * target-delegates.c: Regenerate.
5588
5589         * linux-thread-db.c (class thread_db_target): Add method
5590         thread_info_to_thread_handle.
5591         (thread_db_target::thread_info_to_thread_handle): Define.
5592         * remote.c (class remote_target): Add new method
5593         thread_info_to_thread_handle.
5594         (remote_target::thread_info_to_thread_handle): Define.
5595
5596 2019-04-08  Pedro Alves  <palves@redhat.com>
5597
5598         * common/common-exceptions.c (throw_exception): Don't create
5599         named object to throw; throw directly.
5600         (throw_it): Likewise.  Don't initialize gdb_exception::message
5601         here, with new; pass FMT and AP to the ctor instead.
5602         * common/common-exceptions.h: Include <string>.
5603         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5604         const char *, va_list)): New ctor.  Use std::make_shared.
5605         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5606         errors)): Delete.
5607         (gdb_exception_error::gdb_exception_error(enum errors, const char
5608         *, va_list)): New.
5609         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5610         Add assertion.
5611         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5612         errors)): Delete.
5613         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5614         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5615         Add assertion.
5616
5617 2019-04-08  Tom Tromey  <tom@tromey.com>
5618
5619         * valops.c (value_rtti_indirect_type): Replace throw_exception
5620         with throw.
5621         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5622         with throw.
5623         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5624         throw.
5625         * target.c (target_translate_tls_address): Replace throw_exception
5626         with throw.
5627         * stack.c (frame_apply_command_count): Replace throw_exception
5628         with throw.
5629         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5630         throw.
5631         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5632         with throw.
5633         * rs6000-tdep.c (rs6000_frame_cache)
5634         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5635         * remote.c: Replace throw_exception with throw.
5636         * record-full.c (record_full_message, record_full_wait_1)
5637         (record_full_restore): Replace throw_exception with throw.
5638         * record-btrace.c:
5639         (get_thread_current_frame_id, record_btrace_start_replaying)
5640         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5641         (cmd_record_btrace_start): Replace throw_exception with throw.
5642         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5643         throw.
5644         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5645         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5646         * linespec.c:
5647         (find_linespec_symbols): Replace throw_exception with throw.
5648         * infrun.c (displaced_step_prepare, resume): Replace
5649         throw_exception with throw.
5650         * infcmd.c (post_create_inferior): Replace throw_exception with
5651         throw.
5652         * inf-loop.c (inferior_event_handler): Replace throw_exception
5653         with throw.
5654         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5655         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5656         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5657         (get_prev_frame_always, get_frame_pc_if_available)
5658         (get_frame_address_in_block_if_available, get_frame_language):
5659         Replace throw_exception with throw.
5660         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5661         throw_exception with throw.
5662         * eval.c (fetch_subexp_value, evaluate_var_value)
5663         (evaluate_funcall, evaluate_subexp_standard): Replace
5664         throw_exception with throw.
5665         * dwarf2loc.c (call_site_find_chain)
5666         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5667         Replace throw_exception with throw.
5668         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5669         with throw.
5670         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5671         throw.
5672         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5673         * completer.c (complete_line_internal): Replace throw_exception
5674         with throw.
5675         * compile/compile-object-run.c (compile_object_run): Replace
5676         throw_exception with throw.
5677         * cli/cli-script.c (process_next_line): Replace throw_exception
5678         with throw.
5679         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5680         (btrace_enable, btrace_maint_update_pt_packets): Replace
5681         throw_exception with throw.
5682         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5683         throw_exception with throw.
5684         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5685         throw_exception with throw.
5686         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5687         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5688         * aarch64-tdep.c (aarch64_make_prologue_cache)
5689         (aarch64_make_stub_cache): Replace throw_exception with throw.
5690
5691 2019-04-08  Tom Tromey  <tom@tromey.com>
5692
5693         * common/common-exceptions.c (throw_exception): Rename from
5694         throw_exception_cxx.  Remove old copy.  Make argument const.
5695         (throw_it): Create and throw exception objects directly.
5696         * common/common-exceptions.h (throw_exception): Make argument
5697         const.
5698         (struct gdb_exception_error): Add constructor.
5699         (struct gdb_exception_quit): Add constructor.
5700
5701 2019-04-08  Tom Tromey  <tom@tromey.com>
5702
5703         * common/common-exceptions.h (exception_rethrow): Don't declare.
5704         (TRY_SJLJ): Update comment.
5705         (TRY, CATCH, END_CATCH): Remove.
5706         * common/common-exceptions.c (exception_rethrow): Remove.
5707
5708 2019-04-08  Tom Tromey  <tom@tromey.com>
5709
5710         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5711         Remove.
5712         (gdb_exception_error): Rename from
5713         gdb_exception_RETURN_MASK_ERROR.
5714         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5715         (gdb_quit_bad_alloc): Update.
5716         * aarch64-tdep.c: Update.
5717         * ada-lang.c: Update.
5718         * ada-typeprint.c: Update.
5719         * ada-valprint.c: Update.
5720         * amd64-tdep.c: Update.
5721         * arch-utils.c: Update.
5722         * break-catch-throw.c: Update.
5723         * breakpoint.c: Update.
5724         * btrace.c: Update.
5725         * c-varobj.c: Update.
5726         * cli/cli-cmds.c: Update.
5727         * cli/cli-interp.c: Update.
5728         * cli/cli-script.c: Update.
5729         * common/common-exceptions.c: Update.
5730         * common/new-op.c: Update.
5731         * common/selftest.c: Update.
5732         * compile/compile-c-symbols.c: Update.
5733         * compile/compile-cplus-symbols.c: Update.
5734         * compile/compile-object-load.c: Update.
5735         * compile/compile-object-run.c: Update.
5736         * completer.c: Update.
5737         * corelow.c: Update.
5738         * cp-abi.c: Update.
5739         * cp-support.c: Update.
5740         * cp-valprint.c: Update.
5741         * darwin-nat.c: Update.
5742         * disasm-selftests.c: Update.
5743         * dtrace-probe.c: Update.
5744         * dwarf-index-cache.c: Update.
5745         * dwarf-index-write.c: Update.
5746         * dwarf2-frame-tailcall.c: Update.
5747         * dwarf2-frame.c: Update.
5748         * dwarf2loc.c: Update.
5749         * dwarf2read.c: Update.
5750         * eval.c: Update.
5751         * event-loop.c: Update.
5752         * event-top.c: Update.
5753         * exec.c: Update.
5754         * f-valprint.c: Update.
5755         * fbsd-tdep.c: Update.
5756         * frame-unwind.c: Update.
5757         * frame.c: Update.
5758         * gdbtypes.c: Update.
5759         * gnu-v3-abi.c: Update.
5760         * guile/guile-internal.h: Update.
5761         * guile/scm-block.c: Update.
5762         * guile/scm-breakpoint.c: Update.
5763         * guile/scm-cmd.c: Update.
5764         * guile/scm-disasm.c: Update.
5765         * guile/scm-frame.c: Update.
5766         * guile/scm-lazy-string.c: Update.
5767         * guile/scm-math.c: Update.
5768         * guile/scm-param.c: Update.
5769         * guile/scm-ports.c: Update.
5770         * guile/scm-pretty-print.c: Update.
5771         * guile/scm-symbol.c: Update.
5772         * guile/scm-symtab.c: Update.
5773         * guile/scm-type.c: Update.
5774         * guile/scm-value.c: Update.
5775         * i386-linux-tdep.c: Update.
5776         * i386-tdep.c: Update.
5777         * inf-loop.c: Update.
5778         * infcall.c: Update.
5779         * infcmd.c: Update.
5780         * infrun.c: Update.
5781         * jit.c: Update.
5782         * language.c: Update.
5783         * linespec.c: Update.
5784         * linux-fork.c: Update.
5785         * linux-nat.c: Update.
5786         * linux-tdep.c: Update.
5787         * linux-thread-db.c: Update.
5788         * main.c: Update.
5789         * mi/mi-cmd-break.c: Update.
5790         * mi/mi-cmd-stack.c: Update.
5791         * mi/mi-interp.c: Update.
5792         * mi/mi-main.c: Update.
5793         * objc-lang.c: Update.
5794         * p-valprint.c: Update.
5795         * parse.c: Update.
5796         * ppc-linux-tdep.c: Update.
5797         * printcmd.c: Update.
5798         * python/py-arch.c: Update.
5799         * python/py-breakpoint.c: Update.
5800         * python/py-cmd.c: Update.
5801         * python/py-finishbreakpoint.c: Update.
5802         * python/py-frame.c: Update.
5803         * python/py-framefilter.c: Update.
5804         * python/py-gdb-readline.c: Update.
5805         * python/py-inferior.c: Update.
5806         * python/py-infthread.c: Update.
5807         * python/py-lazy-string.c: Update.
5808         * python/py-linetable.c: Update.
5809         * python/py-objfile.c: Update.
5810         * python/py-param.c: Update.
5811         * python/py-prettyprint.c: Update.
5812         * python/py-progspace.c: Update.
5813         * python/py-record-btrace.c: Update.
5814         * python/py-record.c: Update.
5815         * python/py-symbol.c: Update.
5816         * python/py-type.c: Update.
5817         * python/py-unwind.c: Update.
5818         * python/py-utils.c: Update.
5819         * python/py-value.c: Update.
5820         * python/python.c: Update.
5821         * record-btrace.c: Update.
5822         * record-full.c: Update.
5823         * remote-fileio.c: Update.
5824         * remote.c: Update.
5825         * riscv-tdep.c: Update.
5826         * rs6000-aix-tdep.c: Update.
5827         * rs6000-tdep.c: Update.
5828         * rust-exp.y: Update.
5829         * rust-lang.c: Update.
5830         * s390-tdep.c: Update.
5831         * selftest-arch.c: Update.
5832         * solib-dsbt.c: Update.
5833         * solib-frv.c: Update.
5834         * solib-spu.c: Update.
5835         * solib-svr4.c: Update.
5836         * solib.c: Update.
5837         * sparc64-linux-tdep.c: Update.
5838         * stack.c: Update.
5839         * symfile-mem.c: Update.
5840         * symmisc.c: Update.
5841         * target.c: Update.
5842         * thread.c: Update.
5843         * top.c: Update.
5844         * tracefile-tfile.c: Update.
5845         * tui/tui.c: Update.
5846         * typeprint.c: Update.
5847         * unittests/cli-utils-selftests.c: Update.
5848         * unittests/parse-connection-spec-selftests.c: Update.
5849         * valops.c: Update.
5850         * valprint.c: Update.
5851         * value.c: Update.
5852         * varobj.c: Update.
5853         * windows-nat.c: Update.
5854         * x86-linux-nat.c: Update.
5855         * xml-support.c: Update.
5856
5857 2019-04-08  Tom Tromey  <tom@tromey.com>
5858
5859         * xml-support.c: Use C++ exception handling.
5860         * x86-linux-nat.c: Use C++ exception handling.
5861         * windows-nat.c: Use C++ exception handling.
5862         * varobj.c: Use C++ exception handling.
5863         * value.c: Use C++ exception handling.
5864         * valprint.c: Use C++ exception handling.
5865         * valops.c: Use C++ exception handling.
5866         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5867         handling.
5868         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5869         * typeprint.c: Use C++ exception handling.
5870         * tui/tui.c: Use C++ exception handling.
5871         * tracefile-tfile.c: Use C++ exception handling.
5872         * top.c: Use C++ exception handling.
5873         * thread.c: Use C++ exception handling.
5874         * target.c: Use C++ exception handling.
5875         * symmisc.c: Use C++ exception handling.
5876         * symfile-mem.c: Use C++ exception handling.
5877         * stack.c: Use C++ exception handling.
5878         * sparc64-linux-tdep.c: Use C++ exception handling.
5879         * solib.c: Use C++ exception handling.
5880         * solib-svr4.c: Use C++ exception handling.
5881         * solib-spu.c: Use C++ exception handling.
5882         * solib-frv.c: Use C++ exception handling.
5883         * solib-dsbt.c: Use C++ exception handling.
5884         * selftest-arch.c: Use C++ exception handling.
5885         * s390-tdep.c: Use C++ exception handling.
5886         * rust-lang.c: Use C++ exception handling.
5887         * rust-exp.y: Use C++ exception handling.
5888         * rs6000-tdep.c: Use C++ exception handling.
5889         * rs6000-aix-tdep.c: Use C++ exception handling.
5890         * riscv-tdep.c: Use C++ exception handling.
5891         * remote.c: Use C++ exception handling.
5892         * remote-fileio.c: Use C++ exception handling.
5893         * record-full.c: Use C++ exception handling.
5894         * record-btrace.c: Use C++ exception handling.
5895         * python/python.c: Use C++ exception handling.
5896         * python/py-value.c: Use C++ exception handling.
5897         * python/py-utils.c: Use C++ exception handling.
5898         * python/py-unwind.c: Use C++ exception handling.
5899         * python/py-type.c: Use C++ exception handling.
5900         * python/py-symbol.c: Use C++ exception handling.
5901         * python/py-record.c: Use C++ exception handling.
5902         * python/py-record-btrace.c: Use C++ exception handling.
5903         * python/py-progspace.c: Use C++ exception handling.
5904         * python/py-prettyprint.c: Use C++ exception handling.
5905         * python/py-param.c: Use C++ exception handling.
5906         * python/py-objfile.c: Use C++ exception handling.
5907         * python/py-linetable.c: Use C++ exception handling.
5908         * python/py-lazy-string.c: Use C++ exception handling.
5909         * python/py-infthread.c: Use C++ exception handling.
5910         * python/py-inferior.c: Use C++ exception handling.
5911         * python/py-gdb-readline.c: Use C++ exception handling.
5912         * python/py-framefilter.c: Use C++ exception handling.
5913         * python/py-frame.c: Use C++ exception handling.
5914         * python/py-finishbreakpoint.c: Use C++ exception handling.
5915         * python/py-cmd.c: Use C++ exception handling.
5916         * python/py-breakpoint.c: Use C++ exception handling.
5917         * python/py-arch.c: Use C++ exception handling.
5918         * printcmd.c: Use C++ exception handling.
5919         * ppc-linux-tdep.c: Use C++ exception handling.
5920         * parse.c: Use C++ exception handling.
5921         * p-valprint.c: Use C++ exception handling.
5922         * objc-lang.c: Use C++ exception handling.
5923         * mi/mi-main.c: Use C++ exception handling.
5924         * mi/mi-interp.c: Use C++ exception handling.
5925         * mi/mi-cmd-stack.c: Use C++ exception handling.
5926         * mi/mi-cmd-break.c: Use C++ exception handling.
5927         * main.c: Use C++ exception handling.
5928         * linux-thread-db.c: Use C++ exception handling.
5929         * linux-tdep.c: Use C++ exception handling.
5930         * linux-nat.c: Use C++ exception handling.
5931         * linux-fork.c: Use C++ exception handling.
5932         * linespec.c: Use C++ exception handling.
5933         * language.c: Use C++ exception handling.
5934         * jit.c: Use C++ exception handling.
5935         * infrun.c: Use C++ exception handling.
5936         * infcmd.c: Use C++ exception handling.
5937         * infcall.c: Use C++ exception handling.
5938         * inf-loop.c: Use C++ exception handling.
5939         * i386-tdep.c: Use C++ exception handling.
5940         * i386-linux-tdep.c: Use C++ exception handling.
5941         * guile/scm-value.c: Use C++ exception handling.
5942         * guile/scm-type.c: Use C++ exception handling.
5943         * guile/scm-symtab.c: Use C++ exception handling.
5944         * guile/scm-symbol.c: Use C++ exception handling.
5945         * guile/scm-pretty-print.c: Use C++ exception handling.
5946         * guile/scm-ports.c: Use C++ exception handling.
5947         * guile/scm-param.c: Use C++ exception handling.
5948         * guile/scm-math.c: Use C++ exception handling.
5949         * guile/scm-lazy-string.c: Use C++ exception handling.
5950         * guile/scm-frame.c: Use C++ exception handling.
5951         * guile/scm-disasm.c: Use C++ exception handling.
5952         * guile/scm-cmd.c: Use C++ exception handling.
5953         * guile/scm-breakpoint.c: Use C++ exception handling.
5954         * guile/scm-block.c: Use C++ exception handling.
5955         * guile/guile-internal.h: Use C++ exception handling.
5956         * gnu-v3-abi.c: Use C++ exception handling.
5957         * gdbtypes.c: Use C++ exception handling.
5958         * frame.c: Use C++ exception handling.
5959         * frame-unwind.c: Use C++ exception handling.
5960         * fbsd-tdep.c: Use C++ exception handling.
5961         * f-valprint.c: Use C++ exception handling.
5962         * exec.c: Use C++ exception handling.
5963         * event-top.c: Use C++ exception handling.
5964         * event-loop.c: Use C++ exception handling.
5965         * eval.c: Use C++ exception handling.
5966         * dwarf2read.c: Use C++ exception handling.
5967         * dwarf2loc.c: Use C++ exception handling.
5968         * dwarf2-frame.c: Use C++ exception handling.
5969         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5970         * dwarf-index-write.c: Use C++ exception handling.
5971         * dwarf-index-cache.c: Use C++ exception handling.
5972         * dtrace-probe.c: Use C++ exception handling.
5973         * disasm-selftests.c: Use C++ exception handling.
5974         * darwin-nat.c: Use C++ exception handling.
5975         * cp-valprint.c: Use C++ exception handling.
5976         * cp-support.c: Use C++ exception handling.
5977         * cp-abi.c: Use C++ exception handling.
5978         * corelow.c: Use C++ exception handling.
5979         * completer.c: Use C++ exception handling.
5980         * compile/compile-object-run.c: Use C++ exception handling.
5981         * compile/compile-object-load.c: Use C++ exception handling.
5982         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5983         * compile/compile-c-symbols.c: Use C++ exception handling.
5984         * common/selftest.c: Use C++ exception handling.
5985         * common/new-op.c: Use C++ exception handling.
5986         * cli/cli-script.c: Use C++ exception handling.
5987         * cli/cli-interp.c: Use C++ exception handling.
5988         * cli/cli-cmds.c: Use C++ exception handling.
5989         * c-varobj.c: Use C++ exception handling.
5990         * btrace.c: Use C++ exception handling.
5991         * breakpoint.c: Use C++ exception handling.
5992         * break-catch-throw.c: Use C++ exception handling.
5993         * arch-utils.c: Use C++ exception handling.
5994         * amd64-tdep.c: Use C++ exception handling.
5995         * ada-valprint.c: Use C++ exception handling.
5996         * ada-typeprint.c: Use C++ exception handling.
5997         * ada-lang.c: Use C++ exception handling.
5998         * aarch64-tdep.c: Use C++ exception handling.
5999
6000 2019-04-08  Tom Tromey  <tom@tromey.com>
6001
6002         * xml-support.c (gdb_xml_parser::parse): Update.
6003         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6004         * value.c (show_convenience): Update.
6005         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6006         (test_parse_flags_qcs): Update.
6007         * thread.c (thr_try_catch_cmd): Update.
6008         * target.c (target_translate_tls_address): Update.
6009         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6010         (info_frame_command_core, frame_apply_command_count): Update.
6011         * rust-exp.y (rust_lex_exception_test): Update.
6012         * riscv-tdep.c (riscv_print_one_register_info): Update.
6013         * remote.c (remote_target::enable_btrace): Update.
6014         * record-btrace.c (record_btrace_enable_warn): Update.
6015         * python/py-utils.c (gdbpy_convert_exception): Update.
6016         * printcmd.c (do_one_display, print_variable_and_value): Update.
6017         * mi/mi-main.c (mi_print_exception): Update.
6018         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6019         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6020         * linux-nat.c (linux_nat_target::attach): Update.
6021         * linux-fork.c (class scoped_switch_fork_info): Update.
6022         * infrun.c (displaced_step_prepare): Update.
6023         * infcall.c (call_function_by_hand_dummy): Update.
6024         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6025         * gnu-v3-abi.c (print_one_vtable): Update.
6026         * frame.c (get_prev_frame_always): Update.
6027         * f-valprint.c (info_common_command_for_block): Update.
6028         * exec.c (try_open_exec_file): Update.
6029         * exceptions.c (print_exception, exception_print)
6030         (exception_fprintf, exception_print_same): Update.
6031         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6032         * dwarf-index-cache.c (index_cache::store)
6033         (index_cache::lookup_gdb_index): Update.
6034         * darwin-nat.c (maybe_cache_shell): Update.
6035         * cp-valprint.c (cp_print_value_fields): Update.
6036         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6037         (gcc_cplus_symbol_address): Update.
6038         * compile/compile-c-symbols.c (gcc_convert_symbol)
6039         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6040         * common/selftest.c: Update.
6041         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6042         a std::string.
6043         (exception_try_scope_entry, exception_try_scope_exit): Don't
6044         declare.
6045         (struct exception_try_scope): Remove.
6046         (TRY): Don't use exception_try_scope.
6047         (struct gdb_exception): Add constructor, operator=.
6048         <what>: New method.
6049         (struct gdb_exception_RETURN_MASK_ALL)
6050         (struct gdb_exception_RETURN_MASK_ERROR)
6051         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6052         (struct gdb_quit_bad_alloc): Update.
6053         * common/common-exceptions.c (exception_none): Change
6054         initializer.
6055         (struct catcher) <state, exception>: Initialize inline.
6056         <prev>: Remove member.
6057         (current_catcher): Remove.
6058         (catchers): New global.
6059         (exceptions_state_mc_init): Simplify.
6060         (catcher_pop): Remove.
6061         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6062         (try_scope_depth, exception_try_scope_entry)
6063         (exception_try_scope_exit): Remove.
6064         (throw_exception_sjlj): Update.
6065         (exception_messages, exception_messages_size): Remove.
6066         (throw_it): Simplify.
6067         (gdb_exception_sliced_copy): Remove.
6068         (throw_exception_cxx): Update.
6069         * cli/cli-script.c (script_from_file): Update.
6070         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6071         Update.
6072         * ada-valprint.c (ada_val_print): Update.
6073         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6074         (create_excep_cond_exprs): Update.
6075
6076 2019-04-08  Tom Tromey  <tom@tromey.com>
6077
6078         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6079         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6080         (TRY, CATCH, END_CATCH): Remove some definitions.
6081         * common/common-exceptions.c: Don't use GDB_XCPT.
6082         (catcher_list_size): Remove.
6083         (throw_exception, throw_it): Simplify.
6084
6085 2019-04-05  Tom Tromey  <tom@tromey.com>
6086
6087         Revert the header-sorting patch.
6088         * ft32-tdep.c: Revert.
6089         * frv-tdep.c: Revert.
6090         * frv-linux-tdep.c: Revert.
6091         * frame.c: Revert.
6092         * frame-unwind.c: Revert.
6093         * frame-base.c: Revert.
6094         * fork-child.c: Revert.
6095         * findvar.c: Revert.
6096         * findcmd.c: Revert.
6097         * filesystem.c: Revert.
6098         * filename-seen-cache.h: Revert.
6099         * filename-seen-cache.c: Revert.
6100         * fbsd-tdep.c: Revert.
6101         * fbsd-nat.h: Revert.
6102         * fbsd-nat.c: Revert.
6103         * f-valprint.c: Revert.
6104         * f-typeprint.c: Revert.
6105         * f-lang.c: Revert.
6106         * extension.h: Revert.
6107         * extension.c: Revert.
6108         * extension-priv.h: Revert.
6109         * expprint.c: Revert.
6110         * exec.h: Revert.
6111         * exec.c: Revert.
6112         * exceptions.c: Revert.
6113         * event-top.c: Revert.
6114         * event-loop.c: Revert.
6115         * eval.c: Revert.
6116         * elfread.c: Revert.
6117         * dwarf2read.h: Revert.
6118         * dwarf2read.c: Revert.
6119         * dwarf2loc.c: Revert.
6120         * dwarf2expr.h: Revert.
6121         * dwarf2expr.c: Revert.
6122         * dwarf2-frame.c: Revert.
6123         * dwarf2-frame-tailcall.c: Revert.
6124         * dwarf-index-write.h: Revert.
6125         * dwarf-index-write.c: Revert.
6126         * dwarf-index-common.c: Revert.
6127         * dwarf-index-cache.h: Revert.
6128         * dwarf-index-cache.c: Revert.
6129         * dummy-frame.c: Revert.
6130         * dtrace-probe.c: Revert.
6131         * disasm.h: Revert.
6132         * disasm.c: Revert.
6133         * disasm-selftests.c: Revert.
6134         * dictionary.c: Revert.
6135         * dicos-tdep.c: Revert.
6136         * demangle.c: Revert.
6137         * dcache.h: Revert.
6138         * dcache.c: Revert.
6139         * darwin-nat.h: Revert.
6140         * darwin-nat.c: Revert.
6141         * darwin-nat-info.c: Revert.
6142         * d-valprint.c: Revert.
6143         * d-namespace.c: Revert.
6144         * d-lang.c: Revert.
6145         * ctf.c: Revert.
6146         * csky-tdep.c: Revert.
6147         * csky-linux-tdep.c: Revert.
6148         * cris-tdep.c: Revert.
6149         * cris-linux-tdep.c: Revert.
6150         * cp-valprint.c: Revert.
6151         * cp-support.c: Revert.
6152         * cp-namespace.c: Revert.
6153         * cp-abi.c: Revert.
6154         * corelow.c: Revert.
6155         * corefile.c: Revert.
6156         * continuations.c: Revert.
6157         * completer.h: Revert.
6158         * completer.c: Revert.
6159         * complaints.c: Revert.
6160         * coffread.c: Revert.
6161         * coff-pe-read.c: Revert.
6162         * cli-out.h: Revert.
6163         * cli-out.c: Revert.
6164         * charset.c: Revert.
6165         * c-varobj.c: Revert.
6166         * c-valprint.c: Revert.
6167         * c-typeprint.c: Revert.
6168         * c-lang.c: Revert.
6169         * buildsym.c: Revert.
6170         * buildsym-legacy.c: Revert.
6171         * build-id.h: Revert.
6172         * build-id.c: Revert.
6173         * btrace.c: Revert.
6174         * bsd-uthread.c: Revert.
6175         * breakpoint.h: Revert.
6176         * breakpoint.c: Revert.
6177         * break-catch-throw.c: Revert.
6178         * break-catch-syscall.c: Revert.
6179         * break-catch-sig.c: Revert.
6180         * blockframe.c: Revert.
6181         * block.c: Revert.
6182         * bfin-tdep.c: Revert.
6183         * bfin-linux-tdep.c: Revert.
6184         * bfd-target.c: Revert.
6185         * bcache.c: Revert.
6186         * ax-general.c: Revert.
6187         * ax-gdb.h: Revert.
6188         * ax-gdb.c: Revert.
6189         * avr-tdep.c: Revert.
6190         * auxv.c: Revert.
6191         * auto-load.c: Revert.
6192         * arm-wince-tdep.c: Revert.
6193         * arm-tdep.c: Revert.
6194         * arm-symbian-tdep.c: Revert.
6195         * arm-pikeos-tdep.c: Revert.
6196         * arm-obsd-tdep.c: Revert.
6197         * arm-nbsd-tdep.c: Revert.
6198         * arm-nbsd-nat.c: Revert.
6199         * arm-linux-tdep.c: Revert.
6200         * arm-linux-nat.c: Revert.
6201         * arm-fbsd-tdep.c: Revert.
6202         * arm-fbsd-nat.c: Revert.
6203         * arm-bsd-tdep.c: Revert.
6204         * arch-utils.c: Revert.
6205         * arc-tdep.c: Revert.
6206         * arc-newlib-tdep.c: Revert.
6207         * annotate.h: Revert.
6208         * annotate.c: Revert.
6209         * amd64-windows-tdep.c: Revert.
6210         * amd64-windows-nat.c: Revert.
6211         * amd64-tdep.c: Revert.
6212         * amd64-sol2-tdep.c: Revert.
6213         * amd64-obsd-tdep.c: Revert.
6214         * amd64-obsd-nat.c: Revert.
6215         * amd64-nbsd-tdep.c: Revert.
6216         * amd64-nbsd-nat.c: Revert.
6217         * amd64-nat.c: Revert.
6218         * amd64-linux-tdep.c: Revert.
6219         * amd64-linux-nat.c: Revert.
6220         * amd64-fbsd-tdep.c: Revert.
6221         * amd64-fbsd-nat.c: Revert.
6222         * amd64-dicos-tdep.c: Revert.
6223         * amd64-darwin-tdep.c: Revert.
6224         * amd64-bsd-nat.c: Revert.
6225         * alpha-tdep.c: Revert.
6226         * alpha-obsd-tdep.c: Revert.
6227         * alpha-nbsd-tdep.c: Revert.
6228         * alpha-mdebug-tdep.c: Revert.
6229         * alpha-linux-tdep.c: Revert.
6230         * alpha-linux-nat.c: Revert.
6231         * alpha-bsd-tdep.c: Revert.
6232         * alpha-bsd-nat.c: Revert.
6233         * aix-thread.c: Revert.
6234         * agent.c: Revert.
6235         * addrmap.c: Revert.
6236         * ada-varobj.c: Revert.
6237         * ada-valprint.c: Revert.
6238         * ada-typeprint.c: Revert.
6239         * ada-tasks.c: Revert.
6240         * ada-lang.c: Revert.
6241         * aarch64-tdep.c: Revert.
6242         * aarch64-ravenscar-thread.c: Revert.
6243         * aarch64-newlib-tdep.c: Revert.
6244         * aarch64-linux-tdep.c: Revert.
6245         * aarch64-linux-nat.c: Revert.
6246         * aarch64-fbsd-tdep.c: Revert.
6247         * aarch64-fbsd-nat.c: Revert.
6248         * aarch32-linux-nat.c: Revert.
6249
6250 2019-04-05  Tom Tromey  <tom@tromey.com>
6251
6252         * ft32-tdep.c: Sort headers.
6253         * frv-tdep.c: Sort headers.
6254         * frv-linux-tdep.c: Sort headers.
6255         * frame.c: Sort headers.
6256         * frame-unwind.c: Sort headers.
6257         * frame-base.c: Sort headers.
6258         * fork-child.c: Sort headers.
6259         * findvar.c: Sort headers.
6260         * findcmd.c: Sort headers.
6261         * filesystem.c: Sort headers.
6262         * filename-seen-cache.h: Sort headers.
6263         * filename-seen-cache.c: Sort headers.
6264         * fbsd-tdep.c: Sort headers.
6265         * fbsd-nat.h: Sort headers.
6266         * fbsd-nat.c: Sort headers.
6267         * f-valprint.c: Sort headers.
6268         * f-typeprint.c: Sort headers.
6269         * f-lang.c: Sort headers.
6270         * extension.h: Sort headers.
6271         * extension.c: Sort headers.
6272         * extension-priv.h: Sort headers.
6273         * expprint.c: Sort headers.
6274         * exec.h: Sort headers.
6275         * exec.c: Sort headers.
6276         * exceptions.c: Sort headers.
6277         * event-top.c: Sort headers.
6278         * event-loop.c: Sort headers.
6279         * eval.c: Sort headers.
6280         * elfread.c: Sort headers.
6281         * dwarf2read.h: Sort headers.
6282         * dwarf2read.c: Sort headers.
6283         * dwarf2loc.c: Sort headers.
6284         * dwarf2expr.h: Sort headers.
6285         * dwarf2expr.c: Sort headers.
6286         * dwarf2-frame.c: Sort headers.
6287         * dwarf2-frame-tailcall.c: Sort headers.
6288         * dwarf-index-write.h: Sort headers.
6289         * dwarf-index-write.c: Sort headers.
6290         * dwarf-index-common.c: Sort headers.
6291         * dwarf-index-cache.h: Sort headers.
6292         * dwarf-index-cache.c: Sort headers.
6293         * dummy-frame.c: Sort headers.
6294         * dtrace-probe.c: Sort headers.
6295         * disasm.h: Sort headers.
6296         * disasm.c: Sort headers.
6297         * disasm-selftests.c: Sort headers.
6298         * dictionary.c: Sort headers.
6299         * dicos-tdep.c: Sort headers.
6300         * demangle.c: Sort headers.
6301         * dcache.h: Sort headers.
6302         * dcache.c: Sort headers.
6303         * darwin-nat.h: Sort headers.
6304         * darwin-nat.c: Sort headers.
6305         * darwin-nat-info.c: Sort headers.
6306         * d-valprint.c: Sort headers.
6307         * d-namespace.c: Sort headers.
6308         * d-lang.c: Sort headers.
6309         * ctf.c: Sort headers.
6310         * csky-tdep.c: Sort headers.
6311         * csky-linux-tdep.c: Sort headers.
6312         * cris-tdep.c: Sort headers.
6313         * cris-linux-tdep.c: Sort headers.
6314         * cp-valprint.c: Sort headers.
6315         * cp-support.c: Sort headers.
6316         * cp-namespace.c: Sort headers.
6317         * cp-abi.c: Sort headers.
6318         * corelow.c: Sort headers.
6319         * corefile.c: Sort headers.
6320         * continuations.c: Sort headers.
6321         * completer.h: Sort headers.
6322         * completer.c: Sort headers.
6323         * complaints.c: Sort headers.
6324         * coffread.c: Sort headers.
6325         * coff-pe-read.c: Sort headers.
6326         * cli-out.h: Sort headers.
6327         * cli-out.c: Sort headers.
6328         * charset.c: Sort headers.
6329         * c-varobj.c: Sort headers.
6330         * c-valprint.c: Sort headers.
6331         * c-typeprint.c: Sort headers.
6332         * c-lang.c: Sort headers.
6333         * buildsym.c: Sort headers.
6334         * buildsym-legacy.c: Sort headers.
6335         * build-id.h: Sort headers.
6336         * build-id.c: Sort headers.
6337         * btrace.c: Sort headers.
6338         * bsd-uthread.c: Sort headers.
6339         * breakpoint.h: Sort headers.
6340         * breakpoint.c: Sort headers.
6341         * break-catch-throw.c: Sort headers.
6342         * break-catch-syscall.c: Sort headers.
6343         * break-catch-sig.c: Sort headers.
6344         * blockframe.c: Sort headers.
6345         * block.c: Sort headers.
6346         * bfin-tdep.c: Sort headers.
6347         * bfin-linux-tdep.c: Sort headers.
6348         * bfd-target.c: Sort headers.
6349         * bcache.c: Sort headers.
6350         * ax-general.c: Sort headers.
6351         * ax-gdb.h: Sort headers.
6352         * ax-gdb.c: Sort headers.
6353         * avr-tdep.c: Sort headers.
6354         * auxv.c: Sort headers.
6355         * auto-load.c: Sort headers.
6356         * arm-wince-tdep.c: Sort headers.
6357         * arm-tdep.c: Sort headers.
6358         * arm-symbian-tdep.c: Sort headers.
6359         * arm-pikeos-tdep.c: Sort headers.
6360         * arm-obsd-tdep.c: Sort headers.
6361         * arm-nbsd-tdep.c: Sort headers.
6362         * arm-nbsd-nat.c: Sort headers.
6363         * arm-linux-tdep.c: Sort headers.
6364         * arm-linux-nat.c: Sort headers.
6365         * arm-fbsd-tdep.c: Sort headers.
6366         * arm-fbsd-nat.c: Sort headers.
6367         * arm-bsd-tdep.c: Sort headers.
6368         * arch-utils.c: Sort headers.
6369         * arc-tdep.c: Sort headers.
6370         * arc-newlib-tdep.c: Sort headers.
6371         * annotate.h: Sort headers.
6372         * annotate.c: Sort headers.
6373         * amd64-windows-tdep.c: Sort headers.
6374         * amd64-windows-nat.c: Sort headers.
6375         * amd64-tdep.c: Sort headers.
6376         * amd64-sol2-tdep.c: Sort headers.
6377         * amd64-obsd-tdep.c: Sort headers.
6378         * amd64-obsd-nat.c: Sort headers.
6379         * amd64-nbsd-tdep.c: Sort headers.
6380         * amd64-nbsd-nat.c: Sort headers.
6381         * amd64-nat.c: Sort headers.
6382         * amd64-linux-tdep.c: Sort headers.
6383         * amd64-linux-nat.c: Sort headers.
6384         * amd64-fbsd-tdep.c: Sort headers.
6385         * amd64-fbsd-nat.c: Sort headers.
6386         * amd64-dicos-tdep.c: Sort headers.
6387         * amd64-darwin-tdep.c: Sort headers.
6388         * amd64-bsd-nat.c: Sort headers.
6389         * alpha-tdep.c: Sort headers.
6390         * alpha-obsd-tdep.c: Sort headers.
6391         * alpha-nbsd-tdep.c: Sort headers.
6392         * alpha-mdebug-tdep.c: Sort headers.
6393         * alpha-linux-tdep.c: Sort headers.
6394         * alpha-linux-nat.c: Sort headers.
6395         * alpha-bsd-tdep.c: Sort headers.
6396         * alpha-bsd-nat.c: Sort headers.
6397         * aix-thread.c: Sort headers.
6398         * agent.c: Sort headers.
6399         * addrmap.c: Sort headers.
6400         * ada-varobj.c: Sort headers.
6401         * ada-valprint.c: Sort headers.
6402         * ada-typeprint.c: Sort headers.
6403         * ada-tasks.c: Sort headers.
6404         * ada-lang.c: Sort headers.
6405         * aarch64-tdep.c: Sort headers.
6406         * aarch64-ravenscar-thread.c: Sort headers.
6407         * aarch64-newlib-tdep.c: Sort headers.
6408         * aarch64-linux-tdep.c: Sort headers.
6409         * aarch64-linux-nat.c: Sort headers.
6410         * aarch64-fbsd-tdep.c: Sort headers.
6411         * aarch64-fbsd-nat.c: Sort headers.
6412         * aarch32-linux-nat.c: Sort headers.
6413
6414 2019-04-04  Tom Tromey  <tom@tromey.com>
6415
6416         * varobj.c (varobj_create): Update.
6417         * rust-exp.y (struct rust_parser) <update_innermost_block,
6418         lookup_symbol>: New methods.
6419         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6420         Rename.
6421         (rust_parser::rust_lookup_type)
6422         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6423         * printcmd.c (display_command, do_one_display): Update.
6424         * parser-defs.h (struct parser_state) <parser_state>: Add
6425         "tracker" parameter.
6426         (block_tracker): New member.
6427         (class innermost_block_tracker) <innermost_block_tracker>: Add
6428         "types" parameter.
6429         <reset>: Remove method.
6430         (innermost_block): Don't declare.
6431         (null_post_parser): Update.
6432         * parse.c (innermost_block): Remove global.
6433         (write_dollar_variable): Update.
6434         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6435         Remove "tracker_types" parameter.
6436         (parse_expression): Add "tracker" parameter.
6437         (parse_expression_for_completion): Update.
6438         (null_post_parser): Add "tracker" parameter.
6439         * p-exp.y: Update rules.
6440         * m2-exp.y: Update rules.
6441         * language.h (struct language_defn) <la_post_parser>: Add
6442         "tracker" parameter.
6443         * go-exp.y: Update rules.
6444         * f-exp.y: Update rules.
6445         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6446         parameter.
6447         * d-exp.y: Update rules.
6448         * c-exp.y: Update rules.
6449         * breakpoint.c (set_breakpoint_condition): Create an
6450         innermost_block_tracker.
6451         (watch_command_1): Likewise.
6452         * ada-lang.c (resolve): Add "tracker" parameter.
6453         (resolve_subexp): Likewise.
6454         * ada-exp.y (write_var_from_sym): Update.
6455
6456 2019-04-04  Tom Tromey  <tom@tromey.com>
6457
6458         * type-stack.h: New file.
6459         * type-stack.c: New file.
6460         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6461         type-stack.h.
6462         (insert_into_type_stack, insert_type, push_type, push_type_int)
6463         (insert_type_address_space, pop_type, pop_type_int)
6464         (pop_typelist, pop_type_stack, append_type_stack)
6465         (push_type_stack, get_type_stack, push_typelist)
6466         (follow_type_instance_flags, follow_types): Don't declare.
6467         * parse.c (type_stack): Remove global.
6468         (parse_exp_in_context): Update.
6469         (insert_into_type_stack, insert_type, push_type, push_type_int)
6470         (insert_type_address_space, pop_type, pop_type_int)
6471         (pop_typelist, pop_type_stack, append_type_stack)
6472         (push_type_stack, get_type_stack, push_typelist)
6473         (follow_type_instance_flags, follow_types): Remove (moved to
6474         type-stack.c).
6475         * f-exp.y (type_stack): New global.
6476         Update rules.
6477         (push_kind_type, f_parse): Update.
6478         * d-exp.y (type_stack): New global.
6479         Update rules.
6480         (d_parse): Update.
6481         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6482         Update rules.
6483         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6484         (HFILES_NO_SRCDIR): Add type-stack.h.
6485
6486 2019-04-04  Tom Tromey  <tom@tromey.com>
6487
6488         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6489         (rust_parser::convert_ast_to_expression, rust_parse)
6490         (rust_lex_test_completion, rust_lex_tests): Update.
6491         * parser-defs.h (struct expr_completion_state): New.
6492         (struct parser_state) <parser_state>: Add completion parameter.
6493         <mark_struct_expression, mark_completion_tag>: New methods.
6494         <parse_completion, m_completion_state>: New members.
6495         (prefixify_expression, null_post_parser): Update.
6496         (mark_struct_expression, mark_completion_tag): Don't declare.
6497         * parse.c (parse_completion, expout_last_struct)
6498         (expout_tag_completion_type, expout_completion_name): Remove
6499         globals.
6500         (parser_state::mark_struct_expression)
6501         (parser_state::mark_completion_tag): Now methods.
6502         (prefixify_expression): Add last_struct parameter.
6503         (prefixify_subexp): Likewise.
6504         (parse_exp_1): Update.
6505         (parse_exp_in_context): Add cstate parameter.  Update.
6506         (parse_expression_for_completion): Create an
6507         expr_completion_state.
6508         (null_post_parser): Add "completion" parameter.
6509         * p-exp.y: Update rules.
6510         (yylex): Update.
6511         * language.h (struct language_defn) <la_post_parser>: Add
6512         "completing" parameter.
6513         * go-exp.y: Update rules.
6514         (lex_one_token): Update.
6515         * expression.h (parse_completion): Don't declare.
6516         * d-exp.y: Update rules.
6517         (lex_one_token): Update rules.
6518         * c-exp.y: Update rules.
6519         (lex_one_token): Update.
6520         * ada-lang.c (resolve): Add "parse_completion" parameter.
6521         (resolve_subexp): Likewise.
6522         (ada_resolve_function): Likewise.
6523
6524 2019-04-04  Tom Tromey  <tom@tromey.com>
6525
6526         * parser-defs.h (struct parser_state) <start_arglist,
6527         end_arglist>: New methods.
6528         <arglist_len, m_funcall_chain>: New members.
6529         (arglist_len, start_arglist, end_arglist): Don't declare.
6530         * parse.c (arglist_len, funcall_chain): Remove global.
6531         (start_arglist, end_arglist): Remove functions.
6532         (parse_exp_in_context): Update.
6533         * p-exp.y: Update rules.
6534         * m2-exp.y: Update rules.
6535         * go-exp.y: Update rules.
6536         * f-exp.y: Update rules.
6537         * d-exp.y: Update rules.
6538         * c-exp.y: Update rules.
6539
6540 2019-04-04  Tom Tromey  <tom@tromey.com>
6541
6542         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6543         lex_operator, push_back>: New methods.
6544         Update all rules.
6545         (rust_parser::lex_hex, lex_escape): Rename and update.
6546         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6547         (rust_parser::lex_operator): Rename and update.
6548         (rust_parser::lex_number, rustyylex, rustyyerror)
6549         (rust_lex_test_init, rust_lex_test_sequence)
6550         (rust_lex_test_push_back, rust_lex_tests): Update.
6551         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6552         parameter.
6553         <lexptr, prev_lexptr>: New members.
6554         (lexptr, prev_lexptr): Don't declare.
6555         * parse.c (lexptr, prev_lexptr): Remove globals.
6556         (parse_exp_in_context): Update.
6557         * p-exp.y (yylex, yyerror): Update.
6558         * m2-exp.y (parse_number, yylex, yyerror): Update.
6559         * go-exp.y (lex_one_token, yyerror): Update.
6560         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6561         * d-exp.y (lex_one_token, yyerror): Update.
6562         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6563         (lex_one_token, yyerror): Update.
6564         * ada-lex.l (YY_INPUT): Update.
6565         (rewind_to_char): Update.
6566         * ada-exp.y (yyerror): Update.
6567
6568 2019-04-04  Tom Tromey  <tom@tromey.com>
6569
6570         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6571         * parser-defs.h (struct parser_state) <parser_state>: Add new
6572         parameter.
6573         <comma_terminates>: New member.
6574         (comma_terminates): Don't declare global.
6575         * parse.c (comma_terminates): Remove global.
6576         (parse_exp_in_context): Update.
6577         * p-exp.y (yylex): Update.
6578         * m2-exp.y (yylex): Update.
6579         * go-exp.y (lex_one_token): Update.
6580         * f-exp.y (yylex): Update.
6581         * d-exp.y (lex_one_token): Update.
6582         * c-exp.y (lex_one_token): Update.
6583         * ada-lex.l: Update.
6584
6585 2019-04-04  Tom Tromey  <tom@tromey.com>
6586
6587         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6588         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6589         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6590         * parser-defs.h (paren_depth): Don't declare.
6591         * parse.c (paren_depth): Remove global.
6592         (parse_exp_in_context): Update.
6593         * p-exp.y (paren_depth): New global.
6594         (pascal_parse): Initialize it.
6595         * m2-exp.y (paren_depth): New global.
6596         (m2_parse): Initialize it.
6597         * go-exp.y (paren_depth): New global.
6598         (go_parse): Initialize it.
6599         * f-exp.y (paren_depth): New global.
6600         (f_parse): Initialize it.
6601         * d-exp.y (paren_depth): New global.
6602         (d_parse): Initialize it.
6603         * c-exp.y (paren_depth): New global.
6604         (c_parse): Initialize it.
6605         * ada-lex.l (paren_depth): New global.
6606         (lexer_init): Initialize it.
6607
6608 2019-04-04  Tom Tromey  <tom@tromey.com>
6609
6610         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6611         (rust_parser::convert_ast_to_type)
6612         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6613         * parser-defs.h (struct parser_state) <parser_state>: Add
6614         parameters.  Initialize new members.
6615         <expression_context_block, expression_context_pc>: New members.
6616         * parse.c (expression_context_block, expression_context_pc):
6617         Remove globals.
6618         (parse_exp_in_context): Update.
6619         * p-exp.y: Update all rules.
6620         (yylex): Update.
6621         * m2-exp.y: Update all rules.
6622         (yylex): Update.
6623         * go-exp.y (yylex): Update.
6624         * f-exp.y (yylex): Update.
6625         * d-exp.y: Update all rules.
6626         (yylex): Update.
6627         * c-exp.y: Update all rules.
6628         (lex_one_token, classify_name, yylex, c_parse): Update.
6629         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6630
6631 2019-04-04  Tom Tromey  <tom@tromey.com>
6632
6633         * gdbarch.h, gdbarch.c: Rebuild.
6634         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6635         * stap-probe.h:
6636         (struct stap_parse_info): Replace "parser_state" with
6637         "expr_builder".
6638         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6639         (parser_state): New class.
6640         * parse.c (expr_builder): Rename.
6641         (expr_builder::release): Rename.
6642         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6643         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6644         (write_exp_elt_longcst, write_exp_elt_floatcst)
6645         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6646         (write_exp_string_vector, write_exp_bitstring)
6647         (write_exp_msymbol, mark_struct_expression)
6648         (write_dollar_variable)
6649         (insert_type_address_space, increase_expout_size): Replace
6650         "parser_state" with "expr_builder".
6651         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6652         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6653         "parser_state" with "expr_builder".
6654
6655 2019-04-04  Tom Tromey  <tom@tromey.com>
6656
6657         * rust-exp.y: Replace "parse_language" with method call.
6658         * p-exp.y:
6659         (yylex): Replace "parse_language" with method call.
6660         * m2-exp.y:
6661         (yylex): Replace "parse_language" with method call.
6662         * go-exp.y (classify_name): Replace "parse_language" with method
6663         call.
6664         * f-exp.y (yylex): Replace "parse_language" with method call.
6665         * d-exp.y (lex_one_token): Replace "parse_language" with method
6666         call.
6667         * c-exp.y:
6668         (lex_one_token, classify_name, yylex): Replace "parse_language"
6669         with method call.
6670         * ada-exp.y (find_primitive_type, type_char)
6671         (type_system_address): Replace "parse_language" with method call.
6672
6673 2019-04-04  Tom Tromey  <tom@tromey.com>
6674
6675         * rust-exp.y: Replace "parse_gdbarch" with method call.
6676         * parse.c (write_dollar_variable, insert_type_address_space):
6677         Replace "parse_gdbarch" with method call.
6678         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6679         call.
6680         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6681         call.
6682         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6683         "parse_gdbarch" with method call.
6684         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6685         with method call.
6686         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6687         "parse_gdbarch" with method call.
6688         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6689         "parse_gdbarch" with method call.
6690         * c-exp.y (parse_type, parse_number, classify_name): Replace
6691         "parse_gdbarch" with method call.
6692         * ada-lex.l: Replace "parse_gdbarch" with method call.
6693         * ada-exp.y (parse_type, find_primitive_type, type_char)
6694         (type_system_address): Replace "parse_gdbarch" with method call.
6695
6696 2019-04-04  Tom Tromey  <tom@tromey.com>
6697
6698         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6699         * stap-probe.c (stap_parse_argument): Update.
6700         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6701         initial_size parameter.
6702         * rust-exp.y (rust_lex_tests): Update.
6703         * parse.c (parser_state): Update.
6704         (parse_exp_in_context): Update.
6705         * parser-defs.h (struct parser_state) <parser_state>: Remove
6706         "initial_size" parameter.
6707
6708 2019-04-04  Tom Tromey  <tom@tromey.com>
6709
6710         * parser-defs.h (increase_expout_size): Don't declare.
6711         * parse.c (increase_expout_size): Now static.
6712
6713 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6714
6715         * gnu-nat.c (gnu_nat_target::wait): Fix
6716         target_waitstatus_to_string call.
6717
6718 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6719
6720         * eval.c (evaluate_subexp_standard): Handle internal functions
6721         during Fortran function call handling.
6722
6723 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6724
6725         * NEWS: Mention new internal functions.
6726         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6727         (read_base_type): Use dwarf2_init_complex_target_type.
6728         * value.c (creal_internal_fn): New function.
6729         (cimag_internal_fn): New function.
6730         (_initialize_values): Register new internal functions.
6731
6732 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6733
6734         * infrun.c (stop_all_threads): If debug_infrun, always
6735         trace the wait status after wait_one, using
6736         target_waitstatus_to_string and target_pid_to_str.
6737         (handle_inferior_event): Replace various trace of
6738         wait status kind by a single trace.
6739         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6740         wait status kind image by target_waitstatus_to_string.
6741         * target/waitstatus.c (target_waitstatus_to_string): Fix
6742         obsolete comment.
6743
6744 2019-04-01  Tom Tromey  <tromey@adacore.com>
6745
6746         PR symtab/23331:
6747         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6748
6749 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6750             Pedro Alves  <palves@redhat.com>
6751
6752         * top.c (quit_force): Call 'finalize_values'.
6753         * value.c (finalize_values): New function.
6754         * value.h (finalize_values): Declare.
6755
6756 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6757
6758         * NEWS: Announce $_gdb_major and $_gdb_minor.
6759
6760         * top.c (init_gdb_version_vars): New function.
6761         (gdb_init): Call init_gdb_version_vars.
6762
6763 2019-03-29  Tom Tromey  <tromey@adacore.com>
6764
6765         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6766         help text.  Remove dead code.
6767
6768 2019-03-29  Keith Seitz  <keiths@redhat.com>
6769
6770         From Siddhesh Poyarekar:
6771         * f-lang.h (f77_get_upperbound): Return LONGEST.
6772         (f77_get_lowerbound): Likewise.
6773         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6774         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6775         print them.
6776         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6777         plongest to format print it.
6778         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6779         (f77_get_upperbound): Likewise.
6780         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6781         LOWER_BOUND to LONGEST.
6782         (f77_create_arrayprint_offset_tbl): Likewise.
6783
6784 2019-03-29  Keith Seitz  <keiths@redhat.com>
6785
6786         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6787         %s/pulongest for TYPE_LENGTH instead of %d in format
6788         strings.
6789         * ada-typerint.c (ada_print_type): Likewise.
6790         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6791         * compile/compile-c-support.c (generate_register_struct): Likewise.
6792         * gdbtypes.c (recursive_dump_type): Likewise.
6793         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6794         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6795         instead of %d in format strings.
6796         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6797         to std::min to ULONGEST.
6798         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6799         instead of %d in format strings.
6800         * tracepoint.c (info_scope_command): Likewise.
6801         * typeprint.c (print_offset_data::update)
6802         (print_offset_data::finish): Likewise.
6803         * xtensa-tdep.c (xtensa_store_return_value)
6804         (xtensa_push_dummy_call): Likewise.
6805
6806 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6807
6808         * windows-nat.c (display_selector): Fixed format specifications
6809         for 64-bit Cygwin.
6810
6811 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6812
6813         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6814
6815 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6816
6817         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6818         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6819         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6820         (nios2_linux_init_abi): Install it.
6821
6822 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6823
6824         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6825
6826 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6827
6828         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6829
6830 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6831             Tom Tromey  <tromey@adacore.com>
6832
6833         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6834
6835 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6836
6837         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6838         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6839         method to compute the bounds of range types. Also print "[evaluated]"
6840         if the bounds' values come from a dynamic evaluation.
6841
6842 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6843
6844         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6845         whitespace when pretty printing is on.
6846
6847 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6848
6849         * ppc-linux-nat.c: Add include.
6850
6851 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6852
6853         * NEWS: Mention AArch64 Pointer Authentication.
6854
6855 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6856
6857         * arm-linux-nat.c: Add include.
6858
6859 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6860
6861         * source-cache.c (source_cache::get_source_lines): Re-read
6862         fullname after calling open_source_file.
6863
6864 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6865
6866         * NEWS: Mention TLS support for FreeBSD.
6867
6868 2019-03-25  Tom Tromey  <tromey@adacore.com>
6869
6870         * minsyms.c (BUNCH_SIZE): Update comment.
6871         (~minimal_symbol_reader): Remove old comment.
6872         (compact_minimal_symbols): Update comment.
6873         (minimal_symbol_reader::install): Remove old comment.  Update
6874         other comments.
6875
6876 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6877
6878         * s390-linux-nat.c: Add include.
6879
6880 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6881
6882         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6883         Call linux_get_hwcap.
6884         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6885         Likewise.
6886         (aarch64_linux_get_hwcap): Remove function.
6887         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6888         declaration.
6889         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6890         linux_get_hwcap.
6891         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6892         * linux-tdep.c (linux_get_hwcap): Add function.
6893         (linux_get_hwcap2): Likewise.
6894         * linux-tdep.h (linux_get_hwcap): Add declaration.
6895         (linux_get_hwcap2): Likewise.
6896         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6897         (ppc_linux_get_hwcap2): Likewise.
6898         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6899         linux_get_hwcap.
6900         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6901         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6902         (ppc_linux_nat_target::read_description): Likewise.
6903         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6904         * s390-linux-nat.c: Likewise.
6905         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6906
6907 2019-03-24  Tom Tromey  <tom@tromey.com>
6908
6909         * ada-lang.c (standard_lookup): Simplify initialization.
6910         (ada_lookup_symbol_nonlocal): Simplify return.
6911         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6912         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6913         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6914         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6915         initialization.
6916         * solib.c (solib_global_lookup): Simplify.
6917         * symtab.c (null_block_symbol): Remove.
6918         (symbol_cache_lookup): Simplify returns.
6919         (lookup_language_this): Simplify returns.
6920         (lookup_symbol_aux): Simplify return.
6921         (lookup_local_symbol): Simplify returns.
6922         (lookup_global_symbol_from_objfile): Simplify return.
6923         (lookup_symbol_in_objfile_symtabs)
6924         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6925         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6926         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6927         * cp-namespace.c (cp_lookup_bare_symbol)
6928         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6929         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6930         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6931         (cp_lookup_symbol_via_imports): Simplify initialization.
6932         (find_symbol_in_baseclass): Likewise.
6933         * symtab.h (null_block_symbol): Remove.
6934         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6935         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6936         (d_lookup_symbol_module): Likewise.
6937         (find_symbol_in_baseclass): Simplify initialization.
6938
6939 2019-03-24  Tom Tromey  <tom@tromey.com>
6940
6941         * expression.h: Don't include symtab.h.
6942         (struct block): Forward declare.
6943
6944 2019-03-24  Tom Tromey  <tom@tromey.com>
6945
6946         * c-exp.y (typebase): Remove casts.
6947         * gdbtypes.c (lookup_unsigned_typename, )
6948         (lookup_signed_typename): Remove cast.
6949         * eval.c (parse_to_comma_and_eval): Remove cast.
6950         * parse.c (write_dollar_variable): Remove cast.
6951         * block.h (struct block) <superblock>: Now const.
6952         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6953         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6954         (map_block): Make "block" const.
6955         * symfile.h (struct quick_symbol_functions)
6956         <map_matching_symbols>: Constify block argument to "callback".
6957         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6958         const.
6959         (find_pc_sect_compunit_symtab): Make "b" const.
6960         (find_symbol_at_address): Likewise.
6961         (search_symbols): Likewise.
6962         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6963         (dw2_debug_names_lookup_symbol): Likewise.
6964         (dw2_map_matching_symbols): Update.
6965         * p-valprint.c (pascal_val_print): Remove "block".
6966         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6967         (aux_add_nonlocal_symbols): Make "block" const.
6968         (resolve_subexp): Remove cast.
6969         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6970         const.
6971         (iterate_over_file_blocks): Likewise.
6972         * f-exp.y (%union) <bval>: Remove.
6973         * coffread.c (patch_opaque_types): Make "b" const.
6974         * spu-tdep.c (spu_catch_start): Make "block" const.
6975         * c-valprint.c (print_unpacked_pointer): Remove "block".
6976         * symmisc.c (dump_symtab_1): Make "b" const.
6977         (block_depth): Make "block" const.
6978         * d-exp.y (%union) <bval>: Remove.
6979         * cp-support.h (cp_lookup_rtti_type): Update.
6980         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6981         * psymtab.c (psym_lookup_symbol): Make "block" const.
6982         (maintenance_check_psymtabs): Make "b" const.
6983         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6984         (enumerate_locals, enumerate_args): Update.
6985         * python/py-symtab.c (stpy_global_block): Make "block" const.
6986         (stpy_static_block): Likewise.
6987         * inline-frame.c (block_starting_point_at): Make "new_block"
6988         const.
6989         * block.c (find_block_in_blockvector): Make return type const.
6990         (blockvector_for_pc_sect): Make "b" const.
6991         (find_block_in_blockvector): Make "b" const.
6992
6993 2019-03-23  Tom Tromey  <tom@tromey.com>
6994
6995         * varobj.c (varobj_create): Update.
6996         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6997         * printcmd.c (display_command, do_one_display): Don't reset
6998         innermost_block.
6999         * parser-defs.h (enum innermost_block_tracker_type): Move to
7000         expression.h.
7001         (innermost_block): Update comment.
7002         * parse.c (parse_exp_1): Add tracker_types parameter.
7003         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7004         tracker_types parameter.  Reset innermost_block.
7005         (parse_exp_in_context): Remove.
7006         (parse_expression_for_completion): Update.
7007         * objfiles.c (~objfile): Don't reset expression_context_block or
7008         innermost_block.
7009         * expression.h (enum innermost_block_tracker_type): Move from
7010         parser-defs.h.
7011         (parse_exp_1): Add tracker_types parameter.
7012         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7013         reset innermost_block.
7014
7015 2019-03-23  Tom Tromey  <tom@tromey.com>
7016
7017         * objfiles.h: Include bcache.h.
7018
7019 2019-03-23  Tom Tromey  <tom@tromey.com>
7020
7021         * linespec.c (get_current_search_block): Use
7022         scoped_restore_current_language.
7023         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7024
7025 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7026             Jiong Wang  <jiong.wang@arm.com>
7027
7028         * aarch64-linux-tdep.c
7029         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7030         section.
7031         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7032
7033 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7034             Jiong Wang  <jiong.wang@arm.com>
7035
7036         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7037         instructions.
7038         (aarch64_analyze_prologue_test): Add PACIASP test.
7039         (aarch64_prologue_prev_register): Unmask PC value.
7040
7041 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7042             Jiong Wang  <jiong.wang@arm.com>
7043
7044         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7045         (aarch64_dwarf2_prev_register): Unmask PC value.
7046         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7047         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7048         DW_CFA_AARCH64_negate_ra_state.
7049         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7050
7051 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7052             Jiong Wang  <jiong.wang@arm.com>
7053
7054         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7055         registers.
7056         (aarch64_pseudo_register_name): Likewise.
7057         (aarch64_pseudo_register_type): Likewise.
7058         (aarch64_pseudo_register_reggroup_p): Likewise.
7059         (aarch64_gdbarch_init): Add pauth registers.
7060         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7061         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7062         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7063         (struct gdbarch_tdep): Add regnum for ra_state.
7064
7065 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7066             Jiong Wang  <jiong.wang@arm.com>
7067
7068         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7069
7070 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7071             Jiong Wang  <jiong.wang@arm.com>
7072
7073         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7074         function.
7075         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7076         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7077         (aarch64_gdbarch_init): Add puth registers.
7078         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7079         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7080         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7081
7082 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7083             Jiong Wang  <jiong.wang@arm.com>
7084
7085         * aarch64-linux-nat.c
7086         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7087         * aarch64-linux-tdep.c
7088         (aarch64_linux_core_read_description): Likewise.
7089         (aarch64_linux_get_hwcap): New function.
7090         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7091         (aarch64_linux_get_hwcap): New declaration.
7092
7093 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7094             Jiong Wang  <jiong.wang@arm.com>
7095
7096         * aarch64-linux-nat.c
7097         (aarch64_linux_nat_target::read_description): Add pauth param.
7098         * aarch64-linux-tdep.c
7099         (aarch64_linux_core_read_description): Likewise.
7100         * aarch64-tdep.c (struct target_desc): Add in pauth.
7101         (aarch64_read_description): Add pauth param.
7102         (aarch64_gdbarch_init): Likewise.
7103         * aarch64-tdep.h (aarch64_read_description): Likewise.
7104         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7105         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7106         * features/Makefile: Add new files.
7107         * features/aarch64-pauth.c: New file.
7108         * features/aarch64-pauth.xml: New file.
7109
7110 2019-03-20  Tom Tromey  <tromey@adacore.com>
7111
7112         * infrun.c (handle_inferior_event): Rename from
7113         handle_inferior_event_1.  Create a scoped_value_mark.
7114         (handle_inferior_event): Remove.
7115
7116 2019-03-19  Tom Tromey  <tromey@adacore.com>
7117
7118         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7119         * infrun.h (print_stop_event): Add "displays" parameter.
7120         * infrun.c (print_stop_event): Add "displays" parameter.
7121
7122 2019-03-19  Pedro Alves  <palves@redhat.com>
7123
7124         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7125         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7126         to -1.  Fix TABs vs spaces.
7127         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7128         * tui/tui-out.h (tui_ui_out) Add intro comments.
7129         <m_line, m_start_of_line>: In-class initialize, and add describing
7130         comment.
7131
7132 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7133
7134         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7135         variable names.
7136         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7137
7138 2019-03-18  Pedro Alves  <palves@redhat.com>
7139             Eli Zaretskii <eliz@gnu.org>
7140
7141         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7142         m_line and m_start_of_line.
7143
7144 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7145
7146         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7147         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7148         it returns a newline.  This fixes a regression in TU mode, whereby
7149         the next line is output on the same screen line as the user input.
7150
7151 2019-03-18  Tom Tromey  <tromey@adacore.com>
7152
7153         * minsyms.c (minimal_symbol_reader::install): Remove call to
7154         obstack_blank.
7155
7156 2019-03-18  Pedro Alves  <palves@redhat.com>
7157
7158         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7159         New globals.
7160         (apply_style): New, factored out from ...
7161         (apply_ansi_escape): ... this.  Handle reverse video mode.
7162         (tui_set_reverse_mode): New function.
7163         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7164         * tui/tui-winsource.c (tui_show_source_line): Use
7165         tui_set_reverse_mode instead of setting A_STANDOUT.
7166         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7167         New setter methods.
7168
7169 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7170
7171         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7172         Handle tabs.
7173
7174 2019-03-18  Tom Tromey  <tromey@adacore.com>
7175
7176         * ada-lang.c (empty_array): Add "high" parameter.
7177         (ada_evaluate_subexp): Update.
7178
7179 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7180
7181         * unittests/string_view-selftests.c: Define
7182         _initialize_string_view_selftests unconditionally.
7183
7184 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7185
7186         PR gdb/24350
7187         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7188
7189 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7190
7191         PR gdb/24351
7192         * windows-nat.c (display_selector): Fix format specifiers.
7193
7194 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7195
7196         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7197         tui_refill_source_window instead of tui_refresh_win, to update the
7198         current execution line.  This fixes redisplay of the current line
7199         when stepping through the code with "next" or "step".
7200
7201 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7202
7203         * source-cache.c (source_cache::get_source_lines): Call
7204         find_source_lines to initialize s->nlines.  This fixes vertical
7205         scrolling of TUI source window when the DOWN arrow is pressed.
7206
7207 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7208
7209         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7210         linux-thread-db.c (_initialize_thread_db): Likewise.
7211
7212 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7213
7214         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7215         wclrtoeol in tui_show_source_line".  This reverts changes made in
7216         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7217
7218 2019-03-15  Tom Tromey  <tom@tromey.com>
7219
7220         * symtab.h (struct minimal_symbol): Derive from
7221         general_symbol_info.
7222         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7223         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7224         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7225         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7226         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7227         (MSYMBOL_SEARCH_NAME): Update.
7228         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7229         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7230         * minsyms.c (minimal_symbol_reader::record_full): Update.
7231
7232 2019-03-15  Tom Tromey  <tom@tromey.com>
7233
7234         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7235
7236 2019-03-15  Tom Tromey  <tom@tromey.com>
7237
7238         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7239         unique_xmalloc_ptr.
7240         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7241         Update.
7242         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7243         (build_minimal_symbol_hash_tables)
7244         (minimal_symbol_reader::install): Update.
7245
7246 2019-03-15  Tom Tromey  <tom@tromey.com>
7247
7248         * symtab.c (create_demangled_names_hash): Update.
7249         (symbol_set_names): Update.
7250         * objfiles.h (struct objfile_per_bfd_storage)
7251         <demangled_names_hash>: Now an htab_up.
7252         * objfiles.c (objfile_per_bfd_storage): Simplify.
7253
7254 2019-03-15  Tom Tromey  <tom@tromey.com>
7255
7256         * objfiles.h (struct objfile_per_bfd_storage): Declare
7257         destructor.
7258         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7259         New.
7260         (get_objfile_bfd_data): Use new.  Don't initialize
7261         language_of_main.
7262         (free_objfile_per_bfd_storage): Remove.
7263         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7264
7265 2019-03-15  Tom Tromey  <tom@tromey.com>
7266
7267         * symfile.c (reread_symbols): Update.
7268         * objfiles.c (objfile::objfile): Update.
7269         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7270         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7271         comment.
7272         (minimal_symbol_reader::install): Update.
7273         (terminate_minimal_symbol_table): Remove.
7274         * jit.c (jit_object_close_impl): Update.
7275
7276 2019-03-15  Tom Tromey  <tom@tromey.com>
7277
7278         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7279         initializations.
7280
7281 2019-03-15  Tom Tromey  <tom@tromey.com>
7282
7283         * objfiles.h (struct objfile_per_bfd_storage)
7284         <demangled_hash_languages>: Now a bitset.
7285         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7286         (lookup_minimal_symbol): Update.
7287
7288 2019-03-15  Tom Tromey  <tom@tromey.com>
7289
7290         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7291         Don't return the symbol.
7292         * coffread.c (record_minimal_symbol): Use record_full.
7293
7294 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7295
7296         The MS-Windows port of ncurses fails to switch to a color pair if
7297         one or both of the colors are the implicit default colors.  This
7298         change records the default colors when TUI is initialized, and
7299         then specifies them explicitly when a color pair uses the default
7300         colors.  This allows color styling in TUI mode on MS-Windows.
7301
7302         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7303         ncurses_norm_attr.
7304         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7305         colors in ncurses_norm_attr.
7306         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7307         "none", replace it with the default color recorded in
7308         ncurses_norm_attr.
7309
7310 2019-03-14  Tom Tromey  <tromey@adacore.com>
7311
7312         * source-cache.h (class source_cache) <get_source_lines>: Return
7313         std::string.
7314         * source-cache.c (source_cache::extract_lines): Handle case where
7315         first_pos==npos.  Return std::string.
7316         (source_cache::get_source_lines): Update.
7317
7318 2019-03-14  Tom Tromey  <tromey@adacore.com>
7319
7320         * NEWS: Add item for "style sources" commands.
7321         * source-cache.c (source_cache::get_source_lines): Check
7322         source_styling.
7323         * cli/cli-style.c (source_styling): New global.
7324         (_initialize_cli_style): Add "style sources" commands.
7325         (show_style_sources): New function.
7326         * cli/cli-style.h (source_styling): Declare.
7327
7328 2019-03-14  Pedro Alves  <palves@redhat.com>
7329             Tom Tromey  <tromey@adacore.com>
7330
7331         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7332         * tui/tui-winsource.c (tui_refill_source_window): New function,
7333         from...
7334         (tui_horizontal_source_scroll): ... here.  Move some logic.
7335         * cli/cli-style.c (set_style_enabled): Notify new observable.
7336         * tui/tui-hooks.c (tui_redisplay_source): New function.
7337         (tui_attach_detach_observers): Attach or detach
7338         tui_redisplay_source.
7339         * observable.h (source_styling_changed): New observable.
7340         * observable.c: Define source_styling_changed observable.
7341
7342 2019-03-13  Tom Tromey  <tromey@adacore.com>
7343
7344         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7345         (i386_gnu_nat_target::store_registers): Update.
7346         * target-debug.h (target_debug_print_std_string): New macro.
7347         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7348         * windows-tdep.c (display_one_tib): Update.
7349         * tui/tui-stack.c (tui_make_status_line): Update.
7350         * top.c (print_inferior_quit_action): Update.
7351         * thread.c (thr_try_catch_cmd): Update.
7352         (add_thread_with_info): Update.
7353         (thread_target_id_str): Update.
7354         (thr_try_catch_cmd): Update.
7355         (thread_command): Update.
7356         (thread_find_command): Update.
7357         * record-btrace.c (record_btrace_target::info_record)
7358         (record_btrace_resume_thread, record_btrace_target::resume)
7359         (record_btrace_cancel_resume, record_btrace_step_thread)
7360         (record_btrace_target::wait, record_btrace_target::wait)
7361         (record_btrace_target::wait, record_btrace_target::stop): Update.
7362         * progspace.c (print_program_space): Update.
7363         * process-stratum-target.c
7364         (process_stratum_target::thread_address_space): Update.
7365         * linux-fork.c (linux_fork_mourn_inferior)
7366         (detach_checkpoint_command, info_checkpoints_command)
7367         (linux_fork_context): Update.
7368         (linux_fork_detach): Update.
7369         (class scoped_switch_fork_info): Update.
7370         (delete_checkpoint_command): Update.
7371         * infrun.c (follow_fork_inferior): Update.
7372         (follow_fork_inferior): Update.
7373         (proceed_after_vfork_done): Update.
7374         (handle_vfork_child_exec_or_exit): Update.
7375         (follow_exec): Update.
7376         (displaced_step_prepare_throw): Update.
7377         (displaced_step_restore): Update.
7378         (start_step_over): Update.
7379         (resume_1): Update.
7380         (clear_proceed_status_thread): Update.
7381         (proceed): Update.
7382         (print_target_wait_results): Update.
7383         (do_target_wait): Update.
7384         (context_switch): Update.
7385         (stop_all_threads): Update.
7386         (restart_threads): Update.
7387         (finish_step_over): Update.
7388         (handle_signal_stop): Update.
7389         (switch_back_to_stepped_thread): Update.
7390         (keep_going_pass_signal): Update.
7391         (print_exited_reason): Update.
7392         (normal_stop): Update.
7393         * inferior.c (inferior_pid_to_str): Change return type.
7394         (print_selected_inferior): Update.
7395         (add_inferior): Update.
7396         (detach_inferior): Update.
7397         * dummy-frame.c (fprint_dummy_frames): Update.
7398         * dcache.c (dcache_info_1): Update.
7399         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7400         (btrace_fetch, btrace_clear): Update.
7401         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7402         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7403         type.
7404         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7405         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7406         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7407         * gdbarch.c, gdbarch.h: Rebuild.
7408         * gdbarch.sh (core_pid_to_str): Change return type.
7409         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7410         return type.
7411         (windows_nat_target::pid_to_str): Change return type.
7412         (windows_delete_thread): Update.
7413         (windows_nat_target::attach): Update.
7414         (windows_nat_target::files_info): Update.
7415         * target-delegates.c: Rebuild.
7416         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7417         return type.
7418         (sol_thread_target::pid_to_str): Change return type.
7419         * remote.c (class remote_target) <pid_to_str>: Change return
7420         type.
7421         (remote_target::pid_to_str): Change return type.
7422         (extended_remote_target::attach, remote_target::remote_stop_ns)
7423         (remote_target::remote_notif_remove_queued_reply)
7424         (remote_target::push_stop_reply, remote_target::disable_btrace):
7425         Update.
7426         (extended_remote_target::attach): Update.
7427         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7428         type.
7429         (gdbsim_target::pid_to_str): Change return type.
7430         * ravenscar-thread.c (struct ravenscar_thread_target)
7431         <pid_to_str>: Change return type.
7432         (ravenscar_thread_target::pid_to_str): Change return type.
7433         * procfs.c (class procfs_target) <pid_to_str>: Change return
7434         type.
7435         (procfs_target::pid_to_str): Change return type.
7436         (procfs_target::attach): Update.
7437         (procfs_target::detach): Update.
7438         (procfs_target::fetch_registers): Update.
7439         (procfs_target::store_registers): Update.
7440         (procfs_target::wait): Update.
7441         (procfs_target::files_info): Update.
7442         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7443         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7444         return type.
7445         (nto_procfs_target::pid_to_str): Change return type.
7446         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7447         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7448         return type.
7449         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7450         (exit_lwp): Update.
7451         (attach_proc_task_lwp_callback, get_detach_signal)
7452         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7453         (linux_nat_target::resume, wait_lwp, stop_callback)
7454         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7455         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7456         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7457         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7458         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7459         type.
7460         (inf_ptrace_target::attach): Update.
7461         (inf_ptrace_target::files_info): Update.
7462         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7463         type.
7464         (go32_nat_target::pid_to_str): Change return type.
7465         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7466         (gnu_nat_target::wait): Update.
7467         (gnu_nat_target::wait): Update.
7468         (gnu_nat_target::resume): Update.
7469         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7470         (fbsd_nat_target::wait): Update.
7471         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7472         type.
7473         (darwin_nat_target::attach): Update.
7474         * corelow.c (class core_target) <pid_to_str>: Change return type.
7475         (core_target::pid_to_str): Change return type.
7476         * target.c (normal_pid_to_str): Change return type.
7477         (default_pid_to_str): Likewise.
7478         (target_pid_to_str): Change return type.
7479         (target_translate_tls_address): Update.
7480         (target_announce_detach): Update.
7481         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7482         return type.
7483         (bsd_uthread_target::pid_to_str): Change return type.
7484         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7485         type.
7486         (bsd_kvm_target::pid_to_str): Change return type.
7487         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7488         return type.
7489         (aix_thread_target::pid_to_str): Change return type.
7490         * target.h (struct target_ops) <pid_to_str>: Change return type.
7491         (target_pid_to_str, normal_pid_to_str): Likewise.
7492         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7493         type.
7494         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7495         type.
7496         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7497         return type.
7498         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7499         type.
7500         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7501         type.
7502         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7503         return type.
7504
7505 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7506
7507         * NEWS: Mention that the new default MI version is 3.  Mention
7508         changes to the output of commands and events that deal with
7509         multi-location breakpoints.
7510         * breakpoint.c: Include "mi/mi-out.h".
7511         (print_one_breakpoint): Change output syntax if using MI version
7512         >= 3.
7513         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7514         New.
7515         (mi_multi_location_breakpoint_output_fixed): New.
7516         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7517         (mi_cmd_fix_multi_location_breakpoint_output): New.
7518         (mi_multi_location_breakpoint_output_fixed): New.
7519         * mi/mi-cmds.c (mi_cmds): Register command
7520         -fix-multi-location-breakpoint-output.
7521         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7522         interpreter "mi".
7523
7524 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7525
7526         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7527         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7528         instantiate mi_ui_out based on interpreter name.
7529         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7530         * mi/mi-main.c (mi_load_progress): Likewise.
7531
7532 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7533
7534         * NEWS: Combine separate "New targets" sections for 8.3.
7535
7536 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7537
7538         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7539         (ppcfbsd_init_abi): Install gdbarch
7540         "fetch_tls_load_module_address" and "get_thread_local_address"
7541         methods.
7542
7543 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7544
7545         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7546         (riscv_fbsd_init_abi): Install gdbarch
7547         "fetch_tls_load_module_address" and "get_thread_local_address"
7548         methods.
7549
7550 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7551
7552         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7553         (i386fbsd_init_abi): Install gdbarch
7554         "fetch_tls_load_module_address" and "get_thread_local_address"
7555         methods.
7556
7557 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7558
7559         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7560         (amd64fbsd_init_abi): Install gdbarch
7561         "fetch_tls_load_module_address" and "get_thread_local_address"
7562         methods.
7563
7564 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7565
7566         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7567         (struct fbsd_pspace_data): New type.
7568         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7569         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7570         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7571         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7572         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7573
7574 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7575
7576         * gdbtypes.c (lookup_struct_elt): New function.
7577         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7578         * gdbtypes.h (struct struct_elt): New type.
7579         (lookup_struct_elt): New prototype.
7580
7581 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7582
7583         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7584         remove disabled code block.
7585
7586 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7587
7588         * gdbarch.sh (get_thread_local_address): New method.
7589         * gdbarch.h, gdbarch.c: Regenerate.
7590         * target.c (target_translate_tls_address): Use
7591         gdbarch_get_thread_local_address if present instead of
7592         target::get_thread_local_address.
7593
7594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7595
7596         * target.h (target::get_thread_local_address): Update comment.
7597
7598 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7599
7600         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7601         objfile->separate_debug_objfile_backlink if not NULL.
7602
7603 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7604
7605         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7606         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7607         (amd64bsd_store_inferior_registers): Likewise.
7608         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7609         Enable segment base registers.
7610         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7611         PT_GETFSBASE and PT_GETGSBASE.
7612         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7613         PT_SETGSBASE.
7614         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7615         segment base registers.
7616         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7617
7618 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7619
7620         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7621         Update calls to i386_target_description to add 'segments'
7622         parameter.
7623         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7624         add segment base registers.
7625         * arch/i386.c (i386_create_target_description): Add 'segments'
7626         parameter to enable segment base registers.
7627         * arch/i386.h (i386_create_target_description): Likewise.
7628         * features/i386/32bit-segments.xml: New file.
7629         * features/i386/32bit-segments.c: Generate.
7630         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7631         call to i386_target_description to add 'segments' parameter.
7632         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7633         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7634         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7635         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7636         if feature is present.
7637         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7638         Add 'segments' parameter to call to i386_target_description.
7639         (i386_target_description): Add 'segments' parameter to enable
7640         segment base registers.
7641         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7642         to call to i386_target_description.
7643         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7644         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7645         Define I386_NUM_REGS.
7646         (i386_target_description): Add 'segments' parameter to enable
7647         segment base registers.
7648
7649 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7650
7651         PR/24325
7652         * source-cache.c: #undef open and close, to avoid unresolved
7653         externals during linking.
7654
7655 2019-03-12  Tom Tromey  <tromey@adacore.com>
7656
7657         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7658         const.  Add initializers.
7659         (_initialize_remote): Don't initialize ptid globals.
7660
7661 2019-03-12  Pedro Alves  <palves@redhat.com>
7662
7663         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7664
7665 2019-03-12  Pedro Alves  <palves@redhat.com>
7666
7667         * cp-name-parser.y (main): Remove unused 'len' variable.
7668
7669 2019-03-12  Tom Tromey  <tromey@adacore.com>
7670
7671         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7672         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7673
7674 2019-03-12  Tom Tromey  <tromey@adacore.com>
7675
7676         * linux-nat.c (iterate_over_lwps): Update.
7677         (stop_callback): Remove parameter.
7678         (stop_wait_callback, detach_callback, resume_set_callback)
7679         (select_singlestep_lwp_callback, set_ignore_sigint)
7680         (status_callback, resumed_callback, resume_clear_callback)
7681         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7682         data parameter.
7683         (linux_nat_target::detach, linux_nat_target::resume)
7684         (linux_stop_and_wait_all_lwps, select_event_lwp)
7685         (linux_nat_filter_event, linux_nat_wait_1)
7686         (linux_nat_target::kill, linux_nat_target::stop)
7687         (linux_nat_target::stop): Update.
7688         (linux_nat_resume_callback): Change type.
7689         (resume_stopped_resumed_lwps, count_events_callback)
7690         (select_event_lwp_callback): Likewise.
7691         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7692         * arm-linux-nat.c (struct update_registers_data): Remove.
7693         (update_registers_callback): Change type.
7694         (arm_linux_insert_hw_breakpoint1): Update.
7695         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7696         parameter.
7697         (x86_linux_dr_set_addr): Update.
7698         (x86_linux_dr_set_control): Update.
7699         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7700         (iterate_over_lwps): Use gdb::function_view.
7701         * nat/aarch64-linux-hw-point.c (struct
7702         aarch64_dr_update_callback_param): Remove.
7703         (debug_reg_change_callback): Change type.
7704         (aarch64_notify_debug_reg_change): Update.
7705         * s390-linux-nat.c (s390_refresh_per_info): Update.
7706
7707 2019-03-11  Tom Tromey  <tromey@adacore.com>
7708
7709         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7710         redundant assignment to "this_cu".
7711
7712 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7713
7714         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7715
7716 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7717
7718         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7719         from...
7720         (rank_one_type): ... this.
7721
7722 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7723
7724         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7725         from...
7726         (rank_one_type): ... this.
7727
7728 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7729
7730         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7731         from...
7732         (rank_one_type): ... this.
7733
7734 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7735
7736         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7737         from...
7738         (rank_one_type): ... this.
7739
7740 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7741
7742         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7743         from...
7744         (rank_one_type): ... this.
7745
7746 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7747
7748         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7749         from...
7750         (rank_one_type): ... this.
7751
7752 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7753
7754         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7755         from...
7756         (rank_one_type): ... this.
7757
7758 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7759
7760         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7761         from...
7762         (rank_one_type): ... this.
7763
7764 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7765
7766         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7767         from...
7768         (rank_one_type): ... this.
7769
7770 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7771
7772         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7773         from...
7774         (rank_one_type): ... this.
7775
7776 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7777
7778         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7779         from...
7780         (rank_one_type): ... this.
7781
7782 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7783
7784         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7785         from...
7786         (rank_one_type): ... this.
7787
7788 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7789
7790         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7791         inferior-events' shows the example events.
7792
7793 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7794
7795         Support styling on native MS-Windows console
7796
7797         PR/24315
7798         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7799         on MS-Windows if $TERM is not defined.
7800
7801         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7802
7803         * posix-hdep.c (gdb_console_fputs):
7804         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7805         functions.
7806         * ui-file.h (gdb_console_fputs): Add prototype.
7807
7808         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7809         back to fputs only if the former returns zero.
7810
7811 2019-03-07  Tom Tromey  <tom@tromey.com>
7812
7813         * symmisc.c (print_symbol_bcache_statistics): Update.
7814         (print_objfile_statistics): Update.
7815         * symfile.c (allocate_symtab): Update.
7816         * stabsread.c: Don't include bcache.h.
7817         * psymtab.h (struct psymbol_bcache): Don't declare.
7818         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7819         (psymbol_bcache_init, psymbol_bcache_free)
7820         (psymbol_bcache_get_bcache): Don't declare.
7821         * psymtab.c (struct psymbol_bcache): Remove.
7822         (psymtab_storage::psymtab_storage): Update.
7823         (psymtab_storage::~psymtab_storage): Update.
7824         (psymbol_bcache_init, psymbol_bcache_free)
7825         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7826         (add_psymbol_to_bcache): Update.
7827         (allocate_psymtab): Update.
7828         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7829         macro_cache>: No longer pointers.
7830         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7831         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7832         * macrotab.c (macro_bcache): Update.
7833         * macroexp.c: Don't include bcache.h.
7834         * gdbtypes.c (check_types_worklist): Update.
7835         (types_deeply_equal): Remove TRY/CATCH.  Update.
7836         * elfread.c (elf_symtab_read): Update.
7837         * dwarf2read.c: Don't include bcache.h.
7838         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7839         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7840         (print_bcache_statistics, bcache_memory_used): Don't declare.
7841         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7842         methods.  Rename all data members.
7843         * bcache.c (struct bcache): Move to bcache.h.
7844         (bcache::expand_hash_table): Rename from expand_hash_table.
7845         (bcache): Remove.
7846         (bcache::insert): Rename from bcache_full.
7847         (bcache::compare): Rename from bcache_compare.
7848         (bcache_xmalloc): Remove.
7849         (bcache::~bcache): Rename from bcache_xfree.
7850         (bcache::print_statistics): Rename from print_bcache_statistics.
7851         (bcache::memory_used): Rename from bcache_memory_used.
7852
7853 2019-03-07  Pedro Alves  <palves@redhat.com>
7854
7855         * infrun.c (normal_stop): Also check for
7856         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7857
7858 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * f-lang.c (value_from_host_double): Moved to...
7861         * value.c (value_from_host_double): ...here.
7862         * value.h (value_from_host_double): Declare.
7863         * guile/scm-math.c (vlscm_convert_typed_number): Use
7864         value_from_host_double.
7865         (vlscm_convert_number): Likewise.
7866         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7867         * python/py-value.c (convert_value_from_python): Likewise.
7868
7869 2019-03-06  Tom Tromey  <tom@tromey.com>
7870
7871         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7872
7873 2019-03-06  Tom Tromey  <tom@tromey.com>
7874
7875         * utils.h (free_current_contents): Don't declare.
7876         * utils.c (free_current_contents): Remove.
7877
7878 2019-03-06  Tom Tromey  <tom@tromey.com>
7879
7880         * top.c (quit_force): Update.
7881         * main.c (captured_command_loop): Update.
7882         * common/new-op.c (operator new): Update.
7883         * common/common-exceptions.c (struct catcher)
7884         <save_cleanup_chain>: Remove member.
7885         (exceptions_state_mc_init): Update.
7886         (exception_try_scope_entry): Return nullptr.
7887         (exception_try_scope_exit, exception_rethrow)
7888         (throw_exception_sjlj, throw_exception_cxx): Update.
7889         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7890         (all_cleanups, do_cleanups, discard_cleanups)
7891         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7892         (restore_cleanups, restore_final_cleanups): Don't declare.
7893         (do_final_cleanups): Remove parameter.
7894         * common/cleanups.c (cleanup_chain, make_cleanup)
7895         (make_cleanup_dtor, all_cleanups, do_cleanups)
7896         (discard_my_cleanups, discard_cleanups)
7897         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7898         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7899         (null_cleanup): Remove.
7900         (do_final_cleanups): Remove parameter.
7901
7902 2019-03-06  Tom Tromey  <tom@tromey.com>
7903
7904         * remote.c (remote_target::remote_parse_stop_reply): Use
7905         unique_xmalloc_ptr.
7906
7907 2019-03-06  Tom Tromey  <tom@tromey.com>
7908
7909         * stabsread.c (struct stabs_field_info): Rename from field_info.
7910         <list, fnlist>: Add initializers.
7911         <obstack>: New member.
7912         (read_member_functions, read_struct_fields, read_baseclasses):
7913         Allocate on obstack.  Don't use cleanups.
7914         (read_one_struct_field, read_member_functions, read_struct_fields)
7915         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7916         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7917         (read_struct_type): Update.
7918
7919 2019-03-06  Tom Tromey  <tom@tromey.com>
7920
7921         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7922         * common/filestuff.h (make_cleanup_close): Don't declare.
7923         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7924         Remove.
7925
7926 2019-03-06  Tom Tromey  <tom@tromey.com>
7927
7928         * solib-aix.c: Use make_scope_exit.
7929
7930 2019-03-06  Tom Tromey  <tom@tromey.com>
7931
7932         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7933         Use make_scope_exit.
7934
7935 2019-03-06  Tom Tromey  <tom@tromey.com>
7936
7937         * solib-svr4.c (disable_probes_interface): Remove parameter.
7938         (svr4_handle_solib_event): Use make_scope_exit.
7939
7940 2019-03-06  Tom Tromey  <tom@tromey.com>
7941
7942         * remote.c (struct stop_reply_deleter): Remove.
7943         (stop_reply_up): Update.
7944         (struct stop_reply): Derive from notif_event.  Don't typedef.
7945         <regcache>: Now a std::vector.
7946         (stop_reply_xfree): Remove.
7947         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7948         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7949         (remote_target::discard_pending_stop_replies): Use delete.
7950         (remote_target::remote_parse_stop_reply): Update.
7951         (remote_target::process_stop_reply): Update.
7952         * remote-notif.h (struct notif_event): Add virtual destructor.
7953         Remove "dtr" member.
7954         (struct notif_client) <alloc_event>: Return a unique_ptr.
7955         (notif_event_xfree): Don't declare.
7956         (notif_event_up): New typedef.
7957         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7958         (notif_event_xfree, do_notif_event_xfree): Remove.
7959         (remote_notif_state_xfree): Update.
7960
7961 2019-03-06  Tom Tromey  <tom@tromey.com>
7962
7963         * infrun.c (displaced_step_clear_cleanup): Now a
7964         forward_scope_exit type.
7965         (displaced_step_prepare_throw): Update.
7966         (displaced_step_fixup): Update.
7967
7968 2019-03-06  Tom Tromey  <tom@tromey.com>
7969
7970         * inferior.h (class inferior): Update comment.
7971         * gdbthread.h (class thread_info): Update comment.
7972
7973 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7974             Tom Tromey  <tom@tromey.com>
7975
7976         * stabsread.h (struct stab_section_list): Remove.
7977         (coffstab_build_psymtabs): Update.
7978         * dbxread.c (symbuf_sections): Now a std::vector.
7979         (sect_idx): New global.
7980         (fill_symbuf): Update.
7981         (coffstab_build_psymtabs): Change type of stabsects parameter.
7982         Update.
7983         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7984         std::vector.
7985         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7986         (coff_locate_sections): Update.
7987         (coff_symfile_read): Remove cleanups.  Update.
7988         (init_stringtab): Add storage parameter.
7989         (free_stringtab, free_stringtab_cleanup): Remove.
7990         (init_lineno): Add storage parameter.
7991         (free_linetab, free_linetab_cleanup): Remove.
7992
7993 2019-03-06  Pedro Alves  <palves@redhat.com>
7994
7995         * linux-fork.c (fork_info::clobber_regs): Delete.
7996         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7997         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7998         comment.  Adjust.
7999         (scoped_switch_fork_info::scoped_switch_fork_info)
8000         (checkpoint_command, linux_fork_context): Adjust
8001         fork_save_infrun_state calls.
8002
8003 2019-03-06  Pedro Alves  <palves@redhat.com>
8004
8005         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8006         (inf_has_multiple_threads): Return 'bool' and rewrite using
8007         inferior_info::threads().
8008
8009 2019-03-06  Pedro Alves  <palves@redhat.com>
8010
8011         * linux-fork.c: Include <list>.
8012         (fork_list): Now a std::list instance.
8013         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8014         (forks_exist_p, find_last_fork): Adjust.
8015         (new_fork): Delete.
8016         (one_fork_p): New.
8017         (add_fork): Adjust.
8018         (free_fork): Delete, folded into fork_info::~fork_info().
8019         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8020         Adjust.
8021         (init_fork_list): Delete.
8022         (linux_fork_killall, linux_fork_mourn_inferior)
8023         (linux_fork_detach, info_checkpoints_command): Adjust.
8024         (_initialize_linux_fork): No longer call init_fork_list.
8025
8026 2019-03-06  Pedro Alves  <palves@redhat.com>
8027
8028         * linux-fork.c (new_fork): New, split out of ...
8029         (add_fork): ... this.  Return void.  Move "first fork" special
8030         case from here, to ...
8031         (checkpoint_command): ... here.
8032         * linux-linux.h (add_fork): Return void.
8033
8034 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8035
8036         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8037
8038 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8039             Chris January  <chris.january@arm.com>
8040             David Lecomber  <david.lecomber@arm.com>
8041
8042         * f-exp.y: New token, UNOP_INTRINSIC.
8043         (exp): New pattern using UNOP_INTRINSIC token.
8044         (f77_keywords): Add 'abs' keyword.
8045         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8046         (value_from_host_double): New function.
8047         (evaluate_subexp_f): Support UNOP_ABS.
8048
8049 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8050
8051         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8052         types.
8053
8054 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8055
8056         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8057         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8058         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8059
8060 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8061
8062         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8063
8064 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8065             Chris January  <chris.january@arm.com>
8066
8067         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8068         * f-exp.y: Define 'KIND' token.
8069         (exp): New pattern for KIND expressions.
8070         (ptype): Handle types with a kind extension.
8071         (direct_abs_decl): Extend to spot kind extensions.
8072         (f77_keywords): Add 'kind' to the list.
8073         (push_kind_type): New function.
8074         (convert_to_kind_type): New function.
8075         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8076         * parse.c (operator_length_standard): Likewise.
8077         * parser-defs.h (enum type_pieces): Add tp_kind.
8078         * std-operator.def: Add UNOP_KIND.
8079
8080 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8081
8082         * f-exp.y (f_parse): Set yydebug.
8083
8084 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8085
8086         * f-lang.c (evaluate_subexp_f): New function.
8087         (exp_descriptor_f): New global.
8088         (f_language_defn): Use exp_descriptor_f instead of
8089         exp_descriptor_standard.
8090
8091 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8092
8093         * f-exp.y (struct token): Add comments.
8094         (dot_ops): Remove uppercase versions and the end marker.
8095         (f77_keywords): Likewise.
8096         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8097         entries in the dot_ops array are case insensitive, and use
8098         strncasecmp to compare strings.  Also some whitespace cleanup in
8099         this area.  Similar for the f77_keywords array, except entries in
8100         this list might be case sensitive.
8101
8102 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8103
8104         * f-exp.y (struct f77_boolean_val): Add comments.
8105         (boolean_values): Remove uppercase versions, and end marker.
8106         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8107         and use strncasecmp to achieve case insensitivity.  Additionally,
8108         perform whitespace cleanup around this code.
8109
8110 2019-03-06  Tom Tromey  <tromey@adacore.com>
8111
8112         * remote-sim.c (gdbsim_target_open): Use result of
8113         gdb_argv::release.
8114
8115 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8116         Dirk Schubert  <dirk.schubert@arm.com>
8117         Chris January  <chris.january@arm.com>
8118
8119         * eval.c (evaluate_subexp_standard): Call Fortran argument
8120         wrapping logic.
8121         * f-lang.c (struct value): A value which can be passed into a
8122         Fortran function call.
8123         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8124         where appropriate.
8125         (struct type): Value ready for a Fortran function call.
8126         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8127         is needed.
8128         * f-lang.h (fortran_argument_convert): Declaration.
8129         (fortran_preserve_arg_pointer): Declaration.
8130         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8131
8132 2019-03-05  Tom Tromey  <tromey@adacore.com>
8133
8134         * python/py-prettyprint.c (print_string_repr): Remove #if.
8135         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8136
8137 2019-03-05  Tom Tromey  <tromey@adacore.com>
8138
8139         * target.c (the_dummy_target): Move later.  Change type to
8140         "dummy_target".
8141         (initialize_targets): Don't initialize the_dummy_target.
8142
8143 2019-03-05  Tom Tromey  <tromey@adacore.com>
8144
8145         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8146         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8147
8148 2019-03-05  Tom Tromey  <tromey@adacore.com>
8149
8150         * windows-nat.c (windows_nat_target::attach)
8151         (windows_nat_target::detach): Don't call gdb_flush.
8152         * valprint.c (generic_val_print, val_print, val_print_string):
8153         Don't call gdb_flush.
8154         * utils.c (defaulted_query): Don't call gdb_flush.
8155         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8156         * target.c (target_announce_detach): Don't call gdb_flush.
8157         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8158         * remote.c (extended_remote_target::attach): Don't call
8159         gdb_flush.
8160         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8161         * printcmd.c (do_examine): Don't call gdb_flush.
8162         (info_display_command): Don't call gdb_flush.
8163         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8164         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8165         * memattr.c (info_mem_command): Don't call gdb_flush.
8166         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8167         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8168         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8169         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8170         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8171         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8172         (gnu_nat_target::detach): Don't call gdb_flush.
8173         * f-valprint.c (f_val_print): Don't call gdb_flush.
8174         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8175         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8176         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8177         gdb_flush.
8178         * c-valprint.c (c_val_print): Don't call gdb_flush.
8179         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8180
8181 2019-03-05  Tom Tromey  <tromey@adacore.com>
8182
8183         * varobj.c (update_dynamic_varobj_children): Update.
8184         (install_default_visualizer): Use reset, not release.
8185         * value.c (set_internalvar): Update.
8186         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8187         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8188         ATTRIBUTE_UNUSED_RESULT.
8189
8190 2019-03-05  Tom Tromey  <tromey@adacore.com>
8191
8192         * remote.c (class scoped_remote_fd) <release>: Add
8193         ATTRIBUTE_UNUSED_RESULT.
8194
8195 2019-03-05  Tom Tromey  <tromey@adacore.com>
8196
8197         * macroexp.c (struct macro_buffer) <release>: Add
8198         ATTRIBUTE_UNUSED_RESULT.
8199
8200 2019-03-05  Tom Tromey  <tromey@adacore.com>
8201
8202         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8203         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8204         ATTRIBUTE_UNUSED_RESULT.
8205
8206 2019-03-05  Tom Tromey  <tromey@adacore.com>
8207
8208         * common/scoped_fd.h (class scoped_fd) <release>: Add
8209         ATTRIBUTE_UNUSED_RESULT.
8210
8211 2019-03-05  Tom Tromey  <tromey@adacore.com>
8212
8213         * parser-defs.h (struct parser_state) <release>: Add
8214         ATTRIBUTE_UNUSED_RESULT.
8215
8216 2019-03-05  Tom Tromey  <tromey@adacore.com>
8217
8218         * utils.h (class gdb_argv) <release>: Add
8219         ATTRIBUTE_UNUSED_RESULT.
8220         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8221
8222 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8223
8224         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8225         for-loop range, to avoid compiler warnings.
8226
8227         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8228         avoid compiler warnings about unused variables.
8229
8230         * NEWS: Mention end of support for native debugging on MS-Windows
8231         before XP.
8232
8233         PR gdb/24292
8234         * common/netstuff.c:
8235         * gdbserver/gdbreplay.c
8236         * gdbserver/remote-utils.c:
8237         * ser-tcp.c:
8238         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8239         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8240         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8241         'getaddrinfo' and 'freeaddrinfo' were not available before
8242         Windows XP, and mingw.org's MinGW headers by default define
8243         _WIN32_WINNT to 0x500.
8244
8245 2019-03-01  Gary Benson <gbenson@redhat.com>
8246
8247         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8248
8249 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8250             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8251
8252         PR gdb/8527
8253         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8254         set_sigint_trap, clear_sigint_trap.
8255
8256 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8257
8258         * target.c (target_detach): Clear the regcache and the
8259         frame cache.
8260
8261 2019-02-27  Pedro Alves  <palves@redhat.com>
8262
8263         * utils.c (set_screen_size): When we cap the height/width sizes,
8264         tweak the corresponding command variable to show "unlimited":
8265
8266 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8267             Pedro Alves  <palves@redhat.com>
8268
8269         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8270         before calling rl_set_screen_size.
8271
8272 2019-02-27  Tom Tromey  <tromey@adacore.com>
8273
8274         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8275         define.
8276         * python/py-value.c: Remove Python 2.4 workaround.
8277         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8278         workaround.
8279         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8280         Python 2.4 workaround.
8281         * python/python-internal.h: Remove Python 2.4 comment.
8282         (Py_ssize_t): Don't define.
8283         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8284         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8285         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8286         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8287         * python/python.c (do_start_initialization): Remove Python 2.4
8288         workaround.
8289         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8290         (print_children): Remove Python 2.4 workaround.
8291         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8292         workaround.
8293         (CHARBUFFERPROC_NAME): Remove.
8294         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8295         Python 2.4 workaround.
8296
8297 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8298
8299         * NEWS: Note minimum Python version.
8300
8301 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8302
8303         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8304         code from these functions.  Remove corresponding ifdefs.  Use
8305         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8306         Remove gotos and target of gotos.
8307         (infpy_search_memory): Likewise.
8308
8309 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8310
8311         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8312         (hppa_gdbarch_init): Don't register deleted functions with
8313         gdbarch.
8314
8315 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8316
8317         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8318         (h8300_unwind_sp): Delete.
8319         (h8300_dummy_id): Delete.
8320         (h8300_gdbarch_init): Don't register deleted functions with
8321         gdbarch.
8322
8323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8324
8325         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8326         (ft32_unwind_pc): Delete.
8327         (ft32_unwind_sp): Delete.
8328         (ft32_gdbarch_init): Don't register deleted functions with
8329         gdbarch.
8330
8331 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8332
8333         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8334         (frv_unwind_pc): Delete.
8335         (frv_unwind_sp): Delete.
8336         (frv_gdbarch_init): Don't register deleted functions with
8337         gdbarch.
8338
8339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8340
8341         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8342         (riscv_unwind_pc): Delete.
8343         (riscv_unwind_sp): Delete.
8344         (riscv_gdbarch_init): Don't register deleted functions with
8345         gdbarch.
8346
8347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8348
8349         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8350         (csky_unwind_pc): Delete.
8351         (csky_unwind_sp): Delete.
8352         (csky_gdbarch_init): Don't register deleted functions with
8353         gdbarch.
8354
8355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8356
8357         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8358         (cris_unwind_pc): Delete.
8359         (cris_unwind_sp): Delete.
8360         (cris_gdbarch_init): Don't register deleted functions with
8361         gdbarch.
8362
8363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8364
8365         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8366         (bfin_unwind_pc): Delete.
8367         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8368
8369 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8370
8371         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8372         (arm_unwind_pc): Delete.
8373         (arm_unwind_sp): Delete.
8374         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8375
8376 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8377
8378         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8379         (arc_unwind_pc): Delete.
8380         (arc_unwind_sp): Delete.
8381         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8382
8383 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8384
8385         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8386         (alpha_unwind_pc): Delete.
8387         (alpha_gdbarch_init): Don't register deleted functions with
8388         gdbarch.
8389
8390 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8391
8392         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8393         (aarch64_unwind_pc): Delete.
8394         (aarch64_unwind_sp): Delete.
8395         (aarch64_gdbarch_init): Don't register deleted functions with
8396         gdbarch.
8397
8398 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8399
8400         * gdbtypes.c (type_align): Don't consider static members when
8401         computing structure alignment.
8402
8403 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8404
8405         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8406         return 0 for other types.
8407         * arch-utils.c (default_type_align): Always return 0.
8408         * gdbarch.h: Regenerate.
8409         * gdbarch.sh (type_align): Extend comment.
8410         * gdbtypes.c (type_align): Add additional comments, always call
8411         gdbarch_type_align before applying the default rules.
8412         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8413         generic code will then apply a suitable default.
8414         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8415         types, return 0 for other types.
8416
8417 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8418
8419         * NEWS: Create a new section for the next release branch.
8420         Rename the section of the current branch, now that it has
8421         been cut.
8422
8423 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8424
8425         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8426         * version.in: Bump version to 8.3.50.DATE-git.
8427
8428 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8429
8430         * aix-thread.c (ptid_cmp): Remove unused variable.
8431         (get_signaled_thread): Likewise.
8432         (store_regs_user_thread): Likewise.
8433         (store_regs_kernel_thread): Likewise.
8434         (fetch_regs_kernel_thread): Remove shadowed variable.
8435
8436 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8437
8438         * features/riscv/32bit-cpu.xml: Add register numbers.
8439         * features/riscv/32bit-fpu.c: Regenerate.
8440         * features/riscv/32bit-fpu.xml: Add register numbers.
8441         * features/riscv/64bit-cpu.xml: Add register numbers.
8442         * features/riscv/64bit-fpu.c: Regenerate.
8443         * features/riscv/64bit-fpu.xml: Add register numbers.
8444
8445 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8446
8447         * NEWS: Mention two argument form of gdb.Value constructor.
8448         * python/py-value.c (convert_buffer_and_type_to_value): New
8449         function.
8450         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8451         Add support for handling an optional second argument.  Call
8452         convert_buffer_and_type_to_value as appropriate.
8453         * python/python-internal.h (Py_buffer_deleter): New struct.
8454         (Py_buffer_up): New typedef.
8455
8456 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8457
8458         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8459         instead of releasing ownership.
8460
8461 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8462
8463         * dwarf2read.c (open_and_init_dwp_file): Call
8464         elf_numsections instead of bfd_count_sections to initialize
8465         dwp_file->num_sections.
8466
8467 2019-02-25  Tom Tromey  <tromey@adacore.com>
8468
8469         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8470
8471 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8472
8473         * gcore.in: Add '--readnever' option when invoking GDB.
8474
8475 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8476
8477         * MAINTAINERS: Update my email address.
8478
8479 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8480
8481         * build-id.c (build_id_to_debug_bfd_1): New function.
8482         (build_id_to_debug_bfd): Look for separate debug file in
8483         sysroot.
8484
8485 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8486
8487         * gdbarch.sh: Update the copyright year range that is placed into
8488         generated files.
8489
8490 2019-02-22  Keith Seitz  <keiths@redhat.com>
8491
8492         PR symtab/23853
8493         * linespec.c (create_sals_line_offset): Search for the default
8494         symtab's filename instead of its fullname.
8495
8496 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8497
8498         * NEWS: Update style defaults.
8499
8500 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8501
8502         * main.c (captured_main_1): Disable styling in batch mode.
8503
8504 2019-02-20  Tom Tromey  <tom@tromey.com>
8505
8506         * symtab.c (symtab_symbol_info): Fix typos.
8507
8508 2019-02-20  Tom Tromey  <tromey@adacore.com>
8509
8510         * findcmd.c (_initialize_mem_search): Use upper case for
8511         metasyntactic variables.
8512
8513 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8514
8515         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8516         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8517
8518 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8519
8520         * top.h (source_file_name): Change to std::string.
8521         * top.c (source_file_name): Likewise.
8522         (command_line_input): Adjust.
8523         * cli/cli-script.c (script_from_file): Adjust.
8524
8525 2019-02-19  Tom Tromey  <tromey@adacore.com>
8526
8527         * ravenscar-thread.c
8528         (ravenscar_thread_target::update_thread_list): Don't call
8529         ada_build_task_list.
8530         * ada-lang.h (ada_build_task_list): Don't declare.
8531         * ada-tasks.c (struct ada_tasks_inferior_data)
8532         <task_list_valid_p>: Now bool.
8533         (read_known_tasks, ada_task_list_changed)
8534         (ada_tasks_invalidate_inferior_data): Update.
8535         (read_known_tasks_array): Return bool.
8536         (read_known_tasks_list): Likewise.
8537         (read_known_tasks): Return void.
8538         (ada_build_task_list): Now static.
8539
8540 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8541
8542         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8543         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8544
8545 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8546
8547         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8548         variant for ada_tasks_pspace_data_handle and
8549         ada_tasks_inferior_data_handle.
8550         (ada_tasks_pspace_data_cleanup): New function.
8551         (ada_tasks_inferior_data_cleanup): New function.
8552
8553 2019-02-17  Tom Tromey  <tom@tromey.com>
8554
8555         * macrotab.h (macro_source_fullname): Return a std::string.
8556         * macrotab.c (macro_include, check_for_redefinition)
8557         (macro_undef, macro_lookup_definition, foreach_macro)
8558         (foreach_macro_in_scope): Update.
8559         (macro_source_fullname): Return a std::string.
8560         * macrocmd.c (show_pp_source_pos): Update.
8561
8562 2019-02-17  Tom Tromey  <tom@tromey.com>
8563
8564         * macrocmd.c (show_pp_source_pos): Style the file names.
8565
8566 2019-02-17  Tom Tromey  <tom@tromey.com>
8567
8568         PR tui/24197:
8569         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8570
8571 2019-02-17  Tom Tromey  <tom@tromey.com>
8572
8573         * ada-lang.c (user_select_syms): Use filtered printing.
8574         * utils.c (wrap_style): New global.
8575         (desired_style): Remove.
8576         (emit_style_escape): Add stream parameter.
8577         (set_output_style, reset_terminal_style, prompt_for_continue):
8578         Update.
8579         (flush_wrap_buffer): Only flush gdb_stdout.
8580         (wrap_here): Set wrap_style.
8581         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8582         treat escape sequences as a character.  Change when wrap buffer is
8583         flushed.
8584         (fputs_styled): Do not set the output style when the default is
8585         requested.
8586         * ui-style.h (struct ui_file_style) <is_default>: New method.
8587         * source.c (print_source_lines_base): Emit escape sequences in one
8588         piece.
8589
8590 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8591
8592         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8593         integers and enumeration types.
8594
8595 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8596
8597         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8598         instead of lookup_symbol_in_language
8599         (do_exact_match): New function.
8600         (ada_get_symbol_name_matcher): Return do_exact_match when
8601         doing a verbatim match.
8602
8603 2019-02-15  Tom Tromey  <tromey@adacore.com>
8604
8605         * ravenscar-thread.c (ravenscar_thread_target::resume)
8606         (ravenscar_thread_target::wait): Special case wildcard requests.
8607
8608 2019-02-15  Tom Tromey  <tromey@adacore.com>
8609
8610         * ravenscar-thread.c (base_ptid): Remove.
8611         (struct ravenscar_thread_target) <close>: New method.
8612         <m_base_ptid>: New member.
8613         <update_inferior_ptid, active_task, task_is_currently_active,
8614         runtime_initialized>: Declare methods.
8615         <ravenscar_thread_target>: Add constructor.
8616         (ravenscar_thread_target::task_is_currently_active)
8617         (ravenscar_thread_target::update_inferior_ptid)
8618         (ravenscar_runtime_initialized): Rename.  Now methods.
8619         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8620         (ravenscar_thread_target::update_thread_list): Update.
8621         (ravenscar_thread_target::active_task): Now method.
8622         (ravenscar_thread_target::store_registers)
8623         (ravenscar_thread_target::prepare_to_store)
8624         (ravenscar_thread_target::prepare_to_store)
8625         (ravenscar_thread_target::mourn_inferior): Update.
8626         (ravenscar_inferior_created): Use "new" to create target.
8627         (ravenscar_thread_target::get_ada_task_ptid): Update.
8628         (_initialize_ravenscar): Don't initialize base_ptid.
8629         (ravenscar_ops): Remove global.
8630
8631 2019-02-15  Tom Tromey  <tromey@adacore.com>
8632
8633         * target.h (push_target): Declare new overload.
8634         * target.c (push_target): New overload, taking an rvalue reference.
8635         * remote.c (remote_target::open_1): Use push_target overload.
8636         * corelow.c (core_target_open): Use push_target overload.
8637
8638 2019-02-15  Tom Tromey  <tromey@adacore.com>
8639
8640         * ravenscar-thread.c (is_ravenscar_task)
8641         (ravenscar_task_is_currently_active): Return bool.
8642         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8643         (_initialize_ravenscar): Remove "(void)".
8644         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8645         Return bool.
8646
8647 2019-02-15  Tom Tromey  <tromey@adacore.com>
8648
8649         * ravenscar-thread.c (ravenscar_runtime_initializer)
8650         (has_ravenscar_runtime, get_running_thread_id)
8651         (ravenscar_thread_target::resume): Fix indentation.
8652
8653 2019-02-15  Tom Tromey  <tromey@adacore.com>
8654
8655         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8656         from ravenscar_arch_ops.
8657         (sparc_ravenscar_ops::fetch_registers)
8658         (sparc_ravenscar_ops::store_registers): Now methods.
8659         (sparc_ravenscar_prepare_to_store): Remove.
8660         (sparc_ravenscar_ops): Redefine.
8661         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8662         methods and destructor.  Remove members.
8663         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8664         (ravenscar_thread_target::store_registers)
8665         (ravenscar_thread_target::prepare_to_store): Update.
8666         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8667         Remove.
8668         (struct ppc_ravenscar_powerpc_ops): Derive from
8669         ravenscar_arch_ops.
8670         (ppc_ravenscar_powerpc_ops::fetch_registers)
8671         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8672         (ppc_ravenscar_powerpc_ops): Redefine.
8673         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8674         (ppc_ravenscar_e500_ops::fetch_registers)
8675         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8676         (ppc_ravenscar_e500_ops): Redefine.
8677         * aarch64-ravenscar-thread.c
8678         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8679         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8680         (aarch64_ravenscar_fetch_registers)
8681         (aarch64_ravenscar_store_registers): Now methods.
8682         (aarch64_ravenscar_ops): Redefine.
8683
8684 2019-02-15  Tom Tromey  <tromey@adacore.com>
8685
8686         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8687         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8688         (ravenscar_thread_target::stopped_by_watchpoint)
8689         (ravenscar_thread_target::stopped_data_address)
8690         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8691
8692 2019-02-15  Tom Tromey  <tromey@adacore.com>
8693
8694         * ravenscar-thread.c: Fix some typos.
8695
8696 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8697             Tom Tromey  <tromey@adacore.com>
8698
8699         * ada-lang.c (ada_exception_sal): Change addr_string to a
8700         std::string.
8701         (create_ada_exception_catchpoint): Update.
8702
8703 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8704             Tom Tromey  <tromey@adacore.com>
8705
8706         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8707         (bp_location_ops): Remove.
8708         (base_breakpoint_allocate_location): Update.
8709         (free_bp_location): Update.
8710         * ada-lang.c (class ada_catchpoint_location)
8711         <ada_catchpoint_location>: Remove ops parameter.
8712         (ada_catchpoint_location_dtor): Remove.
8713         (ada_catchpoint_location_ops): Remove.
8714         (allocate_location_exception): Update.
8715         * breakpoint.h (struct bp_location_ops): Remove.
8716         (class bp_location) <bp_location>: Remove bp_location_ops
8717         parameter.
8718         <~bp_location>: Add destructor.
8719         <ops>: Remove.
8720
8721 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8722             Pedro Alves  <palves@redhat.com>
8723
8724         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8725         'PATH_MAX'.
8726
8727 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8728             Samuel Thibault  <samuel.thibault@gnu.org>
8729             Thomas Schwinge  <thomas@codesourcery.com>
8730
8731         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8732         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8733
8734 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8735
8736         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8737         (check_empty): Use "const char *".
8738
8739         * gnu-nat.c (gnu_nat_target::detach): Instead of
8740         'detach_inferior (pid)' call
8741         'detach_inferior (find_inferior_pid (pid))'.
8742
8743         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8744         'nat/fork-inferior.o'.
8745         * gnu-nat.c: #include "nat/fork-inferior.h".
8746
8747         * gnu-nat.c (gnu_nat_target::detach): Instead of
8748         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8749         * gnu-nat.h: #include "inf-child.h".
8750         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8751         'i386_gnu_nat_target::fetch_registers'.
8752         (gnu_store_registers): Rename/move to
8753         'i386_gnu_nat_target::store_registers'.
8754
8755         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8756         * gnu-nat.h (mach_thread_info): New function.
8757         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8758
8759         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8760
8761 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8762
8763         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8764
8765 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8766
8767         * windows-nat.c (windows_add_thread): Add new parameter
8768         "main_thread_p" with default value set to false.  Update
8769         function documentation as well as all callers.
8770         (windows_delete_thread): Likewise.
8771         (fake_create_process): Update call to windows_add_thread.
8772         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8773         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8774         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8775         call to windows_delete_thread.
8776
8777 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8778
8779         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8780
8781 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8782
8783         * symfile.c (find_separate_debug_file): Use canonical path of
8784         sysroot with child_path instead of gdb_sysroot if it is valid.
8785
8786 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8787
8788         * symfile.c (find_separate_debug_file): Use child_path to
8789         determine if an object file is under a sysroot.
8790
8791 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8792
8793         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8794         unittests/child-path-selftests.c.
8795         * common/pathstuff.c (child_path): New function.
8796         * common/pathstuff.h (child_path): New prototype.
8797         * unittests/child-path-selftests.c: New file.
8798
8799 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8800
8801         * symfile.c (find_separate_debug_file): Look for separate debug
8802         files in debug directories under the sysroot.
8803
8804 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8805
8806         * symtab.h (struct minimal_symbol data_p): New const method.
8807         (struct minimal_symbol text_p): Likewise.
8808         * symtab.c (output_source_filename): Use file name style
8809         to print file name.
8810         (print_symbol_info): Likewise.
8811         (print_msymbol_info): Use address style to print addresses.
8812         Use function name style to print executable text symbols.
8813         (expand_symtab_containing_pc): Use data_p.
8814         (find_pc_sect_compunit_symtab): Likewise.
8815
8816 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8817
8818         * breakpoint.c (describe_other_breakpoints): Use address style
8819         to print addresses.
8820         (say_where): Likewise.
8821
8822 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8823
8824         * ada-typeprint.c (print_func_type): Print function name
8825         style to print function name.
8826         * c-typeprint.c (c_print_type_1): Likewise.
8827
8828 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8829
8830         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8831         for execve.
8832
8833 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8834
8835         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8836         type_stack.
8837
8838 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8839
8840         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8841         TYPE_CODE_REF types.
8842
8843 2019-02-08  Jim Wilson  <jimw@sifive.com>
8844
8845         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8846         (riscv_linux_fregset): New.
8847         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8848
8849 2019-02-07  Tom Tromey  <tom@tromey.com>
8850
8851         * thread.c (thread_cancel_execution_command): Update.
8852         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8853         methods.
8854         (struct thread_fsm_ops): Remove.
8855         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8856         (thread_fsm_should_stop, thread_fsm_return_value)
8857         (thread_fsm_set_finished, thread_fsm_finished_p)
8858         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8859         Don't declare.
8860         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8861         * infrun.c (clear_proceed_status_thread)
8862         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8863         (print_stop_event): Update.
8864         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8865         Add constructor.
8866         (step_command_fsm_ops): Remove.
8867         (new_step_command_fsm): Remove.
8868         (step_1): Update.
8869         (step_command_fsm::should_stop): Rename from
8870         step_command_fsm_should_stop.
8871         (step_command_fsm::clean_up): Rename from
8872         step_command_fsm_clean_up.
8873         (step_command_fsm::do_async_reply_reason): Rename from
8874         step_command_fsm_async_reply_reason.
8875         (struct until_next_fsm): Inherit from thread_fsm.  Add
8876         constructor.
8877         (until_next_fsm_ops): Remove.
8878         (new_until_next_fsm): Remove.
8879         (until_next_fsm::should_stop): Rename from
8880         until_next_fsm_should_stop.
8881         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8882         (until_next_fsm::do_async_reply_reason): Rename from
8883         until_next_fsm_async_reply_reason.
8884         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8885         constructor.  Change type of breakpoint.
8886         (finish_command_fsm_ops): Remove.
8887         (new_finish_command_fsm): Remove.
8888         (finish_command_fsm::should_stop): Rename from
8889         finish_command_fsm_should_stop.
8890         (finish_command_fsm::clean_up): Rename from
8891         finish_command_fsm_clean_up.
8892         (finish_command_fsm::return_value): Rename from
8893         finish_command_fsm_return_value.
8894         (finish_command_fsm::do_async_reply_reason): Rename from
8895         finish_command_fsm_async_reply_reason.
8896         (finish_command): Update.
8897         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8898         Add constructor.
8899         (call_thread_fsm_ops): Remove.
8900         (call_thread_fsm::call_thread_fsm): Rename from
8901         new_call_thread_fsm.
8902         (call_thread_fsm::should_stop): Rename from
8903         call_thread_fsm_should_stop.
8904         (call_thread_fsm::should_notify_stop): Rename from
8905         call_thread_fsm_should_notify_stop.
8906         (run_inferior_call, call_function_by_hand_dummy): Update.
8907         * cli/cli-interp.c (should_print_stop_to_console): Update.
8908         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8909         Add constructor.  Change type of location_breakpoint,
8910         caller_breakpoint.
8911         (until_break_fsm_ops): Remove.
8912         (new_until_break_fsm): Remove.
8913         (until_break_fsm::should_stop): Rename from
8914         until_break_fsm_should_stop.
8915         (until_break_fsm::clean_up): Rename from
8916         until_break_fsm_clean_up.
8917         (until_break_fsm::do_async_reply_reason): Rename from
8918         until_break_fsm_async_reply_reason.
8919         (until_break_command): Update.
8920         * thread-fsm.c: Remove.
8921         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8922
8923 2019-02-07  Tom Tromey  <tom@tromey.com>
8924
8925         * yy-remap.h: Add include guard.
8926         * xtensa-tdep.h: Add include guard.
8927         * xcoffread.h: Rename include guard.
8928         * varobj-iter.h: Add include guard.
8929         * tui/tui.h: Rename include guard.
8930         * tui/tui-winsource.h: Rename include guard.
8931         * tui/tui-wingeneral.h: Rename include guard.
8932         * tui/tui-windata.h: Rename include guard.
8933         * tui/tui-win.h: Rename include guard.
8934         * tui/tui-stack.h: Rename include guard.
8935         * tui/tui-source.h: Rename include guard.
8936         * tui/tui-regs.h: Rename include guard.
8937         * tui/tui-out.h: Rename include guard.
8938         * tui/tui-layout.h: Rename include guard.
8939         * tui/tui-io.h: Rename include guard.
8940         * tui/tui-hooks.h: Rename include guard.
8941         * tui/tui-file.h: Rename include guard.
8942         * tui/tui-disasm.h: Rename include guard.
8943         * tui/tui-data.h: Rename include guard.
8944         * tui/tui-command.h: Rename include guard.
8945         * tic6x-tdep.h: Add include guard.
8946         * target/waitstatus.h: Rename include guard.
8947         * target/wait.h: Rename include guard.
8948         * target/target.h: Rename include guard.
8949         * target/resume.h: Rename include guard.
8950         * target-float.h: Rename include guard.
8951         * stabsread.h: Add include guard.
8952         * rs6000-tdep.h: Add include guard.
8953         * riscv-fbsd-tdep.h: Add include guard.
8954         * regformats/regdef.h: Rename include guard.
8955         * record.h: Rename include guard.
8956         * python/python.h: Rename include guard.
8957         * python/python-internal.h: Rename include guard.
8958         * python/py-stopevent.h: Rename include guard.
8959         * python/py-ref.h: Rename include guard.
8960         * python/py-record.h: Rename include guard.
8961         * python/py-record-full.h: Rename include guard.
8962         * python/py-record-btrace.h: Rename include guard.
8963         * python/py-instruction.h: Rename include guard.
8964         * python/py-events.h: Rename include guard.
8965         * python/py-event.h: Rename include guard.
8966         * procfs.h: Add include guard.
8967         * proc-utils.h: Add include guard.
8968         * p-lang.h: Add include guard.
8969         * or1k-tdep.h: Rename include guard.
8970         * observable.h: Rename include guard.
8971         * nto-tdep.h: Rename include guard.
8972         * nat/x86-linux.h: Rename include guard.
8973         * nat/x86-linux-dregs.h: Rename include guard.
8974         * nat/x86-gcc-cpuid.h: Add include guard.
8975         * nat/x86-dregs.h: Rename include guard.
8976         * nat/x86-cpuid.h: Rename include guard.
8977         * nat/ppc-linux.h: Rename include guard.
8978         * nat/mips-linux-watch.h: Rename include guard.
8979         * nat/linux-waitpid.h: Rename include guard.
8980         * nat/linux-ptrace.h: Rename include guard.
8981         * nat/linux-procfs.h: Rename include guard.
8982         * nat/linux-osdata.h: Rename include guard.
8983         * nat/linux-nat.h: Rename include guard.
8984         * nat/linux-namespaces.h: Rename include guard.
8985         * nat/linux-btrace.h: Rename include guard.
8986         * nat/glibc_thread_db.h: Rename include guard.
8987         * nat/gdb_thread_db.h: Rename include guard.
8988         * nat/gdb_ptrace.h: Rename include guard.
8989         * nat/fork-inferior.h: Rename include guard.
8990         * nat/amd64-linux-siginfo.h: Rename include guard.
8991         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8992         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8993         * nat/aarch64-linux.h: Rename include guard.
8994         * nat/aarch64-linux-hw-point.h: Rename include guard.
8995         * mn10300-tdep.h: Add include guard.
8996         * mips-linux-tdep.h: Add include guard.
8997         * mi/mi-parse.h: Rename include guard.
8998         * mi/mi-out.h: Rename include guard.
8999         * mi/mi-main.h: Rename include guard.
9000         * mi/mi-interp.h: Rename include guard.
9001         * mi/mi-getopt.h: Rename include guard.
9002         * mi/mi-console.h: Rename include guard.
9003         * mi/mi-common.h: Rename include guard.
9004         * mi/mi-cmds.h: Rename include guard.
9005         * mi/mi-cmd-break.h: Rename include guard.
9006         * m2-lang.h: Add include guard.
9007         * location.h: Rename include guard.
9008         * linux-record.h: Rename include guard.
9009         * linux-nat.h: Add include guard.
9010         * linux-fork.h: Add include guard.
9011         * i386-darwin-tdep.h: Rename include guard.
9012         * hppa-linux-offsets.h: Add include guard.
9013         * guile/guile.h: Rename include guard.
9014         * guile/guile-internal.h: Rename include guard.
9015         * gnu-nat.h: Rename include guard.
9016         * gdb-stabs.h: Rename include guard.
9017         * frv-tdep.h: Add include guard.
9018         * f-lang.h: Add include guard.
9019         * event-loop.h: Add include guard.
9020         * darwin-nat.h: Rename include guard.
9021         * cp-abi.h: Rename include guard.
9022         * config/sparc/nm-sol2.h: Rename include guard.
9023         * config/nm-nto.h: Rename include guard.
9024         * config/nm-linux.h: Add include guard.
9025         * config/i386/nm-i386gnu.h: Rename include guard.
9026         * config/djgpp/nl_types.h: Rename include guard.
9027         * config/djgpp/langinfo.h: Rename include guard.
9028         * compile/gcc-cp-plugin.h: Add include guard.
9029         * compile/gcc-c-plugin.h: Add include guard.
9030         * compile/compile.h: Rename include guard.
9031         * compile/compile-object-run.h: Rename include guard.
9032         * compile/compile-object-load.h: Rename include guard.
9033         * compile/compile-internal.h: Rename include guard.
9034         * compile/compile-cplus.h: Rename include guard.
9035         * compile/compile-c.h: Rename include guard.
9036         * common/xml-utils.h: Rename include guard.
9037         * common/x86-xstate.h: Rename include guard.
9038         * common/version.h: Rename include guard.
9039         * common/vec.h: Rename include guard.
9040         * common/tdesc.h: Rename include guard.
9041         * common/selftest.h: Rename include guard.
9042         * common/scoped_restore.h: Rename include guard.
9043         * common/scoped_mmap.h: Rename include guard.
9044         * common/scoped_fd.h: Rename include guard.
9045         * common/safe-iterator.h: Rename include guard.
9046         * common/run-time-clock.h: Rename include guard.
9047         * common/refcounted-object.h: Rename include guard.
9048         * common/queue.h: Rename include guard.
9049         * common/ptid.h: Rename include guard.
9050         * common/print-utils.h: Rename include guard.
9051         * common/preprocessor.h: Rename include guard.
9052         * common/pathstuff.h: Rename include guard.
9053         * common/observable.h: Rename include guard.
9054         * common/netstuff.h: Rename include guard.
9055         * common/job-control.h: Rename include guard.
9056         * common/host-defs.h: Rename include guard.
9057         * common/gdb_wait.h: Rename include guard.
9058         * common/gdb_vecs.h: Rename include guard.
9059         * common/gdb_unlinker.h: Rename include guard.
9060         * common/gdb_unique_ptr.h: Rename include guard.
9061         * common/gdb_tilde_expand.h: Rename include guard.
9062         * common/gdb_sys_time.h: Rename include guard.
9063         * common/gdb_string_view.h: Rename include guard.
9064         * common/gdb_splay_tree.h: Rename include guard.
9065         * common/gdb_setjmp.h: Rename include guard.
9066         * common/gdb_ref_ptr.h: Rename include guard.
9067         * common/gdb_optional.h: Rename include guard.
9068         * common/gdb_locale.h: Rename include guard.
9069         * common/gdb_assert.h: Rename include guard.
9070         * common/filtered-iterator.h: Rename include guard.
9071         * common/filestuff.h: Rename include guard.
9072         * common/fileio.h: Rename include guard.
9073         * common/environ.h: Rename include guard.
9074         * common/common-utils.h: Rename include guard.
9075         * common/common-types.h: Rename include guard.
9076         * common/common-regcache.h: Rename include guard.
9077         * common/common-inferior.h: Rename include guard.
9078         * common/common-gdbthread.h: Rename include guard.
9079         * common/common-exceptions.h: Rename include guard.
9080         * common/common-defs.h: Rename include guard.
9081         * common/common-debug.h: Rename include guard.
9082         * common/cleanups.h: Rename include guard.
9083         * common/buffer.h: Rename include guard.
9084         * common/btrace-common.h: Rename include guard.
9085         * common/break-common.h: Rename include guard.
9086         * cli/cli-utils.h: Rename include guard.
9087         * cli/cli-style.h: Rename include guard.
9088         * cli/cli-setshow.h: Rename include guard.
9089         * cli/cli-script.h: Rename include guard.
9090         * cli/cli-interp.h: Rename include guard.
9091         * cli/cli-decode.h: Rename include guard.
9092         * cli/cli-cmds.h: Rename include guard.
9093         * charset-list.h: Add include guard.
9094         * buildsym-legacy.h: Rename include guard.
9095         * bfin-tdep.h: Add include guard.
9096         * ax.h: Rename include guard.
9097         * arm-linux-tdep.h: Add include guard.
9098         * arm-fbsd-tdep.h: Add include guard.
9099         * arch/xtensa.h: Rename include guard.
9100         * arch/tic6x.h: Add include guard.
9101         * arch/i386.h: Add include guard.
9102         * arch/arm.h: Rename include guard.
9103         * arch/arm-linux.h: Rename include guard.
9104         * arch/arm-get-next-pcs.h: Rename include guard.
9105         * arch/amd64.h: Add include guard.
9106         * arch/aarch64-insn.h: Rename include guard.
9107         * arch-utils.h: Rename include guard.
9108         * annotate.h: Add include guard.
9109         * amd64-darwin-tdep.h: Rename include guard.
9110         * aarch64-linux-tdep.h: Add include guard.
9111         * aarch64-fbsd-tdep.h: Add include guard.
9112         * aarch32-linux-nat.h: Add include guard.
9113
9114 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9115
9116         * macrotab.c (macro_define_internal): New function that
9117         factorizes macro_define_object_internal and macro_define_function
9118         code.
9119         (macro_define_object_internal): Use macro_define_internal.
9120         (macro_define_function): Likewise.
9121
9122 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9123
9124         * macrocmd.c (extract_identifier): Return
9125         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9126         callers.
9127
9128 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9129
9130         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9131
9132 2019-02-05  Tom Tromey  <tom@tromey.com>
9133
9134         * target.c (target_stack::unpush): Move assertion earlier.
9135
9136 2019-01-30  Tom Tromey  <tom@tromey.com>
9137
9138         PR python/23615:
9139         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9140         (gdbpy_parse_and_eval): Likewise.
9141         * python/python-internal.h (gdbpy_allow_threads): New class.
9142
9143 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9144
9145         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9146         (aarch64_fbsd_fpregmap): Move earlier.
9147         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9148         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9149         instead of individual calls to trad_frame_set_reg_addr.
9150         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9151         earlier.
9152         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9153         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9154         instead of individual calls to trad_frame_set_reg_addr.
9155
9156 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9157
9158         * CONTRIBUTE: Replace contribution list with wiki link.
9159
9160 2019-01-25  Tom Tromey  <tom@tromey.com>
9161
9162         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9163
9164 2019-01-25  Tom Tromey  <tom@tromey.com>
9165
9166         * xtensa-linux-nat.c: Fix common/ includes.
9167         * xml-support.h: Fix common/ includes.
9168         * xml-support.c: Fix common/ includes.
9169         * x86-linux-nat.c: Fix common/ includes.
9170         * windows-nat.c: Fix common/ includes.
9171         * varobj.h: Fix common/ includes.
9172         * varobj.c: Fix common/ includes.
9173         * value.c: Fix common/ includes.
9174         * valops.c: Fix common/ includes.
9175         * utils.c: Fix common/ includes.
9176         * unittests/xml-utils-selftests.c: Fix common/ includes.
9177         * unittests/utils-selftests.c: Fix common/ includes.
9178         * unittests/unpack-selftests.c: Fix common/ includes.
9179         * unittests/tracepoint-selftests.c: Fix common/ includes.
9180         * unittests/style-selftests.c: Fix common/ includes.
9181         * unittests/string_view-selftests.c: Fix common/ includes.
9182         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9183         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9184         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9185         * unittests/rsp-low-selftests.c: Fix common/ includes.
9186         * unittests/parse-connection-spec-selftests.c: Fix common/
9187         includes.
9188         * unittests/optional-selftests.c: Fix common/ includes.
9189         * unittests/offset-type-selftests.c: Fix common/ includes.
9190         * unittests/observable-selftests.c: Fix common/ includes.
9191         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9192         * unittests/memrange-selftests.c: Fix common/ includes.
9193         * unittests/memory-map-selftests.c: Fix common/ includes.
9194         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9195         * unittests/function-view-selftests.c: Fix common/ includes.
9196         * unittests/environ-selftests.c: Fix common/ includes.
9197         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9198         * unittests/common-utils-selftests.c: Fix common/ includes.
9199         * unittests/cli-utils-selftests.c: Fix common/ includes.
9200         * unittests/array-view-selftests.c: Fix common/ includes.
9201         * ui-file.c: Fix common/ includes.
9202         * tui/tui-io.c: Fix common/ includes.
9203         * tracepoint.h: Fix common/ includes.
9204         * tracepoint.c: Fix common/ includes.
9205         * tracefile-tfile.c: Fix common/ includes.
9206         * top.h: Fix common/ includes.
9207         * top.c: Fix common/ includes.
9208         * thread.c: Fix common/ includes.
9209         * target/waitstatus.h: Fix common/ includes.
9210         * target/waitstatus.c: Fix common/ includes.
9211         * target.h: Fix common/ includes.
9212         * target.c: Fix common/ includes.
9213         * target-memory.c: Fix common/ includes.
9214         * target-descriptions.c: Fix common/ includes.
9215         * symtab.h: Fix common/ includes.
9216         * symfile.c: Fix common/ includes.
9217         * stap-probe.c: Fix common/ includes.
9218         * spu-linux-nat.c: Fix common/ includes.
9219         * sparc-nat.c: Fix common/ includes.
9220         * source.c: Fix common/ includes.
9221         * solib.c: Fix common/ includes.
9222         * solib-target.c: Fix common/ includes.
9223         * ser-unix.c: Fix common/ includes.
9224         * ser-tcp.c: Fix common/ includes.
9225         * ser-pipe.c: Fix common/ includes.
9226         * ser-base.c: Fix common/ includes.
9227         * selftest-arch.c: Fix common/ includes.
9228         * s12z-tdep.c: Fix common/ includes.
9229         * rust-exp.y: Fix common/ includes.
9230         * rs6000-aix-tdep.c: Fix common/ includes.
9231         * riscv-tdep.c: Fix common/ includes.
9232         * remote.c: Fix common/ includes.
9233         * remote-notif.h: Fix common/ includes.
9234         * remote-fileio.h: Fix common/ includes.
9235         * remote-fileio.c: Fix common/ includes.
9236         * regcache.h: Fix common/ includes.
9237         * regcache.c: Fix common/ includes.
9238         * record-btrace.c: Fix common/ includes.
9239         * python/python.c: Fix common/ includes.
9240         * python/py-type.c: Fix common/ includes.
9241         * python/py-inferior.c: Fix common/ includes.
9242         * progspace.h: Fix common/ includes.
9243         * producer.c: Fix common/ includes.
9244         * procfs.c: Fix common/ includes.
9245         * proc-api.c: Fix common/ includes.
9246         * printcmd.c: Fix common/ includes.
9247         * ppc-linux-nat.c: Fix common/ includes.
9248         * parser-defs.h: Fix common/ includes.
9249         * osdata.c: Fix common/ includes.
9250         * obsd-nat.c: Fix common/ includes.
9251         * nat/x86-linux.c: Fix common/ includes.
9252         * nat/x86-linux-dregs.c: Fix common/ includes.
9253         * nat/x86-dregs.h: Fix common/ includes.
9254         * nat/x86-dregs.c: Fix common/ includes.
9255         * nat/ppc-linux.c: Fix common/ includes.
9256         * nat/mips-linux-watch.h: Fix common/ includes.
9257         * nat/mips-linux-watch.c: Fix common/ includes.
9258         * nat/linux-waitpid.c: Fix common/ includes.
9259         * nat/linux-ptrace.h: Fix common/ includes.
9260         * nat/linux-ptrace.c: Fix common/ includes.
9261         * nat/linux-procfs.c: Fix common/ includes.
9262         * nat/linux-personality.c: Fix common/ includes.
9263         * nat/linux-osdata.c: Fix common/ includes.
9264         * nat/linux-namespaces.c: Fix common/ includes.
9265         * nat/linux-btrace.h: Fix common/ includes.
9266         * nat/linux-btrace.c: Fix common/ includes.
9267         * nat/fork-inferior.c: Fix common/ includes.
9268         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9269         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9270         * nat/aarch64-linux.c: Fix common/ includes.
9271         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9272         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9273         * namespace.h: Fix common/ includes.
9274         * mips-linux-tdep.c: Fix common/ includes.
9275         * minsyms.c: Fix common/ includes.
9276         * mi/mi-parse.h: Fix common/ includes.
9277         * mi/mi-main.c: Fix common/ includes.
9278         * mi/mi-cmd-env.c: Fix common/ includes.
9279         * memrange.h: Fix common/ includes.
9280         * memattr.c: Fix common/ includes.
9281         * maint.h: Fix common/ includes.
9282         * maint.c: Fix common/ includes.
9283         * main.c: Fix common/ includes.
9284         * machoread.c: Fix common/ includes.
9285         * location.c: Fix common/ includes.
9286         * linux-thread-db.c: Fix common/ includes.
9287         * linux-nat.c: Fix common/ includes.
9288         * linux-fork.c: Fix common/ includes.
9289         * inline-frame.c: Fix common/ includes.
9290         * infrun.c: Fix common/ includes.
9291         * inflow.c: Fix common/ includes.
9292         * inferior.h: Fix common/ includes.
9293         * inferior.c: Fix common/ includes.
9294         * infcmd.c: Fix common/ includes.
9295         * inf-ptrace.c: Fix common/ includes.
9296         * inf-child.c: Fix common/ includes.
9297         * ia64-linux-nat.c: Fix common/ includes.
9298         * i387-tdep.c: Fix common/ includes.
9299         * i386-tdep.c: Fix common/ includes.
9300         * i386-linux-tdep.c: Fix common/ includes.
9301         * i386-linux-nat.c: Fix common/ includes.
9302         * i386-go32-tdep.c: Fix common/ includes.
9303         * i386-fbsd-tdep.c: Fix common/ includes.
9304         * i386-fbsd-nat.c: Fix common/ includes.
9305         * guile/scm-type.c: Fix common/ includes.
9306         * guile/guile.c: Fix common/ includes.
9307         * go32-nat.c: Fix common/ includes.
9308         * gnu-nat.c: Fix common/ includes.
9309         * gdbthread.h: Fix common/ includes.
9310         * gdbarch-selftests.c: Fix common/ includes.
9311         * gdb_usleep.c: Fix common/ includes.
9312         * gdb_select.h: Fix common/ includes.
9313         * gdb_bfd.c: Fix common/ includes.
9314         * gcore.c: Fix common/ includes.
9315         * fork-child.c: Fix common/ includes.
9316         * findvar.c: Fix common/ includes.
9317         * fbsd-nat.c: Fix common/ includes.
9318         * event-top.c: Fix common/ includes.
9319         * event-loop.c: Fix common/ includes.
9320         * dwarf2read.c: Fix common/ includes.
9321         * dwarf2loc.c: Fix common/ includes.
9322         * dwarf2-frame.c: Fix common/ includes.
9323         * dwarf-index-cache.c: Fix common/ includes.
9324         * dtrace-probe.c: Fix common/ includes.
9325         * disasm-selftests.c: Fix common/ includes.
9326         * defs.h: Fix common/ includes.
9327         * csky-tdep.c: Fix common/ includes.
9328         * cp-valprint.c: Fix common/ includes.
9329         * cp-support.h: Fix common/ includes.
9330         * cp-support.c: Fix common/ includes.
9331         * corelow.c: Fix common/ includes.
9332         * completer.h: Fix common/ includes.
9333         * completer.c: Fix common/ includes.
9334         * compile/compile.c: Fix common/ includes.
9335         * compile/compile-loc2c.c: Fix common/ includes.
9336         * compile/compile-cplus-types.c: Fix common/ includes.
9337         * compile/compile-cplus-symbols.c: Fix common/ includes.
9338         * command.h: Fix common/ includes.
9339         * cli/cli-dump.c: Fix common/ includes.
9340         * cli/cli-cmds.c: Fix common/ includes.
9341         * charset.c: Fix common/ includes.
9342         * build-id.c: Fix common/ includes.
9343         * btrace.h: Fix common/ includes.
9344         * btrace.c: Fix common/ includes.
9345         * breakpoint.h: Fix common/ includes.
9346         * breakpoint.c: Fix common/ includes.
9347         * ax.h:
9348         (enum agent_op): Fix common/ includes.
9349         * ax-general.c (struct aop_map): Fix common/ includes.
9350         * ax-gdb.c: Fix common/ includes.
9351         * auxv.c: Fix common/ includes.
9352         * auto-load.c: Fix common/ includes.
9353         * arm-tdep.c: Fix common/ includes.
9354         * arch/riscv.c: Fix common/ includes.
9355         * arch/ppc-linux-common.c: Fix common/ includes.
9356         * arch/i386.c: Fix common/ includes.
9357         * arch/arm.c: Fix common/ includes.
9358         * arch/arm-linux.c: Fix common/ includes.
9359         * arch/arm-get-next-pcs.c: Fix common/ includes.
9360         * arch/amd64.c: Fix common/ includes.
9361         * arch/aarch64.c: Fix common/ includes.
9362         * arch/aarch64-insn.c: Fix common/ includes.
9363         * arch-utils.c: Fix common/ includes.
9364         * amd64-windows-tdep.c: Fix common/ includes.
9365         * amd64-tdep.c: Fix common/ includes.
9366         * amd64-sol2-tdep.c: Fix common/ includes.
9367         * amd64-obsd-tdep.c: Fix common/ includes.
9368         * amd64-nbsd-tdep.c: Fix common/ includes.
9369         * amd64-linux-tdep.c: Fix common/ includes.
9370         * amd64-linux-nat.c: Fix common/ includes.
9371         * amd64-fbsd-tdep.c: Fix common/ includes.
9372         * amd64-fbsd-nat.c: Fix common/ includes.
9373         * amd64-dicos-tdep.c: Fix common/ includes.
9374         * amd64-darwin-tdep.c: Fix common/ includes.
9375         * agent.c: Fix common/ includes.
9376         * ada-lang.h: Fix common/ includes.
9377         * ada-lang.c: Fix common/ includes.
9378         * aarch64-tdep.c: Fix common/ includes.
9379
9380 2019-01-25  Tom Tromey  <tom@tromey.com>
9381
9382         * common/create-version.sh: Use common/version.h.
9383
9384 2019-01-24  Pedro Alves  <palves@redhat.com>
9385
9386         * infrun.c (signal_stop, signal_print, signal_program)
9387         (signal_catch, signal_pass): Now arrays instead of pointers.
9388         (update_signals_program_target, do_target_resume)
9389         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9390         * linux-nat.c (linux_nat_target::pass_signals)
9391         (linux_nat_target::create_inferior, linux_nat_target::attach):
9392         Adjust.
9393         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9394         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9395         * procfs.c (procfs_target::pass_signals): Adjust.
9396         * record-full.c (record_full_target::resume): Adjust.
9397         * remote.c (remote_target::pass_signals)
9398         (remote_target::program_signals): Adjust.
9399         * target-debug.h (target_debug_print_signals): Now takes a
9400         gdb::array_view as parameter.  Adjust.
9401         * target.h (target_ops) <pass_signals, program_signals>: Replace
9402         pointer and length parameters with gdb::array_view.
9403         (target_pass_signals, target_program_signals): Likewise.
9404         * target-delegates.c: Regenerate.
9405
9406 2019-01-24  Pedro Alves  <palves@redhat.com>
9407
9408         * common/forward-scope-exit.h
9409         (forward_scope_exit::forward_scope_exit): Pass arguments to
9410         m_bind_function directly, instead of creating a std::bind and
9411         copying that.
9412
9413 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9414
9415         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9416         for static members.
9417         (pass_in_v_vfp_candidate): Likewise.
9418
9419 2019-01-23  Tom Tromey  <tom@tromey.com>
9420             Pedro Alves  <palves@redhat.com>
9421
9422         * regcache.c (class regcache_invalidator): Remove.
9423         (regcache::raw_write): Use make_scope_exit.
9424
9425 2019-01-23  Tom Tromey  <tom@tromey.com>
9426
9427         * ui-out.h (class ui_out_emit_type): Update comment.
9428
9429 2019-01-23  Tom Tromey  <tom@tromey.com>
9430
9431         * infrun.c (fetch_inferior_event): Update comment.
9432
9433 2019-01-23  Tom Tromey  <tom@tromey.com>
9434             Pedro Alves  <palves@redhat.com>
9435
9436         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9437         parameter.
9438         (fetch_inferior_event): Use SCOPE_EXIT.
9439
9440
9441 2019-01-23  Tom Tromey  <tom@tromey.com>
9442             Pedro Alves  <palves@redhat.com>
9443
9444         * infrun.c (disable_thread_events): Delete.
9445         (stop_all_threads): Use SCOPE_EXIT.
9446
9447 2019-01-23  Tom Tromey  <tom@tromey.com>
9448             Pedro Alves  <palves@redhat.com>
9449
9450         * symfile.c: Include forward-scope-exit.h.
9451         (clear_symtab_users_cleanup): Replace forward declaration with
9452         a FORWARD_SCOPE_EXIT.
9453         (syms_from_objfile_1): Use the forward_scope_exit and
9454         gdb::optional instead of cleanup_function.
9455         (reread_symbols): Use the forward_scope_exit instead of
9456         cleanup_function.
9457         (clear_symtab_users_cleanup): Remove function.
9458
9459 2019-01-23  Tom Tromey  <tom@tromey.com>
9460             Pedro Alves  <palves@redhat.com>
9461
9462         * linux-nat.c: Include scope-exit.h.
9463         (cleanup_target_stop): Remove.
9464         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9465         SCOPE_EXIT.
9466
9467 2019-01-23  Tom Tromey  <tom@tromey.com>
9468             Pedro Alves  <palves@redhat.com>
9469
9470         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9471         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9472
9473 2019-01-23  Tom Tromey  <tom@tromey.com>
9474             Andrew Burgess  <andrew.burgess@embecosm.com>
9475             Pedro Alves  <palves@redhat.com>
9476
9477         * infrun.c (fetch_inferior_event): Use scope_exit.
9478         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9479         * top.c (execute_command): Use scope_exit.
9480         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9481         * utils.c (do_bpstat_clear_actions_cleanup)
9482         (make_bpstat_clear_actions_cleanup): Remove.
9483
9484 2019-01-23  Tom Tromey  <tom@tromey.com>
9485             Pedro Alves  <palves@redhat.com>
9486
9487         * infrun.c: Include "common/scope-exit.h"
9488         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9489         (wait_for_inferior): Use SCOPE_EXIT.
9490         (fetch_inferior_event): Use scope_exit.
9491
9492 2019-01-23  Tom Tromey  <tom@tromey.com>
9493             Pedro Alves  <palves@redhat.com>
9494
9495         * breakpoint.c (create_breakpoint): Remove cleanup.
9496
9497 2019-01-23  Tom Tromey  <tom@tromey.com>
9498             Andrew Burgess  <andrew.burgess@embecosm.com>
9499             Pedro Alves  <palves@redhat.com>
9500
9501 2019-01-23  Pedro Alves  <palves@redhat.com>
9502
9503         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9504
9505 2019-01-23  Pedro Alves  <palves@redhat.com>
9506             Andrew Burgess  <andrew.burgess@embecosm.com>
9507
9508         * gdbthread.h: Include "common/forward-scope-exit.h".
9509         (scoped_finish_thread_state): Redefine custom class in terms of
9510         forward_scope_exit.
9511
9512 2019-01-23  Pedro Alves  <palves@redhat.com>
9513             Andrew Burgess  <andrew.burgess@embecosm.com>
9514
9515         * common/forward-scope-exit.h: New file.
9516
9517 2019-01-23  Pedro Alves  <palves@redhat.com>
9518             Andrew Burgess  <andrew.burgess@embecosm.com>
9519             Tom Tromey  <tom@tromey.com>
9520
9521         * common/scope-exit.h: New file.
9522
9523 2019-01-23  Pedro Alves  <palves@redhat.com>
9524
9525         * common/preprocessor.h (ESC): Rename to ...
9526         (ESC_PARENS): ... this.
9527         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9528         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9529
9530 2019-01-23  Tom Tromey  <tom@tromey.com>
9531
9532         * language.h (class scoped_switch_to_sym_language_if_auto):
9533         Initialize m_lang in both cases.
9534
9535 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9536
9537         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9538         with XCNEW.
9539
9540 2019-01-22  Tom Tromey  <tom@tromey.com>
9541
9542         * corelow.c: Do not include sys/file.h.
9543
9544 2019-01-22  Tom Tromey  <tom@tromey.com>
9545
9546         * tui/tui-wingeneral.h: Include gdb_curses.h.
9547
9548 2019-01-22  Tom Tromey  <tom@tromey.com>
9549
9550         * source-cache.h (class source_cache) <get_source_lines,
9551         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9552
9553 2019-01-22  Tom Tromey  <tom@tromey.com>
9554
9555         * remote-fileio.h (struct remote_target): Declare.
9556
9557 2019-01-22  Tom Tromey  <tom@tromey.com>
9558
9559         * python/py-arch.c: Do not include py-ref.h.
9560         * python/py-bpevent.c: Do not include py-ref.h.
9561         * python/py-cmd.c: Do not include py-ref.h.
9562         * python/py-continueevent.c: Do not include py-ref.h.
9563         * python/py-event.h: Do not include py-ref.h.
9564         * python/py-evtregistry.c: Do not include py-ref.h.
9565         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9566         * python/py-frame.c: Do not include py-ref.h.
9567         * python/py-framefilter.c: Do not include py-ref.h.
9568         * python/py-function.c: Do not include py-ref.h.
9569         * python/py-infevents.c: Do not include py-ref.h.
9570         * python/py-linetable.c: Do not include py-ref.h.
9571         * python/py-objfile.c: Do not include py-ref.h.
9572         * python/py-param.c: Do not include py-ref.h.
9573         * python/py-prettyprint.c: Do not include py-ref.h.
9574         * python/py-progspace.c: Do not include py-ref.h.
9575         * python/py-symbol.c: Do not include py-ref.h.
9576         * python/py-symtab.c: Do not include py-ref.h.
9577         * python/py-type.c: Do not include py-ref.h.
9578         * python/py-unwind.c: Do not include py-ref.h.
9579         * python/py-utils.c: Do not include py-ref.h.
9580         * python/py-value.c: Do not include py-ref.h.
9581         * python/py-varobj.c: Do not include py-ref.h.
9582         * python/py-xmethods.c: Do not include py-ref.h.
9583         * python/python.c: Do not include py-ref.h.
9584         * varobj.c: Do not include py-ref.h.
9585
9586 2019-01-22  Tom Tromey  <tom@tromey.com>
9587
9588         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9589         keyword for bcache.
9590
9591 2019-01-22  Tom Tromey  <tom@tromey.com>
9592
9593         * compile/compile-cplus-types.c: Remove a comment by #include.
9594
9595 2019-01-22  Tom Tromey  <tom@tromey.com>
9596
9597         * compile/gcc-c-plugin.h: Include compile-internal.h.
9598
9599 2019-01-22  Tom Tromey  <tom@tromey.com>
9600
9601         * stabsread.c (EXTERN): Do not define.
9602         (symnum, next_symbol_text_func, processing_gcc_compilation)
9603         (within_function, global_sym_chain, global_stabs)
9604         (previous_stab_code, this_object_header_files)
9605         (n_this_object_header_files)
9606         (n_allocated_this_object_header_files): Define.
9607         * stabsread.h (EXTERN): Never define.  Use "extern".
9608
9609 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9610
9611         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9612         history_value.
9613
9614 2019-01-21  Tom Tromey  <tom@tromey.com>
9615
9616         * ui-out.c: Fix includes.
9617         * tui/tui-source.c: Fix includes.
9618         * target.c: Fix includes.
9619         * remote.c: Fix includes.
9620         * regcache.c: Fix includes.
9621         * python/py-block.c: Fix includes.
9622         * printcmd.c: Fix includes.
9623         * or1k-tdep.c: Fix includes.
9624         * mi/mi-main.c: Fix includes.
9625         * m32r-tdep.c: Fix includes.
9626         * csky-tdep.c: Fix includes.
9627         * compile/compile-cplus-types.c: Fix includes.
9628         * cli/cli-interp.c: Fix includes.
9629
9630 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9631
9632         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9633         for padding.
9634
9635 2019-01-16  Tom Tromey  <tom@tromey.com>
9636
9637         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9638         earlier.
9639         (struct objfile) <msymbols_range>: Move from top level.
9640         <msymbols>: New method.
9641         (class objfile_msymbols): Remove.
9642         * symtab.c (default_collect_symbol_completion_matches_break_on):
9643         Update.
9644         * symmisc.c (dump_msymbols): Update.
9645         * stabsread.c (scan_file_globals): Update.
9646         * objc-lang.c (info_selectors_command, info_classes_command)
9647         (find_methods): Update.
9648         * minsyms.c (find_solib_trampoline_target): Update.
9649         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9650         * coffread.c (coff_symfile_read): Update.
9651         * ada-lang.c (ada_lookup_simple_minsym)
9652         (ada_collect_symbol_completion_matches): Update.
9653
9654 2019-01-16  Tom Tromey  <tom@tromey.com>
9655
9656         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9657         type.  Remove no-argument constructor.
9658         <iterator::operator++>: Simplify.
9659         <begin>: Update.
9660         <end>: Use minimal_symbol_count.
9661
9662 2019-01-16  Tom Tromey  <tom@tromey.com>
9663
9664         * objfiles.h (struct objfile) <psymtabs>: New method.
9665         (class objfile_psymtabs): Remove.
9666         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9667         typedef.
9668         <range>: New method.
9669         (require_partial_symbols): Change return type.
9670         * psymtab.c (require_partial_symbols)
9671         (psym_expand_symtabs_matching): Update.
9672         * mdebugread.c (parse_partial_symbols): Update.
9673         * dbxread.c (dbx_end_psymtab): Update.
9674
9675 2019-01-15  Tom Tromey  <tom@tromey.com>
9676
9677         * symtab.c (lookup_objfile_from_block)
9678         (lookup_symbol_in_objfile_symtabs)
9679         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9680         (find_line_symtab, info_sources_command)
9681         (default_collect_symbol_completion_matches_break_on)
9682         (make_source_files_completion_list): Update.
9683         * symmisc.c (print_objfile_statistics, dump_objfile)
9684         (maintenance_print_symbols, maintenance_info_symtabs)
9685         (maintenance_check_symtabs, maintenance_info_line_tables):
9686         Update.
9687         * source.c (select_source_symtab)
9688         (forget_cached_source_info_for_objfile): Update.
9689         * objfiles.h (class objfile_compunits): Remove.
9690         (struct objfile) <compunits_range>: New typedef.
9691         (compunits): New method.
9692         * objfiles.c (objfile_relocate1): Update.
9693         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9694         * maint.c (count_symtabs_and_blocks): Update.
9695         * linespec.c (iterate_over_all_matching_symtabs): Update.
9696         * cp-support.c (add_symbol_overload_list_qualified): Update.
9697         * coffread.c (coff_symtab_read): Update.
9698         * ada-lang.c (add_nonlocal_symbols)
9699         (ada_collect_symbol_completion_matches)
9700         (ada_add_global_exceptions): Update.
9701
9702 2019-01-15  Tom Tromey  <tom@tromey.com>
9703
9704         * progspace.h (program_space) <objfiles_safe_range>: New
9705         typedef.
9706         <objfiles_safe>: New method.
9707         * objfiles.h (class all_objfiles_safe): Remove.
9708         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9709         * jit.c (jit_inferior_exit_hook): Update.
9710
9711 2019-01-17  Tom Tromey  <tom@tromey.com>
9712
9713         * progspace.h (program_space) <objfiles_range>: New typedef.
9714         <objfiles>: New method.
9715         <objfiles_head>: Rename from objfiles.
9716         (object_files): Update.
9717         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9718         * guile/scm-pretty-print.c
9719         (ppscm_find_pretty_printer_from_objfiles): Update.
9720         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9721         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9722         Update.
9723         * python/py-progspace.c (pspy_get_objfiles): Update.
9724         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9725         Update.
9726         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9727         (objfpy_lookup_objfile_by_build_id): Update.
9728         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9729         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9730         Update.
9731         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9732         (expand_symtab_containing_pc, lookup_objfile_from_block)
9733         (lookup_static_symbol, basic_lookup_transparent_type)
9734         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9735         (find_line_symtab, info_sources_command)
9736         (default_collect_symbol_completion_matches_break_on)
9737         (make_source_files_completion_list, find_main_name): Update.
9738         * symmisc.c (print_symbol_bcache_statistics)
9739         (print_objfile_statistics, maintenance_print_symbols)
9740         (maintenance_print_msymbols, maintenance_print_objfiles)
9741         (maintenance_info_symtabs, maintenance_check_symtabs)
9742         (maintenance_expand_symtabs, maintenance_info_line_tables):
9743         Update.
9744         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9745         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9746         (map_overlay_command, unmap_overlay_command)
9747         (simple_overlay_update, expand_symtabs_matching)
9748         (map_symbol_filenames): Update.
9749         * symfile-debug.c (set_debug_symfile): Update.
9750         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9751         Update.
9752         * source.c (select_source_symtab, forget_cached_source_info):
9753         Update.
9754         * solib.c (solib_read_symbols): Update.
9755         * solib-spu.c (append_ocl_sos): Update.
9756         * psymtab.c (maintenance_print_psymbols)
9757         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9758         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9759         * printcmd.c (info_symbol_command): Update.
9760         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9761         Update.
9762         * objfiles.h (class all_objfiles): Remove.
9763         * objfiles.c (have_partial_symbols, have_full_symbols)
9764         (have_minimal_symbols, qsort_cmp, update_section_map)
9765         (shared_objfile_contains_address_p)
9766         (default_iterate_over_objfiles_in_search_order): Update.
9767         * objc-lang.c (info_selectors_command, info_classes_command)
9768         (find_methods): Update.
9769         * minsyms.c (find_solib_trampoline_target): Update.
9770         * maint.c (maintenance_info_sections)
9771         (maintenance_translate_address, count_symtabs_and_blocks):
9772         Update.
9773         * main.c (captured_main_1): Update.
9774         * linux-thread-db.c (try_thread_db_load_from_pdir)
9775         (has_libpthread): Update.
9776         * linespec.c (iterate_over_all_matching_symtabs)
9777         (search_minsyms_for_name): Update.
9778         * jit.c (jit_find_objf_with_entry_addr): Update.
9779         * hppa-tdep.c (find_unwind_entry)
9780         (hppa_lookup_stub_minimal_symbol): Update.
9781         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9782         Update.
9783         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9784         (elf_gnu_ifunc_resolve_by_got): Update.
9785         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9786         * dwarf-index-write.c (save_gdb_index_command): Update.
9787         * cp-support.c (add_symbol_overload_list_qualified): Update.
9788         * breakpoint.c (create_overlay_event_breakpoint)
9789         (create_longjmp_master_breakpoint)
9790         (create_std_terminate_master_breakpoint)
9791         (create_exception_master_breakpoint): Update.
9792         * blockframe.c (find_pc_partial_function): Update.
9793         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9794         (ada_collect_symbol_completion_matches)
9795         (ada_add_global_exceptions): Update.
9796
9797 2019-01-17  Tom Tromey  <tom@tromey.com>
9798
9799         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9800         declare VEC.
9801         (solib_target_parse_libraries): Change return type.
9802         (library_list_start_segment, library_list_start_section)
9803         (library_list_end_library, library_list_start_library); Update.
9804         (solib_target_free_library_list): Remove.
9805         (solib_target_parse_libraries): Remove cleanup.  Change return
9806         type.
9807         (solib_target_current_sos): Update.
9808
9809 2019-01-17  Tom Tromey  <tromey@bapiya>
9810
9811         * valprint.c: Replace "the the" with "the".
9812         * symtab.c: Replace "the the" with "the".
9813         * solib.c: Replace "the the" with "the".
9814         * solib-dsbt.c: Replace "the the" with "the".
9815         * linespec.c: Replace "the the" with "the".
9816         * dwarf2loc.h: Replace "the the" with "the".
9817         * amd64-windows-tdep.c: Replace "the the" with "the".
9818         * aarch64-tdep.c: Replace "the the" with "the".
9819
9820 2019-01-16  Keith Seitz  <keiths@redhat.com>
9821
9822         PR gdb/23773
9823         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9824         <builder>: Rename to ..
9825         <m_builder>: ... this and make private.
9826         (dwarf2_cu::get_builder): New method.  Change all users of
9827         `builder' to use this method.
9828         (dwarf2_start_symtab): Move to ...
9829         (dwarf2_cu::start_symtab): ... here.  Update all callers
9830         (setup_type_unit_groups): Move to ...
9831         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9832         callers.
9833         (dwarf2_cu::reset_builder): New method.
9834         (process_full_compunit, process_full_type_unit): Use
9835         dwarf2_cu::reset_builder.
9836         (follow_die_offset): Record the ancestor CU if it is different
9837         from the followed DIE's CU.
9838         (follow_die_sig_1): Likewise.
9839
9840 2019-01-15  Tom Tromey  <tom@tromey.com>
9841
9842         * remote.c (class remote_state) <buf>: Now a char_vector.
9843         <buf_size>: Remove.
9844         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9845         parameter.
9846         (remote_target::getpkt_or_notif_sane_1)
9847         (remote_target::getpkt_sane)
9848         (remote_target::getpkt_or_notif_sane): Likewise.
9849         (class remote_target) <putpkt>: New overload.
9850         (remote_target::read_frame): Change type of "buf_p".  Remove
9851         sizeof_p parameter.
9852         (packet_ok): New overload.
9853         (packet_check_result): New overload.
9854         Update all uses.
9855
9856 2019-01-14  Tom Tromey  <tom@tromey.com>
9857
9858         * remote-notif.c (handle_notification, remote_notif_ack)
9859         (remote_notif_parse): Make "buf" const.
9860         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9861         const.
9862         (remote_notif_parse, remote_notif_ack, handle_notification):
9863         Likewise.
9864         * remote.c (remote_notif_stop_parse): Make "buf" const.
9865         (remote_target::remote_parse_stop_reply): Make "buf" const.
9866         (remote_notif_stop_ack): Make "buf" const.
9867
9868 2019-01-14  Tom Tromey  <tom@tromey.com>
9869
9870         * remote.c (remote_console_output): Make parameter const.
9871
9872 2019-01-14  Tom Tromey  <tom@tromey.com>
9873
9874         * target-debug.h (target_debug_print_signals): Constify.
9875         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9876         * procfs.c (procfs_target::pass_signals): Update.
9877         * linux-nat.c (linux_nat_target::pass_signals): Update.
9878         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9879         * target-delegates.c: Rebuild.
9880         * remote.c (remote_target::program_signals): Update.
9881         (remote_target::pass_signals): Update.
9882         * target.c (target_pass_signals): Constify argument.
9883         (target_program_signals): Likewise.
9884         * target.h (struct target_ops) <pass_signals, program_signals>:
9885         Constify argument.
9886         (target_pass_signals, target_program_signals): Constify argument.
9887
9888 2019-01-14  Tom Tromey  <tom@tromey.com>
9889
9890         PR tui/28819:
9891         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9892
9893 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9894
9895         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9896         field.
9897         * rs6000-tdep.c: Include reggroups.h.
9898         (IS_V_ALIAS_PSEUDOREG): Define.
9899         (rs6000_register_name): Return names for the "vX" aliases.
9900         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9901         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9902         aliases.  Call default_register_reggroup_p for all other
9903         pseudo-registers.
9904         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9905         New functions.
9906         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9907         Handle "vX" aliases.
9908         (v_alias_pseudo_register_collect): New function.
9909         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9910         (rs6000_gdbarch_init): Initialize "vX" aliases as
9911         pseudo-registers.  Restore registration of
9912         rs6000_pseudo_register_reggroup_p with
9913         set_tdesc_pseudo_register_reggroup_p.
9914
9915 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9916
9917         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9918         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9919         set_gdbarch_num_pseudo_regs.
9920
9921 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9922
9923         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9924         Remove arg prefixname, add do_set and do_show.
9925         Add member functions set_list and show_list.
9926         * cli/cli-style.c (class cli_style_option): Update accordingly.
9927         (style_set_list): Move to file scope.
9928         (style_show_list): Likewise.
9929         (set_style): Call help_list.
9930         (show_style): Call cmd_show_list.
9931         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9932         Update to use the new macro.
9933
9934 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9935
9936         * ada-lang.c (_initialize_ada_language): Expand the help text
9937         for the "catch exception" command.
9938
9939 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9940
9941         * symtab.c (matching_obj_sections): Initialize obj,
9942         declare it closer to its usage.
9943
9944 2019-01-10  Tom Tromey  <tom@tromey.com>
9945
9946         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9947         (basic_inf_threads_range): Remove.
9948         (inf_threads_range, inf_non_exited_threads_range)
9949         (safe_inf_threads_range): Use next_adapter.
9950
9951 2019-01-10  Keith Seitz  <keiths@redhat.com>
9952
9953         PR gdb/23712
9954         PR symtab/23010
9955         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9956         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9957
9958 2019-01-10  Keith Seitz  <keiths@redhat.com>
9959
9960         PR gdb/23712
9961         PR symtab/23010
9962         * dictionary.c (pending_to_vector): Remove.
9963         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9964         Remove _1 suffix, replacing functions of the same name.  Update
9965         all callers.
9966         (dict_create_hashed, dict_create_hashed_expandable)
9967         (dict_create_linear, dict_create_linear_expandable, dict_free)
9968         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9969         Make functions static.
9970
9971 2019-01-10  Keith Seitz  <keiths@redhat.com>
9972
9973         PR gdb/23712
9974         PR symtab/23010
9975         * dictionary.h (struct dictionary): Replace declaration with
9976         multidictionary.
9977         (dict_create_hashed, dict_create_hashed_expandable)
9978         (dict_create_linear, dict_create_linear_expandable)
9979         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9980         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9981         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9982         taking multidictionary argument.
9983         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9984         * block.h (struct block) <dict>: Change to multidictionary
9985         and rename `multidict'.
9986         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9987         symmisc.c: Update all dictionary references to multidictionary.
9988
9989 2019-01-10  Keith Seitz  <keiths@redhat.com>
9990
9991         PR gdb/23712
9992         PR symtab/23010
9993         * dictionary.c: Include unordered_map.
9994         (pending_to_vector): New function.
9995         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9996         Rewrite the non-"_1" functions to take vector instead
9997         of linked list.
9998         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9999         "new" _1 versions of the same name.
10000         (multidictionary): Define.
10001         (std::hash<enum language): New definition.
10002         (collate_pending_symbols_by_language, mdict_create_hashed)
10003         (mdict_create_hashed_expandable, mdict_create_linear)
10004         (mdict_create_linear_expandable, mdict_free)
10005         (find_language_dictionary, create_new_language_dictionary)
10006         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10007         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10008         (mdict_size, mdict_empty): New functions.
10009         * dictionary.h (mdict_iterator): Define.
10010
10011 2019-01-10  Pedro Alves  <palves@redhat.com>
10012
10013         * breakpoint.c (read_uploaded_action)
10014         (create_tracepoint_from_upload): Adjust to use
10015         gdb::unique_xmalloc_ptr.
10016         * ctf.c (ctf_write_uploaded_tp):
10017         (SET_ARRAY_FIELD): Use emplace_back.
10018         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10019         * tracefile-tfile.c (tfile_write_uploaded_tp):
10020         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10021         gdb::unique_xmalloc_ptr.
10022         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10023         at_string, cond_string, cmd_strings>: Replace char pointers
10024         with gdb::unique_xmalloc_ptr.
10025
10026 2019-01-10  Pedro Alves  <palves@redhat.com>
10027
10028         * solib-target.c (library_list_start_library): Don't xstrdup name.
10029
10030 2019-01-10  Pedro Alves  <palves@redhat.com>
10031
10032         * mdebugread.c (parse_partial_symbols): Use
10033         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10034
10035 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10036
10037         * linux-fork.c (scoped_switch_fork_info)
10038         <~scoped_switch_fork_info>: Fix incorrect variable name.
10039
10040 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10041
10042         * linux-fork.c (scoped_switch_fork_info)
10043         <scoped_switch_fork_info>: Make explicit.
10044         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10045
10046 2019-01-10  Tom Tromey  <tom@tromey.com>
10047
10048         * objfiles.h (objfile::reset_psymtabs): Update.
10049         * objfiles.c (objfile::objfile): Update.
10050         * psymtab.h (psymtab_storage::obstack): Update.
10051         (psymtab_storage::m_obstack): Use gdb::optional.
10052         (class psymtab_storage): Update comment.  Remove objfile
10053         parameter.
10054         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10055
10056 2019-01-10  Tom Tromey  <tom@tromey.com>
10057
10058         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10059         <free_psymtabs>: Now private.
10060         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10061         (allocate_psymtab): Use new method.
10062
10063 2019-01-10  Tom Tromey  <tom@tromey.com>
10064
10065         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10066         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10067         * mdebugread.c (parse_partial_symbols): Use
10068         allocate_dependencies.
10069         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10070         allocate_dependencies.
10071         (process_psymtab_comp_unit_reader)
10072         (build_type_psymtab_dependencies): Likewise.
10073         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10074
10075 2019-01-10  Tom Tromey  <tom@tromey.com>
10076
10077         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10078         PSYMBOL_SET_LANGUAGE.
10079         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10080
10081 2019-01-10  Tom Tromey  <tom@tromey.com>
10082
10083         * psymtab.h (psymtab_storage::obstack): New method.
10084         <m_obstack>: Rename from obstack; now private.
10085         * psymtab.c (psymtab_storage): Update.
10086         * dwarf2read.c (create_addrmap_from_index)
10087         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10088         Update.
10089
10090 2019-01-10  Tom Tromey  <tom@tromey.com>
10091
10092         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10093         * objfiles.h (objfile::reset_psymtabs): New method.
10094
10095 2019-01-10  Tom Tromey  <tom@tromey.com>
10096
10097         * symmisc.c (print_symbol_bcache_statistics): Update.
10098         (print_objfile_statistics): Update.
10099         * symfile.c (reread_symbols): Update.
10100         * psymtab.h (class psymtab_storage): New.
10101         * psymtab.c (psymtab_storage): New constructor.
10102         (~psymtab_storage): New destructor.
10103         (require_partial_symbols): Update.
10104         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10105         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10106         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10107         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10108         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10109         (start_psymtab_common, end_psymtab_common)
10110         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10111         (allocate_psymtab): Update.
10112         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10113         Update.
10114         (dump_psymtab_addrmap, maintenance_print_psymbols)
10115         (maintenance_check_psymtabs): Update.
10116         (class objfile_psymtabs): Move to objfiles.h.
10117         * psympriv.h (discard_psymtab): Now inline.
10118         (psymtab_discarder::psymtab_discarder): Update.
10119         (psymtab_discarder::~psymtab_discarder): Update.
10120         (ALL_OBJFILE_PSYMTABS): Rewrite.
10121         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10122         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10123         Remove fields.
10124         <partial_symtabs>: New field.
10125         (class objfile_psymtabs): Move from psymtab.h.  Update.
10126         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10127         psymbol_cache.
10128         (objfile::~objfile): Don't destroy psymbol_cache.
10129         * mdebugread.c (parse_partial_symbols): Update.
10130         * dwarf2read.c (create_addrmap_from_index)
10131         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10132         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10133         (add_partial_subprogram, dwarf2_ranges_read): Update.
10134         * dwarf-index-write.c (write_address_map)
10135         (write_one_signatured_type, recursively_write_psymbols)
10136         (class debug_names, class debug_names, write_psymtabs_to_index):
10137         Update.
10138
10139 2019-01-10  Tom Tromey  <tom@tromey.com>
10140
10141         * symtab.h (SYMBOL_SET_NAMES): Update.
10142         (symbol_set_names): Update.
10143         (MSYMBOL_SET_NAMES): Update.
10144         * symtab.c (symbol_set_names): Change argument to be an
10145         objfile_per_bfd_storage.
10146         * psymtab.c (add_psymbol_to_bcache): Update.
10147         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10148
10149 2019-01-10  Tom Tromey  <tom@tromey.com>
10150
10151         * symtab.c (create_demangled_names_hash): Change argument to be an
10152         objfile_per_bfd_storage.
10153         (symbol_set_names): Update.
10154
10155 2019-01-10  Tom Tromey  <tom@tromey.com>
10156
10157         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10158         init_psymbol_list.
10159         * psymtab.c (init_psymbol_list): Do nothing if already called.
10160         * psympriv.h (init_psymbol_list): Add comment.
10161         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10162         init_psymbol_list.
10163         * dbxread.c (dbx_symfile_read): Unconditionally call
10164         init_psymbol_list.
10165
10166 2019-01-10  Tom Tromey  <tom@tromey.com>
10167
10168         * xcoffread.c (scan_xcoff_symtab): Update.
10169         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10170         "where".
10171         * mdebugread.c (parse_partial_symbols)
10172         (handle_psymbol_enumerators): Update.
10173         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10174         * dbxread.c (read_dbx_symtab): Update.
10175         * psympriv.h (psymbol_placement): New enum.
10176         (add_psymbol_to_list): Update.
10177
10178 2019-01-10  Tom Tromey  <tom@tromey.com>
10179
10180         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10181         static_psymbols parameters.
10182         (scan_xcoff_symtab): Update.
10183         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10184         static_psymbols parameters.
10185         * psympriv.h (start_psymtab_common): Update.
10186         * mdebugread.c (parse_partial_symbols): Update.
10187         * dwarf2read.c (create_partial_symtab): Update.
10188         * dbxread.c (read_dbx_symtab): Update.
10189         (start_psymtab): Remove global_psymbols and static_psymbols
10190         parameters.
10191
10192 2019-01-10  Tom Tromey  <tom@tromey.com>
10193
10194         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10195         * psymtab.c (allocate_psymtab): Add comment.
10196         * psympriv.h (allocate_psymtab): Add comment.
10197         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10198         initializations.
10199         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10200
10201 2019-01-10  Tom Tromey  <tom@tromey.com>
10202
10203         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10204         Don't declare.
10205         * mipsread.c: Include mdebugread.h.
10206         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10207         Declare.
10208         * elfread.c: Include mdebugread.h.
10209
10210 2019-01-09  Tom Tromey  <tom@tromey.com>
10211
10212         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10213         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10214         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10215         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10216         (psym_lookup_symbol, psym_find_last_source_symtab)
10217         (psym_forget_cached_source_info, psym_print_stats)
10218         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10219         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10220         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10221         (psym_find_compunit_symtab_by_address)
10222         (maintenance_print_psymbols, maintenance_info_psymtabs)
10223         (maintenance_check_psymtabs): Use ranged for.
10224         * psymtab.h (class objfile_psymtabs): New.
10225         (require_partial_symbols): Return objfile_psymtabs.
10226         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10227
10228 2019-01-09  Tom Tromey  <tom@tromey.com>
10229
10230         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10231         (find_pc_mapped_section, list_overlays_command)
10232         (map_overlay_command, unmap_overlay_command)
10233         (simple_overlay_update): Use all_objfiles.
10234         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10235         * printcmd.c (info_symbol_command): Use all_objfiles.
10236         * objfiles.h (ALL_OBJSECTIONS): Remove.
10237         * maint.c (maintenance_translate_address): Use all_objfiles.
10238         * gcore.c (gcore_create_callback): Use all_objfiles.
10239         (objfile_find_memory_regions): Likewise.
10240
10241 2019-01-09  Tom Tromey  <tom@tromey.com>
10242
10243         * symtab.c (find_line_symtab, info_sources_command)
10244         (make_source_files_completion_list): Use objfile_compunits.
10245         * source.c (select_source_symtab): Use objfile_compunits.
10246         * objfiles.h (struct objfile): Update comment.
10247         (ALL_OBJFILES): Remove.
10248         (ALL_FILETABS): Remove.
10249         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10250         objfile_compunits.
10251
10252 2019-01-09  Tom Tromey  <tom@tromey.com>
10253
10254         * symmisc.c (print_objfile_statistics, dump_objfile)
10255         (maintenance_print_symbols): Use compunit_filetabs.
10256         * source.c (forget_cached_source_info_for_objfile): Use
10257         compunit_filetabs.
10258         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10259         (ALL_FILETABS): Use compunit_filetabs.
10260         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10261         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10262
10263 2019-01-09  Tom Tromey  <tom@tromey.com>
10264
10265         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10266         (compunit_filetabs): New.
10267         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10268         compunit_filetabs.
10269         (info_sources_command, make_source_files_completion_list): Remove
10270         declaration.
10271         * symmisc.c (print_objfile_statistics, dump_objfile)
10272         (maintenance_print_symbols): Remove declaration.
10273         (maintenance_info_symtabs): Use compunit_filetabs.
10274         (maintenance_info_line_tables): Likewise.
10275         * source.c (select_source_symtab): Change local variable name.
10276         (forget_cached_source_info_for_objfile): Remove declaration.
10277         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10278         * objfiles.c (objfile_relocate1): Remove declaration.
10279         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10280         declaration.
10281         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10282         * coffread.c (coff_symtab_read): Remove declaration.
10283         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10284         compunit_filetabs.
10285
10286 2019-01-09  Tom Tromey  <tom@tromey.com>
10287
10288         * symtab.c (lookup_objfile_from_block)
10289         (find_pc_sect_compunit_symtab, search_symbols)
10290         (default_collect_symbol_completion_matches_break_on): Use
10291         objfile_compunits.
10292         * objfiles.h (ALL_COMPUNITS): Remove.
10293         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10294         * cp-support.c (add_symbol_overload_list_qualified): Use
10295         objfile_compunits.
10296         * ada-lang.c (ada_collect_symbol_completion_matches)
10297         (ada_add_global_exceptions): Use objfile_compunits.
10298
10299 2019-01-09  Tom Tromey  <tom@tromey.com>
10300
10301         * source.c (select_source_symtab)
10302         (forget_cached_source_info_for_objfile): Remove declaration.
10303         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10304         declaration.
10305         * maint.c (count_symtabs_and_blocks): Remove declaration.
10306         * cp-support.c (add_symbol_overload_list_qualified): Remove
10307         declaration.
10308         * coffread.c (coff_symtab_read): Remove declaration.
10309         * symtab.c (lookup_symbol_in_objfile_symtabs)
10310         (basic_lookup_transparent_type_1): Use objfile_compunits.
10311         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10312         (info_sources_command, search_symbols)
10313         (default_collect_symbol_completion_matches_break_on)
10314         (make_source_files_completion_list): Remove declaration.
10315         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10316         (ada_collect_symbol_completion_matches)
10317         (ada_add_global_exceptions): Remove declaration.
10318         * linespec.c (iterate_over_all_matching_symtabs): Use
10319         objfile_compunits.
10320         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10321         (class objfile_compunits): New.
10322         (ALL_COMPUNITS): Use objfile_compunits.
10323         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10324         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10325         objfile_compunits.
10326         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10327
10328 2019-01-09  Tom Tromey  <tom@tromey.com>
10329
10330         * symtab.c (search_symbols)
10331         (default_collect_symbol_completion_matches_break_on): Use
10332         objfile_msymbols.
10333         * ada-lang.c (ada_lookup_simple_minsym)
10334         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10335         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10336         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10337         objfile_msymbols.
10338         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10339         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10340         * objc-lang.c (find_methods): Use objfile_msymbols.
10341         (info_selectors_command, info_classes_command): Likewise.
10342         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10343         * objfiles.h (class objfile_msymbols): New.
10344         (ALL_OBJFILE_MSYMBOLS): Remove.
10345         (ALL_MSYMBOLS): Remove.
10346
10347 2019-01-09  Tom Tromey  <tom@tromey.com>
10348
10349         * common/next-iterator.h (next_adapter): Add Iterator template
10350         parameter.
10351         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10352         (class all_objfiles_safe): New.
10353         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10354         * objfiles.c (put_objfile_before): Update comment.
10355         (add_separate_debug_objfile): Likewise.
10356         (free_all_objfiles): Use all_objfiles_safe.
10357         (objfile_purge_solibs): Likewise.
10358
10359 2019-01-09  Tom Tromey  <tom@tromey.com>
10360
10361         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10362         (expand_symtab_containing_pc, lookup_static_symbol)
10363         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10364         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10365         all_objfiles.
10366         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10367         * breakpoint.c (create_overlay_event_breakpoint)
10368         (create_longjmp_master_breakpoint)
10369         (create_std_terminate_master_breakpoint)
10370         (create_exception_master_breakpoint): Use all_objfiles.
10371         * linux-thread-db.c (try_thread_db_load_from_pdir)
10372         (has_libpthread): Use all_objfiles.
10373         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10374         * linespec.c (iterate_over_all_matching_symtabs)
10375         (search_minsyms_for_name): Use all_objfiles.
10376         * maint.c (maintenance_info_sections): Use all_objfiles.
10377         * main.c (captured_main_1): Use all_objfiles.
10378         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10379         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10380         * guile/scm-pretty-print.c
10381         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10382         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10383         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10384         (maintenance_print_msymbols): Use all_objfiles.
10385         * source.c (select_source_symtab): Use all_objfiles.
10386         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10387         * symfile.c (remove_symbol_file_command)
10388         (expand_symtabs_matching, map_symbol_filenames): Use
10389         all_objfiles.
10390         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10391         all_objfiles.
10392         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10393         * objc-lang.c (find_methods): Use all_objfiles.
10394         * objfiles.c (have_partial_symbols, have_full_symbols)
10395         (have_minimal_symbols, qsort_cmp)
10396         (default_iterate_over_objfiles_in_search_order): Use
10397         all_objfiles.
10398         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10399         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10400         (maintenance_check_psymtabs): Use all_objfiles.
10401         (ALL_PSYMTABS): Remove.
10402         * compile/compile-object-run.c (do_module_cleanup): Use
10403         all_objfiles.
10404         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10405         * cp-support.c (add_symbol_overload_list_qualified): Use
10406         all_objfiles.
10407         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10408         Use all_objfiles.
10409         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10410         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10411         all_objfiles.
10412         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10413         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10414         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10415         Uses all_objfiles.
10416         * solib.c (solib_read_symbols): Use all_objfiles
10417
10418 2019-01-09  Tom Tromey  <tom@tromey.com>
10419
10420         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10421         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10422         all_objfiles.
10423         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10424         * symmisc.c (print_symbol_bcache_statistics)
10425         (print_objfile_statistics, maintenance_print_objfiles)
10426         (maintenance_info_symtabs, maintenance_check_symtabs)
10427         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10428         all_objfiles.
10429         * source.c (forget_cached_source_info): Use all_objfiles.
10430         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10431         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10432         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10433         * objfiles.c (update_section_map): Use all_objfiles.
10434         (shared_objfile_contains_address_p): Likewise.
10435         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10436         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10437
10438 2019-01-09  Tom Tromey  <tom@tromey.com>
10439
10440         * common/next-iterator.h: New file.
10441         * objfiles.h (class all_objfiles): New.
10442         (struct objfile_iterator): New.
10443
10444 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10445
10446         * NEWS: Move the description of the changed "frame", "select-frame",
10447          and "info frame" commands to the Changed commands section.
10448
10449 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10450
10451         * gdbtypes.c (check_stub_method_group): Remove handling of old
10452         mangling schemes.
10453         * linespec.c (find_methods): Likewise.
10454         * stabsread.c (read_member_functions): Likewise.
10455         * valops.c (search_struct_method): Likewise.
10456         (value_struct_elt_for_reference): Likewise.
10457         * NEWS: Mention this change.
10458
10459 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10460
10461         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10462         print_source_lines.
10463         * source.c (print_source_lines_base): Update line number check.
10464         (print_source_lines): New function.
10465         (source_lines_range::source_lines_range): New function.
10466         * source.h (class source_lines_range): New class.
10467         (print_source_lines): New declaration.
10468
10469 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10470
10471         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10472
10473 2019-01-08  Tom Tromey  <tom@tromey.com>
10474             Simon Marchi  <simon.marchi@ericsson.com>
10475
10476         PR gdb/24060
10477         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10478         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10479         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10480         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10481         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10482         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10483
10484 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10485
10486         * source.c (select_source_symtab): Move header comment to
10487         declaration in source.h.
10488         (forget_cached_source_info_for_objfile): Likewise.
10489         (forget_cached_source_info): Likewise.
10490         (identify_source_line): Likewise.
10491         * source.h (identify_source_line): Move declaration from symtab.h
10492         and add comment from source.c
10493         (print_source_lines): Likewise.
10494         (forget_cached_source_info_for_objfile): Likewise.
10495         (forget_cached_source_info): Likewise.
10496         (select_source_symtab): Likewise.
10497         (enum print_source_lines_flag): Move definition from symtab.h.
10498         * symtab.h (identify_source_line): Move declaration to source.h.
10499         (print_source_lines): Likewise.
10500         (forget_cached_source_info_for_objfile): Likewise.
10501         (forget_cached_source_info): Likewise.
10502         (select_source_symtab): Likewise.
10503         (enum print_source_lines_flag): Move definition to source.h.
10504         * tui/tui-hooks.c: Add 'source.h' include.
10505
10506 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10507
10508         * source.c (print_source_lines_base): Handle requests to print
10509         reverse line number sequences, and guard against empty lines
10510         string.
10511
10512 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10513
10514         * source.c (print_source_lines_base): Fix skip of '\r' if next
10515         character is '\n'.
10516
10517 2019-01-06  Tom Tromey  <tom@tromey.com>
10518
10519         * c-exp.y (struct c_parse_state) <macro_original_text,
10520         expansion_obstack>: New member.
10521         (macro_original_text, expansion_obstack): Remove globals.
10522         (scan_macro_expansion, scanning_macro_expansion)
10523         (finished_macro_expansion): Update.
10524         (scan_macro_cleanup): Remove.
10525         (yylex, c_parse): Update.
10526
10527 2019-01-06  Tom Tromey  <tom@tromey.com>
10528
10529         * c-exp.y (struct c_parse_state) <strings>: New member.
10530         (operator_stoken): Update.
10531
10532 2019-01-06  Tom Tromey  <tom@tromey.com>
10533
10534         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10535         (union type_stack_elt) <typelist_val>: Now a pointer to
10536         std::vector.
10537         (type_stack_cleanup): Don't declare.
10538         (push_typelist): Update.
10539         * parse.c (pop_typelist): Return a std::vector.
10540         (push_typelist): Take a std::vector.
10541         (follow_types): Update.  Do not free args.
10542         (type_stack_cleanup): Remove.
10543         * c-exp.y (struct c_parse_state): New.
10544         (cpstate): New global.
10545         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10546         (nonempty_typelist): Update.
10547         (func_mod): Create a new vector.
10548         (c_parse): Create a c_parse_state.
10549         (check_parameter_typelist): Do not delete params.
10550         (function_method): Update.  Do not delete type_list.
10551
10552 2019-01-06  Tom Tromey  <tom@tromey.com>
10553
10554         PR gdb/28155:
10555         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10556         check_typedef.
10557         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10558         (print_return_value): Likewise.
10559
10560 2019-01-05  Tom Tromey  <tom@tromey.com>
10561
10562         * contrib/cleanup_check.py: Remove.
10563         * contrib/gcc-with-excheck: Remove.
10564         * contrib/exsummary.py: Remove.
10565         * contrib/excheck.py: Remove.
10566
10567 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10568
10569         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10570         NULL. Initialize tpprev to NULL instead of assigning it
10571         to NULL on the next statement.
10572         * windows-nat.c (windows_delete_thread): Remove check for
10573         main_thread_id before printing thread exit notifications.
10574         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10575         Remove thread ID check against main_thread_id.
10576         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10577         windows_delete_thread.
10578         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10579
10580 2019-01-04  Tom Tromey  <tom@tromey.com>
10581
10582         * compile/compile.c (_initialize_compile): Use upper case for
10583         metasyntactic variables.
10584         * symmisc.c (_initialize_symmisc): Use upper case for
10585         metasyntactic variables.
10586         * psymtab.c (_initialize_psymtab): Use upper case for
10587         metasyntactic variables.
10588         * demangle.c (demangle_command): Use upper case for metasyntactic
10589         variables.
10590         (_initialize_demangler): Likewise.
10591         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10592         variables.
10593
10594 2019-01-03  Tom Tromey  <tom@tromey.com>
10595
10596         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10597
10598 2019-01-03  Tom Tromey  <tom@tromey.com>
10599
10600         * python/py-symtab.c (salpy_str): Update.
10601         (struct salpy_sal_object) <symtab>: Now a PyObject.
10602         (salpy_dealloc): Update.
10603         (del_objfile_sal): Use gdbpy_ref.
10604
10605 2019-01-03  Tom Tromey  <tom@tromey.com>
10606
10607         * python/py-type.c (convert_field): Use new_reference.  Return
10608         gdbpy_ref.
10609         (make_fielditem): Return gdbpy_ref.
10610         (typy_fields): Update.
10611         (typy_getitem): Update.
10612         (field_name): Return gdbpy_ref.  Use new_reference.
10613         (typy_iterator_iternext): Update.
10614
10615 2019-01-03  Tom Tromey  <tom@tromey.com>
10616
10617         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10618
10619 2019-01-03  Tom Tromey  <tom@tromey.com>
10620
10621         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10622         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10623         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10624         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10625         (pspy_set_type_printers): Likewise.
10626         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10627         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10628         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10629         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10630         (objfpy_set_type_printers): Likewise.
10631
10632 2019-01-03  Tom Tromey  <tom@tromey.com>
10633
10634         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10635         (gdbpy_print_stack): Use gdbpy_err_fetch.
10636         * python/python-internal.h (class gdbpy_err_fetch): New class.
10637         (class gdbpy_enter) <m_error_type, m_error_value,
10638         m_error_traceback>: Remove.
10639         <m_error>: New member.
10640         (gdbpy_exception_to_string): Don't declare.
10641         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10642         * python/py-value.c (convert_value_from_python): Use
10643         gdbpy_err_fetch.
10644         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10645         gdbpy_exception_to_string.
10646         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10647         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10648         gdbpy_err_fetch.
10649
10650 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10651
10652         * linux-nat.c (delete_lwp_cleanup): Delete.
10653         (struct lwp_deleter): New struct.
10654         (lwp_info_up): New typedef.
10655         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10656         lwp_info_up.
10657
10658 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10659
10660         * linux-fork.c (class scoped_switch_fork_info): New class.
10661         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10662
10663 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10664
10665         * valops.c (find_overload_match): Remove use of null_cleanup, and
10666         calls to do_cleanups.
10667
10668 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10669
10670         * compile/compile-cplus-types.c
10671         (compile_cplus_instance::decl_name): Handle changes to
10672         cp_func_name.
10673         * cp-support.c (cp_func_name): Update header comment, update
10674         return type.
10675         * cp-support.h (cp_func_name): Update return type in declaration.
10676         * valops.c (find_overload_match): Move temp_func local to top
10677         level of function and change its type.  Use temp_func to hold and
10678         delete temporary string obtained from cp_func_name.
10679
10680 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10681
10682         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10683         gdb::char_vector, remove cleanup, and update uses of `msg`.
10684
10685 2019-01-03  Jim Wilson  <jimw@sifive.com>
10686
10687         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10688
10689 2019-01-02  Tom Tromey  <tom@tromey.com>
10690
10691         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10692         (tdesc_parse_xml): Remove cleanups.
10693         * target-descriptions.h (make_cleanup_free_target_description):
10694         Don't declare.
10695         (target_desc_deleter): New struct.
10696         (target_desc_up): New typedef.
10697         * target-descriptions.c (target_desc_deleter::operator()): Rename
10698         from free_target_description.
10699         (make_cleanup_free_target_description): Remove.
10700
10701 2019-01-02  Tom Tromey  <tom@tromey.com>
10702
10703         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10704         constructor, destructor.
10705         (linespec_parser): Remove typedef.
10706         (~linespec_parser): Rename from linespec_parser_delete.
10707         (linespec_lex_to_end, linespec_complete_label)
10708         (linespec_complete): Update.
10709         (decode_line_full): Remove cleanups.
10710         (decode_line_1): Update.
10711
10712 2019-01-02  Tom Tromey  <tom@tromey.com>
10713
10714         * python/python-internal.h (inferior_to_inferior_object): Change
10715         return type.
10716         * python/py-exitedevent.c (create_exited_event_object): Update.
10717         * python/py-inferior.c (inferior_to_inferior_object): Return
10718         gdbpy_ref.
10719         (python_new_inferior, python_inferior_deleted)
10720         (thread_to_thread_object, delete_thread_object)
10721         (build_inferior_list, gdbpy_selected_inferior): Update.
10722         * python/py-infthread.c (create_thread_object): Update.  Also fail
10723         if inferior_to_inferior_object fails.
10724
10725 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10726
10727         * inferior.h (class inferior) <displaced_step_state>: New field.
10728         * infrun.h (struct displaced_step_state): Move here from
10729         infrun.c.  Initialize fields, add constructor.
10730         <inf>: Remove field.
10731         <reset>: New method.
10732         * infrun.c (struct displaced_step_inferior_state): Move to
10733         infrun.h.
10734         (displaced_step_inferior_states): Remove.
10735         (get_displaced_stepping_state): Adust.
10736         (displaced_step_in_progress_any_inferior): Adjust.
10737         (displaced_step_in_progress_thread): Adjust.
10738         (displaced_step_in_progress): Adjust.
10739         (add_displaced_stepping_state): Remove.
10740         (get_displaced_step_closure_by_addr): Adjust.
10741         (remove_displaced_stepping_state): Remove.
10742         (infrun_inferior_exit): Call displaced_step_state.reset.
10743         (use_displaced_stepping): Don't check for NULL.
10744         (displaced_step_prepare_throw): Call
10745         get_displaced_stepping_state.
10746         (displaced_step_fixup): Don't check for NULL.
10747         (prepare_for_detach): Don't check for NULL.
10748
10749 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10750
10751         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10752          in case of call that did not complete.
10753
10754 2019-01-02  Andrey Utkin  <autkin@undo.io>
10755
10756         * symfile.c (find_separate_debug_file): Fix search of debug files for
10757         remote debuggee.
10758
10759 2019-01-02  Tom Tromey  <tom@tromey.com>
10760
10761         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10762         indentation.
10763         * python/py-frame.c (frapy_older): Remove cast.
10764         (frapy_newer): Likewise.
10765         * python/py-breakpoint.c (local_setattro): Remove cast.
10766         * python/py-arch.c (archpy_name): Remove local variable.
10767         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10768
10769 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10770
10771         * unittests/basic_string_view/element_access/char/empty.cc:
10772         Fix year range in copyright header.
10773
10774 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10775
10776         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10777         Delete.
10778         <operator==>: Update with for removed field.
10779         <hash>: Likewise.
10780         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10781         <isa_features>: ...this.
10782         <abi_features>: New field.
10783         (riscv_isa_flen): Update comment.
10784         (riscv_abi_xlen): New declaration.
10785         (riscv_abi_flen): New declaration.
10786         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10787         isa_features.
10788         (riscv_abi_xlen): New function.
10789         (riscv_isa_flen): Update to get answer from isa_features.
10790         (riscv_abi_flen): New function.
10791         (riscv_has_fp_abi): Update to get answer from abi_features.
10792         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10793         xlen and flen.
10794         (riscv_call_info) <xlen, flen>: Update comment.
10795         (riscv_call_arg_struct): Remove invalid assertions
10796         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10797         is removed.
10798         (riscv_gdbarch_init): Gather isa features and abi features
10799         separately, ensure both match on the gdbarch when reusing an old
10800         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10801         a target with 64-bit float hardware.
10802
10803 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10804
10805         * source.c (search_command_helper): Stop reverse search
10806         when line 1 has been searched.
10807
10808 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10809
10810         * record-full.c (record_full_base_target::close): Rewrite
10811         record_full_core_buf_list free logic.
10812
10813 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10814
10815         * break-catch-syscall.c (print_one_catch_syscall): xfree
10816         the last text.
10817
10818 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10819
10820         * top.c (print_gdb_version): Update Copyright year in version
10821         message.
10822
10823 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10824
10825         Update copyright year range in all GDB files.
10826
10827 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10828
10829         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10830
10831 For older changes see ChangeLog-2018.
10832 \f
10833 Local Variables:
10834 mode: change-log
10835 left-margin: 8
10836 fill-column: 74
10837 version-control: never
10838 coding: utf-8
10839 End:
10840