gdb/ChangeLog

   1 2019-04-08  Tom Tromey  <tom@tromey.com>
   2
   3         * common/common-exceptions.c (throw_exception): Rename from
   4         throw_exception_cxx.  Remove old copy.  Make argument const.
   5         (throw_it): Create and throw exception objects directly.
   6         * common/common-exceptions.h (throw_exception): Make argument
   7         const.
   8         (struct gdb_exception_error): Add constructor.
   9         (struct gdb_exception_quit): Add constructor.
  10
  11 2019-04-08  Tom Tromey  <tom@tromey.com>
  12
  13         * common/common-exceptions.h (exception_rethrow): Don't declare.
  14         (TRY_SJLJ): Update comment.
  15         (TRY, CATCH, END_CATCH): Remove.
  16         * common/common-exceptions.c (exception_rethrow): Remove.
  17
  18 2019-04-08  Tom Tromey  <tom@tromey.com>
  19
  20         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
  21         Remove.
  22         (gdb_exception_error): Rename from
  23         gdb_exception_RETURN_MASK_ERROR.
  24         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
  25         (gdb_quit_bad_alloc): Update.
  26         * aarch64-tdep.c: Update.
  27         * ada-lang.c: Update.
  28         * ada-typeprint.c: Update.
  29         * ada-valprint.c: Update.
  30         * amd64-tdep.c: Update.
  31         * arch-utils.c: Update.
  32         * break-catch-throw.c: Update.
  33         * breakpoint.c: Update.
  34         * btrace.c: Update.
  35         * c-varobj.c: Update.
  36         * cli/cli-cmds.c: Update.
  37         * cli/cli-interp.c: Update.
  38         * cli/cli-script.c: Update.
  39         * common/common-exceptions.c: Update.
  40         * common/new-op.c: Update.
  41         * common/selftest.c: Update.
  42         * compile/compile-c-symbols.c: Update.
  43         * compile/compile-cplus-symbols.c: Update.
  44         * compile/compile-object-load.c: Update.
  45         * compile/compile-object-run.c: Update.
  46         * completer.c: Update.
  47         * corelow.c: Update.
  48         * cp-abi.c: Update.
  49         * cp-support.c: Update.
  50         * cp-valprint.c: Update.
  51         * darwin-nat.c: Update.
  52         * disasm-selftests.c: Update.
  53         * dtrace-probe.c: Update.
  54         * dwarf-index-cache.c: Update.
  55         * dwarf-index-write.c: Update.
  56         * dwarf2-frame-tailcall.c: Update.
  57         * dwarf2-frame.c: Update.
  58         * dwarf2loc.c: Update.
  59         * dwarf2read.c: Update.
  60         * eval.c: Update.
  61         * event-loop.c: Update.
  62         * event-top.c: Update.
  63         * exec.c: Update.
  64         * f-valprint.c: Update.
  65         * fbsd-tdep.c: Update.
  66         * frame-unwind.c: Update.
  67         * frame.c: Update.
  68         * gdbtypes.c: Update.
  69         * gnu-v3-abi.c: Update.
  70         * guile/guile-internal.h: Update.
  71         * guile/scm-block.c: Update.
  72         * guile/scm-breakpoint.c: Update.
  73         * guile/scm-cmd.c: Update.
  74         * guile/scm-disasm.c: Update.
  75         * guile/scm-frame.c: Update.
  76         * guile/scm-lazy-string.c: Update.
  77         * guile/scm-math.c: Update.
  78         * guile/scm-param.c: Update.
  79         * guile/scm-ports.c: Update.
  80         * guile/scm-pretty-print.c: Update.
  81         * guile/scm-symbol.c: Update.
  82         * guile/scm-symtab.c: Update.
  83         * guile/scm-type.c: Update.
  84         * guile/scm-value.c: Update.
  85         * i386-linux-tdep.c: Update.
  86         * i386-tdep.c: Update.
  87         * inf-loop.c: Update.
  88         * infcall.c: Update.
  89         * infcmd.c: Update.
  90         * infrun.c: Update.
  91         * jit.c: Update.
  92         * language.c: Update.
  93         * linespec.c: Update.
  94         * linux-fork.c: Update.
  95         * linux-nat.c: Update.
  96         * linux-tdep.c: Update.
  97         * linux-thread-db.c: Update.
  98         * main.c: Update.
  99         * mi/mi-cmd-break.c: Update.
 100         * mi/mi-cmd-stack.c: Update.
 101         * mi/mi-interp.c: Update.
 102         * mi/mi-main.c: Update.
 103         * objc-lang.c: Update.
 104         * p-valprint.c: Update.
 105         * parse.c: Update.
 106         * ppc-linux-tdep.c: Update.
 107         * printcmd.c: Update.
 108         * python/py-arch.c: Update.
 109         * python/py-breakpoint.c: Update.
 110         * python/py-cmd.c: Update.
 111         * python/py-finishbreakpoint.c: Update.
 112         * python/py-frame.c: Update.
 113         * python/py-framefilter.c: Update.
 114         * python/py-gdb-readline.c: Update.
 115         * python/py-inferior.c: Update.
 116         * python/py-infthread.c: Update.
 117         * python/py-lazy-string.c: Update.
 118         * python/py-linetable.c: Update.
 119         * python/py-objfile.c: Update.
 120         * python/py-param.c: Update.
 121         * python/py-prettyprint.c: Update.
 122         * python/py-progspace.c: Update.
 123         * python/py-record-btrace.c: Update.
 124         * python/py-record.c: Update.
 125         * python/py-symbol.c: Update.
 126         * python/py-type.c: Update.
 127         * python/py-unwind.c: Update.
 128         * python/py-utils.c: Update.
 129         * python/py-value.c: Update.
 130         * python/python.c: Update.
 131         * record-btrace.c: Update.
 132         * record-full.c: Update.
 133         * remote-fileio.c: Update.
 134         * remote.c: Update.
 135         * riscv-tdep.c: Update.
 136         * rs6000-aix-tdep.c: Update.
 137         * rs6000-tdep.c: Update.
 138         * rust-exp.y: Update.
 139         * rust-lang.c: Update.
 140         * s390-tdep.c: Update.
 141         * selftest-arch.c: Update.
 142         * solib-dsbt.c: Update.
 143         * solib-frv.c: Update.
 144         * solib-spu.c: Update.
 145         * solib-svr4.c: Update.
 146         * solib.c: Update.
 147         * sparc64-linux-tdep.c: Update.
 148         * stack.c: Update.
 149         * symfile-mem.c: Update.
 150         * symmisc.c: Update.
 151         * target.c: Update.
 152         * thread.c: Update.
 153         * top.c: Update.
 154         * tracefile-tfile.c: Update.
 155         * tui/tui.c: Update.
 156         * typeprint.c: Update.
 157         * unittests/cli-utils-selftests.c: Update.
 158         * unittests/parse-connection-spec-selftests.c: Update.
 159         * valops.c: Update.
 160         * valprint.c: Update.
 161         * value.c: Update.
 162         * varobj.c: Update.
 163         * windows-nat.c: Update.
 164         * x86-linux-nat.c: Update.
 165         * xml-support.c: Update.
 166
 167 2019-04-08  Tom Tromey  <tom@tromey.com>
 168
 169         * xml-support.c: Use C++ exception handling.
 170         * x86-linux-nat.c: Use C++ exception handling.
 171         * windows-nat.c: Use C++ exception handling.
 172         * varobj.c: Use C++ exception handling.
 173         * value.c: Use C++ exception handling.
 174         * valprint.c: Use C++ exception handling.
 175         * valops.c: Use C++ exception handling.
 176         * unittests/parse-connection-spec-selftests.c: Use C++ exception
 177         handling.
 178         * unittests/cli-utils-selftests.c: Use C++ exception handling.
 179         * typeprint.c: Use C++ exception handling.
 180         * tui/tui.c: Use C++ exception handling.
 181         * tracefile-tfile.c: Use C++ exception handling.
 182         * top.c: Use C++ exception handling.
 183         * thread.c: Use C++ exception handling.
 184         * target.c: Use C++ exception handling.
 185         * symmisc.c: Use C++ exception handling.
 186         * symfile-mem.c: Use C++ exception handling.
 187         * stack.c: Use C++ exception handling.
 188         * sparc64-linux-tdep.c: Use C++ exception handling.
 189         * solib.c: Use C++ exception handling.
 190         * solib-svr4.c: Use C++ exception handling.
 191         * solib-spu.c: Use C++ exception handling.
 192         * solib-frv.c: Use C++ exception handling.
 193         * solib-dsbt.c: Use C++ exception handling.
 194         * selftest-arch.c: Use C++ exception handling.
 195         * s390-tdep.c: Use C++ exception handling.
 196         * rust-lang.c: Use C++ exception handling.
 197         * rust-exp.y: Use C++ exception handling.
 198         * rs6000-tdep.c: Use C++ exception handling.
 199         * rs6000-aix-tdep.c: Use C++ exception handling.
 200         * riscv-tdep.c: Use C++ exception handling.
 201         * remote.c: Use C++ exception handling.
 202         * remote-fileio.c: Use C++ exception handling.
 203         * record-full.c: Use C++ exception handling.
 204         * record-btrace.c: Use C++ exception handling.
 205         * python/python.c: Use C++ exception handling.
 206         * python/py-value.c: Use C++ exception handling.
 207         * python/py-utils.c: Use C++ exception handling.
 208         * python/py-unwind.c: Use C++ exception handling.
 209         * python/py-type.c: Use C++ exception handling.
 210         * python/py-symbol.c: Use C++ exception handling.
 211         * python/py-record.c: Use C++ exception handling.
 212         * python/py-record-btrace.c: Use C++ exception handling.
 213         * python/py-progspace.c: Use C++ exception handling.
 214         * python/py-prettyprint.c: Use C++ exception handling.
 215         * python/py-param.c: Use C++ exception handling.
 216         * python/py-objfile.c: Use C++ exception handling.
 217         * python/py-linetable.c: Use C++ exception handling.
 218         * python/py-lazy-string.c: Use C++ exception handling.
 219         * python/py-infthread.c: Use C++ exception handling.
 220         * python/py-inferior.c: Use C++ exception handling.
 221         * python/py-gdb-readline.c: Use C++ exception handling.
 222         * python/py-framefilter.c: Use C++ exception handling.
 223         * python/py-frame.c: Use C++ exception handling.
 224         * python/py-finishbreakpoint.c: Use C++ exception handling.
 225         * python/py-cmd.c: Use C++ exception handling.
 226         * python/py-breakpoint.c: Use C++ exception handling.
 227         * python/py-arch.c: Use C++ exception handling.
 228         * printcmd.c: Use C++ exception handling.
 229         * ppc-linux-tdep.c: Use C++ exception handling.
 230         * parse.c: Use C++ exception handling.
 231         * p-valprint.c: Use C++ exception handling.
 232         * objc-lang.c: Use C++ exception handling.
 233         * mi/mi-main.c: Use C++ exception handling.
 234         * mi/mi-interp.c: Use C++ exception handling.
 235         * mi/mi-cmd-stack.c: Use C++ exception handling.
 236         * mi/mi-cmd-break.c: Use C++ exception handling.
 237         * main.c: Use C++ exception handling.
 238         * linux-thread-db.c: Use C++ exception handling.
 239         * linux-tdep.c: Use C++ exception handling.
 240         * linux-nat.c: Use C++ exception handling.
 241         * linux-fork.c: Use C++ exception handling.
 242         * linespec.c: Use C++ exception handling.
 243         * language.c: Use C++ exception handling.
 244         * jit.c: Use C++ exception handling.
 245         * infrun.c: Use C++ exception handling.
 246         * infcmd.c: Use C++ exception handling.
 247         * infcall.c: Use C++ exception handling.
 248         * inf-loop.c: Use C++ exception handling.
 249         * i386-tdep.c: Use C++ exception handling.
 250         * i386-linux-tdep.c: Use C++ exception handling.
 251         * guile/scm-value.c: Use C++ exception handling.
 252         * guile/scm-type.c: Use C++ exception handling.
 253         * guile/scm-symtab.c: Use C++ exception handling.
 254         * guile/scm-symbol.c: Use C++ exception handling.
 255         * guile/scm-pretty-print.c: Use C++ exception handling.
 256         * guile/scm-ports.c: Use C++ exception handling.
 257         * guile/scm-param.c: Use C++ exception handling.
 258         * guile/scm-math.c: Use C++ exception handling.
 259         * guile/scm-lazy-string.c: Use C++ exception handling.
 260         * guile/scm-frame.c: Use C++ exception handling.
 261         * guile/scm-disasm.c: Use C++ exception handling.
 262         * guile/scm-cmd.c: Use C++ exception handling.
 263         * guile/scm-breakpoint.c: Use C++ exception handling.
 264         * guile/scm-block.c: Use C++ exception handling.
 265         * guile/guile-internal.h: Use C++ exception handling.
 266         * gnu-v3-abi.c: Use C++ exception handling.
 267         * gdbtypes.c: Use C++ exception handling.
 268         * frame.c: Use C++ exception handling.
 269         * frame-unwind.c: Use C++ exception handling.
 270         * fbsd-tdep.c: Use C++ exception handling.
 271         * f-valprint.c: Use C++ exception handling.
 272         * exec.c: Use C++ exception handling.
 273         * event-top.c: Use C++ exception handling.
 274         * event-loop.c: Use C++ exception handling.
 275         * eval.c: Use C++ exception handling.
 276         * dwarf2read.c: Use C++ exception handling.
 277         * dwarf2loc.c: Use C++ exception handling.
 278         * dwarf2-frame.c: Use C++ exception handling.
 279         * dwarf2-frame-tailcall.c: Use C++ exception handling.
 280         * dwarf-index-write.c: Use C++ exception handling.
 281         * dwarf-index-cache.c: Use C++ exception handling.
 282         * dtrace-probe.c: Use C++ exception handling.
 283         * disasm-selftests.c: Use C++ exception handling.
 284         * darwin-nat.c: Use C++ exception handling.
 285         * cp-valprint.c: Use C++ exception handling.
 286         * cp-support.c: Use C++ exception handling.
 287         * cp-abi.c: Use C++ exception handling.
 288         * corelow.c: Use C++ exception handling.
 289         * completer.c: Use C++ exception handling.
 290         * compile/compile-object-run.c: Use C++ exception handling.
 291         * compile/compile-object-load.c: Use C++ exception handling.
 292         * compile/compile-cplus-symbols.c: Use C++ exception handling.
 293         * compile/compile-c-symbols.c: Use C++ exception handling.
 294         * common/selftest.c: Use C++ exception handling.
 295         * common/new-op.c: Use C++ exception handling.
 296         * cli/cli-script.c: Use C++ exception handling.
 297         * cli/cli-interp.c: Use C++ exception handling.
 298         * cli/cli-cmds.c: Use C++ exception handling.
 299         * c-varobj.c: Use C++ exception handling.
 300         * btrace.c: Use C++ exception handling.
 301         * breakpoint.c: Use C++ exception handling.
 302         * break-catch-throw.c: Use C++ exception handling.
 303         * arch-utils.c: Use C++ exception handling.
 304         * amd64-tdep.c: Use C++ exception handling.
 305         * ada-valprint.c: Use C++ exception handling.
 306         * ada-typeprint.c: Use C++ exception handling.
 307         * ada-lang.c: Use C++ exception handling.
 308         * aarch64-tdep.c: Use C++ exception handling.
 309
 310 2019-04-08  Tom Tromey  <tom@tromey.com>
 311
 312         * xml-support.c (gdb_xml_parser::parse): Update.
 313         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 314         * value.c (show_convenience): Update.
 315         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
 316         (test_parse_flags_qcs): Update.
 317         * thread.c (thr_try_catch_cmd): Update.
 318         * target.c (target_translate_tls_address): Update.
 319         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 320         (info_frame_command_core, frame_apply_command_count): Update.
 321         * rust-exp.y (rust_lex_exception_test): Update.
 322         * riscv-tdep.c (riscv_print_one_register_info): Update.
 323         * remote.c (remote_target::enable_btrace): Update.
 324         * record-btrace.c (record_btrace_enable_warn): Update.
 325         * python/py-utils.c (gdbpy_convert_exception): Update.
 326         * printcmd.c (do_one_display, print_variable_and_value): Update.
 327         * mi/mi-main.c (mi_print_exception): Update.
 328         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
 329         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 330         * linux-nat.c (linux_nat_target::attach): Update.
 331         * linux-fork.c (class scoped_switch_fork_info): Update.
 332         * infrun.c (displaced_step_prepare): Update.
 333         * infcall.c (call_function_by_hand_dummy): Update.
 334         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
 335         * gnu-v3-abi.c (print_one_vtable): Update.
 336         * frame.c (get_prev_frame_always): Update.
 337         * f-valprint.c (info_common_command_for_block): Update.
 338         * exec.c (try_open_exec_file): Update.
 339         * exceptions.c (print_exception, exception_print)
 340         (exception_fprintf, exception_print_same): Update.
 341         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
 342         * dwarf-index-cache.c (index_cache::store)
 343         (index_cache::lookup_gdb_index): Update.
 344         * darwin-nat.c (maybe_cache_shell): Update.
 345         * cp-valprint.c (cp_print_value_fields): Update.
 346         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
 347         (gcc_cplus_symbol_address): Update.
 348         * compile/compile-c-symbols.c (gcc_convert_symbol)
 349         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
 350         * common/selftest.c: Update.
 351         * common/common-exceptions.h (struct gdb_exception) <message>: Now
 352         a std::string.
 353         (exception_try_scope_entry, exception_try_scope_exit): Don't
 354         declare.
 355         (struct exception_try_scope): Remove.
 356         (TRY): Don't use exception_try_scope.
 357         (struct gdb_exception): Add constructor, operator=.
 358         <what>: New method.
 359         (struct gdb_exception_RETURN_MASK_ALL)
 360         (struct gdb_exception_RETURN_MASK_ERROR)
 361         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
 362         (struct gdb_quit_bad_alloc): Update.
 363         * common/common-exceptions.c (exception_none): Change
 364         initializer.
 365         (struct catcher) <state, exception>: Initialize inline.
 366         <prev>: Remove member.
 367         (current_catcher): Remove.
 368         (catchers): New global.
 369         (exceptions_state_mc_init): Simplify.
 370         (catcher_pop): Remove.
 371         (exceptions_state_mc, exceptions_state_mc_catch): Update.
 372         (try_scope_depth, exception_try_scope_entry)
 373         (exception_try_scope_exit): Remove.
 374         (throw_exception_sjlj): Update.
 375         (exception_messages, exception_messages_size): Remove.
 376         (throw_it): Simplify.
 377         (gdb_exception_sliced_copy): Remove.
 378         (throw_exception_cxx): Update.
 379         * cli/cli-script.c (script_from_file): Update.
 380         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
 381         Update.
 382         * ada-valprint.c (ada_val_print): Update.
 383         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
 384         (create_excep_cond_exprs): Update.
 385
 386 2019-04-08  Tom Tromey  <tom@tromey.com>
 387
 388         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
 389         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
 390         (TRY, CATCH, END_CATCH): Remove some definitions.
 391         * common/common-exceptions.c: Don't use GDB_XCPT.
 392         (catcher_list_size): Remove.
 393         (throw_exception, throw_it): Simplify.
 394
 395 2019-04-05  Tom Tromey  <tom@tromey.com>
 396
 397         Revert the header-sorting patch.
 398         * ft32-tdep.c: Revert.
 399         * frv-tdep.c: Revert.
 400         * frv-linux-tdep.c: Revert.
 401         * frame.c: Revert.
 402         * frame-unwind.c: Revert.
 403         * frame-base.c: Revert.
 404         * fork-child.c: Revert.
 405         * findvar.c: Revert.
 406         * findcmd.c: Revert.
 407         * filesystem.c: Revert.
 408         * filename-seen-cache.h: Revert.
 409         * filename-seen-cache.c: Revert.
 410         * fbsd-tdep.c: Revert.
 411         * fbsd-nat.h: Revert.
 412         * fbsd-nat.c: Revert.
 413         * f-valprint.c: Revert.
 414         * f-typeprint.c: Revert.
 415         * f-lang.c: Revert.
 416         * extension.h: Revert.
 417         * extension.c: Revert.
 418         * extension-priv.h: Revert.
 419         * expprint.c: Revert.
 420         * exec.h: Revert.
 421         * exec.c: Revert.
 422         * exceptions.c: Revert.
 423         * event-top.c: Revert.
 424         * event-loop.c: Revert.
 425         * eval.c: Revert.
 426         * elfread.c: Revert.
 427         * dwarf2read.h: Revert.
 428         * dwarf2read.c: Revert.
 429         * dwarf2loc.c: Revert.
 430         * dwarf2expr.h: Revert.
 431         * dwarf2expr.c: Revert.
 432         * dwarf2-frame.c: Revert.
 433         * dwarf2-frame-tailcall.c: Revert.
 434         * dwarf-index-write.h: Revert.
 435         * dwarf-index-write.c: Revert.
 436         * dwarf-index-common.c: Revert.
 437         * dwarf-index-cache.h: Revert.
 438         * dwarf-index-cache.c: Revert.
 439         * dummy-frame.c: Revert.
 440         * dtrace-probe.c: Revert.
 441         * disasm.h: Revert.
 442         * disasm.c: Revert.
 443         * disasm-selftests.c: Revert.
 444         * dictionary.c: Revert.
 445         * dicos-tdep.c: Revert.
 446         * demangle.c: Revert.
 447         * dcache.h: Revert.
 448         * dcache.c: Revert.
 449         * darwin-nat.h: Revert.
 450         * darwin-nat.c: Revert.
 451         * darwin-nat-info.c: Revert.
 452         * d-valprint.c: Revert.
 453         * d-namespace.c: Revert.
 454         * d-lang.c: Revert.
 455         * ctf.c: Revert.
 456         * csky-tdep.c: Revert.
 457         * csky-linux-tdep.c: Revert.
 458         * cris-tdep.c: Revert.
 459         * cris-linux-tdep.c: Revert.
 460         * cp-valprint.c: Revert.
 461         * cp-support.c: Revert.
 462         * cp-namespace.c: Revert.
 463         * cp-abi.c: Revert.
 464         * corelow.c: Revert.
 465         * corefile.c: Revert.
 466         * continuations.c: Revert.
 467         * completer.h: Revert.
 468         * completer.c: Revert.
 469         * complaints.c: Revert.
 470         * coffread.c: Revert.
 471         * coff-pe-read.c: Revert.
 472         * cli-out.h: Revert.
 473         * cli-out.c: Revert.
 474         * charset.c: Revert.
 475         * c-varobj.c: Revert.
 476         * c-valprint.c: Revert.
 477         * c-typeprint.c: Revert.
 478         * c-lang.c: Revert.
 479         * buildsym.c: Revert.
 480         * buildsym-legacy.c: Revert.
 481         * build-id.h: Revert.
 482         * build-id.c: Revert.
 483         * btrace.c: Revert.
 484         * bsd-uthread.c: Revert.
 485         * breakpoint.h: Revert.
 486         * breakpoint.c: Revert.
 487         * break-catch-throw.c: Revert.
 488         * break-catch-syscall.c: Revert.
 489         * break-catch-sig.c: Revert.
 490         * blockframe.c: Revert.
 491         * block.c: Revert.
 492         * bfin-tdep.c: Revert.
 493         * bfin-linux-tdep.c: Revert.
 494         * bfd-target.c: Revert.
 495         * bcache.c: Revert.
 496         * ax-general.c: Revert.
 497         * ax-gdb.h: Revert.
 498         * ax-gdb.c: Revert.
 499         * avr-tdep.c: Revert.
 500         * auxv.c: Revert.
 501         * auto-load.c: Revert.
 502         * arm-wince-tdep.c: Revert.
 503         * arm-tdep.c: Revert.
 504         * arm-symbian-tdep.c: Revert.
 505         * arm-pikeos-tdep.c: Revert.
 506         * arm-obsd-tdep.c: Revert.
 507         * arm-nbsd-tdep.c: Revert.
 508         * arm-nbsd-nat.c: Revert.
 509         * arm-linux-tdep.c: Revert.
 510         * arm-linux-nat.c: Revert.
 511         * arm-fbsd-tdep.c: Revert.
 512         * arm-fbsd-nat.c: Revert.
 513         * arm-bsd-tdep.c: Revert.
 514         * arch-utils.c: Revert.
 515         * arc-tdep.c: Revert.
 516         * arc-newlib-tdep.c: Revert.
 517         * annotate.h: Revert.
 518         * annotate.c: Revert.
 519         * amd64-windows-tdep.c: Revert.
 520         * amd64-windows-nat.c: Revert.
 521         * amd64-tdep.c: Revert.
 522         * amd64-sol2-tdep.c: Revert.
 523         * amd64-obsd-tdep.c: Revert.
 524         * amd64-obsd-nat.c: Revert.
 525         * amd64-nbsd-tdep.c: Revert.
 526         * amd64-nbsd-nat.c: Revert.
 527         * amd64-nat.c: Revert.
 528         * amd64-linux-tdep.c: Revert.
 529         * amd64-linux-nat.c: Revert.
 530         * amd64-fbsd-tdep.c: Revert.
 531         * amd64-fbsd-nat.c: Revert.
 532         * amd64-dicos-tdep.c: Revert.
 533         * amd64-darwin-tdep.c: Revert.
 534         * amd64-bsd-nat.c: Revert.
 535         * alpha-tdep.c: Revert.
 536         * alpha-obsd-tdep.c: Revert.
 537         * alpha-nbsd-tdep.c: Revert.
 538         * alpha-mdebug-tdep.c: Revert.
 539         * alpha-linux-tdep.c: Revert.
 540         * alpha-linux-nat.c: Revert.
 541         * alpha-bsd-tdep.c: Revert.
 542         * alpha-bsd-nat.c: Revert.
 543         * aix-thread.c: Revert.
 544         * agent.c: Revert.
 545         * addrmap.c: Revert.
 546         * ada-varobj.c: Revert.
 547         * ada-valprint.c: Revert.
 548         * ada-typeprint.c: Revert.
 549         * ada-tasks.c: Revert.
 550         * ada-lang.c: Revert.
 551         * aarch64-tdep.c: Revert.
 552         * aarch64-ravenscar-thread.c: Revert.
 553         * aarch64-newlib-tdep.c: Revert.
 554         * aarch64-linux-tdep.c: Revert.
 555         * aarch64-linux-nat.c: Revert.
 556         * aarch64-fbsd-tdep.c: Revert.
 557         * aarch64-fbsd-nat.c: Revert.
 558         * aarch32-linux-nat.c: Revert.
 559
 560 2019-04-05  Tom Tromey  <tom@tromey.com>
 561
 562         * ft32-tdep.c: Sort headers.
 563         * frv-tdep.c: Sort headers.
 564         * frv-linux-tdep.c: Sort headers.
 565         * frame.c: Sort headers.
 566         * frame-unwind.c: Sort headers.
 567         * frame-base.c: Sort headers.
 568         * fork-child.c: Sort headers.
 569         * findvar.c: Sort headers.
 570         * findcmd.c: Sort headers.
 571         * filesystem.c: Sort headers.
 572         * filename-seen-cache.h: Sort headers.
 573         * filename-seen-cache.c: Sort headers.
 574         * fbsd-tdep.c: Sort headers.
 575         * fbsd-nat.h: Sort headers.
 576         * fbsd-nat.c: Sort headers.
 577         * f-valprint.c: Sort headers.
 578         * f-typeprint.c: Sort headers.
 579         * f-lang.c: Sort headers.
 580         * extension.h: Sort headers.
 581         * extension.c: Sort headers.
 582         * extension-priv.h: Sort headers.
 583         * expprint.c: Sort headers.
 584         * exec.h: Sort headers.
 585         * exec.c: Sort headers.
 586         * exceptions.c: Sort headers.
 587         * event-top.c: Sort headers.
 588         * event-loop.c: Sort headers.
 589         * eval.c: Sort headers.
 590         * elfread.c: Sort headers.
 591         * dwarf2read.h: Sort headers.
 592         * dwarf2read.c: Sort headers.
 593         * dwarf2loc.c: Sort headers.
 594         * dwarf2expr.h: Sort headers.
 595         * dwarf2expr.c: Sort headers.
 596         * dwarf2-frame.c: Sort headers.
 597         * dwarf2-frame-tailcall.c: Sort headers.
 598         * dwarf-index-write.h: Sort headers.
 599         * dwarf-index-write.c: Sort headers.
 600         * dwarf-index-common.c: Sort headers.
 601         * dwarf-index-cache.h: Sort headers.
 602         * dwarf-index-cache.c: Sort headers.
 603         * dummy-frame.c: Sort headers.
 604         * dtrace-probe.c: Sort headers.
 605         * disasm.h: Sort headers.
 606         * disasm.c: Sort headers.
 607         * disasm-selftests.c: Sort headers.
 608         * dictionary.c: Sort headers.
 609         * dicos-tdep.c: Sort headers.
 610         * demangle.c: Sort headers.
 611         * dcache.h: Sort headers.
 612         * dcache.c: Sort headers.
 613         * darwin-nat.h: Sort headers.
 614         * darwin-nat.c: Sort headers.
 615         * darwin-nat-info.c: Sort headers.
 616         * d-valprint.c: Sort headers.
 617         * d-namespace.c: Sort headers.
 618         * d-lang.c: Sort headers.
 619         * ctf.c: Sort headers.
 620         * csky-tdep.c: Sort headers.
 621         * csky-linux-tdep.c: Sort headers.
 622         * cris-tdep.c: Sort headers.
 623         * cris-linux-tdep.c: Sort headers.
 624         * cp-valprint.c: Sort headers.
 625         * cp-support.c: Sort headers.
 626         * cp-namespace.c: Sort headers.
 627         * cp-abi.c: Sort headers.
 628         * corelow.c: Sort headers.
 629         * corefile.c: Sort headers.
 630         * continuations.c: Sort headers.
 631         * completer.h: Sort headers.
 632         * completer.c: Sort headers.
 633         * complaints.c: Sort headers.
 634         * coffread.c: Sort headers.
 635         * coff-pe-read.c: Sort headers.
 636         * cli-out.h: Sort headers.
 637         * cli-out.c: Sort headers.
 638         * charset.c: Sort headers.
 639         * c-varobj.c: Sort headers.
 640         * c-valprint.c: Sort headers.
 641         * c-typeprint.c: Sort headers.
 642         * c-lang.c: Sort headers.
 643         * buildsym.c: Sort headers.
 644         * buildsym-legacy.c: Sort headers.
 645         * build-id.h: Sort headers.
 646         * build-id.c: Sort headers.
 647         * btrace.c: Sort headers.
 648         * bsd-uthread.c: Sort headers.
 649         * breakpoint.h: Sort headers.
 650         * breakpoint.c: Sort headers.
 651         * break-catch-throw.c: Sort headers.
 652         * break-catch-syscall.c: Sort headers.
 653         * break-catch-sig.c: Sort headers.
 654         * blockframe.c: Sort headers.
 655         * block.c: Sort headers.
 656         * bfin-tdep.c: Sort headers.
 657         * bfin-linux-tdep.c: Sort headers.
 658         * bfd-target.c: Sort headers.
 659         * bcache.c: Sort headers.
 660         * ax-general.c: Sort headers.
 661         * ax-gdb.h: Sort headers.
 662         * ax-gdb.c: Sort headers.
 663         * avr-tdep.c: Sort headers.
 664         * auxv.c: Sort headers.
 665         * auto-load.c: Sort headers.
 666         * arm-wince-tdep.c: Sort headers.
 667         * arm-tdep.c: Sort headers.
 668         * arm-symbian-tdep.c: Sort headers.
 669         * arm-pikeos-tdep.c: Sort headers.
 670         * arm-obsd-tdep.c: Sort headers.
 671         * arm-nbsd-tdep.c: Sort headers.
 672         * arm-nbsd-nat.c: Sort headers.
 673         * arm-linux-tdep.c: Sort headers.
 674         * arm-linux-nat.c: Sort headers.
 675         * arm-fbsd-tdep.c: Sort headers.
 676         * arm-fbsd-nat.c: Sort headers.
 677         * arm-bsd-tdep.c: Sort headers.
 678         * arch-utils.c: Sort headers.
 679         * arc-tdep.c: Sort headers.
 680         * arc-newlib-tdep.c: Sort headers.
 681         * annotate.h: Sort headers.
 682         * annotate.c: Sort headers.
 683         * amd64-windows-tdep.c: Sort headers.
 684         * amd64-windows-nat.c: Sort headers.
 685         * amd64-tdep.c: Sort headers.
 686         * amd64-sol2-tdep.c: Sort headers.
 687         * amd64-obsd-tdep.c: Sort headers.
 688         * amd64-obsd-nat.c: Sort headers.
 689         * amd64-nbsd-tdep.c: Sort headers.
 690         * amd64-nbsd-nat.c: Sort headers.
 691         * amd64-nat.c: Sort headers.
 692         * amd64-linux-tdep.c: Sort headers.
 693         * amd64-linux-nat.c: Sort headers.
 694         * amd64-fbsd-tdep.c: Sort headers.
 695         * amd64-fbsd-nat.c: Sort headers.
 696         * amd64-dicos-tdep.c: Sort headers.
 697         * amd64-darwin-tdep.c: Sort headers.
 698         * amd64-bsd-nat.c: Sort headers.
 699         * alpha-tdep.c: Sort headers.
 700         * alpha-obsd-tdep.c: Sort headers.
 701         * alpha-nbsd-tdep.c: Sort headers.
 702         * alpha-mdebug-tdep.c: Sort headers.
 703         * alpha-linux-tdep.c: Sort headers.
 704         * alpha-linux-nat.c: Sort headers.
 705         * alpha-bsd-tdep.c: Sort headers.
 706         * alpha-bsd-nat.c: Sort headers.
 707         * aix-thread.c: Sort headers.
 708         * agent.c: Sort headers.
 709         * addrmap.c: Sort headers.
 710         * ada-varobj.c: Sort headers.
 711         * ada-valprint.c: Sort headers.
 712         * ada-typeprint.c: Sort headers.
 713         * ada-tasks.c: Sort headers.
 714         * ada-lang.c: Sort headers.
 715         * aarch64-tdep.c: Sort headers.
 716         * aarch64-ravenscar-thread.c: Sort headers.
 717         * aarch64-newlib-tdep.c: Sort headers.
 718         * aarch64-linux-tdep.c: Sort headers.
 719         * aarch64-linux-nat.c: Sort headers.
 720         * aarch64-fbsd-tdep.c: Sort headers.
 721         * aarch64-fbsd-nat.c: Sort headers.
 722         * aarch32-linux-nat.c: Sort headers.
 723
 724 2019-04-04  Tom Tromey  <tom@tromey.com>
 725
 726         * varobj.c (varobj_create): Update.
 727         * rust-exp.y (struct rust_parser) <update_innermost_block,
 728         lookup_symbol>: New methods.
 729         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
 730         Rename.
 731         (rust_parser::rust_lookup_type)
 732         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 733         * printcmd.c (display_command, do_one_display): Update.
 734         * parser-defs.h (struct parser_state) <parser_state>: Add
 735         "tracker" parameter.
 736         (block_tracker): New member.
 737         (class innermost_block_tracker) <innermost_block_tracker>: Add
 738         "types" parameter.
 739         <reset>: Remove method.
 740         (innermost_block): Don't declare.
 741         (null_post_parser): Update.
 742         * parse.c (innermost_block): Remove global.
 743         (write_dollar_variable): Update.
 744         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
 745         Remove "tracker_types" parameter.
 746         (parse_expression): Add "tracker" parameter.
 747         (parse_expression_for_completion): Update.
 748         (null_post_parser): Add "tracker" parameter.
 749         * p-exp.y: Update rules.
 750         * m2-exp.y: Update rules.
 751         * language.h (struct language_defn) <la_post_parser>: Add
 752         "tracker" parameter.
 753         * go-exp.y: Update rules.
 754         * f-exp.y: Update rules.
 755         * expression.h (parse_expression, parse_exp_1): Add "tracker"
 756         parameter.
 757         * d-exp.y: Update rules.
 758         * c-exp.y: Update rules.
 759         * breakpoint.c (set_breakpoint_condition): Create an
 760         innermost_block_tracker.
 761         (watch_command_1): Likewise.
 762         * ada-lang.c (resolve): Add "tracker" parameter.
 763         (resolve_subexp): Likewise.
 764         * ada-exp.y (write_var_from_sym): Update.
 765
 766 2019-04-04  Tom Tromey  <tom@tromey.com>
 767
 768         * type-stack.h: New file.
 769         * type-stack.c: New file.
 770         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
 771         type-stack.h.
 772         (insert_into_type_stack, insert_type, push_type, push_type_int)
 773         (insert_type_address_space, pop_type, pop_type_int)
 774         (pop_typelist, pop_type_stack, append_type_stack)
 775         (push_type_stack, get_type_stack, push_typelist)
 776         (follow_type_instance_flags, follow_types): Don't declare.
 777         * parse.c (type_stack): Remove global.
 778         (parse_exp_in_context): Update.
 779         (insert_into_type_stack, insert_type, push_type, push_type_int)
 780         (insert_type_address_space, pop_type, pop_type_int)
 781         (pop_typelist, pop_type_stack, append_type_stack)
 782         (push_type_stack, get_type_stack, push_typelist)
 783         (follow_type_instance_flags, follow_types): Remove (moved to
 784         type-stack.c).
 785         * f-exp.y (type_stack): New global.
 786         Update rules.
 787         (push_kind_type, f_parse): Update.
 788         * d-exp.y (type_stack): New global.
 789         Update rules.
 790         (d_parse): Update.
 791         * c-exp.y (struct c_parse_state) <type_stack>: New member.
 792         Update rules.
 793         * Makefile.in (COMMON_SFILES): Add type-stack.c.
 794         (HFILES_NO_SRCDIR): Add type-stack.h.
 795
 796 2019-04-04  Tom Tromey  <tom@tromey.com>
 797
 798         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
 799         (rust_parser::convert_ast_to_expression, rust_parse)
 800         (rust_lex_test_completion, rust_lex_tests): Update.
 801         * parser-defs.h (struct expr_completion_state): New.
 802         (struct parser_state) <parser_state>: Add completion parameter.
 803         <mark_struct_expression, mark_completion_tag>: New methods.
 804         <parse_completion, m_completion_state>: New members.
 805         (prefixify_expression, null_post_parser): Update.
 806         (mark_struct_expression, mark_completion_tag): Don't declare.
 807         * parse.c (parse_completion, expout_last_struct)
 808         (expout_tag_completion_type, expout_completion_name): Remove
 809         globals.
 810         (parser_state::mark_struct_expression)
 811         (parser_state::mark_completion_tag): Now methods.
 812         (prefixify_expression): Add last_struct parameter.
 813         (prefixify_subexp): Likewise.
 814         (parse_exp_1): Update.
 815         (parse_exp_in_context): Add cstate parameter.  Update.
 816         (parse_expression_for_completion): Create an
 817         expr_completion_state.
 818         (null_post_parser): Add "completion" parameter.
 819         * p-exp.y: Update rules.
 820         (yylex): Update.
 821         * language.h (struct language_defn) <la_post_parser>: Add
 822         "completing" parameter.
 823         * go-exp.y: Update rules.
 824         (lex_one_token): Update.
 825         * expression.h (parse_completion): Don't declare.
 826         * d-exp.y: Update rules.
 827         (lex_one_token): Update rules.
 828         * c-exp.y: Update rules.
 829         (lex_one_token): Update.
 830         * ada-lang.c (resolve): Add "parse_completion" parameter.
 831         (resolve_subexp): Likewise.
 832         (ada_resolve_function): Likewise.
 833
 834 2019-04-04  Tom Tromey  <tom@tromey.com>
 835
 836         * parser-defs.h (struct parser_state) <start_arglist,
 837         end_arglist>: New methods.
 838         <arglist_len, m_funcall_chain>: New members.
 839         (arglist_len, start_arglist, end_arglist): Don't declare.
 840         * parse.c (arglist_len, funcall_chain): Remove global.
 841         (start_arglist, end_arglist): Remove functions.
 842         (parse_exp_in_context): Update.
 843         * p-exp.y: Update rules.
 844         * m2-exp.y: Update rules.
 845         * go-exp.y: Update rules.
 846         * f-exp.y: Update rules.
 847         * d-exp.y: Update rules.
 848         * c-exp.y: Update rules.
 849
 850 2019-04-04  Tom Tromey  <tom@tromey.com>
 851
 852         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
 853         lex_operator, push_back>: New methods.
 854         Update all rules.
 855         (rust_parser::lex_hex, lex_escape): Rename and update.
 856         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
 857         (rust_parser::lex_operator): Rename and update.
 858         (rust_parser::lex_number, rustyylex, rustyyerror)
 859         (rust_lex_test_init, rust_lex_test_sequence)
 860         (rust_lex_test_push_back, rust_lex_tests): Update.
 861         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
 862         parameter.
 863         <lexptr, prev_lexptr>: New members.
 864         (lexptr, prev_lexptr): Don't declare.
 865         * parse.c (lexptr, prev_lexptr): Remove globals.
 866         (parse_exp_in_context): Update.
 867         * p-exp.y (yylex, yyerror): Update.
 868         * m2-exp.y (parse_number, yylex, yyerror): Update.
 869         * go-exp.y (lex_one_token, yyerror): Update.
 870         * f-exp.y (match_string_literal, yylex, yyerror): Update.
 871         * d-exp.y (lex_one_token, yyerror): Update.
 872         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
 873         (lex_one_token, yyerror): Update.
 874         * ada-lex.l (YY_INPUT): Update.
 875         (rewind_to_char): Update.
 876         * ada-exp.y (yyerror): Update.
 877
 878 2019-04-04  Tom Tromey  <tom@tromey.com>
 879
 880         * rust-exp.y (rustyylex, rust_lex_tests): Update.
 881         * parser-defs.h (struct parser_state) <parser_state>: Add new
 882         parameter.
 883         <comma_terminates>: New member.
 884         (comma_terminates): Don't declare global.
 885         * parse.c (comma_terminates): Remove global.
 886         (parse_exp_in_context): Update.
 887         * p-exp.y (yylex): Update.
 888         * m2-exp.y (yylex): Update.
 889         * go-exp.y (lex_one_token): Update.
 890         * f-exp.y (yylex): Update.
 891         * d-exp.y (lex_one_token): Update.
 892         * c-exp.y (lex_one_token): Update.
 893         * ada-lex.l: Update.
 894
 895 2019-04-04  Tom Tromey  <tom@tromey.com>
 896
 897         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
 898         (rustyylex, rust_lex_test_init, rust_lex_test_one)
 899         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
 900         * parser-defs.h (paren_depth): Don't declare.
 901         * parse.c (paren_depth): Remove global.
 902         (parse_exp_in_context): Update.
 903         * p-exp.y (paren_depth): New global.
 904         (pascal_parse): Initialize it.
 905         * m2-exp.y (paren_depth): New global.
 906         (m2_parse): Initialize it.
 907         * go-exp.y (paren_depth): New global.
 908         (go_parse): Initialize it.
 909         * f-exp.y (paren_depth): New global.
 910         (f_parse): Initialize it.
 911         * d-exp.y (paren_depth): New global.
 912         (d_parse): Initialize it.
 913         * c-exp.y (paren_depth): New global.
 914         (c_parse): Initialize it.
 915         * ada-lex.l (paren_depth): New global.
 916         (lexer_init): Initialize it.
 917
 918 2019-04-04  Tom Tromey  <tom@tromey.com>
 919
 920         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
 921         (rust_parser::convert_ast_to_type)
 922         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 923         * parser-defs.h (struct parser_state) <parser_state>: Add
 924         parameters.  Initialize new members.
 925         <expression_context_block, expression_context_pc>: New members.
 926         * parse.c (expression_context_block, expression_context_pc):
 927         Remove globals.
 928         (parse_exp_in_context): Update.
 929         * p-exp.y: Update all rules.
 930         (yylex): Update.
 931         * m2-exp.y: Update all rules.
 932         (yylex): Update.
 933         * go-exp.y (yylex): Update.
 934         * f-exp.y (yylex): Update.
 935         * d-exp.y: Update all rules.
 936         (yylex): Update.
 937         * c-exp.y: Update all rules.
 938         (lex_one_token, classify_name, yylex, c_parse): Update.
 939         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
 940
 941 2019-04-04  Tom Tromey  <tom@tromey.com>
 942
 943         * gdbarch.h, gdbarch.c: Rebuild.
 944         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
 945         * stap-probe.h:
 946         (struct stap_parse_info): Replace "parser_state" with
 947         "expr_builder".
 948         * parser-defs.h (struct expr_builder): Rename from "parser_state".
 949         (parser_state): New class.
 950         * parse.c (expr_builder): Rename.
 951         (expr_builder::release): Rename.
 952         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
 953         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
 954         (write_exp_elt_longcst, write_exp_elt_floatcst)
 955         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
 956         (write_exp_string_vector, write_exp_bitstring)
 957         (write_exp_msymbol, mark_struct_expression)
 958         (write_dollar_variable)
 959         (insert_type_address_space, increase_expout_size): Replace
 960         "parser_state" with "expr_builder".
 961         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
 962         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
 963         "parser_state" with "expr_builder".
 964
 965 2019-04-04  Tom Tromey  <tom@tromey.com>
 966
 967         * rust-exp.y: Replace "parse_language" with method call.
 968         * p-exp.y:
 969         (yylex): Replace "parse_language" with method call.
 970         * m2-exp.y:
 971         (yylex): Replace "parse_language" with method call.
 972         * go-exp.y (classify_name): Replace "parse_language" with method
 973         call.
 974         * f-exp.y (yylex): Replace "parse_language" with method call.
 975         * d-exp.y (lex_one_token): Replace "parse_language" with method
 976         call.
 977         * c-exp.y:
 978         (lex_one_token, classify_name, yylex): Replace "parse_language"
 979         with method call.
 980         * ada-exp.y (find_primitive_type, type_char)
 981         (type_system_address): Replace "parse_language" with method call.
 982
 983 2019-04-04  Tom Tromey  <tom@tromey.com>
 984
 985         * rust-exp.y: Replace "parse_gdbarch" with method call.
 986         * parse.c (write_dollar_variable, insert_type_address_space):
 987         Replace "parse_gdbarch" with method call.
 988         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
 989         call.
 990         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
 991         call.
 992         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
 993         "parse_gdbarch" with method call.
 994         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
 995         with method call.
 996         * f-exp.y (parse_type, parse_f_type, yylex): Replace
 997         "parse_gdbarch" with method call.
 998         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
 999         "parse_gdbarch" with method call.
1000         * c-exp.y (parse_type, parse_number, classify_name): Replace
1001         "parse_gdbarch" with method call.
1002         * ada-lex.l: Replace "parse_gdbarch" with method call.
1003         * ada-exp.y (parse_type, find_primitive_type, type_char)
1004         (type_system_address): Replace "parse_gdbarch" with method call.
1005
1006 2019-04-04  Tom Tromey  <tom@tromey.com>
1007
1008         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1009         * stap-probe.c (stap_parse_argument): Update.
1010         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1011         initial_size parameter.
1012         * rust-exp.y (rust_lex_tests): Update.
1013         * parse.c (parser_state): Update.
1014         (parse_exp_in_context): Update.
1015         * parser-defs.h (struct parser_state) <parser_state>: Remove
1016         "initial_size" parameter.
1017
1018 2019-04-04  Tom Tromey  <tom@tromey.com>
1019
1020         * parser-defs.h (increase_expout_size): Don't declare.
1021         * parse.c (increase_expout_size): Now static.
1022
1023 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1024
1025         * gnu-nat.c (gnu_nat_target::wait): Fix
1026         target_waitstatus_to_string call.
1027
1028 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * eval.c (evaluate_subexp_standard): Handle internal functions
1031         during Fortran function call handling.
1032
1033 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * NEWS: Mention new internal functions.
1036         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1037         (read_base_type): Use dwarf2_init_complex_target_type.
1038         * value.c (creal_internal_fn): New function.
1039         (cimag_internal_fn): New function.
1040         (_initialize_values): Register new internal functions.
1041
1042 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1043
1044         * infrun.c (stop_all_threads): If debug_infrun, always
1045         trace the wait status after wait_one, using
1046         target_waitstatus_to_string and target_pid_to_str.
1047         (handle_inferior_event): Replace various trace of
1048         wait status kind by a single trace.
1049         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1050         wait status kind image by target_waitstatus_to_string.
1051         * target/waitstatus.c (target_waitstatus_to_string): Fix
1052         obsolete comment.
1053
1054 2019-04-01  Tom Tromey  <tromey@adacore.com>
1055
1056         PR symtab/23331:
1057         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1058
1059 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1060             Pedro Alves  <palves@redhat.com>
1061
1062         * top.c (quit_force): Call 'finalize_values'.
1063         * value.c (finalize_values): New function.
1064         * value.h (finalize_values): Declare.
1065
1066 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1067
1068         * NEWS: Announce $_gdb_major and $_gdb_minor.
1069
1070         * top.c (init_gdb_version_vars): New function.
1071         (gdb_init): Call init_gdb_version_vars.
1072
1073 2019-03-29  Tom Tromey  <tromey@adacore.com>
1074
1075         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1076         help text.  Remove dead code.
1077
1078 2019-03-29  Keith Seitz  <keiths@redhat.com>
1079
1080         From Siddhesh Poyarekar:
1081         * f-lang.h (f77_get_upperbound): Return LONGEST.
1082         (f77_get_lowerbound): Likewise.
1083         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1084         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1085         print them.
1086         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1087         plongest to format print it.
1088         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1089         (f77_get_upperbound): Likewise.
1090         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1091         LOWER_BOUND to LONGEST.
1092         (f77_create_arrayprint_offset_tbl): Likewise.
1093
1094 2019-03-29  Keith Seitz  <keiths@redhat.com>
1095
1096         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1097         %s/pulongest for TYPE_LENGTH instead of %d in format
1098         strings.
1099         * ada-typerint.c (ada_print_type): Likewise.
1100         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1101         * compile/compile-c-support.c (generate_register_struct): Likewise.
1102         * gdbtypes.c (recursive_dump_type): Likewise.
1103         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1104         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1105         instead of %d in format strings.
1106         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1107         to std::min to ULONGEST.
1108         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1109         instead of %d in format strings.
1110         * tracepoint.c (info_scope_command): Likewise.
1111         * typeprint.c (print_offset_data::update)
1112         (print_offset_data::finish): Likewise.
1113         * xtensa-tdep.c (xtensa_store_return_value)
1114         (xtensa_push_dummy_call): Likewise.
1115
1116 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1117
1118         * windows-nat.c (display_selector): Fixed format specifications
1119         for 64-bit Cygwin.
1120
1121 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1122
1123         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1124
1125 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1126
1127         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1128         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1129         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1130         (nios2_linux_init_abi): Install it.
1131
1132 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1133
1134         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1135
1136 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1137
1138         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1139
1140 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1141             Tom Tromey  <tromey@adacore.com>
1142
1143         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1144
1145 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1146
1147         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1148         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1149         method to compute the bounds of range types. Also print "[evaluated]"
1150         if the bounds' values come from a dynamic evaluation.
1151
1152 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1155         whitespace when pretty printing is on.
1156
1157 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1158
1159         * ppc-linux-nat.c: Add include.
1160
1161 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1162
1163         * NEWS: Mention AArch64 Pointer Authentication.
1164
1165 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1166
1167         * arm-linux-nat.c: Add include.
1168
1169 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1170
1171         * source-cache.c (source_cache::get_source_lines): Re-read
1172         fullname after calling open_source_file.
1173
1174 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1175
1176         * NEWS: Mention TLS support for FreeBSD.
1177
1178 2019-03-25  Tom Tromey  <tromey@adacore.com>
1179
1180         * minsyms.c (BUNCH_SIZE): Update comment.
1181         (~minimal_symbol_reader): Remove old comment.
1182         (compact_minimal_symbols): Update comment.
1183         (minimal_symbol_reader::install): Remove old comment.  Update
1184         other comments.
1185
1186 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1187
1188         * s390-linux-nat.c: Add include.
1189
1190 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1191
1192         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1193         Call linux_get_hwcap.
1194         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1195         Likewise.
1196         (aarch64_linux_get_hwcap): Remove function.
1197         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1198         declaration.
1199         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1200         linux_get_hwcap.
1201         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1202         * linux-tdep.c (linux_get_hwcap): Add function.
1203         (linux_get_hwcap2): Likewise.
1204         * linux-tdep.h (linux_get_hwcap): Add declaration.
1205         (linux_get_hwcap2): Likewise.
1206         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1207         (ppc_linux_get_hwcap2): Likewise.
1208         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1209         linux_get_hwcap.
1210         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1211         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1212         (ppc_linux_nat_target::read_description): Likewise.
1213         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1214         * s390-linux-nat.c: Likewise.
1215         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1216
1217 2019-03-24  Tom Tromey  <tom@tromey.com>
1218
1219         * ada-lang.c (standard_lookup): Simplify initialization.
1220         (ada_lookup_symbol_nonlocal): Simplify return.
1221         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1222         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1223         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1224         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1225         initialization.
1226         * solib.c (solib_global_lookup): Simplify.
1227         * symtab.c (null_block_symbol): Remove.
1228         (symbol_cache_lookup): Simplify returns.
1229         (lookup_language_this): Simplify returns.
1230         (lookup_symbol_aux): Simplify return.
1231         (lookup_local_symbol): Simplify returns.
1232         (lookup_global_symbol_from_objfile): Simplify return.
1233         (lookup_symbol_in_objfile_symtabs)
1234         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1235         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1236         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1237         * cp-namespace.c (cp_lookup_bare_symbol)
1238         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1239         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1240         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1241         (cp_lookup_symbol_via_imports): Simplify initialization.
1242         (find_symbol_in_baseclass): Likewise.
1243         * symtab.h (null_block_symbol): Remove.
1244         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1245         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1246         (d_lookup_symbol_module): Likewise.
1247         (find_symbol_in_baseclass): Simplify initialization.
1248
1249 2019-03-24  Tom Tromey  <tom@tromey.com>
1250
1251         * expression.h: Don't include symtab.h.
1252         (struct block): Forward declare.
1253
1254 2019-03-24  Tom Tromey  <tom@tromey.com>
1255
1256         * c-exp.y (typebase): Remove casts.
1257         * gdbtypes.c (lookup_unsigned_typename, )
1258         (lookup_signed_typename): Remove cast.
1259         * eval.c (parse_to_comma_and_eval): Remove cast.
1260         * parse.c (write_dollar_variable): Remove cast.
1261         * block.h (struct block) <superblock>: Now const.
1262         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1263         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1264         (map_block): Make "block" const.
1265         * symfile.h (struct quick_symbol_functions)
1266         <map_matching_symbols>: Constify block argument to "callback".
1267         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1268         const.
1269         (find_pc_sect_compunit_symtab): Make "b" const.
1270         (find_symbol_at_address): Likewise.
1271         (search_symbols): Likewise.
1272         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1273         (dw2_debug_names_lookup_symbol): Likewise.
1274         (dw2_map_matching_symbols): Update.
1275         * p-valprint.c (pascal_val_print): Remove "block".
1276         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1277         (aux_add_nonlocal_symbols): Make "block" const.
1278         (resolve_subexp): Remove cast.
1279         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1280         const.
1281         (iterate_over_file_blocks): Likewise.
1282         * f-exp.y (%union) <bval>: Remove.
1283         * coffread.c (patch_opaque_types): Make "b" const.
1284         * spu-tdep.c (spu_catch_start): Make "block" const.
1285         * c-valprint.c (print_unpacked_pointer): Remove "block".
1286         * symmisc.c (dump_symtab_1): Make "b" const.
1287         (block_depth): Make "block" const.
1288         * d-exp.y (%union) <bval>: Remove.
1289         * cp-support.h (cp_lookup_rtti_type): Update.
1290         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1291         * psymtab.c (psym_lookup_symbol): Make "block" const.
1292         (maintenance_check_psymtabs): Make "b" const.
1293         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1294         (enumerate_locals, enumerate_args): Update.
1295         * python/py-symtab.c (stpy_global_block): Make "block" const.
1296         (stpy_static_block): Likewise.
1297         * inline-frame.c (block_starting_point_at): Make "new_block"
1298         const.
1299         * block.c (find_block_in_blockvector): Make return type const.
1300         (blockvector_for_pc_sect): Make "b" const.
1301         (find_block_in_blockvector): Make "b" const.
1302
1303 2019-03-23  Tom Tromey  <tom@tromey.com>
1304
1305         * varobj.c (varobj_create): Update.
1306         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1307         * printcmd.c (display_command, do_one_display): Don't reset
1308         innermost_block.
1309         * parser-defs.h (enum innermost_block_tracker_type): Move to
1310         expression.h.
1311         (innermost_block): Update comment.
1312         * parse.c (parse_exp_1): Add tracker_types parameter.
1313         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1314         tracker_types parameter.  Reset innermost_block.
1315         (parse_exp_in_context): Remove.
1316         (parse_expression_for_completion): Update.
1317         * objfiles.c (~objfile): Don't reset expression_context_block or
1318         innermost_block.
1319         * expression.h (enum innermost_block_tracker_type): Move from
1320         parser-defs.h.
1321         (parse_exp_1): Add tracker_types parameter.
1322         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1323         reset innermost_block.
1324
1325 2019-03-23  Tom Tromey  <tom@tromey.com>
1326
1327         * objfiles.h: Include bcache.h.
1328
1329 2019-03-23  Tom Tromey  <tom@tromey.com>
1330
1331         * linespec.c (get_current_search_block): Use
1332         scoped_restore_current_language.
1333         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1334
1335 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1336             Jiong Wang  <jiong.wang@arm.com>
1337
1338         * aarch64-linux-tdep.c
1339         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1340         section.
1341         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1342
1343 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1344             Jiong Wang  <jiong.wang@arm.com>
1345
1346         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1347         instructions.
1348         (aarch64_analyze_prologue_test): Add PACIASP test.
1349         (aarch64_prologue_prev_register): Unmask PC value.
1350
1351 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1352             Jiong Wang  <jiong.wang@arm.com>
1353
1354         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1355         (aarch64_dwarf2_prev_register): Unmask PC value.
1356         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1357         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1358         DW_CFA_AARCH64_negate_ra_state.
1359         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1360
1361 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1362             Jiong Wang  <jiong.wang@arm.com>
1363
1364         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1365         registers.
1366         (aarch64_pseudo_register_name): Likewise.
1367         (aarch64_pseudo_register_type): Likewise.
1368         (aarch64_pseudo_register_reggroup_p): Likewise.
1369         (aarch64_gdbarch_init): Add pauth registers.
1370         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1371         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1372         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1373         (struct gdbarch_tdep): Add regnum for ra_state.
1374
1375 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1376             Jiong Wang  <jiong.wang@arm.com>
1377
1378         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1379
1380 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1381             Jiong Wang  <jiong.wang@arm.com>
1382
1383         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1384         function.
1385         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1386         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1387         (aarch64_gdbarch_init): Add puth registers.
1388         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1389         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1390         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1391
1392 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1393             Jiong Wang  <jiong.wang@arm.com>
1394
1395         * aarch64-linux-nat.c
1396         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1397         * aarch64-linux-tdep.c
1398         (aarch64_linux_core_read_description): Likewise.
1399         (aarch64_linux_get_hwcap): New function.
1400         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1401         (aarch64_linux_get_hwcap): New declaration.
1402
1403 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1404             Jiong Wang  <jiong.wang@arm.com>
1405
1406         * aarch64-linux-nat.c
1407         (aarch64_linux_nat_target::read_description): Add pauth param.
1408         * aarch64-linux-tdep.c
1409         (aarch64_linux_core_read_description): Likewise.
1410         * aarch64-tdep.c (struct target_desc): Add in pauth.
1411         (aarch64_read_description): Add pauth param.
1412         (aarch64_gdbarch_init): Likewise.
1413         * aarch64-tdep.h (aarch64_read_description): Likewise.
1414         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1415         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1416         * features/Makefile: Add new files.
1417         * features/aarch64-pauth.c: New file.
1418         * features/aarch64-pauth.xml: New file.
1419
1420 2019-03-20  Tom Tromey  <tromey@adacore.com>
1421
1422         * infrun.c (handle_inferior_event): Rename from
1423         handle_inferior_event_1.  Create a scoped_value_mark.
1424         (handle_inferior_event): Remove.
1425
1426 2019-03-19  Tom Tromey  <tromey@adacore.com>
1427
1428         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1429         * infrun.h (print_stop_event): Add "displays" parameter.
1430         * infrun.c (print_stop_event): Add "displays" parameter.
1431
1432 2019-03-19  Pedro Alves  <palves@redhat.com>
1433
1434         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1435         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1436         to -1.  Fix TABs vs spaces.
1437         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1438         * tui/tui-out.h (tui_ui_out) Add intro comments.
1439         <m_line, m_start_of_line>: In-class initialize, and add describing
1440         comment.
1441
1442 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1443
1444         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1445         variable names.
1446         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1447
1448 2019-03-18  Pedro Alves  <palves@redhat.com>
1449             Eli Zaretskii <eliz@gnu.org>
1450
1451         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1452         m_line and m_start_of_line.
1453
1454 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1455
1456         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1457         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1458         it returns a newline.  This fixes a regression in TU mode, whereby
1459         the next line is output on the same screen line as the user input.
1460
1461 2019-03-18  Tom Tromey  <tromey@adacore.com>
1462
1463         * minsyms.c (minimal_symbol_reader::install): Remove call to
1464         obstack_blank.
1465
1466 2019-03-18  Pedro Alves  <palves@redhat.com>
1467
1468         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1469         New globals.
1470         (apply_style): New, factored out from ...
1471         (apply_ansi_escape): ... this.  Handle reverse video mode.
1472         (tui_set_reverse_mode): New function.
1473         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1474         * tui/tui-winsource.c (tui_show_source_line): Use
1475         tui_set_reverse_mode instead of setting A_STANDOUT.
1476         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1477         New setter methods.
1478
1479 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1480
1481         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1482         Handle tabs.
1483
1484 2019-03-18  Tom Tromey  <tromey@adacore.com>
1485
1486         * ada-lang.c (empty_array): Add "high" parameter.
1487         (ada_evaluate_subexp): Update.
1488
1489 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1490
1491         * unittests/string_view-selftests.c: Define
1492         _initialize_string_view_selftests unconditionally.
1493
1494 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1495
1496         PR gdb/24350
1497         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1498
1499 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1500
1501         PR gdb/24351
1502         * windows-nat.c (display_selector): Fix format specifiers.
1503
1504 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1505
1506         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1507         tui_refill_source_window instead of tui_refresh_win, to update the
1508         current execution line.  This fixes redisplay of the current line
1509         when stepping through the code with "next" or "step".
1510
1511 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1512
1513         * source-cache.c (source_cache::get_source_lines): Call
1514         find_source_lines to initialize s->nlines.  This fixes vertical
1515         scrolling of TUI source window when the DOWN arrow is pressed.
1516
1517 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1518
1519         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1520         linux-thread-db.c (_initialize_thread_db): Likewise.
1521
1522 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1523
1524         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1525         wclrtoeol in tui_show_source_line".  This reverts changes made in
1526         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1527
1528 2019-03-15  Tom Tromey  <tom@tromey.com>
1529
1530         * symtab.h (struct minimal_symbol): Derive from
1531         general_symbol_info.
1532         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1533         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1534         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1535         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1536         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1537         (MSYMBOL_SEARCH_NAME): Update.
1538         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1539         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1540         * minsyms.c (minimal_symbol_reader::record_full): Update.
1541
1542 2019-03-15  Tom Tromey  <tom@tromey.com>
1543
1544         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1545
1546 2019-03-15  Tom Tromey  <tom@tromey.com>
1547
1548         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1549         unique_xmalloc_ptr.
1550         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1551         Update.
1552         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1553         (build_minimal_symbol_hash_tables)
1554         (minimal_symbol_reader::install): Update.
1555
1556 2019-03-15  Tom Tromey  <tom@tromey.com>
1557
1558         * symtab.c (create_demangled_names_hash): Update.
1559         (symbol_set_names): Update.
1560         * objfiles.h (struct objfile_per_bfd_storage)
1561         <demangled_names_hash>: Now an htab_up.
1562         * objfiles.c (objfile_per_bfd_storage): Simplify.
1563
1564 2019-03-15  Tom Tromey  <tom@tromey.com>
1565
1566         * objfiles.h (struct objfile_per_bfd_storage): Declare
1567         destructor.
1568         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1569         New.
1570         (get_objfile_bfd_data): Use new.  Don't initialize
1571         language_of_main.
1572         (free_objfile_per_bfd_storage): Remove.
1573         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1574
1575 2019-03-15  Tom Tromey  <tom@tromey.com>
1576
1577         * symfile.c (reread_symbols): Update.
1578         * objfiles.c (objfile::objfile): Update.
1579         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1580         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1581         comment.
1582         (minimal_symbol_reader::install): Update.
1583         (terminate_minimal_symbol_table): Remove.
1584         * jit.c (jit_object_close_impl): Update.
1585
1586 2019-03-15  Tom Tromey  <tom@tromey.com>
1587
1588         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1589         initializations.
1590
1591 2019-03-15  Tom Tromey  <tom@tromey.com>
1592
1593         * objfiles.h (struct objfile_per_bfd_storage)
1594         <demangled_hash_languages>: Now a bitset.
1595         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1596         (lookup_minimal_symbol): Update.
1597
1598 2019-03-15  Tom Tromey  <tom@tromey.com>
1599
1600         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1601         Don't return the symbol.
1602         * coffread.c (record_minimal_symbol): Use record_full.
1603
1604 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1605
1606         The MS-Windows port of ncurses fails to switch to a color pair if
1607         one or both of the colors are the implicit default colors.  This
1608         change records the default colors when TUI is initialized, and
1609         then specifies them explicitly when a color pair uses the default
1610         colors.  This allows color styling in TUI mode on MS-Windows.
1611
1612         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1613         ncurses_norm_attr.
1614         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1615         colors in ncurses_norm_attr.
1616         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1617         "none", replace it with the default color recorded in
1618         ncurses_norm_attr.
1619
1620 2019-03-14  Tom Tromey  <tromey@adacore.com>
1621
1622         * source-cache.h (class source_cache) <get_source_lines>: Return
1623         std::string.
1624         * source-cache.c (source_cache::extract_lines): Handle case where
1625         first_pos==npos.  Return std::string.
1626         (source_cache::get_source_lines): Update.
1627
1628 2019-03-14  Tom Tromey  <tromey@adacore.com>
1629
1630         * NEWS: Add item for "style sources" commands.
1631         * source-cache.c (source_cache::get_source_lines): Check
1632         source_styling.
1633         * cli/cli-style.c (source_styling): New global.
1634         (_initialize_cli_style): Add "style sources" commands.
1635         (show_style_sources): New function.
1636         * cli/cli-style.h (source_styling): Declare.
1637
1638 2019-03-14  Pedro Alves  <palves@redhat.com>
1639             Tom Tromey  <tromey@adacore.com>
1640
1641         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1642         * tui/tui-winsource.c (tui_refill_source_window): New function,
1643         from...
1644         (tui_horizontal_source_scroll): ... here.  Move some logic.
1645         * cli/cli-style.c (set_style_enabled): Notify new observable.
1646         * tui/tui-hooks.c (tui_redisplay_source): New function.
1647         (tui_attach_detach_observers): Attach or detach
1648         tui_redisplay_source.
1649         * observable.h (source_styling_changed): New observable.
1650         * observable.c: Define source_styling_changed observable.
1651
1652 2019-03-13  Tom Tromey  <tromey@adacore.com>
1653
1654         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1655         (i386_gnu_nat_target::store_registers): Update.
1656         * target-debug.h (target_debug_print_std_string): New macro.
1657         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1658         * windows-tdep.c (display_one_tib): Update.
1659         * tui/tui-stack.c (tui_make_status_line): Update.
1660         * top.c (print_inferior_quit_action): Update.
1661         * thread.c (thr_try_catch_cmd): Update.
1662         (add_thread_with_info): Update.
1663         (thread_target_id_str): Update.
1664         (thr_try_catch_cmd): Update.
1665         (thread_command): Update.
1666         (thread_find_command): Update.
1667         * record-btrace.c (record_btrace_target::info_record)
1668         (record_btrace_resume_thread, record_btrace_target::resume)
1669         (record_btrace_cancel_resume, record_btrace_step_thread)
1670         (record_btrace_target::wait, record_btrace_target::wait)
1671         (record_btrace_target::wait, record_btrace_target::stop): Update.
1672         * progspace.c (print_program_space): Update.
1673         * process-stratum-target.c
1674         (process_stratum_target::thread_address_space): Update.
1675         * linux-fork.c (linux_fork_mourn_inferior)
1676         (detach_checkpoint_command, info_checkpoints_command)
1677         (linux_fork_context): Update.
1678         (linux_fork_detach): Update.
1679         (class scoped_switch_fork_info): Update.
1680         (delete_checkpoint_command): Update.
1681         * infrun.c (follow_fork_inferior): Update.
1682         (follow_fork_inferior): Update.
1683         (proceed_after_vfork_done): Update.
1684         (handle_vfork_child_exec_or_exit): Update.
1685         (follow_exec): Update.
1686         (displaced_step_prepare_throw): Update.
1687         (displaced_step_restore): Update.
1688         (start_step_over): Update.
1689         (resume_1): Update.
1690         (clear_proceed_status_thread): Update.
1691         (proceed): Update.
1692         (print_target_wait_results): Update.
1693         (do_target_wait): Update.
1694         (context_switch): Update.
1695         (stop_all_threads): Update.
1696         (restart_threads): Update.
1697         (finish_step_over): Update.
1698         (handle_signal_stop): Update.
1699         (switch_back_to_stepped_thread): Update.
1700         (keep_going_pass_signal): Update.
1701         (print_exited_reason): Update.
1702         (normal_stop): Update.
1703         * inferior.c (inferior_pid_to_str): Change return type.
1704         (print_selected_inferior): Update.
1705         (add_inferior): Update.
1706         (detach_inferior): Update.
1707         * dummy-frame.c (fprint_dummy_frames): Update.
1708         * dcache.c (dcache_info_1): Update.
1709         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1710         (btrace_fetch, btrace_clear): Update.
1711         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1712         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1713         type.
1714         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1715         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1716         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1717         * gdbarch.c, gdbarch.h: Rebuild.
1718         * gdbarch.sh (core_pid_to_str): Change return type.
1719         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1720         return type.
1721         (windows_nat_target::pid_to_str): Change return type.
1722         (windows_delete_thread): Update.
1723         (windows_nat_target::attach): Update.
1724         (windows_nat_target::files_info): Update.
1725         * target-delegates.c: Rebuild.
1726         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1727         return type.
1728         (sol_thread_target::pid_to_str): Change return type.
1729         * remote.c (class remote_target) <pid_to_str>: Change return
1730         type.
1731         (remote_target::pid_to_str): Change return type.
1732         (extended_remote_target::attach, remote_target::remote_stop_ns)
1733         (remote_target::remote_notif_remove_queued_reply)
1734         (remote_target::push_stop_reply, remote_target::disable_btrace):
1735         Update.
1736         (extended_remote_target::attach): Update.
1737         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1738         type.
1739         (gdbsim_target::pid_to_str): Change return type.
1740         * ravenscar-thread.c (struct ravenscar_thread_target)
1741         <pid_to_str>: Change return type.
1742         (ravenscar_thread_target::pid_to_str): Change return type.
1743         * procfs.c (class procfs_target) <pid_to_str>: Change return
1744         type.
1745         (procfs_target::pid_to_str): Change return type.
1746         (procfs_target::attach): Update.
1747         (procfs_target::detach): Update.
1748         (procfs_target::fetch_registers): Update.
1749         (procfs_target::store_registers): Update.
1750         (procfs_target::wait): Update.
1751         (procfs_target::files_info): Update.
1752         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1753         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1754         return type.
1755         (nto_procfs_target::pid_to_str): Change return type.
1756         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1757         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1758         return type.
1759         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1760         (exit_lwp): Update.
1761         (attach_proc_task_lwp_callback, get_detach_signal)
1762         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1763         (linux_nat_target::resume, wait_lwp, stop_callback)
1764         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1765         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1766         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1767         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1768         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1769         type.
1770         (inf_ptrace_target::attach): Update.
1771         (inf_ptrace_target::files_info): Update.
1772         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1773         type.
1774         (go32_nat_target::pid_to_str): Change return type.
1775         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1776         (gnu_nat_target::wait): Update.
1777         (gnu_nat_target::wait): Update.
1778         (gnu_nat_target::resume): Update.
1779         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1780         (fbsd_nat_target::wait): Update.
1781         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1782         type.
1783         (darwin_nat_target::attach): Update.
1784         * corelow.c (class core_target) <pid_to_str>: Change return type.
1785         (core_target::pid_to_str): Change return type.
1786         * target.c (normal_pid_to_str): Change return type.
1787         (default_pid_to_str): Likewise.
1788         (target_pid_to_str): Change return type.
1789         (target_translate_tls_address): Update.
1790         (target_announce_detach): Update.
1791         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1792         return type.
1793         (bsd_uthread_target::pid_to_str): Change return type.
1794         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1795         type.
1796         (bsd_kvm_target::pid_to_str): Change return type.
1797         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1798         return type.
1799         (aix_thread_target::pid_to_str): Change return type.
1800         * target.h (struct target_ops) <pid_to_str>: Change return type.
1801         (target_pid_to_str, normal_pid_to_str): Likewise.
1802         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1803         type.
1804         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1805         type.
1806         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1807         return type.
1808         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1809         type.
1810         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1811         type.
1812         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1813         return type.
1814
1815 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1816
1817         * NEWS: Mention that the new default MI version is 3.  Mention
1818         changes to the output of commands and events that deal with
1819         multi-location breakpoints.
1820         * breakpoint.c: Include "mi/mi-out.h".
1821         (print_one_breakpoint): Change output syntax if using MI version
1822         >= 3.
1823         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1824         New.
1825         (mi_multi_location_breakpoint_output_fixed): New.
1826         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1827         (mi_cmd_fix_multi_location_breakpoint_output): New.
1828         (mi_multi_location_breakpoint_output_fixed): New.
1829         * mi/mi-cmds.c (mi_cmds): Register command
1830         -fix-multi-location-breakpoint-output.
1831         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1832         interpreter "mi".
1833
1834 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1835
1836         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1837         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1838         instantiate mi_ui_out based on interpreter name.
1839         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1840         * mi/mi-main.c (mi_load_progress): Likewise.
1841
1842 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1843
1844         * NEWS: Combine separate "New targets" sections for 8.3.
1845
1846 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1847
1848         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1849         (ppcfbsd_init_abi): Install gdbarch
1850         "fetch_tls_load_module_address" and "get_thread_local_address"
1851         methods.
1852
1853 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1854
1855         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1856         (riscv_fbsd_init_abi): Install gdbarch
1857         "fetch_tls_load_module_address" and "get_thread_local_address"
1858         methods.
1859
1860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1861
1862         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1863         (i386fbsd_init_abi): Install gdbarch
1864         "fetch_tls_load_module_address" and "get_thread_local_address"
1865         methods.
1866
1867 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1868
1869         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1870         (amd64fbsd_init_abi): Install gdbarch
1871         "fetch_tls_load_module_address" and "get_thread_local_address"
1872         methods.
1873
1874 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1875
1876         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1877         (struct fbsd_pspace_data): New type.
1878         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1879         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1880         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1881         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1882         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1883
1884 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1885
1886         * gdbtypes.c (lookup_struct_elt): New function.
1887         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1888         * gdbtypes.h (struct struct_elt): New type.
1889         (lookup_struct_elt): New prototype.
1890
1891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1892
1893         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1894         remove disabled code block.
1895
1896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1897
1898         * gdbarch.sh (get_thread_local_address): New method.
1899         * gdbarch.h, gdbarch.c: Regenerate.
1900         * target.c (target_translate_tls_address): Use
1901         gdbarch_get_thread_local_address if present instead of
1902         target::get_thread_local_address.
1903
1904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1905
1906         * target.h (target::get_thread_local_address): Update comment.
1907
1908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1909
1910         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1911         objfile->separate_debug_objfile_backlink if not NULL.
1912
1913 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1914
1915         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1916         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1917         (amd64bsd_store_inferior_registers): Likewise.
1918         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1919         Enable segment base registers.
1920         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1921         PT_GETFSBASE and PT_GETGSBASE.
1922         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1923         PT_SETGSBASE.
1924         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1925         segment base registers.
1926         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1927
1928 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1929
1930         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1931         Update calls to i386_target_description to add 'segments'
1932         parameter.
1933         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1934         add segment base registers.
1935         * arch/i386.c (i386_create_target_description): Add 'segments'
1936         parameter to enable segment base registers.
1937         * arch/i386.h (i386_create_target_description): Likewise.
1938         * features/i386/32bit-segments.xml: New file.
1939         * features/i386/32bit-segments.c: Generate.
1940         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1941         call to i386_target_description to add 'segments' parameter.
1942         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1943         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1944         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1945         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1946         if feature is present.
1947         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1948         Add 'segments' parameter to call to i386_target_description.
1949         (i386_target_description): Add 'segments' parameter to enable
1950         segment base registers.
1951         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1952         to call to i386_target_description.
1953         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1954         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1955         Define I386_NUM_REGS.
1956         (i386_target_description): Add 'segments' parameter to enable
1957         segment base registers.
1958
1959 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1960
1961         PR/24325
1962         * source-cache.c: #undef open and close, to avoid unresolved
1963         externals during linking.
1964
1965 2019-03-12  Tom Tromey  <tromey@adacore.com>
1966
1967         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1968         const.  Add initializers.
1969         (_initialize_remote): Don't initialize ptid globals.
1970
1971 2019-03-12  Pedro Alves  <palves@redhat.com>
1972
1973         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1974
1975 2019-03-12  Pedro Alves  <palves@redhat.com>
1976
1977         * cp-name-parser.y (main): Remove unused 'len' variable.
1978
1979 2019-03-12  Tom Tromey  <tromey@adacore.com>
1980
1981         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1982         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1983
1984 2019-03-12  Tom Tromey  <tromey@adacore.com>
1985
1986         * linux-nat.c (iterate_over_lwps): Update.
1987         (stop_callback): Remove parameter.
1988         (stop_wait_callback, detach_callback, resume_set_callback)
1989         (select_singlestep_lwp_callback, set_ignore_sigint)
1990         (status_callback, resumed_callback, resume_clear_callback)
1991         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1992         data parameter.
1993         (linux_nat_target::detach, linux_nat_target::resume)
1994         (linux_stop_and_wait_all_lwps, select_event_lwp)
1995         (linux_nat_filter_event, linux_nat_wait_1)
1996         (linux_nat_target::kill, linux_nat_target::stop)
1997         (linux_nat_target::stop): Update.
1998         (linux_nat_resume_callback): Change type.
1999         (resume_stopped_resumed_lwps, count_events_callback)
2000         (select_event_lwp_callback): Likewise.
2001         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2002         * arm-linux-nat.c (struct update_registers_data): Remove.
2003         (update_registers_callback): Change type.
2004         (arm_linux_insert_hw_breakpoint1): Update.
2005         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2006         parameter.
2007         (x86_linux_dr_set_addr): Update.
2008         (x86_linux_dr_set_control): Update.
2009         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2010         (iterate_over_lwps): Use gdb::function_view.
2011         * nat/aarch64-linux-hw-point.c (struct
2012         aarch64_dr_update_callback_param): Remove.
2013         (debug_reg_change_callback): Change type.
2014         (aarch64_notify_debug_reg_change): Update.
2015         * s390-linux-nat.c (s390_refresh_per_info): Update.
2016
2017 2019-03-11  Tom Tromey  <tromey@adacore.com>
2018
2019         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2020         redundant assignment to "this_cu".
2021
2022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2023
2024         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2025
2026 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2027
2028         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2029         from...
2030         (rank_one_type): ... this.
2031
2032 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2033
2034         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2035         from...
2036         (rank_one_type): ... this.
2037
2038 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2039
2040         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2041         from...
2042         (rank_one_type): ... this.
2043
2044 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2045
2046         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2047         from...
2048         (rank_one_type): ... this.
2049
2050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2051
2052         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2053         from...
2054         (rank_one_type): ... this.
2055
2056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2057
2058         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2059         from...
2060         (rank_one_type): ... this.
2061
2062 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2063
2064         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2065         from...
2066         (rank_one_type): ... this.
2067
2068 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2069
2070         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2071         from...
2072         (rank_one_type): ... this.
2073
2074 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2075
2076         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2077         from...
2078         (rank_one_type): ... this.
2079
2080 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2081
2082         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2083         from...
2084         (rank_one_type): ... this.
2085
2086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2087
2088         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2089         from...
2090         (rank_one_type): ... this.
2091
2092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2093
2094         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2095         from...
2096         (rank_one_type): ... this.
2097
2098 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2099
2100         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2101         inferior-events' shows the example events.
2102
2103 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2104
2105         Support styling on native MS-Windows console
2106
2107         PR/24315
2108         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2109         on MS-Windows if $TERM is not defined.
2110
2111         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2112
2113         * posix-hdep.c (gdb_console_fputs):
2114         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2115         functions.
2116         * ui-file.h (gdb_console_fputs): Add prototype.
2117
2118         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2119         back to fputs only if the former returns zero.
2120
2121 2019-03-07  Tom Tromey  <tom@tromey.com>
2122
2123         * symmisc.c (print_symbol_bcache_statistics): Update.
2124         (print_objfile_statistics): Update.
2125         * symfile.c (allocate_symtab): Update.
2126         * stabsread.c: Don't include bcache.h.
2127         * psymtab.h (struct psymbol_bcache): Don't declare.
2128         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2129         (psymbol_bcache_init, psymbol_bcache_free)
2130         (psymbol_bcache_get_bcache): Don't declare.
2131         * psymtab.c (struct psymbol_bcache): Remove.
2132         (psymtab_storage::psymtab_storage): Update.
2133         (psymtab_storage::~psymtab_storage): Update.
2134         (psymbol_bcache_init, psymbol_bcache_free)
2135         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2136         (add_psymbol_to_bcache): Update.
2137         (allocate_psymtab): Update.
2138         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2139         macro_cache>: No longer pointers.
2140         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2141         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2142         * macrotab.c (macro_bcache): Update.
2143         * macroexp.c: Don't include bcache.h.
2144         * gdbtypes.c (check_types_worklist): Update.
2145         (types_deeply_equal): Remove TRY/CATCH.  Update.
2146         * elfread.c (elf_symtab_read): Update.
2147         * dwarf2read.c: Don't include bcache.h.
2148         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2149         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2150         (print_bcache_statistics, bcache_memory_used): Don't declare.
2151         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2152         methods.  Rename all data members.
2153         * bcache.c (struct bcache): Move to bcache.h.
2154         (bcache::expand_hash_table): Rename from expand_hash_table.
2155         (bcache): Remove.
2156         (bcache::insert): Rename from bcache_full.
2157         (bcache::compare): Rename from bcache_compare.
2158         (bcache_xmalloc): Remove.
2159         (bcache::~bcache): Rename from bcache_xfree.
2160         (bcache::print_statistics): Rename from print_bcache_statistics.
2161         (bcache::memory_used): Rename from bcache_memory_used.
2162
2163 2019-03-07  Pedro Alves  <palves@redhat.com>
2164
2165         * infrun.c (normal_stop): Also check for
2166         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2167
2168 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2169
2170         * f-lang.c (value_from_host_double): Moved to...
2171         * value.c (value_from_host_double): ...here.
2172         * value.h (value_from_host_double): Declare.
2173         * guile/scm-math.c (vlscm_convert_typed_number): Use
2174         value_from_host_double.
2175         (vlscm_convert_number): Likewise.
2176         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2177         * python/py-value.c (convert_value_from_python): Likewise.
2178
2179 2019-03-06  Tom Tromey  <tom@tromey.com>
2180
2181         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2182
2183 2019-03-06  Tom Tromey  <tom@tromey.com>
2184
2185         * utils.h (free_current_contents): Don't declare.
2186         * utils.c (free_current_contents): Remove.
2187
2188 2019-03-06  Tom Tromey  <tom@tromey.com>
2189
2190         * top.c (quit_force): Update.
2191         * main.c (captured_command_loop): Update.
2192         * common/new-op.c (operator new): Update.
2193         * common/common-exceptions.c (struct catcher)
2194         <save_cleanup_chain>: Remove member.
2195         (exceptions_state_mc_init): Update.
2196         (exception_try_scope_entry): Return nullptr.
2197         (exception_try_scope_exit, exception_rethrow)
2198         (throw_exception_sjlj, throw_exception_cxx): Update.
2199         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2200         (all_cleanups, do_cleanups, discard_cleanups)
2201         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2202         (restore_cleanups, restore_final_cleanups): Don't declare.
2203         (do_final_cleanups): Remove parameter.
2204         * common/cleanups.c (cleanup_chain, make_cleanup)
2205         (make_cleanup_dtor, all_cleanups, do_cleanups)
2206         (discard_my_cleanups, discard_cleanups)
2207         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2208         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2209         (null_cleanup): Remove.
2210         (do_final_cleanups): Remove parameter.
2211
2212 2019-03-06  Tom Tromey  <tom@tromey.com>
2213
2214         * remote.c (remote_target::remote_parse_stop_reply): Use
2215         unique_xmalloc_ptr.
2216
2217 2019-03-06  Tom Tromey  <tom@tromey.com>
2218
2219         * stabsread.c (struct stabs_field_info): Rename from field_info.
2220         <list, fnlist>: Add initializers.
2221         <obstack>: New member.
2222         (read_member_functions, read_struct_fields, read_baseclasses):
2223         Allocate on obstack.  Don't use cleanups.
2224         (read_one_struct_field, read_member_functions, read_struct_fields)
2225         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2226         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2227         (read_struct_type): Update.
2228
2229 2019-03-06  Tom Tromey  <tom@tromey.com>
2230
2231         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2232         * common/filestuff.h (make_cleanup_close): Don't declare.
2233         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2234         Remove.
2235
2236 2019-03-06  Tom Tromey  <tom@tromey.com>
2237
2238         * solib-aix.c: Use make_scope_exit.
2239
2240 2019-03-06  Tom Tromey  <tom@tromey.com>
2241
2242         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2243         Use make_scope_exit.
2244
2245 2019-03-06  Tom Tromey  <tom@tromey.com>
2246
2247         * solib-svr4.c (disable_probes_interface): Remove parameter.
2248         (svr4_handle_solib_event): Use make_scope_exit.
2249
2250 2019-03-06  Tom Tromey  <tom@tromey.com>
2251
2252         * remote.c (struct stop_reply_deleter): Remove.
2253         (stop_reply_up): Update.
2254         (struct stop_reply): Derive from notif_event.  Don't typedef.
2255         <regcache>: Now a std::vector.
2256         (stop_reply_xfree): Remove.
2257         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2258         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2259         (remote_target::discard_pending_stop_replies): Use delete.
2260         (remote_target::remote_parse_stop_reply): Update.
2261         (remote_target::process_stop_reply): Update.
2262         * remote-notif.h (struct notif_event): Add virtual destructor.
2263         Remove "dtr" member.
2264         (struct notif_client) <alloc_event>: Return a unique_ptr.
2265         (notif_event_xfree): Don't declare.
2266         (notif_event_up): New typedef.
2267         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2268         (notif_event_xfree, do_notif_event_xfree): Remove.
2269         (remote_notif_state_xfree): Update.
2270
2271 2019-03-06  Tom Tromey  <tom@tromey.com>
2272
2273         * infrun.c (displaced_step_clear_cleanup): Now a
2274         forward_scope_exit type.
2275         (displaced_step_prepare_throw): Update.
2276         (displaced_step_fixup): Update.
2277
2278 2019-03-06  Tom Tromey  <tom@tromey.com>
2279
2280         * inferior.h (class inferior): Update comment.
2281         * gdbthread.h (class thread_info): Update comment.
2282
2283 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2284             Tom Tromey  <tom@tromey.com>
2285
2286         * stabsread.h (struct stab_section_list): Remove.
2287         (coffstab_build_psymtabs): Update.
2288         * dbxread.c (symbuf_sections): Now a std::vector.
2289         (sect_idx): New global.
2290         (fill_symbuf): Update.
2291         (coffstab_build_psymtabs): Change type of stabsects parameter.
2292         Update.
2293         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2294         std::vector.
2295         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2296         (coff_locate_sections): Update.
2297         (coff_symfile_read): Remove cleanups.  Update.
2298         (init_stringtab): Add storage parameter.
2299         (free_stringtab, free_stringtab_cleanup): Remove.
2300         (init_lineno): Add storage parameter.
2301         (free_linetab, free_linetab_cleanup): Remove.
2302
2303 2019-03-06  Pedro Alves  <palves@redhat.com>
2304
2305         * linux-fork.c (fork_info::clobber_regs): Delete.
2306         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2307         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2308         comment.  Adjust.
2309         (scoped_switch_fork_info::scoped_switch_fork_info)
2310         (checkpoint_command, linux_fork_context): Adjust
2311         fork_save_infrun_state calls.
2312
2313 2019-03-06  Pedro Alves  <palves@redhat.com>
2314
2315         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2316         (inf_has_multiple_threads): Return 'bool' and rewrite using
2317         inferior_info::threads().
2318
2319 2019-03-06  Pedro Alves  <palves@redhat.com>
2320
2321         * linux-fork.c: Include <list>.
2322         (fork_list): Now a std::list instance.
2323         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2324         (forks_exist_p, find_last_fork): Adjust.
2325         (new_fork): Delete.
2326         (one_fork_p): New.
2327         (add_fork): Adjust.
2328         (free_fork): Delete, folded into fork_info::~fork_info().
2329         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2330         Adjust.
2331         (init_fork_list): Delete.
2332         (linux_fork_killall, linux_fork_mourn_inferior)
2333         (linux_fork_detach, info_checkpoints_command): Adjust.
2334         (_initialize_linux_fork): No longer call init_fork_list.
2335
2336 2019-03-06  Pedro Alves  <palves@redhat.com>
2337
2338         * linux-fork.c (new_fork): New, split out of ...
2339         (add_fork): ... this.  Return void.  Move "first fork" special
2340         case from here, to ...
2341         (checkpoint_command): ... here.
2342         * linux-linux.h (add_fork): Return void.
2343
2344 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2345
2346         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2347
2348 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2349             Chris January  <chris.january@arm.com>
2350             David Lecomber  <david.lecomber@arm.com>
2351
2352         * f-exp.y: New token, UNOP_INTRINSIC.
2353         (exp): New pattern using UNOP_INTRINSIC token.
2354         (f77_keywords): Add 'abs' keyword.
2355         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2356         (value_from_host_double): New function.
2357         (evaluate_subexp_f): Support UNOP_ABS.
2358
2359 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2360
2361         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2362         types.
2363
2364 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2365
2366         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2367         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2368         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2369
2370 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2371
2372         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2373
2374 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2375             Chris January  <chris.january@arm.com>
2376
2377         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2378         * f-exp.y: Define 'KIND' token.
2379         (exp): New pattern for KIND expressions.
2380         (ptype): Handle types with a kind extension.
2381         (direct_abs_decl): Extend to spot kind extensions.
2382         (f77_keywords): Add 'kind' to the list.
2383         (push_kind_type): New function.
2384         (convert_to_kind_type): New function.
2385         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2386         * parse.c (operator_length_standard): Likewise.
2387         * parser-defs.h (enum type_pieces): Add tp_kind.
2388         * std-operator.def: Add UNOP_KIND.
2389
2390 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * f-exp.y (f_parse): Set yydebug.
2393
2394 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * f-lang.c (evaluate_subexp_f): New function.
2397         (exp_descriptor_f): New global.
2398         (f_language_defn): Use exp_descriptor_f instead of
2399         exp_descriptor_standard.
2400
2401 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2402
2403         * f-exp.y (struct token): Add comments.
2404         (dot_ops): Remove uppercase versions and the end marker.
2405         (f77_keywords): Likewise.
2406         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2407         entries in the dot_ops array are case insensitive, and use
2408         strncasecmp to compare strings.  Also some whitespace cleanup in
2409         this area.  Similar for the f77_keywords array, except entries in
2410         this list might be case sensitive.
2411
2412 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2413
2414         * f-exp.y (struct f77_boolean_val): Add comments.
2415         (boolean_values): Remove uppercase versions, and end marker.
2416         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2417         and use strncasecmp to achieve case insensitivity.  Additionally,
2418         perform whitespace cleanup around this code.
2419
2420 2019-03-06  Tom Tromey  <tromey@adacore.com>
2421
2422         * remote-sim.c (gdbsim_target_open): Use result of
2423         gdb_argv::release.
2424
2425 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2426         Dirk Schubert  <dirk.schubert@arm.com>
2427         Chris January  <chris.january@arm.com>
2428
2429         * eval.c (evaluate_subexp_standard): Call Fortran argument
2430         wrapping logic.
2431         * f-lang.c (struct value): A value which can be passed into a
2432         Fortran function call.
2433         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2434         where appropriate.
2435         (struct type): Value ready for a Fortran function call.
2436         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2437         is needed.
2438         * f-lang.h (fortran_argument_convert): Declaration.
2439         (fortran_preserve_arg_pointer): Declaration.
2440         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2441
2442 2019-03-05  Tom Tromey  <tromey@adacore.com>
2443
2444         * python/py-prettyprint.c (print_string_repr): Remove #if.
2445         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2446
2447 2019-03-05  Tom Tromey  <tromey@adacore.com>
2448
2449         * target.c (the_dummy_target): Move later.  Change type to
2450         "dummy_target".
2451         (initialize_targets): Don't initialize the_dummy_target.
2452
2453 2019-03-05  Tom Tromey  <tromey@adacore.com>
2454
2455         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2456         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2457
2458 2019-03-05  Tom Tromey  <tromey@adacore.com>
2459
2460         * windows-nat.c (windows_nat_target::attach)
2461         (windows_nat_target::detach): Don't call gdb_flush.
2462         * valprint.c (generic_val_print, val_print, val_print_string):
2463         Don't call gdb_flush.
2464         * utils.c (defaulted_query): Don't call gdb_flush.
2465         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2466         * target.c (target_announce_detach): Don't call gdb_flush.
2467         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2468         * remote.c (extended_remote_target::attach): Don't call
2469         gdb_flush.
2470         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2471         * printcmd.c (do_examine): Don't call gdb_flush.
2472         (info_display_command): Don't call gdb_flush.
2473         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2474         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2475         * memattr.c (info_mem_command): Don't call gdb_flush.
2476         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2477         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2478         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2479         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2480         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2481         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2482         (gnu_nat_target::detach): Don't call gdb_flush.
2483         * f-valprint.c (f_val_print): Don't call gdb_flush.
2484         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2485         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2486         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2487         gdb_flush.
2488         * c-valprint.c (c_val_print): Don't call gdb_flush.
2489         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2490
2491 2019-03-05  Tom Tromey  <tromey@adacore.com>
2492
2493         * varobj.c (update_dynamic_varobj_children): Update.
2494         (install_default_visualizer): Use reset, not release.
2495         * value.c (set_internalvar): Update.
2496         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2497         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2498         ATTRIBUTE_UNUSED_RESULT.
2499
2500 2019-03-05  Tom Tromey  <tromey@adacore.com>
2501
2502         * remote.c (class scoped_remote_fd) <release>: Add
2503         ATTRIBUTE_UNUSED_RESULT.
2504
2505 2019-03-05  Tom Tromey  <tromey@adacore.com>
2506
2507         * macroexp.c (struct macro_buffer) <release>: Add
2508         ATTRIBUTE_UNUSED_RESULT.
2509
2510 2019-03-05  Tom Tromey  <tromey@adacore.com>
2511
2512         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2513         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2514         ATTRIBUTE_UNUSED_RESULT.
2515
2516 2019-03-05  Tom Tromey  <tromey@adacore.com>
2517
2518         * common/scoped_fd.h (class scoped_fd) <release>: Add
2519         ATTRIBUTE_UNUSED_RESULT.
2520
2521 2019-03-05  Tom Tromey  <tromey@adacore.com>
2522
2523         * parser-defs.h (struct parser_state) <release>: Add
2524         ATTRIBUTE_UNUSED_RESULT.
2525
2526 2019-03-05  Tom Tromey  <tromey@adacore.com>
2527
2528         * utils.h (class gdb_argv) <release>: Add
2529         ATTRIBUTE_UNUSED_RESULT.
2530         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2531
2532 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2533
2534         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2535         for-loop range, to avoid compiler warnings.
2536
2537         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2538         avoid compiler warnings about unused variables.
2539
2540         * NEWS: Mention end of support for native debugging on MS-Windows
2541         before XP.
2542
2543         PR gdb/24292
2544         * common/netstuff.c:
2545         * gdbserver/gdbreplay.c
2546         * gdbserver/remote-utils.c:
2547         * ser-tcp.c:
2548         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2549         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2550         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2551         'getaddrinfo' and 'freeaddrinfo' were not available before
2552         Windows XP, and mingw.org's MinGW headers by default define
2553         _WIN32_WINNT to 0x500.
2554
2555 2019-03-01  Gary Benson <gbenson@redhat.com>
2556
2557         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2558
2559 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2560             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2561
2562         PR gdb/8527
2563         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2564         set_sigint_trap, clear_sigint_trap.
2565
2566 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2567
2568         * target.c (target_detach): Clear the regcache and the
2569         frame cache.
2570
2571 2019-02-27  Pedro Alves  <palves@redhat.com>
2572
2573         * utils.c (set_screen_size): When we cap the height/width sizes,
2574         tweak the corresponding command variable to show "unlimited":
2575
2576 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2577             Pedro Alves  <palves@redhat.com>
2578
2579         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2580         before calling rl_set_screen_size.
2581
2582 2019-02-27  Tom Tromey  <tromey@adacore.com>
2583
2584         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2585         define.
2586         * python/py-value.c: Remove Python 2.4 workaround.
2587         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2588         workaround.
2589         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2590         Python 2.4 workaround.
2591         * python/python-internal.h: Remove Python 2.4 comment.
2592         (Py_ssize_t): Don't define.
2593         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2594         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2595         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2596         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2597         * python/python.c (do_start_initialization): Remove Python 2.4
2598         workaround.
2599         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2600         (print_children): Remove Python 2.4 workaround.
2601         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2602         workaround.
2603         (CHARBUFFERPROC_NAME): Remove.
2604         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2605         Python 2.4 workaround.
2606
2607 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2608
2609         * NEWS: Note minimum Python version.
2610
2611 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2612
2613         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2614         code from these functions.  Remove corresponding ifdefs.  Use
2615         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2616         Remove gotos and target of gotos.
2617         (infpy_search_memory): Likewise.
2618
2619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2622         (hppa_gdbarch_init): Don't register deleted functions with
2623         gdbarch.
2624
2625 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2626
2627         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2628         (h8300_unwind_sp): Delete.
2629         (h8300_dummy_id): Delete.
2630         (h8300_gdbarch_init): Don't register deleted functions with
2631         gdbarch.
2632
2633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2634
2635         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2636         (ft32_unwind_pc): Delete.
2637         (ft32_unwind_sp): Delete.
2638         (ft32_gdbarch_init): Don't register deleted functions with
2639         gdbarch.
2640
2641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2642
2643         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2644         (frv_unwind_pc): Delete.
2645         (frv_unwind_sp): Delete.
2646         (frv_gdbarch_init): Don't register deleted functions with
2647         gdbarch.
2648
2649 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2650
2651         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2652         (riscv_unwind_pc): Delete.
2653         (riscv_unwind_sp): Delete.
2654         (riscv_gdbarch_init): Don't register deleted functions with
2655         gdbarch.
2656
2657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2658
2659         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2660         (csky_unwind_pc): Delete.
2661         (csky_unwind_sp): Delete.
2662         (csky_gdbarch_init): Don't register deleted functions with
2663         gdbarch.
2664
2665 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2668         (cris_unwind_pc): Delete.
2669         (cris_unwind_sp): Delete.
2670         (cris_gdbarch_init): Don't register deleted functions with
2671         gdbarch.
2672
2673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2674
2675         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2676         (bfin_unwind_pc): Delete.
2677         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2678
2679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2680
2681         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2682         (arm_unwind_pc): Delete.
2683         (arm_unwind_sp): Delete.
2684         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2685
2686 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2687
2688         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2689         (arc_unwind_pc): Delete.
2690         (arc_unwind_sp): Delete.
2691         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2692
2693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2694
2695         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2696         (alpha_unwind_pc): Delete.
2697         (alpha_gdbarch_init): Don't register deleted functions with
2698         gdbarch.
2699
2700 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2701
2702         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2703         (aarch64_unwind_pc): Delete.
2704         (aarch64_unwind_sp): Delete.
2705         (aarch64_gdbarch_init): Don't register deleted functions with
2706         gdbarch.
2707
2708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         * gdbtypes.c (type_align): Don't consider static members when
2711         computing structure alignment.
2712
2713 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2714
2715         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2716         return 0 for other types.
2717         * arch-utils.c (default_type_align): Always return 0.
2718         * gdbarch.h: Regenerate.
2719         * gdbarch.sh (type_align): Extend comment.
2720         * gdbtypes.c (type_align): Add additional comments, always call
2721         gdbarch_type_align before applying the default rules.
2722         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2723         generic code will then apply a suitable default.
2724         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2725         types, return 0 for other types.
2726
2727 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2728
2729         * NEWS: Create a new section for the next release branch.
2730         Rename the section of the current branch, now that it has
2731         been cut.
2732
2733 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2734
2735         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2736         * version.in: Bump version to 8.3.50.DATE-git.
2737
2738 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2739
2740         * aix-thread.c (ptid_cmp): Remove unused variable.
2741         (get_signaled_thread): Likewise.
2742         (store_regs_user_thread): Likewise.
2743         (store_regs_kernel_thread): Likewise.
2744         (fetch_regs_kernel_thread): Remove shadowed variable.
2745
2746 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2747
2748         * features/riscv/32bit-cpu.xml: Add register numbers.
2749         * features/riscv/32bit-fpu.c: Regenerate.
2750         * features/riscv/32bit-fpu.xml: Add register numbers.
2751         * features/riscv/64bit-cpu.xml: Add register numbers.
2752         * features/riscv/64bit-fpu.c: Regenerate.
2753         * features/riscv/64bit-fpu.xml: Add register numbers.
2754
2755 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2756
2757         * NEWS: Mention two argument form of gdb.Value constructor.
2758         * python/py-value.c (convert_buffer_and_type_to_value): New
2759         function.
2760         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2761         Add support for handling an optional second argument.  Call
2762         convert_buffer_and_type_to_value as appropriate.
2763         * python/python-internal.h (Py_buffer_deleter): New struct.
2764         (Py_buffer_up): New typedef.
2765
2766 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2767
2768         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2769         instead of releasing ownership.
2770
2771 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2772
2773         * dwarf2read.c (open_and_init_dwp_file): Call
2774         elf_numsections instead of bfd_count_sections to initialize
2775         dwp_file->num_sections.
2776
2777 2019-02-25  Tom Tromey  <tromey@adacore.com>
2778
2779         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2780
2781 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2782
2783         * gcore.in: Add '--readnever' option when invoking GDB.
2784
2785 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2786
2787         * MAINTAINERS: Update my email address.
2788
2789 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2790
2791         * build-id.c (build_id_to_debug_bfd_1): New function.
2792         (build_id_to_debug_bfd): Look for separate debug file in
2793         sysroot.
2794
2795 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2796
2797         * gdbarch.sh: Update the copyright year range that is placed into
2798         generated files.
2799
2800 2019-02-22  Keith Seitz  <keiths@redhat.com>
2801
2802         PR symtab/23853
2803         * linespec.c (create_sals_line_offset): Search for the default
2804         symtab's filename instead of its fullname.
2805
2806 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2807
2808         * NEWS: Update style defaults.
2809
2810 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2811
2812         * main.c (captured_main_1): Disable styling in batch mode.
2813
2814 2019-02-20  Tom Tromey  <tom@tromey.com>
2815
2816         * symtab.c (symtab_symbol_info): Fix typos.
2817
2818 2019-02-20  Tom Tromey  <tromey@adacore.com>
2819
2820         * findcmd.c (_initialize_mem_search): Use upper case for
2821         metasyntactic variables.
2822
2823 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2824
2825         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2826         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2827
2828 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2829
2830         * top.h (source_file_name): Change to std::string.
2831         * top.c (source_file_name): Likewise.
2832         (command_line_input): Adjust.
2833         * cli/cli-script.c (script_from_file): Adjust.
2834
2835 2019-02-19  Tom Tromey  <tromey@adacore.com>
2836
2837         * ravenscar-thread.c
2838         (ravenscar_thread_target::update_thread_list): Don't call
2839         ada_build_task_list.
2840         * ada-lang.h (ada_build_task_list): Don't declare.
2841         * ada-tasks.c (struct ada_tasks_inferior_data)
2842         <task_list_valid_p>: Now bool.
2843         (read_known_tasks, ada_task_list_changed)
2844         (ada_tasks_invalidate_inferior_data): Update.
2845         (read_known_tasks_array): Return bool.
2846         (read_known_tasks_list): Likewise.
2847         (read_known_tasks): Return void.
2848         (ada_build_task_list): Now static.
2849
2850 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2853         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2854
2855 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2856
2857         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2858         variant for ada_tasks_pspace_data_handle and
2859         ada_tasks_inferior_data_handle.
2860         (ada_tasks_pspace_data_cleanup): New function.
2861         (ada_tasks_inferior_data_cleanup): New function.
2862
2863 2019-02-17  Tom Tromey  <tom@tromey.com>
2864
2865         * macrotab.h (macro_source_fullname): Return a std::string.
2866         * macrotab.c (macro_include, check_for_redefinition)
2867         (macro_undef, macro_lookup_definition, foreach_macro)
2868         (foreach_macro_in_scope): Update.
2869         (macro_source_fullname): Return a std::string.
2870         * macrocmd.c (show_pp_source_pos): Update.
2871
2872 2019-02-17  Tom Tromey  <tom@tromey.com>
2873
2874         * macrocmd.c (show_pp_source_pos): Style the file names.
2875
2876 2019-02-17  Tom Tromey  <tom@tromey.com>
2877
2878         PR tui/24197:
2879         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2880
2881 2019-02-17  Tom Tromey  <tom@tromey.com>
2882
2883         * ada-lang.c (user_select_syms): Use filtered printing.
2884         * utils.c (wrap_style): New global.
2885         (desired_style): Remove.
2886         (emit_style_escape): Add stream parameter.
2887         (set_output_style, reset_terminal_style, prompt_for_continue):
2888         Update.
2889         (flush_wrap_buffer): Only flush gdb_stdout.
2890         (wrap_here): Set wrap_style.
2891         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2892         treat escape sequences as a character.  Change when wrap buffer is
2893         flushed.
2894         (fputs_styled): Do not set the output style when the default is
2895         requested.
2896         * ui-style.h (struct ui_file_style) <is_default>: New method.
2897         * source.c (print_source_lines_base): Emit escape sequences in one
2898         piece.
2899
2900 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2901
2902         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2903         integers and enumeration types.
2904
2905 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2906
2907         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2908         instead of lookup_symbol_in_language
2909         (do_exact_match): New function.
2910         (ada_get_symbol_name_matcher): Return do_exact_match when
2911         doing a verbatim match.
2912
2913 2019-02-15  Tom Tromey  <tromey@adacore.com>
2914
2915         * ravenscar-thread.c (ravenscar_thread_target::resume)
2916         (ravenscar_thread_target::wait): Special case wildcard requests.
2917
2918 2019-02-15  Tom Tromey  <tromey@adacore.com>
2919
2920         * ravenscar-thread.c (base_ptid): Remove.
2921         (struct ravenscar_thread_target) <close>: New method.
2922         <m_base_ptid>: New member.
2923         <update_inferior_ptid, active_task, task_is_currently_active,
2924         runtime_initialized>: Declare methods.
2925         <ravenscar_thread_target>: Add constructor.
2926         (ravenscar_thread_target::task_is_currently_active)
2927         (ravenscar_thread_target::update_inferior_ptid)
2928         (ravenscar_runtime_initialized): Rename.  Now methods.
2929         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2930         (ravenscar_thread_target::update_thread_list): Update.
2931         (ravenscar_thread_target::active_task): Now method.
2932         (ravenscar_thread_target::store_registers)
2933         (ravenscar_thread_target::prepare_to_store)
2934         (ravenscar_thread_target::prepare_to_store)
2935         (ravenscar_thread_target::mourn_inferior): Update.
2936         (ravenscar_inferior_created): Use "new" to create target.
2937         (ravenscar_thread_target::get_ada_task_ptid): Update.
2938         (_initialize_ravenscar): Don't initialize base_ptid.
2939         (ravenscar_ops): Remove global.
2940
2941 2019-02-15  Tom Tromey  <tromey@adacore.com>
2942
2943         * target.h (push_target): Declare new overload.
2944         * target.c (push_target): New overload, taking an rvalue reference.
2945         * remote.c (remote_target::open_1): Use push_target overload.
2946         * corelow.c (core_target_open): Use push_target overload.
2947
2948 2019-02-15  Tom Tromey  <tromey@adacore.com>
2949
2950         * ravenscar-thread.c (is_ravenscar_task)
2951         (ravenscar_task_is_currently_active): Return bool.
2952         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2953         (_initialize_ravenscar): Remove "(void)".
2954         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2955         Return bool.
2956
2957 2019-02-15  Tom Tromey  <tromey@adacore.com>
2958
2959         * ravenscar-thread.c (ravenscar_runtime_initializer)
2960         (has_ravenscar_runtime, get_running_thread_id)
2961         (ravenscar_thread_target::resume): Fix indentation.
2962
2963 2019-02-15  Tom Tromey  <tromey@adacore.com>
2964
2965         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2966         from ravenscar_arch_ops.
2967         (sparc_ravenscar_ops::fetch_registers)
2968         (sparc_ravenscar_ops::store_registers): Now methods.
2969         (sparc_ravenscar_prepare_to_store): Remove.
2970         (sparc_ravenscar_ops): Redefine.
2971         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2972         methods and destructor.  Remove members.
2973         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2974         (ravenscar_thread_target::store_registers)
2975         (ravenscar_thread_target::prepare_to_store): Update.
2976         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2977         Remove.
2978         (struct ppc_ravenscar_powerpc_ops): Derive from
2979         ravenscar_arch_ops.
2980         (ppc_ravenscar_powerpc_ops::fetch_registers)
2981         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2982         (ppc_ravenscar_powerpc_ops): Redefine.
2983         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2984         (ppc_ravenscar_e500_ops::fetch_registers)
2985         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2986         (ppc_ravenscar_e500_ops): Redefine.
2987         * aarch64-ravenscar-thread.c
2988         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2989         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2990         (aarch64_ravenscar_fetch_registers)
2991         (aarch64_ravenscar_store_registers): Now methods.
2992         (aarch64_ravenscar_ops): Redefine.
2993
2994 2019-02-15  Tom Tromey  <tromey@adacore.com>
2995
2996         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2997         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2998         (ravenscar_thread_target::stopped_by_watchpoint)
2999         (ravenscar_thread_target::stopped_data_address)
3000         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3001
3002 2019-02-15  Tom Tromey  <tromey@adacore.com>
3003
3004         * ravenscar-thread.c: Fix some typos.
3005
3006 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3007             Tom Tromey  <tromey@adacore.com>
3008
3009         * ada-lang.c (ada_exception_sal): Change addr_string to a
3010         std::string.
3011         (create_ada_exception_catchpoint): Update.
3012
3013 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3014             Tom Tromey  <tromey@adacore.com>
3015
3016         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3017         (bp_location_ops): Remove.
3018         (base_breakpoint_allocate_location): Update.
3019         (free_bp_location): Update.
3020         * ada-lang.c (class ada_catchpoint_location)
3021         <ada_catchpoint_location>: Remove ops parameter.
3022         (ada_catchpoint_location_dtor): Remove.
3023         (ada_catchpoint_location_ops): Remove.
3024         (allocate_location_exception): Update.
3025         * breakpoint.h (struct bp_location_ops): Remove.
3026         (class bp_location) <bp_location>: Remove bp_location_ops
3027         parameter.
3028         <~bp_location>: Add destructor.
3029         <ops>: Remove.
3030
3031 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3032             Pedro Alves  <palves@redhat.com>
3033
3034         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3035         'PATH_MAX'.
3036
3037 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3038             Samuel Thibault  <samuel.thibault@gnu.org>
3039             Thomas Schwinge  <thomas@codesourcery.com>
3040
3041         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3042         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3043
3044 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3045
3046         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3047         (check_empty): Use "const char *".
3048
3049         * gnu-nat.c (gnu_nat_target::detach): Instead of
3050         'detach_inferior (pid)' call
3051         'detach_inferior (find_inferior_pid (pid))'.
3052
3053         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3054         'nat/fork-inferior.o'.
3055         * gnu-nat.c: #include "nat/fork-inferior.h".
3056
3057         * gnu-nat.c (gnu_nat_target::detach): Instead of
3058         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3059         * gnu-nat.h: #include "inf-child.h".
3060         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3061         'i386_gnu_nat_target::fetch_registers'.
3062         (gnu_store_registers): Rename/move to
3063         'i386_gnu_nat_target::store_registers'.
3064
3065         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3066         * gnu-nat.h (mach_thread_info): New function.
3067         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3068
3069         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3070
3071 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3072
3073         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3074
3075 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3076
3077         * windows-nat.c (windows_add_thread): Add new parameter
3078         "main_thread_p" with default value set to false.  Update
3079         function documentation as well as all callers.
3080         (windows_delete_thread): Likewise.
3081         (fake_create_process): Update call to windows_add_thread.
3082         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3083         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3084         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3085         call to windows_delete_thread.
3086
3087 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3088
3089         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3090
3091 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3092
3093         * symfile.c (find_separate_debug_file): Use canonical path of
3094         sysroot with child_path instead of gdb_sysroot if it is valid.
3095
3096 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3097
3098         * symfile.c (find_separate_debug_file): Use child_path to
3099         determine if an object file is under a sysroot.
3100
3101 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3102
3103         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3104         unittests/child-path-selftests.c.
3105         * common/pathstuff.c (child_path): New function.
3106         * common/pathstuff.h (child_path): New prototype.
3107         * unittests/child-path-selftests.c: New file.
3108
3109 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3110
3111         * symfile.c (find_separate_debug_file): Look for separate debug
3112         files in debug directories under the sysroot.
3113
3114 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3115
3116         * symtab.h (struct minimal_symbol data_p): New const method.
3117         (struct minimal_symbol text_p): Likewise.
3118         * symtab.c (output_source_filename): Use file name style
3119         to print file name.
3120         (print_symbol_info): Likewise.
3121         (print_msymbol_info): Use address style to print addresses.
3122         Use function name style to print executable text symbols.
3123         (expand_symtab_containing_pc): Use data_p.
3124         (find_pc_sect_compunit_symtab): Likewise.
3125
3126 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3127
3128         * breakpoint.c (describe_other_breakpoints): Use address style
3129         to print addresses.
3130         (say_where): Likewise.
3131
3132 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3133
3134         * ada-typeprint.c (print_func_type): Print function name
3135         style to print function name.
3136         * c-typeprint.c (c_print_type_1): Likewise.
3137
3138 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3139
3140         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3141         for execve.
3142
3143 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3144
3145         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3146         type_stack.
3147
3148 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3149
3150         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3151         TYPE_CODE_REF types.
3152
3153 2019-02-08  Jim Wilson  <jimw@sifive.com>
3154
3155         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3156         (riscv_linux_fregset): New.
3157         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3158
3159 2019-02-07  Tom Tromey  <tom@tromey.com>
3160
3161         * thread.c (thread_cancel_execution_command): Update.
3162         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3163         methods.
3164         (struct thread_fsm_ops): Remove.
3165         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3166         (thread_fsm_should_stop, thread_fsm_return_value)
3167         (thread_fsm_set_finished, thread_fsm_finished_p)
3168         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3169         Don't declare.
3170         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3171         * infrun.c (clear_proceed_status_thread)
3172         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3173         (print_stop_event): Update.
3174         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3175         Add constructor.
3176         (step_command_fsm_ops): Remove.
3177         (new_step_command_fsm): Remove.
3178         (step_1): Update.
3179         (step_command_fsm::should_stop): Rename from
3180         step_command_fsm_should_stop.
3181         (step_command_fsm::clean_up): Rename from
3182         step_command_fsm_clean_up.
3183         (step_command_fsm::do_async_reply_reason): Rename from
3184         step_command_fsm_async_reply_reason.
3185         (struct until_next_fsm): Inherit from thread_fsm.  Add
3186         constructor.
3187         (until_next_fsm_ops): Remove.
3188         (new_until_next_fsm): Remove.
3189         (until_next_fsm::should_stop): Rename from
3190         until_next_fsm_should_stop.
3191         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3192         (until_next_fsm::do_async_reply_reason): Rename from
3193         until_next_fsm_async_reply_reason.
3194         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3195         constructor.  Change type of breakpoint.
3196         (finish_command_fsm_ops): Remove.
3197         (new_finish_command_fsm): Remove.
3198         (finish_command_fsm::should_stop): Rename from
3199         finish_command_fsm_should_stop.
3200         (finish_command_fsm::clean_up): Rename from
3201         finish_command_fsm_clean_up.
3202         (finish_command_fsm::return_value): Rename from
3203         finish_command_fsm_return_value.
3204         (finish_command_fsm::do_async_reply_reason): Rename from
3205         finish_command_fsm_async_reply_reason.
3206         (finish_command): Update.
3207         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3208         Add constructor.
3209         (call_thread_fsm_ops): Remove.
3210         (call_thread_fsm::call_thread_fsm): Rename from
3211         new_call_thread_fsm.
3212         (call_thread_fsm::should_stop): Rename from
3213         call_thread_fsm_should_stop.
3214         (call_thread_fsm::should_notify_stop): Rename from
3215         call_thread_fsm_should_notify_stop.
3216         (run_inferior_call, call_function_by_hand_dummy): Update.
3217         * cli/cli-interp.c (should_print_stop_to_console): Update.
3218         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3219         Add constructor.  Change type of location_breakpoint,
3220         caller_breakpoint.
3221         (until_break_fsm_ops): Remove.
3222         (new_until_break_fsm): Remove.
3223         (until_break_fsm::should_stop): Rename from
3224         until_break_fsm_should_stop.
3225         (until_break_fsm::clean_up): Rename from
3226         until_break_fsm_clean_up.
3227         (until_break_fsm::do_async_reply_reason): Rename from
3228         until_break_fsm_async_reply_reason.
3229         (until_break_command): Update.
3230         * thread-fsm.c: Remove.
3231         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3232
3233 2019-02-07  Tom Tromey  <tom@tromey.com>
3234
3235         * yy-remap.h: Add include guard.
3236         * xtensa-tdep.h: Add include guard.
3237         * xcoffread.h: Rename include guard.
3238         * varobj-iter.h: Add include guard.
3239         * tui/tui.h: Rename include guard.
3240         * tui/tui-winsource.h: Rename include guard.
3241         * tui/tui-wingeneral.h: Rename include guard.
3242         * tui/tui-windata.h: Rename include guard.
3243         * tui/tui-win.h: Rename include guard.
3244         * tui/tui-stack.h: Rename include guard.
3245         * tui/tui-source.h: Rename include guard.
3246         * tui/tui-regs.h: Rename include guard.
3247         * tui/tui-out.h: Rename include guard.
3248         * tui/tui-layout.h: Rename include guard.
3249         * tui/tui-io.h: Rename include guard.
3250         * tui/tui-hooks.h: Rename include guard.
3251         * tui/tui-file.h: Rename include guard.
3252         * tui/tui-disasm.h: Rename include guard.
3253         * tui/tui-data.h: Rename include guard.
3254         * tui/tui-command.h: Rename include guard.
3255         * tic6x-tdep.h: Add include guard.
3256         * target/waitstatus.h: Rename include guard.
3257         * target/wait.h: Rename include guard.
3258         * target/target.h: Rename include guard.
3259         * target/resume.h: Rename include guard.
3260         * target-float.h: Rename include guard.
3261         * stabsread.h: Add include guard.
3262         * rs6000-tdep.h: Add include guard.
3263         * riscv-fbsd-tdep.h: Add include guard.
3264         * regformats/regdef.h: Rename include guard.
3265         * record.h: Rename include guard.
3266         * python/python.h: Rename include guard.
3267         * python/python-internal.h: Rename include guard.
3268         * python/py-stopevent.h: Rename include guard.
3269         * python/py-ref.h: Rename include guard.
3270         * python/py-record.h: Rename include guard.
3271         * python/py-record-full.h: Rename include guard.
3272         * python/py-record-btrace.h: Rename include guard.
3273         * python/py-instruction.h: Rename include guard.
3274         * python/py-events.h: Rename include guard.
3275         * python/py-event.h: Rename include guard.
3276         * procfs.h: Add include guard.
3277         * proc-utils.h: Add include guard.
3278         * p-lang.h: Add include guard.
3279         * or1k-tdep.h: Rename include guard.
3280         * observable.h: Rename include guard.
3281         * nto-tdep.h: Rename include guard.
3282         * nat/x86-linux.h: Rename include guard.
3283         * nat/x86-linux-dregs.h: Rename include guard.
3284         * nat/x86-gcc-cpuid.h: Add include guard.
3285         * nat/x86-dregs.h: Rename include guard.
3286         * nat/x86-cpuid.h: Rename include guard.
3287         * nat/ppc-linux.h: Rename include guard.
3288         * nat/mips-linux-watch.h: Rename include guard.
3289         * nat/linux-waitpid.h: Rename include guard.
3290         * nat/linux-ptrace.h: Rename include guard.
3291         * nat/linux-procfs.h: Rename include guard.
3292         * nat/linux-osdata.h: Rename include guard.
3293         * nat/linux-nat.h: Rename include guard.
3294         * nat/linux-namespaces.h: Rename include guard.
3295         * nat/linux-btrace.h: Rename include guard.
3296         * nat/glibc_thread_db.h: Rename include guard.
3297         * nat/gdb_thread_db.h: Rename include guard.
3298         * nat/gdb_ptrace.h: Rename include guard.
3299         * nat/fork-inferior.h: Rename include guard.
3300         * nat/amd64-linux-siginfo.h: Rename include guard.
3301         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3302         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3303         * nat/aarch64-linux.h: Rename include guard.
3304         * nat/aarch64-linux-hw-point.h: Rename include guard.
3305         * mn10300-tdep.h: Add include guard.
3306         * mips-linux-tdep.h: Add include guard.
3307         * mi/mi-parse.h: Rename include guard.
3308         * mi/mi-out.h: Rename include guard.
3309         * mi/mi-main.h: Rename include guard.
3310         * mi/mi-interp.h: Rename include guard.
3311         * mi/mi-getopt.h: Rename include guard.
3312         * mi/mi-console.h: Rename include guard.
3313         * mi/mi-common.h: Rename include guard.
3314         * mi/mi-cmds.h: Rename include guard.
3315         * mi/mi-cmd-break.h: Rename include guard.
3316         * m2-lang.h: Add include guard.
3317         * location.h: Rename include guard.
3318         * linux-record.h: Rename include guard.
3319         * linux-nat.h: Add include guard.
3320         * linux-fork.h: Add include guard.
3321         * i386-darwin-tdep.h: Rename include guard.
3322         * hppa-linux-offsets.h: Add include guard.
3323         * guile/guile.h: Rename include guard.
3324         * guile/guile-internal.h: Rename include guard.
3325         * gnu-nat.h: Rename include guard.
3326         * gdb-stabs.h: Rename include guard.
3327         * frv-tdep.h: Add include guard.
3328         * f-lang.h: Add include guard.
3329         * event-loop.h: Add include guard.
3330         * darwin-nat.h: Rename include guard.
3331         * cp-abi.h: Rename include guard.
3332         * config/sparc/nm-sol2.h: Rename include guard.
3333         * config/nm-nto.h: Rename include guard.
3334         * config/nm-linux.h: Add include guard.
3335         * config/i386/nm-i386gnu.h: Rename include guard.
3336         * config/djgpp/nl_types.h: Rename include guard.
3337         * config/djgpp/langinfo.h: Rename include guard.
3338         * compile/gcc-cp-plugin.h: Add include guard.
3339         * compile/gcc-c-plugin.h: Add include guard.
3340         * compile/compile.h: Rename include guard.
3341         * compile/compile-object-run.h: Rename include guard.
3342         * compile/compile-object-load.h: Rename include guard.
3343         * compile/compile-internal.h: Rename include guard.
3344         * compile/compile-cplus.h: Rename include guard.
3345         * compile/compile-c.h: Rename include guard.
3346         * common/xml-utils.h: Rename include guard.
3347         * common/x86-xstate.h: Rename include guard.
3348         * common/version.h: Rename include guard.
3349         * common/vec.h: Rename include guard.
3350         * common/tdesc.h: Rename include guard.
3351         * common/selftest.h: Rename include guard.
3352         * common/scoped_restore.h: Rename include guard.
3353         * common/scoped_mmap.h: Rename include guard.
3354         * common/scoped_fd.h: Rename include guard.
3355         * common/safe-iterator.h: Rename include guard.
3356         * common/run-time-clock.h: Rename include guard.
3357         * common/refcounted-object.h: Rename include guard.
3358         * common/queue.h: Rename include guard.
3359         * common/ptid.h: Rename include guard.
3360         * common/print-utils.h: Rename include guard.
3361         * common/preprocessor.h: Rename include guard.
3362         * common/pathstuff.h: Rename include guard.
3363         * common/observable.h: Rename include guard.
3364         * common/netstuff.h: Rename include guard.
3365         * common/job-control.h: Rename include guard.
3366         * common/host-defs.h: Rename include guard.
3367         * common/gdb_wait.h: Rename include guard.
3368         * common/gdb_vecs.h: Rename include guard.
3369         * common/gdb_unlinker.h: Rename include guard.
3370         * common/gdb_unique_ptr.h: Rename include guard.
3371         * common/gdb_tilde_expand.h: Rename include guard.
3372         * common/gdb_sys_time.h: Rename include guard.
3373         * common/gdb_string_view.h: Rename include guard.
3374         * common/gdb_splay_tree.h: Rename include guard.
3375         * common/gdb_setjmp.h: Rename include guard.
3376         * common/gdb_ref_ptr.h: Rename include guard.
3377         * common/gdb_optional.h: Rename include guard.
3378         * common/gdb_locale.h: Rename include guard.
3379         * common/gdb_assert.h: Rename include guard.
3380         * common/filtered-iterator.h: Rename include guard.
3381         * common/filestuff.h: Rename include guard.
3382         * common/fileio.h: Rename include guard.
3383         * common/environ.h: Rename include guard.
3384         * common/common-utils.h: Rename include guard.
3385         * common/common-types.h: Rename include guard.
3386         * common/common-regcache.h: Rename include guard.
3387         * common/common-inferior.h: Rename include guard.
3388         * common/common-gdbthread.h: Rename include guard.
3389         * common/common-exceptions.h: Rename include guard.
3390         * common/common-defs.h: Rename include guard.
3391         * common/common-debug.h: Rename include guard.
3392         * common/cleanups.h: Rename include guard.
3393         * common/buffer.h: Rename include guard.
3394         * common/btrace-common.h: Rename include guard.
3395         * common/break-common.h: Rename include guard.
3396         * cli/cli-utils.h: Rename include guard.
3397         * cli/cli-style.h: Rename include guard.
3398         * cli/cli-setshow.h: Rename include guard.
3399         * cli/cli-script.h: Rename include guard.
3400         * cli/cli-interp.h: Rename include guard.
3401         * cli/cli-decode.h: Rename include guard.
3402         * cli/cli-cmds.h: Rename include guard.
3403         * charset-list.h: Add include guard.
3404         * buildsym-legacy.h: Rename include guard.
3405         * bfin-tdep.h: Add include guard.
3406         * ax.h: Rename include guard.
3407         * arm-linux-tdep.h: Add include guard.
3408         * arm-fbsd-tdep.h: Add include guard.
3409         * arch/xtensa.h: Rename include guard.
3410         * arch/tic6x.h: Add include guard.
3411         * arch/i386.h: Add include guard.
3412         * arch/arm.h: Rename include guard.
3413         * arch/arm-linux.h: Rename include guard.
3414         * arch/arm-get-next-pcs.h: Rename include guard.
3415         * arch/amd64.h: Add include guard.
3416         * arch/aarch64-insn.h: Rename include guard.
3417         * arch-utils.h: Rename include guard.
3418         * annotate.h: Add include guard.
3419         * amd64-darwin-tdep.h: Rename include guard.
3420         * aarch64-linux-tdep.h: Add include guard.
3421         * aarch64-fbsd-tdep.h: Add include guard.
3422         * aarch32-linux-nat.h: Add include guard.
3423
3424 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3425
3426         * macrotab.c (macro_define_internal): New function that
3427         factorizes macro_define_object_internal and macro_define_function
3428         code.
3429         (macro_define_object_internal): Use macro_define_internal.
3430         (macro_define_function): Likewise.
3431
3432 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3433
3434         * macrocmd.c (extract_identifier): Return
3435         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3436         callers.
3437
3438 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3439
3440         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3441
3442 2019-02-05  Tom Tromey  <tom@tromey.com>
3443
3444         * target.c (target_stack::unpush): Move assertion earlier.
3445
3446 2019-01-30  Tom Tromey  <tom@tromey.com>
3447
3448         PR python/23615:
3449         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3450         (gdbpy_parse_and_eval): Likewise.
3451         * python/python-internal.h (gdbpy_allow_threads): New class.
3452
3453 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3454
3455         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3456         (aarch64_fbsd_fpregmap): Move earlier.
3457         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3458         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3459         instead of individual calls to trad_frame_set_reg_addr.
3460         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3461         earlier.
3462         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3463         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3464         instead of individual calls to trad_frame_set_reg_addr.
3465
3466 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3467
3468         * CONTRIBUTE: Replace contribution list with wiki link.
3469
3470 2019-01-25  Tom Tromey  <tom@tromey.com>
3471
3472         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3473
3474 2019-01-25  Tom Tromey  <tom@tromey.com>
3475
3476         * xtensa-linux-nat.c: Fix common/ includes.
3477         * xml-support.h: Fix common/ includes.
3478         * xml-support.c: Fix common/ includes.
3479         * x86-linux-nat.c: Fix common/ includes.
3480         * windows-nat.c: Fix common/ includes.
3481         * varobj.h: Fix common/ includes.
3482         * varobj.c: Fix common/ includes.
3483         * value.c: Fix common/ includes.
3484         * valops.c: Fix common/ includes.
3485         * utils.c: Fix common/ includes.
3486         * unittests/xml-utils-selftests.c: Fix common/ includes.
3487         * unittests/utils-selftests.c: Fix common/ includes.
3488         * unittests/unpack-selftests.c: Fix common/ includes.
3489         * unittests/tracepoint-selftests.c: Fix common/ includes.
3490         * unittests/style-selftests.c: Fix common/ includes.
3491         * unittests/string_view-selftests.c: Fix common/ includes.
3492         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3493         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3494         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3495         * unittests/rsp-low-selftests.c: Fix common/ includes.
3496         * unittests/parse-connection-spec-selftests.c: Fix common/
3497         includes.
3498         * unittests/optional-selftests.c: Fix common/ includes.
3499         * unittests/offset-type-selftests.c: Fix common/ includes.
3500         * unittests/observable-selftests.c: Fix common/ includes.
3501         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3502         * unittests/memrange-selftests.c: Fix common/ includes.
3503         * unittests/memory-map-selftests.c: Fix common/ includes.
3504         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3505         * unittests/function-view-selftests.c: Fix common/ includes.
3506         * unittests/environ-selftests.c: Fix common/ includes.
3507         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3508         * unittests/common-utils-selftests.c: Fix common/ includes.
3509         * unittests/cli-utils-selftests.c: Fix common/ includes.
3510         * unittests/array-view-selftests.c: Fix common/ includes.
3511         * ui-file.c: Fix common/ includes.
3512         * tui/tui-io.c: Fix common/ includes.
3513         * tracepoint.h: Fix common/ includes.
3514         * tracepoint.c: Fix common/ includes.
3515         * tracefile-tfile.c: Fix common/ includes.
3516         * top.h: Fix common/ includes.
3517         * top.c: Fix common/ includes.
3518         * thread.c: Fix common/ includes.
3519         * target/waitstatus.h: Fix common/ includes.
3520         * target/waitstatus.c: Fix common/ includes.
3521         * target.h: Fix common/ includes.
3522         * target.c: Fix common/ includes.
3523         * target-memory.c: Fix common/ includes.
3524         * target-descriptions.c: Fix common/ includes.
3525         * symtab.h: Fix common/ includes.
3526         * symfile.c: Fix common/ includes.
3527         * stap-probe.c: Fix common/ includes.
3528         * spu-linux-nat.c: Fix common/ includes.
3529         * sparc-nat.c: Fix common/ includes.
3530         * source.c: Fix common/ includes.
3531         * solib.c: Fix common/ includes.
3532         * solib-target.c: Fix common/ includes.
3533         * ser-unix.c: Fix common/ includes.
3534         * ser-tcp.c: Fix common/ includes.
3535         * ser-pipe.c: Fix common/ includes.
3536         * ser-base.c: Fix common/ includes.
3537         * selftest-arch.c: Fix common/ includes.
3538         * s12z-tdep.c: Fix common/ includes.
3539         * rust-exp.y: Fix common/ includes.
3540         * rs6000-aix-tdep.c: Fix common/ includes.
3541         * riscv-tdep.c: Fix common/ includes.
3542         * remote.c: Fix common/ includes.
3543         * remote-notif.h: Fix common/ includes.
3544         * remote-fileio.h: Fix common/ includes.
3545         * remote-fileio.c: Fix common/ includes.
3546         * regcache.h: Fix common/ includes.
3547         * regcache.c: Fix common/ includes.
3548         * record-btrace.c: Fix common/ includes.
3549         * python/python.c: Fix common/ includes.
3550         * python/py-type.c: Fix common/ includes.
3551         * python/py-inferior.c: Fix common/ includes.
3552         * progspace.h: Fix common/ includes.
3553         * producer.c: Fix common/ includes.
3554         * procfs.c: Fix common/ includes.
3555         * proc-api.c: Fix common/ includes.
3556         * printcmd.c: Fix common/ includes.
3557         * ppc-linux-nat.c: Fix common/ includes.
3558         * parser-defs.h: Fix common/ includes.
3559         * osdata.c: Fix common/ includes.
3560         * obsd-nat.c: Fix common/ includes.
3561         * nat/x86-linux.c: Fix common/ includes.
3562         * nat/x86-linux-dregs.c: Fix common/ includes.
3563         * nat/x86-dregs.h: Fix common/ includes.
3564         * nat/x86-dregs.c: Fix common/ includes.
3565         * nat/ppc-linux.c: Fix common/ includes.
3566         * nat/mips-linux-watch.h: Fix common/ includes.
3567         * nat/mips-linux-watch.c: Fix common/ includes.
3568         * nat/linux-waitpid.c: Fix common/ includes.
3569         * nat/linux-ptrace.h: Fix common/ includes.
3570         * nat/linux-ptrace.c: Fix common/ includes.
3571         * nat/linux-procfs.c: Fix common/ includes.
3572         * nat/linux-personality.c: Fix common/ includes.
3573         * nat/linux-osdata.c: Fix common/ includes.
3574         * nat/linux-namespaces.c: Fix common/ includes.
3575         * nat/linux-btrace.h: Fix common/ includes.
3576         * nat/linux-btrace.c: Fix common/ includes.
3577         * nat/fork-inferior.c: Fix common/ includes.
3578         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3579         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3580         * nat/aarch64-linux.c: Fix common/ includes.
3581         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3582         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3583         * namespace.h: Fix common/ includes.
3584         * mips-linux-tdep.c: Fix common/ includes.
3585         * minsyms.c: Fix common/ includes.
3586         * mi/mi-parse.h: Fix common/ includes.
3587         * mi/mi-main.c: Fix common/ includes.
3588         * mi/mi-cmd-env.c: Fix common/ includes.
3589         * memrange.h: Fix common/ includes.
3590         * memattr.c: Fix common/ includes.
3591         * maint.h: Fix common/ includes.
3592         * maint.c: Fix common/ includes.
3593         * main.c: Fix common/ includes.
3594         * machoread.c: Fix common/ includes.
3595         * location.c: Fix common/ includes.
3596         * linux-thread-db.c: Fix common/ includes.
3597         * linux-nat.c: Fix common/ includes.
3598         * linux-fork.c: Fix common/ includes.
3599         * inline-frame.c: Fix common/ includes.
3600         * infrun.c: Fix common/ includes.
3601         * inflow.c: Fix common/ includes.
3602         * inferior.h: Fix common/ includes.
3603         * inferior.c: Fix common/ includes.
3604         * infcmd.c: Fix common/ includes.
3605         * inf-ptrace.c: Fix common/ includes.
3606         * inf-child.c: Fix common/ includes.
3607         * ia64-linux-nat.c: Fix common/ includes.
3608         * i387-tdep.c: Fix common/ includes.
3609         * i386-tdep.c: Fix common/ includes.
3610         * i386-linux-tdep.c: Fix common/ includes.
3611         * i386-linux-nat.c: Fix common/ includes.
3612         * i386-go32-tdep.c: Fix common/ includes.
3613         * i386-fbsd-tdep.c: Fix common/ includes.
3614         * i386-fbsd-nat.c: Fix common/ includes.
3615         * guile/scm-type.c: Fix common/ includes.
3616         * guile/guile.c: Fix common/ includes.
3617         * go32-nat.c: Fix common/ includes.
3618         * gnu-nat.c: Fix common/ includes.
3619         * gdbthread.h: Fix common/ includes.
3620         * gdbarch-selftests.c: Fix common/ includes.
3621         * gdb_usleep.c: Fix common/ includes.
3622         * gdb_select.h: Fix common/ includes.
3623         * gdb_bfd.c: Fix common/ includes.
3624         * gcore.c: Fix common/ includes.
3625         * fork-child.c: Fix common/ includes.
3626         * findvar.c: Fix common/ includes.
3627         * fbsd-nat.c: Fix common/ includes.
3628         * event-top.c: Fix common/ includes.
3629         * event-loop.c: Fix common/ includes.
3630         * dwarf2read.c: Fix common/ includes.
3631         * dwarf2loc.c: Fix common/ includes.
3632         * dwarf2-frame.c: Fix common/ includes.
3633         * dwarf-index-cache.c: Fix common/ includes.
3634         * dtrace-probe.c: Fix common/ includes.
3635         * disasm-selftests.c: Fix common/ includes.
3636         * defs.h: Fix common/ includes.
3637         * csky-tdep.c: Fix common/ includes.
3638         * cp-valprint.c: Fix common/ includes.
3639         * cp-support.h: Fix common/ includes.
3640         * cp-support.c: Fix common/ includes.
3641         * corelow.c: Fix common/ includes.
3642         * completer.h: Fix common/ includes.
3643         * completer.c: Fix common/ includes.
3644         * compile/compile.c: Fix common/ includes.
3645         * compile/compile-loc2c.c: Fix common/ includes.
3646         * compile/compile-cplus-types.c: Fix common/ includes.
3647         * compile/compile-cplus-symbols.c: Fix common/ includes.
3648         * command.h: Fix common/ includes.
3649         * cli/cli-dump.c: Fix common/ includes.
3650         * cli/cli-cmds.c: Fix common/ includes.
3651         * charset.c: Fix common/ includes.
3652         * build-id.c: Fix common/ includes.
3653         * btrace.h: Fix common/ includes.
3654         * btrace.c: Fix common/ includes.
3655         * breakpoint.h: Fix common/ includes.
3656         * breakpoint.c: Fix common/ includes.
3657         * ax.h:
3658         (enum agent_op): Fix common/ includes.
3659         * ax-general.c (struct aop_map): Fix common/ includes.
3660         * ax-gdb.c: Fix common/ includes.
3661         * auxv.c: Fix common/ includes.
3662         * auto-load.c: Fix common/ includes.
3663         * arm-tdep.c: Fix common/ includes.
3664         * arch/riscv.c: Fix common/ includes.
3665         * arch/ppc-linux-common.c: Fix common/ includes.
3666         * arch/i386.c: Fix common/ includes.
3667         * arch/arm.c: Fix common/ includes.
3668         * arch/arm-linux.c: Fix common/ includes.
3669         * arch/arm-get-next-pcs.c: Fix common/ includes.
3670         * arch/amd64.c: Fix common/ includes.
3671         * arch/aarch64.c: Fix common/ includes.
3672         * arch/aarch64-insn.c: Fix common/ includes.
3673         * arch-utils.c: Fix common/ includes.
3674         * amd64-windows-tdep.c: Fix common/ includes.
3675         * amd64-tdep.c: Fix common/ includes.
3676         * amd64-sol2-tdep.c: Fix common/ includes.
3677         * amd64-obsd-tdep.c: Fix common/ includes.
3678         * amd64-nbsd-tdep.c: Fix common/ includes.
3679         * amd64-linux-tdep.c: Fix common/ includes.
3680         * amd64-linux-nat.c: Fix common/ includes.
3681         * amd64-fbsd-tdep.c: Fix common/ includes.
3682         * amd64-fbsd-nat.c: Fix common/ includes.
3683         * amd64-dicos-tdep.c: Fix common/ includes.
3684         * amd64-darwin-tdep.c: Fix common/ includes.
3685         * agent.c: Fix common/ includes.
3686         * ada-lang.h: Fix common/ includes.
3687         * ada-lang.c: Fix common/ includes.
3688         * aarch64-tdep.c: Fix common/ includes.
3689
3690 2019-01-25  Tom Tromey  <tom@tromey.com>
3691
3692         * common/create-version.sh: Use common/version.h.
3693
3694 2019-01-24  Pedro Alves  <palves@redhat.com>
3695
3696         * infrun.c (signal_stop, signal_print, signal_program)
3697         (signal_catch, signal_pass): Now arrays instead of pointers.
3698         (update_signals_program_target, do_target_resume)
3699         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3700         * linux-nat.c (linux_nat_target::pass_signals)
3701         (linux_nat_target::create_inferior, linux_nat_target::attach):
3702         Adjust.
3703         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3704         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3705         * procfs.c (procfs_target::pass_signals): Adjust.
3706         * record-full.c (record_full_target::resume): Adjust.
3707         * remote.c (remote_target::pass_signals)
3708         (remote_target::program_signals): Adjust.
3709         * target-debug.h (target_debug_print_signals): Now takes a
3710         gdb::array_view as parameter.  Adjust.
3711         * target.h (target_ops) <pass_signals, program_signals>: Replace
3712         pointer and length parameters with gdb::array_view.
3713         (target_pass_signals, target_program_signals): Likewise.
3714         * target-delegates.c: Regenerate.
3715
3716 2019-01-24  Pedro Alves  <palves@redhat.com>
3717
3718         * common/forward-scope-exit.h
3719         (forward_scope_exit::forward_scope_exit): Pass arguments to
3720         m_bind_function directly, instead of creating a std::bind and
3721         copying that.
3722
3723 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3724
3725         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3726         for static members.
3727         (pass_in_v_vfp_candidate): Likewise.
3728
3729 2019-01-23  Tom Tromey  <tom@tromey.com>
3730             Pedro Alves  <palves@redhat.com>
3731
3732         * regcache.c (class regcache_invalidator): Remove.
3733         (regcache::raw_write): Use make_scope_exit.
3734
3735 2019-01-23  Tom Tromey  <tom@tromey.com>
3736
3737         * ui-out.h (class ui_out_emit_type): Update comment.
3738
3739 2019-01-23  Tom Tromey  <tom@tromey.com>
3740
3741         * infrun.c (fetch_inferior_event): Update comment.
3742
3743 2019-01-23  Tom Tromey  <tom@tromey.com>
3744             Pedro Alves  <palves@redhat.com>
3745
3746         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3747         parameter.
3748         (fetch_inferior_event): Use SCOPE_EXIT.
3749
3750
3751 2019-01-23  Tom Tromey  <tom@tromey.com>
3752             Pedro Alves  <palves@redhat.com>
3753
3754         * infrun.c (disable_thread_events): Delete.
3755         (stop_all_threads): Use SCOPE_EXIT.
3756
3757 2019-01-23  Tom Tromey  <tom@tromey.com>
3758             Pedro Alves  <palves@redhat.com>
3759
3760         * symfile.c: Include forward-scope-exit.h.
3761         (clear_symtab_users_cleanup): Replace forward declaration with
3762         a FORWARD_SCOPE_EXIT.
3763         (syms_from_objfile_1): Use the forward_scope_exit and
3764         gdb::optional instead of cleanup_function.
3765         (reread_symbols): Use the forward_scope_exit instead of
3766         cleanup_function.
3767         (clear_symtab_users_cleanup): Remove function.
3768
3769 2019-01-23  Tom Tromey  <tom@tromey.com>
3770             Pedro Alves  <palves@redhat.com>
3771
3772         * linux-nat.c: Include scope-exit.h.
3773         (cleanup_target_stop): Remove.
3774         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3775         SCOPE_EXIT.
3776
3777 2019-01-23  Tom Tromey  <tom@tromey.com>
3778             Pedro Alves  <palves@redhat.com>
3779
3780         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3781         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3782
3783 2019-01-23  Tom Tromey  <tom@tromey.com>
3784             Andrew Burgess  <andrew.burgess@embecosm.com>
3785             Pedro Alves  <palves@redhat.com>
3786
3787         * infrun.c (fetch_inferior_event): Use scope_exit.
3788         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3789         * top.c (execute_command): Use scope_exit.
3790         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3791         * utils.c (do_bpstat_clear_actions_cleanup)
3792         (make_bpstat_clear_actions_cleanup): Remove.
3793
3794 2019-01-23  Tom Tromey  <tom@tromey.com>
3795             Pedro Alves  <palves@redhat.com>
3796
3797         * infrun.c: Include "common/scope-exit.h"
3798         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3799         (wait_for_inferior): Use SCOPE_EXIT.
3800         (fetch_inferior_event): Use scope_exit.
3801
3802 2019-01-23  Tom Tromey  <tom@tromey.com>
3803             Pedro Alves  <palves@redhat.com>
3804
3805         * breakpoint.c (create_breakpoint): Remove cleanup.
3806
3807 2019-01-23  Tom Tromey  <tom@tromey.com>
3808             Andrew Burgess  <andrew.burgess@embecosm.com>
3809             Pedro Alves  <palves@redhat.com>
3810
3811 2019-01-23  Pedro Alves  <palves@redhat.com>
3812
3813         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3814
3815 2019-01-23  Pedro Alves  <palves@redhat.com>
3816             Andrew Burgess  <andrew.burgess@embecosm.com>
3817
3818         * gdbthread.h: Include "common/forward-scope-exit.h".
3819         (scoped_finish_thread_state): Redefine custom class in terms of
3820         forward_scope_exit.
3821
3822 2019-01-23  Pedro Alves  <palves@redhat.com>
3823             Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * common/forward-scope-exit.h: New file.
3826
3827 2019-01-23  Pedro Alves  <palves@redhat.com>
3828             Andrew Burgess  <andrew.burgess@embecosm.com>
3829             Tom Tromey  <tom@tromey.com>
3830
3831         * common/scope-exit.h: New file.
3832
3833 2019-01-23  Pedro Alves  <palves@redhat.com>
3834
3835         * common/preprocessor.h (ESC): Rename to ...
3836         (ESC_PARENS): ... this.
3837         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3838         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3839
3840 2019-01-23  Tom Tromey  <tom@tromey.com>
3841
3842         * language.h (class scoped_switch_to_sym_language_if_auto):
3843         Initialize m_lang in both cases.
3844
3845 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3846
3847         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3848         with XCNEW.
3849
3850 2019-01-22  Tom Tromey  <tom@tromey.com>
3851
3852         * corelow.c: Do not include sys/file.h.
3853
3854 2019-01-22  Tom Tromey  <tom@tromey.com>
3855
3856         * tui/tui-wingeneral.h: Include gdb_curses.h.
3857
3858 2019-01-22  Tom Tromey  <tom@tromey.com>
3859
3860         * source-cache.h (class source_cache) <get_source_lines,
3861         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3862
3863 2019-01-22  Tom Tromey  <tom@tromey.com>
3864
3865         * remote-fileio.h (struct remote_target): Declare.
3866
3867 2019-01-22  Tom Tromey  <tom@tromey.com>
3868
3869         * python/py-arch.c: Do not include py-ref.h.
3870         * python/py-bpevent.c: Do not include py-ref.h.
3871         * python/py-cmd.c: Do not include py-ref.h.
3872         * python/py-continueevent.c: Do not include py-ref.h.
3873         * python/py-event.h: Do not include py-ref.h.
3874         * python/py-evtregistry.c: Do not include py-ref.h.
3875         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3876         * python/py-frame.c: Do not include py-ref.h.
3877         * python/py-framefilter.c: Do not include py-ref.h.
3878         * python/py-function.c: Do not include py-ref.h.
3879         * python/py-infevents.c: Do not include py-ref.h.
3880         * python/py-linetable.c: Do not include py-ref.h.
3881         * python/py-objfile.c: Do not include py-ref.h.
3882         * python/py-param.c: Do not include py-ref.h.
3883         * python/py-prettyprint.c: Do not include py-ref.h.
3884         * python/py-progspace.c: Do not include py-ref.h.
3885         * python/py-symbol.c: Do not include py-ref.h.
3886         * python/py-symtab.c: Do not include py-ref.h.
3887         * python/py-type.c: Do not include py-ref.h.
3888         * python/py-unwind.c: Do not include py-ref.h.
3889         * python/py-utils.c: Do not include py-ref.h.
3890         * python/py-value.c: Do not include py-ref.h.
3891         * python/py-varobj.c: Do not include py-ref.h.
3892         * python/py-xmethods.c: Do not include py-ref.h.
3893         * python/python.c: Do not include py-ref.h.
3894         * varobj.c: Do not include py-ref.h.
3895
3896 2019-01-22  Tom Tromey  <tom@tromey.com>
3897
3898         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3899         keyword for bcache.
3900
3901 2019-01-22  Tom Tromey  <tom@tromey.com>
3902
3903         * compile/compile-cplus-types.c: Remove a comment by #include.
3904
3905 2019-01-22  Tom Tromey  <tom@tromey.com>
3906
3907         * compile/gcc-c-plugin.h: Include compile-internal.h.
3908
3909 2019-01-22  Tom Tromey  <tom@tromey.com>
3910
3911         * stabsread.c (EXTERN): Do not define.
3912         (symnum, next_symbol_text_func, processing_gcc_compilation)
3913         (within_function, global_sym_chain, global_stabs)
3914         (previous_stab_code, this_object_header_files)
3915         (n_this_object_header_files)
3916         (n_allocated_this_object_header_files): Define.
3917         * stabsread.h (EXTERN): Never define.  Use "extern".
3918
3919 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3920
3921         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3922         history_value.
3923
3924 2019-01-21  Tom Tromey  <tom@tromey.com>
3925
3926         * ui-out.c: Fix includes.
3927         * tui/tui-source.c: Fix includes.
3928         * target.c: Fix includes.
3929         * remote.c: Fix includes.
3930         * regcache.c: Fix includes.
3931         * python/py-block.c: Fix includes.
3932         * printcmd.c: Fix includes.
3933         * or1k-tdep.c: Fix includes.
3934         * mi/mi-main.c: Fix includes.
3935         * m32r-tdep.c: Fix includes.
3936         * csky-tdep.c: Fix includes.
3937         * compile/compile-cplus-types.c: Fix includes.
3938         * cli/cli-interp.c: Fix includes.
3939
3940 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3941
3942         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3943         for padding.
3944
3945 2019-01-16  Tom Tromey  <tom@tromey.com>
3946
3947         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3948         earlier.
3949         (struct objfile) <msymbols_range>: Move from top level.
3950         <msymbols>: New method.
3951         (class objfile_msymbols): Remove.
3952         * symtab.c (default_collect_symbol_completion_matches_break_on):
3953         Update.
3954         * symmisc.c (dump_msymbols): Update.
3955         * stabsread.c (scan_file_globals): Update.
3956         * objc-lang.c (info_selectors_command, info_classes_command)
3957         (find_methods): Update.
3958         * minsyms.c (find_solib_trampoline_target): Update.
3959         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3960         * coffread.c (coff_symfile_read): Update.
3961         * ada-lang.c (ada_lookup_simple_minsym)
3962         (ada_collect_symbol_completion_matches): Update.
3963
3964 2019-01-16  Tom Tromey  <tom@tromey.com>
3965
3966         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3967         type.  Remove no-argument constructor.
3968         <iterator::operator++>: Simplify.
3969         <begin>: Update.
3970         <end>: Use minimal_symbol_count.
3971
3972 2019-01-16  Tom Tromey  <tom@tromey.com>
3973
3974         * objfiles.h (struct objfile) <psymtabs>: New method.
3975         (class objfile_psymtabs): Remove.
3976         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3977         typedef.
3978         <range>: New method.
3979         (require_partial_symbols): Change return type.
3980         * psymtab.c (require_partial_symbols)
3981         (psym_expand_symtabs_matching): Update.
3982         * mdebugread.c (parse_partial_symbols): Update.
3983         * dbxread.c (dbx_end_psymtab): Update.
3984
3985 2019-01-15  Tom Tromey  <tom@tromey.com>
3986
3987         * symtab.c (lookup_objfile_from_block)
3988         (lookup_symbol_in_objfile_symtabs)
3989         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3990         (find_line_symtab, info_sources_command)
3991         (default_collect_symbol_completion_matches_break_on)
3992         (make_source_files_completion_list): Update.
3993         * symmisc.c (print_objfile_statistics, dump_objfile)
3994         (maintenance_print_symbols, maintenance_info_symtabs)
3995         (maintenance_check_symtabs, maintenance_info_line_tables):
3996         Update.
3997         * source.c (select_source_symtab)
3998         (forget_cached_source_info_for_objfile): Update.
3999         * objfiles.h (class objfile_compunits): Remove.
4000         (struct objfile) <compunits_range>: New typedef.
4001         (compunits): New method.
4002         * objfiles.c (objfile_relocate1): Update.
4003         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4004         * maint.c (count_symtabs_and_blocks): Update.
4005         * linespec.c (iterate_over_all_matching_symtabs): Update.
4006         * cp-support.c (add_symbol_overload_list_qualified): Update.
4007         * coffread.c (coff_symtab_read): Update.
4008         * ada-lang.c (add_nonlocal_symbols)
4009         (ada_collect_symbol_completion_matches)
4010         (ada_add_global_exceptions): Update.
4011
4012 2019-01-15  Tom Tromey  <tom@tromey.com>
4013
4014         * progspace.h (program_space) <objfiles_safe_range>: New
4015         typedef.
4016         <objfiles_safe>: New method.
4017         * objfiles.h (class all_objfiles_safe): Remove.
4018         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4019         * jit.c (jit_inferior_exit_hook): Update.
4020
4021 2019-01-17  Tom Tromey  <tom@tromey.com>
4022
4023         * progspace.h (program_space) <objfiles_range>: New typedef.
4024         <objfiles>: New method.
4025         <objfiles_head>: Rename from objfiles.
4026         (object_files): Update.
4027         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4028         * guile/scm-pretty-print.c
4029         (ppscm_find_pretty_printer_from_objfiles): Update.
4030         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4031         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4032         Update.
4033         * python/py-progspace.c (pspy_get_objfiles): Update.
4034         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4035         Update.
4036         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4037         (objfpy_lookup_objfile_by_build_id): Update.
4038         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4039         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4040         Update.
4041         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4042         (expand_symtab_containing_pc, lookup_objfile_from_block)
4043         (lookup_static_symbol, basic_lookup_transparent_type)
4044         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4045         (find_line_symtab, info_sources_command)
4046         (default_collect_symbol_completion_matches_break_on)
4047         (make_source_files_completion_list, find_main_name): Update.
4048         * symmisc.c (print_symbol_bcache_statistics)
4049         (print_objfile_statistics, maintenance_print_symbols)
4050         (maintenance_print_msymbols, maintenance_print_objfiles)
4051         (maintenance_info_symtabs, maintenance_check_symtabs)
4052         (maintenance_expand_symtabs, maintenance_info_line_tables):
4053         Update.
4054         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4055         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4056         (map_overlay_command, unmap_overlay_command)
4057         (simple_overlay_update, expand_symtabs_matching)
4058         (map_symbol_filenames): Update.
4059         * symfile-debug.c (set_debug_symfile): Update.
4060         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4061         Update.
4062         * source.c (select_source_symtab, forget_cached_source_info):
4063         Update.
4064         * solib.c (solib_read_symbols): Update.
4065         * solib-spu.c (append_ocl_sos): Update.
4066         * psymtab.c (maintenance_print_psymbols)
4067         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4068         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4069         * printcmd.c (info_symbol_command): Update.
4070         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4071         Update.
4072         * objfiles.h (class all_objfiles): Remove.
4073         * objfiles.c (have_partial_symbols, have_full_symbols)
4074         (have_minimal_symbols, qsort_cmp, update_section_map)
4075         (shared_objfile_contains_address_p)
4076         (default_iterate_over_objfiles_in_search_order): Update.
4077         * objc-lang.c (info_selectors_command, info_classes_command)
4078         (find_methods): Update.
4079         * minsyms.c (find_solib_trampoline_target): Update.
4080         * maint.c (maintenance_info_sections)
4081         (maintenance_translate_address, count_symtabs_and_blocks):
4082         Update.
4083         * main.c (captured_main_1): Update.
4084         * linux-thread-db.c (try_thread_db_load_from_pdir)
4085         (has_libpthread): Update.
4086         * linespec.c (iterate_over_all_matching_symtabs)
4087         (search_minsyms_for_name): Update.
4088         * jit.c (jit_find_objf_with_entry_addr): Update.
4089         * hppa-tdep.c (find_unwind_entry)
4090         (hppa_lookup_stub_minimal_symbol): Update.
4091         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4092         Update.
4093         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4094         (elf_gnu_ifunc_resolve_by_got): Update.
4095         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4096         * dwarf-index-write.c (save_gdb_index_command): Update.
4097         * cp-support.c (add_symbol_overload_list_qualified): Update.
4098         * breakpoint.c (create_overlay_event_breakpoint)
4099         (create_longjmp_master_breakpoint)
4100         (create_std_terminate_master_breakpoint)
4101         (create_exception_master_breakpoint): Update.
4102         * blockframe.c (find_pc_partial_function): Update.
4103         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4104         (ada_collect_symbol_completion_matches)
4105         (ada_add_global_exceptions): Update.
4106
4107 2019-01-17  Tom Tromey  <tom@tromey.com>
4108
4109         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4110         declare VEC.
4111         (solib_target_parse_libraries): Change return type.
4112         (library_list_start_segment, library_list_start_section)
4113         (library_list_end_library, library_list_start_library); Update.
4114         (solib_target_free_library_list): Remove.
4115         (solib_target_parse_libraries): Remove cleanup.  Change return
4116         type.
4117         (solib_target_current_sos): Update.
4118
4119 2019-01-17  Tom Tromey  <tromey@bapiya>
4120
4121         * valprint.c: Replace "the the" with "the".
4122         * symtab.c: Replace "the the" with "the".
4123         * solib.c: Replace "the the" with "the".
4124         * solib-dsbt.c: Replace "the the" with "the".
4125         * linespec.c: Replace "the the" with "the".
4126         * dwarf2loc.h: Replace "the the" with "the".
4127         * amd64-windows-tdep.c: Replace "the the" with "the".
4128         * aarch64-tdep.c: Replace "the the" with "the".
4129
4130 2019-01-16  Keith Seitz  <keiths@redhat.com>
4131
4132         PR gdb/23773
4133         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4134         <builder>: Rename to ..
4135         <m_builder>: ... this and make private.
4136         (dwarf2_cu::get_builder): New method.  Change all users of
4137         `builder' to use this method.
4138         (dwarf2_start_symtab): Move to ...
4139         (dwarf2_cu::start_symtab): ... here.  Update all callers
4140         (setup_type_unit_groups): Move to ...
4141         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4142         callers.
4143         (dwarf2_cu::reset_builder): New method.
4144         (process_full_compunit, process_full_type_unit): Use
4145         dwarf2_cu::reset_builder.
4146         (follow_die_offset): Record the ancestor CU if it is different
4147         from the followed DIE's CU.
4148         (follow_die_sig_1): Likewise.
4149
4150 2019-01-15  Tom Tromey  <tom@tromey.com>
4151
4152         * remote.c (class remote_state) <buf>: Now a char_vector.
4153         <buf_size>: Remove.
4154         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4155         parameter.
4156         (remote_target::getpkt_or_notif_sane_1)
4157         (remote_target::getpkt_sane)
4158         (remote_target::getpkt_or_notif_sane): Likewise.
4159         (class remote_target) <putpkt>: New overload.
4160         (remote_target::read_frame): Change type of "buf_p".  Remove
4161         sizeof_p parameter.
4162         (packet_ok): New overload.
4163         (packet_check_result): New overload.
4164         Update all uses.
4165
4166 2019-01-14  Tom Tromey  <tom@tromey.com>
4167
4168         * remote-notif.c (handle_notification, remote_notif_ack)
4169         (remote_notif_parse): Make "buf" const.
4170         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4171         const.
4172         (remote_notif_parse, remote_notif_ack, handle_notification):
4173         Likewise.
4174         * remote.c (remote_notif_stop_parse): Make "buf" const.
4175         (remote_target::remote_parse_stop_reply): Make "buf" const.
4176         (remote_notif_stop_ack): Make "buf" const.
4177
4178 2019-01-14  Tom Tromey  <tom@tromey.com>
4179
4180         * remote.c (remote_console_output): Make parameter const.
4181
4182 2019-01-14  Tom Tromey  <tom@tromey.com>
4183
4184         * target-debug.h (target_debug_print_signals): Constify.
4185         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4186         * procfs.c (procfs_target::pass_signals): Update.
4187         * linux-nat.c (linux_nat_target::pass_signals): Update.
4188         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4189         * target-delegates.c: Rebuild.
4190         * remote.c (remote_target::program_signals): Update.
4191         (remote_target::pass_signals): Update.
4192         * target.c (target_pass_signals): Constify argument.
4193         (target_program_signals): Likewise.
4194         * target.h (struct target_ops) <pass_signals, program_signals>:
4195         Constify argument.
4196         (target_pass_signals, target_program_signals): Constify argument.
4197
4198 2019-01-14  Tom Tromey  <tom@tromey.com>
4199
4200         PR tui/28819:
4201         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4202
4203 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4204
4205         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4206         field.
4207         * rs6000-tdep.c: Include reggroups.h.
4208         (IS_V_ALIAS_PSEUDOREG): Define.
4209         (rs6000_register_name): Return names for the "vX" aliases.
4210         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4211         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4212         aliases.  Call default_register_reggroup_p for all other
4213         pseudo-registers.
4214         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4215         New functions.
4216         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4217         Handle "vX" aliases.
4218         (v_alias_pseudo_register_collect): New function.
4219         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4220         (rs6000_gdbarch_init): Initialize "vX" aliases as
4221         pseudo-registers.  Restore registration of
4222         rs6000_pseudo_register_reggroup_p with
4223         set_tdesc_pseudo_register_reggroup_p.
4224
4225 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4226
4227         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4228         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4229         set_gdbarch_num_pseudo_regs.
4230
4231 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4232
4233         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4234         Remove arg prefixname, add do_set and do_show.
4235         Add member functions set_list and show_list.
4236         * cli/cli-style.c (class cli_style_option): Update accordingly.
4237         (style_set_list): Move to file scope.
4238         (style_show_list): Likewise.
4239         (set_style): Call help_list.
4240         (show_style): Call cmd_show_list.
4241         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4242         Update to use the new macro.
4243
4244 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4245
4246         * ada-lang.c (_initialize_ada_language): Expand the help text
4247         for the "catch exception" command.
4248
4249 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4250
4251         * symtab.c (matching_obj_sections): Initialize obj,
4252         declare it closer to its usage.
4253
4254 2019-01-10  Tom Tromey  <tom@tromey.com>
4255
4256         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4257         (basic_inf_threads_range): Remove.
4258         (inf_threads_range, inf_non_exited_threads_range)
4259         (safe_inf_threads_range): Use next_adapter.
4260
4261 2019-01-10  Keith Seitz  <keiths@redhat.com>
4262
4263         PR gdb/23712
4264         PR symtab/23010
4265         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4266         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4267
4268 2019-01-10  Keith Seitz  <keiths@redhat.com>
4269
4270         PR gdb/23712
4271         PR symtab/23010
4272         * dictionary.c (pending_to_vector): Remove.
4273         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4274         Remove _1 suffix, replacing functions of the same name.  Update
4275         all callers.
4276         (dict_create_hashed, dict_create_hashed_expandable)
4277         (dict_create_linear, dict_create_linear_expandable, dict_free)
4278         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4279         Make functions static.
4280
4281 2019-01-10  Keith Seitz  <keiths@redhat.com>
4282
4283         PR gdb/23712
4284         PR symtab/23010
4285         * dictionary.h (struct dictionary): Replace declaration with
4286         multidictionary.
4287         (dict_create_hashed, dict_create_hashed_expandable)
4288         (dict_create_linear, dict_create_linear_expandable)
4289         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4290         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4291         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4292         taking multidictionary argument.
4293         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4294         * block.h (struct block) <dict>: Change to multidictionary
4295         and rename `multidict'.
4296         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4297         symmisc.c: Update all dictionary references to multidictionary.
4298
4299 2019-01-10  Keith Seitz  <keiths@redhat.com>
4300
4301         PR gdb/23712
4302         PR symtab/23010
4303         * dictionary.c: Include unordered_map.
4304         (pending_to_vector): New function.
4305         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4306         Rewrite the non-"_1" functions to take vector instead
4307         of linked list.
4308         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4309         "new" _1 versions of the same name.
4310         (multidictionary): Define.
4311         (std::hash<enum language): New definition.
4312         (collate_pending_symbols_by_language, mdict_create_hashed)
4313         (mdict_create_hashed_expandable, mdict_create_linear)
4314         (mdict_create_linear_expandable, mdict_free)
4315         (find_language_dictionary, create_new_language_dictionary)
4316         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4317         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4318         (mdict_size, mdict_empty): New functions.
4319         * dictionary.h (mdict_iterator): Define.
4320
4321 2019-01-10  Pedro Alves  <palves@redhat.com>
4322
4323         * breakpoint.c (read_uploaded_action)
4324         (create_tracepoint_from_upload): Adjust to use
4325         gdb::unique_xmalloc_ptr.
4326         * ctf.c (ctf_write_uploaded_tp):
4327         (SET_ARRAY_FIELD): Use emplace_back.
4328         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4329         * tracefile-tfile.c (tfile_write_uploaded_tp):
4330         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4331         gdb::unique_xmalloc_ptr.
4332         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4333         at_string, cond_string, cmd_strings>: Replace char pointers
4334         with gdb::unique_xmalloc_ptr.
4335
4336 2019-01-10  Pedro Alves  <palves@redhat.com>
4337
4338         * solib-target.c (library_list_start_library): Don't xstrdup name.
4339
4340 2019-01-10  Pedro Alves  <palves@redhat.com>
4341
4342         * mdebugread.c (parse_partial_symbols): Use
4343         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4344
4345 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4346
4347         * linux-fork.c (scoped_switch_fork_info)
4348         <~scoped_switch_fork_info>: Fix incorrect variable name.
4349
4350 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4351
4352         * linux-fork.c (scoped_switch_fork_info)
4353         <scoped_switch_fork_info>: Make explicit.
4354         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4355
4356 2019-01-10  Tom Tromey  <tom@tromey.com>
4357
4358         * objfiles.h (objfile::reset_psymtabs): Update.
4359         * objfiles.c (objfile::objfile): Update.
4360         * psymtab.h (psymtab_storage::obstack): Update.
4361         (psymtab_storage::m_obstack): Use gdb::optional.
4362         (class psymtab_storage): Update comment.  Remove objfile
4363         parameter.
4364         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4365
4366 2019-01-10  Tom Tromey  <tom@tromey.com>
4367
4368         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4369         <free_psymtabs>: Now private.
4370         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4371         (allocate_psymtab): Use new method.
4372
4373 2019-01-10  Tom Tromey  <tom@tromey.com>
4374
4375         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4376         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4377         * mdebugread.c (parse_partial_symbols): Use
4378         allocate_dependencies.
4379         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4380         allocate_dependencies.
4381         (process_psymtab_comp_unit_reader)
4382         (build_type_psymtab_dependencies): Likewise.
4383         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4384
4385 2019-01-10  Tom Tromey  <tom@tromey.com>
4386
4387         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4388         PSYMBOL_SET_LANGUAGE.
4389         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4390
4391 2019-01-10  Tom Tromey  <tom@tromey.com>
4392
4393         * psymtab.h (psymtab_storage::obstack): New method.
4394         <m_obstack>: Rename from obstack; now private.
4395         * psymtab.c (psymtab_storage): Update.
4396         * dwarf2read.c (create_addrmap_from_index)
4397         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4398         Update.
4399
4400 2019-01-10  Tom Tromey  <tom@tromey.com>
4401
4402         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4403         * objfiles.h (objfile::reset_psymtabs): New method.
4404
4405 2019-01-10  Tom Tromey  <tom@tromey.com>
4406
4407         * symmisc.c (print_symbol_bcache_statistics): Update.
4408         (print_objfile_statistics): Update.
4409         * symfile.c (reread_symbols): Update.
4410         * psymtab.h (class psymtab_storage): New.
4411         * psymtab.c (psymtab_storage): New constructor.
4412         (~psymtab_storage): New destructor.
4413         (require_partial_symbols): Update.
4414         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4415         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4416         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4417         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4418         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4419         (start_psymtab_common, end_psymtab_common)
4420         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4421         (allocate_psymtab): Update.
4422         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4423         Update.
4424         (dump_psymtab_addrmap, maintenance_print_psymbols)
4425         (maintenance_check_psymtabs): Update.
4426         (class objfile_psymtabs): Move to objfiles.h.
4427         * psympriv.h (discard_psymtab): Now inline.
4428         (psymtab_discarder::psymtab_discarder): Update.
4429         (psymtab_discarder::~psymtab_discarder): Update.
4430         (ALL_OBJFILE_PSYMTABS): Rewrite.
4431         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4432         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4433         Remove fields.
4434         <partial_symtabs>: New field.
4435         (class objfile_psymtabs): Move from psymtab.h.  Update.
4436         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4437         psymbol_cache.
4438         (objfile::~objfile): Don't destroy psymbol_cache.
4439         * mdebugread.c (parse_partial_symbols): Update.
4440         * dwarf2read.c (create_addrmap_from_index)
4441         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4442         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4443         (add_partial_subprogram, dwarf2_ranges_read): Update.
4444         * dwarf-index-write.c (write_address_map)
4445         (write_one_signatured_type, recursively_write_psymbols)
4446         (class debug_names, class debug_names, write_psymtabs_to_index):
4447         Update.
4448
4449 2019-01-10  Tom Tromey  <tom@tromey.com>
4450
4451         * symtab.h (SYMBOL_SET_NAMES): Update.
4452         (symbol_set_names): Update.
4453         (MSYMBOL_SET_NAMES): Update.
4454         * symtab.c (symbol_set_names): Change argument to be an
4455         objfile_per_bfd_storage.
4456         * psymtab.c (add_psymbol_to_bcache): Update.
4457         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4458
4459 2019-01-10  Tom Tromey  <tom@tromey.com>
4460
4461         * symtab.c (create_demangled_names_hash): Change argument to be an
4462         objfile_per_bfd_storage.
4463         (symbol_set_names): Update.
4464
4465 2019-01-10  Tom Tromey  <tom@tromey.com>
4466
4467         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4468         init_psymbol_list.
4469         * psymtab.c (init_psymbol_list): Do nothing if already called.
4470         * psympriv.h (init_psymbol_list): Add comment.
4471         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4472         init_psymbol_list.
4473         * dbxread.c (dbx_symfile_read): Unconditionally call
4474         init_psymbol_list.
4475
4476 2019-01-10  Tom Tromey  <tom@tromey.com>
4477
4478         * xcoffread.c (scan_xcoff_symtab): Update.
4479         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4480         "where".
4481         * mdebugread.c (parse_partial_symbols)
4482         (handle_psymbol_enumerators): Update.
4483         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4484         * dbxread.c (read_dbx_symtab): Update.
4485         * psympriv.h (psymbol_placement): New enum.
4486         (add_psymbol_to_list): Update.
4487
4488 2019-01-10  Tom Tromey  <tom@tromey.com>
4489
4490         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4491         static_psymbols parameters.
4492         (scan_xcoff_symtab): Update.
4493         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4494         static_psymbols parameters.
4495         * psympriv.h (start_psymtab_common): Update.
4496         * mdebugread.c (parse_partial_symbols): Update.
4497         * dwarf2read.c (create_partial_symtab): Update.
4498         * dbxread.c (read_dbx_symtab): Update.
4499         (start_psymtab): Remove global_psymbols and static_psymbols
4500         parameters.
4501
4502 2019-01-10  Tom Tromey  <tom@tromey.com>
4503
4504         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4505         * psymtab.c (allocate_psymtab): Add comment.
4506         * psympriv.h (allocate_psymtab): Add comment.
4507         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4508         initializations.
4509         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4510
4511 2019-01-10  Tom Tromey  <tom@tromey.com>
4512
4513         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4514         Don't declare.
4515         * mipsread.c: Include mdebugread.h.
4516         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4517         Declare.
4518         * elfread.c: Include mdebugread.h.
4519
4520 2019-01-09  Tom Tromey  <tom@tromey.com>
4521
4522         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4523         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4524         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4525         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4526         (psym_lookup_symbol, psym_find_last_source_symtab)
4527         (psym_forget_cached_source_info, psym_print_stats)
4528         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4529         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4530         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4531         (psym_find_compunit_symtab_by_address)
4532         (maintenance_print_psymbols, maintenance_info_psymtabs)
4533         (maintenance_check_psymtabs): Use ranged for.
4534         * psymtab.h (class objfile_psymtabs): New.
4535         (require_partial_symbols): Return objfile_psymtabs.
4536         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4537
4538 2019-01-09  Tom Tromey  <tom@tromey.com>
4539
4540         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4541         (find_pc_mapped_section, list_overlays_command)
4542         (map_overlay_command, unmap_overlay_command)
4543         (simple_overlay_update): Use all_objfiles.
4544         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4545         * printcmd.c (info_symbol_command): Use all_objfiles.
4546         * objfiles.h (ALL_OBJSECTIONS): Remove.
4547         * maint.c (maintenance_translate_address): Use all_objfiles.
4548         * gcore.c (gcore_create_callback): Use all_objfiles.
4549         (objfile_find_memory_regions): Likewise.
4550
4551 2019-01-09  Tom Tromey  <tom@tromey.com>
4552
4553         * symtab.c (find_line_symtab, info_sources_command)
4554         (make_source_files_completion_list): Use objfile_compunits.
4555         * source.c (select_source_symtab): Use objfile_compunits.
4556         * objfiles.h (struct objfile): Update comment.
4557         (ALL_OBJFILES): Remove.
4558         (ALL_FILETABS): Remove.
4559         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4560         objfile_compunits.
4561
4562 2019-01-09  Tom Tromey  <tom@tromey.com>
4563
4564         * symmisc.c (print_objfile_statistics, dump_objfile)
4565         (maintenance_print_symbols): Use compunit_filetabs.
4566         * source.c (forget_cached_source_info_for_objfile): Use
4567         compunit_filetabs.
4568         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4569         (ALL_FILETABS): Use compunit_filetabs.
4570         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4571         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4572
4573 2019-01-09  Tom Tromey  <tom@tromey.com>
4574
4575         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4576         (compunit_filetabs): New.
4577         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4578         compunit_filetabs.
4579         (info_sources_command, make_source_files_completion_list): Remove
4580         declaration.
4581         * symmisc.c (print_objfile_statistics, dump_objfile)
4582         (maintenance_print_symbols): Remove declaration.
4583         (maintenance_info_symtabs): Use compunit_filetabs.
4584         (maintenance_info_line_tables): Likewise.
4585         * source.c (select_source_symtab): Change local variable name.
4586         (forget_cached_source_info_for_objfile): Remove declaration.
4587         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4588         * objfiles.c (objfile_relocate1): Remove declaration.
4589         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4590         declaration.
4591         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4592         * coffread.c (coff_symtab_read): Remove declaration.
4593         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4594         compunit_filetabs.
4595
4596 2019-01-09  Tom Tromey  <tom@tromey.com>
4597
4598         * symtab.c (lookup_objfile_from_block)
4599         (find_pc_sect_compunit_symtab, search_symbols)
4600         (default_collect_symbol_completion_matches_break_on): Use
4601         objfile_compunits.
4602         * objfiles.h (ALL_COMPUNITS): Remove.
4603         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4604         * cp-support.c (add_symbol_overload_list_qualified): Use
4605         objfile_compunits.
4606         * ada-lang.c (ada_collect_symbol_completion_matches)
4607         (ada_add_global_exceptions): Use objfile_compunits.
4608
4609 2019-01-09  Tom Tromey  <tom@tromey.com>
4610
4611         * source.c (select_source_symtab)
4612         (forget_cached_source_info_for_objfile): Remove declaration.
4613         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4614         declaration.
4615         * maint.c (count_symtabs_and_blocks): Remove declaration.
4616         * cp-support.c (add_symbol_overload_list_qualified): Remove
4617         declaration.
4618         * coffread.c (coff_symtab_read): Remove declaration.
4619         * symtab.c (lookup_symbol_in_objfile_symtabs)
4620         (basic_lookup_transparent_type_1): Use objfile_compunits.
4621         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4622         (info_sources_command, search_symbols)
4623         (default_collect_symbol_completion_matches_break_on)
4624         (make_source_files_completion_list): Remove declaration.
4625         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4626         (ada_collect_symbol_completion_matches)
4627         (ada_add_global_exceptions): Remove declaration.
4628         * linespec.c (iterate_over_all_matching_symtabs): Use
4629         objfile_compunits.
4630         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4631         (class objfile_compunits): New.
4632         (ALL_COMPUNITS): Use objfile_compunits.
4633         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4634         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4635         objfile_compunits.
4636         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4637
4638 2019-01-09  Tom Tromey  <tom@tromey.com>
4639
4640         * symtab.c (search_symbols)
4641         (default_collect_symbol_completion_matches_break_on): Use
4642         objfile_msymbols.
4643         * ada-lang.c (ada_lookup_simple_minsym)
4644         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4645         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4646         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4647         objfile_msymbols.
4648         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4649         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4650         * objc-lang.c (find_methods): Use objfile_msymbols.
4651         (info_selectors_command, info_classes_command): Likewise.
4652         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4653         * objfiles.h (class objfile_msymbols): New.
4654         (ALL_OBJFILE_MSYMBOLS): Remove.
4655         (ALL_MSYMBOLS): Remove.
4656
4657 2019-01-09  Tom Tromey  <tom@tromey.com>
4658
4659         * common/next-iterator.h (next_adapter): Add Iterator template
4660         parameter.
4661         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4662         (class all_objfiles_safe): New.
4663         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4664         * objfiles.c (put_objfile_before): Update comment.
4665         (add_separate_debug_objfile): Likewise.
4666         (free_all_objfiles): Use all_objfiles_safe.
4667         (objfile_purge_solibs): Likewise.
4668
4669 2019-01-09  Tom Tromey  <tom@tromey.com>
4670
4671         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4672         (expand_symtab_containing_pc, lookup_static_symbol)
4673         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4674         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4675         all_objfiles.
4676         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4677         * breakpoint.c (create_overlay_event_breakpoint)
4678         (create_longjmp_master_breakpoint)
4679         (create_std_terminate_master_breakpoint)
4680         (create_exception_master_breakpoint): Use all_objfiles.
4681         * linux-thread-db.c (try_thread_db_load_from_pdir)
4682         (has_libpthread): Use all_objfiles.
4683         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4684         * linespec.c (iterate_over_all_matching_symtabs)
4685         (search_minsyms_for_name): Use all_objfiles.
4686         * maint.c (maintenance_info_sections): Use all_objfiles.
4687         * main.c (captured_main_1): Use all_objfiles.
4688         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4689         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4690         * guile/scm-pretty-print.c
4691         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4692         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4693         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4694         (maintenance_print_msymbols): Use all_objfiles.
4695         * source.c (select_source_symtab): Use all_objfiles.
4696         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4697         * symfile.c (remove_symbol_file_command)
4698         (expand_symtabs_matching, map_symbol_filenames): Use
4699         all_objfiles.
4700         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4701         all_objfiles.
4702         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4703         * objc-lang.c (find_methods): Use all_objfiles.
4704         * objfiles.c (have_partial_symbols, have_full_symbols)
4705         (have_minimal_symbols, qsort_cmp)
4706         (default_iterate_over_objfiles_in_search_order): Use
4707         all_objfiles.
4708         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4709         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4710         (maintenance_check_psymtabs): Use all_objfiles.
4711         (ALL_PSYMTABS): Remove.
4712         * compile/compile-object-run.c (do_module_cleanup): Use
4713         all_objfiles.
4714         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4715         * cp-support.c (add_symbol_overload_list_qualified): Use
4716         all_objfiles.
4717         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4718         Use all_objfiles.
4719         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4720         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4721         all_objfiles.
4722         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4723         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4724         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4725         Uses all_objfiles.
4726         * solib.c (solib_read_symbols): Use all_objfiles
4727
4728 2019-01-09  Tom Tromey  <tom@tromey.com>
4729
4730         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4731         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4732         all_objfiles.
4733         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4734         * symmisc.c (print_symbol_bcache_statistics)
4735         (print_objfile_statistics, maintenance_print_objfiles)
4736         (maintenance_info_symtabs, maintenance_check_symtabs)
4737         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4738         all_objfiles.
4739         * source.c (forget_cached_source_info): Use all_objfiles.
4740         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4741         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4742         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4743         * objfiles.c (update_section_map): Use all_objfiles.
4744         (shared_objfile_contains_address_p): Likewise.
4745         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4746         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4747
4748 2019-01-09  Tom Tromey  <tom@tromey.com>
4749
4750         * common/next-iterator.h: New file.
4751         * objfiles.h (class all_objfiles): New.
4752         (struct objfile_iterator): New.
4753
4754 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4755
4756         * NEWS: Move the description of the changed "frame", "select-frame",
4757          and "info frame" commands to the Changed commands section.
4758
4759 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4760
4761         * gdbtypes.c (check_stub_method_group): Remove handling of old
4762         mangling schemes.
4763         * linespec.c (find_methods): Likewise.
4764         * stabsread.c (read_member_functions): Likewise.
4765         * valops.c (search_struct_method): Likewise.
4766         (value_struct_elt_for_reference): Likewise.
4767         * NEWS: Mention this change.
4768
4769 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4770
4771         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4772         print_source_lines.
4773         * source.c (print_source_lines_base): Update line number check.
4774         (print_source_lines): New function.
4775         (source_lines_range::source_lines_range): New function.
4776         * source.h (class source_lines_range): New class.
4777         (print_source_lines): New declaration.
4778
4779 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4780
4781         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4782
4783 2019-01-08  Tom Tromey  <tom@tromey.com>
4784             Simon Marchi  <simon.marchi@ericsson.com>
4785
4786         PR gdb/24060
4787         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4788         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4789         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4790         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4791         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4792         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4793
4794 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4795
4796         * source.c (select_source_symtab): Move header comment to
4797         declaration in source.h.
4798         (forget_cached_source_info_for_objfile): Likewise.
4799         (forget_cached_source_info): Likewise.
4800         (identify_source_line): Likewise.
4801         * source.h (identify_source_line): Move declaration from symtab.h
4802         and add comment from source.c
4803         (print_source_lines): Likewise.
4804         (forget_cached_source_info_for_objfile): Likewise.
4805         (forget_cached_source_info): Likewise.
4806         (select_source_symtab): Likewise.
4807         (enum print_source_lines_flag): Move definition from symtab.h.
4808         * symtab.h (identify_source_line): Move declaration to source.h.
4809         (print_source_lines): Likewise.
4810         (forget_cached_source_info_for_objfile): Likewise.
4811         (forget_cached_source_info): Likewise.
4812         (select_source_symtab): Likewise.
4813         (enum print_source_lines_flag): Move definition to source.h.
4814         * tui/tui-hooks.c: Add 'source.h' include.
4815
4816 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4817
4818         * source.c (print_source_lines_base): Handle requests to print
4819         reverse line number sequences, and guard against empty lines
4820         string.
4821
4822 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         * source.c (print_source_lines_base): Fix skip of '\r' if next
4825         character is '\n'.
4826
4827 2019-01-06  Tom Tromey  <tom@tromey.com>
4828
4829         * c-exp.y (struct c_parse_state) <macro_original_text,
4830         expansion_obstack>: New member.
4831         (macro_original_text, expansion_obstack): Remove globals.
4832         (scan_macro_expansion, scanning_macro_expansion)
4833         (finished_macro_expansion): Update.
4834         (scan_macro_cleanup): Remove.
4835         (yylex, c_parse): Update.
4836
4837 2019-01-06  Tom Tromey  <tom@tromey.com>
4838
4839         * c-exp.y (struct c_parse_state) <strings>: New member.
4840         (operator_stoken): Update.
4841
4842 2019-01-06  Tom Tromey  <tom@tromey.com>
4843
4844         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4845         (union type_stack_elt) <typelist_val>: Now a pointer to
4846         std::vector.
4847         (type_stack_cleanup): Don't declare.
4848         (push_typelist): Update.
4849         * parse.c (pop_typelist): Return a std::vector.
4850         (push_typelist): Take a std::vector.
4851         (follow_types): Update.  Do not free args.
4852         (type_stack_cleanup): Remove.
4853         * c-exp.y (struct c_parse_state): New.
4854         (cpstate): New global.
4855         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4856         (nonempty_typelist): Update.
4857         (func_mod): Create a new vector.
4858         (c_parse): Create a c_parse_state.
4859         (check_parameter_typelist): Do not delete params.
4860         (function_method): Update.  Do not delete type_list.
4861
4862 2019-01-06  Tom Tromey  <tom@tromey.com>
4863
4864         PR gdb/28155:
4865         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4866         check_typedef.
4867         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4868         (print_return_value): Likewise.
4869
4870 2019-01-05  Tom Tromey  <tom@tromey.com>
4871
4872         * contrib/cleanup_check.py: Remove.
4873         * contrib/gcc-with-excheck: Remove.
4874         * contrib/exsummary.py: Remove.
4875         * contrib/excheck.py: Remove.
4876
4877 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4878
4879         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4880         NULL. Initialize tpprev to NULL instead of assigning it
4881         to NULL on the next statement.
4882         * windows-nat.c (windows_delete_thread): Remove check for
4883         main_thread_id before printing thread exit notifications.
4884         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4885         Remove thread ID check against main_thread_id.
4886         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4887         windows_delete_thread.
4888         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4889
4890 2019-01-04  Tom Tromey  <tom@tromey.com>
4891
4892         * compile/compile.c (_initialize_compile): Use upper case for
4893         metasyntactic variables.
4894         * symmisc.c (_initialize_symmisc): Use upper case for
4895         metasyntactic variables.
4896         * psymtab.c (_initialize_psymtab): Use upper case for
4897         metasyntactic variables.
4898         * demangle.c (demangle_command): Use upper case for metasyntactic
4899         variables.
4900         (_initialize_demangler): Likewise.
4901         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4902         variables.
4903
4904 2019-01-03  Tom Tromey  <tom@tromey.com>
4905
4906         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4907
4908 2019-01-03  Tom Tromey  <tom@tromey.com>
4909
4910         * python/py-symtab.c (salpy_str): Update.
4911         (struct salpy_sal_object) <symtab>: Now a PyObject.
4912         (salpy_dealloc): Update.
4913         (del_objfile_sal): Use gdbpy_ref.
4914
4915 2019-01-03  Tom Tromey  <tom@tromey.com>
4916
4917         * python/py-type.c (convert_field): Use new_reference.  Return
4918         gdbpy_ref.
4919         (make_fielditem): Return gdbpy_ref.
4920         (typy_fields): Update.
4921         (typy_getitem): Update.
4922         (field_name): Return gdbpy_ref.  Use new_reference.
4923         (typy_iterator_iternext): Update.
4924
4925 2019-01-03  Tom Tromey  <tom@tromey.com>
4926
4927         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4928
4929 2019-01-03  Tom Tromey  <tom@tromey.com>
4930
4931         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4932         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4933         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4934         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4935         (pspy_set_type_printers): Likewise.
4936         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4937         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4938         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4939         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4940         (objfpy_set_type_printers): Likewise.
4941
4942 2019-01-03  Tom Tromey  <tom@tromey.com>
4943
4944         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4945         (gdbpy_print_stack): Use gdbpy_err_fetch.
4946         * python/python-internal.h (class gdbpy_err_fetch): New class.
4947         (class gdbpy_enter) <m_error_type, m_error_value,
4948         m_error_traceback>: Remove.
4949         <m_error>: New member.
4950         (gdbpy_exception_to_string): Don't declare.
4951         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4952         * python/py-value.c (convert_value_from_python): Use
4953         gdbpy_err_fetch.
4954         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4955         gdbpy_exception_to_string.
4956         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4957         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4958         gdbpy_err_fetch.
4959
4960 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * linux-nat.c (delete_lwp_cleanup): Delete.
4963         (struct lwp_deleter): New struct.
4964         (lwp_info_up): New typedef.
4965         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4966         lwp_info_up.
4967
4968 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * linux-fork.c (class scoped_switch_fork_info): New class.
4971         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4972
4973 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * valops.c (find_overload_match): Remove use of null_cleanup, and
4976         calls to do_cleanups.
4977
4978 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4979
4980         * compile/compile-cplus-types.c
4981         (compile_cplus_instance::decl_name): Handle changes to
4982         cp_func_name.
4983         * cp-support.c (cp_func_name): Update header comment, update
4984         return type.
4985         * cp-support.h (cp_func_name): Update return type in declaration.
4986         * valops.c (find_overload_match): Move temp_func local to top
4987         level of function and change its type.  Use temp_func to hold and
4988         delete temporary string obtained from cp_func_name.
4989
4990 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4991
4992         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4993         gdb::char_vector, remove cleanup, and update uses of `msg`.
4994
4995 2019-01-03  Jim Wilson  <jimw@sifive.com>
4996
4997         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4998
4999 2019-01-02  Tom Tromey  <tom@tromey.com>
5000
5001         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5002         (tdesc_parse_xml): Remove cleanups.
5003         * target-descriptions.h (make_cleanup_free_target_description):
5004         Don't declare.
5005         (target_desc_deleter): New struct.
5006         (target_desc_up): New typedef.
5007         * target-descriptions.c (target_desc_deleter::operator()): Rename
5008         from free_target_description.
5009         (make_cleanup_free_target_description): Remove.
5010
5011 2019-01-02  Tom Tromey  <tom@tromey.com>
5012
5013         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5014         constructor, destructor.
5015         (linespec_parser): Remove typedef.
5016         (~linespec_parser): Rename from linespec_parser_delete.
5017         (linespec_lex_to_end, linespec_complete_label)
5018         (linespec_complete): Update.
5019         (decode_line_full): Remove cleanups.
5020         (decode_line_1): Update.
5021
5022 2019-01-02  Tom Tromey  <tom@tromey.com>
5023
5024         * python/python-internal.h (inferior_to_inferior_object): Change
5025         return type.
5026         * python/py-exitedevent.c (create_exited_event_object): Update.
5027         * python/py-inferior.c (inferior_to_inferior_object): Return
5028         gdbpy_ref.
5029         (python_new_inferior, python_inferior_deleted)
5030         (thread_to_thread_object, delete_thread_object)
5031         (build_inferior_list, gdbpy_selected_inferior): Update.
5032         * python/py-infthread.c (create_thread_object): Update.  Also fail
5033         if inferior_to_inferior_object fails.
5034
5035 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5036
5037         * inferior.h (class inferior) <displaced_step_state>: New field.
5038         * infrun.h (struct displaced_step_state): Move here from
5039         infrun.c.  Initialize fields, add constructor.
5040         <inf>: Remove field.
5041         <reset>: New method.
5042         * infrun.c (struct displaced_step_inferior_state): Move to
5043         infrun.h.
5044         (displaced_step_inferior_states): Remove.
5045         (get_displaced_stepping_state): Adust.
5046         (displaced_step_in_progress_any_inferior): Adjust.
5047         (displaced_step_in_progress_thread): Adjust.
5048         (displaced_step_in_progress): Adjust.
5049         (add_displaced_stepping_state): Remove.
5050         (get_displaced_step_closure_by_addr): Adjust.
5051         (remove_displaced_stepping_state): Remove.
5052         (infrun_inferior_exit): Call displaced_step_state.reset.
5053         (use_displaced_stepping): Don't check for NULL.
5054         (displaced_step_prepare_throw): Call
5055         get_displaced_stepping_state.
5056         (displaced_step_fixup): Don't check for NULL.
5057         (prepare_for_detach): Don't check for NULL.
5058
5059 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5060
5061         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5062          in case of call that did not complete.
5063
5064 2019-01-02  Andrey Utkin  <autkin@undo.io>
5065
5066         * symfile.c (find_separate_debug_file): Fix search of debug files for
5067         remote debuggee.
5068
5069 2019-01-02  Tom Tromey  <tom@tromey.com>
5070
5071         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5072         indentation.
5073         * python/py-frame.c (frapy_older): Remove cast.
5074         (frapy_newer): Likewise.
5075         * python/py-breakpoint.c (local_setattro): Remove cast.
5076         * python/py-arch.c (archpy_name): Remove local variable.
5077         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5078
5079 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5080
5081         * unittests/basic_string_view/element_access/char/empty.cc:
5082         Fix year range in copyright header.
5083
5084 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5087         Delete.
5088         <operator==>: Update with for removed field.
5089         <hash>: Likewise.
5090         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5091         <isa_features>: ...this.
5092         <abi_features>: New field.
5093         (riscv_isa_flen): Update comment.
5094         (riscv_abi_xlen): New declaration.
5095         (riscv_abi_flen): New declaration.
5096         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5097         isa_features.
5098         (riscv_abi_xlen): New function.
5099         (riscv_isa_flen): Update to get answer from isa_features.
5100         (riscv_abi_flen): New function.
5101         (riscv_has_fp_abi): Update to get answer from abi_features.
5102         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5103         xlen and flen.
5104         (riscv_call_info) <xlen, flen>: Update comment.
5105         (riscv_call_arg_struct): Remove invalid assertions
5106         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5107         is removed.
5108         (riscv_gdbarch_init): Gather isa features and abi features
5109         separately, ensure both match on the gdbarch when reusing an old
5110         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5111         a target with 64-bit float hardware.
5112
5113 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5114
5115         * source.c (search_command_helper): Stop reverse search
5116         when line 1 has been searched.
5117
5118 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5119
5120         * record-full.c (record_full_base_target::close): Rewrite
5121         record_full_core_buf_list free logic.
5122
5123 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5124
5125         * break-catch-syscall.c (print_one_catch_syscall): xfree
5126         the last text.
5127
5128 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5129
5130         * top.c (print_gdb_version): Update Copyright year in version
5131         message.
5132
5133 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5134
5135         Update copyright year range in all GDB files.
5136
5137 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5138
5139         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5140
5141 For older changes see ChangeLog-2018.
5142 \f
5143 Local Variables:
5144 mode: change-log
5145 left-margin: 8
5146 fill-column: 74
5147 version-control: never
5148 coding: utf-8
5149 End:
5150