gdb/ChangeLog

   1 2019-04-08  Tom Tromey  <tom@tromey.com>
   2
   3         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
   4         Remove.
   5         (gdb_exception_error): Rename from
   6         gdb_exception_RETURN_MASK_ERROR.
   7         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
   8         (gdb_quit_bad_alloc): Update.
   9         * aarch64-tdep.c: Update.
  10         * ada-lang.c: Update.
  11         * ada-typeprint.c: Update.
  12         * ada-valprint.c: Update.
  13         * amd64-tdep.c: Update.
  14         * arch-utils.c: Update.
  15         * break-catch-throw.c: Update.
  16         * breakpoint.c: Update.
  17         * btrace.c: Update.
  18         * c-varobj.c: Update.
  19         * cli/cli-cmds.c: Update.
  20         * cli/cli-interp.c: Update.
  21         * cli/cli-script.c: Update.
  22         * common/common-exceptions.c: Update.
  23         * common/new-op.c: Update.
  24         * common/selftest.c: Update.
  25         * compile/compile-c-symbols.c: Update.
  26         * compile/compile-cplus-symbols.c: Update.
  27         * compile/compile-object-load.c: Update.
  28         * compile/compile-object-run.c: Update.
  29         * completer.c: Update.
  30         * corelow.c: Update.
  31         * cp-abi.c: Update.
  32         * cp-support.c: Update.
  33         * cp-valprint.c: Update.
  34         * darwin-nat.c: Update.
  35         * disasm-selftests.c: Update.
  36         * dtrace-probe.c: Update.
  37         * dwarf-index-cache.c: Update.
  38         * dwarf-index-write.c: Update.
  39         * dwarf2-frame-tailcall.c: Update.
  40         * dwarf2-frame.c: Update.
  41         * dwarf2loc.c: Update.
  42         * dwarf2read.c: Update.
  43         * eval.c: Update.
  44         * event-loop.c: Update.
  45         * event-top.c: Update.
  46         * exec.c: Update.
  47         * f-valprint.c: Update.
  48         * fbsd-tdep.c: Update.
  49         * frame-unwind.c: Update.
  50         * frame.c: Update.
  51         * gdbtypes.c: Update.
  52         * gnu-v3-abi.c: Update.
  53         * guile/guile-internal.h: Update.
  54         * guile/scm-block.c: Update.
  55         * guile/scm-breakpoint.c: Update.
  56         * guile/scm-cmd.c: Update.
  57         * guile/scm-disasm.c: Update.
  58         * guile/scm-frame.c: Update.
  59         * guile/scm-lazy-string.c: Update.
  60         * guile/scm-math.c: Update.
  61         * guile/scm-param.c: Update.
  62         * guile/scm-ports.c: Update.
  63         * guile/scm-pretty-print.c: Update.
  64         * guile/scm-symbol.c: Update.
  65         * guile/scm-symtab.c: Update.
  66         * guile/scm-type.c: Update.
  67         * guile/scm-value.c: Update.
  68         * i386-linux-tdep.c: Update.
  69         * i386-tdep.c: Update.
  70         * inf-loop.c: Update.
  71         * infcall.c: Update.
  72         * infcmd.c: Update.
  73         * infrun.c: Update.
  74         * jit.c: Update.
  75         * language.c: Update.
  76         * linespec.c: Update.
  77         * linux-fork.c: Update.
  78         * linux-nat.c: Update.
  79         * linux-tdep.c: Update.
  80         * linux-thread-db.c: Update.
  81         * main.c: Update.
  82         * mi/mi-cmd-break.c: Update.
  83         * mi/mi-cmd-stack.c: Update.
  84         * mi/mi-interp.c: Update.
  85         * mi/mi-main.c: Update.
  86         * objc-lang.c: Update.
  87         * p-valprint.c: Update.
  88         * parse.c: Update.
  89         * ppc-linux-tdep.c: Update.
  90         * printcmd.c: Update.
  91         * python/py-arch.c: Update.
  92         * python/py-breakpoint.c: Update.
  93         * python/py-cmd.c: Update.
  94         * python/py-finishbreakpoint.c: Update.
  95         * python/py-frame.c: Update.
  96         * python/py-framefilter.c: Update.
  97         * python/py-gdb-readline.c: Update.
  98         * python/py-inferior.c: Update.
  99         * python/py-infthread.c: Update.
 100         * python/py-lazy-string.c: Update.
 101         * python/py-linetable.c: Update.
 102         * python/py-objfile.c: Update.
 103         * python/py-param.c: Update.
 104         * python/py-prettyprint.c: Update.
 105         * python/py-progspace.c: Update.
 106         * python/py-record-btrace.c: Update.
 107         * python/py-record.c: Update.
 108         * python/py-symbol.c: Update.
 109         * python/py-type.c: Update.
 110         * python/py-unwind.c: Update.
 111         * python/py-utils.c: Update.
 112         * python/py-value.c: Update.
 113         * python/python.c: Update.
 114         * record-btrace.c: Update.
 115         * record-full.c: Update.
 116         * remote-fileio.c: Update.
 117         * remote.c: Update.
 118         * riscv-tdep.c: Update.
 119         * rs6000-aix-tdep.c: Update.
 120         * rs6000-tdep.c: Update.
 121         * rust-exp.y: Update.
 122         * rust-lang.c: Update.
 123         * s390-tdep.c: Update.
 124         * selftest-arch.c: Update.
 125         * solib-dsbt.c: Update.
 126         * solib-frv.c: Update.
 127         * solib-spu.c: Update.
 128         * solib-svr4.c: Update.
 129         * solib.c: Update.
 130         * sparc64-linux-tdep.c: Update.
 131         * stack.c: Update.
 132         * symfile-mem.c: Update.
 133         * symmisc.c: Update.
 134         * target.c: Update.
 135         * thread.c: Update.
 136         * top.c: Update.
 137         * tracefile-tfile.c: Update.
 138         * tui/tui.c: Update.
 139         * typeprint.c: Update.
 140         * unittests/cli-utils-selftests.c: Update.
 141         * unittests/parse-connection-spec-selftests.c: Update.
 142         * valops.c: Update.
 143         * valprint.c: Update.
 144         * value.c: Update.
 145         * varobj.c: Update.
 146         * windows-nat.c: Update.
 147         * x86-linux-nat.c: Update.
 148         * xml-support.c: Update.
 149
 150 2019-04-08  Tom Tromey  <tom@tromey.com>
 151
 152         * xml-support.c: Use C++ exception handling.
 153         * x86-linux-nat.c: Use C++ exception handling.
 154         * windows-nat.c: Use C++ exception handling.
 155         * varobj.c: Use C++ exception handling.
 156         * value.c: Use C++ exception handling.
 157         * valprint.c: Use C++ exception handling.
 158         * valops.c: Use C++ exception handling.
 159         * unittests/parse-connection-spec-selftests.c: Use C++ exception
 160         handling.
 161         * unittests/cli-utils-selftests.c: Use C++ exception handling.
 162         * typeprint.c: Use C++ exception handling.
 163         * tui/tui.c: Use C++ exception handling.
 164         * tracefile-tfile.c: Use C++ exception handling.
 165         * top.c: Use C++ exception handling.
 166         * thread.c: Use C++ exception handling.
 167         * target.c: Use C++ exception handling.
 168         * symmisc.c: Use C++ exception handling.
 169         * symfile-mem.c: Use C++ exception handling.
 170         * stack.c: Use C++ exception handling.
 171         * sparc64-linux-tdep.c: Use C++ exception handling.
 172         * solib.c: Use C++ exception handling.
 173         * solib-svr4.c: Use C++ exception handling.
 174         * solib-spu.c: Use C++ exception handling.
 175         * solib-frv.c: Use C++ exception handling.
 176         * solib-dsbt.c: Use C++ exception handling.
 177         * selftest-arch.c: Use C++ exception handling.
 178         * s390-tdep.c: Use C++ exception handling.
 179         * rust-lang.c: Use C++ exception handling.
 180         * rust-exp.y: Use C++ exception handling.
 181         * rs6000-tdep.c: Use C++ exception handling.
 182         * rs6000-aix-tdep.c: Use C++ exception handling.
 183         * riscv-tdep.c: Use C++ exception handling.
 184         * remote.c: Use C++ exception handling.
 185         * remote-fileio.c: Use C++ exception handling.
 186         * record-full.c: Use C++ exception handling.
 187         * record-btrace.c: Use C++ exception handling.
 188         * python/python.c: Use C++ exception handling.
 189         * python/py-value.c: Use C++ exception handling.
 190         * python/py-utils.c: Use C++ exception handling.
 191         * python/py-unwind.c: Use C++ exception handling.
 192         * python/py-type.c: Use C++ exception handling.
 193         * python/py-symbol.c: Use C++ exception handling.
 194         * python/py-record.c: Use C++ exception handling.
 195         * python/py-record-btrace.c: Use C++ exception handling.
 196         * python/py-progspace.c: Use C++ exception handling.
 197         * python/py-prettyprint.c: Use C++ exception handling.
 198         * python/py-param.c: Use C++ exception handling.
 199         * python/py-objfile.c: Use C++ exception handling.
 200         * python/py-linetable.c: Use C++ exception handling.
 201         * python/py-lazy-string.c: Use C++ exception handling.
 202         * python/py-infthread.c: Use C++ exception handling.
 203         * python/py-inferior.c: Use C++ exception handling.
 204         * python/py-gdb-readline.c: Use C++ exception handling.
 205         * python/py-framefilter.c: Use C++ exception handling.
 206         * python/py-frame.c: Use C++ exception handling.
 207         * python/py-finishbreakpoint.c: Use C++ exception handling.
 208         * python/py-cmd.c: Use C++ exception handling.
 209         * python/py-breakpoint.c: Use C++ exception handling.
 210         * python/py-arch.c: Use C++ exception handling.
 211         * printcmd.c: Use C++ exception handling.
 212         * ppc-linux-tdep.c: Use C++ exception handling.
 213         * parse.c: Use C++ exception handling.
 214         * p-valprint.c: Use C++ exception handling.
 215         * objc-lang.c: Use C++ exception handling.
 216         * mi/mi-main.c: Use C++ exception handling.
 217         * mi/mi-interp.c: Use C++ exception handling.
 218         * mi/mi-cmd-stack.c: Use C++ exception handling.
 219         * mi/mi-cmd-break.c: Use C++ exception handling.
 220         * main.c: Use C++ exception handling.
 221         * linux-thread-db.c: Use C++ exception handling.
 222         * linux-tdep.c: Use C++ exception handling.
 223         * linux-nat.c: Use C++ exception handling.
 224         * linux-fork.c: Use C++ exception handling.
 225         * linespec.c: Use C++ exception handling.
 226         * language.c: Use C++ exception handling.
 227         * jit.c: Use C++ exception handling.
 228         * infrun.c: Use C++ exception handling.
 229         * infcmd.c: Use C++ exception handling.
 230         * infcall.c: Use C++ exception handling.
 231         * inf-loop.c: Use C++ exception handling.
 232         * i386-tdep.c: Use C++ exception handling.
 233         * i386-linux-tdep.c: Use C++ exception handling.
 234         * guile/scm-value.c: Use C++ exception handling.
 235         * guile/scm-type.c: Use C++ exception handling.
 236         * guile/scm-symtab.c: Use C++ exception handling.
 237         * guile/scm-symbol.c: Use C++ exception handling.
 238         * guile/scm-pretty-print.c: Use C++ exception handling.
 239         * guile/scm-ports.c: Use C++ exception handling.
 240         * guile/scm-param.c: Use C++ exception handling.
 241         * guile/scm-math.c: Use C++ exception handling.
 242         * guile/scm-lazy-string.c: Use C++ exception handling.
 243         * guile/scm-frame.c: Use C++ exception handling.
 244         * guile/scm-disasm.c: Use C++ exception handling.
 245         * guile/scm-cmd.c: Use C++ exception handling.
 246         * guile/scm-breakpoint.c: Use C++ exception handling.
 247         * guile/scm-block.c: Use C++ exception handling.
 248         * guile/guile-internal.h: Use C++ exception handling.
 249         * gnu-v3-abi.c: Use C++ exception handling.
 250         * gdbtypes.c: Use C++ exception handling.
 251         * frame.c: Use C++ exception handling.
 252         * frame-unwind.c: Use C++ exception handling.
 253         * fbsd-tdep.c: Use C++ exception handling.
 254         * f-valprint.c: Use C++ exception handling.
 255         * exec.c: Use C++ exception handling.
 256         * event-top.c: Use C++ exception handling.
 257         * event-loop.c: Use C++ exception handling.
 258         * eval.c: Use C++ exception handling.
 259         * dwarf2read.c: Use C++ exception handling.
 260         * dwarf2loc.c: Use C++ exception handling.
 261         * dwarf2-frame.c: Use C++ exception handling.
 262         * dwarf2-frame-tailcall.c: Use C++ exception handling.
 263         * dwarf-index-write.c: Use C++ exception handling.
 264         * dwarf-index-cache.c: Use C++ exception handling.
 265         * dtrace-probe.c: Use C++ exception handling.
 266         * disasm-selftests.c: Use C++ exception handling.
 267         * darwin-nat.c: Use C++ exception handling.
 268         * cp-valprint.c: Use C++ exception handling.
 269         * cp-support.c: Use C++ exception handling.
 270         * cp-abi.c: Use C++ exception handling.
 271         * corelow.c: Use C++ exception handling.
 272         * completer.c: Use C++ exception handling.
 273         * compile/compile-object-run.c: Use C++ exception handling.
 274         * compile/compile-object-load.c: Use C++ exception handling.
 275         * compile/compile-cplus-symbols.c: Use C++ exception handling.
 276         * compile/compile-c-symbols.c: Use C++ exception handling.
 277         * common/selftest.c: Use C++ exception handling.
 278         * common/new-op.c: Use C++ exception handling.
 279         * cli/cli-script.c: Use C++ exception handling.
 280         * cli/cli-interp.c: Use C++ exception handling.
 281         * cli/cli-cmds.c: Use C++ exception handling.
 282         * c-varobj.c: Use C++ exception handling.
 283         * btrace.c: Use C++ exception handling.
 284         * breakpoint.c: Use C++ exception handling.
 285         * break-catch-throw.c: Use C++ exception handling.
 286         * arch-utils.c: Use C++ exception handling.
 287         * amd64-tdep.c: Use C++ exception handling.
 288         * ada-valprint.c: Use C++ exception handling.
 289         * ada-typeprint.c: Use C++ exception handling.
 290         * ada-lang.c: Use C++ exception handling.
 291         * aarch64-tdep.c: Use C++ exception handling.
 292
 293 2019-04-08  Tom Tromey  <tom@tromey.com>
 294
 295         * xml-support.c (gdb_xml_parser::parse): Update.
 296         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 297         * value.c (show_convenience): Update.
 298         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
 299         (test_parse_flags_qcs): Update.
 300         * thread.c (thr_try_catch_cmd): Update.
 301         * target.c (target_translate_tls_address): Update.
 302         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 303         (info_frame_command_core, frame_apply_command_count): Update.
 304         * rust-exp.y (rust_lex_exception_test): Update.
 305         * riscv-tdep.c (riscv_print_one_register_info): Update.
 306         * remote.c (remote_target::enable_btrace): Update.
 307         * record-btrace.c (record_btrace_enable_warn): Update.
 308         * python/py-utils.c (gdbpy_convert_exception): Update.
 309         * printcmd.c (do_one_display, print_variable_and_value): Update.
 310         * mi/mi-main.c (mi_print_exception): Update.
 311         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
 312         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 313         * linux-nat.c (linux_nat_target::attach): Update.
 314         * linux-fork.c (class scoped_switch_fork_info): Update.
 315         * infrun.c (displaced_step_prepare): Update.
 316         * infcall.c (call_function_by_hand_dummy): Update.
 317         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
 318         * gnu-v3-abi.c (print_one_vtable): Update.
 319         * frame.c (get_prev_frame_always): Update.
 320         * f-valprint.c (info_common_command_for_block): Update.
 321         * exec.c (try_open_exec_file): Update.
 322         * exceptions.c (print_exception, exception_print)
 323         (exception_fprintf, exception_print_same): Update.
 324         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
 325         * dwarf-index-cache.c (index_cache::store)
 326         (index_cache::lookup_gdb_index): Update.
 327         * darwin-nat.c (maybe_cache_shell): Update.
 328         * cp-valprint.c (cp_print_value_fields): Update.
 329         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
 330         (gcc_cplus_symbol_address): Update.
 331         * compile/compile-c-symbols.c (gcc_convert_symbol)
 332         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
 333         * common/selftest.c: Update.
 334         * common/common-exceptions.h (struct gdb_exception) <message>: Now
 335         a std::string.
 336         (exception_try_scope_entry, exception_try_scope_exit): Don't
 337         declare.
 338         (struct exception_try_scope): Remove.
 339         (TRY): Don't use exception_try_scope.
 340         (struct gdb_exception): Add constructor, operator=.
 341         <what>: New method.
 342         (struct gdb_exception_RETURN_MASK_ALL)
 343         (struct gdb_exception_RETURN_MASK_ERROR)
 344         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
 345         (struct gdb_quit_bad_alloc): Update.
 346         * common/common-exceptions.c (exception_none): Change
 347         initializer.
 348         (struct catcher) <state, exception>: Initialize inline.
 349         <prev>: Remove member.
 350         (current_catcher): Remove.
 351         (catchers): New global.
 352         (exceptions_state_mc_init): Simplify.
 353         (catcher_pop): Remove.
 354         (exceptions_state_mc, exceptions_state_mc_catch): Update.
 355         (try_scope_depth, exception_try_scope_entry)
 356         (exception_try_scope_exit): Remove.
 357         (throw_exception_sjlj): Update.
 358         (exception_messages, exception_messages_size): Remove.
 359         (throw_it): Simplify.
 360         (gdb_exception_sliced_copy): Remove.
 361         (throw_exception_cxx): Update.
 362         * cli/cli-script.c (script_from_file): Update.
 363         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
 364         Update.
 365         * ada-valprint.c (ada_val_print): Update.
 366         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
 367         (create_excep_cond_exprs): Update.
 368
 369 2019-04-08  Tom Tromey  <tom@tromey.com>
 370
 371         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
 372         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
 373         (TRY, CATCH, END_CATCH): Remove some definitions.
 374         * common/common-exceptions.c: Don't use GDB_XCPT.
 375         (catcher_list_size): Remove.
 376         (throw_exception, throw_it): Simplify.
 377
 378 2019-04-05  Tom Tromey  <tom@tromey.com>
 379
 380         Revert the header-sorting patch.
 381         * ft32-tdep.c: Revert.
 382         * frv-tdep.c: Revert.
 383         * frv-linux-tdep.c: Revert.
 384         * frame.c: Revert.
 385         * frame-unwind.c: Revert.
 386         * frame-base.c: Revert.
 387         * fork-child.c: Revert.
 388         * findvar.c: Revert.
 389         * findcmd.c: Revert.
 390         * filesystem.c: Revert.
 391         * filename-seen-cache.h: Revert.
 392         * filename-seen-cache.c: Revert.
 393         * fbsd-tdep.c: Revert.
 394         * fbsd-nat.h: Revert.
 395         * fbsd-nat.c: Revert.
 396         * f-valprint.c: Revert.
 397         * f-typeprint.c: Revert.
 398         * f-lang.c: Revert.
 399         * extension.h: Revert.
 400         * extension.c: Revert.
 401         * extension-priv.h: Revert.
 402         * expprint.c: Revert.
 403         * exec.h: Revert.
 404         * exec.c: Revert.
 405         * exceptions.c: Revert.
 406         * event-top.c: Revert.
 407         * event-loop.c: Revert.
 408         * eval.c: Revert.
 409         * elfread.c: Revert.
 410         * dwarf2read.h: Revert.
 411         * dwarf2read.c: Revert.
 412         * dwarf2loc.c: Revert.
 413         * dwarf2expr.h: Revert.
 414         * dwarf2expr.c: Revert.
 415         * dwarf2-frame.c: Revert.
 416         * dwarf2-frame-tailcall.c: Revert.
 417         * dwarf-index-write.h: Revert.
 418         * dwarf-index-write.c: Revert.
 419         * dwarf-index-common.c: Revert.
 420         * dwarf-index-cache.h: Revert.
 421         * dwarf-index-cache.c: Revert.
 422         * dummy-frame.c: Revert.
 423         * dtrace-probe.c: Revert.
 424         * disasm.h: Revert.
 425         * disasm.c: Revert.
 426         * disasm-selftests.c: Revert.
 427         * dictionary.c: Revert.
 428         * dicos-tdep.c: Revert.
 429         * demangle.c: Revert.
 430         * dcache.h: Revert.
 431         * dcache.c: Revert.
 432         * darwin-nat.h: Revert.
 433         * darwin-nat.c: Revert.
 434         * darwin-nat-info.c: Revert.
 435         * d-valprint.c: Revert.
 436         * d-namespace.c: Revert.
 437         * d-lang.c: Revert.
 438         * ctf.c: Revert.
 439         * csky-tdep.c: Revert.
 440         * csky-linux-tdep.c: Revert.
 441         * cris-tdep.c: Revert.
 442         * cris-linux-tdep.c: Revert.
 443         * cp-valprint.c: Revert.
 444         * cp-support.c: Revert.
 445         * cp-namespace.c: Revert.
 446         * cp-abi.c: Revert.
 447         * corelow.c: Revert.
 448         * corefile.c: Revert.
 449         * continuations.c: Revert.
 450         * completer.h: Revert.
 451         * completer.c: Revert.
 452         * complaints.c: Revert.
 453         * coffread.c: Revert.
 454         * coff-pe-read.c: Revert.
 455         * cli-out.h: Revert.
 456         * cli-out.c: Revert.
 457         * charset.c: Revert.
 458         * c-varobj.c: Revert.
 459         * c-valprint.c: Revert.
 460         * c-typeprint.c: Revert.
 461         * c-lang.c: Revert.
 462         * buildsym.c: Revert.
 463         * buildsym-legacy.c: Revert.
 464         * build-id.h: Revert.
 465         * build-id.c: Revert.
 466         * btrace.c: Revert.
 467         * bsd-uthread.c: Revert.
 468         * breakpoint.h: Revert.
 469         * breakpoint.c: Revert.
 470         * break-catch-throw.c: Revert.
 471         * break-catch-syscall.c: Revert.
 472         * break-catch-sig.c: Revert.
 473         * blockframe.c: Revert.
 474         * block.c: Revert.
 475         * bfin-tdep.c: Revert.
 476         * bfin-linux-tdep.c: Revert.
 477         * bfd-target.c: Revert.
 478         * bcache.c: Revert.
 479         * ax-general.c: Revert.
 480         * ax-gdb.h: Revert.
 481         * ax-gdb.c: Revert.
 482         * avr-tdep.c: Revert.
 483         * auxv.c: Revert.
 484         * auto-load.c: Revert.
 485         * arm-wince-tdep.c: Revert.
 486         * arm-tdep.c: Revert.
 487         * arm-symbian-tdep.c: Revert.
 488         * arm-pikeos-tdep.c: Revert.
 489         * arm-obsd-tdep.c: Revert.
 490         * arm-nbsd-tdep.c: Revert.
 491         * arm-nbsd-nat.c: Revert.
 492         * arm-linux-tdep.c: Revert.
 493         * arm-linux-nat.c: Revert.
 494         * arm-fbsd-tdep.c: Revert.
 495         * arm-fbsd-nat.c: Revert.
 496         * arm-bsd-tdep.c: Revert.
 497         * arch-utils.c: Revert.
 498         * arc-tdep.c: Revert.
 499         * arc-newlib-tdep.c: Revert.
 500         * annotate.h: Revert.
 501         * annotate.c: Revert.
 502         * amd64-windows-tdep.c: Revert.
 503         * amd64-windows-nat.c: Revert.
 504         * amd64-tdep.c: Revert.
 505         * amd64-sol2-tdep.c: Revert.
 506         * amd64-obsd-tdep.c: Revert.
 507         * amd64-obsd-nat.c: Revert.
 508         * amd64-nbsd-tdep.c: Revert.
 509         * amd64-nbsd-nat.c: Revert.
 510         * amd64-nat.c: Revert.
 511         * amd64-linux-tdep.c: Revert.
 512         * amd64-linux-nat.c: Revert.
 513         * amd64-fbsd-tdep.c: Revert.
 514         * amd64-fbsd-nat.c: Revert.
 515         * amd64-dicos-tdep.c: Revert.
 516         * amd64-darwin-tdep.c: Revert.
 517         * amd64-bsd-nat.c: Revert.
 518         * alpha-tdep.c: Revert.
 519         * alpha-obsd-tdep.c: Revert.
 520         * alpha-nbsd-tdep.c: Revert.
 521         * alpha-mdebug-tdep.c: Revert.
 522         * alpha-linux-tdep.c: Revert.
 523         * alpha-linux-nat.c: Revert.
 524         * alpha-bsd-tdep.c: Revert.
 525         * alpha-bsd-nat.c: Revert.
 526         * aix-thread.c: Revert.
 527         * agent.c: Revert.
 528         * addrmap.c: Revert.
 529         * ada-varobj.c: Revert.
 530         * ada-valprint.c: Revert.
 531         * ada-typeprint.c: Revert.
 532         * ada-tasks.c: Revert.
 533         * ada-lang.c: Revert.
 534         * aarch64-tdep.c: Revert.
 535         * aarch64-ravenscar-thread.c: Revert.
 536         * aarch64-newlib-tdep.c: Revert.
 537         * aarch64-linux-tdep.c: Revert.
 538         * aarch64-linux-nat.c: Revert.
 539         * aarch64-fbsd-tdep.c: Revert.
 540         * aarch64-fbsd-nat.c: Revert.
 541         * aarch32-linux-nat.c: Revert.
 542
 543 2019-04-05  Tom Tromey  <tom@tromey.com>
 544
 545         * ft32-tdep.c: Sort headers.
 546         * frv-tdep.c: Sort headers.
 547         * frv-linux-tdep.c: Sort headers.
 548         * frame.c: Sort headers.
 549         * frame-unwind.c: Sort headers.
 550         * frame-base.c: Sort headers.
 551         * fork-child.c: Sort headers.
 552         * findvar.c: Sort headers.
 553         * findcmd.c: Sort headers.
 554         * filesystem.c: Sort headers.
 555         * filename-seen-cache.h: Sort headers.
 556         * filename-seen-cache.c: Sort headers.
 557         * fbsd-tdep.c: Sort headers.
 558         * fbsd-nat.h: Sort headers.
 559         * fbsd-nat.c: Sort headers.
 560         * f-valprint.c: Sort headers.
 561         * f-typeprint.c: Sort headers.
 562         * f-lang.c: Sort headers.
 563         * extension.h: Sort headers.
 564         * extension.c: Sort headers.
 565         * extension-priv.h: Sort headers.
 566         * expprint.c: Sort headers.
 567         * exec.h: Sort headers.
 568         * exec.c: Sort headers.
 569         * exceptions.c: Sort headers.
 570         * event-top.c: Sort headers.
 571         * event-loop.c: Sort headers.
 572         * eval.c: Sort headers.
 573         * elfread.c: Sort headers.
 574         * dwarf2read.h: Sort headers.
 575         * dwarf2read.c: Sort headers.
 576         * dwarf2loc.c: Sort headers.
 577         * dwarf2expr.h: Sort headers.
 578         * dwarf2expr.c: Sort headers.
 579         * dwarf2-frame.c: Sort headers.
 580         * dwarf2-frame-tailcall.c: Sort headers.
 581         * dwarf-index-write.h: Sort headers.
 582         * dwarf-index-write.c: Sort headers.
 583         * dwarf-index-common.c: Sort headers.
 584         * dwarf-index-cache.h: Sort headers.
 585         * dwarf-index-cache.c: Sort headers.
 586         * dummy-frame.c: Sort headers.
 587         * dtrace-probe.c: Sort headers.
 588         * disasm.h: Sort headers.
 589         * disasm.c: Sort headers.
 590         * disasm-selftests.c: Sort headers.
 591         * dictionary.c: Sort headers.
 592         * dicos-tdep.c: Sort headers.
 593         * demangle.c: Sort headers.
 594         * dcache.h: Sort headers.
 595         * dcache.c: Sort headers.
 596         * darwin-nat.h: Sort headers.
 597         * darwin-nat.c: Sort headers.
 598         * darwin-nat-info.c: Sort headers.
 599         * d-valprint.c: Sort headers.
 600         * d-namespace.c: Sort headers.
 601         * d-lang.c: Sort headers.
 602         * ctf.c: Sort headers.
 603         * csky-tdep.c: Sort headers.
 604         * csky-linux-tdep.c: Sort headers.
 605         * cris-tdep.c: Sort headers.
 606         * cris-linux-tdep.c: Sort headers.
 607         * cp-valprint.c: Sort headers.
 608         * cp-support.c: Sort headers.
 609         * cp-namespace.c: Sort headers.
 610         * cp-abi.c: Sort headers.
 611         * corelow.c: Sort headers.
 612         * corefile.c: Sort headers.
 613         * continuations.c: Sort headers.
 614         * completer.h: Sort headers.
 615         * completer.c: Sort headers.
 616         * complaints.c: Sort headers.
 617         * coffread.c: Sort headers.
 618         * coff-pe-read.c: Sort headers.
 619         * cli-out.h: Sort headers.
 620         * cli-out.c: Sort headers.
 621         * charset.c: Sort headers.
 622         * c-varobj.c: Sort headers.
 623         * c-valprint.c: Sort headers.
 624         * c-typeprint.c: Sort headers.
 625         * c-lang.c: Sort headers.
 626         * buildsym.c: Sort headers.
 627         * buildsym-legacy.c: Sort headers.
 628         * build-id.h: Sort headers.
 629         * build-id.c: Sort headers.
 630         * btrace.c: Sort headers.
 631         * bsd-uthread.c: Sort headers.
 632         * breakpoint.h: Sort headers.
 633         * breakpoint.c: Sort headers.
 634         * break-catch-throw.c: Sort headers.
 635         * break-catch-syscall.c: Sort headers.
 636         * break-catch-sig.c: Sort headers.
 637         * blockframe.c: Sort headers.
 638         * block.c: Sort headers.
 639         * bfin-tdep.c: Sort headers.
 640         * bfin-linux-tdep.c: Sort headers.
 641         * bfd-target.c: Sort headers.
 642         * bcache.c: Sort headers.
 643         * ax-general.c: Sort headers.
 644         * ax-gdb.h: Sort headers.
 645         * ax-gdb.c: Sort headers.
 646         * avr-tdep.c: Sort headers.
 647         * auxv.c: Sort headers.
 648         * auto-load.c: Sort headers.
 649         * arm-wince-tdep.c: Sort headers.
 650         * arm-tdep.c: Sort headers.
 651         * arm-symbian-tdep.c: Sort headers.
 652         * arm-pikeos-tdep.c: Sort headers.
 653         * arm-obsd-tdep.c: Sort headers.
 654         * arm-nbsd-tdep.c: Sort headers.
 655         * arm-nbsd-nat.c: Sort headers.
 656         * arm-linux-tdep.c: Sort headers.
 657         * arm-linux-nat.c: Sort headers.
 658         * arm-fbsd-tdep.c: Sort headers.
 659         * arm-fbsd-nat.c: Sort headers.
 660         * arm-bsd-tdep.c: Sort headers.
 661         * arch-utils.c: Sort headers.
 662         * arc-tdep.c: Sort headers.
 663         * arc-newlib-tdep.c: Sort headers.
 664         * annotate.h: Sort headers.
 665         * annotate.c: Sort headers.
 666         * amd64-windows-tdep.c: Sort headers.
 667         * amd64-windows-nat.c: Sort headers.
 668         * amd64-tdep.c: Sort headers.
 669         * amd64-sol2-tdep.c: Sort headers.
 670         * amd64-obsd-tdep.c: Sort headers.
 671         * amd64-obsd-nat.c: Sort headers.
 672         * amd64-nbsd-tdep.c: Sort headers.
 673         * amd64-nbsd-nat.c: Sort headers.
 674         * amd64-nat.c: Sort headers.
 675         * amd64-linux-tdep.c: Sort headers.
 676         * amd64-linux-nat.c: Sort headers.
 677         * amd64-fbsd-tdep.c: Sort headers.
 678         * amd64-fbsd-nat.c: Sort headers.
 679         * amd64-dicos-tdep.c: Sort headers.
 680         * amd64-darwin-tdep.c: Sort headers.
 681         * amd64-bsd-nat.c: Sort headers.
 682         * alpha-tdep.c: Sort headers.
 683         * alpha-obsd-tdep.c: Sort headers.
 684         * alpha-nbsd-tdep.c: Sort headers.
 685         * alpha-mdebug-tdep.c: Sort headers.
 686         * alpha-linux-tdep.c: Sort headers.
 687         * alpha-linux-nat.c: Sort headers.
 688         * alpha-bsd-tdep.c: Sort headers.
 689         * alpha-bsd-nat.c: Sort headers.
 690         * aix-thread.c: Sort headers.
 691         * agent.c: Sort headers.
 692         * addrmap.c: Sort headers.
 693         * ada-varobj.c: Sort headers.
 694         * ada-valprint.c: Sort headers.
 695         * ada-typeprint.c: Sort headers.
 696         * ada-tasks.c: Sort headers.
 697         * ada-lang.c: Sort headers.
 698         * aarch64-tdep.c: Sort headers.
 699         * aarch64-ravenscar-thread.c: Sort headers.
 700         * aarch64-newlib-tdep.c: Sort headers.
 701         * aarch64-linux-tdep.c: Sort headers.
 702         * aarch64-linux-nat.c: Sort headers.
 703         * aarch64-fbsd-tdep.c: Sort headers.
 704         * aarch64-fbsd-nat.c: Sort headers.
 705         * aarch32-linux-nat.c: Sort headers.
 706
 707 2019-04-04  Tom Tromey  <tom@tromey.com>
 708
 709         * varobj.c (varobj_create): Update.
 710         * rust-exp.y (struct rust_parser) <update_innermost_block,
 711         lookup_symbol>: New methods.
 712         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
 713         Rename.
 714         (rust_parser::rust_lookup_type)
 715         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 716         * printcmd.c (display_command, do_one_display): Update.
 717         * parser-defs.h (struct parser_state) <parser_state>: Add
 718         "tracker" parameter.
 719         (block_tracker): New member.
 720         (class innermost_block_tracker) <innermost_block_tracker>: Add
 721         "types" parameter.
 722         <reset>: Remove method.
 723         (innermost_block): Don't declare.
 724         (null_post_parser): Update.
 725         * parse.c (innermost_block): Remove global.
 726         (write_dollar_variable): Update.
 727         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
 728         Remove "tracker_types" parameter.
 729         (parse_expression): Add "tracker" parameter.
 730         (parse_expression_for_completion): Update.
 731         (null_post_parser): Add "tracker" parameter.
 732         * p-exp.y: Update rules.
 733         * m2-exp.y: Update rules.
 734         * language.h (struct language_defn) <la_post_parser>: Add
 735         "tracker" parameter.
 736         * go-exp.y: Update rules.
 737         * f-exp.y: Update rules.
 738         * expression.h (parse_expression, parse_exp_1): Add "tracker"
 739         parameter.
 740         * d-exp.y: Update rules.
 741         * c-exp.y: Update rules.
 742         * breakpoint.c (set_breakpoint_condition): Create an
 743         innermost_block_tracker.
 744         (watch_command_1): Likewise.
 745         * ada-lang.c (resolve): Add "tracker" parameter.
 746         (resolve_subexp): Likewise.
 747         * ada-exp.y (write_var_from_sym): Update.
 748
 749 2019-04-04  Tom Tromey  <tom@tromey.com>
 750
 751         * type-stack.h: New file.
 752         * type-stack.c: New file.
 753         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
 754         type-stack.h.
 755         (insert_into_type_stack, insert_type, push_type, push_type_int)
 756         (insert_type_address_space, pop_type, pop_type_int)
 757         (pop_typelist, pop_type_stack, append_type_stack)
 758         (push_type_stack, get_type_stack, push_typelist)
 759         (follow_type_instance_flags, follow_types): Don't declare.
 760         * parse.c (type_stack): Remove global.
 761         (parse_exp_in_context): Update.
 762         (insert_into_type_stack, insert_type, push_type, push_type_int)
 763         (insert_type_address_space, pop_type, pop_type_int)
 764         (pop_typelist, pop_type_stack, append_type_stack)
 765         (push_type_stack, get_type_stack, push_typelist)
 766         (follow_type_instance_flags, follow_types): Remove (moved to
 767         type-stack.c).
 768         * f-exp.y (type_stack): New global.
 769         Update rules.
 770         (push_kind_type, f_parse): Update.
 771         * d-exp.y (type_stack): New global.
 772         Update rules.
 773         (d_parse): Update.
 774         * c-exp.y (struct c_parse_state) <type_stack>: New member.
 775         Update rules.
 776         * Makefile.in (COMMON_SFILES): Add type-stack.c.
 777         (HFILES_NO_SRCDIR): Add type-stack.h.
 778
 779 2019-04-04  Tom Tromey  <tom@tromey.com>
 780
 781         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
 782         (rust_parser::convert_ast_to_expression, rust_parse)
 783         (rust_lex_test_completion, rust_lex_tests): Update.
 784         * parser-defs.h (struct expr_completion_state): New.
 785         (struct parser_state) <parser_state>: Add completion parameter.
 786         <mark_struct_expression, mark_completion_tag>: New methods.
 787         <parse_completion, m_completion_state>: New members.
 788         (prefixify_expression, null_post_parser): Update.
 789         (mark_struct_expression, mark_completion_tag): Don't declare.
 790         * parse.c (parse_completion, expout_last_struct)
 791         (expout_tag_completion_type, expout_completion_name): Remove
 792         globals.
 793         (parser_state::mark_struct_expression)
 794         (parser_state::mark_completion_tag): Now methods.
 795         (prefixify_expression): Add last_struct parameter.
 796         (prefixify_subexp): Likewise.
 797         (parse_exp_1): Update.
 798         (parse_exp_in_context): Add cstate parameter.  Update.
 799         (parse_expression_for_completion): Create an
 800         expr_completion_state.
 801         (null_post_parser): Add "completion" parameter.
 802         * p-exp.y: Update rules.
 803         (yylex): Update.
 804         * language.h (struct language_defn) <la_post_parser>: Add
 805         "completing" parameter.
 806         * go-exp.y: Update rules.
 807         (lex_one_token): Update.
 808         * expression.h (parse_completion): Don't declare.
 809         * d-exp.y: Update rules.
 810         (lex_one_token): Update rules.
 811         * c-exp.y: Update rules.
 812         (lex_one_token): Update.
 813         * ada-lang.c (resolve): Add "parse_completion" parameter.
 814         (resolve_subexp): Likewise.
 815         (ada_resolve_function): Likewise.
 816
 817 2019-04-04  Tom Tromey  <tom@tromey.com>
 818
 819         * parser-defs.h (struct parser_state) <start_arglist,
 820         end_arglist>: New methods.
 821         <arglist_len, m_funcall_chain>: New members.
 822         (arglist_len, start_arglist, end_arglist): Don't declare.
 823         * parse.c (arglist_len, funcall_chain): Remove global.
 824         (start_arglist, end_arglist): Remove functions.
 825         (parse_exp_in_context): Update.
 826         * p-exp.y: Update rules.
 827         * m2-exp.y: Update rules.
 828         * go-exp.y: Update rules.
 829         * f-exp.y: Update rules.
 830         * d-exp.y: Update rules.
 831         * c-exp.y: Update rules.
 832
 833 2019-04-04  Tom Tromey  <tom@tromey.com>
 834
 835         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
 836         lex_operator, push_back>: New methods.
 837         Update all rules.
 838         (rust_parser::lex_hex, lex_escape): Rename and update.
 839         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
 840         (rust_parser::lex_operator): Rename and update.
 841         (rust_parser::lex_number, rustyylex, rustyyerror)
 842         (rust_lex_test_init, rust_lex_test_sequence)
 843         (rust_lex_test_push_back, rust_lex_tests): Update.
 844         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
 845         parameter.
 846         <lexptr, prev_lexptr>: New members.
 847         (lexptr, prev_lexptr): Don't declare.
 848         * parse.c (lexptr, prev_lexptr): Remove globals.
 849         (parse_exp_in_context): Update.
 850         * p-exp.y (yylex, yyerror): Update.
 851         * m2-exp.y (parse_number, yylex, yyerror): Update.
 852         * go-exp.y (lex_one_token, yyerror): Update.
 853         * f-exp.y (match_string_literal, yylex, yyerror): Update.
 854         * d-exp.y (lex_one_token, yyerror): Update.
 855         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
 856         (lex_one_token, yyerror): Update.
 857         * ada-lex.l (YY_INPUT): Update.
 858         (rewind_to_char): Update.
 859         * ada-exp.y (yyerror): Update.
 860
 861 2019-04-04  Tom Tromey  <tom@tromey.com>
 862
 863         * rust-exp.y (rustyylex, rust_lex_tests): Update.
 864         * parser-defs.h (struct parser_state) <parser_state>: Add new
 865         parameter.
 866         <comma_terminates>: New member.
 867         (comma_terminates): Don't declare global.
 868         * parse.c (comma_terminates): Remove global.
 869         (parse_exp_in_context): Update.
 870         * p-exp.y (yylex): Update.
 871         * m2-exp.y (yylex): Update.
 872         * go-exp.y (lex_one_token): Update.
 873         * f-exp.y (yylex): Update.
 874         * d-exp.y (lex_one_token): Update.
 875         * c-exp.y (lex_one_token): Update.
 876         * ada-lex.l: Update.
 877
 878 2019-04-04  Tom Tromey  <tom@tromey.com>
 879
 880         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
 881         (rustyylex, rust_lex_test_init, rust_lex_test_one)
 882         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
 883         * parser-defs.h (paren_depth): Don't declare.
 884         * parse.c (paren_depth): Remove global.
 885         (parse_exp_in_context): Update.
 886         * p-exp.y (paren_depth): New global.
 887         (pascal_parse): Initialize it.
 888         * m2-exp.y (paren_depth): New global.
 889         (m2_parse): Initialize it.
 890         * go-exp.y (paren_depth): New global.
 891         (go_parse): Initialize it.
 892         * f-exp.y (paren_depth): New global.
 893         (f_parse): Initialize it.
 894         * d-exp.y (paren_depth): New global.
 895         (d_parse): Initialize it.
 896         * c-exp.y (paren_depth): New global.
 897         (c_parse): Initialize it.
 898         * ada-lex.l (paren_depth): New global.
 899         (lexer_init): Initialize it.
 900
 901 2019-04-04  Tom Tromey  <tom@tromey.com>
 902
 903         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
 904         (rust_parser::convert_ast_to_type)
 905         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 906         * parser-defs.h (struct parser_state) <parser_state>: Add
 907         parameters.  Initialize new members.
 908         <expression_context_block, expression_context_pc>: New members.
 909         * parse.c (expression_context_block, expression_context_pc):
 910         Remove globals.
 911         (parse_exp_in_context): Update.
 912         * p-exp.y: Update all rules.
 913         (yylex): Update.
 914         * m2-exp.y: Update all rules.
 915         (yylex): Update.
 916         * go-exp.y (yylex): Update.
 917         * f-exp.y (yylex): Update.
 918         * d-exp.y: Update all rules.
 919         (yylex): Update.
 920         * c-exp.y: Update all rules.
 921         (lex_one_token, classify_name, yylex, c_parse): Update.
 922         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
 923
 924 2019-04-04  Tom Tromey  <tom@tromey.com>
 925
 926         * gdbarch.h, gdbarch.c: Rebuild.
 927         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
 928         * stap-probe.h:
 929         (struct stap_parse_info): Replace "parser_state" with
 930         "expr_builder".
 931         * parser-defs.h (struct expr_builder): Rename from "parser_state".
 932         (parser_state): New class.
 933         * parse.c (expr_builder): Rename.
 934         (expr_builder::release): Rename.
 935         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
 936         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
 937         (write_exp_elt_longcst, write_exp_elt_floatcst)
 938         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
 939         (write_exp_string_vector, write_exp_bitstring)
 940         (write_exp_msymbol, mark_struct_expression)
 941         (write_dollar_variable)
 942         (insert_type_address_space, increase_expout_size): Replace
 943         "parser_state" with "expr_builder".
 944         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
 945         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
 946         "parser_state" with "expr_builder".
 947
 948 2019-04-04  Tom Tromey  <tom@tromey.com>
 949
 950         * rust-exp.y: Replace "parse_language" with method call.
 951         * p-exp.y:
 952         (yylex): Replace "parse_language" with method call.
 953         * m2-exp.y:
 954         (yylex): Replace "parse_language" with method call.
 955         * go-exp.y (classify_name): Replace "parse_language" with method
 956         call.
 957         * f-exp.y (yylex): Replace "parse_language" with method call.
 958         * d-exp.y (lex_one_token): Replace "parse_language" with method
 959         call.
 960         * c-exp.y:
 961         (lex_one_token, classify_name, yylex): Replace "parse_language"
 962         with method call.
 963         * ada-exp.y (find_primitive_type, type_char)
 964         (type_system_address): Replace "parse_language" with method call.
 965
 966 2019-04-04  Tom Tromey  <tom@tromey.com>
 967
 968         * rust-exp.y: Replace "parse_gdbarch" with method call.
 969         * parse.c (write_dollar_variable, insert_type_address_space):
 970         Replace "parse_gdbarch" with method call.
 971         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
 972         call.
 973         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
 974         call.
 975         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
 976         "parse_gdbarch" with method call.
 977         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
 978         with method call.
 979         * f-exp.y (parse_type, parse_f_type, yylex): Replace
 980         "parse_gdbarch" with method call.
 981         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
 982         "parse_gdbarch" with method call.
 983         * c-exp.y (parse_type, parse_number, classify_name): Replace
 984         "parse_gdbarch" with method call.
 985         * ada-lex.l: Replace "parse_gdbarch" with method call.
 986         * ada-exp.y (parse_type, find_primitive_type, type_char)
 987         (type_system_address): Replace "parse_gdbarch" with method call.
 988
 989 2019-04-04  Tom Tromey  <tom@tromey.com>
 990
 991         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
 992         * stap-probe.c (stap_parse_argument): Update.
 993         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
 994         initial_size parameter.
 995         * rust-exp.y (rust_lex_tests): Update.
 996         * parse.c (parser_state): Update.
 997         (parse_exp_in_context): Update.
 998         * parser-defs.h (struct parser_state) <parser_state>: Remove
 999         "initial_size" parameter.
1000
1001 2019-04-04  Tom Tromey  <tom@tromey.com>
1002
1003         * parser-defs.h (increase_expout_size): Don't declare.
1004         * parse.c (increase_expout_size): Now static.
1005
1006 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1007
1008         * gnu-nat.c (gnu_nat_target::wait): Fix
1009         target_waitstatus_to_string call.
1010
1011 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1012
1013         * eval.c (evaluate_subexp_standard): Handle internal functions
1014         during Fortran function call handling.
1015
1016 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * NEWS: Mention new internal functions.
1019         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1020         (read_base_type): Use dwarf2_init_complex_target_type.
1021         * value.c (creal_internal_fn): New function.
1022         (cimag_internal_fn): New function.
1023         (_initialize_values): Register new internal functions.
1024
1025 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1026
1027         * infrun.c (stop_all_threads): If debug_infrun, always
1028         trace the wait status after wait_one, using
1029         target_waitstatus_to_string and target_pid_to_str.
1030         (handle_inferior_event): Replace various trace of
1031         wait status kind by a single trace.
1032         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1033         wait status kind image by target_waitstatus_to_string.
1034         * target/waitstatus.c (target_waitstatus_to_string): Fix
1035         obsolete comment.
1036
1037 2019-04-01  Tom Tromey  <tromey@adacore.com>
1038
1039         PR symtab/23331:
1040         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1041
1042 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1043             Pedro Alves  <palves@redhat.com>
1044
1045         * top.c (quit_force): Call 'finalize_values'.
1046         * value.c (finalize_values): New function.
1047         * value.h (finalize_values): Declare.
1048
1049 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1050
1051         * NEWS: Announce $_gdb_major and $_gdb_minor.
1052
1053         * top.c (init_gdb_version_vars): New function.
1054         (gdb_init): Call init_gdb_version_vars.
1055
1056 2019-03-29  Tom Tromey  <tromey@adacore.com>
1057
1058         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1059         help text.  Remove dead code.
1060
1061 2019-03-29  Keith Seitz  <keiths@redhat.com>
1062
1063         From Siddhesh Poyarekar:
1064         * f-lang.h (f77_get_upperbound): Return LONGEST.
1065         (f77_get_lowerbound): Likewise.
1066         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1067         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1068         print them.
1069         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1070         plongest to format print it.
1071         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1072         (f77_get_upperbound): Likewise.
1073         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1074         LOWER_BOUND to LONGEST.
1075         (f77_create_arrayprint_offset_tbl): Likewise.
1076
1077 2019-03-29  Keith Seitz  <keiths@redhat.com>
1078
1079         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1080         %s/pulongest for TYPE_LENGTH instead of %d in format
1081         strings.
1082         * ada-typerint.c (ada_print_type): Likewise.
1083         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1084         * compile/compile-c-support.c (generate_register_struct): Likewise.
1085         * gdbtypes.c (recursive_dump_type): Likewise.
1086         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1087         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1088         instead of %d in format strings.
1089         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1090         to std::min to ULONGEST.
1091         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1092         instead of %d in format strings.
1093         * tracepoint.c (info_scope_command): Likewise.
1094         * typeprint.c (print_offset_data::update)
1095         (print_offset_data::finish): Likewise.
1096         * xtensa-tdep.c (xtensa_store_return_value)
1097         (xtensa_push_dummy_call): Likewise.
1098
1099 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1100
1101         * windows-nat.c (display_selector): Fixed format specifications
1102         for 64-bit Cygwin.
1103
1104 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1105
1106         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1107
1108 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1109
1110         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1111         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1112         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1113         (nios2_linux_init_abi): Install it.
1114
1115 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1116
1117         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1118
1119 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1120
1121         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1122
1123 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1124             Tom Tromey  <tromey@adacore.com>
1125
1126         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1127
1128 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1129
1130         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1131         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1132         method to compute the bounds of range types. Also print "[evaluated]"
1133         if the bounds' values come from a dynamic evaluation.
1134
1135 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1136
1137         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1138         whitespace when pretty printing is on.
1139
1140 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1141
1142         * ppc-linux-nat.c: Add include.
1143
1144 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1145
1146         * NEWS: Mention AArch64 Pointer Authentication.
1147
1148 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1149
1150         * arm-linux-nat.c: Add include.
1151
1152 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1153
1154         * source-cache.c (source_cache::get_source_lines): Re-read
1155         fullname after calling open_source_file.
1156
1157 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1158
1159         * NEWS: Mention TLS support for FreeBSD.
1160
1161 2019-03-25  Tom Tromey  <tromey@adacore.com>
1162
1163         * minsyms.c (BUNCH_SIZE): Update comment.
1164         (~minimal_symbol_reader): Remove old comment.
1165         (compact_minimal_symbols): Update comment.
1166         (minimal_symbol_reader::install): Remove old comment.  Update
1167         other comments.
1168
1169 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1170
1171         * s390-linux-nat.c: Add include.
1172
1173 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1174
1175         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1176         Call linux_get_hwcap.
1177         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1178         Likewise.
1179         (aarch64_linux_get_hwcap): Remove function.
1180         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1181         declaration.
1182         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1183         linux_get_hwcap.
1184         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1185         * linux-tdep.c (linux_get_hwcap): Add function.
1186         (linux_get_hwcap2): Likewise.
1187         * linux-tdep.h (linux_get_hwcap): Add declaration.
1188         (linux_get_hwcap2): Likewise.
1189         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1190         (ppc_linux_get_hwcap2): Likewise.
1191         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1192         linux_get_hwcap.
1193         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1194         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1195         (ppc_linux_nat_target::read_description): Likewise.
1196         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1197         * s390-linux-nat.c: Likewise.
1198         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1199
1200 2019-03-24  Tom Tromey  <tom@tromey.com>
1201
1202         * ada-lang.c (standard_lookup): Simplify initialization.
1203         (ada_lookup_symbol_nonlocal): Simplify return.
1204         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1205         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1206         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1207         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1208         initialization.
1209         * solib.c (solib_global_lookup): Simplify.
1210         * symtab.c (null_block_symbol): Remove.
1211         (symbol_cache_lookup): Simplify returns.
1212         (lookup_language_this): Simplify returns.
1213         (lookup_symbol_aux): Simplify return.
1214         (lookup_local_symbol): Simplify returns.
1215         (lookup_global_symbol_from_objfile): Simplify return.
1216         (lookup_symbol_in_objfile_symtabs)
1217         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1218         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1219         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1220         * cp-namespace.c (cp_lookup_bare_symbol)
1221         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1222         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1223         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1224         (cp_lookup_symbol_via_imports): Simplify initialization.
1225         (find_symbol_in_baseclass): Likewise.
1226         * symtab.h (null_block_symbol): Remove.
1227         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1228         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1229         (d_lookup_symbol_module): Likewise.
1230         (find_symbol_in_baseclass): Simplify initialization.
1231
1232 2019-03-24  Tom Tromey  <tom@tromey.com>
1233
1234         * expression.h: Don't include symtab.h.
1235         (struct block): Forward declare.
1236
1237 2019-03-24  Tom Tromey  <tom@tromey.com>
1238
1239         * c-exp.y (typebase): Remove casts.
1240         * gdbtypes.c (lookup_unsigned_typename, )
1241         (lookup_signed_typename): Remove cast.
1242         * eval.c (parse_to_comma_and_eval): Remove cast.
1243         * parse.c (write_dollar_variable): Remove cast.
1244         * block.h (struct block) <superblock>: Now const.
1245         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1246         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1247         (map_block): Make "block" const.
1248         * symfile.h (struct quick_symbol_functions)
1249         <map_matching_symbols>: Constify block argument to "callback".
1250         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1251         const.
1252         (find_pc_sect_compunit_symtab): Make "b" const.
1253         (find_symbol_at_address): Likewise.
1254         (search_symbols): Likewise.
1255         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1256         (dw2_debug_names_lookup_symbol): Likewise.
1257         (dw2_map_matching_symbols): Update.
1258         * p-valprint.c (pascal_val_print): Remove "block".
1259         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1260         (aux_add_nonlocal_symbols): Make "block" const.
1261         (resolve_subexp): Remove cast.
1262         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1263         const.
1264         (iterate_over_file_blocks): Likewise.
1265         * f-exp.y (%union) <bval>: Remove.
1266         * coffread.c (patch_opaque_types): Make "b" const.
1267         * spu-tdep.c (spu_catch_start): Make "block" const.
1268         * c-valprint.c (print_unpacked_pointer): Remove "block".
1269         * symmisc.c (dump_symtab_1): Make "b" const.
1270         (block_depth): Make "block" const.
1271         * d-exp.y (%union) <bval>: Remove.
1272         * cp-support.h (cp_lookup_rtti_type): Update.
1273         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1274         * psymtab.c (psym_lookup_symbol): Make "block" const.
1275         (maintenance_check_psymtabs): Make "b" const.
1276         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1277         (enumerate_locals, enumerate_args): Update.
1278         * python/py-symtab.c (stpy_global_block): Make "block" const.
1279         (stpy_static_block): Likewise.
1280         * inline-frame.c (block_starting_point_at): Make "new_block"
1281         const.
1282         * block.c (find_block_in_blockvector): Make return type const.
1283         (blockvector_for_pc_sect): Make "b" const.
1284         (find_block_in_blockvector): Make "b" const.
1285
1286 2019-03-23  Tom Tromey  <tom@tromey.com>
1287
1288         * varobj.c (varobj_create): Update.
1289         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1290         * printcmd.c (display_command, do_one_display): Don't reset
1291         innermost_block.
1292         * parser-defs.h (enum innermost_block_tracker_type): Move to
1293         expression.h.
1294         (innermost_block): Update comment.
1295         * parse.c (parse_exp_1): Add tracker_types parameter.
1296         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1297         tracker_types parameter.  Reset innermost_block.
1298         (parse_exp_in_context): Remove.
1299         (parse_expression_for_completion): Update.
1300         * objfiles.c (~objfile): Don't reset expression_context_block or
1301         innermost_block.
1302         * expression.h (enum innermost_block_tracker_type): Move from
1303         parser-defs.h.
1304         (parse_exp_1): Add tracker_types parameter.
1305         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1306         reset innermost_block.
1307
1308 2019-03-23  Tom Tromey  <tom@tromey.com>
1309
1310         * objfiles.h: Include bcache.h.
1311
1312 2019-03-23  Tom Tromey  <tom@tromey.com>
1313
1314         * linespec.c (get_current_search_block): Use
1315         scoped_restore_current_language.
1316         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1317
1318 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1319             Jiong Wang  <jiong.wang@arm.com>
1320
1321         * aarch64-linux-tdep.c
1322         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1323         section.
1324         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1325
1326 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1327             Jiong Wang  <jiong.wang@arm.com>
1328
1329         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1330         instructions.
1331         (aarch64_analyze_prologue_test): Add PACIASP test.
1332         (aarch64_prologue_prev_register): Unmask PC value.
1333
1334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1335             Jiong Wang  <jiong.wang@arm.com>
1336
1337         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1338         (aarch64_dwarf2_prev_register): Unmask PC value.
1339         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1340         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1341         DW_CFA_AARCH64_negate_ra_state.
1342         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1343
1344 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1345             Jiong Wang  <jiong.wang@arm.com>
1346
1347         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1348         registers.
1349         (aarch64_pseudo_register_name): Likewise.
1350         (aarch64_pseudo_register_type): Likewise.
1351         (aarch64_pseudo_register_reggroup_p): Likewise.
1352         (aarch64_gdbarch_init): Add pauth registers.
1353         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1354         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1355         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1356         (struct gdbarch_tdep): Add regnum for ra_state.
1357
1358 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1359             Jiong Wang  <jiong.wang@arm.com>
1360
1361         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1362
1363 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1364             Jiong Wang  <jiong.wang@arm.com>
1365
1366         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1367         function.
1368         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1369         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1370         (aarch64_gdbarch_init): Add puth registers.
1371         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1372         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1373         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1374
1375 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1376             Jiong Wang  <jiong.wang@arm.com>
1377
1378         * aarch64-linux-nat.c
1379         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1380         * aarch64-linux-tdep.c
1381         (aarch64_linux_core_read_description): Likewise.
1382         (aarch64_linux_get_hwcap): New function.
1383         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1384         (aarch64_linux_get_hwcap): New declaration.
1385
1386 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1387             Jiong Wang  <jiong.wang@arm.com>
1388
1389         * aarch64-linux-nat.c
1390         (aarch64_linux_nat_target::read_description): Add pauth param.
1391         * aarch64-linux-tdep.c
1392         (aarch64_linux_core_read_description): Likewise.
1393         * aarch64-tdep.c (struct target_desc): Add in pauth.
1394         (aarch64_read_description): Add pauth param.
1395         (aarch64_gdbarch_init): Likewise.
1396         * aarch64-tdep.h (aarch64_read_description): Likewise.
1397         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1398         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1399         * features/Makefile: Add new files.
1400         * features/aarch64-pauth.c: New file.
1401         * features/aarch64-pauth.xml: New file.
1402
1403 2019-03-20  Tom Tromey  <tromey@adacore.com>
1404
1405         * infrun.c (handle_inferior_event): Rename from
1406         handle_inferior_event_1.  Create a scoped_value_mark.
1407         (handle_inferior_event): Remove.
1408
1409 2019-03-19  Tom Tromey  <tromey@adacore.com>
1410
1411         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1412         * infrun.h (print_stop_event): Add "displays" parameter.
1413         * infrun.c (print_stop_event): Add "displays" parameter.
1414
1415 2019-03-19  Pedro Alves  <palves@redhat.com>
1416
1417         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1418         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1419         to -1.  Fix TABs vs spaces.
1420         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1421         * tui/tui-out.h (tui_ui_out) Add intro comments.
1422         <m_line, m_start_of_line>: In-class initialize, and add describing
1423         comment.
1424
1425 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1426
1427         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1428         variable names.
1429         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1430
1431 2019-03-18  Pedro Alves  <palves@redhat.com>
1432             Eli Zaretskii <eliz@gnu.org>
1433
1434         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1435         m_line and m_start_of_line.
1436
1437 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1438
1439         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1440         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1441         it returns a newline.  This fixes a regression in TU mode, whereby
1442         the next line is output on the same screen line as the user input.
1443
1444 2019-03-18  Tom Tromey  <tromey@adacore.com>
1445
1446         * minsyms.c (minimal_symbol_reader::install): Remove call to
1447         obstack_blank.
1448
1449 2019-03-18  Pedro Alves  <palves@redhat.com>
1450
1451         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1452         New globals.
1453         (apply_style): New, factored out from ...
1454         (apply_ansi_escape): ... this.  Handle reverse video mode.
1455         (tui_set_reverse_mode): New function.
1456         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1457         * tui/tui-winsource.c (tui_show_source_line): Use
1458         tui_set_reverse_mode instead of setting A_STANDOUT.
1459         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1460         New setter methods.
1461
1462 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1463
1464         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1465         Handle tabs.
1466
1467 2019-03-18  Tom Tromey  <tromey@adacore.com>
1468
1469         * ada-lang.c (empty_array): Add "high" parameter.
1470         (ada_evaluate_subexp): Update.
1471
1472 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1473
1474         * unittests/string_view-selftests.c: Define
1475         _initialize_string_view_selftests unconditionally.
1476
1477 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1478
1479         PR gdb/24350
1480         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1481
1482 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1483
1484         PR gdb/24351
1485         * windows-nat.c (display_selector): Fix format specifiers.
1486
1487 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1488
1489         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1490         tui_refill_source_window instead of tui_refresh_win, to update the
1491         current execution line.  This fixes redisplay of the current line
1492         when stepping through the code with "next" or "step".
1493
1494 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1495
1496         * source-cache.c (source_cache::get_source_lines): Call
1497         find_source_lines to initialize s->nlines.  This fixes vertical
1498         scrolling of TUI source window when the DOWN arrow is pressed.
1499
1500 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1501
1502         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1503         linux-thread-db.c (_initialize_thread_db): Likewise.
1504
1505 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1506
1507         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1508         wclrtoeol in tui_show_source_line".  This reverts changes made in
1509         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1510
1511 2019-03-15  Tom Tromey  <tom@tromey.com>
1512
1513         * symtab.h (struct minimal_symbol): Derive from
1514         general_symbol_info.
1515         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1516         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1517         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1518         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1519         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1520         (MSYMBOL_SEARCH_NAME): Update.
1521         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1522         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1523         * minsyms.c (minimal_symbol_reader::record_full): Update.
1524
1525 2019-03-15  Tom Tromey  <tom@tromey.com>
1526
1527         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1528
1529 2019-03-15  Tom Tromey  <tom@tromey.com>
1530
1531         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1532         unique_xmalloc_ptr.
1533         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1534         Update.
1535         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1536         (build_minimal_symbol_hash_tables)
1537         (minimal_symbol_reader::install): Update.
1538
1539 2019-03-15  Tom Tromey  <tom@tromey.com>
1540
1541         * symtab.c (create_demangled_names_hash): Update.
1542         (symbol_set_names): Update.
1543         * objfiles.h (struct objfile_per_bfd_storage)
1544         <demangled_names_hash>: Now an htab_up.
1545         * objfiles.c (objfile_per_bfd_storage): Simplify.
1546
1547 2019-03-15  Tom Tromey  <tom@tromey.com>
1548
1549         * objfiles.h (struct objfile_per_bfd_storage): Declare
1550         destructor.
1551         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1552         New.
1553         (get_objfile_bfd_data): Use new.  Don't initialize
1554         language_of_main.
1555         (free_objfile_per_bfd_storage): Remove.
1556         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1557
1558 2019-03-15  Tom Tromey  <tom@tromey.com>
1559
1560         * symfile.c (reread_symbols): Update.
1561         * objfiles.c (objfile::objfile): Update.
1562         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1563         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1564         comment.
1565         (minimal_symbol_reader::install): Update.
1566         (terminate_minimal_symbol_table): Remove.
1567         * jit.c (jit_object_close_impl): Update.
1568
1569 2019-03-15  Tom Tromey  <tom@tromey.com>
1570
1571         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1572         initializations.
1573
1574 2019-03-15  Tom Tromey  <tom@tromey.com>
1575
1576         * objfiles.h (struct objfile_per_bfd_storage)
1577         <demangled_hash_languages>: Now a bitset.
1578         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1579         (lookup_minimal_symbol): Update.
1580
1581 2019-03-15  Tom Tromey  <tom@tromey.com>
1582
1583         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1584         Don't return the symbol.
1585         * coffread.c (record_minimal_symbol): Use record_full.
1586
1587 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1588
1589         The MS-Windows port of ncurses fails to switch to a color pair if
1590         one or both of the colors are the implicit default colors.  This
1591         change records the default colors when TUI is initialized, and
1592         then specifies them explicitly when a color pair uses the default
1593         colors.  This allows color styling in TUI mode on MS-Windows.
1594
1595         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1596         ncurses_norm_attr.
1597         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1598         colors in ncurses_norm_attr.
1599         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1600         "none", replace it with the default color recorded in
1601         ncurses_norm_attr.
1602
1603 2019-03-14  Tom Tromey  <tromey@adacore.com>
1604
1605         * source-cache.h (class source_cache) <get_source_lines>: Return
1606         std::string.
1607         * source-cache.c (source_cache::extract_lines): Handle case where
1608         first_pos==npos.  Return std::string.
1609         (source_cache::get_source_lines): Update.
1610
1611 2019-03-14  Tom Tromey  <tromey@adacore.com>
1612
1613         * NEWS: Add item for "style sources" commands.
1614         * source-cache.c (source_cache::get_source_lines): Check
1615         source_styling.
1616         * cli/cli-style.c (source_styling): New global.
1617         (_initialize_cli_style): Add "style sources" commands.
1618         (show_style_sources): New function.
1619         * cli/cli-style.h (source_styling): Declare.
1620
1621 2019-03-14  Pedro Alves  <palves@redhat.com>
1622             Tom Tromey  <tromey@adacore.com>
1623
1624         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1625         * tui/tui-winsource.c (tui_refill_source_window): New function,
1626         from...
1627         (tui_horizontal_source_scroll): ... here.  Move some logic.
1628         * cli/cli-style.c (set_style_enabled): Notify new observable.
1629         * tui/tui-hooks.c (tui_redisplay_source): New function.
1630         (tui_attach_detach_observers): Attach or detach
1631         tui_redisplay_source.
1632         * observable.h (source_styling_changed): New observable.
1633         * observable.c: Define source_styling_changed observable.
1634
1635 2019-03-13  Tom Tromey  <tromey@adacore.com>
1636
1637         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1638         (i386_gnu_nat_target::store_registers): Update.
1639         * target-debug.h (target_debug_print_std_string): New macro.
1640         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1641         * windows-tdep.c (display_one_tib): Update.
1642         * tui/tui-stack.c (tui_make_status_line): Update.
1643         * top.c (print_inferior_quit_action): Update.
1644         * thread.c (thr_try_catch_cmd): Update.
1645         (add_thread_with_info): Update.
1646         (thread_target_id_str): Update.
1647         (thr_try_catch_cmd): Update.
1648         (thread_command): Update.
1649         (thread_find_command): Update.
1650         * record-btrace.c (record_btrace_target::info_record)
1651         (record_btrace_resume_thread, record_btrace_target::resume)
1652         (record_btrace_cancel_resume, record_btrace_step_thread)
1653         (record_btrace_target::wait, record_btrace_target::wait)
1654         (record_btrace_target::wait, record_btrace_target::stop): Update.
1655         * progspace.c (print_program_space): Update.
1656         * process-stratum-target.c
1657         (process_stratum_target::thread_address_space): Update.
1658         * linux-fork.c (linux_fork_mourn_inferior)
1659         (detach_checkpoint_command, info_checkpoints_command)
1660         (linux_fork_context): Update.
1661         (linux_fork_detach): Update.
1662         (class scoped_switch_fork_info): Update.
1663         (delete_checkpoint_command): Update.
1664         * infrun.c (follow_fork_inferior): Update.
1665         (follow_fork_inferior): Update.
1666         (proceed_after_vfork_done): Update.
1667         (handle_vfork_child_exec_or_exit): Update.
1668         (follow_exec): Update.
1669         (displaced_step_prepare_throw): Update.
1670         (displaced_step_restore): Update.
1671         (start_step_over): Update.
1672         (resume_1): Update.
1673         (clear_proceed_status_thread): Update.
1674         (proceed): Update.
1675         (print_target_wait_results): Update.
1676         (do_target_wait): Update.
1677         (context_switch): Update.
1678         (stop_all_threads): Update.
1679         (restart_threads): Update.
1680         (finish_step_over): Update.
1681         (handle_signal_stop): Update.
1682         (switch_back_to_stepped_thread): Update.
1683         (keep_going_pass_signal): Update.
1684         (print_exited_reason): Update.
1685         (normal_stop): Update.
1686         * inferior.c (inferior_pid_to_str): Change return type.
1687         (print_selected_inferior): Update.
1688         (add_inferior): Update.
1689         (detach_inferior): Update.
1690         * dummy-frame.c (fprint_dummy_frames): Update.
1691         * dcache.c (dcache_info_1): Update.
1692         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1693         (btrace_fetch, btrace_clear): Update.
1694         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1695         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1696         type.
1697         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1698         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1699         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1700         * gdbarch.c, gdbarch.h: Rebuild.
1701         * gdbarch.sh (core_pid_to_str): Change return type.
1702         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1703         return type.
1704         (windows_nat_target::pid_to_str): Change return type.
1705         (windows_delete_thread): Update.
1706         (windows_nat_target::attach): Update.
1707         (windows_nat_target::files_info): Update.
1708         * target-delegates.c: Rebuild.
1709         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1710         return type.
1711         (sol_thread_target::pid_to_str): Change return type.
1712         * remote.c (class remote_target) <pid_to_str>: Change return
1713         type.
1714         (remote_target::pid_to_str): Change return type.
1715         (extended_remote_target::attach, remote_target::remote_stop_ns)
1716         (remote_target::remote_notif_remove_queued_reply)
1717         (remote_target::push_stop_reply, remote_target::disable_btrace):
1718         Update.
1719         (extended_remote_target::attach): Update.
1720         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1721         type.
1722         (gdbsim_target::pid_to_str): Change return type.
1723         * ravenscar-thread.c (struct ravenscar_thread_target)
1724         <pid_to_str>: Change return type.
1725         (ravenscar_thread_target::pid_to_str): Change return type.
1726         * procfs.c (class procfs_target) <pid_to_str>: Change return
1727         type.
1728         (procfs_target::pid_to_str): Change return type.
1729         (procfs_target::attach): Update.
1730         (procfs_target::detach): Update.
1731         (procfs_target::fetch_registers): Update.
1732         (procfs_target::store_registers): Update.
1733         (procfs_target::wait): Update.
1734         (procfs_target::files_info): Update.
1735         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1736         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1737         return type.
1738         (nto_procfs_target::pid_to_str): Change return type.
1739         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1740         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1741         return type.
1742         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1743         (exit_lwp): Update.
1744         (attach_proc_task_lwp_callback, get_detach_signal)
1745         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1746         (linux_nat_target::resume, wait_lwp, stop_callback)
1747         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1748         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1749         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1750         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1751         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1752         type.
1753         (inf_ptrace_target::attach): Update.
1754         (inf_ptrace_target::files_info): Update.
1755         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1756         type.
1757         (go32_nat_target::pid_to_str): Change return type.
1758         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1759         (gnu_nat_target::wait): Update.
1760         (gnu_nat_target::wait): Update.
1761         (gnu_nat_target::resume): Update.
1762         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1763         (fbsd_nat_target::wait): Update.
1764         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1765         type.
1766         (darwin_nat_target::attach): Update.
1767         * corelow.c (class core_target) <pid_to_str>: Change return type.
1768         (core_target::pid_to_str): Change return type.
1769         * target.c (normal_pid_to_str): Change return type.
1770         (default_pid_to_str): Likewise.
1771         (target_pid_to_str): Change return type.
1772         (target_translate_tls_address): Update.
1773         (target_announce_detach): Update.
1774         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1775         return type.
1776         (bsd_uthread_target::pid_to_str): Change return type.
1777         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1778         type.
1779         (bsd_kvm_target::pid_to_str): Change return type.
1780         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1781         return type.
1782         (aix_thread_target::pid_to_str): Change return type.
1783         * target.h (struct target_ops) <pid_to_str>: Change return type.
1784         (target_pid_to_str, normal_pid_to_str): Likewise.
1785         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1786         type.
1787         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1788         type.
1789         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1790         return type.
1791         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1792         type.
1793         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1794         type.
1795         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1796         return type.
1797
1798 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1799
1800         * NEWS: Mention that the new default MI version is 3.  Mention
1801         changes to the output of commands and events that deal with
1802         multi-location breakpoints.
1803         * breakpoint.c: Include "mi/mi-out.h".
1804         (print_one_breakpoint): Change output syntax if using MI version
1805         >= 3.
1806         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1807         New.
1808         (mi_multi_location_breakpoint_output_fixed): New.
1809         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1810         (mi_cmd_fix_multi_location_breakpoint_output): New.
1811         (mi_multi_location_breakpoint_output_fixed): New.
1812         * mi/mi-cmds.c (mi_cmds): Register command
1813         -fix-multi-location-breakpoint-output.
1814         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1815         interpreter "mi".
1816
1817 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1818
1819         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1820         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1821         instantiate mi_ui_out based on interpreter name.
1822         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1823         * mi/mi-main.c (mi_load_progress): Likewise.
1824
1825 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1826
1827         * NEWS: Combine separate "New targets" sections for 8.3.
1828
1829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1830
1831         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1832         (ppcfbsd_init_abi): Install gdbarch
1833         "fetch_tls_load_module_address" and "get_thread_local_address"
1834         methods.
1835
1836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1837
1838         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1839         (riscv_fbsd_init_abi): Install gdbarch
1840         "fetch_tls_load_module_address" and "get_thread_local_address"
1841         methods.
1842
1843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1844
1845         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1846         (i386fbsd_init_abi): Install gdbarch
1847         "fetch_tls_load_module_address" and "get_thread_local_address"
1848         methods.
1849
1850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1851
1852         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1853         (amd64fbsd_init_abi): Install gdbarch
1854         "fetch_tls_load_module_address" and "get_thread_local_address"
1855         methods.
1856
1857 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1858
1859         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1860         (struct fbsd_pspace_data): New type.
1861         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1862         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1863         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1864         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1865         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1866
1867 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1868
1869         * gdbtypes.c (lookup_struct_elt): New function.
1870         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1871         * gdbtypes.h (struct struct_elt): New type.
1872         (lookup_struct_elt): New prototype.
1873
1874 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1875
1876         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1877         remove disabled code block.
1878
1879 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1880
1881         * gdbarch.sh (get_thread_local_address): New method.
1882         * gdbarch.h, gdbarch.c: Regenerate.
1883         * target.c (target_translate_tls_address): Use
1884         gdbarch_get_thread_local_address if present instead of
1885         target::get_thread_local_address.
1886
1887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1888
1889         * target.h (target::get_thread_local_address): Update comment.
1890
1891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1892
1893         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1894         objfile->separate_debug_objfile_backlink if not NULL.
1895
1896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1897
1898         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1899         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1900         (amd64bsd_store_inferior_registers): Likewise.
1901         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1902         Enable segment base registers.
1903         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1904         PT_GETFSBASE and PT_GETGSBASE.
1905         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1906         PT_SETGSBASE.
1907         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1908         segment base registers.
1909         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1910
1911 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1912
1913         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1914         Update calls to i386_target_description to add 'segments'
1915         parameter.
1916         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1917         add segment base registers.
1918         * arch/i386.c (i386_create_target_description): Add 'segments'
1919         parameter to enable segment base registers.
1920         * arch/i386.h (i386_create_target_description): Likewise.
1921         * features/i386/32bit-segments.xml: New file.
1922         * features/i386/32bit-segments.c: Generate.
1923         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1924         call to i386_target_description to add 'segments' parameter.
1925         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1926         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1927         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1928         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1929         if feature is present.
1930         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1931         Add 'segments' parameter to call to i386_target_description.
1932         (i386_target_description): Add 'segments' parameter to enable
1933         segment base registers.
1934         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1935         to call to i386_target_description.
1936         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1937         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1938         Define I386_NUM_REGS.
1939         (i386_target_description): Add 'segments' parameter to enable
1940         segment base registers.
1941
1942 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1943
1944         PR/24325
1945         * source-cache.c: #undef open and close, to avoid unresolved
1946         externals during linking.
1947
1948 2019-03-12  Tom Tromey  <tromey@adacore.com>
1949
1950         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1951         const.  Add initializers.
1952         (_initialize_remote): Don't initialize ptid globals.
1953
1954 2019-03-12  Pedro Alves  <palves@redhat.com>
1955
1956         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1957
1958 2019-03-12  Pedro Alves  <palves@redhat.com>
1959
1960         * cp-name-parser.y (main): Remove unused 'len' variable.
1961
1962 2019-03-12  Tom Tromey  <tromey@adacore.com>
1963
1964         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1965         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1966
1967 2019-03-12  Tom Tromey  <tromey@adacore.com>
1968
1969         * linux-nat.c (iterate_over_lwps): Update.
1970         (stop_callback): Remove parameter.
1971         (stop_wait_callback, detach_callback, resume_set_callback)
1972         (select_singlestep_lwp_callback, set_ignore_sigint)
1973         (status_callback, resumed_callback, resume_clear_callback)
1974         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1975         data parameter.
1976         (linux_nat_target::detach, linux_nat_target::resume)
1977         (linux_stop_and_wait_all_lwps, select_event_lwp)
1978         (linux_nat_filter_event, linux_nat_wait_1)
1979         (linux_nat_target::kill, linux_nat_target::stop)
1980         (linux_nat_target::stop): Update.
1981         (linux_nat_resume_callback): Change type.
1982         (resume_stopped_resumed_lwps, count_events_callback)
1983         (select_event_lwp_callback): Likewise.
1984         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1985         * arm-linux-nat.c (struct update_registers_data): Remove.
1986         (update_registers_callback): Change type.
1987         (arm_linux_insert_hw_breakpoint1): Update.
1988         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1989         parameter.
1990         (x86_linux_dr_set_addr): Update.
1991         (x86_linux_dr_set_control): Update.
1992         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1993         (iterate_over_lwps): Use gdb::function_view.
1994         * nat/aarch64-linux-hw-point.c (struct
1995         aarch64_dr_update_callback_param): Remove.
1996         (debug_reg_change_callback): Change type.
1997         (aarch64_notify_debug_reg_change): Update.
1998         * s390-linux-nat.c (s390_refresh_per_info): Update.
1999
2000 2019-03-11  Tom Tromey  <tromey@adacore.com>
2001
2002         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2003         redundant assignment to "this_cu".
2004
2005 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2006
2007         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2008
2009 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2010
2011         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2012         from...
2013         (rank_one_type): ... this.
2014
2015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2016
2017         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2018         from...
2019         (rank_one_type): ... this.
2020
2021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2022
2023         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2024         from...
2025         (rank_one_type): ... this.
2026
2027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2028
2029         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2030         from...
2031         (rank_one_type): ... this.
2032
2033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2034
2035         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2036         from...
2037         (rank_one_type): ... this.
2038
2039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2040
2041         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2042         from...
2043         (rank_one_type): ... this.
2044
2045 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2046
2047         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2048         from...
2049         (rank_one_type): ... this.
2050
2051 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2052
2053         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2054         from...
2055         (rank_one_type): ... this.
2056
2057 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2058
2059         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2060         from...
2061         (rank_one_type): ... this.
2062
2063 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2064
2065         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2066         from...
2067         (rank_one_type): ... this.
2068
2069 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2070
2071         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2072         from...
2073         (rank_one_type): ... this.
2074
2075 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2076
2077         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2078         from...
2079         (rank_one_type): ... this.
2080
2081 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2082
2083         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2084         inferior-events' shows the example events.
2085
2086 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2087
2088         Support styling on native MS-Windows console
2089
2090         PR/24315
2091         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2092         on MS-Windows if $TERM is not defined.
2093
2094         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2095
2096         * posix-hdep.c (gdb_console_fputs):
2097         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2098         functions.
2099         * ui-file.h (gdb_console_fputs): Add prototype.
2100
2101         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2102         back to fputs only if the former returns zero.
2103
2104 2019-03-07  Tom Tromey  <tom@tromey.com>
2105
2106         * symmisc.c (print_symbol_bcache_statistics): Update.
2107         (print_objfile_statistics): Update.
2108         * symfile.c (allocate_symtab): Update.
2109         * stabsread.c: Don't include bcache.h.
2110         * psymtab.h (struct psymbol_bcache): Don't declare.
2111         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2112         (psymbol_bcache_init, psymbol_bcache_free)
2113         (psymbol_bcache_get_bcache): Don't declare.
2114         * psymtab.c (struct psymbol_bcache): Remove.
2115         (psymtab_storage::psymtab_storage): Update.
2116         (psymtab_storage::~psymtab_storage): Update.
2117         (psymbol_bcache_init, psymbol_bcache_free)
2118         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2119         (add_psymbol_to_bcache): Update.
2120         (allocate_psymtab): Update.
2121         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2122         macro_cache>: No longer pointers.
2123         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2124         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2125         * macrotab.c (macro_bcache): Update.
2126         * macroexp.c: Don't include bcache.h.
2127         * gdbtypes.c (check_types_worklist): Update.
2128         (types_deeply_equal): Remove TRY/CATCH.  Update.
2129         * elfread.c (elf_symtab_read): Update.
2130         * dwarf2read.c: Don't include bcache.h.
2131         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2132         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2133         (print_bcache_statistics, bcache_memory_used): Don't declare.
2134         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2135         methods.  Rename all data members.
2136         * bcache.c (struct bcache): Move to bcache.h.
2137         (bcache::expand_hash_table): Rename from expand_hash_table.
2138         (bcache): Remove.
2139         (bcache::insert): Rename from bcache_full.
2140         (bcache::compare): Rename from bcache_compare.
2141         (bcache_xmalloc): Remove.
2142         (bcache::~bcache): Rename from bcache_xfree.
2143         (bcache::print_statistics): Rename from print_bcache_statistics.
2144         (bcache::memory_used): Rename from bcache_memory_used.
2145
2146 2019-03-07  Pedro Alves  <palves@redhat.com>
2147
2148         * infrun.c (normal_stop): Also check for
2149         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2150
2151 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2152
2153         * f-lang.c (value_from_host_double): Moved to...
2154         * value.c (value_from_host_double): ...here.
2155         * value.h (value_from_host_double): Declare.
2156         * guile/scm-math.c (vlscm_convert_typed_number): Use
2157         value_from_host_double.
2158         (vlscm_convert_number): Likewise.
2159         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2160         * python/py-value.c (convert_value_from_python): Likewise.
2161
2162 2019-03-06  Tom Tromey  <tom@tromey.com>
2163
2164         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2165
2166 2019-03-06  Tom Tromey  <tom@tromey.com>
2167
2168         * utils.h (free_current_contents): Don't declare.
2169         * utils.c (free_current_contents): Remove.
2170
2171 2019-03-06  Tom Tromey  <tom@tromey.com>
2172
2173         * top.c (quit_force): Update.
2174         * main.c (captured_command_loop): Update.
2175         * common/new-op.c (operator new): Update.
2176         * common/common-exceptions.c (struct catcher)
2177         <save_cleanup_chain>: Remove member.
2178         (exceptions_state_mc_init): Update.
2179         (exception_try_scope_entry): Return nullptr.
2180         (exception_try_scope_exit, exception_rethrow)
2181         (throw_exception_sjlj, throw_exception_cxx): Update.
2182         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2183         (all_cleanups, do_cleanups, discard_cleanups)
2184         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2185         (restore_cleanups, restore_final_cleanups): Don't declare.
2186         (do_final_cleanups): Remove parameter.
2187         * common/cleanups.c (cleanup_chain, make_cleanup)
2188         (make_cleanup_dtor, all_cleanups, do_cleanups)
2189         (discard_my_cleanups, discard_cleanups)
2190         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2191         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2192         (null_cleanup): Remove.
2193         (do_final_cleanups): Remove parameter.
2194
2195 2019-03-06  Tom Tromey  <tom@tromey.com>
2196
2197         * remote.c (remote_target::remote_parse_stop_reply): Use
2198         unique_xmalloc_ptr.
2199
2200 2019-03-06  Tom Tromey  <tom@tromey.com>
2201
2202         * stabsread.c (struct stabs_field_info): Rename from field_info.
2203         <list, fnlist>: Add initializers.
2204         <obstack>: New member.
2205         (read_member_functions, read_struct_fields, read_baseclasses):
2206         Allocate on obstack.  Don't use cleanups.
2207         (read_one_struct_field, read_member_functions, read_struct_fields)
2208         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2209         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2210         (read_struct_type): Update.
2211
2212 2019-03-06  Tom Tromey  <tom@tromey.com>
2213
2214         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2215         * common/filestuff.h (make_cleanup_close): Don't declare.
2216         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2217         Remove.
2218
2219 2019-03-06  Tom Tromey  <tom@tromey.com>
2220
2221         * solib-aix.c: Use make_scope_exit.
2222
2223 2019-03-06  Tom Tromey  <tom@tromey.com>
2224
2225         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2226         Use make_scope_exit.
2227
2228 2019-03-06  Tom Tromey  <tom@tromey.com>
2229
2230         * solib-svr4.c (disable_probes_interface): Remove parameter.
2231         (svr4_handle_solib_event): Use make_scope_exit.
2232
2233 2019-03-06  Tom Tromey  <tom@tromey.com>
2234
2235         * remote.c (struct stop_reply_deleter): Remove.
2236         (stop_reply_up): Update.
2237         (struct stop_reply): Derive from notif_event.  Don't typedef.
2238         <regcache>: Now a std::vector.
2239         (stop_reply_xfree): Remove.
2240         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2241         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2242         (remote_target::discard_pending_stop_replies): Use delete.
2243         (remote_target::remote_parse_stop_reply): Update.
2244         (remote_target::process_stop_reply): Update.
2245         * remote-notif.h (struct notif_event): Add virtual destructor.
2246         Remove "dtr" member.
2247         (struct notif_client) <alloc_event>: Return a unique_ptr.
2248         (notif_event_xfree): Don't declare.
2249         (notif_event_up): New typedef.
2250         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2251         (notif_event_xfree, do_notif_event_xfree): Remove.
2252         (remote_notif_state_xfree): Update.
2253
2254 2019-03-06  Tom Tromey  <tom@tromey.com>
2255
2256         * infrun.c (displaced_step_clear_cleanup): Now a
2257         forward_scope_exit type.
2258         (displaced_step_prepare_throw): Update.
2259         (displaced_step_fixup): Update.
2260
2261 2019-03-06  Tom Tromey  <tom@tromey.com>
2262
2263         * inferior.h (class inferior): Update comment.
2264         * gdbthread.h (class thread_info): Update comment.
2265
2266 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2267             Tom Tromey  <tom@tromey.com>
2268
2269         * stabsread.h (struct stab_section_list): Remove.
2270         (coffstab_build_psymtabs): Update.
2271         * dbxread.c (symbuf_sections): Now a std::vector.
2272         (sect_idx): New global.
2273         (fill_symbuf): Update.
2274         (coffstab_build_psymtabs): Change type of stabsects parameter.
2275         Update.
2276         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2277         std::vector.
2278         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2279         (coff_locate_sections): Update.
2280         (coff_symfile_read): Remove cleanups.  Update.
2281         (init_stringtab): Add storage parameter.
2282         (free_stringtab, free_stringtab_cleanup): Remove.
2283         (init_lineno): Add storage parameter.
2284         (free_linetab, free_linetab_cleanup): Remove.
2285
2286 2019-03-06  Pedro Alves  <palves@redhat.com>
2287
2288         * linux-fork.c (fork_info::clobber_regs): Delete.
2289         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2290         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2291         comment.  Adjust.
2292         (scoped_switch_fork_info::scoped_switch_fork_info)
2293         (checkpoint_command, linux_fork_context): Adjust
2294         fork_save_infrun_state calls.
2295
2296 2019-03-06  Pedro Alves  <palves@redhat.com>
2297
2298         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2299         (inf_has_multiple_threads): Return 'bool' and rewrite using
2300         inferior_info::threads().
2301
2302 2019-03-06  Pedro Alves  <palves@redhat.com>
2303
2304         * linux-fork.c: Include <list>.
2305         (fork_list): Now a std::list instance.
2306         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2307         (forks_exist_p, find_last_fork): Adjust.
2308         (new_fork): Delete.
2309         (one_fork_p): New.
2310         (add_fork): Adjust.
2311         (free_fork): Delete, folded into fork_info::~fork_info().
2312         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2313         Adjust.
2314         (init_fork_list): Delete.
2315         (linux_fork_killall, linux_fork_mourn_inferior)
2316         (linux_fork_detach, info_checkpoints_command): Adjust.
2317         (_initialize_linux_fork): No longer call init_fork_list.
2318
2319 2019-03-06  Pedro Alves  <palves@redhat.com>
2320
2321         * linux-fork.c (new_fork): New, split out of ...
2322         (add_fork): ... this.  Return void.  Move "first fork" special
2323         case from here, to ...
2324         (checkpoint_command): ... here.
2325         * linux-linux.h (add_fork): Return void.
2326
2327 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2328
2329         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2330
2331 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2332             Chris January  <chris.january@arm.com>
2333             David Lecomber  <david.lecomber@arm.com>
2334
2335         * f-exp.y: New token, UNOP_INTRINSIC.
2336         (exp): New pattern using UNOP_INTRINSIC token.
2337         (f77_keywords): Add 'abs' keyword.
2338         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2339         (value_from_host_double): New function.
2340         (evaluate_subexp_f): Support UNOP_ABS.
2341
2342 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2343
2344         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2345         types.
2346
2347 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2350         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2351         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2352
2353 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2354
2355         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2356
2357 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2358             Chris January  <chris.january@arm.com>
2359
2360         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2361         * f-exp.y: Define 'KIND' token.
2362         (exp): New pattern for KIND expressions.
2363         (ptype): Handle types with a kind extension.
2364         (direct_abs_decl): Extend to spot kind extensions.
2365         (f77_keywords): Add 'kind' to the list.
2366         (push_kind_type): New function.
2367         (convert_to_kind_type): New function.
2368         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2369         * parse.c (operator_length_standard): Likewise.
2370         * parser-defs.h (enum type_pieces): Add tp_kind.
2371         * std-operator.def: Add UNOP_KIND.
2372
2373 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2374
2375         * f-exp.y (f_parse): Set yydebug.
2376
2377 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2378
2379         * f-lang.c (evaluate_subexp_f): New function.
2380         (exp_descriptor_f): New global.
2381         (f_language_defn): Use exp_descriptor_f instead of
2382         exp_descriptor_standard.
2383
2384 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * f-exp.y (struct token): Add comments.
2387         (dot_ops): Remove uppercase versions and the end marker.
2388         (f77_keywords): Likewise.
2389         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2390         entries in the dot_ops array are case insensitive, and use
2391         strncasecmp to compare strings.  Also some whitespace cleanup in
2392         this area.  Similar for the f77_keywords array, except entries in
2393         this list might be case sensitive.
2394
2395 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * f-exp.y (struct f77_boolean_val): Add comments.
2398         (boolean_values): Remove uppercase versions, and end marker.
2399         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2400         and use strncasecmp to achieve case insensitivity.  Additionally,
2401         perform whitespace cleanup around this code.
2402
2403 2019-03-06  Tom Tromey  <tromey@adacore.com>
2404
2405         * remote-sim.c (gdbsim_target_open): Use result of
2406         gdb_argv::release.
2407
2408 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2409         Dirk Schubert  <dirk.schubert@arm.com>
2410         Chris January  <chris.january@arm.com>
2411
2412         * eval.c (evaluate_subexp_standard): Call Fortran argument
2413         wrapping logic.
2414         * f-lang.c (struct value): A value which can be passed into a
2415         Fortran function call.
2416         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2417         where appropriate.
2418         (struct type): Value ready for a Fortran function call.
2419         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2420         is needed.
2421         * f-lang.h (fortran_argument_convert): Declaration.
2422         (fortran_preserve_arg_pointer): Declaration.
2423         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2424
2425 2019-03-05  Tom Tromey  <tromey@adacore.com>
2426
2427         * python/py-prettyprint.c (print_string_repr): Remove #if.
2428         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2429
2430 2019-03-05  Tom Tromey  <tromey@adacore.com>
2431
2432         * target.c (the_dummy_target): Move later.  Change type to
2433         "dummy_target".
2434         (initialize_targets): Don't initialize the_dummy_target.
2435
2436 2019-03-05  Tom Tromey  <tromey@adacore.com>
2437
2438         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2439         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2440
2441 2019-03-05  Tom Tromey  <tromey@adacore.com>
2442
2443         * windows-nat.c (windows_nat_target::attach)
2444         (windows_nat_target::detach): Don't call gdb_flush.
2445         * valprint.c (generic_val_print, val_print, val_print_string):
2446         Don't call gdb_flush.
2447         * utils.c (defaulted_query): Don't call gdb_flush.
2448         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2449         * target.c (target_announce_detach): Don't call gdb_flush.
2450         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2451         * remote.c (extended_remote_target::attach): Don't call
2452         gdb_flush.
2453         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2454         * printcmd.c (do_examine): Don't call gdb_flush.
2455         (info_display_command): Don't call gdb_flush.
2456         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2457         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2458         * memattr.c (info_mem_command): Don't call gdb_flush.
2459         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2460         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2461         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2462         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2463         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2464         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2465         (gnu_nat_target::detach): Don't call gdb_flush.
2466         * f-valprint.c (f_val_print): Don't call gdb_flush.
2467         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2468         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2469         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2470         gdb_flush.
2471         * c-valprint.c (c_val_print): Don't call gdb_flush.
2472         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2473
2474 2019-03-05  Tom Tromey  <tromey@adacore.com>
2475
2476         * varobj.c (update_dynamic_varobj_children): Update.
2477         (install_default_visualizer): Use reset, not release.
2478         * value.c (set_internalvar): Update.
2479         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2480         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2481         ATTRIBUTE_UNUSED_RESULT.
2482
2483 2019-03-05  Tom Tromey  <tromey@adacore.com>
2484
2485         * remote.c (class scoped_remote_fd) <release>: Add
2486         ATTRIBUTE_UNUSED_RESULT.
2487
2488 2019-03-05  Tom Tromey  <tromey@adacore.com>
2489
2490         * macroexp.c (struct macro_buffer) <release>: Add
2491         ATTRIBUTE_UNUSED_RESULT.
2492
2493 2019-03-05  Tom Tromey  <tromey@adacore.com>
2494
2495         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2496         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2497         ATTRIBUTE_UNUSED_RESULT.
2498
2499 2019-03-05  Tom Tromey  <tromey@adacore.com>
2500
2501         * common/scoped_fd.h (class scoped_fd) <release>: Add
2502         ATTRIBUTE_UNUSED_RESULT.
2503
2504 2019-03-05  Tom Tromey  <tromey@adacore.com>
2505
2506         * parser-defs.h (struct parser_state) <release>: Add
2507         ATTRIBUTE_UNUSED_RESULT.
2508
2509 2019-03-05  Tom Tromey  <tromey@adacore.com>
2510
2511         * utils.h (class gdb_argv) <release>: Add
2512         ATTRIBUTE_UNUSED_RESULT.
2513         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2514
2515 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2516
2517         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2518         for-loop range, to avoid compiler warnings.
2519
2520         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2521         avoid compiler warnings about unused variables.
2522
2523         * NEWS: Mention end of support for native debugging on MS-Windows
2524         before XP.
2525
2526         PR gdb/24292
2527         * common/netstuff.c:
2528         * gdbserver/gdbreplay.c
2529         * gdbserver/remote-utils.c:
2530         * ser-tcp.c:
2531         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2532         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2533         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2534         'getaddrinfo' and 'freeaddrinfo' were not available before
2535         Windows XP, and mingw.org's MinGW headers by default define
2536         _WIN32_WINNT to 0x500.
2537
2538 2019-03-01  Gary Benson <gbenson@redhat.com>
2539
2540         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2541
2542 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2543             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2544
2545         PR gdb/8527
2546         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2547         set_sigint_trap, clear_sigint_trap.
2548
2549 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2550
2551         * target.c (target_detach): Clear the regcache and the
2552         frame cache.
2553
2554 2019-02-27  Pedro Alves  <palves@redhat.com>
2555
2556         * utils.c (set_screen_size): When we cap the height/width sizes,
2557         tweak the corresponding command variable to show "unlimited":
2558
2559 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2560             Pedro Alves  <palves@redhat.com>
2561
2562         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2563         before calling rl_set_screen_size.
2564
2565 2019-02-27  Tom Tromey  <tromey@adacore.com>
2566
2567         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2568         define.
2569         * python/py-value.c: Remove Python 2.4 workaround.
2570         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2571         workaround.
2572         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2573         Python 2.4 workaround.
2574         * python/python-internal.h: Remove Python 2.4 comment.
2575         (Py_ssize_t): Don't define.
2576         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2577         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2578         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2579         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2580         * python/python.c (do_start_initialization): Remove Python 2.4
2581         workaround.
2582         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2583         (print_children): Remove Python 2.4 workaround.
2584         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2585         workaround.
2586         (CHARBUFFERPROC_NAME): Remove.
2587         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2588         Python 2.4 workaround.
2589
2590 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2591
2592         * NEWS: Note minimum Python version.
2593
2594 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2595
2596         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2597         code from these functions.  Remove corresponding ifdefs.  Use
2598         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2599         Remove gotos and target of gotos.
2600         (infpy_search_memory): Likewise.
2601
2602 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2603
2604         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2605         (hppa_gdbarch_init): Don't register deleted functions with
2606         gdbarch.
2607
2608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2609
2610         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2611         (h8300_unwind_sp): Delete.
2612         (h8300_dummy_id): Delete.
2613         (h8300_gdbarch_init): Don't register deleted functions with
2614         gdbarch.
2615
2616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2617
2618         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2619         (ft32_unwind_pc): Delete.
2620         (ft32_unwind_sp): Delete.
2621         (ft32_gdbarch_init): Don't register deleted functions with
2622         gdbarch.
2623
2624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2625
2626         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2627         (frv_unwind_pc): Delete.
2628         (frv_unwind_sp): Delete.
2629         (frv_gdbarch_init): Don't register deleted functions with
2630         gdbarch.
2631
2632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2633
2634         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2635         (riscv_unwind_pc): Delete.
2636         (riscv_unwind_sp): Delete.
2637         (riscv_gdbarch_init): Don't register deleted functions with
2638         gdbarch.
2639
2640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2641
2642         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2643         (csky_unwind_pc): Delete.
2644         (csky_unwind_sp): Delete.
2645         (csky_gdbarch_init): Don't register deleted functions with
2646         gdbarch.
2647
2648 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2649
2650         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2651         (cris_unwind_pc): Delete.
2652         (cris_unwind_sp): Delete.
2653         (cris_gdbarch_init): Don't register deleted functions with
2654         gdbarch.
2655
2656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2659         (bfin_unwind_pc): Delete.
2660         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2661
2662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2663
2664         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2665         (arm_unwind_pc): Delete.
2666         (arm_unwind_sp): Delete.
2667         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2668
2669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2670
2671         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2672         (arc_unwind_pc): Delete.
2673         (arc_unwind_sp): Delete.
2674         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2675
2676 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2677
2678         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2679         (alpha_unwind_pc): Delete.
2680         (alpha_gdbarch_init): Don't register deleted functions with
2681         gdbarch.
2682
2683 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2686         (aarch64_unwind_pc): Delete.
2687         (aarch64_unwind_sp): Delete.
2688         (aarch64_gdbarch_init): Don't register deleted functions with
2689         gdbarch.
2690
2691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * gdbtypes.c (type_align): Don't consider static members when
2694         computing structure alignment.
2695
2696 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2697
2698         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2699         return 0 for other types.
2700         * arch-utils.c (default_type_align): Always return 0.
2701         * gdbarch.h: Regenerate.
2702         * gdbarch.sh (type_align): Extend comment.
2703         * gdbtypes.c (type_align): Add additional comments, always call
2704         gdbarch_type_align before applying the default rules.
2705         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2706         generic code will then apply a suitable default.
2707         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2708         types, return 0 for other types.
2709
2710 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2711
2712         * NEWS: Create a new section for the next release branch.
2713         Rename the section of the current branch, now that it has
2714         been cut.
2715
2716 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2717
2718         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2719         * version.in: Bump version to 8.3.50.DATE-git.
2720
2721 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2722
2723         * aix-thread.c (ptid_cmp): Remove unused variable.
2724         (get_signaled_thread): Likewise.
2725         (store_regs_user_thread): Likewise.
2726         (store_regs_kernel_thread): Likewise.
2727         (fetch_regs_kernel_thread): Remove shadowed variable.
2728
2729 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2730
2731         * features/riscv/32bit-cpu.xml: Add register numbers.
2732         * features/riscv/32bit-fpu.c: Regenerate.
2733         * features/riscv/32bit-fpu.xml: Add register numbers.
2734         * features/riscv/64bit-cpu.xml: Add register numbers.
2735         * features/riscv/64bit-fpu.c: Regenerate.
2736         * features/riscv/64bit-fpu.xml: Add register numbers.
2737
2738 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2739
2740         * NEWS: Mention two argument form of gdb.Value constructor.
2741         * python/py-value.c (convert_buffer_and_type_to_value): New
2742         function.
2743         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2744         Add support for handling an optional second argument.  Call
2745         convert_buffer_and_type_to_value as appropriate.
2746         * python/python-internal.h (Py_buffer_deleter): New struct.
2747         (Py_buffer_up): New typedef.
2748
2749 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2750
2751         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2752         instead of releasing ownership.
2753
2754 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2755
2756         * dwarf2read.c (open_and_init_dwp_file): Call
2757         elf_numsections instead of bfd_count_sections to initialize
2758         dwp_file->num_sections.
2759
2760 2019-02-25  Tom Tromey  <tromey@adacore.com>
2761
2762         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2763
2764 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2765
2766         * gcore.in: Add '--readnever' option when invoking GDB.
2767
2768 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2769
2770         * MAINTAINERS: Update my email address.
2771
2772 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2773
2774         * build-id.c (build_id_to_debug_bfd_1): New function.
2775         (build_id_to_debug_bfd): Look for separate debug file in
2776         sysroot.
2777
2778 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2779
2780         * gdbarch.sh: Update the copyright year range that is placed into
2781         generated files.
2782
2783 2019-02-22  Keith Seitz  <keiths@redhat.com>
2784
2785         PR symtab/23853
2786         * linespec.c (create_sals_line_offset): Search for the default
2787         symtab's filename instead of its fullname.
2788
2789 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2790
2791         * NEWS: Update style defaults.
2792
2793 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2794
2795         * main.c (captured_main_1): Disable styling in batch mode.
2796
2797 2019-02-20  Tom Tromey  <tom@tromey.com>
2798
2799         * symtab.c (symtab_symbol_info): Fix typos.
2800
2801 2019-02-20  Tom Tromey  <tromey@adacore.com>
2802
2803         * findcmd.c (_initialize_mem_search): Use upper case for
2804         metasyntactic variables.
2805
2806 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2807
2808         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2809         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2810
2811 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2812
2813         * top.h (source_file_name): Change to std::string.
2814         * top.c (source_file_name): Likewise.
2815         (command_line_input): Adjust.
2816         * cli/cli-script.c (script_from_file): Adjust.
2817
2818 2019-02-19  Tom Tromey  <tromey@adacore.com>
2819
2820         * ravenscar-thread.c
2821         (ravenscar_thread_target::update_thread_list): Don't call
2822         ada_build_task_list.
2823         * ada-lang.h (ada_build_task_list): Don't declare.
2824         * ada-tasks.c (struct ada_tasks_inferior_data)
2825         <task_list_valid_p>: Now bool.
2826         (read_known_tasks, ada_task_list_changed)
2827         (ada_tasks_invalidate_inferior_data): Update.
2828         (read_known_tasks_array): Return bool.
2829         (read_known_tasks_list): Likewise.
2830         (read_known_tasks): Return void.
2831         (ada_build_task_list): Now static.
2832
2833 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2834
2835         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2836         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2837
2838 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2839
2840         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2841         variant for ada_tasks_pspace_data_handle and
2842         ada_tasks_inferior_data_handle.
2843         (ada_tasks_pspace_data_cleanup): New function.
2844         (ada_tasks_inferior_data_cleanup): New function.
2845
2846 2019-02-17  Tom Tromey  <tom@tromey.com>
2847
2848         * macrotab.h (macro_source_fullname): Return a std::string.
2849         * macrotab.c (macro_include, check_for_redefinition)
2850         (macro_undef, macro_lookup_definition, foreach_macro)
2851         (foreach_macro_in_scope): Update.
2852         (macro_source_fullname): Return a std::string.
2853         * macrocmd.c (show_pp_source_pos): Update.
2854
2855 2019-02-17  Tom Tromey  <tom@tromey.com>
2856
2857         * macrocmd.c (show_pp_source_pos): Style the file names.
2858
2859 2019-02-17  Tom Tromey  <tom@tromey.com>
2860
2861         PR tui/24197:
2862         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2863
2864 2019-02-17  Tom Tromey  <tom@tromey.com>
2865
2866         * ada-lang.c (user_select_syms): Use filtered printing.
2867         * utils.c (wrap_style): New global.
2868         (desired_style): Remove.
2869         (emit_style_escape): Add stream parameter.
2870         (set_output_style, reset_terminal_style, prompt_for_continue):
2871         Update.
2872         (flush_wrap_buffer): Only flush gdb_stdout.
2873         (wrap_here): Set wrap_style.
2874         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2875         treat escape sequences as a character.  Change when wrap buffer is
2876         flushed.
2877         (fputs_styled): Do not set the output style when the default is
2878         requested.
2879         * ui-style.h (struct ui_file_style) <is_default>: New method.
2880         * source.c (print_source_lines_base): Emit escape sequences in one
2881         piece.
2882
2883 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2884
2885         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2886         integers and enumeration types.
2887
2888 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2889
2890         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2891         instead of lookup_symbol_in_language
2892         (do_exact_match): New function.
2893         (ada_get_symbol_name_matcher): Return do_exact_match when
2894         doing a verbatim match.
2895
2896 2019-02-15  Tom Tromey  <tromey@adacore.com>
2897
2898         * ravenscar-thread.c (ravenscar_thread_target::resume)
2899         (ravenscar_thread_target::wait): Special case wildcard requests.
2900
2901 2019-02-15  Tom Tromey  <tromey@adacore.com>
2902
2903         * ravenscar-thread.c (base_ptid): Remove.
2904         (struct ravenscar_thread_target) <close>: New method.
2905         <m_base_ptid>: New member.
2906         <update_inferior_ptid, active_task, task_is_currently_active,
2907         runtime_initialized>: Declare methods.
2908         <ravenscar_thread_target>: Add constructor.
2909         (ravenscar_thread_target::task_is_currently_active)
2910         (ravenscar_thread_target::update_inferior_ptid)
2911         (ravenscar_runtime_initialized): Rename.  Now methods.
2912         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2913         (ravenscar_thread_target::update_thread_list): Update.
2914         (ravenscar_thread_target::active_task): Now method.
2915         (ravenscar_thread_target::store_registers)
2916         (ravenscar_thread_target::prepare_to_store)
2917         (ravenscar_thread_target::prepare_to_store)
2918         (ravenscar_thread_target::mourn_inferior): Update.
2919         (ravenscar_inferior_created): Use "new" to create target.
2920         (ravenscar_thread_target::get_ada_task_ptid): Update.
2921         (_initialize_ravenscar): Don't initialize base_ptid.
2922         (ravenscar_ops): Remove global.
2923
2924 2019-02-15  Tom Tromey  <tromey@adacore.com>
2925
2926         * target.h (push_target): Declare new overload.
2927         * target.c (push_target): New overload, taking an rvalue reference.
2928         * remote.c (remote_target::open_1): Use push_target overload.
2929         * corelow.c (core_target_open): Use push_target overload.
2930
2931 2019-02-15  Tom Tromey  <tromey@adacore.com>
2932
2933         * ravenscar-thread.c (is_ravenscar_task)
2934         (ravenscar_task_is_currently_active): Return bool.
2935         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2936         (_initialize_ravenscar): Remove "(void)".
2937         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2938         Return bool.
2939
2940 2019-02-15  Tom Tromey  <tromey@adacore.com>
2941
2942         * ravenscar-thread.c (ravenscar_runtime_initializer)
2943         (has_ravenscar_runtime, get_running_thread_id)
2944         (ravenscar_thread_target::resume): Fix indentation.
2945
2946 2019-02-15  Tom Tromey  <tromey@adacore.com>
2947
2948         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2949         from ravenscar_arch_ops.
2950         (sparc_ravenscar_ops::fetch_registers)
2951         (sparc_ravenscar_ops::store_registers): Now methods.
2952         (sparc_ravenscar_prepare_to_store): Remove.
2953         (sparc_ravenscar_ops): Redefine.
2954         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2955         methods and destructor.  Remove members.
2956         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2957         (ravenscar_thread_target::store_registers)
2958         (ravenscar_thread_target::prepare_to_store): Update.
2959         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2960         Remove.
2961         (struct ppc_ravenscar_powerpc_ops): Derive from
2962         ravenscar_arch_ops.
2963         (ppc_ravenscar_powerpc_ops::fetch_registers)
2964         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2965         (ppc_ravenscar_powerpc_ops): Redefine.
2966         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2967         (ppc_ravenscar_e500_ops::fetch_registers)
2968         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2969         (ppc_ravenscar_e500_ops): Redefine.
2970         * aarch64-ravenscar-thread.c
2971         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2972         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2973         (aarch64_ravenscar_fetch_registers)
2974         (aarch64_ravenscar_store_registers): Now methods.
2975         (aarch64_ravenscar_ops): Redefine.
2976
2977 2019-02-15  Tom Tromey  <tromey@adacore.com>
2978
2979         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2980         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2981         (ravenscar_thread_target::stopped_by_watchpoint)
2982         (ravenscar_thread_target::stopped_data_address)
2983         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2984
2985 2019-02-15  Tom Tromey  <tromey@adacore.com>
2986
2987         * ravenscar-thread.c: Fix some typos.
2988
2989 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2990             Tom Tromey  <tromey@adacore.com>
2991
2992         * ada-lang.c (ada_exception_sal): Change addr_string to a
2993         std::string.
2994         (create_ada_exception_catchpoint): Update.
2995
2996 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2997             Tom Tromey  <tromey@adacore.com>
2998
2999         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3000         (bp_location_ops): Remove.
3001         (base_breakpoint_allocate_location): Update.
3002         (free_bp_location): Update.
3003         * ada-lang.c (class ada_catchpoint_location)
3004         <ada_catchpoint_location>: Remove ops parameter.
3005         (ada_catchpoint_location_dtor): Remove.
3006         (ada_catchpoint_location_ops): Remove.
3007         (allocate_location_exception): Update.
3008         * breakpoint.h (struct bp_location_ops): Remove.
3009         (class bp_location) <bp_location>: Remove bp_location_ops
3010         parameter.
3011         <~bp_location>: Add destructor.
3012         <ops>: Remove.
3013
3014 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3015             Pedro Alves  <palves@redhat.com>
3016
3017         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3018         'PATH_MAX'.
3019
3020 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3021             Samuel Thibault  <samuel.thibault@gnu.org>
3022             Thomas Schwinge  <thomas@codesourcery.com>
3023
3024         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3025         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3026
3027 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3028
3029         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3030         (check_empty): Use "const char *".
3031
3032         * gnu-nat.c (gnu_nat_target::detach): Instead of
3033         'detach_inferior (pid)' call
3034         'detach_inferior (find_inferior_pid (pid))'.
3035
3036         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3037         'nat/fork-inferior.o'.
3038         * gnu-nat.c: #include "nat/fork-inferior.h".
3039
3040         * gnu-nat.c (gnu_nat_target::detach): Instead of
3041         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3042         * gnu-nat.h: #include "inf-child.h".
3043         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3044         'i386_gnu_nat_target::fetch_registers'.
3045         (gnu_store_registers): Rename/move to
3046         'i386_gnu_nat_target::store_registers'.
3047
3048         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3049         * gnu-nat.h (mach_thread_info): New function.
3050         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3051
3052         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3053
3054 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3055
3056         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3057
3058 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3059
3060         * windows-nat.c (windows_add_thread): Add new parameter
3061         "main_thread_p" with default value set to false.  Update
3062         function documentation as well as all callers.
3063         (windows_delete_thread): Likewise.
3064         (fake_create_process): Update call to windows_add_thread.
3065         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3066         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3067         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3068         call to windows_delete_thread.
3069
3070 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3071
3072         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3073
3074 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3075
3076         * symfile.c (find_separate_debug_file): Use canonical path of
3077         sysroot with child_path instead of gdb_sysroot if it is valid.
3078
3079 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3080
3081         * symfile.c (find_separate_debug_file): Use child_path to
3082         determine if an object file is under a sysroot.
3083
3084 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3085
3086         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3087         unittests/child-path-selftests.c.
3088         * common/pathstuff.c (child_path): New function.
3089         * common/pathstuff.h (child_path): New prototype.
3090         * unittests/child-path-selftests.c: New file.
3091
3092 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3093
3094         * symfile.c (find_separate_debug_file): Look for separate debug
3095         files in debug directories under the sysroot.
3096
3097 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3098
3099         * symtab.h (struct minimal_symbol data_p): New const method.
3100         (struct minimal_symbol text_p): Likewise.
3101         * symtab.c (output_source_filename): Use file name style
3102         to print file name.
3103         (print_symbol_info): Likewise.
3104         (print_msymbol_info): Use address style to print addresses.
3105         Use function name style to print executable text symbols.
3106         (expand_symtab_containing_pc): Use data_p.
3107         (find_pc_sect_compunit_symtab): Likewise.
3108
3109 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3110
3111         * breakpoint.c (describe_other_breakpoints): Use address style
3112         to print addresses.
3113         (say_where): Likewise.
3114
3115 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3116
3117         * ada-typeprint.c (print_func_type): Print function name
3118         style to print function name.
3119         * c-typeprint.c (c_print_type_1): Likewise.
3120
3121 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3122
3123         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3124         for execve.
3125
3126 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3127
3128         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3129         type_stack.
3130
3131 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3132
3133         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3134         TYPE_CODE_REF types.
3135
3136 2019-02-08  Jim Wilson  <jimw@sifive.com>
3137
3138         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3139         (riscv_linux_fregset): New.
3140         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3141
3142 2019-02-07  Tom Tromey  <tom@tromey.com>
3143
3144         * thread.c (thread_cancel_execution_command): Update.
3145         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3146         methods.
3147         (struct thread_fsm_ops): Remove.
3148         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3149         (thread_fsm_should_stop, thread_fsm_return_value)
3150         (thread_fsm_set_finished, thread_fsm_finished_p)
3151         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3152         Don't declare.
3153         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3154         * infrun.c (clear_proceed_status_thread)
3155         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3156         (print_stop_event): Update.
3157         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3158         Add constructor.
3159         (step_command_fsm_ops): Remove.
3160         (new_step_command_fsm): Remove.
3161         (step_1): Update.
3162         (step_command_fsm::should_stop): Rename from
3163         step_command_fsm_should_stop.
3164         (step_command_fsm::clean_up): Rename from
3165         step_command_fsm_clean_up.
3166         (step_command_fsm::do_async_reply_reason): Rename from
3167         step_command_fsm_async_reply_reason.
3168         (struct until_next_fsm): Inherit from thread_fsm.  Add
3169         constructor.
3170         (until_next_fsm_ops): Remove.
3171         (new_until_next_fsm): Remove.
3172         (until_next_fsm::should_stop): Rename from
3173         until_next_fsm_should_stop.
3174         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3175         (until_next_fsm::do_async_reply_reason): Rename from
3176         until_next_fsm_async_reply_reason.
3177         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3178         constructor.  Change type of breakpoint.
3179         (finish_command_fsm_ops): Remove.
3180         (new_finish_command_fsm): Remove.
3181         (finish_command_fsm::should_stop): Rename from
3182         finish_command_fsm_should_stop.
3183         (finish_command_fsm::clean_up): Rename from
3184         finish_command_fsm_clean_up.
3185         (finish_command_fsm::return_value): Rename from
3186         finish_command_fsm_return_value.
3187         (finish_command_fsm::do_async_reply_reason): Rename from
3188         finish_command_fsm_async_reply_reason.
3189         (finish_command): Update.
3190         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3191         Add constructor.
3192         (call_thread_fsm_ops): Remove.
3193         (call_thread_fsm::call_thread_fsm): Rename from
3194         new_call_thread_fsm.
3195         (call_thread_fsm::should_stop): Rename from
3196         call_thread_fsm_should_stop.
3197         (call_thread_fsm::should_notify_stop): Rename from
3198         call_thread_fsm_should_notify_stop.
3199         (run_inferior_call, call_function_by_hand_dummy): Update.
3200         * cli/cli-interp.c (should_print_stop_to_console): Update.
3201         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3202         Add constructor.  Change type of location_breakpoint,
3203         caller_breakpoint.
3204         (until_break_fsm_ops): Remove.
3205         (new_until_break_fsm): Remove.
3206         (until_break_fsm::should_stop): Rename from
3207         until_break_fsm_should_stop.
3208         (until_break_fsm::clean_up): Rename from
3209         until_break_fsm_clean_up.
3210         (until_break_fsm::do_async_reply_reason): Rename from
3211         until_break_fsm_async_reply_reason.
3212         (until_break_command): Update.
3213         * thread-fsm.c: Remove.
3214         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3215
3216 2019-02-07  Tom Tromey  <tom@tromey.com>
3217
3218         * yy-remap.h: Add include guard.
3219         * xtensa-tdep.h: Add include guard.
3220         * xcoffread.h: Rename include guard.
3221         * varobj-iter.h: Add include guard.
3222         * tui/tui.h: Rename include guard.
3223         * tui/tui-winsource.h: Rename include guard.
3224         * tui/tui-wingeneral.h: Rename include guard.
3225         * tui/tui-windata.h: Rename include guard.
3226         * tui/tui-win.h: Rename include guard.
3227         * tui/tui-stack.h: Rename include guard.
3228         * tui/tui-source.h: Rename include guard.
3229         * tui/tui-regs.h: Rename include guard.
3230         * tui/tui-out.h: Rename include guard.
3231         * tui/tui-layout.h: Rename include guard.
3232         * tui/tui-io.h: Rename include guard.
3233         * tui/tui-hooks.h: Rename include guard.
3234         * tui/tui-file.h: Rename include guard.
3235         * tui/tui-disasm.h: Rename include guard.
3236         * tui/tui-data.h: Rename include guard.
3237         * tui/tui-command.h: Rename include guard.
3238         * tic6x-tdep.h: Add include guard.
3239         * target/waitstatus.h: Rename include guard.
3240         * target/wait.h: Rename include guard.
3241         * target/target.h: Rename include guard.
3242         * target/resume.h: Rename include guard.
3243         * target-float.h: Rename include guard.
3244         * stabsread.h: Add include guard.
3245         * rs6000-tdep.h: Add include guard.
3246         * riscv-fbsd-tdep.h: Add include guard.
3247         * regformats/regdef.h: Rename include guard.
3248         * record.h: Rename include guard.
3249         * python/python.h: Rename include guard.
3250         * python/python-internal.h: Rename include guard.
3251         * python/py-stopevent.h: Rename include guard.
3252         * python/py-ref.h: Rename include guard.
3253         * python/py-record.h: Rename include guard.
3254         * python/py-record-full.h: Rename include guard.
3255         * python/py-record-btrace.h: Rename include guard.
3256         * python/py-instruction.h: Rename include guard.
3257         * python/py-events.h: Rename include guard.
3258         * python/py-event.h: Rename include guard.
3259         * procfs.h: Add include guard.
3260         * proc-utils.h: Add include guard.
3261         * p-lang.h: Add include guard.
3262         * or1k-tdep.h: Rename include guard.
3263         * observable.h: Rename include guard.
3264         * nto-tdep.h: Rename include guard.
3265         * nat/x86-linux.h: Rename include guard.
3266         * nat/x86-linux-dregs.h: Rename include guard.
3267         * nat/x86-gcc-cpuid.h: Add include guard.
3268         * nat/x86-dregs.h: Rename include guard.
3269         * nat/x86-cpuid.h: Rename include guard.
3270         * nat/ppc-linux.h: Rename include guard.
3271         * nat/mips-linux-watch.h: Rename include guard.
3272         * nat/linux-waitpid.h: Rename include guard.
3273         * nat/linux-ptrace.h: Rename include guard.
3274         * nat/linux-procfs.h: Rename include guard.
3275         * nat/linux-osdata.h: Rename include guard.
3276         * nat/linux-nat.h: Rename include guard.
3277         * nat/linux-namespaces.h: Rename include guard.
3278         * nat/linux-btrace.h: Rename include guard.
3279         * nat/glibc_thread_db.h: Rename include guard.
3280         * nat/gdb_thread_db.h: Rename include guard.
3281         * nat/gdb_ptrace.h: Rename include guard.
3282         * nat/fork-inferior.h: Rename include guard.
3283         * nat/amd64-linux-siginfo.h: Rename include guard.
3284         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3285         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3286         * nat/aarch64-linux.h: Rename include guard.
3287         * nat/aarch64-linux-hw-point.h: Rename include guard.
3288         * mn10300-tdep.h: Add include guard.
3289         * mips-linux-tdep.h: Add include guard.
3290         * mi/mi-parse.h: Rename include guard.
3291         * mi/mi-out.h: Rename include guard.
3292         * mi/mi-main.h: Rename include guard.
3293         * mi/mi-interp.h: Rename include guard.
3294         * mi/mi-getopt.h: Rename include guard.
3295         * mi/mi-console.h: Rename include guard.
3296         * mi/mi-common.h: Rename include guard.
3297         * mi/mi-cmds.h: Rename include guard.
3298         * mi/mi-cmd-break.h: Rename include guard.
3299         * m2-lang.h: Add include guard.
3300         * location.h: Rename include guard.
3301         * linux-record.h: Rename include guard.
3302         * linux-nat.h: Add include guard.
3303         * linux-fork.h: Add include guard.
3304         * i386-darwin-tdep.h: Rename include guard.
3305         * hppa-linux-offsets.h: Add include guard.
3306         * guile/guile.h: Rename include guard.
3307         * guile/guile-internal.h: Rename include guard.
3308         * gnu-nat.h: Rename include guard.
3309         * gdb-stabs.h: Rename include guard.
3310         * frv-tdep.h: Add include guard.
3311         * f-lang.h: Add include guard.
3312         * event-loop.h: Add include guard.
3313         * darwin-nat.h: Rename include guard.
3314         * cp-abi.h: Rename include guard.
3315         * config/sparc/nm-sol2.h: Rename include guard.
3316         * config/nm-nto.h: Rename include guard.
3317         * config/nm-linux.h: Add include guard.
3318         * config/i386/nm-i386gnu.h: Rename include guard.
3319         * config/djgpp/nl_types.h: Rename include guard.
3320         * config/djgpp/langinfo.h: Rename include guard.
3321         * compile/gcc-cp-plugin.h: Add include guard.
3322         * compile/gcc-c-plugin.h: Add include guard.
3323         * compile/compile.h: Rename include guard.
3324         * compile/compile-object-run.h: Rename include guard.
3325         * compile/compile-object-load.h: Rename include guard.
3326         * compile/compile-internal.h: Rename include guard.
3327         * compile/compile-cplus.h: Rename include guard.
3328         * compile/compile-c.h: Rename include guard.
3329         * common/xml-utils.h: Rename include guard.
3330         * common/x86-xstate.h: Rename include guard.
3331         * common/version.h: Rename include guard.
3332         * common/vec.h: Rename include guard.
3333         * common/tdesc.h: Rename include guard.
3334         * common/selftest.h: Rename include guard.
3335         * common/scoped_restore.h: Rename include guard.
3336         * common/scoped_mmap.h: Rename include guard.
3337         * common/scoped_fd.h: Rename include guard.
3338         * common/safe-iterator.h: Rename include guard.
3339         * common/run-time-clock.h: Rename include guard.
3340         * common/refcounted-object.h: Rename include guard.
3341         * common/queue.h: Rename include guard.
3342         * common/ptid.h: Rename include guard.
3343         * common/print-utils.h: Rename include guard.
3344         * common/preprocessor.h: Rename include guard.
3345         * common/pathstuff.h: Rename include guard.
3346         * common/observable.h: Rename include guard.
3347         * common/netstuff.h: Rename include guard.
3348         * common/job-control.h: Rename include guard.
3349         * common/host-defs.h: Rename include guard.
3350         * common/gdb_wait.h: Rename include guard.
3351         * common/gdb_vecs.h: Rename include guard.
3352         * common/gdb_unlinker.h: Rename include guard.
3353         * common/gdb_unique_ptr.h: Rename include guard.
3354         * common/gdb_tilde_expand.h: Rename include guard.
3355         * common/gdb_sys_time.h: Rename include guard.
3356         * common/gdb_string_view.h: Rename include guard.
3357         * common/gdb_splay_tree.h: Rename include guard.
3358         * common/gdb_setjmp.h: Rename include guard.
3359         * common/gdb_ref_ptr.h: Rename include guard.
3360         * common/gdb_optional.h: Rename include guard.
3361         * common/gdb_locale.h: Rename include guard.
3362         * common/gdb_assert.h: Rename include guard.
3363         * common/filtered-iterator.h: Rename include guard.
3364         * common/filestuff.h: Rename include guard.
3365         * common/fileio.h: Rename include guard.
3366         * common/environ.h: Rename include guard.
3367         * common/common-utils.h: Rename include guard.
3368         * common/common-types.h: Rename include guard.
3369         * common/common-regcache.h: Rename include guard.
3370         * common/common-inferior.h: Rename include guard.
3371         * common/common-gdbthread.h: Rename include guard.
3372         * common/common-exceptions.h: Rename include guard.
3373         * common/common-defs.h: Rename include guard.
3374         * common/common-debug.h: Rename include guard.
3375         * common/cleanups.h: Rename include guard.
3376         * common/buffer.h: Rename include guard.
3377         * common/btrace-common.h: Rename include guard.
3378         * common/break-common.h: Rename include guard.
3379         * cli/cli-utils.h: Rename include guard.
3380         * cli/cli-style.h: Rename include guard.
3381         * cli/cli-setshow.h: Rename include guard.
3382         * cli/cli-script.h: Rename include guard.
3383         * cli/cli-interp.h: Rename include guard.
3384         * cli/cli-decode.h: Rename include guard.
3385         * cli/cli-cmds.h: Rename include guard.
3386         * charset-list.h: Add include guard.
3387         * buildsym-legacy.h: Rename include guard.
3388         * bfin-tdep.h: Add include guard.
3389         * ax.h: Rename include guard.
3390         * arm-linux-tdep.h: Add include guard.
3391         * arm-fbsd-tdep.h: Add include guard.
3392         * arch/xtensa.h: Rename include guard.
3393         * arch/tic6x.h: Add include guard.
3394         * arch/i386.h: Add include guard.
3395         * arch/arm.h: Rename include guard.
3396         * arch/arm-linux.h: Rename include guard.
3397         * arch/arm-get-next-pcs.h: Rename include guard.
3398         * arch/amd64.h: Add include guard.
3399         * arch/aarch64-insn.h: Rename include guard.
3400         * arch-utils.h: Rename include guard.
3401         * annotate.h: Add include guard.
3402         * amd64-darwin-tdep.h: Rename include guard.
3403         * aarch64-linux-tdep.h: Add include guard.
3404         * aarch64-fbsd-tdep.h: Add include guard.
3405         * aarch32-linux-nat.h: Add include guard.
3406
3407 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3408
3409         * macrotab.c (macro_define_internal): New function that
3410         factorizes macro_define_object_internal and macro_define_function
3411         code.
3412         (macro_define_object_internal): Use macro_define_internal.
3413         (macro_define_function): Likewise.
3414
3415 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3416
3417         * macrocmd.c (extract_identifier): Return
3418         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3419         callers.
3420
3421 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3422
3423         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3424
3425 2019-02-05  Tom Tromey  <tom@tromey.com>
3426
3427         * target.c (target_stack::unpush): Move assertion earlier.
3428
3429 2019-01-30  Tom Tromey  <tom@tromey.com>
3430
3431         PR python/23615:
3432         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3433         (gdbpy_parse_and_eval): Likewise.
3434         * python/python-internal.h (gdbpy_allow_threads): New class.
3435
3436 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3437
3438         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3439         (aarch64_fbsd_fpregmap): Move earlier.
3440         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3441         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3442         instead of individual calls to trad_frame_set_reg_addr.
3443         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3444         earlier.
3445         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3446         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3447         instead of individual calls to trad_frame_set_reg_addr.
3448
3449 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3450
3451         * CONTRIBUTE: Replace contribution list with wiki link.
3452
3453 2019-01-25  Tom Tromey  <tom@tromey.com>
3454
3455         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3456
3457 2019-01-25  Tom Tromey  <tom@tromey.com>
3458
3459         * xtensa-linux-nat.c: Fix common/ includes.
3460         * xml-support.h: Fix common/ includes.
3461         * xml-support.c: Fix common/ includes.
3462         * x86-linux-nat.c: Fix common/ includes.
3463         * windows-nat.c: Fix common/ includes.
3464         * varobj.h: Fix common/ includes.
3465         * varobj.c: Fix common/ includes.
3466         * value.c: Fix common/ includes.
3467         * valops.c: Fix common/ includes.
3468         * utils.c: Fix common/ includes.
3469         * unittests/xml-utils-selftests.c: Fix common/ includes.
3470         * unittests/utils-selftests.c: Fix common/ includes.
3471         * unittests/unpack-selftests.c: Fix common/ includes.
3472         * unittests/tracepoint-selftests.c: Fix common/ includes.
3473         * unittests/style-selftests.c: Fix common/ includes.
3474         * unittests/string_view-selftests.c: Fix common/ includes.
3475         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3476         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3477         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3478         * unittests/rsp-low-selftests.c: Fix common/ includes.
3479         * unittests/parse-connection-spec-selftests.c: Fix common/
3480         includes.
3481         * unittests/optional-selftests.c: Fix common/ includes.
3482         * unittests/offset-type-selftests.c: Fix common/ includes.
3483         * unittests/observable-selftests.c: Fix common/ includes.
3484         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3485         * unittests/memrange-selftests.c: Fix common/ includes.
3486         * unittests/memory-map-selftests.c: Fix common/ includes.
3487         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3488         * unittests/function-view-selftests.c: Fix common/ includes.
3489         * unittests/environ-selftests.c: Fix common/ includes.
3490         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3491         * unittests/common-utils-selftests.c: Fix common/ includes.
3492         * unittests/cli-utils-selftests.c: Fix common/ includes.
3493         * unittests/array-view-selftests.c: Fix common/ includes.
3494         * ui-file.c: Fix common/ includes.
3495         * tui/tui-io.c: Fix common/ includes.
3496         * tracepoint.h: Fix common/ includes.
3497         * tracepoint.c: Fix common/ includes.
3498         * tracefile-tfile.c: Fix common/ includes.
3499         * top.h: Fix common/ includes.
3500         * top.c: Fix common/ includes.
3501         * thread.c: Fix common/ includes.
3502         * target/waitstatus.h: Fix common/ includes.
3503         * target/waitstatus.c: Fix common/ includes.
3504         * target.h: Fix common/ includes.
3505         * target.c: Fix common/ includes.
3506         * target-memory.c: Fix common/ includes.
3507         * target-descriptions.c: Fix common/ includes.
3508         * symtab.h: Fix common/ includes.
3509         * symfile.c: Fix common/ includes.
3510         * stap-probe.c: Fix common/ includes.
3511         * spu-linux-nat.c: Fix common/ includes.
3512         * sparc-nat.c: Fix common/ includes.
3513         * source.c: Fix common/ includes.
3514         * solib.c: Fix common/ includes.
3515         * solib-target.c: Fix common/ includes.
3516         * ser-unix.c: Fix common/ includes.
3517         * ser-tcp.c: Fix common/ includes.
3518         * ser-pipe.c: Fix common/ includes.
3519         * ser-base.c: Fix common/ includes.
3520         * selftest-arch.c: Fix common/ includes.
3521         * s12z-tdep.c: Fix common/ includes.
3522         * rust-exp.y: Fix common/ includes.
3523         * rs6000-aix-tdep.c: Fix common/ includes.
3524         * riscv-tdep.c: Fix common/ includes.
3525         * remote.c: Fix common/ includes.
3526         * remote-notif.h: Fix common/ includes.
3527         * remote-fileio.h: Fix common/ includes.
3528         * remote-fileio.c: Fix common/ includes.
3529         * regcache.h: Fix common/ includes.
3530         * regcache.c: Fix common/ includes.
3531         * record-btrace.c: Fix common/ includes.
3532         * python/python.c: Fix common/ includes.
3533         * python/py-type.c: Fix common/ includes.
3534         * python/py-inferior.c: Fix common/ includes.
3535         * progspace.h: Fix common/ includes.
3536         * producer.c: Fix common/ includes.
3537         * procfs.c: Fix common/ includes.
3538         * proc-api.c: Fix common/ includes.
3539         * printcmd.c: Fix common/ includes.
3540         * ppc-linux-nat.c: Fix common/ includes.
3541         * parser-defs.h: Fix common/ includes.
3542         * osdata.c: Fix common/ includes.
3543         * obsd-nat.c: Fix common/ includes.
3544         * nat/x86-linux.c: Fix common/ includes.
3545         * nat/x86-linux-dregs.c: Fix common/ includes.
3546         * nat/x86-dregs.h: Fix common/ includes.
3547         * nat/x86-dregs.c: Fix common/ includes.
3548         * nat/ppc-linux.c: Fix common/ includes.
3549         * nat/mips-linux-watch.h: Fix common/ includes.
3550         * nat/mips-linux-watch.c: Fix common/ includes.
3551         * nat/linux-waitpid.c: Fix common/ includes.
3552         * nat/linux-ptrace.h: Fix common/ includes.
3553         * nat/linux-ptrace.c: Fix common/ includes.
3554         * nat/linux-procfs.c: Fix common/ includes.
3555         * nat/linux-personality.c: Fix common/ includes.
3556         * nat/linux-osdata.c: Fix common/ includes.
3557         * nat/linux-namespaces.c: Fix common/ includes.
3558         * nat/linux-btrace.h: Fix common/ includes.
3559         * nat/linux-btrace.c: Fix common/ includes.
3560         * nat/fork-inferior.c: Fix common/ includes.
3561         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3562         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3563         * nat/aarch64-linux.c: Fix common/ includes.
3564         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3565         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3566         * namespace.h: Fix common/ includes.
3567         * mips-linux-tdep.c: Fix common/ includes.
3568         * minsyms.c: Fix common/ includes.
3569         * mi/mi-parse.h: Fix common/ includes.
3570         * mi/mi-main.c: Fix common/ includes.
3571         * mi/mi-cmd-env.c: Fix common/ includes.
3572         * memrange.h: Fix common/ includes.
3573         * memattr.c: Fix common/ includes.
3574         * maint.h: Fix common/ includes.
3575         * maint.c: Fix common/ includes.
3576         * main.c: Fix common/ includes.
3577         * machoread.c: Fix common/ includes.
3578         * location.c: Fix common/ includes.
3579         * linux-thread-db.c: Fix common/ includes.
3580         * linux-nat.c: Fix common/ includes.
3581         * linux-fork.c: Fix common/ includes.
3582         * inline-frame.c: Fix common/ includes.
3583         * infrun.c: Fix common/ includes.
3584         * inflow.c: Fix common/ includes.
3585         * inferior.h: Fix common/ includes.
3586         * inferior.c: Fix common/ includes.
3587         * infcmd.c: Fix common/ includes.
3588         * inf-ptrace.c: Fix common/ includes.
3589         * inf-child.c: Fix common/ includes.
3590         * ia64-linux-nat.c: Fix common/ includes.
3591         * i387-tdep.c: Fix common/ includes.
3592         * i386-tdep.c: Fix common/ includes.
3593         * i386-linux-tdep.c: Fix common/ includes.
3594         * i386-linux-nat.c: Fix common/ includes.
3595         * i386-go32-tdep.c: Fix common/ includes.
3596         * i386-fbsd-tdep.c: Fix common/ includes.
3597         * i386-fbsd-nat.c: Fix common/ includes.
3598         * guile/scm-type.c: Fix common/ includes.
3599         * guile/guile.c: Fix common/ includes.
3600         * go32-nat.c: Fix common/ includes.
3601         * gnu-nat.c: Fix common/ includes.
3602         * gdbthread.h: Fix common/ includes.
3603         * gdbarch-selftests.c: Fix common/ includes.
3604         * gdb_usleep.c: Fix common/ includes.
3605         * gdb_select.h: Fix common/ includes.
3606         * gdb_bfd.c: Fix common/ includes.
3607         * gcore.c: Fix common/ includes.
3608         * fork-child.c: Fix common/ includes.
3609         * findvar.c: Fix common/ includes.
3610         * fbsd-nat.c: Fix common/ includes.
3611         * event-top.c: Fix common/ includes.
3612         * event-loop.c: Fix common/ includes.
3613         * dwarf2read.c: Fix common/ includes.
3614         * dwarf2loc.c: Fix common/ includes.
3615         * dwarf2-frame.c: Fix common/ includes.
3616         * dwarf-index-cache.c: Fix common/ includes.
3617         * dtrace-probe.c: Fix common/ includes.
3618         * disasm-selftests.c: Fix common/ includes.
3619         * defs.h: Fix common/ includes.
3620         * csky-tdep.c: Fix common/ includes.
3621         * cp-valprint.c: Fix common/ includes.
3622         * cp-support.h: Fix common/ includes.
3623         * cp-support.c: Fix common/ includes.
3624         * corelow.c: Fix common/ includes.
3625         * completer.h: Fix common/ includes.
3626         * completer.c: Fix common/ includes.
3627         * compile/compile.c: Fix common/ includes.
3628         * compile/compile-loc2c.c: Fix common/ includes.
3629         * compile/compile-cplus-types.c: Fix common/ includes.
3630         * compile/compile-cplus-symbols.c: Fix common/ includes.
3631         * command.h: Fix common/ includes.
3632         * cli/cli-dump.c: Fix common/ includes.
3633         * cli/cli-cmds.c: Fix common/ includes.
3634         * charset.c: Fix common/ includes.
3635         * build-id.c: Fix common/ includes.
3636         * btrace.h: Fix common/ includes.
3637         * btrace.c: Fix common/ includes.
3638         * breakpoint.h: Fix common/ includes.
3639         * breakpoint.c: Fix common/ includes.
3640         * ax.h:
3641         (enum agent_op): Fix common/ includes.
3642         * ax-general.c (struct aop_map): Fix common/ includes.
3643         * ax-gdb.c: Fix common/ includes.
3644         * auxv.c: Fix common/ includes.
3645         * auto-load.c: Fix common/ includes.
3646         * arm-tdep.c: Fix common/ includes.
3647         * arch/riscv.c: Fix common/ includes.
3648         * arch/ppc-linux-common.c: Fix common/ includes.
3649         * arch/i386.c: Fix common/ includes.
3650         * arch/arm.c: Fix common/ includes.
3651         * arch/arm-linux.c: Fix common/ includes.
3652         * arch/arm-get-next-pcs.c: Fix common/ includes.
3653         * arch/amd64.c: Fix common/ includes.
3654         * arch/aarch64.c: Fix common/ includes.
3655         * arch/aarch64-insn.c: Fix common/ includes.
3656         * arch-utils.c: Fix common/ includes.
3657         * amd64-windows-tdep.c: Fix common/ includes.
3658         * amd64-tdep.c: Fix common/ includes.
3659         * amd64-sol2-tdep.c: Fix common/ includes.
3660         * amd64-obsd-tdep.c: Fix common/ includes.
3661         * amd64-nbsd-tdep.c: Fix common/ includes.
3662         * amd64-linux-tdep.c: Fix common/ includes.
3663         * amd64-linux-nat.c: Fix common/ includes.
3664         * amd64-fbsd-tdep.c: Fix common/ includes.
3665         * amd64-fbsd-nat.c: Fix common/ includes.
3666         * amd64-dicos-tdep.c: Fix common/ includes.
3667         * amd64-darwin-tdep.c: Fix common/ includes.
3668         * agent.c: Fix common/ includes.
3669         * ada-lang.h: Fix common/ includes.
3670         * ada-lang.c: Fix common/ includes.
3671         * aarch64-tdep.c: Fix common/ includes.
3672
3673 2019-01-25  Tom Tromey  <tom@tromey.com>
3674
3675         * common/create-version.sh: Use common/version.h.
3676
3677 2019-01-24  Pedro Alves  <palves@redhat.com>
3678
3679         * infrun.c (signal_stop, signal_print, signal_program)
3680         (signal_catch, signal_pass): Now arrays instead of pointers.
3681         (update_signals_program_target, do_target_resume)
3682         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3683         * linux-nat.c (linux_nat_target::pass_signals)
3684         (linux_nat_target::create_inferior, linux_nat_target::attach):
3685         Adjust.
3686         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3687         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3688         * procfs.c (procfs_target::pass_signals): Adjust.
3689         * record-full.c (record_full_target::resume): Adjust.
3690         * remote.c (remote_target::pass_signals)
3691         (remote_target::program_signals): Adjust.
3692         * target-debug.h (target_debug_print_signals): Now takes a
3693         gdb::array_view as parameter.  Adjust.
3694         * target.h (target_ops) <pass_signals, program_signals>: Replace
3695         pointer and length parameters with gdb::array_view.
3696         (target_pass_signals, target_program_signals): Likewise.
3697         * target-delegates.c: Regenerate.
3698
3699 2019-01-24  Pedro Alves  <palves@redhat.com>
3700
3701         * common/forward-scope-exit.h
3702         (forward_scope_exit::forward_scope_exit): Pass arguments to
3703         m_bind_function directly, instead of creating a std::bind and
3704         copying that.
3705
3706 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3707
3708         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3709         for static members.
3710         (pass_in_v_vfp_candidate): Likewise.
3711
3712 2019-01-23  Tom Tromey  <tom@tromey.com>
3713             Pedro Alves  <palves@redhat.com>
3714
3715         * regcache.c (class regcache_invalidator): Remove.
3716         (regcache::raw_write): Use make_scope_exit.
3717
3718 2019-01-23  Tom Tromey  <tom@tromey.com>
3719
3720         * ui-out.h (class ui_out_emit_type): Update comment.
3721
3722 2019-01-23  Tom Tromey  <tom@tromey.com>
3723
3724         * infrun.c (fetch_inferior_event): Update comment.
3725
3726 2019-01-23  Tom Tromey  <tom@tromey.com>
3727             Pedro Alves  <palves@redhat.com>
3728
3729         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3730         parameter.
3731         (fetch_inferior_event): Use SCOPE_EXIT.
3732
3733
3734 2019-01-23  Tom Tromey  <tom@tromey.com>
3735             Pedro Alves  <palves@redhat.com>
3736
3737         * infrun.c (disable_thread_events): Delete.
3738         (stop_all_threads): Use SCOPE_EXIT.
3739
3740 2019-01-23  Tom Tromey  <tom@tromey.com>
3741             Pedro Alves  <palves@redhat.com>
3742
3743         * symfile.c: Include forward-scope-exit.h.
3744         (clear_symtab_users_cleanup): Replace forward declaration with
3745         a FORWARD_SCOPE_EXIT.
3746         (syms_from_objfile_1): Use the forward_scope_exit and
3747         gdb::optional instead of cleanup_function.
3748         (reread_symbols): Use the forward_scope_exit instead of
3749         cleanup_function.
3750         (clear_symtab_users_cleanup): Remove function.
3751
3752 2019-01-23  Tom Tromey  <tom@tromey.com>
3753             Pedro Alves  <palves@redhat.com>
3754
3755         * linux-nat.c: Include scope-exit.h.
3756         (cleanup_target_stop): Remove.
3757         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3758         SCOPE_EXIT.
3759
3760 2019-01-23  Tom Tromey  <tom@tromey.com>
3761             Pedro Alves  <palves@redhat.com>
3762
3763         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3764         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3765
3766 2019-01-23  Tom Tromey  <tom@tromey.com>
3767             Andrew Burgess  <andrew.burgess@embecosm.com>
3768             Pedro Alves  <palves@redhat.com>
3769
3770         * infrun.c (fetch_inferior_event): Use scope_exit.
3771         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3772         * top.c (execute_command): Use scope_exit.
3773         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3774         * utils.c (do_bpstat_clear_actions_cleanup)
3775         (make_bpstat_clear_actions_cleanup): Remove.
3776
3777 2019-01-23  Tom Tromey  <tom@tromey.com>
3778             Pedro Alves  <palves@redhat.com>
3779
3780         * infrun.c: Include "common/scope-exit.h"
3781         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3782         (wait_for_inferior): Use SCOPE_EXIT.
3783         (fetch_inferior_event): Use scope_exit.
3784
3785 2019-01-23  Tom Tromey  <tom@tromey.com>
3786             Pedro Alves  <palves@redhat.com>
3787
3788         * breakpoint.c (create_breakpoint): Remove cleanup.
3789
3790 2019-01-23  Tom Tromey  <tom@tromey.com>
3791             Andrew Burgess  <andrew.burgess@embecosm.com>
3792             Pedro Alves  <palves@redhat.com>
3793
3794 2019-01-23  Pedro Alves  <palves@redhat.com>
3795
3796         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3797
3798 2019-01-23  Pedro Alves  <palves@redhat.com>
3799             Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * gdbthread.h: Include "common/forward-scope-exit.h".
3802         (scoped_finish_thread_state): Redefine custom class in terms of
3803         forward_scope_exit.
3804
3805 2019-01-23  Pedro Alves  <palves@redhat.com>
3806             Andrew Burgess  <andrew.burgess@embecosm.com>
3807
3808         * common/forward-scope-exit.h: New file.
3809
3810 2019-01-23  Pedro Alves  <palves@redhat.com>
3811             Andrew Burgess  <andrew.burgess@embecosm.com>
3812             Tom Tromey  <tom@tromey.com>
3813
3814         * common/scope-exit.h: New file.
3815
3816 2019-01-23  Pedro Alves  <palves@redhat.com>
3817
3818         * common/preprocessor.h (ESC): Rename to ...
3819         (ESC_PARENS): ... this.
3820         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3821         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3822
3823 2019-01-23  Tom Tromey  <tom@tromey.com>
3824
3825         * language.h (class scoped_switch_to_sym_language_if_auto):
3826         Initialize m_lang in both cases.
3827
3828 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3829
3830         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3831         with XCNEW.
3832
3833 2019-01-22  Tom Tromey  <tom@tromey.com>
3834
3835         * corelow.c: Do not include sys/file.h.
3836
3837 2019-01-22  Tom Tromey  <tom@tromey.com>
3838
3839         * tui/tui-wingeneral.h: Include gdb_curses.h.
3840
3841 2019-01-22  Tom Tromey  <tom@tromey.com>
3842
3843         * source-cache.h (class source_cache) <get_source_lines,
3844         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3845
3846 2019-01-22  Tom Tromey  <tom@tromey.com>
3847
3848         * remote-fileio.h (struct remote_target): Declare.
3849
3850 2019-01-22  Tom Tromey  <tom@tromey.com>
3851
3852         * python/py-arch.c: Do not include py-ref.h.
3853         * python/py-bpevent.c: Do not include py-ref.h.
3854         * python/py-cmd.c: Do not include py-ref.h.
3855         * python/py-continueevent.c: Do not include py-ref.h.
3856         * python/py-event.h: Do not include py-ref.h.
3857         * python/py-evtregistry.c: Do not include py-ref.h.
3858         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3859         * python/py-frame.c: Do not include py-ref.h.
3860         * python/py-framefilter.c: Do not include py-ref.h.
3861         * python/py-function.c: Do not include py-ref.h.
3862         * python/py-infevents.c: Do not include py-ref.h.
3863         * python/py-linetable.c: Do not include py-ref.h.
3864         * python/py-objfile.c: Do not include py-ref.h.
3865         * python/py-param.c: Do not include py-ref.h.
3866         * python/py-prettyprint.c: Do not include py-ref.h.
3867         * python/py-progspace.c: Do not include py-ref.h.
3868         * python/py-symbol.c: Do not include py-ref.h.
3869         * python/py-symtab.c: Do not include py-ref.h.
3870         * python/py-type.c: Do not include py-ref.h.
3871         * python/py-unwind.c: Do not include py-ref.h.
3872         * python/py-utils.c: Do not include py-ref.h.
3873         * python/py-value.c: Do not include py-ref.h.
3874         * python/py-varobj.c: Do not include py-ref.h.
3875         * python/py-xmethods.c: Do not include py-ref.h.
3876         * python/python.c: Do not include py-ref.h.
3877         * varobj.c: Do not include py-ref.h.
3878
3879 2019-01-22  Tom Tromey  <tom@tromey.com>
3880
3881         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3882         keyword for bcache.
3883
3884 2019-01-22  Tom Tromey  <tom@tromey.com>
3885
3886         * compile/compile-cplus-types.c: Remove a comment by #include.
3887
3888 2019-01-22  Tom Tromey  <tom@tromey.com>
3889
3890         * compile/gcc-c-plugin.h: Include compile-internal.h.
3891
3892 2019-01-22  Tom Tromey  <tom@tromey.com>
3893
3894         * stabsread.c (EXTERN): Do not define.
3895         (symnum, next_symbol_text_func, processing_gcc_compilation)
3896         (within_function, global_sym_chain, global_stabs)
3897         (previous_stab_code, this_object_header_files)
3898         (n_this_object_header_files)
3899         (n_allocated_this_object_header_files): Define.
3900         * stabsread.h (EXTERN): Never define.  Use "extern".
3901
3902 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3903
3904         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3905         history_value.
3906
3907 2019-01-21  Tom Tromey  <tom@tromey.com>
3908
3909         * ui-out.c: Fix includes.
3910         * tui/tui-source.c: Fix includes.
3911         * target.c: Fix includes.
3912         * remote.c: Fix includes.
3913         * regcache.c: Fix includes.
3914         * python/py-block.c: Fix includes.
3915         * printcmd.c: Fix includes.
3916         * or1k-tdep.c: Fix includes.
3917         * mi/mi-main.c: Fix includes.
3918         * m32r-tdep.c: Fix includes.
3919         * csky-tdep.c: Fix includes.
3920         * compile/compile-cplus-types.c: Fix includes.
3921         * cli/cli-interp.c: Fix includes.
3922
3923 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3924
3925         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3926         for padding.
3927
3928 2019-01-16  Tom Tromey  <tom@tromey.com>
3929
3930         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3931         earlier.
3932         (struct objfile) <msymbols_range>: Move from top level.
3933         <msymbols>: New method.
3934         (class objfile_msymbols): Remove.
3935         * symtab.c (default_collect_symbol_completion_matches_break_on):
3936         Update.
3937         * symmisc.c (dump_msymbols): Update.
3938         * stabsread.c (scan_file_globals): Update.
3939         * objc-lang.c (info_selectors_command, info_classes_command)
3940         (find_methods): Update.
3941         * minsyms.c (find_solib_trampoline_target): Update.
3942         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3943         * coffread.c (coff_symfile_read): Update.
3944         * ada-lang.c (ada_lookup_simple_minsym)
3945         (ada_collect_symbol_completion_matches): Update.
3946
3947 2019-01-16  Tom Tromey  <tom@tromey.com>
3948
3949         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3950         type.  Remove no-argument constructor.
3951         <iterator::operator++>: Simplify.
3952         <begin>: Update.
3953         <end>: Use minimal_symbol_count.
3954
3955 2019-01-16  Tom Tromey  <tom@tromey.com>
3956
3957         * objfiles.h (struct objfile) <psymtabs>: New method.
3958         (class objfile_psymtabs): Remove.
3959         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3960         typedef.
3961         <range>: New method.
3962         (require_partial_symbols): Change return type.
3963         * psymtab.c (require_partial_symbols)
3964         (psym_expand_symtabs_matching): Update.
3965         * mdebugread.c (parse_partial_symbols): Update.
3966         * dbxread.c (dbx_end_psymtab): Update.
3967
3968 2019-01-15  Tom Tromey  <tom@tromey.com>
3969
3970         * symtab.c (lookup_objfile_from_block)
3971         (lookup_symbol_in_objfile_symtabs)
3972         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3973         (find_line_symtab, info_sources_command)
3974         (default_collect_symbol_completion_matches_break_on)
3975         (make_source_files_completion_list): Update.
3976         * symmisc.c (print_objfile_statistics, dump_objfile)
3977         (maintenance_print_symbols, maintenance_info_symtabs)
3978         (maintenance_check_symtabs, maintenance_info_line_tables):
3979         Update.
3980         * source.c (select_source_symtab)
3981         (forget_cached_source_info_for_objfile): Update.
3982         * objfiles.h (class objfile_compunits): Remove.
3983         (struct objfile) <compunits_range>: New typedef.
3984         (compunits): New method.
3985         * objfiles.c (objfile_relocate1): Update.
3986         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3987         * maint.c (count_symtabs_and_blocks): Update.
3988         * linespec.c (iterate_over_all_matching_symtabs): Update.
3989         * cp-support.c (add_symbol_overload_list_qualified): Update.
3990         * coffread.c (coff_symtab_read): Update.
3991         * ada-lang.c (add_nonlocal_symbols)
3992         (ada_collect_symbol_completion_matches)
3993         (ada_add_global_exceptions): Update.
3994
3995 2019-01-15  Tom Tromey  <tom@tromey.com>
3996
3997         * progspace.h (program_space) <objfiles_safe_range>: New
3998         typedef.
3999         <objfiles_safe>: New method.
4000         * objfiles.h (class all_objfiles_safe): Remove.
4001         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4002         * jit.c (jit_inferior_exit_hook): Update.
4003
4004 2019-01-17  Tom Tromey  <tom@tromey.com>
4005
4006         * progspace.h (program_space) <objfiles_range>: New typedef.
4007         <objfiles>: New method.
4008         <objfiles_head>: Rename from objfiles.
4009         (object_files): Update.
4010         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4011         * guile/scm-pretty-print.c
4012         (ppscm_find_pretty_printer_from_objfiles): Update.
4013         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4014         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4015         Update.
4016         * python/py-progspace.c (pspy_get_objfiles): Update.
4017         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4018         Update.
4019         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4020         (objfpy_lookup_objfile_by_build_id): Update.
4021         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4022         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4023         Update.
4024         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4025         (expand_symtab_containing_pc, lookup_objfile_from_block)
4026         (lookup_static_symbol, basic_lookup_transparent_type)
4027         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4028         (find_line_symtab, info_sources_command)
4029         (default_collect_symbol_completion_matches_break_on)
4030         (make_source_files_completion_list, find_main_name): Update.
4031         * symmisc.c (print_symbol_bcache_statistics)
4032         (print_objfile_statistics, maintenance_print_symbols)
4033         (maintenance_print_msymbols, maintenance_print_objfiles)
4034         (maintenance_info_symtabs, maintenance_check_symtabs)
4035         (maintenance_expand_symtabs, maintenance_info_line_tables):
4036         Update.
4037         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4038         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4039         (map_overlay_command, unmap_overlay_command)
4040         (simple_overlay_update, expand_symtabs_matching)
4041         (map_symbol_filenames): Update.
4042         * symfile-debug.c (set_debug_symfile): Update.
4043         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4044         Update.
4045         * source.c (select_source_symtab, forget_cached_source_info):
4046         Update.
4047         * solib.c (solib_read_symbols): Update.
4048         * solib-spu.c (append_ocl_sos): Update.
4049         * psymtab.c (maintenance_print_psymbols)
4050         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4051         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4052         * printcmd.c (info_symbol_command): Update.
4053         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4054         Update.
4055         * objfiles.h (class all_objfiles): Remove.
4056         * objfiles.c (have_partial_symbols, have_full_symbols)
4057         (have_minimal_symbols, qsort_cmp, update_section_map)
4058         (shared_objfile_contains_address_p)
4059         (default_iterate_over_objfiles_in_search_order): Update.
4060         * objc-lang.c (info_selectors_command, info_classes_command)
4061         (find_methods): Update.
4062         * minsyms.c (find_solib_trampoline_target): Update.
4063         * maint.c (maintenance_info_sections)
4064         (maintenance_translate_address, count_symtabs_and_blocks):
4065         Update.
4066         * main.c (captured_main_1): Update.
4067         * linux-thread-db.c (try_thread_db_load_from_pdir)
4068         (has_libpthread): Update.
4069         * linespec.c (iterate_over_all_matching_symtabs)
4070         (search_minsyms_for_name): Update.
4071         * jit.c (jit_find_objf_with_entry_addr): Update.
4072         * hppa-tdep.c (find_unwind_entry)
4073         (hppa_lookup_stub_minimal_symbol): Update.
4074         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4075         Update.
4076         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4077         (elf_gnu_ifunc_resolve_by_got): Update.
4078         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4079         * dwarf-index-write.c (save_gdb_index_command): Update.
4080         * cp-support.c (add_symbol_overload_list_qualified): Update.
4081         * breakpoint.c (create_overlay_event_breakpoint)
4082         (create_longjmp_master_breakpoint)
4083         (create_std_terminate_master_breakpoint)
4084         (create_exception_master_breakpoint): Update.
4085         * blockframe.c (find_pc_partial_function): Update.
4086         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4087         (ada_collect_symbol_completion_matches)
4088         (ada_add_global_exceptions): Update.
4089
4090 2019-01-17  Tom Tromey  <tom@tromey.com>
4091
4092         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4093         declare VEC.
4094         (solib_target_parse_libraries): Change return type.
4095         (library_list_start_segment, library_list_start_section)
4096         (library_list_end_library, library_list_start_library); Update.
4097         (solib_target_free_library_list): Remove.
4098         (solib_target_parse_libraries): Remove cleanup.  Change return
4099         type.
4100         (solib_target_current_sos): Update.
4101
4102 2019-01-17  Tom Tromey  <tromey@bapiya>
4103
4104         * valprint.c: Replace "the the" with "the".
4105         * symtab.c: Replace "the the" with "the".
4106         * solib.c: Replace "the the" with "the".
4107         * solib-dsbt.c: Replace "the the" with "the".
4108         * linespec.c: Replace "the the" with "the".
4109         * dwarf2loc.h: Replace "the the" with "the".
4110         * amd64-windows-tdep.c: Replace "the the" with "the".
4111         * aarch64-tdep.c: Replace "the the" with "the".
4112
4113 2019-01-16  Keith Seitz  <keiths@redhat.com>
4114
4115         PR gdb/23773
4116         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4117         <builder>: Rename to ..
4118         <m_builder>: ... this and make private.
4119         (dwarf2_cu::get_builder): New method.  Change all users of
4120         `builder' to use this method.
4121         (dwarf2_start_symtab): Move to ...
4122         (dwarf2_cu::start_symtab): ... here.  Update all callers
4123         (setup_type_unit_groups): Move to ...
4124         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4125         callers.
4126         (dwarf2_cu::reset_builder): New method.
4127         (process_full_compunit, process_full_type_unit): Use
4128         dwarf2_cu::reset_builder.
4129         (follow_die_offset): Record the ancestor CU if it is different
4130         from the followed DIE's CU.
4131         (follow_die_sig_1): Likewise.
4132
4133 2019-01-15  Tom Tromey  <tom@tromey.com>
4134
4135         * remote.c (class remote_state) <buf>: Now a char_vector.
4136         <buf_size>: Remove.
4137         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4138         parameter.
4139         (remote_target::getpkt_or_notif_sane_1)
4140         (remote_target::getpkt_sane)
4141         (remote_target::getpkt_or_notif_sane): Likewise.
4142         (class remote_target) <putpkt>: New overload.
4143         (remote_target::read_frame): Change type of "buf_p".  Remove
4144         sizeof_p parameter.
4145         (packet_ok): New overload.
4146         (packet_check_result): New overload.
4147         Update all uses.
4148
4149 2019-01-14  Tom Tromey  <tom@tromey.com>
4150
4151         * remote-notif.c (handle_notification, remote_notif_ack)
4152         (remote_notif_parse): Make "buf" const.
4153         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4154         const.
4155         (remote_notif_parse, remote_notif_ack, handle_notification):
4156         Likewise.
4157         * remote.c (remote_notif_stop_parse): Make "buf" const.
4158         (remote_target::remote_parse_stop_reply): Make "buf" const.
4159         (remote_notif_stop_ack): Make "buf" const.
4160
4161 2019-01-14  Tom Tromey  <tom@tromey.com>
4162
4163         * remote.c (remote_console_output): Make parameter const.
4164
4165 2019-01-14  Tom Tromey  <tom@tromey.com>
4166
4167         * target-debug.h (target_debug_print_signals): Constify.
4168         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4169         * procfs.c (procfs_target::pass_signals): Update.
4170         * linux-nat.c (linux_nat_target::pass_signals): Update.
4171         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4172         * target-delegates.c: Rebuild.
4173         * remote.c (remote_target::program_signals): Update.
4174         (remote_target::pass_signals): Update.
4175         * target.c (target_pass_signals): Constify argument.
4176         (target_program_signals): Likewise.
4177         * target.h (struct target_ops) <pass_signals, program_signals>:
4178         Constify argument.
4179         (target_pass_signals, target_program_signals): Constify argument.
4180
4181 2019-01-14  Tom Tromey  <tom@tromey.com>
4182
4183         PR tui/28819:
4184         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4185
4186 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4187
4188         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4189         field.
4190         * rs6000-tdep.c: Include reggroups.h.
4191         (IS_V_ALIAS_PSEUDOREG): Define.
4192         (rs6000_register_name): Return names for the "vX" aliases.
4193         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4194         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4195         aliases.  Call default_register_reggroup_p for all other
4196         pseudo-registers.
4197         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4198         New functions.
4199         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4200         Handle "vX" aliases.
4201         (v_alias_pseudo_register_collect): New function.
4202         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4203         (rs6000_gdbarch_init): Initialize "vX" aliases as
4204         pseudo-registers.  Restore registration of
4205         rs6000_pseudo_register_reggroup_p with
4206         set_tdesc_pseudo_register_reggroup_p.
4207
4208 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4209
4210         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4211         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4212         set_gdbarch_num_pseudo_regs.
4213
4214 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4215
4216         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4217         Remove arg prefixname, add do_set and do_show.
4218         Add member functions set_list and show_list.
4219         * cli/cli-style.c (class cli_style_option): Update accordingly.
4220         (style_set_list): Move to file scope.
4221         (style_show_list): Likewise.
4222         (set_style): Call help_list.
4223         (show_style): Call cmd_show_list.
4224         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4225         Update to use the new macro.
4226
4227 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4228
4229         * ada-lang.c (_initialize_ada_language): Expand the help text
4230         for the "catch exception" command.
4231
4232 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4233
4234         * symtab.c (matching_obj_sections): Initialize obj,
4235         declare it closer to its usage.
4236
4237 2019-01-10  Tom Tromey  <tom@tromey.com>
4238
4239         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4240         (basic_inf_threads_range): Remove.
4241         (inf_threads_range, inf_non_exited_threads_range)
4242         (safe_inf_threads_range): Use next_adapter.
4243
4244 2019-01-10  Keith Seitz  <keiths@redhat.com>
4245
4246         PR gdb/23712
4247         PR symtab/23010
4248         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4249         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4250
4251 2019-01-10  Keith Seitz  <keiths@redhat.com>
4252
4253         PR gdb/23712
4254         PR symtab/23010
4255         * dictionary.c (pending_to_vector): Remove.
4256         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4257         Remove _1 suffix, replacing functions of the same name.  Update
4258         all callers.
4259         (dict_create_hashed, dict_create_hashed_expandable)
4260         (dict_create_linear, dict_create_linear_expandable, dict_free)
4261         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4262         Make functions static.
4263
4264 2019-01-10  Keith Seitz  <keiths@redhat.com>
4265
4266         PR gdb/23712
4267         PR symtab/23010
4268         * dictionary.h (struct dictionary): Replace declaration with
4269         multidictionary.
4270         (dict_create_hashed, dict_create_hashed_expandable)
4271         (dict_create_linear, dict_create_linear_expandable)
4272         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4273         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4274         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4275         taking multidictionary argument.
4276         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4277         * block.h (struct block) <dict>: Change to multidictionary
4278         and rename `multidict'.
4279         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4280         symmisc.c: Update all dictionary references to multidictionary.
4281
4282 2019-01-10  Keith Seitz  <keiths@redhat.com>
4283
4284         PR gdb/23712
4285         PR symtab/23010
4286         * dictionary.c: Include unordered_map.
4287         (pending_to_vector): New function.
4288         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4289         Rewrite the non-"_1" functions to take vector instead
4290         of linked list.
4291         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4292         "new" _1 versions of the same name.
4293         (multidictionary): Define.
4294         (std::hash<enum language): New definition.
4295         (collate_pending_symbols_by_language, mdict_create_hashed)
4296         (mdict_create_hashed_expandable, mdict_create_linear)
4297         (mdict_create_linear_expandable, mdict_free)
4298         (find_language_dictionary, create_new_language_dictionary)
4299         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4300         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4301         (mdict_size, mdict_empty): New functions.
4302         * dictionary.h (mdict_iterator): Define.
4303
4304 2019-01-10  Pedro Alves  <palves@redhat.com>
4305
4306         * breakpoint.c (read_uploaded_action)
4307         (create_tracepoint_from_upload): Adjust to use
4308         gdb::unique_xmalloc_ptr.
4309         * ctf.c (ctf_write_uploaded_tp):
4310         (SET_ARRAY_FIELD): Use emplace_back.
4311         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4312         * tracefile-tfile.c (tfile_write_uploaded_tp):
4313         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4314         gdb::unique_xmalloc_ptr.
4315         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4316         at_string, cond_string, cmd_strings>: Replace char pointers
4317         with gdb::unique_xmalloc_ptr.
4318
4319 2019-01-10  Pedro Alves  <palves@redhat.com>
4320
4321         * solib-target.c (library_list_start_library): Don't xstrdup name.
4322
4323 2019-01-10  Pedro Alves  <palves@redhat.com>
4324
4325         * mdebugread.c (parse_partial_symbols): Use
4326         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4327
4328 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4329
4330         * linux-fork.c (scoped_switch_fork_info)
4331         <~scoped_switch_fork_info>: Fix incorrect variable name.
4332
4333 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4334
4335         * linux-fork.c (scoped_switch_fork_info)
4336         <scoped_switch_fork_info>: Make explicit.
4337         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4338
4339 2019-01-10  Tom Tromey  <tom@tromey.com>
4340
4341         * objfiles.h (objfile::reset_psymtabs): Update.
4342         * objfiles.c (objfile::objfile): Update.
4343         * psymtab.h (psymtab_storage::obstack): Update.
4344         (psymtab_storage::m_obstack): Use gdb::optional.
4345         (class psymtab_storage): Update comment.  Remove objfile
4346         parameter.
4347         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4348
4349 2019-01-10  Tom Tromey  <tom@tromey.com>
4350
4351         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4352         <free_psymtabs>: Now private.
4353         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4354         (allocate_psymtab): Use new method.
4355
4356 2019-01-10  Tom Tromey  <tom@tromey.com>
4357
4358         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4359         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4360         * mdebugread.c (parse_partial_symbols): Use
4361         allocate_dependencies.
4362         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4363         allocate_dependencies.
4364         (process_psymtab_comp_unit_reader)
4365         (build_type_psymtab_dependencies): Likewise.
4366         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4367
4368 2019-01-10  Tom Tromey  <tom@tromey.com>
4369
4370         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4371         PSYMBOL_SET_LANGUAGE.
4372         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4373
4374 2019-01-10  Tom Tromey  <tom@tromey.com>
4375
4376         * psymtab.h (psymtab_storage::obstack): New method.
4377         <m_obstack>: Rename from obstack; now private.
4378         * psymtab.c (psymtab_storage): Update.
4379         * dwarf2read.c (create_addrmap_from_index)
4380         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4381         Update.
4382
4383 2019-01-10  Tom Tromey  <tom@tromey.com>
4384
4385         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4386         * objfiles.h (objfile::reset_psymtabs): New method.
4387
4388 2019-01-10  Tom Tromey  <tom@tromey.com>
4389
4390         * symmisc.c (print_symbol_bcache_statistics): Update.
4391         (print_objfile_statistics): Update.
4392         * symfile.c (reread_symbols): Update.
4393         * psymtab.h (class psymtab_storage): New.
4394         * psymtab.c (psymtab_storage): New constructor.
4395         (~psymtab_storage): New destructor.
4396         (require_partial_symbols): Update.
4397         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4398         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4399         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4400         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4401         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4402         (start_psymtab_common, end_psymtab_common)
4403         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4404         (allocate_psymtab): Update.
4405         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4406         Update.
4407         (dump_psymtab_addrmap, maintenance_print_psymbols)
4408         (maintenance_check_psymtabs): Update.
4409         (class objfile_psymtabs): Move to objfiles.h.
4410         * psympriv.h (discard_psymtab): Now inline.
4411         (psymtab_discarder::psymtab_discarder): Update.
4412         (psymtab_discarder::~psymtab_discarder): Update.
4413         (ALL_OBJFILE_PSYMTABS): Rewrite.
4414         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4415         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4416         Remove fields.
4417         <partial_symtabs>: New field.
4418         (class objfile_psymtabs): Move from psymtab.h.  Update.
4419         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4420         psymbol_cache.
4421         (objfile::~objfile): Don't destroy psymbol_cache.
4422         * mdebugread.c (parse_partial_symbols): Update.
4423         * dwarf2read.c (create_addrmap_from_index)
4424         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4425         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4426         (add_partial_subprogram, dwarf2_ranges_read): Update.
4427         * dwarf-index-write.c (write_address_map)
4428         (write_one_signatured_type, recursively_write_psymbols)
4429         (class debug_names, class debug_names, write_psymtabs_to_index):
4430         Update.
4431
4432 2019-01-10  Tom Tromey  <tom@tromey.com>
4433
4434         * symtab.h (SYMBOL_SET_NAMES): Update.
4435         (symbol_set_names): Update.
4436         (MSYMBOL_SET_NAMES): Update.
4437         * symtab.c (symbol_set_names): Change argument to be an
4438         objfile_per_bfd_storage.
4439         * psymtab.c (add_psymbol_to_bcache): Update.
4440         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4441
4442 2019-01-10  Tom Tromey  <tom@tromey.com>
4443
4444         * symtab.c (create_demangled_names_hash): Change argument to be an
4445         objfile_per_bfd_storage.
4446         (symbol_set_names): Update.
4447
4448 2019-01-10  Tom Tromey  <tom@tromey.com>
4449
4450         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4451         init_psymbol_list.
4452         * psymtab.c (init_psymbol_list): Do nothing if already called.
4453         * psympriv.h (init_psymbol_list): Add comment.
4454         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4455         init_psymbol_list.
4456         * dbxread.c (dbx_symfile_read): Unconditionally call
4457         init_psymbol_list.
4458
4459 2019-01-10  Tom Tromey  <tom@tromey.com>
4460
4461         * xcoffread.c (scan_xcoff_symtab): Update.
4462         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4463         "where".
4464         * mdebugread.c (parse_partial_symbols)
4465         (handle_psymbol_enumerators): Update.
4466         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4467         * dbxread.c (read_dbx_symtab): Update.
4468         * psympriv.h (psymbol_placement): New enum.
4469         (add_psymbol_to_list): Update.
4470
4471 2019-01-10  Tom Tromey  <tom@tromey.com>
4472
4473         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4474         static_psymbols parameters.
4475         (scan_xcoff_symtab): Update.
4476         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4477         static_psymbols parameters.
4478         * psympriv.h (start_psymtab_common): Update.
4479         * mdebugread.c (parse_partial_symbols): Update.
4480         * dwarf2read.c (create_partial_symtab): Update.
4481         * dbxread.c (read_dbx_symtab): Update.
4482         (start_psymtab): Remove global_psymbols and static_psymbols
4483         parameters.
4484
4485 2019-01-10  Tom Tromey  <tom@tromey.com>
4486
4487         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4488         * psymtab.c (allocate_psymtab): Add comment.
4489         * psympriv.h (allocate_psymtab): Add comment.
4490         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4491         initializations.
4492         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4493
4494 2019-01-10  Tom Tromey  <tom@tromey.com>
4495
4496         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4497         Don't declare.
4498         * mipsread.c: Include mdebugread.h.
4499         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4500         Declare.
4501         * elfread.c: Include mdebugread.h.
4502
4503 2019-01-09  Tom Tromey  <tom@tromey.com>
4504
4505         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4506         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4507         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4508         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4509         (psym_lookup_symbol, psym_find_last_source_symtab)
4510         (psym_forget_cached_source_info, psym_print_stats)
4511         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4512         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4513         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4514         (psym_find_compunit_symtab_by_address)
4515         (maintenance_print_psymbols, maintenance_info_psymtabs)
4516         (maintenance_check_psymtabs): Use ranged for.
4517         * psymtab.h (class objfile_psymtabs): New.
4518         (require_partial_symbols): Return objfile_psymtabs.
4519         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4520
4521 2019-01-09  Tom Tromey  <tom@tromey.com>
4522
4523         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4524         (find_pc_mapped_section, list_overlays_command)
4525         (map_overlay_command, unmap_overlay_command)
4526         (simple_overlay_update): Use all_objfiles.
4527         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4528         * printcmd.c (info_symbol_command): Use all_objfiles.
4529         * objfiles.h (ALL_OBJSECTIONS): Remove.
4530         * maint.c (maintenance_translate_address): Use all_objfiles.
4531         * gcore.c (gcore_create_callback): Use all_objfiles.
4532         (objfile_find_memory_regions): Likewise.
4533
4534 2019-01-09  Tom Tromey  <tom@tromey.com>
4535
4536         * symtab.c (find_line_symtab, info_sources_command)
4537         (make_source_files_completion_list): Use objfile_compunits.
4538         * source.c (select_source_symtab): Use objfile_compunits.
4539         * objfiles.h (struct objfile): Update comment.
4540         (ALL_OBJFILES): Remove.
4541         (ALL_FILETABS): Remove.
4542         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4543         objfile_compunits.
4544
4545 2019-01-09  Tom Tromey  <tom@tromey.com>
4546
4547         * symmisc.c (print_objfile_statistics, dump_objfile)
4548         (maintenance_print_symbols): Use compunit_filetabs.
4549         * source.c (forget_cached_source_info_for_objfile): Use
4550         compunit_filetabs.
4551         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4552         (ALL_FILETABS): Use compunit_filetabs.
4553         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4554         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4555
4556 2019-01-09  Tom Tromey  <tom@tromey.com>
4557
4558         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4559         (compunit_filetabs): New.
4560         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4561         compunit_filetabs.
4562         (info_sources_command, make_source_files_completion_list): Remove
4563         declaration.
4564         * symmisc.c (print_objfile_statistics, dump_objfile)
4565         (maintenance_print_symbols): Remove declaration.
4566         (maintenance_info_symtabs): Use compunit_filetabs.
4567         (maintenance_info_line_tables): Likewise.
4568         * source.c (select_source_symtab): Change local variable name.
4569         (forget_cached_source_info_for_objfile): Remove declaration.
4570         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4571         * objfiles.c (objfile_relocate1): Remove declaration.
4572         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4573         declaration.
4574         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4575         * coffread.c (coff_symtab_read): Remove declaration.
4576         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4577         compunit_filetabs.
4578
4579 2019-01-09  Tom Tromey  <tom@tromey.com>
4580
4581         * symtab.c (lookup_objfile_from_block)
4582         (find_pc_sect_compunit_symtab, search_symbols)
4583         (default_collect_symbol_completion_matches_break_on): Use
4584         objfile_compunits.
4585         * objfiles.h (ALL_COMPUNITS): Remove.
4586         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4587         * cp-support.c (add_symbol_overload_list_qualified): Use
4588         objfile_compunits.
4589         * ada-lang.c (ada_collect_symbol_completion_matches)
4590         (ada_add_global_exceptions): Use objfile_compunits.
4591
4592 2019-01-09  Tom Tromey  <tom@tromey.com>
4593
4594         * source.c (select_source_symtab)
4595         (forget_cached_source_info_for_objfile): Remove declaration.
4596         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4597         declaration.
4598         * maint.c (count_symtabs_and_blocks): Remove declaration.
4599         * cp-support.c (add_symbol_overload_list_qualified): Remove
4600         declaration.
4601         * coffread.c (coff_symtab_read): Remove declaration.
4602         * symtab.c (lookup_symbol_in_objfile_symtabs)
4603         (basic_lookup_transparent_type_1): Use objfile_compunits.
4604         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4605         (info_sources_command, search_symbols)
4606         (default_collect_symbol_completion_matches_break_on)
4607         (make_source_files_completion_list): Remove declaration.
4608         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4609         (ada_collect_symbol_completion_matches)
4610         (ada_add_global_exceptions): Remove declaration.
4611         * linespec.c (iterate_over_all_matching_symtabs): Use
4612         objfile_compunits.
4613         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4614         (class objfile_compunits): New.
4615         (ALL_COMPUNITS): Use objfile_compunits.
4616         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4617         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4618         objfile_compunits.
4619         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4620
4621 2019-01-09  Tom Tromey  <tom@tromey.com>
4622
4623         * symtab.c (search_symbols)
4624         (default_collect_symbol_completion_matches_break_on): Use
4625         objfile_msymbols.
4626         * ada-lang.c (ada_lookup_simple_minsym)
4627         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4628         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4629         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4630         objfile_msymbols.
4631         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4632         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4633         * objc-lang.c (find_methods): Use objfile_msymbols.
4634         (info_selectors_command, info_classes_command): Likewise.
4635         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4636         * objfiles.h (class objfile_msymbols): New.
4637         (ALL_OBJFILE_MSYMBOLS): Remove.
4638         (ALL_MSYMBOLS): Remove.
4639
4640 2019-01-09  Tom Tromey  <tom@tromey.com>
4641
4642         * common/next-iterator.h (next_adapter): Add Iterator template
4643         parameter.
4644         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4645         (class all_objfiles_safe): New.
4646         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4647         * objfiles.c (put_objfile_before): Update comment.
4648         (add_separate_debug_objfile): Likewise.
4649         (free_all_objfiles): Use all_objfiles_safe.
4650         (objfile_purge_solibs): Likewise.
4651
4652 2019-01-09  Tom Tromey  <tom@tromey.com>
4653
4654         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4655         (expand_symtab_containing_pc, lookup_static_symbol)
4656         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4657         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4658         all_objfiles.
4659         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4660         * breakpoint.c (create_overlay_event_breakpoint)
4661         (create_longjmp_master_breakpoint)
4662         (create_std_terminate_master_breakpoint)
4663         (create_exception_master_breakpoint): Use all_objfiles.
4664         * linux-thread-db.c (try_thread_db_load_from_pdir)
4665         (has_libpthread): Use all_objfiles.
4666         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4667         * linespec.c (iterate_over_all_matching_symtabs)
4668         (search_minsyms_for_name): Use all_objfiles.
4669         * maint.c (maintenance_info_sections): Use all_objfiles.
4670         * main.c (captured_main_1): Use all_objfiles.
4671         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4672         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4673         * guile/scm-pretty-print.c
4674         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4675         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4676         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4677         (maintenance_print_msymbols): Use all_objfiles.
4678         * source.c (select_source_symtab): Use all_objfiles.
4679         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4680         * symfile.c (remove_symbol_file_command)
4681         (expand_symtabs_matching, map_symbol_filenames): Use
4682         all_objfiles.
4683         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4684         all_objfiles.
4685         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4686         * objc-lang.c (find_methods): Use all_objfiles.
4687         * objfiles.c (have_partial_symbols, have_full_symbols)
4688         (have_minimal_symbols, qsort_cmp)
4689         (default_iterate_over_objfiles_in_search_order): Use
4690         all_objfiles.
4691         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4692         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4693         (maintenance_check_psymtabs): Use all_objfiles.
4694         (ALL_PSYMTABS): Remove.
4695         * compile/compile-object-run.c (do_module_cleanup): Use
4696         all_objfiles.
4697         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4698         * cp-support.c (add_symbol_overload_list_qualified): Use
4699         all_objfiles.
4700         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4701         Use all_objfiles.
4702         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4703         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4704         all_objfiles.
4705         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4706         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4707         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4708         Uses all_objfiles.
4709         * solib.c (solib_read_symbols): Use all_objfiles
4710
4711 2019-01-09  Tom Tromey  <tom@tromey.com>
4712
4713         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4714         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4715         all_objfiles.
4716         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4717         * symmisc.c (print_symbol_bcache_statistics)
4718         (print_objfile_statistics, maintenance_print_objfiles)
4719         (maintenance_info_symtabs, maintenance_check_symtabs)
4720         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4721         all_objfiles.
4722         * source.c (forget_cached_source_info): Use all_objfiles.
4723         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4724         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4725         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4726         * objfiles.c (update_section_map): Use all_objfiles.
4727         (shared_objfile_contains_address_p): Likewise.
4728         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4729         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4730
4731 2019-01-09  Tom Tromey  <tom@tromey.com>
4732
4733         * common/next-iterator.h: New file.
4734         * objfiles.h (class all_objfiles): New.
4735         (struct objfile_iterator): New.
4736
4737 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4738
4739         * NEWS: Move the description of the changed "frame", "select-frame",
4740          and "info frame" commands to the Changed commands section.
4741
4742 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4743
4744         * gdbtypes.c (check_stub_method_group): Remove handling of old
4745         mangling schemes.
4746         * linespec.c (find_methods): Likewise.
4747         * stabsread.c (read_member_functions): Likewise.
4748         * valops.c (search_struct_method): Likewise.
4749         (value_struct_elt_for_reference): Likewise.
4750         * NEWS: Mention this change.
4751
4752 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4753
4754         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4755         print_source_lines.
4756         * source.c (print_source_lines_base): Update line number check.
4757         (print_source_lines): New function.
4758         (source_lines_range::source_lines_range): New function.
4759         * source.h (class source_lines_range): New class.
4760         (print_source_lines): New declaration.
4761
4762 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4763
4764         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4765
4766 2019-01-08  Tom Tromey  <tom@tromey.com>
4767             Simon Marchi  <simon.marchi@ericsson.com>
4768
4769         PR gdb/24060
4770         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4771         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4772         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4773         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4774         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4775         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4776
4777 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4778
4779         * source.c (select_source_symtab): Move header comment to
4780         declaration in source.h.
4781         (forget_cached_source_info_for_objfile): Likewise.
4782         (forget_cached_source_info): Likewise.
4783         (identify_source_line): Likewise.
4784         * source.h (identify_source_line): Move declaration from symtab.h
4785         and add comment from source.c
4786         (print_source_lines): Likewise.
4787         (forget_cached_source_info_for_objfile): Likewise.
4788         (forget_cached_source_info): Likewise.
4789         (select_source_symtab): Likewise.
4790         (enum print_source_lines_flag): Move definition from symtab.h.
4791         * symtab.h (identify_source_line): Move declaration to source.h.
4792         (print_source_lines): Likewise.
4793         (forget_cached_source_info_for_objfile): Likewise.
4794         (forget_cached_source_info): Likewise.
4795         (select_source_symtab): Likewise.
4796         (enum print_source_lines_flag): Move definition to source.h.
4797         * tui/tui-hooks.c: Add 'source.h' include.
4798
4799 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4800
4801         * source.c (print_source_lines_base): Handle requests to print
4802         reverse line number sequences, and guard against empty lines
4803         string.
4804
4805 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * source.c (print_source_lines_base): Fix skip of '\r' if next
4808         character is '\n'.
4809
4810 2019-01-06  Tom Tromey  <tom@tromey.com>
4811
4812         * c-exp.y (struct c_parse_state) <macro_original_text,
4813         expansion_obstack>: New member.
4814         (macro_original_text, expansion_obstack): Remove globals.
4815         (scan_macro_expansion, scanning_macro_expansion)
4816         (finished_macro_expansion): Update.
4817         (scan_macro_cleanup): Remove.
4818         (yylex, c_parse): Update.
4819
4820 2019-01-06  Tom Tromey  <tom@tromey.com>
4821
4822         * c-exp.y (struct c_parse_state) <strings>: New member.
4823         (operator_stoken): Update.
4824
4825 2019-01-06  Tom Tromey  <tom@tromey.com>
4826
4827         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4828         (union type_stack_elt) <typelist_val>: Now a pointer to
4829         std::vector.
4830         (type_stack_cleanup): Don't declare.
4831         (push_typelist): Update.
4832         * parse.c (pop_typelist): Return a std::vector.
4833         (push_typelist): Take a std::vector.
4834         (follow_types): Update.  Do not free args.
4835         (type_stack_cleanup): Remove.
4836         * c-exp.y (struct c_parse_state): New.
4837         (cpstate): New global.
4838         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4839         (nonempty_typelist): Update.
4840         (func_mod): Create a new vector.
4841         (c_parse): Create a c_parse_state.
4842         (check_parameter_typelist): Do not delete params.
4843         (function_method): Update.  Do not delete type_list.
4844
4845 2019-01-06  Tom Tromey  <tom@tromey.com>
4846
4847         PR gdb/28155:
4848         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4849         check_typedef.
4850         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4851         (print_return_value): Likewise.
4852
4853 2019-01-05  Tom Tromey  <tom@tromey.com>
4854
4855         * contrib/cleanup_check.py: Remove.
4856         * contrib/gcc-with-excheck: Remove.
4857         * contrib/exsummary.py: Remove.
4858         * contrib/excheck.py: Remove.
4859
4860 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4861
4862         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4863         NULL. Initialize tpprev to NULL instead of assigning it
4864         to NULL on the next statement.
4865         * windows-nat.c (windows_delete_thread): Remove check for
4866         main_thread_id before printing thread exit notifications.
4867         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4868         Remove thread ID check against main_thread_id.
4869         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4870         windows_delete_thread.
4871         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4872
4873 2019-01-04  Tom Tromey  <tom@tromey.com>
4874
4875         * compile/compile.c (_initialize_compile): Use upper case for
4876         metasyntactic variables.
4877         * symmisc.c (_initialize_symmisc): Use upper case for
4878         metasyntactic variables.
4879         * psymtab.c (_initialize_psymtab): Use upper case for
4880         metasyntactic variables.
4881         * demangle.c (demangle_command): Use upper case for metasyntactic
4882         variables.
4883         (_initialize_demangler): Likewise.
4884         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4885         variables.
4886
4887 2019-01-03  Tom Tromey  <tom@tromey.com>
4888
4889         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4890
4891 2019-01-03  Tom Tromey  <tom@tromey.com>
4892
4893         * python/py-symtab.c (salpy_str): Update.
4894         (struct salpy_sal_object) <symtab>: Now a PyObject.
4895         (salpy_dealloc): Update.
4896         (del_objfile_sal): Use gdbpy_ref.
4897
4898 2019-01-03  Tom Tromey  <tom@tromey.com>
4899
4900         * python/py-type.c (convert_field): Use new_reference.  Return
4901         gdbpy_ref.
4902         (make_fielditem): Return gdbpy_ref.
4903         (typy_fields): Update.
4904         (typy_getitem): Update.
4905         (field_name): Return gdbpy_ref.  Use new_reference.
4906         (typy_iterator_iternext): Update.
4907
4908 2019-01-03  Tom Tromey  <tom@tromey.com>
4909
4910         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4911
4912 2019-01-03  Tom Tromey  <tom@tromey.com>
4913
4914         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4915         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4916         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4917         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4918         (pspy_set_type_printers): Likewise.
4919         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4920         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4921         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4922         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4923         (objfpy_set_type_printers): Likewise.
4924
4925 2019-01-03  Tom Tromey  <tom@tromey.com>
4926
4927         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4928         (gdbpy_print_stack): Use gdbpy_err_fetch.
4929         * python/python-internal.h (class gdbpy_err_fetch): New class.
4930         (class gdbpy_enter) <m_error_type, m_error_value,
4931         m_error_traceback>: Remove.
4932         <m_error>: New member.
4933         (gdbpy_exception_to_string): Don't declare.
4934         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4935         * python/py-value.c (convert_value_from_python): Use
4936         gdbpy_err_fetch.
4937         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4938         gdbpy_exception_to_string.
4939         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4940         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4941         gdbpy_err_fetch.
4942
4943 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4944
4945         * linux-nat.c (delete_lwp_cleanup): Delete.
4946         (struct lwp_deleter): New struct.
4947         (lwp_info_up): New typedef.
4948         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4949         lwp_info_up.
4950
4951 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4952
4953         * linux-fork.c (class scoped_switch_fork_info): New class.
4954         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4955
4956 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4957
4958         * valops.c (find_overload_match): Remove use of null_cleanup, and
4959         calls to do_cleanups.
4960
4961 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4962
4963         * compile/compile-cplus-types.c
4964         (compile_cplus_instance::decl_name): Handle changes to
4965         cp_func_name.
4966         * cp-support.c (cp_func_name): Update header comment, update
4967         return type.
4968         * cp-support.h (cp_func_name): Update return type in declaration.
4969         * valops.c (find_overload_match): Move temp_func local to top
4970         level of function and change its type.  Use temp_func to hold and
4971         delete temporary string obtained from cp_func_name.
4972
4973 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4976         gdb::char_vector, remove cleanup, and update uses of `msg`.
4977
4978 2019-01-03  Jim Wilson  <jimw@sifive.com>
4979
4980         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4981
4982 2019-01-02  Tom Tromey  <tom@tromey.com>
4983
4984         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4985         (tdesc_parse_xml): Remove cleanups.
4986         * target-descriptions.h (make_cleanup_free_target_description):
4987         Don't declare.
4988         (target_desc_deleter): New struct.
4989         (target_desc_up): New typedef.
4990         * target-descriptions.c (target_desc_deleter::operator()): Rename
4991         from free_target_description.
4992         (make_cleanup_free_target_description): Remove.
4993
4994 2019-01-02  Tom Tromey  <tom@tromey.com>
4995
4996         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4997         constructor, destructor.
4998         (linespec_parser): Remove typedef.
4999         (~linespec_parser): Rename from linespec_parser_delete.
5000         (linespec_lex_to_end, linespec_complete_label)
5001         (linespec_complete): Update.
5002         (decode_line_full): Remove cleanups.
5003         (decode_line_1): Update.
5004
5005 2019-01-02  Tom Tromey  <tom@tromey.com>
5006
5007         * python/python-internal.h (inferior_to_inferior_object): Change
5008         return type.
5009         * python/py-exitedevent.c (create_exited_event_object): Update.
5010         * python/py-inferior.c (inferior_to_inferior_object): Return
5011         gdbpy_ref.
5012         (python_new_inferior, python_inferior_deleted)
5013         (thread_to_thread_object, delete_thread_object)
5014         (build_inferior_list, gdbpy_selected_inferior): Update.
5015         * python/py-infthread.c (create_thread_object): Update.  Also fail
5016         if inferior_to_inferior_object fails.
5017
5018 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5019
5020         * inferior.h (class inferior) <displaced_step_state>: New field.
5021         * infrun.h (struct displaced_step_state): Move here from
5022         infrun.c.  Initialize fields, add constructor.
5023         <inf>: Remove field.
5024         <reset>: New method.
5025         * infrun.c (struct displaced_step_inferior_state): Move to
5026         infrun.h.
5027         (displaced_step_inferior_states): Remove.
5028         (get_displaced_stepping_state): Adust.
5029         (displaced_step_in_progress_any_inferior): Adjust.
5030         (displaced_step_in_progress_thread): Adjust.
5031         (displaced_step_in_progress): Adjust.
5032         (add_displaced_stepping_state): Remove.
5033         (get_displaced_step_closure_by_addr): Adjust.
5034         (remove_displaced_stepping_state): Remove.
5035         (infrun_inferior_exit): Call displaced_step_state.reset.
5036         (use_displaced_stepping): Don't check for NULL.
5037         (displaced_step_prepare_throw): Call
5038         get_displaced_stepping_state.
5039         (displaced_step_fixup): Don't check for NULL.
5040         (prepare_for_detach): Don't check for NULL.
5041
5042 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5043
5044         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5045          in case of call that did not complete.
5046
5047 2019-01-02  Andrey Utkin  <autkin@undo.io>
5048
5049         * symfile.c (find_separate_debug_file): Fix search of debug files for
5050         remote debuggee.
5051
5052 2019-01-02  Tom Tromey  <tom@tromey.com>
5053
5054         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5055         indentation.
5056         * python/py-frame.c (frapy_older): Remove cast.
5057         (frapy_newer): Likewise.
5058         * python/py-breakpoint.c (local_setattro): Remove cast.
5059         * python/py-arch.c (archpy_name): Remove local variable.
5060         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5061
5062 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5063
5064         * unittests/basic_string_view/element_access/char/empty.cc:
5065         Fix year range in copyright header.
5066
5067 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5068
5069         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5070         Delete.
5071         <operator==>: Update with for removed field.
5072         <hash>: Likewise.
5073         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5074         <isa_features>: ...this.
5075         <abi_features>: New field.
5076         (riscv_isa_flen): Update comment.
5077         (riscv_abi_xlen): New declaration.
5078         (riscv_abi_flen): New declaration.
5079         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5080         isa_features.
5081         (riscv_abi_xlen): New function.
5082         (riscv_isa_flen): Update to get answer from isa_features.
5083         (riscv_abi_flen): New function.
5084         (riscv_has_fp_abi): Update to get answer from abi_features.
5085         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5086         xlen and flen.
5087         (riscv_call_info) <xlen, flen>: Update comment.
5088         (riscv_call_arg_struct): Remove invalid assertions
5089         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5090         is removed.
5091         (riscv_gdbarch_init): Gather isa features and abi features
5092         separately, ensure both match on the gdbarch when reusing an old
5093         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5094         a target with 64-bit float hardware.
5095
5096 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5097
5098         * source.c (search_command_helper): Stop reverse search
5099         when line 1 has been searched.
5100
5101 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5102
5103         * record-full.c (record_full_base_target::close): Rewrite
5104         record_full_core_buf_list free logic.
5105
5106 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5107
5108         * break-catch-syscall.c (print_one_catch_syscall): xfree
5109         the last text.
5110
5111 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5112
5113         * top.c (print_gdb_version): Update Copyright year in version
5114         message.
5115
5116 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5117
5118         Update copyright year range in all GDB files.
5119
5120 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5121
5122         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5123
5124 For older changes see ChangeLog-2018.
5125 \f
5126 Local Variables:
5127 mode: change-log
5128 left-margin: 8
5129 fill-column: 74
5130 version-control: never
5131 coding: utf-8
5132 End:
5133