gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
   4         destructor.
   5         (dbx_objfile_data_key): Change type and declare later.
   6         (DBX_SYMFILE_INFO): Rewrite.
   7         * dbxread.c (dbx_objfile_data_key): Change type.
   8         (dbx_symfile_init): Update.
   9         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
  10         (coffstab_build_psymtabs, elfstab_build_psymtabs)
  11         (stabsect_build_psymtabs, _initialize_dbxread): Update.
  12
  13 2019-07-10  Tom Tromey  <tromey@adacore.com>
  14
  15         * jit.c (jit_program_space_key): Change type.  Move lower.
  16         (get_jit_program_space_data): Update.
  17         (jit_program_space_data_cleanup): Remove.
  18         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
  19         Update.
  20         (struct jit_program_space_data): Add initializers.
  21
  22 2019-07-10  Tom Tromey  <tromey@adacore.com>
  23
  24         * solib-darwin.c (struct darwin_info): Add initializers.
  25         (solib_darwin_pspace_data): Change type.
  26         (darwin_pspace_data_cleanup): Remove.
  27         (get_darwin_info, _initialize_darwin_solib): Update.
  28
  29 2019-07-10  Tom Tromey  <tromey@adacore.com>
  30
  31         * remote-sim.c (struct sim_inferior_data): Add initializers,
  32         constructor, and destructor.
  33         (sim_inferior_data_key): Change type.  Move lower.
  34         (check_for_duplicate_sim_descriptor): Update.
  35         (get_sim_inferior_data): Use new.  Update.
  36         (~sim_inferior_data_cleanup): Rename from
  37         sim_inferior_data_cleanup.  Simplify.
  38         (gdbsim_close_inferior, simulator_command)
  39         (sim_command_completer, _initialize_remote_sim): Update.
  40         (next_pid, INITIAL_PID): Move earlier.
  41
  42 2019-07-10  Tom Tromey  <tromey@adacore.com>
  43
  44         * python/python-internal.h (create_thread_object): Return
  45         gdbpy_ref.
  46         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
  47         * python/py-inferior.c (struct threadlist_entry): Add
  48         constructor.
  49         <thread_obj>: Now a gdbpy_ref.
  50         (thread_to_thread_object): Update.
  51         (add_thread_object): Use new.
  52         (delete_thread_object): Use delete.
  53         (infpy_threads): Update.
  54         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
  55         GIL.
  56
  57 2019-07-10  Tom Tromey  <tromey@adacore.com>
  58
  59         * valops.c (value_cast): Specialize error message for Ada.
  60
  61 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  62
  63         * breakpoint.c (breakpoint_1): Update doc and parameter names.
  64
  65 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  66
  67         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
  68         bpstat_should_step): Return bool, adjust comments.
  69         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
  70         bpstat_should_step): Likewise.
  71
  72 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  73
  74         * features/Makefile: Use feature target descriptions for Arm.
  75         * features/arm/arm-core.c: Generate new file.
  76         * features/arm/arm-fpa.c: Likewise.
  77         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
  78         * features/arm/arm-m-profile.c: Likewise.
  79         * features/arm/arm-vfpv2.c: Likewise.
  80         * features/arm/arm-vfpv3.c: Likewise.
  81         * features/arm/xscale-iwmmxt.c: Likewise.
  82         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  83
  84 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  85
  86         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
  87         ptrace earlier.
  88
  89 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  90
  91         * features/aarch64-pauth.c: Regenerate.
  92
  93 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
  94
  95         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
  96         bool.
  97         (bpstat_what): Use false instead of 0.
  98
  99 2019-07-09  Pedro Alves  <palves@redhat.com>
 100
 101         * break-catch-throw.c (is_exception_catchpoint): New.
 102         * breakpoint.c (print_one_breakpoint_location): New parameter
 103         'raw_loc'.  Handle it.  Use
 104         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 105         looking at the breakpoint's type.
 106         (print_one_breakpoint): If handling "maint info breakpoints", also
 107         print locations of exception catchpoints.
 108         * breakpoint.h (is_exception_catchpoint): Declare.
 109
 110 2019-07-09  Pedro Alves  <palves@redhat.com>
 111
 112         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 113         "addr" field.
 114         (allocate_location_exception_catchpoint): New.
 115         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 116         (initialize_throw_catchpoint_ops): Install
 117         allocate_location_exception_catchpoint as allocate_location
 118         method.
 119         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 120         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 121         bp_loc_other.
 122         (breakpoint_address_is_meaningful): Delete.
 123         (bl_address_is_meaningful): New.
 124         (breakpoint_locations_match): Adjust comment.
 125         (bp_location_from_bp_type): New, factored out of...
 126         (bp_location::bp_location(breakpoint *)): ... this.
 127         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 128         factored out of...
 129         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 130         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 131         breakpoint_address_is_meaningful.
 132         (bp_locations_compare): Adjust comment.
 133         (update_global_location_list): Use bl_address_is_meaningful
 134         instead of breakpoint_address_is_meaningful.
 135         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 136         explicit.
 137         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 138         * python/py-breakpoint.c (bppy_get_location): No longer check
 139         whether location is null.
 140
 141 2019-07-09  Pedro Alves  <palves@redhat.com>
 142
 143         PR c++/15468
 144         * breakpoint.c (print_one_breakpoint_location): Remove
 145         single-location assert.
 146
 147 2019-07-09  Tom Tromey  <tom@tromey.com>
 148
 149         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 150         * configure: Rebuild.
 151         * configure.ac: Change common to gdbsupport.
 152         * gdbsupport: Rename from common.
 153         * acinclude.m4: Change common to gdbsupport.
 154         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 155         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 156         gdbsupport.
 157         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 158         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 159         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 160         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 161         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 162         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 163         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 164         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 165         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 166         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 167         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 168         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 169         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 170         coff-pe-read.c, command.h, compile/compile-c-support.c,
 171         compile/compile-c.h, compile/compile-cplus-symbols.c,
 172         compile/compile-cplus-types.c, compile/compile-cplus.h,
 173         compile/compile-loc2c.c, compile/compile.c, completer.c,
 174         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 175         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 176         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 177         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 178         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 179         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 180         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 181         features/aarch64-core.c, features/aarch64-fpu.c,
 182         features/aarch64-pauth.c, features/aarch64-sve.c,
 183         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 184         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 185         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 186         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 187         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 188         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 189         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 190         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 191         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 192         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 193         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 194         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 195         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 196         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 197         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 198         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 199         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 200         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 201         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 202         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 203         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 204         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 205         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 206         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 207         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 208         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 209         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 210         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 211         minsyms.c, mips-linux-tdep.c, namespace.h,
 212         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 213         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 214         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 215         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 216         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 217         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 218         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 219         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 220         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 221         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 222         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 223         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 224         procfs.c, producer.c, progspace.h, psymtab.h,
 225         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 226         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 227         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 228         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 229         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 230         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 231         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 232         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 233         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 234         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 235         target-memory.c, target.c, target.h, target/waitstatus.c,
 236         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 237         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 238         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 239         unittests/array-view-selftests.c,
 240         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 241         unittests/common-utils-selftests.c,
 242         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 243         unittests/format_pieces-selftests.c,
 244         unittests/function-view-selftests.c,
 245         unittests/lookup_name_info-selftests.c,
 246         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 247         unittests/mkdir-recursive-selftests.c,
 248         unittests/observable-selftests.c,
 249         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 250         unittests/parse-connection-spec-selftests.c,
 251         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 252         unittests/scoped_fd-selftests.c,
 253         unittests/scoped_mmap-selftests.c,
 254         unittests/scoped_restore-selftests.c,
 255         unittests/string_view-selftests.c, unittests/style-selftests.c,
 256         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 257         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 258         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 259         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 260         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 261         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 262
 263 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 264
 265         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 266         bool value.
 267         (decode_digits_ordinary): Set explicit_line field in sal.
 268         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 269         symtab_and_line that was set on an explicit line number in
 270         assembler code.  Do always update the recorded symtab and line if
 271         we do skip the prologue.
 272
 273 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 274
 275         * breakpoint.c (set_breakpoint_location_function): Remove
 276         explicit_loc parameter.
 277         (momentary_breakpoint_from_master): Update call to
 278         set_breakpoint_location_function.
 279         (add_location_to_breakpoint): Likewise.
 280
 281 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 282
 283         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 284         required features based on default bfd type when no specific bfd
 285         is present.
 286
 287 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 288
 289         * NEWS: Mention that GDB printf and eval commands can now print
 290         C-style and Ada-style convenience var strings without
 291         calling the inferior.
 292         * printcmd.c (printf_c_string): Locally print GDB internal var
 293         instead of transiting via the inferior.
 294         (printf_wide_c_string): Likewise.
 295
 296 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 297
 298         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 299
 300 2019-07-04  Tom Tromey  <tom@tromey.com>
 301
 302         PR tui/24724:
 303         * tui/tui-winsource.c (tui_clear_source_content): Update.
 304         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 305         (tui_update_breakpoint_info): Update.
 306         (tui_set_exec_info_content): Update.
 307         * tui/tui-source.c (tui_set_source_content_nil): Update.
 308         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 309         has_break.
 310         * tui/tui-data.h (enum tui_bp_flag): New.
 311         (tui_bp_flags): New enum flags type.
 312         (struct tui_source_element) <break_mode>: Change type.  Rename
 313         from has_break.
 314         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 315         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 316         constants.
 317         * tui/tui-winsource.h: Fix comment.
 318
 319 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 320
 321         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 322         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 323         (store_fpregs_to_thread)
 324         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 325         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 326         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 327         (IWMMXT_REGS_SIZE): Add define.
 328         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 329         (fetch_vfp_regs, store_vfp_regs)
 330         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 331         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 332
 333 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 334
 335         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 336         defines.
 337         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 338         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 339         (ARM_INT_REGISTER_SIZE): ...to this.
 340         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 341         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 342         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 343         (arm_linux_collect_gregset, supply_nwfpe_register)
 344         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 345         defines.
 346         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 347         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 348         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 349         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 350         (arm_return_in_memory, arm_store_return_value)
 351         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 352         (arm_record_ld_st_multiple): Likewise.
 353         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 354         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 355
 356 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 357
 358         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 359         AARCH64_DISPLACED_MODIFIED_INSNS.
 360         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 361         (aarch64_displaced_step_copy_insn): Likewise.
 362         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 363         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 364         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 365         ARM_DISPLACED_MODIFIED_INSNS.
 366         * arm-tdep.c (arm_gdbarch_init): Likewise.
 367         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 368         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 369         (struct arm_displaced_step_closure): Use
 370         ARM_DISPLACED_MODIFIED_INSNS.
 371
 372 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 373
 374         * features/Makefile: Remove unused xml files.
 375         * features/aarch64.xml: Remove.
 376         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 377         * features/i386/amd64-avx-avx512.xml: Remove.
 378         * features/i386/amd64-avx-linux.xml: Remove.
 379         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 380         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 381         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 382         * features/i386/amd64-avx-mpx.xml: Remove.
 383         * features/i386/amd64-avx.xml: Remove.
 384         * features/i386/amd64-linux.xml: Remove.
 385         * features/i386/amd64-mpx-linux.xml: Remove.
 386         * features/i386/amd64-mpx.xml: Remove.
 387         * features/i386/amd64.xml: Remove.
 388         * features/i386/i386-avx-avx512-linux.xml: Remove.
 389         * features/i386/i386-avx-avx512.xml: Remove.
 390         * features/i386/i386-avx-linux.xml: Remove.
 391         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 392         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 393         * features/i386/i386-avx-mpx-linux.xml: Remove.
 394         * features/i386/i386-avx-mpx.xml: Remove.
 395         * features/i386/i386-avx.xml: Remove.
 396         * features/i386/i386-linux.xml: Remove.
 397         * features/i386/i386-mmx-linux.xml: Remove.
 398         * features/i386/i386-mmx.xml: Remove.
 399         * features/i386/i386-mpx-linux.xml: Remove.
 400         * features/i386/i386-mpx.xml: Remove.
 401         * features/i386/i386.xml: Remove.
 402         * features/i386/x32-avx-avx512-linux.xml: Remove.
 403         * features/i386/x32-avx-linux.xml: Remove.
 404         * features/i386/x32-linux.xml: Remove.
 405
 406 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 407
 408         * regformats/aarch64.dat: Remove.
 409         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 410         * regformats/i386/amd64-avx-linux.dat: Remove.
 411         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 412         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 413         * regformats/i386/amd64-linux.dat: Remove.
 414         * regformats/i386/amd64-mpx-linux.dat: Remove.
 415         * regformats/i386/amd64.dat: Remove.
 416         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 417         * regformats/i386/i386-avx-linux.dat: Remove.
 418         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 419         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 420         * regformats/i386/i386-linux.dat: Remove.
 421         * regformats/i386/i386-mmx-linux.dat: Remove.
 422         * regformats/i386/i386-mpx-linux.dat: Remove.
 423         * regformats/i386/i386.dat: Remove.
 424         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 425         * regformats/i386/x32-avx-linux.dat: Remove.
 426         * regformats/i386/x32-linux.dat: Remove.
 427
 428 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 429
 430         * aarch64-tdep.c: Remove xml self tests.
 431         * amd64-linux-tdep.c: Likewise.
 432         * amd64-tdep.c: Likewise.
 433         * i386-linux-tdep.c: Likewise.
 434         * i386-tdep.c: Likewise.
 435
 436 2019-07-03  Pedro Alves  <palves@redhat.com>
 437
 438         PR cli/24732
 439         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 440         (pipe_cmd_option_defs): New.
 441         (make_pipe_cmd_options_def_group): New.
 442         (pipe_command): Use gdb::option::process_options.
 443         (pipe_command_completer): New function.
 444         (_initialize_cli_cmds): Install completer for "pipe" command.
 445
 446 2019-07-03  Pedro Alves  <palves@redhat.com>
 447
 448         * cli/cli-option.c (union option_value) <string>: New field.
 449         (struct option_def_and_value): Add ctor, move ctor, dtor and
 450         use DISABLE_COPY_AND_ASSIGN.
 451         (option_def_and_value::clear_value): New.
 452         (parse_option, save_option_value_in_ctx, get_val_type_str)
 453         (add_setshow_cmds_for_options): Handle var_string.
 454         * cli-option.h (union option_def::var_address) <string>: New
 455         field.
 456         (struct string_option_def): New.
 457         * maint-test-options.c (struct test_options_opts): Add default
 458         ctor and use DISABLE_COPY_AND_ASSIGN.
 459         <string_opt>: New field.
 460         (test_options_opts::~test_options_opts): New.
 461         (test_options_opts::dump): Also dump "-string".
 462         (test_options_option_defs): Install "string.
 463
 464 2019-07-03  Pedro Alves  <palves@redhat.com>
 465
 466         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 467         option_value with a null enumeration.
 468         (complete_options): Save the option values in the context.
 469         (save_option_value_in_ctx): New, factored out from ...
 470         (process_options): ... here.
 471         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 472         of the function.
 473         * maint-test-options.c (test_options_opts::dump): New, factored
 474         out from ...
 475         (maintenance_test_options_command_mode): ... here.
 476         (maintenance_test_options_command_completion_result): Delete.
 477         (maintenance_test_options_command_completion_text): Update
 478         comment.
 479         (maintenance_show_test_options_completion_result): Change
 480         prototype.  Just print
 481         maintenance_test_options_command_completion_text.
 482         (save_completion_result): New.
 483         (maintenance_test_options_completer_mode): Pass options context to
 484         complete_options, and then save a dump.
 485         (_initialize_maint_test_options): Use add_cmd to install "maint
 486         show test-options-completion-result".
 487
 488 2019-07-03  Pedro Alves  <palves@redhat.com>
 489
 490         * NEWS (New commands): Mention "with" and "maint with".
 491         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 492         (with_command, with_command_completer): New.
 493         (pipe_command): Adjust to new repeat_previous
 494         interface.
 495         (_initialize_cli_cmds): Install the "with" command and its "w"
 496         alias.
 497         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 498         declarations.
 499         * cli/cli-setshow.c (parse_cli_var_uinteger)
 500         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 501         argument strings for all var_types.
 502         (get_setshow_command_value_string): New, factored out from ...
 503         (do_show_command): ... this.
 504         * cli/cli-setshow.h: Include <string>.
 505         (get_setshow_command_value_string): Declare.
 506         * command.h (repeat_previous): Now returns const char *.  Adjust
 507         comment.
 508         * maint.c: Include "cli/cli-cmds.h".
 509         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 510         (_initialize_maint_cmds): Register the "maintenance with" command.
 511         * top.c (repeat_previous): Move bits from pipe_command here:
 512         Return the saved command line, if any; error out if there's no
 513         command to relaunch.
 514
 515 2019-07-03  Pedro Alves  <palves@redhat.com>
 516
 517         * NEWS (New commands): Mention "maint set/show test-settings"
 518         instead of "maint test-settings".
 519         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 520         (maintenance_test_settings_set_list): Rename to ...
 521         (maintenance_set_test_settings_list): ... this.
 522         (maintenance_test_settings_show_list): Rename to  ...
 523         (maintenance_show_test_settings_list): ... this.
 524         (maintenance_test_settings_cmd): Delete.
 525         (maintenance_test_settings_set_cmd): ...
 526         (maintenance_set_test_settings_cmd): ... this.
 527         (maintenance_test_settings_show_cmd): ...
 528         (maintenance_show_test_settings_cmd): ... this.
 529         (maintenance_test_settings_show_value_cmd):
 530         (maintenance_show_test_settings_value_cmd): ... this.
 531         (_initialize_maint_test_settings): No longer install the "maint
 532         test-settings" prefix command.  Rename "maint test-settings set"
 533         to "maint set test-settings", and "maint test-settings show" to
 534         "maint show test-settings".  Adjust all subcommands.
 535
 536 2019-07-03  Pedro Alves  <palves@redhat.com>
 537
 538         * maint-test-settings.c: Fix file's intro comment.  Replace all
 539         references to "test-options" with references to "test-settings",
 540         in comments.
 541
 542 2019-07-03  Pedro Alves  <palves@redhat.com>
 543
 544         * maint-test-settings.c (maintenance_test_settings_xxx)
 545         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 546         New.
 547         (maintenance_test_settings_enums): Use them.
 548         (maintenance_test_settings_enum): Default to
 549         maintenance_test_settings_xxx.
 550         (_initialize_maint_test_settings): Initialize
 551         MAINTENANCE_TEST_SETTINGS_FILENAME.
 552
 553 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 554
 555         * breakpoint.h (remove_breakpoints_inf): Change return type to
 556         void, move function documentation here.
 557         * breakpoint.c (remove_breakpoints_inf): Change return type to
 558         void, move function documentation to header.
 559
 560 2019-07-02  Pedro Alves  <palves@redhat.com>
 561
 562         * NEWS (Completion improvements): Mention "info threads".
 563         * thread.c (struct info_threads_opts, info_threads_option_defs)
 564         (make_info_threads_options_def_group): New.
 565         (info_threads_command): Use gdb::option::process_options.
 566         (info_threads_command_completer): New.
 567         (_initialize_thread): Use gdb::option::build_help to build the
 568         help text for "info threads".
 569
 570 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 571
 572         * defs.h (generic_load): Move from here...
 573         * symfile.h (generic_load): ... to here.  Rename name parameter
 574         to args.
 575         * symfile.c (generic_load): Add comment.
 576
 577 2019-07-01  Tom Tromey  <tromey@adacore.com>
 578
 579         * dwarf2read.c
 580         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 581         declaration of without_params.  Fix formatting.
 582
 583 2019-07-01  Tom Tromey  <tromey@adacore.com>
 584
 585         * ada-exp.y (find_primitive_type): Update.
 586         * ada-lang.h (ada_lookup_symbol): Update.
 587         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 588         parameter.
 589         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 590
 591 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 592
 593         PR breakpoints/24541
 594         * gdbarch.c: Regenerate.
 595         * gdbarch.h: Regenerate.
 596         * gdbarch.sh: Add 'stap_adjust_register'.
 597         * i386-tdep.c: Include '<unordered_set>'.
 598         (i386_stap_adjust_register): New function.
 599         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 600         * stap-probe.c (stap_parse_register_operand): Call
 601         'gdbarch_stap_adjust_register'.
 602
 603 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 604
 605         PR python/24742
 606         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 607         * python/python.c (do_start_initialization): Use 'xmalloc'
 608         instead of 'PyMem_Malloc'.
 609
 610 2019-06-28  Tom Tromey  <tromey@adacore.com>
 611
 612         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 613         for Ada.
 614
 615 2019-06-27  Tom Tromey  <tromey@adacore.com>
 616
 617         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 618         objfile_key.
 619         (arm_find_mapping_symbol, arm_record_special_symbol)
 620         (_initialize_arm_tdep): Update.
 621         (arm_objfile_data_free): Remove.
 622
 623 2019-06-27  Tom Tromey  <tromey@adacore.com>
 624
 625         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 626         to cp_print_static_field.
 627
 628 2019-06-26  Tom Tromey  <tromey@adacore.com>
 629
 630         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 631         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 632         declare.
 633
 634 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 635
 636         * features/aarch64-core.c (create_feature_aarch64_core):
 637         Regenerate.
 638         * features/aarch64-core.xml: Add cpsr flags.
 639
 640 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 641
 642         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 643         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 644
 645 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 646
 647         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 648         field.
 649         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 650         use.
 651         (arm_record_special_symbol): Don't insert new symbol in sorted
 652         position, push it at the end.
 653
 654 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 655
 656         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 657         (arm_mapping_symbol_s): Remove.
 658         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 659         (arm_mapping_symbol_vec): New typedef.
 660         (struct arm_per_objfile): Add constructor.
 661         <section_maps>: Change type to
 662         std::unique_ptr<arm_mapping_symbol_vec[]>.
 663         (arm_compare_mapping_symbols): Remove.
 664         (arm_find_mapping_symbol): Adjust to section_maps type change.
 665         (arm_objfile_data_free): Call delete on arm_per_objfile.
 666         (arm_record_special_symbol): Adjust to section_maps type change.
 667         Allocate arm_per_objfile with new.
 668
 669 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 670
 671         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 672         with the command prefix.
 673
 674 2019-06-25  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 677         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 678
 679 2019-06-25  Tom Tromey  <tom@tromey.com>
 680
 681         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 682         type.
 683         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 684         protected.
 685
 686 2019-06-25  Tom Tromey  <tom@tromey.com>
 687
 688         * tui/tui-winsource.c
 689         (tui_source_window_base::set_is_exec_point_at): Add check against
 690         LOA_ADDRESS.
 691
 692 2019-06-25  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-source.c (tui_set_source_content): Don't check before
 695         xfree.
 696         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 697
 698 2019-06-25  Tom Tromey  <tom@tromey.com>
 699
 700         * tui/tui-winsource.h (tui_update_source_window_as_is)
 701         (tui_alloc_source_buffer, tui_line_is_displayed)
 702         (tui_addr_is_displayed): Change type of win_info.
 703         * tui/tui-winsource.c (tui_update_source_window_as_is)
 704         (tui_clear_source_content, tui_show_source_line)
 705         (tui_show_source_content, tui_source_window_base::refill)
 706         (tui_source_window_base::set_is_exec_point_at)
 707         (tui_source_window_base::set_is_exec_point_at)
 708         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 709         (tui_alloc_source_buffer, tui_line_is_displayed)
 710         (tui_addr_is_displayed): Change type of win_info.  Update.
 711         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 712         (tui_source_window_base::do_make_visible_with_new_height):
 713         Update.
 714         * tui/tui-source.c (tui_set_source_content)
 715         (tui_set_source_content_nil)
 716         (tui_source_window::do_scroll_vertical): Update.
 717         * tui/tui-layout.c (show_layout): Update.
 718         * tui/tui-disasm.c (tui_set_disassem_content)
 719         (tui_disasm_window::do_scroll_vertical): Update.
 720         * tui/tui-data.h (tui_win_content): Remove.
 721         (struct tui_gen_win_info) <content, content_size>: Remove.
 722         (struct tui_source_element): Add initializers and destructor.
 723         (union tui_which_element, struct tui_win_element): Remove.
 724         (struct tui_source_window_base) <content>: New field.
 725         (struct tui_data_window): Remove destructor.
 726         (tui_alloc_content, tui_free_win_content)
 727         (tui_free_all_source_wins_content): Don't declare.
 728         * tui/tui-data.c (tui_initialize_static_data): Update.
 729         (init_content_element, tui_alloc_content): Remove.
 730         (~tui_gen_win_info): Update.
 731         (~tui_data_window, tui_free_all_source_wins_content)
 732         (tui_free_win_content, free_content, free_content_elements):
 733         Remove.
 734
 735 2019-06-25  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-winsource.h (tui_clear_source_content)
 738         (tui_erase_source_content, tui_show_source_content): Change type
 739         of win_info.
 740         * tui/tui-winsource.c (tui_clear_source_content)
 741         (tui_erase_source_content, tui_show_source_content): Change type
 742         of win_info.
 743         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 744         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 745         win_info.
 746         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 747         win_info.
 748         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 749
 750 2019-06-25  Tom Tromey  <tom@tromey.com>
 751
 752         * tui/tui-winsource.c (tui_clear_source_content)
 753         (tui_source_window_base::set_is_exec_point_at): Update.
 754         * tui/tui-source.c (tui_set_source_content_nil): Update.
 755         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 756         a bool.
 757         * tui/tui-data.c (init_content_element): Update.
 758
 759 2019-06-25  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 762         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 763         * tui/tui-layout.c (init_and_make_win): Update.
 764         * tui/tui.h (enum tui_win_type): Update.
 765         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 766         tui_win_is_auxillary.
 767         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 768         tui_win_is_auxillary.
 769
 770 2019-06-25  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 773         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 774         (tui_delete_data_content_windows, tui_display_all_data)
 775         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 776         Update.
 777         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 778         * tui/tui-regs.c (tui_last_regs_line_no)
 779         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 780         (tui_show_registers): Update.
 781         (tui_show_register_group): Return void.  Update.
 782         (tui_display_registers_from, tui_display_reg_element_at_line)
 783         (tui_display_registers_from_line, tui_check_register_values):
 784         Update.
 785         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 786         member.
 787         (struct tui_data_window) <regs_content>: Now a std::vector.
 788         <regs_content_count>: Remove.
 789         (tui_add_content_elements, tui_free_data_content): Don't declare.
 790         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 791         (init_content_element): Remove DATA_WIN case.  Add assert.
 792         (tui_add_content_elements): Remove.
 793         (tui_data_window): Update.
 794         (tui_free_data_content): Remove.
 795         (free_content_elements): Remove DATA_WIN case.
 796
 797 2019-06-25  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-data.c (tui_data_item_window): Update.
 800         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 801         * tui/tui-windata.c (tui_display_all_data)
 802         (tui_display_data_from_line): Update.
 803         (tui_check_data_values): Remove.
 804         * tui/tui-regs.c (tui_show_register_group)
 805         (tui_display_reg_element_at_line): Update.
 806         * tui/tui-hooks.c (tui_register_changed)
 807         (tui_refresh_frame_and_register_information): Call
 808         tui_check_register_values.
 809         * tui/tui-data.h (struct tui_data_window) <data_content,
 810         data_content_count, data_type>: Remove.
 811         (enum tui_data_type): Remove.
 812
 813         * tui/tui-data.c (tui_data_window::clear_detail)
 814         (~tui_data_window): Update.
 815
 816 2019-06-25  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 819         declare.
 820         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 821         Rename from tui_first_data_item_displayed.  Update.
 822         (tui_data_window::refresh_all)
 823         (tui_data_window::do_scroll_vertical): Update.
 824         * tui/tui-data.h (struct tui_data_window)
 825         <first_data_item_displayed>: Declare new method.
 826
 827 2019-06-25  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 830         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 831         contents...
 832         (tui_initialize_static_data): ...here.
 833
 834 2019-06-25  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 837         (tui_display_registers_from, tui_check_register_values): Update.
 838         (tui_display_register): Remove win_info parameter; update.
 839         (tui_get_register): Change type of parameters.
 840         * tui/tui-data.h (struct tui_data_element): Remove.
 841         (union tui_which_element) <data>: Remove.
 842         <data_window>: Change type.
 843         (struct tui_data_item_window): New.
 844         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 845         case.  Add assert.
 846         (~tui_data_item_window): New destructor.
 847         (free_content_elements): Remove DATA_ITEM_WIN case.
 848
 849 2019-06-25  Tom Tromey  <tom@tromey.com>
 850
 851         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 852         Remove.
 853
 854 2019-06-25  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui-data.h (struct tui_command_element): Remove.
 857         (union tui_which_element) <command>: Remove.
 858         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 859         assert.
 860         (free_content_elements): Remove CMD_WIN case.
 861
 862 2019-06-25  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-layout.c (tui_set_layout): Update.
 865         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 866         * tui/tui-data.c (layout_def): Update.
 867
 868 2019-06-25  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 871         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 872         (tui_source_window_base::set_new_height): Update.
 873         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 874         Update.
 875         (tui_set_locator_fullname, tui_set_locator_info)
 876         (tui_show_frame_info): Update.
 877         * tui/tui-source.c (tui_set_source_content)
 878         (tui_source_is_displayed): Update.
 879         * tui/tui-layout.c (show_source_disasm_command, show_data)
 880         (show_source_or_disasm_and_command): Update.
 881         * tui/tui-disasm.c (tui_set_disassem_content)
 882         (tui_get_begin_asm_address): Update.
 883         * tui/tui-data.h (struct tui_locator_element): Remove.
 884         (union tui_which_element) <locator>: Remove.
 885         (struct tui_locator_window): New.
 886         (tui_locator_win_info_ptr): Change return type.
 887         * tui/tui-data.c (_locator): Change type.
 888         (tui_locator_win_info_ptr): Change return type.
 889         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 890         (tui_alloc_content): Add assert.
 891
 892 2019-06-25  Tom Tromey  <tom@tromey.com>
 893
 894         * tui/tui-winsource.c
 895         (tui_exec_info_window::maybe_allocate_content): New method.
 896         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 897         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 898         (make_source_or_disasm_window): Add cast.
 899         * tui/tui-data.h (union tui_which_element) <simple_string>:
 900         Remove.
 901         (struct tui_source_info): New.
 902         (struct tui_source_window_base) <execution_info>: Change type.
 903         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 904         case, and add assert.
 905         (tui_alloc_content): Add assert.
 906
 907 2019-06-25  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 910         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 911         * tui/tui-data.c (tui_alloc_win_info): Remove.
 912
 913 2019-06-25  Tom Tromey  <tom@tromey.com>
 914
 915         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 916         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 917         can_highlight.
 918
 919 2019-06-25  Tom Tromey  <tom@tromey.com>
 920
 921         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 922         make_visible_with_new_height method.
 923         (tui_win_info::make_visible_with_new_height): New method.
 924         (tui_source_window_base::do_make_visible_with_new_height)
 925         (tui_data_window::do_make_visible_with_new_height)
 926         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 927         (make_visible_with_new_height): Remove.
 928         (tui_resize_all, tui_adjust_win_heights): Use
 929         make_visible_with_new_height method.
 930         * tui/tui-data.h (struct tui_win_info)
 931         <do_make_visible_with_new_height, make_visible_with_new_height>:
 932         New methods.
 933         (struct tui_source_window_base, struct tui_data_window)
 934         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 935         methods.
 936
 937 2019-06-25  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 940         method.
 941         (update_tab_width): Call update_tab_width method.
 942         * tui/tui-data.h (struct tui_win_info)
 943         (struct tui_source_window_base) <update_tab_width>: New methods.
 944
 945 2019-06-25  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 948         parameter.
 949         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 950         parameter.
 951         (tui_gen_win_info::make_visible): Update.
 952         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 953         parameter.
 954         * tui/tui-data.h (enum tui_box): New enum.
 955         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 956
 957 2019-06-25  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 960         init_and_make_win for EXEC_INFO_WIN.
 961         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 962         longer inline.
 963         (struct tui_win_info) <~tui_win_info>: Inline.
 964         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 965         Don't declare.
 966         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 967         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 968         Remove.
 969         (tui_initialize_static_data): Update.
 970         (~tui_gen_win_info): Handle more cleanup here.
 971         (~tui_source_window_base): Delete "execution_info".
 972         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 973
 974 2019-06-25  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-layout.c (make_command_window): Don't set
 977         can_highlight.
 978         (show_source_disasm_command): Call the reset method.
 979         (show_data): Don't set can_highlight.  Call the reset method.
 980         (tui_gen_win_info::reset): Rename from init_gen_win_info
 981         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 982         (show_source_or_disasm_and_command): Call the reset method.
 983         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 984         (struct tui_cmd_window): Set can_highlight.
 985
 986 2019-06-25  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 989         from make_visible.
 990         (tui_make_visible, tui_make_invisible): Rewrite.
 991         (tui_win_info::make_visible): Remove.
 992         (tui_source_window_base::make_visible): Update.
 993         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 994         method.  Moved from...
 995         (struct tui_win_info) <make_visible>: ...here.
 996
 997 2019-06-25  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-winsource.c
1000         (tui_source_window_base::do_scroll_horizontal): Remove direction
1001         parameter.
1002         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1003         direction parameter.
1004         * tui/tui-win.c (tui_win_info::forward_scroll)
1005         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1006         (tui_win_info::right_scroll): Update.
1007         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1008         direction parameter.
1009         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1010         direction parameter.
1011         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1012         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1013         Remove direction parameter.
1014         (struct tui_source_window_base, struct tui_source_window)
1015         (struct tui_disasm_window, struct tui_data_window)
1016         (struct tui_cmd_window): Update.
1017
1018 2019-06-25  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-winsource.h (tui_set_exec_info_content)
1021         (tui_show_exec_info_content, tui_erase_exec_info_content)
1022         (tui_clear_exec_info_content, tui_update_exec_info): Change
1023         argument to tui_source_window_base.
1024         * tui/tui-winsource.c (tui_set_exec_info_content)
1025         (tui_show_exec_info_content, tui_erase_exec_info_content)
1026         (tui_clear_exec_info_content, tui_update_exec_info): Change
1027         argument to tui_source_window_base.
1028
1029 2019-06-25  Tom Tromey  <tom@tromey.com>
1030
1031         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1032         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1033
1034 2019-06-25  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1037         check.
1038
1039 2019-06-25  Tom Tromey  <tom@tromey.com>
1040
1041         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1042         type to void.
1043         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1044         type to void.
1045         * tui/tui-source.c (tui_set_source_content): Update.
1046         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1047
1048 2019-06-25  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-win.c (window_name_completer, tui_set_focus)
1051         (tui_all_windows_info): Use name method.
1052         * tui/tui-data.h (struct tui_gen_win_info)
1053         (struct tui_source_window, struct tui_disasm_window)
1054         (struct tui_data_window, struct tui_cmd_window) <name>: New
1055         method.
1056         (tui_win_name): Don't declare.
1057         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1058         (tui_win_name): Remove.
1059
1060 2019-06-25  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-winsource.h (tui_update_source_window)
1063         (tui_update_source_window_as_is): Change parameter type.
1064         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1065         to be a tui_source_window_base.
1066         (tui_update_source_window_as_is): Likewise.
1067         * tui/tui-win.c (make_visible_with_new_height): Update.
1068
1069 2019-06-25  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui-winsource.c (tui_erase_source_content)
1072         (tui_show_source_content, tui_show_exec_info_content)
1073         (tui_erase_exec_info_content): Use refresh_window method.
1074         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1075         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1076         from tui_refresh_win.
1077         (tui_data_window::refresh_window): New method.
1078         (tui_win_info::refresh, tui_source_window_base::refresh)
1079         (tui_refresh_all): Use refresh_window method.
1080         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1081         method.
1082         * tui/tui-regs.c (tui_display_register): Call refresh_window
1083         method.
1084         * tui/tui-layout.c (show_source_disasm_command)
1085         (show_source_or_disasm_and_command): Call refresh_window method.
1086         * tui/tui-data.h (struct tui_gen_win_info)
1087         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1088         New method.
1089
1090 2019-06-25  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui.c (tui_rl_other_window, tui_enable)
1093         (tui_is_window_visible, tui_get_command_dimension): Update.
1094         * tui/tui-winsource.c (tui_update_source_window_as_is)
1095         (tui_clear_source_content, tui_erase_source_content)
1096         (tui_show_source_line, tui_source_window_base::refill)
1097         (tui_source_window_base::do_scroll_horizontal)
1098         (tui_source_window_base::set_is_exec_point_at)
1099         (tui_update_breakpoint_info, tui_set_exec_info_content)
1100         (tui_alloc_source_buffer, tui_line_is_displayed)
1101         (tui_addr_is_displayed): Update.
1102         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1103         (tui_check_and_display_highlight_if_needed)
1104         (tui_win_info::make_visible, tui_win_info::refresh)
1105         (tui_refresh_all): Update.
1106         * tui/tui-windata.c (tui_first_data_item_displayed)
1107         (tui_delete_data_content_windows, tui_erase_data_content)
1108         (tui_display_all_data, tui_data_window::refresh_all)
1109         (tui_check_data_values): Update.
1110         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1111         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1112         (tui_win_info::backward_scroll, tui_refresh_all_win)
1113         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1114         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1115         (tui_source_window_base::set_new_height)
1116         (tui_data_window::set_new_height)
1117         (make_invisible_and_set_new_height)
1118         (make_visible_with_new_height, new_height_ok)
1119         (parse_scrolling_args): Update.
1120         * tui/tui-stack.c (tui_show_frame_info): Update.
1121         * tui/tui-source.c (tui_set_source_content)
1122         (tui_set_source_content_nil, tui_source_is_displayed)
1123         (tui_source_window::do_scroll_vertical): Update.
1124         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1125         (tui_display_registers_from, tui_display_reg_element_at_line)
1126         (tui_check_register_values, tui_reg_command): Update.
1127         * tui/tui-layout.c (tui_default_win_height)
1128         (show_source_disasm_command, show_data, init_and_make_win)
1129         (show_source_or_disasm_and_command): Update.
1130         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1131         (tui_redisplay_readline, tui_mld_flush)
1132         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1133         (tui_getc): Update.
1134         * tui/tui-disasm.c (tui_set_disassem_content)
1135         (tui_disasm_window::do_scroll_vertical): Update.
1136         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1137         Now virtual.
1138         (struct tui_win_info): Derive from tui_gen_win_info.
1139         <~tui_win_info>: Mark as override.
1140         <generic>: Remove member.
1141         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1142         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1143         (~tui_data_window, ~tui_win_info)
1144         (tui_free_all_source_wins_content): Update.
1145         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1146
1147 2019-06-25  Tom Tromey  <tom@tromey.com>
1148
1149         * tui/tui-layout.c (init_and_make_win): Use new.
1150         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1151         destructor, initializers.
1152         (tui_alloc_generic_win_info): Don't declare.
1153         * tui/tui-data.c (_locator): Add argument to constructor.
1154         (source_win, disasm_win): New globals.
1155         (exec_info): Remove.
1156         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1157         Update.
1158         (tui_alloc_generic_win_info): Remove.
1159         (init_content_element): Use new.
1160         (tui_win_info::tui_win_info): Update.
1161         (free_content_elements) <case DATA_WIN>: Use delete.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1166         * tui/tui-windata.c (tui_first_data_item_displayed)
1167         (tui_delete_data_content_windows): Update.
1168         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1169         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1170         (tui_display_registers_from, tui_check_register_values): Update.
1171         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1172         pointer.
1173         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1174         window.
1175         (tui_free_data_content): Update.
1176         (free_content_elements) <case DATA_WIN>: Free the window.
1177
1178 2019-06-25  Tom Tromey  <tom@tromey.com>
1179
1180         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1181         Update.
1182         * tui/tui-layout.c (make_command_window)
1183         (show_source_disasm_command, show_data, init_and_make_win)
1184         (show_source_or_disasm_and_command): Update.
1185         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1186         method.
1187         <can_highight, is_highlighted>: Now bool.
1188         (tui_set_win_highlight): Don't declare.
1189         * tui/tui-data.c (tui_set_win_highlight): Remove.
1190
1191 2019-06-25  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-wingeneral.c (make_visible): Remove check of window
1194         type.
1195
1196 2019-06-25  Tom Tromey  <tom@tromey.com>
1197
1198         * tui/tui-win.c (tui_win_info::max_height)
1199         (tui_cmd_window::max_height): New methods.
1200         (new_height_ok): Call max_height.
1201         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1202         <max_height>: New method.
1203
1204 2019-06-25  Tom Tromey  <tom@tromey.com>
1205
1206         * tui/tui-win.c (tui_source_window_base::set_new_height)
1207         (tui_data_window::set_new_height): New methods.
1208         (make_invisible_and_set_new_height): Call set_new_height method.
1209         * tui/tui-data.h (struct tui_win_info)
1210         (struct tui_source_window_base, struct tui_data_window)
1211         <set_new_height>: New method.
1212
1213 2019-06-25  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1216         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1217         tui_refresh_data_win.
1218         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1219         method.
1220         (tui_refresh_all_win): Call the refresh_all method.
1221         (tui_set_focus): Likewise.
1222         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1223         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1224         Likewise.
1225
1226 2019-06-25  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-winsource.h (tui_refill_source_window)
1229         (tui_set_is_exec_point_at): Don't declare.
1230         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1231         (tui_source_window_base::refill): Rename from
1232         tui_refill_source_window.
1233         (tui_source_window_base::do_scroll_horizontal): Update.
1234         (tui_source_window_base::set_is_exec_point_at): Rename from
1235         tui_set_is_exec_point_at.
1236         (tui_update_all_breakpoint_info): Update.
1237         * tui/tui-stack.c (tui_show_frame_info): Update.
1238         * tui/tui-layout.c (show_data): Add cast.
1239         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1240         * tui/tui-data.h (struct tui_source_window_base) <refill,
1241         set_is_exec_point_at>: New methods.
1242         (tui_source_windows, tui_add_to_source_windows): Update types.
1243         (tui_add_to_source_windows): Remove redundant declaration.
1244         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1245         (tui_source_windows): Change return type.
1246         (tui_clear_source_windows_detail): Update.
1247         (tui_add_to_source_windows): Change type of parameter.
1248         (tui_free_all_source_wins_content): Update.
1249
1250 2019-06-25  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-wingeneral.c (tui_win_info::refresh)
1253         (tui_source_window_base::refresh): New methods.
1254         (tui_refresh_all): Call the refresh method.
1255         * tui/tui-data.h (struct tui_win_info)
1256         (struct tui_source_window_base) <refresh>: New method.
1257
1258 2019-06-25  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui.h (tui_is_window_visible): Return bool.
1261         * tui/tui.c (tui_is_window_visible): Return bool.
1262         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1263         (tui_make_visible, tui_make_invisible)
1264         (tui_win_info::make_visible)
1265         (tui_source_window_base::make_visible, make_all_visible)
1266         (tui_make_all_visible, tui_make_all_invisible): Update.
1267         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1268         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1269         bool.
1270         (struct tui_win_info, struct tui_source_window_base)
1271         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1272         * tui/tui-data.c (tui_init_generic_part): Update.
1273
1274 2019-06-25  Tom Tromey  <tom@tromey.com>
1275
1276         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1277         (tui_source_window_base::make_visible): New methods.
1278         (make_all_visible): Make method call.
1279         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1280         (struct tui_source_window_base, struct tui_cmd_window): Override
1281         make_visible.
1282         (tui_win_is_source_type): Don't declare.
1283         * tui/tui-data.c (tui_win_is_source_type): Remove.
1284
1285 2019-06-25  Tom Tromey  <tom@tromey.com>
1286
1287         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1288         NULL check.
1289
1290 2019-06-25  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1293         Inline constructor.  Add initializers for members.
1294         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1295         constructors; now inline in class.
1296
1297 2019-06-25  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-regs.c (tui_show_registers): Update.
1300         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1301         bool.
1302         * tui/tui-data.c (tui_data_window::clear_detail)
1303         (tui_data_window): Update.
1304
1305 2019-06-25  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-windata.c (tui_display_all_data)
1308         (tui_display_data_from_line, tui_display_data_from)
1309         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1310         Update.
1311         * tui/tui-regs.c (tui_last_regs_line_no)
1312         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1313         (tui_show_registers, tui_show_register_group)
1314         (tui_display_registers_from, tui_display_reg_element_at_line)
1315         (tui_display_registers_from_line, tui_check_register_values)
1316         (tui_reg_next, tui_reg_prev): Update.
1317         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1318         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1319         tui_data_window.
1320         (struct tui_win_info) <detail>: Remove.  Add new fields from
1321         tui_data_info.
1322         (TUI_DATA_WIN): Add cast.
1323         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1324         (~tui_data_window): Simplify.
1325
1326 2019-06-25  Tom Tromey  <tom@tromey.com>
1327
1328         * tui/tui-layout.c (show_source_disasm_command)
1329         (show_source_or_disasm_and_command): Update.
1330         * tui/tui-io.c (update_cmdwin_start_line)
1331         (tui_redisplay_readline): Update.
1332         * tui/tui-data.h (struct tui_command_info): Remove.
1333         (struct tui_win_info) <detail>: Remove command_info member.
1334         (struct tui_data_window) <start_line>: New member, from
1335         tui_command_info.
1336         (TUI_CMD_WIN): Add casts.
1337
1338 2019-06-25  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-winsource.c (tui_update_source_window)
1341         (tui_refill_source_window)
1342         (tui_source_window_base::do_scroll_horizontal)
1343         (tui_update_breakpoint_info, tui_set_exec_info_content)
1344         (tui_show_exec_info_content, tui_erase_exec_info_content)
1345         (tui_clear_exec_info_content): Update.
1346         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1347         Update.
1348         * tui/tui-win.c (make_invisible_and_set_new_height)
1349         (make_visible_with_new_height): Update.
1350         * tui/tui-source.c (tui_set_source_content)
1351         (tui_show_symtab_source): Update.
1352         * tui/tui-layout.c (extract_display_start_addr)
1353         (show_source_disasm_command, show_data)
1354         (make_source_or_disasm_window)
1355         (show_source_or_disasm_and_command): Update.
1356         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1357         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1358         "gdbarch".
1359         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1360         to tui_source_window_base.
1361         (struct tui_win_info) <detail>: Remove source_info member.
1362         (struct tui_source_window_base) <has_locator>: Inline.
1363         Move contents from tui_source_info; rename has_locator member to
1364         m_has_locator.
1365         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1366         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1367         header file.
1368         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1369         Simplify.
1370         (tui_free_all_source_wins_content): Cast to
1371         tui_source_window_base.
1372
1373 2019-06-25  Tom Tromey  <tom@tromey.com>
1374
1375         * tui/tui-win.c (make_invisible_and_set_new_height)
1376         (make_visible_with_new_height): Call has_locator method.
1377         * tui/tui-layout.c (show_source_disasm_command, show_data)
1378         (show_source_or_disasm_and_command): Update for bool change.
1379         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1380         (tui_win_info) <has_locator>: New method.
1381         (struct tui_source_window_base) <has_locator>: New method.
1382         (tui_win_has_locator): Don't declare.
1383         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1384         from tui_win_has_locator.
1385         (tui_source_window_base): Use false, not FALSE.
1386
1387 2019-06-25  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1390         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1391         clear_detail method directly.
1392         (tui_clear_win_detail): Remove.
1393
1394 2019-06-25  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1397         "this", not TUI_DISASM_WIN.
1398
1399 2019-06-25  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1402         declare.
1403         * tui/tui-winsource.c
1404         (tui_source_window_base::do_scroll_horizontal): Rename from
1405         tui_horizontal_source_scroll.
1406         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1407         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1408         from tui_vertical_data_scroll.
1409         * tui/tui-win.h (tui_scroll): Don't declare.
1410         * tui/tui-win.c (tui_win_info::forward_scroll)
1411         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1412         (tui_win_info::right_scroll): Rename and update.
1413         (tui_scroll_forward_command, tui_scroll_backward_command)
1414         (tui_scroll_left_command, tui_scroll_right_command): Update.
1415         (tui_scroll): Remove.
1416         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1417         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1418         from tui_vertical_source_scroll.
1419         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1420         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1421         from tui_vertical_disassem_scroll.
1422         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1423         do_scroll_horizontal>: New methods.
1424         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1425         Likewise.
1426         (struct tui_source_window_base): Add do_scroll_horizontal.
1427         (struct tui_source_window, struct tui_disasm_window): Add
1428         do_scroll_vertical.
1429         (struct tui_data_window, struct tui_cmd_window): Add
1430         do_scroll_horizontal and do_scroll_vertical.
1431         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1432
1433 2019-06-25  Tom Tromey  <tom@tromey.com>
1434
1435         * tui/tui-data.h (struct tui_source_window_base): New struct.
1436         (struct tui_source_window): Derive from tui_source_window_base.
1437         (struct tui_disasm_window): New struct.
1438         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1439         from tui_source_window::clear_detail.
1440         (tui_source_window_base): Rename from tui_source_window.
1441         (~tui_source_window_base): Rename from ~tui_source_window.
1442         (tui_alloc_win_info): Create a tui_disasm_window.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-data.h (struct tui_source_window)
1447         (struct tui_data_window): Declare destructors.
1448         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1449         destructors.
1450         (tui_win_info): Simplify.
1451
1452 2019-06-25  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-winsource.c (tui_display_main)
1455         (tui_update_source_windows_with_addr)
1456         (tui_update_all_breakpoint_info): Update.
1457         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1458         (new_height_ok, parse_scrolling_args): Update.
1459         * tui/tui-stack.c (tui_show_frame_info): Update.
1460         * tui/tui-data.h (struct tui_list): Remove.
1461         (tui_source_windows): Return a reference to a std::vector.
1462         * tui/tui-data.c (source_windows): Now a std::vector.
1463         (tui_source_windows): Change return type.
1464         (tui_clear_source_windows): Rewrite.
1465         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1466         (tui_free_all_source_wins_content): Rewrite.
1467
1468 2019-06-25  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1471         (struct tui_data_window, struct tui_cmd_window): Declare
1472         clear_detail method.
1473         * tui/tui-data.c (tui_source_window::clear_detail)
1474         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1475         methods.
1476         (tui_clear_win_detail): Simplify.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-layout.c (make_source_window, make_disasm_window)
1481         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1482         Return the new window.
1483         (show_source_disasm_command, show_data)
1484         (show_source_or_disasm_and_command): Update.
1485
1486 2019-06-25  Tom Tromey  <tom@tromey.com>
1487
1488         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1489         parameter.  Return the new window.
1490         (show_source_disasm_command): Update and remove NULL check.
1491         (show_source_or_disasm_and_command): Update.
1492
1493 2019-06-25  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1496
1497 2019-06-25  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-data.h (struct tui_win_info): Make constructor
1500         protected.  Make destructor virtual.  Add initializers.
1501         (tui_source_window, tui_data_window, tui_cmd_window): New
1502         classes.
1503         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1504         constructor.  Add "type" parameter.
1505         (tui_source_window, tui_data_window, tui_cmd_window): New
1506         constructors.
1507         (tui_alloc_win_info): Instantiate the appropriate subclass.
1508
1509 2019-06-25  Tom Tromey  <tom@tromey.com>
1510
1511         * tui/tui-win.c (tui_resize_all): Use delete.
1512         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1513         destructor.
1514         (tui_free_window): Don't declare.
1515         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1516         Update.
1517
1518 2019-06-25  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-data.h (struct tui_win_info): Add constructor.
1521         * tui/tui-data.c (tui_alloc_win_info): Use new.
1522         (tui_free_window): Use delete.
1523
1524 2019-06-22  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1527         declare.
1528         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1529
1530 2019-06-22  Tom Tromey  <tom@tromey.com>
1531
1532         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1533         declare.
1534         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1535
1536 2019-06-22  Tom de Vries  <tdevries@suse.de>
1537
1538         * dwarf2read.c (create_addrmap_from_aranges)
1539         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1540         instead of '%zu'.
1541
1542 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1543
1544         * dwarf2read.h (dwarf2_section_info_def): Remove.
1545         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1546         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1547         std::vector<dwarf2_section_info>.
1548         (struct dwo_file) <~dwo_file>: Remove.
1549         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1550         types field.
1551         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1552         (dwarf2_read_debug_names): Likewise.
1553         (create_debug_types_hash_table): Change parameter type to
1554         array_view, adjust code accordingly.
1555         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1556         (partial_die_info::fixup): Likewise.
1557         (determine_prefix): Likewise.
1558         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1559
1560 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1561
1562         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1563         gdb_bfd_ref_ptr.
1564         <~dwo_file>: Remove call to gdb_bfd_unref.
1565         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1566         gdb_bfd_ref_ptr::get.
1567
1568 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1569
1570         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1571         type to htab_up.
1572         * dwarf2read.c (struct dwo_file): Initialize fields.
1573         <~dwo_file>: New.
1574         (free_dwo_file): Remove, move content to ~dwo_file.
1575         (struct dwo_file_deleter): Remove.
1576         (dwo_file_up>: Remove custom deleter.
1577         (free_dwo_files): Remove.
1578         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1579         dwo_files.
1580         (process_skeletonless_type_units): Call unique_ptr::get.
1581         (allocate_dwo_file_hash_table): Add deleter to created hash
1582         table.  Change return type to htab_up.
1583         (lookup_dwo_file_slot): Don't memset dwo_file, call
1584         unique_ptr::get.
1585         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1586         (create_dwo_unit_in_dwp_v2): Likewise.
1587         (open_and_init_dwo_file): Likewise.
1588         (free_dwo_file_from_slot): Remove.
1589
1590 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1591
1592         * dwarf2read.h (struct dwarf2_section_info) <readin,
1593         is_virtual>: Change type to bool.
1594         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1595         true instead of 1.
1596
1597 2019-06-19  Tom Tromey  <tom@tromey.com>
1598
1599         * tui/tui-data.h (tui_init_content_element): Don't declare.
1600
1601 2019-06-19  Tom Tromey  <tom@tromey.com>
1602
1603         * tui/tui-data.h (tui_init_win_info): Don't declare.
1604
1605 2019-06-19  Tom de Vries  <tdevries@suse.de>
1606
1607         * dwarf2read.h (abstract_to_concrete): Change type to
1608         std::unordered_map<sect_offset, std::vector<sect_offset>,
1609         gdb::hash_enum<sect_offset>>.
1610
1611 2019-06-19  Tom Tromey  <tromey@adacore.com>
1612
1613         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1614         EVAL_AVOID_SIDE_EFFECTS specially.
1615
1616 2019-06-19  Tom Tromey  <tromey@adacore.com>
1617
1618         * source-cache.c (highlighter): New global.
1619         (source_cache::get_source_lines): Create a highlighter on demand.
1620
1621 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1622
1623         * defs.h (deprecated_interactive_hook): Delete declaration.
1624         * interps.c (clear_interpreter_hooks): Remove use of
1625         deprecated_interactive_hook.
1626         * top.c (deprecated_interactive_hook): Delete definition.
1627         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1628
1629 2019-06-18  Tom de Vries  <tdevries@suse.de>
1630
1631         PR gdb/24515
1632         * dwarf2read.h (abstract_to_concrete): Change type from
1633         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1634         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1635         * dwarf2read.c (read_variable): Update.
1636         (dwarf2_fetch_die_loc_sect_off): Update.
1637
1638 2019-06-17  Tom de Vries  <tdevries@suse.de>
1639
1640         PR gdb/24617
1641         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1642         accessing parent[parent_len - 1].
1643
1644 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1645
1646         PR gdb/24364
1647         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1648         call dtrace_process_dof with NULL dof.
1649
1650 2019-06-16  Tom de Vries  <tdevries@suse.de>
1651
1652         PR gdb/24445
1653         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1654
1655 2019-06-16  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1658         (make_all_visible): Use address of member.
1659
1660 2019-06-16  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1663         (tui_free_window, free_content, free_content_elements): Remove
1664         unnecessary cast.
1665         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1666         cast.
1667         * tui/tui-regs.c (tui_show_register_group)
1668         (tui_display_registers_from, tui_display_reg_element_at_line):
1669         Remove unnecessary cast.
1670
1671 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1672
1673         * linux-nat.c (normal_mask): Delete.
1674         (_initialize_linux_nat): Don't initialise normal_mask.
1675
1676 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1677
1678         PR gdb/24445
1679         * dwarf-index-write.h (write_psymtabs_to_index): Add
1680         dwz_basename parameter.
1681         * dwarf-index-write.c (write_gdbindex): Move file writing to
1682         write_gdbindex_1.  Change return type void.
1683         (assert_file_size): Move up, remove filename parameter.
1684         (write_gdbindex_1): New function.
1685         (write_debug_names): Change return type to void, call
1686         assert_file_size.
1687         (struct index_wip_file): New struct.
1688         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1689         file logic to index_wip_file.  Write index for dwz file if
1690         needed.
1691         (save_gdb_index_command): Pass basename of dwz file, if present.
1692         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1693         build-id of dwz file, if present.
1694         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1695         (dwarf2_get_dwz_file): Likewise.
1696         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1697         (dwarf2_get_dwz_file): Likewise.
1698
1699 2019-06-16  Tom Tromey  <tom@tromey.com>
1700
1701         * coffread.c (process_coff_symbol): Use xstrdup.
1702         * value.c (create_internalvar): Use xstrdup.
1703
1704 2019-06-16  Tom Tromey  <tom@tromey.com>
1705
1706         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1707         * breakpoint.c (stopin_command, stopat_command)
1708         (until_break_command, decode_location_default): Remove unnecessary
1709         cast.
1710         * utils.c (subset_compare): Remove unnecessary cast.
1711         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1712         cast.
1713         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1714         cast.
1715         * infcmd.c (path_command): Remove unnecessary cast.
1716         * coffread.c (decode_type): Remove unnecessary cast.
1717         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1718         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1719         * tui/tui-stack.c (tui_show_locator_content)
1720         (tui_show_frame_info): Remove unnecessary cast.
1721         * tui/tui-win.c (tui_scroll_forward_command)
1722         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1723         (parse_scrolling_args): Remove unnecessary cast.
1724         * tui/tui-data.c (init_win_info, tui_del_window)
1725         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1726         (free_content_elements): Remove unnecessary cast.
1727         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1728         unnecessary cast.
1729         * tui/tui-source.c (tui_set_source_content)
1730         (tui_vertical_source_scroll): Remove unnecessary cast.
1731         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1732         cast.
1733         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1734         * tui/tui-regs.c (tui_display_registers_from)
1735         (tui_display_register): Remove unnecessary cast.
1736         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1737         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1738         (make_visible): Remove unnecessary cast.
1739         * tui/tui-winsource.c (tui_erase_source_content)
1740         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1741         unnecessary cast.
1742         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1743         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1744         * stabsread.c (read_type, read_array_type, read_range_type):
1745         Remove unnecessary cast.
1746         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1747         (parse_symbol, parse_type, upgrade_type, parse_external)
1748         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1749         unnecessary cast.
1750         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1751
1752 2019-06-16  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-data.c (tui_alloc_generic_win_info)
1755         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1756         checks.
1757
1758 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1759             Andrew Burgess  <andrew.burgess@embecosm.com>
1760
1761         * f-typeprint.c (f_print_type): Don't return early for not
1762         associated or not allocated types.
1763         (f_type_print_varspec_suffix): Add print_rank parameter and print
1764         ranks of array types in case they dangling.
1765         (f_type_print_base): Add print_rank parameter.
1766
1767 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1768
1769         * NEWS: Mention new MI commands.
1770         * break-catch-throw.c (enum exception_event_kind): Move to
1771         breakpoint.h.
1772         (print_mention_exception_catchpoint): Output text as a single
1773         message.
1774         (catch_exception_command_1): Rename to...
1775         (catch_exception_event): ...this, make non-static, update header
1776         command, and change some parameter types.
1777         (catch_catch_command): Update for changes to
1778         catch_exception_command_1.
1779         (catch_throw_command): Likewise.
1780         (catch_rethrow_command): Likewise.
1781         * breakpoint.c (enum exception_event_kind): Delete.
1782         * breakpoint.h (enum exception_event_kind): Moved here from
1783         break-catch-throw.c.
1784         (catch_exception_event): Declare.
1785         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1786         (mi_cmd_catch_throw): New function.
1787         (mi_cmd_catch_rethrow): New function.
1788         (mi_cmd_catch_catch): New function.
1789         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1790         'catch-catch' entries.
1791         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1792         (mi_cmd_catch_rethrow): Declare.
1793         (mi_cmd_catch_catch): Declare.
1794
1795 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1796
1797         * annotate.c (annotate_source_line): Change return type to void,
1798         update implementation to match.
1799         * annotate.h (annotate_source_line): Change return type to void,
1800         update header comment.
1801         * stack.c (print_frame_info): Don't change what frame information
1802         is printed based on whether annotations are on or not.
1803
1804 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1805
1806         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1807         (annotate_source): Make static.
1808         (annotate_source_line): Moved from source.c and renamed from
1809         identify_source_line.  Update the return type.
1810         * annotate.h (annotate_source): Delete declaration.
1811         (annotate_source_line): Declaration moved from source.h, and
1812         renamed from identify_source_line.  Return type updated.
1813         * source.c (identify_source_line): Moved to annotate.c and renamed
1814         to annotate_source_line.
1815         (info_line_command): Remove check of annotation_level.
1816         * source.h (identify_source_line): Move declaration to annotate.h
1817         and rename to annotate_source_line.
1818         * stack.c: Add 'annotate.h' include.
1819         (print_frame_info): Remove check of annotation_level before
1820         calling annotate_source_line.
1821
1822 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1823
1824         * source-cache.c (source_cache::get_plain_source_lines): Use
1825         open_source_file_with_line_charpos instead of just
1826         open_source_file, remove call to find_source_lines.
1827         (source_cache::get_source_lines): Likewise.
1828         * source.c (find_source_lines): Make static.
1829         (get_filename_and_charpos): Renamed into...
1830         (open_source_file_with_line_charpos): ..this along with changes to
1831         return a scoped_fd, and some other minor clean ups.
1832         (identify_source_line): Use open_source_file_with_line_charpos.
1833         (search_command_helper): Use open_source_file_with_line_charpos
1834         instead of just open_source_file, remove call to
1835         find_source_lines.
1836         * source.h (open_source_file_with_line_charpos): Declare new
1837         function.
1838         (find_source_lines): Delete declaration.
1839
1840 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1841
1842         * source.c (get_filename_and_charpos): Remove fullname
1843         parameter.
1844         (identify_source_line): Update call to get_filename_and_charpos.
1845
1846 2019-06-14  Tom Tromey  <tromey@adacore.com>
1847
1848         PR gdb/24502:
1849         * ui-style.h (skip_ansi_escape): Update comment.
1850         * ui-file.h (class no_terminal_escape_file): New class.
1851         * ui-file.c (no_terminal_escape_file::write)
1852         (no_terminal_escape_file::puts): New methods.
1853         * cli/cli-logging.c (handle_redirections): Use
1854         no_terminal_escape_file.
1855
1856 2019-06-14  Tom Tromey  <tromey@adacore.com>
1857
1858         * NEWS: Move convenience variable news above Python news.
1859
1860 2019-06-14  Tom Tromey  <tom@tromey.com>
1861
1862         * gnulib: Move directory to top-level.
1863         * configure.ac: Don't configure gnulib.
1864         * configure: Rebuild.
1865         * common/common-defs.h: Use new path to gnulib.
1866         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1867         (GNULIB_H): Remove.
1868         (INCGNU): Look in new gnulib location.
1869         (HFILES_NO_SRCDIR): Remove gnulib files.
1870         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1871         (generated_files): Remove GNULIB_H.
1872         ($(LIBGNU), all-lib): Remove targets.
1873         (distclean): Don't mention GNULIB_BUILDDIR.
1874         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1875
1876 2019-06-14  Tom Tromey  <tromey@adacore.com>
1877
1878         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1879         Warn if symbol file does not provide any symbols.
1880
1881 2019-06-14  Tom Tromey  <tromey@adacore.com>
1882
1883         * source.c (find_and_open_source): Respect basenames_may_differ.
1884
1885 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1886
1887         * annotate.c (annotate_breakpoints_invalid): Make use of
1888         scoped_restore_terminal_state.
1889         (annotate_frames_invalid): Likewise.
1890
1891 2019-06-14  Tom Tromey  <tromey@adacore.com>
1892
1893         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1894         allow assignment to an internalvar.
1895
1896 2019-06-14  Tom Tromey  <tromey@adacore.com>
1897
1898         * ada-lex.l: Allow "_" in attribute names.
1899
1900 2019-06-14  Tom Tromey  <tromey@adacore.com>
1901
1902         PR gdb/24653:
1903         * regcache.c (registers_changed): Don't call alloca.
1904         * top.c (execute_command): Don't call alloca.
1905
1906 2019-06-13  Pedro Alves  <palves@redhat.com>
1907
1908         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1909         'expression'.  When parsing an expression, error out if there's
1910         junk after "unlimited".
1911         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1912         (do_set_command): Adjust calls to is_unlimited_literal.
1913
1914 2019-06-13  Pedro Alves  <palves@redhat.com>
1915
1916         * compile/compile.c (make_compile_options_def_group): Add braces
1917         around array_view initializer.
1918         * thread.c (make_thread_apply_all_options_def_group)
1919         (make_thread_apply_all_options_def_group): Likewise.
1920
1921 2019-06-13  Pedro Alves  <palves@redhat.com>
1922
1923         * NEWS (New commands): Mention "maint test-options
1924         require-delimiter", "maint test-options unknown-is-error", "maint
1925         test-options unknown-is-operand" and "maint show
1926         test-options-completion-result".
1927         (New command options, command completion): New section.
1928         (Completion improvements): New section.
1929         Mention that you can abbreviate "unlimited".
1930
1931 2019-06-13  Pedro Alves  <palves@redhat.com>
1932
1933         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1934         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1935         * unittests/cli-utils-selftests.c (test_parse_flags)
1936         (test_parse_flags_qcs): Delete.
1937         (test_cli_utils): Don't call deleted functions.
1938
1939 2019-06-13  Pedro Alves  <palves@redhat.com>
1940
1941         * thread.c: Include "cli/cli-option.h".
1942         (tp_array_compar_ascending): Global.
1943         (tp_array_compar): Delete function.
1944         (tp_array_compar_ascending, tp_array_compar_descending): New
1945         functions.
1946         (ascending_option_def, qcs_flag_option_def)
1947         (thr_qcs_flags_option_defs)
1948         (make_thread_apply_all_options_def_group)
1949         (make_thread_apply_options_def_group): New.
1950         (thread_apply_all_command): Use gdb::option::process_options.
1951         (thread_apply_command_completer)
1952         (thread_apply_all_command_completer): New.
1953         (thread_apply_command): Use gdb::option::process_options.
1954         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1955         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1956         to generate help text of "thread apply".  Adjust "taas"'s help.
1957         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1958         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1959
1960 2019-06-13  Pedro Alves  <palves@redhat.com>
1961
1962         * thread.c (thread_apply_command): Check for invalid TID with
1963         isdigit instead of !isalpha.
1964
1965 2019-06-13  Pedro Alves  <palves@redhat.com>
1966
1967         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1968         (validate_flags_qcs): New.
1969         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1970         (validate_flags_qcs): Declare.
1971         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1972         (make_frame_apply_options_def_group): New.
1973         (frame_apply_command_count): Process options with
1974         gdb::option::process_options.
1975         (frame_apply_completer): New.
1976         (frame_apply_level_completer, frame_apply_all_completer)
1977         (frame_apply_completer): New.
1978         (_initialize_stack): Update help of "frame apply", "frame apply
1979         level", "frame apply all" and "faas" to mention supported options
1980         and install command completers.
1981         * stack.h (frame_apply_all_completer): Declare.
1982         * thread.c: Include "stack.h".
1983         (tfaas_command): Add "--".
1984         (_initialize_thread): Update help "tfaas" to mention supported
1985         options and install command completer.
1986
1987 2019-06-13  Pedro Alves  <palves@redhat.com>
1988
1989         * completer.c (complete_nested_command_line): New.
1990         (gdb_completion_word_break_characters_throw): Add assertion.
1991         * completer.h (complete_nested_command_line): Declare.
1992
1993 2019-06-13  Pedro Alves  <palves@redhat.com>
1994
1995         * stack.c (parse_backtrace_qualifiers): New.
1996         (backtrace_command): Use it.
1997         (backtrace_command_completer): Complete on qualifiers.
1998
1999 2019-06-13  Pedro Alves  <palves@redhat.com>
2000
2001         * frame.c: Include "cli/cli-option.h.
2002         (user_set_backtrace_options): New.
2003         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2004         Delete.
2005         (get_prev_frame): Adjust.
2006         (boolean_option_def, uinteger_option_def)
2007         (set_backtrace_option_defs): New.
2008         (_initialize_frame): Adjust and use
2009         gdb::option::add_setshow_cmds_for_options to install "set
2010         backtrace past-main" and "set backtrace past-entry".
2011         * frame.h: Include "cli/cli-option.h".
2012         (struct frame_print_options): Forward declare.
2013         (print_frame_arguments_all, print_frame_arguments_scalars)
2014         (print_frame_arguments_none): Declare.
2015         (print_entry_values): Delete declaration.
2016         (struct frame_print_options, user_frame_print_options): New.
2017         (struct set_backtrace_options): New.
2018         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2019         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2020         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2021         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2022         (list_args_or_locals): Add frame_print_options parameter.
2023         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2024         * python/py-framefilter.c (enumerate_args): Pass down
2025         USER_FRAME_PRINT_OPTIONS.
2026         * stack.c: Include "cli/cli-option.h".
2027         (print_frame_arguments_all, print_frame_arguments_scalars)
2028         (print_frame_arguments_none): Declare.
2029         (print_raw_frame_arguments, print_entry_values): Delete.
2030         (user_frame_print_options): New.
2031         (boolean_option_def, enum_option_def, frame_print_option_defs):
2032         New.
2033         (struct backtrace_cmd_options): New.
2034         (bt_flag_option_def): New.
2035         (backtrace_command_option_defs): New.
2036         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2037         (print_frame_arg, read_frame_arg, print_frame_args)
2038         (print_frame_info, print_frame): Add frame_print_options parameter
2039         and use it.
2040         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2041         (backtrace_command_1): Add frame_print_options and
2042         backtrace_cmd_options parameters and use them.
2043         (make_backtrace_options_def_group): New.
2044         (backtrace_command): Process command options with
2045         gdb::option::process_options.
2046         (backtrace_command_completer): New.
2047         (_initialize_stack): Extend "backtrace"'s help to mention
2048         supported options.  Install completer for "backtrace".
2049         Install some settings commands with add_setshow_cmds_for_options.
2050
2051 2019-06-13  Pedro Alves  <palves@redhat.com>
2052
2053         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2054         and that "set/show print raw frame-arguments" are now deprecated.
2055
2056         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2057         command.
2058         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2059         * stack.c (_initialize_stack): Install "set/show print
2060         raw-frame-arguments", and deprecate "set/show print raw
2061         frame-arguments".
2062         * valprint.c (_initialize_valprint): Deprecate "set/show print
2063         raw".
2064
2065 2019-06-13  Pedro Alves  <palves@redhat.com>
2066
2067         * compile/compile.c (struct compile_options): New.
2068         (compile_flag_option_def, compile_command_option_defs)
2069         (make_compile_options_def_group): New.
2070         (compile_file_command): Handle options with
2071         gdb::option::process_options.
2072         (compile_file_command_completer): New function.
2073         (compile_code_command): Handle options with
2074         gdb::option::process_options.
2075         (compile_code_command_completer): New function.
2076         (_initialize_compiler): Install completers for "compile code" and
2077         "compile file".  Mention available options in "compile code" and
2078         "compile code"'s help.
2079         * completer.c (advance_to_completion_word): New, factored out from
2080         ...
2081         (advance_to_expression_complete_word_point): ... this.
2082         (advance_to_filename_complete_word_point): New.
2083         * completer.h (advance_to_filename_complete_word_point): New
2084         declaration.
2085
2086 2019-06-13  Pedro Alves  <palves@redhat.com>
2087
2088         * compile/compile.c: Include "cli/cli-option.h".
2089         (compile_print_value): Scope data pointer is now a
2090         value_print_options pointer; adjust.
2091         (compile_print_command): Process options.  Scope data pointer is
2092         now a value_print_options pointer; adjust.
2093         (_initialize_compile): Update "compile print"'s help to include
2094         supported options.  Install a completer for "compile print".
2095         * cp-valprint.c (show_vtblprint, show_objectprint)
2096         (show_static_field_print): Delete.
2097         (_initialize_cp_valprint): Don't install "set print
2098         static-members", "set print vtbl", "set print object" here.
2099         * printcmd.c: Include "cli/cli-option.h" and
2100         "common/gdb_optional.h".
2101         (print_command_parse_format): Rework to fill in a
2102         value_print_options instead of a format_data.
2103         (print_value): Change parameter type from format_data pointer to
2104         value_print_options reference.  Adjust.
2105         (print_command_1): Process options.  Adjust to pass down a
2106         value_print_options.
2107         (print_command_completer): New.
2108         (_initialize_printcmd): Install print_command_completer as
2109         handle_brkchars completer for the "print" command.  Update
2110         "print"'s help to include supported options.
2111         * valprint.c: Include "cli/cli-option.h".
2112         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2113         here from cp-valprint.c.
2114         (boolean_option_def, uinteger_option_def)
2115         (value_print_option_defs, make_value_print_options_def_group):
2116         New.  Use gdb::option::add_setshow_cmds_for_options to install
2117         "set print elements", "set print null-stop", "set print repeats",
2118         "set print pretty", "set print union", "set print array", "set
2119         print address", "set print symbol", "set print array-indexes".
2120         * valprint.h: Include <string> and "cli/cli-option.h".
2121         (make_value_print_options_def_group): Declare.
2122         (print_value): Change parameter type from format_data pointer to
2123         value_print_options reference.
2124         (print_command_completer): Declare.
2125
2126 2019-06-13  Pedro Alves  <palves@redhat.com>
2127
2128         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2129         (COMMON_SFILES): Add maint-test-settings.c.
2130         * cli/cli-decode.c (boolean_enums): New global, factored out from
2131         ...
2132         (add_setshow_boolean_cmd): ... here.
2133         * cli/cli-decode.h (boolean_enums): Declare.
2134         * cli/cli-option.c: New file.
2135         * cli/cli-option.h: New file.
2136         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2137         factored out from ...
2138         (parse_cli_boolean_value(const char *)): ... this.
2139         (is_unlimited_literal): Change parameter type to pointer to
2140         pointer.  Adjust and advance ARG pointer.
2141         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2142         (parse_cli_var_enum): New, factored out from ...
2143         (do_set_command): ... this.  Adjust.
2144         * cli/cli-setshow.h (parse_cli_boolean_value)
2145         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2146         (parse_cli_var_enum): Declare.
2147         * cli/cli-utils.c: Include "cli/cli-option.h".
2148         (get_ulongest): New.
2149         * cli/cli-utils.h (get_ulongest): Declare.
2150         (check_for_argument): New overloads.
2151         * maint-test-options.c: New file.
2152
2153 2019-06-13  Pedro Alves  <palves@redhat.com>
2154
2155         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2156         parse a range if "-" is at the end of the string.
2157
2158 2019-06-13  Pedro Alves  <palves@redhat.com>
2159
2160         * cli/cli-setshow.c (parse_auto_binary_operation)
2161         (parse_cli_boolean_value): Don't allow "o".
2162
2163 2019-06-13  Pedro Alves  <palves@redhat.com>
2164
2165         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2166         * NEWS: Mention maint test-settings KIND.
2167         * maint-test-settings.c: New file.
2168
2169 2019-06-13  Pedro Alves  <palves@redhat.com>
2170
2171         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2172         completer.
2173         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2174         "set" completers.
2175
2176 2019-06-13  Pedro Alves  <palves@redhat.com>
2177
2178         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2179         after item.
2180
2181 2019-06-13  Pedro Alves  <palves@redhat.com>
2182
2183         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2184
2185 2019-06-13  Pedro Alves <palves@redhat.com>
2186
2187         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2188         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2189         call.
2190         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2191         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2192         calls.
2193         (check_for_argument): Skip spaces after argument.
2194
2195 2019-06-13  Pedro Alves  <palves@redhat.com>
2196
2197         * thread.c (thread_apply_command): Adjust TID parsing.
2198         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2199         detected before end of string.
2200         (tid_is_in_list): Error out if LIST is invalid.
2201
2202 2019-06-13  Pedro Alves  <palves@redhat.com>
2203
2204         * completer.c (complete_line_internal_1): Rewind completion word
2205         point.
2206         (completion_tracker::advance_custom_word_point_by): Change
2207         parameter type to int.
2208         * completer.h (completion_tracker::advance_custom_word_point_by):
2209         Likewise.
2210
2211 2019-06-13  Pedro Alves  <palves@redhat.com>
2212
2213         * completer.c (advance_to_completion_word): Handle delimiters.
2214
2215 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2216
2217         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2218
2219 2019-06-11  Tom Tromey  <tom@tromey.com>
2220
2221         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2222         (xmalloc_failed): Move to alloc.c.
2223         * alloc.c: New file.
2224         * Makefile.in (COMMON_SFILES): Add alloc.c.
2225
2226 2019-06-11  Tom Tromey  <tom@tromey.com>
2227
2228         * nat/linux-waitpid.c: Don't include server.h.
2229         (linux_debug): Remove.
2230         (my_waitpid): Update.
2231
2232 2019-06-11  Tom Tromey  <tromey@adacore.com>
2233
2234         * infcall.c (_initialize_infcall): Remove trailing newline from
2235         help.
2236         * user-regs.c (_initialize_user_regs): Remove trailing newline
2237         from help.
2238         * typeprint.c (_initialize_typeprint): Remove trailing newline
2239         from help.
2240         * reverse.c (_initialize_reverse): Remove trailing newlines from
2241         help.
2242         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2243         from help.
2244         * language.c (add_set_language_command): Remove trailing newline
2245         from help.
2246         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2247         help.
2248         * disasm.c (_initialize_disasm): Remove trailing newline from
2249         help.
2250         * top.c (init_main): Remove trailing newline from help.
2251         * interps.c (_initialize_interpreter): Remove trailing newline
2252         from help.
2253         * btrace.c (_initialize_btrace): Remove trailing newlines from
2254         help.
2255         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2256         from help.
2257         * python/python.c (_initialize_python): Remove trailing newline
2258         from help.
2259         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2260         help.
2261         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2262         from help.  Reformat some text.
2263         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2264         from help.
2265         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2266         newline from help.
2267
2268 2019-06-11  Tom Tromey  <tromey@adacore.com>
2269
2270         * darwin-nat.c (darwin_decode_exception_message)
2271         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2272
2273 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * valops.c (value_slice): Check for not allocated or not
2276         associated values.
2277
2278 2019-06-10  Tom de Vries  <tdevries@suse.de>
2279
2280         PR gdb/24618
2281         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2282         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2283         invalid.
2284
2285 2019-06-10  Tom de Vries  <tdevries@suse.de>
2286
2287         PR gdb/24611
2288         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2289         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2290
2291 2019-06-10  Tom de Vries  <tdevries@suse.de>
2292
2293         PR symtab/24545
2294         * symtab.c (struct demangled_name_entry): Add language field.
2295         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2296         static minimal symbol".  Set and use language field.
2297
2298 2019-06-10  Tom Tromey  <tromey@adacore.com>
2299
2300         * ada-lang.c (_initialize_ada_language): Update help text.
2301
2302 2019-06-10  Tom Tromey  <tromey@adacore.com>
2303
2304         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2305         with a newline.
2306         * guile/guile.c (handle_boot_error): Don't end warning with a
2307         newline.
2308         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2309         warning with a newline.
2310         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2311         newline.
2312         (s12z_frame_cache): Likewise.
2313         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2314         a newline.
2315         * solib-svr4.c (disable_probes_interface): Don't end warning with
2316         a newline.
2317         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2318         newline.
2319         * python/python.c (do_finish_initialization): Don't end warning
2320         with a newline.
2321
2322 2019-06-10  Tom Tromey  <tom@tromey.com>
2323
2324         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2325         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2326         gdbpy_enter.
2327
2328 2019-06-10  Tom Tromey  <tromey@adacore.com>
2329
2330         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2331         data.
2332         (elf_new_init): Don't call stabsread_new_init.
2333         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2334         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2335         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2336
2337 2019-06-10  Tom de Vries  <tdevries@suse.de>
2338
2339         PR symtab/16264
2340         PR symtab/24517
2341         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2342
2343 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2344
2345         * source.c (find_and_open_source): Also rewrite relative file
2346         names.
2347
2348 2019-04-26  Amos Bird  <amosbird@gmail.com>
2349
2350         * annotate.c (annotate_thread_exited): Add "thread-exited"
2351         annotation.
2352
2353 2019-06-06  Tom Tromey  <tromey@adacore.com>
2354
2355         * maint.h (class scoped_command_stats): Use
2356         DISABLE_COPY_AND_ASSIGN.
2357         <print_time>: New method.
2358         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2359         print_time.
2360         (scoped_command_stats::print_time): New method.
2361
2362 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2365         instructions of lengths 6 or 8 bytes.
2366
2367 2019-06-04  Pedro Alves  <palves@redhat.com>
2368
2369         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2370
2371         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2372         * breakpoint.c (condition_completer): Likewise.
2373         * cli/cli-dump.c (scan_expression): Likewise.
2374         * common/filestuff.c (mkdir_recursive): Likewise.
2375         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2376         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2377         (gdb_abspath): Likewise.
2378         * compile/compile-cplus-types.c
2379         (compile_cplus_instance::decl_name): Likewise.
2380         * completer.c (complete_explicit_location):
2381         (signal_completer, reg_or_group_completer_1): Likewise.
2382         * cp-support.c (cp_remove_params_if_any): Likewise.
2383         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2384         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2385         * infcmd.c (strip_bg_char): Likewise.
2386         * linespec.c (copy_token_string): Likewise.
2387         * mi/mi-main.c (output_cores): Likewise.
2388         * psymtab.c (psymtab_search_name):
2389         * symfile.c (test_set_ext_lang_command): Likewise.
2390         * target.c (target_fileio_read_stralloc): Likewise.
2391         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2392         * value.c (complete_internalvar): Likewise.
2393
2394 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2395
2396         Add objfile property to gdb.Type.
2397         * NEWS: Mention Python API addition.
2398         * python/py-type.c (typy_get_objfile): New method.
2399
2400 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2401
2402         * NEWS: Mention the new set|show style [title|highlight].
2403         Mention changes to "show style", "help" and "apropos".
2404
2405 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2406
2407         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2408         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2409         instead of print_help_for_command.
2410         (print_doc_of_command): New function.
2411         (help_list): Add 'apropos -v word' suggestion.
2412         (print_help_for_command): Style the command name using title style.
2413         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2414         (_initialize_cli_cmds): Describe -v in apropos_command help.
2415
2416 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2417
2418         * cli/cli-style.h (cli_style_option): Add name in constructor,
2419         add m_name class member, add constructor with intensity,
2420         add name class function.
2421         (cli_style_option::add_setshow_commands): Remove name argument.
2422         (highlight_style, title_style): New styles.
2423         * cli/cli-style.c (do_show): New function that shows a style
2424         characteristic styling the style name with itself.
2425         (set_style_name): New function.
2426         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2427         Update all callers according to the changes in cli/cli-style.h.
2428         * utils.h (fputs_highlighted): New function.
2429         * utils.c (fputs_highlighted): Likewise.
2430
2431 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2432
2433         * NEWS: Mention new pipe command and new convenience variables.
2434
2435 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2436
2437         * cli/cli-cmds.c (pipe_command): New function.
2438         (_initialize_cli_cmds): Call add_com for pipe_command.
2439         Define | as an alias for pipe.
2440         (exit_status_set_internal_vars): New function.
2441         (shell_escape): Call exit_status_set_internal_vars.
2442         cli/cli-decode.c (find_command_name_length): Recognize | as
2443         a single character command.
2444
2445 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2446
2447         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2448         top.c (execute_command_to_ui_file): New function, mostly a copy
2449         of execute_command_to_string.
2450         (execute_command_to_string): Implement by calling
2451         execute_command_to_ui_file.
2452
2453 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2454
2455         * top.h (saved_command_line): Remove declaration.
2456         * top.c (previous_saved_command_line, previous_repeat_arguments):
2457         New variables.
2458         (saved_command_line): Make static, define together with other
2459         'repeat variables'.
2460         (dont_repeat): Clear repeat_arguments.
2461         (repeat_previous, get_saved_command_line, save_command_line):
2462         New functions.
2463         (gdb_init): Initialize saved_command_line
2464         and previous_saved_command_line.
2465         * main.c (captured_main_1): Remove saved_command_line initialization.
2466         * event-top.c (handle_line_of_input): Update to use
2467         the new 'repeat' related functions instead of direct access to
2468         saved_command_line.
2469         * command.h (repeat_previous, get_saved_command_line,
2470         save_command_line): New declarations.
2471         (dont_repeat): Add comment.
2472
2473 2019-05-30  Tom Tromey  <tromey@adacore.com>
2474
2475         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2476         Fix comment.
2477         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2478
2479 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2480
2481         PR cli/24587
2482         * completer.c (complete): Initialize variable word.
2483
2484 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2485
2486         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2487         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2488         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2489         'body' is NULL to the outter 'if', protecting the '!is_define'
2490         situation as well.
2491
2492 2019-05-29  Tom Tromey  <tromey@adacore.com>
2493
2494         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2495         (dwarf_unknown): New function.
2496         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2497         (dwarf_type_encoding_name): Use dwarf_unknown.
2498
2499 2019-05-29  Tom Tromey  <tromey@adacore.com>
2500
2501         PR c++/20020:
2502         * cp-valprint.c (cp_print_value_fields): Call
2503         cp_print_static_field inside "try".
2504
2505 2019-05-29  Tom Tromey  <tromey@adacore.com>
2506
2507         * inflow.c (struct terminal_info): Add default operator=.
2508         * configure: Rebuild.
2509         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2510         -Wdeprecated-copy-dtor, -Wredundant-move.
2511
2512 2019-05-29  Tom Tromey  <tromey@adacore.com>
2513
2514         * NEWS: Add entry.
2515         * infcmd.c (print_return_value_1): Handle finish_print
2516         option.
2517         (show_print_finish): New function.
2518         (_initialize_infcmd): Add "set/show print finish" commands.
2519         * valprint.c (user_print_options): Initialize new member.
2520         * valprint.h (struct value_print_options) <finish_print>: New
2521         member.
2522
2523 2019-05-28  Tom Tromey  <tromey@adacore.com>
2524
2525         * ada-lang.c (ada_remove_Xbn_suffix)
2526         (find_old_style_renaming_symbol)
2527         (parse_old_style_renaming): Remove.
2528         (ada_find_renaming_symbol): Don't call
2529         find_old_style_renaming_symbol.
2530         (ada_is_renaming_symbol): Rename from
2531         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2532         bool.  Now static.
2533         (ada_read_var_value): Update and simplify.
2534         * ada-exp.y (write_var_or_type): Remove old code.
2535
2536 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2537
2538         * event-top.c: Remove include comment.
2539         * inflow.c (class scoped_ignore_sigttou): Move from here...
2540         * inflow.h (class scoped_ignore_sigttou): ...to here.
2541         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2542         * top.c:  Remove include comment.
2543
2544 2019-05-27  Tom Tromey  <tom@tromey.com>
2545
2546         * NEWS: Fix typo.
2547
2548 2019-05-22  Tom Tromey  <tromey@adacore.com>
2549
2550         * target.c (target_follow_exec): Constify parameter.
2551         * target-delegates.c: Rebuild.
2552         * remote.c (remote_target::follow_exec): Constify parameter.
2553         * infrun.c (follow_exec): Constify parameter.
2554         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2555         (target_follow_exec): Likewise.
2556
2557 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2558
2559         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2560         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2561
2562 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2563
2564         * NEWS: Add debugredirect and testsuite sections.
2565
2566 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2567
2568         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2569         target descriptions using exclusively floating point register name
2570         aliases.
2571
2572 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2573
2574         PR gdb/18644:
2575         * f-lang.c (build_fortran_types): Handle the case where
2576         gdbarch_floatformat_for_type returns a nullptr.
2577
2578 2019-05-21  Tom de Vries  <tdevries@suse.de>
2579
2580         PR cli/24587
2581         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2582
2583 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2584
2585         PR gdb/18644:
2586         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2587         16-byte floats.
2588         * i386-tdep.c (i386_floatformat_for_type): Use
2589         floatformats_ia64_quad for the 16-byte floating point component
2590         within a fortran 32-byte complex number.
2591
2592 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2593
2594         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2595         delete default constructor.
2596         (find_partial_die): Update to return const struct.
2597         (partial_die_parent_scope): Move variable declaration into scope
2598         of its use and change its type to auto.
2599         (guess_partial_die_structure_name): Likewise.
2600         (partial_die_info::fixup): Likewise.
2601
2602 2019-05-17  Tom Tromey  <tromey@adacore.com>
2603
2604         * source.c (find_and_open_source): Remove cast.
2605
2606 2019-05-17  Tom Tromey  <tromey@adacore.com>
2607
2608         * annotate.c (annotate_source): Make "filename" const.
2609         * annotate.h (annotate_source): Use const.
2610
2611 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2612
2613         * disasm.c (set_disassembler_options): Send errors to stderr.
2614
2615 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2616
2617         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2618         (cli_interp_base::set_logging): Check debug_redirect.
2619         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2620         * cli/cli-logging.c (debug_redirect): Add static variable.
2621         (pop_output_files): Add default param.
2622         (handle_redirections): Print debug setting.
2623         (show_logging_command): Likewise.
2624         (_initialize_cli_logging): Add debugredirect command.
2625         * interps.c (current_interp_set_logging): Add debug_redirect
2626         parameter.
2627         * interps.h (set_logging): Add debug_redirect parameter.
2628         (current_interp_set_logging): Likewise.
2629         * mi/mi-common.h: Likewise.
2630         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2631
2632 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2633             Tom Tromey  <tromey@adacore.com>
2634
2635         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2636         directly.
2637         * cli/cli-interp.h (make_logging_output): Remove declaration.
2638         * cli/cli-logging.c (make_logging_output): Remove function.
2639         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2640         directly.
2641         * ui-file.c (tee_file::tee_file): Remove bools.
2642         (tee_file::~tee_file): Remove deletes.
2643         * ui-file.h (tee_file): Remove bools.
2644
2645 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2646
2647         * mi/mi-cmds.h (mi_cmd_complete): New function.
2648         * mi/mi-main.c (mi_cmd_complete): Likewise.
2649         * mi/mi-cmds.c: Define new MI command -complete.
2650         * NEWS: Mention new -complete command.
2651
2652 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2653
2654         * completer.h (complete): New function.
2655         * completer.c (complete): Likewise.
2656         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2657         function defined in completer.h.
2658
2659 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2660
2661         * MAINTAINERS (Write After Approval): Add myself.
2662
2663 2019-05-17  Tom de Vries  <tdevries@suse.de>
2664
2665         PR gdb/24094
2666         * dwarf2read.c (struct cu_partial_die_info): New struct.
2667         (find_partial_die): Return cu_partial_die_info.
2668         (partial_die_parent_scope, guess_partial_die_structure_name)
2669         (partial_die_info::fixup): Handle new return type of find_partial_die.
2670
2671 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2672
2673         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2674         "std::string", simplifying the algorithm.
2675
2676 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2677
2678         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2679         (stap_static_probe_ops::get_probes): Likewise.
2680
2681 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2682
2683         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2684         '-')" and "else if".
2685         (stap_parse_single_operand): Join checks for
2686         "gdbarch_stap_parse_special_token_p" and
2687         "gdbarch_stap_parse_special_token" in the same "if" statement.
2688         Invert check when verifying for operation on register
2689         displacement.
2690
2691 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2692
2693         * stap-probe.c (stap_get_opcode): Update comment.
2694         (stap_get_expected_argument_type): Likewise.
2695         (handle_stap_probe): Likewise.
2696
2697 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2698
2699         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2700         return type to 'bool'.  Adjust comment.  Use 'bool' when
2701         appropriate.
2702         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2703         * stap-probe.c (stap_parse_argument_1): Likewise.
2704         (stap_is_operator): Likewise.
2705         (stap_is_generic_prefix): Likewise.
2706         (stap_is_register_prefix): Likewise.
2707         (stap_is_register_indirection_prefix): Likewise.
2708         (stap_is_integer_prefix): Likewise.
2709         (stap_generic_check_suffix): Likewise.
2710         (stap_check_integer_suffix): Likewise.
2711         (stap_check_register_suffix): Likewise.
2712         (stap_check_register_indirection_suffix): Likewise.
2713         (stap_parse_register_operand): Likewise.
2714         (stap_parse_single_operand): Likewise.
2715         (stap_parse_argument_1): Likewise.
2716         (stap_probe::get_argument_count): Likewise.
2717         (stap_is_operator): Likewise.
2718
2719 2019-05-16  Tom Tromey  <tromey@adacore.com>
2720
2721         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2722         keyword to foreach.
2723
2724 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2725
2726         * linux-thread-db.c (try_thread_db_load_1): Change return type
2727         to bool.
2728         (try_thread_db_load): Likewise.
2729         (try_thread_db_load_from_pdir_1): Likewise.
2730         (try_thread_db_load_from_pdir): Likewise.
2731         (try_thread_db_load_from_sdir): Likewise.
2732         (try_thread_db_load_from_dir): Likewise.
2733         (thread_db_load_search): Likewise.
2734         (has_libpthread): Likewise.
2735         (thread_db_load): Likewise.
2736
2737 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2738
2739         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2740         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2741         NULL, and complain/return if that's the case.
2742
2743 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2744
2745         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2746         (advance, posn, abstract_read_memory): New functions.
2747         [struct mem_read_abstraction]: New struct.
2748         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2749
2750 2019-05-14  Tom Tromey  <tromey@adacore.com>
2751
2752         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2753         value is not lval_memory.
2754
2755 2019-05-14  Tom Tromey  <tromey@adacore.com>
2756
2757         * solib.c (info_sharedlibrary_command): Style the file name.
2758
2759 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2760
2761         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2762         (aarch64_vnv_type): Likewise.
2763         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2764         * common/tdesc.c: Likewise.
2765         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2766         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2767         * features/aarch64-fpu.xml: Add ieee half view.
2768         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2769         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2770         * gdbtypes.h (struct builtin_type): Likewise.
2771         (struct objfile_type): Likewise.
2772
2773 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2774
2775         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2776         typo.
2777         * location.h (string_to_event_location): Likewise.
2778
2779 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2780
2781         GDB 8.3 released.
2782
2783 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2784
2785         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2786         New variable declaration.
2787         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2788         New variable.
2789         (print_one_breakpoint): Use ui_out::test_flags and new global
2790         variable to compute use_fixed_output.
2791         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2792         Remove.
2793         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2794         (mi_multi_location_breakpoint_output_fixed): Remove.
2795         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2796         new variable.
2797         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2798         fix_multi_location_breakpoint_output flag if version >= 3.
2799         * ui-out.h (enum ui_out_flag)
2800         <fix_multi_location_breakpoint_output>: New enumerator.
2801
2802 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2803
2804         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2805
2806 2019-05-10  Tom Tromey  <tromey@adacore.com>
2807
2808         * ada-lang.c (catch_ada_completer): New function.
2809         (_initialize_ada_language): Use it.
2810
2811 2019-05-10  Tom Tromey  <tromey@adacore.com>
2812
2813         * thread.c (print_thread_info): Make "requested_threads" const.
2814         * gdbthread.h (print_thread_info): Make "requested_threads"
2815         const.
2816         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2817         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2818
2819 2019-05-08  Tom Tromey  <tom@tromey.com>
2820
2821         * gdbtypes.c (objfile_type_data): Change type.
2822         (objfile_type, _initialize_gdbtypes): Update.
2823
2824 2019-05-08  Tom Tromey  <tom@tromey.com>
2825
2826         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2827         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2828         (_initialize_dwarf2_frame): Update.
2829
2830 2019-05-08  Tom Tromey  <tom@tromey.com>
2831
2832         * objc-lang.c (objc_objfile_data): Change type.
2833         (find_methods): Update.
2834         (_initialize_objc_lang): Remove.
2835
2836 2019-05-08  Tom Tromey  <tom@tromey.com>
2837
2838         * stabsread.c (rs6000_builtin_type_data): Change type.
2839         (rs6000_builtin_type, _initialize_stabsread): Update.
2840
2841 2019-05-08  Tom Tromey  <tom@tromey.com>
2842
2843         * mips-tdep.c (mips_pdr_data): Remove.
2844         (_initialize_mips_tdep): Update.
2845
2846 2019-05-08  Tom Tromey  <tom@tromey.com>
2847
2848         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2849         (hppa_init_objfile_priv_data, read_unwind_info)
2850         (find_unwind_entry, _initialize_hppa_tdep): Update.
2851
2852 2019-05-08  Tom Tromey  <tom@tromey.com>
2853
2854         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2855         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2856         on obstack.
2857         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2858
2859 2019-05-08  Tom Tromey  <tom@tromey.com>
2860
2861         * mdebugread.c (basic_type_data): Change type.
2862         (basic_type, _initialize_mdebugread): Update.
2863
2864 2019-05-08  Tom Tromey  <tom@tromey.com>
2865
2866         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2867
2868 2019-05-08  Tom Tromey  <tom@tromey.com>
2869
2870         * nto-tdep.c (nto_inferior_data_reg): Change type.
2871         (nto_inferior_data): Update.
2872         (nto_inferior_data_cleanup, nto_new_inferior_data)
2873         (_initialize_nto_tdep): Remove.
2874         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2875
2876 2019-05-08  Tom Tromey  <tom@tromey.com>
2877
2878         * ada-lang.c (struct ada_inferior_data): Add initializers.
2879         (ada_inferior_data): Change type.
2880         (ada_inferior_data_cleanup): Remove.
2881         (get_ada_inferior_data, ada_inferior_exit)
2882         (struct ada_pspace_data): Add initializers, destructor.
2883         (ada_pspace_data_handle): Change type.
2884         (get_ada_pspace_data): Update.
2885         (ada_pspace_data_cleanup): Remove.
2886
2887 2019-05-08  Tom Tromey  <tom@tromey.com>
2888
2889         * coffread.c (struct coff_symfile_info): Add initializers.
2890         (coff_objfile_data_key): Move lower.  Change type.
2891         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2892         Update.
2893         (coff_free_info): Remove.
2894
2895 2019-05-08  Tom Tromey  <tom@tromey.com>
2896
2897         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2898         (fbsd_pspace_data_handle): Move lower.  Change type.
2899         (get_fbsd_pspace_data): Update.
2900         (fbsd_pspace_data_cleanup): Remove.
2901         (_initialize_fbsd_tdep): Update.
2902
2903 2019-05-08  Tom Tromey  <tom@tromey.com>
2904
2905         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2906         (get_ada_tasks_pspace_data): Update.
2907         (ada_tasks_pspace_data_cleanup): Remove.
2908         (_initialize_tasks): Update.
2909         (ada_tasks_inferior_data_handle): Change type.
2910         (get_ada_tasks_inferior_data): Update.
2911         (ada_tasks_inferior_data_cleanup): Remove.
2912         (struct ada_tasks_pspace_data): Add initializers.
2913
2914 2019-05-08  Tom Tromey  <tom@tromey.com>
2915
2916         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2917         * symfile-debug.c (debug_sym_get_probes): Change type.
2918         * stap-probe.c (handle_stap_probe):
2919         (stap_static_probe_ops::get_probes): Change type.
2920         * probe.h (class static_probe_ops) <get_probes>: Change type.
2921         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2922         (parse_probes_in_pspace): Update.
2923         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2924         Update.
2925         (any_static_probe_ops::get_probes): Change type.
2926         * elfread.c (elfread_data): New typedef.
2927         (probe_key): Change type.
2928         (elf_get_probes): Likewise.  Update.
2929         (probe_key_free): Remove.
2930         (_initialize_elfread): Update.
2931         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2932         Change type.
2933         (dtrace_process_dof_probe, dtrace_process_dof)
2934         (dtrace_static_probe_ops::get_probe): Change type.
2935
2936 2019-05-08  Tom Tromey  <tom@tromey.com>
2937
2938         * xcoffread.c (struct xcoff_symfile_info): Rename from
2939         coff_symfile_info.  Add initializers.
2940         (xcoff_objfile_data_key): Move lower.  Change type.
2941         (XCOFF_DATA): Rewrite.
2942         (xcoff_free_info): Remove.
2943         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2944         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2945         (xcoff_initial_scan): Update.
2946
2947 2019-05-08  Tom Tromey  <tom@tromey.com>
2948
2949         * solib-svr4.c (struct svr4_info): Add initializers and
2950         destructor.
2951         <probes_table>: Now an htab_up.
2952         (solib_svr4_pspace_data): Change type.
2953         (free_probes_table): Simplify.
2954         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2955         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2956         (probes_table_remove_objfile_probes, register_solib_event_probe)
2957         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2958         (_initialize_svr4_solib): Update.
2959
2960 2019-05-08  Tom Tromey  <tom@tromey.com>
2961
2962         * remote.c (remote_pspace_data): Change type.
2963         (remote_pspace_data_cleanup): Remove.
2964         (get_remote_exec_file, set_pspace_remote_exec_file)
2965         (_initialize_remote): Update.
2966
2967 2019-05-08  Tom Tromey  <tom@tromey.com>
2968
2969         * breakpoint.c (breakpoint_objfile_key): Change type.
2970         (get_breakpoint_objfile_data): Update.
2971         (free_breakpoint_objfile_data): Remove.
2972         (_initialize_breakpoint): Update.
2973
2974 2019-05-08  Tom Tromey  <tom@tromey.com>
2975
2976         * linux-tdep.c (struct linux_info): Add initializers.
2977         (linux_inferior_data): Move.  Change type.
2978         (invalidate_linux_cache_inf): Update.
2979         (linux_inferior_data_cleanup): Remove.
2980         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2981
2982 2019-05-08  Tom Tromey  <tom@tromey.com>
2983
2984         * auxv.c (auxv_inferior_data): Move.  Change type.
2985         (auxv_inferior_data_cleanup): Remove.
2986         (invalidate_auxv_cache_inf): Rewrite.
2987         (get_auxv_inferior_data, _initialize_auxv): Update.
2988
2989 2019-05-08  Tom Tromey  <tom@tromey.com>
2990
2991         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2992         (symfile_debug_objfile_data_key): Change type.
2993         (symfile_debug_installed, debug_qf_has_symbols)
2994         (debug_qf_find_last_source_symtab)
2995         (debug_qf_forget_cached_source_info)
2996         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2997         (debug_qf_print_stats, debug_qf_dump)
2998         (debug_qf_expand_symtabs_for_function)
2999         (debug_qf_expand_all_symtabs)
3000         (debug_qf_expand_symtabs_with_fullname)
3001         (debug_qf_map_matching_symbols)
3002         (debug_qf_expand_symtabs_matching)
3003         (debug_qf_find_pc_sect_compunit_symtab)
3004         (debug_qf_map_symbol_filenames)
3005         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3006         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3007         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3008         (debug_sym_read_linetable, debug_sym_relocate): Update.
3009         (symfile_debug_free_objfile): Remove.
3010         (install_symfile_debug_logging, _initialize_symfile_debug):
3011         Update.
3012
3013 2019-05-08  Tom Tromey  <tom@tromey.com>
3014
3015         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3016         allocate_on_obstack.
3017         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3018         (get_dwarf2_per_objfile): Update.
3019         (set_dwarf2_per_objfile): Remove.
3020         (dwarf2_has_info, dwarf2_get_section_info): Update.
3021         (dwarf2_free_objfile): Remove.
3022         (_initialize_dwarf2_read): Update.
3023
3024 2019-05-08  Tom Tromey  <tom@tromey.com>
3025
3026         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3027         initializers.
3028         <unsupported_script_warning_printed,
3029         script_not_found_warning_printed>: Now bool.
3030         (auto_load_pspace_data): Change type.
3031         (~auto_load_pspace_info): Rename from
3032         auto_load_pspace_data_cleanup.
3033         (get_auto_load_pspace_data, init_loaded_scripts_info)
3034         (clear_section_scripts, maybe_print_unsupported_script_warning)
3035         (maybe_print_script_not_found_warning, _initialize_auto_load):
3036         Update.
3037
3038 2019-05-08  Tom Tromey  <tom@tromey.com>
3039
3040         * objfiles.c (objfile_pspace_info): Add destructor and
3041         initializers.
3042         (objfiles_pspace_data): Change type.
3043         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3044         (get_objfile_pspace_data): Update.
3045         (objfiles_bfd_data): Change type.
3046         (get_objfile_bfd_data): Update.
3047         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3048
3049 2019-05-08  Tom Tromey  <tom@tromey.com>
3050
3051         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3052         Change type.
3053         (get_catch_syscall_inferior_data): Update.
3054         (catch_syscall_inferior_data_cleanup): Remove.
3055         (_initialize_break_catch_syscall): Update.
3056
3057 2019-05-08  Tom Tromey  <tom@tromey.com>
3058
3059         * inflow.c (struct terminal_info): Add destructor and
3060         initializers.
3061         (inflow_inferior_data): Change type.
3062         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3063         (get_inflow_inferior_data, inflow_inferior_exit)
3064         (swap_terminal_info, _initialize_inflow): Update.
3065
3066 2019-05-08  Tom Tromey  <tom@tromey.com>
3067
3068         * target-dcache.c (target_dcache_cleanup): Remove.
3069         (target_dcache_aspace_key): Change type.
3070         (target_dcache_init_p, target_dcache_invalidate)
3071         (target_dcache_get, target_dcache_get_or_init)
3072         (_initialize_target_dcache): Update.
3073         * dcache.h (struct dcache_deleter): New.
3074
3075 2019-05-08  Tom Tromey  <tom@tromey.com>
3076
3077         * symtab.c (struct symbol_cache): Add destructor and
3078         initializers.
3079         (symbol_cache_key): Move.  Change type.
3080         (make_symbol_cache, free_symbol_cache): Remove.
3081         (get_symbol_cache): Update.
3082         (symbol_cache_cleanup): Remove.
3083         (ALL_PSPACES, symbol_cache_flush)
3084         (maintenance_print_symbol_cache)
3085         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3086         Update.
3087
3088 2019-05-08  Tom Tromey  <tom@tromey.com>
3089
3090         * symtab.c (struct main_info): Add destructor and initializers.
3091         (main_progspace_key): Move.  Change type.
3092         (get_main_info): Update.
3093         (main_info_cleanup): Remove.
3094         (_initialize_symtab): Update.
3095
3096 2019-05-08  Tom Tromey  <tom@tromey.com>
3097
3098         * registry.h (DECLARE_REGISTRY): Define the _key class.
3099
3100 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * NEWS: Merge two 'New commands' sections.
3103
3104 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3105
3106         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3107         parameter and use Ada language definition instead.
3108         (ada_val_print_ptr): Remove unused language parameter.
3109         (ada_val_print_num): Remove language parameter and use Ada language
3110         definition instead.
3111         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3112         parameter.
3113         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3114         parameter and use Ada language definition instead.
3115         (ada_val_print_1): Update all ada_val_print_xxx calls.
3116         Remove language parameter.
3117         (ada_val_print): Update ada_val_print_1 call.
3118
3119 2019-05-08  Tom Tromey  <tromey@adacore.com>
3120
3121         * remote.c (remote_hw_watchpoint_limit)
3122         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3123         Now static.
3124
3125 2019-05-08  Tom Tromey  <tromey@adacore.com>
3126
3127         * maint.c (_initialize_maint_cmds): Move initialization code to
3128         remote.c.
3129         (watchdog, show_watchdog): Move to remote.c.
3130         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3131         "watchdog" static.
3132         (_initialize_remote): Move initialization code from maint.c.
3133         * defs.h (watchdog): Don't declare.
3134
3135 2019-05-08  Tom Tromey  <tromey@adacore.com>
3136
3137         * tui/tui-interp.c: Include main.h.
3138         * interps.c: Include main.h.
3139         * main.h (interpreter_p): Declare.
3140         * defs.h (interpreter_p): Don't declare.
3141
3142 2019-05-08  Tom Tromey  <tromey@adacore.com>
3143
3144         * dwarf2loc.c: Include dwarf2read.h.
3145         * defs.h (read_unsigned_leb128): Don't declare.
3146         * dwarf2read.h (read_unsigned_leb128): Declare.
3147
3148 2019-05-08  Tom Tromey  <tromey@adacore.com>
3149
3150         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3151         method.
3152
3153 2019-05-08  Tom Tromey  <tromey@adacore.com>
3154
3155         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3156         when no wrap column is set.
3157
3158 2019-05-08  Tom Tromey  <tromey@adacore.com>
3159
3160         * c-lang.c (c_get_string): Handle non-C-style arrays.
3161
3162 2019-05-08  Tom Tromey  <tromey@adacore.com>
3163
3164         * typeprint.c (print_offset_data::update): Print the bit offset,
3165         not the number of bits remaining.
3166
3167 2019-05-08  Tom Tromey  <tromey@adacore.com>
3168
3169         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3170         padding at end of comment.
3171
3172 2019-05-08  Tom Tromey  <tromey@adacore.com>
3173
3174         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3175         Compare main types.
3176
3177 2019-05-06  Tom Tromey  <tom@tromey.com>
3178
3179         * common/scoped_mmap.c: Include common-defs.h.
3180         * common/scoped_mmap.h: Don't include config.h.
3181
3182 2019-05-04  Tom Tromey  <tom@tromey.com>
3183
3184         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3185         (struct aarch64_call_info): Add initializers.
3186         <si>: Now a std::vector.
3187         (pass_on_stack, aarch64_push_dummy_call): Update.
3188
3189 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3190             Tom Tromey  <tom@tromey.com>
3191
3192         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3193         (ppc_threads): Now a std::vector.  Now static.
3194         (hwdebug_find_thread_points_by_tid)
3195         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3196         Update.
3197
3198 2019-05-04  Tom Tromey  <tom@tromey.com>
3199
3200         * arc-tdep.c (arc_tdesc_init): Return bool.
3201
3202 2019-05-04  Tom Tromey  <tom@tromey.com>
3203
3204         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3205         Use gdb_assert_not_reached.
3206
3207 2019-05-04  Tom Tromey  <tom@tromey.com>
3208
3209         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3210         "false".
3211
3212 2019-05-04  Tom Tromey  <tom@tromey.com>
3213
3214         * arc-tdep.c (arc_tdesc_init): Use bool.
3215
3216 2019-05-04  Tom Tromey  <tom@tromey.com>
3217
3218         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3219
3220 2019-05-04  Tom Tromey  <tom@tromey.com>
3221
3222         * cli/cli-cmds.c (valid_command_p): Return bool.
3223
3224 2019-05-04  Tom Tromey  <tom@tromey.com>
3225
3226         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3227         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3228
3229 2019-05-04  Raul Tambre  <raul@tambre.ee>
3230
3231         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3232         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3233         operator for comparison.
3234
3235 2019-05-04  Tom Tromey  <tom@tromey.com>
3236
3237         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3238         (lookup_partial_symbol, print_partial_symbols)
3239         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3240         (psymbol_compare): Update.
3241         (add_psymbol_to_bcache): Clear the entire psymbol.
3242         (maintenance_check_psymtabs): Update.
3243         * psympriv.h (struct partial_symbol): Don't derive from
3244         general_symbol_info.
3245         <obj_section, unrelocated_address, address,
3246         set_unrelocated_address>: Update.
3247         <ginfo>: New member.
3248         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3249         (debug_names::write_psymbols): Update.
3250
3251 2019-05-04  Tom de Vries  <tdevries@suse.de>
3252
3253         * contrib/cc-with-tweaks.sh: Support -n arg.
3254
3255 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3256
3257         * corelow.c (core_target::detach): Ensure frame cache and
3258         register caches are cleared.
3259         inferior.c (exit_inferior_1): Likewise.
3260
3261 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3262             Tom Tromey  <tom@tromey.com>
3263
3264         * dictionary.c (collate_pending_symbols_by_language): Remove
3265         "struct" from foreach.
3266         * symtab.c (lookup_global_symbol_from_objfile)
3267         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3268         foreach.
3269         * ser-tcp.c (net_open): Remove "struct" from foreach.
3270         * objfiles.c (objfile_relocate, objfile_rebase)
3271         (objfile_has_symbols): Remove "struct" from foreach.
3272         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3273         from foreach.
3274         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3275         foreach.
3276         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3277         "struct" from foreach.
3278         * ada-lang.c (create_excep_cond_exprs)
3279         (ada_exception_catchpoint_cond_string): Remove "struct" from
3280         foreach.
3281
3282 2019-05-03  Tom Tromey  <tromey@adacore.com>
3283
3284         * ada-exp.y (convert_char_literal): Check suffix of each
3285         enumerator.
3286
3287 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3288
3289         PR ada/21406:
3290         * ada-exp.y (yywrap): Don't define.
3291         * ada-lex.l (%option): Add noyywrap
3292         (yywrap): Remove.
3293
3294 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3295
3296         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3297         _WIN32_WINNT to the XP level, unless already defined to a higher
3298         level.
3299
3300         * unittests/parse-connection-spec-selftests.c:
3301         * ser-tcp.c:
3302         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3303         override.
3304
3305         * symfile.c (find_separate_debug_file): Remove colon from the
3306         drive spec of DOS/Windows file names of the target, so that the
3307         file name produced from DEBUGDIR and the target's directory will
3308         be valid on DOS/Windows systems.
3309
3310 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3311
3312         * rust-lang.c (val_print_struct): Handle printing structures
3313         containing strings.
3314
3315 2019-05-02  Tom Tromey  <tromey@adacore.com>
3316
3317         * valarith.c (_initialize_valarith): Remove.
3318
3319 2019-05-01  Tom Tromey  <tromey@adacore.com>
3320
3321         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3322         bitfields.
3323
3324 2019-05-01  Tom Tromey  <tromey@adacore.com>
3325
3326         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3327         for big-endian copies.
3328
3329 2019-04-30  Ali Tamur  <tamur@google.com>
3330         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3331         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3332         (read_3_bytes): New function.
3333
3334 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3335
3336         * windows-nat.c (main_thread_id): Delete.
3337         (handle_output_debug_string): Replace main_thread_id by
3338         current_event.dwThreadId.
3339         (fake_create_process): Likewise.
3340         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3341         Do not set main_thread_id.
3342         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3343         current_event.dwThreadId.
3344         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3345
3346 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3347
3348         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3349         Use current_event.dwThreadId instead of main_thread_id.
3350
3351 2019-04-30  Tom Tromey  <tromey@adacore.com>
3352
3353         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3354         (create_excep_cond_exprs): Iterate over program spaces.
3355         (ada_exception_catchpoint_cond_string): Examine all minimal
3356         symbols for exception types.
3357
3358 2019-04-30  Tom Tromey  <tromey@adacore.com>
3359
3360         PR c++/24470:
3361         * dwarf2read.c (process_structure_scope): Handle case where type
3362         has template parameters but no symbol was created.
3363
3364 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3365             Chris January  <chris.january@arm.com>
3366
3367         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3368         qualifier.
3369         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3370
3371 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * f-typeprint.c (f_print_type): Update rules for printing
3374         whitespace.
3375         (f_type_print_varspec_suffix): Likewise.
3376
3377 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3378             Chris January  <chris.january@arm.com>
3379
3380         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3381         function arguments.
3382
3383 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * f-lang.c (build_fortran_types): Change name of void type to
3386         lower case.
3387         * f-typeprint.c (f_type_print_base): Print the name of the void
3388         type, rather than a fixed string.
3389         * f-valprint.c (f_decorations): Use lower case void string.
3390
3391 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3392             Chris January  <chris.january@arm.com>
3393
3394         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3395         types for Fortran.
3396
3397 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3398             Chris January  <chris.january@arm.com>
3399             David Lecomber  <david.lecomber@arm.com>
3400
3401         * f-exp.y (BINOP_INTRINSIC): New token.
3402         (exp): New parser rule handling BINOP_INTRINSIC.
3403         (f77_keywords): Add new builtin procedures.
3404         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3405         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3406         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3407         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3408         (print_unop_subexp_f): New function.
3409         (print_binop_subexp_f): New function.
3410         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3411         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3412         (dump_subexp_body_f): Likewise.
3413         (operator_check_f): Likewise.
3414         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3415         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3416
3417 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3418
3419         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3420         UNOP_KIND.
3421         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3422         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3423         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3424         (operator_length_f): New fuction.
3425         (print_subexp_f): New function.
3426         (op_name_f): New function.
3427         (dump_subexp_body_f): New function.
3428         (operator_check_f): New function.
3429         (exp_descriptor_f): Replace standard expression handling functions
3430         with new functions.
3431         * gdb/fortran-operator.def: New file.
3432         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3433         * gdb/std-operator.def: Remove UNOP_KIND.
3434
3435 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3436
3437         * std-operator.def: Remove unbalanced, stray double quote
3438         character.
3439
3440 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3441             Chris January  <chris.january@arm.com>
3442             Daniel Everett  <daniel.everett@arm.com>
3443             Nick Forrington  <nick.forrington@arm.com>
3444             Richard Bunt  <richard.bunt@arm.com>
3445
3446         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3447         of depth when printing anonymous structs or unions.
3448         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3449         Don't print either the top-level value, or the children if the
3450         max-depth is exceeded.
3451         (ppscm_print_children): When printing the key of a map, allow one
3452         extra level of depth.
3453         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3454         print either the top-level value, or the children if the max-depth
3455         is exceeded.
3456         (print_children): When printing the key of a map, allow one extra
3457         level of depth.
3458         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3459         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3460         (user_print_options): Initialise max_depth field.
3461         (val_print_scalar_or_string_type_p): New function.
3462         (val_print): Check to see if the max depth has been reached.
3463         (val_print_check_max_depth): Define new function.
3464         (show_print_max_depth): New function.
3465         (_initialize_valprint): Add 'print max-depth' option.
3466         * valprint.h (struct value_print_options) <max_depth>: New field.
3467         (val_print_check_max_depth): Declare new function.
3468         * NEWS: Document new feature.
3469
3470 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3471
3472         * ada-lang.c (ada_language_defn): Initialise new field.
3473         * c-lang.c (c_is_string_type_p): New function.
3474         (c_language_defn): Initialise new field.
3475         (cplus_language_defn): Initialise new field.
3476         (asm_language_defn): Initialise new field.
3477         (minimal_language_defn): Initialise new field.
3478         * c-lang.h (c_is_string_type_p): Declare new function.
3479         * d-lang.c (d_language_defn): Initialise new field.
3480         * f-lang.c (f_is_string_type_p): New function.
3481         (f_language_defn): Initialise new field.
3482         * go-lang.c (go_is_string_type_p): New function.
3483         (go_language_defn): Initialise new field.
3484         * language.c (default_is_string_type_p): New function.
3485         (unknown_language_defn): Initialise new field.
3486         (auto_language_defn): Initialise new field.
3487         * language.h (struct language_defn) <la_is_string_type_p>: New
3488         member variable.
3489         (default_is_string_type_p): Declare new function.
3490         * m2-lang.c (m2_language_defn): Initialise new field.
3491         * objc-lang.c (objc_language_defn): Initialise new field.
3492         * opencl-lang.c (opencl_language_defn): Initialise new field.
3493         * p-lang.c (pascal_is_string_type_p): New function.
3494         (pascal_language_defn): Initialise new field.
3495         * rust-lang.c (rust_is_string_type_p): New function.
3496         (rust_language_defn): Initialise new field.
3497
3498 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3499
3500         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3501         New field.
3502         * ada-lang.c (ada_language_defn): Initialise new field.
3503         * c-lang.c (c_language_defn): Likewise.
3504         (cplus_language_defn): Likewise.
3505         (asm_language_defn): Likewise.
3506         (minimal_language_defn): Likewise.
3507         * d-lang.c (d_language_defn): Likewise.
3508         * f-lang.c (f_language_defn): Likewise.
3509         * go-lang.c (go_language_defn): Likewise.
3510         * language.c (unknown_language_defn): Likewise.
3511         (auto_language_defn): Likewise.
3512         * m2-lang.c (m2_language_defn): Likewise.
3513         * objc-lang.c (objc_language_defn): Likewise.
3514         * opencl-lang.c (opencl_language_defn): Likewise.
3515         * p-lang.c (pascal_language_defn): Likewise.
3516         * rust-lang.c (rust_language_defn): Likewise.
3517
3518 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3519
3520         * ada-lang.c (ada_is_character_type): Change return type to bool.
3521         (ada_is_string_type): Likewise.
3522         * ada-lang.h (ada_is_character_type): Update declaration
3523         (ada_is_string_type): Likewise.
3524
3525 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3526
3527         Support style in 'frame|thread apply'
3528
3529         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3530         * record.c (record_start, record_stop): Update callers of
3531         execute_command_to_string with false.
3532         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3533         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3534         methods.
3535         (class string_file): New constructor with term_out parameter.
3536         Override methods term_out and can_emit_style_escape.  New member
3537         term_out.
3538         (class stdio_file): Override can_emit_style_escape.
3539         (class tee_file): Override term_out and can_emit_style_escape.
3540         * utils.h (can_emit_style_escape): Remove.
3541         * utils.c (can_emit_style_escape): Likewise.
3542         Update all callers of can_emit_style_escape (SOMESTREAM) to
3543         SOMESTREAM->can_emit_style_escape.
3544         * source-cache.c (source_cache::get_source_lines): Likewise.
3545         * stack.c (frame_apply_command_count): Call execute_command_to_string
3546         passing the term_out characteristic of the current gdb_stdout.
3547         * thread.c (thr_try_catch_cmd): Likewise.
3548         * top.c (execute_command_to_string): pass term_out parameter
3549         to construct the string_file for the command output.
3550         * ui-file.c (term_cli_styling): New function (most code moved
3551         from utils.c can_emit_style_escape).
3552         (string_file::string_file, string_file::can_emit_style_escape,
3553         stdio_file::can_emit_style_escape, tee_file::term_out,
3554         tee_file::can_emit_style_escape): New functions.
3555
3556 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3557
3558         * NEWS: Mention the new set|show may-call-functions.
3559         * infcall.c (may_call_functions_p): New variable.
3560         (show_may_call_functions_p): New function.
3561         (call_function_by_hand_dummy): Throws an error if not
3562         may-call-functions.
3563         (_initialize_infcall): Call add_setshow_boolean_cmd for
3564         may-call-functions.
3565
3566 2019-04-25  Keith Seitz  <keiths@redhat.com>
3567
3568         PR c++/24367
3569         * cp-support.c (inspect_type): Don't attempt substitutions
3570         of symbol with the same name.
3571
3572 2019-04-25  Tom Tromey  <tromey@adacore.com>
3573
3574         PR gdb/24475:
3575         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3576         static.
3577
3578 2019-04-25  Tom Tromey  <tromey@adacore.com>
3579
3580         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3581         rvalue reference.
3582         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3583         (gdb_xml_parser::parse): Use std::move.
3584         * python/python-internal.h (gdbpy_convert_exception): Take a const
3585         reference.
3586         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3587         std::move.
3588         * python/py-utils.c (gdbpy_convert_exception): Take a const
3589         reference.
3590         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3591         Use std::move.
3592         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3593         Use std::move.
3594         * mi/mi-main.c (mi_print_exception): Take a const reference.
3595         * main.c (handle_command_errors): Take a const reference.
3596         * linespec.c (parse_linespec): Use std::move.
3597         * infcall.c (run_inferior_call): Use std::move.
3598         (call_function_by_hand_dummy): Use std::move.
3599         * exec.c (try_open_exec_file): Use std::move.
3600         * exceptions.h (exception_print, exception_fprintf)
3601         (exception_print_same): Update.
3602         * exceptions.c (print_exception, exception_print)
3603         (exception_fprintf, exception_print_same): Change parameters to
3604         const reference.
3605         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3606         * common/new-op.c: Use std::move.
3607         * common/common-exceptions.h (struct gdb_exception): Add move
3608         constructor.
3609         (struct gdb_exception_error, struct gdb_exception_quit, struct
3610         gdb_quit_bad_alloc): Change constructor to move constructor.
3611         (throw_exception): Change parameter to rvalue reference.
3612         * common/common-exceptions.c (throw_exception): Take rvalue
3613         reference.
3614         * cli/cli-interp.c (safe_execute_command): Use std::move.
3615         * breakpoint.c (insert_bp_location, location_to_sals): Use
3616         std::move.
3617
3618 2019-04-25  Tom Tromey  <tromey@adacore.com>
3619
3620         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3621         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3622         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3623         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3624         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3625         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3626         guile/scm-value.c: Use unpack.
3627         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3628         gdbscm_gdb_exception.
3629         (gdbscm_throw_gdb_exception): Likewise.
3630         (struct gdbscm_gdb_exception): New.
3631         (unpack): New function.
3632         (gdbscm_wrap): Use unpack.
3633
3634 2019-04-25  Tom Tromey  <tromey@adacore.com>
3635
3636         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3637         (gdb_rl_callback_handler): Use std::move.
3638         * common/common-exceptions.h (struct gdb_exception): Add move
3639         assignment operator.
3640         (throw_exception_sjlj): Change "exception" to const reference.
3641         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3642         (throw_exception_sjlj): Change "exception" to const reference.
3643
3644 2019-04-25  Tom Tromey  <tromey@adacore.com>
3645
3646         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3647         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3648         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3649         Update.
3650         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3651         Update.
3652         * mi/mi-interp.c (mi_interp::exec): Update.
3653         * linespec.c (parse_linespec): Update.
3654         * infcall.c (run_inferior_call): Update.
3655         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3656         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3657         (gdbscm_lookup_global_symbol): Update.
3658         * guile/scm-param.c (gdbscm_parameter_value): Update.
3659         * guile/scm-frame.c (gdbscm_frame_read_register)
3660         (gdbscm_frame_read_var): Update.
3661         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3662         * exec.c (try_open_exec_file): Update.
3663         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3664         (gdb_rl_callback_handler): Update.
3665         * common/common-exceptions.h (exception_none): Don't declare.
3666         * common/common-exceptions.c (exception_none): Don't define.
3667         (struct catcher) <exception>: Update.
3668         * cli/cli-interp.c (safe_execute_command): Update.
3669         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3670
3671 2019-04-25  Ali Tamur  <tamur@google.com>
3672
3673         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3674         (read_attribute_value): Likewise.
3675         (dwarf2_read_addr_index): Update comment.
3676         (read_str_index): Add DW_FORM_strx.
3677         (dwarf2_string_attr): Likewise.
3678         (dwarf2_const_value_attr): Likewise.
3679         (dump_die_shallow): Likewise.
3680         (dwarf2_fetch_constant_bytes): Likewise.
3681         (skip_form_bytes): Likewise.
3682         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3683
3684 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3685
3686         PR corefiles/11608
3687         PR corefiles/18187
3688         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3689         OFFSET.  Verify if current mapping contains an ELF header.
3690         (linux_find_memory_regions_full): Adjust call to
3691         dump_mapping_p.
3692
3693 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3694             Kang Li <kanglictf@gmail.com>
3695
3696         PR gdb/21600
3697
3698         * dwarf2-frame.c (read_initial_length): Be consistent about using
3699         unsigned representation of length.
3700         (decode_frame_entry_1): Likewise.  Check for wraparound of
3701         end pointer as well as buffer overflow.
3702
3703 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3704
3705         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3706         "vq".
3707
3708 2019-04-24  Tom Tromey  <tromey@adacore.com>
3709
3710         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3711
3712 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3713
3714         * s12z-tdep.c (s12z_unwind_pc): Delete.
3715         (s12z_unwind_sp): Delete.
3716         (s12z_gdbarch_init): Don't register deleted functions with
3717         gdbarch.
3718
3719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * rl78-tdep.c (rl78_unwind_sp): Delete.
3722         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3723
3724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3725
3726         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3727         (xstormy16_unwind_pc): Delete.
3728         (xstormy16_dummy_id): Delete.
3729         (xstormy16_gdbarch_init): Don't register deleted functions with
3730         gdbarch.
3731
3732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3733
3734         * vax-tdep.c (vax_unwind_pc): Delete.
3735         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3736
3737 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3738
3739         * v850-tdep.c (v850_unwind_sp): Delete.
3740         (v850_unwind_pc): Delete.
3741         (v850_dummy_id): Delete.
3742         (v850_gdbarch_init): Don't register deleted functions with
3743         gdbarch.
3744
3745 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3748         (tilegx_unwind_pc): Delete.
3749         (tilegx_unwind_dummy_id): Delete.
3750         (tilegx_gdbarch_init): Don't register deleted functions with
3751         gdbarch.
3752
3753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3754
3755         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3756         (tic6x_dummy_id): Delete.
3757         (tic6x_gdbarch_init): Don't register deleted functions with
3758         gdbarch.
3759
3760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3761
3762         * sparc-tdep.c (sparc_unwind_pc): Delete.
3763         (sparc32_gdbarch_init): Don't register deleted function with
3764         gdbarch.
3765
3766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3767
3768         * sh-tdep.c (sh_unwind_sp): Delete.
3769         (sh_unwind_pc): Delete.
3770         (sh_dummy_id): Delete.
3771         (sh_gdbarch_init): Don't register deleted functions with
3772         gdbarch.
3773
3774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3775
3776         * score-tdep.c (score_unwind_sp): Delete.
3777         (score_unwind_pc): Delete.
3778         (score_dummy_id): Delete.
3779         (score_gdbarch_init): Don't register deleted functions with
3780         gdbarch.
3781
3782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3783
3784         * rx-tdep.c (rx_unwind_pc): Delete.
3785         (rx_unwind_sp): Delete.
3786         (rx_dummy_id): Delete.
3787         (rx_gdbarch_init): Don't register deleted functions with
3788         gdbarch.  Update comment.
3789
3790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3793         (rs6000_dummy_id): Delete.
3794         (rs6000_gdbarch_init): Don't register deleted functions with
3795         gdbarch.
3796
3797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * or1k-tdep.c (or1k_dummy_id): Delete.
3800         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3801
3802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3803
3804         * nios2-tdep.c (nios2_dummy_id): Delete.
3805         (nios2_unwind_sp): Delete.
3806         (nios2_gdbarch_init): Don't register deleted functions with
3807         gdbarch.
3808
3809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3810
3811         * nds32-tdep.c (nds32_dummy_id): Delete.
3812         (nds32_unwind_pc): Delete.
3813         (nds32_unwind_sp): Delete.
3814         (nds32_gdbarch_init): Don't register deleted functions with
3815         gdbarch.
3816
3817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * msp430-tdep.c (msp430_unwind_pc): Delete.
3820         (msp430_unwind_sp): Delete.
3821         (msp430_dummy_id): Delete.
3822         (msp430_gdbarch_init): Don't register deleted functions with
3823         gdbarch.
3824
3825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3826
3827         * moxie-tdep.c (moxie_unwind_sp): Delete.
3828         (moxie_unwind_pc): Delete.
3829         (moxie_dummy_id): Delete.
3830         (moxie_gdbarch_init): Don't register deleted functions with
3831         gdbarch.
3832
3833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3834
3835         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3836         (mn10300_unwind_pc): Delete.
3837         (mn10300_unwind_sp): Delete.
3838         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3839         mn10300_unwind_sp.
3840         (mn10300_frame_unwind_init): Don't register deleted functions with
3841         gdbarch.
3842
3843 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * mep-tdep.c (mep_unwind_pc): Delete.
3846         (mep_unwind_sp): Delete.
3847         (mep_dummy_id): Delete.
3848         (mep_gdbarch_init): Don't register deleted functions with
3849         gdbarch.
3850
3851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3852
3853         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3854         (m68hc11_unwind_sp): Delete.
3855         (m68hc11_gdbarch_init): Don't register deleted functions with
3856         gdbarch.
3857
3858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * m32r-tdep.c (m32r_unwind_sp): Delete.
3861         (m32r_unwind_pc): Delete.
3862         (m32r_dummy_id): Delete.
3863         (m32r_gdbarch_init): Don't register deleted functions with
3864         gdbarch.
3865
3866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3867
3868         * m32c-tdep.c (m32c_unwind_pc): Delete.
3869         (m32c_unwind_sp): Delete.
3870         (m32c_dummy_id): Delete.
3871         (m32c_gdbarch_init): Don't register deleted functions with
3872         gdbarch.
3873
3874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3875
3876         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3877         (lm32_unwind_pc): Delete.
3878         (lm32_dummy_id): Delete.
3879         (lm32_gdbarch_init): Don't register deleted functions with
3880         gdbarch.
3881
3882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3883
3884         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3885         (iq2000_unwind_pc): Delete.
3886         (iq2000_dummy_id): Delete.
3887         (iq2000_gdbarch_init): Don't register deleted functions with
3888         gdbarch.
3889
3890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3891
3892         * nds32-tdep.c (nds32_type_align): Delete.
3893         (nds32_push_dummy_call): Use type_align instead.
3894
3895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3896
3897         * arm-tdep.c (arm_type_align): Only handle vector override case.
3898         (arm_push_dummy_call): Use type_align.
3899         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3900
3901 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3904         case.
3905         (pass_on_stack): Use type_align.
3906         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3907         function.
3908
3909 2019-04-23  Tom Tromey  <tromey@adacore.com>
3910
3911         * dwarf2read.c (line_header::file_name_at): Remove unused
3912         overload.
3913
3914 2019-04-23  Tom de Vries  <tdevries@suse.de>
3915
3916         PR gdb/24438
3917         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3918         invocation.
3919
3920
3921 2019-03-27  Ali Tamur  <tamur@google.com>
3922
3923         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3924         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3925         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3926         (dwarf_expr_context::get_addr_index): Likewise
3927         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3928         (symbol_needs_eval_context::get_addr_index): Likewise
3929         (disassemble_dwarf_expression): Add DW_OP_addrx
3930         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3931         (read_cutu_die_from_dwo): Update comment
3932         (skip_one_die): Add DW_FORM_addrx
3933         (read_attribute_value): Likewise
3934         (var_decode_location): Add DW_OP_addrx
3935         (dwarf2_const_value_attr): Add DW_FORM_addrx
3936         (dump_die_shallow): Likewise
3937         (dwarf2_fetch_constant_bytes): Likewise
3938         (decode_locdesc): Add DW_OP_addrx
3939         (skip_form_bytes): Add DW_FORM_addrx
3940
3941 2019-04-22  Ali Tamur  <tamur@google.com>
3942
3943         * MAINTAINERS (Write After Approval): Add self.
3944
3945 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3946
3947         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3948         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3949         (open_symbol_file_object): Likewise.
3950         (svr4_default_sos): Add info parameter.
3951         (svr4_read_so_list): Likewise.
3952         (svr4_current_sos_direct): Adjust functions calls to pass down
3953         info.
3954         (svr4_current_sos_1): Add info parameter.
3955         (svr4_current_sos): Call get_svr4_info, pass info down to
3956         svr4_current_sos_1.
3957         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3958         get_svr4_info.
3959         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3960         get_svr4_info.
3961         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3962         to get_svr4_info.
3963         (probes_table_remove_objfile_probes): Likewise.
3964         (register_solib_event_probe): Add info parameter.
3965         (solist_update_incremental): Pass info parameter down to
3966         svr4_read_so_list.
3967         (disable_probes_interface): Add info parameter.
3968         (svr4_handle_solib_event): Pass current_program_space to
3969         get_svr4_info.  Adjust disable_probes_interface cleanup.
3970         (svr4_create_probe_breakpoints): Add info parameter, pass it
3971         down to register_solib_event_probe.
3972         (svr4_create_solib_event_breakpoints): Add info parameter,
3973         pass it down to svr4_create_probe_breakpoints.
3974         (enable_break): Pass info down to
3975         svr4_create_solib_event_breakpoints.
3976         (svr4_solib_create_inferior_hook): Pass current_program_space to
3977         get_svr4_info.
3978         (svr4_clear_solib): Likewise.
3979
3980 2019-04-22  Pedro Alves  <palves@redhat.com>
3981
3982         * solib-svr4.c (svr4_free_objfile_observer): New.
3983         (probe_and_action::objfile): New field.
3984         (probes_table_htab_remove_objfile_probes)
3985         (probes_table_remove_objfile_probes): New functions.
3986         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3987         in the new probe_and_action.  Don't store the probe in 'lookup'.
3988         (svr4_create_probe_breakpoints): Pass objfile to
3989         register_solib_event_probe.
3990         (_initialize_svr4_solib): Register a free_objfile observer.
3991
3992 2019-04-19  Tom Tromey  <tom@tromey.com>
3993
3994         * common/queue.h: Remove.
3995
3996 2019-04-19  Tom Tromey  <tom@tromey.com>
3997
3998         * event-loop.c: Don't include "common/queue.h".
3999
4000 2019-04-19  Tom Tromey  <tom@tromey.com>
4001
4002         * remote.c (remote_target): Use delete.
4003         * remote-notif.h: Include <list>, not "common/queue.h".
4004         (notif_client_p): Remove typedef.
4005         (remote_notif_state): Add constructor, destructor, initializer.
4006         <notif_queue>: Now a std::list.
4007         (remote_notif_state_xfree): Don't declare.
4008         * remote-notif.c (remote_notif_process, handle_notification)
4009         (remote_notif_state_allocate): Update.
4010         (~remote_notif_state): Rename from remote_notif_state_xfree.
4011
4012 2019-04-19  Tom Tromey  <tom@tromey.com>
4013
4014         * symfile.c (reread_symbols): Update.
4015         * objfiles.c (objfile_register_static_link)
4016         (objfile_lookup_static_link): Update
4017         (~objfile) Don't delete static_links.
4018         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4019
4020 2019-04-19  Tom Tromey  <tom@tromey.com>
4021
4022         * type-stack.h (struct type_stack) <insert>: Constify string.
4023         * type-stack.c (type_stack::insert): Constify string.
4024         * gdbtypes.h (lookup_template_type): Update.
4025         (address_space_name_to_int): Update.
4026         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4027         const.
4028         (lookup_template_type): Make name const.
4029         * c-exp.y: Update rules.
4030         (lex_one_token, classify_name, classify_inner_name)
4031         (c_print_token): Update.
4032         * p-exp.y: Update rules.
4033         (yylex): Update.
4034         * f-exp.y: Update rules.
4035         (yylex): Update.
4036         * d-exp.y: Update rules.
4037         (lex_one_token, classify_name, classify_inner_name): Update.
4038         * parse.c (write_dollar_variable, copy_name): Return std::string.
4039         * parser-defs.h (copy_name): Change return type.
4040         * m2-exp.y: Update rules.
4041         (yylex): Update.
4042         * go-exp.y (lex_one_token): Update.
4043         Update rules.
4044         (classify_unsafe_function, classify_packaged_name)
4045         (classify_name, yylex): Update.
4046
4047 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4048
4049         * configure.ac: add --enable-source-highlight switch.
4050         * configure: Regenerate.
4051         * top.c (print_gdb_version): plumb --enable-source-highlight
4052         status to "show configuration".
4053
4054 2019-04-19  Tom Tromey  <tromey@adacore.com>
4055
4056         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4057         Check ADA_TYPE_P.
4058         (empty_record, ada_template_to_fixed_record_type_1)
4059         (template_to_static_fixed_type)
4060         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4061         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4062         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4063         macros.
4064
4065 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4066
4067         PR symtab/24423:
4068         * source.c (print_source_lines_base): Advance "iter" when a
4069         control character is seen.
4070
4071 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4072
4073         * inferior.h (struct infcall_suspend_state_deleter):
4074         Catch exception in destructor to avoid crash.
4075
4076 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4077
4078         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4079         close to the add_com "shell".
4080
4081 2019-04-18  Tom Tromey  <tromey@adacore.com>
4082
4083         * process-stratum-target.h (class process_stratum_target)
4084         <stratum>: Add "final".
4085
4086 2019-04-17  Tom Tromey  <tromey@adacore.com>
4087
4088         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4089         against nullptr before use.
4090
4091 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4092
4093         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4094
4095 2019-04-17  Jim Wilson  <jimw@sifive.com>
4096             Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4099         code read might fail, assume 4-byte breakpoint in that case.
4100
4101 2019-04-15  Leszek Swirski  <leszeks@google.com>
4102
4103         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4104         rather than a hand-rolled POD check when checking for forced MEMORY
4105         classification.
4106
4107 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4108
4109         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4110         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4111         function.
4112         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4113         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4114         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4115         declaration.
4116
4117 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4118
4119         * aarch64-linux-nat.c
4120         (aarch64_linux_nat_target::thread_architecture): Add override.
4121         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4122         each VQ.
4123
4124 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4125
4126         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4127
4128 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4129
4130         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4131         target types of size 96-bits, add some additional comments, and
4132         check that the builtin type we found was the correct size.
4133
4134 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4135
4136         * utils.c (prompt_for_continue): Don't restore the styling at the
4137         end, as applied_style has the wrong value.  This fixes styling in
4138         long lists of file names that are interrupted by the "Continue?"
4139         prompt.
4140
4141 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4142
4143         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4144         * c-lang.c (c_language_defn): Likewise.
4145         (cplus_language_defn): Likewise.
4146         (asm_language_defn): Likewise.
4147         (minimal_language_defn): Likewise.
4148         * d-lang.c (d_language_defn): Likewise.
4149         * f-lang.c (f_language_defn): Likewise.
4150         * go-lang.c (go_language_defn): Likewise.
4151         * language.c (unknown_language_defn): Likewise.
4152         (auto_language_defn): Likewise.
4153         * language.h (struct language_defn): Remove la_magic field.
4154         (LANG_MAGIC): Delete.
4155         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4156         * objc-lang.c (objc_language_defn): Likewise.
4157         * opencl-lang.c (opencl_language_defn): Likewise.
4158         * p-lang.c (pascal_language_defn): Likewise.
4159         * rust-lang.c (rust_language_defn): Likewise.
4160
4161 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4162
4163         * riscv-tdep.c (riscv_type_align): New function.
4164         (riscv_type_alignment): Delete.
4165         (riscv_arg_location): Use 'type_align'.
4166         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4167
4168 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4169
4170         * gdbtypes.c (type_align): A struct with no non-static fields also
4171         has alignment of 1.
4172
4173 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4176         component to 0.
4177         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4178         member.
4179         (riscv_struct_info::analyse): New implementation using new
4180         analyse_inner member function.
4181         (riscv_struct_info::field_offset): New member function.
4182         (riscv_struct_info::m_offsets): New member variable.
4183         (riscv_struct_info::analyse_inner): New private member function,
4184         takes the old implementation of riscv_struct_info::analyse but
4185         extended to track field offsets.
4186         (riscv_call_arg_struct): Update the struct folding special cases
4187         to handle cases where empty C++ structs, which are non-zero
4188         length, are found.
4189         (riscv_arg_location): Initialise the length of each location, a
4190         non-zero length now indicates the location is in use.
4191         (riscv_push_dummy_call): Allow for the first location having a
4192         non-zero offset when setting up arguments.
4193         (riscv_return_value): Likewise, but for return values.
4194
4195 2019-04-11  Tom Tromey  <tromey@adacore.com>
4196
4197         * utils.c (internal_vproblem): Make "msg" const.
4198
4199 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4200
4201         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4202         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4203         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4204         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4205
4206 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4207
4208         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4209         function.
4210         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4211         of amd64_collect_native_gregset.
4212         (amd64_linux_nat_target::store_registers): Likewise.
4213
4214 2019-04-10  Tom Tromey  <tom@tromey.com>
4215
4216         * symtab.c (lookup_global_symbol_from_objfile)
4217         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4218         * objfiles.h (class separate_debug_iterator): New.
4219         (class separate_debug_range): New.
4220         (struct objfile) <separate_debug_objfiles>: New method.
4221         (objfile_separate_debug_iterate): Don't declare.
4222         * objfiles.c (separate_debug_iterator::operator++): Rename from
4223         objfile_separate_debug_iterate.
4224         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4225         iterator.
4226         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4227         iterator.
4228
4229 2019-04-10  Tom Tromey  <tom@tromey.com>
4230
4231         * symfile.c (reread_symbols): Remove old comment.
4232         * objfiles.c (free_all_objfiles): Fix a typo.
4233
4234 2019-04-10  Tom Tromey  <tom@tromey.com>
4235
4236         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4237         * minsyms.c (lookup_minimal_symbol): Use foreach.
4238         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4239         (lookup_minimal_symbol_solib_trampoline): Likewise.
4240         * symfile.c (reread_symbols): Use foreach.
4241
4242 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4243             Tom Tromey  <tromey@adacore.com>
4244
4245         PR rust/24414:
4246         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4247         (rust_lex_int_test): Change "value" to be LONGEST.
4248         (rust_lex_tests): Add test for long integer literal.
4249
4250 2019-04-09  Tom Tromey  <tromey@adacore.com>
4251
4252         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4253         to bool.
4254         (extended_remote_target::attach): Update.
4255         (remote_target::remote_notice_new_inferior): Update.
4256         (remote_target::add_current_inferior_and_thread): Update.
4257         * inferior.c (exit_inferior_1): Use "false".
4258         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4259
4260 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4261
4262         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4263         the "start" command.
4264
4265 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4266
4267         * python/py-inferior.c (infpy_thread_from_thread_handle):
4268         Adjust comments to reflect renaming of thread_from_thread_handle
4269         to thread_from_handle.  Adjust keywords.  Fix type error message.
4270         (inferior_object_methods): Add thread_from_handle.  Retain
4271         thread_from_thread_handle, but mark it as deprecated.
4272
4273 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4274
4275         * gdbthread.h (find_thread_by_handle): Revise declaration.
4276         * thread.c (find_thread_by_handle): Likewise.  Adjust
4277         implementation too.
4278         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4279         support for buffer objects as handles.
4280
4281 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4282
4283         * python/py-infthread.c (thpy_thread_handle): New function.
4284         (thread_object_methods): Register thpy_thread_handle.
4285
4286 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4287
4288         * gdbthread.h (thread_to_thread_handle): Declare.
4289         * thread.c (gdbtypes.h): Include.
4290         (thread_to_thread_handle): New function.
4291
4292         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4293         (target_thread_info_to_thread_handle): Declare.
4294         * target.c (target_thread_info_to_thread_handle): New function.
4295         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4296         * target-delegates.c: Regenerate.
4297
4298         * linux-thread-db.c (class thread_db_target): Add method
4299         thread_info_to_thread_handle.
4300         (thread_db_target::thread_info_to_thread_handle): Define.
4301         * remote.c (class remote_target): Add new method
4302         thread_info_to_thread_handle.
4303         (remote_target::thread_info_to_thread_handle): Define.
4304
4305 2019-04-08  Pedro Alves  <palves@redhat.com>
4306
4307         * common/common-exceptions.c (throw_exception): Don't create
4308         named object to throw; throw directly.
4309         (throw_it): Likewise.  Don't initialize gdb_exception::message
4310         here, with new; pass FMT and AP to the ctor instead.
4311         * common/common-exceptions.h: Include <string>.
4312         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4313         const char *, va_list)): New ctor.  Use std::make_shared.
4314         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4315         errors)): Delete.
4316         (gdb_exception_error::gdb_exception_error(enum errors, const char
4317         *, va_list)): New.
4318         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4319         Add assertion.
4320         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4321         errors)): Delete.
4322         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4323         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4324         Add assertion.
4325
4326 2019-04-08  Tom Tromey  <tom@tromey.com>
4327
4328         * valops.c (value_rtti_indirect_type): Replace throw_exception
4329         with throw.
4330         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4331         with throw.
4332         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4333         throw.
4334         * target.c (target_translate_tls_address): Replace throw_exception
4335         with throw.
4336         * stack.c (frame_apply_command_count): Replace throw_exception
4337         with throw.
4338         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4339         throw.
4340         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4341         with throw.
4342         * rs6000-tdep.c (rs6000_frame_cache)
4343         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4344         * remote.c: Replace throw_exception with throw.
4345         * record-full.c (record_full_message, record_full_wait_1)
4346         (record_full_restore): Replace throw_exception with throw.
4347         * record-btrace.c:
4348         (get_thread_current_frame_id, record_btrace_start_replaying)
4349         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4350         (cmd_record_btrace_start): Replace throw_exception with throw.
4351         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4352         throw.
4353         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4354         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4355         * linespec.c:
4356         (find_linespec_symbols): Replace throw_exception with throw.
4357         * infrun.c (displaced_step_prepare, resume): Replace
4358         throw_exception with throw.
4359         * infcmd.c (post_create_inferior): Replace throw_exception with
4360         throw.
4361         * inf-loop.c (inferior_event_handler): Replace throw_exception
4362         with throw.
4363         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4364         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4365         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4366         (get_prev_frame_always, get_frame_pc_if_available)
4367         (get_frame_address_in_block_if_available, get_frame_language):
4368         Replace throw_exception with throw.
4369         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4370         throw_exception with throw.
4371         * eval.c (fetch_subexp_value, evaluate_var_value)
4372         (evaluate_funcall, evaluate_subexp_standard): Replace
4373         throw_exception with throw.
4374         * dwarf2loc.c (call_site_find_chain)
4375         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4376         Replace throw_exception with throw.
4377         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4378         with throw.
4379         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4380         throw.
4381         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4382         * completer.c (complete_line_internal): Replace throw_exception
4383         with throw.
4384         * compile/compile-object-run.c (compile_object_run): Replace
4385         throw_exception with throw.
4386         * cli/cli-script.c (process_next_line): Replace throw_exception
4387         with throw.
4388         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4389         (btrace_enable, btrace_maint_update_pt_packets): Replace
4390         throw_exception with throw.
4391         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4392         throw_exception with throw.
4393         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4394         throw_exception with throw.
4395         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4396         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4397         * aarch64-tdep.c (aarch64_make_prologue_cache)
4398         (aarch64_make_stub_cache): Replace throw_exception with throw.
4399
4400 2019-04-08  Tom Tromey  <tom@tromey.com>
4401
4402         * common/common-exceptions.c (throw_exception): Rename from
4403         throw_exception_cxx.  Remove old copy.  Make argument const.
4404         (throw_it): Create and throw exception objects directly.
4405         * common/common-exceptions.h (throw_exception): Make argument
4406         const.
4407         (struct gdb_exception_error): Add constructor.
4408         (struct gdb_exception_quit): Add constructor.
4409
4410 2019-04-08  Tom Tromey  <tom@tromey.com>
4411
4412         * common/common-exceptions.h (exception_rethrow): Don't declare.
4413         (TRY_SJLJ): Update comment.
4414         (TRY, CATCH, END_CATCH): Remove.
4415         * common/common-exceptions.c (exception_rethrow): Remove.
4416
4417 2019-04-08  Tom Tromey  <tom@tromey.com>
4418
4419         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4420         Remove.
4421         (gdb_exception_error): Rename from
4422         gdb_exception_RETURN_MASK_ERROR.
4423         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4424         (gdb_quit_bad_alloc): Update.
4425         * aarch64-tdep.c: Update.
4426         * ada-lang.c: Update.
4427         * ada-typeprint.c: Update.
4428         * ada-valprint.c: Update.
4429         * amd64-tdep.c: Update.
4430         * arch-utils.c: Update.
4431         * break-catch-throw.c: Update.
4432         * breakpoint.c: Update.
4433         * btrace.c: Update.
4434         * c-varobj.c: Update.
4435         * cli/cli-cmds.c: Update.
4436         * cli/cli-interp.c: Update.
4437         * cli/cli-script.c: Update.
4438         * common/common-exceptions.c: Update.
4439         * common/new-op.c: Update.
4440         * common/selftest.c: Update.
4441         * compile/compile-c-symbols.c: Update.
4442         * compile/compile-cplus-symbols.c: Update.
4443         * compile/compile-object-load.c: Update.
4444         * compile/compile-object-run.c: Update.
4445         * completer.c: Update.
4446         * corelow.c: Update.
4447         * cp-abi.c: Update.
4448         * cp-support.c: Update.
4449         * cp-valprint.c: Update.
4450         * darwin-nat.c: Update.
4451         * disasm-selftests.c: Update.
4452         * dtrace-probe.c: Update.
4453         * dwarf-index-cache.c: Update.
4454         * dwarf-index-write.c: Update.
4455         * dwarf2-frame-tailcall.c: Update.
4456         * dwarf2-frame.c: Update.
4457         * dwarf2loc.c: Update.
4458         * dwarf2read.c: Update.
4459         * eval.c: Update.
4460         * event-loop.c: Update.
4461         * event-top.c: Update.
4462         * exec.c: Update.
4463         * f-valprint.c: Update.
4464         * fbsd-tdep.c: Update.
4465         * frame-unwind.c: Update.
4466         * frame.c: Update.
4467         * gdbtypes.c: Update.
4468         * gnu-v3-abi.c: Update.
4469         * guile/guile-internal.h: Update.
4470         * guile/scm-block.c: Update.
4471         * guile/scm-breakpoint.c: Update.
4472         * guile/scm-cmd.c: Update.
4473         * guile/scm-disasm.c: Update.
4474         * guile/scm-frame.c: Update.
4475         * guile/scm-lazy-string.c: Update.
4476         * guile/scm-math.c: Update.
4477         * guile/scm-param.c: Update.
4478         * guile/scm-ports.c: Update.
4479         * guile/scm-pretty-print.c: Update.
4480         * guile/scm-symbol.c: Update.
4481         * guile/scm-symtab.c: Update.
4482         * guile/scm-type.c: Update.
4483         * guile/scm-value.c: Update.
4484         * i386-linux-tdep.c: Update.
4485         * i386-tdep.c: Update.
4486         * inf-loop.c: Update.
4487         * infcall.c: Update.
4488         * infcmd.c: Update.
4489         * infrun.c: Update.
4490         * jit.c: Update.
4491         * language.c: Update.
4492         * linespec.c: Update.
4493         * linux-fork.c: Update.
4494         * linux-nat.c: Update.
4495         * linux-tdep.c: Update.
4496         * linux-thread-db.c: Update.
4497         * main.c: Update.
4498         * mi/mi-cmd-break.c: Update.
4499         * mi/mi-cmd-stack.c: Update.
4500         * mi/mi-interp.c: Update.
4501         * mi/mi-main.c: Update.
4502         * objc-lang.c: Update.
4503         * p-valprint.c: Update.
4504         * parse.c: Update.
4505         * ppc-linux-tdep.c: Update.
4506         * printcmd.c: Update.
4507         * python/py-arch.c: Update.
4508         * python/py-breakpoint.c: Update.
4509         * python/py-cmd.c: Update.
4510         * python/py-finishbreakpoint.c: Update.
4511         * python/py-frame.c: Update.
4512         * python/py-framefilter.c: Update.
4513         * python/py-gdb-readline.c: Update.
4514         * python/py-inferior.c: Update.
4515         * python/py-infthread.c: Update.
4516         * python/py-lazy-string.c: Update.
4517         * python/py-linetable.c: Update.
4518         * python/py-objfile.c: Update.
4519         * python/py-param.c: Update.
4520         * python/py-prettyprint.c: Update.
4521         * python/py-progspace.c: Update.
4522         * python/py-record-btrace.c: Update.
4523         * python/py-record.c: Update.
4524         * python/py-symbol.c: Update.
4525         * python/py-type.c: Update.
4526         * python/py-unwind.c: Update.
4527         * python/py-utils.c: Update.
4528         * python/py-value.c: Update.
4529         * python/python.c: Update.
4530         * record-btrace.c: Update.
4531         * record-full.c: Update.
4532         * remote-fileio.c: Update.
4533         * remote.c: Update.
4534         * riscv-tdep.c: Update.
4535         * rs6000-aix-tdep.c: Update.
4536         * rs6000-tdep.c: Update.
4537         * rust-exp.y: Update.
4538         * rust-lang.c: Update.
4539         * s390-tdep.c: Update.
4540         * selftest-arch.c: Update.
4541         * solib-dsbt.c: Update.
4542         * solib-frv.c: Update.
4543         * solib-spu.c: Update.
4544         * solib-svr4.c: Update.
4545         * solib.c: Update.
4546         * sparc64-linux-tdep.c: Update.
4547         * stack.c: Update.
4548         * symfile-mem.c: Update.
4549         * symmisc.c: Update.
4550         * target.c: Update.
4551         * thread.c: Update.
4552         * top.c: Update.
4553         * tracefile-tfile.c: Update.
4554         * tui/tui.c: Update.
4555         * typeprint.c: Update.
4556         * unittests/cli-utils-selftests.c: Update.
4557         * unittests/parse-connection-spec-selftests.c: Update.
4558         * valops.c: Update.
4559         * valprint.c: Update.
4560         * value.c: Update.
4561         * varobj.c: Update.
4562         * windows-nat.c: Update.
4563         * x86-linux-nat.c: Update.
4564         * xml-support.c: Update.
4565
4566 2019-04-08  Tom Tromey  <tom@tromey.com>
4567
4568         * xml-support.c: Use C++ exception handling.
4569         * x86-linux-nat.c: Use C++ exception handling.
4570         * windows-nat.c: Use C++ exception handling.
4571         * varobj.c: Use C++ exception handling.
4572         * value.c: Use C++ exception handling.
4573         * valprint.c: Use C++ exception handling.
4574         * valops.c: Use C++ exception handling.
4575         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4576         handling.
4577         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4578         * typeprint.c: Use C++ exception handling.
4579         * tui/tui.c: Use C++ exception handling.
4580         * tracefile-tfile.c: Use C++ exception handling.
4581         * top.c: Use C++ exception handling.
4582         * thread.c: Use C++ exception handling.
4583         * target.c: Use C++ exception handling.
4584         * symmisc.c: Use C++ exception handling.
4585         * symfile-mem.c: Use C++ exception handling.
4586         * stack.c: Use C++ exception handling.
4587         * sparc64-linux-tdep.c: Use C++ exception handling.
4588         * solib.c: Use C++ exception handling.
4589         * solib-svr4.c: Use C++ exception handling.
4590         * solib-spu.c: Use C++ exception handling.
4591         * solib-frv.c: Use C++ exception handling.
4592         * solib-dsbt.c: Use C++ exception handling.
4593         * selftest-arch.c: Use C++ exception handling.
4594         * s390-tdep.c: Use C++ exception handling.
4595         * rust-lang.c: Use C++ exception handling.
4596         * rust-exp.y: Use C++ exception handling.
4597         * rs6000-tdep.c: Use C++ exception handling.
4598         * rs6000-aix-tdep.c: Use C++ exception handling.
4599         * riscv-tdep.c: Use C++ exception handling.
4600         * remote.c: Use C++ exception handling.
4601         * remote-fileio.c: Use C++ exception handling.
4602         * record-full.c: Use C++ exception handling.
4603         * record-btrace.c: Use C++ exception handling.
4604         * python/python.c: Use C++ exception handling.
4605         * python/py-value.c: Use C++ exception handling.
4606         * python/py-utils.c: Use C++ exception handling.
4607         * python/py-unwind.c: Use C++ exception handling.
4608         * python/py-type.c: Use C++ exception handling.
4609         * python/py-symbol.c: Use C++ exception handling.
4610         * python/py-record.c: Use C++ exception handling.
4611         * python/py-record-btrace.c: Use C++ exception handling.
4612         * python/py-progspace.c: Use C++ exception handling.
4613         * python/py-prettyprint.c: Use C++ exception handling.
4614         * python/py-param.c: Use C++ exception handling.
4615         * python/py-objfile.c: Use C++ exception handling.
4616         * python/py-linetable.c: Use C++ exception handling.
4617         * python/py-lazy-string.c: Use C++ exception handling.
4618         * python/py-infthread.c: Use C++ exception handling.
4619         * python/py-inferior.c: Use C++ exception handling.
4620         * python/py-gdb-readline.c: Use C++ exception handling.
4621         * python/py-framefilter.c: Use C++ exception handling.
4622         * python/py-frame.c: Use C++ exception handling.
4623         * python/py-finishbreakpoint.c: Use C++ exception handling.
4624         * python/py-cmd.c: Use C++ exception handling.
4625         * python/py-breakpoint.c: Use C++ exception handling.
4626         * python/py-arch.c: Use C++ exception handling.
4627         * printcmd.c: Use C++ exception handling.
4628         * ppc-linux-tdep.c: Use C++ exception handling.
4629         * parse.c: Use C++ exception handling.
4630         * p-valprint.c: Use C++ exception handling.
4631         * objc-lang.c: Use C++ exception handling.
4632         * mi/mi-main.c: Use C++ exception handling.
4633         * mi/mi-interp.c: Use C++ exception handling.
4634         * mi/mi-cmd-stack.c: Use C++ exception handling.
4635         * mi/mi-cmd-break.c: Use C++ exception handling.
4636         * main.c: Use C++ exception handling.
4637         * linux-thread-db.c: Use C++ exception handling.
4638         * linux-tdep.c: Use C++ exception handling.
4639         * linux-nat.c: Use C++ exception handling.
4640         * linux-fork.c: Use C++ exception handling.
4641         * linespec.c: Use C++ exception handling.
4642         * language.c: Use C++ exception handling.
4643         * jit.c: Use C++ exception handling.
4644         * infrun.c: Use C++ exception handling.
4645         * infcmd.c: Use C++ exception handling.
4646         * infcall.c: Use C++ exception handling.
4647         * inf-loop.c: Use C++ exception handling.
4648         * i386-tdep.c: Use C++ exception handling.
4649         * i386-linux-tdep.c: Use C++ exception handling.
4650         * guile/scm-value.c: Use C++ exception handling.
4651         * guile/scm-type.c: Use C++ exception handling.
4652         * guile/scm-symtab.c: Use C++ exception handling.
4653         * guile/scm-symbol.c: Use C++ exception handling.
4654         * guile/scm-pretty-print.c: Use C++ exception handling.
4655         * guile/scm-ports.c: Use C++ exception handling.
4656         * guile/scm-param.c: Use C++ exception handling.
4657         * guile/scm-math.c: Use C++ exception handling.
4658         * guile/scm-lazy-string.c: Use C++ exception handling.
4659         * guile/scm-frame.c: Use C++ exception handling.
4660         * guile/scm-disasm.c: Use C++ exception handling.
4661         * guile/scm-cmd.c: Use C++ exception handling.
4662         * guile/scm-breakpoint.c: Use C++ exception handling.
4663         * guile/scm-block.c: Use C++ exception handling.
4664         * guile/guile-internal.h: Use C++ exception handling.
4665         * gnu-v3-abi.c: Use C++ exception handling.
4666         * gdbtypes.c: Use C++ exception handling.
4667         * frame.c: Use C++ exception handling.
4668         * frame-unwind.c: Use C++ exception handling.
4669         * fbsd-tdep.c: Use C++ exception handling.
4670         * f-valprint.c: Use C++ exception handling.
4671         * exec.c: Use C++ exception handling.
4672         * event-top.c: Use C++ exception handling.
4673         * event-loop.c: Use C++ exception handling.
4674         * eval.c: Use C++ exception handling.
4675         * dwarf2read.c: Use C++ exception handling.
4676         * dwarf2loc.c: Use C++ exception handling.
4677         * dwarf2-frame.c: Use C++ exception handling.
4678         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4679         * dwarf-index-write.c: Use C++ exception handling.
4680         * dwarf-index-cache.c: Use C++ exception handling.
4681         * dtrace-probe.c: Use C++ exception handling.
4682         * disasm-selftests.c: Use C++ exception handling.
4683         * darwin-nat.c: Use C++ exception handling.
4684         * cp-valprint.c: Use C++ exception handling.
4685         * cp-support.c: Use C++ exception handling.
4686         * cp-abi.c: Use C++ exception handling.
4687         * corelow.c: Use C++ exception handling.
4688         * completer.c: Use C++ exception handling.
4689         * compile/compile-object-run.c: Use C++ exception handling.
4690         * compile/compile-object-load.c: Use C++ exception handling.
4691         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4692         * compile/compile-c-symbols.c: Use C++ exception handling.
4693         * common/selftest.c: Use C++ exception handling.
4694         * common/new-op.c: Use C++ exception handling.
4695         * cli/cli-script.c: Use C++ exception handling.
4696         * cli/cli-interp.c: Use C++ exception handling.
4697         * cli/cli-cmds.c: Use C++ exception handling.
4698         * c-varobj.c: Use C++ exception handling.
4699         * btrace.c: Use C++ exception handling.
4700         * breakpoint.c: Use C++ exception handling.
4701         * break-catch-throw.c: Use C++ exception handling.
4702         * arch-utils.c: Use C++ exception handling.
4703         * amd64-tdep.c: Use C++ exception handling.
4704         * ada-valprint.c: Use C++ exception handling.
4705         * ada-typeprint.c: Use C++ exception handling.
4706         * ada-lang.c: Use C++ exception handling.
4707         * aarch64-tdep.c: Use C++ exception handling.
4708
4709 2019-04-08  Tom Tromey  <tom@tromey.com>
4710
4711         * xml-support.c (gdb_xml_parser::parse): Update.
4712         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4713         * value.c (show_convenience): Update.
4714         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4715         (test_parse_flags_qcs): Update.
4716         * thread.c (thr_try_catch_cmd): Update.
4717         * target.c (target_translate_tls_address): Update.
4718         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4719         (info_frame_command_core, frame_apply_command_count): Update.
4720         * rust-exp.y (rust_lex_exception_test): Update.
4721         * riscv-tdep.c (riscv_print_one_register_info): Update.
4722         * remote.c (remote_target::enable_btrace): Update.
4723         * record-btrace.c (record_btrace_enable_warn): Update.
4724         * python/py-utils.c (gdbpy_convert_exception): Update.
4725         * printcmd.c (do_one_display, print_variable_and_value): Update.
4726         * mi/mi-main.c (mi_print_exception): Update.
4727         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4728         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4729         * linux-nat.c (linux_nat_target::attach): Update.
4730         * linux-fork.c (class scoped_switch_fork_info): Update.
4731         * infrun.c (displaced_step_prepare): Update.
4732         * infcall.c (call_function_by_hand_dummy): Update.
4733         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4734         * gnu-v3-abi.c (print_one_vtable): Update.
4735         * frame.c (get_prev_frame_always): Update.
4736         * f-valprint.c (info_common_command_for_block): Update.
4737         * exec.c (try_open_exec_file): Update.
4738         * exceptions.c (print_exception, exception_print)
4739         (exception_fprintf, exception_print_same): Update.
4740         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4741         * dwarf-index-cache.c (index_cache::store)
4742         (index_cache::lookup_gdb_index): Update.
4743         * darwin-nat.c (maybe_cache_shell): Update.
4744         * cp-valprint.c (cp_print_value_fields): Update.
4745         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4746         (gcc_cplus_symbol_address): Update.
4747         * compile/compile-c-symbols.c (gcc_convert_symbol)
4748         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4749         * common/selftest.c: Update.
4750         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4751         a std::string.
4752         (exception_try_scope_entry, exception_try_scope_exit): Don't
4753         declare.
4754         (struct exception_try_scope): Remove.
4755         (TRY): Don't use exception_try_scope.
4756         (struct gdb_exception): Add constructor, operator=.
4757         <what>: New method.
4758         (struct gdb_exception_RETURN_MASK_ALL)
4759         (struct gdb_exception_RETURN_MASK_ERROR)
4760         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4761         (struct gdb_quit_bad_alloc): Update.
4762         * common/common-exceptions.c (exception_none): Change
4763         initializer.
4764         (struct catcher) <state, exception>: Initialize inline.
4765         <prev>: Remove member.
4766         (current_catcher): Remove.
4767         (catchers): New global.
4768         (exceptions_state_mc_init): Simplify.
4769         (catcher_pop): Remove.
4770         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4771         (try_scope_depth, exception_try_scope_entry)
4772         (exception_try_scope_exit): Remove.
4773         (throw_exception_sjlj): Update.
4774         (exception_messages, exception_messages_size): Remove.
4775         (throw_it): Simplify.
4776         (gdb_exception_sliced_copy): Remove.
4777         (throw_exception_cxx): Update.
4778         * cli/cli-script.c (script_from_file): Update.
4779         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4780         Update.
4781         * ada-valprint.c (ada_val_print): Update.
4782         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4783         (create_excep_cond_exprs): Update.
4784
4785 2019-04-08  Tom Tromey  <tom@tromey.com>
4786
4787         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4788         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4789         (TRY, CATCH, END_CATCH): Remove some definitions.
4790         * common/common-exceptions.c: Don't use GDB_XCPT.
4791         (catcher_list_size): Remove.
4792         (throw_exception, throw_it): Simplify.
4793
4794 2019-04-05  Tom Tromey  <tom@tromey.com>
4795
4796         Revert the header-sorting patch.
4797         * ft32-tdep.c: Revert.
4798         * frv-tdep.c: Revert.
4799         * frv-linux-tdep.c: Revert.
4800         * frame.c: Revert.
4801         * frame-unwind.c: Revert.
4802         * frame-base.c: Revert.
4803         * fork-child.c: Revert.
4804         * findvar.c: Revert.
4805         * findcmd.c: Revert.
4806         * filesystem.c: Revert.
4807         * filename-seen-cache.h: Revert.
4808         * filename-seen-cache.c: Revert.
4809         * fbsd-tdep.c: Revert.
4810         * fbsd-nat.h: Revert.
4811         * fbsd-nat.c: Revert.
4812         * f-valprint.c: Revert.
4813         * f-typeprint.c: Revert.
4814         * f-lang.c: Revert.
4815         * extension.h: Revert.
4816         * extension.c: Revert.
4817         * extension-priv.h: Revert.
4818         * expprint.c: Revert.
4819         * exec.h: Revert.
4820         * exec.c: Revert.
4821         * exceptions.c: Revert.
4822         * event-top.c: Revert.
4823         * event-loop.c: Revert.
4824         * eval.c: Revert.
4825         * elfread.c: Revert.
4826         * dwarf2read.h: Revert.
4827         * dwarf2read.c: Revert.
4828         * dwarf2loc.c: Revert.
4829         * dwarf2expr.h: Revert.
4830         * dwarf2expr.c: Revert.
4831         * dwarf2-frame.c: Revert.
4832         * dwarf2-frame-tailcall.c: Revert.
4833         * dwarf-index-write.h: Revert.
4834         * dwarf-index-write.c: Revert.
4835         * dwarf-index-common.c: Revert.
4836         * dwarf-index-cache.h: Revert.
4837         * dwarf-index-cache.c: Revert.
4838         * dummy-frame.c: Revert.
4839         * dtrace-probe.c: Revert.
4840         * disasm.h: Revert.
4841         * disasm.c: Revert.
4842         * disasm-selftests.c: Revert.
4843         * dictionary.c: Revert.
4844         * dicos-tdep.c: Revert.
4845         * demangle.c: Revert.
4846         * dcache.h: Revert.
4847         * dcache.c: Revert.
4848         * darwin-nat.h: Revert.
4849         * darwin-nat.c: Revert.
4850         * darwin-nat-info.c: Revert.
4851         * d-valprint.c: Revert.
4852         * d-namespace.c: Revert.
4853         * d-lang.c: Revert.
4854         * ctf.c: Revert.
4855         * csky-tdep.c: Revert.
4856         * csky-linux-tdep.c: Revert.
4857         * cris-tdep.c: Revert.
4858         * cris-linux-tdep.c: Revert.
4859         * cp-valprint.c: Revert.
4860         * cp-support.c: Revert.
4861         * cp-namespace.c: Revert.
4862         * cp-abi.c: Revert.
4863         * corelow.c: Revert.
4864         * corefile.c: Revert.
4865         * continuations.c: Revert.
4866         * completer.h: Revert.
4867         * completer.c: Revert.
4868         * complaints.c: Revert.
4869         * coffread.c: Revert.
4870         * coff-pe-read.c: Revert.
4871         * cli-out.h: Revert.
4872         * cli-out.c: Revert.
4873         * charset.c: Revert.
4874         * c-varobj.c: Revert.
4875         * c-valprint.c: Revert.
4876         * c-typeprint.c: Revert.
4877         * c-lang.c: Revert.
4878         * buildsym.c: Revert.
4879         * buildsym-legacy.c: Revert.
4880         * build-id.h: Revert.
4881         * build-id.c: Revert.
4882         * btrace.c: Revert.
4883         * bsd-uthread.c: Revert.
4884         * breakpoint.h: Revert.
4885         * breakpoint.c: Revert.
4886         * break-catch-throw.c: Revert.
4887         * break-catch-syscall.c: Revert.
4888         * break-catch-sig.c: Revert.
4889         * blockframe.c: Revert.
4890         * block.c: Revert.
4891         * bfin-tdep.c: Revert.
4892         * bfin-linux-tdep.c: Revert.
4893         * bfd-target.c: Revert.
4894         * bcache.c: Revert.
4895         * ax-general.c: Revert.
4896         * ax-gdb.h: Revert.
4897         * ax-gdb.c: Revert.
4898         * avr-tdep.c: Revert.
4899         * auxv.c: Revert.
4900         * auto-load.c: Revert.
4901         * arm-wince-tdep.c: Revert.
4902         * arm-tdep.c: Revert.
4903         * arm-symbian-tdep.c: Revert.
4904         * arm-pikeos-tdep.c: Revert.
4905         * arm-obsd-tdep.c: Revert.
4906         * arm-nbsd-tdep.c: Revert.
4907         * arm-nbsd-nat.c: Revert.
4908         * arm-linux-tdep.c: Revert.
4909         * arm-linux-nat.c: Revert.
4910         * arm-fbsd-tdep.c: Revert.
4911         * arm-fbsd-nat.c: Revert.
4912         * arm-bsd-tdep.c: Revert.
4913         * arch-utils.c: Revert.
4914         * arc-tdep.c: Revert.
4915         * arc-newlib-tdep.c: Revert.
4916         * annotate.h: Revert.
4917         * annotate.c: Revert.
4918         * amd64-windows-tdep.c: Revert.
4919         * amd64-windows-nat.c: Revert.
4920         * amd64-tdep.c: Revert.
4921         * amd64-sol2-tdep.c: Revert.
4922         * amd64-obsd-tdep.c: Revert.
4923         * amd64-obsd-nat.c: Revert.
4924         * amd64-nbsd-tdep.c: Revert.
4925         * amd64-nbsd-nat.c: Revert.
4926         * amd64-nat.c: Revert.
4927         * amd64-linux-tdep.c: Revert.
4928         * amd64-linux-nat.c: Revert.
4929         * amd64-fbsd-tdep.c: Revert.
4930         * amd64-fbsd-nat.c: Revert.
4931         * amd64-dicos-tdep.c: Revert.
4932         * amd64-darwin-tdep.c: Revert.
4933         * amd64-bsd-nat.c: Revert.
4934         * alpha-tdep.c: Revert.
4935         * alpha-obsd-tdep.c: Revert.
4936         * alpha-nbsd-tdep.c: Revert.
4937         * alpha-mdebug-tdep.c: Revert.
4938         * alpha-linux-tdep.c: Revert.
4939         * alpha-linux-nat.c: Revert.
4940         * alpha-bsd-tdep.c: Revert.
4941         * alpha-bsd-nat.c: Revert.
4942         * aix-thread.c: Revert.
4943         * agent.c: Revert.
4944         * addrmap.c: Revert.
4945         * ada-varobj.c: Revert.
4946         * ada-valprint.c: Revert.
4947         * ada-typeprint.c: Revert.
4948         * ada-tasks.c: Revert.
4949         * ada-lang.c: Revert.
4950         * aarch64-tdep.c: Revert.
4951         * aarch64-ravenscar-thread.c: Revert.
4952         * aarch64-newlib-tdep.c: Revert.
4953         * aarch64-linux-tdep.c: Revert.
4954         * aarch64-linux-nat.c: Revert.
4955         * aarch64-fbsd-tdep.c: Revert.
4956         * aarch64-fbsd-nat.c: Revert.
4957         * aarch32-linux-nat.c: Revert.
4958
4959 2019-04-05  Tom Tromey  <tom@tromey.com>
4960
4961         * ft32-tdep.c: Sort headers.
4962         * frv-tdep.c: Sort headers.
4963         * frv-linux-tdep.c: Sort headers.
4964         * frame.c: Sort headers.
4965         * frame-unwind.c: Sort headers.
4966         * frame-base.c: Sort headers.
4967         * fork-child.c: Sort headers.
4968         * findvar.c: Sort headers.
4969         * findcmd.c: Sort headers.
4970         * filesystem.c: Sort headers.
4971         * filename-seen-cache.h: Sort headers.
4972         * filename-seen-cache.c: Sort headers.
4973         * fbsd-tdep.c: Sort headers.
4974         * fbsd-nat.h: Sort headers.
4975         * fbsd-nat.c: Sort headers.
4976         * f-valprint.c: Sort headers.
4977         * f-typeprint.c: Sort headers.
4978         * f-lang.c: Sort headers.
4979         * extension.h: Sort headers.
4980         * extension.c: Sort headers.
4981         * extension-priv.h: Sort headers.
4982         * expprint.c: Sort headers.
4983         * exec.h: Sort headers.
4984         * exec.c: Sort headers.
4985         * exceptions.c: Sort headers.
4986         * event-top.c: Sort headers.
4987         * event-loop.c: Sort headers.
4988         * eval.c: Sort headers.
4989         * elfread.c: Sort headers.
4990         * dwarf2read.h: Sort headers.
4991         * dwarf2read.c: Sort headers.
4992         * dwarf2loc.c: Sort headers.
4993         * dwarf2expr.h: Sort headers.
4994         * dwarf2expr.c: Sort headers.
4995         * dwarf2-frame.c: Sort headers.
4996         * dwarf2-frame-tailcall.c: Sort headers.
4997         * dwarf-index-write.h: Sort headers.
4998         * dwarf-index-write.c: Sort headers.
4999         * dwarf-index-common.c: Sort headers.
5000         * dwarf-index-cache.h: Sort headers.
5001         * dwarf-index-cache.c: Sort headers.
5002         * dummy-frame.c: Sort headers.
5003         * dtrace-probe.c: Sort headers.
5004         * disasm.h: Sort headers.
5005         * disasm.c: Sort headers.
5006         * disasm-selftests.c: Sort headers.
5007         * dictionary.c: Sort headers.
5008         * dicos-tdep.c: Sort headers.
5009         * demangle.c: Sort headers.
5010         * dcache.h: Sort headers.
5011         * dcache.c: Sort headers.
5012         * darwin-nat.h: Sort headers.
5013         * darwin-nat.c: Sort headers.
5014         * darwin-nat-info.c: Sort headers.
5015         * d-valprint.c: Sort headers.
5016         * d-namespace.c: Sort headers.
5017         * d-lang.c: Sort headers.
5018         * ctf.c: Sort headers.
5019         * csky-tdep.c: Sort headers.
5020         * csky-linux-tdep.c: Sort headers.
5021         * cris-tdep.c: Sort headers.
5022         * cris-linux-tdep.c: Sort headers.
5023         * cp-valprint.c: Sort headers.
5024         * cp-support.c: Sort headers.
5025         * cp-namespace.c: Sort headers.
5026         * cp-abi.c: Sort headers.
5027         * corelow.c: Sort headers.
5028         * corefile.c: Sort headers.
5029         * continuations.c: Sort headers.
5030         * completer.h: Sort headers.
5031         * completer.c: Sort headers.
5032         * complaints.c: Sort headers.
5033         * coffread.c: Sort headers.
5034         * coff-pe-read.c: Sort headers.
5035         * cli-out.h: Sort headers.
5036         * cli-out.c: Sort headers.
5037         * charset.c: Sort headers.
5038         * c-varobj.c: Sort headers.
5039         * c-valprint.c: Sort headers.
5040         * c-typeprint.c: Sort headers.
5041         * c-lang.c: Sort headers.
5042         * buildsym.c: Sort headers.
5043         * buildsym-legacy.c: Sort headers.
5044         * build-id.h: Sort headers.
5045         * build-id.c: Sort headers.
5046         * btrace.c: Sort headers.
5047         * bsd-uthread.c: Sort headers.
5048         * breakpoint.h: Sort headers.
5049         * breakpoint.c: Sort headers.
5050         * break-catch-throw.c: Sort headers.
5051         * break-catch-syscall.c: Sort headers.
5052         * break-catch-sig.c: Sort headers.
5053         * blockframe.c: Sort headers.
5054         * block.c: Sort headers.
5055         * bfin-tdep.c: Sort headers.
5056         * bfin-linux-tdep.c: Sort headers.
5057         * bfd-target.c: Sort headers.
5058         * bcache.c: Sort headers.
5059         * ax-general.c: Sort headers.
5060         * ax-gdb.h: Sort headers.
5061         * ax-gdb.c: Sort headers.
5062         * avr-tdep.c: Sort headers.
5063         * auxv.c: Sort headers.
5064         * auto-load.c: Sort headers.
5065         * arm-wince-tdep.c: Sort headers.
5066         * arm-tdep.c: Sort headers.
5067         * arm-symbian-tdep.c: Sort headers.
5068         * arm-pikeos-tdep.c: Sort headers.
5069         * arm-obsd-tdep.c: Sort headers.
5070         * arm-nbsd-tdep.c: Sort headers.
5071         * arm-nbsd-nat.c: Sort headers.
5072         * arm-linux-tdep.c: Sort headers.
5073         * arm-linux-nat.c: Sort headers.
5074         * arm-fbsd-tdep.c: Sort headers.
5075         * arm-fbsd-nat.c: Sort headers.
5076         * arm-bsd-tdep.c: Sort headers.
5077         * arch-utils.c: Sort headers.
5078         * arc-tdep.c: Sort headers.
5079         * arc-newlib-tdep.c: Sort headers.
5080         * annotate.h: Sort headers.
5081         * annotate.c: Sort headers.
5082         * amd64-windows-tdep.c: Sort headers.
5083         * amd64-windows-nat.c: Sort headers.
5084         * amd64-tdep.c: Sort headers.
5085         * amd64-sol2-tdep.c: Sort headers.
5086         * amd64-obsd-tdep.c: Sort headers.
5087         * amd64-obsd-nat.c: Sort headers.
5088         * amd64-nbsd-tdep.c: Sort headers.
5089         * amd64-nbsd-nat.c: Sort headers.
5090         * amd64-nat.c: Sort headers.
5091         * amd64-linux-tdep.c: Sort headers.
5092         * amd64-linux-nat.c: Sort headers.
5093         * amd64-fbsd-tdep.c: Sort headers.
5094         * amd64-fbsd-nat.c: Sort headers.
5095         * amd64-dicos-tdep.c: Sort headers.
5096         * amd64-darwin-tdep.c: Sort headers.
5097         * amd64-bsd-nat.c: Sort headers.
5098         * alpha-tdep.c: Sort headers.
5099         * alpha-obsd-tdep.c: Sort headers.
5100         * alpha-nbsd-tdep.c: Sort headers.
5101         * alpha-mdebug-tdep.c: Sort headers.
5102         * alpha-linux-tdep.c: Sort headers.
5103         * alpha-linux-nat.c: Sort headers.
5104         * alpha-bsd-tdep.c: Sort headers.
5105         * alpha-bsd-nat.c: Sort headers.
5106         * aix-thread.c: Sort headers.
5107         * agent.c: Sort headers.
5108         * addrmap.c: Sort headers.
5109         * ada-varobj.c: Sort headers.
5110         * ada-valprint.c: Sort headers.
5111         * ada-typeprint.c: Sort headers.
5112         * ada-tasks.c: Sort headers.
5113         * ada-lang.c: Sort headers.
5114         * aarch64-tdep.c: Sort headers.
5115         * aarch64-ravenscar-thread.c: Sort headers.
5116         * aarch64-newlib-tdep.c: Sort headers.
5117         * aarch64-linux-tdep.c: Sort headers.
5118         * aarch64-linux-nat.c: Sort headers.
5119         * aarch64-fbsd-tdep.c: Sort headers.
5120         * aarch64-fbsd-nat.c: Sort headers.
5121         * aarch32-linux-nat.c: Sort headers.
5122
5123 2019-04-04  Tom Tromey  <tom@tromey.com>
5124
5125         * varobj.c (varobj_create): Update.
5126         * rust-exp.y (struct rust_parser) <update_innermost_block,
5127         lookup_symbol>: New methods.
5128         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5129         Rename.
5130         (rust_parser::rust_lookup_type)
5131         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5132         * printcmd.c (display_command, do_one_display): Update.
5133         * parser-defs.h (struct parser_state) <parser_state>: Add
5134         "tracker" parameter.
5135         (block_tracker): New member.
5136         (class innermost_block_tracker) <innermost_block_tracker>: Add
5137         "types" parameter.
5138         <reset>: Remove method.
5139         (innermost_block): Don't declare.
5140         (null_post_parser): Update.
5141         * parse.c (innermost_block): Remove global.
5142         (write_dollar_variable): Update.
5143         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5144         Remove "tracker_types" parameter.
5145         (parse_expression): Add "tracker" parameter.
5146         (parse_expression_for_completion): Update.
5147         (null_post_parser): Add "tracker" parameter.
5148         * p-exp.y: Update rules.
5149         * m2-exp.y: Update rules.
5150         * language.h (struct language_defn) <la_post_parser>: Add
5151         "tracker" parameter.
5152         * go-exp.y: Update rules.
5153         * f-exp.y: Update rules.
5154         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5155         parameter.
5156         * d-exp.y: Update rules.
5157         * c-exp.y: Update rules.
5158         * breakpoint.c (set_breakpoint_condition): Create an
5159         innermost_block_tracker.
5160         (watch_command_1): Likewise.
5161         * ada-lang.c (resolve): Add "tracker" parameter.
5162         (resolve_subexp): Likewise.
5163         * ada-exp.y (write_var_from_sym): Update.
5164
5165 2019-04-04  Tom Tromey  <tom@tromey.com>
5166
5167         * type-stack.h: New file.
5168         * type-stack.c: New file.
5169         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5170         type-stack.h.
5171         (insert_into_type_stack, insert_type, push_type, push_type_int)
5172         (insert_type_address_space, pop_type, pop_type_int)
5173         (pop_typelist, pop_type_stack, append_type_stack)
5174         (push_type_stack, get_type_stack, push_typelist)
5175         (follow_type_instance_flags, follow_types): Don't declare.
5176         * parse.c (type_stack): Remove global.
5177         (parse_exp_in_context): Update.
5178         (insert_into_type_stack, insert_type, push_type, push_type_int)
5179         (insert_type_address_space, pop_type, pop_type_int)
5180         (pop_typelist, pop_type_stack, append_type_stack)
5181         (push_type_stack, get_type_stack, push_typelist)
5182         (follow_type_instance_flags, follow_types): Remove (moved to
5183         type-stack.c).
5184         * f-exp.y (type_stack): New global.
5185         Update rules.
5186         (push_kind_type, f_parse): Update.
5187         * d-exp.y (type_stack): New global.
5188         Update rules.
5189         (d_parse): Update.
5190         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5191         Update rules.
5192         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5193         (HFILES_NO_SRCDIR): Add type-stack.h.
5194
5195 2019-04-04  Tom Tromey  <tom@tromey.com>
5196
5197         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5198         (rust_parser::convert_ast_to_expression, rust_parse)
5199         (rust_lex_test_completion, rust_lex_tests): Update.
5200         * parser-defs.h (struct expr_completion_state): New.
5201         (struct parser_state) <parser_state>: Add completion parameter.
5202         <mark_struct_expression, mark_completion_tag>: New methods.
5203         <parse_completion, m_completion_state>: New members.
5204         (prefixify_expression, null_post_parser): Update.
5205         (mark_struct_expression, mark_completion_tag): Don't declare.
5206         * parse.c (parse_completion, expout_last_struct)
5207         (expout_tag_completion_type, expout_completion_name): Remove
5208         globals.
5209         (parser_state::mark_struct_expression)
5210         (parser_state::mark_completion_tag): Now methods.
5211         (prefixify_expression): Add last_struct parameter.
5212         (prefixify_subexp): Likewise.
5213         (parse_exp_1): Update.
5214         (parse_exp_in_context): Add cstate parameter.  Update.
5215         (parse_expression_for_completion): Create an
5216         expr_completion_state.
5217         (null_post_parser): Add "completion" parameter.
5218         * p-exp.y: Update rules.
5219         (yylex): Update.
5220         * language.h (struct language_defn) <la_post_parser>: Add
5221         "completing" parameter.
5222         * go-exp.y: Update rules.
5223         (lex_one_token): Update.
5224         * expression.h (parse_completion): Don't declare.
5225         * d-exp.y: Update rules.
5226         (lex_one_token): Update rules.
5227         * c-exp.y: Update rules.
5228         (lex_one_token): Update.
5229         * ada-lang.c (resolve): Add "parse_completion" parameter.
5230         (resolve_subexp): Likewise.
5231         (ada_resolve_function): Likewise.
5232
5233 2019-04-04  Tom Tromey  <tom@tromey.com>
5234
5235         * parser-defs.h (struct parser_state) <start_arglist,
5236         end_arglist>: New methods.
5237         <arglist_len, m_funcall_chain>: New members.
5238         (arglist_len, start_arglist, end_arglist): Don't declare.
5239         * parse.c (arglist_len, funcall_chain): Remove global.
5240         (start_arglist, end_arglist): Remove functions.
5241         (parse_exp_in_context): Update.
5242         * p-exp.y: Update rules.
5243         * m2-exp.y: Update rules.
5244         * go-exp.y: Update rules.
5245         * f-exp.y: Update rules.
5246         * d-exp.y: Update rules.
5247         * c-exp.y: Update rules.
5248
5249 2019-04-04  Tom Tromey  <tom@tromey.com>
5250
5251         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5252         lex_operator, push_back>: New methods.
5253         Update all rules.
5254         (rust_parser::lex_hex, lex_escape): Rename and update.
5255         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5256         (rust_parser::lex_operator): Rename and update.
5257         (rust_parser::lex_number, rustyylex, rustyyerror)
5258         (rust_lex_test_init, rust_lex_test_sequence)
5259         (rust_lex_test_push_back, rust_lex_tests): Update.
5260         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5261         parameter.
5262         <lexptr, prev_lexptr>: New members.
5263         (lexptr, prev_lexptr): Don't declare.
5264         * parse.c (lexptr, prev_lexptr): Remove globals.
5265         (parse_exp_in_context): Update.
5266         * p-exp.y (yylex, yyerror): Update.
5267         * m2-exp.y (parse_number, yylex, yyerror): Update.
5268         * go-exp.y (lex_one_token, yyerror): Update.
5269         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5270         * d-exp.y (lex_one_token, yyerror): Update.
5271         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5272         (lex_one_token, yyerror): Update.
5273         * ada-lex.l (YY_INPUT): Update.
5274         (rewind_to_char): Update.
5275         * ada-exp.y (yyerror): Update.
5276
5277 2019-04-04  Tom Tromey  <tom@tromey.com>
5278
5279         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5280         * parser-defs.h (struct parser_state) <parser_state>: Add new
5281         parameter.
5282         <comma_terminates>: New member.
5283         (comma_terminates): Don't declare global.
5284         * parse.c (comma_terminates): Remove global.
5285         (parse_exp_in_context): Update.
5286         * p-exp.y (yylex): Update.
5287         * m2-exp.y (yylex): Update.
5288         * go-exp.y (lex_one_token): Update.
5289         * f-exp.y (yylex): Update.
5290         * d-exp.y (lex_one_token): Update.
5291         * c-exp.y (lex_one_token): Update.
5292         * ada-lex.l: Update.
5293
5294 2019-04-04  Tom Tromey  <tom@tromey.com>
5295
5296         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5297         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5298         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5299         * parser-defs.h (paren_depth): Don't declare.
5300         * parse.c (paren_depth): Remove global.
5301         (parse_exp_in_context): Update.
5302         * p-exp.y (paren_depth): New global.
5303         (pascal_parse): Initialize it.
5304         * m2-exp.y (paren_depth): New global.
5305         (m2_parse): Initialize it.
5306         * go-exp.y (paren_depth): New global.
5307         (go_parse): Initialize it.
5308         * f-exp.y (paren_depth): New global.
5309         (f_parse): Initialize it.
5310         * d-exp.y (paren_depth): New global.
5311         (d_parse): Initialize it.
5312         * c-exp.y (paren_depth): New global.
5313         (c_parse): Initialize it.
5314         * ada-lex.l (paren_depth): New global.
5315         (lexer_init): Initialize it.
5316
5317 2019-04-04  Tom Tromey  <tom@tromey.com>
5318
5319         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5320         (rust_parser::convert_ast_to_type)
5321         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5322         * parser-defs.h (struct parser_state) <parser_state>: Add
5323         parameters.  Initialize new members.
5324         <expression_context_block, expression_context_pc>: New members.
5325         * parse.c (expression_context_block, expression_context_pc):
5326         Remove globals.
5327         (parse_exp_in_context): Update.
5328         * p-exp.y: Update all rules.
5329         (yylex): Update.
5330         * m2-exp.y: Update all rules.
5331         (yylex): Update.
5332         * go-exp.y (yylex): Update.
5333         * f-exp.y (yylex): Update.
5334         * d-exp.y: Update all rules.
5335         (yylex): Update.
5336         * c-exp.y: Update all rules.
5337         (lex_one_token, classify_name, yylex, c_parse): Update.
5338         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5339
5340 2019-04-04  Tom Tromey  <tom@tromey.com>
5341
5342         * gdbarch.h, gdbarch.c: Rebuild.
5343         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5344         * stap-probe.h:
5345         (struct stap_parse_info): Replace "parser_state" with
5346         "expr_builder".
5347         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5348         (parser_state): New class.
5349         * parse.c (expr_builder): Rename.
5350         (expr_builder::release): Rename.
5351         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5352         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5353         (write_exp_elt_longcst, write_exp_elt_floatcst)
5354         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5355         (write_exp_string_vector, write_exp_bitstring)
5356         (write_exp_msymbol, mark_struct_expression)
5357         (write_dollar_variable)
5358         (insert_type_address_space, increase_expout_size): Replace
5359         "parser_state" with "expr_builder".
5360         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5361         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5362         "parser_state" with "expr_builder".
5363
5364 2019-04-04  Tom Tromey  <tom@tromey.com>
5365
5366         * rust-exp.y: Replace "parse_language" with method call.
5367         * p-exp.y:
5368         (yylex): Replace "parse_language" with method call.
5369         * m2-exp.y:
5370         (yylex): Replace "parse_language" with method call.
5371         * go-exp.y (classify_name): Replace "parse_language" with method
5372         call.
5373         * f-exp.y (yylex): Replace "parse_language" with method call.
5374         * d-exp.y (lex_one_token): Replace "parse_language" with method
5375         call.
5376         * c-exp.y:
5377         (lex_one_token, classify_name, yylex): Replace "parse_language"
5378         with method call.
5379         * ada-exp.y (find_primitive_type, type_char)
5380         (type_system_address): Replace "parse_language" with method call.
5381
5382 2019-04-04  Tom Tromey  <tom@tromey.com>
5383
5384         * rust-exp.y: Replace "parse_gdbarch" with method call.
5385         * parse.c (write_dollar_variable, insert_type_address_space):
5386         Replace "parse_gdbarch" with method call.
5387         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5388         call.
5389         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5390         call.
5391         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5392         "parse_gdbarch" with method call.
5393         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5394         with method call.
5395         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5396         "parse_gdbarch" with method call.
5397         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5398         "parse_gdbarch" with method call.
5399         * c-exp.y (parse_type, parse_number, classify_name): Replace
5400         "parse_gdbarch" with method call.
5401         * ada-lex.l: Replace "parse_gdbarch" with method call.
5402         * ada-exp.y (parse_type, find_primitive_type, type_char)
5403         (type_system_address): Replace "parse_gdbarch" with method call.
5404
5405 2019-04-04  Tom Tromey  <tom@tromey.com>
5406
5407         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5408         * stap-probe.c (stap_parse_argument): Update.
5409         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5410         initial_size parameter.
5411         * rust-exp.y (rust_lex_tests): Update.
5412         * parse.c (parser_state): Update.
5413         (parse_exp_in_context): Update.
5414         * parser-defs.h (struct parser_state) <parser_state>: Remove
5415         "initial_size" parameter.
5416
5417 2019-04-04  Tom Tromey  <tom@tromey.com>
5418
5419         * parser-defs.h (increase_expout_size): Don't declare.
5420         * parse.c (increase_expout_size): Now static.
5421
5422 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5423
5424         * gnu-nat.c (gnu_nat_target::wait): Fix
5425         target_waitstatus_to_string call.
5426
5427 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5428
5429         * eval.c (evaluate_subexp_standard): Handle internal functions
5430         during Fortran function call handling.
5431
5432 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * NEWS: Mention new internal functions.
5435         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5436         (read_base_type): Use dwarf2_init_complex_target_type.
5437         * value.c (creal_internal_fn): New function.
5438         (cimag_internal_fn): New function.
5439         (_initialize_values): Register new internal functions.
5440
5441 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5442
5443         * infrun.c (stop_all_threads): If debug_infrun, always
5444         trace the wait status after wait_one, using
5445         target_waitstatus_to_string and target_pid_to_str.
5446         (handle_inferior_event): Replace various trace of
5447         wait status kind by a single trace.
5448         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5449         wait status kind image by target_waitstatus_to_string.
5450         * target/waitstatus.c (target_waitstatus_to_string): Fix
5451         obsolete comment.
5452
5453 2019-04-01  Tom Tromey  <tromey@adacore.com>
5454
5455         PR symtab/23331:
5456         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5457
5458 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5459             Pedro Alves  <palves@redhat.com>
5460
5461         * top.c (quit_force): Call 'finalize_values'.
5462         * value.c (finalize_values): New function.
5463         * value.h (finalize_values): Declare.
5464
5465 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5466
5467         * NEWS: Announce $_gdb_major and $_gdb_minor.
5468
5469         * top.c (init_gdb_version_vars): New function.
5470         (gdb_init): Call init_gdb_version_vars.
5471
5472 2019-03-29  Tom Tromey  <tromey@adacore.com>
5473
5474         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5475         help text.  Remove dead code.
5476
5477 2019-03-29  Keith Seitz  <keiths@redhat.com>
5478
5479         From Siddhesh Poyarekar:
5480         * f-lang.h (f77_get_upperbound): Return LONGEST.
5481         (f77_get_lowerbound): Likewise.
5482         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5483         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5484         print them.
5485         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5486         plongest to format print it.
5487         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5488         (f77_get_upperbound): Likewise.
5489         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5490         LOWER_BOUND to LONGEST.
5491         (f77_create_arrayprint_offset_tbl): Likewise.
5492
5493 2019-03-29  Keith Seitz  <keiths@redhat.com>
5494
5495         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5496         %s/pulongest for TYPE_LENGTH instead of %d in format
5497         strings.
5498         * ada-typerint.c (ada_print_type): Likewise.
5499         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5500         * compile/compile-c-support.c (generate_register_struct): Likewise.
5501         * gdbtypes.c (recursive_dump_type): Likewise.
5502         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5503         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5504         instead of %d in format strings.
5505         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5506         to std::min to ULONGEST.
5507         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5508         instead of %d in format strings.
5509         * tracepoint.c (info_scope_command): Likewise.
5510         * typeprint.c (print_offset_data::update)
5511         (print_offset_data::finish): Likewise.
5512         * xtensa-tdep.c (xtensa_store_return_value)
5513         (xtensa_push_dummy_call): Likewise.
5514
5515 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5516
5517         * windows-nat.c (display_selector): Fixed format specifications
5518         for 64-bit Cygwin.
5519
5520 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5521
5522         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5523
5524 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5525
5526         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5527         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5528         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5529         (nios2_linux_init_abi): Install it.
5530
5531 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5532
5533         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5534
5535 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5536
5537         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5538
5539 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5540             Tom Tromey  <tromey@adacore.com>
5541
5542         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5543
5544 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5545
5546         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5547         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5548         method to compute the bounds of range types. Also print "[evaluated]"
5549         if the bounds' values come from a dynamic evaluation.
5550
5551 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5552
5553         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5554         whitespace when pretty printing is on.
5555
5556 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5557
5558         * ppc-linux-nat.c: Add include.
5559
5560 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5561
5562         * NEWS: Mention AArch64 Pointer Authentication.
5563
5564 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5565
5566         * arm-linux-nat.c: Add include.
5567
5568 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5569
5570         * source-cache.c (source_cache::get_source_lines): Re-read
5571         fullname after calling open_source_file.
5572
5573 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5574
5575         * NEWS: Mention TLS support for FreeBSD.
5576
5577 2019-03-25  Tom Tromey  <tromey@adacore.com>
5578
5579         * minsyms.c (BUNCH_SIZE): Update comment.
5580         (~minimal_symbol_reader): Remove old comment.
5581         (compact_minimal_symbols): Update comment.
5582         (minimal_symbol_reader::install): Remove old comment.  Update
5583         other comments.
5584
5585 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5586
5587         * s390-linux-nat.c: Add include.
5588
5589 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5590
5591         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5592         Call linux_get_hwcap.
5593         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5594         Likewise.
5595         (aarch64_linux_get_hwcap): Remove function.
5596         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5597         declaration.
5598         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5599         linux_get_hwcap.
5600         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5601         * linux-tdep.c (linux_get_hwcap): Add function.
5602         (linux_get_hwcap2): Likewise.
5603         * linux-tdep.h (linux_get_hwcap): Add declaration.
5604         (linux_get_hwcap2): Likewise.
5605         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5606         (ppc_linux_get_hwcap2): Likewise.
5607         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5608         linux_get_hwcap.
5609         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5610         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5611         (ppc_linux_nat_target::read_description): Likewise.
5612         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5613         * s390-linux-nat.c: Likewise.
5614         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5615
5616 2019-03-24  Tom Tromey  <tom@tromey.com>
5617
5618         * ada-lang.c (standard_lookup): Simplify initialization.
5619         (ada_lookup_symbol_nonlocal): Simplify return.
5620         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5621         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5622         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5623         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5624         initialization.
5625         * solib.c (solib_global_lookup): Simplify.
5626         * symtab.c (null_block_symbol): Remove.
5627         (symbol_cache_lookup): Simplify returns.
5628         (lookup_language_this): Simplify returns.
5629         (lookup_symbol_aux): Simplify return.
5630         (lookup_local_symbol): Simplify returns.
5631         (lookup_global_symbol_from_objfile): Simplify return.
5632         (lookup_symbol_in_objfile_symtabs)
5633         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5634         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5635         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5636         * cp-namespace.c (cp_lookup_bare_symbol)
5637         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5638         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5639         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5640         (cp_lookup_symbol_via_imports): Simplify initialization.
5641         (find_symbol_in_baseclass): Likewise.
5642         * symtab.h (null_block_symbol): Remove.
5643         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5644         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5645         (d_lookup_symbol_module): Likewise.
5646         (find_symbol_in_baseclass): Simplify initialization.
5647
5648 2019-03-24  Tom Tromey  <tom@tromey.com>
5649
5650         * expression.h: Don't include symtab.h.
5651         (struct block): Forward declare.
5652
5653 2019-03-24  Tom Tromey  <tom@tromey.com>
5654
5655         * c-exp.y (typebase): Remove casts.
5656         * gdbtypes.c (lookup_unsigned_typename, )
5657         (lookup_signed_typename): Remove cast.
5658         * eval.c (parse_to_comma_and_eval): Remove cast.
5659         * parse.c (write_dollar_variable): Remove cast.
5660         * block.h (struct block) <superblock>: Now const.
5661         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5662         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5663         (map_block): Make "block" const.
5664         * symfile.h (struct quick_symbol_functions)
5665         <map_matching_symbols>: Constify block argument to "callback".
5666         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5667         const.
5668         (find_pc_sect_compunit_symtab): Make "b" const.
5669         (find_symbol_at_address): Likewise.
5670         (search_symbols): Likewise.
5671         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5672         (dw2_debug_names_lookup_symbol): Likewise.
5673         (dw2_map_matching_symbols): Update.
5674         * p-valprint.c (pascal_val_print): Remove "block".
5675         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5676         (aux_add_nonlocal_symbols): Make "block" const.
5677         (resolve_subexp): Remove cast.
5678         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5679         const.
5680         (iterate_over_file_blocks): Likewise.
5681         * f-exp.y (%union) <bval>: Remove.
5682         * coffread.c (patch_opaque_types): Make "b" const.
5683         * spu-tdep.c (spu_catch_start): Make "block" const.
5684         * c-valprint.c (print_unpacked_pointer): Remove "block".
5685         * symmisc.c (dump_symtab_1): Make "b" const.
5686         (block_depth): Make "block" const.
5687         * d-exp.y (%union) <bval>: Remove.
5688         * cp-support.h (cp_lookup_rtti_type): Update.
5689         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5690         * psymtab.c (psym_lookup_symbol): Make "block" const.
5691         (maintenance_check_psymtabs): Make "b" const.
5692         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5693         (enumerate_locals, enumerate_args): Update.
5694         * python/py-symtab.c (stpy_global_block): Make "block" const.
5695         (stpy_static_block): Likewise.
5696         * inline-frame.c (block_starting_point_at): Make "new_block"
5697         const.
5698         * block.c (find_block_in_blockvector): Make return type const.
5699         (blockvector_for_pc_sect): Make "b" const.
5700         (find_block_in_blockvector): Make "b" const.
5701
5702 2019-03-23  Tom Tromey  <tom@tromey.com>
5703
5704         * varobj.c (varobj_create): Update.
5705         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5706         * printcmd.c (display_command, do_one_display): Don't reset
5707         innermost_block.
5708         * parser-defs.h (enum innermost_block_tracker_type): Move to
5709         expression.h.
5710         (innermost_block): Update comment.
5711         * parse.c (parse_exp_1): Add tracker_types parameter.
5712         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5713         tracker_types parameter.  Reset innermost_block.
5714         (parse_exp_in_context): Remove.
5715         (parse_expression_for_completion): Update.
5716         * objfiles.c (~objfile): Don't reset expression_context_block or
5717         innermost_block.
5718         * expression.h (enum innermost_block_tracker_type): Move from
5719         parser-defs.h.
5720         (parse_exp_1): Add tracker_types parameter.
5721         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5722         reset innermost_block.
5723
5724 2019-03-23  Tom Tromey  <tom@tromey.com>
5725
5726         * objfiles.h: Include bcache.h.
5727
5728 2019-03-23  Tom Tromey  <tom@tromey.com>
5729
5730         * linespec.c (get_current_search_block): Use
5731         scoped_restore_current_language.
5732         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5733
5734 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5735             Jiong Wang  <jiong.wang@arm.com>
5736
5737         * aarch64-linux-tdep.c
5738         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5739         section.
5740         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5741
5742 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5743             Jiong Wang  <jiong.wang@arm.com>
5744
5745         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5746         instructions.
5747         (aarch64_analyze_prologue_test): Add PACIASP test.
5748         (aarch64_prologue_prev_register): Unmask PC value.
5749
5750 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5751             Jiong Wang  <jiong.wang@arm.com>
5752
5753         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5754         (aarch64_dwarf2_prev_register): Unmask PC value.
5755         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5756         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5757         DW_CFA_AARCH64_negate_ra_state.
5758         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5759
5760 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5761             Jiong Wang  <jiong.wang@arm.com>
5762
5763         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5764         registers.
5765         (aarch64_pseudo_register_name): Likewise.
5766         (aarch64_pseudo_register_type): Likewise.
5767         (aarch64_pseudo_register_reggroup_p): Likewise.
5768         (aarch64_gdbarch_init): Add pauth registers.
5769         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5770         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5771         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5772         (struct gdbarch_tdep): Add regnum for ra_state.
5773
5774 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5775             Jiong Wang  <jiong.wang@arm.com>
5776
5777         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5778
5779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5780             Jiong Wang  <jiong.wang@arm.com>
5781
5782         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5783         function.
5784         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5785         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5786         (aarch64_gdbarch_init): Add puth registers.
5787         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5788         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5789         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5790
5791 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5792             Jiong Wang  <jiong.wang@arm.com>
5793
5794         * aarch64-linux-nat.c
5795         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5796         * aarch64-linux-tdep.c
5797         (aarch64_linux_core_read_description): Likewise.
5798         (aarch64_linux_get_hwcap): New function.
5799         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5800         (aarch64_linux_get_hwcap): New declaration.
5801
5802 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5803             Jiong Wang  <jiong.wang@arm.com>
5804
5805         * aarch64-linux-nat.c
5806         (aarch64_linux_nat_target::read_description): Add pauth param.
5807         * aarch64-linux-tdep.c
5808         (aarch64_linux_core_read_description): Likewise.
5809         * aarch64-tdep.c (struct target_desc): Add in pauth.
5810         (aarch64_read_description): Add pauth param.
5811         (aarch64_gdbarch_init): Likewise.
5812         * aarch64-tdep.h (aarch64_read_description): Likewise.
5813         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5814         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5815         * features/Makefile: Add new files.
5816         * features/aarch64-pauth.c: New file.
5817         * features/aarch64-pauth.xml: New file.
5818
5819 2019-03-20  Tom Tromey  <tromey@adacore.com>
5820
5821         * infrun.c (handle_inferior_event): Rename from
5822         handle_inferior_event_1.  Create a scoped_value_mark.
5823         (handle_inferior_event): Remove.
5824
5825 2019-03-19  Tom Tromey  <tromey@adacore.com>
5826
5827         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5828         * infrun.h (print_stop_event): Add "displays" parameter.
5829         * infrun.c (print_stop_event): Add "displays" parameter.
5830
5831 2019-03-19  Pedro Alves  <palves@redhat.com>
5832
5833         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5834         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5835         to -1.  Fix TABs vs spaces.
5836         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5837         * tui/tui-out.h (tui_ui_out) Add intro comments.
5838         <m_line, m_start_of_line>: In-class initialize, and add describing
5839         comment.
5840
5841 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5842
5843         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5844         variable names.
5845         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5846
5847 2019-03-18  Pedro Alves  <palves@redhat.com>
5848             Eli Zaretskii <eliz@gnu.org>
5849
5850         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5851         m_line and m_start_of_line.
5852
5853 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5854
5855         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5856         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5857         it returns a newline.  This fixes a regression in TU mode, whereby
5858         the next line is output on the same screen line as the user input.
5859
5860 2019-03-18  Tom Tromey  <tromey@adacore.com>
5861
5862         * minsyms.c (minimal_symbol_reader::install): Remove call to
5863         obstack_blank.
5864
5865 2019-03-18  Pedro Alves  <palves@redhat.com>
5866
5867         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5868         New globals.
5869         (apply_style): New, factored out from ...
5870         (apply_ansi_escape): ... this.  Handle reverse video mode.
5871         (tui_set_reverse_mode): New function.
5872         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5873         * tui/tui-winsource.c (tui_show_source_line): Use
5874         tui_set_reverse_mode instead of setting A_STANDOUT.
5875         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5876         New setter methods.
5877
5878 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5879
5880         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5881         Handle tabs.
5882
5883 2019-03-18  Tom Tromey  <tromey@adacore.com>
5884
5885         * ada-lang.c (empty_array): Add "high" parameter.
5886         (ada_evaluate_subexp): Update.
5887
5888 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5889
5890         * unittests/string_view-selftests.c: Define
5891         _initialize_string_view_selftests unconditionally.
5892
5893 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5894
5895         PR gdb/24350
5896         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5897
5898 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5899
5900         PR gdb/24351
5901         * windows-nat.c (display_selector): Fix format specifiers.
5902
5903 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5904
5905         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5906         tui_refill_source_window instead of tui_refresh_win, to update the
5907         current execution line.  This fixes redisplay of the current line
5908         when stepping through the code with "next" or "step".
5909
5910 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5911
5912         * source-cache.c (source_cache::get_source_lines): Call
5913         find_source_lines to initialize s->nlines.  This fixes vertical
5914         scrolling of TUI source window when the DOWN arrow is pressed.
5915
5916 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5917
5918         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5919         linux-thread-db.c (_initialize_thread_db): Likewise.
5920
5921 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5922
5923         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5924         wclrtoeol in tui_show_source_line".  This reverts changes made in
5925         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5926
5927 2019-03-15  Tom Tromey  <tom@tromey.com>
5928
5929         * symtab.h (struct minimal_symbol): Derive from
5930         general_symbol_info.
5931         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5932         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5933         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5934         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5935         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5936         (MSYMBOL_SEARCH_NAME): Update.
5937         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5938         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5939         * minsyms.c (minimal_symbol_reader::record_full): Update.
5940
5941 2019-03-15  Tom Tromey  <tom@tromey.com>
5942
5943         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5944
5945 2019-03-15  Tom Tromey  <tom@tromey.com>
5946
5947         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5948         unique_xmalloc_ptr.
5949         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5950         Update.
5951         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5952         (build_minimal_symbol_hash_tables)
5953         (minimal_symbol_reader::install): Update.
5954
5955 2019-03-15  Tom Tromey  <tom@tromey.com>
5956
5957         * symtab.c (create_demangled_names_hash): Update.
5958         (symbol_set_names): Update.
5959         * objfiles.h (struct objfile_per_bfd_storage)
5960         <demangled_names_hash>: Now an htab_up.
5961         * objfiles.c (objfile_per_bfd_storage): Simplify.
5962
5963 2019-03-15  Tom Tromey  <tom@tromey.com>
5964
5965         * objfiles.h (struct objfile_per_bfd_storage): Declare
5966         destructor.
5967         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5968         New.
5969         (get_objfile_bfd_data): Use new.  Don't initialize
5970         language_of_main.
5971         (free_objfile_per_bfd_storage): Remove.
5972         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5973
5974 2019-03-15  Tom Tromey  <tom@tromey.com>
5975
5976         * symfile.c (reread_symbols): Update.
5977         * objfiles.c (objfile::objfile): Update.
5978         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5979         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5980         comment.
5981         (minimal_symbol_reader::install): Update.
5982         (terminate_minimal_symbol_table): Remove.
5983         * jit.c (jit_object_close_impl): Update.
5984
5985 2019-03-15  Tom Tromey  <tom@tromey.com>
5986
5987         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5988         initializations.
5989
5990 2019-03-15  Tom Tromey  <tom@tromey.com>
5991
5992         * objfiles.h (struct objfile_per_bfd_storage)
5993         <demangled_hash_languages>: Now a bitset.
5994         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5995         (lookup_minimal_symbol): Update.
5996
5997 2019-03-15  Tom Tromey  <tom@tromey.com>
5998
5999         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6000         Don't return the symbol.
6001         * coffread.c (record_minimal_symbol): Use record_full.
6002
6003 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6004
6005         The MS-Windows port of ncurses fails to switch to a color pair if
6006         one or both of the colors are the implicit default colors.  This
6007         change records the default colors when TUI is initialized, and
6008         then specifies them explicitly when a color pair uses the default
6009         colors.  This allows color styling in TUI mode on MS-Windows.
6010
6011         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6012         ncurses_norm_attr.
6013         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6014         colors in ncurses_norm_attr.
6015         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6016         "none", replace it with the default color recorded in
6017         ncurses_norm_attr.
6018
6019 2019-03-14  Tom Tromey  <tromey@adacore.com>
6020
6021         * source-cache.h (class source_cache) <get_source_lines>: Return
6022         std::string.
6023         * source-cache.c (source_cache::extract_lines): Handle case where
6024         first_pos==npos.  Return std::string.
6025         (source_cache::get_source_lines): Update.
6026
6027 2019-03-14  Tom Tromey  <tromey@adacore.com>
6028
6029         * NEWS: Add item for "style sources" commands.
6030         * source-cache.c (source_cache::get_source_lines): Check
6031         source_styling.
6032         * cli/cli-style.c (source_styling): New global.
6033         (_initialize_cli_style): Add "style sources" commands.
6034         (show_style_sources): New function.
6035         * cli/cli-style.h (source_styling): Declare.
6036
6037 2019-03-14  Pedro Alves  <palves@redhat.com>
6038             Tom Tromey  <tromey@adacore.com>
6039
6040         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6041         * tui/tui-winsource.c (tui_refill_source_window): New function,
6042         from...
6043         (tui_horizontal_source_scroll): ... here.  Move some logic.
6044         * cli/cli-style.c (set_style_enabled): Notify new observable.
6045         * tui/tui-hooks.c (tui_redisplay_source): New function.
6046         (tui_attach_detach_observers): Attach or detach
6047         tui_redisplay_source.
6048         * observable.h (source_styling_changed): New observable.
6049         * observable.c: Define source_styling_changed observable.
6050
6051 2019-03-13  Tom Tromey  <tromey@adacore.com>
6052
6053         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6054         (i386_gnu_nat_target::store_registers): Update.
6055         * target-debug.h (target_debug_print_std_string): New macro.
6056         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6057         * windows-tdep.c (display_one_tib): Update.
6058         * tui/tui-stack.c (tui_make_status_line): Update.
6059         * top.c (print_inferior_quit_action): Update.
6060         * thread.c (thr_try_catch_cmd): Update.
6061         (add_thread_with_info): Update.
6062         (thread_target_id_str): Update.
6063         (thr_try_catch_cmd): Update.
6064         (thread_command): Update.
6065         (thread_find_command): Update.
6066         * record-btrace.c (record_btrace_target::info_record)
6067         (record_btrace_resume_thread, record_btrace_target::resume)
6068         (record_btrace_cancel_resume, record_btrace_step_thread)
6069         (record_btrace_target::wait, record_btrace_target::wait)
6070         (record_btrace_target::wait, record_btrace_target::stop): Update.
6071         * progspace.c (print_program_space): Update.
6072         * process-stratum-target.c
6073         (process_stratum_target::thread_address_space): Update.
6074         * linux-fork.c (linux_fork_mourn_inferior)
6075         (detach_checkpoint_command, info_checkpoints_command)
6076         (linux_fork_context): Update.
6077         (linux_fork_detach): Update.
6078         (class scoped_switch_fork_info): Update.
6079         (delete_checkpoint_command): Update.
6080         * infrun.c (follow_fork_inferior): Update.
6081         (follow_fork_inferior): Update.
6082         (proceed_after_vfork_done): Update.
6083         (handle_vfork_child_exec_or_exit): Update.
6084         (follow_exec): Update.
6085         (displaced_step_prepare_throw): Update.
6086         (displaced_step_restore): Update.
6087         (start_step_over): Update.
6088         (resume_1): Update.
6089         (clear_proceed_status_thread): Update.
6090         (proceed): Update.
6091         (print_target_wait_results): Update.
6092         (do_target_wait): Update.
6093         (context_switch): Update.
6094         (stop_all_threads): Update.
6095         (restart_threads): Update.
6096         (finish_step_over): Update.
6097         (handle_signal_stop): Update.
6098         (switch_back_to_stepped_thread): Update.
6099         (keep_going_pass_signal): Update.
6100         (print_exited_reason): Update.
6101         (normal_stop): Update.
6102         * inferior.c (inferior_pid_to_str): Change return type.
6103         (print_selected_inferior): Update.
6104         (add_inferior): Update.
6105         (detach_inferior): Update.
6106         * dummy-frame.c (fprint_dummy_frames): Update.
6107         * dcache.c (dcache_info_1): Update.
6108         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6109         (btrace_fetch, btrace_clear): Update.
6110         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6111         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6112         type.
6113         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6114         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6115         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6116         * gdbarch.c, gdbarch.h: Rebuild.
6117         * gdbarch.sh (core_pid_to_str): Change return type.
6118         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6119         return type.
6120         (windows_nat_target::pid_to_str): Change return type.
6121         (windows_delete_thread): Update.
6122         (windows_nat_target::attach): Update.
6123         (windows_nat_target::files_info): Update.
6124         * target-delegates.c: Rebuild.
6125         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6126         return type.
6127         (sol_thread_target::pid_to_str): Change return type.
6128         * remote.c (class remote_target) <pid_to_str>: Change return
6129         type.
6130         (remote_target::pid_to_str): Change return type.
6131         (extended_remote_target::attach, remote_target::remote_stop_ns)
6132         (remote_target::remote_notif_remove_queued_reply)
6133         (remote_target::push_stop_reply, remote_target::disable_btrace):
6134         Update.
6135         (extended_remote_target::attach): Update.
6136         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6137         type.
6138         (gdbsim_target::pid_to_str): Change return type.
6139         * ravenscar-thread.c (struct ravenscar_thread_target)
6140         <pid_to_str>: Change return type.
6141         (ravenscar_thread_target::pid_to_str): Change return type.
6142         * procfs.c (class procfs_target) <pid_to_str>: Change return
6143         type.
6144         (procfs_target::pid_to_str): Change return type.
6145         (procfs_target::attach): Update.
6146         (procfs_target::detach): Update.
6147         (procfs_target::fetch_registers): Update.
6148         (procfs_target::store_registers): Update.
6149         (procfs_target::wait): Update.
6150         (procfs_target::files_info): Update.
6151         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6152         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6153         return type.
6154         (nto_procfs_target::pid_to_str): Change return type.
6155         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6156         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6157         return type.
6158         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6159         (exit_lwp): Update.
6160         (attach_proc_task_lwp_callback, get_detach_signal)
6161         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6162         (linux_nat_target::resume, wait_lwp, stop_callback)
6163         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6164         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6165         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6166         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6167         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6168         type.
6169         (inf_ptrace_target::attach): Update.
6170         (inf_ptrace_target::files_info): Update.
6171         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6172         type.
6173         (go32_nat_target::pid_to_str): Change return type.
6174         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6175         (gnu_nat_target::wait): Update.
6176         (gnu_nat_target::wait): Update.
6177         (gnu_nat_target::resume): Update.
6178         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6179         (fbsd_nat_target::wait): Update.
6180         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6181         type.
6182         (darwin_nat_target::attach): Update.
6183         * corelow.c (class core_target) <pid_to_str>: Change return type.
6184         (core_target::pid_to_str): Change return type.
6185         * target.c (normal_pid_to_str): Change return type.
6186         (default_pid_to_str): Likewise.
6187         (target_pid_to_str): Change return type.
6188         (target_translate_tls_address): Update.
6189         (target_announce_detach): Update.
6190         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6191         return type.
6192         (bsd_uthread_target::pid_to_str): Change return type.
6193         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6194         type.
6195         (bsd_kvm_target::pid_to_str): Change return type.
6196         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6197         return type.
6198         (aix_thread_target::pid_to_str): Change return type.
6199         * target.h (struct target_ops) <pid_to_str>: Change return type.
6200         (target_pid_to_str, normal_pid_to_str): Likewise.
6201         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6202         type.
6203         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6204         type.
6205         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6206         return type.
6207         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6208         type.
6209         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6210         type.
6211         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6212         return type.
6213
6214 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6215
6216         * NEWS: Mention that the new default MI version is 3.  Mention
6217         changes to the output of commands and events that deal with
6218         multi-location breakpoints.
6219         * breakpoint.c: Include "mi/mi-out.h".
6220         (print_one_breakpoint): Change output syntax if using MI version
6221         >= 3.
6222         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6223         New.
6224         (mi_multi_location_breakpoint_output_fixed): New.
6225         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6226         (mi_cmd_fix_multi_location_breakpoint_output): New.
6227         (mi_multi_location_breakpoint_output_fixed): New.
6228         * mi/mi-cmds.c (mi_cmds): Register command
6229         -fix-multi-location-breakpoint-output.
6230         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6231         interpreter "mi".
6232
6233 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6234
6235         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6236         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6237         instantiate mi_ui_out based on interpreter name.
6238         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6239         * mi/mi-main.c (mi_load_progress): Likewise.
6240
6241 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6242
6243         * NEWS: Combine separate "New targets" sections for 8.3.
6244
6245 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6246
6247         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6248         (ppcfbsd_init_abi): Install gdbarch
6249         "fetch_tls_load_module_address" and "get_thread_local_address"
6250         methods.
6251
6252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6253
6254         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6255         (riscv_fbsd_init_abi): Install gdbarch
6256         "fetch_tls_load_module_address" and "get_thread_local_address"
6257         methods.
6258
6259 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6260
6261         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6262         (i386fbsd_init_abi): Install gdbarch
6263         "fetch_tls_load_module_address" and "get_thread_local_address"
6264         methods.
6265
6266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6267
6268         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6269         (amd64fbsd_init_abi): Install gdbarch
6270         "fetch_tls_load_module_address" and "get_thread_local_address"
6271         methods.
6272
6273 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6274
6275         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6276         (struct fbsd_pspace_data): New type.
6277         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6278         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6279         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6280         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6281         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6282
6283 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6284
6285         * gdbtypes.c (lookup_struct_elt): New function.
6286         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6287         * gdbtypes.h (struct struct_elt): New type.
6288         (lookup_struct_elt): New prototype.
6289
6290 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6291
6292         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6293         remove disabled code block.
6294
6295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6296
6297         * gdbarch.sh (get_thread_local_address): New method.
6298         * gdbarch.h, gdbarch.c: Regenerate.
6299         * target.c (target_translate_tls_address): Use
6300         gdbarch_get_thread_local_address if present instead of
6301         target::get_thread_local_address.
6302
6303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6304
6305         * target.h (target::get_thread_local_address): Update comment.
6306
6307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6308
6309         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6310         objfile->separate_debug_objfile_backlink if not NULL.
6311
6312 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6313
6314         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6315         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6316         (amd64bsd_store_inferior_registers): Likewise.
6317         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6318         Enable segment base registers.
6319         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6320         PT_GETFSBASE and PT_GETGSBASE.
6321         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6322         PT_SETGSBASE.
6323         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6324         segment base registers.
6325         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6326
6327 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6328
6329         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6330         Update calls to i386_target_description to add 'segments'
6331         parameter.
6332         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6333         add segment base registers.
6334         * arch/i386.c (i386_create_target_description): Add 'segments'
6335         parameter to enable segment base registers.
6336         * arch/i386.h (i386_create_target_description): Likewise.
6337         * features/i386/32bit-segments.xml: New file.
6338         * features/i386/32bit-segments.c: Generate.
6339         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6340         call to i386_target_description to add 'segments' parameter.
6341         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6342         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6343         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6344         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6345         if feature is present.
6346         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6347         Add 'segments' parameter to call to i386_target_description.
6348         (i386_target_description): Add 'segments' parameter to enable
6349         segment base registers.
6350         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6351         to call to i386_target_description.
6352         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6353         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6354         Define I386_NUM_REGS.
6355         (i386_target_description): Add 'segments' parameter to enable
6356         segment base registers.
6357
6358 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6359
6360         PR/24325
6361         * source-cache.c: #undef open and close, to avoid unresolved
6362         externals during linking.
6363
6364 2019-03-12  Tom Tromey  <tromey@adacore.com>
6365
6366         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6367         const.  Add initializers.
6368         (_initialize_remote): Don't initialize ptid globals.
6369
6370 2019-03-12  Pedro Alves  <palves@redhat.com>
6371
6372         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6373
6374 2019-03-12  Pedro Alves  <palves@redhat.com>
6375
6376         * cp-name-parser.y (main): Remove unused 'len' variable.
6377
6378 2019-03-12  Tom Tromey  <tromey@adacore.com>
6379
6380         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6381         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6382
6383 2019-03-12  Tom Tromey  <tromey@adacore.com>
6384
6385         * linux-nat.c (iterate_over_lwps): Update.
6386         (stop_callback): Remove parameter.
6387         (stop_wait_callback, detach_callback, resume_set_callback)
6388         (select_singlestep_lwp_callback, set_ignore_sigint)
6389         (status_callback, resumed_callback, resume_clear_callback)
6390         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6391         data parameter.
6392         (linux_nat_target::detach, linux_nat_target::resume)
6393         (linux_stop_and_wait_all_lwps, select_event_lwp)
6394         (linux_nat_filter_event, linux_nat_wait_1)
6395         (linux_nat_target::kill, linux_nat_target::stop)
6396         (linux_nat_target::stop): Update.
6397         (linux_nat_resume_callback): Change type.
6398         (resume_stopped_resumed_lwps, count_events_callback)
6399         (select_event_lwp_callback): Likewise.
6400         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6401         * arm-linux-nat.c (struct update_registers_data): Remove.
6402         (update_registers_callback): Change type.
6403         (arm_linux_insert_hw_breakpoint1): Update.
6404         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6405         parameter.
6406         (x86_linux_dr_set_addr): Update.
6407         (x86_linux_dr_set_control): Update.
6408         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6409         (iterate_over_lwps): Use gdb::function_view.
6410         * nat/aarch64-linux-hw-point.c (struct
6411         aarch64_dr_update_callback_param): Remove.
6412         (debug_reg_change_callback): Change type.
6413         (aarch64_notify_debug_reg_change): Update.
6414         * s390-linux-nat.c (s390_refresh_per_info): Update.
6415
6416 2019-03-11  Tom Tromey  <tromey@adacore.com>
6417
6418         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6419         redundant assignment to "this_cu".
6420
6421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6422
6423         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6424
6425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6426
6427         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6428         from...
6429         (rank_one_type): ... this.
6430
6431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6432
6433         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6434         from...
6435         (rank_one_type): ... this.
6436
6437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6438
6439         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6440         from...
6441         (rank_one_type): ... this.
6442
6443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6444
6445         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6446         from...
6447         (rank_one_type): ... this.
6448
6449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6450
6451         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6452         from...
6453         (rank_one_type): ... this.
6454
6455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6456
6457         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6458         from...
6459         (rank_one_type): ... this.
6460
6461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6462
6463         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6464         from...
6465         (rank_one_type): ... this.
6466
6467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6468
6469         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6470         from...
6471         (rank_one_type): ... this.
6472
6473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6474
6475         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6476         from...
6477         (rank_one_type): ... this.
6478
6479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6480
6481         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6482         from...
6483         (rank_one_type): ... this.
6484
6485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6486
6487         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6488         from...
6489         (rank_one_type): ... this.
6490
6491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6492
6493         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6494         from...
6495         (rank_one_type): ... this.
6496
6497 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6498
6499         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6500         inferior-events' shows the example events.
6501
6502 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6503
6504         Support styling on native MS-Windows console
6505
6506         PR/24315
6507         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6508         on MS-Windows if $TERM is not defined.
6509
6510         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6511
6512         * posix-hdep.c (gdb_console_fputs):
6513         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6514         functions.
6515         * ui-file.h (gdb_console_fputs): Add prototype.
6516
6517         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6518         back to fputs only if the former returns zero.
6519
6520 2019-03-07  Tom Tromey  <tom@tromey.com>
6521
6522         * symmisc.c (print_symbol_bcache_statistics): Update.
6523         (print_objfile_statistics): Update.
6524         * symfile.c (allocate_symtab): Update.
6525         * stabsread.c: Don't include bcache.h.
6526         * psymtab.h (struct psymbol_bcache): Don't declare.
6527         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6528         (psymbol_bcache_init, psymbol_bcache_free)
6529         (psymbol_bcache_get_bcache): Don't declare.
6530         * psymtab.c (struct psymbol_bcache): Remove.
6531         (psymtab_storage::psymtab_storage): Update.
6532         (psymtab_storage::~psymtab_storage): Update.
6533         (psymbol_bcache_init, psymbol_bcache_free)
6534         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6535         (add_psymbol_to_bcache): Update.
6536         (allocate_psymtab): Update.
6537         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6538         macro_cache>: No longer pointers.
6539         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6540         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6541         * macrotab.c (macro_bcache): Update.
6542         * macroexp.c: Don't include bcache.h.
6543         * gdbtypes.c (check_types_worklist): Update.
6544         (types_deeply_equal): Remove TRY/CATCH.  Update.
6545         * elfread.c (elf_symtab_read): Update.
6546         * dwarf2read.c: Don't include bcache.h.
6547         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6548         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6549         (print_bcache_statistics, bcache_memory_used): Don't declare.
6550         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6551         methods.  Rename all data members.
6552         * bcache.c (struct bcache): Move to bcache.h.
6553         (bcache::expand_hash_table): Rename from expand_hash_table.
6554         (bcache): Remove.
6555         (bcache::insert): Rename from bcache_full.
6556         (bcache::compare): Rename from bcache_compare.
6557         (bcache_xmalloc): Remove.
6558         (bcache::~bcache): Rename from bcache_xfree.
6559         (bcache::print_statistics): Rename from print_bcache_statistics.
6560         (bcache::memory_used): Rename from bcache_memory_used.
6561
6562 2019-03-07  Pedro Alves  <palves@redhat.com>
6563
6564         * infrun.c (normal_stop): Also check for
6565         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6566
6567 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6568
6569         * f-lang.c (value_from_host_double): Moved to...
6570         * value.c (value_from_host_double): ...here.
6571         * value.h (value_from_host_double): Declare.
6572         * guile/scm-math.c (vlscm_convert_typed_number): Use
6573         value_from_host_double.
6574         (vlscm_convert_number): Likewise.
6575         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6576         * python/py-value.c (convert_value_from_python): Likewise.
6577
6578 2019-03-06  Tom Tromey  <tom@tromey.com>
6579
6580         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6581
6582 2019-03-06  Tom Tromey  <tom@tromey.com>
6583
6584         * utils.h (free_current_contents): Don't declare.
6585         * utils.c (free_current_contents): Remove.
6586
6587 2019-03-06  Tom Tromey  <tom@tromey.com>
6588
6589         * top.c (quit_force): Update.
6590         * main.c (captured_command_loop): Update.
6591         * common/new-op.c (operator new): Update.
6592         * common/common-exceptions.c (struct catcher)
6593         <save_cleanup_chain>: Remove member.
6594         (exceptions_state_mc_init): Update.
6595         (exception_try_scope_entry): Return nullptr.
6596         (exception_try_scope_exit, exception_rethrow)
6597         (throw_exception_sjlj, throw_exception_cxx): Update.
6598         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6599         (all_cleanups, do_cleanups, discard_cleanups)
6600         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6601         (restore_cleanups, restore_final_cleanups): Don't declare.
6602         (do_final_cleanups): Remove parameter.
6603         * common/cleanups.c (cleanup_chain, make_cleanup)
6604         (make_cleanup_dtor, all_cleanups, do_cleanups)
6605         (discard_my_cleanups, discard_cleanups)
6606         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6607         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6608         (null_cleanup): Remove.
6609         (do_final_cleanups): Remove parameter.
6610
6611 2019-03-06  Tom Tromey  <tom@tromey.com>
6612
6613         * remote.c (remote_target::remote_parse_stop_reply): Use
6614         unique_xmalloc_ptr.
6615
6616 2019-03-06  Tom Tromey  <tom@tromey.com>
6617
6618         * stabsread.c (struct stabs_field_info): Rename from field_info.
6619         <list, fnlist>: Add initializers.
6620         <obstack>: New member.
6621         (read_member_functions, read_struct_fields, read_baseclasses):
6622         Allocate on obstack.  Don't use cleanups.
6623         (read_one_struct_field, read_member_functions, read_struct_fields)
6624         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6625         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6626         (read_struct_type): Update.
6627
6628 2019-03-06  Tom Tromey  <tom@tromey.com>
6629
6630         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6631         * common/filestuff.h (make_cleanup_close): Don't declare.
6632         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6633         Remove.
6634
6635 2019-03-06  Tom Tromey  <tom@tromey.com>
6636
6637         * solib-aix.c: Use make_scope_exit.
6638
6639 2019-03-06  Tom Tromey  <tom@tromey.com>
6640
6641         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6642         Use make_scope_exit.
6643
6644 2019-03-06  Tom Tromey  <tom@tromey.com>
6645
6646         * solib-svr4.c (disable_probes_interface): Remove parameter.
6647         (svr4_handle_solib_event): Use make_scope_exit.
6648
6649 2019-03-06  Tom Tromey  <tom@tromey.com>
6650
6651         * remote.c (struct stop_reply_deleter): Remove.
6652         (stop_reply_up): Update.
6653         (struct stop_reply): Derive from notif_event.  Don't typedef.
6654         <regcache>: Now a std::vector.
6655         (stop_reply_xfree): Remove.
6656         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6657         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6658         (remote_target::discard_pending_stop_replies): Use delete.
6659         (remote_target::remote_parse_stop_reply): Update.
6660         (remote_target::process_stop_reply): Update.
6661         * remote-notif.h (struct notif_event): Add virtual destructor.
6662         Remove "dtr" member.
6663         (struct notif_client) <alloc_event>: Return a unique_ptr.
6664         (notif_event_xfree): Don't declare.
6665         (notif_event_up): New typedef.
6666         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6667         (notif_event_xfree, do_notif_event_xfree): Remove.
6668         (remote_notif_state_xfree): Update.
6669
6670 2019-03-06  Tom Tromey  <tom@tromey.com>
6671
6672         * infrun.c (displaced_step_clear_cleanup): Now a
6673         forward_scope_exit type.
6674         (displaced_step_prepare_throw): Update.
6675         (displaced_step_fixup): Update.
6676
6677 2019-03-06  Tom Tromey  <tom@tromey.com>
6678
6679         * inferior.h (class inferior): Update comment.
6680         * gdbthread.h (class thread_info): Update comment.
6681
6682 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6683             Tom Tromey  <tom@tromey.com>
6684
6685         * stabsread.h (struct stab_section_list): Remove.
6686         (coffstab_build_psymtabs): Update.
6687         * dbxread.c (symbuf_sections): Now a std::vector.
6688         (sect_idx): New global.
6689         (fill_symbuf): Update.
6690         (coffstab_build_psymtabs): Change type of stabsects parameter.
6691         Update.
6692         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6693         std::vector.
6694         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6695         (coff_locate_sections): Update.
6696         (coff_symfile_read): Remove cleanups.  Update.
6697         (init_stringtab): Add storage parameter.
6698         (free_stringtab, free_stringtab_cleanup): Remove.
6699         (init_lineno): Add storage parameter.
6700         (free_linetab, free_linetab_cleanup): Remove.
6701
6702 2019-03-06  Pedro Alves  <palves@redhat.com>
6703
6704         * linux-fork.c (fork_info::clobber_regs): Delete.
6705         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6706         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6707         comment.  Adjust.
6708         (scoped_switch_fork_info::scoped_switch_fork_info)
6709         (checkpoint_command, linux_fork_context): Adjust
6710         fork_save_infrun_state calls.
6711
6712 2019-03-06  Pedro Alves  <palves@redhat.com>
6713
6714         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6715         (inf_has_multiple_threads): Return 'bool' and rewrite using
6716         inferior_info::threads().
6717
6718 2019-03-06  Pedro Alves  <palves@redhat.com>
6719
6720         * linux-fork.c: Include <list>.
6721         (fork_list): Now a std::list instance.
6722         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6723         (forks_exist_p, find_last_fork): Adjust.
6724         (new_fork): Delete.
6725         (one_fork_p): New.
6726         (add_fork): Adjust.
6727         (free_fork): Delete, folded into fork_info::~fork_info().
6728         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6729         Adjust.
6730         (init_fork_list): Delete.
6731         (linux_fork_killall, linux_fork_mourn_inferior)
6732         (linux_fork_detach, info_checkpoints_command): Adjust.
6733         (_initialize_linux_fork): No longer call init_fork_list.
6734
6735 2019-03-06  Pedro Alves  <palves@redhat.com>
6736
6737         * linux-fork.c (new_fork): New, split out of ...
6738         (add_fork): ... this.  Return void.  Move "first fork" special
6739         case from here, to ...
6740         (checkpoint_command): ... here.
6741         * linux-linux.h (add_fork): Return void.
6742
6743 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6744
6745         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6746
6747 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6748             Chris January  <chris.january@arm.com>
6749             David Lecomber  <david.lecomber@arm.com>
6750
6751         * f-exp.y: New token, UNOP_INTRINSIC.
6752         (exp): New pattern using UNOP_INTRINSIC token.
6753         (f77_keywords): Add 'abs' keyword.
6754         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6755         (value_from_host_double): New function.
6756         (evaluate_subexp_f): Support UNOP_ABS.
6757
6758 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6759
6760         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6761         types.
6762
6763 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6764
6765         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6766         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6767         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6768
6769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6770
6771         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6772
6773 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6774             Chris January  <chris.january@arm.com>
6775
6776         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6777         * f-exp.y: Define 'KIND' token.
6778         (exp): New pattern for KIND expressions.
6779         (ptype): Handle types with a kind extension.
6780         (direct_abs_decl): Extend to spot kind extensions.
6781         (f77_keywords): Add 'kind' to the list.
6782         (push_kind_type): New function.
6783         (convert_to_kind_type): New function.
6784         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6785         * parse.c (operator_length_standard): Likewise.
6786         * parser-defs.h (enum type_pieces): Add tp_kind.
6787         * std-operator.def: Add UNOP_KIND.
6788
6789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6790
6791         * f-exp.y (f_parse): Set yydebug.
6792
6793 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6794
6795         * f-lang.c (evaluate_subexp_f): New function.
6796         (exp_descriptor_f): New global.
6797         (f_language_defn): Use exp_descriptor_f instead of
6798         exp_descriptor_standard.
6799
6800 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6801
6802         * f-exp.y (struct token): Add comments.
6803         (dot_ops): Remove uppercase versions and the end marker.
6804         (f77_keywords): Likewise.
6805         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6806         entries in the dot_ops array are case insensitive, and use
6807         strncasecmp to compare strings.  Also some whitespace cleanup in
6808         this area.  Similar for the f77_keywords array, except entries in
6809         this list might be case sensitive.
6810
6811 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6812
6813         * f-exp.y (struct f77_boolean_val): Add comments.
6814         (boolean_values): Remove uppercase versions, and end marker.
6815         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6816         and use strncasecmp to achieve case insensitivity.  Additionally,
6817         perform whitespace cleanup around this code.
6818
6819 2019-03-06  Tom Tromey  <tromey@adacore.com>
6820
6821         * remote-sim.c (gdbsim_target_open): Use result of
6822         gdb_argv::release.
6823
6824 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6825         Dirk Schubert  <dirk.schubert@arm.com>
6826         Chris January  <chris.january@arm.com>
6827
6828         * eval.c (evaluate_subexp_standard): Call Fortran argument
6829         wrapping logic.
6830         * f-lang.c (struct value): A value which can be passed into a
6831         Fortran function call.
6832         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6833         where appropriate.
6834         (struct type): Value ready for a Fortran function call.
6835         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6836         is needed.
6837         * f-lang.h (fortran_argument_convert): Declaration.
6838         (fortran_preserve_arg_pointer): Declaration.
6839         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6840
6841 2019-03-05  Tom Tromey  <tromey@adacore.com>
6842
6843         * python/py-prettyprint.c (print_string_repr): Remove #if.
6844         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6845
6846 2019-03-05  Tom Tromey  <tromey@adacore.com>
6847
6848         * target.c (the_dummy_target): Move later.  Change type to
6849         "dummy_target".
6850         (initialize_targets): Don't initialize the_dummy_target.
6851
6852 2019-03-05  Tom Tromey  <tromey@adacore.com>
6853
6854         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6855         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6856
6857 2019-03-05  Tom Tromey  <tromey@adacore.com>
6858
6859         * windows-nat.c (windows_nat_target::attach)
6860         (windows_nat_target::detach): Don't call gdb_flush.
6861         * valprint.c (generic_val_print, val_print, val_print_string):
6862         Don't call gdb_flush.
6863         * utils.c (defaulted_query): Don't call gdb_flush.
6864         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6865         * target.c (target_announce_detach): Don't call gdb_flush.
6866         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6867         * remote.c (extended_remote_target::attach): Don't call
6868         gdb_flush.
6869         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6870         * printcmd.c (do_examine): Don't call gdb_flush.
6871         (info_display_command): Don't call gdb_flush.
6872         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6873         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6874         * memattr.c (info_mem_command): Don't call gdb_flush.
6875         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6876         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6877         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6878         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6879         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6880         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6881         (gnu_nat_target::detach): Don't call gdb_flush.
6882         * f-valprint.c (f_val_print): Don't call gdb_flush.
6883         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6884         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6885         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6886         gdb_flush.
6887         * c-valprint.c (c_val_print): Don't call gdb_flush.
6888         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6889
6890 2019-03-05  Tom Tromey  <tromey@adacore.com>
6891
6892         * varobj.c (update_dynamic_varobj_children): Update.
6893         (install_default_visualizer): Use reset, not release.
6894         * value.c (set_internalvar): Update.
6895         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6896         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6897         ATTRIBUTE_UNUSED_RESULT.
6898
6899 2019-03-05  Tom Tromey  <tromey@adacore.com>
6900
6901         * remote.c (class scoped_remote_fd) <release>: Add
6902         ATTRIBUTE_UNUSED_RESULT.
6903
6904 2019-03-05  Tom Tromey  <tromey@adacore.com>
6905
6906         * macroexp.c (struct macro_buffer) <release>: Add
6907         ATTRIBUTE_UNUSED_RESULT.
6908
6909 2019-03-05  Tom Tromey  <tromey@adacore.com>
6910
6911         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6912         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6913         ATTRIBUTE_UNUSED_RESULT.
6914
6915 2019-03-05  Tom Tromey  <tromey@adacore.com>
6916
6917         * common/scoped_fd.h (class scoped_fd) <release>: Add
6918         ATTRIBUTE_UNUSED_RESULT.
6919
6920 2019-03-05  Tom Tromey  <tromey@adacore.com>
6921
6922         * parser-defs.h (struct parser_state) <release>: Add
6923         ATTRIBUTE_UNUSED_RESULT.
6924
6925 2019-03-05  Tom Tromey  <tromey@adacore.com>
6926
6927         * utils.h (class gdb_argv) <release>: Add
6928         ATTRIBUTE_UNUSED_RESULT.
6929         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6930
6931 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6932
6933         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6934         for-loop range, to avoid compiler warnings.
6935
6936         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6937         avoid compiler warnings about unused variables.
6938
6939         * NEWS: Mention end of support for native debugging on MS-Windows
6940         before XP.
6941
6942         PR gdb/24292
6943         * common/netstuff.c:
6944         * gdbserver/gdbreplay.c
6945         * gdbserver/remote-utils.c:
6946         * ser-tcp.c:
6947         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6948         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6949         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6950         'getaddrinfo' and 'freeaddrinfo' were not available before
6951         Windows XP, and mingw.org's MinGW headers by default define
6952         _WIN32_WINNT to 0x500.
6953
6954 2019-03-01  Gary Benson <gbenson@redhat.com>
6955
6956         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6957
6958 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6959             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6960
6961         PR gdb/8527
6962         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6963         set_sigint_trap, clear_sigint_trap.
6964
6965 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6966
6967         * target.c (target_detach): Clear the regcache and the
6968         frame cache.
6969
6970 2019-02-27  Pedro Alves  <palves@redhat.com>
6971
6972         * utils.c (set_screen_size): When we cap the height/width sizes,
6973         tweak the corresponding command variable to show "unlimited":
6974
6975 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6976             Pedro Alves  <palves@redhat.com>
6977
6978         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6979         before calling rl_set_screen_size.
6980
6981 2019-02-27  Tom Tromey  <tromey@adacore.com>
6982
6983         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6984         define.
6985         * python/py-value.c: Remove Python 2.4 workaround.
6986         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6987         workaround.
6988         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6989         Python 2.4 workaround.
6990         * python/python-internal.h: Remove Python 2.4 comment.
6991         (Py_ssize_t): Don't define.
6992         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6993         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6994         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6995         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6996         * python/python.c (do_start_initialization): Remove Python 2.4
6997         workaround.
6998         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6999         (print_children): Remove Python 2.4 workaround.
7000         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7001         workaround.
7002         (CHARBUFFERPROC_NAME): Remove.
7003         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7004         Python 2.4 workaround.
7005
7006 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7007
7008         * NEWS: Note minimum Python version.
7009
7010 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7011
7012         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7013         code from these functions.  Remove corresponding ifdefs.  Use
7014         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7015         Remove gotos and target of gotos.
7016         (infpy_search_memory): Likewise.
7017
7018 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7019
7020         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7021         (hppa_gdbarch_init): Don't register deleted functions with
7022         gdbarch.
7023
7024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7025
7026         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7027         (h8300_unwind_sp): Delete.
7028         (h8300_dummy_id): Delete.
7029         (h8300_gdbarch_init): Don't register deleted functions with
7030         gdbarch.
7031
7032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7033
7034         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7035         (ft32_unwind_pc): Delete.
7036         (ft32_unwind_sp): Delete.
7037         (ft32_gdbarch_init): Don't register deleted functions with
7038         gdbarch.
7039
7040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7041
7042         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7043         (frv_unwind_pc): Delete.
7044         (frv_unwind_sp): Delete.
7045         (frv_gdbarch_init): Don't register deleted functions with
7046         gdbarch.
7047
7048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7049
7050         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7051         (riscv_unwind_pc): Delete.
7052         (riscv_unwind_sp): Delete.
7053         (riscv_gdbarch_init): Don't register deleted functions with
7054         gdbarch.
7055
7056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7057
7058         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7059         (csky_unwind_pc): Delete.
7060         (csky_unwind_sp): Delete.
7061         (csky_gdbarch_init): Don't register deleted functions with
7062         gdbarch.
7063
7064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7065
7066         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7067         (cris_unwind_pc): Delete.
7068         (cris_unwind_sp): Delete.
7069         (cris_gdbarch_init): Don't register deleted functions with
7070         gdbarch.
7071
7072 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7073
7074         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7075         (bfin_unwind_pc): Delete.
7076         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7077
7078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7079
7080         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7081         (arm_unwind_pc): Delete.
7082         (arm_unwind_sp): Delete.
7083         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7084
7085 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7088         (arc_unwind_pc): Delete.
7089         (arc_unwind_sp): Delete.
7090         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7091
7092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7093
7094         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7095         (alpha_unwind_pc): Delete.
7096         (alpha_gdbarch_init): Don't register deleted functions with
7097         gdbarch.
7098
7099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7100
7101         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7102         (aarch64_unwind_pc): Delete.
7103         (aarch64_unwind_sp): Delete.
7104         (aarch64_gdbarch_init): Don't register deleted functions with
7105         gdbarch.
7106
7107 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7108
7109         * gdbtypes.c (type_align): Don't consider static members when
7110         computing structure alignment.
7111
7112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7115         return 0 for other types.
7116         * arch-utils.c (default_type_align): Always return 0.
7117         * gdbarch.h: Regenerate.
7118         * gdbarch.sh (type_align): Extend comment.
7119         * gdbtypes.c (type_align): Add additional comments, always call
7120         gdbarch_type_align before applying the default rules.
7121         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7122         generic code will then apply a suitable default.
7123         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7124         types, return 0 for other types.
7125
7126 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7127
7128         * NEWS: Create a new section for the next release branch.
7129         Rename the section of the current branch, now that it has
7130         been cut.
7131
7132 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7133
7134         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7135         * version.in: Bump version to 8.3.50.DATE-git.
7136
7137 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7138
7139         * aix-thread.c (ptid_cmp): Remove unused variable.
7140         (get_signaled_thread): Likewise.
7141         (store_regs_user_thread): Likewise.
7142         (store_regs_kernel_thread): Likewise.
7143         (fetch_regs_kernel_thread): Remove shadowed variable.
7144
7145 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7146
7147         * features/riscv/32bit-cpu.xml: Add register numbers.
7148         * features/riscv/32bit-fpu.c: Regenerate.
7149         * features/riscv/32bit-fpu.xml: Add register numbers.
7150         * features/riscv/64bit-cpu.xml: Add register numbers.
7151         * features/riscv/64bit-fpu.c: Regenerate.
7152         * features/riscv/64bit-fpu.xml: Add register numbers.
7153
7154 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7155
7156         * NEWS: Mention two argument form of gdb.Value constructor.
7157         * python/py-value.c (convert_buffer_and_type_to_value): New
7158         function.
7159         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7160         Add support for handling an optional second argument.  Call
7161         convert_buffer_and_type_to_value as appropriate.
7162         * python/python-internal.h (Py_buffer_deleter): New struct.
7163         (Py_buffer_up): New typedef.
7164
7165 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7166
7167         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7168         instead of releasing ownership.
7169
7170 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7171
7172         * dwarf2read.c (open_and_init_dwp_file): Call
7173         elf_numsections instead of bfd_count_sections to initialize
7174         dwp_file->num_sections.
7175
7176 2019-02-25  Tom Tromey  <tromey@adacore.com>
7177
7178         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7179
7180 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7181
7182         * gcore.in: Add '--readnever' option when invoking GDB.
7183
7184 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7185
7186         * MAINTAINERS: Update my email address.
7187
7188 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7189
7190         * build-id.c (build_id_to_debug_bfd_1): New function.
7191         (build_id_to_debug_bfd): Look for separate debug file in
7192         sysroot.
7193
7194 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7195
7196         * gdbarch.sh: Update the copyright year range that is placed into
7197         generated files.
7198
7199 2019-02-22  Keith Seitz  <keiths@redhat.com>
7200
7201         PR symtab/23853
7202         * linespec.c (create_sals_line_offset): Search for the default
7203         symtab's filename instead of its fullname.
7204
7205 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7206
7207         * NEWS: Update style defaults.
7208
7209 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7210
7211         * main.c (captured_main_1): Disable styling in batch mode.
7212
7213 2019-02-20  Tom Tromey  <tom@tromey.com>
7214
7215         * symtab.c (symtab_symbol_info): Fix typos.
7216
7217 2019-02-20  Tom Tromey  <tromey@adacore.com>
7218
7219         * findcmd.c (_initialize_mem_search): Use upper case for
7220         metasyntactic variables.
7221
7222 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7223
7224         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7225         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7226
7227 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7228
7229         * top.h (source_file_name): Change to std::string.
7230         * top.c (source_file_name): Likewise.
7231         (command_line_input): Adjust.
7232         * cli/cli-script.c (script_from_file): Adjust.
7233
7234 2019-02-19  Tom Tromey  <tromey@adacore.com>
7235
7236         * ravenscar-thread.c
7237         (ravenscar_thread_target::update_thread_list): Don't call
7238         ada_build_task_list.
7239         * ada-lang.h (ada_build_task_list): Don't declare.
7240         * ada-tasks.c (struct ada_tasks_inferior_data)
7241         <task_list_valid_p>: Now bool.
7242         (read_known_tasks, ada_task_list_changed)
7243         (ada_tasks_invalidate_inferior_data): Update.
7244         (read_known_tasks_array): Return bool.
7245         (read_known_tasks_list): Likewise.
7246         (read_known_tasks): Return void.
7247         (ada_build_task_list): Now static.
7248
7249 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7250
7251         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7252         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7253
7254 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7255
7256         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7257         variant for ada_tasks_pspace_data_handle and
7258         ada_tasks_inferior_data_handle.
7259         (ada_tasks_pspace_data_cleanup): New function.
7260         (ada_tasks_inferior_data_cleanup): New function.
7261
7262 2019-02-17  Tom Tromey  <tom@tromey.com>
7263
7264         * macrotab.h (macro_source_fullname): Return a std::string.
7265         * macrotab.c (macro_include, check_for_redefinition)
7266         (macro_undef, macro_lookup_definition, foreach_macro)
7267         (foreach_macro_in_scope): Update.
7268         (macro_source_fullname): Return a std::string.
7269         * macrocmd.c (show_pp_source_pos): Update.
7270
7271 2019-02-17  Tom Tromey  <tom@tromey.com>
7272
7273         * macrocmd.c (show_pp_source_pos): Style the file names.
7274
7275 2019-02-17  Tom Tromey  <tom@tromey.com>
7276
7277         PR tui/24197:
7278         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7279
7280 2019-02-17  Tom Tromey  <tom@tromey.com>
7281
7282         * ada-lang.c (user_select_syms): Use filtered printing.
7283         * utils.c (wrap_style): New global.
7284         (desired_style): Remove.
7285         (emit_style_escape): Add stream parameter.
7286         (set_output_style, reset_terminal_style, prompt_for_continue):
7287         Update.
7288         (flush_wrap_buffer): Only flush gdb_stdout.
7289         (wrap_here): Set wrap_style.
7290         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7291         treat escape sequences as a character.  Change when wrap buffer is
7292         flushed.
7293         (fputs_styled): Do not set the output style when the default is
7294         requested.
7295         * ui-style.h (struct ui_file_style) <is_default>: New method.
7296         * source.c (print_source_lines_base): Emit escape sequences in one
7297         piece.
7298
7299 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7300
7301         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7302         integers and enumeration types.
7303
7304 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7305
7306         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7307         instead of lookup_symbol_in_language
7308         (do_exact_match): New function.
7309         (ada_get_symbol_name_matcher): Return do_exact_match when
7310         doing a verbatim match.
7311
7312 2019-02-15  Tom Tromey  <tromey@adacore.com>
7313
7314         * ravenscar-thread.c (ravenscar_thread_target::resume)
7315         (ravenscar_thread_target::wait): Special case wildcard requests.
7316
7317 2019-02-15  Tom Tromey  <tromey@adacore.com>
7318
7319         * ravenscar-thread.c (base_ptid): Remove.
7320         (struct ravenscar_thread_target) <close>: New method.
7321         <m_base_ptid>: New member.
7322         <update_inferior_ptid, active_task, task_is_currently_active,
7323         runtime_initialized>: Declare methods.
7324         <ravenscar_thread_target>: Add constructor.
7325         (ravenscar_thread_target::task_is_currently_active)
7326         (ravenscar_thread_target::update_inferior_ptid)
7327         (ravenscar_runtime_initialized): Rename.  Now methods.
7328         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7329         (ravenscar_thread_target::update_thread_list): Update.
7330         (ravenscar_thread_target::active_task): Now method.
7331         (ravenscar_thread_target::store_registers)
7332         (ravenscar_thread_target::prepare_to_store)
7333         (ravenscar_thread_target::prepare_to_store)
7334         (ravenscar_thread_target::mourn_inferior): Update.
7335         (ravenscar_inferior_created): Use "new" to create target.
7336         (ravenscar_thread_target::get_ada_task_ptid): Update.
7337         (_initialize_ravenscar): Don't initialize base_ptid.
7338         (ravenscar_ops): Remove global.
7339
7340 2019-02-15  Tom Tromey  <tromey@adacore.com>
7341
7342         * target.h (push_target): Declare new overload.
7343         * target.c (push_target): New overload, taking an rvalue reference.
7344         * remote.c (remote_target::open_1): Use push_target overload.
7345         * corelow.c (core_target_open): Use push_target overload.
7346
7347 2019-02-15  Tom Tromey  <tromey@adacore.com>
7348
7349         * ravenscar-thread.c (is_ravenscar_task)
7350         (ravenscar_task_is_currently_active): Return bool.
7351         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7352         (_initialize_ravenscar): Remove "(void)".
7353         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7354         Return bool.
7355
7356 2019-02-15  Tom Tromey  <tromey@adacore.com>
7357
7358         * ravenscar-thread.c (ravenscar_runtime_initializer)
7359         (has_ravenscar_runtime, get_running_thread_id)
7360         (ravenscar_thread_target::resume): Fix indentation.
7361
7362 2019-02-15  Tom Tromey  <tromey@adacore.com>
7363
7364         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7365         from ravenscar_arch_ops.
7366         (sparc_ravenscar_ops::fetch_registers)
7367         (sparc_ravenscar_ops::store_registers): Now methods.
7368         (sparc_ravenscar_prepare_to_store): Remove.
7369         (sparc_ravenscar_ops): Redefine.
7370         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7371         methods and destructor.  Remove members.
7372         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7373         (ravenscar_thread_target::store_registers)
7374         (ravenscar_thread_target::prepare_to_store): Update.
7375         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7376         Remove.
7377         (struct ppc_ravenscar_powerpc_ops): Derive from
7378         ravenscar_arch_ops.
7379         (ppc_ravenscar_powerpc_ops::fetch_registers)
7380         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7381         (ppc_ravenscar_powerpc_ops): Redefine.
7382         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7383         (ppc_ravenscar_e500_ops::fetch_registers)
7384         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7385         (ppc_ravenscar_e500_ops): Redefine.
7386         * aarch64-ravenscar-thread.c
7387         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7388         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7389         (aarch64_ravenscar_fetch_registers)
7390         (aarch64_ravenscar_store_registers): Now methods.
7391         (aarch64_ravenscar_ops): Redefine.
7392
7393 2019-02-15  Tom Tromey  <tromey@adacore.com>
7394
7395         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7396         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7397         (ravenscar_thread_target::stopped_by_watchpoint)
7398         (ravenscar_thread_target::stopped_data_address)
7399         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7400
7401 2019-02-15  Tom Tromey  <tromey@adacore.com>
7402
7403         * ravenscar-thread.c: Fix some typos.
7404
7405 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7406             Tom Tromey  <tromey@adacore.com>
7407
7408         * ada-lang.c (ada_exception_sal): Change addr_string to a
7409         std::string.
7410         (create_ada_exception_catchpoint): Update.
7411
7412 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7413             Tom Tromey  <tromey@adacore.com>
7414
7415         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7416         (bp_location_ops): Remove.
7417         (base_breakpoint_allocate_location): Update.
7418         (free_bp_location): Update.
7419         * ada-lang.c (class ada_catchpoint_location)
7420         <ada_catchpoint_location>: Remove ops parameter.
7421         (ada_catchpoint_location_dtor): Remove.
7422         (ada_catchpoint_location_ops): Remove.
7423         (allocate_location_exception): Update.
7424         * breakpoint.h (struct bp_location_ops): Remove.
7425         (class bp_location) <bp_location>: Remove bp_location_ops
7426         parameter.
7427         <~bp_location>: Add destructor.
7428         <ops>: Remove.
7429
7430 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7431             Pedro Alves  <palves@redhat.com>
7432
7433         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7434         'PATH_MAX'.
7435
7436 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7437             Samuel Thibault  <samuel.thibault@gnu.org>
7438             Thomas Schwinge  <thomas@codesourcery.com>
7439
7440         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7441         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7442
7443 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7444
7445         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7446         (check_empty): Use "const char *".
7447
7448         * gnu-nat.c (gnu_nat_target::detach): Instead of
7449         'detach_inferior (pid)' call
7450         'detach_inferior (find_inferior_pid (pid))'.
7451
7452         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7453         'nat/fork-inferior.o'.
7454         * gnu-nat.c: #include "nat/fork-inferior.h".
7455
7456         * gnu-nat.c (gnu_nat_target::detach): Instead of
7457         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7458         * gnu-nat.h: #include "inf-child.h".
7459         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7460         'i386_gnu_nat_target::fetch_registers'.
7461         (gnu_store_registers): Rename/move to
7462         'i386_gnu_nat_target::store_registers'.
7463
7464         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7465         * gnu-nat.h (mach_thread_info): New function.
7466         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7467
7468         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7469
7470 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7471
7472         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7473
7474 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7475
7476         * windows-nat.c (windows_add_thread): Add new parameter
7477         "main_thread_p" with default value set to false.  Update
7478         function documentation as well as all callers.
7479         (windows_delete_thread): Likewise.
7480         (fake_create_process): Update call to windows_add_thread.
7481         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7482         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7483         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7484         call to windows_delete_thread.
7485
7486 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7487
7488         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7489
7490 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7491
7492         * symfile.c (find_separate_debug_file): Use canonical path of
7493         sysroot with child_path instead of gdb_sysroot if it is valid.
7494
7495 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7496
7497         * symfile.c (find_separate_debug_file): Use child_path to
7498         determine if an object file is under a sysroot.
7499
7500 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7501
7502         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7503         unittests/child-path-selftests.c.
7504         * common/pathstuff.c (child_path): New function.
7505         * common/pathstuff.h (child_path): New prototype.
7506         * unittests/child-path-selftests.c: New file.
7507
7508 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7509
7510         * symfile.c (find_separate_debug_file): Look for separate debug
7511         files in debug directories under the sysroot.
7512
7513 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7514
7515         * symtab.h (struct minimal_symbol data_p): New const method.
7516         (struct minimal_symbol text_p): Likewise.
7517         * symtab.c (output_source_filename): Use file name style
7518         to print file name.
7519         (print_symbol_info): Likewise.
7520         (print_msymbol_info): Use address style to print addresses.
7521         Use function name style to print executable text symbols.
7522         (expand_symtab_containing_pc): Use data_p.
7523         (find_pc_sect_compunit_symtab): Likewise.
7524
7525 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7526
7527         * breakpoint.c (describe_other_breakpoints): Use address style
7528         to print addresses.
7529         (say_where): Likewise.
7530
7531 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7532
7533         * ada-typeprint.c (print_func_type): Print function name
7534         style to print function name.
7535         * c-typeprint.c (c_print_type_1): Likewise.
7536
7537 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7538
7539         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7540         for execve.
7541
7542 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7543
7544         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7545         type_stack.
7546
7547 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7548
7549         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7550         TYPE_CODE_REF types.
7551
7552 2019-02-08  Jim Wilson  <jimw@sifive.com>
7553
7554         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7555         (riscv_linux_fregset): New.
7556         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7557
7558 2019-02-07  Tom Tromey  <tom@tromey.com>
7559
7560         * thread.c (thread_cancel_execution_command): Update.
7561         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7562         methods.
7563         (struct thread_fsm_ops): Remove.
7564         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7565         (thread_fsm_should_stop, thread_fsm_return_value)
7566         (thread_fsm_set_finished, thread_fsm_finished_p)
7567         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7568         Don't declare.
7569         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7570         * infrun.c (clear_proceed_status_thread)
7571         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7572         (print_stop_event): Update.
7573         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7574         Add constructor.
7575         (step_command_fsm_ops): Remove.
7576         (new_step_command_fsm): Remove.
7577         (step_1): Update.
7578         (step_command_fsm::should_stop): Rename from
7579         step_command_fsm_should_stop.
7580         (step_command_fsm::clean_up): Rename from
7581         step_command_fsm_clean_up.
7582         (step_command_fsm::do_async_reply_reason): Rename from
7583         step_command_fsm_async_reply_reason.
7584         (struct until_next_fsm): Inherit from thread_fsm.  Add
7585         constructor.
7586         (until_next_fsm_ops): Remove.
7587         (new_until_next_fsm): Remove.
7588         (until_next_fsm::should_stop): Rename from
7589         until_next_fsm_should_stop.
7590         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7591         (until_next_fsm::do_async_reply_reason): Rename from
7592         until_next_fsm_async_reply_reason.
7593         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7594         constructor.  Change type of breakpoint.
7595         (finish_command_fsm_ops): Remove.
7596         (new_finish_command_fsm): Remove.
7597         (finish_command_fsm::should_stop): Rename from
7598         finish_command_fsm_should_stop.
7599         (finish_command_fsm::clean_up): Rename from
7600         finish_command_fsm_clean_up.
7601         (finish_command_fsm::return_value): Rename from
7602         finish_command_fsm_return_value.
7603         (finish_command_fsm::do_async_reply_reason): Rename from
7604         finish_command_fsm_async_reply_reason.
7605         (finish_command): Update.
7606         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7607         Add constructor.
7608         (call_thread_fsm_ops): Remove.
7609         (call_thread_fsm::call_thread_fsm): Rename from
7610         new_call_thread_fsm.
7611         (call_thread_fsm::should_stop): Rename from
7612         call_thread_fsm_should_stop.
7613         (call_thread_fsm::should_notify_stop): Rename from
7614         call_thread_fsm_should_notify_stop.
7615         (run_inferior_call, call_function_by_hand_dummy): Update.
7616         * cli/cli-interp.c (should_print_stop_to_console): Update.
7617         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7618         Add constructor.  Change type of location_breakpoint,
7619         caller_breakpoint.
7620         (until_break_fsm_ops): Remove.
7621         (new_until_break_fsm): Remove.
7622         (until_break_fsm::should_stop): Rename from
7623         until_break_fsm_should_stop.
7624         (until_break_fsm::clean_up): Rename from
7625         until_break_fsm_clean_up.
7626         (until_break_fsm::do_async_reply_reason): Rename from
7627         until_break_fsm_async_reply_reason.
7628         (until_break_command): Update.
7629         * thread-fsm.c: Remove.
7630         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7631
7632 2019-02-07  Tom Tromey  <tom@tromey.com>
7633
7634         * yy-remap.h: Add include guard.
7635         * xtensa-tdep.h: Add include guard.
7636         * xcoffread.h: Rename include guard.
7637         * varobj-iter.h: Add include guard.
7638         * tui/tui.h: Rename include guard.
7639         * tui/tui-winsource.h: Rename include guard.
7640         * tui/tui-wingeneral.h: Rename include guard.
7641         * tui/tui-windata.h: Rename include guard.
7642         * tui/tui-win.h: Rename include guard.
7643         * tui/tui-stack.h: Rename include guard.
7644         * tui/tui-source.h: Rename include guard.
7645         * tui/tui-regs.h: Rename include guard.
7646         * tui/tui-out.h: Rename include guard.
7647         * tui/tui-layout.h: Rename include guard.
7648         * tui/tui-io.h: Rename include guard.
7649         * tui/tui-hooks.h: Rename include guard.
7650         * tui/tui-file.h: Rename include guard.
7651         * tui/tui-disasm.h: Rename include guard.
7652         * tui/tui-data.h: Rename include guard.
7653         * tui/tui-command.h: Rename include guard.
7654         * tic6x-tdep.h: Add include guard.
7655         * target/waitstatus.h: Rename include guard.
7656         * target/wait.h: Rename include guard.
7657         * target/target.h: Rename include guard.
7658         * target/resume.h: Rename include guard.
7659         * target-float.h: Rename include guard.
7660         * stabsread.h: Add include guard.
7661         * rs6000-tdep.h: Add include guard.
7662         * riscv-fbsd-tdep.h: Add include guard.
7663         * regformats/regdef.h: Rename include guard.
7664         * record.h: Rename include guard.
7665         * python/python.h: Rename include guard.
7666         * python/python-internal.h: Rename include guard.
7667         * python/py-stopevent.h: Rename include guard.
7668         * python/py-ref.h: Rename include guard.
7669         * python/py-record.h: Rename include guard.
7670         * python/py-record-full.h: Rename include guard.
7671         * python/py-record-btrace.h: Rename include guard.
7672         * python/py-instruction.h: Rename include guard.
7673         * python/py-events.h: Rename include guard.
7674         * python/py-event.h: Rename include guard.
7675         * procfs.h: Add include guard.
7676         * proc-utils.h: Add include guard.
7677         * p-lang.h: Add include guard.
7678         * or1k-tdep.h: Rename include guard.
7679         * observable.h: Rename include guard.
7680         * nto-tdep.h: Rename include guard.
7681         * nat/x86-linux.h: Rename include guard.
7682         * nat/x86-linux-dregs.h: Rename include guard.
7683         * nat/x86-gcc-cpuid.h: Add include guard.
7684         * nat/x86-dregs.h: Rename include guard.
7685         * nat/x86-cpuid.h: Rename include guard.
7686         * nat/ppc-linux.h: Rename include guard.
7687         * nat/mips-linux-watch.h: Rename include guard.
7688         * nat/linux-waitpid.h: Rename include guard.
7689         * nat/linux-ptrace.h: Rename include guard.
7690         * nat/linux-procfs.h: Rename include guard.
7691         * nat/linux-osdata.h: Rename include guard.
7692         * nat/linux-nat.h: Rename include guard.
7693         * nat/linux-namespaces.h: Rename include guard.
7694         * nat/linux-btrace.h: Rename include guard.
7695         * nat/glibc_thread_db.h: Rename include guard.
7696         * nat/gdb_thread_db.h: Rename include guard.
7697         * nat/gdb_ptrace.h: Rename include guard.
7698         * nat/fork-inferior.h: Rename include guard.
7699         * nat/amd64-linux-siginfo.h: Rename include guard.
7700         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7701         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7702         * nat/aarch64-linux.h: Rename include guard.
7703         * nat/aarch64-linux-hw-point.h: Rename include guard.
7704         * mn10300-tdep.h: Add include guard.
7705         * mips-linux-tdep.h: Add include guard.
7706         * mi/mi-parse.h: Rename include guard.
7707         * mi/mi-out.h: Rename include guard.
7708         * mi/mi-main.h: Rename include guard.
7709         * mi/mi-interp.h: Rename include guard.
7710         * mi/mi-getopt.h: Rename include guard.
7711         * mi/mi-console.h: Rename include guard.
7712         * mi/mi-common.h: Rename include guard.
7713         * mi/mi-cmds.h: Rename include guard.
7714         * mi/mi-cmd-break.h: Rename include guard.
7715         * m2-lang.h: Add include guard.
7716         * location.h: Rename include guard.
7717         * linux-record.h: Rename include guard.
7718         * linux-nat.h: Add include guard.
7719         * linux-fork.h: Add include guard.
7720         * i386-darwin-tdep.h: Rename include guard.
7721         * hppa-linux-offsets.h: Add include guard.
7722         * guile/guile.h: Rename include guard.
7723         * guile/guile-internal.h: Rename include guard.
7724         * gnu-nat.h: Rename include guard.
7725         * gdb-stabs.h: Rename include guard.
7726         * frv-tdep.h: Add include guard.
7727         * f-lang.h: Add include guard.
7728         * event-loop.h: Add include guard.
7729         * darwin-nat.h: Rename include guard.
7730         * cp-abi.h: Rename include guard.
7731         * config/sparc/nm-sol2.h: Rename include guard.
7732         * config/nm-nto.h: Rename include guard.
7733         * config/nm-linux.h: Add include guard.
7734         * config/i386/nm-i386gnu.h: Rename include guard.
7735         * config/djgpp/nl_types.h: Rename include guard.
7736         * config/djgpp/langinfo.h: Rename include guard.
7737         * compile/gcc-cp-plugin.h: Add include guard.
7738         * compile/gcc-c-plugin.h: Add include guard.
7739         * compile/compile.h: Rename include guard.
7740         * compile/compile-object-run.h: Rename include guard.
7741         * compile/compile-object-load.h: Rename include guard.
7742         * compile/compile-internal.h: Rename include guard.
7743         * compile/compile-cplus.h: Rename include guard.
7744         * compile/compile-c.h: Rename include guard.
7745         * common/xml-utils.h: Rename include guard.
7746         * common/x86-xstate.h: Rename include guard.
7747         * common/version.h: Rename include guard.
7748         * common/vec.h: Rename include guard.
7749         * common/tdesc.h: Rename include guard.
7750         * common/selftest.h: Rename include guard.
7751         * common/scoped_restore.h: Rename include guard.
7752         * common/scoped_mmap.h: Rename include guard.
7753         * common/scoped_fd.h: Rename include guard.
7754         * common/safe-iterator.h: Rename include guard.
7755         * common/run-time-clock.h: Rename include guard.
7756         * common/refcounted-object.h: Rename include guard.
7757         * common/queue.h: Rename include guard.
7758         * common/ptid.h: Rename include guard.
7759         * common/print-utils.h: Rename include guard.
7760         * common/preprocessor.h: Rename include guard.
7761         * common/pathstuff.h: Rename include guard.
7762         * common/observable.h: Rename include guard.
7763         * common/netstuff.h: Rename include guard.
7764         * common/job-control.h: Rename include guard.
7765         * common/host-defs.h: Rename include guard.
7766         * common/gdb_wait.h: Rename include guard.
7767         * common/gdb_vecs.h: Rename include guard.
7768         * common/gdb_unlinker.h: Rename include guard.
7769         * common/gdb_unique_ptr.h: Rename include guard.
7770         * common/gdb_tilde_expand.h: Rename include guard.
7771         * common/gdb_sys_time.h: Rename include guard.
7772         * common/gdb_string_view.h: Rename include guard.
7773         * common/gdb_splay_tree.h: Rename include guard.
7774         * common/gdb_setjmp.h: Rename include guard.
7775         * common/gdb_ref_ptr.h: Rename include guard.
7776         * common/gdb_optional.h: Rename include guard.
7777         * common/gdb_locale.h: Rename include guard.
7778         * common/gdb_assert.h: Rename include guard.
7779         * common/filtered-iterator.h: Rename include guard.
7780         * common/filestuff.h: Rename include guard.
7781         * common/fileio.h: Rename include guard.
7782         * common/environ.h: Rename include guard.
7783         * common/common-utils.h: Rename include guard.
7784         * common/common-types.h: Rename include guard.
7785         * common/common-regcache.h: Rename include guard.
7786         * common/common-inferior.h: Rename include guard.
7787         * common/common-gdbthread.h: Rename include guard.
7788         * common/common-exceptions.h: Rename include guard.
7789         * common/common-defs.h: Rename include guard.
7790         * common/common-debug.h: Rename include guard.
7791         * common/cleanups.h: Rename include guard.
7792         * common/buffer.h: Rename include guard.
7793         * common/btrace-common.h: Rename include guard.
7794         * common/break-common.h: Rename include guard.
7795         * cli/cli-utils.h: Rename include guard.
7796         * cli/cli-style.h: Rename include guard.
7797         * cli/cli-setshow.h: Rename include guard.
7798         * cli/cli-script.h: Rename include guard.
7799         * cli/cli-interp.h: Rename include guard.
7800         * cli/cli-decode.h: Rename include guard.
7801         * cli/cli-cmds.h: Rename include guard.
7802         * charset-list.h: Add include guard.
7803         * buildsym-legacy.h: Rename include guard.
7804         * bfin-tdep.h: Add include guard.
7805         * ax.h: Rename include guard.
7806         * arm-linux-tdep.h: Add include guard.
7807         * arm-fbsd-tdep.h: Add include guard.
7808         * arch/xtensa.h: Rename include guard.
7809         * arch/tic6x.h: Add include guard.
7810         * arch/i386.h: Add include guard.
7811         * arch/arm.h: Rename include guard.
7812         * arch/arm-linux.h: Rename include guard.
7813         * arch/arm-get-next-pcs.h: Rename include guard.
7814         * arch/amd64.h: Add include guard.
7815         * arch/aarch64-insn.h: Rename include guard.
7816         * arch-utils.h: Rename include guard.
7817         * annotate.h: Add include guard.
7818         * amd64-darwin-tdep.h: Rename include guard.
7819         * aarch64-linux-tdep.h: Add include guard.
7820         * aarch64-fbsd-tdep.h: Add include guard.
7821         * aarch32-linux-nat.h: Add include guard.
7822
7823 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7824
7825         * macrotab.c (macro_define_internal): New function that
7826         factorizes macro_define_object_internal and macro_define_function
7827         code.
7828         (macro_define_object_internal): Use macro_define_internal.
7829         (macro_define_function): Likewise.
7830
7831 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7832
7833         * macrocmd.c (extract_identifier): Return
7834         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7835         callers.
7836
7837 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7838
7839         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7840
7841 2019-02-05  Tom Tromey  <tom@tromey.com>
7842
7843         * target.c (target_stack::unpush): Move assertion earlier.
7844
7845 2019-01-30  Tom Tromey  <tom@tromey.com>
7846
7847         PR python/23615:
7848         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7849         (gdbpy_parse_and_eval): Likewise.
7850         * python/python-internal.h (gdbpy_allow_threads): New class.
7851
7852 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7853
7854         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7855         (aarch64_fbsd_fpregmap): Move earlier.
7856         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7857         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7858         instead of individual calls to trad_frame_set_reg_addr.
7859         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7860         earlier.
7861         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7862         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7863         instead of individual calls to trad_frame_set_reg_addr.
7864
7865 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7866
7867         * CONTRIBUTE: Replace contribution list with wiki link.
7868
7869 2019-01-25  Tom Tromey  <tom@tromey.com>
7870
7871         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7872
7873 2019-01-25  Tom Tromey  <tom@tromey.com>
7874
7875         * xtensa-linux-nat.c: Fix common/ includes.
7876         * xml-support.h: Fix common/ includes.
7877         * xml-support.c: Fix common/ includes.
7878         * x86-linux-nat.c: Fix common/ includes.
7879         * windows-nat.c: Fix common/ includes.
7880         * varobj.h: Fix common/ includes.
7881         * varobj.c: Fix common/ includes.
7882         * value.c: Fix common/ includes.
7883         * valops.c: Fix common/ includes.
7884         * utils.c: Fix common/ includes.
7885         * unittests/xml-utils-selftests.c: Fix common/ includes.
7886         * unittests/utils-selftests.c: Fix common/ includes.
7887         * unittests/unpack-selftests.c: Fix common/ includes.
7888         * unittests/tracepoint-selftests.c: Fix common/ includes.
7889         * unittests/style-selftests.c: Fix common/ includes.
7890         * unittests/string_view-selftests.c: Fix common/ includes.
7891         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7892         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7893         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7894         * unittests/rsp-low-selftests.c: Fix common/ includes.
7895         * unittests/parse-connection-spec-selftests.c: Fix common/
7896         includes.
7897         * unittests/optional-selftests.c: Fix common/ includes.
7898         * unittests/offset-type-selftests.c: Fix common/ includes.
7899         * unittests/observable-selftests.c: Fix common/ includes.
7900         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7901         * unittests/memrange-selftests.c: Fix common/ includes.
7902         * unittests/memory-map-selftests.c: Fix common/ includes.
7903         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7904         * unittests/function-view-selftests.c: Fix common/ includes.
7905         * unittests/environ-selftests.c: Fix common/ includes.
7906         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7907         * unittests/common-utils-selftests.c: Fix common/ includes.
7908         * unittests/cli-utils-selftests.c: Fix common/ includes.
7909         * unittests/array-view-selftests.c: Fix common/ includes.
7910         * ui-file.c: Fix common/ includes.
7911         * tui/tui-io.c: Fix common/ includes.
7912         * tracepoint.h: Fix common/ includes.
7913         * tracepoint.c: Fix common/ includes.
7914         * tracefile-tfile.c: Fix common/ includes.
7915         * top.h: Fix common/ includes.
7916         * top.c: Fix common/ includes.
7917         * thread.c: Fix common/ includes.
7918         * target/waitstatus.h: Fix common/ includes.
7919         * target/waitstatus.c: Fix common/ includes.
7920         * target.h: Fix common/ includes.
7921         * target.c: Fix common/ includes.
7922         * target-memory.c: Fix common/ includes.
7923         * target-descriptions.c: Fix common/ includes.
7924         * symtab.h: Fix common/ includes.
7925         * symfile.c: Fix common/ includes.
7926         * stap-probe.c: Fix common/ includes.
7927         * spu-linux-nat.c: Fix common/ includes.
7928         * sparc-nat.c: Fix common/ includes.
7929         * source.c: Fix common/ includes.
7930         * solib.c: Fix common/ includes.
7931         * solib-target.c: Fix common/ includes.
7932         * ser-unix.c: Fix common/ includes.
7933         * ser-tcp.c: Fix common/ includes.
7934         * ser-pipe.c: Fix common/ includes.
7935         * ser-base.c: Fix common/ includes.
7936         * selftest-arch.c: Fix common/ includes.
7937         * s12z-tdep.c: Fix common/ includes.
7938         * rust-exp.y: Fix common/ includes.
7939         * rs6000-aix-tdep.c: Fix common/ includes.
7940         * riscv-tdep.c: Fix common/ includes.
7941         * remote.c: Fix common/ includes.
7942         * remote-notif.h: Fix common/ includes.
7943         * remote-fileio.h: Fix common/ includes.
7944         * remote-fileio.c: Fix common/ includes.
7945         * regcache.h: Fix common/ includes.
7946         * regcache.c: Fix common/ includes.
7947         * record-btrace.c: Fix common/ includes.
7948         * python/python.c: Fix common/ includes.
7949         * python/py-type.c: Fix common/ includes.
7950         * python/py-inferior.c: Fix common/ includes.
7951         * progspace.h: Fix common/ includes.
7952         * producer.c: Fix common/ includes.
7953         * procfs.c: Fix common/ includes.
7954         * proc-api.c: Fix common/ includes.
7955         * printcmd.c: Fix common/ includes.
7956         * ppc-linux-nat.c: Fix common/ includes.
7957         * parser-defs.h: Fix common/ includes.
7958         * osdata.c: Fix common/ includes.
7959         * obsd-nat.c: Fix common/ includes.
7960         * nat/x86-linux.c: Fix common/ includes.
7961         * nat/x86-linux-dregs.c: Fix common/ includes.
7962         * nat/x86-dregs.h: Fix common/ includes.
7963         * nat/x86-dregs.c: Fix common/ includes.
7964         * nat/ppc-linux.c: Fix common/ includes.
7965         * nat/mips-linux-watch.h: Fix common/ includes.
7966         * nat/mips-linux-watch.c: Fix common/ includes.
7967         * nat/linux-waitpid.c: Fix common/ includes.
7968         * nat/linux-ptrace.h: Fix common/ includes.
7969         * nat/linux-ptrace.c: Fix common/ includes.
7970         * nat/linux-procfs.c: Fix common/ includes.
7971         * nat/linux-personality.c: Fix common/ includes.
7972         * nat/linux-osdata.c: Fix common/ includes.
7973         * nat/linux-namespaces.c: Fix common/ includes.
7974         * nat/linux-btrace.h: Fix common/ includes.
7975         * nat/linux-btrace.c: Fix common/ includes.
7976         * nat/fork-inferior.c: Fix common/ includes.
7977         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7978         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7979         * nat/aarch64-linux.c: Fix common/ includes.
7980         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7981         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7982         * namespace.h: Fix common/ includes.
7983         * mips-linux-tdep.c: Fix common/ includes.
7984         * minsyms.c: Fix common/ includes.
7985         * mi/mi-parse.h: Fix common/ includes.
7986         * mi/mi-main.c: Fix common/ includes.
7987         * mi/mi-cmd-env.c: Fix common/ includes.
7988         * memrange.h: Fix common/ includes.
7989         * memattr.c: Fix common/ includes.
7990         * maint.h: Fix common/ includes.
7991         * maint.c: Fix common/ includes.
7992         * main.c: Fix common/ includes.
7993         * machoread.c: Fix common/ includes.
7994         * location.c: Fix common/ includes.
7995         * linux-thread-db.c: Fix common/ includes.
7996         * linux-nat.c: Fix common/ includes.
7997         * linux-fork.c: Fix common/ includes.
7998         * inline-frame.c: Fix common/ includes.
7999         * infrun.c: Fix common/ includes.
8000         * inflow.c: Fix common/ includes.
8001         * inferior.h: Fix common/ includes.
8002         * inferior.c: Fix common/ includes.
8003         * infcmd.c: Fix common/ includes.
8004         * inf-ptrace.c: Fix common/ includes.
8005         * inf-child.c: Fix common/ includes.
8006         * ia64-linux-nat.c: Fix common/ includes.
8007         * i387-tdep.c: Fix common/ includes.
8008         * i386-tdep.c: Fix common/ includes.
8009         * i386-linux-tdep.c: Fix common/ includes.
8010         * i386-linux-nat.c: Fix common/ includes.
8011         * i386-go32-tdep.c: Fix common/ includes.
8012         * i386-fbsd-tdep.c: Fix common/ includes.
8013         * i386-fbsd-nat.c: Fix common/ includes.
8014         * guile/scm-type.c: Fix common/ includes.
8015         * guile/guile.c: Fix common/ includes.
8016         * go32-nat.c: Fix common/ includes.
8017         * gnu-nat.c: Fix common/ includes.
8018         * gdbthread.h: Fix common/ includes.
8019         * gdbarch-selftests.c: Fix common/ includes.
8020         * gdb_usleep.c: Fix common/ includes.
8021         * gdb_select.h: Fix common/ includes.
8022         * gdb_bfd.c: Fix common/ includes.
8023         * gcore.c: Fix common/ includes.
8024         * fork-child.c: Fix common/ includes.
8025         * findvar.c: Fix common/ includes.
8026         * fbsd-nat.c: Fix common/ includes.
8027         * event-top.c: Fix common/ includes.
8028         * event-loop.c: Fix common/ includes.
8029         * dwarf2read.c: Fix common/ includes.
8030         * dwarf2loc.c: Fix common/ includes.
8031         * dwarf2-frame.c: Fix common/ includes.
8032         * dwarf-index-cache.c: Fix common/ includes.
8033         * dtrace-probe.c: Fix common/ includes.
8034         * disasm-selftests.c: Fix common/ includes.
8035         * defs.h: Fix common/ includes.
8036         * csky-tdep.c: Fix common/ includes.
8037         * cp-valprint.c: Fix common/ includes.
8038         * cp-support.h: Fix common/ includes.
8039         * cp-support.c: Fix common/ includes.
8040         * corelow.c: Fix common/ includes.
8041         * completer.h: Fix common/ includes.
8042         * completer.c: Fix common/ includes.
8043         * compile/compile.c: Fix common/ includes.
8044         * compile/compile-loc2c.c: Fix common/ includes.
8045         * compile/compile-cplus-types.c: Fix common/ includes.
8046         * compile/compile-cplus-symbols.c: Fix common/ includes.
8047         * command.h: Fix common/ includes.
8048         * cli/cli-dump.c: Fix common/ includes.
8049         * cli/cli-cmds.c: Fix common/ includes.
8050         * charset.c: Fix common/ includes.
8051         * build-id.c: Fix common/ includes.
8052         * btrace.h: Fix common/ includes.
8053         * btrace.c: Fix common/ includes.
8054         * breakpoint.h: Fix common/ includes.
8055         * breakpoint.c: Fix common/ includes.
8056         * ax.h:
8057         (enum agent_op): Fix common/ includes.
8058         * ax-general.c (struct aop_map): Fix common/ includes.
8059         * ax-gdb.c: Fix common/ includes.
8060         * auxv.c: Fix common/ includes.
8061         * auto-load.c: Fix common/ includes.
8062         * arm-tdep.c: Fix common/ includes.
8063         * arch/riscv.c: Fix common/ includes.
8064         * arch/ppc-linux-common.c: Fix common/ includes.
8065         * arch/i386.c: Fix common/ includes.
8066         * arch/arm.c: Fix common/ includes.
8067         * arch/arm-linux.c: Fix common/ includes.
8068         * arch/arm-get-next-pcs.c: Fix common/ includes.
8069         * arch/amd64.c: Fix common/ includes.
8070         * arch/aarch64.c: Fix common/ includes.
8071         * arch/aarch64-insn.c: Fix common/ includes.
8072         * arch-utils.c: Fix common/ includes.
8073         * amd64-windows-tdep.c: Fix common/ includes.
8074         * amd64-tdep.c: Fix common/ includes.
8075         * amd64-sol2-tdep.c: Fix common/ includes.
8076         * amd64-obsd-tdep.c: Fix common/ includes.
8077         * amd64-nbsd-tdep.c: Fix common/ includes.
8078         * amd64-linux-tdep.c: Fix common/ includes.
8079         * amd64-linux-nat.c: Fix common/ includes.
8080         * amd64-fbsd-tdep.c: Fix common/ includes.
8081         * amd64-fbsd-nat.c: Fix common/ includes.
8082         * amd64-dicos-tdep.c: Fix common/ includes.
8083         * amd64-darwin-tdep.c: Fix common/ includes.
8084         * agent.c: Fix common/ includes.
8085         * ada-lang.h: Fix common/ includes.
8086         * ada-lang.c: Fix common/ includes.
8087         * aarch64-tdep.c: Fix common/ includes.
8088
8089 2019-01-25  Tom Tromey  <tom@tromey.com>
8090
8091         * common/create-version.sh: Use common/version.h.
8092
8093 2019-01-24  Pedro Alves  <palves@redhat.com>
8094
8095         * infrun.c (signal_stop, signal_print, signal_program)
8096         (signal_catch, signal_pass): Now arrays instead of pointers.
8097         (update_signals_program_target, do_target_resume)
8098         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8099         * linux-nat.c (linux_nat_target::pass_signals)
8100         (linux_nat_target::create_inferior, linux_nat_target::attach):
8101         Adjust.
8102         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8103         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8104         * procfs.c (procfs_target::pass_signals): Adjust.
8105         * record-full.c (record_full_target::resume): Adjust.
8106         * remote.c (remote_target::pass_signals)
8107         (remote_target::program_signals): Adjust.
8108         * target-debug.h (target_debug_print_signals): Now takes a
8109         gdb::array_view as parameter.  Adjust.
8110         * target.h (target_ops) <pass_signals, program_signals>: Replace
8111         pointer and length parameters with gdb::array_view.
8112         (target_pass_signals, target_program_signals): Likewise.
8113         * target-delegates.c: Regenerate.
8114
8115 2019-01-24  Pedro Alves  <palves@redhat.com>
8116
8117         * common/forward-scope-exit.h
8118         (forward_scope_exit::forward_scope_exit): Pass arguments to
8119         m_bind_function directly, instead of creating a std::bind and
8120         copying that.
8121
8122 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8123
8124         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8125         for static members.
8126         (pass_in_v_vfp_candidate): Likewise.
8127
8128 2019-01-23  Tom Tromey  <tom@tromey.com>
8129             Pedro Alves  <palves@redhat.com>
8130
8131         * regcache.c (class regcache_invalidator): Remove.
8132         (regcache::raw_write): Use make_scope_exit.
8133
8134 2019-01-23  Tom Tromey  <tom@tromey.com>
8135
8136         * ui-out.h (class ui_out_emit_type): Update comment.
8137
8138 2019-01-23  Tom Tromey  <tom@tromey.com>
8139
8140         * infrun.c (fetch_inferior_event): Update comment.
8141
8142 2019-01-23  Tom Tromey  <tom@tromey.com>
8143             Pedro Alves  <palves@redhat.com>
8144
8145         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8146         parameter.
8147         (fetch_inferior_event): Use SCOPE_EXIT.
8148
8149
8150 2019-01-23  Tom Tromey  <tom@tromey.com>
8151             Pedro Alves  <palves@redhat.com>
8152
8153         * infrun.c (disable_thread_events): Delete.
8154         (stop_all_threads): Use SCOPE_EXIT.
8155
8156 2019-01-23  Tom Tromey  <tom@tromey.com>
8157             Pedro Alves  <palves@redhat.com>
8158
8159         * symfile.c: Include forward-scope-exit.h.
8160         (clear_symtab_users_cleanup): Replace forward declaration with
8161         a FORWARD_SCOPE_EXIT.
8162         (syms_from_objfile_1): Use the forward_scope_exit and
8163         gdb::optional instead of cleanup_function.
8164         (reread_symbols): Use the forward_scope_exit instead of
8165         cleanup_function.
8166         (clear_symtab_users_cleanup): Remove function.
8167
8168 2019-01-23  Tom Tromey  <tom@tromey.com>
8169             Pedro Alves  <palves@redhat.com>
8170
8171         * linux-nat.c: Include scope-exit.h.
8172         (cleanup_target_stop): Remove.
8173         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8174         SCOPE_EXIT.
8175
8176 2019-01-23  Tom Tromey  <tom@tromey.com>
8177             Pedro Alves  <palves@redhat.com>
8178
8179         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8180         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8181
8182 2019-01-23  Tom Tromey  <tom@tromey.com>
8183             Andrew Burgess  <andrew.burgess@embecosm.com>
8184             Pedro Alves  <palves@redhat.com>
8185
8186         * infrun.c (fetch_inferior_event): Use scope_exit.
8187         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8188         * top.c (execute_command): Use scope_exit.
8189         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8190         * utils.c (do_bpstat_clear_actions_cleanup)
8191         (make_bpstat_clear_actions_cleanup): Remove.
8192
8193 2019-01-23  Tom Tromey  <tom@tromey.com>
8194             Pedro Alves  <palves@redhat.com>
8195
8196         * infrun.c: Include "common/scope-exit.h"
8197         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8198         (wait_for_inferior): Use SCOPE_EXIT.
8199         (fetch_inferior_event): Use scope_exit.
8200
8201 2019-01-23  Tom Tromey  <tom@tromey.com>
8202             Pedro Alves  <palves@redhat.com>
8203
8204         * breakpoint.c (create_breakpoint): Remove cleanup.
8205
8206 2019-01-23  Tom Tromey  <tom@tromey.com>
8207             Andrew Burgess  <andrew.burgess@embecosm.com>
8208             Pedro Alves  <palves@redhat.com>
8209
8210 2019-01-23  Pedro Alves  <palves@redhat.com>
8211
8212         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8213
8214 2019-01-23  Pedro Alves  <palves@redhat.com>
8215             Andrew Burgess  <andrew.burgess@embecosm.com>
8216
8217         * gdbthread.h: Include "common/forward-scope-exit.h".
8218         (scoped_finish_thread_state): Redefine custom class in terms of
8219         forward_scope_exit.
8220
8221 2019-01-23  Pedro Alves  <palves@redhat.com>
8222             Andrew Burgess  <andrew.burgess@embecosm.com>
8223
8224         * common/forward-scope-exit.h: New file.
8225
8226 2019-01-23  Pedro Alves  <palves@redhat.com>
8227             Andrew Burgess  <andrew.burgess@embecosm.com>
8228             Tom Tromey  <tom@tromey.com>
8229
8230         * common/scope-exit.h: New file.
8231
8232 2019-01-23  Pedro Alves  <palves@redhat.com>
8233
8234         * common/preprocessor.h (ESC): Rename to ...
8235         (ESC_PARENS): ... this.
8236         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8237         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8238
8239 2019-01-23  Tom Tromey  <tom@tromey.com>
8240
8241         * language.h (class scoped_switch_to_sym_language_if_auto):
8242         Initialize m_lang in both cases.
8243
8244 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8245
8246         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8247         with XCNEW.
8248
8249 2019-01-22  Tom Tromey  <tom@tromey.com>
8250
8251         * corelow.c: Do not include sys/file.h.
8252
8253 2019-01-22  Tom Tromey  <tom@tromey.com>
8254
8255         * tui/tui-wingeneral.h: Include gdb_curses.h.
8256
8257 2019-01-22  Tom Tromey  <tom@tromey.com>
8258
8259         * source-cache.h (class source_cache) <get_source_lines,
8260         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8261
8262 2019-01-22  Tom Tromey  <tom@tromey.com>
8263
8264         * remote-fileio.h (struct remote_target): Declare.
8265
8266 2019-01-22  Tom Tromey  <tom@tromey.com>
8267
8268         * python/py-arch.c: Do not include py-ref.h.
8269         * python/py-bpevent.c: Do not include py-ref.h.
8270         * python/py-cmd.c: Do not include py-ref.h.
8271         * python/py-continueevent.c: Do not include py-ref.h.
8272         * python/py-event.h: Do not include py-ref.h.
8273         * python/py-evtregistry.c: Do not include py-ref.h.
8274         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8275         * python/py-frame.c: Do not include py-ref.h.
8276         * python/py-framefilter.c: Do not include py-ref.h.
8277         * python/py-function.c: Do not include py-ref.h.
8278         * python/py-infevents.c: Do not include py-ref.h.
8279         * python/py-linetable.c: Do not include py-ref.h.
8280         * python/py-objfile.c: Do not include py-ref.h.
8281         * python/py-param.c: Do not include py-ref.h.
8282         * python/py-prettyprint.c: Do not include py-ref.h.
8283         * python/py-progspace.c: Do not include py-ref.h.
8284         * python/py-symbol.c: Do not include py-ref.h.
8285         * python/py-symtab.c: Do not include py-ref.h.
8286         * python/py-type.c: Do not include py-ref.h.
8287         * python/py-unwind.c: Do not include py-ref.h.
8288         * python/py-utils.c: Do not include py-ref.h.
8289         * python/py-value.c: Do not include py-ref.h.
8290         * python/py-varobj.c: Do not include py-ref.h.
8291         * python/py-xmethods.c: Do not include py-ref.h.
8292         * python/python.c: Do not include py-ref.h.
8293         * varobj.c: Do not include py-ref.h.
8294
8295 2019-01-22  Tom Tromey  <tom@tromey.com>
8296
8297         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8298         keyword for bcache.
8299
8300 2019-01-22  Tom Tromey  <tom@tromey.com>
8301
8302         * compile/compile-cplus-types.c: Remove a comment by #include.
8303
8304 2019-01-22  Tom Tromey  <tom@tromey.com>
8305
8306         * compile/gcc-c-plugin.h: Include compile-internal.h.
8307
8308 2019-01-22  Tom Tromey  <tom@tromey.com>
8309
8310         * stabsread.c (EXTERN): Do not define.
8311         (symnum, next_symbol_text_func, processing_gcc_compilation)
8312         (within_function, global_sym_chain, global_stabs)
8313         (previous_stab_code, this_object_header_files)
8314         (n_this_object_header_files)
8315         (n_allocated_this_object_header_files): Define.
8316         * stabsread.h (EXTERN): Never define.  Use "extern".
8317
8318 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8319
8320         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8321         history_value.
8322
8323 2019-01-21  Tom Tromey  <tom@tromey.com>
8324
8325         * ui-out.c: Fix includes.
8326         * tui/tui-source.c: Fix includes.
8327         * target.c: Fix includes.
8328         * remote.c: Fix includes.
8329         * regcache.c: Fix includes.
8330         * python/py-block.c: Fix includes.
8331         * printcmd.c: Fix includes.
8332         * or1k-tdep.c: Fix includes.
8333         * mi/mi-main.c: Fix includes.
8334         * m32r-tdep.c: Fix includes.
8335         * csky-tdep.c: Fix includes.
8336         * compile/compile-cplus-types.c: Fix includes.
8337         * cli/cli-interp.c: Fix includes.
8338
8339 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8340
8341         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8342         for padding.
8343
8344 2019-01-16  Tom Tromey  <tom@tromey.com>
8345
8346         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8347         earlier.
8348         (struct objfile) <msymbols_range>: Move from top level.
8349         <msymbols>: New method.
8350         (class objfile_msymbols): Remove.
8351         * symtab.c (default_collect_symbol_completion_matches_break_on):
8352         Update.
8353         * symmisc.c (dump_msymbols): Update.
8354         * stabsread.c (scan_file_globals): Update.
8355         * objc-lang.c (info_selectors_command, info_classes_command)
8356         (find_methods): Update.
8357         * minsyms.c (find_solib_trampoline_target): Update.
8358         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8359         * coffread.c (coff_symfile_read): Update.
8360         * ada-lang.c (ada_lookup_simple_minsym)
8361         (ada_collect_symbol_completion_matches): Update.
8362
8363 2019-01-16  Tom Tromey  <tom@tromey.com>
8364
8365         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8366         type.  Remove no-argument constructor.
8367         <iterator::operator++>: Simplify.
8368         <begin>: Update.
8369         <end>: Use minimal_symbol_count.
8370
8371 2019-01-16  Tom Tromey  <tom@tromey.com>
8372
8373         * objfiles.h (struct objfile) <psymtabs>: New method.
8374         (class objfile_psymtabs): Remove.
8375         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8376         typedef.
8377         <range>: New method.
8378         (require_partial_symbols): Change return type.
8379         * psymtab.c (require_partial_symbols)
8380         (psym_expand_symtabs_matching): Update.
8381         * mdebugread.c (parse_partial_symbols): Update.
8382         * dbxread.c (dbx_end_psymtab): Update.
8383
8384 2019-01-15  Tom Tromey  <tom@tromey.com>
8385
8386         * symtab.c (lookup_objfile_from_block)
8387         (lookup_symbol_in_objfile_symtabs)
8388         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8389         (find_line_symtab, info_sources_command)
8390         (default_collect_symbol_completion_matches_break_on)
8391         (make_source_files_completion_list): Update.
8392         * symmisc.c (print_objfile_statistics, dump_objfile)
8393         (maintenance_print_symbols, maintenance_info_symtabs)
8394         (maintenance_check_symtabs, maintenance_info_line_tables):
8395         Update.
8396         * source.c (select_source_symtab)
8397         (forget_cached_source_info_for_objfile): Update.
8398         * objfiles.h (class objfile_compunits): Remove.
8399         (struct objfile) <compunits_range>: New typedef.
8400         (compunits): New method.
8401         * objfiles.c (objfile_relocate1): Update.
8402         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8403         * maint.c (count_symtabs_and_blocks): Update.
8404         * linespec.c (iterate_over_all_matching_symtabs): Update.
8405         * cp-support.c (add_symbol_overload_list_qualified): Update.
8406         * coffread.c (coff_symtab_read): Update.
8407         * ada-lang.c (add_nonlocal_symbols)
8408         (ada_collect_symbol_completion_matches)
8409         (ada_add_global_exceptions): Update.
8410
8411 2019-01-15  Tom Tromey  <tom@tromey.com>
8412
8413         * progspace.h (program_space) <objfiles_safe_range>: New
8414         typedef.
8415         <objfiles_safe>: New method.
8416         * objfiles.h (class all_objfiles_safe): Remove.
8417         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8418         * jit.c (jit_inferior_exit_hook): Update.
8419
8420 2019-01-17  Tom Tromey  <tom@tromey.com>
8421
8422         * progspace.h (program_space) <objfiles_range>: New typedef.
8423         <objfiles>: New method.
8424         <objfiles_head>: Rename from objfiles.
8425         (object_files): Update.
8426         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8427         * guile/scm-pretty-print.c
8428         (ppscm_find_pretty_printer_from_objfiles): Update.
8429         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8430         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8431         Update.
8432         * python/py-progspace.c (pspy_get_objfiles): Update.
8433         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8434         Update.
8435         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8436         (objfpy_lookup_objfile_by_build_id): Update.
8437         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8438         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8439         Update.
8440         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8441         (expand_symtab_containing_pc, lookup_objfile_from_block)
8442         (lookup_static_symbol, basic_lookup_transparent_type)
8443         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8444         (find_line_symtab, info_sources_command)
8445         (default_collect_symbol_completion_matches_break_on)
8446         (make_source_files_completion_list, find_main_name): Update.
8447         * symmisc.c (print_symbol_bcache_statistics)
8448         (print_objfile_statistics, maintenance_print_symbols)
8449         (maintenance_print_msymbols, maintenance_print_objfiles)
8450         (maintenance_info_symtabs, maintenance_check_symtabs)
8451         (maintenance_expand_symtabs, maintenance_info_line_tables):
8452         Update.
8453         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8454         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8455         (map_overlay_command, unmap_overlay_command)
8456         (simple_overlay_update, expand_symtabs_matching)
8457         (map_symbol_filenames): Update.
8458         * symfile-debug.c (set_debug_symfile): Update.
8459         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8460         Update.
8461         * source.c (select_source_symtab, forget_cached_source_info):
8462         Update.
8463         * solib.c (solib_read_symbols): Update.
8464         * solib-spu.c (append_ocl_sos): Update.
8465         * psymtab.c (maintenance_print_psymbols)
8466         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8467         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8468         * printcmd.c (info_symbol_command): Update.
8469         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8470         Update.
8471         * objfiles.h (class all_objfiles): Remove.
8472         * objfiles.c (have_partial_symbols, have_full_symbols)
8473         (have_minimal_symbols, qsort_cmp, update_section_map)
8474         (shared_objfile_contains_address_p)
8475         (default_iterate_over_objfiles_in_search_order): Update.
8476         * objc-lang.c (info_selectors_command, info_classes_command)
8477         (find_methods): Update.
8478         * minsyms.c (find_solib_trampoline_target): Update.
8479         * maint.c (maintenance_info_sections)
8480         (maintenance_translate_address, count_symtabs_and_blocks):
8481         Update.
8482         * main.c (captured_main_1): Update.
8483         * linux-thread-db.c (try_thread_db_load_from_pdir)
8484         (has_libpthread): Update.
8485         * linespec.c (iterate_over_all_matching_symtabs)
8486         (search_minsyms_for_name): Update.
8487         * jit.c (jit_find_objf_with_entry_addr): Update.
8488         * hppa-tdep.c (find_unwind_entry)
8489         (hppa_lookup_stub_minimal_symbol): Update.
8490         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8491         Update.
8492         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8493         (elf_gnu_ifunc_resolve_by_got): Update.
8494         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8495         * dwarf-index-write.c (save_gdb_index_command): Update.
8496         * cp-support.c (add_symbol_overload_list_qualified): Update.
8497         * breakpoint.c (create_overlay_event_breakpoint)
8498         (create_longjmp_master_breakpoint)
8499         (create_std_terminate_master_breakpoint)
8500         (create_exception_master_breakpoint): Update.
8501         * blockframe.c (find_pc_partial_function): Update.
8502         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8503         (ada_collect_symbol_completion_matches)
8504         (ada_add_global_exceptions): Update.
8505
8506 2019-01-17  Tom Tromey  <tom@tromey.com>
8507
8508         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8509         declare VEC.
8510         (solib_target_parse_libraries): Change return type.
8511         (library_list_start_segment, library_list_start_section)
8512         (library_list_end_library, library_list_start_library); Update.
8513         (solib_target_free_library_list): Remove.
8514         (solib_target_parse_libraries): Remove cleanup.  Change return
8515         type.
8516         (solib_target_current_sos): Update.
8517
8518 2019-01-17  Tom Tromey  <tromey@bapiya>
8519
8520         * valprint.c: Replace "the the" with "the".
8521         * symtab.c: Replace "the the" with "the".
8522         * solib.c: Replace "the the" with "the".
8523         * solib-dsbt.c: Replace "the the" with "the".
8524         * linespec.c: Replace "the the" with "the".
8525         * dwarf2loc.h: Replace "the the" with "the".
8526         * amd64-windows-tdep.c: Replace "the the" with "the".
8527         * aarch64-tdep.c: Replace "the the" with "the".
8528
8529 2019-01-16  Keith Seitz  <keiths@redhat.com>
8530
8531         PR gdb/23773
8532         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8533         <builder>: Rename to ..
8534         <m_builder>: ... this and make private.
8535         (dwarf2_cu::get_builder): New method.  Change all users of
8536         `builder' to use this method.
8537         (dwarf2_start_symtab): Move to ...
8538         (dwarf2_cu::start_symtab): ... here.  Update all callers
8539         (setup_type_unit_groups): Move to ...
8540         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8541         callers.
8542         (dwarf2_cu::reset_builder): New method.
8543         (process_full_compunit, process_full_type_unit): Use
8544         dwarf2_cu::reset_builder.
8545         (follow_die_offset): Record the ancestor CU if it is different
8546         from the followed DIE's CU.
8547         (follow_die_sig_1): Likewise.
8548
8549 2019-01-15  Tom Tromey  <tom@tromey.com>
8550
8551         * remote.c (class remote_state) <buf>: Now a char_vector.
8552         <buf_size>: Remove.
8553         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8554         parameter.
8555         (remote_target::getpkt_or_notif_sane_1)
8556         (remote_target::getpkt_sane)
8557         (remote_target::getpkt_or_notif_sane): Likewise.
8558         (class remote_target) <putpkt>: New overload.
8559         (remote_target::read_frame): Change type of "buf_p".  Remove
8560         sizeof_p parameter.
8561         (packet_ok): New overload.
8562         (packet_check_result): New overload.
8563         Update all uses.
8564
8565 2019-01-14  Tom Tromey  <tom@tromey.com>
8566
8567         * remote-notif.c (handle_notification, remote_notif_ack)
8568         (remote_notif_parse): Make "buf" const.
8569         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8570         const.
8571         (remote_notif_parse, remote_notif_ack, handle_notification):
8572         Likewise.
8573         * remote.c (remote_notif_stop_parse): Make "buf" const.
8574         (remote_target::remote_parse_stop_reply): Make "buf" const.
8575         (remote_notif_stop_ack): Make "buf" const.
8576
8577 2019-01-14  Tom Tromey  <tom@tromey.com>
8578
8579         * remote.c (remote_console_output): Make parameter const.
8580
8581 2019-01-14  Tom Tromey  <tom@tromey.com>
8582
8583         * target-debug.h (target_debug_print_signals): Constify.
8584         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8585         * procfs.c (procfs_target::pass_signals): Update.
8586         * linux-nat.c (linux_nat_target::pass_signals): Update.
8587         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8588         * target-delegates.c: Rebuild.
8589         * remote.c (remote_target::program_signals): Update.
8590         (remote_target::pass_signals): Update.
8591         * target.c (target_pass_signals): Constify argument.
8592         (target_program_signals): Likewise.
8593         * target.h (struct target_ops) <pass_signals, program_signals>:
8594         Constify argument.
8595         (target_pass_signals, target_program_signals): Constify argument.
8596
8597 2019-01-14  Tom Tromey  <tom@tromey.com>
8598
8599         PR tui/28819:
8600         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8601
8602 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8603
8604         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8605         field.
8606         * rs6000-tdep.c: Include reggroups.h.
8607         (IS_V_ALIAS_PSEUDOREG): Define.
8608         (rs6000_register_name): Return names for the "vX" aliases.
8609         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8610         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8611         aliases.  Call default_register_reggroup_p for all other
8612         pseudo-registers.
8613         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8614         New functions.
8615         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8616         Handle "vX" aliases.
8617         (v_alias_pseudo_register_collect): New function.
8618         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8619         (rs6000_gdbarch_init): Initialize "vX" aliases as
8620         pseudo-registers.  Restore registration of
8621         rs6000_pseudo_register_reggroup_p with
8622         set_tdesc_pseudo_register_reggroup_p.
8623
8624 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8625
8626         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8627         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8628         set_gdbarch_num_pseudo_regs.
8629
8630 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8631
8632         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8633         Remove arg prefixname, add do_set and do_show.
8634         Add member functions set_list and show_list.
8635         * cli/cli-style.c (class cli_style_option): Update accordingly.
8636         (style_set_list): Move to file scope.
8637         (style_show_list): Likewise.
8638         (set_style): Call help_list.
8639         (show_style): Call cmd_show_list.
8640         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8641         Update to use the new macro.
8642
8643 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8644
8645         * ada-lang.c (_initialize_ada_language): Expand the help text
8646         for the "catch exception" command.
8647
8648 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8649
8650         * symtab.c (matching_obj_sections): Initialize obj,
8651         declare it closer to its usage.
8652
8653 2019-01-10  Tom Tromey  <tom@tromey.com>
8654
8655         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8656         (basic_inf_threads_range): Remove.
8657         (inf_threads_range, inf_non_exited_threads_range)
8658         (safe_inf_threads_range): Use next_adapter.
8659
8660 2019-01-10  Keith Seitz  <keiths@redhat.com>
8661
8662         PR gdb/23712
8663         PR symtab/23010
8664         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8665         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8666
8667 2019-01-10  Keith Seitz  <keiths@redhat.com>
8668
8669         PR gdb/23712
8670         PR symtab/23010
8671         * dictionary.c (pending_to_vector): Remove.
8672         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8673         Remove _1 suffix, replacing functions of the same name.  Update
8674         all callers.
8675         (dict_create_hashed, dict_create_hashed_expandable)
8676         (dict_create_linear, dict_create_linear_expandable, dict_free)
8677         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8678         Make functions static.
8679
8680 2019-01-10  Keith Seitz  <keiths@redhat.com>
8681
8682         PR gdb/23712
8683         PR symtab/23010
8684         * dictionary.h (struct dictionary): Replace declaration with
8685         multidictionary.
8686         (dict_create_hashed, dict_create_hashed_expandable)
8687         (dict_create_linear, dict_create_linear_expandable)
8688         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8689         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8690         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8691         taking multidictionary argument.
8692         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8693         * block.h (struct block) <dict>: Change to multidictionary
8694         and rename `multidict'.
8695         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8696         symmisc.c: Update all dictionary references to multidictionary.
8697
8698 2019-01-10  Keith Seitz  <keiths@redhat.com>
8699
8700         PR gdb/23712
8701         PR symtab/23010
8702         * dictionary.c: Include unordered_map.
8703         (pending_to_vector): New function.
8704         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8705         Rewrite the non-"_1" functions to take vector instead
8706         of linked list.
8707         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8708         "new" _1 versions of the same name.
8709         (multidictionary): Define.
8710         (std::hash<enum language): New definition.
8711         (collate_pending_symbols_by_language, mdict_create_hashed)
8712         (mdict_create_hashed_expandable, mdict_create_linear)
8713         (mdict_create_linear_expandable, mdict_free)
8714         (find_language_dictionary, create_new_language_dictionary)
8715         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8716         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8717         (mdict_size, mdict_empty): New functions.
8718         * dictionary.h (mdict_iterator): Define.
8719
8720 2019-01-10  Pedro Alves  <palves@redhat.com>
8721
8722         * breakpoint.c (read_uploaded_action)
8723         (create_tracepoint_from_upload): Adjust to use
8724         gdb::unique_xmalloc_ptr.
8725         * ctf.c (ctf_write_uploaded_tp):
8726         (SET_ARRAY_FIELD): Use emplace_back.
8727         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8728         * tracefile-tfile.c (tfile_write_uploaded_tp):
8729         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8730         gdb::unique_xmalloc_ptr.
8731         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8732         at_string, cond_string, cmd_strings>: Replace char pointers
8733         with gdb::unique_xmalloc_ptr.
8734
8735 2019-01-10  Pedro Alves  <palves@redhat.com>
8736
8737         * solib-target.c (library_list_start_library): Don't xstrdup name.
8738
8739 2019-01-10  Pedro Alves  <palves@redhat.com>
8740
8741         * mdebugread.c (parse_partial_symbols): Use
8742         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8743
8744 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8745
8746         * linux-fork.c (scoped_switch_fork_info)
8747         <~scoped_switch_fork_info>: Fix incorrect variable name.
8748
8749 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8750
8751         * linux-fork.c (scoped_switch_fork_info)
8752         <scoped_switch_fork_info>: Make explicit.
8753         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8754
8755 2019-01-10  Tom Tromey  <tom@tromey.com>
8756
8757         * objfiles.h (objfile::reset_psymtabs): Update.
8758         * objfiles.c (objfile::objfile): Update.
8759         * psymtab.h (psymtab_storage::obstack): Update.
8760         (psymtab_storage::m_obstack): Use gdb::optional.
8761         (class psymtab_storage): Update comment.  Remove objfile
8762         parameter.
8763         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8764
8765 2019-01-10  Tom Tromey  <tom@tromey.com>
8766
8767         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8768         <free_psymtabs>: Now private.
8769         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8770         (allocate_psymtab): Use new method.
8771
8772 2019-01-10  Tom Tromey  <tom@tromey.com>
8773
8774         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8775         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8776         * mdebugread.c (parse_partial_symbols): Use
8777         allocate_dependencies.
8778         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8779         allocate_dependencies.
8780         (process_psymtab_comp_unit_reader)
8781         (build_type_psymtab_dependencies): Likewise.
8782         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8783
8784 2019-01-10  Tom Tromey  <tom@tromey.com>
8785
8786         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8787         PSYMBOL_SET_LANGUAGE.
8788         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8789
8790 2019-01-10  Tom Tromey  <tom@tromey.com>
8791
8792         * psymtab.h (psymtab_storage::obstack): New method.
8793         <m_obstack>: Rename from obstack; now private.
8794         * psymtab.c (psymtab_storage): Update.
8795         * dwarf2read.c (create_addrmap_from_index)
8796         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8797         Update.
8798
8799 2019-01-10  Tom Tromey  <tom@tromey.com>
8800
8801         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8802         * objfiles.h (objfile::reset_psymtabs): New method.
8803
8804 2019-01-10  Tom Tromey  <tom@tromey.com>
8805
8806         * symmisc.c (print_symbol_bcache_statistics): Update.
8807         (print_objfile_statistics): Update.
8808         * symfile.c (reread_symbols): Update.
8809         * psymtab.h (class psymtab_storage): New.
8810         * psymtab.c (psymtab_storage): New constructor.
8811         (~psymtab_storage): New destructor.
8812         (require_partial_symbols): Update.
8813         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8814         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8815         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8816         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8817         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8818         (start_psymtab_common, end_psymtab_common)
8819         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8820         (allocate_psymtab): Update.
8821         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8822         Update.
8823         (dump_psymtab_addrmap, maintenance_print_psymbols)
8824         (maintenance_check_psymtabs): Update.
8825         (class objfile_psymtabs): Move to objfiles.h.
8826         * psympriv.h (discard_psymtab): Now inline.
8827         (psymtab_discarder::psymtab_discarder): Update.
8828         (psymtab_discarder::~psymtab_discarder): Update.
8829         (ALL_OBJFILE_PSYMTABS): Rewrite.
8830         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8831         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8832         Remove fields.
8833         <partial_symtabs>: New field.
8834         (class objfile_psymtabs): Move from psymtab.h.  Update.
8835         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8836         psymbol_cache.
8837         (objfile::~objfile): Don't destroy psymbol_cache.
8838         * mdebugread.c (parse_partial_symbols): Update.
8839         * dwarf2read.c (create_addrmap_from_index)
8840         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8841         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8842         (add_partial_subprogram, dwarf2_ranges_read): Update.
8843         * dwarf-index-write.c (write_address_map)
8844         (write_one_signatured_type, recursively_write_psymbols)
8845         (class debug_names, class debug_names, write_psymtabs_to_index):
8846         Update.
8847
8848 2019-01-10  Tom Tromey  <tom@tromey.com>
8849
8850         * symtab.h (SYMBOL_SET_NAMES): Update.
8851         (symbol_set_names): Update.
8852         (MSYMBOL_SET_NAMES): Update.
8853         * symtab.c (symbol_set_names): Change argument to be an
8854         objfile_per_bfd_storage.
8855         * psymtab.c (add_psymbol_to_bcache): Update.
8856         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8857
8858 2019-01-10  Tom Tromey  <tom@tromey.com>
8859
8860         * symtab.c (create_demangled_names_hash): Change argument to be an
8861         objfile_per_bfd_storage.
8862         (symbol_set_names): Update.
8863
8864 2019-01-10  Tom Tromey  <tom@tromey.com>
8865
8866         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8867         init_psymbol_list.
8868         * psymtab.c (init_psymbol_list): Do nothing if already called.
8869         * psympriv.h (init_psymbol_list): Add comment.
8870         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8871         init_psymbol_list.
8872         * dbxread.c (dbx_symfile_read): Unconditionally call
8873         init_psymbol_list.
8874
8875 2019-01-10  Tom Tromey  <tom@tromey.com>
8876
8877         * xcoffread.c (scan_xcoff_symtab): Update.
8878         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8879         "where".
8880         * mdebugread.c (parse_partial_symbols)
8881         (handle_psymbol_enumerators): Update.
8882         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8883         * dbxread.c (read_dbx_symtab): Update.
8884         * psympriv.h (psymbol_placement): New enum.
8885         (add_psymbol_to_list): Update.
8886
8887 2019-01-10  Tom Tromey  <tom@tromey.com>
8888
8889         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8890         static_psymbols parameters.
8891         (scan_xcoff_symtab): Update.
8892         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8893         static_psymbols parameters.
8894         * psympriv.h (start_psymtab_common): Update.
8895         * mdebugread.c (parse_partial_symbols): Update.
8896         * dwarf2read.c (create_partial_symtab): Update.
8897         * dbxread.c (read_dbx_symtab): Update.
8898         (start_psymtab): Remove global_psymbols and static_psymbols
8899         parameters.
8900
8901 2019-01-10  Tom Tromey  <tom@tromey.com>
8902
8903         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8904         * psymtab.c (allocate_psymtab): Add comment.
8905         * psympriv.h (allocate_psymtab): Add comment.
8906         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8907         initializations.
8908         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8909
8910 2019-01-10  Tom Tromey  <tom@tromey.com>
8911
8912         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8913         Don't declare.
8914         * mipsread.c: Include mdebugread.h.
8915         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8916         Declare.
8917         * elfread.c: Include mdebugread.h.
8918
8919 2019-01-09  Tom Tromey  <tom@tromey.com>
8920
8921         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8922         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8923         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8924         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8925         (psym_lookup_symbol, psym_find_last_source_symtab)
8926         (psym_forget_cached_source_info, psym_print_stats)
8927         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8928         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8929         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8930         (psym_find_compunit_symtab_by_address)
8931         (maintenance_print_psymbols, maintenance_info_psymtabs)
8932         (maintenance_check_psymtabs): Use ranged for.
8933         * psymtab.h (class objfile_psymtabs): New.
8934         (require_partial_symbols): Return objfile_psymtabs.
8935         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8936
8937 2019-01-09  Tom Tromey  <tom@tromey.com>
8938
8939         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8940         (find_pc_mapped_section, list_overlays_command)
8941         (map_overlay_command, unmap_overlay_command)
8942         (simple_overlay_update): Use all_objfiles.
8943         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8944         * printcmd.c (info_symbol_command): Use all_objfiles.
8945         * objfiles.h (ALL_OBJSECTIONS): Remove.
8946         * maint.c (maintenance_translate_address): Use all_objfiles.
8947         * gcore.c (gcore_create_callback): Use all_objfiles.
8948         (objfile_find_memory_regions): Likewise.
8949
8950 2019-01-09  Tom Tromey  <tom@tromey.com>
8951
8952         * symtab.c (find_line_symtab, info_sources_command)
8953         (make_source_files_completion_list): Use objfile_compunits.
8954         * source.c (select_source_symtab): Use objfile_compunits.
8955         * objfiles.h (struct objfile): Update comment.
8956         (ALL_OBJFILES): Remove.
8957         (ALL_FILETABS): Remove.
8958         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8959         objfile_compunits.
8960
8961 2019-01-09  Tom Tromey  <tom@tromey.com>
8962
8963         * symmisc.c (print_objfile_statistics, dump_objfile)
8964         (maintenance_print_symbols): Use compunit_filetabs.
8965         * source.c (forget_cached_source_info_for_objfile): Use
8966         compunit_filetabs.
8967         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8968         (ALL_FILETABS): Use compunit_filetabs.
8969         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8970         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8971
8972 2019-01-09  Tom Tromey  <tom@tromey.com>
8973
8974         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8975         (compunit_filetabs): New.
8976         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8977         compunit_filetabs.
8978         (info_sources_command, make_source_files_completion_list): Remove
8979         declaration.
8980         * symmisc.c (print_objfile_statistics, dump_objfile)
8981         (maintenance_print_symbols): Remove declaration.
8982         (maintenance_info_symtabs): Use compunit_filetabs.
8983         (maintenance_info_line_tables): Likewise.
8984         * source.c (select_source_symtab): Change local variable name.
8985         (forget_cached_source_info_for_objfile): Remove declaration.
8986         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8987         * objfiles.c (objfile_relocate1): Remove declaration.
8988         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8989         declaration.
8990         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8991         * coffread.c (coff_symtab_read): Remove declaration.
8992         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8993         compunit_filetabs.
8994
8995 2019-01-09  Tom Tromey  <tom@tromey.com>
8996
8997         * symtab.c (lookup_objfile_from_block)
8998         (find_pc_sect_compunit_symtab, search_symbols)
8999         (default_collect_symbol_completion_matches_break_on): Use
9000         objfile_compunits.
9001         * objfiles.h (ALL_COMPUNITS): Remove.
9002         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9003         * cp-support.c (add_symbol_overload_list_qualified): Use
9004         objfile_compunits.
9005         * ada-lang.c (ada_collect_symbol_completion_matches)
9006         (ada_add_global_exceptions): Use objfile_compunits.
9007
9008 2019-01-09  Tom Tromey  <tom@tromey.com>
9009
9010         * source.c (select_source_symtab)
9011         (forget_cached_source_info_for_objfile): Remove declaration.
9012         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9013         declaration.
9014         * maint.c (count_symtabs_and_blocks): Remove declaration.
9015         * cp-support.c (add_symbol_overload_list_qualified): Remove
9016         declaration.
9017         * coffread.c (coff_symtab_read): Remove declaration.
9018         * symtab.c (lookup_symbol_in_objfile_symtabs)
9019         (basic_lookup_transparent_type_1): Use objfile_compunits.
9020         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9021         (info_sources_command, search_symbols)
9022         (default_collect_symbol_completion_matches_break_on)
9023         (make_source_files_completion_list): Remove declaration.
9024         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9025         (ada_collect_symbol_completion_matches)
9026         (ada_add_global_exceptions): Remove declaration.
9027         * linespec.c (iterate_over_all_matching_symtabs): Use
9028         objfile_compunits.
9029         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9030         (class objfile_compunits): New.
9031         (ALL_COMPUNITS): Use objfile_compunits.
9032         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9033         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9034         objfile_compunits.
9035         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9036
9037 2019-01-09  Tom Tromey  <tom@tromey.com>
9038
9039         * symtab.c (search_symbols)
9040         (default_collect_symbol_completion_matches_break_on): Use
9041         objfile_msymbols.
9042         * ada-lang.c (ada_lookup_simple_minsym)
9043         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9044         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9045         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9046         objfile_msymbols.
9047         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9048         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9049         * objc-lang.c (find_methods): Use objfile_msymbols.
9050         (info_selectors_command, info_classes_command): Likewise.
9051         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9052         * objfiles.h (class objfile_msymbols): New.
9053         (ALL_OBJFILE_MSYMBOLS): Remove.
9054         (ALL_MSYMBOLS): Remove.
9055
9056 2019-01-09  Tom Tromey  <tom@tromey.com>
9057
9058         * common/next-iterator.h (next_adapter): Add Iterator template
9059         parameter.
9060         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9061         (class all_objfiles_safe): New.
9062         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9063         * objfiles.c (put_objfile_before): Update comment.
9064         (add_separate_debug_objfile): Likewise.
9065         (free_all_objfiles): Use all_objfiles_safe.
9066         (objfile_purge_solibs): Likewise.
9067
9068 2019-01-09  Tom Tromey  <tom@tromey.com>
9069
9070         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9071         (expand_symtab_containing_pc, lookup_static_symbol)
9072         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9073         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9074         all_objfiles.
9075         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9076         * breakpoint.c (create_overlay_event_breakpoint)
9077         (create_longjmp_master_breakpoint)
9078         (create_std_terminate_master_breakpoint)
9079         (create_exception_master_breakpoint): Use all_objfiles.
9080         * linux-thread-db.c (try_thread_db_load_from_pdir)
9081         (has_libpthread): Use all_objfiles.
9082         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9083         * linespec.c (iterate_over_all_matching_symtabs)
9084         (search_minsyms_for_name): Use all_objfiles.
9085         * maint.c (maintenance_info_sections): Use all_objfiles.
9086         * main.c (captured_main_1): Use all_objfiles.
9087         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9088         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9089         * guile/scm-pretty-print.c
9090         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9091         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9092         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9093         (maintenance_print_msymbols): Use all_objfiles.
9094         * source.c (select_source_symtab): Use all_objfiles.
9095         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9096         * symfile.c (remove_symbol_file_command)
9097         (expand_symtabs_matching, map_symbol_filenames): Use
9098         all_objfiles.
9099         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9100         all_objfiles.
9101         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9102         * objc-lang.c (find_methods): Use all_objfiles.
9103         * objfiles.c (have_partial_symbols, have_full_symbols)
9104         (have_minimal_symbols, qsort_cmp)
9105         (default_iterate_over_objfiles_in_search_order): Use
9106         all_objfiles.
9107         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9108         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9109         (maintenance_check_psymtabs): Use all_objfiles.
9110         (ALL_PSYMTABS): Remove.
9111         * compile/compile-object-run.c (do_module_cleanup): Use
9112         all_objfiles.
9113         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9114         * cp-support.c (add_symbol_overload_list_qualified): Use
9115         all_objfiles.
9116         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9117         Use all_objfiles.
9118         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9119         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9120         all_objfiles.
9121         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9122         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9123         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9124         Uses all_objfiles.
9125         * solib.c (solib_read_symbols): Use all_objfiles
9126
9127 2019-01-09  Tom Tromey  <tom@tromey.com>
9128
9129         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9130         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9131         all_objfiles.
9132         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9133         * symmisc.c (print_symbol_bcache_statistics)
9134         (print_objfile_statistics, maintenance_print_objfiles)
9135         (maintenance_info_symtabs, maintenance_check_symtabs)
9136         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9137         all_objfiles.
9138         * source.c (forget_cached_source_info): Use all_objfiles.
9139         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9140         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9141         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9142         * objfiles.c (update_section_map): Use all_objfiles.
9143         (shared_objfile_contains_address_p): Likewise.
9144         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9145         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9146
9147 2019-01-09  Tom Tromey  <tom@tromey.com>
9148
9149         * common/next-iterator.h: New file.
9150         * objfiles.h (class all_objfiles): New.
9151         (struct objfile_iterator): New.
9152
9153 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9154
9155         * NEWS: Move the description of the changed "frame", "select-frame",
9156          and "info frame" commands to the Changed commands section.
9157
9158 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9159
9160         * gdbtypes.c (check_stub_method_group): Remove handling of old
9161         mangling schemes.
9162         * linespec.c (find_methods): Likewise.
9163         * stabsread.c (read_member_functions): Likewise.
9164         * valops.c (search_struct_method): Likewise.
9165         (value_struct_elt_for_reference): Likewise.
9166         * NEWS: Mention this change.
9167
9168 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9169
9170         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9171         print_source_lines.
9172         * source.c (print_source_lines_base): Update line number check.
9173         (print_source_lines): New function.
9174         (source_lines_range::source_lines_range): New function.
9175         * source.h (class source_lines_range): New class.
9176         (print_source_lines): New declaration.
9177
9178 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9179
9180         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9181
9182 2019-01-08  Tom Tromey  <tom@tromey.com>
9183             Simon Marchi  <simon.marchi@ericsson.com>
9184
9185         PR gdb/24060
9186         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9187         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9188         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9189         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9190         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9191         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9192
9193 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9194
9195         * source.c (select_source_symtab): Move header comment to
9196         declaration in source.h.
9197         (forget_cached_source_info_for_objfile): Likewise.
9198         (forget_cached_source_info): Likewise.
9199         (identify_source_line): Likewise.
9200         * source.h (identify_source_line): Move declaration from symtab.h
9201         and add comment from source.c
9202         (print_source_lines): Likewise.
9203         (forget_cached_source_info_for_objfile): Likewise.
9204         (forget_cached_source_info): Likewise.
9205         (select_source_symtab): Likewise.
9206         (enum print_source_lines_flag): Move definition from symtab.h.
9207         * symtab.h (identify_source_line): Move declaration to source.h.
9208         (print_source_lines): Likewise.
9209         (forget_cached_source_info_for_objfile): Likewise.
9210         (forget_cached_source_info): Likewise.
9211         (select_source_symtab): Likewise.
9212         (enum print_source_lines_flag): Move definition to source.h.
9213         * tui/tui-hooks.c: Add 'source.h' include.
9214
9215 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9216
9217         * source.c (print_source_lines_base): Handle requests to print
9218         reverse line number sequences, and guard against empty lines
9219         string.
9220
9221 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9222
9223         * source.c (print_source_lines_base): Fix skip of '\r' if next
9224         character is '\n'.
9225
9226 2019-01-06  Tom Tromey  <tom@tromey.com>
9227
9228         * c-exp.y (struct c_parse_state) <macro_original_text,
9229         expansion_obstack>: New member.
9230         (macro_original_text, expansion_obstack): Remove globals.
9231         (scan_macro_expansion, scanning_macro_expansion)
9232         (finished_macro_expansion): Update.
9233         (scan_macro_cleanup): Remove.
9234         (yylex, c_parse): Update.
9235
9236 2019-01-06  Tom Tromey  <tom@tromey.com>
9237
9238         * c-exp.y (struct c_parse_state) <strings>: New member.
9239         (operator_stoken): Update.
9240
9241 2019-01-06  Tom Tromey  <tom@tromey.com>
9242
9243         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9244         (union type_stack_elt) <typelist_val>: Now a pointer to
9245         std::vector.
9246         (type_stack_cleanup): Don't declare.
9247         (push_typelist): Update.
9248         * parse.c (pop_typelist): Return a std::vector.
9249         (push_typelist): Take a std::vector.
9250         (follow_types): Update.  Do not free args.
9251         (type_stack_cleanup): Remove.
9252         * c-exp.y (struct c_parse_state): New.
9253         (cpstate): New global.
9254         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9255         (nonempty_typelist): Update.
9256         (func_mod): Create a new vector.
9257         (c_parse): Create a c_parse_state.
9258         (check_parameter_typelist): Do not delete params.
9259         (function_method): Update.  Do not delete type_list.
9260
9261 2019-01-06  Tom Tromey  <tom@tromey.com>
9262
9263         PR gdb/28155:
9264         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9265         check_typedef.
9266         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9267         (print_return_value): Likewise.
9268
9269 2019-01-05  Tom Tromey  <tom@tromey.com>
9270
9271         * contrib/cleanup_check.py: Remove.
9272         * contrib/gcc-with-excheck: Remove.
9273         * contrib/exsummary.py: Remove.
9274         * contrib/excheck.py: Remove.
9275
9276 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9277
9278         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9279         NULL. Initialize tpprev to NULL instead of assigning it
9280         to NULL on the next statement.
9281         * windows-nat.c (windows_delete_thread): Remove check for
9282         main_thread_id before printing thread exit notifications.
9283         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9284         Remove thread ID check against main_thread_id.
9285         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9286         windows_delete_thread.
9287         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9288
9289 2019-01-04  Tom Tromey  <tom@tromey.com>
9290
9291         * compile/compile.c (_initialize_compile): Use upper case for
9292         metasyntactic variables.
9293         * symmisc.c (_initialize_symmisc): Use upper case for
9294         metasyntactic variables.
9295         * psymtab.c (_initialize_psymtab): Use upper case for
9296         metasyntactic variables.
9297         * demangle.c (demangle_command): Use upper case for metasyntactic
9298         variables.
9299         (_initialize_demangler): Likewise.
9300         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9301         variables.
9302
9303 2019-01-03  Tom Tromey  <tom@tromey.com>
9304
9305         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9306
9307 2019-01-03  Tom Tromey  <tom@tromey.com>
9308
9309         * python/py-symtab.c (salpy_str): Update.
9310         (struct salpy_sal_object) <symtab>: Now a PyObject.
9311         (salpy_dealloc): Update.
9312         (del_objfile_sal): Use gdbpy_ref.
9313
9314 2019-01-03  Tom Tromey  <tom@tromey.com>
9315
9316         * python/py-type.c (convert_field): Use new_reference.  Return
9317         gdbpy_ref.
9318         (make_fielditem): Return gdbpy_ref.
9319         (typy_fields): Update.
9320         (typy_getitem): Update.
9321         (field_name): Return gdbpy_ref.  Use new_reference.
9322         (typy_iterator_iternext): Update.
9323
9324 2019-01-03  Tom Tromey  <tom@tromey.com>
9325
9326         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9327
9328 2019-01-03  Tom Tromey  <tom@tromey.com>
9329
9330         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9331         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9332         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9333         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9334         (pspy_set_type_printers): Likewise.
9335         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9336         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9337         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9338         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9339         (objfpy_set_type_printers): Likewise.
9340
9341 2019-01-03  Tom Tromey  <tom@tromey.com>
9342
9343         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9344         (gdbpy_print_stack): Use gdbpy_err_fetch.
9345         * python/python-internal.h (class gdbpy_err_fetch): New class.
9346         (class gdbpy_enter) <m_error_type, m_error_value,
9347         m_error_traceback>: Remove.
9348         <m_error>: New member.
9349         (gdbpy_exception_to_string): Don't declare.
9350         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9351         * python/py-value.c (convert_value_from_python): Use
9352         gdbpy_err_fetch.
9353         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9354         gdbpy_exception_to_string.
9355         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9356         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9357         gdbpy_err_fetch.
9358
9359 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9360
9361         * linux-nat.c (delete_lwp_cleanup): Delete.
9362         (struct lwp_deleter): New struct.
9363         (lwp_info_up): New typedef.
9364         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9365         lwp_info_up.
9366
9367 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9368
9369         * linux-fork.c (class scoped_switch_fork_info): New class.
9370         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9371
9372 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9373
9374         * valops.c (find_overload_match): Remove use of null_cleanup, and
9375         calls to do_cleanups.
9376
9377 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9378
9379         * compile/compile-cplus-types.c
9380         (compile_cplus_instance::decl_name): Handle changes to
9381         cp_func_name.
9382         * cp-support.c (cp_func_name): Update header comment, update
9383         return type.
9384         * cp-support.h (cp_func_name): Update return type in declaration.
9385         * valops.c (find_overload_match): Move temp_func local to top
9386         level of function and change its type.  Use temp_func to hold and
9387         delete temporary string obtained from cp_func_name.
9388
9389 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9390
9391         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9392         gdb::char_vector, remove cleanup, and update uses of `msg`.
9393
9394 2019-01-03  Jim Wilson  <jimw@sifive.com>
9395
9396         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9397
9398 2019-01-02  Tom Tromey  <tom@tromey.com>
9399
9400         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9401         (tdesc_parse_xml): Remove cleanups.
9402         * target-descriptions.h (make_cleanup_free_target_description):
9403         Don't declare.
9404         (target_desc_deleter): New struct.
9405         (target_desc_up): New typedef.
9406         * target-descriptions.c (target_desc_deleter::operator()): Rename
9407         from free_target_description.
9408         (make_cleanup_free_target_description): Remove.
9409
9410 2019-01-02  Tom Tromey  <tom@tromey.com>
9411
9412         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9413         constructor, destructor.
9414         (linespec_parser): Remove typedef.
9415         (~linespec_parser): Rename from linespec_parser_delete.
9416         (linespec_lex_to_end, linespec_complete_label)
9417         (linespec_complete): Update.
9418         (decode_line_full): Remove cleanups.
9419         (decode_line_1): Update.
9420
9421 2019-01-02  Tom Tromey  <tom@tromey.com>
9422
9423         * python/python-internal.h (inferior_to_inferior_object): Change
9424         return type.
9425         * python/py-exitedevent.c (create_exited_event_object): Update.
9426         * python/py-inferior.c (inferior_to_inferior_object): Return
9427         gdbpy_ref.
9428         (python_new_inferior, python_inferior_deleted)
9429         (thread_to_thread_object, delete_thread_object)
9430         (build_inferior_list, gdbpy_selected_inferior): Update.
9431         * python/py-infthread.c (create_thread_object): Update.  Also fail
9432         if inferior_to_inferior_object fails.
9433
9434 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9435
9436         * inferior.h (class inferior) <displaced_step_state>: New field.
9437         * infrun.h (struct displaced_step_state): Move here from
9438         infrun.c.  Initialize fields, add constructor.
9439         <inf>: Remove field.
9440         <reset>: New method.
9441         * infrun.c (struct displaced_step_inferior_state): Move to
9442         infrun.h.
9443         (displaced_step_inferior_states): Remove.
9444         (get_displaced_stepping_state): Adust.
9445         (displaced_step_in_progress_any_inferior): Adjust.
9446         (displaced_step_in_progress_thread): Adjust.
9447         (displaced_step_in_progress): Adjust.
9448         (add_displaced_stepping_state): Remove.
9449         (get_displaced_step_closure_by_addr): Adjust.
9450         (remove_displaced_stepping_state): Remove.
9451         (infrun_inferior_exit): Call displaced_step_state.reset.
9452         (use_displaced_stepping): Don't check for NULL.
9453         (displaced_step_prepare_throw): Call
9454         get_displaced_stepping_state.
9455         (displaced_step_fixup): Don't check for NULL.
9456         (prepare_for_detach): Don't check for NULL.
9457
9458 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9459
9460         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9461          in case of call that did not complete.
9462
9463 2019-01-02  Andrey Utkin  <autkin@undo.io>
9464
9465         * symfile.c (find_separate_debug_file): Fix search of debug files for
9466         remote debuggee.
9467
9468 2019-01-02  Tom Tromey  <tom@tromey.com>
9469
9470         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9471         indentation.
9472         * python/py-frame.c (frapy_older): Remove cast.
9473         (frapy_newer): Likewise.
9474         * python/py-breakpoint.c (local_setattro): Remove cast.
9475         * python/py-arch.c (archpy_name): Remove local variable.
9476         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9477
9478 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9479
9480         * unittests/basic_string_view/element_access/char/empty.cc:
9481         Fix year range in copyright header.
9482
9483 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9484
9485         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9486         Delete.
9487         <operator==>: Update with for removed field.
9488         <hash>: Likewise.
9489         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9490         <isa_features>: ...this.
9491         <abi_features>: New field.
9492         (riscv_isa_flen): Update comment.
9493         (riscv_abi_xlen): New declaration.
9494         (riscv_abi_flen): New declaration.
9495         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9496         isa_features.
9497         (riscv_abi_xlen): New function.
9498         (riscv_isa_flen): Update to get answer from isa_features.
9499         (riscv_abi_flen): New function.
9500         (riscv_has_fp_abi): Update to get answer from abi_features.
9501         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9502         xlen and flen.
9503         (riscv_call_info) <xlen, flen>: Update comment.
9504         (riscv_call_arg_struct): Remove invalid assertions
9505         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9506         is removed.
9507         (riscv_gdbarch_init): Gather isa features and abi features
9508         separately, ensure both match on the gdbarch when reusing an old
9509         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9510         a target with 64-bit float hardware.
9511
9512 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9513
9514         * source.c (search_command_helper): Stop reverse search
9515         when line 1 has been searched.
9516
9517 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9518
9519         * record-full.c (record_full_base_target::close): Rewrite
9520         record_full_core_buf_list free logic.
9521
9522 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9523
9524         * break-catch-syscall.c (print_one_catch_syscall): xfree
9525         the last text.
9526
9527 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9528
9529         * top.c (print_gdb_version): Update Copyright year in version
9530         message.
9531
9532 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9533
9534         Update copyright year range in all GDB files.
9535
9536 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9537
9538         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9539
9540 For older changes see ChangeLog-2018.
9541 \f
9542 Local Variables:
9543 mode: change-log
9544 left-margin: 8
9545 fill-column: 74
9546 version-control: never
9547 coding: utf-8
9548 End:
9549