gdb/ChangeLog

   1 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
   2
   3         * regcache.h (regcache_get_ptid): Remove, update all callers to
   4         call regcache::ptid instead.
   5         * regcache.c (regcache_get_ptid): Remove.
   6
   7 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
   8
   9         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
  10
  11 2018-05-30  Pedro Alves  <palves@redhat.com>
  12
  13         * common/common-exceptions.h (exception_rethrow): Use
  14         ATTRIBUTE_NORETURN.
  15
  16 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
  17
  18         * breakpoint.c (print_solib_event, check_status_catch_solib):
  19         Remove struct keyword in range-based for loops.
  20         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
  21         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
  22         Likewise.
  23         * linespec.c (find_superclass_methods, search_minsyms_for_name):
  24         Likewise.
  25         * symfile.c (addr_info_make_relative): Likewise.
  26         * thread.c (value_in_thread_stack_temporaries): Likewise.
  27
  28 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
  29
  30         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
  31         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
  32         * coff-pe-read.c (add_pe_forwarded_sym): Replace
  33         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
  34         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
  35         * jit.c (jit_breakpoint_re_set_internal): Likewise.
  36         * printcmd.c (info_address_command): Likewise.
  37
  38 2018-05-29  Tom Tromey  <tom@tromey.com>
  39
  40         * windows-nat.c (handle_exception): Update fall-through comment.
  41
  42 2018-05-29  Tom Tromey  <tom@tromey.com>
  43
  44         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
  45         (struct program_space) <added_solibs>: Now a std::vector.
  46         * breakpoint.c (print_solib_event): Update.
  47         (check_status_catch_solib): Update.
  48         * progspace.c (clear_program_space_solib_cache): Update.
  49         * solib.c (update_solib_list): Update.
  50
  51 2018-05-29  Tom Tromey  <tom@tromey.com>
  52
  53         * python/py-type.c (typy_richcompare): Update.
  54         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
  55         * gdbtypes.h (types_deeply_equal): Return bool.
  56         (types_equal): Likewise.
  57         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
  58         declare VEC.
  59         (check_types_equal): Change worklist to std::vector.  Return
  60         bool.
  61         (struct type_equality_entry): Add constructor.
  62         (compare_maybe_null_strings): Return bool.
  63         (check_types_worklist): Return bool.  Change worklist to
  64         std::vector.
  65         (types_deeply_equal): Use std::vector.
  66         (types_equal): Return bool.
  67         (compare_maybe_null_strings): Simplify.
  68
  69 2018-05-29  Tom Tromey  <tom@tromey.com>
  70
  71         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
  72
  73 2018-05-29  Tom Tromey  <tom@tromey.com>
  74
  75         * objc-lang.h: Don't include cp-support.h.
  76         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
  77         declare VEC.
  78
  79 2018-05-27  Tom Tromey  <tom@tromey.com>
  80
  81         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
  82
  83 2018-05-25  Tom Tromey  <tom@tromey.com>
  84
  85         * value.c (value::location): Initialize.
  86
  87 2018-05-25  Tom Tromey  <tom@tromey.com>
  88
  89         * dbxread.c (init_bincl_list): Remove.
  90         (bincl_list): Now a std::vector.
  91         (bincls_allocated, next_bincl): Remove.
  92         (free_bincl_list, do_free_bincl_list_cleanup)
  93         (make_cleanup_free_bincl_list): Remove.
  94         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
  95         unique_xmalloc_ptr.
  96         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
  97         (struct header_file_location): Add constructor.
  98         (add_bincl_to_list): Remove.
  99
 100 2018-05-25  Tom Tromey  <tom@tromey.com>
 101
 102         * tui/tui.c (tui_enable): Update.
 103         * mi/mi-interp.c (mi_interp::init): Update.
 104         * interps.h (class interp) <name>: New method.
 105         <m_name>: Rename from name.
 106         (~scoped_restore_interp): Update.
 107         * interps.c (interp::interp): Update.
 108         (interp_add, interp_set, interp_lookup_existing)
 109         (current_interp_named_p): Update.
 110
 111 2018-05-25  Tom Tromey  <tom@tromey.com>
 112
 113         * interps.c (interp_name): Remove.
 114         * mi/mi-interp.c (mi_interp::init): Update.
 115         * interps.h (interp_name): Remove.
 116         (~scoped_restore_interp): Update.
 117         * tui/tui.c (tui_enable): Update.
 118
 119 2018-05-25  Tom Tromey  <tom@tromey.com>
 120
 121         * utils.c (fputs_maybe_filtered): Update.
 122         * linespec.c (decode_line_full): Update.
 123         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
 124         (mi_print_breakpoint_for_event, mi_solib_loaded)
 125         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
 126         (mi_user_selected_context_changed): Update.
 127         * mi/mi-main.c (mi_execute_command): Update.
 128         * cli/cli-script.c (execute_control_command): Update.
 129         * python/python.c (execute_gdb_command): Update.
 130         * solib.c (info_sharedlibrary_command): Update.
 131         * interps.c (interp_ui_out): Remove.
 132         * interps.h (interp_ui_out): Remove.
 133
 134 2018-05-25  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
 137         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
 138         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
 139
 140 2018-05-25  Tom Tromey  <tom@tromey.com>
 141
 142         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
 143         * interps.c (interp_exec): Use scoped_restore.
 144
 145 2018-05-25  Tom Tromey  <tom@tromey.com>
 146
 147         * remote.c (remote_target::remote_file_get): Use
 148         gdb::byte_vector.
 149         (remote_target::remote_file_put): Likewise.
 150
 151 2018-05-25  Tom Tromey  <tom@tromey.com>
 152
 153         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
 154         a std::string.
 155         (get_pe_section_index, add_pe_exported_sym): Update.
 156         (read_pe_exported_syms): Use gdb::def_vector.
 157
 158 2018-05-25  Tom Tromey  <tom@tromey.com>
 159
 160         * frame.c (remove_prev_frame): Remove.
 161         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
 162
 163 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
 164
 165         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
 166         Remove prototypes.
 167         * mips-linux-nat.c (supply_fpregset): Always call
 168         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
 169         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
 170         `mips_fill_fpregset'.
 171         * mips-linux-tdep.c (mips_supply_fpregset)
 172         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
 173         (mips_fill_fpregset_wrapper): Remove functions.
 174         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
 175         (mips_linux_fpregset): Remove variable.
 176         (mips_linux_iterate_over_regset_sections): Use
 177         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
 178         (mips_linux_o32_sigframe_init): Remove comment.
 179
 180 2018-05-25  Pedro Alves  <palves@redhat.com>
 181
 182         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
 183         (struct readahead_cache, struct packet_reg, struct
 184         remote_arch_state, class remote_state): Move higher up in the
 185         file.
 186         (remote_target::m_remote_state): Now an object instead of a pointer.
 187         (remote_target::get_remote_state): Adjust.
 188
 189 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 190
 191         * stack.c (select_and_print_frame): Delete.
 192         (struct function_bounds): Move struct within function.
 193         (func_command): Most content moved into new function
 194         find_frame_for_function, use new function, print result, add
 195         function comment.
 196         (find_frame_for_function): New function, now returns a result.
 197
 198 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 199
 200         * stack.c (iterate_over_block_arg_vars): Fix comment.
 201         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
 202
 203 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 204
 205         PR gdb/23203
 206         * frame.c
 207         (scoped_restore_selected_frame::scoped_restore_selected_frame):
 208         Define.
 209         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
 210         Define.
 211         * frame.h (class scoped_restore_selected_frame): New class.
 212         * stack.c (print_frame_local_vars): Remove catching and rethrowing
 213         of any exception, use scoped_restore_selected_frame to restore the
 214         frame instead.
 215
 216 2018-05-24  Pedro Alves  <palves@redhat.com>
 217
 218         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
 219         override.
 220
 221 2018-05-23  Tom Tromey  <tom@tromey.com>
 222
 223         * complaints.c (struct complaints): Remove.
 224         (symfile_complaint_book): Remove.
 225         (series): New global.
 226         (complaint_internal): Update.
 227         (clear_complaints): Update.
 228
 229 2018-05-23  Tom Tromey  <tom@tromey.com>
 230
 231         * complaints.c (counters): New global.
 232         (struct complain): Remove.
 233         (struct complaints) <root>: Remove.
 234         (complaint_sentinel): Remove.
 235         (symfile_complaint_book): Update.
 236         (find_complaint) Remove.
 237         (complaint_internal, clear_complaints): Update.
 238
 239 2018-05-23  Tom Tromey  <tom@tromey.com>
 240
 241         * complaints.c (struct complain) <file, line>: Remove.
 242         (find_complaint): Remove file, line parameters.
 243         (complaint_internal): Update.
 244
 245 2018-05-23  Tom Tromey  <tom@tromey.com>
 246
 247         * complaints.c (vcomplaint): Remove.
 248         (complaint_internal) Merge in contents of vcomplaint.
 249
 250 2018-05-23  Tom Tromey  <tom@tromey.com>
 251
 252         * complaints.c (struct complaints) <explanation>: Remove.
 253         (symfile_explanations): Remove.
 254         (symfile_complaint_book): Update.
 255         (vcomplaint): Update.
 256         (struct explanation): Remove.
 257
 258 2018-05-23  Tom Tromey  <tom@tromey.com>
 259
 260         * complaints.c (symfile_complaints): Remove.
 261         (complaint_internal): Remove "complaints" parameter.
 262         (clear_complaints, vcomplaint): Remove "c" parameter.
 263         (get_complaints): Remove.
 264         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
 265         (dwarf2_debug_line_missing_file_complaint)
 266         (dwarf2_debug_line_missing_end_sequence_complaint)
 267         (dwarf2_complex_location_expr_complaint)
 268         (dwarf2_const_value_length_mismatch_complaint)
 269         (dwarf2_section_buffer_overflow_complaint)
 270         (dwarf2_macro_malformed_definition_complaint)
 271         (dwarf2_invalid_attrib_class_complaint)
 272         (create_addrmap_from_index, dw2_symtab_iter_next)
 273         (dw2_expand_marked_cus)
 274         (dw2_debug_names_iterator::find_vec_in_debug_names)
 275         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
 276         (create_debug_type_hash_table, init_cutu_and_read_dies)
 277         (partial_die_parent_scope, add_partial_enumeration)
 278         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
 279         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
 280         (read_import_statement, read_file_scope, create_dwo_cu_reader)
 281         (create_cus_hash_table, create_dwp_hash_table)
 282         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
 283         (dwarf2_rnglists_process, dwarf2_ranges_process)
 284         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
 285         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
 286         (handle_struct_member_die, process_structure_scope)
 287         (read_array_type, read_common_block, read_module_type)
 288         (read_tag_pointer_type, read_typedef, read_base_type)
 289         (read_subrange_type, load_partial_dies, partial_die_info::read)
 290         (partial_die_info::read, partial_die_info::read)
 291         (partial_die_info::read, read_checked_initial_length_and_offset)
 292         (dwarf2_string_attr, read_formatted_entries)
 293         (dwarf_decode_line_header)
 294         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
 295         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
 296         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
 297         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
 298         (get_signatured_type, get_DW_AT_signature_type)
 299         (decode_locdesc, file_file_name, consume_improper_spaces)
 300         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
 301         (dwarf_decode_macro_bytes, dwarf_decode_macros)
 302         (dwarf2_symbol_mark_computed, set_die_type)
 303         (read_attribute_value): Update.
 304         * stap-probe.c (handle_stap_probe, get_stap_base_address):
 305         Update.
 306         * dbxread.c (unknown_symtype_complaint)
 307         (lbrac_mismatch_complaint, repeated_header_complaint)
 308         (set_namestring, function_outside_compilation_unit_complaint)
 309         (read_dbx_symtab, process_one_symbol): Update.
 310         * gdbtypes.c (stub_noname_complaint): Update.
 311         * windows-nat.c (handle_unload_dll): Update.
 312         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
 313         (decode_base_type): Update.
 314         * xcoffread.c (bf_notfound_complaint, ef_complaint)
 315         (eb_complaint, record_include_begin, record_include_end)
 316         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
 317         (process_xcoff_symbol, read_symbol)
 318         (function_outside_compilation_unit_complaint)
 319         (scan_xcoff_symtab): Update.
 320         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
 321         * buildsym.c (finish_block_internal, make_blockvector)
 322         (end_symtab_get_static_block, augment_type_symtab): Update.
 323         * dtrace-probe.c (dtrace_process_dof)
 324         (dtrace_static_probe_ops::get_probes): Update.
 325         * complaints.h (struct complaint): Don't declare.
 326         (symfile_complaints): Remove.
 327         (complaint_internal): Remove "complaints" parameter.
 328         (complaint): Likewise.
 329         (clear_complaints): Likewise.
 330         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 331         (reread_symbols): Update.
 332         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
 333         (dwarf2_frame_cache, decode_frame_entry): Update.
 334         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
 335         * objc-lang.c (lookup_objc_class, lookup_child_selector)
 336         (info_selectors_command): Update.
 337         * macrotab.c (macro_include, check_for_redefinition)
 338         (macro_undef): Update.
 339         * objfiles.c (filter_overlapping_sections): Update.
 340         * stabsread.c (invalid_cpp_abbrev_complaint)
 341         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
 342         (define_symbol, error_type, read_type, rs6000_builtin_type)
 343         (stabs_method_name_from_physname, read_member_functions)
 344         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
 345         (attach_fields_to_type, complain_about_struct_wipeout)
 346         (read_range_type, read_args, common_block_start)
 347         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
 348         Update.
 349         * mdebugread.c (index_complaint, unknown_ext_complaint)
 350         (basic_type_complaint, bad_tag_guess_complaint)
 351         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
 352         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
 353         (parse_procedure, parse_lines)
 354         (function_outside_compilation_unit_complaint)
 355         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
 356         (bad_tag_guess_complaint, reg_value_complaint): Update.
 357         * cp-support.c (demangled_name_complaint): Update.
 358         * macroscope.c (sal_macro_scope): Update.
 359         * dwarf-index-write.c (class debug_names): Update.
 360
 361 2018-05-23  Tom Tromey  <tom@tromey.com>
 362
 363         * complaints.c (clear_complaints): Remove "noisy" parameter.
 364         * complaints.h (clear_complaints): Update.
 365         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 366         (reread_symbols): Update.
 367
 368 2018-05-23  Tom Tromey  <tom@tromey.com>
 369
 370         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
 371         SUBSEQUENT_MESSAGE.
 372         (vcomplaint, clear_complaints): Update.
 373         (symfile_explanations): Remove some messages.
 374
 375 2018-05-23  Tom Tromey  <tom@tromey.com>
 376
 377         * complaints.c (internal_complaint): Remove.
 378         * complaints.h (internal_complaint): Remove.
 379
 380 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 381
 382         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
 383
 384 2018-05-22  Pedro Alves  <palves@redhat.com>
 385
 386         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
 387         (remote_fileio_badfd, remote_fileio_return_errno)
 388         (remote_fileio_return_success, remote_fileio_func_open)
 389         (remote_fileio_func_open, remote_fileio_func_close)
 390         (remote_fileio_func_read, remote_fileio_func_write)
 391         (remote_fileio_func_lseek, remote_fileio_func_rename)
 392         (remote_fileio_func_unlink, remote_fileio_func_stat)
 393         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
 394         (remote_fileio_func_isatty, remote_fileio_func_system): Add
 395         remote_target parameter.
 396         (remote_fio_func_map) <func>: Add remote_target parameter.
 397         (do_remote_fileio_request, remote_fileio_request):
 398         * remote-fileio.h (remote_fileio_request):
 399         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
 400         remote_target parameter.
 401         (remote_notif_process, handle_notification): Adjust to pass down
 402         the remote.
 403         (remote_notif_state_allocate): Add remote_target parameter.  Save
 404         it.
 405         * remote-notif.h (struct remote_target): Forward declare.
 406         (struct notif_client) <parse, ack, can_get_pending_events>: Add
 407         remote_target parameter.
 408         (struct remote_notif_state) <remote>: New field.
 409         (remote_notif_ack, remote_notif_parse): Add remote_target
 410         parameter.
 411         (remote_notif_state_allocate, remote_notif_state_allocate): Add
 412         remote_target parameter.
 413         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
 414         (threads_listing_context, rmt_thread_action, protocol_feature)
 415         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
 416         (packet_result, struct threads_listing_context, remote_state):
 417         Move definitions and declarations higher up.
 418         (remote_target) <~remote_target>: Declare.
 419         (remote_download_command_source, remote_file_put, remote_file_get)
 420         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
 421         (remote_hostio_pread_vFile, remote_hostio_send_command)
 422         (remote_hostio_set_filesystem, remote_hostio_open)
 423         (remote_hostio_close, remote_hostio_unlink, remote_state)
 424         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
 425         (get_memory_write_packet_size, get_memory_read_packet_size)
 426         (append_pending_thread_resumptions, remote_detach_1)
 427         (append_resumption, remote_resume_with_vcont)
 428         (add_current_inferior_and_thread, wait_ns, wait_as)
 429         (process_stop_reply, remote_notice_new_inferior)
 430         (process_initial_stop_replies, remote_add_thread)
 431         (btrace_sync_conf, remote_btrace_maybe_reopen)
 432         (remove_new_fork_children, kill_new_fork_children)
 433         (discard_pending_stop_replies, stop_reply_queue_length)
 434         (check_pending_events_prevent_wildcard_vcont)
 435         (discard_pending_stop_replies_in_queue, stop_reply)
 436         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
 437         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
 438         (remote_interrupt_as, remote_interrupt_ns)
 439         (remote_get_noisy_reply, remote_query_attached)
 440         (remote_add_inferior, remote_current_thread, get_current_thread)
 441         (set_thread, set_general_thread, set_continue_thread)
 442         (set_general_process, write_ptid)
 443         (remote_unpack_thread_info_response, remote_get_threadinfo)
 444         (parse_threadlist_response, remote_get_threadlist)
 445         (remote_threadlist_iterator, remote_get_threads_with_ql)
 446         (remote_get_threads_with_qxfer)
 447         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
 448         (get_offsets, remote_check_symbols, remote_supported_packet)
 449         (remote_query_supported, remote_packet_size)
 450         (remote_serial_quit_handler, remote_detach_pid)
 451         (remote_vcont_probe, remote_resume_with_hc)
 452         (send_interrupt_sequence, interrupt_query)
 453         (remote_notif_get_pending_events, fetch_register_using_p)
 454         (send_g_packet, process_g_packet, fetch_registers_using_g)
 455         (store_register_using_P, store_registers_using_G)
 456         (set_remote_traceframe, check_binary_download)
 457         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
 458         (remote_xfer_live_readonly_partial, remote_read_bytes)
 459         (remote_send_printf, remote_flash_write, readchar)
 460         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
 461         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
 462         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
 463         (extended_remote_disable_randomization, extended_remote_run)
 464         (send_environment_packet, extended_remote_environment_support)
 465         (extended_remote_set_inferior_cwd, remote_write_qxfer)
 466         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
 467         (packet_command): Now methods of ...
 468         (remote_target): ... this class.
 469         (m_remote_state) <remote_target>: New field.
 470         (struct remote_state) <stop_reply_queue,
 471         remote_async_inferior_event_token, wait_forever_enabled_p>: New
 472         fields.
 473         (remote_state::remote_state): Allocate stop_reply_queue.
 474         (remote_state): Delete global.
 475         (get_remote_state_raw): Delete.
 476         (remote_target::get_remote_state): Allocate m_remote_state on
 477         demand.
 478         (get_current_remote_target): New.
 479         (remote_ops, extended_remote_ops): Delete.
 480         (wait_forever_enabled_p, remote_async_inferior_event_token):
 481         Delete, moved to struct remote_state.
 482         (remote_target::close): Delete self.  Destruction bits split to
 483         ...
 484         (remote_target::~remote_target): ... this.
 485         (show_memory_packet_size): Adjust to use
 486         get_current_remote_target.
 487         (struct protocol_feature) <func>: Add remote_target parameter.
 488         All callers adjusted.
 489         (curr_quit_handler_target): New.
 490         (remote_serial_quit_handler): Reimplement.
 491         (remote_target::open_1): Adjust to use get_current_remote_target.
 492         Heap-allocate remote_target/extended_remote_target instances.
 493         (vcont_builder::vcont_builder): Add remote_target parameter, and
 494         save it in m_remote.  All callers adjusted.
 495         (vcont_builder::m_remote): New field.
 496         (vcont_builder::restart, vcont_builder::flush)
 497         (vcont_builder::push_action): Use it.
 498         (remote_target::commit_resume): Use it.
 499         (struct queue_iter_param) <remote>: New field.
 500         (remote_target::remove_new_fork_children): Fill in 'remote' field.
 501         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
 502         (check_pending_event_prevents_wildcard_vcont_callback)
 503         (remote_target::check_pending_events_prevent_wildcard_vcont)
 504         (remote_target::discard_pending_stop_replies)
 505         (remote_target::discard_pending_stop_replies_in_queue)
 506         (remote_target::remote_notif_remove_queued_reply): Fill in
 507         'remote' field.
 508         (remote_notif_get_pending_events): New.
 509         (remote_target::readchar, remote_target::remote_serial_write):
 510         Save/restore curr_quit_handler_target.
 511         (putpkt): New.
 512         (kill_new_fork_children): Fill in 'remote' field.
 513         (packet_command): Use get_current_remote_target, defer to
 514         remote_target method of same name.
 515         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
 516         parameter, and save it in m_remote.  All callers adjusted.
 517         (scoped_remote_fd::release): Use m_remote.
 518         (scoped_remote_fd::m_remote): New field.
 519         (remote_file_put, remote_file_get, remote_file_delete): Use
 520         get_current_remote_target, defer to remote_target method of same
 521         name.
 522         (remote_btrace_reset): Add remote_state paremeter.  Update all
 523         callers.
 524         (remote_async_inferior_event_handler). Pass down 'data'.
 525         (remote_new_objfile): Use get_current_remote_target.
 526         (remote_target::vcont_r_supported): New.
 527         (set_range_stepping): Use get_current_remote_target and
 528         remote_target::vcont_r_supported.
 529         (_initialize_remote): Don't allocate 'remote_state' and
 530         'stop_reply_queue' globals.
 531         * remote.h (struct remote_target): Forward declare.
 532         (getpkt, putpkt, remote_notif_get_pending_events): Add
 533         'remote_target' parameter.
 534
 535 2018-05-22  Pedro Alves  <palves@redhat.com>
 536
 537         * remote.c (vcont_builder): Now a class.  Make all data members
 538         private.
 539         (vcont_builder) <vcont_builder, restart, flush, push_action>:
 540         Declare methods.
 541         (vcont_builder_restart): Rename to ...
 542         (vcont_builder::restart): ... this.
 543         (vcont_builder_flush): Rename to ...
 544         (vcont_builder::flush): ... this.
 545         (vcont_builder_push_action): Rename to ...
 546         (vcont_builder::push_action): ... this.
 547         (remote_target::commit_resume): Adjust.
 548
 549 2018-05-22  Pedro Alves  <palves@redhat.com>
 550
 551         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
 552         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
 553         (get_fixed_memory_packet_size): New.
 554         (get_memory_packet_size): Use it.
 555         (set_memory_packet_size): Don't override the config size with
 556         DEFAULT_MAX_MEMORY_PACKET_SIZE.
 557         (show_memory_packet_size): Use get_fixed_memory_packet_size.
 558         Don't refer to get_memory_packet_size if not connected to a remote
 559         target.  Show "(default)" if configured size is 0.
 560
 561 2018-05-22  Pedro Alves  <palves@redhat.com>
 562
 563         * remote.c (remote_target::mourn_inferior): Move
 564         discard_pending_stop_replies call here from ...
 565         (_initialize_remote): ... here.
 566
 567 2018-05-22  Pedro Alves  <palves@redhat.com>
 568
 569         * remote.c (compare_section_command): Remove set_general_process
 570         call.
 571
 572 2018-05-22  Pedro Alves  <palves@redhat.com>
 573
 574         * remote.c (struct packet_reg, struct remote_arch_state):
 575         Move higher up in the file.
 576         (remote_state) <m_arch_states>: Store remote_arch_state values
 577         instead of remote_arch_state pointers.
 578         (remote_state::get_remote_arch_state): Adjust.
 579
 580 2018-05-22  Pedro Alves  <palves@redhat.com>
 581
 582         * remote.c: Include <unordered_map>.
 583         (remote_state): Now a class.
 584         (remote_state) <get_remote_arch_state>: Declare method.
 585         <get_remote_arch_state>: New field.
 586         (remote_arch_state) <remote_arch_state>: Declare ctor.
 587         <regs>: Now a unique_ptr.
 588         (remote_gdbarch_data_handle): Delete.
 589         (get_remote_arch_state): Delete.
 590         (remote_state::get_remote_arch_state): New.
 591         (get_remote_state): Adjust to call remote_state's
 592         get_remote_arch_state method.
 593         (init_remote_state): Delete, bits factored out to ...
 594         (remote_arch_state::remote_arch_state): ... this new method.
 595         (get_remote_packet_size, get_memory_packet_size)
 596         (process_g_packet, remote_target::fetch_registers)
 597         (remote_target::prepare_to_store, store_registers_using_G)
 598         (remote_target::store_registers, remote_target::get_trace_status):
 599         Adjust to call remote_state's method.
 600         (_initialize_remote): Remove reference to
 601         remote_gdbarch_data_handle.
 602
 603 2018-05-22  Pedro Alves  <palves@redhat.com>
 604
 605         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
 606         pread>: New method declarations.
 607         (remote_target::open_1): Adjust.
 608         (readahead_cache_invalidate): Rename to ...
 609         (readahead_cache::invalidate): ... this, and adjust to be a class
 610         method.
 611         (readahead_cache_invalidate_fd): Rename to ...
 612         (readahead_cache::invalidate_fd): ... this, and adjust to be a
 613         class method.
 614         (remote_hostio_pwrite): Adjust.
 615         (remote_hostio_pread_from_cache): Rename to ...
 616         (readahead_cache::pread): ... this, and adjust to be a class
 617         method.
 618         (remote_hostio_close): Adjust.
 619
 620 2018-05-22  Pedro Alves  <palves@redhat.com>
 621
 622         * remote.c (remote_hostio_close_cleanup): Delete.
 623         (class scoped_remote_fd): New.
 624         (remote_file_put, remote_file_get): Use it.
 625
 626 2018-05-22  Pedro Alves  <palves@redhat.com>
 627
 628         (struct vCont_action_support): Use bool and initialize all fields.
 629         (struct readahead_cache): Initialize all fields.
 630         (remote_state): Use bool and initialize all fields.
 631         (remote_state::remote_state, remote_state::~remote_state): New.
 632         (new_remote_state): Delete.
 633         (_initialize_remote): Use new to allocate remote_state.
 634
 635 2018-05-22  Pedro Alves  <palves@redhat.com>
 636             張俊芝  <zjz@zjz.name>
 637
 638         PR gdb/22973
 639         * c-exp.y: Include "c-support.h".
 640         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
 641         of tolower.  Use c_ident_is_alpha to scan names.
 642         * c-lang.c: Include "c-support.h".
 643         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
 644         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
 645         * c-support.h: New file, with bits factored out from ...
 646         * cp-name-parser.y: ... this file.
 647         Include "c-support.h".
 648         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
 649         c-support.h and renamed.
 650         (symbol_end, yylex): Adjust.
 651
 652 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 653
 654         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
 655         parameter type to CORE_ADDR.
 656         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
 657         parameter type in declaration to CORE_ADDR.
 658         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
 659         target_auxv_search to get AT_HWCAP and use the result to get the
 660         target description.
 661         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
 662         to CORE_ADDR. Remove the cast of the return value to unsigned
 663         long. Fix error predicate of target_auxv_search.
 664         (ppc_linux_nat_target::read_description): Change the type of the
 665         hwcap variable to CORE_ADDR.
 666
 667 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 668
 669         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
 670         if the size of fpscr is larger than 32 bits.
 671
 672 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 673
 674         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
 675         (ppc32_linux_vsxregmap): New global.
 676         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
 677         regcache_supply_regset, and regcache_collect_regset.
 678         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
 679         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
 680         (fetch_vsx_register, store_vsx_register): Remove.
 681         (fetch_vsx_registers): Add regno parameter. Get regset using
 682         ppc_linux_vsxregset. Use regset to supply registers.
 683         (store_vsx_registers): Add regno parameter. Get regset using
 684         ppc_linux_vsxregset. Use regset to collect registers.
 685         (fetch_register): Call fetch_vsx_registers instead of
 686         fetch_vsx_register.
 687         (store_register): Call store_vsx_registers instead of
 688         store_vsx_register.
 689         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
 690         new regno parameter.
 691         (store_ppc_registers): Call store_vsx_registers with -1 for the
 692         new regno parameter.
 693         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
 694         (ppc_collect_vsxregset): Remove.
 695
 696 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 697
 698         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
 699         offset fields.
 700         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
 701         for vector register offset fields.
 702         (ppc64_fbsd_reg_offsets): Likewise.
 703         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 704         to vector register offset fields.
 705         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 706         to vector register offset fields.
 707         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
 708         vector register offset fields.
 709         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
 710         initializers for vector register offset fields.
 711         (rs6000_aix64_reg_offsets): Likewise.
 712         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
 713         (ppc_supply_vrregset): Remove.
 714         (ppc_collect_vrregset): Remove.
 715         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
 716         (ppc_linux_vrregset) : New function.
 717         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
 718         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
 719         (ppc32_linux_vrregset): Remove.
 720         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
 721         and use result instead of ppc32_linux_vrregset.
 722         (ppc32_linux_reg_offsets): Remove initializers for vector register
 723         offset fields.
 724         (ppc64_linux_reg_offsets): Likewise.
 725         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
 726         * ppc-linux-nat.c: Include regset.h.
 727         (gdb_vrregset_t): Adjust comment to account for little-endian
 728         mode.
 729         (supply_vrregset, fill_vrregset): Remove.
 730         (fetch_altivec_register, store_altivec_register): Remove.
 731         (fetch_altivec_registers): Add regno parameter. Get regset using
 732         ppc_linux_vrregset. Use regset to supply registers.
 733         (store_altivec_registers): Add regno parameter. Get regset using
 734         ppc_linux_vrregset. Use regset to collect registers.
 735         (fetch_register): Call fetch_altivec_registers instead of
 736         fetch_altivec_register.
 737         (store_register): Call store_altivec_registers instead of
 738         store_altivec_register.
 739         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
 740         the new regno parameter.
 741         (store_ppc_registers): Call store_altivec_registers with -1 for
 742         the new regno parameter.
 743
 744 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 745
 746         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
 747         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
 748         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
 749         (gdb_vrregset_t): Change array type size to
 750         PPC_LINUX_SIZEOF_VRREGSET.
 751         (gdb_vsxregset_t): Change array type size to
 752         PPC_LINUX_SIZEOF_VSXREGSET.
 753         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
 754         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
 755         PPC_LINUX_SIZEOF_VSXREGSET.
 756
 757 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 758
 759         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
 760         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
 761         nat/ppc-linux.c.
 762         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
 763         ppc_linux_target_wordsize with tid.
 764         (ppc_linux_nat_target::read_description): Call ppc_linux_target
 765         wordsize with tid.
 766         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
 767         (ppc64_64bit_inferior_p): Add static and inline specifiers.
 768         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
 769         tid parameter. Remove static specifier.
 770         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
 771         (ppc_linux_target_wordsize): New declaration.
 772
 773 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 774
 775         * arch/ppc-linux-common.c: New file.
 776         * arch/ppc-linux-common.h: New file.
 777         * arch/ppc-linux-tdesc.h: New file.
 778         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
 779         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
 780         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
 781         arch/ppc-linux-tdesc.h.
 782         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
 783         arch/ppc-linux-tdesc.h.
 784         (ppc_linux_nat_target::read_description): Remove target
 785         description matching code. Fill a ppc_linux_features struct and
 786         call ppc_linux_match_description with it. Move comment about ISA
 787         2.05 to ppc-linux-common.c.
 788         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
 789         arch/ppc-linux-tdesc.h.
 790         (ppc_linux_core_read_description): Remove target description
 791         matching code. Fill a ppc_linux_features struct and call
 792         ppc_linux_match_description with it.
 793         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
 794         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
 795         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
 796         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
 797         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
 798         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
 799         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
 800         (tdesc_powerpc_e500l): Remove.
 801
 802 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
 803
 804         * ada-lang.c (catch_assert_command): Pass empty string instead
 805         of NULL for excep_string argument.
 806
 807 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 808
 809         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
 810         the width of the requested register exceeds the width of the
 811         `ptrace' data type.
 812
 813 2018-05-21  Tom Tromey  <tom@tromey.com>
 814
 815         * printcmd.c (output_command): Remove.
 816         (output_command_const): Rename to output_command.
 817         * valprint.h (output_command): Rename from output_command_const.
 818         * tracepoint.c (trace_dump_actions): Call output_command.
 819
 820 2018-05-21  Tom Tromey  <tom@tromey.com>
 821
 822         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
 823         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
 824         * ada-lang.h (create_ada_exception_catchpoint): Update.
 825         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
 826         std::string.
 827         (create_excep_cond_exprs, ~ada_catchpoint)
 828         (should_stop_exception, print_one_exception)
 829         (print_mention_exception, print_recreate_exception): Update.
 830         (ada_get_next_arg): Remove.
 831         (catch_ada_exception_command_split): Use std::string.  Change type
 832         of "excep_string", "cond_string".
 833         (catch_ada_exception_command): Update.
 834         (create_ada_exception_catchpoint): Change type of excep_string.
 835         (ada_exception_sal): Remove excep_string parameter.
 836         (~ada_catchpoint): Remove.
 837
 838 2018-05-21  Tom Tromey  <tom@tromey.com>
 839
 840         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
 841         cleanup.
 842
 843 2018-05-21  Tom Tromey  <tom@tromey.com>
 844
 845         * ada-lang.c (ada_exception_message_1, ada_exception_message):
 846         Return unique_xmalloc_ptr.
 847         (print_it_exception): Update.
 848
 849 2018-05-21  Tom Tromey  <tom@tromey.com>
 850
 851         * tracepoint.c (trace_dump_actions): Use std::string.
 852
 853 2018-05-21  Tom Tromey  <tom@tromey.com>
 854
 855         * symfile.c (reread_symbols): Use std::string for original_name.
 856
 857 2018-05-21  Tom Tromey  <tom@tromey.com>
 858
 859         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
 860         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
 861         constructor.
 862
 863 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
 864
 865         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
 866         instance to...
 867         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
 868         * objfiles.c (get_objfile_bfd_data): Allocate
 869         objfile_per_bfd_storage with obstack_new when allocating on
 870         obstack.
 871
 872 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
 873
 874         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
 875         OBSTACK_ZALLOC.
 876         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
 877         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
 878         * mdebugread.c (mdebug_build_psymtabs): Likewise.
 879         (add_pending): Likewise.
 880         (parse_symbol): Likewise.
 881         (parse_partial_symbols): Likewise.
 882         (psymtab_to_symtab_1): Likewise.
 883         (new_psymtab): Likewise.
 884         (elfmdebug_build_psymtabs): Likewise.
 885         * minsyms.c (terminate_minimal_symbol_table): Likewise.
 886         * objfiles.c (get_objfile_bfd_data): Likewise.
 887         (objfile_register_static_link): Likewise.
 888         * psymtab.c (allocate_psymtab): Likewise.
 889         * stabsread.c (read_member_functions): Likewise.
 890         * xcoffread.c (xcoff_end_psymtab): Likewise.
 891
 892 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
 893
 894         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
 895         compiler supports std::is_trivially_constructible.
 896         * common/poison.h: Include obstack.h.
 897         (IsMallocable): Define to is_trivially_constructible if the
 898         compiler supports it, define to true_type otherwise.
 899         (xobnew): New.
 900         (XOBNEW): Redefine.
 901         (xobnewvec): New.
 902         (XOBNEWVEC): Redefine.
 903         * gdb_obstack.h (obstack_zalloc): New.
 904         (OBSTACK_ZALLOC): Redefine.
 905         (obstack_calloc): New.
 906         (OBSTACK_CALLOC): Redefine.
 907         (obstack_new): New.
 908         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
 909         (gdbarch_obstack): New declaration in gdbarch.h, definition in
 910         gdbarch.c.
 911         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
 912         obstack_calloc/obstack_zalloc.
 913         (gdbarch_obstack_zalloc): Remove.
 914         * target-descriptions.c (tdesc_data_init): Use obstack_new.
 915
 916 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 917
 918         * stack.c (backtrace_command_1): Remove useless variable int i.
 919
 920 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 921
 922         * stack.c (print_frame_info): Fix comment.
 923
 924 2018-05-18  Tom Tromey  <tom@tromey.com>
 925
 926         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
 927         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
 928         (~dwarf2_per_objfile): Update
 929         (dwarf2_get_dwz_file): Use new.
 930         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
 931         unique_ptr.
 932
 933 2018-05-18  Tom Tromey  <tom@tromey.com>
 934
 935         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
 936         unique_ptr.
 937         * dwarf2read.c (struct dwp_file): Add constructor and
 938         initializers.
 939         (open_and_init_dwp_file): Return a unique_ptr.
 940         (dwarf2_per_objfile, create_dwp_hash_table)
 941         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
 942         (lookup_dwo_unit_in_dwp): Update.
 943         (open_and_init_dwp_file, get_dwp_file): Update.
 944
 945 2018-05-18  Tom Tromey  <tom@tromey.com>
 946
 947         * dwarf2read.c (dwarf2_per_objfile): Update.
 948         (struct mapped_index): Add initializers.
 949         (dwarf2_read_index): Use new.
 950         (dw2_symtab_iter_init): Update.
 951         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
 952         unique_ptr.
 953
 954 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
 955
 956         * dwarf2read.c (mapped_index) <total_size>: Remove.
 957
 958 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
 959
 960         * unittests/format_pieces-selftests.c (test_format_specifier):
 961         Add ARI comments.
 962
 963 2018-05-18  Tom Tromey  <tom@tromey.com>
 964
 965         * c-typeprint.c (maybe_print_hole): New function.
 966         (c_print_type_struct_field_offset): Update.
 967         (c_type_print_base_struct_union): Call maybe_print_hole.
 968
 969 2018-05-17  Keith Seitz  <keiths@redhat.com>
 970
 971         * breakpoint.c (build_bpstat_chain): New function, moved from
 972         bpstat_stop_status.
 973         (bpstat_stop_status): Add optional parameter, `stop_chain'.
 974         If no stop chain is passed, call build_bpstat_chain to build it.
 975         * breakpoint.h (build_bpstat_chain): Declare.
 976         (bpstat_stop_status): Move documentation here from breakpoint.c.
 977         * infrun.c (handle_signal_stop): Before eliding inlined frames,
 978         build the stop chain and pass it to skip_inline_frames.
 979         Pass this stop chain to bpstat_stop_status.
 980         * inline-frame.c: Include breakpoint.h.
 981         (stopped_by_user_bp_inline_frame): New function.
 982         (skip_inline_frames): Add parameter `stop_chain'.
 983         Move documention to inline-frame.h.
 984         If non-NULL, use stopped_by_user_bp_inline_frame to determine
 985         whether the frame should be elided.
 986         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
 987         Add moved documentation and update for new parameter.
 988
 989 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
 990
 991         PR cli/14975
 992         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 993         unittests/format_pieces-selftests.c.
 994         * common/format.h (format_piece) <operator==>: New.
 995         (format_pieces) <operator[]>: Remove.
 996         * common/format.c (format_pieces::format_pieces): Handle \e.
 997         * unittests/format_pieces-selftests.c: New.
 998
 999 2018-05-17  Tom Tromey  <tom@tromey.com>
1000
1001         PR symtab/23010:
1002         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
1003         (dw2_instantiate_symtab): Add skip_partial parameter.
1004         (dw2_find_last_source_symtab, dw2_map_expand_apply)
1005         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
1006         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
1007         (dw2_expand_symtabs_matching_one)
1008         (dw2_find_pc_sect_compunit_symtab)
1009         (dw2_debug_names_lookup_symbol)
1010         (dw2_debug_names_expand_symtabs_for_function): Update.
1011         (init_cutu_and_read_dies): Add skip_partial parameter.
1012         (process_psymtab_comp_unit, build_type_psymtabs_1)
1013         (process_skeletonless_type_unit, load_partial_comp_unit)
1014         (psymtab_to_symtab_1): Update.
1015         (load_full_comp_unit): Add skip_partial parameter.
1016         (process_imported_unit_die, dwarf2_read_addr_index)
1017         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
1018         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
1019         (read_signatured_type): Update.
1020
1021 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1022
1023         * value.c (release_value): Remove unused variable.
1024         (record_latest_value): Likewise.
1025         (access_value_history): Likewise.
1026         (preserve_values): Likewise.
1027
1028 2018-05-17  Tom Tromey  <tom@tromey.com>
1029
1030         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
1031         Initialize.
1032
1033 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
1034
1035         PR gdb/22286
1036         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
1037         Also handle registers whose width is not a multiple of
1038         PTRACE_TYPE_RET.
1039         (linux_nat_trad_target::store_register): Likewise.
1040
1041 2018-05-16  Tom Tromey  <tom@tromey.com>
1042
1043         * gdbcore.h (core_bfd): Redefine.
1044         * corelow.c (core_target::close): Update.
1045         (core_target_open): Update.
1046         * progspace.h (struct program_space) <cbfd>: Now a
1047         gdb_bfd_ref_ptr.
1048
1049 2018-05-16  Tom Tromey  <tom@tromey.com>
1050
1051         PR cli/19551:
1052         * symfile-add-flags.h (enum symfile_add_flags)
1053         <SYMFILE_NOT_FILENAME>: New constant.
1054         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
1055         objfile name from BFD.
1056         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
1057         * minidebug.c (find_separate_debug_file_in_section): Put
1058         ".gnu_debugdata" into BFD's file name.
1059
1060 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
1061
1062         * regcache.c (regcache_read_ftype, regcache_write_ftype):
1063         Remove.
1064
1065 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
1066
1067         PR binutils/21446
1068         * aarch64-tdep.c (aarch64_analyze_prologue,
1069         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
1070         Indicate not interested in errors.
1071
1072 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1073
1074         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
1075         Supply the MIPS_ZERO_REGNUM register.
1076
1077 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1078
1079         * mips-tdep.c (mask_address_var): Make variable static.
1080
1081 2018-05-14  Tom Tromey  <tom@tromey.com>
1082
1083         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
1084
1085 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1086
1087         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
1088         FXSAVE_ADDR for the mxcsr register.
1089
1090 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
1091
1092         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
1093
1094 2018-05-11  Pedro Alves  <palves@redhat.com>
1095
1096         * corelow.c (core_target) <core_target>: No longer inline.
1097         Initialize m_core_gdbarch, m_core_vec and build the section table
1098         here.
1099         <~core_target>: New.
1100         <core_gdbarch, get_core_register_section>: New methods.
1101         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
1102         factored out from ...
1103         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
1104         (core_ops): Delete.
1105         (sniff_core_bfd): Add gdbarch parameter.
1106         (core_close): Delete, merged into ...
1107         (core_target::close): ... here.  Delete self.
1108         (core_close_cleanup): Delete.
1109         (core_target_open): Allocate a core_target on the heap.  Use a
1110         unique_ptr instead of a cleanup.  Bits moved into the core_target
1111         ctor.  Adjust to use core_target methods instead of globals.
1112         (get_core_register_section): Rename to ...
1113         (core_target::get_core_register_section): ... this and adjust.
1114         (struct get_core_registers_cb_data): New.
1115         (get_core_registers_cb): Use it.  Use bool.
1116         (core_target::fetch_registers, core_target::files_info)
1117         (core_target::xfer_partial, core_target::read_description)
1118         (core_target::pid_to, core_target::thread_name): Adjust to
1119         reference class fields instead of globals.
1120         * target.h (struct target_ops_deleter, target_ops_up): New.
1121
1122 2018-05-11  Pedro Alves  <palves@redhat.com>
1123
1124         * corefile.c (core_file_command): Move to corelow.c.
1125         * corelow.c (the_core_target): Delete.
1126         (core_file_command): Moved from corefile.c.  Check exec_bfd
1127         instead of the_core_target.  Use target_detach instead of calling
1128         into the_core_target directly.
1129         (maybe_say_no_core_file_now): New.
1130         (core_target::detach): Use it.
1131         (_initialize_corelow): Remove references to the_core_target.
1132         * gdbcore.h (the_core_target): Delete.
1133
1134 2018-05-11  Tom Tromey  <tromey@redhat.com>
1135             Pedro Alves  <palves@redhat.com>
1136
1137         * corefile.c (core_bfd): Remove.
1138         * gdbcore.h (core_bfd): Now a macro.
1139         * progspace.h (struct program_space) <cbfd>: New field.
1140
1141 2018-05-11  Tom Tromey  <tom@tromey.com>
1142
1143         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1144         gdb::def_vector.
1145
1146 2018-05-10  Tom Tromey  <tom@tromey.com>
1147
1148         * configure: Rebuild.
1149         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1150
1151 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1152
1153         PR server/23158:
1154         * regformats/regdat.sh: Adjust script, following the addition
1155         of the new expedite_regs parameter to init_target_desc.
1156
1157 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1158
1159         PR gdb/23127
1160         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1161         set_gdbarch_significant_addr_bit.
1162         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1163         set_gdbarch_significant_addr_bit.
1164         * utils.c (address_significant): Update to sign extend addr.
1165
1166 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1167
1168         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1169         (xtensa_linux_init_abi): Limit tdep->num_regs by
1170         tdep->num_nopriv_regs.
1171         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1172         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1173         not initialized.
1174
1175 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1176
1177         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1178
1179 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1180
1181         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1182         (I387_MXCSR_INIT_VAL): New constant.
1183         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1184         buffer if it was supplied by the inferior.
1185         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1186         (i387_xsave_get_clear_bv): New function.
1187         (i387_supply_xsave): Only read x87 control registers from the
1188         xsave buffer if the feature is enabled, and the state will have
1189         been written, otherwise, provide a suitable default.
1190         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1191         including x87 control registers.  Update control registers if they
1192         have changed from the default value, and mark features as enabled
1193         as required.
1194         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1195
1196 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1197
1198         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1199
1200 2018-05-07  Tom Tromey  <tom@tromey.com>
1201
1202         * configure: Rebuild.
1203         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1204
1205 2018-05-07  Tom Tromey  <tom@tromey.com>
1206
1207         PR tdep/20362:
1208         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1209         bit.  Use correct value for VDIV.
1210
1211 2018-05-04  Tom Tromey  <tom@tromey.com>
1212
1213         * configure: Rebuild.
1214         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1215
1216 2018-05-04  Tom Tromey  <tom@tromey.com>
1217
1218         * linux-record.c (record_linux_system_call) <case
1219         RECORD_SYS_RECVFROM>: Add "break".
1220
1221 2018-05-04  Tom Tromey  <tom@tromey.com>
1222
1223         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1224         Add missing "break".
1225         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1226         Add missing "break".
1227
1228 2018-05-04  Tom Tromey  <tom@tromey.com>
1229
1230         * rs6000-tdep.c (ppc_process_record_op4)
1231         (ppc_process_record_op63): Add fall-through comment.
1232
1233 2018-05-04  Tom Tromey  <tom@tromey.com>
1234
1235         * i386-tdep.c (i386_process_record): Add fall-through comment.
1236
1237 2018-05-04  Tom Tromey  <tom@tromey.com>
1238
1239         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1240         comment.
1241
1242 2018-05-04  Tom Tromey  <tom@tromey.com>
1243
1244         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1245         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1246         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1247         comment.
1248         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1249         comment.
1250         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1251         comment.
1252
1253 2018-05-04  Tom Tromey  <tom@tromey.com>
1254
1255         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1256
1257 2018-05-04  Tom Tromey  <tom@tromey.com>
1258
1259         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1260         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1261         * symfile.c (section_is_mapped): Fix fall-through comment.
1262         * stabsread.c (define_symbol, read_member_functions): Fix
1263         fall-through comment.
1264         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1265         comment.
1266         * remote.c (remote_wait_as): Fix fall-through comment.
1267         * p-exp.y (yylex): Fix fall-through comment.
1268         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1269         comment.
1270         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1271         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1272         * jv-exp.y (yylex): Fix fall-through comment.
1273         * go-exp.y (lex_one_token): Fix fall-through comment.
1274         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1275         fall-through comment.
1276         * f-exp.y (yylex): Fix fall-through comment.
1277         * dwarf2read.c (process_die): Fix fall-through comments.
1278         * dbxread.c (process_one_symbol): Fix fall-through comment.
1279         * d-exp.y (lex_one_token): Fix fall-through comment.
1280         * cp-name-parser.y (yylex): Fix fall-through comment.
1281         * coffread.c (coff_symtab_read): Fix fall-through comment.
1282         * c-exp.y (lex_one_token): Fix fall-through comment.
1283         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1284         comment.
1285         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1286         comment.
1287
1288 2018-05-04  Tom Tromey  <tom@tromey.com>
1289
1290         PR python/22730:
1291         * NEWS: Mention gdb.execute change.
1292         * gdbcmd.h (execute_control_command): Don't declare.
1293         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1294         execute_control_commands, execute_control_commands_to_string.
1295         * cli/cli-script.h (execute_control_commands)
1296         (execute_control_commands_to_string): Declare.
1297         (execute_control_command): Add from_tty parameter.
1298         * cli/cli-script.c (execute_control_commands)
1299         (execute_control_commands_to_string): New functions.
1300         (execute_user_command): Use execute_control_commands.
1301         (execute_control_command_1): Add "from_tty" parameter.  Update.
1302         (execute_control_command): Likewise.
1303
1304 2018-05-04  Tom Tromey  <tom@tromey.com>
1305
1306         PR python/22731:
1307         * NEWS: Mention that breakpoint commands are writable.
1308         * python/py-breakpoint.c (bppy_set_commands): New function.
1309         (breakpoint_object_getset) <"commands">: Use it.
1310
1311 2018-05-04  Tom Tromey  <tom@tromey.com>
1312
1313         * tracepoint.c (actions_command): Update.
1314         * mi/mi-cmd-break.c (mi_command_line_array)
1315         (mi_command_line_array_cnt, mi_command_line_array_ptr)
1316         (mi_read_next_line): Remove.
1317         (mi_cmd_break_commands): Update.
1318         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
1319         function_view.
1320         * cli/cli-script.c (get_command_line): Update.
1321         (process_next_line): Use function_view.  Constify.
1322         (recurse_read_control_structure, read_command_lines)
1323         (read_command_lines_1): Change argument types to function_view.
1324         (do_define_command, document_command): Update.
1325         * breakpoint.h (check_tracepoint_command): Don't declare.
1326         * breakpoint.c (check_tracepoint_command): Remove.
1327         (commands_command_1, create_tracepoint_from_upload): Update.
1328
1329 2018-05-04  Tom Tromey  <tom@tromey.com>
1330
1331         PR gdb/11750:
1332         * cli/cli-script.h (enum command_control_type) <define_control>:
1333         New constant.
1334         * cli/cli-script.c (multi_line_command_p): Handle define_control.
1335         (build_command_line, execute_control_command_1)
1336         (process_next_line): Likewise.
1337         (do_define_command): New function, extracted from define_command.
1338         (define_command): Use it.
1339
1340 2018-05-04  Tom Tromey  <tom@tromey.com>
1341
1342         * tracepoint.c (actions_command): Update.
1343         * cli/cli-script.h (read_command_lines): Update.
1344         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
1345         (MAX_TMPBUF): Remove define.
1346         (define_command): Use string_printf.
1347         (document_command): Likewise.
1348         * breakpoint.c (commands_command_1): Update.
1349
1350 2018-05-04  Tom Tromey  <tom@tromey.com>
1351
1352         * top.c (execute_command): Update.
1353         * cli/cli-script.h (print_command_lines): Now varargs.
1354         * cli/cli-script.c (print_command_lines): Now varargs.
1355         (execute_control_command_1) <case while_control, case if_control>:
1356         Update.
1357
1358 2018-05-04  Tom Tromey  <tom@tromey.com>
1359
1360         * tracepoint.c (all_tracepoint_actions): Rename from
1361         all_tracepoint_actions_and_cleanup.  Change return type.
1362         (actions_command, encode_actions_1, encode_actions)
1363         (trace_dump_actions, tdump_command): Update.
1364         * remote.c (remote_download_command_source): Update.
1365         * python/python.c (gdbpy_eval_from_control_command)
1366         (python_command, python_interactive_command): Update.
1367         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1368         * guile/guile.c (guile_command)
1369         (gdbscm_eval_from_control_command, guile_command): Update.
1370         * compile/compile.c (compile_code_command)
1371         (compile_print_command, compile_to_object): Update.
1372         * cli/cli-script.h (struct command_lines_deleter): New.
1373         (counted_command_line): New typedef.
1374         (struct command_line): Add constructor, destructor.
1375         <body_list>: Remove.
1376         <body_list_0, body_list_1>: New members.
1377         (command_line_up): Remove typedef.
1378         (read_command_lines, read_command_lines_1, get_command_line):
1379         Update.
1380         (copy_command_lines): Don't declare.
1381         * cli/cli-script.c (build_command_line): Use "new".
1382         (get_command_line): Return counted_command_line.
1383         (print_command_lines, execute_user_command)
1384         (execute_control_command_1, while_command, if_command): Update.
1385         (realloc_body_list): Remove.
1386         (process_next_line, recurse_read_control_structure): Update.
1387         (read_command_lines, read_command_lines_1): Return counted_command_line.
1388         (free_command_lines): Use "delete".
1389         (copy_command_lines): Remove.
1390         (define_command, document_command, show_user_1): Update.
1391         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1392         a counted_command_line.
1393         * breakpoint.h (counted_command_line): Remove typedef.
1394         (breakpoint_set_commands): Update.
1395         * breakpoint.c (check_no_tracepoint_commands)
1396         (validate_commands_for_breakpoint): Update.
1397         (breakpoint_set_commands): Change commands to be a
1398         counted_command_line.
1399         (commands_command_1, update_dprintf_command_list)
1400         (create_tracepoint_from_upload): Update.
1401
1402 2018-05-04  Tom Tromey  <tom@tromey.com>
1403
1404         * cli/cli-decode.h (cmd_list_element): New constructor.
1405         (~cmd_list_element): New destructor.
1406         (struct cmd_list_element): Add initializers.
1407         * cli/cli-decode.c (do_add_cmd): Use "new".
1408         (delete_cmd): Use "delete".
1409
1410 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1411             Pedro Alves <palves@redhat.com>
1412
1413         PR breakpoints/19806 and support for PR external/20207.
1414         * NEWS: Mention Aarch64 watchpoint improvements.
1415         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1416         watchpoints and PR external/20207 watchpoints.
1417         * nat/aarch64-linux-hw-point.c
1418         (kernel_supports_any_contiguous_range): New.
1419         (aarch64_watchpoint_offset): New.
1420         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1421         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1422         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1423         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1424         next_addr_orig_p.  Support PR external/20207 watchpoints.
1425         (aarch64_downgrade_regs): New.
1426         (aarch64_dr_state_insert_one_point): New parameters offset and
1427         addr_orig.
1428         (aarch64_dr_state_remove_one_point): Likewise.
1429         (aarch64_handle_breakpoint): Update caller.
1430         (aarch64_handle_aligned_watchpoint): Likewise.
1431         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1432         aligned_offset.
1433         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1434         aarch64_downgrade_regs.
1435         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1436         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1437         (DR_CONTROL_MASK): ... this.
1438         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1439         (unsigned int aarch64_watchpoint_offset): New prototype.
1440         (aarch64_linux_set_debug_regs): Remove const from state.
1441         * utils.c (align_up, align_down): Move to ...
1442         * common/common-utils.c (align_up, align_down): ... here.
1443         * utils.h (align_up, align_down): Move to ...
1444         * common/common-utils.h (align_up, align_down): ... here.
1445
1446 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1447
1448         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1449         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1450         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1451         Re-implement to match the ABI as summarized in GCC's
1452         gcc/config/sparc/sparc.c.  All callers updated.
1453         (sparc32_store_arguments): Remove assertion.
1454
1455 2018-05-04  Tom Tromey  <tom@tromey.com>
1456
1457         * printcmd.c: Don't include tui.h.
1458         (decode_format): Use skip_spaces.
1459
1460 2018-05-04  Tom Tromey  <tom@tromey.com>
1461
1462         PR gdb/22619:
1463         * printcmd.c (last_count): New global.
1464         (x_command): Use saved count when repeating.
1465
1466 2018-05-04  Tom Tromey  <tom@tromey.com>
1467
1468         * nto-procfs.c (do_closedir_cleanup): Remove.
1469         (procfs_pidlist): Use gdb_dir_up.
1470         * procfs.c (do_closedir_cleanup): Remove.
1471         (proc_update_threads): Use gdb_dir_up.
1472         * common/filestuff.h (struct gdb_dir_deleter): New.
1473         (gdb_dir_up): New typedef.
1474
1475 2018-05-04  Tom Tromey  <tom@tromey.com>
1476
1477         * ada-lang.c (print_mention_exception): Use std::string.
1478
1479 2018-05-04  Tom Tromey  <tom@tromey.com>
1480
1481         * ada-lang.c (create_excep_cond_exprs): Update.
1482         (ada_exception_catchpoint_cond_string): Use std::string.
1483
1484 2018-05-04  Tom Tromey  <tom@tromey.com>
1485
1486         * ada-lang.c (xget_renaming_scope): Return std::string.
1487         (old_renaming_is_invisible): Update.
1488
1489 2018-05-04  Tom Tromey  <tom@tromey.com>
1490
1491         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1492         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1493
1494 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1495
1496         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1497
1498 2018-05-04  Tom Tromey  <tom@tromey.com>
1499
1500         * remote.c (remote_query_supported_append): Change type.
1501         (remote_check_symbols): Update.
1502
1503 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1504
1505         PR gdb/11420
1506         * configure.ac: Prepend libpython.
1507         * python/python-config.py: Likewise.
1508         * configure: Regenerate.
1509
1510 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1511
1512         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1513
1514 2018-05-03  Pedro Alves  <palves@redhat.com>
1515
1516         * s390-linux-nat.c
1517         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1518         override.  Write 'true' instead of '1'.
1519         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1520         declaration.
1521
1522 2018-05-02  Pedro Alves  <palves@redhat.com>
1523
1524         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1525         add_inf_child_target.
1526         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1527         add_inf_child_target.
1528         * aix-thread.c (aix_thread_target_info): New.
1529         (aix_thread_target) <shortname, longname, doc>: Delete.
1530         <info>: New.
1531         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1532         add_inf_child_target.
1533         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1534         add_inf_child_target.
1535         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1536         add_inf_child_target.
1537         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1538         add_inf_child_target.
1539         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1540         add_inf_child_target.
1541         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1542         add_inf_child_target.
1543         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1544         add_inf_child_target.
1545         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1546         add_inf_child_target.
1547         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1548         add_inf_child_target.
1549         * bfd-target.c (target_bfd_target_info): New.
1550         (target_bfd) <shortname, longname, doc>: Delete.
1551         <info>: New.
1552         * bsd-kvm.c (bsd_kvm_target_info): New.
1553         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1554         <info>: New.
1555         (bsd_kvm_target::open): Rename to ...
1556         (bsd_kvm_target_open): ... this.  Adjust.
1557         * bsd-uthread.c (bsd_uthread_target_info): New.
1558         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1559         <info>: New.
1560         * corefile.c (core_file_command): Adjust.
1561         * corelow.c (core_target_info): New.
1562         (core_target) <shortname, longname, doc>: Delete.
1563         <info>: New.
1564         (core_target::open): Rename to ...
1565         (core_target_open): ... this.  Adjust.
1566         * ctf.c (ctf_target_info): New.
1567         (ctf_target) <shortname, longname, doc>: Delete.
1568         <info>: New.
1569         (ctf_target::open): Rename to ...
1570         (ctf_target_open): ... this.
1571         (_initialize_ctf): Adjust.
1572         * exec.c (exec_target_info): New.
1573         (exec_target) <shortname, longname, doc>: Delete.
1574         <info>: New.
1575         (exec_target::open): Rename to ...
1576         (exec_target_open): ... this.
1577         * gdbcore.h (core_target_open): Declare.
1578         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1579         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1580         add_inf_child_target.
1581         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1582         add_inf_child_target.
1583         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1584         add_inf_child_target.
1585         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1586         add_inf_child_target.
1587         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1588         add_inf_child_target.
1589         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1590         add_inf_child_target.
1591         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1592         add_inf_child_target.
1593         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1594         add_inf_child_target.
1595         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1596         add_inf_child_target.
1597         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1598         add_inf_child_target.
1599         * inf-child.c (inf_child_target_info): New.
1600         (inf_child_target::info): New.
1601         (inf_child_open_target): Remove 'target' parameter.  Use
1602         get_native_target instead.
1603         (inf_child_target::open): Delete.
1604         (add_inf_child_target): New.
1605         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1606         Delete.
1607         <info>: New.
1608         (add_inf_child_target): Declare.
1609         (inf_child_open_target): Declare.
1610         * linux-thread-db.c (thread_db_target_info): New.
1611         (thread_db_target) <shortname, longname, doc>: Delete.
1612         <info>: New.
1613         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1614         add_inf_child_target.
1615         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1616         add_inf_child_target.
1617         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1618         add_inf_child_target.
1619         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1620         add_inf_child_target.
1621         * make-target-delegates (print_class): Adjust.
1622         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1623         add_inf_child_target.
1624         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1625         add_inf_child_target.
1626         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1627         add_inf_child_target.
1628         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1629         add_inf_child_target.
1630         * nto-procfs.c (nto_native_target_info): New.
1631         (nto_procfs_target_native) <shortname, longname, doc>:
1632         Delete.
1633         <info>: New.
1634         (nto_procfs_target_info): New.
1635         (nto_procfs_target_procfs) <shortname, longname, doc>:
1636         Delete.
1637         <info>: New.
1638         (init_procfs_targets): Adjust.
1639         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1640         add_inf_child_target.
1641         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1642         add_inf_child_target.
1643         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1644         add_inf_child_target.
1645         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1646         add_inf_child_target.
1647         * ravenscar-thread.c (ravenscar_target_info): New.
1648         (ravenscar_thread_target) <shortname, longname, doc>:
1649         Delete.
1650         <info>: New.
1651         * record-btrace.c (record_btrace_target_info):
1652         (record_btrace_target) <shortname, longname, doc>: Delete.
1653         <info>: New.
1654         (record_btrace_target::open): Rename to ...
1655         (record_btrace_target_open): ... this.  Adjust.
1656         * record-full.c (record_longname, record_doc): New.
1657         (record_full_base_target) <shortname, longname, doc>: Delete.
1658         <info>: New.
1659         (record_full_target_info): New.
1660         (record_full_target): <shortname>: Delete.
1661         <info>: New.
1662         (record_full_core_open_1, record_full_open_1): Update comments.
1663         (record_full_base_target::open): Rename to ...
1664         (record_full_open): ... this.
1665         (cmd_record_full_restore): Update.
1666         (_initialize_record_full): Update.
1667         * remote-sim.c (remote_sim_target_info): New.
1668         (gdbsim_target) <shortname, longname, doc>: Delete.
1669         <info>: New.
1670         (gdbsim_target::open): Rename to ...
1671         (gdbsim_target_open): ... this.
1672         (_initialize_remote_sim): Adjust.
1673         * remote.c (remote_doc): New.
1674         (remote_target_info): New.
1675         (remote_target) <shortname, longname, doc>: Delete.
1676         <info>: New.
1677         (extended_remote_target_info): New.
1678         (extended_remote_target) <shortname, longname, doc>: Delete.
1679         <info>: New.
1680         (remote_target::open_1): Make static.  Adjust.
1681         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1682         * s390-linux-nat.c (_initialize_s390_nat): Use
1683         add_inf_child_target.
1684         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1685         add_inf_child_target.
1686         * sol-thread.c (thread_db_target_info): New.
1687         (sol_thread_target) <shortname, longname, doc>: Delete.
1688         <info>: New.
1689         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1690         add_inf_child_target.
1691         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1692         add_inf_child_target.
1693         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1694         add_inf_child_target.
1695         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1696         add_inf_child_target.
1697         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1698         add_inf_child_target.
1699         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1700         add_inf_child_target.
1701         * spu-linux-nat.c (_initialize_spu_nat): Use
1702         add_inf_child_target.
1703         * spu-multiarch.c (spu_multiarch_target_info): New.
1704         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1705         <info>: New.
1706         * target-delegates.c: Regenerate.
1707         * target.c: Include <unordered_map>.
1708         (target_ops_p): Delete.
1709         (DEF_VEC_P(target_ops_p)): Delete.
1710         (target_factories): New.
1711         (test_target_info): New.
1712         (test_target_ops::info): New.
1713         (open_target): Adjust to use target_factories.
1714         (add_target_with_completer): Rename to ...
1715         (add_target): ... this.  Change prototype.  Register target_info
1716         and open callback in target_factories.  Register target_info in
1717         command context instead of target_ops.
1718         (add_target): Delete old implementation.
1719         (add_deprecated_target_alias): Change prototype.  Adjust.
1720         (the_native_target): New.
1721         (set_native_target, get_native_target): New.
1722         (find_default_run_target): Use the_native_target.
1723         (find_attach_target, find_run_target): Simplify.
1724         (target_ops::open): Delete.
1725         (dummy_target_info): New.
1726         (dummy_target::shortname, dummy_target::longname)
1727         (dummy_target::doc): Delete.
1728         (dummy_target::info): New.
1729         (debug_target::shortname, debug_target::longname)
1730         (debug_target::doc): Delete.
1731         (debug_target::info): New.
1732         * target.h (struct target_info): New.
1733         (target_ops::~target_ops): Add comment.
1734         (target_ops::info): New.
1735         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1736         longer virtual.  Implement in terms of target_info.
1737         (set_native_target, get_native_target): Declare.
1738         (target_open_ftype): New.
1739         (add_target, add_target_with_completer)
1740         (add_deprecated_target_alias): Change prototype.
1741         (test_target) <shortname, longname, doc>: Delete.
1742         <info>: New.
1743         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1744         add_inf_child_target.
1745         * tracefile-tfile.c (tfile_target_info): New.
1746         (tfile_target) <shortname, longname, doc>: Delete.
1747         <info>: New.
1748         (tfile_target::open): Rename to ...
1749         (tfile_target_open): ... this.
1750         (_initialize_tracefile_tfile): Adjust.
1751         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1752         add_inf_child_target.
1753         * windows-nat.c (_initialize_windows_nat): Use
1754         add_inf_child_target.
1755         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1756         add_inf_child_target.
1757
1758 2018-05-02  Pedro Alves  <palves@redhat.com>
1759
1760         * linux-nat.h (linux_nat_target) <low_new_thread,
1761         low_delete_thread, low_new_fork, low_forget_process,
1762         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1763         New virtual methods.
1764         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1765         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1766         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1767         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1768         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1769         Delete.
1770         * linux-fork.c (delete_fork): Adjust to call low method.
1771         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1772         (linux_nat_new_fork, linux_nat_forget_process_hook)
1773         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1774         (linux_nat_status_is_event):
1775         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1776         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1777         to call low method.
1778         (sigtrap_is_event): Rename to ...
1779         (linux_nat_target::low_status_is_event): ... this.
1780         (linux_nat_set_status_is_event): Delete.
1781         (save_stop_reason, linux_nat_wait_1)
1782         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1783         low methods.
1784         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1785         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1786         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1787         (linux_nat_set_prepare_to_resume): Delete.
1788         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1789         low virtual methods.
1790         * amd64-linux-nat.c: Likewise.
1791         * arm-linux-nat.c: Likewise.
1792         * i386-linux-nat.c: Likewise.
1793         * ia64-linux-nat.c: Likewise.
1794         * mips-linux-nat.c: Likewise.
1795         * ppc-linux-nat.c: Likewise.
1796         * s390-linux-nat.c: Likewise.
1797         * sparc64-linux-nat.c: Likewise.
1798         * x86-linux-nat.c: Likewise.
1799         * x86-linux-nat.h: Include "nat/x86-linux.h".
1800         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1801         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1802         Override methods.
1803
1804 2018-05-02  Pedro Alves  <palves@redhat.com>
1805
1806         * target.h (target_ops)
1807         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1808         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1809         stopped_by_watchpoint, have_continuable_watchpoint,
1810         stopped_data_address, watchpoint_addr_within_range,
1811         can_accel_watchpoint_condition, can_run, thread_alive,
1812         has_all_memory, has_memory, has_stack, has_registers,
1813         has_execution, can_async_p, is_async_p, supports_non_stop,
1814         always_non_stop_p, can_execute_reverse, supports_multi_process,
1815         supports_enable_disable_tracepoint,
1816         supports_disable_randomization, supports_string_tracing,
1817         supports_evaluation_of_breakpoint_conditions,
1818         can_run_breakpoint_commands, filesystem_is_local,
1819         can_download_tracepoint, get_trace_state_variable_value,
1820         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1821         record_is_replaying, record_will_replay,
1822         augmented_libraries_svr4_read>: Adjust to return bool.
1823         * aarch64-linux-nat.c: All implementations adjusted.
1824         * aix-thread.c: All implementations adjusted.
1825         * arm-linux-nat.c: All implementations adjusted.
1826         * breakpoint.c: All implementations adjusted.
1827         * bsd-kvm.c: All implementations adjusted.
1828         * bsd-uthread.c: All implementations adjusted.
1829         * corelow.c: All implementations adjusted.
1830         * ctf.c: All implementations adjusted.
1831         * darwin-nat.c: All implementations adjusted.
1832         * darwin-nat.h: All implementations adjusted.
1833         * exec.c: All implementations adjusted.
1834         * fbsd-nat.c: All implementations adjusted.
1835         * fbsd-nat.h: All implementations adjusted.
1836         * gnu-nat.c: All implementations adjusted.
1837         * gnu-nat.h: All implementations adjusted.
1838         * go32-nat.c: All implementations adjusted.
1839         * ia64-linux-nat.c: All implementations adjusted.
1840         * inf-child.c: All implementations adjusted.
1841         * inf-child.h: All implementations adjusted.
1842         * inf-ptrace.c: All implementations adjusted.
1843         * inf-ptrace.h: All implementations adjusted.
1844         * linux-nat.c: All implementations adjusted.
1845         * linux-nat.h: All implementations adjusted.
1846         * mips-linux-nat.c: All implementations adjusted.
1847         * nto-procfs.c: All implementations adjusted.
1848         * ppc-linux-nat.c: All implementations adjusted.
1849         * procfs.c: All implementations adjusted.
1850         * ravenscar-thread.c: All implementations adjusted.
1851         * record-btrace.c: All implementations adjusted.
1852         * record-full.c: All implementations adjusted.
1853         * remote-sim.c: All implementations adjusted.
1854         * remote.c: All implementations adjusted.
1855         * s390-linux-nat.c: All implementations adjusted.
1856         * sol-thread.c: All implementations adjusted.
1857         * spu-multiarch.c: All implementations adjusted.
1858         * target-delegates.c: All implementations adjusted.
1859         * target.c: All implementations adjusted.
1860         * target.h: All implementations adjusted.
1861         * tracefile-tfile.c: All implementations adjusted.
1862         * tracefile.c: All implementations adjusted.
1863         * tracefile.h: All implementations adjusted.
1864         * windows-nat.c: All implementations adjusted.
1865         * x86-linux-nat.h: All implementations adjusted.
1866         * x86-nat.h: All implementations adjusted.
1867
1868 2018-05-02  Pedro Alves  <palves@redhat.com>
1869
1870         * make-target-delegates (scan_target_h): Don't trim lines here.
1871         Replace sequences of tabs and/or whitespace with a single
1872         whitespace.
1873         (top level, parsing methods): Trim each line before processing it
1874         here.
1875
1876 2018-05-02  Pedro Alves  <palves@redhat.com>
1877             John Baldwin  <jhb@freebsd.org>
1878
1879         * target.h (enum strata) <debug_stratum>: New.
1880         (struct target_ops) <all delegation methods>: Replace by C++
1881         virtual methods, and drop "to_" prefix.  All references updated
1882         throughout.
1883         <to_shortname, to_longname, to_doc, to_data,
1884         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
1885         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
1886         virtual methods.  All references updated throughout.
1887         <can_attach, supports_terminal_ours, can_create_inferior,
1888         get_thread_control_capabilities, attach_no_wait>: New
1889         virtual methods.
1890         <insert_breakpoint, remove_breakpoint>: Now
1891         TARGET_DEFAULT_NORETURN methods.
1892         <info_proc>: Now returns bool.
1893         <to_magic>: Delete.
1894         (OPS_MAGIC): Delete.
1895         (current_target): Delete.  All references replaced by references
1896         to ...
1897         (target_stack): ... this.  New.
1898         (target_shortname, target_longname): Adjust.
1899         (target_can_run): Now a function declaration.
1900         (default_child_has_all_memory, default_child_has_memory)
1901         (default_child_has_stack, default_child_has_registers)
1902         (default_child_has_execution): Remove target_ops parameter.
1903         (complete_target_initialization): Delete.
1904         (memory_breakpoint_target): New template class.
1905         (test_target_ops): Refactor as a C++ class with virtual methods.
1906         * make-target-delegates (NAME_PART): Tighten.
1907         (POINTER_PART, CP_SYMBOL): New.
1908         (SIMPLE_RETURN_PART): Reimplement.
1909         (VEC_RETURN_PART): Expect less.
1910         (RETURN_PART, VIRTUAL_PART): New.
1911         (METHOD): Adjust to C++ virtual methods.
1912         (scan_target_h): Remove reference to C99.
1913         (dname): Output "target_ops::" prefix.
1914         (write_function_header): Adjust to output a C++ class method.
1915         (write_declaration): New.
1916         (write_delegator): Adjust to output a C++ class method.
1917         (tdname): Output "dummy_target::" prefix.
1918         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1919         method.
1920         (tdefault_names, debug_names): Delete.
1921         (return_types, tdefaults, styles, argtypes_array): New.
1922         (top level): All methods are delegators.
1923         (print_class): New.
1924         (top level): Print dummy_target and debug_target classes.
1925         * target-delegates.c: Regenerate.
1926         * target-debug.h (target_debug_print_enum_info_proc_what)
1927         (target_debug_print_thread_control_capabilities)
1928         (target_debug_print_thread_info_p): New.
1929         * target.c (dummy_target): Delete.
1930         (the_dummy_target, the_debug_target): New.
1931         (target_stack): Now extern.
1932         (set_targetdebug): Push/unpush debug target.
1933         (default_child_has_all_memory, default_child_has_memory)
1934         (default_child_has_stack, default_child_has_registers)
1935         (default_child_has_execution): Remove target_ops parameter.
1936         (complete_target_initialization): Delete.
1937         (add_target_with_completer): No longer call
1938         complete_target_initialization.
1939         (target_supports_terminal_ours): Use regular delegation.
1940         (update_current_target): Delete.
1941         (push_target): No longer check magic number.  Don't call
1942         update_current_target.
1943         (unpush_target): Don't call update_current_target.
1944         (target_is_pushed): No longer check magic number.
1945         (target_require_runnable): Skip for all stratums over
1946         process_stratum.
1947         (target_ops::info_proc): New.
1948         (target_info_proc): Use find_target_at and
1949         find_default_run_target.
1950         (target_supports_disable_randomization): Use regular delegation.
1951         (target_get_osdata): Use find_target_at.
1952         (target_ops::open, target_ops::close, target_ops::can_attach)
1953         (target_ops::attach, target_ops::can_create_inferior)
1954         (target_ops::create_inferior, target_ops::can_run)
1955         (target_can_run): New.
1956         (default_fileio_target): Use regular delegation.
1957         (target_ops::fileio_open, target_ops::fileio_pwrite)
1958         (target_ops::fileio_pread, target_ops::fileio_fstat)
1959         (target_ops::fileio_close, target_ops::fileio_unlink)
1960         (target_ops::fileio_readlink): New.
1961         (target_fileio_open_1, target_fileio_unlink)
1962         (target_fileio_readlink): Always call the target method.  Handle
1963         FILEIO_ENOSYS.
1964         (return_zero, return_zero_has_execution): Delete.
1965         (init_dummy_target): Delete.
1966         (dummy_target::dummy_target, dummy_target::shortname)
1967         (dummy_target::longname, dummy_target::doc)
1968         (debug_target::debug_target, debug_target::shortname)
1969         (debug_target::longname, debug_target::doc): New.
1970         (target_supports_delete_record): Use regular delegation.
1971         (setup_target_debug): Delete.
1972         (maintenance_print_target_stack): Skip debug_stratum.
1973         (initialize_targets): Instantiate the_dummy_target and
1974         the_debug_target.
1975         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1976         use target_stack.
1977         (target_auxv_search, fprint_target_auxv): Adjust.
1978         (info_auxv_command): Adjust to use target_stack.
1979         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1980         * exceptions.c (print_flush): Handle a NULL target_stack.
1981         * regcache.c (target_ops_no_register): Refactor as class with
1982         virtual methods.
1983
1984         * exec.c (exec_target): New class.
1985         (exec_ops): Now an exec_target.
1986         (exec_open, exec_close_1, exec_get_section_table)
1987         (exec_xfer_partial, exec_files_info, exec_has_memory)
1988         (exec_make_note_section): Refactor as exec_target methods.
1989         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1990         Delete.
1991         (exec_target::find_memory_regions): New.
1992         (_initialize_exec): Don't call init_exec_ops.
1993         * gdbcore.h (exec_file_clear): Delete.
1994
1995         * corefile.c (core_target): Delete.
1996         (core_file_command): Adjust.
1997         * corelow.c (core_target): New class.
1998         (the_core_target): New.
1999         (core_close): Remove target_ops parameter.
2000         (core_close_cleanup): Adjust.
2001         (core_target::close): New.
2002         (core_open, core_detach, get_core_registers, core_files_info)
2003         (core_xfer_partial, core_thread_alive, core_read_description)
2004         (core_pid_to_str, core_thread_name, core_has_memory)
2005         (core_has_stack, core_has_registers, core_info_proc): Rework as
2006         core_target methods.
2007         (ignore, core_remove_breakpoint, init_core_ops): Delete.
2008         (_initialize_corelow): Initialize the_core_target.
2009         * gdbcore.h (core_target): Delete.
2010         (the_core_target): New.
2011
2012         * ctf.c: (ctf_target): New class.
2013         (ctf_ops): Now a ctf_target.
2014         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
2015         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
2016         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
2017         methods.
2018         (init_ctf_ops): Delete.
2019         (_initialize_ctf): Don't call it.
2020         * tracefile-tfile.c (tfile_target): New class.
2021         (tfile_ops): Now a tfile_target.
2022         (tfile_open, tfile_close, tfile_files_info)
2023         (tfile_get_tracepoint_status, tfile_trace_find)
2024         (tfile_fetch_registers, tfile_xfer_partial)
2025         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
2026         Refactor as tfile_target methods.
2027         (tfile_xfer_partial_features): Remove target_ops parameter.
2028         (init_tfile_ops): Delete.
2029         (_initialize_tracefile_tfile): Don't call it.
2030         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
2031         (tracefile_has_stack, tracefile_has_registers)
2032         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
2033         tracefile_target methods.
2034         (init_tracefile_ops): Delete.
2035         (tracefile_target::tracefile_target): New.
2036         * tracefile.h: Include "target.h".
2037         (tracefile_target): New class.
2038         (init_tracefile_ops): Delete.
2039
2040         * spu-multiarch.c (spu_multiarch_target): New class.
2041         (spu_ops): Now a spu_multiarch_target.
2042         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
2043         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
2044         (spu_search_memory, spu_mourn_inferior): Refactor as
2045         spu_multiarch_target methods.
2046         (init_spu_ops): Delete.
2047         (_initialize_spu_multiarch): Remove references to init_spu_ops,
2048         complete_target_initialization.
2049
2050         * ravenscar-thread.c (ravenscar_thread_target): New class.
2051         (ravenscar_ops): Now a ravenscar_thread_target.
2052         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
2053         (ravenscar_thread_alive, ravenscar_pid_to_str)
2054         (ravenscar_fetch_registers, ravenscar_store_registers)
2055         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
2056         (ravenscar_stopped_by_hw_breakpoint)
2057         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
2058         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
2059         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
2060         methods.
2061         (init_ravenscar_thread_ops): Delete.
2062         (_initialize_ravenscar): Remove references to
2063         init_ravenscar_thread_ops and complete_target_initialization.
2064
2065         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
2066         (bsd_uthread_target): New class.
2067         (bsd_uthread_ops): Now a bsd_uthread_target.
2068         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
2069         (bsd_uthread_close, bsd_uthread_mourn_inferior)
2070         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
2071         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
2072         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
2073         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
2074         (bsd_uthread_target): Delete function.
2075         (_initialize_bsd_uthread): Remove reference to
2076         complete_target_initialization.
2077
2078         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
2079         (target_bfd): ... this new class.
2080         (target_bfd_xfer_partial, target_bfd_get_section_table)
2081         (target_bfd_close): Refactor as target_bfd methods.
2082         (target_bfd::~target_bfd): New.
2083         (target_bfd_reopen): Adjust.
2084         (target_bfd::close): New.
2085
2086         * record-btrace.c (record_btrace_target): New class.
2087         (record_btrace_ops): Now a record_btrace_target.
2088         (record_btrace_open, record_btrace_stop_recording)
2089         (record_btrace_disconnect, record_btrace_close)
2090         (record_btrace_async, record_btrace_info)
2091         (record_btrace_insn_history, record_btrace_insn_history_range)
2092         (record_btrace_insn_history_from, record_btrace_call_history)
2093         (record_btrace_call_history_range)
2094         (record_btrace_call_history_from, record_btrace_record_method)
2095         (record_btrace_is_replaying, record_btrace_will_replay)
2096         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
2097         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
2098         (record_btrace_store_registers, record_btrace_prepare_to_store)
2099         (record_btrace_to_get_unwinder)
2100         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
2101         (record_btrace_commit_resume, record_btrace_wait)
2102         (record_btrace_stop, record_btrace_can_execute_reverse)
2103         (record_btrace_stopped_by_sw_breakpoint)
2104         (record_btrace_supports_stopped_by_sw_breakpoint)
2105         (record_btrace_stopped_by_hw_breakpoint)
2106         (record_btrace_supports_stopped_by_hw_breakpoint)
2107         (record_btrace_update_thread_list, record_btrace_thread_alive)
2108         (record_btrace_goto_begin, record_btrace_goto_end)
2109         (record_btrace_goto, record_btrace_stop_replaying_all)
2110         (record_btrace_execution_direction)
2111         (record_btrace_prepare_to_generate_core)
2112         (record_btrace_done_generating_core): Refactor as
2113         record_btrace_target methods.
2114         (init_record_btrace_ops): Delete.
2115         (_initialize_record_btrace): Remove reference to
2116         init_record_btrace_ops.
2117         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
2118         the execution_direction global.
2119         (record_full_base_target, record_full_target)
2120         (record_full_core_target): New classes.
2121         (record_full_ops): Now a record_full_target.
2122         (record_full_core_ops): Now a record_full_core_target.
2123         (record_full_target::detach, record_full_target::disconnect)
2124         (record_full_core_target::disconnect)
2125         (record_full_target::mourn_inferior, record_full_target::kill):
2126         New.
2127         (record_full_open, record_full_close, record_full_async): Refactor
2128         as methods of the record_full_base_target class.
2129         (record_full_resume, record_full_commit_resume): Refactor
2130         as methods of the record_full_target class.
2131         (record_full_wait, record_full_stopped_by_watchpoint)
2132         (record_full_stopped_data_address)
2133         (record_full_stopped_by_sw_breakpoint)
2134         (record_full_supports_stopped_by_sw_breakpoint)
2135         (record_full_stopped_by_hw_breakpoint)
2136         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
2137         methods of the record_full_base_target class.
2138         (record_full_store_registers, record_full_xfer_partial)
2139         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2140         Refactor as methods of the record_full_target class.
2141         (record_full_can_execute_reverse, record_full_get_bookmark)
2142         (record_full_goto_bookmark, record_full_execution_direction)
2143         (record_full_record_method, record_full_info, record_full_delete)
2144         (record_full_is_replaying, record_full_will_replay)
2145         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2146         (record_full_stop_replaying): Refactor as methods of the
2147         record_full_base_target class.
2148         (record_full_core_resume, record_full_core_kill)
2149         (record_full_core_fetch_registers)
2150         (record_full_core_prepare_to_store)
2151         (record_full_core_store_registers, record_full_core_xfer_partial)
2152         (record_full_core_insert_breakpoint)
2153         (record_full_core_remove_breakpoint)
2154         (record_full_core_has_execution): Refactor
2155         as methods of the record_full_core_target class.
2156         (record_full_base_target::supports_delete_record): New.
2157         (init_record_full_ops): Delete.
2158         (init_record_full_core_ops): Delete.
2159         (record_full_save): Refactor as method of the
2160         record_full_base_target class.
2161         (_initialize_record_full): Remove references to
2162         init_record_full_ops and init_record_full_core_ops.
2163
2164         * remote.c (remote_target, extended_remote_target): New classes.
2165         (remote_ops): Now a remote_target.
2166         (extended_remote_ops): Now an extended_remote_target.
2167         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2168         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2169         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2170         (remote_pass_signals, remote_set_syscall_catchpoint)
2171         (remote_program_signals, )
2172         (remote_thread_always_alive): Remove target_ops parameter.
2173         (remote_thread_alive, remote_thread_name)
2174         (remote_update_thread_list, remote_threads_extra_info)
2175         (remote_static_tracepoint_marker_at)
2176         (remote_static_tracepoint_markers_by_strid)
2177         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2178         (remote_open): Refactor as methods of remote_target.
2179         (extended_remote_open, extended_remote_detach)
2180         (extended_remote_attach, extended_remote_post_attach):
2181         (extended_remote_supports_disable_randomization)
2182         (extended_remote_create_inferior): : Refactor as method of
2183         extended_remote_target.
2184         (remote_set_permissions, remote_open_1, remote_detach)
2185         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2186         (remote_resume, remote_commit_resume, remote_stop)
2187         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2188         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2189         (remote_prepare_to_store, remote_store_registers)
2190         (remote_flash_erase, remote_flash_done, remote_files_info)
2191         (remote_kill, remote_mourn, remote_insert_breakpoint)
2192         (remote_remove_breakpoint, remote_insert_watchpoint)
2193         (remote_watchpoint_addr_within_range)
2194         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2195         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2196         (remote_supports_stopped_by_sw_breakpoint)
2197         (remote_stopped_by_hw_breakpoint)
2198         (remote_supports_stopped_by_hw_breakpoint)
2199         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2200         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2201         (remote_verify_memory): Refactor as methods of remote_target.
2202         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2203         parameter.
2204         (remote_xfer_partial, remote_get_memory_xfer_limit)
2205         (remote_search_memory, remote_rcmd, remote_memory_map)
2206         (remote_pid_to_str, remote_get_thread_local_address)
2207         (remote_get_tib_address, remote_read_description): Refactor as
2208         methods of remote_target.
2209         (remote_target::fileio_open, remote_target::fileio_pwrite)
2210         (remote_target::fileio_pread, remote_target::fileio_close): New.
2211         (remote_hostio_readlink, remote_hostio_fstat)
2212         (remote_filesystem_is_local, remote_can_execute_reverse)
2213         (remote_supports_non_stop, remote_supports_disable_randomization)
2214         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2215         (remote_supports_enable_disable_tracepoint)
2216         (remote_supports_string_tracing)
2217         (remote_can_run_breakpoint_commands, remote_trace_init)
2218         (remote_download_tracepoint, remote_can_download_tracepoint)
2219         (remote_download_trace_state_variable, remote_enable_tracepoint)
2220         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2221         (remote_trace_start, remote_get_trace_status)
2222         (remote_get_tracepoint_status, remote_trace_stop)
2223         (remote_trace_find, remote_get_trace_state_variable_value)
2224         (remote_save_trace_data, remote_get_raw_trace_data)
2225         (remote_set_disconnected_tracing, remote_core_of_thread)
2226         (remote_set_circular_trace_buffer, remote_traceframe_info)
2227         (remote_get_min_fast_tracepoint_insn_len)
2228         (remote_set_trace_buffer_size, remote_set_trace_notes)
2229         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2230         (remote_disable_btrace, remote_teardown_btrace)
2231         (remote_read_btrace, remote_btrace_conf)
2232         (remote_augmented_libraries_svr4_read, remote_load)
2233         (remote_pid_to_exec_file, remote_can_do_single_step)
2234         (remote_execution_direction, remote_thread_handle_to_thread_info):
2235         Refactor as methods of remote_target.
2236         (init_remote_ops, init_extended_remote_ops): Delete.
2237         (remote_can_async_p, remote_is_async_p, remote_async)
2238         (remote_thread_events, remote_upload_tracepoints)
2239         (remote_upload_trace_state_variables): Refactor as methods of
2240         remote_target.
2241         (_initialize_remote): Remove references to init_remote_ops and
2242         init_extended_remote_ops.
2243
2244         * remote-sim.c (gdbsim_target): New class.
2245         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2246         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2247         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2248         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2249         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2250         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2251         Refactor as methods of gdbsim_target.
2252         (gdbsim_ops): Now a gdbsim_target.
2253         (init_gdbsim_ops): Delete.
2254         (gdbsim_cntrl_c): Adjust.
2255         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2256
2257         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2258         (the_amd64_linux_nat_target): New.
2259         (amd64_linux_fetch_inferior_registers)
2260         (amd64_linux_store_inferior_registers): Refactor as methods of
2261         amd64_linux_nat_target.
2262         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2263         * i386-linux-nat.c: Don't include "linux-nat.h".
2264         (i386_linux_nat_target): New class.
2265         (the_i386_linux_nat_target): New.
2266         (i386_linux_fetch_inferior_registers)
2267         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2268         as methods of i386_linux_nat_target.
2269         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2270         * inf-child.c (inf_child_ops): Delete.
2271         (inf_child_fetch_inferior_registers)
2272         (inf_child_store_inferior_registers): Delete.
2273         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2274         methods of inf_child_target.
2275         (inf_child_target::supports_terminal_ours)
2276         (inf_child_target::terminal_init)
2277         (inf_child_target::terminal_inferior)
2278         (inf_child_target::terminal_ours_for_output)
2279         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2280         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2281         New.
2282         (inf_child_open, inf_child_disconnect, inf_child_close)
2283         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2284         (inf_child_post_startup_inferior, inf_child_can_run)
2285         (inf_child_pid_to_exec_file): Refactor as methods of
2286         inf_child_target.
2287         (inf_child_follow_fork): Delete.
2288         (inf_child_target::can_create_inferior)
2289         (inf_child_target::can_attach): New.
2290         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2291         (inf_child_target::has_stack, inf_child_target::has_registers)
2292         (inf_child_target::has_execution): New.
2293         (inf_child_fileio_open, inf_child_fileio_pwrite)
2294         (inf_child_fileio_pread, inf_child_fileio_fstat)
2295         (inf_child_fileio_close, inf_child_fileio_unlink)
2296         (inf_child_fileio_readlink, inf_child_use_agent)
2297         (inf_child_can_use_agent): Refactor as methods of
2298         inf_child_target.
2299         (return_zero, inf_child_target): Delete.
2300         (inf_child_target::inf_child_target): New.
2301         * inf-child.h: Include "target.h".
2302         (inf_child_target): Delete function prototype.
2303         (inf_child_target): New class.
2304         (inf_child_open_target, inf_child_mourn_inferior)
2305         (inf_child_maybe_unpush_target): Delete.
2306         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2307         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2308         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2309         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2310         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2311         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2312         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2313         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2314         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2315         methods of inf_ptrace_target.
2316         (inf_ptrace_target): Delete function.
2317         * inf-ptrace.h: Include "inf-child.h".
2318         (inf_ptrace_target): Delete function declaration.
2319         (inf_ptrace_target): New class.
2320         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
2321         * linux-nat.c (linux_target): New.
2322         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
2323         (linux_nat_target::~linux_nat_target): New.
2324         (linux_child_post_attach, linux_child_post_startup_inferior)
2325         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
2326         (linux_child_remove_fork_catchpoint)
2327         (linux_child_insert_vfork_catchpoint)
2328         (linux_child_remove_vfork_catchpoint)
2329         (linux_child_insert_exec_catchpoint)
2330         (linux_child_remove_exec_catchpoint)
2331         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
2332         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
2333         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
2334         (linux_nat_stopped_data_address)
2335         (linux_nat_stopped_by_sw_breakpoint)
2336         (linux_nat_supports_stopped_by_sw_breakpoint)
2337         (linux_nat_stopped_by_hw_breakpoint)
2338         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
2339         (linux_nat_kill, linux_nat_mourn_inferior)
2340         (linux_nat_xfer_partial, linux_nat_thread_alive)
2341         (linux_nat_update_thread_list, linux_nat_pid_to_str)
2342         (linux_nat_thread_name, linux_child_pid_to_exec_file)
2343         (linux_child_static_tracepoint_markers_by_strid)
2344         (linux_nat_is_async_p, linux_nat_can_async_p)
2345         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
2346         (linux_nat_supports_multi_process)
2347         (linux_nat_supports_disable_randomization, linux_nat_async)
2348         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
2349         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
2350         (linux_nat_fileio_open, linux_nat_fileio_readlink)
2351         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
2352         methods of linux_nat_target.
2353         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
2354         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
2355         parameter.
2356         (check_stopped_by_watchpoint): Adjust.
2357         (linux_xfer_partial): Delete.
2358         (linux_target_install_ops, linux_target, linux_nat_add_target):
2359         Delete.
2360         (linux_nat_target::linux_nat_target): New.
2361         * linux-nat.h: Include "inf-ptrace.h".
2362         (linux_nat_target): New.
2363         (linux_target, linux_target_install_ops, linux_nat_add_target):
2364         Delete function declarations.
2365         (linux_target): Declare global.
2366         * linux-thread-db.c (thread_db_target): New.
2367         (thread_db_target::thread_db_target): New.
2368         (thread_db_ops): Delete.
2369         (the_thread_db_target): New.
2370         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2371         (thread_db_update_thread_list, thread_db_pid_to_str)
2372         (thread_db_extra_thread_info)
2373         (thread_db_thread_handle_to_thread_info)
2374         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2375         (thread_db_resume): Refactor as methods of thread_db_target.
2376         (init_thread_db_ops): Delete.
2377         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2378         * x86-linux-nat.c: Don't include "linux-nat.h".
2379         (super_post_startup_inferior): Delete.
2380         (x86_linux_nat_target::~x86_linux_nat_target): New.
2381         (x86_linux_child_post_startup_inferior)
2382         (x86_linux_read_description, x86_linux_enable_btrace)
2383         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2384         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2385         methods of x86_linux_nat_target.
2386         (x86_linux_create_target): Delete.  Bits folded ...
2387         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2388         pointer.
2389         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2390         (x86_linux_nat_target): New class.
2391         (x86_linux_create_target): Delete.
2392         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2393         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2394         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2395         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2396         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2397         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2398         make extern.
2399         (x86_use_watchpoints): Delete.
2400         * x86-nat.h: Include "breakpoint.h" and "target.h".
2401         (x86_use_watchpoints): Delete.
2402         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2403         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2404         (x86_insert_watchpoint, x86_remove_watchpoint)
2405         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2406         (x86_stopped_by_hw_breakpoint): New declarations.
2407         (x86_nat_target): New template class.
2408
2409         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2410         (the_ppc_linux_nat_target): New.
2411         (ppc_linux_fetch_inferior_registers)
2412         (ppc_linux_can_use_hw_breakpoint)
2413         (ppc_linux_region_ok_for_hw_watchpoint)
2414         (ppc_linux_ranged_break_num_registers)
2415         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2416         (ppc_linux_insert_mask_watchpoint)
2417         (ppc_linux_remove_mask_watchpoint)
2418         (ppc_linux_can_accel_watchpoint_condition)
2419         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2420         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2421         (ppc_linux_watchpoint_addr_within_range)
2422         (ppc_linux_masked_watch_num_registers)
2423         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2424         (ppc_linux_read_description): Refactor as methods of
2425         ppc_linux_nat_target.
2426         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2427
2428         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2429         (procfs_target): New class.
2430         (the_procfs_target): New.
2431         (procfs_target): Delete function.
2432         (procfs_auxv_parse, procfs_attach, procfs_detach)
2433         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2434         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2435         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2436         (procfs_create_inferior, procfs_update_thread_list)
2437         (procfs_thread_alive, procfs_pid_to_str)
2438         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2439         (procfs_stopped_data_address, procfs_insert_watchpoint)
2440         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2441         (proc_find_memory_regions, procfs_info_proc)
2442         (procfs_make_note_section): Refactor as methods of procfs_target.
2443         (_initialize_procfs): Adjust.
2444         * sol-thread.c (sol_thread_target): New class.
2445         (sol_thread_ops): Now a sol_thread_target.
2446         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2447         (sol_thread_fetch_registers, sol_thread_store_registers)
2448         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2449         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2450         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2451         (init_sol_thread_ops): Delete.
2452         (_initialize_sol_thread): Adjust.  Remove references to
2453         init_sol_thread_ops and complete_target_initialization.
2454
2455         * windows-nat.c (windows_nat_target): New class.
2456         (windows_fetch_inferior_registers)
2457         (windows_store_inferior_registers, windows_resume, windows_wait)
2458         (windows_attach, windows_detach, windows_pid_to_exec_file)
2459         (windows_files_info, windows_create_inferior)
2460         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2461         (windows_close, windows_pid_to_str, windows_xfer_partial)
2462         (windows_get_tib_address, windows_get_ada_task_ptid)
2463         (windows_thread_name, windows_thread_alive): Refactor as
2464         windows_nat_target methods.
2465         (do_initial_windows_stuff): Adjust.
2466         (windows_target): Delete function.
2467         (_initialize_windows_nat): Adjust.
2468
2469         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2470         (darwin_mourn_inferior, darwin_kill_inferior)
2471         (darwin_create_inferior, darwin_attach, darwin_detach)
2472         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2473         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2474         (darwin_supports_multi_process): Refactor as darwin_nat_target
2475         methods.
2476         (darwin_resume_to, darwin_files_info): Delete.
2477         (_initialize_darwin_inferior): Rename to ...
2478         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2479         * darwin-nat.h: Include "inf-child.h".
2480         (darwin_nat_target): New class.
2481         (darwin_complete_target): Delete.
2482         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2483         (darwin_target): New.
2484         (i386_darwin_fetch_inferior_registers)
2485         (i386_darwin_store_inferior_registers): Refactor as methods of
2486         darwin_nat_target.
2487         (darwin_complete_target): Delete, with ...
2488         (_initialize_i386_darwin_nat): ... bits factored out here.
2489
2490         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2491         (the_alpha_linux_nat_target): New.
2492         (alpha_linux_register_u_offset): Refactor as
2493         alpha_linux_nat_target method.
2494         (_initialize_alpha_linux_nat): Adjust.
2495         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2496         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2497         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2498         methods of linux_nat_trad_target.
2499         (linux_trad_target): Delete.
2500         * linux-nat-trad.h (linux_trad_target): Delete function.
2501         (linux_nat_trad_target): New class.
2502         * mips-linux-nat.c (mips_linux_nat_target): New class.
2503         (super_fetch_registers, super_store_registers, super_close):
2504         Delete.
2505         (the_mips_linux_nat_target): New.
2506         (mips64_linux_regsets_fetch_registers)
2507         (mips64_linux_regsets_store_registers)
2508         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2509         (mips_linux_register_u_offset, mips_linux_read_description)
2510         (mips_linux_can_use_hw_breakpoint)
2511         (mips_linux_stopped_by_watchpoint)
2512         (mips_linux_stopped_data_address)
2513         (mips_linux_region_ok_for_hw_watchpoint)
2514         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2515         (mips_linux_close): Refactor as methods of mips_linux_nat.
2516         (_initialize_mips_linux_nat): Adjust to C++ification.
2517
2518         * aix-thread.c (aix_thread_target): New class.
2519         (aix_thread_ops): Now an aix_thread_target.
2520         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2521         (aix_thread_fetch_registers, aix_thread_store_registers)
2522         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2523         (aix_thread_thread_alive, aix_thread_pid_to_str)
2524         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2525         Refactor as methods of aix_thread_target.
2526         (init_aix_thread_ops): Delete.
2527         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2528         and complete_target_initialization.
2529         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2530         (rs6000_nat_target): New class.
2531         (the_rs6000_nat_target): New.
2532         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2533         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2534         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2535         (super_create_inferior): Delete.
2536         (_initialize_rs6000_nat): Adjust to C++ification.
2537
2538         * arm-linux-nat.c (arm_linux_nat_target): New class.
2539         (the_arm_linux_nat_target): New.
2540         (arm_linux_fetch_inferior_registers)
2541         (arm_linux_store_inferior_registers, arm_linux_read_description)
2542         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2543         (arm_linux_remove_hw_breakpoint)
2544         (arm_linux_region_ok_for_hw_watchpoint)
2545         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2546         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2547         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2548         arm_linux_nat_target.
2549         (_initialize_arm_linux_nat): Adjust to C++ification.
2550
2551         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2552         (the_aarch64_linux_nat_target): New.
2553         (aarch64_linux_fetch_inferior_registers)
2554         (aarch64_linux_store_inferior_registers)
2555         (aarch64_linux_child_post_startup_inferior)
2556         (aarch64_linux_read_description)
2557         (aarch64_linux_can_use_hw_breakpoint)
2558         (aarch64_linux_insert_hw_breakpoint)
2559         (aarch64_linux_remove_hw_breakpoint)
2560         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2561         (aarch64_linux_region_ok_for_hw_watchpoint)
2562         (aarch64_linux_stopped_data_address)
2563         (aarch64_linux_stopped_by_watchpoint)
2564         (aarch64_linux_watchpoint_addr_within_range)
2565         (aarch64_linux_can_do_single_step): Refactor as methods of
2566         aarch64_linux_nat_target.
2567         (super_post_startup_inferior): Delete.
2568         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2569
2570         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2571         (the_hppa_linux_nat_target): New.
2572         (hppa_linux_fetch_inferior_registers)
2573         (hppa_linux_store_inferior_registers): Refactor as methods of
2574         hppa_linux_nat_target.
2575         (_initialize_hppa_linux_nat): Adjust to C++ification.
2576
2577         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2578         (the_ia64_linux_nat_target): New.
2579         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2580         (ia64_linux_stopped_data_address)
2581         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2582         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2583         ia64_linux_nat_target methods.
2584         (super_xfer_partial): Delete.
2585         (_initialize_ia64_linux_nat): Adjust to C++ification.
2586
2587         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2588         (the_m32r_linux_nat_target): New.
2589         (m32r_linux_fetch_inferior_registers)
2590         (m32r_linux_store_inferior_registers): Refactor as
2591         m32r_linux_nat_target methods.
2592         (_initialize_m32r_linux_nat): Adjust to C++ification.
2593
2594         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2595         (the_m68k_linux_nat_target): New.
2596         (m68k_linux_fetch_inferior_registers)
2597         (m68k_linux_store_inferior_registers): Refactor as
2598         m68k_linux_nat_target methods.
2599         (_initialize_m68k_linux_nat): Adjust to C++ification.
2600
2601         * s390-linux-nat.c (s390_linux_nat_target): New class.
2602         (the_s390_linux_nat_target): New.
2603         (s390_linux_fetch_inferior_registers)
2604         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2605         (s390_insert_watchpoint, s390_remove_watchpoint)
2606         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2607         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2608         (s390_auxv_parse, s390_read_description): Refactor as methods of
2609         s390_linux_nat_target.
2610         (_initialize_s390_nat): Adjust to C++ification.
2611
2612         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2613         (the_sparc_linux_nat_target): New.
2614         (_initialize_sparc_linux_nat): Adjust to C++ification.
2615         * sparc-nat.c (sparc_fetch_inferior_registers)
2616         (sparc_store_inferior_registers): Remove target_ops parameter.
2617         * sparc-nat.h (sparc_fetch_inferior_registers)
2618         (sparc_store_inferior_registers): Remove target_ops parameter.
2619         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2620         (the_sparc64_linux_nat_target): New.
2621         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2622
2623         * spu-linux-nat.c (spu_linux_nat_target): New class.
2624         (the_spu_linux_nat_target): New.
2625         (spu_child_post_startup_inferior, spu_child_post_attach)
2626         (spu_child_wait, spu_fetch_inferior_registers)
2627         (spu_store_inferior_registers, spu_xfer_partial)
2628         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2629         methods.
2630         (_initialize_spu_nat): Adjust to C++ification.
2631
2632         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2633         (the_tilegx_linux_nat_target): New.
2634         (fetch_inferior_registers, store_inferior_registers):
2635         Refactor as methods.
2636         (_initialize_tile_linux_nat): Adjust to C++ification.
2637
2638         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2639         (the_xtensa_linux_nat_target): New.
2640         (xtensa_linux_fetch_inferior_registers)
2641         (xtensa_linux_store_inferior_registers): Refactor as
2642         xtensa_linux_nat_target methods.
2643         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2644
2645         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2646         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2647         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2648         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2649         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2650         (fbsd_stopped_by_sw_breakpoint)
2651         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2652         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2653         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2654         (fbsd_post_startup_inferior, fbsd_post_attach)
2655         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2656         (fbsd_set_syscall_catchpoint)
2657         (super_xfer_partial, super_resume, super_wait)
2658         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2659         (fbsd_handle_debug_trap): Remove target_ops parameter.
2660         (fbsd_nat_add_target): Delete.
2661         * fbsd-nat.h: Include "inf-ptrace.h".
2662         (fbsd_nat_add_target): Delete.
2663         (USE_SIGTRAP_SIGINFO): Define.
2664         (fbsd_nat_target): New class.
2665
2666         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2667         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2668         (amd64bsd_target): Delete.
2669         * amd64-bsd-nat.h: New file.
2670         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2671         "x86-bsd-nat.h".
2672         (amd64_fbsd_nat_target): New class.
2673         (the_amd64_fbsd_nat_target): New.
2674         (amd64fbsd_read_description): Refactor as method of
2675         amd64_fbsd_nat_target.
2676         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2677         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2678         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2679         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2680         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2681         (i386bsd_target): Delete.
2682         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2683         (i386bsd_fetch_inferior_registers)
2684         (i386bsd_store_inferior_registers): Declare.
2685         (i386_bsd_nat_target): New class.
2686         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2687         (the_i386_fbsd_nat_target): New.
2688         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2689         i386_fbsd_nat_target methods.
2690         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2691         (_initialize_i386fbsd_nat): Adjust to C++ification.
2692         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2693         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2694         (_initialize_x86_bsd_nat): Adjust to C++ification.
2695         * x86-bsd-nat.h: Include "x86-nat.h".
2696         (x86bsd_target): Delete declaration.
2697         (x86bsd_nat_target): New class.
2698
2699         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2700         (the_aarch64_fbsd_nat_target): New.
2701         (aarch64_fbsd_fetch_inferior_registers)
2702         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2703         aarch64_fbsd_nat_target.
2704         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2705         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2706         (the_alpha_bsd_nat_target): New.
2707         (alphabsd_fetch_inferior_registers)
2708         (alphabsd_store_inferior_registers): Refactor as
2709         alpha_bsd_nat_target methods.
2710         (_initialize_alphabsd_nat): Refactor as methods of
2711         alpha_bsd_nat_target.
2712         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2713         (the_amd64_nbsd_nat_target): New.
2714         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2715         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2716         (the_amd64_obsd_nat_target): New.
2717         (_initialize_amd64obsd_nat): Adjust to C++ification.
2718         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2719         (the_arm_fbsd_nat_target): New.
2720         (arm_fbsd_fetch_inferior_registers)
2721         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2722         (_initialize_arm_fbsd_nat): Refactor as methods of
2723         arm_fbsd_nat_target.
2724         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2725         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2726         (the_arm_netbsd_nat_target): New.
2727         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2728         arm_netbsd_nat_target.
2729         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2730         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2731         (the_hppa_nbsd_nat_target): New.
2732         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2733         hppa_nbsd_nat_target methods.
2734         (_initialize_hppanbsd_nat): Adjust to C++ification.
2735         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2736         (the_hppa_obsd_nat_target): New.
2737         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2738         methods of hppa_obsd_nat_target.
2739         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2740         add_target.
2741         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2742         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2743         add_target.
2744         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2745         (_initialize_i386obsd_nat): Use add_target.
2746         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2747         (the_m68k_bsd_nat_target): New.
2748         (m68kbsd_fetch_inferior_registers)
2749         (m68kbsd_store_inferior_registers): Refactor as methods of
2750         m68k_bsd_nat_target.
2751         (_initialize_m68kbsd_nat): Adjust to C++ification.
2752         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2753         (the_mips_fbsd_nat_target): New.
2754         (mips_fbsd_fetch_inferior_registers)
2755         (mips_fbsd_store_inferior_registers): Refactor as methods of
2756         mips_fbsd_nat_target.
2757         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2758         add_target.
2759         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2760         (the_mips_nbsd_nat_target): New.
2761         (mipsnbsd_fetch_inferior_registers)
2762         (mipsnbsd_store_inferior_registers): Refactor as methods of
2763         mips_nbsd_nat_target.
2764         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2765         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2766         (the_mips64_obsd_nat_target): New.
2767         (mips64obsd_fetch_inferior_registers)
2768         (mips64obsd_store_inferior_registers): Refactor as methods of
2769         mips64_obsd_nat_target.
2770         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2771         add_target.
2772         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2773         nbsd_nat_target.
2774         * nbsd-nat.h: Include "inf-ptrace.h".
2775         (nbsd_nat_target): New class.
2776         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2777         (obsd_wait): Refactor as methods of obsd_nat_target.
2778         (obsd_add_target): Delete.
2779         * obsd-nat.h: Include "inf-ptrace.h".
2780         (obsd_nat_target): New class.
2781         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2782         (the_ppc_fbsd_nat_target): New.
2783         (ppcfbsd_fetch_inferior_registers)
2784         (ppcfbsd_store_inferior_registers): Refactor as methods of
2785         ppc_fbsd_nat_target.
2786         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2787         add_target.
2788         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2789         (the_ppc_nbsd_nat_target): New.
2790         (ppcnbsd_fetch_inferior_registers)
2791         (ppcnbsd_store_inferior_registers): Refactor as methods of
2792         ppc_nbsd_nat_target.
2793         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2794         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2795         (the_ppc_obsd_nat_target): New.
2796         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2797         methods of ppc_obsd_nat_target.
2798         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2799         add_target.
2800         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2801         (the_sh_nbsd_nat_target): New.
2802         (shnbsd_fetch_inferior_registers)
2803         (shnbsd_store_inferior_registers): Refactor as methods of
2804         sh_nbsd_nat_target.
2805         (_initialize_shnbsd_nat): Adjust to C++ification.
2806         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2807         (inf_ptrace_xfer_partial): Delete.
2808         (sparc_xfer_partial, sparc_target): Delete.
2809         * sparc-nat.h (sparc_fetch_inferior_registers)
2810         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2811         (sparc_target): Delete function declaration.
2812         (sparc_target): New template class.
2813         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2814         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2815         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2816         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2817         add_target.
2818         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2819         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2820         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2821         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2822         add_target.
2823         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2824         (the_vax_bsd_nat_target): New.
2825         (vaxbsd_fetch_inferior_registers)
2826         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2827         methods.
2828         (_initialize_vaxbsd_nat): Adjust to C++ification.
2829
2830         * bsd-kvm.c (bsd_kvm_target): New class.
2831         (bsd_kvm_ops): Now a bsd_kvm_target.
2832         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2833         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2834         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2835         bsd_kvm_target.
2836         (bsd_kvm_return_one): Delete.
2837         (bsd_kvm_add_target): Adjust to C++ification.
2838
2839         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2840         (nto_procfs_target_procfs): New classes.
2841         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2842         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2843         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2844         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2845         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2846         (procfs_remove_hw_breakpoint, procfs_resume)
2847         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2848         (procfs_kill_inferior, procfs_store_registers)
2849         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2850         as methods of nto_procfs_target.
2851         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2852         (nto_native_ops): Delete.
2853         (procfs_open, procfs_native_open): Delete.
2854         (nto_native_ops): Now an nto_procfs_target_native.
2855         (init_procfs_targets): Adjust to C++ification.
2856         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2857         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2858         Refactor as methods of nto_procfs_target.
2859
2860         * go32-nat.c (go32_nat_target): New class.
2861         (the_go32_nat_target): New.
2862         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2863         (go32_store_registers, go32_xfer_partial, go32_files_info)
2864         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2865         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2866         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2867         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2868         (go32_target): Delete.
2869         (_initialize_go32_nat): Adjust to C++ification.
2870
2871         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2872         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2873         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2874         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
2875         gnu_nat_target.
2876         (gnu_target): Delete.
2877         * gnu-nat.h (gnu_target): Delete.
2878         (gnu_nat_target): New class.
2879         * i386-gnu-nat.c (gnu_base_target): New.
2880         (i386_gnu_nat_target): New class.
2881         (the_i386_gnu_nat_target): New.
2882         (_initialize_i386gnu_nat): Adjust to C++ification.
2883
2884 2018-05-02  Pedro Alves  <palves@redhat.com>
2885
2886         * bfd-target.c (target_bfd_xclose): Rename to ...
2887         (target_bfd_close): ... this.
2888         (target_bfd_reopen): Adjust.
2889         * target.c (target_close): Remove references to to_xclose.
2890         * target.h (target_ops::to_xclose): Delete.
2891         (target_ops::to_close): Update comments.
2892
2893 2018-05-02  Pedro Alves  <palves@redhat.com>
2894
2895         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
2896         "linux-nat.h".
2897         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
2898         * inf-ptrace.c (inf_ptrace_register_u_offset)
2899         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2900         (inf_ptrace_store_register, inf_ptrace_store_registers)
2901         (inf_ptrace_trad_target): Move to ...
2902         * linux-nat-trad.c: ... this new file.
2903         * linux-nat-trad.h: New file.
2904         * linux-nat.c (linux_target_install_ops): Make extern.
2905         (linux_trad_target): Delete.
2906         * linux-nat.h (linux_trad_target): Delete declaration.
2907         (linux_target_install_ops): Declare.
2908         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
2909         "linux-nat.h".
2910
2911 2018-05-02  Pedro Alves  <palves@redhat.com>
2912
2913         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2914         procfs_target/add_target here.
2915         * procfs.c (procfs_target): Make static.
2916         (_initialize_procfs): Call add_target here.
2917         * procfs.h (struct target_ops): Remove forward declaration.
2918         (procfs_target): Remove declaration.
2919         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2920
2921 2018-05-02  Pedro Alves  <palves@redhat.com>
2922
2923         * procfs.c (procfs_stopped_by_watchpoint)
2924         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2925         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2926         Forward declare.
2927         (procfs_use_watchpoints): Delete, move contents...
2928         (procfs_target): ... here.
2929         * procfs.h (procfs_use_watchpoints): Delete declaration.
2930         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2931         procfs_use_watchpoints.
2932         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2933         procfs_use_watchpoints.
2934
2935 2018-05-02  Tom Tromey  <tom@tromey.com>
2936
2937         PR python/20084:
2938         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2939         and var_zuinteger_unlimited.
2940         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2941         and PARAM_ZUINTEGER_UNLIMITED.
2942         (set_parameter_value): Handle var_zuinteger and
2943         var_zuinteger_unlimited.
2944         (add_setshow_generic): Likewise.
2945         (parmpy_init): Likewise.
2946
2947 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2948
2949         PR rust/23124
2950         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2951         pointer is not null before dereferencing it.
2952
2953 2018-04-30  Tom Tromey  <tom@tromey.com>
2954
2955         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2956         is_mi_like_p.
2957
2958 2018-04-30  Tom Tromey  <tom@tromey.com>
2959
2960         * breakpoint.c (mention): Remove use of is_mi_like_p.
2961         (print_mention_ranged_breakpoint): Likewise.
2962         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2963         of is_mi_like_p.
2964
2965 2018-04-30  Tom Tromey  <tom@tromey.com>
2966
2967         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2968
2969 2018-04-30  Tom Tromey  <tom@tromey.com>
2970
2971         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2972         (info_spu_event_command): Remove some uses of is_mi_like_p.
2973
2974 2018-04-30  Tom Tromey  <tom@tromey.com>
2975
2976         * python/py-framefilter.c (py_print_single_arg)
2977         (enumerate_locals, py_print_args, py_print_frame): Remove some
2978         uses of is_mi_like_p.
2979
2980 2018-04-30  Tom Tromey  <tom@tromey.com>
2981
2982         * ui-out.c: Update.
2983         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2984         * ui-out.h (ui_out::is_mi_like_p): Now const.
2985         (ui_out::do_is_mi_like_p): Now const.
2986         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2987
2988 2018-04-30  Tom Tromey  <tom@tromey.com>
2989
2990         * varobj.c (varobj_set_visualizer): Use new_reference.
2991         * python/python.c (gdbpy_decode_line): Use new_reference.
2992         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2993         new_reference.
2994
2995 2018-04-30  Tom Tromey  <tom@tromey.com>
2996
2997         * varobj.c (install_new_value): Use new_reference.
2998         * value.h (value_incref): Return void.  Swap intro comment with
2999         value_decref.
3000         * value.c (set_value_parent): Use new_reference.
3001         (value_incref): Return void.  Update intro comment.
3002         (release_value): Use new_reference.
3003         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
3004
3005 2018-04-30  Tom Tromey  <tom@tromey.com>
3006
3007         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
3008         * gdb_bfd.h (new_bfd_ref): Remove.
3009         (gdb_bfd_open): Update comment.
3010         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
3011         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
3012         (gdb_bfd_fdopenr): Use new_reference.
3013         * exec.c (exec_file_attach): Use new_reference.
3014
3015 2018-04-30  Tom Tromey  <tom@tromey.com>
3016
3017         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
3018         method.
3019
3020 2018-04-30  Tom Tromey  <tom@tromey.com>
3021
3022         * jit.c (jit_read_code_entry): Use type_align.
3023         * i386-tdep.c (i386_gdbarch_init): Don't call
3024         set_gdbarch_long_long_align_bit.
3025         * gdbarch.sh: Remove long_long_align_bit.
3026         * gdbarch.c, gdbarch.h: Rebuild.
3027         * arc-tdep.c (arc_type_align): New function.
3028         (arc_gdbarch_init): Use arc_type_align.  Don't call
3029         set_gdbarch_long_long_align_bit.
3030
3031 2018-04-30  Tom Tromey  <tom@tromey.com>
3032
3033         * rust-lang.c (rust_type_alignment): Remove.
3034         (rust_composite_type): Use type_align.
3035
3036 2018-04-30  Tom Tromey  <tom@tromey.com>
3037
3038         * NEWS: Mention Type.align.
3039         * python/py-type.c (typy_get_alignof): New function.
3040         (type_object_getset): Add "alignof".
3041
3042 2018-04-30  Tom Tromey  <tom@tromey.com>
3043
3044         PR exp/17095:
3045         * NEWS: Update.
3046         * std-operator.def (UNOP_ALIGNOF): New operator.
3047         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
3048         New.
3049         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
3050         * c-lang.c (c_op_print_tab): Add alignof.
3051         * c-exp.y (ALIGNOF): New token.
3052         (exp): Add "ALIGNOF" production.
3053         (ident_tokens): Add _Alignof and alignof.
3054
3055 2018-04-30  Tom Tromey  <tom@tromey.com>
3056
3057         * i386-tdep.c (i386_type_align): New function.
3058         (i386_gdbarch_init): Update.
3059         * gdbarch.sh (type_align): New method.
3060         * gdbarch.c, gdbarch.h: Rebuild.
3061         * arch-utils.h (default_type_align): Declare.
3062         * arch-utils.c (default_type_align): New function.
3063         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
3064         (struct type) <align_log2>: New field.
3065         <instance_flags>: Now a bitfield.
3066         (TYPE_RAW_ALIGN): New macro.
3067         (type_align, type_raw_align, set_type_align): Declare.
3068         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
3069         functions.
3070         * dwarf2read.c (quirk_rust_enum): Set type alignment.
3071         (get_alignment, maybe_set_alignment): New functions.
3072         (read_structure_type, read_enumeration_type, read_array_type)
3073         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
3074         (read_subrange_type, read_base_type): Set type alignment.
3075
3076 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
3077
3078         * dwarf2read.c (read_index_from_section): Use bool.
3079
3080 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
3081
3082         PR gdb/22950
3083         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
3084         with #ifdef.
3085
3086 2018-04-29  John Reiser  <jreiser@BitWagon.com>
3087
3088         PR build/22873
3089         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
3090         last step, and do it atomically.
3091
3092 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
3093
3094         * compile/compile-c-types.c (convert_int, convert_float):
3095         Update for C FE v1.
3096
3097 2018-04-27  Tom Tromey  <tom@tromey.com>
3098
3099         PR rust/22545:
3100         * rust-lang.c (rust_inclusive_range_type_p): New function.
3101         (rust_range): Handle inclusive ranges.
3102         (rust_compute_range): Likewise.
3103         * rust-exp.y (struct rust_op) <inclusive>: New field.
3104         (DOTDOTEQ): New constant.
3105         (range_expr): Add "..=" productions.
3106         (operator_tokens): Add "..=" token.
3107         (ast_range): Add "inclusive" parameter.
3108         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
3109         ranges.
3110         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
3111         bounds values.
3112         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
3113         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
3114         Update comments.
3115         * expprint.c (print_subexp_standard): Handle new bounds values.
3116         (dump_subexp_body_standard): Likewise.
3117
3118 2018-04-27  Tom Tromey  <tom@tromey.com>
3119
3120         * configure: Rebuild.
3121         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
3122         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
3123         "OVERRIDE".
3124         (class symbol_needs_eval_context): Likewise.
3125         * dwarf2read.c (mock_mapped_index::symbol_name_count)
3126         (mock_mapped_index::symbol_name_at): Use "override".  Remove
3127         "virtual".
3128         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
3129         "override".
3130         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
3131         * aarch64-tdep.c (instruction_reader::read): Use "override".
3132         (instruction_reader_test::read): Likewise.
3133         * arm-tdep.c (instruction_reader::read): Use "override".
3134         (instruction_reader_thumb::read): Likewise.
3135
3136 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
3137
3138         PR remote/9665
3139         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3140         instead of remote_send.
3141         (remote_send): Remove.
3142
3143 2018-04-26  Pedro Alves  <palves@redhat.com>
3144
3145         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3146         find_function_start_sal instead of find_pc_line.
3147
3148 2018-04-26  Pedro Alves  <palves@redhat.com>
3149
3150         * breakpoint.c (set_breakpoint_location_function): Handle
3151         mst_data_gnu_ifunc.
3152         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3153         * elfread.c (elf_symtab_read): Give data symbols with
3154         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3155         (elf_rel_plt_read): Update comment.
3156         * linespec.c (convert_linespec_to_sals): Handle
3157         mst_data_gnu_ifunc.
3158         (minsym_found): Handle mst_data_gnu_ifunc.
3159         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3160         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3161         * parse.c (find_minsym_type_and_address): Handle
3162         mst_data_gnu_ifunc.
3163         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3164         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3165         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3166         comment.
3167         <mst_data_gnu_ifunc>: New enumerator.
3168
3169 2018-04-26  Pedro Alves  <palves@redhat.com>
3170
3171         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3172         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3173         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3174         Handle it.
3175         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3176         (lookup_minimal_symbol_by_pc): Adjust.
3177         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3178         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3179         * minsyms.h (lookup_msym_prefer): New enum.
3180         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3181         parameter by a lookup_msym_prefer parameter.
3182
3183 2018-04-26  Pedro Alves  <palves@redhat.com>
3184
3185         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3186         ends in "@plt" instead of looking at the symbol's section.
3187
3188 2018-04-26  Pedro Alves  <palves@redhat.com>
3189
3190         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3191         all references.
3192         (find_pc_partial_function_gnu_ifunc): Rename to ...
3193         (find_pc_partial_function): ... this, and remove references to
3194         'is_gnu_ifunc_p'.
3195         (find_pc_partial_function): Delete old implementation.
3196         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3197
3198 2018-04-26  Pedro Alves  <palves@redhat.com>
3199
3200         * linespec.c (struct bound_minimal_symbol_search_key): New.
3201         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3202         skip first line if we found a GNU ifunc minimal symbol by name.
3203         (compare_msymbols): Change parameters to work with a destructured
3204         lhs minsym.
3205         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3206         functions.
3207
3208 2018-04-26  Pedro Alves  <palves@redhat.com>
3209
3210         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3211         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3212         address/name.
3213         (add_location_to_breakpoint): Store the minsym and the objfile in
3214         the breakpoint location.
3215         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3216         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3217         Record the minsym in the sal.
3218         * symtab.h (symtab_and_line) <msymbol>: New field.
3219
3220 2018-04-26  Pedro Alves  <palves@redhat.com>
3221
3222         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3223         unless we actually resolved the ifunc.
3224
3225 2018-04-26  Pedro Alves  <palves@redhat.com>
3226
3227         * c-exp.y (variable production): Prefer ifunc minsyms over
3228         regular function symbols.
3229         * symtab.c (find_gnu_ifunc): New function.
3230         * minsyms.h (lookup_msym_prefer): New enum.
3231         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3232         parameter by a lookup_msym_prefer parameter.
3233         * symtab.h (find_gnu_ifunc): New declaration.
3234
3235 2018-04-26  Pedro Alves  <palves@redhat.com>
3236
3237         * blockframe.c (find_gnu_ifunc_target_type): New function.
3238         (find_function_type): New.
3239         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3240         return a value with a memory address.
3241         (eval_call): For calls to GNU ifunc functions, try to find the
3242         type of the target function from the type that the resolver
3243         returns.
3244         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3245         symbols.
3246         * infcall.c (find_function_return_type): Delete.
3247         (find_function_addr): Add 'function_type' parameter.  For calls to
3248         GNU ifunc functions, try to find the type of the target function
3249         from the type that the resolver returns, and return it via
3250         FUNCTION_TYPE.
3251         (call_function_by_hand_dummy): Adjust to use the function type
3252         returned by find_function_addr.
3253         (find_function_addr): Add 'function_type' parameter and move
3254         description here.
3255         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3256         declarations.
3257
3258 2018-04-26  Pedro Alves  <palves@redhat.com>
3259
3260         * c-exp.y (variable production): Skip finding an alias for ifunc
3261         symbols.
3262
3263 2018-04-26  Pedro Alves  <palves@redhat.com>
3264
3265         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3266
3267 2018-04-25  Pedro Alves  <palves@redhat.com>
3268
3269         * infcmd.c (kill_command): Print the pid as string, not the whole
3270         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3271         message.
3272         * remote.c (remote_detach_1): Print the pid as string, not the
3273         whole thread's ptid.
3274
3275 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3276             Sergio Durigan Junior  <sergiodj@redhat.com>
3277             Pedro Alves  <palves@redhat.com>
3278
3279         * infcmd.c (kill_command): Print message when inferior has
3280         been killed.
3281         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3282         '1'.
3283         (add_inferior): Improve message printed when
3284         'print_inferior_events' is on.
3285         (exit_inferior): Remove message printed when
3286         'print_inferior_events' is on.
3287         (detach_inferior): Improve message printed when
3288         'print_inferior_events' is on.
3289         (initialize_inferiors): Use 'add_inferior_silent' to set
3290         'current_inferior_'.
3291         * inferior.h (print_inferior_events): Declare here as
3292         'extern'.
3293         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3294         '[Detaching...]' messages when 'print_inferior_events' is on.
3295         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3296         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3297         'Detaching after fork from child...', replace it by '... from
3298         parent...'.
3299         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3300         prefix/suffix when printing 'Detaching...' messages.  Print
3301         them when 'print_inferior_events' is on.
3302         * remote.c (remote_detach_1): Print message when detaching
3303         from inferior and '!is_fork_parent'.
3304
3305 2018-04-24  Tom Tromey  <tom@tromey.com>
3306
3307         * cli-out.h: Reindent.
3308
3309 2018-04-24  Tom Tromey  <tom@tromey.com>
3310
3311         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3312         (cli_ui_out::do_field_string): Use fputs_filtered.
3313         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3314
3315 2018-04-23  Tom Tromey  <tom@tromey.com>
3316
3317         * guile/scm-frame.c (gdbscm_frame_read_var): Use
3318         gdb::unique_xmalloc_ptr.
3319
3320 2018-04-23  Tom Tromey  <tom@tromey.com>
3321
3322         * configure: Rebuild.
3323
3324 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
3325
3326         PR gdb/23095
3327         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
3328         prepare_for_testing.  Set normal_bp to r_debug_state if target
3329         is bsd.
3330
3331 2018-04-21  Pedro Alves  <palves@redhat.com>
3332             Rajendra SY  <rajendra.sy@gmail.com>
3333
3334         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
3335         * remote.c (extended_remote_attach): In all-stop mode, mark the
3336         thread as executing.
3337
3338 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3339
3340         * thread.c (thread_apply_all_command): Fix comment.
3341         (thread_command): Fix comment.
3342
3343 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
3344
3345         * common/tdesc.h (tdesc_create_feature): Remove xml filename
3346         parameter.
3347         * features/aarch64-core.c (create_feature_aarch64_core):
3348         Regenerate.
3349         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
3350         Likewise.
3351         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
3352         Likewise.
3353         * features/i386/32bit-avx512.c
3354         (create_feature_i386_32bit_avx512): Likewise.
3355         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
3356         Likewise.
3357         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
3358         Likewise.
3359         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3360         Likewise.
3361         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3362         Likewise.
3363         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3364         Likewise.
3365         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3366         Likewise.
3367         * features/i386/64bit-avx512.c
3368         (create_feature_i386_64bit_avx512): Likewise.
3369         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3370         Likewise.
3371         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3372         Likewise.
3373         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3374         Likewise.
3375         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3376         Likewise.
3377         * features/i386/64bit-segments.c
3378         (create_feature_i386_64bit_segments): Likewise.
3379         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3380         Likewise.
3381         * features/i386/x32-core.c
3382         (create_feature_i386_x32_core): Likewise.
3383         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3384         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3385         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3386         * target-descriptions.c: In generated code, don't pass xml
3387         filename.
3388
3389 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3390
3391         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3392         (print_xml_feature::visit_post): Likewise.
3393         (print_xml_feature::visit): Likewise.
3394         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3395         (print_xml_feature): Add new class.
3396         * regformats/regdat.sh: Null xmltarget on feature targets.
3397         * target-descriptions.c (struct target_desc): Add xmltarget.
3398         (maintenance_check_tdesc_xml_convert): Add unittest function.
3399         (tdesc_get_features_xml): Add function to get xml.
3400         (maintenance_check_xml_descriptions): Test xml generation.
3401         * xml-tdesc.c (string_read_description_xml): Add function.
3402         * xml-tdesc.h (string_read_description_xml): Add declaration.
3403
3404 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3405
3406         * features/Makefile: Add feature marker to targets with new style
3407         target descriptions.
3408         * regformats/aarch64.dat: Regenerate.
3409         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3410         * regformats/i386/amd64-avx-linux.dat: Likewise.
3411         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3412         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3413         * regformats/i386/amd64-linux.dat: Likewise.
3414         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3415         * regformats/i386/amd64.dat: Likewise.
3416         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3417         * regformats/i386/i386-avx-linux.dat: Likewise.
3418         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3419         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3420         * regformats/i386/i386-linux.dat: Likewise.
3421         * regformats/i386/i386-mmx-linux.dat: Likewise.
3422         * regformats/i386/i386-mpx-linux.dat: Likewise.
3423         * regformats/i386/i386.dat: Likewise.
3424         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3425         * regformats/i386/x32-avx-linux.dat: Likewise.
3426         * regformats/i386/x32-linux.dat: Likewise.
3427         * regformats/tic6x-c62x-linux.dat: Likewise.
3428         * regformats/tic6x-c64x-linux.dat: Likewise.
3429         * regformats/tic6x-c64xp-linux.dat: Likewise.
3430         * regformats/regdat.sh: Parse feature marker.
3431
3432 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3433
3434         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3435         (tdesc_osabi_name): Likewise.
3436         * target-descriptions.c (tdesc_architecture_name): Add new
3437         function.
3438         (tdesc_osabi_name): Likewise.
3439
3440 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3441
3442         * common/tdesc.c (tdesc_predefined_type): Move to here.
3443         (tdesc_named_type): Likewise.
3444         (tdesc_create_vector): Likewise.
3445         (tdesc_create_struct): Likewise.
3446         (tdesc_set_struct_size): Likewise.
3447         (tdesc_create_union): Likewise.
3448         (tdesc_create_flags): Likewise.
3449         (tdesc_create_enum): Likewise.
3450         (tdesc_add_field): Likewise.
3451         (tdesc_add_typed_bitfield): Likewise.
3452         (tdesc_add_bitfield): Likewise.
3453         (tdesc_add_flag): Likewise.
3454         (tdesc_add_enum_value): Likewise.
3455         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3456         (struct tdesc_type_vector): Likewise.
3457         (struct tdesc_type_field): Likewise.
3458         (struct tdesc_type_with_fields): Likewise.
3459         (tdesc_create_enum): Add declaration.
3460         (tdesc_add_typed_bitfield): Likewise.
3461         (tdesc_add_enum_value): Likewise.
3462         * target-descriptions.c (tdesc_type_field): Move from here.
3463         (tdesc_type_builtin): Likewise.
3464         (tdesc_type_vector): Likewise.
3465         (tdesc_type_with_fields): Likewise.
3466         (tdesc_predefined_types): Likewise.
3467         (tdesc_named_type): Likewise.
3468         (tdesc_create_vector): Likewise.
3469         (tdesc_create_struct): Likewise.
3470         (tdesc_set_struct_size): Likewise.
3471         (tdesc_create_union): Likewise.
3472         (tdesc_create_flags): Likewise.
3473         (tdesc_create_enum): Likewise.
3474         (tdesc_add_field): Likewise.
3475         (tdesc_add_typed_bitfield): Likewise.
3476         (tdesc_add_bitfield): Likewise.
3477         (tdesc_add_flag): Likewise.
3478         (tdesc_add_enum_value): Likewise.
3479         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3480         (tdesc_add_typed_bitfield): Likewise.
3481         (tdesc_add_enum_value): Likewise.
3482
3483 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3484
3485         * common/tdesc.c (tdesc_feature::accept): Move to here.
3486         (tdesc_feature::operator==): Likewise.
3487         (tdesc_create_reg): Likewise.
3488         * common/tdesc.h (tdesc_type_kind): Likewise.
3489         (struct tdesc_type): Likewise.
3490         (struct tdesc_feature): Likewise.
3491         * regformats/regdat.sh: Create a feature.
3492         * target-descriptions.c (tdesc_type_kind): Move from here.
3493         (tdesc_type): Likewise.
3494         (tdesc_type_up): Likewise.
3495         (tdesc_feature): Likewise.
3496         (tdesc_create_reg): Likewise.
3497
3498 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3499
3500         * Makefile.in: Add arch/tdesc.c
3501         * common/tdesc.c: New file.
3502         * common/tdesc.h (tdesc_element_visitor): Move to here.
3503         (tdesc_element): Likewise.
3504         (tdesc_reg): Likewise.
3505         (tdesc_reg_up): Likewise.
3506         * regformats/regdef.h (reg): Add offset to constructors.
3507         * target-descriptions.c (tdesc_element_visitor): Move from here.
3508         (tdesc_element): Likewise.
3509         (tdesc_reg): Likewise.
3510         (tdesc_reg_up): Likewise.
3511
3512 2018-04-17  Tom Tromey  <tom@tromey.com>
3513
3514         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3515         discriminant field.
3516
3517 2018-04-17  Tom Tromey  <tom@tromey.com>
3518
3519         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3520
3521 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3522
3523         * symtab.c (print_symbol_info): Skip printing filename and line
3524         number when `last' is NULL.
3525         (symtab_symbol_info): Use empty string instead of NULL for first
3526         invocation of print_symbol_info.
3527         (rbreak_command): Pass NULL to `last' parameter of
3528         print_symbol_info.
3529
3530 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3531
3532         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3533         instead of nullptr.
3534
3535 2018-04-16  Pedro Alves  <palves@redhat.com>
3536
3537         * MAINTAINERS (sh): Remove.
3538         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3539         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3540         (ALLDEPFILES): Remove sh64-tdep.c.
3541         * NEWS: Mentions that support for SH-5/SH64 is removed.
3542         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3543         (sh*-*-openbsd*): Ditto.
3544         (sh64-*-elf*): Remove.
3545         (sh*): Remove.
3546         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3547         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3548         * sh-tdep.c: No longer include "sh64-tdep.h".
3549         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3550         * sh64-tdep.c, sh64-tdep.h: Remove files.
3551
3552 2018-04-16  Pedro Alves  <palves@redhat.com>
3553
3554         * MAINTAINERS: Remove m88k.
3555         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3556         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3557         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3558         * NEWS: Mention that support for m88k was removed.
3559         * configure.host (m88*-*-*): Remove support.
3560         * configure.nat (m88k-*-*): Remove support.
3561         * configure.tgt (m88*-*-openbsd*): Remove.
3562         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3563
3564 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3565
3566         * configure.tgt (x86_tobjs): New variable.
3567         (amd64_tobjs, i386_tobjs): Use it.
3568
3569 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3570
3571         * symtab.c (print_symbol_info): Precede the symbol definition by
3572         the line number when available.
3573         * NEWS: Advertise this enhancement.
3574
3575 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3576
3577         * NEWS (New options): announce set/show record btrace cpu.
3578         * btrace.c: Include record-btrace.h.
3579         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3580         the vendor is unknown.
3581         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3582         Maybe overwrite the btrace configuration's cpu.
3583         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3584         (btrace_fetch): Add cpu parameter.  Update callers.
3585         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3586         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3587         errata workarounds if the vendor is unknown.
3588         * python/py-record-btrace.c: Include record-btrace.h.
3589         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3590         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3591         * record-btrace.c (record_btrace_cpu_state_kind): New.
3592         (record_btrace_cpu): New.
3593         (set_record_btrace_cpu_cmdlist): New.
3594         (record_btrace_get_cpu): New.
3595         (require_btrace_thread, record_btrace_info)
3596         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3597         (cmd_set_record_btrace_cpu_none): New.
3598         (cmd_set_record_btrace_cpu_auto): New.
3599         (cmd_set_record_btrace_cpu): New.
3600         (cmd_show_record_btrace_cpu): New.
3601         (_initialize_record_btrace): Initialize set/show record btrace cpu
3602         commands.
3603         * record-btrace.h (record_btrace_get_cpu): New.
3604
3605 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3606
3607         * record.c (set_record_command): Fix typo in message.
3608
3609 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3610
3611         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3612
3613 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3614
3615         * infrun.c (process_event_stop_test): Call
3616         gdbarch_in_indirect_branch_thunk.
3617         * gdbarch.sh (in_indirect_branch_thunk): New.
3618         * gdbarch.c: Regenerated.
3619         * gdbarch.h: Regenerated.
3620         * x86-tdep.h: New.
3621         * x86-tdep.c: New.
3622         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3623         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3624         (ALLDEPFILES): Add x86-tdep.c.
3625         * arch-utils.h (default_in_indirect_branch_thunk): New.
3626         * arch-utils.c (default_in_indirect_branch_thunk): New.
3627         * i386-tdep: Include x86-tdep.h.
3628         (i386_in_indirect_branch_thunk): New.
3629         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3630         function.
3631         * amd64-tdep: Include x86-tdep.h.
3632         (amd64_in_indirect_branch_thunk): New.
3633         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3634
3635 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3636
3637         PR gdb/23053
3638         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3639         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3640         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3641         regression.
3642
3643 2018-04-12  Tom Tromey  <tom@tromey.com>
3644
3645         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3646         (rust_evaluate_subexp): Likewise.
3647
3648 2018-04-12  Pedro Alves  <palves@redhat.com>
3649
3650         * procfs.c (procfs_detach): Make forward declaration's prototype
3651         match definition's protototype.
3652         (proc_get_LDT_entry): Remove stale do_cleanups call.
3653
3654 2018-04-12  Pedro Alves  <palves@redhat.com>
3655
3656         * target.h (target_ops::to_has_exited): Delete.
3657         (target_has_exited): Delete.
3658         * target-delegates.c: Regenerate.
3659
3660 2018-04-11  Pedro Alves  <palves@redhat.com>
3661
3662         * target.c (fileio_fh_t::t): Add comment.
3663         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3664         (target_fileio_close): Handle a NULL target.
3665         (invalidate_fileio_fh): New.
3666         (target_close): Call it.
3667         * remote.c (remote_hostio_send_command): No longer check whether
3668         remote_desc is open.
3669
3670 2018-04-11  Pedro Alves  <palves@redhat.com>
3671
3672         * target.c (fileio_fh_t): Make it a named struct instead of a
3673         typedef.
3674         (fileio_fh_t::is_closed): New method.
3675         (DEF_VEC_O (fileio_fh_t)): Remove.
3676         (fileio_fhandles): Now a std::vector.
3677         (is_closed_fileio_fh): Delete.
3678         (acquire_fileio_fd): Adjust.  Rename parameters.
3679         (release_fileio_fd): Adjust.
3680         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3681         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3682         (target_fileio_close): Adjust.
3683
3684 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3685
3686         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3687         index.
3688
3689 2018-04-10  Pedro Alves  <palves@redhat.com>
3690
3691         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3692         (scoped_finish_thread_state): New class.
3693         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3694         cleanup.
3695         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3696         (fetch_inferior_event, normal_stop): Likewise.
3697         * thread.c (finish_thread_state_cleanup): Delete.
3698
3699 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3700             Pedro Alves  <palves@redhat.com>
3701
3702         * value.c: Include "selftest.h" and "common/array-view.h".
3703         (struct range) <operator ==>: New.
3704         (test_ranges_contain): New.
3705         (check_ranges_vector): New.
3706         (test_insert_into_bit_range_vector): New.
3707         (_initialize_values): Register selftests.
3708         * common/array-view.h (operator==, operator!=): New.
3709
3710 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3711
3712         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3713         an iterator.
3714         * inline-frame.c: Include <algorithm>.
3715         (struct inline_state): Add constructor.
3716         (inline_state_s): Remove.
3717         (DEF_VEC_O(inline_state_s)): Remove.
3718         (inline_states): Change type to std::vector.
3719         (find_inline_frame_state): Adjust to std::vector.
3720         (allocate_inline_frame_state): Remove.
3721         (clear_inline_frame_state): Adjust to std::vector.
3722         (skip_inline_frames): Adjust to std::vector.
3723
3724 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3725
3726         * tracepoint.h (struct trace_state_variable): Add constructor.
3727         <name>: Change type to std::string.
3728         * tracepoint.c (tsv_s): Remove.
3729         (DEF_VEC_O(tsv_s)): Remove.
3730         (tvariables): Change to std::vector.
3731         (create_trace_state_variable): Adjust to std::vector.
3732         (find_trace_state_variable): Likewise.
3733         (find_trace_state_variable_by_number): Likewise.
3734         (delete_trace_state_variable): Likewise.
3735         (trace_variable_command): Adjust to std::string.
3736         (delete_trace_variable_command): Likewise.
3737         (tvariables_info_1): Adjust to std::vector.
3738         (save_trace_state_variables): Likewise.
3739         (start_tracing): Likewise.
3740         (merge_uploaded_trace_state_variables): Adjust to std::vector
3741         and std::string.
3742         * target.h (struct target_ops)
3743         <to_download_trace_state_variable>: Pass reference to
3744         trace_state_variable.
3745         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3746         * target-delegates.c: Re-generate.
3747         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3748         (mi_tsv_deleted): Likewise.
3749         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3750         * remote.c (remote_download_trace_state_variable): Change
3751         pointer to reference and adjust.
3752         * make-target-delegates (parse_argtypes): Handle references.
3753         (write_function_header): Likewise.
3754         (munge_type): Likewise.
3755
3756 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3757
3758         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3759         string_view-selftests.c.
3760         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3761         testsuite.
3762         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3763         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3764         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3765         * unittests/basic_string_view/element_access/char/1.cc:
3766         Likewise.
3767         * unittests/basic_string_view/element_access/char/empty.cc:
3768         Likewise.
3769         * unittests/basic_string_view/element_access/char/front_back.cc:
3770         Likewise.
3771         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3772         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3773         Likewise.
3774         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3775         Likewise.
3776         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3777         Likewise.
3778         * unittests/basic_string_view/operations/compare/char/1.cc:
3779         Likewise.
3780         * unittests/basic_string_view/operations/compare/char/13650.cc:
3781         Likewise.
3782         * unittests/basic_string_view/operations/copy/char/1.cc:
3783         Likewise.
3784         * unittests/basic_string_view/operations/data/char/1.cc:
3785         Likewise.
3786         * unittests/basic_string_view/operations/find/char/1.cc:
3787         Likewise.
3788         * unittests/basic_string_view/operations/find/char/2.cc:
3789         Likewise.
3790         * unittests/basic_string_view/operations/find/char/3.cc:
3791         Likewise.
3792         * unittests/basic_string_view/operations/find/char/4.cc:
3793         Likewise.
3794         * unittests/basic_string_view/operations/rfind/char/1.cc:
3795         Likewise.
3796         * unittests/basic_string_view/operations/rfind/char/2.cc:
3797         Likewise.
3798         * unittests/basic_string_view/operations/rfind/char/3.cc:
3799         Likewise.
3800         * unittests/basic_string_view/operations/substr/char/1.cc:
3801         Likewise.
3802         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3803         * unittests/string_view-selftests.c: New file.
3804
3805 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3806
3807         * unittests/basic_string_view/capacity/1.cc: New file.
3808         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3809         * unittests/basic_string_view/cons/char/1.cc: New file.
3810         * unittests/basic_string_view/cons/char/2.cc: New file.
3811         * unittests/basic_string_view/cons/char/3.cc: New file.
3812         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3813         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3814         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3815         * unittests/basic_string_view/element_access/char/1.cc: New file.
3816         * unittests/basic_string_view/element_access/char/2.cc: New file.
3817         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3818         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3819         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3820         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3821         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3822         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3823         * unittests/basic_string_view/include.cc: New file.
3824         * unittests/basic_string_view/inserters/char/1.cc: New file.
3825         * unittests/basic_string_view/inserters/char/2.cc: New file.
3826         * unittests/basic_string_view/inserters/char/3.cc: New file.
3827         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3828         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3829         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3830         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3831         * unittests/basic_string_view/literals/types.cc: New file.
3832         * unittests/basic_string_view/literals/values.cc: New file.
3833         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3834         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3835         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3836         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3837         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3838         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3839         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3840         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3841         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3842         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3843         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3844         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3845         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3846         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3847         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3848         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3849         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3850         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3851         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3852         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3853         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3854         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3855         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3856         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3857         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3858         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3859         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3860         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3861         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3862         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3863         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3864         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3865         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3866         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3867         * unittests/basic_string_view/operators/char/2.cc: New file.
3868         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3869         * unittests/basic_string_view/range_access/char/1.cc: New file.
3870         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3871         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3872         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3873         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3874         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
3875         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
3876         * unittests/basic_string_view/requirements/typedefs.cc: New file.
3877         * unittests/basic_string_view/typedefs.cc: New file.
3878         * unittests/basic_string_view/types/1.cc: New file.
3879
3880 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3881
3882         * common/gdb_string_view.h: Remove libstdc++ implementation
3883         details, adjust to gdb reality.
3884         * common/gdb_string_view.tcc: Likewise.
3885         * cli/cli-script.c (struct string_view): Remove.
3886         (user_args) <m_args>: Change element type to gdb::string_view.
3887         (user_args::insert_args): Adjust.
3888
3889 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3890
3891         * common/gdb_string_view.h: New file.
3892         * common/gdb_string_view.tcc: New file.
3893
3894 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3895
3896         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
3897         * configure: Re-generate.
3898
3899 2018-04-09  Pedro Alves  <palves@redhat.com>
3900
3901         * gdbarch.sh: Include "observable.h" instead of "observer.h".
3902         (set_target_gdbarch): Call
3903         gdb::observers::architecture_changed.notify instead of
3904         observer_notify_architecture_changed.
3905
3906 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3907
3908         * tracepoint.c (struct current_traceframe_cleanup): Remove.
3909         (do_restore_current_traceframe_cleanup): Remove.
3910         (restore_current_traceframe_cleanup_dtor): Remove.
3911         (make_cleanup_restore_current_traceframe): Remove.
3912         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
3913         New.
3914         * tracepoint.h (struct scoped_restore_current_traceframe): New.
3915         * infrun.c (fetch_inferior_event): Use
3916         scoped_restore_current_traceframe.
3917
3918 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3919
3920         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3921         Remove.
3922         <n_allocated_type_units>: Remove.
3923         <all_type_units>: Change to std::vector.
3924         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3925         to std::vector change.
3926         (dwarf2_per_objfile::get_cutu): Likewise.
3927         (dwarf2_per_objfile::get_tu): Likewise.
3928         (create_signatured_type_table_from_index): Likewise.
3929         (create_signatured_type_table_from_debug_names): Likewise.
3930         (dw2_symtab_iter_next): Likewise.
3931         (dw2_print_stats): Likewise.
3932         (dw2_expand_all_symtabs): Likewise.
3933         (dw2_expand_marked_cus): Likewise.
3934         (dw2_debug_names_iterator::next): Likewise.
3935         (dwarf2_initialize_objfile): Likewise.
3936         (add_signatured_type_cu_to_table): Likewise.
3937         (create_all_type_units): Likewise.
3938         (add_type_unit): Likewise.
3939         (struct tu_abbrev_offset): Add constructor.
3940         (build_type_psymtabs_1): Adjust to std::vector change.
3941         (print_tu_stats): Likewise.
3942         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3943         (write_debug_names): Likewise.
3944
3945 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3946
3947         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3948         Make an std::vector.
3949         <n_comp_units>: Remove.
3950         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3951         to std::vector change.
3952         (dwarf2_per_objfile::get_cutu): Likewise.
3953         (dwarf2_per_objfile::get_cu): Likewise.
3954         (create_cus_from_index): Likewise.
3955         (create_addrmap_from_index): Likewise.
3956         (create_addrmap_from_aranges): Likewise.
3957         (dwarf2_read_index): Likewise.
3958         (dw2_find_last_source_symtab): Likewise.
3959         (dw2_map_symtabs_matching_filename): Likewise.
3960         (dw2_symtab_iter_next): Likewise.
3961         (dw2_print_stats): Likewise.
3962         (dw2_expand_all_symtabs): Likewise.
3963         (dw2_expand_symtabs_with_fullname): Likewise.
3964         (dw2_expand_marked_cus): Likewise.
3965         (dw2_map_symbol_filenames): Likewise.
3966         (create_cus_from_debug_names): Likewise.
3967         (dwarf2_read_debug_names): Likewise.
3968         (dw2_debug_names_iterator::next): Likewise.
3969         (dwarf2_initialize_objfile): Likewise.
3970         (set_partial_user): Likewise.
3971         (dwarf2_build_psymtabs_hard): Likewise.
3972         (read_comp_units_from_section): Remove arguments, adjust to
3973         std::vector change.
3974         (create_all_comp_units): Adjust to std::vector and
3975         read_comp_units_from_section changes.
3976         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3977         change.
3978         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3979         (psyms_seen_size): Likewise.
3980         (write_gdbindex): Likewise.
3981         (write_debug_names): Likewise.
3982
3983 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3984
3985         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3986         with dwarf2_per_objfile.
3987         (create_cus_from_index): Likewise.
3988         (create_signatured_type_table_from_index): Likewise.
3989         (dwarf2_read_index): Likewise.
3990         (dwarf2_initialize_objfile): Likewise.
3991         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3992         per_cu rather than get_dwarf2_per_objfile.
3993
3994 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3995
3996         * dwarf2read.h (struct signatured_type): Forward declare.
3997         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3998         New methods.
3999         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
4000         (dw2_get_cutu): ...this.
4001         (dwarf2_per_objfile::get_cu): Rename from...
4002         (dw2_get_cu): ...this.
4003         (dwarf2_per_objfile::get_tu): New.
4004         (create_addrmap_from_index): Adjust.
4005         (create_addrmap_from_aranges): Adjust.
4006         (dw2_find_last_source_symtab): Adjust.
4007         (dw2_map_symtabs_matching_filename): Adjust.
4008         (dw2_symtab_iter_next): Adjust.
4009         (dw2_print_stats): Adjust.
4010         (dw2_expand_all_symtabs): Adjust.
4011         (dw2_expand_symtabs_with_fullname): Adjust.
4012         (dw2_expand_marked_cus): Adjust.
4013         (dw_expand_symtabs_matching_file_matcher): Adjust.
4014         (dw2_map_symbol_filenames): Adjust.
4015         (dw2_debug_names_iterator::next): Adjust.
4016         (dwarf2_initialize_objfile): Adjust.
4017         (set_partial_user): Adjust.
4018         (dwarf2_build_psymtabs_hard): Adjust.
4019
4020 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4021
4022         * dwarf2read.c (create_signatured_type_table_from_debug_names):
4023         Remove unused variables.
4024         (dw2_map_symtabs_matching_filename): Likewise.
4025         (dwarf2_record_block_ranges): Likewise.
4026         (dwarf2_read_addr_index): Likewise.
4027         (follow_die_offset): Likewise.
4028
4029 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4030
4031         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
4032         to symbol_file_add_main.
4033
4034 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4035
4036         PR mi/22299
4037         * mi/mi-console.c (do_fputc_async_safe): New.
4038         (mi_console_file::write_async_safe): New.
4039         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
4040         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
4041         New.
4042         * ui-file.c (ui_file::putstrn): Adjust call to
4043         fputstrn_unfiltered.
4044         * utils.c (printchar): Replace do_fputs and do_fprintf
4045         parameters by do_fputc.
4046         (fputstr_filtered): Adjust call to printchar.
4047         (fputstr_unfiltered): Likewise.
4048         (fputstrn_filtered): Likewise.
4049         (fputstrn_unfiltered): Add do_fputc parameter, pass to
4050         printchar.
4051         * utils.h (do_fputc_ftype): New typedef.
4052         (fputstrn_unfiltered): Add do_fputc parameter.
4053
4054 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4055
4056         * regformats/i386/i386-avx.dat: Remove.
4057
4058 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4059
4060         PR gdb/22979
4061         * amd64-tdep.c (amd64_none_init_abi): New function.
4062         (amd64_x32_none_init_abi): New function.
4063         (_initialize_amd64_tdep): Register handlers for x86-64 and
4064         x64_32 with GDB_OSABI_NONE.
4065         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
4066         GDB_OSABI_NONE osabi.
4067
4068 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4069
4070         PR gdb/22980
4071         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
4072         GDB_OSABI_NONE.
4073         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
4074         * osabi.c (gdb_osabi_names): Add "unknown" entry.
4075
4076 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4077
4078         * common/byte-vector.h (char_vector): New type.
4079         * target.h (target_read_alloc): Return
4080         gdb::optional<byte_vector>.
4081         (target_read_stralloc): Return gdb::optional<char_vector>.
4082         (target_get_osdata): Return gdb::optional<char_vector>.
4083         * target.c (target_read_alloc_1): Templatize.  Replacement
4084         manual memory management with vector.
4085         (target_read_alloc): Change return type, adjust.
4086         (target_read_stralloc): Change return type, adjust.
4087         (target_get_osdata): Change return type, adjust.
4088         * auxv.c (struct auxv_info) <length>: Remove.
4089         <data>: Change type to gdb::optional<byte_vector>.
4090         (auxv_inferior_data_cleanup): Free auxv_info with delete.
4091         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
4092         (target_auxv_search): Adjust.
4093         (fprint_target_auxv): Adjust.
4094         * avr-tdep.c (avr_io_reg_read_command): Adjust.
4095         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
4096         (linux_make_corefile_notes): Adjust.
4097         * osdata.c (get_osdata): Adjust.
4098         * remote.c (remote_get_threads_with_qxfer): Adjust.
4099         (remote_memory_map): Adjust.
4100         (remote_traceframe_info): Adjust.
4101         (btrace_read_config): Adjust.
4102         (remote_read_btrace): Adjust.
4103         (remote_pid_to_exec_file): Adjust.
4104         * solib-aix.c (solib_aix_get_library_list): Adjust.
4105         * solib-dsbt.c (decode_loadmap): Don't free buf.
4106         (dsbt_get_initial_loadmaps): Adjust.
4107         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
4108         * solib-target.c (solib_target_current_sos): Adjust.
4109         * tracepoint.c (sdata_make_value): Adjust.
4110         * xml-support.c (xinclude_start_include): Adjust.
4111         (xml_fetch_content_from_file): Adjust.
4112         * xml-support.h (xml_fetch_another): Change return type.
4113         (xml_fetch_content_from_file): Change return type.
4114         * xml-syscall.c (xml_init_syscalls_info): Adjust.
4115         * xml-tdesc.c (file_read_description_xml): Adjust.
4116         (fetch_available_features_from_target): Change return type.
4117         (target_fetch_description_xml): Adjust.
4118         (target_read_description_xml): Adjust.
4119
4120 2018-04-06  Tom Tromey  <tom@tromey.com>
4121
4122         * value.c (~value): Update.
4123         (struct value) <contents>: Now unique_xmalloc_ptr.
4124         (value_contents_bits_eq, allocate_value_contents)
4125         (value_contents_raw, value_contents_all_raw)
4126         (value_contents_for_printing, value_contents_for_printing_const)
4127         (set_value_enclosing_type): Update.
4128
4129 2018-04-06  Tom Tromey  <tom@tromey.com>
4130
4131         * value.c (range_s): Remove typedef, VEC.
4132         (struct range): Add operator<.
4133         (range_lessthan): Remove.
4134         (ranges_contain): Change type.
4135         (~value): Update.
4136         (struct value) <unavailable, optimized_out>: Now std::vector.
4137         (value_entirely_available)
4138         (value_entirely_covered_by_range_vector)
4139         (value_entirely_unavailable, value_entirely_optimized_out):
4140         Update.
4141         (insert_into_bit_range_vector): Change argument type.
4142         (find_first_range_overlap): Likewise.
4143         (struct ranges_and_idx, value_contents_bits_eq)
4144         (require_not_optimized_out, require_available): Update.
4145         (ranges_copy_adjusted): Change argument types.
4146         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4147
4148 2018-04-06  Tom Tromey  <tom@tromey.com>
4149
4150         * value.c (~value): Update.
4151         (struct value) <parent>: Now a value_ref_ptr.
4152         (value_parent, set_value_parent, value_address, value_copy):
4153         Update.
4154
4155 2018-04-06  Tom Tromey  <tom@tromey.com>
4156
4157         * value.c (struct value): Add constructor, destructor, and member
4158         initializers.
4159         (allocate_value_lazy, value_decref): Update.
4160
4161 2018-04-06  Tom Tromey  <tom@tromey.com>
4162
4163         * value.c (struct value) <released, next>: Remove.
4164         (all_values): Now a std::vector.
4165         (allocate_value_lazy): Update.
4166         (value_next): Remove.
4167         (value_mark, value_free_to_mark, release_value)
4168         (value_release_to_mark): Update.
4169
4170 2018-04-06  Tom Tromey  <tom@tromey.com>
4171
4172         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4173         (free_value_chain): Remove.
4174         * value.c (free_value_chain): Remove.
4175         (value_release_to_mark): Return a std::vector.
4176         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4177         std::vector.
4178         (check_condition): Update.
4179         * eval.c (fetch_subexp_value): Change "val_chain" to a
4180         std::vector.
4181         * breakpoint.c (update_watchpoint): Update.
4182         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4183
4184 2018-04-06  Tom Tromey  <tom@tromey.com>
4185
4186         * value.h (free_all_values): Remove.
4187         * value.c (free_all_values): Remove.
4188
4189 2018-04-06  Tom Tromey  <tom@tromey.com>
4190
4191         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4192         (value_history_chain, value_history_count): Remove.
4193         (value_history): New global.
4194         (record_latest_value, access_value_history, show_values)
4195         (preserve_values): Update.
4196
4197 2018-04-06  Tom Tromey  <tom@tromey.com>
4198
4199         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4200         * varobj.c (varobj_set_display_format, varobj_set_value)
4201         (install_default_visualizer, construct_visualizer)
4202         (install_new_value, ~varobj, varobj_get_value_type)
4203         (my_value_of_variable, varobj_editable_p): Update.
4204         * c-varobj.c (c_describe_child, c_value_of_variable)
4205         (cplus_number_of_children, cplus_describe_child): Update.
4206         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4207         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4208         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4209
4210 2018-04-06  Tom Tromey  <tom@tromey.com>
4211
4212         * printcmd.c (last_examine_address): Change type to
4213         value_ref_ptr.
4214         (do_examine, x_command): Update.
4215
4216 2018-04-06  Tom Tromey  <tom@tromey.com>
4217
4218         * value.c (release_value): Update.
4219         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4220         (struct bpstats) <val>: Now a value_ref_ptr.
4221         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4222         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4223         (~watchpoint, print_it_watchpoint, watch_command_1)
4224         (invalidate_bp_value_on_memory_change): Update.
4225
4226 2018-04-06  Tom Tromey  <tom@tromey.com>
4227
4228         * varobj.c (varobj_clear_saved_item)
4229         (update_dynamic_varobj_children, install_new_value, ~varobj):
4230         Update.
4231         * value.h (value_incref): Move declaration earlier.
4232         (value_decref): Rename from value_free.
4233         (struct value_ref_policy): New.
4234         (value_ref_ptr): New typedef.
4235         (struct value_deleter): Remove.
4236         (gdb_value_up): Remove typedef.
4237         (release_value): Change return type.
4238         (release_value_or_incref): Remove.
4239         * value.c (set_value_parent): Update.
4240         (value_incref): Change return type.
4241         (value_decref): Rename from value_free.
4242         (value_free_to_mark, free_all_values, free_value_chain): Update.
4243         (release_value): Return value_ref_ptr.
4244         (release_value_or_incref): Remove.
4245         (record_latest_value, set_internalvar, clear_internalvar):
4246         Update.
4247         * stack.c (info_frame_command): Don't call value_free.
4248         * python/py-value.c (valpy_dealloc, valpy_new)
4249         (value_to_value_object): Update.
4250         * printcmd.c (do_examine): Update.
4251         * opencl-lang.c (lval_func_free_closure): Update.
4252         * mi/mi-main.c (register_changed_p): Don't call value_free.
4253         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4254         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4255         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4256         value_free.
4257         * guile/scm-value.c (vlscm_free_value_smob)
4258         (vlscm_scm_from_value): Update.
4259         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4260         (frame_unwind_register_unsigned, get_frame_register_bytes)
4261         (put_frame_register_bytes): Don't call value_free.
4262         * findvar.c (address_from_register): Don't call value_free.
4263         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4264         * dwarf2loc.c (entry_data_value_free_closure)
4265         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4266         (dwarf2_evaluate_loc_desc_full): Update.
4267         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4268         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4269         (~watchpoint, watch_command_1)
4270         (invalidate_bp_value_on_memory_change): Update.
4271         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4272
4273 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4274
4275         PR gdb/23022
4276         * warning.m4: Add -Wno-error=deprecated-register.
4277         * configure: Re-generate.
4278
4279 2018-04-05  Tom Tromey  <tom@tromey.com>
4280
4281         * linespec.h: Remove include of "vec.h".
4282
4283 2018-04-05  Tom Tromey  <tom@tromey.com>
4284
4285         * linespec.c (typep): Remove typedef.
4286         (find_methods, find_superclass_methods): Take a std::vector.
4287         (find_method): Use std::vector.
4288
4289 2018-04-05  Tom Tromey  <tom@tromey.com>
4290
4291         * utils.c (compare_strings): Remove.
4292         * utils.h (compare_strings): Remove.
4293         * objc-lang.h (find_imps): Update.
4294         * objc-lang.c (find_methods): Take a std::vector.
4295         (uniquify_strings, find_imps): Likewise.
4296         * linespec.c (find_methods): Take a std::vector.
4297         (decode_objc): Use std::vector.
4298         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4299         a std::vector.
4300         (find_method, find_function_symbols): Use std::vector.
4301
4302 2018-04-05  Tom Tromey  <tom@tromey.com>
4303
4304         * completer.c (completion_tracker::completion_tracker): Remove
4305         cast.
4306         (completion_tracker::discard_completions): Likewise.
4307         * breakpoint.c (ambiguous_names_p): Remove cast.
4308         * ada-lang.c (_initialize_ada_language): Remove cast.
4309         * utils.h (streq): Update.
4310         (streq_hash): Add new declaration.
4311         * utils.c (streq): Return bool.
4312         (streq_hash): New function.
4313
4314 2018-04-05  Tom Tromey  <tom@tromey.com>
4315
4316         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
4317         Remove a string copy.
4318
4319 2018-04-05  Tom Tromey  <tom@tromey.com>
4320
4321         * linespec.c (filter_results): Use std::vector.
4322         (decode_line_2, decode_line_full): Update.
4323
4324 2018-04-05  Tom Tromey  <tom@tromey.com>
4325
4326         * linespec.c (canonical_to_fullform): Return std::string.
4327         (filter_results): Update.
4328         (struct decode_line_2_item): Add constructor.
4329         <fullform, displayform>: Now std::string.
4330         (decode_line_2_compare_items): Now a std::sort comparator.
4331         (decode_line_2): Update.
4332
4333 2018-04-05  Tom Tromey  <tom@tromey.com>
4334
4335         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
4336         (unexpected_linespec_error): Update.
4337         (linespec_parse_basic, parse_linespec): Update.
4338
4339 2018-04-05  Tom Tromey  <tom@tromey.com>
4340
4341         * linespec.c (linespec_parse_basic): Reindent.
4342
4343 2018-04-05  Tom Tromey  <tom@tromey.com>
4344
4345         * minsyms.h (iterate_over_minimal_symbols): Update.
4346         * minsyms.c (iterate_over_minimal_symbols): Take a
4347         gdb::function_view.
4348         * linespec.c (struct collect_minsyms): Remove.
4349         (compare_msyms): Now a std::sort comparator.
4350         (add_minsym): Add parameters.
4351         (search_minsyms_for_name): Update.  Use std::vector.
4352
4353 2018-04-03  Tom Tromey  <tom@tromey.com>
4354
4355         * mipsread.c (read_alphacoff_dynamic_symtab): Use
4356         gdb::byte_vector.
4357
4358 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4359
4360         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4361
4362 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4363
4364         PR gdb/16959
4365         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
4366         printing static type.
4367
4368 2018-04-01  Tom Tromey  <tom@tromey.com>
4369
4370         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4371         (rs6000_xfer_shared_libraries): Update.
4372
4373 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4374
4375         * common/gdb_vecs.h (char_ptr): Remove.
4376         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4377
4378 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4379
4380         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4381         with std::vector.
4382         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4383
4384 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4385
4386         * tracepoint.h (struct uploaded_tp): Initialize fields.
4387         <actions, step_actions, cmd_strings>: Change type to
4388         std::vector<char *>.
4389         * tracepoint.c (get_uploaded_tp): Allocate with new.
4390         (free_uploaded_tps): Free with delete.
4391         (parse_tracepoint_definition): Adjust to std::vector change.
4392         * breakpoint.c (read_uploaded_action): Likewise.
4393         (create_tracepoint_from_upload): Likewise.
4394         * ctf.c (ctf_write_uploaded_tp): Likewise.
4395         (SET_ARRAY_FIELD): Likewise.
4396         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4397
4398 2018-03-30  Tom Tromey  <tom@tromey.com>
4399
4400         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4401         std::unique_ptr.
4402         (svr4_keep_data_in_core): Update.
4403         (svr4_read_so_list): Update.
4404
4405 2018-03-30  Tom Tromey  <tom@tromey.com>
4406
4407         * windows-nat.c (handle_output_debug_string, handle_exception):
4408         Update.
4409         * target.h (target_read_string): Update.
4410         * target.c (target_read_string): Change "string" to
4411         unique_xmalloc_ptr.
4412         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4413         Update.
4414         * solib-frv.c (frv_current_sos): Update.
4415         * solib-dsbt.c (dsbt_current_sos): Update.
4416         * solib-darwin.c (darwin_current_sos): Update.
4417         * linux-thread-db.c (inferior_has_bug): Update.
4418         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4419         Update.  Remove alloca.
4420         * ada-lang.c (ada_main_name): Update.
4421
4422 2018-03-30  Tom Tromey  <tom@tromey.com>
4423
4424         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4425         (struct dwo_file_deleter): New.
4426         (dwo_file_up): New typedef.
4427         (open_and_init_dwo_file): Use dwo_file_up.
4428         (free_dwo_file_cleanup): Remove.
4429
4430 2018-03-30  Tom Tromey  <tom@tromey.com>
4431
4432         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4433         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4434
4435 2018-03-30  Tom Tromey  <tom@tromey.com>
4436
4437         * dwarf2read.c (class free_cached_comp_units): New class.
4438         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4439         (free_cached_comp_units): Remove function.
4440
4441 2018-03-30  Tom Tromey  <tom@tromey.com>
4442
4443         * utils.h (make_cleanup_unpush_target): Remove.
4444         * inf-ptrace.c (struct target_unpusher): New.
4445         (target_unpush_up) New typedef.
4446         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4447         target_unpush_up.
4448         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4449
4450 2018-03-27  Tom Tromey  <tom@tromey.com>
4451
4452         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4453
4454 2018-03-27  Pedro Alves  <palves@redhat.com>
4455             Tom Tromey  <tom@tromey.com>
4456
4457         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4458         destructor.  Now a class.
4459         (gdb_readline_wrapper_cleanup): Remove function.
4460         (gdb_readline_wrapper): Remove cleanups.
4461
4462 2018-03-27  Tom Tromey  <tom@tromey.com>
4463
4464         * typeprint.h (struct type_print_options) <local_typedefs,
4465         global_typedefs>: Remove "struct" keyword.
4466         (class typedef_hash_table): New class.
4467         (recursively_update_typedef_hash, add_template_parameters)
4468         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4469         (find_typedef_in_hash): Don't declare.
4470         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4471         (typedef_hash_table::recursively_update): Rename from
4472         recursively_update_typedef_hash.  Now a member.
4473         (typedef_hash_table::add_template_parameters): Rename from
4474         add_template_parameters.  Now a member.
4475         (typedef_hash_table::typedef_hash_table): Now a constructor;
4476         rename from create_typedef_hash.
4477         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4478         rename from free_typedef_hash.
4479         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4480         (do_free_global_table): Remove.
4481         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4482         from copy_type_recursive.
4483         (create_global_typedef_table): Remove.
4484         (typedef_hash_table::find_global_typedef): Now a member of
4485         typedef_hash_table.
4486         (typedef_hash_table::find_typedef): Rename from
4487         find_typedef_in_hash; now a member.
4488         (whatis_exp): Update.
4489         * extension.h (struct ext_lang_type_printers): Add constructor and
4490         destructor.
4491         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4492         declare.
4493         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4494         Now a constructor; rename from start_ext_lang_type_printers.
4495         (ext_lang_type_printers): Now a destructor; rename from
4496         free_ext_lang_type_printers.
4497         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4498         Update.
4499         (c_type_print_base_struct_union): Update.  Remove cleanups.
4500
4501 2018-03-27  Tom Tromey  <tom@tromey.com>
4502
4503         * dwarf-index-write.c: Include <cmath>.
4504
4505 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4506
4507         * NEWS: Add entry describing new "set|show varsize-limit" command.
4508         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4509         command.
4510         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4511         "set variable".
4512
4513 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4514
4515         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4516         dwarf-index-write.c
4517         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4518         * dwarf-index-common.c: New file.
4519         * dwarf-index-common.h: New file.
4520         * dwarf-index-write.c: New file.
4521         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4522         (struct dwarf2_section_info): Move from here.
4523         (dwarf2_section_info_def): Likewise.
4524         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4525         (offset_type): Likewise.
4526         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4527         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4528         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4529         (byte_swap): Likewise.
4530         (MAYBE_SWAP): Likewise.
4531         (dwarf2_per_cu_ptr): Likewise.
4532         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4533         (struct tu_stats): Likewise.
4534         (struct dwarf2_per_objfile): Likewise.
4535         (struct dwarf2_per_cu_data): Likewise.
4536         (struct signatured_type): Likewise.
4537         (sig_type_ptr): Likewise.
4538         (DEF_VEC_P (sig_type_ptr)): Likewise.
4539         (INDEX4_SUFFIX): Likewise.
4540         (INDEX5_SUFFIX): Likewise.
4541         (DEBUG_STR_SUFFIX): Likewise.
4542         (dwarf2_read_section): Make non-static.
4543         (mapped_index_string_hash): Move from here.
4544         (dwarf5_djb_hash): Likewise.
4545         (file_write): Likewise.
4546         (class data_buf): Likewise.
4547         (struct symtab_index_entry): Likewise.
4548         (struct mapped_symtab): Likewise.
4549         (find_slot): Likewise.
4550         (hash_expand): Likewise.
4551         (add_index_entry): Likewise.
4552         (uniquify_cu_indices): Likewise.
4553         (class c_str_view): Likewise.
4554         (class c_str_view_hasher): Likewise.
4555         (class vector_hasher): Likewise.
4556         (write_hash_table): Likewise.
4557         (psym_index_map): Likewise.
4558         (struct addrmap_index_data): Likewise.
4559         (add_address_entry): Likewise.
4560         (add_address_entry_worker): Likewise.
4561         (write_address_map): Likewise.
4562         (symbol_kind): Likewise.
4563         (write_psymbols): Likewise.
4564         (struct signatured_type_index_data): Likewise.
4565         (write_one_signatured_type): Likewise.
4566         (recursively_count_psymbols): Likewise.
4567         (recursively_write_psymbols): Likewise.
4568         (class debug_names): Likewise.
4569         (check_dwarf64_offsets): Likewise.
4570         (psyms_seen_size): Likewise.
4571         (write_gdbindex): Likewise.
4572         (write_debug_names): Likewise.
4573         (assert_file_size): Likewise.
4574         (write_psymtabs_to_index): Likewise.
4575         (save_gdb_index_command): Likewise.
4576         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4577         command.
4578         * dwarf2read.h: New file.
4579
4580 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4581
4582         PR gdb/22670
4583         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4584         symbol name if the CU's language stores symbol names in linkage
4585         format.
4586         * language.h (struct language_defn)
4587         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4588         all instances of this struct.
4589
4590 2018-03-26  Tom Tromey  <tom@tromey.com>
4591
4592         * stack.c (backtrace_command_1): Remove verbose code.
4593
4594 2018-03-26  Tom Tromey  <tom@tromey.com>
4595
4596         * python/py-framefilter.c (py_print_type): Don't catch
4597         exceptions.  Return void.
4598         (py_print_value): Likewise.
4599         (py_print_single_arg): Likewise.
4600         (enumerate_args): Don't catch exceptions.
4601         (py_print_args): Likewise.
4602         (py_print_frame): Likewise.
4603         (gdbpy_apply_frame_filter): Catch exceptions here.
4604
4605 2018-03-26  Tom Tromey  <tom@tromey.com>
4606
4607         * stack.c (_initialize_stack): Remove trailing newlines from help
4608         text.  Add "Usage" line to "backtrace" help.
4609
4610 2018-03-26  Tom Tromey  <tom@tromey.com>
4611
4612         PR python/16486:
4613         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4614
4615 2018-03-26  Tom Tromey  <tom@tromey.com>
4616
4617         * python/py-framefilter.c (py_print_single_arg): Return
4618         EXT_LANG_BT_ERROR from catch.
4619
4620 2018-03-26  Tom Tromey  <tom@tromey.com>
4621
4622         PR backtrace/15584:
4623         * stack.c (backtrace_command_1): Move some code into no-filters
4624         "if".
4625
4626 2018-03-26  Tom Tromey  <tom@tromey.com>
4627
4628         * python/py-framefilter.c (throw_quit_or_print_exception): New
4629         function.
4630         (gdbpy_apply_frame_filter): Use it.
4631
4632 2018-03-26  Tom Tromey  <tom@tromey.com>
4633
4634         PR cli/17716:
4635         * python/py-framefilter.c (py_print_type, py_print_value)
4636         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4637         RETURN_MASK_ERROR.
4638
4639 2018-03-26  Tom Tromey  <tom@tromey.com>
4640
4641         * python/py-framefilter.c (enumerate_args): Use
4642         gdb::unique_xmalloc_ptr.
4643
4644 2018-03-26  Tom Tromey  <tom@tromey.com>
4645
4646         * python/py-framefilter.c (py_print_frame): Return
4647         EXT_LANG_BT_OK.
4648         (gdbpy_apply_frame_filter): Update comment.
4649         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4650         Remove.
4651         <EXT_LANG_BT_NO_FILTERS>: Change value.
4652
4653 2018-03-26  Tom Tromey  <tom@tromey.com>
4654
4655         PR backtrace/15582:
4656         * stack.c (backtrace_command): Parse "hide" argument.
4657         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4658         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4659         constant.
4660
4661 2018-03-26  Tom Tromey  <tom@tromey.com>
4662
4663         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4664         add "flags".
4665         (backtrace_command): Remove "fulltrace", add "flags".
4666
4667 2018-03-26  Tom Tromey  <tom@tromey.com>
4668
4669         * stack.c (backtrace_command): Rewrite command line parsing.
4670
4671 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4672
4673         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4674
4675 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4676
4677         * filename-seen-cache.h: Add include guard.
4678
4679 2018-03-26  Keith Seitz  <keiths@redhat.com>
4680
4681         * symfile.c (place_section): Remove "struct" from section_addr_info
4682         in comment.
4683         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4684         "struct" keyword from section_addr_info.
4685
4686 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4687
4688         * regformats/regdef.h (reg): Add constructors.
4689
4690 2018-03-25  Pedro Alves  <palves@redhat.com>
4691
4692         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4693         if then/else bodies in var_func_name extraction.
4694
4695 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4696
4697         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4698         lookup_minimal_symbol() to find symbol entry.
4699         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4700
4701 2018-03-23  Keith Seitz  <keiths@redhat.com>
4702
4703         PR c++/22968
4704         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4705         nested type definitions for C++, too.
4706
4707 2018-03-23  Tom Tromey  <tom@tromey.com>
4708
4709         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4710         a typedef.
4711         (macho_register_oso): Remove.
4712         (macho_symtab_read): Take a std::vector.
4713         (oso_el_compare_name): Now a std::sort comparator.
4714         (macho_symfile_read_all_oso): Take a std::vector.
4715         (macho_symfile_read): Use std::vector.  Remove cleanups.
4716
4717 2018-03-22  Tom Tromey  <tom@tromey.com>
4718
4719         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4720         (record_full_goto_bookmark): Use std::string.
4721
4722 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4723
4724         PR tdep/18295
4725         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4726         a single mask.
4727
4728 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4729
4730         * rs6000-tdep.c (store_insn_p): New function.
4731         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4732         and cr_reg to their unshifted values. Use store_insn_p to
4733         match LR saves using either R1 or fdata->alloca_reg. Use
4734         store_insn_p to match CR saves. Set alloca_reg_offset
4735         when alloca_reg and framep are set. Remove lr_reg shift
4736         when assigning to fdata->lr_register.
4737
4738 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4739
4740         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4741         command line args instead of emitting a warning.
4742
4743 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4744
4745         * tracepoint.h (struct static_tracepoint_marker): Initialize
4746         fields, define default constructor, move constructor and move
4747         assignment, disable the rest.
4748         <str_id, extra>: Make std::string.
4749         (release_static_tracepoint_marker): Remove.
4750         (free_current_marker): Remove.
4751         * tracepoint.c (free_current_marker): Remove.
4752         (parse_static_tracepoint_marker_definition): Adjust to
4753         std::string, use new hex2str overload.
4754         (release_static_tracepoint_marker): Remove.
4755         (print_one_static_tracepoint_marker): Get marker by reference
4756         and adjust to std::string.
4757         (info_static_tracepoint_markers_command): Adjust to std::vector
4758         changes
4759         * target.h (static_tracepoint_marker_p): Remove typedef.
4760         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4761         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4762         bool.
4763         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4764         * target-debug.h
4765         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4766         (target_debug_print_std_vector_static_tracepoint_marker): New.
4767         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4768         to...
4769         (target_debug_print_static_tracepoint_marker_p): ... this.
4770         * target-delegates.c: Re-generate.
4771         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4772         Make std::string.
4773         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4774         (decode_static_tracepoint_spec): Adjust to std::vector.
4775         (tracepoint_print_one_detail): Adjust to std::string.
4776         (strace_marker_decode_location): Adjust to std::string.
4777         (update_static_tracepoint): Adjust to std::string, remove call
4778         to release_static_tracepoint_marker.
4779         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4780         Adjust to std::vector.
4781         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4782         (remote_static_tracepoint_markers_by_strid): Adjust to
4783         std::vector.
4784         * common/rsp-low.h (hex2str): New overload with explicit count
4785         of bytes.
4786         * common/rsp-low.c (hex2str): New overload with explicit count
4787         of bytes.
4788         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4789         (_initialize_rsp_low_selftests): Add test_hex2str test.
4790         * unittests/tracepoint-selftests.c
4791         (test_parse_static_tracepoint_marker_definition): Adjust to
4792         std::string.
4793
4794 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4795
4796         * tracepoint.c (parse_static_tracepoint_marker_definition):
4797         Consider case where the definition is followed by more
4798         definitions.
4799         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4800         tracepoint-selftests.c.
4801         * unittests/tracepoint-selftests.c: New.
4802
4803 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4804
4805         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4806         Carvalho.
4807
4808 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4809
4810         * symtab.c (find_pc_sect_line): fixed indentation.
4811
4812 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4813
4814         * symtab.c (find_pc_sect_line): now uses binary search.
4815
4816 2018-03-19  Tom Tromey  <tom@tromey.com>
4817
4818         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4819         "IDENT" production.
4820
4821 2018-03-19  Pedro Alves  <palves@redhat.com>
4822             Tom Tromey  <tom@tromey.com>
4823
4824         * unittests/observable-selftests.c: New file.
4825         * common/observable.h: New file.
4826         * observable.h: New file.
4827         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4828         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4829         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4830         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4831         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4832         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4833         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4834         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4835         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4836         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4837         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4838         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4839         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4840         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4841         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4842         tui/tui-interp.c, valops.c: Update all users.
4843         * tui/tui-hooks.c (tui_bp_created_observer)
4844         (tui_bp_deleted_observer, tui_bp_modified_observer)
4845         (tui_inferior_exit_observer, tui_before_prompt_observer)
4846         (tui_normal_stop_observer, tui_register_changed_observer):
4847         Remove.
4848         (tui_observers_token): New global.
4849         (attach_or_detach, tui_attach_detach_observers): New functions.
4850         (tui_install_hooks, tui_remove_hooks): Use
4851         tui_attach_detach_observers.
4852         * record-btrace.c (record_btrace_thread_observer): Remove.
4853         (record_btrace_thread_observer_token): New global.
4854         * observer.sh: Remove.
4855         * observer.c: Rename to observable.c.
4856         * observable.c (namespace gdb_observers): Define new objects.
4857         (observer_debug): Move into gdb_observers namespace.
4858         (struct observer, struct observer_list, xalloc_observer_list_node)
4859         (xfree_observer_list_node, generic_observer_attach)
4860         (generic_observer_detach, generic_observer_notify): Remove.
4861         (_initialize_observer): Update.
4862         Don't include observer.inc.
4863         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4864         (clean mostlyclean): Likewise.
4865         (observer.h, observer.inc): Remove targets.
4866         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4867         (COMMON_SFILES): Use observable.c, not observer.c.
4868         * .gitignore: Remove observer.h.
4869
4870 2018-03-18  Tom Tromey  <tom@tromey.com>
4871
4872         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4873         gdb::def_vector.
4874         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
4875
4876 2018-03-17  Tom Tromey  <tom@tromey.com>
4877
4878         * auto-load.c (auto_load_objfile_script_1): Use std::string.
4879
4880 2018-03-17  Tom Tromey  <tom@tromey.com>
4881
4882         * target.c (class scoped_target_fd): New.
4883         (target_fileio_close_cleanup): Remove.
4884         (target_fileio_read_alloc_1): Use scoped_target_fd.
4885
4886 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
4887
4888         * silent-rules.mk: New.
4889         * Makefile.in: Include silent-rules.mk
4890         (srcdir, VPATH, top_srcdir): Move up.
4891         (COMPILE): Add ECHO_CXX.
4892         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
4893         (init.c): Add ECHO_INIT_C.
4894         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
4895         (version.c): Add ECHO_GEN.
4896         (printcmd.o): Add ECHO_CXX.
4897         (target-float.o): Add ECHO_CXX.
4898         (ada-exp.o): Add ECHO_CXX.
4899         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
4900         (insight$(EXEEXT)): Add ECHO_CXXLD.
4901         * gnulib/configure.ac: Add AM_SILENT_RULES.
4902         * gnulib/aclocal.m4: Re-generate.
4903         * gnulib/configure: Re-generate.
4904         * gnulib/import/Makefile.in: Re-generate.
4905
4906 2018-03-16  Tom Tromey  <tom@tromey.com>
4907
4908         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
4909         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
4910         * utils.c (do_free_section_addr_info)
4911         (make_cleanup_free_section_addr_info): Remove.
4912         * symfile.h (struct other_sections): Add constructor.
4913         (struct section_addr_info): Remove.
4914         (section_addr_info): New typedef.
4915         (struct sym_fns) <sym_offsets>: Change type of parameter.
4916         (build_section_addr_info_from_objfile)
4917         (relative_addr_info_to_section_offsets, addr_info_make_relative)
4918         (default_symfile_offsets, symbol_file_add)
4919         (symbol_file_add_from_bfd)
4920         (build_section_addr_info_from_section_table): Update.
4921         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4922         * symfile.c (alloc_section_addr_info): Remove.
4923         (build_section_addr_info_from_section_table): Change return type.
4924         Update.
4925         (build_section_addr_info_from_bfd)
4926         (build_section_addr_info_from_objfile): Likewise.
4927         (free_section_addr_info): Remove.
4928         (relative_addr_info_to_section_offsets): Change type of "addrs".
4929         (addrs_section_compar): Now a std::sort comparator.
4930         (addrs_section_sort): Change return type.
4931         (addr_info_make_relative): Change type of "addrs".  Update.
4932         (default_symfile_offsets, syms_from_objfile_1)
4933         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4934         (symbol_file_add_separate): Update.
4935         (symbol_file_add): Change type of "addrs".  Update.
4936         (add_symbol_file_command): Update.  Remove cleanups.
4937         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4938         cleanups.
4939         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4940         * solib.c (solib_read_symbols): Update.
4941         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4942         * machoread.c (macho_symfile_offsets): Update.
4943         * jit.c (jit_bfd_try_read_symtab): Update.
4944
4945 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4946
4947         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4948         unittests/utils-selftests.c.
4949         * unittests/utils-selftests.c: New file.
4950
4951 2018-03-14  Tom Tromey  <tom@tromey.com>
4952
4953         PR cli/14977:
4954         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4955         for NULL.
4956
4957 2018-03-14  Tom Tromey  <tom@tromey.com>
4958
4959         PR cli/19918:
4960         * printcmd.c (printf_pointer): Allow "-" in format.
4961
4962 2018-03-14  Tom Tromey  <tom@tromey.com>
4963
4964         * printcmd.c (_initialize_printcmd): Add usage to printf.
4965
4966 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4967
4968         * MAINTAINERS: Update my email address.
4969
4970 2018-03-13  Tom Tromey  <tom@tromey.com>
4971
4972         * machoread.c (macho_check_dsym): Change filenamep to a
4973         std::string*.
4974         (macho_symfile_read): Update.
4975         * symfile.c (load_command): Use std::string.
4976
4977 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4978
4979         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4980         to error message string.
4981         (riscv_register_name): Use xsnprintf instead of sprintf.
4982         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4983         internal_error.
4984         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4985         error.
4986         (riscv_push_dummy_call): Likewise.
4987
4988 2018-03-12  Tom Tromey  <tom@tromey.com>
4989
4990         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4991         Use gdb::byte_vector.
4992         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4993
4994 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4995
4996         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4997         parameter type to readable_regcache.
4998         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4999         the declaration.
5000
5001 2018-03-11  Tom Tromey  <tom@tromey.com>
5002
5003         * dwarf2read.c (struct nextfield): Add initializers.
5004         (struct nextfnfield): Remove.
5005         (struct fnfieldlist): Add initializers.  Remove "length" and
5006         "head", use std::vector.
5007         (struct decl_field_list): Remove.
5008         (struct field_info): Add initializers.
5009         <fields, baseclasses>: Now std::vector.
5010         <nbaseclasses, nfnfields, typedef_field_list_count,
5011         nested_types_list_count>: Remove.
5012         (dwarf2_add_field, dwarf2_add_type_defn)
5013         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
5014         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
5015         (process_structure_scope): Update.
5016
5017 2018-03-11  Tom Tromey  <tom@tromey.com>
5018
5019         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
5020         for use by std::sort.
5021         (build_type_psymtabs_1): Use std::vector.
5022
5023 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
5024
5025         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
5026         and LIBMPFR in the printed configuration.
5027
5028 2018-03-08  Tom Tromey  <tom@tromey.com>
5029
5030         * source.c (get_filename_and_charpos): Use scoped_fd.
5031         * nto-procfs.c (procfs_open_1): Use scoped_fd.
5032         (procfs_pidlist): Likewise.
5033         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
5034         (iterate_over_mappings): Likewise.
5035
5036 2018-03-08  Tom Tromey  <tom@tromey.com>
5037
5038         * infcall.c (struct call_return_meta_info)
5039         <stack_temporaries_enabled>: Remove.
5040         (get_call_return_value, call_function_by_hand_dummy): Update.
5041         * thread.c (disable_thread_stack_temporaries): Remove.
5042         (enable_thread_stack_temporaries): Remove.
5043         (thread_stack_temporaries_enabled_p): Return bool.
5044         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
5045         (get_last_thread_stack_temporary): Update.
5046         * eval.c (evaluate_subexp): Update.
5047         * gdbthread.h (class enable_thread_stack_temporaries): Now a
5048         class, not a function.
5049         (value_ptr, value_vec): Remove typedefs.
5050         (class thread_info) <stack_temporaries_enabled>: Now bool.
5051         <stack_temporaries>: Now a std::vector.
5052         (thread_stack_temporaries_enabled_p)
5053         (value_in_thread_stack_temporaries): Return bool.
5054
5055 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
5056
5057         * remote.c (putpkt_binary): Fix omitted bytes reporting.
5058         (getpkt_or_notif_sane_1): Likewise.
5059
5060 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5061
5062         * build-id.c (build_id_to_debug_bfd): Use std::string.
5063
5064 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5065
5066         * build-id.c (find_separate_debug_file_by_buildid): Return
5067         std::string.
5068         * build-id.h (find_separate_debug_file_by_buildid): Return
5069         std::string.
5070         * coffread.c (coff_symfile_read): Adjust to std::string.
5071         * elfread.c (elf_symfile_read): Adjust to std::string.
5072         * symfile.c (separate_debug_file_exists): Change parameter to
5073         std::string.
5074         (find_separate_debug_file): Return std::string.
5075         (find_separate_debug_file_by_debuglink): Return std::string.
5076         * symfile.h (find_separate_debug_file_by_debuglink): Return
5077         std::string.
5078
5079 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5080
5081         * common/xml-utils.c (xml_escape_text): Move code to...
5082         (xml_escape_text_append): ... this new function.
5083         * common/xml-utils.h (xml_escape_text_append): New declaration.
5084         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
5085         New function.
5086         (_initialize_xml_utils): register test_xml_escape_text_append as
5087         a selftest.
5088
5089 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
5090
5091         * defs.h: Remove MAX_REGISTER_SIZE.
5092         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
5093         asserts.
5094         * python/py-unwind.c (pyuw_sniffer): Likewise.
5095
5096 2018-03-07  Tom Tromey  <tom@tromey.com>
5097
5098         * linux-tdep.c (linux_info_proc): Update.
5099         * target.h (struct target_ops) <to_fileio_readlink>: Return
5100         optional<string>.
5101         (target_fileio_readlink): Return optional<string>.
5102         * remote.c (remote_hostio_readlink): Return optional<string>.
5103         * inf-child.c (inf_child_fileio_readlink): Return
5104         optional<string>.
5105         * target.c (target_fileio_readlink): Return optional<string>.
5106
5107 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5108
5109         * regcache.c (cooked_read_test): Add riscv to the list of
5110         architectures that have a save_reggroup.
5111
5112 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5113
5114         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
5115         value is not a dynamic class object.
5116
5117 2018-03-06  Tom Tromey  <tom@tromey.com>
5118
5119         * rust-exp.y: Formatting fixes.
5120
5121 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5122
5123         * riscv-tdep.c (riscv_register_name): Remove target description
5124         support.
5125         (riscv_gdbarch_init): Remove target description check.
5126
5127 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5128
5129         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
5130         comment.
5131         * riscv-tdep.h: Likewise.
5132
5133 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5134
5135         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
5136         (riscv_pseudo_register_write): Delete.
5137         (riscv_gdbarch_init): Remove all use of pseudo registers.
5138
5139 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5140
5141         * record-btrace.c (btrace_print_lines): Replace cleanup
5142         parameter with RAII equivalents.
5143         (btrace_insn_history): Replace cleanup with RAII equivalents.
5144         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5145         make_cleanup_ui_out_tuple_begin_end): Remove.
5146         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5147         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5148         make_cleanup_ui_out_list_begin_end): Remove.
5149
5150 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5151
5152         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5153         parameter types to std::vector.  Use bool.
5154         (record_btrace_wait): Replace VEC(tp_t) with
5155         std::vector<thread_info *>.
5156         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5157
5158 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5159
5160         * record-btrace.c (record_btrace_disable_callback): Remove.
5161         (struct scoped_btrace_disable): New.
5162         (record_btrace_open): Use scoped_btrace_disable.
5163
5164 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5167         reading values from registers.
5168
5169 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5172         where appropriate.
5173
5174 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5175
5176         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5177         change parameter type.  Use GDB's print functions, and use
5178         core_addr_to_string where appropriate.
5179         (riscv_push_dummy_call): Use core_addr_to_string where
5180         appropriate, update call to riscv_print_arg_location, and reindent
5181         a few lines.
5182         (riscv_return_value): Update call to riscv_print_arg_location.
5183
5184 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5185             Tim Newsome <tim@sifive.com>
5186             Albert Ou <a0u@eecs.berkeley.edu>
5187             Darius Rad <darius@bluespec.com>
5188
5189         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5190         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5191         (ALLDEPFILES): Add riscv-tdep.c
5192         * configure.tgt: Add riscv support.
5193         * riscv-tdep.c: New file.
5194         * riscv-tdep.h: New file.
5195         * NEWS: Mention new target.
5196         * MAINTAINERS: Add entry for riscv.
5197
5198 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5199
5200         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5201         fields within aggregates.
5202
5203 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5204
5205         * record-btrace.c (btrace_print_lines): Change type of flags to
5206         gdb_disassembly_flags.
5207
5208 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5209
5210         * fbsd-nat.c: Include "inf-ptrace.h".
5211         (USE_SIGTRAP_SIGINFO): Conditionally define.
5212         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5213         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5214         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5215         function.
5216         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5217         Likewise.
5218         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5219         Likewise.
5220         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5221         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5222         "supports_stopped_by_hw_breakpoint" target methods.
5223
5224 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5225
5226         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5227         * fbsd-nat.c (debug_fbsd_nat): New variable.
5228         (show_fbsd_nat_debug): New function.
5229         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5230         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5231
5232 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5233
5234         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5235         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5236         prototype.
5237         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5238         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5239         method.
5240
5241 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5242
5243         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5244         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5245
5246 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5247
5248         * charset.c (struct charset_vector): New.
5249         (charsets): Change type to charset_vector.
5250         (find_charset_names): Adjust.
5251         (add_one): Adjust.
5252         (_initialize_charset): Adjust.
5253
5254 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5255
5256         * progspace.h (struct program_space) <deleted_solibs>: Change
5257         type to std::vector<std::string>.
5258         * progspace.c (clear_program_space_solib_cache): Adjust.
5259         * breakpoint.c (print_solib_event): Adjust.
5260         (check_status_catch_solib): Adjust.
5261         * solib.c (update_solib_list): Adjust.
5262         * ui-out.h (class ui_out) <field_string>: New overload.
5263         * ui-out.c (ui_out::field_string): New overload.
5264
5265 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5266
5267         * progspace.h (struct program_space): Add constructor and
5268         destructor, initialize fields.
5269         (add_program_space): Remove.
5270         * progspace.c (add_program_space): Rename to...
5271         (program_space::program_space): ... this.
5272         (release_program_space): Rename to...
5273         (program_space::~program_space): ... this.
5274         (delete_program_space): Use delete to delete program_space.
5275         (initialize_progspace): Use new to allocate program_space.
5276         * inferior.c (add_inferior_with_spaces): Likewise.
5277         (clone_inferior_command): Likewise.
5278         * infrun.c (follow_fork_inferior): Likewise.
5279         (handle_vfork_child_exec_or_exit): Likewise.
5280
5281 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5282
5283         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5284         (delim_string_to_char_ptr_vec): Return std::vector of
5285         gdb::unique_xmalloc_ptr.
5286         (dirnames_to_char_ptr_vec_append): Take std::vector of
5287         gdb::unique_xmalloc_ptr.
5288         (dirnames_to_char_ptr_vec): Return std::vector of
5289         gdb::unique_xmalloc_ptr.
5290         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5291         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5292         (delim_string_to_char_ptr_vec): Return an std::vector of
5293         gdb::unique_xmalloc_ptr, adjust the code.
5294         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5295         gdb::unique_xmalloc_ptr, adjust the code.
5296         (dirnames_to_char_ptr_vec): Return an std::vector of
5297         gdb::unique_xmalloc_ptr, adjust the code.
5298         * auto-load.c (auto_load_safe_path_vec): Change type to
5299         std::vector of gdb::unique_xmalloc_ptr.
5300         (auto_load_expand_dir_vars): Return an std::vector of
5301         gdb::unique_xmalloc_ptr, adjust the code.
5302         (auto_load_safe_path_vec_update): Adjust.
5303         (filename_is_in_auto_load_safe_path_vec): Adjust.
5304         (auto_load_objfile_script_1): Adjust.
5305         * build-id.c (build_id_to_debug_bfd): Adjust.
5306         * linux-thread-db.c (thread_db_load_search): Adjust.
5307         * source.c (add_path): Adjust.
5308         (openp): Adjust.
5309         * symfile.c (find_separate_debug_file): Adjust.
5310         * utils.c (do_free_char_ptr_vec): Remove.
5311         (make_cleanup_free_char_ptr_vec): Remove.
5312
5313 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5314
5315         PR gdb/22907
5316         * common/pathstuff.c: Conditionally include "<windows.h>".
5317
5318 2018-03-01  Georg Sauthoff  <mail@georg.so>
5319
5320         PR gdb/22888
5321         * gcore.in: Quote variables and switch interpreter to bash.
5322
5323 2018-03-01  Tom Tromey  <tom@tromey.com>
5324
5325         * dwarf2read.c (alloc_discriminant_info): Fix default_index
5326         assertion.  Add assertion for discriminant_index.
5327         (quirk_rust_enum): Use correct base type name in univariant case.
5328
5329 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
5330
5331         * record.c (get_call_history_modifiers): Return a
5332         record_print_flags.
5333         (cmd_record_call_history): Adjust.
5334         * record-btrace.c (record_btrace_call_history): Adjust.
5335         (record_btrace_call_history_range): Adjust.
5336         (record_btrace_call_history_from): Adjust.
5337         * target-debug.h (target_debug_print_record_print_flags): New.
5338         * target-delegates.c: Re-generate.
5339         * target.c (target_call_history): Change flags type.
5340         (target_call_history_from): Likewise.
5341         (target_call_history_range): Likewise.
5342         * target.h (struct target_ops) <target_call_history>: Likewise.
5343         (target_call_history_from): Likewise.
5344         (target_call_history_range): Likewise.
5345
5346 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5347             Simon Marchi  <simon.marchi@polymtl.ca>
5348
5349         * common/common-utils.c: Include "sys/stat.h".
5350         (is_regular_file): Move here from "source.c"; change return
5351         type to "bool".
5352         * common/common-utils.h (is_regular_file): New prototype.
5353         * common/pathstuff.c (contains_dir_separator): New function.
5354         * common/pathstuff.h (contains_dir_separator): New prototype.
5355         * source.c: Don't include "sys/stat.h".
5356         (is_regular_file): Move to "common/common-utils.c".
5357
5358 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5359
5360         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5361         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5362         * auto-load.c: Include "common/pathstuff.h".
5363         * common/common-def.h (current_directory): Move here.
5364         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5365         function.
5366         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5367         prototype.
5368         * common/pathstuff.c: New file.
5369         * common/pathstuff.h: New file.
5370         * compile/compile.c: Include "common/pathstuff.h".
5371         * defs.h (current_directory): Move to "common/common-defs.h".
5372         * dwarf2read.c: Include "common/pathstuff.h".
5373         * exec.c: Likewise.
5374         * guile/scm-safe-call.c: Likewise.
5375         * linux-thread-db.c: Likewise.
5376         * main.c: Likewise.
5377         * nto-tdep.c: Likewise.
5378         * objfiles.c: Likewise.
5379         * source.c: Likewise.
5380         * symtab.c: Likewise.
5381         * utils.c: Include "common/pathstuff.h".
5382         (gdb_realpath): Move to "common/pathstuff.c".
5383         (gdb_realpath_keepfile): Likewise.
5384         (gdb_abspath): Likewise.
5385         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5386         (gdb_realpath_keepfile): Likewise.
5387         (gdb_abspath): Likewise.
5388
5389 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5390
5391         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5392         wildcard process pid for super_resume for kernels with a
5393         specific bug.
5394
5395 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5396
5397         * compile/compile.c (get_args): Add additional comments
5398         explaining function.
5399
5400 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5401             Tom Tromey  <tom@tromey.com>
5402
5403         * target.h (memory_write_request_s): Remove typedef.  Don't define
5404         VEC.
5405         (target_write_memory_blocks): Change argument to std::vector.
5406         (struct memory_write_request): Add constructor.
5407         * target-memory.c (compare_block_starting_address): Return bool.
5408         Change argument types.
5409         (claim_memory): Change arguments to use std::vector.
5410         (split_regular_and_flash_blocks, blocks_to_erase)
5411         (compute_garbled_blocks): Likewise.
5412         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5413         (target_write_memory_blocks): Change argument to std::vector.
5414         * symfile.c (struct load_section_data): Add constructor and
5415         destructor.  Use std::vector for "requests".
5416         (struct load_progress_data): Add initializers.
5417         (load_section_callback): Update.  Use "new".
5418         (clear_memory_write_data): Remove.
5419         (generic_load): Update.
5420
5421 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5422
5423         * arch/aarch64.h: Use common/tdesc.h.
5424
5425 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5426
5427         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5428         architecture with a 64-bit ABI.
5429
5430 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5431
5432         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5433         ahead of target description loading.
5434
5435 2018-02-26  Tom Tromey  <tom@tromey.com>
5436
5437         * stack.c (backtrace_command_1): Update.
5438         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5439         of "flags".
5440         * python/py-framefilter.c (py_print_frame)
5441         (gdbpy_apply_frame_filter): Change type of "flags".
5442         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5443         of "flags".
5444         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5445         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5446         * extension.h (enum frame_filter_flag): Rename from
5447         frame_filter_flags.
5448         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5449         (apply_ext_lang_frame_filter): Change type of "flags".
5450         * extension.c (apply_ext_lang_frame_filter): Change type of
5451         "flags".
5452         * extension-priv.h (struct extension_language_ops)
5453         <apply_frame_filter>: Change type of "flags".
5454
5455 2018-02-26  Tom Tromey  <tom@tromey.com>
5456
5457         PR python/16497:
5458         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5459         off-by-one in py_end computation.
5460         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5461         PRINT_MORE_FRAMES.
5462         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5463         constant.
5464
5465 2018-02-26  Tom Tromey  <tom@tromey.com>
5466
5467         * dwarf2read.c (struct variant_field): New.
5468         (struct nextfield) <variant>: New field.
5469         (dwarf2_add_field): Handle DW_TAG_variant_part.
5470         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5471         discriminated union.
5472         (read_structure_type): Handle DW_TAG_variant_part.
5473         (handle_struct_member_die): New function, extracted from
5474         process_structure_scope.  Handle DW_TAG_variant.
5475         (process_structure_scope): Handle discriminated unions.  Call
5476         handle_struct_member_die.
5477
5478 2018-02-26  Tom Tromey  <tom@tromey.com>
5479
5480         * rust-lang.h (rust_last_path_segment): Declare.
5481         * rust-lang.c (rust_last_path_segment): Now public.  Change
5482         contract.
5483         (struct disr_info): Remove.
5484         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5485         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5486         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5487         (rust_enum_p, rust_enum_variant): New function.
5488         (rust_underscore_fields): Remove "offset" parameter.
5489         (rust_print_enum): New function.
5490         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5491         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5492         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5493         enums.
5494         (rust_internal_print_type): New function, from rust_print_type.
5495         Remove enum code.
5496         (rust_print_type): Call rust_internal_print_type.
5497         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5498         Update enum handling.
5499         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5500         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5501         (rust_union_quirks): New functions.
5502         (process_full_comp_unit, process_full_type_unit): Call
5503         rust_union_quirks.
5504         (process_structure_scope): Update rust_unions if necessary.
5505
5506 2018-02-26  Tom Tromey  <tom@tromey.com>
5507
5508         * value.h (value_union_variant): Declare.
5509         * valops.c (value_union_variant): New function.
5510         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5511         (struct discriminant_info): New.
5512         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5513         enumerator.
5514         (struct main_type) <flag_discriminated_union>: New field.
5515
5516 2018-02-26  Tom Tromey  <tom@tromey.com>
5517
5518         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5519         unittests/unpack-selftests.c.
5520         * unittests/unpack-selftests.c: New file.
5521         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5522
5523 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5524
5525         * dwarf2read.c (struct partial_die_info) <read>: New method.
5526         (read_partial_die): Remove the declaration.
5527         (load_partial_dies): Update.
5528         (partial_die_info::partial_die_info):
5529         (read_partial_die): Change it to partial_die_info::read.
5530
5531 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5532
5533         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5534         (fixup_partial_die): Remove declaration.
5535         (scan_partial_symbols): Update.
5536         (partial_die_parent_scope): Likewise.
5537         (partial_die_full_name): Likewise.
5538         (fixup_partial_die): Change it to partial_die_info::fixup.
5539
5540 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5541
5542         * dwarf2read.c (read_partial_die): Update the declaration.
5543         (load_partial_dies): Caller update.
5544         (read_partial_die): Remove one argument abbrev_len.
5545
5546 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5547
5548         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5549         assignment operator.
5550         (load_partial_dies): Use ctor and copy ctor.
5551         (read_partial_die): Update.
5552         (dwarf2_cu::find_partial_die): Use ctor.
5553
5554 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5555
5556         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5557         (find_partial_die_in_comp_unit): Change it to
5558         dwarf2_cu::find_partial_die.
5559         (find_partial_die): Update.
5560
5561 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5562
5563         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5564         is NULL.
5565
5566 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5567
5568         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5569
5570 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5571
5572         * arch/amd64.h: Use common/tdesc.h.
5573         * arch/i386.c: Likewise.
5574         * arch/i386.h: Likewise.
5575         * arch/tic6x.c: Likewise.
5576         * arch/tdesc.h: Move file from here...
5577         * common/tdesc.h: ...to here.
5578         * features/aarch64-core.c: Regenerate.
5579         * features/aarch64-fpu.c: Regenerate.
5580         * features/i386/32bit-avx.c: Regenerate.
5581         * features/i386/32bit-avx512.c: Regenerate.
5582         * features/i386/32bit-core.c: Regenerate.
5583         * features/i386/32bit-linux.c: Regenerate.
5584         * features/i386/32bit-mpx.c: Regenerate.
5585         * features/i386/32bit-pkeys.c: Regenerate.
5586         * features/i386/32bit-sse.c: Regenerate.
5587         * features/i386/64bit-avx.c: Regenerate.
5588         * features/i386/64bit-avx512.c: Regenerate.
5589         * features/i386/64bit-core.c: Regenerate.
5590         * features/i386/64bit-linux.c: Regenerate.
5591         * features/i386/64bit-mpx.c: Regenerate.
5592         * features/i386/64bit-pkeys.c: Regenerate.
5593         * features/i386/64bit-segments.c: Regenerate.
5594         * features/i386/64bit-sse.c: Regenerate.
5595         * features/i386/x32-core.c: Regenerate.
5596         * features/tic6x-c6xp.c: Regenerate.
5597         * features/tic6x-core.c: Regenerate.
5598         * features/tic6x-gp.c: Regenerate.
5599         * target-descriptions.c: Use common/tdesc.h.
5600         * target-descriptions.h: Likewise.
5601
5602 2018-02-24  Tom Tromey  <tom@tromey.com>
5603
5604         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5605         (try_thread_db_load_from_dir, thread_db_load_search): Use
5606         std::string.
5607         (info_auto_load_libthread_db_compare): Return bool.  Change
5608         argument types.
5609         (info_auto_load_libthread_db): Use std::vector, std::string.
5610         Remove cleanups.
5611
5612 2018-02-24  Tom Tromey  <tom@tromey.com>
5613
5614         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5615         std::string.
5616         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5617         std::string*.
5618         * gdbarch.c: Rebuild.
5619         * gdbarch.h: Rebuild.
5620         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5621         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5622         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5623         std::string*.
5624
5625 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5626
5627         * gdbtypes.h (sect_offset): Change type to uint64_t.
5628         (sect_offset_str): New function.
5629         * dwarf2read.c (create_addrmap_from_aranges): Use
5630         sect_offset_str.
5631         (error_check_comp_unit_head): Likewise.
5632         (create_debug_type_hash_table): Likewise.
5633         (read_cutu_die_from_dwo): Likewise.
5634         (init_cutu_and_read_dies): Likewise.
5635         (init_cutu_and_read_dies_no_follow): Likewise.
5636         (process_psymtab_comp_unit_reader): Likewise.
5637         (partial_die_parent_scope): Likewise.
5638         (peek_die_abbrev): Likewise.
5639         (process_queue): Likewise.
5640         (dwarf2_physname): Likewise.
5641         (read_namespace_alias): Likewise.
5642         (read_import_statement): Likewise.
5643         (create_dwo_cu_reader): Likewise.
5644         (create_cus_hash_table): Likewise.
5645         (lookup_dwo_cutu): Likewise.
5646         (inherit_abstract_dies): Likewise.
5647         (read_func_scope): Likewise.
5648         (read_call_site_scope): Likewise.
5649         (dwarf2_add_member_fn): Likewise.
5650         (read_common_block): Likewise.
5651         (read_module_type): Likewise.
5652         (read_typedef): Likewise.
5653         (read_subrange_type): Likewise.
5654         (load_partial_dies): Likewise.
5655         (read_partial_die): Likewise.
5656         (find_partial_die): Likewise.
5657         (read_str_index): Likewise.
5658         (dwarf2_string_attr): Likewise.
5659         (build_error_marker_type): Likewise.
5660         (lookup_die_type): Likewise.
5661         (dump_die_shallow): Likewise.
5662         (follow_die_ref): Likewise.
5663         (dwarf2_fetch_die_loc_sect_off): Likewise.
5664         (dwarf2_fetch_constant_bytes): Likewise.
5665         (follow_die_sig): Likewise.
5666         (get_signatured_type): Likewise.
5667         (get_DW_AT_signature_type): Likewise.
5668         (dwarf2_find_containing_comp_unit): Likewise.
5669         (set_die_type): Likewise.
5670
5671 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5672
5673         * arch/aarch64.c: Include "common-defs.h".
5674         * arch/amd64.c: Likewise.
5675         * arch/i386.c: Likewise.
5676
5677 2018-02-21  Tom Tromey  <tom@tromey.com>
5678
5679         * value.h: (extract_field_op): Update.
5680         * eval.c (extract_field_op): Return a const char *.
5681         * expression.h (parse_expression_for_completion): Update.
5682         * completer.c (complete_expression): Update.
5683         (add_struct_fields): Make fieldname const.
5684         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5685         (mark_completion_tag, parse_exp_in_context_1): Update.
5686         (parse_expression_for_completion): Change "name" to
5687         unique_xmalloc_ptr*.
5688
5689 2018-02-21  Tom Tromey  <tom@tromey.com>
5690
5691         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5692
5693 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5694
5695         * avr-tdep.c (avr_read_pc): Change parameter type to
5696         readable_regcache.
5697         * gdbarch.sh (read_pc): Likewise.
5698         * gdbarch.c: Re-generated.
5699         * gdbarch.h: Re-generated.
5700         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5701         readable_regcache.
5702         * ia64-tdep.c (ia64_read_pc): Likewise.
5703         * mips-tdep.c (mips_read_pc): Likewise.
5704         * spu-tdep.c (spu_read_pc): Likewise.
5705
5706 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5707
5708         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5709         * regcache-dump.c: New file.
5710         * regcache.c: Move register_dump to regcache-dump.c.
5711         (maintenance_print_registers): Likewise.
5712         (maintenance_print_raw_registers): Likewise.
5713         (maintenance_print_cooked_registers): Likewise.
5714         (maintenance_print_register_groups): Likewise.
5715         (maintenance_print_remote_registers): Likewise.
5716         (_initialize_regcache): Likewise.
5717         * regcache.h (register_dump): Moved from regcache.c.
5718
5719 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5720
5721         * regcache.c (regcache::regcache): Update.
5722         (regcache::invalidate): Move it to detached_regcache::invalidate.
5723         (get_thread_arch_aspace_regcache): Update.
5724         (regcache::raw_update): Update.
5725         (regcache::cooked_read): Remove some code.
5726         (regcache::cooked_read_value): Likewise.
5727         (regcache::raw_write): Remove assert on m_readonly_p.
5728         (regcache::raw_supply_integer): Move it to
5729         detached_regcache::raw_supply_integer.
5730         (regcache::raw_supply_zeroed): Likewise.
5731         * regcache.h (detached_regcache) <raw_supply_integer>: New
5732         declaration.
5733         <raw_supply_zeroed, invalidate>: Likewise.
5734         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5735         <invalidate>: Likewise.
5736         <m_readonly_p>: Removed.
5737
5738 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5739
5740         * infcmd.c (get_return_value): Let stop_regs point to
5741         get_current_regcache.
5742         * regcache.c (regcache::regcache): Remove.
5743         (register_dump_reg_buffer): New class.
5744         (regcache_print): Adjust.
5745         * regcache.h (regcache): Remove constructors.
5746
5747 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5748
5749         * regcache.c (class register_dump): New class.
5750         (register_dump_regcache, register_dump_none): New class.
5751         (register_dump_remote, register_dump_groups): New class.
5752         (regcache_print): Update.
5753         * regcache.h (regcache_dump_what): Move it to regcache.c.
5754         (regcache) <dump>: Remove.
5755
5756 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5757
5758         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5759          reg_buffer_rw *.
5760         (jit_unwind_reg_set_impl): Call raw_supply.
5761         (jit_frame_sniffer): Use reg_buffer_rw.
5762         * record-full.c (record_full_core_regbuf): Change its type.
5763         (record_full_core_open_1): Use reg_buffer_rw.
5764         (record_full_close): Likewise.
5765         (record_full_core_fetch_registers): Use regcache->raw_supply.
5766         (record_full_core_store_registers): Likewise.
5767         * regcache.c (regcache::get_register_status): Move it to
5768         reg_buffer.
5769         (regcache_raw_set_cached_value): Remove.
5770         (regcache::raw_set_cached_value): Remove.
5771         (regcache::raw_write): Call raw_supply.
5772         (regcache::raw_supply): Move it to reg_buffer_rw.
5773         * regcache.h (regcache_raw_set_cached_value): Remove.
5774         (reg_buffer_rw): New class.
5775
5776 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5777
5778         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5779         readonly_detached_regcache.
5780         (dummy_frame_prev_register): Use regcache->cooked_read.
5781         * frame.c (frame_save_as_regcache): Change return type.
5782         (frame_pop): Update.
5783         * frame.h (frame_save_as_regcache): Update declaration.
5784         * inferior.h (get_infcall_suspend_state_regcache): Update
5785         declaration.
5786         * infrun.c (infcall_suspend_state) <registers>: use
5787         readonly_detached_regcache.
5788         (save_infcall_suspend_state): Don't use regcache_dup.
5789         (get_infcall_suspend_state_regcache): Change return type.
5790         * linux-fork.c (struct fork_info) <savedregs>: Change to
5791         readonly_detached_regcache.
5792         <pc>: New field.
5793         (fork_save_infrun_state): Don't use regcache_dup.
5794         (info_checkpoints_command): Adjust.
5795         * mi/mi-main.c (register_changed_p): Update declaration.
5796         (mi_cmd_data_list_changed_registers): Use
5797         readonly_detached_regcache.
5798         (register_changed_p): Change parameter type to
5799         readonly_detached_regcache.
5800         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5801         readonly_detached_regcache.
5802         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5803         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5804         New.
5805         (regcache::save): Move it to reg_buffer.
5806         (regcache::restore): Change parameter type.
5807         (regcache_dup): Remove.
5808         * regcache.h (reg_buffer) <save>: New method.
5809         (readonly_detached_regcache): New class.
5810         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5811         readonly_detached_regcache.
5812         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5813
5814 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5815
5816         * frame.c (frame_save_as_regcache): Use regcache method save.
5817         (frame_pop): Use regcache method restore.
5818         * infrun.c (restore_infcall_suspend_state): Likewise.
5819         * linux-fork.c (fork_load_infrun_state): Likewise.
5820         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5821         save.
5822         * regcache.c (regcache_save): Remove.
5823         (regcache::restore): More asserts.
5824         (regcache_cpy): Remove.
5825         * regcache.h (regcache_save): Remove the declaration.
5826         (regcache::restore): Move from private to public.
5827         Remove the friend declaration of regcache_cpy.
5828         (regcache_cpy): Remove declaration.
5829
5830 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5831
5832         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5833         parameter type to 'readable_regcache *'.
5834         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5835         * arm-tdep.c (arm_neon_quad_read): Likewise.
5836         (arm_pseudo_read): Likewise.
5837         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5838         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5839         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5840         * gdbarch.c: Re-generated.
5841         * gdbarch.h: Re-generated.
5842         * gdbarch.sh (pseudo_register_read): Change parameter type to
5843         'readable_regcache *'.
5844         (pseudo_register_read_value): Likewise.
5845         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5846         (h8300_pseudo_register_read): Likewise.
5847         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5848         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5849         (i386_pseudo_register_read_into_value): Likewise.
5850         (i386_pseudo_register_read_value): Likewise.
5851         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5852         declaration.
5853         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5854         * m32c-tdep.c (m32c_raw_read): Likewise.
5855         (m32c_read_flg): Likewise.
5856         (m32c_banked_register): Likewise.
5857         (m32c_banked_read): Likewise.
5858         (m32c_sb_read): Likewise.
5859         (m32c_part_read): Likewise.
5860         (m32c_cat_read): Likewise.
5861         (m32c_r3r2r1r0_read): Likewise.
5862         (m32c_pseudo_register_read): Likewise.
5863         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5864         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5865         (mep_pseudo_cr64_read): Likewise.
5866         (mep_pseudo_register_read): Likewise.
5867         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5868         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5869         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5870         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5871         (regcache::cooked_read): Likewise.
5872         (regcache::cooked_read_value): Likewise.
5873         (regcache_cooked_read_signed):
5874         (regcache::cooked_read): Likewise.
5875         * regcache.h (readable_regcache): New class.
5876         (regcache): Inherit readable_regcache.  Move some methods to
5877         readable_regcache.
5878         * rl78-tdep.c (rl78_pseudo_register_read): Change
5879         parameter type to 'readable_regcache *'.
5880         * rs6000-tdep.c (do_regcache_raw_read): Remove.
5881         (e500_pseudo_register_read): Change parameter type to
5882         'readable_regcache *'.
5883         (dfp_pseudo_register_read): Likewise.
5884         (vsx_pseudo_register_read): Likewise.
5885         (efpr_pseudo_register_read): Likewise.
5886         * s390-tdep.c (s390_pseudo_register_read): Likewise.
5887         * sh-tdep.c (sh_pseudo_register_read): Likewise.
5888         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
5889         (sh64_pseudo_register_read): Likewise.
5890         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
5891         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5892         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
5893         (spu_pseudo_register_read): Likewise.
5894         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5895         (xtensa_pseudo_register_read): Likewise.
5896
5897 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5898
5899         * regcache.c (regcache::regcache): Call reg_buffer ctor.
5900         (regcache::arch): Move it to reg_buffer::arch.
5901         (regcache::register_buffer): Likewise.
5902         (regcache::assert_regnum): Likewise.
5903         (regcache::num_raw_registers): Likewise.
5904         * regcache.h (reg_buffer): New class.
5905         (regcache): Inherit reg_buffer.
5906
5907 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
5908
5909         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
5910         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
5911
5912 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
5913
5914         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
5915
5916 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
5917
5918         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5919         (SFILES): Remove common/*.c files.
5920         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5921         * common/common.host: Add common reference.
5922         * configure.ac: Likewise.
5923         * configure: Regenerate.
5924
5925 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5926
5927         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5928         (block_initialize_namespace): Use new.
5929         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5930         (dwarf2_free_objfile): Use delete.
5931         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5932         (copy_type_recursive): Use new.
5933         * gdb_obstack.h (allocate_on_obstack): New.
5934
5935 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5936
5937         PR gdb/22849
5938         * inferior.c (exit_inferior_1): Reset inf->control.
5939
5940 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5941
5942         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5943         declaration.
5944
5945 2018-02-14  Pedro Alves  <palves@redhat.com>
5946
5947         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5948         frame_cleanup_after_sniffer on exception.
5949
5950 2018-02-14  Tom Tromey  <tom@tromey.com>
5951
5952         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5953         const.
5954         (solib_bfd_open): Make pathname const.
5955         * solib.c (solib_bfd_open): Make pathname const.
5956         * solib-spu.c (spu_bfd_fopen): Make name const.
5957         (spu_bfd_open): Make pathname const.
5958         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5959         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5960
5961 2018-02-14  Tom Tromey  <tom@tromey.com>
5962
5963         * symfile.c (symfile_bfd_open): Update.
5964         * source.h (openp, source_full_path_of, find_and_open_source):
5965         Change argument type to unique_xmalloc_ptr.
5966         * source.c (openp): Take a unique_xmalloc_ptr.
5967         (source_full_path_of, find_and_open_source): Likewise.
5968         (open_source_file, symtab_to_fullname): Update.
5969         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5970         unique_xmalloc_ptr.
5971         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5972         (exec_file_find): Update.
5973         * psymtab.c (psymtab_to_fullname): Update.
5974         * nto-tdep.h (nto_find_and_open_solib): Update.
5975         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5976         unique_xmalloc_ptr.
5977         * exec.c (exec_file_attach): Update.
5978         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5979         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5980
5981 2018-02-14  Tom Tromey  <tom@tromey.com>
5982
5983         * solib.c: Include source.h.
5984         * nto-tdep.c: Include source.h.
5985         * mi/mi-cmd-env.c: Include source.h.
5986         * infcmd.c: Include source.h.
5987         * exec.c: Include source.h.
5988         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5989         (add_path, directory_switch, source_path, init_source_path): Move
5990         declarations...
5991         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5992         (add_path, directory_switch, source_path, init_source_path):
5993         ...here.
5994
5995 2018-02-14  Tom Tromey  <tom@tromey.com>
5996
5997         * solist.h (exec_file_find, solib_find): Return
5998         unique_xmalloc_ptr.
5999         (solib_bfd_fopen): Take a const char *.
6000         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
6001         (exec_file_find, solib_find): Likewise.
6002         (solib_bfd_fopen): Do not take ownership of "pathname".
6003         (solib_bfd_open): Use unique_xmalloc_ptr.
6004         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
6005         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
6006         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
6007         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
6008
6009 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
6010
6011         * ada-lang.c (name_match_type_from_name): Remove reference to
6012         ada_name_for_lookup in function's documentation.
6013         * ada-lang.h (ada_name_for_lookup): Delete declaration.
6014
6015 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6016
6017         * defs.h (enum openp_flags): New enum.
6018         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
6019         Move to enum openp_flags.
6020         (openp_flags): New enum flags.
6021         (openp): Change parameter type to openp_flags.
6022         * source.c (openp): Change parameter type to openp_flags.
6023         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
6024         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
6025
6026 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6027
6028         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
6029         per-command.
6030
6031 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6032
6033         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
6034         into...
6035         (class dwarf2_queue_guard): ...the destructor of this new class.
6036         (dw2_do_instantiate_symtab): Create instance of the new class
6037         dwarf2_queue_guard, remove cleanup.
6038
6039 2018-02-09  Tom Tromey  <tom@tromey.com>
6040
6041         * source.c (find_source_lines): Don't reference past the end of
6042         the vector.
6043
6044 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6045
6046         * remote.c (remote_btrace_maybe_reopen): Change error message.
6047         * btrace.c (btrace_enable): Likewise.
6048         (parse_xml_btrace): Likewise.
6049         (parse_xml_btrace_conf): Likewise.
6050
6051 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6052
6053         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
6054         (linux_enable_pt, linux_enable_bts): Call
6055         diagnose_perf_event_open_fail.
6056
6057 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6058
6059         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
6060         Remove parameter and change return type.  Update callers.  Move it.
6061         (linux_enable_bts, linux_enable_pt): Improve error message.
6062         (linux_enable_pt): Remove zero buffer size check.
6063         (linux_enable_btrace): Improve error messages.  Remove NULL return
6064         check.
6065
6066 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6067
6068         * btrace.c (btrace_enable): Remove target_supports_btrace call.
6069         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
6070         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
6071         (linux_supports_pt, linux_supports_btrace): Remove.
6072         (linux_enable_bts): Call cpu_supports_bts.
6073         * nat/linux-btrace.h (linux_supports_btrace): Remove.
6074         * remote.c (remote_supports_btrace): Remove.
6075         (init_remote_ops): Remove remote_supports_btrace.
6076         * target-delegates.c: Regenerated.
6077         * target.c (target_supports_btrace): Remove.
6078         * target.h (target_ops) <to_supports_btrace>: Remove
6079         (target_supports_btrace): Remove.
6080         * x86-linux-nat.c (x86_linux_create_target): Remove
6081         linux_supports_btrace.
6082
6083 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6084
6085         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
6086         btrace failed.
6087         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
6088         exception and use message in own exception.
6089
6090 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6091
6092         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
6093         (perf_event_pt_event_type): Use gdb_file_up.
6094         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
6095         scoped_fd, and scoped_mmap.
6096
6097 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6098
6099         * common/scoped_mmap.h: New.
6100         * unittests/scoped_mmap-selftest.c: New.
6101         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6102         unittests/scoped_mmap-selftest.c.
6103
6104 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6105
6106         * common/scoped_fd.h: New.
6107         * unittests/scoped_fd-selftest.c: New.
6108         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6109         unittests/scoped_fd-selftest.c.
6110
6111 2018-02-09  Tom Tromey  <tom@tromey.com>
6112
6113         * auto-load.c (auto_load_section_scripts): Use
6114         gdb::unique_xmalloc_ptr.
6115
6116 2018-02-09  Tom Tromey  <tom@tromey.com>
6117
6118         * auto-load.c (execute_script_contents): Use std::string.
6119
6120 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
6121
6122         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
6123         Python function, rather than a new command.
6124
6125 2018-02-08  Tom Tromey  <tom@tromey.com>
6126
6127         * solib.c (solib_find_1): Use std::string.
6128         (solib_bfd_fopen): Use unique_xmalloc_ptr.
6129
6130 2018-02-08  Tom Tromey  <tom@tromey.com>
6131
6132         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
6133
6134 2018-02-08  Tom Tromey  <tom@tromey.com>
6135
6136         * source.c (find_source_lines): Use gdb::def_vector.
6137
6138 2018-02-08  Tom Tromey  <tom@tromey.com>
6139
6140         * macrocmd.c (struct temporary_macro_definition): New.
6141         (macro_define_command): Use temporary_macro_definition.  Remove
6142         cleanups.
6143         (free_macro_definition_ptr): Remove.
6144
6145 2018-02-08  Tom Tromey  <tom@tromey.com>
6146
6147         * macroexp.c (maybe_expand): Use std::string.
6148
6149 2018-02-08  Tom Tromey  <tom@tromey.com>
6150
6151         * macroexp.c (struct macro_buffer): Add initializers for some
6152         members.
6153         (init_buffer, init_shared_buffer, free_buffer)
6154         (free_buffer_return_text): Remove.
6155         (macro_buffer): New constructors.
6156         (~macro_buffer): New destructor.
6157         (macro_buffer::set_shared): New method.
6158         (macro_buffer::resize_buffer, macro_buffer::appendc)
6159         (macro_buffer::appendmem): Now methods, not free functions.
6160         (set_token, append_tokens_without_splicing, stringify)
6161         (macro_stringify): Update.
6162         (gather_arguments): Change return type.  Remove argc_p argument,
6163         add args_ptr argument.  Use std::vector.
6164         (substitute_args): Remove argc argument.  Accept std::vector.
6165         (expand): Update.  Use std::vector.
6166         (scan, macro_expand, macro_expand_next): Update.
6167
6168 2018-02-08  Tom Tromey  <tom@tromey.com>
6169
6170         * symtab.c (default_collect_symbol_completion_matches_break_on):
6171         Use unique_xmalloc_ptr.
6172         * macroscope.h: (sal_macro_scope, user_macro_scope)
6173         (default_macro_scope): Return unique_xmalloc_ptr.
6174         * macroscope.c (sal_macro_scope, user_macro_scope)
6175         (default_macro_scope): Return unique_xmalloc_ptr.
6176         * macroexp.h (macro_expand, macro_expand_once): Return
6177         unique_xmalloc_ptr.
6178         * macroexp.c (macro_expand, macro_expand_once): Return
6179         unique_xmalloc_ptr.
6180         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6181         (info_macro_command, info_macros_command): Use
6182         unique_xmalloc_ptr.
6183         * compile/compile-c-support.c (write_macro_definitions): Use
6184         unique_xmalloc_ptr.
6185         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6186
6187 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6188
6189         * value.c (value_static_field): Assign field type instead of
6190         containing type when returning an optimized out value.
6191
6192 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6193
6194         * ft32-tdep.c (ft32_read_pc): Remove.
6195         (ft32_write_pc): Remove.
6196         (ft32_gdbarch_init): Update.
6197         * m32r-tdep.c (m32r_read_pc): Remove.
6198         (m32r_gdbarch_init): Update.
6199         * mep-tdep.c (mep_read_pc): Remove.
6200         (mep_gdbarch_init): Update.
6201         * microblaze-tdep.c (microblaze_write_pc): Remove.
6202         (microblaze_gdbarch_init): Update.
6203         * mn10300-tdep.c (mn10300_read_pc): Remove.
6204         (mn10300_write_pc): Remove.
6205         (mn10300_gdbarch_init): Update.
6206         * moxie-tdep.c (moxie_read_pc): Remove.
6207         (moxie_write_pc): Remove.
6208         (moxie_gdbarch_init): Update.
6209
6210 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6211
6212         * expprint.c (print_subexp_standard): Handle
6213         OP_F77_UNDETERMINED_ARGLIST.
6214         (dump_subexp_body_standard): Likewise.
6215
6216 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6217
6218         * target-descriptions.c (tdesc_element_visitor) Add empty
6219         implementations.
6220         (tdesc_type): Move make_gdb_type from here.
6221         (tdesc_type_builtin): Likewise.
6222         (tdesc_type_vector): Likewise.
6223         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6224         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6225         (make_gdb_type_union): Likewise.
6226         (make_gdb_type_flags): Likewise.
6227         (make_gdb_type_enum): Likewise.
6228         (make_gdb_type): New function.
6229         (tdesc_register_type): Use static make_gdb_type.
6230
6231 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6232
6233         * infcmd.c (default_print_one_register_info): Align natural-format
6234         column values consistently one under another.
6235         (pad_to_column): New function.
6236
6237 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6238
6239         * dwarf2read.c (dwarf2_physname): Move commment.
6240
6241 2018-02-01  Leszek Swirski  <leszeks@google.com>
6242
6243         * varobj.c (varobj_formatted_print_options): Allow recursive
6244         pretty printing if pretty printing is enabled.
6245
6246 2018-02-01  Leszek Swirski  <leszeks@google.com>
6247
6248         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6249         names after a structop as a filename.
6250
6251 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6252
6253         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6254         (arm_record_coproc_data_proc): Likewise.
6255
6256 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6257
6258         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6259
6260 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6261
6262         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6263         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6264
6265 2018-01-31  Pedro Alves  <palves@redhat.com>
6266
6267         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6268         * inflow.c (child_terminal_save_inferior): Wrap reference to
6269         tcgetpgrp in HAVE_TERMIOS_H.
6270         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6271         _WIN32.
6272         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6273         always iterate over all inferiors.
6274         (gdbsim_cntrl_c): Adjust.
6275         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6276
6277 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6278
6279         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6280         index type is objfile-owned if the element type is as well.
6281
6282 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6283
6284         GDB 8.1 released.
6285
6286 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6287
6288         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6289         "features/s390x-linux64.c".
6290         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6291         s390_linux32 and s390x_linux64.
6292         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6293         default tdesc.
6294         * s390-tdep.c: Include "features/s390-linux32.c" and
6295         "features/s390x-linux64.c".
6296         (s390_tdesc_valid): Add check for tdesc_has_registers.
6297         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6298         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6299         tdesc_s390x_linux64.
6300         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6301         tdesc_s390x_linux64 to...
6302         * s390-tdep.h: ...here.
6303
6304 2018-01-30  Pedro Alves  <palves@redhat.com>
6305
6306         PR gdb/13211
6307         * config.in, configure: Regenerate.
6308         * configure.ac: Check for getpgid.
6309         * go32-nat.c (go32_pass_ctrlc): New.
6310         (go32_target): Install it.
6311         * inf-child.c (inf_child_target): Install
6312         child_terminal_save_inferior, child_pass_ctrlc and
6313         child_interrupt.
6314         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6315         (inf_ptrace_target): No longer install it.
6316         * infcmd.c (interrupt_target_1): Adjust.
6317         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
6318         (child_interrupt): Declare.
6319         (inferior::terminal_state): New.
6320         * inflow.c (struct terminal_info): Update comments.
6321         (inferior_process_group): Delete.
6322         (terminal_is_ours): Delete.
6323         (gdb_tty_state): New.
6324         (child_terminal_init): Adjust.
6325         (is_gdb_terminal, sharing_input_terminal_1)
6326         (sharing_input_terminal): New functions.
6327         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
6328         Set the process's actual process group in the foreground if
6329         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
6330         mark terminal as the inferior's if not sharing GDB's terminal.
6331         Don't check attach_flag.
6332         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
6333         pass down a target_terminal_state.
6334         (child_terminal_save_inferior): New, factored out from ...
6335         (child_terminal_ours_1): ... this.  Handle
6336         target_terminal_state::is_ours_for_output.
6337         (child_interrupt, child_pass_ctrlc): New.
6338         (inflow_inferior_exit): Clear the inferior's terminal_state.
6339         (copy_terminal_info): Copy the inferior's terminal state.
6340         (_initialize_inflow): Remove reference to terminal_is_ours.
6341         * inflow.h (inferior_process_group): Delete.
6342         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
6343         * procfs.c (procfs_target): Don't install procfs_interrupt.
6344         (procfs_interrupt): Delete.
6345         * remote.c (remote_serial_quit_handler): Adjust.
6346         (remote_interrupt): Remove ptid parameter.  Adjust.
6347         * target-delegates.c: Regenerate.
6348         * target.c: Include "terminal.h".
6349         (target_terminal::terminal_state): Rename to ...
6350         (target_terminal::m_terminal_state): ... this.
6351         (target_terminal::init): Adjust.
6352         (target_terminal::inferior): Adjust to per-inferior
6353         terminal_state.
6354         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
6355         (target_terminal::ours, target_terminal::ours_for_output): Use
6356         target_terminal_is_ours_kind.
6357         (target_interrupt): Remove ptid parameter.  Adjust.
6358         (default_target_pass_ctrlc): Adjust.
6359         * target.h (target_ops::to_terminal_save_inferior): New field.
6360         (target_ops::to_interrupt): Remove ptid_t parameter.
6361         (target_interrupt): Remove ptid_t parameter.  Update comment.
6362         (target_pass_ctrlc): Update comment.
6363         * target/target.h (target_terminal_state): New scoped enum,
6364         factored out of ...
6365         (target_terminal::terminal_state): ... here.
6366         (target_terminal::inferior): Update comments.
6367         (target_terminal::restore_inferior): New.
6368         (target_terminal::is_inferior, target_terminal::is_ours)
6369         (target_terminal::is_ours_for_output): Adjust.
6370         (target_terminal::scoped_restore_terminal_state): Adjust to
6371         rename, and call restore_inferior() instead of inferior().
6372         (target_terminal::scoped_restore_terminal_state::m_state): Change
6373         type.
6374         (target_terminal::terminal_state): Rename to ...
6375         (target_terminal::m_terminal_state): ... this and change type.
6376
6377 2018-01-30  Pedro Alves  <palves@redhat.com>
6378
6379         * linux-nat.c (wait_for_signal): New function.
6380         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6381         directly.
6382         (async_terminal_is_ours)
6383         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6384         (linux_nat_add_target): Don't override
6385         to_terminal_inferior/to_terminal_ours.
6386
6387 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6388
6389         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6390
6391 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6392
6393         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6394         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6395         dwarf2_per_objfile_free here.
6396         (dwarf2_per_objfile_free): Remove.
6397         (_initialize_dwarf2_read): Don't register
6398         dwarf2_per_objfile_free as a registry cleanup.
6399
6400 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6401
6402         Avoid compilation errors in MinGW native builds
6403
6404         The error is triggered by including python-internal.h, and the
6405         error message is:
6406
6407              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6408                       from build-gnulib/import/math.h:27,
6409                       from d:/usr/Python26/include/pyport.h:235,
6410                       from d:/usr/Python26/include/Python.h:58,
6411                       from python/python-internal.h:94,
6412                       from python/py-arch.c:24:
6413              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6414         using ::hypot;
6415                 ^~~~~
6416
6417         This happens because Python headers define 'hypot' to expand t
6418         '_hypot' in the Windows builds.
6419         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6420         'hypoth'.  This avoids a compilation error.
6421
6422 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6423
6424         * MAINTAINERS (Write After Approval): Fix ordering.
6425
6426 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6427
6428         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6429
6430 2018-01-26  Alan Modra  <amodra@gmail.com>
6431
6432         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6433         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6434         Remove nop.  Make const.  Comment.
6435         (powerpc32_plt_stub_so_2): New.
6436         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6437         Correct count.  Update uses.
6438         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6439         Move common code reading PLT entry word.  Correct
6440         powerpc32_plt_stub PLT address calculation.
6441         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6442         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6443         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6444         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6445         (ppc64_standard_linkage8): Likewise.
6446         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6447         Correct insns description.
6448         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6449
6450 2018-01-24  Pedro Alves  <palves@redhat.com>
6451
6452         GCC PR libstdc++/83906
6453         * gdbtypes.c (operator==(const dynamic_prop &,
6454         const dynamic_prop &)): New.
6455         (operator==(const range_bounds &, const range_bounds &)): New.
6456         (check_types_equal): Use them instead of memcmp.
6457         * gdbtypes.h (operator==(const dynamic_prop &,
6458         const dynamic_prop &)): Declare.
6459         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6460         (operator==(const range_bounds &, const range_bounds &)): Declare.
6461         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6462
6463 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6464
6465         * s390-linux-tdep.c (s390_record_address_mask)
6466         (s390_record_calc_disp_common, s390_record_calc_disp)
6467         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6468         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6469         (s390_process_record): Move to s390-tdep.c.
6470         (s390_linux_init_abi_any): Adjust.
6471         * s390-tdep.c (s390_record_address_mask)
6472         (s390_record_calc_disp_common, s390_record_calc_disp)
6473         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6474         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6475         (s390_process_record): Moved from s390-linux-tdep.c
6476         (s390_gdbarch_init): Adjust.
6477
6478 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6479
6480         * s390-linux-nat.c (s390-tdep.h): New include.
6481         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6482         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6483         (ALLDEPFILES): Add s390-tdep.c.
6484         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6485         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6486         * s390-tdep.h: ...this.  New file.
6487         * s390-linux-tdep.c (s390-tdep.h): New include.
6488         (_initialize_s390_tdep): Rename to...
6489         (_initialize_s390_linux_tdep): ...this and adjust.
6490         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6491         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6492         s390-tdep.h.
6493         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6494         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6495         (s390_is_partial_instruction, s390_software_single_step)
6496         (is_non_branch_ril, s390_displaced_step_copy_insn)
6497         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6498         (s390_prologue_data, s390_addr, s390_store, s390_load)
6499         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6500         (s390_register_call_saved, s390_guess_tracepoint_registers)
6501         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6502         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6503         (s390_pseudo_register_name, s390_pseudo_register_type)
6504         (s390_pseudo_register_read, s390_pseudo_register_write)
6505         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6506         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6507         (s390_addr_bits_remove, s390_address_class_type_flags)
6508         (s390_address_class_type_flags_to_name)
6509         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6510         (s390_function_arg_float, s390_function_arg_vector)
6511         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6512         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6513         (s390_frame_align, s390_register_return_value, s390_return_value)
6514         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6515         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6516         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6517         (s390_trad_frame_prev_register, s390_unwind_cache)
6518         (s390_prologue_frame_unwind_cache)
6519         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6520         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6521         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6522         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6523         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6524         (s390_frame_base_address, s390_local_base_address)
6525         (s390_frame_base, s390_gcc_target_options)
6526         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6527         (s390_validate_reg_range, s390_tdesc_valid)
6528         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6529         * s390-tdep.c: ...this.  New file.
6530
6531 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6532
6533         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6534         (s390_process_record, s390_gdbarch_tdep_alloc)
6535         (s390_linux_init_abi_any): Use/set new hook.
6536
6537 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6538
6539         * s390-linux-tdep.c (osabi.h): New include.
6540         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6541         (s390_linux_init_abi_any): New functions.
6542         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6543
6544 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6545
6546         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6547         tdesc_has_registers check
6548
6549 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6550
6551         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6552         (s390_validate_reg_range): New macro.
6553         (s390_gdbarch_init): Adjust.
6554
6555 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6556
6557         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6558         (s390_gdbarch_tdep_alloc): Adjust.
6559         (s390_gdbarch_init): Adjust.
6560
6561 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6562
6563         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6564         <have_tdb>: Change type to bool.
6565         (s390_gdbarch_tdep_alloc): Adjust.
6566         (s390_gdbarch_init): Adjust.
6567
6568 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6569
6570         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6571         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6572         (s390_gdbarch_tdep_alloc): New function.
6573         (s390_gdbarch_init): Allocate tdep at start and use its fields
6574         instead of separate variables.
6575
6576 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6577
6578         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6579         when looking for cached gdbarch and add comment for remaining.
6580
6581 2018-01-22  Pedro Alves  <palves@redhat.com>
6582             Sergio Durigan Junior  <sergiodj@redhat.com>
6583
6584         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6585         case.
6586
6587 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6588
6589         * MAINTAINERS: Update my company e-mail address.
6590
6591 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6592
6593         * regcache.c (cooked_write_test): New function.
6594         (_initialize_regcache): Register the test.
6595
6596 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6597
6598         * ia64-tdep.c (ia64_pseudo_register_read): Call
6599         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6600         * m32c-tdep.c (m32c_cat_read): Likewise.
6601         (m32c_r3r2r1r0_read): Likewise.
6602         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6603         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6604
6605 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6606
6607         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6608         method raw_read instead of regcache_raw_read.
6609         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6610         * arm-tdep.c (arm_neon_quad_read): Likewise.
6611         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6612         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6613         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6614         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6615         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6616         (i386_pseudo_register_read_into_value): Likewise.
6617         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6618         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6619         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6620         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6621         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6622         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6623         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6624         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6625         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6626
6627 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6628
6629         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6630         * configure.tgt: Remove target mt.
6631         * mt-tdep.c: Remove.
6632         * regcache.c (cooked_read_test): Remove the check for mt.
6633
6634 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6635
6636         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6637         instead of gdbarch_pseudo_register_read_value.
6638
6639 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6640
6641         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6642         language is Ada.
6643
6644 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6645
6646         * linespec.c (create_sals_line_offset): Remove code that preserved
6647         the symtab_and_line's line number.
6648
6649 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6650
6651         * varobj.c (varobj_create): Don't set valid_block when creating a
6652         floating varobj.
6653
6654 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6655
6656         * varobj.c (varobj_create): Remove out of date comment.
6657
6658 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6659
6660         PR mi/20395
6661         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6662         updating innermost block.
6663         * parse.c (innermost_block_tracker::update): Take extra type
6664         parameter, and check types match before updating innermost block.
6665         (write_dollar_variable): Update innermost block for registers.
6666         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6667         (innermost_block_tracker::innermost_block_tracker): Initialise
6668         m_types member.
6669         (innermost_block_tracker::reset): Take type parameter.
6670         (innermost_block_tracker::update): Take type parameter, and pass
6671         type through as needed.
6672         (innermost_block_tracker::m_types): New member.
6673         * varobj.c (varobj_create): Pass type when reseting innermost
6674         block.
6675
6676 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6677
6678         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6679         * ada-lang.c (resolve_subexp): Likewise.
6680         * breakpoint.c (set_breakpoint_condition) Likewise.
6681         (watch_command_1) Likewise.
6682         * c-exp.y (variable): Likewise.
6683         * d-exp.y (PrimaryExpression): Likewise.
6684         * f-exp.y (variable): Likewise.
6685         * go-exp.y (variable): Likewise.
6686         * m2-exp.y (variable): Likewise.
6687         * objfiles.c (objfile::~objfile): Likewise.
6688         * p-exp.y (variable): Likewise.
6689         * parse.c (innermost_block): Change type.
6690         * parser-defs.h (class innermost_block_tracker): New.
6691         (innermost_block): Change to innermost_block_tracker.
6692         * printcmd.c (display_command): Switch to innermost_block API.
6693         (do_one_display): Likewise.
6694         * rust-exp.y (do_one_display): Likewise.
6695         * symfile.c (clear_symtab_users): Likewise.
6696         * varobj.c (varobj_create): Switch to innermost_block API, replace
6697         use of innermost_block with block stored on varobj object.
6698
6699 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6700
6701         * expression.h (innermost_block): Remove declaration.
6702         * varobj.c: Add 'parser-defs.h' include.
6703
6704 2018-01-19  Tom Tromey  <tom@tromey.com>
6705
6706         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6707         symbols in the static and global blocks.
6708
6709 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6710
6711         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6712         gdb_ptrace.h, and move including gdb_wait.h ...
6713         * nat/linux-ptrace.h: ... to here.
6714
6715 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6716
6717         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6718         inf_ptrace_detach_success.
6719         (inf_ptrace_detach_success): Add inferior parameter, use it
6720         instead of inferior_ptid, pass it to detach_inferior.
6721         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6722         parameter.
6723         * inferior.c (detach_inferior): Add overload that takes an
6724         inferior object.
6725         * inferior.h (detach_inferior): Likewise.
6726         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6727         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6728         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6729
6730 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6731
6732         * target.h (struct target_ops) <to_detach>: Add inferior
6733         parameter.
6734         (target_detach): Likewise.
6735         * target.c (dispose_inferior): Pass inferior down.
6736         (target_detach): Pass inferior down.  Assert that it is equal to
6737         the current inferior.
6738         * aix-thread.c (aix_thread_detach): Pass inferior down.
6739         * corefile.c (core_file_command): Pass current_inferior() down.
6740         * corelow.c (core_detach): Add inferior parameter.
6741         * darwin-nat.c (darwin_detach): Likewise.
6742         * gnu-nat.c (gnu_detach): Likewise.
6743         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6744         * infcmd.c (detach_command): Pass current_inferior() down to
6745         target_detach.
6746         * infrun.c (follow_fork_inferior): Pass parent_inf to
6747         target_detach.
6748         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6749         target_detach.
6750         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6751         * linux-thread-db.c (thread_db_detach): Likewise.
6752         * nto-procfs.c (procfs_detach): Likewise.
6753         * procfs.c (procfs_detach): Likewise.
6754         * record.c (record_detach): Likewise.
6755         * record.h (struct inferior): Forward-declare.
6756         (record_detach): Add inferior parameter.
6757         * remote-sim.c (gdbsim_detach): Likewise.
6758         * remote.c (remote_detach_1): Likewise.
6759         (remote_detach): Likewise.
6760         (extended_remote_detach): Likewise.
6761         * sol-thread.c (sol_thread_detach): Likewise.
6762         * target-debug.h (target_debug_print_inferior_p): New macro.
6763         * target-delegates.c: Re-generate.
6764         * top.c (kill_or_detach): Pass inferior down to target_detach.
6765         * windows-nat.c (windows_detach): Add inferior parameter.
6766
6767 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6768
6769         * target.h (struct target_ops) <to_detach>: Remove args
6770         parameter.
6771         (target_detach): Likewise.
6772         * target.c (dispose_inferior): Adjust.
6773         (target_detach): Remove args parameter, adjust.
6774         * aix-thread.c (aix_thread_detach): Adjust.
6775         * corefile.c (core_file_command): Adjust.
6776         * corelow.c (core_detach): Adjust.
6777         * darwin-nat.c (darwin_detach): Adjust.
6778         * gnu-nat.c (gnu_detach): Adjust.
6779         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6780         * infcmd.c (detach_command): Adjust
6781         * infrun.c (follow_fork_inferior): Adjust.
6782         (handle_vfork_child_exec_or_exit): Adjust.
6783         * linux-fork.c (linux_fork_detach): Remove args parameter.
6784         * linux-fork.h (linux_fork_detach): Likewise.
6785         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6786         * linux-thread-db.c (thread_db_detach): Likewise.
6787         * nto-procfs.c (procfs_detach): Likewise.
6788         * procfs.c (procfs_detach): Likewise.
6789         (do_detach): Remove signo parameter.
6790         * record.c (record_detach): Remove args parameter.
6791         * record.h (record_detach): Likewise.
6792         * remote-sim.c (gdbsim_detach): Likewise.
6793         * remote.c (remote_detach_1): Likewise.
6794         (remote_detach): Likewise.
6795         (extended_remote_detach): Likewise.
6796         * sol-thread.c (sol_thread_detach): Likewise.
6797         * target-delegates.c: Re-generate.
6798         * top.c (struct qt_args) <args>: Remove field.
6799         (kill_or_detach): Don't pass args.
6800         (quit_force): Don't set args.
6801         * windows-nat.c (windows_detach): Remove args parameter.
6802
6803 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6804
6805         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6806         (arm_linux_init_abi): Install it.
6807
6808 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6809
6810         * osabi.c (gdb_osabi_names): Extend the regexp for
6811         arm-linux-gnueabihf.
6812
6813 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6814
6815         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6816         m_abbrevs.
6817         (abbrev_table::add_abbrev): Update.
6818         (abbrev_table::lookup_abbrev): Update.
6819
6820 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6821
6822         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6823
6824 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6825
6826         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6827         to "std::string".
6828
6829 2018-01-17  Tom Tromey  <tom@tromey.com>
6830
6831         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6832
6833 2018-01-17  Tom Tromey  <tom@tromey.com>
6834
6835         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6836         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6837         (create_array_type_with_stride): Update.
6838         * dwarf2read.c (set_die_type): Update.
6839
6840 2018-01-17  Tom Tromey  <tom@tromey.com>
6841
6842         * dwarf2read.c (delayed_method_info): Remove typedef.
6843         (dwarf2_cu::method_info): Now a std::vector.
6844         (add_to_method_list): Update.
6845         (free_delayed_list): Remove.
6846         (compute_delayed_physnames): Update.
6847         (process_full_comp_unit, process_full_type_unit): Clear the method
6848         list.  Remove cleanups.
6849         (psymtab_include_file_name): Add name_holder parameter.  Use
6850         unique_xmalloc_ptr.
6851         (dwarf_decode_lines): Update.
6852
6853 2018-01-17  Tom Tromey  <tom@tromey.com>
6854             Simon Marchi  <simon.marchi@ericsson.com>
6855
6856         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6857         (dwarf2_per_objfile::free_cached_comp_units)
6858         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6859         (init_cutu_and_read_dies_no_follow): Update.
6860         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6861         (dwarf2_cu::~dwarf2_cu): New.
6862         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6863         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6864
6865 2018-01-17  Tom Tromey  <tom@tromey.com>
6866             Simon Marchi  <simon.marchi@ericsson.com>
6867
6868         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6869         (struct die_reader_specs) <abbrev_table>: New member.
6870         (struct abbrev_table): Add constructor.
6871         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6872         <abbrev_obstack>: Now an auto_obstack.
6873         (abbrev_table_up): New typedef.
6874         (init_cu_die_reader): Add abbrev_table parameter.
6875         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
6876         Add result_dwo_abbrev_table.
6877         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6878         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
6879         Update.
6880         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
6881         parameter.
6882         (skip_children): Update.
6883         (abbrev_table::alloc_abbrev): Rename from
6884         abbrev_table_alloc_abbrev.
6885         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
6886         (abbrev_table::lookup_abbrev): Rename from
6887         abbrev_table_lookup_abbrev.
6888         (abbrev_table_read_table): Return abbrev_table_up.
6889         (abbrev_table_free, abbrev_table_free_cleanup)
6890         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
6891         (load_partial_dies): Update.
6892
6893 2018-01-17  Tom Tromey  <tom@tromey.com>
6894
6895         * dwarf2read.c (dwarf2_compute_name): Update comment.
6896         (read_func_scope, read_variable): Update.
6897         (new_symbol): Remove.
6898         (new_symbol_full): Rename to new_symbol.
6899
6900 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
6901
6902         PR gdb/16577
6903         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
6904         a warning instead of throwing an error, set section size to 0 and return
6905         NULL.
6906         * gdb_bfd.h (gdb_bfd_map_section): Update description.
6907
6908 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6909
6910         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
6911         std::string.
6912         (linux_ptrace_attach_fail_reason_string): Likewise.
6913         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
6914         Likewise.
6915         (linux_ptrace_attach_fail_reason_string): Likewise.
6916         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
6917
6918 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6919
6920         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6921
6922 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6923
6924         PR gdb/21559
6925         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6926         checking for fs_base/gs_base fields in struct user_regs_struct.
6927         * configure: Regenerate.
6928
6929 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6930
6931         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6932         function.
6933         (aarch64_linux_init_abi): Install it to gdbarch hook
6934         gcc_target_options.
6935
6936 2018-01-15  Pedro Alves  <palves@redhat.com>
6937
6938         * common/signals-state-save-restore.c
6939         (save_original_signals_state): Fix typos.
6940
6941 2017-01-12  Tom Tromey  <tom@tromey.com>
6942             Sergio Durigan Junior  <sergiodj@redhat.com>
6943
6944         * Makefile.in (install-only): Install gdb-add-index.
6945
6946 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6947
6948         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6949
6950 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6951
6952         * infrun.c (keep_going_pass_signal): Clear step-over info when
6953         insert_breakpoints fails.
6954
6955 2018-01-11  Pedro Alves  <palves@redhat.com>
6956
6957         PR gdb/22583
6958         * infrun.c (resume): Rename to ...
6959         (resume_1): ... this.
6960         (resume): Reimplement as wrapper around resume_1.
6961
6962 2018-01-11  Pedro Alves  <palves@redhat.com>
6963
6964         PR remote/22597
6965         * remote.c (remote_parse_stop_reply): Default to the last-set
6966         general thread instead of to 'magic_null_ptid'.
6967
6968 2018-01-10  Pedro Alves  <palves@redhat.com>
6969
6970         * language.h (language_get_symbol_name_matcher): Rename ...
6971         (get_symbol_name_matcher): ... this.
6972         * language.c (language_get_symbol_name_matcher): Ditto.
6973         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6974         callers adjusted.
6975
6976 2018-01-10  Pedro Alves  <palves@redhat.com>
6977
6978         PR gdb/22670
6979         * dwarf2read.c
6980         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6981         Adjust to use language_get_symbol_name_matcher instead of
6982         language_defn::la_get_symbol_name_matcher.
6983         * language.c (language_get_symbol_name_matcher): If in Ada mode
6984         and the lookup name is a verbatim match, return Ada's matcher.
6985         * language.h (language_get_symbol_name_matcher): Adjust comment.
6986         (ada_lookup_name_info::verbatim_p):: New method.
6987
6988 2018-01-10  Pedro Alves  <palves@redhat.com>
6989
6990         PR gdb/22670
6991         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6992         minsym's language is language_auto or language_cplus, pass down
6993         language_ada instead.
6994         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6995
6996 2018-01-10  Pedro Alves  <palves@redhat.com>
6997
6998         PR gdb/22670
6999         * minsyms.c (linkage_name_str): New function.
7000         (iterate_over_minimal_symbols): Use it.
7001
7002 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7003
7004         * NEWS: Document that 'info proc' now works on FreeBSD.
7005
7006 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7007
7008         * configure.ac: Check for kinfo_getfile in libutil.
7009         * configure: Regenerate.
7010         * config.in: Regenerate.
7011         * fbsd-nat.c: Include "fbsd-tdep.h".
7012         (fbsd_fetch_cmdline): New.
7013         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
7014         rather than calling error.
7015         (fbsd_info_proc): New.
7016         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
7017         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
7018         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
7019
7020 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7021
7022         * fbsd-nat.c (struct free_deleter): Remove.
7023         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
7024
7025 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7026
7027         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
7028         NULL for an empty pathname.
7029
7030 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7031
7032         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
7033         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
7034         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
7035         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
7036         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
7037         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
7038         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
7039         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
7040         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
7041         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
7042         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
7043         (fbsd_core_fetch_timeval, fbsd_print_sigset)
7044         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
7045         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
7046         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
7047
7048 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
7049
7050         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
7051         (gnu_xfer_auxv): New function.
7052         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
7053         TARGET_OBJECT_AUXV.
7054
7055 2018-01-08  Yao Qi  <yao.qi@linaro.org>
7056             Simon Marchi  <simon.marchi@ericsson.com>
7057
7058         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
7059         common/selftest.c.
7060         (COMMON_OBS): Remove selftest.o.
7061         * configure.ac: Append selftest-arch.c and common/selftest.c to
7062         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
7063         * configure: Re-generated.
7064         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
7065         GDB_SELF_TEST.
7066         (maintenance_info_selftests): Likewise.
7067
7068 2018-01-08  Xavier Roirand  <roirand@adacore.com>
7069
7070         * ada-valprint.c (val_print_packed_array_elements): Use
7071         proper number of elements when printing an array indexed
7072         by an enumeration type.
7073
7074 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7075
7076         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
7077         (dw2_get_file_names_reader): Adjust.
7078         (lookup_dwo_signatured_type): Adjust.
7079         (lookup_dwp_signatured_type): Adjust.
7080         (lookup_signatured_type): Adjust.
7081         (create_type_unit_group): Adjust.
7082         (get_type_unit_group): Adjust.
7083         (process_psymtab_comp_unit_reader): Adjust.
7084         (build_type_psymtabs_reader): Adjust.
7085         (scan_partial_symbols): Adjust.
7086         (add_partial_symbol): Adjust.
7087         (add_partial_subprogram): Adjust.
7088         (peek_die_abbrev): Adjust.
7089         (fixup_go_packaging): Adjust.
7090         (process_imported_unit_die): Adjust.
7091         (dwarf2_compute_name): Adjust.
7092         (dwarf2_physname): Adjust.
7093         (read_import_statement): Adjust.
7094         (handle_DW_AT_stmt_list): Adjust.
7095         (read_file_scope): Adjust.
7096         (read_func_scope): Adjust.
7097         (read_lexical_block_scope): Adjust.
7098         (read_call_site_scope): Adjust.
7099         (read_variable): Adjust.
7100         (dwarf2_rnglists_process): Adjust.
7101         (dwarf2_ranges_process): Adjust.
7102         (dwarf2_ranges_read): Adjust.
7103         (dwarf2_get_pc_bounds): Adjust.
7104         (dwarf2_record_block_ranges): Adjust.
7105         (dwarf2_add_field): Adjust.
7106         (dwarf2_add_member_fn): Adjust.
7107         (read_structure_type): Adjust.
7108         (process_structure_scope): Adjust.
7109         (read_enumeration_type): Adjust.
7110         (read_array_type): Adjust.
7111         (mark_common_block_symbol_computed): Adjust.
7112         (read_common_block): Adjust.
7113         (read_namespace_type): Adjust.
7114         (read_namespace): Adjust.
7115         (read_module_type): Adjust.
7116         (read_tag_pointer_type): Adjust.
7117         (read_tag_ptr_to_member_type): Adjust.
7118         (read_tag_string_type): Adjust.
7119         (read_subroutine_type): Adjust.
7120         (read_typedef): Adjust.
7121         (read_base_type): Adjust.
7122         (attr_to_dynamic_prop): Adjust.
7123         (read_subrange_type): Adjust.
7124         (read_unspecified_type): Adjust.
7125         (dwarf2_read_abbrevs): Adjust.
7126         (load_partial_dies): Adjust.
7127         (read_partial_die): Adjust.
7128         (find_partial_die): Adjust.
7129         (guess_partial_die_structure_name): Adjust.
7130         (fixup_partial_die): Adjust.
7131         (read_attribute_value): Adjust.
7132         (read_addr_index): Adjust.
7133         (read_addr_index_from_leb128): Adjust.
7134         (read_str_index): Adjust.
7135         (dwarf2_string_attr): Adjust.
7136         (get_debug_line_section): Adjust.
7137         (dwarf_decode_line_header): Adjust.
7138         (lnp_state_machine::check_line_address): Adjust.
7139         (dwarf_decode_lines_1): Adjust.
7140         (dwarf_decode_lines): Adjust.
7141         (dwarf2_start_symtab): Adjust.
7142         (var_decode_location): Adjust.
7143         (new_symbol_full): Adjust.
7144         (dwarf2_const_value_data): Adjust.
7145         (dwarf2_const_value_attr): Adjust.
7146         (dwarf2_const_value): Adjust.
7147         (die_type): Adjust.
7148         (die_containing_type): Adjust.
7149         (build_error_marker_type): Adjust.
7150         (lookup_die_type): Adjust.
7151         (guess_full_die_structure_name): Adjust.
7152         (anonymous_struct_prefix): Adjust.
7153         (determine_prefix): Adjust.
7154         (dwarf2_name): Adjust.
7155         (follow_die_ref_or_sig): Adjust.
7156         (follow_die_offset): Adjust.
7157         (follow_die_ref): Adjust.
7158         (follow_die_sig_1): Adjust.
7159         (follow_die_sig): Adjust.
7160         (get_signatured_type): Adjust.
7161         (get_DW_AT_signature_type): Adjust.
7162         (decode_locdesc): Adjust.
7163         (dwarf_decode_macros): Adjust.
7164         (cu_debug_loc_section): Adjust.
7165         (fill_in_loclist_baton): Adjust.
7166         (dwarf2_symbol_mark_computed): Adjust.
7167         (init_one_comp_unit): Don't assign
7168         dwarf2_cu::dwarf2_per_objfile.
7169         (set_die_type): Adjust.
7170
7171 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7172
7173         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7174         <dwarf2_per_objfile>: New field.
7175         (dwarf2_per_objfile): Remove global.
7176         (get_dwarf2_per_objfile): New function.
7177         (set_dwarf2_per_objfile): New function.
7178         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7179         dwarf2_per_objfile.
7180         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7181         (read_abbrev_offset): Likewise.
7182         (read_indirect_string): Likewise.
7183         (read_indirect_line_string): Likewise.
7184         (read_indirect_string_at_offset): Likewise.
7185         (read_indirect_string_from_dwz): Likewise.
7186         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7187         dwarf2_per_objfile.
7188         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7189         (create_all_comp_units): Change objfile parameter to
7190         dwarf2_per_objfile.
7191         (create_all_type_units): Likewise.
7192         (process_queue): Add dwarf2_per_objfile parameter.
7193         (read_and_check_comp_unit_head): Likewise.
7194         (lookup_dwo_unit_in_dwp): Likewise.
7195         (get_dwp_file): Likewise.
7196         (process_cu_includes): Likewise.
7197         (struct free_dwo_file_cleanup_data): New struct.
7198         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7199         set_dwarf2_per_objfile.
7200         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7201         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7202         context, adjust calls.
7203         (dw2_instantiate_symtab): Likewise.
7204         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7205         (dw2_get_cu): Likewise.
7206         (create_cu_from_index_list): Change objfile parameter to
7207         dwarf2_per_objfile.
7208         (create_cus_from_index_list): Get dwarf2_per_objfile from
7209         context, adjust calls.
7210         (create_cus_from_index): Likewise.
7211         (create_signatured_type_table_from_index): Change objfile
7212         parameter to dwarf2_per_objfile.
7213         (create_signatured_type_table_from_debug_names): Change objfile
7214         parameter to dwarf2_per_objfile.
7215         (create_addrmap_from_index): Likewise.
7216         (create_addrmap_from_aranges): Likewise.
7217         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7218         (dw2_setup): Remove.
7219         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7220         context.
7221         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7222         get_dwarf2_per_objfile.
7223         (dw2_forget_cached_source_info): Likewise.
7224         (dw2_map_symtabs_matching_filename): Likewise.
7225         (struct dw2_symtab_iterator) <index>: Remove.
7226         <dwarf2_per_objfile>: New field.
7227         (dw2_symtab_iter_init): Replace index parameter with
7228         dwarf2_per_objfile.
7229         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7230         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7231         (dw2_print_stats): Likewise.
7232         (dw2_dump): Likewise.
7233         (dw2_expand_symtabs_for_function): Likewise.
7234         (dw2_expand_all_symtabs): Likewise.
7235         (dw2_expand_symtabs_with_fullname): Likewise.
7236         (dw2_expand_marked_cus): Replace index and objfile parameters
7237         with dwarf2_per_objfile.
7238         (dw_expand_symtabs_matching_file_matcher): Add
7239         dwarf2_per_objfile parameter and adjust calls.
7240         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7241         adjust calls.
7242         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7243         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7244         adjust calls.
7245         (create_cus_from_debug_names_list): Replace objfile parameter
7246         with dwarf2_per_objfile and adjust calls.
7247         (create_cus_from_debug_names): Likewise.
7248         (dwarf2_read_debug_names): Likewise.
7249         (mapped_debug_names::namei_to_name): Adjust call.
7250         (dw2_debug_names_iterator::next): Likewise.
7251         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7252         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7253         (dw2_debug_names_dump): Likewise.
7254         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7255         (dw2_debug_names_expand_symtabs_matching): Likewise.
7256         (dwarf2_initialize_objfile): Likewise.
7257         (dwarf2_build_psymtabs): Likewise.
7258         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7259         this_cu.
7260         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7261         (read_and_check_comp_unit_head): Likewise.
7262         (read_abbrev_offset): Likewise.
7263         (create_debug_type_hash_table): Likewise.
7264         (create_debug_types_hash_table): Likewise.
7265         (create_all_type_units): Replace objfile parameter with
7266         dwarf2_per_objfile.
7267         (add_type_unit): Add dwarf2_per_objfile parameter.
7268         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7269         with dwarf2_per_objfile.
7270         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7271         (lookup_dwp_signatured_type): Likewise.
7272         (lookup_signatured_type): Likewise.
7273         (read_cutu_die_from_dwo): Likewise.
7274         (init_tu_and_read_dwo_dies): Likewise.
7275         (init_cutu_and_read_dies): Likewise.
7276         (init_cutu_and_read_dies_no_follow): Likewise.
7277         (allocate_type_unit_groups_table): Add objfile parameter.
7278         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7279         (get_type_unit_group): Likewise.
7280         (process_psymtab_comp_unit): Update call.
7281         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7282         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7283         (print_tu_stats): Likewise.
7284         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7285         in void* parameter.
7286         (build_type_psymtabs): Change objfile parameter to
7287         dwarf2_per_objfile.
7288         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7289         passed in void* parameter.
7290         (process_skeletonless_type_units): Change objfile parameter to
7291         dwarf2_per_objfile.
7292         (set_partial_user): Likewise.
7293         (dwarf2_build_psymtabs_hard): Likewise.
7294         (read_comp_units_from_section): Likewise.
7295         (create_all_comp_units): Likewise.
7296         (scan_partial_symbols): Update calls.
7297         (add_partial_symbol): Likewise.
7298         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7299         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7300         (process_queue): Add dwarf2_per_objfile parameter.
7301         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7302         (compute_compunit_symtab_includes): Likewise.
7303         (process_cu_includes): Add dwarf2_per_objfile parameter.
7304         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7305         (process_full_type_unit): Likewise.
7306         (process_imported_unit_die): Update call.
7307         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7308         (read_file_scope): Likewise.
7309         (allocate_dwo_file_hash_table): Add objfile parameter.
7310         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7311         (create_cus_hash_table): Likewise.
7312         (create_dwp_hash_table): Likewise.
7313         (create_dwo_unit_in_dwp_v1): Likewise.
7314         (create_dwp_v2_section): Likewise.
7315         (create_dwo_unit_in_dwp_v2): Likewise.
7316         (lookup_dwo_unit_in_dwp): Likewise.
7317         (try_open_dwop_file): Likewise.
7318         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
7319         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
7320         cleanup to include a reference to dwarf2_per_objfile.
7321         (open_dwp_file): Add dwarf2_per_objfile parameter.
7322         (open_and_init_dwp_file): Likewise.
7323         (get_dwp_file): Likewise.
7324         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
7325         (queue_and_load_all_dwo_tus): Update call.
7326         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
7327         data.
7328         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
7329         (dwarf2_ranges_process): Likewise.
7330         (dwarf2_get_pc_bounds): Likewise.
7331         (mark_common_block_symbol_computed): Likewise.
7332         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7333         (dwarf2_read_abbrevs): Update call.
7334         (read_partial_die): Use dwarf2_per_objfile from cu.
7335         (find_partial_die): Likewise.
7336         (fixup_partial_die): Likewise.
7337         (read_attribute_value): Likewise.
7338         (read_indirect_string_at_offset_from): Add objfile parameter.
7339         (read_indirect_string_at_offset): Add dwarf2_per_objfile
7340         parameter.
7341         (read_indirect_string_from_dwz): Add objfile parameter.
7342         (read_indirect_string): Add objfile parameter.
7343         (read_addr_index_1): Add dwarf2_per_objfile parameter.
7344         (read_addr_index): Use dwarf2_per_objfile from cu.
7345         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
7346         call dw2_setup.
7347         (read_str_index): Use dwarf2_per_objfile from cu.
7348         (get_debug_line_section): Likewise.
7349         (read_formatted_entries): Add dwarf2_per_objfile parameter.
7350         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
7351         (new_symbol_full): Use dwarf2_per_objfile from cu.
7352         (build_error_marker_type): Likewise.
7353         (lookup_die_type): Likewise.
7354         (determine_prefix): Likewise.
7355         (follow_die_offset): Likewise.
7356         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
7357         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
7358         (dwarf2_fetch_die_type_sect_off): Likewise.
7359         (dwarf2_get_die_type): Likewise.
7360         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7361         (get_signatured_type): Likewise.
7362         (get_DW_AT_signature_type): Likewise.
7363         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7364         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7365         (cu_debug_loc_section): Likewise.
7366         (fill_in_loclist_baton): Likewise.
7367         (dwarf2_symbol_mark_computed): Likewise.
7368         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7369         dwarf2_per_objfile.
7370         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7371         parameter.
7372         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7373         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7374         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7375         (set_die_type): Use dwarf2_free_objfile from cu.
7376         (get_die_type_at_offset): Likewise.
7377         (dwarf2_per_objfile_free): Don't assign global variable.
7378         (debug_names) <constructor>: Add dwarf2_per_objfile
7379         parameter, update m_debugstrlookup construction.
7380         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7381         parameter.
7382         <m_dwarf2_per_objfile>: New field.
7383         <lookup>: Use m_dwarf2_per_objfile.
7384         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7385         (psyms_seen_size): Likewise.
7386         (write_gdbindex): Replace objfile parameter with
7387         dwarf2_per_objfile.
7388         (write_debug_names): Likewise.
7389         (write_psymtabs_to_index): Likewise.
7390         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7391         calls.
7392
7393 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7394
7395         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7396         <dwarf2_per_objfile>: New field.
7397         (struct dwarf2_per_cu_data) <objfile>: Remove.
7398         <dwarf2_per_objfile>: New field.
7399         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7400         of objfile.
7401         (create_signatured_type_table_from_index): Likewise.
7402         (create_debug_type_hash_table): Likewise.
7403         (fill_in_sig_entry_from_dwo_entry): Likewise.
7404         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7405         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7406         objfile.
7407         (create_partial_symtab): Access objfile through
7408         dwarf2_per_objfile.
7409         (process_psymtab_comp_unit_reader): Likewise.
7410         (read_comp_units_from_section): Likewise.
7411         (scan_partial_symbols): Likewise.
7412         (add_partial_symbol): Likewise.
7413         (add_partial_subprogram): Likewise.
7414         (peek_die_abbrev): Likewise.
7415         (fixup_go_packaging): Likewise.
7416         (process_full_comp_unit): Likewise.
7417         (process_full_type_unit): Likewise.
7418         (process_imported_unit_die): Likewise.
7419         (dwarf2_compute_name): Likewise.
7420         (dwarf2_physname): Likewise.
7421         (read_import_statement): Likewise.
7422         (create_cus_hash_table): Assign dwarf2_physname instead of
7423         objfile.
7424         (read_func_scope): Access objfile through dwarf2_per_objfile.
7425         (read_lexical_block_scope): Likewise.
7426         (read_call_site_scope): Likewise.
7427         (read_variable): Likewise.
7428         (dwarf2_rnglists_process): Likewise.
7429         (dwarf2_ranges_process): Likewise.
7430         (dwarf2_ranges_read): Likewise.
7431         (dwarf2_record_block_ranges): Likewise.
7432         (dwarf2_add_field): Likewise.
7433         (dwarf2_add_member_fn): Likewise.
7434         (read_structure_type): Likewise.
7435         (process_structure_scope): Likewise.
7436         (read_enumeration_type): Likewise.
7437         (read_array_type): Likewise.
7438         (read_common_block): Likewise.
7439         (read_namespace_type): Likewise.
7440         (read_namespace): Likewise.
7441         (read_module_type): Likewise.
7442         (read_tag_pointer_type): Likewise.
7443         (read_tag_ptr_to_member_type): Likewise.
7444         (read_tag_string_type): Likewise.
7445         (read_subroutine_type): Likewise.
7446         (read_typedef): Likewise.
7447         (read_base_type): Likewise.
7448         (attr_to_dynamic_prop): Likewise.
7449         (read_subrange_type): Likewise.
7450         (read_unspecified_type): Likewise.
7451         (load_partial_dies): Likewise.
7452         (read_partial_die): Likewise.
7453         (find_partial_die): Likewise.
7454         (guess_partial_die_structure_name): Likewise.
7455         (fixup_partial_die): Likewise.
7456         (read_attribute_value): Likewise.
7457         (read_addr_index_from_leb128): Likewise.
7458         (dwarf2_read_addr_index): Likewise.
7459         (dwarf2_string_attr): Likewise.
7460         (lnp_state_machine::check_line_address): Likewise.
7461         (dwarf_decode_lines_1): Likewise.
7462         (dwarf_decode_lines): Likewise.
7463         (dwarf2_start_symtab): Likewise.
7464         (var_decode_location): Likewise.
7465         (new_symbol_full): Likewise.
7466         (dwarf2_const_value_data): Likewise.
7467         (dwarf2_const_value_attr): Likewise.
7468         (dwarf2_const_value): Likewise.
7469         (die_type): Likewise.
7470         (die_containing_type): Likewise.
7471         (lookup_die_type): Likewise.
7472         (guess_full_die_structure_name): Likewise.
7473         (anonymous_struct_prefix): Likewise.
7474         (dwarf2_name): Likewise.
7475         (follow_die_ref_or_sig): Likewise.
7476         (follow_die_offset): Likewise.
7477         (follow_die_ref): Likewise.
7478         (dwarf2_fetch_die_loc_sect_off): Likewise.
7479         (dwarf2_fetch_constant_bytes): Likewise.
7480         (dwarf2_fetch_die_type_sect_off): Likewise.
7481         (dwarf2_get_die_type): Likewise.
7482         (follow_die_sig): Likewise.
7483         (decode_locdesc): Likewise.
7484         (dwarf2_per_cu_objfile): Likewise.
7485         (dwarf2_per_cu_text_offset): Likewise.
7486         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7487         objfile.
7488         (set_die_type): Access objfile through
7489         dwarf2_per_objfile.
7490
7491 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7492
7493         * valprint.c (converted_character_d): Remove typedef.
7494         (DEF_VEC_O (converted_character_d)): Remove.
7495         (count_next_character): Use std::vector.
7496         (print_converted_chars_to_obstack): Likewise.
7497         (generic_printstr): Likewise.
7498
7499 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7500
7501         * xml-support.h (struct gdb_xml_value): Add constructor.
7502         <value>: Change type to unique_xmalloc_ptr.
7503         (gdb_xml_value_s): Remove typedef.
7504         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7505         (gdb_xml_element_start_handler): Change parameter type to
7506         std::vector.
7507         (xml_find_attribute): Likewise.
7508         * xml-support.c (xml_find_attribute): Change parameter type to
7509         std::vector and adjust.
7510         (gdb_xml_values_cleanup): Remove.
7511         (gdb_xml_parser::start_element): Adjust to std::vector.
7512         (xinclude_start_include): Change paraeter type to std::vector
7513         and adjust.
7514         * btrace.c (check_xml_btrace_version): Likewise.
7515         (parse_xml_btrace_block): Likewise.
7516         (parse_xml_btrace_pt_config_cpu): Likewise.
7517         (parse_xml_btrace_pt): Likewise.
7518         (parse_xml_btrace_conf_bts): Likewise.
7519         (parse_xml_btrace_conf_pt): Likewise.
7520         * memory-map.c (memory_map_start_memory): Likewise.
7521         (memory_map_start_property): Likewise.
7522         * osdata.c (osdata_start_osdata): Likewise.
7523         (osdata_start_item): Likewise.
7524         (osdata_start_column): Likewise.
7525         * remote.c (start_thread): Likewise.
7526         * solib-aix.c (library_list_start_library): Likewise.
7527         (library_list_start_list): Likewise.
7528         * solib-svr4.c (library_list_start_library): Likewise.
7529         (svr4_library_list_start_list): Likewise.
7530         * solib-target.c (library_list_start_segment): Likewise.
7531         (library_list_start_section): Likewise.
7532         (library_list_start_library): Likewise.
7533         (library_list_start_list): Likewise.
7534         * tracepoint.c (traceframe_info_start_memory): Likewise.
7535         (traceframe_info_start_tvar): Likewise.
7536         * xml-syscall.c (syscall_start_syscall): Likewise.
7537         * xml-tdesc.c (tdesc_start_target): Likewise.
7538         (tdesc_start_feature): Likewise.
7539         (tdesc_start_reg): Likewise.
7540         (tdesc_start_union): Likewise.
7541         (tdesc_start_struct): Likewise.
7542         (tdesc_start_flags): Likewise.
7543         (tdesc_start_enum): Likewise.
7544         (tdesc_start_field): Likewise.
7545         (tdesc_start_enum_value): Likewise.
7546         (tdesc_start_vector): Likewise.
7547
7548 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7549
7550         * extension.h (struct xmethod_worker) <clone>: Remove.
7551         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7552         Remove.
7553         (python_xmethod_worker::clone): Remove.
7554         * valops.c (find_overload_match): Use std::move instead of
7555         clone.
7556
7557 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7558
7559         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7560         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7561         <free_xmethod_worker_data>: Remove.
7562         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7563         <get_xmethod_arg_types>: Remove.
7564         <get_xmethod_result_type>: Remove.
7565         <invoke_xmethod>: Remove.
7566         * extension.c (new_xmethod_worker): Remove.
7567         (clone_xmethod_worker): Remove.
7568         (get_matching_xmethod_workers): Return void, pass std::vector by
7569         pointer.
7570         (get_xmethod_arg_types): Rename to...
7571         (xmethod_worker::get_arg_types): ... this, and adjust.
7572         (get_xmethod_result_type): Rename to...
7573         (xmethod_worker::get_result_type): ... this, and adjust.
7574         (invoke_xmethod): Remove.
7575         (free_xmethod_worker): Remove.
7576         (free_xmethod_worker_vec): Remove.
7577         * extension.h (enum ext_lang_rc): Move here from
7578         extension-priv.h.
7579         (struct xmethod_worker): Add constructor and destructor.
7580         <data>: Remove.
7581         <value>: Remove.
7582         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7583         virtual pure methods.
7584         <get_arg_types, get_result_type>: New methods.
7585         (xmethod_worker_ptr): Remove typedef.
7586         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7587         (xmethod_worker_vec): Remove typedef.
7588         (xmethod_worker_up): New typedef.
7589         (invoke_xmethod): Remove.
7590         (clone_xmethod_worker): Remove.
7591         (free_xmethod_worker): Remove.
7592         (free_xmethod_worker_vec): Remove.
7593         (get_xmethod_arg_types): Remove.
7594         (get_xmethod_result_type): Remove.
7595         * valops.c (find_method_list): Use std::vector, don't use
7596         intermediate vector.
7597         (value_find_oload_method_list): Use std::vector.
7598         (find_overload_match): Use std::vector.
7599         (find_oload_champ): Use std::vector.
7600         * value.c (value_free): Use operator delete.
7601         (value_of_xmethod): Rename to...
7602         (value_from_xmethod): ... this.  Don't assign
7603         xmethod_worker::value, take rvalue-reference.
7604         (result_type_of_xmethod): Adjust.
7605         (call_xmethod): Adjust.
7606         * value.h: Include extension.h.
7607         (struct xmethod_worker): Don't forward-declare.
7608         (value_of_xmethod): Rename to...
7609         (value_from_xmethod): ... this, take rvalue-reference.
7610         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7611         (struct python_xmethod_worker): ... this, add constructor and
7612         destructor.
7613         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7614         (gdbpy_free_xmethod_worker_data): Rename to...
7615         (python_xmethod_worker::~python_xmethod_worker): ... this and
7616         adjust.
7617         (gdbpy_clone_xmethod_worker_data): Rename to...
7618         (python_xmethod_worker::clone): ... this and adjust.
7619         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7620         temporary vector.
7621         (gdbpy_get_xmethod_arg_types): Rename to...
7622         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7623         (gdbpy_get_xmethod_result_type): Rename to...
7624         (python_xmethod_worker::do_get_result_type): ... this and
7625         adjust.
7626         (gdbpy_invoke_xmethod): Rename to...
7627         (python_xmethod_worker::invoke): ... this and adjust.
7628         (new_python_xmethod_worker): Rename to...
7629         (python_xmethod_worker::python_xmethod_worker): ... this and
7630         adjust.
7631         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7632         Remove.
7633         (gdbpy_free_xmethod_worker_data): Remove.
7634         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7635         (gdbpy_get_xmethod_arg_types): Remove.
7636         (gdbpy_get_xmethod_result_type): Remove.
7637         (gdbpy_invoke_xmethod): Remove.
7638         * python/python.c (python_extension_ops): Remove obsolete
7639         callbacks.
7640
7641 2018-01-05  Pedro Alves  <palves@redhat.com>
7642
7643         PR gdb/18653
7644         * common/signals-state-save-restore.c
7645         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7646         find a custom handler preinstalled, instead of internal erroring.
7647         But only warn if !quiet.
7648         * common/signals-state-save-restore.h
7649         (save_original_signals_state): New parameter 'quiet'.
7650         * main.c (captured_main_1): Move save_original_signals_state call
7651         after option handling, and pass QUIET.
7652
7653 2018-01-05  Pedro Alves  <palves@redhat.com>
7654
7655         * spu-tdep.c (spu_catch_start): Pass
7656         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7657
7658 2018-01-05  Pedro Alves  <palves@redhat.com>
7659
7660         PR gdb/22670
7661         * ada-lang.c (literal_symbol_name_matcher): New function.
7662         (ada_get_symbol_name_matcher): Use it for
7663         symbol_name_match_type::SEARCH_NAME.
7664         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7665         it down instead of assuming symbol_name_match_type::FULL.
7666         * block.h (block_lookup_symbol): New parameter 'match_type'.
7667         * c-valprint.c (print_unpacked_pointer): Use
7668         lookup_symbol_search_name instead of lookup_symbol.
7669         * compile/compile-object-load.c (get_out_value_type): Pass down
7670         symbol_name_match_type::SEARCH_NAME.
7671         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7672         symbol_name_match_type::FULL.
7673         * cp-support.c (cp_get_symbol_name_matcher): Handle
7674         symbol_name_match_type::SEARCH_NAME.
7675         * infrun.c (insert_exception_resume_breakpoint): Use
7676         lookup_symbol_search_name.
7677         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7678         * psymtab.c (maintenance_check_psymtabs): Use
7679         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7680         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7681         SYMBOL_SEARCH_NAME.
7682         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7683         if symbol_name_match_type::SEARCH_NAME.
7684         (lookup_symbol_in_language): Pass down
7685         symbol_name_match_type::FULL.
7686         (lookup_symbol_search_name): New.
7687         (lookup_language_this): Pass down
7688         symbol_name_match_type::SEARCH_NAME.
7689         (lookup_symbol_aux, lookup_local_symbol): New parameter
7690         'match_type'.  Pass it down.
7691         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7692         (lookup_symbol_search_name): New declaration.
7693         (lookup_symbol_in_block): New 'match_type' parameter.
7694
7695 2018-01-05  Pedro Alves  <palves@redhat.com>
7696
7697         PR gdb/22670
7698         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7699         ada_lookup_symbol.
7700         (ada_lookup_symbol): Reimplement in terms of
7701         ada_lookup_symbol_list, bits factored out from
7702         ada_lookup_encoded_symbol.
7703
7704 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7705
7706         * ada-exp.y (write_object_renaming): When subscripting an array
7707         using a symbol as the index, pass the block in call to
7708         ada_lookup_encoded_symbol when looking that symbol up.
7709
7710 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7711
7712         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7713         TYPE_INDEX_TYPE.
7714
7715 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7716
7717         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7718         the case where VALUE_LVAL (val0) is not lval_memory.
7719
7720 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7721
7722         * ada-valprint.c (print_optional_low_bound): Handle
7723         character-indexed array printing like boolean-indexed array
7724         printing.
7725
7726 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7727
7728         * NEWS: Create a new section for the next release branch.
7729         Rename the section of the current branch, now that it has
7730         been cut.
7731
7732 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7733
7734         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7735         * version.in: Bump version to 8.1.50.DATE-git.
7736
7737 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7738
7739         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7740         Add field.
7741         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7742         Add field.
7743         (default_exception_support_info) <catch_handlers_sym>: Add field.
7744         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7745         (ada_exception_name_addr_1): Add "catch handlers" handling.
7746         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7747         Update all callers.
7748         (create_excep_cond_exprs) <ex>: Add parameter.
7749         (re_set_exception): Update create_excep_cond_exprs call.
7750         (print_it_exception, print_one_exception, print_mention_exception)
7751         (print_recreate_exception): Add "catch handler" handling.
7752         (allocate_location_catch_handlers, re_set_catch_handlers)
7753         (check_status_catch_handlers, print_it_catch_handlers)
7754         (print_one_catch_handlers, print_mention_catch_handlers)
7755         (print_recreate_catch_handlers): New function.
7756         (catch_handlers_breakpoint_ops): New variable.
7757         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7758         Add parameter.  Add "catch handler" handling.
7759         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7760         Add "catch handler" handling.
7761         (ada_exception_catchpoint_cond_string): Add "catch handler"
7762         handling.
7763         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7764         call.
7765         (catch_ada_handlers_command): New function.
7766         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7767         operations structure.
7768         (_initialize_ada_language): Add "catch handlers" command entry.
7769         * NEWS: Document "catch handlers" feature.
7770
7771 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7772
7773         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7774         account when creating the array type of the slice.
7775         (ada_value_slice): Likewise.
7776
7777 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7778
7779         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7780         New enum value.
7781         (create_array_type_with_stride): Add byte_stride_prop parameter.
7782         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7783         New parameter.  Update all callers in this file.
7784         (array_type_has_dynamic_stride): New function.
7785         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7786         of arrays with dynamic byte strides.
7787         * dwarf2read.c (read_array_type): Add support for dynamic
7788         DW_AT_byte_stride attributes.
7789
7790 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7791
7792         * dwarf2read.c (read_unspecified_type): Treat
7793         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7794
7795 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7796
7797         Update copyright year range in all GDB files.
7798
7799 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7800
7801         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7802         and gdb/testsuite/gdb.base/step-line.c.
7803
7804 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7805
7806         * copyright.py (main): Dump the contents of
7807         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7808         even if BY_HAND is empty.
7809
7810 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7811
7812         * top.c (print_gdb_version): Update Copyright year in version
7813         message.
7814
7815 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7816
7817         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7818
7819 For older changes see ChangeLog-2017.
7820 \f
7821 Local Variables:
7822 mode: change-log
7823 left-margin: 8
7824 fill-column: 74
7825 version-control: never
7826 coding: utf-8
7827 End: