gdb/ChangeLog

   1 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2             Tom Tromey  <tromey@adacore.com>
   3
   4         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
   5
   6 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
   7
   8         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
   9         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  10         method to compute the bounds of range types. Also print "[evaluated]"
  11         if the bounds' values come from a dynamic evaluation.
  12
  13 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  14
  15         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  16         whitespace when pretty printing is on.
  17
  18 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  19
  20         * ppc-linux-nat.c: Add include.
  21
  22 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  23
  24         * NEWS: Mention AArch64 Pointer Authentication.
  25
  26 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  27
  28         * arm-linux-nat.c: Add include.
  29
  30 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  31
  32         * source-cache.c (source_cache::get_source_lines): Re-read
  33         fullname after calling open_source_file.
  34
  35 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  36
  37         * NEWS: Mention TLS support for FreeBSD.
  38
  39 2019-03-25  Tom Tromey  <tromey@adacore.com>
  40
  41         * minsyms.c (BUNCH_SIZE): Update comment.
  42         (~minimal_symbol_reader): Remove old comment.
  43         (compact_minimal_symbols): Update comment.
  44         (minimal_symbol_reader::install): Remove old comment.  Update
  45         other comments.
  46
  47 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  48
  49         * s390-linux-nat.c: Add include.
  50
  51 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  52
  53         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  54         Call linux_get_hwcap.
  55         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  56         Likewise.
  57         (aarch64_linux_get_hwcap): Remove function.
  58         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  59         declaration.
  60         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  61         linux_get_hwcap.
  62         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  63         * linux-tdep.c (linux_get_hwcap): Add function.
  64         (linux_get_hwcap2): Likewise.
  65         * linux-tdep.h (linux_get_hwcap): Add declaration.
  66         (linux_get_hwcap2): Likewise.
  67         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  68         (ppc_linux_get_hwcap2): Likewise.
  69         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  70         linux_get_hwcap.
  71         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  72         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  73         (ppc_linux_nat_target::read_description): Likewise.
  74         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  75         * s390-linux-nat.c: Likewise.
  76         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  77
  78 2019-03-24  Tom Tromey  <tom@tromey.com>
  79
  80         * ada-lang.c (standard_lookup): Simplify initialization.
  81         (ada_lookup_symbol_nonlocal): Simplify return.
  82         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  83         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  84         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  85         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  86         initialization.
  87         * solib.c (solib_global_lookup): Simplify.
  88         * symtab.c (null_block_symbol): Remove.
  89         (symbol_cache_lookup): Simplify returns.
  90         (lookup_language_this): Simplify returns.
  91         (lookup_symbol_aux): Simplify return.
  92         (lookup_local_symbol): Simplify returns.
  93         (lookup_global_symbol_from_objfile): Simplify return.
  94         (lookup_symbol_in_objfile_symtabs)
  95         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
  96         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
  97         (lookup_static_symbol, lookup_global_symbol): Simplify return.
  98         * cp-namespace.c (cp_lookup_bare_symbol)
  99         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 100         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 101         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 102         (cp_lookup_symbol_via_imports): Simplify initialization.
 103         (find_symbol_in_baseclass): Likewise.
 104         * symtab.h (null_block_symbol): Remove.
 105         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 106         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 107         (d_lookup_symbol_module): Likewise.
 108         (find_symbol_in_baseclass): Simplify initialization.
 109
 110 2019-03-24  Tom Tromey  <tom@tromey.com>
 111
 112         * expression.h: Don't include symtab.h.
 113         (struct block): Forward declare.
 114
 115 2019-03-24  Tom Tromey  <tom@tromey.com>
 116
 117         * c-exp.y (typebase): Remove casts.
 118         * gdbtypes.c (lookup_unsigned_typename, )
 119         (lookup_signed_typename): Remove cast.
 120         * eval.c (parse_to_comma_and_eval): Remove cast.
 121         * parse.c (write_dollar_variable): Remove cast.
 122         * block.h (struct block) <superblock>: Now const.
 123         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 124         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 125         (map_block): Make "block" const.
 126         * symfile.h (struct quick_symbol_functions)
 127         <map_matching_symbols>: Constify block argument to "callback".
 128         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 129         const.
 130         (find_pc_sect_compunit_symtab): Make "b" const.
 131         (find_symbol_at_address): Likewise.
 132         (search_symbols): Likewise.
 133         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 134         (dw2_debug_names_lookup_symbol): Likewise.
 135         (dw2_map_matching_symbols): Update.
 136         * p-valprint.c (pascal_val_print): Remove "block".
 137         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 138         (aux_add_nonlocal_symbols): Make "block" const.
 139         (resolve_subexp): Remove cast.
 140         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 141         const.
 142         (iterate_over_file_blocks): Likewise.
 143         * f-exp.y (%union) <bval>: Remove.
 144         * coffread.c (patch_opaque_types): Make "b" const.
 145         * spu-tdep.c (spu_catch_start): Make "block" const.
 146         * c-valprint.c (print_unpacked_pointer): Remove "block".
 147         * symmisc.c (dump_symtab_1): Make "b" const.
 148         (block_depth): Make "block" const.
 149         * d-exp.y (%union) <bval>: Remove.
 150         * cp-support.h (cp_lookup_rtti_type): Update.
 151         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 152         * psymtab.c (psym_lookup_symbol): Make "block" const.
 153         (maintenance_check_psymtabs): Make "b" const.
 154         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 155         (enumerate_locals, enumerate_args): Update.
 156         * python/py-symtab.c (stpy_global_block): Make "block" const.
 157         (stpy_static_block): Likewise.
 158         * inline-frame.c (block_starting_point_at): Make "new_block"
 159         const.
 160         * block.c (find_block_in_blockvector): Make return type const.
 161         (blockvector_for_pc_sect): Make "b" const.
 162         (find_block_in_blockvector): Make "b" const.
 163
 164 2019-03-23  Tom Tromey  <tom@tromey.com>
 165
 166         * varobj.c (varobj_create): Update.
 167         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 168         * printcmd.c (display_command, do_one_display): Don't reset
 169         innermost_block.
 170         * parser-defs.h (enum innermost_block_tracker_type): Move to
 171         expression.h.
 172         (innermost_block): Update comment.
 173         * parse.c (parse_exp_1): Add tracker_types parameter.
 174         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 175         tracker_types parameter.  Reset innermost_block.
 176         (parse_exp_in_context): Remove.
 177         (parse_expression_for_completion): Update.
 178         * objfiles.c (~objfile): Don't reset expression_context_block or
 179         innermost_block.
 180         * expression.h (enum innermost_block_tracker_type): Move from
 181         parser-defs.h.
 182         (parse_exp_1): Add tracker_types parameter.
 183         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 184         reset innermost_block.
 185
 186 2019-03-23  Tom Tromey  <tom@tromey.com>
 187
 188         * objfiles.h: Include bcache.h.
 189
 190 2019-03-23  Tom Tromey  <tom@tromey.com>
 191
 192         * linespec.c (get_current_search_block): Use
 193         scoped_restore_current_language.
 194         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 195
 196 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 197             Jiong Wang  <jiong.wang@arm.com>
 198
 199         * aarch64-linux-tdep.c
 200         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 201         section.
 202         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 203
 204 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 205             Jiong Wang  <jiong.wang@arm.com>
 206
 207         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 208         instructions.
 209         (aarch64_analyze_prologue_test): Add PACIASP test.
 210         (aarch64_prologue_prev_register): Unmask PC value.
 211
 212 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 213             Jiong Wang  <jiong.wang@arm.com>
 214
 215         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 216         (aarch64_dwarf2_prev_register): Unmask PC value.
 217         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 218         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 219         DW_CFA_AARCH64_negate_ra_state.
 220         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 221
 222 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 223             Jiong Wang  <jiong.wang@arm.com>
 224
 225         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 226         registers.
 227         (aarch64_pseudo_register_name): Likewise.
 228         (aarch64_pseudo_register_type): Likewise.
 229         (aarch64_pseudo_register_reggroup_p): Likewise.
 230         (aarch64_gdbarch_init): Add pauth registers.
 231         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 232         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 233         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 234         (struct gdbarch_tdep): Add regnum for ra_state.
 235
 236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 237             Jiong Wang  <jiong.wang@arm.com>
 238
 239         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 240
 241 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 242             Jiong Wang  <jiong.wang@arm.com>
 243
 244         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 245         function.
 246         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 247         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 248         (aarch64_gdbarch_init): Add puth registers.
 249         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 250         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 251         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 252
 253 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 254             Jiong Wang  <jiong.wang@arm.com>
 255
 256         * aarch64-linux-nat.c
 257         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 258         * aarch64-linux-tdep.c
 259         (aarch64_linux_core_read_description): Likewise.
 260         (aarch64_linux_get_hwcap): New function.
 261         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 262         (aarch64_linux_get_hwcap): New declaration.
 263
 264 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 265             Jiong Wang  <jiong.wang@arm.com>
 266
 267         * aarch64-linux-nat.c
 268         (aarch64_linux_nat_target::read_description): Add pauth param.
 269         * aarch64-linux-tdep.c
 270         (aarch64_linux_core_read_description): Likewise.
 271         * aarch64-tdep.c (struct target_desc): Add in pauth.
 272         (aarch64_read_description): Add pauth param.
 273         (aarch64_gdbarch_init): Likewise.
 274         * aarch64-tdep.h (aarch64_read_description): Likewise.
 275         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 276         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 277         * features/Makefile: Add new files.
 278         * features/aarch64-pauth.c: New file.
 279         * features/aarch64-pauth.xml: New file.
 280
 281 2019-03-20  Tom Tromey  <tromey@adacore.com>
 282
 283         * infrun.c (handle_inferior_event): Rename from
 284         handle_inferior_event_1.  Create a scoped_value_mark.
 285         (handle_inferior_event): Remove.
 286
 287 2019-03-19  Tom Tromey  <tromey@adacore.com>
 288
 289         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 290         * infrun.h (print_stop_event): Add "displays" parameter.
 291         * infrun.c (print_stop_event): Add "displays" parameter.
 292
 293 2019-03-19  Pedro Alves  <palves@redhat.com>
 294
 295         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 296         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 297         to -1.  Fix TABs vs spaces.
 298         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 299         * tui/tui-out.h (tui_ui_out) Add intro comments.
 300         <m_line, m_start_of_line>: In-class initialize, and add describing
 301         comment.
 302
 303 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 304
 305         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 306         variable names.
 307         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 308
 309 2019-03-18  Pedro Alves  <palves@redhat.com>
 310             Eli Zaretskii <eliz@gnu.org>
 311
 312         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 313         m_line and m_start_of_line.
 314
 315 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 316
 317         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 318         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 319         it returns a newline.  This fixes a regression in TU mode, whereby
 320         the next line is output on the same screen line as the user input.
 321
 322 2019-03-18  Tom Tromey  <tromey@adacore.com>
 323
 324         * minsyms.c (minimal_symbol_reader::install): Remove call to
 325         obstack_blank.
 326
 327 2019-03-18  Pedro Alves  <palves@redhat.com>
 328
 329         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 330         New globals.
 331         (apply_style): New, factored out from ...
 332         (apply_ansi_escape): ... this.  Handle reverse video mode.
 333         (tui_set_reverse_mode): New function.
 334         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 335         * tui/tui-winsource.c (tui_show_source_line): Use
 336         tui_set_reverse_mode instead of setting A_STANDOUT.
 337         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 338         New setter methods.
 339
 340 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 341
 342         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 343         Handle tabs.
 344
 345 2019-03-18  Tom Tromey  <tromey@adacore.com>
 346
 347         * ada-lang.c (empty_array): Add "high" parameter.
 348         (ada_evaluate_subexp): Update.
 349
 350 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 351
 352         * unittests/string_view-selftests.c: Define
 353         _initialize_string_view_selftests unconditionally.
 354
 355 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 356
 357         PR gdb/24350
 358         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 359
 360 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 361
 362         PR gdb/24351
 363         * windows-nat.c (display_selector): Fix format specifiers.
 364
 365 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 366
 367         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 368         tui_refill_source_window instead of tui_refresh_win, to update the
 369         current execution line.  This fixes redisplay of the current line
 370         when stepping through the code with "next" or "step".
 371
 372 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 373
 374         * source-cache.c (source_cache::get_source_lines): Call
 375         find_source_lines to initialize s->nlines.  This fixes vertical
 376         scrolling of TUI source window when the DOWN arrow is pressed.
 377
 378 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 379
 380         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 381         linux-thread-db.c (_initialize_thread_db): Likewise.
 382
 383 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 384
 385         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 386         wclrtoeol in tui_show_source_line".  This reverts changes made in
 387         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 388
 389 2019-03-15  Tom Tromey  <tom@tromey.com>
 390
 391         * symtab.h (struct minimal_symbol): Derive from
 392         general_symbol_info.
 393         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 394         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 395         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 396         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 397         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 398         (MSYMBOL_SEARCH_NAME): Update.
 399         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 400         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 401         * minsyms.c (minimal_symbol_reader::record_full): Update.
 402
 403 2019-03-15  Tom Tromey  <tom@tromey.com>
 404
 405         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 406
 407 2019-03-15  Tom Tromey  <tom@tromey.com>
 408
 409         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 410         unique_xmalloc_ptr.
 411         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 412         Update.
 413         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 414         (build_minimal_symbol_hash_tables)
 415         (minimal_symbol_reader::install): Update.
 416
 417 2019-03-15  Tom Tromey  <tom@tromey.com>
 418
 419         * symtab.c (create_demangled_names_hash): Update.
 420         (symbol_set_names): Update.
 421         * objfiles.h (struct objfile_per_bfd_storage)
 422         <demangled_names_hash>: Now an htab_up.
 423         * objfiles.c (objfile_per_bfd_storage): Simplify.
 424
 425 2019-03-15  Tom Tromey  <tom@tromey.com>
 426
 427         * objfiles.h (struct objfile_per_bfd_storage): Declare
 428         destructor.
 429         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 430         New.
 431         (get_objfile_bfd_data): Use new.  Don't initialize
 432         language_of_main.
 433         (free_objfile_per_bfd_storage): Remove.
 434         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 435
 436 2019-03-15  Tom Tromey  <tom@tromey.com>
 437
 438         * symfile.c (reread_symbols): Update.
 439         * objfiles.c (objfile::objfile): Update.
 440         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 441         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 442         comment.
 443         (minimal_symbol_reader::install): Update.
 444         (terminate_minimal_symbol_table): Remove.
 445         * jit.c (jit_object_close_impl): Update.
 446
 447 2019-03-15  Tom Tromey  <tom@tromey.com>
 448
 449         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 450         initializations.
 451
 452 2019-03-15  Tom Tromey  <tom@tromey.com>
 453
 454         * objfiles.h (struct objfile_per_bfd_storage)
 455         <demangled_hash_languages>: Now a bitset.
 456         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 457         (lookup_minimal_symbol): Update.
 458
 459 2019-03-15  Tom Tromey  <tom@tromey.com>
 460
 461         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 462         Don't return the symbol.
 463         * coffread.c (record_minimal_symbol): Use record_full.
 464
 465 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 466
 467         The MS-Windows port of ncurses fails to switch to a color pair if
 468         one or both of the colors are the implicit default colors.  This
 469         change records the default colors when TUI is initialized, and
 470         then specifies them explicitly when a color pair uses the default
 471         colors.  This allows color styling in TUI mode on MS-Windows.
 472
 473         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 474         ncurses_norm_attr.
 475         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 476         colors in ncurses_norm_attr.
 477         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 478         "none", replace it with the default color recorded in
 479         ncurses_norm_attr.
 480
 481 2019-03-14  Tom Tromey  <tromey@adacore.com>
 482
 483         * source-cache.h (class source_cache) <get_source_lines>: Return
 484         std::string.
 485         * source-cache.c (source_cache::extract_lines): Handle case where
 486         first_pos==npos.  Return std::string.
 487         (source_cache::get_source_lines): Update.
 488
 489 2019-03-14  Tom Tromey  <tromey@adacore.com>
 490
 491         * NEWS: Add item for "style sources" commands.
 492         * source-cache.c (source_cache::get_source_lines): Check
 493         source_styling.
 494         * cli/cli-style.c (source_styling): New global.
 495         (_initialize_cli_style): Add "style sources" commands.
 496         (show_style_sources): New function.
 497         * cli/cli-style.h (source_styling): Declare.
 498
 499 2019-03-14  Pedro Alves  <palves@redhat.com>
 500             Tom Tromey  <tromey@adacore.com>
 501
 502         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 503         * tui/tui-winsource.c (tui_refill_source_window): New function,
 504         from...
 505         (tui_horizontal_source_scroll): ... here.  Move some logic.
 506         * cli/cli-style.c (set_style_enabled): Notify new observable.
 507         * tui/tui-hooks.c (tui_redisplay_source): New function.
 508         (tui_attach_detach_observers): Attach or detach
 509         tui_redisplay_source.
 510         * observable.h (source_styling_changed): New observable.
 511         * observable.c: Define source_styling_changed observable.
 512
 513 2019-03-13  Tom Tromey  <tromey@adacore.com>
 514
 515         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 516         (i386_gnu_nat_target::store_registers): Update.
 517         * target-debug.h (target_debug_print_std_string): New macro.
 518         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 519         * windows-tdep.c (display_one_tib): Update.
 520         * tui/tui-stack.c (tui_make_status_line): Update.
 521         * top.c (print_inferior_quit_action): Update.
 522         * thread.c (thr_try_catch_cmd): Update.
 523         (add_thread_with_info): Update.
 524         (thread_target_id_str): Update.
 525         (thr_try_catch_cmd): Update.
 526         (thread_command): Update.
 527         (thread_find_command): Update.
 528         * record-btrace.c (record_btrace_target::info_record)
 529         (record_btrace_resume_thread, record_btrace_target::resume)
 530         (record_btrace_cancel_resume, record_btrace_step_thread)
 531         (record_btrace_target::wait, record_btrace_target::wait)
 532         (record_btrace_target::wait, record_btrace_target::stop): Update.
 533         * progspace.c (print_program_space): Update.
 534         * process-stratum-target.c
 535         (process_stratum_target::thread_address_space): Update.
 536         * linux-fork.c (linux_fork_mourn_inferior)
 537         (detach_checkpoint_command, info_checkpoints_command)
 538         (linux_fork_context): Update.
 539         (linux_fork_detach): Update.
 540         (class scoped_switch_fork_info): Update.
 541         (delete_checkpoint_command): Update.
 542         * infrun.c (follow_fork_inferior): Update.
 543         (follow_fork_inferior): Update.
 544         (proceed_after_vfork_done): Update.
 545         (handle_vfork_child_exec_or_exit): Update.
 546         (follow_exec): Update.
 547         (displaced_step_prepare_throw): Update.
 548         (displaced_step_restore): Update.
 549         (start_step_over): Update.
 550         (resume_1): Update.
 551         (clear_proceed_status_thread): Update.
 552         (proceed): Update.
 553         (print_target_wait_results): Update.
 554         (do_target_wait): Update.
 555         (context_switch): Update.
 556         (stop_all_threads): Update.
 557         (restart_threads): Update.
 558         (finish_step_over): Update.
 559         (handle_signal_stop): Update.
 560         (switch_back_to_stepped_thread): Update.
 561         (keep_going_pass_signal): Update.
 562         (print_exited_reason): Update.
 563         (normal_stop): Update.
 564         * inferior.c (inferior_pid_to_str): Change return type.
 565         (print_selected_inferior): Update.
 566         (add_inferior): Update.
 567         (detach_inferior): Update.
 568         * dummy-frame.c (fprint_dummy_frames): Update.
 569         * dcache.c (dcache_info_1): Update.
 570         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 571         (btrace_fetch, btrace_clear): Update.
 572         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 573         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 574         type.
 575         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 576         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 577         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 578         * gdbarch.c, gdbarch.h: Rebuild.
 579         * gdbarch.sh (core_pid_to_str): Change return type.
 580         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 581         return type.
 582         (windows_nat_target::pid_to_str): Change return type.
 583         (windows_delete_thread): Update.
 584         (windows_nat_target::attach): Update.
 585         (windows_nat_target::files_info): Update.
 586         * target-delegates.c: Rebuild.
 587         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 588         return type.
 589         (sol_thread_target::pid_to_str): Change return type.
 590         * remote.c (class remote_target) <pid_to_str>: Change return
 591         type.
 592         (remote_target::pid_to_str): Change return type.
 593         (extended_remote_target::attach, remote_target::remote_stop_ns)
 594         (remote_target::remote_notif_remove_queued_reply)
 595         (remote_target::push_stop_reply, remote_target::disable_btrace):
 596         Update.
 597         (extended_remote_target::attach): Update.
 598         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 599         type.
 600         (gdbsim_target::pid_to_str): Change return type.
 601         * ravenscar-thread.c (struct ravenscar_thread_target)
 602         <pid_to_str>: Change return type.
 603         (ravenscar_thread_target::pid_to_str): Change return type.
 604         * procfs.c (class procfs_target) <pid_to_str>: Change return
 605         type.
 606         (procfs_target::pid_to_str): Change return type.
 607         (procfs_target::attach): Update.
 608         (procfs_target::detach): Update.
 609         (procfs_target::fetch_registers): Update.
 610         (procfs_target::store_registers): Update.
 611         (procfs_target::wait): Update.
 612         (procfs_target::files_info): Update.
 613         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 614         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 615         return type.
 616         (nto_procfs_target::pid_to_str): Change return type.
 617         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 618         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 619         return type.
 620         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 621         (exit_lwp): Update.
 622         (attach_proc_task_lwp_callback, get_detach_signal)
 623         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 624         (linux_nat_target::resume, wait_lwp, stop_callback)
 625         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 626         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 627         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 628         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 629         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 630         type.
 631         (inf_ptrace_target::attach): Update.
 632         (inf_ptrace_target::files_info): Update.
 633         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 634         type.
 635         (go32_nat_target::pid_to_str): Change return type.
 636         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 637         (gnu_nat_target::wait): Update.
 638         (gnu_nat_target::wait): Update.
 639         (gnu_nat_target::resume): Update.
 640         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 641         (fbsd_nat_target::wait): Update.
 642         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 643         type.
 644         (darwin_nat_target::attach): Update.
 645         * corelow.c (class core_target) <pid_to_str>: Change return type.
 646         (core_target::pid_to_str): Change return type.
 647         * target.c (normal_pid_to_str): Change return type.
 648         (default_pid_to_str): Likewise.
 649         (target_pid_to_str): Change return type.
 650         (target_translate_tls_address): Update.
 651         (target_announce_detach): Update.
 652         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 653         return type.
 654         (bsd_uthread_target::pid_to_str): Change return type.
 655         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 656         type.
 657         (bsd_kvm_target::pid_to_str): Change return type.
 658         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 659         return type.
 660         (aix_thread_target::pid_to_str): Change return type.
 661         * target.h (struct target_ops) <pid_to_str>: Change return type.
 662         (target_pid_to_str, normal_pid_to_str): Likewise.
 663         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 664         type.
 665         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 666         type.
 667         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 668         return type.
 669         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 670         type.
 671         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 672         type.
 673         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 674         return type.
 675
 676 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 677
 678         * NEWS: Mention that the new default MI version is 3.  Mention
 679         changes to the output of commands and events that deal with
 680         multi-location breakpoints.
 681         * breakpoint.c: Include "mi/mi-out.h".
 682         (print_one_breakpoint): Change output syntax if using MI version
 683         >= 3.
 684         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 685         New.
 686         (mi_multi_location_breakpoint_output_fixed): New.
 687         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 688         (mi_cmd_fix_multi_location_breakpoint_output): New.
 689         (mi_multi_location_breakpoint_output_fixed): New.
 690         * mi/mi-cmds.c (mi_cmds): Register command
 691         -fix-multi-location-breakpoint-output.
 692         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 693         interpreter "mi".
 694
 695 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 696
 697         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 698         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 699         instantiate mi_ui_out based on interpreter name.
 700         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 701         * mi/mi-main.c (mi_load_progress): Likewise.
 702
 703 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 704
 705         * NEWS: Combine separate "New targets" sections for 8.3.
 706
 707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 708
 709         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 710         (ppcfbsd_init_abi): Install gdbarch
 711         "fetch_tls_load_module_address" and "get_thread_local_address"
 712         methods.
 713
 714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 715
 716         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 717         (riscv_fbsd_init_abi): Install gdbarch
 718         "fetch_tls_load_module_address" and "get_thread_local_address"
 719         methods.
 720
 721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 722
 723         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 724         (i386fbsd_init_abi): Install gdbarch
 725         "fetch_tls_load_module_address" and "get_thread_local_address"
 726         methods.
 727
 728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 729
 730         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 731         (amd64fbsd_init_abi): Install gdbarch
 732         "fetch_tls_load_module_address" and "get_thread_local_address"
 733         methods.
 734
 735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 736
 737         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 738         (struct fbsd_pspace_data): New type.
 739         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 740         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 741         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 742         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 743         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 744
 745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 746
 747         * gdbtypes.c (lookup_struct_elt): New function.
 748         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 749         * gdbtypes.h (struct struct_elt): New type.
 750         (lookup_struct_elt): New prototype.
 751
 752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 753
 754         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 755         remove disabled code block.
 756
 757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 758
 759         * gdbarch.sh (get_thread_local_address): New method.
 760         * gdbarch.h, gdbarch.c: Regenerate.
 761         * target.c (target_translate_tls_address): Use
 762         gdbarch_get_thread_local_address if present instead of
 763         target::get_thread_local_address.
 764
 765 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 766
 767         * target.h (target::get_thread_local_address): Update comment.
 768
 769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 770
 771         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 772         objfile->separate_debug_objfile_backlink if not NULL.
 773
 774 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 775
 776         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 777         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 778         (amd64bsd_store_inferior_registers): Likewise.
 779         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 780         Enable segment base registers.
 781         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 782         PT_GETFSBASE and PT_GETGSBASE.
 783         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 784         PT_SETGSBASE.
 785         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 786         segment base registers.
 787         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 788
 789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 790
 791         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 792         Update calls to i386_target_description to add 'segments'
 793         parameter.
 794         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 795         add segment base registers.
 796         * arch/i386.c (i386_create_target_description): Add 'segments'
 797         parameter to enable segment base registers.
 798         * arch/i386.h (i386_create_target_description): Likewise.
 799         * features/i386/32bit-segments.xml: New file.
 800         * features/i386/32bit-segments.c: Generate.
 801         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 802         call to i386_target_description to add 'segments' parameter.
 803         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 804         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 805         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 806         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 807         if feature is present.
 808         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 809         Add 'segments' parameter to call to i386_target_description.
 810         (i386_target_description): Add 'segments' parameter to enable
 811         segment base registers.
 812         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 813         to call to i386_target_description.
 814         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 815         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 816         Define I386_NUM_REGS.
 817         (i386_target_description): Add 'segments' parameter to enable
 818         segment base registers.
 819
 820 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 821
 822         PR/24325
 823         * source-cache.c: #undef open and close, to avoid unresolved
 824         externals during linking.
 825
 826 2019-03-12  Tom Tromey  <tromey@adacore.com>
 827
 828         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 829         const.  Add initializers.
 830         (_initialize_remote): Don't initialize ptid globals.
 831
 832 2019-03-12  Pedro Alves  <palves@redhat.com>
 833
 834         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 835
 836 2019-03-12  Pedro Alves  <palves@redhat.com>
 837
 838         * cp-name-parser.y (main): Remove unused 'len' variable.
 839
 840 2019-03-12  Tom Tromey  <tromey@adacore.com>
 841
 842         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 843         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 844
 845 2019-03-12  Tom Tromey  <tromey@adacore.com>
 846
 847         * linux-nat.c (iterate_over_lwps): Update.
 848         (stop_callback): Remove parameter.
 849         (stop_wait_callback, detach_callback, resume_set_callback)
 850         (select_singlestep_lwp_callback, set_ignore_sigint)
 851         (status_callback, resumed_callback, resume_clear_callback)
 852         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 853         data parameter.
 854         (linux_nat_target::detach, linux_nat_target::resume)
 855         (linux_stop_and_wait_all_lwps, select_event_lwp)
 856         (linux_nat_filter_event, linux_nat_wait_1)
 857         (linux_nat_target::kill, linux_nat_target::stop)
 858         (linux_nat_target::stop): Update.
 859         (linux_nat_resume_callback): Change type.
 860         (resume_stopped_resumed_lwps, count_events_callback)
 861         (select_event_lwp_callback): Likewise.
 862         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 863         * arm-linux-nat.c (struct update_registers_data): Remove.
 864         (update_registers_callback): Change type.
 865         (arm_linux_insert_hw_breakpoint1): Update.
 866         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 867         parameter.
 868         (x86_linux_dr_set_addr): Update.
 869         (x86_linux_dr_set_control): Update.
 870         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 871         (iterate_over_lwps): Use gdb::function_view.
 872         * nat/aarch64-linux-hw-point.c (struct
 873         aarch64_dr_update_callback_param): Remove.
 874         (debug_reg_change_callback): Change type.
 875         (aarch64_notify_debug_reg_change): Update.
 876         * s390-linux-nat.c (s390_refresh_per_info): Update.
 877
 878 2019-03-11  Tom Tromey  <tromey@adacore.com>
 879
 880         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 881         redundant assignment to "this_cu".
 882
 883 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 884
 885         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 886
 887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 888
 889         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 890         from...
 891         (rank_one_type): ... this.
 892
 893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 894
 895         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 896         from...
 897         (rank_one_type): ... this.
 898
 899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 900
 901         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 902         from...
 903         (rank_one_type): ... this.
 904
 905 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 906
 907         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 908         from...
 909         (rank_one_type): ... this.
 910
 911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 912
 913         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 914         from...
 915         (rank_one_type): ... this.
 916
 917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 918
 919         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 920         from...
 921         (rank_one_type): ... this.
 922
 923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 924
 925         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 926         from...
 927         (rank_one_type): ... this.
 928
 929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 930
 931         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 932         from...
 933         (rank_one_type): ... this.
 934
 935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 936
 937         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 938         from...
 939         (rank_one_type): ... this.
 940
 941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 942
 943         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 944         from...
 945         (rank_one_type): ... this.
 946
 947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 948
 949         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 950         from...
 951         (rank_one_type): ... this.
 952
 953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 954
 955         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 956         from...
 957         (rank_one_type): ... this.
 958
 959 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 960
 961         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 962         inferior-events' shows the example events.
 963
 964 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 965
 966         Support styling on native MS-Windows console
 967
 968         PR/24315
 969         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 970         on MS-Windows if $TERM is not defined.
 971
 972         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 973
 974         * posix-hdep.c (gdb_console_fputs):
 975         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 976         functions.
 977         * ui-file.h (gdb_console_fputs): Add prototype.
 978
 979         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 980         back to fputs only if the former returns zero.
 981
 982 2019-03-07  Tom Tromey  <tom@tromey.com>
 983
 984         * symmisc.c (print_symbol_bcache_statistics): Update.
 985         (print_objfile_statistics): Update.
 986         * symfile.c (allocate_symtab): Update.
 987         * stabsread.c: Don't include bcache.h.
 988         * psymtab.h (struct psymbol_bcache): Don't declare.
 989         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 990         (psymbol_bcache_init, psymbol_bcache_free)
 991         (psymbol_bcache_get_bcache): Don't declare.
 992         * psymtab.c (struct psymbol_bcache): Remove.
 993         (psymtab_storage::psymtab_storage): Update.
 994         (psymtab_storage::~psymtab_storage): Update.
 995         (psymbol_bcache_init, psymbol_bcache_free)
 996         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 997         (add_psymbol_to_bcache): Update.
 998         (allocate_psymtab): Update.
 999         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1000         macro_cache>: No longer pointers.
1001         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1002         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1003         * macrotab.c (macro_bcache): Update.
1004         * macroexp.c: Don't include bcache.h.
1005         * gdbtypes.c (check_types_worklist): Update.
1006         (types_deeply_equal): Remove TRY/CATCH.  Update.
1007         * elfread.c (elf_symtab_read): Update.
1008         * dwarf2read.c: Don't include bcache.h.
1009         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1010         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1011         (print_bcache_statistics, bcache_memory_used): Don't declare.
1012         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1013         methods.  Rename all data members.
1014         * bcache.c (struct bcache): Move to bcache.h.
1015         (bcache::expand_hash_table): Rename from expand_hash_table.
1016         (bcache): Remove.
1017         (bcache::insert): Rename from bcache_full.
1018         (bcache::compare): Rename from bcache_compare.
1019         (bcache_xmalloc): Remove.
1020         (bcache::~bcache): Rename from bcache_xfree.
1021         (bcache::print_statistics): Rename from print_bcache_statistics.
1022         (bcache::memory_used): Rename from bcache_memory_used.
1023
1024 2019-03-07  Pedro Alves  <palves@redhat.com>
1025
1026         * infrun.c (normal_stop): Also check for
1027         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1028
1029 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * f-lang.c (value_from_host_double): Moved to...
1032         * value.c (value_from_host_double): ...here.
1033         * value.h (value_from_host_double): Declare.
1034         * guile/scm-math.c (vlscm_convert_typed_number): Use
1035         value_from_host_double.
1036         (vlscm_convert_number): Likewise.
1037         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1038         * python/py-value.c (convert_value_from_python): Likewise.
1039
1040 2019-03-06  Tom Tromey  <tom@tromey.com>
1041
1042         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1043
1044 2019-03-06  Tom Tromey  <tom@tromey.com>
1045
1046         * utils.h (free_current_contents): Don't declare.
1047         * utils.c (free_current_contents): Remove.
1048
1049 2019-03-06  Tom Tromey  <tom@tromey.com>
1050
1051         * top.c (quit_force): Update.
1052         * main.c (captured_command_loop): Update.
1053         * common/new-op.c (operator new): Update.
1054         * common/common-exceptions.c (struct catcher)
1055         <save_cleanup_chain>: Remove member.
1056         (exceptions_state_mc_init): Update.
1057         (exception_try_scope_entry): Return nullptr.
1058         (exception_try_scope_exit, exception_rethrow)
1059         (throw_exception_sjlj, throw_exception_cxx): Update.
1060         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1061         (all_cleanups, do_cleanups, discard_cleanups)
1062         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1063         (restore_cleanups, restore_final_cleanups): Don't declare.
1064         (do_final_cleanups): Remove parameter.
1065         * common/cleanups.c (cleanup_chain, make_cleanup)
1066         (make_cleanup_dtor, all_cleanups, do_cleanups)
1067         (discard_my_cleanups, discard_cleanups)
1068         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1069         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1070         (null_cleanup): Remove.
1071         (do_final_cleanups): Remove parameter.
1072
1073 2019-03-06  Tom Tromey  <tom@tromey.com>
1074
1075         * remote.c (remote_target::remote_parse_stop_reply): Use
1076         unique_xmalloc_ptr.
1077
1078 2019-03-06  Tom Tromey  <tom@tromey.com>
1079
1080         * stabsread.c (struct stabs_field_info): Rename from field_info.
1081         <list, fnlist>: Add initializers.
1082         <obstack>: New member.
1083         (read_member_functions, read_struct_fields, read_baseclasses):
1084         Allocate on obstack.  Don't use cleanups.
1085         (read_one_struct_field, read_member_functions, read_struct_fields)
1086         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1087         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1088         (read_struct_type): Update.
1089
1090 2019-03-06  Tom Tromey  <tom@tromey.com>
1091
1092         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1093         * common/filestuff.h (make_cleanup_close): Don't declare.
1094         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1095         Remove.
1096
1097 2019-03-06  Tom Tromey  <tom@tromey.com>
1098
1099         * solib-aix.c: Use make_scope_exit.
1100
1101 2019-03-06  Tom Tromey  <tom@tromey.com>
1102
1103         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1104         Use make_scope_exit.
1105
1106 2019-03-06  Tom Tromey  <tom@tromey.com>
1107
1108         * solib-svr4.c (disable_probes_interface): Remove parameter.
1109         (svr4_handle_solib_event): Use make_scope_exit.
1110
1111 2019-03-06  Tom Tromey  <tom@tromey.com>
1112
1113         * remote.c (struct stop_reply_deleter): Remove.
1114         (stop_reply_up): Update.
1115         (struct stop_reply): Derive from notif_event.  Don't typedef.
1116         <regcache>: Now a std::vector.
1117         (stop_reply_xfree): Remove.
1118         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1119         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1120         (remote_target::discard_pending_stop_replies): Use delete.
1121         (remote_target::remote_parse_stop_reply): Update.
1122         (remote_target::process_stop_reply): Update.
1123         * remote-notif.h (struct notif_event): Add virtual destructor.
1124         Remove "dtr" member.
1125         (struct notif_client) <alloc_event>: Return a unique_ptr.
1126         (notif_event_xfree): Don't declare.
1127         (notif_event_up): New typedef.
1128         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1129         (notif_event_xfree, do_notif_event_xfree): Remove.
1130         (remote_notif_state_xfree): Update.
1131
1132 2019-03-06  Tom Tromey  <tom@tromey.com>
1133
1134         * infrun.c (displaced_step_clear_cleanup): Now a
1135         forward_scope_exit type.
1136         (displaced_step_prepare_throw): Update.
1137         (displaced_step_fixup): Update.
1138
1139 2019-03-06  Tom Tromey  <tom@tromey.com>
1140
1141         * inferior.h (class inferior): Update comment.
1142         * gdbthread.h (class thread_info): Update comment.
1143
1144 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1145             Tom Tromey  <tom@tromey.com>
1146
1147         * stabsread.h (struct stab_section_list): Remove.
1148         (coffstab_build_psymtabs): Update.
1149         * dbxread.c (symbuf_sections): Now a std::vector.
1150         (sect_idx): New global.
1151         (fill_symbuf): Update.
1152         (coffstab_build_psymtabs): Change type of stabsects parameter.
1153         Update.
1154         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1155         std::vector.
1156         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1157         (coff_locate_sections): Update.
1158         (coff_symfile_read): Remove cleanups.  Update.
1159         (init_stringtab): Add storage parameter.
1160         (free_stringtab, free_stringtab_cleanup): Remove.
1161         (init_lineno): Add storage parameter.
1162         (free_linetab, free_linetab_cleanup): Remove.
1163
1164 2019-03-06  Pedro Alves  <palves@redhat.com>
1165
1166         * linux-fork.c (fork_info::clobber_regs): Delete.
1167         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1168         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1169         comment.  Adjust.
1170         (scoped_switch_fork_info::scoped_switch_fork_info)
1171         (checkpoint_command, linux_fork_context): Adjust
1172         fork_save_infrun_state calls.
1173
1174 2019-03-06  Pedro Alves  <palves@redhat.com>
1175
1176         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1177         (inf_has_multiple_threads): Return 'bool' and rewrite using
1178         inferior_info::threads().
1179
1180 2019-03-06  Pedro Alves  <palves@redhat.com>
1181
1182         * linux-fork.c: Include <list>.
1183         (fork_list): Now a std::list instance.
1184         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1185         (forks_exist_p, find_last_fork): Adjust.
1186         (new_fork): Delete.
1187         (one_fork_p): New.
1188         (add_fork): Adjust.
1189         (free_fork): Delete, folded into fork_info::~fork_info().
1190         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1191         Adjust.
1192         (init_fork_list): Delete.
1193         (linux_fork_killall, linux_fork_mourn_inferior)
1194         (linux_fork_detach, info_checkpoints_command): Adjust.
1195         (_initialize_linux_fork): No longer call init_fork_list.
1196
1197 2019-03-06  Pedro Alves  <palves@redhat.com>
1198
1199         * linux-fork.c (new_fork): New, split out of ...
1200         (add_fork): ... this.  Return void.  Move "first fork" special
1201         case from here, to ...
1202         (checkpoint_command): ... here.
1203         * linux-linux.h (add_fork): Return void.
1204
1205 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1206
1207         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1208
1209 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1210             Chris January  <chris.january@arm.com>
1211             David Lecomber  <david.lecomber@arm.com>
1212
1213         * f-exp.y: New token, UNOP_INTRINSIC.
1214         (exp): New pattern using UNOP_INTRINSIC token.
1215         (f77_keywords): Add 'abs' keyword.
1216         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1217         (value_from_host_double): New function.
1218         (evaluate_subexp_f): Support UNOP_ABS.
1219
1220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1223         types.
1224
1225 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1226
1227         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1228         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1229         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1230
1231 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1234
1235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1236             Chris January  <chris.january@arm.com>
1237
1238         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1239         * f-exp.y: Define 'KIND' token.
1240         (exp): New pattern for KIND expressions.
1241         (ptype): Handle types with a kind extension.
1242         (direct_abs_decl): Extend to spot kind extensions.
1243         (f77_keywords): Add 'kind' to the list.
1244         (push_kind_type): New function.
1245         (convert_to_kind_type): New function.
1246         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1247         * parse.c (operator_length_standard): Likewise.
1248         * parser-defs.h (enum type_pieces): Add tp_kind.
1249         * std-operator.def: Add UNOP_KIND.
1250
1251 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1252
1253         * f-exp.y (f_parse): Set yydebug.
1254
1255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * f-lang.c (evaluate_subexp_f): New function.
1258         (exp_descriptor_f): New global.
1259         (f_language_defn): Use exp_descriptor_f instead of
1260         exp_descriptor_standard.
1261
1262 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1263
1264         * f-exp.y (struct token): Add comments.
1265         (dot_ops): Remove uppercase versions and the end marker.
1266         (f77_keywords): Likewise.
1267         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1268         entries in the dot_ops array are case insensitive, and use
1269         strncasecmp to compare strings.  Also some whitespace cleanup in
1270         this area.  Similar for the f77_keywords array, except entries in
1271         this list might be case sensitive.
1272
1273 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1274
1275         * f-exp.y (struct f77_boolean_val): Add comments.
1276         (boolean_values): Remove uppercase versions, and end marker.
1277         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1278         and use strncasecmp to achieve case insensitivity.  Additionally,
1279         perform whitespace cleanup around this code.
1280
1281 2019-03-06  Tom Tromey  <tromey@adacore.com>
1282
1283         * remote-sim.c (gdbsim_target_open): Use result of
1284         gdb_argv::release.
1285
1286 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1287         Dirk Schubert  <dirk.schubert@arm.com>
1288         Chris January  <chris.january@arm.com>
1289
1290         * eval.c (evaluate_subexp_standard): Call Fortran argument
1291         wrapping logic.
1292         * f-lang.c (struct value): A value which can be passed into a
1293         Fortran function call.
1294         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1295         where appropriate.
1296         (struct type): Value ready for a Fortran function call.
1297         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1298         is needed.
1299         * f-lang.h (fortran_argument_convert): Declaration.
1300         (fortran_preserve_arg_pointer): Declaration.
1301         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1302
1303 2019-03-05  Tom Tromey  <tromey@adacore.com>
1304
1305         * python/py-prettyprint.c (print_string_repr): Remove #if.
1306         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1307
1308 2019-03-05  Tom Tromey  <tromey@adacore.com>
1309
1310         * target.c (the_dummy_target): Move later.  Change type to
1311         "dummy_target".
1312         (initialize_targets): Don't initialize the_dummy_target.
1313
1314 2019-03-05  Tom Tromey  <tromey@adacore.com>
1315
1316         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1317         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1318
1319 2019-03-05  Tom Tromey  <tromey@adacore.com>
1320
1321         * windows-nat.c (windows_nat_target::attach)
1322         (windows_nat_target::detach): Don't call gdb_flush.
1323         * valprint.c (generic_val_print, val_print, val_print_string):
1324         Don't call gdb_flush.
1325         * utils.c (defaulted_query): Don't call gdb_flush.
1326         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1327         * target.c (target_announce_detach): Don't call gdb_flush.
1328         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1329         * remote.c (extended_remote_target::attach): Don't call
1330         gdb_flush.
1331         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1332         * printcmd.c (do_examine): Don't call gdb_flush.
1333         (info_display_command): Don't call gdb_flush.
1334         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1335         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1336         * memattr.c (info_mem_command): Don't call gdb_flush.
1337         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1338         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1339         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1340         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1341         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1342         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1343         (gnu_nat_target::detach): Don't call gdb_flush.
1344         * f-valprint.c (f_val_print): Don't call gdb_flush.
1345         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1346         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1347         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1348         gdb_flush.
1349         * c-valprint.c (c_val_print): Don't call gdb_flush.
1350         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1351
1352 2019-03-05  Tom Tromey  <tromey@adacore.com>
1353
1354         * varobj.c (update_dynamic_varobj_children): Update.
1355         (install_default_visualizer): Use reset, not release.
1356         * value.c (set_internalvar): Update.
1357         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1358         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1359         ATTRIBUTE_UNUSED_RESULT.
1360
1361 2019-03-05  Tom Tromey  <tromey@adacore.com>
1362
1363         * remote.c (class scoped_remote_fd) <release>: Add
1364         ATTRIBUTE_UNUSED_RESULT.
1365
1366 2019-03-05  Tom Tromey  <tromey@adacore.com>
1367
1368         * macroexp.c (struct macro_buffer) <release>: Add
1369         ATTRIBUTE_UNUSED_RESULT.
1370
1371 2019-03-05  Tom Tromey  <tromey@adacore.com>
1372
1373         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1374         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1375         ATTRIBUTE_UNUSED_RESULT.
1376
1377 2019-03-05  Tom Tromey  <tromey@adacore.com>
1378
1379         * common/scoped_fd.h (class scoped_fd) <release>: Add
1380         ATTRIBUTE_UNUSED_RESULT.
1381
1382 2019-03-05  Tom Tromey  <tromey@adacore.com>
1383
1384         * parser-defs.h (struct parser_state) <release>: Add
1385         ATTRIBUTE_UNUSED_RESULT.
1386
1387 2019-03-05  Tom Tromey  <tromey@adacore.com>
1388
1389         * utils.h (class gdb_argv) <release>: Add
1390         ATTRIBUTE_UNUSED_RESULT.
1391         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1392
1393 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1394
1395         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1396         for-loop range, to avoid compiler warnings.
1397
1398         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1399         avoid compiler warnings about unused variables.
1400
1401         * NEWS: Mention end of support for native debugging on MS-Windows
1402         before XP.
1403
1404         PR gdb/24292
1405         * common/netstuff.c:
1406         * gdbserver/gdbreplay.c
1407         * gdbserver/remote-utils.c:
1408         * ser-tcp.c:
1409         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1410         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1411         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1412         'getaddrinfo' and 'freeaddrinfo' were not available before
1413         Windows XP, and mingw.org's MinGW headers by default define
1414         _WIN32_WINNT to 0x500.
1415
1416 2019-03-01  Gary Benson <gbenson@redhat.com>
1417
1418         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1419
1420 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1421             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1422
1423         PR gdb/8527
1424         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1425         set_sigint_trap, clear_sigint_trap.
1426
1427 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1428
1429         * target.c (target_detach): Clear the regcache and the
1430         frame cache.
1431
1432 2019-02-27  Pedro Alves  <palves@redhat.com>
1433
1434         * utils.c (set_screen_size): When we cap the height/width sizes,
1435         tweak the corresponding command variable to show "unlimited":
1436
1437 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1438             Pedro Alves  <palves@redhat.com>
1439
1440         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1441         before calling rl_set_screen_size.
1442
1443 2019-02-27  Tom Tromey  <tromey@adacore.com>
1444
1445         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1446         define.
1447         * python/py-value.c: Remove Python 2.4 workaround.
1448         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1449         workaround.
1450         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1451         Python 2.4 workaround.
1452         * python/python-internal.h: Remove Python 2.4 comment.
1453         (Py_ssize_t): Don't define.
1454         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1455         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1456         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1457         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1458         * python/python.c (do_start_initialization): Remove Python 2.4
1459         workaround.
1460         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1461         (print_children): Remove Python 2.4 workaround.
1462         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1463         workaround.
1464         (CHARBUFFERPROC_NAME): Remove.
1465         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1466         Python 2.4 workaround.
1467
1468 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1469
1470         * NEWS: Note minimum Python version.
1471
1472 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1473
1474         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1475         code from these functions.  Remove corresponding ifdefs.  Use
1476         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1477         Remove gotos and target of gotos.
1478         (infpy_search_memory): Likewise.
1479
1480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1483         (hppa_gdbarch_init): Don't register deleted functions with
1484         gdbarch.
1485
1486 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1487
1488         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1489         (h8300_unwind_sp): Delete.
1490         (h8300_dummy_id): Delete.
1491         (h8300_gdbarch_init): Don't register deleted functions with
1492         gdbarch.
1493
1494 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1495
1496         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1497         (ft32_unwind_pc): Delete.
1498         (ft32_unwind_sp): Delete.
1499         (ft32_gdbarch_init): Don't register deleted functions with
1500         gdbarch.
1501
1502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1503
1504         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1505         (frv_unwind_pc): Delete.
1506         (frv_unwind_sp): Delete.
1507         (frv_gdbarch_init): Don't register deleted functions with
1508         gdbarch.
1509
1510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1511
1512         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1513         (riscv_unwind_pc): Delete.
1514         (riscv_unwind_sp): Delete.
1515         (riscv_gdbarch_init): Don't register deleted functions with
1516         gdbarch.
1517
1518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1519
1520         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1521         (csky_unwind_pc): Delete.
1522         (csky_unwind_sp): Delete.
1523         (csky_gdbarch_init): Don't register deleted functions with
1524         gdbarch.
1525
1526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1527
1528         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1529         (cris_unwind_pc): Delete.
1530         (cris_unwind_sp): Delete.
1531         (cris_gdbarch_init): Don't register deleted functions with
1532         gdbarch.
1533
1534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1535
1536         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1537         (bfin_unwind_pc): Delete.
1538         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1539
1540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1543         (arm_unwind_pc): Delete.
1544         (arm_unwind_sp): Delete.
1545         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1546
1547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1548
1549         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1550         (arc_unwind_pc): Delete.
1551         (arc_unwind_sp): Delete.
1552         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1553
1554 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1555
1556         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1557         (alpha_unwind_pc): Delete.
1558         (alpha_gdbarch_init): Don't register deleted functions with
1559         gdbarch.
1560
1561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1564         (aarch64_unwind_pc): Delete.
1565         (aarch64_unwind_sp): Delete.
1566         (aarch64_gdbarch_init): Don't register deleted functions with
1567         gdbarch.
1568
1569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1570
1571         * gdbtypes.c (type_align): Don't consider static members when
1572         computing structure alignment.
1573
1574 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1575
1576         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1577         return 0 for other types.
1578         * arch-utils.c (default_type_align): Always return 0.
1579         * gdbarch.h: Regenerate.
1580         * gdbarch.sh (type_align): Extend comment.
1581         * gdbtypes.c (type_align): Add additional comments, always call
1582         gdbarch_type_align before applying the default rules.
1583         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1584         generic code will then apply a suitable default.
1585         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1586         types, return 0 for other types.
1587
1588 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1589
1590         * NEWS: Create a new section for the next release branch.
1591         Rename the section of the current branch, now that it has
1592         been cut.
1593
1594 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1595
1596         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1597         * version.in: Bump version to 8.3.50.DATE-git.
1598
1599 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1600
1601         * aix-thread.c (ptid_cmp): Remove unused variable.
1602         (get_signaled_thread): Likewise.
1603         (store_regs_user_thread): Likewise.
1604         (store_regs_kernel_thread): Likewise.
1605         (fetch_regs_kernel_thread): Remove shadowed variable.
1606
1607 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * features/riscv/32bit-cpu.xml: Add register numbers.
1610         * features/riscv/32bit-fpu.c: Regenerate.
1611         * features/riscv/32bit-fpu.xml: Add register numbers.
1612         * features/riscv/64bit-cpu.xml: Add register numbers.
1613         * features/riscv/64bit-fpu.c: Regenerate.
1614         * features/riscv/64bit-fpu.xml: Add register numbers.
1615
1616 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1617
1618         * NEWS: Mention two argument form of gdb.Value constructor.
1619         * python/py-value.c (convert_buffer_and_type_to_value): New
1620         function.
1621         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1622         Add support for handling an optional second argument.  Call
1623         convert_buffer_and_type_to_value as appropriate.
1624         * python/python-internal.h (Py_buffer_deleter): New struct.
1625         (Py_buffer_up): New typedef.
1626
1627 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1628
1629         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1630         instead of releasing ownership.
1631
1632 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1633
1634         * dwarf2read.c (open_and_init_dwp_file): Call
1635         elf_numsections instead of bfd_count_sections to initialize
1636         dwp_file->num_sections.
1637
1638 2019-02-25  Tom Tromey  <tromey@adacore.com>
1639
1640         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1641
1642 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1643
1644         * gcore.in: Add '--readnever' option when invoking GDB.
1645
1646 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1647
1648         * MAINTAINERS: Update my email address.
1649
1650 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1651
1652         * build-id.c (build_id_to_debug_bfd_1): New function.
1653         (build_id_to_debug_bfd): Look for separate debug file in
1654         sysroot.
1655
1656 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1657
1658         * gdbarch.sh: Update the copyright year range that is placed into
1659         generated files.
1660
1661 2019-02-22  Keith Seitz  <keiths@redhat.com>
1662
1663         PR symtab/23853
1664         * linespec.c (create_sals_line_offset): Search for the default
1665         symtab's filename instead of its fullname.
1666
1667 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1668
1669         * NEWS: Update style defaults.
1670
1671 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1672
1673         * main.c (captured_main_1): Disable styling in batch mode.
1674
1675 2019-02-20  Tom Tromey  <tom@tromey.com>
1676
1677         * symtab.c (symtab_symbol_info): Fix typos.
1678
1679 2019-02-20  Tom Tromey  <tromey@adacore.com>
1680
1681         * findcmd.c (_initialize_mem_search): Use upper case for
1682         metasyntactic variables.
1683
1684 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1685
1686         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1687         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1688
1689 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1690
1691         * top.h (source_file_name): Change to std::string.
1692         * top.c (source_file_name): Likewise.
1693         (command_line_input): Adjust.
1694         * cli/cli-script.c (script_from_file): Adjust.
1695
1696 2019-02-19  Tom Tromey  <tromey@adacore.com>
1697
1698         * ravenscar-thread.c
1699         (ravenscar_thread_target::update_thread_list): Don't call
1700         ada_build_task_list.
1701         * ada-lang.h (ada_build_task_list): Don't declare.
1702         * ada-tasks.c (struct ada_tasks_inferior_data)
1703         <task_list_valid_p>: Now bool.
1704         (read_known_tasks, ada_task_list_changed)
1705         (ada_tasks_invalidate_inferior_data): Update.
1706         (read_known_tasks_array): Return bool.
1707         (read_known_tasks_list): Likewise.
1708         (read_known_tasks): Return void.
1709         (ada_build_task_list): Now static.
1710
1711 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1712
1713         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1714         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1715
1716 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1717
1718         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1719         variant for ada_tasks_pspace_data_handle and
1720         ada_tasks_inferior_data_handle.
1721         (ada_tasks_pspace_data_cleanup): New function.
1722         (ada_tasks_inferior_data_cleanup): New function.
1723
1724 2019-02-17  Tom Tromey  <tom@tromey.com>
1725
1726         * macrotab.h (macro_source_fullname): Return a std::string.
1727         * macrotab.c (macro_include, check_for_redefinition)
1728         (macro_undef, macro_lookup_definition, foreach_macro)
1729         (foreach_macro_in_scope): Update.
1730         (macro_source_fullname): Return a std::string.
1731         * macrocmd.c (show_pp_source_pos): Update.
1732
1733 2019-02-17  Tom Tromey  <tom@tromey.com>
1734
1735         * macrocmd.c (show_pp_source_pos): Style the file names.
1736
1737 2019-02-17  Tom Tromey  <tom@tromey.com>
1738
1739         PR tui/24197:
1740         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1741
1742 2019-02-17  Tom Tromey  <tom@tromey.com>
1743
1744         * ada-lang.c (user_select_syms): Use filtered printing.
1745         * utils.c (wrap_style): New global.
1746         (desired_style): Remove.
1747         (emit_style_escape): Add stream parameter.
1748         (set_output_style, reset_terminal_style, prompt_for_continue):
1749         Update.
1750         (flush_wrap_buffer): Only flush gdb_stdout.
1751         (wrap_here): Set wrap_style.
1752         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1753         treat escape sequences as a character.  Change when wrap buffer is
1754         flushed.
1755         (fputs_styled): Do not set the output style when the default is
1756         requested.
1757         * ui-style.h (struct ui_file_style) <is_default>: New method.
1758         * source.c (print_source_lines_base): Emit escape sequences in one
1759         piece.
1760
1761 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1762
1763         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1764         integers and enumeration types.
1765
1766 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1767
1768         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1769         instead of lookup_symbol_in_language
1770         (do_exact_match): New function.
1771         (ada_get_symbol_name_matcher): Return do_exact_match when
1772         doing a verbatim match.
1773
1774 2019-02-15  Tom Tromey  <tromey@adacore.com>
1775
1776         * ravenscar-thread.c (ravenscar_thread_target::resume)
1777         (ravenscar_thread_target::wait): Special case wildcard requests.
1778
1779 2019-02-15  Tom Tromey  <tromey@adacore.com>
1780
1781         * ravenscar-thread.c (base_ptid): Remove.
1782         (struct ravenscar_thread_target) <close>: New method.
1783         <m_base_ptid>: New member.
1784         <update_inferior_ptid, active_task, task_is_currently_active,
1785         runtime_initialized>: Declare methods.
1786         <ravenscar_thread_target>: Add constructor.
1787         (ravenscar_thread_target::task_is_currently_active)
1788         (ravenscar_thread_target::update_inferior_ptid)
1789         (ravenscar_runtime_initialized): Rename.  Now methods.
1790         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1791         (ravenscar_thread_target::update_thread_list): Update.
1792         (ravenscar_thread_target::active_task): Now method.
1793         (ravenscar_thread_target::store_registers)
1794         (ravenscar_thread_target::prepare_to_store)
1795         (ravenscar_thread_target::prepare_to_store)
1796         (ravenscar_thread_target::mourn_inferior): Update.
1797         (ravenscar_inferior_created): Use "new" to create target.
1798         (ravenscar_thread_target::get_ada_task_ptid): Update.
1799         (_initialize_ravenscar): Don't initialize base_ptid.
1800         (ravenscar_ops): Remove global.
1801
1802 2019-02-15  Tom Tromey  <tromey@adacore.com>
1803
1804         * target.h (push_target): Declare new overload.
1805         * target.c (push_target): New overload, taking an rvalue reference.
1806         * remote.c (remote_target::open_1): Use push_target overload.
1807         * corelow.c (core_target_open): Use push_target overload.
1808
1809 2019-02-15  Tom Tromey  <tromey@adacore.com>
1810
1811         * ravenscar-thread.c (is_ravenscar_task)
1812         (ravenscar_task_is_currently_active): Return bool.
1813         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1814         (_initialize_ravenscar): Remove "(void)".
1815         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1816         Return bool.
1817
1818 2019-02-15  Tom Tromey  <tromey@adacore.com>
1819
1820         * ravenscar-thread.c (ravenscar_runtime_initializer)
1821         (has_ravenscar_runtime, get_running_thread_id)
1822         (ravenscar_thread_target::resume): Fix indentation.
1823
1824 2019-02-15  Tom Tromey  <tromey@adacore.com>
1825
1826         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1827         from ravenscar_arch_ops.
1828         (sparc_ravenscar_ops::fetch_registers)
1829         (sparc_ravenscar_ops::store_registers): Now methods.
1830         (sparc_ravenscar_prepare_to_store): Remove.
1831         (sparc_ravenscar_ops): Redefine.
1832         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1833         methods and destructor.  Remove members.
1834         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1835         (ravenscar_thread_target::store_registers)
1836         (ravenscar_thread_target::prepare_to_store): Update.
1837         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1838         Remove.
1839         (struct ppc_ravenscar_powerpc_ops): Derive from
1840         ravenscar_arch_ops.
1841         (ppc_ravenscar_powerpc_ops::fetch_registers)
1842         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1843         (ppc_ravenscar_powerpc_ops): Redefine.
1844         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1845         (ppc_ravenscar_e500_ops::fetch_registers)
1846         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1847         (ppc_ravenscar_e500_ops): Redefine.
1848         * aarch64-ravenscar-thread.c
1849         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1850         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1851         (aarch64_ravenscar_fetch_registers)
1852         (aarch64_ravenscar_store_registers): Now methods.
1853         (aarch64_ravenscar_ops): Redefine.
1854
1855 2019-02-15  Tom Tromey  <tromey@adacore.com>
1856
1857         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1858         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1859         (ravenscar_thread_target::stopped_by_watchpoint)
1860         (ravenscar_thread_target::stopped_data_address)
1861         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1862
1863 2019-02-15  Tom Tromey  <tromey@adacore.com>
1864
1865         * ravenscar-thread.c: Fix some typos.
1866
1867 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1868             Tom Tromey  <tromey@adacore.com>
1869
1870         * ada-lang.c (ada_exception_sal): Change addr_string to a
1871         std::string.
1872         (create_ada_exception_catchpoint): Update.
1873
1874 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1875             Tom Tromey  <tromey@adacore.com>
1876
1877         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1878         (bp_location_ops): Remove.
1879         (base_breakpoint_allocate_location): Update.
1880         (free_bp_location): Update.
1881         * ada-lang.c (class ada_catchpoint_location)
1882         <ada_catchpoint_location>: Remove ops parameter.
1883         (ada_catchpoint_location_dtor): Remove.
1884         (ada_catchpoint_location_ops): Remove.
1885         (allocate_location_exception): Update.
1886         * breakpoint.h (struct bp_location_ops): Remove.
1887         (class bp_location) <bp_location>: Remove bp_location_ops
1888         parameter.
1889         <~bp_location>: Add destructor.
1890         <ops>: Remove.
1891
1892 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1893             Pedro Alves  <palves@redhat.com>
1894
1895         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1896         'PATH_MAX'.
1897
1898 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1899             Samuel Thibault  <samuel.thibault@gnu.org>
1900             Thomas Schwinge  <thomas@codesourcery.com>
1901
1902         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1903         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1904
1905 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1906
1907         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1908         (check_empty): Use "const char *".
1909
1910         * gnu-nat.c (gnu_nat_target::detach): Instead of
1911         'detach_inferior (pid)' call
1912         'detach_inferior (find_inferior_pid (pid))'.
1913
1914         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1915         'nat/fork-inferior.o'.
1916         * gnu-nat.c: #include "nat/fork-inferior.h".
1917
1918         * gnu-nat.c (gnu_nat_target::detach): Instead of
1919         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1920         * gnu-nat.h: #include "inf-child.h".
1921         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1922         'i386_gnu_nat_target::fetch_registers'.
1923         (gnu_store_registers): Rename/move to
1924         'i386_gnu_nat_target::store_registers'.
1925
1926         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1927         * gnu-nat.h (mach_thread_info): New function.
1928         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1929
1930         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1931
1932 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1933
1934         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1935
1936 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1937
1938         * windows-nat.c (windows_add_thread): Add new parameter
1939         "main_thread_p" with default value set to false.  Update
1940         function documentation as well as all callers.
1941         (windows_delete_thread): Likewise.
1942         (fake_create_process): Update call to windows_add_thread.
1943         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1944         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1945         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1946         call to windows_delete_thread.
1947
1948 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1949
1950         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1951
1952 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1953
1954         * symfile.c (find_separate_debug_file): Use canonical path of
1955         sysroot with child_path instead of gdb_sysroot if it is valid.
1956
1957 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1958
1959         * symfile.c (find_separate_debug_file): Use child_path to
1960         determine if an object file is under a sysroot.
1961
1962 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1963
1964         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1965         unittests/child-path-selftests.c.
1966         * common/pathstuff.c (child_path): New function.
1967         * common/pathstuff.h (child_path): New prototype.
1968         * unittests/child-path-selftests.c: New file.
1969
1970 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1971
1972         * symfile.c (find_separate_debug_file): Look for separate debug
1973         files in debug directories under the sysroot.
1974
1975 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1976
1977         * symtab.h (struct minimal_symbol data_p): New const method.
1978         (struct minimal_symbol text_p): Likewise.
1979         * symtab.c (output_source_filename): Use file name style
1980         to print file name.
1981         (print_symbol_info): Likewise.
1982         (print_msymbol_info): Use address style to print addresses.
1983         Use function name style to print executable text symbols.
1984         (expand_symtab_containing_pc): Use data_p.
1985         (find_pc_sect_compunit_symtab): Likewise.
1986
1987 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1988
1989         * breakpoint.c (describe_other_breakpoints): Use address style
1990         to print addresses.
1991         (say_where): Likewise.
1992
1993 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1994
1995         * ada-typeprint.c (print_func_type): Print function name
1996         style to print function name.
1997         * c-typeprint.c (c_print_type_1): Likewise.
1998
1999 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2000
2001         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2002         for execve.
2003
2004 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2005
2006         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2007         type_stack.
2008
2009 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2010
2011         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2012         TYPE_CODE_REF types.
2013
2014 2019-02-08  Jim Wilson  <jimw@sifive.com>
2015
2016         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2017         (riscv_linux_fregset): New.
2018         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2019
2020 2019-02-07  Tom Tromey  <tom@tromey.com>
2021
2022         * thread.c (thread_cancel_execution_command): Update.
2023         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2024         methods.
2025         (struct thread_fsm_ops): Remove.
2026         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2027         (thread_fsm_should_stop, thread_fsm_return_value)
2028         (thread_fsm_set_finished, thread_fsm_finished_p)
2029         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2030         Don't declare.
2031         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2032         * infrun.c (clear_proceed_status_thread)
2033         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2034         (print_stop_event): Update.
2035         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2036         Add constructor.
2037         (step_command_fsm_ops): Remove.
2038         (new_step_command_fsm): Remove.
2039         (step_1): Update.
2040         (step_command_fsm::should_stop): Rename from
2041         step_command_fsm_should_stop.
2042         (step_command_fsm::clean_up): Rename from
2043         step_command_fsm_clean_up.
2044         (step_command_fsm::do_async_reply_reason): Rename from
2045         step_command_fsm_async_reply_reason.
2046         (struct until_next_fsm): Inherit from thread_fsm.  Add
2047         constructor.
2048         (until_next_fsm_ops): Remove.
2049         (new_until_next_fsm): Remove.
2050         (until_next_fsm::should_stop): Rename from
2051         until_next_fsm_should_stop.
2052         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2053         (until_next_fsm::do_async_reply_reason): Rename from
2054         until_next_fsm_async_reply_reason.
2055         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2056         constructor.  Change type of breakpoint.
2057         (finish_command_fsm_ops): Remove.
2058         (new_finish_command_fsm): Remove.
2059         (finish_command_fsm::should_stop): Rename from
2060         finish_command_fsm_should_stop.
2061         (finish_command_fsm::clean_up): Rename from
2062         finish_command_fsm_clean_up.
2063         (finish_command_fsm::return_value): Rename from
2064         finish_command_fsm_return_value.
2065         (finish_command_fsm::do_async_reply_reason): Rename from
2066         finish_command_fsm_async_reply_reason.
2067         (finish_command): Update.
2068         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2069         Add constructor.
2070         (call_thread_fsm_ops): Remove.
2071         (call_thread_fsm::call_thread_fsm): Rename from
2072         new_call_thread_fsm.
2073         (call_thread_fsm::should_stop): Rename from
2074         call_thread_fsm_should_stop.
2075         (call_thread_fsm::should_notify_stop): Rename from
2076         call_thread_fsm_should_notify_stop.
2077         (run_inferior_call, call_function_by_hand_dummy): Update.
2078         * cli/cli-interp.c (should_print_stop_to_console): Update.
2079         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2080         Add constructor.  Change type of location_breakpoint,
2081         caller_breakpoint.
2082         (until_break_fsm_ops): Remove.
2083         (new_until_break_fsm): Remove.
2084         (until_break_fsm::should_stop): Rename from
2085         until_break_fsm_should_stop.
2086         (until_break_fsm::clean_up): Rename from
2087         until_break_fsm_clean_up.
2088         (until_break_fsm::do_async_reply_reason): Rename from
2089         until_break_fsm_async_reply_reason.
2090         (until_break_command): Update.
2091         * thread-fsm.c: Remove.
2092         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2093
2094 2019-02-07  Tom Tromey  <tom@tromey.com>
2095
2096         * yy-remap.h: Add include guard.
2097         * xtensa-tdep.h: Add include guard.
2098         * xcoffread.h: Rename include guard.
2099         * varobj-iter.h: Add include guard.
2100         * tui/tui.h: Rename include guard.
2101         * tui/tui-winsource.h: Rename include guard.
2102         * tui/tui-wingeneral.h: Rename include guard.
2103         * tui/tui-windata.h: Rename include guard.
2104         * tui/tui-win.h: Rename include guard.
2105         * tui/tui-stack.h: Rename include guard.
2106         * tui/tui-source.h: Rename include guard.
2107         * tui/tui-regs.h: Rename include guard.
2108         * tui/tui-out.h: Rename include guard.
2109         * tui/tui-layout.h: Rename include guard.
2110         * tui/tui-io.h: Rename include guard.
2111         * tui/tui-hooks.h: Rename include guard.
2112         * tui/tui-file.h: Rename include guard.
2113         * tui/tui-disasm.h: Rename include guard.
2114         * tui/tui-data.h: Rename include guard.
2115         * tui/tui-command.h: Rename include guard.
2116         * tic6x-tdep.h: Add include guard.
2117         * target/waitstatus.h: Rename include guard.
2118         * target/wait.h: Rename include guard.
2119         * target/target.h: Rename include guard.
2120         * target/resume.h: Rename include guard.
2121         * target-float.h: Rename include guard.
2122         * stabsread.h: Add include guard.
2123         * rs6000-tdep.h: Add include guard.
2124         * riscv-fbsd-tdep.h: Add include guard.
2125         * regformats/regdef.h: Rename include guard.
2126         * record.h: Rename include guard.
2127         * python/python.h: Rename include guard.
2128         * python/python-internal.h: Rename include guard.
2129         * python/py-stopevent.h: Rename include guard.
2130         * python/py-ref.h: Rename include guard.
2131         * python/py-record.h: Rename include guard.
2132         * python/py-record-full.h: Rename include guard.
2133         * python/py-record-btrace.h: Rename include guard.
2134         * python/py-instruction.h: Rename include guard.
2135         * python/py-events.h: Rename include guard.
2136         * python/py-event.h: Rename include guard.
2137         * procfs.h: Add include guard.
2138         * proc-utils.h: Add include guard.
2139         * p-lang.h: Add include guard.
2140         * or1k-tdep.h: Rename include guard.
2141         * observable.h: Rename include guard.
2142         * nto-tdep.h: Rename include guard.
2143         * nat/x86-linux.h: Rename include guard.
2144         * nat/x86-linux-dregs.h: Rename include guard.
2145         * nat/x86-gcc-cpuid.h: Add include guard.
2146         * nat/x86-dregs.h: Rename include guard.
2147         * nat/x86-cpuid.h: Rename include guard.
2148         * nat/ppc-linux.h: Rename include guard.
2149         * nat/mips-linux-watch.h: Rename include guard.
2150         * nat/linux-waitpid.h: Rename include guard.
2151         * nat/linux-ptrace.h: Rename include guard.
2152         * nat/linux-procfs.h: Rename include guard.
2153         * nat/linux-osdata.h: Rename include guard.
2154         * nat/linux-nat.h: Rename include guard.
2155         * nat/linux-namespaces.h: Rename include guard.
2156         * nat/linux-btrace.h: Rename include guard.
2157         * nat/glibc_thread_db.h: Rename include guard.
2158         * nat/gdb_thread_db.h: Rename include guard.
2159         * nat/gdb_ptrace.h: Rename include guard.
2160         * nat/fork-inferior.h: Rename include guard.
2161         * nat/amd64-linux-siginfo.h: Rename include guard.
2162         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2163         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2164         * nat/aarch64-linux.h: Rename include guard.
2165         * nat/aarch64-linux-hw-point.h: Rename include guard.
2166         * mn10300-tdep.h: Add include guard.
2167         * mips-linux-tdep.h: Add include guard.
2168         * mi/mi-parse.h: Rename include guard.
2169         * mi/mi-out.h: Rename include guard.
2170         * mi/mi-main.h: Rename include guard.
2171         * mi/mi-interp.h: Rename include guard.
2172         * mi/mi-getopt.h: Rename include guard.
2173         * mi/mi-console.h: Rename include guard.
2174         * mi/mi-common.h: Rename include guard.
2175         * mi/mi-cmds.h: Rename include guard.
2176         * mi/mi-cmd-break.h: Rename include guard.
2177         * m2-lang.h: Add include guard.
2178         * location.h: Rename include guard.
2179         * linux-record.h: Rename include guard.
2180         * linux-nat.h: Add include guard.
2181         * linux-fork.h: Add include guard.
2182         * i386-darwin-tdep.h: Rename include guard.
2183         * hppa-linux-offsets.h: Add include guard.
2184         * guile/guile.h: Rename include guard.
2185         * guile/guile-internal.h: Rename include guard.
2186         * gnu-nat.h: Rename include guard.
2187         * gdb-stabs.h: Rename include guard.
2188         * frv-tdep.h: Add include guard.
2189         * f-lang.h: Add include guard.
2190         * event-loop.h: Add include guard.
2191         * darwin-nat.h: Rename include guard.
2192         * cp-abi.h: Rename include guard.
2193         * config/sparc/nm-sol2.h: Rename include guard.
2194         * config/nm-nto.h: Rename include guard.
2195         * config/nm-linux.h: Add include guard.
2196         * config/i386/nm-i386gnu.h: Rename include guard.
2197         * config/djgpp/nl_types.h: Rename include guard.
2198         * config/djgpp/langinfo.h: Rename include guard.
2199         * compile/gcc-cp-plugin.h: Add include guard.
2200         * compile/gcc-c-plugin.h: Add include guard.
2201         * compile/compile.h: Rename include guard.
2202         * compile/compile-object-run.h: Rename include guard.
2203         * compile/compile-object-load.h: Rename include guard.
2204         * compile/compile-internal.h: Rename include guard.
2205         * compile/compile-cplus.h: Rename include guard.
2206         * compile/compile-c.h: Rename include guard.
2207         * common/xml-utils.h: Rename include guard.
2208         * common/x86-xstate.h: Rename include guard.
2209         * common/version.h: Rename include guard.
2210         * common/vec.h: Rename include guard.
2211         * common/tdesc.h: Rename include guard.
2212         * common/selftest.h: Rename include guard.
2213         * common/scoped_restore.h: Rename include guard.
2214         * common/scoped_mmap.h: Rename include guard.
2215         * common/scoped_fd.h: Rename include guard.
2216         * common/safe-iterator.h: Rename include guard.
2217         * common/run-time-clock.h: Rename include guard.
2218         * common/refcounted-object.h: Rename include guard.
2219         * common/queue.h: Rename include guard.
2220         * common/ptid.h: Rename include guard.
2221         * common/print-utils.h: Rename include guard.
2222         * common/preprocessor.h: Rename include guard.
2223         * common/pathstuff.h: Rename include guard.
2224         * common/observable.h: Rename include guard.
2225         * common/netstuff.h: Rename include guard.
2226         * common/job-control.h: Rename include guard.
2227         * common/host-defs.h: Rename include guard.
2228         * common/gdb_wait.h: Rename include guard.
2229         * common/gdb_vecs.h: Rename include guard.
2230         * common/gdb_unlinker.h: Rename include guard.
2231         * common/gdb_unique_ptr.h: Rename include guard.
2232         * common/gdb_tilde_expand.h: Rename include guard.
2233         * common/gdb_sys_time.h: Rename include guard.
2234         * common/gdb_string_view.h: Rename include guard.
2235         * common/gdb_splay_tree.h: Rename include guard.
2236         * common/gdb_setjmp.h: Rename include guard.
2237         * common/gdb_ref_ptr.h: Rename include guard.
2238         * common/gdb_optional.h: Rename include guard.
2239         * common/gdb_locale.h: Rename include guard.
2240         * common/gdb_assert.h: Rename include guard.
2241         * common/filtered-iterator.h: Rename include guard.
2242         * common/filestuff.h: Rename include guard.
2243         * common/fileio.h: Rename include guard.
2244         * common/environ.h: Rename include guard.
2245         * common/common-utils.h: Rename include guard.
2246         * common/common-types.h: Rename include guard.
2247         * common/common-regcache.h: Rename include guard.
2248         * common/common-inferior.h: Rename include guard.
2249         * common/common-gdbthread.h: Rename include guard.
2250         * common/common-exceptions.h: Rename include guard.
2251         * common/common-defs.h: Rename include guard.
2252         * common/common-debug.h: Rename include guard.
2253         * common/cleanups.h: Rename include guard.
2254         * common/buffer.h: Rename include guard.
2255         * common/btrace-common.h: Rename include guard.
2256         * common/break-common.h: Rename include guard.
2257         * cli/cli-utils.h: Rename include guard.
2258         * cli/cli-style.h: Rename include guard.
2259         * cli/cli-setshow.h: Rename include guard.
2260         * cli/cli-script.h: Rename include guard.
2261         * cli/cli-interp.h: Rename include guard.
2262         * cli/cli-decode.h: Rename include guard.
2263         * cli/cli-cmds.h: Rename include guard.
2264         * charset-list.h: Add include guard.
2265         * buildsym-legacy.h: Rename include guard.
2266         * bfin-tdep.h: Add include guard.
2267         * ax.h: Rename include guard.
2268         * arm-linux-tdep.h: Add include guard.
2269         * arm-fbsd-tdep.h: Add include guard.
2270         * arch/xtensa.h: Rename include guard.
2271         * arch/tic6x.h: Add include guard.
2272         * arch/i386.h: Add include guard.
2273         * arch/arm.h: Rename include guard.
2274         * arch/arm-linux.h: Rename include guard.
2275         * arch/arm-get-next-pcs.h: Rename include guard.
2276         * arch/amd64.h: Add include guard.
2277         * arch/aarch64-insn.h: Rename include guard.
2278         * arch-utils.h: Rename include guard.
2279         * annotate.h: Add include guard.
2280         * amd64-darwin-tdep.h: Rename include guard.
2281         * aarch64-linux-tdep.h: Add include guard.
2282         * aarch64-fbsd-tdep.h: Add include guard.
2283         * aarch32-linux-nat.h: Add include guard.
2284
2285 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2286
2287         * macrotab.c (macro_define_internal): New function that
2288         factorizes macro_define_object_internal and macro_define_function
2289         code.
2290         (macro_define_object_internal): Use macro_define_internal.
2291         (macro_define_function): Likewise.
2292
2293 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2294
2295         * macrocmd.c (extract_identifier): Return
2296         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2297         callers.
2298
2299 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2300
2301         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2302
2303 2019-02-05  Tom Tromey  <tom@tromey.com>
2304
2305         * target.c (target_stack::unpush): Move assertion earlier.
2306
2307 2019-01-30  Tom Tromey  <tom@tromey.com>
2308
2309         PR python/23615:
2310         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2311         (gdbpy_parse_and_eval): Likewise.
2312         * python/python-internal.h (gdbpy_allow_threads): New class.
2313
2314 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2315
2316         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2317         (aarch64_fbsd_fpregmap): Move earlier.
2318         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2319         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2320         instead of individual calls to trad_frame_set_reg_addr.
2321         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2322         earlier.
2323         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2324         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2325         instead of individual calls to trad_frame_set_reg_addr.
2326
2327 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2328
2329         * CONTRIBUTE: Replace contribution list with wiki link.
2330
2331 2019-01-25  Tom Tromey  <tom@tromey.com>
2332
2333         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2334
2335 2019-01-25  Tom Tromey  <tom@tromey.com>
2336
2337         * xtensa-linux-nat.c: Fix common/ includes.
2338         * xml-support.h: Fix common/ includes.
2339         * xml-support.c: Fix common/ includes.
2340         * x86-linux-nat.c: Fix common/ includes.
2341         * windows-nat.c: Fix common/ includes.
2342         * varobj.h: Fix common/ includes.
2343         * varobj.c: Fix common/ includes.
2344         * value.c: Fix common/ includes.
2345         * valops.c: Fix common/ includes.
2346         * utils.c: Fix common/ includes.
2347         * unittests/xml-utils-selftests.c: Fix common/ includes.
2348         * unittests/utils-selftests.c: Fix common/ includes.
2349         * unittests/unpack-selftests.c: Fix common/ includes.
2350         * unittests/tracepoint-selftests.c: Fix common/ includes.
2351         * unittests/style-selftests.c: Fix common/ includes.
2352         * unittests/string_view-selftests.c: Fix common/ includes.
2353         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2354         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2355         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2356         * unittests/rsp-low-selftests.c: Fix common/ includes.
2357         * unittests/parse-connection-spec-selftests.c: Fix common/
2358         includes.
2359         * unittests/optional-selftests.c: Fix common/ includes.
2360         * unittests/offset-type-selftests.c: Fix common/ includes.
2361         * unittests/observable-selftests.c: Fix common/ includes.
2362         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2363         * unittests/memrange-selftests.c: Fix common/ includes.
2364         * unittests/memory-map-selftests.c: Fix common/ includes.
2365         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2366         * unittests/function-view-selftests.c: Fix common/ includes.
2367         * unittests/environ-selftests.c: Fix common/ includes.
2368         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2369         * unittests/common-utils-selftests.c: Fix common/ includes.
2370         * unittests/cli-utils-selftests.c: Fix common/ includes.
2371         * unittests/array-view-selftests.c: Fix common/ includes.
2372         * ui-file.c: Fix common/ includes.
2373         * tui/tui-io.c: Fix common/ includes.
2374         * tracepoint.h: Fix common/ includes.
2375         * tracepoint.c: Fix common/ includes.
2376         * tracefile-tfile.c: Fix common/ includes.
2377         * top.h: Fix common/ includes.
2378         * top.c: Fix common/ includes.
2379         * thread.c: Fix common/ includes.
2380         * target/waitstatus.h: Fix common/ includes.
2381         * target/waitstatus.c: Fix common/ includes.
2382         * target.h: Fix common/ includes.
2383         * target.c: Fix common/ includes.
2384         * target-memory.c: Fix common/ includes.
2385         * target-descriptions.c: Fix common/ includes.
2386         * symtab.h: Fix common/ includes.
2387         * symfile.c: Fix common/ includes.
2388         * stap-probe.c: Fix common/ includes.
2389         * spu-linux-nat.c: Fix common/ includes.
2390         * sparc-nat.c: Fix common/ includes.
2391         * source.c: Fix common/ includes.
2392         * solib.c: Fix common/ includes.
2393         * solib-target.c: Fix common/ includes.
2394         * ser-unix.c: Fix common/ includes.
2395         * ser-tcp.c: Fix common/ includes.
2396         * ser-pipe.c: Fix common/ includes.
2397         * ser-base.c: Fix common/ includes.
2398         * selftest-arch.c: Fix common/ includes.
2399         * s12z-tdep.c: Fix common/ includes.
2400         * rust-exp.y: Fix common/ includes.
2401         * rs6000-aix-tdep.c: Fix common/ includes.
2402         * riscv-tdep.c: Fix common/ includes.
2403         * remote.c: Fix common/ includes.
2404         * remote-notif.h: Fix common/ includes.
2405         * remote-fileio.h: Fix common/ includes.
2406         * remote-fileio.c: Fix common/ includes.
2407         * regcache.h: Fix common/ includes.
2408         * regcache.c: Fix common/ includes.
2409         * record-btrace.c: Fix common/ includes.
2410         * python/python.c: Fix common/ includes.
2411         * python/py-type.c: Fix common/ includes.
2412         * python/py-inferior.c: Fix common/ includes.
2413         * progspace.h: Fix common/ includes.
2414         * producer.c: Fix common/ includes.
2415         * procfs.c: Fix common/ includes.
2416         * proc-api.c: Fix common/ includes.
2417         * printcmd.c: Fix common/ includes.
2418         * ppc-linux-nat.c: Fix common/ includes.
2419         * parser-defs.h: Fix common/ includes.
2420         * osdata.c: Fix common/ includes.
2421         * obsd-nat.c: Fix common/ includes.
2422         * nat/x86-linux.c: Fix common/ includes.
2423         * nat/x86-linux-dregs.c: Fix common/ includes.
2424         * nat/x86-dregs.h: Fix common/ includes.
2425         * nat/x86-dregs.c: Fix common/ includes.
2426         * nat/ppc-linux.c: Fix common/ includes.
2427         * nat/mips-linux-watch.h: Fix common/ includes.
2428         * nat/mips-linux-watch.c: Fix common/ includes.
2429         * nat/linux-waitpid.c: Fix common/ includes.
2430         * nat/linux-ptrace.h: Fix common/ includes.
2431         * nat/linux-ptrace.c: Fix common/ includes.
2432         * nat/linux-procfs.c: Fix common/ includes.
2433         * nat/linux-personality.c: Fix common/ includes.
2434         * nat/linux-osdata.c: Fix common/ includes.
2435         * nat/linux-namespaces.c: Fix common/ includes.
2436         * nat/linux-btrace.h: Fix common/ includes.
2437         * nat/linux-btrace.c: Fix common/ includes.
2438         * nat/fork-inferior.c: Fix common/ includes.
2439         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2440         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2441         * nat/aarch64-linux.c: Fix common/ includes.
2442         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2443         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2444         * namespace.h: Fix common/ includes.
2445         * mips-linux-tdep.c: Fix common/ includes.
2446         * minsyms.c: Fix common/ includes.
2447         * mi/mi-parse.h: Fix common/ includes.
2448         * mi/mi-main.c: Fix common/ includes.
2449         * mi/mi-cmd-env.c: Fix common/ includes.
2450         * memrange.h: Fix common/ includes.
2451         * memattr.c: Fix common/ includes.
2452         * maint.h: Fix common/ includes.
2453         * maint.c: Fix common/ includes.
2454         * main.c: Fix common/ includes.
2455         * machoread.c: Fix common/ includes.
2456         * location.c: Fix common/ includes.
2457         * linux-thread-db.c: Fix common/ includes.
2458         * linux-nat.c: Fix common/ includes.
2459         * linux-fork.c: Fix common/ includes.
2460         * inline-frame.c: Fix common/ includes.
2461         * infrun.c: Fix common/ includes.
2462         * inflow.c: Fix common/ includes.
2463         * inferior.h: Fix common/ includes.
2464         * inferior.c: Fix common/ includes.
2465         * infcmd.c: Fix common/ includes.
2466         * inf-ptrace.c: Fix common/ includes.
2467         * inf-child.c: Fix common/ includes.
2468         * ia64-linux-nat.c: Fix common/ includes.
2469         * i387-tdep.c: Fix common/ includes.
2470         * i386-tdep.c: Fix common/ includes.
2471         * i386-linux-tdep.c: Fix common/ includes.
2472         * i386-linux-nat.c: Fix common/ includes.
2473         * i386-go32-tdep.c: Fix common/ includes.
2474         * i386-fbsd-tdep.c: Fix common/ includes.
2475         * i386-fbsd-nat.c: Fix common/ includes.
2476         * guile/scm-type.c: Fix common/ includes.
2477         * guile/guile.c: Fix common/ includes.
2478         * go32-nat.c: Fix common/ includes.
2479         * gnu-nat.c: Fix common/ includes.
2480         * gdbthread.h: Fix common/ includes.
2481         * gdbarch-selftests.c: Fix common/ includes.
2482         * gdb_usleep.c: Fix common/ includes.
2483         * gdb_select.h: Fix common/ includes.
2484         * gdb_bfd.c: Fix common/ includes.
2485         * gcore.c: Fix common/ includes.
2486         * fork-child.c: Fix common/ includes.
2487         * findvar.c: Fix common/ includes.
2488         * fbsd-nat.c: Fix common/ includes.
2489         * event-top.c: Fix common/ includes.
2490         * event-loop.c: Fix common/ includes.
2491         * dwarf2read.c: Fix common/ includes.
2492         * dwarf2loc.c: Fix common/ includes.
2493         * dwarf2-frame.c: Fix common/ includes.
2494         * dwarf-index-cache.c: Fix common/ includes.
2495         * dtrace-probe.c: Fix common/ includes.
2496         * disasm-selftests.c: Fix common/ includes.
2497         * defs.h: Fix common/ includes.
2498         * csky-tdep.c: Fix common/ includes.
2499         * cp-valprint.c: Fix common/ includes.
2500         * cp-support.h: Fix common/ includes.
2501         * cp-support.c: Fix common/ includes.
2502         * corelow.c: Fix common/ includes.
2503         * completer.h: Fix common/ includes.
2504         * completer.c: Fix common/ includes.
2505         * compile/compile.c: Fix common/ includes.
2506         * compile/compile-loc2c.c: Fix common/ includes.
2507         * compile/compile-cplus-types.c: Fix common/ includes.
2508         * compile/compile-cplus-symbols.c: Fix common/ includes.
2509         * command.h: Fix common/ includes.
2510         * cli/cli-dump.c: Fix common/ includes.
2511         * cli/cli-cmds.c: Fix common/ includes.
2512         * charset.c: Fix common/ includes.
2513         * build-id.c: Fix common/ includes.
2514         * btrace.h: Fix common/ includes.
2515         * btrace.c: Fix common/ includes.
2516         * breakpoint.h: Fix common/ includes.
2517         * breakpoint.c: Fix common/ includes.
2518         * ax.h:
2519         (enum agent_op): Fix common/ includes.
2520         * ax-general.c (struct aop_map): Fix common/ includes.
2521         * ax-gdb.c: Fix common/ includes.
2522         * auxv.c: Fix common/ includes.
2523         * auto-load.c: Fix common/ includes.
2524         * arm-tdep.c: Fix common/ includes.
2525         * arch/riscv.c: Fix common/ includes.
2526         * arch/ppc-linux-common.c: Fix common/ includes.
2527         * arch/i386.c: Fix common/ includes.
2528         * arch/arm.c: Fix common/ includes.
2529         * arch/arm-linux.c: Fix common/ includes.
2530         * arch/arm-get-next-pcs.c: Fix common/ includes.
2531         * arch/amd64.c: Fix common/ includes.
2532         * arch/aarch64.c: Fix common/ includes.
2533         * arch/aarch64-insn.c: Fix common/ includes.
2534         * arch-utils.c: Fix common/ includes.
2535         * amd64-windows-tdep.c: Fix common/ includes.
2536         * amd64-tdep.c: Fix common/ includes.
2537         * amd64-sol2-tdep.c: Fix common/ includes.
2538         * amd64-obsd-tdep.c: Fix common/ includes.
2539         * amd64-nbsd-tdep.c: Fix common/ includes.
2540         * amd64-linux-tdep.c: Fix common/ includes.
2541         * amd64-linux-nat.c: Fix common/ includes.
2542         * amd64-fbsd-tdep.c: Fix common/ includes.
2543         * amd64-fbsd-nat.c: Fix common/ includes.
2544         * amd64-dicos-tdep.c: Fix common/ includes.
2545         * amd64-darwin-tdep.c: Fix common/ includes.
2546         * agent.c: Fix common/ includes.
2547         * ada-lang.h: Fix common/ includes.
2548         * ada-lang.c: Fix common/ includes.
2549         * aarch64-tdep.c: Fix common/ includes.
2550
2551 2019-01-25  Tom Tromey  <tom@tromey.com>
2552
2553         * common/create-version.sh: Use common/version.h.
2554
2555 2019-01-24  Pedro Alves  <palves@redhat.com>
2556
2557         * infrun.c (signal_stop, signal_print, signal_program)
2558         (signal_catch, signal_pass): Now arrays instead of pointers.
2559         (update_signals_program_target, do_target_resume)
2560         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2561         * linux-nat.c (linux_nat_target::pass_signals)
2562         (linux_nat_target::create_inferior, linux_nat_target::attach):
2563         Adjust.
2564         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2565         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2566         * procfs.c (procfs_target::pass_signals): Adjust.
2567         * record-full.c (record_full_target::resume): Adjust.
2568         * remote.c (remote_target::pass_signals)
2569         (remote_target::program_signals): Adjust.
2570         * target-debug.h (target_debug_print_signals): Now takes a
2571         gdb::array_view as parameter.  Adjust.
2572         * target.h (target_ops) <pass_signals, program_signals>: Replace
2573         pointer and length parameters with gdb::array_view.
2574         (target_pass_signals, target_program_signals): Likewise.
2575         * target-delegates.c: Regenerate.
2576
2577 2019-01-24  Pedro Alves  <palves@redhat.com>
2578
2579         * common/forward-scope-exit.h
2580         (forward_scope_exit::forward_scope_exit): Pass arguments to
2581         m_bind_function directly, instead of creating a std::bind and
2582         copying that.
2583
2584 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2585
2586         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2587         for static members.
2588         (pass_in_v_vfp_candidate): Likewise.
2589
2590 2019-01-23  Tom Tromey  <tom@tromey.com>
2591             Pedro Alves  <palves@redhat.com>
2592
2593         * regcache.c (class regcache_invalidator): Remove.
2594         (regcache::raw_write): Use make_scope_exit.
2595
2596 2019-01-23  Tom Tromey  <tom@tromey.com>
2597
2598         * ui-out.h (class ui_out_emit_type): Update comment.
2599
2600 2019-01-23  Tom Tromey  <tom@tromey.com>
2601
2602         * infrun.c (fetch_inferior_event): Update comment.
2603
2604 2019-01-23  Tom Tromey  <tom@tromey.com>
2605             Pedro Alves  <palves@redhat.com>
2606
2607         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2608         parameter.
2609         (fetch_inferior_event): Use SCOPE_EXIT.
2610
2611
2612 2019-01-23  Tom Tromey  <tom@tromey.com>
2613             Pedro Alves  <palves@redhat.com>
2614
2615         * infrun.c (disable_thread_events): Delete.
2616         (stop_all_threads): Use SCOPE_EXIT.
2617
2618 2019-01-23  Tom Tromey  <tom@tromey.com>
2619             Pedro Alves  <palves@redhat.com>
2620
2621         * symfile.c: Include forward-scope-exit.h.
2622         (clear_symtab_users_cleanup): Replace forward declaration with
2623         a FORWARD_SCOPE_EXIT.
2624         (syms_from_objfile_1): Use the forward_scope_exit and
2625         gdb::optional instead of cleanup_function.
2626         (reread_symbols): Use the forward_scope_exit instead of
2627         cleanup_function.
2628         (clear_symtab_users_cleanup): Remove function.
2629
2630 2019-01-23  Tom Tromey  <tom@tromey.com>
2631             Pedro Alves  <palves@redhat.com>
2632
2633         * linux-nat.c: Include scope-exit.h.
2634         (cleanup_target_stop): Remove.
2635         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2636         SCOPE_EXIT.
2637
2638 2019-01-23  Tom Tromey  <tom@tromey.com>
2639             Pedro Alves  <palves@redhat.com>
2640
2641         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2642         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2643
2644 2019-01-23  Tom Tromey  <tom@tromey.com>
2645             Andrew Burgess  <andrew.burgess@embecosm.com>
2646             Pedro Alves  <palves@redhat.com>
2647
2648         * infrun.c (fetch_inferior_event): Use scope_exit.
2649         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2650         * top.c (execute_command): Use scope_exit.
2651         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2652         * utils.c (do_bpstat_clear_actions_cleanup)
2653         (make_bpstat_clear_actions_cleanup): Remove.
2654
2655 2019-01-23  Tom Tromey  <tom@tromey.com>
2656             Pedro Alves  <palves@redhat.com>
2657
2658         * infrun.c: Include "common/scope-exit.h"
2659         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2660         (wait_for_inferior): Use SCOPE_EXIT.
2661         (fetch_inferior_event): Use scope_exit.
2662
2663 2019-01-23  Tom Tromey  <tom@tromey.com>
2664             Pedro Alves  <palves@redhat.com>
2665
2666         * breakpoint.c (create_breakpoint): Remove cleanup.
2667
2668 2019-01-23  Tom Tromey  <tom@tromey.com>
2669             Andrew Burgess  <andrew.burgess@embecosm.com>
2670             Pedro Alves  <palves@redhat.com>
2671
2672 2019-01-23  Pedro Alves  <palves@redhat.com>
2673
2674         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2675
2676 2019-01-23  Pedro Alves  <palves@redhat.com>
2677             Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * gdbthread.h: Include "common/forward-scope-exit.h".
2680         (scoped_finish_thread_state): Redefine custom class in terms of
2681         forward_scope_exit.
2682
2683 2019-01-23  Pedro Alves  <palves@redhat.com>
2684             Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * common/forward-scope-exit.h: New file.
2687
2688 2019-01-23  Pedro Alves  <palves@redhat.com>
2689             Andrew Burgess  <andrew.burgess@embecosm.com>
2690             Tom Tromey  <tom@tromey.com>
2691
2692         * common/scope-exit.h: New file.
2693
2694 2019-01-23  Pedro Alves  <palves@redhat.com>
2695
2696         * common/preprocessor.h (ESC): Rename to ...
2697         (ESC_PARENS): ... this.
2698         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2699         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2700
2701 2019-01-23  Tom Tromey  <tom@tromey.com>
2702
2703         * language.h (class scoped_switch_to_sym_language_if_auto):
2704         Initialize m_lang in both cases.
2705
2706 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2707
2708         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2709         with XCNEW.
2710
2711 2019-01-22  Tom Tromey  <tom@tromey.com>
2712
2713         * corelow.c: Do not include sys/file.h.
2714
2715 2019-01-22  Tom Tromey  <tom@tromey.com>
2716
2717         * tui/tui-wingeneral.h: Include gdb_curses.h.
2718
2719 2019-01-22  Tom Tromey  <tom@tromey.com>
2720
2721         * source-cache.h (class source_cache) <get_source_lines,
2722         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2723
2724 2019-01-22  Tom Tromey  <tom@tromey.com>
2725
2726         * remote-fileio.h (struct remote_target): Declare.
2727
2728 2019-01-22  Tom Tromey  <tom@tromey.com>
2729
2730         * python/py-arch.c: Do not include py-ref.h.
2731         * python/py-bpevent.c: Do not include py-ref.h.
2732         * python/py-cmd.c: Do not include py-ref.h.
2733         * python/py-continueevent.c: Do not include py-ref.h.
2734         * python/py-event.h: Do not include py-ref.h.
2735         * python/py-evtregistry.c: Do not include py-ref.h.
2736         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2737         * python/py-frame.c: Do not include py-ref.h.
2738         * python/py-framefilter.c: Do not include py-ref.h.
2739         * python/py-function.c: Do not include py-ref.h.
2740         * python/py-infevents.c: Do not include py-ref.h.
2741         * python/py-linetable.c: Do not include py-ref.h.
2742         * python/py-objfile.c: Do not include py-ref.h.
2743         * python/py-param.c: Do not include py-ref.h.
2744         * python/py-prettyprint.c: Do not include py-ref.h.
2745         * python/py-progspace.c: Do not include py-ref.h.
2746         * python/py-symbol.c: Do not include py-ref.h.
2747         * python/py-symtab.c: Do not include py-ref.h.
2748         * python/py-type.c: Do not include py-ref.h.
2749         * python/py-unwind.c: Do not include py-ref.h.
2750         * python/py-utils.c: Do not include py-ref.h.
2751         * python/py-value.c: Do not include py-ref.h.
2752         * python/py-varobj.c: Do not include py-ref.h.
2753         * python/py-xmethods.c: Do not include py-ref.h.
2754         * python/python.c: Do not include py-ref.h.
2755         * varobj.c: Do not include py-ref.h.
2756
2757 2019-01-22  Tom Tromey  <tom@tromey.com>
2758
2759         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2760         keyword for bcache.
2761
2762 2019-01-22  Tom Tromey  <tom@tromey.com>
2763
2764         * compile/compile-cplus-types.c: Remove a comment by #include.
2765
2766 2019-01-22  Tom Tromey  <tom@tromey.com>
2767
2768         * compile/gcc-c-plugin.h: Include compile-internal.h.
2769
2770 2019-01-22  Tom Tromey  <tom@tromey.com>
2771
2772         * stabsread.c (EXTERN): Do not define.
2773         (symnum, next_symbol_text_func, processing_gcc_compilation)
2774         (within_function, global_sym_chain, global_stabs)
2775         (previous_stab_code, this_object_header_files)
2776         (n_this_object_header_files)
2777         (n_allocated_this_object_header_files): Define.
2778         * stabsread.h (EXTERN): Never define.  Use "extern".
2779
2780 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2781
2782         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2783         history_value.
2784
2785 2019-01-21  Tom Tromey  <tom@tromey.com>
2786
2787         * ui-out.c: Fix includes.
2788         * tui/tui-source.c: Fix includes.
2789         * target.c: Fix includes.
2790         * remote.c: Fix includes.
2791         * regcache.c: Fix includes.
2792         * python/py-block.c: Fix includes.
2793         * printcmd.c: Fix includes.
2794         * or1k-tdep.c: Fix includes.
2795         * mi/mi-main.c: Fix includes.
2796         * m32r-tdep.c: Fix includes.
2797         * csky-tdep.c: Fix includes.
2798         * compile/compile-cplus-types.c: Fix includes.
2799         * cli/cli-interp.c: Fix includes.
2800
2801 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2802
2803         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2804         for padding.
2805
2806 2019-01-16  Tom Tromey  <tom@tromey.com>
2807
2808         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2809         earlier.
2810         (struct objfile) <msymbols_range>: Move from top level.
2811         <msymbols>: New method.
2812         (class objfile_msymbols): Remove.
2813         * symtab.c (default_collect_symbol_completion_matches_break_on):
2814         Update.
2815         * symmisc.c (dump_msymbols): Update.
2816         * stabsread.c (scan_file_globals): Update.
2817         * objc-lang.c (info_selectors_command, info_classes_command)
2818         (find_methods): Update.
2819         * minsyms.c (find_solib_trampoline_target): Update.
2820         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2821         * coffread.c (coff_symfile_read): Update.
2822         * ada-lang.c (ada_lookup_simple_minsym)
2823         (ada_collect_symbol_completion_matches): Update.
2824
2825 2019-01-16  Tom Tromey  <tom@tromey.com>
2826
2827         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2828         type.  Remove no-argument constructor.
2829         <iterator::operator++>: Simplify.
2830         <begin>: Update.
2831         <end>: Use minimal_symbol_count.
2832
2833 2019-01-16  Tom Tromey  <tom@tromey.com>
2834
2835         * objfiles.h (struct objfile) <psymtabs>: New method.
2836         (class objfile_psymtabs): Remove.
2837         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2838         typedef.
2839         <range>: New method.
2840         (require_partial_symbols): Change return type.
2841         * psymtab.c (require_partial_symbols)
2842         (psym_expand_symtabs_matching): Update.
2843         * mdebugread.c (parse_partial_symbols): Update.
2844         * dbxread.c (dbx_end_psymtab): Update.
2845
2846 2019-01-15  Tom Tromey  <tom@tromey.com>
2847
2848         * symtab.c (lookup_objfile_from_block)
2849         (lookup_symbol_in_objfile_symtabs)
2850         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2851         (find_line_symtab, info_sources_command)
2852         (default_collect_symbol_completion_matches_break_on)
2853         (make_source_files_completion_list): Update.
2854         * symmisc.c (print_objfile_statistics, dump_objfile)
2855         (maintenance_print_symbols, maintenance_info_symtabs)
2856         (maintenance_check_symtabs, maintenance_info_line_tables):
2857         Update.
2858         * source.c (select_source_symtab)
2859         (forget_cached_source_info_for_objfile): Update.
2860         * objfiles.h (class objfile_compunits): Remove.
2861         (struct objfile) <compunits_range>: New typedef.
2862         (compunits): New method.
2863         * objfiles.c (objfile_relocate1): Update.
2864         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2865         * maint.c (count_symtabs_and_blocks): Update.
2866         * linespec.c (iterate_over_all_matching_symtabs): Update.
2867         * cp-support.c (add_symbol_overload_list_qualified): Update.
2868         * coffread.c (coff_symtab_read): Update.
2869         * ada-lang.c (add_nonlocal_symbols)
2870         (ada_collect_symbol_completion_matches)
2871         (ada_add_global_exceptions): Update.
2872
2873 2019-01-15  Tom Tromey  <tom@tromey.com>
2874
2875         * progspace.h (program_space) <objfiles_safe_range>: New
2876         typedef.
2877         <objfiles_safe>: New method.
2878         * objfiles.h (class all_objfiles_safe): Remove.
2879         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2880         * jit.c (jit_inferior_exit_hook): Update.
2881
2882 2019-01-17  Tom Tromey  <tom@tromey.com>
2883
2884         * progspace.h (program_space) <objfiles_range>: New typedef.
2885         <objfiles>: New method.
2886         <objfiles_head>: Rename from objfiles.
2887         (object_files): Update.
2888         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2889         * guile/scm-pretty-print.c
2890         (ppscm_find_pretty_printer_from_objfiles): Update.
2891         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2892         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2893         Update.
2894         * python/py-progspace.c (pspy_get_objfiles): Update.
2895         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2896         Update.
2897         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2898         (objfpy_lookup_objfile_by_build_id): Update.
2899         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2900         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2901         Update.
2902         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2903         (expand_symtab_containing_pc, lookup_objfile_from_block)
2904         (lookup_static_symbol, basic_lookup_transparent_type)
2905         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2906         (find_line_symtab, info_sources_command)
2907         (default_collect_symbol_completion_matches_break_on)
2908         (make_source_files_completion_list, find_main_name): Update.
2909         * symmisc.c (print_symbol_bcache_statistics)
2910         (print_objfile_statistics, maintenance_print_symbols)
2911         (maintenance_print_msymbols, maintenance_print_objfiles)
2912         (maintenance_info_symtabs, maintenance_check_symtabs)
2913         (maintenance_expand_symtabs, maintenance_info_line_tables):
2914         Update.
2915         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2916         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2917         (map_overlay_command, unmap_overlay_command)
2918         (simple_overlay_update, expand_symtabs_matching)
2919         (map_symbol_filenames): Update.
2920         * symfile-debug.c (set_debug_symfile): Update.
2921         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2922         Update.
2923         * source.c (select_source_symtab, forget_cached_source_info):
2924         Update.
2925         * solib.c (solib_read_symbols): Update.
2926         * solib-spu.c (append_ocl_sos): Update.
2927         * psymtab.c (maintenance_print_psymbols)
2928         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2929         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2930         * printcmd.c (info_symbol_command): Update.
2931         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2932         Update.
2933         * objfiles.h (class all_objfiles): Remove.
2934         * objfiles.c (have_partial_symbols, have_full_symbols)
2935         (have_minimal_symbols, qsort_cmp, update_section_map)
2936         (shared_objfile_contains_address_p)
2937         (default_iterate_over_objfiles_in_search_order): Update.
2938         * objc-lang.c (info_selectors_command, info_classes_command)
2939         (find_methods): Update.
2940         * minsyms.c (find_solib_trampoline_target): Update.
2941         * maint.c (maintenance_info_sections)
2942         (maintenance_translate_address, count_symtabs_and_blocks):
2943         Update.
2944         * main.c (captured_main_1): Update.
2945         * linux-thread-db.c (try_thread_db_load_from_pdir)
2946         (has_libpthread): Update.
2947         * linespec.c (iterate_over_all_matching_symtabs)
2948         (search_minsyms_for_name): Update.
2949         * jit.c (jit_find_objf_with_entry_addr): Update.
2950         * hppa-tdep.c (find_unwind_entry)
2951         (hppa_lookup_stub_minimal_symbol): Update.
2952         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2953         Update.
2954         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2955         (elf_gnu_ifunc_resolve_by_got): Update.
2956         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2957         * dwarf-index-write.c (save_gdb_index_command): Update.
2958         * cp-support.c (add_symbol_overload_list_qualified): Update.
2959         * breakpoint.c (create_overlay_event_breakpoint)
2960         (create_longjmp_master_breakpoint)
2961         (create_std_terminate_master_breakpoint)
2962         (create_exception_master_breakpoint): Update.
2963         * blockframe.c (find_pc_partial_function): Update.
2964         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2965         (ada_collect_symbol_completion_matches)
2966         (ada_add_global_exceptions): Update.
2967
2968 2019-01-17  Tom Tromey  <tom@tromey.com>
2969
2970         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2971         declare VEC.
2972         (solib_target_parse_libraries): Change return type.
2973         (library_list_start_segment, library_list_start_section)
2974         (library_list_end_library, library_list_start_library); Update.
2975         (solib_target_free_library_list): Remove.
2976         (solib_target_parse_libraries): Remove cleanup.  Change return
2977         type.
2978         (solib_target_current_sos): Update.
2979
2980 2019-01-17  Tom Tromey  <tromey@bapiya>
2981
2982         * valprint.c: Replace "the the" with "the".
2983         * symtab.c: Replace "the the" with "the".
2984         * solib.c: Replace "the the" with "the".
2985         * solib-dsbt.c: Replace "the the" with "the".
2986         * linespec.c: Replace "the the" with "the".
2987         * dwarf2loc.h: Replace "the the" with "the".
2988         * amd64-windows-tdep.c: Replace "the the" with "the".
2989         * aarch64-tdep.c: Replace "the the" with "the".
2990
2991 2019-01-16  Keith Seitz  <keiths@redhat.com>
2992
2993         PR gdb/23773
2994         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2995         <builder>: Rename to ..
2996         <m_builder>: ... this and make private.
2997         (dwarf2_cu::get_builder): New method.  Change all users of
2998         `builder' to use this method.
2999         (dwarf2_start_symtab): Move to ...
3000         (dwarf2_cu::start_symtab): ... here.  Update all callers
3001         (setup_type_unit_groups): Move to ...
3002         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3003         callers.
3004         (dwarf2_cu::reset_builder): New method.
3005         (process_full_compunit, process_full_type_unit): Use
3006         dwarf2_cu::reset_builder.
3007         (follow_die_offset): Record the ancestor CU if it is different
3008         from the followed DIE's CU.
3009         (follow_die_sig_1): Likewise.
3010
3011 2019-01-15  Tom Tromey  <tom@tromey.com>
3012
3013         * remote.c (class remote_state) <buf>: Now a char_vector.
3014         <buf_size>: Remove.
3015         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3016         parameter.
3017         (remote_target::getpkt_or_notif_sane_1)
3018         (remote_target::getpkt_sane)
3019         (remote_target::getpkt_or_notif_sane): Likewise.
3020         (class remote_target) <putpkt>: New overload.
3021         (remote_target::read_frame): Change type of "buf_p".  Remove
3022         sizeof_p parameter.
3023         (packet_ok): New overload.
3024         (packet_check_result): New overload.
3025         Update all uses.
3026
3027 2019-01-14  Tom Tromey  <tom@tromey.com>
3028
3029         * remote-notif.c (handle_notification, remote_notif_ack)
3030         (remote_notif_parse): Make "buf" const.
3031         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3032         const.
3033         (remote_notif_parse, remote_notif_ack, handle_notification):
3034         Likewise.
3035         * remote.c (remote_notif_stop_parse): Make "buf" const.
3036         (remote_target::remote_parse_stop_reply): Make "buf" const.
3037         (remote_notif_stop_ack): Make "buf" const.
3038
3039 2019-01-14  Tom Tromey  <tom@tromey.com>
3040
3041         * remote.c (remote_console_output): Make parameter const.
3042
3043 2019-01-14  Tom Tromey  <tom@tromey.com>
3044
3045         * target-debug.h (target_debug_print_signals): Constify.
3046         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3047         * procfs.c (procfs_target::pass_signals): Update.
3048         * linux-nat.c (linux_nat_target::pass_signals): Update.
3049         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3050         * target-delegates.c: Rebuild.
3051         * remote.c (remote_target::program_signals): Update.
3052         (remote_target::pass_signals): Update.
3053         * target.c (target_pass_signals): Constify argument.
3054         (target_program_signals): Likewise.
3055         * target.h (struct target_ops) <pass_signals, program_signals>:
3056         Constify argument.
3057         (target_pass_signals, target_program_signals): Constify argument.
3058
3059 2019-01-14  Tom Tromey  <tom@tromey.com>
3060
3061         PR tui/28819:
3062         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3063
3064 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3065
3066         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3067         field.
3068         * rs6000-tdep.c: Include reggroups.h.
3069         (IS_V_ALIAS_PSEUDOREG): Define.
3070         (rs6000_register_name): Return names for the "vX" aliases.
3071         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3072         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3073         aliases.  Call default_register_reggroup_p for all other
3074         pseudo-registers.
3075         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3076         New functions.
3077         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3078         Handle "vX" aliases.
3079         (v_alias_pseudo_register_collect): New function.
3080         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3081         (rs6000_gdbarch_init): Initialize "vX" aliases as
3082         pseudo-registers.  Restore registration of
3083         rs6000_pseudo_register_reggroup_p with
3084         set_tdesc_pseudo_register_reggroup_p.
3085
3086 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3087
3088         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3089         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3090         set_gdbarch_num_pseudo_regs.
3091
3092 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3093
3094         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3095         Remove arg prefixname, add do_set and do_show.
3096         Add member functions set_list and show_list.
3097         * cli/cli-style.c (class cli_style_option): Update accordingly.
3098         (style_set_list): Move to file scope.
3099         (style_show_list): Likewise.
3100         (set_style): Call help_list.
3101         (show_style): Call cmd_show_list.
3102         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3103         Update to use the new macro.
3104
3105 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3106
3107         * ada-lang.c (_initialize_ada_language): Expand the help text
3108         for the "catch exception" command.
3109
3110 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3111
3112         * symtab.c (matching_obj_sections): Initialize obj,
3113         declare it closer to its usage.
3114
3115 2019-01-10  Tom Tromey  <tom@tromey.com>
3116
3117         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3118         (basic_inf_threads_range): Remove.
3119         (inf_threads_range, inf_non_exited_threads_range)
3120         (safe_inf_threads_range): Use next_adapter.
3121
3122 2019-01-10  Keith Seitz  <keiths@redhat.com>
3123
3124         PR gdb/23712
3125         PR symtab/23010
3126         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3127         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3128
3129 2019-01-10  Keith Seitz  <keiths@redhat.com>
3130
3131         PR gdb/23712
3132         PR symtab/23010
3133         * dictionary.c (pending_to_vector): Remove.
3134         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3135         Remove _1 suffix, replacing functions of the same name.  Update
3136         all callers.
3137         (dict_create_hashed, dict_create_hashed_expandable)
3138         (dict_create_linear, dict_create_linear_expandable, dict_free)
3139         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3140         Make functions static.
3141
3142 2019-01-10  Keith Seitz  <keiths@redhat.com>
3143
3144         PR gdb/23712
3145         PR symtab/23010
3146         * dictionary.h (struct dictionary): Replace declaration with
3147         multidictionary.
3148         (dict_create_hashed, dict_create_hashed_expandable)
3149         (dict_create_linear, dict_create_linear_expandable)
3150         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3151         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3152         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3153         taking multidictionary argument.
3154         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3155         * block.h (struct block) <dict>: Change to multidictionary
3156         and rename `multidict'.
3157         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3158         symmisc.c: Update all dictionary references to multidictionary.
3159
3160 2019-01-10  Keith Seitz  <keiths@redhat.com>
3161
3162         PR gdb/23712
3163         PR symtab/23010
3164         * dictionary.c: Include unordered_map.
3165         (pending_to_vector): New function.
3166         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3167         Rewrite the non-"_1" functions to take vector instead
3168         of linked list.
3169         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3170         "new" _1 versions of the same name.
3171         (multidictionary): Define.
3172         (std::hash<enum language): New definition.
3173         (collate_pending_symbols_by_language, mdict_create_hashed)
3174         (mdict_create_hashed_expandable, mdict_create_linear)
3175         (mdict_create_linear_expandable, mdict_free)
3176         (find_language_dictionary, create_new_language_dictionary)
3177         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3178         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3179         (mdict_size, mdict_empty): New functions.
3180         * dictionary.h (mdict_iterator): Define.
3181
3182 2019-01-10  Pedro Alves  <palves@redhat.com>
3183
3184         * breakpoint.c (read_uploaded_action)
3185         (create_tracepoint_from_upload): Adjust to use
3186         gdb::unique_xmalloc_ptr.
3187         * ctf.c (ctf_write_uploaded_tp):
3188         (SET_ARRAY_FIELD): Use emplace_back.
3189         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3190         * tracefile-tfile.c (tfile_write_uploaded_tp):
3191         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3192         gdb::unique_xmalloc_ptr.
3193         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3194         at_string, cond_string, cmd_strings>: Replace char pointers
3195         with gdb::unique_xmalloc_ptr.
3196
3197 2019-01-10  Pedro Alves  <palves@redhat.com>
3198
3199         * solib-target.c (library_list_start_library): Don't xstrdup name.
3200
3201 2019-01-10  Pedro Alves  <palves@redhat.com>
3202
3203         * mdebugread.c (parse_partial_symbols): Use
3204         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3205
3206 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3207
3208         * linux-fork.c (scoped_switch_fork_info)
3209         <~scoped_switch_fork_info>: Fix incorrect variable name.
3210
3211 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3212
3213         * linux-fork.c (scoped_switch_fork_info)
3214         <scoped_switch_fork_info>: Make explicit.
3215         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3216
3217 2019-01-10  Tom Tromey  <tom@tromey.com>
3218
3219         * objfiles.h (objfile::reset_psymtabs): Update.
3220         * objfiles.c (objfile::objfile): Update.
3221         * psymtab.h (psymtab_storage::obstack): Update.
3222         (psymtab_storage::m_obstack): Use gdb::optional.
3223         (class psymtab_storage): Update comment.  Remove objfile
3224         parameter.
3225         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3226
3227 2019-01-10  Tom Tromey  <tom@tromey.com>
3228
3229         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3230         <free_psymtabs>: Now private.
3231         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3232         (allocate_psymtab): Use new method.
3233
3234 2019-01-10  Tom Tromey  <tom@tromey.com>
3235
3236         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3237         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3238         * mdebugread.c (parse_partial_symbols): Use
3239         allocate_dependencies.
3240         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3241         allocate_dependencies.
3242         (process_psymtab_comp_unit_reader)
3243         (build_type_psymtab_dependencies): Likewise.
3244         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3245
3246 2019-01-10  Tom Tromey  <tom@tromey.com>
3247
3248         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3249         PSYMBOL_SET_LANGUAGE.
3250         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3251
3252 2019-01-10  Tom Tromey  <tom@tromey.com>
3253
3254         * psymtab.h (psymtab_storage::obstack): New method.
3255         <m_obstack>: Rename from obstack; now private.
3256         * psymtab.c (psymtab_storage): Update.
3257         * dwarf2read.c (create_addrmap_from_index)
3258         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3259         Update.
3260
3261 2019-01-10  Tom Tromey  <tom@tromey.com>
3262
3263         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3264         * objfiles.h (objfile::reset_psymtabs): New method.
3265
3266 2019-01-10  Tom Tromey  <tom@tromey.com>
3267
3268         * symmisc.c (print_symbol_bcache_statistics): Update.
3269         (print_objfile_statistics): Update.
3270         * symfile.c (reread_symbols): Update.
3271         * psymtab.h (class psymtab_storage): New.
3272         * psymtab.c (psymtab_storage): New constructor.
3273         (~psymtab_storage): New destructor.
3274         (require_partial_symbols): Update.
3275         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3276         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3277         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3278         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3279         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3280         (start_psymtab_common, end_psymtab_common)
3281         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3282         (allocate_psymtab): Update.
3283         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3284         Update.
3285         (dump_psymtab_addrmap, maintenance_print_psymbols)
3286         (maintenance_check_psymtabs): Update.
3287         (class objfile_psymtabs): Move to objfiles.h.
3288         * psympriv.h (discard_psymtab): Now inline.
3289         (psymtab_discarder::psymtab_discarder): Update.
3290         (psymtab_discarder::~psymtab_discarder): Update.
3291         (ALL_OBJFILE_PSYMTABS): Rewrite.
3292         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3293         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3294         Remove fields.
3295         <partial_symtabs>: New field.
3296         (class objfile_psymtabs): Move from psymtab.h.  Update.
3297         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3298         psymbol_cache.
3299         (objfile::~objfile): Don't destroy psymbol_cache.
3300         * mdebugread.c (parse_partial_symbols): Update.
3301         * dwarf2read.c (create_addrmap_from_index)
3302         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3303         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3304         (add_partial_subprogram, dwarf2_ranges_read): Update.
3305         * dwarf-index-write.c (write_address_map)
3306         (write_one_signatured_type, recursively_write_psymbols)
3307         (class debug_names, class debug_names, write_psymtabs_to_index):
3308         Update.
3309
3310 2019-01-10  Tom Tromey  <tom@tromey.com>
3311
3312         * symtab.h (SYMBOL_SET_NAMES): Update.
3313         (symbol_set_names): Update.
3314         (MSYMBOL_SET_NAMES): Update.
3315         * symtab.c (symbol_set_names): Change argument to be an
3316         objfile_per_bfd_storage.
3317         * psymtab.c (add_psymbol_to_bcache): Update.
3318         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3319
3320 2019-01-10  Tom Tromey  <tom@tromey.com>
3321
3322         * symtab.c (create_demangled_names_hash): Change argument to be an
3323         objfile_per_bfd_storage.
3324         (symbol_set_names): Update.
3325
3326 2019-01-10  Tom Tromey  <tom@tromey.com>
3327
3328         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3329         init_psymbol_list.
3330         * psymtab.c (init_psymbol_list): Do nothing if already called.
3331         * psympriv.h (init_psymbol_list): Add comment.
3332         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3333         init_psymbol_list.
3334         * dbxread.c (dbx_symfile_read): Unconditionally call
3335         init_psymbol_list.
3336
3337 2019-01-10  Tom Tromey  <tom@tromey.com>
3338
3339         * xcoffread.c (scan_xcoff_symtab): Update.
3340         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3341         "where".
3342         * mdebugread.c (parse_partial_symbols)
3343         (handle_psymbol_enumerators): Update.
3344         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3345         * dbxread.c (read_dbx_symtab): Update.
3346         * psympriv.h (psymbol_placement): New enum.
3347         (add_psymbol_to_list): Update.
3348
3349 2019-01-10  Tom Tromey  <tom@tromey.com>
3350
3351         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3352         static_psymbols parameters.
3353         (scan_xcoff_symtab): Update.
3354         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3355         static_psymbols parameters.
3356         * psympriv.h (start_psymtab_common): Update.
3357         * mdebugread.c (parse_partial_symbols): Update.
3358         * dwarf2read.c (create_partial_symtab): Update.
3359         * dbxread.c (read_dbx_symtab): Update.
3360         (start_psymtab): Remove global_psymbols and static_psymbols
3361         parameters.
3362
3363 2019-01-10  Tom Tromey  <tom@tromey.com>
3364
3365         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3366         * psymtab.c (allocate_psymtab): Add comment.
3367         * psympriv.h (allocate_psymtab): Add comment.
3368         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3369         initializations.
3370         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3371
3372 2019-01-10  Tom Tromey  <tom@tromey.com>
3373
3374         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3375         Don't declare.
3376         * mipsread.c: Include mdebugread.h.
3377         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3378         Declare.
3379         * elfread.c: Include mdebugread.h.
3380
3381 2019-01-09  Tom Tromey  <tom@tromey.com>
3382
3383         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3384         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3385         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3386         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3387         (psym_lookup_symbol, psym_find_last_source_symtab)
3388         (psym_forget_cached_source_info, psym_print_stats)
3389         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3390         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3391         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3392         (psym_find_compunit_symtab_by_address)
3393         (maintenance_print_psymbols, maintenance_info_psymtabs)
3394         (maintenance_check_psymtabs): Use ranged for.
3395         * psymtab.h (class objfile_psymtabs): New.
3396         (require_partial_symbols): Return objfile_psymtabs.
3397         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3398
3399 2019-01-09  Tom Tromey  <tom@tromey.com>
3400
3401         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3402         (find_pc_mapped_section, list_overlays_command)
3403         (map_overlay_command, unmap_overlay_command)
3404         (simple_overlay_update): Use all_objfiles.
3405         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3406         * printcmd.c (info_symbol_command): Use all_objfiles.
3407         * objfiles.h (ALL_OBJSECTIONS): Remove.
3408         * maint.c (maintenance_translate_address): Use all_objfiles.
3409         * gcore.c (gcore_create_callback): Use all_objfiles.
3410         (objfile_find_memory_regions): Likewise.
3411
3412 2019-01-09  Tom Tromey  <tom@tromey.com>
3413
3414         * symtab.c (find_line_symtab, info_sources_command)
3415         (make_source_files_completion_list): Use objfile_compunits.
3416         * source.c (select_source_symtab): Use objfile_compunits.
3417         * objfiles.h (struct objfile): Update comment.
3418         (ALL_OBJFILES): Remove.
3419         (ALL_FILETABS): Remove.
3420         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3421         objfile_compunits.
3422
3423 2019-01-09  Tom Tromey  <tom@tromey.com>
3424
3425         * symmisc.c (print_objfile_statistics, dump_objfile)
3426         (maintenance_print_symbols): Use compunit_filetabs.
3427         * source.c (forget_cached_source_info_for_objfile): Use
3428         compunit_filetabs.
3429         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3430         (ALL_FILETABS): Use compunit_filetabs.
3431         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3432         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3433
3434 2019-01-09  Tom Tromey  <tom@tromey.com>
3435
3436         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3437         (compunit_filetabs): New.
3438         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3439         compunit_filetabs.
3440         (info_sources_command, make_source_files_completion_list): Remove
3441         declaration.
3442         * symmisc.c (print_objfile_statistics, dump_objfile)
3443         (maintenance_print_symbols): Remove declaration.
3444         (maintenance_info_symtabs): Use compunit_filetabs.
3445         (maintenance_info_line_tables): Likewise.
3446         * source.c (select_source_symtab): Change local variable name.
3447         (forget_cached_source_info_for_objfile): Remove declaration.
3448         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3449         * objfiles.c (objfile_relocate1): Remove declaration.
3450         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3451         declaration.
3452         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3453         * coffread.c (coff_symtab_read): Remove declaration.
3454         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3455         compunit_filetabs.
3456
3457 2019-01-09  Tom Tromey  <tom@tromey.com>
3458
3459         * symtab.c (lookup_objfile_from_block)
3460         (find_pc_sect_compunit_symtab, search_symbols)
3461         (default_collect_symbol_completion_matches_break_on): Use
3462         objfile_compunits.
3463         * objfiles.h (ALL_COMPUNITS): Remove.
3464         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3465         * cp-support.c (add_symbol_overload_list_qualified): Use
3466         objfile_compunits.
3467         * ada-lang.c (ada_collect_symbol_completion_matches)
3468         (ada_add_global_exceptions): Use objfile_compunits.
3469
3470 2019-01-09  Tom Tromey  <tom@tromey.com>
3471
3472         * source.c (select_source_symtab)
3473         (forget_cached_source_info_for_objfile): Remove declaration.
3474         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3475         declaration.
3476         * maint.c (count_symtabs_and_blocks): Remove declaration.
3477         * cp-support.c (add_symbol_overload_list_qualified): Remove
3478         declaration.
3479         * coffread.c (coff_symtab_read): Remove declaration.
3480         * symtab.c (lookup_symbol_in_objfile_symtabs)
3481         (basic_lookup_transparent_type_1): Use objfile_compunits.
3482         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3483         (info_sources_command, search_symbols)
3484         (default_collect_symbol_completion_matches_break_on)
3485         (make_source_files_completion_list): Remove declaration.
3486         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3487         (ada_collect_symbol_completion_matches)
3488         (ada_add_global_exceptions): Remove declaration.
3489         * linespec.c (iterate_over_all_matching_symtabs): Use
3490         objfile_compunits.
3491         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3492         (class objfile_compunits): New.
3493         (ALL_COMPUNITS): Use objfile_compunits.
3494         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3495         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3496         objfile_compunits.
3497         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3498
3499 2019-01-09  Tom Tromey  <tom@tromey.com>
3500
3501         * symtab.c (search_symbols)
3502         (default_collect_symbol_completion_matches_break_on): Use
3503         objfile_msymbols.
3504         * ada-lang.c (ada_lookup_simple_minsym)
3505         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3506         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3507         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3508         objfile_msymbols.
3509         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3510         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3511         * objc-lang.c (find_methods): Use objfile_msymbols.
3512         (info_selectors_command, info_classes_command): Likewise.
3513         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3514         * objfiles.h (class objfile_msymbols): New.
3515         (ALL_OBJFILE_MSYMBOLS): Remove.
3516         (ALL_MSYMBOLS): Remove.
3517
3518 2019-01-09  Tom Tromey  <tom@tromey.com>
3519
3520         * common/next-iterator.h (next_adapter): Add Iterator template
3521         parameter.
3522         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3523         (class all_objfiles_safe): New.
3524         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3525         * objfiles.c (put_objfile_before): Update comment.
3526         (add_separate_debug_objfile): Likewise.
3527         (free_all_objfiles): Use all_objfiles_safe.
3528         (objfile_purge_solibs): Likewise.
3529
3530 2019-01-09  Tom Tromey  <tom@tromey.com>
3531
3532         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3533         (expand_symtab_containing_pc, lookup_static_symbol)
3534         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3535         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3536         all_objfiles.
3537         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3538         * breakpoint.c (create_overlay_event_breakpoint)
3539         (create_longjmp_master_breakpoint)
3540         (create_std_terminate_master_breakpoint)
3541         (create_exception_master_breakpoint): Use all_objfiles.
3542         * linux-thread-db.c (try_thread_db_load_from_pdir)
3543         (has_libpthread): Use all_objfiles.
3544         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3545         * linespec.c (iterate_over_all_matching_symtabs)
3546         (search_minsyms_for_name): Use all_objfiles.
3547         * maint.c (maintenance_info_sections): Use all_objfiles.
3548         * main.c (captured_main_1): Use all_objfiles.
3549         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3550         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3551         * guile/scm-pretty-print.c
3552         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3553         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3554         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3555         (maintenance_print_msymbols): Use all_objfiles.
3556         * source.c (select_source_symtab): Use all_objfiles.
3557         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3558         * symfile.c (remove_symbol_file_command)
3559         (expand_symtabs_matching, map_symbol_filenames): Use
3560         all_objfiles.
3561         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3562         all_objfiles.
3563         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3564         * objc-lang.c (find_methods): Use all_objfiles.
3565         * objfiles.c (have_partial_symbols, have_full_symbols)
3566         (have_minimal_symbols, qsort_cmp)
3567         (default_iterate_over_objfiles_in_search_order): Use
3568         all_objfiles.
3569         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3570         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3571         (maintenance_check_psymtabs): Use all_objfiles.
3572         (ALL_PSYMTABS): Remove.
3573         * compile/compile-object-run.c (do_module_cleanup): Use
3574         all_objfiles.
3575         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3576         * cp-support.c (add_symbol_overload_list_qualified): Use
3577         all_objfiles.
3578         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3579         Use all_objfiles.
3580         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3581         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3582         all_objfiles.
3583         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3584         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3585         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3586         Uses all_objfiles.
3587         * solib.c (solib_read_symbols): Use all_objfiles
3588
3589 2019-01-09  Tom Tromey  <tom@tromey.com>
3590
3591         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3592         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3593         all_objfiles.
3594         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3595         * symmisc.c (print_symbol_bcache_statistics)
3596         (print_objfile_statistics, maintenance_print_objfiles)
3597         (maintenance_info_symtabs, maintenance_check_symtabs)
3598         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3599         all_objfiles.
3600         * source.c (forget_cached_source_info): Use all_objfiles.
3601         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3602         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3603         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3604         * objfiles.c (update_section_map): Use all_objfiles.
3605         (shared_objfile_contains_address_p): Likewise.
3606         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3607         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3608
3609 2019-01-09  Tom Tromey  <tom@tromey.com>
3610
3611         * common/next-iterator.h: New file.
3612         * objfiles.h (class all_objfiles): New.
3613         (struct objfile_iterator): New.
3614
3615 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3616
3617         * NEWS: Move the description of the changed "frame", "select-frame",
3618          and "info frame" commands to the Changed commands section.
3619
3620 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3621
3622         * gdbtypes.c (check_stub_method_group): Remove handling of old
3623         mangling schemes.
3624         * linespec.c (find_methods): Likewise.
3625         * stabsread.c (read_member_functions): Likewise.
3626         * valops.c (search_struct_method): Likewise.
3627         (value_struct_elt_for_reference): Likewise.
3628         * NEWS: Mention this change.
3629
3630 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3631
3632         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3633         print_source_lines.
3634         * source.c (print_source_lines_base): Update line number check.
3635         (print_source_lines): New function.
3636         (source_lines_range::source_lines_range): New function.
3637         * source.h (class source_lines_range): New class.
3638         (print_source_lines): New declaration.
3639
3640 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3641
3642         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3643
3644 2019-01-08  Tom Tromey  <tom@tromey.com>
3645             Simon Marchi  <simon.marchi@ericsson.com>
3646
3647         PR gdb/24060
3648         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3649         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3650         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3651         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3652         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3653         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3654
3655 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3656
3657         * source.c (select_source_symtab): Move header comment to
3658         declaration in source.h.
3659         (forget_cached_source_info_for_objfile): Likewise.
3660         (forget_cached_source_info): Likewise.
3661         (identify_source_line): Likewise.
3662         * source.h (identify_source_line): Move declaration from symtab.h
3663         and add comment from source.c
3664         (print_source_lines): Likewise.
3665         (forget_cached_source_info_for_objfile): Likewise.
3666         (forget_cached_source_info): Likewise.
3667         (select_source_symtab): Likewise.
3668         (enum print_source_lines_flag): Move definition from symtab.h.
3669         * symtab.h (identify_source_line): Move declaration to source.h.
3670         (print_source_lines): Likewise.
3671         (forget_cached_source_info_for_objfile): Likewise.
3672         (forget_cached_source_info): Likewise.
3673         (select_source_symtab): Likewise.
3674         (enum print_source_lines_flag): Move definition to source.h.
3675         * tui/tui-hooks.c: Add 'source.h' include.
3676
3677 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3678
3679         * source.c (print_source_lines_base): Handle requests to print
3680         reverse line number sequences, and guard against empty lines
3681         string.
3682
3683 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3684
3685         * source.c (print_source_lines_base): Fix skip of '\r' if next
3686         character is '\n'.
3687
3688 2019-01-06  Tom Tromey  <tom@tromey.com>
3689
3690         * c-exp.y (struct c_parse_state) <macro_original_text,
3691         expansion_obstack>: New member.
3692         (macro_original_text, expansion_obstack): Remove globals.
3693         (scan_macro_expansion, scanning_macro_expansion)
3694         (finished_macro_expansion): Update.
3695         (scan_macro_cleanup): Remove.
3696         (yylex, c_parse): Update.
3697
3698 2019-01-06  Tom Tromey  <tom@tromey.com>
3699
3700         * c-exp.y (struct c_parse_state) <strings>: New member.
3701         (operator_stoken): Update.
3702
3703 2019-01-06  Tom Tromey  <tom@tromey.com>
3704
3705         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3706         (union type_stack_elt) <typelist_val>: Now a pointer to
3707         std::vector.
3708         (type_stack_cleanup): Don't declare.
3709         (push_typelist): Update.
3710         * parse.c (pop_typelist): Return a std::vector.
3711         (push_typelist): Take a std::vector.
3712         (follow_types): Update.  Do not free args.
3713         (type_stack_cleanup): Remove.
3714         * c-exp.y (struct c_parse_state): New.
3715         (cpstate): New global.
3716         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3717         (nonempty_typelist): Update.
3718         (func_mod): Create a new vector.
3719         (c_parse): Create a c_parse_state.
3720         (check_parameter_typelist): Do not delete params.
3721         (function_method): Update.  Do not delete type_list.
3722
3723 2019-01-06  Tom Tromey  <tom@tromey.com>
3724
3725         PR gdb/28155:
3726         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3727         check_typedef.
3728         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3729         (print_return_value): Likewise.
3730
3731 2019-01-05  Tom Tromey  <tom@tromey.com>
3732
3733         * contrib/cleanup_check.py: Remove.
3734         * contrib/gcc-with-excheck: Remove.
3735         * contrib/exsummary.py: Remove.
3736         * contrib/excheck.py: Remove.
3737
3738 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3739
3740         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3741         NULL. Initialize tpprev to NULL instead of assigning it
3742         to NULL on the next statement.
3743         * windows-nat.c (windows_delete_thread): Remove check for
3744         main_thread_id before printing thread exit notifications.
3745         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3746         Remove thread ID check against main_thread_id.
3747         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3748         windows_delete_thread.
3749         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3750
3751 2019-01-04  Tom Tromey  <tom@tromey.com>
3752
3753         * compile/compile.c (_initialize_compile): Use upper case for
3754         metasyntactic variables.
3755         * symmisc.c (_initialize_symmisc): Use upper case for
3756         metasyntactic variables.
3757         * psymtab.c (_initialize_psymtab): Use upper case for
3758         metasyntactic variables.
3759         * demangle.c (demangle_command): Use upper case for metasyntactic
3760         variables.
3761         (_initialize_demangler): Likewise.
3762         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3763         variables.
3764
3765 2019-01-03  Tom Tromey  <tom@tromey.com>
3766
3767         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3768
3769 2019-01-03  Tom Tromey  <tom@tromey.com>
3770
3771         * python/py-symtab.c (salpy_str): Update.
3772         (struct salpy_sal_object) <symtab>: Now a PyObject.
3773         (salpy_dealloc): Update.
3774         (del_objfile_sal): Use gdbpy_ref.
3775
3776 2019-01-03  Tom Tromey  <tom@tromey.com>
3777
3778         * python/py-type.c (convert_field): Use new_reference.  Return
3779         gdbpy_ref.
3780         (make_fielditem): Return gdbpy_ref.
3781         (typy_fields): Update.
3782         (typy_getitem): Update.
3783         (field_name): Return gdbpy_ref.  Use new_reference.
3784         (typy_iterator_iternext): Update.
3785
3786 2019-01-03  Tom Tromey  <tom@tromey.com>
3787
3788         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3789
3790 2019-01-03  Tom Tromey  <tom@tromey.com>
3791
3792         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3793         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3794         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3795         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3796         (pspy_set_type_printers): Likewise.
3797         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3798         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3799         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3800         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3801         (objfpy_set_type_printers): Likewise.
3802
3803 2019-01-03  Tom Tromey  <tom@tromey.com>
3804
3805         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3806         (gdbpy_print_stack): Use gdbpy_err_fetch.
3807         * python/python-internal.h (class gdbpy_err_fetch): New class.
3808         (class gdbpy_enter) <m_error_type, m_error_value,
3809         m_error_traceback>: Remove.
3810         <m_error>: New member.
3811         (gdbpy_exception_to_string): Don't declare.
3812         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3813         * python/py-value.c (convert_value_from_python): Use
3814         gdbpy_err_fetch.
3815         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3816         gdbpy_exception_to_string.
3817         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3818         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3819         gdbpy_err_fetch.
3820
3821 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3822
3823         * linux-nat.c (delete_lwp_cleanup): Delete.
3824         (struct lwp_deleter): New struct.
3825         (lwp_info_up): New typedef.
3826         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3827         lwp_info_up.
3828
3829 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3830
3831         * linux-fork.c (class scoped_switch_fork_info): New class.
3832         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3833
3834 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * valops.c (find_overload_match): Remove use of null_cleanup, and
3837         calls to do_cleanups.
3838
3839 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3840
3841         * compile/compile-cplus-types.c
3842         (compile_cplus_instance::decl_name): Handle changes to
3843         cp_func_name.
3844         * cp-support.c (cp_func_name): Update header comment, update
3845         return type.
3846         * cp-support.h (cp_func_name): Update return type in declaration.
3847         * valops.c (find_overload_match): Move temp_func local to top
3848         level of function and change its type.  Use temp_func to hold and
3849         delete temporary string obtained from cp_func_name.
3850
3851 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3852
3853         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3854         gdb::char_vector, remove cleanup, and update uses of `msg`.
3855
3856 2019-01-03  Jim Wilson  <jimw@sifive.com>
3857
3858         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3859
3860 2019-01-02  Tom Tromey  <tom@tromey.com>
3861
3862         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3863         (tdesc_parse_xml): Remove cleanups.
3864         * target-descriptions.h (make_cleanup_free_target_description):
3865         Don't declare.
3866         (target_desc_deleter): New struct.
3867         (target_desc_up): New typedef.
3868         * target-descriptions.c (target_desc_deleter::operator()): Rename
3869         from free_target_description.
3870         (make_cleanup_free_target_description): Remove.
3871
3872 2019-01-02  Tom Tromey  <tom@tromey.com>
3873
3874         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3875         constructor, destructor.
3876         (linespec_parser): Remove typedef.
3877         (~linespec_parser): Rename from linespec_parser_delete.
3878         (linespec_lex_to_end, linespec_complete_label)
3879         (linespec_complete): Update.
3880         (decode_line_full): Remove cleanups.
3881         (decode_line_1): Update.
3882
3883 2019-01-02  Tom Tromey  <tom@tromey.com>
3884
3885         * python/python-internal.h (inferior_to_inferior_object): Change
3886         return type.
3887         * python/py-exitedevent.c (create_exited_event_object): Update.
3888         * python/py-inferior.c (inferior_to_inferior_object): Return
3889         gdbpy_ref.
3890         (python_new_inferior, python_inferior_deleted)
3891         (thread_to_thread_object, delete_thread_object)
3892         (build_inferior_list, gdbpy_selected_inferior): Update.
3893         * python/py-infthread.c (create_thread_object): Update.  Also fail
3894         if inferior_to_inferior_object fails.
3895
3896 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3897
3898         * inferior.h (class inferior) <displaced_step_state>: New field.
3899         * infrun.h (struct displaced_step_state): Move here from
3900         infrun.c.  Initialize fields, add constructor.
3901         <inf>: Remove field.
3902         <reset>: New method.
3903         * infrun.c (struct displaced_step_inferior_state): Move to
3904         infrun.h.
3905         (displaced_step_inferior_states): Remove.
3906         (get_displaced_stepping_state): Adust.
3907         (displaced_step_in_progress_any_inferior): Adjust.
3908         (displaced_step_in_progress_thread): Adjust.
3909         (displaced_step_in_progress): Adjust.
3910         (add_displaced_stepping_state): Remove.
3911         (get_displaced_step_closure_by_addr): Adjust.
3912         (remove_displaced_stepping_state): Remove.
3913         (infrun_inferior_exit): Call displaced_step_state.reset.
3914         (use_displaced_stepping): Don't check for NULL.
3915         (displaced_step_prepare_throw): Call
3916         get_displaced_stepping_state.
3917         (displaced_step_fixup): Don't check for NULL.
3918         (prepare_for_detach): Don't check for NULL.
3919
3920 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3921
3922         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3923          in case of call that did not complete.
3924
3925 2019-01-02  Andrey Utkin  <autkin@undo.io>
3926
3927         * symfile.c (find_separate_debug_file): Fix search of debug files for
3928         remote debuggee.
3929
3930 2019-01-02  Tom Tromey  <tom@tromey.com>
3931
3932         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3933         indentation.
3934         * python/py-frame.c (frapy_older): Remove cast.
3935         (frapy_newer): Likewise.
3936         * python/py-breakpoint.c (local_setattro): Remove cast.
3937         * python/py-arch.c (archpy_name): Remove local variable.
3938         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3939
3940 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3941
3942         * unittests/basic_string_view/element_access/char/empty.cc:
3943         Fix year range in copyright header.
3944
3945 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3946
3947         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3948         Delete.
3949         <operator==>: Update with for removed field.
3950         <hash>: Likewise.
3951         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3952         <isa_features>: ...this.
3953         <abi_features>: New field.
3954         (riscv_isa_flen): Update comment.
3955         (riscv_abi_xlen): New declaration.
3956         (riscv_abi_flen): New declaration.
3957         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3958         isa_features.
3959         (riscv_abi_xlen): New function.
3960         (riscv_isa_flen): Update to get answer from isa_features.
3961         (riscv_abi_flen): New function.
3962         (riscv_has_fp_abi): Update to get answer from abi_features.
3963         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3964         xlen and flen.
3965         (riscv_call_info) <xlen, flen>: Update comment.
3966         (riscv_call_arg_struct): Remove invalid assertions
3967         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3968         is removed.
3969         (riscv_gdbarch_init): Gather isa features and abi features
3970         separately, ensure both match on the gdbarch when reusing an old
3971         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3972         a target with 64-bit float hardware.
3973
3974 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3975
3976         * source.c (search_command_helper): Stop reverse search
3977         when line 1 has been searched.
3978
3979 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3980
3981         * record-full.c (record_full_base_target::close): Rewrite
3982         record_full_core_buf_list free logic.
3983
3984 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3985
3986         * break-catch-syscall.c (print_one_catch_syscall): xfree
3987         the last text.
3988
3989 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3990
3991         * top.c (print_gdb_version): Update Copyright year in version
3992         message.
3993
3994 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3995
3996         Update copyright year range in all GDB files.
3997
3998 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3999
4000         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4001
4002 For older changes see ChangeLog-2018.
4003 \f
4004 Local Variables:
4005 mode: change-log
4006 left-margin: 8
4007 fill-column: 74
4008 version-control: never
4009 coding: utf-8
4010 End:
4011