Don't derive partial_symbol from general_symbol_info
[external/binutils.git] / gdb / ChangeLog
1 2019-05-04  Tom Tromey  <tom@tromey.com>
2
3         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4         (lookup_partial_symbol, print_partial_symbols)
5         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6         (psymbol_compare): Update.
7         (add_psymbol_to_bcache): Clear the entire psymbol.
8         (maintenance_check_psymtabs): Update.
9         * psympriv.h (struct partial_symbol): Don't derive from
10         general_symbol_info.
11         <obj_section, unrelocated_address, address,
12         set_unrelocated_address>: Update.
13         <ginfo>: New member.
14         * dwarf-index-write.c (write_psymbols, debug_names::insert)
15         (debug_names::write_psymbols): Update.
16
17 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
18
19         * windows-nat.c [_WIN32_WINNT]: Define _WIN32_WINNT to Windows XP
20         level, so that various Windows header files expose the necessary
21         declarations and definitions.
22
23         * symfile.c (find_separate_debug_file): Remove colon from the
24         drive spec of DOS/Windows file names of the target, so that the
25         file name produced from DEBUGDIR and the target's directory will
26         be valid on DOS/Windows systems.
27
28 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
29
30         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
31         Use current_event.dwThreadId instead of main_thread_id.
32
33 2019-04-30  Tom Tromey  <tromey@adacore.com>
34
35         PR c++/24470:
36         * dwarf2read.c (process_structure_scope): Handle case where type
37         has template parameters but no symbol was created.
38
39 2019-04-19  Sergei Trofimovich <siarheit@google.com>
40
41         * configure.ac: add --enable-source-highlight switch.
42         * configure: Regenerate.
43         * top.c (print_gdb_version): plumb --enable-source-highlight
44         status to "show configuration".
45
46 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
47
48         PR symtab/24423:
49         * source.c (print_source_lines_base): Advance "iter" when a
50         control character is seen.
51
52 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
53
54         * inferior.h (struct infcall_suspend_state_deleter):
55         Catch exception in destructor to avoid crash.
56
57 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
58
59         * utils.c (prompt_for_continue): Don't restore the styling at the
60         end, as applied_style has the wrong value.  This fixes styling in
61         long lists of file names that are interrupted by the "Continue?"
62         prompt.
63
64 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
65
66         * version.in: Set GDB version number to 8.2.91.DATE-git.
67
68 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
69
70         GDB 8.2.91 released.
71
72 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
73
74         * version.in: Set GDB version number to 8.2.91.
75
76 2019-03-20  Tom Tromey  <tromey@adacore.com>
77
78         PR gdb/24391
79         * infrun.c (handle_inferior_event): Rename from
80         handle_inferior_event_1.  Create a scoped_value_mark.
81         (handle_inferior_event): Remove.
82
83 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
84
85         * source-cache.c (source_cache::get_source_lines): Re-read
86         fullname after calling open_source_file.
87
88 2019-03-18  Pedro Alves  <palves@redhat.com>
89             Eli Zaretskii <eliz@gnu.org>
90
91         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
92         m_line and m_start_of_line.
93
94 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
95
96         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
97         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
98         it returns a newline.  This fixes a regression in TU mode, whereby
99         the next line is output on the same screen line as the user input.
100
101 2019-03-18  Pedro Alves  <palves@redhat.com>
102
103         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
104         New globals.
105         (apply_style): New, factored out from ...
106         (apply_ansi_escape): ... this.  Handle reverse video mode.
107         (tui_set_reverse_mode): New function.
108         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
109         * tui/tui-winsource.c (tui_show_source_line): Use
110         tui_set_reverse_mode instead of setting A_STANDOUT.
111         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
112         New setter methods.
113
114 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
115
116         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
117         Handle tabs.
118
119 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
120
121         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
122         tui_refill_source_window instead of tui_refresh_win, to update the
123         current execution line.  This fixes redisplay of the current line
124         when stepping through the code with "next" or "step".
125
126 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
127
128         * source-cache.c (source_cache::get_source_lines): Call
129         find_source_lines to initialize s->nlines.  This fixes vertical
130         scrolling of TUI source window when the DOWN arrow is pressed.
131
132 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
133
134         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
135         wclrtoeol in tui_show_source_line".  This reverts changes made in
136         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
137
138 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
139
140         * NEWS: Combine separate "New targets" sections for 8.3.
141
142 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
143
144         The MS-Windows port of ncurses fails to switch to a color pair if
145         one or both of the colors are the implicit default colors.  This
146         change records the default colors when TUI is initialized, and
147         then specifies them explicitly when a color pair uses the default
148         colors.  This allows color styling in TUI mode on MS-Windows.
149
150         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
151         ncurses_norm_attr.
152         (tui_initialize_io) [__MINGW32__]: Record the default terminal
153         colors in ncurses_norm_attr.
154         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
155         "none", replace it with the default color recorded in
156         ncurses_norm_attr.
157
158 2019-03-14  Tom Tromey  <tromey@adacore.com>
159
160         * source-cache.h (class source_cache) <get_source_lines>: Return
161         std::string.
162         * source-cache.c (source_cache::extract_lines): Handle case where
163         first_pos==npos.  Return std::string.
164         (source_cache::get_source_lines): Update.
165
166 2019-03-14  Tom Tromey  <tromey@adacore.com>
167
168         * NEWS: Add item for "style sources" commands.
169         * source-cache.c (source_cache::get_source_lines): Check
170         source_styling.
171         * cli/cli-style.c (source_styling): New global.
172         (_initialize_cli_style): Add "style sources" commands.
173         (show_style_sources): New function.
174         * cli/cli-style.h (source_styling): Declare.
175
176 2019-03-14  Pedro Alves  <palves@redhat.com>
177             Tom Tromey  <tromey@adacore.com>
178
179         * tui/tui-winsource.h (tui_refill_source_window): Declare.
180         * tui/tui-winsource.c (tui_refill_source_window): New function,
181         from...
182         (tui_horizontal_source_scroll): ... here.  Move some logic.
183         * cli/cli-style.c (set_style_enabled): Notify new observable.
184         * tui/tui-hooks.c (tui_redisplay_source): New function.
185         (tui_attach_detach_observers): Attach or detach
186         tui_redisplay_source.
187         * observable.h (source_styling_changed): New observable.
188         * observable.c: Define source_styling_changed observable.
189
190 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
191
192         PR/24325
193         * source-cache.c: #undef open and close, to avoid unresolved
194         externals during linking.
195
196 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
197
198         Support styling on native MS-Windows console
199
200         PR/24315
201         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
202         on MS-Windows if $TERM is not defined.
203
204         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
205
206         * posix-hdep.c (gdb_console_fputs):
207         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
208         functions.
209         * ui-file.h (gdb_console_fputs): Add prototype.
210
211         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
212         back to fputs only if the former returns zero.
213
214 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
215             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
216
217         PR gdb/8527
218         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
219         set_sigint_trap, clear_sigint_trap.
220
221 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
222
223         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
224         for-loop range, to avoid compiler warnings.
225
226         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
227         avoid compiler warnings about unused variables.
228
229 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
230
231         * NEWS: Mention end of support for native debugging on MS-Windows
232         before XP.
233
234 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
235
236         PR gdb/24292
237         * common/netstuff.c:
238         * gdbserver/gdbreplay.c
239         * gdbserver/remote-utils.c:
240         * ser-tcp.c:
241         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
242         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
243         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
244         'getaddrinfo' and 'freeaddrinfo' were not available before
245         Windows XP, and mingw.org's MinGW headers by default define
246         _WIN32_WINNT to 0x500.
247
248 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
249     
250         * NEWS: Note minimum Python version.
251
252 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
253
254         * version.in: Set GDB version number to 8.2.90.DATE-git.
255
256 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
257
258         GDB 8.2.90 released.
259
260 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
261
262         * version.in: Set GDB version number to 8.2.90.
263
264 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
265
266         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
267
268 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
269
270         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
271         * version.in: Bump version to 8.2.90.DATE-git.
272
273 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
274
275         * aix-thread.c (ptid_cmp): Remove unused variable.
276         (get_signaled_thread): Likewise.
277         (store_regs_user_thread): Likewise.
278         (store_regs_kernel_thread): Likewise.
279         (fetch_regs_kernel_thread): Remove shadowed variable.
280
281 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
282
283         * features/riscv/32bit-cpu.xml: Add register numbers.
284         * features/riscv/32bit-fpu.c: Regenerate.
285         * features/riscv/32bit-fpu.xml: Add register numbers.
286         * features/riscv/64bit-cpu.xml: Add register numbers.
287         * features/riscv/64bit-fpu.c: Regenerate.
288         * features/riscv/64bit-fpu.xml: Add register numbers.
289
290 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
291
292         * NEWS: Mention two argument form of gdb.Value constructor.
293         * python/py-value.c (convert_buffer_and_type_to_value): New
294         function.
295         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
296         Add support for handling an optional second argument.  Call
297         convert_buffer_and_type_to_value as appropriate.
298         * python/python-internal.h (Py_buffer_deleter): New struct.
299         (Py_buffer_up): New typedef.
300
301 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
302
303         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
304         instead of releasing ownership.
305
306 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
307
308         * dwarf2read.c (open_and_init_dwp_file): Call
309         elf_numsections instead of bfd_count_sections to initialize
310         dwp_file->num_sections.
311
312 2019-02-25  Tom Tromey  <tromey@adacore.com>
313
314         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
315
316 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
317
318         * gcore.in: Add '--readnever' option when invoking GDB.
319
320 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
321
322         * MAINTAINERS: Update my email address.
323
324 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
325
326         * build-id.c (build_id_to_debug_bfd_1): New function.
327         (build_id_to_debug_bfd): Look for separate debug file in
328         sysroot.
329
330 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
331
332         * gdbarch.sh: Update the copyright year range that is placed into
333         generated files.
334
335 2019-02-22  Keith Seitz  <keiths@redhat.com>
336
337         PR symtab/23853
338         * linespec.c (create_sals_line_offset): Search for the default
339         symtab's filename instead of its fullname.
340
341 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
342
343         * NEWS: Update style defaults.
344
345 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
346
347         * main.c (captured_main_1): Disable styling in batch mode.
348
349 2019-02-20  Tom Tromey  <tom@tromey.com>
350
351         * symtab.c (symtab_symbol_info): Fix typos.
352
353 2019-02-20  Tom Tromey  <tromey@adacore.com>
354
355         * findcmd.c (_initialize_mem_search): Use upper case for
356         metasyntactic variables.
357
358 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
359
360         * aarch64-tdep.c (aarch64_add_reggroups): New function.
361         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
362
363 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
364
365         * top.h (source_file_name): Change to std::string.
366         * top.c (source_file_name): Likewise.
367         (command_line_input): Adjust.
368         * cli/cli-script.c (script_from_file): Adjust.
369
370 2019-02-19  Tom Tromey  <tromey@adacore.com>
371
372         * ravenscar-thread.c
373         (ravenscar_thread_target::update_thread_list): Don't call
374         ada_build_task_list.
375         * ada-lang.h (ada_build_task_list): Don't declare.
376         * ada-tasks.c (struct ada_tasks_inferior_data)
377         <task_list_valid_p>: Now bool.
378         (read_known_tasks, ada_task_list_changed)
379         (ada_tasks_invalidate_inferior_data): Update.
380         (read_known_tasks_array): Return bool.
381         (read_known_tasks_list): Likewise.
382         (read_known_tasks): Return void.
383         (ada_build_task_list): Now static.
384
385 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
386
387         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
388         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
389
390 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
391
392         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
393         variant for ada_tasks_pspace_data_handle and
394         ada_tasks_inferior_data_handle.
395         (ada_tasks_pspace_data_cleanup): New function.
396         (ada_tasks_inferior_data_cleanup): New function.
397
398 2019-02-17  Tom Tromey  <tom@tromey.com>
399
400         * macrotab.h (macro_source_fullname): Return a std::string.
401         * macrotab.c (macro_include, check_for_redefinition)
402         (macro_undef, macro_lookup_definition, foreach_macro)
403         (foreach_macro_in_scope): Update.
404         (macro_source_fullname): Return a std::string.
405         * macrocmd.c (show_pp_source_pos): Update.
406
407 2019-02-17  Tom Tromey  <tom@tromey.com>
408
409         * macrocmd.c (show_pp_source_pos): Style the file names.
410
411 2019-02-17  Tom Tromey  <tom@tromey.com>
412
413         PR tui/24197:
414         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
415
416 2019-02-17  Tom Tromey  <tom@tromey.com>
417
418         * ada-lang.c (user_select_syms): Use filtered printing.
419         * utils.c (wrap_style): New global.
420         (desired_style): Remove.
421         (emit_style_escape): Add stream parameter.
422         (set_output_style, reset_terminal_style, prompt_for_continue):
423         Update.
424         (flush_wrap_buffer): Only flush gdb_stdout.
425         (wrap_here): Set wrap_style.
426         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
427         treat escape sequences as a character.  Change when wrap buffer is
428         flushed.
429         (fputs_styled): Do not set the output style when the default is
430         requested.
431         * ui-style.h (struct ui_file_style) <is_default>: New method.
432         * source.c (print_source_lines_base): Emit escape sequences in one
433         piece.
434
435 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
436
437         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
438         integers and enumeration types.
439
440 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
441
442         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
443         instead of lookup_symbol_in_language
444         (do_exact_match): New function.
445         (ada_get_symbol_name_matcher): Return do_exact_match when
446         doing a verbatim match.
447
448 2019-02-15  Tom Tromey  <tromey@adacore.com>
449
450         * ravenscar-thread.c (ravenscar_thread_target::resume)
451         (ravenscar_thread_target::wait): Special case wildcard requests.
452
453 2019-02-15  Tom Tromey  <tromey@adacore.com>
454
455         * ravenscar-thread.c (base_ptid): Remove.
456         (struct ravenscar_thread_target) <close>: New method.
457         <m_base_ptid>: New member.
458         <update_inferior_ptid, active_task, task_is_currently_active,
459         runtime_initialized>: Declare methods.
460         <ravenscar_thread_target>: Add constructor.
461         (ravenscar_thread_target::task_is_currently_active)
462         (ravenscar_thread_target::update_inferior_ptid)
463         (ravenscar_runtime_initialized): Rename.  Now methods.
464         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
465         (ravenscar_thread_target::update_thread_list): Update.
466         (ravenscar_thread_target::active_task): Now method.
467         (ravenscar_thread_target::store_registers)
468         (ravenscar_thread_target::prepare_to_store)
469         (ravenscar_thread_target::prepare_to_store)
470         (ravenscar_thread_target::mourn_inferior): Update.
471         (ravenscar_inferior_created): Use "new" to create target.
472         (ravenscar_thread_target::get_ada_task_ptid): Update.
473         (_initialize_ravenscar): Don't initialize base_ptid.
474         (ravenscar_ops): Remove global.
475
476 2019-02-15  Tom Tromey  <tromey@adacore.com>
477
478         * target.h (push_target): Declare new overload.
479         * target.c (push_target): New overload, taking an rvalue reference.
480         * remote.c (remote_target::open_1): Use push_target overload.
481         * corelow.c (core_target_open): Use push_target overload.
482
483 2019-02-15  Tom Tromey  <tromey@adacore.com>
484
485         * ravenscar-thread.c (is_ravenscar_task)
486         (ravenscar_task_is_currently_active): Return bool.
487         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
488         (_initialize_ravenscar): Remove "(void)".
489         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
490         Return bool.
491
492 2019-02-15  Tom Tromey  <tromey@adacore.com>
493
494         * ravenscar-thread.c (ravenscar_runtime_initializer)
495         (has_ravenscar_runtime, get_running_thread_id)
496         (ravenscar_thread_target::resume): Fix indentation.
497
498 2019-02-15  Tom Tromey  <tromey@adacore.com>
499
500         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
501         from ravenscar_arch_ops.
502         (sparc_ravenscar_ops::fetch_registers)
503         (sparc_ravenscar_ops::store_registers): Now methods.
504         (sparc_ravenscar_prepare_to_store): Remove.
505         (sparc_ravenscar_ops): Redefine.
506         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
507         methods and destructor.  Remove members.
508         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
509         (ravenscar_thread_target::store_registers)
510         (ravenscar_thread_target::prepare_to_store): Update.
511         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
512         Remove.
513         (struct ppc_ravenscar_powerpc_ops): Derive from
514         ravenscar_arch_ops.
515         (ppc_ravenscar_powerpc_ops::fetch_registers)
516         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
517         (ppc_ravenscar_powerpc_ops): Redefine.
518         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
519         (ppc_ravenscar_e500_ops::fetch_registers)
520         (ppc_ravenscar_e500_ops::store_registers): Now methods.
521         (ppc_ravenscar_e500_ops): Redefine.
522         * aarch64-ravenscar-thread.c
523         (aarch64_ravenscar_generic_prepare_to_store): Remove.
524         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
525         (aarch64_ravenscar_fetch_registers)
526         (aarch64_ravenscar_store_registers): Now methods.
527         (aarch64_ravenscar_ops): Redefine.
528
529 2019-02-15  Tom Tromey  <tromey@adacore.com>
530
531         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
532         (ravenscar_thread_target::stopped_by_hw_breakpoint)
533         (ravenscar_thread_target::stopped_by_watchpoint)
534         (ravenscar_thread_target::stopped_data_address)
535         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
536
537 2019-02-15  Tom Tromey  <tromey@adacore.com>
538
539         * ravenscar-thread.c: Fix some typos.
540
541 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
542             Tom Tromey  <tromey@adacore.com>
543
544         * ada-lang.c (ada_exception_sal): Change addr_string to a
545         std::string.
546         (create_ada_exception_catchpoint): Update.
547
548 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
549             Tom Tromey  <tromey@adacore.com>
550
551         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
552         (bp_location_ops): Remove.
553         (base_breakpoint_allocate_location): Update.
554         (free_bp_location): Update.
555         * ada-lang.c (class ada_catchpoint_location)
556         <ada_catchpoint_location>: Remove ops parameter.
557         (ada_catchpoint_location_dtor): Remove.
558         (ada_catchpoint_location_ops): Remove.
559         (allocate_location_exception): Update.
560         * breakpoint.h (struct bp_location_ops): Remove.
561         (class bp_location) <bp_location>: Remove bp_location_ops
562         parameter.
563         <~bp_location>: Add destructor.
564         <ops>: Remove.
565
566 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
567             Pedro Alves  <palves@redhat.com>
568
569         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
570         'PATH_MAX'.
571
572 2019-02-14  David Michael  <fedora.dm0@gmail.com>
573             Samuel Thibault  <samuel.thibault@gnu.org>
574             Thomas Schwinge  <thomas@codesourcery.com>
575
576         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
577         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
578
579 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
580
581         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
582         (check_empty): Use "const char *".
583
584         * gnu-nat.c (gnu_nat_target::detach): Instead of
585         'detach_inferior (pid)' call
586         'detach_inferior (find_inferior_pid (pid))'.
587
588         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
589         'nat/fork-inferior.o'.
590         * gnu-nat.c: #include "nat/fork-inferior.h".
591
592         * gnu-nat.c (gnu_nat_target::detach): Instead of
593         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
594         * gnu-nat.h: #include "inf-child.h".
595         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
596         'i386_gnu_nat_target::fetch_registers'.
597         (gnu_store_registers): Rename/move to
598         'i386_gnu_nat_target::store_registers'.
599
600         * config/i386/nm-i386gnu.h: Don't "#include" any files.
601         * gnu-nat.h (mach_thread_info): New function.
602         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
603
604         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
605
606 2019-02-14  Frederic Konrad  <konrad@adacore.com>
607
608         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
609
610 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
611
612         * windows-nat.c (windows_add_thread): Add new parameter
613         "main_thread_p" with default value set to false.  Update
614         function documentation as well as all callers.
615         (windows_delete_thread): Likewise.
616         (fake_create_process): Update call to windows_add_thread.
617         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
618         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
619         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
620         call to windows_delete_thread.
621
622 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
623
624         * MAINTAINERS: Add Andrew Burgess as global maintainer.
625
626 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
627
628         * symfile.c (find_separate_debug_file): Use canonical path of
629         sysroot with child_path instead of gdb_sysroot if it is valid.
630
631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
632
633         * symfile.c (find_separate_debug_file): Use child_path to
634         determine if an object file is under a sysroot.
635
636 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
637
638         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
639         unittests/child-path-selftests.c.
640         * common/pathstuff.c (child_path): New function.
641         * common/pathstuff.h (child_path): New prototype.
642         * unittests/child-path-selftests.c: New file.
643
644 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
645
646         * symfile.c (find_separate_debug_file): Look for separate debug
647         files in debug directories under the sysroot.
648
649 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
650
651         * symtab.h (struct minimal_symbol data_p): New const method.
652         (struct minimal_symbol text_p): Likewise.
653         * symtab.c (output_source_filename): Use file name style
654         to print file name.
655         (print_symbol_info): Likewise.
656         (print_msymbol_info): Use address style to print addresses.
657         Use function name style to print executable text symbols.
658         (expand_symtab_containing_pc): Use data_p.
659         (find_pc_sect_compunit_symtab): Likewise.
660
661 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
662
663         * breakpoint.c (describe_other_breakpoints): Use address style
664         to print addresses.
665         (say_where): Likewise.
666
667 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
668
669         * ada-typeprint.c (print_func_type): Print function name
670         style to print function name.
671         * c-typeprint.c (c_print_type_1): Likewise.
672
673 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
674
675         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
676         for execve.
677
678 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
679
680         * c-exp.y (direct_abs_decl): Use emplace_back to record the
681         type_stack.
682
683 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
684
685         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
686         TYPE_CODE_REF types.
687
688 2019-02-08  Jim Wilson  <jimw@sifive.com>
689
690         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
691         (riscv_linux_fregset): New.
692         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
693
694 2019-02-07  Tom Tromey  <tom@tromey.com>
695
696         * thread.c (thread_cancel_execution_command): Update.
697         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
698         methods.
699         (struct thread_fsm_ops): Remove.
700         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
701         (thread_fsm_should_stop, thread_fsm_return_value)
702         (thread_fsm_set_finished, thread_fsm_finished_p)
703         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
704         Don't declare.
705         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
706         * infrun.c (clear_proceed_status_thread)
707         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
708         (print_stop_event): Update.
709         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
710         Add constructor.
711         (step_command_fsm_ops): Remove.
712         (new_step_command_fsm): Remove.
713         (step_1): Update.
714         (step_command_fsm::should_stop): Rename from
715         step_command_fsm_should_stop.
716         (step_command_fsm::clean_up): Rename from
717         step_command_fsm_clean_up.
718         (step_command_fsm::do_async_reply_reason): Rename from
719         step_command_fsm_async_reply_reason.
720         (struct until_next_fsm): Inherit from thread_fsm.  Add
721         constructor.
722         (until_next_fsm_ops): Remove.
723         (new_until_next_fsm): Remove.
724         (until_next_fsm::should_stop): Rename from
725         until_next_fsm_should_stop.
726         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
727         (until_next_fsm::do_async_reply_reason): Rename from
728         until_next_fsm_async_reply_reason.
729         (struct finish_command_fsm): Inherit from thread_fsm.  Add
730         constructor.  Change type of breakpoint.
731         (finish_command_fsm_ops): Remove.
732         (new_finish_command_fsm): Remove.
733         (finish_command_fsm::should_stop): Rename from
734         finish_command_fsm_should_stop.
735         (finish_command_fsm::clean_up): Rename from
736         finish_command_fsm_clean_up.
737         (finish_command_fsm::return_value): Rename from
738         finish_command_fsm_return_value.
739         (finish_command_fsm::do_async_reply_reason): Rename from
740         finish_command_fsm_async_reply_reason.
741         (finish_command): Update.
742         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
743         Add constructor.
744         (call_thread_fsm_ops): Remove.
745         (call_thread_fsm::call_thread_fsm): Rename from
746         new_call_thread_fsm.
747         (call_thread_fsm::should_stop): Rename from
748         call_thread_fsm_should_stop.
749         (call_thread_fsm::should_notify_stop): Rename from
750         call_thread_fsm_should_notify_stop.
751         (run_inferior_call, call_function_by_hand_dummy): Update.
752         * cli/cli-interp.c (should_print_stop_to_console): Update.
753         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
754         Add constructor.  Change type of location_breakpoint,
755         caller_breakpoint.
756         (until_break_fsm_ops): Remove.
757         (new_until_break_fsm): Remove.
758         (until_break_fsm::should_stop): Rename from
759         until_break_fsm_should_stop.
760         (until_break_fsm::clean_up): Rename from
761         until_break_fsm_clean_up.
762         (until_break_fsm::do_async_reply_reason): Rename from
763         until_break_fsm_async_reply_reason.
764         (until_break_command): Update.
765         * thread-fsm.c: Remove.
766         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
767
768 2019-02-07  Tom Tromey  <tom@tromey.com>
769
770         * yy-remap.h: Add include guard.
771         * xtensa-tdep.h: Add include guard.
772         * xcoffread.h: Rename include guard.
773         * varobj-iter.h: Add include guard.
774         * tui/tui.h: Rename include guard.
775         * tui/tui-winsource.h: Rename include guard.
776         * tui/tui-wingeneral.h: Rename include guard.
777         * tui/tui-windata.h: Rename include guard.
778         * tui/tui-win.h: Rename include guard.
779         * tui/tui-stack.h: Rename include guard.
780         * tui/tui-source.h: Rename include guard.
781         * tui/tui-regs.h: Rename include guard.
782         * tui/tui-out.h: Rename include guard.
783         * tui/tui-layout.h: Rename include guard.
784         * tui/tui-io.h: Rename include guard.
785         * tui/tui-hooks.h: Rename include guard.
786         * tui/tui-file.h: Rename include guard.
787         * tui/tui-disasm.h: Rename include guard.
788         * tui/tui-data.h: Rename include guard.
789         * tui/tui-command.h: Rename include guard.
790         * tic6x-tdep.h: Add include guard.
791         * target/waitstatus.h: Rename include guard.
792         * target/wait.h: Rename include guard.
793         * target/target.h: Rename include guard.
794         * target/resume.h: Rename include guard.
795         * target-float.h: Rename include guard.
796         * stabsread.h: Add include guard.
797         * rs6000-tdep.h: Add include guard.
798         * riscv-fbsd-tdep.h: Add include guard.
799         * regformats/regdef.h: Rename include guard.
800         * record.h: Rename include guard.
801         * python/python.h: Rename include guard.
802         * python/python-internal.h: Rename include guard.
803         * python/py-stopevent.h: Rename include guard.
804         * python/py-ref.h: Rename include guard.
805         * python/py-record.h: Rename include guard.
806         * python/py-record-full.h: Rename include guard.
807         * python/py-record-btrace.h: Rename include guard.
808         * python/py-instruction.h: Rename include guard.
809         * python/py-events.h: Rename include guard.
810         * python/py-event.h: Rename include guard.
811         * procfs.h: Add include guard.
812         * proc-utils.h: Add include guard.
813         * p-lang.h: Add include guard.
814         * or1k-tdep.h: Rename include guard.
815         * observable.h: Rename include guard.
816         * nto-tdep.h: Rename include guard.
817         * nat/x86-linux.h: Rename include guard.
818         * nat/x86-linux-dregs.h: Rename include guard.
819         * nat/x86-gcc-cpuid.h: Add include guard.
820         * nat/x86-dregs.h: Rename include guard.
821         * nat/x86-cpuid.h: Rename include guard.
822         * nat/ppc-linux.h: Rename include guard.
823         * nat/mips-linux-watch.h: Rename include guard.
824         * nat/linux-waitpid.h: Rename include guard.
825         * nat/linux-ptrace.h: Rename include guard.
826         * nat/linux-procfs.h: Rename include guard.
827         * nat/linux-osdata.h: Rename include guard.
828         * nat/linux-nat.h: Rename include guard.
829         * nat/linux-namespaces.h: Rename include guard.
830         * nat/linux-btrace.h: Rename include guard.
831         * nat/glibc_thread_db.h: Rename include guard.
832         * nat/gdb_thread_db.h: Rename include guard.
833         * nat/gdb_ptrace.h: Rename include guard.
834         * nat/fork-inferior.h: Rename include guard.
835         * nat/amd64-linux-siginfo.h: Rename include guard.
836         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
837         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
838         * nat/aarch64-linux.h: Rename include guard.
839         * nat/aarch64-linux-hw-point.h: Rename include guard.
840         * mn10300-tdep.h: Add include guard.
841         * mips-linux-tdep.h: Add include guard.
842         * mi/mi-parse.h: Rename include guard.
843         * mi/mi-out.h: Rename include guard.
844         * mi/mi-main.h: Rename include guard.
845         * mi/mi-interp.h: Rename include guard.
846         * mi/mi-getopt.h: Rename include guard.
847         * mi/mi-console.h: Rename include guard.
848         * mi/mi-common.h: Rename include guard.
849         * mi/mi-cmds.h: Rename include guard.
850         * mi/mi-cmd-break.h: Rename include guard.
851         * m2-lang.h: Add include guard.
852         * location.h: Rename include guard.
853         * linux-record.h: Rename include guard.
854         * linux-nat.h: Add include guard.
855         * linux-fork.h: Add include guard.
856         * i386-darwin-tdep.h: Rename include guard.
857         * hppa-linux-offsets.h: Add include guard.
858         * guile/guile.h: Rename include guard.
859         * guile/guile-internal.h: Rename include guard.
860         * gnu-nat.h: Rename include guard.
861         * gdb-stabs.h: Rename include guard.
862         * frv-tdep.h: Add include guard.
863         * f-lang.h: Add include guard.
864         * event-loop.h: Add include guard.
865         * darwin-nat.h: Rename include guard.
866         * cp-abi.h: Rename include guard.
867         * config/sparc/nm-sol2.h: Rename include guard.
868         * config/nm-nto.h: Rename include guard.
869         * config/nm-linux.h: Add include guard.
870         * config/i386/nm-i386gnu.h: Rename include guard.
871         * config/djgpp/nl_types.h: Rename include guard.
872         * config/djgpp/langinfo.h: Rename include guard.
873         * compile/gcc-cp-plugin.h: Add include guard.
874         * compile/gcc-c-plugin.h: Add include guard.
875         * compile/compile.h: Rename include guard.
876         * compile/compile-object-run.h: Rename include guard.
877         * compile/compile-object-load.h: Rename include guard.
878         * compile/compile-internal.h: Rename include guard.
879         * compile/compile-cplus.h: Rename include guard.
880         * compile/compile-c.h: Rename include guard.
881         * common/xml-utils.h: Rename include guard.
882         * common/x86-xstate.h: Rename include guard.
883         * common/version.h: Rename include guard.
884         * common/vec.h: Rename include guard.
885         * common/tdesc.h: Rename include guard.
886         * common/selftest.h: Rename include guard.
887         * common/scoped_restore.h: Rename include guard.
888         * common/scoped_mmap.h: Rename include guard.
889         * common/scoped_fd.h: Rename include guard.
890         * common/safe-iterator.h: Rename include guard.
891         * common/run-time-clock.h: Rename include guard.
892         * common/refcounted-object.h: Rename include guard.
893         * common/queue.h: Rename include guard.
894         * common/ptid.h: Rename include guard.
895         * common/print-utils.h: Rename include guard.
896         * common/preprocessor.h: Rename include guard.
897         * common/pathstuff.h: Rename include guard.
898         * common/observable.h: Rename include guard.
899         * common/netstuff.h: Rename include guard.
900         * common/job-control.h: Rename include guard.
901         * common/host-defs.h: Rename include guard.
902         * common/gdb_wait.h: Rename include guard.
903         * common/gdb_vecs.h: Rename include guard.
904         * common/gdb_unlinker.h: Rename include guard.
905         * common/gdb_unique_ptr.h: Rename include guard.
906         * common/gdb_tilde_expand.h: Rename include guard.
907         * common/gdb_sys_time.h: Rename include guard.
908         * common/gdb_string_view.h: Rename include guard.
909         * common/gdb_splay_tree.h: Rename include guard.
910         * common/gdb_setjmp.h: Rename include guard.
911         * common/gdb_ref_ptr.h: Rename include guard.
912         * common/gdb_optional.h: Rename include guard.
913         * common/gdb_locale.h: Rename include guard.
914         * common/gdb_assert.h: Rename include guard.
915         * common/filtered-iterator.h: Rename include guard.
916         * common/filestuff.h: Rename include guard.
917         * common/fileio.h: Rename include guard.
918         * common/environ.h: Rename include guard.
919         * common/common-utils.h: Rename include guard.
920         * common/common-types.h: Rename include guard.
921         * common/common-regcache.h: Rename include guard.
922         * common/common-inferior.h: Rename include guard.
923         * common/common-gdbthread.h: Rename include guard.
924         * common/common-exceptions.h: Rename include guard.
925         * common/common-defs.h: Rename include guard.
926         * common/common-debug.h: Rename include guard.
927         * common/cleanups.h: Rename include guard.
928         * common/buffer.h: Rename include guard.
929         * common/btrace-common.h: Rename include guard.
930         * common/break-common.h: Rename include guard.
931         * cli/cli-utils.h: Rename include guard.
932         * cli/cli-style.h: Rename include guard.
933         * cli/cli-setshow.h: Rename include guard.
934         * cli/cli-script.h: Rename include guard.
935         * cli/cli-interp.h: Rename include guard.
936         * cli/cli-decode.h: Rename include guard.
937         * cli/cli-cmds.h: Rename include guard.
938         * charset-list.h: Add include guard.
939         * buildsym-legacy.h: Rename include guard.
940         * bfin-tdep.h: Add include guard.
941         * ax.h: Rename include guard.
942         * arm-linux-tdep.h: Add include guard.
943         * arm-fbsd-tdep.h: Add include guard.
944         * arch/xtensa.h: Rename include guard.
945         * arch/tic6x.h: Add include guard.
946         * arch/i386.h: Add include guard.
947         * arch/arm.h: Rename include guard.
948         * arch/arm-linux.h: Rename include guard.
949         * arch/arm-get-next-pcs.h: Rename include guard.
950         * arch/amd64.h: Add include guard.
951         * arch/aarch64-insn.h: Rename include guard.
952         * arch-utils.h: Rename include guard.
953         * annotate.h: Add include guard.
954         * amd64-darwin-tdep.h: Rename include guard.
955         * aarch64-linux-tdep.h: Add include guard.
956         * aarch64-fbsd-tdep.h: Add include guard.
957         * aarch32-linux-nat.h: Add include guard.
958
959 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
960
961         * macrotab.c (macro_define_internal): New function that
962         factorizes macro_define_object_internal and macro_define_function
963         code.
964         (macro_define_object_internal): Use macro_define_internal.
965         (macro_define_function): Likewise.
966
967 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
968
969         * macrocmd.c (extract_identifier): Return
970         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
971         callers.
972
973 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
974
975         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
976
977 2019-02-05  Tom Tromey  <tom@tromey.com>
978
979         * target.c (target_stack::unpush): Move assertion earlier.
980
981 2019-01-30  Tom Tromey  <tom@tromey.com>
982
983         PR python/23615:
984         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
985         (gdbpy_parse_and_eval): Likewise.
986         * python/python-internal.h (gdbpy_allow_threads): New class.
987
988 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
989
990         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
991         (aarch64_fbsd_fpregmap): Move earlier.
992         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
993         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
994         instead of individual calls to trad_frame_set_reg_addr.
995         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
996         earlier.
997         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
998         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
999         instead of individual calls to trad_frame_set_reg_addr.
1000
1001 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1002
1003         * CONTRIBUTE: Replace contribution list with wiki link.
1004
1005 2019-01-25  Tom Tromey  <tom@tromey.com>
1006
1007         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1008
1009 2019-01-25  Tom Tromey  <tom@tromey.com>
1010
1011         * xtensa-linux-nat.c: Fix common/ includes.
1012         * xml-support.h: Fix common/ includes.
1013         * xml-support.c: Fix common/ includes.
1014         * x86-linux-nat.c: Fix common/ includes.
1015         * windows-nat.c: Fix common/ includes.
1016         * varobj.h: Fix common/ includes.
1017         * varobj.c: Fix common/ includes.
1018         * value.c: Fix common/ includes.
1019         * valops.c: Fix common/ includes.
1020         * utils.c: Fix common/ includes.
1021         * unittests/xml-utils-selftests.c: Fix common/ includes.
1022         * unittests/utils-selftests.c: Fix common/ includes.
1023         * unittests/unpack-selftests.c: Fix common/ includes.
1024         * unittests/tracepoint-selftests.c: Fix common/ includes.
1025         * unittests/style-selftests.c: Fix common/ includes.
1026         * unittests/string_view-selftests.c: Fix common/ includes.
1027         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1028         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1029         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1030         * unittests/rsp-low-selftests.c: Fix common/ includes.
1031         * unittests/parse-connection-spec-selftests.c: Fix common/
1032         includes.
1033         * unittests/optional-selftests.c: Fix common/ includes.
1034         * unittests/offset-type-selftests.c: Fix common/ includes.
1035         * unittests/observable-selftests.c: Fix common/ includes.
1036         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1037         * unittests/memrange-selftests.c: Fix common/ includes.
1038         * unittests/memory-map-selftests.c: Fix common/ includes.
1039         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1040         * unittests/function-view-selftests.c: Fix common/ includes.
1041         * unittests/environ-selftests.c: Fix common/ includes.
1042         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1043         * unittests/common-utils-selftests.c: Fix common/ includes.
1044         * unittests/cli-utils-selftests.c: Fix common/ includes.
1045         * unittests/array-view-selftests.c: Fix common/ includes.
1046         * ui-file.c: Fix common/ includes.
1047         * tui/tui-io.c: Fix common/ includes.
1048         * tracepoint.h: Fix common/ includes.
1049         * tracepoint.c: Fix common/ includes.
1050         * tracefile-tfile.c: Fix common/ includes.
1051         * top.h: Fix common/ includes.
1052         * top.c: Fix common/ includes.
1053         * thread.c: Fix common/ includes.
1054         * target/waitstatus.h: Fix common/ includes.
1055         * target/waitstatus.c: Fix common/ includes.
1056         * target.h: Fix common/ includes.
1057         * target.c: Fix common/ includes.
1058         * target-memory.c: Fix common/ includes.
1059         * target-descriptions.c: Fix common/ includes.
1060         * symtab.h: Fix common/ includes.
1061         * symfile.c: Fix common/ includes.
1062         * stap-probe.c: Fix common/ includes.
1063         * spu-linux-nat.c: Fix common/ includes.
1064         * sparc-nat.c: Fix common/ includes.
1065         * source.c: Fix common/ includes.
1066         * solib.c: Fix common/ includes.
1067         * solib-target.c: Fix common/ includes.
1068         * ser-unix.c: Fix common/ includes.
1069         * ser-tcp.c: Fix common/ includes.
1070         * ser-pipe.c: Fix common/ includes.
1071         * ser-base.c: Fix common/ includes.
1072         * selftest-arch.c: Fix common/ includes.
1073         * s12z-tdep.c: Fix common/ includes.
1074         * rust-exp.y: Fix common/ includes.
1075         * rs6000-aix-tdep.c: Fix common/ includes.
1076         * riscv-tdep.c: Fix common/ includes.
1077         * remote.c: Fix common/ includes.
1078         * remote-notif.h: Fix common/ includes.
1079         * remote-fileio.h: Fix common/ includes.
1080         * remote-fileio.c: Fix common/ includes.
1081         * regcache.h: Fix common/ includes.
1082         * regcache.c: Fix common/ includes.
1083         * record-btrace.c: Fix common/ includes.
1084         * python/python.c: Fix common/ includes.
1085         * python/py-type.c: Fix common/ includes.
1086         * python/py-inferior.c: Fix common/ includes.
1087         * progspace.h: Fix common/ includes.
1088         * producer.c: Fix common/ includes.
1089         * procfs.c: Fix common/ includes.
1090         * proc-api.c: Fix common/ includes.
1091         * printcmd.c: Fix common/ includes.
1092         * ppc-linux-nat.c: Fix common/ includes.
1093         * parser-defs.h: Fix common/ includes.
1094         * osdata.c: Fix common/ includes.
1095         * obsd-nat.c: Fix common/ includes.
1096         * nat/x86-linux.c: Fix common/ includes.
1097         * nat/x86-linux-dregs.c: Fix common/ includes.
1098         * nat/x86-dregs.h: Fix common/ includes.
1099         * nat/x86-dregs.c: Fix common/ includes.
1100         * nat/ppc-linux.c: Fix common/ includes.
1101         * nat/mips-linux-watch.h: Fix common/ includes.
1102         * nat/mips-linux-watch.c: Fix common/ includes.
1103         * nat/linux-waitpid.c: Fix common/ includes.
1104         * nat/linux-ptrace.h: Fix common/ includes.
1105         * nat/linux-ptrace.c: Fix common/ includes.
1106         * nat/linux-procfs.c: Fix common/ includes.
1107         * nat/linux-personality.c: Fix common/ includes.
1108         * nat/linux-osdata.c: Fix common/ includes.
1109         * nat/linux-namespaces.c: Fix common/ includes.
1110         * nat/linux-btrace.h: Fix common/ includes.
1111         * nat/linux-btrace.c: Fix common/ includes.
1112         * nat/fork-inferior.c: Fix common/ includes.
1113         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1114         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1115         * nat/aarch64-linux.c: Fix common/ includes.
1116         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1117         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1118         * namespace.h: Fix common/ includes.
1119         * mips-linux-tdep.c: Fix common/ includes.
1120         * minsyms.c: Fix common/ includes.
1121         * mi/mi-parse.h: Fix common/ includes.
1122         * mi/mi-main.c: Fix common/ includes.
1123         * mi/mi-cmd-env.c: Fix common/ includes.
1124         * memrange.h: Fix common/ includes.
1125         * memattr.c: Fix common/ includes.
1126         * maint.h: Fix common/ includes.
1127         * maint.c: Fix common/ includes.
1128         * main.c: Fix common/ includes.
1129         * machoread.c: Fix common/ includes.
1130         * location.c: Fix common/ includes.
1131         * linux-thread-db.c: Fix common/ includes.
1132         * linux-nat.c: Fix common/ includes.
1133         * linux-fork.c: Fix common/ includes.
1134         * inline-frame.c: Fix common/ includes.
1135         * infrun.c: Fix common/ includes.
1136         * inflow.c: Fix common/ includes.
1137         * inferior.h: Fix common/ includes.
1138         * inferior.c: Fix common/ includes.
1139         * infcmd.c: Fix common/ includes.
1140         * inf-ptrace.c: Fix common/ includes.
1141         * inf-child.c: Fix common/ includes.
1142         * ia64-linux-nat.c: Fix common/ includes.
1143         * i387-tdep.c: Fix common/ includes.
1144         * i386-tdep.c: Fix common/ includes.
1145         * i386-linux-tdep.c: Fix common/ includes.
1146         * i386-linux-nat.c: Fix common/ includes.
1147         * i386-go32-tdep.c: Fix common/ includes.
1148         * i386-fbsd-tdep.c: Fix common/ includes.
1149         * i386-fbsd-nat.c: Fix common/ includes.
1150         * guile/scm-type.c: Fix common/ includes.
1151         * guile/guile.c: Fix common/ includes.
1152         * go32-nat.c: Fix common/ includes.
1153         * gnu-nat.c: Fix common/ includes.
1154         * gdbthread.h: Fix common/ includes.
1155         * gdbarch-selftests.c: Fix common/ includes.
1156         * gdb_usleep.c: Fix common/ includes.
1157         * gdb_select.h: Fix common/ includes.
1158         * gdb_bfd.c: Fix common/ includes.
1159         * gcore.c: Fix common/ includes.
1160         * fork-child.c: Fix common/ includes.
1161         * findvar.c: Fix common/ includes.
1162         * fbsd-nat.c: Fix common/ includes.
1163         * event-top.c: Fix common/ includes.
1164         * event-loop.c: Fix common/ includes.
1165         * dwarf2read.c: Fix common/ includes.
1166         * dwarf2loc.c: Fix common/ includes.
1167         * dwarf2-frame.c: Fix common/ includes.
1168         * dwarf-index-cache.c: Fix common/ includes.
1169         * dtrace-probe.c: Fix common/ includes.
1170         * disasm-selftests.c: Fix common/ includes.
1171         * defs.h: Fix common/ includes.
1172         * csky-tdep.c: Fix common/ includes.
1173         * cp-valprint.c: Fix common/ includes.
1174         * cp-support.h: Fix common/ includes.
1175         * cp-support.c: Fix common/ includes.
1176         * corelow.c: Fix common/ includes.
1177         * completer.h: Fix common/ includes.
1178         * completer.c: Fix common/ includes.
1179         * compile/compile.c: Fix common/ includes.
1180         * compile/compile-loc2c.c: Fix common/ includes.
1181         * compile/compile-cplus-types.c: Fix common/ includes.
1182         * compile/compile-cplus-symbols.c: Fix common/ includes.
1183         * command.h: Fix common/ includes.
1184         * cli/cli-dump.c: Fix common/ includes.
1185         * cli/cli-cmds.c: Fix common/ includes.
1186         * charset.c: Fix common/ includes.
1187         * build-id.c: Fix common/ includes.
1188         * btrace.h: Fix common/ includes.
1189         * btrace.c: Fix common/ includes.
1190         * breakpoint.h: Fix common/ includes.
1191         * breakpoint.c: Fix common/ includes.
1192         * ax.h: 
1193         (enum agent_op): Fix common/ includes.
1194         * ax-general.c (struct aop_map): Fix common/ includes.
1195         * ax-gdb.c: Fix common/ includes.
1196         * auxv.c: Fix common/ includes.
1197         * auto-load.c: Fix common/ includes.
1198         * arm-tdep.c: Fix common/ includes.
1199         * arch/riscv.c: Fix common/ includes.
1200         * arch/ppc-linux-common.c: Fix common/ includes.
1201         * arch/i386.c: Fix common/ includes.
1202         * arch/arm.c: Fix common/ includes.
1203         * arch/arm-linux.c: Fix common/ includes.
1204         * arch/arm-get-next-pcs.c: Fix common/ includes.
1205         * arch/amd64.c: Fix common/ includes.
1206         * arch/aarch64.c: Fix common/ includes.
1207         * arch/aarch64-insn.c: Fix common/ includes.
1208         * arch-utils.c: Fix common/ includes.
1209         * amd64-windows-tdep.c: Fix common/ includes.
1210         * amd64-tdep.c: Fix common/ includes.
1211         * amd64-sol2-tdep.c: Fix common/ includes.
1212         * amd64-obsd-tdep.c: Fix common/ includes.
1213         * amd64-nbsd-tdep.c: Fix common/ includes.
1214         * amd64-linux-tdep.c: Fix common/ includes.
1215         * amd64-linux-nat.c: Fix common/ includes.
1216         * amd64-fbsd-tdep.c: Fix common/ includes.
1217         * amd64-fbsd-nat.c: Fix common/ includes.
1218         * amd64-dicos-tdep.c: Fix common/ includes.
1219         * amd64-darwin-tdep.c: Fix common/ includes.
1220         * agent.c: Fix common/ includes.
1221         * ada-lang.h: Fix common/ includes.
1222         * ada-lang.c: Fix common/ includes.
1223         * aarch64-tdep.c: Fix common/ includes.
1224
1225 2019-01-25  Tom Tromey  <tom@tromey.com>
1226
1227         * common/create-version.sh: Use common/version.h.
1228
1229 2019-01-24  Pedro Alves  <palves@redhat.com>
1230
1231         * infrun.c (signal_stop, signal_print, signal_program)
1232         (signal_catch, signal_pass): Now arrays instead of pointers.
1233         (update_signals_program_target, do_target_resume)
1234         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1235         * linux-nat.c (linux_nat_target::pass_signals)
1236         (linux_nat_target::create_inferior, linux_nat_target::attach):
1237         Adjust.
1238         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1239         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1240         * procfs.c (procfs_target::pass_signals): Adjust.
1241         * record-full.c (record_full_target::resume): Adjust.
1242         * remote.c (remote_target::pass_signals)
1243         (remote_target::program_signals): Adjust.
1244         * target-debug.h (target_debug_print_signals): Now takes a
1245         gdb::array_view as parameter.  Adjust.
1246         * target.h (target_ops) <pass_signals, program_signals>: Replace
1247         pointer and length parameters with gdb::array_view.
1248         (target_pass_signals, target_program_signals): Likewise.
1249         * target-delegates.c: Regenerate.
1250
1251 2019-01-24  Pedro Alves  <palves@redhat.com>
1252
1253         * common/forward-scope-exit.h
1254         (forward_scope_exit::forward_scope_exit): Pass arguments to
1255         m_bind_function directly, instead of creating a std::bind and
1256         copying that.
1257
1258 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1259
1260         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1261         for static members.
1262         (pass_in_v_vfp_candidate): Likewise.
1263
1264 2019-01-23  Tom Tromey  <tom@tromey.com>
1265             Pedro Alves  <palves@redhat.com>
1266
1267         * regcache.c (class regcache_invalidator): Remove.
1268         (regcache::raw_write): Use make_scope_exit.
1269
1270 2019-01-23  Tom Tromey  <tom@tromey.com>
1271
1272         * ui-out.h (class ui_out_emit_type): Update comment.
1273
1274 2019-01-23  Tom Tromey  <tom@tromey.com>
1275
1276         * infrun.c (fetch_inferior_event): Update comment.
1277
1278 2019-01-23  Tom Tromey  <tom@tromey.com>
1279             Pedro Alves  <palves@redhat.com>
1280
1281         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1282         parameter.
1283         (fetch_inferior_event): Use SCOPE_EXIT.
1284
1285
1286 2019-01-23  Tom Tromey  <tom@tromey.com>
1287             Pedro Alves  <palves@redhat.com>
1288
1289         * infrun.c (disable_thread_events): Delete.
1290         (stop_all_threads): Use SCOPE_EXIT.
1291
1292 2019-01-23  Tom Tromey  <tom@tromey.com>
1293             Pedro Alves  <palves@redhat.com>
1294
1295         * symfile.c: Include forward-scope-exit.h.
1296         (clear_symtab_users_cleanup): Replace forward declaration with
1297         a FORWARD_SCOPE_EXIT.
1298         (syms_from_objfile_1): Use the forward_scope_exit and
1299         gdb::optional instead of cleanup_function.
1300         (reread_symbols): Use the forward_scope_exit instead of
1301         cleanup_function.
1302         (clear_symtab_users_cleanup): Remove function.
1303
1304 2019-01-23  Tom Tromey  <tom@tromey.com>
1305             Pedro Alves  <palves@redhat.com>
1306
1307         * linux-nat.c: Include scope-exit.h.
1308         (cleanup_target_stop): Remove.
1309         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1310         SCOPE_EXIT.
1311
1312 2019-01-23  Tom Tromey  <tom@tromey.com>
1313             Pedro Alves  <palves@redhat.com>
1314
1315         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1316         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1317
1318 2019-01-23  Tom Tromey  <tom@tromey.com>
1319             Andrew Burgess  <andrew.burgess@embecosm.com>
1320             Pedro Alves  <palves@redhat.com>
1321
1322         * infrun.c (fetch_inferior_event): Use scope_exit.
1323         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1324         * top.c (execute_command): Use scope_exit.
1325         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1326         * utils.c (do_bpstat_clear_actions_cleanup)
1327         (make_bpstat_clear_actions_cleanup): Remove.
1328
1329 2019-01-23  Tom Tromey  <tom@tromey.com>
1330             Pedro Alves  <palves@redhat.com>
1331
1332         * infrun.c: Include "common/scope-exit.h"
1333         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1334         (wait_for_inferior): Use SCOPE_EXIT.
1335         (fetch_inferior_event): Use scope_exit.
1336
1337 2019-01-23  Tom Tromey  <tom@tromey.com>
1338             Pedro Alves  <palves@redhat.com>
1339
1340         * breakpoint.c (create_breakpoint): Remove cleanup.
1341
1342 2019-01-23  Tom Tromey  <tom@tromey.com>
1343             Andrew Burgess  <andrew.burgess@embecosm.com>
1344             Pedro Alves  <palves@redhat.com>
1345
1346 2019-01-23  Pedro Alves  <palves@redhat.com>
1347
1348         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1349
1350 2019-01-23  Pedro Alves  <palves@redhat.com>
1351             Andrew Burgess  <andrew.burgess@embecosm.com>
1352
1353         * gdbthread.h: Include "common/forward-scope-exit.h".
1354         (scoped_finish_thread_state): Redefine custom class in terms of
1355         forward_scope_exit.
1356
1357 2019-01-23  Pedro Alves  <palves@redhat.com>
1358             Andrew Burgess  <andrew.burgess@embecosm.com>
1359
1360         * common/forward-scope-exit.h: New file.
1361
1362 2019-01-23  Pedro Alves  <palves@redhat.com>
1363             Andrew Burgess  <andrew.burgess@embecosm.com>
1364             Tom Tromey  <tom@tromey.com>
1365
1366         * common/scope-exit.h: New file.
1367
1368 2019-01-23  Pedro Alves  <palves@redhat.com>
1369
1370         * common/preprocessor.h (ESC): Rename to ...
1371         (ESC_PARENS): ... this.
1372         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1373         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1374
1375 2019-01-23  Tom Tromey  <tom@tromey.com>
1376
1377         * language.h (class scoped_switch_to_sym_language_if_auto):
1378         Initialize m_lang in both cases.
1379
1380 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1381
1382         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1383         with XCNEW.
1384
1385 2019-01-22  Tom Tromey  <tom@tromey.com>
1386
1387         * corelow.c: Do not include sys/file.h.
1388
1389 2019-01-22  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-wingeneral.h: Include gdb_curses.h.
1392
1393 2019-01-22  Tom Tromey  <tom@tromey.com>
1394
1395         * source-cache.h (class source_cache) <get_source_lines,
1396         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1397
1398 2019-01-22  Tom Tromey  <tom@tromey.com>
1399
1400         * remote-fileio.h (struct remote_target): Declare.
1401
1402 2019-01-22  Tom Tromey  <tom@tromey.com>
1403
1404         * python/py-arch.c: Do not include py-ref.h.
1405         * python/py-bpevent.c: Do not include py-ref.h.
1406         * python/py-cmd.c: Do not include py-ref.h.
1407         * python/py-continueevent.c: Do not include py-ref.h.
1408         * python/py-event.h: Do not include py-ref.h.
1409         * python/py-evtregistry.c: Do not include py-ref.h.
1410         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1411         * python/py-frame.c: Do not include py-ref.h.
1412         * python/py-framefilter.c: Do not include py-ref.h.
1413         * python/py-function.c: Do not include py-ref.h.
1414         * python/py-infevents.c: Do not include py-ref.h.
1415         * python/py-linetable.c: Do not include py-ref.h.
1416         * python/py-objfile.c: Do not include py-ref.h.
1417         * python/py-param.c: Do not include py-ref.h.
1418         * python/py-prettyprint.c: Do not include py-ref.h.
1419         * python/py-progspace.c: Do not include py-ref.h.
1420         * python/py-symbol.c: Do not include py-ref.h.
1421         * python/py-symtab.c: Do not include py-ref.h.
1422         * python/py-type.c: Do not include py-ref.h.
1423         * python/py-unwind.c: Do not include py-ref.h.
1424         * python/py-utils.c: Do not include py-ref.h.
1425         * python/py-value.c: Do not include py-ref.h.
1426         * python/py-varobj.c: Do not include py-ref.h.
1427         * python/py-xmethods.c: Do not include py-ref.h.
1428         * python/python.c: Do not include py-ref.h.
1429         * varobj.c: Do not include py-ref.h.
1430
1431 2019-01-22  Tom Tromey  <tom@tromey.com>
1432
1433         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1434         keyword for bcache.
1435
1436 2019-01-22  Tom Tromey  <tom@tromey.com>
1437
1438         * compile/compile-cplus-types.c: Remove a comment by #include.
1439
1440 2019-01-22  Tom Tromey  <tom@tromey.com>
1441
1442         * compile/gcc-c-plugin.h: Include compile-internal.h.
1443
1444 2019-01-22  Tom Tromey  <tom@tromey.com>
1445
1446         * stabsread.c (EXTERN): Do not define.
1447         (symnum, next_symbol_text_func, processing_gcc_compilation)
1448         (within_function, global_sym_chain, global_stabs)
1449         (previous_stab_code, this_object_header_files)
1450         (n_this_object_header_files)
1451         (n_allocated_this_object_header_files): Define.
1452         * stabsread.h (EXTERN): Never define.  Use "extern".
1453
1454 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1455
1456         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1457         history_value.
1458
1459 2019-01-21  Tom Tromey  <tom@tromey.com>
1460
1461         * ui-out.c: Fix includes.
1462         * tui/tui-source.c: Fix includes.
1463         * target.c: Fix includes.
1464         * remote.c: Fix includes.
1465         * regcache.c: Fix includes.
1466         * python/py-block.c: Fix includes.
1467         * printcmd.c: Fix includes.
1468         * or1k-tdep.c: Fix includes.
1469         * mi/mi-main.c: Fix includes.
1470         * m32r-tdep.c: Fix includes.
1471         * csky-tdep.c: Fix includes.
1472         * compile/compile-cplus-types.c: Fix includes.
1473         * cli/cli-interp.c: Fix includes.
1474
1475 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1476
1477         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1478         for padding.
1479
1480 2019-01-16  Tom Tromey  <tom@tromey.com>
1481
1482         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1483         earlier.
1484         (struct objfile) <msymbols_range>: Move from top level.
1485         <msymbols>: New method.
1486         (class objfile_msymbols): Remove.
1487         * symtab.c (default_collect_symbol_completion_matches_break_on):
1488         Update.
1489         * symmisc.c (dump_msymbols): Update.
1490         * stabsread.c (scan_file_globals): Update.
1491         * objc-lang.c (info_selectors_command, info_classes_command)
1492         (find_methods): Update.
1493         * minsyms.c (find_solib_trampoline_target): Update.
1494         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1495         * coffread.c (coff_symfile_read): Update.
1496         * ada-lang.c (ada_lookup_simple_minsym)
1497         (ada_collect_symbol_completion_matches): Update.
1498
1499 2019-01-16  Tom Tromey  <tom@tromey.com>
1500
1501         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1502         type.  Remove no-argument constructor.
1503         <iterator::operator++>: Simplify.
1504         <begin>: Update.
1505         <end>: Use minimal_symbol_count.
1506
1507 2019-01-16  Tom Tromey  <tom@tromey.com>
1508
1509         * objfiles.h (struct objfile) <psymtabs>: New method.
1510         (class objfile_psymtabs): Remove.
1511         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1512         typedef.
1513         <range>: New method.
1514         (require_partial_symbols): Change return type.
1515         * psymtab.c (require_partial_symbols)
1516         (psym_expand_symtabs_matching): Update.
1517         * mdebugread.c (parse_partial_symbols): Update.
1518         * dbxread.c (dbx_end_psymtab): Update.
1519
1520 2019-01-15  Tom Tromey  <tom@tromey.com>
1521
1522         * symtab.c (lookup_objfile_from_block)
1523         (lookup_symbol_in_objfile_symtabs)
1524         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1525         (find_line_symtab, info_sources_command)
1526         (default_collect_symbol_completion_matches_break_on)
1527         (make_source_files_completion_list): Update.
1528         * symmisc.c (print_objfile_statistics, dump_objfile)
1529         (maintenance_print_symbols, maintenance_info_symtabs)
1530         (maintenance_check_symtabs, maintenance_info_line_tables):
1531         Update.
1532         * source.c (select_source_symtab)
1533         (forget_cached_source_info_for_objfile): Update.
1534         * objfiles.h (class objfile_compunits): Remove.
1535         (struct objfile) <compunits_range>: New typedef.
1536         (compunits): New method.
1537         * objfiles.c (objfile_relocate1): Update.
1538         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1539         * maint.c (count_symtabs_and_blocks): Update.
1540         * linespec.c (iterate_over_all_matching_symtabs): Update.
1541         * cp-support.c (add_symbol_overload_list_qualified): Update.
1542         * coffread.c (coff_symtab_read): Update.
1543         * ada-lang.c (add_nonlocal_symbols)
1544         (ada_collect_symbol_completion_matches)
1545         (ada_add_global_exceptions): Update.
1546
1547 2019-01-15  Tom Tromey  <tom@tromey.com>
1548
1549         * progspace.h (program_space) <objfiles_safe_range>: New
1550         typedef.
1551         <objfiles_safe>: New method.
1552         * objfiles.h (class all_objfiles_safe): Remove.
1553         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1554         * jit.c (jit_inferior_exit_hook): Update.
1555
1556 2019-01-17  Tom Tromey  <tom@tromey.com>
1557
1558         * progspace.h (program_space) <objfiles_range>: New typedef.
1559         <objfiles>: New method.
1560         <objfiles_head>: Rename from objfiles.
1561         (object_files): Update.
1562         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1563         * guile/scm-pretty-print.c
1564         (ppscm_find_pretty_printer_from_objfiles): Update.
1565         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1566         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1567         Update.
1568         * python/py-progspace.c (pspy_get_objfiles): Update.
1569         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1570         Update.
1571         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1572         (objfpy_lookup_objfile_by_build_id): Update.
1573         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1574         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1575         Update.
1576         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1577         (expand_symtab_containing_pc, lookup_objfile_from_block)
1578         (lookup_static_symbol, basic_lookup_transparent_type)
1579         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1580         (find_line_symtab, info_sources_command)
1581         (default_collect_symbol_completion_matches_break_on)
1582         (make_source_files_completion_list, find_main_name): Update.
1583         * symmisc.c (print_symbol_bcache_statistics)
1584         (print_objfile_statistics, maintenance_print_symbols)
1585         (maintenance_print_msymbols, maintenance_print_objfiles)
1586         (maintenance_info_symtabs, maintenance_check_symtabs)
1587         (maintenance_expand_symtabs, maintenance_info_line_tables):
1588         Update.
1589         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1590         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1591         (map_overlay_command, unmap_overlay_command)
1592         (simple_overlay_update, expand_symtabs_matching)
1593         (map_symbol_filenames): Update.
1594         * symfile-debug.c (set_debug_symfile): Update.
1595         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1596         Update.
1597         * source.c (select_source_symtab, forget_cached_source_info):
1598         Update.
1599         * solib.c (solib_read_symbols): Update.
1600         * solib-spu.c (append_ocl_sos): Update.
1601         * psymtab.c (maintenance_print_psymbols)
1602         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1603         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1604         * printcmd.c (info_symbol_command): Update.
1605         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1606         Update.
1607         * objfiles.h (class all_objfiles): Remove.
1608         * objfiles.c (have_partial_symbols, have_full_symbols)
1609         (have_minimal_symbols, qsort_cmp, update_section_map)
1610         (shared_objfile_contains_address_p)
1611         (default_iterate_over_objfiles_in_search_order): Update.
1612         * objc-lang.c (info_selectors_command, info_classes_command)
1613         (find_methods): Update.
1614         * minsyms.c (find_solib_trampoline_target): Update.
1615         * maint.c (maintenance_info_sections)
1616         (maintenance_translate_address, count_symtabs_and_blocks):
1617         Update.
1618         * main.c (captured_main_1): Update.
1619         * linux-thread-db.c (try_thread_db_load_from_pdir)
1620         (has_libpthread): Update.
1621         * linespec.c (iterate_over_all_matching_symtabs)
1622         (search_minsyms_for_name): Update.
1623         * jit.c (jit_find_objf_with_entry_addr): Update.
1624         * hppa-tdep.c (find_unwind_entry)
1625         (hppa_lookup_stub_minimal_symbol): Update.
1626         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1627         Update.
1628         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1629         (elf_gnu_ifunc_resolve_by_got): Update.
1630         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1631         * dwarf-index-write.c (save_gdb_index_command): Update.
1632         * cp-support.c (add_symbol_overload_list_qualified): Update.
1633         * breakpoint.c (create_overlay_event_breakpoint)
1634         (create_longjmp_master_breakpoint)
1635         (create_std_terminate_master_breakpoint)
1636         (create_exception_master_breakpoint): Update.
1637         * blockframe.c (find_pc_partial_function): Update.
1638         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1639         (ada_collect_symbol_completion_matches)
1640         (ada_add_global_exceptions): Update.
1641
1642 2019-01-17  Tom Tromey  <tom@tromey.com>
1643
1644         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1645         declare VEC.
1646         (solib_target_parse_libraries): Change return type.
1647         (library_list_start_segment, library_list_start_section)
1648         (library_list_end_library, library_list_start_library); Update.
1649         (solib_target_free_library_list): Remove.
1650         (solib_target_parse_libraries): Remove cleanup.  Change return
1651         type.
1652         (solib_target_current_sos): Update.
1653
1654 2019-01-17  Tom Tromey  <tromey@bapiya>
1655
1656         * valprint.c: Replace "the the" with "the".
1657         * symtab.c: Replace "the the" with "the".
1658         * solib.c: Replace "the the" with "the".
1659         * solib-dsbt.c: Replace "the the" with "the".
1660         * linespec.c: Replace "the the" with "the".
1661         * dwarf2loc.h: Replace "the the" with "the".
1662         * amd64-windows-tdep.c: Replace "the the" with "the".
1663         * aarch64-tdep.c: Replace "the the" with "the".
1664
1665 2019-01-16  Keith Seitz  <keiths@redhat.com>
1666
1667         PR gdb/23773
1668         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1669         <builder>: Rename to ..
1670         <m_builder>: ... this and make private.
1671         (dwarf2_cu::get_builder): New method.  Change all users of
1672         `builder' to use this method.
1673         (dwarf2_start_symtab): Move to ...
1674         (dwarf2_cu::start_symtab): ... here.  Update all callers
1675         (setup_type_unit_groups): Move to ...
1676         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1677         callers.
1678         (dwarf2_cu::reset_builder): New method.
1679         (process_full_compunit, process_full_type_unit): Use
1680         dwarf2_cu::reset_builder.
1681         (follow_die_offset): Record the ancestor CU if it is different
1682         from the followed DIE's CU.
1683         (follow_die_sig_1): Likewise.
1684
1685 2019-01-15  Tom Tromey  <tom@tromey.com>
1686
1687         * remote.c (class remote_state) <buf>: Now a char_vector.
1688         <buf_size>: Remove.
1689         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1690         parameter.
1691         (remote_target::getpkt_or_notif_sane_1)
1692         (remote_target::getpkt_sane)
1693         (remote_target::getpkt_or_notif_sane): Likewise.
1694         (class remote_target) <putpkt>: New overload.
1695         (remote_target::read_frame): Change type of "buf_p".  Remove
1696         sizeof_p parameter.
1697         (packet_ok): New overload.
1698         (packet_check_result): New overload.
1699         Update all uses.
1700
1701 2019-01-14  Tom Tromey  <tom@tromey.com>
1702
1703         * remote-notif.c (handle_notification, remote_notif_ack)
1704         (remote_notif_parse): Make "buf" const.
1705         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1706         const.
1707         (remote_notif_parse, remote_notif_ack, handle_notification):
1708         Likewise.
1709         * remote.c (remote_notif_stop_parse): Make "buf" const.
1710         (remote_target::remote_parse_stop_reply): Make "buf" const.
1711         (remote_notif_stop_ack): Make "buf" const.
1712
1713 2019-01-14  Tom Tromey  <tom@tromey.com>
1714
1715         * remote.c (remote_console_output): Make parameter const.
1716
1717 2019-01-14  Tom Tromey  <tom@tromey.com>
1718
1719         * target-debug.h (target_debug_print_signals): Constify.
1720         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1721         * procfs.c (procfs_target::pass_signals): Update.
1722         * linux-nat.c (linux_nat_target::pass_signals): Update.
1723         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1724         * target-delegates.c: Rebuild.
1725         * remote.c (remote_target::program_signals): Update.
1726         (remote_target::pass_signals): Update.
1727         * target.c (target_pass_signals): Constify argument.
1728         (target_program_signals): Likewise.
1729         * target.h (struct target_ops) <pass_signals, program_signals>:
1730         Constify argument.
1731         (target_pass_signals, target_program_signals): Constify argument.
1732
1733 2019-01-14  Tom Tromey  <tom@tromey.com>
1734
1735         PR tui/28819:
1736         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1737
1738 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1739
1740         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1741         field.
1742         * rs6000-tdep.c: Include reggroups.h.
1743         (IS_V_ALIAS_PSEUDOREG): Define.
1744         (rs6000_register_name): Return names for the "vX" aliases.
1745         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1746         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1747         aliases.  Call default_register_reggroup_p for all other
1748         pseudo-registers.
1749         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1750         New functions.
1751         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1752         Handle "vX" aliases.
1753         (v_alias_pseudo_register_collect): New function.
1754         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1755         (rs6000_gdbarch_init): Initialize "vX" aliases as
1756         pseudo-registers.  Restore registration of
1757         rs6000_pseudo_register_reggroup_p with
1758         set_tdesc_pseudo_register_reggroup_p.
1759
1760 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1761
1762         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1763         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1764         set_gdbarch_num_pseudo_regs.
1765
1766 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1767
1768         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1769         Remove arg prefixname, add do_set and do_show.
1770         Add member functions set_list and show_list.
1771         * cli/cli-style.c (class cli_style_option): Update accordingly.
1772         (style_set_list): Move to file scope.
1773         (style_show_list): Likewise.
1774         (set_style): Call help_list.
1775         (show_style): Call cmd_show_list.
1776         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1777         Update to use the new macro.
1778
1779 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1780
1781         * ada-lang.c (_initialize_ada_language): Expand the help text
1782         for the "catch exception" command.
1783
1784 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1785
1786         * symtab.c (matching_obj_sections): Initialize obj,
1787         declare it closer to its usage.
1788
1789 2019-01-10  Tom Tromey  <tom@tromey.com>
1790
1791         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1792         (basic_inf_threads_range): Remove.
1793         (inf_threads_range, inf_non_exited_threads_range)
1794         (safe_inf_threads_range): Use next_adapter.
1795
1796 2019-01-10  Keith Seitz  <keiths@redhat.com>
1797
1798         PR gdb/23712
1799         PR symtab/23010
1800         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1801         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1802
1803 2019-01-10  Keith Seitz  <keiths@redhat.com>
1804
1805         PR gdb/23712
1806         PR symtab/23010
1807         * dictionary.c (pending_to_vector): Remove.
1808         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1809         Remove _1 suffix, replacing functions of the same name.  Update
1810         all callers.
1811         (dict_create_hashed, dict_create_hashed_expandable)
1812         (dict_create_linear, dict_create_linear_expandable, dict_free)
1813         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1814         Make functions static.
1815
1816 2019-01-10  Keith Seitz  <keiths@redhat.com>
1817
1818         PR gdb/23712
1819         PR symtab/23010
1820         * dictionary.h (struct dictionary): Replace declaration with
1821         multidictionary.
1822         (dict_create_hashed, dict_create_hashed_expandable)
1823         (dict_create_linear, dict_create_linear_expandable)
1824         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1825         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1826         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1827         taking multidictionary argument.
1828         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1829         * block.h (struct block) <dict>: Change to multidictionary
1830         and rename `multidict'.
1831         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1832         symmisc.c: Update all dictionary references to multidictionary.
1833
1834 2019-01-10  Keith Seitz  <keiths@redhat.com>
1835
1836         PR gdb/23712
1837         PR symtab/23010
1838         * dictionary.c: Include unordered_map.
1839         (pending_to_vector): New function.
1840         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1841         Rewrite the non-"_1" functions to take vector instead
1842         of linked list.
1843         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1844         "new" _1 versions of the same name.
1845         (multidictionary): Define.
1846         (std::hash<enum language): New definition.
1847         (collate_pending_symbols_by_language, mdict_create_hashed)
1848         (mdict_create_hashed_expandable, mdict_create_linear)
1849         (mdict_create_linear_expandable, mdict_free)
1850         (find_language_dictionary, create_new_language_dictionary)
1851         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1852         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1853         (mdict_size, mdict_empty): New functions.
1854         * dictionary.h (mdict_iterator): Define.
1855
1856 2019-01-10  Pedro Alves  <palves@redhat.com>
1857
1858         * breakpoint.c (read_uploaded_action)
1859         (create_tracepoint_from_upload): Adjust to use
1860         gdb::unique_xmalloc_ptr.
1861         * ctf.c (ctf_write_uploaded_tp):
1862         (SET_ARRAY_FIELD): Use emplace_back.
1863         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1864         * tracefile-tfile.c (tfile_write_uploaded_tp):
1865         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1866         gdb::unique_xmalloc_ptr.
1867         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1868         at_string, cond_string, cmd_strings>: Replace char pointers
1869         with gdb::unique_xmalloc_ptr.
1870
1871 2019-01-10  Pedro Alves  <palves@redhat.com>
1872
1873         * solib-target.c (library_list_start_library): Don't xstrdup name.
1874
1875 2019-01-10  Pedro Alves  <palves@redhat.com>
1876
1877         * mdebugread.c (parse_partial_symbols): Use
1878         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1879
1880 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1881
1882         * linux-fork.c (scoped_switch_fork_info)
1883         <~scoped_switch_fork_info>: Fix incorrect variable name.
1884
1885 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1886
1887         * linux-fork.c (scoped_switch_fork_info)
1888         <scoped_switch_fork_info>: Make explicit.
1889         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1890
1891 2019-01-10  Tom Tromey  <tom@tromey.com>
1892
1893         * objfiles.h (objfile::reset_psymtabs): Update.
1894         * objfiles.c (objfile::objfile): Update.
1895         * psymtab.h (psymtab_storage::obstack): Update.
1896         (psymtab_storage::m_obstack): Use gdb::optional.
1897         (class psymtab_storage): Update comment.  Remove objfile
1898         parameter.
1899         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1900
1901 2019-01-10  Tom Tromey  <tom@tromey.com>
1902
1903         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1904         <free_psymtabs>: Now private.
1905         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1906         (allocate_psymtab): Use new method.
1907
1908 2019-01-10  Tom Tromey  <tom@tromey.com>
1909
1910         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1911         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1912         * mdebugread.c (parse_partial_symbols): Use
1913         allocate_dependencies.
1914         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1915         allocate_dependencies.
1916         (process_psymtab_comp_unit_reader)
1917         (build_type_psymtab_dependencies): Likewise.
1918         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1919
1920 2019-01-10  Tom Tromey  <tom@tromey.com>
1921
1922         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1923         PSYMBOL_SET_LANGUAGE.
1924         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1925
1926 2019-01-10  Tom Tromey  <tom@tromey.com>
1927
1928         * psymtab.h (psymtab_storage::obstack): New method.
1929         <m_obstack>: Rename from obstack; now private.
1930         * psymtab.c (psymtab_storage): Update.
1931         * dwarf2read.c (create_addrmap_from_index)
1932         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1933         Update.
1934
1935 2019-01-10  Tom Tromey  <tom@tromey.com>
1936
1937         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1938         * objfiles.h (objfile::reset_psymtabs): New method.
1939
1940 2019-01-10  Tom Tromey  <tom@tromey.com>
1941
1942         * symmisc.c (print_symbol_bcache_statistics): Update.
1943         (print_objfile_statistics): Update.
1944         * symfile.c (reread_symbols): Update.
1945         * psymtab.h (class psymtab_storage): New.
1946         * psymtab.c (psymtab_storage): New constructor.
1947         (~psymtab_storage): New destructor.
1948         (require_partial_symbols): Update.
1949         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1950         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1951         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1952         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1953         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1954         (start_psymtab_common, end_psymtab_common)
1955         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1956         (allocate_psymtab): Update.
1957         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1958         Update.
1959         (dump_psymtab_addrmap, maintenance_print_psymbols)
1960         (maintenance_check_psymtabs): Update.
1961         (class objfile_psymtabs): Move to objfiles.h.
1962         * psympriv.h (discard_psymtab): Now inline.
1963         (psymtab_discarder::psymtab_discarder): Update.
1964         (psymtab_discarder::~psymtab_discarder): Update.
1965         (ALL_OBJFILE_PSYMTABS): Rewrite.
1966         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1967         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1968         Remove fields.
1969         <partial_symtabs>: New field.
1970         (class objfile_psymtabs): Move from psymtab.h.  Update.
1971         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1972         psymbol_cache.
1973         (objfile::~objfile): Don't destroy psymbol_cache.
1974         * mdebugread.c (parse_partial_symbols): Update.
1975         * dwarf2read.c (create_addrmap_from_index)
1976         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1977         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1978         (add_partial_subprogram, dwarf2_ranges_read): Update.
1979         * dwarf-index-write.c (write_address_map)
1980         (write_one_signatured_type, recursively_write_psymbols)
1981         (class debug_names, class debug_names, write_psymtabs_to_index):
1982         Update.
1983
1984 2019-01-10  Tom Tromey  <tom@tromey.com>
1985
1986         * symtab.h (SYMBOL_SET_NAMES): Update.
1987         (symbol_set_names): Update.
1988         (MSYMBOL_SET_NAMES): Update.
1989         * symtab.c (symbol_set_names): Change argument to be an
1990         objfile_per_bfd_storage.
1991         * psymtab.c (add_psymbol_to_bcache): Update.
1992         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1993
1994 2019-01-10  Tom Tromey  <tom@tromey.com>
1995
1996         * symtab.c (create_demangled_names_hash): Change argument to be an
1997         objfile_per_bfd_storage.
1998         (symbol_set_names): Update.
1999
2000 2019-01-10  Tom Tromey  <tom@tromey.com>
2001
2002         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2003         init_psymbol_list.
2004         * psymtab.c (init_psymbol_list): Do nothing if already called.
2005         * psympriv.h (init_psymbol_list): Add comment.
2006         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2007         init_psymbol_list.
2008         * dbxread.c (dbx_symfile_read): Unconditionally call
2009         init_psymbol_list.
2010
2011 2019-01-10  Tom Tromey  <tom@tromey.com>
2012
2013         * xcoffread.c (scan_xcoff_symtab): Update.
2014         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2015         "where".
2016         * mdebugread.c (parse_partial_symbols)
2017         (handle_psymbol_enumerators): Update.
2018         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2019         * dbxread.c (read_dbx_symtab): Update.
2020         * psympriv.h (psymbol_placement): New enum.
2021         (add_psymbol_to_list): Update.
2022
2023 2019-01-10  Tom Tromey  <tom@tromey.com>
2024
2025         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2026         static_psymbols parameters.
2027         (scan_xcoff_symtab): Update.
2028         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2029         static_psymbols parameters.
2030         * psympriv.h (start_psymtab_common): Update.
2031         * mdebugread.c (parse_partial_symbols): Update.
2032         * dwarf2read.c (create_partial_symtab): Update.
2033         * dbxread.c (read_dbx_symtab): Update.
2034         (start_psymtab): Remove global_psymbols and static_psymbols
2035         parameters.
2036
2037 2019-01-10  Tom Tromey  <tom@tromey.com>
2038
2039         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2040         * psymtab.c (allocate_psymtab): Add comment.
2041         * psympriv.h (allocate_psymtab): Add comment.
2042         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2043         initializations.
2044         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2045
2046 2019-01-10  Tom Tromey  <tom@tromey.com>
2047
2048         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2049         Don't declare.
2050         * mipsread.c: Include mdebugread.h.
2051         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2052         Declare.
2053         * elfread.c: Include mdebugread.h.
2054
2055 2019-01-09  Tom Tromey  <tom@tromey.com>
2056
2057         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2058         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2059         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2060         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2061         (psym_lookup_symbol, psym_find_last_source_symtab)
2062         (psym_forget_cached_source_info, psym_print_stats)
2063         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2064         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2065         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2066         (psym_find_compunit_symtab_by_address)
2067         (maintenance_print_psymbols, maintenance_info_psymtabs)
2068         (maintenance_check_psymtabs): Use ranged for.
2069         * psymtab.h (class objfile_psymtabs): New.
2070         (require_partial_symbols): Return objfile_psymtabs.
2071         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2072
2073 2019-01-09  Tom Tromey  <tom@tromey.com>
2074
2075         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2076         (find_pc_mapped_section, list_overlays_command)
2077         (map_overlay_command, unmap_overlay_command)
2078         (simple_overlay_update): Use all_objfiles.
2079         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2080         * printcmd.c (info_symbol_command): Use all_objfiles.
2081         * objfiles.h (ALL_OBJSECTIONS): Remove.
2082         * maint.c (maintenance_translate_address): Use all_objfiles.
2083         * gcore.c (gcore_create_callback): Use all_objfiles.
2084         (objfile_find_memory_regions): Likewise.
2085
2086 2019-01-09  Tom Tromey  <tom@tromey.com>
2087
2088         * symtab.c (find_line_symtab, info_sources_command)
2089         (make_source_files_completion_list): Use objfile_compunits.
2090         * source.c (select_source_symtab): Use objfile_compunits.
2091         * objfiles.h (struct objfile): Update comment.
2092         (ALL_OBJFILES): Remove.
2093         (ALL_FILETABS): Remove.
2094         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2095         objfile_compunits.
2096
2097 2019-01-09  Tom Tromey  <tom@tromey.com>
2098
2099         * symmisc.c (print_objfile_statistics, dump_objfile)
2100         (maintenance_print_symbols): Use compunit_filetabs.
2101         * source.c (forget_cached_source_info_for_objfile): Use
2102         compunit_filetabs.
2103         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2104         (ALL_FILETABS): Use compunit_filetabs.
2105         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2106         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2107
2108 2019-01-09  Tom Tromey  <tom@tromey.com>
2109
2110         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2111         (compunit_filetabs): New.
2112         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2113         compunit_filetabs.
2114         (info_sources_command, make_source_files_completion_list): Remove
2115         declaration.
2116         * symmisc.c (print_objfile_statistics, dump_objfile)
2117         (maintenance_print_symbols): Remove declaration.
2118         (maintenance_info_symtabs): Use compunit_filetabs.
2119         (maintenance_info_line_tables): Likewise.
2120         * source.c (select_source_symtab): Change local variable name.
2121         (forget_cached_source_info_for_objfile): Remove declaration.
2122         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2123         * objfiles.c (objfile_relocate1): Remove declaration.
2124         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2125         declaration.
2126         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2127         * coffread.c (coff_symtab_read): Remove declaration.
2128         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2129         compunit_filetabs.
2130
2131 2019-01-09  Tom Tromey  <tom@tromey.com>
2132
2133         * symtab.c (lookup_objfile_from_block)
2134         (find_pc_sect_compunit_symtab, search_symbols)
2135         (default_collect_symbol_completion_matches_break_on): Use
2136         objfile_compunits.
2137         * objfiles.h (ALL_COMPUNITS): Remove.
2138         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2139         * cp-support.c (add_symbol_overload_list_qualified): Use
2140         objfile_compunits.
2141         * ada-lang.c (ada_collect_symbol_completion_matches)
2142         (ada_add_global_exceptions): Use objfile_compunits.
2143
2144 2019-01-09  Tom Tromey  <tom@tromey.com>
2145
2146         * source.c (select_source_symtab)
2147         (forget_cached_source_info_for_objfile): Remove declaration.
2148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2149         declaration.
2150         * maint.c (count_symtabs_and_blocks): Remove declaration.
2151         * cp-support.c (add_symbol_overload_list_qualified): Remove
2152         declaration.
2153         * coffread.c (coff_symtab_read): Remove declaration.
2154         * symtab.c (lookup_symbol_in_objfile_symtabs)
2155         (basic_lookup_transparent_type_1): Use objfile_compunits.
2156         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2157         (info_sources_command, search_symbols)
2158         (default_collect_symbol_completion_matches_break_on)
2159         (make_source_files_completion_list): Remove declaration.
2160         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2161         (ada_collect_symbol_completion_matches)
2162         (ada_add_global_exceptions): Remove declaration.
2163         * linespec.c (iterate_over_all_matching_symtabs): Use
2164         objfile_compunits.
2165         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2166         (class objfile_compunits): New.
2167         (ALL_COMPUNITS): Use objfile_compunits.
2168         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2169         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2170         objfile_compunits.
2171         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2172
2173 2019-01-09  Tom Tromey  <tom@tromey.com>
2174
2175         * symtab.c (search_symbols)
2176         (default_collect_symbol_completion_matches_break_on): Use
2177         objfile_msymbols.
2178         * ada-lang.c (ada_lookup_simple_minsym)
2179         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2180         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2181         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2182         objfile_msymbols.
2183         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2184         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2185         * objc-lang.c (find_methods): Use objfile_msymbols.
2186         (info_selectors_command, info_classes_command): Likewise.
2187         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2188         * objfiles.h (class objfile_msymbols): New.
2189         (ALL_OBJFILE_MSYMBOLS): Remove.
2190         (ALL_MSYMBOLS): Remove.
2191
2192 2019-01-09  Tom Tromey  <tom@tromey.com>
2193
2194         * common/next-iterator.h (next_adapter): Add Iterator template
2195         parameter.
2196         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2197         (class all_objfiles_safe): New.
2198         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2199         * objfiles.c (put_objfile_before): Update comment.
2200         (add_separate_debug_objfile): Likewise.
2201         (free_all_objfiles): Use all_objfiles_safe.
2202         (objfile_purge_solibs): Likewise.
2203
2204 2019-01-09  Tom Tromey  <tom@tromey.com>
2205
2206         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2207         (expand_symtab_containing_pc, lookup_static_symbol)
2208         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2209         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2210         all_objfiles.
2211         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2212         * breakpoint.c (create_overlay_event_breakpoint)
2213         (create_longjmp_master_breakpoint)
2214         (create_std_terminate_master_breakpoint)
2215         (create_exception_master_breakpoint): Use all_objfiles.
2216         * linux-thread-db.c (try_thread_db_load_from_pdir)
2217         (has_libpthread): Use all_objfiles.
2218         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2219         * linespec.c (iterate_over_all_matching_symtabs)
2220         (search_minsyms_for_name): Use all_objfiles.
2221         * maint.c (maintenance_info_sections): Use all_objfiles.
2222         * main.c (captured_main_1): Use all_objfiles.
2223         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2224         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2225         * guile/scm-pretty-print.c
2226         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2227         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2228         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2229         (maintenance_print_msymbols): Use all_objfiles.
2230         * source.c (select_source_symtab): Use all_objfiles.
2231         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2232         * symfile.c (remove_symbol_file_command)
2233         (expand_symtabs_matching, map_symbol_filenames): Use
2234         all_objfiles.
2235         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2236         all_objfiles.
2237         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2238         * objc-lang.c (find_methods): Use all_objfiles.
2239         * objfiles.c (have_partial_symbols, have_full_symbols)
2240         (have_minimal_symbols, qsort_cmp)
2241         (default_iterate_over_objfiles_in_search_order): Use
2242         all_objfiles.
2243         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2244         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2245         (maintenance_check_psymtabs): Use all_objfiles.
2246         (ALL_PSYMTABS): Remove.
2247         * compile/compile-object-run.c (do_module_cleanup): Use
2248         all_objfiles.
2249         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2250         * cp-support.c (add_symbol_overload_list_qualified): Use
2251         all_objfiles.
2252         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2253         Use all_objfiles.
2254         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2255         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2256         all_objfiles.
2257         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2258         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2259         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2260         Uses all_objfiles.
2261         * solib.c (solib_read_symbols): Use all_objfiles
2262
2263 2019-01-09  Tom Tromey  <tom@tromey.com>
2264
2265         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2266         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2267         all_objfiles.
2268         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2269         * symmisc.c (print_symbol_bcache_statistics)
2270         (print_objfile_statistics, maintenance_print_objfiles)
2271         (maintenance_info_symtabs, maintenance_check_symtabs)
2272         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2273         all_objfiles.
2274         * source.c (forget_cached_source_info): Use all_objfiles.
2275         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2276         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2277         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2278         * objfiles.c (update_section_map): Use all_objfiles.
2279         (shared_objfile_contains_address_p): Likewise.
2280         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2281         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2282
2283 2019-01-09  Tom Tromey  <tom@tromey.com>
2284
2285         * common/next-iterator.h: New file.
2286         * objfiles.h (class all_objfiles): New.
2287         (struct objfile_iterator): New.
2288
2289 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2290
2291         * NEWS: Move the description of the changed "frame", "select-frame",
2292          and "info frame" commands to the Changed commands section.
2293
2294 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2295
2296         * gdbtypes.c (check_stub_method_group): Remove handling of old
2297         mangling schemes.
2298         * linespec.c (find_methods): Likewise.
2299         * stabsread.c (read_member_functions): Likewise.
2300         * valops.c (search_struct_method): Likewise.
2301         (value_struct_elt_for_reference): Likewise.
2302         * NEWS: Mention this change.
2303
2304 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2305
2306         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2307         print_source_lines.
2308         * source.c (print_source_lines_base): Update line number check.
2309         (print_source_lines): New function.
2310         (source_lines_range::source_lines_range): New function.
2311         * source.h (class source_lines_range): New class.
2312         (print_source_lines): New declaration.
2313
2314 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2315
2316         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2317
2318 2019-01-08  Tom Tromey  <tom@tromey.com>
2319             Simon Marchi  <simon.marchi@ericsson.com>
2320
2321         PR gdb/24060
2322         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2323         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2324         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2325         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2326         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2327         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2328
2329 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2330
2331         * source.c (select_source_symtab): Move header comment to
2332         declaration in source.h.
2333         (forget_cached_source_info_for_objfile): Likewise.
2334         (forget_cached_source_info): Likewise.
2335         (identify_source_line): Likewise.
2336         * source.h (identify_source_line): Move declaration from symtab.h
2337         and add comment from source.c
2338         (print_source_lines): Likewise.
2339         (forget_cached_source_info_for_objfile): Likewise.
2340         (forget_cached_source_info): Likewise.
2341         (select_source_symtab): Likewise.
2342         (enum print_source_lines_flag): Move definition from symtab.h.
2343         * symtab.h (identify_source_line): Move declaration to source.h.
2344         (print_source_lines): Likewise.
2345         (forget_cached_source_info_for_objfile): Likewise.
2346         (forget_cached_source_info): Likewise.
2347         (select_source_symtab): Likewise.
2348         (enum print_source_lines_flag): Move definition to source.h.
2349         * tui/tui-hooks.c: Add 'source.h' include.
2350
2351 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * source.c (print_source_lines_base): Handle requests to print
2354         reverse line number sequences, and guard against empty lines
2355         string.
2356
2357 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2358
2359         * source.c (print_source_lines_base): Fix skip of '\r' if next
2360         character is '\n'.
2361
2362 2019-01-06  Tom Tromey  <tom@tromey.com>
2363
2364         * c-exp.y (struct c_parse_state) <macro_original_text,
2365         expansion_obstack>: New member.
2366         (macro_original_text, expansion_obstack): Remove globals.
2367         (scan_macro_expansion, scanning_macro_expansion)
2368         (finished_macro_expansion): Update.
2369         (scan_macro_cleanup): Remove.
2370         (yylex, c_parse): Update.
2371
2372 2019-01-06  Tom Tromey  <tom@tromey.com>
2373
2374         * c-exp.y (struct c_parse_state) <strings>: New member.
2375         (operator_stoken): Update.
2376
2377 2019-01-06  Tom Tromey  <tom@tromey.com>
2378
2379         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2380         (union type_stack_elt) <typelist_val>: Now a pointer to
2381         std::vector.
2382         (type_stack_cleanup): Don't declare.
2383         (push_typelist): Update.
2384         * parse.c (pop_typelist): Return a std::vector.
2385         (push_typelist): Take a std::vector.
2386         (follow_types): Update.  Do not free args.
2387         (type_stack_cleanup): Remove.
2388         * c-exp.y (struct c_parse_state): New.
2389         (cpstate): New global.
2390         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2391         (nonempty_typelist): Update.
2392         (func_mod): Create a new vector.
2393         (c_parse): Create a c_parse_state.
2394         (check_parameter_typelist): Do not delete params.
2395         (function_method): Update.  Do not delete type_list.
2396
2397 2019-01-06  Tom Tromey  <tom@tromey.com>
2398
2399         PR gdb/28155:
2400         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2401         check_typedef.
2402         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2403         (print_return_value): Likewise.
2404
2405 2019-01-05  Tom Tromey  <tom@tromey.com>
2406
2407         * contrib/cleanup_check.py: Remove.
2408         * contrib/gcc-with-excheck: Remove.
2409         * contrib/exsummary.py: Remove.
2410         * contrib/excheck.py: Remove.
2411
2412 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2413
2414         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2415         NULL. Initialize tpprev to NULL instead of assigning it
2416         to NULL on the next statement.
2417         * windows-nat.c (windows_delete_thread): Remove check for
2418         main_thread_id before printing thread exit notifications.
2419         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2420         Remove thread ID check against main_thread_id.
2421         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2422         windows_delete_thread.
2423         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2424
2425 2019-01-04  Tom Tromey  <tom@tromey.com>
2426
2427         * compile/compile.c (_initialize_compile): Use upper case for
2428         metasyntactic variables.
2429         * symmisc.c (_initialize_symmisc): Use upper case for
2430         metasyntactic variables.
2431         * psymtab.c (_initialize_psymtab): Use upper case for
2432         metasyntactic variables.
2433         * demangle.c (demangle_command): Use upper case for metasyntactic
2434         variables.
2435         (_initialize_demangler): Likewise.
2436         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2437         variables.
2438
2439 2019-01-03  Tom Tromey  <tom@tromey.com>
2440
2441         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2442
2443 2019-01-03  Tom Tromey  <tom@tromey.com>
2444
2445         * python/py-symtab.c (salpy_str): Update.
2446         (struct salpy_sal_object) <symtab>: Now a PyObject.
2447         (salpy_dealloc): Update.
2448         (del_objfile_sal): Use gdbpy_ref.
2449
2450 2019-01-03  Tom Tromey  <tom@tromey.com>
2451
2452         * python/py-type.c (convert_field): Use new_reference.  Return
2453         gdbpy_ref.
2454         (make_fielditem): Return gdbpy_ref.
2455         (typy_fields): Update.
2456         (typy_getitem): Update.
2457         (field_name): Return gdbpy_ref.  Use new_reference.
2458         (typy_iterator_iternext): Update.
2459
2460 2019-01-03  Tom Tromey  <tom@tromey.com>
2461
2462         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2463
2464 2019-01-03  Tom Tromey  <tom@tromey.com>
2465
2466         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2467         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2468         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2469         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2470         (pspy_set_type_printers): Likewise.
2471         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2472         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2473         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2474         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2475         (objfpy_set_type_printers): Likewise.
2476
2477 2019-01-03  Tom Tromey  <tom@tromey.com>
2478
2479         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2480         (gdbpy_print_stack): Use gdbpy_err_fetch.
2481         * python/python-internal.h (class gdbpy_err_fetch): New class.
2482         (class gdbpy_enter) <m_error_type, m_error_value,
2483         m_error_traceback>: Remove.
2484         <m_error>: New member.
2485         (gdbpy_exception_to_string): Don't declare.
2486         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2487         * python/py-value.c (convert_value_from_python): Use
2488         gdbpy_err_fetch.
2489         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2490         gdbpy_exception_to_string.
2491         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2492         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2493         gdbpy_err_fetch.
2494
2495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2496
2497         * linux-nat.c (delete_lwp_cleanup): Delete.
2498         (struct lwp_deleter): New struct.
2499         (lwp_info_up): New typedef.
2500         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2501         lwp_info_up.
2502
2503 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2504
2505         * linux-fork.c (class scoped_switch_fork_info): New class.
2506         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2507
2508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2509
2510         * valops.c (find_overload_match): Remove use of null_cleanup, and
2511         calls to do_cleanups.
2512
2513 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * compile/compile-cplus-types.c
2516         (compile_cplus_instance::decl_name): Handle changes to
2517         cp_func_name.
2518         * cp-support.c (cp_func_name): Update header comment, update
2519         return type.
2520         * cp-support.h (cp_func_name): Update return type in declaration.
2521         * valops.c (find_overload_match): Move temp_func local to top
2522         level of function and change its type.  Use temp_func to hold and
2523         delete temporary string obtained from cp_func_name.
2524
2525 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2528         gdb::char_vector, remove cleanup, and update uses of `msg`.
2529
2530 2019-01-03  Jim Wilson  <jimw@sifive.com>
2531
2532         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2533
2534 2019-01-02  Tom Tromey  <tom@tromey.com>
2535
2536         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2537         (tdesc_parse_xml): Remove cleanups.
2538         * target-descriptions.h (make_cleanup_free_target_description):
2539         Don't declare.
2540         (target_desc_deleter): New struct.
2541         (target_desc_up): New typedef.
2542         * target-descriptions.c (target_desc_deleter::operator()): Rename
2543         from free_target_description.
2544         (make_cleanup_free_target_description): Remove.
2545
2546 2019-01-02  Tom Tromey  <tom@tromey.com>
2547
2548         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2549         constructor, destructor.
2550         (linespec_parser): Remove typedef.
2551         (~linespec_parser): Rename from linespec_parser_delete.
2552         (linespec_lex_to_end, linespec_complete_label)
2553         (linespec_complete): Update.
2554         (decode_line_full): Remove cleanups.
2555         (decode_line_1): Update.
2556
2557 2019-01-02  Tom Tromey  <tom@tromey.com>
2558
2559         * python/python-internal.h (inferior_to_inferior_object): Change
2560         return type.
2561         * python/py-exitedevent.c (create_exited_event_object): Update.
2562         * python/py-inferior.c (inferior_to_inferior_object): Return
2563         gdbpy_ref.
2564         (python_new_inferior, python_inferior_deleted)
2565         (thread_to_thread_object, delete_thread_object)
2566         (build_inferior_list, gdbpy_selected_inferior): Update.
2567         * python/py-infthread.c (create_thread_object): Update.  Also fail
2568         if inferior_to_inferior_object fails.
2569
2570 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2571
2572         * inferior.h (class inferior) <displaced_step_state>: New field.
2573         * infrun.h (struct displaced_step_state): Move here from
2574         infrun.c.  Initialize fields, add constructor.
2575         <inf>: Remove field.
2576         <reset>: New method.
2577         * infrun.c (struct displaced_step_inferior_state): Move to
2578         infrun.h.
2579         (displaced_step_inferior_states): Remove.
2580         (get_displaced_stepping_state): Adust.
2581         (displaced_step_in_progress_any_inferior): Adjust.
2582         (displaced_step_in_progress_thread): Adjust.
2583         (displaced_step_in_progress): Adjust.
2584         (add_displaced_stepping_state): Remove.
2585         (get_displaced_step_closure_by_addr): Adjust.
2586         (remove_displaced_stepping_state): Remove.
2587         (infrun_inferior_exit): Call displaced_step_state.reset.
2588         (use_displaced_stepping): Don't check for NULL.
2589         (displaced_step_prepare_throw): Call
2590         get_displaced_stepping_state.
2591         (displaced_step_fixup): Don't check for NULL.
2592         (prepare_for_detach): Don't check for NULL.
2593
2594 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2595
2596         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2597          in case of call that did not complete.
2598
2599 2019-01-02  Andrey Utkin  <autkin@undo.io>
2600
2601         * symfile.c (find_separate_debug_file): Fix search of debug files for
2602         remote debuggee.
2603
2604 2019-01-02  Tom Tromey  <tom@tromey.com>
2605
2606         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2607         indentation.
2608         * python/py-frame.c (frapy_older): Remove cast.
2609         (frapy_newer): Likewise.
2610         * python/py-breakpoint.c (local_setattro): Remove cast.
2611         * python/py-arch.c (archpy_name): Remove local variable.
2612         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2613
2614 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2615
2616         * unittests/basic_string_view/element_access/char/empty.cc:
2617         Fix year range in copyright header.
2618
2619 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2622         Delete.
2623         <operator==>: Update with for removed field.
2624         <hash>: Likewise.
2625         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2626         <isa_features>: ...this.
2627         <abi_features>: New field.
2628         (riscv_isa_flen): Update comment.
2629         (riscv_abi_xlen): New declaration.
2630         (riscv_abi_flen): New declaration.
2631         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2632         isa_features.
2633         (riscv_abi_xlen): New function.
2634         (riscv_isa_flen): Update to get answer from isa_features.
2635         (riscv_abi_flen): New function.
2636         (riscv_has_fp_abi): Update to get answer from abi_features.
2637         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2638         xlen and flen.
2639         (riscv_call_info) <xlen, flen>: Update comment.
2640         (riscv_call_arg_struct): Remove invalid assertions
2641         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2642         is removed.
2643         (riscv_gdbarch_init): Gather isa features and abi features
2644         separately, ensure both match on the gdbarch when reusing an old
2645         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2646         a target with 64-bit float hardware.
2647
2648 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2649
2650         * source.c (search_command_helper): Stop reverse search
2651         when line 1 has been searched.
2652
2653 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2654
2655         * record-full.c (record_full_base_target::close): Rewrite
2656         record_full_core_buf_list free logic.
2657
2658 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2659
2660         * break-catch-syscall.c (print_one_catch_syscall): xfree
2661         the last text.
2662
2663 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2664
2665         * top.c (print_gdb_version): Update Copyright year in version
2666         message.
2667
2668 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2669
2670         Update copyright year range in all GDB files.
2671
2672 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2673
2674         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2675
2676 For older changes see ChangeLog-2018.
2677 \f
2678 Local Variables:
2679 mode: change-log
2680 left-margin: 8
2681 fill-column: 74
2682 version-control: never
2683 coding: utf-8
2684 End:
2685