gdb/ChangeLog

   1 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * linux-fork.c (scoped_switch_fork_info)
   4         <scoped_switch_fork_info>: Make explicit.
   5         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
   6
   7 2019-01-10  Tom Tromey  <tom@tromey.com>
   8
   9         * objfiles.h (objfile::reset_psymtabs): Update.
  10         * objfiles.c (objfile::objfile): Update.
  11         * psymtab.h (psymtab_storage::obstack): Update.
  12         (psymtab_storage::m_obstack): Use gdb::optional.
  13         (class psymtab_storage): Update comment.  Remove objfile
  14         parameter.
  15         * psymtab.c (psymtab_storage::psymtab_storage): Update.
  16
  17 2019-01-10  Tom Tromey  <tom@tromey.com>
  18
  19         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
  20         <free_psymtabs>: Now private.
  21         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
  22         (allocate_psymtab): Use new method.
  23
  24 2019-01-10  Tom Tromey  <tom@tromey.com>
  25
  26         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
  27         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
  28         * mdebugread.c (parse_partial_symbols): Use
  29         allocate_dependencies.
  30         * dwarf2read.c (dwarf2_create_include_psymtab): Use
  31         allocate_dependencies.
  32         (process_psymtab_comp_unit_reader)
  33         (build_type_psymtab_dependencies): Likewise.
  34         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
  35
  36 2019-01-10  Tom Tromey  <tom@tromey.com>
  37
  38         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
  39         PSYMBOL_SET_LANGUAGE.
  40         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
  41
  42 2019-01-10  Tom Tromey  <tom@tromey.com>
  43
  44         * psymtab.h (psymtab_storage::obstack): New method.
  45         <m_obstack>: Rename from obstack; now private.
  46         * psymtab.c (psymtab_storage): Update.
  47         * dwarf2read.c (create_addrmap_from_index)
  48         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
  49         Update.
  50
  51 2019-01-10  Tom Tromey  <tom@tromey.com>
  52
  53         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
  54         * objfiles.h (objfile::reset_psymtabs): New method.
  55
  56 2019-01-10  Tom Tromey  <tom@tromey.com>
  57
  58         * symmisc.c (print_symbol_bcache_statistics): Update.
  59         (print_objfile_statistics): Update.
  60         * symfile.c (reread_symbols): Update.
  61         * psymtab.h (class psymtab_storage): New.
  62         * psymtab.c (psymtab_storage): New constructor.
  63         (~psymtab_storage): New destructor.
  64         (require_partial_symbols): Update.
  65         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
  66         (find_pc_sect_psymtab, find_pc_sect_psymbol)
  67         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
  68         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
  69         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
  70         (start_psymtab_common, end_psymtab_common)
  71         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
  72         (allocate_psymtab): Update.
  73         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
  74         Update.
  75         (dump_psymtab_addrmap, maintenance_print_psymbols)
  76         (maintenance_check_psymtabs): Update.
  77         (class objfile_psymtabs): Move to objfiles.h.
  78         * psympriv.h (discard_psymtab): Now inline.
  79         (psymtab_discarder::psymtab_discarder): Update.
  80         (psymtab_discarder::~psymtab_discarder): Update.
  81         (ALL_OBJFILE_PSYMTABS): Rewrite.
  82         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
  83         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
  84         Remove fields.
  85         <partial_symtabs>: New field.
  86         (class objfile_psymtabs): Move from psymtab.h.  Update.
  87         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
  88         psymbol_cache.
  89         (objfile::~objfile): Don't destroy psymbol_cache.
  90         * mdebugread.c (parse_partial_symbols): Update.
  91         * dwarf2read.c (create_addrmap_from_index)
  92         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
  93         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
  94         (add_partial_subprogram, dwarf2_ranges_read): Update.
  95         * dwarf-index-write.c (write_address_map)
  96         (write_one_signatured_type, recursively_write_psymbols)
  97         (class debug_names, class debug_names, write_psymtabs_to_index):
  98         Update.
  99
 100 2019-01-10  Tom Tromey  <tom@tromey.com>
 101
 102         * symtab.h (SYMBOL_SET_NAMES): Update.
 103         (symbol_set_names): Update.
 104         (MSYMBOL_SET_NAMES): Update.
 105         * symtab.c (symbol_set_names): Change argument to be an
 106         objfile_per_bfd_storage.
 107         * psymtab.c (add_psymbol_to_bcache): Update.
 108         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 109
 110 2019-01-10  Tom Tromey  <tom@tromey.com>
 111
 112         * symtab.c (create_demangled_names_hash): Change argument to be an
 113         objfile_per_bfd_storage.
 114         (symbol_set_names): Update.
 115
 116 2019-01-10  Tom Tromey  <tom@tromey.com>
 117
 118         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 119         init_psymbol_list.
 120         * psymtab.c (init_psymbol_list): Do nothing if already called.
 121         * psympriv.h (init_psymbol_list): Add comment.
 122         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 123         init_psymbol_list.
 124         * dbxread.c (dbx_symfile_read): Unconditionally call
 125         init_psymbol_list.
 126
 127 2019-01-10  Tom Tromey  <tom@tromey.com>
 128
 129         * xcoffread.c (scan_xcoff_symtab): Update.
 130         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 131         "where".
 132         * mdebugread.c (parse_partial_symbols)
 133         (handle_psymbol_enumerators): Update.
 134         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 135         * dbxread.c (read_dbx_symtab): Update.
 136         * psympriv.h (psymbol_placement): New enum.
 137         (add_psymbol_to_list): Update.
 138
 139 2019-01-10  Tom Tromey  <tom@tromey.com>
 140
 141         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 142         static_psymbols parameters.
 143         (scan_xcoff_symtab): Update.
 144         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 145         static_psymbols parameters.
 146         * psympriv.h (start_psymtab_common): Update.
 147         * mdebugread.c (parse_partial_symbols): Update.
 148         * dwarf2read.c (create_partial_symtab): Update.
 149         * dbxread.c (read_dbx_symtab): Update.
 150         (start_psymtab): Remove global_psymbols and static_psymbols
 151         parameters.
 152
 153 2019-01-10  Tom Tromey  <tom@tromey.com>
 154
 155         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 156         * psymtab.c (allocate_psymtab): Add comment.
 157         * psympriv.h (allocate_psymtab): Add comment.
 158         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 159         initializations.
 160         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 161
 162 2019-01-10  Tom Tromey  <tom@tromey.com>
 163
 164         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 165         Don't declare.
 166         * mipsread.c: Include mdebugread.h.
 167         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 168         Declare.
 169         * elfread.c: Include mdebugread.h.
 170
 171 2019-01-09  Tom Tromey  <tom@tromey.com>
 172
 173         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 174         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 175         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 176         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 177         (psym_lookup_symbol, psym_find_last_source_symtab)
 178         (psym_forget_cached_source_info, psym_print_stats)
 179         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 180         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 181         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 182         (psym_find_compunit_symtab_by_address)
 183         (maintenance_print_psymbols, maintenance_info_psymtabs)
 184         (maintenance_check_psymtabs): Use ranged for.
 185         * psymtab.h (class objfile_psymtabs): New.
 186         (require_partial_symbols): Return objfile_psymtabs.
 187         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 188
 189 2019-01-09  Tom Tromey  <tom@tromey.com>
 190
 191         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 192         (find_pc_mapped_section, list_overlays_command)
 193         (map_overlay_command, unmap_overlay_command)
 194         (simple_overlay_update): Use all_objfiles.
 195         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 196         * printcmd.c (info_symbol_command): Use all_objfiles.
 197         * objfiles.h (ALL_OBJSECTIONS): Remove.
 198         * maint.c (maintenance_translate_address): Use all_objfiles.
 199         * gcore.c (gcore_create_callback): Use all_objfiles.
 200         (objfile_find_memory_regions): Likewise.
 201
 202 2019-01-09  Tom Tromey  <tom@tromey.com>
 203
 204         * symtab.c (find_line_symtab, info_sources_command)
 205         (make_source_files_completion_list): Use objfile_compunits.
 206         * source.c (select_source_symtab): Use objfile_compunits.
 207         * objfiles.h (struct objfile): Update comment.
 208         (ALL_OBJFILES): Remove.
 209         (ALL_FILETABS): Remove.
 210         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 211         objfile_compunits.
 212
 213 2019-01-09  Tom Tromey  <tom@tromey.com>
 214
 215         * symmisc.c (print_objfile_statistics, dump_objfile)
 216         (maintenance_print_symbols): Use compunit_filetabs.
 217         * source.c (forget_cached_source_info_for_objfile): Use
 218         compunit_filetabs.
 219         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 220         (ALL_FILETABS): Use compunit_filetabs.
 221         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 222         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 223
 224 2019-01-09  Tom Tromey  <tom@tromey.com>
 225
 226         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 227         (compunit_filetabs): New.
 228         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 229         compunit_filetabs.
 230         (info_sources_command, make_source_files_completion_list): Remove
 231         declaration.
 232         * symmisc.c (print_objfile_statistics, dump_objfile)
 233         (maintenance_print_symbols): Remove declaration.
 234         (maintenance_info_symtabs): Use compunit_filetabs.
 235         (maintenance_info_line_tables): Likewise.
 236         * source.c (select_source_symtab): Change local variable name.
 237         (forget_cached_source_info_for_objfile): Remove declaration.
 238         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 239         * objfiles.c (objfile_relocate1): Remove declaration.
 240         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 241         declaration.
 242         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 243         * coffread.c (coff_symtab_read): Remove declaration.
 244         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 245         compunit_filetabs.
 246
 247 2019-01-09  Tom Tromey  <tom@tromey.com>
 248
 249         * symtab.c (lookup_objfile_from_block)
 250         (find_pc_sect_compunit_symtab, search_symbols)
 251         (default_collect_symbol_completion_matches_break_on): Use
 252         objfile_compunits.
 253         * objfiles.h (ALL_COMPUNITS): Remove.
 254         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 255         * cp-support.c (add_symbol_overload_list_qualified): Use
 256         objfile_compunits.
 257         * ada-lang.c (ada_collect_symbol_completion_matches)
 258         (ada_add_global_exceptions): Use objfile_compunits.
 259
 260 2019-01-09  Tom Tromey  <tom@tromey.com>
 261
 262         * source.c (select_source_symtab)
 263         (forget_cached_source_info_for_objfile): Remove declaration.
 264         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 265         declaration.
 266         * maint.c (count_symtabs_and_blocks): Remove declaration.
 267         * cp-support.c (add_symbol_overload_list_qualified): Remove
 268         declaration.
 269         * coffread.c (coff_symtab_read): Remove declaration.
 270         * symtab.c (lookup_symbol_in_objfile_symtabs)
 271         (basic_lookup_transparent_type_1): Use objfile_compunits.
 272         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 273         (info_sources_command, search_symbols)
 274         (default_collect_symbol_completion_matches_break_on)
 275         (make_source_files_completion_list): Remove declaration.
 276         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 277         (ada_collect_symbol_completion_matches)
 278         (ada_add_global_exceptions): Remove declaration.
 279         * linespec.c (iterate_over_all_matching_symtabs): Use
 280         objfile_compunits.
 281         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 282         (class objfile_compunits): New.
 283         (ALL_COMPUNITS): Use objfile_compunits.
 284         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 285         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 286         objfile_compunits.
 287         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 288
 289 2019-01-09  Tom Tromey  <tom@tromey.com>
 290
 291         * symtab.c (search_symbols)
 292         (default_collect_symbol_completion_matches_break_on): Use
 293         objfile_msymbols.
 294         * ada-lang.c (ada_lookup_simple_minsym)
 295         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 296         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 297         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 298         objfile_msymbols.
 299         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 300         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 301         * objc-lang.c (find_methods): Use objfile_msymbols.
 302         (info_selectors_command, info_classes_command): Likewise.
 303         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 304         * objfiles.h (class objfile_msymbols): New.
 305         (ALL_OBJFILE_MSYMBOLS): Remove.
 306         (ALL_MSYMBOLS): Remove.
 307
 308 2019-01-09  Tom Tromey  <tom@tromey.com>
 309
 310         * common/next-iterator.h (next_adapter): Add Iterator template
 311         parameter.
 312         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 313         (class all_objfiles_safe): New.
 314         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 315         * objfiles.c (put_objfile_before): Update comment.
 316         (add_separate_debug_objfile): Likewise.
 317         (free_all_objfiles): Use all_objfiles_safe.
 318         (objfile_purge_solibs): Likewise.
 319
 320 2019-01-09  Tom Tromey  <tom@tromey.com>
 321
 322         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 323         (expand_symtab_containing_pc, lookup_static_symbol)
 324         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 325         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 326         all_objfiles.
 327         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 328         * breakpoint.c (create_overlay_event_breakpoint)
 329         (create_longjmp_master_breakpoint)
 330         (create_std_terminate_master_breakpoint)
 331         (create_exception_master_breakpoint): Use all_objfiles.
 332         * linux-thread-db.c (try_thread_db_load_from_pdir)
 333         (has_libpthread): Use all_objfiles.
 334         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 335         * linespec.c (iterate_over_all_matching_symtabs)
 336         (search_minsyms_for_name): Use all_objfiles.
 337         * maint.c (maintenance_info_sections): Use all_objfiles.
 338         * main.c (captured_main_1): Use all_objfiles.
 339         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 340         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 341         * guile/scm-pretty-print.c
 342         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 343         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 344         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 345         (maintenance_print_msymbols): Use all_objfiles.
 346         * source.c (select_source_symtab): Use all_objfiles.
 347         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 348         * symfile.c (remove_symbol_file_command)
 349         (expand_symtabs_matching, map_symbol_filenames): Use
 350         all_objfiles.
 351         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 352         all_objfiles.
 353         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 354         * objc-lang.c (find_methods): Use all_objfiles.
 355         * objfiles.c (have_partial_symbols, have_full_symbols)
 356         (have_minimal_symbols, qsort_cmp)
 357         (default_iterate_over_objfiles_in_search_order): Use
 358         all_objfiles.
 359         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 360         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 361         (maintenance_check_psymtabs): Use all_objfiles.
 362         (ALL_PSYMTABS): Remove.
 363         * compile/compile-object-run.c (do_module_cleanup): Use
 364         all_objfiles.
 365         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 366         * cp-support.c (add_symbol_overload_list_qualified): Use
 367         all_objfiles.
 368         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 369         Use all_objfiles.
 370         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 371         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 372         all_objfiles.
 373         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 374         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 375         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 376         Uses all_objfiles.
 377         * solib.c (solib_read_symbols): Use all_objfiles
 378
 379 2019-01-09  Tom Tromey  <tom@tromey.com>
 380
 381         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 382         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 383         all_objfiles.
 384         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 385         * symmisc.c (print_symbol_bcache_statistics)
 386         (print_objfile_statistics, maintenance_print_objfiles)
 387         (maintenance_info_symtabs, maintenance_check_symtabs)
 388         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 389         all_objfiles.
 390         * source.c (forget_cached_source_info): Use all_objfiles.
 391         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 392         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 393         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 394         * objfiles.c (update_section_map): Use all_objfiles.
 395         (shared_objfile_contains_address_p): Likewise.
 396         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 397         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 398
 399 2019-01-09  Tom Tromey  <tom@tromey.com>
 400
 401         * common/next-iterator.h: New file.
 402         * objfiles.h (class all_objfiles): New.
 403         (struct objfile_iterator): New.
 404
 405 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 406
 407         * NEWS: Move the description of the changed "frame", "select-frame",
 408          and "info frame" commands to the Changed commands section.
 409
 410 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 411
 412         * gdbtypes.c (check_stub_method_group): Remove handling of old
 413         mangling schemes.
 414         * linespec.c (find_methods): Likewise.
 415         * stabsread.c (read_member_functions): Likewise.
 416         * valops.c (search_struct_method): Likewise.
 417         (value_struct_elt_for_reference): Likewise.
 418         * NEWS: Mention this change.
 419
 420 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 421
 422         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 423         print_source_lines.
 424         * source.c (print_source_lines_base): Update line number check.
 425         (print_source_lines): New function.
 426         (source_lines_range::source_lines_range): New function.
 427         * source.h (class source_lines_range): New class.
 428         (print_source_lines): New declaration.
 429
 430 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 431
 432         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 433
 434 2019-01-08  Tom Tromey  <tom@tromey.com>
 435             Simon Marchi  <simon.marchi@ericsson.com>
 436
 437         PR gdb/24060
 438         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 439         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 440         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 441         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 442         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 443         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 444
 445 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 446
 447         * source.c (select_source_symtab): Move header comment to
 448         declaration in source.h.
 449         (forget_cached_source_info_for_objfile): Likewise.
 450         (forget_cached_source_info): Likewise.
 451         (identify_source_line): Likewise.
 452         * source.h (identify_source_line): Move declaration from symtab.h
 453         and add comment from source.c
 454         (print_source_lines): Likewise.
 455         (forget_cached_source_info_for_objfile): Likewise.
 456         (forget_cached_source_info): Likewise.
 457         (select_source_symtab): Likewise.
 458         (enum print_source_lines_flag): Move definition from symtab.h.
 459         * symtab.h (identify_source_line): Move declaration to source.h.
 460         (print_source_lines): Likewise.
 461         (forget_cached_source_info_for_objfile): Likewise.
 462         (forget_cached_source_info): Likewise.
 463         (select_source_symtab): Likewise.
 464         (enum print_source_lines_flag): Move definition to source.h.
 465         * tui/tui-hooks.c: Add 'source.h' include.
 466
 467 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 468
 469         * source.c (print_source_lines_base): Handle requests to print
 470         reverse line number sequences, and guard against empty lines
 471         string.
 472
 473 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 474
 475         * source.c (print_source_lines_base): Fix skip of '\r' if next
 476         character is '\n'.
 477
 478 2019-01-06  Tom Tromey  <tom@tromey.com>
 479
 480         * c-exp.y (struct c_parse_state) <macro_original_text,
 481         expansion_obstack>: New member.
 482         (macro_original_text, expansion_obstack): Remove globals.
 483         (scan_macro_expansion, scanning_macro_expansion)
 484         (finished_macro_expansion): Update.
 485         (scan_macro_cleanup): Remove.
 486         (yylex, c_parse): Update.
 487
 488 2019-01-06  Tom Tromey  <tom@tromey.com>
 489
 490         * c-exp.y (struct c_parse_state) <strings>: New member.
 491         (operator_stoken): Update.
 492
 493 2019-01-06  Tom Tromey  <tom@tromey.com>
 494
 495         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 496         (union type_stack_elt) <typelist_val>: Now a pointer to
 497         std::vector.
 498         (type_stack_cleanup): Don't declare.
 499         (push_typelist): Update.
 500         * parse.c (pop_typelist): Return a std::vector.
 501         (push_typelist): Take a std::vector.
 502         (follow_types): Update.  Do not free args.
 503         (type_stack_cleanup): Remove.
 504         * c-exp.y (struct c_parse_state): New.
 505         (cpstate): New global.
 506         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 507         (nonempty_typelist): Update.
 508         (func_mod): Create a new vector.
 509         (c_parse): Create a c_parse_state.
 510         (check_parameter_typelist): Do not delete params.
 511         (function_method): Update.  Do not delete type_list.
 512
 513 2019-01-06  Tom Tromey  <tom@tromey.com>
 514
 515         PR gdb/28155:
 516         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 517         check_typedef.
 518         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 519         (print_return_value): Likewise.
 520
 521 2019-01-05  Tom Tromey  <tom@tromey.com>
 522
 523         * contrib/cleanup_check.py: Remove.
 524         * contrib/gcc-with-excheck: Remove.
 525         * contrib/exsummary.py: Remove.
 526         * contrib/excheck.py: Remove.
 527
 528 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 529
 530         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 531         NULL. Initialize tpprev to NULL instead of assigning it
 532         to NULL on the next statement.
 533         * windows-nat.c (windows_delete_thread): Remove check for
 534         main_thread_id before printing thread exit notifications.
 535         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 536         Remove thread ID check against main_thread_id.
 537         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 538         windows_delete_thread.
 539         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 540
 541 2019-01-04  Tom Tromey  <tom@tromey.com>
 542
 543         * compile/compile.c (_initialize_compile): Use upper case for
 544         metasyntactic variables.
 545         * symmisc.c (_initialize_symmisc): Use upper case for
 546         metasyntactic variables.
 547         * psymtab.c (_initialize_psymtab): Use upper case for
 548         metasyntactic variables.
 549         * demangle.c (demangle_command): Use upper case for metasyntactic
 550         variables.
 551         (_initialize_demangler): Likewise.
 552         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 553         variables.
 554
 555 2019-01-03  Tom Tromey  <tom@tromey.com>
 556
 557         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 558
 559 2019-01-03  Tom Tromey  <tom@tromey.com>
 560
 561         * python/py-symtab.c (salpy_str): Update.
 562         (struct salpy_sal_object) <symtab>: Now a PyObject.
 563         (salpy_dealloc): Update.
 564         (del_objfile_sal): Use gdbpy_ref.
 565
 566 2019-01-03  Tom Tromey  <tom@tromey.com>
 567
 568         * python/py-type.c (convert_field): Use new_reference.  Return
 569         gdbpy_ref.
 570         (make_fielditem): Return gdbpy_ref.
 571         (typy_fields): Update.
 572         (typy_getitem): Update.
 573         (field_name): Return gdbpy_ref.  Use new_reference.
 574         (typy_iterator_iternext): Update.
 575
 576 2019-01-03  Tom Tromey  <tom@tromey.com>
 577
 578         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 579
 580 2019-01-03  Tom Tromey  <tom@tromey.com>
 581
 582         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 583         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 584         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 585         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 586         (pspy_set_type_printers): Likewise.
 587         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 588         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 589         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 590         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 591         (objfpy_set_type_printers): Likewise.
 592
 593 2019-01-03  Tom Tromey  <tom@tromey.com>
 594
 595         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 596         (gdbpy_print_stack): Use gdbpy_err_fetch.
 597         * python/python-internal.h (class gdbpy_err_fetch): New class.
 598         (class gdbpy_enter) <m_error_type, m_error_value,
 599         m_error_traceback>: Remove.
 600         <m_error>: New member.
 601         (gdbpy_exception_to_string): Don't declare.
 602         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 603         * python/py-value.c (convert_value_from_python): Use
 604         gdbpy_err_fetch.
 605         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 606         gdbpy_exception_to_string.
 607         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 608         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 609         gdbpy_err_fetch.
 610
 611 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 612
 613         * linux-nat.c (delete_lwp_cleanup): Delete.
 614         (struct lwp_deleter): New struct.
 615         (lwp_info_up): New typedef.
 616         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 617         lwp_info_up.
 618
 619 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 620
 621         * linux-fork.c (class scoped_switch_fork_info): New class.
 622         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 623
 624 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * valops.c (find_overload_match): Remove use of null_cleanup, and
 627         calls to do_cleanups.
 628
 629 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 630
 631         * compile/compile-cplus-types.c
 632         (compile_cplus_instance::decl_name): Handle changes to
 633         cp_func_name.
 634         * cp-support.c (cp_func_name): Update header comment, update
 635         return type.
 636         * cp-support.h (cp_func_name): Update return type in declaration.
 637         * valops.c (find_overload_match): Move temp_func local to top
 638         level of function and change its type.  Use temp_func to hold and
 639         delete temporary string obtained from cp_func_name.
 640
 641 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 642
 643         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 644         gdb::char_vector, remove cleanup, and update uses of `msg`.
 645
 646 2019-01-03  Jim Wilson  <jimw@sifive.com>
 647
 648         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 649
 650 2019-01-02  Tom Tromey  <tom@tromey.com>
 651
 652         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 653         (tdesc_parse_xml): Remove cleanups.
 654         * target-descriptions.h (make_cleanup_free_target_description):
 655         Don't declare.
 656         (target_desc_deleter): New struct.
 657         (target_desc_up): New typedef.
 658         * target-descriptions.c (target_desc_deleter::operator()): Rename
 659         from free_target_description.
 660         (make_cleanup_free_target_description): Remove.
 661
 662 2019-01-02  Tom Tromey  <tom@tromey.com>
 663
 664         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
 665         constructor, destructor.
 666         (linespec_parser): Remove typedef.
 667         (~linespec_parser): Rename from linespec_parser_delete.
 668         (linespec_lex_to_end, linespec_complete_label)
 669         (linespec_complete): Update.
 670         (decode_line_full): Remove cleanups.
 671         (decode_line_1): Update.
 672
 673 2019-01-02  Tom Tromey  <tom@tromey.com>
 674
 675         * python/python-internal.h (inferior_to_inferior_object): Change
 676         return type.
 677         * python/py-exitedevent.c (create_exited_event_object): Update.
 678         * python/py-inferior.c (inferior_to_inferior_object): Return
 679         gdbpy_ref.
 680         (python_new_inferior, python_inferior_deleted)
 681         (thread_to_thread_object, delete_thread_object)
 682         (build_inferior_list, gdbpy_selected_inferior): Update.
 683         * python/py-infthread.c (create_thread_object): Update.  Also fail
 684         if inferior_to_inferior_object fails.
 685
 686 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
 687
 688         * inferior.h (class inferior) <displaced_step_state>: New field.
 689         * infrun.h (struct displaced_step_state): Move here from
 690         infrun.c.  Initialize fields, add constructor.
 691         <inf>: Remove field.
 692         <reset>: New method.
 693         * infrun.c (struct displaced_step_inferior_state): Move to
 694         infrun.h.
 695         (displaced_step_inferior_states): Remove.
 696         (get_displaced_stepping_state): Adust.
 697         (displaced_step_in_progress_any_inferior): Adjust.
 698         (displaced_step_in_progress_thread): Adjust.
 699         (displaced_step_in_progress): Adjust.
 700         (add_displaced_stepping_state): Remove.
 701         (get_displaced_step_closure_by_addr): Adjust.
 702         (remove_displaced_stepping_state): Remove.
 703         (infrun_inferior_exit): Call displaced_step_state.reset.
 704         (use_displaced_stepping): Don't check for NULL.
 705         (displaced_step_prepare_throw): Call
 706         get_displaced_stepping_state.
 707         (displaced_step_fixup): Don't check for NULL.
 708         (prepare_for_detach): Don't check for NULL.
 709
 710 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 711
 712         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
 713          in case of call that did not complete.
 714
 715 2019-01-02  Andrey Utkin  <autkin@undo.io>
 716
 717         * symfile.c (find_separate_debug_file): Fix search of debug files for
 718         remote debuggee.
 719
 720 2019-01-02  Tom Tromey  <tom@tromey.com>
 721
 722         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
 723         indentation.
 724         * python/py-frame.c (frapy_older): Remove cast.
 725         (frapy_newer): Likewise.
 726         * python/py-breakpoint.c (local_setattro): Remove cast.
 727         * python/py-arch.c (archpy_name): Remove local variable.
 728         * python/py-type.c (gdbpy_lookup_type): Remove cast.
 729
 730 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
 731
 732         * unittests/basic_string_view/element_access/char/empty.cc:
 733         Fix year range in copyright header.
 734
 735 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 736
 737         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
 738         Delete.
 739         <operator==>: Update with for removed field.
 740         <hash>: Likewise.
 741         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
 742         <isa_features>: ...this.
 743         <abi_features>: New field.
 744         (riscv_isa_flen): Update comment.
 745         (riscv_abi_xlen): New declaration.
 746         (riscv_abi_flen): New declaration.
 747         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
 748         isa_features.
 749         (riscv_abi_xlen): New function.
 750         (riscv_isa_flen): Update to get answer from isa_features.
 751         (riscv_abi_flen): New function.
 752         (riscv_has_fp_abi): Update to get answer from abi_features.
 753         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
 754         xlen and flen.
 755         (riscv_call_info) <xlen, flen>: Update comment.
 756         (riscv_call_arg_struct): Remove invalid assertions
 757         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
 758         is removed.
 759         (riscv_gdbarch_init): Gather isa features and abi features
 760         separately, ensure both match on the gdbarch when reusing an old
 761         gdbarch.  Relax an error check to allow 32-bit abi float to run on
 762         a target with 64-bit float hardware.
 763
 764 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 765
 766         * source.c (search_command_helper): Stop reverse search
 767         when line 1 has been searched.
 768
 769 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 770
 771         * record-full.c (record_full_base_target::close): Rewrite
 772         record_full_core_buf_list free logic.
 773
 774 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 775
 776         * break-catch-syscall.c (print_one_catch_syscall): xfree
 777         the last text.
 778
 779 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 780
 781         * top.c (print_gdb_version): Update Copyright year in version
 782         message.
 783
 784 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 785
 786         Update copyright year range in all GDB files.
 787
 788 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 789
 790         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
 791
 792 For older changes see ChangeLog-2018.
 793 \f
 794 Local Variables:
 795 mode: change-log
 796 left-margin: 8
 797 fill-column: 74
 798 version-control: never
 799 coding: utf-8
 800 End:
 801