gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
   4         (rust_parser::convert_ast_to_type)
   5         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
   6         * parser-defs.h (struct parser_state) <parser_state>: Add
   7         parameters.  Initialize new members.
   8         <expression_context_block, expression_context_pc>: New members.
   9         * parse.c (expression_context_block, expression_context_pc):
  10         Remove globals.
  11         (parse_exp_in_context): Update.
  12         * p-exp.y: Update all rules.
  13         (yylex): Update.
  14         * m2-exp.y: Update all rules.
  15         (yylex): Update.
  16         * go-exp.y (yylex): Update.
  17         * f-exp.y (yylex): Update.
  18         * d-exp.y: Update all rules.
  19         (yylex): Update.
  20         * c-exp.y: Update all rules.
  21         (lex_one_token, classify_name, yylex, c_parse): Update.
  22         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
  23
  24 2019-04-04  Tom Tromey  <tom@tromey.com>
  25
  26         * gdbarch.h, gdbarch.c: Rebuild.
  27         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
  28         * stap-probe.h:
  29         (struct stap_parse_info): Replace "parser_state" with
  30         "expr_builder".
  31         * parser-defs.h (struct expr_builder): Rename from "parser_state".
  32         (parser_state): New class.
  33         * parse.c (expr_builder): Rename.
  34         (expr_builder::release): Rename.
  35         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
  36         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
  37         (write_exp_elt_longcst, write_exp_elt_floatcst)
  38         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
  39         (write_exp_string_vector, write_exp_bitstring)
  40         (write_exp_msymbol, mark_struct_expression)
  41         (write_dollar_variable)
  42         (insert_type_address_space, increase_expout_size): Replace
  43         "parser_state" with "expr_builder".
  44         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
  45         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
  46         "parser_state" with "expr_builder".
  47
  48 2019-04-04  Tom Tromey  <tom@tromey.com>
  49
  50         * rust-exp.y: Replace "parse_language" with method call.
  51         * p-exp.y:
  52         (yylex): Replace "parse_language" with method call.
  53         * m2-exp.y:
  54         (yylex): Replace "parse_language" with method call.
  55         * go-exp.y (classify_name): Replace "parse_language" with method
  56         call.
  57         * f-exp.y (yylex): Replace "parse_language" with method call.
  58         * d-exp.y (lex_one_token): Replace "parse_language" with method
  59         call.
  60         * c-exp.y:
  61         (lex_one_token, classify_name, yylex): Replace "parse_language"
  62         with method call.
  63         * ada-exp.y (find_primitive_type, type_char)
  64         (type_system_address): Replace "parse_language" with method call.
  65
  66 2019-04-04  Tom Tromey  <tom@tromey.com>
  67
  68         * rust-exp.y: Replace "parse_gdbarch" with method call.
  69         * parse.c (write_dollar_variable, insert_type_address_space):
  70         Replace "parse_gdbarch" with method call.
  71         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
  72         call.
  73         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
  74         call.
  75         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
  76         "parse_gdbarch" with method call.
  77         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
  78         with method call.
  79         * f-exp.y (parse_type, parse_f_type, yylex): Replace
  80         "parse_gdbarch" with method call.
  81         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
  82         "parse_gdbarch" with method call.
  83         * c-exp.y (parse_type, parse_number, classify_name): Replace
  84         "parse_gdbarch" with method call.
  85         * ada-lex.l: Replace "parse_gdbarch" with method call.
  86         * ada-exp.y (parse_type, find_primitive_type, type_char)
  87         (type_system_address): Replace "parse_gdbarch" with method call.
  88
  89 2019-04-04  Tom Tromey  <tom@tromey.com>
  90
  91         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
  92         * stap-probe.c (stap_parse_argument): Update.
  93         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
  94         initial_size parameter.
  95         * rust-exp.y (rust_lex_tests): Update.
  96         * parse.c (parser_state): Update.
  97         (parse_exp_in_context): Update.
  98         * parser-defs.h (struct parser_state) <parser_state>: Remove
  99         "initial_size" parameter.
 100
 101 2019-04-04  Tom Tromey  <tom@tromey.com>
 102
 103         * parser-defs.h (increase_expout_size): Don't declare.
 104         * parse.c (increase_expout_size): Now static.
 105
 106 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
 107
 108         * gnu-nat.c (gnu_nat_target::wait): Fix
 109         target_waitstatus_to_string call.
 110
 111 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 112
 113         * eval.c (evaluate_subexp_standard): Handle internal functions
 114         during Fortran function call handling.
 115
 116 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 117
 118         * NEWS: Mention new internal functions.
 119         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
 120         (read_base_type): Use dwarf2_init_complex_target_type.
 121         * value.c (creal_internal_fn): New function.
 122         (cimag_internal_fn): New function.
 123         (_initialize_values): Register new internal functions.
 124
 125 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 126
 127         * infrun.c (stop_all_threads): If debug_infrun, always
 128         trace the wait status after wait_one, using
 129         target_waitstatus_to_string and target_pid_to_str.
 130         (handle_inferior_event): Replace various trace of
 131         wait status kind by a single trace.
 132         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
 133         wait status kind image by target_waitstatus_to_string.
 134         * target/waitstatus.c (target_waitstatus_to_string): Fix
 135         obsolete comment.
 136
 137 2019-04-01  Tom Tromey  <tromey@adacore.com>
 138
 139         PR symtab/23331:
 140         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
 141
 142 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 143             Pedro Alves  <palves@redhat.com>
 144
 145         * top.c (quit_force): Call 'finalize_values'.
 146         * value.c (finalize_values): New function.
 147         * value.h (finalize_values): Declare.
 148
 149 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 150
 151         * NEWS: Announce $_gdb_major and $_gdb_minor.
 152
 153         * top.c (init_gdb_version_vars): New function.
 154         (gdb_init): Call init_gdb_version_vars.
 155
 156 2019-03-29  Tom Tromey  <tromey@adacore.com>
 157
 158         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 159         help text.  Remove dead code.
 160
 161 2019-03-29  Keith Seitz  <keiths@redhat.com>
 162
 163         From Siddhesh Poyarekar:
 164         * f-lang.h (f77_get_upperbound): Return LONGEST.
 165         (f77_get_lowerbound): Likewise.
 166         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 167         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 168         print them.
 169         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 170         plongest to format print it.
 171         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 172         (f77_get_upperbound): Likewise.
 173         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 174         LOWER_BOUND to LONGEST.
 175         (f77_create_arrayprint_offset_tbl): Likewise.
 176
 177 2019-03-29  Keith Seitz  <keiths@redhat.com>
 178
 179         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 180         %s/pulongest for TYPE_LENGTH instead of %d in format
 181         strings.
 182         * ada-typerint.c (ada_print_type): Likewise.
 183         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 184         * compile/compile-c-support.c (generate_register_struct): Likewise.
 185         * gdbtypes.c (recursive_dump_type): Likewise.
 186         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 187         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 188         instead of %d in format strings.
 189         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 190         to std::min to ULONGEST.
 191         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 192         instead of %d in format strings.
 193         * tracepoint.c (info_scope_command): Likewise.
 194         * typeprint.c (print_offset_data::update)
 195         (print_offset_data::finish): Likewise.
 196         * xtensa-tdep.c (xtensa_store_return_value)
 197         (xtensa_push_dummy_call): Likewise.
 198
 199 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 200
 201         * windows-nat.c (display_selector): Fixed format specifications
 202         for 64-bit Cygwin.
 203
 204 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 205
 206         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 207
 208 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 209
 210         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 211         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 212         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 213         (nios2_linux_init_abi): Install it.
 214
 215 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 216
 217         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 218
 219 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 220
 221         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 222
 223 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 224             Tom Tromey  <tromey@adacore.com>
 225
 226         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 227
 228 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 229
 230         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 231         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 232         method to compute the bounds of range types. Also print "[evaluated]"
 233         if the bounds' values come from a dynamic evaluation.
 234
 235 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 236
 237         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 238         whitespace when pretty printing is on.
 239
 240 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 241
 242         * ppc-linux-nat.c: Add include.
 243
 244 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 245
 246         * NEWS: Mention AArch64 Pointer Authentication.
 247
 248 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 249
 250         * arm-linux-nat.c: Add include.
 251
 252 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 253
 254         * source-cache.c (source_cache::get_source_lines): Re-read
 255         fullname after calling open_source_file.
 256
 257 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 258
 259         * NEWS: Mention TLS support for FreeBSD.
 260
 261 2019-03-25  Tom Tromey  <tromey@adacore.com>
 262
 263         * minsyms.c (BUNCH_SIZE): Update comment.
 264         (~minimal_symbol_reader): Remove old comment.
 265         (compact_minimal_symbols): Update comment.
 266         (minimal_symbol_reader::install): Remove old comment.  Update
 267         other comments.
 268
 269 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 270
 271         * s390-linux-nat.c: Add include.
 272
 273 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 274
 275         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 276         Call linux_get_hwcap.
 277         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 278         Likewise.
 279         (aarch64_linux_get_hwcap): Remove function.
 280         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 281         declaration.
 282         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 283         linux_get_hwcap.
 284         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 285         * linux-tdep.c (linux_get_hwcap): Add function.
 286         (linux_get_hwcap2): Likewise.
 287         * linux-tdep.h (linux_get_hwcap): Add declaration.
 288         (linux_get_hwcap2): Likewise.
 289         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 290         (ppc_linux_get_hwcap2): Likewise.
 291         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 292         linux_get_hwcap.
 293         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 294         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 295         (ppc_linux_nat_target::read_description): Likewise.
 296         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 297         * s390-linux-nat.c: Likewise.
 298         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 299
 300 2019-03-24  Tom Tromey  <tom@tromey.com>
 301
 302         * ada-lang.c (standard_lookup): Simplify initialization.
 303         (ada_lookup_symbol_nonlocal): Simplify return.
 304         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 305         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 306         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 307         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 308         initialization.
 309         * solib.c (solib_global_lookup): Simplify.
 310         * symtab.c (null_block_symbol): Remove.
 311         (symbol_cache_lookup): Simplify returns.
 312         (lookup_language_this): Simplify returns.
 313         (lookup_symbol_aux): Simplify return.
 314         (lookup_local_symbol): Simplify returns.
 315         (lookup_global_symbol_from_objfile): Simplify return.
 316         (lookup_symbol_in_objfile_symtabs)
 317         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 318         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 319         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 320         * cp-namespace.c (cp_lookup_bare_symbol)
 321         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 322         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 323         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 324         (cp_lookup_symbol_via_imports): Simplify initialization.
 325         (find_symbol_in_baseclass): Likewise.
 326         * symtab.h (null_block_symbol): Remove.
 327         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 328         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 329         (d_lookup_symbol_module): Likewise.
 330         (find_symbol_in_baseclass): Simplify initialization.
 331
 332 2019-03-24  Tom Tromey  <tom@tromey.com>
 333
 334         * expression.h: Don't include symtab.h.
 335         (struct block): Forward declare.
 336
 337 2019-03-24  Tom Tromey  <tom@tromey.com>
 338
 339         * c-exp.y (typebase): Remove casts.
 340         * gdbtypes.c (lookup_unsigned_typename, )
 341         (lookup_signed_typename): Remove cast.
 342         * eval.c (parse_to_comma_and_eval): Remove cast.
 343         * parse.c (write_dollar_variable): Remove cast.
 344         * block.h (struct block) <superblock>: Now const.
 345         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 346         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 347         (map_block): Make "block" const.
 348         * symfile.h (struct quick_symbol_functions)
 349         <map_matching_symbols>: Constify block argument to "callback".
 350         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 351         const.
 352         (find_pc_sect_compunit_symtab): Make "b" const.
 353         (find_symbol_at_address): Likewise.
 354         (search_symbols): Likewise.
 355         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 356         (dw2_debug_names_lookup_symbol): Likewise.
 357         (dw2_map_matching_symbols): Update.
 358         * p-valprint.c (pascal_val_print): Remove "block".
 359         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 360         (aux_add_nonlocal_symbols): Make "block" const.
 361         (resolve_subexp): Remove cast.
 362         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 363         const.
 364         (iterate_over_file_blocks): Likewise.
 365         * f-exp.y (%union) <bval>: Remove.
 366         * coffread.c (patch_opaque_types): Make "b" const.
 367         * spu-tdep.c (spu_catch_start): Make "block" const.
 368         * c-valprint.c (print_unpacked_pointer): Remove "block".
 369         * symmisc.c (dump_symtab_1): Make "b" const.
 370         (block_depth): Make "block" const.
 371         * d-exp.y (%union) <bval>: Remove.
 372         * cp-support.h (cp_lookup_rtti_type): Update.
 373         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 374         * psymtab.c (psym_lookup_symbol): Make "block" const.
 375         (maintenance_check_psymtabs): Make "b" const.
 376         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 377         (enumerate_locals, enumerate_args): Update.
 378         * python/py-symtab.c (stpy_global_block): Make "block" const.
 379         (stpy_static_block): Likewise.
 380         * inline-frame.c (block_starting_point_at): Make "new_block"
 381         const.
 382         * block.c (find_block_in_blockvector): Make return type const.
 383         (blockvector_for_pc_sect): Make "b" const.
 384         (find_block_in_blockvector): Make "b" const.
 385
 386 2019-03-23  Tom Tromey  <tom@tromey.com>
 387
 388         * varobj.c (varobj_create): Update.
 389         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 390         * printcmd.c (display_command, do_one_display): Don't reset
 391         innermost_block.
 392         * parser-defs.h (enum innermost_block_tracker_type): Move to
 393         expression.h.
 394         (innermost_block): Update comment.
 395         * parse.c (parse_exp_1): Add tracker_types parameter.
 396         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 397         tracker_types parameter.  Reset innermost_block.
 398         (parse_exp_in_context): Remove.
 399         (parse_expression_for_completion): Update.
 400         * objfiles.c (~objfile): Don't reset expression_context_block or
 401         innermost_block.
 402         * expression.h (enum innermost_block_tracker_type): Move from
 403         parser-defs.h.
 404         (parse_exp_1): Add tracker_types parameter.
 405         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 406         reset innermost_block.
 407
 408 2019-03-23  Tom Tromey  <tom@tromey.com>
 409
 410         * objfiles.h: Include bcache.h.
 411
 412 2019-03-23  Tom Tromey  <tom@tromey.com>
 413
 414         * linespec.c (get_current_search_block): Use
 415         scoped_restore_current_language.
 416         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 417
 418 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 419             Jiong Wang  <jiong.wang@arm.com>
 420
 421         * aarch64-linux-tdep.c
 422         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 423         section.
 424         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 425
 426 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 427             Jiong Wang  <jiong.wang@arm.com>
 428
 429         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 430         instructions.
 431         (aarch64_analyze_prologue_test): Add PACIASP test.
 432         (aarch64_prologue_prev_register): Unmask PC value.
 433
 434 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 435             Jiong Wang  <jiong.wang@arm.com>
 436
 437         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 438         (aarch64_dwarf2_prev_register): Unmask PC value.
 439         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 440         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 441         DW_CFA_AARCH64_negate_ra_state.
 442         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 443
 444 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 445             Jiong Wang  <jiong.wang@arm.com>
 446
 447         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 448         registers.
 449         (aarch64_pseudo_register_name): Likewise.
 450         (aarch64_pseudo_register_type): Likewise.
 451         (aarch64_pseudo_register_reggroup_p): Likewise.
 452         (aarch64_gdbarch_init): Add pauth registers.
 453         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 454         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 455         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 456         (struct gdbarch_tdep): Add regnum for ra_state.
 457
 458 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 459             Jiong Wang  <jiong.wang@arm.com>
 460
 461         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 462
 463 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 464             Jiong Wang  <jiong.wang@arm.com>
 465
 466         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 467         function.
 468         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 469         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 470         (aarch64_gdbarch_init): Add puth registers.
 471         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 472         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 473         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 474
 475 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 476             Jiong Wang  <jiong.wang@arm.com>
 477
 478         * aarch64-linux-nat.c
 479         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 480         * aarch64-linux-tdep.c
 481         (aarch64_linux_core_read_description): Likewise.
 482         (aarch64_linux_get_hwcap): New function.
 483         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 484         (aarch64_linux_get_hwcap): New declaration.
 485
 486 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 487             Jiong Wang  <jiong.wang@arm.com>
 488
 489         * aarch64-linux-nat.c
 490         (aarch64_linux_nat_target::read_description): Add pauth param.
 491         * aarch64-linux-tdep.c
 492         (aarch64_linux_core_read_description): Likewise.
 493         * aarch64-tdep.c (struct target_desc): Add in pauth.
 494         (aarch64_read_description): Add pauth param.
 495         (aarch64_gdbarch_init): Likewise.
 496         * aarch64-tdep.h (aarch64_read_description): Likewise.
 497         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 498         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 499         * features/Makefile: Add new files.
 500         * features/aarch64-pauth.c: New file.
 501         * features/aarch64-pauth.xml: New file.
 502
 503 2019-03-20  Tom Tromey  <tromey@adacore.com>
 504
 505         * infrun.c (handle_inferior_event): Rename from
 506         handle_inferior_event_1.  Create a scoped_value_mark.
 507         (handle_inferior_event): Remove.
 508
 509 2019-03-19  Tom Tromey  <tromey@adacore.com>
 510
 511         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 512         * infrun.h (print_stop_event): Add "displays" parameter.
 513         * infrun.c (print_stop_event): Add "displays" parameter.
 514
 515 2019-03-19  Pedro Alves  <palves@redhat.com>
 516
 517         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 518         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 519         to -1.  Fix TABs vs spaces.
 520         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 521         * tui/tui-out.h (tui_ui_out) Add intro comments.
 522         <m_line, m_start_of_line>: In-class initialize, and add describing
 523         comment.
 524
 525 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 526
 527         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 528         variable names.
 529         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 530
 531 2019-03-18  Pedro Alves  <palves@redhat.com>
 532             Eli Zaretskii <eliz@gnu.org>
 533
 534         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 535         m_line and m_start_of_line.
 536
 537 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 538
 539         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 540         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 541         it returns a newline.  This fixes a regression in TU mode, whereby
 542         the next line is output on the same screen line as the user input.
 543
 544 2019-03-18  Tom Tromey  <tromey@adacore.com>
 545
 546         * minsyms.c (minimal_symbol_reader::install): Remove call to
 547         obstack_blank.
 548
 549 2019-03-18  Pedro Alves  <palves@redhat.com>
 550
 551         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 552         New globals.
 553         (apply_style): New, factored out from ...
 554         (apply_ansi_escape): ... this.  Handle reverse video mode.
 555         (tui_set_reverse_mode): New function.
 556         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 557         * tui/tui-winsource.c (tui_show_source_line): Use
 558         tui_set_reverse_mode instead of setting A_STANDOUT.
 559         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 560         New setter methods.
 561
 562 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 563
 564         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 565         Handle tabs.
 566
 567 2019-03-18  Tom Tromey  <tromey@adacore.com>
 568
 569         * ada-lang.c (empty_array): Add "high" parameter.
 570         (ada_evaluate_subexp): Update.
 571
 572 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 573
 574         * unittests/string_view-selftests.c: Define
 575         _initialize_string_view_selftests unconditionally.
 576
 577 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 578
 579         PR gdb/24350
 580         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 581
 582 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 583
 584         PR gdb/24351
 585         * windows-nat.c (display_selector): Fix format specifiers.
 586
 587 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 588
 589         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 590         tui_refill_source_window instead of tui_refresh_win, to update the
 591         current execution line.  This fixes redisplay of the current line
 592         when stepping through the code with "next" or "step".
 593
 594 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 595
 596         * source-cache.c (source_cache::get_source_lines): Call
 597         find_source_lines to initialize s->nlines.  This fixes vertical
 598         scrolling of TUI source window when the DOWN arrow is pressed.
 599
 600 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 601
 602         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 603         linux-thread-db.c (_initialize_thread_db): Likewise.
 604
 605 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 606
 607         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 608         wclrtoeol in tui_show_source_line".  This reverts changes made in
 609         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 610
 611 2019-03-15  Tom Tromey  <tom@tromey.com>
 612
 613         * symtab.h (struct minimal_symbol): Derive from
 614         general_symbol_info.
 615         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 616         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 617         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 618         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 619         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 620         (MSYMBOL_SEARCH_NAME): Update.
 621         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 622         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 623         * minsyms.c (minimal_symbol_reader::record_full): Update.
 624
 625 2019-03-15  Tom Tromey  <tom@tromey.com>
 626
 627         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 628
 629 2019-03-15  Tom Tromey  <tom@tromey.com>
 630
 631         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 632         unique_xmalloc_ptr.
 633         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 634         Update.
 635         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 636         (build_minimal_symbol_hash_tables)
 637         (minimal_symbol_reader::install): Update.
 638
 639 2019-03-15  Tom Tromey  <tom@tromey.com>
 640
 641         * symtab.c (create_demangled_names_hash): Update.
 642         (symbol_set_names): Update.
 643         * objfiles.h (struct objfile_per_bfd_storage)
 644         <demangled_names_hash>: Now an htab_up.
 645         * objfiles.c (objfile_per_bfd_storage): Simplify.
 646
 647 2019-03-15  Tom Tromey  <tom@tromey.com>
 648
 649         * objfiles.h (struct objfile_per_bfd_storage): Declare
 650         destructor.
 651         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 652         New.
 653         (get_objfile_bfd_data): Use new.  Don't initialize
 654         language_of_main.
 655         (free_objfile_per_bfd_storage): Remove.
 656         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 657
 658 2019-03-15  Tom Tromey  <tom@tromey.com>
 659
 660         * symfile.c (reread_symbols): Update.
 661         * objfiles.c (objfile::objfile): Update.
 662         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 663         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 664         comment.
 665         (minimal_symbol_reader::install): Update.
 666         (terminate_minimal_symbol_table): Remove.
 667         * jit.c (jit_object_close_impl): Update.
 668
 669 2019-03-15  Tom Tromey  <tom@tromey.com>
 670
 671         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 672         initializations.
 673
 674 2019-03-15  Tom Tromey  <tom@tromey.com>
 675
 676         * objfiles.h (struct objfile_per_bfd_storage)
 677         <demangled_hash_languages>: Now a bitset.
 678         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 679         (lookup_minimal_symbol): Update.
 680
 681 2019-03-15  Tom Tromey  <tom@tromey.com>
 682
 683         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 684         Don't return the symbol.
 685         * coffread.c (record_minimal_symbol): Use record_full.
 686
 687 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 688
 689         The MS-Windows port of ncurses fails to switch to a color pair if
 690         one or both of the colors are the implicit default colors.  This
 691         change records the default colors when TUI is initialized, and
 692         then specifies them explicitly when a color pair uses the default
 693         colors.  This allows color styling in TUI mode on MS-Windows.
 694
 695         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 696         ncurses_norm_attr.
 697         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 698         colors in ncurses_norm_attr.
 699         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 700         "none", replace it with the default color recorded in
 701         ncurses_norm_attr.
 702
 703 2019-03-14  Tom Tromey  <tromey@adacore.com>
 704
 705         * source-cache.h (class source_cache) <get_source_lines>: Return
 706         std::string.
 707         * source-cache.c (source_cache::extract_lines): Handle case where
 708         first_pos==npos.  Return std::string.
 709         (source_cache::get_source_lines): Update.
 710
 711 2019-03-14  Tom Tromey  <tromey@adacore.com>
 712
 713         * NEWS: Add item for "style sources" commands.
 714         * source-cache.c (source_cache::get_source_lines): Check
 715         source_styling.
 716         * cli/cli-style.c (source_styling): New global.
 717         (_initialize_cli_style): Add "style sources" commands.
 718         (show_style_sources): New function.
 719         * cli/cli-style.h (source_styling): Declare.
 720
 721 2019-03-14  Pedro Alves  <palves@redhat.com>
 722             Tom Tromey  <tromey@adacore.com>
 723
 724         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 725         * tui/tui-winsource.c (tui_refill_source_window): New function,
 726         from...
 727         (tui_horizontal_source_scroll): ... here.  Move some logic.
 728         * cli/cli-style.c (set_style_enabled): Notify new observable.
 729         * tui/tui-hooks.c (tui_redisplay_source): New function.
 730         (tui_attach_detach_observers): Attach or detach
 731         tui_redisplay_source.
 732         * observable.h (source_styling_changed): New observable.
 733         * observable.c: Define source_styling_changed observable.
 734
 735 2019-03-13  Tom Tromey  <tromey@adacore.com>
 736
 737         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 738         (i386_gnu_nat_target::store_registers): Update.
 739         * target-debug.h (target_debug_print_std_string): New macro.
 740         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 741         * windows-tdep.c (display_one_tib): Update.
 742         * tui/tui-stack.c (tui_make_status_line): Update.
 743         * top.c (print_inferior_quit_action): Update.
 744         * thread.c (thr_try_catch_cmd): Update.
 745         (add_thread_with_info): Update.
 746         (thread_target_id_str): Update.
 747         (thr_try_catch_cmd): Update.
 748         (thread_command): Update.
 749         (thread_find_command): Update.
 750         * record-btrace.c (record_btrace_target::info_record)
 751         (record_btrace_resume_thread, record_btrace_target::resume)
 752         (record_btrace_cancel_resume, record_btrace_step_thread)
 753         (record_btrace_target::wait, record_btrace_target::wait)
 754         (record_btrace_target::wait, record_btrace_target::stop): Update.
 755         * progspace.c (print_program_space): Update.
 756         * process-stratum-target.c
 757         (process_stratum_target::thread_address_space): Update.
 758         * linux-fork.c (linux_fork_mourn_inferior)
 759         (detach_checkpoint_command, info_checkpoints_command)
 760         (linux_fork_context): Update.
 761         (linux_fork_detach): Update.
 762         (class scoped_switch_fork_info): Update.
 763         (delete_checkpoint_command): Update.
 764         * infrun.c (follow_fork_inferior): Update.
 765         (follow_fork_inferior): Update.
 766         (proceed_after_vfork_done): Update.
 767         (handle_vfork_child_exec_or_exit): Update.
 768         (follow_exec): Update.
 769         (displaced_step_prepare_throw): Update.
 770         (displaced_step_restore): Update.
 771         (start_step_over): Update.
 772         (resume_1): Update.
 773         (clear_proceed_status_thread): Update.
 774         (proceed): Update.
 775         (print_target_wait_results): Update.
 776         (do_target_wait): Update.
 777         (context_switch): Update.
 778         (stop_all_threads): Update.
 779         (restart_threads): Update.
 780         (finish_step_over): Update.
 781         (handle_signal_stop): Update.
 782         (switch_back_to_stepped_thread): Update.
 783         (keep_going_pass_signal): Update.
 784         (print_exited_reason): Update.
 785         (normal_stop): Update.
 786         * inferior.c (inferior_pid_to_str): Change return type.
 787         (print_selected_inferior): Update.
 788         (add_inferior): Update.
 789         (detach_inferior): Update.
 790         * dummy-frame.c (fprint_dummy_frames): Update.
 791         * dcache.c (dcache_info_1): Update.
 792         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 793         (btrace_fetch, btrace_clear): Update.
 794         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 795         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 796         type.
 797         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 798         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 799         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 800         * gdbarch.c, gdbarch.h: Rebuild.
 801         * gdbarch.sh (core_pid_to_str): Change return type.
 802         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 803         return type.
 804         (windows_nat_target::pid_to_str): Change return type.
 805         (windows_delete_thread): Update.
 806         (windows_nat_target::attach): Update.
 807         (windows_nat_target::files_info): Update.
 808         * target-delegates.c: Rebuild.
 809         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 810         return type.
 811         (sol_thread_target::pid_to_str): Change return type.
 812         * remote.c (class remote_target) <pid_to_str>: Change return
 813         type.
 814         (remote_target::pid_to_str): Change return type.
 815         (extended_remote_target::attach, remote_target::remote_stop_ns)
 816         (remote_target::remote_notif_remove_queued_reply)
 817         (remote_target::push_stop_reply, remote_target::disable_btrace):
 818         Update.
 819         (extended_remote_target::attach): Update.
 820         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 821         type.
 822         (gdbsim_target::pid_to_str): Change return type.
 823         * ravenscar-thread.c (struct ravenscar_thread_target)
 824         <pid_to_str>: Change return type.
 825         (ravenscar_thread_target::pid_to_str): Change return type.
 826         * procfs.c (class procfs_target) <pid_to_str>: Change return
 827         type.
 828         (procfs_target::pid_to_str): Change return type.
 829         (procfs_target::attach): Update.
 830         (procfs_target::detach): Update.
 831         (procfs_target::fetch_registers): Update.
 832         (procfs_target::store_registers): Update.
 833         (procfs_target::wait): Update.
 834         (procfs_target::files_info): Update.
 835         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 836         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 837         return type.
 838         (nto_procfs_target::pid_to_str): Change return type.
 839         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 840         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 841         return type.
 842         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 843         (exit_lwp): Update.
 844         (attach_proc_task_lwp_callback, get_detach_signal)
 845         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 846         (linux_nat_target::resume, wait_lwp, stop_callback)
 847         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 848         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 849         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 850         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 851         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 852         type.
 853         (inf_ptrace_target::attach): Update.
 854         (inf_ptrace_target::files_info): Update.
 855         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 856         type.
 857         (go32_nat_target::pid_to_str): Change return type.
 858         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 859         (gnu_nat_target::wait): Update.
 860         (gnu_nat_target::wait): Update.
 861         (gnu_nat_target::resume): Update.
 862         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 863         (fbsd_nat_target::wait): Update.
 864         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 865         type.
 866         (darwin_nat_target::attach): Update.
 867         * corelow.c (class core_target) <pid_to_str>: Change return type.
 868         (core_target::pid_to_str): Change return type.
 869         * target.c (normal_pid_to_str): Change return type.
 870         (default_pid_to_str): Likewise.
 871         (target_pid_to_str): Change return type.
 872         (target_translate_tls_address): Update.
 873         (target_announce_detach): Update.
 874         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 875         return type.
 876         (bsd_uthread_target::pid_to_str): Change return type.
 877         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 878         type.
 879         (bsd_kvm_target::pid_to_str): Change return type.
 880         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 881         return type.
 882         (aix_thread_target::pid_to_str): Change return type.
 883         * target.h (struct target_ops) <pid_to_str>: Change return type.
 884         (target_pid_to_str, normal_pid_to_str): Likewise.
 885         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 886         type.
 887         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 888         type.
 889         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 890         return type.
 891         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 892         type.
 893         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 894         type.
 895         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 896         return type.
 897
 898 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 899
 900         * NEWS: Mention that the new default MI version is 3.  Mention
 901         changes to the output of commands and events that deal with
 902         multi-location breakpoints.
 903         * breakpoint.c: Include "mi/mi-out.h".
 904         (print_one_breakpoint): Change output syntax if using MI version
 905         >= 3.
 906         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 907         New.
 908         (mi_multi_location_breakpoint_output_fixed): New.
 909         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 910         (mi_cmd_fix_multi_location_breakpoint_output): New.
 911         (mi_multi_location_breakpoint_output_fixed): New.
 912         * mi/mi-cmds.c (mi_cmds): Register command
 913         -fix-multi-location-breakpoint-output.
 914         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 915         interpreter "mi".
 916
 917 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 918
 919         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 920         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 921         instantiate mi_ui_out based on interpreter name.
 922         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 923         * mi/mi-main.c (mi_load_progress): Likewise.
 924
 925 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 926
 927         * NEWS: Combine separate "New targets" sections for 8.3.
 928
 929 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 930
 931         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 932         (ppcfbsd_init_abi): Install gdbarch
 933         "fetch_tls_load_module_address" and "get_thread_local_address"
 934         methods.
 935
 936 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 937
 938         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 939         (riscv_fbsd_init_abi): Install gdbarch
 940         "fetch_tls_load_module_address" and "get_thread_local_address"
 941         methods.
 942
 943 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 944
 945         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 946         (i386fbsd_init_abi): Install gdbarch
 947         "fetch_tls_load_module_address" and "get_thread_local_address"
 948         methods.
 949
 950 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 951
 952         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 953         (amd64fbsd_init_abi): Install gdbarch
 954         "fetch_tls_load_module_address" and "get_thread_local_address"
 955         methods.
 956
 957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 958
 959         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 960         (struct fbsd_pspace_data): New type.
 961         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 962         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 963         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 964         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 965         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 966
 967 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 968
 969         * gdbtypes.c (lookup_struct_elt): New function.
 970         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 971         * gdbtypes.h (struct struct_elt): New type.
 972         (lookup_struct_elt): New prototype.
 973
 974 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 975
 976         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 977         remove disabled code block.
 978
 979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 980
 981         * gdbarch.sh (get_thread_local_address): New method.
 982         * gdbarch.h, gdbarch.c: Regenerate.
 983         * target.c (target_translate_tls_address): Use
 984         gdbarch_get_thread_local_address if present instead of
 985         target::get_thread_local_address.
 986
 987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 988
 989         * target.h (target::get_thread_local_address): Update comment.
 990
 991 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 992
 993         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 994         objfile->separate_debug_objfile_backlink if not NULL.
 995
 996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 997
 998         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 999         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1000         (amd64bsd_store_inferior_registers): Likewise.
1001         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1002         Enable segment base registers.
1003         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1004         PT_GETFSBASE and PT_GETGSBASE.
1005         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1006         PT_SETGSBASE.
1007         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1008         segment base registers.
1009         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1010
1011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1012
1013         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1014         Update calls to i386_target_description to add 'segments'
1015         parameter.
1016         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1017         add segment base registers.
1018         * arch/i386.c (i386_create_target_description): Add 'segments'
1019         parameter to enable segment base registers.
1020         * arch/i386.h (i386_create_target_description): Likewise.
1021         * features/i386/32bit-segments.xml: New file.
1022         * features/i386/32bit-segments.c: Generate.
1023         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1024         call to i386_target_description to add 'segments' parameter.
1025         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1026         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1027         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1028         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1029         if feature is present.
1030         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1031         Add 'segments' parameter to call to i386_target_description.
1032         (i386_target_description): Add 'segments' parameter to enable
1033         segment base registers.
1034         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1035         to call to i386_target_description.
1036         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1037         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1038         Define I386_NUM_REGS.
1039         (i386_target_description): Add 'segments' parameter to enable
1040         segment base registers.
1041
1042 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1043
1044         PR/24325
1045         * source-cache.c: #undef open and close, to avoid unresolved
1046         externals during linking.
1047
1048 2019-03-12  Tom Tromey  <tromey@adacore.com>
1049
1050         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1051         const.  Add initializers.
1052         (_initialize_remote): Don't initialize ptid globals.
1053
1054 2019-03-12  Pedro Alves  <palves@redhat.com>
1055
1056         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1057
1058 2019-03-12  Pedro Alves  <palves@redhat.com>
1059
1060         * cp-name-parser.y (main): Remove unused 'len' variable.
1061
1062 2019-03-12  Tom Tromey  <tromey@adacore.com>
1063
1064         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1065         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1066
1067 2019-03-12  Tom Tromey  <tromey@adacore.com>
1068
1069         * linux-nat.c (iterate_over_lwps): Update.
1070         (stop_callback): Remove parameter.
1071         (stop_wait_callback, detach_callback, resume_set_callback)
1072         (select_singlestep_lwp_callback, set_ignore_sigint)
1073         (status_callback, resumed_callback, resume_clear_callback)
1074         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1075         data parameter.
1076         (linux_nat_target::detach, linux_nat_target::resume)
1077         (linux_stop_and_wait_all_lwps, select_event_lwp)
1078         (linux_nat_filter_event, linux_nat_wait_1)
1079         (linux_nat_target::kill, linux_nat_target::stop)
1080         (linux_nat_target::stop): Update.
1081         (linux_nat_resume_callback): Change type.
1082         (resume_stopped_resumed_lwps, count_events_callback)
1083         (select_event_lwp_callback): Likewise.
1084         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1085         * arm-linux-nat.c (struct update_registers_data): Remove.
1086         (update_registers_callback): Change type.
1087         (arm_linux_insert_hw_breakpoint1): Update.
1088         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1089         parameter.
1090         (x86_linux_dr_set_addr): Update.
1091         (x86_linux_dr_set_control): Update.
1092         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1093         (iterate_over_lwps): Use gdb::function_view.
1094         * nat/aarch64-linux-hw-point.c (struct
1095         aarch64_dr_update_callback_param): Remove.
1096         (debug_reg_change_callback): Change type.
1097         (aarch64_notify_debug_reg_change): Update.
1098         * s390-linux-nat.c (s390_refresh_per_info): Update.
1099
1100 2019-03-11  Tom Tromey  <tromey@adacore.com>
1101
1102         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1103         redundant assignment to "this_cu".
1104
1105 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1106
1107         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1108
1109 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1110
1111         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1112         from...
1113         (rank_one_type): ... this.
1114
1115 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1116
1117         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1118         from...
1119         (rank_one_type): ... this.
1120
1121 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1122
1123         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1124         from...
1125         (rank_one_type): ... this.
1126
1127 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1128
1129         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1130         from...
1131         (rank_one_type): ... this.
1132
1133 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1134
1135         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1136         from...
1137         (rank_one_type): ... this.
1138
1139 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1140
1141         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1142         from...
1143         (rank_one_type): ... this.
1144
1145 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1146
1147         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1148         from...
1149         (rank_one_type): ... this.
1150
1151 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1152
1153         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1154         from...
1155         (rank_one_type): ... this.
1156
1157 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1158
1159         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1160         from...
1161         (rank_one_type): ... this.
1162
1163 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1164
1165         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1166         from...
1167         (rank_one_type): ... this.
1168
1169 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1170
1171         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1172         from...
1173         (rank_one_type): ... this.
1174
1175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1176
1177         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1178         from...
1179         (rank_one_type): ... this.
1180
1181 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1182
1183         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1184         inferior-events' shows the example events.
1185
1186 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1187
1188         Support styling on native MS-Windows console
1189
1190         PR/24315
1191         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1192         on MS-Windows if $TERM is not defined.
1193
1194         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1195
1196         * posix-hdep.c (gdb_console_fputs):
1197         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1198         functions.
1199         * ui-file.h (gdb_console_fputs): Add prototype.
1200
1201         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1202         back to fputs only if the former returns zero.
1203
1204 2019-03-07  Tom Tromey  <tom@tromey.com>
1205
1206         * symmisc.c (print_symbol_bcache_statistics): Update.
1207         (print_objfile_statistics): Update.
1208         * symfile.c (allocate_symtab): Update.
1209         * stabsread.c: Don't include bcache.h.
1210         * psymtab.h (struct psymbol_bcache): Don't declare.
1211         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1212         (psymbol_bcache_init, psymbol_bcache_free)
1213         (psymbol_bcache_get_bcache): Don't declare.
1214         * psymtab.c (struct psymbol_bcache): Remove.
1215         (psymtab_storage::psymtab_storage): Update.
1216         (psymtab_storage::~psymtab_storage): Update.
1217         (psymbol_bcache_init, psymbol_bcache_free)
1218         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1219         (add_psymbol_to_bcache): Update.
1220         (allocate_psymtab): Update.
1221         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1222         macro_cache>: No longer pointers.
1223         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1224         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1225         * macrotab.c (macro_bcache): Update.
1226         * macroexp.c: Don't include bcache.h.
1227         * gdbtypes.c (check_types_worklist): Update.
1228         (types_deeply_equal): Remove TRY/CATCH.  Update.
1229         * elfread.c (elf_symtab_read): Update.
1230         * dwarf2read.c: Don't include bcache.h.
1231         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1232         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1233         (print_bcache_statistics, bcache_memory_used): Don't declare.
1234         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1235         methods.  Rename all data members.
1236         * bcache.c (struct bcache): Move to bcache.h.
1237         (bcache::expand_hash_table): Rename from expand_hash_table.
1238         (bcache): Remove.
1239         (bcache::insert): Rename from bcache_full.
1240         (bcache::compare): Rename from bcache_compare.
1241         (bcache_xmalloc): Remove.
1242         (bcache::~bcache): Rename from bcache_xfree.
1243         (bcache::print_statistics): Rename from print_bcache_statistics.
1244         (bcache::memory_used): Rename from bcache_memory_used.
1245
1246 2019-03-07  Pedro Alves  <palves@redhat.com>
1247
1248         * infrun.c (normal_stop): Also check for
1249         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1250
1251 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1252
1253         * f-lang.c (value_from_host_double): Moved to...
1254         * value.c (value_from_host_double): ...here.
1255         * value.h (value_from_host_double): Declare.
1256         * guile/scm-math.c (vlscm_convert_typed_number): Use
1257         value_from_host_double.
1258         (vlscm_convert_number): Likewise.
1259         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1260         * python/py-value.c (convert_value_from_python): Likewise.
1261
1262 2019-03-06  Tom Tromey  <tom@tromey.com>
1263
1264         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1265
1266 2019-03-06  Tom Tromey  <tom@tromey.com>
1267
1268         * utils.h (free_current_contents): Don't declare.
1269         * utils.c (free_current_contents): Remove.
1270
1271 2019-03-06  Tom Tromey  <tom@tromey.com>
1272
1273         * top.c (quit_force): Update.
1274         * main.c (captured_command_loop): Update.
1275         * common/new-op.c (operator new): Update.
1276         * common/common-exceptions.c (struct catcher)
1277         <save_cleanup_chain>: Remove member.
1278         (exceptions_state_mc_init): Update.
1279         (exception_try_scope_entry): Return nullptr.
1280         (exception_try_scope_exit, exception_rethrow)
1281         (throw_exception_sjlj, throw_exception_cxx): Update.
1282         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1283         (all_cleanups, do_cleanups, discard_cleanups)
1284         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1285         (restore_cleanups, restore_final_cleanups): Don't declare.
1286         (do_final_cleanups): Remove parameter.
1287         * common/cleanups.c (cleanup_chain, make_cleanup)
1288         (make_cleanup_dtor, all_cleanups, do_cleanups)
1289         (discard_my_cleanups, discard_cleanups)
1290         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1291         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1292         (null_cleanup): Remove.
1293         (do_final_cleanups): Remove parameter.
1294
1295 2019-03-06  Tom Tromey  <tom@tromey.com>
1296
1297         * remote.c (remote_target::remote_parse_stop_reply): Use
1298         unique_xmalloc_ptr.
1299
1300 2019-03-06  Tom Tromey  <tom@tromey.com>
1301
1302         * stabsread.c (struct stabs_field_info): Rename from field_info.
1303         <list, fnlist>: Add initializers.
1304         <obstack>: New member.
1305         (read_member_functions, read_struct_fields, read_baseclasses):
1306         Allocate on obstack.  Don't use cleanups.
1307         (read_one_struct_field, read_member_functions, read_struct_fields)
1308         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1309         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1310         (read_struct_type): Update.
1311
1312 2019-03-06  Tom Tromey  <tom@tromey.com>
1313
1314         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1315         * common/filestuff.h (make_cleanup_close): Don't declare.
1316         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1317         Remove.
1318
1319 2019-03-06  Tom Tromey  <tom@tromey.com>
1320
1321         * solib-aix.c: Use make_scope_exit.
1322
1323 2019-03-06  Tom Tromey  <tom@tromey.com>
1324
1325         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1326         Use make_scope_exit.
1327
1328 2019-03-06  Tom Tromey  <tom@tromey.com>
1329
1330         * solib-svr4.c (disable_probes_interface): Remove parameter.
1331         (svr4_handle_solib_event): Use make_scope_exit.
1332
1333 2019-03-06  Tom Tromey  <tom@tromey.com>
1334
1335         * remote.c (struct stop_reply_deleter): Remove.
1336         (stop_reply_up): Update.
1337         (struct stop_reply): Derive from notif_event.  Don't typedef.
1338         <regcache>: Now a std::vector.
1339         (stop_reply_xfree): Remove.
1340         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1341         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1342         (remote_target::discard_pending_stop_replies): Use delete.
1343         (remote_target::remote_parse_stop_reply): Update.
1344         (remote_target::process_stop_reply): Update.
1345         * remote-notif.h (struct notif_event): Add virtual destructor.
1346         Remove "dtr" member.
1347         (struct notif_client) <alloc_event>: Return a unique_ptr.
1348         (notif_event_xfree): Don't declare.
1349         (notif_event_up): New typedef.
1350         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1351         (notif_event_xfree, do_notif_event_xfree): Remove.
1352         (remote_notif_state_xfree): Update.
1353
1354 2019-03-06  Tom Tromey  <tom@tromey.com>
1355
1356         * infrun.c (displaced_step_clear_cleanup): Now a
1357         forward_scope_exit type.
1358         (displaced_step_prepare_throw): Update.
1359         (displaced_step_fixup): Update.
1360
1361 2019-03-06  Tom Tromey  <tom@tromey.com>
1362
1363         * inferior.h (class inferior): Update comment.
1364         * gdbthread.h (class thread_info): Update comment.
1365
1366 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1367             Tom Tromey  <tom@tromey.com>
1368
1369         * stabsread.h (struct stab_section_list): Remove.
1370         (coffstab_build_psymtabs): Update.
1371         * dbxread.c (symbuf_sections): Now a std::vector.
1372         (sect_idx): New global.
1373         (fill_symbuf): Update.
1374         (coffstab_build_psymtabs): Change type of stabsects parameter.
1375         Update.
1376         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1377         std::vector.
1378         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1379         (coff_locate_sections): Update.
1380         (coff_symfile_read): Remove cleanups.  Update.
1381         (init_stringtab): Add storage parameter.
1382         (free_stringtab, free_stringtab_cleanup): Remove.
1383         (init_lineno): Add storage parameter.
1384         (free_linetab, free_linetab_cleanup): Remove.
1385
1386 2019-03-06  Pedro Alves  <palves@redhat.com>
1387
1388         * linux-fork.c (fork_info::clobber_regs): Delete.
1389         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1390         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1391         comment.  Adjust.
1392         (scoped_switch_fork_info::scoped_switch_fork_info)
1393         (checkpoint_command, linux_fork_context): Adjust
1394         fork_save_infrun_state calls.
1395
1396 2019-03-06  Pedro Alves  <palves@redhat.com>
1397
1398         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1399         (inf_has_multiple_threads): Return 'bool' and rewrite using
1400         inferior_info::threads().
1401
1402 2019-03-06  Pedro Alves  <palves@redhat.com>
1403
1404         * linux-fork.c: Include <list>.
1405         (fork_list): Now a std::list instance.
1406         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1407         (forks_exist_p, find_last_fork): Adjust.
1408         (new_fork): Delete.
1409         (one_fork_p): New.
1410         (add_fork): Adjust.
1411         (free_fork): Delete, folded into fork_info::~fork_info().
1412         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1413         Adjust.
1414         (init_fork_list): Delete.
1415         (linux_fork_killall, linux_fork_mourn_inferior)
1416         (linux_fork_detach, info_checkpoints_command): Adjust.
1417         (_initialize_linux_fork): No longer call init_fork_list.
1418
1419 2019-03-06  Pedro Alves  <palves@redhat.com>
1420
1421         * linux-fork.c (new_fork): New, split out of ...
1422         (add_fork): ... this.  Return void.  Move "first fork" special
1423         case from here, to ...
1424         (checkpoint_command): ... here.
1425         * linux-linux.h (add_fork): Return void.
1426
1427 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1428
1429         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1430
1431 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1432             Chris January  <chris.january@arm.com>
1433             David Lecomber  <david.lecomber@arm.com>
1434
1435         * f-exp.y: New token, UNOP_INTRINSIC.
1436         (exp): New pattern using UNOP_INTRINSIC token.
1437         (f77_keywords): Add 'abs' keyword.
1438         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1439         (value_from_host_double): New function.
1440         (evaluate_subexp_f): Support UNOP_ABS.
1441
1442 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1443
1444         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1445         types.
1446
1447 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1448
1449         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1450         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1451         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1452
1453 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1454
1455         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1456
1457 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1458             Chris January  <chris.january@arm.com>
1459
1460         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1461         * f-exp.y: Define 'KIND' token.
1462         (exp): New pattern for KIND expressions.
1463         (ptype): Handle types with a kind extension.
1464         (direct_abs_decl): Extend to spot kind extensions.
1465         (f77_keywords): Add 'kind' to the list.
1466         (push_kind_type): New function.
1467         (convert_to_kind_type): New function.
1468         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1469         * parse.c (operator_length_standard): Likewise.
1470         * parser-defs.h (enum type_pieces): Add tp_kind.
1471         * std-operator.def: Add UNOP_KIND.
1472
1473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1474
1475         * f-exp.y (f_parse): Set yydebug.
1476
1477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1478
1479         * f-lang.c (evaluate_subexp_f): New function.
1480         (exp_descriptor_f): New global.
1481         (f_language_defn): Use exp_descriptor_f instead of
1482         exp_descriptor_standard.
1483
1484 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1485
1486         * f-exp.y (struct token): Add comments.
1487         (dot_ops): Remove uppercase versions and the end marker.
1488         (f77_keywords): Likewise.
1489         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1490         entries in the dot_ops array are case insensitive, and use
1491         strncasecmp to compare strings.  Also some whitespace cleanup in
1492         this area.  Similar for the f77_keywords array, except entries in
1493         this list might be case sensitive.
1494
1495 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1496
1497         * f-exp.y (struct f77_boolean_val): Add comments.
1498         (boolean_values): Remove uppercase versions, and end marker.
1499         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1500         and use strncasecmp to achieve case insensitivity.  Additionally,
1501         perform whitespace cleanup around this code.
1502
1503 2019-03-06  Tom Tromey  <tromey@adacore.com>
1504
1505         * remote-sim.c (gdbsim_target_open): Use result of
1506         gdb_argv::release.
1507
1508 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1509         Dirk Schubert  <dirk.schubert@arm.com>
1510         Chris January  <chris.january@arm.com>
1511
1512         * eval.c (evaluate_subexp_standard): Call Fortran argument
1513         wrapping logic.
1514         * f-lang.c (struct value): A value which can be passed into a
1515         Fortran function call.
1516         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1517         where appropriate.
1518         (struct type): Value ready for a Fortran function call.
1519         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1520         is needed.
1521         * f-lang.h (fortran_argument_convert): Declaration.
1522         (fortran_preserve_arg_pointer): Declaration.
1523         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1524
1525 2019-03-05  Tom Tromey  <tromey@adacore.com>
1526
1527         * python/py-prettyprint.c (print_string_repr): Remove #if.
1528         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1529
1530 2019-03-05  Tom Tromey  <tromey@adacore.com>
1531
1532         * target.c (the_dummy_target): Move later.  Change type to
1533         "dummy_target".
1534         (initialize_targets): Don't initialize the_dummy_target.
1535
1536 2019-03-05  Tom Tromey  <tromey@adacore.com>
1537
1538         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1539         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1540
1541 2019-03-05  Tom Tromey  <tromey@adacore.com>
1542
1543         * windows-nat.c (windows_nat_target::attach)
1544         (windows_nat_target::detach): Don't call gdb_flush.
1545         * valprint.c (generic_val_print, val_print, val_print_string):
1546         Don't call gdb_flush.
1547         * utils.c (defaulted_query): Don't call gdb_flush.
1548         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1549         * target.c (target_announce_detach): Don't call gdb_flush.
1550         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1551         * remote.c (extended_remote_target::attach): Don't call
1552         gdb_flush.
1553         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1554         * printcmd.c (do_examine): Don't call gdb_flush.
1555         (info_display_command): Don't call gdb_flush.
1556         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1557         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1558         * memattr.c (info_mem_command): Don't call gdb_flush.
1559         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1560         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1561         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1562         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1563         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1564         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1565         (gnu_nat_target::detach): Don't call gdb_flush.
1566         * f-valprint.c (f_val_print): Don't call gdb_flush.
1567         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1568         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1569         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1570         gdb_flush.
1571         * c-valprint.c (c_val_print): Don't call gdb_flush.
1572         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1573
1574 2019-03-05  Tom Tromey  <tromey@adacore.com>
1575
1576         * varobj.c (update_dynamic_varobj_children): Update.
1577         (install_default_visualizer): Use reset, not release.
1578         * value.c (set_internalvar): Update.
1579         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1580         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1581         ATTRIBUTE_UNUSED_RESULT.
1582
1583 2019-03-05  Tom Tromey  <tromey@adacore.com>
1584
1585         * remote.c (class scoped_remote_fd) <release>: Add
1586         ATTRIBUTE_UNUSED_RESULT.
1587
1588 2019-03-05  Tom Tromey  <tromey@adacore.com>
1589
1590         * macroexp.c (struct macro_buffer) <release>: Add
1591         ATTRIBUTE_UNUSED_RESULT.
1592
1593 2019-03-05  Tom Tromey  <tromey@adacore.com>
1594
1595         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1596         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1597         ATTRIBUTE_UNUSED_RESULT.
1598
1599 2019-03-05  Tom Tromey  <tromey@adacore.com>
1600
1601         * common/scoped_fd.h (class scoped_fd) <release>: Add
1602         ATTRIBUTE_UNUSED_RESULT.
1603
1604 2019-03-05  Tom Tromey  <tromey@adacore.com>
1605
1606         * parser-defs.h (struct parser_state) <release>: Add
1607         ATTRIBUTE_UNUSED_RESULT.
1608
1609 2019-03-05  Tom Tromey  <tromey@adacore.com>
1610
1611         * utils.h (class gdb_argv) <release>: Add
1612         ATTRIBUTE_UNUSED_RESULT.
1613         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1614
1615 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1616
1617         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1618         for-loop range, to avoid compiler warnings.
1619
1620         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1621         avoid compiler warnings about unused variables.
1622
1623         * NEWS: Mention end of support for native debugging on MS-Windows
1624         before XP.
1625
1626         PR gdb/24292
1627         * common/netstuff.c:
1628         * gdbserver/gdbreplay.c
1629         * gdbserver/remote-utils.c:
1630         * ser-tcp.c:
1631         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1632         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1633         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1634         'getaddrinfo' and 'freeaddrinfo' were not available before
1635         Windows XP, and mingw.org's MinGW headers by default define
1636         _WIN32_WINNT to 0x500.
1637
1638 2019-03-01  Gary Benson <gbenson@redhat.com>
1639
1640         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1641
1642 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1643             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1644
1645         PR gdb/8527
1646         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1647         set_sigint_trap, clear_sigint_trap.
1648
1649 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1650
1651         * target.c (target_detach): Clear the regcache and the
1652         frame cache.
1653
1654 2019-02-27  Pedro Alves  <palves@redhat.com>
1655
1656         * utils.c (set_screen_size): When we cap the height/width sizes,
1657         tweak the corresponding command variable to show "unlimited":
1658
1659 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1660             Pedro Alves  <palves@redhat.com>
1661
1662         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1663         before calling rl_set_screen_size.
1664
1665 2019-02-27  Tom Tromey  <tromey@adacore.com>
1666
1667         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1668         define.
1669         * python/py-value.c: Remove Python 2.4 workaround.
1670         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1671         workaround.
1672         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1673         Python 2.4 workaround.
1674         * python/python-internal.h: Remove Python 2.4 comment.
1675         (Py_ssize_t): Don't define.
1676         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1677         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1678         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1679         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1680         * python/python.c (do_start_initialization): Remove Python 2.4
1681         workaround.
1682         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1683         (print_children): Remove Python 2.4 workaround.
1684         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1685         workaround.
1686         (CHARBUFFERPROC_NAME): Remove.
1687         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1688         Python 2.4 workaround.
1689
1690 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1691
1692         * NEWS: Note minimum Python version.
1693
1694 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1695
1696         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1697         code from these functions.  Remove corresponding ifdefs.  Use
1698         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1699         Remove gotos and target of gotos.
1700         (infpy_search_memory): Likewise.
1701
1702 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1703
1704         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1705         (hppa_gdbarch_init): Don't register deleted functions with
1706         gdbarch.
1707
1708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1709
1710         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1711         (h8300_unwind_sp): Delete.
1712         (h8300_dummy_id): Delete.
1713         (h8300_gdbarch_init): Don't register deleted functions with
1714         gdbarch.
1715
1716 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1717
1718         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1719         (ft32_unwind_pc): Delete.
1720         (ft32_unwind_sp): Delete.
1721         (ft32_gdbarch_init): Don't register deleted functions with
1722         gdbarch.
1723
1724 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1725
1726         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1727         (frv_unwind_pc): Delete.
1728         (frv_unwind_sp): Delete.
1729         (frv_gdbarch_init): Don't register deleted functions with
1730         gdbarch.
1731
1732 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1733
1734         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1735         (riscv_unwind_pc): Delete.
1736         (riscv_unwind_sp): Delete.
1737         (riscv_gdbarch_init): Don't register deleted functions with
1738         gdbarch.
1739
1740 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1741
1742         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1743         (csky_unwind_pc): Delete.
1744         (csky_unwind_sp): Delete.
1745         (csky_gdbarch_init): Don't register deleted functions with
1746         gdbarch.
1747
1748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1749
1750         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1751         (cris_unwind_pc): Delete.
1752         (cris_unwind_sp): Delete.
1753         (cris_gdbarch_init): Don't register deleted functions with
1754         gdbarch.
1755
1756 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1757
1758         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1759         (bfin_unwind_pc): Delete.
1760         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1761
1762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1763
1764         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1765         (arm_unwind_pc): Delete.
1766         (arm_unwind_sp): Delete.
1767         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1768
1769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1770
1771         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1772         (arc_unwind_pc): Delete.
1773         (arc_unwind_sp): Delete.
1774         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1775
1776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1779         (alpha_unwind_pc): Delete.
1780         (alpha_gdbarch_init): Don't register deleted functions with
1781         gdbarch.
1782
1783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1784
1785         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1786         (aarch64_unwind_pc): Delete.
1787         (aarch64_unwind_sp): Delete.
1788         (aarch64_gdbarch_init): Don't register deleted functions with
1789         gdbarch.
1790
1791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1792
1793         * gdbtypes.c (type_align): Don't consider static members when
1794         computing structure alignment.
1795
1796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1797
1798         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1799         return 0 for other types.
1800         * arch-utils.c (default_type_align): Always return 0.
1801         * gdbarch.h: Regenerate.
1802         * gdbarch.sh (type_align): Extend comment.
1803         * gdbtypes.c (type_align): Add additional comments, always call
1804         gdbarch_type_align before applying the default rules.
1805         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1806         generic code will then apply a suitable default.
1807         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1808         types, return 0 for other types.
1809
1810 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1811
1812         * NEWS: Create a new section for the next release branch.
1813         Rename the section of the current branch, now that it has
1814         been cut.
1815
1816 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1817
1818         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1819         * version.in: Bump version to 8.3.50.DATE-git.
1820
1821 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1822
1823         * aix-thread.c (ptid_cmp): Remove unused variable.
1824         (get_signaled_thread): Likewise.
1825         (store_regs_user_thread): Likewise.
1826         (store_regs_kernel_thread): Likewise.
1827         (fetch_regs_kernel_thread): Remove shadowed variable.
1828
1829 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1830
1831         * features/riscv/32bit-cpu.xml: Add register numbers.
1832         * features/riscv/32bit-fpu.c: Regenerate.
1833         * features/riscv/32bit-fpu.xml: Add register numbers.
1834         * features/riscv/64bit-cpu.xml: Add register numbers.
1835         * features/riscv/64bit-fpu.c: Regenerate.
1836         * features/riscv/64bit-fpu.xml: Add register numbers.
1837
1838 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1839
1840         * NEWS: Mention two argument form of gdb.Value constructor.
1841         * python/py-value.c (convert_buffer_and_type_to_value): New
1842         function.
1843         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1844         Add support for handling an optional second argument.  Call
1845         convert_buffer_and_type_to_value as appropriate.
1846         * python/python-internal.h (Py_buffer_deleter): New struct.
1847         (Py_buffer_up): New typedef.
1848
1849 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1850
1851         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1852         instead of releasing ownership.
1853
1854 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1855
1856         * dwarf2read.c (open_and_init_dwp_file): Call
1857         elf_numsections instead of bfd_count_sections to initialize
1858         dwp_file->num_sections.
1859
1860 2019-02-25  Tom Tromey  <tromey@adacore.com>
1861
1862         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1863
1864 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1865
1866         * gcore.in: Add '--readnever' option when invoking GDB.
1867
1868 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1869
1870         * MAINTAINERS: Update my email address.
1871
1872 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1873
1874         * build-id.c (build_id_to_debug_bfd_1): New function.
1875         (build_id_to_debug_bfd): Look for separate debug file in
1876         sysroot.
1877
1878 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * gdbarch.sh: Update the copyright year range that is placed into
1881         generated files.
1882
1883 2019-02-22  Keith Seitz  <keiths@redhat.com>
1884
1885         PR symtab/23853
1886         * linespec.c (create_sals_line_offset): Search for the default
1887         symtab's filename instead of its fullname.
1888
1889 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1890
1891         * NEWS: Update style defaults.
1892
1893 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1894
1895         * main.c (captured_main_1): Disable styling in batch mode.
1896
1897 2019-02-20  Tom Tromey  <tom@tromey.com>
1898
1899         * symtab.c (symtab_symbol_info): Fix typos.
1900
1901 2019-02-20  Tom Tromey  <tromey@adacore.com>
1902
1903         * findcmd.c (_initialize_mem_search): Use upper case for
1904         metasyntactic variables.
1905
1906 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1907
1908         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1909         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1910
1911 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1912
1913         * top.h (source_file_name): Change to std::string.
1914         * top.c (source_file_name): Likewise.
1915         (command_line_input): Adjust.
1916         * cli/cli-script.c (script_from_file): Adjust.
1917
1918 2019-02-19  Tom Tromey  <tromey@adacore.com>
1919
1920         * ravenscar-thread.c
1921         (ravenscar_thread_target::update_thread_list): Don't call
1922         ada_build_task_list.
1923         * ada-lang.h (ada_build_task_list): Don't declare.
1924         * ada-tasks.c (struct ada_tasks_inferior_data)
1925         <task_list_valid_p>: Now bool.
1926         (read_known_tasks, ada_task_list_changed)
1927         (ada_tasks_invalidate_inferior_data): Update.
1928         (read_known_tasks_array): Return bool.
1929         (read_known_tasks_list): Likewise.
1930         (read_known_tasks): Return void.
1931         (ada_build_task_list): Now static.
1932
1933 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1934
1935         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1936         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1937
1938 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1939
1940         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1941         variant for ada_tasks_pspace_data_handle and
1942         ada_tasks_inferior_data_handle.
1943         (ada_tasks_pspace_data_cleanup): New function.
1944         (ada_tasks_inferior_data_cleanup): New function.
1945
1946 2019-02-17  Tom Tromey  <tom@tromey.com>
1947
1948         * macrotab.h (macro_source_fullname): Return a std::string.
1949         * macrotab.c (macro_include, check_for_redefinition)
1950         (macro_undef, macro_lookup_definition, foreach_macro)
1951         (foreach_macro_in_scope): Update.
1952         (macro_source_fullname): Return a std::string.
1953         * macrocmd.c (show_pp_source_pos): Update.
1954
1955 2019-02-17  Tom Tromey  <tom@tromey.com>
1956
1957         * macrocmd.c (show_pp_source_pos): Style the file names.
1958
1959 2019-02-17  Tom Tromey  <tom@tromey.com>
1960
1961         PR tui/24197:
1962         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1963
1964 2019-02-17  Tom Tromey  <tom@tromey.com>
1965
1966         * ada-lang.c (user_select_syms): Use filtered printing.
1967         * utils.c (wrap_style): New global.
1968         (desired_style): Remove.
1969         (emit_style_escape): Add stream parameter.
1970         (set_output_style, reset_terminal_style, prompt_for_continue):
1971         Update.
1972         (flush_wrap_buffer): Only flush gdb_stdout.
1973         (wrap_here): Set wrap_style.
1974         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1975         treat escape sequences as a character.  Change when wrap buffer is
1976         flushed.
1977         (fputs_styled): Do not set the output style when the default is
1978         requested.
1979         * ui-style.h (struct ui_file_style) <is_default>: New method.
1980         * source.c (print_source_lines_base): Emit escape sequences in one
1981         piece.
1982
1983 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1984
1985         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1986         integers and enumeration types.
1987
1988 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1989
1990         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1991         instead of lookup_symbol_in_language
1992         (do_exact_match): New function.
1993         (ada_get_symbol_name_matcher): Return do_exact_match when
1994         doing a verbatim match.
1995
1996 2019-02-15  Tom Tromey  <tromey@adacore.com>
1997
1998         * ravenscar-thread.c (ravenscar_thread_target::resume)
1999         (ravenscar_thread_target::wait): Special case wildcard requests.
2000
2001 2019-02-15  Tom Tromey  <tromey@adacore.com>
2002
2003         * ravenscar-thread.c (base_ptid): Remove.
2004         (struct ravenscar_thread_target) <close>: New method.
2005         <m_base_ptid>: New member.
2006         <update_inferior_ptid, active_task, task_is_currently_active,
2007         runtime_initialized>: Declare methods.
2008         <ravenscar_thread_target>: Add constructor.
2009         (ravenscar_thread_target::task_is_currently_active)
2010         (ravenscar_thread_target::update_inferior_ptid)
2011         (ravenscar_runtime_initialized): Rename.  Now methods.
2012         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2013         (ravenscar_thread_target::update_thread_list): Update.
2014         (ravenscar_thread_target::active_task): Now method.
2015         (ravenscar_thread_target::store_registers)
2016         (ravenscar_thread_target::prepare_to_store)
2017         (ravenscar_thread_target::prepare_to_store)
2018         (ravenscar_thread_target::mourn_inferior): Update.
2019         (ravenscar_inferior_created): Use "new" to create target.
2020         (ravenscar_thread_target::get_ada_task_ptid): Update.
2021         (_initialize_ravenscar): Don't initialize base_ptid.
2022         (ravenscar_ops): Remove global.
2023
2024 2019-02-15  Tom Tromey  <tromey@adacore.com>
2025
2026         * target.h (push_target): Declare new overload.
2027         * target.c (push_target): New overload, taking an rvalue reference.
2028         * remote.c (remote_target::open_1): Use push_target overload.
2029         * corelow.c (core_target_open): Use push_target overload.
2030
2031 2019-02-15  Tom Tromey  <tromey@adacore.com>
2032
2033         * ravenscar-thread.c (is_ravenscar_task)
2034         (ravenscar_task_is_currently_active): Return bool.
2035         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2036         (_initialize_ravenscar): Remove "(void)".
2037         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2038         Return bool.
2039
2040 2019-02-15  Tom Tromey  <tromey@adacore.com>
2041
2042         * ravenscar-thread.c (ravenscar_runtime_initializer)
2043         (has_ravenscar_runtime, get_running_thread_id)
2044         (ravenscar_thread_target::resume): Fix indentation.
2045
2046 2019-02-15  Tom Tromey  <tromey@adacore.com>
2047
2048         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2049         from ravenscar_arch_ops.
2050         (sparc_ravenscar_ops::fetch_registers)
2051         (sparc_ravenscar_ops::store_registers): Now methods.
2052         (sparc_ravenscar_prepare_to_store): Remove.
2053         (sparc_ravenscar_ops): Redefine.
2054         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2055         methods and destructor.  Remove members.
2056         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2057         (ravenscar_thread_target::store_registers)
2058         (ravenscar_thread_target::prepare_to_store): Update.
2059         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2060         Remove.
2061         (struct ppc_ravenscar_powerpc_ops): Derive from
2062         ravenscar_arch_ops.
2063         (ppc_ravenscar_powerpc_ops::fetch_registers)
2064         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2065         (ppc_ravenscar_powerpc_ops): Redefine.
2066         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2067         (ppc_ravenscar_e500_ops::fetch_registers)
2068         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2069         (ppc_ravenscar_e500_ops): Redefine.
2070         * aarch64-ravenscar-thread.c
2071         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2072         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2073         (aarch64_ravenscar_fetch_registers)
2074         (aarch64_ravenscar_store_registers): Now methods.
2075         (aarch64_ravenscar_ops): Redefine.
2076
2077 2019-02-15  Tom Tromey  <tromey@adacore.com>
2078
2079         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2080         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2081         (ravenscar_thread_target::stopped_by_watchpoint)
2082         (ravenscar_thread_target::stopped_data_address)
2083         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2084
2085 2019-02-15  Tom Tromey  <tromey@adacore.com>
2086
2087         * ravenscar-thread.c: Fix some typos.
2088
2089 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2090             Tom Tromey  <tromey@adacore.com>
2091
2092         * ada-lang.c (ada_exception_sal): Change addr_string to a
2093         std::string.
2094         (create_ada_exception_catchpoint): Update.
2095
2096 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2097             Tom Tromey  <tromey@adacore.com>
2098
2099         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2100         (bp_location_ops): Remove.
2101         (base_breakpoint_allocate_location): Update.
2102         (free_bp_location): Update.
2103         * ada-lang.c (class ada_catchpoint_location)
2104         <ada_catchpoint_location>: Remove ops parameter.
2105         (ada_catchpoint_location_dtor): Remove.
2106         (ada_catchpoint_location_ops): Remove.
2107         (allocate_location_exception): Update.
2108         * breakpoint.h (struct bp_location_ops): Remove.
2109         (class bp_location) <bp_location>: Remove bp_location_ops
2110         parameter.
2111         <~bp_location>: Add destructor.
2112         <ops>: Remove.
2113
2114 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2115             Pedro Alves  <palves@redhat.com>
2116
2117         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2118         'PATH_MAX'.
2119
2120 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2121             Samuel Thibault  <samuel.thibault@gnu.org>
2122             Thomas Schwinge  <thomas@codesourcery.com>
2123
2124         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2125         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2126
2127 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2128
2129         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2130         (check_empty): Use "const char *".
2131
2132         * gnu-nat.c (gnu_nat_target::detach): Instead of
2133         'detach_inferior (pid)' call
2134         'detach_inferior (find_inferior_pid (pid))'.
2135
2136         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2137         'nat/fork-inferior.o'.
2138         * gnu-nat.c: #include "nat/fork-inferior.h".
2139
2140         * gnu-nat.c (gnu_nat_target::detach): Instead of
2141         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2142         * gnu-nat.h: #include "inf-child.h".
2143         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2144         'i386_gnu_nat_target::fetch_registers'.
2145         (gnu_store_registers): Rename/move to
2146         'i386_gnu_nat_target::store_registers'.
2147
2148         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2149         * gnu-nat.h (mach_thread_info): New function.
2150         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2151
2152         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2153
2154 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2155
2156         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2157
2158 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2159
2160         * windows-nat.c (windows_add_thread): Add new parameter
2161         "main_thread_p" with default value set to false.  Update
2162         function documentation as well as all callers.
2163         (windows_delete_thread): Likewise.
2164         (fake_create_process): Update call to windows_add_thread.
2165         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2166         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2167         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2168         call to windows_delete_thread.
2169
2170 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2171
2172         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2173
2174 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2175
2176         * symfile.c (find_separate_debug_file): Use canonical path of
2177         sysroot with child_path instead of gdb_sysroot if it is valid.
2178
2179 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2180
2181         * symfile.c (find_separate_debug_file): Use child_path to
2182         determine if an object file is under a sysroot.
2183
2184 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2185
2186         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2187         unittests/child-path-selftests.c.
2188         * common/pathstuff.c (child_path): New function.
2189         * common/pathstuff.h (child_path): New prototype.
2190         * unittests/child-path-selftests.c: New file.
2191
2192 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2193
2194         * symfile.c (find_separate_debug_file): Look for separate debug
2195         files in debug directories under the sysroot.
2196
2197 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2198
2199         * symtab.h (struct minimal_symbol data_p): New const method.
2200         (struct minimal_symbol text_p): Likewise.
2201         * symtab.c (output_source_filename): Use file name style
2202         to print file name.
2203         (print_symbol_info): Likewise.
2204         (print_msymbol_info): Use address style to print addresses.
2205         Use function name style to print executable text symbols.
2206         (expand_symtab_containing_pc): Use data_p.
2207         (find_pc_sect_compunit_symtab): Likewise.
2208
2209 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2210
2211         * breakpoint.c (describe_other_breakpoints): Use address style
2212         to print addresses.
2213         (say_where): Likewise.
2214
2215 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2216
2217         * ada-typeprint.c (print_func_type): Print function name
2218         style to print function name.
2219         * c-typeprint.c (c_print_type_1): Likewise.
2220
2221 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2222
2223         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2224         for execve.
2225
2226 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2227
2228         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2229         type_stack.
2230
2231 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2232
2233         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2234         TYPE_CODE_REF types.
2235
2236 2019-02-08  Jim Wilson  <jimw@sifive.com>
2237
2238         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2239         (riscv_linux_fregset): New.
2240         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2241
2242 2019-02-07  Tom Tromey  <tom@tromey.com>
2243
2244         * thread.c (thread_cancel_execution_command): Update.
2245         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2246         methods.
2247         (struct thread_fsm_ops): Remove.
2248         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2249         (thread_fsm_should_stop, thread_fsm_return_value)
2250         (thread_fsm_set_finished, thread_fsm_finished_p)
2251         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2252         Don't declare.
2253         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2254         * infrun.c (clear_proceed_status_thread)
2255         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2256         (print_stop_event): Update.
2257         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2258         Add constructor.
2259         (step_command_fsm_ops): Remove.
2260         (new_step_command_fsm): Remove.
2261         (step_1): Update.
2262         (step_command_fsm::should_stop): Rename from
2263         step_command_fsm_should_stop.
2264         (step_command_fsm::clean_up): Rename from
2265         step_command_fsm_clean_up.
2266         (step_command_fsm::do_async_reply_reason): Rename from
2267         step_command_fsm_async_reply_reason.
2268         (struct until_next_fsm): Inherit from thread_fsm.  Add
2269         constructor.
2270         (until_next_fsm_ops): Remove.
2271         (new_until_next_fsm): Remove.
2272         (until_next_fsm::should_stop): Rename from
2273         until_next_fsm_should_stop.
2274         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2275         (until_next_fsm::do_async_reply_reason): Rename from
2276         until_next_fsm_async_reply_reason.
2277         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2278         constructor.  Change type of breakpoint.
2279         (finish_command_fsm_ops): Remove.
2280         (new_finish_command_fsm): Remove.
2281         (finish_command_fsm::should_stop): Rename from
2282         finish_command_fsm_should_stop.
2283         (finish_command_fsm::clean_up): Rename from
2284         finish_command_fsm_clean_up.
2285         (finish_command_fsm::return_value): Rename from
2286         finish_command_fsm_return_value.
2287         (finish_command_fsm::do_async_reply_reason): Rename from
2288         finish_command_fsm_async_reply_reason.
2289         (finish_command): Update.
2290         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2291         Add constructor.
2292         (call_thread_fsm_ops): Remove.
2293         (call_thread_fsm::call_thread_fsm): Rename from
2294         new_call_thread_fsm.
2295         (call_thread_fsm::should_stop): Rename from
2296         call_thread_fsm_should_stop.
2297         (call_thread_fsm::should_notify_stop): Rename from
2298         call_thread_fsm_should_notify_stop.
2299         (run_inferior_call, call_function_by_hand_dummy): Update.
2300         * cli/cli-interp.c (should_print_stop_to_console): Update.
2301         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2302         Add constructor.  Change type of location_breakpoint,
2303         caller_breakpoint.
2304         (until_break_fsm_ops): Remove.
2305         (new_until_break_fsm): Remove.
2306         (until_break_fsm::should_stop): Rename from
2307         until_break_fsm_should_stop.
2308         (until_break_fsm::clean_up): Rename from
2309         until_break_fsm_clean_up.
2310         (until_break_fsm::do_async_reply_reason): Rename from
2311         until_break_fsm_async_reply_reason.
2312         (until_break_command): Update.
2313         * thread-fsm.c: Remove.
2314         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2315
2316 2019-02-07  Tom Tromey  <tom@tromey.com>
2317
2318         * yy-remap.h: Add include guard.
2319         * xtensa-tdep.h: Add include guard.
2320         * xcoffread.h: Rename include guard.
2321         * varobj-iter.h: Add include guard.
2322         * tui/tui.h: Rename include guard.
2323         * tui/tui-winsource.h: Rename include guard.
2324         * tui/tui-wingeneral.h: Rename include guard.
2325         * tui/tui-windata.h: Rename include guard.
2326         * tui/tui-win.h: Rename include guard.
2327         * tui/tui-stack.h: Rename include guard.
2328         * tui/tui-source.h: Rename include guard.
2329         * tui/tui-regs.h: Rename include guard.
2330         * tui/tui-out.h: Rename include guard.
2331         * tui/tui-layout.h: Rename include guard.
2332         * tui/tui-io.h: Rename include guard.
2333         * tui/tui-hooks.h: Rename include guard.
2334         * tui/tui-file.h: Rename include guard.
2335         * tui/tui-disasm.h: Rename include guard.
2336         * tui/tui-data.h: Rename include guard.
2337         * tui/tui-command.h: Rename include guard.
2338         * tic6x-tdep.h: Add include guard.
2339         * target/waitstatus.h: Rename include guard.
2340         * target/wait.h: Rename include guard.
2341         * target/target.h: Rename include guard.
2342         * target/resume.h: Rename include guard.
2343         * target-float.h: Rename include guard.
2344         * stabsread.h: Add include guard.
2345         * rs6000-tdep.h: Add include guard.
2346         * riscv-fbsd-tdep.h: Add include guard.
2347         * regformats/regdef.h: Rename include guard.
2348         * record.h: Rename include guard.
2349         * python/python.h: Rename include guard.
2350         * python/python-internal.h: Rename include guard.
2351         * python/py-stopevent.h: Rename include guard.
2352         * python/py-ref.h: Rename include guard.
2353         * python/py-record.h: Rename include guard.
2354         * python/py-record-full.h: Rename include guard.
2355         * python/py-record-btrace.h: Rename include guard.
2356         * python/py-instruction.h: Rename include guard.
2357         * python/py-events.h: Rename include guard.
2358         * python/py-event.h: Rename include guard.
2359         * procfs.h: Add include guard.
2360         * proc-utils.h: Add include guard.
2361         * p-lang.h: Add include guard.
2362         * or1k-tdep.h: Rename include guard.
2363         * observable.h: Rename include guard.
2364         * nto-tdep.h: Rename include guard.
2365         * nat/x86-linux.h: Rename include guard.
2366         * nat/x86-linux-dregs.h: Rename include guard.
2367         * nat/x86-gcc-cpuid.h: Add include guard.
2368         * nat/x86-dregs.h: Rename include guard.
2369         * nat/x86-cpuid.h: Rename include guard.
2370         * nat/ppc-linux.h: Rename include guard.
2371         * nat/mips-linux-watch.h: Rename include guard.
2372         * nat/linux-waitpid.h: Rename include guard.
2373         * nat/linux-ptrace.h: Rename include guard.
2374         * nat/linux-procfs.h: Rename include guard.
2375         * nat/linux-osdata.h: Rename include guard.
2376         * nat/linux-nat.h: Rename include guard.
2377         * nat/linux-namespaces.h: Rename include guard.
2378         * nat/linux-btrace.h: Rename include guard.
2379         * nat/glibc_thread_db.h: Rename include guard.
2380         * nat/gdb_thread_db.h: Rename include guard.
2381         * nat/gdb_ptrace.h: Rename include guard.
2382         * nat/fork-inferior.h: Rename include guard.
2383         * nat/amd64-linux-siginfo.h: Rename include guard.
2384         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2385         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2386         * nat/aarch64-linux.h: Rename include guard.
2387         * nat/aarch64-linux-hw-point.h: Rename include guard.
2388         * mn10300-tdep.h: Add include guard.
2389         * mips-linux-tdep.h: Add include guard.
2390         * mi/mi-parse.h: Rename include guard.
2391         * mi/mi-out.h: Rename include guard.
2392         * mi/mi-main.h: Rename include guard.
2393         * mi/mi-interp.h: Rename include guard.
2394         * mi/mi-getopt.h: Rename include guard.
2395         * mi/mi-console.h: Rename include guard.
2396         * mi/mi-common.h: Rename include guard.
2397         * mi/mi-cmds.h: Rename include guard.
2398         * mi/mi-cmd-break.h: Rename include guard.
2399         * m2-lang.h: Add include guard.
2400         * location.h: Rename include guard.
2401         * linux-record.h: Rename include guard.
2402         * linux-nat.h: Add include guard.
2403         * linux-fork.h: Add include guard.
2404         * i386-darwin-tdep.h: Rename include guard.
2405         * hppa-linux-offsets.h: Add include guard.
2406         * guile/guile.h: Rename include guard.
2407         * guile/guile-internal.h: Rename include guard.
2408         * gnu-nat.h: Rename include guard.
2409         * gdb-stabs.h: Rename include guard.
2410         * frv-tdep.h: Add include guard.
2411         * f-lang.h: Add include guard.
2412         * event-loop.h: Add include guard.
2413         * darwin-nat.h: Rename include guard.
2414         * cp-abi.h: Rename include guard.
2415         * config/sparc/nm-sol2.h: Rename include guard.
2416         * config/nm-nto.h: Rename include guard.
2417         * config/nm-linux.h: Add include guard.
2418         * config/i386/nm-i386gnu.h: Rename include guard.
2419         * config/djgpp/nl_types.h: Rename include guard.
2420         * config/djgpp/langinfo.h: Rename include guard.
2421         * compile/gcc-cp-plugin.h: Add include guard.
2422         * compile/gcc-c-plugin.h: Add include guard.
2423         * compile/compile.h: Rename include guard.
2424         * compile/compile-object-run.h: Rename include guard.
2425         * compile/compile-object-load.h: Rename include guard.
2426         * compile/compile-internal.h: Rename include guard.
2427         * compile/compile-cplus.h: Rename include guard.
2428         * compile/compile-c.h: Rename include guard.
2429         * common/xml-utils.h: Rename include guard.
2430         * common/x86-xstate.h: Rename include guard.
2431         * common/version.h: Rename include guard.
2432         * common/vec.h: Rename include guard.
2433         * common/tdesc.h: Rename include guard.
2434         * common/selftest.h: Rename include guard.
2435         * common/scoped_restore.h: Rename include guard.
2436         * common/scoped_mmap.h: Rename include guard.
2437         * common/scoped_fd.h: Rename include guard.
2438         * common/safe-iterator.h: Rename include guard.
2439         * common/run-time-clock.h: Rename include guard.
2440         * common/refcounted-object.h: Rename include guard.
2441         * common/queue.h: Rename include guard.
2442         * common/ptid.h: Rename include guard.
2443         * common/print-utils.h: Rename include guard.
2444         * common/preprocessor.h: Rename include guard.
2445         * common/pathstuff.h: Rename include guard.
2446         * common/observable.h: Rename include guard.
2447         * common/netstuff.h: Rename include guard.
2448         * common/job-control.h: Rename include guard.
2449         * common/host-defs.h: Rename include guard.
2450         * common/gdb_wait.h: Rename include guard.
2451         * common/gdb_vecs.h: Rename include guard.
2452         * common/gdb_unlinker.h: Rename include guard.
2453         * common/gdb_unique_ptr.h: Rename include guard.
2454         * common/gdb_tilde_expand.h: Rename include guard.
2455         * common/gdb_sys_time.h: Rename include guard.
2456         * common/gdb_string_view.h: Rename include guard.
2457         * common/gdb_splay_tree.h: Rename include guard.
2458         * common/gdb_setjmp.h: Rename include guard.
2459         * common/gdb_ref_ptr.h: Rename include guard.
2460         * common/gdb_optional.h: Rename include guard.
2461         * common/gdb_locale.h: Rename include guard.
2462         * common/gdb_assert.h: Rename include guard.
2463         * common/filtered-iterator.h: Rename include guard.
2464         * common/filestuff.h: Rename include guard.
2465         * common/fileio.h: Rename include guard.
2466         * common/environ.h: Rename include guard.
2467         * common/common-utils.h: Rename include guard.
2468         * common/common-types.h: Rename include guard.
2469         * common/common-regcache.h: Rename include guard.
2470         * common/common-inferior.h: Rename include guard.
2471         * common/common-gdbthread.h: Rename include guard.
2472         * common/common-exceptions.h: Rename include guard.
2473         * common/common-defs.h: Rename include guard.
2474         * common/common-debug.h: Rename include guard.
2475         * common/cleanups.h: Rename include guard.
2476         * common/buffer.h: Rename include guard.
2477         * common/btrace-common.h: Rename include guard.
2478         * common/break-common.h: Rename include guard.
2479         * cli/cli-utils.h: Rename include guard.
2480         * cli/cli-style.h: Rename include guard.
2481         * cli/cli-setshow.h: Rename include guard.
2482         * cli/cli-script.h: Rename include guard.
2483         * cli/cli-interp.h: Rename include guard.
2484         * cli/cli-decode.h: Rename include guard.
2485         * cli/cli-cmds.h: Rename include guard.
2486         * charset-list.h: Add include guard.
2487         * buildsym-legacy.h: Rename include guard.
2488         * bfin-tdep.h: Add include guard.
2489         * ax.h: Rename include guard.
2490         * arm-linux-tdep.h: Add include guard.
2491         * arm-fbsd-tdep.h: Add include guard.
2492         * arch/xtensa.h: Rename include guard.
2493         * arch/tic6x.h: Add include guard.
2494         * arch/i386.h: Add include guard.
2495         * arch/arm.h: Rename include guard.
2496         * arch/arm-linux.h: Rename include guard.
2497         * arch/arm-get-next-pcs.h: Rename include guard.
2498         * arch/amd64.h: Add include guard.
2499         * arch/aarch64-insn.h: Rename include guard.
2500         * arch-utils.h: Rename include guard.
2501         * annotate.h: Add include guard.
2502         * amd64-darwin-tdep.h: Rename include guard.
2503         * aarch64-linux-tdep.h: Add include guard.
2504         * aarch64-fbsd-tdep.h: Add include guard.
2505         * aarch32-linux-nat.h: Add include guard.
2506
2507 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2508
2509         * macrotab.c (macro_define_internal): New function that
2510         factorizes macro_define_object_internal and macro_define_function
2511         code.
2512         (macro_define_object_internal): Use macro_define_internal.
2513         (macro_define_function): Likewise.
2514
2515 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2516
2517         * macrocmd.c (extract_identifier): Return
2518         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2519         callers.
2520
2521 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2522
2523         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2524
2525 2019-02-05  Tom Tromey  <tom@tromey.com>
2526
2527         * target.c (target_stack::unpush): Move assertion earlier.
2528
2529 2019-01-30  Tom Tromey  <tom@tromey.com>
2530
2531         PR python/23615:
2532         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2533         (gdbpy_parse_and_eval): Likewise.
2534         * python/python-internal.h (gdbpy_allow_threads): New class.
2535
2536 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2537
2538         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2539         (aarch64_fbsd_fpregmap): Move earlier.
2540         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2541         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2542         instead of individual calls to trad_frame_set_reg_addr.
2543         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2544         earlier.
2545         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2546         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2547         instead of individual calls to trad_frame_set_reg_addr.
2548
2549 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2550
2551         * CONTRIBUTE: Replace contribution list with wiki link.
2552
2553 2019-01-25  Tom Tromey  <tom@tromey.com>
2554
2555         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2556
2557 2019-01-25  Tom Tromey  <tom@tromey.com>
2558
2559         * xtensa-linux-nat.c: Fix common/ includes.
2560         * xml-support.h: Fix common/ includes.
2561         * xml-support.c: Fix common/ includes.
2562         * x86-linux-nat.c: Fix common/ includes.
2563         * windows-nat.c: Fix common/ includes.
2564         * varobj.h: Fix common/ includes.
2565         * varobj.c: Fix common/ includes.
2566         * value.c: Fix common/ includes.
2567         * valops.c: Fix common/ includes.
2568         * utils.c: Fix common/ includes.
2569         * unittests/xml-utils-selftests.c: Fix common/ includes.
2570         * unittests/utils-selftests.c: Fix common/ includes.
2571         * unittests/unpack-selftests.c: Fix common/ includes.
2572         * unittests/tracepoint-selftests.c: Fix common/ includes.
2573         * unittests/style-selftests.c: Fix common/ includes.
2574         * unittests/string_view-selftests.c: Fix common/ includes.
2575         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2576         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2577         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2578         * unittests/rsp-low-selftests.c: Fix common/ includes.
2579         * unittests/parse-connection-spec-selftests.c: Fix common/
2580         includes.
2581         * unittests/optional-selftests.c: Fix common/ includes.
2582         * unittests/offset-type-selftests.c: Fix common/ includes.
2583         * unittests/observable-selftests.c: Fix common/ includes.
2584         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2585         * unittests/memrange-selftests.c: Fix common/ includes.
2586         * unittests/memory-map-selftests.c: Fix common/ includes.
2587         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2588         * unittests/function-view-selftests.c: Fix common/ includes.
2589         * unittests/environ-selftests.c: Fix common/ includes.
2590         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2591         * unittests/common-utils-selftests.c: Fix common/ includes.
2592         * unittests/cli-utils-selftests.c: Fix common/ includes.
2593         * unittests/array-view-selftests.c: Fix common/ includes.
2594         * ui-file.c: Fix common/ includes.
2595         * tui/tui-io.c: Fix common/ includes.
2596         * tracepoint.h: Fix common/ includes.
2597         * tracepoint.c: Fix common/ includes.
2598         * tracefile-tfile.c: Fix common/ includes.
2599         * top.h: Fix common/ includes.
2600         * top.c: Fix common/ includes.
2601         * thread.c: Fix common/ includes.
2602         * target/waitstatus.h: Fix common/ includes.
2603         * target/waitstatus.c: Fix common/ includes.
2604         * target.h: Fix common/ includes.
2605         * target.c: Fix common/ includes.
2606         * target-memory.c: Fix common/ includes.
2607         * target-descriptions.c: Fix common/ includes.
2608         * symtab.h: Fix common/ includes.
2609         * symfile.c: Fix common/ includes.
2610         * stap-probe.c: Fix common/ includes.
2611         * spu-linux-nat.c: Fix common/ includes.
2612         * sparc-nat.c: Fix common/ includes.
2613         * source.c: Fix common/ includes.
2614         * solib.c: Fix common/ includes.
2615         * solib-target.c: Fix common/ includes.
2616         * ser-unix.c: Fix common/ includes.
2617         * ser-tcp.c: Fix common/ includes.
2618         * ser-pipe.c: Fix common/ includes.
2619         * ser-base.c: Fix common/ includes.
2620         * selftest-arch.c: Fix common/ includes.
2621         * s12z-tdep.c: Fix common/ includes.
2622         * rust-exp.y: Fix common/ includes.
2623         * rs6000-aix-tdep.c: Fix common/ includes.
2624         * riscv-tdep.c: Fix common/ includes.
2625         * remote.c: Fix common/ includes.
2626         * remote-notif.h: Fix common/ includes.
2627         * remote-fileio.h: Fix common/ includes.
2628         * remote-fileio.c: Fix common/ includes.
2629         * regcache.h: Fix common/ includes.
2630         * regcache.c: Fix common/ includes.
2631         * record-btrace.c: Fix common/ includes.
2632         * python/python.c: Fix common/ includes.
2633         * python/py-type.c: Fix common/ includes.
2634         * python/py-inferior.c: Fix common/ includes.
2635         * progspace.h: Fix common/ includes.
2636         * producer.c: Fix common/ includes.
2637         * procfs.c: Fix common/ includes.
2638         * proc-api.c: Fix common/ includes.
2639         * printcmd.c: Fix common/ includes.
2640         * ppc-linux-nat.c: Fix common/ includes.
2641         * parser-defs.h: Fix common/ includes.
2642         * osdata.c: Fix common/ includes.
2643         * obsd-nat.c: Fix common/ includes.
2644         * nat/x86-linux.c: Fix common/ includes.
2645         * nat/x86-linux-dregs.c: Fix common/ includes.
2646         * nat/x86-dregs.h: Fix common/ includes.
2647         * nat/x86-dregs.c: Fix common/ includes.
2648         * nat/ppc-linux.c: Fix common/ includes.
2649         * nat/mips-linux-watch.h: Fix common/ includes.
2650         * nat/mips-linux-watch.c: Fix common/ includes.
2651         * nat/linux-waitpid.c: Fix common/ includes.
2652         * nat/linux-ptrace.h: Fix common/ includes.
2653         * nat/linux-ptrace.c: Fix common/ includes.
2654         * nat/linux-procfs.c: Fix common/ includes.
2655         * nat/linux-personality.c: Fix common/ includes.
2656         * nat/linux-osdata.c: Fix common/ includes.
2657         * nat/linux-namespaces.c: Fix common/ includes.
2658         * nat/linux-btrace.h: Fix common/ includes.
2659         * nat/linux-btrace.c: Fix common/ includes.
2660         * nat/fork-inferior.c: Fix common/ includes.
2661         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2662         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2663         * nat/aarch64-linux.c: Fix common/ includes.
2664         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2665         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2666         * namespace.h: Fix common/ includes.
2667         * mips-linux-tdep.c: Fix common/ includes.
2668         * minsyms.c: Fix common/ includes.
2669         * mi/mi-parse.h: Fix common/ includes.
2670         * mi/mi-main.c: Fix common/ includes.
2671         * mi/mi-cmd-env.c: Fix common/ includes.
2672         * memrange.h: Fix common/ includes.
2673         * memattr.c: Fix common/ includes.
2674         * maint.h: Fix common/ includes.
2675         * maint.c: Fix common/ includes.
2676         * main.c: Fix common/ includes.
2677         * machoread.c: Fix common/ includes.
2678         * location.c: Fix common/ includes.
2679         * linux-thread-db.c: Fix common/ includes.
2680         * linux-nat.c: Fix common/ includes.
2681         * linux-fork.c: Fix common/ includes.
2682         * inline-frame.c: Fix common/ includes.
2683         * infrun.c: Fix common/ includes.
2684         * inflow.c: Fix common/ includes.
2685         * inferior.h: Fix common/ includes.
2686         * inferior.c: Fix common/ includes.
2687         * infcmd.c: Fix common/ includes.
2688         * inf-ptrace.c: Fix common/ includes.
2689         * inf-child.c: Fix common/ includes.
2690         * ia64-linux-nat.c: Fix common/ includes.
2691         * i387-tdep.c: Fix common/ includes.
2692         * i386-tdep.c: Fix common/ includes.
2693         * i386-linux-tdep.c: Fix common/ includes.
2694         * i386-linux-nat.c: Fix common/ includes.
2695         * i386-go32-tdep.c: Fix common/ includes.
2696         * i386-fbsd-tdep.c: Fix common/ includes.
2697         * i386-fbsd-nat.c: Fix common/ includes.
2698         * guile/scm-type.c: Fix common/ includes.
2699         * guile/guile.c: Fix common/ includes.
2700         * go32-nat.c: Fix common/ includes.
2701         * gnu-nat.c: Fix common/ includes.
2702         * gdbthread.h: Fix common/ includes.
2703         * gdbarch-selftests.c: Fix common/ includes.
2704         * gdb_usleep.c: Fix common/ includes.
2705         * gdb_select.h: Fix common/ includes.
2706         * gdb_bfd.c: Fix common/ includes.
2707         * gcore.c: Fix common/ includes.
2708         * fork-child.c: Fix common/ includes.
2709         * findvar.c: Fix common/ includes.
2710         * fbsd-nat.c: Fix common/ includes.
2711         * event-top.c: Fix common/ includes.
2712         * event-loop.c: Fix common/ includes.
2713         * dwarf2read.c: Fix common/ includes.
2714         * dwarf2loc.c: Fix common/ includes.
2715         * dwarf2-frame.c: Fix common/ includes.
2716         * dwarf-index-cache.c: Fix common/ includes.
2717         * dtrace-probe.c: Fix common/ includes.
2718         * disasm-selftests.c: Fix common/ includes.
2719         * defs.h: Fix common/ includes.
2720         * csky-tdep.c: Fix common/ includes.
2721         * cp-valprint.c: Fix common/ includes.
2722         * cp-support.h: Fix common/ includes.
2723         * cp-support.c: Fix common/ includes.
2724         * corelow.c: Fix common/ includes.
2725         * completer.h: Fix common/ includes.
2726         * completer.c: Fix common/ includes.
2727         * compile/compile.c: Fix common/ includes.
2728         * compile/compile-loc2c.c: Fix common/ includes.
2729         * compile/compile-cplus-types.c: Fix common/ includes.
2730         * compile/compile-cplus-symbols.c: Fix common/ includes.
2731         * command.h: Fix common/ includes.
2732         * cli/cli-dump.c: Fix common/ includes.
2733         * cli/cli-cmds.c: Fix common/ includes.
2734         * charset.c: Fix common/ includes.
2735         * build-id.c: Fix common/ includes.
2736         * btrace.h: Fix common/ includes.
2737         * btrace.c: Fix common/ includes.
2738         * breakpoint.h: Fix common/ includes.
2739         * breakpoint.c: Fix common/ includes.
2740         * ax.h:
2741         (enum agent_op): Fix common/ includes.
2742         * ax-general.c (struct aop_map): Fix common/ includes.
2743         * ax-gdb.c: Fix common/ includes.
2744         * auxv.c: Fix common/ includes.
2745         * auto-load.c: Fix common/ includes.
2746         * arm-tdep.c: Fix common/ includes.
2747         * arch/riscv.c: Fix common/ includes.
2748         * arch/ppc-linux-common.c: Fix common/ includes.
2749         * arch/i386.c: Fix common/ includes.
2750         * arch/arm.c: Fix common/ includes.
2751         * arch/arm-linux.c: Fix common/ includes.
2752         * arch/arm-get-next-pcs.c: Fix common/ includes.
2753         * arch/amd64.c: Fix common/ includes.
2754         * arch/aarch64.c: Fix common/ includes.
2755         * arch/aarch64-insn.c: Fix common/ includes.
2756         * arch-utils.c: Fix common/ includes.
2757         * amd64-windows-tdep.c: Fix common/ includes.
2758         * amd64-tdep.c: Fix common/ includes.
2759         * amd64-sol2-tdep.c: Fix common/ includes.
2760         * amd64-obsd-tdep.c: Fix common/ includes.
2761         * amd64-nbsd-tdep.c: Fix common/ includes.
2762         * amd64-linux-tdep.c: Fix common/ includes.
2763         * amd64-linux-nat.c: Fix common/ includes.
2764         * amd64-fbsd-tdep.c: Fix common/ includes.
2765         * amd64-fbsd-nat.c: Fix common/ includes.
2766         * amd64-dicos-tdep.c: Fix common/ includes.
2767         * amd64-darwin-tdep.c: Fix common/ includes.
2768         * agent.c: Fix common/ includes.
2769         * ada-lang.h: Fix common/ includes.
2770         * ada-lang.c: Fix common/ includes.
2771         * aarch64-tdep.c: Fix common/ includes.
2772
2773 2019-01-25  Tom Tromey  <tom@tromey.com>
2774
2775         * common/create-version.sh: Use common/version.h.
2776
2777 2019-01-24  Pedro Alves  <palves@redhat.com>
2778
2779         * infrun.c (signal_stop, signal_print, signal_program)
2780         (signal_catch, signal_pass): Now arrays instead of pointers.
2781         (update_signals_program_target, do_target_resume)
2782         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2783         * linux-nat.c (linux_nat_target::pass_signals)
2784         (linux_nat_target::create_inferior, linux_nat_target::attach):
2785         Adjust.
2786         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2787         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2788         * procfs.c (procfs_target::pass_signals): Adjust.
2789         * record-full.c (record_full_target::resume): Adjust.
2790         * remote.c (remote_target::pass_signals)
2791         (remote_target::program_signals): Adjust.
2792         * target-debug.h (target_debug_print_signals): Now takes a
2793         gdb::array_view as parameter.  Adjust.
2794         * target.h (target_ops) <pass_signals, program_signals>: Replace
2795         pointer and length parameters with gdb::array_view.
2796         (target_pass_signals, target_program_signals): Likewise.
2797         * target-delegates.c: Regenerate.
2798
2799 2019-01-24  Pedro Alves  <palves@redhat.com>
2800
2801         * common/forward-scope-exit.h
2802         (forward_scope_exit::forward_scope_exit): Pass arguments to
2803         m_bind_function directly, instead of creating a std::bind and
2804         copying that.
2805
2806 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2807
2808         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2809         for static members.
2810         (pass_in_v_vfp_candidate): Likewise.
2811
2812 2019-01-23  Tom Tromey  <tom@tromey.com>
2813             Pedro Alves  <palves@redhat.com>
2814
2815         * regcache.c (class regcache_invalidator): Remove.
2816         (regcache::raw_write): Use make_scope_exit.
2817
2818 2019-01-23  Tom Tromey  <tom@tromey.com>
2819
2820         * ui-out.h (class ui_out_emit_type): Update comment.
2821
2822 2019-01-23  Tom Tromey  <tom@tromey.com>
2823
2824         * infrun.c (fetch_inferior_event): Update comment.
2825
2826 2019-01-23  Tom Tromey  <tom@tromey.com>
2827             Pedro Alves  <palves@redhat.com>
2828
2829         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2830         parameter.
2831         (fetch_inferior_event): Use SCOPE_EXIT.
2832
2833
2834 2019-01-23  Tom Tromey  <tom@tromey.com>
2835             Pedro Alves  <palves@redhat.com>
2836
2837         * infrun.c (disable_thread_events): Delete.
2838         (stop_all_threads): Use SCOPE_EXIT.
2839
2840 2019-01-23  Tom Tromey  <tom@tromey.com>
2841             Pedro Alves  <palves@redhat.com>
2842
2843         * symfile.c: Include forward-scope-exit.h.
2844         (clear_symtab_users_cleanup): Replace forward declaration with
2845         a FORWARD_SCOPE_EXIT.
2846         (syms_from_objfile_1): Use the forward_scope_exit and
2847         gdb::optional instead of cleanup_function.
2848         (reread_symbols): Use the forward_scope_exit instead of
2849         cleanup_function.
2850         (clear_symtab_users_cleanup): Remove function.
2851
2852 2019-01-23  Tom Tromey  <tom@tromey.com>
2853             Pedro Alves  <palves@redhat.com>
2854
2855         * linux-nat.c: Include scope-exit.h.
2856         (cleanup_target_stop): Remove.
2857         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2858         SCOPE_EXIT.
2859
2860 2019-01-23  Tom Tromey  <tom@tromey.com>
2861             Pedro Alves  <palves@redhat.com>
2862
2863         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2864         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2865
2866 2019-01-23  Tom Tromey  <tom@tromey.com>
2867             Andrew Burgess  <andrew.burgess@embecosm.com>
2868             Pedro Alves  <palves@redhat.com>
2869
2870         * infrun.c (fetch_inferior_event): Use scope_exit.
2871         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2872         * top.c (execute_command): Use scope_exit.
2873         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2874         * utils.c (do_bpstat_clear_actions_cleanup)
2875         (make_bpstat_clear_actions_cleanup): Remove.
2876
2877 2019-01-23  Tom Tromey  <tom@tromey.com>
2878             Pedro Alves  <palves@redhat.com>
2879
2880         * infrun.c: Include "common/scope-exit.h"
2881         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2882         (wait_for_inferior): Use SCOPE_EXIT.
2883         (fetch_inferior_event): Use scope_exit.
2884
2885 2019-01-23  Tom Tromey  <tom@tromey.com>
2886             Pedro Alves  <palves@redhat.com>
2887
2888         * breakpoint.c (create_breakpoint): Remove cleanup.
2889
2890 2019-01-23  Tom Tromey  <tom@tromey.com>
2891             Andrew Burgess  <andrew.burgess@embecosm.com>
2892             Pedro Alves  <palves@redhat.com>
2893
2894 2019-01-23  Pedro Alves  <palves@redhat.com>
2895
2896         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2897
2898 2019-01-23  Pedro Alves  <palves@redhat.com>
2899             Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * gdbthread.h: Include "common/forward-scope-exit.h".
2902         (scoped_finish_thread_state): Redefine custom class in terms of
2903         forward_scope_exit.
2904
2905 2019-01-23  Pedro Alves  <palves@redhat.com>
2906             Andrew Burgess  <andrew.burgess@embecosm.com>
2907
2908         * common/forward-scope-exit.h: New file.
2909
2910 2019-01-23  Pedro Alves  <palves@redhat.com>
2911             Andrew Burgess  <andrew.burgess@embecosm.com>
2912             Tom Tromey  <tom@tromey.com>
2913
2914         * common/scope-exit.h: New file.
2915
2916 2019-01-23  Pedro Alves  <palves@redhat.com>
2917
2918         * common/preprocessor.h (ESC): Rename to ...
2919         (ESC_PARENS): ... this.
2920         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2921         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2922
2923 2019-01-23  Tom Tromey  <tom@tromey.com>
2924
2925         * language.h (class scoped_switch_to_sym_language_if_auto):
2926         Initialize m_lang in both cases.
2927
2928 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2929
2930         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2931         with XCNEW.
2932
2933 2019-01-22  Tom Tromey  <tom@tromey.com>
2934
2935         * corelow.c: Do not include sys/file.h.
2936
2937 2019-01-22  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-wingeneral.h: Include gdb_curses.h.
2940
2941 2019-01-22  Tom Tromey  <tom@tromey.com>
2942
2943         * source-cache.h (class source_cache) <get_source_lines,
2944         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2945
2946 2019-01-22  Tom Tromey  <tom@tromey.com>
2947
2948         * remote-fileio.h (struct remote_target): Declare.
2949
2950 2019-01-22  Tom Tromey  <tom@tromey.com>
2951
2952         * python/py-arch.c: Do not include py-ref.h.
2953         * python/py-bpevent.c: Do not include py-ref.h.
2954         * python/py-cmd.c: Do not include py-ref.h.
2955         * python/py-continueevent.c: Do not include py-ref.h.
2956         * python/py-event.h: Do not include py-ref.h.
2957         * python/py-evtregistry.c: Do not include py-ref.h.
2958         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2959         * python/py-frame.c: Do not include py-ref.h.
2960         * python/py-framefilter.c: Do not include py-ref.h.
2961         * python/py-function.c: Do not include py-ref.h.
2962         * python/py-infevents.c: Do not include py-ref.h.
2963         * python/py-linetable.c: Do not include py-ref.h.
2964         * python/py-objfile.c: Do not include py-ref.h.
2965         * python/py-param.c: Do not include py-ref.h.
2966         * python/py-prettyprint.c: Do not include py-ref.h.
2967         * python/py-progspace.c: Do not include py-ref.h.
2968         * python/py-symbol.c: Do not include py-ref.h.
2969         * python/py-symtab.c: Do not include py-ref.h.
2970         * python/py-type.c: Do not include py-ref.h.
2971         * python/py-unwind.c: Do not include py-ref.h.
2972         * python/py-utils.c: Do not include py-ref.h.
2973         * python/py-value.c: Do not include py-ref.h.
2974         * python/py-varobj.c: Do not include py-ref.h.
2975         * python/py-xmethods.c: Do not include py-ref.h.
2976         * python/python.c: Do not include py-ref.h.
2977         * varobj.c: Do not include py-ref.h.
2978
2979 2019-01-22  Tom Tromey  <tom@tromey.com>
2980
2981         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2982         keyword for bcache.
2983
2984 2019-01-22  Tom Tromey  <tom@tromey.com>
2985
2986         * compile/compile-cplus-types.c: Remove a comment by #include.
2987
2988 2019-01-22  Tom Tromey  <tom@tromey.com>
2989
2990         * compile/gcc-c-plugin.h: Include compile-internal.h.
2991
2992 2019-01-22  Tom Tromey  <tom@tromey.com>
2993
2994         * stabsread.c (EXTERN): Do not define.
2995         (symnum, next_symbol_text_func, processing_gcc_compilation)
2996         (within_function, global_sym_chain, global_stabs)
2997         (previous_stab_code, this_object_header_files)
2998         (n_this_object_header_files)
2999         (n_allocated_this_object_header_files): Define.
3000         * stabsread.h (EXTERN): Never define.  Use "extern".
3001
3002 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3003
3004         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3005         history_value.
3006
3007 2019-01-21  Tom Tromey  <tom@tromey.com>
3008
3009         * ui-out.c: Fix includes.
3010         * tui/tui-source.c: Fix includes.
3011         * target.c: Fix includes.
3012         * remote.c: Fix includes.
3013         * regcache.c: Fix includes.
3014         * python/py-block.c: Fix includes.
3015         * printcmd.c: Fix includes.
3016         * or1k-tdep.c: Fix includes.
3017         * mi/mi-main.c: Fix includes.
3018         * m32r-tdep.c: Fix includes.
3019         * csky-tdep.c: Fix includes.
3020         * compile/compile-cplus-types.c: Fix includes.
3021         * cli/cli-interp.c: Fix includes.
3022
3023 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3024
3025         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3026         for padding.
3027
3028 2019-01-16  Tom Tromey  <tom@tromey.com>
3029
3030         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3031         earlier.
3032         (struct objfile) <msymbols_range>: Move from top level.
3033         <msymbols>: New method.
3034         (class objfile_msymbols): Remove.
3035         * symtab.c (default_collect_symbol_completion_matches_break_on):
3036         Update.
3037         * symmisc.c (dump_msymbols): Update.
3038         * stabsread.c (scan_file_globals): Update.
3039         * objc-lang.c (info_selectors_command, info_classes_command)
3040         (find_methods): Update.
3041         * minsyms.c (find_solib_trampoline_target): Update.
3042         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3043         * coffread.c (coff_symfile_read): Update.
3044         * ada-lang.c (ada_lookup_simple_minsym)
3045         (ada_collect_symbol_completion_matches): Update.
3046
3047 2019-01-16  Tom Tromey  <tom@tromey.com>
3048
3049         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3050         type.  Remove no-argument constructor.
3051         <iterator::operator++>: Simplify.
3052         <begin>: Update.
3053         <end>: Use minimal_symbol_count.
3054
3055 2019-01-16  Tom Tromey  <tom@tromey.com>
3056
3057         * objfiles.h (struct objfile) <psymtabs>: New method.
3058         (class objfile_psymtabs): Remove.
3059         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3060         typedef.
3061         <range>: New method.
3062         (require_partial_symbols): Change return type.
3063         * psymtab.c (require_partial_symbols)
3064         (psym_expand_symtabs_matching): Update.
3065         * mdebugread.c (parse_partial_symbols): Update.
3066         * dbxread.c (dbx_end_psymtab): Update.
3067
3068 2019-01-15  Tom Tromey  <tom@tromey.com>
3069
3070         * symtab.c (lookup_objfile_from_block)
3071         (lookup_symbol_in_objfile_symtabs)
3072         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3073         (find_line_symtab, info_sources_command)
3074         (default_collect_symbol_completion_matches_break_on)
3075         (make_source_files_completion_list): Update.
3076         * symmisc.c (print_objfile_statistics, dump_objfile)
3077         (maintenance_print_symbols, maintenance_info_symtabs)
3078         (maintenance_check_symtabs, maintenance_info_line_tables):
3079         Update.
3080         * source.c (select_source_symtab)
3081         (forget_cached_source_info_for_objfile): Update.
3082         * objfiles.h (class objfile_compunits): Remove.
3083         (struct objfile) <compunits_range>: New typedef.
3084         (compunits): New method.
3085         * objfiles.c (objfile_relocate1): Update.
3086         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3087         * maint.c (count_symtabs_and_blocks): Update.
3088         * linespec.c (iterate_over_all_matching_symtabs): Update.
3089         * cp-support.c (add_symbol_overload_list_qualified): Update.
3090         * coffread.c (coff_symtab_read): Update.
3091         * ada-lang.c (add_nonlocal_symbols)
3092         (ada_collect_symbol_completion_matches)
3093         (ada_add_global_exceptions): Update.
3094
3095 2019-01-15  Tom Tromey  <tom@tromey.com>
3096
3097         * progspace.h (program_space) <objfiles_safe_range>: New
3098         typedef.
3099         <objfiles_safe>: New method.
3100         * objfiles.h (class all_objfiles_safe): Remove.
3101         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3102         * jit.c (jit_inferior_exit_hook): Update.
3103
3104 2019-01-17  Tom Tromey  <tom@tromey.com>
3105
3106         * progspace.h (program_space) <objfiles_range>: New typedef.
3107         <objfiles>: New method.
3108         <objfiles_head>: Rename from objfiles.
3109         (object_files): Update.
3110         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3111         * guile/scm-pretty-print.c
3112         (ppscm_find_pretty_printer_from_objfiles): Update.
3113         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3114         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3115         Update.
3116         * python/py-progspace.c (pspy_get_objfiles): Update.
3117         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3118         Update.
3119         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3120         (objfpy_lookup_objfile_by_build_id): Update.
3121         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3122         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3123         Update.
3124         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3125         (expand_symtab_containing_pc, lookup_objfile_from_block)
3126         (lookup_static_symbol, basic_lookup_transparent_type)
3127         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3128         (find_line_symtab, info_sources_command)
3129         (default_collect_symbol_completion_matches_break_on)
3130         (make_source_files_completion_list, find_main_name): Update.
3131         * symmisc.c (print_symbol_bcache_statistics)
3132         (print_objfile_statistics, maintenance_print_symbols)
3133         (maintenance_print_msymbols, maintenance_print_objfiles)
3134         (maintenance_info_symtabs, maintenance_check_symtabs)
3135         (maintenance_expand_symtabs, maintenance_info_line_tables):
3136         Update.
3137         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3138         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3139         (map_overlay_command, unmap_overlay_command)
3140         (simple_overlay_update, expand_symtabs_matching)
3141         (map_symbol_filenames): Update.
3142         * symfile-debug.c (set_debug_symfile): Update.
3143         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3144         Update.
3145         * source.c (select_source_symtab, forget_cached_source_info):
3146         Update.
3147         * solib.c (solib_read_symbols): Update.
3148         * solib-spu.c (append_ocl_sos): Update.
3149         * psymtab.c (maintenance_print_psymbols)
3150         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3151         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3152         * printcmd.c (info_symbol_command): Update.
3153         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3154         Update.
3155         * objfiles.h (class all_objfiles): Remove.
3156         * objfiles.c (have_partial_symbols, have_full_symbols)
3157         (have_minimal_symbols, qsort_cmp, update_section_map)
3158         (shared_objfile_contains_address_p)
3159         (default_iterate_over_objfiles_in_search_order): Update.
3160         * objc-lang.c (info_selectors_command, info_classes_command)
3161         (find_methods): Update.
3162         * minsyms.c (find_solib_trampoline_target): Update.
3163         * maint.c (maintenance_info_sections)
3164         (maintenance_translate_address, count_symtabs_and_blocks):
3165         Update.
3166         * main.c (captured_main_1): Update.
3167         * linux-thread-db.c (try_thread_db_load_from_pdir)
3168         (has_libpthread): Update.
3169         * linespec.c (iterate_over_all_matching_symtabs)
3170         (search_minsyms_for_name): Update.
3171         * jit.c (jit_find_objf_with_entry_addr): Update.
3172         * hppa-tdep.c (find_unwind_entry)
3173         (hppa_lookup_stub_minimal_symbol): Update.
3174         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3175         Update.
3176         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3177         (elf_gnu_ifunc_resolve_by_got): Update.
3178         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3179         * dwarf-index-write.c (save_gdb_index_command): Update.
3180         * cp-support.c (add_symbol_overload_list_qualified): Update.
3181         * breakpoint.c (create_overlay_event_breakpoint)
3182         (create_longjmp_master_breakpoint)
3183         (create_std_terminate_master_breakpoint)
3184         (create_exception_master_breakpoint): Update.
3185         * blockframe.c (find_pc_partial_function): Update.
3186         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3187         (ada_collect_symbol_completion_matches)
3188         (ada_add_global_exceptions): Update.
3189
3190 2019-01-17  Tom Tromey  <tom@tromey.com>
3191
3192         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3193         declare VEC.
3194         (solib_target_parse_libraries): Change return type.
3195         (library_list_start_segment, library_list_start_section)
3196         (library_list_end_library, library_list_start_library); Update.
3197         (solib_target_free_library_list): Remove.
3198         (solib_target_parse_libraries): Remove cleanup.  Change return
3199         type.
3200         (solib_target_current_sos): Update.
3201
3202 2019-01-17  Tom Tromey  <tromey@bapiya>
3203
3204         * valprint.c: Replace "the the" with "the".
3205         * symtab.c: Replace "the the" with "the".
3206         * solib.c: Replace "the the" with "the".
3207         * solib-dsbt.c: Replace "the the" with "the".
3208         * linespec.c: Replace "the the" with "the".
3209         * dwarf2loc.h: Replace "the the" with "the".
3210         * amd64-windows-tdep.c: Replace "the the" with "the".
3211         * aarch64-tdep.c: Replace "the the" with "the".
3212
3213 2019-01-16  Keith Seitz  <keiths@redhat.com>
3214
3215         PR gdb/23773
3216         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3217         <builder>: Rename to ..
3218         <m_builder>: ... this and make private.
3219         (dwarf2_cu::get_builder): New method.  Change all users of
3220         `builder' to use this method.
3221         (dwarf2_start_symtab): Move to ...
3222         (dwarf2_cu::start_symtab): ... here.  Update all callers
3223         (setup_type_unit_groups): Move to ...
3224         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3225         callers.
3226         (dwarf2_cu::reset_builder): New method.
3227         (process_full_compunit, process_full_type_unit): Use
3228         dwarf2_cu::reset_builder.
3229         (follow_die_offset): Record the ancestor CU if it is different
3230         from the followed DIE's CU.
3231         (follow_die_sig_1): Likewise.
3232
3233 2019-01-15  Tom Tromey  <tom@tromey.com>
3234
3235         * remote.c (class remote_state) <buf>: Now a char_vector.
3236         <buf_size>: Remove.
3237         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3238         parameter.
3239         (remote_target::getpkt_or_notif_sane_1)
3240         (remote_target::getpkt_sane)
3241         (remote_target::getpkt_or_notif_sane): Likewise.
3242         (class remote_target) <putpkt>: New overload.
3243         (remote_target::read_frame): Change type of "buf_p".  Remove
3244         sizeof_p parameter.
3245         (packet_ok): New overload.
3246         (packet_check_result): New overload.
3247         Update all uses.
3248
3249 2019-01-14  Tom Tromey  <tom@tromey.com>
3250
3251         * remote-notif.c (handle_notification, remote_notif_ack)
3252         (remote_notif_parse): Make "buf" const.
3253         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3254         const.
3255         (remote_notif_parse, remote_notif_ack, handle_notification):
3256         Likewise.
3257         * remote.c (remote_notif_stop_parse): Make "buf" const.
3258         (remote_target::remote_parse_stop_reply): Make "buf" const.
3259         (remote_notif_stop_ack): Make "buf" const.
3260
3261 2019-01-14  Tom Tromey  <tom@tromey.com>
3262
3263         * remote.c (remote_console_output): Make parameter const.
3264
3265 2019-01-14  Tom Tromey  <tom@tromey.com>
3266
3267         * target-debug.h (target_debug_print_signals): Constify.
3268         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3269         * procfs.c (procfs_target::pass_signals): Update.
3270         * linux-nat.c (linux_nat_target::pass_signals): Update.
3271         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3272         * target-delegates.c: Rebuild.
3273         * remote.c (remote_target::program_signals): Update.
3274         (remote_target::pass_signals): Update.
3275         * target.c (target_pass_signals): Constify argument.
3276         (target_program_signals): Likewise.
3277         * target.h (struct target_ops) <pass_signals, program_signals>:
3278         Constify argument.
3279         (target_pass_signals, target_program_signals): Constify argument.
3280
3281 2019-01-14  Tom Tromey  <tom@tromey.com>
3282
3283         PR tui/28819:
3284         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3285
3286 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3287
3288         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3289         field.
3290         * rs6000-tdep.c: Include reggroups.h.
3291         (IS_V_ALIAS_PSEUDOREG): Define.
3292         (rs6000_register_name): Return names for the "vX" aliases.
3293         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3294         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3295         aliases.  Call default_register_reggroup_p for all other
3296         pseudo-registers.
3297         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3298         New functions.
3299         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3300         Handle "vX" aliases.
3301         (v_alias_pseudo_register_collect): New function.
3302         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3303         (rs6000_gdbarch_init): Initialize "vX" aliases as
3304         pseudo-registers.  Restore registration of
3305         rs6000_pseudo_register_reggroup_p with
3306         set_tdesc_pseudo_register_reggroup_p.
3307
3308 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3309
3310         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3311         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3312         set_gdbarch_num_pseudo_regs.
3313
3314 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3315
3316         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3317         Remove arg prefixname, add do_set and do_show.
3318         Add member functions set_list and show_list.
3319         * cli/cli-style.c (class cli_style_option): Update accordingly.
3320         (style_set_list): Move to file scope.
3321         (style_show_list): Likewise.
3322         (set_style): Call help_list.
3323         (show_style): Call cmd_show_list.
3324         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3325         Update to use the new macro.
3326
3327 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3328
3329         * ada-lang.c (_initialize_ada_language): Expand the help text
3330         for the "catch exception" command.
3331
3332 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3333
3334         * symtab.c (matching_obj_sections): Initialize obj,
3335         declare it closer to its usage.
3336
3337 2019-01-10  Tom Tromey  <tom@tromey.com>
3338
3339         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3340         (basic_inf_threads_range): Remove.
3341         (inf_threads_range, inf_non_exited_threads_range)
3342         (safe_inf_threads_range): Use next_adapter.
3343
3344 2019-01-10  Keith Seitz  <keiths@redhat.com>
3345
3346         PR gdb/23712
3347         PR symtab/23010
3348         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3349         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3350
3351 2019-01-10  Keith Seitz  <keiths@redhat.com>
3352
3353         PR gdb/23712
3354         PR symtab/23010
3355         * dictionary.c (pending_to_vector): Remove.
3356         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3357         Remove _1 suffix, replacing functions of the same name.  Update
3358         all callers.
3359         (dict_create_hashed, dict_create_hashed_expandable)
3360         (dict_create_linear, dict_create_linear_expandable, dict_free)
3361         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3362         Make functions static.
3363
3364 2019-01-10  Keith Seitz  <keiths@redhat.com>
3365
3366         PR gdb/23712
3367         PR symtab/23010
3368         * dictionary.h (struct dictionary): Replace declaration with
3369         multidictionary.
3370         (dict_create_hashed, dict_create_hashed_expandable)
3371         (dict_create_linear, dict_create_linear_expandable)
3372         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3373         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3374         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3375         taking multidictionary argument.
3376         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3377         * block.h (struct block) <dict>: Change to multidictionary
3378         and rename `multidict'.
3379         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3380         symmisc.c: Update all dictionary references to multidictionary.
3381
3382 2019-01-10  Keith Seitz  <keiths@redhat.com>
3383
3384         PR gdb/23712
3385         PR symtab/23010
3386         * dictionary.c: Include unordered_map.
3387         (pending_to_vector): New function.
3388         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3389         Rewrite the non-"_1" functions to take vector instead
3390         of linked list.
3391         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3392         "new" _1 versions of the same name.
3393         (multidictionary): Define.
3394         (std::hash<enum language): New definition.
3395         (collate_pending_symbols_by_language, mdict_create_hashed)
3396         (mdict_create_hashed_expandable, mdict_create_linear)
3397         (mdict_create_linear_expandable, mdict_free)
3398         (find_language_dictionary, create_new_language_dictionary)
3399         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3400         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3401         (mdict_size, mdict_empty): New functions.
3402         * dictionary.h (mdict_iterator): Define.
3403
3404 2019-01-10  Pedro Alves  <palves@redhat.com>
3405
3406         * breakpoint.c (read_uploaded_action)
3407         (create_tracepoint_from_upload): Adjust to use
3408         gdb::unique_xmalloc_ptr.
3409         * ctf.c (ctf_write_uploaded_tp):
3410         (SET_ARRAY_FIELD): Use emplace_back.
3411         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3412         * tracefile-tfile.c (tfile_write_uploaded_tp):
3413         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3414         gdb::unique_xmalloc_ptr.
3415         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3416         at_string, cond_string, cmd_strings>: Replace char pointers
3417         with gdb::unique_xmalloc_ptr.
3418
3419 2019-01-10  Pedro Alves  <palves@redhat.com>
3420
3421         * solib-target.c (library_list_start_library): Don't xstrdup name.
3422
3423 2019-01-10  Pedro Alves  <palves@redhat.com>
3424
3425         * mdebugread.c (parse_partial_symbols): Use
3426         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3427
3428 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3429
3430         * linux-fork.c (scoped_switch_fork_info)
3431         <~scoped_switch_fork_info>: Fix incorrect variable name.
3432
3433 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3434
3435         * linux-fork.c (scoped_switch_fork_info)
3436         <scoped_switch_fork_info>: Make explicit.
3437         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3438
3439 2019-01-10  Tom Tromey  <tom@tromey.com>
3440
3441         * objfiles.h (objfile::reset_psymtabs): Update.
3442         * objfiles.c (objfile::objfile): Update.
3443         * psymtab.h (psymtab_storage::obstack): Update.
3444         (psymtab_storage::m_obstack): Use gdb::optional.
3445         (class psymtab_storage): Update comment.  Remove objfile
3446         parameter.
3447         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3448
3449 2019-01-10  Tom Tromey  <tom@tromey.com>
3450
3451         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3452         <free_psymtabs>: Now private.
3453         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3454         (allocate_psymtab): Use new method.
3455
3456 2019-01-10  Tom Tromey  <tom@tromey.com>
3457
3458         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3459         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3460         * mdebugread.c (parse_partial_symbols): Use
3461         allocate_dependencies.
3462         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3463         allocate_dependencies.
3464         (process_psymtab_comp_unit_reader)
3465         (build_type_psymtab_dependencies): Likewise.
3466         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3467
3468 2019-01-10  Tom Tromey  <tom@tromey.com>
3469
3470         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3471         PSYMBOL_SET_LANGUAGE.
3472         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3473
3474 2019-01-10  Tom Tromey  <tom@tromey.com>
3475
3476         * psymtab.h (psymtab_storage::obstack): New method.
3477         <m_obstack>: Rename from obstack; now private.
3478         * psymtab.c (psymtab_storage): Update.
3479         * dwarf2read.c (create_addrmap_from_index)
3480         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3481         Update.
3482
3483 2019-01-10  Tom Tromey  <tom@tromey.com>
3484
3485         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3486         * objfiles.h (objfile::reset_psymtabs): New method.
3487
3488 2019-01-10  Tom Tromey  <tom@tromey.com>
3489
3490         * symmisc.c (print_symbol_bcache_statistics): Update.
3491         (print_objfile_statistics): Update.
3492         * symfile.c (reread_symbols): Update.
3493         * psymtab.h (class psymtab_storage): New.
3494         * psymtab.c (psymtab_storage): New constructor.
3495         (~psymtab_storage): New destructor.
3496         (require_partial_symbols): Update.
3497         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3498         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3499         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3500         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3501         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3502         (start_psymtab_common, end_psymtab_common)
3503         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3504         (allocate_psymtab): Update.
3505         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3506         Update.
3507         (dump_psymtab_addrmap, maintenance_print_psymbols)
3508         (maintenance_check_psymtabs): Update.
3509         (class objfile_psymtabs): Move to objfiles.h.
3510         * psympriv.h (discard_psymtab): Now inline.
3511         (psymtab_discarder::psymtab_discarder): Update.
3512         (psymtab_discarder::~psymtab_discarder): Update.
3513         (ALL_OBJFILE_PSYMTABS): Rewrite.
3514         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3515         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3516         Remove fields.
3517         <partial_symtabs>: New field.
3518         (class objfile_psymtabs): Move from psymtab.h.  Update.
3519         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3520         psymbol_cache.
3521         (objfile::~objfile): Don't destroy psymbol_cache.
3522         * mdebugread.c (parse_partial_symbols): Update.
3523         * dwarf2read.c (create_addrmap_from_index)
3524         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3525         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3526         (add_partial_subprogram, dwarf2_ranges_read): Update.
3527         * dwarf-index-write.c (write_address_map)
3528         (write_one_signatured_type, recursively_write_psymbols)
3529         (class debug_names, class debug_names, write_psymtabs_to_index):
3530         Update.
3531
3532 2019-01-10  Tom Tromey  <tom@tromey.com>
3533
3534         * symtab.h (SYMBOL_SET_NAMES): Update.
3535         (symbol_set_names): Update.
3536         (MSYMBOL_SET_NAMES): Update.
3537         * symtab.c (symbol_set_names): Change argument to be an
3538         objfile_per_bfd_storage.
3539         * psymtab.c (add_psymbol_to_bcache): Update.
3540         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3541
3542 2019-01-10  Tom Tromey  <tom@tromey.com>
3543
3544         * symtab.c (create_demangled_names_hash): Change argument to be an
3545         objfile_per_bfd_storage.
3546         (symbol_set_names): Update.
3547
3548 2019-01-10  Tom Tromey  <tom@tromey.com>
3549
3550         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3551         init_psymbol_list.
3552         * psymtab.c (init_psymbol_list): Do nothing if already called.
3553         * psympriv.h (init_psymbol_list): Add comment.
3554         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3555         init_psymbol_list.
3556         * dbxread.c (dbx_symfile_read): Unconditionally call
3557         init_psymbol_list.
3558
3559 2019-01-10  Tom Tromey  <tom@tromey.com>
3560
3561         * xcoffread.c (scan_xcoff_symtab): Update.
3562         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3563         "where".
3564         * mdebugread.c (parse_partial_symbols)
3565         (handle_psymbol_enumerators): Update.
3566         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3567         * dbxread.c (read_dbx_symtab): Update.
3568         * psympriv.h (psymbol_placement): New enum.
3569         (add_psymbol_to_list): Update.
3570
3571 2019-01-10  Tom Tromey  <tom@tromey.com>
3572
3573         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3574         static_psymbols parameters.
3575         (scan_xcoff_symtab): Update.
3576         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3577         static_psymbols parameters.
3578         * psympriv.h (start_psymtab_common): Update.
3579         * mdebugread.c (parse_partial_symbols): Update.
3580         * dwarf2read.c (create_partial_symtab): Update.
3581         * dbxread.c (read_dbx_symtab): Update.
3582         (start_psymtab): Remove global_psymbols and static_psymbols
3583         parameters.
3584
3585 2019-01-10  Tom Tromey  <tom@tromey.com>
3586
3587         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3588         * psymtab.c (allocate_psymtab): Add comment.
3589         * psympriv.h (allocate_psymtab): Add comment.
3590         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3591         initializations.
3592         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3593
3594 2019-01-10  Tom Tromey  <tom@tromey.com>
3595
3596         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3597         Don't declare.
3598         * mipsread.c: Include mdebugread.h.
3599         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3600         Declare.
3601         * elfread.c: Include mdebugread.h.
3602
3603 2019-01-09  Tom Tromey  <tom@tromey.com>
3604
3605         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3606         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3607         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3608         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3609         (psym_lookup_symbol, psym_find_last_source_symtab)
3610         (psym_forget_cached_source_info, psym_print_stats)
3611         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3612         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3613         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3614         (psym_find_compunit_symtab_by_address)
3615         (maintenance_print_psymbols, maintenance_info_psymtabs)
3616         (maintenance_check_psymtabs): Use ranged for.
3617         * psymtab.h (class objfile_psymtabs): New.
3618         (require_partial_symbols): Return objfile_psymtabs.
3619         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3620
3621 2019-01-09  Tom Tromey  <tom@tromey.com>
3622
3623         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3624         (find_pc_mapped_section, list_overlays_command)
3625         (map_overlay_command, unmap_overlay_command)
3626         (simple_overlay_update): Use all_objfiles.
3627         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3628         * printcmd.c (info_symbol_command): Use all_objfiles.
3629         * objfiles.h (ALL_OBJSECTIONS): Remove.
3630         * maint.c (maintenance_translate_address): Use all_objfiles.
3631         * gcore.c (gcore_create_callback): Use all_objfiles.
3632         (objfile_find_memory_regions): Likewise.
3633
3634 2019-01-09  Tom Tromey  <tom@tromey.com>
3635
3636         * symtab.c (find_line_symtab, info_sources_command)
3637         (make_source_files_completion_list): Use objfile_compunits.
3638         * source.c (select_source_symtab): Use objfile_compunits.
3639         * objfiles.h (struct objfile): Update comment.
3640         (ALL_OBJFILES): Remove.
3641         (ALL_FILETABS): Remove.
3642         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3643         objfile_compunits.
3644
3645 2019-01-09  Tom Tromey  <tom@tromey.com>
3646
3647         * symmisc.c (print_objfile_statistics, dump_objfile)
3648         (maintenance_print_symbols): Use compunit_filetabs.
3649         * source.c (forget_cached_source_info_for_objfile): Use
3650         compunit_filetabs.
3651         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3652         (ALL_FILETABS): Use compunit_filetabs.
3653         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3654         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3655
3656 2019-01-09  Tom Tromey  <tom@tromey.com>
3657
3658         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3659         (compunit_filetabs): New.
3660         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3661         compunit_filetabs.
3662         (info_sources_command, make_source_files_completion_list): Remove
3663         declaration.
3664         * symmisc.c (print_objfile_statistics, dump_objfile)
3665         (maintenance_print_symbols): Remove declaration.
3666         (maintenance_info_symtabs): Use compunit_filetabs.
3667         (maintenance_info_line_tables): Likewise.
3668         * source.c (select_source_symtab): Change local variable name.
3669         (forget_cached_source_info_for_objfile): Remove declaration.
3670         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3671         * objfiles.c (objfile_relocate1): Remove declaration.
3672         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3673         declaration.
3674         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3675         * coffread.c (coff_symtab_read): Remove declaration.
3676         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3677         compunit_filetabs.
3678
3679 2019-01-09  Tom Tromey  <tom@tromey.com>
3680
3681         * symtab.c (lookup_objfile_from_block)
3682         (find_pc_sect_compunit_symtab, search_symbols)
3683         (default_collect_symbol_completion_matches_break_on): Use
3684         objfile_compunits.
3685         * objfiles.h (ALL_COMPUNITS): Remove.
3686         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3687         * cp-support.c (add_symbol_overload_list_qualified): Use
3688         objfile_compunits.
3689         * ada-lang.c (ada_collect_symbol_completion_matches)
3690         (ada_add_global_exceptions): Use objfile_compunits.
3691
3692 2019-01-09  Tom Tromey  <tom@tromey.com>
3693
3694         * source.c (select_source_symtab)
3695         (forget_cached_source_info_for_objfile): Remove declaration.
3696         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3697         declaration.
3698         * maint.c (count_symtabs_and_blocks): Remove declaration.
3699         * cp-support.c (add_symbol_overload_list_qualified): Remove
3700         declaration.
3701         * coffread.c (coff_symtab_read): Remove declaration.
3702         * symtab.c (lookup_symbol_in_objfile_symtabs)
3703         (basic_lookup_transparent_type_1): Use objfile_compunits.
3704         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3705         (info_sources_command, search_symbols)
3706         (default_collect_symbol_completion_matches_break_on)
3707         (make_source_files_completion_list): Remove declaration.
3708         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3709         (ada_collect_symbol_completion_matches)
3710         (ada_add_global_exceptions): Remove declaration.
3711         * linespec.c (iterate_over_all_matching_symtabs): Use
3712         objfile_compunits.
3713         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3714         (class objfile_compunits): New.
3715         (ALL_COMPUNITS): Use objfile_compunits.
3716         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3717         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3718         objfile_compunits.
3719         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3720
3721 2019-01-09  Tom Tromey  <tom@tromey.com>
3722
3723         * symtab.c (search_symbols)
3724         (default_collect_symbol_completion_matches_break_on): Use
3725         objfile_msymbols.
3726         * ada-lang.c (ada_lookup_simple_minsym)
3727         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3728         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3729         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3730         objfile_msymbols.
3731         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3732         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3733         * objc-lang.c (find_methods): Use objfile_msymbols.
3734         (info_selectors_command, info_classes_command): Likewise.
3735         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3736         * objfiles.h (class objfile_msymbols): New.
3737         (ALL_OBJFILE_MSYMBOLS): Remove.
3738         (ALL_MSYMBOLS): Remove.
3739
3740 2019-01-09  Tom Tromey  <tom@tromey.com>
3741
3742         * common/next-iterator.h (next_adapter): Add Iterator template
3743         parameter.
3744         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3745         (class all_objfiles_safe): New.
3746         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3747         * objfiles.c (put_objfile_before): Update comment.
3748         (add_separate_debug_objfile): Likewise.
3749         (free_all_objfiles): Use all_objfiles_safe.
3750         (objfile_purge_solibs): Likewise.
3751
3752 2019-01-09  Tom Tromey  <tom@tromey.com>
3753
3754         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3755         (expand_symtab_containing_pc, lookup_static_symbol)
3756         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3757         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3758         all_objfiles.
3759         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3760         * breakpoint.c (create_overlay_event_breakpoint)
3761         (create_longjmp_master_breakpoint)
3762         (create_std_terminate_master_breakpoint)
3763         (create_exception_master_breakpoint): Use all_objfiles.
3764         * linux-thread-db.c (try_thread_db_load_from_pdir)
3765         (has_libpthread): Use all_objfiles.
3766         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3767         * linespec.c (iterate_over_all_matching_symtabs)
3768         (search_minsyms_for_name): Use all_objfiles.
3769         * maint.c (maintenance_info_sections): Use all_objfiles.
3770         * main.c (captured_main_1): Use all_objfiles.
3771         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3772         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3773         * guile/scm-pretty-print.c
3774         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3775         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3776         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3777         (maintenance_print_msymbols): Use all_objfiles.
3778         * source.c (select_source_symtab): Use all_objfiles.
3779         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3780         * symfile.c (remove_symbol_file_command)
3781         (expand_symtabs_matching, map_symbol_filenames): Use
3782         all_objfiles.
3783         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3784         all_objfiles.
3785         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3786         * objc-lang.c (find_methods): Use all_objfiles.
3787         * objfiles.c (have_partial_symbols, have_full_symbols)
3788         (have_minimal_symbols, qsort_cmp)
3789         (default_iterate_over_objfiles_in_search_order): Use
3790         all_objfiles.
3791         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3792         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3793         (maintenance_check_psymtabs): Use all_objfiles.
3794         (ALL_PSYMTABS): Remove.
3795         * compile/compile-object-run.c (do_module_cleanup): Use
3796         all_objfiles.
3797         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3798         * cp-support.c (add_symbol_overload_list_qualified): Use
3799         all_objfiles.
3800         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3801         Use all_objfiles.
3802         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3803         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3804         all_objfiles.
3805         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3806         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3807         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3808         Uses all_objfiles.
3809         * solib.c (solib_read_symbols): Use all_objfiles
3810
3811 2019-01-09  Tom Tromey  <tom@tromey.com>
3812
3813         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3814         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3815         all_objfiles.
3816         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3817         * symmisc.c (print_symbol_bcache_statistics)
3818         (print_objfile_statistics, maintenance_print_objfiles)
3819         (maintenance_info_symtabs, maintenance_check_symtabs)
3820         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3821         all_objfiles.
3822         * source.c (forget_cached_source_info): Use all_objfiles.
3823         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3824         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3825         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3826         * objfiles.c (update_section_map): Use all_objfiles.
3827         (shared_objfile_contains_address_p): Likewise.
3828         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3829         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3830
3831 2019-01-09  Tom Tromey  <tom@tromey.com>
3832
3833         * common/next-iterator.h: New file.
3834         * objfiles.h (class all_objfiles): New.
3835         (struct objfile_iterator): New.
3836
3837 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3838
3839         * NEWS: Move the description of the changed "frame", "select-frame",
3840          and "info frame" commands to the Changed commands section.
3841
3842 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3843
3844         * gdbtypes.c (check_stub_method_group): Remove handling of old
3845         mangling schemes.
3846         * linespec.c (find_methods): Likewise.
3847         * stabsread.c (read_member_functions): Likewise.
3848         * valops.c (search_struct_method): Likewise.
3849         (value_struct_elt_for_reference): Likewise.
3850         * NEWS: Mention this change.
3851
3852 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3853
3854         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3855         print_source_lines.
3856         * source.c (print_source_lines_base): Update line number check.
3857         (print_source_lines): New function.
3858         (source_lines_range::source_lines_range): New function.
3859         * source.h (class source_lines_range): New class.
3860         (print_source_lines): New declaration.
3861
3862 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3863
3864         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3865
3866 2019-01-08  Tom Tromey  <tom@tromey.com>
3867             Simon Marchi  <simon.marchi@ericsson.com>
3868
3869         PR gdb/24060
3870         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3871         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3872         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3873         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3874         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3875         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3876
3877 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * source.c (select_source_symtab): Move header comment to
3880         declaration in source.h.
3881         (forget_cached_source_info_for_objfile): Likewise.
3882         (forget_cached_source_info): Likewise.
3883         (identify_source_line): Likewise.
3884         * source.h (identify_source_line): Move declaration from symtab.h
3885         and add comment from source.c
3886         (print_source_lines): Likewise.
3887         (forget_cached_source_info_for_objfile): Likewise.
3888         (forget_cached_source_info): Likewise.
3889         (select_source_symtab): Likewise.
3890         (enum print_source_lines_flag): Move definition from symtab.h.
3891         * symtab.h (identify_source_line): Move declaration to source.h.
3892         (print_source_lines): Likewise.
3893         (forget_cached_source_info_for_objfile): Likewise.
3894         (forget_cached_source_info): Likewise.
3895         (select_source_symtab): Likewise.
3896         (enum print_source_lines_flag): Move definition to source.h.
3897         * tui/tui-hooks.c: Add 'source.h' include.
3898
3899 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3900
3901         * source.c (print_source_lines_base): Handle requests to print
3902         reverse line number sequences, and guard against empty lines
3903         string.
3904
3905 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * source.c (print_source_lines_base): Fix skip of '\r' if next
3908         character is '\n'.
3909
3910 2019-01-06  Tom Tromey  <tom@tromey.com>
3911
3912         * c-exp.y (struct c_parse_state) <macro_original_text,
3913         expansion_obstack>: New member.
3914         (macro_original_text, expansion_obstack): Remove globals.
3915         (scan_macro_expansion, scanning_macro_expansion)
3916         (finished_macro_expansion): Update.
3917         (scan_macro_cleanup): Remove.
3918         (yylex, c_parse): Update.
3919
3920 2019-01-06  Tom Tromey  <tom@tromey.com>
3921
3922         * c-exp.y (struct c_parse_state) <strings>: New member.
3923         (operator_stoken): Update.
3924
3925 2019-01-06  Tom Tromey  <tom@tromey.com>
3926
3927         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3928         (union type_stack_elt) <typelist_val>: Now a pointer to
3929         std::vector.
3930         (type_stack_cleanup): Don't declare.
3931         (push_typelist): Update.
3932         * parse.c (pop_typelist): Return a std::vector.
3933         (push_typelist): Take a std::vector.
3934         (follow_types): Update.  Do not free args.
3935         (type_stack_cleanup): Remove.
3936         * c-exp.y (struct c_parse_state): New.
3937         (cpstate): New global.
3938         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3939         (nonempty_typelist): Update.
3940         (func_mod): Create a new vector.
3941         (c_parse): Create a c_parse_state.
3942         (check_parameter_typelist): Do not delete params.
3943         (function_method): Update.  Do not delete type_list.
3944
3945 2019-01-06  Tom Tromey  <tom@tromey.com>
3946
3947         PR gdb/28155:
3948         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3949         check_typedef.
3950         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3951         (print_return_value): Likewise.
3952
3953 2019-01-05  Tom Tromey  <tom@tromey.com>
3954
3955         * contrib/cleanup_check.py: Remove.
3956         * contrib/gcc-with-excheck: Remove.
3957         * contrib/exsummary.py: Remove.
3958         * contrib/excheck.py: Remove.
3959
3960 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3961
3962         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3963         NULL. Initialize tpprev to NULL instead of assigning it
3964         to NULL on the next statement.
3965         * windows-nat.c (windows_delete_thread): Remove check for
3966         main_thread_id before printing thread exit notifications.
3967         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3968         Remove thread ID check against main_thread_id.
3969         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3970         windows_delete_thread.
3971         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3972
3973 2019-01-04  Tom Tromey  <tom@tromey.com>
3974
3975         * compile/compile.c (_initialize_compile): Use upper case for
3976         metasyntactic variables.
3977         * symmisc.c (_initialize_symmisc): Use upper case for
3978         metasyntactic variables.
3979         * psymtab.c (_initialize_psymtab): Use upper case for
3980         metasyntactic variables.
3981         * demangle.c (demangle_command): Use upper case for metasyntactic
3982         variables.
3983         (_initialize_demangler): Likewise.
3984         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3985         variables.
3986
3987 2019-01-03  Tom Tromey  <tom@tromey.com>
3988
3989         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3990
3991 2019-01-03  Tom Tromey  <tom@tromey.com>
3992
3993         * python/py-symtab.c (salpy_str): Update.
3994         (struct salpy_sal_object) <symtab>: Now a PyObject.
3995         (salpy_dealloc): Update.
3996         (del_objfile_sal): Use gdbpy_ref.
3997
3998 2019-01-03  Tom Tromey  <tom@tromey.com>
3999
4000         * python/py-type.c (convert_field): Use new_reference.  Return
4001         gdbpy_ref.
4002         (make_fielditem): Return gdbpy_ref.
4003         (typy_fields): Update.
4004         (typy_getitem): Update.
4005         (field_name): Return gdbpy_ref.  Use new_reference.
4006         (typy_iterator_iternext): Update.
4007
4008 2019-01-03  Tom Tromey  <tom@tromey.com>
4009
4010         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4011
4012 2019-01-03  Tom Tromey  <tom@tromey.com>
4013
4014         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4015         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4016         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4017         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4018         (pspy_set_type_printers): Likewise.
4019         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4020         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4021         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4022         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4023         (objfpy_set_type_printers): Likewise.
4024
4025 2019-01-03  Tom Tromey  <tom@tromey.com>
4026
4027         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4028         (gdbpy_print_stack): Use gdbpy_err_fetch.
4029         * python/python-internal.h (class gdbpy_err_fetch): New class.
4030         (class gdbpy_enter) <m_error_type, m_error_value,
4031         m_error_traceback>: Remove.
4032         <m_error>: New member.
4033         (gdbpy_exception_to_string): Don't declare.
4034         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4035         * python/py-value.c (convert_value_from_python): Use
4036         gdbpy_err_fetch.
4037         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4038         gdbpy_exception_to_string.
4039         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4040         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4041         gdbpy_err_fetch.
4042
4043 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4044
4045         * linux-nat.c (delete_lwp_cleanup): Delete.
4046         (struct lwp_deleter): New struct.
4047         (lwp_info_up): New typedef.
4048         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4049         lwp_info_up.
4050
4051 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4052
4053         * linux-fork.c (class scoped_switch_fork_info): New class.
4054         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4055
4056 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4057
4058         * valops.c (find_overload_match): Remove use of null_cleanup, and
4059         calls to do_cleanups.
4060
4061 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4062
4063         * compile/compile-cplus-types.c
4064         (compile_cplus_instance::decl_name): Handle changes to
4065         cp_func_name.
4066         * cp-support.c (cp_func_name): Update header comment, update
4067         return type.
4068         * cp-support.h (cp_func_name): Update return type in declaration.
4069         * valops.c (find_overload_match): Move temp_func local to top
4070         level of function and change its type.  Use temp_func to hold and
4071         delete temporary string obtained from cp_func_name.
4072
4073 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4074
4075         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4076         gdb::char_vector, remove cleanup, and update uses of `msg`.
4077
4078 2019-01-03  Jim Wilson  <jimw@sifive.com>
4079
4080         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4081
4082 2019-01-02  Tom Tromey  <tom@tromey.com>
4083
4084         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4085         (tdesc_parse_xml): Remove cleanups.
4086         * target-descriptions.h (make_cleanup_free_target_description):
4087         Don't declare.
4088         (target_desc_deleter): New struct.
4089         (target_desc_up): New typedef.
4090         * target-descriptions.c (target_desc_deleter::operator()): Rename
4091         from free_target_description.
4092         (make_cleanup_free_target_description): Remove.
4093
4094 2019-01-02  Tom Tromey  <tom@tromey.com>
4095
4096         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4097         constructor, destructor.
4098         (linespec_parser): Remove typedef.
4099         (~linespec_parser): Rename from linespec_parser_delete.
4100         (linespec_lex_to_end, linespec_complete_label)
4101         (linespec_complete): Update.
4102         (decode_line_full): Remove cleanups.
4103         (decode_line_1): Update.
4104
4105 2019-01-02  Tom Tromey  <tom@tromey.com>
4106
4107         * python/python-internal.h (inferior_to_inferior_object): Change
4108         return type.
4109         * python/py-exitedevent.c (create_exited_event_object): Update.
4110         * python/py-inferior.c (inferior_to_inferior_object): Return
4111         gdbpy_ref.
4112         (python_new_inferior, python_inferior_deleted)
4113         (thread_to_thread_object, delete_thread_object)
4114         (build_inferior_list, gdbpy_selected_inferior): Update.
4115         * python/py-infthread.c (create_thread_object): Update.  Also fail
4116         if inferior_to_inferior_object fails.
4117
4118 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4119
4120         * inferior.h (class inferior) <displaced_step_state>: New field.
4121         * infrun.h (struct displaced_step_state): Move here from
4122         infrun.c.  Initialize fields, add constructor.
4123         <inf>: Remove field.
4124         <reset>: New method.
4125         * infrun.c (struct displaced_step_inferior_state): Move to
4126         infrun.h.
4127         (displaced_step_inferior_states): Remove.
4128         (get_displaced_stepping_state): Adust.
4129         (displaced_step_in_progress_any_inferior): Adjust.
4130         (displaced_step_in_progress_thread): Adjust.
4131         (displaced_step_in_progress): Adjust.
4132         (add_displaced_stepping_state): Remove.
4133         (get_displaced_step_closure_by_addr): Adjust.
4134         (remove_displaced_stepping_state): Remove.
4135         (infrun_inferior_exit): Call displaced_step_state.reset.
4136         (use_displaced_stepping): Don't check for NULL.
4137         (displaced_step_prepare_throw): Call
4138         get_displaced_stepping_state.
4139         (displaced_step_fixup): Don't check for NULL.
4140         (prepare_for_detach): Don't check for NULL.
4141
4142 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4143
4144         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4145          in case of call that did not complete.
4146
4147 2019-01-02  Andrey Utkin  <autkin@undo.io>
4148
4149         * symfile.c (find_separate_debug_file): Fix search of debug files for
4150         remote debuggee.
4151
4152 2019-01-02  Tom Tromey  <tom@tromey.com>
4153
4154         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4155         indentation.
4156         * python/py-frame.c (frapy_older): Remove cast.
4157         (frapy_newer): Likewise.
4158         * python/py-breakpoint.c (local_setattro): Remove cast.
4159         * python/py-arch.c (archpy_name): Remove local variable.
4160         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4161
4162 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4163
4164         * unittests/basic_string_view/element_access/char/empty.cc:
4165         Fix year range in copyright header.
4166
4167 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4170         Delete.
4171         <operator==>: Update with for removed field.
4172         <hash>: Likewise.
4173         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4174         <isa_features>: ...this.
4175         <abi_features>: New field.
4176         (riscv_isa_flen): Update comment.
4177         (riscv_abi_xlen): New declaration.
4178         (riscv_abi_flen): New declaration.
4179         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4180         isa_features.
4181         (riscv_abi_xlen): New function.
4182         (riscv_isa_flen): Update to get answer from isa_features.
4183         (riscv_abi_flen): New function.
4184         (riscv_has_fp_abi): Update to get answer from abi_features.
4185         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4186         xlen and flen.
4187         (riscv_call_info) <xlen, flen>: Update comment.
4188         (riscv_call_arg_struct): Remove invalid assertions
4189         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4190         is removed.
4191         (riscv_gdbarch_init): Gather isa features and abi features
4192         separately, ensure both match on the gdbarch when reusing an old
4193         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4194         a target with 64-bit float hardware.
4195
4196 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4197
4198         * source.c (search_command_helper): Stop reverse search
4199         when line 1 has been searched.
4200
4201 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4202
4203         * record-full.c (record_full_base_target::close): Rewrite
4204         record_full_core_buf_list free logic.
4205
4206 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4207
4208         * break-catch-syscall.c (print_one_catch_syscall): xfree
4209         the last text.
4210
4211 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4212
4213         * top.c (print_gdb_version): Update Copyright year in version
4214         message.
4215
4216 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4217
4218         Update copyright year range in all GDB files.
4219
4220 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4221
4222         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4223
4224 For older changes see ChangeLog-2018.
4225 \f
4226 Local Variables:
4227 mode: change-log
4228 left-margin: 8
4229 fill-column: 74
4230 version-control: never
4231 coding: utf-8
4232 End:
4233