gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-source.c (tui_source_window_base::reset): Remove
   4         win_type parameter.
   5         * tui/tui-layout.c (make_command_window, make_source_window)
   6         (make_disasm_window, make_data_window)
   7         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
   8         (reset_locator, show_source_or_disasm_and_command): Update.
   9         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
  10         win_type parameter.
  11         (struct tui_source_window_base) <reset>: Likewise.
  12
  13 2019-07-17  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-layout.c (show_source_disasm_command): Use
  16         reset_locator.
  17         (reset_locator): New function.
  18         (init_and_make_win): Remove.
  19         (show_source_or_disasm_and_command): Use reset_locator.
  20
  21 2019-07-17  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  24         condition.
  25         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  26         Remove condition.
  27         * tui/tui-source.c (tui_source_window_base::reset): New method.
  28         * tui/tui-layout.c (make_command_window): Don't call
  29         init_and_make_win.
  30         (make_source_window, make_disasm_window): Don't call
  31         make_source_or_disasm_window.
  32         (make_data_window): Don't call init_and_make_win.  Change calling
  33         convention.
  34         (show_source_disasm_command, show_data): Simplify.
  35         (make_source_or_disasm_window): Remove.
  36         (show_source_or_disasm_and_command): Simplify.
  37         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  38         (struct tui_source_window_base) <reset>: Likewise.
  39         <execution_info>: Remove initializer.
  40         * tui/tui-data.c (tui_source_window_base): Initialize
  41         execution_info.
  42
  43 2019-07-17  Tom Tromey  <tom@tromey.com>
  44
  45         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  46         variable.
  47
  48 2019-07-17  Tom Tromey  <tom@tromey.com>
  49
  50         * tui/tui.c (tui_rl_other_window): Update.
  51         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  52         superclass method first.  Always iterate over regs_content.
  53         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  54         method.
  55         * tui/tui-win.c (tui_set_focus_command): Update.
  56
  57 2019-07-17  Tom Tromey  <tom@tromey.com>
  58
  59         * tui/tui-win.c (tui_set_focus_command): Rename from
  60         tui_set_focus.  Call tui_enable.
  61         (tui_set_focus_command): Remove.
  62
  63 2019-07-17  Tom Tromey  <tom@tromey.com>
  64
  65         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  66         refresh_window.
  67         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
  68         touchwin.
  69         (tui_data_window::refresh_window): Call refresh_window on data
  70         items.  Always call superclass refresh_window.
  71         (tui_win_info::refresh): Remove.
  72         (tui_source_window_base::refresh_window): Update.
  73         (tui_refresh_all): Update.
  74         * tui/tui-layout.c (show_source_disasm_command): Remove call to
  75         refresh_window.
  76         (show_source_or_disasm_and_command): Likewise.
  77         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
  78         (struct tui_source_window_base) <refresh>: Likewise.
  79
  80 2019-07-17  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-winsource.c (tui_clear_source_content)
  83         (tui_show_source_content): Update.
  84         * tui/tui-source.c (tui_source_window::showing_source_p): Check
  85         whether content is empty.
  86         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
  87         Remove.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-winsource.c (tui_erase_source_content): Clear the
  92         window's contents.
  93         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
  94         * tui/tui-source.c (tui_set_source_content_nil): Remove.
  95
  96 2019-07-17  Tom Tromey  <tom@tromey.com>
  97
  98         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
  99         (struct tui_data_item_window): Update.
 100
 101 2019-07-17  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 104         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 105         defines.
 106
 107 2019-07-17  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-winsource.h (tui_erase_source_content)
 110         (tui_clear_source_content): Remove "display_prompt" parameter.
 111         * tui/tui-winsource.c (tui_update_source_window_as_is)
 112         (tui_update_source_windows_with_addr): Update.
 113         (tui_clear_source_content): Remove "display_prompt" parameter.
 114         (tui_erase_source_content): Likewise.  Simplify.
 115         (tui_show_source_content): Update.
 116         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 117         * tui/tui-stack.c (tui_show_frame_info): Update.
 118         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 119         Remove defines.
 120
 121 2019-07-17  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 124         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 125         parameter.
 126         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 127         parameter.
 128
 129 2019-07-17  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-winsource.c (tui_clear_source_content)
 132         (tui_show_source_content, tui_show_exec_info_content)
 133         (tui_clear_exec_info_content): Update.
 134         * tui/tui-stack.c (tui_show_locator_content): Update.
 135         (tui_show_frame_info): Update.
 136         * tui/tui-source.h (tui_source_window): Don't declare.
 137         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 138         from tui_source_is_displayed.
 139         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 140         Remove field.
 141         (struct tui_source_window_base) <content_in_use>: New field.  Now
 142         bool.
 143         (struct tui_source_window) <showing_source_p>: New method.
 144         (TUI_SRC_WIN): Change cast.
 145         * tui/tui-data.c (tui_initialize_static_data): Update.
 146
 147 2019-07-17  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 150         location_matches_p.
 151         * tui/tui-source.c (tui_source_window::location_matches_p): New
 152         method.
 153         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 154         method.
 155         * tui/tui-data.h (struct tui_source_window_base)
 156         <location_matches_p>: New method.
 157         (struct tui_source_window, struct tui_disasm_window)
 158         <location_matches_p>: Likewise.
 159
 160 2019-07-17  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-win.c (tui_set_win_height_command): Rename from
 163         tui_set_win_height.
 164         (tui_set_win_height_command): Remove.
 165
 166 2019-07-17  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-source.c (tui_source_window): New constructor.  Add
 169         observer.
 170         (~tui_source_window): New destructor.
 171         (tui_source_window::style_changed): New method.
 172         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 173         (tui_attach_detach_observers): Update.
 174         * tui/tui-data.h (struct tui_source_window): Make constructor not
 175         inline.  Add destructor.
 176         (struct tui_source_window) <style_changed>: New method.
 177         <m_observable>: New member.
 178
 179 2019-07-17  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 182         * tui/tui-win.c (tui_resize_all): Fix typo.
 183
 184 2019-07-17  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 187         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 188         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 189         * tui/tui-win.c (window_name_completer): Use foreach.
 190         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 191         (update_tab_width): Likewise.
 192         * tui/tui-layout.c (show_layout): Update.
 193         * tui/tui-data.h (class tui_window_iterator): New.
 194         (struct all_tui_windows): New.
 195         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 196
 197 2019-07-17  Tom Tromey  <tom@tromey.com>
 198
 199         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 200         parameter.  Don't reference globals.
 201         (tui_reg_command): Update.
 202
 203 2019-07-17  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-regs.c (tui_show_registers): Simplify.
 206
 207 2019-07-17  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-regs.c (tui_show_registers): Update.
 210         (tui_show_register_group): Add win_info parameter.
 211
 212 2019-07-17  Tom Tromey  <tom@tromey.com>
 213
 214         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 215         Rename from tui_display_reg_element_at_line.
 216         (tui_data_window::display_registers_from_line): Update.
 217         * tui/tui-data.h (struct tui_data_window)
 218         <display_reg_element_at_line>: New method.
 219
 220 2019-07-17  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-regs.h (tui_display_registers_from)
 223         (tui_display_registers_from_line): Don't declare.
 224         * tui/tui-windata.c (tui_data_window::display_all_data)
 225         (tui_data_window::refresh_all)
 226         (tui_data_window::do_scroll_vertical): Update.
 227         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 228         from tui_display_registers_from.
 229         (tui_display_reg_element_at_line): Update.
 230         (tui_data_window::display_registers_from_line): Rename from
 231         tui_display_registers_from_line.
 232         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 233         display_registers_from_line>: New methods.
 234
 235 2019-07-17  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 238         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 239         from tui_erase_data_content.
 240         (tui_data_window::display_all_data)
 241         (tui_data_window::refresh_all)
 242         (tui_data_window::do_scroll_vertical): Update.
 243         * tui/tui-regs.c (tui_show_registers): Update.
 244         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 245         New method.
 246
 247 2019-07-17  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 250         declare.
 251         * tui/tui-windata.c
 252         (tui_data_window::delete_data_content_windows): Rename from
 253         tui_delete_data_content_windows.
 254         (tui_data_window::display_all_data)
 255         (tui_data_window::do_scroll_vertical): Update.
 256         * tui/tui-data.h (struct tui_data_window)
 257         <delete_data_content_windows>: New method.
 258
 259 2019-07-17  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 262         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 263
 264 2019-07-17  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 267         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 268         from tui_display_all_data.
 269         * tui/tui-win.c
 270         (tui_data_window::do_make_visible_with_new_height): Update.
 271         * tui/tui-regs.c (tui_show_registers): Update.
 272         * tui/tui-layout.c (tui_set_layout): Update.
 273         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 274         method.
 275
 276 2019-07-17  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 279         * tui/tui-windata.c (tui_display_data_from): Remove.
 280         (tui_data_window::refresh_all): Update.
 281
 282 2019-07-17  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 285         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 286         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 287         tui_display_registers_from_line.
 288         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 289         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 290         "force_display" parameter.
 291
 292 2019-07-17  Tom Tromey  <tom@tromey.com>
 293
 294         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 295         declare.
 296         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 297         Rename from tui_first_reg_element_no_inline.
 298         (tui_display_reg_element_at_line)
 299         (tui_display_registers_from_line): Update.
 300         * tui/tui-data.h (struct tui_data_window)
 301         <first_reg_element_no_inline>: New method.
 302
 303 2019-07-17  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-windata.c (tui_display_data_from)
 306         (tui_data_window::do_scroll_vertical): Update.
 307         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 308         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 309         Rename from tui_line_from_reg_element_no.
 310         (tui_display_registers_from_line): Update.
 311         * tui/tui-data.h (struct tui_data_window)
 312         <line_from_reg_element_no>: New method.
 313
 314 2019-07-17  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 317         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 318         tui_last_regs_line_no.
 319         (tui_display_reg_element_at_line)
 320         (tui_display_registers_from_line): Update.
 321         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 322         method.
 323
 324 2019-07-17  Tom Tromey  <tom@tromey.com>
 325
 326         PR tui/24722:
 327         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 328         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 329         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 330         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 331         (tui_update_breakpoint_info): Likewise.
 332         * tui/tui-hooks.c (tui_event_create_breakpoint)
 333         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 334         Update.
 335
 336 2019-07-17  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 339
 340 2019-07-17  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-winsource.c (tui_update_source_window_as_is)
 343         (tui_update_source_windows_with_addr): Update.
 344         * tui/tui-source.h (tui_set_source_content)
 345         (tui_show_symtab_source): Add "win_info" parameter.
 346         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 347         parameter.
 348         (tui_show_symtab_source): Likewise.
 349
 350 2019-07-17  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-wingeneral.c
 353         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 354
 355 2019-07-17  Tom Tromey  <tom@tromey.com>
 356
 357         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 358         (struct tui_cmd_window) <can_scroll>: New method.
 359         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 360         method.
 361
 362 2019-07-17  Tom Tromey  <tromey@adacore.com>
 363
 364         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 365         do_field_signed>: Rename.  Change type of "value".
 366         * ui-out.c (ui_out::field_signed): Rename from field_int.
 367         Change type of "value".
 368         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 369         type of "value".
 370         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 371         do_field_int.  Change type of "value".
 372         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 373         do_field_int.  Change type of "value".
 374         * tracepoint.c (trace_status_mi, tfind_1)
 375         (print_one_static_tracepoint_marker): Update.
 376         * thread.c (print_thread_info_1, print_selected_thread_frame):
 377         Update.
 378         * stack.c (print_frame, print_frame_info): Update.
 379         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 380         Update.
 381         * source.c (print_source_lines_base): Update.
 382         * skip.c (info_skip_command): Update.
 383         * record-btrace.c (btrace_ui_out_decode_error)
 384         (btrace_call_history_src_line): Update.
 385         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 386         Update.
 387         * progspace.c (print_program_space): Update.
 388         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 389         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 390         do_field_int.  Change type of "value".
 391         * mi/mi-out.c (mi_ui_out::do_table_begin)
 392         (mi_ui_out::do_table_header): Update.
 393         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 394         type of "value".
 395         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 396         (mi_cmd_data_list_changed_registers, output_register)
 397         (mi_cmd_data_read_memory, mi_load_progress)
 398         (mi_cmd_trace_frame_collected): Update.
 399         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 400         Update.
 401         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 402         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 403         (mi_cmd_var_list_children, varobj_update_one): Update.
 404         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 405         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 406         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 407         * inferior.c (print_inferior): Update.
 408         * gdb_bfd.c (print_one_bfd): Update.
 409         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 410         Update.
 411         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 412         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 413         do_field_int.  Change type of "value".
 414         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 415         do_field_int.  Change type of "value".
 416         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 417         (print_one_breakpoint_location, print_it_catch_fork)
 418         (print_one_catch_fork, print_it_catch_vfork)
 419         (print_one_catch_vfork, print_it_catch_solib)
 420         (print_it_catch_exec, print_it_ranged_breakpoint)
 421         (print_mention_watchpoint, print_mention_masked_watchpoint)
 422         (bkpt_print_it, update_static_tracepoint): Update.
 423         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 424         * break-catch-syscall.c (print_it_catch_syscall): Update.
 425         * ada-tasks.c (print_ada_task_info): Update.
 426         * ada-lang.c (print_it_exception, print_mention_exception):
 427         Update.
 428
 429 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 430
 431         PR breakpoints/24541
 432         * gdbarch.c: Regenerate.
 433         * gdbarch.h: Regenerate.
 434         * gdbarch.sh: Adjust return type and parameter types for
 435         'stap_adjust_register'.
 436         (i386_stap_adjust_register): Adjust signature and return new
 437         register name.
 438         * stap-probe.c (stap_parse_register_operand): Adjust use of
 439         'gdbarch_stap_adjust_register'.
 440
 441 2019-07-17  Tom Tromey  <tromey@adacore.com>
 442
 443         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 444         declare VEC.
 445         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 446         std::vector.
 447         (struct s390_process_info): Add initializers.
 448         (s390_add_process): Use new.
 449         (s390_linux_nat_target::low_forget_process): Use delete.
 450         (s390_linux_nat_target::low_new_fork)
 451         (s390_linux_nat_target::stopped_by_watchpoint)
 452         (s390_linux_nat_target::low_prepare_to_resume)
 453         (s390_linux_nat_target::insert_watchpoint)
 454         (s390_linux_nat_target::insert_hw_breakpoint)
 455         (s390_linux_nat_target::remove_watchpoint)
 456         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 457
 458 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 459
 460         * aarch64-fbsd-nat.c: Include regcache.h.
 461         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 462         argument.
 463         (aarch64_fbsd_nat_target::fetch_registers)
 464         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 465         variable.
 466         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 467
 468 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 469
 470         * fbsd-nat.c: Include gdbarch.h.
 471
 472 2019-07-15  Tom Tromey  <tromey@adacore.com>
 473
 474         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 475
 476 2019-07-15  Tom Tromey  <tromey@adacore.com>
 477
 478         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 479         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 480         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 481         * cli-out.c (cli_ui_out::do_field_int): New method.
 482         * ui-out.c (ui_out::field_unsigned): New method.
 483         * symfile.c (generic_load): Use field_unsigned.
 484         (print_transfer_performance): Likewise.
 485         * record-btrace.c (ui_out_field_uint): Remove.
 486         (btrace_call_history_insn_range, btrace_call_history): Use
 487         field_unsigned.
 488         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 489         field_unsigned.
 490         * ui-out.h (class ui_out) <field_unsigned>: New method.
 491         <do_field_unsigned>: Likewise.
 492
 493 2019-07-15  Tom Tromey  <tromey@adacore.com>
 494
 495         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 496         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 497         * target.c (flash_erase_command): Use field_string.
 498         * infrun.c (print_signal_received_reason): Use field_string.
 499         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 500         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 501         field_string.
 502         * ada-tasks.c (print_ada_task_info): Use field_string.
 503
 504 2019-07-15  Tom Tromey  <tromey@adacore.com>
 505
 506         * target.c (flash_erase_command): Use field_core_addr.
 507         * symfile.c (generic_load): Use field_core_addr.
 508         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 509         Use field_core_addr.
 510         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 511         field_core_addr.
 512
 513 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 516         value if its desired type is smaller than a CORE_ADDR and signed.
 517
 518 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 519
 520         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 521         of changes to field names, and use new is_reference field to
 522         decide if a property is a reference or not.
 523         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 524         field.
 525         (struct dwarf2_property_baton): Update header comment, rename
 526         'referenced_type' to 'property_type' and update comments.
 527         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 528         default property type, store in property baton, update to take
 529         accound of renamed field.
 530         (read_func_scope): Update call to attr_to_dynamic_prop.
 531         (read_array_type): Likewise.
 532         (dwarf2_per_cu_addr_sized_int_type): New function.
 533         (read_subrange_index_type): Move type finding code to
 534         dwarf2_per_cu_addr_sized_int_type.
 535         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 536         (dwarf2_per_cu_addr_type): New function.
 537         (set_die_type): Update calls to attr_to_dynamic_prop.
 538
 539 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 540
 541         * dwarf2read.c (read_subrange_index_type): New function.
 542         (read_subrange_type): Move code into new function and call it.
 543         * gdbtypes.c (create_range_type): Add some asserts.
 544
 545 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 546
 547         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 548         update return statements.
 549         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 550         declaration, and update comment to match.
 551         * gdbtypes.c (resolve_dynamic_array): Update call to
 552         dwarf2_evaluate_property to match new return type.
 553
 554 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * valarith.c (value_subscripted_rvalue): Change lowerbound
 557         parameter type from int to LONGEST.
 558         * value.h (value_subscripted_rvalue): Likewise in declaration.
 559
 560 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * cli/cli-utils.c (info_print_command_completer): New function.
 563         * cli/cli-utils.h: Add 'completer.h' include, and forward
 564         declaration for 'struct cmd_list_element'.
 565         (info_print_command_completer): Declare.
 566         * stack.c (_initialize_stack): Add completer for 'info locals' and
 567         'info args'.
 568         * symtab.c (_initialize_symtab): Add completer for 'info
 569         variables' and 'info functions'.
 570         * NEWS: Mention completion for additional info commands.
 571
 572 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 573
 574         * cli/cli-utils.c (extract_info_print_args): Delete.
 575         (extract_arg_maybe_quoted): Delete.
 576         (info_print_options_defs): New variable.
 577         (make_info_print_options_def_group): New function.
 578         (extract_info_print_options): Define new function.
 579         * cli/cli-utils.h (extract_info_print_args): Delete.
 580         (struct info_print_options): New structure.
 581         (extract_info_print_options): Declare new function.
 582         * stack.c (info_locals_command): Update to use new
 583         extract_info_print_options, also add a header comment.
 584         (info_args_command): Likewise.
 585         * symtab.c (info_variables_command): Likewise.
 586         (info_functions_command): Likewise.
 587
 588 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 589
 590         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 591         to extract string arguments.
 592         * common/common-utils.c (extract_string_maybe_quoted): New function.
 593         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 594
 595 2019-07-11  Tom Tromey  <tromey@adacore.com>
 596
 597         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 598         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 599         * top.h (gdbinit): Don't declare.
 600         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 601         into...
 602         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 603         * top.c (gdb_init): Don't call init_cli_cmds.
 604         (gdbinit): Remove.
 605         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 606
 607 2019-07-11  Tom Tromey  <tromey@adacore.com>
 608
 609         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 610         after it has been moved.
 611
 612 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 613
 614         * valops.c (value_must_coerce_to_target): Change return type to
 615         bool.
 616         * value.h (value_must_coerce_to_target): Likewise.
 617
 618 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 619
 620         * breakpoint.c (is_hardware_watchpoint): Remove
 621         forward-declaration.
 622         (is_masked_watchpoint): Change return type to bool.
 623         (is_tracepoint): Likewise.
 624         (is_breakpoint): Likewise.
 625         (is_hardware_watchpoint): Likewise.
 626         (is_watchpoint): Likewise.
 627         (is_no_memory_software_watchpoint): Likewise.
 628         (is_catchpoint): Likewise.
 629         (breakpoint_1): Make FILTER parameter's return type bool.
 630         is_masked_watchpoint): Change return type to bool.
 631         (save_breakpoints): Make FILTER parameter's return type bool.
 632         * breakpoint.h (is_breakpoint): Change return type to bool.
 633         (is_watchpoint): Likewise.
 634         (is_catchpoint): Likewise.
 635         (is_tracepoint): Likewise.
 636
 637 2019-07-10  Tom Tromey  <tom@tromey.com>
 638
 639         * defs.h: Don't include gdbarch.h.
 640         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 641         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 642         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 643         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 644         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 645         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 646         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 647         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 648         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 649         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 650         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 651         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 652         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 653         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 654         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 655         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 656         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 657         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 658         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 659         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 660         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 661         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 662         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 663         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 664         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 665         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 666         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 667
 668 2019-07-10  Tom Tromey  <tromey@adacore.com>
 669
 670         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 671         * breakpoint.c (init_ada_exception_breakpoint): Register as
 672         bp_catchpoint.
 673         (print_one_breakpoint_location, print_one_breakpoint): Use
 674         is_ada_exception_catchpoint.
 675         * ada-lang.c (class ada_catchpoint_location): Pass
 676         bp_loc_software_breakpoint to bp_location constructor.
 677         (is_ada_exception_catchpoint): New function.
 678
 679 2019-07-10  Tom Tromey  <tromey@adacore.com>
 680
 681         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 682         VEC.
 683         (struct arm_exidx_entry): New method operator<.
 684         (struct arm_exidx_data) <section_maps>: Change type.
 685         (arm_exidx_data_free): Remove.
 686         (arm_exidx_data_key): Change type.  Move lower.
 687         (arm_exidx_new_objfile): Update.
 688         (arm_compare_exidx_entries): Remove.
 689         (arm_find_exidx_entry, _initialize_arm_tdep)
 690
 691 2019-07-10  Tom Tromey  <tromey@adacore.com>
 692
 693         * solib-spu.c (ocl_program_data_key): Change type.
 694         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 695         Update.
 696
 697 2019-07-10  Tom Tromey  <tromey@adacore.com>
 698
 699         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 700         (struct solib_aix_inferior_data) <library_list>: Change type.
 701         (solib_aix_inferior_data_handle): Change type.
 702         (get_solib_aix_inferior_data): Update.
 703         (solib_aix_free_library_list): Remove.
 704         (library_list_start_library): Update.
 705         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 706         return type.
 707         (solib_aix_get_library_list)
 708         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 709         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 710
 711 2019-07-10  Tom Tromey  <tromey@adacore.com>
 712
 713         * solib-dsbt.c (struct dsbt_info): Add initializers.
 714         (solib_dsbt_pspace_data): Change type.
 715         (dsbt_pspace_data_cleanup): Remove.
 716         (get_dsbt_info, _initialize_dsbt_solib): Update.
 717
 718 2019-07-10  Tom Tromey  <tromey@adacore.com>
 719
 720         * spu-tdep.c (spu_overlay_data): Change type.
 721         (spu_get_overlay_table, spu_overlay_new_objfile)
 722         (_initialize_spu_tdep): Update.
 723
 724 2019-07-10  Tom Tromey  <tromey@adacore.com>
 725
 726         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 727         destructor.
 728         (dbx_objfile_data_key): Change type and declare later.
 729         (DBX_SYMFILE_INFO): Rewrite.
 730         * dbxread.c (dbx_objfile_data_key): Change type.
 731         (dbx_symfile_init): Update.
 732         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 733         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 734         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 735
 736 2019-07-10  Tom Tromey  <tromey@adacore.com>
 737
 738         * jit.c (jit_program_space_key): Change type.  Move lower.
 739         (get_jit_program_space_data): Update.
 740         (jit_program_space_data_cleanup): Remove.
 741         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 742         Update.
 743         (struct jit_program_space_data): Add initializers.
 744
 745 2019-07-10  Tom Tromey  <tromey@adacore.com>
 746
 747         * solib-darwin.c (struct darwin_info): Add initializers.
 748         (solib_darwin_pspace_data): Change type.
 749         (darwin_pspace_data_cleanup): Remove.
 750         (get_darwin_info, _initialize_darwin_solib): Update.
 751
 752 2019-07-10  Tom Tromey  <tromey@adacore.com>
 753
 754         * remote-sim.c (struct sim_inferior_data): Add initializers,
 755         constructor, and destructor.
 756         (sim_inferior_data_key): Change type.  Move lower.
 757         (check_for_duplicate_sim_descriptor): Update.
 758         (get_sim_inferior_data): Use new.  Update.
 759         (~sim_inferior_data_cleanup): Rename from
 760         sim_inferior_data_cleanup.  Simplify.
 761         (gdbsim_close_inferior, simulator_command)
 762         (sim_command_completer, _initialize_remote_sim): Update.
 763         (next_pid, INITIAL_PID): Move earlier.
 764
 765 2019-07-10  Tom Tromey  <tromey@adacore.com>
 766
 767         * python/python-internal.h (create_thread_object): Return
 768         gdbpy_ref.
 769         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 770         * python/py-inferior.c (struct threadlist_entry): Add
 771         constructor.
 772         <thread_obj>: Now a gdbpy_ref.
 773         (thread_to_thread_object): Update.
 774         (add_thread_object): Use new.
 775         (delete_thread_object): Use delete.
 776         (infpy_threads): Update.
 777         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 778         GIL.
 779
 780 2019-07-10  Tom Tromey  <tromey@adacore.com>
 781
 782         * valops.c (value_cast): Specialize error message for Ada.
 783
 784 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 785
 786         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 787
 788 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 789
 790         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 791         bpstat_should_step): Return bool, adjust comments.
 792         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 793         bpstat_should_step): Likewise.
 794
 795 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 796
 797         * features/Makefile: Use feature target descriptions for Arm.
 798         * features/arm/arm-core.c: Generate new file.
 799         * features/arm/arm-fpa.c: Likewise.
 800         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 801         * features/arm/arm-m-profile.c: Likewise.
 802         * features/arm/arm-vfpv2.c: Likewise.
 803         * features/arm/arm-vfpv3.c: Likewise.
 804         * features/arm/xscale-iwmmxt.c: Likewise.
 805         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 806
 807 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 808
 809         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 810         ptrace earlier.
 811
 812 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 813
 814         * features/aarch64-pauth.c: Regenerate.
 815
 816 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 817
 818         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 819         bool.
 820         (bpstat_what): Use false instead of 0.
 821
 822 2019-07-09  Pedro Alves  <palves@redhat.com>
 823
 824         * break-catch-throw.c (is_exception_catchpoint): New.
 825         * breakpoint.c (print_one_breakpoint_location): New parameter
 826         'raw_loc'.  Handle it.  Use
 827         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 828         looking at the breakpoint's type.
 829         (print_one_breakpoint): If handling "maint info breakpoints", also
 830         print locations of exception catchpoints.
 831         * breakpoint.h (is_exception_catchpoint): Declare.
 832
 833 2019-07-09  Pedro Alves  <palves@redhat.com>
 834
 835         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 836         "addr" field.
 837         (allocate_location_exception_catchpoint): New.
 838         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 839         (initialize_throw_catchpoint_ops): Install
 840         allocate_location_exception_catchpoint as allocate_location
 841         method.
 842         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 843         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 844         bp_loc_other.
 845         (breakpoint_address_is_meaningful): Delete.
 846         (bl_address_is_meaningful): New.
 847         (breakpoint_locations_match): Adjust comment.
 848         (bp_location_from_bp_type): New, factored out of...
 849         (bp_location::bp_location(breakpoint *)): ... this.
 850         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 851         factored out of...
 852         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 853         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 854         breakpoint_address_is_meaningful.
 855         (bp_locations_compare): Adjust comment.
 856         (update_global_location_list): Use bl_address_is_meaningful
 857         instead of breakpoint_address_is_meaningful.
 858         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 859         explicit.
 860         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 861         * python/py-breakpoint.c (bppy_get_location): No longer check
 862         whether location is null.
 863
 864 2019-07-09  Pedro Alves  <palves@redhat.com>
 865
 866         PR c++/15468
 867         * breakpoint.c (print_one_breakpoint_location): Remove
 868         single-location assert.
 869
 870 2019-07-09  Tom Tromey  <tom@tromey.com>
 871
 872         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 873         * configure: Rebuild.
 874         * configure.ac: Change common to gdbsupport.
 875         * gdbsupport: Rename from common.
 876         * acinclude.m4: Change common to gdbsupport.
 877         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 878         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 879         gdbsupport.
 880         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 881         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 882         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 883         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 884         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 885         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 886         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 887         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 888         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 889         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 890         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 891         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 892         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 893         coff-pe-read.c, command.h, compile/compile-c-support.c,
 894         compile/compile-c.h, compile/compile-cplus-symbols.c,
 895         compile/compile-cplus-types.c, compile/compile-cplus.h,
 896         compile/compile-loc2c.c, compile/compile.c, completer.c,
 897         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 898         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 899         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 900         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 901         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 902         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 903         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 904         features/aarch64-core.c, features/aarch64-fpu.c,
 905         features/aarch64-pauth.c, features/aarch64-sve.c,
 906         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 907         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 908         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 909         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 910         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 911         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 912         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 913         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 914         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 915         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 916         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 917         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 918         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 919         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 920         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 921         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 922         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 923         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 924         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 925         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 926         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 927         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 928         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 929         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 930         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 931         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 932         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 933         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 934         minsyms.c, mips-linux-tdep.c, namespace.h,
 935         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 936         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 937         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 938         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 939         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 940         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 941         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 942         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 943         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 944         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 945         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 946         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 947         procfs.c, producer.c, progspace.h, psymtab.h,
 948         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 949         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 950         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 951         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 952         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 953         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 954         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 955         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 956         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 957         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 958         target-memory.c, target.c, target.h, target/waitstatus.c,
 959         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 960         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 961         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 962         unittests/array-view-selftests.c,
 963         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 964         unittests/common-utils-selftests.c,
 965         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 966         unittests/format_pieces-selftests.c,
 967         unittests/function-view-selftests.c,
 968         unittests/lookup_name_info-selftests.c,
 969         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 970         unittests/mkdir-recursive-selftests.c,
 971         unittests/observable-selftests.c,
 972         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 973         unittests/parse-connection-spec-selftests.c,
 974         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 975         unittests/scoped_fd-selftests.c,
 976         unittests/scoped_mmap-selftests.c,
 977         unittests/scoped_restore-selftests.c,
 978         unittests/string_view-selftests.c, unittests/style-selftests.c,
 979         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 980         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 981         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 982         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 983         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 984         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 985
 986 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 987
 988         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 989         bool value.
 990         (decode_digits_ordinary): Set explicit_line field in sal.
 991         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 992         symtab_and_line that was set on an explicit line number in
 993         assembler code.  Do always update the recorded symtab and line if
 994         we do skip the prologue.
 995
 996 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 997
 998         * breakpoint.c (set_breakpoint_location_function): Remove
 999         explicit_loc parameter.
1000         (momentary_breakpoint_from_master): Update call to
1001         set_breakpoint_location_function.
1002         (add_location_to_breakpoint): Likewise.
1003
1004 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1005
1006         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1007         required features based on default bfd type when no specific bfd
1008         is present.
1009
1010 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1011
1012         * NEWS: Mention that GDB printf and eval commands can now print
1013         C-style and Ada-style convenience var strings without
1014         calling the inferior.
1015         * printcmd.c (printf_c_string): Locally print GDB internal var
1016         instead of transiting via the inferior.
1017         (printf_wide_c_string): Likewise.
1018
1019 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1020
1021         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1022
1023 2019-07-04  Tom Tromey  <tom@tromey.com>
1024
1025         PR tui/24724:
1026         * tui/tui-winsource.c (tui_clear_source_content): Update.
1027         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1028         (tui_update_breakpoint_info): Update.
1029         (tui_set_exec_info_content): Update.
1030         * tui/tui-source.c (tui_set_source_content_nil): Update.
1031         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1032         has_break.
1033         * tui/tui-data.h (enum tui_bp_flag): New.
1034         (tui_bp_flags): New enum flags type.
1035         (struct tui_source_element) <break_mode>: Change type.  Rename
1036         from has_break.
1037         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1038         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1039         constants.
1040         * tui/tui-winsource.h: Fix comment.
1041
1042 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1043
1044         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1045         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1046         (store_fpregs_to_thread)
1047         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1048         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1049         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1050         (IWMMXT_REGS_SIZE): Add define.
1051         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1052         (fetch_vfp_regs, store_vfp_regs)
1053         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1054         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1055
1056 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1057
1058         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1059         defines.
1060         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1061         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1062         (ARM_INT_REGISTER_SIZE): ...to this.
1063         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1064         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1065         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1066         (arm_linux_collect_gregset, supply_nwfpe_register)
1067         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1068         defines.
1069         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1070         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1071         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1072         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1073         (arm_return_in_memory, arm_store_return_value)
1074         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1075         (arm_record_ld_st_multiple): Likewise.
1076         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1077         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1078
1079 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1080
1081         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1082         AARCH64_DISPLACED_MODIFIED_INSNS.
1083         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1084         (aarch64_displaced_step_copy_insn): Likewise.
1085         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1086         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1087         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1088         ARM_DISPLACED_MODIFIED_INSNS.
1089         * arm-tdep.c (arm_gdbarch_init): Likewise.
1090         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1091         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1092         (struct arm_displaced_step_closure): Use
1093         ARM_DISPLACED_MODIFIED_INSNS.
1094
1095 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1096
1097         * features/Makefile: Remove unused xml files.
1098         * features/aarch64.xml: Remove.
1099         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1100         * features/i386/amd64-avx-avx512.xml: Remove.
1101         * features/i386/amd64-avx-linux.xml: Remove.
1102         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1103         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1104         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1105         * features/i386/amd64-avx-mpx.xml: Remove.
1106         * features/i386/amd64-avx.xml: Remove.
1107         * features/i386/amd64-linux.xml: Remove.
1108         * features/i386/amd64-mpx-linux.xml: Remove.
1109         * features/i386/amd64-mpx.xml: Remove.
1110         * features/i386/amd64.xml: Remove.
1111         * features/i386/i386-avx-avx512-linux.xml: Remove.
1112         * features/i386/i386-avx-avx512.xml: Remove.
1113         * features/i386/i386-avx-linux.xml: Remove.
1114         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1115         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1116         * features/i386/i386-avx-mpx-linux.xml: Remove.
1117         * features/i386/i386-avx-mpx.xml: Remove.
1118         * features/i386/i386-avx.xml: Remove.
1119         * features/i386/i386-linux.xml: Remove.
1120         * features/i386/i386-mmx-linux.xml: Remove.
1121         * features/i386/i386-mmx.xml: Remove.
1122         * features/i386/i386-mpx-linux.xml: Remove.
1123         * features/i386/i386-mpx.xml: Remove.
1124         * features/i386/i386.xml: Remove.
1125         * features/i386/x32-avx-avx512-linux.xml: Remove.
1126         * features/i386/x32-avx-linux.xml: Remove.
1127         * features/i386/x32-linux.xml: Remove.
1128
1129 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1130
1131         * regformats/aarch64.dat: Remove.
1132         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1133         * regformats/i386/amd64-avx-linux.dat: Remove.
1134         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1135         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1136         * regformats/i386/amd64-linux.dat: Remove.
1137         * regformats/i386/amd64-mpx-linux.dat: Remove.
1138         * regformats/i386/amd64.dat: Remove.
1139         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1140         * regformats/i386/i386-avx-linux.dat: Remove.
1141         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1142         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1143         * regformats/i386/i386-linux.dat: Remove.
1144         * regformats/i386/i386-mmx-linux.dat: Remove.
1145         * regformats/i386/i386-mpx-linux.dat: Remove.
1146         * regformats/i386/i386.dat: Remove.
1147         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1148         * regformats/i386/x32-avx-linux.dat: Remove.
1149         * regformats/i386/x32-linux.dat: Remove.
1150
1151 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1152
1153         * aarch64-tdep.c: Remove xml self tests.
1154         * amd64-linux-tdep.c: Likewise.
1155         * amd64-tdep.c: Likewise.
1156         * i386-linux-tdep.c: Likewise.
1157         * i386-tdep.c: Likewise.
1158
1159 2019-07-03  Pedro Alves  <palves@redhat.com>
1160
1161         PR cli/24732
1162         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1163         (pipe_cmd_option_defs): New.
1164         (make_pipe_cmd_options_def_group): New.
1165         (pipe_command): Use gdb::option::process_options.
1166         (pipe_command_completer): New function.
1167         (_initialize_cli_cmds): Install completer for "pipe" command.
1168
1169 2019-07-03  Pedro Alves  <palves@redhat.com>
1170
1171         * cli/cli-option.c (union option_value) <string>: New field.
1172         (struct option_def_and_value): Add ctor, move ctor, dtor and
1173         use DISABLE_COPY_AND_ASSIGN.
1174         (option_def_and_value::clear_value): New.
1175         (parse_option, save_option_value_in_ctx, get_val_type_str)
1176         (add_setshow_cmds_for_options): Handle var_string.
1177         * cli-option.h (union option_def::var_address) <string>: New
1178         field.
1179         (struct string_option_def): New.
1180         * maint-test-options.c (struct test_options_opts): Add default
1181         ctor and use DISABLE_COPY_AND_ASSIGN.
1182         <string_opt>: New field.
1183         (test_options_opts::~test_options_opts): New.
1184         (test_options_opts::dump): Also dump "-string".
1185         (test_options_option_defs): Install "string.
1186
1187 2019-07-03  Pedro Alves  <palves@redhat.com>
1188
1189         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1190         option_value with a null enumeration.
1191         (complete_options): Save the option values in the context.
1192         (save_option_value_in_ctx): New, factored out from ...
1193         (process_options): ... here.
1194         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1195         of the function.
1196         * maint-test-options.c (test_options_opts::dump): New, factored
1197         out from ...
1198         (maintenance_test_options_command_mode): ... here.
1199         (maintenance_test_options_command_completion_result): Delete.
1200         (maintenance_test_options_command_completion_text): Update
1201         comment.
1202         (maintenance_show_test_options_completion_result): Change
1203         prototype.  Just print
1204         maintenance_test_options_command_completion_text.
1205         (save_completion_result): New.
1206         (maintenance_test_options_completer_mode): Pass options context to
1207         complete_options, and then save a dump.
1208         (_initialize_maint_test_options): Use add_cmd to install "maint
1209         show test-options-completion-result".
1210
1211 2019-07-03  Pedro Alves  <palves@redhat.com>
1212
1213         * NEWS (New commands): Mention "with" and "maint with".
1214         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1215         (with_command, with_command_completer): New.
1216         (pipe_command): Adjust to new repeat_previous
1217         interface.
1218         (_initialize_cli_cmds): Install the "with" command and its "w"
1219         alias.
1220         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1221         declarations.
1222         * cli/cli-setshow.c (parse_cli_var_uinteger)
1223         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1224         argument strings for all var_types.
1225         (get_setshow_command_value_string): New, factored out from ...
1226         (do_show_command): ... this.
1227         * cli/cli-setshow.h: Include <string>.
1228         (get_setshow_command_value_string): Declare.
1229         * command.h (repeat_previous): Now returns const char *.  Adjust
1230         comment.
1231         * maint.c: Include "cli/cli-cmds.h".
1232         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1233         (_initialize_maint_cmds): Register the "maintenance with" command.
1234         * top.c (repeat_previous): Move bits from pipe_command here:
1235         Return the saved command line, if any; error out if there's no
1236         command to relaunch.
1237
1238 2019-07-03  Pedro Alves  <palves@redhat.com>
1239
1240         * NEWS (New commands): Mention "maint set/show test-settings"
1241         instead of "maint test-settings".
1242         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1243         (maintenance_test_settings_set_list): Rename to ...
1244         (maintenance_set_test_settings_list): ... this.
1245         (maintenance_test_settings_show_list): Rename to  ...
1246         (maintenance_show_test_settings_list): ... this.
1247         (maintenance_test_settings_cmd): Delete.
1248         (maintenance_test_settings_set_cmd): ...
1249         (maintenance_set_test_settings_cmd): ... this.
1250         (maintenance_test_settings_show_cmd): ...
1251         (maintenance_show_test_settings_cmd): ... this.
1252         (maintenance_test_settings_show_value_cmd):
1253         (maintenance_show_test_settings_value_cmd): ... this.
1254         (_initialize_maint_test_settings): No longer install the "maint
1255         test-settings" prefix command.  Rename "maint test-settings set"
1256         to "maint set test-settings", and "maint test-settings show" to
1257         "maint show test-settings".  Adjust all subcommands.
1258
1259 2019-07-03  Pedro Alves  <palves@redhat.com>
1260
1261         * maint-test-settings.c: Fix file's intro comment.  Replace all
1262         references to "test-options" with references to "test-settings",
1263         in comments.
1264
1265 2019-07-03  Pedro Alves  <palves@redhat.com>
1266
1267         * maint-test-settings.c (maintenance_test_settings_xxx)
1268         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1269         New.
1270         (maintenance_test_settings_enums): Use them.
1271         (maintenance_test_settings_enum): Default to
1272         maintenance_test_settings_xxx.
1273         (_initialize_maint_test_settings): Initialize
1274         MAINTENANCE_TEST_SETTINGS_FILENAME.
1275
1276 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1277
1278         * breakpoint.h (remove_breakpoints_inf): Change return type to
1279         void, move function documentation here.
1280         * breakpoint.c (remove_breakpoints_inf): Change return type to
1281         void, move function documentation to header.
1282
1283 2019-07-02  Pedro Alves  <palves@redhat.com>
1284
1285         * NEWS (Completion improvements): Mention "info threads".
1286         * thread.c (struct info_threads_opts, info_threads_option_defs)
1287         (make_info_threads_options_def_group): New.
1288         (info_threads_command): Use gdb::option::process_options.
1289         (info_threads_command_completer): New.
1290         (_initialize_thread): Use gdb::option::build_help to build the
1291         help text for "info threads".
1292
1293 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1294
1295         * defs.h (generic_load): Move from here...
1296         * symfile.h (generic_load): ... to here.  Rename name parameter
1297         to args.
1298         * symfile.c (generic_load): Add comment.
1299
1300 2019-07-01  Tom Tromey  <tromey@adacore.com>
1301
1302         * dwarf2read.c
1303         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1304         declaration of without_params.  Fix formatting.
1305
1306 2019-07-01  Tom Tromey  <tromey@adacore.com>
1307
1308         * ada-exp.y (find_primitive_type): Update.
1309         * ada-lang.h (ada_lookup_symbol): Update.
1310         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1311         parameter.
1312         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1313
1314 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1315
1316         PR breakpoints/24541
1317         * gdbarch.c: Regenerate.
1318         * gdbarch.h: Regenerate.
1319         * gdbarch.sh: Add 'stap_adjust_register'.
1320         * i386-tdep.c: Include '<unordered_set>'.
1321         (i386_stap_adjust_register): New function.
1322         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1323         * stap-probe.c (stap_parse_register_operand): Call
1324         'gdbarch_stap_adjust_register'.
1325
1326 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1327
1328         PR python/24742
1329         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1330         * python/python.c (do_start_initialization): Use 'xmalloc'
1331         instead of 'PyMem_Malloc'.
1332
1333 2019-06-28  Tom Tromey  <tromey@adacore.com>
1334
1335         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1336         for Ada.
1337
1338 2019-06-27  Tom Tromey  <tromey@adacore.com>
1339
1340         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1341         objfile_key.
1342         (arm_find_mapping_symbol, arm_record_special_symbol)
1343         (_initialize_arm_tdep): Update.
1344         (arm_objfile_data_free): Remove.
1345
1346 2019-06-27  Tom Tromey  <tromey@adacore.com>
1347
1348         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1349         to cp_print_static_field.
1350
1351 2019-06-26  Tom Tromey  <tromey@adacore.com>
1352
1353         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1354         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1355         declare.
1356
1357 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1358
1359         * features/aarch64-core.c (create_feature_aarch64_core):
1360         Regenerate.
1361         * features/aarch64-core.xml: Add cpsr flags.
1362
1363 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1364
1365         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1366         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1367
1368 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1369
1370         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1371         field.
1372         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1373         use.
1374         (arm_record_special_symbol): Don't insert new symbol in sorted
1375         position, push it at the end.
1376
1377 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1378
1379         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1380         (arm_mapping_symbol_s): Remove.
1381         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1382         (arm_mapping_symbol_vec): New typedef.
1383         (struct arm_per_objfile): Add constructor.
1384         <section_maps>: Change type to
1385         std::unique_ptr<arm_mapping_symbol_vec[]>.
1386         (arm_compare_mapping_symbols): Remove.
1387         (arm_find_mapping_symbol): Adjust to section_maps type change.
1388         (arm_objfile_data_free): Call delete on arm_per_objfile.
1389         (arm_record_special_symbol): Adjust to section_maps type change.
1390         Allocate arm_per_objfile with new.
1391
1392 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1393
1394         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1395         with the command prefix.
1396
1397 2019-06-25  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1400         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1401
1402 2019-06-25  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1405         type.
1406         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1407         protected.
1408
1409 2019-06-25  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-winsource.c
1412         (tui_source_window_base::set_is_exec_point_at): Add check against
1413         LOA_ADDRESS.
1414
1415 2019-06-25  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-source.c (tui_set_source_content): Don't check before
1418         xfree.
1419         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1420
1421 2019-06-25  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-winsource.h (tui_update_source_window_as_is)
1424         (tui_alloc_source_buffer, tui_line_is_displayed)
1425         (tui_addr_is_displayed): Change type of win_info.
1426         * tui/tui-winsource.c (tui_update_source_window_as_is)
1427         (tui_clear_source_content, tui_show_source_line)
1428         (tui_show_source_content, tui_source_window_base::refill)
1429         (tui_source_window_base::set_is_exec_point_at)
1430         (tui_source_window_base::set_is_exec_point_at)
1431         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1432         (tui_alloc_source_buffer, tui_line_is_displayed)
1433         (tui_addr_is_displayed): Change type of win_info.  Update.
1434         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1435         (tui_source_window_base::do_make_visible_with_new_height):
1436         Update.
1437         * tui/tui-source.c (tui_set_source_content)
1438         (tui_set_source_content_nil)
1439         (tui_source_window::do_scroll_vertical): Update.
1440         * tui/tui-layout.c (show_layout): Update.
1441         * tui/tui-disasm.c (tui_set_disassem_content)
1442         (tui_disasm_window::do_scroll_vertical): Update.
1443         * tui/tui-data.h (tui_win_content): Remove.
1444         (struct tui_gen_win_info) <content, content_size>: Remove.
1445         (struct tui_source_element): Add initializers and destructor.
1446         (union tui_which_element, struct tui_win_element): Remove.
1447         (struct tui_source_window_base) <content>: New field.
1448         (struct tui_data_window): Remove destructor.
1449         (tui_alloc_content, tui_free_win_content)
1450         (tui_free_all_source_wins_content): Don't declare.
1451         * tui/tui-data.c (tui_initialize_static_data): Update.
1452         (init_content_element, tui_alloc_content): Remove.
1453         (~tui_gen_win_info): Update.
1454         (~tui_data_window, tui_free_all_source_wins_content)
1455         (tui_free_win_content, free_content, free_content_elements):
1456         Remove.
1457
1458 2019-06-25  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-winsource.h (tui_clear_source_content)
1461         (tui_erase_source_content, tui_show_source_content): Change type
1462         of win_info.
1463         * tui/tui-winsource.c (tui_clear_source_content)
1464         (tui_erase_source_content, tui_show_source_content): Change type
1465         of win_info.
1466         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1467         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1468         win_info.
1469         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1470         win_info.
1471         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1472
1473 2019-06-25  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-winsource.c (tui_clear_source_content)
1476         (tui_source_window_base::set_is_exec_point_at): Update.
1477         * tui/tui-source.c (tui_set_source_content_nil): Update.
1478         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1479         a bool.
1480         * tui/tui-data.c (init_content_element): Update.
1481
1482 2019-06-25  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1485         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1486         * tui/tui-layout.c (init_and_make_win): Update.
1487         * tui/tui.h (enum tui_win_type): Update.
1488         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1489         tui_win_is_auxillary.
1490         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1491         tui_win_is_auxillary.
1492
1493 2019-06-25  Tom Tromey  <tom@tromey.com>
1494
1495         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1496         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1497         (tui_delete_data_content_windows, tui_display_all_data)
1498         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1499         Update.
1500         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1501         * tui/tui-regs.c (tui_last_regs_line_no)
1502         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1503         (tui_show_registers): Update.
1504         (tui_show_register_group): Return void.  Update.
1505         (tui_display_registers_from, tui_display_reg_element_at_line)
1506         (tui_display_registers_from_line, tui_check_register_values):
1507         Update.
1508         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1509         member.
1510         (struct tui_data_window) <regs_content>: Now a std::vector.
1511         <regs_content_count>: Remove.
1512         (tui_add_content_elements, tui_free_data_content): Don't declare.
1513         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1514         (init_content_element): Remove DATA_WIN case.  Add assert.
1515         (tui_add_content_elements): Remove.
1516         (tui_data_window): Update.
1517         (tui_free_data_content): Remove.
1518         (free_content_elements): Remove DATA_WIN case.
1519
1520 2019-06-25  Tom Tromey  <tom@tromey.com>
1521
1522         * tui/tui-data.c (tui_data_item_window): Update.
1523         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1524         * tui/tui-windata.c (tui_display_all_data)
1525         (tui_display_data_from_line): Update.
1526         (tui_check_data_values): Remove.
1527         * tui/tui-regs.c (tui_show_register_group)
1528         (tui_display_reg_element_at_line): Update.
1529         * tui/tui-hooks.c (tui_register_changed)
1530         (tui_refresh_frame_and_register_information): Call
1531         tui_check_register_values.
1532         * tui/tui-data.h (struct tui_data_window) <data_content,
1533         data_content_count, data_type>: Remove.
1534         (enum tui_data_type): Remove.
1535
1536         * tui/tui-data.c (tui_data_window::clear_detail)
1537         (~tui_data_window): Update.
1538
1539 2019-06-25  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1542         declare.
1543         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1544         Rename from tui_first_data_item_displayed.  Update.
1545         (tui_data_window::refresh_all)
1546         (tui_data_window::do_scroll_vertical): Update.
1547         * tui/tui-data.h (struct tui_data_window)
1548         <first_data_item_displayed>: Declare new method.
1549
1550 2019-06-25  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1553         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1554         contents...
1555         (tui_initialize_static_data): ...here.
1556
1557 2019-06-25  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1560         (tui_display_registers_from, tui_check_register_values): Update.
1561         (tui_display_register): Remove win_info parameter; update.
1562         (tui_get_register): Change type of parameters.
1563         * tui/tui-data.h (struct tui_data_element): Remove.
1564         (union tui_which_element) <data>: Remove.
1565         <data_window>: Change type.
1566         (struct tui_data_item_window): New.
1567         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1568         case.  Add assert.
1569         (~tui_data_item_window): New destructor.
1570         (free_content_elements): Remove DATA_ITEM_WIN case.
1571
1572 2019-06-25  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1575         Remove.
1576
1577 2019-06-25  Tom Tromey  <tom@tromey.com>
1578
1579         * tui/tui-data.h (struct tui_command_element): Remove.
1580         (union tui_which_element) <command>: Remove.
1581         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1582         assert.
1583         (free_content_elements): Remove CMD_WIN case.
1584
1585 2019-06-25  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-layout.c (tui_set_layout): Update.
1588         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1589         * tui/tui-data.c (layout_def): Update.
1590
1591 2019-06-25  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1594         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1595         (tui_source_window_base::set_new_height): Update.
1596         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1597         Update.
1598         (tui_set_locator_fullname, tui_set_locator_info)
1599         (tui_show_frame_info): Update.
1600         * tui/tui-source.c (tui_set_source_content)
1601         (tui_source_is_displayed): Update.
1602         * tui/tui-layout.c (show_source_disasm_command, show_data)
1603         (show_source_or_disasm_and_command): Update.
1604         * tui/tui-disasm.c (tui_set_disassem_content)
1605         (tui_get_begin_asm_address): Update.
1606         * tui/tui-data.h (struct tui_locator_element): Remove.
1607         (union tui_which_element) <locator>: Remove.
1608         (struct tui_locator_window): New.
1609         (tui_locator_win_info_ptr): Change return type.
1610         * tui/tui-data.c (_locator): Change type.
1611         (tui_locator_win_info_ptr): Change return type.
1612         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1613         (tui_alloc_content): Add assert.
1614
1615 2019-06-25  Tom Tromey  <tom@tromey.com>
1616
1617         * tui/tui-winsource.c
1618         (tui_exec_info_window::maybe_allocate_content): New method.
1619         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1620         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1621         (make_source_or_disasm_window): Add cast.
1622         * tui/tui-data.h (union tui_which_element) <simple_string>:
1623         Remove.
1624         (struct tui_source_info): New.
1625         (struct tui_source_window_base) <execution_info>: Change type.
1626         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1627         case, and add assert.
1628         (tui_alloc_content): Add assert.
1629
1630 2019-06-25  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1633         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1634         * tui/tui-data.c (tui_alloc_win_info): Remove.
1635
1636 2019-06-25  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1639         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1640         can_highlight.
1641
1642 2019-06-25  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1645         make_visible_with_new_height method.
1646         (tui_win_info::make_visible_with_new_height): New method.
1647         (tui_source_window_base::do_make_visible_with_new_height)
1648         (tui_data_window::do_make_visible_with_new_height)
1649         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1650         (make_visible_with_new_height): Remove.
1651         (tui_resize_all, tui_adjust_win_heights): Use
1652         make_visible_with_new_height method.
1653         * tui/tui-data.h (struct tui_win_info)
1654         <do_make_visible_with_new_height, make_visible_with_new_height>:
1655         New methods.
1656         (struct tui_source_window_base, struct tui_data_window)
1657         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1658         methods.
1659
1660 2019-06-25  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1663         method.
1664         (update_tab_width): Call update_tab_width method.
1665         * tui/tui-data.h (struct tui_win_info)
1666         (struct tui_source_window_base) <update_tab_width>: New methods.
1667
1668 2019-06-25  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1671         parameter.
1672         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1673         parameter.
1674         (tui_gen_win_info::make_visible): Update.
1675         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1676         parameter.
1677         * tui/tui-data.h (enum tui_box): New enum.
1678         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1679
1680 2019-06-25  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1683         init_and_make_win for EXEC_INFO_WIN.
1684         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1685         longer inline.
1686         (struct tui_win_info) <~tui_win_info>: Inline.
1687         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1688         Don't declare.
1689         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1690         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1691         Remove.
1692         (tui_initialize_static_data): Update.
1693         (~tui_gen_win_info): Handle more cleanup here.
1694         (~tui_source_window_base): Delete "execution_info".
1695         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1696
1697 2019-06-25  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-layout.c (make_command_window): Don't set
1700         can_highlight.
1701         (show_source_disasm_command): Call the reset method.
1702         (show_data): Don't set can_highlight.  Call the reset method.
1703         (tui_gen_win_info::reset): Rename from init_gen_win_info
1704         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1705         (show_source_or_disasm_and_command): Call the reset method.
1706         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1707         (struct tui_cmd_window): Set can_highlight.
1708
1709 2019-06-25  Tom Tromey  <tom@tromey.com>
1710
1711         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1712         from make_visible.
1713         (tui_make_visible, tui_make_invisible): Rewrite.
1714         (tui_win_info::make_visible): Remove.
1715         (tui_source_window_base::make_visible): Update.
1716         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1717         method.  Moved from...
1718         (struct tui_win_info) <make_visible>: ...here.
1719
1720 2019-06-25  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-winsource.c
1723         (tui_source_window_base::do_scroll_horizontal): Remove direction
1724         parameter.
1725         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1726         direction parameter.
1727         * tui/tui-win.c (tui_win_info::forward_scroll)
1728         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1729         (tui_win_info::right_scroll): Update.
1730         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1731         direction parameter.
1732         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1733         direction parameter.
1734         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1735         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1736         Remove direction parameter.
1737         (struct tui_source_window_base, struct tui_source_window)
1738         (struct tui_disasm_window, struct tui_data_window)
1739         (struct tui_cmd_window): Update.
1740
1741 2019-06-25  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-winsource.h (tui_set_exec_info_content)
1744         (tui_show_exec_info_content, tui_erase_exec_info_content)
1745         (tui_clear_exec_info_content, tui_update_exec_info): Change
1746         argument to tui_source_window_base.
1747         * tui/tui-winsource.c (tui_set_exec_info_content)
1748         (tui_show_exec_info_content, tui_erase_exec_info_content)
1749         (tui_clear_exec_info_content, tui_update_exec_info): Change
1750         argument to tui_source_window_base.
1751
1752 2019-06-25  Tom Tromey  <tom@tromey.com>
1753
1754         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1755         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1756
1757 2019-06-25  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1760         check.
1761
1762 2019-06-25  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1765         type to void.
1766         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1767         type to void.
1768         * tui/tui-source.c (tui_set_source_content): Update.
1769         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1770
1771 2019-06-25  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-win.c (window_name_completer, tui_set_focus)
1774         (tui_all_windows_info): Use name method.
1775         * tui/tui-data.h (struct tui_gen_win_info)
1776         (struct tui_source_window, struct tui_disasm_window)
1777         (struct tui_data_window, struct tui_cmd_window) <name>: New
1778         method.
1779         (tui_win_name): Don't declare.
1780         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1781         (tui_win_name): Remove.
1782
1783 2019-06-25  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-winsource.h (tui_update_source_window)
1786         (tui_update_source_window_as_is): Change parameter type.
1787         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1788         to be a tui_source_window_base.
1789         (tui_update_source_window_as_is): Likewise.
1790         * tui/tui-win.c (make_visible_with_new_height): Update.
1791
1792 2019-06-25  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-winsource.c (tui_erase_source_content)
1795         (tui_show_source_content, tui_show_exec_info_content)
1796         (tui_erase_exec_info_content): Use refresh_window method.
1797         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1798         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1799         from tui_refresh_win.
1800         (tui_data_window::refresh_window): New method.
1801         (tui_win_info::refresh, tui_source_window_base::refresh)
1802         (tui_refresh_all): Use refresh_window method.
1803         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1804         method.
1805         * tui/tui-regs.c (tui_display_register): Call refresh_window
1806         method.
1807         * tui/tui-layout.c (show_source_disasm_command)
1808         (show_source_or_disasm_and_command): Call refresh_window method.
1809         * tui/tui-data.h (struct tui_gen_win_info)
1810         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1811         New method.
1812
1813 2019-06-25  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui.c (tui_rl_other_window, tui_enable)
1816         (tui_is_window_visible, tui_get_command_dimension): Update.
1817         * tui/tui-winsource.c (tui_update_source_window_as_is)
1818         (tui_clear_source_content, tui_erase_source_content)
1819         (tui_show_source_line, tui_source_window_base::refill)
1820         (tui_source_window_base::do_scroll_horizontal)
1821         (tui_source_window_base::set_is_exec_point_at)
1822         (tui_update_breakpoint_info, tui_set_exec_info_content)
1823         (tui_alloc_source_buffer, tui_line_is_displayed)
1824         (tui_addr_is_displayed): Update.
1825         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1826         (tui_check_and_display_highlight_if_needed)
1827         (tui_win_info::make_visible, tui_win_info::refresh)
1828         (tui_refresh_all): Update.
1829         * tui/tui-windata.c (tui_first_data_item_displayed)
1830         (tui_delete_data_content_windows, tui_erase_data_content)
1831         (tui_display_all_data, tui_data_window::refresh_all)
1832         (tui_check_data_values): Update.
1833         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1834         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1835         (tui_win_info::backward_scroll, tui_refresh_all_win)
1836         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1837         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1838         (tui_source_window_base::set_new_height)
1839         (tui_data_window::set_new_height)
1840         (make_invisible_and_set_new_height)
1841         (make_visible_with_new_height, new_height_ok)
1842         (parse_scrolling_args): Update.
1843         * tui/tui-stack.c (tui_show_frame_info): Update.
1844         * tui/tui-source.c (tui_set_source_content)
1845         (tui_set_source_content_nil, tui_source_is_displayed)
1846         (tui_source_window::do_scroll_vertical): Update.
1847         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1848         (tui_display_registers_from, tui_display_reg_element_at_line)
1849         (tui_check_register_values, tui_reg_command): Update.
1850         * tui/tui-layout.c (tui_default_win_height)
1851         (show_source_disasm_command, show_data, init_and_make_win)
1852         (show_source_or_disasm_and_command): Update.
1853         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1854         (tui_redisplay_readline, tui_mld_flush)
1855         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1856         (tui_getc): Update.
1857         * tui/tui-disasm.c (tui_set_disassem_content)
1858         (tui_disasm_window::do_scroll_vertical): Update.
1859         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1860         Now virtual.
1861         (struct tui_win_info): Derive from tui_gen_win_info.
1862         <~tui_win_info>: Mark as override.
1863         <generic>: Remove member.
1864         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1865         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1866         (~tui_data_window, ~tui_win_info)
1867         (tui_free_all_source_wins_content): Update.
1868         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1869
1870 2019-06-25  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-layout.c (init_and_make_win): Use new.
1873         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1874         destructor, initializers.
1875         (tui_alloc_generic_win_info): Don't declare.
1876         * tui/tui-data.c (_locator): Add argument to constructor.
1877         (source_win, disasm_win): New globals.
1878         (exec_info): Remove.
1879         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1880         Update.
1881         (tui_alloc_generic_win_info): Remove.
1882         (init_content_element): Use new.
1883         (tui_win_info::tui_win_info): Update.
1884         (free_content_elements) <case DATA_WIN>: Use delete.
1885
1886 2019-06-25  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1889         * tui/tui-windata.c (tui_first_data_item_displayed)
1890         (tui_delete_data_content_windows): Update.
1891         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1892         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1893         (tui_display_registers_from, tui_check_register_values): Update.
1894         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1895         pointer.
1896         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1897         window.
1898         (tui_free_data_content): Update.
1899         (free_content_elements) <case DATA_WIN>: Free the window.
1900
1901 2019-06-25  Tom Tromey  <tom@tromey.com>
1902
1903         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1904         Update.
1905         * tui/tui-layout.c (make_command_window)
1906         (show_source_disasm_command, show_data, init_and_make_win)
1907         (show_source_or_disasm_and_command): Update.
1908         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1909         method.
1910         <can_highight, is_highlighted>: Now bool.
1911         (tui_set_win_highlight): Don't declare.
1912         * tui/tui-data.c (tui_set_win_highlight): Remove.
1913
1914 2019-06-25  Tom Tromey  <tom@tromey.com>
1915
1916         * tui/tui-wingeneral.c (make_visible): Remove check of window
1917         type.
1918
1919 2019-06-25  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-win.c (tui_win_info::max_height)
1922         (tui_cmd_window::max_height): New methods.
1923         (new_height_ok): Call max_height.
1924         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1925         <max_height>: New method.
1926
1927 2019-06-25  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-win.c (tui_source_window_base::set_new_height)
1930         (tui_data_window::set_new_height): New methods.
1931         (make_invisible_and_set_new_height): Call set_new_height method.
1932         * tui/tui-data.h (struct tui_win_info)
1933         (struct tui_source_window_base, struct tui_data_window)
1934         <set_new_height>: New method.
1935
1936 2019-06-25  Tom Tromey  <tom@tromey.com>
1937
1938         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1939         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1940         tui_refresh_data_win.
1941         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1942         method.
1943         (tui_refresh_all_win): Call the refresh_all method.
1944         (tui_set_focus): Likewise.
1945         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1946         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1947         Likewise.
1948
1949 2019-06-25  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-winsource.h (tui_refill_source_window)
1952         (tui_set_is_exec_point_at): Don't declare.
1953         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1954         (tui_source_window_base::refill): Rename from
1955         tui_refill_source_window.
1956         (tui_source_window_base::do_scroll_horizontal): Update.
1957         (tui_source_window_base::set_is_exec_point_at): Rename from
1958         tui_set_is_exec_point_at.
1959         (tui_update_all_breakpoint_info): Update.
1960         * tui/tui-stack.c (tui_show_frame_info): Update.
1961         * tui/tui-layout.c (show_data): Add cast.
1962         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1963         * tui/tui-data.h (struct tui_source_window_base) <refill,
1964         set_is_exec_point_at>: New methods.
1965         (tui_source_windows, tui_add_to_source_windows): Update types.
1966         (tui_add_to_source_windows): Remove redundant declaration.
1967         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1968         (tui_source_windows): Change return type.
1969         (tui_clear_source_windows_detail): Update.
1970         (tui_add_to_source_windows): Change type of parameter.
1971         (tui_free_all_source_wins_content): Update.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-wingeneral.c (tui_win_info::refresh)
1976         (tui_source_window_base::refresh): New methods.
1977         (tui_refresh_all): Call the refresh method.
1978         * tui/tui-data.h (struct tui_win_info)
1979         (struct tui_source_window_base) <refresh>: New method.
1980
1981 2019-06-25  Tom Tromey  <tom@tromey.com>
1982
1983         * tui/tui.h (tui_is_window_visible): Return bool.
1984         * tui/tui.c (tui_is_window_visible): Return bool.
1985         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1986         (tui_make_visible, tui_make_invisible)
1987         (tui_win_info::make_visible)
1988         (tui_source_window_base::make_visible, make_all_visible)
1989         (tui_make_all_visible, tui_make_all_invisible): Update.
1990         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1991         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1992         bool.
1993         (struct tui_win_info, struct tui_source_window_base)
1994         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1995         * tui/tui-data.c (tui_init_generic_part): Update.
1996
1997 2019-06-25  Tom Tromey  <tom@tromey.com>
1998
1999         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2000         (tui_source_window_base::make_visible): New methods.
2001         (make_all_visible): Make method call.
2002         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2003         (struct tui_source_window_base, struct tui_cmd_window): Override
2004         make_visible.
2005         (tui_win_is_source_type): Don't declare.
2006         * tui/tui-data.c (tui_win_is_source_type): Remove.
2007
2008 2019-06-25  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2011         NULL check.
2012
2013 2019-06-25  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2016         Inline constructor.  Add initializers for members.
2017         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2018         constructors; now inline in class.
2019
2020 2019-06-25  Tom Tromey  <tom@tromey.com>
2021
2022         * tui/tui-regs.c (tui_show_registers): Update.
2023         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2024         bool.
2025         * tui/tui-data.c (tui_data_window::clear_detail)
2026         (tui_data_window): Update.
2027
2028 2019-06-25  Tom Tromey  <tom@tromey.com>
2029
2030         * tui/tui-windata.c (tui_display_all_data)
2031         (tui_display_data_from_line, tui_display_data_from)
2032         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2033         Update.
2034         * tui/tui-regs.c (tui_last_regs_line_no)
2035         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2036         (tui_show_registers, tui_show_register_group)
2037         (tui_display_registers_from, tui_display_reg_element_at_line)
2038         (tui_display_registers_from_line, tui_check_register_values)
2039         (tui_reg_next, tui_reg_prev): Update.
2040         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2041         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2042         tui_data_window.
2043         (struct tui_win_info) <detail>: Remove.  Add new fields from
2044         tui_data_info.
2045         (TUI_DATA_WIN): Add cast.
2046         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2047         (~tui_data_window): Simplify.
2048
2049 2019-06-25  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-layout.c (show_source_disasm_command)
2052         (show_source_or_disasm_and_command): Update.
2053         * tui/tui-io.c (update_cmdwin_start_line)
2054         (tui_redisplay_readline): Update.
2055         * tui/tui-data.h (struct tui_command_info): Remove.
2056         (struct tui_win_info) <detail>: Remove command_info member.
2057         (struct tui_data_window) <start_line>: New member, from
2058         tui_command_info.
2059         (TUI_CMD_WIN): Add casts.
2060
2061 2019-06-25  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-winsource.c (tui_update_source_window)
2064         (tui_refill_source_window)
2065         (tui_source_window_base::do_scroll_horizontal)
2066         (tui_update_breakpoint_info, tui_set_exec_info_content)
2067         (tui_show_exec_info_content, tui_erase_exec_info_content)
2068         (tui_clear_exec_info_content): Update.
2069         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2070         Update.
2071         * tui/tui-win.c (make_invisible_and_set_new_height)
2072         (make_visible_with_new_height): Update.
2073         * tui/tui-source.c (tui_set_source_content)
2074         (tui_show_symtab_source): Update.
2075         * tui/tui-layout.c (extract_display_start_addr)
2076         (show_source_disasm_command, show_data)
2077         (make_source_or_disasm_window)
2078         (show_source_or_disasm_and_command): Update.
2079         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2080         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2081         "gdbarch".
2082         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2083         to tui_source_window_base.
2084         (struct tui_win_info) <detail>: Remove source_info member.
2085         (struct tui_source_window_base) <has_locator>: Inline.
2086         Move contents from tui_source_info; rename has_locator member to
2087         m_has_locator.
2088         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2089         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2090         header file.
2091         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2092         Simplify.
2093         (tui_free_all_source_wins_content): Cast to
2094         tui_source_window_base.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-win.c (make_invisible_and_set_new_height)
2099         (make_visible_with_new_height): Call has_locator method.
2100         * tui/tui-layout.c (show_source_disasm_command, show_data)
2101         (show_source_or_disasm_and_command): Update for bool change.
2102         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2103         (tui_win_info) <has_locator>: New method.
2104         (struct tui_source_window_base) <has_locator>: New method.
2105         (tui_win_has_locator): Don't declare.
2106         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2107         from tui_win_has_locator.
2108         (tui_source_window_base): Use false, not FALSE.
2109
2110 2019-06-25  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2113         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2114         clear_detail method directly.
2115         (tui_clear_win_detail): Remove.
2116
2117 2019-06-25  Tom Tromey  <tom@tromey.com>
2118
2119         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2120         "this", not TUI_DISASM_WIN.
2121
2122 2019-06-25  Tom Tromey  <tom@tromey.com>
2123
2124         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2125         declare.
2126         * tui/tui-winsource.c
2127         (tui_source_window_base::do_scroll_horizontal): Rename from
2128         tui_horizontal_source_scroll.
2129         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2130         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2131         from tui_vertical_data_scroll.
2132         * tui/tui-win.h (tui_scroll): Don't declare.
2133         * tui/tui-win.c (tui_win_info::forward_scroll)
2134         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2135         (tui_win_info::right_scroll): Rename and update.
2136         (tui_scroll_forward_command, tui_scroll_backward_command)
2137         (tui_scroll_left_command, tui_scroll_right_command): Update.
2138         (tui_scroll): Remove.
2139         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2140         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2141         from tui_vertical_source_scroll.
2142         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2143         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2144         from tui_vertical_disassem_scroll.
2145         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2146         do_scroll_horizontal>: New methods.
2147         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2148         Likewise.
2149         (struct tui_source_window_base): Add do_scroll_horizontal.
2150         (struct tui_source_window, struct tui_disasm_window): Add
2151         do_scroll_vertical.
2152         (struct tui_data_window, struct tui_cmd_window): Add
2153         do_scroll_horizontal and do_scroll_vertical.
2154         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2155
2156 2019-06-25  Tom Tromey  <tom@tromey.com>
2157
2158         * tui/tui-data.h (struct tui_source_window_base): New struct.
2159         (struct tui_source_window): Derive from tui_source_window_base.
2160         (struct tui_disasm_window): New struct.
2161         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2162         from tui_source_window::clear_detail.
2163         (tui_source_window_base): Rename from tui_source_window.
2164         (~tui_source_window_base): Rename from ~tui_source_window.
2165         (tui_alloc_win_info): Create a tui_disasm_window.
2166
2167 2019-06-25  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-data.h (struct tui_source_window)
2170         (struct tui_data_window): Declare destructors.
2171         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2172         destructors.
2173         (tui_win_info): Simplify.
2174
2175 2019-06-25  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-winsource.c (tui_display_main)
2178         (tui_update_source_windows_with_addr)
2179         (tui_update_all_breakpoint_info): Update.
2180         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2181         (new_height_ok, parse_scrolling_args): Update.
2182         * tui/tui-stack.c (tui_show_frame_info): Update.
2183         * tui/tui-data.h (struct tui_list): Remove.
2184         (tui_source_windows): Return a reference to a std::vector.
2185         * tui/tui-data.c (source_windows): Now a std::vector.
2186         (tui_source_windows): Change return type.
2187         (tui_clear_source_windows): Rewrite.
2188         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2189         (tui_free_all_source_wins_content): Rewrite.
2190
2191 2019-06-25  Tom Tromey  <tom@tromey.com>
2192
2193         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2194         (struct tui_data_window, struct tui_cmd_window): Declare
2195         clear_detail method.
2196         * tui/tui-data.c (tui_source_window::clear_detail)
2197         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2198         methods.
2199         (tui_clear_win_detail): Simplify.
2200
2201 2019-06-25  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-layout.c (make_source_window, make_disasm_window)
2204         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2205         Return the new window.
2206         (show_source_disasm_command, show_data)
2207         (show_source_or_disasm_and_command): Update.
2208
2209 2019-06-25  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2212         parameter.  Return the new window.
2213         (show_source_disasm_command): Update and remove NULL check.
2214         (show_source_or_disasm_and_command): Update.
2215
2216 2019-06-25  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2219
2220 2019-06-25  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-data.h (struct tui_win_info): Make constructor
2223         protected.  Make destructor virtual.  Add initializers.
2224         (tui_source_window, tui_data_window, tui_cmd_window): New
2225         classes.
2226         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2227         constructor.  Add "type" parameter.
2228         (tui_source_window, tui_data_window, tui_cmd_window): New
2229         constructors.
2230         (tui_alloc_win_info): Instantiate the appropriate subclass.
2231
2232 2019-06-25  Tom Tromey  <tom@tromey.com>
2233
2234         * tui/tui-win.c (tui_resize_all): Use delete.
2235         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2236         destructor.
2237         (tui_free_window): Don't declare.
2238         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2239         Update.
2240
2241 2019-06-25  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-data.h (struct tui_win_info): Add constructor.
2244         * tui/tui-data.c (tui_alloc_win_info): Use new.
2245         (tui_free_window): Use delete.
2246
2247 2019-06-22  Tom Tromey  <tom@tromey.com>
2248
2249         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2250         declare.
2251         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2252
2253 2019-06-22  Tom Tromey  <tom@tromey.com>
2254
2255         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2256         declare.
2257         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2258
2259 2019-06-22  Tom de Vries  <tdevries@suse.de>
2260
2261         * dwarf2read.c (create_addrmap_from_aranges)
2262         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2263         instead of '%zu'.
2264
2265 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2266
2267         * dwarf2read.h (dwarf2_section_info_def): Remove.
2268         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2269         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2270         std::vector<dwarf2_section_info>.
2271         (struct dwo_file) <~dwo_file>: Remove.
2272         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2273         types field.
2274         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2275         (dwarf2_read_debug_names): Likewise.
2276         (create_debug_types_hash_table): Change parameter type to
2277         array_view, adjust code accordingly.
2278         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2279         (partial_die_info::fixup): Likewise.
2280         (determine_prefix): Likewise.
2281         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2282
2283 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2284
2285         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2286         gdb_bfd_ref_ptr.
2287         <~dwo_file>: Remove call to gdb_bfd_unref.
2288         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2289         gdb_bfd_ref_ptr::get.
2290
2291 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2292
2293         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2294         type to htab_up.
2295         * dwarf2read.c (struct dwo_file): Initialize fields.
2296         <~dwo_file>: New.
2297         (free_dwo_file): Remove, move content to ~dwo_file.
2298         (struct dwo_file_deleter): Remove.
2299         (dwo_file_up>: Remove custom deleter.
2300         (free_dwo_files): Remove.
2301         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2302         dwo_files.
2303         (process_skeletonless_type_units): Call unique_ptr::get.
2304         (allocate_dwo_file_hash_table): Add deleter to created hash
2305         table.  Change return type to htab_up.
2306         (lookup_dwo_file_slot): Don't memset dwo_file, call
2307         unique_ptr::get.
2308         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2309         (create_dwo_unit_in_dwp_v2): Likewise.
2310         (open_and_init_dwo_file): Likewise.
2311         (free_dwo_file_from_slot): Remove.
2312
2313 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2314
2315         * dwarf2read.h (struct dwarf2_section_info) <readin,
2316         is_virtual>: Change type to bool.
2317         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2318         true instead of 1.
2319
2320 2019-06-19  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui-data.h (tui_init_content_element): Don't declare.
2323
2324 2019-06-19  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-data.h (tui_init_win_info): Don't declare.
2327
2328 2019-06-19  Tom de Vries  <tdevries@suse.de>
2329
2330         * dwarf2read.h (abstract_to_concrete): Change type to
2331         std::unordered_map<sect_offset, std::vector<sect_offset>,
2332         gdb::hash_enum<sect_offset>>.
2333
2334 2019-06-19  Tom Tromey  <tromey@adacore.com>
2335
2336         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2337         EVAL_AVOID_SIDE_EFFECTS specially.
2338
2339 2019-06-19  Tom Tromey  <tromey@adacore.com>
2340
2341         * source-cache.c (highlighter): New global.
2342         (source_cache::get_source_lines): Create a highlighter on demand.
2343
2344 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2345
2346         * defs.h (deprecated_interactive_hook): Delete declaration.
2347         * interps.c (clear_interpreter_hooks): Remove use of
2348         deprecated_interactive_hook.
2349         * top.c (deprecated_interactive_hook): Delete definition.
2350         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2351
2352 2019-06-18  Tom de Vries  <tdevries@suse.de>
2353
2354         PR gdb/24515
2355         * dwarf2read.h (abstract_to_concrete): Change type from
2356         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2357         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2358         * dwarf2read.c (read_variable): Update.
2359         (dwarf2_fetch_die_loc_sect_off): Update.
2360
2361 2019-06-17  Tom de Vries  <tdevries@suse.de>
2362
2363         PR gdb/24617
2364         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2365         accessing parent[parent_len - 1].
2366
2367 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2368
2369         PR gdb/24364
2370         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2371         call dtrace_process_dof with NULL dof.
2372
2373 2019-06-16  Tom de Vries  <tdevries@suse.de>
2374
2375         PR gdb/24445
2376         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2377
2378 2019-06-16  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2381         (make_all_visible): Use address of member.
2382
2383 2019-06-16  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2386         (tui_free_window, free_content, free_content_elements): Remove
2387         unnecessary cast.
2388         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2389         cast.
2390         * tui/tui-regs.c (tui_show_register_group)
2391         (tui_display_registers_from, tui_display_reg_element_at_line):
2392         Remove unnecessary cast.
2393
2394 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * linux-nat.c (normal_mask): Delete.
2397         (_initialize_linux_nat): Don't initialise normal_mask.
2398
2399 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2400
2401         PR gdb/24445
2402         * dwarf-index-write.h (write_psymtabs_to_index): Add
2403         dwz_basename parameter.
2404         * dwarf-index-write.c (write_gdbindex): Move file writing to
2405         write_gdbindex_1.  Change return type void.
2406         (assert_file_size): Move up, remove filename parameter.
2407         (write_gdbindex_1): New function.
2408         (write_debug_names): Change return type to void, call
2409         assert_file_size.
2410         (struct index_wip_file): New struct.
2411         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2412         file logic to index_wip_file.  Write index for dwz file if
2413         needed.
2414         (save_gdb_index_command): Pass basename of dwz file, if present.
2415         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2416         build-id of dwz file, if present.
2417         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2418         (dwarf2_get_dwz_file): Likewise.
2419         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2420         (dwarf2_get_dwz_file): Likewise.
2421
2422 2019-06-16  Tom Tromey  <tom@tromey.com>
2423
2424         * coffread.c (process_coff_symbol): Use xstrdup.
2425         * value.c (create_internalvar): Use xstrdup.
2426
2427 2019-06-16  Tom Tromey  <tom@tromey.com>
2428
2429         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2430         * breakpoint.c (stopin_command, stopat_command)
2431         (until_break_command, decode_location_default): Remove unnecessary
2432         cast.
2433         * utils.c (subset_compare): Remove unnecessary cast.
2434         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2435         cast.
2436         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2437         cast.
2438         * infcmd.c (path_command): Remove unnecessary cast.
2439         * coffread.c (decode_type): Remove unnecessary cast.
2440         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2441         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2442         * tui/tui-stack.c (tui_show_locator_content)
2443         (tui_show_frame_info): Remove unnecessary cast.
2444         * tui/tui-win.c (tui_scroll_forward_command)
2445         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2446         (parse_scrolling_args): Remove unnecessary cast.
2447         * tui/tui-data.c (init_win_info, tui_del_window)
2448         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2449         (free_content_elements): Remove unnecessary cast.
2450         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2451         unnecessary cast.
2452         * tui/tui-source.c (tui_set_source_content)
2453         (tui_vertical_source_scroll): Remove unnecessary cast.
2454         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2455         cast.
2456         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2457         * tui/tui-regs.c (tui_display_registers_from)
2458         (tui_display_register): Remove unnecessary cast.
2459         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2460         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2461         (make_visible): Remove unnecessary cast.
2462         * tui/tui-winsource.c (tui_erase_source_content)
2463         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2464         unnecessary cast.
2465         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2466         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2467         * stabsread.c (read_type, read_array_type, read_range_type):
2468         Remove unnecessary cast.
2469         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2470         (parse_symbol, parse_type, upgrade_type, parse_external)
2471         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2472         unnecessary cast.
2473         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2474
2475 2019-06-16  Tom Tromey  <tom@tromey.com>
2476
2477         * tui/tui-data.c (tui_alloc_generic_win_info)
2478         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2479         checks.
2480
2481 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2482             Andrew Burgess  <andrew.burgess@embecosm.com>
2483
2484         * f-typeprint.c (f_print_type): Don't return early for not
2485         associated or not allocated types.
2486         (f_type_print_varspec_suffix): Add print_rank parameter and print
2487         ranks of array types in case they dangling.
2488         (f_type_print_base): Add print_rank parameter.
2489
2490 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2491
2492         * NEWS: Mention new MI commands.
2493         * break-catch-throw.c (enum exception_event_kind): Move to
2494         breakpoint.h.
2495         (print_mention_exception_catchpoint): Output text as a single
2496         message.
2497         (catch_exception_command_1): Rename to...
2498         (catch_exception_event): ...this, make non-static, update header
2499         command, and change some parameter types.
2500         (catch_catch_command): Update for changes to
2501         catch_exception_command_1.
2502         (catch_throw_command): Likewise.
2503         (catch_rethrow_command): Likewise.
2504         * breakpoint.c (enum exception_event_kind): Delete.
2505         * breakpoint.h (enum exception_event_kind): Moved here from
2506         break-catch-throw.c.
2507         (catch_exception_event): Declare.
2508         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2509         (mi_cmd_catch_throw): New function.
2510         (mi_cmd_catch_rethrow): New function.
2511         (mi_cmd_catch_catch): New function.
2512         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2513         'catch-catch' entries.
2514         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2515         (mi_cmd_catch_rethrow): Declare.
2516         (mi_cmd_catch_catch): Declare.
2517
2518 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * annotate.c (annotate_source_line): Change return type to void,
2521         update implementation to match.
2522         * annotate.h (annotate_source_line): Change return type to void,
2523         update header comment.
2524         * stack.c (print_frame_info): Don't change what frame information
2525         is printed based on whether annotations are on or not.
2526
2527 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2528
2529         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2530         (annotate_source): Make static.
2531         (annotate_source_line): Moved from source.c and renamed from
2532         identify_source_line.  Update the return type.
2533         * annotate.h (annotate_source): Delete declaration.
2534         (annotate_source_line): Declaration moved from source.h, and
2535         renamed from identify_source_line.  Return type updated.
2536         * source.c (identify_source_line): Moved to annotate.c and renamed
2537         to annotate_source_line.
2538         (info_line_command): Remove check of annotation_level.
2539         * source.h (identify_source_line): Move declaration to annotate.h
2540         and rename to annotate_source_line.
2541         * stack.c: Add 'annotate.h' include.
2542         (print_frame_info): Remove check of annotation_level before
2543         calling annotate_source_line.
2544
2545 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * source-cache.c (source_cache::get_plain_source_lines): Use
2548         open_source_file_with_line_charpos instead of just
2549         open_source_file, remove call to find_source_lines.
2550         (source_cache::get_source_lines): Likewise.
2551         * source.c (find_source_lines): Make static.
2552         (get_filename_and_charpos): Renamed into...
2553         (open_source_file_with_line_charpos): ..this along with changes to
2554         return a scoped_fd, and some other minor clean ups.
2555         (identify_source_line): Use open_source_file_with_line_charpos.
2556         (search_command_helper): Use open_source_file_with_line_charpos
2557         instead of just open_source_file, remove call to
2558         find_source_lines.
2559         * source.h (open_source_file_with_line_charpos): Declare new
2560         function.
2561         (find_source_lines): Delete declaration.
2562
2563 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2564
2565         * source.c (get_filename_and_charpos): Remove fullname
2566         parameter.
2567         (identify_source_line): Update call to get_filename_and_charpos.
2568
2569 2019-06-14  Tom Tromey  <tromey@adacore.com>
2570
2571         PR gdb/24502:
2572         * ui-style.h (skip_ansi_escape): Update comment.
2573         * ui-file.h (class no_terminal_escape_file): New class.
2574         * ui-file.c (no_terminal_escape_file::write)
2575         (no_terminal_escape_file::puts): New methods.
2576         * cli/cli-logging.c (handle_redirections): Use
2577         no_terminal_escape_file.
2578
2579 2019-06-14  Tom Tromey  <tromey@adacore.com>
2580
2581         * NEWS: Move convenience variable news above Python news.
2582
2583 2019-06-14  Tom Tromey  <tom@tromey.com>
2584
2585         * gnulib: Move directory to top-level.
2586         * configure.ac: Don't configure gnulib.
2587         * configure: Rebuild.
2588         * common/common-defs.h: Use new path to gnulib.
2589         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2590         (GNULIB_H): Remove.
2591         (INCGNU): Look in new gnulib location.
2592         (HFILES_NO_SRCDIR): Remove gnulib files.
2593         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2594         (generated_files): Remove GNULIB_H.
2595         ($(LIBGNU), all-lib): Remove targets.
2596         (distclean): Don't mention GNULIB_BUILDDIR.
2597         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2598
2599 2019-06-14  Tom Tromey  <tromey@adacore.com>
2600
2601         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2602         Warn if symbol file does not provide any symbols.
2603
2604 2019-06-14  Tom Tromey  <tromey@adacore.com>
2605
2606         * source.c (find_and_open_source): Respect basenames_may_differ.
2607
2608 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2609
2610         * annotate.c (annotate_breakpoints_invalid): Make use of
2611         scoped_restore_terminal_state.
2612         (annotate_frames_invalid): Likewise.
2613
2614 2019-06-14  Tom Tromey  <tromey@adacore.com>
2615
2616         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2617         allow assignment to an internalvar.
2618
2619 2019-06-14  Tom Tromey  <tromey@adacore.com>
2620
2621         * ada-lex.l: Allow "_" in attribute names.
2622
2623 2019-06-14  Tom Tromey  <tromey@adacore.com>
2624
2625         PR gdb/24653:
2626         * regcache.c (registers_changed): Don't call alloca.
2627         * top.c (execute_command): Don't call alloca.
2628
2629 2019-06-13  Pedro Alves  <palves@redhat.com>
2630
2631         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2632         'expression'.  When parsing an expression, error out if there's
2633         junk after "unlimited".
2634         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2635         (do_set_command): Adjust calls to is_unlimited_literal.
2636
2637 2019-06-13  Pedro Alves  <palves@redhat.com>
2638
2639         * compile/compile.c (make_compile_options_def_group): Add braces
2640         around array_view initializer.
2641         * thread.c (make_thread_apply_all_options_def_group)
2642         (make_thread_apply_all_options_def_group): Likewise.
2643
2644 2019-06-13  Pedro Alves  <palves@redhat.com>
2645
2646         * NEWS (New commands): Mention "maint test-options
2647         require-delimiter", "maint test-options unknown-is-error", "maint
2648         test-options unknown-is-operand" and "maint show
2649         test-options-completion-result".
2650         (New command options, command completion): New section.
2651         (Completion improvements): New section.
2652         Mention that you can abbreviate "unlimited".
2653
2654 2019-06-13  Pedro Alves  <palves@redhat.com>
2655
2656         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2657         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2658         * unittests/cli-utils-selftests.c (test_parse_flags)
2659         (test_parse_flags_qcs): Delete.
2660         (test_cli_utils): Don't call deleted functions.
2661
2662 2019-06-13  Pedro Alves  <palves@redhat.com>
2663
2664         * thread.c: Include "cli/cli-option.h".
2665         (tp_array_compar_ascending): Global.
2666         (tp_array_compar): Delete function.
2667         (tp_array_compar_ascending, tp_array_compar_descending): New
2668         functions.
2669         (ascending_option_def, qcs_flag_option_def)
2670         (thr_qcs_flags_option_defs)
2671         (make_thread_apply_all_options_def_group)
2672         (make_thread_apply_options_def_group): New.
2673         (thread_apply_all_command): Use gdb::option::process_options.
2674         (thread_apply_command_completer)
2675         (thread_apply_all_command_completer): New.
2676         (thread_apply_command): Use gdb::option::process_options.
2677         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2678         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2679         to generate help text of "thread apply".  Adjust "taas"'s help.
2680         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2681         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2682
2683 2019-06-13  Pedro Alves  <palves@redhat.com>
2684
2685         * thread.c (thread_apply_command): Check for invalid TID with
2686         isdigit instead of !isalpha.
2687
2688 2019-06-13  Pedro Alves  <palves@redhat.com>
2689
2690         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2691         (validate_flags_qcs): New.
2692         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2693         (validate_flags_qcs): Declare.
2694         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2695         (make_frame_apply_options_def_group): New.
2696         (frame_apply_command_count): Process options with
2697         gdb::option::process_options.
2698         (frame_apply_completer): New.
2699         (frame_apply_level_completer, frame_apply_all_completer)
2700         (frame_apply_completer): New.
2701         (_initialize_stack): Update help of "frame apply", "frame apply
2702         level", "frame apply all" and "faas" to mention supported options
2703         and install command completers.
2704         * stack.h (frame_apply_all_completer): Declare.
2705         * thread.c: Include "stack.h".
2706         (tfaas_command): Add "--".
2707         (_initialize_thread): Update help "tfaas" to mention supported
2708         options and install command completer.
2709
2710 2019-06-13  Pedro Alves  <palves@redhat.com>
2711
2712         * completer.c (complete_nested_command_line): New.
2713         (gdb_completion_word_break_characters_throw): Add assertion.
2714         * completer.h (complete_nested_command_line): Declare.
2715
2716 2019-06-13  Pedro Alves  <palves@redhat.com>
2717
2718         * stack.c (parse_backtrace_qualifiers): New.
2719         (backtrace_command): Use it.
2720         (backtrace_command_completer): Complete on qualifiers.
2721
2722 2019-06-13  Pedro Alves  <palves@redhat.com>
2723
2724         * frame.c: Include "cli/cli-option.h.
2725         (user_set_backtrace_options): New.
2726         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2727         Delete.
2728         (get_prev_frame): Adjust.
2729         (boolean_option_def, uinteger_option_def)
2730         (set_backtrace_option_defs): New.
2731         (_initialize_frame): Adjust and use
2732         gdb::option::add_setshow_cmds_for_options to install "set
2733         backtrace past-main" and "set backtrace past-entry".
2734         * frame.h: Include "cli/cli-option.h".
2735         (struct frame_print_options): Forward declare.
2736         (print_frame_arguments_all, print_frame_arguments_scalars)
2737         (print_frame_arguments_none): Declare.
2738         (print_entry_values): Delete declaration.
2739         (struct frame_print_options, user_frame_print_options): New.
2740         (struct set_backtrace_options): New.
2741         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2742         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2743         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2744         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2745         (list_args_or_locals): Add frame_print_options parameter.
2746         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2747         * python/py-framefilter.c (enumerate_args): Pass down
2748         USER_FRAME_PRINT_OPTIONS.
2749         * stack.c: Include "cli/cli-option.h".
2750         (print_frame_arguments_all, print_frame_arguments_scalars)
2751         (print_frame_arguments_none): Declare.
2752         (print_raw_frame_arguments, print_entry_values): Delete.
2753         (user_frame_print_options): New.
2754         (boolean_option_def, enum_option_def, frame_print_option_defs):
2755         New.
2756         (struct backtrace_cmd_options): New.
2757         (bt_flag_option_def): New.
2758         (backtrace_command_option_defs): New.
2759         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2760         (print_frame_arg, read_frame_arg, print_frame_args)
2761         (print_frame_info, print_frame): Add frame_print_options parameter
2762         and use it.
2763         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2764         (backtrace_command_1): Add frame_print_options and
2765         backtrace_cmd_options parameters and use them.
2766         (make_backtrace_options_def_group): New.
2767         (backtrace_command): Process command options with
2768         gdb::option::process_options.
2769         (backtrace_command_completer): New.
2770         (_initialize_stack): Extend "backtrace"'s help to mention
2771         supported options.  Install completer for "backtrace".
2772         Install some settings commands with add_setshow_cmds_for_options.
2773
2774 2019-06-13  Pedro Alves  <palves@redhat.com>
2775
2776         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2777         and that "set/show print raw frame-arguments" are now deprecated.
2778
2779         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2780         command.
2781         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2782         * stack.c (_initialize_stack): Install "set/show print
2783         raw-frame-arguments", and deprecate "set/show print raw
2784         frame-arguments".
2785         * valprint.c (_initialize_valprint): Deprecate "set/show print
2786         raw".
2787
2788 2019-06-13  Pedro Alves  <palves@redhat.com>
2789
2790         * compile/compile.c (struct compile_options): New.
2791         (compile_flag_option_def, compile_command_option_defs)
2792         (make_compile_options_def_group): New.
2793         (compile_file_command): Handle options with
2794         gdb::option::process_options.
2795         (compile_file_command_completer): New function.
2796         (compile_code_command): Handle options with
2797         gdb::option::process_options.
2798         (compile_code_command_completer): New function.
2799         (_initialize_compiler): Install completers for "compile code" and
2800         "compile file".  Mention available options in "compile code" and
2801         "compile code"'s help.
2802         * completer.c (advance_to_completion_word): New, factored out from
2803         ...
2804         (advance_to_expression_complete_word_point): ... this.
2805         (advance_to_filename_complete_word_point): New.
2806         * completer.h (advance_to_filename_complete_word_point): New
2807         declaration.
2808
2809 2019-06-13  Pedro Alves  <palves@redhat.com>
2810
2811         * compile/compile.c: Include "cli/cli-option.h".
2812         (compile_print_value): Scope data pointer is now a
2813         value_print_options pointer; adjust.
2814         (compile_print_command): Process options.  Scope data pointer is
2815         now a value_print_options pointer; adjust.
2816         (_initialize_compile): Update "compile print"'s help to include
2817         supported options.  Install a completer for "compile print".
2818         * cp-valprint.c (show_vtblprint, show_objectprint)
2819         (show_static_field_print): Delete.
2820         (_initialize_cp_valprint): Don't install "set print
2821         static-members", "set print vtbl", "set print object" here.
2822         * printcmd.c: Include "cli/cli-option.h" and
2823         "common/gdb_optional.h".
2824         (print_command_parse_format): Rework to fill in a
2825         value_print_options instead of a format_data.
2826         (print_value): Change parameter type from format_data pointer to
2827         value_print_options reference.  Adjust.
2828         (print_command_1): Process options.  Adjust to pass down a
2829         value_print_options.
2830         (print_command_completer): New.
2831         (_initialize_printcmd): Install print_command_completer as
2832         handle_brkchars completer for the "print" command.  Update
2833         "print"'s help to include supported options.
2834         * valprint.c: Include "cli/cli-option.h".
2835         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2836         here from cp-valprint.c.
2837         (boolean_option_def, uinteger_option_def)
2838         (value_print_option_defs, make_value_print_options_def_group):
2839         New.  Use gdb::option::add_setshow_cmds_for_options to install
2840         "set print elements", "set print null-stop", "set print repeats",
2841         "set print pretty", "set print union", "set print array", "set
2842         print address", "set print symbol", "set print array-indexes".
2843         * valprint.h: Include <string> and "cli/cli-option.h".
2844         (make_value_print_options_def_group): Declare.
2845         (print_value): Change parameter type from format_data pointer to
2846         value_print_options reference.
2847         (print_command_completer): Declare.
2848
2849 2019-06-13  Pedro Alves  <palves@redhat.com>
2850
2851         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2852         (COMMON_SFILES): Add maint-test-settings.c.
2853         * cli/cli-decode.c (boolean_enums): New global, factored out from
2854         ...
2855         (add_setshow_boolean_cmd): ... here.
2856         * cli/cli-decode.h (boolean_enums): Declare.
2857         * cli/cli-option.c: New file.
2858         * cli/cli-option.h: New file.
2859         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2860         factored out from ...
2861         (parse_cli_boolean_value(const char *)): ... this.
2862         (is_unlimited_literal): Change parameter type to pointer to
2863         pointer.  Adjust and advance ARG pointer.
2864         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2865         (parse_cli_var_enum): New, factored out from ...
2866         (do_set_command): ... this.  Adjust.
2867         * cli/cli-setshow.h (parse_cli_boolean_value)
2868         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2869         (parse_cli_var_enum): Declare.
2870         * cli/cli-utils.c: Include "cli/cli-option.h".
2871         (get_ulongest): New.
2872         * cli/cli-utils.h (get_ulongest): Declare.
2873         (check_for_argument): New overloads.
2874         * maint-test-options.c: New file.
2875
2876 2019-06-13  Pedro Alves  <palves@redhat.com>
2877
2878         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2879         parse a range if "-" is at the end of the string.
2880
2881 2019-06-13  Pedro Alves  <palves@redhat.com>
2882
2883         * cli/cli-setshow.c (parse_auto_binary_operation)
2884         (parse_cli_boolean_value): Don't allow "o".
2885
2886 2019-06-13  Pedro Alves  <palves@redhat.com>
2887
2888         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2889         * NEWS: Mention maint test-settings KIND.
2890         * maint-test-settings.c: New file.
2891
2892 2019-06-13  Pedro Alves  <palves@redhat.com>
2893
2894         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2895         completer.
2896         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2897         "set" completers.
2898
2899 2019-06-13  Pedro Alves  <palves@redhat.com>
2900
2901         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2902         after item.
2903
2904 2019-06-13  Pedro Alves  <palves@redhat.com>
2905
2906         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2907
2908 2019-06-13  Pedro Alves <palves@redhat.com>
2909
2910         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2911         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2912         call.
2913         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2914         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2915         calls.
2916         (check_for_argument): Skip spaces after argument.
2917
2918 2019-06-13  Pedro Alves  <palves@redhat.com>
2919
2920         * thread.c (thread_apply_command): Adjust TID parsing.
2921         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2922         detected before end of string.
2923         (tid_is_in_list): Error out if LIST is invalid.
2924
2925 2019-06-13  Pedro Alves  <palves@redhat.com>
2926
2927         * completer.c (complete_line_internal_1): Rewind completion word
2928         point.
2929         (completion_tracker::advance_custom_word_point_by): Change
2930         parameter type to int.
2931         * completer.h (completion_tracker::advance_custom_word_point_by):
2932         Likewise.
2933
2934 2019-06-13  Pedro Alves  <palves@redhat.com>
2935
2936         * completer.c (advance_to_completion_word): Handle delimiters.
2937
2938 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2939
2940         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2941
2942 2019-06-11  Tom Tromey  <tom@tromey.com>
2943
2944         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2945         (xmalloc_failed): Move to alloc.c.
2946         * alloc.c: New file.
2947         * Makefile.in (COMMON_SFILES): Add alloc.c.
2948
2949 2019-06-11  Tom Tromey  <tom@tromey.com>
2950
2951         * nat/linux-waitpid.c: Don't include server.h.
2952         (linux_debug): Remove.
2953         (my_waitpid): Update.
2954
2955 2019-06-11  Tom Tromey  <tromey@adacore.com>
2956
2957         * infcall.c (_initialize_infcall): Remove trailing newline from
2958         help.
2959         * user-regs.c (_initialize_user_regs): Remove trailing newline
2960         from help.
2961         * typeprint.c (_initialize_typeprint): Remove trailing newline
2962         from help.
2963         * reverse.c (_initialize_reverse): Remove trailing newlines from
2964         help.
2965         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2966         from help.
2967         * language.c (add_set_language_command): Remove trailing newline
2968         from help.
2969         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2970         help.
2971         * disasm.c (_initialize_disasm): Remove trailing newline from
2972         help.
2973         * top.c (init_main): Remove trailing newline from help.
2974         * interps.c (_initialize_interpreter): Remove trailing newline
2975         from help.
2976         * btrace.c (_initialize_btrace): Remove trailing newlines from
2977         help.
2978         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2979         from help.
2980         * python/python.c (_initialize_python): Remove trailing newline
2981         from help.
2982         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2983         help.
2984         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2985         from help.  Reformat some text.
2986         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2987         from help.
2988         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2989         newline from help.
2990
2991 2019-06-11  Tom Tromey  <tromey@adacore.com>
2992
2993         * darwin-nat.c (darwin_decode_exception_message)
2994         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2995
2996 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2997
2998         * valops.c (value_slice): Check for not allocated or not
2999         associated values.
3000
3001 2019-06-10  Tom de Vries  <tdevries@suse.de>
3002
3003         PR gdb/24618
3004         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3005         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3006         invalid.
3007
3008 2019-06-10  Tom de Vries  <tdevries@suse.de>
3009
3010         PR gdb/24611
3011         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3012         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3013
3014 2019-06-10  Tom de Vries  <tdevries@suse.de>
3015
3016         PR symtab/24545
3017         * symtab.c (struct demangled_name_entry): Add language field.
3018         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3019         static minimal symbol".  Set and use language field.
3020
3021 2019-06-10  Tom Tromey  <tromey@adacore.com>
3022
3023         * ada-lang.c (_initialize_ada_language): Update help text.
3024
3025 2019-06-10  Tom Tromey  <tromey@adacore.com>
3026
3027         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3028         with a newline.
3029         * guile/guile.c (handle_boot_error): Don't end warning with a
3030         newline.
3031         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3032         warning with a newline.
3033         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3034         newline.
3035         (s12z_frame_cache): Likewise.
3036         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3037         a newline.
3038         * solib-svr4.c (disable_probes_interface): Don't end warning with
3039         a newline.
3040         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3041         newline.
3042         * python/python.c (do_finish_initialization): Don't end warning
3043         with a newline.
3044
3045 2019-06-10  Tom Tromey  <tom@tromey.com>
3046
3047         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3048         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3049         gdbpy_enter.
3050
3051 2019-06-10  Tom Tromey  <tromey@adacore.com>
3052
3053         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3054         data.
3055         (elf_new_init): Don't call stabsread_new_init.
3056         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3057         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3058         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3059
3060 2019-06-10  Tom de Vries  <tdevries@suse.de>
3061
3062         PR symtab/16264
3063         PR symtab/24517
3064         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3065
3066 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3067
3068         * source.c (find_and_open_source): Also rewrite relative file
3069         names.
3070
3071 2019-04-26  Amos Bird  <amosbird@gmail.com>
3072
3073         * annotate.c (annotate_thread_exited): Add "thread-exited"
3074         annotation.
3075
3076 2019-06-06  Tom Tromey  <tromey@adacore.com>
3077
3078         * maint.h (class scoped_command_stats): Use
3079         DISABLE_COPY_AND_ASSIGN.
3080         <print_time>: New method.
3081         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3082         print_time.
3083         (scoped_command_stats::print_time): New method.
3084
3085 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3086
3087         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3088         instructions of lengths 6 or 8 bytes.
3089
3090 2019-06-04  Pedro Alves  <palves@redhat.com>
3091
3092         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3093
3094         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3095         * breakpoint.c (condition_completer): Likewise.
3096         * cli/cli-dump.c (scan_expression): Likewise.
3097         * common/filestuff.c (mkdir_recursive): Likewise.
3098         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3099         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3100         (gdb_abspath): Likewise.
3101         * compile/compile-cplus-types.c
3102         (compile_cplus_instance::decl_name): Likewise.
3103         * completer.c (complete_explicit_location):
3104         (signal_completer, reg_or_group_completer_1): Likewise.
3105         * cp-support.c (cp_remove_params_if_any): Likewise.
3106         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3107         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3108         * infcmd.c (strip_bg_char): Likewise.
3109         * linespec.c (copy_token_string): Likewise.
3110         * mi/mi-main.c (output_cores): Likewise.
3111         * psymtab.c (psymtab_search_name):
3112         * symfile.c (test_set_ext_lang_command): Likewise.
3113         * target.c (target_fileio_read_stralloc): Likewise.
3114         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3115         * value.c (complete_internalvar): Likewise.
3116
3117 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3118
3119         Add objfile property to gdb.Type.
3120         * NEWS: Mention Python API addition.
3121         * python/py-type.c (typy_get_objfile): New method.
3122
3123 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3124
3125         * NEWS: Mention the new set|show style [title|highlight].
3126         Mention changes to "show style", "help" and "apropos".
3127
3128 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3129
3130         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3131         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3132         instead of print_help_for_command.
3133         (print_doc_of_command): New function.
3134         (help_list): Add 'apropos -v word' suggestion.
3135         (print_help_for_command): Style the command name using title style.
3136         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3137         (_initialize_cli_cmds): Describe -v in apropos_command help.
3138
3139 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3140
3141         * cli/cli-style.h (cli_style_option): Add name in constructor,
3142         add m_name class member, add constructor with intensity,
3143         add name class function.
3144         (cli_style_option::add_setshow_commands): Remove name argument.
3145         (highlight_style, title_style): New styles.
3146         * cli/cli-style.c (do_show): New function that shows a style
3147         characteristic styling the style name with itself.
3148         (set_style_name): New function.
3149         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3150         Update all callers according to the changes in cli/cli-style.h.
3151         * utils.h (fputs_highlighted): New function.
3152         * utils.c (fputs_highlighted): Likewise.
3153
3154 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3155
3156         * NEWS: Mention new pipe command and new convenience variables.
3157
3158 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3159
3160         * cli/cli-cmds.c (pipe_command): New function.
3161         (_initialize_cli_cmds): Call add_com for pipe_command.
3162         Define | as an alias for pipe.
3163         (exit_status_set_internal_vars): New function.
3164         (shell_escape): Call exit_status_set_internal_vars.
3165         cli/cli-decode.c (find_command_name_length): Recognize | as
3166         a single character command.
3167
3168 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3169
3170         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3171         top.c (execute_command_to_ui_file): New function, mostly a copy
3172         of execute_command_to_string.
3173         (execute_command_to_string): Implement by calling
3174         execute_command_to_ui_file.
3175
3176 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3177
3178         * top.h (saved_command_line): Remove declaration.
3179         * top.c (previous_saved_command_line, previous_repeat_arguments):
3180         New variables.
3181         (saved_command_line): Make static, define together with other
3182         'repeat variables'.
3183         (dont_repeat): Clear repeat_arguments.
3184         (repeat_previous, get_saved_command_line, save_command_line):
3185         New functions.
3186         (gdb_init): Initialize saved_command_line
3187         and previous_saved_command_line.
3188         * main.c (captured_main_1): Remove saved_command_line initialization.
3189         * event-top.c (handle_line_of_input): Update to use
3190         the new 'repeat' related functions instead of direct access to
3191         saved_command_line.
3192         * command.h (repeat_previous, get_saved_command_line,
3193         save_command_line): New declarations.
3194         (dont_repeat): Add comment.
3195
3196 2019-05-30  Tom Tromey  <tromey@adacore.com>
3197
3198         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3199         Fix comment.
3200         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3201
3202 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3203
3204         PR cli/24587
3205         * completer.c (complete): Initialize variable word.
3206
3207 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3208
3209         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3210         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3211         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3212         'body' is NULL to the outter 'if', protecting the '!is_define'
3213         situation as well.
3214
3215 2019-05-29  Tom Tromey  <tromey@adacore.com>
3216
3217         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3218         (dwarf_unknown): New function.
3219         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3220         (dwarf_type_encoding_name): Use dwarf_unknown.
3221
3222 2019-05-29  Tom Tromey  <tromey@adacore.com>
3223
3224         PR c++/20020:
3225         * cp-valprint.c (cp_print_value_fields): Call
3226         cp_print_static_field inside "try".
3227
3228 2019-05-29  Tom Tromey  <tromey@adacore.com>
3229
3230         * inflow.c (struct terminal_info): Add default operator=.
3231         * configure: Rebuild.
3232         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3233         -Wdeprecated-copy-dtor, -Wredundant-move.
3234
3235 2019-05-29  Tom Tromey  <tromey@adacore.com>
3236
3237         * NEWS: Add entry.
3238         * infcmd.c (print_return_value_1): Handle finish_print
3239         option.
3240         (show_print_finish): New function.
3241         (_initialize_infcmd): Add "set/show print finish" commands.
3242         * valprint.c (user_print_options): Initialize new member.
3243         * valprint.h (struct value_print_options) <finish_print>: New
3244         member.
3245
3246 2019-05-28  Tom Tromey  <tromey@adacore.com>
3247
3248         * ada-lang.c (ada_remove_Xbn_suffix)
3249         (find_old_style_renaming_symbol)
3250         (parse_old_style_renaming): Remove.
3251         (ada_find_renaming_symbol): Don't call
3252         find_old_style_renaming_symbol.
3253         (ada_is_renaming_symbol): Rename from
3254         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3255         bool.  Now static.
3256         (ada_read_var_value): Update and simplify.
3257         * ada-exp.y (write_var_or_type): Remove old code.
3258
3259 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3260
3261         * event-top.c: Remove include comment.
3262         * inflow.c (class scoped_ignore_sigttou): Move from here...
3263         * inflow.h (class scoped_ignore_sigttou): ...to here.
3264         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3265         * top.c:  Remove include comment.
3266
3267 2019-05-27  Tom Tromey  <tom@tromey.com>
3268
3269         * NEWS: Fix typo.
3270
3271 2019-05-22  Tom Tromey  <tromey@adacore.com>
3272
3273         * target.c (target_follow_exec): Constify parameter.
3274         * target-delegates.c: Rebuild.
3275         * remote.c (remote_target::follow_exec): Constify parameter.
3276         * infrun.c (follow_exec): Constify parameter.
3277         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3278         (target_follow_exec): Likewise.
3279
3280 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3281
3282         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3283         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3284
3285 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3286
3287         * NEWS: Add debugredirect and testsuite sections.
3288
3289 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3290
3291         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3292         target descriptions using exclusively floating point register name
3293         aliases.
3294
3295 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3296
3297         PR gdb/18644:
3298         * f-lang.c (build_fortran_types): Handle the case where
3299         gdbarch_floatformat_for_type returns a nullptr.
3300
3301 2019-05-21  Tom de Vries  <tdevries@suse.de>
3302
3303         PR cli/24587
3304         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3305
3306 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3307
3308         PR gdb/18644:
3309         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3310         16-byte floats.
3311         * i386-tdep.c (i386_floatformat_for_type): Use
3312         floatformats_ia64_quad for the 16-byte floating point component
3313         within a fortran 32-byte complex number.
3314
3315 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3316
3317         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3318         delete default constructor.
3319         (find_partial_die): Update to return const struct.
3320         (partial_die_parent_scope): Move variable declaration into scope
3321         of its use and change its type to auto.
3322         (guess_partial_die_structure_name): Likewise.
3323         (partial_die_info::fixup): Likewise.
3324
3325 2019-05-17  Tom Tromey  <tromey@adacore.com>
3326
3327         * source.c (find_and_open_source): Remove cast.
3328
3329 2019-05-17  Tom Tromey  <tromey@adacore.com>
3330
3331         * annotate.c (annotate_source): Make "filename" const.
3332         * annotate.h (annotate_source): Use const.
3333
3334 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3335
3336         * disasm.c (set_disassembler_options): Send errors to stderr.
3337
3338 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3339
3340         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3341         (cli_interp_base::set_logging): Check debug_redirect.
3342         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3343         * cli/cli-logging.c (debug_redirect): Add static variable.
3344         (pop_output_files): Add default param.
3345         (handle_redirections): Print debug setting.
3346         (show_logging_command): Likewise.
3347         (_initialize_cli_logging): Add debugredirect command.
3348         * interps.c (current_interp_set_logging): Add debug_redirect
3349         parameter.
3350         * interps.h (set_logging): Add debug_redirect parameter.
3351         (current_interp_set_logging): Likewise.
3352         * mi/mi-common.h: Likewise.
3353         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3354
3355 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3356             Tom Tromey  <tromey@adacore.com>
3357
3358         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3359         directly.
3360         * cli/cli-interp.h (make_logging_output): Remove declaration.
3361         * cli/cli-logging.c (make_logging_output): Remove function.
3362         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3363         directly.
3364         * ui-file.c (tee_file::tee_file): Remove bools.
3365         (tee_file::~tee_file): Remove deletes.
3366         * ui-file.h (tee_file): Remove bools.
3367
3368 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3369
3370         * mi/mi-cmds.h (mi_cmd_complete): New function.
3371         * mi/mi-main.c (mi_cmd_complete): Likewise.
3372         * mi/mi-cmds.c: Define new MI command -complete.
3373         * NEWS: Mention new -complete command.
3374
3375 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3376
3377         * completer.h (complete): New function.
3378         * completer.c (complete): Likewise.
3379         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3380         function defined in completer.h.
3381
3382 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3383
3384         * MAINTAINERS (Write After Approval): Add myself.
3385
3386 2019-05-17  Tom de Vries  <tdevries@suse.de>
3387
3388         PR gdb/24094
3389         * dwarf2read.c (struct cu_partial_die_info): New struct.
3390         (find_partial_die): Return cu_partial_die_info.
3391         (partial_die_parent_scope, guess_partial_die_structure_name)
3392         (partial_die_info::fixup): Handle new return type of find_partial_die.
3393
3394 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3395
3396         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3397         "std::string", simplifying the algorithm.
3398
3399 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3400
3401         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3402         (stap_static_probe_ops::get_probes): Likewise.
3403
3404 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3405
3406         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3407         '-')" and "else if".
3408         (stap_parse_single_operand): Join checks for
3409         "gdbarch_stap_parse_special_token_p" and
3410         "gdbarch_stap_parse_special_token" in the same "if" statement.
3411         Invert check when verifying for operation on register
3412         displacement.
3413
3414 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3415
3416         * stap-probe.c (stap_get_opcode): Update comment.
3417         (stap_get_expected_argument_type): Likewise.
3418         (handle_stap_probe): Likewise.
3419
3420 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3421
3422         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3423         return type to 'bool'.  Adjust comment.  Use 'bool' when
3424         appropriate.
3425         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3426         * stap-probe.c (stap_parse_argument_1): Likewise.
3427         (stap_is_operator): Likewise.
3428         (stap_is_generic_prefix): Likewise.
3429         (stap_is_register_prefix): Likewise.
3430         (stap_is_register_indirection_prefix): Likewise.
3431         (stap_is_integer_prefix): Likewise.
3432         (stap_generic_check_suffix): Likewise.
3433         (stap_check_integer_suffix): Likewise.
3434         (stap_check_register_suffix): Likewise.
3435         (stap_check_register_indirection_suffix): Likewise.
3436         (stap_parse_register_operand): Likewise.
3437         (stap_parse_single_operand): Likewise.
3438         (stap_parse_argument_1): Likewise.
3439         (stap_probe::get_argument_count): Likewise.
3440         (stap_is_operator): Likewise.
3441
3442 2019-05-16  Tom Tromey  <tromey@adacore.com>
3443
3444         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3445         keyword to foreach.
3446
3447 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3448
3449         * linux-thread-db.c (try_thread_db_load_1): Change return type
3450         to bool.
3451         (try_thread_db_load): Likewise.
3452         (try_thread_db_load_from_pdir_1): Likewise.
3453         (try_thread_db_load_from_pdir): Likewise.
3454         (try_thread_db_load_from_sdir): Likewise.
3455         (try_thread_db_load_from_dir): Likewise.
3456         (thread_db_load_search): Likewise.
3457         (has_libpthread): Likewise.
3458         (thread_db_load): Likewise.
3459
3460 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3461
3462         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3463         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3464         NULL, and complain/return if that's the case.
3465
3466 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3467
3468         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3469         (advance, posn, abstract_read_memory): New functions.
3470         [struct mem_read_abstraction]: New struct.
3471         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3472
3473 2019-05-14  Tom Tromey  <tromey@adacore.com>
3474
3475         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3476         value is not lval_memory.
3477
3478 2019-05-14  Tom Tromey  <tromey@adacore.com>
3479
3480         * solib.c (info_sharedlibrary_command): Style the file name.
3481
3482 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3483
3484         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3485         (aarch64_vnv_type): Likewise.
3486         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3487         * common/tdesc.c: Likewise.
3488         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3489         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3490         * features/aarch64-fpu.xml: Add ieee half view.
3491         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3492         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3493         * gdbtypes.h (struct builtin_type): Likewise.
3494         (struct objfile_type): Likewise.
3495
3496 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3497
3498         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3499         typo.
3500         * location.h (string_to_event_location): Likewise.
3501
3502 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3503
3504         GDB 8.3 released.
3505
3506 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3507
3508         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3509         New variable declaration.
3510         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3511         New variable.
3512         (print_one_breakpoint): Use ui_out::test_flags and new global
3513         variable to compute use_fixed_output.
3514         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3515         Remove.
3516         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3517         (mi_multi_location_breakpoint_output_fixed): Remove.
3518         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3519         new variable.
3520         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3521         fix_multi_location_breakpoint_output flag if version >= 3.
3522         * ui-out.h (enum ui_out_flag)
3523         <fix_multi_location_breakpoint_output>: New enumerator.
3524
3525 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3526
3527         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3528
3529 2019-05-10  Tom Tromey  <tromey@adacore.com>
3530
3531         * ada-lang.c (catch_ada_completer): New function.
3532         (_initialize_ada_language): Use it.
3533
3534 2019-05-10  Tom Tromey  <tromey@adacore.com>
3535
3536         * thread.c (print_thread_info): Make "requested_threads" const.
3537         * gdbthread.h (print_thread_info): Make "requested_threads"
3538         const.
3539         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3540         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3541
3542 2019-05-08  Tom Tromey  <tom@tromey.com>
3543
3544         * gdbtypes.c (objfile_type_data): Change type.
3545         (objfile_type, _initialize_gdbtypes): Update.
3546
3547 2019-05-08  Tom Tromey  <tom@tromey.com>
3548
3549         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3550         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3551         (_initialize_dwarf2_frame): Update.
3552
3553 2019-05-08  Tom Tromey  <tom@tromey.com>
3554
3555         * objc-lang.c (objc_objfile_data): Change type.
3556         (find_methods): Update.
3557         (_initialize_objc_lang): Remove.
3558
3559 2019-05-08  Tom Tromey  <tom@tromey.com>
3560
3561         * stabsread.c (rs6000_builtin_type_data): Change type.
3562         (rs6000_builtin_type, _initialize_stabsread): Update.
3563
3564 2019-05-08  Tom Tromey  <tom@tromey.com>
3565
3566         * mips-tdep.c (mips_pdr_data): Remove.
3567         (_initialize_mips_tdep): Update.
3568
3569 2019-05-08  Tom Tromey  <tom@tromey.com>
3570
3571         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3572         (hppa_init_objfile_priv_data, read_unwind_info)
3573         (find_unwind_entry, _initialize_hppa_tdep): Update.
3574
3575 2019-05-08  Tom Tromey  <tom@tromey.com>
3576
3577         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3578         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3579         on obstack.
3580         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3581
3582 2019-05-08  Tom Tromey  <tom@tromey.com>
3583
3584         * mdebugread.c (basic_type_data): Change type.
3585         (basic_type, _initialize_mdebugread): Update.
3586
3587 2019-05-08  Tom Tromey  <tom@tromey.com>
3588
3589         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3590
3591 2019-05-08  Tom Tromey  <tom@tromey.com>
3592
3593         * nto-tdep.c (nto_inferior_data_reg): Change type.
3594         (nto_inferior_data): Update.
3595         (nto_inferior_data_cleanup, nto_new_inferior_data)
3596         (_initialize_nto_tdep): Remove.
3597         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3598
3599 2019-05-08  Tom Tromey  <tom@tromey.com>
3600
3601         * ada-lang.c (struct ada_inferior_data): Add initializers.
3602         (ada_inferior_data): Change type.
3603         (ada_inferior_data_cleanup): Remove.
3604         (get_ada_inferior_data, ada_inferior_exit)
3605         (struct ada_pspace_data): Add initializers, destructor.
3606         (ada_pspace_data_handle): Change type.
3607         (get_ada_pspace_data): Update.
3608         (ada_pspace_data_cleanup): Remove.
3609
3610 2019-05-08  Tom Tromey  <tom@tromey.com>
3611
3612         * coffread.c (struct coff_symfile_info): Add initializers.
3613         (coff_objfile_data_key): Move lower.  Change type.
3614         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3615         Update.
3616         (coff_free_info): Remove.
3617
3618 2019-05-08  Tom Tromey  <tom@tromey.com>
3619
3620         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3621         (fbsd_pspace_data_handle): Move lower.  Change type.
3622         (get_fbsd_pspace_data): Update.
3623         (fbsd_pspace_data_cleanup): Remove.
3624         (_initialize_fbsd_tdep): Update.
3625
3626 2019-05-08  Tom Tromey  <tom@tromey.com>
3627
3628         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3629         (get_ada_tasks_pspace_data): Update.
3630         (ada_tasks_pspace_data_cleanup): Remove.
3631         (_initialize_tasks): Update.
3632         (ada_tasks_inferior_data_handle): Change type.
3633         (get_ada_tasks_inferior_data): Update.
3634         (ada_tasks_inferior_data_cleanup): Remove.
3635         (struct ada_tasks_pspace_data): Add initializers.
3636
3637 2019-05-08  Tom Tromey  <tom@tromey.com>
3638
3639         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3640         * symfile-debug.c (debug_sym_get_probes): Change type.
3641         * stap-probe.c (handle_stap_probe):
3642         (stap_static_probe_ops::get_probes): Change type.
3643         * probe.h (class static_probe_ops) <get_probes>: Change type.
3644         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3645         (parse_probes_in_pspace): Update.
3646         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3647         Update.
3648         (any_static_probe_ops::get_probes): Change type.
3649         * elfread.c (elfread_data): New typedef.
3650         (probe_key): Change type.
3651         (elf_get_probes): Likewise.  Update.
3652         (probe_key_free): Remove.
3653         (_initialize_elfread): Update.
3654         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3655         Change type.
3656         (dtrace_process_dof_probe, dtrace_process_dof)
3657         (dtrace_static_probe_ops::get_probe): Change type.
3658
3659 2019-05-08  Tom Tromey  <tom@tromey.com>
3660
3661         * xcoffread.c (struct xcoff_symfile_info): Rename from
3662         coff_symfile_info.  Add initializers.
3663         (xcoff_objfile_data_key): Move lower.  Change type.
3664         (XCOFF_DATA): Rewrite.
3665         (xcoff_free_info): Remove.
3666         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3667         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3668         (xcoff_initial_scan): Update.
3669
3670 2019-05-08  Tom Tromey  <tom@tromey.com>
3671
3672         * solib-svr4.c (struct svr4_info): Add initializers and
3673         destructor.
3674         <probes_table>: Now an htab_up.
3675         (solib_svr4_pspace_data): Change type.
3676         (free_probes_table): Simplify.
3677         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3678         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3679         (probes_table_remove_objfile_probes, register_solib_event_probe)
3680         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3681         (_initialize_svr4_solib): Update.
3682
3683 2019-05-08  Tom Tromey  <tom@tromey.com>
3684
3685         * remote.c (remote_pspace_data): Change type.
3686         (remote_pspace_data_cleanup): Remove.
3687         (get_remote_exec_file, set_pspace_remote_exec_file)
3688         (_initialize_remote): Update.
3689
3690 2019-05-08  Tom Tromey  <tom@tromey.com>
3691
3692         * breakpoint.c (breakpoint_objfile_key): Change type.
3693         (get_breakpoint_objfile_data): Update.
3694         (free_breakpoint_objfile_data): Remove.
3695         (_initialize_breakpoint): Update.
3696
3697 2019-05-08  Tom Tromey  <tom@tromey.com>
3698
3699         * linux-tdep.c (struct linux_info): Add initializers.
3700         (linux_inferior_data): Move.  Change type.
3701         (invalidate_linux_cache_inf): Update.
3702         (linux_inferior_data_cleanup): Remove.
3703         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3704
3705 2019-05-08  Tom Tromey  <tom@tromey.com>
3706
3707         * auxv.c (auxv_inferior_data): Move.  Change type.
3708         (auxv_inferior_data_cleanup): Remove.
3709         (invalidate_auxv_cache_inf): Rewrite.
3710         (get_auxv_inferior_data, _initialize_auxv): Update.
3711
3712 2019-05-08  Tom Tromey  <tom@tromey.com>
3713
3714         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3715         (symfile_debug_objfile_data_key): Change type.
3716         (symfile_debug_installed, debug_qf_has_symbols)
3717         (debug_qf_find_last_source_symtab)
3718         (debug_qf_forget_cached_source_info)
3719         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3720         (debug_qf_print_stats, debug_qf_dump)
3721         (debug_qf_expand_symtabs_for_function)
3722         (debug_qf_expand_all_symtabs)
3723         (debug_qf_expand_symtabs_with_fullname)
3724         (debug_qf_map_matching_symbols)
3725         (debug_qf_expand_symtabs_matching)
3726         (debug_qf_find_pc_sect_compunit_symtab)
3727         (debug_qf_map_symbol_filenames)
3728         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3729         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3730         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3731         (debug_sym_read_linetable, debug_sym_relocate): Update.
3732         (symfile_debug_free_objfile): Remove.
3733         (install_symfile_debug_logging, _initialize_symfile_debug):
3734         Update.
3735
3736 2019-05-08  Tom Tromey  <tom@tromey.com>
3737
3738         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3739         allocate_on_obstack.
3740         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3741         (get_dwarf2_per_objfile): Update.
3742         (set_dwarf2_per_objfile): Remove.
3743         (dwarf2_has_info, dwarf2_get_section_info): Update.
3744         (dwarf2_free_objfile): Remove.
3745         (_initialize_dwarf2_read): Update.
3746
3747 2019-05-08  Tom Tromey  <tom@tromey.com>
3748
3749         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3750         initializers.
3751         <unsupported_script_warning_printed,
3752         script_not_found_warning_printed>: Now bool.
3753         (auto_load_pspace_data): Change type.
3754         (~auto_load_pspace_info): Rename from
3755         auto_load_pspace_data_cleanup.
3756         (get_auto_load_pspace_data, init_loaded_scripts_info)
3757         (clear_section_scripts, maybe_print_unsupported_script_warning)
3758         (maybe_print_script_not_found_warning, _initialize_auto_load):
3759         Update.
3760
3761 2019-05-08  Tom Tromey  <tom@tromey.com>
3762
3763         * objfiles.c (objfile_pspace_info): Add destructor and
3764         initializers.
3765         (objfiles_pspace_data): Change type.
3766         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3767         (get_objfile_pspace_data): Update.
3768         (objfiles_bfd_data): Change type.
3769         (get_objfile_bfd_data): Update.
3770         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3771
3772 2019-05-08  Tom Tromey  <tom@tromey.com>
3773
3774         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3775         Change type.
3776         (get_catch_syscall_inferior_data): Update.
3777         (catch_syscall_inferior_data_cleanup): Remove.
3778         (_initialize_break_catch_syscall): Update.
3779
3780 2019-05-08  Tom Tromey  <tom@tromey.com>
3781
3782         * inflow.c (struct terminal_info): Add destructor and
3783         initializers.
3784         (inflow_inferior_data): Change type.
3785         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3786         (get_inflow_inferior_data, inflow_inferior_exit)
3787         (swap_terminal_info, _initialize_inflow): Update.
3788
3789 2019-05-08  Tom Tromey  <tom@tromey.com>
3790
3791         * target-dcache.c (target_dcache_cleanup): Remove.
3792         (target_dcache_aspace_key): Change type.
3793         (target_dcache_init_p, target_dcache_invalidate)
3794         (target_dcache_get, target_dcache_get_or_init)
3795         (_initialize_target_dcache): Update.
3796         * dcache.h (struct dcache_deleter): New.
3797
3798 2019-05-08  Tom Tromey  <tom@tromey.com>
3799
3800         * symtab.c (struct symbol_cache): Add destructor and
3801         initializers.
3802         (symbol_cache_key): Move.  Change type.
3803         (make_symbol_cache, free_symbol_cache): Remove.
3804         (get_symbol_cache): Update.
3805         (symbol_cache_cleanup): Remove.
3806         (ALL_PSPACES, symbol_cache_flush)
3807         (maintenance_print_symbol_cache)
3808         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3809         Update.
3810
3811 2019-05-08  Tom Tromey  <tom@tromey.com>
3812
3813         * symtab.c (struct main_info): Add destructor and initializers.
3814         (main_progspace_key): Move.  Change type.
3815         (get_main_info): Update.
3816         (main_info_cleanup): Remove.
3817         (_initialize_symtab): Update.
3818
3819 2019-05-08  Tom Tromey  <tom@tromey.com>
3820
3821         * registry.h (DECLARE_REGISTRY): Define the _key class.
3822
3823 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * NEWS: Merge two 'New commands' sections.
3826
3827 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3828
3829         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3830         parameter and use Ada language definition instead.
3831         (ada_val_print_ptr): Remove unused language parameter.
3832         (ada_val_print_num): Remove language parameter and use Ada language
3833         definition instead.
3834         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3835         parameter.
3836         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3837         parameter and use Ada language definition instead.
3838         (ada_val_print_1): Update all ada_val_print_xxx calls.
3839         Remove language parameter.
3840         (ada_val_print): Update ada_val_print_1 call.
3841
3842 2019-05-08  Tom Tromey  <tromey@adacore.com>
3843
3844         * remote.c (remote_hw_watchpoint_limit)
3845         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3846         Now static.
3847
3848 2019-05-08  Tom Tromey  <tromey@adacore.com>
3849
3850         * maint.c (_initialize_maint_cmds): Move initialization code to
3851         remote.c.
3852         (watchdog, show_watchdog): Move to remote.c.
3853         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3854         "watchdog" static.
3855         (_initialize_remote): Move initialization code from maint.c.
3856         * defs.h (watchdog): Don't declare.
3857
3858 2019-05-08  Tom Tromey  <tromey@adacore.com>
3859
3860         * tui/tui-interp.c: Include main.h.
3861         * interps.c: Include main.h.
3862         * main.h (interpreter_p): Declare.
3863         * defs.h (interpreter_p): Don't declare.
3864
3865 2019-05-08  Tom Tromey  <tromey@adacore.com>
3866
3867         * dwarf2loc.c: Include dwarf2read.h.
3868         * defs.h (read_unsigned_leb128): Don't declare.
3869         * dwarf2read.h (read_unsigned_leb128): Declare.
3870
3871 2019-05-08  Tom Tromey  <tromey@adacore.com>
3872
3873         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3874         method.
3875
3876 2019-05-08  Tom Tromey  <tromey@adacore.com>
3877
3878         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3879         when no wrap column is set.
3880
3881 2019-05-08  Tom Tromey  <tromey@adacore.com>
3882
3883         * c-lang.c (c_get_string): Handle non-C-style arrays.
3884
3885 2019-05-08  Tom Tromey  <tromey@adacore.com>
3886
3887         * typeprint.c (print_offset_data::update): Print the bit offset,
3888         not the number of bits remaining.
3889
3890 2019-05-08  Tom Tromey  <tromey@adacore.com>
3891
3892         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3893         padding at end of comment.
3894
3895 2019-05-08  Tom Tromey  <tromey@adacore.com>
3896
3897         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3898         Compare main types.
3899
3900 2019-05-06  Tom Tromey  <tom@tromey.com>
3901
3902         * common/scoped_mmap.c: Include common-defs.h.
3903         * common/scoped_mmap.h: Don't include config.h.
3904
3905 2019-05-04  Tom Tromey  <tom@tromey.com>
3906
3907         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3908         (struct aarch64_call_info): Add initializers.
3909         <si>: Now a std::vector.
3910         (pass_on_stack, aarch64_push_dummy_call): Update.
3911
3912 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3913             Tom Tromey  <tom@tromey.com>
3914
3915         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3916         (ppc_threads): Now a std::vector.  Now static.
3917         (hwdebug_find_thread_points_by_tid)
3918         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3919         Update.
3920
3921 2019-05-04  Tom Tromey  <tom@tromey.com>
3922
3923         * arc-tdep.c (arc_tdesc_init): Return bool.
3924
3925 2019-05-04  Tom Tromey  <tom@tromey.com>
3926
3927         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3928         Use gdb_assert_not_reached.
3929
3930 2019-05-04  Tom Tromey  <tom@tromey.com>
3931
3932         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3933         "false".
3934
3935 2019-05-04  Tom Tromey  <tom@tromey.com>
3936
3937         * arc-tdep.c (arc_tdesc_init): Use bool.
3938
3939 2019-05-04  Tom Tromey  <tom@tromey.com>
3940
3941         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3942
3943 2019-05-04  Tom Tromey  <tom@tromey.com>
3944
3945         * cli/cli-cmds.c (valid_command_p): Return bool.
3946
3947 2019-05-04  Tom Tromey  <tom@tromey.com>
3948
3949         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3950         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3951
3952 2019-05-04  Raul Tambre  <raul@tambre.ee>
3953
3954         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3955         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3956         operator for comparison.
3957
3958 2019-05-04  Tom Tromey  <tom@tromey.com>
3959
3960         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3961         (lookup_partial_symbol, print_partial_symbols)
3962         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3963         (psymbol_compare): Update.
3964         (add_psymbol_to_bcache): Clear the entire psymbol.
3965         (maintenance_check_psymtabs): Update.
3966         * psympriv.h (struct partial_symbol): Don't derive from
3967         general_symbol_info.
3968         <obj_section, unrelocated_address, address,
3969         set_unrelocated_address>: Update.
3970         <ginfo>: New member.
3971         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3972         (debug_names::write_psymbols): Update.
3973
3974 2019-05-04  Tom de Vries  <tdevries@suse.de>
3975
3976         * contrib/cc-with-tweaks.sh: Support -n arg.
3977
3978 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3979
3980         * corelow.c (core_target::detach): Ensure frame cache and
3981         register caches are cleared.
3982         inferior.c (exit_inferior_1): Likewise.
3983
3984 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3985             Tom Tromey  <tom@tromey.com>
3986
3987         * dictionary.c (collate_pending_symbols_by_language): Remove
3988         "struct" from foreach.
3989         * symtab.c (lookup_global_symbol_from_objfile)
3990         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3991         foreach.
3992         * ser-tcp.c (net_open): Remove "struct" from foreach.
3993         * objfiles.c (objfile_relocate, objfile_rebase)
3994         (objfile_has_symbols): Remove "struct" from foreach.
3995         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3996         from foreach.
3997         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3998         foreach.
3999         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4000         "struct" from foreach.
4001         * ada-lang.c (create_excep_cond_exprs)
4002         (ada_exception_catchpoint_cond_string): Remove "struct" from
4003         foreach.
4004
4005 2019-05-03  Tom Tromey  <tromey@adacore.com>
4006
4007         * ada-exp.y (convert_char_literal): Check suffix of each
4008         enumerator.
4009
4010 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4011
4012         PR ada/21406:
4013         * ada-exp.y (yywrap): Don't define.
4014         * ada-lex.l (%option): Add noyywrap
4015         (yywrap): Remove.
4016
4017 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4018
4019         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4020         _WIN32_WINNT to the XP level, unless already defined to a higher
4021         level.
4022
4023         * unittests/parse-connection-spec-selftests.c:
4024         * ser-tcp.c:
4025         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4026         override.
4027
4028         * symfile.c (find_separate_debug_file): Remove colon from the
4029         drive spec of DOS/Windows file names of the target, so that the
4030         file name produced from DEBUGDIR and the target's directory will
4031         be valid on DOS/Windows systems.
4032
4033 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4034
4035         * rust-lang.c (val_print_struct): Handle printing structures
4036         containing strings.
4037
4038 2019-05-02  Tom Tromey  <tromey@adacore.com>
4039
4040         * valarith.c (_initialize_valarith): Remove.
4041
4042 2019-05-01  Tom Tromey  <tromey@adacore.com>
4043
4044         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4045         bitfields.
4046
4047 2019-05-01  Tom Tromey  <tromey@adacore.com>
4048
4049         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4050         for big-endian copies.
4051
4052 2019-04-30  Ali Tamur  <tamur@google.com>
4053         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4054         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4055         (read_3_bytes): New function.
4056
4057 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4058
4059         * windows-nat.c (main_thread_id): Delete.
4060         (handle_output_debug_string): Replace main_thread_id by
4061         current_event.dwThreadId.
4062         (fake_create_process): Likewise.
4063         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4064         Do not set main_thread_id.
4065         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4066         current_event.dwThreadId.
4067         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4068
4069 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4070
4071         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4072         Use current_event.dwThreadId instead of main_thread_id.
4073
4074 2019-04-30  Tom Tromey  <tromey@adacore.com>
4075
4076         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4077         (create_excep_cond_exprs): Iterate over program spaces.
4078         (ada_exception_catchpoint_cond_string): Examine all minimal
4079         symbols for exception types.
4080
4081 2019-04-30  Tom Tromey  <tromey@adacore.com>
4082
4083         PR c++/24470:
4084         * dwarf2read.c (process_structure_scope): Handle case where type
4085         has template parameters but no symbol was created.
4086
4087 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4088             Chris January  <chris.january@arm.com>
4089
4090         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4091         qualifier.
4092         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4093
4094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4095
4096         * f-typeprint.c (f_print_type): Update rules for printing
4097         whitespace.
4098         (f_type_print_varspec_suffix): Likewise.
4099
4100 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4101             Chris January  <chris.january@arm.com>
4102
4103         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4104         function arguments.
4105
4106 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4107
4108         * f-lang.c (build_fortran_types): Change name of void type to
4109         lower case.
4110         * f-typeprint.c (f_type_print_base): Print the name of the void
4111         type, rather than a fixed string.
4112         * f-valprint.c (f_decorations): Use lower case void string.
4113
4114 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4115             Chris January  <chris.january@arm.com>
4116
4117         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4118         types for Fortran.
4119
4120 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4121             Chris January  <chris.january@arm.com>
4122             David Lecomber  <david.lecomber@arm.com>
4123
4124         * f-exp.y (BINOP_INTRINSIC): New token.
4125         (exp): New parser rule handling BINOP_INTRINSIC.
4126         (f77_keywords): Add new builtin procedures.
4127         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4128         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4129         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4130         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4131         (print_unop_subexp_f): New function.
4132         (print_binop_subexp_f): New function.
4133         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4134         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4135         (dump_subexp_body_f): Likewise.
4136         (operator_check_f): Likewise.
4137         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4138         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4139
4140 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4141
4142         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4143         UNOP_KIND.
4144         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4145         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4146         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4147         (operator_length_f): New fuction.
4148         (print_subexp_f): New function.
4149         (op_name_f): New function.
4150         (dump_subexp_body_f): New function.
4151         (operator_check_f): New function.
4152         (exp_descriptor_f): Replace standard expression handling functions
4153         with new functions.
4154         * gdb/fortran-operator.def: New file.
4155         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4156         * gdb/std-operator.def: Remove UNOP_KIND.
4157
4158 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4159
4160         * std-operator.def: Remove unbalanced, stray double quote
4161         character.
4162
4163 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4164             Chris January  <chris.january@arm.com>
4165             Daniel Everett  <daniel.everett@arm.com>
4166             Nick Forrington  <nick.forrington@arm.com>
4167             Richard Bunt  <richard.bunt@arm.com>
4168
4169         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4170         of depth when printing anonymous structs or unions.
4171         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4172         Don't print either the top-level value, or the children if the
4173         max-depth is exceeded.
4174         (ppscm_print_children): When printing the key of a map, allow one
4175         extra level of depth.
4176         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4177         print either the top-level value, or the children if the max-depth
4178         is exceeded.
4179         (print_children): When printing the key of a map, allow one extra
4180         level of depth.
4181         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4182         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4183         (user_print_options): Initialise max_depth field.
4184         (val_print_scalar_or_string_type_p): New function.
4185         (val_print): Check to see if the max depth has been reached.
4186         (val_print_check_max_depth): Define new function.
4187         (show_print_max_depth): New function.
4188         (_initialize_valprint): Add 'print max-depth' option.
4189         * valprint.h (struct value_print_options) <max_depth>: New field.
4190         (val_print_check_max_depth): Declare new function.
4191         * NEWS: Document new feature.
4192
4193 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * ada-lang.c (ada_language_defn): Initialise new field.
4196         * c-lang.c (c_is_string_type_p): New function.
4197         (c_language_defn): Initialise new field.
4198         (cplus_language_defn): Initialise new field.
4199         (asm_language_defn): Initialise new field.
4200         (minimal_language_defn): Initialise new field.
4201         * c-lang.h (c_is_string_type_p): Declare new function.
4202         * d-lang.c (d_language_defn): Initialise new field.
4203         * f-lang.c (f_is_string_type_p): New function.
4204         (f_language_defn): Initialise new field.
4205         * go-lang.c (go_is_string_type_p): New function.
4206         (go_language_defn): Initialise new field.
4207         * language.c (default_is_string_type_p): New function.
4208         (unknown_language_defn): Initialise new field.
4209         (auto_language_defn): Initialise new field.
4210         * language.h (struct language_defn) <la_is_string_type_p>: New
4211         member variable.
4212         (default_is_string_type_p): Declare new function.
4213         * m2-lang.c (m2_language_defn): Initialise new field.
4214         * objc-lang.c (objc_language_defn): Initialise new field.
4215         * opencl-lang.c (opencl_language_defn): Initialise new field.
4216         * p-lang.c (pascal_is_string_type_p): New function.
4217         (pascal_language_defn): Initialise new field.
4218         * rust-lang.c (rust_is_string_type_p): New function.
4219         (rust_language_defn): Initialise new field.
4220
4221 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4222
4223         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4224         New field.
4225         * ada-lang.c (ada_language_defn): Initialise new field.
4226         * c-lang.c (c_language_defn): Likewise.
4227         (cplus_language_defn): Likewise.
4228         (asm_language_defn): Likewise.
4229         (minimal_language_defn): Likewise.
4230         * d-lang.c (d_language_defn): Likewise.
4231         * f-lang.c (f_language_defn): Likewise.
4232         * go-lang.c (go_language_defn): Likewise.
4233         * language.c (unknown_language_defn): Likewise.
4234         (auto_language_defn): Likewise.
4235         * m2-lang.c (m2_language_defn): Likewise.
4236         * objc-lang.c (objc_language_defn): Likewise.
4237         * opencl-lang.c (opencl_language_defn): Likewise.
4238         * p-lang.c (pascal_language_defn): Likewise.
4239         * rust-lang.c (rust_language_defn): Likewise.
4240
4241 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4242
4243         * ada-lang.c (ada_is_character_type): Change return type to bool.
4244         (ada_is_string_type): Likewise.
4245         * ada-lang.h (ada_is_character_type): Update declaration
4246         (ada_is_string_type): Likewise.
4247
4248 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4249
4250         Support style in 'frame|thread apply'
4251
4252         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4253         * record.c (record_start, record_stop): Update callers of
4254         execute_command_to_string with false.
4255         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4256         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4257         methods.
4258         (class string_file): New constructor with term_out parameter.
4259         Override methods term_out and can_emit_style_escape.  New member
4260         term_out.
4261         (class stdio_file): Override can_emit_style_escape.
4262         (class tee_file): Override term_out and can_emit_style_escape.
4263         * utils.h (can_emit_style_escape): Remove.
4264         * utils.c (can_emit_style_escape): Likewise.
4265         Update all callers of can_emit_style_escape (SOMESTREAM) to
4266         SOMESTREAM->can_emit_style_escape.
4267         * source-cache.c (source_cache::get_source_lines): Likewise.
4268         * stack.c (frame_apply_command_count): Call execute_command_to_string
4269         passing the term_out characteristic of the current gdb_stdout.
4270         * thread.c (thr_try_catch_cmd): Likewise.
4271         * top.c (execute_command_to_string): pass term_out parameter
4272         to construct the string_file for the command output.
4273         * ui-file.c (term_cli_styling): New function (most code moved
4274         from utils.c can_emit_style_escape).
4275         (string_file::string_file, string_file::can_emit_style_escape,
4276         stdio_file::can_emit_style_escape, tee_file::term_out,
4277         tee_file::can_emit_style_escape): New functions.
4278
4279 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4280
4281         * NEWS: Mention the new set|show may-call-functions.
4282         * infcall.c (may_call_functions_p): New variable.
4283         (show_may_call_functions_p): New function.
4284         (call_function_by_hand_dummy): Throws an error if not
4285         may-call-functions.
4286         (_initialize_infcall): Call add_setshow_boolean_cmd for
4287         may-call-functions.
4288
4289 2019-04-25  Keith Seitz  <keiths@redhat.com>
4290
4291         PR c++/24367
4292         * cp-support.c (inspect_type): Don't attempt substitutions
4293         of symbol with the same name.
4294
4295 2019-04-25  Tom Tromey  <tromey@adacore.com>
4296
4297         PR gdb/24475:
4298         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4299         static.
4300
4301 2019-04-25  Tom Tromey  <tromey@adacore.com>
4302
4303         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4304         rvalue reference.
4305         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4306         (gdb_xml_parser::parse): Use std::move.
4307         * python/python-internal.h (gdbpy_convert_exception): Take a const
4308         reference.
4309         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4310         std::move.
4311         * python/py-utils.c (gdbpy_convert_exception): Take a const
4312         reference.
4313         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4314         Use std::move.
4315         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4316         Use std::move.
4317         * mi/mi-main.c (mi_print_exception): Take a const reference.
4318         * main.c (handle_command_errors): Take a const reference.
4319         * linespec.c (parse_linespec): Use std::move.
4320         * infcall.c (run_inferior_call): Use std::move.
4321         (call_function_by_hand_dummy): Use std::move.
4322         * exec.c (try_open_exec_file): Use std::move.
4323         * exceptions.h (exception_print, exception_fprintf)
4324         (exception_print_same): Update.
4325         * exceptions.c (print_exception, exception_print)
4326         (exception_fprintf, exception_print_same): Change parameters to
4327         const reference.
4328         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4329         * common/new-op.c: Use std::move.
4330         * common/common-exceptions.h (struct gdb_exception): Add move
4331         constructor.
4332         (struct gdb_exception_error, struct gdb_exception_quit, struct
4333         gdb_quit_bad_alloc): Change constructor to move constructor.
4334         (throw_exception): Change parameter to rvalue reference.
4335         * common/common-exceptions.c (throw_exception): Take rvalue
4336         reference.
4337         * cli/cli-interp.c (safe_execute_command): Use std::move.
4338         * breakpoint.c (insert_bp_location, location_to_sals): Use
4339         std::move.
4340
4341 2019-04-25  Tom Tromey  <tromey@adacore.com>
4342
4343         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4344         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4345         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4346         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4347         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4348         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4349         guile/scm-value.c: Use unpack.
4350         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4351         gdbscm_gdb_exception.
4352         (gdbscm_throw_gdb_exception): Likewise.
4353         (struct gdbscm_gdb_exception): New.
4354         (unpack): New function.
4355         (gdbscm_wrap): Use unpack.
4356
4357 2019-04-25  Tom Tromey  <tromey@adacore.com>
4358
4359         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4360         (gdb_rl_callback_handler): Use std::move.
4361         * common/common-exceptions.h (struct gdb_exception): Add move
4362         assignment operator.
4363         (throw_exception_sjlj): Change "exception" to const reference.
4364         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4365         (throw_exception_sjlj): Change "exception" to const reference.
4366
4367 2019-04-25  Tom Tromey  <tromey@adacore.com>
4368
4369         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4370         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4371         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4372         Update.
4373         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4374         Update.
4375         * mi/mi-interp.c (mi_interp::exec): Update.
4376         * linespec.c (parse_linespec): Update.
4377         * infcall.c (run_inferior_call): Update.
4378         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4379         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4380         (gdbscm_lookup_global_symbol): Update.
4381         * guile/scm-param.c (gdbscm_parameter_value): Update.
4382         * guile/scm-frame.c (gdbscm_frame_read_register)
4383         (gdbscm_frame_read_var): Update.
4384         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4385         * exec.c (try_open_exec_file): Update.
4386         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4387         (gdb_rl_callback_handler): Update.
4388         * common/common-exceptions.h (exception_none): Don't declare.
4389         * common/common-exceptions.c (exception_none): Don't define.
4390         (struct catcher) <exception>: Update.
4391         * cli/cli-interp.c (safe_execute_command): Update.
4392         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4393
4394 2019-04-25  Ali Tamur  <tamur@google.com>
4395
4396         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4397         (read_attribute_value): Likewise.
4398         (dwarf2_read_addr_index): Update comment.
4399         (read_str_index): Add DW_FORM_strx.
4400         (dwarf2_string_attr): Likewise.
4401         (dwarf2_const_value_attr): Likewise.
4402         (dump_die_shallow): Likewise.
4403         (dwarf2_fetch_constant_bytes): Likewise.
4404         (skip_form_bytes): Likewise.
4405         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4406
4407 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4408
4409         PR corefiles/11608
4410         PR corefiles/18187
4411         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4412         OFFSET.  Verify if current mapping contains an ELF header.
4413         (linux_find_memory_regions_full): Adjust call to
4414         dump_mapping_p.
4415
4416 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4417             Kang Li <kanglictf@gmail.com>
4418
4419         PR gdb/21600
4420
4421         * dwarf2-frame.c (read_initial_length): Be consistent about using
4422         unsigned representation of length.
4423         (decode_frame_entry_1): Likewise.  Check for wraparound of
4424         end pointer as well as buffer overflow.
4425
4426 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4427
4428         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4429         "vq".
4430
4431 2019-04-24  Tom Tromey  <tromey@adacore.com>
4432
4433         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4434
4435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4436
4437         * s12z-tdep.c (s12z_unwind_pc): Delete.
4438         (s12z_unwind_sp): Delete.
4439         (s12z_gdbarch_init): Don't register deleted functions with
4440         gdbarch.
4441
4442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4443
4444         * rl78-tdep.c (rl78_unwind_sp): Delete.
4445         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4446
4447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4448
4449         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4450         (xstormy16_unwind_pc): Delete.
4451         (xstormy16_dummy_id): Delete.
4452         (xstormy16_gdbarch_init): Don't register deleted functions with
4453         gdbarch.
4454
4455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4456
4457         * vax-tdep.c (vax_unwind_pc): Delete.
4458         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4459
4460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4461
4462         * v850-tdep.c (v850_unwind_sp): Delete.
4463         (v850_unwind_pc): Delete.
4464         (v850_dummy_id): Delete.
4465         (v850_gdbarch_init): Don't register deleted functions with
4466         gdbarch.
4467
4468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4469
4470         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4471         (tilegx_unwind_pc): Delete.
4472         (tilegx_unwind_dummy_id): Delete.
4473         (tilegx_gdbarch_init): Don't register deleted functions with
4474         gdbarch.
4475
4476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4477
4478         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4479         (tic6x_dummy_id): Delete.
4480         (tic6x_gdbarch_init): Don't register deleted functions with
4481         gdbarch.
4482
4483 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4484
4485         * sparc-tdep.c (sparc_unwind_pc): Delete.
4486         (sparc32_gdbarch_init): Don't register deleted function with
4487         gdbarch.
4488
4489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4490
4491         * sh-tdep.c (sh_unwind_sp): Delete.
4492         (sh_unwind_pc): Delete.
4493         (sh_dummy_id): Delete.
4494         (sh_gdbarch_init): Don't register deleted functions with
4495         gdbarch.
4496
4497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4498
4499         * score-tdep.c (score_unwind_sp): Delete.
4500         (score_unwind_pc): Delete.
4501         (score_dummy_id): Delete.
4502         (score_gdbarch_init): Don't register deleted functions with
4503         gdbarch.
4504
4505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4506
4507         * rx-tdep.c (rx_unwind_pc): Delete.
4508         (rx_unwind_sp): Delete.
4509         (rx_dummy_id): Delete.
4510         (rx_gdbarch_init): Don't register deleted functions with
4511         gdbarch.  Update comment.
4512
4513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4516         (rs6000_dummy_id): Delete.
4517         (rs6000_gdbarch_init): Don't register deleted functions with
4518         gdbarch.
4519
4520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4521
4522         * or1k-tdep.c (or1k_dummy_id): Delete.
4523         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4524
4525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4526
4527         * nios2-tdep.c (nios2_dummy_id): Delete.
4528         (nios2_unwind_sp): Delete.
4529         (nios2_gdbarch_init): Don't register deleted functions with
4530         gdbarch.
4531
4532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4533
4534         * nds32-tdep.c (nds32_dummy_id): Delete.
4535         (nds32_unwind_pc): Delete.
4536         (nds32_unwind_sp): Delete.
4537         (nds32_gdbarch_init): Don't register deleted functions with
4538         gdbarch.
4539
4540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4541
4542         * msp430-tdep.c (msp430_unwind_pc): Delete.
4543         (msp430_unwind_sp): Delete.
4544         (msp430_dummy_id): Delete.
4545         (msp430_gdbarch_init): Don't register deleted functions with
4546         gdbarch.
4547
4548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4549
4550         * moxie-tdep.c (moxie_unwind_sp): Delete.
4551         (moxie_unwind_pc): Delete.
4552         (moxie_dummy_id): Delete.
4553         (moxie_gdbarch_init): Don't register deleted functions with
4554         gdbarch.
4555
4556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4557
4558         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4559         (mn10300_unwind_pc): Delete.
4560         (mn10300_unwind_sp): Delete.
4561         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4562         mn10300_unwind_sp.
4563         (mn10300_frame_unwind_init): Don't register deleted functions with
4564         gdbarch.
4565
4566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * mep-tdep.c (mep_unwind_pc): Delete.
4569         (mep_unwind_sp): Delete.
4570         (mep_dummy_id): Delete.
4571         (mep_gdbarch_init): Don't register deleted functions with
4572         gdbarch.
4573
4574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4575
4576         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4577         (m68hc11_unwind_sp): Delete.
4578         (m68hc11_gdbarch_init): Don't register deleted functions with
4579         gdbarch.
4580
4581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4582
4583         * m32r-tdep.c (m32r_unwind_sp): Delete.
4584         (m32r_unwind_pc): Delete.
4585         (m32r_dummy_id): Delete.
4586         (m32r_gdbarch_init): Don't register deleted functions with
4587         gdbarch.
4588
4589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4590
4591         * m32c-tdep.c (m32c_unwind_pc): Delete.
4592         (m32c_unwind_sp): Delete.
4593         (m32c_dummy_id): Delete.
4594         (m32c_gdbarch_init): Don't register deleted functions with
4595         gdbarch.
4596
4597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4598
4599         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4600         (lm32_unwind_pc): Delete.
4601         (lm32_dummy_id): Delete.
4602         (lm32_gdbarch_init): Don't register deleted functions with
4603         gdbarch.
4604
4605 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4606
4607         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4608         (iq2000_unwind_pc): Delete.
4609         (iq2000_dummy_id): Delete.
4610         (iq2000_gdbarch_init): Don't register deleted functions with
4611         gdbarch.
4612
4613 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4614
4615         * nds32-tdep.c (nds32_type_align): Delete.
4616         (nds32_push_dummy_call): Use type_align instead.
4617
4618 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4619
4620         * arm-tdep.c (arm_type_align): Only handle vector override case.
4621         (arm_push_dummy_call): Use type_align.
4622         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4623
4624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4625
4626         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4627         case.
4628         (pass_on_stack): Use type_align.
4629         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4630         function.
4631
4632 2019-04-23  Tom Tromey  <tromey@adacore.com>
4633
4634         * dwarf2read.c (line_header::file_name_at): Remove unused
4635         overload.
4636
4637 2019-04-23  Tom de Vries  <tdevries@suse.de>
4638
4639         PR gdb/24438
4640         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4641         invocation.
4642
4643
4644 2019-03-27  Ali Tamur  <tamur@google.com>
4645
4646         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4647         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4648         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4649         (dwarf_expr_context::get_addr_index): Likewise
4650         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4651         (symbol_needs_eval_context::get_addr_index): Likewise
4652         (disassemble_dwarf_expression): Add DW_OP_addrx
4653         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4654         (read_cutu_die_from_dwo): Update comment
4655         (skip_one_die): Add DW_FORM_addrx
4656         (read_attribute_value): Likewise
4657         (var_decode_location): Add DW_OP_addrx
4658         (dwarf2_const_value_attr): Add DW_FORM_addrx
4659         (dump_die_shallow): Likewise
4660         (dwarf2_fetch_constant_bytes): Likewise
4661         (decode_locdesc): Add DW_OP_addrx
4662         (skip_form_bytes): Add DW_FORM_addrx
4663
4664 2019-04-22  Ali Tamur  <tamur@google.com>
4665
4666         * MAINTAINERS (Write After Approval): Add self.
4667
4668 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4669
4670         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4671         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4672         (open_symbol_file_object): Likewise.
4673         (svr4_default_sos): Add info parameter.
4674         (svr4_read_so_list): Likewise.
4675         (svr4_current_sos_direct): Adjust functions calls to pass down
4676         info.
4677         (svr4_current_sos_1): Add info parameter.
4678         (svr4_current_sos): Call get_svr4_info, pass info down to
4679         svr4_current_sos_1.
4680         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4681         get_svr4_info.
4682         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4683         get_svr4_info.
4684         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4685         to get_svr4_info.
4686         (probes_table_remove_objfile_probes): Likewise.
4687         (register_solib_event_probe): Add info parameter.
4688         (solist_update_incremental): Pass info parameter down to
4689         svr4_read_so_list.
4690         (disable_probes_interface): Add info parameter.
4691         (svr4_handle_solib_event): Pass current_program_space to
4692         get_svr4_info.  Adjust disable_probes_interface cleanup.
4693         (svr4_create_probe_breakpoints): Add info parameter, pass it
4694         down to register_solib_event_probe.
4695         (svr4_create_solib_event_breakpoints): Add info parameter,
4696         pass it down to svr4_create_probe_breakpoints.
4697         (enable_break): Pass info down to
4698         svr4_create_solib_event_breakpoints.
4699         (svr4_solib_create_inferior_hook): Pass current_program_space to
4700         get_svr4_info.
4701         (svr4_clear_solib): Likewise.
4702
4703 2019-04-22  Pedro Alves  <palves@redhat.com>
4704
4705         * solib-svr4.c (svr4_free_objfile_observer): New.
4706         (probe_and_action::objfile): New field.
4707         (probes_table_htab_remove_objfile_probes)
4708         (probes_table_remove_objfile_probes): New functions.
4709         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4710         in the new probe_and_action.  Don't store the probe in 'lookup'.
4711         (svr4_create_probe_breakpoints): Pass objfile to
4712         register_solib_event_probe.
4713         (_initialize_svr4_solib): Register a free_objfile observer.
4714
4715 2019-04-19  Tom Tromey  <tom@tromey.com>
4716
4717         * common/queue.h: Remove.
4718
4719 2019-04-19  Tom Tromey  <tom@tromey.com>
4720
4721         * event-loop.c: Don't include "common/queue.h".
4722
4723 2019-04-19  Tom Tromey  <tom@tromey.com>
4724
4725         * remote.c (remote_target): Use delete.
4726         * remote-notif.h: Include <list>, not "common/queue.h".
4727         (notif_client_p): Remove typedef.
4728         (remote_notif_state): Add constructor, destructor, initializer.
4729         <notif_queue>: Now a std::list.
4730         (remote_notif_state_xfree): Don't declare.
4731         * remote-notif.c (remote_notif_process, handle_notification)
4732         (remote_notif_state_allocate): Update.
4733         (~remote_notif_state): Rename from remote_notif_state_xfree.
4734
4735 2019-04-19  Tom Tromey  <tom@tromey.com>
4736
4737         * symfile.c (reread_symbols): Update.
4738         * objfiles.c (objfile_register_static_link)
4739         (objfile_lookup_static_link): Update
4740         (~objfile) Don't delete static_links.
4741         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4742
4743 2019-04-19  Tom Tromey  <tom@tromey.com>
4744
4745         * type-stack.h (struct type_stack) <insert>: Constify string.
4746         * type-stack.c (type_stack::insert): Constify string.
4747         * gdbtypes.h (lookup_template_type): Update.
4748         (address_space_name_to_int): Update.
4749         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4750         const.
4751         (lookup_template_type): Make name const.
4752         * c-exp.y: Update rules.
4753         (lex_one_token, classify_name, classify_inner_name)
4754         (c_print_token): Update.
4755         * p-exp.y: Update rules.
4756         (yylex): Update.
4757         * f-exp.y: Update rules.
4758         (yylex): Update.
4759         * d-exp.y: Update rules.
4760         (lex_one_token, classify_name, classify_inner_name): Update.
4761         * parse.c (write_dollar_variable, copy_name): Return std::string.
4762         * parser-defs.h (copy_name): Change return type.
4763         * m2-exp.y: Update rules.
4764         (yylex): Update.
4765         * go-exp.y (lex_one_token): Update.
4766         Update rules.
4767         (classify_unsafe_function, classify_packaged_name)
4768         (classify_name, yylex): Update.
4769
4770 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4771
4772         * configure.ac: add --enable-source-highlight switch.
4773         * configure: Regenerate.
4774         * top.c (print_gdb_version): plumb --enable-source-highlight
4775         status to "show configuration".
4776
4777 2019-04-19  Tom Tromey  <tromey@adacore.com>
4778
4779         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4780         Check ADA_TYPE_P.
4781         (empty_record, ada_template_to_fixed_record_type_1)
4782         (template_to_static_fixed_type)
4783         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4784         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4785         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4786         macros.
4787
4788 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4789
4790         PR symtab/24423:
4791         * source.c (print_source_lines_base): Advance "iter" when a
4792         control character is seen.
4793
4794 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4795
4796         * inferior.h (struct infcall_suspend_state_deleter):
4797         Catch exception in destructor to avoid crash.
4798
4799 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4800
4801         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4802         close to the add_com "shell".
4803
4804 2019-04-18  Tom Tromey  <tromey@adacore.com>
4805
4806         * process-stratum-target.h (class process_stratum_target)
4807         <stratum>: Add "final".
4808
4809 2019-04-17  Tom Tromey  <tromey@adacore.com>
4810
4811         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4812         against nullptr before use.
4813
4814 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4815
4816         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4817
4818 2019-04-17  Jim Wilson  <jimw@sifive.com>
4819             Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4822         code read might fail, assume 4-byte breakpoint in that case.
4823
4824 2019-04-15  Leszek Swirski  <leszeks@google.com>
4825
4826         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4827         rather than a hand-rolled POD check when checking for forced MEMORY
4828         classification.
4829
4830 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4831
4832         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4833         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4834         function.
4835         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4836         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4837         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4838         declaration.
4839
4840 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4841
4842         * aarch64-linux-nat.c
4843         (aarch64_linux_nat_target::thread_architecture): Add override.
4844         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4845         each VQ.
4846
4847 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4848
4849         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4850
4851 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4852
4853         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4854         target types of size 96-bits, add some additional comments, and
4855         check that the builtin type we found was the correct size.
4856
4857 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4858
4859         * utils.c (prompt_for_continue): Don't restore the styling at the
4860         end, as applied_style has the wrong value.  This fixes styling in
4861         long lists of file names that are interrupted by the "Continue?"
4862         prompt.
4863
4864 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4865
4866         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4867         * c-lang.c (c_language_defn): Likewise.
4868         (cplus_language_defn): Likewise.
4869         (asm_language_defn): Likewise.
4870         (minimal_language_defn): Likewise.
4871         * d-lang.c (d_language_defn): Likewise.
4872         * f-lang.c (f_language_defn): Likewise.
4873         * go-lang.c (go_language_defn): Likewise.
4874         * language.c (unknown_language_defn): Likewise.
4875         (auto_language_defn): Likewise.
4876         * language.h (struct language_defn): Remove la_magic field.
4877         (LANG_MAGIC): Delete.
4878         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4879         * objc-lang.c (objc_language_defn): Likewise.
4880         * opencl-lang.c (opencl_language_defn): Likewise.
4881         * p-lang.c (pascal_language_defn): Likewise.
4882         * rust-lang.c (rust_language_defn): Likewise.
4883
4884 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * riscv-tdep.c (riscv_type_align): New function.
4887         (riscv_type_alignment): Delete.
4888         (riscv_arg_location): Use 'type_align'.
4889         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4890
4891 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4892
4893         * gdbtypes.c (type_align): A struct with no non-static fields also
4894         has alignment of 1.
4895
4896 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4897
4898         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4899         component to 0.
4900         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4901         member.
4902         (riscv_struct_info::analyse): New implementation using new
4903         analyse_inner member function.
4904         (riscv_struct_info::field_offset): New member function.
4905         (riscv_struct_info::m_offsets): New member variable.
4906         (riscv_struct_info::analyse_inner): New private member function,
4907         takes the old implementation of riscv_struct_info::analyse but
4908         extended to track field offsets.
4909         (riscv_call_arg_struct): Update the struct folding special cases
4910         to handle cases where empty C++ structs, which are non-zero
4911         length, are found.
4912         (riscv_arg_location): Initialise the length of each location, a
4913         non-zero length now indicates the location is in use.
4914         (riscv_push_dummy_call): Allow for the first location having a
4915         non-zero offset when setting up arguments.
4916         (riscv_return_value): Likewise, but for return values.
4917
4918 2019-04-11  Tom Tromey  <tromey@adacore.com>
4919
4920         * utils.c (internal_vproblem): Make "msg" const.
4921
4922 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4923
4924         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4925         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4926         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4927         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4928
4929 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4930
4931         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4932         function.
4933         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4934         of amd64_collect_native_gregset.
4935         (amd64_linux_nat_target::store_registers): Likewise.
4936
4937 2019-04-10  Tom Tromey  <tom@tromey.com>
4938
4939         * symtab.c (lookup_global_symbol_from_objfile)
4940         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4941         * objfiles.h (class separate_debug_iterator): New.
4942         (class separate_debug_range): New.
4943         (struct objfile) <separate_debug_objfiles>: New method.
4944         (objfile_separate_debug_iterate): Don't declare.
4945         * objfiles.c (separate_debug_iterator::operator++): Rename from
4946         objfile_separate_debug_iterate.
4947         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4948         iterator.
4949         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4950         iterator.
4951
4952 2019-04-10  Tom Tromey  <tom@tromey.com>
4953
4954         * symfile.c (reread_symbols): Remove old comment.
4955         * objfiles.c (free_all_objfiles): Fix a typo.
4956
4957 2019-04-10  Tom Tromey  <tom@tromey.com>
4958
4959         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4960         * minsyms.c (lookup_minimal_symbol): Use foreach.
4961         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4962         (lookup_minimal_symbol_solib_trampoline): Likewise.
4963         * symfile.c (reread_symbols): Use foreach.
4964
4965 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4966             Tom Tromey  <tromey@adacore.com>
4967
4968         PR rust/24414:
4969         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4970         (rust_lex_int_test): Change "value" to be LONGEST.
4971         (rust_lex_tests): Add test for long integer literal.
4972
4973 2019-04-09  Tom Tromey  <tromey@adacore.com>
4974
4975         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4976         to bool.
4977         (extended_remote_target::attach): Update.
4978         (remote_target::remote_notice_new_inferior): Update.
4979         (remote_target::add_current_inferior_and_thread): Update.
4980         * inferior.c (exit_inferior_1): Use "false".
4981         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4982
4983 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4984
4985         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4986         the "start" command.
4987
4988 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4989
4990         * python/py-inferior.c (infpy_thread_from_thread_handle):
4991         Adjust comments to reflect renaming of thread_from_thread_handle
4992         to thread_from_handle.  Adjust keywords.  Fix type error message.
4993         (inferior_object_methods): Add thread_from_handle.  Retain
4994         thread_from_thread_handle, but mark it as deprecated.
4995
4996 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4997
4998         * gdbthread.h (find_thread_by_handle): Revise declaration.
4999         * thread.c (find_thread_by_handle): Likewise.  Adjust
5000         implementation too.
5001         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5002         support for buffer objects as handles.
5003
5004 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5005
5006         * python/py-infthread.c (thpy_thread_handle): New function.
5007         (thread_object_methods): Register thpy_thread_handle.
5008
5009 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5010
5011         * gdbthread.h (thread_to_thread_handle): Declare.
5012         * thread.c (gdbtypes.h): Include.
5013         (thread_to_thread_handle): New function.
5014
5015         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5016         (target_thread_info_to_thread_handle): Declare.
5017         * target.c (target_thread_info_to_thread_handle): New function.
5018         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5019         * target-delegates.c: Regenerate.
5020
5021         * linux-thread-db.c (class thread_db_target): Add method
5022         thread_info_to_thread_handle.
5023         (thread_db_target::thread_info_to_thread_handle): Define.
5024         * remote.c (class remote_target): Add new method
5025         thread_info_to_thread_handle.
5026         (remote_target::thread_info_to_thread_handle): Define.
5027
5028 2019-04-08  Pedro Alves  <palves@redhat.com>
5029
5030         * common/common-exceptions.c (throw_exception): Don't create
5031         named object to throw; throw directly.
5032         (throw_it): Likewise.  Don't initialize gdb_exception::message
5033         here, with new; pass FMT and AP to the ctor instead.
5034         * common/common-exceptions.h: Include <string>.
5035         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5036         const char *, va_list)): New ctor.  Use std::make_shared.
5037         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5038         errors)): Delete.
5039         (gdb_exception_error::gdb_exception_error(enum errors, const char
5040         *, va_list)): New.
5041         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5042         Add assertion.
5043         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5044         errors)): Delete.
5045         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5046         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5047         Add assertion.
5048
5049 2019-04-08  Tom Tromey  <tom@tromey.com>
5050
5051         * valops.c (value_rtti_indirect_type): Replace throw_exception
5052         with throw.
5053         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5054         with throw.
5055         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5056         throw.
5057         * target.c (target_translate_tls_address): Replace throw_exception
5058         with throw.
5059         * stack.c (frame_apply_command_count): Replace throw_exception
5060         with throw.
5061         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5062         throw.
5063         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5064         with throw.
5065         * rs6000-tdep.c (rs6000_frame_cache)
5066         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5067         * remote.c: Replace throw_exception with throw.
5068         * record-full.c (record_full_message, record_full_wait_1)
5069         (record_full_restore): Replace throw_exception with throw.
5070         * record-btrace.c:
5071         (get_thread_current_frame_id, record_btrace_start_replaying)
5072         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5073         (cmd_record_btrace_start): Replace throw_exception with throw.
5074         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5075         throw.
5076         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5077         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5078         * linespec.c:
5079         (find_linespec_symbols): Replace throw_exception with throw.
5080         * infrun.c (displaced_step_prepare, resume): Replace
5081         throw_exception with throw.
5082         * infcmd.c (post_create_inferior): Replace throw_exception with
5083         throw.
5084         * inf-loop.c (inferior_event_handler): Replace throw_exception
5085         with throw.
5086         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5087         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5088         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5089         (get_prev_frame_always, get_frame_pc_if_available)
5090         (get_frame_address_in_block_if_available, get_frame_language):
5091         Replace throw_exception with throw.
5092         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5093         throw_exception with throw.
5094         * eval.c (fetch_subexp_value, evaluate_var_value)
5095         (evaluate_funcall, evaluate_subexp_standard): Replace
5096         throw_exception with throw.
5097         * dwarf2loc.c (call_site_find_chain)
5098         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5099         Replace throw_exception with throw.
5100         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5101         with throw.
5102         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5103         throw.
5104         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5105         * completer.c (complete_line_internal): Replace throw_exception
5106         with throw.
5107         * compile/compile-object-run.c (compile_object_run): Replace
5108         throw_exception with throw.
5109         * cli/cli-script.c (process_next_line): Replace throw_exception
5110         with throw.
5111         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5112         (btrace_enable, btrace_maint_update_pt_packets): Replace
5113         throw_exception with throw.
5114         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5115         throw_exception with throw.
5116         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5117         throw_exception with throw.
5118         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5119         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5120         * aarch64-tdep.c (aarch64_make_prologue_cache)
5121         (aarch64_make_stub_cache): Replace throw_exception with throw.
5122
5123 2019-04-08  Tom Tromey  <tom@tromey.com>
5124
5125         * common/common-exceptions.c (throw_exception): Rename from
5126         throw_exception_cxx.  Remove old copy.  Make argument const.
5127         (throw_it): Create and throw exception objects directly.
5128         * common/common-exceptions.h (throw_exception): Make argument
5129         const.
5130         (struct gdb_exception_error): Add constructor.
5131         (struct gdb_exception_quit): Add constructor.
5132
5133 2019-04-08  Tom Tromey  <tom@tromey.com>
5134
5135         * common/common-exceptions.h (exception_rethrow): Don't declare.
5136         (TRY_SJLJ): Update comment.
5137         (TRY, CATCH, END_CATCH): Remove.
5138         * common/common-exceptions.c (exception_rethrow): Remove.
5139
5140 2019-04-08  Tom Tromey  <tom@tromey.com>
5141
5142         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5143         Remove.
5144         (gdb_exception_error): Rename from
5145         gdb_exception_RETURN_MASK_ERROR.
5146         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5147         (gdb_quit_bad_alloc): Update.
5148         * aarch64-tdep.c: Update.
5149         * ada-lang.c: Update.
5150         * ada-typeprint.c: Update.
5151         * ada-valprint.c: Update.
5152         * amd64-tdep.c: Update.
5153         * arch-utils.c: Update.
5154         * break-catch-throw.c: Update.
5155         * breakpoint.c: Update.
5156         * btrace.c: Update.
5157         * c-varobj.c: Update.
5158         * cli/cli-cmds.c: Update.
5159         * cli/cli-interp.c: Update.
5160         * cli/cli-script.c: Update.
5161         * common/common-exceptions.c: Update.
5162         * common/new-op.c: Update.
5163         * common/selftest.c: Update.
5164         * compile/compile-c-symbols.c: Update.
5165         * compile/compile-cplus-symbols.c: Update.
5166         * compile/compile-object-load.c: Update.
5167         * compile/compile-object-run.c: Update.
5168         * completer.c: Update.
5169         * corelow.c: Update.
5170         * cp-abi.c: Update.
5171         * cp-support.c: Update.
5172         * cp-valprint.c: Update.
5173         * darwin-nat.c: Update.
5174         * disasm-selftests.c: Update.
5175         * dtrace-probe.c: Update.
5176         * dwarf-index-cache.c: Update.
5177         * dwarf-index-write.c: Update.
5178         * dwarf2-frame-tailcall.c: Update.
5179         * dwarf2-frame.c: Update.
5180         * dwarf2loc.c: Update.
5181         * dwarf2read.c: Update.
5182         * eval.c: Update.
5183         * event-loop.c: Update.
5184         * event-top.c: Update.
5185         * exec.c: Update.
5186         * f-valprint.c: Update.
5187         * fbsd-tdep.c: Update.
5188         * frame-unwind.c: Update.
5189         * frame.c: Update.
5190         * gdbtypes.c: Update.
5191         * gnu-v3-abi.c: Update.
5192         * guile/guile-internal.h: Update.
5193         * guile/scm-block.c: Update.
5194         * guile/scm-breakpoint.c: Update.
5195         * guile/scm-cmd.c: Update.
5196         * guile/scm-disasm.c: Update.
5197         * guile/scm-frame.c: Update.
5198         * guile/scm-lazy-string.c: Update.
5199         * guile/scm-math.c: Update.
5200         * guile/scm-param.c: Update.
5201         * guile/scm-ports.c: Update.
5202         * guile/scm-pretty-print.c: Update.
5203         * guile/scm-symbol.c: Update.
5204         * guile/scm-symtab.c: Update.
5205         * guile/scm-type.c: Update.
5206         * guile/scm-value.c: Update.
5207         * i386-linux-tdep.c: Update.
5208         * i386-tdep.c: Update.
5209         * inf-loop.c: Update.
5210         * infcall.c: Update.
5211         * infcmd.c: Update.
5212         * infrun.c: Update.
5213         * jit.c: Update.
5214         * language.c: Update.
5215         * linespec.c: Update.
5216         * linux-fork.c: Update.
5217         * linux-nat.c: Update.
5218         * linux-tdep.c: Update.
5219         * linux-thread-db.c: Update.
5220         * main.c: Update.
5221         * mi/mi-cmd-break.c: Update.
5222         * mi/mi-cmd-stack.c: Update.
5223         * mi/mi-interp.c: Update.
5224         * mi/mi-main.c: Update.
5225         * objc-lang.c: Update.
5226         * p-valprint.c: Update.
5227         * parse.c: Update.
5228         * ppc-linux-tdep.c: Update.
5229         * printcmd.c: Update.
5230         * python/py-arch.c: Update.
5231         * python/py-breakpoint.c: Update.
5232         * python/py-cmd.c: Update.
5233         * python/py-finishbreakpoint.c: Update.
5234         * python/py-frame.c: Update.
5235         * python/py-framefilter.c: Update.
5236         * python/py-gdb-readline.c: Update.
5237         * python/py-inferior.c: Update.
5238         * python/py-infthread.c: Update.
5239         * python/py-lazy-string.c: Update.
5240         * python/py-linetable.c: Update.
5241         * python/py-objfile.c: Update.
5242         * python/py-param.c: Update.
5243         * python/py-prettyprint.c: Update.
5244         * python/py-progspace.c: Update.
5245         * python/py-record-btrace.c: Update.
5246         * python/py-record.c: Update.
5247         * python/py-symbol.c: Update.
5248         * python/py-type.c: Update.
5249         * python/py-unwind.c: Update.
5250         * python/py-utils.c: Update.
5251         * python/py-value.c: Update.
5252         * python/python.c: Update.
5253         * record-btrace.c: Update.
5254         * record-full.c: Update.
5255         * remote-fileio.c: Update.
5256         * remote.c: Update.
5257         * riscv-tdep.c: Update.
5258         * rs6000-aix-tdep.c: Update.
5259         * rs6000-tdep.c: Update.
5260         * rust-exp.y: Update.
5261         * rust-lang.c: Update.
5262         * s390-tdep.c: Update.
5263         * selftest-arch.c: Update.
5264         * solib-dsbt.c: Update.
5265         * solib-frv.c: Update.
5266         * solib-spu.c: Update.
5267         * solib-svr4.c: Update.
5268         * solib.c: Update.
5269         * sparc64-linux-tdep.c: Update.
5270         * stack.c: Update.
5271         * symfile-mem.c: Update.
5272         * symmisc.c: Update.
5273         * target.c: Update.
5274         * thread.c: Update.
5275         * top.c: Update.
5276         * tracefile-tfile.c: Update.
5277         * tui/tui.c: Update.
5278         * typeprint.c: Update.
5279         * unittests/cli-utils-selftests.c: Update.
5280         * unittests/parse-connection-spec-selftests.c: Update.
5281         * valops.c: Update.
5282         * valprint.c: Update.
5283         * value.c: Update.
5284         * varobj.c: Update.
5285         * windows-nat.c: Update.
5286         * x86-linux-nat.c: Update.
5287         * xml-support.c: Update.
5288
5289 2019-04-08  Tom Tromey  <tom@tromey.com>
5290
5291         * xml-support.c: Use C++ exception handling.
5292         * x86-linux-nat.c: Use C++ exception handling.
5293         * windows-nat.c: Use C++ exception handling.
5294         * varobj.c: Use C++ exception handling.
5295         * value.c: Use C++ exception handling.
5296         * valprint.c: Use C++ exception handling.
5297         * valops.c: Use C++ exception handling.
5298         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5299         handling.
5300         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5301         * typeprint.c: Use C++ exception handling.
5302         * tui/tui.c: Use C++ exception handling.
5303         * tracefile-tfile.c: Use C++ exception handling.
5304         * top.c: Use C++ exception handling.
5305         * thread.c: Use C++ exception handling.
5306         * target.c: Use C++ exception handling.
5307         * symmisc.c: Use C++ exception handling.
5308         * symfile-mem.c: Use C++ exception handling.
5309         * stack.c: Use C++ exception handling.
5310         * sparc64-linux-tdep.c: Use C++ exception handling.
5311         * solib.c: Use C++ exception handling.
5312         * solib-svr4.c: Use C++ exception handling.
5313         * solib-spu.c: Use C++ exception handling.
5314         * solib-frv.c: Use C++ exception handling.
5315         * solib-dsbt.c: Use C++ exception handling.
5316         * selftest-arch.c: Use C++ exception handling.
5317         * s390-tdep.c: Use C++ exception handling.
5318         * rust-lang.c: Use C++ exception handling.
5319         * rust-exp.y: Use C++ exception handling.
5320         * rs6000-tdep.c: Use C++ exception handling.
5321         * rs6000-aix-tdep.c: Use C++ exception handling.
5322         * riscv-tdep.c: Use C++ exception handling.
5323         * remote.c: Use C++ exception handling.
5324         * remote-fileio.c: Use C++ exception handling.
5325         * record-full.c: Use C++ exception handling.
5326         * record-btrace.c: Use C++ exception handling.
5327         * python/python.c: Use C++ exception handling.
5328         * python/py-value.c: Use C++ exception handling.
5329         * python/py-utils.c: Use C++ exception handling.
5330         * python/py-unwind.c: Use C++ exception handling.
5331         * python/py-type.c: Use C++ exception handling.
5332         * python/py-symbol.c: Use C++ exception handling.
5333         * python/py-record.c: Use C++ exception handling.
5334         * python/py-record-btrace.c: Use C++ exception handling.
5335         * python/py-progspace.c: Use C++ exception handling.
5336         * python/py-prettyprint.c: Use C++ exception handling.
5337         * python/py-param.c: Use C++ exception handling.
5338         * python/py-objfile.c: Use C++ exception handling.
5339         * python/py-linetable.c: Use C++ exception handling.
5340         * python/py-lazy-string.c: Use C++ exception handling.
5341         * python/py-infthread.c: Use C++ exception handling.
5342         * python/py-inferior.c: Use C++ exception handling.
5343         * python/py-gdb-readline.c: Use C++ exception handling.
5344         * python/py-framefilter.c: Use C++ exception handling.
5345         * python/py-frame.c: Use C++ exception handling.
5346         * python/py-finishbreakpoint.c: Use C++ exception handling.
5347         * python/py-cmd.c: Use C++ exception handling.
5348         * python/py-breakpoint.c: Use C++ exception handling.
5349         * python/py-arch.c: Use C++ exception handling.
5350         * printcmd.c: Use C++ exception handling.
5351         * ppc-linux-tdep.c: Use C++ exception handling.
5352         * parse.c: Use C++ exception handling.
5353         * p-valprint.c: Use C++ exception handling.
5354         * objc-lang.c: Use C++ exception handling.
5355         * mi/mi-main.c: Use C++ exception handling.
5356         * mi/mi-interp.c: Use C++ exception handling.
5357         * mi/mi-cmd-stack.c: Use C++ exception handling.
5358         * mi/mi-cmd-break.c: Use C++ exception handling.
5359         * main.c: Use C++ exception handling.
5360         * linux-thread-db.c: Use C++ exception handling.
5361         * linux-tdep.c: Use C++ exception handling.
5362         * linux-nat.c: Use C++ exception handling.
5363         * linux-fork.c: Use C++ exception handling.
5364         * linespec.c: Use C++ exception handling.
5365         * language.c: Use C++ exception handling.
5366         * jit.c: Use C++ exception handling.
5367         * infrun.c: Use C++ exception handling.
5368         * infcmd.c: Use C++ exception handling.
5369         * infcall.c: Use C++ exception handling.
5370         * inf-loop.c: Use C++ exception handling.
5371         * i386-tdep.c: Use C++ exception handling.
5372         * i386-linux-tdep.c: Use C++ exception handling.
5373         * guile/scm-value.c: Use C++ exception handling.
5374         * guile/scm-type.c: Use C++ exception handling.
5375         * guile/scm-symtab.c: Use C++ exception handling.
5376         * guile/scm-symbol.c: Use C++ exception handling.
5377         * guile/scm-pretty-print.c: Use C++ exception handling.
5378         * guile/scm-ports.c: Use C++ exception handling.
5379         * guile/scm-param.c: Use C++ exception handling.
5380         * guile/scm-math.c: Use C++ exception handling.
5381         * guile/scm-lazy-string.c: Use C++ exception handling.
5382         * guile/scm-frame.c: Use C++ exception handling.
5383         * guile/scm-disasm.c: Use C++ exception handling.
5384         * guile/scm-cmd.c: Use C++ exception handling.
5385         * guile/scm-breakpoint.c: Use C++ exception handling.
5386         * guile/scm-block.c: Use C++ exception handling.
5387         * guile/guile-internal.h: Use C++ exception handling.
5388         * gnu-v3-abi.c: Use C++ exception handling.
5389         * gdbtypes.c: Use C++ exception handling.
5390         * frame.c: Use C++ exception handling.
5391         * frame-unwind.c: Use C++ exception handling.
5392         * fbsd-tdep.c: Use C++ exception handling.
5393         * f-valprint.c: Use C++ exception handling.
5394         * exec.c: Use C++ exception handling.
5395         * event-top.c: Use C++ exception handling.
5396         * event-loop.c: Use C++ exception handling.
5397         * eval.c: Use C++ exception handling.
5398         * dwarf2read.c: Use C++ exception handling.
5399         * dwarf2loc.c: Use C++ exception handling.
5400         * dwarf2-frame.c: Use C++ exception handling.
5401         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5402         * dwarf-index-write.c: Use C++ exception handling.
5403         * dwarf-index-cache.c: Use C++ exception handling.
5404         * dtrace-probe.c: Use C++ exception handling.
5405         * disasm-selftests.c: Use C++ exception handling.
5406         * darwin-nat.c: Use C++ exception handling.
5407         * cp-valprint.c: Use C++ exception handling.
5408         * cp-support.c: Use C++ exception handling.
5409         * cp-abi.c: Use C++ exception handling.
5410         * corelow.c: Use C++ exception handling.
5411         * completer.c: Use C++ exception handling.
5412         * compile/compile-object-run.c: Use C++ exception handling.
5413         * compile/compile-object-load.c: Use C++ exception handling.
5414         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5415         * compile/compile-c-symbols.c: Use C++ exception handling.
5416         * common/selftest.c: Use C++ exception handling.
5417         * common/new-op.c: Use C++ exception handling.
5418         * cli/cli-script.c: Use C++ exception handling.
5419         * cli/cli-interp.c: Use C++ exception handling.
5420         * cli/cli-cmds.c: Use C++ exception handling.
5421         * c-varobj.c: Use C++ exception handling.
5422         * btrace.c: Use C++ exception handling.
5423         * breakpoint.c: Use C++ exception handling.
5424         * break-catch-throw.c: Use C++ exception handling.
5425         * arch-utils.c: Use C++ exception handling.
5426         * amd64-tdep.c: Use C++ exception handling.
5427         * ada-valprint.c: Use C++ exception handling.
5428         * ada-typeprint.c: Use C++ exception handling.
5429         * ada-lang.c: Use C++ exception handling.
5430         * aarch64-tdep.c: Use C++ exception handling.
5431
5432 2019-04-08  Tom Tromey  <tom@tromey.com>
5433
5434         * xml-support.c (gdb_xml_parser::parse): Update.
5435         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5436         * value.c (show_convenience): Update.
5437         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5438         (test_parse_flags_qcs): Update.
5439         * thread.c (thr_try_catch_cmd): Update.
5440         * target.c (target_translate_tls_address): Update.
5441         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5442         (info_frame_command_core, frame_apply_command_count): Update.
5443         * rust-exp.y (rust_lex_exception_test): Update.
5444         * riscv-tdep.c (riscv_print_one_register_info): Update.
5445         * remote.c (remote_target::enable_btrace): Update.
5446         * record-btrace.c (record_btrace_enable_warn): Update.
5447         * python/py-utils.c (gdbpy_convert_exception): Update.
5448         * printcmd.c (do_one_display, print_variable_and_value): Update.
5449         * mi/mi-main.c (mi_print_exception): Update.
5450         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5451         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5452         * linux-nat.c (linux_nat_target::attach): Update.
5453         * linux-fork.c (class scoped_switch_fork_info): Update.
5454         * infrun.c (displaced_step_prepare): Update.
5455         * infcall.c (call_function_by_hand_dummy): Update.
5456         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5457         * gnu-v3-abi.c (print_one_vtable): Update.
5458         * frame.c (get_prev_frame_always): Update.
5459         * f-valprint.c (info_common_command_for_block): Update.
5460         * exec.c (try_open_exec_file): Update.
5461         * exceptions.c (print_exception, exception_print)
5462         (exception_fprintf, exception_print_same): Update.
5463         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5464         * dwarf-index-cache.c (index_cache::store)
5465         (index_cache::lookup_gdb_index): Update.
5466         * darwin-nat.c (maybe_cache_shell): Update.
5467         * cp-valprint.c (cp_print_value_fields): Update.
5468         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5469         (gcc_cplus_symbol_address): Update.
5470         * compile/compile-c-symbols.c (gcc_convert_symbol)
5471         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5472         * common/selftest.c: Update.
5473         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5474         a std::string.
5475         (exception_try_scope_entry, exception_try_scope_exit): Don't
5476         declare.
5477         (struct exception_try_scope): Remove.
5478         (TRY): Don't use exception_try_scope.
5479         (struct gdb_exception): Add constructor, operator=.
5480         <what>: New method.
5481         (struct gdb_exception_RETURN_MASK_ALL)
5482         (struct gdb_exception_RETURN_MASK_ERROR)
5483         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5484         (struct gdb_quit_bad_alloc): Update.
5485         * common/common-exceptions.c (exception_none): Change
5486         initializer.
5487         (struct catcher) <state, exception>: Initialize inline.
5488         <prev>: Remove member.
5489         (current_catcher): Remove.
5490         (catchers): New global.
5491         (exceptions_state_mc_init): Simplify.
5492         (catcher_pop): Remove.
5493         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5494         (try_scope_depth, exception_try_scope_entry)
5495         (exception_try_scope_exit): Remove.
5496         (throw_exception_sjlj): Update.
5497         (exception_messages, exception_messages_size): Remove.
5498         (throw_it): Simplify.
5499         (gdb_exception_sliced_copy): Remove.
5500         (throw_exception_cxx): Update.
5501         * cli/cli-script.c (script_from_file): Update.
5502         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5503         Update.
5504         * ada-valprint.c (ada_val_print): Update.
5505         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5506         (create_excep_cond_exprs): Update.
5507
5508 2019-04-08  Tom Tromey  <tom@tromey.com>
5509
5510         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5511         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5512         (TRY, CATCH, END_CATCH): Remove some definitions.
5513         * common/common-exceptions.c: Don't use GDB_XCPT.
5514         (catcher_list_size): Remove.
5515         (throw_exception, throw_it): Simplify.
5516
5517 2019-04-05  Tom Tromey  <tom@tromey.com>
5518
5519         Revert the header-sorting patch.
5520         * ft32-tdep.c: Revert.
5521         * frv-tdep.c: Revert.
5522         * frv-linux-tdep.c: Revert.
5523         * frame.c: Revert.
5524         * frame-unwind.c: Revert.
5525         * frame-base.c: Revert.
5526         * fork-child.c: Revert.
5527         * findvar.c: Revert.
5528         * findcmd.c: Revert.
5529         * filesystem.c: Revert.
5530         * filename-seen-cache.h: Revert.
5531         * filename-seen-cache.c: Revert.
5532         * fbsd-tdep.c: Revert.
5533         * fbsd-nat.h: Revert.
5534         * fbsd-nat.c: Revert.
5535         * f-valprint.c: Revert.
5536         * f-typeprint.c: Revert.
5537         * f-lang.c: Revert.
5538         * extension.h: Revert.
5539         * extension.c: Revert.
5540         * extension-priv.h: Revert.
5541         * expprint.c: Revert.
5542         * exec.h: Revert.
5543         * exec.c: Revert.
5544         * exceptions.c: Revert.
5545         * event-top.c: Revert.
5546         * event-loop.c: Revert.
5547         * eval.c: Revert.
5548         * elfread.c: Revert.
5549         * dwarf2read.h: Revert.
5550         * dwarf2read.c: Revert.
5551         * dwarf2loc.c: Revert.
5552         * dwarf2expr.h: Revert.
5553         * dwarf2expr.c: Revert.
5554         * dwarf2-frame.c: Revert.
5555         * dwarf2-frame-tailcall.c: Revert.
5556         * dwarf-index-write.h: Revert.
5557         * dwarf-index-write.c: Revert.
5558         * dwarf-index-common.c: Revert.
5559         * dwarf-index-cache.h: Revert.
5560         * dwarf-index-cache.c: Revert.
5561         * dummy-frame.c: Revert.
5562         * dtrace-probe.c: Revert.
5563         * disasm.h: Revert.
5564         * disasm.c: Revert.
5565         * disasm-selftests.c: Revert.
5566         * dictionary.c: Revert.
5567         * dicos-tdep.c: Revert.
5568         * demangle.c: Revert.
5569         * dcache.h: Revert.
5570         * dcache.c: Revert.
5571         * darwin-nat.h: Revert.
5572         * darwin-nat.c: Revert.
5573         * darwin-nat-info.c: Revert.
5574         * d-valprint.c: Revert.
5575         * d-namespace.c: Revert.
5576         * d-lang.c: Revert.
5577         * ctf.c: Revert.
5578         * csky-tdep.c: Revert.
5579         * csky-linux-tdep.c: Revert.
5580         * cris-tdep.c: Revert.
5581         * cris-linux-tdep.c: Revert.
5582         * cp-valprint.c: Revert.
5583         * cp-support.c: Revert.
5584         * cp-namespace.c: Revert.
5585         * cp-abi.c: Revert.
5586         * corelow.c: Revert.
5587         * corefile.c: Revert.
5588         * continuations.c: Revert.
5589         * completer.h: Revert.
5590         * completer.c: Revert.
5591         * complaints.c: Revert.
5592         * coffread.c: Revert.
5593         * coff-pe-read.c: Revert.
5594         * cli-out.h: Revert.
5595         * cli-out.c: Revert.
5596         * charset.c: Revert.
5597         * c-varobj.c: Revert.
5598         * c-valprint.c: Revert.
5599         * c-typeprint.c: Revert.
5600         * c-lang.c: Revert.
5601         * buildsym.c: Revert.
5602         * buildsym-legacy.c: Revert.
5603         * build-id.h: Revert.
5604         * build-id.c: Revert.
5605         * btrace.c: Revert.
5606         * bsd-uthread.c: Revert.
5607         * breakpoint.h: Revert.
5608         * breakpoint.c: Revert.
5609         * break-catch-throw.c: Revert.
5610         * break-catch-syscall.c: Revert.
5611         * break-catch-sig.c: Revert.
5612         * blockframe.c: Revert.
5613         * block.c: Revert.
5614         * bfin-tdep.c: Revert.
5615         * bfin-linux-tdep.c: Revert.
5616         * bfd-target.c: Revert.
5617         * bcache.c: Revert.
5618         * ax-general.c: Revert.
5619         * ax-gdb.h: Revert.
5620         * ax-gdb.c: Revert.
5621         * avr-tdep.c: Revert.
5622         * auxv.c: Revert.
5623         * auto-load.c: Revert.
5624         * arm-wince-tdep.c: Revert.
5625         * arm-tdep.c: Revert.
5626         * arm-symbian-tdep.c: Revert.
5627         * arm-pikeos-tdep.c: Revert.
5628         * arm-obsd-tdep.c: Revert.
5629         * arm-nbsd-tdep.c: Revert.
5630         * arm-nbsd-nat.c: Revert.
5631         * arm-linux-tdep.c: Revert.
5632         * arm-linux-nat.c: Revert.
5633         * arm-fbsd-tdep.c: Revert.
5634         * arm-fbsd-nat.c: Revert.
5635         * arm-bsd-tdep.c: Revert.
5636         * arch-utils.c: Revert.
5637         * arc-tdep.c: Revert.
5638         * arc-newlib-tdep.c: Revert.
5639         * annotate.h: Revert.
5640         * annotate.c: Revert.
5641         * amd64-windows-tdep.c: Revert.
5642         * amd64-windows-nat.c: Revert.
5643         * amd64-tdep.c: Revert.
5644         * amd64-sol2-tdep.c: Revert.
5645         * amd64-obsd-tdep.c: Revert.
5646         * amd64-obsd-nat.c: Revert.
5647         * amd64-nbsd-tdep.c: Revert.
5648         * amd64-nbsd-nat.c: Revert.
5649         * amd64-nat.c: Revert.
5650         * amd64-linux-tdep.c: Revert.
5651         * amd64-linux-nat.c: Revert.
5652         * amd64-fbsd-tdep.c: Revert.
5653         * amd64-fbsd-nat.c: Revert.
5654         * amd64-dicos-tdep.c: Revert.
5655         * amd64-darwin-tdep.c: Revert.
5656         * amd64-bsd-nat.c: Revert.
5657         * alpha-tdep.c: Revert.
5658         * alpha-obsd-tdep.c: Revert.
5659         * alpha-nbsd-tdep.c: Revert.
5660         * alpha-mdebug-tdep.c: Revert.
5661         * alpha-linux-tdep.c: Revert.
5662         * alpha-linux-nat.c: Revert.
5663         * alpha-bsd-tdep.c: Revert.
5664         * alpha-bsd-nat.c: Revert.
5665         * aix-thread.c: Revert.
5666         * agent.c: Revert.
5667         * addrmap.c: Revert.
5668         * ada-varobj.c: Revert.
5669         * ada-valprint.c: Revert.
5670         * ada-typeprint.c: Revert.
5671         * ada-tasks.c: Revert.
5672         * ada-lang.c: Revert.
5673         * aarch64-tdep.c: Revert.
5674         * aarch64-ravenscar-thread.c: Revert.
5675         * aarch64-newlib-tdep.c: Revert.
5676         * aarch64-linux-tdep.c: Revert.
5677         * aarch64-linux-nat.c: Revert.
5678         * aarch64-fbsd-tdep.c: Revert.
5679         * aarch64-fbsd-nat.c: Revert.
5680         * aarch32-linux-nat.c: Revert.
5681
5682 2019-04-05  Tom Tromey  <tom@tromey.com>
5683
5684         * ft32-tdep.c: Sort headers.
5685         * frv-tdep.c: Sort headers.
5686         * frv-linux-tdep.c: Sort headers.
5687         * frame.c: Sort headers.
5688         * frame-unwind.c: Sort headers.
5689         * frame-base.c: Sort headers.
5690         * fork-child.c: Sort headers.
5691         * findvar.c: Sort headers.
5692         * findcmd.c: Sort headers.
5693         * filesystem.c: Sort headers.
5694         * filename-seen-cache.h: Sort headers.
5695         * filename-seen-cache.c: Sort headers.
5696         * fbsd-tdep.c: Sort headers.
5697         * fbsd-nat.h: Sort headers.
5698         * fbsd-nat.c: Sort headers.
5699         * f-valprint.c: Sort headers.
5700         * f-typeprint.c: Sort headers.
5701         * f-lang.c: Sort headers.
5702         * extension.h: Sort headers.
5703         * extension.c: Sort headers.
5704         * extension-priv.h: Sort headers.
5705         * expprint.c: Sort headers.
5706         * exec.h: Sort headers.
5707         * exec.c: Sort headers.
5708         * exceptions.c: Sort headers.
5709         * event-top.c: Sort headers.
5710         * event-loop.c: Sort headers.
5711         * eval.c: Sort headers.
5712         * elfread.c: Sort headers.
5713         * dwarf2read.h: Sort headers.
5714         * dwarf2read.c: Sort headers.
5715         * dwarf2loc.c: Sort headers.
5716         * dwarf2expr.h: Sort headers.
5717         * dwarf2expr.c: Sort headers.
5718         * dwarf2-frame.c: Sort headers.
5719         * dwarf2-frame-tailcall.c: Sort headers.
5720         * dwarf-index-write.h: Sort headers.
5721         * dwarf-index-write.c: Sort headers.
5722         * dwarf-index-common.c: Sort headers.
5723         * dwarf-index-cache.h: Sort headers.
5724         * dwarf-index-cache.c: Sort headers.
5725         * dummy-frame.c: Sort headers.
5726         * dtrace-probe.c: Sort headers.
5727         * disasm.h: Sort headers.
5728         * disasm.c: Sort headers.
5729         * disasm-selftests.c: Sort headers.
5730         * dictionary.c: Sort headers.
5731         * dicos-tdep.c: Sort headers.
5732         * demangle.c: Sort headers.
5733         * dcache.h: Sort headers.
5734         * dcache.c: Sort headers.
5735         * darwin-nat.h: Sort headers.
5736         * darwin-nat.c: Sort headers.
5737         * darwin-nat-info.c: Sort headers.
5738         * d-valprint.c: Sort headers.
5739         * d-namespace.c: Sort headers.
5740         * d-lang.c: Sort headers.
5741         * ctf.c: Sort headers.
5742         * csky-tdep.c: Sort headers.
5743         * csky-linux-tdep.c: Sort headers.
5744         * cris-tdep.c: Sort headers.
5745         * cris-linux-tdep.c: Sort headers.
5746         * cp-valprint.c: Sort headers.
5747         * cp-support.c: Sort headers.
5748         * cp-namespace.c: Sort headers.
5749         * cp-abi.c: Sort headers.
5750         * corelow.c: Sort headers.
5751         * corefile.c: Sort headers.
5752         * continuations.c: Sort headers.
5753         * completer.h: Sort headers.
5754         * completer.c: Sort headers.
5755         * complaints.c: Sort headers.
5756         * coffread.c: Sort headers.
5757         * coff-pe-read.c: Sort headers.
5758         * cli-out.h: Sort headers.
5759         * cli-out.c: Sort headers.
5760         * charset.c: Sort headers.
5761         * c-varobj.c: Sort headers.
5762         * c-valprint.c: Sort headers.
5763         * c-typeprint.c: Sort headers.
5764         * c-lang.c: Sort headers.
5765         * buildsym.c: Sort headers.
5766         * buildsym-legacy.c: Sort headers.
5767         * build-id.h: Sort headers.
5768         * build-id.c: Sort headers.
5769         * btrace.c: Sort headers.
5770         * bsd-uthread.c: Sort headers.
5771         * breakpoint.h: Sort headers.
5772         * breakpoint.c: Sort headers.
5773         * break-catch-throw.c: Sort headers.
5774         * break-catch-syscall.c: Sort headers.
5775         * break-catch-sig.c: Sort headers.
5776         * blockframe.c: Sort headers.
5777         * block.c: Sort headers.
5778         * bfin-tdep.c: Sort headers.
5779         * bfin-linux-tdep.c: Sort headers.
5780         * bfd-target.c: Sort headers.
5781         * bcache.c: Sort headers.
5782         * ax-general.c: Sort headers.
5783         * ax-gdb.h: Sort headers.
5784         * ax-gdb.c: Sort headers.
5785         * avr-tdep.c: Sort headers.
5786         * auxv.c: Sort headers.
5787         * auto-load.c: Sort headers.
5788         * arm-wince-tdep.c: Sort headers.
5789         * arm-tdep.c: Sort headers.
5790         * arm-symbian-tdep.c: Sort headers.
5791         * arm-pikeos-tdep.c: Sort headers.
5792         * arm-obsd-tdep.c: Sort headers.
5793         * arm-nbsd-tdep.c: Sort headers.
5794         * arm-nbsd-nat.c: Sort headers.
5795         * arm-linux-tdep.c: Sort headers.
5796         * arm-linux-nat.c: Sort headers.
5797         * arm-fbsd-tdep.c: Sort headers.
5798         * arm-fbsd-nat.c: Sort headers.
5799         * arm-bsd-tdep.c: Sort headers.
5800         * arch-utils.c: Sort headers.
5801         * arc-tdep.c: Sort headers.
5802         * arc-newlib-tdep.c: Sort headers.
5803         * annotate.h: Sort headers.
5804         * annotate.c: Sort headers.
5805         * amd64-windows-tdep.c: Sort headers.
5806         * amd64-windows-nat.c: Sort headers.
5807         * amd64-tdep.c: Sort headers.
5808         * amd64-sol2-tdep.c: Sort headers.
5809         * amd64-obsd-tdep.c: Sort headers.
5810         * amd64-obsd-nat.c: Sort headers.
5811         * amd64-nbsd-tdep.c: Sort headers.
5812         * amd64-nbsd-nat.c: Sort headers.
5813         * amd64-nat.c: Sort headers.
5814         * amd64-linux-tdep.c: Sort headers.
5815         * amd64-linux-nat.c: Sort headers.
5816         * amd64-fbsd-tdep.c: Sort headers.
5817         * amd64-fbsd-nat.c: Sort headers.
5818         * amd64-dicos-tdep.c: Sort headers.
5819         * amd64-darwin-tdep.c: Sort headers.
5820         * amd64-bsd-nat.c: Sort headers.
5821         * alpha-tdep.c: Sort headers.
5822         * alpha-obsd-tdep.c: Sort headers.
5823         * alpha-nbsd-tdep.c: Sort headers.
5824         * alpha-mdebug-tdep.c: Sort headers.
5825         * alpha-linux-tdep.c: Sort headers.
5826         * alpha-linux-nat.c: Sort headers.
5827         * alpha-bsd-tdep.c: Sort headers.
5828         * alpha-bsd-nat.c: Sort headers.
5829         * aix-thread.c: Sort headers.
5830         * agent.c: Sort headers.
5831         * addrmap.c: Sort headers.
5832         * ada-varobj.c: Sort headers.
5833         * ada-valprint.c: Sort headers.
5834         * ada-typeprint.c: Sort headers.
5835         * ada-tasks.c: Sort headers.
5836         * ada-lang.c: Sort headers.
5837         * aarch64-tdep.c: Sort headers.
5838         * aarch64-ravenscar-thread.c: Sort headers.
5839         * aarch64-newlib-tdep.c: Sort headers.
5840         * aarch64-linux-tdep.c: Sort headers.
5841         * aarch64-linux-nat.c: Sort headers.
5842         * aarch64-fbsd-tdep.c: Sort headers.
5843         * aarch64-fbsd-nat.c: Sort headers.
5844         * aarch32-linux-nat.c: Sort headers.
5845
5846 2019-04-04  Tom Tromey  <tom@tromey.com>
5847
5848         * varobj.c (varobj_create): Update.
5849         * rust-exp.y (struct rust_parser) <update_innermost_block,
5850         lookup_symbol>: New methods.
5851         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5852         Rename.
5853         (rust_parser::rust_lookup_type)
5854         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5855         * printcmd.c (display_command, do_one_display): Update.
5856         * parser-defs.h (struct parser_state) <parser_state>: Add
5857         "tracker" parameter.
5858         (block_tracker): New member.
5859         (class innermost_block_tracker) <innermost_block_tracker>: Add
5860         "types" parameter.
5861         <reset>: Remove method.
5862         (innermost_block): Don't declare.
5863         (null_post_parser): Update.
5864         * parse.c (innermost_block): Remove global.
5865         (write_dollar_variable): Update.
5866         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5867         Remove "tracker_types" parameter.
5868         (parse_expression): Add "tracker" parameter.
5869         (parse_expression_for_completion): Update.
5870         (null_post_parser): Add "tracker" parameter.
5871         * p-exp.y: Update rules.
5872         * m2-exp.y: Update rules.
5873         * language.h (struct language_defn) <la_post_parser>: Add
5874         "tracker" parameter.
5875         * go-exp.y: Update rules.
5876         * f-exp.y: Update rules.
5877         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5878         parameter.
5879         * d-exp.y: Update rules.
5880         * c-exp.y: Update rules.
5881         * breakpoint.c (set_breakpoint_condition): Create an
5882         innermost_block_tracker.
5883         (watch_command_1): Likewise.
5884         * ada-lang.c (resolve): Add "tracker" parameter.
5885         (resolve_subexp): Likewise.
5886         * ada-exp.y (write_var_from_sym): Update.
5887
5888 2019-04-04  Tom Tromey  <tom@tromey.com>
5889
5890         * type-stack.h: New file.
5891         * type-stack.c: New file.
5892         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5893         type-stack.h.
5894         (insert_into_type_stack, insert_type, push_type, push_type_int)
5895         (insert_type_address_space, pop_type, pop_type_int)
5896         (pop_typelist, pop_type_stack, append_type_stack)
5897         (push_type_stack, get_type_stack, push_typelist)
5898         (follow_type_instance_flags, follow_types): Don't declare.
5899         * parse.c (type_stack): Remove global.
5900         (parse_exp_in_context): Update.
5901         (insert_into_type_stack, insert_type, push_type, push_type_int)
5902         (insert_type_address_space, pop_type, pop_type_int)
5903         (pop_typelist, pop_type_stack, append_type_stack)
5904         (push_type_stack, get_type_stack, push_typelist)
5905         (follow_type_instance_flags, follow_types): Remove (moved to
5906         type-stack.c).
5907         * f-exp.y (type_stack): New global.
5908         Update rules.
5909         (push_kind_type, f_parse): Update.
5910         * d-exp.y (type_stack): New global.
5911         Update rules.
5912         (d_parse): Update.
5913         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5914         Update rules.
5915         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5916         (HFILES_NO_SRCDIR): Add type-stack.h.
5917
5918 2019-04-04  Tom Tromey  <tom@tromey.com>
5919
5920         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5921         (rust_parser::convert_ast_to_expression, rust_parse)
5922         (rust_lex_test_completion, rust_lex_tests): Update.
5923         * parser-defs.h (struct expr_completion_state): New.
5924         (struct parser_state) <parser_state>: Add completion parameter.
5925         <mark_struct_expression, mark_completion_tag>: New methods.
5926         <parse_completion, m_completion_state>: New members.
5927         (prefixify_expression, null_post_parser): Update.
5928         (mark_struct_expression, mark_completion_tag): Don't declare.
5929         * parse.c (parse_completion, expout_last_struct)
5930         (expout_tag_completion_type, expout_completion_name): Remove
5931         globals.
5932         (parser_state::mark_struct_expression)
5933         (parser_state::mark_completion_tag): Now methods.
5934         (prefixify_expression): Add last_struct parameter.
5935         (prefixify_subexp): Likewise.
5936         (parse_exp_1): Update.
5937         (parse_exp_in_context): Add cstate parameter.  Update.
5938         (parse_expression_for_completion): Create an
5939         expr_completion_state.
5940         (null_post_parser): Add "completion" parameter.
5941         * p-exp.y: Update rules.
5942         (yylex): Update.
5943         * language.h (struct language_defn) <la_post_parser>: Add
5944         "completing" parameter.
5945         * go-exp.y: Update rules.
5946         (lex_one_token): Update.
5947         * expression.h (parse_completion): Don't declare.
5948         * d-exp.y: Update rules.
5949         (lex_one_token): Update rules.
5950         * c-exp.y: Update rules.
5951         (lex_one_token): Update.
5952         * ada-lang.c (resolve): Add "parse_completion" parameter.
5953         (resolve_subexp): Likewise.
5954         (ada_resolve_function): Likewise.
5955
5956 2019-04-04  Tom Tromey  <tom@tromey.com>
5957
5958         * parser-defs.h (struct parser_state) <start_arglist,
5959         end_arglist>: New methods.
5960         <arglist_len, m_funcall_chain>: New members.
5961         (arglist_len, start_arglist, end_arglist): Don't declare.
5962         * parse.c (arglist_len, funcall_chain): Remove global.
5963         (start_arglist, end_arglist): Remove functions.
5964         (parse_exp_in_context): Update.
5965         * p-exp.y: Update rules.
5966         * m2-exp.y: Update rules.
5967         * go-exp.y: Update rules.
5968         * f-exp.y: Update rules.
5969         * d-exp.y: Update rules.
5970         * c-exp.y: Update rules.
5971
5972 2019-04-04  Tom Tromey  <tom@tromey.com>
5973
5974         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5975         lex_operator, push_back>: New methods.
5976         Update all rules.
5977         (rust_parser::lex_hex, lex_escape): Rename and update.
5978         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5979         (rust_parser::lex_operator): Rename and update.
5980         (rust_parser::lex_number, rustyylex, rustyyerror)
5981         (rust_lex_test_init, rust_lex_test_sequence)
5982         (rust_lex_test_push_back, rust_lex_tests): Update.
5983         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5984         parameter.
5985         <lexptr, prev_lexptr>: New members.
5986         (lexptr, prev_lexptr): Don't declare.
5987         * parse.c (lexptr, prev_lexptr): Remove globals.
5988         (parse_exp_in_context): Update.
5989         * p-exp.y (yylex, yyerror): Update.
5990         * m2-exp.y (parse_number, yylex, yyerror): Update.
5991         * go-exp.y (lex_one_token, yyerror): Update.
5992         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5993         * d-exp.y (lex_one_token, yyerror): Update.
5994         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5995         (lex_one_token, yyerror): Update.
5996         * ada-lex.l (YY_INPUT): Update.
5997         (rewind_to_char): Update.
5998         * ada-exp.y (yyerror): Update.
5999
6000 2019-04-04  Tom Tromey  <tom@tromey.com>
6001
6002         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6003         * parser-defs.h (struct parser_state) <parser_state>: Add new
6004         parameter.
6005         <comma_terminates>: New member.
6006         (comma_terminates): Don't declare global.
6007         * parse.c (comma_terminates): Remove global.
6008         (parse_exp_in_context): Update.
6009         * p-exp.y (yylex): Update.
6010         * m2-exp.y (yylex): Update.
6011         * go-exp.y (lex_one_token): Update.
6012         * f-exp.y (yylex): Update.
6013         * d-exp.y (lex_one_token): Update.
6014         * c-exp.y (lex_one_token): Update.
6015         * ada-lex.l: Update.
6016
6017 2019-04-04  Tom Tromey  <tom@tromey.com>
6018
6019         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6020         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6021         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6022         * parser-defs.h (paren_depth): Don't declare.
6023         * parse.c (paren_depth): Remove global.
6024         (parse_exp_in_context): Update.
6025         * p-exp.y (paren_depth): New global.
6026         (pascal_parse): Initialize it.
6027         * m2-exp.y (paren_depth): New global.
6028         (m2_parse): Initialize it.
6029         * go-exp.y (paren_depth): New global.
6030         (go_parse): Initialize it.
6031         * f-exp.y (paren_depth): New global.
6032         (f_parse): Initialize it.
6033         * d-exp.y (paren_depth): New global.
6034         (d_parse): Initialize it.
6035         * c-exp.y (paren_depth): New global.
6036         (c_parse): Initialize it.
6037         * ada-lex.l (paren_depth): New global.
6038         (lexer_init): Initialize it.
6039
6040 2019-04-04  Tom Tromey  <tom@tromey.com>
6041
6042         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6043         (rust_parser::convert_ast_to_type)
6044         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6045         * parser-defs.h (struct parser_state) <parser_state>: Add
6046         parameters.  Initialize new members.
6047         <expression_context_block, expression_context_pc>: New members.
6048         * parse.c (expression_context_block, expression_context_pc):
6049         Remove globals.
6050         (parse_exp_in_context): Update.
6051         * p-exp.y: Update all rules.
6052         (yylex): Update.
6053         * m2-exp.y: Update all rules.
6054         (yylex): Update.
6055         * go-exp.y (yylex): Update.
6056         * f-exp.y (yylex): Update.
6057         * d-exp.y: Update all rules.
6058         (yylex): Update.
6059         * c-exp.y: Update all rules.
6060         (lex_one_token, classify_name, yylex, c_parse): Update.
6061         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6062
6063 2019-04-04  Tom Tromey  <tom@tromey.com>
6064
6065         * gdbarch.h, gdbarch.c: Rebuild.
6066         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6067         * stap-probe.h:
6068         (struct stap_parse_info): Replace "parser_state" with
6069         "expr_builder".
6070         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6071         (parser_state): New class.
6072         * parse.c (expr_builder): Rename.
6073         (expr_builder::release): Rename.
6074         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6075         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6076         (write_exp_elt_longcst, write_exp_elt_floatcst)
6077         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6078         (write_exp_string_vector, write_exp_bitstring)
6079         (write_exp_msymbol, mark_struct_expression)
6080         (write_dollar_variable)
6081         (insert_type_address_space, increase_expout_size): Replace
6082         "parser_state" with "expr_builder".
6083         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6084         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6085         "parser_state" with "expr_builder".
6086
6087 2019-04-04  Tom Tromey  <tom@tromey.com>
6088
6089         * rust-exp.y: Replace "parse_language" with method call.
6090         * p-exp.y:
6091         (yylex): Replace "parse_language" with method call.
6092         * m2-exp.y:
6093         (yylex): Replace "parse_language" with method call.
6094         * go-exp.y (classify_name): Replace "parse_language" with method
6095         call.
6096         * f-exp.y (yylex): Replace "parse_language" with method call.
6097         * d-exp.y (lex_one_token): Replace "parse_language" with method
6098         call.
6099         * c-exp.y:
6100         (lex_one_token, classify_name, yylex): Replace "parse_language"
6101         with method call.
6102         * ada-exp.y (find_primitive_type, type_char)
6103         (type_system_address): Replace "parse_language" with method call.
6104
6105 2019-04-04  Tom Tromey  <tom@tromey.com>
6106
6107         * rust-exp.y: Replace "parse_gdbarch" with method call.
6108         * parse.c (write_dollar_variable, insert_type_address_space):
6109         Replace "parse_gdbarch" with method call.
6110         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6111         call.
6112         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6113         call.
6114         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6115         "parse_gdbarch" with method call.
6116         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6117         with method call.
6118         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6119         "parse_gdbarch" with method call.
6120         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6121         "parse_gdbarch" with method call.
6122         * c-exp.y (parse_type, parse_number, classify_name): Replace
6123         "parse_gdbarch" with method call.
6124         * ada-lex.l: Replace "parse_gdbarch" with method call.
6125         * ada-exp.y (parse_type, find_primitive_type, type_char)
6126         (type_system_address): Replace "parse_gdbarch" with method call.
6127
6128 2019-04-04  Tom Tromey  <tom@tromey.com>
6129
6130         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6131         * stap-probe.c (stap_parse_argument): Update.
6132         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6133         initial_size parameter.
6134         * rust-exp.y (rust_lex_tests): Update.
6135         * parse.c (parser_state): Update.
6136         (parse_exp_in_context): Update.
6137         * parser-defs.h (struct parser_state) <parser_state>: Remove
6138         "initial_size" parameter.
6139
6140 2019-04-04  Tom Tromey  <tom@tromey.com>
6141
6142         * parser-defs.h (increase_expout_size): Don't declare.
6143         * parse.c (increase_expout_size): Now static.
6144
6145 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6146
6147         * gnu-nat.c (gnu_nat_target::wait): Fix
6148         target_waitstatus_to_string call.
6149
6150 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6151
6152         * eval.c (evaluate_subexp_standard): Handle internal functions
6153         during Fortran function call handling.
6154
6155 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6156
6157         * NEWS: Mention new internal functions.
6158         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6159         (read_base_type): Use dwarf2_init_complex_target_type.
6160         * value.c (creal_internal_fn): New function.
6161         (cimag_internal_fn): New function.
6162         (_initialize_values): Register new internal functions.
6163
6164 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6165
6166         * infrun.c (stop_all_threads): If debug_infrun, always
6167         trace the wait status after wait_one, using
6168         target_waitstatus_to_string and target_pid_to_str.
6169         (handle_inferior_event): Replace various trace of
6170         wait status kind by a single trace.
6171         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6172         wait status kind image by target_waitstatus_to_string.
6173         * target/waitstatus.c (target_waitstatus_to_string): Fix
6174         obsolete comment.
6175
6176 2019-04-01  Tom Tromey  <tromey@adacore.com>
6177
6178         PR symtab/23331:
6179         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6180
6181 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6182             Pedro Alves  <palves@redhat.com>
6183
6184         * top.c (quit_force): Call 'finalize_values'.
6185         * value.c (finalize_values): New function.
6186         * value.h (finalize_values): Declare.
6187
6188 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6189
6190         * NEWS: Announce $_gdb_major and $_gdb_minor.
6191
6192         * top.c (init_gdb_version_vars): New function.
6193         (gdb_init): Call init_gdb_version_vars.
6194
6195 2019-03-29  Tom Tromey  <tromey@adacore.com>
6196
6197         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6198         help text.  Remove dead code.
6199
6200 2019-03-29  Keith Seitz  <keiths@redhat.com>
6201
6202         From Siddhesh Poyarekar:
6203         * f-lang.h (f77_get_upperbound): Return LONGEST.
6204         (f77_get_lowerbound): Likewise.
6205         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6206         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6207         print them.
6208         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6209         plongest to format print it.
6210         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6211         (f77_get_upperbound): Likewise.
6212         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6213         LOWER_BOUND to LONGEST.
6214         (f77_create_arrayprint_offset_tbl): Likewise.
6215
6216 2019-03-29  Keith Seitz  <keiths@redhat.com>
6217
6218         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6219         %s/pulongest for TYPE_LENGTH instead of %d in format
6220         strings.
6221         * ada-typerint.c (ada_print_type): Likewise.
6222         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6223         * compile/compile-c-support.c (generate_register_struct): Likewise.
6224         * gdbtypes.c (recursive_dump_type): Likewise.
6225         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6226         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6227         instead of %d in format strings.
6228         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6229         to std::min to ULONGEST.
6230         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6231         instead of %d in format strings.
6232         * tracepoint.c (info_scope_command): Likewise.
6233         * typeprint.c (print_offset_data::update)
6234         (print_offset_data::finish): Likewise.
6235         * xtensa-tdep.c (xtensa_store_return_value)
6236         (xtensa_push_dummy_call): Likewise.
6237
6238 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6239
6240         * windows-nat.c (display_selector): Fixed format specifications
6241         for 64-bit Cygwin.
6242
6243 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6244
6245         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6246
6247 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6248
6249         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6250         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6251         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6252         (nios2_linux_init_abi): Install it.
6253
6254 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6255
6256         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6257
6258 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6259
6260         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6261
6262 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6263             Tom Tromey  <tromey@adacore.com>
6264
6265         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6266
6267 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6268
6269         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6270         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6271         method to compute the bounds of range types. Also print "[evaluated]"
6272         if the bounds' values come from a dynamic evaluation.
6273
6274 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6277         whitespace when pretty printing is on.
6278
6279 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6280
6281         * ppc-linux-nat.c: Add include.
6282
6283 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6284
6285         * NEWS: Mention AArch64 Pointer Authentication.
6286
6287 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6288
6289         * arm-linux-nat.c: Add include.
6290
6291 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6292
6293         * source-cache.c (source_cache::get_source_lines): Re-read
6294         fullname after calling open_source_file.
6295
6296 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6297
6298         * NEWS: Mention TLS support for FreeBSD.
6299
6300 2019-03-25  Tom Tromey  <tromey@adacore.com>
6301
6302         * minsyms.c (BUNCH_SIZE): Update comment.
6303         (~minimal_symbol_reader): Remove old comment.
6304         (compact_minimal_symbols): Update comment.
6305         (minimal_symbol_reader::install): Remove old comment.  Update
6306         other comments.
6307
6308 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6309
6310         * s390-linux-nat.c: Add include.
6311
6312 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6313
6314         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6315         Call linux_get_hwcap.
6316         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6317         Likewise.
6318         (aarch64_linux_get_hwcap): Remove function.
6319         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6320         declaration.
6321         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6322         linux_get_hwcap.
6323         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6324         * linux-tdep.c (linux_get_hwcap): Add function.
6325         (linux_get_hwcap2): Likewise.
6326         * linux-tdep.h (linux_get_hwcap): Add declaration.
6327         (linux_get_hwcap2): Likewise.
6328         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6329         (ppc_linux_get_hwcap2): Likewise.
6330         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6331         linux_get_hwcap.
6332         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6333         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6334         (ppc_linux_nat_target::read_description): Likewise.
6335         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6336         * s390-linux-nat.c: Likewise.
6337         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6338
6339 2019-03-24  Tom Tromey  <tom@tromey.com>
6340
6341         * ada-lang.c (standard_lookup): Simplify initialization.
6342         (ada_lookup_symbol_nonlocal): Simplify return.
6343         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6344         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6345         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6346         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6347         initialization.
6348         * solib.c (solib_global_lookup): Simplify.
6349         * symtab.c (null_block_symbol): Remove.
6350         (symbol_cache_lookup): Simplify returns.
6351         (lookup_language_this): Simplify returns.
6352         (lookup_symbol_aux): Simplify return.
6353         (lookup_local_symbol): Simplify returns.
6354         (lookup_global_symbol_from_objfile): Simplify return.
6355         (lookup_symbol_in_objfile_symtabs)
6356         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6357         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6358         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6359         * cp-namespace.c (cp_lookup_bare_symbol)
6360         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6361         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6362         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6363         (cp_lookup_symbol_via_imports): Simplify initialization.
6364         (find_symbol_in_baseclass): Likewise.
6365         * symtab.h (null_block_symbol): Remove.
6366         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6367         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6368         (d_lookup_symbol_module): Likewise.
6369         (find_symbol_in_baseclass): Simplify initialization.
6370
6371 2019-03-24  Tom Tromey  <tom@tromey.com>
6372
6373         * expression.h: Don't include symtab.h.
6374         (struct block): Forward declare.
6375
6376 2019-03-24  Tom Tromey  <tom@tromey.com>
6377
6378         * c-exp.y (typebase): Remove casts.
6379         * gdbtypes.c (lookup_unsigned_typename, )
6380         (lookup_signed_typename): Remove cast.
6381         * eval.c (parse_to_comma_and_eval): Remove cast.
6382         * parse.c (write_dollar_variable): Remove cast.
6383         * block.h (struct block) <superblock>: Now const.
6384         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6385         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6386         (map_block): Make "block" const.
6387         * symfile.h (struct quick_symbol_functions)
6388         <map_matching_symbols>: Constify block argument to "callback".
6389         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6390         const.
6391         (find_pc_sect_compunit_symtab): Make "b" const.
6392         (find_symbol_at_address): Likewise.
6393         (search_symbols): Likewise.
6394         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6395         (dw2_debug_names_lookup_symbol): Likewise.
6396         (dw2_map_matching_symbols): Update.
6397         * p-valprint.c (pascal_val_print): Remove "block".
6398         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6399         (aux_add_nonlocal_symbols): Make "block" const.
6400         (resolve_subexp): Remove cast.
6401         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6402         const.
6403         (iterate_over_file_blocks): Likewise.
6404         * f-exp.y (%union) <bval>: Remove.
6405         * coffread.c (patch_opaque_types): Make "b" const.
6406         * spu-tdep.c (spu_catch_start): Make "block" const.
6407         * c-valprint.c (print_unpacked_pointer): Remove "block".
6408         * symmisc.c (dump_symtab_1): Make "b" const.
6409         (block_depth): Make "block" const.
6410         * d-exp.y (%union) <bval>: Remove.
6411         * cp-support.h (cp_lookup_rtti_type): Update.
6412         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6413         * psymtab.c (psym_lookup_symbol): Make "block" const.
6414         (maintenance_check_psymtabs): Make "b" const.
6415         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6416         (enumerate_locals, enumerate_args): Update.
6417         * python/py-symtab.c (stpy_global_block): Make "block" const.
6418         (stpy_static_block): Likewise.
6419         * inline-frame.c (block_starting_point_at): Make "new_block"
6420         const.
6421         * block.c (find_block_in_blockvector): Make return type const.
6422         (blockvector_for_pc_sect): Make "b" const.
6423         (find_block_in_blockvector): Make "b" const.
6424
6425 2019-03-23  Tom Tromey  <tom@tromey.com>
6426
6427         * varobj.c (varobj_create): Update.
6428         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6429         * printcmd.c (display_command, do_one_display): Don't reset
6430         innermost_block.
6431         * parser-defs.h (enum innermost_block_tracker_type): Move to
6432         expression.h.
6433         (innermost_block): Update comment.
6434         * parse.c (parse_exp_1): Add tracker_types parameter.
6435         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6436         tracker_types parameter.  Reset innermost_block.
6437         (parse_exp_in_context): Remove.
6438         (parse_expression_for_completion): Update.
6439         * objfiles.c (~objfile): Don't reset expression_context_block or
6440         innermost_block.
6441         * expression.h (enum innermost_block_tracker_type): Move from
6442         parser-defs.h.
6443         (parse_exp_1): Add tracker_types parameter.
6444         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6445         reset innermost_block.
6446
6447 2019-03-23  Tom Tromey  <tom@tromey.com>
6448
6449         * objfiles.h: Include bcache.h.
6450
6451 2019-03-23  Tom Tromey  <tom@tromey.com>
6452
6453         * linespec.c (get_current_search_block): Use
6454         scoped_restore_current_language.
6455         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6456
6457 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6458             Jiong Wang  <jiong.wang@arm.com>
6459
6460         * aarch64-linux-tdep.c
6461         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6462         section.
6463         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6464
6465 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6466             Jiong Wang  <jiong.wang@arm.com>
6467
6468         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6469         instructions.
6470         (aarch64_analyze_prologue_test): Add PACIASP test.
6471         (aarch64_prologue_prev_register): Unmask PC value.
6472
6473 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6474             Jiong Wang  <jiong.wang@arm.com>
6475
6476         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6477         (aarch64_dwarf2_prev_register): Unmask PC value.
6478         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6479         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6480         DW_CFA_AARCH64_negate_ra_state.
6481         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6482
6483 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6484             Jiong Wang  <jiong.wang@arm.com>
6485
6486         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6487         registers.
6488         (aarch64_pseudo_register_name): Likewise.
6489         (aarch64_pseudo_register_type): Likewise.
6490         (aarch64_pseudo_register_reggroup_p): Likewise.
6491         (aarch64_gdbarch_init): Add pauth registers.
6492         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6493         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6494         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6495         (struct gdbarch_tdep): Add regnum for ra_state.
6496
6497 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6498             Jiong Wang  <jiong.wang@arm.com>
6499
6500         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6501
6502 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6503             Jiong Wang  <jiong.wang@arm.com>
6504
6505         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6506         function.
6507         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6508         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6509         (aarch64_gdbarch_init): Add puth registers.
6510         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6511         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6512         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6513
6514 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6515             Jiong Wang  <jiong.wang@arm.com>
6516
6517         * aarch64-linux-nat.c
6518         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6519         * aarch64-linux-tdep.c
6520         (aarch64_linux_core_read_description): Likewise.
6521         (aarch64_linux_get_hwcap): New function.
6522         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6523         (aarch64_linux_get_hwcap): New declaration.
6524
6525 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6526             Jiong Wang  <jiong.wang@arm.com>
6527
6528         * aarch64-linux-nat.c
6529         (aarch64_linux_nat_target::read_description): Add pauth param.
6530         * aarch64-linux-tdep.c
6531         (aarch64_linux_core_read_description): Likewise.
6532         * aarch64-tdep.c (struct target_desc): Add in pauth.
6533         (aarch64_read_description): Add pauth param.
6534         (aarch64_gdbarch_init): Likewise.
6535         * aarch64-tdep.h (aarch64_read_description): Likewise.
6536         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6537         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6538         * features/Makefile: Add new files.
6539         * features/aarch64-pauth.c: New file.
6540         * features/aarch64-pauth.xml: New file.
6541
6542 2019-03-20  Tom Tromey  <tromey@adacore.com>
6543
6544         * infrun.c (handle_inferior_event): Rename from
6545         handle_inferior_event_1.  Create a scoped_value_mark.
6546         (handle_inferior_event): Remove.
6547
6548 2019-03-19  Tom Tromey  <tromey@adacore.com>
6549
6550         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6551         * infrun.h (print_stop_event): Add "displays" parameter.
6552         * infrun.c (print_stop_event): Add "displays" parameter.
6553
6554 2019-03-19  Pedro Alves  <palves@redhat.com>
6555
6556         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6557         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6558         to -1.  Fix TABs vs spaces.
6559         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6560         * tui/tui-out.h (tui_ui_out) Add intro comments.
6561         <m_line, m_start_of_line>: In-class initialize, and add describing
6562         comment.
6563
6564 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6565
6566         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6567         variable names.
6568         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6569
6570 2019-03-18  Pedro Alves  <palves@redhat.com>
6571             Eli Zaretskii <eliz@gnu.org>
6572
6573         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6574         m_line and m_start_of_line.
6575
6576 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6577
6578         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6579         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6580         it returns a newline.  This fixes a regression in TU mode, whereby
6581         the next line is output on the same screen line as the user input.
6582
6583 2019-03-18  Tom Tromey  <tromey@adacore.com>
6584
6585         * minsyms.c (minimal_symbol_reader::install): Remove call to
6586         obstack_blank.
6587
6588 2019-03-18  Pedro Alves  <palves@redhat.com>
6589
6590         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6591         New globals.
6592         (apply_style): New, factored out from ...
6593         (apply_ansi_escape): ... this.  Handle reverse video mode.
6594         (tui_set_reverse_mode): New function.
6595         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6596         * tui/tui-winsource.c (tui_show_source_line): Use
6597         tui_set_reverse_mode instead of setting A_STANDOUT.
6598         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6599         New setter methods.
6600
6601 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6602
6603         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6604         Handle tabs.
6605
6606 2019-03-18  Tom Tromey  <tromey@adacore.com>
6607
6608         * ada-lang.c (empty_array): Add "high" parameter.
6609         (ada_evaluate_subexp): Update.
6610
6611 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6612
6613         * unittests/string_view-selftests.c: Define
6614         _initialize_string_view_selftests unconditionally.
6615
6616 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6617
6618         PR gdb/24350
6619         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6620
6621 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6622
6623         PR gdb/24351
6624         * windows-nat.c (display_selector): Fix format specifiers.
6625
6626 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6627
6628         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6629         tui_refill_source_window instead of tui_refresh_win, to update the
6630         current execution line.  This fixes redisplay of the current line
6631         when stepping through the code with "next" or "step".
6632
6633 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6634
6635         * source-cache.c (source_cache::get_source_lines): Call
6636         find_source_lines to initialize s->nlines.  This fixes vertical
6637         scrolling of TUI source window when the DOWN arrow is pressed.
6638
6639 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6640
6641         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6642         linux-thread-db.c (_initialize_thread_db): Likewise.
6643
6644 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6645
6646         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6647         wclrtoeol in tui_show_source_line".  This reverts changes made in
6648         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6649
6650 2019-03-15  Tom Tromey  <tom@tromey.com>
6651
6652         * symtab.h (struct minimal_symbol): Derive from
6653         general_symbol_info.
6654         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6655         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6656         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6657         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6658         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6659         (MSYMBOL_SEARCH_NAME): Update.
6660         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6661         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6662         * minsyms.c (minimal_symbol_reader::record_full): Update.
6663
6664 2019-03-15  Tom Tromey  <tom@tromey.com>
6665
6666         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6667
6668 2019-03-15  Tom Tromey  <tom@tromey.com>
6669
6670         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6671         unique_xmalloc_ptr.
6672         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6673         Update.
6674         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6675         (build_minimal_symbol_hash_tables)
6676         (minimal_symbol_reader::install): Update.
6677
6678 2019-03-15  Tom Tromey  <tom@tromey.com>
6679
6680         * symtab.c (create_demangled_names_hash): Update.
6681         (symbol_set_names): Update.
6682         * objfiles.h (struct objfile_per_bfd_storage)
6683         <demangled_names_hash>: Now an htab_up.
6684         * objfiles.c (objfile_per_bfd_storage): Simplify.
6685
6686 2019-03-15  Tom Tromey  <tom@tromey.com>
6687
6688         * objfiles.h (struct objfile_per_bfd_storage): Declare
6689         destructor.
6690         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6691         New.
6692         (get_objfile_bfd_data): Use new.  Don't initialize
6693         language_of_main.
6694         (free_objfile_per_bfd_storage): Remove.
6695         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6696
6697 2019-03-15  Tom Tromey  <tom@tromey.com>
6698
6699         * symfile.c (reread_symbols): Update.
6700         * objfiles.c (objfile::objfile): Update.
6701         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6702         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6703         comment.
6704         (minimal_symbol_reader::install): Update.
6705         (terminate_minimal_symbol_table): Remove.
6706         * jit.c (jit_object_close_impl): Update.
6707
6708 2019-03-15  Tom Tromey  <tom@tromey.com>
6709
6710         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6711         initializations.
6712
6713 2019-03-15  Tom Tromey  <tom@tromey.com>
6714
6715         * objfiles.h (struct objfile_per_bfd_storage)
6716         <demangled_hash_languages>: Now a bitset.
6717         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6718         (lookup_minimal_symbol): Update.
6719
6720 2019-03-15  Tom Tromey  <tom@tromey.com>
6721
6722         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6723         Don't return the symbol.
6724         * coffread.c (record_minimal_symbol): Use record_full.
6725
6726 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6727
6728         The MS-Windows port of ncurses fails to switch to a color pair if
6729         one or both of the colors are the implicit default colors.  This
6730         change records the default colors when TUI is initialized, and
6731         then specifies them explicitly when a color pair uses the default
6732         colors.  This allows color styling in TUI mode on MS-Windows.
6733
6734         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6735         ncurses_norm_attr.
6736         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6737         colors in ncurses_norm_attr.
6738         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6739         "none", replace it with the default color recorded in
6740         ncurses_norm_attr.
6741
6742 2019-03-14  Tom Tromey  <tromey@adacore.com>
6743
6744         * source-cache.h (class source_cache) <get_source_lines>: Return
6745         std::string.
6746         * source-cache.c (source_cache::extract_lines): Handle case where
6747         first_pos==npos.  Return std::string.
6748         (source_cache::get_source_lines): Update.
6749
6750 2019-03-14  Tom Tromey  <tromey@adacore.com>
6751
6752         * NEWS: Add item for "style sources" commands.
6753         * source-cache.c (source_cache::get_source_lines): Check
6754         source_styling.
6755         * cli/cli-style.c (source_styling): New global.
6756         (_initialize_cli_style): Add "style sources" commands.
6757         (show_style_sources): New function.
6758         * cli/cli-style.h (source_styling): Declare.
6759
6760 2019-03-14  Pedro Alves  <palves@redhat.com>
6761             Tom Tromey  <tromey@adacore.com>
6762
6763         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6764         * tui/tui-winsource.c (tui_refill_source_window): New function,
6765         from...
6766         (tui_horizontal_source_scroll): ... here.  Move some logic.
6767         * cli/cli-style.c (set_style_enabled): Notify new observable.
6768         * tui/tui-hooks.c (tui_redisplay_source): New function.
6769         (tui_attach_detach_observers): Attach or detach
6770         tui_redisplay_source.
6771         * observable.h (source_styling_changed): New observable.
6772         * observable.c: Define source_styling_changed observable.
6773
6774 2019-03-13  Tom Tromey  <tromey@adacore.com>
6775
6776         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6777         (i386_gnu_nat_target::store_registers): Update.
6778         * target-debug.h (target_debug_print_std_string): New macro.
6779         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6780         * windows-tdep.c (display_one_tib): Update.
6781         * tui/tui-stack.c (tui_make_status_line): Update.
6782         * top.c (print_inferior_quit_action): Update.
6783         * thread.c (thr_try_catch_cmd): Update.
6784         (add_thread_with_info): Update.
6785         (thread_target_id_str): Update.
6786         (thr_try_catch_cmd): Update.
6787         (thread_command): Update.
6788         (thread_find_command): Update.
6789         * record-btrace.c (record_btrace_target::info_record)
6790         (record_btrace_resume_thread, record_btrace_target::resume)
6791         (record_btrace_cancel_resume, record_btrace_step_thread)
6792         (record_btrace_target::wait, record_btrace_target::wait)
6793         (record_btrace_target::wait, record_btrace_target::stop): Update.
6794         * progspace.c (print_program_space): Update.
6795         * process-stratum-target.c
6796         (process_stratum_target::thread_address_space): Update.
6797         * linux-fork.c (linux_fork_mourn_inferior)
6798         (detach_checkpoint_command, info_checkpoints_command)
6799         (linux_fork_context): Update.
6800         (linux_fork_detach): Update.
6801         (class scoped_switch_fork_info): Update.
6802         (delete_checkpoint_command): Update.
6803         * infrun.c (follow_fork_inferior): Update.
6804         (follow_fork_inferior): Update.
6805         (proceed_after_vfork_done): Update.
6806         (handle_vfork_child_exec_or_exit): Update.
6807         (follow_exec): Update.
6808         (displaced_step_prepare_throw): Update.
6809         (displaced_step_restore): Update.
6810         (start_step_over): Update.
6811         (resume_1): Update.
6812         (clear_proceed_status_thread): Update.
6813         (proceed): Update.
6814         (print_target_wait_results): Update.
6815         (do_target_wait): Update.
6816         (context_switch): Update.
6817         (stop_all_threads): Update.
6818         (restart_threads): Update.
6819         (finish_step_over): Update.
6820         (handle_signal_stop): Update.
6821         (switch_back_to_stepped_thread): Update.
6822         (keep_going_pass_signal): Update.
6823         (print_exited_reason): Update.
6824         (normal_stop): Update.
6825         * inferior.c (inferior_pid_to_str): Change return type.
6826         (print_selected_inferior): Update.
6827         (add_inferior): Update.
6828         (detach_inferior): Update.
6829         * dummy-frame.c (fprint_dummy_frames): Update.
6830         * dcache.c (dcache_info_1): Update.
6831         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6832         (btrace_fetch, btrace_clear): Update.
6833         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6834         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6835         type.
6836         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6837         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6838         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6839         * gdbarch.c, gdbarch.h: Rebuild.
6840         * gdbarch.sh (core_pid_to_str): Change return type.
6841         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6842         return type.
6843         (windows_nat_target::pid_to_str): Change return type.
6844         (windows_delete_thread): Update.
6845         (windows_nat_target::attach): Update.
6846         (windows_nat_target::files_info): Update.
6847         * target-delegates.c: Rebuild.
6848         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6849         return type.
6850         (sol_thread_target::pid_to_str): Change return type.
6851         * remote.c (class remote_target) <pid_to_str>: Change return
6852         type.
6853         (remote_target::pid_to_str): Change return type.
6854         (extended_remote_target::attach, remote_target::remote_stop_ns)
6855         (remote_target::remote_notif_remove_queued_reply)
6856         (remote_target::push_stop_reply, remote_target::disable_btrace):
6857         Update.
6858         (extended_remote_target::attach): Update.
6859         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6860         type.
6861         (gdbsim_target::pid_to_str): Change return type.
6862         * ravenscar-thread.c (struct ravenscar_thread_target)
6863         <pid_to_str>: Change return type.
6864         (ravenscar_thread_target::pid_to_str): Change return type.
6865         * procfs.c (class procfs_target) <pid_to_str>: Change return
6866         type.
6867         (procfs_target::pid_to_str): Change return type.
6868         (procfs_target::attach): Update.
6869         (procfs_target::detach): Update.
6870         (procfs_target::fetch_registers): Update.
6871         (procfs_target::store_registers): Update.
6872         (procfs_target::wait): Update.
6873         (procfs_target::files_info): Update.
6874         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6875         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6876         return type.
6877         (nto_procfs_target::pid_to_str): Change return type.
6878         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6879         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6880         return type.
6881         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6882         (exit_lwp): Update.
6883         (attach_proc_task_lwp_callback, get_detach_signal)
6884         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6885         (linux_nat_target::resume, wait_lwp, stop_callback)
6886         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6887         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6888         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6889         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6890         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6891         type.
6892         (inf_ptrace_target::attach): Update.
6893         (inf_ptrace_target::files_info): Update.
6894         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6895         type.
6896         (go32_nat_target::pid_to_str): Change return type.
6897         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6898         (gnu_nat_target::wait): Update.
6899         (gnu_nat_target::wait): Update.
6900         (gnu_nat_target::resume): Update.
6901         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6902         (fbsd_nat_target::wait): Update.
6903         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6904         type.
6905         (darwin_nat_target::attach): Update.
6906         * corelow.c (class core_target) <pid_to_str>: Change return type.
6907         (core_target::pid_to_str): Change return type.
6908         * target.c (normal_pid_to_str): Change return type.
6909         (default_pid_to_str): Likewise.
6910         (target_pid_to_str): Change return type.
6911         (target_translate_tls_address): Update.
6912         (target_announce_detach): Update.
6913         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6914         return type.
6915         (bsd_uthread_target::pid_to_str): Change return type.
6916         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6917         type.
6918         (bsd_kvm_target::pid_to_str): Change return type.
6919         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6920         return type.
6921         (aix_thread_target::pid_to_str): Change return type.
6922         * target.h (struct target_ops) <pid_to_str>: Change return type.
6923         (target_pid_to_str, normal_pid_to_str): Likewise.
6924         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6925         type.
6926         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6927         type.
6928         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6929         return type.
6930         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6931         type.
6932         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6933         type.
6934         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6935         return type.
6936
6937 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6938
6939         * NEWS: Mention that the new default MI version is 3.  Mention
6940         changes to the output of commands and events that deal with
6941         multi-location breakpoints.
6942         * breakpoint.c: Include "mi/mi-out.h".
6943         (print_one_breakpoint): Change output syntax if using MI version
6944         >= 3.
6945         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6946         New.
6947         (mi_multi_location_breakpoint_output_fixed): New.
6948         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6949         (mi_cmd_fix_multi_location_breakpoint_output): New.
6950         (mi_multi_location_breakpoint_output_fixed): New.
6951         * mi/mi-cmds.c (mi_cmds): Register command
6952         -fix-multi-location-breakpoint-output.
6953         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6954         interpreter "mi".
6955
6956 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6957
6958         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6959         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6960         instantiate mi_ui_out based on interpreter name.
6961         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6962         * mi/mi-main.c (mi_load_progress): Likewise.
6963
6964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6965
6966         * NEWS: Combine separate "New targets" sections for 8.3.
6967
6968 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6969
6970         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6971         (ppcfbsd_init_abi): Install gdbarch
6972         "fetch_tls_load_module_address" and "get_thread_local_address"
6973         methods.
6974
6975 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6976
6977         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6978         (riscv_fbsd_init_abi): Install gdbarch
6979         "fetch_tls_load_module_address" and "get_thread_local_address"
6980         methods.
6981
6982 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6983
6984         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6985         (i386fbsd_init_abi): Install gdbarch
6986         "fetch_tls_load_module_address" and "get_thread_local_address"
6987         methods.
6988
6989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6990
6991         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6992         (amd64fbsd_init_abi): Install gdbarch
6993         "fetch_tls_load_module_address" and "get_thread_local_address"
6994         methods.
6995
6996 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6997
6998         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6999         (struct fbsd_pspace_data): New type.
7000         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7001         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7002         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7003         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7004         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7005
7006 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7007
7008         * gdbtypes.c (lookup_struct_elt): New function.
7009         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7010         * gdbtypes.h (struct struct_elt): New type.
7011         (lookup_struct_elt): New prototype.
7012
7013 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7014
7015         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7016         remove disabled code block.
7017
7018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7019
7020         * gdbarch.sh (get_thread_local_address): New method.
7021         * gdbarch.h, gdbarch.c: Regenerate.
7022         * target.c (target_translate_tls_address): Use
7023         gdbarch_get_thread_local_address if present instead of
7024         target::get_thread_local_address.
7025
7026 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7027
7028         * target.h (target::get_thread_local_address): Update comment.
7029
7030 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7031
7032         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7033         objfile->separate_debug_objfile_backlink if not NULL.
7034
7035 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7036
7037         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7038         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7039         (amd64bsd_store_inferior_registers): Likewise.
7040         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7041         Enable segment base registers.
7042         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7043         PT_GETFSBASE and PT_GETGSBASE.
7044         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7045         PT_SETGSBASE.
7046         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7047         segment base registers.
7048         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7049
7050 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7051
7052         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7053         Update calls to i386_target_description to add 'segments'
7054         parameter.
7055         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7056         add segment base registers.
7057         * arch/i386.c (i386_create_target_description): Add 'segments'
7058         parameter to enable segment base registers.
7059         * arch/i386.h (i386_create_target_description): Likewise.
7060         * features/i386/32bit-segments.xml: New file.
7061         * features/i386/32bit-segments.c: Generate.
7062         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7063         call to i386_target_description to add 'segments' parameter.
7064         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7065         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7066         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7067         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7068         if feature is present.
7069         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7070         Add 'segments' parameter to call to i386_target_description.
7071         (i386_target_description): Add 'segments' parameter to enable
7072         segment base registers.
7073         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7074         to call to i386_target_description.
7075         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7076         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7077         Define I386_NUM_REGS.
7078         (i386_target_description): Add 'segments' parameter to enable
7079         segment base registers.
7080
7081 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7082
7083         PR/24325
7084         * source-cache.c: #undef open and close, to avoid unresolved
7085         externals during linking.
7086
7087 2019-03-12  Tom Tromey  <tromey@adacore.com>
7088
7089         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7090         const.  Add initializers.
7091         (_initialize_remote): Don't initialize ptid globals.
7092
7093 2019-03-12  Pedro Alves  <palves@redhat.com>
7094
7095         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7096
7097 2019-03-12  Pedro Alves  <palves@redhat.com>
7098
7099         * cp-name-parser.y (main): Remove unused 'len' variable.
7100
7101 2019-03-12  Tom Tromey  <tromey@adacore.com>
7102
7103         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7104         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7105
7106 2019-03-12  Tom Tromey  <tromey@adacore.com>
7107
7108         * linux-nat.c (iterate_over_lwps): Update.
7109         (stop_callback): Remove parameter.
7110         (stop_wait_callback, detach_callback, resume_set_callback)
7111         (select_singlestep_lwp_callback, set_ignore_sigint)
7112         (status_callback, resumed_callback, resume_clear_callback)
7113         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7114         data parameter.
7115         (linux_nat_target::detach, linux_nat_target::resume)
7116         (linux_stop_and_wait_all_lwps, select_event_lwp)
7117         (linux_nat_filter_event, linux_nat_wait_1)
7118         (linux_nat_target::kill, linux_nat_target::stop)
7119         (linux_nat_target::stop): Update.
7120         (linux_nat_resume_callback): Change type.
7121         (resume_stopped_resumed_lwps, count_events_callback)
7122         (select_event_lwp_callback): Likewise.
7123         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7124         * arm-linux-nat.c (struct update_registers_data): Remove.
7125         (update_registers_callback): Change type.
7126         (arm_linux_insert_hw_breakpoint1): Update.
7127         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7128         parameter.
7129         (x86_linux_dr_set_addr): Update.
7130         (x86_linux_dr_set_control): Update.
7131         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7132         (iterate_over_lwps): Use gdb::function_view.
7133         * nat/aarch64-linux-hw-point.c (struct
7134         aarch64_dr_update_callback_param): Remove.
7135         (debug_reg_change_callback): Change type.
7136         (aarch64_notify_debug_reg_change): Update.
7137         * s390-linux-nat.c (s390_refresh_per_info): Update.
7138
7139 2019-03-11  Tom Tromey  <tromey@adacore.com>
7140
7141         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7142         redundant assignment to "this_cu".
7143
7144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7145
7146         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7147
7148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7149
7150         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7151         from...
7152         (rank_one_type): ... this.
7153
7154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7155
7156         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7157         from...
7158         (rank_one_type): ... this.
7159
7160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7161
7162         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7163         from...
7164         (rank_one_type): ... this.
7165
7166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7167
7168         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7169         from...
7170         (rank_one_type): ... this.
7171
7172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7173
7174         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7175         from...
7176         (rank_one_type): ... this.
7177
7178 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7179
7180         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7181         from...
7182         (rank_one_type): ... this.
7183
7184 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7185
7186         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7187         from...
7188         (rank_one_type): ... this.
7189
7190 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7191
7192         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7193         from...
7194         (rank_one_type): ... this.
7195
7196 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7197
7198         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7199         from...
7200         (rank_one_type): ... this.
7201
7202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7203
7204         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7205         from...
7206         (rank_one_type): ... this.
7207
7208 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7209
7210         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7211         from...
7212         (rank_one_type): ... this.
7213
7214 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7215
7216         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7217         from...
7218         (rank_one_type): ... this.
7219
7220 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7221
7222         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7223         inferior-events' shows the example events.
7224
7225 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7226
7227         Support styling on native MS-Windows console
7228
7229         PR/24315
7230         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7231         on MS-Windows if $TERM is not defined.
7232
7233         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7234
7235         * posix-hdep.c (gdb_console_fputs):
7236         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7237         functions.
7238         * ui-file.h (gdb_console_fputs): Add prototype.
7239
7240         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7241         back to fputs only if the former returns zero.
7242
7243 2019-03-07  Tom Tromey  <tom@tromey.com>
7244
7245         * symmisc.c (print_symbol_bcache_statistics): Update.
7246         (print_objfile_statistics): Update.
7247         * symfile.c (allocate_symtab): Update.
7248         * stabsread.c: Don't include bcache.h.
7249         * psymtab.h (struct psymbol_bcache): Don't declare.
7250         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7251         (psymbol_bcache_init, psymbol_bcache_free)
7252         (psymbol_bcache_get_bcache): Don't declare.
7253         * psymtab.c (struct psymbol_bcache): Remove.
7254         (psymtab_storage::psymtab_storage): Update.
7255         (psymtab_storage::~psymtab_storage): Update.
7256         (psymbol_bcache_init, psymbol_bcache_free)
7257         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7258         (add_psymbol_to_bcache): Update.
7259         (allocate_psymtab): Update.
7260         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7261         macro_cache>: No longer pointers.
7262         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7263         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7264         * macrotab.c (macro_bcache): Update.
7265         * macroexp.c: Don't include bcache.h.
7266         * gdbtypes.c (check_types_worklist): Update.
7267         (types_deeply_equal): Remove TRY/CATCH.  Update.
7268         * elfread.c (elf_symtab_read): Update.
7269         * dwarf2read.c: Don't include bcache.h.
7270         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7271         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7272         (print_bcache_statistics, bcache_memory_used): Don't declare.
7273         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7274         methods.  Rename all data members.
7275         * bcache.c (struct bcache): Move to bcache.h.
7276         (bcache::expand_hash_table): Rename from expand_hash_table.
7277         (bcache): Remove.
7278         (bcache::insert): Rename from bcache_full.
7279         (bcache::compare): Rename from bcache_compare.
7280         (bcache_xmalloc): Remove.
7281         (bcache::~bcache): Rename from bcache_xfree.
7282         (bcache::print_statistics): Rename from print_bcache_statistics.
7283         (bcache::memory_used): Rename from bcache_memory_used.
7284
7285 2019-03-07  Pedro Alves  <palves@redhat.com>
7286
7287         * infrun.c (normal_stop): Also check for
7288         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7289
7290 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7291
7292         * f-lang.c (value_from_host_double): Moved to...
7293         * value.c (value_from_host_double): ...here.
7294         * value.h (value_from_host_double): Declare.
7295         * guile/scm-math.c (vlscm_convert_typed_number): Use
7296         value_from_host_double.
7297         (vlscm_convert_number): Likewise.
7298         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7299         * python/py-value.c (convert_value_from_python): Likewise.
7300
7301 2019-03-06  Tom Tromey  <tom@tromey.com>
7302
7303         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7304
7305 2019-03-06  Tom Tromey  <tom@tromey.com>
7306
7307         * utils.h (free_current_contents): Don't declare.
7308         * utils.c (free_current_contents): Remove.
7309
7310 2019-03-06  Tom Tromey  <tom@tromey.com>
7311
7312         * top.c (quit_force): Update.
7313         * main.c (captured_command_loop): Update.
7314         * common/new-op.c (operator new): Update.
7315         * common/common-exceptions.c (struct catcher)
7316         <save_cleanup_chain>: Remove member.
7317         (exceptions_state_mc_init): Update.
7318         (exception_try_scope_entry): Return nullptr.
7319         (exception_try_scope_exit, exception_rethrow)
7320         (throw_exception_sjlj, throw_exception_cxx): Update.
7321         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7322         (all_cleanups, do_cleanups, discard_cleanups)
7323         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7324         (restore_cleanups, restore_final_cleanups): Don't declare.
7325         (do_final_cleanups): Remove parameter.
7326         * common/cleanups.c (cleanup_chain, make_cleanup)
7327         (make_cleanup_dtor, all_cleanups, do_cleanups)
7328         (discard_my_cleanups, discard_cleanups)
7329         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7330         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7331         (null_cleanup): Remove.
7332         (do_final_cleanups): Remove parameter.
7333
7334 2019-03-06  Tom Tromey  <tom@tromey.com>
7335
7336         * remote.c (remote_target::remote_parse_stop_reply): Use
7337         unique_xmalloc_ptr.
7338
7339 2019-03-06  Tom Tromey  <tom@tromey.com>
7340
7341         * stabsread.c (struct stabs_field_info): Rename from field_info.
7342         <list, fnlist>: Add initializers.
7343         <obstack>: New member.
7344         (read_member_functions, read_struct_fields, read_baseclasses):
7345         Allocate on obstack.  Don't use cleanups.
7346         (read_one_struct_field, read_member_functions, read_struct_fields)
7347         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7348         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7349         (read_struct_type): Update.
7350
7351 2019-03-06  Tom Tromey  <tom@tromey.com>
7352
7353         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7354         * common/filestuff.h (make_cleanup_close): Don't declare.
7355         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7356         Remove.
7357
7358 2019-03-06  Tom Tromey  <tom@tromey.com>
7359
7360         * solib-aix.c: Use make_scope_exit.
7361
7362 2019-03-06  Tom Tromey  <tom@tromey.com>
7363
7364         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7365         Use make_scope_exit.
7366
7367 2019-03-06  Tom Tromey  <tom@tromey.com>
7368
7369         * solib-svr4.c (disable_probes_interface): Remove parameter.
7370         (svr4_handle_solib_event): Use make_scope_exit.
7371
7372 2019-03-06  Tom Tromey  <tom@tromey.com>
7373
7374         * remote.c (struct stop_reply_deleter): Remove.
7375         (stop_reply_up): Update.
7376         (struct stop_reply): Derive from notif_event.  Don't typedef.
7377         <regcache>: Now a std::vector.
7378         (stop_reply_xfree): Remove.
7379         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7380         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7381         (remote_target::discard_pending_stop_replies): Use delete.
7382         (remote_target::remote_parse_stop_reply): Update.
7383         (remote_target::process_stop_reply): Update.
7384         * remote-notif.h (struct notif_event): Add virtual destructor.
7385         Remove "dtr" member.
7386         (struct notif_client) <alloc_event>: Return a unique_ptr.
7387         (notif_event_xfree): Don't declare.
7388         (notif_event_up): New typedef.
7389         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7390         (notif_event_xfree, do_notif_event_xfree): Remove.
7391         (remote_notif_state_xfree): Update.
7392
7393 2019-03-06  Tom Tromey  <tom@tromey.com>
7394
7395         * infrun.c (displaced_step_clear_cleanup): Now a
7396         forward_scope_exit type.
7397         (displaced_step_prepare_throw): Update.
7398         (displaced_step_fixup): Update.
7399
7400 2019-03-06  Tom Tromey  <tom@tromey.com>
7401
7402         * inferior.h (class inferior): Update comment.
7403         * gdbthread.h (class thread_info): Update comment.
7404
7405 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7406             Tom Tromey  <tom@tromey.com>
7407
7408         * stabsread.h (struct stab_section_list): Remove.
7409         (coffstab_build_psymtabs): Update.
7410         * dbxread.c (symbuf_sections): Now a std::vector.
7411         (sect_idx): New global.
7412         (fill_symbuf): Update.
7413         (coffstab_build_psymtabs): Change type of stabsects parameter.
7414         Update.
7415         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7416         std::vector.
7417         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7418         (coff_locate_sections): Update.
7419         (coff_symfile_read): Remove cleanups.  Update.
7420         (init_stringtab): Add storage parameter.
7421         (free_stringtab, free_stringtab_cleanup): Remove.
7422         (init_lineno): Add storage parameter.
7423         (free_linetab, free_linetab_cleanup): Remove.
7424
7425 2019-03-06  Pedro Alves  <palves@redhat.com>
7426
7427         * linux-fork.c (fork_info::clobber_regs): Delete.
7428         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7429         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7430         comment.  Adjust.
7431         (scoped_switch_fork_info::scoped_switch_fork_info)
7432         (checkpoint_command, linux_fork_context): Adjust
7433         fork_save_infrun_state calls.
7434
7435 2019-03-06  Pedro Alves  <palves@redhat.com>
7436
7437         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7438         (inf_has_multiple_threads): Return 'bool' and rewrite using
7439         inferior_info::threads().
7440
7441 2019-03-06  Pedro Alves  <palves@redhat.com>
7442
7443         * linux-fork.c: Include <list>.
7444         (fork_list): Now a std::list instance.
7445         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7446         (forks_exist_p, find_last_fork): Adjust.
7447         (new_fork): Delete.
7448         (one_fork_p): New.
7449         (add_fork): Adjust.
7450         (free_fork): Delete, folded into fork_info::~fork_info().
7451         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7452         Adjust.
7453         (init_fork_list): Delete.
7454         (linux_fork_killall, linux_fork_mourn_inferior)
7455         (linux_fork_detach, info_checkpoints_command): Adjust.
7456         (_initialize_linux_fork): No longer call init_fork_list.
7457
7458 2019-03-06  Pedro Alves  <palves@redhat.com>
7459
7460         * linux-fork.c (new_fork): New, split out of ...
7461         (add_fork): ... this.  Return void.  Move "first fork" special
7462         case from here, to ...
7463         (checkpoint_command): ... here.
7464         * linux-linux.h (add_fork): Return void.
7465
7466 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7467
7468         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7469
7470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7471             Chris January  <chris.january@arm.com>
7472             David Lecomber  <david.lecomber@arm.com>
7473
7474         * f-exp.y: New token, UNOP_INTRINSIC.
7475         (exp): New pattern using UNOP_INTRINSIC token.
7476         (f77_keywords): Add 'abs' keyword.
7477         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7478         (value_from_host_double): New function.
7479         (evaluate_subexp_f): Support UNOP_ABS.
7480
7481 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7482
7483         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7484         types.
7485
7486 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7487
7488         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7489         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7490         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7491
7492 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7493
7494         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7495
7496 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7497             Chris January  <chris.january@arm.com>
7498
7499         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7500         * f-exp.y: Define 'KIND' token.
7501         (exp): New pattern for KIND expressions.
7502         (ptype): Handle types with a kind extension.
7503         (direct_abs_decl): Extend to spot kind extensions.
7504         (f77_keywords): Add 'kind' to the list.
7505         (push_kind_type): New function.
7506         (convert_to_kind_type): New function.
7507         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7508         * parse.c (operator_length_standard): Likewise.
7509         * parser-defs.h (enum type_pieces): Add tp_kind.
7510         * std-operator.def: Add UNOP_KIND.
7511
7512 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7513
7514         * f-exp.y (f_parse): Set yydebug.
7515
7516 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7517
7518         * f-lang.c (evaluate_subexp_f): New function.
7519         (exp_descriptor_f): New global.
7520         (f_language_defn): Use exp_descriptor_f instead of
7521         exp_descriptor_standard.
7522
7523 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7524
7525         * f-exp.y (struct token): Add comments.
7526         (dot_ops): Remove uppercase versions and the end marker.
7527         (f77_keywords): Likewise.
7528         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7529         entries in the dot_ops array are case insensitive, and use
7530         strncasecmp to compare strings.  Also some whitespace cleanup in
7531         this area.  Similar for the f77_keywords array, except entries in
7532         this list might be case sensitive.
7533
7534 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7535
7536         * f-exp.y (struct f77_boolean_val): Add comments.
7537         (boolean_values): Remove uppercase versions, and end marker.
7538         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7539         and use strncasecmp to achieve case insensitivity.  Additionally,
7540         perform whitespace cleanup around this code.
7541
7542 2019-03-06  Tom Tromey  <tromey@adacore.com>
7543
7544         * remote-sim.c (gdbsim_target_open): Use result of
7545         gdb_argv::release.
7546
7547 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7548         Dirk Schubert  <dirk.schubert@arm.com>
7549         Chris January  <chris.january@arm.com>
7550
7551         * eval.c (evaluate_subexp_standard): Call Fortran argument
7552         wrapping logic.
7553         * f-lang.c (struct value): A value which can be passed into a
7554         Fortran function call.
7555         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7556         where appropriate.
7557         (struct type): Value ready for a Fortran function call.
7558         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7559         is needed.
7560         * f-lang.h (fortran_argument_convert): Declaration.
7561         (fortran_preserve_arg_pointer): Declaration.
7562         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7563
7564 2019-03-05  Tom Tromey  <tromey@adacore.com>
7565
7566         * python/py-prettyprint.c (print_string_repr): Remove #if.
7567         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7568
7569 2019-03-05  Tom Tromey  <tromey@adacore.com>
7570
7571         * target.c (the_dummy_target): Move later.  Change type to
7572         "dummy_target".
7573         (initialize_targets): Don't initialize the_dummy_target.
7574
7575 2019-03-05  Tom Tromey  <tromey@adacore.com>
7576
7577         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7578         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7579
7580 2019-03-05  Tom Tromey  <tromey@adacore.com>
7581
7582         * windows-nat.c (windows_nat_target::attach)
7583         (windows_nat_target::detach): Don't call gdb_flush.
7584         * valprint.c (generic_val_print, val_print, val_print_string):
7585         Don't call gdb_flush.
7586         * utils.c (defaulted_query): Don't call gdb_flush.
7587         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7588         * target.c (target_announce_detach): Don't call gdb_flush.
7589         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7590         * remote.c (extended_remote_target::attach): Don't call
7591         gdb_flush.
7592         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7593         * printcmd.c (do_examine): Don't call gdb_flush.
7594         (info_display_command): Don't call gdb_flush.
7595         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7596         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7597         * memattr.c (info_mem_command): Don't call gdb_flush.
7598         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7599         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7600         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7601         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7602         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7603         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7604         (gnu_nat_target::detach): Don't call gdb_flush.
7605         * f-valprint.c (f_val_print): Don't call gdb_flush.
7606         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7607         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7608         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7609         gdb_flush.
7610         * c-valprint.c (c_val_print): Don't call gdb_flush.
7611         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7612
7613 2019-03-05  Tom Tromey  <tromey@adacore.com>
7614
7615         * varobj.c (update_dynamic_varobj_children): Update.
7616         (install_default_visualizer): Use reset, not release.
7617         * value.c (set_internalvar): Update.
7618         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7619         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7620         ATTRIBUTE_UNUSED_RESULT.
7621
7622 2019-03-05  Tom Tromey  <tromey@adacore.com>
7623
7624         * remote.c (class scoped_remote_fd) <release>: Add
7625         ATTRIBUTE_UNUSED_RESULT.
7626
7627 2019-03-05  Tom Tromey  <tromey@adacore.com>
7628
7629         * macroexp.c (struct macro_buffer) <release>: Add
7630         ATTRIBUTE_UNUSED_RESULT.
7631
7632 2019-03-05  Tom Tromey  <tromey@adacore.com>
7633
7634         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7635         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7636         ATTRIBUTE_UNUSED_RESULT.
7637
7638 2019-03-05  Tom Tromey  <tromey@adacore.com>
7639
7640         * common/scoped_fd.h (class scoped_fd) <release>: Add
7641         ATTRIBUTE_UNUSED_RESULT.
7642
7643 2019-03-05  Tom Tromey  <tromey@adacore.com>
7644
7645         * parser-defs.h (struct parser_state) <release>: Add
7646         ATTRIBUTE_UNUSED_RESULT.
7647
7648 2019-03-05  Tom Tromey  <tromey@adacore.com>
7649
7650         * utils.h (class gdb_argv) <release>: Add
7651         ATTRIBUTE_UNUSED_RESULT.
7652         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7653
7654 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7655
7656         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7657         for-loop range, to avoid compiler warnings.
7658
7659         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7660         avoid compiler warnings about unused variables.
7661
7662         * NEWS: Mention end of support for native debugging on MS-Windows
7663         before XP.
7664
7665         PR gdb/24292
7666         * common/netstuff.c:
7667         * gdbserver/gdbreplay.c
7668         * gdbserver/remote-utils.c:
7669         * ser-tcp.c:
7670         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7671         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7672         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7673         'getaddrinfo' and 'freeaddrinfo' were not available before
7674         Windows XP, and mingw.org's MinGW headers by default define
7675         _WIN32_WINNT to 0x500.
7676
7677 2019-03-01  Gary Benson <gbenson@redhat.com>
7678
7679         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7680
7681 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7682             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7683
7684         PR gdb/8527
7685         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7686         set_sigint_trap, clear_sigint_trap.
7687
7688 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7689
7690         * target.c (target_detach): Clear the regcache and the
7691         frame cache.
7692
7693 2019-02-27  Pedro Alves  <palves@redhat.com>
7694
7695         * utils.c (set_screen_size): When we cap the height/width sizes,
7696         tweak the corresponding command variable to show "unlimited":
7697
7698 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7699             Pedro Alves  <palves@redhat.com>
7700
7701         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7702         before calling rl_set_screen_size.
7703
7704 2019-02-27  Tom Tromey  <tromey@adacore.com>
7705
7706         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7707         define.
7708         * python/py-value.c: Remove Python 2.4 workaround.
7709         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7710         workaround.
7711         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7712         Python 2.4 workaround.
7713         * python/python-internal.h: Remove Python 2.4 comment.
7714         (Py_ssize_t): Don't define.
7715         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7716         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7717         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7718         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7719         * python/python.c (do_start_initialization): Remove Python 2.4
7720         workaround.
7721         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7722         (print_children): Remove Python 2.4 workaround.
7723         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7724         workaround.
7725         (CHARBUFFERPROC_NAME): Remove.
7726         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7727         Python 2.4 workaround.
7728
7729 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7730
7731         * NEWS: Note minimum Python version.
7732
7733 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7734
7735         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7736         code from these functions.  Remove corresponding ifdefs.  Use
7737         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7738         Remove gotos and target of gotos.
7739         (infpy_search_memory): Likewise.
7740
7741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7742
7743         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7744         (hppa_gdbarch_init): Don't register deleted functions with
7745         gdbarch.
7746
7747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7748
7749         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7750         (h8300_unwind_sp): Delete.
7751         (h8300_dummy_id): Delete.
7752         (h8300_gdbarch_init): Don't register deleted functions with
7753         gdbarch.
7754
7755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7756
7757         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7758         (ft32_unwind_pc): Delete.
7759         (ft32_unwind_sp): Delete.
7760         (ft32_gdbarch_init): Don't register deleted functions with
7761         gdbarch.
7762
7763 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7764
7765         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7766         (frv_unwind_pc): Delete.
7767         (frv_unwind_sp): Delete.
7768         (frv_gdbarch_init): Don't register deleted functions with
7769         gdbarch.
7770
7771 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7772
7773         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7774         (riscv_unwind_pc): Delete.
7775         (riscv_unwind_sp): Delete.
7776         (riscv_gdbarch_init): Don't register deleted functions with
7777         gdbarch.
7778
7779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7780
7781         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7782         (csky_unwind_pc): Delete.
7783         (csky_unwind_sp): Delete.
7784         (csky_gdbarch_init): Don't register deleted functions with
7785         gdbarch.
7786
7787 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7788
7789         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7790         (cris_unwind_pc): Delete.
7791         (cris_unwind_sp): Delete.
7792         (cris_gdbarch_init): Don't register deleted functions with
7793         gdbarch.
7794
7795 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7796
7797         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7798         (bfin_unwind_pc): Delete.
7799         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7800
7801 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7802
7803         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7804         (arm_unwind_pc): Delete.
7805         (arm_unwind_sp): Delete.
7806         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7807
7808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7809
7810         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7811         (arc_unwind_pc): Delete.
7812         (arc_unwind_sp): Delete.
7813         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7814
7815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7816
7817         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7818         (alpha_unwind_pc): Delete.
7819         (alpha_gdbarch_init): Don't register deleted functions with
7820         gdbarch.
7821
7822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7823
7824         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7825         (aarch64_unwind_pc): Delete.
7826         (aarch64_unwind_sp): Delete.
7827         (aarch64_gdbarch_init): Don't register deleted functions with
7828         gdbarch.
7829
7830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7831
7832         * gdbtypes.c (type_align): Don't consider static members when
7833         computing structure alignment.
7834
7835 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7836
7837         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7838         return 0 for other types.
7839         * arch-utils.c (default_type_align): Always return 0.
7840         * gdbarch.h: Regenerate.
7841         * gdbarch.sh (type_align): Extend comment.
7842         * gdbtypes.c (type_align): Add additional comments, always call
7843         gdbarch_type_align before applying the default rules.
7844         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7845         generic code will then apply a suitable default.
7846         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7847         types, return 0 for other types.
7848
7849 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7850
7851         * NEWS: Create a new section for the next release branch.
7852         Rename the section of the current branch, now that it has
7853         been cut.
7854
7855 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7856
7857         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7858         * version.in: Bump version to 8.3.50.DATE-git.
7859
7860 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7861
7862         * aix-thread.c (ptid_cmp): Remove unused variable.
7863         (get_signaled_thread): Likewise.
7864         (store_regs_user_thread): Likewise.
7865         (store_regs_kernel_thread): Likewise.
7866         (fetch_regs_kernel_thread): Remove shadowed variable.
7867
7868 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7869
7870         * features/riscv/32bit-cpu.xml: Add register numbers.
7871         * features/riscv/32bit-fpu.c: Regenerate.
7872         * features/riscv/32bit-fpu.xml: Add register numbers.
7873         * features/riscv/64bit-cpu.xml: Add register numbers.
7874         * features/riscv/64bit-fpu.c: Regenerate.
7875         * features/riscv/64bit-fpu.xml: Add register numbers.
7876
7877 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7878
7879         * NEWS: Mention two argument form of gdb.Value constructor.
7880         * python/py-value.c (convert_buffer_and_type_to_value): New
7881         function.
7882         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7883         Add support for handling an optional second argument.  Call
7884         convert_buffer_and_type_to_value as appropriate.
7885         * python/python-internal.h (Py_buffer_deleter): New struct.
7886         (Py_buffer_up): New typedef.
7887
7888 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7889
7890         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7891         instead of releasing ownership.
7892
7893 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7894
7895         * dwarf2read.c (open_and_init_dwp_file): Call
7896         elf_numsections instead of bfd_count_sections to initialize
7897         dwp_file->num_sections.
7898
7899 2019-02-25  Tom Tromey  <tromey@adacore.com>
7900
7901         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7902
7903 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7904
7905         * gcore.in: Add '--readnever' option when invoking GDB.
7906
7907 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7908
7909         * MAINTAINERS: Update my email address.
7910
7911 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7912
7913         * build-id.c (build_id_to_debug_bfd_1): New function.
7914         (build_id_to_debug_bfd): Look for separate debug file in
7915         sysroot.
7916
7917 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7918
7919         * gdbarch.sh: Update the copyright year range that is placed into
7920         generated files.
7921
7922 2019-02-22  Keith Seitz  <keiths@redhat.com>
7923
7924         PR symtab/23853
7925         * linespec.c (create_sals_line_offset): Search for the default
7926         symtab's filename instead of its fullname.
7927
7928 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7929
7930         * NEWS: Update style defaults.
7931
7932 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7933
7934         * main.c (captured_main_1): Disable styling in batch mode.
7935
7936 2019-02-20  Tom Tromey  <tom@tromey.com>
7937
7938         * symtab.c (symtab_symbol_info): Fix typos.
7939
7940 2019-02-20  Tom Tromey  <tromey@adacore.com>
7941
7942         * findcmd.c (_initialize_mem_search): Use upper case for
7943         metasyntactic variables.
7944
7945 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7946
7947         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7948         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7949
7950 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7951
7952         * top.h (source_file_name): Change to std::string.
7953         * top.c (source_file_name): Likewise.
7954         (command_line_input): Adjust.
7955         * cli/cli-script.c (script_from_file): Adjust.
7956
7957 2019-02-19  Tom Tromey  <tromey@adacore.com>
7958
7959         * ravenscar-thread.c
7960         (ravenscar_thread_target::update_thread_list): Don't call
7961         ada_build_task_list.
7962         * ada-lang.h (ada_build_task_list): Don't declare.
7963         * ada-tasks.c (struct ada_tasks_inferior_data)
7964         <task_list_valid_p>: Now bool.
7965         (read_known_tasks, ada_task_list_changed)
7966         (ada_tasks_invalidate_inferior_data): Update.
7967         (read_known_tasks_array): Return bool.
7968         (read_known_tasks_list): Likewise.
7969         (read_known_tasks): Return void.
7970         (ada_build_task_list): Now static.
7971
7972 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7973
7974         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7975         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7976
7977 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7978
7979         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7980         variant for ada_tasks_pspace_data_handle and
7981         ada_tasks_inferior_data_handle.
7982         (ada_tasks_pspace_data_cleanup): New function.
7983         (ada_tasks_inferior_data_cleanup): New function.
7984
7985 2019-02-17  Tom Tromey  <tom@tromey.com>
7986
7987         * macrotab.h (macro_source_fullname): Return a std::string.
7988         * macrotab.c (macro_include, check_for_redefinition)
7989         (macro_undef, macro_lookup_definition, foreach_macro)
7990         (foreach_macro_in_scope): Update.
7991         (macro_source_fullname): Return a std::string.
7992         * macrocmd.c (show_pp_source_pos): Update.
7993
7994 2019-02-17  Tom Tromey  <tom@tromey.com>
7995
7996         * macrocmd.c (show_pp_source_pos): Style the file names.
7997
7998 2019-02-17  Tom Tromey  <tom@tromey.com>
7999
8000         PR tui/24197:
8001         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8002
8003 2019-02-17  Tom Tromey  <tom@tromey.com>
8004
8005         * ada-lang.c (user_select_syms): Use filtered printing.
8006         * utils.c (wrap_style): New global.
8007         (desired_style): Remove.
8008         (emit_style_escape): Add stream parameter.
8009         (set_output_style, reset_terminal_style, prompt_for_continue):
8010         Update.
8011         (flush_wrap_buffer): Only flush gdb_stdout.
8012         (wrap_here): Set wrap_style.
8013         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8014         treat escape sequences as a character.  Change when wrap buffer is
8015         flushed.
8016         (fputs_styled): Do not set the output style when the default is
8017         requested.
8018         * ui-style.h (struct ui_file_style) <is_default>: New method.
8019         * source.c (print_source_lines_base): Emit escape sequences in one
8020         piece.
8021
8022 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8023
8024         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8025         integers and enumeration types.
8026
8027 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8028
8029         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8030         instead of lookup_symbol_in_language
8031         (do_exact_match): New function.
8032         (ada_get_symbol_name_matcher): Return do_exact_match when
8033         doing a verbatim match.
8034
8035 2019-02-15  Tom Tromey  <tromey@adacore.com>
8036
8037         * ravenscar-thread.c (ravenscar_thread_target::resume)
8038         (ravenscar_thread_target::wait): Special case wildcard requests.
8039
8040 2019-02-15  Tom Tromey  <tromey@adacore.com>
8041
8042         * ravenscar-thread.c (base_ptid): Remove.
8043         (struct ravenscar_thread_target) <close>: New method.
8044         <m_base_ptid>: New member.
8045         <update_inferior_ptid, active_task, task_is_currently_active,
8046         runtime_initialized>: Declare methods.
8047         <ravenscar_thread_target>: Add constructor.
8048         (ravenscar_thread_target::task_is_currently_active)
8049         (ravenscar_thread_target::update_inferior_ptid)
8050         (ravenscar_runtime_initialized): Rename.  Now methods.
8051         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8052         (ravenscar_thread_target::update_thread_list): Update.
8053         (ravenscar_thread_target::active_task): Now method.
8054         (ravenscar_thread_target::store_registers)
8055         (ravenscar_thread_target::prepare_to_store)
8056         (ravenscar_thread_target::prepare_to_store)
8057         (ravenscar_thread_target::mourn_inferior): Update.
8058         (ravenscar_inferior_created): Use "new" to create target.
8059         (ravenscar_thread_target::get_ada_task_ptid): Update.
8060         (_initialize_ravenscar): Don't initialize base_ptid.
8061         (ravenscar_ops): Remove global.
8062
8063 2019-02-15  Tom Tromey  <tromey@adacore.com>
8064
8065         * target.h (push_target): Declare new overload.
8066         * target.c (push_target): New overload, taking an rvalue reference.
8067         * remote.c (remote_target::open_1): Use push_target overload.
8068         * corelow.c (core_target_open): Use push_target overload.
8069
8070 2019-02-15  Tom Tromey  <tromey@adacore.com>
8071
8072         * ravenscar-thread.c (is_ravenscar_task)
8073         (ravenscar_task_is_currently_active): Return bool.
8074         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8075         (_initialize_ravenscar): Remove "(void)".
8076         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8077         Return bool.
8078
8079 2019-02-15  Tom Tromey  <tromey@adacore.com>
8080
8081         * ravenscar-thread.c (ravenscar_runtime_initializer)
8082         (has_ravenscar_runtime, get_running_thread_id)
8083         (ravenscar_thread_target::resume): Fix indentation.
8084
8085 2019-02-15  Tom Tromey  <tromey@adacore.com>
8086
8087         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8088         from ravenscar_arch_ops.
8089         (sparc_ravenscar_ops::fetch_registers)
8090         (sparc_ravenscar_ops::store_registers): Now methods.
8091         (sparc_ravenscar_prepare_to_store): Remove.
8092         (sparc_ravenscar_ops): Redefine.
8093         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8094         methods and destructor.  Remove members.
8095         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8096         (ravenscar_thread_target::store_registers)
8097         (ravenscar_thread_target::prepare_to_store): Update.
8098         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8099         Remove.
8100         (struct ppc_ravenscar_powerpc_ops): Derive from
8101         ravenscar_arch_ops.
8102         (ppc_ravenscar_powerpc_ops::fetch_registers)
8103         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8104         (ppc_ravenscar_powerpc_ops): Redefine.
8105         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8106         (ppc_ravenscar_e500_ops::fetch_registers)
8107         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8108         (ppc_ravenscar_e500_ops): Redefine.
8109         * aarch64-ravenscar-thread.c
8110         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8111         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8112         (aarch64_ravenscar_fetch_registers)
8113         (aarch64_ravenscar_store_registers): Now methods.
8114         (aarch64_ravenscar_ops): Redefine.
8115
8116 2019-02-15  Tom Tromey  <tromey@adacore.com>
8117
8118         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8119         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8120         (ravenscar_thread_target::stopped_by_watchpoint)
8121         (ravenscar_thread_target::stopped_data_address)
8122         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8123
8124 2019-02-15  Tom Tromey  <tromey@adacore.com>
8125
8126         * ravenscar-thread.c: Fix some typos.
8127
8128 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8129             Tom Tromey  <tromey@adacore.com>
8130
8131         * ada-lang.c (ada_exception_sal): Change addr_string to a
8132         std::string.
8133         (create_ada_exception_catchpoint): Update.
8134
8135 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8136             Tom Tromey  <tromey@adacore.com>
8137
8138         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8139         (bp_location_ops): Remove.
8140         (base_breakpoint_allocate_location): Update.
8141         (free_bp_location): Update.
8142         * ada-lang.c (class ada_catchpoint_location)
8143         <ada_catchpoint_location>: Remove ops parameter.
8144         (ada_catchpoint_location_dtor): Remove.
8145         (ada_catchpoint_location_ops): Remove.
8146         (allocate_location_exception): Update.
8147         * breakpoint.h (struct bp_location_ops): Remove.
8148         (class bp_location) <bp_location>: Remove bp_location_ops
8149         parameter.
8150         <~bp_location>: Add destructor.
8151         <ops>: Remove.
8152
8153 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8154             Pedro Alves  <palves@redhat.com>
8155
8156         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8157         'PATH_MAX'.
8158
8159 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8160             Samuel Thibault  <samuel.thibault@gnu.org>
8161             Thomas Schwinge  <thomas@codesourcery.com>
8162
8163         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8164         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8165
8166 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8167
8168         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8169         (check_empty): Use "const char *".
8170
8171         * gnu-nat.c (gnu_nat_target::detach): Instead of
8172         'detach_inferior (pid)' call
8173         'detach_inferior (find_inferior_pid (pid))'.
8174
8175         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8176         'nat/fork-inferior.o'.
8177         * gnu-nat.c: #include "nat/fork-inferior.h".
8178
8179         * gnu-nat.c (gnu_nat_target::detach): Instead of
8180         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8181         * gnu-nat.h: #include "inf-child.h".
8182         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8183         'i386_gnu_nat_target::fetch_registers'.
8184         (gnu_store_registers): Rename/move to
8185         'i386_gnu_nat_target::store_registers'.
8186
8187         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8188         * gnu-nat.h (mach_thread_info): New function.
8189         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8190
8191         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8192
8193 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8194
8195         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8196
8197 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8198
8199         * windows-nat.c (windows_add_thread): Add new parameter
8200         "main_thread_p" with default value set to false.  Update
8201         function documentation as well as all callers.
8202         (windows_delete_thread): Likewise.
8203         (fake_create_process): Update call to windows_add_thread.
8204         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8205         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8206         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8207         call to windows_delete_thread.
8208
8209 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8210
8211         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8212
8213 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8214
8215         * symfile.c (find_separate_debug_file): Use canonical path of
8216         sysroot with child_path instead of gdb_sysroot if it is valid.
8217
8218 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8219
8220         * symfile.c (find_separate_debug_file): Use child_path to
8221         determine if an object file is under a sysroot.
8222
8223 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8224
8225         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8226         unittests/child-path-selftests.c.
8227         * common/pathstuff.c (child_path): New function.
8228         * common/pathstuff.h (child_path): New prototype.
8229         * unittests/child-path-selftests.c: New file.
8230
8231 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8232
8233         * symfile.c (find_separate_debug_file): Look for separate debug
8234         files in debug directories under the sysroot.
8235
8236 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8237
8238         * symtab.h (struct minimal_symbol data_p): New const method.
8239         (struct minimal_symbol text_p): Likewise.
8240         * symtab.c (output_source_filename): Use file name style
8241         to print file name.
8242         (print_symbol_info): Likewise.
8243         (print_msymbol_info): Use address style to print addresses.
8244         Use function name style to print executable text symbols.
8245         (expand_symtab_containing_pc): Use data_p.
8246         (find_pc_sect_compunit_symtab): Likewise.
8247
8248 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8249
8250         * breakpoint.c (describe_other_breakpoints): Use address style
8251         to print addresses.
8252         (say_where): Likewise.
8253
8254 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8255
8256         * ada-typeprint.c (print_func_type): Print function name
8257         style to print function name.
8258         * c-typeprint.c (c_print_type_1): Likewise.
8259
8260 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8261
8262         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8263         for execve.
8264
8265 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8266
8267         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8268         type_stack.
8269
8270 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8271
8272         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8273         TYPE_CODE_REF types.
8274
8275 2019-02-08  Jim Wilson  <jimw@sifive.com>
8276
8277         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8278         (riscv_linux_fregset): New.
8279         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8280
8281 2019-02-07  Tom Tromey  <tom@tromey.com>
8282
8283         * thread.c (thread_cancel_execution_command): Update.
8284         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8285         methods.
8286         (struct thread_fsm_ops): Remove.
8287         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8288         (thread_fsm_should_stop, thread_fsm_return_value)
8289         (thread_fsm_set_finished, thread_fsm_finished_p)
8290         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8291         Don't declare.
8292         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8293         * infrun.c (clear_proceed_status_thread)
8294         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8295         (print_stop_event): Update.
8296         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8297         Add constructor.
8298         (step_command_fsm_ops): Remove.
8299         (new_step_command_fsm): Remove.
8300         (step_1): Update.
8301         (step_command_fsm::should_stop): Rename from
8302         step_command_fsm_should_stop.
8303         (step_command_fsm::clean_up): Rename from
8304         step_command_fsm_clean_up.
8305         (step_command_fsm::do_async_reply_reason): Rename from
8306         step_command_fsm_async_reply_reason.
8307         (struct until_next_fsm): Inherit from thread_fsm.  Add
8308         constructor.
8309         (until_next_fsm_ops): Remove.
8310         (new_until_next_fsm): Remove.
8311         (until_next_fsm::should_stop): Rename from
8312         until_next_fsm_should_stop.
8313         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8314         (until_next_fsm::do_async_reply_reason): Rename from
8315         until_next_fsm_async_reply_reason.
8316         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8317         constructor.  Change type of breakpoint.
8318         (finish_command_fsm_ops): Remove.
8319         (new_finish_command_fsm): Remove.
8320         (finish_command_fsm::should_stop): Rename from
8321         finish_command_fsm_should_stop.
8322         (finish_command_fsm::clean_up): Rename from
8323         finish_command_fsm_clean_up.
8324         (finish_command_fsm::return_value): Rename from
8325         finish_command_fsm_return_value.
8326         (finish_command_fsm::do_async_reply_reason): Rename from
8327         finish_command_fsm_async_reply_reason.
8328         (finish_command): Update.
8329         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8330         Add constructor.
8331         (call_thread_fsm_ops): Remove.
8332         (call_thread_fsm::call_thread_fsm): Rename from
8333         new_call_thread_fsm.
8334         (call_thread_fsm::should_stop): Rename from
8335         call_thread_fsm_should_stop.
8336         (call_thread_fsm::should_notify_stop): Rename from
8337         call_thread_fsm_should_notify_stop.
8338         (run_inferior_call, call_function_by_hand_dummy): Update.
8339         * cli/cli-interp.c (should_print_stop_to_console): Update.
8340         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8341         Add constructor.  Change type of location_breakpoint,
8342         caller_breakpoint.
8343         (until_break_fsm_ops): Remove.
8344         (new_until_break_fsm): Remove.
8345         (until_break_fsm::should_stop): Rename from
8346         until_break_fsm_should_stop.
8347         (until_break_fsm::clean_up): Rename from
8348         until_break_fsm_clean_up.
8349         (until_break_fsm::do_async_reply_reason): Rename from
8350         until_break_fsm_async_reply_reason.
8351         (until_break_command): Update.
8352         * thread-fsm.c: Remove.
8353         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8354
8355 2019-02-07  Tom Tromey  <tom@tromey.com>
8356
8357         * yy-remap.h: Add include guard.
8358         * xtensa-tdep.h: Add include guard.
8359         * xcoffread.h: Rename include guard.
8360         * varobj-iter.h: Add include guard.
8361         * tui/tui.h: Rename include guard.
8362         * tui/tui-winsource.h: Rename include guard.
8363         * tui/tui-wingeneral.h: Rename include guard.
8364         * tui/tui-windata.h: Rename include guard.
8365         * tui/tui-win.h: Rename include guard.
8366         * tui/tui-stack.h: Rename include guard.
8367         * tui/tui-source.h: Rename include guard.
8368         * tui/tui-regs.h: Rename include guard.
8369         * tui/tui-out.h: Rename include guard.
8370         * tui/tui-layout.h: Rename include guard.
8371         * tui/tui-io.h: Rename include guard.
8372         * tui/tui-hooks.h: Rename include guard.
8373         * tui/tui-file.h: Rename include guard.
8374         * tui/tui-disasm.h: Rename include guard.
8375         * tui/tui-data.h: Rename include guard.
8376         * tui/tui-command.h: Rename include guard.
8377         * tic6x-tdep.h: Add include guard.
8378         * target/waitstatus.h: Rename include guard.
8379         * target/wait.h: Rename include guard.
8380         * target/target.h: Rename include guard.
8381         * target/resume.h: Rename include guard.
8382         * target-float.h: Rename include guard.
8383         * stabsread.h: Add include guard.
8384         * rs6000-tdep.h: Add include guard.
8385         * riscv-fbsd-tdep.h: Add include guard.
8386         * regformats/regdef.h: Rename include guard.
8387         * record.h: Rename include guard.
8388         * python/python.h: Rename include guard.
8389         * python/python-internal.h: Rename include guard.
8390         * python/py-stopevent.h: Rename include guard.
8391         * python/py-ref.h: Rename include guard.
8392         * python/py-record.h: Rename include guard.
8393         * python/py-record-full.h: Rename include guard.
8394         * python/py-record-btrace.h: Rename include guard.
8395         * python/py-instruction.h: Rename include guard.
8396         * python/py-events.h: Rename include guard.
8397         * python/py-event.h: Rename include guard.
8398         * procfs.h: Add include guard.
8399         * proc-utils.h: Add include guard.
8400         * p-lang.h: Add include guard.
8401         * or1k-tdep.h: Rename include guard.
8402         * observable.h: Rename include guard.
8403         * nto-tdep.h: Rename include guard.
8404         * nat/x86-linux.h: Rename include guard.
8405         * nat/x86-linux-dregs.h: Rename include guard.
8406         * nat/x86-gcc-cpuid.h: Add include guard.
8407         * nat/x86-dregs.h: Rename include guard.
8408         * nat/x86-cpuid.h: Rename include guard.
8409         * nat/ppc-linux.h: Rename include guard.
8410         * nat/mips-linux-watch.h: Rename include guard.
8411         * nat/linux-waitpid.h: Rename include guard.
8412         * nat/linux-ptrace.h: Rename include guard.
8413         * nat/linux-procfs.h: Rename include guard.
8414         * nat/linux-osdata.h: Rename include guard.
8415         * nat/linux-nat.h: Rename include guard.
8416         * nat/linux-namespaces.h: Rename include guard.
8417         * nat/linux-btrace.h: Rename include guard.
8418         * nat/glibc_thread_db.h: Rename include guard.
8419         * nat/gdb_thread_db.h: Rename include guard.
8420         * nat/gdb_ptrace.h: Rename include guard.
8421         * nat/fork-inferior.h: Rename include guard.
8422         * nat/amd64-linux-siginfo.h: Rename include guard.
8423         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8424         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8425         * nat/aarch64-linux.h: Rename include guard.
8426         * nat/aarch64-linux-hw-point.h: Rename include guard.
8427         * mn10300-tdep.h: Add include guard.
8428         * mips-linux-tdep.h: Add include guard.
8429         * mi/mi-parse.h: Rename include guard.
8430         * mi/mi-out.h: Rename include guard.
8431         * mi/mi-main.h: Rename include guard.
8432         * mi/mi-interp.h: Rename include guard.
8433         * mi/mi-getopt.h: Rename include guard.
8434         * mi/mi-console.h: Rename include guard.
8435         * mi/mi-common.h: Rename include guard.
8436         * mi/mi-cmds.h: Rename include guard.
8437         * mi/mi-cmd-break.h: Rename include guard.
8438         * m2-lang.h: Add include guard.
8439         * location.h: Rename include guard.
8440         * linux-record.h: Rename include guard.
8441         * linux-nat.h: Add include guard.
8442         * linux-fork.h: Add include guard.
8443         * i386-darwin-tdep.h: Rename include guard.
8444         * hppa-linux-offsets.h: Add include guard.
8445         * guile/guile.h: Rename include guard.
8446         * guile/guile-internal.h: Rename include guard.
8447         * gnu-nat.h: Rename include guard.
8448         * gdb-stabs.h: Rename include guard.
8449         * frv-tdep.h: Add include guard.
8450         * f-lang.h: Add include guard.
8451         * event-loop.h: Add include guard.
8452         * darwin-nat.h: Rename include guard.
8453         * cp-abi.h: Rename include guard.
8454         * config/sparc/nm-sol2.h: Rename include guard.
8455         * config/nm-nto.h: Rename include guard.
8456         * config/nm-linux.h: Add include guard.
8457         * config/i386/nm-i386gnu.h: Rename include guard.
8458         * config/djgpp/nl_types.h: Rename include guard.
8459         * config/djgpp/langinfo.h: Rename include guard.
8460         * compile/gcc-cp-plugin.h: Add include guard.
8461         * compile/gcc-c-plugin.h: Add include guard.
8462         * compile/compile.h: Rename include guard.
8463         * compile/compile-object-run.h: Rename include guard.
8464         * compile/compile-object-load.h: Rename include guard.
8465         * compile/compile-internal.h: Rename include guard.
8466         * compile/compile-cplus.h: Rename include guard.
8467         * compile/compile-c.h: Rename include guard.
8468         * common/xml-utils.h: Rename include guard.
8469         * common/x86-xstate.h: Rename include guard.
8470         * common/version.h: Rename include guard.
8471         * common/vec.h: Rename include guard.
8472         * common/tdesc.h: Rename include guard.
8473         * common/selftest.h: Rename include guard.
8474         * common/scoped_restore.h: Rename include guard.
8475         * common/scoped_mmap.h: Rename include guard.
8476         * common/scoped_fd.h: Rename include guard.
8477         * common/safe-iterator.h: Rename include guard.
8478         * common/run-time-clock.h: Rename include guard.
8479         * common/refcounted-object.h: Rename include guard.
8480         * common/queue.h: Rename include guard.
8481         * common/ptid.h: Rename include guard.
8482         * common/print-utils.h: Rename include guard.
8483         * common/preprocessor.h: Rename include guard.
8484         * common/pathstuff.h: Rename include guard.
8485         * common/observable.h: Rename include guard.
8486         * common/netstuff.h: Rename include guard.
8487         * common/job-control.h: Rename include guard.
8488         * common/host-defs.h: Rename include guard.
8489         * common/gdb_wait.h: Rename include guard.
8490         * common/gdb_vecs.h: Rename include guard.
8491         * common/gdb_unlinker.h: Rename include guard.
8492         * common/gdb_unique_ptr.h: Rename include guard.
8493         * common/gdb_tilde_expand.h: Rename include guard.
8494         * common/gdb_sys_time.h: Rename include guard.
8495         * common/gdb_string_view.h: Rename include guard.
8496         * common/gdb_splay_tree.h: Rename include guard.
8497         * common/gdb_setjmp.h: Rename include guard.
8498         * common/gdb_ref_ptr.h: Rename include guard.
8499         * common/gdb_optional.h: Rename include guard.
8500         * common/gdb_locale.h: Rename include guard.
8501         * common/gdb_assert.h: Rename include guard.
8502         * common/filtered-iterator.h: Rename include guard.
8503         * common/filestuff.h: Rename include guard.
8504         * common/fileio.h: Rename include guard.
8505         * common/environ.h: Rename include guard.
8506         * common/common-utils.h: Rename include guard.
8507         * common/common-types.h: Rename include guard.
8508         * common/common-regcache.h: Rename include guard.
8509         * common/common-inferior.h: Rename include guard.
8510         * common/common-gdbthread.h: Rename include guard.
8511         * common/common-exceptions.h: Rename include guard.
8512         * common/common-defs.h: Rename include guard.
8513         * common/common-debug.h: Rename include guard.
8514         * common/cleanups.h: Rename include guard.
8515         * common/buffer.h: Rename include guard.
8516         * common/btrace-common.h: Rename include guard.
8517         * common/break-common.h: Rename include guard.
8518         * cli/cli-utils.h: Rename include guard.
8519         * cli/cli-style.h: Rename include guard.
8520         * cli/cli-setshow.h: Rename include guard.
8521         * cli/cli-script.h: Rename include guard.
8522         * cli/cli-interp.h: Rename include guard.
8523         * cli/cli-decode.h: Rename include guard.
8524         * cli/cli-cmds.h: Rename include guard.
8525         * charset-list.h: Add include guard.
8526         * buildsym-legacy.h: Rename include guard.
8527         * bfin-tdep.h: Add include guard.
8528         * ax.h: Rename include guard.
8529         * arm-linux-tdep.h: Add include guard.
8530         * arm-fbsd-tdep.h: Add include guard.
8531         * arch/xtensa.h: Rename include guard.
8532         * arch/tic6x.h: Add include guard.
8533         * arch/i386.h: Add include guard.
8534         * arch/arm.h: Rename include guard.
8535         * arch/arm-linux.h: Rename include guard.
8536         * arch/arm-get-next-pcs.h: Rename include guard.
8537         * arch/amd64.h: Add include guard.
8538         * arch/aarch64-insn.h: Rename include guard.
8539         * arch-utils.h: Rename include guard.
8540         * annotate.h: Add include guard.
8541         * amd64-darwin-tdep.h: Rename include guard.
8542         * aarch64-linux-tdep.h: Add include guard.
8543         * aarch64-fbsd-tdep.h: Add include guard.
8544         * aarch32-linux-nat.h: Add include guard.
8545
8546 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8547
8548         * macrotab.c (macro_define_internal): New function that
8549         factorizes macro_define_object_internal and macro_define_function
8550         code.
8551         (macro_define_object_internal): Use macro_define_internal.
8552         (macro_define_function): Likewise.
8553
8554 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8555
8556         * macrocmd.c (extract_identifier): Return
8557         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8558         callers.
8559
8560 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8561
8562         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8563
8564 2019-02-05  Tom Tromey  <tom@tromey.com>
8565
8566         * target.c (target_stack::unpush): Move assertion earlier.
8567
8568 2019-01-30  Tom Tromey  <tom@tromey.com>
8569
8570         PR python/23615:
8571         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8572         (gdbpy_parse_and_eval): Likewise.
8573         * python/python-internal.h (gdbpy_allow_threads): New class.
8574
8575 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8576
8577         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8578         (aarch64_fbsd_fpregmap): Move earlier.
8579         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8580         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8581         instead of individual calls to trad_frame_set_reg_addr.
8582         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8583         earlier.
8584         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8585         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8586         instead of individual calls to trad_frame_set_reg_addr.
8587
8588 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8589
8590         * CONTRIBUTE: Replace contribution list with wiki link.
8591
8592 2019-01-25  Tom Tromey  <tom@tromey.com>
8593
8594         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8595
8596 2019-01-25  Tom Tromey  <tom@tromey.com>
8597
8598         * xtensa-linux-nat.c: Fix common/ includes.
8599         * xml-support.h: Fix common/ includes.
8600         * xml-support.c: Fix common/ includes.
8601         * x86-linux-nat.c: Fix common/ includes.
8602         * windows-nat.c: Fix common/ includes.
8603         * varobj.h: Fix common/ includes.
8604         * varobj.c: Fix common/ includes.
8605         * value.c: Fix common/ includes.
8606         * valops.c: Fix common/ includes.
8607         * utils.c: Fix common/ includes.
8608         * unittests/xml-utils-selftests.c: Fix common/ includes.
8609         * unittests/utils-selftests.c: Fix common/ includes.
8610         * unittests/unpack-selftests.c: Fix common/ includes.
8611         * unittests/tracepoint-selftests.c: Fix common/ includes.
8612         * unittests/style-selftests.c: Fix common/ includes.
8613         * unittests/string_view-selftests.c: Fix common/ includes.
8614         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8615         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8616         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8617         * unittests/rsp-low-selftests.c: Fix common/ includes.
8618         * unittests/parse-connection-spec-selftests.c: Fix common/
8619         includes.
8620         * unittests/optional-selftests.c: Fix common/ includes.
8621         * unittests/offset-type-selftests.c: Fix common/ includes.
8622         * unittests/observable-selftests.c: Fix common/ includes.
8623         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8624         * unittests/memrange-selftests.c: Fix common/ includes.
8625         * unittests/memory-map-selftests.c: Fix common/ includes.
8626         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8627         * unittests/function-view-selftests.c: Fix common/ includes.
8628         * unittests/environ-selftests.c: Fix common/ includes.
8629         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8630         * unittests/common-utils-selftests.c: Fix common/ includes.
8631         * unittests/cli-utils-selftests.c: Fix common/ includes.
8632         * unittests/array-view-selftests.c: Fix common/ includes.
8633         * ui-file.c: Fix common/ includes.
8634         * tui/tui-io.c: Fix common/ includes.
8635         * tracepoint.h: Fix common/ includes.
8636         * tracepoint.c: Fix common/ includes.
8637         * tracefile-tfile.c: Fix common/ includes.
8638         * top.h: Fix common/ includes.
8639         * top.c: Fix common/ includes.
8640         * thread.c: Fix common/ includes.
8641         * target/waitstatus.h: Fix common/ includes.
8642         * target/waitstatus.c: Fix common/ includes.
8643         * target.h: Fix common/ includes.
8644         * target.c: Fix common/ includes.
8645         * target-memory.c: Fix common/ includes.
8646         * target-descriptions.c: Fix common/ includes.
8647         * symtab.h: Fix common/ includes.
8648         * symfile.c: Fix common/ includes.
8649         * stap-probe.c: Fix common/ includes.
8650         * spu-linux-nat.c: Fix common/ includes.
8651         * sparc-nat.c: Fix common/ includes.
8652         * source.c: Fix common/ includes.
8653         * solib.c: Fix common/ includes.
8654         * solib-target.c: Fix common/ includes.
8655         * ser-unix.c: Fix common/ includes.
8656         * ser-tcp.c: Fix common/ includes.
8657         * ser-pipe.c: Fix common/ includes.
8658         * ser-base.c: Fix common/ includes.
8659         * selftest-arch.c: Fix common/ includes.
8660         * s12z-tdep.c: Fix common/ includes.
8661         * rust-exp.y: Fix common/ includes.
8662         * rs6000-aix-tdep.c: Fix common/ includes.
8663         * riscv-tdep.c: Fix common/ includes.
8664         * remote.c: Fix common/ includes.
8665         * remote-notif.h: Fix common/ includes.
8666         * remote-fileio.h: Fix common/ includes.
8667         * remote-fileio.c: Fix common/ includes.
8668         * regcache.h: Fix common/ includes.
8669         * regcache.c: Fix common/ includes.
8670         * record-btrace.c: Fix common/ includes.
8671         * python/python.c: Fix common/ includes.
8672         * python/py-type.c: Fix common/ includes.
8673         * python/py-inferior.c: Fix common/ includes.
8674         * progspace.h: Fix common/ includes.
8675         * producer.c: Fix common/ includes.
8676         * procfs.c: Fix common/ includes.
8677         * proc-api.c: Fix common/ includes.
8678         * printcmd.c: Fix common/ includes.
8679         * ppc-linux-nat.c: Fix common/ includes.
8680         * parser-defs.h: Fix common/ includes.
8681         * osdata.c: Fix common/ includes.
8682         * obsd-nat.c: Fix common/ includes.
8683         * nat/x86-linux.c: Fix common/ includes.
8684         * nat/x86-linux-dregs.c: Fix common/ includes.
8685         * nat/x86-dregs.h: Fix common/ includes.
8686         * nat/x86-dregs.c: Fix common/ includes.
8687         * nat/ppc-linux.c: Fix common/ includes.
8688         * nat/mips-linux-watch.h: Fix common/ includes.
8689         * nat/mips-linux-watch.c: Fix common/ includes.
8690         * nat/linux-waitpid.c: Fix common/ includes.
8691         * nat/linux-ptrace.h: Fix common/ includes.
8692         * nat/linux-ptrace.c: Fix common/ includes.
8693         * nat/linux-procfs.c: Fix common/ includes.
8694         * nat/linux-personality.c: Fix common/ includes.
8695         * nat/linux-osdata.c: Fix common/ includes.
8696         * nat/linux-namespaces.c: Fix common/ includes.
8697         * nat/linux-btrace.h: Fix common/ includes.
8698         * nat/linux-btrace.c: Fix common/ includes.
8699         * nat/fork-inferior.c: Fix common/ includes.
8700         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8701         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8702         * nat/aarch64-linux.c: Fix common/ includes.
8703         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8704         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8705         * namespace.h: Fix common/ includes.
8706         * mips-linux-tdep.c: Fix common/ includes.
8707         * minsyms.c: Fix common/ includes.
8708         * mi/mi-parse.h: Fix common/ includes.
8709         * mi/mi-main.c: Fix common/ includes.
8710         * mi/mi-cmd-env.c: Fix common/ includes.
8711         * memrange.h: Fix common/ includes.
8712         * memattr.c: Fix common/ includes.
8713         * maint.h: Fix common/ includes.
8714         * maint.c: Fix common/ includes.
8715         * main.c: Fix common/ includes.
8716         * machoread.c: Fix common/ includes.
8717         * location.c: Fix common/ includes.
8718         * linux-thread-db.c: Fix common/ includes.
8719         * linux-nat.c: Fix common/ includes.
8720         * linux-fork.c: Fix common/ includes.
8721         * inline-frame.c: Fix common/ includes.
8722         * infrun.c: Fix common/ includes.
8723         * inflow.c: Fix common/ includes.
8724         * inferior.h: Fix common/ includes.
8725         * inferior.c: Fix common/ includes.
8726         * infcmd.c: Fix common/ includes.
8727         * inf-ptrace.c: Fix common/ includes.
8728         * inf-child.c: Fix common/ includes.
8729         * ia64-linux-nat.c: Fix common/ includes.
8730         * i387-tdep.c: Fix common/ includes.
8731         * i386-tdep.c: Fix common/ includes.
8732         * i386-linux-tdep.c: Fix common/ includes.
8733         * i386-linux-nat.c: Fix common/ includes.
8734         * i386-go32-tdep.c: Fix common/ includes.
8735         * i386-fbsd-tdep.c: Fix common/ includes.
8736         * i386-fbsd-nat.c: Fix common/ includes.
8737         * guile/scm-type.c: Fix common/ includes.
8738         * guile/guile.c: Fix common/ includes.
8739         * go32-nat.c: Fix common/ includes.
8740         * gnu-nat.c: Fix common/ includes.
8741         * gdbthread.h: Fix common/ includes.
8742         * gdbarch-selftests.c: Fix common/ includes.
8743         * gdb_usleep.c: Fix common/ includes.
8744         * gdb_select.h: Fix common/ includes.
8745         * gdb_bfd.c: Fix common/ includes.
8746         * gcore.c: Fix common/ includes.
8747         * fork-child.c: Fix common/ includes.
8748         * findvar.c: Fix common/ includes.
8749         * fbsd-nat.c: Fix common/ includes.
8750         * event-top.c: Fix common/ includes.
8751         * event-loop.c: Fix common/ includes.
8752         * dwarf2read.c: Fix common/ includes.
8753         * dwarf2loc.c: Fix common/ includes.
8754         * dwarf2-frame.c: Fix common/ includes.
8755         * dwarf-index-cache.c: Fix common/ includes.
8756         * dtrace-probe.c: Fix common/ includes.
8757         * disasm-selftests.c: Fix common/ includes.
8758         * defs.h: Fix common/ includes.
8759         * csky-tdep.c: Fix common/ includes.
8760         * cp-valprint.c: Fix common/ includes.
8761         * cp-support.h: Fix common/ includes.
8762         * cp-support.c: Fix common/ includes.
8763         * corelow.c: Fix common/ includes.
8764         * completer.h: Fix common/ includes.
8765         * completer.c: Fix common/ includes.
8766         * compile/compile.c: Fix common/ includes.
8767         * compile/compile-loc2c.c: Fix common/ includes.
8768         * compile/compile-cplus-types.c: Fix common/ includes.
8769         * compile/compile-cplus-symbols.c: Fix common/ includes.
8770         * command.h: Fix common/ includes.
8771         * cli/cli-dump.c: Fix common/ includes.
8772         * cli/cli-cmds.c: Fix common/ includes.
8773         * charset.c: Fix common/ includes.
8774         * build-id.c: Fix common/ includes.
8775         * btrace.h: Fix common/ includes.
8776         * btrace.c: Fix common/ includes.
8777         * breakpoint.h: Fix common/ includes.
8778         * breakpoint.c: Fix common/ includes.
8779         * ax.h:
8780         (enum agent_op): Fix common/ includes.
8781         * ax-general.c (struct aop_map): Fix common/ includes.
8782         * ax-gdb.c: Fix common/ includes.
8783         * auxv.c: Fix common/ includes.
8784         * auto-load.c: Fix common/ includes.
8785         * arm-tdep.c: Fix common/ includes.
8786         * arch/riscv.c: Fix common/ includes.
8787         * arch/ppc-linux-common.c: Fix common/ includes.
8788         * arch/i386.c: Fix common/ includes.
8789         * arch/arm.c: Fix common/ includes.
8790         * arch/arm-linux.c: Fix common/ includes.
8791         * arch/arm-get-next-pcs.c: Fix common/ includes.
8792         * arch/amd64.c: Fix common/ includes.
8793         * arch/aarch64.c: Fix common/ includes.
8794         * arch/aarch64-insn.c: Fix common/ includes.
8795         * arch-utils.c: Fix common/ includes.
8796         * amd64-windows-tdep.c: Fix common/ includes.
8797         * amd64-tdep.c: Fix common/ includes.
8798         * amd64-sol2-tdep.c: Fix common/ includes.
8799         * amd64-obsd-tdep.c: Fix common/ includes.
8800         * amd64-nbsd-tdep.c: Fix common/ includes.
8801         * amd64-linux-tdep.c: Fix common/ includes.
8802         * amd64-linux-nat.c: Fix common/ includes.
8803         * amd64-fbsd-tdep.c: Fix common/ includes.
8804         * amd64-fbsd-nat.c: Fix common/ includes.
8805         * amd64-dicos-tdep.c: Fix common/ includes.
8806         * amd64-darwin-tdep.c: Fix common/ includes.
8807         * agent.c: Fix common/ includes.
8808         * ada-lang.h: Fix common/ includes.
8809         * ada-lang.c: Fix common/ includes.
8810         * aarch64-tdep.c: Fix common/ includes.
8811
8812 2019-01-25  Tom Tromey  <tom@tromey.com>
8813
8814         * common/create-version.sh: Use common/version.h.
8815
8816 2019-01-24  Pedro Alves  <palves@redhat.com>
8817
8818         * infrun.c (signal_stop, signal_print, signal_program)
8819         (signal_catch, signal_pass): Now arrays instead of pointers.
8820         (update_signals_program_target, do_target_resume)
8821         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8822         * linux-nat.c (linux_nat_target::pass_signals)
8823         (linux_nat_target::create_inferior, linux_nat_target::attach):
8824         Adjust.
8825         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8826         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8827         * procfs.c (procfs_target::pass_signals): Adjust.
8828         * record-full.c (record_full_target::resume): Adjust.
8829         * remote.c (remote_target::pass_signals)
8830         (remote_target::program_signals): Adjust.
8831         * target-debug.h (target_debug_print_signals): Now takes a
8832         gdb::array_view as parameter.  Adjust.
8833         * target.h (target_ops) <pass_signals, program_signals>: Replace
8834         pointer and length parameters with gdb::array_view.
8835         (target_pass_signals, target_program_signals): Likewise.
8836         * target-delegates.c: Regenerate.
8837
8838 2019-01-24  Pedro Alves  <palves@redhat.com>
8839
8840         * common/forward-scope-exit.h
8841         (forward_scope_exit::forward_scope_exit): Pass arguments to
8842         m_bind_function directly, instead of creating a std::bind and
8843         copying that.
8844
8845 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8846
8847         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8848         for static members.
8849         (pass_in_v_vfp_candidate): Likewise.
8850
8851 2019-01-23  Tom Tromey  <tom@tromey.com>
8852             Pedro Alves  <palves@redhat.com>
8853
8854         * regcache.c (class regcache_invalidator): Remove.
8855         (regcache::raw_write): Use make_scope_exit.
8856
8857 2019-01-23  Tom Tromey  <tom@tromey.com>
8858
8859         * ui-out.h (class ui_out_emit_type): Update comment.
8860
8861 2019-01-23  Tom Tromey  <tom@tromey.com>
8862
8863         * infrun.c (fetch_inferior_event): Update comment.
8864
8865 2019-01-23  Tom Tromey  <tom@tromey.com>
8866             Pedro Alves  <palves@redhat.com>
8867
8868         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8869         parameter.
8870         (fetch_inferior_event): Use SCOPE_EXIT.
8871
8872
8873 2019-01-23  Tom Tromey  <tom@tromey.com>
8874             Pedro Alves  <palves@redhat.com>
8875
8876         * infrun.c (disable_thread_events): Delete.
8877         (stop_all_threads): Use SCOPE_EXIT.
8878
8879 2019-01-23  Tom Tromey  <tom@tromey.com>
8880             Pedro Alves  <palves@redhat.com>
8881
8882         * symfile.c: Include forward-scope-exit.h.
8883         (clear_symtab_users_cleanup): Replace forward declaration with
8884         a FORWARD_SCOPE_EXIT.
8885         (syms_from_objfile_1): Use the forward_scope_exit and
8886         gdb::optional instead of cleanup_function.
8887         (reread_symbols): Use the forward_scope_exit instead of
8888         cleanup_function.
8889         (clear_symtab_users_cleanup): Remove function.
8890
8891 2019-01-23  Tom Tromey  <tom@tromey.com>
8892             Pedro Alves  <palves@redhat.com>
8893
8894         * linux-nat.c: Include scope-exit.h.
8895         (cleanup_target_stop): Remove.
8896         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8897         SCOPE_EXIT.
8898
8899 2019-01-23  Tom Tromey  <tom@tromey.com>
8900             Pedro Alves  <palves@redhat.com>
8901
8902         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8903         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8904
8905 2019-01-23  Tom Tromey  <tom@tromey.com>
8906             Andrew Burgess  <andrew.burgess@embecosm.com>
8907             Pedro Alves  <palves@redhat.com>
8908
8909         * infrun.c (fetch_inferior_event): Use scope_exit.
8910         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8911         * top.c (execute_command): Use scope_exit.
8912         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8913         * utils.c (do_bpstat_clear_actions_cleanup)
8914         (make_bpstat_clear_actions_cleanup): Remove.
8915
8916 2019-01-23  Tom Tromey  <tom@tromey.com>
8917             Pedro Alves  <palves@redhat.com>
8918
8919         * infrun.c: Include "common/scope-exit.h"
8920         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8921         (wait_for_inferior): Use SCOPE_EXIT.
8922         (fetch_inferior_event): Use scope_exit.
8923
8924 2019-01-23  Tom Tromey  <tom@tromey.com>
8925             Pedro Alves  <palves@redhat.com>
8926
8927         * breakpoint.c (create_breakpoint): Remove cleanup.
8928
8929 2019-01-23  Tom Tromey  <tom@tromey.com>
8930             Andrew Burgess  <andrew.burgess@embecosm.com>
8931             Pedro Alves  <palves@redhat.com>
8932
8933 2019-01-23  Pedro Alves  <palves@redhat.com>
8934
8935         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8936
8937 2019-01-23  Pedro Alves  <palves@redhat.com>
8938             Andrew Burgess  <andrew.burgess@embecosm.com>
8939
8940         * gdbthread.h: Include "common/forward-scope-exit.h".
8941         (scoped_finish_thread_state): Redefine custom class in terms of
8942         forward_scope_exit.
8943
8944 2019-01-23  Pedro Alves  <palves@redhat.com>
8945             Andrew Burgess  <andrew.burgess@embecosm.com>
8946
8947         * common/forward-scope-exit.h: New file.
8948
8949 2019-01-23  Pedro Alves  <palves@redhat.com>
8950             Andrew Burgess  <andrew.burgess@embecosm.com>
8951             Tom Tromey  <tom@tromey.com>
8952
8953         * common/scope-exit.h: New file.
8954
8955 2019-01-23  Pedro Alves  <palves@redhat.com>
8956
8957         * common/preprocessor.h (ESC): Rename to ...
8958         (ESC_PARENS): ... this.
8959         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8960         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8961
8962 2019-01-23  Tom Tromey  <tom@tromey.com>
8963
8964         * language.h (class scoped_switch_to_sym_language_if_auto):
8965         Initialize m_lang in both cases.
8966
8967 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8968
8969         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8970         with XCNEW.
8971
8972 2019-01-22  Tom Tromey  <tom@tromey.com>
8973
8974         * corelow.c: Do not include sys/file.h.
8975
8976 2019-01-22  Tom Tromey  <tom@tromey.com>
8977
8978         * tui/tui-wingeneral.h: Include gdb_curses.h.
8979
8980 2019-01-22  Tom Tromey  <tom@tromey.com>
8981
8982         * source-cache.h (class source_cache) <get_source_lines,
8983         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8984
8985 2019-01-22  Tom Tromey  <tom@tromey.com>
8986
8987         * remote-fileio.h (struct remote_target): Declare.
8988
8989 2019-01-22  Tom Tromey  <tom@tromey.com>
8990
8991         * python/py-arch.c: Do not include py-ref.h.
8992         * python/py-bpevent.c: Do not include py-ref.h.
8993         * python/py-cmd.c: Do not include py-ref.h.
8994         * python/py-continueevent.c: Do not include py-ref.h.
8995         * python/py-event.h: Do not include py-ref.h.
8996         * python/py-evtregistry.c: Do not include py-ref.h.
8997         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8998         * python/py-frame.c: Do not include py-ref.h.
8999         * python/py-framefilter.c: Do not include py-ref.h.
9000         * python/py-function.c: Do not include py-ref.h.
9001         * python/py-infevents.c: Do not include py-ref.h.
9002         * python/py-linetable.c: Do not include py-ref.h.
9003         * python/py-objfile.c: Do not include py-ref.h.
9004         * python/py-param.c: Do not include py-ref.h.
9005         * python/py-prettyprint.c: Do not include py-ref.h.
9006         * python/py-progspace.c: Do not include py-ref.h.
9007         * python/py-symbol.c: Do not include py-ref.h.
9008         * python/py-symtab.c: Do not include py-ref.h.
9009         * python/py-type.c: Do not include py-ref.h.
9010         * python/py-unwind.c: Do not include py-ref.h.
9011         * python/py-utils.c: Do not include py-ref.h.
9012         * python/py-value.c: Do not include py-ref.h.
9013         * python/py-varobj.c: Do not include py-ref.h.
9014         * python/py-xmethods.c: Do not include py-ref.h.
9015         * python/python.c: Do not include py-ref.h.
9016         * varobj.c: Do not include py-ref.h.
9017
9018 2019-01-22  Tom Tromey  <tom@tromey.com>
9019
9020         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9021         keyword for bcache.
9022
9023 2019-01-22  Tom Tromey  <tom@tromey.com>
9024
9025         * compile/compile-cplus-types.c: Remove a comment by #include.
9026
9027 2019-01-22  Tom Tromey  <tom@tromey.com>
9028
9029         * compile/gcc-c-plugin.h: Include compile-internal.h.
9030
9031 2019-01-22  Tom Tromey  <tom@tromey.com>
9032
9033         * stabsread.c (EXTERN): Do not define.
9034         (symnum, next_symbol_text_func, processing_gcc_compilation)
9035         (within_function, global_sym_chain, global_stabs)
9036         (previous_stab_code, this_object_header_files)
9037         (n_this_object_header_files)
9038         (n_allocated_this_object_header_files): Define.
9039         * stabsread.h (EXTERN): Never define.  Use "extern".
9040
9041 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9042
9043         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9044         history_value.
9045
9046 2019-01-21  Tom Tromey  <tom@tromey.com>
9047
9048         * ui-out.c: Fix includes.
9049         * tui/tui-source.c: Fix includes.
9050         * target.c: Fix includes.
9051         * remote.c: Fix includes.
9052         * regcache.c: Fix includes.
9053         * python/py-block.c: Fix includes.
9054         * printcmd.c: Fix includes.
9055         * or1k-tdep.c: Fix includes.
9056         * mi/mi-main.c: Fix includes.
9057         * m32r-tdep.c: Fix includes.
9058         * csky-tdep.c: Fix includes.
9059         * compile/compile-cplus-types.c: Fix includes.
9060         * cli/cli-interp.c: Fix includes.
9061
9062 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9063
9064         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9065         for padding.
9066
9067 2019-01-16  Tom Tromey  <tom@tromey.com>
9068
9069         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9070         earlier.
9071         (struct objfile) <msymbols_range>: Move from top level.
9072         <msymbols>: New method.
9073         (class objfile_msymbols): Remove.
9074         * symtab.c (default_collect_symbol_completion_matches_break_on):
9075         Update.
9076         * symmisc.c (dump_msymbols): Update.
9077         * stabsread.c (scan_file_globals): Update.
9078         * objc-lang.c (info_selectors_command, info_classes_command)
9079         (find_methods): Update.
9080         * minsyms.c (find_solib_trampoline_target): Update.
9081         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9082         * coffread.c (coff_symfile_read): Update.
9083         * ada-lang.c (ada_lookup_simple_minsym)
9084         (ada_collect_symbol_completion_matches): Update.
9085
9086 2019-01-16  Tom Tromey  <tom@tromey.com>
9087
9088         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9089         type.  Remove no-argument constructor.
9090         <iterator::operator++>: Simplify.
9091         <begin>: Update.
9092         <end>: Use minimal_symbol_count.
9093
9094 2019-01-16  Tom Tromey  <tom@tromey.com>
9095
9096         * objfiles.h (struct objfile) <psymtabs>: New method.
9097         (class objfile_psymtabs): Remove.
9098         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9099         typedef.
9100         <range>: New method.
9101         (require_partial_symbols): Change return type.
9102         * psymtab.c (require_partial_symbols)
9103         (psym_expand_symtabs_matching): Update.
9104         * mdebugread.c (parse_partial_symbols): Update.
9105         * dbxread.c (dbx_end_psymtab): Update.
9106
9107 2019-01-15  Tom Tromey  <tom@tromey.com>
9108
9109         * symtab.c (lookup_objfile_from_block)
9110         (lookup_symbol_in_objfile_symtabs)
9111         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9112         (find_line_symtab, info_sources_command)
9113         (default_collect_symbol_completion_matches_break_on)
9114         (make_source_files_completion_list): Update.
9115         * symmisc.c (print_objfile_statistics, dump_objfile)
9116         (maintenance_print_symbols, maintenance_info_symtabs)
9117         (maintenance_check_symtabs, maintenance_info_line_tables):
9118         Update.
9119         * source.c (select_source_symtab)
9120         (forget_cached_source_info_for_objfile): Update.
9121         * objfiles.h (class objfile_compunits): Remove.
9122         (struct objfile) <compunits_range>: New typedef.
9123         (compunits): New method.
9124         * objfiles.c (objfile_relocate1): Update.
9125         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9126         * maint.c (count_symtabs_and_blocks): Update.
9127         * linespec.c (iterate_over_all_matching_symtabs): Update.
9128         * cp-support.c (add_symbol_overload_list_qualified): Update.
9129         * coffread.c (coff_symtab_read): Update.
9130         * ada-lang.c (add_nonlocal_symbols)
9131         (ada_collect_symbol_completion_matches)
9132         (ada_add_global_exceptions): Update.
9133
9134 2019-01-15  Tom Tromey  <tom@tromey.com>
9135
9136         * progspace.h (program_space) <objfiles_safe_range>: New
9137         typedef.
9138         <objfiles_safe>: New method.
9139         * objfiles.h (class all_objfiles_safe): Remove.
9140         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9141         * jit.c (jit_inferior_exit_hook): Update.
9142
9143 2019-01-17  Tom Tromey  <tom@tromey.com>
9144
9145         * progspace.h (program_space) <objfiles_range>: New typedef.
9146         <objfiles>: New method.
9147         <objfiles_head>: Rename from objfiles.
9148         (object_files): Update.
9149         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9150         * guile/scm-pretty-print.c
9151         (ppscm_find_pretty_printer_from_objfiles): Update.
9152         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9153         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9154         Update.
9155         * python/py-progspace.c (pspy_get_objfiles): Update.
9156         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9157         Update.
9158         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9159         (objfpy_lookup_objfile_by_build_id): Update.
9160         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9161         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9162         Update.
9163         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9164         (expand_symtab_containing_pc, lookup_objfile_from_block)
9165         (lookup_static_symbol, basic_lookup_transparent_type)
9166         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9167         (find_line_symtab, info_sources_command)
9168         (default_collect_symbol_completion_matches_break_on)
9169         (make_source_files_completion_list, find_main_name): Update.
9170         * symmisc.c (print_symbol_bcache_statistics)
9171         (print_objfile_statistics, maintenance_print_symbols)
9172         (maintenance_print_msymbols, maintenance_print_objfiles)
9173         (maintenance_info_symtabs, maintenance_check_symtabs)
9174         (maintenance_expand_symtabs, maintenance_info_line_tables):
9175         Update.
9176         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9177         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9178         (map_overlay_command, unmap_overlay_command)
9179         (simple_overlay_update, expand_symtabs_matching)
9180         (map_symbol_filenames): Update.
9181         * symfile-debug.c (set_debug_symfile): Update.
9182         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9183         Update.
9184         * source.c (select_source_symtab, forget_cached_source_info):
9185         Update.
9186         * solib.c (solib_read_symbols): Update.
9187         * solib-spu.c (append_ocl_sos): Update.
9188         * psymtab.c (maintenance_print_psymbols)
9189         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9190         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9191         * printcmd.c (info_symbol_command): Update.
9192         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9193         Update.
9194         * objfiles.h (class all_objfiles): Remove.
9195         * objfiles.c (have_partial_symbols, have_full_symbols)
9196         (have_minimal_symbols, qsort_cmp, update_section_map)
9197         (shared_objfile_contains_address_p)
9198         (default_iterate_over_objfiles_in_search_order): Update.
9199         * objc-lang.c (info_selectors_command, info_classes_command)
9200         (find_methods): Update.
9201         * minsyms.c (find_solib_trampoline_target): Update.
9202         * maint.c (maintenance_info_sections)
9203         (maintenance_translate_address, count_symtabs_and_blocks):
9204         Update.
9205         * main.c (captured_main_1): Update.
9206         * linux-thread-db.c (try_thread_db_load_from_pdir)
9207         (has_libpthread): Update.
9208         * linespec.c (iterate_over_all_matching_symtabs)
9209         (search_minsyms_for_name): Update.
9210         * jit.c (jit_find_objf_with_entry_addr): Update.
9211         * hppa-tdep.c (find_unwind_entry)
9212         (hppa_lookup_stub_minimal_symbol): Update.
9213         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9214         Update.
9215         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9216         (elf_gnu_ifunc_resolve_by_got): Update.
9217         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9218         * dwarf-index-write.c (save_gdb_index_command): Update.
9219         * cp-support.c (add_symbol_overload_list_qualified): Update.
9220         * breakpoint.c (create_overlay_event_breakpoint)
9221         (create_longjmp_master_breakpoint)
9222         (create_std_terminate_master_breakpoint)
9223         (create_exception_master_breakpoint): Update.
9224         * blockframe.c (find_pc_partial_function): Update.
9225         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9226         (ada_collect_symbol_completion_matches)
9227         (ada_add_global_exceptions): Update.
9228
9229 2019-01-17  Tom Tromey  <tom@tromey.com>
9230
9231         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9232         declare VEC.
9233         (solib_target_parse_libraries): Change return type.
9234         (library_list_start_segment, library_list_start_section)
9235         (library_list_end_library, library_list_start_library); Update.
9236         (solib_target_free_library_list): Remove.
9237         (solib_target_parse_libraries): Remove cleanup.  Change return
9238         type.
9239         (solib_target_current_sos): Update.
9240
9241 2019-01-17  Tom Tromey  <tromey@bapiya>
9242
9243         * valprint.c: Replace "the the" with "the".
9244         * symtab.c: Replace "the the" with "the".
9245         * solib.c: Replace "the the" with "the".
9246         * solib-dsbt.c: Replace "the the" with "the".
9247         * linespec.c: Replace "the the" with "the".
9248         * dwarf2loc.h: Replace "the the" with "the".
9249         * amd64-windows-tdep.c: Replace "the the" with "the".
9250         * aarch64-tdep.c: Replace "the the" with "the".
9251
9252 2019-01-16  Keith Seitz  <keiths@redhat.com>
9253
9254         PR gdb/23773
9255         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9256         <builder>: Rename to ..
9257         <m_builder>: ... this and make private.
9258         (dwarf2_cu::get_builder): New method.  Change all users of
9259         `builder' to use this method.
9260         (dwarf2_start_symtab): Move to ...
9261         (dwarf2_cu::start_symtab): ... here.  Update all callers
9262         (setup_type_unit_groups): Move to ...
9263         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9264         callers.
9265         (dwarf2_cu::reset_builder): New method.
9266         (process_full_compunit, process_full_type_unit): Use
9267         dwarf2_cu::reset_builder.
9268         (follow_die_offset): Record the ancestor CU if it is different
9269         from the followed DIE's CU.
9270         (follow_die_sig_1): Likewise.
9271
9272 2019-01-15  Tom Tromey  <tom@tromey.com>
9273
9274         * remote.c (class remote_state) <buf>: Now a char_vector.
9275         <buf_size>: Remove.
9276         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9277         parameter.
9278         (remote_target::getpkt_or_notif_sane_1)
9279         (remote_target::getpkt_sane)
9280         (remote_target::getpkt_or_notif_sane): Likewise.
9281         (class remote_target) <putpkt>: New overload.
9282         (remote_target::read_frame): Change type of "buf_p".  Remove
9283         sizeof_p parameter.
9284         (packet_ok): New overload.
9285         (packet_check_result): New overload.
9286         Update all uses.
9287
9288 2019-01-14  Tom Tromey  <tom@tromey.com>
9289
9290         * remote-notif.c (handle_notification, remote_notif_ack)
9291         (remote_notif_parse): Make "buf" const.
9292         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9293         const.
9294         (remote_notif_parse, remote_notif_ack, handle_notification):
9295         Likewise.
9296         * remote.c (remote_notif_stop_parse): Make "buf" const.
9297         (remote_target::remote_parse_stop_reply): Make "buf" const.
9298         (remote_notif_stop_ack): Make "buf" const.
9299
9300 2019-01-14  Tom Tromey  <tom@tromey.com>
9301
9302         * remote.c (remote_console_output): Make parameter const.
9303
9304 2019-01-14  Tom Tromey  <tom@tromey.com>
9305
9306         * target-debug.h (target_debug_print_signals): Constify.
9307         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9308         * procfs.c (procfs_target::pass_signals): Update.
9309         * linux-nat.c (linux_nat_target::pass_signals): Update.
9310         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9311         * target-delegates.c: Rebuild.
9312         * remote.c (remote_target::program_signals): Update.
9313         (remote_target::pass_signals): Update.
9314         * target.c (target_pass_signals): Constify argument.
9315         (target_program_signals): Likewise.
9316         * target.h (struct target_ops) <pass_signals, program_signals>:
9317         Constify argument.
9318         (target_pass_signals, target_program_signals): Constify argument.
9319
9320 2019-01-14  Tom Tromey  <tom@tromey.com>
9321
9322         PR tui/28819:
9323         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9324
9325 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9326
9327         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9328         field.
9329         * rs6000-tdep.c: Include reggroups.h.
9330         (IS_V_ALIAS_PSEUDOREG): Define.
9331         (rs6000_register_name): Return names for the "vX" aliases.
9332         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9333         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9334         aliases.  Call default_register_reggroup_p for all other
9335         pseudo-registers.
9336         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9337         New functions.
9338         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9339         Handle "vX" aliases.
9340         (v_alias_pseudo_register_collect): New function.
9341         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9342         (rs6000_gdbarch_init): Initialize "vX" aliases as
9343         pseudo-registers.  Restore registration of
9344         rs6000_pseudo_register_reggroup_p with
9345         set_tdesc_pseudo_register_reggroup_p.
9346
9347 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9348
9349         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9350         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9351         set_gdbarch_num_pseudo_regs.
9352
9353 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9354
9355         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9356         Remove arg prefixname, add do_set and do_show.
9357         Add member functions set_list and show_list.
9358         * cli/cli-style.c (class cli_style_option): Update accordingly.
9359         (style_set_list): Move to file scope.
9360         (style_show_list): Likewise.
9361         (set_style): Call help_list.
9362         (show_style): Call cmd_show_list.
9363         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9364         Update to use the new macro.
9365
9366 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9367
9368         * ada-lang.c (_initialize_ada_language): Expand the help text
9369         for the "catch exception" command.
9370
9371 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9372
9373         * symtab.c (matching_obj_sections): Initialize obj,
9374         declare it closer to its usage.
9375
9376 2019-01-10  Tom Tromey  <tom@tromey.com>
9377
9378         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9379         (basic_inf_threads_range): Remove.
9380         (inf_threads_range, inf_non_exited_threads_range)
9381         (safe_inf_threads_range): Use next_adapter.
9382
9383 2019-01-10  Keith Seitz  <keiths@redhat.com>
9384
9385         PR gdb/23712
9386         PR symtab/23010
9387         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9388         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9389
9390 2019-01-10  Keith Seitz  <keiths@redhat.com>
9391
9392         PR gdb/23712
9393         PR symtab/23010
9394         * dictionary.c (pending_to_vector): Remove.
9395         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9396         Remove _1 suffix, replacing functions of the same name.  Update
9397         all callers.
9398         (dict_create_hashed, dict_create_hashed_expandable)
9399         (dict_create_linear, dict_create_linear_expandable, dict_free)
9400         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9401         Make functions static.
9402
9403 2019-01-10  Keith Seitz  <keiths@redhat.com>
9404
9405         PR gdb/23712
9406         PR symtab/23010
9407         * dictionary.h (struct dictionary): Replace declaration with
9408         multidictionary.
9409         (dict_create_hashed, dict_create_hashed_expandable)
9410         (dict_create_linear, dict_create_linear_expandable)
9411         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9412         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9413         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9414         taking multidictionary argument.
9415         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9416         * block.h (struct block) <dict>: Change to multidictionary
9417         and rename `multidict'.
9418         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9419         symmisc.c: Update all dictionary references to multidictionary.
9420
9421 2019-01-10  Keith Seitz  <keiths@redhat.com>
9422
9423         PR gdb/23712
9424         PR symtab/23010
9425         * dictionary.c: Include unordered_map.
9426         (pending_to_vector): New function.
9427         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9428         Rewrite the non-"_1" functions to take vector instead
9429         of linked list.
9430         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9431         "new" _1 versions of the same name.
9432         (multidictionary): Define.
9433         (std::hash<enum language): New definition.
9434         (collate_pending_symbols_by_language, mdict_create_hashed)
9435         (mdict_create_hashed_expandable, mdict_create_linear)
9436         (mdict_create_linear_expandable, mdict_free)
9437         (find_language_dictionary, create_new_language_dictionary)
9438         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9439         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9440         (mdict_size, mdict_empty): New functions.
9441         * dictionary.h (mdict_iterator): Define.
9442
9443 2019-01-10  Pedro Alves  <palves@redhat.com>
9444
9445         * breakpoint.c (read_uploaded_action)
9446         (create_tracepoint_from_upload): Adjust to use
9447         gdb::unique_xmalloc_ptr.
9448         * ctf.c (ctf_write_uploaded_tp):
9449         (SET_ARRAY_FIELD): Use emplace_back.
9450         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9451         * tracefile-tfile.c (tfile_write_uploaded_tp):
9452         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9453         gdb::unique_xmalloc_ptr.
9454         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9455         at_string, cond_string, cmd_strings>: Replace char pointers
9456         with gdb::unique_xmalloc_ptr.
9457
9458 2019-01-10  Pedro Alves  <palves@redhat.com>
9459
9460         * solib-target.c (library_list_start_library): Don't xstrdup name.
9461
9462 2019-01-10  Pedro Alves  <palves@redhat.com>
9463
9464         * mdebugread.c (parse_partial_symbols): Use
9465         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9466
9467 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9468
9469         * linux-fork.c (scoped_switch_fork_info)
9470         <~scoped_switch_fork_info>: Fix incorrect variable name.
9471
9472 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9473
9474         * linux-fork.c (scoped_switch_fork_info)
9475         <scoped_switch_fork_info>: Make explicit.
9476         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9477
9478 2019-01-10  Tom Tromey  <tom@tromey.com>
9479
9480         * objfiles.h (objfile::reset_psymtabs): Update.
9481         * objfiles.c (objfile::objfile): Update.
9482         * psymtab.h (psymtab_storage::obstack): Update.
9483         (psymtab_storage::m_obstack): Use gdb::optional.
9484         (class psymtab_storage): Update comment.  Remove objfile
9485         parameter.
9486         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9487
9488 2019-01-10  Tom Tromey  <tom@tromey.com>
9489
9490         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9491         <free_psymtabs>: Now private.
9492         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9493         (allocate_psymtab): Use new method.
9494
9495 2019-01-10  Tom Tromey  <tom@tromey.com>
9496
9497         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9498         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9499         * mdebugread.c (parse_partial_symbols): Use
9500         allocate_dependencies.
9501         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9502         allocate_dependencies.
9503         (process_psymtab_comp_unit_reader)
9504         (build_type_psymtab_dependencies): Likewise.
9505         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9506
9507 2019-01-10  Tom Tromey  <tom@tromey.com>
9508
9509         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9510         PSYMBOL_SET_LANGUAGE.
9511         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9512
9513 2019-01-10  Tom Tromey  <tom@tromey.com>
9514
9515         * psymtab.h (psymtab_storage::obstack): New method.
9516         <m_obstack>: Rename from obstack; now private.
9517         * psymtab.c (psymtab_storage): Update.
9518         * dwarf2read.c (create_addrmap_from_index)
9519         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9520         Update.
9521
9522 2019-01-10  Tom Tromey  <tom@tromey.com>
9523
9524         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9525         * objfiles.h (objfile::reset_psymtabs): New method.
9526
9527 2019-01-10  Tom Tromey  <tom@tromey.com>
9528
9529         * symmisc.c (print_symbol_bcache_statistics): Update.
9530         (print_objfile_statistics): Update.
9531         * symfile.c (reread_symbols): Update.
9532         * psymtab.h (class psymtab_storage): New.
9533         * psymtab.c (psymtab_storage): New constructor.
9534         (~psymtab_storage): New destructor.
9535         (require_partial_symbols): Update.
9536         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9537         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9538         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9539         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9540         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9541         (start_psymtab_common, end_psymtab_common)
9542         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9543         (allocate_psymtab): Update.
9544         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9545         Update.
9546         (dump_psymtab_addrmap, maintenance_print_psymbols)
9547         (maintenance_check_psymtabs): Update.
9548         (class objfile_psymtabs): Move to objfiles.h.
9549         * psympriv.h (discard_psymtab): Now inline.
9550         (psymtab_discarder::psymtab_discarder): Update.
9551         (psymtab_discarder::~psymtab_discarder): Update.
9552         (ALL_OBJFILE_PSYMTABS): Rewrite.
9553         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9554         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9555         Remove fields.
9556         <partial_symtabs>: New field.
9557         (class objfile_psymtabs): Move from psymtab.h.  Update.
9558         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9559         psymbol_cache.
9560         (objfile::~objfile): Don't destroy psymbol_cache.
9561         * mdebugread.c (parse_partial_symbols): Update.
9562         * dwarf2read.c (create_addrmap_from_index)
9563         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9564         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9565         (add_partial_subprogram, dwarf2_ranges_read): Update.
9566         * dwarf-index-write.c (write_address_map)
9567         (write_one_signatured_type, recursively_write_psymbols)
9568         (class debug_names, class debug_names, write_psymtabs_to_index):
9569         Update.
9570
9571 2019-01-10  Tom Tromey  <tom@tromey.com>
9572
9573         * symtab.h (SYMBOL_SET_NAMES): Update.
9574         (symbol_set_names): Update.
9575         (MSYMBOL_SET_NAMES): Update.
9576         * symtab.c (symbol_set_names): Change argument to be an
9577         objfile_per_bfd_storage.
9578         * psymtab.c (add_psymbol_to_bcache): Update.
9579         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9580
9581 2019-01-10  Tom Tromey  <tom@tromey.com>
9582
9583         * symtab.c (create_demangled_names_hash): Change argument to be an
9584         objfile_per_bfd_storage.
9585         (symbol_set_names): Update.
9586
9587 2019-01-10  Tom Tromey  <tom@tromey.com>
9588
9589         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9590         init_psymbol_list.
9591         * psymtab.c (init_psymbol_list): Do nothing if already called.
9592         * psympriv.h (init_psymbol_list): Add comment.
9593         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9594         init_psymbol_list.
9595         * dbxread.c (dbx_symfile_read): Unconditionally call
9596         init_psymbol_list.
9597
9598 2019-01-10  Tom Tromey  <tom@tromey.com>
9599
9600         * xcoffread.c (scan_xcoff_symtab): Update.
9601         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9602         "where".
9603         * mdebugread.c (parse_partial_symbols)
9604         (handle_psymbol_enumerators): Update.
9605         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9606         * dbxread.c (read_dbx_symtab): Update.
9607         * psympriv.h (psymbol_placement): New enum.
9608         (add_psymbol_to_list): Update.
9609
9610 2019-01-10  Tom Tromey  <tom@tromey.com>
9611
9612         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9613         static_psymbols parameters.
9614         (scan_xcoff_symtab): Update.
9615         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9616         static_psymbols parameters.
9617         * psympriv.h (start_psymtab_common): Update.
9618         * mdebugread.c (parse_partial_symbols): Update.
9619         * dwarf2read.c (create_partial_symtab): Update.
9620         * dbxread.c (read_dbx_symtab): Update.
9621         (start_psymtab): Remove global_psymbols and static_psymbols
9622         parameters.
9623
9624 2019-01-10  Tom Tromey  <tom@tromey.com>
9625
9626         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9627         * psymtab.c (allocate_psymtab): Add comment.
9628         * psympriv.h (allocate_psymtab): Add comment.
9629         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9630         initializations.
9631         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9632
9633 2019-01-10  Tom Tromey  <tom@tromey.com>
9634
9635         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9636         Don't declare.
9637         * mipsread.c: Include mdebugread.h.
9638         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9639         Declare.
9640         * elfread.c: Include mdebugread.h.
9641
9642 2019-01-09  Tom Tromey  <tom@tromey.com>
9643
9644         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9645         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9646         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9647         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9648         (psym_lookup_symbol, psym_find_last_source_symtab)
9649         (psym_forget_cached_source_info, psym_print_stats)
9650         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9651         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9652         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9653         (psym_find_compunit_symtab_by_address)
9654         (maintenance_print_psymbols, maintenance_info_psymtabs)
9655         (maintenance_check_psymtabs): Use ranged for.
9656         * psymtab.h (class objfile_psymtabs): New.
9657         (require_partial_symbols): Return objfile_psymtabs.
9658         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9659
9660 2019-01-09  Tom Tromey  <tom@tromey.com>
9661
9662         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9663         (find_pc_mapped_section, list_overlays_command)
9664         (map_overlay_command, unmap_overlay_command)
9665         (simple_overlay_update): Use all_objfiles.
9666         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9667         * printcmd.c (info_symbol_command): Use all_objfiles.
9668         * objfiles.h (ALL_OBJSECTIONS): Remove.
9669         * maint.c (maintenance_translate_address): Use all_objfiles.
9670         * gcore.c (gcore_create_callback): Use all_objfiles.
9671         (objfile_find_memory_regions): Likewise.
9672
9673 2019-01-09  Tom Tromey  <tom@tromey.com>
9674
9675         * symtab.c (find_line_symtab, info_sources_command)
9676         (make_source_files_completion_list): Use objfile_compunits.
9677         * source.c (select_source_symtab): Use objfile_compunits.
9678         * objfiles.h (struct objfile): Update comment.
9679         (ALL_OBJFILES): Remove.
9680         (ALL_FILETABS): Remove.
9681         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9682         objfile_compunits.
9683
9684 2019-01-09  Tom Tromey  <tom@tromey.com>
9685
9686         * symmisc.c (print_objfile_statistics, dump_objfile)
9687         (maintenance_print_symbols): Use compunit_filetabs.
9688         * source.c (forget_cached_source_info_for_objfile): Use
9689         compunit_filetabs.
9690         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9691         (ALL_FILETABS): Use compunit_filetabs.
9692         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9693         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9694
9695 2019-01-09  Tom Tromey  <tom@tromey.com>
9696
9697         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9698         (compunit_filetabs): New.
9699         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9700         compunit_filetabs.
9701         (info_sources_command, make_source_files_completion_list): Remove
9702         declaration.
9703         * symmisc.c (print_objfile_statistics, dump_objfile)
9704         (maintenance_print_symbols): Remove declaration.
9705         (maintenance_info_symtabs): Use compunit_filetabs.
9706         (maintenance_info_line_tables): Likewise.
9707         * source.c (select_source_symtab): Change local variable name.
9708         (forget_cached_source_info_for_objfile): Remove declaration.
9709         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9710         * objfiles.c (objfile_relocate1): Remove declaration.
9711         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9712         declaration.
9713         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9714         * coffread.c (coff_symtab_read): Remove declaration.
9715         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9716         compunit_filetabs.
9717
9718 2019-01-09  Tom Tromey  <tom@tromey.com>
9719
9720         * symtab.c (lookup_objfile_from_block)
9721         (find_pc_sect_compunit_symtab, search_symbols)
9722         (default_collect_symbol_completion_matches_break_on): Use
9723         objfile_compunits.
9724         * objfiles.h (ALL_COMPUNITS): Remove.
9725         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9726         * cp-support.c (add_symbol_overload_list_qualified): Use
9727         objfile_compunits.
9728         * ada-lang.c (ada_collect_symbol_completion_matches)
9729         (ada_add_global_exceptions): Use objfile_compunits.
9730
9731 2019-01-09  Tom Tromey  <tom@tromey.com>
9732
9733         * source.c (select_source_symtab)
9734         (forget_cached_source_info_for_objfile): Remove declaration.
9735         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9736         declaration.
9737         * maint.c (count_symtabs_and_blocks): Remove declaration.
9738         * cp-support.c (add_symbol_overload_list_qualified): Remove
9739         declaration.
9740         * coffread.c (coff_symtab_read): Remove declaration.
9741         * symtab.c (lookup_symbol_in_objfile_symtabs)
9742         (basic_lookup_transparent_type_1): Use objfile_compunits.
9743         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9744         (info_sources_command, search_symbols)
9745         (default_collect_symbol_completion_matches_break_on)
9746         (make_source_files_completion_list): Remove declaration.
9747         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9748         (ada_collect_symbol_completion_matches)
9749         (ada_add_global_exceptions): Remove declaration.
9750         * linespec.c (iterate_over_all_matching_symtabs): Use
9751         objfile_compunits.
9752         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9753         (class objfile_compunits): New.
9754         (ALL_COMPUNITS): Use objfile_compunits.
9755         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9756         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9757         objfile_compunits.
9758         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9759
9760 2019-01-09  Tom Tromey  <tom@tromey.com>
9761
9762         * symtab.c (search_symbols)
9763         (default_collect_symbol_completion_matches_break_on): Use
9764         objfile_msymbols.
9765         * ada-lang.c (ada_lookup_simple_minsym)
9766         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9767         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9768         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9769         objfile_msymbols.
9770         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9771         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9772         * objc-lang.c (find_methods): Use objfile_msymbols.
9773         (info_selectors_command, info_classes_command): Likewise.
9774         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9775         * objfiles.h (class objfile_msymbols): New.
9776         (ALL_OBJFILE_MSYMBOLS): Remove.
9777         (ALL_MSYMBOLS): Remove.
9778
9779 2019-01-09  Tom Tromey  <tom@tromey.com>
9780
9781         * common/next-iterator.h (next_adapter): Add Iterator template
9782         parameter.
9783         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9784         (class all_objfiles_safe): New.
9785         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9786         * objfiles.c (put_objfile_before): Update comment.
9787         (add_separate_debug_objfile): Likewise.
9788         (free_all_objfiles): Use all_objfiles_safe.
9789         (objfile_purge_solibs): Likewise.
9790
9791 2019-01-09  Tom Tromey  <tom@tromey.com>
9792
9793         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9794         (expand_symtab_containing_pc, lookup_static_symbol)
9795         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9796         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9797         all_objfiles.
9798         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9799         * breakpoint.c (create_overlay_event_breakpoint)
9800         (create_longjmp_master_breakpoint)
9801         (create_std_terminate_master_breakpoint)
9802         (create_exception_master_breakpoint): Use all_objfiles.
9803         * linux-thread-db.c (try_thread_db_load_from_pdir)
9804         (has_libpthread): Use all_objfiles.
9805         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9806         * linespec.c (iterate_over_all_matching_symtabs)
9807         (search_minsyms_for_name): Use all_objfiles.
9808         * maint.c (maintenance_info_sections): Use all_objfiles.
9809         * main.c (captured_main_1): Use all_objfiles.
9810         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9811         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9812         * guile/scm-pretty-print.c
9813         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9814         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9815         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9816         (maintenance_print_msymbols): Use all_objfiles.
9817         * source.c (select_source_symtab): Use all_objfiles.
9818         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9819         * symfile.c (remove_symbol_file_command)
9820         (expand_symtabs_matching, map_symbol_filenames): Use
9821         all_objfiles.
9822         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9823         all_objfiles.
9824         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9825         * objc-lang.c (find_methods): Use all_objfiles.
9826         * objfiles.c (have_partial_symbols, have_full_symbols)
9827         (have_minimal_symbols, qsort_cmp)
9828         (default_iterate_over_objfiles_in_search_order): Use
9829         all_objfiles.
9830         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9831         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9832         (maintenance_check_psymtabs): Use all_objfiles.
9833         (ALL_PSYMTABS): Remove.
9834         * compile/compile-object-run.c (do_module_cleanup): Use
9835         all_objfiles.
9836         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9837         * cp-support.c (add_symbol_overload_list_qualified): Use
9838         all_objfiles.
9839         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9840         Use all_objfiles.
9841         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9842         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9843         all_objfiles.
9844         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9845         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9846         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9847         Uses all_objfiles.
9848         * solib.c (solib_read_symbols): Use all_objfiles
9849
9850 2019-01-09  Tom Tromey  <tom@tromey.com>
9851
9852         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9853         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9854         all_objfiles.
9855         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9856         * symmisc.c (print_symbol_bcache_statistics)
9857         (print_objfile_statistics, maintenance_print_objfiles)
9858         (maintenance_info_symtabs, maintenance_check_symtabs)
9859         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9860         all_objfiles.
9861         * source.c (forget_cached_source_info): Use all_objfiles.
9862         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9863         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9864         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9865         * objfiles.c (update_section_map): Use all_objfiles.
9866         (shared_objfile_contains_address_p): Likewise.
9867         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9868         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9869
9870 2019-01-09  Tom Tromey  <tom@tromey.com>
9871
9872         * common/next-iterator.h: New file.
9873         * objfiles.h (class all_objfiles): New.
9874         (struct objfile_iterator): New.
9875
9876 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9877
9878         * NEWS: Move the description of the changed "frame", "select-frame",
9879          and "info frame" commands to the Changed commands section.
9880
9881 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9882
9883         * gdbtypes.c (check_stub_method_group): Remove handling of old
9884         mangling schemes.
9885         * linespec.c (find_methods): Likewise.
9886         * stabsread.c (read_member_functions): Likewise.
9887         * valops.c (search_struct_method): Likewise.
9888         (value_struct_elt_for_reference): Likewise.
9889         * NEWS: Mention this change.
9890
9891 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9892
9893         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9894         print_source_lines.
9895         * source.c (print_source_lines_base): Update line number check.
9896         (print_source_lines): New function.
9897         (source_lines_range::source_lines_range): New function.
9898         * source.h (class source_lines_range): New class.
9899         (print_source_lines): New declaration.
9900
9901 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9902
9903         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9904
9905 2019-01-08  Tom Tromey  <tom@tromey.com>
9906             Simon Marchi  <simon.marchi@ericsson.com>
9907
9908         PR gdb/24060
9909         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9910         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9911         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9912         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9913         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9914         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9915
9916 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9917
9918         * source.c (select_source_symtab): Move header comment to
9919         declaration in source.h.
9920         (forget_cached_source_info_for_objfile): Likewise.
9921         (forget_cached_source_info): Likewise.
9922         (identify_source_line): Likewise.
9923         * source.h (identify_source_line): Move declaration from symtab.h
9924         and add comment from source.c
9925         (print_source_lines): Likewise.
9926         (forget_cached_source_info_for_objfile): Likewise.
9927         (forget_cached_source_info): Likewise.
9928         (select_source_symtab): Likewise.
9929         (enum print_source_lines_flag): Move definition from symtab.h.
9930         * symtab.h (identify_source_line): Move declaration to source.h.
9931         (print_source_lines): Likewise.
9932         (forget_cached_source_info_for_objfile): Likewise.
9933         (forget_cached_source_info): Likewise.
9934         (select_source_symtab): Likewise.
9935         (enum print_source_lines_flag): Move definition to source.h.
9936         * tui/tui-hooks.c: Add 'source.h' include.
9937
9938 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9939
9940         * source.c (print_source_lines_base): Handle requests to print
9941         reverse line number sequences, and guard against empty lines
9942         string.
9943
9944 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9945
9946         * source.c (print_source_lines_base): Fix skip of '\r' if next
9947         character is '\n'.
9948
9949 2019-01-06  Tom Tromey  <tom@tromey.com>
9950
9951         * c-exp.y (struct c_parse_state) <macro_original_text,
9952         expansion_obstack>: New member.
9953         (macro_original_text, expansion_obstack): Remove globals.
9954         (scan_macro_expansion, scanning_macro_expansion)
9955         (finished_macro_expansion): Update.
9956         (scan_macro_cleanup): Remove.
9957         (yylex, c_parse): Update.
9958
9959 2019-01-06  Tom Tromey  <tom@tromey.com>
9960
9961         * c-exp.y (struct c_parse_state) <strings>: New member.
9962         (operator_stoken): Update.
9963
9964 2019-01-06  Tom Tromey  <tom@tromey.com>
9965
9966         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9967         (union type_stack_elt) <typelist_val>: Now a pointer to
9968         std::vector.
9969         (type_stack_cleanup): Don't declare.
9970         (push_typelist): Update.
9971         * parse.c (pop_typelist): Return a std::vector.
9972         (push_typelist): Take a std::vector.
9973         (follow_types): Update.  Do not free args.
9974         (type_stack_cleanup): Remove.
9975         * c-exp.y (struct c_parse_state): New.
9976         (cpstate): New global.
9977         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9978         (nonempty_typelist): Update.
9979         (func_mod): Create a new vector.
9980         (c_parse): Create a c_parse_state.
9981         (check_parameter_typelist): Do not delete params.
9982         (function_method): Update.  Do not delete type_list.
9983
9984 2019-01-06  Tom Tromey  <tom@tromey.com>
9985
9986         PR gdb/28155:
9987         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9988         check_typedef.
9989         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9990         (print_return_value): Likewise.
9991
9992 2019-01-05  Tom Tromey  <tom@tromey.com>
9993
9994         * contrib/cleanup_check.py: Remove.
9995         * contrib/gcc-with-excheck: Remove.
9996         * contrib/exsummary.py: Remove.
9997         * contrib/excheck.py: Remove.
9998
9999 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10000
10001         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10002         NULL. Initialize tpprev to NULL instead of assigning it
10003         to NULL on the next statement.
10004         * windows-nat.c (windows_delete_thread): Remove check for
10005         main_thread_id before printing thread exit notifications.
10006         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10007         Remove thread ID check against main_thread_id.
10008         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10009         windows_delete_thread.
10010         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10011
10012 2019-01-04  Tom Tromey  <tom@tromey.com>
10013
10014         * compile/compile.c (_initialize_compile): Use upper case for
10015         metasyntactic variables.
10016         * symmisc.c (_initialize_symmisc): Use upper case for
10017         metasyntactic variables.
10018         * psymtab.c (_initialize_psymtab): Use upper case for
10019         metasyntactic variables.
10020         * demangle.c (demangle_command): Use upper case for metasyntactic
10021         variables.
10022         (_initialize_demangler): Likewise.
10023         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10024         variables.
10025
10026 2019-01-03  Tom Tromey  <tom@tromey.com>
10027
10028         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10029
10030 2019-01-03  Tom Tromey  <tom@tromey.com>
10031
10032         * python/py-symtab.c (salpy_str): Update.
10033         (struct salpy_sal_object) <symtab>: Now a PyObject.
10034         (salpy_dealloc): Update.
10035         (del_objfile_sal): Use gdbpy_ref.
10036
10037 2019-01-03  Tom Tromey  <tom@tromey.com>
10038
10039         * python/py-type.c (convert_field): Use new_reference.  Return
10040         gdbpy_ref.
10041         (make_fielditem): Return gdbpy_ref.
10042         (typy_fields): Update.
10043         (typy_getitem): Update.
10044         (field_name): Return gdbpy_ref.  Use new_reference.
10045         (typy_iterator_iternext): Update.
10046
10047 2019-01-03  Tom Tromey  <tom@tromey.com>
10048
10049         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10050
10051 2019-01-03  Tom Tromey  <tom@tromey.com>
10052
10053         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10054         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10055         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10056         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10057         (pspy_set_type_printers): Likewise.
10058         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10059         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10060         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10061         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10062         (objfpy_set_type_printers): Likewise.
10063
10064 2019-01-03  Tom Tromey  <tom@tromey.com>
10065
10066         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10067         (gdbpy_print_stack): Use gdbpy_err_fetch.
10068         * python/python-internal.h (class gdbpy_err_fetch): New class.
10069         (class gdbpy_enter) <m_error_type, m_error_value,
10070         m_error_traceback>: Remove.
10071         <m_error>: New member.
10072         (gdbpy_exception_to_string): Don't declare.
10073         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10074         * python/py-value.c (convert_value_from_python): Use
10075         gdbpy_err_fetch.
10076         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10077         gdbpy_exception_to_string.
10078         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10079         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10080         gdbpy_err_fetch.
10081
10082 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10083
10084         * linux-nat.c (delete_lwp_cleanup): Delete.
10085         (struct lwp_deleter): New struct.
10086         (lwp_info_up): New typedef.
10087         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10088         lwp_info_up.
10089
10090 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10091
10092         * linux-fork.c (class scoped_switch_fork_info): New class.
10093         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10094
10095 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10096
10097         * valops.c (find_overload_match): Remove use of null_cleanup, and
10098         calls to do_cleanups.
10099
10100 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10101
10102         * compile/compile-cplus-types.c
10103         (compile_cplus_instance::decl_name): Handle changes to
10104         cp_func_name.
10105         * cp-support.c (cp_func_name): Update header comment, update
10106         return type.
10107         * cp-support.h (cp_func_name): Update return type in declaration.
10108         * valops.c (find_overload_match): Move temp_func local to top
10109         level of function and change its type.  Use temp_func to hold and
10110         delete temporary string obtained from cp_func_name.
10111
10112 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10113
10114         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10115         gdb::char_vector, remove cleanup, and update uses of `msg`.
10116
10117 2019-01-03  Jim Wilson  <jimw@sifive.com>
10118
10119         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10120
10121 2019-01-02  Tom Tromey  <tom@tromey.com>
10122
10123         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10124         (tdesc_parse_xml): Remove cleanups.
10125         * target-descriptions.h (make_cleanup_free_target_description):
10126         Don't declare.
10127         (target_desc_deleter): New struct.
10128         (target_desc_up): New typedef.
10129         * target-descriptions.c (target_desc_deleter::operator()): Rename
10130         from free_target_description.
10131         (make_cleanup_free_target_description): Remove.
10132
10133 2019-01-02  Tom Tromey  <tom@tromey.com>
10134
10135         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10136         constructor, destructor.
10137         (linespec_parser): Remove typedef.
10138         (~linespec_parser): Rename from linespec_parser_delete.
10139         (linespec_lex_to_end, linespec_complete_label)
10140         (linespec_complete): Update.
10141         (decode_line_full): Remove cleanups.
10142         (decode_line_1): Update.
10143
10144 2019-01-02  Tom Tromey  <tom@tromey.com>
10145
10146         * python/python-internal.h (inferior_to_inferior_object): Change
10147         return type.
10148         * python/py-exitedevent.c (create_exited_event_object): Update.
10149         * python/py-inferior.c (inferior_to_inferior_object): Return
10150         gdbpy_ref.
10151         (python_new_inferior, python_inferior_deleted)
10152         (thread_to_thread_object, delete_thread_object)
10153         (build_inferior_list, gdbpy_selected_inferior): Update.
10154         * python/py-infthread.c (create_thread_object): Update.  Also fail
10155         if inferior_to_inferior_object fails.
10156
10157 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10158
10159         * inferior.h (class inferior) <displaced_step_state>: New field.
10160         * infrun.h (struct displaced_step_state): Move here from
10161         infrun.c.  Initialize fields, add constructor.
10162         <inf>: Remove field.
10163         <reset>: New method.
10164         * infrun.c (struct displaced_step_inferior_state): Move to
10165         infrun.h.
10166         (displaced_step_inferior_states): Remove.
10167         (get_displaced_stepping_state): Adust.
10168         (displaced_step_in_progress_any_inferior): Adjust.
10169         (displaced_step_in_progress_thread): Adjust.
10170         (displaced_step_in_progress): Adjust.
10171         (add_displaced_stepping_state): Remove.
10172         (get_displaced_step_closure_by_addr): Adjust.
10173         (remove_displaced_stepping_state): Remove.
10174         (infrun_inferior_exit): Call displaced_step_state.reset.
10175         (use_displaced_stepping): Don't check for NULL.
10176         (displaced_step_prepare_throw): Call
10177         get_displaced_stepping_state.
10178         (displaced_step_fixup): Don't check for NULL.
10179         (prepare_for_detach): Don't check for NULL.
10180
10181 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10182
10183         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10184          in case of call that did not complete.
10185
10186 2019-01-02  Andrey Utkin  <autkin@undo.io>
10187
10188         * symfile.c (find_separate_debug_file): Fix search of debug files for
10189         remote debuggee.
10190
10191 2019-01-02  Tom Tromey  <tom@tromey.com>
10192
10193         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10194         indentation.
10195         * python/py-frame.c (frapy_older): Remove cast.
10196         (frapy_newer): Likewise.
10197         * python/py-breakpoint.c (local_setattro): Remove cast.
10198         * python/py-arch.c (archpy_name): Remove local variable.
10199         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10200
10201 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10202
10203         * unittests/basic_string_view/element_access/char/empty.cc:
10204         Fix year range in copyright header.
10205
10206 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10207
10208         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10209         Delete.
10210         <operator==>: Update with for removed field.
10211         <hash>: Likewise.
10212         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10213         <isa_features>: ...this.
10214         <abi_features>: New field.
10215         (riscv_isa_flen): Update comment.
10216         (riscv_abi_xlen): New declaration.
10217         (riscv_abi_flen): New declaration.
10218         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10219         isa_features.
10220         (riscv_abi_xlen): New function.
10221         (riscv_isa_flen): Update to get answer from isa_features.
10222         (riscv_abi_flen): New function.
10223         (riscv_has_fp_abi): Update to get answer from abi_features.
10224         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10225         xlen and flen.
10226         (riscv_call_info) <xlen, flen>: Update comment.
10227         (riscv_call_arg_struct): Remove invalid assertions
10228         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10229         is removed.
10230         (riscv_gdbarch_init): Gather isa features and abi features
10231         separately, ensure both match on the gdbarch when reusing an old
10232         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10233         a target with 64-bit float hardware.
10234
10235 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10236
10237         * source.c (search_command_helper): Stop reverse search
10238         when line 1 has been searched.
10239
10240 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10241
10242         * record-full.c (record_full_base_target::close): Rewrite
10243         record_full_core_buf_list free logic.
10244
10245 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10246
10247         * break-catch-syscall.c (print_one_catch_syscall): xfree
10248         the last text.
10249
10250 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10251
10252         * top.c (print_gdb_version): Update Copyright year in version
10253         message.
10254
10255 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10256
10257         Update copyright year range in all GDB files.
10258
10259 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10260
10261         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10262
10263 For older changes see ChangeLog-2018.
10264 \f
10265 Local Variables:
10266 mode: change-log
10267 left-margin: 8
10268 fill-column: 74
10269 version-control: never
10270 coding: utf-8
10271 End:
10272