gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.h (tui_refresh_all): Update.
   4         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
   5         (tui_refresh_all): Remove "list" parameter.  Use foreach.
   6         * tui/tui-win.c (window_name_completer): Use foreach.
   7         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
   8         (update_tab_width): Likewise.
   9         * tui/tui-layout.c (show_layout): Update.
  10         * tui/tui-data.h (class tui_window_iterator): New.
  11         (struct all_tui_windows): New.
  12         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
  13
  14 2019-07-17  Tom Tromey  <tom@tromey.com>
  15
  16         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
  17         parameter.  Don't reference globals.
  18         (tui_reg_command): Update.
  19
  20 2019-07-17  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-regs.c (tui_show_registers): Simplify.
  23
  24 2019-07-17  Tom Tromey  <tom@tromey.com>
  25
  26         * tui/tui-regs.c (tui_show_registers): Update.
  27         (tui_show_register_group): Add win_info parameter.
  28
  29 2019-07-17  Tom Tromey  <tom@tromey.com>
  30
  31         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
  32         Rename from tui_display_reg_element_at_line.
  33         (tui_data_window::display_registers_from_line): Update.
  34         * tui/tui-data.h (struct tui_data_window)
  35         <display_reg_element_at_line>: New method.
  36
  37 2019-07-17  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-regs.h (tui_display_registers_from)
  40         (tui_display_registers_from_line): Don't declare.
  41         * tui/tui-windata.c (tui_data_window::display_all_data)
  42         (tui_data_window::refresh_all)
  43         (tui_data_window::do_scroll_vertical): Update.
  44         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
  45         from tui_display_registers_from.
  46         (tui_display_reg_element_at_line): Update.
  47         (tui_data_window::display_registers_from_line): Rename from
  48         tui_display_registers_from_line.
  49         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
  50         display_registers_from_line>: New methods.
  51
  52 2019-07-17  Tom Tromey  <tom@tromey.com>
  53
  54         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
  55         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
  56         from tui_erase_data_content.
  57         (tui_data_window::display_all_data)
  58         (tui_data_window::refresh_all)
  59         (tui_data_window::do_scroll_vertical): Update.
  60         * tui/tui-regs.c (tui_show_registers): Update.
  61         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
  62         New method.
  63
  64 2019-07-17  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
  67         declare.
  68         * tui/tui-windata.c
  69         (tui_data_window::delete_data_content_windows): Rename from
  70         tui_delete_data_content_windows.
  71         (tui_data_window::display_all_data)
  72         (tui_data_window::do_scroll_vertical): Update.
  73         * tui/tui-data.h (struct tui_data_window)
  74         <delete_data_content_windows>: New method.
  75
  76 2019-07-17  Tom Tromey  <tom@tromey.com>
  77
  78         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
  79         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
  80
  81 2019-07-17  Tom Tromey  <tom@tromey.com>
  82
  83         * tui/tui-windata.h (tui_display_all_data): Don't declare.
  84         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
  85         from tui_display_all_data.
  86         * tui/tui-win.c
  87         (tui_data_window::do_make_visible_with_new_height): Update.
  88         * tui/tui-regs.c (tui_show_registers): Update.
  89         * tui/tui-layout.c (tui_set_layout): Update.
  90         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
  91         method.
  92
  93 2019-07-17  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-windata.h (tui_display_data_from): Don't declare.
  96         * tui/tui-windata.c (tui_display_data_from): Remove.
  97         (tui_data_window::refresh_all): Update.
  98
  99 2019-07-17  Tom Tromey  <tom@tromey.com>
 100
 101         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 102         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 103         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 104         tui_display_registers_from_line.
 105         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 106         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 107         "force_display" parameter.
 108
 109 2019-07-17  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 112         declare.
 113         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 114         Rename from tui_first_reg_element_no_inline.
 115         (tui_display_reg_element_at_line)
 116         (tui_display_registers_from_line): Update.
 117         * tui/tui-data.h (struct tui_data_window)
 118         <first_reg_element_no_inline>: New method.
 119
 120 2019-07-17  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-windata.c (tui_display_data_from)
 123         (tui_data_window::do_scroll_vertical): Update.
 124         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 125         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 126         Rename from tui_line_from_reg_element_no.
 127         (tui_display_registers_from_line): Update.
 128         * tui/tui-data.h (struct tui_data_window)
 129         <line_from_reg_element_no>: New method.
 130
 131 2019-07-17  Tom Tromey  <tom@tromey.com>
 132
 133         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 134         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 135         tui_last_regs_line_no.
 136         (tui_display_reg_element_at_line)
 137         (tui_display_registers_from_line): Update.
 138         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 139         method.
 140
 141 2019-07-17  Tom Tromey  <tom@tromey.com>
 142
 143         PR tui/24722:
 144         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 145         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 146         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 147         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 148         (tui_update_breakpoint_info): Likewise.
 149         * tui/tui-hooks.c (tui_event_create_breakpoint)
 150         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 151         Update.
 152
 153 2019-07-17  Tom Tromey  <tom@tromey.com>
 154
 155         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 156
 157 2019-07-17  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-winsource.c (tui_update_source_window_as_is)
 160         (tui_update_source_windows_with_addr): Update.
 161         * tui/tui-source.h (tui_set_source_content)
 162         (tui_show_symtab_source): Add "win_info" parameter.
 163         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 164         parameter.
 165         (tui_show_symtab_source): Likewise.
 166
 167 2019-07-17  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-wingeneral.c
 170         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 171
 172 2019-07-17  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 175         (struct tui_cmd_window) <can_scroll>: New method.
 176         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 177         method.
 178
 179 2019-07-17  Tom Tromey  <tromey@adacore.com>
 180
 181         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 182         do_field_signed>: Rename.  Change type of "value".
 183         * ui-out.c (ui_out::field_signed): Rename from field_int.
 184         Change type of "value".
 185         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 186         type of "value".
 187         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 188         do_field_int.  Change type of "value".
 189         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 190         do_field_int.  Change type of "value".
 191         * tracepoint.c (trace_status_mi, tfind_1)
 192         (print_one_static_tracepoint_marker): Update.
 193         * thread.c (print_thread_info_1, print_selected_thread_frame):
 194         Update.
 195         * stack.c (print_frame, print_frame_info): Update.
 196         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 197         Update.
 198         * source.c (print_source_lines_base): Update.
 199         * skip.c (info_skip_command): Update.
 200         * record-btrace.c (btrace_ui_out_decode_error)
 201         (btrace_call_history_src_line): Update.
 202         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 203         Update.
 204         * progspace.c (print_program_space): Update.
 205         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 206         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 207         do_field_int.  Change type of "value".
 208         * mi/mi-out.c (mi_ui_out::do_table_begin)
 209         (mi_ui_out::do_table_header): Update.
 210         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 211         type of "value".
 212         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 213         (mi_cmd_data_list_changed_registers, output_register)
 214         (mi_cmd_data_read_memory, mi_load_progress)
 215         (mi_cmd_trace_frame_collected): Update.
 216         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 217         Update.
 218         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 219         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 220         (mi_cmd_var_list_children, varobj_update_one): Update.
 221         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 222         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 223         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 224         * inferior.c (print_inferior): Update.
 225         * gdb_bfd.c (print_one_bfd): Update.
 226         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 227         Update.
 228         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 229         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 230         do_field_int.  Change type of "value".
 231         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 232         do_field_int.  Change type of "value".
 233         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 234         (print_one_breakpoint_location, print_it_catch_fork)
 235         (print_one_catch_fork, print_it_catch_vfork)
 236         (print_one_catch_vfork, print_it_catch_solib)
 237         (print_it_catch_exec, print_it_ranged_breakpoint)
 238         (print_mention_watchpoint, print_mention_masked_watchpoint)
 239         (bkpt_print_it, update_static_tracepoint): Update.
 240         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 241         * break-catch-syscall.c (print_it_catch_syscall): Update.
 242         * ada-tasks.c (print_ada_task_info): Update.
 243         * ada-lang.c (print_it_exception, print_mention_exception):
 244         Update.
 245
 246 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 247
 248         PR breakpoints/24541
 249         * gdbarch.c: Regenerate.
 250         * gdbarch.h: Regenerate.
 251         * gdbarch.sh: Adjust return type and parameter types for
 252         'stap_adjust_register'.
 253         (i386_stap_adjust_register): Adjust signature and return new
 254         register name.
 255         * stap-probe.c (stap_parse_register_operand): Adjust use of
 256         'gdbarch_stap_adjust_register'.
 257
 258 2019-07-17  Tom Tromey  <tromey@adacore.com>
 259
 260         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 261         declare VEC.
 262         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 263         std::vector.
 264         (struct s390_process_info): Add initializers.
 265         (s390_add_process): Use new.
 266         (s390_linux_nat_target::low_forget_process): Use delete.
 267         (s390_linux_nat_target::low_new_fork)
 268         (s390_linux_nat_target::stopped_by_watchpoint)
 269         (s390_linux_nat_target::low_prepare_to_resume)
 270         (s390_linux_nat_target::insert_watchpoint)
 271         (s390_linux_nat_target::insert_hw_breakpoint)
 272         (s390_linux_nat_target::remove_watchpoint)
 273         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 274
 275 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 276
 277         * aarch64-fbsd-nat.c: Include regcache.h.
 278         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 279         argument.
 280         (aarch64_fbsd_nat_target::fetch_registers)
 281         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 282         variable.
 283         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 284
 285 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 286
 287         * fbsd-nat.c: Include gdbarch.h.
 288
 289 2019-07-15  Tom Tromey  <tromey@adacore.com>
 290
 291         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 292
 293 2019-07-15  Tom Tromey  <tromey@adacore.com>
 294
 295         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 296         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 297         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 298         * cli-out.c (cli_ui_out::do_field_int): New method.
 299         * ui-out.c (ui_out::field_unsigned): New method.
 300         * symfile.c (generic_load): Use field_unsigned.
 301         (print_transfer_performance): Likewise.
 302         * record-btrace.c (ui_out_field_uint): Remove.
 303         (btrace_call_history_insn_range, btrace_call_history): Use
 304         field_unsigned.
 305         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 306         field_unsigned.
 307         * ui-out.h (class ui_out) <field_unsigned>: New method.
 308         <do_field_unsigned>: Likewise.
 309
 310 2019-07-15  Tom Tromey  <tromey@adacore.com>
 311
 312         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 313         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 314         * target.c (flash_erase_command): Use field_string.
 315         * infrun.c (print_signal_received_reason): Use field_string.
 316         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 317         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 318         field_string.
 319         * ada-tasks.c (print_ada_task_info): Use field_string.
 320
 321 2019-07-15  Tom Tromey  <tromey@adacore.com>
 322
 323         * target.c (flash_erase_command): Use field_core_addr.
 324         * symfile.c (generic_load): Use field_core_addr.
 325         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 326         Use field_core_addr.
 327         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 328         field_core_addr.
 329
 330 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 333         value if its desired type is smaller than a CORE_ADDR and signed.
 334
 335 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 336
 337         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 338         of changes to field names, and use new is_reference field to
 339         decide if a property is a reference or not.
 340         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 341         field.
 342         (struct dwarf2_property_baton): Update header comment, rename
 343         'referenced_type' to 'property_type' and update comments.
 344         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 345         default property type, store in property baton, update to take
 346         accound of renamed field.
 347         (read_func_scope): Update call to attr_to_dynamic_prop.
 348         (read_array_type): Likewise.
 349         (dwarf2_per_cu_addr_sized_int_type): New function.
 350         (read_subrange_index_type): Move type finding code to
 351         dwarf2_per_cu_addr_sized_int_type.
 352         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 353         (dwarf2_per_cu_addr_type): New function.
 354         (set_die_type): Update calls to attr_to_dynamic_prop.
 355
 356 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 357
 358         * dwarf2read.c (read_subrange_index_type): New function.
 359         (read_subrange_type): Move code into new function and call it.
 360         * gdbtypes.c (create_range_type): Add some asserts.
 361
 362 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 363
 364         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 365         update return statements.
 366         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 367         declaration, and update comment to match.
 368         * gdbtypes.c (resolve_dynamic_array): Update call to
 369         dwarf2_evaluate_property to match new return type.
 370
 371 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 372
 373         * valarith.c (value_subscripted_rvalue): Change lowerbound
 374         parameter type from int to LONGEST.
 375         * value.h (value_subscripted_rvalue): Likewise in declaration.
 376
 377 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 378
 379         * cli/cli-utils.c (info_print_command_completer): New function.
 380         * cli/cli-utils.h: Add 'completer.h' include, and forward
 381         declaration for 'struct cmd_list_element'.
 382         (info_print_command_completer): Declare.
 383         * stack.c (_initialize_stack): Add completer for 'info locals' and
 384         'info args'.
 385         * symtab.c (_initialize_symtab): Add completer for 'info
 386         variables' and 'info functions'.
 387         * NEWS: Mention completion for additional info commands.
 388
 389 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 390
 391         * cli/cli-utils.c (extract_info_print_args): Delete.
 392         (extract_arg_maybe_quoted): Delete.
 393         (info_print_options_defs): New variable.
 394         (make_info_print_options_def_group): New function.
 395         (extract_info_print_options): Define new function.
 396         * cli/cli-utils.h (extract_info_print_args): Delete.
 397         (struct info_print_options): New structure.
 398         (extract_info_print_options): Declare new function.
 399         * stack.c (info_locals_command): Update to use new
 400         extract_info_print_options, also add a header comment.
 401         (info_args_command): Likewise.
 402         * symtab.c (info_variables_command): Likewise.
 403         (info_functions_command): Likewise.
 404
 405 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 406
 407         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 408         to extract string arguments.
 409         * common/common-utils.c (extract_string_maybe_quoted): New function.
 410         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 411
 412 2019-07-11  Tom Tromey  <tromey@adacore.com>
 413
 414         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 415         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 416         * top.h (gdbinit): Don't declare.
 417         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 418         into...
 419         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 420         * top.c (gdb_init): Don't call init_cli_cmds.
 421         (gdbinit): Remove.
 422         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 423
 424 2019-07-11  Tom Tromey  <tromey@adacore.com>
 425
 426         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 427         after it has been moved.
 428
 429 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 430
 431         * valops.c (value_must_coerce_to_target): Change return type to
 432         bool.
 433         * value.h (value_must_coerce_to_target): Likewise.
 434
 435 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 436
 437         * breakpoint.c (is_hardware_watchpoint): Remove
 438         forward-declaration.
 439         (is_masked_watchpoint): Change return type to bool.
 440         (is_tracepoint): Likewise.
 441         (is_breakpoint): Likewise.
 442         (is_hardware_watchpoint): Likewise.
 443         (is_watchpoint): Likewise.
 444         (is_no_memory_software_watchpoint): Likewise.
 445         (is_catchpoint): Likewise.
 446         (breakpoint_1): Make FILTER parameter's return type bool.
 447         is_masked_watchpoint): Change return type to bool.
 448         (save_breakpoints): Make FILTER parameter's return type bool.
 449         * breakpoint.h (is_breakpoint): Change return type to bool.
 450         (is_watchpoint): Likewise.
 451         (is_catchpoint): Likewise.
 452         (is_tracepoint): Likewise.
 453
 454 2019-07-10  Tom Tromey  <tom@tromey.com>
 455
 456         * defs.h: Don't include gdbarch.h.
 457         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 458         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 459         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 460         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 461         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 462         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 463         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 464         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 465         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 466         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 467         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 468         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 469         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 470         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 471         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 472         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 473         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 474         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 475         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 476         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 477         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 478         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 479         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 480         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 481         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 482         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 483         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 484
 485 2019-07-10  Tom Tromey  <tromey@adacore.com>
 486
 487         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 488         * breakpoint.c (init_ada_exception_breakpoint): Register as
 489         bp_catchpoint.
 490         (print_one_breakpoint_location, print_one_breakpoint): Use
 491         is_ada_exception_catchpoint.
 492         * ada-lang.c (class ada_catchpoint_location): Pass
 493         bp_loc_software_breakpoint to bp_location constructor.
 494         (is_ada_exception_catchpoint): New function.
 495
 496 2019-07-10  Tom Tromey  <tromey@adacore.com>
 497
 498         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 499         VEC.
 500         (struct arm_exidx_entry): New method operator<.
 501         (struct arm_exidx_data) <section_maps>: Change type.
 502         (arm_exidx_data_free): Remove.
 503         (arm_exidx_data_key): Change type.  Move lower.
 504         (arm_exidx_new_objfile): Update.
 505         (arm_compare_exidx_entries): Remove.
 506         (arm_find_exidx_entry, _initialize_arm_tdep)
 507
 508 2019-07-10  Tom Tromey  <tromey@adacore.com>
 509
 510         * solib-spu.c (ocl_program_data_key): Change type.
 511         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 512         Update.
 513
 514 2019-07-10  Tom Tromey  <tromey@adacore.com>
 515
 516         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 517         (struct solib_aix_inferior_data) <library_list>: Change type.
 518         (solib_aix_inferior_data_handle): Change type.
 519         (get_solib_aix_inferior_data): Update.
 520         (solib_aix_free_library_list): Remove.
 521         (library_list_start_library): Update.
 522         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 523         return type.
 524         (solib_aix_get_library_list)
 525         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 526         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 527
 528 2019-07-10  Tom Tromey  <tromey@adacore.com>
 529
 530         * solib-dsbt.c (struct dsbt_info): Add initializers.
 531         (solib_dsbt_pspace_data): Change type.
 532         (dsbt_pspace_data_cleanup): Remove.
 533         (get_dsbt_info, _initialize_dsbt_solib): Update.
 534
 535 2019-07-10  Tom Tromey  <tromey@adacore.com>
 536
 537         * spu-tdep.c (spu_overlay_data): Change type.
 538         (spu_get_overlay_table, spu_overlay_new_objfile)
 539         (_initialize_spu_tdep): Update.
 540
 541 2019-07-10  Tom Tromey  <tromey@adacore.com>
 542
 543         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 544         destructor.
 545         (dbx_objfile_data_key): Change type and declare later.
 546         (DBX_SYMFILE_INFO): Rewrite.
 547         * dbxread.c (dbx_objfile_data_key): Change type.
 548         (dbx_symfile_init): Update.
 549         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 550         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 551         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 552
 553 2019-07-10  Tom Tromey  <tromey@adacore.com>
 554
 555         * jit.c (jit_program_space_key): Change type.  Move lower.
 556         (get_jit_program_space_data): Update.
 557         (jit_program_space_data_cleanup): Remove.
 558         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 559         Update.
 560         (struct jit_program_space_data): Add initializers.
 561
 562 2019-07-10  Tom Tromey  <tromey@adacore.com>
 563
 564         * solib-darwin.c (struct darwin_info): Add initializers.
 565         (solib_darwin_pspace_data): Change type.
 566         (darwin_pspace_data_cleanup): Remove.
 567         (get_darwin_info, _initialize_darwin_solib): Update.
 568
 569 2019-07-10  Tom Tromey  <tromey@adacore.com>
 570
 571         * remote-sim.c (struct sim_inferior_data): Add initializers,
 572         constructor, and destructor.
 573         (sim_inferior_data_key): Change type.  Move lower.
 574         (check_for_duplicate_sim_descriptor): Update.
 575         (get_sim_inferior_data): Use new.  Update.
 576         (~sim_inferior_data_cleanup): Rename from
 577         sim_inferior_data_cleanup.  Simplify.
 578         (gdbsim_close_inferior, simulator_command)
 579         (sim_command_completer, _initialize_remote_sim): Update.
 580         (next_pid, INITIAL_PID): Move earlier.
 581
 582 2019-07-10  Tom Tromey  <tromey@adacore.com>
 583
 584         * python/python-internal.h (create_thread_object): Return
 585         gdbpy_ref.
 586         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 587         * python/py-inferior.c (struct threadlist_entry): Add
 588         constructor.
 589         <thread_obj>: Now a gdbpy_ref.
 590         (thread_to_thread_object): Update.
 591         (add_thread_object): Use new.
 592         (delete_thread_object): Use delete.
 593         (infpy_threads): Update.
 594         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 595         GIL.
 596
 597 2019-07-10  Tom Tromey  <tromey@adacore.com>
 598
 599         * valops.c (value_cast): Specialize error message for Ada.
 600
 601 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 602
 603         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 604
 605 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 606
 607         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 608         bpstat_should_step): Return bool, adjust comments.
 609         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 610         bpstat_should_step): Likewise.
 611
 612 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 613
 614         * features/Makefile: Use feature target descriptions for Arm.
 615         * features/arm/arm-core.c: Generate new file.
 616         * features/arm/arm-fpa.c: Likewise.
 617         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 618         * features/arm/arm-m-profile.c: Likewise.
 619         * features/arm/arm-vfpv2.c: Likewise.
 620         * features/arm/arm-vfpv3.c: Likewise.
 621         * features/arm/xscale-iwmmxt.c: Likewise.
 622         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 623
 624 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 625
 626         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 627         ptrace earlier.
 628
 629 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 630
 631         * features/aarch64-pauth.c: Regenerate.
 632
 633 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 634
 635         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 636         bool.
 637         (bpstat_what): Use false instead of 0.
 638
 639 2019-07-09  Pedro Alves  <palves@redhat.com>
 640
 641         * break-catch-throw.c (is_exception_catchpoint): New.
 642         * breakpoint.c (print_one_breakpoint_location): New parameter
 643         'raw_loc'.  Handle it.  Use
 644         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 645         looking at the breakpoint's type.
 646         (print_one_breakpoint): If handling "maint info breakpoints", also
 647         print locations of exception catchpoints.
 648         * breakpoint.h (is_exception_catchpoint): Declare.
 649
 650 2019-07-09  Pedro Alves  <palves@redhat.com>
 651
 652         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 653         "addr" field.
 654         (allocate_location_exception_catchpoint): New.
 655         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 656         (initialize_throw_catchpoint_ops): Install
 657         allocate_location_exception_catchpoint as allocate_location
 658         method.
 659         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 660         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 661         bp_loc_other.
 662         (breakpoint_address_is_meaningful): Delete.
 663         (bl_address_is_meaningful): New.
 664         (breakpoint_locations_match): Adjust comment.
 665         (bp_location_from_bp_type): New, factored out of...
 666         (bp_location::bp_location(breakpoint *)): ... this.
 667         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 668         factored out of...
 669         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 670         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 671         breakpoint_address_is_meaningful.
 672         (bp_locations_compare): Adjust comment.
 673         (update_global_location_list): Use bl_address_is_meaningful
 674         instead of breakpoint_address_is_meaningful.
 675         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 676         explicit.
 677         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 678         * python/py-breakpoint.c (bppy_get_location): No longer check
 679         whether location is null.
 680
 681 2019-07-09  Pedro Alves  <palves@redhat.com>
 682
 683         PR c++/15468
 684         * breakpoint.c (print_one_breakpoint_location): Remove
 685         single-location assert.
 686
 687 2019-07-09  Tom Tromey  <tom@tromey.com>
 688
 689         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 690         * configure: Rebuild.
 691         * configure.ac: Change common to gdbsupport.
 692         * gdbsupport: Rename from common.
 693         * acinclude.m4: Change common to gdbsupport.
 694         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 695         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 696         gdbsupport.
 697         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 698         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 699         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 700         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 701         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 702         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 703         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 704         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 705         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 706         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 707         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 708         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 709         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 710         coff-pe-read.c, command.h, compile/compile-c-support.c,
 711         compile/compile-c.h, compile/compile-cplus-symbols.c,
 712         compile/compile-cplus-types.c, compile/compile-cplus.h,
 713         compile/compile-loc2c.c, compile/compile.c, completer.c,
 714         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 715         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 716         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 717         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 718         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 719         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 720         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 721         features/aarch64-core.c, features/aarch64-fpu.c,
 722         features/aarch64-pauth.c, features/aarch64-sve.c,
 723         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 724         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 725         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 726         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 727         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 728         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 729         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 730         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 731         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 732         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 733         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 734         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 735         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 736         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 737         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 738         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 739         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 740         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 741         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 742         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 743         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 744         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 745         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 746         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 747         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 748         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 749         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 750         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 751         minsyms.c, mips-linux-tdep.c, namespace.h,
 752         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 753         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 754         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 755         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 756         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 757         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 758         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 759         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 760         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 761         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 762         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 763         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 764         procfs.c, producer.c, progspace.h, psymtab.h,
 765         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 766         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 767         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 768         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 769         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 770         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 771         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 772         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 773         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 774         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 775         target-memory.c, target.c, target.h, target/waitstatus.c,
 776         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 777         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 778         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 779         unittests/array-view-selftests.c,
 780         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 781         unittests/common-utils-selftests.c,
 782         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 783         unittests/format_pieces-selftests.c,
 784         unittests/function-view-selftests.c,
 785         unittests/lookup_name_info-selftests.c,
 786         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 787         unittests/mkdir-recursive-selftests.c,
 788         unittests/observable-selftests.c,
 789         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 790         unittests/parse-connection-spec-selftests.c,
 791         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 792         unittests/scoped_fd-selftests.c,
 793         unittests/scoped_mmap-selftests.c,
 794         unittests/scoped_restore-selftests.c,
 795         unittests/string_view-selftests.c, unittests/style-selftests.c,
 796         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 797         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 798         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 799         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 800         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 801         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 802
 803 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 806         bool value.
 807         (decode_digits_ordinary): Set explicit_line field in sal.
 808         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 809         symtab_and_line that was set on an explicit line number in
 810         assembler code.  Do always update the recorded symtab and line if
 811         we do skip the prologue.
 812
 813 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 814
 815         * breakpoint.c (set_breakpoint_location_function): Remove
 816         explicit_loc parameter.
 817         (momentary_breakpoint_from_master): Update call to
 818         set_breakpoint_location_function.
 819         (add_location_to_breakpoint): Likewise.
 820
 821 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 822
 823         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 824         required features based on default bfd type when no specific bfd
 825         is present.
 826
 827 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 828
 829         * NEWS: Mention that GDB printf and eval commands can now print
 830         C-style and Ada-style convenience var strings without
 831         calling the inferior.
 832         * printcmd.c (printf_c_string): Locally print GDB internal var
 833         instead of transiting via the inferior.
 834         (printf_wide_c_string): Likewise.
 835
 836 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 837
 838         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 839
 840 2019-07-04  Tom Tromey  <tom@tromey.com>
 841
 842         PR tui/24724:
 843         * tui/tui-winsource.c (tui_clear_source_content): Update.
 844         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 845         (tui_update_breakpoint_info): Update.
 846         (tui_set_exec_info_content): Update.
 847         * tui/tui-source.c (tui_set_source_content_nil): Update.
 848         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 849         has_break.
 850         * tui/tui-data.h (enum tui_bp_flag): New.
 851         (tui_bp_flags): New enum flags type.
 852         (struct tui_source_element) <break_mode>: Change type.  Rename
 853         from has_break.
 854         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 855         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 856         constants.
 857         * tui/tui-winsource.h: Fix comment.
 858
 859 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 860
 861         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 862         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 863         (store_fpregs_to_thread)
 864         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 865         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 866         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 867         (IWMMXT_REGS_SIZE): Add define.
 868         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 869         (fetch_vfp_regs, store_vfp_regs)
 870         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 871         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 872
 873 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 874
 875         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 876         defines.
 877         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 878         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 879         (ARM_INT_REGISTER_SIZE): ...to this.
 880         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 881         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 882         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 883         (arm_linux_collect_gregset, supply_nwfpe_register)
 884         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 885         defines.
 886         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 887         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 888         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 889         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 890         (arm_return_in_memory, arm_store_return_value)
 891         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 892         (arm_record_ld_st_multiple): Likewise.
 893         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 894         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 895
 896 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 897
 898         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 899         AARCH64_DISPLACED_MODIFIED_INSNS.
 900         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 901         (aarch64_displaced_step_copy_insn): Likewise.
 902         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 903         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 904         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 905         ARM_DISPLACED_MODIFIED_INSNS.
 906         * arm-tdep.c (arm_gdbarch_init): Likewise.
 907         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 908         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 909         (struct arm_displaced_step_closure): Use
 910         ARM_DISPLACED_MODIFIED_INSNS.
 911
 912 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 913
 914         * features/Makefile: Remove unused xml files.
 915         * features/aarch64.xml: Remove.
 916         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 917         * features/i386/amd64-avx-avx512.xml: Remove.
 918         * features/i386/amd64-avx-linux.xml: Remove.
 919         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 920         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 921         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 922         * features/i386/amd64-avx-mpx.xml: Remove.
 923         * features/i386/amd64-avx.xml: Remove.
 924         * features/i386/amd64-linux.xml: Remove.
 925         * features/i386/amd64-mpx-linux.xml: Remove.
 926         * features/i386/amd64-mpx.xml: Remove.
 927         * features/i386/amd64.xml: Remove.
 928         * features/i386/i386-avx-avx512-linux.xml: Remove.
 929         * features/i386/i386-avx-avx512.xml: Remove.
 930         * features/i386/i386-avx-linux.xml: Remove.
 931         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 932         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 933         * features/i386/i386-avx-mpx-linux.xml: Remove.
 934         * features/i386/i386-avx-mpx.xml: Remove.
 935         * features/i386/i386-avx.xml: Remove.
 936         * features/i386/i386-linux.xml: Remove.
 937         * features/i386/i386-mmx-linux.xml: Remove.
 938         * features/i386/i386-mmx.xml: Remove.
 939         * features/i386/i386-mpx-linux.xml: Remove.
 940         * features/i386/i386-mpx.xml: Remove.
 941         * features/i386/i386.xml: Remove.
 942         * features/i386/x32-avx-avx512-linux.xml: Remove.
 943         * features/i386/x32-avx-linux.xml: Remove.
 944         * features/i386/x32-linux.xml: Remove.
 945
 946 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 947
 948         * regformats/aarch64.dat: Remove.
 949         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 950         * regformats/i386/amd64-avx-linux.dat: Remove.
 951         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 952         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 953         * regformats/i386/amd64-linux.dat: Remove.
 954         * regformats/i386/amd64-mpx-linux.dat: Remove.
 955         * regformats/i386/amd64.dat: Remove.
 956         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 957         * regformats/i386/i386-avx-linux.dat: Remove.
 958         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 959         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 960         * regformats/i386/i386-linux.dat: Remove.
 961         * regformats/i386/i386-mmx-linux.dat: Remove.
 962         * regformats/i386/i386-mpx-linux.dat: Remove.
 963         * regformats/i386/i386.dat: Remove.
 964         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 965         * regformats/i386/x32-avx-linux.dat: Remove.
 966         * regformats/i386/x32-linux.dat: Remove.
 967
 968 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 969
 970         * aarch64-tdep.c: Remove xml self tests.
 971         * amd64-linux-tdep.c: Likewise.
 972         * amd64-tdep.c: Likewise.
 973         * i386-linux-tdep.c: Likewise.
 974         * i386-tdep.c: Likewise.
 975
 976 2019-07-03  Pedro Alves  <palves@redhat.com>
 977
 978         PR cli/24732
 979         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 980         (pipe_cmd_option_defs): New.
 981         (make_pipe_cmd_options_def_group): New.
 982         (pipe_command): Use gdb::option::process_options.
 983         (pipe_command_completer): New function.
 984         (_initialize_cli_cmds): Install completer for "pipe" command.
 985
 986 2019-07-03  Pedro Alves  <palves@redhat.com>
 987
 988         * cli/cli-option.c (union option_value) <string>: New field.
 989         (struct option_def_and_value): Add ctor, move ctor, dtor and
 990         use DISABLE_COPY_AND_ASSIGN.
 991         (option_def_and_value::clear_value): New.
 992         (parse_option, save_option_value_in_ctx, get_val_type_str)
 993         (add_setshow_cmds_for_options): Handle var_string.
 994         * cli-option.h (union option_def::var_address) <string>: New
 995         field.
 996         (struct string_option_def): New.
 997         * maint-test-options.c (struct test_options_opts): Add default
 998         ctor and use DISABLE_COPY_AND_ASSIGN.
 999         <string_opt>: New field.
1000         (test_options_opts::~test_options_opts): New.
1001         (test_options_opts::dump): Also dump "-string".
1002         (test_options_option_defs): Install "string.
1003
1004 2019-07-03  Pedro Alves  <palves@redhat.com>
1005
1006         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1007         option_value with a null enumeration.
1008         (complete_options): Save the option values in the context.
1009         (save_option_value_in_ctx): New, factored out from ...
1010         (process_options): ... here.
1011         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1012         of the function.
1013         * maint-test-options.c (test_options_opts::dump): New, factored
1014         out from ...
1015         (maintenance_test_options_command_mode): ... here.
1016         (maintenance_test_options_command_completion_result): Delete.
1017         (maintenance_test_options_command_completion_text): Update
1018         comment.
1019         (maintenance_show_test_options_completion_result): Change
1020         prototype.  Just print
1021         maintenance_test_options_command_completion_text.
1022         (save_completion_result): New.
1023         (maintenance_test_options_completer_mode): Pass options context to
1024         complete_options, and then save a dump.
1025         (_initialize_maint_test_options): Use add_cmd to install "maint
1026         show test-options-completion-result".
1027
1028 2019-07-03  Pedro Alves  <palves@redhat.com>
1029
1030         * NEWS (New commands): Mention "with" and "maint with".
1031         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1032         (with_command, with_command_completer): New.
1033         (pipe_command): Adjust to new repeat_previous
1034         interface.
1035         (_initialize_cli_cmds): Install the "with" command and its "w"
1036         alias.
1037         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1038         declarations.
1039         * cli/cli-setshow.c (parse_cli_var_uinteger)
1040         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1041         argument strings for all var_types.
1042         (get_setshow_command_value_string): New, factored out from ...
1043         (do_show_command): ... this.
1044         * cli/cli-setshow.h: Include <string>.
1045         (get_setshow_command_value_string): Declare.
1046         * command.h (repeat_previous): Now returns const char *.  Adjust
1047         comment.
1048         * maint.c: Include "cli/cli-cmds.h".
1049         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1050         (_initialize_maint_cmds): Register the "maintenance with" command.
1051         * top.c (repeat_previous): Move bits from pipe_command here:
1052         Return the saved command line, if any; error out if there's no
1053         command to relaunch.
1054
1055 2019-07-03  Pedro Alves  <palves@redhat.com>
1056
1057         * NEWS (New commands): Mention "maint set/show test-settings"
1058         instead of "maint test-settings".
1059         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1060         (maintenance_test_settings_set_list): Rename to ...
1061         (maintenance_set_test_settings_list): ... this.
1062         (maintenance_test_settings_show_list): Rename to  ...
1063         (maintenance_show_test_settings_list): ... this.
1064         (maintenance_test_settings_cmd): Delete.
1065         (maintenance_test_settings_set_cmd): ...
1066         (maintenance_set_test_settings_cmd): ... this.
1067         (maintenance_test_settings_show_cmd): ...
1068         (maintenance_show_test_settings_cmd): ... this.
1069         (maintenance_test_settings_show_value_cmd):
1070         (maintenance_show_test_settings_value_cmd): ... this.
1071         (_initialize_maint_test_settings): No longer install the "maint
1072         test-settings" prefix command.  Rename "maint test-settings set"
1073         to "maint set test-settings", and "maint test-settings show" to
1074         "maint show test-settings".  Adjust all subcommands.
1075
1076 2019-07-03  Pedro Alves  <palves@redhat.com>
1077
1078         * maint-test-settings.c: Fix file's intro comment.  Replace all
1079         references to "test-options" with references to "test-settings",
1080         in comments.
1081
1082 2019-07-03  Pedro Alves  <palves@redhat.com>
1083
1084         * maint-test-settings.c (maintenance_test_settings_xxx)
1085         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1086         New.
1087         (maintenance_test_settings_enums): Use them.
1088         (maintenance_test_settings_enum): Default to
1089         maintenance_test_settings_xxx.
1090         (_initialize_maint_test_settings): Initialize
1091         MAINTENANCE_TEST_SETTINGS_FILENAME.
1092
1093 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1094
1095         * breakpoint.h (remove_breakpoints_inf): Change return type to
1096         void, move function documentation here.
1097         * breakpoint.c (remove_breakpoints_inf): Change return type to
1098         void, move function documentation to header.
1099
1100 2019-07-02  Pedro Alves  <palves@redhat.com>
1101
1102         * NEWS (Completion improvements): Mention "info threads".
1103         * thread.c (struct info_threads_opts, info_threads_option_defs)
1104         (make_info_threads_options_def_group): New.
1105         (info_threads_command): Use gdb::option::process_options.
1106         (info_threads_command_completer): New.
1107         (_initialize_thread): Use gdb::option::build_help to build the
1108         help text for "info threads".
1109
1110 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1111
1112         * defs.h (generic_load): Move from here...
1113         * symfile.h (generic_load): ... to here.  Rename name parameter
1114         to args.
1115         * symfile.c (generic_load): Add comment.
1116
1117 2019-07-01  Tom Tromey  <tromey@adacore.com>
1118
1119         * dwarf2read.c
1120         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1121         declaration of without_params.  Fix formatting.
1122
1123 2019-07-01  Tom Tromey  <tromey@adacore.com>
1124
1125         * ada-exp.y (find_primitive_type): Update.
1126         * ada-lang.h (ada_lookup_symbol): Update.
1127         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1128         parameter.
1129         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1130
1131 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1132
1133         PR breakpoints/24541
1134         * gdbarch.c: Regenerate.
1135         * gdbarch.h: Regenerate.
1136         * gdbarch.sh: Add 'stap_adjust_register'.
1137         * i386-tdep.c: Include '<unordered_set>'.
1138         (i386_stap_adjust_register): New function.
1139         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1140         * stap-probe.c (stap_parse_register_operand): Call
1141         'gdbarch_stap_adjust_register'.
1142
1143 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1144
1145         PR python/24742
1146         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1147         * python/python.c (do_start_initialization): Use 'xmalloc'
1148         instead of 'PyMem_Malloc'.
1149
1150 2019-06-28  Tom Tromey  <tromey@adacore.com>
1151
1152         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1153         for Ada.
1154
1155 2019-06-27  Tom Tromey  <tromey@adacore.com>
1156
1157         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1158         objfile_key.
1159         (arm_find_mapping_symbol, arm_record_special_symbol)
1160         (_initialize_arm_tdep): Update.
1161         (arm_objfile_data_free): Remove.
1162
1163 2019-06-27  Tom Tromey  <tromey@adacore.com>
1164
1165         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1166         to cp_print_static_field.
1167
1168 2019-06-26  Tom Tromey  <tromey@adacore.com>
1169
1170         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1171         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1172         declare.
1173
1174 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1175
1176         * features/aarch64-core.c (create_feature_aarch64_core):
1177         Regenerate.
1178         * features/aarch64-core.xml: Add cpsr flags.
1179
1180 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1181
1182         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1183         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1184
1185 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1186
1187         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1188         field.
1189         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1190         use.
1191         (arm_record_special_symbol): Don't insert new symbol in sorted
1192         position, push it at the end.
1193
1194 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1195
1196         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1197         (arm_mapping_symbol_s): Remove.
1198         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1199         (arm_mapping_symbol_vec): New typedef.
1200         (struct arm_per_objfile): Add constructor.
1201         <section_maps>: Change type to
1202         std::unique_ptr<arm_mapping_symbol_vec[]>.
1203         (arm_compare_mapping_symbols): Remove.
1204         (arm_find_mapping_symbol): Adjust to section_maps type change.
1205         (arm_objfile_data_free): Call delete on arm_per_objfile.
1206         (arm_record_special_symbol): Adjust to section_maps type change.
1207         Allocate arm_per_objfile with new.
1208
1209 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1210
1211         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1212         with the command prefix.
1213
1214 2019-06-25  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1217         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1218
1219 2019-06-25  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1222         type.
1223         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1224         protected.
1225
1226 2019-06-25  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-winsource.c
1229         (tui_source_window_base::set_is_exec_point_at): Add check against
1230         LOA_ADDRESS.
1231
1232 2019-06-25  Tom Tromey  <tom@tromey.com>
1233
1234         * tui/tui-source.c (tui_set_source_content): Don't check before
1235         xfree.
1236         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1237
1238 2019-06-25  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-winsource.h (tui_update_source_window_as_is)
1241         (tui_alloc_source_buffer, tui_line_is_displayed)
1242         (tui_addr_is_displayed): Change type of win_info.
1243         * tui/tui-winsource.c (tui_update_source_window_as_is)
1244         (tui_clear_source_content, tui_show_source_line)
1245         (tui_show_source_content, tui_source_window_base::refill)
1246         (tui_source_window_base::set_is_exec_point_at)
1247         (tui_source_window_base::set_is_exec_point_at)
1248         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1249         (tui_alloc_source_buffer, tui_line_is_displayed)
1250         (tui_addr_is_displayed): Change type of win_info.  Update.
1251         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1252         (tui_source_window_base::do_make_visible_with_new_height):
1253         Update.
1254         * tui/tui-source.c (tui_set_source_content)
1255         (tui_set_source_content_nil)
1256         (tui_source_window::do_scroll_vertical): Update.
1257         * tui/tui-layout.c (show_layout): Update.
1258         * tui/tui-disasm.c (tui_set_disassem_content)
1259         (tui_disasm_window::do_scroll_vertical): Update.
1260         * tui/tui-data.h (tui_win_content): Remove.
1261         (struct tui_gen_win_info) <content, content_size>: Remove.
1262         (struct tui_source_element): Add initializers and destructor.
1263         (union tui_which_element, struct tui_win_element): Remove.
1264         (struct tui_source_window_base) <content>: New field.
1265         (struct tui_data_window): Remove destructor.
1266         (tui_alloc_content, tui_free_win_content)
1267         (tui_free_all_source_wins_content): Don't declare.
1268         * tui/tui-data.c (tui_initialize_static_data): Update.
1269         (init_content_element, tui_alloc_content): Remove.
1270         (~tui_gen_win_info): Update.
1271         (~tui_data_window, tui_free_all_source_wins_content)
1272         (tui_free_win_content, free_content, free_content_elements):
1273         Remove.
1274
1275 2019-06-25  Tom Tromey  <tom@tromey.com>
1276
1277         * tui/tui-winsource.h (tui_clear_source_content)
1278         (tui_erase_source_content, tui_show_source_content): Change type
1279         of win_info.
1280         * tui/tui-winsource.c (tui_clear_source_content)
1281         (tui_erase_source_content, tui_show_source_content): Change type
1282         of win_info.
1283         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1284         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1285         win_info.
1286         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1287         win_info.
1288         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1289
1290 2019-06-25  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-winsource.c (tui_clear_source_content)
1293         (tui_source_window_base::set_is_exec_point_at): Update.
1294         * tui/tui-source.c (tui_set_source_content_nil): Update.
1295         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1296         a bool.
1297         * tui/tui-data.c (init_content_element): Update.
1298
1299 2019-06-25  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1302         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1303         * tui/tui-layout.c (init_and_make_win): Update.
1304         * tui/tui.h (enum tui_win_type): Update.
1305         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1306         tui_win_is_auxillary.
1307         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1308         tui_win_is_auxillary.
1309
1310 2019-06-25  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1313         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1314         (tui_delete_data_content_windows, tui_display_all_data)
1315         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1316         Update.
1317         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1318         * tui/tui-regs.c (tui_last_regs_line_no)
1319         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1320         (tui_show_registers): Update.
1321         (tui_show_register_group): Return void.  Update.
1322         (tui_display_registers_from, tui_display_reg_element_at_line)
1323         (tui_display_registers_from_line, tui_check_register_values):
1324         Update.
1325         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1326         member.
1327         (struct tui_data_window) <regs_content>: Now a std::vector.
1328         <regs_content_count>: Remove.
1329         (tui_add_content_elements, tui_free_data_content): Don't declare.
1330         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1331         (init_content_element): Remove DATA_WIN case.  Add assert.
1332         (tui_add_content_elements): Remove.
1333         (tui_data_window): Update.
1334         (tui_free_data_content): Remove.
1335         (free_content_elements): Remove DATA_WIN case.
1336
1337 2019-06-25  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-data.c (tui_data_item_window): Update.
1340         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1341         * tui/tui-windata.c (tui_display_all_data)
1342         (tui_display_data_from_line): Update.
1343         (tui_check_data_values): Remove.
1344         * tui/tui-regs.c (tui_show_register_group)
1345         (tui_display_reg_element_at_line): Update.
1346         * tui/tui-hooks.c (tui_register_changed)
1347         (tui_refresh_frame_and_register_information): Call
1348         tui_check_register_values.
1349         * tui/tui-data.h (struct tui_data_window) <data_content,
1350         data_content_count, data_type>: Remove.
1351         (enum tui_data_type): Remove.
1352
1353         * tui/tui-data.c (tui_data_window::clear_detail)
1354         (~tui_data_window): Update.
1355
1356 2019-06-25  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1359         declare.
1360         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1361         Rename from tui_first_data_item_displayed.  Update.
1362         (tui_data_window::refresh_all)
1363         (tui_data_window::do_scroll_vertical): Update.
1364         * tui/tui-data.h (struct tui_data_window)
1365         <first_data_item_displayed>: Declare new method.
1366
1367 2019-06-25  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1370         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1371         contents...
1372         (tui_initialize_static_data): ...here.
1373
1374 2019-06-25  Tom Tromey  <tom@tromey.com>
1375
1376         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1377         (tui_display_registers_from, tui_check_register_values): Update.
1378         (tui_display_register): Remove win_info parameter; update.
1379         (tui_get_register): Change type of parameters.
1380         * tui/tui-data.h (struct tui_data_element): Remove.
1381         (union tui_which_element) <data>: Remove.
1382         <data_window>: Change type.
1383         (struct tui_data_item_window): New.
1384         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1385         case.  Add assert.
1386         (~tui_data_item_window): New destructor.
1387         (free_content_elements): Remove DATA_ITEM_WIN case.
1388
1389 2019-06-25  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1392         Remove.
1393
1394 2019-06-25  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-data.h (struct tui_command_element): Remove.
1397         (union tui_which_element) <command>: Remove.
1398         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1399         assert.
1400         (free_content_elements): Remove CMD_WIN case.
1401
1402 2019-06-25  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-layout.c (tui_set_layout): Update.
1405         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1406         * tui/tui-data.c (layout_def): Update.
1407
1408 2019-06-25  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1411         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1412         (tui_source_window_base::set_new_height): Update.
1413         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1414         Update.
1415         (tui_set_locator_fullname, tui_set_locator_info)
1416         (tui_show_frame_info): Update.
1417         * tui/tui-source.c (tui_set_source_content)
1418         (tui_source_is_displayed): Update.
1419         * tui/tui-layout.c (show_source_disasm_command, show_data)
1420         (show_source_or_disasm_and_command): Update.
1421         * tui/tui-disasm.c (tui_set_disassem_content)
1422         (tui_get_begin_asm_address): Update.
1423         * tui/tui-data.h (struct tui_locator_element): Remove.
1424         (union tui_which_element) <locator>: Remove.
1425         (struct tui_locator_window): New.
1426         (tui_locator_win_info_ptr): Change return type.
1427         * tui/tui-data.c (_locator): Change type.
1428         (tui_locator_win_info_ptr): Change return type.
1429         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1430         (tui_alloc_content): Add assert.
1431
1432 2019-06-25  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-winsource.c
1435         (tui_exec_info_window::maybe_allocate_content): New method.
1436         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1437         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1438         (make_source_or_disasm_window): Add cast.
1439         * tui/tui-data.h (union tui_which_element) <simple_string>:
1440         Remove.
1441         (struct tui_source_info): New.
1442         (struct tui_source_window_base) <execution_info>: Change type.
1443         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1444         case, and add assert.
1445         (tui_alloc_content): Add assert.
1446
1447 2019-06-25  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1450         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1451         * tui/tui-data.c (tui_alloc_win_info): Remove.
1452
1453 2019-06-25  Tom Tromey  <tom@tromey.com>
1454
1455         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1456         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1457         can_highlight.
1458
1459 2019-06-25  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1462         make_visible_with_new_height method.
1463         (tui_win_info::make_visible_with_new_height): New method.
1464         (tui_source_window_base::do_make_visible_with_new_height)
1465         (tui_data_window::do_make_visible_with_new_height)
1466         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1467         (make_visible_with_new_height): Remove.
1468         (tui_resize_all, tui_adjust_win_heights): Use
1469         make_visible_with_new_height method.
1470         * tui/tui-data.h (struct tui_win_info)
1471         <do_make_visible_with_new_height, make_visible_with_new_height>:
1472         New methods.
1473         (struct tui_source_window_base, struct tui_data_window)
1474         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1475         methods.
1476
1477 2019-06-25  Tom Tromey  <tom@tromey.com>
1478
1479         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1480         method.
1481         (update_tab_width): Call update_tab_width method.
1482         * tui/tui-data.h (struct tui_win_info)
1483         (struct tui_source_window_base) <update_tab_width>: New methods.
1484
1485 2019-06-25  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1488         parameter.
1489         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1490         parameter.
1491         (tui_gen_win_info::make_visible): Update.
1492         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1493         parameter.
1494         * tui/tui-data.h (enum tui_box): New enum.
1495         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1496
1497 2019-06-25  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1500         init_and_make_win for EXEC_INFO_WIN.
1501         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1502         longer inline.
1503         (struct tui_win_info) <~tui_win_info>: Inline.
1504         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1505         Don't declare.
1506         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1507         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1508         Remove.
1509         (tui_initialize_static_data): Update.
1510         (~tui_gen_win_info): Handle more cleanup here.
1511         (~tui_source_window_base): Delete "execution_info".
1512         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1513
1514 2019-06-25  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-layout.c (make_command_window): Don't set
1517         can_highlight.
1518         (show_source_disasm_command): Call the reset method.
1519         (show_data): Don't set can_highlight.  Call the reset method.
1520         (tui_gen_win_info::reset): Rename from init_gen_win_info
1521         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1522         (show_source_or_disasm_and_command): Call the reset method.
1523         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1524         (struct tui_cmd_window): Set can_highlight.
1525
1526 2019-06-25  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1529         from make_visible.
1530         (tui_make_visible, tui_make_invisible): Rewrite.
1531         (tui_win_info::make_visible): Remove.
1532         (tui_source_window_base::make_visible): Update.
1533         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1534         method.  Moved from...
1535         (struct tui_win_info) <make_visible>: ...here.
1536
1537 2019-06-25  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-winsource.c
1540         (tui_source_window_base::do_scroll_horizontal): Remove direction
1541         parameter.
1542         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1543         direction parameter.
1544         * tui/tui-win.c (tui_win_info::forward_scroll)
1545         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1546         (tui_win_info::right_scroll): Update.
1547         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1548         direction parameter.
1549         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1550         direction parameter.
1551         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1552         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1553         Remove direction parameter.
1554         (struct tui_source_window_base, struct tui_source_window)
1555         (struct tui_disasm_window, struct tui_data_window)
1556         (struct tui_cmd_window): Update.
1557
1558 2019-06-25  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-winsource.h (tui_set_exec_info_content)
1561         (tui_show_exec_info_content, tui_erase_exec_info_content)
1562         (tui_clear_exec_info_content, tui_update_exec_info): Change
1563         argument to tui_source_window_base.
1564         * tui/tui-winsource.c (tui_set_exec_info_content)
1565         (tui_show_exec_info_content, tui_erase_exec_info_content)
1566         (tui_clear_exec_info_content, tui_update_exec_info): Change
1567         argument to tui_source_window_base.
1568
1569 2019-06-25  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1572         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1573
1574 2019-06-25  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1577         check.
1578
1579 2019-06-25  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1582         type to void.
1583         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1584         type to void.
1585         * tui/tui-source.c (tui_set_source_content): Update.
1586         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1587
1588 2019-06-25  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-win.c (window_name_completer, tui_set_focus)
1591         (tui_all_windows_info): Use name method.
1592         * tui/tui-data.h (struct tui_gen_win_info)
1593         (struct tui_source_window, struct tui_disasm_window)
1594         (struct tui_data_window, struct tui_cmd_window) <name>: New
1595         method.
1596         (tui_win_name): Don't declare.
1597         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1598         (tui_win_name): Remove.
1599
1600 2019-06-25  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-winsource.h (tui_update_source_window)
1603         (tui_update_source_window_as_is): Change parameter type.
1604         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1605         to be a tui_source_window_base.
1606         (tui_update_source_window_as_is): Likewise.
1607         * tui/tui-win.c (make_visible_with_new_height): Update.
1608
1609 2019-06-25  Tom Tromey  <tom@tromey.com>
1610
1611         * tui/tui-winsource.c (tui_erase_source_content)
1612         (tui_show_source_content, tui_show_exec_info_content)
1613         (tui_erase_exec_info_content): Use refresh_window method.
1614         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1615         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1616         from tui_refresh_win.
1617         (tui_data_window::refresh_window): New method.
1618         (tui_win_info::refresh, tui_source_window_base::refresh)
1619         (tui_refresh_all): Use refresh_window method.
1620         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1621         method.
1622         * tui/tui-regs.c (tui_display_register): Call refresh_window
1623         method.
1624         * tui/tui-layout.c (show_source_disasm_command)
1625         (show_source_or_disasm_and_command): Call refresh_window method.
1626         * tui/tui-data.h (struct tui_gen_win_info)
1627         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1628         New method.
1629
1630 2019-06-25  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui.c (tui_rl_other_window, tui_enable)
1633         (tui_is_window_visible, tui_get_command_dimension): Update.
1634         * tui/tui-winsource.c (tui_update_source_window_as_is)
1635         (tui_clear_source_content, tui_erase_source_content)
1636         (tui_show_source_line, tui_source_window_base::refill)
1637         (tui_source_window_base::do_scroll_horizontal)
1638         (tui_source_window_base::set_is_exec_point_at)
1639         (tui_update_breakpoint_info, tui_set_exec_info_content)
1640         (tui_alloc_source_buffer, tui_line_is_displayed)
1641         (tui_addr_is_displayed): Update.
1642         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1643         (tui_check_and_display_highlight_if_needed)
1644         (tui_win_info::make_visible, tui_win_info::refresh)
1645         (tui_refresh_all): Update.
1646         * tui/tui-windata.c (tui_first_data_item_displayed)
1647         (tui_delete_data_content_windows, tui_erase_data_content)
1648         (tui_display_all_data, tui_data_window::refresh_all)
1649         (tui_check_data_values): Update.
1650         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1651         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1652         (tui_win_info::backward_scroll, tui_refresh_all_win)
1653         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1654         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1655         (tui_source_window_base::set_new_height)
1656         (tui_data_window::set_new_height)
1657         (make_invisible_and_set_new_height)
1658         (make_visible_with_new_height, new_height_ok)
1659         (parse_scrolling_args): Update.
1660         * tui/tui-stack.c (tui_show_frame_info): Update.
1661         * tui/tui-source.c (tui_set_source_content)
1662         (tui_set_source_content_nil, tui_source_is_displayed)
1663         (tui_source_window::do_scroll_vertical): Update.
1664         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1665         (tui_display_registers_from, tui_display_reg_element_at_line)
1666         (tui_check_register_values, tui_reg_command): Update.
1667         * tui/tui-layout.c (tui_default_win_height)
1668         (show_source_disasm_command, show_data, init_and_make_win)
1669         (show_source_or_disasm_and_command): Update.
1670         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1671         (tui_redisplay_readline, tui_mld_flush)
1672         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1673         (tui_getc): Update.
1674         * tui/tui-disasm.c (tui_set_disassem_content)
1675         (tui_disasm_window::do_scroll_vertical): Update.
1676         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1677         Now virtual.
1678         (struct tui_win_info): Derive from tui_gen_win_info.
1679         <~tui_win_info>: Mark as override.
1680         <generic>: Remove member.
1681         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1682         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1683         (~tui_data_window, ~tui_win_info)
1684         (tui_free_all_source_wins_content): Update.
1685         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1686
1687 2019-06-25  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-layout.c (init_and_make_win): Use new.
1690         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1691         destructor, initializers.
1692         (tui_alloc_generic_win_info): Don't declare.
1693         * tui/tui-data.c (_locator): Add argument to constructor.
1694         (source_win, disasm_win): New globals.
1695         (exec_info): Remove.
1696         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1697         Update.
1698         (tui_alloc_generic_win_info): Remove.
1699         (init_content_element): Use new.
1700         (tui_win_info::tui_win_info): Update.
1701         (free_content_elements) <case DATA_WIN>: Use delete.
1702
1703 2019-06-25  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1706         * tui/tui-windata.c (tui_first_data_item_displayed)
1707         (tui_delete_data_content_windows): Update.
1708         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1709         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1710         (tui_display_registers_from, tui_check_register_values): Update.
1711         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1712         pointer.
1713         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1714         window.
1715         (tui_free_data_content): Update.
1716         (free_content_elements) <case DATA_WIN>: Free the window.
1717
1718 2019-06-25  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1721         Update.
1722         * tui/tui-layout.c (make_command_window)
1723         (show_source_disasm_command, show_data, init_and_make_win)
1724         (show_source_or_disasm_and_command): Update.
1725         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1726         method.
1727         <can_highight, is_highlighted>: Now bool.
1728         (tui_set_win_highlight): Don't declare.
1729         * tui/tui-data.c (tui_set_win_highlight): Remove.
1730
1731 2019-06-25  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-wingeneral.c (make_visible): Remove check of window
1734         type.
1735
1736 2019-06-25  Tom Tromey  <tom@tromey.com>
1737
1738         * tui/tui-win.c (tui_win_info::max_height)
1739         (tui_cmd_window::max_height): New methods.
1740         (new_height_ok): Call max_height.
1741         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1742         <max_height>: New method.
1743
1744 2019-06-25  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-win.c (tui_source_window_base::set_new_height)
1747         (tui_data_window::set_new_height): New methods.
1748         (make_invisible_and_set_new_height): Call set_new_height method.
1749         * tui/tui-data.h (struct tui_win_info)
1750         (struct tui_source_window_base, struct tui_data_window)
1751         <set_new_height>: New method.
1752
1753 2019-06-25  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1756         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1757         tui_refresh_data_win.
1758         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1759         method.
1760         (tui_refresh_all_win): Call the refresh_all method.
1761         (tui_set_focus): Likewise.
1762         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1763         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1764         Likewise.
1765
1766 2019-06-25  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-winsource.h (tui_refill_source_window)
1769         (tui_set_is_exec_point_at): Don't declare.
1770         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1771         (tui_source_window_base::refill): Rename from
1772         tui_refill_source_window.
1773         (tui_source_window_base::do_scroll_horizontal): Update.
1774         (tui_source_window_base::set_is_exec_point_at): Rename from
1775         tui_set_is_exec_point_at.
1776         (tui_update_all_breakpoint_info): Update.
1777         * tui/tui-stack.c (tui_show_frame_info): Update.
1778         * tui/tui-layout.c (show_data): Add cast.
1779         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1780         * tui/tui-data.h (struct tui_source_window_base) <refill,
1781         set_is_exec_point_at>: New methods.
1782         (tui_source_windows, tui_add_to_source_windows): Update types.
1783         (tui_add_to_source_windows): Remove redundant declaration.
1784         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1785         (tui_source_windows): Change return type.
1786         (tui_clear_source_windows_detail): Update.
1787         (tui_add_to_source_windows): Change type of parameter.
1788         (tui_free_all_source_wins_content): Update.
1789
1790 2019-06-25  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-wingeneral.c (tui_win_info::refresh)
1793         (tui_source_window_base::refresh): New methods.
1794         (tui_refresh_all): Call the refresh method.
1795         * tui/tui-data.h (struct tui_win_info)
1796         (struct tui_source_window_base) <refresh>: New method.
1797
1798 2019-06-25  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui.h (tui_is_window_visible): Return bool.
1801         * tui/tui.c (tui_is_window_visible): Return bool.
1802         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1803         (tui_make_visible, tui_make_invisible)
1804         (tui_win_info::make_visible)
1805         (tui_source_window_base::make_visible, make_all_visible)
1806         (tui_make_all_visible, tui_make_all_invisible): Update.
1807         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1808         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1809         bool.
1810         (struct tui_win_info, struct tui_source_window_base)
1811         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1812         * tui/tui-data.c (tui_init_generic_part): Update.
1813
1814 2019-06-25  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1817         (tui_source_window_base::make_visible): New methods.
1818         (make_all_visible): Make method call.
1819         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1820         (struct tui_source_window_base, struct tui_cmd_window): Override
1821         make_visible.
1822         (tui_win_is_source_type): Don't declare.
1823         * tui/tui-data.c (tui_win_is_source_type): Remove.
1824
1825 2019-06-25  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1828         NULL check.
1829
1830 2019-06-25  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1833         Inline constructor.  Add initializers for members.
1834         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1835         constructors; now inline in class.
1836
1837 2019-06-25  Tom Tromey  <tom@tromey.com>
1838
1839         * tui/tui-regs.c (tui_show_registers): Update.
1840         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1841         bool.
1842         * tui/tui-data.c (tui_data_window::clear_detail)
1843         (tui_data_window): Update.
1844
1845 2019-06-25  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-windata.c (tui_display_all_data)
1848         (tui_display_data_from_line, tui_display_data_from)
1849         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1850         Update.
1851         * tui/tui-regs.c (tui_last_regs_line_no)
1852         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1853         (tui_show_registers, tui_show_register_group)
1854         (tui_display_registers_from, tui_display_reg_element_at_line)
1855         (tui_display_registers_from_line, tui_check_register_values)
1856         (tui_reg_next, tui_reg_prev): Update.
1857         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1858         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1859         tui_data_window.
1860         (struct tui_win_info) <detail>: Remove.  Add new fields from
1861         tui_data_info.
1862         (TUI_DATA_WIN): Add cast.
1863         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1864         (~tui_data_window): Simplify.
1865
1866 2019-06-25  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-layout.c (show_source_disasm_command)
1869         (show_source_or_disasm_and_command): Update.
1870         * tui/tui-io.c (update_cmdwin_start_line)
1871         (tui_redisplay_readline): Update.
1872         * tui/tui-data.h (struct tui_command_info): Remove.
1873         (struct tui_win_info) <detail>: Remove command_info member.
1874         (struct tui_data_window) <start_line>: New member, from
1875         tui_command_info.
1876         (TUI_CMD_WIN): Add casts.
1877
1878 2019-06-25  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-winsource.c (tui_update_source_window)
1881         (tui_refill_source_window)
1882         (tui_source_window_base::do_scroll_horizontal)
1883         (tui_update_breakpoint_info, tui_set_exec_info_content)
1884         (tui_show_exec_info_content, tui_erase_exec_info_content)
1885         (tui_clear_exec_info_content): Update.
1886         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1887         Update.
1888         * tui/tui-win.c (make_invisible_and_set_new_height)
1889         (make_visible_with_new_height): Update.
1890         * tui/tui-source.c (tui_set_source_content)
1891         (tui_show_symtab_source): Update.
1892         * tui/tui-layout.c (extract_display_start_addr)
1893         (show_source_disasm_command, show_data)
1894         (make_source_or_disasm_window)
1895         (show_source_or_disasm_and_command): Update.
1896         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1897         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1898         "gdbarch".
1899         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1900         to tui_source_window_base.
1901         (struct tui_win_info) <detail>: Remove source_info member.
1902         (struct tui_source_window_base) <has_locator>: Inline.
1903         Move contents from tui_source_info; rename has_locator member to
1904         m_has_locator.
1905         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1906         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1907         header file.
1908         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1909         Simplify.
1910         (tui_free_all_source_wins_content): Cast to
1911         tui_source_window_base.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-win.c (make_invisible_and_set_new_height)
1916         (make_visible_with_new_height): Call has_locator method.
1917         * tui/tui-layout.c (show_source_disasm_command, show_data)
1918         (show_source_or_disasm_and_command): Update for bool change.
1919         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1920         (tui_win_info) <has_locator>: New method.
1921         (struct tui_source_window_base) <has_locator>: New method.
1922         (tui_win_has_locator): Don't declare.
1923         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1924         from tui_win_has_locator.
1925         (tui_source_window_base): Use false, not FALSE.
1926
1927 2019-06-25  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1930         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1931         clear_detail method directly.
1932         (tui_clear_win_detail): Remove.
1933
1934 2019-06-25  Tom Tromey  <tom@tromey.com>
1935
1936         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1937         "this", not TUI_DISASM_WIN.
1938
1939 2019-06-25  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1942         declare.
1943         * tui/tui-winsource.c
1944         (tui_source_window_base::do_scroll_horizontal): Rename from
1945         tui_horizontal_source_scroll.
1946         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1947         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1948         from tui_vertical_data_scroll.
1949         * tui/tui-win.h (tui_scroll): Don't declare.
1950         * tui/tui-win.c (tui_win_info::forward_scroll)
1951         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1952         (tui_win_info::right_scroll): Rename and update.
1953         (tui_scroll_forward_command, tui_scroll_backward_command)
1954         (tui_scroll_left_command, tui_scroll_right_command): Update.
1955         (tui_scroll): Remove.
1956         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1957         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1958         from tui_vertical_source_scroll.
1959         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1960         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1961         from tui_vertical_disassem_scroll.
1962         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1963         do_scroll_horizontal>: New methods.
1964         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1965         Likewise.
1966         (struct tui_source_window_base): Add do_scroll_horizontal.
1967         (struct tui_source_window, struct tui_disasm_window): Add
1968         do_scroll_vertical.
1969         (struct tui_data_window, struct tui_cmd_window): Add
1970         do_scroll_horizontal and do_scroll_vertical.
1971         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-data.h (struct tui_source_window_base): New struct.
1976         (struct tui_source_window): Derive from tui_source_window_base.
1977         (struct tui_disasm_window): New struct.
1978         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1979         from tui_source_window::clear_detail.
1980         (tui_source_window_base): Rename from tui_source_window.
1981         (~tui_source_window_base): Rename from ~tui_source_window.
1982         (tui_alloc_win_info): Create a tui_disasm_window.
1983
1984 2019-06-25  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-data.h (struct tui_source_window)
1987         (struct tui_data_window): Declare destructors.
1988         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1989         destructors.
1990         (tui_win_info): Simplify.
1991
1992 2019-06-25  Tom Tromey  <tom@tromey.com>
1993
1994         * tui/tui-winsource.c (tui_display_main)
1995         (tui_update_source_windows_with_addr)
1996         (tui_update_all_breakpoint_info): Update.
1997         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1998         (new_height_ok, parse_scrolling_args): Update.
1999         * tui/tui-stack.c (tui_show_frame_info): Update.
2000         * tui/tui-data.h (struct tui_list): Remove.
2001         (tui_source_windows): Return a reference to a std::vector.
2002         * tui/tui-data.c (source_windows): Now a std::vector.
2003         (tui_source_windows): Change return type.
2004         (tui_clear_source_windows): Rewrite.
2005         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2006         (tui_free_all_source_wins_content): Rewrite.
2007
2008 2019-06-25  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2011         (struct tui_data_window, struct tui_cmd_window): Declare
2012         clear_detail method.
2013         * tui/tui-data.c (tui_source_window::clear_detail)
2014         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2015         methods.
2016         (tui_clear_win_detail): Simplify.
2017
2018 2019-06-25  Tom Tromey  <tom@tromey.com>
2019
2020         * tui/tui-layout.c (make_source_window, make_disasm_window)
2021         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2022         Return the new window.
2023         (show_source_disasm_command, show_data)
2024         (show_source_or_disasm_and_command): Update.
2025
2026 2019-06-25  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2029         parameter.  Return the new window.
2030         (show_source_disasm_command): Update and remove NULL check.
2031         (show_source_or_disasm_and_command): Update.
2032
2033 2019-06-25  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2036
2037 2019-06-25  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-data.h (struct tui_win_info): Make constructor
2040         protected.  Make destructor virtual.  Add initializers.
2041         (tui_source_window, tui_data_window, tui_cmd_window): New
2042         classes.
2043         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2044         constructor.  Add "type" parameter.
2045         (tui_source_window, tui_data_window, tui_cmd_window): New
2046         constructors.
2047         (tui_alloc_win_info): Instantiate the appropriate subclass.
2048
2049 2019-06-25  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-win.c (tui_resize_all): Use delete.
2052         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2053         destructor.
2054         (tui_free_window): Don't declare.
2055         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2056         Update.
2057
2058 2019-06-25  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-data.h (struct tui_win_info): Add constructor.
2061         * tui/tui-data.c (tui_alloc_win_info): Use new.
2062         (tui_free_window): Use delete.
2063
2064 2019-06-22  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2067         declare.
2068         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2069
2070 2019-06-22  Tom Tromey  <tom@tromey.com>
2071
2072         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2073         declare.
2074         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2075
2076 2019-06-22  Tom de Vries  <tdevries@suse.de>
2077
2078         * dwarf2read.c (create_addrmap_from_aranges)
2079         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2080         instead of '%zu'.
2081
2082 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2083
2084         * dwarf2read.h (dwarf2_section_info_def): Remove.
2085         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2086         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2087         std::vector<dwarf2_section_info>.
2088         (struct dwo_file) <~dwo_file>: Remove.
2089         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2090         types field.
2091         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2092         (dwarf2_read_debug_names): Likewise.
2093         (create_debug_types_hash_table): Change parameter type to
2094         array_view, adjust code accordingly.
2095         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2096         (partial_die_info::fixup): Likewise.
2097         (determine_prefix): Likewise.
2098         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2099
2100 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2101
2102         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2103         gdb_bfd_ref_ptr.
2104         <~dwo_file>: Remove call to gdb_bfd_unref.
2105         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2106         gdb_bfd_ref_ptr::get.
2107
2108 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2109
2110         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2111         type to htab_up.
2112         * dwarf2read.c (struct dwo_file): Initialize fields.
2113         <~dwo_file>: New.
2114         (free_dwo_file): Remove, move content to ~dwo_file.
2115         (struct dwo_file_deleter): Remove.
2116         (dwo_file_up>: Remove custom deleter.
2117         (free_dwo_files): Remove.
2118         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2119         dwo_files.
2120         (process_skeletonless_type_units): Call unique_ptr::get.
2121         (allocate_dwo_file_hash_table): Add deleter to created hash
2122         table.  Change return type to htab_up.
2123         (lookup_dwo_file_slot): Don't memset dwo_file, call
2124         unique_ptr::get.
2125         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2126         (create_dwo_unit_in_dwp_v2): Likewise.
2127         (open_and_init_dwo_file): Likewise.
2128         (free_dwo_file_from_slot): Remove.
2129
2130 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2131
2132         * dwarf2read.h (struct dwarf2_section_info) <readin,
2133         is_virtual>: Change type to bool.
2134         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2135         true instead of 1.
2136
2137 2019-06-19  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-data.h (tui_init_content_element): Don't declare.
2140
2141 2019-06-19  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-data.h (tui_init_win_info): Don't declare.
2144
2145 2019-06-19  Tom de Vries  <tdevries@suse.de>
2146
2147         * dwarf2read.h (abstract_to_concrete): Change type to
2148         std::unordered_map<sect_offset, std::vector<sect_offset>,
2149         gdb::hash_enum<sect_offset>>.
2150
2151 2019-06-19  Tom Tromey  <tromey@adacore.com>
2152
2153         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2154         EVAL_AVOID_SIDE_EFFECTS specially.
2155
2156 2019-06-19  Tom Tromey  <tromey@adacore.com>
2157
2158         * source-cache.c (highlighter): New global.
2159         (source_cache::get_source_lines): Create a highlighter on demand.
2160
2161 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2162
2163         * defs.h (deprecated_interactive_hook): Delete declaration.
2164         * interps.c (clear_interpreter_hooks): Remove use of
2165         deprecated_interactive_hook.
2166         * top.c (deprecated_interactive_hook): Delete definition.
2167         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2168
2169 2019-06-18  Tom de Vries  <tdevries@suse.de>
2170
2171         PR gdb/24515
2172         * dwarf2read.h (abstract_to_concrete): Change type from
2173         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2174         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2175         * dwarf2read.c (read_variable): Update.
2176         (dwarf2_fetch_die_loc_sect_off): Update.
2177
2178 2019-06-17  Tom de Vries  <tdevries@suse.de>
2179
2180         PR gdb/24617
2181         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2182         accessing parent[parent_len - 1].
2183
2184 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2185
2186         PR gdb/24364
2187         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2188         call dtrace_process_dof with NULL dof.
2189
2190 2019-06-16  Tom de Vries  <tdevries@suse.de>
2191
2192         PR gdb/24445
2193         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2194
2195 2019-06-16  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2198         (make_all_visible): Use address of member.
2199
2200 2019-06-16  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2203         (tui_free_window, free_content, free_content_elements): Remove
2204         unnecessary cast.
2205         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2206         cast.
2207         * tui/tui-regs.c (tui_show_register_group)
2208         (tui_display_registers_from, tui_display_reg_element_at_line):
2209         Remove unnecessary cast.
2210
2211 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2212
2213         * linux-nat.c (normal_mask): Delete.
2214         (_initialize_linux_nat): Don't initialise normal_mask.
2215
2216 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2217
2218         PR gdb/24445
2219         * dwarf-index-write.h (write_psymtabs_to_index): Add
2220         dwz_basename parameter.
2221         * dwarf-index-write.c (write_gdbindex): Move file writing to
2222         write_gdbindex_1.  Change return type void.
2223         (assert_file_size): Move up, remove filename parameter.
2224         (write_gdbindex_1): New function.
2225         (write_debug_names): Change return type to void, call
2226         assert_file_size.
2227         (struct index_wip_file): New struct.
2228         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2229         file logic to index_wip_file.  Write index for dwz file if
2230         needed.
2231         (save_gdb_index_command): Pass basename of dwz file, if present.
2232         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2233         build-id of dwz file, if present.
2234         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2235         (dwarf2_get_dwz_file): Likewise.
2236         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2237         (dwarf2_get_dwz_file): Likewise.
2238
2239 2019-06-16  Tom Tromey  <tom@tromey.com>
2240
2241         * coffread.c (process_coff_symbol): Use xstrdup.
2242         * value.c (create_internalvar): Use xstrdup.
2243
2244 2019-06-16  Tom Tromey  <tom@tromey.com>
2245
2246         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2247         * breakpoint.c (stopin_command, stopat_command)
2248         (until_break_command, decode_location_default): Remove unnecessary
2249         cast.
2250         * utils.c (subset_compare): Remove unnecessary cast.
2251         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2252         cast.
2253         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2254         cast.
2255         * infcmd.c (path_command): Remove unnecessary cast.
2256         * coffread.c (decode_type): Remove unnecessary cast.
2257         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2258         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2259         * tui/tui-stack.c (tui_show_locator_content)
2260         (tui_show_frame_info): Remove unnecessary cast.
2261         * tui/tui-win.c (tui_scroll_forward_command)
2262         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2263         (parse_scrolling_args): Remove unnecessary cast.
2264         * tui/tui-data.c (init_win_info, tui_del_window)
2265         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2266         (free_content_elements): Remove unnecessary cast.
2267         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2268         unnecessary cast.
2269         * tui/tui-source.c (tui_set_source_content)
2270         (tui_vertical_source_scroll): Remove unnecessary cast.
2271         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2272         cast.
2273         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2274         * tui/tui-regs.c (tui_display_registers_from)
2275         (tui_display_register): Remove unnecessary cast.
2276         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2277         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2278         (make_visible): Remove unnecessary cast.
2279         * tui/tui-winsource.c (tui_erase_source_content)
2280         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2281         unnecessary cast.
2282         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2283         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2284         * stabsread.c (read_type, read_array_type, read_range_type):
2285         Remove unnecessary cast.
2286         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2287         (parse_symbol, parse_type, upgrade_type, parse_external)
2288         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2289         unnecessary cast.
2290         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2291
2292 2019-06-16  Tom Tromey  <tom@tromey.com>
2293
2294         * tui/tui-data.c (tui_alloc_generic_win_info)
2295         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2296         checks.
2297
2298 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2299             Andrew Burgess  <andrew.burgess@embecosm.com>
2300
2301         * f-typeprint.c (f_print_type): Don't return early for not
2302         associated or not allocated types.
2303         (f_type_print_varspec_suffix): Add print_rank parameter and print
2304         ranks of array types in case they dangling.
2305         (f_type_print_base): Add print_rank parameter.
2306
2307 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2308
2309         * NEWS: Mention new MI commands.
2310         * break-catch-throw.c (enum exception_event_kind): Move to
2311         breakpoint.h.
2312         (print_mention_exception_catchpoint): Output text as a single
2313         message.
2314         (catch_exception_command_1): Rename to...
2315         (catch_exception_event): ...this, make non-static, update header
2316         command, and change some parameter types.
2317         (catch_catch_command): Update for changes to
2318         catch_exception_command_1.
2319         (catch_throw_command): Likewise.
2320         (catch_rethrow_command): Likewise.
2321         * breakpoint.c (enum exception_event_kind): Delete.
2322         * breakpoint.h (enum exception_event_kind): Moved here from
2323         break-catch-throw.c.
2324         (catch_exception_event): Declare.
2325         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2326         (mi_cmd_catch_throw): New function.
2327         (mi_cmd_catch_rethrow): New function.
2328         (mi_cmd_catch_catch): New function.
2329         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2330         'catch-catch' entries.
2331         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2332         (mi_cmd_catch_rethrow): Declare.
2333         (mi_cmd_catch_catch): Declare.
2334
2335 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2336
2337         * annotate.c (annotate_source_line): Change return type to void,
2338         update implementation to match.
2339         * annotate.h (annotate_source_line): Change return type to void,
2340         update header comment.
2341         * stack.c (print_frame_info): Don't change what frame information
2342         is printed based on whether annotations are on or not.
2343
2344 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2345
2346         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2347         (annotate_source): Make static.
2348         (annotate_source_line): Moved from source.c and renamed from
2349         identify_source_line.  Update the return type.
2350         * annotate.h (annotate_source): Delete declaration.
2351         (annotate_source_line): Declaration moved from source.h, and
2352         renamed from identify_source_line.  Return type updated.
2353         * source.c (identify_source_line): Moved to annotate.c and renamed
2354         to annotate_source_line.
2355         (info_line_command): Remove check of annotation_level.
2356         * source.h (identify_source_line): Move declaration to annotate.h
2357         and rename to annotate_source_line.
2358         * stack.c: Add 'annotate.h' include.
2359         (print_frame_info): Remove check of annotation_level before
2360         calling annotate_source_line.
2361
2362 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2363
2364         * source-cache.c (source_cache::get_plain_source_lines): Use
2365         open_source_file_with_line_charpos instead of just
2366         open_source_file, remove call to find_source_lines.
2367         (source_cache::get_source_lines): Likewise.
2368         * source.c (find_source_lines): Make static.
2369         (get_filename_and_charpos): Renamed into...
2370         (open_source_file_with_line_charpos): ..this along with changes to
2371         return a scoped_fd, and some other minor clean ups.
2372         (identify_source_line): Use open_source_file_with_line_charpos.
2373         (search_command_helper): Use open_source_file_with_line_charpos
2374         instead of just open_source_file, remove call to
2375         find_source_lines.
2376         * source.h (open_source_file_with_line_charpos): Declare new
2377         function.
2378         (find_source_lines): Delete declaration.
2379
2380 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2381
2382         * source.c (get_filename_and_charpos): Remove fullname
2383         parameter.
2384         (identify_source_line): Update call to get_filename_and_charpos.
2385
2386 2019-06-14  Tom Tromey  <tromey@adacore.com>
2387
2388         PR gdb/24502:
2389         * ui-style.h (skip_ansi_escape): Update comment.
2390         * ui-file.h (class no_terminal_escape_file): New class.
2391         * ui-file.c (no_terminal_escape_file::write)
2392         (no_terminal_escape_file::puts): New methods.
2393         * cli/cli-logging.c (handle_redirections): Use
2394         no_terminal_escape_file.
2395
2396 2019-06-14  Tom Tromey  <tromey@adacore.com>
2397
2398         * NEWS: Move convenience variable news above Python news.
2399
2400 2019-06-14  Tom Tromey  <tom@tromey.com>
2401
2402         * gnulib: Move directory to top-level.
2403         * configure.ac: Don't configure gnulib.
2404         * configure: Rebuild.
2405         * common/common-defs.h: Use new path to gnulib.
2406         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2407         (GNULIB_H): Remove.
2408         (INCGNU): Look in new gnulib location.
2409         (HFILES_NO_SRCDIR): Remove gnulib files.
2410         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2411         (generated_files): Remove GNULIB_H.
2412         ($(LIBGNU), all-lib): Remove targets.
2413         (distclean): Don't mention GNULIB_BUILDDIR.
2414         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2415
2416 2019-06-14  Tom Tromey  <tromey@adacore.com>
2417
2418         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2419         Warn if symbol file does not provide any symbols.
2420
2421 2019-06-14  Tom Tromey  <tromey@adacore.com>
2422
2423         * source.c (find_and_open_source): Respect basenames_may_differ.
2424
2425 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2426
2427         * annotate.c (annotate_breakpoints_invalid): Make use of
2428         scoped_restore_terminal_state.
2429         (annotate_frames_invalid): Likewise.
2430
2431 2019-06-14  Tom Tromey  <tromey@adacore.com>
2432
2433         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2434         allow assignment to an internalvar.
2435
2436 2019-06-14  Tom Tromey  <tromey@adacore.com>
2437
2438         * ada-lex.l: Allow "_" in attribute names.
2439
2440 2019-06-14  Tom Tromey  <tromey@adacore.com>
2441
2442         PR gdb/24653:
2443         * regcache.c (registers_changed): Don't call alloca.
2444         * top.c (execute_command): Don't call alloca.
2445
2446 2019-06-13  Pedro Alves  <palves@redhat.com>
2447
2448         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2449         'expression'.  When parsing an expression, error out if there's
2450         junk after "unlimited".
2451         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2452         (do_set_command): Adjust calls to is_unlimited_literal.
2453
2454 2019-06-13  Pedro Alves  <palves@redhat.com>
2455
2456         * compile/compile.c (make_compile_options_def_group): Add braces
2457         around array_view initializer.
2458         * thread.c (make_thread_apply_all_options_def_group)
2459         (make_thread_apply_all_options_def_group): Likewise.
2460
2461 2019-06-13  Pedro Alves  <palves@redhat.com>
2462
2463         * NEWS (New commands): Mention "maint test-options
2464         require-delimiter", "maint test-options unknown-is-error", "maint
2465         test-options unknown-is-operand" and "maint show
2466         test-options-completion-result".
2467         (New command options, command completion): New section.
2468         (Completion improvements): New section.
2469         Mention that you can abbreviate "unlimited".
2470
2471 2019-06-13  Pedro Alves  <palves@redhat.com>
2472
2473         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2474         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2475         * unittests/cli-utils-selftests.c (test_parse_flags)
2476         (test_parse_flags_qcs): Delete.
2477         (test_cli_utils): Don't call deleted functions.
2478
2479 2019-06-13  Pedro Alves  <palves@redhat.com>
2480
2481         * thread.c: Include "cli/cli-option.h".
2482         (tp_array_compar_ascending): Global.
2483         (tp_array_compar): Delete function.
2484         (tp_array_compar_ascending, tp_array_compar_descending): New
2485         functions.
2486         (ascending_option_def, qcs_flag_option_def)
2487         (thr_qcs_flags_option_defs)
2488         (make_thread_apply_all_options_def_group)
2489         (make_thread_apply_options_def_group): New.
2490         (thread_apply_all_command): Use gdb::option::process_options.
2491         (thread_apply_command_completer)
2492         (thread_apply_all_command_completer): New.
2493         (thread_apply_command): Use gdb::option::process_options.
2494         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2495         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2496         to generate help text of "thread apply".  Adjust "taas"'s help.
2497         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2498         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2499
2500 2019-06-13  Pedro Alves  <palves@redhat.com>
2501
2502         * thread.c (thread_apply_command): Check for invalid TID with
2503         isdigit instead of !isalpha.
2504
2505 2019-06-13  Pedro Alves  <palves@redhat.com>
2506
2507         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2508         (validate_flags_qcs): New.
2509         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2510         (validate_flags_qcs): Declare.
2511         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2512         (make_frame_apply_options_def_group): New.
2513         (frame_apply_command_count): Process options with
2514         gdb::option::process_options.
2515         (frame_apply_completer): New.
2516         (frame_apply_level_completer, frame_apply_all_completer)
2517         (frame_apply_completer): New.
2518         (_initialize_stack): Update help of "frame apply", "frame apply
2519         level", "frame apply all" and "faas" to mention supported options
2520         and install command completers.
2521         * stack.h (frame_apply_all_completer): Declare.
2522         * thread.c: Include "stack.h".
2523         (tfaas_command): Add "--".
2524         (_initialize_thread): Update help "tfaas" to mention supported
2525         options and install command completer.
2526
2527 2019-06-13  Pedro Alves  <palves@redhat.com>
2528
2529         * completer.c (complete_nested_command_line): New.
2530         (gdb_completion_word_break_characters_throw): Add assertion.
2531         * completer.h (complete_nested_command_line): Declare.
2532
2533 2019-06-13  Pedro Alves  <palves@redhat.com>
2534
2535         * stack.c (parse_backtrace_qualifiers): New.
2536         (backtrace_command): Use it.
2537         (backtrace_command_completer): Complete on qualifiers.
2538
2539 2019-06-13  Pedro Alves  <palves@redhat.com>
2540
2541         * frame.c: Include "cli/cli-option.h.
2542         (user_set_backtrace_options): New.
2543         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2544         Delete.
2545         (get_prev_frame): Adjust.
2546         (boolean_option_def, uinteger_option_def)
2547         (set_backtrace_option_defs): New.
2548         (_initialize_frame): Adjust and use
2549         gdb::option::add_setshow_cmds_for_options to install "set
2550         backtrace past-main" and "set backtrace past-entry".
2551         * frame.h: Include "cli/cli-option.h".
2552         (struct frame_print_options): Forward declare.
2553         (print_frame_arguments_all, print_frame_arguments_scalars)
2554         (print_frame_arguments_none): Declare.
2555         (print_entry_values): Delete declaration.
2556         (struct frame_print_options, user_frame_print_options): New.
2557         (struct set_backtrace_options): New.
2558         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2559         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2560         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2561         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2562         (list_args_or_locals): Add frame_print_options parameter.
2563         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2564         * python/py-framefilter.c (enumerate_args): Pass down
2565         USER_FRAME_PRINT_OPTIONS.
2566         * stack.c: Include "cli/cli-option.h".
2567         (print_frame_arguments_all, print_frame_arguments_scalars)
2568         (print_frame_arguments_none): Declare.
2569         (print_raw_frame_arguments, print_entry_values): Delete.
2570         (user_frame_print_options): New.
2571         (boolean_option_def, enum_option_def, frame_print_option_defs):
2572         New.
2573         (struct backtrace_cmd_options): New.
2574         (bt_flag_option_def): New.
2575         (backtrace_command_option_defs): New.
2576         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2577         (print_frame_arg, read_frame_arg, print_frame_args)
2578         (print_frame_info, print_frame): Add frame_print_options parameter
2579         and use it.
2580         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2581         (backtrace_command_1): Add frame_print_options and
2582         backtrace_cmd_options parameters and use them.
2583         (make_backtrace_options_def_group): New.
2584         (backtrace_command): Process command options with
2585         gdb::option::process_options.
2586         (backtrace_command_completer): New.
2587         (_initialize_stack): Extend "backtrace"'s help to mention
2588         supported options.  Install completer for "backtrace".
2589         Install some settings commands with add_setshow_cmds_for_options.
2590
2591 2019-06-13  Pedro Alves  <palves@redhat.com>
2592
2593         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2594         and that "set/show print raw frame-arguments" are now deprecated.
2595
2596         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2597         command.
2598         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2599         * stack.c (_initialize_stack): Install "set/show print
2600         raw-frame-arguments", and deprecate "set/show print raw
2601         frame-arguments".
2602         * valprint.c (_initialize_valprint): Deprecate "set/show print
2603         raw".
2604
2605 2019-06-13  Pedro Alves  <palves@redhat.com>
2606
2607         * compile/compile.c (struct compile_options): New.
2608         (compile_flag_option_def, compile_command_option_defs)
2609         (make_compile_options_def_group): New.
2610         (compile_file_command): Handle options with
2611         gdb::option::process_options.
2612         (compile_file_command_completer): New function.
2613         (compile_code_command): Handle options with
2614         gdb::option::process_options.
2615         (compile_code_command_completer): New function.
2616         (_initialize_compiler): Install completers for "compile code" and
2617         "compile file".  Mention available options in "compile code" and
2618         "compile code"'s help.
2619         * completer.c (advance_to_completion_word): New, factored out from
2620         ...
2621         (advance_to_expression_complete_word_point): ... this.
2622         (advance_to_filename_complete_word_point): New.
2623         * completer.h (advance_to_filename_complete_word_point): New
2624         declaration.
2625
2626 2019-06-13  Pedro Alves  <palves@redhat.com>
2627
2628         * compile/compile.c: Include "cli/cli-option.h".
2629         (compile_print_value): Scope data pointer is now a
2630         value_print_options pointer; adjust.
2631         (compile_print_command): Process options.  Scope data pointer is
2632         now a value_print_options pointer; adjust.
2633         (_initialize_compile): Update "compile print"'s help to include
2634         supported options.  Install a completer for "compile print".
2635         * cp-valprint.c (show_vtblprint, show_objectprint)
2636         (show_static_field_print): Delete.
2637         (_initialize_cp_valprint): Don't install "set print
2638         static-members", "set print vtbl", "set print object" here.
2639         * printcmd.c: Include "cli/cli-option.h" and
2640         "common/gdb_optional.h".
2641         (print_command_parse_format): Rework to fill in a
2642         value_print_options instead of a format_data.
2643         (print_value): Change parameter type from format_data pointer to
2644         value_print_options reference.  Adjust.
2645         (print_command_1): Process options.  Adjust to pass down a
2646         value_print_options.
2647         (print_command_completer): New.
2648         (_initialize_printcmd): Install print_command_completer as
2649         handle_brkchars completer for the "print" command.  Update
2650         "print"'s help to include supported options.
2651         * valprint.c: Include "cli/cli-option.h".
2652         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2653         here from cp-valprint.c.
2654         (boolean_option_def, uinteger_option_def)
2655         (value_print_option_defs, make_value_print_options_def_group):
2656         New.  Use gdb::option::add_setshow_cmds_for_options to install
2657         "set print elements", "set print null-stop", "set print repeats",
2658         "set print pretty", "set print union", "set print array", "set
2659         print address", "set print symbol", "set print array-indexes".
2660         * valprint.h: Include <string> and "cli/cli-option.h".
2661         (make_value_print_options_def_group): Declare.
2662         (print_value): Change parameter type from format_data pointer to
2663         value_print_options reference.
2664         (print_command_completer): Declare.
2665
2666 2019-06-13  Pedro Alves  <palves@redhat.com>
2667
2668         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2669         (COMMON_SFILES): Add maint-test-settings.c.
2670         * cli/cli-decode.c (boolean_enums): New global, factored out from
2671         ...
2672         (add_setshow_boolean_cmd): ... here.
2673         * cli/cli-decode.h (boolean_enums): Declare.
2674         * cli/cli-option.c: New file.
2675         * cli/cli-option.h: New file.
2676         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2677         factored out from ...
2678         (parse_cli_boolean_value(const char *)): ... this.
2679         (is_unlimited_literal): Change parameter type to pointer to
2680         pointer.  Adjust and advance ARG pointer.
2681         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2682         (parse_cli_var_enum): New, factored out from ...
2683         (do_set_command): ... this.  Adjust.
2684         * cli/cli-setshow.h (parse_cli_boolean_value)
2685         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2686         (parse_cli_var_enum): Declare.
2687         * cli/cli-utils.c: Include "cli/cli-option.h".
2688         (get_ulongest): New.
2689         * cli/cli-utils.h (get_ulongest): Declare.
2690         (check_for_argument): New overloads.
2691         * maint-test-options.c: New file.
2692
2693 2019-06-13  Pedro Alves  <palves@redhat.com>
2694
2695         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2696         parse a range if "-" is at the end of the string.
2697
2698 2019-06-13  Pedro Alves  <palves@redhat.com>
2699
2700         * cli/cli-setshow.c (parse_auto_binary_operation)
2701         (parse_cli_boolean_value): Don't allow "o".
2702
2703 2019-06-13  Pedro Alves  <palves@redhat.com>
2704
2705         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2706         * NEWS: Mention maint test-settings KIND.
2707         * maint-test-settings.c: New file.
2708
2709 2019-06-13  Pedro Alves  <palves@redhat.com>
2710
2711         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2712         completer.
2713         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2714         "set" completers.
2715
2716 2019-06-13  Pedro Alves  <palves@redhat.com>
2717
2718         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2719         after item.
2720
2721 2019-06-13  Pedro Alves  <palves@redhat.com>
2722
2723         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2724
2725 2019-06-13  Pedro Alves <palves@redhat.com>
2726
2727         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2728         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2729         call.
2730         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2731         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2732         calls.
2733         (check_for_argument): Skip spaces after argument.
2734
2735 2019-06-13  Pedro Alves  <palves@redhat.com>
2736
2737         * thread.c (thread_apply_command): Adjust TID parsing.
2738         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2739         detected before end of string.
2740         (tid_is_in_list): Error out if LIST is invalid.
2741
2742 2019-06-13  Pedro Alves  <palves@redhat.com>
2743
2744         * completer.c (complete_line_internal_1): Rewind completion word
2745         point.
2746         (completion_tracker::advance_custom_word_point_by): Change
2747         parameter type to int.
2748         * completer.h (completion_tracker::advance_custom_word_point_by):
2749         Likewise.
2750
2751 2019-06-13  Pedro Alves  <palves@redhat.com>
2752
2753         * completer.c (advance_to_completion_word): Handle delimiters.
2754
2755 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2756
2757         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2758
2759 2019-06-11  Tom Tromey  <tom@tromey.com>
2760
2761         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2762         (xmalloc_failed): Move to alloc.c.
2763         * alloc.c: New file.
2764         * Makefile.in (COMMON_SFILES): Add alloc.c.
2765
2766 2019-06-11  Tom Tromey  <tom@tromey.com>
2767
2768         * nat/linux-waitpid.c: Don't include server.h.
2769         (linux_debug): Remove.
2770         (my_waitpid): Update.
2771
2772 2019-06-11  Tom Tromey  <tromey@adacore.com>
2773
2774         * infcall.c (_initialize_infcall): Remove trailing newline from
2775         help.
2776         * user-regs.c (_initialize_user_regs): Remove trailing newline
2777         from help.
2778         * typeprint.c (_initialize_typeprint): Remove trailing newline
2779         from help.
2780         * reverse.c (_initialize_reverse): Remove trailing newlines from
2781         help.
2782         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2783         from help.
2784         * language.c (add_set_language_command): Remove trailing newline
2785         from help.
2786         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2787         help.
2788         * disasm.c (_initialize_disasm): Remove trailing newline from
2789         help.
2790         * top.c (init_main): Remove trailing newline from help.
2791         * interps.c (_initialize_interpreter): Remove trailing newline
2792         from help.
2793         * btrace.c (_initialize_btrace): Remove trailing newlines from
2794         help.
2795         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2796         from help.
2797         * python/python.c (_initialize_python): Remove trailing newline
2798         from help.
2799         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2800         help.
2801         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2802         from help.  Reformat some text.
2803         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2804         from help.
2805         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2806         newline from help.
2807
2808 2019-06-11  Tom Tromey  <tromey@adacore.com>
2809
2810         * darwin-nat.c (darwin_decode_exception_message)
2811         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2812
2813 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2814
2815         * valops.c (value_slice): Check for not allocated or not
2816         associated values.
2817
2818 2019-06-10  Tom de Vries  <tdevries@suse.de>
2819
2820         PR gdb/24618
2821         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2822         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2823         invalid.
2824
2825 2019-06-10  Tom de Vries  <tdevries@suse.de>
2826
2827         PR gdb/24611
2828         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2829         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2830
2831 2019-06-10  Tom de Vries  <tdevries@suse.de>
2832
2833         PR symtab/24545
2834         * symtab.c (struct demangled_name_entry): Add language field.
2835         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2836         static minimal symbol".  Set and use language field.
2837
2838 2019-06-10  Tom Tromey  <tromey@adacore.com>
2839
2840         * ada-lang.c (_initialize_ada_language): Update help text.
2841
2842 2019-06-10  Tom Tromey  <tromey@adacore.com>
2843
2844         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2845         with a newline.
2846         * guile/guile.c (handle_boot_error): Don't end warning with a
2847         newline.
2848         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2849         warning with a newline.
2850         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2851         newline.
2852         (s12z_frame_cache): Likewise.
2853         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2854         a newline.
2855         * solib-svr4.c (disable_probes_interface): Don't end warning with
2856         a newline.
2857         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2858         newline.
2859         * python/python.c (do_finish_initialization): Don't end warning
2860         with a newline.
2861
2862 2019-06-10  Tom Tromey  <tom@tromey.com>
2863
2864         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2865         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2866         gdbpy_enter.
2867
2868 2019-06-10  Tom Tromey  <tromey@adacore.com>
2869
2870         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2871         data.
2872         (elf_new_init): Don't call stabsread_new_init.
2873         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2874         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2875         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2876
2877 2019-06-10  Tom de Vries  <tdevries@suse.de>
2878
2879         PR symtab/16264
2880         PR symtab/24517
2881         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2882
2883 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2884
2885         * source.c (find_and_open_source): Also rewrite relative file
2886         names.
2887
2888 2019-04-26  Amos Bird  <amosbird@gmail.com>
2889
2890         * annotate.c (annotate_thread_exited): Add "thread-exited"
2891         annotation.
2892
2893 2019-06-06  Tom Tromey  <tromey@adacore.com>
2894
2895         * maint.h (class scoped_command_stats): Use
2896         DISABLE_COPY_AND_ASSIGN.
2897         <print_time>: New method.
2898         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2899         print_time.
2900         (scoped_command_stats::print_time): New method.
2901
2902 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2903
2904         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2905         instructions of lengths 6 or 8 bytes.
2906
2907 2019-06-04  Pedro Alves  <palves@redhat.com>
2908
2909         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2910
2911         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2912         * breakpoint.c (condition_completer): Likewise.
2913         * cli/cli-dump.c (scan_expression): Likewise.
2914         * common/filestuff.c (mkdir_recursive): Likewise.
2915         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2916         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2917         (gdb_abspath): Likewise.
2918         * compile/compile-cplus-types.c
2919         (compile_cplus_instance::decl_name): Likewise.
2920         * completer.c (complete_explicit_location):
2921         (signal_completer, reg_or_group_completer_1): Likewise.
2922         * cp-support.c (cp_remove_params_if_any): Likewise.
2923         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2924         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2925         * infcmd.c (strip_bg_char): Likewise.
2926         * linespec.c (copy_token_string): Likewise.
2927         * mi/mi-main.c (output_cores): Likewise.
2928         * psymtab.c (psymtab_search_name):
2929         * symfile.c (test_set_ext_lang_command): Likewise.
2930         * target.c (target_fileio_read_stralloc): Likewise.
2931         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2932         * value.c (complete_internalvar): Likewise.
2933
2934 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2935
2936         Add objfile property to gdb.Type.
2937         * NEWS: Mention Python API addition.
2938         * python/py-type.c (typy_get_objfile): New method.
2939
2940 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2941
2942         * NEWS: Mention the new set|show style [title|highlight].
2943         Mention changes to "show style", "help" and "apropos".
2944
2945 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2946
2947         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2948         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2949         instead of print_help_for_command.
2950         (print_doc_of_command): New function.
2951         (help_list): Add 'apropos -v word' suggestion.
2952         (print_help_for_command): Style the command name using title style.
2953         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2954         (_initialize_cli_cmds): Describe -v in apropos_command help.
2955
2956 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2957
2958         * cli/cli-style.h (cli_style_option): Add name in constructor,
2959         add m_name class member, add constructor with intensity,
2960         add name class function.
2961         (cli_style_option::add_setshow_commands): Remove name argument.
2962         (highlight_style, title_style): New styles.
2963         * cli/cli-style.c (do_show): New function that shows a style
2964         characteristic styling the style name with itself.
2965         (set_style_name): New function.
2966         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2967         Update all callers according to the changes in cli/cli-style.h.
2968         * utils.h (fputs_highlighted): New function.
2969         * utils.c (fputs_highlighted): Likewise.
2970
2971 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2972
2973         * NEWS: Mention new pipe command and new convenience variables.
2974
2975 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2976
2977         * cli/cli-cmds.c (pipe_command): New function.
2978         (_initialize_cli_cmds): Call add_com for pipe_command.
2979         Define | as an alias for pipe.
2980         (exit_status_set_internal_vars): New function.
2981         (shell_escape): Call exit_status_set_internal_vars.
2982         cli/cli-decode.c (find_command_name_length): Recognize | as
2983         a single character command.
2984
2985 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2986
2987         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2988         top.c (execute_command_to_ui_file): New function, mostly a copy
2989         of execute_command_to_string.
2990         (execute_command_to_string): Implement by calling
2991         execute_command_to_ui_file.
2992
2993 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2994
2995         * top.h (saved_command_line): Remove declaration.
2996         * top.c (previous_saved_command_line, previous_repeat_arguments):
2997         New variables.
2998         (saved_command_line): Make static, define together with other
2999         'repeat variables'.
3000         (dont_repeat): Clear repeat_arguments.
3001         (repeat_previous, get_saved_command_line, save_command_line):
3002         New functions.
3003         (gdb_init): Initialize saved_command_line
3004         and previous_saved_command_line.
3005         * main.c (captured_main_1): Remove saved_command_line initialization.
3006         * event-top.c (handle_line_of_input): Update to use
3007         the new 'repeat' related functions instead of direct access to
3008         saved_command_line.
3009         * command.h (repeat_previous, get_saved_command_line,
3010         save_command_line): New declarations.
3011         (dont_repeat): Add comment.
3012
3013 2019-05-30  Tom Tromey  <tromey@adacore.com>
3014
3015         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3016         Fix comment.
3017         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3018
3019 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3020
3021         PR cli/24587
3022         * completer.c (complete): Initialize variable word.
3023
3024 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3025
3026         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3027         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3028         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3029         'body' is NULL to the outter 'if', protecting the '!is_define'
3030         situation as well.
3031
3032 2019-05-29  Tom Tromey  <tromey@adacore.com>
3033
3034         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3035         (dwarf_unknown): New function.
3036         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3037         (dwarf_type_encoding_name): Use dwarf_unknown.
3038
3039 2019-05-29  Tom Tromey  <tromey@adacore.com>
3040
3041         PR c++/20020:
3042         * cp-valprint.c (cp_print_value_fields): Call
3043         cp_print_static_field inside "try".
3044
3045 2019-05-29  Tom Tromey  <tromey@adacore.com>
3046
3047         * inflow.c (struct terminal_info): Add default operator=.
3048         * configure: Rebuild.
3049         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3050         -Wdeprecated-copy-dtor, -Wredundant-move.
3051
3052 2019-05-29  Tom Tromey  <tromey@adacore.com>
3053
3054         * NEWS: Add entry.
3055         * infcmd.c (print_return_value_1): Handle finish_print
3056         option.
3057         (show_print_finish): New function.
3058         (_initialize_infcmd): Add "set/show print finish" commands.
3059         * valprint.c (user_print_options): Initialize new member.
3060         * valprint.h (struct value_print_options) <finish_print>: New
3061         member.
3062
3063 2019-05-28  Tom Tromey  <tromey@adacore.com>
3064
3065         * ada-lang.c (ada_remove_Xbn_suffix)
3066         (find_old_style_renaming_symbol)
3067         (parse_old_style_renaming): Remove.
3068         (ada_find_renaming_symbol): Don't call
3069         find_old_style_renaming_symbol.
3070         (ada_is_renaming_symbol): Rename from
3071         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3072         bool.  Now static.
3073         (ada_read_var_value): Update and simplify.
3074         * ada-exp.y (write_var_or_type): Remove old code.
3075
3076 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3077
3078         * event-top.c: Remove include comment.
3079         * inflow.c (class scoped_ignore_sigttou): Move from here...
3080         * inflow.h (class scoped_ignore_sigttou): ...to here.
3081         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3082         * top.c:  Remove include comment.
3083
3084 2019-05-27  Tom Tromey  <tom@tromey.com>
3085
3086         * NEWS: Fix typo.
3087
3088 2019-05-22  Tom Tromey  <tromey@adacore.com>
3089
3090         * target.c (target_follow_exec): Constify parameter.
3091         * target-delegates.c: Rebuild.
3092         * remote.c (remote_target::follow_exec): Constify parameter.
3093         * infrun.c (follow_exec): Constify parameter.
3094         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3095         (target_follow_exec): Likewise.
3096
3097 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3098
3099         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3100         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3101
3102 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3103
3104         * NEWS: Add debugredirect and testsuite sections.
3105
3106 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3107
3108         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3109         target descriptions using exclusively floating point register name
3110         aliases.
3111
3112 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3113
3114         PR gdb/18644:
3115         * f-lang.c (build_fortran_types): Handle the case where
3116         gdbarch_floatformat_for_type returns a nullptr.
3117
3118 2019-05-21  Tom de Vries  <tdevries@suse.de>
3119
3120         PR cli/24587
3121         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3122
3123 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3124
3125         PR gdb/18644:
3126         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3127         16-byte floats.
3128         * i386-tdep.c (i386_floatformat_for_type): Use
3129         floatformats_ia64_quad for the 16-byte floating point component
3130         within a fortran 32-byte complex number.
3131
3132 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3133
3134         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3135         delete default constructor.
3136         (find_partial_die): Update to return const struct.
3137         (partial_die_parent_scope): Move variable declaration into scope
3138         of its use and change its type to auto.
3139         (guess_partial_die_structure_name): Likewise.
3140         (partial_die_info::fixup): Likewise.
3141
3142 2019-05-17  Tom Tromey  <tromey@adacore.com>
3143
3144         * source.c (find_and_open_source): Remove cast.
3145
3146 2019-05-17  Tom Tromey  <tromey@adacore.com>
3147
3148         * annotate.c (annotate_source): Make "filename" const.
3149         * annotate.h (annotate_source): Use const.
3150
3151 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3152
3153         * disasm.c (set_disassembler_options): Send errors to stderr.
3154
3155 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3156
3157         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3158         (cli_interp_base::set_logging): Check debug_redirect.
3159         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3160         * cli/cli-logging.c (debug_redirect): Add static variable.
3161         (pop_output_files): Add default param.
3162         (handle_redirections): Print debug setting.
3163         (show_logging_command): Likewise.
3164         (_initialize_cli_logging): Add debugredirect command.
3165         * interps.c (current_interp_set_logging): Add debug_redirect
3166         parameter.
3167         * interps.h (set_logging): Add debug_redirect parameter.
3168         (current_interp_set_logging): Likewise.
3169         * mi/mi-common.h: Likewise.
3170         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3171
3172 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3173             Tom Tromey  <tromey@adacore.com>
3174
3175         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3176         directly.
3177         * cli/cli-interp.h (make_logging_output): Remove declaration.
3178         * cli/cli-logging.c (make_logging_output): Remove function.
3179         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3180         directly.
3181         * ui-file.c (tee_file::tee_file): Remove bools.
3182         (tee_file::~tee_file): Remove deletes.
3183         * ui-file.h (tee_file): Remove bools.
3184
3185 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3186
3187         * mi/mi-cmds.h (mi_cmd_complete): New function.
3188         * mi/mi-main.c (mi_cmd_complete): Likewise.
3189         * mi/mi-cmds.c: Define new MI command -complete.
3190         * NEWS: Mention new -complete command.
3191
3192 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3193
3194         * completer.h (complete): New function.
3195         * completer.c (complete): Likewise.
3196         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3197         function defined in completer.h.
3198
3199 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3200
3201         * MAINTAINERS (Write After Approval): Add myself.
3202
3203 2019-05-17  Tom de Vries  <tdevries@suse.de>
3204
3205         PR gdb/24094
3206         * dwarf2read.c (struct cu_partial_die_info): New struct.
3207         (find_partial_die): Return cu_partial_die_info.
3208         (partial_die_parent_scope, guess_partial_die_structure_name)
3209         (partial_die_info::fixup): Handle new return type of find_partial_die.
3210
3211 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3212
3213         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3214         "std::string", simplifying the algorithm.
3215
3216 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3217
3218         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3219         (stap_static_probe_ops::get_probes): Likewise.
3220
3221 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3222
3223         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3224         '-')" and "else if".
3225         (stap_parse_single_operand): Join checks for
3226         "gdbarch_stap_parse_special_token_p" and
3227         "gdbarch_stap_parse_special_token" in the same "if" statement.
3228         Invert check when verifying for operation on register
3229         displacement.
3230
3231 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3232
3233         * stap-probe.c (stap_get_opcode): Update comment.
3234         (stap_get_expected_argument_type): Likewise.
3235         (handle_stap_probe): Likewise.
3236
3237 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3238
3239         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3240         return type to 'bool'.  Adjust comment.  Use 'bool' when
3241         appropriate.
3242         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3243         * stap-probe.c (stap_parse_argument_1): Likewise.
3244         (stap_is_operator): Likewise.
3245         (stap_is_generic_prefix): Likewise.
3246         (stap_is_register_prefix): Likewise.
3247         (stap_is_register_indirection_prefix): Likewise.
3248         (stap_is_integer_prefix): Likewise.
3249         (stap_generic_check_suffix): Likewise.
3250         (stap_check_integer_suffix): Likewise.
3251         (stap_check_register_suffix): Likewise.
3252         (stap_check_register_indirection_suffix): Likewise.
3253         (stap_parse_register_operand): Likewise.
3254         (stap_parse_single_operand): Likewise.
3255         (stap_parse_argument_1): Likewise.
3256         (stap_probe::get_argument_count): Likewise.
3257         (stap_is_operator): Likewise.
3258
3259 2019-05-16  Tom Tromey  <tromey@adacore.com>
3260
3261         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3262         keyword to foreach.
3263
3264 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3265
3266         * linux-thread-db.c (try_thread_db_load_1): Change return type
3267         to bool.
3268         (try_thread_db_load): Likewise.
3269         (try_thread_db_load_from_pdir_1): Likewise.
3270         (try_thread_db_load_from_pdir): Likewise.
3271         (try_thread_db_load_from_sdir): Likewise.
3272         (try_thread_db_load_from_dir): Likewise.
3273         (thread_db_load_search): Likewise.
3274         (has_libpthread): Likewise.
3275         (thread_db_load): Likewise.
3276
3277 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3278
3279         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3280         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3281         NULL, and complain/return if that's the case.
3282
3283 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3284
3285         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3286         (advance, posn, abstract_read_memory): New functions.
3287         [struct mem_read_abstraction]: New struct.
3288         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3289
3290 2019-05-14  Tom Tromey  <tromey@adacore.com>
3291
3292         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3293         value is not lval_memory.
3294
3295 2019-05-14  Tom Tromey  <tromey@adacore.com>
3296
3297         * solib.c (info_sharedlibrary_command): Style the file name.
3298
3299 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3300
3301         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3302         (aarch64_vnv_type): Likewise.
3303         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3304         * common/tdesc.c: Likewise.
3305         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3306         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3307         * features/aarch64-fpu.xml: Add ieee half view.
3308         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3309         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3310         * gdbtypes.h (struct builtin_type): Likewise.
3311         (struct objfile_type): Likewise.
3312
3313 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3314
3315         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3316         typo.
3317         * location.h (string_to_event_location): Likewise.
3318
3319 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3320
3321         GDB 8.3 released.
3322
3323 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3324
3325         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3326         New variable declaration.
3327         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3328         New variable.
3329         (print_one_breakpoint): Use ui_out::test_flags and new global
3330         variable to compute use_fixed_output.
3331         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3332         Remove.
3333         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3334         (mi_multi_location_breakpoint_output_fixed): Remove.
3335         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3336         new variable.
3337         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3338         fix_multi_location_breakpoint_output flag if version >= 3.
3339         * ui-out.h (enum ui_out_flag)
3340         <fix_multi_location_breakpoint_output>: New enumerator.
3341
3342 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3343
3344         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3345
3346 2019-05-10  Tom Tromey  <tromey@adacore.com>
3347
3348         * ada-lang.c (catch_ada_completer): New function.
3349         (_initialize_ada_language): Use it.
3350
3351 2019-05-10  Tom Tromey  <tromey@adacore.com>
3352
3353         * thread.c (print_thread_info): Make "requested_threads" const.
3354         * gdbthread.h (print_thread_info): Make "requested_threads"
3355         const.
3356         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3357         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3358
3359 2019-05-08  Tom Tromey  <tom@tromey.com>
3360
3361         * gdbtypes.c (objfile_type_data): Change type.
3362         (objfile_type, _initialize_gdbtypes): Update.
3363
3364 2019-05-08  Tom Tromey  <tom@tromey.com>
3365
3366         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3367         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3368         (_initialize_dwarf2_frame): Update.
3369
3370 2019-05-08  Tom Tromey  <tom@tromey.com>
3371
3372         * objc-lang.c (objc_objfile_data): Change type.
3373         (find_methods): Update.
3374         (_initialize_objc_lang): Remove.
3375
3376 2019-05-08  Tom Tromey  <tom@tromey.com>
3377
3378         * stabsread.c (rs6000_builtin_type_data): Change type.
3379         (rs6000_builtin_type, _initialize_stabsread): Update.
3380
3381 2019-05-08  Tom Tromey  <tom@tromey.com>
3382
3383         * mips-tdep.c (mips_pdr_data): Remove.
3384         (_initialize_mips_tdep): Update.
3385
3386 2019-05-08  Tom Tromey  <tom@tromey.com>
3387
3388         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3389         (hppa_init_objfile_priv_data, read_unwind_info)
3390         (find_unwind_entry, _initialize_hppa_tdep): Update.
3391
3392 2019-05-08  Tom Tromey  <tom@tromey.com>
3393
3394         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3395         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3396         on obstack.
3397         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3398
3399 2019-05-08  Tom Tromey  <tom@tromey.com>
3400
3401         * mdebugread.c (basic_type_data): Change type.
3402         (basic_type, _initialize_mdebugread): Update.
3403
3404 2019-05-08  Tom Tromey  <tom@tromey.com>
3405
3406         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3407
3408 2019-05-08  Tom Tromey  <tom@tromey.com>
3409
3410         * nto-tdep.c (nto_inferior_data_reg): Change type.
3411         (nto_inferior_data): Update.
3412         (nto_inferior_data_cleanup, nto_new_inferior_data)
3413         (_initialize_nto_tdep): Remove.
3414         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3415
3416 2019-05-08  Tom Tromey  <tom@tromey.com>
3417
3418         * ada-lang.c (struct ada_inferior_data): Add initializers.
3419         (ada_inferior_data): Change type.
3420         (ada_inferior_data_cleanup): Remove.
3421         (get_ada_inferior_data, ada_inferior_exit)
3422         (struct ada_pspace_data): Add initializers, destructor.
3423         (ada_pspace_data_handle): Change type.
3424         (get_ada_pspace_data): Update.
3425         (ada_pspace_data_cleanup): Remove.
3426
3427 2019-05-08  Tom Tromey  <tom@tromey.com>
3428
3429         * coffread.c (struct coff_symfile_info): Add initializers.
3430         (coff_objfile_data_key): Move lower.  Change type.
3431         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3432         Update.
3433         (coff_free_info): Remove.
3434
3435 2019-05-08  Tom Tromey  <tom@tromey.com>
3436
3437         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3438         (fbsd_pspace_data_handle): Move lower.  Change type.
3439         (get_fbsd_pspace_data): Update.
3440         (fbsd_pspace_data_cleanup): Remove.
3441         (_initialize_fbsd_tdep): Update.
3442
3443 2019-05-08  Tom Tromey  <tom@tromey.com>
3444
3445         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3446         (get_ada_tasks_pspace_data): Update.
3447         (ada_tasks_pspace_data_cleanup): Remove.
3448         (_initialize_tasks): Update.
3449         (ada_tasks_inferior_data_handle): Change type.
3450         (get_ada_tasks_inferior_data): Update.
3451         (ada_tasks_inferior_data_cleanup): Remove.
3452         (struct ada_tasks_pspace_data): Add initializers.
3453
3454 2019-05-08  Tom Tromey  <tom@tromey.com>
3455
3456         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3457         * symfile-debug.c (debug_sym_get_probes): Change type.
3458         * stap-probe.c (handle_stap_probe):
3459         (stap_static_probe_ops::get_probes): Change type.
3460         * probe.h (class static_probe_ops) <get_probes>: Change type.
3461         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3462         (parse_probes_in_pspace): Update.
3463         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3464         Update.
3465         (any_static_probe_ops::get_probes): Change type.
3466         * elfread.c (elfread_data): New typedef.
3467         (probe_key): Change type.
3468         (elf_get_probes): Likewise.  Update.
3469         (probe_key_free): Remove.
3470         (_initialize_elfread): Update.
3471         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3472         Change type.
3473         (dtrace_process_dof_probe, dtrace_process_dof)
3474         (dtrace_static_probe_ops::get_probe): Change type.
3475
3476 2019-05-08  Tom Tromey  <tom@tromey.com>
3477
3478         * xcoffread.c (struct xcoff_symfile_info): Rename from
3479         coff_symfile_info.  Add initializers.
3480         (xcoff_objfile_data_key): Move lower.  Change type.
3481         (XCOFF_DATA): Rewrite.
3482         (xcoff_free_info): Remove.
3483         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3484         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3485         (xcoff_initial_scan): Update.
3486
3487 2019-05-08  Tom Tromey  <tom@tromey.com>
3488
3489         * solib-svr4.c (struct svr4_info): Add initializers and
3490         destructor.
3491         <probes_table>: Now an htab_up.
3492         (solib_svr4_pspace_data): Change type.
3493         (free_probes_table): Simplify.
3494         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3495         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3496         (probes_table_remove_objfile_probes, register_solib_event_probe)
3497         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3498         (_initialize_svr4_solib): Update.
3499
3500 2019-05-08  Tom Tromey  <tom@tromey.com>
3501
3502         * remote.c (remote_pspace_data): Change type.
3503         (remote_pspace_data_cleanup): Remove.
3504         (get_remote_exec_file, set_pspace_remote_exec_file)
3505         (_initialize_remote): Update.
3506
3507 2019-05-08  Tom Tromey  <tom@tromey.com>
3508
3509         * breakpoint.c (breakpoint_objfile_key): Change type.
3510         (get_breakpoint_objfile_data): Update.
3511         (free_breakpoint_objfile_data): Remove.
3512         (_initialize_breakpoint): Update.
3513
3514 2019-05-08  Tom Tromey  <tom@tromey.com>
3515
3516         * linux-tdep.c (struct linux_info): Add initializers.
3517         (linux_inferior_data): Move.  Change type.
3518         (invalidate_linux_cache_inf): Update.
3519         (linux_inferior_data_cleanup): Remove.
3520         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3521
3522 2019-05-08  Tom Tromey  <tom@tromey.com>
3523
3524         * auxv.c (auxv_inferior_data): Move.  Change type.
3525         (auxv_inferior_data_cleanup): Remove.
3526         (invalidate_auxv_cache_inf): Rewrite.
3527         (get_auxv_inferior_data, _initialize_auxv): Update.
3528
3529 2019-05-08  Tom Tromey  <tom@tromey.com>
3530
3531         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3532         (symfile_debug_objfile_data_key): Change type.
3533         (symfile_debug_installed, debug_qf_has_symbols)
3534         (debug_qf_find_last_source_symtab)
3535         (debug_qf_forget_cached_source_info)
3536         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3537         (debug_qf_print_stats, debug_qf_dump)
3538         (debug_qf_expand_symtabs_for_function)
3539         (debug_qf_expand_all_symtabs)
3540         (debug_qf_expand_symtabs_with_fullname)
3541         (debug_qf_map_matching_symbols)
3542         (debug_qf_expand_symtabs_matching)
3543         (debug_qf_find_pc_sect_compunit_symtab)
3544         (debug_qf_map_symbol_filenames)
3545         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3546         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3547         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3548         (debug_sym_read_linetable, debug_sym_relocate): Update.
3549         (symfile_debug_free_objfile): Remove.
3550         (install_symfile_debug_logging, _initialize_symfile_debug):
3551         Update.
3552
3553 2019-05-08  Tom Tromey  <tom@tromey.com>
3554
3555         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3556         allocate_on_obstack.
3557         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3558         (get_dwarf2_per_objfile): Update.
3559         (set_dwarf2_per_objfile): Remove.
3560         (dwarf2_has_info, dwarf2_get_section_info): Update.
3561         (dwarf2_free_objfile): Remove.
3562         (_initialize_dwarf2_read): Update.
3563
3564 2019-05-08  Tom Tromey  <tom@tromey.com>
3565
3566         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3567         initializers.
3568         <unsupported_script_warning_printed,
3569         script_not_found_warning_printed>: Now bool.
3570         (auto_load_pspace_data): Change type.
3571         (~auto_load_pspace_info): Rename from
3572         auto_load_pspace_data_cleanup.
3573         (get_auto_load_pspace_data, init_loaded_scripts_info)
3574         (clear_section_scripts, maybe_print_unsupported_script_warning)
3575         (maybe_print_script_not_found_warning, _initialize_auto_load):
3576         Update.
3577
3578 2019-05-08  Tom Tromey  <tom@tromey.com>
3579
3580         * objfiles.c (objfile_pspace_info): Add destructor and
3581         initializers.
3582         (objfiles_pspace_data): Change type.
3583         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3584         (get_objfile_pspace_data): Update.
3585         (objfiles_bfd_data): Change type.
3586         (get_objfile_bfd_data): Update.
3587         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3588
3589 2019-05-08  Tom Tromey  <tom@tromey.com>
3590
3591         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3592         Change type.
3593         (get_catch_syscall_inferior_data): Update.
3594         (catch_syscall_inferior_data_cleanup): Remove.
3595         (_initialize_break_catch_syscall): Update.
3596
3597 2019-05-08  Tom Tromey  <tom@tromey.com>
3598
3599         * inflow.c (struct terminal_info): Add destructor and
3600         initializers.
3601         (inflow_inferior_data): Change type.
3602         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3603         (get_inflow_inferior_data, inflow_inferior_exit)
3604         (swap_terminal_info, _initialize_inflow): Update.
3605
3606 2019-05-08  Tom Tromey  <tom@tromey.com>
3607
3608         * target-dcache.c (target_dcache_cleanup): Remove.
3609         (target_dcache_aspace_key): Change type.
3610         (target_dcache_init_p, target_dcache_invalidate)
3611         (target_dcache_get, target_dcache_get_or_init)
3612         (_initialize_target_dcache): Update.
3613         * dcache.h (struct dcache_deleter): New.
3614
3615 2019-05-08  Tom Tromey  <tom@tromey.com>
3616
3617         * symtab.c (struct symbol_cache): Add destructor and
3618         initializers.
3619         (symbol_cache_key): Move.  Change type.
3620         (make_symbol_cache, free_symbol_cache): Remove.
3621         (get_symbol_cache): Update.
3622         (symbol_cache_cleanup): Remove.
3623         (ALL_PSPACES, symbol_cache_flush)
3624         (maintenance_print_symbol_cache)
3625         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3626         Update.
3627
3628 2019-05-08  Tom Tromey  <tom@tromey.com>
3629
3630         * symtab.c (struct main_info): Add destructor and initializers.
3631         (main_progspace_key): Move.  Change type.
3632         (get_main_info): Update.
3633         (main_info_cleanup): Remove.
3634         (_initialize_symtab): Update.
3635
3636 2019-05-08  Tom Tromey  <tom@tromey.com>
3637
3638         * registry.h (DECLARE_REGISTRY): Define the _key class.
3639
3640 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3641
3642         * NEWS: Merge two 'New commands' sections.
3643
3644 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3645
3646         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3647         parameter and use Ada language definition instead.
3648         (ada_val_print_ptr): Remove unused language parameter.
3649         (ada_val_print_num): Remove language parameter and use Ada language
3650         definition instead.
3651         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3652         parameter.
3653         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3654         parameter and use Ada language definition instead.
3655         (ada_val_print_1): Update all ada_val_print_xxx calls.
3656         Remove language parameter.
3657         (ada_val_print): Update ada_val_print_1 call.
3658
3659 2019-05-08  Tom Tromey  <tromey@adacore.com>
3660
3661         * remote.c (remote_hw_watchpoint_limit)
3662         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3663         Now static.
3664
3665 2019-05-08  Tom Tromey  <tromey@adacore.com>
3666
3667         * maint.c (_initialize_maint_cmds): Move initialization code to
3668         remote.c.
3669         (watchdog, show_watchdog): Move to remote.c.
3670         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3671         "watchdog" static.
3672         (_initialize_remote): Move initialization code from maint.c.
3673         * defs.h (watchdog): Don't declare.
3674
3675 2019-05-08  Tom Tromey  <tromey@adacore.com>
3676
3677         * tui/tui-interp.c: Include main.h.
3678         * interps.c: Include main.h.
3679         * main.h (interpreter_p): Declare.
3680         * defs.h (interpreter_p): Don't declare.
3681
3682 2019-05-08  Tom Tromey  <tromey@adacore.com>
3683
3684         * dwarf2loc.c: Include dwarf2read.h.
3685         * defs.h (read_unsigned_leb128): Don't declare.
3686         * dwarf2read.h (read_unsigned_leb128): Declare.
3687
3688 2019-05-08  Tom Tromey  <tromey@adacore.com>
3689
3690         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3691         method.
3692
3693 2019-05-08  Tom Tromey  <tromey@adacore.com>
3694
3695         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3696         when no wrap column is set.
3697
3698 2019-05-08  Tom Tromey  <tromey@adacore.com>
3699
3700         * c-lang.c (c_get_string): Handle non-C-style arrays.
3701
3702 2019-05-08  Tom Tromey  <tromey@adacore.com>
3703
3704         * typeprint.c (print_offset_data::update): Print the bit offset,
3705         not the number of bits remaining.
3706
3707 2019-05-08  Tom Tromey  <tromey@adacore.com>
3708
3709         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3710         padding at end of comment.
3711
3712 2019-05-08  Tom Tromey  <tromey@adacore.com>
3713
3714         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3715         Compare main types.
3716
3717 2019-05-06  Tom Tromey  <tom@tromey.com>
3718
3719         * common/scoped_mmap.c: Include common-defs.h.
3720         * common/scoped_mmap.h: Don't include config.h.
3721
3722 2019-05-04  Tom Tromey  <tom@tromey.com>
3723
3724         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3725         (struct aarch64_call_info): Add initializers.
3726         <si>: Now a std::vector.
3727         (pass_on_stack, aarch64_push_dummy_call): Update.
3728
3729 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3730             Tom Tromey  <tom@tromey.com>
3731
3732         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3733         (ppc_threads): Now a std::vector.  Now static.
3734         (hwdebug_find_thread_points_by_tid)
3735         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3736         Update.
3737
3738 2019-05-04  Tom Tromey  <tom@tromey.com>
3739
3740         * arc-tdep.c (arc_tdesc_init): Return bool.
3741
3742 2019-05-04  Tom Tromey  <tom@tromey.com>
3743
3744         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3745         Use gdb_assert_not_reached.
3746
3747 2019-05-04  Tom Tromey  <tom@tromey.com>
3748
3749         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3750         "false".
3751
3752 2019-05-04  Tom Tromey  <tom@tromey.com>
3753
3754         * arc-tdep.c (arc_tdesc_init): Use bool.
3755
3756 2019-05-04  Tom Tromey  <tom@tromey.com>
3757
3758         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3759
3760 2019-05-04  Tom Tromey  <tom@tromey.com>
3761
3762         * cli/cli-cmds.c (valid_command_p): Return bool.
3763
3764 2019-05-04  Tom Tromey  <tom@tromey.com>
3765
3766         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3767         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3768
3769 2019-05-04  Raul Tambre  <raul@tambre.ee>
3770
3771         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3772         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3773         operator for comparison.
3774
3775 2019-05-04  Tom Tromey  <tom@tromey.com>
3776
3777         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3778         (lookup_partial_symbol, print_partial_symbols)
3779         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3780         (psymbol_compare): Update.
3781         (add_psymbol_to_bcache): Clear the entire psymbol.
3782         (maintenance_check_psymtabs): Update.
3783         * psympriv.h (struct partial_symbol): Don't derive from
3784         general_symbol_info.
3785         <obj_section, unrelocated_address, address,
3786         set_unrelocated_address>: Update.
3787         <ginfo>: New member.
3788         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3789         (debug_names::write_psymbols): Update.
3790
3791 2019-05-04  Tom de Vries  <tdevries@suse.de>
3792
3793         * contrib/cc-with-tweaks.sh: Support -n arg.
3794
3795 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3796
3797         * corelow.c (core_target::detach): Ensure frame cache and
3798         register caches are cleared.
3799         inferior.c (exit_inferior_1): Likewise.
3800
3801 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3802             Tom Tromey  <tom@tromey.com>
3803
3804         * dictionary.c (collate_pending_symbols_by_language): Remove
3805         "struct" from foreach.
3806         * symtab.c (lookup_global_symbol_from_objfile)
3807         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3808         foreach.
3809         * ser-tcp.c (net_open): Remove "struct" from foreach.
3810         * objfiles.c (objfile_relocate, objfile_rebase)
3811         (objfile_has_symbols): Remove "struct" from foreach.
3812         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3813         from foreach.
3814         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3815         foreach.
3816         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3817         "struct" from foreach.
3818         * ada-lang.c (create_excep_cond_exprs)
3819         (ada_exception_catchpoint_cond_string): Remove "struct" from
3820         foreach.
3821
3822 2019-05-03  Tom Tromey  <tromey@adacore.com>
3823
3824         * ada-exp.y (convert_char_literal): Check suffix of each
3825         enumerator.
3826
3827 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3828
3829         PR ada/21406:
3830         * ada-exp.y (yywrap): Don't define.
3831         * ada-lex.l (%option): Add noyywrap
3832         (yywrap): Remove.
3833
3834 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3835
3836         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3837         _WIN32_WINNT to the XP level, unless already defined to a higher
3838         level.
3839
3840         * unittests/parse-connection-spec-selftests.c:
3841         * ser-tcp.c:
3842         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3843         override.
3844
3845         * symfile.c (find_separate_debug_file): Remove colon from the
3846         drive spec of DOS/Windows file names of the target, so that the
3847         file name produced from DEBUGDIR and the target's directory will
3848         be valid on DOS/Windows systems.
3849
3850 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3851
3852         * rust-lang.c (val_print_struct): Handle printing structures
3853         containing strings.
3854
3855 2019-05-02  Tom Tromey  <tromey@adacore.com>
3856
3857         * valarith.c (_initialize_valarith): Remove.
3858
3859 2019-05-01  Tom Tromey  <tromey@adacore.com>
3860
3861         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3862         bitfields.
3863
3864 2019-05-01  Tom Tromey  <tromey@adacore.com>
3865
3866         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3867         for big-endian copies.
3868
3869 2019-04-30  Ali Tamur  <tamur@google.com>
3870         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3871         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3872         (read_3_bytes): New function.
3873
3874 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3875
3876         * windows-nat.c (main_thread_id): Delete.
3877         (handle_output_debug_string): Replace main_thread_id by
3878         current_event.dwThreadId.
3879         (fake_create_process): Likewise.
3880         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3881         Do not set main_thread_id.
3882         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3883         current_event.dwThreadId.
3884         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3885
3886 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3887
3888         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3889         Use current_event.dwThreadId instead of main_thread_id.
3890
3891 2019-04-30  Tom Tromey  <tromey@adacore.com>
3892
3893         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3894         (create_excep_cond_exprs): Iterate over program spaces.
3895         (ada_exception_catchpoint_cond_string): Examine all minimal
3896         symbols for exception types.
3897
3898 2019-04-30  Tom Tromey  <tromey@adacore.com>
3899
3900         PR c++/24470:
3901         * dwarf2read.c (process_structure_scope): Handle case where type
3902         has template parameters but no symbol was created.
3903
3904 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3905             Chris January  <chris.january@arm.com>
3906
3907         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3908         qualifier.
3909         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3910
3911 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * f-typeprint.c (f_print_type): Update rules for printing
3914         whitespace.
3915         (f_type_print_varspec_suffix): Likewise.
3916
3917 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3918             Chris January  <chris.january@arm.com>
3919
3920         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3921         function arguments.
3922
3923 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3924
3925         * f-lang.c (build_fortran_types): Change name of void type to
3926         lower case.
3927         * f-typeprint.c (f_type_print_base): Print the name of the void
3928         type, rather than a fixed string.
3929         * f-valprint.c (f_decorations): Use lower case void string.
3930
3931 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3932             Chris January  <chris.january@arm.com>
3933
3934         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3935         types for Fortran.
3936
3937 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3938             Chris January  <chris.january@arm.com>
3939             David Lecomber  <david.lecomber@arm.com>
3940
3941         * f-exp.y (BINOP_INTRINSIC): New token.
3942         (exp): New parser rule handling BINOP_INTRINSIC.
3943         (f77_keywords): Add new builtin procedures.
3944         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3945         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3946         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3947         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3948         (print_unop_subexp_f): New function.
3949         (print_binop_subexp_f): New function.
3950         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3951         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3952         (dump_subexp_body_f): Likewise.
3953         (operator_check_f): Likewise.
3954         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3955         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3956
3957 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3958
3959         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3960         UNOP_KIND.
3961         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3962         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3963         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3964         (operator_length_f): New fuction.
3965         (print_subexp_f): New function.
3966         (op_name_f): New function.
3967         (dump_subexp_body_f): New function.
3968         (operator_check_f): New function.
3969         (exp_descriptor_f): Replace standard expression handling functions
3970         with new functions.
3971         * gdb/fortran-operator.def: New file.
3972         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3973         * gdb/std-operator.def: Remove UNOP_KIND.
3974
3975 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * std-operator.def: Remove unbalanced, stray double quote
3978         character.
3979
3980 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3981             Chris January  <chris.january@arm.com>
3982             Daniel Everett  <daniel.everett@arm.com>
3983             Nick Forrington  <nick.forrington@arm.com>
3984             Richard Bunt  <richard.bunt@arm.com>
3985
3986         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3987         of depth when printing anonymous structs or unions.
3988         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3989         Don't print either the top-level value, or the children if the
3990         max-depth is exceeded.
3991         (ppscm_print_children): When printing the key of a map, allow one
3992         extra level of depth.
3993         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3994         print either the top-level value, or the children if the max-depth
3995         is exceeded.
3996         (print_children): When printing the key of a map, allow one extra
3997         level of depth.
3998         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3999         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4000         (user_print_options): Initialise max_depth field.
4001         (val_print_scalar_or_string_type_p): New function.
4002         (val_print): Check to see if the max depth has been reached.
4003         (val_print_check_max_depth): Define new function.
4004         (show_print_max_depth): New function.
4005         (_initialize_valprint): Add 'print max-depth' option.
4006         * valprint.h (struct value_print_options) <max_depth>: New field.
4007         (val_print_check_max_depth): Declare new function.
4008         * NEWS: Document new feature.
4009
4010 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4011
4012         * ada-lang.c (ada_language_defn): Initialise new field.
4013         * c-lang.c (c_is_string_type_p): New function.
4014         (c_language_defn): Initialise new field.
4015         (cplus_language_defn): Initialise new field.
4016         (asm_language_defn): Initialise new field.
4017         (minimal_language_defn): Initialise new field.
4018         * c-lang.h (c_is_string_type_p): Declare new function.
4019         * d-lang.c (d_language_defn): Initialise new field.
4020         * f-lang.c (f_is_string_type_p): New function.
4021         (f_language_defn): Initialise new field.
4022         * go-lang.c (go_is_string_type_p): New function.
4023         (go_language_defn): Initialise new field.
4024         * language.c (default_is_string_type_p): New function.
4025         (unknown_language_defn): Initialise new field.
4026         (auto_language_defn): Initialise new field.
4027         * language.h (struct language_defn) <la_is_string_type_p>: New
4028         member variable.
4029         (default_is_string_type_p): Declare new function.
4030         * m2-lang.c (m2_language_defn): Initialise new field.
4031         * objc-lang.c (objc_language_defn): Initialise new field.
4032         * opencl-lang.c (opencl_language_defn): Initialise new field.
4033         * p-lang.c (pascal_is_string_type_p): New function.
4034         (pascal_language_defn): Initialise new field.
4035         * rust-lang.c (rust_is_string_type_p): New function.
4036         (rust_language_defn): Initialise new field.
4037
4038 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4041         New field.
4042         * ada-lang.c (ada_language_defn): Initialise new field.
4043         * c-lang.c (c_language_defn): Likewise.
4044         (cplus_language_defn): Likewise.
4045         (asm_language_defn): Likewise.
4046         (minimal_language_defn): Likewise.
4047         * d-lang.c (d_language_defn): Likewise.
4048         * f-lang.c (f_language_defn): Likewise.
4049         * go-lang.c (go_language_defn): Likewise.
4050         * language.c (unknown_language_defn): Likewise.
4051         (auto_language_defn): Likewise.
4052         * m2-lang.c (m2_language_defn): Likewise.
4053         * objc-lang.c (objc_language_defn): Likewise.
4054         * opencl-lang.c (opencl_language_defn): Likewise.
4055         * p-lang.c (pascal_language_defn): Likewise.
4056         * rust-lang.c (rust_language_defn): Likewise.
4057
4058 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4059
4060         * ada-lang.c (ada_is_character_type): Change return type to bool.
4061         (ada_is_string_type): Likewise.
4062         * ada-lang.h (ada_is_character_type): Update declaration
4063         (ada_is_string_type): Likewise.
4064
4065 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4066
4067         Support style in 'frame|thread apply'
4068
4069         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4070         * record.c (record_start, record_stop): Update callers of
4071         execute_command_to_string with false.
4072         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4073         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4074         methods.
4075         (class string_file): New constructor with term_out parameter.
4076         Override methods term_out and can_emit_style_escape.  New member
4077         term_out.
4078         (class stdio_file): Override can_emit_style_escape.
4079         (class tee_file): Override term_out and can_emit_style_escape.
4080         * utils.h (can_emit_style_escape): Remove.
4081         * utils.c (can_emit_style_escape): Likewise.
4082         Update all callers of can_emit_style_escape (SOMESTREAM) to
4083         SOMESTREAM->can_emit_style_escape.
4084         * source-cache.c (source_cache::get_source_lines): Likewise.
4085         * stack.c (frame_apply_command_count): Call execute_command_to_string
4086         passing the term_out characteristic of the current gdb_stdout.
4087         * thread.c (thr_try_catch_cmd): Likewise.
4088         * top.c (execute_command_to_string): pass term_out parameter
4089         to construct the string_file for the command output.
4090         * ui-file.c (term_cli_styling): New function (most code moved
4091         from utils.c can_emit_style_escape).
4092         (string_file::string_file, string_file::can_emit_style_escape,
4093         stdio_file::can_emit_style_escape, tee_file::term_out,
4094         tee_file::can_emit_style_escape): New functions.
4095
4096 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4097
4098         * NEWS: Mention the new set|show may-call-functions.
4099         * infcall.c (may_call_functions_p): New variable.
4100         (show_may_call_functions_p): New function.
4101         (call_function_by_hand_dummy): Throws an error if not
4102         may-call-functions.
4103         (_initialize_infcall): Call add_setshow_boolean_cmd for
4104         may-call-functions.
4105
4106 2019-04-25  Keith Seitz  <keiths@redhat.com>
4107
4108         PR c++/24367
4109         * cp-support.c (inspect_type): Don't attempt substitutions
4110         of symbol with the same name.
4111
4112 2019-04-25  Tom Tromey  <tromey@adacore.com>
4113
4114         PR gdb/24475:
4115         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4116         static.
4117
4118 2019-04-25  Tom Tromey  <tromey@adacore.com>
4119
4120         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4121         rvalue reference.
4122         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4123         (gdb_xml_parser::parse): Use std::move.
4124         * python/python-internal.h (gdbpy_convert_exception): Take a const
4125         reference.
4126         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4127         std::move.
4128         * python/py-utils.c (gdbpy_convert_exception): Take a const
4129         reference.
4130         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4131         Use std::move.
4132         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4133         Use std::move.
4134         * mi/mi-main.c (mi_print_exception): Take a const reference.
4135         * main.c (handle_command_errors): Take a const reference.
4136         * linespec.c (parse_linespec): Use std::move.
4137         * infcall.c (run_inferior_call): Use std::move.
4138         (call_function_by_hand_dummy): Use std::move.
4139         * exec.c (try_open_exec_file): Use std::move.
4140         * exceptions.h (exception_print, exception_fprintf)
4141         (exception_print_same): Update.
4142         * exceptions.c (print_exception, exception_print)
4143         (exception_fprintf, exception_print_same): Change parameters to
4144         const reference.
4145         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4146         * common/new-op.c: Use std::move.
4147         * common/common-exceptions.h (struct gdb_exception): Add move
4148         constructor.
4149         (struct gdb_exception_error, struct gdb_exception_quit, struct
4150         gdb_quit_bad_alloc): Change constructor to move constructor.
4151         (throw_exception): Change parameter to rvalue reference.
4152         * common/common-exceptions.c (throw_exception): Take rvalue
4153         reference.
4154         * cli/cli-interp.c (safe_execute_command): Use std::move.
4155         * breakpoint.c (insert_bp_location, location_to_sals): Use
4156         std::move.
4157
4158 2019-04-25  Tom Tromey  <tromey@adacore.com>
4159
4160         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4161         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4162         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4163         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4164         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4165         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4166         guile/scm-value.c: Use unpack.
4167         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4168         gdbscm_gdb_exception.
4169         (gdbscm_throw_gdb_exception): Likewise.
4170         (struct gdbscm_gdb_exception): New.
4171         (unpack): New function.
4172         (gdbscm_wrap): Use unpack.
4173
4174 2019-04-25  Tom Tromey  <tromey@adacore.com>
4175
4176         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4177         (gdb_rl_callback_handler): Use std::move.
4178         * common/common-exceptions.h (struct gdb_exception): Add move
4179         assignment operator.
4180         (throw_exception_sjlj): Change "exception" to const reference.
4181         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4182         (throw_exception_sjlj): Change "exception" to const reference.
4183
4184 2019-04-25  Tom Tromey  <tromey@adacore.com>
4185
4186         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4187         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4188         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4189         Update.
4190         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4191         Update.
4192         * mi/mi-interp.c (mi_interp::exec): Update.
4193         * linespec.c (parse_linespec): Update.
4194         * infcall.c (run_inferior_call): Update.
4195         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4196         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4197         (gdbscm_lookup_global_symbol): Update.
4198         * guile/scm-param.c (gdbscm_parameter_value): Update.
4199         * guile/scm-frame.c (gdbscm_frame_read_register)
4200         (gdbscm_frame_read_var): Update.
4201         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4202         * exec.c (try_open_exec_file): Update.
4203         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4204         (gdb_rl_callback_handler): Update.
4205         * common/common-exceptions.h (exception_none): Don't declare.
4206         * common/common-exceptions.c (exception_none): Don't define.
4207         (struct catcher) <exception>: Update.
4208         * cli/cli-interp.c (safe_execute_command): Update.
4209         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4210
4211 2019-04-25  Ali Tamur  <tamur@google.com>
4212
4213         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4214         (read_attribute_value): Likewise.
4215         (dwarf2_read_addr_index): Update comment.
4216         (read_str_index): Add DW_FORM_strx.
4217         (dwarf2_string_attr): Likewise.
4218         (dwarf2_const_value_attr): Likewise.
4219         (dump_die_shallow): Likewise.
4220         (dwarf2_fetch_constant_bytes): Likewise.
4221         (skip_form_bytes): Likewise.
4222         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4223
4224 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4225
4226         PR corefiles/11608
4227         PR corefiles/18187
4228         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4229         OFFSET.  Verify if current mapping contains an ELF header.
4230         (linux_find_memory_regions_full): Adjust call to
4231         dump_mapping_p.
4232
4233 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4234             Kang Li <kanglictf@gmail.com>
4235
4236         PR gdb/21600
4237
4238         * dwarf2-frame.c (read_initial_length): Be consistent about using
4239         unsigned representation of length.
4240         (decode_frame_entry_1): Likewise.  Check for wraparound of
4241         end pointer as well as buffer overflow.
4242
4243 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4244
4245         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4246         "vq".
4247
4248 2019-04-24  Tom Tromey  <tromey@adacore.com>
4249
4250         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4251
4252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4253
4254         * s12z-tdep.c (s12z_unwind_pc): Delete.
4255         (s12z_unwind_sp): Delete.
4256         (s12z_gdbarch_init): Don't register deleted functions with
4257         gdbarch.
4258
4259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * rl78-tdep.c (rl78_unwind_sp): Delete.
4262         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4263
4264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4267         (xstormy16_unwind_pc): Delete.
4268         (xstormy16_dummy_id): Delete.
4269         (xstormy16_gdbarch_init): Don't register deleted functions with
4270         gdbarch.
4271
4272 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4273
4274         * vax-tdep.c (vax_unwind_pc): Delete.
4275         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4276
4277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4278
4279         * v850-tdep.c (v850_unwind_sp): Delete.
4280         (v850_unwind_pc): Delete.
4281         (v850_dummy_id): Delete.
4282         (v850_gdbarch_init): Don't register deleted functions with
4283         gdbarch.
4284
4285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4286
4287         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4288         (tilegx_unwind_pc): Delete.
4289         (tilegx_unwind_dummy_id): Delete.
4290         (tilegx_gdbarch_init): Don't register deleted functions with
4291         gdbarch.
4292
4293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4294
4295         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4296         (tic6x_dummy_id): Delete.
4297         (tic6x_gdbarch_init): Don't register deleted functions with
4298         gdbarch.
4299
4300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4301
4302         * sparc-tdep.c (sparc_unwind_pc): Delete.
4303         (sparc32_gdbarch_init): Don't register deleted function with
4304         gdbarch.
4305
4306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * sh-tdep.c (sh_unwind_sp): Delete.
4309         (sh_unwind_pc): Delete.
4310         (sh_dummy_id): Delete.
4311         (sh_gdbarch_init): Don't register deleted functions with
4312         gdbarch.
4313
4314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * score-tdep.c (score_unwind_sp): Delete.
4317         (score_unwind_pc): Delete.
4318         (score_dummy_id): Delete.
4319         (score_gdbarch_init): Don't register deleted functions with
4320         gdbarch.
4321
4322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4323
4324         * rx-tdep.c (rx_unwind_pc): Delete.
4325         (rx_unwind_sp): Delete.
4326         (rx_dummy_id): Delete.
4327         (rx_gdbarch_init): Don't register deleted functions with
4328         gdbarch.  Update comment.
4329
4330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4331
4332         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4333         (rs6000_dummy_id): Delete.
4334         (rs6000_gdbarch_init): Don't register deleted functions with
4335         gdbarch.
4336
4337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4338
4339         * or1k-tdep.c (or1k_dummy_id): Delete.
4340         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4341
4342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4343
4344         * nios2-tdep.c (nios2_dummy_id): Delete.
4345         (nios2_unwind_sp): Delete.
4346         (nios2_gdbarch_init): Don't register deleted functions with
4347         gdbarch.
4348
4349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         * nds32-tdep.c (nds32_dummy_id): Delete.
4352         (nds32_unwind_pc): Delete.
4353         (nds32_unwind_sp): Delete.
4354         (nds32_gdbarch_init): Don't register deleted functions with
4355         gdbarch.
4356
4357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4358
4359         * msp430-tdep.c (msp430_unwind_pc): Delete.
4360         (msp430_unwind_sp): Delete.
4361         (msp430_dummy_id): Delete.
4362         (msp430_gdbarch_init): Don't register deleted functions with
4363         gdbarch.
4364
4365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4366
4367         * moxie-tdep.c (moxie_unwind_sp): Delete.
4368         (moxie_unwind_pc): Delete.
4369         (moxie_dummy_id): Delete.
4370         (moxie_gdbarch_init): Don't register deleted functions with
4371         gdbarch.
4372
4373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4376         (mn10300_unwind_pc): Delete.
4377         (mn10300_unwind_sp): Delete.
4378         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4379         mn10300_unwind_sp.
4380         (mn10300_frame_unwind_init): Don't register deleted functions with
4381         gdbarch.
4382
4383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4384
4385         * mep-tdep.c (mep_unwind_pc): Delete.
4386         (mep_unwind_sp): Delete.
4387         (mep_dummy_id): Delete.
4388         (mep_gdbarch_init): Don't register deleted functions with
4389         gdbarch.
4390
4391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4392
4393         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4394         (m68hc11_unwind_sp): Delete.
4395         (m68hc11_gdbarch_init): Don't register deleted functions with
4396         gdbarch.
4397
4398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4399
4400         * m32r-tdep.c (m32r_unwind_sp): Delete.
4401         (m32r_unwind_pc): Delete.
4402         (m32r_dummy_id): Delete.
4403         (m32r_gdbarch_init): Don't register deleted functions with
4404         gdbarch.
4405
4406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4407
4408         * m32c-tdep.c (m32c_unwind_pc): Delete.
4409         (m32c_unwind_sp): Delete.
4410         (m32c_dummy_id): Delete.
4411         (m32c_gdbarch_init): Don't register deleted functions with
4412         gdbarch.
4413
4414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4415
4416         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4417         (lm32_unwind_pc): Delete.
4418         (lm32_dummy_id): Delete.
4419         (lm32_gdbarch_init): Don't register deleted functions with
4420         gdbarch.
4421
4422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4423
4424         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4425         (iq2000_unwind_pc): Delete.
4426         (iq2000_dummy_id): Delete.
4427         (iq2000_gdbarch_init): Don't register deleted functions with
4428         gdbarch.
4429
4430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4431
4432         * nds32-tdep.c (nds32_type_align): Delete.
4433         (nds32_push_dummy_call): Use type_align instead.
4434
4435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4436
4437         * arm-tdep.c (arm_type_align): Only handle vector override case.
4438         (arm_push_dummy_call): Use type_align.
4439         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4440
4441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4442
4443         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4444         case.
4445         (pass_on_stack): Use type_align.
4446         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4447         function.
4448
4449 2019-04-23  Tom Tromey  <tromey@adacore.com>
4450
4451         * dwarf2read.c (line_header::file_name_at): Remove unused
4452         overload.
4453
4454 2019-04-23  Tom de Vries  <tdevries@suse.de>
4455
4456         PR gdb/24438
4457         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4458         invocation.
4459
4460
4461 2019-03-27  Ali Tamur  <tamur@google.com>
4462
4463         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4464         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4465         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4466         (dwarf_expr_context::get_addr_index): Likewise
4467         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4468         (symbol_needs_eval_context::get_addr_index): Likewise
4469         (disassemble_dwarf_expression): Add DW_OP_addrx
4470         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4471         (read_cutu_die_from_dwo): Update comment
4472         (skip_one_die): Add DW_FORM_addrx
4473         (read_attribute_value): Likewise
4474         (var_decode_location): Add DW_OP_addrx
4475         (dwarf2_const_value_attr): Add DW_FORM_addrx
4476         (dump_die_shallow): Likewise
4477         (dwarf2_fetch_constant_bytes): Likewise
4478         (decode_locdesc): Add DW_OP_addrx
4479         (skip_form_bytes): Add DW_FORM_addrx
4480
4481 2019-04-22  Ali Tamur  <tamur@google.com>
4482
4483         * MAINTAINERS (Write After Approval): Add self.
4484
4485 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4486
4487         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4488         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4489         (open_symbol_file_object): Likewise.
4490         (svr4_default_sos): Add info parameter.
4491         (svr4_read_so_list): Likewise.
4492         (svr4_current_sos_direct): Adjust functions calls to pass down
4493         info.
4494         (svr4_current_sos_1): Add info parameter.
4495         (svr4_current_sos): Call get_svr4_info, pass info down to
4496         svr4_current_sos_1.
4497         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4498         get_svr4_info.
4499         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4500         get_svr4_info.
4501         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4502         to get_svr4_info.
4503         (probes_table_remove_objfile_probes): Likewise.
4504         (register_solib_event_probe): Add info parameter.
4505         (solist_update_incremental): Pass info parameter down to
4506         svr4_read_so_list.
4507         (disable_probes_interface): Add info parameter.
4508         (svr4_handle_solib_event): Pass current_program_space to
4509         get_svr4_info.  Adjust disable_probes_interface cleanup.
4510         (svr4_create_probe_breakpoints): Add info parameter, pass it
4511         down to register_solib_event_probe.
4512         (svr4_create_solib_event_breakpoints): Add info parameter,
4513         pass it down to svr4_create_probe_breakpoints.
4514         (enable_break): Pass info down to
4515         svr4_create_solib_event_breakpoints.
4516         (svr4_solib_create_inferior_hook): Pass current_program_space to
4517         get_svr4_info.
4518         (svr4_clear_solib): Likewise.
4519
4520 2019-04-22  Pedro Alves  <palves@redhat.com>
4521
4522         * solib-svr4.c (svr4_free_objfile_observer): New.
4523         (probe_and_action::objfile): New field.
4524         (probes_table_htab_remove_objfile_probes)
4525         (probes_table_remove_objfile_probes): New functions.
4526         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4527         in the new probe_and_action.  Don't store the probe in 'lookup'.
4528         (svr4_create_probe_breakpoints): Pass objfile to
4529         register_solib_event_probe.
4530         (_initialize_svr4_solib): Register a free_objfile observer.
4531
4532 2019-04-19  Tom Tromey  <tom@tromey.com>
4533
4534         * common/queue.h: Remove.
4535
4536 2019-04-19  Tom Tromey  <tom@tromey.com>
4537
4538         * event-loop.c: Don't include "common/queue.h".
4539
4540 2019-04-19  Tom Tromey  <tom@tromey.com>
4541
4542         * remote.c (remote_target): Use delete.
4543         * remote-notif.h: Include <list>, not "common/queue.h".
4544         (notif_client_p): Remove typedef.
4545         (remote_notif_state): Add constructor, destructor, initializer.
4546         <notif_queue>: Now a std::list.
4547         (remote_notif_state_xfree): Don't declare.
4548         * remote-notif.c (remote_notif_process, handle_notification)
4549         (remote_notif_state_allocate): Update.
4550         (~remote_notif_state): Rename from remote_notif_state_xfree.
4551
4552 2019-04-19  Tom Tromey  <tom@tromey.com>
4553
4554         * symfile.c (reread_symbols): Update.
4555         * objfiles.c (objfile_register_static_link)
4556         (objfile_lookup_static_link): Update
4557         (~objfile) Don't delete static_links.
4558         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4559
4560 2019-04-19  Tom Tromey  <tom@tromey.com>
4561
4562         * type-stack.h (struct type_stack) <insert>: Constify string.
4563         * type-stack.c (type_stack::insert): Constify string.
4564         * gdbtypes.h (lookup_template_type): Update.
4565         (address_space_name_to_int): Update.
4566         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4567         const.
4568         (lookup_template_type): Make name const.
4569         * c-exp.y: Update rules.
4570         (lex_one_token, classify_name, classify_inner_name)
4571         (c_print_token): Update.
4572         * p-exp.y: Update rules.
4573         (yylex): Update.
4574         * f-exp.y: Update rules.
4575         (yylex): Update.
4576         * d-exp.y: Update rules.
4577         (lex_one_token, classify_name, classify_inner_name): Update.
4578         * parse.c (write_dollar_variable, copy_name): Return std::string.
4579         * parser-defs.h (copy_name): Change return type.
4580         * m2-exp.y: Update rules.
4581         (yylex): Update.
4582         * go-exp.y (lex_one_token): Update.
4583         Update rules.
4584         (classify_unsafe_function, classify_packaged_name)
4585         (classify_name, yylex): Update.
4586
4587 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4588
4589         * configure.ac: add --enable-source-highlight switch.
4590         * configure: Regenerate.
4591         * top.c (print_gdb_version): plumb --enable-source-highlight
4592         status to "show configuration".
4593
4594 2019-04-19  Tom Tromey  <tromey@adacore.com>
4595
4596         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4597         Check ADA_TYPE_P.
4598         (empty_record, ada_template_to_fixed_record_type_1)
4599         (template_to_static_fixed_type)
4600         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4601         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4602         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4603         macros.
4604
4605 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4606
4607         PR symtab/24423:
4608         * source.c (print_source_lines_base): Advance "iter" when a
4609         control character is seen.
4610
4611 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4612
4613         * inferior.h (struct infcall_suspend_state_deleter):
4614         Catch exception in destructor to avoid crash.
4615
4616 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4617
4618         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4619         close to the add_com "shell".
4620
4621 2019-04-18  Tom Tromey  <tromey@adacore.com>
4622
4623         * process-stratum-target.h (class process_stratum_target)
4624         <stratum>: Add "final".
4625
4626 2019-04-17  Tom Tromey  <tromey@adacore.com>
4627
4628         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4629         against nullptr before use.
4630
4631 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4632
4633         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4634
4635 2019-04-17  Jim Wilson  <jimw@sifive.com>
4636             Andrew Burgess  <andrew.burgess@embecosm.com>
4637
4638         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4639         code read might fail, assume 4-byte breakpoint in that case.
4640
4641 2019-04-15  Leszek Swirski  <leszeks@google.com>
4642
4643         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4644         rather than a hand-rolled POD check when checking for forced MEMORY
4645         classification.
4646
4647 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4648
4649         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4650         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4651         function.
4652         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4653         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4654         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4655         declaration.
4656
4657 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4658
4659         * aarch64-linux-nat.c
4660         (aarch64_linux_nat_target::thread_architecture): Add override.
4661         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4662         each VQ.
4663
4664 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4665
4666         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4667
4668 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4669
4670         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4671         target types of size 96-bits, add some additional comments, and
4672         check that the builtin type we found was the correct size.
4673
4674 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4675
4676         * utils.c (prompt_for_continue): Don't restore the styling at the
4677         end, as applied_style has the wrong value.  This fixes styling in
4678         long lists of file names that are interrupted by the "Continue?"
4679         prompt.
4680
4681 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4682
4683         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4684         * c-lang.c (c_language_defn): Likewise.
4685         (cplus_language_defn): Likewise.
4686         (asm_language_defn): Likewise.
4687         (minimal_language_defn): Likewise.
4688         * d-lang.c (d_language_defn): Likewise.
4689         * f-lang.c (f_language_defn): Likewise.
4690         * go-lang.c (go_language_defn): Likewise.
4691         * language.c (unknown_language_defn): Likewise.
4692         (auto_language_defn): Likewise.
4693         * language.h (struct language_defn): Remove la_magic field.
4694         (LANG_MAGIC): Delete.
4695         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4696         * objc-lang.c (objc_language_defn): Likewise.
4697         * opencl-lang.c (opencl_language_defn): Likewise.
4698         * p-lang.c (pascal_language_defn): Likewise.
4699         * rust-lang.c (rust_language_defn): Likewise.
4700
4701 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4702
4703         * riscv-tdep.c (riscv_type_align): New function.
4704         (riscv_type_alignment): Delete.
4705         (riscv_arg_location): Use 'type_align'.
4706         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4707
4708 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * gdbtypes.c (type_align): A struct with no non-static fields also
4711         has alignment of 1.
4712
4713 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4714
4715         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4716         component to 0.
4717         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4718         member.
4719         (riscv_struct_info::analyse): New implementation using new
4720         analyse_inner member function.
4721         (riscv_struct_info::field_offset): New member function.
4722         (riscv_struct_info::m_offsets): New member variable.
4723         (riscv_struct_info::analyse_inner): New private member function,
4724         takes the old implementation of riscv_struct_info::analyse but
4725         extended to track field offsets.
4726         (riscv_call_arg_struct): Update the struct folding special cases
4727         to handle cases where empty C++ structs, which are non-zero
4728         length, are found.
4729         (riscv_arg_location): Initialise the length of each location, a
4730         non-zero length now indicates the location is in use.
4731         (riscv_push_dummy_call): Allow for the first location having a
4732         non-zero offset when setting up arguments.
4733         (riscv_return_value): Likewise, but for return values.
4734
4735 2019-04-11  Tom Tromey  <tromey@adacore.com>
4736
4737         * utils.c (internal_vproblem): Make "msg" const.
4738
4739 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4740
4741         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4742         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4743         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4744         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4745
4746 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4747
4748         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4749         function.
4750         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4751         of amd64_collect_native_gregset.
4752         (amd64_linux_nat_target::store_registers): Likewise.
4753
4754 2019-04-10  Tom Tromey  <tom@tromey.com>
4755
4756         * symtab.c (lookup_global_symbol_from_objfile)
4757         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4758         * objfiles.h (class separate_debug_iterator): New.
4759         (class separate_debug_range): New.
4760         (struct objfile) <separate_debug_objfiles>: New method.
4761         (objfile_separate_debug_iterate): Don't declare.
4762         * objfiles.c (separate_debug_iterator::operator++): Rename from
4763         objfile_separate_debug_iterate.
4764         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4765         iterator.
4766         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4767         iterator.
4768
4769 2019-04-10  Tom Tromey  <tom@tromey.com>
4770
4771         * symfile.c (reread_symbols): Remove old comment.
4772         * objfiles.c (free_all_objfiles): Fix a typo.
4773
4774 2019-04-10  Tom Tromey  <tom@tromey.com>
4775
4776         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4777         * minsyms.c (lookup_minimal_symbol): Use foreach.
4778         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4779         (lookup_minimal_symbol_solib_trampoline): Likewise.
4780         * symfile.c (reread_symbols): Use foreach.
4781
4782 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4783             Tom Tromey  <tromey@adacore.com>
4784
4785         PR rust/24414:
4786         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4787         (rust_lex_int_test): Change "value" to be LONGEST.
4788         (rust_lex_tests): Add test for long integer literal.
4789
4790 2019-04-09  Tom Tromey  <tromey@adacore.com>
4791
4792         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4793         to bool.
4794         (extended_remote_target::attach): Update.
4795         (remote_target::remote_notice_new_inferior): Update.
4796         (remote_target::add_current_inferior_and_thread): Update.
4797         * inferior.c (exit_inferior_1): Use "false".
4798         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4799
4800 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4801
4802         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4803         the "start" command.
4804
4805 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4806
4807         * python/py-inferior.c (infpy_thread_from_thread_handle):
4808         Adjust comments to reflect renaming of thread_from_thread_handle
4809         to thread_from_handle.  Adjust keywords.  Fix type error message.
4810         (inferior_object_methods): Add thread_from_handle.  Retain
4811         thread_from_thread_handle, but mark it as deprecated.
4812
4813 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4814
4815         * gdbthread.h (find_thread_by_handle): Revise declaration.
4816         * thread.c (find_thread_by_handle): Likewise.  Adjust
4817         implementation too.
4818         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4819         support for buffer objects as handles.
4820
4821 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4822
4823         * python/py-infthread.c (thpy_thread_handle): New function.
4824         (thread_object_methods): Register thpy_thread_handle.
4825
4826 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4827
4828         * gdbthread.h (thread_to_thread_handle): Declare.
4829         * thread.c (gdbtypes.h): Include.
4830         (thread_to_thread_handle): New function.
4831
4832         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4833         (target_thread_info_to_thread_handle): Declare.
4834         * target.c (target_thread_info_to_thread_handle): New function.
4835         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4836         * target-delegates.c: Regenerate.
4837
4838         * linux-thread-db.c (class thread_db_target): Add method
4839         thread_info_to_thread_handle.
4840         (thread_db_target::thread_info_to_thread_handle): Define.
4841         * remote.c (class remote_target): Add new method
4842         thread_info_to_thread_handle.
4843         (remote_target::thread_info_to_thread_handle): Define.
4844
4845 2019-04-08  Pedro Alves  <palves@redhat.com>
4846
4847         * common/common-exceptions.c (throw_exception): Don't create
4848         named object to throw; throw directly.
4849         (throw_it): Likewise.  Don't initialize gdb_exception::message
4850         here, with new; pass FMT and AP to the ctor instead.
4851         * common/common-exceptions.h: Include <string>.
4852         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4853         const char *, va_list)): New ctor.  Use std::make_shared.
4854         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4855         errors)): Delete.
4856         (gdb_exception_error::gdb_exception_error(enum errors, const char
4857         *, va_list)): New.
4858         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4859         Add assertion.
4860         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4861         errors)): Delete.
4862         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4863         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4864         Add assertion.
4865
4866 2019-04-08  Tom Tromey  <tom@tromey.com>
4867
4868         * valops.c (value_rtti_indirect_type): Replace throw_exception
4869         with throw.
4870         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4871         with throw.
4872         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4873         throw.
4874         * target.c (target_translate_tls_address): Replace throw_exception
4875         with throw.
4876         * stack.c (frame_apply_command_count): Replace throw_exception
4877         with throw.
4878         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4879         throw.
4880         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4881         with throw.
4882         * rs6000-tdep.c (rs6000_frame_cache)
4883         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4884         * remote.c: Replace throw_exception with throw.
4885         * record-full.c (record_full_message, record_full_wait_1)
4886         (record_full_restore): Replace throw_exception with throw.
4887         * record-btrace.c:
4888         (get_thread_current_frame_id, record_btrace_start_replaying)
4889         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4890         (cmd_record_btrace_start): Replace throw_exception with throw.
4891         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4892         throw.
4893         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4894         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4895         * linespec.c:
4896         (find_linespec_symbols): Replace throw_exception with throw.
4897         * infrun.c (displaced_step_prepare, resume): Replace
4898         throw_exception with throw.
4899         * infcmd.c (post_create_inferior): Replace throw_exception with
4900         throw.
4901         * inf-loop.c (inferior_event_handler): Replace throw_exception
4902         with throw.
4903         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4904         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4905         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4906         (get_prev_frame_always, get_frame_pc_if_available)
4907         (get_frame_address_in_block_if_available, get_frame_language):
4908         Replace throw_exception with throw.
4909         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4910         throw_exception with throw.
4911         * eval.c (fetch_subexp_value, evaluate_var_value)
4912         (evaluate_funcall, evaluate_subexp_standard): Replace
4913         throw_exception with throw.
4914         * dwarf2loc.c (call_site_find_chain)
4915         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4916         Replace throw_exception with throw.
4917         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4918         with throw.
4919         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4920         throw.
4921         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4922         * completer.c (complete_line_internal): Replace throw_exception
4923         with throw.
4924         * compile/compile-object-run.c (compile_object_run): Replace
4925         throw_exception with throw.
4926         * cli/cli-script.c (process_next_line): Replace throw_exception
4927         with throw.
4928         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4929         (btrace_enable, btrace_maint_update_pt_packets): Replace
4930         throw_exception with throw.
4931         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4932         throw_exception with throw.
4933         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4934         throw_exception with throw.
4935         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4936         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4937         * aarch64-tdep.c (aarch64_make_prologue_cache)
4938         (aarch64_make_stub_cache): Replace throw_exception with throw.
4939
4940 2019-04-08  Tom Tromey  <tom@tromey.com>
4941
4942         * common/common-exceptions.c (throw_exception): Rename from
4943         throw_exception_cxx.  Remove old copy.  Make argument const.
4944         (throw_it): Create and throw exception objects directly.
4945         * common/common-exceptions.h (throw_exception): Make argument
4946         const.
4947         (struct gdb_exception_error): Add constructor.
4948         (struct gdb_exception_quit): Add constructor.
4949
4950 2019-04-08  Tom Tromey  <tom@tromey.com>
4951
4952         * common/common-exceptions.h (exception_rethrow): Don't declare.
4953         (TRY_SJLJ): Update comment.
4954         (TRY, CATCH, END_CATCH): Remove.
4955         * common/common-exceptions.c (exception_rethrow): Remove.
4956
4957 2019-04-08  Tom Tromey  <tom@tromey.com>
4958
4959         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4960         Remove.
4961         (gdb_exception_error): Rename from
4962         gdb_exception_RETURN_MASK_ERROR.
4963         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4964         (gdb_quit_bad_alloc): Update.
4965         * aarch64-tdep.c: Update.
4966         * ada-lang.c: Update.
4967         * ada-typeprint.c: Update.
4968         * ada-valprint.c: Update.
4969         * amd64-tdep.c: Update.
4970         * arch-utils.c: Update.
4971         * break-catch-throw.c: Update.
4972         * breakpoint.c: Update.
4973         * btrace.c: Update.
4974         * c-varobj.c: Update.
4975         * cli/cli-cmds.c: Update.
4976         * cli/cli-interp.c: Update.
4977         * cli/cli-script.c: Update.
4978         * common/common-exceptions.c: Update.
4979         * common/new-op.c: Update.
4980         * common/selftest.c: Update.
4981         * compile/compile-c-symbols.c: Update.
4982         * compile/compile-cplus-symbols.c: Update.
4983         * compile/compile-object-load.c: Update.
4984         * compile/compile-object-run.c: Update.
4985         * completer.c: Update.
4986         * corelow.c: Update.
4987         * cp-abi.c: Update.
4988         * cp-support.c: Update.
4989         * cp-valprint.c: Update.
4990         * darwin-nat.c: Update.
4991         * disasm-selftests.c: Update.
4992         * dtrace-probe.c: Update.
4993         * dwarf-index-cache.c: Update.
4994         * dwarf-index-write.c: Update.
4995         * dwarf2-frame-tailcall.c: Update.
4996         * dwarf2-frame.c: Update.
4997         * dwarf2loc.c: Update.
4998         * dwarf2read.c: Update.
4999         * eval.c: Update.
5000         * event-loop.c: Update.
5001         * event-top.c: Update.
5002         * exec.c: Update.
5003         * f-valprint.c: Update.
5004         * fbsd-tdep.c: Update.
5005         * frame-unwind.c: Update.
5006         * frame.c: Update.
5007         * gdbtypes.c: Update.
5008         * gnu-v3-abi.c: Update.
5009         * guile/guile-internal.h: Update.
5010         * guile/scm-block.c: Update.
5011         * guile/scm-breakpoint.c: Update.
5012         * guile/scm-cmd.c: Update.
5013         * guile/scm-disasm.c: Update.
5014         * guile/scm-frame.c: Update.
5015         * guile/scm-lazy-string.c: Update.
5016         * guile/scm-math.c: Update.
5017         * guile/scm-param.c: Update.
5018         * guile/scm-ports.c: Update.
5019         * guile/scm-pretty-print.c: Update.
5020         * guile/scm-symbol.c: Update.
5021         * guile/scm-symtab.c: Update.
5022         * guile/scm-type.c: Update.
5023         * guile/scm-value.c: Update.
5024         * i386-linux-tdep.c: Update.
5025         * i386-tdep.c: Update.
5026         * inf-loop.c: Update.
5027         * infcall.c: Update.
5028         * infcmd.c: Update.
5029         * infrun.c: Update.
5030         * jit.c: Update.
5031         * language.c: Update.
5032         * linespec.c: Update.
5033         * linux-fork.c: Update.
5034         * linux-nat.c: Update.
5035         * linux-tdep.c: Update.
5036         * linux-thread-db.c: Update.
5037         * main.c: Update.
5038         * mi/mi-cmd-break.c: Update.
5039         * mi/mi-cmd-stack.c: Update.
5040         * mi/mi-interp.c: Update.
5041         * mi/mi-main.c: Update.
5042         * objc-lang.c: Update.
5043         * p-valprint.c: Update.
5044         * parse.c: Update.
5045         * ppc-linux-tdep.c: Update.
5046         * printcmd.c: Update.
5047         * python/py-arch.c: Update.
5048         * python/py-breakpoint.c: Update.
5049         * python/py-cmd.c: Update.
5050         * python/py-finishbreakpoint.c: Update.
5051         * python/py-frame.c: Update.
5052         * python/py-framefilter.c: Update.
5053         * python/py-gdb-readline.c: Update.
5054         * python/py-inferior.c: Update.
5055         * python/py-infthread.c: Update.
5056         * python/py-lazy-string.c: Update.
5057         * python/py-linetable.c: Update.
5058         * python/py-objfile.c: Update.
5059         * python/py-param.c: Update.
5060         * python/py-prettyprint.c: Update.
5061         * python/py-progspace.c: Update.
5062         * python/py-record-btrace.c: Update.
5063         * python/py-record.c: Update.
5064         * python/py-symbol.c: Update.
5065         * python/py-type.c: Update.
5066         * python/py-unwind.c: Update.
5067         * python/py-utils.c: Update.
5068         * python/py-value.c: Update.
5069         * python/python.c: Update.
5070         * record-btrace.c: Update.
5071         * record-full.c: Update.
5072         * remote-fileio.c: Update.
5073         * remote.c: Update.
5074         * riscv-tdep.c: Update.
5075         * rs6000-aix-tdep.c: Update.
5076         * rs6000-tdep.c: Update.
5077         * rust-exp.y: Update.
5078         * rust-lang.c: Update.
5079         * s390-tdep.c: Update.
5080         * selftest-arch.c: Update.
5081         * solib-dsbt.c: Update.
5082         * solib-frv.c: Update.
5083         * solib-spu.c: Update.
5084         * solib-svr4.c: Update.
5085         * solib.c: Update.
5086         * sparc64-linux-tdep.c: Update.
5087         * stack.c: Update.
5088         * symfile-mem.c: Update.
5089         * symmisc.c: Update.
5090         * target.c: Update.
5091         * thread.c: Update.
5092         * top.c: Update.
5093         * tracefile-tfile.c: Update.
5094         * tui/tui.c: Update.
5095         * typeprint.c: Update.
5096         * unittests/cli-utils-selftests.c: Update.
5097         * unittests/parse-connection-spec-selftests.c: Update.
5098         * valops.c: Update.
5099         * valprint.c: Update.
5100         * value.c: Update.
5101         * varobj.c: Update.
5102         * windows-nat.c: Update.
5103         * x86-linux-nat.c: Update.
5104         * xml-support.c: Update.
5105
5106 2019-04-08  Tom Tromey  <tom@tromey.com>
5107
5108         * xml-support.c: Use C++ exception handling.
5109         * x86-linux-nat.c: Use C++ exception handling.
5110         * windows-nat.c: Use C++ exception handling.
5111         * varobj.c: Use C++ exception handling.
5112         * value.c: Use C++ exception handling.
5113         * valprint.c: Use C++ exception handling.
5114         * valops.c: Use C++ exception handling.
5115         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5116         handling.
5117         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5118         * typeprint.c: Use C++ exception handling.
5119         * tui/tui.c: Use C++ exception handling.
5120         * tracefile-tfile.c: Use C++ exception handling.
5121         * top.c: Use C++ exception handling.
5122         * thread.c: Use C++ exception handling.
5123         * target.c: Use C++ exception handling.
5124         * symmisc.c: Use C++ exception handling.
5125         * symfile-mem.c: Use C++ exception handling.
5126         * stack.c: Use C++ exception handling.
5127         * sparc64-linux-tdep.c: Use C++ exception handling.
5128         * solib.c: Use C++ exception handling.
5129         * solib-svr4.c: Use C++ exception handling.
5130         * solib-spu.c: Use C++ exception handling.
5131         * solib-frv.c: Use C++ exception handling.
5132         * solib-dsbt.c: Use C++ exception handling.
5133         * selftest-arch.c: Use C++ exception handling.
5134         * s390-tdep.c: Use C++ exception handling.
5135         * rust-lang.c: Use C++ exception handling.
5136         * rust-exp.y: Use C++ exception handling.
5137         * rs6000-tdep.c: Use C++ exception handling.
5138         * rs6000-aix-tdep.c: Use C++ exception handling.
5139         * riscv-tdep.c: Use C++ exception handling.
5140         * remote.c: Use C++ exception handling.
5141         * remote-fileio.c: Use C++ exception handling.
5142         * record-full.c: Use C++ exception handling.
5143         * record-btrace.c: Use C++ exception handling.
5144         * python/python.c: Use C++ exception handling.
5145         * python/py-value.c: Use C++ exception handling.
5146         * python/py-utils.c: Use C++ exception handling.
5147         * python/py-unwind.c: Use C++ exception handling.
5148         * python/py-type.c: Use C++ exception handling.
5149         * python/py-symbol.c: Use C++ exception handling.
5150         * python/py-record.c: Use C++ exception handling.
5151         * python/py-record-btrace.c: Use C++ exception handling.
5152         * python/py-progspace.c: Use C++ exception handling.
5153         * python/py-prettyprint.c: Use C++ exception handling.
5154         * python/py-param.c: Use C++ exception handling.
5155         * python/py-objfile.c: Use C++ exception handling.
5156         * python/py-linetable.c: Use C++ exception handling.
5157         * python/py-lazy-string.c: Use C++ exception handling.
5158         * python/py-infthread.c: Use C++ exception handling.
5159         * python/py-inferior.c: Use C++ exception handling.
5160         * python/py-gdb-readline.c: Use C++ exception handling.
5161         * python/py-framefilter.c: Use C++ exception handling.
5162         * python/py-frame.c: Use C++ exception handling.
5163         * python/py-finishbreakpoint.c: Use C++ exception handling.
5164         * python/py-cmd.c: Use C++ exception handling.
5165         * python/py-breakpoint.c: Use C++ exception handling.
5166         * python/py-arch.c: Use C++ exception handling.
5167         * printcmd.c: Use C++ exception handling.
5168         * ppc-linux-tdep.c: Use C++ exception handling.
5169         * parse.c: Use C++ exception handling.
5170         * p-valprint.c: Use C++ exception handling.
5171         * objc-lang.c: Use C++ exception handling.
5172         * mi/mi-main.c: Use C++ exception handling.
5173         * mi/mi-interp.c: Use C++ exception handling.
5174         * mi/mi-cmd-stack.c: Use C++ exception handling.
5175         * mi/mi-cmd-break.c: Use C++ exception handling.
5176         * main.c: Use C++ exception handling.
5177         * linux-thread-db.c: Use C++ exception handling.
5178         * linux-tdep.c: Use C++ exception handling.
5179         * linux-nat.c: Use C++ exception handling.
5180         * linux-fork.c: Use C++ exception handling.
5181         * linespec.c: Use C++ exception handling.
5182         * language.c: Use C++ exception handling.
5183         * jit.c: Use C++ exception handling.
5184         * infrun.c: Use C++ exception handling.
5185         * infcmd.c: Use C++ exception handling.
5186         * infcall.c: Use C++ exception handling.
5187         * inf-loop.c: Use C++ exception handling.
5188         * i386-tdep.c: Use C++ exception handling.
5189         * i386-linux-tdep.c: Use C++ exception handling.
5190         * guile/scm-value.c: Use C++ exception handling.
5191         * guile/scm-type.c: Use C++ exception handling.
5192         * guile/scm-symtab.c: Use C++ exception handling.
5193         * guile/scm-symbol.c: Use C++ exception handling.
5194         * guile/scm-pretty-print.c: Use C++ exception handling.
5195         * guile/scm-ports.c: Use C++ exception handling.
5196         * guile/scm-param.c: Use C++ exception handling.
5197         * guile/scm-math.c: Use C++ exception handling.
5198         * guile/scm-lazy-string.c: Use C++ exception handling.
5199         * guile/scm-frame.c: Use C++ exception handling.
5200         * guile/scm-disasm.c: Use C++ exception handling.
5201         * guile/scm-cmd.c: Use C++ exception handling.
5202         * guile/scm-breakpoint.c: Use C++ exception handling.
5203         * guile/scm-block.c: Use C++ exception handling.
5204         * guile/guile-internal.h: Use C++ exception handling.
5205         * gnu-v3-abi.c: Use C++ exception handling.
5206         * gdbtypes.c: Use C++ exception handling.
5207         * frame.c: Use C++ exception handling.
5208         * frame-unwind.c: Use C++ exception handling.
5209         * fbsd-tdep.c: Use C++ exception handling.
5210         * f-valprint.c: Use C++ exception handling.
5211         * exec.c: Use C++ exception handling.
5212         * event-top.c: Use C++ exception handling.
5213         * event-loop.c: Use C++ exception handling.
5214         * eval.c: Use C++ exception handling.
5215         * dwarf2read.c: Use C++ exception handling.
5216         * dwarf2loc.c: Use C++ exception handling.
5217         * dwarf2-frame.c: Use C++ exception handling.
5218         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5219         * dwarf-index-write.c: Use C++ exception handling.
5220         * dwarf-index-cache.c: Use C++ exception handling.
5221         * dtrace-probe.c: Use C++ exception handling.
5222         * disasm-selftests.c: Use C++ exception handling.
5223         * darwin-nat.c: Use C++ exception handling.
5224         * cp-valprint.c: Use C++ exception handling.
5225         * cp-support.c: Use C++ exception handling.
5226         * cp-abi.c: Use C++ exception handling.
5227         * corelow.c: Use C++ exception handling.
5228         * completer.c: Use C++ exception handling.
5229         * compile/compile-object-run.c: Use C++ exception handling.
5230         * compile/compile-object-load.c: Use C++ exception handling.
5231         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5232         * compile/compile-c-symbols.c: Use C++ exception handling.
5233         * common/selftest.c: Use C++ exception handling.
5234         * common/new-op.c: Use C++ exception handling.
5235         * cli/cli-script.c: Use C++ exception handling.
5236         * cli/cli-interp.c: Use C++ exception handling.
5237         * cli/cli-cmds.c: Use C++ exception handling.
5238         * c-varobj.c: Use C++ exception handling.
5239         * btrace.c: Use C++ exception handling.
5240         * breakpoint.c: Use C++ exception handling.
5241         * break-catch-throw.c: Use C++ exception handling.
5242         * arch-utils.c: Use C++ exception handling.
5243         * amd64-tdep.c: Use C++ exception handling.
5244         * ada-valprint.c: Use C++ exception handling.
5245         * ada-typeprint.c: Use C++ exception handling.
5246         * ada-lang.c: Use C++ exception handling.
5247         * aarch64-tdep.c: Use C++ exception handling.
5248
5249 2019-04-08  Tom Tromey  <tom@tromey.com>
5250
5251         * xml-support.c (gdb_xml_parser::parse): Update.
5252         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5253         * value.c (show_convenience): Update.
5254         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5255         (test_parse_flags_qcs): Update.
5256         * thread.c (thr_try_catch_cmd): Update.
5257         * target.c (target_translate_tls_address): Update.
5258         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5259         (info_frame_command_core, frame_apply_command_count): Update.
5260         * rust-exp.y (rust_lex_exception_test): Update.
5261         * riscv-tdep.c (riscv_print_one_register_info): Update.
5262         * remote.c (remote_target::enable_btrace): Update.
5263         * record-btrace.c (record_btrace_enable_warn): Update.
5264         * python/py-utils.c (gdbpy_convert_exception): Update.
5265         * printcmd.c (do_one_display, print_variable_and_value): Update.
5266         * mi/mi-main.c (mi_print_exception): Update.
5267         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5268         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5269         * linux-nat.c (linux_nat_target::attach): Update.
5270         * linux-fork.c (class scoped_switch_fork_info): Update.
5271         * infrun.c (displaced_step_prepare): Update.
5272         * infcall.c (call_function_by_hand_dummy): Update.
5273         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5274         * gnu-v3-abi.c (print_one_vtable): Update.
5275         * frame.c (get_prev_frame_always): Update.
5276         * f-valprint.c (info_common_command_for_block): Update.
5277         * exec.c (try_open_exec_file): Update.
5278         * exceptions.c (print_exception, exception_print)
5279         (exception_fprintf, exception_print_same): Update.
5280         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5281         * dwarf-index-cache.c (index_cache::store)
5282         (index_cache::lookup_gdb_index): Update.
5283         * darwin-nat.c (maybe_cache_shell): Update.
5284         * cp-valprint.c (cp_print_value_fields): Update.
5285         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5286         (gcc_cplus_symbol_address): Update.
5287         * compile/compile-c-symbols.c (gcc_convert_symbol)
5288         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5289         * common/selftest.c: Update.
5290         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5291         a std::string.
5292         (exception_try_scope_entry, exception_try_scope_exit): Don't
5293         declare.
5294         (struct exception_try_scope): Remove.
5295         (TRY): Don't use exception_try_scope.
5296         (struct gdb_exception): Add constructor, operator=.
5297         <what>: New method.
5298         (struct gdb_exception_RETURN_MASK_ALL)
5299         (struct gdb_exception_RETURN_MASK_ERROR)
5300         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5301         (struct gdb_quit_bad_alloc): Update.
5302         * common/common-exceptions.c (exception_none): Change
5303         initializer.
5304         (struct catcher) <state, exception>: Initialize inline.
5305         <prev>: Remove member.
5306         (current_catcher): Remove.
5307         (catchers): New global.
5308         (exceptions_state_mc_init): Simplify.
5309         (catcher_pop): Remove.
5310         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5311         (try_scope_depth, exception_try_scope_entry)
5312         (exception_try_scope_exit): Remove.
5313         (throw_exception_sjlj): Update.
5314         (exception_messages, exception_messages_size): Remove.
5315         (throw_it): Simplify.
5316         (gdb_exception_sliced_copy): Remove.
5317         (throw_exception_cxx): Update.
5318         * cli/cli-script.c (script_from_file): Update.
5319         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5320         Update.
5321         * ada-valprint.c (ada_val_print): Update.
5322         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5323         (create_excep_cond_exprs): Update.
5324
5325 2019-04-08  Tom Tromey  <tom@tromey.com>
5326
5327         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5328         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5329         (TRY, CATCH, END_CATCH): Remove some definitions.
5330         * common/common-exceptions.c: Don't use GDB_XCPT.
5331         (catcher_list_size): Remove.
5332         (throw_exception, throw_it): Simplify.
5333
5334 2019-04-05  Tom Tromey  <tom@tromey.com>
5335
5336         Revert the header-sorting patch.
5337         * ft32-tdep.c: Revert.
5338         * frv-tdep.c: Revert.
5339         * frv-linux-tdep.c: Revert.
5340         * frame.c: Revert.
5341         * frame-unwind.c: Revert.
5342         * frame-base.c: Revert.
5343         * fork-child.c: Revert.
5344         * findvar.c: Revert.
5345         * findcmd.c: Revert.
5346         * filesystem.c: Revert.
5347         * filename-seen-cache.h: Revert.
5348         * filename-seen-cache.c: Revert.
5349         * fbsd-tdep.c: Revert.
5350         * fbsd-nat.h: Revert.
5351         * fbsd-nat.c: Revert.
5352         * f-valprint.c: Revert.
5353         * f-typeprint.c: Revert.
5354         * f-lang.c: Revert.
5355         * extension.h: Revert.
5356         * extension.c: Revert.
5357         * extension-priv.h: Revert.
5358         * expprint.c: Revert.
5359         * exec.h: Revert.
5360         * exec.c: Revert.
5361         * exceptions.c: Revert.
5362         * event-top.c: Revert.
5363         * event-loop.c: Revert.
5364         * eval.c: Revert.
5365         * elfread.c: Revert.
5366         * dwarf2read.h: Revert.
5367         * dwarf2read.c: Revert.
5368         * dwarf2loc.c: Revert.
5369         * dwarf2expr.h: Revert.
5370         * dwarf2expr.c: Revert.
5371         * dwarf2-frame.c: Revert.
5372         * dwarf2-frame-tailcall.c: Revert.
5373         * dwarf-index-write.h: Revert.
5374         * dwarf-index-write.c: Revert.
5375         * dwarf-index-common.c: Revert.
5376         * dwarf-index-cache.h: Revert.
5377         * dwarf-index-cache.c: Revert.
5378         * dummy-frame.c: Revert.
5379         * dtrace-probe.c: Revert.
5380         * disasm.h: Revert.
5381         * disasm.c: Revert.
5382         * disasm-selftests.c: Revert.
5383         * dictionary.c: Revert.
5384         * dicos-tdep.c: Revert.
5385         * demangle.c: Revert.
5386         * dcache.h: Revert.
5387         * dcache.c: Revert.
5388         * darwin-nat.h: Revert.
5389         * darwin-nat.c: Revert.
5390         * darwin-nat-info.c: Revert.
5391         * d-valprint.c: Revert.
5392         * d-namespace.c: Revert.
5393         * d-lang.c: Revert.
5394         * ctf.c: Revert.
5395         * csky-tdep.c: Revert.
5396         * csky-linux-tdep.c: Revert.
5397         * cris-tdep.c: Revert.
5398         * cris-linux-tdep.c: Revert.
5399         * cp-valprint.c: Revert.
5400         * cp-support.c: Revert.
5401         * cp-namespace.c: Revert.
5402         * cp-abi.c: Revert.
5403         * corelow.c: Revert.
5404         * corefile.c: Revert.
5405         * continuations.c: Revert.
5406         * completer.h: Revert.
5407         * completer.c: Revert.
5408         * complaints.c: Revert.
5409         * coffread.c: Revert.
5410         * coff-pe-read.c: Revert.
5411         * cli-out.h: Revert.
5412         * cli-out.c: Revert.
5413         * charset.c: Revert.
5414         * c-varobj.c: Revert.
5415         * c-valprint.c: Revert.
5416         * c-typeprint.c: Revert.
5417         * c-lang.c: Revert.
5418         * buildsym.c: Revert.
5419         * buildsym-legacy.c: Revert.
5420         * build-id.h: Revert.
5421         * build-id.c: Revert.
5422         * btrace.c: Revert.
5423         * bsd-uthread.c: Revert.
5424         * breakpoint.h: Revert.
5425         * breakpoint.c: Revert.
5426         * break-catch-throw.c: Revert.
5427         * break-catch-syscall.c: Revert.
5428         * break-catch-sig.c: Revert.
5429         * blockframe.c: Revert.
5430         * block.c: Revert.
5431         * bfin-tdep.c: Revert.
5432         * bfin-linux-tdep.c: Revert.
5433         * bfd-target.c: Revert.
5434         * bcache.c: Revert.
5435         * ax-general.c: Revert.
5436         * ax-gdb.h: Revert.
5437         * ax-gdb.c: Revert.
5438         * avr-tdep.c: Revert.
5439         * auxv.c: Revert.
5440         * auto-load.c: Revert.
5441         * arm-wince-tdep.c: Revert.
5442         * arm-tdep.c: Revert.
5443         * arm-symbian-tdep.c: Revert.
5444         * arm-pikeos-tdep.c: Revert.
5445         * arm-obsd-tdep.c: Revert.
5446         * arm-nbsd-tdep.c: Revert.
5447         * arm-nbsd-nat.c: Revert.
5448         * arm-linux-tdep.c: Revert.
5449         * arm-linux-nat.c: Revert.
5450         * arm-fbsd-tdep.c: Revert.
5451         * arm-fbsd-nat.c: Revert.
5452         * arm-bsd-tdep.c: Revert.
5453         * arch-utils.c: Revert.
5454         * arc-tdep.c: Revert.
5455         * arc-newlib-tdep.c: Revert.
5456         * annotate.h: Revert.
5457         * annotate.c: Revert.
5458         * amd64-windows-tdep.c: Revert.
5459         * amd64-windows-nat.c: Revert.
5460         * amd64-tdep.c: Revert.
5461         * amd64-sol2-tdep.c: Revert.
5462         * amd64-obsd-tdep.c: Revert.
5463         * amd64-obsd-nat.c: Revert.
5464         * amd64-nbsd-tdep.c: Revert.
5465         * amd64-nbsd-nat.c: Revert.
5466         * amd64-nat.c: Revert.
5467         * amd64-linux-tdep.c: Revert.
5468         * amd64-linux-nat.c: Revert.
5469         * amd64-fbsd-tdep.c: Revert.
5470         * amd64-fbsd-nat.c: Revert.
5471         * amd64-dicos-tdep.c: Revert.
5472         * amd64-darwin-tdep.c: Revert.
5473         * amd64-bsd-nat.c: Revert.
5474         * alpha-tdep.c: Revert.
5475         * alpha-obsd-tdep.c: Revert.
5476         * alpha-nbsd-tdep.c: Revert.
5477         * alpha-mdebug-tdep.c: Revert.
5478         * alpha-linux-tdep.c: Revert.
5479         * alpha-linux-nat.c: Revert.
5480         * alpha-bsd-tdep.c: Revert.
5481         * alpha-bsd-nat.c: Revert.
5482         * aix-thread.c: Revert.
5483         * agent.c: Revert.
5484         * addrmap.c: Revert.
5485         * ada-varobj.c: Revert.
5486         * ada-valprint.c: Revert.
5487         * ada-typeprint.c: Revert.
5488         * ada-tasks.c: Revert.
5489         * ada-lang.c: Revert.
5490         * aarch64-tdep.c: Revert.
5491         * aarch64-ravenscar-thread.c: Revert.
5492         * aarch64-newlib-tdep.c: Revert.
5493         * aarch64-linux-tdep.c: Revert.
5494         * aarch64-linux-nat.c: Revert.
5495         * aarch64-fbsd-tdep.c: Revert.
5496         * aarch64-fbsd-nat.c: Revert.
5497         * aarch32-linux-nat.c: Revert.
5498
5499 2019-04-05  Tom Tromey  <tom@tromey.com>
5500
5501         * ft32-tdep.c: Sort headers.
5502         * frv-tdep.c: Sort headers.
5503         * frv-linux-tdep.c: Sort headers.
5504         * frame.c: Sort headers.
5505         * frame-unwind.c: Sort headers.
5506         * frame-base.c: Sort headers.
5507         * fork-child.c: Sort headers.
5508         * findvar.c: Sort headers.
5509         * findcmd.c: Sort headers.
5510         * filesystem.c: Sort headers.
5511         * filename-seen-cache.h: Sort headers.
5512         * filename-seen-cache.c: Sort headers.
5513         * fbsd-tdep.c: Sort headers.
5514         * fbsd-nat.h: Sort headers.
5515         * fbsd-nat.c: Sort headers.
5516         * f-valprint.c: Sort headers.
5517         * f-typeprint.c: Sort headers.
5518         * f-lang.c: Sort headers.
5519         * extension.h: Sort headers.
5520         * extension.c: Sort headers.
5521         * extension-priv.h: Sort headers.
5522         * expprint.c: Sort headers.
5523         * exec.h: Sort headers.
5524         * exec.c: Sort headers.
5525         * exceptions.c: Sort headers.
5526         * event-top.c: Sort headers.
5527         * event-loop.c: Sort headers.
5528         * eval.c: Sort headers.
5529         * elfread.c: Sort headers.
5530         * dwarf2read.h: Sort headers.
5531         * dwarf2read.c: Sort headers.
5532         * dwarf2loc.c: Sort headers.
5533         * dwarf2expr.h: Sort headers.
5534         * dwarf2expr.c: Sort headers.
5535         * dwarf2-frame.c: Sort headers.
5536         * dwarf2-frame-tailcall.c: Sort headers.
5537         * dwarf-index-write.h: Sort headers.
5538         * dwarf-index-write.c: Sort headers.
5539         * dwarf-index-common.c: Sort headers.
5540         * dwarf-index-cache.h: Sort headers.
5541         * dwarf-index-cache.c: Sort headers.
5542         * dummy-frame.c: Sort headers.
5543         * dtrace-probe.c: Sort headers.
5544         * disasm.h: Sort headers.
5545         * disasm.c: Sort headers.
5546         * disasm-selftests.c: Sort headers.
5547         * dictionary.c: Sort headers.
5548         * dicos-tdep.c: Sort headers.
5549         * demangle.c: Sort headers.
5550         * dcache.h: Sort headers.
5551         * dcache.c: Sort headers.
5552         * darwin-nat.h: Sort headers.
5553         * darwin-nat.c: Sort headers.
5554         * darwin-nat-info.c: Sort headers.
5555         * d-valprint.c: Sort headers.
5556         * d-namespace.c: Sort headers.
5557         * d-lang.c: Sort headers.
5558         * ctf.c: Sort headers.
5559         * csky-tdep.c: Sort headers.
5560         * csky-linux-tdep.c: Sort headers.
5561         * cris-tdep.c: Sort headers.
5562         * cris-linux-tdep.c: Sort headers.
5563         * cp-valprint.c: Sort headers.
5564         * cp-support.c: Sort headers.
5565         * cp-namespace.c: Sort headers.
5566         * cp-abi.c: Sort headers.
5567         * corelow.c: Sort headers.
5568         * corefile.c: Sort headers.
5569         * continuations.c: Sort headers.
5570         * completer.h: Sort headers.
5571         * completer.c: Sort headers.
5572         * complaints.c: Sort headers.
5573         * coffread.c: Sort headers.
5574         * coff-pe-read.c: Sort headers.
5575         * cli-out.h: Sort headers.
5576         * cli-out.c: Sort headers.
5577         * charset.c: Sort headers.
5578         * c-varobj.c: Sort headers.
5579         * c-valprint.c: Sort headers.
5580         * c-typeprint.c: Sort headers.
5581         * c-lang.c: Sort headers.
5582         * buildsym.c: Sort headers.
5583         * buildsym-legacy.c: Sort headers.
5584         * build-id.h: Sort headers.
5585         * build-id.c: Sort headers.
5586         * btrace.c: Sort headers.
5587         * bsd-uthread.c: Sort headers.
5588         * breakpoint.h: Sort headers.
5589         * breakpoint.c: Sort headers.
5590         * break-catch-throw.c: Sort headers.
5591         * break-catch-syscall.c: Sort headers.
5592         * break-catch-sig.c: Sort headers.
5593         * blockframe.c: Sort headers.
5594         * block.c: Sort headers.
5595         * bfin-tdep.c: Sort headers.
5596         * bfin-linux-tdep.c: Sort headers.
5597         * bfd-target.c: Sort headers.
5598         * bcache.c: Sort headers.
5599         * ax-general.c: Sort headers.
5600         * ax-gdb.h: Sort headers.
5601         * ax-gdb.c: Sort headers.
5602         * avr-tdep.c: Sort headers.
5603         * auxv.c: Sort headers.
5604         * auto-load.c: Sort headers.
5605         * arm-wince-tdep.c: Sort headers.
5606         * arm-tdep.c: Sort headers.
5607         * arm-symbian-tdep.c: Sort headers.
5608         * arm-pikeos-tdep.c: Sort headers.
5609         * arm-obsd-tdep.c: Sort headers.
5610         * arm-nbsd-tdep.c: Sort headers.
5611         * arm-nbsd-nat.c: Sort headers.
5612         * arm-linux-tdep.c: Sort headers.
5613         * arm-linux-nat.c: Sort headers.
5614         * arm-fbsd-tdep.c: Sort headers.
5615         * arm-fbsd-nat.c: Sort headers.
5616         * arm-bsd-tdep.c: Sort headers.
5617         * arch-utils.c: Sort headers.
5618         * arc-tdep.c: Sort headers.
5619         * arc-newlib-tdep.c: Sort headers.
5620         * annotate.h: Sort headers.
5621         * annotate.c: Sort headers.
5622         * amd64-windows-tdep.c: Sort headers.
5623         * amd64-windows-nat.c: Sort headers.
5624         * amd64-tdep.c: Sort headers.
5625         * amd64-sol2-tdep.c: Sort headers.
5626         * amd64-obsd-tdep.c: Sort headers.
5627         * amd64-obsd-nat.c: Sort headers.
5628         * amd64-nbsd-tdep.c: Sort headers.
5629         * amd64-nbsd-nat.c: Sort headers.
5630         * amd64-nat.c: Sort headers.
5631         * amd64-linux-tdep.c: Sort headers.
5632         * amd64-linux-nat.c: Sort headers.
5633         * amd64-fbsd-tdep.c: Sort headers.
5634         * amd64-fbsd-nat.c: Sort headers.
5635         * amd64-dicos-tdep.c: Sort headers.
5636         * amd64-darwin-tdep.c: Sort headers.
5637         * amd64-bsd-nat.c: Sort headers.
5638         * alpha-tdep.c: Sort headers.
5639         * alpha-obsd-tdep.c: Sort headers.
5640         * alpha-nbsd-tdep.c: Sort headers.
5641         * alpha-mdebug-tdep.c: Sort headers.
5642         * alpha-linux-tdep.c: Sort headers.
5643         * alpha-linux-nat.c: Sort headers.
5644         * alpha-bsd-tdep.c: Sort headers.
5645         * alpha-bsd-nat.c: Sort headers.
5646         * aix-thread.c: Sort headers.
5647         * agent.c: Sort headers.
5648         * addrmap.c: Sort headers.
5649         * ada-varobj.c: Sort headers.
5650         * ada-valprint.c: Sort headers.
5651         * ada-typeprint.c: Sort headers.
5652         * ada-tasks.c: Sort headers.
5653         * ada-lang.c: Sort headers.
5654         * aarch64-tdep.c: Sort headers.
5655         * aarch64-ravenscar-thread.c: Sort headers.
5656         * aarch64-newlib-tdep.c: Sort headers.
5657         * aarch64-linux-tdep.c: Sort headers.
5658         * aarch64-linux-nat.c: Sort headers.
5659         * aarch64-fbsd-tdep.c: Sort headers.
5660         * aarch64-fbsd-nat.c: Sort headers.
5661         * aarch32-linux-nat.c: Sort headers.
5662
5663 2019-04-04  Tom Tromey  <tom@tromey.com>
5664
5665         * varobj.c (varobj_create): Update.
5666         * rust-exp.y (struct rust_parser) <update_innermost_block,
5667         lookup_symbol>: New methods.
5668         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5669         Rename.
5670         (rust_parser::rust_lookup_type)
5671         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5672         * printcmd.c (display_command, do_one_display): Update.
5673         * parser-defs.h (struct parser_state) <parser_state>: Add
5674         "tracker" parameter.
5675         (block_tracker): New member.
5676         (class innermost_block_tracker) <innermost_block_tracker>: Add
5677         "types" parameter.
5678         <reset>: Remove method.
5679         (innermost_block): Don't declare.
5680         (null_post_parser): Update.
5681         * parse.c (innermost_block): Remove global.
5682         (write_dollar_variable): Update.
5683         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5684         Remove "tracker_types" parameter.
5685         (parse_expression): Add "tracker" parameter.
5686         (parse_expression_for_completion): Update.
5687         (null_post_parser): Add "tracker" parameter.
5688         * p-exp.y: Update rules.
5689         * m2-exp.y: Update rules.
5690         * language.h (struct language_defn) <la_post_parser>: Add
5691         "tracker" parameter.
5692         * go-exp.y: Update rules.
5693         * f-exp.y: Update rules.
5694         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5695         parameter.
5696         * d-exp.y: Update rules.
5697         * c-exp.y: Update rules.
5698         * breakpoint.c (set_breakpoint_condition): Create an
5699         innermost_block_tracker.
5700         (watch_command_1): Likewise.
5701         * ada-lang.c (resolve): Add "tracker" parameter.
5702         (resolve_subexp): Likewise.
5703         * ada-exp.y (write_var_from_sym): Update.
5704
5705 2019-04-04  Tom Tromey  <tom@tromey.com>
5706
5707         * type-stack.h: New file.
5708         * type-stack.c: New file.
5709         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5710         type-stack.h.
5711         (insert_into_type_stack, insert_type, push_type, push_type_int)
5712         (insert_type_address_space, pop_type, pop_type_int)
5713         (pop_typelist, pop_type_stack, append_type_stack)
5714         (push_type_stack, get_type_stack, push_typelist)
5715         (follow_type_instance_flags, follow_types): Don't declare.
5716         * parse.c (type_stack): Remove global.
5717         (parse_exp_in_context): Update.
5718         (insert_into_type_stack, insert_type, push_type, push_type_int)
5719         (insert_type_address_space, pop_type, pop_type_int)
5720         (pop_typelist, pop_type_stack, append_type_stack)
5721         (push_type_stack, get_type_stack, push_typelist)
5722         (follow_type_instance_flags, follow_types): Remove (moved to
5723         type-stack.c).
5724         * f-exp.y (type_stack): New global.
5725         Update rules.
5726         (push_kind_type, f_parse): Update.
5727         * d-exp.y (type_stack): New global.
5728         Update rules.
5729         (d_parse): Update.
5730         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5731         Update rules.
5732         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5733         (HFILES_NO_SRCDIR): Add type-stack.h.
5734
5735 2019-04-04  Tom Tromey  <tom@tromey.com>
5736
5737         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5738         (rust_parser::convert_ast_to_expression, rust_parse)
5739         (rust_lex_test_completion, rust_lex_tests): Update.
5740         * parser-defs.h (struct expr_completion_state): New.
5741         (struct parser_state) <parser_state>: Add completion parameter.
5742         <mark_struct_expression, mark_completion_tag>: New methods.
5743         <parse_completion, m_completion_state>: New members.
5744         (prefixify_expression, null_post_parser): Update.
5745         (mark_struct_expression, mark_completion_tag): Don't declare.
5746         * parse.c (parse_completion, expout_last_struct)
5747         (expout_tag_completion_type, expout_completion_name): Remove
5748         globals.
5749         (parser_state::mark_struct_expression)
5750         (parser_state::mark_completion_tag): Now methods.
5751         (prefixify_expression): Add last_struct parameter.
5752         (prefixify_subexp): Likewise.
5753         (parse_exp_1): Update.
5754         (parse_exp_in_context): Add cstate parameter.  Update.
5755         (parse_expression_for_completion): Create an
5756         expr_completion_state.
5757         (null_post_parser): Add "completion" parameter.
5758         * p-exp.y: Update rules.
5759         (yylex): Update.
5760         * language.h (struct language_defn) <la_post_parser>: Add
5761         "completing" parameter.
5762         * go-exp.y: Update rules.
5763         (lex_one_token): Update.
5764         * expression.h (parse_completion): Don't declare.
5765         * d-exp.y: Update rules.
5766         (lex_one_token): Update rules.
5767         * c-exp.y: Update rules.
5768         (lex_one_token): Update.
5769         * ada-lang.c (resolve): Add "parse_completion" parameter.
5770         (resolve_subexp): Likewise.
5771         (ada_resolve_function): Likewise.
5772
5773 2019-04-04  Tom Tromey  <tom@tromey.com>
5774
5775         * parser-defs.h (struct parser_state) <start_arglist,
5776         end_arglist>: New methods.
5777         <arglist_len, m_funcall_chain>: New members.
5778         (arglist_len, start_arglist, end_arglist): Don't declare.
5779         * parse.c (arglist_len, funcall_chain): Remove global.
5780         (start_arglist, end_arglist): Remove functions.
5781         (parse_exp_in_context): Update.
5782         * p-exp.y: Update rules.
5783         * m2-exp.y: Update rules.
5784         * go-exp.y: Update rules.
5785         * f-exp.y: Update rules.
5786         * d-exp.y: Update rules.
5787         * c-exp.y: Update rules.
5788
5789 2019-04-04  Tom Tromey  <tom@tromey.com>
5790
5791         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5792         lex_operator, push_back>: New methods.
5793         Update all rules.
5794         (rust_parser::lex_hex, lex_escape): Rename and update.
5795         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5796         (rust_parser::lex_operator): Rename and update.
5797         (rust_parser::lex_number, rustyylex, rustyyerror)
5798         (rust_lex_test_init, rust_lex_test_sequence)
5799         (rust_lex_test_push_back, rust_lex_tests): Update.
5800         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5801         parameter.
5802         <lexptr, prev_lexptr>: New members.
5803         (lexptr, prev_lexptr): Don't declare.
5804         * parse.c (lexptr, prev_lexptr): Remove globals.
5805         (parse_exp_in_context): Update.
5806         * p-exp.y (yylex, yyerror): Update.
5807         * m2-exp.y (parse_number, yylex, yyerror): Update.
5808         * go-exp.y (lex_one_token, yyerror): Update.
5809         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5810         * d-exp.y (lex_one_token, yyerror): Update.
5811         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5812         (lex_one_token, yyerror): Update.
5813         * ada-lex.l (YY_INPUT): Update.
5814         (rewind_to_char): Update.
5815         * ada-exp.y (yyerror): Update.
5816
5817 2019-04-04  Tom Tromey  <tom@tromey.com>
5818
5819         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5820         * parser-defs.h (struct parser_state) <parser_state>: Add new
5821         parameter.
5822         <comma_terminates>: New member.
5823         (comma_terminates): Don't declare global.
5824         * parse.c (comma_terminates): Remove global.
5825         (parse_exp_in_context): Update.
5826         * p-exp.y (yylex): Update.
5827         * m2-exp.y (yylex): Update.
5828         * go-exp.y (lex_one_token): Update.
5829         * f-exp.y (yylex): Update.
5830         * d-exp.y (lex_one_token): Update.
5831         * c-exp.y (lex_one_token): Update.
5832         * ada-lex.l: Update.
5833
5834 2019-04-04  Tom Tromey  <tom@tromey.com>
5835
5836         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5837         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5838         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5839         * parser-defs.h (paren_depth): Don't declare.
5840         * parse.c (paren_depth): Remove global.
5841         (parse_exp_in_context): Update.
5842         * p-exp.y (paren_depth): New global.
5843         (pascal_parse): Initialize it.
5844         * m2-exp.y (paren_depth): New global.
5845         (m2_parse): Initialize it.
5846         * go-exp.y (paren_depth): New global.
5847         (go_parse): Initialize it.
5848         * f-exp.y (paren_depth): New global.
5849         (f_parse): Initialize it.
5850         * d-exp.y (paren_depth): New global.
5851         (d_parse): Initialize it.
5852         * c-exp.y (paren_depth): New global.
5853         (c_parse): Initialize it.
5854         * ada-lex.l (paren_depth): New global.
5855         (lexer_init): Initialize it.
5856
5857 2019-04-04  Tom Tromey  <tom@tromey.com>
5858
5859         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5860         (rust_parser::convert_ast_to_type)
5861         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5862         * parser-defs.h (struct parser_state) <parser_state>: Add
5863         parameters.  Initialize new members.
5864         <expression_context_block, expression_context_pc>: New members.
5865         * parse.c (expression_context_block, expression_context_pc):
5866         Remove globals.
5867         (parse_exp_in_context): Update.
5868         * p-exp.y: Update all rules.
5869         (yylex): Update.
5870         * m2-exp.y: Update all rules.
5871         (yylex): Update.
5872         * go-exp.y (yylex): Update.
5873         * f-exp.y (yylex): Update.
5874         * d-exp.y: Update all rules.
5875         (yylex): Update.
5876         * c-exp.y: Update all rules.
5877         (lex_one_token, classify_name, yylex, c_parse): Update.
5878         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5879
5880 2019-04-04  Tom Tromey  <tom@tromey.com>
5881
5882         * gdbarch.h, gdbarch.c: Rebuild.
5883         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5884         * stap-probe.h:
5885         (struct stap_parse_info): Replace "parser_state" with
5886         "expr_builder".
5887         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5888         (parser_state): New class.
5889         * parse.c (expr_builder): Rename.
5890         (expr_builder::release): Rename.
5891         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5892         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5893         (write_exp_elt_longcst, write_exp_elt_floatcst)
5894         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5895         (write_exp_string_vector, write_exp_bitstring)
5896         (write_exp_msymbol, mark_struct_expression)
5897         (write_dollar_variable)
5898         (insert_type_address_space, increase_expout_size): Replace
5899         "parser_state" with "expr_builder".
5900         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5901         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5902         "parser_state" with "expr_builder".
5903
5904 2019-04-04  Tom Tromey  <tom@tromey.com>
5905
5906         * rust-exp.y: Replace "parse_language" with method call.
5907         * p-exp.y:
5908         (yylex): Replace "parse_language" with method call.
5909         * m2-exp.y:
5910         (yylex): Replace "parse_language" with method call.
5911         * go-exp.y (classify_name): Replace "parse_language" with method
5912         call.
5913         * f-exp.y (yylex): Replace "parse_language" with method call.
5914         * d-exp.y (lex_one_token): Replace "parse_language" with method
5915         call.
5916         * c-exp.y:
5917         (lex_one_token, classify_name, yylex): Replace "parse_language"
5918         with method call.
5919         * ada-exp.y (find_primitive_type, type_char)
5920         (type_system_address): Replace "parse_language" with method call.
5921
5922 2019-04-04  Tom Tromey  <tom@tromey.com>
5923
5924         * rust-exp.y: Replace "parse_gdbarch" with method call.
5925         * parse.c (write_dollar_variable, insert_type_address_space):
5926         Replace "parse_gdbarch" with method call.
5927         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5928         call.
5929         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5930         call.
5931         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5932         "parse_gdbarch" with method call.
5933         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5934         with method call.
5935         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5936         "parse_gdbarch" with method call.
5937         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5938         "parse_gdbarch" with method call.
5939         * c-exp.y (parse_type, parse_number, classify_name): Replace
5940         "parse_gdbarch" with method call.
5941         * ada-lex.l: Replace "parse_gdbarch" with method call.
5942         * ada-exp.y (parse_type, find_primitive_type, type_char)
5943         (type_system_address): Replace "parse_gdbarch" with method call.
5944
5945 2019-04-04  Tom Tromey  <tom@tromey.com>
5946
5947         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5948         * stap-probe.c (stap_parse_argument): Update.
5949         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5950         initial_size parameter.
5951         * rust-exp.y (rust_lex_tests): Update.
5952         * parse.c (parser_state): Update.
5953         (parse_exp_in_context): Update.
5954         * parser-defs.h (struct parser_state) <parser_state>: Remove
5955         "initial_size" parameter.
5956
5957 2019-04-04  Tom Tromey  <tom@tromey.com>
5958
5959         * parser-defs.h (increase_expout_size): Don't declare.
5960         * parse.c (increase_expout_size): Now static.
5961
5962 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5963
5964         * gnu-nat.c (gnu_nat_target::wait): Fix
5965         target_waitstatus_to_string call.
5966
5967 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5968
5969         * eval.c (evaluate_subexp_standard): Handle internal functions
5970         during Fortran function call handling.
5971
5972 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5973
5974         * NEWS: Mention new internal functions.
5975         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5976         (read_base_type): Use dwarf2_init_complex_target_type.
5977         * value.c (creal_internal_fn): New function.
5978         (cimag_internal_fn): New function.
5979         (_initialize_values): Register new internal functions.
5980
5981 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5982
5983         * infrun.c (stop_all_threads): If debug_infrun, always
5984         trace the wait status after wait_one, using
5985         target_waitstatus_to_string and target_pid_to_str.
5986         (handle_inferior_event): Replace various trace of
5987         wait status kind by a single trace.
5988         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5989         wait status kind image by target_waitstatus_to_string.
5990         * target/waitstatus.c (target_waitstatus_to_string): Fix
5991         obsolete comment.
5992
5993 2019-04-01  Tom Tromey  <tromey@adacore.com>
5994
5995         PR symtab/23331:
5996         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5997
5998 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5999             Pedro Alves  <palves@redhat.com>
6000
6001         * top.c (quit_force): Call 'finalize_values'.
6002         * value.c (finalize_values): New function.
6003         * value.h (finalize_values): Declare.
6004
6005 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6006
6007         * NEWS: Announce $_gdb_major and $_gdb_minor.
6008
6009         * top.c (init_gdb_version_vars): New function.
6010         (gdb_init): Call init_gdb_version_vars.
6011
6012 2019-03-29  Tom Tromey  <tromey@adacore.com>
6013
6014         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6015         help text.  Remove dead code.
6016
6017 2019-03-29  Keith Seitz  <keiths@redhat.com>
6018
6019         From Siddhesh Poyarekar:
6020         * f-lang.h (f77_get_upperbound): Return LONGEST.
6021         (f77_get_lowerbound): Likewise.
6022         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6023         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6024         print them.
6025         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6026         plongest to format print it.
6027         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6028         (f77_get_upperbound): Likewise.
6029         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6030         LOWER_BOUND to LONGEST.
6031         (f77_create_arrayprint_offset_tbl): Likewise.
6032
6033 2019-03-29  Keith Seitz  <keiths@redhat.com>
6034
6035         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6036         %s/pulongest for TYPE_LENGTH instead of %d in format
6037         strings.
6038         * ada-typerint.c (ada_print_type): Likewise.
6039         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6040         * compile/compile-c-support.c (generate_register_struct): Likewise.
6041         * gdbtypes.c (recursive_dump_type): Likewise.
6042         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6043         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6044         instead of %d in format strings.
6045         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6046         to std::min to ULONGEST.
6047         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6048         instead of %d in format strings.
6049         * tracepoint.c (info_scope_command): Likewise.
6050         * typeprint.c (print_offset_data::update)
6051         (print_offset_data::finish): Likewise.
6052         * xtensa-tdep.c (xtensa_store_return_value)
6053         (xtensa_push_dummy_call): Likewise.
6054
6055 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6056
6057         * windows-nat.c (display_selector): Fixed format specifications
6058         for 64-bit Cygwin.
6059
6060 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6061
6062         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6063
6064 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6065
6066         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6067         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6068         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6069         (nios2_linux_init_abi): Install it.
6070
6071 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6072
6073         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6074
6075 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6076
6077         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6078
6079 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6080             Tom Tromey  <tromey@adacore.com>
6081
6082         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6083
6084 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6085
6086         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6087         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6088         method to compute the bounds of range types. Also print "[evaluated]"
6089         if the bounds' values come from a dynamic evaluation.
6090
6091 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6092
6093         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6094         whitespace when pretty printing is on.
6095
6096 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6097
6098         * ppc-linux-nat.c: Add include.
6099
6100 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6101
6102         * NEWS: Mention AArch64 Pointer Authentication.
6103
6104 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6105
6106         * arm-linux-nat.c: Add include.
6107
6108 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6109
6110         * source-cache.c (source_cache::get_source_lines): Re-read
6111         fullname after calling open_source_file.
6112
6113 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6114
6115         * NEWS: Mention TLS support for FreeBSD.
6116
6117 2019-03-25  Tom Tromey  <tromey@adacore.com>
6118
6119         * minsyms.c (BUNCH_SIZE): Update comment.
6120         (~minimal_symbol_reader): Remove old comment.
6121         (compact_minimal_symbols): Update comment.
6122         (minimal_symbol_reader::install): Remove old comment.  Update
6123         other comments.
6124
6125 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6126
6127         * s390-linux-nat.c: Add include.
6128
6129 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6130
6131         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6132         Call linux_get_hwcap.
6133         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6134         Likewise.
6135         (aarch64_linux_get_hwcap): Remove function.
6136         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6137         declaration.
6138         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6139         linux_get_hwcap.
6140         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6141         * linux-tdep.c (linux_get_hwcap): Add function.
6142         (linux_get_hwcap2): Likewise.
6143         * linux-tdep.h (linux_get_hwcap): Add declaration.
6144         (linux_get_hwcap2): Likewise.
6145         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6146         (ppc_linux_get_hwcap2): Likewise.
6147         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6148         linux_get_hwcap.
6149         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6150         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6151         (ppc_linux_nat_target::read_description): Likewise.
6152         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6153         * s390-linux-nat.c: Likewise.
6154         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6155
6156 2019-03-24  Tom Tromey  <tom@tromey.com>
6157
6158         * ada-lang.c (standard_lookup): Simplify initialization.
6159         (ada_lookup_symbol_nonlocal): Simplify return.
6160         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6161         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6162         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6163         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6164         initialization.
6165         * solib.c (solib_global_lookup): Simplify.
6166         * symtab.c (null_block_symbol): Remove.
6167         (symbol_cache_lookup): Simplify returns.
6168         (lookup_language_this): Simplify returns.
6169         (lookup_symbol_aux): Simplify return.
6170         (lookup_local_symbol): Simplify returns.
6171         (lookup_global_symbol_from_objfile): Simplify return.
6172         (lookup_symbol_in_objfile_symtabs)
6173         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6174         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6175         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6176         * cp-namespace.c (cp_lookup_bare_symbol)
6177         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6178         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6179         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6180         (cp_lookup_symbol_via_imports): Simplify initialization.
6181         (find_symbol_in_baseclass): Likewise.
6182         * symtab.h (null_block_symbol): Remove.
6183         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6184         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6185         (d_lookup_symbol_module): Likewise.
6186         (find_symbol_in_baseclass): Simplify initialization.
6187
6188 2019-03-24  Tom Tromey  <tom@tromey.com>
6189
6190         * expression.h: Don't include symtab.h.
6191         (struct block): Forward declare.
6192
6193 2019-03-24  Tom Tromey  <tom@tromey.com>
6194
6195         * c-exp.y (typebase): Remove casts.
6196         * gdbtypes.c (lookup_unsigned_typename, )
6197         (lookup_signed_typename): Remove cast.
6198         * eval.c (parse_to_comma_and_eval): Remove cast.
6199         * parse.c (write_dollar_variable): Remove cast.
6200         * block.h (struct block) <superblock>: Now const.
6201         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6202         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6203         (map_block): Make "block" const.
6204         * symfile.h (struct quick_symbol_functions)
6205         <map_matching_symbols>: Constify block argument to "callback".
6206         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6207         const.
6208         (find_pc_sect_compunit_symtab): Make "b" const.
6209         (find_symbol_at_address): Likewise.
6210         (search_symbols): Likewise.
6211         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6212         (dw2_debug_names_lookup_symbol): Likewise.
6213         (dw2_map_matching_symbols): Update.
6214         * p-valprint.c (pascal_val_print): Remove "block".
6215         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6216         (aux_add_nonlocal_symbols): Make "block" const.
6217         (resolve_subexp): Remove cast.
6218         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6219         const.
6220         (iterate_over_file_blocks): Likewise.
6221         * f-exp.y (%union) <bval>: Remove.
6222         * coffread.c (patch_opaque_types): Make "b" const.
6223         * spu-tdep.c (spu_catch_start): Make "block" const.
6224         * c-valprint.c (print_unpacked_pointer): Remove "block".
6225         * symmisc.c (dump_symtab_1): Make "b" const.
6226         (block_depth): Make "block" const.
6227         * d-exp.y (%union) <bval>: Remove.
6228         * cp-support.h (cp_lookup_rtti_type): Update.
6229         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6230         * psymtab.c (psym_lookup_symbol): Make "block" const.
6231         (maintenance_check_psymtabs): Make "b" const.
6232         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6233         (enumerate_locals, enumerate_args): Update.
6234         * python/py-symtab.c (stpy_global_block): Make "block" const.
6235         (stpy_static_block): Likewise.
6236         * inline-frame.c (block_starting_point_at): Make "new_block"
6237         const.
6238         * block.c (find_block_in_blockvector): Make return type const.
6239         (blockvector_for_pc_sect): Make "b" const.
6240         (find_block_in_blockvector): Make "b" const.
6241
6242 2019-03-23  Tom Tromey  <tom@tromey.com>
6243
6244         * varobj.c (varobj_create): Update.
6245         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6246         * printcmd.c (display_command, do_one_display): Don't reset
6247         innermost_block.
6248         * parser-defs.h (enum innermost_block_tracker_type): Move to
6249         expression.h.
6250         (innermost_block): Update comment.
6251         * parse.c (parse_exp_1): Add tracker_types parameter.
6252         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6253         tracker_types parameter.  Reset innermost_block.
6254         (parse_exp_in_context): Remove.
6255         (parse_expression_for_completion): Update.
6256         * objfiles.c (~objfile): Don't reset expression_context_block or
6257         innermost_block.
6258         * expression.h (enum innermost_block_tracker_type): Move from
6259         parser-defs.h.
6260         (parse_exp_1): Add tracker_types parameter.
6261         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6262         reset innermost_block.
6263
6264 2019-03-23  Tom Tromey  <tom@tromey.com>
6265
6266         * objfiles.h: Include bcache.h.
6267
6268 2019-03-23  Tom Tromey  <tom@tromey.com>
6269
6270         * linespec.c (get_current_search_block): Use
6271         scoped_restore_current_language.
6272         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6273
6274 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6275             Jiong Wang  <jiong.wang@arm.com>
6276
6277         * aarch64-linux-tdep.c
6278         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6279         section.
6280         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6281
6282 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6283             Jiong Wang  <jiong.wang@arm.com>
6284
6285         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6286         instructions.
6287         (aarch64_analyze_prologue_test): Add PACIASP test.
6288         (aarch64_prologue_prev_register): Unmask PC value.
6289
6290 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6291             Jiong Wang  <jiong.wang@arm.com>
6292
6293         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6294         (aarch64_dwarf2_prev_register): Unmask PC value.
6295         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6296         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6297         DW_CFA_AARCH64_negate_ra_state.
6298         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6299
6300 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6301             Jiong Wang  <jiong.wang@arm.com>
6302
6303         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6304         registers.
6305         (aarch64_pseudo_register_name): Likewise.
6306         (aarch64_pseudo_register_type): Likewise.
6307         (aarch64_pseudo_register_reggroup_p): Likewise.
6308         (aarch64_gdbarch_init): Add pauth registers.
6309         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6310         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6311         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6312         (struct gdbarch_tdep): Add regnum for ra_state.
6313
6314 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6315             Jiong Wang  <jiong.wang@arm.com>
6316
6317         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6318
6319 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6320             Jiong Wang  <jiong.wang@arm.com>
6321
6322         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6323         function.
6324         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6325         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6326         (aarch64_gdbarch_init): Add puth registers.
6327         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6328         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6329         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6330
6331 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6332             Jiong Wang  <jiong.wang@arm.com>
6333
6334         * aarch64-linux-nat.c
6335         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6336         * aarch64-linux-tdep.c
6337         (aarch64_linux_core_read_description): Likewise.
6338         (aarch64_linux_get_hwcap): New function.
6339         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6340         (aarch64_linux_get_hwcap): New declaration.
6341
6342 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6343             Jiong Wang  <jiong.wang@arm.com>
6344
6345         * aarch64-linux-nat.c
6346         (aarch64_linux_nat_target::read_description): Add pauth param.
6347         * aarch64-linux-tdep.c
6348         (aarch64_linux_core_read_description): Likewise.
6349         * aarch64-tdep.c (struct target_desc): Add in pauth.
6350         (aarch64_read_description): Add pauth param.
6351         (aarch64_gdbarch_init): Likewise.
6352         * aarch64-tdep.h (aarch64_read_description): Likewise.
6353         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6354         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6355         * features/Makefile: Add new files.
6356         * features/aarch64-pauth.c: New file.
6357         * features/aarch64-pauth.xml: New file.
6358
6359 2019-03-20  Tom Tromey  <tromey@adacore.com>
6360
6361         * infrun.c (handle_inferior_event): Rename from
6362         handle_inferior_event_1.  Create a scoped_value_mark.
6363         (handle_inferior_event): Remove.
6364
6365 2019-03-19  Tom Tromey  <tromey@adacore.com>
6366
6367         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6368         * infrun.h (print_stop_event): Add "displays" parameter.
6369         * infrun.c (print_stop_event): Add "displays" parameter.
6370
6371 2019-03-19  Pedro Alves  <palves@redhat.com>
6372
6373         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6374         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6375         to -1.  Fix TABs vs spaces.
6376         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6377         * tui/tui-out.h (tui_ui_out) Add intro comments.
6378         <m_line, m_start_of_line>: In-class initialize, and add describing
6379         comment.
6380
6381 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6382
6383         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6384         variable names.
6385         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6386
6387 2019-03-18  Pedro Alves  <palves@redhat.com>
6388             Eli Zaretskii <eliz@gnu.org>
6389
6390         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6391         m_line and m_start_of_line.
6392
6393 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6394
6395         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6396         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6397         it returns a newline.  This fixes a regression in TU mode, whereby
6398         the next line is output on the same screen line as the user input.
6399
6400 2019-03-18  Tom Tromey  <tromey@adacore.com>
6401
6402         * minsyms.c (minimal_symbol_reader::install): Remove call to
6403         obstack_blank.
6404
6405 2019-03-18  Pedro Alves  <palves@redhat.com>
6406
6407         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6408         New globals.
6409         (apply_style): New, factored out from ...
6410         (apply_ansi_escape): ... this.  Handle reverse video mode.
6411         (tui_set_reverse_mode): New function.
6412         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6413         * tui/tui-winsource.c (tui_show_source_line): Use
6414         tui_set_reverse_mode instead of setting A_STANDOUT.
6415         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6416         New setter methods.
6417
6418 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6419
6420         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6421         Handle tabs.
6422
6423 2019-03-18  Tom Tromey  <tromey@adacore.com>
6424
6425         * ada-lang.c (empty_array): Add "high" parameter.
6426         (ada_evaluate_subexp): Update.
6427
6428 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6429
6430         * unittests/string_view-selftests.c: Define
6431         _initialize_string_view_selftests unconditionally.
6432
6433 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6434
6435         PR gdb/24350
6436         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6437
6438 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6439
6440         PR gdb/24351
6441         * windows-nat.c (display_selector): Fix format specifiers.
6442
6443 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6444
6445         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6446         tui_refill_source_window instead of tui_refresh_win, to update the
6447         current execution line.  This fixes redisplay of the current line
6448         when stepping through the code with "next" or "step".
6449
6450 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6451
6452         * source-cache.c (source_cache::get_source_lines): Call
6453         find_source_lines to initialize s->nlines.  This fixes vertical
6454         scrolling of TUI source window when the DOWN arrow is pressed.
6455
6456 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6457
6458         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6459         linux-thread-db.c (_initialize_thread_db): Likewise.
6460
6461 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6462
6463         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6464         wclrtoeol in tui_show_source_line".  This reverts changes made in
6465         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6466
6467 2019-03-15  Tom Tromey  <tom@tromey.com>
6468
6469         * symtab.h (struct minimal_symbol): Derive from
6470         general_symbol_info.
6471         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6472         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6473         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6474         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6475         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6476         (MSYMBOL_SEARCH_NAME): Update.
6477         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6478         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6479         * minsyms.c (minimal_symbol_reader::record_full): Update.
6480
6481 2019-03-15  Tom Tromey  <tom@tromey.com>
6482
6483         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6484
6485 2019-03-15  Tom Tromey  <tom@tromey.com>
6486
6487         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6488         unique_xmalloc_ptr.
6489         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6490         Update.
6491         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6492         (build_minimal_symbol_hash_tables)
6493         (minimal_symbol_reader::install): Update.
6494
6495 2019-03-15  Tom Tromey  <tom@tromey.com>
6496
6497         * symtab.c (create_demangled_names_hash): Update.
6498         (symbol_set_names): Update.
6499         * objfiles.h (struct objfile_per_bfd_storage)
6500         <demangled_names_hash>: Now an htab_up.
6501         * objfiles.c (objfile_per_bfd_storage): Simplify.
6502
6503 2019-03-15  Tom Tromey  <tom@tromey.com>
6504
6505         * objfiles.h (struct objfile_per_bfd_storage): Declare
6506         destructor.
6507         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6508         New.
6509         (get_objfile_bfd_data): Use new.  Don't initialize
6510         language_of_main.
6511         (free_objfile_per_bfd_storage): Remove.
6512         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6513
6514 2019-03-15  Tom Tromey  <tom@tromey.com>
6515
6516         * symfile.c (reread_symbols): Update.
6517         * objfiles.c (objfile::objfile): Update.
6518         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6519         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6520         comment.
6521         (minimal_symbol_reader::install): Update.
6522         (terminate_minimal_symbol_table): Remove.
6523         * jit.c (jit_object_close_impl): Update.
6524
6525 2019-03-15  Tom Tromey  <tom@tromey.com>
6526
6527         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6528         initializations.
6529
6530 2019-03-15  Tom Tromey  <tom@tromey.com>
6531
6532         * objfiles.h (struct objfile_per_bfd_storage)
6533         <demangled_hash_languages>: Now a bitset.
6534         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6535         (lookup_minimal_symbol): Update.
6536
6537 2019-03-15  Tom Tromey  <tom@tromey.com>
6538
6539         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6540         Don't return the symbol.
6541         * coffread.c (record_minimal_symbol): Use record_full.
6542
6543 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6544
6545         The MS-Windows port of ncurses fails to switch to a color pair if
6546         one or both of the colors are the implicit default colors.  This
6547         change records the default colors when TUI is initialized, and
6548         then specifies them explicitly when a color pair uses the default
6549         colors.  This allows color styling in TUI mode on MS-Windows.
6550
6551         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6552         ncurses_norm_attr.
6553         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6554         colors in ncurses_norm_attr.
6555         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6556         "none", replace it with the default color recorded in
6557         ncurses_norm_attr.
6558
6559 2019-03-14  Tom Tromey  <tromey@adacore.com>
6560
6561         * source-cache.h (class source_cache) <get_source_lines>: Return
6562         std::string.
6563         * source-cache.c (source_cache::extract_lines): Handle case where
6564         first_pos==npos.  Return std::string.
6565         (source_cache::get_source_lines): Update.
6566
6567 2019-03-14  Tom Tromey  <tromey@adacore.com>
6568
6569         * NEWS: Add item for "style sources" commands.
6570         * source-cache.c (source_cache::get_source_lines): Check
6571         source_styling.
6572         * cli/cli-style.c (source_styling): New global.
6573         (_initialize_cli_style): Add "style sources" commands.
6574         (show_style_sources): New function.
6575         * cli/cli-style.h (source_styling): Declare.
6576
6577 2019-03-14  Pedro Alves  <palves@redhat.com>
6578             Tom Tromey  <tromey@adacore.com>
6579
6580         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6581         * tui/tui-winsource.c (tui_refill_source_window): New function,
6582         from...
6583         (tui_horizontal_source_scroll): ... here.  Move some logic.
6584         * cli/cli-style.c (set_style_enabled): Notify new observable.
6585         * tui/tui-hooks.c (tui_redisplay_source): New function.
6586         (tui_attach_detach_observers): Attach or detach
6587         tui_redisplay_source.
6588         * observable.h (source_styling_changed): New observable.
6589         * observable.c: Define source_styling_changed observable.
6590
6591 2019-03-13  Tom Tromey  <tromey@adacore.com>
6592
6593         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6594         (i386_gnu_nat_target::store_registers): Update.
6595         * target-debug.h (target_debug_print_std_string): New macro.
6596         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6597         * windows-tdep.c (display_one_tib): Update.
6598         * tui/tui-stack.c (tui_make_status_line): Update.
6599         * top.c (print_inferior_quit_action): Update.
6600         * thread.c (thr_try_catch_cmd): Update.
6601         (add_thread_with_info): Update.
6602         (thread_target_id_str): Update.
6603         (thr_try_catch_cmd): Update.
6604         (thread_command): Update.
6605         (thread_find_command): Update.
6606         * record-btrace.c (record_btrace_target::info_record)
6607         (record_btrace_resume_thread, record_btrace_target::resume)
6608         (record_btrace_cancel_resume, record_btrace_step_thread)
6609         (record_btrace_target::wait, record_btrace_target::wait)
6610         (record_btrace_target::wait, record_btrace_target::stop): Update.
6611         * progspace.c (print_program_space): Update.
6612         * process-stratum-target.c
6613         (process_stratum_target::thread_address_space): Update.
6614         * linux-fork.c (linux_fork_mourn_inferior)
6615         (detach_checkpoint_command, info_checkpoints_command)
6616         (linux_fork_context): Update.
6617         (linux_fork_detach): Update.
6618         (class scoped_switch_fork_info): Update.
6619         (delete_checkpoint_command): Update.
6620         * infrun.c (follow_fork_inferior): Update.
6621         (follow_fork_inferior): Update.
6622         (proceed_after_vfork_done): Update.
6623         (handle_vfork_child_exec_or_exit): Update.
6624         (follow_exec): Update.
6625         (displaced_step_prepare_throw): Update.
6626         (displaced_step_restore): Update.
6627         (start_step_over): Update.
6628         (resume_1): Update.
6629         (clear_proceed_status_thread): Update.
6630         (proceed): Update.
6631         (print_target_wait_results): Update.
6632         (do_target_wait): Update.
6633         (context_switch): Update.
6634         (stop_all_threads): Update.
6635         (restart_threads): Update.
6636         (finish_step_over): Update.
6637         (handle_signal_stop): Update.
6638         (switch_back_to_stepped_thread): Update.
6639         (keep_going_pass_signal): Update.
6640         (print_exited_reason): Update.
6641         (normal_stop): Update.
6642         * inferior.c (inferior_pid_to_str): Change return type.
6643         (print_selected_inferior): Update.
6644         (add_inferior): Update.
6645         (detach_inferior): Update.
6646         * dummy-frame.c (fprint_dummy_frames): Update.
6647         * dcache.c (dcache_info_1): Update.
6648         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6649         (btrace_fetch, btrace_clear): Update.
6650         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6651         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6652         type.
6653         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6654         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6655         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6656         * gdbarch.c, gdbarch.h: Rebuild.
6657         * gdbarch.sh (core_pid_to_str): Change return type.
6658         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6659         return type.
6660         (windows_nat_target::pid_to_str): Change return type.
6661         (windows_delete_thread): Update.
6662         (windows_nat_target::attach): Update.
6663         (windows_nat_target::files_info): Update.
6664         * target-delegates.c: Rebuild.
6665         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6666         return type.
6667         (sol_thread_target::pid_to_str): Change return type.
6668         * remote.c (class remote_target) <pid_to_str>: Change return
6669         type.
6670         (remote_target::pid_to_str): Change return type.
6671         (extended_remote_target::attach, remote_target::remote_stop_ns)
6672         (remote_target::remote_notif_remove_queued_reply)
6673         (remote_target::push_stop_reply, remote_target::disable_btrace):
6674         Update.
6675         (extended_remote_target::attach): Update.
6676         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6677         type.
6678         (gdbsim_target::pid_to_str): Change return type.
6679         * ravenscar-thread.c (struct ravenscar_thread_target)
6680         <pid_to_str>: Change return type.
6681         (ravenscar_thread_target::pid_to_str): Change return type.
6682         * procfs.c (class procfs_target) <pid_to_str>: Change return
6683         type.
6684         (procfs_target::pid_to_str): Change return type.
6685         (procfs_target::attach): Update.
6686         (procfs_target::detach): Update.
6687         (procfs_target::fetch_registers): Update.
6688         (procfs_target::store_registers): Update.
6689         (procfs_target::wait): Update.
6690         (procfs_target::files_info): Update.
6691         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6692         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6693         return type.
6694         (nto_procfs_target::pid_to_str): Change return type.
6695         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6696         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6697         return type.
6698         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6699         (exit_lwp): Update.
6700         (attach_proc_task_lwp_callback, get_detach_signal)
6701         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6702         (linux_nat_target::resume, wait_lwp, stop_callback)
6703         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6704         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6705         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6706         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6707         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6708         type.
6709         (inf_ptrace_target::attach): Update.
6710         (inf_ptrace_target::files_info): Update.
6711         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6712         type.
6713         (go32_nat_target::pid_to_str): Change return type.
6714         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6715         (gnu_nat_target::wait): Update.
6716         (gnu_nat_target::wait): Update.
6717         (gnu_nat_target::resume): Update.
6718         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6719         (fbsd_nat_target::wait): Update.
6720         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6721         type.
6722         (darwin_nat_target::attach): Update.
6723         * corelow.c (class core_target) <pid_to_str>: Change return type.
6724         (core_target::pid_to_str): Change return type.
6725         * target.c (normal_pid_to_str): Change return type.
6726         (default_pid_to_str): Likewise.
6727         (target_pid_to_str): Change return type.
6728         (target_translate_tls_address): Update.
6729         (target_announce_detach): Update.
6730         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6731         return type.
6732         (bsd_uthread_target::pid_to_str): Change return type.
6733         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6734         type.
6735         (bsd_kvm_target::pid_to_str): Change return type.
6736         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6737         return type.
6738         (aix_thread_target::pid_to_str): Change return type.
6739         * target.h (struct target_ops) <pid_to_str>: Change return type.
6740         (target_pid_to_str, normal_pid_to_str): Likewise.
6741         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6742         type.
6743         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6744         type.
6745         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6746         return type.
6747         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6748         type.
6749         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6750         type.
6751         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6752         return type.
6753
6754 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6755
6756         * NEWS: Mention that the new default MI version is 3.  Mention
6757         changes to the output of commands and events that deal with
6758         multi-location breakpoints.
6759         * breakpoint.c: Include "mi/mi-out.h".
6760         (print_one_breakpoint): Change output syntax if using MI version
6761         >= 3.
6762         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6763         New.
6764         (mi_multi_location_breakpoint_output_fixed): New.
6765         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6766         (mi_cmd_fix_multi_location_breakpoint_output): New.
6767         (mi_multi_location_breakpoint_output_fixed): New.
6768         * mi/mi-cmds.c (mi_cmds): Register command
6769         -fix-multi-location-breakpoint-output.
6770         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6771         interpreter "mi".
6772
6773 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6774
6775         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6776         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6777         instantiate mi_ui_out based on interpreter name.
6778         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6779         * mi/mi-main.c (mi_load_progress): Likewise.
6780
6781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6782
6783         * NEWS: Combine separate "New targets" sections for 8.3.
6784
6785 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6786
6787         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6788         (ppcfbsd_init_abi): Install gdbarch
6789         "fetch_tls_load_module_address" and "get_thread_local_address"
6790         methods.
6791
6792 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6793
6794         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6795         (riscv_fbsd_init_abi): Install gdbarch
6796         "fetch_tls_load_module_address" and "get_thread_local_address"
6797         methods.
6798
6799 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6800
6801         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6802         (i386fbsd_init_abi): Install gdbarch
6803         "fetch_tls_load_module_address" and "get_thread_local_address"
6804         methods.
6805
6806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6807
6808         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6809         (amd64fbsd_init_abi): Install gdbarch
6810         "fetch_tls_load_module_address" and "get_thread_local_address"
6811         methods.
6812
6813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6814
6815         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6816         (struct fbsd_pspace_data): New type.
6817         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6818         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6819         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6820         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6821         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6822
6823 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6824
6825         * gdbtypes.c (lookup_struct_elt): New function.
6826         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6827         * gdbtypes.h (struct struct_elt): New type.
6828         (lookup_struct_elt): New prototype.
6829
6830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6831
6832         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6833         remove disabled code block.
6834
6835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6836
6837         * gdbarch.sh (get_thread_local_address): New method.
6838         * gdbarch.h, gdbarch.c: Regenerate.
6839         * target.c (target_translate_tls_address): Use
6840         gdbarch_get_thread_local_address if present instead of
6841         target::get_thread_local_address.
6842
6843 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6844
6845         * target.h (target::get_thread_local_address): Update comment.
6846
6847 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6848
6849         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6850         objfile->separate_debug_objfile_backlink if not NULL.
6851
6852 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6853
6854         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6855         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6856         (amd64bsd_store_inferior_registers): Likewise.
6857         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6858         Enable segment base registers.
6859         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6860         PT_GETFSBASE and PT_GETGSBASE.
6861         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6862         PT_SETGSBASE.
6863         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6864         segment base registers.
6865         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6866
6867 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6868
6869         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6870         Update calls to i386_target_description to add 'segments'
6871         parameter.
6872         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6873         add segment base registers.
6874         * arch/i386.c (i386_create_target_description): Add 'segments'
6875         parameter to enable segment base registers.
6876         * arch/i386.h (i386_create_target_description): Likewise.
6877         * features/i386/32bit-segments.xml: New file.
6878         * features/i386/32bit-segments.c: Generate.
6879         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6880         call to i386_target_description to add 'segments' parameter.
6881         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6882         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6883         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6884         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6885         if feature is present.
6886         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6887         Add 'segments' parameter to call to i386_target_description.
6888         (i386_target_description): Add 'segments' parameter to enable
6889         segment base registers.
6890         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6891         to call to i386_target_description.
6892         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6893         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6894         Define I386_NUM_REGS.
6895         (i386_target_description): Add 'segments' parameter to enable
6896         segment base registers.
6897
6898 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6899
6900         PR/24325
6901         * source-cache.c: #undef open and close, to avoid unresolved
6902         externals during linking.
6903
6904 2019-03-12  Tom Tromey  <tromey@adacore.com>
6905
6906         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6907         const.  Add initializers.
6908         (_initialize_remote): Don't initialize ptid globals.
6909
6910 2019-03-12  Pedro Alves  <palves@redhat.com>
6911
6912         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6913
6914 2019-03-12  Pedro Alves  <palves@redhat.com>
6915
6916         * cp-name-parser.y (main): Remove unused 'len' variable.
6917
6918 2019-03-12  Tom Tromey  <tromey@adacore.com>
6919
6920         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6921         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6922
6923 2019-03-12  Tom Tromey  <tromey@adacore.com>
6924
6925         * linux-nat.c (iterate_over_lwps): Update.
6926         (stop_callback): Remove parameter.
6927         (stop_wait_callback, detach_callback, resume_set_callback)
6928         (select_singlestep_lwp_callback, set_ignore_sigint)
6929         (status_callback, resumed_callback, resume_clear_callback)
6930         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6931         data parameter.
6932         (linux_nat_target::detach, linux_nat_target::resume)
6933         (linux_stop_and_wait_all_lwps, select_event_lwp)
6934         (linux_nat_filter_event, linux_nat_wait_1)
6935         (linux_nat_target::kill, linux_nat_target::stop)
6936         (linux_nat_target::stop): Update.
6937         (linux_nat_resume_callback): Change type.
6938         (resume_stopped_resumed_lwps, count_events_callback)
6939         (select_event_lwp_callback): Likewise.
6940         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6941         * arm-linux-nat.c (struct update_registers_data): Remove.
6942         (update_registers_callback): Change type.
6943         (arm_linux_insert_hw_breakpoint1): Update.
6944         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6945         parameter.
6946         (x86_linux_dr_set_addr): Update.
6947         (x86_linux_dr_set_control): Update.
6948         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6949         (iterate_over_lwps): Use gdb::function_view.
6950         * nat/aarch64-linux-hw-point.c (struct
6951         aarch64_dr_update_callback_param): Remove.
6952         (debug_reg_change_callback): Change type.
6953         (aarch64_notify_debug_reg_change): Update.
6954         * s390-linux-nat.c (s390_refresh_per_info): Update.
6955
6956 2019-03-11  Tom Tromey  <tromey@adacore.com>
6957
6958         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6959         redundant assignment to "this_cu".
6960
6961 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6962
6963         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6964
6965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6966
6967         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6968         from...
6969         (rank_one_type): ... this.
6970
6971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6972
6973         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6974         from...
6975         (rank_one_type): ... this.
6976
6977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6978
6979         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6980         from...
6981         (rank_one_type): ... this.
6982
6983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6984
6985         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6986         from...
6987         (rank_one_type): ... this.
6988
6989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6990
6991         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6992         from...
6993         (rank_one_type): ... this.
6994
6995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6996
6997         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6998         from...
6999         (rank_one_type): ... this.
7000
7001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7002
7003         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7004         from...
7005         (rank_one_type): ... this.
7006
7007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7008
7009         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7010         from...
7011         (rank_one_type): ... this.
7012
7013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7014
7015         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7016         from...
7017         (rank_one_type): ... this.
7018
7019 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7020
7021         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7022         from...
7023         (rank_one_type): ... this.
7024
7025 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7026
7027         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7028         from...
7029         (rank_one_type): ... this.
7030
7031 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7032
7033         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7034         from...
7035         (rank_one_type): ... this.
7036
7037 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7038
7039         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7040         inferior-events' shows the example events.
7041
7042 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7043
7044         Support styling on native MS-Windows console
7045
7046         PR/24315
7047         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7048         on MS-Windows if $TERM is not defined.
7049
7050         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7051
7052         * posix-hdep.c (gdb_console_fputs):
7053         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7054         functions.
7055         * ui-file.h (gdb_console_fputs): Add prototype.
7056
7057         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7058         back to fputs only if the former returns zero.
7059
7060 2019-03-07  Tom Tromey  <tom@tromey.com>
7061
7062         * symmisc.c (print_symbol_bcache_statistics): Update.
7063         (print_objfile_statistics): Update.
7064         * symfile.c (allocate_symtab): Update.
7065         * stabsread.c: Don't include bcache.h.
7066         * psymtab.h (struct psymbol_bcache): Don't declare.
7067         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7068         (psymbol_bcache_init, psymbol_bcache_free)
7069         (psymbol_bcache_get_bcache): Don't declare.
7070         * psymtab.c (struct psymbol_bcache): Remove.
7071         (psymtab_storage::psymtab_storage): Update.
7072         (psymtab_storage::~psymtab_storage): Update.
7073         (psymbol_bcache_init, psymbol_bcache_free)
7074         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7075         (add_psymbol_to_bcache): Update.
7076         (allocate_psymtab): Update.
7077         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7078         macro_cache>: No longer pointers.
7079         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7080         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7081         * macrotab.c (macro_bcache): Update.
7082         * macroexp.c: Don't include bcache.h.
7083         * gdbtypes.c (check_types_worklist): Update.
7084         (types_deeply_equal): Remove TRY/CATCH.  Update.
7085         * elfread.c (elf_symtab_read): Update.
7086         * dwarf2read.c: Don't include bcache.h.
7087         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7088         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7089         (print_bcache_statistics, bcache_memory_used): Don't declare.
7090         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7091         methods.  Rename all data members.
7092         * bcache.c (struct bcache): Move to bcache.h.
7093         (bcache::expand_hash_table): Rename from expand_hash_table.
7094         (bcache): Remove.
7095         (bcache::insert): Rename from bcache_full.
7096         (bcache::compare): Rename from bcache_compare.
7097         (bcache_xmalloc): Remove.
7098         (bcache::~bcache): Rename from bcache_xfree.
7099         (bcache::print_statistics): Rename from print_bcache_statistics.
7100         (bcache::memory_used): Rename from bcache_memory_used.
7101
7102 2019-03-07  Pedro Alves  <palves@redhat.com>
7103
7104         * infrun.c (normal_stop): Also check for
7105         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7106
7107 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7108
7109         * f-lang.c (value_from_host_double): Moved to...
7110         * value.c (value_from_host_double): ...here.
7111         * value.h (value_from_host_double): Declare.
7112         * guile/scm-math.c (vlscm_convert_typed_number): Use
7113         value_from_host_double.
7114         (vlscm_convert_number): Likewise.
7115         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7116         * python/py-value.c (convert_value_from_python): Likewise.
7117
7118 2019-03-06  Tom Tromey  <tom@tromey.com>
7119
7120         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7121
7122 2019-03-06  Tom Tromey  <tom@tromey.com>
7123
7124         * utils.h (free_current_contents): Don't declare.
7125         * utils.c (free_current_contents): Remove.
7126
7127 2019-03-06  Tom Tromey  <tom@tromey.com>
7128
7129         * top.c (quit_force): Update.
7130         * main.c (captured_command_loop): Update.
7131         * common/new-op.c (operator new): Update.
7132         * common/common-exceptions.c (struct catcher)
7133         <save_cleanup_chain>: Remove member.
7134         (exceptions_state_mc_init): Update.
7135         (exception_try_scope_entry): Return nullptr.
7136         (exception_try_scope_exit, exception_rethrow)
7137         (throw_exception_sjlj, throw_exception_cxx): Update.
7138         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7139         (all_cleanups, do_cleanups, discard_cleanups)
7140         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7141         (restore_cleanups, restore_final_cleanups): Don't declare.
7142         (do_final_cleanups): Remove parameter.
7143         * common/cleanups.c (cleanup_chain, make_cleanup)
7144         (make_cleanup_dtor, all_cleanups, do_cleanups)
7145         (discard_my_cleanups, discard_cleanups)
7146         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7147         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7148         (null_cleanup): Remove.
7149         (do_final_cleanups): Remove parameter.
7150
7151 2019-03-06  Tom Tromey  <tom@tromey.com>
7152
7153         * remote.c (remote_target::remote_parse_stop_reply): Use
7154         unique_xmalloc_ptr.
7155
7156 2019-03-06  Tom Tromey  <tom@tromey.com>
7157
7158         * stabsread.c (struct stabs_field_info): Rename from field_info.
7159         <list, fnlist>: Add initializers.
7160         <obstack>: New member.
7161         (read_member_functions, read_struct_fields, read_baseclasses):
7162         Allocate on obstack.  Don't use cleanups.
7163         (read_one_struct_field, read_member_functions, read_struct_fields)
7164         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7165         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7166         (read_struct_type): Update.
7167
7168 2019-03-06  Tom Tromey  <tom@tromey.com>
7169
7170         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7171         * common/filestuff.h (make_cleanup_close): Don't declare.
7172         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7173         Remove.
7174
7175 2019-03-06  Tom Tromey  <tom@tromey.com>
7176
7177         * solib-aix.c: Use make_scope_exit.
7178
7179 2019-03-06  Tom Tromey  <tom@tromey.com>
7180
7181         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7182         Use make_scope_exit.
7183
7184 2019-03-06  Tom Tromey  <tom@tromey.com>
7185
7186         * solib-svr4.c (disable_probes_interface): Remove parameter.
7187         (svr4_handle_solib_event): Use make_scope_exit.
7188
7189 2019-03-06  Tom Tromey  <tom@tromey.com>
7190
7191         * remote.c (struct stop_reply_deleter): Remove.
7192         (stop_reply_up): Update.
7193         (struct stop_reply): Derive from notif_event.  Don't typedef.
7194         <regcache>: Now a std::vector.
7195         (stop_reply_xfree): Remove.
7196         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7197         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7198         (remote_target::discard_pending_stop_replies): Use delete.
7199         (remote_target::remote_parse_stop_reply): Update.
7200         (remote_target::process_stop_reply): Update.
7201         * remote-notif.h (struct notif_event): Add virtual destructor.
7202         Remove "dtr" member.
7203         (struct notif_client) <alloc_event>: Return a unique_ptr.
7204         (notif_event_xfree): Don't declare.
7205         (notif_event_up): New typedef.
7206         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7207         (notif_event_xfree, do_notif_event_xfree): Remove.
7208         (remote_notif_state_xfree): Update.
7209
7210 2019-03-06  Tom Tromey  <tom@tromey.com>
7211
7212         * infrun.c (displaced_step_clear_cleanup): Now a
7213         forward_scope_exit type.
7214         (displaced_step_prepare_throw): Update.
7215         (displaced_step_fixup): Update.
7216
7217 2019-03-06  Tom Tromey  <tom@tromey.com>
7218
7219         * inferior.h (class inferior): Update comment.
7220         * gdbthread.h (class thread_info): Update comment.
7221
7222 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7223             Tom Tromey  <tom@tromey.com>
7224
7225         * stabsread.h (struct stab_section_list): Remove.
7226         (coffstab_build_psymtabs): Update.
7227         * dbxread.c (symbuf_sections): Now a std::vector.
7228         (sect_idx): New global.
7229         (fill_symbuf): Update.
7230         (coffstab_build_psymtabs): Change type of stabsects parameter.
7231         Update.
7232         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7233         std::vector.
7234         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7235         (coff_locate_sections): Update.
7236         (coff_symfile_read): Remove cleanups.  Update.
7237         (init_stringtab): Add storage parameter.
7238         (free_stringtab, free_stringtab_cleanup): Remove.
7239         (init_lineno): Add storage parameter.
7240         (free_linetab, free_linetab_cleanup): Remove.
7241
7242 2019-03-06  Pedro Alves  <palves@redhat.com>
7243
7244         * linux-fork.c (fork_info::clobber_regs): Delete.
7245         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7246         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7247         comment.  Adjust.
7248         (scoped_switch_fork_info::scoped_switch_fork_info)
7249         (checkpoint_command, linux_fork_context): Adjust
7250         fork_save_infrun_state calls.
7251
7252 2019-03-06  Pedro Alves  <palves@redhat.com>
7253
7254         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7255         (inf_has_multiple_threads): Return 'bool' and rewrite using
7256         inferior_info::threads().
7257
7258 2019-03-06  Pedro Alves  <palves@redhat.com>
7259
7260         * linux-fork.c: Include <list>.
7261         (fork_list): Now a std::list instance.
7262         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7263         (forks_exist_p, find_last_fork): Adjust.
7264         (new_fork): Delete.
7265         (one_fork_p): New.
7266         (add_fork): Adjust.
7267         (free_fork): Delete, folded into fork_info::~fork_info().
7268         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7269         Adjust.
7270         (init_fork_list): Delete.
7271         (linux_fork_killall, linux_fork_mourn_inferior)
7272         (linux_fork_detach, info_checkpoints_command): Adjust.
7273         (_initialize_linux_fork): No longer call init_fork_list.
7274
7275 2019-03-06  Pedro Alves  <palves@redhat.com>
7276
7277         * linux-fork.c (new_fork): New, split out of ...
7278         (add_fork): ... this.  Return void.  Move "first fork" special
7279         case from here, to ...
7280         (checkpoint_command): ... here.
7281         * linux-linux.h (add_fork): Return void.
7282
7283 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7284
7285         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7286
7287 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7288             Chris January  <chris.january@arm.com>
7289             David Lecomber  <david.lecomber@arm.com>
7290
7291         * f-exp.y: New token, UNOP_INTRINSIC.
7292         (exp): New pattern using UNOP_INTRINSIC token.
7293         (f77_keywords): Add 'abs' keyword.
7294         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7295         (value_from_host_double): New function.
7296         (evaluate_subexp_f): Support UNOP_ABS.
7297
7298 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7299
7300         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7301         types.
7302
7303 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7304
7305         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7306         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7307         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7308
7309 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7310
7311         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7312
7313 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7314             Chris January  <chris.january@arm.com>
7315
7316         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7317         * f-exp.y: Define 'KIND' token.
7318         (exp): New pattern for KIND expressions.
7319         (ptype): Handle types with a kind extension.
7320         (direct_abs_decl): Extend to spot kind extensions.
7321         (f77_keywords): Add 'kind' to the list.
7322         (push_kind_type): New function.
7323         (convert_to_kind_type): New function.
7324         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7325         * parse.c (operator_length_standard): Likewise.
7326         * parser-defs.h (enum type_pieces): Add tp_kind.
7327         * std-operator.def: Add UNOP_KIND.
7328
7329 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7330
7331         * f-exp.y (f_parse): Set yydebug.
7332
7333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7334
7335         * f-lang.c (evaluate_subexp_f): New function.
7336         (exp_descriptor_f): New global.
7337         (f_language_defn): Use exp_descriptor_f instead of
7338         exp_descriptor_standard.
7339
7340 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7341
7342         * f-exp.y (struct token): Add comments.
7343         (dot_ops): Remove uppercase versions and the end marker.
7344         (f77_keywords): Likewise.
7345         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7346         entries in the dot_ops array are case insensitive, and use
7347         strncasecmp to compare strings.  Also some whitespace cleanup in
7348         this area.  Similar for the f77_keywords array, except entries in
7349         this list might be case sensitive.
7350
7351 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7352
7353         * f-exp.y (struct f77_boolean_val): Add comments.
7354         (boolean_values): Remove uppercase versions, and end marker.
7355         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7356         and use strncasecmp to achieve case insensitivity.  Additionally,
7357         perform whitespace cleanup around this code.
7358
7359 2019-03-06  Tom Tromey  <tromey@adacore.com>
7360
7361         * remote-sim.c (gdbsim_target_open): Use result of
7362         gdb_argv::release.
7363
7364 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7365         Dirk Schubert  <dirk.schubert@arm.com>
7366         Chris January  <chris.january@arm.com>
7367
7368         * eval.c (evaluate_subexp_standard): Call Fortran argument
7369         wrapping logic.
7370         * f-lang.c (struct value): A value which can be passed into a
7371         Fortran function call.
7372         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7373         where appropriate.
7374         (struct type): Value ready for a Fortran function call.
7375         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7376         is needed.
7377         * f-lang.h (fortran_argument_convert): Declaration.
7378         (fortran_preserve_arg_pointer): Declaration.
7379         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7380
7381 2019-03-05  Tom Tromey  <tromey@adacore.com>
7382
7383         * python/py-prettyprint.c (print_string_repr): Remove #if.
7384         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7385
7386 2019-03-05  Tom Tromey  <tromey@adacore.com>
7387
7388         * target.c (the_dummy_target): Move later.  Change type to
7389         "dummy_target".
7390         (initialize_targets): Don't initialize the_dummy_target.
7391
7392 2019-03-05  Tom Tromey  <tromey@adacore.com>
7393
7394         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7395         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7396
7397 2019-03-05  Tom Tromey  <tromey@adacore.com>
7398
7399         * windows-nat.c (windows_nat_target::attach)
7400         (windows_nat_target::detach): Don't call gdb_flush.
7401         * valprint.c (generic_val_print, val_print, val_print_string):
7402         Don't call gdb_flush.
7403         * utils.c (defaulted_query): Don't call gdb_flush.
7404         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7405         * target.c (target_announce_detach): Don't call gdb_flush.
7406         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7407         * remote.c (extended_remote_target::attach): Don't call
7408         gdb_flush.
7409         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7410         * printcmd.c (do_examine): Don't call gdb_flush.
7411         (info_display_command): Don't call gdb_flush.
7412         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7413         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7414         * memattr.c (info_mem_command): Don't call gdb_flush.
7415         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7416         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7417         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7418         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7419         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7420         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7421         (gnu_nat_target::detach): Don't call gdb_flush.
7422         * f-valprint.c (f_val_print): Don't call gdb_flush.
7423         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7424         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7425         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7426         gdb_flush.
7427         * c-valprint.c (c_val_print): Don't call gdb_flush.
7428         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7429
7430 2019-03-05  Tom Tromey  <tromey@adacore.com>
7431
7432         * varobj.c (update_dynamic_varobj_children): Update.
7433         (install_default_visualizer): Use reset, not release.
7434         * value.c (set_internalvar): Update.
7435         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7436         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7437         ATTRIBUTE_UNUSED_RESULT.
7438
7439 2019-03-05  Tom Tromey  <tromey@adacore.com>
7440
7441         * remote.c (class scoped_remote_fd) <release>: Add
7442         ATTRIBUTE_UNUSED_RESULT.
7443
7444 2019-03-05  Tom Tromey  <tromey@adacore.com>
7445
7446         * macroexp.c (struct macro_buffer) <release>: Add
7447         ATTRIBUTE_UNUSED_RESULT.
7448
7449 2019-03-05  Tom Tromey  <tromey@adacore.com>
7450
7451         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7452         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7453         ATTRIBUTE_UNUSED_RESULT.
7454
7455 2019-03-05  Tom Tromey  <tromey@adacore.com>
7456
7457         * common/scoped_fd.h (class scoped_fd) <release>: Add
7458         ATTRIBUTE_UNUSED_RESULT.
7459
7460 2019-03-05  Tom Tromey  <tromey@adacore.com>
7461
7462         * parser-defs.h (struct parser_state) <release>: Add
7463         ATTRIBUTE_UNUSED_RESULT.
7464
7465 2019-03-05  Tom Tromey  <tromey@adacore.com>
7466
7467         * utils.h (class gdb_argv) <release>: Add
7468         ATTRIBUTE_UNUSED_RESULT.
7469         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7470
7471 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7472
7473         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7474         for-loop range, to avoid compiler warnings.
7475
7476         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7477         avoid compiler warnings about unused variables.
7478
7479         * NEWS: Mention end of support for native debugging on MS-Windows
7480         before XP.
7481
7482         PR gdb/24292
7483         * common/netstuff.c:
7484         * gdbserver/gdbreplay.c
7485         * gdbserver/remote-utils.c:
7486         * ser-tcp.c:
7487         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7488         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7489         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7490         'getaddrinfo' and 'freeaddrinfo' were not available before
7491         Windows XP, and mingw.org's MinGW headers by default define
7492         _WIN32_WINNT to 0x500.
7493
7494 2019-03-01  Gary Benson <gbenson@redhat.com>
7495
7496         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7497
7498 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7499             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7500
7501         PR gdb/8527
7502         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7503         set_sigint_trap, clear_sigint_trap.
7504
7505 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7506
7507         * target.c (target_detach): Clear the regcache and the
7508         frame cache.
7509
7510 2019-02-27  Pedro Alves  <palves@redhat.com>
7511
7512         * utils.c (set_screen_size): When we cap the height/width sizes,
7513         tweak the corresponding command variable to show "unlimited":
7514
7515 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7516             Pedro Alves  <palves@redhat.com>
7517
7518         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7519         before calling rl_set_screen_size.
7520
7521 2019-02-27  Tom Tromey  <tromey@adacore.com>
7522
7523         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7524         define.
7525         * python/py-value.c: Remove Python 2.4 workaround.
7526         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7527         workaround.
7528         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7529         Python 2.4 workaround.
7530         * python/python-internal.h: Remove Python 2.4 comment.
7531         (Py_ssize_t): Don't define.
7532         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7533         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7534         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7535         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7536         * python/python.c (do_start_initialization): Remove Python 2.4
7537         workaround.
7538         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7539         (print_children): Remove Python 2.4 workaround.
7540         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7541         workaround.
7542         (CHARBUFFERPROC_NAME): Remove.
7543         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7544         Python 2.4 workaround.
7545
7546 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7547
7548         * NEWS: Note minimum Python version.
7549
7550 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7551
7552         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7553         code from these functions.  Remove corresponding ifdefs.  Use
7554         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7555         Remove gotos and target of gotos.
7556         (infpy_search_memory): Likewise.
7557
7558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7559
7560         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7561         (hppa_gdbarch_init): Don't register deleted functions with
7562         gdbarch.
7563
7564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7565
7566         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7567         (h8300_unwind_sp): Delete.
7568         (h8300_dummy_id): Delete.
7569         (h8300_gdbarch_init): Don't register deleted functions with
7570         gdbarch.
7571
7572 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7573
7574         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7575         (ft32_unwind_pc): Delete.
7576         (ft32_unwind_sp): Delete.
7577         (ft32_gdbarch_init): Don't register deleted functions with
7578         gdbarch.
7579
7580 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7581
7582         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7583         (frv_unwind_pc): Delete.
7584         (frv_unwind_sp): Delete.
7585         (frv_gdbarch_init): Don't register deleted functions with
7586         gdbarch.
7587
7588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7589
7590         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7591         (riscv_unwind_pc): Delete.
7592         (riscv_unwind_sp): Delete.
7593         (riscv_gdbarch_init): Don't register deleted functions with
7594         gdbarch.
7595
7596 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7597
7598         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7599         (csky_unwind_pc): Delete.
7600         (csky_unwind_sp): Delete.
7601         (csky_gdbarch_init): Don't register deleted functions with
7602         gdbarch.
7603
7604 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7605
7606         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7607         (cris_unwind_pc): Delete.
7608         (cris_unwind_sp): Delete.
7609         (cris_gdbarch_init): Don't register deleted functions with
7610         gdbarch.
7611
7612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7613
7614         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7615         (bfin_unwind_pc): Delete.
7616         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7617
7618 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7619
7620         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7621         (arm_unwind_pc): Delete.
7622         (arm_unwind_sp): Delete.
7623         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7624
7625 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7626
7627         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7628         (arc_unwind_pc): Delete.
7629         (arc_unwind_sp): Delete.
7630         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7631
7632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7635         (alpha_unwind_pc): Delete.
7636         (alpha_gdbarch_init): Don't register deleted functions with
7637         gdbarch.
7638
7639 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7640
7641         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7642         (aarch64_unwind_pc): Delete.
7643         (aarch64_unwind_sp): Delete.
7644         (aarch64_gdbarch_init): Don't register deleted functions with
7645         gdbarch.
7646
7647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7648
7649         * gdbtypes.c (type_align): Don't consider static members when
7650         computing structure alignment.
7651
7652 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7653
7654         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7655         return 0 for other types.
7656         * arch-utils.c (default_type_align): Always return 0.
7657         * gdbarch.h: Regenerate.
7658         * gdbarch.sh (type_align): Extend comment.
7659         * gdbtypes.c (type_align): Add additional comments, always call
7660         gdbarch_type_align before applying the default rules.
7661         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7662         generic code will then apply a suitable default.
7663         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7664         types, return 0 for other types.
7665
7666 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7667
7668         * NEWS: Create a new section for the next release branch.
7669         Rename the section of the current branch, now that it has
7670         been cut.
7671
7672 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7673
7674         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7675         * version.in: Bump version to 8.3.50.DATE-git.
7676
7677 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7678
7679         * aix-thread.c (ptid_cmp): Remove unused variable.
7680         (get_signaled_thread): Likewise.
7681         (store_regs_user_thread): Likewise.
7682         (store_regs_kernel_thread): Likewise.
7683         (fetch_regs_kernel_thread): Remove shadowed variable.
7684
7685 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7686
7687         * features/riscv/32bit-cpu.xml: Add register numbers.
7688         * features/riscv/32bit-fpu.c: Regenerate.
7689         * features/riscv/32bit-fpu.xml: Add register numbers.
7690         * features/riscv/64bit-cpu.xml: Add register numbers.
7691         * features/riscv/64bit-fpu.c: Regenerate.
7692         * features/riscv/64bit-fpu.xml: Add register numbers.
7693
7694 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7695
7696         * NEWS: Mention two argument form of gdb.Value constructor.
7697         * python/py-value.c (convert_buffer_and_type_to_value): New
7698         function.
7699         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7700         Add support for handling an optional second argument.  Call
7701         convert_buffer_and_type_to_value as appropriate.
7702         * python/python-internal.h (Py_buffer_deleter): New struct.
7703         (Py_buffer_up): New typedef.
7704
7705 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7706
7707         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7708         instead of releasing ownership.
7709
7710 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7711
7712         * dwarf2read.c (open_and_init_dwp_file): Call
7713         elf_numsections instead of bfd_count_sections to initialize
7714         dwp_file->num_sections.
7715
7716 2019-02-25  Tom Tromey  <tromey@adacore.com>
7717
7718         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7719
7720 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7721
7722         * gcore.in: Add '--readnever' option when invoking GDB.
7723
7724 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7725
7726         * MAINTAINERS: Update my email address.
7727
7728 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7729
7730         * build-id.c (build_id_to_debug_bfd_1): New function.
7731         (build_id_to_debug_bfd): Look for separate debug file in
7732         sysroot.
7733
7734 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7735
7736         * gdbarch.sh: Update the copyright year range that is placed into
7737         generated files.
7738
7739 2019-02-22  Keith Seitz  <keiths@redhat.com>
7740
7741         PR symtab/23853
7742         * linespec.c (create_sals_line_offset): Search for the default
7743         symtab's filename instead of its fullname.
7744
7745 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7746
7747         * NEWS: Update style defaults.
7748
7749 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7750
7751         * main.c (captured_main_1): Disable styling in batch mode.
7752
7753 2019-02-20  Tom Tromey  <tom@tromey.com>
7754
7755         * symtab.c (symtab_symbol_info): Fix typos.
7756
7757 2019-02-20  Tom Tromey  <tromey@adacore.com>
7758
7759         * findcmd.c (_initialize_mem_search): Use upper case for
7760         metasyntactic variables.
7761
7762 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7763
7764         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7765         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7766
7767 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7768
7769         * top.h (source_file_name): Change to std::string.
7770         * top.c (source_file_name): Likewise.
7771         (command_line_input): Adjust.
7772         * cli/cli-script.c (script_from_file): Adjust.
7773
7774 2019-02-19  Tom Tromey  <tromey@adacore.com>
7775
7776         * ravenscar-thread.c
7777         (ravenscar_thread_target::update_thread_list): Don't call
7778         ada_build_task_list.
7779         * ada-lang.h (ada_build_task_list): Don't declare.
7780         * ada-tasks.c (struct ada_tasks_inferior_data)
7781         <task_list_valid_p>: Now bool.
7782         (read_known_tasks, ada_task_list_changed)
7783         (ada_tasks_invalidate_inferior_data): Update.
7784         (read_known_tasks_array): Return bool.
7785         (read_known_tasks_list): Likewise.
7786         (read_known_tasks): Return void.
7787         (ada_build_task_list): Now static.
7788
7789 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7792         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7793
7794 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7795
7796         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7797         variant for ada_tasks_pspace_data_handle and
7798         ada_tasks_inferior_data_handle.
7799         (ada_tasks_pspace_data_cleanup): New function.
7800         (ada_tasks_inferior_data_cleanup): New function.
7801
7802 2019-02-17  Tom Tromey  <tom@tromey.com>
7803
7804         * macrotab.h (macro_source_fullname): Return a std::string.
7805         * macrotab.c (macro_include, check_for_redefinition)
7806         (macro_undef, macro_lookup_definition, foreach_macro)
7807         (foreach_macro_in_scope): Update.
7808         (macro_source_fullname): Return a std::string.
7809         * macrocmd.c (show_pp_source_pos): Update.
7810
7811 2019-02-17  Tom Tromey  <tom@tromey.com>
7812
7813         * macrocmd.c (show_pp_source_pos): Style the file names.
7814
7815 2019-02-17  Tom Tromey  <tom@tromey.com>
7816
7817         PR tui/24197:
7818         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7819
7820 2019-02-17  Tom Tromey  <tom@tromey.com>
7821
7822         * ada-lang.c (user_select_syms): Use filtered printing.
7823         * utils.c (wrap_style): New global.
7824         (desired_style): Remove.
7825         (emit_style_escape): Add stream parameter.
7826         (set_output_style, reset_terminal_style, prompt_for_continue):
7827         Update.
7828         (flush_wrap_buffer): Only flush gdb_stdout.
7829         (wrap_here): Set wrap_style.
7830         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7831         treat escape sequences as a character.  Change when wrap buffer is
7832         flushed.
7833         (fputs_styled): Do not set the output style when the default is
7834         requested.
7835         * ui-style.h (struct ui_file_style) <is_default>: New method.
7836         * source.c (print_source_lines_base): Emit escape sequences in one
7837         piece.
7838
7839 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7840
7841         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7842         integers and enumeration types.
7843
7844 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7845
7846         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7847         instead of lookup_symbol_in_language
7848         (do_exact_match): New function.
7849         (ada_get_symbol_name_matcher): Return do_exact_match when
7850         doing a verbatim match.
7851
7852 2019-02-15  Tom Tromey  <tromey@adacore.com>
7853
7854         * ravenscar-thread.c (ravenscar_thread_target::resume)
7855         (ravenscar_thread_target::wait): Special case wildcard requests.
7856
7857 2019-02-15  Tom Tromey  <tromey@adacore.com>
7858
7859         * ravenscar-thread.c (base_ptid): Remove.
7860         (struct ravenscar_thread_target) <close>: New method.
7861         <m_base_ptid>: New member.
7862         <update_inferior_ptid, active_task, task_is_currently_active,
7863         runtime_initialized>: Declare methods.
7864         <ravenscar_thread_target>: Add constructor.
7865         (ravenscar_thread_target::task_is_currently_active)
7866         (ravenscar_thread_target::update_inferior_ptid)
7867         (ravenscar_runtime_initialized): Rename.  Now methods.
7868         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7869         (ravenscar_thread_target::update_thread_list): Update.
7870         (ravenscar_thread_target::active_task): Now method.
7871         (ravenscar_thread_target::store_registers)
7872         (ravenscar_thread_target::prepare_to_store)
7873         (ravenscar_thread_target::prepare_to_store)
7874         (ravenscar_thread_target::mourn_inferior): Update.
7875         (ravenscar_inferior_created): Use "new" to create target.
7876         (ravenscar_thread_target::get_ada_task_ptid): Update.
7877         (_initialize_ravenscar): Don't initialize base_ptid.
7878         (ravenscar_ops): Remove global.
7879
7880 2019-02-15  Tom Tromey  <tromey@adacore.com>
7881
7882         * target.h (push_target): Declare new overload.
7883         * target.c (push_target): New overload, taking an rvalue reference.
7884         * remote.c (remote_target::open_1): Use push_target overload.
7885         * corelow.c (core_target_open): Use push_target overload.
7886
7887 2019-02-15  Tom Tromey  <tromey@adacore.com>
7888
7889         * ravenscar-thread.c (is_ravenscar_task)
7890         (ravenscar_task_is_currently_active): Return bool.
7891         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7892         (_initialize_ravenscar): Remove "(void)".
7893         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7894         Return bool.
7895
7896 2019-02-15  Tom Tromey  <tromey@adacore.com>
7897
7898         * ravenscar-thread.c (ravenscar_runtime_initializer)
7899         (has_ravenscar_runtime, get_running_thread_id)
7900         (ravenscar_thread_target::resume): Fix indentation.
7901
7902 2019-02-15  Tom Tromey  <tromey@adacore.com>
7903
7904         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7905         from ravenscar_arch_ops.
7906         (sparc_ravenscar_ops::fetch_registers)
7907         (sparc_ravenscar_ops::store_registers): Now methods.
7908         (sparc_ravenscar_prepare_to_store): Remove.
7909         (sparc_ravenscar_ops): Redefine.
7910         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7911         methods and destructor.  Remove members.
7912         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7913         (ravenscar_thread_target::store_registers)
7914         (ravenscar_thread_target::prepare_to_store): Update.
7915         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7916         Remove.
7917         (struct ppc_ravenscar_powerpc_ops): Derive from
7918         ravenscar_arch_ops.
7919         (ppc_ravenscar_powerpc_ops::fetch_registers)
7920         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7921         (ppc_ravenscar_powerpc_ops): Redefine.
7922         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7923         (ppc_ravenscar_e500_ops::fetch_registers)
7924         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7925         (ppc_ravenscar_e500_ops): Redefine.
7926         * aarch64-ravenscar-thread.c
7927         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7928         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7929         (aarch64_ravenscar_fetch_registers)
7930         (aarch64_ravenscar_store_registers): Now methods.
7931         (aarch64_ravenscar_ops): Redefine.
7932
7933 2019-02-15  Tom Tromey  <tromey@adacore.com>
7934
7935         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7936         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7937         (ravenscar_thread_target::stopped_by_watchpoint)
7938         (ravenscar_thread_target::stopped_data_address)
7939         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7940
7941 2019-02-15  Tom Tromey  <tromey@adacore.com>
7942
7943         * ravenscar-thread.c: Fix some typos.
7944
7945 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7946             Tom Tromey  <tromey@adacore.com>
7947
7948         * ada-lang.c (ada_exception_sal): Change addr_string to a
7949         std::string.
7950         (create_ada_exception_catchpoint): Update.
7951
7952 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7953             Tom Tromey  <tromey@adacore.com>
7954
7955         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7956         (bp_location_ops): Remove.
7957         (base_breakpoint_allocate_location): Update.
7958         (free_bp_location): Update.
7959         * ada-lang.c (class ada_catchpoint_location)
7960         <ada_catchpoint_location>: Remove ops parameter.
7961         (ada_catchpoint_location_dtor): Remove.
7962         (ada_catchpoint_location_ops): Remove.
7963         (allocate_location_exception): Update.
7964         * breakpoint.h (struct bp_location_ops): Remove.
7965         (class bp_location) <bp_location>: Remove bp_location_ops
7966         parameter.
7967         <~bp_location>: Add destructor.
7968         <ops>: Remove.
7969
7970 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7971             Pedro Alves  <palves@redhat.com>
7972
7973         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7974         'PATH_MAX'.
7975
7976 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7977             Samuel Thibault  <samuel.thibault@gnu.org>
7978             Thomas Schwinge  <thomas@codesourcery.com>
7979
7980         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7981         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7982
7983 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7984
7985         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7986         (check_empty): Use "const char *".
7987
7988         * gnu-nat.c (gnu_nat_target::detach): Instead of
7989         'detach_inferior (pid)' call
7990         'detach_inferior (find_inferior_pid (pid))'.
7991
7992         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7993         'nat/fork-inferior.o'.
7994         * gnu-nat.c: #include "nat/fork-inferior.h".
7995
7996         * gnu-nat.c (gnu_nat_target::detach): Instead of
7997         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7998         * gnu-nat.h: #include "inf-child.h".
7999         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8000         'i386_gnu_nat_target::fetch_registers'.
8001         (gnu_store_registers): Rename/move to
8002         'i386_gnu_nat_target::store_registers'.
8003
8004         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8005         * gnu-nat.h (mach_thread_info): New function.
8006         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8007
8008         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8009
8010 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8011
8012         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8013
8014 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8015
8016         * windows-nat.c (windows_add_thread): Add new parameter
8017         "main_thread_p" with default value set to false.  Update
8018         function documentation as well as all callers.
8019         (windows_delete_thread): Likewise.
8020         (fake_create_process): Update call to windows_add_thread.
8021         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8022         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8023         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8024         call to windows_delete_thread.
8025
8026 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8027
8028         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8029
8030 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8031
8032         * symfile.c (find_separate_debug_file): Use canonical path of
8033         sysroot with child_path instead of gdb_sysroot if it is valid.
8034
8035 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8036
8037         * symfile.c (find_separate_debug_file): Use child_path to
8038         determine if an object file is under a sysroot.
8039
8040 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8041
8042         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8043         unittests/child-path-selftests.c.
8044         * common/pathstuff.c (child_path): New function.
8045         * common/pathstuff.h (child_path): New prototype.
8046         * unittests/child-path-selftests.c: New file.
8047
8048 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8049
8050         * symfile.c (find_separate_debug_file): Look for separate debug
8051         files in debug directories under the sysroot.
8052
8053 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8054
8055         * symtab.h (struct minimal_symbol data_p): New const method.
8056         (struct minimal_symbol text_p): Likewise.
8057         * symtab.c (output_source_filename): Use file name style
8058         to print file name.
8059         (print_symbol_info): Likewise.
8060         (print_msymbol_info): Use address style to print addresses.
8061         Use function name style to print executable text symbols.
8062         (expand_symtab_containing_pc): Use data_p.
8063         (find_pc_sect_compunit_symtab): Likewise.
8064
8065 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8066
8067         * breakpoint.c (describe_other_breakpoints): Use address style
8068         to print addresses.
8069         (say_where): Likewise.
8070
8071 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8072
8073         * ada-typeprint.c (print_func_type): Print function name
8074         style to print function name.
8075         * c-typeprint.c (c_print_type_1): Likewise.
8076
8077 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8078
8079         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8080         for execve.
8081
8082 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8083
8084         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8085         type_stack.
8086
8087 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8088
8089         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8090         TYPE_CODE_REF types.
8091
8092 2019-02-08  Jim Wilson  <jimw@sifive.com>
8093
8094         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8095         (riscv_linux_fregset): New.
8096         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8097
8098 2019-02-07  Tom Tromey  <tom@tromey.com>
8099
8100         * thread.c (thread_cancel_execution_command): Update.
8101         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8102         methods.
8103         (struct thread_fsm_ops): Remove.
8104         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8105         (thread_fsm_should_stop, thread_fsm_return_value)
8106         (thread_fsm_set_finished, thread_fsm_finished_p)
8107         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8108         Don't declare.
8109         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8110         * infrun.c (clear_proceed_status_thread)
8111         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8112         (print_stop_event): Update.
8113         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8114         Add constructor.
8115         (step_command_fsm_ops): Remove.
8116         (new_step_command_fsm): Remove.
8117         (step_1): Update.
8118         (step_command_fsm::should_stop): Rename from
8119         step_command_fsm_should_stop.
8120         (step_command_fsm::clean_up): Rename from
8121         step_command_fsm_clean_up.
8122         (step_command_fsm::do_async_reply_reason): Rename from
8123         step_command_fsm_async_reply_reason.
8124         (struct until_next_fsm): Inherit from thread_fsm.  Add
8125         constructor.
8126         (until_next_fsm_ops): Remove.
8127         (new_until_next_fsm): Remove.
8128         (until_next_fsm::should_stop): Rename from
8129         until_next_fsm_should_stop.
8130         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8131         (until_next_fsm::do_async_reply_reason): Rename from
8132         until_next_fsm_async_reply_reason.
8133         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8134         constructor.  Change type of breakpoint.
8135         (finish_command_fsm_ops): Remove.
8136         (new_finish_command_fsm): Remove.
8137         (finish_command_fsm::should_stop): Rename from
8138         finish_command_fsm_should_stop.
8139         (finish_command_fsm::clean_up): Rename from
8140         finish_command_fsm_clean_up.
8141         (finish_command_fsm::return_value): Rename from
8142         finish_command_fsm_return_value.
8143         (finish_command_fsm::do_async_reply_reason): Rename from
8144         finish_command_fsm_async_reply_reason.
8145         (finish_command): Update.
8146         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8147         Add constructor.
8148         (call_thread_fsm_ops): Remove.
8149         (call_thread_fsm::call_thread_fsm): Rename from
8150         new_call_thread_fsm.
8151         (call_thread_fsm::should_stop): Rename from
8152         call_thread_fsm_should_stop.
8153         (call_thread_fsm::should_notify_stop): Rename from
8154         call_thread_fsm_should_notify_stop.
8155         (run_inferior_call, call_function_by_hand_dummy): Update.
8156         * cli/cli-interp.c (should_print_stop_to_console): Update.
8157         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8158         Add constructor.  Change type of location_breakpoint,
8159         caller_breakpoint.
8160         (until_break_fsm_ops): Remove.
8161         (new_until_break_fsm): Remove.
8162         (until_break_fsm::should_stop): Rename from
8163         until_break_fsm_should_stop.
8164         (until_break_fsm::clean_up): Rename from
8165         until_break_fsm_clean_up.
8166         (until_break_fsm::do_async_reply_reason): Rename from
8167         until_break_fsm_async_reply_reason.
8168         (until_break_command): Update.
8169         * thread-fsm.c: Remove.
8170         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8171
8172 2019-02-07  Tom Tromey  <tom@tromey.com>
8173
8174         * yy-remap.h: Add include guard.
8175         * xtensa-tdep.h: Add include guard.
8176         * xcoffread.h: Rename include guard.
8177         * varobj-iter.h: Add include guard.
8178         * tui/tui.h: Rename include guard.
8179         * tui/tui-winsource.h: Rename include guard.
8180         * tui/tui-wingeneral.h: Rename include guard.
8181         * tui/tui-windata.h: Rename include guard.
8182         * tui/tui-win.h: Rename include guard.
8183         * tui/tui-stack.h: Rename include guard.
8184         * tui/tui-source.h: Rename include guard.
8185         * tui/tui-regs.h: Rename include guard.
8186         * tui/tui-out.h: Rename include guard.
8187         * tui/tui-layout.h: Rename include guard.
8188         * tui/tui-io.h: Rename include guard.
8189         * tui/tui-hooks.h: Rename include guard.
8190         * tui/tui-file.h: Rename include guard.
8191         * tui/tui-disasm.h: Rename include guard.
8192         * tui/tui-data.h: Rename include guard.
8193         * tui/tui-command.h: Rename include guard.
8194         * tic6x-tdep.h: Add include guard.
8195         * target/waitstatus.h: Rename include guard.
8196         * target/wait.h: Rename include guard.
8197         * target/target.h: Rename include guard.
8198         * target/resume.h: Rename include guard.
8199         * target-float.h: Rename include guard.
8200         * stabsread.h: Add include guard.
8201         * rs6000-tdep.h: Add include guard.
8202         * riscv-fbsd-tdep.h: Add include guard.
8203         * regformats/regdef.h: Rename include guard.
8204         * record.h: Rename include guard.
8205         * python/python.h: Rename include guard.
8206         * python/python-internal.h: Rename include guard.
8207         * python/py-stopevent.h: Rename include guard.
8208         * python/py-ref.h: Rename include guard.
8209         * python/py-record.h: Rename include guard.
8210         * python/py-record-full.h: Rename include guard.
8211         * python/py-record-btrace.h: Rename include guard.
8212         * python/py-instruction.h: Rename include guard.
8213         * python/py-events.h: Rename include guard.
8214         * python/py-event.h: Rename include guard.
8215         * procfs.h: Add include guard.
8216         * proc-utils.h: Add include guard.
8217         * p-lang.h: Add include guard.
8218         * or1k-tdep.h: Rename include guard.
8219         * observable.h: Rename include guard.
8220         * nto-tdep.h: Rename include guard.
8221         * nat/x86-linux.h: Rename include guard.
8222         * nat/x86-linux-dregs.h: Rename include guard.
8223         * nat/x86-gcc-cpuid.h: Add include guard.
8224         * nat/x86-dregs.h: Rename include guard.
8225         * nat/x86-cpuid.h: Rename include guard.
8226         * nat/ppc-linux.h: Rename include guard.
8227         * nat/mips-linux-watch.h: Rename include guard.
8228         * nat/linux-waitpid.h: Rename include guard.
8229         * nat/linux-ptrace.h: Rename include guard.
8230         * nat/linux-procfs.h: Rename include guard.
8231         * nat/linux-osdata.h: Rename include guard.
8232         * nat/linux-nat.h: Rename include guard.
8233         * nat/linux-namespaces.h: Rename include guard.
8234         * nat/linux-btrace.h: Rename include guard.
8235         * nat/glibc_thread_db.h: Rename include guard.
8236         * nat/gdb_thread_db.h: Rename include guard.
8237         * nat/gdb_ptrace.h: Rename include guard.
8238         * nat/fork-inferior.h: Rename include guard.
8239         * nat/amd64-linux-siginfo.h: Rename include guard.
8240         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8241         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8242         * nat/aarch64-linux.h: Rename include guard.
8243         * nat/aarch64-linux-hw-point.h: Rename include guard.
8244         * mn10300-tdep.h: Add include guard.
8245         * mips-linux-tdep.h: Add include guard.
8246         * mi/mi-parse.h: Rename include guard.
8247         * mi/mi-out.h: Rename include guard.
8248         * mi/mi-main.h: Rename include guard.
8249         * mi/mi-interp.h: Rename include guard.
8250         * mi/mi-getopt.h: Rename include guard.
8251         * mi/mi-console.h: Rename include guard.
8252         * mi/mi-common.h: Rename include guard.
8253         * mi/mi-cmds.h: Rename include guard.
8254         * mi/mi-cmd-break.h: Rename include guard.
8255         * m2-lang.h: Add include guard.
8256         * location.h: Rename include guard.
8257         * linux-record.h: Rename include guard.
8258         * linux-nat.h: Add include guard.
8259         * linux-fork.h: Add include guard.
8260         * i386-darwin-tdep.h: Rename include guard.
8261         * hppa-linux-offsets.h: Add include guard.
8262         * guile/guile.h: Rename include guard.
8263         * guile/guile-internal.h: Rename include guard.
8264         * gnu-nat.h: Rename include guard.
8265         * gdb-stabs.h: Rename include guard.
8266         * frv-tdep.h: Add include guard.
8267         * f-lang.h: Add include guard.
8268         * event-loop.h: Add include guard.
8269         * darwin-nat.h: Rename include guard.
8270         * cp-abi.h: Rename include guard.
8271         * config/sparc/nm-sol2.h: Rename include guard.
8272         * config/nm-nto.h: Rename include guard.
8273         * config/nm-linux.h: Add include guard.
8274         * config/i386/nm-i386gnu.h: Rename include guard.
8275         * config/djgpp/nl_types.h: Rename include guard.
8276         * config/djgpp/langinfo.h: Rename include guard.
8277         * compile/gcc-cp-plugin.h: Add include guard.
8278         * compile/gcc-c-plugin.h: Add include guard.
8279         * compile/compile.h: Rename include guard.
8280         * compile/compile-object-run.h: Rename include guard.
8281         * compile/compile-object-load.h: Rename include guard.
8282         * compile/compile-internal.h: Rename include guard.
8283         * compile/compile-cplus.h: Rename include guard.
8284         * compile/compile-c.h: Rename include guard.
8285         * common/xml-utils.h: Rename include guard.
8286         * common/x86-xstate.h: Rename include guard.
8287         * common/version.h: Rename include guard.
8288         * common/vec.h: Rename include guard.
8289         * common/tdesc.h: Rename include guard.
8290         * common/selftest.h: Rename include guard.
8291         * common/scoped_restore.h: Rename include guard.
8292         * common/scoped_mmap.h: Rename include guard.
8293         * common/scoped_fd.h: Rename include guard.
8294         * common/safe-iterator.h: Rename include guard.
8295         * common/run-time-clock.h: Rename include guard.
8296         * common/refcounted-object.h: Rename include guard.
8297         * common/queue.h: Rename include guard.
8298         * common/ptid.h: Rename include guard.
8299         * common/print-utils.h: Rename include guard.
8300         * common/preprocessor.h: Rename include guard.
8301         * common/pathstuff.h: Rename include guard.
8302         * common/observable.h: Rename include guard.
8303         * common/netstuff.h: Rename include guard.
8304         * common/job-control.h: Rename include guard.
8305         * common/host-defs.h: Rename include guard.
8306         * common/gdb_wait.h: Rename include guard.
8307         * common/gdb_vecs.h: Rename include guard.
8308         * common/gdb_unlinker.h: Rename include guard.
8309         * common/gdb_unique_ptr.h: Rename include guard.
8310         * common/gdb_tilde_expand.h: Rename include guard.
8311         * common/gdb_sys_time.h: Rename include guard.
8312         * common/gdb_string_view.h: Rename include guard.
8313         * common/gdb_splay_tree.h: Rename include guard.
8314         * common/gdb_setjmp.h: Rename include guard.
8315         * common/gdb_ref_ptr.h: Rename include guard.
8316         * common/gdb_optional.h: Rename include guard.
8317         * common/gdb_locale.h: Rename include guard.
8318         * common/gdb_assert.h: Rename include guard.
8319         * common/filtered-iterator.h: Rename include guard.
8320         * common/filestuff.h: Rename include guard.
8321         * common/fileio.h: Rename include guard.
8322         * common/environ.h: Rename include guard.
8323         * common/common-utils.h: Rename include guard.
8324         * common/common-types.h: Rename include guard.
8325         * common/common-regcache.h: Rename include guard.
8326         * common/common-inferior.h: Rename include guard.
8327         * common/common-gdbthread.h: Rename include guard.
8328         * common/common-exceptions.h: Rename include guard.
8329         * common/common-defs.h: Rename include guard.
8330         * common/common-debug.h: Rename include guard.
8331         * common/cleanups.h: Rename include guard.
8332         * common/buffer.h: Rename include guard.
8333         * common/btrace-common.h: Rename include guard.
8334         * common/break-common.h: Rename include guard.
8335         * cli/cli-utils.h: Rename include guard.
8336         * cli/cli-style.h: Rename include guard.
8337         * cli/cli-setshow.h: Rename include guard.
8338         * cli/cli-script.h: Rename include guard.
8339         * cli/cli-interp.h: Rename include guard.
8340         * cli/cli-decode.h: Rename include guard.
8341         * cli/cli-cmds.h: Rename include guard.
8342         * charset-list.h: Add include guard.
8343         * buildsym-legacy.h: Rename include guard.
8344         * bfin-tdep.h: Add include guard.
8345         * ax.h: Rename include guard.
8346         * arm-linux-tdep.h: Add include guard.
8347         * arm-fbsd-tdep.h: Add include guard.
8348         * arch/xtensa.h: Rename include guard.
8349         * arch/tic6x.h: Add include guard.
8350         * arch/i386.h: Add include guard.
8351         * arch/arm.h: Rename include guard.
8352         * arch/arm-linux.h: Rename include guard.
8353         * arch/arm-get-next-pcs.h: Rename include guard.
8354         * arch/amd64.h: Add include guard.
8355         * arch/aarch64-insn.h: Rename include guard.
8356         * arch-utils.h: Rename include guard.
8357         * annotate.h: Add include guard.
8358         * amd64-darwin-tdep.h: Rename include guard.
8359         * aarch64-linux-tdep.h: Add include guard.
8360         * aarch64-fbsd-tdep.h: Add include guard.
8361         * aarch32-linux-nat.h: Add include guard.
8362
8363 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8364
8365         * macrotab.c (macro_define_internal): New function that
8366         factorizes macro_define_object_internal and macro_define_function
8367         code.
8368         (macro_define_object_internal): Use macro_define_internal.
8369         (macro_define_function): Likewise.
8370
8371 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8372
8373         * macrocmd.c (extract_identifier): Return
8374         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8375         callers.
8376
8377 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8378
8379         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8380
8381 2019-02-05  Tom Tromey  <tom@tromey.com>
8382
8383         * target.c (target_stack::unpush): Move assertion earlier.
8384
8385 2019-01-30  Tom Tromey  <tom@tromey.com>
8386
8387         PR python/23615:
8388         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8389         (gdbpy_parse_and_eval): Likewise.
8390         * python/python-internal.h (gdbpy_allow_threads): New class.
8391
8392 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8393
8394         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8395         (aarch64_fbsd_fpregmap): Move earlier.
8396         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8397         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8398         instead of individual calls to trad_frame_set_reg_addr.
8399         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8400         earlier.
8401         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8402         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8403         instead of individual calls to trad_frame_set_reg_addr.
8404
8405 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8406
8407         * CONTRIBUTE: Replace contribution list with wiki link.
8408
8409 2019-01-25  Tom Tromey  <tom@tromey.com>
8410
8411         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8412
8413 2019-01-25  Tom Tromey  <tom@tromey.com>
8414
8415         * xtensa-linux-nat.c: Fix common/ includes.
8416         * xml-support.h: Fix common/ includes.
8417         * xml-support.c: Fix common/ includes.
8418         * x86-linux-nat.c: Fix common/ includes.
8419         * windows-nat.c: Fix common/ includes.
8420         * varobj.h: Fix common/ includes.
8421         * varobj.c: Fix common/ includes.
8422         * value.c: Fix common/ includes.
8423         * valops.c: Fix common/ includes.
8424         * utils.c: Fix common/ includes.
8425         * unittests/xml-utils-selftests.c: Fix common/ includes.
8426         * unittests/utils-selftests.c: Fix common/ includes.
8427         * unittests/unpack-selftests.c: Fix common/ includes.
8428         * unittests/tracepoint-selftests.c: Fix common/ includes.
8429         * unittests/style-selftests.c: Fix common/ includes.
8430         * unittests/string_view-selftests.c: Fix common/ includes.
8431         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8432         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8433         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8434         * unittests/rsp-low-selftests.c: Fix common/ includes.
8435         * unittests/parse-connection-spec-selftests.c: Fix common/
8436         includes.
8437         * unittests/optional-selftests.c: Fix common/ includes.
8438         * unittests/offset-type-selftests.c: Fix common/ includes.
8439         * unittests/observable-selftests.c: Fix common/ includes.
8440         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8441         * unittests/memrange-selftests.c: Fix common/ includes.
8442         * unittests/memory-map-selftests.c: Fix common/ includes.
8443         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8444         * unittests/function-view-selftests.c: Fix common/ includes.
8445         * unittests/environ-selftests.c: Fix common/ includes.
8446         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8447         * unittests/common-utils-selftests.c: Fix common/ includes.
8448         * unittests/cli-utils-selftests.c: Fix common/ includes.
8449         * unittests/array-view-selftests.c: Fix common/ includes.
8450         * ui-file.c: Fix common/ includes.
8451         * tui/tui-io.c: Fix common/ includes.
8452         * tracepoint.h: Fix common/ includes.
8453         * tracepoint.c: Fix common/ includes.
8454         * tracefile-tfile.c: Fix common/ includes.
8455         * top.h: Fix common/ includes.
8456         * top.c: Fix common/ includes.
8457         * thread.c: Fix common/ includes.
8458         * target/waitstatus.h: Fix common/ includes.
8459         * target/waitstatus.c: Fix common/ includes.
8460         * target.h: Fix common/ includes.
8461         * target.c: Fix common/ includes.
8462         * target-memory.c: Fix common/ includes.
8463         * target-descriptions.c: Fix common/ includes.
8464         * symtab.h: Fix common/ includes.
8465         * symfile.c: Fix common/ includes.
8466         * stap-probe.c: Fix common/ includes.
8467         * spu-linux-nat.c: Fix common/ includes.
8468         * sparc-nat.c: Fix common/ includes.
8469         * source.c: Fix common/ includes.
8470         * solib.c: Fix common/ includes.
8471         * solib-target.c: Fix common/ includes.
8472         * ser-unix.c: Fix common/ includes.
8473         * ser-tcp.c: Fix common/ includes.
8474         * ser-pipe.c: Fix common/ includes.
8475         * ser-base.c: Fix common/ includes.
8476         * selftest-arch.c: Fix common/ includes.
8477         * s12z-tdep.c: Fix common/ includes.
8478         * rust-exp.y: Fix common/ includes.
8479         * rs6000-aix-tdep.c: Fix common/ includes.
8480         * riscv-tdep.c: Fix common/ includes.
8481         * remote.c: Fix common/ includes.
8482         * remote-notif.h: Fix common/ includes.
8483         * remote-fileio.h: Fix common/ includes.
8484         * remote-fileio.c: Fix common/ includes.
8485         * regcache.h: Fix common/ includes.
8486         * regcache.c: Fix common/ includes.
8487         * record-btrace.c: Fix common/ includes.
8488         * python/python.c: Fix common/ includes.
8489         * python/py-type.c: Fix common/ includes.
8490         * python/py-inferior.c: Fix common/ includes.
8491         * progspace.h: Fix common/ includes.
8492         * producer.c: Fix common/ includes.
8493         * procfs.c: Fix common/ includes.
8494         * proc-api.c: Fix common/ includes.
8495         * printcmd.c: Fix common/ includes.
8496         * ppc-linux-nat.c: Fix common/ includes.
8497         * parser-defs.h: Fix common/ includes.
8498         * osdata.c: Fix common/ includes.
8499         * obsd-nat.c: Fix common/ includes.
8500         * nat/x86-linux.c: Fix common/ includes.
8501         * nat/x86-linux-dregs.c: Fix common/ includes.
8502         * nat/x86-dregs.h: Fix common/ includes.
8503         * nat/x86-dregs.c: Fix common/ includes.
8504         * nat/ppc-linux.c: Fix common/ includes.
8505         * nat/mips-linux-watch.h: Fix common/ includes.
8506         * nat/mips-linux-watch.c: Fix common/ includes.
8507         * nat/linux-waitpid.c: Fix common/ includes.
8508         * nat/linux-ptrace.h: Fix common/ includes.
8509         * nat/linux-ptrace.c: Fix common/ includes.
8510         * nat/linux-procfs.c: Fix common/ includes.
8511         * nat/linux-personality.c: Fix common/ includes.
8512         * nat/linux-osdata.c: Fix common/ includes.
8513         * nat/linux-namespaces.c: Fix common/ includes.
8514         * nat/linux-btrace.h: Fix common/ includes.
8515         * nat/linux-btrace.c: Fix common/ includes.
8516         * nat/fork-inferior.c: Fix common/ includes.
8517         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8518         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8519         * nat/aarch64-linux.c: Fix common/ includes.
8520         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8521         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8522         * namespace.h: Fix common/ includes.
8523         * mips-linux-tdep.c: Fix common/ includes.
8524         * minsyms.c: Fix common/ includes.
8525         * mi/mi-parse.h: Fix common/ includes.
8526         * mi/mi-main.c: Fix common/ includes.
8527         * mi/mi-cmd-env.c: Fix common/ includes.
8528         * memrange.h: Fix common/ includes.
8529         * memattr.c: Fix common/ includes.
8530         * maint.h: Fix common/ includes.
8531         * maint.c: Fix common/ includes.
8532         * main.c: Fix common/ includes.
8533         * machoread.c: Fix common/ includes.
8534         * location.c: Fix common/ includes.
8535         * linux-thread-db.c: Fix common/ includes.
8536         * linux-nat.c: Fix common/ includes.
8537         * linux-fork.c: Fix common/ includes.
8538         * inline-frame.c: Fix common/ includes.
8539         * infrun.c: Fix common/ includes.
8540         * inflow.c: Fix common/ includes.
8541         * inferior.h: Fix common/ includes.
8542         * inferior.c: Fix common/ includes.
8543         * infcmd.c: Fix common/ includes.
8544         * inf-ptrace.c: Fix common/ includes.
8545         * inf-child.c: Fix common/ includes.
8546         * ia64-linux-nat.c: Fix common/ includes.
8547         * i387-tdep.c: Fix common/ includes.
8548         * i386-tdep.c: Fix common/ includes.
8549         * i386-linux-tdep.c: Fix common/ includes.
8550         * i386-linux-nat.c: Fix common/ includes.
8551         * i386-go32-tdep.c: Fix common/ includes.
8552         * i386-fbsd-tdep.c: Fix common/ includes.
8553         * i386-fbsd-nat.c: Fix common/ includes.
8554         * guile/scm-type.c: Fix common/ includes.
8555         * guile/guile.c: Fix common/ includes.
8556         * go32-nat.c: Fix common/ includes.
8557         * gnu-nat.c: Fix common/ includes.
8558         * gdbthread.h: Fix common/ includes.
8559         * gdbarch-selftests.c: Fix common/ includes.
8560         * gdb_usleep.c: Fix common/ includes.
8561         * gdb_select.h: Fix common/ includes.
8562         * gdb_bfd.c: Fix common/ includes.
8563         * gcore.c: Fix common/ includes.
8564         * fork-child.c: Fix common/ includes.
8565         * findvar.c: Fix common/ includes.
8566         * fbsd-nat.c: Fix common/ includes.
8567         * event-top.c: Fix common/ includes.
8568         * event-loop.c: Fix common/ includes.
8569         * dwarf2read.c: Fix common/ includes.
8570         * dwarf2loc.c: Fix common/ includes.
8571         * dwarf2-frame.c: Fix common/ includes.
8572         * dwarf-index-cache.c: Fix common/ includes.
8573         * dtrace-probe.c: Fix common/ includes.
8574         * disasm-selftests.c: Fix common/ includes.
8575         * defs.h: Fix common/ includes.
8576         * csky-tdep.c: Fix common/ includes.
8577         * cp-valprint.c: Fix common/ includes.
8578         * cp-support.h: Fix common/ includes.
8579         * cp-support.c: Fix common/ includes.
8580         * corelow.c: Fix common/ includes.
8581         * completer.h: Fix common/ includes.
8582         * completer.c: Fix common/ includes.
8583         * compile/compile.c: Fix common/ includes.
8584         * compile/compile-loc2c.c: Fix common/ includes.
8585         * compile/compile-cplus-types.c: Fix common/ includes.
8586         * compile/compile-cplus-symbols.c: Fix common/ includes.
8587         * command.h: Fix common/ includes.
8588         * cli/cli-dump.c: Fix common/ includes.
8589         * cli/cli-cmds.c: Fix common/ includes.
8590         * charset.c: Fix common/ includes.
8591         * build-id.c: Fix common/ includes.
8592         * btrace.h: Fix common/ includes.
8593         * btrace.c: Fix common/ includes.
8594         * breakpoint.h: Fix common/ includes.
8595         * breakpoint.c: Fix common/ includes.
8596         * ax.h:
8597         (enum agent_op): Fix common/ includes.
8598         * ax-general.c (struct aop_map): Fix common/ includes.
8599         * ax-gdb.c: Fix common/ includes.
8600         * auxv.c: Fix common/ includes.
8601         * auto-load.c: Fix common/ includes.
8602         * arm-tdep.c: Fix common/ includes.
8603         * arch/riscv.c: Fix common/ includes.
8604         * arch/ppc-linux-common.c: Fix common/ includes.
8605         * arch/i386.c: Fix common/ includes.
8606         * arch/arm.c: Fix common/ includes.
8607         * arch/arm-linux.c: Fix common/ includes.
8608         * arch/arm-get-next-pcs.c: Fix common/ includes.
8609         * arch/amd64.c: Fix common/ includes.
8610         * arch/aarch64.c: Fix common/ includes.
8611         * arch/aarch64-insn.c: Fix common/ includes.
8612         * arch-utils.c: Fix common/ includes.
8613         * amd64-windows-tdep.c: Fix common/ includes.
8614         * amd64-tdep.c: Fix common/ includes.
8615         * amd64-sol2-tdep.c: Fix common/ includes.
8616         * amd64-obsd-tdep.c: Fix common/ includes.
8617         * amd64-nbsd-tdep.c: Fix common/ includes.
8618         * amd64-linux-tdep.c: Fix common/ includes.
8619         * amd64-linux-nat.c: Fix common/ includes.
8620         * amd64-fbsd-tdep.c: Fix common/ includes.
8621         * amd64-fbsd-nat.c: Fix common/ includes.
8622         * amd64-dicos-tdep.c: Fix common/ includes.
8623         * amd64-darwin-tdep.c: Fix common/ includes.
8624         * agent.c: Fix common/ includes.
8625         * ada-lang.h: Fix common/ includes.
8626         * ada-lang.c: Fix common/ includes.
8627         * aarch64-tdep.c: Fix common/ includes.
8628
8629 2019-01-25  Tom Tromey  <tom@tromey.com>
8630
8631         * common/create-version.sh: Use common/version.h.
8632
8633 2019-01-24  Pedro Alves  <palves@redhat.com>
8634
8635         * infrun.c (signal_stop, signal_print, signal_program)
8636         (signal_catch, signal_pass): Now arrays instead of pointers.
8637         (update_signals_program_target, do_target_resume)
8638         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8639         * linux-nat.c (linux_nat_target::pass_signals)
8640         (linux_nat_target::create_inferior, linux_nat_target::attach):
8641         Adjust.
8642         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8643         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8644         * procfs.c (procfs_target::pass_signals): Adjust.
8645         * record-full.c (record_full_target::resume): Adjust.
8646         * remote.c (remote_target::pass_signals)
8647         (remote_target::program_signals): Adjust.
8648         * target-debug.h (target_debug_print_signals): Now takes a
8649         gdb::array_view as parameter.  Adjust.
8650         * target.h (target_ops) <pass_signals, program_signals>: Replace
8651         pointer and length parameters with gdb::array_view.
8652         (target_pass_signals, target_program_signals): Likewise.
8653         * target-delegates.c: Regenerate.
8654
8655 2019-01-24  Pedro Alves  <palves@redhat.com>
8656
8657         * common/forward-scope-exit.h
8658         (forward_scope_exit::forward_scope_exit): Pass arguments to
8659         m_bind_function directly, instead of creating a std::bind and
8660         copying that.
8661
8662 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8663
8664         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8665         for static members.
8666         (pass_in_v_vfp_candidate): Likewise.
8667
8668 2019-01-23  Tom Tromey  <tom@tromey.com>
8669             Pedro Alves  <palves@redhat.com>
8670
8671         * regcache.c (class regcache_invalidator): Remove.
8672         (regcache::raw_write): Use make_scope_exit.
8673
8674 2019-01-23  Tom Tromey  <tom@tromey.com>
8675
8676         * ui-out.h (class ui_out_emit_type): Update comment.
8677
8678 2019-01-23  Tom Tromey  <tom@tromey.com>
8679
8680         * infrun.c (fetch_inferior_event): Update comment.
8681
8682 2019-01-23  Tom Tromey  <tom@tromey.com>
8683             Pedro Alves  <palves@redhat.com>
8684
8685         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8686         parameter.
8687         (fetch_inferior_event): Use SCOPE_EXIT.
8688
8689
8690 2019-01-23  Tom Tromey  <tom@tromey.com>
8691             Pedro Alves  <palves@redhat.com>
8692
8693         * infrun.c (disable_thread_events): Delete.
8694         (stop_all_threads): Use SCOPE_EXIT.
8695
8696 2019-01-23  Tom Tromey  <tom@tromey.com>
8697             Pedro Alves  <palves@redhat.com>
8698
8699         * symfile.c: Include forward-scope-exit.h.
8700         (clear_symtab_users_cleanup): Replace forward declaration with
8701         a FORWARD_SCOPE_EXIT.
8702         (syms_from_objfile_1): Use the forward_scope_exit and
8703         gdb::optional instead of cleanup_function.
8704         (reread_symbols): Use the forward_scope_exit instead of
8705         cleanup_function.
8706         (clear_symtab_users_cleanup): Remove function.
8707
8708 2019-01-23  Tom Tromey  <tom@tromey.com>
8709             Pedro Alves  <palves@redhat.com>
8710
8711         * linux-nat.c: Include scope-exit.h.
8712         (cleanup_target_stop): Remove.
8713         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8714         SCOPE_EXIT.
8715
8716 2019-01-23  Tom Tromey  <tom@tromey.com>
8717             Pedro Alves  <palves@redhat.com>
8718
8719         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8720         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8721
8722 2019-01-23  Tom Tromey  <tom@tromey.com>
8723             Andrew Burgess  <andrew.burgess@embecosm.com>
8724             Pedro Alves  <palves@redhat.com>
8725
8726         * infrun.c (fetch_inferior_event): Use scope_exit.
8727         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8728         * top.c (execute_command): Use scope_exit.
8729         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8730         * utils.c (do_bpstat_clear_actions_cleanup)
8731         (make_bpstat_clear_actions_cleanup): Remove.
8732
8733 2019-01-23  Tom Tromey  <tom@tromey.com>
8734             Pedro Alves  <palves@redhat.com>
8735
8736         * infrun.c: Include "common/scope-exit.h"
8737         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8738         (wait_for_inferior): Use SCOPE_EXIT.
8739         (fetch_inferior_event): Use scope_exit.
8740
8741 2019-01-23  Tom Tromey  <tom@tromey.com>
8742             Pedro Alves  <palves@redhat.com>
8743
8744         * breakpoint.c (create_breakpoint): Remove cleanup.
8745
8746 2019-01-23  Tom Tromey  <tom@tromey.com>
8747             Andrew Burgess  <andrew.burgess@embecosm.com>
8748             Pedro Alves  <palves@redhat.com>
8749
8750 2019-01-23  Pedro Alves  <palves@redhat.com>
8751
8752         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8753
8754 2019-01-23  Pedro Alves  <palves@redhat.com>
8755             Andrew Burgess  <andrew.burgess@embecosm.com>
8756
8757         * gdbthread.h: Include "common/forward-scope-exit.h".
8758         (scoped_finish_thread_state): Redefine custom class in terms of
8759         forward_scope_exit.
8760
8761 2019-01-23  Pedro Alves  <palves@redhat.com>
8762             Andrew Burgess  <andrew.burgess@embecosm.com>
8763
8764         * common/forward-scope-exit.h: New file.
8765
8766 2019-01-23  Pedro Alves  <palves@redhat.com>
8767             Andrew Burgess  <andrew.burgess@embecosm.com>
8768             Tom Tromey  <tom@tromey.com>
8769
8770         * common/scope-exit.h: New file.
8771
8772 2019-01-23  Pedro Alves  <palves@redhat.com>
8773
8774         * common/preprocessor.h (ESC): Rename to ...
8775         (ESC_PARENS): ... this.
8776         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8777         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8778
8779 2019-01-23  Tom Tromey  <tom@tromey.com>
8780
8781         * language.h (class scoped_switch_to_sym_language_if_auto):
8782         Initialize m_lang in both cases.
8783
8784 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8785
8786         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8787         with XCNEW.
8788
8789 2019-01-22  Tom Tromey  <tom@tromey.com>
8790
8791         * corelow.c: Do not include sys/file.h.
8792
8793 2019-01-22  Tom Tromey  <tom@tromey.com>
8794
8795         * tui/tui-wingeneral.h: Include gdb_curses.h.
8796
8797 2019-01-22  Tom Tromey  <tom@tromey.com>
8798
8799         * source-cache.h (class source_cache) <get_source_lines,
8800         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8801
8802 2019-01-22  Tom Tromey  <tom@tromey.com>
8803
8804         * remote-fileio.h (struct remote_target): Declare.
8805
8806 2019-01-22  Tom Tromey  <tom@tromey.com>
8807
8808         * python/py-arch.c: Do not include py-ref.h.
8809         * python/py-bpevent.c: Do not include py-ref.h.
8810         * python/py-cmd.c: Do not include py-ref.h.
8811         * python/py-continueevent.c: Do not include py-ref.h.
8812         * python/py-event.h: Do not include py-ref.h.
8813         * python/py-evtregistry.c: Do not include py-ref.h.
8814         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8815         * python/py-frame.c: Do not include py-ref.h.
8816         * python/py-framefilter.c: Do not include py-ref.h.
8817         * python/py-function.c: Do not include py-ref.h.
8818         * python/py-infevents.c: Do not include py-ref.h.
8819         * python/py-linetable.c: Do not include py-ref.h.
8820         * python/py-objfile.c: Do not include py-ref.h.
8821         * python/py-param.c: Do not include py-ref.h.
8822         * python/py-prettyprint.c: Do not include py-ref.h.
8823         * python/py-progspace.c: Do not include py-ref.h.
8824         * python/py-symbol.c: Do not include py-ref.h.
8825         * python/py-symtab.c: Do not include py-ref.h.
8826         * python/py-type.c: Do not include py-ref.h.
8827         * python/py-unwind.c: Do not include py-ref.h.
8828         * python/py-utils.c: Do not include py-ref.h.
8829         * python/py-value.c: Do not include py-ref.h.
8830         * python/py-varobj.c: Do not include py-ref.h.
8831         * python/py-xmethods.c: Do not include py-ref.h.
8832         * python/python.c: Do not include py-ref.h.
8833         * varobj.c: Do not include py-ref.h.
8834
8835 2019-01-22  Tom Tromey  <tom@tromey.com>
8836
8837         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8838         keyword for bcache.
8839
8840 2019-01-22  Tom Tromey  <tom@tromey.com>
8841
8842         * compile/compile-cplus-types.c: Remove a comment by #include.
8843
8844 2019-01-22  Tom Tromey  <tom@tromey.com>
8845
8846         * compile/gcc-c-plugin.h: Include compile-internal.h.
8847
8848 2019-01-22  Tom Tromey  <tom@tromey.com>
8849
8850         * stabsread.c (EXTERN): Do not define.
8851         (symnum, next_symbol_text_func, processing_gcc_compilation)
8852         (within_function, global_sym_chain, global_stabs)
8853         (previous_stab_code, this_object_header_files)
8854         (n_this_object_header_files)
8855         (n_allocated_this_object_header_files): Define.
8856         * stabsread.h (EXTERN): Never define.  Use "extern".
8857
8858 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8859
8860         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8861         history_value.
8862
8863 2019-01-21  Tom Tromey  <tom@tromey.com>
8864
8865         * ui-out.c: Fix includes.
8866         * tui/tui-source.c: Fix includes.
8867         * target.c: Fix includes.
8868         * remote.c: Fix includes.
8869         * regcache.c: Fix includes.
8870         * python/py-block.c: Fix includes.
8871         * printcmd.c: Fix includes.
8872         * or1k-tdep.c: Fix includes.
8873         * mi/mi-main.c: Fix includes.
8874         * m32r-tdep.c: Fix includes.
8875         * csky-tdep.c: Fix includes.
8876         * compile/compile-cplus-types.c: Fix includes.
8877         * cli/cli-interp.c: Fix includes.
8878
8879 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8880
8881         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8882         for padding.
8883
8884 2019-01-16  Tom Tromey  <tom@tromey.com>
8885
8886         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8887         earlier.
8888         (struct objfile) <msymbols_range>: Move from top level.
8889         <msymbols>: New method.
8890         (class objfile_msymbols): Remove.
8891         * symtab.c (default_collect_symbol_completion_matches_break_on):
8892         Update.
8893         * symmisc.c (dump_msymbols): Update.
8894         * stabsread.c (scan_file_globals): Update.
8895         * objc-lang.c (info_selectors_command, info_classes_command)
8896         (find_methods): Update.
8897         * minsyms.c (find_solib_trampoline_target): Update.
8898         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8899         * coffread.c (coff_symfile_read): Update.
8900         * ada-lang.c (ada_lookup_simple_minsym)
8901         (ada_collect_symbol_completion_matches): Update.
8902
8903 2019-01-16  Tom Tromey  <tom@tromey.com>
8904
8905         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8906         type.  Remove no-argument constructor.
8907         <iterator::operator++>: Simplify.
8908         <begin>: Update.
8909         <end>: Use minimal_symbol_count.
8910
8911 2019-01-16  Tom Tromey  <tom@tromey.com>
8912
8913         * objfiles.h (struct objfile) <psymtabs>: New method.
8914         (class objfile_psymtabs): Remove.
8915         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8916         typedef.
8917         <range>: New method.
8918         (require_partial_symbols): Change return type.
8919         * psymtab.c (require_partial_symbols)
8920         (psym_expand_symtabs_matching): Update.
8921         * mdebugread.c (parse_partial_symbols): Update.
8922         * dbxread.c (dbx_end_psymtab): Update.
8923
8924 2019-01-15  Tom Tromey  <tom@tromey.com>
8925
8926         * symtab.c (lookup_objfile_from_block)
8927         (lookup_symbol_in_objfile_symtabs)
8928         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8929         (find_line_symtab, info_sources_command)
8930         (default_collect_symbol_completion_matches_break_on)
8931         (make_source_files_completion_list): Update.
8932         * symmisc.c (print_objfile_statistics, dump_objfile)
8933         (maintenance_print_symbols, maintenance_info_symtabs)
8934         (maintenance_check_symtabs, maintenance_info_line_tables):
8935         Update.
8936         * source.c (select_source_symtab)
8937         (forget_cached_source_info_for_objfile): Update.
8938         * objfiles.h (class objfile_compunits): Remove.
8939         (struct objfile) <compunits_range>: New typedef.
8940         (compunits): New method.
8941         * objfiles.c (objfile_relocate1): Update.
8942         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8943         * maint.c (count_symtabs_and_blocks): Update.
8944         * linespec.c (iterate_over_all_matching_symtabs): Update.
8945         * cp-support.c (add_symbol_overload_list_qualified): Update.
8946         * coffread.c (coff_symtab_read): Update.
8947         * ada-lang.c (add_nonlocal_symbols)
8948         (ada_collect_symbol_completion_matches)
8949         (ada_add_global_exceptions): Update.
8950
8951 2019-01-15  Tom Tromey  <tom@tromey.com>
8952
8953         * progspace.h (program_space) <objfiles_safe_range>: New
8954         typedef.
8955         <objfiles_safe>: New method.
8956         * objfiles.h (class all_objfiles_safe): Remove.
8957         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8958         * jit.c (jit_inferior_exit_hook): Update.
8959
8960 2019-01-17  Tom Tromey  <tom@tromey.com>
8961
8962         * progspace.h (program_space) <objfiles_range>: New typedef.
8963         <objfiles>: New method.
8964         <objfiles_head>: Rename from objfiles.
8965         (object_files): Update.
8966         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8967         * guile/scm-pretty-print.c
8968         (ppscm_find_pretty_printer_from_objfiles): Update.
8969         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8970         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8971         Update.
8972         * python/py-progspace.c (pspy_get_objfiles): Update.
8973         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8974         Update.
8975         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8976         (objfpy_lookup_objfile_by_build_id): Update.
8977         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8978         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8979         Update.
8980         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8981         (expand_symtab_containing_pc, lookup_objfile_from_block)
8982         (lookup_static_symbol, basic_lookup_transparent_type)
8983         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8984         (find_line_symtab, info_sources_command)
8985         (default_collect_symbol_completion_matches_break_on)
8986         (make_source_files_completion_list, find_main_name): Update.
8987         * symmisc.c (print_symbol_bcache_statistics)
8988         (print_objfile_statistics, maintenance_print_symbols)
8989         (maintenance_print_msymbols, maintenance_print_objfiles)
8990         (maintenance_info_symtabs, maintenance_check_symtabs)
8991         (maintenance_expand_symtabs, maintenance_info_line_tables):
8992         Update.
8993         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8994         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8995         (map_overlay_command, unmap_overlay_command)
8996         (simple_overlay_update, expand_symtabs_matching)
8997         (map_symbol_filenames): Update.
8998         * symfile-debug.c (set_debug_symfile): Update.
8999         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9000         Update.
9001         * source.c (select_source_symtab, forget_cached_source_info):
9002         Update.
9003         * solib.c (solib_read_symbols): Update.
9004         * solib-spu.c (append_ocl_sos): Update.
9005         * psymtab.c (maintenance_print_psymbols)
9006         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9007         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9008         * printcmd.c (info_symbol_command): Update.
9009         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9010         Update.
9011         * objfiles.h (class all_objfiles): Remove.
9012         * objfiles.c (have_partial_symbols, have_full_symbols)
9013         (have_minimal_symbols, qsort_cmp, update_section_map)
9014         (shared_objfile_contains_address_p)
9015         (default_iterate_over_objfiles_in_search_order): Update.
9016         * objc-lang.c (info_selectors_command, info_classes_command)
9017         (find_methods): Update.
9018         * minsyms.c (find_solib_trampoline_target): Update.
9019         * maint.c (maintenance_info_sections)
9020         (maintenance_translate_address, count_symtabs_and_blocks):
9021         Update.
9022         * main.c (captured_main_1): Update.
9023         * linux-thread-db.c (try_thread_db_load_from_pdir)
9024         (has_libpthread): Update.
9025         * linespec.c (iterate_over_all_matching_symtabs)
9026         (search_minsyms_for_name): Update.
9027         * jit.c (jit_find_objf_with_entry_addr): Update.
9028         * hppa-tdep.c (find_unwind_entry)
9029         (hppa_lookup_stub_minimal_symbol): Update.
9030         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9031         Update.
9032         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9033         (elf_gnu_ifunc_resolve_by_got): Update.
9034         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9035         * dwarf-index-write.c (save_gdb_index_command): Update.
9036         * cp-support.c (add_symbol_overload_list_qualified): Update.
9037         * breakpoint.c (create_overlay_event_breakpoint)
9038         (create_longjmp_master_breakpoint)
9039         (create_std_terminate_master_breakpoint)
9040         (create_exception_master_breakpoint): Update.
9041         * blockframe.c (find_pc_partial_function): Update.
9042         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9043         (ada_collect_symbol_completion_matches)
9044         (ada_add_global_exceptions): Update.
9045
9046 2019-01-17  Tom Tromey  <tom@tromey.com>
9047
9048         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9049         declare VEC.
9050         (solib_target_parse_libraries): Change return type.
9051         (library_list_start_segment, library_list_start_section)
9052         (library_list_end_library, library_list_start_library); Update.
9053         (solib_target_free_library_list): Remove.
9054         (solib_target_parse_libraries): Remove cleanup.  Change return
9055         type.
9056         (solib_target_current_sos): Update.
9057
9058 2019-01-17  Tom Tromey  <tromey@bapiya>
9059
9060         * valprint.c: Replace "the the" with "the".
9061         * symtab.c: Replace "the the" with "the".
9062         * solib.c: Replace "the the" with "the".
9063         * solib-dsbt.c: Replace "the the" with "the".
9064         * linespec.c: Replace "the the" with "the".
9065         * dwarf2loc.h: Replace "the the" with "the".
9066         * amd64-windows-tdep.c: Replace "the the" with "the".
9067         * aarch64-tdep.c: Replace "the the" with "the".
9068
9069 2019-01-16  Keith Seitz  <keiths@redhat.com>
9070
9071         PR gdb/23773
9072         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9073         <builder>: Rename to ..
9074         <m_builder>: ... this and make private.
9075         (dwarf2_cu::get_builder): New method.  Change all users of
9076         `builder' to use this method.
9077         (dwarf2_start_symtab): Move to ...
9078         (dwarf2_cu::start_symtab): ... here.  Update all callers
9079         (setup_type_unit_groups): Move to ...
9080         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9081         callers.
9082         (dwarf2_cu::reset_builder): New method.
9083         (process_full_compunit, process_full_type_unit): Use
9084         dwarf2_cu::reset_builder.
9085         (follow_die_offset): Record the ancestor CU if it is different
9086         from the followed DIE's CU.
9087         (follow_die_sig_1): Likewise.
9088
9089 2019-01-15  Tom Tromey  <tom@tromey.com>
9090
9091         * remote.c (class remote_state) <buf>: Now a char_vector.
9092         <buf_size>: Remove.
9093         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9094         parameter.
9095         (remote_target::getpkt_or_notif_sane_1)
9096         (remote_target::getpkt_sane)
9097         (remote_target::getpkt_or_notif_sane): Likewise.
9098         (class remote_target) <putpkt>: New overload.
9099         (remote_target::read_frame): Change type of "buf_p".  Remove
9100         sizeof_p parameter.
9101         (packet_ok): New overload.
9102         (packet_check_result): New overload.
9103         Update all uses.
9104
9105 2019-01-14  Tom Tromey  <tom@tromey.com>
9106
9107         * remote-notif.c (handle_notification, remote_notif_ack)
9108         (remote_notif_parse): Make "buf" const.
9109         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9110         const.
9111         (remote_notif_parse, remote_notif_ack, handle_notification):
9112         Likewise.
9113         * remote.c (remote_notif_stop_parse): Make "buf" const.
9114         (remote_target::remote_parse_stop_reply): Make "buf" const.
9115         (remote_notif_stop_ack): Make "buf" const.
9116
9117 2019-01-14  Tom Tromey  <tom@tromey.com>
9118
9119         * remote.c (remote_console_output): Make parameter const.
9120
9121 2019-01-14  Tom Tromey  <tom@tromey.com>
9122
9123         * target-debug.h (target_debug_print_signals): Constify.
9124         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9125         * procfs.c (procfs_target::pass_signals): Update.
9126         * linux-nat.c (linux_nat_target::pass_signals): Update.
9127         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9128         * target-delegates.c: Rebuild.
9129         * remote.c (remote_target::program_signals): Update.
9130         (remote_target::pass_signals): Update.
9131         * target.c (target_pass_signals): Constify argument.
9132         (target_program_signals): Likewise.
9133         * target.h (struct target_ops) <pass_signals, program_signals>:
9134         Constify argument.
9135         (target_pass_signals, target_program_signals): Constify argument.
9136
9137 2019-01-14  Tom Tromey  <tom@tromey.com>
9138
9139         PR tui/28819:
9140         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9141
9142 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9143
9144         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9145         field.
9146         * rs6000-tdep.c: Include reggroups.h.
9147         (IS_V_ALIAS_PSEUDOREG): Define.
9148         (rs6000_register_name): Return names for the "vX" aliases.
9149         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9150         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9151         aliases.  Call default_register_reggroup_p for all other
9152         pseudo-registers.
9153         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9154         New functions.
9155         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9156         Handle "vX" aliases.
9157         (v_alias_pseudo_register_collect): New function.
9158         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9159         (rs6000_gdbarch_init): Initialize "vX" aliases as
9160         pseudo-registers.  Restore registration of
9161         rs6000_pseudo_register_reggroup_p with
9162         set_tdesc_pseudo_register_reggroup_p.
9163
9164 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9165
9166         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9167         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9168         set_gdbarch_num_pseudo_regs.
9169
9170 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9171
9172         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9173         Remove arg prefixname, add do_set and do_show.
9174         Add member functions set_list and show_list.
9175         * cli/cli-style.c (class cli_style_option): Update accordingly.
9176         (style_set_list): Move to file scope.
9177         (style_show_list): Likewise.
9178         (set_style): Call help_list.
9179         (show_style): Call cmd_show_list.
9180         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9181         Update to use the new macro.
9182
9183 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9184
9185         * ada-lang.c (_initialize_ada_language): Expand the help text
9186         for the "catch exception" command.
9187
9188 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9189
9190         * symtab.c (matching_obj_sections): Initialize obj,
9191         declare it closer to its usage.
9192
9193 2019-01-10  Tom Tromey  <tom@tromey.com>
9194
9195         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9196         (basic_inf_threads_range): Remove.
9197         (inf_threads_range, inf_non_exited_threads_range)
9198         (safe_inf_threads_range): Use next_adapter.
9199
9200 2019-01-10  Keith Seitz  <keiths@redhat.com>
9201
9202         PR gdb/23712
9203         PR symtab/23010
9204         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9205         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9206
9207 2019-01-10  Keith Seitz  <keiths@redhat.com>
9208
9209         PR gdb/23712
9210         PR symtab/23010
9211         * dictionary.c (pending_to_vector): Remove.
9212         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9213         Remove _1 suffix, replacing functions of the same name.  Update
9214         all callers.
9215         (dict_create_hashed, dict_create_hashed_expandable)
9216         (dict_create_linear, dict_create_linear_expandable, dict_free)
9217         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9218         Make functions static.
9219
9220 2019-01-10  Keith Seitz  <keiths@redhat.com>
9221
9222         PR gdb/23712
9223         PR symtab/23010
9224         * dictionary.h (struct dictionary): Replace declaration with
9225         multidictionary.
9226         (dict_create_hashed, dict_create_hashed_expandable)
9227         (dict_create_linear, dict_create_linear_expandable)
9228         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9229         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9230         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9231         taking multidictionary argument.
9232         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9233         * block.h (struct block) <dict>: Change to multidictionary
9234         and rename `multidict'.
9235         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9236         symmisc.c: Update all dictionary references to multidictionary.
9237
9238 2019-01-10  Keith Seitz  <keiths@redhat.com>
9239
9240         PR gdb/23712
9241         PR symtab/23010
9242         * dictionary.c: Include unordered_map.
9243         (pending_to_vector): New function.
9244         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9245         Rewrite the non-"_1" functions to take vector instead
9246         of linked list.
9247         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9248         "new" _1 versions of the same name.
9249         (multidictionary): Define.
9250         (std::hash<enum language): New definition.
9251         (collate_pending_symbols_by_language, mdict_create_hashed)
9252         (mdict_create_hashed_expandable, mdict_create_linear)
9253         (mdict_create_linear_expandable, mdict_free)
9254         (find_language_dictionary, create_new_language_dictionary)
9255         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9256         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9257         (mdict_size, mdict_empty): New functions.
9258         * dictionary.h (mdict_iterator): Define.
9259
9260 2019-01-10  Pedro Alves  <palves@redhat.com>
9261
9262         * breakpoint.c (read_uploaded_action)
9263         (create_tracepoint_from_upload): Adjust to use
9264         gdb::unique_xmalloc_ptr.
9265         * ctf.c (ctf_write_uploaded_tp):
9266         (SET_ARRAY_FIELD): Use emplace_back.
9267         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9268         * tracefile-tfile.c (tfile_write_uploaded_tp):
9269         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9270         gdb::unique_xmalloc_ptr.
9271         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9272         at_string, cond_string, cmd_strings>: Replace char pointers
9273         with gdb::unique_xmalloc_ptr.
9274
9275 2019-01-10  Pedro Alves  <palves@redhat.com>
9276
9277         * solib-target.c (library_list_start_library): Don't xstrdup name.
9278
9279 2019-01-10  Pedro Alves  <palves@redhat.com>
9280
9281         * mdebugread.c (parse_partial_symbols): Use
9282         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9283
9284 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9285
9286         * linux-fork.c (scoped_switch_fork_info)
9287         <~scoped_switch_fork_info>: Fix incorrect variable name.
9288
9289 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * linux-fork.c (scoped_switch_fork_info)
9292         <scoped_switch_fork_info>: Make explicit.
9293         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9294
9295 2019-01-10  Tom Tromey  <tom@tromey.com>
9296
9297         * objfiles.h (objfile::reset_psymtabs): Update.
9298         * objfiles.c (objfile::objfile): Update.
9299         * psymtab.h (psymtab_storage::obstack): Update.
9300         (psymtab_storage::m_obstack): Use gdb::optional.
9301         (class psymtab_storage): Update comment.  Remove objfile
9302         parameter.
9303         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9304
9305 2019-01-10  Tom Tromey  <tom@tromey.com>
9306
9307         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9308         <free_psymtabs>: Now private.
9309         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9310         (allocate_psymtab): Use new method.
9311
9312 2019-01-10  Tom Tromey  <tom@tromey.com>
9313
9314         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9315         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9316         * mdebugread.c (parse_partial_symbols): Use
9317         allocate_dependencies.
9318         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9319         allocate_dependencies.
9320         (process_psymtab_comp_unit_reader)
9321         (build_type_psymtab_dependencies): Likewise.
9322         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9323
9324 2019-01-10  Tom Tromey  <tom@tromey.com>
9325
9326         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9327         PSYMBOL_SET_LANGUAGE.
9328         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9329
9330 2019-01-10  Tom Tromey  <tom@tromey.com>
9331
9332         * psymtab.h (psymtab_storage::obstack): New method.
9333         <m_obstack>: Rename from obstack; now private.
9334         * psymtab.c (psymtab_storage): Update.
9335         * dwarf2read.c (create_addrmap_from_index)
9336         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9337         Update.
9338
9339 2019-01-10  Tom Tromey  <tom@tromey.com>
9340
9341         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9342         * objfiles.h (objfile::reset_psymtabs): New method.
9343
9344 2019-01-10  Tom Tromey  <tom@tromey.com>
9345
9346         * symmisc.c (print_symbol_bcache_statistics): Update.
9347         (print_objfile_statistics): Update.
9348         * symfile.c (reread_symbols): Update.
9349         * psymtab.h (class psymtab_storage): New.
9350         * psymtab.c (psymtab_storage): New constructor.
9351         (~psymtab_storage): New destructor.
9352         (require_partial_symbols): Update.
9353         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9354         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9355         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9356         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9357         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9358         (start_psymtab_common, end_psymtab_common)
9359         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9360         (allocate_psymtab): Update.
9361         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9362         Update.
9363         (dump_psymtab_addrmap, maintenance_print_psymbols)
9364         (maintenance_check_psymtabs): Update.
9365         (class objfile_psymtabs): Move to objfiles.h.
9366         * psympriv.h (discard_psymtab): Now inline.
9367         (psymtab_discarder::psymtab_discarder): Update.
9368         (psymtab_discarder::~psymtab_discarder): Update.
9369         (ALL_OBJFILE_PSYMTABS): Rewrite.
9370         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9371         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9372         Remove fields.
9373         <partial_symtabs>: New field.
9374         (class objfile_psymtabs): Move from psymtab.h.  Update.
9375         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9376         psymbol_cache.
9377         (objfile::~objfile): Don't destroy psymbol_cache.
9378         * mdebugread.c (parse_partial_symbols): Update.
9379         * dwarf2read.c (create_addrmap_from_index)
9380         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9381         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9382         (add_partial_subprogram, dwarf2_ranges_read): Update.
9383         * dwarf-index-write.c (write_address_map)
9384         (write_one_signatured_type, recursively_write_psymbols)
9385         (class debug_names, class debug_names, write_psymtabs_to_index):
9386         Update.
9387
9388 2019-01-10  Tom Tromey  <tom@tromey.com>
9389
9390         * symtab.h (SYMBOL_SET_NAMES): Update.
9391         (symbol_set_names): Update.
9392         (MSYMBOL_SET_NAMES): Update.
9393         * symtab.c (symbol_set_names): Change argument to be an
9394         objfile_per_bfd_storage.
9395         * psymtab.c (add_psymbol_to_bcache): Update.
9396         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9397
9398 2019-01-10  Tom Tromey  <tom@tromey.com>
9399
9400         * symtab.c (create_demangled_names_hash): Change argument to be an
9401         objfile_per_bfd_storage.
9402         (symbol_set_names): Update.
9403
9404 2019-01-10  Tom Tromey  <tom@tromey.com>
9405
9406         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9407         init_psymbol_list.
9408         * psymtab.c (init_psymbol_list): Do nothing if already called.
9409         * psympriv.h (init_psymbol_list): Add comment.
9410         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9411         init_psymbol_list.
9412         * dbxread.c (dbx_symfile_read): Unconditionally call
9413         init_psymbol_list.
9414
9415 2019-01-10  Tom Tromey  <tom@tromey.com>
9416
9417         * xcoffread.c (scan_xcoff_symtab): Update.
9418         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9419         "where".
9420         * mdebugread.c (parse_partial_symbols)
9421         (handle_psymbol_enumerators): Update.
9422         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9423         * dbxread.c (read_dbx_symtab): Update.
9424         * psympriv.h (psymbol_placement): New enum.
9425         (add_psymbol_to_list): Update.
9426
9427 2019-01-10  Tom Tromey  <tom@tromey.com>
9428
9429         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9430         static_psymbols parameters.
9431         (scan_xcoff_symtab): Update.
9432         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9433         static_psymbols parameters.
9434         * psympriv.h (start_psymtab_common): Update.
9435         * mdebugread.c (parse_partial_symbols): Update.
9436         * dwarf2read.c (create_partial_symtab): Update.
9437         * dbxread.c (read_dbx_symtab): Update.
9438         (start_psymtab): Remove global_psymbols and static_psymbols
9439         parameters.
9440
9441 2019-01-10  Tom Tromey  <tom@tromey.com>
9442
9443         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9444         * psymtab.c (allocate_psymtab): Add comment.
9445         * psympriv.h (allocate_psymtab): Add comment.
9446         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9447         initializations.
9448         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9449
9450 2019-01-10  Tom Tromey  <tom@tromey.com>
9451
9452         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9453         Don't declare.
9454         * mipsread.c: Include mdebugread.h.
9455         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9456         Declare.
9457         * elfread.c: Include mdebugread.h.
9458
9459 2019-01-09  Tom Tromey  <tom@tromey.com>
9460
9461         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9462         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9463         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9464         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9465         (psym_lookup_symbol, psym_find_last_source_symtab)
9466         (psym_forget_cached_source_info, psym_print_stats)
9467         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9468         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9469         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9470         (psym_find_compunit_symtab_by_address)
9471         (maintenance_print_psymbols, maintenance_info_psymtabs)
9472         (maintenance_check_psymtabs): Use ranged for.
9473         * psymtab.h (class objfile_psymtabs): New.
9474         (require_partial_symbols): Return objfile_psymtabs.
9475         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9476
9477 2019-01-09  Tom Tromey  <tom@tromey.com>
9478
9479         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9480         (find_pc_mapped_section, list_overlays_command)
9481         (map_overlay_command, unmap_overlay_command)
9482         (simple_overlay_update): Use all_objfiles.
9483         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9484         * printcmd.c (info_symbol_command): Use all_objfiles.
9485         * objfiles.h (ALL_OBJSECTIONS): Remove.
9486         * maint.c (maintenance_translate_address): Use all_objfiles.
9487         * gcore.c (gcore_create_callback): Use all_objfiles.
9488         (objfile_find_memory_regions): Likewise.
9489
9490 2019-01-09  Tom Tromey  <tom@tromey.com>
9491
9492         * symtab.c (find_line_symtab, info_sources_command)
9493         (make_source_files_completion_list): Use objfile_compunits.
9494         * source.c (select_source_symtab): Use objfile_compunits.
9495         * objfiles.h (struct objfile): Update comment.
9496         (ALL_OBJFILES): Remove.
9497         (ALL_FILETABS): Remove.
9498         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9499         objfile_compunits.
9500
9501 2019-01-09  Tom Tromey  <tom@tromey.com>
9502
9503         * symmisc.c (print_objfile_statistics, dump_objfile)
9504         (maintenance_print_symbols): Use compunit_filetabs.
9505         * source.c (forget_cached_source_info_for_objfile): Use
9506         compunit_filetabs.
9507         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9508         (ALL_FILETABS): Use compunit_filetabs.
9509         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9510         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9511
9512 2019-01-09  Tom Tromey  <tom@tromey.com>
9513
9514         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9515         (compunit_filetabs): New.
9516         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9517         compunit_filetabs.
9518         (info_sources_command, make_source_files_completion_list): Remove
9519         declaration.
9520         * symmisc.c (print_objfile_statistics, dump_objfile)
9521         (maintenance_print_symbols): Remove declaration.
9522         (maintenance_info_symtabs): Use compunit_filetabs.
9523         (maintenance_info_line_tables): Likewise.
9524         * source.c (select_source_symtab): Change local variable name.
9525         (forget_cached_source_info_for_objfile): Remove declaration.
9526         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9527         * objfiles.c (objfile_relocate1): Remove declaration.
9528         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9529         declaration.
9530         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9531         * coffread.c (coff_symtab_read): Remove declaration.
9532         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9533         compunit_filetabs.
9534
9535 2019-01-09  Tom Tromey  <tom@tromey.com>
9536
9537         * symtab.c (lookup_objfile_from_block)
9538         (find_pc_sect_compunit_symtab, search_symbols)
9539         (default_collect_symbol_completion_matches_break_on): Use
9540         objfile_compunits.
9541         * objfiles.h (ALL_COMPUNITS): Remove.
9542         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9543         * cp-support.c (add_symbol_overload_list_qualified): Use
9544         objfile_compunits.
9545         * ada-lang.c (ada_collect_symbol_completion_matches)
9546         (ada_add_global_exceptions): Use objfile_compunits.
9547
9548 2019-01-09  Tom Tromey  <tom@tromey.com>
9549
9550         * source.c (select_source_symtab)
9551         (forget_cached_source_info_for_objfile): Remove declaration.
9552         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9553         declaration.
9554         * maint.c (count_symtabs_and_blocks): Remove declaration.
9555         * cp-support.c (add_symbol_overload_list_qualified): Remove
9556         declaration.
9557         * coffread.c (coff_symtab_read): Remove declaration.
9558         * symtab.c (lookup_symbol_in_objfile_symtabs)
9559         (basic_lookup_transparent_type_1): Use objfile_compunits.
9560         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9561         (info_sources_command, search_symbols)
9562         (default_collect_symbol_completion_matches_break_on)
9563         (make_source_files_completion_list): Remove declaration.
9564         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9565         (ada_collect_symbol_completion_matches)
9566         (ada_add_global_exceptions): Remove declaration.
9567         * linespec.c (iterate_over_all_matching_symtabs): Use
9568         objfile_compunits.
9569         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9570         (class objfile_compunits): New.
9571         (ALL_COMPUNITS): Use objfile_compunits.
9572         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9573         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9574         objfile_compunits.
9575         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9576
9577 2019-01-09  Tom Tromey  <tom@tromey.com>
9578
9579         * symtab.c (search_symbols)
9580         (default_collect_symbol_completion_matches_break_on): Use
9581         objfile_msymbols.
9582         * ada-lang.c (ada_lookup_simple_minsym)
9583         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9584         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9585         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9586         objfile_msymbols.
9587         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9588         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9589         * objc-lang.c (find_methods): Use objfile_msymbols.
9590         (info_selectors_command, info_classes_command): Likewise.
9591         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9592         * objfiles.h (class objfile_msymbols): New.
9593         (ALL_OBJFILE_MSYMBOLS): Remove.
9594         (ALL_MSYMBOLS): Remove.
9595
9596 2019-01-09  Tom Tromey  <tom@tromey.com>
9597
9598         * common/next-iterator.h (next_adapter): Add Iterator template
9599         parameter.
9600         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9601         (class all_objfiles_safe): New.
9602         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9603         * objfiles.c (put_objfile_before): Update comment.
9604         (add_separate_debug_objfile): Likewise.
9605         (free_all_objfiles): Use all_objfiles_safe.
9606         (objfile_purge_solibs): Likewise.
9607
9608 2019-01-09  Tom Tromey  <tom@tromey.com>
9609
9610         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9611         (expand_symtab_containing_pc, lookup_static_symbol)
9612         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9613         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9614         all_objfiles.
9615         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9616         * breakpoint.c (create_overlay_event_breakpoint)
9617         (create_longjmp_master_breakpoint)
9618         (create_std_terminate_master_breakpoint)
9619         (create_exception_master_breakpoint): Use all_objfiles.
9620         * linux-thread-db.c (try_thread_db_load_from_pdir)
9621         (has_libpthread): Use all_objfiles.
9622         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9623         * linespec.c (iterate_over_all_matching_symtabs)
9624         (search_minsyms_for_name): Use all_objfiles.
9625         * maint.c (maintenance_info_sections): Use all_objfiles.
9626         * main.c (captured_main_1): Use all_objfiles.
9627         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9628         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9629         * guile/scm-pretty-print.c
9630         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9631         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9632         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9633         (maintenance_print_msymbols): Use all_objfiles.
9634         * source.c (select_source_symtab): Use all_objfiles.
9635         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9636         * symfile.c (remove_symbol_file_command)
9637         (expand_symtabs_matching, map_symbol_filenames): Use
9638         all_objfiles.
9639         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9640         all_objfiles.
9641         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9642         * objc-lang.c (find_methods): Use all_objfiles.
9643         * objfiles.c (have_partial_symbols, have_full_symbols)
9644         (have_minimal_symbols, qsort_cmp)
9645         (default_iterate_over_objfiles_in_search_order): Use
9646         all_objfiles.
9647         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9648         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9649         (maintenance_check_psymtabs): Use all_objfiles.
9650         (ALL_PSYMTABS): Remove.
9651         * compile/compile-object-run.c (do_module_cleanup): Use
9652         all_objfiles.
9653         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9654         * cp-support.c (add_symbol_overload_list_qualified): Use
9655         all_objfiles.
9656         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9657         Use all_objfiles.
9658         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9659         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9660         all_objfiles.
9661         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9662         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9663         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9664         Uses all_objfiles.
9665         * solib.c (solib_read_symbols): Use all_objfiles
9666
9667 2019-01-09  Tom Tromey  <tom@tromey.com>
9668
9669         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9670         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9671         all_objfiles.
9672         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9673         * symmisc.c (print_symbol_bcache_statistics)
9674         (print_objfile_statistics, maintenance_print_objfiles)
9675         (maintenance_info_symtabs, maintenance_check_symtabs)
9676         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9677         all_objfiles.
9678         * source.c (forget_cached_source_info): Use all_objfiles.
9679         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9680         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9681         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9682         * objfiles.c (update_section_map): Use all_objfiles.
9683         (shared_objfile_contains_address_p): Likewise.
9684         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9685         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9686
9687 2019-01-09  Tom Tromey  <tom@tromey.com>
9688
9689         * common/next-iterator.h: New file.
9690         * objfiles.h (class all_objfiles): New.
9691         (struct objfile_iterator): New.
9692
9693 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9694
9695         * NEWS: Move the description of the changed "frame", "select-frame",
9696          and "info frame" commands to the Changed commands section.
9697
9698 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9699
9700         * gdbtypes.c (check_stub_method_group): Remove handling of old
9701         mangling schemes.
9702         * linespec.c (find_methods): Likewise.
9703         * stabsread.c (read_member_functions): Likewise.
9704         * valops.c (search_struct_method): Likewise.
9705         (value_struct_elt_for_reference): Likewise.
9706         * NEWS: Mention this change.
9707
9708 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9709
9710         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9711         print_source_lines.
9712         * source.c (print_source_lines_base): Update line number check.
9713         (print_source_lines): New function.
9714         (source_lines_range::source_lines_range): New function.
9715         * source.h (class source_lines_range): New class.
9716         (print_source_lines): New declaration.
9717
9718 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9719
9720         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9721
9722 2019-01-08  Tom Tromey  <tom@tromey.com>
9723             Simon Marchi  <simon.marchi@ericsson.com>
9724
9725         PR gdb/24060
9726         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9727         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9728         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9729         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9730         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9731         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9732
9733 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9734
9735         * source.c (select_source_symtab): Move header comment to
9736         declaration in source.h.
9737         (forget_cached_source_info_for_objfile): Likewise.
9738         (forget_cached_source_info): Likewise.
9739         (identify_source_line): Likewise.
9740         * source.h (identify_source_line): Move declaration from symtab.h
9741         and add comment from source.c
9742         (print_source_lines): Likewise.
9743         (forget_cached_source_info_for_objfile): Likewise.
9744         (forget_cached_source_info): Likewise.
9745         (select_source_symtab): Likewise.
9746         (enum print_source_lines_flag): Move definition from symtab.h.
9747         * symtab.h (identify_source_line): Move declaration to source.h.
9748         (print_source_lines): Likewise.
9749         (forget_cached_source_info_for_objfile): Likewise.
9750         (forget_cached_source_info): Likewise.
9751         (select_source_symtab): Likewise.
9752         (enum print_source_lines_flag): Move definition to source.h.
9753         * tui/tui-hooks.c: Add 'source.h' include.
9754
9755 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9756
9757         * source.c (print_source_lines_base): Handle requests to print
9758         reverse line number sequences, and guard against empty lines
9759         string.
9760
9761 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9762
9763         * source.c (print_source_lines_base): Fix skip of '\r' if next
9764         character is '\n'.
9765
9766 2019-01-06  Tom Tromey  <tom@tromey.com>
9767
9768         * c-exp.y (struct c_parse_state) <macro_original_text,
9769         expansion_obstack>: New member.
9770         (macro_original_text, expansion_obstack): Remove globals.
9771         (scan_macro_expansion, scanning_macro_expansion)
9772         (finished_macro_expansion): Update.
9773         (scan_macro_cleanup): Remove.
9774         (yylex, c_parse): Update.
9775
9776 2019-01-06  Tom Tromey  <tom@tromey.com>
9777
9778         * c-exp.y (struct c_parse_state) <strings>: New member.
9779         (operator_stoken): Update.
9780
9781 2019-01-06  Tom Tromey  <tom@tromey.com>
9782
9783         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9784         (union type_stack_elt) <typelist_val>: Now a pointer to
9785         std::vector.
9786         (type_stack_cleanup): Don't declare.
9787         (push_typelist): Update.
9788         * parse.c (pop_typelist): Return a std::vector.
9789         (push_typelist): Take a std::vector.
9790         (follow_types): Update.  Do not free args.
9791         (type_stack_cleanup): Remove.
9792         * c-exp.y (struct c_parse_state): New.
9793         (cpstate): New global.
9794         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9795         (nonempty_typelist): Update.
9796         (func_mod): Create a new vector.
9797         (c_parse): Create a c_parse_state.
9798         (check_parameter_typelist): Do not delete params.
9799         (function_method): Update.  Do not delete type_list.
9800
9801 2019-01-06  Tom Tromey  <tom@tromey.com>
9802
9803         PR gdb/28155:
9804         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9805         check_typedef.
9806         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9807         (print_return_value): Likewise.
9808
9809 2019-01-05  Tom Tromey  <tom@tromey.com>
9810
9811         * contrib/cleanup_check.py: Remove.
9812         * contrib/gcc-with-excheck: Remove.
9813         * contrib/exsummary.py: Remove.
9814         * contrib/excheck.py: Remove.
9815
9816 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9817
9818         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9819         NULL. Initialize tpprev to NULL instead of assigning it
9820         to NULL on the next statement.
9821         * windows-nat.c (windows_delete_thread): Remove check for
9822         main_thread_id before printing thread exit notifications.
9823         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9824         Remove thread ID check against main_thread_id.
9825         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9826         windows_delete_thread.
9827         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9828
9829 2019-01-04  Tom Tromey  <tom@tromey.com>
9830
9831         * compile/compile.c (_initialize_compile): Use upper case for
9832         metasyntactic variables.
9833         * symmisc.c (_initialize_symmisc): Use upper case for
9834         metasyntactic variables.
9835         * psymtab.c (_initialize_psymtab): Use upper case for
9836         metasyntactic variables.
9837         * demangle.c (demangle_command): Use upper case for metasyntactic
9838         variables.
9839         (_initialize_demangler): Likewise.
9840         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9841         variables.
9842
9843 2019-01-03  Tom Tromey  <tom@tromey.com>
9844
9845         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9846
9847 2019-01-03  Tom Tromey  <tom@tromey.com>
9848
9849         * python/py-symtab.c (salpy_str): Update.
9850         (struct salpy_sal_object) <symtab>: Now a PyObject.
9851         (salpy_dealloc): Update.
9852         (del_objfile_sal): Use gdbpy_ref.
9853
9854 2019-01-03  Tom Tromey  <tom@tromey.com>
9855
9856         * python/py-type.c (convert_field): Use new_reference.  Return
9857         gdbpy_ref.
9858         (make_fielditem): Return gdbpy_ref.
9859         (typy_fields): Update.
9860         (typy_getitem): Update.
9861         (field_name): Return gdbpy_ref.  Use new_reference.
9862         (typy_iterator_iternext): Update.
9863
9864 2019-01-03  Tom Tromey  <tom@tromey.com>
9865
9866         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9867
9868 2019-01-03  Tom Tromey  <tom@tromey.com>
9869
9870         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9871         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9872         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9873         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9874         (pspy_set_type_printers): Likewise.
9875         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9876         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9877         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9878         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9879         (objfpy_set_type_printers): Likewise.
9880
9881 2019-01-03  Tom Tromey  <tom@tromey.com>
9882
9883         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9884         (gdbpy_print_stack): Use gdbpy_err_fetch.
9885         * python/python-internal.h (class gdbpy_err_fetch): New class.
9886         (class gdbpy_enter) <m_error_type, m_error_value,
9887         m_error_traceback>: Remove.
9888         <m_error>: New member.
9889         (gdbpy_exception_to_string): Don't declare.
9890         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9891         * python/py-value.c (convert_value_from_python): Use
9892         gdbpy_err_fetch.
9893         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9894         gdbpy_exception_to_string.
9895         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9896         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9897         gdbpy_err_fetch.
9898
9899 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9900
9901         * linux-nat.c (delete_lwp_cleanup): Delete.
9902         (struct lwp_deleter): New struct.
9903         (lwp_info_up): New typedef.
9904         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9905         lwp_info_up.
9906
9907 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9908
9909         * linux-fork.c (class scoped_switch_fork_info): New class.
9910         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9911
9912 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9913
9914         * valops.c (find_overload_match): Remove use of null_cleanup, and
9915         calls to do_cleanups.
9916
9917 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9918
9919         * compile/compile-cplus-types.c
9920         (compile_cplus_instance::decl_name): Handle changes to
9921         cp_func_name.
9922         * cp-support.c (cp_func_name): Update header comment, update
9923         return type.
9924         * cp-support.h (cp_func_name): Update return type in declaration.
9925         * valops.c (find_overload_match): Move temp_func local to top
9926         level of function and change its type.  Use temp_func to hold and
9927         delete temporary string obtained from cp_func_name.
9928
9929 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9930
9931         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9932         gdb::char_vector, remove cleanup, and update uses of `msg`.
9933
9934 2019-01-03  Jim Wilson  <jimw@sifive.com>
9935
9936         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9937
9938 2019-01-02  Tom Tromey  <tom@tromey.com>
9939
9940         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9941         (tdesc_parse_xml): Remove cleanups.
9942         * target-descriptions.h (make_cleanup_free_target_description):
9943         Don't declare.
9944         (target_desc_deleter): New struct.
9945         (target_desc_up): New typedef.
9946         * target-descriptions.c (target_desc_deleter::operator()): Rename
9947         from free_target_description.
9948         (make_cleanup_free_target_description): Remove.
9949
9950 2019-01-02  Tom Tromey  <tom@tromey.com>
9951
9952         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9953         constructor, destructor.
9954         (linespec_parser): Remove typedef.
9955         (~linespec_parser): Rename from linespec_parser_delete.
9956         (linespec_lex_to_end, linespec_complete_label)
9957         (linespec_complete): Update.
9958         (decode_line_full): Remove cleanups.
9959         (decode_line_1): Update.
9960
9961 2019-01-02  Tom Tromey  <tom@tromey.com>
9962
9963         * python/python-internal.h (inferior_to_inferior_object): Change
9964         return type.
9965         * python/py-exitedevent.c (create_exited_event_object): Update.
9966         * python/py-inferior.c (inferior_to_inferior_object): Return
9967         gdbpy_ref.
9968         (python_new_inferior, python_inferior_deleted)
9969         (thread_to_thread_object, delete_thread_object)
9970         (build_inferior_list, gdbpy_selected_inferior): Update.
9971         * python/py-infthread.c (create_thread_object): Update.  Also fail
9972         if inferior_to_inferior_object fails.
9973
9974 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9975
9976         * inferior.h (class inferior) <displaced_step_state>: New field.
9977         * infrun.h (struct displaced_step_state): Move here from
9978         infrun.c.  Initialize fields, add constructor.
9979         <inf>: Remove field.
9980         <reset>: New method.
9981         * infrun.c (struct displaced_step_inferior_state): Move to
9982         infrun.h.
9983         (displaced_step_inferior_states): Remove.
9984         (get_displaced_stepping_state): Adust.
9985         (displaced_step_in_progress_any_inferior): Adjust.
9986         (displaced_step_in_progress_thread): Adjust.
9987         (displaced_step_in_progress): Adjust.
9988         (add_displaced_stepping_state): Remove.
9989         (get_displaced_step_closure_by_addr): Adjust.
9990         (remove_displaced_stepping_state): Remove.
9991         (infrun_inferior_exit): Call displaced_step_state.reset.
9992         (use_displaced_stepping): Don't check for NULL.
9993         (displaced_step_prepare_throw): Call
9994         get_displaced_stepping_state.
9995         (displaced_step_fixup): Don't check for NULL.
9996         (prepare_for_detach): Don't check for NULL.
9997
9998 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9999
10000         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10001          in case of call that did not complete.
10002
10003 2019-01-02  Andrey Utkin  <autkin@undo.io>
10004
10005         * symfile.c (find_separate_debug_file): Fix search of debug files for
10006         remote debuggee.
10007
10008 2019-01-02  Tom Tromey  <tom@tromey.com>
10009
10010         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10011         indentation.
10012         * python/py-frame.c (frapy_older): Remove cast.
10013         (frapy_newer): Likewise.
10014         * python/py-breakpoint.c (local_setattro): Remove cast.
10015         * python/py-arch.c (archpy_name): Remove local variable.
10016         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10017
10018 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10019
10020         * unittests/basic_string_view/element_access/char/empty.cc:
10021         Fix year range in copyright header.
10022
10023 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10024
10025         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10026         Delete.
10027         <operator==>: Update with for removed field.
10028         <hash>: Likewise.
10029         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10030         <isa_features>: ...this.
10031         <abi_features>: New field.
10032         (riscv_isa_flen): Update comment.
10033         (riscv_abi_xlen): New declaration.
10034         (riscv_abi_flen): New declaration.
10035         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10036         isa_features.
10037         (riscv_abi_xlen): New function.
10038         (riscv_isa_flen): Update to get answer from isa_features.
10039         (riscv_abi_flen): New function.
10040         (riscv_has_fp_abi): Update to get answer from abi_features.
10041         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10042         xlen and flen.
10043         (riscv_call_info) <xlen, flen>: Update comment.
10044         (riscv_call_arg_struct): Remove invalid assertions
10045         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10046         is removed.
10047         (riscv_gdbarch_init): Gather isa features and abi features
10048         separately, ensure both match on the gdbarch when reusing an old
10049         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10050         a target with 64-bit float hardware.
10051
10052 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10053
10054         * source.c (search_command_helper): Stop reverse search
10055         when line 1 has been searched.
10056
10057 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10058
10059         * record-full.c (record_full_base_target::close): Rewrite
10060         record_full_core_buf_list free logic.
10061
10062 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10063
10064         * break-catch-syscall.c (print_one_catch_syscall): xfree
10065         the last text.
10066
10067 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10068
10069         * top.c (print_gdb_version): Update Copyright year in version
10070         message.
10071
10072 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10073
10074         Update copyright year range in all GDB files.
10075
10076 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10077
10078         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10079
10080 For older changes see ChangeLog-2018.
10081 \f
10082 Local Variables:
10083 mode: change-log
10084 left-margin: 8
10085 fill-column: 74
10086 version-control: never
10087 coding: utf-8
10088 End:
10089