gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (show_source_disasm_command): Use
   4         reset_locator.
   5         (reset_locator): New function.
   6         (init_and_make_win): Remove.
   7         (show_source_or_disasm_and_command): Use reset_locator.
   8
   9 2019-07-17  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
  12         condition.
  13         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
  14         Remove condition.
  15         * tui/tui-source.c (tui_source_window_base::reset): New method.
  16         * tui/tui-layout.c (make_command_window): Don't call
  17         init_and_make_win.
  18         (make_source_window, make_disasm_window): Don't call
  19         make_source_or_disasm_window.
  20         (make_data_window): Don't call init_and_make_win.  Change calling
  21         convention.
  22         (show_source_disasm_command, show_data): Simplify.
  23         (make_source_or_disasm_window): Remove.
  24         (show_source_or_disasm_and_command): Simplify.
  25         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
  26         (struct tui_source_window_base) <reset>: Likewise.
  27         <execution_info>: Remove initializer.
  28         * tui/tui-data.c (tui_source_window_base): Initialize
  29         execution_info.
  30
  31 2019-07-17  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
  34         variable.
  35
  36 2019-07-17  Tom Tromey  <tom@tromey.com>
  37
  38         * tui/tui.c (tui_rl_other_window): Update.
  39         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
  40         superclass method first.  Always iterate over regs_content.
  41         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
  42         method.
  43         * tui/tui-win.c (tui_set_focus_command): Update.
  44
  45 2019-07-17  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-win.c (tui_set_focus_command): Rename from
  48         tui_set_focus.  Call tui_enable.
  49         (tui_set_focus_command): Remove.
  50
  51 2019-07-17  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
  54         refresh_window.
  55         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
  56         touchwin.
  57         (tui_data_window::refresh_window): Call refresh_window on data
  58         items.  Always call superclass refresh_window.
  59         (tui_win_info::refresh): Remove.
  60         (tui_source_window_base::refresh_window): Update.
  61         (tui_refresh_all): Update.
  62         * tui/tui-layout.c (show_source_disasm_command): Remove call to
  63         refresh_window.
  64         (show_source_or_disasm_and_command): Likewise.
  65         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
  66         (struct tui_source_window_base) <refresh>: Likewise.
  67
  68 2019-07-17  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-winsource.c (tui_clear_source_content)
  71         (tui_show_source_content): Update.
  72         * tui/tui-source.c (tui_source_window::showing_source_p): Check
  73         whether content is empty.
  74         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
  75         Remove.
  76
  77 2019-07-17  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-winsource.c (tui_erase_source_content): Clear the
  80         window's contents.
  81         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
  82         * tui/tui-source.c (tui_set_source_content_nil): Remove.
  83
  84 2019-07-17  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
  87         (struct tui_data_item_window): Update.
  88
  89 2019-07-17  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
  92         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
  93         defines.
  94
  95 2019-07-17  Tom Tromey  <tom@tromey.com>
  96
  97         * tui/tui-winsource.h (tui_erase_source_content)
  98         (tui_clear_source_content): Remove "display_prompt" parameter.
  99         * tui/tui-winsource.c (tui_update_source_window_as_is)
 100         (tui_update_source_windows_with_addr): Update.
 101         (tui_clear_source_content): Remove "display_prompt" parameter.
 102         (tui_erase_source_content): Likewise.  Simplify.
 103         (tui_show_source_content): Update.
 104         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 105         * tui/tui-stack.c (tui_show_frame_info): Update.
 106         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 107         Remove defines.
 108
 109 2019-07-17  Tom Tromey  <tom@tromey.com>
 110
 111         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 112         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 113         parameter.
 114         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 115         parameter.
 116
 117 2019-07-17  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-winsource.c (tui_clear_source_content)
 120         (tui_show_source_content, tui_show_exec_info_content)
 121         (tui_clear_exec_info_content): Update.
 122         * tui/tui-stack.c (tui_show_locator_content): Update.
 123         (tui_show_frame_info): Update.
 124         * tui/tui-source.h (tui_source_window): Don't declare.
 125         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 126         from tui_source_is_displayed.
 127         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 128         Remove field.
 129         (struct tui_source_window_base) <content_in_use>: New field.  Now
 130         bool.
 131         (struct tui_source_window) <showing_source_p>: New method.
 132         (TUI_SRC_WIN): Change cast.
 133         * tui/tui-data.c (tui_initialize_static_data): Update.
 134
 135 2019-07-17  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 138         location_matches_p.
 139         * tui/tui-source.c (tui_source_window::location_matches_p): New
 140         method.
 141         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 142         method.
 143         * tui/tui-data.h (struct tui_source_window_base)
 144         <location_matches_p>: New method.
 145         (struct tui_source_window, struct tui_disasm_window)
 146         <location_matches_p>: Likewise.
 147
 148 2019-07-17  Tom Tromey  <tom@tromey.com>
 149
 150         * tui/tui-win.c (tui_set_win_height_command): Rename from
 151         tui_set_win_height.
 152         (tui_set_win_height_command): Remove.
 153
 154 2019-07-17  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-source.c (tui_source_window): New constructor.  Add
 157         observer.
 158         (~tui_source_window): New destructor.
 159         (tui_source_window::style_changed): New method.
 160         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 161         (tui_attach_detach_observers): Update.
 162         * tui/tui-data.h (struct tui_source_window): Make constructor not
 163         inline.  Add destructor.
 164         (struct tui_source_window) <style_changed>: New method.
 165         <m_observable>: New member.
 166
 167 2019-07-17  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 170         * tui/tui-win.c (tui_resize_all): Fix typo.
 171
 172 2019-07-17  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 175         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 176         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 177         * tui/tui-win.c (window_name_completer): Use foreach.
 178         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 179         (update_tab_width): Likewise.
 180         * tui/tui-layout.c (show_layout): Update.
 181         * tui/tui-data.h (class tui_window_iterator): New.
 182         (struct all_tui_windows): New.
 183         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 184
 185 2019-07-17  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 188         parameter.  Don't reference globals.
 189         (tui_reg_command): Update.
 190
 191 2019-07-17  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-regs.c (tui_show_registers): Simplify.
 194
 195 2019-07-17  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-regs.c (tui_show_registers): Update.
 198         (tui_show_register_group): Add win_info parameter.
 199
 200 2019-07-17  Tom Tromey  <tom@tromey.com>
 201
 202         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 203         Rename from tui_display_reg_element_at_line.
 204         (tui_data_window::display_registers_from_line): Update.
 205         * tui/tui-data.h (struct tui_data_window)
 206         <display_reg_element_at_line>: New method.
 207
 208 2019-07-17  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-regs.h (tui_display_registers_from)
 211         (tui_display_registers_from_line): Don't declare.
 212         * tui/tui-windata.c (tui_data_window::display_all_data)
 213         (tui_data_window::refresh_all)
 214         (tui_data_window::do_scroll_vertical): Update.
 215         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 216         from tui_display_registers_from.
 217         (tui_display_reg_element_at_line): Update.
 218         (tui_data_window::display_registers_from_line): Rename from
 219         tui_display_registers_from_line.
 220         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 221         display_registers_from_line>: New methods.
 222
 223 2019-07-17  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 226         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 227         from tui_erase_data_content.
 228         (tui_data_window::display_all_data)
 229         (tui_data_window::refresh_all)
 230         (tui_data_window::do_scroll_vertical): Update.
 231         * tui/tui-regs.c (tui_show_registers): Update.
 232         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 233         New method.
 234
 235 2019-07-17  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 238         declare.
 239         * tui/tui-windata.c
 240         (tui_data_window::delete_data_content_windows): Rename from
 241         tui_delete_data_content_windows.
 242         (tui_data_window::display_all_data)
 243         (tui_data_window::do_scroll_vertical): Update.
 244         * tui/tui-data.h (struct tui_data_window)
 245         <delete_data_content_windows>: New method.
 246
 247 2019-07-17  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 250         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 251
 252 2019-07-17  Tom Tromey  <tom@tromey.com>
 253
 254         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 255         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 256         from tui_display_all_data.
 257         * tui/tui-win.c
 258         (tui_data_window::do_make_visible_with_new_height): Update.
 259         * tui/tui-regs.c (tui_show_registers): Update.
 260         * tui/tui-layout.c (tui_set_layout): Update.
 261         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 262         method.
 263
 264 2019-07-17  Tom Tromey  <tom@tromey.com>
 265
 266         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 267         * tui/tui-windata.c (tui_display_data_from): Remove.
 268         (tui_data_window::refresh_all): Update.
 269
 270 2019-07-17  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 273         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 274         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 275         tui_display_registers_from_line.
 276         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 277         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 278         "force_display" parameter.
 279
 280 2019-07-17  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 283         declare.
 284         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 285         Rename from tui_first_reg_element_no_inline.
 286         (tui_display_reg_element_at_line)
 287         (tui_display_registers_from_line): Update.
 288         * tui/tui-data.h (struct tui_data_window)
 289         <first_reg_element_no_inline>: New method.
 290
 291 2019-07-17  Tom Tromey  <tom@tromey.com>
 292
 293         * tui/tui-windata.c (tui_display_data_from)
 294         (tui_data_window::do_scroll_vertical): Update.
 295         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 296         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 297         Rename from tui_line_from_reg_element_no.
 298         (tui_display_registers_from_line): Update.
 299         * tui/tui-data.h (struct tui_data_window)
 300         <line_from_reg_element_no>: New method.
 301
 302 2019-07-17  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 305         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 306         tui_last_regs_line_no.
 307         (tui_display_reg_element_at_line)
 308         (tui_display_registers_from_line): Update.
 309         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 310         method.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         PR tui/24722:
 315         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 316         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 317         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 318         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 319         (tui_update_breakpoint_info): Likewise.
 320         * tui/tui-hooks.c (tui_event_create_breakpoint)
 321         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 322         Update.
 323
 324 2019-07-17  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 327
 328 2019-07-17  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-winsource.c (tui_update_source_window_as_is)
 331         (tui_update_source_windows_with_addr): Update.
 332         * tui/tui-source.h (tui_set_source_content)
 333         (tui_show_symtab_source): Add "win_info" parameter.
 334         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 335         parameter.
 336         (tui_show_symtab_source): Likewise.
 337
 338 2019-07-17  Tom Tromey  <tom@tromey.com>
 339
 340         * tui/tui-wingeneral.c
 341         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 342
 343 2019-07-17  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 346         (struct tui_cmd_window) <can_scroll>: New method.
 347         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 348         method.
 349
 350 2019-07-17  Tom Tromey  <tromey@adacore.com>
 351
 352         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 353         do_field_signed>: Rename.  Change type of "value".
 354         * ui-out.c (ui_out::field_signed): Rename from field_int.
 355         Change type of "value".
 356         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 357         type of "value".
 358         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 359         do_field_int.  Change type of "value".
 360         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 361         do_field_int.  Change type of "value".
 362         * tracepoint.c (trace_status_mi, tfind_1)
 363         (print_one_static_tracepoint_marker): Update.
 364         * thread.c (print_thread_info_1, print_selected_thread_frame):
 365         Update.
 366         * stack.c (print_frame, print_frame_info): Update.
 367         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 368         Update.
 369         * source.c (print_source_lines_base): Update.
 370         * skip.c (info_skip_command): Update.
 371         * record-btrace.c (btrace_ui_out_decode_error)
 372         (btrace_call_history_src_line): Update.
 373         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 374         Update.
 375         * progspace.c (print_program_space): Update.
 376         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 377         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 378         do_field_int.  Change type of "value".
 379         * mi/mi-out.c (mi_ui_out::do_table_begin)
 380         (mi_ui_out::do_table_header): Update.
 381         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 382         type of "value".
 383         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 384         (mi_cmd_data_list_changed_registers, output_register)
 385         (mi_cmd_data_read_memory, mi_load_progress)
 386         (mi_cmd_trace_frame_collected): Update.
 387         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 388         Update.
 389         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 390         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 391         (mi_cmd_var_list_children, varobj_update_one): Update.
 392         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 393         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 394         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 395         * inferior.c (print_inferior): Update.
 396         * gdb_bfd.c (print_one_bfd): Update.
 397         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 398         Update.
 399         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 400         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 401         do_field_int.  Change type of "value".
 402         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 403         do_field_int.  Change type of "value".
 404         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 405         (print_one_breakpoint_location, print_it_catch_fork)
 406         (print_one_catch_fork, print_it_catch_vfork)
 407         (print_one_catch_vfork, print_it_catch_solib)
 408         (print_it_catch_exec, print_it_ranged_breakpoint)
 409         (print_mention_watchpoint, print_mention_masked_watchpoint)
 410         (bkpt_print_it, update_static_tracepoint): Update.
 411         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 412         * break-catch-syscall.c (print_it_catch_syscall): Update.
 413         * ada-tasks.c (print_ada_task_info): Update.
 414         * ada-lang.c (print_it_exception, print_mention_exception):
 415         Update.
 416
 417 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 418
 419         PR breakpoints/24541
 420         * gdbarch.c: Regenerate.
 421         * gdbarch.h: Regenerate.
 422         * gdbarch.sh: Adjust return type and parameter types for
 423         'stap_adjust_register'.
 424         (i386_stap_adjust_register): Adjust signature and return new
 425         register name.
 426         * stap-probe.c (stap_parse_register_operand): Adjust use of
 427         'gdbarch_stap_adjust_register'.
 428
 429 2019-07-17  Tom Tromey  <tromey@adacore.com>
 430
 431         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 432         declare VEC.
 433         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 434         std::vector.
 435         (struct s390_process_info): Add initializers.
 436         (s390_add_process): Use new.
 437         (s390_linux_nat_target::low_forget_process): Use delete.
 438         (s390_linux_nat_target::low_new_fork)
 439         (s390_linux_nat_target::stopped_by_watchpoint)
 440         (s390_linux_nat_target::low_prepare_to_resume)
 441         (s390_linux_nat_target::insert_watchpoint)
 442         (s390_linux_nat_target::insert_hw_breakpoint)
 443         (s390_linux_nat_target::remove_watchpoint)
 444         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 445
 446 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 447
 448         * aarch64-fbsd-nat.c: Include regcache.h.
 449         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 450         argument.
 451         (aarch64_fbsd_nat_target::fetch_registers)
 452         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 453         variable.
 454         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 455
 456 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 457
 458         * fbsd-nat.c: Include gdbarch.h.
 459
 460 2019-07-15  Tom Tromey  <tromey@adacore.com>
 461
 462         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 463
 464 2019-07-15  Tom Tromey  <tromey@adacore.com>
 465
 466         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 467         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 468         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 469         * cli-out.c (cli_ui_out::do_field_int): New method.
 470         * ui-out.c (ui_out::field_unsigned): New method.
 471         * symfile.c (generic_load): Use field_unsigned.
 472         (print_transfer_performance): Likewise.
 473         * record-btrace.c (ui_out_field_uint): Remove.
 474         (btrace_call_history_insn_range, btrace_call_history): Use
 475         field_unsigned.
 476         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 477         field_unsigned.
 478         * ui-out.h (class ui_out) <field_unsigned>: New method.
 479         <do_field_unsigned>: Likewise.
 480
 481 2019-07-15  Tom Tromey  <tromey@adacore.com>
 482
 483         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 484         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 485         * target.c (flash_erase_command): Use field_string.
 486         * infrun.c (print_signal_received_reason): Use field_string.
 487         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 488         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 489         field_string.
 490         * ada-tasks.c (print_ada_task_info): Use field_string.
 491
 492 2019-07-15  Tom Tromey  <tromey@adacore.com>
 493
 494         * target.c (flash_erase_command): Use field_core_addr.
 495         * symfile.c (generic_load): Use field_core_addr.
 496         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 497         Use field_core_addr.
 498         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 499         field_core_addr.
 500
 501 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 502
 503         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 504         value if its desired type is smaller than a CORE_ADDR and signed.
 505
 506 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 509         of changes to field names, and use new is_reference field to
 510         decide if a property is a reference or not.
 511         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 512         field.
 513         (struct dwarf2_property_baton): Update header comment, rename
 514         'referenced_type' to 'property_type' and update comments.
 515         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 516         default property type, store in property baton, update to take
 517         accound of renamed field.
 518         (read_func_scope): Update call to attr_to_dynamic_prop.
 519         (read_array_type): Likewise.
 520         (dwarf2_per_cu_addr_sized_int_type): New function.
 521         (read_subrange_index_type): Move type finding code to
 522         dwarf2_per_cu_addr_sized_int_type.
 523         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 524         (dwarf2_per_cu_addr_type): New function.
 525         (set_die_type): Update calls to attr_to_dynamic_prop.
 526
 527 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 528
 529         * dwarf2read.c (read_subrange_index_type): New function.
 530         (read_subrange_type): Move code into new function and call it.
 531         * gdbtypes.c (create_range_type): Add some asserts.
 532
 533 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 534
 535         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 536         update return statements.
 537         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 538         declaration, and update comment to match.
 539         * gdbtypes.c (resolve_dynamic_array): Update call to
 540         dwarf2_evaluate_property to match new return type.
 541
 542 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 543
 544         * valarith.c (value_subscripted_rvalue): Change lowerbound
 545         parameter type from int to LONGEST.
 546         * value.h (value_subscripted_rvalue): Likewise in declaration.
 547
 548 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 549
 550         * cli/cli-utils.c (info_print_command_completer): New function.
 551         * cli/cli-utils.h: Add 'completer.h' include, and forward
 552         declaration for 'struct cmd_list_element'.
 553         (info_print_command_completer): Declare.
 554         * stack.c (_initialize_stack): Add completer for 'info locals' and
 555         'info args'.
 556         * symtab.c (_initialize_symtab): Add completer for 'info
 557         variables' and 'info functions'.
 558         * NEWS: Mention completion for additional info commands.
 559
 560 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * cli/cli-utils.c (extract_info_print_args): Delete.
 563         (extract_arg_maybe_quoted): Delete.
 564         (info_print_options_defs): New variable.
 565         (make_info_print_options_def_group): New function.
 566         (extract_info_print_options): Define new function.
 567         * cli/cli-utils.h (extract_info_print_args): Delete.
 568         (struct info_print_options): New structure.
 569         (extract_info_print_options): Declare new function.
 570         * stack.c (info_locals_command): Update to use new
 571         extract_info_print_options, also add a header comment.
 572         (info_args_command): Likewise.
 573         * symtab.c (info_variables_command): Likewise.
 574         (info_functions_command): Likewise.
 575
 576 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 577
 578         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 579         to extract string arguments.
 580         * common/common-utils.c (extract_string_maybe_quoted): New function.
 581         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 582
 583 2019-07-11  Tom Tromey  <tromey@adacore.com>
 584
 585         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 586         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 587         * top.h (gdbinit): Don't declare.
 588         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 589         into...
 590         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 591         * top.c (gdb_init): Don't call init_cli_cmds.
 592         (gdbinit): Remove.
 593         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 594
 595 2019-07-11  Tom Tromey  <tromey@adacore.com>
 596
 597         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 598         after it has been moved.
 599
 600 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 601
 602         * valops.c (value_must_coerce_to_target): Change return type to
 603         bool.
 604         * value.h (value_must_coerce_to_target): Likewise.
 605
 606 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 607
 608         * breakpoint.c (is_hardware_watchpoint): Remove
 609         forward-declaration.
 610         (is_masked_watchpoint): Change return type to bool.
 611         (is_tracepoint): Likewise.
 612         (is_breakpoint): Likewise.
 613         (is_hardware_watchpoint): Likewise.
 614         (is_watchpoint): Likewise.
 615         (is_no_memory_software_watchpoint): Likewise.
 616         (is_catchpoint): Likewise.
 617         (breakpoint_1): Make FILTER parameter's return type bool.
 618         is_masked_watchpoint): Change return type to bool.
 619         (save_breakpoints): Make FILTER parameter's return type bool.
 620         * breakpoint.h (is_breakpoint): Change return type to bool.
 621         (is_watchpoint): Likewise.
 622         (is_catchpoint): Likewise.
 623         (is_tracepoint): Likewise.
 624
 625 2019-07-10  Tom Tromey  <tom@tromey.com>
 626
 627         * defs.h: Don't include gdbarch.h.
 628         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 629         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 630         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 631         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 632         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 633         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 634         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 635         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 636         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 637         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 638         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 639         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 640         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 641         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 642         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 643         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 644         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 645         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 646         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 647         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 648         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 649         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 650         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 651         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 652         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 653         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 654         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 655
 656 2019-07-10  Tom Tromey  <tromey@adacore.com>
 657
 658         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 659         * breakpoint.c (init_ada_exception_breakpoint): Register as
 660         bp_catchpoint.
 661         (print_one_breakpoint_location, print_one_breakpoint): Use
 662         is_ada_exception_catchpoint.
 663         * ada-lang.c (class ada_catchpoint_location): Pass
 664         bp_loc_software_breakpoint to bp_location constructor.
 665         (is_ada_exception_catchpoint): New function.
 666
 667 2019-07-10  Tom Tromey  <tromey@adacore.com>
 668
 669         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 670         VEC.
 671         (struct arm_exidx_entry): New method operator<.
 672         (struct arm_exidx_data) <section_maps>: Change type.
 673         (arm_exidx_data_free): Remove.
 674         (arm_exidx_data_key): Change type.  Move lower.
 675         (arm_exidx_new_objfile): Update.
 676         (arm_compare_exidx_entries): Remove.
 677         (arm_find_exidx_entry, _initialize_arm_tdep)
 678
 679 2019-07-10  Tom Tromey  <tromey@adacore.com>
 680
 681         * solib-spu.c (ocl_program_data_key): Change type.
 682         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 683         Update.
 684
 685 2019-07-10  Tom Tromey  <tromey@adacore.com>
 686
 687         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 688         (struct solib_aix_inferior_data) <library_list>: Change type.
 689         (solib_aix_inferior_data_handle): Change type.
 690         (get_solib_aix_inferior_data): Update.
 691         (solib_aix_free_library_list): Remove.
 692         (library_list_start_library): Update.
 693         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 694         return type.
 695         (solib_aix_get_library_list)
 696         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 697         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 698
 699 2019-07-10  Tom Tromey  <tromey@adacore.com>
 700
 701         * solib-dsbt.c (struct dsbt_info): Add initializers.
 702         (solib_dsbt_pspace_data): Change type.
 703         (dsbt_pspace_data_cleanup): Remove.
 704         (get_dsbt_info, _initialize_dsbt_solib): Update.
 705
 706 2019-07-10  Tom Tromey  <tromey@adacore.com>
 707
 708         * spu-tdep.c (spu_overlay_data): Change type.
 709         (spu_get_overlay_table, spu_overlay_new_objfile)
 710         (_initialize_spu_tdep): Update.
 711
 712 2019-07-10  Tom Tromey  <tromey@adacore.com>
 713
 714         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 715         destructor.
 716         (dbx_objfile_data_key): Change type and declare later.
 717         (DBX_SYMFILE_INFO): Rewrite.
 718         * dbxread.c (dbx_objfile_data_key): Change type.
 719         (dbx_symfile_init): Update.
 720         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 721         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 722         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 723
 724 2019-07-10  Tom Tromey  <tromey@adacore.com>
 725
 726         * jit.c (jit_program_space_key): Change type.  Move lower.
 727         (get_jit_program_space_data): Update.
 728         (jit_program_space_data_cleanup): Remove.
 729         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 730         Update.
 731         (struct jit_program_space_data): Add initializers.
 732
 733 2019-07-10  Tom Tromey  <tromey@adacore.com>
 734
 735         * solib-darwin.c (struct darwin_info): Add initializers.
 736         (solib_darwin_pspace_data): Change type.
 737         (darwin_pspace_data_cleanup): Remove.
 738         (get_darwin_info, _initialize_darwin_solib): Update.
 739
 740 2019-07-10  Tom Tromey  <tromey@adacore.com>
 741
 742         * remote-sim.c (struct sim_inferior_data): Add initializers,
 743         constructor, and destructor.
 744         (sim_inferior_data_key): Change type.  Move lower.
 745         (check_for_duplicate_sim_descriptor): Update.
 746         (get_sim_inferior_data): Use new.  Update.
 747         (~sim_inferior_data_cleanup): Rename from
 748         sim_inferior_data_cleanup.  Simplify.
 749         (gdbsim_close_inferior, simulator_command)
 750         (sim_command_completer, _initialize_remote_sim): Update.
 751         (next_pid, INITIAL_PID): Move earlier.
 752
 753 2019-07-10  Tom Tromey  <tromey@adacore.com>
 754
 755         * python/python-internal.h (create_thread_object): Return
 756         gdbpy_ref.
 757         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 758         * python/py-inferior.c (struct threadlist_entry): Add
 759         constructor.
 760         <thread_obj>: Now a gdbpy_ref.
 761         (thread_to_thread_object): Update.
 762         (add_thread_object): Use new.
 763         (delete_thread_object): Use delete.
 764         (infpy_threads): Update.
 765         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 766         GIL.
 767
 768 2019-07-10  Tom Tromey  <tromey@adacore.com>
 769
 770         * valops.c (value_cast): Specialize error message for Ada.
 771
 772 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 773
 774         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 775
 776 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 777
 778         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 779         bpstat_should_step): Return bool, adjust comments.
 780         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 781         bpstat_should_step): Likewise.
 782
 783 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 784
 785         * features/Makefile: Use feature target descriptions for Arm.
 786         * features/arm/arm-core.c: Generate new file.
 787         * features/arm/arm-fpa.c: Likewise.
 788         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 789         * features/arm/arm-m-profile.c: Likewise.
 790         * features/arm/arm-vfpv2.c: Likewise.
 791         * features/arm/arm-vfpv3.c: Likewise.
 792         * features/arm/xscale-iwmmxt.c: Likewise.
 793         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 794
 795 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 796
 797         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 798         ptrace earlier.
 799
 800 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 801
 802         * features/aarch64-pauth.c: Regenerate.
 803
 804 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 805
 806         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 807         bool.
 808         (bpstat_what): Use false instead of 0.
 809
 810 2019-07-09  Pedro Alves  <palves@redhat.com>
 811
 812         * break-catch-throw.c (is_exception_catchpoint): New.
 813         * breakpoint.c (print_one_breakpoint_location): New parameter
 814         'raw_loc'.  Handle it.  Use
 815         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 816         looking at the breakpoint's type.
 817         (print_one_breakpoint): If handling "maint info breakpoints", also
 818         print locations of exception catchpoints.
 819         * breakpoint.h (is_exception_catchpoint): Declare.
 820
 821 2019-07-09  Pedro Alves  <palves@redhat.com>
 822
 823         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 824         "addr" field.
 825         (allocate_location_exception_catchpoint): New.
 826         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 827         (initialize_throw_catchpoint_ops): Install
 828         allocate_location_exception_catchpoint as allocate_location
 829         method.
 830         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 831         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 832         bp_loc_other.
 833         (breakpoint_address_is_meaningful): Delete.
 834         (bl_address_is_meaningful): New.
 835         (breakpoint_locations_match): Adjust comment.
 836         (bp_location_from_bp_type): New, factored out of...
 837         (bp_location::bp_location(breakpoint *)): ... this.
 838         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 839         factored out of...
 840         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 841         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 842         breakpoint_address_is_meaningful.
 843         (bp_locations_compare): Adjust comment.
 844         (update_global_location_list): Use bl_address_is_meaningful
 845         instead of breakpoint_address_is_meaningful.
 846         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 847         explicit.
 848         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 849         * python/py-breakpoint.c (bppy_get_location): No longer check
 850         whether location is null.
 851
 852 2019-07-09  Pedro Alves  <palves@redhat.com>
 853
 854         PR c++/15468
 855         * breakpoint.c (print_one_breakpoint_location): Remove
 856         single-location assert.
 857
 858 2019-07-09  Tom Tromey  <tom@tromey.com>
 859
 860         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 861         * configure: Rebuild.
 862         * configure.ac: Change common to gdbsupport.
 863         * gdbsupport: Rename from common.
 864         * acinclude.m4: Change common to gdbsupport.
 865         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 866         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 867         gdbsupport.
 868         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 869         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 870         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 871         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 872         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 873         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 874         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 875         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 876         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 877         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 878         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 879         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 880         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 881         coff-pe-read.c, command.h, compile/compile-c-support.c,
 882         compile/compile-c.h, compile/compile-cplus-symbols.c,
 883         compile/compile-cplus-types.c, compile/compile-cplus.h,
 884         compile/compile-loc2c.c, compile/compile.c, completer.c,
 885         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 886         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 887         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 888         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 889         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 890         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 891         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 892         features/aarch64-core.c, features/aarch64-fpu.c,
 893         features/aarch64-pauth.c, features/aarch64-sve.c,
 894         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 895         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 896         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 897         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 898         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 899         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 900         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 901         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 902         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 903         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 904         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 905         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 906         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 907         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 908         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 909         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 910         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 911         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 912         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 913         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 914         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 915         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 916         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 917         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 918         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 919         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 920         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 921         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 922         minsyms.c, mips-linux-tdep.c, namespace.h,
 923         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 924         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 925         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 926         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 927         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 928         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 929         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 930         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 931         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 932         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 933         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 934         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 935         procfs.c, producer.c, progspace.h, psymtab.h,
 936         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 937         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 938         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 939         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 940         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 941         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 942         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 943         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 944         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 945         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 946         target-memory.c, target.c, target.h, target/waitstatus.c,
 947         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 948         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 949         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 950         unittests/array-view-selftests.c,
 951         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 952         unittests/common-utils-selftests.c,
 953         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 954         unittests/format_pieces-selftests.c,
 955         unittests/function-view-selftests.c,
 956         unittests/lookup_name_info-selftests.c,
 957         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 958         unittests/mkdir-recursive-selftests.c,
 959         unittests/observable-selftests.c,
 960         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 961         unittests/parse-connection-spec-selftests.c,
 962         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 963         unittests/scoped_fd-selftests.c,
 964         unittests/scoped_mmap-selftests.c,
 965         unittests/scoped_restore-selftests.c,
 966         unittests/string_view-selftests.c, unittests/style-selftests.c,
 967         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 968         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 969         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 970         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 971         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 972         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 973
 974 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 975
 976         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 977         bool value.
 978         (decode_digits_ordinary): Set explicit_line field in sal.
 979         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 980         symtab_and_line that was set on an explicit line number in
 981         assembler code.  Do always update the recorded symtab and line if
 982         we do skip the prologue.
 983
 984 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * breakpoint.c (set_breakpoint_location_function): Remove
 987         explicit_loc parameter.
 988         (momentary_breakpoint_from_master): Update call to
 989         set_breakpoint_location_function.
 990         (add_location_to_breakpoint): Likewise.
 991
 992 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 993
 994         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 995         required features based on default bfd type when no specific bfd
 996         is present.
 997
 998 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 999
1000         * NEWS: Mention that GDB printf and eval commands can now print
1001         C-style and Ada-style convenience var strings without
1002         calling the inferior.
1003         * printcmd.c (printf_c_string): Locally print GDB internal var
1004         instead of transiting via the inferior.
1005         (printf_wide_c_string): Likewise.
1006
1007 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1008
1009         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1010
1011 2019-07-04  Tom Tromey  <tom@tromey.com>
1012
1013         PR tui/24724:
1014         * tui/tui-winsource.c (tui_clear_source_content): Update.
1015         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1016         (tui_update_breakpoint_info): Update.
1017         (tui_set_exec_info_content): Update.
1018         * tui/tui-source.c (tui_set_source_content_nil): Update.
1019         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1020         has_break.
1021         * tui/tui-data.h (enum tui_bp_flag): New.
1022         (tui_bp_flags): New enum flags type.
1023         (struct tui_source_element) <break_mode>: Change type.  Rename
1024         from has_break.
1025         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1026         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1027         constants.
1028         * tui/tui-winsource.h: Fix comment.
1029
1030 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1031
1032         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1033         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1034         (store_fpregs_to_thread)
1035         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1036         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1037         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1038         (IWMMXT_REGS_SIZE): Add define.
1039         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1040         (fetch_vfp_regs, store_vfp_regs)
1041         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1042         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1043
1044 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1045
1046         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1047         defines.
1048         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1049         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1050         (ARM_INT_REGISTER_SIZE): ...to this.
1051         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1052         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1053         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1054         (arm_linux_collect_gregset, supply_nwfpe_register)
1055         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1056         defines.
1057         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1058         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1059         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1060         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1061         (arm_return_in_memory, arm_store_return_value)
1062         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1063         (arm_record_ld_st_multiple): Likewise.
1064         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1065         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1066
1067 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1068
1069         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1070         AARCH64_DISPLACED_MODIFIED_INSNS.
1071         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1072         (aarch64_displaced_step_copy_insn): Likewise.
1073         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1074         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1075         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1076         ARM_DISPLACED_MODIFIED_INSNS.
1077         * arm-tdep.c (arm_gdbarch_init): Likewise.
1078         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1079         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1080         (struct arm_displaced_step_closure): Use
1081         ARM_DISPLACED_MODIFIED_INSNS.
1082
1083 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1084
1085         * features/Makefile: Remove unused xml files.
1086         * features/aarch64.xml: Remove.
1087         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1088         * features/i386/amd64-avx-avx512.xml: Remove.
1089         * features/i386/amd64-avx-linux.xml: Remove.
1090         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1091         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1092         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1093         * features/i386/amd64-avx-mpx.xml: Remove.
1094         * features/i386/amd64-avx.xml: Remove.
1095         * features/i386/amd64-linux.xml: Remove.
1096         * features/i386/amd64-mpx-linux.xml: Remove.
1097         * features/i386/amd64-mpx.xml: Remove.
1098         * features/i386/amd64.xml: Remove.
1099         * features/i386/i386-avx-avx512-linux.xml: Remove.
1100         * features/i386/i386-avx-avx512.xml: Remove.
1101         * features/i386/i386-avx-linux.xml: Remove.
1102         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1103         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1104         * features/i386/i386-avx-mpx-linux.xml: Remove.
1105         * features/i386/i386-avx-mpx.xml: Remove.
1106         * features/i386/i386-avx.xml: Remove.
1107         * features/i386/i386-linux.xml: Remove.
1108         * features/i386/i386-mmx-linux.xml: Remove.
1109         * features/i386/i386-mmx.xml: Remove.
1110         * features/i386/i386-mpx-linux.xml: Remove.
1111         * features/i386/i386-mpx.xml: Remove.
1112         * features/i386/i386.xml: Remove.
1113         * features/i386/x32-avx-avx512-linux.xml: Remove.
1114         * features/i386/x32-avx-linux.xml: Remove.
1115         * features/i386/x32-linux.xml: Remove.
1116
1117 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1118
1119         * regformats/aarch64.dat: Remove.
1120         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1121         * regformats/i386/amd64-avx-linux.dat: Remove.
1122         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1123         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1124         * regformats/i386/amd64-linux.dat: Remove.
1125         * regformats/i386/amd64-mpx-linux.dat: Remove.
1126         * regformats/i386/amd64.dat: Remove.
1127         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1128         * regformats/i386/i386-avx-linux.dat: Remove.
1129         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1130         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1131         * regformats/i386/i386-linux.dat: Remove.
1132         * regformats/i386/i386-mmx-linux.dat: Remove.
1133         * regformats/i386/i386-mpx-linux.dat: Remove.
1134         * regformats/i386/i386.dat: Remove.
1135         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1136         * regformats/i386/x32-avx-linux.dat: Remove.
1137         * regformats/i386/x32-linux.dat: Remove.
1138
1139 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1140
1141         * aarch64-tdep.c: Remove xml self tests.
1142         * amd64-linux-tdep.c: Likewise.
1143         * amd64-tdep.c: Likewise.
1144         * i386-linux-tdep.c: Likewise.
1145         * i386-tdep.c: Likewise.
1146
1147 2019-07-03  Pedro Alves  <palves@redhat.com>
1148
1149         PR cli/24732
1150         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1151         (pipe_cmd_option_defs): New.
1152         (make_pipe_cmd_options_def_group): New.
1153         (pipe_command): Use gdb::option::process_options.
1154         (pipe_command_completer): New function.
1155         (_initialize_cli_cmds): Install completer for "pipe" command.
1156
1157 2019-07-03  Pedro Alves  <palves@redhat.com>
1158
1159         * cli/cli-option.c (union option_value) <string>: New field.
1160         (struct option_def_and_value): Add ctor, move ctor, dtor and
1161         use DISABLE_COPY_AND_ASSIGN.
1162         (option_def_and_value::clear_value): New.
1163         (parse_option, save_option_value_in_ctx, get_val_type_str)
1164         (add_setshow_cmds_for_options): Handle var_string.
1165         * cli-option.h (union option_def::var_address) <string>: New
1166         field.
1167         (struct string_option_def): New.
1168         * maint-test-options.c (struct test_options_opts): Add default
1169         ctor and use DISABLE_COPY_AND_ASSIGN.
1170         <string_opt>: New field.
1171         (test_options_opts::~test_options_opts): New.
1172         (test_options_opts::dump): Also dump "-string".
1173         (test_options_option_defs): Install "string.
1174
1175 2019-07-03  Pedro Alves  <palves@redhat.com>
1176
1177         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1178         option_value with a null enumeration.
1179         (complete_options): Save the option values in the context.
1180         (save_option_value_in_ctx): New, factored out from ...
1181         (process_options): ... here.
1182         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1183         of the function.
1184         * maint-test-options.c (test_options_opts::dump): New, factored
1185         out from ...
1186         (maintenance_test_options_command_mode): ... here.
1187         (maintenance_test_options_command_completion_result): Delete.
1188         (maintenance_test_options_command_completion_text): Update
1189         comment.
1190         (maintenance_show_test_options_completion_result): Change
1191         prototype.  Just print
1192         maintenance_test_options_command_completion_text.
1193         (save_completion_result): New.
1194         (maintenance_test_options_completer_mode): Pass options context to
1195         complete_options, and then save a dump.
1196         (_initialize_maint_test_options): Use add_cmd to install "maint
1197         show test-options-completion-result".
1198
1199 2019-07-03  Pedro Alves  <palves@redhat.com>
1200
1201         * NEWS (New commands): Mention "with" and "maint with".
1202         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1203         (with_command, with_command_completer): New.
1204         (pipe_command): Adjust to new repeat_previous
1205         interface.
1206         (_initialize_cli_cmds): Install the "with" command and its "w"
1207         alias.
1208         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1209         declarations.
1210         * cli/cli-setshow.c (parse_cli_var_uinteger)
1211         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1212         argument strings for all var_types.
1213         (get_setshow_command_value_string): New, factored out from ...
1214         (do_show_command): ... this.
1215         * cli/cli-setshow.h: Include <string>.
1216         (get_setshow_command_value_string): Declare.
1217         * command.h (repeat_previous): Now returns const char *.  Adjust
1218         comment.
1219         * maint.c: Include "cli/cli-cmds.h".
1220         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1221         (_initialize_maint_cmds): Register the "maintenance with" command.
1222         * top.c (repeat_previous): Move bits from pipe_command here:
1223         Return the saved command line, if any; error out if there's no
1224         command to relaunch.
1225
1226 2019-07-03  Pedro Alves  <palves@redhat.com>
1227
1228         * NEWS (New commands): Mention "maint set/show test-settings"
1229         instead of "maint test-settings".
1230         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1231         (maintenance_test_settings_set_list): Rename to ...
1232         (maintenance_set_test_settings_list): ... this.
1233         (maintenance_test_settings_show_list): Rename to  ...
1234         (maintenance_show_test_settings_list): ... this.
1235         (maintenance_test_settings_cmd): Delete.
1236         (maintenance_test_settings_set_cmd): ...
1237         (maintenance_set_test_settings_cmd): ... this.
1238         (maintenance_test_settings_show_cmd): ...
1239         (maintenance_show_test_settings_cmd): ... this.
1240         (maintenance_test_settings_show_value_cmd):
1241         (maintenance_show_test_settings_value_cmd): ... this.
1242         (_initialize_maint_test_settings): No longer install the "maint
1243         test-settings" prefix command.  Rename "maint test-settings set"
1244         to "maint set test-settings", and "maint test-settings show" to
1245         "maint show test-settings".  Adjust all subcommands.
1246
1247 2019-07-03  Pedro Alves  <palves@redhat.com>
1248
1249         * maint-test-settings.c: Fix file's intro comment.  Replace all
1250         references to "test-options" with references to "test-settings",
1251         in comments.
1252
1253 2019-07-03  Pedro Alves  <palves@redhat.com>
1254
1255         * maint-test-settings.c (maintenance_test_settings_xxx)
1256         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1257         New.
1258         (maintenance_test_settings_enums): Use them.
1259         (maintenance_test_settings_enum): Default to
1260         maintenance_test_settings_xxx.
1261         (_initialize_maint_test_settings): Initialize
1262         MAINTENANCE_TEST_SETTINGS_FILENAME.
1263
1264 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1265
1266         * breakpoint.h (remove_breakpoints_inf): Change return type to
1267         void, move function documentation here.
1268         * breakpoint.c (remove_breakpoints_inf): Change return type to
1269         void, move function documentation to header.
1270
1271 2019-07-02  Pedro Alves  <palves@redhat.com>
1272
1273         * NEWS (Completion improvements): Mention "info threads".
1274         * thread.c (struct info_threads_opts, info_threads_option_defs)
1275         (make_info_threads_options_def_group): New.
1276         (info_threads_command): Use gdb::option::process_options.
1277         (info_threads_command_completer): New.
1278         (_initialize_thread): Use gdb::option::build_help to build the
1279         help text for "info threads".
1280
1281 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1282
1283         * defs.h (generic_load): Move from here...
1284         * symfile.h (generic_load): ... to here.  Rename name parameter
1285         to args.
1286         * symfile.c (generic_load): Add comment.
1287
1288 2019-07-01  Tom Tromey  <tromey@adacore.com>
1289
1290         * dwarf2read.c
1291         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1292         declaration of without_params.  Fix formatting.
1293
1294 2019-07-01  Tom Tromey  <tromey@adacore.com>
1295
1296         * ada-exp.y (find_primitive_type): Update.
1297         * ada-lang.h (ada_lookup_symbol): Update.
1298         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1299         parameter.
1300         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1301
1302 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1303
1304         PR breakpoints/24541
1305         * gdbarch.c: Regenerate.
1306         * gdbarch.h: Regenerate.
1307         * gdbarch.sh: Add 'stap_adjust_register'.
1308         * i386-tdep.c: Include '<unordered_set>'.
1309         (i386_stap_adjust_register): New function.
1310         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1311         * stap-probe.c (stap_parse_register_operand): Call
1312         'gdbarch_stap_adjust_register'.
1313
1314 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1315
1316         PR python/24742
1317         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1318         * python/python.c (do_start_initialization): Use 'xmalloc'
1319         instead of 'PyMem_Malloc'.
1320
1321 2019-06-28  Tom Tromey  <tromey@adacore.com>
1322
1323         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1324         for Ada.
1325
1326 2019-06-27  Tom Tromey  <tromey@adacore.com>
1327
1328         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1329         objfile_key.
1330         (arm_find_mapping_symbol, arm_record_special_symbol)
1331         (_initialize_arm_tdep): Update.
1332         (arm_objfile_data_free): Remove.
1333
1334 2019-06-27  Tom Tromey  <tromey@adacore.com>
1335
1336         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1337         to cp_print_static_field.
1338
1339 2019-06-26  Tom Tromey  <tromey@adacore.com>
1340
1341         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1342         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1343         declare.
1344
1345 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1346
1347         * features/aarch64-core.c (create_feature_aarch64_core):
1348         Regenerate.
1349         * features/aarch64-core.xml: Add cpsr flags.
1350
1351 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1352
1353         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1354         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1355
1356 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1357
1358         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1359         field.
1360         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1361         use.
1362         (arm_record_special_symbol): Don't insert new symbol in sorted
1363         position, push it at the end.
1364
1365 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1366
1367         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1368         (arm_mapping_symbol_s): Remove.
1369         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1370         (arm_mapping_symbol_vec): New typedef.
1371         (struct arm_per_objfile): Add constructor.
1372         <section_maps>: Change type to
1373         std::unique_ptr<arm_mapping_symbol_vec[]>.
1374         (arm_compare_mapping_symbols): Remove.
1375         (arm_find_mapping_symbol): Adjust to section_maps type change.
1376         (arm_objfile_data_free): Call delete on arm_per_objfile.
1377         (arm_record_special_symbol): Adjust to section_maps type change.
1378         Allocate arm_per_objfile with new.
1379
1380 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1381
1382         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1383         with the command prefix.
1384
1385 2019-06-25  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1388         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1389
1390 2019-06-25  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1393         type.
1394         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1395         protected.
1396
1397 2019-06-25  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-winsource.c
1400         (tui_source_window_base::set_is_exec_point_at): Add check against
1401         LOA_ADDRESS.
1402
1403 2019-06-25  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-source.c (tui_set_source_content): Don't check before
1406         xfree.
1407         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1408
1409 2019-06-25  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-winsource.h (tui_update_source_window_as_is)
1412         (tui_alloc_source_buffer, tui_line_is_displayed)
1413         (tui_addr_is_displayed): Change type of win_info.
1414         * tui/tui-winsource.c (tui_update_source_window_as_is)
1415         (tui_clear_source_content, tui_show_source_line)
1416         (tui_show_source_content, tui_source_window_base::refill)
1417         (tui_source_window_base::set_is_exec_point_at)
1418         (tui_source_window_base::set_is_exec_point_at)
1419         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1420         (tui_alloc_source_buffer, tui_line_is_displayed)
1421         (tui_addr_is_displayed): Change type of win_info.  Update.
1422         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1423         (tui_source_window_base::do_make_visible_with_new_height):
1424         Update.
1425         * tui/tui-source.c (tui_set_source_content)
1426         (tui_set_source_content_nil)
1427         (tui_source_window::do_scroll_vertical): Update.
1428         * tui/tui-layout.c (show_layout): Update.
1429         * tui/tui-disasm.c (tui_set_disassem_content)
1430         (tui_disasm_window::do_scroll_vertical): Update.
1431         * tui/tui-data.h (tui_win_content): Remove.
1432         (struct tui_gen_win_info) <content, content_size>: Remove.
1433         (struct tui_source_element): Add initializers and destructor.
1434         (union tui_which_element, struct tui_win_element): Remove.
1435         (struct tui_source_window_base) <content>: New field.
1436         (struct tui_data_window): Remove destructor.
1437         (tui_alloc_content, tui_free_win_content)
1438         (tui_free_all_source_wins_content): Don't declare.
1439         * tui/tui-data.c (tui_initialize_static_data): Update.
1440         (init_content_element, tui_alloc_content): Remove.
1441         (~tui_gen_win_info): Update.
1442         (~tui_data_window, tui_free_all_source_wins_content)
1443         (tui_free_win_content, free_content, free_content_elements):
1444         Remove.
1445
1446 2019-06-25  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-winsource.h (tui_clear_source_content)
1449         (tui_erase_source_content, tui_show_source_content): Change type
1450         of win_info.
1451         * tui/tui-winsource.c (tui_clear_source_content)
1452         (tui_erase_source_content, tui_show_source_content): Change type
1453         of win_info.
1454         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1455         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1456         win_info.
1457         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1458         win_info.
1459         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1460
1461 2019-06-25  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-winsource.c (tui_clear_source_content)
1464         (tui_source_window_base::set_is_exec_point_at): Update.
1465         * tui/tui-source.c (tui_set_source_content_nil): Update.
1466         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1467         a bool.
1468         * tui/tui-data.c (init_content_element): Update.
1469
1470 2019-06-25  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1473         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1474         * tui/tui-layout.c (init_and_make_win): Update.
1475         * tui/tui.h (enum tui_win_type): Update.
1476         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1477         tui_win_is_auxillary.
1478         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1479         tui_win_is_auxillary.
1480
1481 2019-06-25  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1484         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1485         (tui_delete_data_content_windows, tui_display_all_data)
1486         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1487         Update.
1488         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1489         * tui/tui-regs.c (tui_last_regs_line_no)
1490         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1491         (tui_show_registers): Update.
1492         (tui_show_register_group): Return void.  Update.
1493         (tui_display_registers_from, tui_display_reg_element_at_line)
1494         (tui_display_registers_from_line, tui_check_register_values):
1495         Update.
1496         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1497         member.
1498         (struct tui_data_window) <regs_content>: Now a std::vector.
1499         <regs_content_count>: Remove.
1500         (tui_add_content_elements, tui_free_data_content): Don't declare.
1501         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1502         (init_content_element): Remove DATA_WIN case.  Add assert.
1503         (tui_add_content_elements): Remove.
1504         (tui_data_window): Update.
1505         (tui_free_data_content): Remove.
1506         (free_content_elements): Remove DATA_WIN case.
1507
1508 2019-06-25  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-data.c (tui_data_item_window): Update.
1511         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1512         * tui/tui-windata.c (tui_display_all_data)
1513         (tui_display_data_from_line): Update.
1514         (tui_check_data_values): Remove.
1515         * tui/tui-regs.c (tui_show_register_group)
1516         (tui_display_reg_element_at_line): Update.
1517         * tui/tui-hooks.c (tui_register_changed)
1518         (tui_refresh_frame_and_register_information): Call
1519         tui_check_register_values.
1520         * tui/tui-data.h (struct tui_data_window) <data_content,
1521         data_content_count, data_type>: Remove.
1522         (enum tui_data_type): Remove.
1523
1524         * tui/tui-data.c (tui_data_window::clear_detail)
1525         (~tui_data_window): Update.
1526
1527 2019-06-25  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1530         declare.
1531         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1532         Rename from tui_first_data_item_displayed.  Update.
1533         (tui_data_window::refresh_all)
1534         (tui_data_window::do_scroll_vertical): Update.
1535         * tui/tui-data.h (struct tui_data_window)
1536         <first_data_item_displayed>: Declare new method.
1537
1538 2019-06-25  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1541         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1542         contents...
1543         (tui_initialize_static_data): ...here.
1544
1545 2019-06-25  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1548         (tui_display_registers_from, tui_check_register_values): Update.
1549         (tui_display_register): Remove win_info parameter; update.
1550         (tui_get_register): Change type of parameters.
1551         * tui/tui-data.h (struct tui_data_element): Remove.
1552         (union tui_which_element) <data>: Remove.
1553         <data_window>: Change type.
1554         (struct tui_data_item_window): New.
1555         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1556         case.  Add assert.
1557         (~tui_data_item_window): New destructor.
1558         (free_content_elements): Remove DATA_ITEM_WIN case.
1559
1560 2019-06-25  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1563         Remove.
1564
1565 2019-06-25  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-data.h (struct tui_command_element): Remove.
1568         (union tui_which_element) <command>: Remove.
1569         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1570         assert.
1571         (free_content_elements): Remove CMD_WIN case.
1572
1573 2019-06-25  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-layout.c (tui_set_layout): Update.
1576         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1577         * tui/tui-data.c (layout_def): Update.
1578
1579 2019-06-25  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1582         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1583         (tui_source_window_base::set_new_height): Update.
1584         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1585         Update.
1586         (tui_set_locator_fullname, tui_set_locator_info)
1587         (tui_show_frame_info): Update.
1588         * tui/tui-source.c (tui_set_source_content)
1589         (tui_source_is_displayed): Update.
1590         * tui/tui-layout.c (show_source_disasm_command, show_data)
1591         (show_source_or_disasm_and_command): Update.
1592         * tui/tui-disasm.c (tui_set_disassem_content)
1593         (tui_get_begin_asm_address): Update.
1594         * tui/tui-data.h (struct tui_locator_element): Remove.
1595         (union tui_which_element) <locator>: Remove.
1596         (struct tui_locator_window): New.
1597         (tui_locator_win_info_ptr): Change return type.
1598         * tui/tui-data.c (_locator): Change type.
1599         (tui_locator_win_info_ptr): Change return type.
1600         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1601         (tui_alloc_content): Add assert.
1602
1603 2019-06-25  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-winsource.c
1606         (tui_exec_info_window::maybe_allocate_content): New method.
1607         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1608         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1609         (make_source_or_disasm_window): Add cast.
1610         * tui/tui-data.h (union tui_which_element) <simple_string>:
1611         Remove.
1612         (struct tui_source_info): New.
1613         (struct tui_source_window_base) <execution_info>: Change type.
1614         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1615         case, and add assert.
1616         (tui_alloc_content): Add assert.
1617
1618 2019-06-25  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1621         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1622         * tui/tui-data.c (tui_alloc_win_info): Remove.
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1627         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1628         can_highlight.
1629
1630 2019-06-25  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1633         make_visible_with_new_height method.
1634         (tui_win_info::make_visible_with_new_height): New method.
1635         (tui_source_window_base::do_make_visible_with_new_height)
1636         (tui_data_window::do_make_visible_with_new_height)
1637         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1638         (make_visible_with_new_height): Remove.
1639         (tui_resize_all, tui_adjust_win_heights): Use
1640         make_visible_with_new_height method.
1641         * tui/tui-data.h (struct tui_win_info)
1642         <do_make_visible_with_new_height, make_visible_with_new_height>:
1643         New methods.
1644         (struct tui_source_window_base, struct tui_data_window)
1645         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1646         methods.
1647
1648 2019-06-25  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1651         method.
1652         (update_tab_width): Call update_tab_width method.
1653         * tui/tui-data.h (struct tui_win_info)
1654         (struct tui_source_window_base) <update_tab_width>: New methods.
1655
1656 2019-06-25  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1659         parameter.
1660         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1661         parameter.
1662         (tui_gen_win_info::make_visible): Update.
1663         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1664         parameter.
1665         * tui/tui-data.h (enum tui_box): New enum.
1666         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1667
1668 2019-06-25  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1671         init_and_make_win for EXEC_INFO_WIN.
1672         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1673         longer inline.
1674         (struct tui_win_info) <~tui_win_info>: Inline.
1675         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1676         Don't declare.
1677         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1678         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1679         Remove.
1680         (tui_initialize_static_data): Update.
1681         (~tui_gen_win_info): Handle more cleanup here.
1682         (~tui_source_window_base): Delete "execution_info".
1683         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1684
1685 2019-06-25  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-layout.c (make_command_window): Don't set
1688         can_highlight.
1689         (show_source_disasm_command): Call the reset method.
1690         (show_data): Don't set can_highlight.  Call the reset method.
1691         (tui_gen_win_info::reset): Rename from init_gen_win_info
1692         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1693         (show_source_or_disasm_and_command): Call the reset method.
1694         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1695         (struct tui_cmd_window): Set can_highlight.
1696
1697 2019-06-25  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1700         from make_visible.
1701         (tui_make_visible, tui_make_invisible): Rewrite.
1702         (tui_win_info::make_visible): Remove.
1703         (tui_source_window_base::make_visible): Update.
1704         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1705         method.  Moved from...
1706         (struct tui_win_info) <make_visible>: ...here.
1707
1708 2019-06-25  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-winsource.c
1711         (tui_source_window_base::do_scroll_horizontal): Remove direction
1712         parameter.
1713         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1714         direction parameter.
1715         * tui/tui-win.c (tui_win_info::forward_scroll)
1716         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1717         (tui_win_info::right_scroll): Update.
1718         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1719         direction parameter.
1720         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1721         direction parameter.
1722         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1723         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1724         Remove direction parameter.
1725         (struct tui_source_window_base, struct tui_source_window)
1726         (struct tui_disasm_window, struct tui_data_window)
1727         (struct tui_cmd_window): Update.
1728
1729 2019-06-25  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-winsource.h (tui_set_exec_info_content)
1732         (tui_show_exec_info_content, tui_erase_exec_info_content)
1733         (tui_clear_exec_info_content, tui_update_exec_info): Change
1734         argument to tui_source_window_base.
1735         * tui/tui-winsource.c (tui_set_exec_info_content)
1736         (tui_show_exec_info_content, tui_erase_exec_info_content)
1737         (tui_clear_exec_info_content, tui_update_exec_info): Change
1738         argument to tui_source_window_base.
1739
1740 2019-06-25  Tom Tromey  <tom@tromey.com>
1741
1742         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1743         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1744
1745 2019-06-25  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1748         check.
1749
1750 2019-06-25  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1753         type to void.
1754         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1755         type to void.
1756         * tui/tui-source.c (tui_set_source_content): Update.
1757         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1758
1759 2019-06-25  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-win.c (window_name_completer, tui_set_focus)
1762         (tui_all_windows_info): Use name method.
1763         * tui/tui-data.h (struct tui_gen_win_info)
1764         (struct tui_source_window, struct tui_disasm_window)
1765         (struct tui_data_window, struct tui_cmd_window) <name>: New
1766         method.
1767         (tui_win_name): Don't declare.
1768         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1769         (tui_win_name): Remove.
1770
1771 2019-06-25  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-winsource.h (tui_update_source_window)
1774         (tui_update_source_window_as_is): Change parameter type.
1775         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1776         to be a tui_source_window_base.
1777         (tui_update_source_window_as_is): Likewise.
1778         * tui/tui-win.c (make_visible_with_new_height): Update.
1779
1780 2019-06-25  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-winsource.c (tui_erase_source_content)
1783         (tui_show_source_content, tui_show_exec_info_content)
1784         (tui_erase_exec_info_content): Use refresh_window method.
1785         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1786         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1787         from tui_refresh_win.
1788         (tui_data_window::refresh_window): New method.
1789         (tui_win_info::refresh, tui_source_window_base::refresh)
1790         (tui_refresh_all): Use refresh_window method.
1791         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1792         method.
1793         * tui/tui-regs.c (tui_display_register): Call refresh_window
1794         method.
1795         * tui/tui-layout.c (show_source_disasm_command)
1796         (show_source_or_disasm_and_command): Call refresh_window method.
1797         * tui/tui-data.h (struct tui_gen_win_info)
1798         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1799         New method.
1800
1801 2019-06-25  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui.c (tui_rl_other_window, tui_enable)
1804         (tui_is_window_visible, tui_get_command_dimension): Update.
1805         * tui/tui-winsource.c (tui_update_source_window_as_is)
1806         (tui_clear_source_content, tui_erase_source_content)
1807         (tui_show_source_line, tui_source_window_base::refill)
1808         (tui_source_window_base::do_scroll_horizontal)
1809         (tui_source_window_base::set_is_exec_point_at)
1810         (tui_update_breakpoint_info, tui_set_exec_info_content)
1811         (tui_alloc_source_buffer, tui_line_is_displayed)
1812         (tui_addr_is_displayed): Update.
1813         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1814         (tui_check_and_display_highlight_if_needed)
1815         (tui_win_info::make_visible, tui_win_info::refresh)
1816         (tui_refresh_all): Update.
1817         * tui/tui-windata.c (tui_first_data_item_displayed)
1818         (tui_delete_data_content_windows, tui_erase_data_content)
1819         (tui_display_all_data, tui_data_window::refresh_all)
1820         (tui_check_data_values): Update.
1821         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1822         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1823         (tui_win_info::backward_scroll, tui_refresh_all_win)
1824         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1825         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1826         (tui_source_window_base::set_new_height)
1827         (tui_data_window::set_new_height)
1828         (make_invisible_and_set_new_height)
1829         (make_visible_with_new_height, new_height_ok)
1830         (parse_scrolling_args): Update.
1831         * tui/tui-stack.c (tui_show_frame_info): Update.
1832         * tui/tui-source.c (tui_set_source_content)
1833         (tui_set_source_content_nil, tui_source_is_displayed)
1834         (tui_source_window::do_scroll_vertical): Update.
1835         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1836         (tui_display_registers_from, tui_display_reg_element_at_line)
1837         (tui_check_register_values, tui_reg_command): Update.
1838         * tui/tui-layout.c (tui_default_win_height)
1839         (show_source_disasm_command, show_data, init_and_make_win)
1840         (show_source_or_disasm_and_command): Update.
1841         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1842         (tui_redisplay_readline, tui_mld_flush)
1843         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1844         (tui_getc): Update.
1845         * tui/tui-disasm.c (tui_set_disassem_content)
1846         (tui_disasm_window::do_scroll_vertical): Update.
1847         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1848         Now virtual.
1849         (struct tui_win_info): Derive from tui_gen_win_info.
1850         <~tui_win_info>: Mark as override.
1851         <generic>: Remove member.
1852         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1853         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1854         (~tui_data_window, ~tui_win_info)
1855         (tui_free_all_source_wins_content): Update.
1856         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1857
1858 2019-06-25  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-layout.c (init_and_make_win): Use new.
1861         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1862         destructor, initializers.
1863         (tui_alloc_generic_win_info): Don't declare.
1864         * tui/tui-data.c (_locator): Add argument to constructor.
1865         (source_win, disasm_win): New globals.
1866         (exec_info): Remove.
1867         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1868         Update.
1869         (tui_alloc_generic_win_info): Remove.
1870         (init_content_element): Use new.
1871         (tui_win_info::tui_win_info): Update.
1872         (free_content_elements) <case DATA_WIN>: Use delete.
1873
1874 2019-06-25  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1877         * tui/tui-windata.c (tui_first_data_item_displayed)
1878         (tui_delete_data_content_windows): Update.
1879         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1880         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1881         (tui_display_registers_from, tui_check_register_values): Update.
1882         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1883         pointer.
1884         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1885         window.
1886         (tui_free_data_content): Update.
1887         (free_content_elements) <case DATA_WIN>: Free the window.
1888
1889 2019-06-25  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1892         Update.
1893         * tui/tui-layout.c (make_command_window)
1894         (show_source_disasm_command, show_data, init_and_make_win)
1895         (show_source_or_disasm_and_command): Update.
1896         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1897         method.
1898         <can_highight, is_highlighted>: Now bool.
1899         (tui_set_win_highlight): Don't declare.
1900         * tui/tui-data.c (tui_set_win_highlight): Remove.
1901
1902 2019-06-25  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-wingeneral.c (make_visible): Remove check of window
1905         type.
1906
1907 2019-06-25  Tom Tromey  <tom@tromey.com>
1908
1909         * tui/tui-win.c (tui_win_info::max_height)
1910         (tui_cmd_window::max_height): New methods.
1911         (new_height_ok): Call max_height.
1912         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1913         <max_height>: New method.
1914
1915 2019-06-25  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-win.c (tui_source_window_base::set_new_height)
1918         (tui_data_window::set_new_height): New methods.
1919         (make_invisible_and_set_new_height): Call set_new_height method.
1920         * tui/tui-data.h (struct tui_win_info)
1921         (struct tui_source_window_base, struct tui_data_window)
1922         <set_new_height>: New method.
1923
1924 2019-06-25  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1927         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1928         tui_refresh_data_win.
1929         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1930         method.
1931         (tui_refresh_all_win): Call the refresh_all method.
1932         (tui_set_focus): Likewise.
1933         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1934         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1935         Likewise.
1936
1937 2019-06-25  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-winsource.h (tui_refill_source_window)
1940         (tui_set_is_exec_point_at): Don't declare.
1941         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1942         (tui_source_window_base::refill): Rename from
1943         tui_refill_source_window.
1944         (tui_source_window_base::do_scroll_horizontal): Update.
1945         (tui_source_window_base::set_is_exec_point_at): Rename from
1946         tui_set_is_exec_point_at.
1947         (tui_update_all_breakpoint_info): Update.
1948         * tui/tui-stack.c (tui_show_frame_info): Update.
1949         * tui/tui-layout.c (show_data): Add cast.
1950         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1951         * tui/tui-data.h (struct tui_source_window_base) <refill,
1952         set_is_exec_point_at>: New methods.
1953         (tui_source_windows, tui_add_to_source_windows): Update types.
1954         (tui_add_to_source_windows): Remove redundant declaration.
1955         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1956         (tui_source_windows): Change return type.
1957         (tui_clear_source_windows_detail): Update.
1958         (tui_add_to_source_windows): Change type of parameter.
1959         (tui_free_all_source_wins_content): Update.
1960
1961 2019-06-25  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-wingeneral.c (tui_win_info::refresh)
1964         (tui_source_window_base::refresh): New methods.
1965         (tui_refresh_all): Call the refresh method.
1966         * tui/tui-data.h (struct tui_win_info)
1967         (struct tui_source_window_base) <refresh>: New method.
1968
1969 2019-06-25  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui.h (tui_is_window_visible): Return bool.
1972         * tui/tui.c (tui_is_window_visible): Return bool.
1973         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1974         (tui_make_visible, tui_make_invisible)
1975         (tui_win_info::make_visible)
1976         (tui_source_window_base::make_visible, make_all_visible)
1977         (tui_make_all_visible, tui_make_all_invisible): Update.
1978         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1979         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1980         bool.
1981         (struct tui_win_info, struct tui_source_window_base)
1982         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1983         * tui/tui-data.c (tui_init_generic_part): Update.
1984
1985 2019-06-25  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1988         (tui_source_window_base::make_visible): New methods.
1989         (make_all_visible): Make method call.
1990         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1991         (struct tui_source_window_base, struct tui_cmd_window): Override
1992         make_visible.
1993         (tui_win_is_source_type): Don't declare.
1994         * tui/tui-data.c (tui_win_is_source_type): Remove.
1995
1996 2019-06-25  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1999         NULL check.
2000
2001 2019-06-25  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2004         Inline constructor.  Add initializers for members.
2005         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2006         constructors; now inline in class.
2007
2008 2019-06-25  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-regs.c (tui_show_registers): Update.
2011         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2012         bool.
2013         * tui/tui-data.c (tui_data_window::clear_detail)
2014         (tui_data_window): Update.
2015
2016 2019-06-25  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-windata.c (tui_display_all_data)
2019         (tui_display_data_from_line, tui_display_data_from)
2020         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2021         Update.
2022         * tui/tui-regs.c (tui_last_regs_line_no)
2023         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2024         (tui_show_registers, tui_show_register_group)
2025         (tui_display_registers_from, tui_display_reg_element_at_line)
2026         (tui_display_registers_from_line, tui_check_register_values)
2027         (tui_reg_next, tui_reg_prev): Update.
2028         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2029         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2030         tui_data_window.
2031         (struct tui_win_info) <detail>: Remove.  Add new fields from
2032         tui_data_info.
2033         (TUI_DATA_WIN): Add cast.
2034         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2035         (~tui_data_window): Simplify.
2036
2037 2019-06-25  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-layout.c (show_source_disasm_command)
2040         (show_source_or_disasm_and_command): Update.
2041         * tui/tui-io.c (update_cmdwin_start_line)
2042         (tui_redisplay_readline): Update.
2043         * tui/tui-data.h (struct tui_command_info): Remove.
2044         (struct tui_win_info) <detail>: Remove command_info member.
2045         (struct tui_data_window) <start_line>: New member, from
2046         tui_command_info.
2047         (TUI_CMD_WIN): Add casts.
2048
2049 2019-06-25  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-winsource.c (tui_update_source_window)
2052         (tui_refill_source_window)
2053         (tui_source_window_base::do_scroll_horizontal)
2054         (tui_update_breakpoint_info, tui_set_exec_info_content)
2055         (tui_show_exec_info_content, tui_erase_exec_info_content)
2056         (tui_clear_exec_info_content): Update.
2057         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2058         Update.
2059         * tui/tui-win.c (make_invisible_and_set_new_height)
2060         (make_visible_with_new_height): Update.
2061         * tui/tui-source.c (tui_set_source_content)
2062         (tui_show_symtab_source): Update.
2063         * tui/tui-layout.c (extract_display_start_addr)
2064         (show_source_disasm_command, show_data)
2065         (make_source_or_disasm_window)
2066         (show_source_or_disasm_and_command): Update.
2067         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2068         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2069         "gdbarch".
2070         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2071         to tui_source_window_base.
2072         (struct tui_win_info) <detail>: Remove source_info member.
2073         (struct tui_source_window_base) <has_locator>: Inline.
2074         Move contents from tui_source_info; rename has_locator member to
2075         m_has_locator.
2076         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2077         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2078         header file.
2079         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2080         Simplify.
2081         (tui_free_all_source_wins_content): Cast to
2082         tui_source_window_base.
2083
2084 2019-06-25  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-win.c (make_invisible_and_set_new_height)
2087         (make_visible_with_new_height): Call has_locator method.
2088         * tui/tui-layout.c (show_source_disasm_command, show_data)
2089         (show_source_or_disasm_and_command): Update for bool change.
2090         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2091         (tui_win_info) <has_locator>: New method.
2092         (struct tui_source_window_base) <has_locator>: New method.
2093         (tui_win_has_locator): Don't declare.
2094         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2095         from tui_win_has_locator.
2096         (tui_source_window_base): Use false, not FALSE.
2097
2098 2019-06-25  Tom Tromey  <tom@tromey.com>
2099
2100         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2101         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2102         clear_detail method directly.
2103         (tui_clear_win_detail): Remove.
2104
2105 2019-06-25  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2108         "this", not TUI_DISASM_WIN.
2109
2110 2019-06-25  Tom Tromey  <tom@tromey.com>
2111
2112         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2113         declare.
2114         * tui/tui-winsource.c
2115         (tui_source_window_base::do_scroll_horizontal): Rename from
2116         tui_horizontal_source_scroll.
2117         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2118         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2119         from tui_vertical_data_scroll.
2120         * tui/tui-win.h (tui_scroll): Don't declare.
2121         * tui/tui-win.c (tui_win_info::forward_scroll)
2122         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2123         (tui_win_info::right_scroll): Rename and update.
2124         (tui_scroll_forward_command, tui_scroll_backward_command)
2125         (tui_scroll_left_command, tui_scroll_right_command): Update.
2126         (tui_scroll): Remove.
2127         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2128         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2129         from tui_vertical_source_scroll.
2130         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2131         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2132         from tui_vertical_disassem_scroll.
2133         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2134         do_scroll_horizontal>: New methods.
2135         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2136         Likewise.
2137         (struct tui_source_window_base): Add do_scroll_horizontal.
2138         (struct tui_source_window, struct tui_disasm_window): Add
2139         do_scroll_vertical.
2140         (struct tui_data_window, struct tui_cmd_window): Add
2141         do_scroll_horizontal and do_scroll_vertical.
2142         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2143
2144 2019-06-25  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-data.h (struct tui_source_window_base): New struct.
2147         (struct tui_source_window): Derive from tui_source_window_base.
2148         (struct tui_disasm_window): New struct.
2149         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2150         from tui_source_window::clear_detail.
2151         (tui_source_window_base): Rename from tui_source_window.
2152         (~tui_source_window_base): Rename from ~tui_source_window.
2153         (tui_alloc_win_info): Create a tui_disasm_window.
2154
2155 2019-06-25  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-data.h (struct tui_source_window)
2158         (struct tui_data_window): Declare destructors.
2159         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2160         destructors.
2161         (tui_win_info): Simplify.
2162
2163 2019-06-25  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-winsource.c (tui_display_main)
2166         (tui_update_source_windows_with_addr)
2167         (tui_update_all_breakpoint_info): Update.
2168         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2169         (new_height_ok, parse_scrolling_args): Update.
2170         * tui/tui-stack.c (tui_show_frame_info): Update.
2171         * tui/tui-data.h (struct tui_list): Remove.
2172         (tui_source_windows): Return a reference to a std::vector.
2173         * tui/tui-data.c (source_windows): Now a std::vector.
2174         (tui_source_windows): Change return type.
2175         (tui_clear_source_windows): Rewrite.
2176         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2177         (tui_free_all_source_wins_content): Rewrite.
2178
2179 2019-06-25  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2182         (struct tui_data_window, struct tui_cmd_window): Declare
2183         clear_detail method.
2184         * tui/tui-data.c (tui_source_window::clear_detail)
2185         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2186         methods.
2187         (tui_clear_win_detail): Simplify.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui-layout.c (make_source_window, make_disasm_window)
2192         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2193         Return the new window.
2194         (show_source_disasm_command, show_data)
2195         (show_source_or_disasm_and_command): Update.
2196
2197 2019-06-25  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2200         parameter.  Return the new window.
2201         (show_source_disasm_command): Update and remove NULL check.
2202         (show_source_or_disasm_and_command): Update.
2203
2204 2019-06-25  Tom Tromey  <tom@tromey.com>
2205
2206         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2207
2208 2019-06-25  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-data.h (struct tui_win_info): Make constructor
2211         protected.  Make destructor virtual.  Add initializers.
2212         (tui_source_window, tui_data_window, tui_cmd_window): New
2213         classes.
2214         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2215         constructor.  Add "type" parameter.
2216         (tui_source_window, tui_data_window, tui_cmd_window): New
2217         constructors.
2218         (tui_alloc_win_info): Instantiate the appropriate subclass.
2219
2220 2019-06-25  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-win.c (tui_resize_all): Use delete.
2223         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2224         destructor.
2225         (tui_free_window): Don't declare.
2226         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2227         Update.
2228
2229 2019-06-25  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-data.h (struct tui_win_info): Add constructor.
2232         * tui/tui-data.c (tui_alloc_win_info): Use new.
2233         (tui_free_window): Use delete.
2234
2235 2019-06-22  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2238         declare.
2239         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2240
2241 2019-06-22  Tom Tromey  <tom@tromey.com>
2242
2243         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2244         declare.
2245         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2246
2247 2019-06-22  Tom de Vries  <tdevries@suse.de>
2248
2249         * dwarf2read.c (create_addrmap_from_aranges)
2250         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2251         instead of '%zu'.
2252
2253 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2254
2255         * dwarf2read.h (dwarf2_section_info_def): Remove.
2256         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2257         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2258         std::vector<dwarf2_section_info>.
2259         (struct dwo_file) <~dwo_file>: Remove.
2260         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2261         types field.
2262         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2263         (dwarf2_read_debug_names): Likewise.
2264         (create_debug_types_hash_table): Change parameter type to
2265         array_view, adjust code accordingly.
2266         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2267         (partial_die_info::fixup): Likewise.
2268         (determine_prefix): Likewise.
2269         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2270
2271 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2272
2273         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2274         gdb_bfd_ref_ptr.
2275         <~dwo_file>: Remove call to gdb_bfd_unref.
2276         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2277         gdb_bfd_ref_ptr::get.
2278
2279 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2280
2281         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2282         type to htab_up.
2283         * dwarf2read.c (struct dwo_file): Initialize fields.
2284         <~dwo_file>: New.
2285         (free_dwo_file): Remove, move content to ~dwo_file.
2286         (struct dwo_file_deleter): Remove.
2287         (dwo_file_up>: Remove custom deleter.
2288         (free_dwo_files): Remove.
2289         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2290         dwo_files.
2291         (process_skeletonless_type_units): Call unique_ptr::get.
2292         (allocate_dwo_file_hash_table): Add deleter to created hash
2293         table.  Change return type to htab_up.
2294         (lookup_dwo_file_slot): Don't memset dwo_file, call
2295         unique_ptr::get.
2296         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2297         (create_dwo_unit_in_dwp_v2): Likewise.
2298         (open_and_init_dwo_file): Likewise.
2299         (free_dwo_file_from_slot): Remove.
2300
2301 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2302
2303         * dwarf2read.h (struct dwarf2_section_info) <readin,
2304         is_virtual>: Change type to bool.
2305         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2306         true instead of 1.
2307
2308 2019-06-19  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-data.h (tui_init_content_element): Don't declare.
2311
2312 2019-06-19  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui-data.h (tui_init_win_info): Don't declare.
2315
2316 2019-06-19  Tom de Vries  <tdevries@suse.de>
2317
2318         * dwarf2read.h (abstract_to_concrete): Change type to
2319         std::unordered_map<sect_offset, std::vector<sect_offset>,
2320         gdb::hash_enum<sect_offset>>.
2321
2322 2019-06-19  Tom Tromey  <tromey@adacore.com>
2323
2324         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2325         EVAL_AVOID_SIDE_EFFECTS specially.
2326
2327 2019-06-19  Tom Tromey  <tromey@adacore.com>
2328
2329         * source-cache.c (highlighter): New global.
2330         (source_cache::get_source_lines): Create a highlighter on demand.
2331
2332 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2333
2334         * defs.h (deprecated_interactive_hook): Delete declaration.
2335         * interps.c (clear_interpreter_hooks): Remove use of
2336         deprecated_interactive_hook.
2337         * top.c (deprecated_interactive_hook): Delete definition.
2338         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2339
2340 2019-06-18  Tom de Vries  <tdevries@suse.de>
2341
2342         PR gdb/24515
2343         * dwarf2read.h (abstract_to_concrete): Change type from
2344         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2345         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2346         * dwarf2read.c (read_variable): Update.
2347         (dwarf2_fetch_die_loc_sect_off): Update.
2348
2349 2019-06-17  Tom de Vries  <tdevries@suse.de>
2350
2351         PR gdb/24617
2352         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2353         accessing parent[parent_len - 1].
2354
2355 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2356
2357         PR gdb/24364
2358         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2359         call dtrace_process_dof with NULL dof.
2360
2361 2019-06-16  Tom de Vries  <tdevries@suse.de>
2362
2363         PR gdb/24445
2364         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2365
2366 2019-06-16  Tom Tromey  <tom@tromey.com>
2367
2368         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2369         (make_all_visible): Use address of member.
2370
2371 2019-06-16  Tom Tromey  <tom@tromey.com>
2372
2373         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2374         (tui_free_window, free_content, free_content_elements): Remove
2375         unnecessary cast.
2376         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2377         cast.
2378         * tui/tui-regs.c (tui_show_register_group)
2379         (tui_display_registers_from, tui_display_reg_element_at_line):
2380         Remove unnecessary cast.
2381
2382 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * linux-nat.c (normal_mask): Delete.
2385         (_initialize_linux_nat): Don't initialise normal_mask.
2386
2387 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2388
2389         PR gdb/24445
2390         * dwarf-index-write.h (write_psymtabs_to_index): Add
2391         dwz_basename parameter.
2392         * dwarf-index-write.c (write_gdbindex): Move file writing to
2393         write_gdbindex_1.  Change return type void.
2394         (assert_file_size): Move up, remove filename parameter.
2395         (write_gdbindex_1): New function.
2396         (write_debug_names): Change return type to void, call
2397         assert_file_size.
2398         (struct index_wip_file): New struct.
2399         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2400         file logic to index_wip_file.  Write index for dwz file if
2401         needed.
2402         (save_gdb_index_command): Pass basename of dwz file, if present.
2403         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2404         build-id of dwz file, if present.
2405         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2406         (dwarf2_get_dwz_file): Likewise.
2407         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2408         (dwarf2_get_dwz_file): Likewise.
2409
2410 2019-06-16  Tom Tromey  <tom@tromey.com>
2411
2412         * coffread.c (process_coff_symbol): Use xstrdup.
2413         * value.c (create_internalvar): Use xstrdup.
2414
2415 2019-06-16  Tom Tromey  <tom@tromey.com>
2416
2417         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2418         * breakpoint.c (stopin_command, stopat_command)
2419         (until_break_command, decode_location_default): Remove unnecessary
2420         cast.
2421         * utils.c (subset_compare): Remove unnecessary cast.
2422         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2423         cast.
2424         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2425         cast.
2426         * infcmd.c (path_command): Remove unnecessary cast.
2427         * coffread.c (decode_type): Remove unnecessary cast.
2428         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2429         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2430         * tui/tui-stack.c (tui_show_locator_content)
2431         (tui_show_frame_info): Remove unnecessary cast.
2432         * tui/tui-win.c (tui_scroll_forward_command)
2433         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2434         (parse_scrolling_args): Remove unnecessary cast.
2435         * tui/tui-data.c (init_win_info, tui_del_window)
2436         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2437         (free_content_elements): Remove unnecessary cast.
2438         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2439         unnecessary cast.
2440         * tui/tui-source.c (tui_set_source_content)
2441         (tui_vertical_source_scroll): Remove unnecessary cast.
2442         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2443         cast.
2444         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2445         * tui/tui-regs.c (tui_display_registers_from)
2446         (tui_display_register): Remove unnecessary cast.
2447         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2448         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2449         (make_visible): Remove unnecessary cast.
2450         * tui/tui-winsource.c (tui_erase_source_content)
2451         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2452         unnecessary cast.
2453         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2454         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2455         * stabsread.c (read_type, read_array_type, read_range_type):
2456         Remove unnecessary cast.
2457         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2458         (parse_symbol, parse_type, upgrade_type, parse_external)
2459         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2460         unnecessary cast.
2461         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2462
2463 2019-06-16  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-data.c (tui_alloc_generic_win_info)
2466         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2467         checks.
2468
2469 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2470             Andrew Burgess  <andrew.burgess@embecosm.com>
2471
2472         * f-typeprint.c (f_print_type): Don't return early for not
2473         associated or not allocated types.
2474         (f_type_print_varspec_suffix): Add print_rank parameter and print
2475         ranks of array types in case they dangling.
2476         (f_type_print_base): Add print_rank parameter.
2477
2478 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2479
2480         * NEWS: Mention new MI commands.
2481         * break-catch-throw.c (enum exception_event_kind): Move to
2482         breakpoint.h.
2483         (print_mention_exception_catchpoint): Output text as a single
2484         message.
2485         (catch_exception_command_1): Rename to...
2486         (catch_exception_event): ...this, make non-static, update header
2487         command, and change some parameter types.
2488         (catch_catch_command): Update for changes to
2489         catch_exception_command_1.
2490         (catch_throw_command): Likewise.
2491         (catch_rethrow_command): Likewise.
2492         * breakpoint.c (enum exception_event_kind): Delete.
2493         * breakpoint.h (enum exception_event_kind): Moved here from
2494         break-catch-throw.c.
2495         (catch_exception_event): Declare.
2496         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2497         (mi_cmd_catch_throw): New function.
2498         (mi_cmd_catch_rethrow): New function.
2499         (mi_cmd_catch_catch): New function.
2500         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2501         'catch-catch' entries.
2502         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2503         (mi_cmd_catch_rethrow): Declare.
2504         (mi_cmd_catch_catch): Declare.
2505
2506 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2507
2508         * annotate.c (annotate_source_line): Change return type to void,
2509         update implementation to match.
2510         * annotate.h (annotate_source_line): Change return type to void,
2511         update header comment.
2512         * stack.c (print_frame_info): Don't change what frame information
2513         is printed based on whether annotations are on or not.
2514
2515 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2516
2517         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2518         (annotate_source): Make static.
2519         (annotate_source_line): Moved from source.c and renamed from
2520         identify_source_line.  Update the return type.
2521         * annotate.h (annotate_source): Delete declaration.
2522         (annotate_source_line): Declaration moved from source.h, and
2523         renamed from identify_source_line.  Return type updated.
2524         * source.c (identify_source_line): Moved to annotate.c and renamed
2525         to annotate_source_line.
2526         (info_line_command): Remove check of annotation_level.
2527         * source.h (identify_source_line): Move declaration to annotate.h
2528         and rename to annotate_source_line.
2529         * stack.c: Add 'annotate.h' include.
2530         (print_frame_info): Remove check of annotation_level before
2531         calling annotate_source_line.
2532
2533 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2534
2535         * source-cache.c (source_cache::get_plain_source_lines): Use
2536         open_source_file_with_line_charpos instead of just
2537         open_source_file, remove call to find_source_lines.
2538         (source_cache::get_source_lines): Likewise.
2539         * source.c (find_source_lines): Make static.
2540         (get_filename_and_charpos): Renamed into...
2541         (open_source_file_with_line_charpos): ..this along with changes to
2542         return a scoped_fd, and some other minor clean ups.
2543         (identify_source_line): Use open_source_file_with_line_charpos.
2544         (search_command_helper): Use open_source_file_with_line_charpos
2545         instead of just open_source_file, remove call to
2546         find_source_lines.
2547         * source.h (open_source_file_with_line_charpos): Declare new
2548         function.
2549         (find_source_lines): Delete declaration.
2550
2551 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2552
2553         * source.c (get_filename_and_charpos): Remove fullname
2554         parameter.
2555         (identify_source_line): Update call to get_filename_and_charpos.
2556
2557 2019-06-14  Tom Tromey  <tromey@adacore.com>
2558
2559         PR gdb/24502:
2560         * ui-style.h (skip_ansi_escape): Update comment.
2561         * ui-file.h (class no_terminal_escape_file): New class.
2562         * ui-file.c (no_terminal_escape_file::write)
2563         (no_terminal_escape_file::puts): New methods.
2564         * cli/cli-logging.c (handle_redirections): Use
2565         no_terminal_escape_file.
2566
2567 2019-06-14  Tom Tromey  <tromey@adacore.com>
2568
2569         * NEWS: Move convenience variable news above Python news.
2570
2571 2019-06-14  Tom Tromey  <tom@tromey.com>
2572
2573         * gnulib: Move directory to top-level.
2574         * configure.ac: Don't configure gnulib.
2575         * configure: Rebuild.
2576         * common/common-defs.h: Use new path to gnulib.
2577         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2578         (GNULIB_H): Remove.
2579         (INCGNU): Look in new gnulib location.
2580         (HFILES_NO_SRCDIR): Remove gnulib files.
2581         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2582         (generated_files): Remove GNULIB_H.
2583         ($(LIBGNU), all-lib): Remove targets.
2584         (distclean): Don't mention GNULIB_BUILDDIR.
2585         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2586
2587 2019-06-14  Tom Tromey  <tromey@adacore.com>
2588
2589         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2590         Warn if symbol file does not provide any symbols.
2591
2592 2019-06-14  Tom Tromey  <tromey@adacore.com>
2593
2594         * source.c (find_and_open_source): Respect basenames_may_differ.
2595
2596 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2597
2598         * annotate.c (annotate_breakpoints_invalid): Make use of
2599         scoped_restore_terminal_state.
2600         (annotate_frames_invalid): Likewise.
2601
2602 2019-06-14  Tom Tromey  <tromey@adacore.com>
2603
2604         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2605         allow assignment to an internalvar.
2606
2607 2019-06-14  Tom Tromey  <tromey@adacore.com>
2608
2609         * ada-lex.l: Allow "_" in attribute names.
2610
2611 2019-06-14  Tom Tromey  <tromey@adacore.com>
2612
2613         PR gdb/24653:
2614         * regcache.c (registers_changed): Don't call alloca.
2615         * top.c (execute_command): Don't call alloca.
2616
2617 2019-06-13  Pedro Alves  <palves@redhat.com>
2618
2619         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2620         'expression'.  When parsing an expression, error out if there's
2621         junk after "unlimited".
2622         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2623         (do_set_command): Adjust calls to is_unlimited_literal.
2624
2625 2019-06-13  Pedro Alves  <palves@redhat.com>
2626
2627         * compile/compile.c (make_compile_options_def_group): Add braces
2628         around array_view initializer.
2629         * thread.c (make_thread_apply_all_options_def_group)
2630         (make_thread_apply_all_options_def_group): Likewise.
2631
2632 2019-06-13  Pedro Alves  <palves@redhat.com>
2633
2634         * NEWS (New commands): Mention "maint test-options
2635         require-delimiter", "maint test-options unknown-is-error", "maint
2636         test-options unknown-is-operand" and "maint show
2637         test-options-completion-result".
2638         (New command options, command completion): New section.
2639         (Completion improvements): New section.
2640         Mention that you can abbreviate "unlimited".
2641
2642 2019-06-13  Pedro Alves  <palves@redhat.com>
2643
2644         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2645         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2646         * unittests/cli-utils-selftests.c (test_parse_flags)
2647         (test_parse_flags_qcs): Delete.
2648         (test_cli_utils): Don't call deleted functions.
2649
2650 2019-06-13  Pedro Alves  <palves@redhat.com>
2651
2652         * thread.c: Include "cli/cli-option.h".
2653         (tp_array_compar_ascending): Global.
2654         (tp_array_compar): Delete function.
2655         (tp_array_compar_ascending, tp_array_compar_descending): New
2656         functions.
2657         (ascending_option_def, qcs_flag_option_def)
2658         (thr_qcs_flags_option_defs)
2659         (make_thread_apply_all_options_def_group)
2660         (make_thread_apply_options_def_group): New.
2661         (thread_apply_all_command): Use gdb::option::process_options.
2662         (thread_apply_command_completer)
2663         (thread_apply_all_command_completer): New.
2664         (thread_apply_command): Use gdb::option::process_options.
2665         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2666         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2667         to generate help text of "thread apply".  Adjust "taas"'s help.
2668         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2669         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2670
2671 2019-06-13  Pedro Alves  <palves@redhat.com>
2672
2673         * thread.c (thread_apply_command): Check for invalid TID with
2674         isdigit instead of !isalpha.
2675
2676 2019-06-13  Pedro Alves  <palves@redhat.com>
2677
2678         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2679         (validate_flags_qcs): New.
2680         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2681         (validate_flags_qcs): Declare.
2682         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2683         (make_frame_apply_options_def_group): New.
2684         (frame_apply_command_count): Process options with
2685         gdb::option::process_options.
2686         (frame_apply_completer): New.
2687         (frame_apply_level_completer, frame_apply_all_completer)
2688         (frame_apply_completer): New.
2689         (_initialize_stack): Update help of "frame apply", "frame apply
2690         level", "frame apply all" and "faas" to mention supported options
2691         and install command completers.
2692         * stack.h (frame_apply_all_completer): Declare.
2693         * thread.c: Include "stack.h".
2694         (tfaas_command): Add "--".
2695         (_initialize_thread): Update help "tfaas" to mention supported
2696         options and install command completer.
2697
2698 2019-06-13  Pedro Alves  <palves@redhat.com>
2699
2700         * completer.c (complete_nested_command_line): New.
2701         (gdb_completion_word_break_characters_throw): Add assertion.
2702         * completer.h (complete_nested_command_line): Declare.
2703
2704 2019-06-13  Pedro Alves  <palves@redhat.com>
2705
2706         * stack.c (parse_backtrace_qualifiers): New.
2707         (backtrace_command): Use it.
2708         (backtrace_command_completer): Complete on qualifiers.
2709
2710 2019-06-13  Pedro Alves  <palves@redhat.com>
2711
2712         * frame.c: Include "cli/cli-option.h.
2713         (user_set_backtrace_options): New.
2714         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2715         Delete.
2716         (get_prev_frame): Adjust.
2717         (boolean_option_def, uinteger_option_def)
2718         (set_backtrace_option_defs): New.
2719         (_initialize_frame): Adjust and use
2720         gdb::option::add_setshow_cmds_for_options to install "set
2721         backtrace past-main" and "set backtrace past-entry".
2722         * frame.h: Include "cli/cli-option.h".
2723         (struct frame_print_options): Forward declare.
2724         (print_frame_arguments_all, print_frame_arguments_scalars)
2725         (print_frame_arguments_none): Declare.
2726         (print_entry_values): Delete declaration.
2727         (struct frame_print_options, user_frame_print_options): New.
2728         (struct set_backtrace_options): New.
2729         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2730         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2731         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2732         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2733         (list_args_or_locals): Add frame_print_options parameter.
2734         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2735         * python/py-framefilter.c (enumerate_args): Pass down
2736         USER_FRAME_PRINT_OPTIONS.
2737         * stack.c: Include "cli/cli-option.h".
2738         (print_frame_arguments_all, print_frame_arguments_scalars)
2739         (print_frame_arguments_none): Declare.
2740         (print_raw_frame_arguments, print_entry_values): Delete.
2741         (user_frame_print_options): New.
2742         (boolean_option_def, enum_option_def, frame_print_option_defs):
2743         New.
2744         (struct backtrace_cmd_options): New.
2745         (bt_flag_option_def): New.
2746         (backtrace_command_option_defs): New.
2747         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2748         (print_frame_arg, read_frame_arg, print_frame_args)
2749         (print_frame_info, print_frame): Add frame_print_options parameter
2750         and use it.
2751         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2752         (backtrace_command_1): Add frame_print_options and
2753         backtrace_cmd_options parameters and use them.
2754         (make_backtrace_options_def_group): New.
2755         (backtrace_command): Process command options with
2756         gdb::option::process_options.
2757         (backtrace_command_completer): New.
2758         (_initialize_stack): Extend "backtrace"'s help to mention
2759         supported options.  Install completer for "backtrace".
2760         Install some settings commands with add_setshow_cmds_for_options.
2761
2762 2019-06-13  Pedro Alves  <palves@redhat.com>
2763
2764         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2765         and that "set/show print raw frame-arguments" are now deprecated.
2766
2767         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2768         command.
2769         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2770         * stack.c (_initialize_stack): Install "set/show print
2771         raw-frame-arguments", and deprecate "set/show print raw
2772         frame-arguments".
2773         * valprint.c (_initialize_valprint): Deprecate "set/show print
2774         raw".
2775
2776 2019-06-13  Pedro Alves  <palves@redhat.com>
2777
2778         * compile/compile.c (struct compile_options): New.
2779         (compile_flag_option_def, compile_command_option_defs)
2780         (make_compile_options_def_group): New.
2781         (compile_file_command): Handle options with
2782         gdb::option::process_options.
2783         (compile_file_command_completer): New function.
2784         (compile_code_command): Handle options with
2785         gdb::option::process_options.
2786         (compile_code_command_completer): New function.
2787         (_initialize_compiler): Install completers for "compile code" and
2788         "compile file".  Mention available options in "compile code" and
2789         "compile code"'s help.
2790         * completer.c (advance_to_completion_word): New, factored out from
2791         ...
2792         (advance_to_expression_complete_word_point): ... this.
2793         (advance_to_filename_complete_word_point): New.
2794         * completer.h (advance_to_filename_complete_word_point): New
2795         declaration.
2796
2797 2019-06-13  Pedro Alves  <palves@redhat.com>
2798
2799         * compile/compile.c: Include "cli/cli-option.h".
2800         (compile_print_value): Scope data pointer is now a
2801         value_print_options pointer; adjust.
2802         (compile_print_command): Process options.  Scope data pointer is
2803         now a value_print_options pointer; adjust.
2804         (_initialize_compile): Update "compile print"'s help to include
2805         supported options.  Install a completer for "compile print".
2806         * cp-valprint.c (show_vtblprint, show_objectprint)
2807         (show_static_field_print): Delete.
2808         (_initialize_cp_valprint): Don't install "set print
2809         static-members", "set print vtbl", "set print object" here.
2810         * printcmd.c: Include "cli/cli-option.h" and
2811         "common/gdb_optional.h".
2812         (print_command_parse_format): Rework to fill in a
2813         value_print_options instead of a format_data.
2814         (print_value): Change parameter type from format_data pointer to
2815         value_print_options reference.  Adjust.
2816         (print_command_1): Process options.  Adjust to pass down a
2817         value_print_options.
2818         (print_command_completer): New.
2819         (_initialize_printcmd): Install print_command_completer as
2820         handle_brkchars completer for the "print" command.  Update
2821         "print"'s help to include supported options.
2822         * valprint.c: Include "cli/cli-option.h".
2823         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2824         here from cp-valprint.c.
2825         (boolean_option_def, uinteger_option_def)
2826         (value_print_option_defs, make_value_print_options_def_group):
2827         New.  Use gdb::option::add_setshow_cmds_for_options to install
2828         "set print elements", "set print null-stop", "set print repeats",
2829         "set print pretty", "set print union", "set print array", "set
2830         print address", "set print symbol", "set print array-indexes".
2831         * valprint.h: Include <string> and "cli/cli-option.h".
2832         (make_value_print_options_def_group): Declare.
2833         (print_value): Change parameter type from format_data pointer to
2834         value_print_options reference.
2835         (print_command_completer): Declare.
2836
2837 2019-06-13  Pedro Alves  <palves@redhat.com>
2838
2839         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2840         (COMMON_SFILES): Add maint-test-settings.c.
2841         * cli/cli-decode.c (boolean_enums): New global, factored out from
2842         ...
2843         (add_setshow_boolean_cmd): ... here.
2844         * cli/cli-decode.h (boolean_enums): Declare.
2845         * cli/cli-option.c: New file.
2846         * cli/cli-option.h: New file.
2847         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2848         factored out from ...
2849         (parse_cli_boolean_value(const char *)): ... this.
2850         (is_unlimited_literal): Change parameter type to pointer to
2851         pointer.  Adjust and advance ARG pointer.
2852         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2853         (parse_cli_var_enum): New, factored out from ...
2854         (do_set_command): ... this.  Adjust.
2855         * cli/cli-setshow.h (parse_cli_boolean_value)
2856         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2857         (parse_cli_var_enum): Declare.
2858         * cli/cli-utils.c: Include "cli/cli-option.h".
2859         (get_ulongest): New.
2860         * cli/cli-utils.h (get_ulongest): Declare.
2861         (check_for_argument): New overloads.
2862         * maint-test-options.c: New file.
2863
2864 2019-06-13  Pedro Alves  <palves@redhat.com>
2865
2866         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2867         parse a range if "-" is at the end of the string.
2868
2869 2019-06-13  Pedro Alves  <palves@redhat.com>
2870
2871         * cli/cli-setshow.c (parse_auto_binary_operation)
2872         (parse_cli_boolean_value): Don't allow "o".
2873
2874 2019-06-13  Pedro Alves  <palves@redhat.com>
2875
2876         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2877         * NEWS: Mention maint test-settings KIND.
2878         * maint-test-settings.c: New file.
2879
2880 2019-06-13  Pedro Alves  <palves@redhat.com>
2881
2882         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2883         completer.
2884         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2885         "set" completers.
2886
2887 2019-06-13  Pedro Alves  <palves@redhat.com>
2888
2889         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2890         after item.
2891
2892 2019-06-13  Pedro Alves  <palves@redhat.com>
2893
2894         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2895
2896 2019-06-13  Pedro Alves <palves@redhat.com>
2897
2898         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2899         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2900         call.
2901         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2902         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2903         calls.
2904         (check_for_argument): Skip spaces after argument.
2905
2906 2019-06-13  Pedro Alves  <palves@redhat.com>
2907
2908         * thread.c (thread_apply_command): Adjust TID parsing.
2909         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2910         detected before end of string.
2911         (tid_is_in_list): Error out if LIST is invalid.
2912
2913 2019-06-13  Pedro Alves  <palves@redhat.com>
2914
2915         * completer.c (complete_line_internal_1): Rewind completion word
2916         point.
2917         (completion_tracker::advance_custom_word_point_by): Change
2918         parameter type to int.
2919         * completer.h (completion_tracker::advance_custom_word_point_by):
2920         Likewise.
2921
2922 2019-06-13  Pedro Alves  <palves@redhat.com>
2923
2924         * completer.c (advance_to_completion_word): Handle delimiters.
2925
2926 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2927
2928         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2929
2930 2019-06-11  Tom Tromey  <tom@tromey.com>
2931
2932         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2933         (xmalloc_failed): Move to alloc.c.
2934         * alloc.c: New file.
2935         * Makefile.in (COMMON_SFILES): Add alloc.c.
2936
2937 2019-06-11  Tom Tromey  <tom@tromey.com>
2938
2939         * nat/linux-waitpid.c: Don't include server.h.
2940         (linux_debug): Remove.
2941         (my_waitpid): Update.
2942
2943 2019-06-11  Tom Tromey  <tromey@adacore.com>
2944
2945         * infcall.c (_initialize_infcall): Remove trailing newline from
2946         help.
2947         * user-regs.c (_initialize_user_regs): Remove trailing newline
2948         from help.
2949         * typeprint.c (_initialize_typeprint): Remove trailing newline
2950         from help.
2951         * reverse.c (_initialize_reverse): Remove trailing newlines from
2952         help.
2953         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2954         from help.
2955         * language.c (add_set_language_command): Remove trailing newline
2956         from help.
2957         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2958         help.
2959         * disasm.c (_initialize_disasm): Remove trailing newline from
2960         help.
2961         * top.c (init_main): Remove trailing newline from help.
2962         * interps.c (_initialize_interpreter): Remove trailing newline
2963         from help.
2964         * btrace.c (_initialize_btrace): Remove trailing newlines from
2965         help.
2966         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2967         from help.
2968         * python/python.c (_initialize_python): Remove trailing newline
2969         from help.
2970         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2971         help.
2972         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2973         from help.  Reformat some text.
2974         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2975         from help.
2976         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2977         newline from help.
2978
2979 2019-06-11  Tom Tromey  <tromey@adacore.com>
2980
2981         * darwin-nat.c (darwin_decode_exception_message)
2982         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2983
2984 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2985
2986         * valops.c (value_slice): Check for not allocated or not
2987         associated values.
2988
2989 2019-06-10  Tom de Vries  <tdevries@suse.de>
2990
2991         PR gdb/24618
2992         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2993         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2994         invalid.
2995
2996 2019-06-10  Tom de Vries  <tdevries@suse.de>
2997
2998         PR gdb/24611
2999         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3000         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3001
3002 2019-06-10  Tom de Vries  <tdevries@suse.de>
3003
3004         PR symtab/24545
3005         * symtab.c (struct demangled_name_entry): Add language field.
3006         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3007         static minimal symbol".  Set and use language field.
3008
3009 2019-06-10  Tom Tromey  <tromey@adacore.com>
3010
3011         * ada-lang.c (_initialize_ada_language): Update help text.
3012
3013 2019-06-10  Tom Tromey  <tromey@adacore.com>
3014
3015         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3016         with a newline.
3017         * guile/guile.c (handle_boot_error): Don't end warning with a
3018         newline.
3019         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3020         warning with a newline.
3021         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3022         newline.
3023         (s12z_frame_cache): Likewise.
3024         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3025         a newline.
3026         * solib-svr4.c (disable_probes_interface): Don't end warning with
3027         a newline.
3028         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3029         newline.
3030         * python/python.c (do_finish_initialization): Don't end warning
3031         with a newline.
3032
3033 2019-06-10  Tom Tromey  <tom@tromey.com>
3034
3035         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3036         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3037         gdbpy_enter.
3038
3039 2019-06-10  Tom Tromey  <tromey@adacore.com>
3040
3041         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3042         data.
3043         (elf_new_init): Don't call stabsread_new_init.
3044         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3045         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3046         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3047
3048 2019-06-10  Tom de Vries  <tdevries@suse.de>
3049
3050         PR symtab/16264
3051         PR symtab/24517
3052         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3053
3054 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3055
3056         * source.c (find_and_open_source): Also rewrite relative file
3057         names.
3058
3059 2019-04-26  Amos Bird  <amosbird@gmail.com>
3060
3061         * annotate.c (annotate_thread_exited): Add "thread-exited"
3062         annotation.
3063
3064 2019-06-06  Tom Tromey  <tromey@adacore.com>
3065
3066         * maint.h (class scoped_command_stats): Use
3067         DISABLE_COPY_AND_ASSIGN.
3068         <print_time>: New method.
3069         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3070         print_time.
3071         (scoped_command_stats::print_time): New method.
3072
3073 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3074
3075         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3076         instructions of lengths 6 or 8 bytes.
3077
3078 2019-06-04  Pedro Alves  <palves@redhat.com>
3079
3080         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3081
3082         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3083         * breakpoint.c (condition_completer): Likewise.
3084         * cli/cli-dump.c (scan_expression): Likewise.
3085         * common/filestuff.c (mkdir_recursive): Likewise.
3086         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3087         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3088         (gdb_abspath): Likewise.
3089         * compile/compile-cplus-types.c
3090         (compile_cplus_instance::decl_name): Likewise.
3091         * completer.c (complete_explicit_location):
3092         (signal_completer, reg_or_group_completer_1): Likewise.
3093         * cp-support.c (cp_remove_params_if_any): Likewise.
3094         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3095         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3096         * infcmd.c (strip_bg_char): Likewise.
3097         * linespec.c (copy_token_string): Likewise.
3098         * mi/mi-main.c (output_cores): Likewise.
3099         * psymtab.c (psymtab_search_name):
3100         * symfile.c (test_set_ext_lang_command): Likewise.
3101         * target.c (target_fileio_read_stralloc): Likewise.
3102         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3103         * value.c (complete_internalvar): Likewise.
3104
3105 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3106
3107         Add objfile property to gdb.Type.
3108         * NEWS: Mention Python API addition.
3109         * python/py-type.c (typy_get_objfile): New method.
3110
3111 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3112
3113         * NEWS: Mention the new set|show style [title|highlight].
3114         Mention changes to "show style", "help" and "apropos".
3115
3116 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3117
3118         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3119         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3120         instead of print_help_for_command.
3121         (print_doc_of_command): New function.
3122         (help_list): Add 'apropos -v word' suggestion.
3123         (print_help_for_command): Style the command name using title style.
3124         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3125         (_initialize_cli_cmds): Describe -v in apropos_command help.
3126
3127 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3128
3129         * cli/cli-style.h (cli_style_option): Add name in constructor,
3130         add m_name class member, add constructor with intensity,
3131         add name class function.
3132         (cli_style_option::add_setshow_commands): Remove name argument.
3133         (highlight_style, title_style): New styles.
3134         * cli/cli-style.c (do_show): New function that shows a style
3135         characteristic styling the style name with itself.
3136         (set_style_name): New function.
3137         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3138         Update all callers according to the changes in cli/cli-style.h.
3139         * utils.h (fputs_highlighted): New function.
3140         * utils.c (fputs_highlighted): Likewise.
3141
3142 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3143
3144         * NEWS: Mention new pipe command and new convenience variables.
3145
3146 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3147
3148         * cli/cli-cmds.c (pipe_command): New function.
3149         (_initialize_cli_cmds): Call add_com for pipe_command.
3150         Define | as an alias for pipe.
3151         (exit_status_set_internal_vars): New function.
3152         (shell_escape): Call exit_status_set_internal_vars.
3153         cli/cli-decode.c (find_command_name_length): Recognize | as
3154         a single character command.
3155
3156 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3157
3158         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3159         top.c (execute_command_to_ui_file): New function, mostly a copy
3160         of execute_command_to_string.
3161         (execute_command_to_string): Implement by calling
3162         execute_command_to_ui_file.
3163
3164 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3165
3166         * top.h (saved_command_line): Remove declaration.
3167         * top.c (previous_saved_command_line, previous_repeat_arguments):
3168         New variables.
3169         (saved_command_line): Make static, define together with other
3170         'repeat variables'.
3171         (dont_repeat): Clear repeat_arguments.
3172         (repeat_previous, get_saved_command_line, save_command_line):
3173         New functions.
3174         (gdb_init): Initialize saved_command_line
3175         and previous_saved_command_line.
3176         * main.c (captured_main_1): Remove saved_command_line initialization.
3177         * event-top.c (handle_line_of_input): Update to use
3178         the new 'repeat' related functions instead of direct access to
3179         saved_command_line.
3180         * command.h (repeat_previous, get_saved_command_line,
3181         save_command_line): New declarations.
3182         (dont_repeat): Add comment.
3183
3184 2019-05-30  Tom Tromey  <tromey@adacore.com>
3185
3186         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3187         Fix comment.
3188         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3189
3190 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3191
3192         PR cli/24587
3193         * completer.c (complete): Initialize variable word.
3194
3195 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3196
3197         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3198         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3199         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3200         'body' is NULL to the outter 'if', protecting the '!is_define'
3201         situation as well.
3202
3203 2019-05-29  Tom Tromey  <tromey@adacore.com>
3204
3205         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3206         (dwarf_unknown): New function.
3207         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3208         (dwarf_type_encoding_name): Use dwarf_unknown.
3209
3210 2019-05-29  Tom Tromey  <tromey@adacore.com>
3211
3212         PR c++/20020:
3213         * cp-valprint.c (cp_print_value_fields): Call
3214         cp_print_static_field inside "try".
3215
3216 2019-05-29  Tom Tromey  <tromey@adacore.com>
3217
3218         * inflow.c (struct terminal_info): Add default operator=.
3219         * configure: Rebuild.
3220         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3221         -Wdeprecated-copy-dtor, -Wredundant-move.
3222
3223 2019-05-29  Tom Tromey  <tromey@adacore.com>
3224
3225         * NEWS: Add entry.
3226         * infcmd.c (print_return_value_1): Handle finish_print
3227         option.
3228         (show_print_finish): New function.
3229         (_initialize_infcmd): Add "set/show print finish" commands.
3230         * valprint.c (user_print_options): Initialize new member.
3231         * valprint.h (struct value_print_options) <finish_print>: New
3232         member.
3233
3234 2019-05-28  Tom Tromey  <tromey@adacore.com>
3235
3236         * ada-lang.c (ada_remove_Xbn_suffix)
3237         (find_old_style_renaming_symbol)
3238         (parse_old_style_renaming): Remove.
3239         (ada_find_renaming_symbol): Don't call
3240         find_old_style_renaming_symbol.
3241         (ada_is_renaming_symbol): Rename from
3242         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3243         bool.  Now static.
3244         (ada_read_var_value): Update and simplify.
3245         * ada-exp.y (write_var_or_type): Remove old code.
3246
3247 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3248
3249         * event-top.c: Remove include comment.
3250         * inflow.c (class scoped_ignore_sigttou): Move from here...
3251         * inflow.h (class scoped_ignore_sigttou): ...to here.
3252         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3253         * top.c:  Remove include comment.
3254
3255 2019-05-27  Tom Tromey  <tom@tromey.com>
3256
3257         * NEWS: Fix typo.
3258
3259 2019-05-22  Tom Tromey  <tromey@adacore.com>
3260
3261         * target.c (target_follow_exec): Constify parameter.
3262         * target-delegates.c: Rebuild.
3263         * remote.c (remote_target::follow_exec): Constify parameter.
3264         * infrun.c (follow_exec): Constify parameter.
3265         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3266         (target_follow_exec): Likewise.
3267
3268 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3269
3270         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3271         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3272
3273 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3274
3275         * NEWS: Add debugredirect and testsuite sections.
3276
3277 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3278
3279         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3280         target descriptions using exclusively floating point register name
3281         aliases.
3282
3283 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3284
3285         PR gdb/18644:
3286         * f-lang.c (build_fortran_types): Handle the case where
3287         gdbarch_floatformat_for_type returns a nullptr.
3288
3289 2019-05-21  Tom de Vries  <tdevries@suse.de>
3290
3291         PR cli/24587
3292         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3293
3294 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3295
3296         PR gdb/18644:
3297         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3298         16-byte floats.
3299         * i386-tdep.c (i386_floatformat_for_type): Use
3300         floatformats_ia64_quad for the 16-byte floating point component
3301         within a fortran 32-byte complex number.
3302
3303 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3304
3305         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3306         delete default constructor.
3307         (find_partial_die): Update to return const struct.
3308         (partial_die_parent_scope): Move variable declaration into scope
3309         of its use and change its type to auto.
3310         (guess_partial_die_structure_name): Likewise.
3311         (partial_die_info::fixup): Likewise.
3312
3313 2019-05-17  Tom Tromey  <tromey@adacore.com>
3314
3315         * source.c (find_and_open_source): Remove cast.
3316
3317 2019-05-17  Tom Tromey  <tromey@adacore.com>
3318
3319         * annotate.c (annotate_source): Make "filename" const.
3320         * annotate.h (annotate_source): Use const.
3321
3322 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3323
3324         * disasm.c (set_disassembler_options): Send errors to stderr.
3325
3326 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3327
3328         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3329         (cli_interp_base::set_logging): Check debug_redirect.
3330         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3331         * cli/cli-logging.c (debug_redirect): Add static variable.
3332         (pop_output_files): Add default param.
3333         (handle_redirections): Print debug setting.
3334         (show_logging_command): Likewise.
3335         (_initialize_cli_logging): Add debugredirect command.
3336         * interps.c (current_interp_set_logging): Add debug_redirect
3337         parameter.
3338         * interps.h (set_logging): Add debug_redirect parameter.
3339         (current_interp_set_logging): Likewise.
3340         * mi/mi-common.h: Likewise.
3341         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3342
3343 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3344             Tom Tromey  <tromey@adacore.com>
3345
3346         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3347         directly.
3348         * cli/cli-interp.h (make_logging_output): Remove declaration.
3349         * cli/cli-logging.c (make_logging_output): Remove function.
3350         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3351         directly.
3352         * ui-file.c (tee_file::tee_file): Remove bools.
3353         (tee_file::~tee_file): Remove deletes.
3354         * ui-file.h (tee_file): Remove bools.
3355
3356 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3357
3358         * mi/mi-cmds.h (mi_cmd_complete): New function.
3359         * mi/mi-main.c (mi_cmd_complete): Likewise.
3360         * mi/mi-cmds.c: Define new MI command -complete.
3361         * NEWS: Mention new -complete command.
3362
3363 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3364
3365         * completer.h (complete): New function.
3366         * completer.c (complete): Likewise.
3367         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3368         function defined in completer.h.
3369
3370 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3371
3372         * MAINTAINERS (Write After Approval): Add myself.
3373
3374 2019-05-17  Tom de Vries  <tdevries@suse.de>
3375
3376         PR gdb/24094
3377         * dwarf2read.c (struct cu_partial_die_info): New struct.
3378         (find_partial_die): Return cu_partial_die_info.
3379         (partial_die_parent_scope, guess_partial_die_structure_name)
3380         (partial_die_info::fixup): Handle new return type of find_partial_die.
3381
3382 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3383
3384         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3385         "std::string", simplifying the algorithm.
3386
3387 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3388
3389         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3390         (stap_static_probe_ops::get_probes): Likewise.
3391
3392 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3393
3394         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3395         '-')" and "else if".
3396         (stap_parse_single_operand): Join checks for
3397         "gdbarch_stap_parse_special_token_p" and
3398         "gdbarch_stap_parse_special_token" in the same "if" statement.
3399         Invert check when verifying for operation on register
3400         displacement.
3401
3402 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3403
3404         * stap-probe.c (stap_get_opcode): Update comment.
3405         (stap_get_expected_argument_type): Likewise.
3406         (handle_stap_probe): Likewise.
3407
3408 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3409
3410         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3411         return type to 'bool'.  Adjust comment.  Use 'bool' when
3412         appropriate.
3413         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3414         * stap-probe.c (stap_parse_argument_1): Likewise.
3415         (stap_is_operator): Likewise.
3416         (stap_is_generic_prefix): Likewise.
3417         (stap_is_register_prefix): Likewise.
3418         (stap_is_register_indirection_prefix): Likewise.
3419         (stap_is_integer_prefix): Likewise.
3420         (stap_generic_check_suffix): Likewise.
3421         (stap_check_integer_suffix): Likewise.
3422         (stap_check_register_suffix): Likewise.
3423         (stap_check_register_indirection_suffix): Likewise.
3424         (stap_parse_register_operand): Likewise.
3425         (stap_parse_single_operand): Likewise.
3426         (stap_parse_argument_1): Likewise.
3427         (stap_probe::get_argument_count): Likewise.
3428         (stap_is_operator): Likewise.
3429
3430 2019-05-16  Tom Tromey  <tromey@adacore.com>
3431
3432         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3433         keyword to foreach.
3434
3435 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3436
3437         * linux-thread-db.c (try_thread_db_load_1): Change return type
3438         to bool.
3439         (try_thread_db_load): Likewise.
3440         (try_thread_db_load_from_pdir_1): Likewise.
3441         (try_thread_db_load_from_pdir): Likewise.
3442         (try_thread_db_load_from_sdir): Likewise.
3443         (try_thread_db_load_from_dir): Likewise.
3444         (thread_db_load_search): Likewise.
3445         (has_libpthread): Likewise.
3446         (thread_db_load): Likewise.
3447
3448 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3449
3450         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3451         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3452         NULL, and complain/return if that's the case.
3453
3454 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3455
3456         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3457         (advance, posn, abstract_read_memory): New functions.
3458         [struct mem_read_abstraction]: New struct.
3459         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3460
3461 2019-05-14  Tom Tromey  <tromey@adacore.com>
3462
3463         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3464         value is not lval_memory.
3465
3466 2019-05-14  Tom Tromey  <tromey@adacore.com>
3467
3468         * solib.c (info_sharedlibrary_command): Style the file name.
3469
3470 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3471
3472         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3473         (aarch64_vnv_type): Likewise.
3474         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3475         * common/tdesc.c: Likewise.
3476         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3477         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3478         * features/aarch64-fpu.xml: Add ieee half view.
3479         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3480         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3481         * gdbtypes.h (struct builtin_type): Likewise.
3482         (struct objfile_type): Likewise.
3483
3484 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3485
3486         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3487         typo.
3488         * location.h (string_to_event_location): Likewise.
3489
3490 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3491
3492         GDB 8.3 released.
3493
3494 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3495
3496         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3497         New variable declaration.
3498         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3499         New variable.
3500         (print_one_breakpoint): Use ui_out::test_flags and new global
3501         variable to compute use_fixed_output.
3502         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3503         Remove.
3504         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3505         (mi_multi_location_breakpoint_output_fixed): Remove.
3506         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3507         new variable.
3508         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3509         fix_multi_location_breakpoint_output flag if version >= 3.
3510         * ui-out.h (enum ui_out_flag)
3511         <fix_multi_location_breakpoint_output>: New enumerator.
3512
3513 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3514
3515         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3516
3517 2019-05-10  Tom Tromey  <tromey@adacore.com>
3518
3519         * ada-lang.c (catch_ada_completer): New function.
3520         (_initialize_ada_language): Use it.
3521
3522 2019-05-10  Tom Tromey  <tromey@adacore.com>
3523
3524         * thread.c (print_thread_info): Make "requested_threads" const.
3525         * gdbthread.h (print_thread_info): Make "requested_threads"
3526         const.
3527         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3528         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3529
3530 2019-05-08  Tom Tromey  <tom@tromey.com>
3531
3532         * gdbtypes.c (objfile_type_data): Change type.
3533         (objfile_type, _initialize_gdbtypes): Update.
3534
3535 2019-05-08  Tom Tromey  <tom@tromey.com>
3536
3537         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3538         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3539         (_initialize_dwarf2_frame): Update.
3540
3541 2019-05-08  Tom Tromey  <tom@tromey.com>
3542
3543         * objc-lang.c (objc_objfile_data): Change type.
3544         (find_methods): Update.
3545         (_initialize_objc_lang): Remove.
3546
3547 2019-05-08  Tom Tromey  <tom@tromey.com>
3548
3549         * stabsread.c (rs6000_builtin_type_data): Change type.
3550         (rs6000_builtin_type, _initialize_stabsread): Update.
3551
3552 2019-05-08  Tom Tromey  <tom@tromey.com>
3553
3554         * mips-tdep.c (mips_pdr_data): Remove.
3555         (_initialize_mips_tdep): Update.
3556
3557 2019-05-08  Tom Tromey  <tom@tromey.com>
3558
3559         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3560         (hppa_init_objfile_priv_data, read_unwind_info)
3561         (find_unwind_entry, _initialize_hppa_tdep): Update.
3562
3563 2019-05-08  Tom Tromey  <tom@tromey.com>
3564
3565         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3566         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3567         on obstack.
3568         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3569
3570 2019-05-08  Tom Tromey  <tom@tromey.com>
3571
3572         * mdebugread.c (basic_type_data): Change type.
3573         (basic_type, _initialize_mdebugread): Update.
3574
3575 2019-05-08  Tom Tromey  <tom@tromey.com>
3576
3577         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3578
3579 2019-05-08  Tom Tromey  <tom@tromey.com>
3580
3581         * nto-tdep.c (nto_inferior_data_reg): Change type.
3582         (nto_inferior_data): Update.
3583         (nto_inferior_data_cleanup, nto_new_inferior_data)
3584         (_initialize_nto_tdep): Remove.
3585         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3586
3587 2019-05-08  Tom Tromey  <tom@tromey.com>
3588
3589         * ada-lang.c (struct ada_inferior_data): Add initializers.
3590         (ada_inferior_data): Change type.
3591         (ada_inferior_data_cleanup): Remove.
3592         (get_ada_inferior_data, ada_inferior_exit)
3593         (struct ada_pspace_data): Add initializers, destructor.
3594         (ada_pspace_data_handle): Change type.
3595         (get_ada_pspace_data): Update.
3596         (ada_pspace_data_cleanup): Remove.
3597
3598 2019-05-08  Tom Tromey  <tom@tromey.com>
3599
3600         * coffread.c (struct coff_symfile_info): Add initializers.
3601         (coff_objfile_data_key): Move lower.  Change type.
3602         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3603         Update.
3604         (coff_free_info): Remove.
3605
3606 2019-05-08  Tom Tromey  <tom@tromey.com>
3607
3608         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3609         (fbsd_pspace_data_handle): Move lower.  Change type.
3610         (get_fbsd_pspace_data): Update.
3611         (fbsd_pspace_data_cleanup): Remove.
3612         (_initialize_fbsd_tdep): Update.
3613
3614 2019-05-08  Tom Tromey  <tom@tromey.com>
3615
3616         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3617         (get_ada_tasks_pspace_data): Update.
3618         (ada_tasks_pspace_data_cleanup): Remove.
3619         (_initialize_tasks): Update.
3620         (ada_tasks_inferior_data_handle): Change type.
3621         (get_ada_tasks_inferior_data): Update.
3622         (ada_tasks_inferior_data_cleanup): Remove.
3623         (struct ada_tasks_pspace_data): Add initializers.
3624
3625 2019-05-08  Tom Tromey  <tom@tromey.com>
3626
3627         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3628         * symfile-debug.c (debug_sym_get_probes): Change type.
3629         * stap-probe.c (handle_stap_probe):
3630         (stap_static_probe_ops::get_probes): Change type.
3631         * probe.h (class static_probe_ops) <get_probes>: Change type.
3632         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3633         (parse_probes_in_pspace): Update.
3634         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3635         Update.
3636         (any_static_probe_ops::get_probes): Change type.
3637         * elfread.c (elfread_data): New typedef.
3638         (probe_key): Change type.
3639         (elf_get_probes): Likewise.  Update.
3640         (probe_key_free): Remove.
3641         (_initialize_elfread): Update.
3642         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3643         Change type.
3644         (dtrace_process_dof_probe, dtrace_process_dof)
3645         (dtrace_static_probe_ops::get_probe): Change type.
3646
3647 2019-05-08  Tom Tromey  <tom@tromey.com>
3648
3649         * xcoffread.c (struct xcoff_symfile_info): Rename from
3650         coff_symfile_info.  Add initializers.
3651         (xcoff_objfile_data_key): Move lower.  Change type.
3652         (XCOFF_DATA): Rewrite.
3653         (xcoff_free_info): Remove.
3654         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3655         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3656         (xcoff_initial_scan): Update.
3657
3658 2019-05-08  Tom Tromey  <tom@tromey.com>
3659
3660         * solib-svr4.c (struct svr4_info): Add initializers and
3661         destructor.
3662         <probes_table>: Now an htab_up.
3663         (solib_svr4_pspace_data): Change type.
3664         (free_probes_table): Simplify.
3665         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3666         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3667         (probes_table_remove_objfile_probes, register_solib_event_probe)
3668         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3669         (_initialize_svr4_solib): Update.
3670
3671 2019-05-08  Tom Tromey  <tom@tromey.com>
3672
3673         * remote.c (remote_pspace_data): Change type.
3674         (remote_pspace_data_cleanup): Remove.
3675         (get_remote_exec_file, set_pspace_remote_exec_file)
3676         (_initialize_remote): Update.
3677
3678 2019-05-08  Tom Tromey  <tom@tromey.com>
3679
3680         * breakpoint.c (breakpoint_objfile_key): Change type.
3681         (get_breakpoint_objfile_data): Update.
3682         (free_breakpoint_objfile_data): Remove.
3683         (_initialize_breakpoint): Update.
3684
3685 2019-05-08  Tom Tromey  <tom@tromey.com>
3686
3687         * linux-tdep.c (struct linux_info): Add initializers.
3688         (linux_inferior_data): Move.  Change type.
3689         (invalidate_linux_cache_inf): Update.
3690         (linux_inferior_data_cleanup): Remove.
3691         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3692
3693 2019-05-08  Tom Tromey  <tom@tromey.com>
3694
3695         * auxv.c (auxv_inferior_data): Move.  Change type.
3696         (auxv_inferior_data_cleanup): Remove.
3697         (invalidate_auxv_cache_inf): Rewrite.
3698         (get_auxv_inferior_data, _initialize_auxv): Update.
3699
3700 2019-05-08  Tom Tromey  <tom@tromey.com>
3701
3702         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3703         (symfile_debug_objfile_data_key): Change type.
3704         (symfile_debug_installed, debug_qf_has_symbols)
3705         (debug_qf_find_last_source_symtab)
3706         (debug_qf_forget_cached_source_info)
3707         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3708         (debug_qf_print_stats, debug_qf_dump)
3709         (debug_qf_expand_symtabs_for_function)
3710         (debug_qf_expand_all_symtabs)
3711         (debug_qf_expand_symtabs_with_fullname)
3712         (debug_qf_map_matching_symbols)
3713         (debug_qf_expand_symtabs_matching)
3714         (debug_qf_find_pc_sect_compunit_symtab)
3715         (debug_qf_map_symbol_filenames)
3716         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3717         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3718         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3719         (debug_sym_read_linetable, debug_sym_relocate): Update.
3720         (symfile_debug_free_objfile): Remove.
3721         (install_symfile_debug_logging, _initialize_symfile_debug):
3722         Update.
3723
3724 2019-05-08  Tom Tromey  <tom@tromey.com>
3725
3726         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3727         allocate_on_obstack.
3728         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3729         (get_dwarf2_per_objfile): Update.
3730         (set_dwarf2_per_objfile): Remove.
3731         (dwarf2_has_info, dwarf2_get_section_info): Update.
3732         (dwarf2_free_objfile): Remove.
3733         (_initialize_dwarf2_read): Update.
3734
3735 2019-05-08  Tom Tromey  <tom@tromey.com>
3736
3737         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3738         initializers.
3739         <unsupported_script_warning_printed,
3740         script_not_found_warning_printed>: Now bool.
3741         (auto_load_pspace_data): Change type.
3742         (~auto_load_pspace_info): Rename from
3743         auto_load_pspace_data_cleanup.
3744         (get_auto_load_pspace_data, init_loaded_scripts_info)
3745         (clear_section_scripts, maybe_print_unsupported_script_warning)
3746         (maybe_print_script_not_found_warning, _initialize_auto_load):
3747         Update.
3748
3749 2019-05-08  Tom Tromey  <tom@tromey.com>
3750
3751         * objfiles.c (objfile_pspace_info): Add destructor and
3752         initializers.
3753         (objfiles_pspace_data): Change type.
3754         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3755         (get_objfile_pspace_data): Update.
3756         (objfiles_bfd_data): Change type.
3757         (get_objfile_bfd_data): Update.
3758         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3759
3760 2019-05-08  Tom Tromey  <tom@tromey.com>
3761
3762         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3763         Change type.
3764         (get_catch_syscall_inferior_data): Update.
3765         (catch_syscall_inferior_data_cleanup): Remove.
3766         (_initialize_break_catch_syscall): Update.
3767
3768 2019-05-08  Tom Tromey  <tom@tromey.com>
3769
3770         * inflow.c (struct terminal_info): Add destructor and
3771         initializers.
3772         (inflow_inferior_data): Change type.
3773         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3774         (get_inflow_inferior_data, inflow_inferior_exit)
3775         (swap_terminal_info, _initialize_inflow): Update.
3776
3777 2019-05-08  Tom Tromey  <tom@tromey.com>
3778
3779         * target-dcache.c (target_dcache_cleanup): Remove.
3780         (target_dcache_aspace_key): Change type.
3781         (target_dcache_init_p, target_dcache_invalidate)
3782         (target_dcache_get, target_dcache_get_or_init)
3783         (_initialize_target_dcache): Update.
3784         * dcache.h (struct dcache_deleter): New.
3785
3786 2019-05-08  Tom Tromey  <tom@tromey.com>
3787
3788         * symtab.c (struct symbol_cache): Add destructor and
3789         initializers.
3790         (symbol_cache_key): Move.  Change type.
3791         (make_symbol_cache, free_symbol_cache): Remove.
3792         (get_symbol_cache): Update.
3793         (symbol_cache_cleanup): Remove.
3794         (ALL_PSPACES, symbol_cache_flush)
3795         (maintenance_print_symbol_cache)
3796         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3797         Update.
3798
3799 2019-05-08  Tom Tromey  <tom@tromey.com>
3800
3801         * symtab.c (struct main_info): Add destructor and initializers.
3802         (main_progspace_key): Move.  Change type.
3803         (get_main_info): Update.
3804         (main_info_cleanup): Remove.
3805         (_initialize_symtab): Update.
3806
3807 2019-05-08  Tom Tromey  <tom@tromey.com>
3808
3809         * registry.h (DECLARE_REGISTRY): Define the _key class.
3810
3811 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3812
3813         * NEWS: Merge two 'New commands' sections.
3814
3815 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3816
3817         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3818         parameter and use Ada language definition instead.
3819         (ada_val_print_ptr): Remove unused language parameter.
3820         (ada_val_print_num): Remove language parameter and use Ada language
3821         definition instead.
3822         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3823         parameter.
3824         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3825         parameter and use Ada language definition instead.
3826         (ada_val_print_1): Update all ada_val_print_xxx calls.
3827         Remove language parameter.
3828         (ada_val_print): Update ada_val_print_1 call.
3829
3830 2019-05-08  Tom Tromey  <tromey@adacore.com>
3831
3832         * remote.c (remote_hw_watchpoint_limit)
3833         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3834         Now static.
3835
3836 2019-05-08  Tom Tromey  <tromey@adacore.com>
3837
3838         * maint.c (_initialize_maint_cmds): Move initialization code to
3839         remote.c.
3840         (watchdog, show_watchdog): Move to remote.c.
3841         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3842         "watchdog" static.
3843         (_initialize_remote): Move initialization code from maint.c.
3844         * defs.h (watchdog): Don't declare.
3845
3846 2019-05-08  Tom Tromey  <tromey@adacore.com>
3847
3848         * tui/tui-interp.c: Include main.h.
3849         * interps.c: Include main.h.
3850         * main.h (interpreter_p): Declare.
3851         * defs.h (interpreter_p): Don't declare.
3852
3853 2019-05-08  Tom Tromey  <tromey@adacore.com>
3854
3855         * dwarf2loc.c: Include dwarf2read.h.
3856         * defs.h (read_unsigned_leb128): Don't declare.
3857         * dwarf2read.h (read_unsigned_leb128): Declare.
3858
3859 2019-05-08  Tom Tromey  <tromey@adacore.com>
3860
3861         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3862         method.
3863
3864 2019-05-08  Tom Tromey  <tromey@adacore.com>
3865
3866         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3867         when no wrap column is set.
3868
3869 2019-05-08  Tom Tromey  <tromey@adacore.com>
3870
3871         * c-lang.c (c_get_string): Handle non-C-style arrays.
3872
3873 2019-05-08  Tom Tromey  <tromey@adacore.com>
3874
3875         * typeprint.c (print_offset_data::update): Print the bit offset,
3876         not the number of bits remaining.
3877
3878 2019-05-08  Tom Tromey  <tromey@adacore.com>
3879
3880         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3881         padding at end of comment.
3882
3883 2019-05-08  Tom Tromey  <tromey@adacore.com>
3884
3885         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3886         Compare main types.
3887
3888 2019-05-06  Tom Tromey  <tom@tromey.com>
3889
3890         * common/scoped_mmap.c: Include common-defs.h.
3891         * common/scoped_mmap.h: Don't include config.h.
3892
3893 2019-05-04  Tom Tromey  <tom@tromey.com>
3894
3895         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3896         (struct aarch64_call_info): Add initializers.
3897         <si>: Now a std::vector.
3898         (pass_on_stack, aarch64_push_dummy_call): Update.
3899
3900 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3901             Tom Tromey  <tom@tromey.com>
3902
3903         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3904         (ppc_threads): Now a std::vector.  Now static.
3905         (hwdebug_find_thread_points_by_tid)
3906         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3907         Update.
3908
3909 2019-05-04  Tom Tromey  <tom@tromey.com>
3910
3911         * arc-tdep.c (arc_tdesc_init): Return bool.
3912
3913 2019-05-04  Tom Tromey  <tom@tromey.com>
3914
3915         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3916         Use gdb_assert_not_reached.
3917
3918 2019-05-04  Tom Tromey  <tom@tromey.com>
3919
3920         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3921         "false".
3922
3923 2019-05-04  Tom Tromey  <tom@tromey.com>
3924
3925         * arc-tdep.c (arc_tdesc_init): Use bool.
3926
3927 2019-05-04  Tom Tromey  <tom@tromey.com>
3928
3929         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3930
3931 2019-05-04  Tom Tromey  <tom@tromey.com>
3932
3933         * cli/cli-cmds.c (valid_command_p): Return bool.
3934
3935 2019-05-04  Tom Tromey  <tom@tromey.com>
3936
3937         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3938         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3939
3940 2019-05-04  Raul Tambre  <raul@tambre.ee>
3941
3942         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3943         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3944         operator for comparison.
3945
3946 2019-05-04  Tom Tromey  <tom@tromey.com>
3947
3948         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3949         (lookup_partial_symbol, print_partial_symbols)
3950         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3951         (psymbol_compare): Update.
3952         (add_psymbol_to_bcache): Clear the entire psymbol.
3953         (maintenance_check_psymtabs): Update.
3954         * psympriv.h (struct partial_symbol): Don't derive from
3955         general_symbol_info.
3956         <obj_section, unrelocated_address, address,
3957         set_unrelocated_address>: Update.
3958         <ginfo>: New member.
3959         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3960         (debug_names::write_psymbols): Update.
3961
3962 2019-05-04  Tom de Vries  <tdevries@suse.de>
3963
3964         * contrib/cc-with-tweaks.sh: Support -n arg.
3965
3966 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3967
3968         * corelow.c (core_target::detach): Ensure frame cache and
3969         register caches are cleared.
3970         inferior.c (exit_inferior_1): Likewise.
3971
3972 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3973             Tom Tromey  <tom@tromey.com>
3974
3975         * dictionary.c (collate_pending_symbols_by_language): Remove
3976         "struct" from foreach.
3977         * symtab.c (lookup_global_symbol_from_objfile)
3978         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3979         foreach.
3980         * ser-tcp.c (net_open): Remove "struct" from foreach.
3981         * objfiles.c (objfile_relocate, objfile_rebase)
3982         (objfile_has_symbols): Remove "struct" from foreach.
3983         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3984         from foreach.
3985         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3986         foreach.
3987         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3988         "struct" from foreach.
3989         * ada-lang.c (create_excep_cond_exprs)
3990         (ada_exception_catchpoint_cond_string): Remove "struct" from
3991         foreach.
3992
3993 2019-05-03  Tom Tromey  <tromey@adacore.com>
3994
3995         * ada-exp.y (convert_char_literal): Check suffix of each
3996         enumerator.
3997
3998 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3999
4000         PR ada/21406:
4001         * ada-exp.y (yywrap): Don't define.
4002         * ada-lex.l (%option): Add noyywrap
4003         (yywrap): Remove.
4004
4005 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4006
4007         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4008         _WIN32_WINNT to the XP level, unless already defined to a higher
4009         level.
4010
4011         * unittests/parse-connection-spec-selftests.c:
4012         * ser-tcp.c:
4013         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4014         override.
4015
4016         * symfile.c (find_separate_debug_file): Remove colon from the
4017         drive spec of DOS/Windows file names of the target, so that the
4018         file name produced from DEBUGDIR and the target's directory will
4019         be valid on DOS/Windows systems.
4020
4021 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4022
4023         * rust-lang.c (val_print_struct): Handle printing structures
4024         containing strings.
4025
4026 2019-05-02  Tom Tromey  <tromey@adacore.com>
4027
4028         * valarith.c (_initialize_valarith): Remove.
4029
4030 2019-05-01  Tom Tromey  <tromey@adacore.com>
4031
4032         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4033         bitfields.
4034
4035 2019-05-01  Tom Tromey  <tromey@adacore.com>
4036
4037         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4038         for big-endian copies.
4039
4040 2019-04-30  Ali Tamur  <tamur@google.com>
4041         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4042         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4043         (read_3_bytes): New function.
4044
4045 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4046
4047         * windows-nat.c (main_thread_id): Delete.
4048         (handle_output_debug_string): Replace main_thread_id by
4049         current_event.dwThreadId.
4050         (fake_create_process): Likewise.
4051         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4052         Do not set main_thread_id.
4053         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4054         current_event.dwThreadId.
4055         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4056
4057 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4058
4059         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4060         Use current_event.dwThreadId instead of main_thread_id.
4061
4062 2019-04-30  Tom Tromey  <tromey@adacore.com>
4063
4064         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4065         (create_excep_cond_exprs): Iterate over program spaces.
4066         (ada_exception_catchpoint_cond_string): Examine all minimal
4067         symbols for exception types.
4068
4069 2019-04-30  Tom Tromey  <tromey@adacore.com>
4070
4071         PR c++/24470:
4072         * dwarf2read.c (process_structure_scope): Handle case where type
4073         has template parameters but no symbol was created.
4074
4075 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4076             Chris January  <chris.january@arm.com>
4077
4078         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4079         qualifier.
4080         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4081
4082 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4083
4084         * f-typeprint.c (f_print_type): Update rules for printing
4085         whitespace.
4086         (f_type_print_varspec_suffix): Likewise.
4087
4088 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4089             Chris January  <chris.january@arm.com>
4090
4091         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4092         function arguments.
4093
4094 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4095
4096         * f-lang.c (build_fortran_types): Change name of void type to
4097         lower case.
4098         * f-typeprint.c (f_type_print_base): Print the name of the void
4099         type, rather than a fixed string.
4100         * f-valprint.c (f_decorations): Use lower case void string.
4101
4102 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4103             Chris January  <chris.january@arm.com>
4104
4105         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4106         types for Fortran.
4107
4108 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4109             Chris January  <chris.january@arm.com>
4110             David Lecomber  <david.lecomber@arm.com>
4111
4112         * f-exp.y (BINOP_INTRINSIC): New token.
4113         (exp): New parser rule handling BINOP_INTRINSIC.
4114         (f77_keywords): Add new builtin procedures.
4115         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4116         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4117         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4118         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4119         (print_unop_subexp_f): New function.
4120         (print_binop_subexp_f): New function.
4121         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4122         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4123         (dump_subexp_body_f): Likewise.
4124         (operator_check_f): Likewise.
4125         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4126         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4127
4128 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4129
4130         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4131         UNOP_KIND.
4132         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4133         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4134         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4135         (operator_length_f): New fuction.
4136         (print_subexp_f): New function.
4137         (op_name_f): New function.
4138         (dump_subexp_body_f): New function.
4139         (operator_check_f): New function.
4140         (exp_descriptor_f): Replace standard expression handling functions
4141         with new functions.
4142         * gdb/fortran-operator.def: New file.
4143         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4144         * gdb/std-operator.def: Remove UNOP_KIND.
4145
4146 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * std-operator.def: Remove unbalanced, stray double quote
4149         character.
4150
4151 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4152             Chris January  <chris.january@arm.com>
4153             Daniel Everett  <daniel.everett@arm.com>
4154             Nick Forrington  <nick.forrington@arm.com>
4155             Richard Bunt  <richard.bunt@arm.com>
4156
4157         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4158         of depth when printing anonymous structs or unions.
4159         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4160         Don't print either the top-level value, or the children if the
4161         max-depth is exceeded.
4162         (ppscm_print_children): When printing the key of a map, allow one
4163         extra level of depth.
4164         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4165         print either the top-level value, or the children if the max-depth
4166         is exceeded.
4167         (print_children): When printing the key of a map, allow one extra
4168         level of depth.
4169         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4170         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4171         (user_print_options): Initialise max_depth field.
4172         (val_print_scalar_or_string_type_p): New function.
4173         (val_print): Check to see if the max depth has been reached.
4174         (val_print_check_max_depth): Define new function.
4175         (show_print_max_depth): New function.
4176         (_initialize_valprint): Add 'print max-depth' option.
4177         * valprint.h (struct value_print_options) <max_depth>: New field.
4178         (val_print_check_max_depth): Declare new function.
4179         * NEWS: Document new feature.
4180
4181 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * ada-lang.c (ada_language_defn): Initialise new field.
4184         * c-lang.c (c_is_string_type_p): New function.
4185         (c_language_defn): Initialise new field.
4186         (cplus_language_defn): Initialise new field.
4187         (asm_language_defn): Initialise new field.
4188         (minimal_language_defn): Initialise new field.
4189         * c-lang.h (c_is_string_type_p): Declare new function.
4190         * d-lang.c (d_language_defn): Initialise new field.
4191         * f-lang.c (f_is_string_type_p): New function.
4192         (f_language_defn): Initialise new field.
4193         * go-lang.c (go_is_string_type_p): New function.
4194         (go_language_defn): Initialise new field.
4195         * language.c (default_is_string_type_p): New function.
4196         (unknown_language_defn): Initialise new field.
4197         (auto_language_defn): Initialise new field.
4198         * language.h (struct language_defn) <la_is_string_type_p>: New
4199         member variable.
4200         (default_is_string_type_p): Declare new function.
4201         * m2-lang.c (m2_language_defn): Initialise new field.
4202         * objc-lang.c (objc_language_defn): Initialise new field.
4203         * opencl-lang.c (opencl_language_defn): Initialise new field.
4204         * p-lang.c (pascal_is_string_type_p): New function.
4205         (pascal_language_defn): Initialise new field.
4206         * rust-lang.c (rust_is_string_type_p): New function.
4207         (rust_language_defn): Initialise new field.
4208
4209 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4210
4211         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4212         New field.
4213         * ada-lang.c (ada_language_defn): Initialise new field.
4214         * c-lang.c (c_language_defn): Likewise.
4215         (cplus_language_defn): Likewise.
4216         (asm_language_defn): Likewise.
4217         (minimal_language_defn): Likewise.
4218         * d-lang.c (d_language_defn): Likewise.
4219         * f-lang.c (f_language_defn): Likewise.
4220         * go-lang.c (go_language_defn): Likewise.
4221         * language.c (unknown_language_defn): Likewise.
4222         (auto_language_defn): Likewise.
4223         * m2-lang.c (m2_language_defn): Likewise.
4224         * objc-lang.c (objc_language_defn): Likewise.
4225         * opencl-lang.c (opencl_language_defn): Likewise.
4226         * p-lang.c (pascal_language_defn): Likewise.
4227         * rust-lang.c (rust_language_defn): Likewise.
4228
4229 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4230
4231         * ada-lang.c (ada_is_character_type): Change return type to bool.
4232         (ada_is_string_type): Likewise.
4233         * ada-lang.h (ada_is_character_type): Update declaration
4234         (ada_is_string_type): Likewise.
4235
4236 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4237
4238         Support style in 'frame|thread apply'
4239
4240         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4241         * record.c (record_start, record_stop): Update callers of
4242         execute_command_to_string with false.
4243         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4244         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4245         methods.
4246         (class string_file): New constructor with term_out parameter.
4247         Override methods term_out and can_emit_style_escape.  New member
4248         term_out.
4249         (class stdio_file): Override can_emit_style_escape.
4250         (class tee_file): Override term_out and can_emit_style_escape.
4251         * utils.h (can_emit_style_escape): Remove.
4252         * utils.c (can_emit_style_escape): Likewise.
4253         Update all callers of can_emit_style_escape (SOMESTREAM) to
4254         SOMESTREAM->can_emit_style_escape.
4255         * source-cache.c (source_cache::get_source_lines): Likewise.
4256         * stack.c (frame_apply_command_count): Call execute_command_to_string
4257         passing the term_out characteristic of the current gdb_stdout.
4258         * thread.c (thr_try_catch_cmd): Likewise.
4259         * top.c (execute_command_to_string): pass term_out parameter
4260         to construct the string_file for the command output.
4261         * ui-file.c (term_cli_styling): New function (most code moved
4262         from utils.c can_emit_style_escape).
4263         (string_file::string_file, string_file::can_emit_style_escape,
4264         stdio_file::can_emit_style_escape, tee_file::term_out,
4265         tee_file::can_emit_style_escape): New functions.
4266
4267 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4268
4269         * NEWS: Mention the new set|show may-call-functions.
4270         * infcall.c (may_call_functions_p): New variable.
4271         (show_may_call_functions_p): New function.
4272         (call_function_by_hand_dummy): Throws an error if not
4273         may-call-functions.
4274         (_initialize_infcall): Call add_setshow_boolean_cmd for
4275         may-call-functions.
4276
4277 2019-04-25  Keith Seitz  <keiths@redhat.com>
4278
4279         PR c++/24367
4280         * cp-support.c (inspect_type): Don't attempt substitutions
4281         of symbol with the same name.
4282
4283 2019-04-25  Tom Tromey  <tromey@adacore.com>
4284
4285         PR gdb/24475:
4286         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4287         static.
4288
4289 2019-04-25  Tom Tromey  <tromey@adacore.com>
4290
4291         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4292         rvalue reference.
4293         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4294         (gdb_xml_parser::parse): Use std::move.
4295         * python/python-internal.h (gdbpy_convert_exception): Take a const
4296         reference.
4297         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4298         std::move.
4299         * python/py-utils.c (gdbpy_convert_exception): Take a const
4300         reference.
4301         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4302         Use std::move.
4303         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4304         Use std::move.
4305         * mi/mi-main.c (mi_print_exception): Take a const reference.
4306         * main.c (handle_command_errors): Take a const reference.
4307         * linespec.c (parse_linespec): Use std::move.
4308         * infcall.c (run_inferior_call): Use std::move.
4309         (call_function_by_hand_dummy): Use std::move.
4310         * exec.c (try_open_exec_file): Use std::move.
4311         * exceptions.h (exception_print, exception_fprintf)
4312         (exception_print_same): Update.
4313         * exceptions.c (print_exception, exception_print)
4314         (exception_fprintf, exception_print_same): Change parameters to
4315         const reference.
4316         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4317         * common/new-op.c: Use std::move.
4318         * common/common-exceptions.h (struct gdb_exception): Add move
4319         constructor.
4320         (struct gdb_exception_error, struct gdb_exception_quit, struct
4321         gdb_quit_bad_alloc): Change constructor to move constructor.
4322         (throw_exception): Change parameter to rvalue reference.
4323         * common/common-exceptions.c (throw_exception): Take rvalue
4324         reference.
4325         * cli/cli-interp.c (safe_execute_command): Use std::move.
4326         * breakpoint.c (insert_bp_location, location_to_sals): Use
4327         std::move.
4328
4329 2019-04-25  Tom Tromey  <tromey@adacore.com>
4330
4331         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4332         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4333         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4334         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4335         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4336         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4337         guile/scm-value.c: Use unpack.
4338         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4339         gdbscm_gdb_exception.
4340         (gdbscm_throw_gdb_exception): Likewise.
4341         (struct gdbscm_gdb_exception): New.
4342         (unpack): New function.
4343         (gdbscm_wrap): Use unpack.
4344
4345 2019-04-25  Tom Tromey  <tromey@adacore.com>
4346
4347         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4348         (gdb_rl_callback_handler): Use std::move.
4349         * common/common-exceptions.h (struct gdb_exception): Add move
4350         assignment operator.
4351         (throw_exception_sjlj): Change "exception" to const reference.
4352         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4353         (throw_exception_sjlj): Change "exception" to const reference.
4354
4355 2019-04-25  Tom Tromey  <tromey@adacore.com>
4356
4357         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4358         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4359         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4360         Update.
4361         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4362         Update.
4363         * mi/mi-interp.c (mi_interp::exec): Update.
4364         * linespec.c (parse_linespec): Update.
4365         * infcall.c (run_inferior_call): Update.
4366         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4367         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4368         (gdbscm_lookup_global_symbol): Update.
4369         * guile/scm-param.c (gdbscm_parameter_value): Update.
4370         * guile/scm-frame.c (gdbscm_frame_read_register)
4371         (gdbscm_frame_read_var): Update.
4372         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4373         * exec.c (try_open_exec_file): Update.
4374         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4375         (gdb_rl_callback_handler): Update.
4376         * common/common-exceptions.h (exception_none): Don't declare.
4377         * common/common-exceptions.c (exception_none): Don't define.
4378         (struct catcher) <exception>: Update.
4379         * cli/cli-interp.c (safe_execute_command): Update.
4380         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4381
4382 2019-04-25  Ali Tamur  <tamur@google.com>
4383
4384         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4385         (read_attribute_value): Likewise.
4386         (dwarf2_read_addr_index): Update comment.
4387         (read_str_index): Add DW_FORM_strx.
4388         (dwarf2_string_attr): Likewise.
4389         (dwarf2_const_value_attr): Likewise.
4390         (dump_die_shallow): Likewise.
4391         (dwarf2_fetch_constant_bytes): Likewise.
4392         (skip_form_bytes): Likewise.
4393         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4394
4395 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4396
4397         PR corefiles/11608
4398         PR corefiles/18187
4399         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4400         OFFSET.  Verify if current mapping contains an ELF header.
4401         (linux_find_memory_regions_full): Adjust call to
4402         dump_mapping_p.
4403
4404 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4405             Kang Li <kanglictf@gmail.com>
4406
4407         PR gdb/21600
4408
4409         * dwarf2-frame.c (read_initial_length): Be consistent about using
4410         unsigned representation of length.
4411         (decode_frame_entry_1): Likewise.  Check for wraparound of
4412         end pointer as well as buffer overflow.
4413
4414 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4415
4416         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4417         "vq".
4418
4419 2019-04-24  Tom Tromey  <tromey@adacore.com>
4420
4421         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4422
4423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4424
4425         * s12z-tdep.c (s12z_unwind_pc): Delete.
4426         (s12z_unwind_sp): Delete.
4427         (s12z_gdbarch_init): Don't register deleted functions with
4428         gdbarch.
4429
4430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4431
4432         * rl78-tdep.c (rl78_unwind_sp): Delete.
4433         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4434
4435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4436
4437         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4438         (xstormy16_unwind_pc): Delete.
4439         (xstormy16_dummy_id): Delete.
4440         (xstormy16_gdbarch_init): Don't register deleted functions with
4441         gdbarch.
4442
4443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4444
4445         * vax-tdep.c (vax_unwind_pc): Delete.
4446         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4447
4448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4449
4450         * v850-tdep.c (v850_unwind_sp): Delete.
4451         (v850_unwind_pc): Delete.
4452         (v850_dummy_id): Delete.
4453         (v850_gdbarch_init): Don't register deleted functions with
4454         gdbarch.
4455
4456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4459         (tilegx_unwind_pc): Delete.
4460         (tilegx_unwind_dummy_id): Delete.
4461         (tilegx_gdbarch_init): Don't register deleted functions with
4462         gdbarch.
4463
4464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4465
4466         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4467         (tic6x_dummy_id): Delete.
4468         (tic6x_gdbarch_init): Don't register deleted functions with
4469         gdbarch.
4470
4471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4472
4473         * sparc-tdep.c (sparc_unwind_pc): Delete.
4474         (sparc32_gdbarch_init): Don't register deleted function with
4475         gdbarch.
4476
4477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4478
4479         * sh-tdep.c (sh_unwind_sp): Delete.
4480         (sh_unwind_pc): Delete.
4481         (sh_dummy_id): Delete.
4482         (sh_gdbarch_init): Don't register deleted functions with
4483         gdbarch.
4484
4485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4486
4487         * score-tdep.c (score_unwind_sp): Delete.
4488         (score_unwind_pc): Delete.
4489         (score_dummy_id): Delete.
4490         (score_gdbarch_init): Don't register deleted functions with
4491         gdbarch.
4492
4493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * rx-tdep.c (rx_unwind_pc): Delete.
4496         (rx_unwind_sp): Delete.
4497         (rx_dummy_id): Delete.
4498         (rx_gdbarch_init): Don't register deleted functions with
4499         gdbarch.  Update comment.
4500
4501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4502
4503         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4504         (rs6000_dummy_id): Delete.
4505         (rs6000_gdbarch_init): Don't register deleted functions with
4506         gdbarch.
4507
4508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4509
4510         * or1k-tdep.c (or1k_dummy_id): Delete.
4511         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4512
4513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4514
4515         * nios2-tdep.c (nios2_dummy_id): Delete.
4516         (nios2_unwind_sp): Delete.
4517         (nios2_gdbarch_init): Don't register deleted functions with
4518         gdbarch.
4519
4520 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4521
4522         * nds32-tdep.c (nds32_dummy_id): Delete.
4523         (nds32_unwind_pc): Delete.
4524         (nds32_unwind_sp): Delete.
4525         (nds32_gdbarch_init): Don't register deleted functions with
4526         gdbarch.
4527
4528 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4529
4530         * msp430-tdep.c (msp430_unwind_pc): Delete.
4531         (msp430_unwind_sp): Delete.
4532         (msp430_dummy_id): Delete.
4533         (msp430_gdbarch_init): Don't register deleted functions with
4534         gdbarch.
4535
4536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4537
4538         * moxie-tdep.c (moxie_unwind_sp): Delete.
4539         (moxie_unwind_pc): Delete.
4540         (moxie_dummy_id): Delete.
4541         (moxie_gdbarch_init): Don't register deleted functions with
4542         gdbarch.
4543
4544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4545
4546         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4547         (mn10300_unwind_pc): Delete.
4548         (mn10300_unwind_sp): Delete.
4549         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4550         mn10300_unwind_sp.
4551         (mn10300_frame_unwind_init): Don't register deleted functions with
4552         gdbarch.
4553
4554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4555
4556         * mep-tdep.c (mep_unwind_pc): Delete.
4557         (mep_unwind_sp): Delete.
4558         (mep_dummy_id): Delete.
4559         (mep_gdbarch_init): Don't register deleted functions with
4560         gdbarch.
4561
4562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4563
4564         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4565         (m68hc11_unwind_sp): Delete.
4566         (m68hc11_gdbarch_init): Don't register deleted functions with
4567         gdbarch.
4568
4569 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4570
4571         * m32r-tdep.c (m32r_unwind_sp): Delete.
4572         (m32r_unwind_pc): Delete.
4573         (m32r_dummy_id): Delete.
4574         (m32r_gdbarch_init): Don't register deleted functions with
4575         gdbarch.
4576
4577 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * m32c-tdep.c (m32c_unwind_pc): Delete.
4580         (m32c_unwind_sp): Delete.
4581         (m32c_dummy_id): Delete.
4582         (m32c_gdbarch_init): Don't register deleted functions with
4583         gdbarch.
4584
4585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4588         (lm32_unwind_pc): Delete.
4589         (lm32_dummy_id): Delete.
4590         (lm32_gdbarch_init): Don't register deleted functions with
4591         gdbarch.
4592
4593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4596         (iq2000_unwind_pc): Delete.
4597         (iq2000_dummy_id): Delete.
4598         (iq2000_gdbarch_init): Don't register deleted functions with
4599         gdbarch.
4600
4601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4602
4603         * nds32-tdep.c (nds32_type_align): Delete.
4604         (nds32_push_dummy_call): Use type_align instead.
4605
4606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4607
4608         * arm-tdep.c (arm_type_align): Only handle vector override case.
4609         (arm_push_dummy_call): Use type_align.
4610         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4611
4612 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4613
4614         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4615         case.
4616         (pass_on_stack): Use type_align.
4617         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4618         function.
4619
4620 2019-04-23  Tom Tromey  <tromey@adacore.com>
4621
4622         * dwarf2read.c (line_header::file_name_at): Remove unused
4623         overload.
4624
4625 2019-04-23  Tom de Vries  <tdevries@suse.de>
4626
4627         PR gdb/24438
4628         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4629         invocation.
4630
4631
4632 2019-03-27  Ali Tamur  <tamur@google.com>
4633
4634         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4635         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4636         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4637         (dwarf_expr_context::get_addr_index): Likewise
4638         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4639         (symbol_needs_eval_context::get_addr_index): Likewise
4640         (disassemble_dwarf_expression): Add DW_OP_addrx
4641         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4642         (read_cutu_die_from_dwo): Update comment
4643         (skip_one_die): Add DW_FORM_addrx
4644         (read_attribute_value): Likewise
4645         (var_decode_location): Add DW_OP_addrx
4646         (dwarf2_const_value_attr): Add DW_FORM_addrx
4647         (dump_die_shallow): Likewise
4648         (dwarf2_fetch_constant_bytes): Likewise
4649         (decode_locdesc): Add DW_OP_addrx
4650         (skip_form_bytes): Add DW_FORM_addrx
4651
4652 2019-04-22  Ali Tamur  <tamur@google.com>
4653
4654         * MAINTAINERS (Write After Approval): Add self.
4655
4656 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4657
4658         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4659         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4660         (open_symbol_file_object): Likewise.
4661         (svr4_default_sos): Add info parameter.
4662         (svr4_read_so_list): Likewise.
4663         (svr4_current_sos_direct): Adjust functions calls to pass down
4664         info.
4665         (svr4_current_sos_1): Add info parameter.
4666         (svr4_current_sos): Call get_svr4_info, pass info down to
4667         svr4_current_sos_1.
4668         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4669         get_svr4_info.
4670         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4671         get_svr4_info.
4672         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4673         to get_svr4_info.
4674         (probes_table_remove_objfile_probes): Likewise.
4675         (register_solib_event_probe): Add info parameter.
4676         (solist_update_incremental): Pass info parameter down to
4677         svr4_read_so_list.
4678         (disable_probes_interface): Add info parameter.
4679         (svr4_handle_solib_event): Pass current_program_space to
4680         get_svr4_info.  Adjust disable_probes_interface cleanup.
4681         (svr4_create_probe_breakpoints): Add info parameter, pass it
4682         down to register_solib_event_probe.
4683         (svr4_create_solib_event_breakpoints): Add info parameter,
4684         pass it down to svr4_create_probe_breakpoints.
4685         (enable_break): Pass info down to
4686         svr4_create_solib_event_breakpoints.
4687         (svr4_solib_create_inferior_hook): Pass current_program_space to
4688         get_svr4_info.
4689         (svr4_clear_solib): Likewise.
4690
4691 2019-04-22  Pedro Alves  <palves@redhat.com>
4692
4693         * solib-svr4.c (svr4_free_objfile_observer): New.
4694         (probe_and_action::objfile): New field.
4695         (probes_table_htab_remove_objfile_probes)
4696         (probes_table_remove_objfile_probes): New functions.
4697         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4698         in the new probe_and_action.  Don't store the probe in 'lookup'.
4699         (svr4_create_probe_breakpoints): Pass objfile to
4700         register_solib_event_probe.
4701         (_initialize_svr4_solib): Register a free_objfile observer.
4702
4703 2019-04-19  Tom Tromey  <tom@tromey.com>
4704
4705         * common/queue.h: Remove.
4706
4707 2019-04-19  Tom Tromey  <tom@tromey.com>
4708
4709         * event-loop.c: Don't include "common/queue.h".
4710
4711 2019-04-19  Tom Tromey  <tom@tromey.com>
4712
4713         * remote.c (remote_target): Use delete.
4714         * remote-notif.h: Include <list>, not "common/queue.h".
4715         (notif_client_p): Remove typedef.
4716         (remote_notif_state): Add constructor, destructor, initializer.
4717         <notif_queue>: Now a std::list.
4718         (remote_notif_state_xfree): Don't declare.
4719         * remote-notif.c (remote_notif_process, handle_notification)
4720         (remote_notif_state_allocate): Update.
4721         (~remote_notif_state): Rename from remote_notif_state_xfree.
4722
4723 2019-04-19  Tom Tromey  <tom@tromey.com>
4724
4725         * symfile.c (reread_symbols): Update.
4726         * objfiles.c (objfile_register_static_link)
4727         (objfile_lookup_static_link): Update
4728         (~objfile) Don't delete static_links.
4729         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4730
4731 2019-04-19  Tom Tromey  <tom@tromey.com>
4732
4733         * type-stack.h (struct type_stack) <insert>: Constify string.
4734         * type-stack.c (type_stack::insert): Constify string.
4735         * gdbtypes.h (lookup_template_type): Update.
4736         (address_space_name_to_int): Update.
4737         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4738         const.
4739         (lookup_template_type): Make name const.
4740         * c-exp.y: Update rules.
4741         (lex_one_token, classify_name, classify_inner_name)
4742         (c_print_token): Update.
4743         * p-exp.y: Update rules.
4744         (yylex): Update.
4745         * f-exp.y: Update rules.
4746         (yylex): Update.
4747         * d-exp.y: Update rules.
4748         (lex_one_token, classify_name, classify_inner_name): Update.
4749         * parse.c (write_dollar_variable, copy_name): Return std::string.
4750         * parser-defs.h (copy_name): Change return type.
4751         * m2-exp.y: Update rules.
4752         (yylex): Update.
4753         * go-exp.y (lex_one_token): Update.
4754         Update rules.
4755         (classify_unsafe_function, classify_packaged_name)
4756         (classify_name, yylex): Update.
4757
4758 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4759
4760         * configure.ac: add --enable-source-highlight switch.
4761         * configure: Regenerate.
4762         * top.c (print_gdb_version): plumb --enable-source-highlight
4763         status to "show configuration".
4764
4765 2019-04-19  Tom Tromey  <tromey@adacore.com>
4766
4767         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4768         Check ADA_TYPE_P.
4769         (empty_record, ada_template_to_fixed_record_type_1)
4770         (template_to_static_fixed_type)
4771         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4772         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4773         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4774         macros.
4775
4776 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4777
4778         PR symtab/24423:
4779         * source.c (print_source_lines_base): Advance "iter" when a
4780         control character is seen.
4781
4782 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4783
4784         * inferior.h (struct infcall_suspend_state_deleter):
4785         Catch exception in destructor to avoid crash.
4786
4787 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4788
4789         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4790         close to the add_com "shell".
4791
4792 2019-04-18  Tom Tromey  <tromey@adacore.com>
4793
4794         * process-stratum-target.h (class process_stratum_target)
4795         <stratum>: Add "final".
4796
4797 2019-04-17  Tom Tromey  <tromey@adacore.com>
4798
4799         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4800         against nullptr before use.
4801
4802 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4803
4804         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4805
4806 2019-04-17  Jim Wilson  <jimw@sifive.com>
4807             Andrew Burgess  <andrew.burgess@embecosm.com>
4808
4809         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4810         code read might fail, assume 4-byte breakpoint in that case.
4811
4812 2019-04-15  Leszek Swirski  <leszeks@google.com>
4813
4814         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4815         rather than a hand-rolled POD check when checking for forced MEMORY
4816         classification.
4817
4818 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4819
4820         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4821         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4822         function.
4823         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4824         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4825         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4826         declaration.
4827
4828 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4829
4830         * aarch64-linux-nat.c
4831         (aarch64_linux_nat_target::thread_architecture): Add override.
4832         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4833         each VQ.
4834
4835 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4836
4837         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4838
4839 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4840
4841         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4842         target types of size 96-bits, add some additional comments, and
4843         check that the builtin type we found was the correct size.
4844
4845 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4846
4847         * utils.c (prompt_for_continue): Don't restore the styling at the
4848         end, as applied_style has the wrong value.  This fixes styling in
4849         long lists of file names that are interrupted by the "Continue?"
4850         prompt.
4851
4852 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4853
4854         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4855         * c-lang.c (c_language_defn): Likewise.
4856         (cplus_language_defn): Likewise.
4857         (asm_language_defn): Likewise.
4858         (minimal_language_defn): Likewise.
4859         * d-lang.c (d_language_defn): Likewise.
4860         * f-lang.c (f_language_defn): Likewise.
4861         * go-lang.c (go_language_defn): Likewise.
4862         * language.c (unknown_language_defn): Likewise.
4863         (auto_language_defn): Likewise.
4864         * language.h (struct language_defn): Remove la_magic field.
4865         (LANG_MAGIC): Delete.
4866         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4867         * objc-lang.c (objc_language_defn): Likewise.
4868         * opencl-lang.c (opencl_language_defn): Likewise.
4869         * p-lang.c (pascal_language_defn): Likewise.
4870         * rust-lang.c (rust_language_defn): Likewise.
4871
4872 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4873
4874         * riscv-tdep.c (riscv_type_align): New function.
4875         (riscv_type_alignment): Delete.
4876         (riscv_arg_location): Use 'type_align'.
4877         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4878
4879 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4880
4881         * gdbtypes.c (type_align): A struct with no non-static fields also
4882         has alignment of 1.
4883
4884 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4885
4886         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4887         component to 0.
4888         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4889         member.
4890         (riscv_struct_info::analyse): New implementation using new
4891         analyse_inner member function.
4892         (riscv_struct_info::field_offset): New member function.
4893         (riscv_struct_info::m_offsets): New member variable.
4894         (riscv_struct_info::analyse_inner): New private member function,
4895         takes the old implementation of riscv_struct_info::analyse but
4896         extended to track field offsets.
4897         (riscv_call_arg_struct): Update the struct folding special cases
4898         to handle cases where empty C++ structs, which are non-zero
4899         length, are found.
4900         (riscv_arg_location): Initialise the length of each location, a
4901         non-zero length now indicates the location is in use.
4902         (riscv_push_dummy_call): Allow for the first location having a
4903         non-zero offset when setting up arguments.
4904         (riscv_return_value): Likewise, but for return values.
4905
4906 2019-04-11  Tom Tromey  <tromey@adacore.com>
4907
4908         * utils.c (internal_vproblem): Make "msg" const.
4909
4910 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4911
4912         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4913         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4914         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4915         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4916
4917 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4918
4919         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4920         function.
4921         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4922         of amd64_collect_native_gregset.
4923         (amd64_linux_nat_target::store_registers): Likewise.
4924
4925 2019-04-10  Tom Tromey  <tom@tromey.com>
4926
4927         * symtab.c (lookup_global_symbol_from_objfile)
4928         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4929         * objfiles.h (class separate_debug_iterator): New.
4930         (class separate_debug_range): New.
4931         (struct objfile) <separate_debug_objfiles>: New method.
4932         (objfile_separate_debug_iterate): Don't declare.
4933         * objfiles.c (separate_debug_iterator::operator++): Rename from
4934         objfile_separate_debug_iterate.
4935         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4936         iterator.
4937         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4938         iterator.
4939
4940 2019-04-10  Tom Tromey  <tom@tromey.com>
4941
4942         * symfile.c (reread_symbols): Remove old comment.
4943         * objfiles.c (free_all_objfiles): Fix a typo.
4944
4945 2019-04-10  Tom Tromey  <tom@tromey.com>
4946
4947         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4948         * minsyms.c (lookup_minimal_symbol): Use foreach.
4949         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4950         (lookup_minimal_symbol_solib_trampoline): Likewise.
4951         * symfile.c (reread_symbols): Use foreach.
4952
4953 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4954             Tom Tromey  <tromey@adacore.com>
4955
4956         PR rust/24414:
4957         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4958         (rust_lex_int_test): Change "value" to be LONGEST.
4959         (rust_lex_tests): Add test for long integer literal.
4960
4961 2019-04-09  Tom Tromey  <tromey@adacore.com>
4962
4963         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4964         to bool.
4965         (extended_remote_target::attach): Update.
4966         (remote_target::remote_notice_new_inferior): Update.
4967         (remote_target::add_current_inferior_and_thread): Update.
4968         * inferior.c (exit_inferior_1): Use "false".
4969         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4970
4971 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4972
4973         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4974         the "start" command.
4975
4976 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4977
4978         * python/py-inferior.c (infpy_thread_from_thread_handle):
4979         Adjust comments to reflect renaming of thread_from_thread_handle
4980         to thread_from_handle.  Adjust keywords.  Fix type error message.
4981         (inferior_object_methods): Add thread_from_handle.  Retain
4982         thread_from_thread_handle, but mark it as deprecated.
4983
4984 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4985
4986         * gdbthread.h (find_thread_by_handle): Revise declaration.
4987         * thread.c (find_thread_by_handle): Likewise.  Adjust
4988         implementation too.
4989         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4990         support for buffer objects as handles.
4991
4992 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4993
4994         * python/py-infthread.c (thpy_thread_handle): New function.
4995         (thread_object_methods): Register thpy_thread_handle.
4996
4997 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4998
4999         * gdbthread.h (thread_to_thread_handle): Declare.
5000         * thread.c (gdbtypes.h): Include.
5001         (thread_to_thread_handle): New function.
5002
5003         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5004         (target_thread_info_to_thread_handle): Declare.
5005         * target.c (target_thread_info_to_thread_handle): New function.
5006         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5007         * target-delegates.c: Regenerate.
5008
5009         * linux-thread-db.c (class thread_db_target): Add method
5010         thread_info_to_thread_handle.
5011         (thread_db_target::thread_info_to_thread_handle): Define.
5012         * remote.c (class remote_target): Add new method
5013         thread_info_to_thread_handle.
5014         (remote_target::thread_info_to_thread_handle): Define.
5015
5016 2019-04-08  Pedro Alves  <palves@redhat.com>
5017
5018         * common/common-exceptions.c (throw_exception): Don't create
5019         named object to throw; throw directly.
5020         (throw_it): Likewise.  Don't initialize gdb_exception::message
5021         here, with new; pass FMT and AP to the ctor instead.
5022         * common/common-exceptions.h: Include <string>.
5023         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5024         const char *, va_list)): New ctor.  Use std::make_shared.
5025         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5026         errors)): Delete.
5027         (gdb_exception_error::gdb_exception_error(enum errors, const char
5028         *, va_list)): New.
5029         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5030         Add assertion.
5031         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5032         errors)): Delete.
5033         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5034         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5035         Add assertion.
5036
5037 2019-04-08  Tom Tromey  <tom@tromey.com>
5038
5039         * valops.c (value_rtti_indirect_type): Replace throw_exception
5040         with throw.
5041         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5042         with throw.
5043         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5044         throw.
5045         * target.c (target_translate_tls_address): Replace throw_exception
5046         with throw.
5047         * stack.c (frame_apply_command_count): Replace throw_exception
5048         with throw.
5049         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5050         throw.
5051         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5052         with throw.
5053         * rs6000-tdep.c (rs6000_frame_cache)
5054         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5055         * remote.c: Replace throw_exception with throw.
5056         * record-full.c (record_full_message, record_full_wait_1)
5057         (record_full_restore): Replace throw_exception with throw.
5058         * record-btrace.c:
5059         (get_thread_current_frame_id, record_btrace_start_replaying)
5060         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5061         (cmd_record_btrace_start): Replace throw_exception with throw.
5062         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5063         throw.
5064         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5065         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5066         * linespec.c:
5067         (find_linespec_symbols): Replace throw_exception with throw.
5068         * infrun.c (displaced_step_prepare, resume): Replace
5069         throw_exception with throw.
5070         * infcmd.c (post_create_inferior): Replace throw_exception with
5071         throw.
5072         * inf-loop.c (inferior_event_handler): Replace throw_exception
5073         with throw.
5074         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5075         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5076         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5077         (get_prev_frame_always, get_frame_pc_if_available)
5078         (get_frame_address_in_block_if_available, get_frame_language):
5079         Replace throw_exception with throw.
5080         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5081         throw_exception with throw.
5082         * eval.c (fetch_subexp_value, evaluate_var_value)
5083         (evaluate_funcall, evaluate_subexp_standard): Replace
5084         throw_exception with throw.
5085         * dwarf2loc.c (call_site_find_chain)
5086         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5087         Replace throw_exception with throw.
5088         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5089         with throw.
5090         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5091         throw.
5092         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5093         * completer.c (complete_line_internal): Replace throw_exception
5094         with throw.
5095         * compile/compile-object-run.c (compile_object_run): Replace
5096         throw_exception with throw.
5097         * cli/cli-script.c (process_next_line): Replace throw_exception
5098         with throw.
5099         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5100         (btrace_enable, btrace_maint_update_pt_packets): Replace
5101         throw_exception with throw.
5102         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5103         throw_exception with throw.
5104         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5105         throw_exception with throw.
5106         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5107         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5108         * aarch64-tdep.c (aarch64_make_prologue_cache)
5109         (aarch64_make_stub_cache): Replace throw_exception with throw.
5110
5111 2019-04-08  Tom Tromey  <tom@tromey.com>
5112
5113         * common/common-exceptions.c (throw_exception): Rename from
5114         throw_exception_cxx.  Remove old copy.  Make argument const.
5115         (throw_it): Create and throw exception objects directly.
5116         * common/common-exceptions.h (throw_exception): Make argument
5117         const.
5118         (struct gdb_exception_error): Add constructor.
5119         (struct gdb_exception_quit): Add constructor.
5120
5121 2019-04-08  Tom Tromey  <tom@tromey.com>
5122
5123         * common/common-exceptions.h (exception_rethrow): Don't declare.
5124         (TRY_SJLJ): Update comment.
5125         (TRY, CATCH, END_CATCH): Remove.
5126         * common/common-exceptions.c (exception_rethrow): Remove.
5127
5128 2019-04-08  Tom Tromey  <tom@tromey.com>
5129
5130         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5131         Remove.
5132         (gdb_exception_error): Rename from
5133         gdb_exception_RETURN_MASK_ERROR.
5134         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5135         (gdb_quit_bad_alloc): Update.
5136         * aarch64-tdep.c: Update.
5137         * ada-lang.c: Update.
5138         * ada-typeprint.c: Update.
5139         * ada-valprint.c: Update.
5140         * amd64-tdep.c: Update.
5141         * arch-utils.c: Update.
5142         * break-catch-throw.c: Update.
5143         * breakpoint.c: Update.
5144         * btrace.c: Update.
5145         * c-varobj.c: Update.
5146         * cli/cli-cmds.c: Update.
5147         * cli/cli-interp.c: Update.
5148         * cli/cli-script.c: Update.
5149         * common/common-exceptions.c: Update.
5150         * common/new-op.c: Update.
5151         * common/selftest.c: Update.
5152         * compile/compile-c-symbols.c: Update.
5153         * compile/compile-cplus-symbols.c: Update.
5154         * compile/compile-object-load.c: Update.
5155         * compile/compile-object-run.c: Update.
5156         * completer.c: Update.
5157         * corelow.c: Update.
5158         * cp-abi.c: Update.
5159         * cp-support.c: Update.
5160         * cp-valprint.c: Update.
5161         * darwin-nat.c: Update.
5162         * disasm-selftests.c: Update.
5163         * dtrace-probe.c: Update.
5164         * dwarf-index-cache.c: Update.
5165         * dwarf-index-write.c: Update.
5166         * dwarf2-frame-tailcall.c: Update.
5167         * dwarf2-frame.c: Update.
5168         * dwarf2loc.c: Update.
5169         * dwarf2read.c: Update.
5170         * eval.c: Update.
5171         * event-loop.c: Update.
5172         * event-top.c: Update.
5173         * exec.c: Update.
5174         * f-valprint.c: Update.
5175         * fbsd-tdep.c: Update.
5176         * frame-unwind.c: Update.
5177         * frame.c: Update.
5178         * gdbtypes.c: Update.
5179         * gnu-v3-abi.c: Update.
5180         * guile/guile-internal.h: Update.
5181         * guile/scm-block.c: Update.
5182         * guile/scm-breakpoint.c: Update.
5183         * guile/scm-cmd.c: Update.
5184         * guile/scm-disasm.c: Update.
5185         * guile/scm-frame.c: Update.
5186         * guile/scm-lazy-string.c: Update.
5187         * guile/scm-math.c: Update.
5188         * guile/scm-param.c: Update.
5189         * guile/scm-ports.c: Update.
5190         * guile/scm-pretty-print.c: Update.
5191         * guile/scm-symbol.c: Update.
5192         * guile/scm-symtab.c: Update.
5193         * guile/scm-type.c: Update.
5194         * guile/scm-value.c: Update.
5195         * i386-linux-tdep.c: Update.
5196         * i386-tdep.c: Update.
5197         * inf-loop.c: Update.
5198         * infcall.c: Update.
5199         * infcmd.c: Update.
5200         * infrun.c: Update.
5201         * jit.c: Update.
5202         * language.c: Update.
5203         * linespec.c: Update.
5204         * linux-fork.c: Update.
5205         * linux-nat.c: Update.
5206         * linux-tdep.c: Update.
5207         * linux-thread-db.c: Update.
5208         * main.c: Update.
5209         * mi/mi-cmd-break.c: Update.
5210         * mi/mi-cmd-stack.c: Update.
5211         * mi/mi-interp.c: Update.
5212         * mi/mi-main.c: Update.
5213         * objc-lang.c: Update.
5214         * p-valprint.c: Update.
5215         * parse.c: Update.
5216         * ppc-linux-tdep.c: Update.
5217         * printcmd.c: Update.
5218         * python/py-arch.c: Update.
5219         * python/py-breakpoint.c: Update.
5220         * python/py-cmd.c: Update.
5221         * python/py-finishbreakpoint.c: Update.
5222         * python/py-frame.c: Update.
5223         * python/py-framefilter.c: Update.
5224         * python/py-gdb-readline.c: Update.
5225         * python/py-inferior.c: Update.
5226         * python/py-infthread.c: Update.
5227         * python/py-lazy-string.c: Update.
5228         * python/py-linetable.c: Update.
5229         * python/py-objfile.c: Update.
5230         * python/py-param.c: Update.
5231         * python/py-prettyprint.c: Update.
5232         * python/py-progspace.c: Update.
5233         * python/py-record-btrace.c: Update.
5234         * python/py-record.c: Update.
5235         * python/py-symbol.c: Update.
5236         * python/py-type.c: Update.
5237         * python/py-unwind.c: Update.
5238         * python/py-utils.c: Update.
5239         * python/py-value.c: Update.
5240         * python/python.c: Update.
5241         * record-btrace.c: Update.
5242         * record-full.c: Update.
5243         * remote-fileio.c: Update.
5244         * remote.c: Update.
5245         * riscv-tdep.c: Update.
5246         * rs6000-aix-tdep.c: Update.
5247         * rs6000-tdep.c: Update.
5248         * rust-exp.y: Update.
5249         * rust-lang.c: Update.
5250         * s390-tdep.c: Update.
5251         * selftest-arch.c: Update.
5252         * solib-dsbt.c: Update.
5253         * solib-frv.c: Update.
5254         * solib-spu.c: Update.
5255         * solib-svr4.c: Update.
5256         * solib.c: Update.
5257         * sparc64-linux-tdep.c: Update.
5258         * stack.c: Update.
5259         * symfile-mem.c: Update.
5260         * symmisc.c: Update.
5261         * target.c: Update.
5262         * thread.c: Update.
5263         * top.c: Update.
5264         * tracefile-tfile.c: Update.
5265         * tui/tui.c: Update.
5266         * typeprint.c: Update.
5267         * unittests/cli-utils-selftests.c: Update.
5268         * unittests/parse-connection-spec-selftests.c: Update.
5269         * valops.c: Update.
5270         * valprint.c: Update.
5271         * value.c: Update.
5272         * varobj.c: Update.
5273         * windows-nat.c: Update.
5274         * x86-linux-nat.c: Update.
5275         * xml-support.c: Update.
5276
5277 2019-04-08  Tom Tromey  <tom@tromey.com>
5278
5279         * xml-support.c: Use C++ exception handling.
5280         * x86-linux-nat.c: Use C++ exception handling.
5281         * windows-nat.c: Use C++ exception handling.
5282         * varobj.c: Use C++ exception handling.
5283         * value.c: Use C++ exception handling.
5284         * valprint.c: Use C++ exception handling.
5285         * valops.c: Use C++ exception handling.
5286         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5287         handling.
5288         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5289         * typeprint.c: Use C++ exception handling.
5290         * tui/tui.c: Use C++ exception handling.
5291         * tracefile-tfile.c: Use C++ exception handling.
5292         * top.c: Use C++ exception handling.
5293         * thread.c: Use C++ exception handling.
5294         * target.c: Use C++ exception handling.
5295         * symmisc.c: Use C++ exception handling.
5296         * symfile-mem.c: Use C++ exception handling.
5297         * stack.c: Use C++ exception handling.
5298         * sparc64-linux-tdep.c: Use C++ exception handling.
5299         * solib.c: Use C++ exception handling.
5300         * solib-svr4.c: Use C++ exception handling.
5301         * solib-spu.c: Use C++ exception handling.
5302         * solib-frv.c: Use C++ exception handling.
5303         * solib-dsbt.c: Use C++ exception handling.
5304         * selftest-arch.c: Use C++ exception handling.
5305         * s390-tdep.c: Use C++ exception handling.
5306         * rust-lang.c: Use C++ exception handling.
5307         * rust-exp.y: Use C++ exception handling.
5308         * rs6000-tdep.c: Use C++ exception handling.
5309         * rs6000-aix-tdep.c: Use C++ exception handling.
5310         * riscv-tdep.c: Use C++ exception handling.
5311         * remote.c: Use C++ exception handling.
5312         * remote-fileio.c: Use C++ exception handling.
5313         * record-full.c: Use C++ exception handling.
5314         * record-btrace.c: Use C++ exception handling.
5315         * python/python.c: Use C++ exception handling.
5316         * python/py-value.c: Use C++ exception handling.
5317         * python/py-utils.c: Use C++ exception handling.
5318         * python/py-unwind.c: Use C++ exception handling.
5319         * python/py-type.c: Use C++ exception handling.
5320         * python/py-symbol.c: Use C++ exception handling.
5321         * python/py-record.c: Use C++ exception handling.
5322         * python/py-record-btrace.c: Use C++ exception handling.
5323         * python/py-progspace.c: Use C++ exception handling.
5324         * python/py-prettyprint.c: Use C++ exception handling.
5325         * python/py-param.c: Use C++ exception handling.
5326         * python/py-objfile.c: Use C++ exception handling.
5327         * python/py-linetable.c: Use C++ exception handling.
5328         * python/py-lazy-string.c: Use C++ exception handling.
5329         * python/py-infthread.c: Use C++ exception handling.
5330         * python/py-inferior.c: Use C++ exception handling.
5331         * python/py-gdb-readline.c: Use C++ exception handling.
5332         * python/py-framefilter.c: Use C++ exception handling.
5333         * python/py-frame.c: Use C++ exception handling.
5334         * python/py-finishbreakpoint.c: Use C++ exception handling.
5335         * python/py-cmd.c: Use C++ exception handling.
5336         * python/py-breakpoint.c: Use C++ exception handling.
5337         * python/py-arch.c: Use C++ exception handling.
5338         * printcmd.c: Use C++ exception handling.
5339         * ppc-linux-tdep.c: Use C++ exception handling.
5340         * parse.c: Use C++ exception handling.
5341         * p-valprint.c: Use C++ exception handling.
5342         * objc-lang.c: Use C++ exception handling.
5343         * mi/mi-main.c: Use C++ exception handling.
5344         * mi/mi-interp.c: Use C++ exception handling.
5345         * mi/mi-cmd-stack.c: Use C++ exception handling.
5346         * mi/mi-cmd-break.c: Use C++ exception handling.
5347         * main.c: Use C++ exception handling.
5348         * linux-thread-db.c: Use C++ exception handling.
5349         * linux-tdep.c: Use C++ exception handling.
5350         * linux-nat.c: Use C++ exception handling.
5351         * linux-fork.c: Use C++ exception handling.
5352         * linespec.c: Use C++ exception handling.
5353         * language.c: Use C++ exception handling.
5354         * jit.c: Use C++ exception handling.
5355         * infrun.c: Use C++ exception handling.
5356         * infcmd.c: Use C++ exception handling.
5357         * infcall.c: Use C++ exception handling.
5358         * inf-loop.c: Use C++ exception handling.
5359         * i386-tdep.c: Use C++ exception handling.
5360         * i386-linux-tdep.c: Use C++ exception handling.
5361         * guile/scm-value.c: Use C++ exception handling.
5362         * guile/scm-type.c: Use C++ exception handling.
5363         * guile/scm-symtab.c: Use C++ exception handling.
5364         * guile/scm-symbol.c: Use C++ exception handling.
5365         * guile/scm-pretty-print.c: Use C++ exception handling.
5366         * guile/scm-ports.c: Use C++ exception handling.
5367         * guile/scm-param.c: Use C++ exception handling.
5368         * guile/scm-math.c: Use C++ exception handling.
5369         * guile/scm-lazy-string.c: Use C++ exception handling.
5370         * guile/scm-frame.c: Use C++ exception handling.
5371         * guile/scm-disasm.c: Use C++ exception handling.
5372         * guile/scm-cmd.c: Use C++ exception handling.
5373         * guile/scm-breakpoint.c: Use C++ exception handling.
5374         * guile/scm-block.c: Use C++ exception handling.
5375         * guile/guile-internal.h: Use C++ exception handling.
5376         * gnu-v3-abi.c: Use C++ exception handling.
5377         * gdbtypes.c: Use C++ exception handling.
5378         * frame.c: Use C++ exception handling.
5379         * frame-unwind.c: Use C++ exception handling.
5380         * fbsd-tdep.c: Use C++ exception handling.
5381         * f-valprint.c: Use C++ exception handling.
5382         * exec.c: Use C++ exception handling.
5383         * event-top.c: Use C++ exception handling.
5384         * event-loop.c: Use C++ exception handling.
5385         * eval.c: Use C++ exception handling.
5386         * dwarf2read.c: Use C++ exception handling.
5387         * dwarf2loc.c: Use C++ exception handling.
5388         * dwarf2-frame.c: Use C++ exception handling.
5389         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5390         * dwarf-index-write.c: Use C++ exception handling.
5391         * dwarf-index-cache.c: Use C++ exception handling.
5392         * dtrace-probe.c: Use C++ exception handling.
5393         * disasm-selftests.c: Use C++ exception handling.
5394         * darwin-nat.c: Use C++ exception handling.
5395         * cp-valprint.c: Use C++ exception handling.
5396         * cp-support.c: Use C++ exception handling.
5397         * cp-abi.c: Use C++ exception handling.
5398         * corelow.c: Use C++ exception handling.
5399         * completer.c: Use C++ exception handling.
5400         * compile/compile-object-run.c: Use C++ exception handling.
5401         * compile/compile-object-load.c: Use C++ exception handling.
5402         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5403         * compile/compile-c-symbols.c: Use C++ exception handling.
5404         * common/selftest.c: Use C++ exception handling.
5405         * common/new-op.c: Use C++ exception handling.
5406         * cli/cli-script.c: Use C++ exception handling.
5407         * cli/cli-interp.c: Use C++ exception handling.
5408         * cli/cli-cmds.c: Use C++ exception handling.
5409         * c-varobj.c: Use C++ exception handling.
5410         * btrace.c: Use C++ exception handling.
5411         * breakpoint.c: Use C++ exception handling.
5412         * break-catch-throw.c: Use C++ exception handling.
5413         * arch-utils.c: Use C++ exception handling.
5414         * amd64-tdep.c: Use C++ exception handling.
5415         * ada-valprint.c: Use C++ exception handling.
5416         * ada-typeprint.c: Use C++ exception handling.
5417         * ada-lang.c: Use C++ exception handling.
5418         * aarch64-tdep.c: Use C++ exception handling.
5419
5420 2019-04-08  Tom Tromey  <tom@tromey.com>
5421
5422         * xml-support.c (gdb_xml_parser::parse): Update.
5423         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5424         * value.c (show_convenience): Update.
5425         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5426         (test_parse_flags_qcs): Update.
5427         * thread.c (thr_try_catch_cmd): Update.
5428         * target.c (target_translate_tls_address): Update.
5429         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5430         (info_frame_command_core, frame_apply_command_count): Update.
5431         * rust-exp.y (rust_lex_exception_test): Update.
5432         * riscv-tdep.c (riscv_print_one_register_info): Update.
5433         * remote.c (remote_target::enable_btrace): Update.
5434         * record-btrace.c (record_btrace_enable_warn): Update.
5435         * python/py-utils.c (gdbpy_convert_exception): Update.
5436         * printcmd.c (do_one_display, print_variable_and_value): Update.
5437         * mi/mi-main.c (mi_print_exception): Update.
5438         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5439         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5440         * linux-nat.c (linux_nat_target::attach): Update.
5441         * linux-fork.c (class scoped_switch_fork_info): Update.
5442         * infrun.c (displaced_step_prepare): Update.
5443         * infcall.c (call_function_by_hand_dummy): Update.
5444         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5445         * gnu-v3-abi.c (print_one_vtable): Update.
5446         * frame.c (get_prev_frame_always): Update.
5447         * f-valprint.c (info_common_command_for_block): Update.
5448         * exec.c (try_open_exec_file): Update.
5449         * exceptions.c (print_exception, exception_print)
5450         (exception_fprintf, exception_print_same): Update.
5451         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5452         * dwarf-index-cache.c (index_cache::store)
5453         (index_cache::lookup_gdb_index): Update.
5454         * darwin-nat.c (maybe_cache_shell): Update.
5455         * cp-valprint.c (cp_print_value_fields): Update.
5456         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5457         (gcc_cplus_symbol_address): Update.
5458         * compile/compile-c-symbols.c (gcc_convert_symbol)
5459         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5460         * common/selftest.c: Update.
5461         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5462         a std::string.
5463         (exception_try_scope_entry, exception_try_scope_exit): Don't
5464         declare.
5465         (struct exception_try_scope): Remove.
5466         (TRY): Don't use exception_try_scope.
5467         (struct gdb_exception): Add constructor, operator=.
5468         <what>: New method.
5469         (struct gdb_exception_RETURN_MASK_ALL)
5470         (struct gdb_exception_RETURN_MASK_ERROR)
5471         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5472         (struct gdb_quit_bad_alloc): Update.
5473         * common/common-exceptions.c (exception_none): Change
5474         initializer.
5475         (struct catcher) <state, exception>: Initialize inline.
5476         <prev>: Remove member.
5477         (current_catcher): Remove.
5478         (catchers): New global.
5479         (exceptions_state_mc_init): Simplify.
5480         (catcher_pop): Remove.
5481         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5482         (try_scope_depth, exception_try_scope_entry)
5483         (exception_try_scope_exit): Remove.
5484         (throw_exception_sjlj): Update.
5485         (exception_messages, exception_messages_size): Remove.
5486         (throw_it): Simplify.
5487         (gdb_exception_sliced_copy): Remove.
5488         (throw_exception_cxx): Update.
5489         * cli/cli-script.c (script_from_file): Update.
5490         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5491         Update.
5492         * ada-valprint.c (ada_val_print): Update.
5493         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5494         (create_excep_cond_exprs): Update.
5495
5496 2019-04-08  Tom Tromey  <tom@tromey.com>
5497
5498         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5499         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5500         (TRY, CATCH, END_CATCH): Remove some definitions.
5501         * common/common-exceptions.c: Don't use GDB_XCPT.
5502         (catcher_list_size): Remove.
5503         (throw_exception, throw_it): Simplify.
5504
5505 2019-04-05  Tom Tromey  <tom@tromey.com>
5506
5507         Revert the header-sorting patch.
5508         * ft32-tdep.c: Revert.
5509         * frv-tdep.c: Revert.
5510         * frv-linux-tdep.c: Revert.
5511         * frame.c: Revert.
5512         * frame-unwind.c: Revert.
5513         * frame-base.c: Revert.
5514         * fork-child.c: Revert.
5515         * findvar.c: Revert.
5516         * findcmd.c: Revert.
5517         * filesystem.c: Revert.
5518         * filename-seen-cache.h: Revert.
5519         * filename-seen-cache.c: Revert.
5520         * fbsd-tdep.c: Revert.
5521         * fbsd-nat.h: Revert.
5522         * fbsd-nat.c: Revert.
5523         * f-valprint.c: Revert.
5524         * f-typeprint.c: Revert.
5525         * f-lang.c: Revert.
5526         * extension.h: Revert.
5527         * extension.c: Revert.
5528         * extension-priv.h: Revert.
5529         * expprint.c: Revert.
5530         * exec.h: Revert.
5531         * exec.c: Revert.
5532         * exceptions.c: Revert.
5533         * event-top.c: Revert.
5534         * event-loop.c: Revert.
5535         * eval.c: Revert.
5536         * elfread.c: Revert.
5537         * dwarf2read.h: Revert.
5538         * dwarf2read.c: Revert.
5539         * dwarf2loc.c: Revert.
5540         * dwarf2expr.h: Revert.
5541         * dwarf2expr.c: Revert.
5542         * dwarf2-frame.c: Revert.
5543         * dwarf2-frame-tailcall.c: Revert.
5544         * dwarf-index-write.h: Revert.
5545         * dwarf-index-write.c: Revert.
5546         * dwarf-index-common.c: Revert.
5547         * dwarf-index-cache.h: Revert.
5548         * dwarf-index-cache.c: Revert.
5549         * dummy-frame.c: Revert.
5550         * dtrace-probe.c: Revert.
5551         * disasm.h: Revert.
5552         * disasm.c: Revert.
5553         * disasm-selftests.c: Revert.
5554         * dictionary.c: Revert.
5555         * dicos-tdep.c: Revert.
5556         * demangle.c: Revert.
5557         * dcache.h: Revert.
5558         * dcache.c: Revert.
5559         * darwin-nat.h: Revert.
5560         * darwin-nat.c: Revert.
5561         * darwin-nat-info.c: Revert.
5562         * d-valprint.c: Revert.
5563         * d-namespace.c: Revert.
5564         * d-lang.c: Revert.
5565         * ctf.c: Revert.
5566         * csky-tdep.c: Revert.
5567         * csky-linux-tdep.c: Revert.
5568         * cris-tdep.c: Revert.
5569         * cris-linux-tdep.c: Revert.
5570         * cp-valprint.c: Revert.
5571         * cp-support.c: Revert.
5572         * cp-namespace.c: Revert.
5573         * cp-abi.c: Revert.
5574         * corelow.c: Revert.
5575         * corefile.c: Revert.
5576         * continuations.c: Revert.
5577         * completer.h: Revert.
5578         * completer.c: Revert.
5579         * complaints.c: Revert.
5580         * coffread.c: Revert.
5581         * coff-pe-read.c: Revert.
5582         * cli-out.h: Revert.
5583         * cli-out.c: Revert.
5584         * charset.c: Revert.
5585         * c-varobj.c: Revert.
5586         * c-valprint.c: Revert.
5587         * c-typeprint.c: Revert.
5588         * c-lang.c: Revert.
5589         * buildsym.c: Revert.
5590         * buildsym-legacy.c: Revert.
5591         * build-id.h: Revert.
5592         * build-id.c: Revert.
5593         * btrace.c: Revert.
5594         * bsd-uthread.c: Revert.
5595         * breakpoint.h: Revert.
5596         * breakpoint.c: Revert.
5597         * break-catch-throw.c: Revert.
5598         * break-catch-syscall.c: Revert.
5599         * break-catch-sig.c: Revert.
5600         * blockframe.c: Revert.
5601         * block.c: Revert.
5602         * bfin-tdep.c: Revert.
5603         * bfin-linux-tdep.c: Revert.
5604         * bfd-target.c: Revert.
5605         * bcache.c: Revert.
5606         * ax-general.c: Revert.
5607         * ax-gdb.h: Revert.
5608         * ax-gdb.c: Revert.
5609         * avr-tdep.c: Revert.
5610         * auxv.c: Revert.
5611         * auto-load.c: Revert.
5612         * arm-wince-tdep.c: Revert.
5613         * arm-tdep.c: Revert.
5614         * arm-symbian-tdep.c: Revert.
5615         * arm-pikeos-tdep.c: Revert.
5616         * arm-obsd-tdep.c: Revert.
5617         * arm-nbsd-tdep.c: Revert.
5618         * arm-nbsd-nat.c: Revert.
5619         * arm-linux-tdep.c: Revert.
5620         * arm-linux-nat.c: Revert.
5621         * arm-fbsd-tdep.c: Revert.
5622         * arm-fbsd-nat.c: Revert.
5623         * arm-bsd-tdep.c: Revert.
5624         * arch-utils.c: Revert.
5625         * arc-tdep.c: Revert.
5626         * arc-newlib-tdep.c: Revert.
5627         * annotate.h: Revert.
5628         * annotate.c: Revert.
5629         * amd64-windows-tdep.c: Revert.
5630         * amd64-windows-nat.c: Revert.
5631         * amd64-tdep.c: Revert.
5632         * amd64-sol2-tdep.c: Revert.
5633         * amd64-obsd-tdep.c: Revert.
5634         * amd64-obsd-nat.c: Revert.
5635         * amd64-nbsd-tdep.c: Revert.
5636         * amd64-nbsd-nat.c: Revert.
5637         * amd64-nat.c: Revert.
5638         * amd64-linux-tdep.c: Revert.
5639         * amd64-linux-nat.c: Revert.
5640         * amd64-fbsd-tdep.c: Revert.
5641         * amd64-fbsd-nat.c: Revert.
5642         * amd64-dicos-tdep.c: Revert.
5643         * amd64-darwin-tdep.c: Revert.
5644         * amd64-bsd-nat.c: Revert.
5645         * alpha-tdep.c: Revert.
5646         * alpha-obsd-tdep.c: Revert.
5647         * alpha-nbsd-tdep.c: Revert.
5648         * alpha-mdebug-tdep.c: Revert.
5649         * alpha-linux-tdep.c: Revert.
5650         * alpha-linux-nat.c: Revert.
5651         * alpha-bsd-tdep.c: Revert.
5652         * alpha-bsd-nat.c: Revert.
5653         * aix-thread.c: Revert.
5654         * agent.c: Revert.
5655         * addrmap.c: Revert.
5656         * ada-varobj.c: Revert.
5657         * ada-valprint.c: Revert.
5658         * ada-typeprint.c: Revert.
5659         * ada-tasks.c: Revert.
5660         * ada-lang.c: Revert.
5661         * aarch64-tdep.c: Revert.
5662         * aarch64-ravenscar-thread.c: Revert.
5663         * aarch64-newlib-tdep.c: Revert.
5664         * aarch64-linux-tdep.c: Revert.
5665         * aarch64-linux-nat.c: Revert.
5666         * aarch64-fbsd-tdep.c: Revert.
5667         * aarch64-fbsd-nat.c: Revert.
5668         * aarch32-linux-nat.c: Revert.
5669
5670 2019-04-05  Tom Tromey  <tom@tromey.com>
5671
5672         * ft32-tdep.c: Sort headers.
5673         * frv-tdep.c: Sort headers.
5674         * frv-linux-tdep.c: Sort headers.
5675         * frame.c: Sort headers.
5676         * frame-unwind.c: Sort headers.
5677         * frame-base.c: Sort headers.
5678         * fork-child.c: Sort headers.
5679         * findvar.c: Sort headers.
5680         * findcmd.c: Sort headers.
5681         * filesystem.c: Sort headers.
5682         * filename-seen-cache.h: Sort headers.
5683         * filename-seen-cache.c: Sort headers.
5684         * fbsd-tdep.c: Sort headers.
5685         * fbsd-nat.h: Sort headers.
5686         * fbsd-nat.c: Sort headers.
5687         * f-valprint.c: Sort headers.
5688         * f-typeprint.c: Sort headers.
5689         * f-lang.c: Sort headers.
5690         * extension.h: Sort headers.
5691         * extension.c: Sort headers.
5692         * extension-priv.h: Sort headers.
5693         * expprint.c: Sort headers.
5694         * exec.h: Sort headers.
5695         * exec.c: Sort headers.
5696         * exceptions.c: Sort headers.
5697         * event-top.c: Sort headers.
5698         * event-loop.c: Sort headers.
5699         * eval.c: Sort headers.
5700         * elfread.c: Sort headers.
5701         * dwarf2read.h: Sort headers.
5702         * dwarf2read.c: Sort headers.
5703         * dwarf2loc.c: Sort headers.
5704         * dwarf2expr.h: Sort headers.
5705         * dwarf2expr.c: Sort headers.
5706         * dwarf2-frame.c: Sort headers.
5707         * dwarf2-frame-tailcall.c: Sort headers.
5708         * dwarf-index-write.h: Sort headers.
5709         * dwarf-index-write.c: Sort headers.
5710         * dwarf-index-common.c: Sort headers.
5711         * dwarf-index-cache.h: Sort headers.
5712         * dwarf-index-cache.c: Sort headers.
5713         * dummy-frame.c: Sort headers.
5714         * dtrace-probe.c: Sort headers.
5715         * disasm.h: Sort headers.
5716         * disasm.c: Sort headers.
5717         * disasm-selftests.c: Sort headers.
5718         * dictionary.c: Sort headers.
5719         * dicos-tdep.c: Sort headers.
5720         * demangle.c: Sort headers.
5721         * dcache.h: Sort headers.
5722         * dcache.c: Sort headers.
5723         * darwin-nat.h: Sort headers.
5724         * darwin-nat.c: Sort headers.
5725         * darwin-nat-info.c: Sort headers.
5726         * d-valprint.c: Sort headers.
5727         * d-namespace.c: Sort headers.
5728         * d-lang.c: Sort headers.
5729         * ctf.c: Sort headers.
5730         * csky-tdep.c: Sort headers.
5731         * csky-linux-tdep.c: Sort headers.
5732         * cris-tdep.c: Sort headers.
5733         * cris-linux-tdep.c: Sort headers.
5734         * cp-valprint.c: Sort headers.
5735         * cp-support.c: Sort headers.
5736         * cp-namespace.c: Sort headers.
5737         * cp-abi.c: Sort headers.
5738         * corelow.c: Sort headers.
5739         * corefile.c: Sort headers.
5740         * continuations.c: Sort headers.
5741         * completer.h: Sort headers.
5742         * completer.c: Sort headers.
5743         * complaints.c: Sort headers.
5744         * coffread.c: Sort headers.
5745         * coff-pe-read.c: Sort headers.
5746         * cli-out.h: Sort headers.
5747         * cli-out.c: Sort headers.
5748         * charset.c: Sort headers.
5749         * c-varobj.c: Sort headers.
5750         * c-valprint.c: Sort headers.
5751         * c-typeprint.c: Sort headers.
5752         * c-lang.c: Sort headers.
5753         * buildsym.c: Sort headers.
5754         * buildsym-legacy.c: Sort headers.
5755         * build-id.h: Sort headers.
5756         * build-id.c: Sort headers.
5757         * btrace.c: Sort headers.
5758         * bsd-uthread.c: Sort headers.
5759         * breakpoint.h: Sort headers.
5760         * breakpoint.c: Sort headers.
5761         * break-catch-throw.c: Sort headers.
5762         * break-catch-syscall.c: Sort headers.
5763         * break-catch-sig.c: Sort headers.
5764         * blockframe.c: Sort headers.
5765         * block.c: Sort headers.
5766         * bfin-tdep.c: Sort headers.
5767         * bfin-linux-tdep.c: Sort headers.
5768         * bfd-target.c: Sort headers.
5769         * bcache.c: Sort headers.
5770         * ax-general.c: Sort headers.
5771         * ax-gdb.h: Sort headers.
5772         * ax-gdb.c: Sort headers.
5773         * avr-tdep.c: Sort headers.
5774         * auxv.c: Sort headers.
5775         * auto-load.c: Sort headers.
5776         * arm-wince-tdep.c: Sort headers.
5777         * arm-tdep.c: Sort headers.
5778         * arm-symbian-tdep.c: Sort headers.
5779         * arm-pikeos-tdep.c: Sort headers.
5780         * arm-obsd-tdep.c: Sort headers.
5781         * arm-nbsd-tdep.c: Sort headers.
5782         * arm-nbsd-nat.c: Sort headers.
5783         * arm-linux-tdep.c: Sort headers.
5784         * arm-linux-nat.c: Sort headers.
5785         * arm-fbsd-tdep.c: Sort headers.
5786         * arm-fbsd-nat.c: Sort headers.
5787         * arm-bsd-tdep.c: Sort headers.
5788         * arch-utils.c: Sort headers.
5789         * arc-tdep.c: Sort headers.
5790         * arc-newlib-tdep.c: Sort headers.
5791         * annotate.h: Sort headers.
5792         * annotate.c: Sort headers.
5793         * amd64-windows-tdep.c: Sort headers.
5794         * amd64-windows-nat.c: Sort headers.
5795         * amd64-tdep.c: Sort headers.
5796         * amd64-sol2-tdep.c: Sort headers.
5797         * amd64-obsd-tdep.c: Sort headers.
5798         * amd64-obsd-nat.c: Sort headers.
5799         * amd64-nbsd-tdep.c: Sort headers.
5800         * amd64-nbsd-nat.c: Sort headers.
5801         * amd64-nat.c: Sort headers.
5802         * amd64-linux-tdep.c: Sort headers.
5803         * amd64-linux-nat.c: Sort headers.
5804         * amd64-fbsd-tdep.c: Sort headers.
5805         * amd64-fbsd-nat.c: Sort headers.
5806         * amd64-dicos-tdep.c: Sort headers.
5807         * amd64-darwin-tdep.c: Sort headers.
5808         * amd64-bsd-nat.c: Sort headers.
5809         * alpha-tdep.c: Sort headers.
5810         * alpha-obsd-tdep.c: Sort headers.
5811         * alpha-nbsd-tdep.c: Sort headers.
5812         * alpha-mdebug-tdep.c: Sort headers.
5813         * alpha-linux-tdep.c: Sort headers.
5814         * alpha-linux-nat.c: Sort headers.
5815         * alpha-bsd-tdep.c: Sort headers.
5816         * alpha-bsd-nat.c: Sort headers.
5817         * aix-thread.c: Sort headers.
5818         * agent.c: Sort headers.
5819         * addrmap.c: Sort headers.
5820         * ada-varobj.c: Sort headers.
5821         * ada-valprint.c: Sort headers.
5822         * ada-typeprint.c: Sort headers.
5823         * ada-tasks.c: Sort headers.
5824         * ada-lang.c: Sort headers.
5825         * aarch64-tdep.c: Sort headers.
5826         * aarch64-ravenscar-thread.c: Sort headers.
5827         * aarch64-newlib-tdep.c: Sort headers.
5828         * aarch64-linux-tdep.c: Sort headers.
5829         * aarch64-linux-nat.c: Sort headers.
5830         * aarch64-fbsd-tdep.c: Sort headers.
5831         * aarch64-fbsd-nat.c: Sort headers.
5832         * aarch32-linux-nat.c: Sort headers.
5833
5834 2019-04-04  Tom Tromey  <tom@tromey.com>
5835
5836         * varobj.c (varobj_create): Update.
5837         * rust-exp.y (struct rust_parser) <update_innermost_block,
5838         lookup_symbol>: New methods.
5839         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5840         Rename.
5841         (rust_parser::rust_lookup_type)
5842         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5843         * printcmd.c (display_command, do_one_display): Update.
5844         * parser-defs.h (struct parser_state) <parser_state>: Add
5845         "tracker" parameter.
5846         (block_tracker): New member.
5847         (class innermost_block_tracker) <innermost_block_tracker>: Add
5848         "types" parameter.
5849         <reset>: Remove method.
5850         (innermost_block): Don't declare.
5851         (null_post_parser): Update.
5852         * parse.c (innermost_block): Remove global.
5853         (write_dollar_variable): Update.
5854         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5855         Remove "tracker_types" parameter.
5856         (parse_expression): Add "tracker" parameter.
5857         (parse_expression_for_completion): Update.
5858         (null_post_parser): Add "tracker" parameter.
5859         * p-exp.y: Update rules.
5860         * m2-exp.y: Update rules.
5861         * language.h (struct language_defn) <la_post_parser>: Add
5862         "tracker" parameter.
5863         * go-exp.y: Update rules.
5864         * f-exp.y: Update rules.
5865         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5866         parameter.
5867         * d-exp.y: Update rules.
5868         * c-exp.y: Update rules.
5869         * breakpoint.c (set_breakpoint_condition): Create an
5870         innermost_block_tracker.
5871         (watch_command_1): Likewise.
5872         * ada-lang.c (resolve): Add "tracker" parameter.
5873         (resolve_subexp): Likewise.
5874         * ada-exp.y (write_var_from_sym): Update.
5875
5876 2019-04-04  Tom Tromey  <tom@tromey.com>
5877
5878         * type-stack.h: New file.
5879         * type-stack.c: New file.
5880         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5881         type-stack.h.
5882         (insert_into_type_stack, insert_type, push_type, push_type_int)
5883         (insert_type_address_space, pop_type, pop_type_int)
5884         (pop_typelist, pop_type_stack, append_type_stack)
5885         (push_type_stack, get_type_stack, push_typelist)
5886         (follow_type_instance_flags, follow_types): Don't declare.
5887         * parse.c (type_stack): Remove global.
5888         (parse_exp_in_context): Update.
5889         (insert_into_type_stack, insert_type, push_type, push_type_int)
5890         (insert_type_address_space, pop_type, pop_type_int)
5891         (pop_typelist, pop_type_stack, append_type_stack)
5892         (push_type_stack, get_type_stack, push_typelist)
5893         (follow_type_instance_flags, follow_types): Remove (moved to
5894         type-stack.c).
5895         * f-exp.y (type_stack): New global.
5896         Update rules.
5897         (push_kind_type, f_parse): Update.
5898         * d-exp.y (type_stack): New global.
5899         Update rules.
5900         (d_parse): Update.
5901         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5902         Update rules.
5903         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5904         (HFILES_NO_SRCDIR): Add type-stack.h.
5905
5906 2019-04-04  Tom Tromey  <tom@tromey.com>
5907
5908         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5909         (rust_parser::convert_ast_to_expression, rust_parse)
5910         (rust_lex_test_completion, rust_lex_tests): Update.
5911         * parser-defs.h (struct expr_completion_state): New.
5912         (struct parser_state) <parser_state>: Add completion parameter.
5913         <mark_struct_expression, mark_completion_tag>: New methods.
5914         <parse_completion, m_completion_state>: New members.
5915         (prefixify_expression, null_post_parser): Update.
5916         (mark_struct_expression, mark_completion_tag): Don't declare.
5917         * parse.c (parse_completion, expout_last_struct)
5918         (expout_tag_completion_type, expout_completion_name): Remove
5919         globals.
5920         (parser_state::mark_struct_expression)
5921         (parser_state::mark_completion_tag): Now methods.
5922         (prefixify_expression): Add last_struct parameter.
5923         (prefixify_subexp): Likewise.
5924         (parse_exp_1): Update.
5925         (parse_exp_in_context): Add cstate parameter.  Update.
5926         (parse_expression_for_completion): Create an
5927         expr_completion_state.
5928         (null_post_parser): Add "completion" parameter.
5929         * p-exp.y: Update rules.
5930         (yylex): Update.
5931         * language.h (struct language_defn) <la_post_parser>: Add
5932         "completing" parameter.
5933         * go-exp.y: Update rules.
5934         (lex_one_token): Update.
5935         * expression.h (parse_completion): Don't declare.
5936         * d-exp.y: Update rules.
5937         (lex_one_token): Update rules.
5938         * c-exp.y: Update rules.
5939         (lex_one_token): Update.
5940         * ada-lang.c (resolve): Add "parse_completion" parameter.
5941         (resolve_subexp): Likewise.
5942         (ada_resolve_function): Likewise.
5943
5944 2019-04-04  Tom Tromey  <tom@tromey.com>
5945
5946         * parser-defs.h (struct parser_state) <start_arglist,
5947         end_arglist>: New methods.
5948         <arglist_len, m_funcall_chain>: New members.
5949         (arglist_len, start_arglist, end_arglist): Don't declare.
5950         * parse.c (arglist_len, funcall_chain): Remove global.
5951         (start_arglist, end_arglist): Remove functions.
5952         (parse_exp_in_context): Update.
5953         * p-exp.y: Update rules.
5954         * m2-exp.y: Update rules.
5955         * go-exp.y: Update rules.
5956         * f-exp.y: Update rules.
5957         * d-exp.y: Update rules.
5958         * c-exp.y: Update rules.
5959
5960 2019-04-04  Tom Tromey  <tom@tromey.com>
5961
5962         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5963         lex_operator, push_back>: New methods.
5964         Update all rules.
5965         (rust_parser::lex_hex, lex_escape): Rename and update.
5966         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5967         (rust_parser::lex_operator): Rename and update.
5968         (rust_parser::lex_number, rustyylex, rustyyerror)
5969         (rust_lex_test_init, rust_lex_test_sequence)
5970         (rust_lex_test_push_back, rust_lex_tests): Update.
5971         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5972         parameter.
5973         <lexptr, prev_lexptr>: New members.
5974         (lexptr, prev_lexptr): Don't declare.
5975         * parse.c (lexptr, prev_lexptr): Remove globals.
5976         (parse_exp_in_context): Update.
5977         * p-exp.y (yylex, yyerror): Update.
5978         * m2-exp.y (parse_number, yylex, yyerror): Update.
5979         * go-exp.y (lex_one_token, yyerror): Update.
5980         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5981         * d-exp.y (lex_one_token, yyerror): Update.
5982         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5983         (lex_one_token, yyerror): Update.
5984         * ada-lex.l (YY_INPUT): Update.
5985         (rewind_to_char): Update.
5986         * ada-exp.y (yyerror): Update.
5987
5988 2019-04-04  Tom Tromey  <tom@tromey.com>
5989
5990         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5991         * parser-defs.h (struct parser_state) <parser_state>: Add new
5992         parameter.
5993         <comma_terminates>: New member.
5994         (comma_terminates): Don't declare global.
5995         * parse.c (comma_terminates): Remove global.
5996         (parse_exp_in_context): Update.
5997         * p-exp.y (yylex): Update.
5998         * m2-exp.y (yylex): Update.
5999         * go-exp.y (lex_one_token): Update.
6000         * f-exp.y (yylex): Update.
6001         * d-exp.y (lex_one_token): Update.
6002         * c-exp.y (lex_one_token): Update.
6003         * ada-lex.l: Update.
6004
6005 2019-04-04  Tom Tromey  <tom@tromey.com>
6006
6007         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6008         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6009         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6010         * parser-defs.h (paren_depth): Don't declare.
6011         * parse.c (paren_depth): Remove global.
6012         (parse_exp_in_context): Update.
6013         * p-exp.y (paren_depth): New global.
6014         (pascal_parse): Initialize it.
6015         * m2-exp.y (paren_depth): New global.
6016         (m2_parse): Initialize it.
6017         * go-exp.y (paren_depth): New global.
6018         (go_parse): Initialize it.
6019         * f-exp.y (paren_depth): New global.
6020         (f_parse): Initialize it.
6021         * d-exp.y (paren_depth): New global.
6022         (d_parse): Initialize it.
6023         * c-exp.y (paren_depth): New global.
6024         (c_parse): Initialize it.
6025         * ada-lex.l (paren_depth): New global.
6026         (lexer_init): Initialize it.
6027
6028 2019-04-04  Tom Tromey  <tom@tromey.com>
6029
6030         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6031         (rust_parser::convert_ast_to_type)
6032         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6033         * parser-defs.h (struct parser_state) <parser_state>: Add
6034         parameters.  Initialize new members.
6035         <expression_context_block, expression_context_pc>: New members.
6036         * parse.c (expression_context_block, expression_context_pc):
6037         Remove globals.
6038         (parse_exp_in_context): Update.
6039         * p-exp.y: Update all rules.
6040         (yylex): Update.
6041         * m2-exp.y: Update all rules.
6042         (yylex): Update.
6043         * go-exp.y (yylex): Update.
6044         * f-exp.y (yylex): Update.
6045         * d-exp.y: Update all rules.
6046         (yylex): Update.
6047         * c-exp.y: Update all rules.
6048         (lex_one_token, classify_name, yylex, c_parse): Update.
6049         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6050
6051 2019-04-04  Tom Tromey  <tom@tromey.com>
6052
6053         * gdbarch.h, gdbarch.c: Rebuild.
6054         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6055         * stap-probe.h:
6056         (struct stap_parse_info): Replace "parser_state" with
6057         "expr_builder".
6058         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6059         (parser_state): New class.
6060         * parse.c (expr_builder): Rename.
6061         (expr_builder::release): Rename.
6062         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6063         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6064         (write_exp_elt_longcst, write_exp_elt_floatcst)
6065         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6066         (write_exp_string_vector, write_exp_bitstring)
6067         (write_exp_msymbol, mark_struct_expression)
6068         (write_dollar_variable)
6069         (insert_type_address_space, increase_expout_size): Replace
6070         "parser_state" with "expr_builder".
6071         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6072         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6073         "parser_state" with "expr_builder".
6074
6075 2019-04-04  Tom Tromey  <tom@tromey.com>
6076
6077         * rust-exp.y: Replace "parse_language" with method call.
6078         * p-exp.y:
6079         (yylex): Replace "parse_language" with method call.
6080         * m2-exp.y:
6081         (yylex): Replace "parse_language" with method call.
6082         * go-exp.y (classify_name): Replace "parse_language" with method
6083         call.
6084         * f-exp.y (yylex): Replace "parse_language" with method call.
6085         * d-exp.y (lex_one_token): Replace "parse_language" with method
6086         call.
6087         * c-exp.y:
6088         (lex_one_token, classify_name, yylex): Replace "parse_language"
6089         with method call.
6090         * ada-exp.y (find_primitive_type, type_char)
6091         (type_system_address): Replace "parse_language" with method call.
6092
6093 2019-04-04  Tom Tromey  <tom@tromey.com>
6094
6095         * rust-exp.y: Replace "parse_gdbarch" with method call.
6096         * parse.c (write_dollar_variable, insert_type_address_space):
6097         Replace "parse_gdbarch" with method call.
6098         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6099         call.
6100         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6101         call.
6102         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6103         "parse_gdbarch" with method call.
6104         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6105         with method call.
6106         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6107         "parse_gdbarch" with method call.
6108         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6109         "parse_gdbarch" with method call.
6110         * c-exp.y (parse_type, parse_number, classify_name): Replace
6111         "parse_gdbarch" with method call.
6112         * ada-lex.l: Replace "parse_gdbarch" with method call.
6113         * ada-exp.y (parse_type, find_primitive_type, type_char)
6114         (type_system_address): Replace "parse_gdbarch" with method call.
6115
6116 2019-04-04  Tom Tromey  <tom@tromey.com>
6117
6118         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6119         * stap-probe.c (stap_parse_argument): Update.
6120         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6121         initial_size parameter.
6122         * rust-exp.y (rust_lex_tests): Update.
6123         * parse.c (parser_state): Update.
6124         (parse_exp_in_context): Update.
6125         * parser-defs.h (struct parser_state) <parser_state>: Remove
6126         "initial_size" parameter.
6127
6128 2019-04-04  Tom Tromey  <tom@tromey.com>
6129
6130         * parser-defs.h (increase_expout_size): Don't declare.
6131         * parse.c (increase_expout_size): Now static.
6132
6133 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6134
6135         * gnu-nat.c (gnu_nat_target::wait): Fix
6136         target_waitstatus_to_string call.
6137
6138 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6139
6140         * eval.c (evaluate_subexp_standard): Handle internal functions
6141         during Fortran function call handling.
6142
6143 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6144
6145         * NEWS: Mention new internal functions.
6146         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6147         (read_base_type): Use dwarf2_init_complex_target_type.
6148         * value.c (creal_internal_fn): New function.
6149         (cimag_internal_fn): New function.
6150         (_initialize_values): Register new internal functions.
6151
6152 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6153
6154         * infrun.c (stop_all_threads): If debug_infrun, always
6155         trace the wait status after wait_one, using
6156         target_waitstatus_to_string and target_pid_to_str.
6157         (handle_inferior_event): Replace various trace of
6158         wait status kind by a single trace.
6159         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6160         wait status kind image by target_waitstatus_to_string.
6161         * target/waitstatus.c (target_waitstatus_to_string): Fix
6162         obsolete comment.
6163
6164 2019-04-01  Tom Tromey  <tromey@adacore.com>
6165
6166         PR symtab/23331:
6167         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6168
6169 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6170             Pedro Alves  <palves@redhat.com>
6171
6172         * top.c (quit_force): Call 'finalize_values'.
6173         * value.c (finalize_values): New function.
6174         * value.h (finalize_values): Declare.
6175
6176 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6177
6178         * NEWS: Announce $_gdb_major and $_gdb_minor.
6179
6180         * top.c (init_gdb_version_vars): New function.
6181         (gdb_init): Call init_gdb_version_vars.
6182
6183 2019-03-29  Tom Tromey  <tromey@adacore.com>
6184
6185         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6186         help text.  Remove dead code.
6187
6188 2019-03-29  Keith Seitz  <keiths@redhat.com>
6189
6190         From Siddhesh Poyarekar:
6191         * f-lang.h (f77_get_upperbound): Return LONGEST.
6192         (f77_get_lowerbound): Likewise.
6193         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6194         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6195         print them.
6196         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6197         plongest to format print it.
6198         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6199         (f77_get_upperbound): Likewise.
6200         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6201         LOWER_BOUND to LONGEST.
6202         (f77_create_arrayprint_offset_tbl): Likewise.
6203
6204 2019-03-29  Keith Seitz  <keiths@redhat.com>
6205
6206         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6207         %s/pulongest for TYPE_LENGTH instead of %d in format
6208         strings.
6209         * ada-typerint.c (ada_print_type): Likewise.
6210         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6211         * compile/compile-c-support.c (generate_register_struct): Likewise.
6212         * gdbtypes.c (recursive_dump_type): Likewise.
6213         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6214         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6215         instead of %d in format strings.
6216         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6217         to std::min to ULONGEST.
6218         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6219         instead of %d in format strings.
6220         * tracepoint.c (info_scope_command): Likewise.
6221         * typeprint.c (print_offset_data::update)
6222         (print_offset_data::finish): Likewise.
6223         * xtensa-tdep.c (xtensa_store_return_value)
6224         (xtensa_push_dummy_call): Likewise.
6225
6226 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6227
6228         * windows-nat.c (display_selector): Fixed format specifications
6229         for 64-bit Cygwin.
6230
6231 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6232
6233         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6234
6235 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6236
6237         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6238         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6239         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6240         (nios2_linux_init_abi): Install it.
6241
6242 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6243
6244         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6245
6246 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6247
6248         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6249
6250 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6251             Tom Tromey  <tromey@adacore.com>
6252
6253         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6254
6255 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6256
6257         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6258         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6259         method to compute the bounds of range types. Also print "[evaluated]"
6260         if the bounds' values come from a dynamic evaluation.
6261
6262 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6263
6264         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6265         whitespace when pretty printing is on.
6266
6267 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6268
6269         * ppc-linux-nat.c: Add include.
6270
6271 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6272
6273         * NEWS: Mention AArch64 Pointer Authentication.
6274
6275 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6276
6277         * arm-linux-nat.c: Add include.
6278
6279 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6280
6281         * source-cache.c (source_cache::get_source_lines): Re-read
6282         fullname after calling open_source_file.
6283
6284 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6285
6286         * NEWS: Mention TLS support for FreeBSD.
6287
6288 2019-03-25  Tom Tromey  <tromey@adacore.com>
6289
6290         * minsyms.c (BUNCH_SIZE): Update comment.
6291         (~minimal_symbol_reader): Remove old comment.
6292         (compact_minimal_symbols): Update comment.
6293         (minimal_symbol_reader::install): Remove old comment.  Update
6294         other comments.
6295
6296 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6297
6298         * s390-linux-nat.c: Add include.
6299
6300 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6301
6302         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6303         Call linux_get_hwcap.
6304         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6305         Likewise.
6306         (aarch64_linux_get_hwcap): Remove function.
6307         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6308         declaration.
6309         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6310         linux_get_hwcap.
6311         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6312         * linux-tdep.c (linux_get_hwcap): Add function.
6313         (linux_get_hwcap2): Likewise.
6314         * linux-tdep.h (linux_get_hwcap): Add declaration.
6315         (linux_get_hwcap2): Likewise.
6316         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6317         (ppc_linux_get_hwcap2): Likewise.
6318         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6319         linux_get_hwcap.
6320         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6321         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6322         (ppc_linux_nat_target::read_description): Likewise.
6323         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6324         * s390-linux-nat.c: Likewise.
6325         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6326
6327 2019-03-24  Tom Tromey  <tom@tromey.com>
6328
6329         * ada-lang.c (standard_lookup): Simplify initialization.
6330         (ada_lookup_symbol_nonlocal): Simplify return.
6331         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6332         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6333         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6334         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6335         initialization.
6336         * solib.c (solib_global_lookup): Simplify.
6337         * symtab.c (null_block_symbol): Remove.
6338         (symbol_cache_lookup): Simplify returns.
6339         (lookup_language_this): Simplify returns.
6340         (lookup_symbol_aux): Simplify return.
6341         (lookup_local_symbol): Simplify returns.
6342         (lookup_global_symbol_from_objfile): Simplify return.
6343         (lookup_symbol_in_objfile_symtabs)
6344         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6345         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6346         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6347         * cp-namespace.c (cp_lookup_bare_symbol)
6348         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6349         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6350         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6351         (cp_lookup_symbol_via_imports): Simplify initialization.
6352         (find_symbol_in_baseclass): Likewise.
6353         * symtab.h (null_block_symbol): Remove.
6354         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6355         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6356         (d_lookup_symbol_module): Likewise.
6357         (find_symbol_in_baseclass): Simplify initialization.
6358
6359 2019-03-24  Tom Tromey  <tom@tromey.com>
6360
6361         * expression.h: Don't include symtab.h.
6362         (struct block): Forward declare.
6363
6364 2019-03-24  Tom Tromey  <tom@tromey.com>
6365
6366         * c-exp.y (typebase): Remove casts.
6367         * gdbtypes.c (lookup_unsigned_typename, )
6368         (lookup_signed_typename): Remove cast.
6369         * eval.c (parse_to_comma_and_eval): Remove cast.
6370         * parse.c (write_dollar_variable): Remove cast.
6371         * block.h (struct block) <superblock>: Now const.
6372         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6373         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6374         (map_block): Make "block" const.
6375         * symfile.h (struct quick_symbol_functions)
6376         <map_matching_symbols>: Constify block argument to "callback".
6377         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6378         const.
6379         (find_pc_sect_compunit_symtab): Make "b" const.
6380         (find_symbol_at_address): Likewise.
6381         (search_symbols): Likewise.
6382         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6383         (dw2_debug_names_lookup_symbol): Likewise.
6384         (dw2_map_matching_symbols): Update.
6385         * p-valprint.c (pascal_val_print): Remove "block".
6386         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6387         (aux_add_nonlocal_symbols): Make "block" const.
6388         (resolve_subexp): Remove cast.
6389         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6390         const.
6391         (iterate_over_file_blocks): Likewise.
6392         * f-exp.y (%union) <bval>: Remove.
6393         * coffread.c (patch_opaque_types): Make "b" const.
6394         * spu-tdep.c (spu_catch_start): Make "block" const.
6395         * c-valprint.c (print_unpacked_pointer): Remove "block".
6396         * symmisc.c (dump_symtab_1): Make "b" const.
6397         (block_depth): Make "block" const.
6398         * d-exp.y (%union) <bval>: Remove.
6399         * cp-support.h (cp_lookup_rtti_type): Update.
6400         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6401         * psymtab.c (psym_lookup_symbol): Make "block" const.
6402         (maintenance_check_psymtabs): Make "b" const.
6403         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6404         (enumerate_locals, enumerate_args): Update.
6405         * python/py-symtab.c (stpy_global_block): Make "block" const.
6406         (stpy_static_block): Likewise.
6407         * inline-frame.c (block_starting_point_at): Make "new_block"
6408         const.
6409         * block.c (find_block_in_blockvector): Make return type const.
6410         (blockvector_for_pc_sect): Make "b" const.
6411         (find_block_in_blockvector): Make "b" const.
6412
6413 2019-03-23  Tom Tromey  <tom@tromey.com>
6414
6415         * varobj.c (varobj_create): Update.
6416         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6417         * printcmd.c (display_command, do_one_display): Don't reset
6418         innermost_block.
6419         * parser-defs.h (enum innermost_block_tracker_type): Move to
6420         expression.h.
6421         (innermost_block): Update comment.
6422         * parse.c (parse_exp_1): Add tracker_types parameter.
6423         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6424         tracker_types parameter.  Reset innermost_block.
6425         (parse_exp_in_context): Remove.
6426         (parse_expression_for_completion): Update.
6427         * objfiles.c (~objfile): Don't reset expression_context_block or
6428         innermost_block.
6429         * expression.h (enum innermost_block_tracker_type): Move from
6430         parser-defs.h.
6431         (parse_exp_1): Add tracker_types parameter.
6432         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6433         reset innermost_block.
6434
6435 2019-03-23  Tom Tromey  <tom@tromey.com>
6436
6437         * objfiles.h: Include bcache.h.
6438
6439 2019-03-23  Tom Tromey  <tom@tromey.com>
6440
6441         * linespec.c (get_current_search_block): Use
6442         scoped_restore_current_language.
6443         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6444
6445 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6446             Jiong Wang  <jiong.wang@arm.com>
6447
6448         * aarch64-linux-tdep.c
6449         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6450         section.
6451         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6452
6453 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6454             Jiong Wang  <jiong.wang@arm.com>
6455
6456         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6457         instructions.
6458         (aarch64_analyze_prologue_test): Add PACIASP test.
6459         (aarch64_prologue_prev_register): Unmask PC value.
6460
6461 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6462             Jiong Wang  <jiong.wang@arm.com>
6463
6464         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6465         (aarch64_dwarf2_prev_register): Unmask PC value.
6466         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6467         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6468         DW_CFA_AARCH64_negate_ra_state.
6469         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6470
6471 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6472             Jiong Wang  <jiong.wang@arm.com>
6473
6474         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6475         registers.
6476         (aarch64_pseudo_register_name): Likewise.
6477         (aarch64_pseudo_register_type): Likewise.
6478         (aarch64_pseudo_register_reggroup_p): Likewise.
6479         (aarch64_gdbarch_init): Add pauth registers.
6480         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6481         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6482         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6483         (struct gdbarch_tdep): Add regnum for ra_state.
6484
6485 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6486             Jiong Wang  <jiong.wang@arm.com>
6487
6488         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6489
6490 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6491             Jiong Wang  <jiong.wang@arm.com>
6492
6493         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6494         function.
6495         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6496         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6497         (aarch64_gdbarch_init): Add puth registers.
6498         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6499         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6500         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6501
6502 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6503             Jiong Wang  <jiong.wang@arm.com>
6504
6505         * aarch64-linux-nat.c
6506         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6507         * aarch64-linux-tdep.c
6508         (aarch64_linux_core_read_description): Likewise.
6509         (aarch64_linux_get_hwcap): New function.
6510         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6511         (aarch64_linux_get_hwcap): New declaration.
6512
6513 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6514             Jiong Wang  <jiong.wang@arm.com>
6515
6516         * aarch64-linux-nat.c
6517         (aarch64_linux_nat_target::read_description): Add pauth param.
6518         * aarch64-linux-tdep.c
6519         (aarch64_linux_core_read_description): Likewise.
6520         * aarch64-tdep.c (struct target_desc): Add in pauth.
6521         (aarch64_read_description): Add pauth param.
6522         (aarch64_gdbarch_init): Likewise.
6523         * aarch64-tdep.h (aarch64_read_description): Likewise.
6524         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6525         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6526         * features/Makefile: Add new files.
6527         * features/aarch64-pauth.c: New file.
6528         * features/aarch64-pauth.xml: New file.
6529
6530 2019-03-20  Tom Tromey  <tromey@adacore.com>
6531
6532         * infrun.c (handle_inferior_event): Rename from
6533         handle_inferior_event_1.  Create a scoped_value_mark.
6534         (handle_inferior_event): Remove.
6535
6536 2019-03-19  Tom Tromey  <tromey@adacore.com>
6537
6538         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6539         * infrun.h (print_stop_event): Add "displays" parameter.
6540         * infrun.c (print_stop_event): Add "displays" parameter.
6541
6542 2019-03-19  Pedro Alves  <palves@redhat.com>
6543
6544         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6545         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6546         to -1.  Fix TABs vs spaces.
6547         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6548         * tui/tui-out.h (tui_ui_out) Add intro comments.
6549         <m_line, m_start_of_line>: In-class initialize, and add describing
6550         comment.
6551
6552 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6553
6554         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6555         variable names.
6556         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6557
6558 2019-03-18  Pedro Alves  <palves@redhat.com>
6559             Eli Zaretskii <eliz@gnu.org>
6560
6561         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6562         m_line and m_start_of_line.
6563
6564 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6565
6566         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6567         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6568         it returns a newline.  This fixes a regression in TU mode, whereby
6569         the next line is output on the same screen line as the user input.
6570
6571 2019-03-18  Tom Tromey  <tromey@adacore.com>
6572
6573         * minsyms.c (minimal_symbol_reader::install): Remove call to
6574         obstack_blank.
6575
6576 2019-03-18  Pedro Alves  <palves@redhat.com>
6577
6578         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6579         New globals.
6580         (apply_style): New, factored out from ...
6581         (apply_ansi_escape): ... this.  Handle reverse video mode.
6582         (tui_set_reverse_mode): New function.
6583         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6584         * tui/tui-winsource.c (tui_show_source_line): Use
6585         tui_set_reverse_mode instead of setting A_STANDOUT.
6586         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6587         New setter methods.
6588
6589 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6590
6591         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6592         Handle tabs.
6593
6594 2019-03-18  Tom Tromey  <tromey@adacore.com>
6595
6596         * ada-lang.c (empty_array): Add "high" parameter.
6597         (ada_evaluate_subexp): Update.
6598
6599 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6600
6601         * unittests/string_view-selftests.c: Define
6602         _initialize_string_view_selftests unconditionally.
6603
6604 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6605
6606         PR gdb/24350
6607         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6608
6609 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6610
6611         PR gdb/24351
6612         * windows-nat.c (display_selector): Fix format specifiers.
6613
6614 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6615
6616         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6617         tui_refill_source_window instead of tui_refresh_win, to update the
6618         current execution line.  This fixes redisplay of the current line
6619         when stepping through the code with "next" or "step".
6620
6621 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6622
6623         * source-cache.c (source_cache::get_source_lines): Call
6624         find_source_lines to initialize s->nlines.  This fixes vertical
6625         scrolling of TUI source window when the DOWN arrow is pressed.
6626
6627 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6628
6629         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6630         linux-thread-db.c (_initialize_thread_db): Likewise.
6631
6632 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6633
6634         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6635         wclrtoeol in tui_show_source_line".  This reverts changes made in
6636         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6637
6638 2019-03-15  Tom Tromey  <tom@tromey.com>
6639
6640         * symtab.h (struct minimal_symbol): Derive from
6641         general_symbol_info.
6642         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6643         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6644         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6645         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6646         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6647         (MSYMBOL_SEARCH_NAME): Update.
6648         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6649         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6650         * minsyms.c (minimal_symbol_reader::record_full): Update.
6651
6652 2019-03-15  Tom Tromey  <tom@tromey.com>
6653
6654         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6655
6656 2019-03-15  Tom Tromey  <tom@tromey.com>
6657
6658         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6659         unique_xmalloc_ptr.
6660         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6661         Update.
6662         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6663         (build_minimal_symbol_hash_tables)
6664         (minimal_symbol_reader::install): Update.
6665
6666 2019-03-15  Tom Tromey  <tom@tromey.com>
6667
6668         * symtab.c (create_demangled_names_hash): Update.
6669         (symbol_set_names): Update.
6670         * objfiles.h (struct objfile_per_bfd_storage)
6671         <demangled_names_hash>: Now an htab_up.
6672         * objfiles.c (objfile_per_bfd_storage): Simplify.
6673
6674 2019-03-15  Tom Tromey  <tom@tromey.com>
6675
6676         * objfiles.h (struct objfile_per_bfd_storage): Declare
6677         destructor.
6678         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6679         New.
6680         (get_objfile_bfd_data): Use new.  Don't initialize
6681         language_of_main.
6682         (free_objfile_per_bfd_storage): Remove.
6683         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6684
6685 2019-03-15  Tom Tromey  <tom@tromey.com>
6686
6687         * symfile.c (reread_symbols): Update.
6688         * objfiles.c (objfile::objfile): Update.
6689         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6690         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6691         comment.
6692         (minimal_symbol_reader::install): Update.
6693         (terminate_minimal_symbol_table): Remove.
6694         * jit.c (jit_object_close_impl): Update.
6695
6696 2019-03-15  Tom Tromey  <tom@tromey.com>
6697
6698         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6699         initializations.
6700
6701 2019-03-15  Tom Tromey  <tom@tromey.com>
6702
6703         * objfiles.h (struct objfile_per_bfd_storage)
6704         <demangled_hash_languages>: Now a bitset.
6705         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6706         (lookup_minimal_symbol): Update.
6707
6708 2019-03-15  Tom Tromey  <tom@tromey.com>
6709
6710         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6711         Don't return the symbol.
6712         * coffread.c (record_minimal_symbol): Use record_full.
6713
6714 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6715
6716         The MS-Windows port of ncurses fails to switch to a color pair if
6717         one or both of the colors are the implicit default colors.  This
6718         change records the default colors when TUI is initialized, and
6719         then specifies them explicitly when a color pair uses the default
6720         colors.  This allows color styling in TUI mode on MS-Windows.
6721
6722         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6723         ncurses_norm_attr.
6724         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6725         colors in ncurses_norm_attr.
6726         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6727         "none", replace it with the default color recorded in
6728         ncurses_norm_attr.
6729
6730 2019-03-14  Tom Tromey  <tromey@adacore.com>
6731
6732         * source-cache.h (class source_cache) <get_source_lines>: Return
6733         std::string.
6734         * source-cache.c (source_cache::extract_lines): Handle case where
6735         first_pos==npos.  Return std::string.
6736         (source_cache::get_source_lines): Update.
6737
6738 2019-03-14  Tom Tromey  <tromey@adacore.com>
6739
6740         * NEWS: Add item for "style sources" commands.
6741         * source-cache.c (source_cache::get_source_lines): Check
6742         source_styling.
6743         * cli/cli-style.c (source_styling): New global.
6744         (_initialize_cli_style): Add "style sources" commands.
6745         (show_style_sources): New function.
6746         * cli/cli-style.h (source_styling): Declare.
6747
6748 2019-03-14  Pedro Alves  <palves@redhat.com>
6749             Tom Tromey  <tromey@adacore.com>
6750
6751         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6752         * tui/tui-winsource.c (tui_refill_source_window): New function,
6753         from...
6754         (tui_horizontal_source_scroll): ... here.  Move some logic.
6755         * cli/cli-style.c (set_style_enabled): Notify new observable.
6756         * tui/tui-hooks.c (tui_redisplay_source): New function.
6757         (tui_attach_detach_observers): Attach or detach
6758         tui_redisplay_source.
6759         * observable.h (source_styling_changed): New observable.
6760         * observable.c: Define source_styling_changed observable.
6761
6762 2019-03-13  Tom Tromey  <tromey@adacore.com>
6763
6764         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6765         (i386_gnu_nat_target::store_registers): Update.
6766         * target-debug.h (target_debug_print_std_string): New macro.
6767         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6768         * windows-tdep.c (display_one_tib): Update.
6769         * tui/tui-stack.c (tui_make_status_line): Update.
6770         * top.c (print_inferior_quit_action): Update.
6771         * thread.c (thr_try_catch_cmd): Update.
6772         (add_thread_with_info): Update.
6773         (thread_target_id_str): Update.
6774         (thr_try_catch_cmd): Update.
6775         (thread_command): Update.
6776         (thread_find_command): Update.
6777         * record-btrace.c (record_btrace_target::info_record)
6778         (record_btrace_resume_thread, record_btrace_target::resume)
6779         (record_btrace_cancel_resume, record_btrace_step_thread)
6780         (record_btrace_target::wait, record_btrace_target::wait)
6781         (record_btrace_target::wait, record_btrace_target::stop): Update.
6782         * progspace.c (print_program_space): Update.
6783         * process-stratum-target.c
6784         (process_stratum_target::thread_address_space): Update.
6785         * linux-fork.c (linux_fork_mourn_inferior)
6786         (detach_checkpoint_command, info_checkpoints_command)
6787         (linux_fork_context): Update.
6788         (linux_fork_detach): Update.
6789         (class scoped_switch_fork_info): Update.
6790         (delete_checkpoint_command): Update.
6791         * infrun.c (follow_fork_inferior): Update.
6792         (follow_fork_inferior): Update.
6793         (proceed_after_vfork_done): Update.
6794         (handle_vfork_child_exec_or_exit): Update.
6795         (follow_exec): Update.
6796         (displaced_step_prepare_throw): Update.
6797         (displaced_step_restore): Update.
6798         (start_step_over): Update.
6799         (resume_1): Update.
6800         (clear_proceed_status_thread): Update.
6801         (proceed): Update.
6802         (print_target_wait_results): Update.
6803         (do_target_wait): Update.
6804         (context_switch): Update.
6805         (stop_all_threads): Update.
6806         (restart_threads): Update.
6807         (finish_step_over): Update.
6808         (handle_signal_stop): Update.
6809         (switch_back_to_stepped_thread): Update.
6810         (keep_going_pass_signal): Update.
6811         (print_exited_reason): Update.
6812         (normal_stop): Update.
6813         * inferior.c (inferior_pid_to_str): Change return type.
6814         (print_selected_inferior): Update.
6815         (add_inferior): Update.
6816         (detach_inferior): Update.
6817         * dummy-frame.c (fprint_dummy_frames): Update.
6818         * dcache.c (dcache_info_1): Update.
6819         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6820         (btrace_fetch, btrace_clear): Update.
6821         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6822         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6823         type.
6824         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6825         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6826         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6827         * gdbarch.c, gdbarch.h: Rebuild.
6828         * gdbarch.sh (core_pid_to_str): Change return type.
6829         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6830         return type.
6831         (windows_nat_target::pid_to_str): Change return type.
6832         (windows_delete_thread): Update.
6833         (windows_nat_target::attach): Update.
6834         (windows_nat_target::files_info): Update.
6835         * target-delegates.c: Rebuild.
6836         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6837         return type.
6838         (sol_thread_target::pid_to_str): Change return type.
6839         * remote.c (class remote_target) <pid_to_str>: Change return
6840         type.
6841         (remote_target::pid_to_str): Change return type.
6842         (extended_remote_target::attach, remote_target::remote_stop_ns)
6843         (remote_target::remote_notif_remove_queued_reply)
6844         (remote_target::push_stop_reply, remote_target::disable_btrace):
6845         Update.
6846         (extended_remote_target::attach): Update.
6847         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6848         type.
6849         (gdbsim_target::pid_to_str): Change return type.
6850         * ravenscar-thread.c (struct ravenscar_thread_target)
6851         <pid_to_str>: Change return type.
6852         (ravenscar_thread_target::pid_to_str): Change return type.
6853         * procfs.c (class procfs_target) <pid_to_str>: Change return
6854         type.
6855         (procfs_target::pid_to_str): Change return type.
6856         (procfs_target::attach): Update.
6857         (procfs_target::detach): Update.
6858         (procfs_target::fetch_registers): Update.
6859         (procfs_target::store_registers): Update.
6860         (procfs_target::wait): Update.
6861         (procfs_target::files_info): Update.
6862         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6863         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6864         return type.
6865         (nto_procfs_target::pid_to_str): Change return type.
6866         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6867         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6868         return type.
6869         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6870         (exit_lwp): Update.
6871         (attach_proc_task_lwp_callback, get_detach_signal)
6872         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6873         (linux_nat_target::resume, wait_lwp, stop_callback)
6874         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6875         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6876         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6877         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6878         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6879         type.
6880         (inf_ptrace_target::attach): Update.
6881         (inf_ptrace_target::files_info): Update.
6882         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6883         type.
6884         (go32_nat_target::pid_to_str): Change return type.
6885         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6886         (gnu_nat_target::wait): Update.
6887         (gnu_nat_target::wait): Update.
6888         (gnu_nat_target::resume): Update.
6889         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6890         (fbsd_nat_target::wait): Update.
6891         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6892         type.
6893         (darwin_nat_target::attach): Update.
6894         * corelow.c (class core_target) <pid_to_str>: Change return type.
6895         (core_target::pid_to_str): Change return type.
6896         * target.c (normal_pid_to_str): Change return type.
6897         (default_pid_to_str): Likewise.
6898         (target_pid_to_str): Change return type.
6899         (target_translate_tls_address): Update.
6900         (target_announce_detach): Update.
6901         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6902         return type.
6903         (bsd_uthread_target::pid_to_str): Change return type.
6904         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6905         type.
6906         (bsd_kvm_target::pid_to_str): Change return type.
6907         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6908         return type.
6909         (aix_thread_target::pid_to_str): Change return type.
6910         * target.h (struct target_ops) <pid_to_str>: Change return type.
6911         (target_pid_to_str, normal_pid_to_str): Likewise.
6912         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6913         type.
6914         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6915         type.
6916         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6917         return type.
6918         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6919         type.
6920         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6921         type.
6922         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6923         return type.
6924
6925 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6926
6927         * NEWS: Mention that the new default MI version is 3.  Mention
6928         changes to the output of commands and events that deal with
6929         multi-location breakpoints.
6930         * breakpoint.c: Include "mi/mi-out.h".
6931         (print_one_breakpoint): Change output syntax if using MI version
6932         >= 3.
6933         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6934         New.
6935         (mi_multi_location_breakpoint_output_fixed): New.
6936         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6937         (mi_cmd_fix_multi_location_breakpoint_output): New.
6938         (mi_multi_location_breakpoint_output_fixed): New.
6939         * mi/mi-cmds.c (mi_cmds): Register command
6940         -fix-multi-location-breakpoint-output.
6941         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6942         interpreter "mi".
6943
6944 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6945
6946         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6947         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6948         instantiate mi_ui_out based on interpreter name.
6949         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6950         * mi/mi-main.c (mi_load_progress): Likewise.
6951
6952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6953
6954         * NEWS: Combine separate "New targets" sections for 8.3.
6955
6956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6957
6958         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6959         (ppcfbsd_init_abi): Install gdbarch
6960         "fetch_tls_load_module_address" and "get_thread_local_address"
6961         methods.
6962
6963 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6964
6965         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6966         (riscv_fbsd_init_abi): Install gdbarch
6967         "fetch_tls_load_module_address" and "get_thread_local_address"
6968         methods.
6969
6970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6971
6972         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6973         (i386fbsd_init_abi): Install gdbarch
6974         "fetch_tls_load_module_address" and "get_thread_local_address"
6975         methods.
6976
6977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6978
6979         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6980         (amd64fbsd_init_abi): Install gdbarch
6981         "fetch_tls_load_module_address" and "get_thread_local_address"
6982         methods.
6983
6984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6985
6986         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6987         (struct fbsd_pspace_data): New type.
6988         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6989         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6990         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6991         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6992         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6993
6994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6995
6996         * gdbtypes.c (lookup_struct_elt): New function.
6997         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6998         * gdbtypes.h (struct struct_elt): New type.
6999         (lookup_struct_elt): New prototype.
7000
7001 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7002
7003         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7004         remove disabled code block.
7005
7006 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7007
7008         * gdbarch.sh (get_thread_local_address): New method.
7009         * gdbarch.h, gdbarch.c: Regenerate.
7010         * target.c (target_translate_tls_address): Use
7011         gdbarch_get_thread_local_address if present instead of
7012         target::get_thread_local_address.
7013
7014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7015
7016         * target.h (target::get_thread_local_address): Update comment.
7017
7018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7019
7020         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7021         objfile->separate_debug_objfile_backlink if not NULL.
7022
7023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7024
7025         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7026         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7027         (amd64bsd_store_inferior_registers): Likewise.
7028         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7029         Enable segment base registers.
7030         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7031         PT_GETFSBASE and PT_GETGSBASE.
7032         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7033         PT_SETGSBASE.
7034         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7035         segment base registers.
7036         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7037
7038 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7039
7040         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7041         Update calls to i386_target_description to add 'segments'
7042         parameter.
7043         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7044         add segment base registers.
7045         * arch/i386.c (i386_create_target_description): Add 'segments'
7046         parameter to enable segment base registers.
7047         * arch/i386.h (i386_create_target_description): Likewise.
7048         * features/i386/32bit-segments.xml: New file.
7049         * features/i386/32bit-segments.c: Generate.
7050         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7051         call to i386_target_description to add 'segments' parameter.
7052         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7053         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7054         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7055         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7056         if feature is present.
7057         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7058         Add 'segments' parameter to call to i386_target_description.
7059         (i386_target_description): Add 'segments' parameter to enable
7060         segment base registers.
7061         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7062         to call to i386_target_description.
7063         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7064         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7065         Define I386_NUM_REGS.
7066         (i386_target_description): Add 'segments' parameter to enable
7067         segment base registers.
7068
7069 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7070
7071         PR/24325
7072         * source-cache.c: #undef open and close, to avoid unresolved
7073         externals during linking.
7074
7075 2019-03-12  Tom Tromey  <tromey@adacore.com>
7076
7077         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7078         const.  Add initializers.
7079         (_initialize_remote): Don't initialize ptid globals.
7080
7081 2019-03-12  Pedro Alves  <palves@redhat.com>
7082
7083         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7084
7085 2019-03-12  Pedro Alves  <palves@redhat.com>
7086
7087         * cp-name-parser.y (main): Remove unused 'len' variable.
7088
7089 2019-03-12  Tom Tromey  <tromey@adacore.com>
7090
7091         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7092         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7093
7094 2019-03-12  Tom Tromey  <tromey@adacore.com>
7095
7096         * linux-nat.c (iterate_over_lwps): Update.
7097         (stop_callback): Remove parameter.
7098         (stop_wait_callback, detach_callback, resume_set_callback)
7099         (select_singlestep_lwp_callback, set_ignore_sigint)
7100         (status_callback, resumed_callback, resume_clear_callback)
7101         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7102         data parameter.
7103         (linux_nat_target::detach, linux_nat_target::resume)
7104         (linux_stop_and_wait_all_lwps, select_event_lwp)
7105         (linux_nat_filter_event, linux_nat_wait_1)
7106         (linux_nat_target::kill, linux_nat_target::stop)
7107         (linux_nat_target::stop): Update.
7108         (linux_nat_resume_callback): Change type.
7109         (resume_stopped_resumed_lwps, count_events_callback)
7110         (select_event_lwp_callback): Likewise.
7111         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7112         * arm-linux-nat.c (struct update_registers_data): Remove.
7113         (update_registers_callback): Change type.
7114         (arm_linux_insert_hw_breakpoint1): Update.
7115         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7116         parameter.
7117         (x86_linux_dr_set_addr): Update.
7118         (x86_linux_dr_set_control): Update.
7119         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7120         (iterate_over_lwps): Use gdb::function_view.
7121         * nat/aarch64-linux-hw-point.c (struct
7122         aarch64_dr_update_callback_param): Remove.
7123         (debug_reg_change_callback): Change type.
7124         (aarch64_notify_debug_reg_change): Update.
7125         * s390-linux-nat.c (s390_refresh_per_info): Update.
7126
7127 2019-03-11  Tom Tromey  <tromey@adacore.com>
7128
7129         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7130         redundant assignment to "this_cu".
7131
7132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7133
7134         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7135
7136 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7137
7138         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7139         from...
7140         (rank_one_type): ... this.
7141
7142 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7143
7144         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7145         from...
7146         (rank_one_type): ... this.
7147
7148 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7149
7150         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7151         from...
7152         (rank_one_type): ... this.
7153
7154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7155
7156         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7157         from...
7158         (rank_one_type): ... this.
7159
7160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7161
7162         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7163         from...
7164         (rank_one_type): ... this.
7165
7166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7167
7168         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7169         from...
7170         (rank_one_type): ... this.
7171
7172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7173
7174         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7175         from...
7176         (rank_one_type): ... this.
7177
7178 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7179
7180         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7181         from...
7182         (rank_one_type): ... this.
7183
7184 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7185
7186         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7187         from...
7188         (rank_one_type): ... this.
7189
7190 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7191
7192         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7193         from...
7194         (rank_one_type): ... this.
7195
7196 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7197
7198         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7199         from...
7200         (rank_one_type): ... this.
7201
7202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7203
7204         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7205         from...
7206         (rank_one_type): ... this.
7207
7208 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7209
7210         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7211         inferior-events' shows the example events.
7212
7213 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7214
7215         Support styling on native MS-Windows console
7216
7217         PR/24315
7218         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7219         on MS-Windows if $TERM is not defined.
7220
7221         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7222
7223         * posix-hdep.c (gdb_console_fputs):
7224         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7225         functions.
7226         * ui-file.h (gdb_console_fputs): Add prototype.
7227
7228         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7229         back to fputs only if the former returns zero.
7230
7231 2019-03-07  Tom Tromey  <tom@tromey.com>
7232
7233         * symmisc.c (print_symbol_bcache_statistics): Update.
7234         (print_objfile_statistics): Update.
7235         * symfile.c (allocate_symtab): Update.
7236         * stabsread.c: Don't include bcache.h.
7237         * psymtab.h (struct psymbol_bcache): Don't declare.
7238         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7239         (psymbol_bcache_init, psymbol_bcache_free)
7240         (psymbol_bcache_get_bcache): Don't declare.
7241         * psymtab.c (struct psymbol_bcache): Remove.
7242         (psymtab_storage::psymtab_storage): Update.
7243         (psymtab_storage::~psymtab_storage): Update.
7244         (psymbol_bcache_init, psymbol_bcache_free)
7245         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7246         (add_psymbol_to_bcache): Update.
7247         (allocate_psymtab): Update.
7248         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7249         macro_cache>: No longer pointers.
7250         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7251         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7252         * macrotab.c (macro_bcache): Update.
7253         * macroexp.c: Don't include bcache.h.
7254         * gdbtypes.c (check_types_worklist): Update.
7255         (types_deeply_equal): Remove TRY/CATCH.  Update.
7256         * elfread.c (elf_symtab_read): Update.
7257         * dwarf2read.c: Don't include bcache.h.
7258         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7259         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7260         (print_bcache_statistics, bcache_memory_used): Don't declare.
7261         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7262         methods.  Rename all data members.
7263         * bcache.c (struct bcache): Move to bcache.h.
7264         (bcache::expand_hash_table): Rename from expand_hash_table.
7265         (bcache): Remove.
7266         (bcache::insert): Rename from bcache_full.
7267         (bcache::compare): Rename from bcache_compare.
7268         (bcache_xmalloc): Remove.
7269         (bcache::~bcache): Rename from bcache_xfree.
7270         (bcache::print_statistics): Rename from print_bcache_statistics.
7271         (bcache::memory_used): Rename from bcache_memory_used.
7272
7273 2019-03-07  Pedro Alves  <palves@redhat.com>
7274
7275         * infrun.c (normal_stop): Also check for
7276         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7277
7278 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7279
7280         * f-lang.c (value_from_host_double): Moved to...
7281         * value.c (value_from_host_double): ...here.
7282         * value.h (value_from_host_double): Declare.
7283         * guile/scm-math.c (vlscm_convert_typed_number): Use
7284         value_from_host_double.
7285         (vlscm_convert_number): Likewise.
7286         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7287         * python/py-value.c (convert_value_from_python): Likewise.
7288
7289 2019-03-06  Tom Tromey  <tom@tromey.com>
7290
7291         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7292
7293 2019-03-06  Tom Tromey  <tom@tromey.com>
7294
7295         * utils.h (free_current_contents): Don't declare.
7296         * utils.c (free_current_contents): Remove.
7297
7298 2019-03-06  Tom Tromey  <tom@tromey.com>
7299
7300         * top.c (quit_force): Update.
7301         * main.c (captured_command_loop): Update.
7302         * common/new-op.c (operator new): Update.
7303         * common/common-exceptions.c (struct catcher)
7304         <save_cleanup_chain>: Remove member.
7305         (exceptions_state_mc_init): Update.
7306         (exception_try_scope_entry): Return nullptr.
7307         (exception_try_scope_exit, exception_rethrow)
7308         (throw_exception_sjlj, throw_exception_cxx): Update.
7309         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7310         (all_cleanups, do_cleanups, discard_cleanups)
7311         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7312         (restore_cleanups, restore_final_cleanups): Don't declare.
7313         (do_final_cleanups): Remove parameter.
7314         * common/cleanups.c (cleanup_chain, make_cleanup)
7315         (make_cleanup_dtor, all_cleanups, do_cleanups)
7316         (discard_my_cleanups, discard_cleanups)
7317         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7318         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7319         (null_cleanup): Remove.
7320         (do_final_cleanups): Remove parameter.
7321
7322 2019-03-06  Tom Tromey  <tom@tromey.com>
7323
7324         * remote.c (remote_target::remote_parse_stop_reply): Use
7325         unique_xmalloc_ptr.
7326
7327 2019-03-06  Tom Tromey  <tom@tromey.com>
7328
7329         * stabsread.c (struct stabs_field_info): Rename from field_info.
7330         <list, fnlist>: Add initializers.
7331         <obstack>: New member.
7332         (read_member_functions, read_struct_fields, read_baseclasses):
7333         Allocate on obstack.  Don't use cleanups.
7334         (read_one_struct_field, read_member_functions, read_struct_fields)
7335         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7336         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7337         (read_struct_type): Update.
7338
7339 2019-03-06  Tom Tromey  <tom@tromey.com>
7340
7341         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7342         * common/filestuff.h (make_cleanup_close): Don't declare.
7343         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7344         Remove.
7345
7346 2019-03-06  Tom Tromey  <tom@tromey.com>
7347
7348         * solib-aix.c: Use make_scope_exit.
7349
7350 2019-03-06  Tom Tromey  <tom@tromey.com>
7351
7352         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7353         Use make_scope_exit.
7354
7355 2019-03-06  Tom Tromey  <tom@tromey.com>
7356
7357         * solib-svr4.c (disable_probes_interface): Remove parameter.
7358         (svr4_handle_solib_event): Use make_scope_exit.
7359
7360 2019-03-06  Tom Tromey  <tom@tromey.com>
7361
7362         * remote.c (struct stop_reply_deleter): Remove.
7363         (stop_reply_up): Update.
7364         (struct stop_reply): Derive from notif_event.  Don't typedef.
7365         <regcache>: Now a std::vector.
7366         (stop_reply_xfree): Remove.
7367         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7368         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7369         (remote_target::discard_pending_stop_replies): Use delete.
7370         (remote_target::remote_parse_stop_reply): Update.
7371         (remote_target::process_stop_reply): Update.
7372         * remote-notif.h (struct notif_event): Add virtual destructor.
7373         Remove "dtr" member.
7374         (struct notif_client) <alloc_event>: Return a unique_ptr.
7375         (notif_event_xfree): Don't declare.
7376         (notif_event_up): New typedef.
7377         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7378         (notif_event_xfree, do_notif_event_xfree): Remove.
7379         (remote_notif_state_xfree): Update.
7380
7381 2019-03-06  Tom Tromey  <tom@tromey.com>
7382
7383         * infrun.c (displaced_step_clear_cleanup): Now a
7384         forward_scope_exit type.
7385         (displaced_step_prepare_throw): Update.
7386         (displaced_step_fixup): Update.
7387
7388 2019-03-06  Tom Tromey  <tom@tromey.com>
7389
7390         * inferior.h (class inferior): Update comment.
7391         * gdbthread.h (class thread_info): Update comment.
7392
7393 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7394             Tom Tromey  <tom@tromey.com>
7395
7396         * stabsread.h (struct stab_section_list): Remove.
7397         (coffstab_build_psymtabs): Update.
7398         * dbxread.c (symbuf_sections): Now a std::vector.
7399         (sect_idx): New global.
7400         (fill_symbuf): Update.
7401         (coffstab_build_psymtabs): Change type of stabsects parameter.
7402         Update.
7403         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7404         std::vector.
7405         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7406         (coff_locate_sections): Update.
7407         (coff_symfile_read): Remove cleanups.  Update.
7408         (init_stringtab): Add storage parameter.
7409         (free_stringtab, free_stringtab_cleanup): Remove.
7410         (init_lineno): Add storage parameter.
7411         (free_linetab, free_linetab_cleanup): Remove.
7412
7413 2019-03-06  Pedro Alves  <palves@redhat.com>
7414
7415         * linux-fork.c (fork_info::clobber_regs): Delete.
7416         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7417         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7418         comment.  Adjust.
7419         (scoped_switch_fork_info::scoped_switch_fork_info)
7420         (checkpoint_command, linux_fork_context): Adjust
7421         fork_save_infrun_state calls.
7422
7423 2019-03-06  Pedro Alves  <palves@redhat.com>
7424
7425         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7426         (inf_has_multiple_threads): Return 'bool' and rewrite using
7427         inferior_info::threads().
7428
7429 2019-03-06  Pedro Alves  <palves@redhat.com>
7430
7431         * linux-fork.c: Include <list>.
7432         (fork_list): Now a std::list instance.
7433         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7434         (forks_exist_p, find_last_fork): Adjust.
7435         (new_fork): Delete.
7436         (one_fork_p): New.
7437         (add_fork): Adjust.
7438         (free_fork): Delete, folded into fork_info::~fork_info().
7439         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7440         Adjust.
7441         (init_fork_list): Delete.
7442         (linux_fork_killall, linux_fork_mourn_inferior)
7443         (linux_fork_detach, info_checkpoints_command): Adjust.
7444         (_initialize_linux_fork): No longer call init_fork_list.
7445
7446 2019-03-06  Pedro Alves  <palves@redhat.com>
7447
7448         * linux-fork.c (new_fork): New, split out of ...
7449         (add_fork): ... this.  Return void.  Move "first fork" special
7450         case from here, to ...
7451         (checkpoint_command): ... here.
7452         * linux-linux.h (add_fork): Return void.
7453
7454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7455
7456         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7457
7458 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7459             Chris January  <chris.january@arm.com>
7460             David Lecomber  <david.lecomber@arm.com>
7461
7462         * f-exp.y: New token, UNOP_INTRINSIC.
7463         (exp): New pattern using UNOP_INTRINSIC token.
7464         (f77_keywords): Add 'abs' keyword.
7465         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7466         (value_from_host_double): New function.
7467         (evaluate_subexp_f): Support UNOP_ABS.
7468
7469 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7470
7471         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7472         types.
7473
7474 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7475
7476         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7477         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7478         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7479
7480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7481
7482         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7483
7484 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7485             Chris January  <chris.january@arm.com>
7486
7487         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7488         * f-exp.y: Define 'KIND' token.
7489         (exp): New pattern for KIND expressions.
7490         (ptype): Handle types with a kind extension.
7491         (direct_abs_decl): Extend to spot kind extensions.
7492         (f77_keywords): Add 'kind' to the list.
7493         (push_kind_type): New function.
7494         (convert_to_kind_type): New function.
7495         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7496         * parse.c (operator_length_standard): Likewise.
7497         * parser-defs.h (enum type_pieces): Add tp_kind.
7498         * std-operator.def: Add UNOP_KIND.
7499
7500 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7501
7502         * f-exp.y (f_parse): Set yydebug.
7503
7504 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7505
7506         * f-lang.c (evaluate_subexp_f): New function.
7507         (exp_descriptor_f): New global.
7508         (f_language_defn): Use exp_descriptor_f instead of
7509         exp_descriptor_standard.
7510
7511 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7512
7513         * f-exp.y (struct token): Add comments.
7514         (dot_ops): Remove uppercase versions and the end marker.
7515         (f77_keywords): Likewise.
7516         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7517         entries in the dot_ops array are case insensitive, and use
7518         strncasecmp to compare strings.  Also some whitespace cleanup in
7519         this area.  Similar for the f77_keywords array, except entries in
7520         this list might be case sensitive.
7521
7522 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * f-exp.y (struct f77_boolean_val): Add comments.
7525         (boolean_values): Remove uppercase versions, and end marker.
7526         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7527         and use strncasecmp to achieve case insensitivity.  Additionally,
7528         perform whitespace cleanup around this code.
7529
7530 2019-03-06  Tom Tromey  <tromey@adacore.com>
7531
7532         * remote-sim.c (gdbsim_target_open): Use result of
7533         gdb_argv::release.
7534
7535 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7536         Dirk Schubert  <dirk.schubert@arm.com>
7537         Chris January  <chris.january@arm.com>
7538
7539         * eval.c (evaluate_subexp_standard): Call Fortran argument
7540         wrapping logic.
7541         * f-lang.c (struct value): A value which can be passed into a
7542         Fortran function call.
7543         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7544         where appropriate.
7545         (struct type): Value ready for a Fortran function call.
7546         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7547         is needed.
7548         * f-lang.h (fortran_argument_convert): Declaration.
7549         (fortran_preserve_arg_pointer): Declaration.
7550         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7551
7552 2019-03-05  Tom Tromey  <tromey@adacore.com>
7553
7554         * python/py-prettyprint.c (print_string_repr): Remove #if.
7555         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7556
7557 2019-03-05  Tom Tromey  <tromey@adacore.com>
7558
7559         * target.c (the_dummy_target): Move later.  Change type to
7560         "dummy_target".
7561         (initialize_targets): Don't initialize the_dummy_target.
7562
7563 2019-03-05  Tom Tromey  <tromey@adacore.com>
7564
7565         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7566         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7567
7568 2019-03-05  Tom Tromey  <tromey@adacore.com>
7569
7570         * windows-nat.c (windows_nat_target::attach)
7571         (windows_nat_target::detach): Don't call gdb_flush.
7572         * valprint.c (generic_val_print, val_print, val_print_string):
7573         Don't call gdb_flush.
7574         * utils.c (defaulted_query): Don't call gdb_flush.
7575         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7576         * target.c (target_announce_detach): Don't call gdb_flush.
7577         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7578         * remote.c (extended_remote_target::attach): Don't call
7579         gdb_flush.
7580         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7581         * printcmd.c (do_examine): Don't call gdb_flush.
7582         (info_display_command): Don't call gdb_flush.
7583         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7584         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7585         * memattr.c (info_mem_command): Don't call gdb_flush.
7586         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7587         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7588         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7589         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7590         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7591         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7592         (gnu_nat_target::detach): Don't call gdb_flush.
7593         * f-valprint.c (f_val_print): Don't call gdb_flush.
7594         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7595         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7596         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7597         gdb_flush.
7598         * c-valprint.c (c_val_print): Don't call gdb_flush.
7599         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7600
7601 2019-03-05  Tom Tromey  <tromey@adacore.com>
7602
7603         * varobj.c (update_dynamic_varobj_children): Update.
7604         (install_default_visualizer): Use reset, not release.
7605         * value.c (set_internalvar): Update.
7606         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7607         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7608         ATTRIBUTE_UNUSED_RESULT.
7609
7610 2019-03-05  Tom Tromey  <tromey@adacore.com>
7611
7612         * remote.c (class scoped_remote_fd) <release>: Add
7613         ATTRIBUTE_UNUSED_RESULT.
7614
7615 2019-03-05  Tom Tromey  <tromey@adacore.com>
7616
7617         * macroexp.c (struct macro_buffer) <release>: Add
7618         ATTRIBUTE_UNUSED_RESULT.
7619
7620 2019-03-05  Tom Tromey  <tromey@adacore.com>
7621
7622         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7623         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7624         ATTRIBUTE_UNUSED_RESULT.
7625
7626 2019-03-05  Tom Tromey  <tromey@adacore.com>
7627
7628         * common/scoped_fd.h (class scoped_fd) <release>: Add
7629         ATTRIBUTE_UNUSED_RESULT.
7630
7631 2019-03-05  Tom Tromey  <tromey@adacore.com>
7632
7633         * parser-defs.h (struct parser_state) <release>: Add
7634         ATTRIBUTE_UNUSED_RESULT.
7635
7636 2019-03-05  Tom Tromey  <tromey@adacore.com>
7637
7638         * utils.h (class gdb_argv) <release>: Add
7639         ATTRIBUTE_UNUSED_RESULT.
7640         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7641
7642 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7643
7644         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7645         for-loop range, to avoid compiler warnings.
7646
7647         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7648         avoid compiler warnings about unused variables.
7649
7650         * NEWS: Mention end of support for native debugging on MS-Windows
7651         before XP.
7652
7653         PR gdb/24292
7654         * common/netstuff.c:
7655         * gdbserver/gdbreplay.c
7656         * gdbserver/remote-utils.c:
7657         * ser-tcp.c:
7658         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7659         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7660         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7661         'getaddrinfo' and 'freeaddrinfo' were not available before
7662         Windows XP, and mingw.org's MinGW headers by default define
7663         _WIN32_WINNT to 0x500.
7664
7665 2019-03-01  Gary Benson <gbenson@redhat.com>
7666
7667         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7668
7669 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7670             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7671
7672         PR gdb/8527
7673         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7674         set_sigint_trap, clear_sigint_trap.
7675
7676 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7677
7678         * target.c (target_detach): Clear the regcache and the
7679         frame cache.
7680
7681 2019-02-27  Pedro Alves  <palves@redhat.com>
7682
7683         * utils.c (set_screen_size): When we cap the height/width sizes,
7684         tweak the corresponding command variable to show "unlimited":
7685
7686 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7687             Pedro Alves  <palves@redhat.com>
7688
7689         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7690         before calling rl_set_screen_size.
7691
7692 2019-02-27  Tom Tromey  <tromey@adacore.com>
7693
7694         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7695         define.
7696         * python/py-value.c: Remove Python 2.4 workaround.
7697         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7698         workaround.
7699         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7700         Python 2.4 workaround.
7701         * python/python-internal.h: Remove Python 2.4 comment.
7702         (Py_ssize_t): Don't define.
7703         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7704         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7705         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7706         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7707         * python/python.c (do_start_initialization): Remove Python 2.4
7708         workaround.
7709         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7710         (print_children): Remove Python 2.4 workaround.
7711         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7712         workaround.
7713         (CHARBUFFERPROC_NAME): Remove.
7714         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7715         Python 2.4 workaround.
7716
7717 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7718
7719         * NEWS: Note minimum Python version.
7720
7721 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7722
7723         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7724         code from these functions.  Remove corresponding ifdefs.  Use
7725         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7726         Remove gotos and target of gotos.
7727         (infpy_search_memory): Likewise.
7728
7729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7730
7731         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7732         (hppa_gdbarch_init): Don't register deleted functions with
7733         gdbarch.
7734
7735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7736
7737         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7738         (h8300_unwind_sp): Delete.
7739         (h8300_dummy_id): Delete.
7740         (h8300_gdbarch_init): Don't register deleted functions with
7741         gdbarch.
7742
7743 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7744
7745         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7746         (ft32_unwind_pc): Delete.
7747         (ft32_unwind_sp): Delete.
7748         (ft32_gdbarch_init): Don't register deleted functions with
7749         gdbarch.
7750
7751 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7752
7753         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7754         (frv_unwind_pc): Delete.
7755         (frv_unwind_sp): Delete.
7756         (frv_gdbarch_init): Don't register deleted functions with
7757         gdbarch.
7758
7759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7762         (riscv_unwind_pc): Delete.
7763         (riscv_unwind_sp): Delete.
7764         (riscv_gdbarch_init): Don't register deleted functions with
7765         gdbarch.
7766
7767 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7768
7769         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7770         (csky_unwind_pc): Delete.
7771         (csky_unwind_sp): Delete.
7772         (csky_gdbarch_init): Don't register deleted functions with
7773         gdbarch.
7774
7775 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7778         (cris_unwind_pc): Delete.
7779         (cris_unwind_sp): Delete.
7780         (cris_gdbarch_init): Don't register deleted functions with
7781         gdbarch.
7782
7783 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7786         (bfin_unwind_pc): Delete.
7787         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7788
7789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7790
7791         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7792         (arm_unwind_pc): Delete.
7793         (arm_unwind_sp): Delete.
7794         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7795
7796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7797
7798         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7799         (arc_unwind_pc): Delete.
7800         (arc_unwind_sp): Delete.
7801         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7802
7803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7804
7805         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7806         (alpha_unwind_pc): Delete.
7807         (alpha_gdbarch_init): Don't register deleted functions with
7808         gdbarch.
7809
7810 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7811
7812         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7813         (aarch64_unwind_pc): Delete.
7814         (aarch64_unwind_sp): Delete.
7815         (aarch64_gdbarch_init): Don't register deleted functions with
7816         gdbarch.
7817
7818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7819
7820         * gdbtypes.c (type_align): Don't consider static members when
7821         computing structure alignment.
7822
7823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7824
7825         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7826         return 0 for other types.
7827         * arch-utils.c (default_type_align): Always return 0.
7828         * gdbarch.h: Regenerate.
7829         * gdbarch.sh (type_align): Extend comment.
7830         * gdbtypes.c (type_align): Add additional comments, always call
7831         gdbarch_type_align before applying the default rules.
7832         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7833         generic code will then apply a suitable default.
7834         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7835         types, return 0 for other types.
7836
7837 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7838
7839         * NEWS: Create a new section for the next release branch.
7840         Rename the section of the current branch, now that it has
7841         been cut.
7842
7843 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7844
7845         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7846         * version.in: Bump version to 8.3.50.DATE-git.
7847
7848 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7849
7850         * aix-thread.c (ptid_cmp): Remove unused variable.
7851         (get_signaled_thread): Likewise.
7852         (store_regs_user_thread): Likewise.
7853         (store_regs_kernel_thread): Likewise.
7854         (fetch_regs_kernel_thread): Remove shadowed variable.
7855
7856 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7857
7858         * features/riscv/32bit-cpu.xml: Add register numbers.
7859         * features/riscv/32bit-fpu.c: Regenerate.
7860         * features/riscv/32bit-fpu.xml: Add register numbers.
7861         * features/riscv/64bit-cpu.xml: Add register numbers.
7862         * features/riscv/64bit-fpu.c: Regenerate.
7863         * features/riscv/64bit-fpu.xml: Add register numbers.
7864
7865 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7866
7867         * NEWS: Mention two argument form of gdb.Value constructor.
7868         * python/py-value.c (convert_buffer_and_type_to_value): New
7869         function.
7870         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7871         Add support for handling an optional second argument.  Call
7872         convert_buffer_and_type_to_value as appropriate.
7873         * python/python-internal.h (Py_buffer_deleter): New struct.
7874         (Py_buffer_up): New typedef.
7875
7876 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7877
7878         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7879         instead of releasing ownership.
7880
7881 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7882
7883         * dwarf2read.c (open_and_init_dwp_file): Call
7884         elf_numsections instead of bfd_count_sections to initialize
7885         dwp_file->num_sections.
7886
7887 2019-02-25  Tom Tromey  <tromey@adacore.com>
7888
7889         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7890
7891 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7892
7893         * gcore.in: Add '--readnever' option when invoking GDB.
7894
7895 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7896
7897         * MAINTAINERS: Update my email address.
7898
7899 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7900
7901         * build-id.c (build_id_to_debug_bfd_1): New function.
7902         (build_id_to_debug_bfd): Look for separate debug file in
7903         sysroot.
7904
7905 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7906
7907         * gdbarch.sh: Update the copyright year range that is placed into
7908         generated files.
7909
7910 2019-02-22  Keith Seitz  <keiths@redhat.com>
7911
7912         PR symtab/23853
7913         * linespec.c (create_sals_line_offset): Search for the default
7914         symtab's filename instead of its fullname.
7915
7916 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7917
7918         * NEWS: Update style defaults.
7919
7920 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7921
7922         * main.c (captured_main_1): Disable styling in batch mode.
7923
7924 2019-02-20  Tom Tromey  <tom@tromey.com>
7925
7926         * symtab.c (symtab_symbol_info): Fix typos.
7927
7928 2019-02-20  Tom Tromey  <tromey@adacore.com>
7929
7930         * findcmd.c (_initialize_mem_search): Use upper case for
7931         metasyntactic variables.
7932
7933 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7934
7935         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7936         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7937
7938 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7939
7940         * top.h (source_file_name): Change to std::string.
7941         * top.c (source_file_name): Likewise.
7942         (command_line_input): Adjust.
7943         * cli/cli-script.c (script_from_file): Adjust.
7944
7945 2019-02-19  Tom Tromey  <tromey@adacore.com>
7946
7947         * ravenscar-thread.c
7948         (ravenscar_thread_target::update_thread_list): Don't call
7949         ada_build_task_list.
7950         * ada-lang.h (ada_build_task_list): Don't declare.
7951         * ada-tasks.c (struct ada_tasks_inferior_data)
7952         <task_list_valid_p>: Now bool.
7953         (read_known_tasks, ada_task_list_changed)
7954         (ada_tasks_invalidate_inferior_data): Update.
7955         (read_known_tasks_array): Return bool.
7956         (read_known_tasks_list): Likewise.
7957         (read_known_tasks): Return void.
7958         (ada_build_task_list): Now static.
7959
7960 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7961
7962         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7963         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7964
7965 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7966
7967         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7968         variant for ada_tasks_pspace_data_handle and
7969         ada_tasks_inferior_data_handle.
7970         (ada_tasks_pspace_data_cleanup): New function.
7971         (ada_tasks_inferior_data_cleanup): New function.
7972
7973 2019-02-17  Tom Tromey  <tom@tromey.com>
7974
7975         * macrotab.h (macro_source_fullname): Return a std::string.
7976         * macrotab.c (macro_include, check_for_redefinition)
7977         (macro_undef, macro_lookup_definition, foreach_macro)
7978         (foreach_macro_in_scope): Update.
7979         (macro_source_fullname): Return a std::string.
7980         * macrocmd.c (show_pp_source_pos): Update.
7981
7982 2019-02-17  Tom Tromey  <tom@tromey.com>
7983
7984         * macrocmd.c (show_pp_source_pos): Style the file names.
7985
7986 2019-02-17  Tom Tromey  <tom@tromey.com>
7987
7988         PR tui/24197:
7989         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7990
7991 2019-02-17  Tom Tromey  <tom@tromey.com>
7992
7993         * ada-lang.c (user_select_syms): Use filtered printing.
7994         * utils.c (wrap_style): New global.
7995         (desired_style): Remove.
7996         (emit_style_escape): Add stream parameter.
7997         (set_output_style, reset_terminal_style, prompt_for_continue):
7998         Update.
7999         (flush_wrap_buffer): Only flush gdb_stdout.
8000         (wrap_here): Set wrap_style.
8001         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8002         treat escape sequences as a character.  Change when wrap buffer is
8003         flushed.
8004         (fputs_styled): Do not set the output style when the default is
8005         requested.
8006         * ui-style.h (struct ui_file_style) <is_default>: New method.
8007         * source.c (print_source_lines_base): Emit escape sequences in one
8008         piece.
8009
8010 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8011
8012         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8013         integers and enumeration types.
8014
8015 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8016
8017         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8018         instead of lookup_symbol_in_language
8019         (do_exact_match): New function.
8020         (ada_get_symbol_name_matcher): Return do_exact_match when
8021         doing a verbatim match.
8022
8023 2019-02-15  Tom Tromey  <tromey@adacore.com>
8024
8025         * ravenscar-thread.c (ravenscar_thread_target::resume)
8026         (ravenscar_thread_target::wait): Special case wildcard requests.
8027
8028 2019-02-15  Tom Tromey  <tromey@adacore.com>
8029
8030         * ravenscar-thread.c (base_ptid): Remove.
8031         (struct ravenscar_thread_target) <close>: New method.
8032         <m_base_ptid>: New member.
8033         <update_inferior_ptid, active_task, task_is_currently_active,
8034         runtime_initialized>: Declare methods.
8035         <ravenscar_thread_target>: Add constructor.
8036         (ravenscar_thread_target::task_is_currently_active)
8037         (ravenscar_thread_target::update_inferior_ptid)
8038         (ravenscar_runtime_initialized): Rename.  Now methods.
8039         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8040         (ravenscar_thread_target::update_thread_list): Update.
8041         (ravenscar_thread_target::active_task): Now method.
8042         (ravenscar_thread_target::store_registers)
8043         (ravenscar_thread_target::prepare_to_store)
8044         (ravenscar_thread_target::prepare_to_store)
8045         (ravenscar_thread_target::mourn_inferior): Update.
8046         (ravenscar_inferior_created): Use "new" to create target.
8047         (ravenscar_thread_target::get_ada_task_ptid): Update.
8048         (_initialize_ravenscar): Don't initialize base_ptid.
8049         (ravenscar_ops): Remove global.
8050
8051 2019-02-15  Tom Tromey  <tromey@adacore.com>
8052
8053         * target.h (push_target): Declare new overload.
8054         * target.c (push_target): New overload, taking an rvalue reference.
8055         * remote.c (remote_target::open_1): Use push_target overload.
8056         * corelow.c (core_target_open): Use push_target overload.
8057
8058 2019-02-15  Tom Tromey  <tromey@adacore.com>
8059
8060         * ravenscar-thread.c (is_ravenscar_task)
8061         (ravenscar_task_is_currently_active): Return bool.
8062         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8063         (_initialize_ravenscar): Remove "(void)".
8064         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8065         Return bool.
8066
8067 2019-02-15  Tom Tromey  <tromey@adacore.com>
8068
8069         * ravenscar-thread.c (ravenscar_runtime_initializer)
8070         (has_ravenscar_runtime, get_running_thread_id)
8071         (ravenscar_thread_target::resume): Fix indentation.
8072
8073 2019-02-15  Tom Tromey  <tromey@adacore.com>
8074
8075         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8076         from ravenscar_arch_ops.
8077         (sparc_ravenscar_ops::fetch_registers)
8078         (sparc_ravenscar_ops::store_registers): Now methods.
8079         (sparc_ravenscar_prepare_to_store): Remove.
8080         (sparc_ravenscar_ops): Redefine.
8081         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8082         methods and destructor.  Remove members.
8083         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8084         (ravenscar_thread_target::store_registers)
8085         (ravenscar_thread_target::prepare_to_store): Update.
8086         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8087         Remove.
8088         (struct ppc_ravenscar_powerpc_ops): Derive from
8089         ravenscar_arch_ops.
8090         (ppc_ravenscar_powerpc_ops::fetch_registers)
8091         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8092         (ppc_ravenscar_powerpc_ops): Redefine.
8093         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8094         (ppc_ravenscar_e500_ops::fetch_registers)
8095         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8096         (ppc_ravenscar_e500_ops): Redefine.
8097         * aarch64-ravenscar-thread.c
8098         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8099         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8100         (aarch64_ravenscar_fetch_registers)
8101         (aarch64_ravenscar_store_registers): Now methods.
8102         (aarch64_ravenscar_ops): Redefine.
8103
8104 2019-02-15  Tom Tromey  <tromey@adacore.com>
8105
8106         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8107         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8108         (ravenscar_thread_target::stopped_by_watchpoint)
8109         (ravenscar_thread_target::stopped_data_address)
8110         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8111
8112 2019-02-15  Tom Tromey  <tromey@adacore.com>
8113
8114         * ravenscar-thread.c: Fix some typos.
8115
8116 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8117             Tom Tromey  <tromey@adacore.com>
8118
8119         * ada-lang.c (ada_exception_sal): Change addr_string to a
8120         std::string.
8121         (create_ada_exception_catchpoint): Update.
8122
8123 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8124             Tom Tromey  <tromey@adacore.com>
8125
8126         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8127         (bp_location_ops): Remove.
8128         (base_breakpoint_allocate_location): Update.
8129         (free_bp_location): Update.
8130         * ada-lang.c (class ada_catchpoint_location)
8131         <ada_catchpoint_location>: Remove ops parameter.
8132         (ada_catchpoint_location_dtor): Remove.
8133         (ada_catchpoint_location_ops): Remove.
8134         (allocate_location_exception): Update.
8135         * breakpoint.h (struct bp_location_ops): Remove.
8136         (class bp_location) <bp_location>: Remove bp_location_ops
8137         parameter.
8138         <~bp_location>: Add destructor.
8139         <ops>: Remove.
8140
8141 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8142             Pedro Alves  <palves@redhat.com>
8143
8144         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8145         'PATH_MAX'.
8146
8147 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8148             Samuel Thibault  <samuel.thibault@gnu.org>
8149             Thomas Schwinge  <thomas@codesourcery.com>
8150
8151         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8152         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8153
8154 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8155
8156         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8157         (check_empty): Use "const char *".
8158
8159         * gnu-nat.c (gnu_nat_target::detach): Instead of
8160         'detach_inferior (pid)' call
8161         'detach_inferior (find_inferior_pid (pid))'.
8162
8163         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8164         'nat/fork-inferior.o'.
8165         * gnu-nat.c: #include "nat/fork-inferior.h".
8166
8167         * gnu-nat.c (gnu_nat_target::detach): Instead of
8168         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8169         * gnu-nat.h: #include "inf-child.h".
8170         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8171         'i386_gnu_nat_target::fetch_registers'.
8172         (gnu_store_registers): Rename/move to
8173         'i386_gnu_nat_target::store_registers'.
8174
8175         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8176         * gnu-nat.h (mach_thread_info): New function.
8177         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8178
8179         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8180
8181 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8182
8183         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8184
8185 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8186
8187         * windows-nat.c (windows_add_thread): Add new parameter
8188         "main_thread_p" with default value set to false.  Update
8189         function documentation as well as all callers.
8190         (windows_delete_thread): Likewise.
8191         (fake_create_process): Update call to windows_add_thread.
8192         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8193         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8194         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8195         call to windows_delete_thread.
8196
8197 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8198
8199         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8200
8201 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8202
8203         * symfile.c (find_separate_debug_file): Use canonical path of
8204         sysroot with child_path instead of gdb_sysroot if it is valid.
8205
8206 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8207
8208         * symfile.c (find_separate_debug_file): Use child_path to
8209         determine if an object file is under a sysroot.
8210
8211 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8212
8213         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8214         unittests/child-path-selftests.c.
8215         * common/pathstuff.c (child_path): New function.
8216         * common/pathstuff.h (child_path): New prototype.
8217         * unittests/child-path-selftests.c: New file.
8218
8219 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8220
8221         * symfile.c (find_separate_debug_file): Look for separate debug
8222         files in debug directories under the sysroot.
8223
8224 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8225
8226         * symtab.h (struct minimal_symbol data_p): New const method.
8227         (struct minimal_symbol text_p): Likewise.
8228         * symtab.c (output_source_filename): Use file name style
8229         to print file name.
8230         (print_symbol_info): Likewise.
8231         (print_msymbol_info): Use address style to print addresses.
8232         Use function name style to print executable text symbols.
8233         (expand_symtab_containing_pc): Use data_p.
8234         (find_pc_sect_compunit_symtab): Likewise.
8235
8236 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8237
8238         * breakpoint.c (describe_other_breakpoints): Use address style
8239         to print addresses.
8240         (say_where): Likewise.
8241
8242 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8243
8244         * ada-typeprint.c (print_func_type): Print function name
8245         style to print function name.
8246         * c-typeprint.c (c_print_type_1): Likewise.
8247
8248 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8249
8250         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8251         for execve.
8252
8253 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8254
8255         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8256         type_stack.
8257
8258 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8259
8260         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8261         TYPE_CODE_REF types.
8262
8263 2019-02-08  Jim Wilson  <jimw@sifive.com>
8264
8265         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8266         (riscv_linux_fregset): New.
8267         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8268
8269 2019-02-07  Tom Tromey  <tom@tromey.com>
8270
8271         * thread.c (thread_cancel_execution_command): Update.
8272         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8273         methods.
8274         (struct thread_fsm_ops): Remove.
8275         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8276         (thread_fsm_should_stop, thread_fsm_return_value)
8277         (thread_fsm_set_finished, thread_fsm_finished_p)
8278         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8279         Don't declare.
8280         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8281         * infrun.c (clear_proceed_status_thread)
8282         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8283         (print_stop_event): Update.
8284         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8285         Add constructor.
8286         (step_command_fsm_ops): Remove.
8287         (new_step_command_fsm): Remove.
8288         (step_1): Update.
8289         (step_command_fsm::should_stop): Rename from
8290         step_command_fsm_should_stop.
8291         (step_command_fsm::clean_up): Rename from
8292         step_command_fsm_clean_up.
8293         (step_command_fsm::do_async_reply_reason): Rename from
8294         step_command_fsm_async_reply_reason.
8295         (struct until_next_fsm): Inherit from thread_fsm.  Add
8296         constructor.
8297         (until_next_fsm_ops): Remove.
8298         (new_until_next_fsm): Remove.
8299         (until_next_fsm::should_stop): Rename from
8300         until_next_fsm_should_stop.
8301         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8302         (until_next_fsm::do_async_reply_reason): Rename from
8303         until_next_fsm_async_reply_reason.
8304         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8305         constructor.  Change type of breakpoint.
8306         (finish_command_fsm_ops): Remove.
8307         (new_finish_command_fsm): Remove.
8308         (finish_command_fsm::should_stop): Rename from
8309         finish_command_fsm_should_stop.
8310         (finish_command_fsm::clean_up): Rename from
8311         finish_command_fsm_clean_up.
8312         (finish_command_fsm::return_value): Rename from
8313         finish_command_fsm_return_value.
8314         (finish_command_fsm::do_async_reply_reason): Rename from
8315         finish_command_fsm_async_reply_reason.
8316         (finish_command): Update.
8317         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8318         Add constructor.
8319         (call_thread_fsm_ops): Remove.
8320         (call_thread_fsm::call_thread_fsm): Rename from
8321         new_call_thread_fsm.
8322         (call_thread_fsm::should_stop): Rename from
8323         call_thread_fsm_should_stop.
8324         (call_thread_fsm::should_notify_stop): Rename from
8325         call_thread_fsm_should_notify_stop.
8326         (run_inferior_call, call_function_by_hand_dummy): Update.
8327         * cli/cli-interp.c (should_print_stop_to_console): Update.
8328         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8329         Add constructor.  Change type of location_breakpoint,
8330         caller_breakpoint.
8331         (until_break_fsm_ops): Remove.
8332         (new_until_break_fsm): Remove.
8333         (until_break_fsm::should_stop): Rename from
8334         until_break_fsm_should_stop.
8335         (until_break_fsm::clean_up): Rename from
8336         until_break_fsm_clean_up.
8337         (until_break_fsm::do_async_reply_reason): Rename from
8338         until_break_fsm_async_reply_reason.
8339         (until_break_command): Update.
8340         * thread-fsm.c: Remove.
8341         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8342
8343 2019-02-07  Tom Tromey  <tom@tromey.com>
8344
8345         * yy-remap.h: Add include guard.
8346         * xtensa-tdep.h: Add include guard.
8347         * xcoffread.h: Rename include guard.
8348         * varobj-iter.h: Add include guard.
8349         * tui/tui.h: Rename include guard.
8350         * tui/tui-winsource.h: Rename include guard.
8351         * tui/tui-wingeneral.h: Rename include guard.
8352         * tui/tui-windata.h: Rename include guard.
8353         * tui/tui-win.h: Rename include guard.
8354         * tui/tui-stack.h: Rename include guard.
8355         * tui/tui-source.h: Rename include guard.
8356         * tui/tui-regs.h: Rename include guard.
8357         * tui/tui-out.h: Rename include guard.
8358         * tui/tui-layout.h: Rename include guard.
8359         * tui/tui-io.h: Rename include guard.
8360         * tui/tui-hooks.h: Rename include guard.
8361         * tui/tui-file.h: Rename include guard.
8362         * tui/tui-disasm.h: Rename include guard.
8363         * tui/tui-data.h: Rename include guard.
8364         * tui/tui-command.h: Rename include guard.
8365         * tic6x-tdep.h: Add include guard.
8366         * target/waitstatus.h: Rename include guard.
8367         * target/wait.h: Rename include guard.
8368         * target/target.h: Rename include guard.
8369         * target/resume.h: Rename include guard.
8370         * target-float.h: Rename include guard.
8371         * stabsread.h: Add include guard.
8372         * rs6000-tdep.h: Add include guard.
8373         * riscv-fbsd-tdep.h: Add include guard.
8374         * regformats/regdef.h: Rename include guard.
8375         * record.h: Rename include guard.
8376         * python/python.h: Rename include guard.
8377         * python/python-internal.h: Rename include guard.
8378         * python/py-stopevent.h: Rename include guard.
8379         * python/py-ref.h: Rename include guard.
8380         * python/py-record.h: Rename include guard.
8381         * python/py-record-full.h: Rename include guard.
8382         * python/py-record-btrace.h: Rename include guard.
8383         * python/py-instruction.h: Rename include guard.
8384         * python/py-events.h: Rename include guard.
8385         * python/py-event.h: Rename include guard.
8386         * procfs.h: Add include guard.
8387         * proc-utils.h: Add include guard.
8388         * p-lang.h: Add include guard.
8389         * or1k-tdep.h: Rename include guard.
8390         * observable.h: Rename include guard.
8391         * nto-tdep.h: Rename include guard.
8392         * nat/x86-linux.h: Rename include guard.
8393         * nat/x86-linux-dregs.h: Rename include guard.
8394         * nat/x86-gcc-cpuid.h: Add include guard.
8395         * nat/x86-dregs.h: Rename include guard.
8396         * nat/x86-cpuid.h: Rename include guard.
8397         * nat/ppc-linux.h: Rename include guard.
8398         * nat/mips-linux-watch.h: Rename include guard.
8399         * nat/linux-waitpid.h: Rename include guard.
8400         * nat/linux-ptrace.h: Rename include guard.
8401         * nat/linux-procfs.h: Rename include guard.
8402         * nat/linux-osdata.h: Rename include guard.
8403         * nat/linux-nat.h: Rename include guard.
8404         * nat/linux-namespaces.h: Rename include guard.
8405         * nat/linux-btrace.h: Rename include guard.
8406         * nat/glibc_thread_db.h: Rename include guard.
8407         * nat/gdb_thread_db.h: Rename include guard.
8408         * nat/gdb_ptrace.h: Rename include guard.
8409         * nat/fork-inferior.h: Rename include guard.
8410         * nat/amd64-linux-siginfo.h: Rename include guard.
8411         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8412         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8413         * nat/aarch64-linux.h: Rename include guard.
8414         * nat/aarch64-linux-hw-point.h: Rename include guard.
8415         * mn10300-tdep.h: Add include guard.
8416         * mips-linux-tdep.h: Add include guard.
8417         * mi/mi-parse.h: Rename include guard.
8418         * mi/mi-out.h: Rename include guard.
8419         * mi/mi-main.h: Rename include guard.
8420         * mi/mi-interp.h: Rename include guard.
8421         * mi/mi-getopt.h: Rename include guard.
8422         * mi/mi-console.h: Rename include guard.
8423         * mi/mi-common.h: Rename include guard.
8424         * mi/mi-cmds.h: Rename include guard.
8425         * mi/mi-cmd-break.h: Rename include guard.
8426         * m2-lang.h: Add include guard.
8427         * location.h: Rename include guard.
8428         * linux-record.h: Rename include guard.
8429         * linux-nat.h: Add include guard.
8430         * linux-fork.h: Add include guard.
8431         * i386-darwin-tdep.h: Rename include guard.
8432         * hppa-linux-offsets.h: Add include guard.
8433         * guile/guile.h: Rename include guard.
8434         * guile/guile-internal.h: Rename include guard.
8435         * gnu-nat.h: Rename include guard.
8436         * gdb-stabs.h: Rename include guard.
8437         * frv-tdep.h: Add include guard.
8438         * f-lang.h: Add include guard.
8439         * event-loop.h: Add include guard.
8440         * darwin-nat.h: Rename include guard.
8441         * cp-abi.h: Rename include guard.
8442         * config/sparc/nm-sol2.h: Rename include guard.
8443         * config/nm-nto.h: Rename include guard.
8444         * config/nm-linux.h: Add include guard.
8445         * config/i386/nm-i386gnu.h: Rename include guard.
8446         * config/djgpp/nl_types.h: Rename include guard.
8447         * config/djgpp/langinfo.h: Rename include guard.
8448         * compile/gcc-cp-plugin.h: Add include guard.
8449         * compile/gcc-c-plugin.h: Add include guard.
8450         * compile/compile.h: Rename include guard.
8451         * compile/compile-object-run.h: Rename include guard.
8452         * compile/compile-object-load.h: Rename include guard.
8453         * compile/compile-internal.h: Rename include guard.
8454         * compile/compile-cplus.h: Rename include guard.
8455         * compile/compile-c.h: Rename include guard.
8456         * common/xml-utils.h: Rename include guard.
8457         * common/x86-xstate.h: Rename include guard.
8458         * common/version.h: Rename include guard.
8459         * common/vec.h: Rename include guard.
8460         * common/tdesc.h: Rename include guard.
8461         * common/selftest.h: Rename include guard.
8462         * common/scoped_restore.h: Rename include guard.
8463         * common/scoped_mmap.h: Rename include guard.
8464         * common/scoped_fd.h: Rename include guard.
8465         * common/safe-iterator.h: Rename include guard.
8466         * common/run-time-clock.h: Rename include guard.
8467         * common/refcounted-object.h: Rename include guard.
8468         * common/queue.h: Rename include guard.
8469         * common/ptid.h: Rename include guard.
8470         * common/print-utils.h: Rename include guard.
8471         * common/preprocessor.h: Rename include guard.
8472         * common/pathstuff.h: Rename include guard.
8473         * common/observable.h: Rename include guard.
8474         * common/netstuff.h: Rename include guard.
8475         * common/job-control.h: Rename include guard.
8476         * common/host-defs.h: Rename include guard.
8477         * common/gdb_wait.h: Rename include guard.
8478         * common/gdb_vecs.h: Rename include guard.
8479         * common/gdb_unlinker.h: Rename include guard.
8480         * common/gdb_unique_ptr.h: Rename include guard.
8481         * common/gdb_tilde_expand.h: Rename include guard.
8482         * common/gdb_sys_time.h: Rename include guard.
8483         * common/gdb_string_view.h: Rename include guard.
8484         * common/gdb_splay_tree.h: Rename include guard.
8485         * common/gdb_setjmp.h: Rename include guard.
8486         * common/gdb_ref_ptr.h: Rename include guard.
8487         * common/gdb_optional.h: Rename include guard.
8488         * common/gdb_locale.h: Rename include guard.
8489         * common/gdb_assert.h: Rename include guard.
8490         * common/filtered-iterator.h: Rename include guard.
8491         * common/filestuff.h: Rename include guard.
8492         * common/fileio.h: Rename include guard.
8493         * common/environ.h: Rename include guard.
8494         * common/common-utils.h: Rename include guard.
8495         * common/common-types.h: Rename include guard.
8496         * common/common-regcache.h: Rename include guard.
8497         * common/common-inferior.h: Rename include guard.
8498         * common/common-gdbthread.h: Rename include guard.
8499         * common/common-exceptions.h: Rename include guard.
8500         * common/common-defs.h: Rename include guard.
8501         * common/common-debug.h: Rename include guard.
8502         * common/cleanups.h: Rename include guard.
8503         * common/buffer.h: Rename include guard.
8504         * common/btrace-common.h: Rename include guard.
8505         * common/break-common.h: Rename include guard.
8506         * cli/cli-utils.h: Rename include guard.
8507         * cli/cli-style.h: Rename include guard.
8508         * cli/cli-setshow.h: Rename include guard.
8509         * cli/cli-script.h: Rename include guard.
8510         * cli/cli-interp.h: Rename include guard.
8511         * cli/cli-decode.h: Rename include guard.
8512         * cli/cli-cmds.h: Rename include guard.
8513         * charset-list.h: Add include guard.
8514         * buildsym-legacy.h: Rename include guard.
8515         * bfin-tdep.h: Add include guard.
8516         * ax.h: Rename include guard.
8517         * arm-linux-tdep.h: Add include guard.
8518         * arm-fbsd-tdep.h: Add include guard.
8519         * arch/xtensa.h: Rename include guard.
8520         * arch/tic6x.h: Add include guard.
8521         * arch/i386.h: Add include guard.
8522         * arch/arm.h: Rename include guard.
8523         * arch/arm-linux.h: Rename include guard.
8524         * arch/arm-get-next-pcs.h: Rename include guard.
8525         * arch/amd64.h: Add include guard.
8526         * arch/aarch64-insn.h: Rename include guard.
8527         * arch-utils.h: Rename include guard.
8528         * annotate.h: Add include guard.
8529         * amd64-darwin-tdep.h: Rename include guard.
8530         * aarch64-linux-tdep.h: Add include guard.
8531         * aarch64-fbsd-tdep.h: Add include guard.
8532         * aarch32-linux-nat.h: Add include guard.
8533
8534 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8535
8536         * macrotab.c (macro_define_internal): New function that
8537         factorizes macro_define_object_internal and macro_define_function
8538         code.
8539         (macro_define_object_internal): Use macro_define_internal.
8540         (macro_define_function): Likewise.
8541
8542 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8543
8544         * macrocmd.c (extract_identifier): Return
8545         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8546         callers.
8547
8548 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8549
8550         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8551
8552 2019-02-05  Tom Tromey  <tom@tromey.com>
8553
8554         * target.c (target_stack::unpush): Move assertion earlier.
8555
8556 2019-01-30  Tom Tromey  <tom@tromey.com>
8557
8558         PR python/23615:
8559         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8560         (gdbpy_parse_and_eval): Likewise.
8561         * python/python-internal.h (gdbpy_allow_threads): New class.
8562
8563 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8564
8565         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8566         (aarch64_fbsd_fpregmap): Move earlier.
8567         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8568         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8569         instead of individual calls to trad_frame_set_reg_addr.
8570         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8571         earlier.
8572         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8573         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8574         instead of individual calls to trad_frame_set_reg_addr.
8575
8576 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8577
8578         * CONTRIBUTE: Replace contribution list with wiki link.
8579
8580 2019-01-25  Tom Tromey  <tom@tromey.com>
8581
8582         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8583
8584 2019-01-25  Tom Tromey  <tom@tromey.com>
8585
8586         * xtensa-linux-nat.c: Fix common/ includes.
8587         * xml-support.h: Fix common/ includes.
8588         * xml-support.c: Fix common/ includes.
8589         * x86-linux-nat.c: Fix common/ includes.
8590         * windows-nat.c: Fix common/ includes.
8591         * varobj.h: Fix common/ includes.
8592         * varobj.c: Fix common/ includes.
8593         * value.c: Fix common/ includes.
8594         * valops.c: Fix common/ includes.
8595         * utils.c: Fix common/ includes.
8596         * unittests/xml-utils-selftests.c: Fix common/ includes.
8597         * unittests/utils-selftests.c: Fix common/ includes.
8598         * unittests/unpack-selftests.c: Fix common/ includes.
8599         * unittests/tracepoint-selftests.c: Fix common/ includes.
8600         * unittests/style-selftests.c: Fix common/ includes.
8601         * unittests/string_view-selftests.c: Fix common/ includes.
8602         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8603         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8604         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8605         * unittests/rsp-low-selftests.c: Fix common/ includes.
8606         * unittests/parse-connection-spec-selftests.c: Fix common/
8607         includes.
8608         * unittests/optional-selftests.c: Fix common/ includes.
8609         * unittests/offset-type-selftests.c: Fix common/ includes.
8610         * unittests/observable-selftests.c: Fix common/ includes.
8611         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8612         * unittests/memrange-selftests.c: Fix common/ includes.
8613         * unittests/memory-map-selftests.c: Fix common/ includes.
8614         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8615         * unittests/function-view-selftests.c: Fix common/ includes.
8616         * unittests/environ-selftests.c: Fix common/ includes.
8617         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8618         * unittests/common-utils-selftests.c: Fix common/ includes.
8619         * unittests/cli-utils-selftests.c: Fix common/ includes.
8620         * unittests/array-view-selftests.c: Fix common/ includes.
8621         * ui-file.c: Fix common/ includes.
8622         * tui/tui-io.c: Fix common/ includes.
8623         * tracepoint.h: Fix common/ includes.
8624         * tracepoint.c: Fix common/ includes.
8625         * tracefile-tfile.c: Fix common/ includes.
8626         * top.h: Fix common/ includes.
8627         * top.c: Fix common/ includes.
8628         * thread.c: Fix common/ includes.
8629         * target/waitstatus.h: Fix common/ includes.
8630         * target/waitstatus.c: Fix common/ includes.
8631         * target.h: Fix common/ includes.
8632         * target.c: Fix common/ includes.
8633         * target-memory.c: Fix common/ includes.
8634         * target-descriptions.c: Fix common/ includes.
8635         * symtab.h: Fix common/ includes.
8636         * symfile.c: Fix common/ includes.
8637         * stap-probe.c: Fix common/ includes.
8638         * spu-linux-nat.c: Fix common/ includes.
8639         * sparc-nat.c: Fix common/ includes.
8640         * source.c: Fix common/ includes.
8641         * solib.c: Fix common/ includes.
8642         * solib-target.c: Fix common/ includes.
8643         * ser-unix.c: Fix common/ includes.
8644         * ser-tcp.c: Fix common/ includes.
8645         * ser-pipe.c: Fix common/ includes.
8646         * ser-base.c: Fix common/ includes.
8647         * selftest-arch.c: Fix common/ includes.
8648         * s12z-tdep.c: Fix common/ includes.
8649         * rust-exp.y: Fix common/ includes.
8650         * rs6000-aix-tdep.c: Fix common/ includes.
8651         * riscv-tdep.c: Fix common/ includes.
8652         * remote.c: Fix common/ includes.
8653         * remote-notif.h: Fix common/ includes.
8654         * remote-fileio.h: Fix common/ includes.
8655         * remote-fileio.c: Fix common/ includes.
8656         * regcache.h: Fix common/ includes.
8657         * regcache.c: Fix common/ includes.
8658         * record-btrace.c: Fix common/ includes.
8659         * python/python.c: Fix common/ includes.
8660         * python/py-type.c: Fix common/ includes.
8661         * python/py-inferior.c: Fix common/ includes.
8662         * progspace.h: Fix common/ includes.
8663         * producer.c: Fix common/ includes.
8664         * procfs.c: Fix common/ includes.
8665         * proc-api.c: Fix common/ includes.
8666         * printcmd.c: Fix common/ includes.
8667         * ppc-linux-nat.c: Fix common/ includes.
8668         * parser-defs.h: Fix common/ includes.
8669         * osdata.c: Fix common/ includes.
8670         * obsd-nat.c: Fix common/ includes.
8671         * nat/x86-linux.c: Fix common/ includes.
8672         * nat/x86-linux-dregs.c: Fix common/ includes.
8673         * nat/x86-dregs.h: Fix common/ includes.
8674         * nat/x86-dregs.c: Fix common/ includes.
8675         * nat/ppc-linux.c: Fix common/ includes.
8676         * nat/mips-linux-watch.h: Fix common/ includes.
8677         * nat/mips-linux-watch.c: Fix common/ includes.
8678         * nat/linux-waitpid.c: Fix common/ includes.
8679         * nat/linux-ptrace.h: Fix common/ includes.
8680         * nat/linux-ptrace.c: Fix common/ includes.
8681         * nat/linux-procfs.c: Fix common/ includes.
8682         * nat/linux-personality.c: Fix common/ includes.
8683         * nat/linux-osdata.c: Fix common/ includes.
8684         * nat/linux-namespaces.c: Fix common/ includes.
8685         * nat/linux-btrace.h: Fix common/ includes.
8686         * nat/linux-btrace.c: Fix common/ includes.
8687         * nat/fork-inferior.c: Fix common/ includes.
8688         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8689         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8690         * nat/aarch64-linux.c: Fix common/ includes.
8691         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8692         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8693         * namespace.h: Fix common/ includes.
8694         * mips-linux-tdep.c: Fix common/ includes.
8695         * minsyms.c: Fix common/ includes.
8696         * mi/mi-parse.h: Fix common/ includes.
8697         * mi/mi-main.c: Fix common/ includes.
8698         * mi/mi-cmd-env.c: Fix common/ includes.
8699         * memrange.h: Fix common/ includes.
8700         * memattr.c: Fix common/ includes.
8701         * maint.h: Fix common/ includes.
8702         * maint.c: Fix common/ includes.
8703         * main.c: Fix common/ includes.
8704         * machoread.c: Fix common/ includes.
8705         * location.c: Fix common/ includes.
8706         * linux-thread-db.c: Fix common/ includes.
8707         * linux-nat.c: Fix common/ includes.
8708         * linux-fork.c: Fix common/ includes.
8709         * inline-frame.c: Fix common/ includes.
8710         * infrun.c: Fix common/ includes.
8711         * inflow.c: Fix common/ includes.
8712         * inferior.h: Fix common/ includes.
8713         * inferior.c: Fix common/ includes.
8714         * infcmd.c: Fix common/ includes.
8715         * inf-ptrace.c: Fix common/ includes.
8716         * inf-child.c: Fix common/ includes.
8717         * ia64-linux-nat.c: Fix common/ includes.
8718         * i387-tdep.c: Fix common/ includes.
8719         * i386-tdep.c: Fix common/ includes.
8720         * i386-linux-tdep.c: Fix common/ includes.
8721         * i386-linux-nat.c: Fix common/ includes.
8722         * i386-go32-tdep.c: Fix common/ includes.
8723         * i386-fbsd-tdep.c: Fix common/ includes.
8724         * i386-fbsd-nat.c: Fix common/ includes.
8725         * guile/scm-type.c: Fix common/ includes.
8726         * guile/guile.c: Fix common/ includes.
8727         * go32-nat.c: Fix common/ includes.
8728         * gnu-nat.c: Fix common/ includes.
8729         * gdbthread.h: Fix common/ includes.
8730         * gdbarch-selftests.c: Fix common/ includes.
8731         * gdb_usleep.c: Fix common/ includes.
8732         * gdb_select.h: Fix common/ includes.
8733         * gdb_bfd.c: Fix common/ includes.
8734         * gcore.c: Fix common/ includes.
8735         * fork-child.c: Fix common/ includes.
8736         * findvar.c: Fix common/ includes.
8737         * fbsd-nat.c: Fix common/ includes.
8738         * event-top.c: Fix common/ includes.
8739         * event-loop.c: Fix common/ includes.
8740         * dwarf2read.c: Fix common/ includes.
8741         * dwarf2loc.c: Fix common/ includes.
8742         * dwarf2-frame.c: Fix common/ includes.
8743         * dwarf-index-cache.c: Fix common/ includes.
8744         * dtrace-probe.c: Fix common/ includes.
8745         * disasm-selftests.c: Fix common/ includes.
8746         * defs.h: Fix common/ includes.
8747         * csky-tdep.c: Fix common/ includes.
8748         * cp-valprint.c: Fix common/ includes.
8749         * cp-support.h: Fix common/ includes.
8750         * cp-support.c: Fix common/ includes.
8751         * corelow.c: Fix common/ includes.
8752         * completer.h: Fix common/ includes.
8753         * completer.c: Fix common/ includes.
8754         * compile/compile.c: Fix common/ includes.
8755         * compile/compile-loc2c.c: Fix common/ includes.
8756         * compile/compile-cplus-types.c: Fix common/ includes.
8757         * compile/compile-cplus-symbols.c: Fix common/ includes.
8758         * command.h: Fix common/ includes.
8759         * cli/cli-dump.c: Fix common/ includes.
8760         * cli/cli-cmds.c: Fix common/ includes.
8761         * charset.c: Fix common/ includes.
8762         * build-id.c: Fix common/ includes.
8763         * btrace.h: Fix common/ includes.
8764         * btrace.c: Fix common/ includes.
8765         * breakpoint.h: Fix common/ includes.
8766         * breakpoint.c: Fix common/ includes.
8767         * ax.h:
8768         (enum agent_op): Fix common/ includes.
8769         * ax-general.c (struct aop_map): Fix common/ includes.
8770         * ax-gdb.c: Fix common/ includes.
8771         * auxv.c: Fix common/ includes.
8772         * auto-load.c: Fix common/ includes.
8773         * arm-tdep.c: Fix common/ includes.
8774         * arch/riscv.c: Fix common/ includes.
8775         * arch/ppc-linux-common.c: Fix common/ includes.
8776         * arch/i386.c: Fix common/ includes.
8777         * arch/arm.c: Fix common/ includes.
8778         * arch/arm-linux.c: Fix common/ includes.
8779         * arch/arm-get-next-pcs.c: Fix common/ includes.
8780         * arch/amd64.c: Fix common/ includes.
8781         * arch/aarch64.c: Fix common/ includes.
8782         * arch/aarch64-insn.c: Fix common/ includes.
8783         * arch-utils.c: Fix common/ includes.
8784         * amd64-windows-tdep.c: Fix common/ includes.
8785         * amd64-tdep.c: Fix common/ includes.
8786         * amd64-sol2-tdep.c: Fix common/ includes.
8787         * amd64-obsd-tdep.c: Fix common/ includes.
8788         * amd64-nbsd-tdep.c: Fix common/ includes.
8789         * amd64-linux-tdep.c: Fix common/ includes.
8790         * amd64-linux-nat.c: Fix common/ includes.
8791         * amd64-fbsd-tdep.c: Fix common/ includes.
8792         * amd64-fbsd-nat.c: Fix common/ includes.
8793         * amd64-dicos-tdep.c: Fix common/ includes.
8794         * amd64-darwin-tdep.c: Fix common/ includes.
8795         * agent.c: Fix common/ includes.
8796         * ada-lang.h: Fix common/ includes.
8797         * ada-lang.c: Fix common/ includes.
8798         * aarch64-tdep.c: Fix common/ includes.
8799
8800 2019-01-25  Tom Tromey  <tom@tromey.com>
8801
8802         * common/create-version.sh: Use common/version.h.
8803
8804 2019-01-24  Pedro Alves  <palves@redhat.com>
8805
8806         * infrun.c (signal_stop, signal_print, signal_program)
8807         (signal_catch, signal_pass): Now arrays instead of pointers.
8808         (update_signals_program_target, do_target_resume)
8809         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8810         * linux-nat.c (linux_nat_target::pass_signals)
8811         (linux_nat_target::create_inferior, linux_nat_target::attach):
8812         Adjust.
8813         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8814         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8815         * procfs.c (procfs_target::pass_signals): Adjust.
8816         * record-full.c (record_full_target::resume): Adjust.
8817         * remote.c (remote_target::pass_signals)
8818         (remote_target::program_signals): Adjust.
8819         * target-debug.h (target_debug_print_signals): Now takes a
8820         gdb::array_view as parameter.  Adjust.
8821         * target.h (target_ops) <pass_signals, program_signals>: Replace
8822         pointer and length parameters with gdb::array_view.
8823         (target_pass_signals, target_program_signals): Likewise.
8824         * target-delegates.c: Regenerate.
8825
8826 2019-01-24  Pedro Alves  <palves@redhat.com>
8827
8828         * common/forward-scope-exit.h
8829         (forward_scope_exit::forward_scope_exit): Pass arguments to
8830         m_bind_function directly, instead of creating a std::bind and
8831         copying that.
8832
8833 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8834
8835         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8836         for static members.
8837         (pass_in_v_vfp_candidate): Likewise.
8838
8839 2019-01-23  Tom Tromey  <tom@tromey.com>
8840             Pedro Alves  <palves@redhat.com>
8841
8842         * regcache.c (class regcache_invalidator): Remove.
8843         (regcache::raw_write): Use make_scope_exit.
8844
8845 2019-01-23  Tom Tromey  <tom@tromey.com>
8846
8847         * ui-out.h (class ui_out_emit_type): Update comment.
8848
8849 2019-01-23  Tom Tromey  <tom@tromey.com>
8850
8851         * infrun.c (fetch_inferior_event): Update comment.
8852
8853 2019-01-23  Tom Tromey  <tom@tromey.com>
8854             Pedro Alves  <palves@redhat.com>
8855
8856         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8857         parameter.
8858         (fetch_inferior_event): Use SCOPE_EXIT.
8859
8860
8861 2019-01-23  Tom Tromey  <tom@tromey.com>
8862             Pedro Alves  <palves@redhat.com>
8863
8864         * infrun.c (disable_thread_events): Delete.
8865         (stop_all_threads): Use SCOPE_EXIT.
8866
8867 2019-01-23  Tom Tromey  <tom@tromey.com>
8868             Pedro Alves  <palves@redhat.com>
8869
8870         * symfile.c: Include forward-scope-exit.h.
8871         (clear_symtab_users_cleanup): Replace forward declaration with
8872         a FORWARD_SCOPE_EXIT.
8873         (syms_from_objfile_1): Use the forward_scope_exit and
8874         gdb::optional instead of cleanup_function.
8875         (reread_symbols): Use the forward_scope_exit instead of
8876         cleanup_function.
8877         (clear_symtab_users_cleanup): Remove function.
8878
8879 2019-01-23  Tom Tromey  <tom@tromey.com>
8880             Pedro Alves  <palves@redhat.com>
8881
8882         * linux-nat.c: Include scope-exit.h.
8883         (cleanup_target_stop): Remove.
8884         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8885         SCOPE_EXIT.
8886
8887 2019-01-23  Tom Tromey  <tom@tromey.com>
8888             Pedro Alves  <palves@redhat.com>
8889
8890         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8891         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8892
8893 2019-01-23  Tom Tromey  <tom@tromey.com>
8894             Andrew Burgess  <andrew.burgess@embecosm.com>
8895             Pedro Alves  <palves@redhat.com>
8896
8897         * infrun.c (fetch_inferior_event): Use scope_exit.
8898         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8899         * top.c (execute_command): Use scope_exit.
8900         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8901         * utils.c (do_bpstat_clear_actions_cleanup)
8902         (make_bpstat_clear_actions_cleanup): Remove.
8903
8904 2019-01-23  Tom Tromey  <tom@tromey.com>
8905             Pedro Alves  <palves@redhat.com>
8906
8907         * infrun.c: Include "common/scope-exit.h"
8908         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8909         (wait_for_inferior): Use SCOPE_EXIT.
8910         (fetch_inferior_event): Use scope_exit.
8911
8912 2019-01-23  Tom Tromey  <tom@tromey.com>
8913             Pedro Alves  <palves@redhat.com>
8914
8915         * breakpoint.c (create_breakpoint): Remove cleanup.
8916
8917 2019-01-23  Tom Tromey  <tom@tromey.com>
8918             Andrew Burgess  <andrew.burgess@embecosm.com>
8919             Pedro Alves  <palves@redhat.com>
8920
8921 2019-01-23  Pedro Alves  <palves@redhat.com>
8922
8923         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8924
8925 2019-01-23  Pedro Alves  <palves@redhat.com>
8926             Andrew Burgess  <andrew.burgess@embecosm.com>
8927
8928         * gdbthread.h: Include "common/forward-scope-exit.h".
8929         (scoped_finish_thread_state): Redefine custom class in terms of
8930         forward_scope_exit.
8931
8932 2019-01-23  Pedro Alves  <palves@redhat.com>
8933             Andrew Burgess  <andrew.burgess@embecosm.com>
8934
8935         * common/forward-scope-exit.h: New file.
8936
8937 2019-01-23  Pedro Alves  <palves@redhat.com>
8938             Andrew Burgess  <andrew.burgess@embecosm.com>
8939             Tom Tromey  <tom@tromey.com>
8940
8941         * common/scope-exit.h: New file.
8942
8943 2019-01-23  Pedro Alves  <palves@redhat.com>
8944
8945         * common/preprocessor.h (ESC): Rename to ...
8946         (ESC_PARENS): ... this.
8947         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8948         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8949
8950 2019-01-23  Tom Tromey  <tom@tromey.com>
8951
8952         * language.h (class scoped_switch_to_sym_language_if_auto):
8953         Initialize m_lang in both cases.
8954
8955 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8956
8957         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8958         with XCNEW.
8959
8960 2019-01-22  Tom Tromey  <tom@tromey.com>
8961
8962         * corelow.c: Do not include sys/file.h.
8963
8964 2019-01-22  Tom Tromey  <tom@tromey.com>
8965
8966         * tui/tui-wingeneral.h: Include gdb_curses.h.
8967
8968 2019-01-22  Tom Tromey  <tom@tromey.com>
8969
8970         * source-cache.h (class source_cache) <get_source_lines,
8971         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8972
8973 2019-01-22  Tom Tromey  <tom@tromey.com>
8974
8975         * remote-fileio.h (struct remote_target): Declare.
8976
8977 2019-01-22  Tom Tromey  <tom@tromey.com>
8978
8979         * python/py-arch.c: Do not include py-ref.h.
8980         * python/py-bpevent.c: Do not include py-ref.h.
8981         * python/py-cmd.c: Do not include py-ref.h.
8982         * python/py-continueevent.c: Do not include py-ref.h.
8983         * python/py-event.h: Do not include py-ref.h.
8984         * python/py-evtregistry.c: Do not include py-ref.h.
8985         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8986         * python/py-frame.c: Do not include py-ref.h.
8987         * python/py-framefilter.c: Do not include py-ref.h.
8988         * python/py-function.c: Do not include py-ref.h.
8989         * python/py-infevents.c: Do not include py-ref.h.
8990         * python/py-linetable.c: Do not include py-ref.h.
8991         * python/py-objfile.c: Do not include py-ref.h.
8992         * python/py-param.c: Do not include py-ref.h.
8993         * python/py-prettyprint.c: Do not include py-ref.h.
8994         * python/py-progspace.c: Do not include py-ref.h.
8995         * python/py-symbol.c: Do not include py-ref.h.
8996         * python/py-symtab.c: Do not include py-ref.h.
8997         * python/py-type.c: Do not include py-ref.h.
8998         * python/py-unwind.c: Do not include py-ref.h.
8999         * python/py-utils.c: Do not include py-ref.h.
9000         * python/py-value.c: Do not include py-ref.h.
9001         * python/py-varobj.c: Do not include py-ref.h.
9002         * python/py-xmethods.c: Do not include py-ref.h.
9003         * python/python.c: Do not include py-ref.h.
9004         * varobj.c: Do not include py-ref.h.
9005
9006 2019-01-22  Tom Tromey  <tom@tromey.com>
9007
9008         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9009         keyword for bcache.
9010
9011 2019-01-22  Tom Tromey  <tom@tromey.com>
9012
9013         * compile/compile-cplus-types.c: Remove a comment by #include.
9014
9015 2019-01-22  Tom Tromey  <tom@tromey.com>
9016
9017         * compile/gcc-c-plugin.h: Include compile-internal.h.
9018
9019 2019-01-22  Tom Tromey  <tom@tromey.com>
9020
9021         * stabsread.c (EXTERN): Do not define.
9022         (symnum, next_symbol_text_func, processing_gcc_compilation)
9023         (within_function, global_sym_chain, global_stabs)
9024         (previous_stab_code, this_object_header_files)
9025         (n_this_object_header_files)
9026         (n_allocated_this_object_header_files): Define.
9027         * stabsread.h (EXTERN): Never define.  Use "extern".
9028
9029 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9030
9031         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9032         history_value.
9033
9034 2019-01-21  Tom Tromey  <tom@tromey.com>
9035
9036         * ui-out.c: Fix includes.
9037         * tui/tui-source.c: Fix includes.
9038         * target.c: Fix includes.
9039         * remote.c: Fix includes.
9040         * regcache.c: Fix includes.
9041         * python/py-block.c: Fix includes.
9042         * printcmd.c: Fix includes.
9043         * or1k-tdep.c: Fix includes.
9044         * mi/mi-main.c: Fix includes.
9045         * m32r-tdep.c: Fix includes.
9046         * csky-tdep.c: Fix includes.
9047         * compile/compile-cplus-types.c: Fix includes.
9048         * cli/cli-interp.c: Fix includes.
9049
9050 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9051
9052         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9053         for padding.
9054
9055 2019-01-16  Tom Tromey  <tom@tromey.com>
9056
9057         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9058         earlier.
9059         (struct objfile) <msymbols_range>: Move from top level.
9060         <msymbols>: New method.
9061         (class objfile_msymbols): Remove.
9062         * symtab.c (default_collect_symbol_completion_matches_break_on):
9063         Update.
9064         * symmisc.c (dump_msymbols): Update.
9065         * stabsread.c (scan_file_globals): Update.
9066         * objc-lang.c (info_selectors_command, info_classes_command)
9067         (find_methods): Update.
9068         * minsyms.c (find_solib_trampoline_target): Update.
9069         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9070         * coffread.c (coff_symfile_read): Update.
9071         * ada-lang.c (ada_lookup_simple_minsym)
9072         (ada_collect_symbol_completion_matches): Update.
9073
9074 2019-01-16  Tom Tromey  <tom@tromey.com>
9075
9076         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9077         type.  Remove no-argument constructor.
9078         <iterator::operator++>: Simplify.
9079         <begin>: Update.
9080         <end>: Use minimal_symbol_count.
9081
9082 2019-01-16  Tom Tromey  <tom@tromey.com>
9083
9084         * objfiles.h (struct objfile) <psymtabs>: New method.
9085         (class objfile_psymtabs): Remove.
9086         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9087         typedef.
9088         <range>: New method.
9089         (require_partial_symbols): Change return type.
9090         * psymtab.c (require_partial_symbols)
9091         (psym_expand_symtabs_matching): Update.
9092         * mdebugread.c (parse_partial_symbols): Update.
9093         * dbxread.c (dbx_end_psymtab): Update.
9094
9095 2019-01-15  Tom Tromey  <tom@tromey.com>
9096
9097         * symtab.c (lookup_objfile_from_block)
9098         (lookup_symbol_in_objfile_symtabs)
9099         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9100         (find_line_symtab, info_sources_command)
9101         (default_collect_symbol_completion_matches_break_on)
9102         (make_source_files_completion_list): Update.
9103         * symmisc.c (print_objfile_statistics, dump_objfile)
9104         (maintenance_print_symbols, maintenance_info_symtabs)
9105         (maintenance_check_symtabs, maintenance_info_line_tables):
9106         Update.
9107         * source.c (select_source_symtab)
9108         (forget_cached_source_info_for_objfile): Update.
9109         * objfiles.h (class objfile_compunits): Remove.
9110         (struct objfile) <compunits_range>: New typedef.
9111         (compunits): New method.
9112         * objfiles.c (objfile_relocate1): Update.
9113         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9114         * maint.c (count_symtabs_and_blocks): Update.
9115         * linespec.c (iterate_over_all_matching_symtabs): Update.
9116         * cp-support.c (add_symbol_overload_list_qualified): Update.
9117         * coffread.c (coff_symtab_read): Update.
9118         * ada-lang.c (add_nonlocal_symbols)
9119         (ada_collect_symbol_completion_matches)
9120         (ada_add_global_exceptions): Update.
9121
9122 2019-01-15  Tom Tromey  <tom@tromey.com>
9123
9124         * progspace.h (program_space) <objfiles_safe_range>: New
9125         typedef.
9126         <objfiles_safe>: New method.
9127         * objfiles.h (class all_objfiles_safe): Remove.
9128         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9129         * jit.c (jit_inferior_exit_hook): Update.
9130
9131 2019-01-17  Tom Tromey  <tom@tromey.com>
9132
9133         * progspace.h (program_space) <objfiles_range>: New typedef.
9134         <objfiles>: New method.
9135         <objfiles_head>: Rename from objfiles.
9136         (object_files): Update.
9137         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9138         * guile/scm-pretty-print.c
9139         (ppscm_find_pretty_printer_from_objfiles): Update.
9140         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9141         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9142         Update.
9143         * python/py-progspace.c (pspy_get_objfiles): Update.
9144         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9145         Update.
9146         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9147         (objfpy_lookup_objfile_by_build_id): Update.
9148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9149         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9150         Update.
9151         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9152         (expand_symtab_containing_pc, lookup_objfile_from_block)
9153         (lookup_static_symbol, basic_lookup_transparent_type)
9154         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9155         (find_line_symtab, info_sources_command)
9156         (default_collect_symbol_completion_matches_break_on)
9157         (make_source_files_completion_list, find_main_name): Update.
9158         * symmisc.c (print_symbol_bcache_statistics)
9159         (print_objfile_statistics, maintenance_print_symbols)
9160         (maintenance_print_msymbols, maintenance_print_objfiles)
9161         (maintenance_info_symtabs, maintenance_check_symtabs)
9162         (maintenance_expand_symtabs, maintenance_info_line_tables):
9163         Update.
9164         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9165         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9166         (map_overlay_command, unmap_overlay_command)
9167         (simple_overlay_update, expand_symtabs_matching)
9168         (map_symbol_filenames): Update.
9169         * symfile-debug.c (set_debug_symfile): Update.
9170         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9171         Update.
9172         * source.c (select_source_symtab, forget_cached_source_info):
9173         Update.
9174         * solib.c (solib_read_symbols): Update.
9175         * solib-spu.c (append_ocl_sos): Update.
9176         * psymtab.c (maintenance_print_psymbols)
9177         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9178         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9179         * printcmd.c (info_symbol_command): Update.
9180         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9181         Update.
9182         * objfiles.h (class all_objfiles): Remove.
9183         * objfiles.c (have_partial_symbols, have_full_symbols)
9184         (have_minimal_symbols, qsort_cmp, update_section_map)
9185         (shared_objfile_contains_address_p)
9186         (default_iterate_over_objfiles_in_search_order): Update.
9187         * objc-lang.c (info_selectors_command, info_classes_command)
9188         (find_methods): Update.
9189         * minsyms.c (find_solib_trampoline_target): Update.
9190         * maint.c (maintenance_info_sections)
9191         (maintenance_translate_address, count_symtabs_and_blocks):
9192         Update.
9193         * main.c (captured_main_1): Update.
9194         * linux-thread-db.c (try_thread_db_load_from_pdir)
9195         (has_libpthread): Update.
9196         * linespec.c (iterate_over_all_matching_symtabs)
9197         (search_minsyms_for_name): Update.
9198         * jit.c (jit_find_objf_with_entry_addr): Update.
9199         * hppa-tdep.c (find_unwind_entry)
9200         (hppa_lookup_stub_minimal_symbol): Update.
9201         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9202         Update.
9203         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9204         (elf_gnu_ifunc_resolve_by_got): Update.
9205         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9206         * dwarf-index-write.c (save_gdb_index_command): Update.
9207         * cp-support.c (add_symbol_overload_list_qualified): Update.
9208         * breakpoint.c (create_overlay_event_breakpoint)
9209         (create_longjmp_master_breakpoint)
9210         (create_std_terminate_master_breakpoint)
9211         (create_exception_master_breakpoint): Update.
9212         * blockframe.c (find_pc_partial_function): Update.
9213         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9214         (ada_collect_symbol_completion_matches)
9215         (ada_add_global_exceptions): Update.
9216
9217 2019-01-17  Tom Tromey  <tom@tromey.com>
9218
9219         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9220         declare VEC.
9221         (solib_target_parse_libraries): Change return type.
9222         (library_list_start_segment, library_list_start_section)
9223         (library_list_end_library, library_list_start_library); Update.
9224         (solib_target_free_library_list): Remove.
9225         (solib_target_parse_libraries): Remove cleanup.  Change return
9226         type.
9227         (solib_target_current_sos): Update.
9228
9229 2019-01-17  Tom Tromey  <tromey@bapiya>
9230
9231         * valprint.c: Replace "the the" with "the".
9232         * symtab.c: Replace "the the" with "the".
9233         * solib.c: Replace "the the" with "the".
9234         * solib-dsbt.c: Replace "the the" with "the".
9235         * linespec.c: Replace "the the" with "the".
9236         * dwarf2loc.h: Replace "the the" with "the".
9237         * amd64-windows-tdep.c: Replace "the the" with "the".
9238         * aarch64-tdep.c: Replace "the the" with "the".
9239
9240 2019-01-16  Keith Seitz  <keiths@redhat.com>
9241
9242         PR gdb/23773
9243         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9244         <builder>: Rename to ..
9245         <m_builder>: ... this and make private.
9246         (dwarf2_cu::get_builder): New method.  Change all users of
9247         `builder' to use this method.
9248         (dwarf2_start_symtab): Move to ...
9249         (dwarf2_cu::start_symtab): ... here.  Update all callers
9250         (setup_type_unit_groups): Move to ...
9251         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9252         callers.
9253         (dwarf2_cu::reset_builder): New method.
9254         (process_full_compunit, process_full_type_unit): Use
9255         dwarf2_cu::reset_builder.
9256         (follow_die_offset): Record the ancestor CU if it is different
9257         from the followed DIE's CU.
9258         (follow_die_sig_1): Likewise.
9259
9260 2019-01-15  Tom Tromey  <tom@tromey.com>
9261
9262         * remote.c (class remote_state) <buf>: Now a char_vector.
9263         <buf_size>: Remove.
9264         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9265         parameter.
9266         (remote_target::getpkt_or_notif_sane_1)
9267         (remote_target::getpkt_sane)
9268         (remote_target::getpkt_or_notif_sane): Likewise.
9269         (class remote_target) <putpkt>: New overload.
9270         (remote_target::read_frame): Change type of "buf_p".  Remove
9271         sizeof_p parameter.
9272         (packet_ok): New overload.
9273         (packet_check_result): New overload.
9274         Update all uses.
9275
9276 2019-01-14  Tom Tromey  <tom@tromey.com>
9277
9278         * remote-notif.c (handle_notification, remote_notif_ack)
9279         (remote_notif_parse): Make "buf" const.
9280         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9281         const.
9282         (remote_notif_parse, remote_notif_ack, handle_notification):
9283         Likewise.
9284         * remote.c (remote_notif_stop_parse): Make "buf" const.
9285         (remote_target::remote_parse_stop_reply): Make "buf" const.
9286         (remote_notif_stop_ack): Make "buf" const.
9287
9288 2019-01-14  Tom Tromey  <tom@tromey.com>
9289
9290         * remote.c (remote_console_output): Make parameter const.
9291
9292 2019-01-14  Tom Tromey  <tom@tromey.com>
9293
9294         * target-debug.h (target_debug_print_signals): Constify.
9295         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9296         * procfs.c (procfs_target::pass_signals): Update.
9297         * linux-nat.c (linux_nat_target::pass_signals): Update.
9298         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9299         * target-delegates.c: Rebuild.
9300         * remote.c (remote_target::program_signals): Update.
9301         (remote_target::pass_signals): Update.
9302         * target.c (target_pass_signals): Constify argument.
9303         (target_program_signals): Likewise.
9304         * target.h (struct target_ops) <pass_signals, program_signals>:
9305         Constify argument.
9306         (target_pass_signals, target_program_signals): Constify argument.
9307
9308 2019-01-14  Tom Tromey  <tom@tromey.com>
9309
9310         PR tui/28819:
9311         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9312
9313 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9314
9315         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9316         field.
9317         * rs6000-tdep.c: Include reggroups.h.
9318         (IS_V_ALIAS_PSEUDOREG): Define.
9319         (rs6000_register_name): Return names for the "vX" aliases.
9320         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9321         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9322         aliases.  Call default_register_reggroup_p for all other
9323         pseudo-registers.
9324         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9325         New functions.
9326         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9327         Handle "vX" aliases.
9328         (v_alias_pseudo_register_collect): New function.
9329         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9330         (rs6000_gdbarch_init): Initialize "vX" aliases as
9331         pseudo-registers.  Restore registration of
9332         rs6000_pseudo_register_reggroup_p with
9333         set_tdesc_pseudo_register_reggroup_p.
9334
9335 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9336
9337         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9338         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9339         set_gdbarch_num_pseudo_regs.
9340
9341 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9342
9343         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9344         Remove arg prefixname, add do_set and do_show.
9345         Add member functions set_list and show_list.
9346         * cli/cli-style.c (class cli_style_option): Update accordingly.
9347         (style_set_list): Move to file scope.
9348         (style_show_list): Likewise.
9349         (set_style): Call help_list.
9350         (show_style): Call cmd_show_list.
9351         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9352         Update to use the new macro.
9353
9354 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9355
9356         * ada-lang.c (_initialize_ada_language): Expand the help text
9357         for the "catch exception" command.
9358
9359 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9360
9361         * symtab.c (matching_obj_sections): Initialize obj,
9362         declare it closer to its usage.
9363
9364 2019-01-10  Tom Tromey  <tom@tromey.com>
9365
9366         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9367         (basic_inf_threads_range): Remove.
9368         (inf_threads_range, inf_non_exited_threads_range)
9369         (safe_inf_threads_range): Use next_adapter.
9370
9371 2019-01-10  Keith Seitz  <keiths@redhat.com>
9372
9373         PR gdb/23712
9374         PR symtab/23010
9375         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9376         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9377
9378 2019-01-10  Keith Seitz  <keiths@redhat.com>
9379
9380         PR gdb/23712
9381         PR symtab/23010
9382         * dictionary.c (pending_to_vector): Remove.
9383         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9384         Remove _1 suffix, replacing functions of the same name.  Update
9385         all callers.
9386         (dict_create_hashed, dict_create_hashed_expandable)
9387         (dict_create_linear, dict_create_linear_expandable, dict_free)
9388         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9389         Make functions static.
9390
9391 2019-01-10  Keith Seitz  <keiths@redhat.com>
9392
9393         PR gdb/23712
9394         PR symtab/23010
9395         * dictionary.h (struct dictionary): Replace declaration with
9396         multidictionary.
9397         (dict_create_hashed, dict_create_hashed_expandable)
9398         (dict_create_linear, dict_create_linear_expandable)
9399         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9400         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9401         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9402         taking multidictionary argument.
9403         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9404         * block.h (struct block) <dict>: Change to multidictionary
9405         and rename `multidict'.
9406         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9407         symmisc.c: Update all dictionary references to multidictionary.
9408
9409 2019-01-10  Keith Seitz  <keiths@redhat.com>
9410
9411         PR gdb/23712
9412         PR symtab/23010
9413         * dictionary.c: Include unordered_map.
9414         (pending_to_vector): New function.
9415         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9416         Rewrite the non-"_1" functions to take vector instead
9417         of linked list.
9418         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9419         "new" _1 versions of the same name.
9420         (multidictionary): Define.
9421         (std::hash<enum language): New definition.
9422         (collate_pending_symbols_by_language, mdict_create_hashed)
9423         (mdict_create_hashed_expandable, mdict_create_linear)
9424         (mdict_create_linear_expandable, mdict_free)
9425         (find_language_dictionary, create_new_language_dictionary)
9426         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9427         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9428         (mdict_size, mdict_empty): New functions.
9429         * dictionary.h (mdict_iterator): Define.
9430
9431 2019-01-10  Pedro Alves  <palves@redhat.com>
9432
9433         * breakpoint.c (read_uploaded_action)
9434         (create_tracepoint_from_upload): Adjust to use
9435         gdb::unique_xmalloc_ptr.
9436         * ctf.c (ctf_write_uploaded_tp):
9437         (SET_ARRAY_FIELD): Use emplace_back.
9438         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9439         * tracefile-tfile.c (tfile_write_uploaded_tp):
9440         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9441         gdb::unique_xmalloc_ptr.
9442         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9443         at_string, cond_string, cmd_strings>: Replace char pointers
9444         with gdb::unique_xmalloc_ptr.
9445
9446 2019-01-10  Pedro Alves  <palves@redhat.com>
9447
9448         * solib-target.c (library_list_start_library): Don't xstrdup name.
9449
9450 2019-01-10  Pedro Alves  <palves@redhat.com>
9451
9452         * mdebugread.c (parse_partial_symbols): Use
9453         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9454
9455 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9456
9457         * linux-fork.c (scoped_switch_fork_info)
9458         <~scoped_switch_fork_info>: Fix incorrect variable name.
9459
9460 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9461
9462         * linux-fork.c (scoped_switch_fork_info)
9463         <scoped_switch_fork_info>: Make explicit.
9464         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9465
9466 2019-01-10  Tom Tromey  <tom@tromey.com>
9467
9468         * objfiles.h (objfile::reset_psymtabs): Update.
9469         * objfiles.c (objfile::objfile): Update.
9470         * psymtab.h (psymtab_storage::obstack): Update.
9471         (psymtab_storage::m_obstack): Use gdb::optional.
9472         (class psymtab_storage): Update comment.  Remove objfile
9473         parameter.
9474         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9475
9476 2019-01-10  Tom Tromey  <tom@tromey.com>
9477
9478         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9479         <free_psymtabs>: Now private.
9480         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9481         (allocate_psymtab): Use new method.
9482
9483 2019-01-10  Tom Tromey  <tom@tromey.com>
9484
9485         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9486         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9487         * mdebugread.c (parse_partial_symbols): Use
9488         allocate_dependencies.
9489         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9490         allocate_dependencies.
9491         (process_psymtab_comp_unit_reader)
9492         (build_type_psymtab_dependencies): Likewise.
9493         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9494
9495 2019-01-10  Tom Tromey  <tom@tromey.com>
9496
9497         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9498         PSYMBOL_SET_LANGUAGE.
9499         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9500
9501 2019-01-10  Tom Tromey  <tom@tromey.com>
9502
9503         * psymtab.h (psymtab_storage::obstack): New method.
9504         <m_obstack>: Rename from obstack; now private.
9505         * psymtab.c (psymtab_storage): Update.
9506         * dwarf2read.c (create_addrmap_from_index)
9507         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9508         Update.
9509
9510 2019-01-10  Tom Tromey  <tom@tromey.com>
9511
9512         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9513         * objfiles.h (objfile::reset_psymtabs): New method.
9514
9515 2019-01-10  Tom Tromey  <tom@tromey.com>
9516
9517         * symmisc.c (print_symbol_bcache_statistics): Update.
9518         (print_objfile_statistics): Update.
9519         * symfile.c (reread_symbols): Update.
9520         * psymtab.h (class psymtab_storage): New.
9521         * psymtab.c (psymtab_storage): New constructor.
9522         (~psymtab_storage): New destructor.
9523         (require_partial_symbols): Update.
9524         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9525         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9526         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9527         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9528         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9529         (start_psymtab_common, end_psymtab_common)
9530         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9531         (allocate_psymtab): Update.
9532         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9533         Update.
9534         (dump_psymtab_addrmap, maintenance_print_psymbols)
9535         (maintenance_check_psymtabs): Update.
9536         (class objfile_psymtabs): Move to objfiles.h.
9537         * psympriv.h (discard_psymtab): Now inline.
9538         (psymtab_discarder::psymtab_discarder): Update.
9539         (psymtab_discarder::~psymtab_discarder): Update.
9540         (ALL_OBJFILE_PSYMTABS): Rewrite.
9541         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9542         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9543         Remove fields.
9544         <partial_symtabs>: New field.
9545         (class objfile_psymtabs): Move from psymtab.h.  Update.
9546         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9547         psymbol_cache.
9548         (objfile::~objfile): Don't destroy psymbol_cache.
9549         * mdebugread.c (parse_partial_symbols): Update.
9550         * dwarf2read.c (create_addrmap_from_index)
9551         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9552         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9553         (add_partial_subprogram, dwarf2_ranges_read): Update.
9554         * dwarf-index-write.c (write_address_map)
9555         (write_one_signatured_type, recursively_write_psymbols)
9556         (class debug_names, class debug_names, write_psymtabs_to_index):
9557         Update.
9558
9559 2019-01-10  Tom Tromey  <tom@tromey.com>
9560
9561         * symtab.h (SYMBOL_SET_NAMES): Update.
9562         (symbol_set_names): Update.
9563         (MSYMBOL_SET_NAMES): Update.
9564         * symtab.c (symbol_set_names): Change argument to be an
9565         objfile_per_bfd_storage.
9566         * psymtab.c (add_psymbol_to_bcache): Update.
9567         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9568
9569 2019-01-10  Tom Tromey  <tom@tromey.com>
9570
9571         * symtab.c (create_demangled_names_hash): Change argument to be an
9572         objfile_per_bfd_storage.
9573         (symbol_set_names): Update.
9574
9575 2019-01-10  Tom Tromey  <tom@tromey.com>
9576
9577         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9578         init_psymbol_list.
9579         * psymtab.c (init_psymbol_list): Do nothing if already called.
9580         * psympriv.h (init_psymbol_list): Add comment.
9581         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9582         init_psymbol_list.
9583         * dbxread.c (dbx_symfile_read): Unconditionally call
9584         init_psymbol_list.
9585
9586 2019-01-10  Tom Tromey  <tom@tromey.com>
9587
9588         * xcoffread.c (scan_xcoff_symtab): Update.
9589         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9590         "where".
9591         * mdebugread.c (parse_partial_symbols)
9592         (handle_psymbol_enumerators): Update.
9593         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9594         * dbxread.c (read_dbx_symtab): Update.
9595         * psympriv.h (psymbol_placement): New enum.
9596         (add_psymbol_to_list): Update.
9597
9598 2019-01-10  Tom Tromey  <tom@tromey.com>
9599
9600         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9601         static_psymbols parameters.
9602         (scan_xcoff_symtab): Update.
9603         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9604         static_psymbols parameters.
9605         * psympriv.h (start_psymtab_common): Update.
9606         * mdebugread.c (parse_partial_symbols): Update.
9607         * dwarf2read.c (create_partial_symtab): Update.
9608         * dbxread.c (read_dbx_symtab): Update.
9609         (start_psymtab): Remove global_psymbols and static_psymbols
9610         parameters.
9611
9612 2019-01-10  Tom Tromey  <tom@tromey.com>
9613
9614         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9615         * psymtab.c (allocate_psymtab): Add comment.
9616         * psympriv.h (allocate_psymtab): Add comment.
9617         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9618         initializations.
9619         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9620
9621 2019-01-10  Tom Tromey  <tom@tromey.com>
9622
9623         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9624         Don't declare.
9625         * mipsread.c: Include mdebugread.h.
9626         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9627         Declare.
9628         * elfread.c: Include mdebugread.h.
9629
9630 2019-01-09  Tom Tromey  <tom@tromey.com>
9631
9632         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9633         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9634         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9635         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9636         (psym_lookup_symbol, psym_find_last_source_symtab)
9637         (psym_forget_cached_source_info, psym_print_stats)
9638         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9639         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9640         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9641         (psym_find_compunit_symtab_by_address)
9642         (maintenance_print_psymbols, maintenance_info_psymtabs)
9643         (maintenance_check_psymtabs): Use ranged for.
9644         * psymtab.h (class objfile_psymtabs): New.
9645         (require_partial_symbols): Return objfile_psymtabs.
9646         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9647
9648 2019-01-09  Tom Tromey  <tom@tromey.com>
9649
9650         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9651         (find_pc_mapped_section, list_overlays_command)
9652         (map_overlay_command, unmap_overlay_command)
9653         (simple_overlay_update): Use all_objfiles.
9654         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9655         * printcmd.c (info_symbol_command): Use all_objfiles.
9656         * objfiles.h (ALL_OBJSECTIONS): Remove.
9657         * maint.c (maintenance_translate_address): Use all_objfiles.
9658         * gcore.c (gcore_create_callback): Use all_objfiles.
9659         (objfile_find_memory_regions): Likewise.
9660
9661 2019-01-09  Tom Tromey  <tom@tromey.com>
9662
9663         * symtab.c (find_line_symtab, info_sources_command)
9664         (make_source_files_completion_list): Use objfile_compunits.
9665         * source.c (select_source_symtab): Use objfile_compunits.
9666         * objfiles.h (struct objfile): Update comment.
9667         (ALL_OBJFILES): Remove.
9668         (ALL_FILETABS): Remove.
9669         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9670         objfile_compunits.
9671
9672 2019-01-09  Tom Tromey  <tom@tromey.com>
9673
9674         * symmisc.c (print_objfile_statistics, dump_objfile)
9675         (maintenance_print_symbols): Use compunit_filetabs.
9676         * source.c (forget_cached_source_info_for_objfile): Use
9677         compunit_filetabs.
9678         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9679         (ALL_FILETABS): Use compunit_filetabs.
9680         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9681         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9682
9683 2019-01-09  Tom Tromey  <tom@tromey.com>
9684
9685         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9686         (compunit_filetabs): New.
9687         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9688         compunit_filetabs.
9689         (info_sources_command, make_source_files_completion_list): Remove
9690         declaration.
9691         * symmisc.c (print_objfile_statistics, dump_objfile)
9692         (maintenance_print_symbols): Remove declaration.
9693         (maintenance_info_symtabs): Use compunit_filetabs.
9694         (maintenance_info_line_tables): Likewise.
9695         * source.c (select_source_symtab): Change local variable name.
9696         (forget_cached_source_info_for_objfile): Remove declaration.
9697         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9698         * objfiles.c (objfile_relocate1): Remove declaration.
9699         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9700         declaration.
9701         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9702         * coffread.c (coff_symtab_read): Remove declaration.
9703         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9704         compunit_filetabs.
9705
9706 2019-01-09  Tom Tromey  <tom@tromey.com>
9707
9708         * symtab.c (lookup_objfile_from_block)
9709         (find_pc_sect_compunit_symtab, search_symbols)
9710         (default_collect_symbol_completion_matches_break_on): Use
9711         objfile_compunits.
9712         * objfiles.h (ALL_COMPUNITS): Remove.
9713         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9714         * cp-support.c (add_symbol_overload_list_qualified): Use
9715         objfile_compunits.
9716         * ada-lang.c (ada_collect_symbol_completion_matches)
9717         (ada_add_global_exceptions): Use objfile_compunits.
9718
9719 2019-01-09  Tom Tromey  <tom@tromey.com>
9720
9721         * source.c (select_source_symtab)
9722         (forget_cached_source_info_for_objfile): Remove declaration.
9723         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9724         declaration.
9725         * maint.c (count_symtabs_and_blocks): Remove declaration.
9726         * cp-support.c (add_symbol_overload_list_qualified): Remove
9727         declaration.
9728         * coffread.c (coff_symtab_read): Remove declaration.
9729         * symtab.c (lookup_symbol_in_objfile_symtabs)
9730         (basic_lookup_transparent_type_1): Use objfile_compunits.
9731         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9732         (info_sources_command, search_symbols)
9733         (default_collect_symbol_completion_matches_break_on)
9734         (make_source_files_completion_list): Remove declaration.
9735         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9736         (ada_collect_symbol_completion_matches)
9737         (ada_add_global_exceptions): Remove declaration.
9738         * linespec.c (iterate_over_all_matching_symtabs): Use
9739         objfile_compunits.
9740         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9741         (class objfile_compunits): New.
9742         (ALL_COMPUNITS): Use objfile_compunits.
9743         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9744         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9745         objfile_compunits.
9746         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9747
9748 2019-01-09  Tom Tromey  <tom@tromey.com>
9749
9750         * symtab.c (search_symbols)
9751         (default_collect_symbol_completion_matches_break_on): Use
9752         objfile_msymbols.
9753         * ada-lang.c (ada_lookup_simple_minsym)
9754         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9755         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9756         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9757         objfile_msymbols.
9758         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9759         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9760         * objc-lang.c (find_methods): Use objfile_msymbols.
9761         (info_selectors_command, info_classes_command): Likewise.
9762         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9763         * objfiles.h (class objfile_msymbols): New.
9764         (ALL_OBJFILE_MSYMBOLS): Remove.
9765         (ALL_MSYMBOLS): Remove.
9766
9767 2019-01-09  Tom Tromey  <tom@tromey.com>
9768
9769         * common/next-iterator.h (next_adapter): Add Iterator template
9770         parameter.
9771         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9772         (class all_objfiles_safe): New.
9773         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9774         * objfiles.c (put_objfile_before): Update comment.
9775         (add_separate_debug_objfile): Likewise.
9776         (free_all_objfiles): Use all_objfiles_safe.
9777         (objfile_purge_solibs): Likewise.
9778
9779 2019-01-09  Tom Tromey  <tom@tromey.com>
9780
9781         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9782         (expand_symtab_containing_pc, lookup_static_symbol)
9783         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9784         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9785         all_objfiles.
9786         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9787         * breakpoint.c (create_overlay_event_breakpoint)
9788         (create_longjmp_master_breakpoint)
9789         (create_std_terminate_master_breakpoint)
9790         (create_exception_master_breakpoint): Use all_objfiles.
9791         * linux-thread-db.c (try_thread_db_load_from_pdir)
9792         (has_libpthread): Use all_objfiles.
9793         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9794         * linespec.c (iterate_over_all_matching_symtabs)
9795         (search_minsyms_for_name): Use all_objfiles.
9796         * maint.c (maintenance_info_sections): Use all_objfiles.
9797         * main.c (captured_main_1): Use all_objfiles.
9798         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9799         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9800         * guile/scm-pretty-print.c
9801         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9802         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9803         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9804         (maintenance_print_msymbols): Use all_objfiles.
9805         * source.c (select_source_symtab): Use all_objfiles.
9806         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9807         * symfile.c (remove_symbol_file_command)
9808         (expand_symtabs_matching, map_symbol_filenames): Use
9809         all_objfiles.
9810         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9811         all_objfiles.
9812         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9813         * objc-lang.c (find_methods): Use all_objfiles.
9814         * objfiles.c (have_partial_symbols, have_full_symbols)
9815         (have_minimal_symbols, qsort_cmp)
9816         (default_iterate_over_objfiles_in_search_order): Use
9817         all_objfiles.
9818         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9819         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9820         (maintenance_check_psymtabs): Use all_objfiles.
9821         (ALL_PSYMTABS): Remove.
9822         * compile/compile-object-run.c (do_module_cleanup): Use
9823         all_objfiles.
9824         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9825         * cp-support.c (add_symbol_overload_list_qualified): Use
9826         all_objfiles.
9827         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9828         Use all_objfiles.
9829         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9830         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9831         all_objfiles.
9832         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9833         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9834         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9835         Uses all_objfiles.
9836         * solib.c (solib_read_symbols): Use all_objfiles
9837
9838 2019-01-09  Tom Tromey  <tom@tromey.com>
9839
9840         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9841         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9842         all_objfiles.
9843         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9844         * symmisc.c (print_symbol_bcache_statistics)
9845         (print_objfile_statistics, maintenance_print_objfiles)
9846         (maintenance_info_symtabs, maintenance_check_symtabs)
9847         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9848         all_objfiles.
9849         * source.c (forget_cached_source_info): Use all_objfiles.
9850         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9851         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9852         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9853         * objfiles.c (update_section_map): Use all_objfiles.
9854         (shared_objfile_contains_address_p): Likewise.
9855         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9856         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9857
9858 2019-01-09  Tom Tromey  <tom@tromey.com>
9859
9860         * common/next-iterator.h: New file.
9861         * objfiles.h (class all_objfiles): New.
9862         (struct objfile_iterator): New.
9863
9864 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9865
9866         * NEWS: Move the description of the changed "frame", "select-frame",
9867          and "info frame" commands to the Changed commands section.
9868
9869 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9870
9871         * gdbtypes.c (check_stub_method_group): Remove handling of old
9872         mangling schemes.
9873         * linespec.c (find_methods): Likewise.
9874         * stabsread.c (read_member_functions): Likewise.
9875         * valops.c (search_struct_method): Likewise.
9876         (value_struct_elt_for_reference): Likewise.
9877         * NEWS: Mention this change.
9878
9879 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9880
9881         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9882         print_source_lines.
9883         * source.c (print_source_lines_base): Update line number check.
9884         (print_source_lines): New function.
9885         (source_lines_range::source_lines_range): New function.
9886         * source.h (class source_lines_range): New class.
9887         (print_source_lines): New declaration.
9888
9889 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9890
9891         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9892
9893 2019-01-08  Tom Tromey  <tom@tromey.com>
9894             Simon Marchi  <simon.marchi@ericsson.com>
9895
9896         PR gdb/24060
9897         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9898         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9899         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9900         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9901         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9902         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9903
9904 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9905
9906         * source.c (select_source_symtab): Move header comment to
9907         declaration in source.h.
9908         (forget_cached_source_info_for_objfile): Likewise.
9909         (forget_cached_source_info): Likewise.
9910         (identify_source_line): Likewise.
9911         * source.h (identify_source_line): Move declaration from symtab.h
9912         and add comment from source.c
9913         (print_source_lines): Likewise.
9914         (forget_cached_source_info_for_objfile): Likewise.
9915         (forget_cached_source_info): Likewise.
9916         (select_source_symtab): Likewise.
9917         (enum print_source_lines_flag): Move definition from symtab.h.
9918         * symtab.h (identify_source_line): Move declaration to source.h.
9919         (print_source_lines): Likewise.
9920         (forget_cached_source_info_for_objfile): Likewise.
9921         (forget_cached_source_info): Likewise.
9922         (select_source_symtab): Likewise.
9923         (enum print_source_lines_flag): Move definition to source.h.
9924         * tui/tui-hooks.c: Add 'source.h' include.
9925
9926 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9927
9928         * source.c (print_source_lines_base): Handle requests to print
9929         reverse line number sequences, and guard against empty lines
9930         string.
9931
9932 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9933
9934         * source.c (print_source_lines_base): Fix skip of '\r' if next
9935         character is '\n'.
9936
9937 2019-01-06  Tom Tromey  <tom@tromey.com>
9938
9939         * c-exp.y (struct c_parse_state) <macro_original_text,
9940         expansion_obstack>: New member.
9941         (macro_original_text, expansion_obstack): Remove globals.
9942         (scan_macro_expansion, scanning_macro_expansion)
9943         (finished_macro_expansion): Update.
9944         (scan_macro_cleanup): Remove.
9945         (yylex, c_parse): Update.
9946
9947 2019-01-06  Tom Tromey  <tom@tromey.com>
9948
9949         * c-exp.y (struct c_parse_state) <strings>: New member.
9950         (operator_stoken): Update.
9951
9952 2019-01-06  Tom Tromey  <tom@tromey.com>
9953
9954         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9955         (union type_stack_elt) <typelist_val>: Now a pointer to
9956         std::vector.
9957         (type_stack_cleanup): Don't declare.
9958         (push_typelist): Update.
9959         * parse.c (pop_typelist): Return a std::vector.
9960         (push_typelist): Take a std::vector.
9961         (follow_types): Update.  Do not free args.
9962         (type_stack_cleanup): Remove.
9963         * c-exp.y (struct c_parse_state): New.
9964         (cpstate): New global.
9965         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9966         (nonempty_typelist): Update.
9967         (func_mod): Create a new vector.
9968         (c_parse): Create a c_parse_state.
9969         (check_parameter_typelist): Do not delete params.
9970         (function_method): Update.  Do not delete type_list.
9971
9972 2019-01-06  Tom Tromey  <tom@tromey.com>
9973
9974         PR gdb/28155:
9975         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9976         check_typedef.
9977         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9978         (print_return_value): Likewise.
9979
9980 2019-01-05  Tom Tromey  <tom@tromey.com>
9981
9982         * contrib/cleanup_check.py: Remove.
9983         * contrib/gcc-with-excheck: Remove.
9984         * contrib/exsummary.py: Remove.
9985         * contrib/excheck.py: Remove.
9986
9987 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9988
9989         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9990         NULL. Initialize tpprev to NULL instead of assigning it
9991         to NULL on the next statement.
9992         * windows-nat.c (windows_delete_thread): Remove check for
9993         main_thread_id before printing thread exit notifications.
9994         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9995         Remove thread ID check against main_thread_id.
9996         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9997         windows_delete_thread.
9998         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9999
10000 2019-01-04  Tom Tromey  <tom@tromey.com>
10001
10002         * compile/compile.c (_initialize_compile): Use upper case for
10003         metasyntactic variables.
10004         * symmisc.c (_initialize_symmisc): Use upper case for
10005         metasyntactic variables.
10006         * psymtab.c (_initialize_psymtab): Use upper case for
10007         metasyntactic variables.
10008         * demangle.c (demangle_command): Use upper case for metasyntactic
10009         variables.
10010         (_initialize_demangler): Likewise.
10011         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10012         variables.
10013
10014 2019-01-03  Tom Tromey  <tom@tromey.com>
10015
10016         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10017
10018 2019-01-03  Tom Tromey  <tom@tromey.com>
10019
10020         * python/py-symtab.c (salpy_str): Update.
10021         (struct salpy_sal_object) <symtab>: Now a PyObject.
10022         (salpy_dealloc): Update.
10023         (del_objfile_sal): Use gdbpy_ref.
10024
10025 2019-01-03  Tom Tromey  <tom@tromey.com>
10026
10027         * python/py-type.c (convert_field): Use new_reference.  Return
10028         gdbpy_ref.
10029         (make_fielditem): Return gdbpy_ref.
10030         (typy_fields): Update.
10031         (typy_getitem): Update.
10032         (field_name): Return gdbpy_ref.  Use new_reference.
10033         (typy_iterator_iternext): Update.
10034
10035 2019-01-03  Tom Tromey  <tom@tromey.com>
10036
10037         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10038
10039 2019-01-03  Tom Tromey  <tom@tromey.com>
10040
10041         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10042         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10043         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10044         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10045         (pspy_set_type_printers): Likewise.
10046         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10047         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10048         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10049         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10050         (objfpy_set_type_printers): Likewise.
10051
10052 2019-01-03  Tom Tromey  <tom@tromey.com>
10053
10054         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10055         (gdbpy_print_stack): Use gdbpy_err_fetch.
10056         * python/python-internal.h (class gdbpy_err_fetch): New class.
10057         (class gdbpy_enter) <m_error_type, m_error_value,
10058         m_error_traceback>: Remove.
10059         <m_error>: New member.
10060         (gdbpy_exception_to_string): Don't declare.
10061         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10062         * python/py-value.c (convert_value_from_python): Use
10063         gdbpy_err_fetch.
10064         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10065         gdbpy_exception_to_string.
10066         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10067         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10068         gdbpy_err_fetch.
10069
10070 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10071
10072         * linux-nat.c (delete_lwp_cleanup): Delete.
10073         (struct lwp_deleter): New struct.
10074         (lwp_info_up): New typedef.
10075         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10076         lwp_info_up.
10077
10078 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10079
10080         * linux-fork.c (class scoped_switch_fork_info): New class.
10081         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10082
10083 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10084
10085         * valops.c (find_overload_match): Remove use of null_cleanup, and
10086         calls to do_cleanups.
10087
10088 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10089
10090         * compile/compile-cplus-types.c
10091         (compile_cplus_instance::decl_name): Handle changes to
10092         cp_func_name.
10093         * cp-support.c (cp_func_name): Update header comment, update
10094         return type.
10095         * cp-support.h (cp_func_name): Update return type in declaration.
10096         * valops.c (find_overload_match): Move temp_func local to top
10097         level of function and change its type.  Use temp_func to hold and
10098         delete temporary string obtained from cp_func_name.
10099
10100 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10101
10102         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10103         gdb::char_vector, remove cleanup, and update uses of `msg`.
10104
10105 2019-01-03  Jim Wilson  <jimw@sifive.com>
10106
10107         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10108
10109 2019-01-02  Tom Tromey  <tom@tromey.com>
10110
10111         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10112         (tdesc_parse_xml): Remove cleanups.
10113         * target-descriptions.h (make_cleanup_free_target_description):
10114         Don't declare.
10115         (target_desc_deleter): New struct.
10116         (target_desc_up): New typedef.
10117         * target-descriptions.c (target_desc_deleter::operator()): Rename
10118         from free_target_description.
10119         (make_cleanup_free_target_description): Remove.
10120
10121 2019-01-02  Tom Tromey  <tom@tromey.com>
10122
10123         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10124         constructor, destructor.
10125         (linespec_parser): Remove typedef.
10126         (~linespec_parser): Rename from linespec_parser_delete.
10127         (linespec_lex_to_end, linespec_complete_label)
10128         (linespec_complete): Update.
10129         (decode_line_full): Remove cleanups.
10130         (decode_line_1): Update.
10131
10132 2019-01-02  Tom Tromey  <tom@tromey.com>
10133
10134         * python/python-internal.h (inferior_to_inferior_object): Change
10135         return type.
10136         * python/py-exitedevent.c (create_exited_event_object): Update.
10137         * python/py-inferior.c (inferior_to_inferior_object): Return
10138         gdbpy_ref.
10139         (python_new_inferior, python_inferior_deleted)
10140         (thread_to_thread_object, delete_thread_object)
10141         (build_inferior_list, gdbpy_selected_inferior): Update.
10142         * python/py-infthread.c (create_thread_object): Update.  Also fail
10143         if inferior_to_inferior_object fails.
10144
10145 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10146
10147         * inferior.h (class inferior) <displaced_step_state>: New field.
10148         * infrun.h (struct displaced_step_state): Move here from
10149         infrun.c.  Initialize fields, add constructor.
10150         <inf>: Remove field.
10151         <reset>: New method.
10152         * infrun.c (struct displaced_step_inferior_state): Move to
10153         infrun.h.
10154         (displaced_step_inferior_states): Remove.
10155         (get_displaced_stepping_state): Adust.
10156         (displaced_step_in_progress_any_inferior): Adjust.
10157         (displaced_step_in_progress_thread): Adjust.
10158         (displaced_step_in_progress): Adjust.
10159         (add_displaced_stepping_state): Remove.
10160         (get_displaced_step_closure_by_addr): Adjust.
10161         (remove_displaced_stepping_state): Remove.
10162         (infrun_inferior_exit): Call displaced_step_state.reset.
10163         (use_displaced_stepping): Don't check for NULL.
10164         (displaced_step_prepare_throw): Call
10165         get_displaced_stepping_state.
10166         (displaced_step_fixup): Don't check for NULL.
10167         (prepare_for_detach): Don't check for NULL.
10168
10169 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10170
10171         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10172          in case of call that did not complete.
10173
10174 2019-01-02  Andrey Utkin  <autkin@undo.io>
10175
10176         * symfile.c (find_separate_debug_file): Fix search of debug files for
10177         remote debuggee.
10178
10179 2019-01-02  Tom Tromey  <tom@tromey.com>
10180
10181         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10182         indentation.
10183         * python/py-frame.c (frapy_older): Remove cast.
10184         (frapy_newer): Likewise.
10185         * python/py-breakpoint.c (local_setattro): Remove cast.
10186         * python/py-arch.c (archpy_name): Remove local variable.
10187         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10188
10189 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10190
10191         * unittests/basic_string_view/element_access/char/empty.cc:
10192         Fix year range in copyright header.
10193
10194 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10195
10196         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10197         Delete.
10198         <operator==>: Update with for removed field.
10199         <hash>: Likewise.
10200         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10201         <isa_features>: ...this.
10202         <abi_features>: New field.
10203         (riscv_isa_flen): Update comment.
10204         (riscv_abi_xlen): New declaration.
10205         (riscv_abi_flen): New declaration.
10206         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10207         isa_features.
10208         (riscv_abi_xlen): New function.
10209         (riscv_isa_flen): Update to get answer from isa_features.
10210         (riscv_abi_flen): New function.
10211         (riscv_has_fp_abi): Update to get answer from abi_features.
10212         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10213         xlen and flen.
10214         (riscv_call_info) <xlen, flen>: Update comment.
10215         (riscv_call_arg_struct): Remove invalid assertions
10216         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10217         is removed.
10218         (riscv_gdbarch_init): Gather isa features and abi features
10219         separately, ensure both match on the gdbarch when reusing an old
10220         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10221         a target with 64-bit float hardware.
10222
10223 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10224
10225         * source.c (search_command_helper): Stop reverse search
10226         when line 1 has been searched.
10227
10228 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10229
10230         * record-full.c (record_full_base_target::close): Rewrite
10231         record_full_core_buf_list free logic.
10232
10233 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10234
10235         * break-catch-syscall.c (print_one_catch_syscall): xfree
10236         the last text.
10237
10238 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10239
10240         * top.c (print_gdb_version): Update Copyright year in version
10241         message.
10242
10243 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10244
10245         Update copyright year range in all GDB files.
10246
10247 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10248
10249         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10250
10251 For older changes see ChangeLog-2018.
10252 \f
10253 Local Variables:
10254 mode: change-log
10255 left-margin: 8
10256 fill-column: 74
10257 version-control: never
10258 coding: utf-8
10259 End:
10260