gdb/ChangeLog

   1 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * NEWS: Combine separate "New targets" sections for 8.3.
   4
   5 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
   6
   7         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
   8         (ppcfbsd_init_abi): Install gdbarch
   9         "fetch_tls_load_module_address" and "get_thread_local_address"
  10         methods.
  11
  12 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  13
  14         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
  15         (riscv_fbsd_init_abi): Install gdbarch
  16         "fetch_tls_load_module_address" and "get_thread_local_address"
  17         methods.
  18
  19 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  20
  21         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
  22         (i386fbsd_init_abi): Install gdbarch
  23         "fetch_tls_load_module_address" and "get_thread_local_address"
  24         methods.
  25
  26 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  27
  28         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
  29         (amd64fbsd_init_abi): Install gdbarch
  30         "fetch_tls_load_module_address" and "get_thread_local_address"
  31         methods.
  32
  33 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  34
  35         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
  36         (struct fbsd_pspace_data): New type.
  37         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
  38         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
  39         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
  40         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
  41         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
  42
  43 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  44
  45         * gdbtypes.c (lookup_struct_elt): New function.
  46         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
  47         * gdbtypes.h (struct struct_elt): New type.
  48         (lookup_struct_elt): New prototype.
  49
  50 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  51
  52         * gdbtypes.c (lookup_struct_elt_type): Update comment and
  53         remove disabled code block.
  54
  55 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  56
  57         * gdbarch.sh (get_thread_local_address): New method.
  58         * gdbarch.h, gdbarch.c: Regenerate.
  59         * target.c (target_translate_tls_address): Use
  60         gdbarch_get_thread_local_address if present instead of
  61         target::get_thread_local_address.
  62
  63 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  64
  65         * target.h (target::get_thread_local_address): Update comment.
  66
  67 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  68
  69         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
  70         objfile->separate_debug_objfile_backlink if not NULL.
  71
  72 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  73
  74         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
  75         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
  76         (amd64bsd_store_inferior_registers): Likewise.
  77         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  78         Enable segment base registers.
  79         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
  80         PT_GETFSBASE and PT_GETGSBASE.
  81         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
  82         PT_SETGSBASE.
  83         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
  84         segment base registers.
  85         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  86
  87 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  88
  89         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  90         Update calls to i386_target_description to add 'segments'
  91         parameter.
  92         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
  93         add segment base registers.
  94         * arch/i386.c (i386_create_target_description): Add 'segments'
  95         parameter to enable segment base registers.
  96         * arch/i386.h (i386_create_target_description): Likewise.
  97         * features/i386/32bit-segments.xml: New file.
  98         * features/i386/32bit-segments.c: Generate.
  99         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 100         call to i386_target_description to add 'segments' parameter.
 101         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 102         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 103         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 104         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 105         if feature is present.
 106         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 107         Add 'segments' parameter to call to i386_target_description.
 108         (i386_target_description): Add 'segments' parameter to enable
 109         segment base registers.
 110         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 111         to call to i386_target_description.
 112         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 113         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 114         Define I386_NUM_REGS.
 115         (i386_target_description): Add 'segments' parameter to enable
 116         segment base registers.
 117
 118 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 119
 120         PR/24325
 121         * source-cache.c: #undef open and close, to avoid unresolved
 122         externals during linking.
 123
 124 2019-03-12  Tom Tromey  <tromey@adacore.com>
 125
 126         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 127         const.  Add initializers.
 128         (_initialize_remote): Don't initialize ptid globals.
 129
 130 2019-03-12  Pedro Alves  <palves@redhat.com>
 131
 132         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 133
 134 2019-03-12  Pedro Alves  <palves@redhat.com>
 135
 136         * cp-name-parser.y (main): Remove unused 'len' variable.
 137
 138 2019-03-12  Tom Tromey  <tromey@adacore.com>
 139
 140         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 141         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 142
 143 2019-03-12  Tom Tromey  <tromey@adacore.com>
 144
 145         * linux-nat.c (iterate_over_lwps): Update.
 146         (stop_callback): Remove parameter.
 147         (stop_wait_callback, detach_callback, resume_set_callback)
 148         (select_singlestep_lwp_callback, set_ignore_sigint)
 149         (status_callback, resumed_callback, resume_clear_callback)
 150         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 151         data parameter.
 152         (linux_nat_target::detach, linux_nat_target::resume)
 153         (linux_stop_and_wait_all_lwps, select_event_lwp)
 154         (linux_nat_filter_event, linux_nat_wait_1)
 155         (linux_nat_target::kill, linux_nat_target::stop)
 156         (linux_nat_target::stop): Update.
 157         (linux_nat_resume_callback): Change type.
 158         (resume_stopped_resumed_lwps, count_events_callback)
 159         (select_event_lwp_callback): Likewise.
 160         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 161         * arm-linux-nat.c (struct update_registers_data): Remove.
 162         (update_registers_callback): Change type.
 163         (arm_linux_insert_hw_breakpoint1): Update.
 164         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 165         parameter.
 166         (x86_linux_dr_set_addr): Update.
 167         (x86_linux_dr_set_control): Update.
 168         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 169         (iterate_over_lwps): Use gdb::function_view.
 170         * nat/aarch64-linux-hw-point.c (struct
 171         aarch64_dr_update_callback_param): Remove.
 172         (debug_reg_change_callback): Change type.
 173         (aarch64_notify_debug_reg_change): Update.
 174         * s390-linux-nat.c (s390_refresh_per_info): Update.
 175
 176 2019-03-11  Tom Tromey  <tromey@adacore.com>
 177
 178         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 179         redundant assignment to "this_cu".
 180
 181 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 182
 183         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 184
 185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 186
 187         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 188         from...
 189         (rank_one_type): ... this.
 190
 191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 192
 193         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 194         from...
 195         (rank_one_type): ... this.
 196
 197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 198
 199         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 200         from...
 201         (rank_one_type): ... this.
 202
 203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 204
 205         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 206         from...
 207         (rank_one_type): ... this.
 208
 209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 210
 211         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 212         from...
 213         (rank_one_type): ... this.
 214
 215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 216
 217         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 218         from...
 219         (rank_one_type): ... this.
 220
 221 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 222
 223         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 224         from...
 225         (rank_one_type): ... this.
 226
 227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 228
 229         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 230         from...
 231         (rank_one_type): ... this.
 232
 233 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 234
 235         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 236         from...
 237         (rank_one_type): ... this.
 238
 239 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 240
 241         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 242         from...
 243         (rank_one_type): ... this.
 244
 245 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 246
 247         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 248         from...
 249         (rank_one_type): ... this.
 250
 251 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 252
 253         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 254         from...
 255         (rank_one_type): ... this.
 256
 257 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 258
 259         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 260         inferior-events' shows the example events.
 261
 262 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 263
 264         Support styling on native MS-Windows console
 265
 266         PR/24315
 267         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 268         on MS-Windows if $TERM is not defined.
 269
 270         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 271
 272         * posix-hdep.c (gdb_console_fputs):
 273         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 274         functions.
 275         * ui-file.h (gdb_console_fputs): Add prototype.
 276
 277         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 278         back to fputs only if the former returns zero.
 279
 280 2019-03-07  Tom Tromey  <tom@tromey.com>
 281
 282         * symmisc.c (print_symbol_bcache_statistics): Update.
 283         (print_objfile_statistics): Update.
 284         * symfile.c (allocate_symtab): Update.
 285         * stabsread.c: Don't include bcache.h.
 286         * psymtab.h (struct psymbol_bcache): Don't declare.
 287         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 288         (psymbol_bcache_init, psymbol_bcache_free)
 289         (psymbol_bcache_get_bcache): Don't declare.
 290         * psymtab.c (struct psymbol_bcache): Remove.
 291         (psymtab_storage::psymtab_storage): Update.
 292         (psymtab_storage::~psymtab_storage): Update.
 293         (psymbol_bcache_init, psymbol_bcache_free)
 294         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 295         (add_psymbol_to_bcache): Update.
 296         (allocate_psymtab): Update.
 297         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 298         macro_cache>: No longer pointers.
 299         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 300         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 301         * macrotab.c (macro_bcache): Update.
 302         * macroexp.c: Don't include bcache.h.
 303         * gdbtypes.c (check_types_worklist): Update.
 304         (types_deeply_equal): Remove TRY/CATCH.  Update.
 305         * elfread.c (elf_symtab_read): Update.
 306         * dwarf2read.c: Don't include bcache.h.
 307         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 308         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 309         (print_bcache_statistics, bcache_memory_used): Don't declare.
 310         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 311         methods.  Rename all data members.
 312         * bcache.c (struct bcache): Move to bcache.h.
 313         (bcache::expand_hash_table): Rename from expand_hash_table.
 314         (bcache): Remove.
 315         (bcache::insert): Rename from bcache_full.
 316         (bcache::compare): Rename from bcache_compare.
 317         (bcache_xmalloc): Remove.
 318         (bcache::~bcache): Rename from bcache_xfree.
 319         (bcache::print_statistics): Rename from print_bcache_statistics.
 320         (bcache::memory_used): Rename from bcache_memory_used.
 321
 322 2019-03-07  Pedro Alves  <palves@redhat.com>
 323
 324         * infrun.c (normal_stop): Also check for
 325         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 326
 327 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 328
 329         * f-lang.c (value_from_host_double): Moved to...
 330         * value.c (value_from_host_double): ...here.
 331         * value.h (value_from_host_double): Declare.
 332         * guile/scm-math.c (vlscm_convert_typed_number): Use
 333         value_from_host_double.
 334         (vlscm_convert_number): Likewise.
 335         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 336         * python/py-value.c (convert_value_from_python): Likewise.
 337
 338 2019-03-06  Tom Tromey  <tom@tromey.com>
 339
 340         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 341
 342 2019-03-06  Tom Tromey  <tom@tromey.com>
 343
 344         * utils.h (free_current_contents): Don't declare.
 345         * utils.c (free_current_contents): Remove.
 346
 347 2019-03-06  Tom Tromey  <tom@tromey.com>
 348
 349         * top.c (quit_force): Update.
 350         * main.c (captured_command_loop): Update.
 351         * common/new-op.c (operator new): Update.
 352         * common/common-exceptions.c (struct catcher)
 353         <save_cleanup_chain>: Remove member.
 354         (exceptions_state_mc_init): Update.
 355         (exception_try_scope_entry): Return nullptr.
 356         (exception_try_scope_exit, exception_rethrow)
 357         (throw_exception_sjlj, throw_exception_cxx): Update.
 358         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 359         (all_cleanups, do_cleanups, discard_cleanups)
 360         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 361         (restore_cleanups, restore_final_cleanups): Don't declare.
 362         (do_final_cleanups): Remove parameter.
 363         * common/cleanups.c (cleanup_chain, make_cleanup)
 364         (make_cleanup_dtor, all_cleanups, do_cleanups)
 365         (discard_my_cleanups, discard_cleanups)
 366         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 367         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 368         (null_cleanup): Remove.
 369         (do_final_cleanups): Remove parameter.
 370
 371 2019-03-06  Tom Tromey  <tom@tromey.com>
 372
 373         * remote.c (remote_target::remote_parse_stop_reply): Use
 374         unique_xmalloc_ptr.
 375
 376 2019-03-06  Tom Tromey  <tom@tromey.com>
 377
 378         * stabsread.c (struct stabs_field_info): Rename from field_info.
 379         <list, fnlist>: Add initializers.
 380         <obstack>: New member.
 381         (read_member_functions, read_struct_fields, read_baseclasses):
 382         Allocate on obstack.  Don't use cleanups.
 383         (read_one_struct_field, read_member_functions, read_struct_fields)
 384         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 385         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 386         (read_struct_type): Update.
 387
 388 2019-03-06  Tom Tromey  <tom@tromey.com>
 389
 390         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 391         * common/filestuff.h (make_cleanup_close): Don't declare.
 392         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 393         Remove.
 394
 395 2019-03-06  Tom Tromey  <tom@tromey.com>
 396
 397         * solib-aix.c: Use make_scope_exit.
 398
 399 2019-03-06  Tom Tromey  <tom@tromey.com>
 400
 401         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 402         Use make_scope_exit.
 403
 404 2019-03-06  Tom Tromey  <tom@tromey.com>
 405
 406         * solib-svr4.c (disable_probes_interface): Remove parameter.
 407         (svr4_handle_solib_event): Use make_scope_exit.
 408
 409 2019-03-06  Tom Tromey  <tom@tromey.com>
 410
 411         * remote.c (struct stop_reply_deleter): Remove.
 412         (stop_reply_up): Update.
 413         (struct stop_reply): Derive from notif_event.  Don't typedef.
 414         <regcache>: Now a std::vector.
 415         (stop_reply_xfree): Remove.
 416         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 417         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 418         (remote_target::discard_pending_stop_replies): Use delete.
 419         (remote_target::remote_parse_stop_reply): Update.
 420         (remote_target::process_stop_reply): Update.
 421         * remote-notif.h (struct notif_event): Add virtual destructor.
 422         Remove "dtr" member.
 423         (struct notif_client) <alloc_event>: Return a unique_ptr.
 424         (notif_event_xfree): Don't declare.
 425         (notif_event_up): New typedef.
 426         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 427         (notif_event_xfree, do_notif_event_xfree): Remove.
 428         (remote_notif_state_xfree): Update.
 429
 430 2019-03-06  Tom Tromey  <tom@tromey.com>
 431
 432         * infrun.c (displaced_step_clear_cleanup): Now a
 433         forward_scope_exit type.
 434         (displaced_step_prepare_throw): Update.
 435         (displaced_step_fixup): Update.
 436
 437 2019-03-06  Tom Tromey  <tom@tromey.com>
 438
 439         * inferior.h (class inferior): Update comment.
 440         * gdbthread.h (class thread_info): Update comment.
 441
 442 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 443             Tom Tromey  <tom@tromey.com>
 444
 445         * stabsread.h (struct stab_section_list): Remove.
 446         (coffstab_build_psymtabs): Update.
 447         * dbxread.c (symbuf_sections): Now a std::vector.
 448         (sect_idx): New global.
 449         (fill_symbuf): Update.
 450         (coffstab_build_psymtabs): Change type of stabsects parameter.
 451         Update.
 452         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 453         std::vector.
 454         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 455         (coff_locate_sections): Update.
 456         (coff_symfile_read): Remove cleanups.  Update.
 457         (init_stringtab): Add storage parameter.
 458         (free_stringtab, free_stringtab_cleanup): Remove.
 459         (init_lineno): Add storage parameter.
 460         (free_linetab, free_linetab_cleanup): Remove.
 461
 462 2019-03-06  Pedro Alves  <palves@redhat.com>
 463
 464         * linux-fork.c (fork_info::clobber_regs): Delete.
 465         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 466         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 467         comment.  Adjust.
 468         (scoped_switch_fork_info::scoped_switch_fork_info)
 469         (checkpoint_command, linux_fork_context): Adjust
 470         fork_save_infrun_state calls.
 471
 472 2019-03-06  Pedro Alves  <palves@redhat.com>
 473
 474         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 475         (inf_has_multiple_threads): Return 'bool' and rewrite using
 476         inferior_info::threads().
 477
 478 2019-03-06  Pedro Alves  <palves@redhat.com>
 479
 480         * linux-fork.c: Include <list>.
 481         (fork_list): Now a std::list instance.
 482         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 483         (forks_exist_p, find_last_fork): Adjust.
 484         (new_fork): Delete.
 485         (one_fork_p): New.
 486         (add_fork): Adjust.
 487         (free_fork): Delete, folded into fork_info::~fork_info().
 488         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 489         Adjust.
 490         (init_fork_list): Delete.
 491         (linux_fork_killall, linux_fork_mourn_inferior)
 492         (linux_fork_detach, info_checkpoints_command): Adjust.
 493         (_initialize_linux_fork): No longer call init_fork_list.
 494
 495 2019-03-06  Pedro Alves  <palves@redhat.com>
 496
 497         * linux-fork.c (new_fork): New, split out of ...
 498         (add_fork): ... this.  Return void.  Move "first fork" special
 499         case from here, to ...
 500         (checkpoint_command): ... here.
 501         * linux-linux.h (add_fork): Return void.
 502
 503 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 506
 507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 508             Chris January  <chris.january@arm.com>
 509             David Lecomber  <david.lecomber@arm.com>
 510
 511         * f-exp.y: New token, UNOP_INTRINSIC.
 512         (exp): New pattern using UNOP_INTRINSIC token.
 513         (f77_keywords): Add 'abs' keyword.
 514         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 515         (value_from_host_double): New function.
 516         (evaluate_subexp_f): Support UNOP_ABS.
 517
 518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 519
 520         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 521         types.
 522
 523 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 524
 525         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 526         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 527         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 528
 529 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 532
 533 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 534             Chris January  <chris.january@arm.com>
 535
 536         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 537         * f-exp.y: Define 'KIND' token.
 538         (exp): New pattern for KIND expressions.
 539         (ptype): Handle types with a kind extension.
 540         (direct_abs_decl): Extend to spot kind extensions.
 541         (f77_keywords): Add 'kind' to the list.
 542         (push_kind_type): New function.
 543         (convert_to_kind_type): New function.
 544         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 545         * parse.c (operator_length_standard): Likewise.
 546         * parser-defs.h (enum type_pieces): Add tp_kind.
 547         * std-operator.def: Add UNOP_KIND.
 548
 549 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 550
 551         * f-exp.y (f_parse): Set yydebug.
 552
 553 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 554
 555         * f-lang.c (evaluate_subexp_f): New function.
 556         (exp_descriptor_f): New global.
 557         (f_language_defn): Use exp_descriptor_f instead of
 558         exp_descriptor_standard.
 559
 560 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * f-exp.y (struct token): Add comments.
 563         (dot_ops): Remove uppercase versions and the end marker.
 564         (f77_keywords): Likewise.
 565         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 566         entries in the dot_ops array are case insensitive, and use
 567         strncasecmp to compare strings.  Also some whitespace cleanup in
 568         this area.  Similar for the f77_keywords array, except entries in
 569         this list might be case sensitive.
 570
 571 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 572
 573         * f-exp.y (struct f77_boolean_val): Add comments.
 574         (boolean_values): Remove uppercase versions, and end marker.
 575         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 576         and use strncasecmp to achieve case insensitivity.  Additionally,
 577         perform whitespace cleanup around this code.
 578
 579 2019-03-06  Tom Tromey  <tromey@adacore.com>
 580
 581         * remote-sim.c (gdbsim_target_open): Use result of
 582         gdb_argv::release.
 583
 584 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 585         Dirk Schubert  <dirk.schubert@arm.com>
 586         Chris January  <chris.january@arm.com>
 587
 588         * eval.c (evaluate_subexp_standard): Call Fortran argument
 589         wrapping logic.
 590         * f-lang.c (struct value): A value which can be passed into a
 591         Fortran function call.
 592         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 593         where appropriate.
 594         (struct type): Value ready for a Fortran function call.
 595         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 596         is needed.
 597         * f-lang.h (fortran_argument_convert): Declaration.
 598         (fortran_preserve_arg_pointer): Declaration.
 599         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 600
 601 2019-03-05  Tom Tromey  <tromey@adacore.com>
 602
 603         * python/py-prettyprint.c (print_string_repr): Remove #if.
 604         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 605
 606 2019-03-05  Tom Tromey  <tromey@adacore.com>
 607
 608         * target.c (the_dummy_target): Move later.  Change type to
 609         "dummy_target".
 610         (initialize_targets): Don't initialize the_dummy_target.
 611
 612 2019-03-05  Tom Tromey  <tromey@adacore.com>
 613
 614         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 615         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 616
 617 2019-03-05  Tom Tromey  <tromey@adacore.com>
 618
 619         * windows-nat.c (windows_nat_target::attach)
 620         (windows_nat_target::detach): Don't call gdb_flush.
 621         * valprint.c (generic_val_print, val_print, val_print_string):
 622         Don't call gdb_flush.
 623         * utils.c (defaulted_query): Don't call gdb_flush.
 624         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 625         * target.c (target_announce_detach): Don't call gdb_flush.
 626         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 627         * remote.c (extended_remote_target::attach): Don't call
 628         gdb_flush.
 629         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 630         * printcmd.c (do_examine): Don't call gdb_flush.
 631         (info_display_command): Don't call gdb_flush.
 632         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 633         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 634         * memattr.c (info_mem_command): Don't call gdb_flush.
 635         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 636         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 637         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 638         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 639         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 640         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 641         (gnu_nat_target::detach): Don't call gdb_flush.
 642         * f-valprint.c (f_val_print): Don't call gdb_flush.
 643         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 644         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 645         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 646         gdb_flush.
 647         * c-valprint.c (c_val_print): Don't call gdb_flush.
 648         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 649
 650 2019-03-05  Tom Tromey  <tromey@adacore.com>
 651
 652         * varobj.c (update_dynamic_varobj_children): Update.
 653         (install_default_visualizer): Use reset, not release.
 654         * value.c (set_internalvar): Update.
 655         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 656         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 657         ATTRIBUTE_UNUSED_RESULT.
 658
 659 2019-03-05  Tom Tromey  <tromey@adacore.com>
 660
 661         * remote.c (class scoped_remote_fd) <release>: Add
 662         ATTRIBUTE_UNUSED_RESULT.
 663
 664 2019-03-05  Tom Tromey  <tromey@adacore.com>
 665
 666         * macroexp.c (struct macro_buffer) <release>: Add
 667         ATTRIBUTE_UNUSED_RESULT.
 668
 669 2019-03-05  Tom Tromey  <tromey@adacore.com>
 670
 671         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 672         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 673         ATTRIBUTE_UNUSED_RESULT.
 674
 675 2019-03-05  Tom Tromey  <tromey@adacore.com>
 676
 677         * common/scoped_fd.h (class scoped_fd) <release>: Add
 678         ATTRIBUTE_UNUSED_RESULT.
 679
 680 2019-03-05  Tom Tromey  <tromey@adacore.com>
 681
 682         * parser-defs.h (struct parser_state) <release>: Add
 683         ATTRIBUTE_UNUSED_RESULT.
 684
 685 2019-03-05  Tom Tromey  <tromey@adacore.com>
 686
 687         * utils.h (class gdb_argv) <release>: Add
 688         ATTRIBUTE_UNUSED_RESULT.
 689         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 690
 691 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 692
 693         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 694         for-loop range, to avoid compiler warnings.
 695
 696         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 697         avoid compiler warnings about unused variables.
 698
 699         * NEWS: Mention end of support for native debugging on MS-Windows
 700         before XP.
 701
 702         PR gdb/24292
 703         * common/netstuff.c:
 704         * gdbserver/gdbreplay.c
 705         * gdbserver/remote-utils.c:
 706         * ser-tcp.c:
 707         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 708         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 709         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 710         'getaddrinfo' and 'freeaddrinfo' were not available before
 711         Windows XP, and mingw.org's MinGW headers by default define
 712         _WIN32_WINNT to 0x500.
 713
 714 2019-03-01  Gary Benson <gbenson@redhat.com>
 715
 716         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 717
 718 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 719             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 720
 721         PR gdb/8527
 722         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 723         set_sigint_trap, clear_sigint_trap.
 724
 725 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 726
 727         * target.c (target_detach): Clear the regcache and the
 728         frame cache.
 729
 730 2019-02-27  Pedro Alves  <palves@redhat.com>
 731
 732         * utils.c (set_screen_size): When we cap the height/width sizes,
 733         tweak the corresponding command variable to show "unlimited":
 734
 735 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 736             Pedro Alves  <palves@redhat.com>
 737
 738         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 739         before calling rl_set_screen_size.
 740
 741 2019-02-27  Tom Tromey  <tromey@adacore.com>
 742
 743         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 744         define.
 745         * python/py-value.c: Remove Python 2.4 workaround.
 746         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 747         workaround.
 748         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 749         Python 2.4 workaround.
 750         * python/python-internal.h: Remove Python 2.4 comment.
 751         (Py_ssize_t): Don't define.
 752         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 753         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 754         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 755         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 756         * python/python.c (do_start_initialization): Remove Python 2.4
 757         workaround.
 758         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 759         (print_children): Remove Python 2.4 workaround.
 760         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 761         workaround.
 762         (CHARBUFFERPROC_NAME): Remove.
 763         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 764         Python 2.4 workaround.
 765
 766 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 767
 768         * NEWS: Note minimum Python version.
 769
 770 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 771
 772         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 773         code from these functions.  Remove corresponding ifdefs.  Use
 774         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 775         Remove gotos and target of gotos.
 776         (infpy_search_memory): Likewise.
 777
 778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 781         (hppa_gdbarch_init): Don't register deleted functions with
 782         gdbarch.
 783
 784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 787         (h8300_unwind_sp): Delete.
 788         (h8300_dummy_id): Delete.
 789         (h8300_gdbarch_init): Don't register deleted functions with
 790         gdbarch.
 791
 792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 793
 794         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 795         (ft32_unwind_pc): Delete.
 796         (ft32_unwind_sp): Delete.
 797         (ft32_gdbarch_init): Don't register deleted functions with
 798         gdbarch.
 799
 800 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 803         (frv_unwind_pc): Delete.
 804         (frv_unwind_sp): Delete.
 805         (frv_gdbarch_init): Don't register deleted functions with
 806         gdbarch.
 807
 808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 809
 810         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 811         (riscv_unwind_pc): Delete.
 812         (riscv_unwind_sp): Delete.
 813         (riscv_gdbarch_init): Don't register deleted functions with
 814         gdbarch.
 815
 816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 819         (csky_unwind_pc): Delete.
 820         (csky_unwind_sp): Delete.
 821         (csky_gdbarch_init): Don't register deleted functions with
 822         gdbarch.
 823
 824 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 825
 826         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 827         (cris_unwind_pc): Delete.
 828         (cris_unwind_sp): Delete.
 829         (cris_gdbarch_init): Don't register deleted functions with
 830         gdbarch.
 831
 832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 835         (bfin_unwind_pc): Delete.
 836         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 837
 838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 841         (arm_unwind_pc): Delete.
 842         (arm_unwind_sp): Delete.
 843         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 844
 845 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 848         (arc_unwind_pc): Delete.
 849         (arc_unwind_sp): Delete.
 850         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 851
 852 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 853
 854         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 855         (alpha_unwind_pc): Delete.
 856         (alpha_gdbarch_init): Don't register deleted functions with
 857         gdbarch.
 858
 859 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 860
 861         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 862         (aarch64_unwind_pc): Delete.
 863         (aarch64_unwind_sp): Delete.
 864         (aarch64_gdbarch_init): Don't register deleted functions with
 865         gdbarch.
 866
 867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * gdbtypes.c (type_align): Don't consider static members when
 870         computing structure alignment.
 871
 872 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 875         return 0 for other types.
 876         * arch-utils.c (default_type_align): Always return 0.
 877         * gdbarch.h: Regenerate.
 878         * gdbarch.sh (type_align): Extend comment.
 879         * gdbtypes.c (type_align): Add additional comments, always call
 880         gdbarch_type_align before applying the default rules.
 881         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 882         generic code will then apply a suitable default.
 883         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 884         types, return 0 for other types.
 885
 886 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 887
 888         * NEWS: Create a new section for the next release branch.
 889         Rename the section of the current branch, now that it has
 890         been cut.
 891
 892 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 893
 894         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 895         * version.in: Bump version to 8.3.50.DATE-git.
 896
 897 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 898
 899         * aix-thread.c (ptid_cmp): Remove unused variable.
 900         (get_signaled_thread): Likewise.
 901         (store_regs_user_thread): Likewise.
 902         (store_regs_kernel_thread): Likewise.
 903         (fetch_regs_kernel_thread): Remove shadowed variable.
 904
 905 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * features/riscv/32bit-cpu.xml: Add register numbers.
 908         * features/riscv/32bit-fpu.c: Regenerate.
 909         * features/riscv/32bit-fpu.xml: Add register numbers.
 910         * features/riscv/64bit-cpu.xml: Add register numbers.
 911         * features/riscv/64bit-fpu.c: Regenerate.
 912         * features/riscv/64bit-fpu.xml: Add register numbers.
 913
 914 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 915
 916         * NEWS: Mention two argument form of gdb.Value constructor.
 917         * python/py-value.c (convert_buffer_and_type_to_value): New
 918         function.
 919         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 920         Add support for handling an optional second argument.  Call
 921         convert_buffer_and_type_to_value as appropriate.
 922         * python/python-internal.h (Py_buffer_deleter): New struct.
 923         (Py_buffer_up): New typedef.
 924
 925 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 926
 927         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 928         instead of releasing ownership.
 929
 930 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 931
 932         * dwarf2read.c (open_and_init_dwp_file): Call
 933         elf_numsections instead of bfd_count_sections to initialize
 934         dwp_file->num_sections.
 935
 936 2019-02-25  Tom Tromey  <tromey@adacore.com>
 937
 938         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 939
 940 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 941
 942         * gcore.in: Add '--readnever' option when invoking GDB.
 943
 944 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 945
 946         * MAINTAINERS: Update my email address.
 947
 948 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 949
 950         * build-id.c (build_id_to_debug_bfd_1): New function.
 951         (build_id_to_debug_bfd): Look for separate debug file in
 952         sysroot.
 953
 954 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 955
 956         * gdbarch.sh: Update the copyright year range that is placed into
 957         generated files.
 958
 959 2019-02-22  Keith Seitz  <keiths@redhat.com>
 960
 961         PR symtab/23853
 962         * linespec.c (create_sals_line_offset): Search for the default
 963         symtab's filename instead of its fullname.
 964
 965 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 966
 967         * NEWS: Update style defaults.
 968
 969 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 970
 971         * main.c (captured_main_1): Disable styling in batch mode.
 972
 973 2019-02-20  Tom Tromey  <tom@tromey.com>
 974
 975         * symtab.c (symtab_symbol_info): Fix typos.
 976
 977 2019-02-20  Tom Tromey  <tromey@adacore.com>
 978
 979         * findcmd.c (_initialize_mem_search): Use upper case for
 980         metasyntactic variables.
 981
 982 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 983
 984         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 985         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 986
 987 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 988
 989         * top.h (source_file_name): Change to std::string.
 990         * top.c (source_file_name): Likewise.
 991         (command_line_input): Adjust.
 992         * cli/cli-script.c (script_from_file): Adjust.
 993
 994 2019-02-19  Tom Tromey  <tromey@adacore.com>
 995
 996         * ravenscar-thread.c
 997         (ravenscar_thread_target::update_thread_list): Don't call
 998         ada_build_task_list.
 999         * ada-lang.h (ada_build_task_list): Don't declare.
1000         * ada-tasks.c (struct ada_tasks_inferior_data)
1001         <task_list_valid_p>: Now bool.
1002         (read_known_tasks, ada_task_list_changed)
1003         (ada_tasks_invalidate_inferior_data): Update.
1004         (read_known_tasks_array): Return bool.
1005         (read_known_tasks_list): Likewise.
1006         (read_known_tasks): Return void.
1007         (ada_build_task_list): Now static.
1008
1009 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1010
1011         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1012         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1013
1014 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1015
1016         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1017         variant for ada_tasks_pspace_data_handle and
1018         ada_tasks_inferior_data_handle.
1019         (ada_tasks_pspace_data_cleanup): New function.
1020         (ada_tasks_inferior_data_cleanup): New function.
1021
1022 2019-02-17  Tom Tromey  <tom@tromey.com>
1023
1024         * macrotab.h (macro_source_fullname): Return a std::string.
1025         * macrotab.c (macro_include, check_for_redefinition)
1026         (macro_undef, macro_lookup_definition, foreach_macro)
1027         (foreach_macro_in_scope): Update.
1028         (macro_source_fullname): Return a std::string.
1029         * macrocmd.c (show_pp_source_pos): Update.
1030
1031 2019-02-17  Tom Tromey  <tom@tromey.com>
1032
1033         * macrocmd.c (show_pp_source_pos): Style the file names.
1034
1035 2019-02-17  Tom Tromey  <tom@tromey.com>
1036
1037         PR tui/24197:
1038         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1039
1040 2019-02-17  Tom Tromey  <tom@tromey.com>
1041
1042         * ada-lang.c (user_select_syms): Use filtered printing.
1043         * utils.c (wrap_style): New global.
1044         (desired_style): Remove.
1045         (emit_style_escape): Add stream parameter.
1046         (set_output_style, reset_terminal_style, prompt_for_continue):
1047         Update.
1048         (flush_wrap_buffer): Only flush gdb_stdout.
1049         (wrap_here): Set wrap_style.
1050         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1051         treat escape sequences as a character.  Change when wrap buffer is
1052         flushed.
1053         (fputs_styled): Do not set the output style when the default is
1054         requested.
1055         * ui-style.h (struct ui_file_style) <is_default>: New method.
1056         * source.c (print_source_lines_base): Emit escape sequences in one
1057         piece.
1058
1059 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1060
1061         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1062         integers and enumeration types.
1063
1064 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1065
1066         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1067         instead of lookup_symbol_in_language
1068         (do_exact_match): New function.
1069         (ada_get_symbol_name_matcher): Return do_exact_match when
1070         doing a verbatim match.
1071
1072 2019-02-15  Tom Tromey  <tromey@adacore.com>
1073
1074         * ravenscar-thread.c (ravenscar_thread_target::resume)
1075         (ravenscar_thread_target::wait): Special case wildcard requests.
1076
1077 2019-02-15  Tom Tromey  <tromey@adacore.com>
1078
1079         * ravenscar-thread.c (base_ptid): Remove.
1080         (struct ravenscar_thread_target) <close>: New method.
1081         <m_base_ptid>: New member.
1082         <update_inferior_ptid, active_task, task_is_currently_active,
1083         runtime_initialized>: Declare methods.
1084         <ravenscar_thread_target>: Add constructor.
1085         (ravenscar_thread_target::task_is_currently_active)
1086         (ravenscar_thread_target::update_inferior_ptid)
1087         (ravenscar_runtime_initialized): Rename.  Now methods.
1088         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1089         (ravenscar_thread_target::update_thread_list): Update.
1090         (ravenscar_thread_target::active_task): Now method.
1091         (ravenscar_thread_target::store_registers)
1092         (ravenscar_thread_target::prepare_to_store)
1093         (ravenscar_thread_target::prepare_to_store)
1094         (ravenscar_thread_target::mourn_inferior): Update.
1095         (ravenscar_inferior_created): Use "new" to create target.
1096         (ravenscar_thread_target::get_ada_task_ptid): Update.
1097         (_initialize_ravenscar): Don't initialize base_ptid.
1098         (ravenscar_ops): Remove global.
1099
1100 2019-02-15  Tom Tromey  <tromey@adacore.com>
1101
1102         * target.h (push_target): Declare new overload.
1103         * target.c (push_target): New overload, taking an rvalue reference.
1104         * remote.c (remote_target::open_1): Use push_target overload.
1105         * corelow.c (core_target_open): Use push_target overload.
1106
1107 2019-02-15  Tom Tromey  <tromey@adacore.com>
1108
1109         * ravenscar-thread.c (is_ravenscar_task)
1110         (ravenscar_task_is_currently_active): Return bool.
1111         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1112         (_initialize_ravenscar): Remove "(void)".
1113         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1114         Return bool.
1115
1116 2019-02-15  Tom Tromey  <tromey@adacore.com>
1117
1118         * ravenscar-thread.c (ravenscar_runtime_initializer)
1119         (has_ravenscar_runtime, get_running_thread_id)
1120         (ravenscar_thread_target::resume): Fix indentation.
1121
1122 2019-02-15  Tom Tromey  <tromey@adacore.com>
1123
1124         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1125         from ravenscar_arch_ops.
1126         (sparc_ravenscar_ops::fetch_registers)
1127         (sparc_ravenscar_ops::store_registers): Now methods.
1128         (sparc_ravenscar_prepare_to_store): Remove.
1129         (sparc_ravenscar_ops): Redefine.
1130         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1131         methods and destructor.  Remove members.
1132         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1133         (ravenscar_thread_target::store_registers)
1134         (ravenscar_thread_target::prepare_to_store): Update.
1135         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1136         Remove.
1137         (struct ppc_ravenscar_powerpc_ops): Derive from
1138         ravenscar_arch_ops.
1139         (ppc_ravenscar_powerpc_ops::fetch_registers)
1140         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1141         (ppc_ravenscar_powerpc_ops): Redefine.
1142         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1143         (ppc_ravenscar_e500_ops::fetch_registers)
1144         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1145         (ppc_ravenscar_e500_ops): Redefine.
1146         * aarch64-ravenscar-thread.c
1147         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1148         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1149         (aarch64_ravenscar_fetch_registers)
1150         (aarch64_ravenscar_store_registers): Now methods.
1151         (aarch64_ravenscar_ops): Redefine.
1152
1153 2019-02-15  Tom Tromey  <tromey@adacore.com>
1154
1155         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1156         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1157         (ravenscar_thread_target::stopped_by_watchpoint)
1158         (ravenscar_thread_target::stopped_data_address)
1159         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1160
1161 2019-02-15  Tom Tromey  <tromey@adacore.com>
1162
1163         * ravenscar-thread.c: Fix some typos.
1164
1165 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1166             Tom Tromey  <tromey@adacore.com>
1167
1168         * ada-lang.c (ada_exception_sal): Change addr_string to a
1169         std::string.
1170         (create_ada_exception_catchpoint): Update.
1171
1172 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1173             Tom Tromey  <tromey@adacore.com>
1174
1175         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1176         (bp_location_ops): Remove.
1177         (base_breakpoint_allocate_location): Update.
1178         (free_bp_location): Update.
1179         * ada-lang.c (class ada_catchpoint_location)
1180         <ada_catchpoint_location>: Remove ops parameter.
1181         (ada_catchpoint_location_dtor): Remove.
1182         (ada_catchpoint_location_ops): Remove.
1183         (allocate_location_exception): Update.
1184         * breakpoint.h (struct bp_location_ops): Remove.
1185         (class bp_location) <bp_location>: Remove bp_location_ops
1186         parameter.
1187         <~bp_location>: Add destructor.
1188         <ops>: Remove.
1189
1190 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1191             Pedro Alves  <palves@redhat.com>
1192
1193         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1194         'PATH_MAX'.
1195
1196 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1197             Samuel Thibault  <samuel.thibault@gnu.org>
1198             Thomas Schwinge  <thomas@codesourcery.com>
1199
1200         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1201         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1202
1203 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1204
1205         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1206         (check_empty): Use "const char *".
1207
1208         * gnu-nat.c (gnu_nat_target::detach): Instead of
1209         'detach_inferior (pid)' call
1210         'detach_inferior (find_inferior_pid (pid))'.
1211
1212         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1213         'nat/fork-inferior.o'.
1214         * gnu-nat.c: #include "nat/fork-inferior.h".
1215
1216         * gnu-nat.c (gnu_nat_target::detach): Instead of
1217         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1218         * gnu-nat.h: #include "inf-child.h".
1219         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1220         'i386_gnu_nat_target::fetch_registers'.
1221         (gnu_store_registers): Rename/move to
1222         'i386_gnu_nat_target::store_registers'.
1223
1224         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1225         * gnu-nat.h (mach_thread_info): New function.
1226         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1227
1228         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1229
1230 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1231
1232         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1233
1234 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1235
1236         * windows-nat.c (windows_add_thread): Add new parameter
1237         "main_thread_p" with default value set to false.  Update
1238         function documentation as well as all callers.
1239         (windows_delete_thread): Likewise.
1240         (fake_create_process): Update call to windows_add_thread.
1241         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1242         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1243         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1244         call to windows_delete_thread.
1245
1246 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1247
1248         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1249
1250 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1251
1252         * symfile.c (find_separate_debug_file): Use canonical path of
1253         sysroot with child_path instead of gdb_sysroot if it is valid.
1254
1255 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1256
1257         * symfile.c (find_separate_debug_file): Use child_path to
1258         determine if an object file is under a sysroot.
1259
1260 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1261
1262         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1263         unittests/child-path-selftests.c.
1264         * common/pathstuff.c (child_path): New function.
1265         * common/pathstuff.h (child_path): New prototype.
1266         * unittests/child-path-selftests.c: New file.
1267
1268 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1269
1270         * symfile.c (find_separate_debug_file): Look for separate debug
1271         files in debug directories under the sysroot.
1272
1273 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1274
1275         * symtab.h (struct minimal_symbol data_p): New const method.
1276         (struct minimal_symbol text_p): Likewise.
1277         * symtab.c (output_source_filename): Use file name style
1278         to print file name.
1279         (print_symbol_info): Likewise.
1280         (print_msymbol_info): Use address style to print addresses.
1281         Use function name style to print executable text symbols.
1282         (expand_symtab_containing_pc): Use data_p.
1283         (find_pc_sect_compunit_symtab): Likewise.
1284
1285 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1286
1287         * breakpoint.c (describe_other_breakpoints): Use address style
1288         to print addresses.
1289         (say_where): Likewise.
1290
1291 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1292
1293         * ada-typeprint.c (print_func_type): Print function name
1294         style to print function name.
1295         * c-typeprint.c (c_print_type_1): Likewise.
1296
1297 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1298
1299         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1300         for execve.
1301
1302 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1303
1304         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1305         type_stack.
1306
1307 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1308
1309         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1310         TYPE_CODE_REF types.
1311
1312 2019-02-08  Jim Wilson  <jimw@sifive.com>
1313
1314         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1315         (riscv_linux_fregset): New.
1316         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1317
1318 2019-02-07  Tom Tromey  <tom@tromey.com>
1319
1320         * thread.c (thread_cancel_execution_command): Update.
1321         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1322         methods.
1323         (struct thread_fsm_ops): Remove.
1324         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1325         (thread_fsm_should_stop, thread_fsm_return_value)
1326         (thread_fsm_set_finished, thread_fsm_finished_p)
1327         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1328         Don't declare.
1329         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1330         * infrun.c (clear_proceed_status_thread)
1331         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1332         (print_stop_event): Update.
1333         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1334         Add constructor.
1335         (step_command_fsm_ops): Remove.
1336         (new_step_command_fsm): Remove.
1337         (step_1): Update.
1338         (step_command_fsm::should_stop): Rename from
1339         step_command_fsm_should_stop.
1340         (step_command_fsm::clean_up): Rename from
1341         step_command_fsm_clean_up.
1342         (step_command_fsm::do_async_reply_reason): Rename from
1343         step_command_fsm_async_reply_reason.
1344         (struct until_next_fsm): Inherit from thread_fsm.  Add
1345         constructor.
1346         (until_next_fsm_ops): Remove.
1347         (new_until_next_fsm): Remove.
1348         (until_next_fsm::should_stop): Rename from
1349         until_next_fsm_should_stop.
1350         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1351         (until_next_fsm::do_async_reply_reason): Rename from
1352         until_next_fsm_async_reply_reason.
1353         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1354         constructor.  Change type of breakpoint.
1355         (finish_command_fsm_ops): Remove.
1356         (new_finish_command_fsm): Remove.
1357         (finish_command_fsm::should_stop): Rename from
1358         finish_command_fsm_should_stop.
1359         (finish_command_fsm::clean_up): Rename from
1360         finish_command_fsm_clean_up.
1361         (finish_command_fsm::return_value): Rename from
1362         finish_command_fsm_return_value.
1363         (finish_command_fsm::do_async_reply_reason): Rename from
1364         finish_command_fsm_async_reply_reason.
1365         (finish_command): Update.
1366         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1367         Add constructor.
1368         (call_thread_fsm_ops): Remove.
1369         (call_thread_fsm::call_thread_fsm): Rename from
1370         new_call_thread_fsm.
1371         (call_thread_fsm::should_stop): Rename from
1372         call_thread_fsm_should_stop.
1373         (call_thread_fsm::should_notify_stop): Rename from
1374         call_thread_fsm_should_notify_stop.
1375         (run_inferior_call, call_function_by_hand_dummy): Update.
1376         * cli/cli-interp.c (should_print_stop_to_console): Update.
1377         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1378         Add constructor.  Change type of location_breakpoint,
1379         caller_breakpoint.
1380         (until_break_fsm_ops): Remove.
1381         (new_until_break_fsm): Remove.
1382         (until_break_fsm::should_stop): Rename from
1383         until_break_fsm_should_stop.
1384         (until_break_fsm::clean_up): Rename from
1385         until_break_fsm_clean_up.
1386         (until_break_fsm::do_async_reply_reason): Rename from
1387         until_break_fsm_async_reply_reason.
1388         (until_break_command): Update.
1389         * thread-fsm.c: Remove.
1390         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1391
1392 2019-02-07  Tom Tromey  <tom@tromey.com>
1393
1394         * yy-remap.h: Add include guard.
1395         * xtensa-tdep.h: Add include guard.
1396         * xcoffread.h: Rename include guard.
1397         * varobj-iter.h: Add include guard.
1398         * tui/tui.h: Rename include guard.
1399         * tui/tui-winsource.h: Rename include guard.
1400         * tui/tui-wingeneral.h: Rename include guard.
1401         * tui/tui-windata.h: Rename include guard.
1402         * tui/tui-win.h: Rename include guard.
1403         * tui/tui-stack.h: Rename include guard.
1404         * tui/tui-source.h: Rename include guard.
1405         * tui/tui-regs.h: Rename include guard.
1406         * tui/tui-out.h: Rename include guard.
1407         * tui/tui-layout.h: Rename include guard.
1408         * tui/tui-io.h: Rename include guard.
1409         * tui/tui-hooks.h: Rename include guard.
1410         * tui/tui-file.h: Rename include guard.
1411         * tui/tui-disasm.h: Rename include guard.
1412         * tui/tui-data.h: Rename include guard.
1413         * tui/tui-command.h: Rename include guard.
1414         * tic6x-tdep.h: Add include guard.
1415         * target/waitstatus.h: Rename include guard.
1416         * target/wait.h: Rename include guard.
1417         * target/target.h: Rename include guard.
1418         * target/resume.h: Rename include guard.
1419         * target-float.h: Rename include guard.
1420         * stabsread.h: Add include guard.
1421         * rs6000-tdep.h: Add include guard.
1422         * riscv-fbsd-tdep.h: Add include guard.
1423         * regformats/regdef.h: Rename include guard.
1424         * record.h: Rename include guard.
1425         * python/python.h: Rename include guard.
1426         * python/python-internal.h: Rename include guard.
1427         * python/py-stopevent.h: Rename include guard.
1428         * python/py-ref.h: Rename include guard.
1429         * python/py-record.h: Rename include guard.
1430         * python/py-record-full.h: Rename include guard.
1431         * python/py-record-btrace.h: Rename include guard.
1432         * python/py-instruction.h: Rename include guard.
1433         * python/py-events.h: Rename include guard.
1434         * python/py-event.h: Rename include guard.
1435         * procfs.h: Add include guard.
1436         * proc-utils.h: Add include guard.
1437         * p-lang.h: Add include guard.
1438         * or1k-tdep.h: Rename include guard.
1439         * observable.h: Rename include guard.
1440         * nto-tdep.h: Rename include guard.
1441         * nat/x86-linux.h: Rename include guard.
1442         * nat/x86-linux-dregs.h: Rename include guard.
1443         * nat/x86-gcc-cpuid.h: Add include guard.
1444         * nat/x86-dregs.h: Rename include guard.
1445         * nat/x86-cpuid.h: Rename include guard.
1446         * nat/ppc-linux.h: Rename include guard.
1447         * nat/mips-linux-watch.h: Rename include guard.
1448         * nat/linux-waitpid.h: Rename include guard.
1449         * nat/linux-ptrace.h: Rename include guard.
1450         * nat/linux-procfs.h: Rename include guard.
1451         * nat/linux-osdata.h: Rename include guard.
1452         * nat/linux-nat.h: Rename include guard.
1453         * nat/linux-namespaces.h: Rename include guard.
1454         * nat/linux-btrace.h: Rename include guard.
1455         * nat/glibc_thread_db.h: Rename include guard.
1456         * nat/gdb_thread_db.h: Rename include guard.
1457         * nat/gdb_ptrace.h: Rename include guard.
1458         * nat/fork-inferior.h: Rename include guard.
1459         * nat/amd64-linux-siginfo.h: Rename include guard.
1460         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1461         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1462         * nat/aarch64-linux.h: Rename include guard.
1463         * nat/aarch64-linux-hw-point.h: Rename include guard.
1464         * mn10300-tdep.h: Add include guard.
1465         * mips-linux-tdep.h: Add include guard.
1466         * mi/mi-parse.h: Rename include guard.
1467         * mi/mi-out.h: Rename include guard.
1468         * mi/mi-main.h: Rename include guard.
1469         * mi/mi-interp.h: Rename include guard.
1470         * mi/mi-getopt.h: Rename include guard.
1471         * mi/mi-console.h: Rename include guard.
1472         * mi/mi-common.h: Rename include guard.
1473         * mi/mi-cmds.h: Rename include guard.
1474         * mi/mi-cmd-break.h: Rename include guard.
1475         * m2-lang.h: Add include guard.
1476         * location.h: Rename include guard.
1477         * linux-record.h: Rename include guard.
1478         * linux-nat.h: Add include guard.
1479         * linux-fork.h: Add include guard.
1480         * i386-darwin-tdep.h: Rename include guard.
1481         * hppa-linux-offsets.h: Add include guard.
1482         * guile/guile.h: Rename include guard.
1483         * guile/guile-internal.h: Rename include guard.
1484         * gnu-nat.h: Rename include guard.
1485         * gdb-stabs.h: Rename include guard.
1486         * frv-tdep.h: Add include guard.
1487         * f-lang.h: Add include guard.
1488         * event-loop.h: Add include guard.
1489         * darwin-nat.h: Rename include guard.
1490         * cp-abi.h: Rename include guard.
1491         * config/sparc/nm-sol2.h: Rename include guard.
1492         * config/nm-nto.h: Rename include guard.
1493         * config/nm-linux.h: Add include guard.
1494         * config/i386/nm-i386gnu.h: Rename include guard.
1495         * config/djgpp/nl_types.h: Rename include guard.
1496         * config/djgpp/langinfo.h: Rename include guard.
1497         * compile/gcc-cp-plugin.h: Add include guard.
1498         * compile/gcc-c-plugin.h: Add include guard.
1499         * compile/compile.h: Rename include guard.
1500         * compile/compile-object-run.h: Rename include guard.
1501         * compile/compile-object-load.h: Rename include guard.
1502         * compile/compile-internal.h: Rename include guard.
1503         * compile/compile-cplus.h: Rename include guard.
1504         * compile/compile-c.h: Rename include guard.
1505         * common/xml-utils.h: Rename include guard.
1506         * common/x86-xstate.h: Rename include guard.
1507         * common/version.h: Rename include guard.
1508         * common/vec.h: Rename include guard.
1509         * common/tdesc.h: Rename include guard.
1510         * common/selftest.h: Rename include guard.
1511         * common/scoped_restore.h: Rename include guard.
1512         * common/scoped_mmap.h: Rename include guard.
1513         * common/scoped_fd.h: Rename include guard.
1514         * common/safe-iterator.h: Rename include guard.
1515         * common/run-time-clock.h: Rename include guard.
1516         * common/refcounted-object.h: Rename include guard.
1517         * common/queue.h: Rename include guard.
1518         * common/ptid.h: Rename include guard.
1519         * common/print-utils.h: Rename include guard.
1520         * common/preprocessor.h: Rename include guard.
1521         * common/pathstuff.h: Rename include guard.
1522         * common/observable.h: Rename include guard.
1523         * common/netstuff.h: Rename include guard.
1524         * common/job-control.h: Rename include guard.
1525         * common/host-defs.h: Rename include guard.
1526         * common/gdb_wait.h: Rename include guard.
1527         * common/gdb_vecs.h: Rename include guard.
1528         * common/gdb_unlinker.h: Rename include guard.
1529         * common/gdb_unique_ptr.h: Rename include guard.
1530         * common/gdb_tilde_expand.h: Rename include guard.
1531         * common/gdb_sys_time.h: Rename include guard.
1532         * common/gdb_string_view.h: Rename include guard.
1533         * common/gdb_splay_tree.h: Rename include guard.
1534         * common/gdb_setjmp.h: Rename include guard.
1535         * common/gdb_ref_ptr.h: Rename include guard.
1536         * common/gdb_optional.h: Rename include guard.
1537         * common/gdb_locale.h: Rename include guard.
1538         * common/gdb_assert.h: Rename include guard.
1539         * common/filtered-iterator.h: Rename include guard.
1540         * common/filestuff.h: Rename include guard.
1541         * common/fileio.h: Rename include guard.
1542         * common/environ.h: Rename include guard.
1543         * common/common-utils.h: Rename include guard.
1544         * common/common-types.h: Rename include guard.
1545         * common/common-regcache.h: Rename include guard.
1546         * common/common-inferior.h: Rename include guard.
1547         * common/common-gdbthread.h: Rename include guard.
1548         * common/common-exceptions.h: Rename include guard.
1549         * common/common-defs.h: Rename include guard.
1550         * common/common-debug.h: Rename include guard.
1551         * common/cleanups.h: Rename include guard.
1552         * common/buffer.h: Rename include guard.
1553         * common/btrace-common.h: Rename include guard.
1554         * common/break-common.h: Rename include guard.
1555         * cli/cli-utils.h: Rename include guard.
1556         * cli/cli-style.h: Rename include guard.
1557         * cli/cli-setshow.h: Rename include guard.
1558         * cli/cli-script.h: Rename include guard.
1559         * cli/cli-interp.h: Rename include guard.
1560         * cli/cli-decode.h: Rename include guard.
1561         * cli/cli-cmds.h: Rename include guard.
1562         * charset-list.h: Add include guard.
1563         * buildsym-legacy.h: Rename include guard.
1564         * bfin-tdep.h: Add include guard.
1565         * ax.h: Rename include guard.
1566         * arm-linux-tdep.h: Add include guard.
1567         * arm-fbsd-tdep.h: Add include guard.
1568         * arch/xtensa.h: Rename include guard.
1569         * arch/tic6x.h: Add include guard.
1570         * arch/i386.h: Add include guard.
1571         * arch/arm.h: Rename include guard.
1572         * arch/arm-linux.h: Rename include guard.
1573         * arch/arm-get-next-pcs.h: Rename include guard.
1574         * arch/amd64.h: Add include guard.
1575         * arch/aarch64-insn.h: Rename include guard.
1576         * arch-utils.h: Rename include guard.
1577         * annotate.h: Add include guard.
1578         * amd64-darwin-tdep.h: Rename include guard.
1579         * aarch64-linux-tdep.h: Add include guard.
1580         * aarch64-fbsd-tdep.h: Add include guard.
1581         * aarch32-linux-nat.h: Add include guard.
1582
1583 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1584
1585         * macrotab.c (macro_define_internal): New function that
1586         factorizes macro_define_object_internal and macro_define_function
1587         code.
1588         (macro_define_object_internal): Use macro_define_internal.
1589         (macro_define_function): Likewise.
1590
1591 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1592
1593         * macrocmd.c (extract_identifier): Return
1594         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1595         callers.
1596
1597 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1598
1599         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1600
1601 2019-02-05  Tom Tromey  <tom@tromey.com>
1602
1603         * target.c (target_stack::unpush): Move assertion earlier.
1604
1605 2019-01-30  Tom Tromey  <tom@tromey.com>
1606
1607         PR python/23615:
1608         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1609         (gdbpy_parse_and_eval): Likewise.
1610         * python/python-internal.h (gdbpy_allow_threads): New class.
1611
1612 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1613
1614         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1615         (aarch64_fbsd_fpregmap): Move earlier.
1616         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1617         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1618         instead of individual calls to trad_frame_set_reg_addr.
1619         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1620         earlier.
1621         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1622         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1623         instead of individual calls to trad_frame_set_reg_addr.
1624
1625 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1626
1627         * CONTRIBUTE: Replace contribution list with wiki link.
1628
1629 2019-01-25  Tom Tromey  <tom@tromey.com>
1630
1631         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1632
1633 2019-01-25  Tom Tromey  <tom@tromey.com>
1634
1635         * xtensa-linux-nat.c: Fix common/ includes.
1636         * xml-support.h: Fix common/ includes.
1637         * xml-support.c: Fix common/ includes.
1638         * x86-linux-nat.c: Fix common/ includes.
1639         * windows-nat.c: Fix common/ includes.
1640         * varobj.h: Fix common/ includes.
1641         * varobj.c: Fix common/ includes.
1642         * value.c: Fix common/ includes.
1643         * valops.c: Fix common/ includes.
1644         * utils.c: Fix common/ includes.
1645         * unittests/xml-utils-selftests.c: Fix common/ includes.
1646         * unittests/utils-selftests.c: Fix common/ includes.
1647         * unittests/unpack-selftests.c: Fix common/ includes.
1648         * unittests/tracepoint-selftests.c: Fix common/ includes.
1649         * unittests/style-selftests.c: Fix common/ includes.
1650         * unittests/string_view-selftests.c: Fix common/ includes.
1651         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1652         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1653         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1654         * unittests/rsp-low-selftests.c: Fix common/ includes.
1655         * unittests/parse-connection-spec-selftests.c: Fix common/
1656         includes.
1657         * unittests/optional-selftests.c: Fix common/ includes.
1658         * unittests/offset-type-selftests.c: Fix common/ includes.
1659         * unittests/observable-selftests.c: Fix common/ includes.
1660         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1661         * unittests/memrange-selftests.c: Fix common/ includes.
1662         * unittests/memory-map-selftests.c: Fix common/ includes.
1663         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1664         * unittests/function-view-selftests.c: Fix common/ includes.
1665         * unittests/environ-selftests.c: Fix common/ includes.
1666         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1667         * unittests/common-utils-selftests.c: Fix common/ includes.
1668         * unittests/cli-utils-selftests.c: Fix common/ includes.
1669         * unittests/array-view-selftests.c: Fix common/ includes.
1670         * ui-file.c: Fix common/ includes.
1671         * tui/tui-io.c: Fix common/ includes.
1672         * tracepoint.h: Fix common/ includes.
1673         * tracepoint.c: Fix common/ includes.
1674         * tracefile-tfile.c: Fix common/ includes.
1675         * top.h: Fix common/ includes.
1676         * top.c: Fix common/ includes.
1677         * thread.c: Fix common/ includes.
1678         * target/waitstatus.h: Fix common/ includes.
1679         * target/waitstatus.c: Fix common/ includes.
1680         * target.h: Fix common/ includes.
1681         * target.c: Fix common/ includes.
1682         * target-memory.c: Fix common/ includes.
1683         * target-descriptions.c: Fix common/ includes.
1684         * symtab.h: Fix common/ includes.
1685         * symfile.c: Fix common/ includes.
1686         * stap-probe.c: Fix common/ includes.
1687         * spu-linux-nat.c: Fix common/ includes.
1688         * sparc-nat.c: Fix common/ includes.
1689         * source.c: Fix common/ includes.
1690         * solib.c: Fix common/ includes.
1691         * solib-target.c: Fix common/ includes.
1692         * ser-unix.c: Fix common/ includes.
1693         * ser-tcp.c: Fix common/ includes.
1694         * ser-pipe.c: Fix common/ includes.
1695         * ser-base.c: Fix common/ includes.
1696         * selftest-arch.c: Fix common/ includes.
1697         * s12z-tdep.c: Fix common/ includes.
1698         * rust-exp.y: Fix common/ includes.
1699         * rs6000-aix-tdep.c: Fix common/ includes.
1700         * riscv-tdep.c: Fix common/ includes.
1701         * remote.c: Fix common/ includes.
1702         * remote-notif.h: Fix common/ includes.
1703         * remote-fileio.h: Fix common/ includes.
1704         * remote-fileio.c: Fix common/ includes.
1705         * regcache.h: Fix common/ includes.
1706         * regcache.c: Fix common/ includes.
1707         * record-btrace.c: Fix common/ includes.
1708         * python/python.c: Fix common/ includes.
1709         * python/py-type.c: Fix common/ includes.
1710         * python/py-inferior.c: Fix common/ includes.
1711         * progspace.h: Fix common/ includes.
1712         * producer.c: Fix common/ includes.
1713         * procfs.c: Fix common/ includes.
1714         * proc-api.c: Fix common/ includes.
1715         * printcmd.c: Fix common/ includes.
1716         * ppc-linux-nat.c: Fix common/ includes.
1717         * parser-defs.h: Fix common/ includes.
1718         * osdata.c: Fix common/ includes.
1719         * obsd-nat.c: Fix common/ includes.
1720         * nat/x86-linux.c: Fix common/ includes.
1721         * nat/x86-linux-dregs.c: Fix common/ includes.
1722         * nat/x86-dregs.h: Fix common/ includes.
1723         * nat/x86-dregs.c: Fix common/ includes.
1724         * nat/ppc-linux.c: Fix common/ includes.
1725         * nat/mips-linux-watch.h: Fix common/ includes.
1726         * nat/mips-linux-watch.c: Fix common/ includes.
1727         * nat/linux-waitpid.c: Fix common/ includes.
1728         * nat/linux-ptrace.h: Fix common/ includes.
1729         * nat/linux-ptrace.c: Fix common/ includes.
1730         * nat/linux-procfs.c: Fix common/ includes.
1731         * nat/linux-personality.c: Fix common/ includes.
1732         * nat/linux-osdata.c: Fix common/ includes.
1733         * nat/linux-namespaces.c: Fix common/ includes.
1734         * nat/linux-btrace.h: Fix common/ includes.
1735         * nat/linux-btrace.c: Fix common/ includes.
1736         * nat/fork-inferior.c: Fix common/ includes.
1737         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1738         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1739         * nat/aarch64-linux.c: Fix common/ includes.
1740         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1741         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1742         * namespace.h: Fix common/ includes.
1743         * mips-linux-tdep.c: Fix common/ includes.
1744         * minsyms.c: Fix common/ includes.
1745         * mi/mi-parse.h: Fix common/ includes.
1746         * mi/mi-main.c: Fix common/ includes.
1747         * mi/mi-cmd-env.c: Fix common/ includes.
1748         * memrange.h: Fix common/ includes.
1749         * memattr.c: Fix common/ includes.
1750         * maint.h: Fix common/ includes.
1751         * maint.c: Fix common/ includes.
1752         * main.c: Fix common/ includes.
1753         * machoread.c: Fix common/ includes.
1754         * location.c: Fix common/ includes.
1755         * linux-thread-db.c: Fix common/ includes.
1756         * linux-nat.c: Fix common/ includes.
1757         * linux-fork.c: Fix common/ includes.
1758         * inline-frame.c: Fix common/ includes.
1759         * infrun.c: Fix common/ includes.
1760         * inflow.c: Fix common/ includes.
1761         * inferior.h: Fix common/ includes.
1762         * inferior.c: Fix common/ includes.
1763         * infcmd.c: Fix common/ includes.
1764         * inf-ptrace.c: Fix common/ includes.
1765         * inf-child.c: Fix common/ includes.
1766         * ia64-linux-nat.c: Fix common/ includes.
1767         * i387-tdep.c: Fix common/ includes.
1768         * i386-tdep.c: Fix common/ includes.
1769         * i386-linux-tdep.c: Fix common/ includes.
1770         * i386-linux-nat.c: Fix common/ includes.
1771         * i386-go32-tdep.c: Fix common/ includes.
1772         * i386-fbsd-tdep.c: Fix common/ includes.
1773         * i386-fbsd-nat.c: Fix common/ includes.
1774         * guile/scm-type.c: Fix common/ includes.
1775         * guile/guile.c: Fix common/ includes.
1776         * go32-nat.c: Fix common/ includes.
1777         * gnu-nat.c: Fix common/ includes.
1778         * gdbthread.h: Fix common/ includes.
1779         * gdbarch-selftests.c: Fix common/ includes.
1780         * gdb_usleep.c: Fix common/ includes.
1781         * gdb_select.h: Fix common/ includes.
1782         * gdb_bfd.c: Fix common/ includes.
1783         * gcore.c: Fix common/ includes.
1784         * fork-child.c: Fix common/ includes.
1785         * findvar.c: Fix common/ includes.
1786         * fbsd-nat.c: Fix common/ includes.
1787         * event-top.c: Fix common/ includes.
1788         * event-loop.c: Fix common/ includes.
1789         * dwarf2read.c: Fix common/ includes.
1790         * dwarf2loc.c: Fix common/ includes.
1791         * dwarf2-frame.c: Fix common/ includes.
1792         * dwarf-index-cache.c: Fix common/ includes.
1793         * dtrace-probe.c: Fix common/ includes.
1794         * disasm-selftests.c: Fix common/ includes.
1795         * defs.h: Fix common/ includes.
1796         * csky-tdep.c: Fix common/ includes.
1797         * cp-valprint.c: Fix common/ includes.
1798         * cp-support.h: Fix common/ includes.
1799         * cp-support.c: Fix common/ includes.
1800         * corelow.c: Fix common/ includes.
1801         * completer.h: Fix common/ includes.
1802         * completer.c: Fix common/ includes.
1803         * compile/compile.c: Fix common/ includes.
1804         * compile/compile-loc2c.c: Fix common/ includes.
1805         * compile/compile-cplus-types.c: Fix common/ includes.
1806         * compile/compile-cplus-symbols.c: Fix common/ includes.
1807         * command.h: Fix common/ includes.
1808         * cli/cli-dump.c: Fix common/ includes.
1809         * cli/cli-cmds.c: Fix common/ includes.
1810         * charset.c: Fix common/ includes.
1811         * build-id.c: Fix common/ includes.
1812         * btrace.h: Fix common/ includes.
1813         * btrace.c: Fix common/ includes.
1814         * breakpoint.h: Fix common/ includes.
1815         * breakpoint.c: Fix common/ includes.
1816         * ax.h:
1817         (enum agent_op): Fix common/ includes.
1818         * ax-general.c (struct aop_map): Fix common/ includes.
1819         * ax-gdb.c: Fix common/ includes.
1820         * auxv.c: Fix common/ includes.
1821         * auto-load.c: Fix common/ includes.
1822         * arm-tdep.c: Fix common/ includes.
1823         * arch/riscv.c: Fix common/ includes.
1824         * arch/ppc-linux-common.c: Fix common/ includes.
1825         * arch/i386.c: Fix common/ includes.
1826         * arch/arm.c: Fix common/ includes.
1827         * arch/arm-linux.c: Fix common/ includes.
1828         * arch/arm-get-next-pcs.c: Fix common/ includes.
1829         * arch/amd64.c: Fix common/ includes.
1830         * arch/aarch64.c: Fix common/ includes.
1831         * arch/aarch64-insn.c: Fix common/ includes.
1832         * arch-utils.c: Fix common/ includes.
1833         * amd64-windows-tdep.c: Fix common/ includes.
1834         * amd64-tdep.c: Fix common/ includes.
1835         * amd64-sol2-tdep.c: Fix common/ includes.
1836         * amd64-obsd-tdep.c: Fix common/ includes.
1837         * amd64-nbsd-tdep.c: Fix common/ includes.
1838         * amd64-linux-tdep.c: Fix common/ includes.
1839         * amd64-linux-nat.c: Fix common/ includes.
1840         * amd64-fbsd-tdep.c: Fix common/ includes.
1841         * amd64-fbsd-nat.c: Fix common/ includes.
1842         * amd64-dicos-tdep.c: Fix common/ includes.
1843         * amd64-darwin-tdep.c: Fix common/ includes.
1844         * agent.c: Fix common/ includes.
1845         * ada-lang.h: Fix common/ includes.
1846         * ada-lang.c: Fix common/ includes.
1847         * aarch64-tdep.c: Fix common/ includes.
1848
1849 2019-01-25  Tom Tromey  <tom@tromey.com>
1850
1851         * common/create-version.sh: Use common/version.h.
1852
1853 2019-01-24  Pedro Alves  <palves@redhat.com>
1854
1855         * infrun.c (signal_stop, signal_print, signal_program)
1856         (signal_catch, signal_pass): Now arrays instead of pointers.
1857         (update_signals_program_target, do_target_resume)
1858         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1859         * linux-nat.c (linux_nat_target::pass_signals)
1860         (linux_nat_target::create_inferior, linux_nat_target::attach):
1861         Adjust.
1862         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1863         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1864         * procfs.c (procfs_target::pass_signals): Adjust.
1865         * record-full.c (record_full_target::resume): Adjust.
1866         * remote.c (remote_target::pass_signals)
1867         (remote_target::program_signals): Adjust.
1868         * target-debug.h (target_debug_print_signals): Now takes a
1869         gdb::array_view as parameter.  Adjust.
1870         * target.h (target_ops) <pass_signals, program_signals>: Replace
1871         pointer and length parameters with gdb::array_view.
1872         (target_pass_signals, target_program_signals): Likewise.
1873         * target-delegates.c: Regenerate.
1874
1875 2019-01-24  Pedro Alves  <palves@redhat.com>
1876
1877         * common/forward-scope-exit.h
1878         (forward_scope_exit::forward_scope_exit): Pass arguments to
1879         m_bind_function directly, instead of creating a std::bind and
1880         copying that.
1881
1882 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1883
1884         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1885         for static members.
1886         (pass_in_v_vfp_candidate): Likewise.
1887
1888 2019-01-23  Tom Tromey  <tom@tromey.com>
1889             Pedro Alves  <palves@redhat.com>
1890
1891         * regcache.c (class regcache_invalidator): Remove.
1892         (regcache::raw_write): Use make_scope_exit.
1893
1894 2019-01-23  Tom Tromey  <tom@tromey.com>
1895
1896         * ui-out.h (class ui_out_emit_type): Update comment.
1897
1898 2019-01-23  Tom Tromey  <tom@tromey.com>
1899
1900         * infrun.c (fetch_inferior_event): Update comment.
1901
1902 2019-01-23  Tom Tromey  <tom@tromey.com>
1903             Pedro Alves  <palves@redhat.com>
1904
1905         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1906         parameter.
1907         (fetch_inferior_event): Use SCOPE_EXIT.
1908
1909
1910 2019-01-23  Tom Tromey  <tom@tromey.com>
1911             Pedro Alves  <palves@redhat.com>
1912
1913         * infrun.c (disable_thread_events): Delete.
1914         (stop_all_threads): Use SCOPE_EXIT.
1915
1916 2019-01-23  Tom Tromey  <tom@tromey.com>
1917             Pedro Alves  <palves@redhat.com>
1918
1919         * symfile.c: Include forward-scope-exit.h.
1920         (clear_symtab_users_cleanup): Replace forward declaration with
1921         a FORWARD_SCOPE_EXIT.
1922         (syms_from_objfile_1): Use the forward_scope_exit and
1923         gdb::optional instead of cleanup_function.
1924         (reread_symbols): Use the forward_scope_exit instead of
1925         cleanup_function.
1926         (clear_symtab_users_cleanup): Remove function.
1927
1928 2019-01-23  Tom Tromey  <tom@tromey.com>
1929             Pedro Alves  <palves@redhat.com>
1930
1931         * linux-nat.c: Include scope-exit.h.
1932         (cleanup_target_stop): Remove.
1933         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1934         SCOPE_EXIT.
1935
1936 2019-01-23  Tom Tromey  <tom@tromey.com>
1937             Pedro Alves  <palves@redhat.com>
1938
1939         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1940         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1941
1942 2019-01-23  Tom Tromey  <tom@tromey.com>
1943             Andrew Burgess  <andrew.burgess@embecosm.com>
1944             Pedro Alves  <palves@redhat.com>
1945
1946         * infrun.c (fetch_inferior_event): Use scope_exit.
1947         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1948         * top.c (execute_command): Use scope_exit.
1949         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1950         * utils.c (do_bpstat_clear_actions_cleanup)
1951         (make_bpstat_clear_actions_cleanup): Remove.
1952
1953 2019-01-23  Tom Tromey  <tom@tromey.com>
1954             Pedro Alves  <palves@redhat.com>
1955
1956         * infrun.c: Include "common/scope-exit.h"
1957         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1958         (wait_for_inferior): Use SCOPE_EXIT.
1959         (fetch_inferior_event): Use scope_exit.
1960
1961 2019-01-23  Tom Tromey  <tom@tromey.com>
1962             Pedro Alves  <palves@redhat.com>
1963
1964         * breakpoint.c (create_breakpoint): Remove cleanup.
1965
1966 2019-01-23  Tom Tromey  <tom@tromey.com>
1967             Andrew Burgess  <andrew.burgess@embecosm.com>
1968             Pedro Alves  <palves@redhat.com>
1969
1970 2019-01-23  Pedro Alves  <palves@redhat.com>
1971
1972         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1973
1974 2019-01-23  Pedro Alves  <palves@redhat.com>
1975             Andrew Burgess  <andrew.burgess@embecosm.com>
1976
1977         * gdbthread.h: Include "common/forward-scope-exit.h".
1978         (scoped_finish_thread_state): Redefine custom class in terms of
1979         forward_scope_exit.
1980
1981 2019-01-23  Pedro Alves  <palves@redhat.com>
1982             Andrew Burgess  <andrew.burgess@embecosm.com>
1983
1984         * common/forward-scope-exit.h: New file.
1985
1986 2019-01-23  Pedro Alves  <palves@redhat.com>
1987             Andrew Burgess  <andrew.burgess@embecosm.com>
1988             Tom Tromey  <tom@tromey.com>
1989
1990         * common/scope-exit.h: New file.
1991
1992 2019-01-23  Pedro Alves  <palves@redhat.com>
1993
1994         * common/preprocessor.h (ESC): Rename to ...
1995         (ESC_PARENS): ... this.
1996         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1997         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1998
1999 2019-01-23  Tom Tromey  <tom@tromey.com>
2000
2001         * language.h (class scoped_switch_to_sym_language_if_auto):
2002         Initialize m_lang in both cases.
2003
2004 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2005
2006         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2007         with XCNEW.
2008
2009 2019-01-22  Tom Tromey  <tom@tromey.com>
2010
2011         * corelow.c: Do not include sys/file.h.
2012
2013 2019-01-22  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-wingeneral.h: Include gdb_curses.h.
2016
2017 2019-01-22  Tom Tromey  <tom@tromey.com>
2018
2019         * source-cache.h (class source_cache) <get_source_lines,
2020         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2021
2022 2019-01-22  Tom Tromey  <tom@tromey.com>
2023
2024         * remote-fileio.h (struct remote_target): Declare.
2025
2026 2019-01-22  Tom Tromey  <tom@tromey.com>
2027
2028         * python/py-arch.c: Do not include py-ref.h.
2029         * python/py-bpevent.c: Do not include py-ref.h.
2030         * python/py-cmd.c: Do not include py-ref.h.
2031         * python/py-continueevent.c: Do not include py-ref.h.
2032         * python/py-event.h: Do not include py-ref.h.
2033         * python/py-evtregistry.c: Do not include py-ref.h.
2034         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2035         * python/py-frame.c: Do not include py-ref.h.
2036         * python/py-framefilter.c: Do not include py-ref.h.
2037         * python/py-function.c: Do not include py-ref.h.
2038         * python/py-infevents.c: Do not include py-ref.h.
2039         * python/py-linetable.c: Do not include py-ref.h.
2040         * python/py-objfile.c: Do not include py-ref.h.
2041         * python/py-param.c: Do not include py-ref.h.
2042         * python/py-prettyprint.c: Do not include py-ref.h.
2043         * python/py-progspace.c: Do not include py-ref.h.
2044         * python/py-symbol.c: Do not include py-ref.h.
2045         * python/py-symtab.c: Do not include py-ref.h.
2046         * python/py-type.c: Do not include py-ref.h.
2047         * python/py-unwind.c: Do not include py-ref.h.
2048         * python/py-utils.c: Do not include py-ref.h.
2049         * python/py-value.c: Do not include py-ref.h.
2050         * python/py-varobj.c: Do not include py-ref.h.
2051         * python/py-xmethods.c: Do not include py-ref.h.
2052         * python/python.c: Do not include py-ref.h.
2053         * varobj.c: Do not include py-ref.h.
2054
2055 2019-01-22  Tom Tromey  <tom@tromey.com>
2056
2057         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2058         keyword for bcache.
2059
2060 2019-01-22  Tom Tromey  <tom@tromey.com>
2061
2062         * compile/compile-cplus-types.c: Remove a comment by #include.
2063
2064 2019-01-22  Tom Tromey  <tom@tromey.com>
2065
2066         * compile/gcc-c-plugin.h: Include compile-internal.h.
2067
2068 2019-01-22  Tom Tromey  <tom@tromey.com>
2069
2070         * stabsread.c (EXTERN): Do not define.
2071         (symnum, next_symbol_text_func, processing_gcc_compilation)
2072         (within_function, global_sym_chain, global_stabs)
2073         (previous_stab_code, this_object_header_files)
2074         (n_this_object_header_files)
2075         (n_allocated_this_object_header_files): Define.
2076         * stabsread.h (EXTERN): Never define.  Use "extern".
2077
2078 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2079
2080         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2081         history_value.
2082
2083 2019-01-21  Tom Tromey  <tom@tromey.com>
2084
2085         * ui-out.c: Fix includes.
2086         * tui/tui-source.c: Fix includes.
2087         * target.c: Fix includes.
2088         * remote.c: Fix includes.
2089         * regcache.c: Fix includes.
2090         * python/py-block.c: Fix includes.
2091         * printcmd.c: Fix includes.
2092         * or1k-tdep.c: Fix includes.
2093         * mi/mi-main.c: Fix includes.
2094         * m32r-tdep.c: Fix includes.
2095         * csky-tdep.c: Fix includes.
2096         * compile/compile-cplus-types.c: Fix includes.
2097         * cli/cli-interp.c: Fix includes.
2098
2099 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2100
2101         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2102         for padding.
2103
2104 2019-01-16  Tom Tromey  <tom@tromey.com>
2105
2106         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2107         earlier.
2108         (struct objfile) <msymbols_range>: Move from top level.
2109         <msymbols>: New method.
2110         (class objfile_msymbols): Remove.
2111         * symtab.c (default_collect_symbol_completion_matches_break_on):
2112         Update.
2113         * symmisc.c (dump_msymbols): Update.
2114         * stabsread.c (scan_file_globals): Update.
2115         * objc-lang.c (info_selectors_command, info_classes_command)
2116         (find_methods): Update.
2117         * minsyms.c (find_solib_trampoline_target): Update.
2118         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2119         * coffread.c (coff_symfile_read): Update.
2120         * ada-lang.c (ada_lookup_simple_minsym)
2121         (ada_collect_symbol_completion_matches): Update.
2122
2123 2019-01-16  Tom Tromey  <tom@tromey.com>
2124
2125         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2126         type.  Remove no-argument constructor.
2127         <iterator::operator++>: Simplify.
2128         <begin>: Update.
2129         <end>: Use minimal_symbol_count.
2130
2131 2019-01-16  Tom Tromey  <tom@tromey.com>
2132
2133         * objfiles.h (struct objfile) <psymtabs>: New method.
2134         (class objfile_psymtabs): Remove.
2135         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2136         typedef.
2137         <range>: New method.
2138         (require_partial_symbols): Change return type.
2139         * psymtab.c (require_partial_symbols)
2140         (psym_expand_symtabs_matching): Update.
2141         * mdebugread.c (parse_partial_symbols): Update.
2142         * dbxread.c (dbx_end_psymtab): Update.
2143
2144 2019-01-15  Tom Tromey  <tom@tromey.com>
2145
2146         * symtab.c (lookup_objfile_from_block)
2147         (lookup_symbol_in_objfile_symtabs)
2148         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2149         (find_line_symtab, info_sources_command)
2150         (default_collect_symbol_completion_matches_break_on)
2151         (make_source_files_completion_list): Update.
2152         * symmisc.c (print_objfile_statistics, dump_objfile)
2153         (maintenance_print_symbols, maintenance_info_symtabs)
2154         (maintenance_check_symtabs, maintenance_info_line_tables):
2155         Update.
2156         * source.c (select_source_symtab)
2157         (forget_cached_source_info_for_objfile): Update.
2158         * objfiles.h (class objfile_compunits): Remove.
2159         (struct objfile) <compunits_range>: New typedef.
2160         (compunits): New method.
2161         * objfiles.c (objfile_relocate1): Update.
2162         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2163         * maint.c (count_symtabs_and_blocks): Update.
2164         * linespec.c (iterate_over_all_matching_symtabs): Update.
2165         * cp-support.c (add_symbol_overload_list_qualified): Update.
2166         * coffread.c (coff_symtab_read): Update.
2167         * ada-lang.c (add_nonlocal_symbols)
2168         (ada_collect_symbol_completion_matches)
2169         (ada_add_global_exceptions): Update.
2170
2171 2019-01-15  Tom Tromey  <tom@tromey.com>
2172
2173         * progspace.h (program_space) <objfiles_safe_range>: New
2174         typedef.
2175         <objfiles_safe>: New method.
2176         * objfiles.h (class all_objfiles_safe): Remove.
2177         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2178         * jit.c (jit_inferior_exit_hook): Update.
2179
2180 2019-01-17  Tom Tromey  <tom@tromey.com>
2181
2182         * progspace.h (program_space) <objfiles_range>: New typedef.
2183         <objfiles>: New method.
2184         <objfiles_head>: Rename from objfiles.
2185         (object_files): Update.
2186         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2187         * guile/scm-pretty-print.c
2188         (ppscm_find_pretty_printer_from_objfiles): Update.
2189         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2190         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2191         Update.
2192         * python/py-progspace.c (pspy_get_objfiles): Update.
2193         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2194         Update.
2195         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2196         (objfpy_lookup_objfile_by_build_id): Update.
2197         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2198         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2199         Update.
2200         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2201         (expand_symtab_containing_pc, lookup_objfile_from_block)
2202         (lookup_static_symbol, basic_lookup_transparent_type)
2203         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2204         (find_line_symtab, info_sources_command)
2205         (default_collect_symbol_completion_matches_break_on)
2206         (make_source_files_completion_list, find_main_name): Update.
2207         * symmisc.c (print_symbol_bcache_statistics)
2208         (print_objfile_statistics, maintenance_print_symbols)
2209         (maintenance_print_msymbols, maintenance_print_objfiles)
2210         (maintenance_info_symtabs, maintenance_check_symtabs)
2211         (maintenance_expand_symtabs, maintenance_info_line_tables):
2212         Update.
2213         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2214         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2215         (map_overlay_command, unmap_overlay_command)
2216         (simple_overlay_update, expand_symtabs_matching)
2217         (map_symbol_filenames): Update.
2218         * symfile-debug.c (set_debug_symfile): Update.
2219         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2220         Update.
2221         * source.c (select_source_symtab, forget_cached_source_info):
2222         Update.
2223         * solib.c (solib_read_symbols): Update.
2224         * solib-spu.c (append_ocl_sos): Update.
2225         * psymtab.c (maintenance_print_psymbols)
2226         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2227         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2228         * printcmd.c (info_symbol_command): Update.
2229         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2230         Update.
2231         * objfiles.h (class all_objfiles): Remove.
2232         * objfiles.c (have_partial_symbols, have_full_symbols)
2233         (have_minimal_symbols, qsort_cmp, update_section_map)
2234         (shared_objfile_contains_address_p)
2235         (default_iterate_over_objfiles_in_search_order): Update.
2236         * objc-lang.c (info_selectors_command, info_classes_command)
2237         (find_methods): Update.
2238         * minsyms.c (find_solib_trampoline_target): Update.
2239         * maint.c (maintenance_info_sections)
2240         (maintenance_translate_address, count_symtabs_and_blocks):
2241         Update.
2242         * main.c (captured_main_1): Update.
2243         * linux-thread-db.c (try_thread_db_load_from_pdir)
2244         (has_libpthread): Update.
2245         * linespec.c (iterate_over_all_matching_symtabs)
2246         (search_minsyms_for_name): Update.
2247         * jit.c (jit_find_objf_with_entry_addr): Update.
2248         * hppa-tdep.c (find_unwind_entry)
2249         (hppa_lookup_stub_minimal_symbol): Update.
2250         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2251         Update.
2252         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2253         (elf_gnu_ifunc_resolve_by_got): Update.
2254         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2255         * dwarf-index-write.c (save_gdb_index_command): Update.
2256         * cp-support.c (add_symbol_overload_list_qualified): Update.
2257         * breakpoint.c (create_overlay_event_breakpoint)
2258         (create_longjmp_master_breakpoint)
2259         (create_std_terminate_master_breakpoint)
2260         (create_exception_master_breakpoint): Update.
2261         * blockframe.c (find_pc_partial_function): Update.
2262         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2263         (ada_collect_symbol_completion_matches)
2264         (ada_add_global_exceptions): Update.
2265
2266 2019-01-17  Tom Tromey  <tom@tromey.com>
2267
2268         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2269         declare VEC.
2270         (solib_target_parse_libraries): Change return type.
2271         (library_list_start_segment, library_list_start_section)
2272         (library_list_end_library, library_list_start_library); Update.
2273         (solib_target_free_library_list): Remove.
2274         (solib_target_parse_libraries): Remove cleanup.  Change return
2275         type.
2276         (solib_target_current_sos): Update.
2277
2278 2019-01-17  Tom Tromey  <tromey@bapiya>
2279
2280         * valprint.c: Replace "the the" with "the".
2281         * symtab.c: Replace "the the" with "the".
2282         * solib.c: Replace "the the" with "the".
2283         * solib-dsbt.c: Replace "the the" with "the".
2284         * linespec.c: Replace "the the" with "the".
2285         * dwarf2loc.h: Replace "the the" with "the".
2286         * amd64-windows-tdep.c: Replace "the the" with "the".
2287         * aarch64-tdep.c: Replace "the the" with "the".
2288
2289 2019-01-16  Keith Seitz  <keiths@redhat.com>
2290
2291         PR gdb/23773
2292         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2293         <builder>: Rename to ..
2294         <m_builder>: ... this and make private.
2295         (dwarf2_cu::get_builder): New method.  Change all users of
2296         `builder' to use this method.
2297         (dwarf2_start_symtab): Move to ...
2298         (dwarf2_cu::start_symtab): ... here.  Update all callers
2299         (setup_type_unit_groups): Move to ...
2300         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2301         callers.
2302         (dwarf2_cu::reset_builder): New method.
2303         (process_full_compunit, process_full_type_unit): Use
2304         dwarf2_cu::reset_builder.
2305         (follow_die_offset): Record the ancestor CU if it is different
2306         from the followed DIE's CU.
2307         (follow_die_sig_1): Likewise.
2308
2309 2019-01-15  Tom Tromey  <tom@tromey.com>
2310
2311         * remote.c (class remote_state) <buf>: Now a char_vector.
2312         <buf_size>: Remove.
2313         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2314         parameter.
2315         (remote_target::getpkt_or_notif_sane_1)
2316         (remote_target::getpkt_sane)
2317         (remote_target::getpkt_or_notif_sane): Likewise.
2318         (class remote_target) <putpkt>: New overload.
2319         (remote_target::read_frame): Change type of "buf_p".  Remove
2320         sizeof_p parameter.
2321         (packet_ok): New overload.
2322         (packet_check_result): New overload.
2323         Update all uses.
2324
2325 2019-01-14  Tom Tromey  <tom@tromey.com>
2326
2327         * remote-notif.c (handle_notification, remote_notif_ack)
2328         (remote_notif_parse): Make "buf" const.
2329         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2330         const.
2331         (remote_notif_parse, remote_notif_ack, handle_notification):
2332         Likewise.
2333         * remote.c (remote_notif_stop_parse): Make "buf" const.
2334         (remote_target::remote_parse_stop_reply): Make "buf" const.
2335         (remote_notif_stop_ack): Make "buf" const.
2336
2337 2019-01-14  Tom Tromey  <tom@tromey.com>
2338
2339         * remote.c (remote_console_output): Make parameter const.
2340
2341 2019-01-14  Tom Tromey  <tom@tromey.com>
2342
2343         * target-debug.h (target_debug_print_signals): Constify.
2344         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2345         * procfs.c (procfs_target::pass_signals): Update.
2346         * linux-nat.c (linux_nat_target::pass_signals): Update.
2347         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2348         * target-delegates.c: Rebuild.
2349         * remote.c (remote_target::program_signals): Update.
2350         (remote_target::pass_signals): Update.
2351         * target.c (target_pass_signals): Constify argument.
2352         (target_program_signals): Likewise.
2353         * target.h (struct target_ops) <pass_signals, program_signals>:
2354         Constify argument.
2355         (target_pass_signals, target_program_signals): Constify argument.
2356
2357 2019-01-14  Tom Tromey  <tom@tromey.com>
2358
2359         PR tui/28819:
2360         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2361
2362 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2363
2364         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2365         field.
2366         * rs6000-tdep.c: Include reggroups.h.
2367         (IS_V_ALIAS_PSEUDOREG): Define.
2368         (rs6000_register_name): Return names for the "vX" aliases.
2369         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2370         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2371         aliases.  Call default_register_reggroup_p for all other
2372         pseudo-registers.
2373         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2374         New functions.
2375         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2376         Handle "vX" aliases.
2377         (v_alias_pseudo_register_collect): New function.
2378         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2379         (rs6000_gdbarch_init): Initialize "vX" aliases as
2380         pseudo-registers.  Restore registration of
2381         rs6000_pseudo_register_reggroup_p with
2382         set_tdesc_pseudo_register_reggroup_p.
2383
2384 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2385
2386         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2387         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2388         set_gdbarch_num_pseudo_regs.
2389
2390 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2391
2392         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2393         Remove arg prefixname, add do_set and do_show.
2394         Add member functions set_list and show_list.
2395         * cli/cli-style.c (class cli_style_option): Update accordingly.
2396         (style_set_list): Move to file scope.
2397         (style_show_list): Likewise.
2398         (set_style): Call help_list.
2399         (show_style): Call cmd_show_list.
2400         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2401         Update to use the new macro.
2402
2403 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2404
2405         * ada-lang.c (_initialize_ada_language): Expand the help text
2406         for the "catch exception" command.
2407
2408 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2409
2410         * symtab.c (matching_obj_sections): Initialize obj,
2411         declare it closer to its usage.
2412
2413 2019-01-10  Tom Tromey  <tom@tromey.com>
2414
2415         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2416         (basic_inf_threads_range): Remove.
2417         (inf_threads_range, inf_non_exited_threads_range)
2418         (safe_inf_threads_range): Use next_adapter.
2419
2420 2019-01-10  Keith Seitz  <keiths@redhat.com>
2421
2422         PR gdb/23712
2423         PR symtab/23010
2424         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2425         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2426
2427 2019-01-10  Keith Seitz  <keiths@redhat.com>
2428
2429         PR gdb/23712
2430         PR symtab/23010
2431         * dictionary.c (pending_to_vector): Remove.
2432         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2433         Remove _1 suffix, replacing functions of the same name.  Update
2434         all callers.
2435         (dict_create_hashed, dict_create_hashed_expandable)
2436         (dict_create_linear, dict_create_linear_expandable, dict_free)
2437         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2438         Make functions static.
2439
2440 2019-01-10  Keith Seitz  <keiths@redhat.com>
2441
2442         PR gdb/23712
2443         PR symtab/23010
2444         * dictionary.h (struct dictionary): Replace declaration with
2445         multidictionary.
2446         (dict_create_hashed, dict_create_hashed_expandable)
2447         (dict_create_linear, dict_create_linear_expandable)
2448         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2449         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2450         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2451         taking multidictionary argument.
2452         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2453         * block.h (struct block) <dict>: Change to multidictionary
2454         and rename `multidict'.
2455         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2456         symmisc.c: Update all dictionary references to multidictionary.
2457
2458 2019-01-10  Keith Seitz  <keiths@redhat.com>
2459
2460         PR gdb/23712
2461         PR symtab/23010
2462         * dictionary.c: Include unordered_map.
2463         (pending_to_vector): New function.
2464         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2465         Rewrite the non-"_1" functions to take vector instead
2466         of linked list.
2467         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2468         "new" _1 versions of the same name.
2469         (multidictionary): Define.
2470         (std::hash<enum language): New definition.
2471         (collate_pending_symbols_by_language, mdict_create_hashed)
2472         (mdict_create_hashed_expandable, mdict_create_linear)
2473         (mdict_create_linear_expandable, mdict_free)
2474         (find_language_dictionary, create_new_language_dictionary)
2475         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2476         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2477         (mdict_size, mdict_empty): New functions.
2478         * dictionary.h (mdict_iterator): Define.
2479
2480 2019-01-10  Pedro Alves  <palves@redhat.com>
2481
2482         * breakpoint.c (read_uploaded_action)
2483         (create_tracepoint_from_upload): Adjust to use
2484         gdb::unique_xmalloc_ptr.
2485         * ctf.c (ctf_write_uploaded_tp):
2486         (SET_ARRAY_FIELD): Use emplace_back.
2487         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2488         * tracefile-tfile.c (tfile_write_uploaded_tp):
2489         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2490         gdb::unique_xmalloc_ptr.
2491         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2492         at_string, cond_string, cmd_strings>: Replace char pointers
2493         with gdb::unique_xmalloc_ptr.
2494
2495 2019-01-10  Pedro Alves  <palves@redhat.com>
2496
2497         * solib-target.c (library_list_start_library): Don't xstrdup name.
2498
2499 2019-01-10  Pedro Alves  <palves@redhat.com>
2500
2501         * mdebugread.c (parse_partial_symbols): Use
2502         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2503
2504 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         * linux-fork.c (scoped_switch_fork_info)
2507         <~scoped_switch_fork_info>: Fix incorrect variable name.
2508
2509 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * linux-fork.c (scoped_switch_fork_info)
2512         <scoped_switch_fork_info>: Make explicit.
2513         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2514
2515 2019-01-10  Tom Tromey  <tom@tromey.com>
2516
2517         * objfiles.h (objfile::reset_psymtabs): Update.
2518         * objfiles.c (objfile::objfile): Update.
2519         * psymtab.h (psymtab_storage::obstack): Update.
2520         (psymtab_storage::m_obstack): Use gdb::optional.
2521         (class psymtab_storage): Update comment.  Remove objfile
2522         parameter.
2523         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2524
2525 2019-01-10  Tom Tromey  <tom@tromey.com>
2526
2527         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2528         <free_psymtabs>: Now private.
2529         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2530         (allocate_psymtab): Use new method.
2531
2532 2019-01-10  Tom Tromey  <tom@tromey.com>
2533
2534         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2535         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2536         * mdebugread.c (parse_partial_symbols): Use
2537         allocate_dependencies.
2538         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2539         allocate_dependencies.
2540         (process_psymtab_comp_unit_reader)
2541         (build_type_psymtab_dependencies): Likewise.
2542         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2543
2544 2019-01-10  Tom Tromey  <tom@tromey.com>
2545
2546         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2547         PSYMBOL_SET_LANGUAGE.
2548         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2549
2550 2019-01-10  Tom Tromey  <tom@tromey.com>
2551
2552         * psymtab.h (psymtab_storage::obstack): New method.
2553         <m_obstack>: Rename from obstack; now private.
2554         * psymtab.c (psymtab_storage): Update.
2555         * dwarf2read.c (create_addrmap_from_index)
2556         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2557         Update.
2558
2559 2019-01-10  Tom Tromey  <tom@tromey.com>
2560
2561         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2562         * objfiles.h (objfile::reset_psymtabs): New method.
2563
2564 2019-01-10  Tom Tromey  <tom@tromey.com>
2565
2566         * symmisc.c (print_symbol_bcache_statistics): Update.
2567         (print_objfile_statistics): Update.
2568         * symfile.c (reread_symbols): Update.
2569         * psymtab.h (class psymtab_storage): New.
2570         * psymtab.c (psymtab_storage): New constructor.
2571         (~psymtab_storage): New destructor.
2572         (require_partial_symbols): Update.
2573         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2574         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2575         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2576         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2577         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2578         (start_psymtab_common, end_psymtab_common)
2579         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2580         (allocate_psymtab): Update.
2581         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2582         Update.
2583         (dump_psymtab_addrmap, maintenance_print_psymbols)
2584         (maintenance_check_psymtabs): Update.
2585         (class objfile_psymtabs): Move to objfiles.h.
2586         * psympriv.h (discard_psymtab): Now inline.
2587         (psymtab_discarder::psymtab_discarder): Update.
2588         (psymtab_discarder::~psymtab_discarder): Update.
2589         (ALL_OBJFILE_PSYMTABS): Rewrite.
2590         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2591         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2592         Remove fields.
2593         <partial_symtabs>: New field.
2594         (class objfile_psymtabs): Move from psymtab.h.  Update.
2595         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2596         psymbol_cache.
2597         (objfile::~objfile): Don't destroy psymbol_cache.
2598         * mdebugread.c (parse_partial_symbols): Update.
2599         * dwarf2read.c (create_addrmap_from_index)
2600         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2601         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2602         (add_partial_subprogram, dwarf2_ranges_read): Update.
2603         * dwarf-index-write.c (write_address_map)
2604         (write_one_signatured_type, recursively_write_psymbols)
2605         (class debug_names, class debug_names, write_psymtabs_to_index):
2606         Update.
2607
2608 2019-01-10  Tom Tromey  <tom@tromey.com>
2609
2610         * symtab.h (SYMBOL_SET_NAMES): Update.
2611         (symbol_set_names): Update.
2612         (MSYMBOL_SET_NAMES): Update.
2613         * symtab.c (symbol_set_names): Change argument to be an
2614         objfile_per_bfd_storage.
2615         * psymtab.c (add_psymbol_to_bcache): Update.
2616         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2617
2618 2019-01-10  Tom Tromey  <tom@tromey.com>
2619
2620         * symtab.c (create_demangled_names_hash): Change argument to be an
2621         objfile_per_bfd_storage.
2622         (symbol_set_names): Update.
2623
2624 2019-01-10  Tom Tromey  <tom@tromey.com>
2625
2626         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2627         init_psymbol_list.
2628         * psymtab.c (init_psymbol_list): Do nothing if already called.
2629         * psympriv.h (init_psymbol_list): Add comment.
2630         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2631         init_psymbol_list.
2632         * dbxread.c (dbx_symfile_read): Unconditionally call
2633         init_psymbol_list.
2634
2635 2019-01-10  Tom Tromey  <tom@tromey.com>
2636
2637         * xcoffread.c (scan_xcoff_symtab): Update.
2638         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2639         "where".
2640         * mdebugread.c (parse_partial_symbols)
2641         (handle_psymbol_enumerators): Update.
2642         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2643         * dbxread.c (read_dbx_symtab): Update.
2644         * psympriv.h (psymbol_placement): New enum.
2645         (add_psymbol_to_list): Update.
2646
2647 2019-01-10  Tom Tromey  <tom@tromey.com>
2648
2649         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2650         static_psymbols parameters.
2651         (scan_xcoff_symtab): Update.
2652         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2653         static_psymbols parameters.
2654         * psympriv.h (start_psymtab_common): Update.
2655         * mdebugread.c (parse_partial_symbols): Update.
2656         * dwarf2read.c (create_partial_symtab): Update.
2657         * dbxread.c (read_dbx_symtab): Update.
2658         (start_psymtab): Remove global_psymbols and static_psymbols
2659         parameters.
2660
2661 2019-01-10  Tom Tromey  <tom@tromey.com>
2662
2663         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2664         * psymtab.c (allocate_psymtab): Add comment.
2665         * psympriv.h (allocate_psymtab): Add comment.
2666         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2667         initializations.
2668         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2669
2670 2019-01-10  Tom Tromey  <tom@tromey.com>
2671
2672         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2673         Don't declare.
2674         * mipsread.c: Include mdebugread.h.
2675         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2676         Declare.
2677         * elfread.c: Include mdebugread.h.
2678
2679 2019-01-09  Tom Tromey  <tom@tromey.com>
2680
2681         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2682         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2683         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2684         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2685         (psym_lookup_symbol, psym_find_last_source_symtab)
2686         (psym_forget_cached_source_info, psym_print_stats)
2687         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2688         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2689         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2690         (psym_find_compunit_symtab_by_address)
2691         (maintenance_print_psymbols, maintenance_info_psymtabs)
2692         (maintenance_check_psymtabs): Use ranged for.
2693         * psymtab.h (class objfile_psymtabs): New.
2694         (require_partial_symbols): Return objfile_psymtabs.
2695         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2696
2697 2019-01-09  Tom Tromey  <tom@tromey.com>
2698
2699         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2700         (find_pc_mapped_section, list_overlays_command)
2701         (map_overlay_command, unmap_overlay_command)
2702         (simple_overlay_update): Use all_objfiles.
2703         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2704         * printcmd.c (info_symbol_command): Use all_objfiles.
2705         * objfiles.h (ALL_OBJSECTIONS): Remove.
2706         * maint.c (maintenance_translate_address): Use all_objfiles.
2707         * gcore.c (gcore_create_callback): Use all_objfiles.
2708         (objfile_find_memory_regions): Likewise.
2709
2710 2019-01-09  Tom Tromey  <tom@tromey.com>
2711
2712         * symtab.c (find_line_symtab, info_sources_command)
2713         (make_source_files_completion_list): Use objfile_compunits.
2714         * source.c (select_source_symtab): Use objfile_compunits.
2715         * objfiles.h (struct objfile): Update comment.
2716         (ALL_OBJFILES): Remove.
2717         (ALL_FILETABS): Remove.
2718         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2719         objfile_compunits.
2720
2721 2019-01-09  Tom Tromey  <tom@tromey.com>
2722
2723         * symmisc.c (print_objfile_statistics, dump_objfile)
2724         (maintenance_print_symbols): Use compunit_filetabs.
2725         * source.c (forget_cached_source_info_for_objfile): Use
2726         compunit_filetabs.
2727         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2728         (ALL_FILETABS): Use compunit_filetabs.
2729         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2730         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2731
2732 2019-01-09  Tom Tromey  <tom@tromey.com>
2733
2734         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2735         (compunit_filetabs): New.
2736         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2737         compunit_filetabs.
2738         (info_sources_command, make_source_files_completion_list): Remove
2739         declaration.
2740         * symmisc.c (print_objfile_statistics, dump_objfile)
2741         (maintenance_print_symbols): Remove declaration.
2742         (maintenance_info_symtabs): Use compunit_filetabs.
2743         (maintenance_info_line_tables): Likewise.
2744         * source.c (select_source_symtab): Change local variable name.
2745         (forget_cached_source_info_for_objfile): Remove declaration.
2746         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2747         * objfiles.c (objfile_relocate1): Remove declaration.
2748         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2749         declaration.
2750         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2751         * coffread.c (coff_symtab_read): Remove declaration.
2752         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2753         compunit_filetabs.
2754
2755 2019-01-09  Tom Tromey  <tom@tromey.com>
2756
2757         * symtab.c (lookup_objfile_from_block)
2758         (find_pc_sect_compunit_symtab, search_symbols)
2759         (default_collect_symbol_completion_matches_break_on): Use
2760         objfile_compunits.
2761         * objfiles.h (ALL_COMPUNITS): Remove.
2762         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2763         * cp-support.c (add_symbol_overload_list_qualified): Use
2764         objfile_compunits.
2765         * ada-lang.c (ada_collect_symbol_completion_matches)
2766         (ada_add_global_exceptions): Use objfile_compunits.
2767
2768 2019-01-09  Tom Tromey  <tom@tromey.com>
2769
2770         * source.c (select_source_symtab)
2771         (forget_cached_source_info_for_objfile): Remove declaration.
2772         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2773         declaration.
2774         * maint.c (count_symtabs_and_blocks): Remove declaration.
2775         * cp-support.c (add_symbol_overload_list_qualified): Remove
2776         declaration.
2777         * coffread.c (coff_symtab_read): Remove declaration.
2778         * symtab.c (lookup_symbol_in_objfile_symtabs)
2779         (basic_lookup_transparent_type_1): Use objfile_compunits.
2780         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2781         (info_sources_command, search_symbols)
2782         (default_collect_symbol_completion_matches_break_on)
2783         (make_source_files_completion_list): Remove declaration.
2784         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2785         (ada_collect_symbol_completion_matches)
2786         (ada_add_global_exceptions): Remove declaration.
2787         * linespec.c (iterate_over_all_matching_symtabs): Use
2788         objfile_compunits.
2789         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2790         (class objfile_compunits): New.
2791         (ALL_COMPUNITS): Use objfile_compunits.
2792         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2793         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2794         objfile_compunits.
2795         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2796
2797 2019-01-09  Tom Tromey  <tom@tromey.com>
2798
2799         * symtab.c (search_symbols)
2800         (default_collect_symbol_completion_matches_break_on): Use
2801         objfile_msymbols.
2802         * ada-lang.c (ada_lookup_simple_minsym)
2803         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2804         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2805         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2806         objfile_msymbols.
2807         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2808         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2809         * objc-lang.c (find_methods): Use objfile_msymbols.
2810         (info_selectors_command, info_classes_command): Likewise.
2811         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2812         * objfiles.h (class objfile_msymbols): New.
2813         (ALL_OBJFILE_MSYMBOLS): Remove.
2814         (ALL_MSYMBOLS): Remove.
2815
2816 2019-01-09  Tom Tromey  <tom@tromey.com>
2817
2818         * common/next-iterator.h (next_adapter): Add Iterator template
2819         parameter.
2820         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2821         (class all_objfiles_safe): New.
2822         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2823         * objfiles.c (put_objfile_before): Update comment.
2824         (add_separate_debug_objfile): Likewise.
2825         (free_all_objfiles): Use all_objfiles_safe.
2826         (objfile_purge_solibs): Likewise.
2827
2828 2019-01-09  Tom Tromey  <tom@tromey.com>
2829
2830         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2831         (expand_symtab_containing_pc, lookup_static_symbol)
2832         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2833         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2834         all_objfiles.
2835         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2836         * breakpoint.c (create_overlay_event_breakpoint)
2837         (create_longjmp_master_breakpoint)
2838         (create_std_terminate_master_breakpoint)
2839         (create_exception_master_breakpoint): Use all_objfiles.
2840         * linux-thread-db.c (try_thread_db_load_from_pdir)
2841         (has_libpthread): Use all_objfiles.
2842         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2843         * linespec.c (iterate_over_all_matching_symtabs)
2844         (search_minsyms_for_name): Use all_objfiles.
2845         * maint.c (maintenance_info_sections): Use all_objfiles.
2846         * main.c (captured_main_1): Use all_objfiles.
2847         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2848         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2849         * guile/scm-pretty-print.c
2850         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2851         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2852         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2853         (maintenance_print_msymbols): Use all_objfiles.
2854         * source.c (select_source_symtab): Use all_objfiles.
2855         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2856         * symfile.c (remove_symbol_file_command)
2857         (expand_symtabs_matching, map_symbol_filenames): Use
2858         all_objfiles.
2859         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2860         all_objfiles.
2861         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2862         * objc-lang.c (find_methods): Use all_objfiles.
2863         * objfiles.c (have_partial_symbols, have_full_symbols)
2864         (have_minimal_symbols, qsort_cmp)
2865         (default_iterate_over_objfiles_in_search_order): Use
2866         all_objfiles.
2867         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2868         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2869         (maintenance_check_psymtabs): Use all_objfiles.
2870         (ALL_PSYMTABS): Remove.
2871         * compile/compile-object-run.c (do_module_cleanup): Use
2872         all_objfiles.
2873         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2874         * cp-support.c (add_symbol_overload_list_qualified): Use
2875         all_objfiles.
2876         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2877         Use all_objfiles.
2878         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2879         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2880         all_objfiles.
2881         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2882         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2883         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2884         Uses all_objfiles.
2885         * solib.c (solib_read_symbols): Use all_objfiles
2886
2887 2019-01-09  Tom Tromey  <tom@tromey.com>
2888
2889         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2890         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2891         all_objfiles.
2892         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2893         * symmisc.c (print_symbol_bcache_statistics)
2894         (print_objfile_statistics, maintenance_print_objfiles)
2895         (maintenance_info_symtabs, maintenance_check_symtabs)
2896         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2897         all_objfiles.
2898         * source.c (forget_cached_source_info): Use all_objfiles.
2899         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2900         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2901         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2902         * objfiles.c (update_section_map): Use all_objfiles.
2903         (shared_objfile_contains_address_p): Likewise.
2904         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2905         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2906
2907 2019-01-09  Tom Tromey  <tom@tromey.com>
2908
2909         * common/next-iterator.h: New file.
2910         * objfiles.h (class all_objfiles): New.
2911         (struct objfile_iterator): New.
2912
2913 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2914
2915         * NEWS: Move the description of the changed "frame", "select-frame",
2916          and "info frame" commands to the Changed commands section.
2917
2918 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2919
2920         * gdbtypes.c (check_stub_method_group): Remove handling of old
2921         mangling schemes.
2922         * linespec.c (find_methods): Likewise.
2923         * stabsread.c (read_member_functions): Likewise.
2924         * valops.c (search_struct_method): Likewise.
2925         (value_struct_elt_for_reference): Likewise.
2926         * NEWS: Mention this change.
2927
2928 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2929
2930         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2931         print_source_lines.
2932         * source.c (print_source_lines_base): Update line number check.
2933         (print_source_lines): New function.
2934         (source_lines_range::source_lines_range): New function.
2935         * source.h (class source_lines_range): New class.
2936         (print_source_lines): New declaration.
2937
2938 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2939
2940         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2941
2942 2019-01-08  Tom Tromey  <tom@tromey.com>
2943             Simon Marchi  <simon.marchi@ericsson.com>
2944
2945         PR gdb/24060
2946         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2947         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2948         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2949         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2950         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2951         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2952
2953 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2954
2955         * source.c (select_source_symtab): Move header comment to
2956         declaration in source.h.
2957         (forget_cached_source_info_for_objfile): Likewise.
2958         (forget_cached_source_info): Likewise.
2959         (identify_source_line): Likewise.
2960         * source.h (identify_source_line): Move declaration from symtab.h
2961         and add comment from source.c
2962         (print_source_lines): Likewise.
2963         (forget_cached_source_info_for_objfile): Likewise.
2964         (forget_cached_source_info): Likewise.
2965         (select_source_symtab): Likewise.
2966         (enum print_source_lines_flag): Move definition from symtab.h.
2967         * symtab.h (identify_source_line): Move declaration to source.h.
2968         (print_source_lines): Likewise.
2969         (forget_cached_source_info_for_objfile): Likewise.
2970         (forget_cached_source_info): Likewise.
2971         (select_source_symtab): Likewise.
2972         (enum print_source_lines_flag): Move definition to source.h.
2973         * tui/tui-hooks.c: Add 'source.h' include.
2974
2975 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2976
2977         * source.c (print_source_lines_base): Handle requests to print
2978         reverse line number sequences, and guard against empty lines
2979         string.
2980
2981 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2982
2983         * source.c (print_source_lines_base): Fix skip of '\r' if next
2984         character is '\n'.
2985
2986 2019-01-06  Tom Tromey  <tom@tromey.com>
2987
2988         * c-exp.y (struct c_parse_state) <macro_original_text,
2989         expansion_obstack>: New member.
2990         (macro_original_text, expansion_obstack): Remove globals.
2991         (scan_macro_expansion, scanning_macro_expansion)
2992         (finished_macro_expansion): Update.
2993         (scan_macro_cleanup): Remove.
2994         (yylex, c_parse): Update.
2995
2996 2019-01-06  Tom Tromey  <tom@tromey.com>
2997
2998         * c-exp.y (struct c_parse_state) <strings>: New member.
2999         (operator_stoken): Update.
3000
3001 2019-01-06  Tom Tromey  <tom@tromey.com>
3002
3003         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3004         (union type_stack_elt) <typelist_val>: Now a pointer to
3005         std::vector.
3006         (type_stack_cleanup): Don't declare.
3007         (push_typelist): Update.
3008         * parse.c (pop_typelist): Return a std::vector.
3009         (push_typelist): Take a std::vector.
3010         (follow_types): Update.  Do not free args.
3011         (type_stack_cleanup): Remove.
3012         * c-exp.y (struct c_parse_state): New.
3013         (cpstate): New global.
3014         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3015         (nonempty_typelist): Update.
3016         (func_mod): Create a new vector.
3017         (c_parse): Create a c_parse_state.
3018         (check_parameter_typelist): Do not delete params.
3019         (function_method): Update.  Do not delete type_list.
3020
3021 2019-01-06  Tom Tromey  <tom@tromey.com>
3022
3023         PR gdb/28155:
3024         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3025         check_typedef.
3026         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3027         (print_return_value): Likewise.
3028
3029 2019-01-05  Tom Tromey  <tom@tromey.com>
3030
3031         * contrib/cleanup_check.py: Remove.
3032         * contrib/gcc-with-excheck: Remove.
3033         * contrib/exsummary.py: Remove.
3034         * contrib/excheck.py: Remove.
3035
3036 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3037
3038         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3039         NULL. Initialize tpprev to NULL instead of assigning it
3040         to NULL on the next statement.
3041         * windows-nat.c (windows_delete_thread): Remove check for
3042         main_thread_id before printing thread exit notifications.
3043         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3044         Remove thread ID check against main_thread_id.
3045         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3046         windows_delete_thread.
3047         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3048
3049 2019-01-04  Tom Tromey  <tom@tromey.com>
3050
3051         * compile/compile.c (_initialize_compile): Use upper case for
3052         metasyntactic variables.
3053         * symmisc.c (_initialize_symmisc): Use upper case for
3054         metasyntactic variables.
3055         * psymtab.c (_initialize_psymtab): Use upper case for
3056         metasyntactic variables.
3057         * demangle.c (demangle_command): Use upper case for metasyntactic
3058         variables.
3059         (_initialize_demangler): Likewise.
3060         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3061         variables.
3062
3063 2019-01-03  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3066
3067 2019-01-03  Tom Tromey  <tom@tromey.com>
3068
3069         * python/py-symtab.c (salpy_str): Update.
3070         (struct salpy_sal_object) <symtab>: Now a PyObject.
3071         (salpy_dealloc): Update.
3072         (del_objfile_sal): Use gdbpy_ref.
3073
3074 2019-01-03  Tom Tromey  <tom@tromey.com>
3075
3076         * python/py-type.c (convert_field): Use new_reference.  Return
3077         gdbpy_ref.
3078         (make_fielditem): Return gdbpy_ref.
3079         (typy_fields): Update.
3080         (typy_getitem): Update.
3081         (field_name): Return gdbpy_ref.  Use new_reference.
3082         (typy_iterator_iternext): Update.
3083
3084 2019-01-03  Tom Tromey  <tom@tromey.com>
3085
3086         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3087
3088 2019-01-03  Tom Tromey  <tom@tromey.com>
3089
3090         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3091         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3092         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3093         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3094         (pspy_set_type_printers): Likewise.
3095         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3096         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3097         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3098         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3099         (objfpy_set_type_printers): Likewise.
3100
3101 2019-01-03  Tom Tromey  <tom@tromey.com>
3102
3103         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3104         (gdbpy_print_stack): Use gdbpy_err_fetch.
3105         * python/python-internal.h (class gdbpy_err_fetch): New class.
3106         (class gdbpy_enter) <m_error_type, m_error_value,
3107         m_error_traceback>: Remove.
3108         <m_error>: New member.
3109         (gdbpy_exception_to_string): Don't declare.
3110         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3111         * python/py-value.c (convert_value_from_python): Use
3112         gdbpy_err_fetch.
3113         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3114         gdbpy_exception_to_string.
3115         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3116         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3117         gdbpy_err_fetch.
3118
3119 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3120
3121         * linux-nat.c (delete_lwp_cleanup): Delete.
3122         (struct lwp_deleter): New struct.
3123         (lwp_info_up): New typedef.
3124         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3125         lwp_info_up.
3126
3127 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3128
3129         * linux-fork.c (class scoped_switch_fork_info): New class.
3130         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3131
3132 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3133
3134         * valops.c (find_overload_match): Remove use of null_cleanup, and
3135         calls to do_cleanups.
3136
3137 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3138
3139         * compile/compile-cplus-types.c
3140         (compile_cplus_instance::decl_name): Handle changes to
3141         cp_func_name.
3142         * cp-support.c (cp_func_name): Update header comment, update
3143         return type.
3144         * cp-support.h (cp_func_name): Update return type in declaration.
3145         * valops.c (find_overload_match): Move temp_func local to top
3146         level of function and change its type.  Use temp_func to hold and
3147         delete temporary string obtained from cp_func_name.
3148
3149 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3150
3151         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3152         gdb::char_vector, remove cleanup, and update uses of `msg`.
3153
3154 2019-01-03  Jim Wilson  <jimw@sifive.com>
3155
3156         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3157
3158 2019-01-02  Tom Tromey  <tom@tromey.com>
3159
3160         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3161         (tdesc_parse_xml): Remove cleanups.
3162         * target-descriptions.h (make_cleanup_free_target_description):
3163         Don't declare.
3164         (target_desc_deleter): New struct.
3165         (target_desc_up): New typedef.
3166         * target-descriptions.c (target_desc_deleter::operator()): Rename
3167         from free_target_description.
3168         (make_cleanup_free_target_description): Remove.
3169
3170 2019-01-02  Tom Tromey  <tom@tromey.com>
3171
3172         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3173         constructor, destructor.
3174         (linespec_parser): Remove typedef.
3175         (~linespec_parser): Rename from linespec_parser_delete.
3176         (linespec_lex_to_end, linespec_complete_label)
3177         (linespec_complete): Update.
3178         (decode_line_full): Remove cleanups.
3179         (decode_line_1): Update.
3180
3181 2019-01-02  Tom Tromey  <tom@tromey.com>
3182
3183         * python/python-internal.h (inferior_to_inferior_object): Change
3184         return type.
3185         * python/py-exitedevent.c (create_exited_event_object): Update.
3186         * python/py-inferior.c (inferior_to_inferior_object): Return
3187         gdbpy_ref.
3188         (python_new_inferior, python_inferior_deleted)
3189         (thread_to_thread_object, delete_thread_object)
3190         (build_inferior_list, gdbpy_selected_inferior): Update.
3191         * python/py-infthread.c (create_thread_object): Update.  Also fail
3192         if inferior_to_inferior_object fails.
3193
3194 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3195
3196         * inferior.h (class inferior) <displaced_step_state>: New field.
3197         * infrun.h (struct displaced_step_state): Move here from
3198         infrun.c.  Initialize fields, add constructor.
3199         <inf>: Remove field.
3200         <reset>: New method.
3201         * infrun.c (struct displaced_step_inferior_state): Move to
3202         infrun.h.
3203         (displaced_step_inferior_states): Remove.
3204         (get_displaced_stepping_state): Adust.
3205         (displaced_step_in_progress_any_inferior): Adjust.
3206         (displaced_step_in_progress_thread): Adjust.
3207         (displaced_step_in_progress): Adjust.
3208         (add_displaced_stepping_state): Remove.
3209         (get_displaced_step_closure_by_addr): Adjust.
3210         (remove_displaced_stepping_state): Remove.
3211         (infrun_inferior_exit): Call displaced_step_state.reset.
3212         (use_displaced_stepping): Don't check for NULL.
3213         (displaced_step_prepare_throw): Call
3214         get_displaced_stepping_state.
3215         (displaced_step_fixup): Don't check for NULL.
3216         (prepare_for_detach): Don't check for NULL.
3217
3218 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3219
3220         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3221          in case of call that did not complete.
3222
3223 2019-01-02  Andrey Utkin  <autkin@undo.io>
3224
3225         * symfile.c (find_separate_debug_file): Fix search of debug files for
3226         remote debuggee.
3227
3228 2019-01-02  Tom Tromey  <tom@tromey.com>
3229
3230         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3231         indentation.
3232         * python/py-frame.c (frapy_older): Remove cast.
3233         (frapy_newer): Likewise.
3234         * python/py-breakpoint.c (local_setattro): Remove cast.
3235         * python/py-arch.c (archpy_name): Remove local variable.
3236         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3237
3238 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3239
3240         * unittests/basic_string_view/element_access/char/empty.cc:
3241         Fix year range in copyright header.
3242
3243 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3244
3245         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3246         Delete.
3247         <operator==>: Update with for removed field.
3248         <hash>: Likewise.
3249         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3250         <isa_features>: ...this.
3251         <abi_features>: New field.
3252         (riscv_isa_flen): Update comment.
3253         (riscv_abi_xlen): New declaration.
3254         (riscv_abi_flen): New declaration.
3255         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3256         isa_features.
3257         (riscv_abi_xlen): New function.
3258         (riscv_isa_flen): Update to get answer from isa_features.
3259         (riscv_abi_flen): New function.
3260         (riscv_has_fp_abi): Update to get answer from abi_features.
3261         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3262         xlen and flen.
3263         (riscv_call_info) <xlen, flen>: Update comment.
3264         (riscv_call_arg_struct): Remove invalid assertions
3265         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3266         is removed.
3267         (riscv_gdbarch_init): Gather isa features and abi features
3268         separately, ensure both match on the gdbarch when reusing an old
3269         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3270         a target with 64-bit float hardware.
3271
3272 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3273
3274         * source.c (search_command_helper): Stop reverse search
3275         when line 1 has been searched.
3276
3277 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3278
3279         * record-full.c (record_full_base_target::close): Rewrite
3280         record_full_core_buf_list free logic.
3281
3282 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3283
3284         * break-catch-syscall.c (print_one_catch_syscall): xfree
3285         the last text.
3286
3287 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3288
3289         * top.c (print_gdb_version): Update Copyright year in version
3290         message.
3291
3292 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3293
3294         Update copyright year range in all GDB files.
3295
3296 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3297
3298         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3299
3300 For older changes see ChangeLog-2018.
3301 \f
3302 Local Variables:
3303 mode: change-log
3304 left-margin: 8
3305 fill-column: 74
3306 version-control: never
3307 coding: utf-8
3308 End:
3309