Introduce ATTRIBUTE_UNUSED_RESULT and use it
[external/binutils.git] / gdb / ChangeLog
1 2019-03-05  Tom Tromey  <tromey@adacore.com>
2
3         * utils.h (class gdb_argv) <release>: Add
4         ATTRIBUTE_UNUSED_RESULT.
5         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6
7 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8
9         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10         for-loop range, to avoid compiler warnings.
11
12         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13         avoid compiler warnings about unused variables.
14
15         * NEWS: Mention end of support for native debugging on MS-Windows
16         before XP.
17
18         PR gdb/24292
19         * common/netstuff.c:
20         * gdbserver/gdbreplay.c
21         * gdbserver/remote-utils.c:
22         * ser-tcp.c:
23         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
24         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
25         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
26         'getaddrinfo' and 'freeaddrinfo' were not available before
27         Windows XP, and mingw.org's MinGW headers by default define
28         _WIN32_WINNT to 0x500.
29
30 2019-03-01  Gary Benson <gbenson@redhat.com>
31
32         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
33
34 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
35             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
36
37         PR gdb/8527
38         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
39         set_sigint_trap, clear_sigint_trap.
40
41 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
42
43         * target.c (target_detach): Clear the regcache and the
44         frame cache.
45
46 2019-02-27  Pedro Alves  <palves@redhat.com>
47
48         * utils.c (set_screen_size): When we cap the height/width sizes,
49         tweak the corresponding command variable to show "unlimited":
50
51 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
52             Pedro Alves  <palves@redhat.com>
53
54         * utils.c (set_screen_size): Reduce "infinite" rows and columns
55         before calling rl_set_screen_size.
56
57 2019-02-27  Tom Tromey  <tromey@adacore.com>
58
59         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
60         define.
61         * python/py-value.c: Remove Python 2.4 workaround.
62         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
63         workaround.
64         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
65         Python 2.4 workaround.
66         * python/python-internal.h: Remove Python 2.4 comment.
67         (Py_ssize_t): Don't define.
68         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
69         (gdb_Py_DECREF): Remove Python 2.4 workaround.
70         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
71         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
72         * python/python.c (do_start_initialization): Remove Python 2.4
73         workaround.
74         * python/py-prettyprint.c (class dummy_python_frame): Remove.
75         (print_children): Remove Python 2.4 workaround.
76         * python/py-inferior.c (buffer_procs): Remove Python 2.4
77         workaround.
78         (CHARBUFFERPROC_NAME): Remove.
79         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
80         Python 2.4 workaround.
81
82 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
83
84         * NEWS: Note minimum Python version.
85
86 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
87
88         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
89         code from these functions.  Remove corresponding ifdefs.  Use
90         Py_buffer_up instead of explicit calls to PyBuffer_Release.
91         Remove gotos and target of gotos.
92         (infpy_search_memory): Likewise.
93
94 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
95
96         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
97         (hppa_gdbarch_init): Don't register deleted functions with
98         gdbarch.
99
100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
101
102         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
103         (h8300_unwind_sp): Delete.
104         (h8300_dummy_id): Delete.
105         (h8300_gdbarch_init): Don't register deleted functions with
106         gdbarch.
107
108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
109
110         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
111         (ft32_unwind_pc): Delete.
112         (ft32_unwind_sp): Delete.
113         (ft32_gdbarch_init): Don't register deleted functions with
114         gdbarch.
115
116 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
117
118         * gdb/frv-tdep.c (frv_dummy_id): Delete.
119         (frv_unwind_pc): Delete.
120         (frv_unwind_sp): Delete.
121         (frv_gdbarch_init): Don't register deleted functions with
122         gdbarch.
123
124 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
125
126         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
127         (riscv_unwind_pc): Delete.
128         (riscv_unwind_sp): Delete.
129         (riscv_gdbarch_init): Don't register deleted functions with
130         gdbarch.
131
132 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
133
134         * gdb/csky-tdep.c (csky_dummy_id): Delete.
135         (csky_unwind_pc): Delete.
136         (csky_unwind_sp): Delete.
137         (csky_gdbarch_init): Don't register deleted functions with
138         gdbarch.
139
140 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
141
142         * gdb/cris-tdep.c (cris_dummy_id): Delete.
143         (cris_unwind_pc): Delete.
144         (cris_unwind_sp): Delete.
145         (cris_gdbarch_init): Don't register deleted functions with
146         gdbarch.
147
148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
149
150         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
151         (bfin_unwind_pc): Delete.
152         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
153
154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
155
156         * gdb/arm-tdep.c (arm_dummy_id): Delete.
157         (arm_unwind_pc): Delete.
158         (arm_unwind_sp): Delete.
159         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
160
161 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
162
163         * gdb/arc-tdep.c (arc_dummy_id): Delete.
164         (arc_unwind_pc): Delete.
165         (arc_unwind_sp): Delete.
166         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
167
168 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
169
170         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
171         (alpha_unwind_pc): Delete.
172         (alpha_gdbarch_init): Don't register deleted functions with
173         gdbarch.
174
175 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
176
177         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
178         (aarch64_unwind_pc): Delete.
179         (aarch64_unwind_sp): Delete.
180         (aarch64_gdbarch_init): Don't register deleted functions with
181         gdbarch.
182
183 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
184
185         * gdbtypes.c (type_align): Don't consider static members when
186         computing structure alignment.
187
188 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
189
190         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
191         return 0 for other types.
192         * arch-utils.c (default_type_align): Always return 0.
193         * gdbarch.h: Regenerate.
194         * gdbarch.sh (type_align): Extend comment.
195         * gdbtypes.c (type_align): Add additional comments, always call
196         gdbarch_type_align before applying the default rules.
197         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
198         generic code will then apply a suitable default.
199         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
200         types, return 0 for other types.
201
202 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
203
204         * NEWS: Create a new section for the next release branch.
205         Rename the section of the current branch, now that it has
206         been cut.
207
208 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
209
210         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
211         * version.in: Bump version to 8.3.50.DATE-git.
212
213 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
214
215         * aix-thread.c (ptid_cmp): Remove unused variable.
216         (get_signaled_thread): Likewise.
217         (store_regs_user_thread): Likewise.
218         (store_regs_kernel_thread): Likewise.
219         (fetch_regs_kernel_thread): Remove shadowed variable.
220
221 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
222
223         * features/riscv/32bit-cpu.xml: Add register numbers.
224         * features/riscv/32bit-fpu.c: Regenerate.
225         * features/riscv/32bit-fpu.xml: Add register numbers.
226         * features/riscv/64bit-cpu.xml: Add register numbers.
227         * features/riscv/64bit-fpu.c: Regenerate.
228         * features/riscv/64bit-fpu.xml: Add register numbers.
229
230 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
231
232         * NEWS: Mention two argument form of gdb.Value constructor.
233         * python/py-value.c (convert_buffer_and_type_to_value): New
234         function.
235         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
236         Add support for handling an optional second argument.  Call
237         convert_buffer_and_type_to_value as appropriate.
238         * python/python-internal.h (Py_buffer_deleter): New struct.
239         (Py_buffer_up): New typedef.
240
241 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
242
243         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
244         instead of releasing ownership.
245
246 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
247
248         * dwarf2read.c (open_and_init_dwp_file): Call
249         elf_numsections instead of bfd_count_sections to initialize
250         dwp_file->num_sections.
251
252 2019-02-25  Tom Tromey  <tromey@adacore.com>
253
254         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
255
256 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
257
258         * gcore.in: Add '--readnever' option when invoking GDB.
259
260 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
261
262         * MAINTAINERS: Update my email address.
263
264 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
265
266         * build-id.c (build_id_to_debug_bfd_1): New function.
267         (build_id_to_debug_bfd): Look for separate debug file in
268         sysroot.
269
270 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
271
272         * gdbarch.sh: Update the copyright year range that is placed into
273         generated files.
274
275 2019-02-22  Keith Seitz  <keiths@redhat.com>
276
277         PR symtab/23853
278         * linespec.c (create_sals_line_offset): Search for the default
279         symtab's filename instead of its fullname.
280
281 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
282
283         * NEWS: Update style defaults.
284
285 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
286
287         * main.c (captured_main_1): Disable styling in batch mode.
288
289 2019-02-20  Tom Tromey  <tom@tromey.com>
290
291         * symtab.c (symtab_symbol_info): Fix typos.
292
293 2019-02-20  Tom Tromey  <tromey@adacore.com>
294
295         * findcmd.c (_initialize_mem_search): Use upper case for
296         metasyntactic variables.
297
298 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
299
300         * aarch64-tdep.c (aarch64_add_reggroups): New function.
301         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
302
303 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
304
305         * top.h (source_file_name): Change to std::string.
306         * top.c (source_file_name): Likewise.
307         (command_line_input): Adjust.
308         * cli/cli-script.c (script_from_file): Adjust.
309
310 2019-02-19  Tom Tromey  <tromey@adacore.com>
311
312         * ravenscar-thread.c
313         (ravenscar_thread_target::update_thread_list): Don't call
314         ada_build_task_list.
315         * ada-lang.h (ada_build_task_list): Don't declare.
316         * ada-tasks.c (struct ada_tasks_inferior_data)
317         <task_list_valid_p>: Now bool.
318         (read_known_tasks, ada_task_list_changed)
319         (ada_tasks_invalidate_inferior_data): Update.
320         (read_known_tasks_array): Return bool.
321         (read_known_tasks_list): Likewise.
322         (read_known_tasks): Return void.
323         (ada_build_task_list): Now static.
324
325 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
326
327         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
328         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
329
330 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
331
332         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
333         variant for ada_tasks_pspace_data_handle and
334         ada_tasks_inferior_data_handle.
335         (ada_tasks_pspace_data_cleanup): New function.
336         (ada_tasks_inferior_data_cleanup): New function.
337
338 2019-02-17  Tom Tromey  <tom@tromey.com>
339
340         * macrotab.h (macro_source_fullname): Return a std::string.
341         * macrotab.c (macro_include, check_for_redefinition)
342         (macro_undef, macro_lookup_definition, foreach_macro)
343         (foreach_macro_in_scope): Update.
344         (macro_source_fullname): Return a std::string.
345         * macrocmd.c (show_pp_source_pos): Update.
346
347 2019-02-17  Tom Tromey  <tom@tromey.com>
348
349         * macrocmd.c (show_pp_source_pos): Style the file names.
350
351 2019-02-17  Tom Tromey  <tom@tromey.com>
352
353         PR tui/24197:
354         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
355
356 2019-02-17  Tom Tromey  <tom@tromey.com>
357
358         * ada-lang.c (user_select_syms): Use filtered printing.
359         * utils.c (wrap_style): New global.
360         (desired_style): Remove.
361         (emit_style_escape): Add stream parameter.
362         (set_output_style, reset_terminal_style, prompt_for_continue):
363         Update.
364         (flush_wrap_buffer): Only flush gdb_stdout.
365         (wrap_here): Set wrap_style.
366         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
367         treat escape sequences as a character.  Change when wrap buffer is
368         flushed.
369         (fputs_styled): Do not set the output style when the default is
370         requested.
371         * ui-style.h (struct ui_file_style) <is_default>: New method.
372         * source.c (print_source_lines_base): Emit escape sequences in one
373         piece.
374
375 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
376
377         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
378         integers and enumeration types.
379
380 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
381
382         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
383         instead of lookup_symbol_in_language
384         (do_exact_match): New function.
385         (ada_get_symbol_name_matcher): Return do_exact_match when
386         doing a verbatim match.
387
388 2019-02-15  Tom Tromey  <tromey@adacore.com>
389
390         * ravenscar-thread.c (ravenscar_thread_target::resume)
391         (ravenscar_thread_target::wait): Special case wildcard requests.
392
393 2019-02-15  Tom Tromey  <tromey@adacore.com>
394
395         * ravenscar-thread.c (base_ptid): Remove.
396         (struct ravenscar_thread_target) <close>: New method.
397         <m_base_ptid>: New member.
398         <update_inferior_ptid, active_task, task_is_currently_active,
399         runtime_initialized>: Declare methods.
400         <ravenscar_thread_target>: Add constructor.
401         (ravenscar_thread_target::task_is_currently_active)
402         (ravenscar_thread_target::update_inferior_ptid)
403         (ravenscar_runtime_initialized): Rename.  Now methods.
404         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
405         (ravenscar_thread_target::update_thread_list): Update.
406         (ravenscar_thread_target::active_task): Now method.
407         (ravenscar_thread_target::store_registers)
408         (ravenscar_thread_target::prepare_to_store)
409         (ravenscar_thread_target::prepare_to_store)
410         (ravenscar_thread_target::mourn_inferior): Update.
411         (ravenscar_inferior_created): Use "new" to create target.
412         (ravenscar_thread_target::get_ada_task_ptid): Update.
413         (_initialize_ravenscar): Don't initialize base_ptid.
414         (ravenscar_ops): Remove global.
415
416 2019-02-15  Tom Tromey  <tromey@adacore.com>
417
418         * target.h (push_target): Declare new overload.
419         * target.c (push_target): New overload, taking an rvalue reference.
420         * remote.c (remote_target::open_1): Use push_target overload.
421         * corelow.c (core_target_open): Use push_target overload.
422
423 2019-02-15  Tom Tromey  <tromey@adacore.com>
424
425         * ravenscar-thread.c (is_ravenscar_task)
426         (ravenscar_task_is_currently_active): Return bool.
427         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
428         (_initialize_ravenscar): Remove "(void)".
429         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
430         Return bool.
431
432 2019-02-15  Tom Tromey  <tromey@adacore.com>
433
434         * ravenscar-thread.c (ravenscar_runtime_initializer)
435         (has_ravenscar_runtime, get_running_thread_id)
436         (ravenscar_thread_target::resume): Fix indentation.
437
438 2019-02-15  Tom Tromey  <tromey@adacore.com>
439
440         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
441         from ravenscar_arch_ops.
442         (sparc_ravenscar_ops::fetch_registers)
443         (sparc_ravenscar_ops::store_registers): Now methods.
444         (sparc_ravenscar_prepare_to_store): Remove.
445         (sparc_ravenscar_ops): Redefine.
446         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
447         methods and destructor.  Remove members.
448         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
449         (ravenscar_thread_target::store_registers)
450         (ravenscar_thread_target::prepare_to_store): Update.
451         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
452         Remove.
453         (struct ppc_ravenscar_powerpc_ops): Derive from
454         ravenscar_arch_ops.
455         (ppc_ravenscar_powerpc_ops::fetch_registers)
456         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
457         (ppc_ravenscar_powerpc_ops): Redefine.
458         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
459         (ppc_ravenscar_e500_ops::fetch_registers)
460         (ppc_ravenscar_e500_ops::store_registers): Now methods.
461         (ppc_ravenscar_e500_ops): Redefine.
462         * aarch64-ravenscar-thread.c
463         (aarch64_ravenscar_generic_prepare_to_store): Remove.
464         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
465         (aarch64_ravenscar_fetch_registers)
466         (aarch64_ravenscar_store_registers): Now methods.
467         (aarch64_ravenscar_ops): Redefine.
468
469 2019-02-15  Tom Tromey  <tromey@adacore.com>
470
471         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
472         (ravenscar_thread_target::stopped_by_hw_breakpoint)
473         (ravenscar_thread_target::stopped_by_watchpoint)
474         (ravenscar_thread_target::stopped_data_address)
475         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
476
477 2019-02-15  Tom Tromey  <tromey@adacore.com>
478
479         * ravenscar-thread.c: Fix some typos.
480
481 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
482             Tom Tromey  <tromey@adacore.com>
483
484         * ada-lang.c (ada_exception_sal): Change addr_string to a
485         std::string.
486         (create_ada_exception_catchpoint): Update.
487
488 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
489             Tom Tromey  <tromey@adacore.com>
490
491         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
492         (bp_location_ops): Remove.
493         (base_breakpoint_allocate_location): Update.
494         (free_bp_location): Update.
495         * ada-lang.c (class ada_catchpoint_location)
496         <ada_catchpoint_location>: Remove ops parameter.
497         (ada_catchpoint_location_dtor): Remove.
498         (ada_catchpoint_location_ops): Remove.
499         (allocate_location_exception): Update.
500         * breakpoint.h (struct bp_location_ops): Remove.
501         (class bp_location) <bp_location>: Remove bp_location_ops
502         parameter.
503         <~bp_location>: Add destructor.
504         <ops>: Remove.
505
506 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
507             Pedro Alves  <palves@redhat.com>
508
509         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
510         'PATH_MAX'.
511
512 2019-02-14  David Michael  <fedora.dm0@gmail.com>
513             Samuel Thibault  <samuel.thibault@gnu.org>
514             Thomas Schwinge  <thomas@codesourcery.com>
515
516         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
517         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
518
519 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
520
521         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
522         (check_empty): Use "const char *".
523
524         * gnu-nat.c (gnu_nat_target::detach): Instead of
525         'detach_inferior (pid)' call
526         'detach_inferior (find_inferior_pid (pid))'.
527
528         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
529         'nat/fork-inferior.o'.
530         * gnu-nat.c: #include "nat/fork-inferior.h".
531
532         * gnu-nat.c (gnu_nat_target::detach): Instead of
533         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
534         * gnu-nat.h: #include "inf-child.h".
535         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
536         'i386_gnu_nat_target::fetch_registers'.
537         (gnu_store_registers): Rename/move to
538         'i386_gnu_nat_target::store_registers'.
539
540         * config/i386/nm-i386gnu.h: Don't "#include" any files.
541         * gnu-nat.h (mach_thread_info): New function.
542         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
543
544         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
545
546 2019-02-14  Frederic Konrad  <konrad@adacore.com>
547
548         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
549
550 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
551
552         * windows-nat.c (windows_add_thread): Add new parameter
553         "main_thread_p" with default value set to false.  Update
554         function documentation as well as all callers.
555         (windows_delete_thread): Likewise.
556         (fake_create_process): Update call to windows_add_thread.
557         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
558         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
559         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
560         call to windows_delete_thread.
561
562 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
563
564         * MAINTAINERS: Add Andrew Burgess as global maintainer.
565
566 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
567
568         * symfile.c (find_separate_debug_file): Use canonical path of
569         sysroot with child_path instead of gdb_sysroot if it is valid.
570
571 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
572
573         * symfile.c (find_separate_debug_file): Use child_path to
574         determine if an object file is under a sysroot.
575
576 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
577
578         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
579         unittests/child-path-selftests.c.
580         * common/pathstuff.c (child_path): New function.
581         * common/pathstuff.h (child_path): New prototype.
582         * unittests/child-path-selftests.c: New file.
583
584 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
585
586         * symfile.c (find_separate_debug_file): Look for separate debug
587         files in debug directories under the sysroot.
588
589 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
590
591         * symtab.h (struct minimal_symbol data_p): New const method.
592         (struct minimal_symbol text_p): Likewise.
593         * symtab.c (output_source_filename): Use file name style
594         to print file name.
595         (print_symbol_info): Likewise.
596         (print_msymbol_info): Use address style to print addresses.
597         Use function name style to print executable text symbols.
598         (expand_symtab_containing_pc): Use data_p.
599         (find_pc_sect_compunit_symtab): Likewise.
600
601 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
602
603         * breakpoint.c (describe_other_breakpoints): Use address style
604         to print addresses.
605         (say_where): Likewise.
606
607 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
608
609         * ada-typeprint.c (print_func_type): Print function name
610         style to print function name.
611         * c-typeprint.c (c_print_type_1): Likewise.
612
613 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
614
615         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
616         for execve.
617
618 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
619
620         * c-exp.y (direct_abs_decl): Use emplace_back to record the
621         type_stack.
622
623 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
624
625         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
626         TYPE_CODE_REF types.
627
628 2019-02-08  Jim Wilson  <jimw@sifive.com>
629
630         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
631         (riscv_linux_fregset): New.
632         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
633
634 2019-02-07  Tom Tromey  <tom@tromey.com>
635
636         * thread.c (thread_cancel_execution_command): Update.
637         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
638         methods.
639         (struct thread_fsm_ops): Remove.
640         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
641         (thread_fsm_should_stop, thread_fsm_return_value)
642         (thread_fsm_set_finished, thread_fsm_finished_p)
643         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
644         Don't declare.
645         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
646         * infrun.c (clear_proceed_status_thread)
647         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
648         (print_stop_event): Update.
649         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
650         Add constructor.
651         (step_command_fsm_ops): Remove.
652         (new_step_command_fsm): Remove.
653         (step_1): Update.
654         (step_command_fsm::should_stop): Rename from
655         step_command_fsm_should_stop.
656         (step_command_fsm::clean_up): Rename from
657         step_command_fsm_clean_up.
658         (step_command_fsm::do_async_reply_reason): Rename from
659         step_command_fsm_async_reply_reason.
660         (struct until_next_fsm): Inherit from thread_fsm.  Add
661         constructor.
662         (until_next_fsm_ops): Remove.
663         (new_until_next_fsm): Remove.
664         (until_next_fsm::should_stop): Rename from
665         until_next_fsm_should_stop.
666         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
667         (until_next_fsm::do_async_reply_reason): Rename from
668         until_next_fsm_async_reply_reason.
669         (struct finish_command_fsm): Inherit from thread_fsm.  Add
670         constructor.  Change type of breakpoint.
671         (finish_command_fsm_ops): Remove.
672         (new_finish_command_fsm): Remove.
673         (finish_command_fsm::should_stop): Rename from
674         finish_command_fsm_should_stop.
675         (finish_command_fsm::clean_up): Rename from
676         finish_command_fsm_clean_up.
677         (finish_command_fsm::return_value): Rename from
678         finish_command_fsm_return_value.
679         (finish_command_fsm::do_async_reply_reason): Rename from
680         finish_command_fsm_async_reply_reason.
681         (finish_command): Update.
682         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
683         Add constructor.
684         (call_thread_fsm_ops): Remove.
685         (call_thread_fsm::call_thread_fsm): Rename from
686         new_call_thread_fsm.
687         (call_thread_fsm::should_stop): Rename from
688         call_thread_fsm_should_stop.
689         (call_thread_fsm::should_notify_stop): Rename from
690         call_thread_fsm_should_notify_stop.
691         (run_inferior_call, call_function_by_hand_dummy): Update.
692         * cli/cli-interp.c (should_print_stop_to_console): Update.
693         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
694         Add constructor.  Change type of location_breakpoint,
695         caller_breakpoint.
696         (until_break_fsm_ops): Remove.
697         (new_until_break_fsm): Remove.
698         (until_break_fsm::should_stop): Rename from
699         until_break_fsm_should_stop.
700         (until_break_fsm::clean_up): Rename from
701         until_break_fsm_clean_up.
702         (until_break_fsm::do_async_reply_reason): Rename from
703         until_break_fsm_async_reply_reason.
704         (until_break_command): Update.
705         * thread-fsm.c: Remove.
706         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
707
708 2019-02-07  Tom Tromey  <tom@tromey.com>
709
710         * yy-remap.h: Add include guard.
711         * xtensa-tdep.h: Add include guard.
712         * xcoffread.h: Rename include guard.
713         * varobj-iter.h: Add include guard.
714         * tui/tui.h: Rename include guard.
715         * tui/tui-winsource.h: Rename include guard.
716         * tui/tui-wingeneral.h: Rename include guard.
717         * tui/tui-windata.h: Rename include guard.
718         * tui/tui-win.h: Rename include guard.
719         * tui/tui-stack.h: Rename include guard.
720         * tui/tui-source.h: Rename include guard.
721         * tui/tui-regs.h: Rename include guard.
722         * tui/tui-out.h: Rename include guard.
723         * tui/tui-layout.h: Rename include guard.
724         * tui/tui-io.h: Rename include guard.
725         * tui/tui-hooks.h: Rename include guard.
726         * tui/tui-file.h: Rename include guard.
727         * tui/tui-disasm.h: Rename include guard.
728         * tui/tui-data.h: Rename include guard.
729         * tui/tui-command.h: Rename include guard.
730         * tic6x-tdep.h: Add include guard.
731         * target/waitstatus.h: Rename include guard.
732         * target/wait.h: Rename include guard.
733         * target/target.h: Rename include guard.
734         * target/resume.h: Rename include guard.
735         * target-float.h: Rename include guard.
736         * stabsread.h: Add include guard.
737         * rs6000-tdep.h: Add include guard.
738         * riscv-fbsd-tdep.h: Add include guard.
739         * regformats/regdef.h: Rename include guard.
740         * record.h: Rename include guard.
741         * python/python.h: Rename include guard.
742         * python/python-internal.h: Rename include guard.
743         * python/py-stopevent.h: Rename include guard.
744         * python/py-ref.h: Rename include guard.
745         * python/py-record.h: Rename include guard.
746         * python/py-record-full.h: Rename include guard.
747         * python/py-record-btrace.h: Rename include guard.
748         * python/py-instruction.h: Rename include guard.
749         * python/py-events.h: Rename include guard.
750         * python/py-event.h: Rename include guard.
751         * procfs.h: Add include guard.
752         * proc-utils.h: Add include guard.
753         * p-lang.h: Add include guard.
754         * or1k-tdep.h: Rename include guard.
755         * observable.h: Rename include guard.
756         * nto-tdep.h: Rename include guard.
757         * nat/x86-linux.h: Rename include guard.
758         * nat/x86-linux-dregs.h: Rename include guard.
759         * nat/x86-gcc-cpuid.h: Add include guard.
760         * nat/x86-dregs.h: Rename include guard.
761         * nat/x86-cpuid.h: Rename include guard.
762         * nat/ppc-linux.h: Rename include guard.
763         * nat/mips-linux-watch.h: Rename include guard.
764         * nat/linux-waitpid.h: Rename include guard.
765         * nat/linux-ptrace.h: Rename include guard.
766         * nat/linux-procfs.h: Rename include guard.
767         * nat/linux-osdata.h: Rename include guard.
768         * nat/linux-nat.h: Rename include guard.
769         * nat/linux-namespaces.h: Rename include guard.
770         * nat/linux-btrace.h: Rename include guard.
771         * nat/glibc_thread_db.h: Rename include guard.
772         * nat/gdb_thread_db.h: Rename include guard.
773         * nat/gdb_ptrace.h: Rename include guard.
774         * nat/fork-inferior.h: Rename include guard.
775         * nat/amd64-linux-siginfo.h: Rename include guard.
776         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
777         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
778         * nat/aarch64-linux.h: Rename include guard.
779         * nat/aarch64-linux-hw-point.h: Rename include guard.
780         * mn10300-tdep.h: Add include guard.
781         * mips-linux-tdep.h: Add include guard.
782         * mi/mi-parse.h: Rename include guard.
783         * mi/mi-out.h: Rename include guard.
784         * mi/mi-main.h: Rename include guard.
785         * mi/mi-interp.h: Rename include guard.
786         * mi/mi-getopt.h: Rename include guard.
787         * mi/mi-console.h: Rename include guard.
788         * mi/mi-common.h: Rename include guard.
789         * mi/mi-cmds.h: Rename include guard.
790         * mi/mi-cmd-break.h: Rename include guard.
791         * m2-lang.h: Add include guard.
792         * location.h: Rename include guard.
793         * linux-record.h: Rename include guard.
794         * linux-nat.h: Add include guard.
795         * linux-fork.h: Add include guard.
796         * i386-darwin-tdep.h: Rename include guard.
797         * hppa-linux-offsets.h: Add include guard.
798         * guile/guile.h: Rename include guard.
799         * guile/guile-internal.h: Rename include guard.
800         * gnu-nat.h: Rename include guard.
801         * gdb-stabs.h: Rename include guard.
802         * frv-tdep.h: Add include guard.
803         * f-lang.h: Add include guard.
804         * event-loop.h: Add include guard.
805         * darwin-nat.h: Rename include guard.
806         * cp-abi.h: Rename include guard.
807         * config/sparc/nm-sol2.h: Rename include guard.
808         * config/nm-nto.h: Rename include guard.
809         * config/nm-linux.h: Add include guard.
810         * config/i386/nm-i386gnu.h: Rename include guard.
811         * config/djgpp/nl_types.h: Rename include guard.
812         * config/djgpp/langinfo.h: Rename include guard.
813         * compile/gcc-cp-plugin.h: Add include guard.
814         * compile/gcc-c-plugin.h: Add include guard.
815         * compile/compile.h: Rename include guard.
816         * compile/compile-object-run.h: Rename include guard.
817         * compile/compile-object-load.h: Rename include guard.
818         * compile/compile-internal.h: Rename include guard.
819         * compile/compile-cplus.h: Rename include guard.
820         * compile/compile-c.h: Rename include guard.
821         * common/xml-utils.h: Rename include guard.
822         * common/x86-xstate.h: Rename include guard.
823         * common/version.h: Rename include guard.
824         * common/vec.h: Rename include guard.
825         * common/tdesc.h: Rename include guard.
826         * common/selftest.h: Rename include guard.
827         * common/scoped_restore.h: Rename include guard.
828         * common/scoped_mmap.h: Rename include guard.
829         * common/scoped_fd.h: Rename include guard.
830         * common/safe-iterator.h: Rename include guard.
831         * common/run-time-clock.h: Rename include guard.
832         * common/refcounted-object.h: Rename include guard.
833         * common/queue.h: Rename include guard.
834         * common/ptid.h: Rename include guard.
835         * common/print-utils.h: Rename include guard.
836         * common/preprocessor.h: Rename include guard.
837         * common/pathstuff.h: Rename include guard.
838         * common/observable.h: Rename include guard.
839         * common/netstuff.h: Rename include guard.
840         * common/job-control.h: Rename include guard.
841         * common/host-defs.h: Rename include guard.
842         * common/gdb_wait.h: Rename include guard.
843         * common/gdb_vecs.h: Rename include guard.
844         * common/gdb_unlinker.h: Rename include guard.
845         * common/gdb_unique_ptr.h: Rename include guard.
846         * common/gdb_tilde_expand.h: Rename include guard.
847         * common/gdb_sys_time.h: Rename include guard.
848         * common/gdb_string_view.h: Rename include guard.
849         * common/gdb_splay_tree.h: Rename include guard.
850         * common/gdb_setjmp.h: Rename include guard.
851         * common/gdb_ref_ptr.h: Rename include guard.
852         * common/gdb_optional.h: Rename include guard.
853         * common/gdb_locale.h: Rename include guard.
854         * common/gdb_assert.h: Rename include guard.
855         * common/filtered-iterator.h: Rename include guard.
856         * common/filestuff.h: Rename include guard.
857         * common/fileio.h: Rename include guard.
858         * common/environ.h: Rename include guard.
859         * common/common-utils.h: Rename include guard.
860         * common/common-types.h: Rename include guard.
861         * common/common-regcache.h: Rename include guard.
862         * common/common-inferior.h: Rename include guard.
863         * common/common-gdbthread.h: Rename include guard.
864         * common/common-exceptions.h: Rename include guard.
865         * common/common-defs.h: Rename include guard.
866         * common/common-debug.h: Rename include guard.
867         * common/cleanups.h: Rename include guard.
868         * common/buffer.h: Rename include guard.
869         * common/btrace-common.h: Rename include guard.
870         * common/break-common.h: Rename include guard.
871         * cli/cli-utils.h: Rename include guard.
872         * cli/cli-style.h: Rename include guard.
873         * cli/cli-setshow.h: Rename include guard.
874         * cli/cli-script.h: Rename include guard.
875         * cli/cli-interp.h: Rename include guard.
876         * cli/cli-decode.h: Rename include guard.
877         * cli/cli-cmds.h: Rename include guard.
878         * charset-list.h: Add include guard.
879         * buildsym-legacy.h: Rename include guard.
880         * bfin-tdep.h: Add include guard.
881         * ax.h: Rename include guard.
882         * arm-linux-tdep.h: Add include guard.
883         * arm-fbsd-tdep.h: Add include guard.
884         * arch/xtensa.h: Rename include guard.
885         * arch/tic6x.h: Add include guard.
886         * arch/i386.h: Add include guard.
887         * arch/arm.h: Rename include guard.
888         * arch/arm-linux.h: Rename include guard.
889         * arch/arm-get-next-pcs.h: Rename include guard.
890         * arch/amd64.h: Add include guard.
891         * arch/aarch64-insn.h: Rename include guard.
892         * arch-utils.h: Rename include guard.
893         * annotate.h: Add include guard.
894         * amd64-darwin-tdep.h: Rename include guard.
895         * aarch64-linux-tdep.h: Add include guard.
896         * aarch64-fbsd-tdep.h: Add include guard.
897         * aarch32-linux-nat.h: Add include guard.
898
899 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
900
901         * macrotab.c (macro_define_internal): New function that
902         factorizes macro_define_object_internal and macro_define_function
903         code.
904         (macro_define_object_internal): Use macro_define_internal.
905         (macro_define_function): Likewise.
906
907 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
908
909         * macrocmd.c (extract_identifier): Return
910         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
911         callers.
912
913 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
914
915         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
916
917 2019-02-05  Tom Tromey  <tom@tromey.com>
918
919         * target.c (target_stack::unpush): Move assertion earlier.
920
921 2019-01-30  Tom Tromey  <tom@tromey.com>
922
923         PR python/23615:
924         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
925         (gdbpy_parse_and_eval): Likewise.
926         * python/python-internal.h (gdbpy_allow_threads): New class.
927
928 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
929
930         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
931         (aarch64_fbsd_fpregmap): Move earlier.
932         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
933         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
934         instead of individual calls to trad_frame_set_reg_addr.
935         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
936         earlier.
937         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
938         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
939         instead of individual calls to trad_frame_set_reg_addr.
940
941 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
942
943         * CONTRIBUTE: Replace contribution list with wiki link.
944
945 2019-01-25  Tom Tromey  <tom@tromey.com>
946
947         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
948
949 2019-01-25  Tom Tromey  <tom@tromey.com>
950
951         * xtensa-linux-nat.c: Fix common/ includes.
952         * xml-support.h: Fix common/ includes.
953         * xml-support.c: Fix common/ includes.
954         * x86-linux-nat.c: Fix common/ includes.
955         * windows-nat.c: Fix common/ includes.
956         * varobj.h: Fix common/ includes.
957         * varobj.c: Fix common/ includes.
958         * value.c: Fix common/ includes.
959         * valops.c: Fix common/ includes.
960         * utils.c: Fix common/ includes.
961         * unittests/xml-utils-selftests.c: Fix common/ includes.
962         * unittests/utils-selftests.c: Fix common/ includes.
963         * unittests/unpack-selftests.c: Fix common/ includes.
964         * unittests/tracepoint-selftests.c: Fix common/ includes.
965         * unittests/style-selftests.c: Fix common/ includes.
966         * unittests/string_view-selftests.c: Fix common/ includes.
967         * unittests/scoped_restore-selftests.c: Fix common/ includes.
968         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
969         * unittests/scoped_fd-selftests.c: Fix common/ includes.
970         * unittests/rsp-low-selftests.c: Fix common/ includes.
971         * unittests/parse-connection-spec-selftests.c: Fix common/
972         includes.
973         * unittests/optional-selftests.c: Fix common/ includes.
974         * unittests/offset-type-selftests.c: Fix common/ includes.
975         * unittests/observable-selftests.c: Fix common/ includes.
976         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
977         * unittests/memrange-selftests.c: Fix common/ includes.
978         * unittests/memory-map-selftests.c: Fix common/ includes.
979         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
980         * unittests/function-view-selftests.c: Fix common/ includes.
981         * unittests/environ-selftests.c: Fix common/ includes.
982         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
983         * unittests/common-utils-selftests.c: Fix common/ includes.
984         * unittests/cli-utils-selftests.c: Fix common/ includes.
985         * unittests/array-view-selftests.c: Fix common/ includes.
986         * ui-file.c: Fix common/ includes.
987         * tui/tui-io.c: Fix common/ includes.
988         * tracepoint.h: Fix common/ includes.
989         * tracepoint.c: Fix common/ includes.
990         * tracefile-tfile.c: Fix common/ includes.
991         * top.h: Fix common/ includes.
992         * top.c: Fix common/ includes.
993         * thread.c: Fix common/ includes.
994         * target/waitstatus.h: Fix common/ includes.
995         * target/waitstatus.c: Fix common/ includes.
996         * target.h: Fix common/ includes.
997         * target.c: Fix common/ includes.
998         * target-memory.c: Fix common/ includes.
999         * target-descriptions.c: Fix common/ includes.
1000         * symtab.h: Fix common/ includes.
1001         * symfile.c: Fix common/ includes.
1002         * stap-probe.c: Fix common/ includes.
1003         * spu-linux-nat.c: Fix common/ includes.
1004         * sparc-nat.c: Fix common/ includes.
1005         * source.c: Fix common/ includes.
1006         * solib.c: Fix common/ includes.
1007         * solib-target.c: Fix common/ includes.
1008         * ser-unix.c: Fix common/ includes.
1009         * ser-tcp.c: Fix common/ includes.
1010         * ser-pipe.c: Fix common/ includes.
1011         * ser-base.c: Fix common/ includes.
1012         * selftest-arch.c: Fix common/ includes.
1013         * s12z-tdep.c: Fix common/ includes.
1014         * rust-exp.y: Fix common/ includes.
1015         * rs6000-aix-tdep.c: Fix common/ includes.
1016         * riscv-tdep.c: Fix common/ includes.
1017         * remote.c: Fix common/ includes.
1018         * remote-notif.h: Fix common/ includes.
1019         * remote-fileio.h: Fix common/ includes.
1020         * remote-fileio.c: Fix common/ includes.
1021         * regcache.h: Fix common/ includes.
1022         * regcache.c: Fix common/ includes.
1023         * record-btrace.c: Fix common/ includes.
1024         * python/python.c: Fix common/ includes.
1025         * python/py-type.c: Fix common/ includes.
1026         * python/py-inferior.c: Fix common/ includes.
1027         * progspace.h: Fix common/ includes.
1028         * producer.c: Fix common/ includes.
1029         * procfs.c: Fix common/ includes.
1030         * proc-api.c: Fix common/ includes.
1031         * printcmd.c: Fix common/ includes.
1032         * ppc-linux-nat.c: Fix common/ includes.
1033         * parser-defs.h: Fix common/ includes.
1034         * osdata.c: Fix common/ includes.
1035         * obsd-nat.c: Fix common/ includes.
1036         * nat/x86-linux.c: Fix common/ includes.
1037         * nat/x86-linux-dregs.c: Fix common/ includes.
1038         * nat/x86-dregs.h: Fix common/ includes.
1039         * nat/x86-dregs.c: Fix common/ includes.
1040         * nat/ppc-linux.c: Fix common/ includes.
1041         * nat/mips-linux-watch.h: Fix common/ includes.
1042         * nat/mips-linux-watch.c: Fix common/ includes.
1043         * nat/linux-waitpid.c: Fix common/ includes.
1044         * nat/linux-ptrace.h: Fix common/ includes.
1045         * nat/linux-ptrace.c: Fix common/ includes.
1046         * nat/linux-procfs.c: Fix common/ includes.
1047         * nat/linux-personality.c: Fix common/ includes.
1048         * nat/linux-osdata.c: Fix common/ includes.
1049         * nat/linux-namespaces.c: Fix common/ includes.
1050         * nat/linux-btrace.h: Fix common/ includes.
1051         * nat/linux-btrace.c: Fix common/ includes.
1052         * nat/fork-inferior.c: Fix common/ includes.
1053         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1054         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1055         * nat/aarch64-linux.c: Fix common/ includes.
1056         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1057         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1058         * namespace.h: Fix common/ includes.
1059         * mips-linux-tdep.c: Fix common/ includes.
1060         * minsyms.c: Fix common/ includes.
1061         * mi/mi-parse.h: Fix common/ includes.
1062         * mi/mi-main.c: Fix common/ includes.
1063         * mi/mi-cmd-env.c: Fix common/ includes.
1064         * memrange.h: Fix common/ includes.
1065         * memattr.c: Fix common/ includes.
1066         * maint.h: Fix common/ includes.
1067         * maint.c: Fix common/ includes.
1068         * main.c: Fix common/ includes.
1069         * machoread.c: Fix common/ includes.
1070         * location.c: Fix common/ includes.
1071         * linux-thread-db.c: Fix common/ includes.
1072         * linux-nat.c: Fix common/ includes.
1073         * linux-fork.c: Fix common/ includes.
1074         * inline-frame.c: Fix common/ includes.
1075         * infrun.c: Fix common/ includes.
1076         * inflow.c: Fix common/ includes.
1077         * inferior.h: Fix common/ includes.
1078         * inferior.c: Fix common/ includes.
1079         * infcmd.c: Fix common/ includes.
1080         * inf-ptrace.c: Fix common/ includes.
1081         * inf-child.c: Fix common/ includes.
1082         * ia64-linux-nat.c: Fix common/ includes.
1083         * i387-tdep.c: Fix common/ includes.
1084         * i386-tdep.c: Fix common/ includes.
1085         * i386-linux-tdep.c: Fix common/ includes.
1086         * i386-linux-nat.c: Fix common/ includes.
1087         * i386-go32-tdep.c: Fix common/ includes.
1088         * i386-fbsd-tdep.c: Fix common/ includes.
1089         * i386-fbsd-nat.c: Fix common/ includes.
1090         * guile/scm-type.c: Fix common/ includes.
1091         * guile/guile.c: Fix common/ includes.
1092         * go32-nat.c: Fix common/ includes.
1093         * gnu-nat.c: Fix common/ includes.
1094         * gdbthread.h: Fix common/ includes.
1095         * gdbarch-selftests.c: Fix common/ includes.
1096         * gdb_usleep.c: Fix common/ includes.
1097         * gdb_select.h: Fix common/ includes.
1098         * gdb_bfd.c: Fix common/ includes.
1099         * gcore.c: Fix common/ includes.
1100         * fork-child.c: Fix common/ includes.
1101         * findvar.c: Fix common/ includes.
1102         * fbsd-nat.c: Fix common/ includes.
1103         * event-top.c: Fix common/ includes.
1104         * event-loop.c: Fix common/ includes.
1105         * dwarf2read.c: Fix common/ includes.
1106         * dwarf2loc.c: Fix common/ includes.
1107         * dwarf2-frame.c: Fix common/ includes.
1108         * dwarf-index-cache.c: Fix common/ includes.
1109         * dtrace-probe.c: Fix common/ includes.
1110         * disasm-selftests.c: Fix common/ includes.
1111         * defs.h: Fix common/ includes.
1112         * csky-tdep.c: Fix common/ includes.
1113         * cp-valprint.c: Fix common/ includes.
1114         * cp-support.h: Fix common/ includes.
1115         * cp-support.c: Fix common/ includes.
1116         * corelow.c: Fix common/ includes.
1117         * completer.h: Fix common/ includes.
1118         * completer.c: Fix common/ includes.
1119         * compile/compile.c: Fix common/ includes.
1120         * compile/compile-loc2c.c: Fix common/ includes.
1121         * compile/compile-cplus-types.c: Fix common/ includes.
1122         * compile/compile-cplus-symbols.c: Fix common/ includes.
1123         * command.h: Fix common/ includes.
1124         * cli/cli-dump.c: Fix common/ includes.
1125         * cli/cli-cmds.c: Fix common/ includes.
1126         * charset.c: Fix common/ includes.
1127         * build-id.c: Fix common/ includes.
1128         * btrace.h: Fix common/ includes.
1129         * btrace.c: Fix common/ includes.
1130         * breakpoint.h: Fix common/ includes.
1131         * breakpoint.c: Fix common/ includes.
1132         * ax.h: 
1133         (enum agent_op): Fix common/ includes.
1134         * ax-general.c (struct aop_map): Fix common/ includes.
1135         * ax-gdb.c: Fix common/ includes.
1136         * auxv.c: Fix common/ includes.
1137         * auto-load.c: Fix common/ includes.
1138         * arm-tdep.c: Fix common/ includes.
1139         * arch/riscv.c: Fix common/ includes.
1140         * arch/ppc-linux-common.c: Fix common/ includes.
1141         * arch/i386.c: Fix common/ includes.
1142         * arch/arm.c: Fix common/ includes.
1143         * arch/arm-linux.c: Fix common/ includes.
1144         * arch/arm-get-next-pcs.c: Fix common/ includes.
1145         * arch/amd64.c: Fix common/ includes.
1146         * arch/aarch64.c: Fix common/ includes.
1147         * arch/aarch64-insn.c: Fix common/ includes.
1148         * arch-utils.c: Fix common/ includes.
1149         * amd64-windows-tdep.c: Fix common/ includes.
1150         * amd64-tdep.c: Fix common/ includes.
1151         * amd64-sol2-tdep.c: Fix common/ includes.
1152         * amd64-obsd-tdep.c: Fix common/ includes.
1153         * amd64-nbsd-tdep.c: Fix common/ includes.
1154         * amd64-linux-tdep.c: Fix common/ includes.
1155         * amd64-linux-nat.c: Fix common/ includes.
1156         * amd64-fbsd-tdep.c: Fix common/ includes.
1157         * amd64-fbsd-nat.c: Fix common/ includes.
1158         * amd64-dicos-tdep.c: Fix common/ includes.
1159         * amd64-darwin-tdep.c: Fix common/ includes.
1160         * agent.c: Fix common/ includes.
1161         * ada-lang.h: Fix common/ includes.
1162         * ada-lang.c: Fix common/ includes.
1163         * aarch64-tdep.c: Fix common/ includes.
1164
1165 2019-01-25  Tom Tromey  <tom@tromey.com>
1166
1167         * common/create-version.sh: Use common/version.h.
1168
1169 2019-01-24  Pedro Alves  <palves@redhat.com>
1170
1171         * infrun.c (signal_stop, signal_print, signal_program)
1172         (signal_catch, signal_pass): Now arrays instead of pointers.
1173         (update_signals_program_target, do_target_resume)
1174         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1175         * linux-nat.c (linux_nat_target::pass_signals)
1176         (linux_nat_target::create_inferior, linux_nat_target::attach):
1177         Adjust.
1178         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1179         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1180         * procfs.c (procfs_target::pass_signals): Adjust.
1181         * record-full.c (record_full_target::resume): Adjust.
1182         * remote.c (remote_target::pass_signals)
1183         (remote_target::program_signals): Adjust.
1184         * target-debug.h (target_debug_print_signals): Now takes a
1185         gdb::array_view as parameter.  Adjust.
1186         * target.h (target_ops) <pass_signals, program_signals>: Replace
1187         pointer and length parameters with gdb::array_view.
1188         (target_pass_signals, target_program_signals): Likewise.
1189         * target-delegates.c: Regenerate.
1190
1191 2019-01-24  Pedro Alves  <palves@redhat.com>
1192
1193         * common/forward-scope-exit.h
1194         (forward_scope_exit::forward_scope_exit): Pass arguments to
1195         m_bind_function directly, instead of creating a std::bind and
1196         copying that.
1197
1198 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1199
1200         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1201         for static members.
1202         (pass_in_v_vfp_candidate): Likewise.
1203
1204 2019-01-23  Tom Tromey  <tom@tromey.com>
1205             Pedro Alves  <palves@redhat.com>
1206
1207         * regcache.c (class regcache_invalidator): Remove.
1208         (regcache::raw_write): Use make_scope_exit.
1209
1210 2019-01-23  Tom Tromey  <tom@tromey.com>
1211
1212         * ui-out.h (class ui_out_emit_type): Update comment.
1213
1214 2019-01-23  Tom Tromey  <tom@tromey.com>
1215
1216         * infrun.c (fetch_inferior_event): Update comment.
1217
1218 2019-01-23  Tom Tromey  <tom@tromey.com>
1219             Pedro Alves  <palves@redhat.com>
1220
1221         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1222         parameter.
1223         (fetch_inferior_event): Use SCOPE_EXIT.
1224
1225
1226 2019-01-23  Tom Tromey  <tom@tromey.com>
1227             Pedro Alves  <palves@redhat.com>
1228
1229         * infrun.c (disable_thread_events): Delete.
1230         (stop_all_threads): Use SCOPE_EXIT.
1231
1232 2019-01-23  Tom Tromey  <tom@tromey.com>
1233             Pedro Alves  <palves@redhat.com>
1234
1235         * symfile.c: Include forward-scope-exit.h.
1236         (clear_symtab_users_cleanup): Replace forward declaration with
1237         a FORWARD_SCOPE_EXIT.
1238         (syms_from_objfile_1): Use the forward_scope_exit and
1239         gdb::optional instead of cleanup_function.
1240         (reread_symbols): Use the forward_scope_exit instead of
1241         cleanup_function.
1242         (clear_symtab_users_cleanup): Remove function.
1243
1244 2019-01-23  Tom Tromey  <tom@tromey.com>
1245             Pedro Alves  <palves@redhat.com>
1246
1247         * linux-nat.c: Include scope-exit.h.
1248         (cleanup_target_stop): Remove.
1249         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1250         SCOPE_EXIT.
1251
1252 2019-01-23  Tom Tromey  <tom@tromey.com>
1253             Pedro Alves  <palves@redhat.com>
1254
1255         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1256         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1257
1258 2019-01-23  Tom Tromey  <tom@tromey.com>
1259             Andrew Burgess  <andrew.burgess@embecosm.com>
1260             Pedro Alves  <palves@redhat.com>
1261
1262         * infrun.c (fetch_inferior_event): Use scope_exit.
1263         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1264         * top.c (execute_command): Use scope_exit.
1265         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1266         * utils.c (do_bpstat_clear_actions_cleanup)
1267         (make_bpstat_clear_actions_cleanup): Remove.
1268
1269 2019-01-23  Tom Tromey  <tom@tromey.com>
1270             Pedro Alves  <palves@redhat.com>
1271
1272         * infrun.c: Include "common/scope-exit.h"
1273         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1274         (wait_for_inferior): Use SCOPE_EXIT.
1275         (fetch_inferior_event): Use scope_exit.
1276
1277 2019-01-23  Tom Tromey  <tom@tromey.com>
1278             Pedro Alves  <palves@redhat.com>
1279
1280         * breakpoint.c (create_breakpoint): Remove cleanup.
1281
1282 2019-01-23  Tom Tromey  <tom@tromey.com>
1283             Andrew Burgess  <andrew.burgess@embecosm.com>
1284             Pedro Alves  <palves@redhat.com>
1285
1286 2019-01-23  Pedro Alves  <palves@redhat.com>
1287
1288         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1289
1290 2019-01-23  Pedro Alves  <palves@redhat.com>
1291             Andrew Burgess  <andrew.burgess@embecosm.com>
1292
1293         * gdbthread.h: Include "common/forward-scope-exit.h".
1294         (scoped_finish_thread_state): Redefine custom class in terms of
1295         forward_scope_exit.
1296
1297 2019-01-23  Pedro Alves  <palves@redhat.com>
1298             Andrew Burgess  <andrew.burgess@embecosm.com>
1299
1300         * common/forward-scope-exit.h: New file.
1301
1302 2019-01-23  Pedro Alves  <palves@redhat.com>
1303             Andrew Burgess  <andrew.burgess@embecosm.com>
1304             Tom Tromey  <tom@tromey.com>
1305
1306         * common/scope-exit.h: New file.
1307
1308 2019-01-23  Pedro Alves  <palves@redhat.com>
1309
1310         * common/preprocessor.h (ESC): Rename to ...
1311         (ESC_PARENS): ... this.
1312         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1313         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1314
1315 2019-01-23  Tom Tromey  <tom@tromey.com>
1316
1317         * language.h (class scoped_switch_to_sym_language_if_auto):
1318         Initialize m_lang in both cases.
1319
1320 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1321
1322         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1323         with XCNEW.
1324
1325 2019-01-22  Tom Tromey  <tom@tromey.com>
1326
1327         * corelow.c: Do not include sys/file.h.
1328
1329 2019-01-22  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-wingeneral.h: Include gdb_curses.h.
1332
1333 2019-01-22  Tom Tromey  <tom@tromey.com>
1334
1335         * source-cache.h (class source_cache) <get_source_lines,
1336         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1337
1338 2019-01-22  Tom Tromey  <tom@tromey.com>
1339
1340         * remote-fileio.h (struct remote_target): Declare.
1341
1342 2019-01-22  Tom Tromey  <tom@tromey.com>
1343
1344         * python/py-arch.c: Do not include py-ref.h.
1345         * python/py-bpevent.c: Do not include py-ref.h.
1346         * python/py-cmd.c: Do not include py-ref.h.
1347         * python/py-continueevent.c: Do not include py-ref.h.
1348         * python/py-event.h: Do not include py-ref.h.
1349         * python/py-evtregistry.c: Do not include py-ref.h.
1350         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1351         * python/py-frame.c: Do not include py-ref.h.
1352         * python/py-framefilter.c: Do not include py-ref.h.
1353         * python/py-function.c: Do not include py-ref.h.
1354         * python/py-infevents.c: Do not include py-ref.h.
1355         * python/py-linetable.c: Do not include py-ref.h.
1356         * python/py-objfile.c: Do not include py-ref.h.
1357         * python/py-param.c: Do not include py-ref.h.
1358         * python/py-prettyprint.c: Do not include py-ref.h.
1359         * python/py-progspace.c: Do not include py-ref.h.
1360         * python/py-symbol.c: Do not include py-ref.h.
1361         * python/py-symtab.c: Do not include py-ref.h.
1362         * python/py-type.c: Do not include py-ref.h.
1363         * python/py-unwind.c: Do not include py-ref.h.
1364         * python/py-utils.c: Do not include py-ref.h.
1365         * python/py-value.c: Do not include py-ref.h.
1366         * python/py-varobj.c: Do not include py-ref.h.
1367         * python/py-xmethods.c: Do not include py-ref.h.
1368         * python/python.c: Do not include py-ref.h.
1369         * varobj.c: Do not include py-ref.h.
1370
1371 2019-01-22  Tom Tromey  <tom@tromey.com>
1372
1373         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1374         keyword for bcache.
1375
1376 2019-01-22  Tom Tromey  <tom@tromey.com>
1377
1378         * compile/compile-cplus-types.c: Remove a comment by #include.
1379
1380 2019-01-22  Tom Tromey  <tom@tromey.com>
1381
1382         * compile/gcc-c-plugin.h: Include compile-internal.h.
1383
1384 2019-01-22  Tom Tromey  <tom@tromey.com>
1385
1386         * stabsread.c (EXTERN): Do not define.
1387         (symnum, next_symbol_text_func, processing_gcc_compilation)
1388         (within_function, global_sym_chain, global_stabs)
1389         (previous_stab_code, this_object_header_files)
1390         (n_this_object_header_files)
1391         (n_allocated_this_object_header_files): Define.
1392         * stabsread.h (EXTERN): Never define.  Use "extern".
1393
1394 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1395
1396         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1397         history_value.
1398
1399 2019-01-21  Tom Tromey  <tom@tromey.com>
1400
1401         * ui-out.c: Fix includes.
1402         * tui/tui-source.c: Fix includes.
1403         * target.c: Fix includes.
1404         * remote.c: Fix includes.
1405         * regcache.c: Fix includes.
1406         * python/py-block.c: Fix includes.
1407         * printcmd.c: Fix includes.
1408         * or1k-tdep.c: Fix includes.
1409         * mi/mi-main.c: Fix includes.
1410         * m32r-tdep.c: Fix includes.
1411         * csky-tdep.c: Fix includes.
1412         * compile/compile-cplus-types.c: Fix includes.
1413         * cli/cli-interp.c: Fix includes.
1414
1415 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1416
1417         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1418         for padding.
1419
1420 2019-01-16  Tom Tromey  <tom@tromey.com>
1421
1422         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1423         earlier.
1424         (struct objfile) <msymbols_range>: Move from top level.
1425         <msymbols>: New method.
1426         (class objfile_msymbols): Remove.
1427         * symtab.c (default_collect_symbol_completion_matches_break_on):
1428         Update.
1429         * symmisc.c (dump_msymbols): Update.
1430         * stabsread.c (scan_file_globals): Update.
1431         * objc-lang.c (info_selectors_command, info_classes_command)
1432         (find_methods): Update.
1433         * minsyms.c (find_solib_trampoline_target): Update.
1434         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1435         * coffread.c (coff_symfile_read): Update.
1436         * ada-lang.c (ada_lookup_simple_minsym)
1437         (ada_collect_symbol_completion_matches): Update.
1438
1439 2019-01-16  Tom Tromey  <tom@tromey.com>
1440
1441         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1442         type.  Remove no-argument constructor.
1443         <iterator::operator++>: Simplify.
1444         <begin>: Update.
1445         <end>: Use minimal_symbol_count.
1446
1447 2019-01-16  Tom Tromey  <tom@tromey.com>
1448
1449         * objfiles.h (struct objfile) <psymtabs>: New method.
1450         (class objfile_psymtabs): Remove.
1451         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1452         typedef.
1453         <range>: New method.
1454         (require_partial_symbols): Change return type.
1455         * psymtab.c (require_partial_symbols)
1456         (psym_expand_symtabs_matching): Update.
1457         * mdebugread.c (parse_partial_symbols): Update.
1458         * dbxread.c (dbx_end_psymtab): Update.
1459
1460 2019-01-15  Tom Tromey  <tom@tromey.com>
1461
1462         * symtab.c (lookup_objfile_from_block)
1463         (lookup_symbol_in_objfile_symtabs)
1464         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1465         (find_line_symtab, info_sources_command)
1466         (default_collect_symbol_completion_matches_break_on)
1467         (make_source_files_completion_list): Update.
1468         * symmisc.c (print_objfile_statistics, dump_objfile)
1469         (maintenance_print_symbols, maintenance_info_symtabs)
1470         (maintenance_check_symtabs, maintenance_info_line_tables):
1471         Update.
1472         * source.c (select_source_symtab)
1473         (forget_cached_source_info_for_objfile): Update.
1474         * objfiles.h (class objfile_compunits): Remove.
1475         (struct objfile) <compunits_range>: New typedef.
1476         (compunits): New method.
1477         * objfiles.c (objfile_relocate1): Update.
1478         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1479         * maint.c (count_symtabs_and_blocks): Update.
1480         * linespec.c (iterate_over_all_matching_symtabs): Update.
1481         * cp-support.c (add_symbol_overload_list_qualified): Update.
1482         * coffread.c (coff_symtab_read): Update.
1483         * ada-lang.c (add_nonlocal_symbols)
1484         (ada_collect_symbol_completion_matches)
1485         (ada_add_global_exceptions): Update.
1486
1487 2019-01-15  Tom Tromey  <tom@tromey.com>
1488
1489         * progspace.h (program_space) <objfiles_safe_range>: New
1490         typedef.
1491         <objfiles_safe>: New method.
1492         * objfiles.h (class all_objfiles_safe): Remove.
1493         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1494         * jit.c (jit_inferior_exit_hook): Update.
1495
1496 2019-01-17  Tom Tromey  <tom@tromey.com>
1497
1498         * progspace.h (program_space) <objfiles_range>: New typedef.
1499         <objfiles>: New method.
1500         <objfiles_head>: Rename from objfiles.
1501         (object_files): Update.
1502         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1503         * guile/scm-pretty-print.c
1504         (ppscm_find_pretty_printer_from_objfiles): Update.
1505         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1506         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1507         Update.
1508         * python/py-progspace.c (pspy_get_objfiles): Update.
1509         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1510         Update.
1511         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1512         (objfpy_lookup_objfile_by_build_id): Update.
1513         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1514         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1515         Update.
1516         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1517         (expand_symtab_containing_pc, lookup_objfile_from_block)
1518         (lookup_static_symbol, basic_lookup_transparent_type)
1519         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1520         (find_line_symtab, info_sources_command)
1521         (default_collect_symbol_completion_matches_break_on)
1522         (make_source_files_completion_list, find_main_name): Update.
1523         * symmisc.c (print_symbol_bcache_statistics)
1524         (print_objfile_statistics, maintenance_print_symbols)
1525         (maintenance_print_msymbols, maintenance_print_objfiles)
1526         (maintenance_info_symtabs, maintenance_check_symtabs)
1527         (maintenance_expand_symtabs, maintenance_info_line_tables):
1528         Update.
1529         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1530         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1531         (map_overlay_command, unmap_overlay_command)
1532         (simple_overlay_update, expand_symtabs_matching)
1533         (map_symbol_filenames): Update.
1534         * symfile-debug.c (set_debug_symfile): Update.
1535         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1536         Update.
1537         * source.c (select_source_symtab, forget_cached_source_info):
1538         Update.
1539         * solib.c (solib_read_symbols): Update.
1540         * solib-spu.c (append_ocl_sos): Update.
1541         * psymtab.c (maintenance_print_psymbols)
1542         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1543         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1544         * printcmd.c (info_symbol_command): Update.
1545         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1546         Update.
1547         * objfiles.h (class all_objfiles): Remove.
1548         * objfiles.c (have_partial_symbols, have_full_symbols)
1549         (have_minimal_symbols, qsort_cmp, update_section_map)
1550         (shared_objfile_contains_address_p)
1551         (default_iterate_over_objfiles_in_search_order): Update.
1552         * objc-lang.c (info_selectors_command, info_classes_command)
1553         (find_methods): Update.
1554         * minsyms.c (find_solib_trampoline_target): Update.
1555         * maint.c (maintenance_info_sections)
1556         (maintenance_translate_address, count_symtabs_and_blocks):
1557         Update.
1558         * main.c (captured_main_1): Update.
1559         * linux-thread-db.c (try_thread_db_load_from_pdir)
1560         (has_libpthread): Update.
1561         * linespec.c (iterate_over_all_matching_symtabs)
1562         (search_minsyms_for_name): Update.
1563         * jit.c (jit_find_objf_with_entry_addr): Update.
1564         * hppa-tdep.c (find_unwind_entry)
1565         (hppa_lookup_stub_minimal_symbol): Update.
1566         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1567         Update.
1568         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1569         (elf_gnu_ifunc_resolve_by_got): Update.
1570         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1571         * dwarf-index-write.c (save_gdb_index_command): Update.
1572         * cp-support.c (add_symbol_overload_list_qualified): Update.
1573         * breakpoint.c (create_overlay_event_breakpoint)
1574         (create_longjmp_master_breakpoint)
1575         (create_std_terminate_master_breakpoint)
1576         (create_exception_master_breakpoint): Update.
1577         * blockframe.c (find_pc_partial_function): Update.
1578         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1579         (ada_collect_symbol_completion_matches)
1580         (ada_add_global_exceptions): Update.
1581
1582 2019-01-17  Tom Tromey  <tom@tromey.com>
1583
1584         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1585         declare VEC.
1586         (solib_target_parse_libraries): Change return type.
1587         (library_list_start_segment, library_list_start_section)
1588         (library_list_end_library, library_list_start_library); Update.
1589         (solib_target_free_library_list): Remove.
1590         (solib_target_parse_libraries): Remove cleanup.  Change return
1591         type.
1592         (solib_target_current_sos): Update.
1593
1594 2019-01-17  Tom Tromey  <tromey@bapiya>
1595
1596         * valprint.c: Replace "the the" with "the".
1597         * symtab.c: Replace "the the" with "the".
1598         * solib.c: Replace "the the" with "the".
1599         * solib-dsbt.c: Replace "the the" with "the".
1600         * linespec.c: Replace "the the" with "the".
1601         * dwarf2loc.h: Replace "the the" with "the".
1602         * amd64-windows-tdep.c: Replace "the the" with "the".
1603         * aarch64-tdep.c: Replace "the the" with "the".
1604
1605 2019-01-16  Keith Seitz  <keiths@redhat.com>
1606
1607         PR gdb/23773
1608         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1609         <builder>: Rename to ..
1610         <m_builder>: ... this and make private.
1611         (dwarf2_cu::get_builder): New method.  Change all users of
1612         `builder' to use this method.
1613         (dwarf2_start_symtab): Move to ...
1614         (dwarf2_cu::start_symtab): ... here.  Update all callers
1615         (setup_type_unit_groups): Move to ...
1616         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1617         callers.
1618         (dwarf2_cu::reset_builder): New method.
1619         (process_full_compunit, process_full_type_unit): Use
1620         dwarf2_cu::reset_builder.
1621         (follow_die_offset): Record the ancestor CU if it is different
1622         from the followed DIE's CU.
1623         (follow_die_sig_1): Likewise.
1624
1625 2019-01-15  Tom Tromey  <tom@tromey.com>
1626
1627         * remote.c (class remote_state) <buf>: Now a char_vector.
1628         <buf_size>: Remove.
1629         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1630         parameter.
1631         (remote_target::getpkt_or_notif_sane_1)
1632         (remote_target::getpkt_sane)
1633         (remote_target::getpkt_or_notif_sane): Likewise.
1634         (class remote_target) <putpkt>: New overload.
1635         (remote_target::read_frame): Change type of "buf_p".  Remove
1636         sizeof_p parameter.
1637         (packet_ok): New overload.
1638         (packet_check_result): New overload.
1639         Update all uses.
1640
1641 2019-01-14  Tom Tromey  <tom@tromey.com>
1642
1643         * remote-notif.c (handle_notification, remote_notif_ack)
1644         (remote_notif_parse): Make "buf" const.
1645         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1646         const.
1647         (remote_notif_parse, remote_notif_ack, handle_notification):
1648         Likewise.
1649         * remote.c (remote_notif_stop_parse): Make "buf" const.
1650         (remote_target::remote_parse_stop_reply): Make "buf" const.
1651         (remote_notif_stop_ack): Make "buf" const.
1652
1653 2019-01-14  Tom Tromey  <tom@tromey.com>
1654
1655         * remote.c (remote_console_output): Make parameter const.
1656
1657 2019-01-14  Tom Tromey  <tom@tromey.com>
1658
1659         * target-debug.h (target_debug_print_signals): Constify.
1660         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1661         * procfs.c (procfs_target::pass_signals): Update.
1662         * linux-nat.c (linux_nat_target::pass_signals): Update.
1663         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1664         * target-delegates.c: Rebuild.
1665         * remote.c (remote_target::program_signals): Update.
1666         (remote_target::pass_signals): Update.
1667         * target.c (target_pass_signals): Constify argument.
1668         (target_program_signals): Likewise.
1669         * target.h (struct target_ops) <pass_signals, program_signals>:
1670         Constify argument.
1671         (target_pass_signals, target_program_signals): Constify argument.
1672
1673 2019-01-14  Tom Tromey  <tom@tromey.com>
1674
1675         PR tui/28819:
1676         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1677
1678 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1679
1680         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1681         field.
1682         * rs6000-tdep.c: Include reggroups.h.
1683         (IS_V_ALIAS_PSEUDOREG): Define.
1684         (rs6000_register_name): Return names for the "vX" aliases.
1685         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1686         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1687         aliases.  Call default_register_reggroup_p for all other
1688         pseudo-registers.
1689         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1690         New functions.
1691         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1692         Handle "vX" aliases.
1693         (v_alias_pseudo_register_collect): New function.
1694         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1695         (rs6000_gdbarch_init): Initialize "vX" aliases as
1696         pseudo-registers.  Restore registration of
1697         rs6000_pseudo_register_reggroup_p with
1698         set_tdesc_pseudo_register_reggroup_p.
1699
1700 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1701
1702         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1703         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1704         set_gdbarch_num_pseudo_regs.
1705
1706 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1707
1708         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1709         Remove arg prefixname, add do_set and do_show.
1710         Add member functions set_list and show_list.
1711         * cli/cli-style.c (class cli_style_option): Update accordingly.
1712         (style_set_list): Move to file scope.
1713         (style_show_list): Likewise.
1714         (set_style): Call help_list.
1715         (show_style): Call cmd_show_list.
1716         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1717         Update to use the new macro.
1718
1719 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1720
1721         * ada-lang.c (_initialize_ada_language): Expand the help text
1722         for the "catch exception" command.
1723
1724 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1725
1726         * symtab.c (matching_obj_sections): Initialize obj,
1727         declare it closer to its usage.
1728
1729 2019-01-10  Tom Tromey  <tom@tromey.com>
1730
1731         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1732         (basic_inf_threads_range): Remove.
1733         (inf_threads_range, inf_non_exited_threads_range)
1734         (safe_inf_threads_range): Use next_adapter.
1735
1736 2019-01-10  Keith Seitz  <keiths@redhat.com>
1737
1738         PR gdb/23712
1739         PR symtab/23010
1740         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1741         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1742
1743 2019-01-10  Keith Seitz  <keiths@redhat.com>
1744
1745         PR gdb/23712
1746         PR symtab/23010
1747         * dictionary.c (pending_to_vector): Remove.
1748         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1749         Remove _1 suffix, replacing functions of the same name.  Update
1750         all callers.
1751         (dict_create_hashed, dict_create_hashed_expandable)
1752         (dict_create_linear, dict_create_linear_expandable, dict_free)
1753         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1754         Make functions static.
1755
1756 2019-01-10  Keith Seitz  <keiths@redhat.com>
1757
1758         PR gdb/23712
1759         PR symtab/23010
1760         * dictionary.h (struct dictionary): Replace declaration with
1761         multidictionary.
1762         (dict_create_hashed, dict_create_hashed_expandable)
1763         (dict_create_linear, dict_create_linear_expandable)
1764         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1765         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1766         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1767         taking multidictionary argument.
1768         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1769         * block.h (struct block) <dict>: Change to multidictionary
1770         and rename `multidict'.
1771         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1772         symmisc.c: Update all dictionary references to multidictionary.
1773
1774 2019-01-10  Keith Seitz  <keiths@redhat.com>
1775
1776         PR gdb/23712
1777         PR symtab/23010
1778         * dictionary.c: Include unordered_map.
1779         (pending_to_vector): New function.
1780         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1781         Rewrite the non-"_1" functions to take vector instead
1782         of linked list.
1783         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1784         "new" _1 versions of the same name.
1785         (multidictionary): Define.
1786         (std::hash<enum language): New definition.
1787         (collate_pending_symbols_by_language, mdict_create_hashed)
1788         (mdict_create_hashed_expandable, mdict_create_linear)
1789         (mdict_create_linear_expandable, mdict_free)
1790         (find_language_dictionary, create_new_language_dictionary)
1791         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1792         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1793         (mdict_size, mdict_empty): New functions.
1794         * dictionary.h (mdict_iterator): Define.
1795
1796 2019-01-10  Pedro Alves  <palves@redhat.com>
1797
1798         * breakpoint.c (read_uploaded_action)
1799         (create_tracepoint_from_upload): Adjust to use
1800         gdb::unique_xmalloc_ptr.
1801         * ctf.c (ctf_write_uploaded_tp):
1802         (SET_ARRAY_FIELD): Use emplace_back.
1803         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1804         * tracefile-tfile.c (tfile_write_uploaded_tp):
1805         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1806         gdb::unique_xmalloc_ptr.
1807         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1808         at_string, cond_string, cmd_strings>: Replace char pointers
1809         with gdb::unique_xmalloc_ptr.
1810
1811 2019-01-10  Pedro Alves  <palves@redhat.com>
1812
1813         * solib-target.c (library_list_start_library): Don't xstrdup name.
1814
1815 2019-01-10  Pedro Alves  <palves@redhat.com>
1816
1817         * mdebugread.c (parse_partial_symbols): Use
1818         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1819
1820 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1821
1822         * linux-fork.c (scoped_switch_fork_info)
1823         <~scoped_switch_fork_info>: Fix incorrect variable name.
1824
1825 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1826
1827         * linux-fork.c (scoped_switch_fork_info)
1828         <scoped_switch_fork_info>: Make explicit.
1829         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1830
1831 2019-01-10  Tom Tromey  <tom@tromey.com>
1832
1833         * objfiles.h (objfile::reset_psymtabs): Update.
1834         * objfiles.c (objfile::objfile): Update.
1835         * psymtab.h (psymtab_storage::obstack): Update.
1836         (psymtab_storage::m_obstack): Use gdb::optional.
1837         (class psymtab_storage): Update comment.  Remove objfile
1838         parameter.
1839         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1840
1841 2019-01-10  Tom Tromey  <tom@tromey.com>
1842
1843         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1844         <free_psymtabs>: Now private.
1845         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1846         (allocate_psymtab): Use new method.
1847
1848 2019-01-10  Tom Tromey  <tom@tromey.com>
1849
1850         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1851         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1852         * mdebugread.c (parse_partial_symbols): Use
1853         allocate_dependencies.
1854         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1855         allocate_dependencies.
1856         (process_psymtab_comp_unit_reader)
1857         (build_type_psymtab_dependencies): Likewise.
1858         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1859
1860 2019-01-10  Tom Tromey  <tom@tromey.com>
1861
1862         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1863         PSYMBOL_SET_LANGUAGE.
1864         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1865
1866 2019-01-10  Tom Tromey  <tom@tromey.com>
1867
1868         * psymtab.h (psymtab_storage::obstack): New method.
1869         <m_obstack>: Rename from obstack; now private.
1870         * psymtab.c (psymtab_storage): Update.
1871         * dwarf2read.c (create_addrmap_from_index)
1872         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1873         Update.
1874
1875 2019-01-10  Tom Tromey  <tom@tromey.com>
1876
1877         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1878         * objfiles.h (objfile::reset_psymtabs): New method.
1879
1880 2019-01-10  Tom Tromey  <tom@tromey.com>
1881
1882         * symmisc.c (print_symbol_bcache_statistics): Update.
1883         (print_objfile_statistics): Update.
1884         * symfile.c (reread_symbols): Update.
1885         * psymtab.h (class psymtab_storage): New.
1886         * psymtab.c (psymtab_storage): New constructor.
1887         (~psymtab_storage): New destructor.
1888         (require_partial_symbols): Update.
1889         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1890         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1891         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1892         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1893         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1894         (start_psymtab_common, end_psymtab_common)
1895         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1896         (allocate_psymtab): Update.
1897         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1898         Update.
1899         (dump_psymtab_addrmap, maintenance_print_psymbols)
1900         (maintenance_check_psymtabs): Update.
1901         (class objfile_psymtabs): Move to objfiles.h.
1902         * psympriv.h (discard_psymtab): Now inline.
1903         (psymtab_discarder::psymtab_discarder): Update.
1904         (psymtab_discarder::~psymtab_discarder): Update.
1905         (ALL_OBJFILE_PSYMTABS): Rewrite.
1906         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1907         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1908         Remove fields.
1909         <partial_symtabs>: New field.
1910         (class objfile_psymtabs): Move from psymtab.h.  Update.
1911         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1912         psymbol_cache.
1913         (objfile::~objfile): Don't destroy psymbol_cache.
1914         * mdebugread.c (parse_partial_symbols): Update.
1915         * dwarf2read.c (create_addrmap_from_index)
1916         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1917         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1918         (add_partial_subprogram, dwarf2_ranges_read): Update.
1919         * dwarf-index-write.c (write_address_map)
1920         (write_one_signatured_type, recursively_write_psymbols)
1921         (class debug_names, class debug_names, write_psymtabs_to_index):
1922         Update.
1923
1924 2019-01-10  Tom Tromey  <tom@tromey.com>
1925
1926         * symtab.h (SYMBOL_SET_NAMES): Update.
1927         (symbol_set_names): Update.
1928         (MSYMBOL_SET_NAMES): Update.
1929         * symtab.c (symbol_set_names): Change argument to be an
1930         objfile_per_bfd_storage.
1931         * psymtab.c (add_psymbol_to_bcache): Update.
1932         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1933
1934 2019-01-10  Tom Tromey  <tom@tromey.com>
1935
1936         * symtab.c (create_demangled_names_hash): Change argument to be an
1937         objfile_per_bfd_storage.
1938         (symbol_set_names): Update.
1939
1940 2019-01-10  Tom Tromey  <tom@tromey.com>
1941
1942         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1943         init_psymbol_list.
1944         * psymtab.c (init_psymbol_list): Do nothing if already called.
1945         * psympriv.h (init_psymbol_list): Add comment.
1946         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1947         init_psymbol_list.
1948         * dbxread.c (dbx_symfile_read): Unconditionally call
1949         init_psymbol_list.
1950
1951 2019-01-10  Tom Tromey  <tom@tromey.com>
1952
1953         * xcoffread.c (scan_xcoff_symtab): Update.
1954         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1955         "where".
1956         * mdebugread.c (parse_partial_symbols)
1957         (handle_psymbol_enumerators): Update.
1958         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1959         * dbxread.c (read_dbx_symtab): Update.
1960         * psympriv.h (psymbol_placement): New enum.
1961         (add_psymbol_to_list): Update.
1962
1963 2019-01-10  Tom Tromey  <tom@tromey.com>
1964
1965         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1966         static_psymbols parameters.
1967         (scan_xcoff_symtab): Update.
1968         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1969         static_psymbols parameters.
1970         * psympriv.h (start_psymtab_common): Update.
1971         * mdebugread.c (parse_partial_symbols): Update.
1972         * dwarf2read.c (create_partial_symtab): Update.
1973         * dbxread.c (read_dbx_symtab): Update.
1974         (start_psymtab): Remove global_psymbols and static_psymbols
1975         parameters.
1976
1977 2019-01-10  Tom Tromey  <tom@tromey.com>
1978
1979         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1980         * psymtab.c (allocate_psymtab): Add comment.
1981         * psympriv.h (allocate_psymtab): Add comment.
1982         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1983         initializations.
1984         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1985
1986 2019-01-10  Tom Tromey  <tom@tromey.com>
1987
1988         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1989         Don't declare.
1990         * mipsread.c: Include mdebugread.h.
1991         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1992         Declare.
1993         * elfread.c: Include mdebugread.h.
1994
1995 2019-01-09  Tom Tromey  <tom@tromey.com>
1996
1997         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1998         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1999         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2000         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2001         (psym_lookup_symbol, psym_find_last_source_symtab)
2002         (psym_forget_cached_source_info, psym_print_stats)
2003         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2004         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2005         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2006         (psym_find_compunit_symtab_by_address)
2007         (maintenance_print_psymbols, maintenance_info_psymtabs)
2008         (maintenance_check_psymtabs): Use ranged for.
2009         * psymtab.h (class objfile_psymtabs): New.
2010         (require_partial_symbols): Return objfile_psymtabs.
2011         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2012
2013 2019-01-09  Tom Tromey  <tom@tromey.com>
2014
2015         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2016         (find_pc_mapped_section, list_overlays_command)
2017         (map_overlay_command, unmap_overlay_command)
2018         (simple_overlay_update): Use all_objfiles.
2019         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2020         * printcmd.c (info_symbol_command): Use all_objfiles.
2021         * objfiles.h (ALL_OBJSECTIONS): Remove.
2022         * maint.c (maintenance_translate_address): Use all_objfiles.
2023         * gcore.c (gcore_create_callback): Use all_objfiles.
2024         (objfile_find_memory_regions): Likewise.
2025
2026 2019-01-09  Tom Tromey  <tom@tromey.com>
2027
2028         * symtab.c (find_line_symtab, info_sources_command)
2029         (make_source_files_completion_list): Use objfile_compunits.
2030         * source.c (select_source_symtab): Use objfile_compunits.
2031         * objfiles.h (struct objfile): Update comment.
2032         (ALL_OBJFILES): Remove.
2033         (ALL_FILETABS): Remove.
2034         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2035         objfile_compunits.
2036
2037 2019-01-09  Tom Tromey  <tom@tromey.com>
2038
2039         * symmisc.c (print_objfile_statistics, dump_objfile)
2040         (maintenance_print_symbols): Use compunit_filetabs.
2041         * source.c (forget_cached_source_info_for_objfile): Use
2042         compunit_filetabs.
2043         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2044         (ALL_FILETABS): Use compunit_filetabs.
2045         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2046         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2047
2048 2019-01-09  Tom Tromey  <tom@tromey.com>
2049
2050         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2051         (compunit_filetabs): New.
2052         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2053         compunit_filetabs.
2054         (info_sources_command, make_source_files_completion_list): Remove
2055         declaration.
2056         * symmisc.c (print_objfile_statistics, dump_objfile)
2057         (maintenance_print_symbols): Remove declaration.
2058         (maintenance_info_symtabs): Use compunit_filetabs.
2059         (maintenance_info_line_tables): Likewise.
2060         * source.c (select_source_symtab): Change local variable name.
2061         (forget_cached_source_info_for_objfile): Remove declaration.
2062         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2063         * objfiles.c (objfile_relocate1): Remove declaration.
2064         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2065         declaration.
2066         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2067         * coffread.c (coff_symtab_read): Remove declaration.
2068         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2069         compunit_filetabs.
2070
2071 2019-01-09  Tom Tromey  <tom@tromey.com>
2072
2073         * symtab.c (lookup_objfile_from_block)
2074         (find_pc_sect_compunit_symtab, search_symbols)
2075         (default_collect_symbol_completion_matches_break_on): Use
2076         objfile_compunits.
2077         * objfiles.h (ALL_COMPUNITS): Remove.
2078         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2079         * cp-support.c (add_symbol_overload_list_qualified): Use
2080         objfile_compunits.
2081         * ada-lang.c (ada_collect_symbol_completion_matches)
2082         (ada_add_global_exceptions): Use objfile_compunits.
2083
2084 2019-01-09  Tom Tromey  <tom@tromey.com>
2085
2086         * source.c (select_source_symtab)
2087         (forget_cached_source_info_for_objfile): Remove declaration.
2088         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2089         declaration.
2090         * maint.c (count_symtabs_and_blocks): Remove declaration.
2091         * cp-support.c (add_symbol_overload_list_qualified): Remove
2092         declaration.
2093         * coffread.c (coff_symtab_read): Remove declaration.
2094         * symtab.c (lookup_symbol_in_objfile_symtabs)
2095         (basic_lookup_transparent_type_1): Use objfile_compunits.
2096         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2097         (info_sources_command, search_symbols)
2098         (default_collect_symbol_completion_matches_break_on)
2099         (make_source_files_completion_list): Remove declaration.
2100         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2101         (ada_collect_symbol_completion_matches)
2102         (ada_add_global_exceptions): Remove declaration.
2103         * linespec.c (iterate_over_all_matching_symtabs): Use
2104         objfile_compunits.
2105         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2106         (class objfile_compunits): New.
2107         (ALL_COMPUNITS): Use objfile_compunits.
2108         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2109         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2110         objfile_compunits.
2111         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2112
2113 2019-01-09  Tom Tromey  <tom@tromey.com>
2114
2115         * symtab.c (search_symbols)
2116         (default_collect_symbol_completion_matches_break_on): Use
2117         objfile_msymbols.
2118         * ada-lang.c (ada_lookup_simple_minsym)
2119         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2120         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2121         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2122         objfile_msymbols.
2123         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2124         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2125         * objc-lang.c (find_methods): Use objfile_msymbols.
2126         (info_selectors_command, info_classes_command): Likewise.
2127         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2128         * objfiles.h (class objfile_msymbols): New.
2129         (ALL_OBJFILE_MSYMBOLS): Remove.
2130         (ALL_MSYMBOLS): Remove.
2131
2132 2019-01-09  Tom Tromey  <tom@tromey.com>
2133
2134         * common/next-iterator.h (next_adapter): Add Iterator template
2135         parameter.
2136         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2137         (class all_objfiles_safe): New.
2138         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2139         * objfiles.c (put_objfile_before): Update comment.
2140         (add_separate_debug_objfile): Likewise.
2141         (free_all_objfiles): Use all_objfiles_safe.
2142         (objfile_purge_solibs): Likewise.
2143
2144 2019-01-09  Tom Tromey  <tom@tromey.com>
2145
2146         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2147         (expand_symtab_containing_pc, lookup_static_symbol)
2148         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2149         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2150         all_objfiles.
2151         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2152         * breakpoint.c (create_overlay_event_breakpoint)
2153         (create_longjmp_master_breakpoint)
2154         (create_std_terminate_master_breakpoint)
2155         (create_exception_master_breakpoint): Use all_objfiles.
2156         * linux-thread-db.c (try_thread_db_load_from_pdir)
2157         (has_libpthread): Use all_objfiles.
2158         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2159         * linespec.c (iterate_over_all_matching_symtabs)
2160         (search_minsyms_for_name): Use all_objfiles.
2161         * maint.c (maintenance_info_sections): Use all_objfiles.
2162         * main.c (captured_main_1): Use all_objfiles.
2163         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2164         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2165         * guile/scm-pretty-print.c
2166         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2167         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2168         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2169         (maintenance_print_msymbols): Use all_objfiles.
2170         * source.c (select_source_symtab): Use all_objfiles.
2171         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2172         * symfile.c (remove_symbol_file_command)
2173         (expand_symtabs_matching, map_symbol_filenames): Use
2174         all_objfiles.
2175         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2176         all_objfiles.
2177         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2178         * objc-lang.c (find_methods): Use all_objfiles.
2179         * objfiles.c (have_partial_symbols, have_full_symbols)
2180         (have_minimal_symbols, qsort_cmp)
2181         (default_iterate_over_objfiles_in_search_order): Use
2182         all_objfiles.
2183         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2184         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2185         (maintenance_check_psymtabs): Use all_objfiles.
2186         (ALL_PSYMTABS): Remove.
2187         * compile/compile-object-run.c (do_module_cleanup): Use
2188         all_objfiles.
2189         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2190         * cp-support.c (add_symbol_overload_list_qualified): Use
2191         all_objfiles.
2192         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2193         Use all_objfiles.
2194         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2195         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2196         all_objfiles.
2197         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2198         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2199         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2200         Uses all_objfiles.
2201         * solib.c (solib_read_symbols): Use all_objfiles
2202
2203 2019-01-09  Tom Tromey  <tom@tromey.com>
2204
2205         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2206         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2207         all_objfiles.
2208         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2209         * symmisc.c (print_symbol_bcache_statistics)
2210         (print_objfile_statistics, maintenance_print_objfiles)
2211         (maintenance_info_symtabs, maintenance_check_symtabs)
2212         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2213         all_objfiles.
2214         * source.c (forget_cached_source_info): Use all_objfiles.
2215         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2216         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2217         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2218         * objfiles.c (update_section_map): Use all_objfiles.
2219         (shared_objfile_contains_address_p): Likewise.
2220         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2221         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2222
2223 2019-01-09  Tom Tromey  <tom@tromey.com>
2224
2225         * common/next-iterator.h: New file.
2226         * objfiles.h (class all_objfiles): New.
2227         (struct objfile_iterator): New.
2228
2229 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2230
2231         * NEWS: Move the description of the changed "frame", "select-frame",
2232          and "info frame" commands to the Changed commands section.
2233
2234 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2235
2236         * gdbtypes.c (check_stub_method_group): Remove handling of old
2237         mangling schemes.
2238         * linespec.c (find_methods): Likewise.
2239         * stabsread.c (read_member_functions): Likewise.
2240         * valops.c (search_struct_method): Likewise.
2241         (value_struct_elt_for_reference): Likewise.
2242         * NEWS: Mention this change.
2243
2244 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2245
2246         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2247         print_source_lines.
2248         * source.c (print_source_lines_base): Update line number check.
2249         (print_source_lines): New function.
2250         (source_lines_range::source_lines_range): New function.
2251         * source.h (class source_lines_range): New class.
2252         (print_source_lines): New declaration.
2253
2254 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2255
2256         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2257
2258 2019-01-08  Tom Tromey  <tom@tromey.com>
2259             Simon Marchi  <simon.marchi@ericsson.com>
2260
2261         PR gdb/24060
2262         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2263         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2264         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2265         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2266         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2267         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2268
2269 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2270
2271         * source.c (select_source_symtab): Move header comment to
2272         declaration in source.h.
2273         (forget_cached_source_info_for_objfile): Likewise.
2274         (forget_cached_source_info): Likewise.
2275         (identify_source_line): Likewise.
2276         * source.h (identify_source_line): Move declaration from symtab.h
2277         and add comment from source.c
2278         (print_source_lines): Likewise.
2279         (forget_cached_source_info_for_objfile): Likewise.
2280         (forget_cached_source_info): Likewise.
2281         (select_source_symtab): Likewise.
2282         (enum print_source_lines_flag): Move definition from symtab.h.
2283         * symtab.h (identify_source_line): Move declaration to source.h.
2284         (print_source_lines): Likewise.
2285         (forget_cached_source_info_for_objfile): Likewise.
2286         (forget_cached_source_info): Likewise.
2287         (select_source_symtab): Likewise.
2288         (enum print_source_lines_flag): Move definition to source.h.
2289         * tui/tui-hooks.c: Add 'source.h' include.
2290
2291 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2292
2293         * source.c (print_source_lines_base): Handle requests to print
2294         reverse line number sequences, and guard against empty lines
2295         string.
2296
2297 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * source.c (print_source_lines_base): Fix skip of '\r' if next
2300         character is '\n'.
2301
2302 2019-01-06  Tom Tromey  <tom@tromey.com>
2303
2304         * c-exp.y (struct c_parse_state) <macro_original_text,
2305         expansion_obstack>: New member.
2306         (macro_original_text, expansion_obstack): Remove globals.
2307         (scan_macro_expansion, scanning_macro_expansion)
2308         (finished_macro_expansion): Update.
2309         (scan_macro_cleanup): Remove.
2310         (yylex, c_parse): Update.
2311
2312 2019-01-06  Tom Tromey  <tom@tromey.com>
2313
2314         * c-exp.y (struct c_parse_state) <strings>: New member.
2315         (operator_stoken): Update.
2316
2317 2019-01-06  Tom Tromey  <tom@tromey.com>
2318
2319         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2320         (union type_stack_elt) <typelist_val>: Now a pointer to
2321         std::vector.
2322         (type_stack_cleanup): Don't declare.
2323         (push_typelist): Update.
2324         * parse.c (pop_typelist): Return a std::vector.
2325         (push_typelist): Take a std::vector.
2326         (follow_types): Update.  Do not free args.
2327         (type_stack_cleanup): Remove.
2328         * c-exp.y (struct c_parse_state): New.
2329         (cpstate): New global.
2330         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2331         (nonempty_typelist): Update.
2332         (func_mod): Create a new vector.
2333         (c_parse): Create a c_parse_state.
2334         (check_parameter_typelist): Do not delete params.
2335         (function_method): Update.  Do not delete type_list.
2336
2337 2019-01-06  Tom Tromey  <tom@tromey.com>
2338
2339         PR gdb/28155:
2340         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2341         check_typedef.
2342         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2343         (print_return_value): Likewise.
2344
2345 2019-01-05  Tom Tromey  <tom@tromey.com>
2346
2347         * contrib/cleanup_check.py: Remove.
2348         * contrib/gcc-with-excheck: Remove.
2349         * contrib/exsummary.py: Remove.
2350         * contrib/excheck.py: Remove.
2351
2352 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2353
2354         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2355         NULL. Initialize tpprev to NULL instead of assigning it
2356         to NULL on the next statement.
2357         * windows-nat.c (windows_delete_thread): Remove check for
2358         main_thread_id before printing thread exit notifications.
2359         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2360         Remove thread ID check against main_thread_id.
2361         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2362         windows_delete_thread.
2363         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2364
2365 2019-01-04  Tom Tromey  <tom@tromey.com>
2366
2367         * compile/compile.c (_initialize_compile): Use upper case for
2368         metasyntactic variables.
2369         * symmisc.c (_initialize_symmisc): Use upper case for
2370         metasyntactic variables.
2371         * psymtab.c (_initialize_psymtab): Use upper case for
2372         metasyntactic variables.
2373         * demangle.c (demangle_command): Use upper case for metasyntactic
2374         variables.
2375         (_initialize_demangler): Likewise.
2376         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2377         variables.
2378
2379 2019-01-03  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2382
2383 2019-01-03  Tom Tromey  <tom@tromey.com>
2384
2385         * python/py-symtab.c (salpy_str): Update.
2386         (struct salpy_sal_object) <symtab>: Now a PyObject.
2387         (salpy_dealloc): Update.
2388         (del_objfile_sal): Use gdbpy_ref.
2389
2390 2019-01-03  Tom Tromey  <tom@tromey.com>
2391
2392         * python/py-type.c (convert_field): Use new_reference.  Return
2393         gdbpy_ref.
2394         (make_fielditem): Return gdbpy_ref.
2395         (typy_fields): Update.
2396         (typy_getitem): Update.
2397         (field_name): Return gdbpy_ref.  Use new_reference.
2398         (typy_iterator_iternext): Update.
2399
2400 2019-01-03  Tom Tromey  <tom@tromey.com>
2401
2402         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2403
2404 2019-01-03  Tom Tromey  <tom@tromey.com>
2405
2406         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2407         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2408         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2409         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2410         (pspy_set_type_printers): Likewise.
2411         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2412         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2413         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2414         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2415         (objfpy_set_type_printers): Likewise.
2416
2417 2019-01-03  Tom Tromey  <tom@tromey.com>
2418
2419         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2420         (gdbpy_print_stack): Use gdbpy_err_fetch.
2421         * python/python-internal.h (class gdbpy_err_fetch): New class.
2422         (class gdbpy_enter) <m_error_type, m_error_value,
2423         m_error_traceback>: Remove.
2424         <m_error>: New member.
2425         (gdbpy_exception_to_string): Don't declare.
2426         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2427         * python/py-value.c (convert_value_from_python): Use
2428         gdbpy_err_fetch.
2429         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2430         gdbpy_exception_to_string.
2431         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2432         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2433         gdbpy_err_fetch.
2434
2435 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * linux-nat.c (delete_lwp_cleanup): Delete.
2438         (struct lwp_deleter): New struct.
2439         (lwp_info_up): New typedef.
2440         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2441         lwp_info_up.
2442
2443 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2444
2445         * linux-fork.c (class scoped_switch_fork_info): New class.
2446         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2447
2448 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2449
2450         * valops.c (find_overload_match): Remove use of null_cleanup, and
2451         calls to do_cleanups.
2452
2453 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2454
2455         * compile/compile-cplus-types.c
2456         (compile_cplus_instance::decl_name): Handle changes to
2457         cp_func_name.
2458         * cp-support.c (cp_func_name): Update header comment, update
2459         return type.
2460         * cp-support.h (cp_func_name): Update return type in declaration.
2461         * valops.c (find_overload_match): Move temp_func local to top
2462         level of function and change its type.  Use temp_func to hold and
2463         delete temporary string obtained from cp_func_name.
2464
2465 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2466
2467         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2468         gdb::char_vector, remove cleanup, and update uses of `msg`.
2469
2470 2019-01-03  Jim Wilson  <jimw@sifive.com>
2471
2472         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2473
2474 2019-01-02  Tom Tromey  <tom@tromey.com>
2475
2476         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2477         (tdesc_parse_xml): Remove cleanups.
2478         * target-descriptions.h (make_cleanup_free_target_description):
2479         Don't declare.
2480         (target_desc_deleter): New struct.
2481         (target_desc_up): New typedef.
2482         * target-descriptions.c (target_desc_deleter::operator()): Rename
2483         from free_target_description.
2484         (make_cleanup_free_target_description): Remove.
2485
2486 2019-01-02  Tom Tromey  <tom@tromey.com>
2487
2488         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2489         constructor, destructor.
2490         (linespec_parser): Remove typedef.
2491         (~linespec_parser): Rename from linespec_parser_delete.
2492         (linespec_lex_to_end, linespec_complete_label)
2493         (linespec_complete): Update.
2494         (decode_line_full): Remove cleanups.
2495         (decode_line_1): Update.
2496
2497 2019-01-02  Tom Tromey  <tom@tromey.com>
2498
2499         * python/python-internal.h (inferior_to_inferior_object): Change
2500         return type.
2501         * python/py-exitedevent.c (create_exited_event_object): Update.
2502         * python/py-inferior.c (inferior_to_inferior_object): Return
2503         gdbpy_ref.
2504         (python_new_inferior, python_inferior_deleted)
2505         (thread_to_thread_object, delete_thread_object)
2506         (build_inferior_list, gdbpy_selected_inferior): Update.
2507         * python/py-infthread.c (create_thread_object): Update.  Also fail
2508         if inferior_to_inferior_object fails.
2509
2510 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2511
2512         * inferior.h (class inferior) <displaced_step_state>: New field.
2513         * infrun.h (struct displaced_step_state): Move here from
2514         infrun.c.  Initialize fields, add constructor.
2515         <inf>: Remove field.
2516         <reset>: New method.
2517         * infrun.c (struct displaced_step_inferior_state): Move to
2518         infrun.h.
2519         (displaced_step_inferior_states): Remove.
2520         (get_displaced_stepping_state): Adust.
2521         (displaced_step_in_progress_any_inferior): Adjust.
2522         (displaced_step_in_progress_thread): Adjust.
2523         (displaced_step_in_progress): Adjust.
2524         (add_displaced_stepping_state): Remove.
2525         (get_displaced_step_closure_by_addr): Adjust.
2526         (remove_displaced_stepping_state): Remove.
2527         (infrun_inferior_exit): Call displaced_step_state.reset.
2528         (use_displaced_stepping): Don't check for NULL.
2529         (displaced_step_prepare_throw): Call
2530         get_displaced_stepping_state.
2531         (displaced_step_fixup): Don't check for NULL.
2532         (prepare_for_detach): Don't check for NULL.
2533
2534 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2535
2536         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2537          in case of call that did not complete.
2538
2539 2019-01-02  Andrey Utkin  <autkin@undo.io>
2540
2541         * symfile.c (find_separate_debug_file): Fix search of debug files for
2542         remote debuggee.
2543
2544 2019-01-02  Tom Tromey  <tom@tromey.com>
2545
2546         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2547         indentation.
2548         * python/py-frame.c (frapy_older): Remove cast.
2549         (frapy_newer): Likewise.
2550         * python/py-breakpoint.c (local_setattro): Remove cast.
2551         * python/py-arch.c (archpy_name): Remove local variable.
2552         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2553
2554 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2555
2556         * unittests/basic_string_view/element_access/char/empty.cc:
2557         Fix year range in copyright header.
2558
2559 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2560
2561         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2562         Delete.
2563         <operator==>: Update with for removed field.
2564         <hash>: Likewise.
2565         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2566         <isa_features>: ...this.
2567         <abi_features>: New field.
2568         (riscv_isa_flen): Update comment.
2569         (riscv_abi_xlen): New declaration.
2570         (riscv_abi_flen): New declaration.
2571         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2572         isa_features.
2573         (riscv_abi_xlen): New function.
2574         (riscv_isa_flen): Update to get answer from isa_features.
2575         (riscv_abi_flen): New function.
2576         (riscv_has_fp_abi): Update to get answer from abi_features.
2577         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2578         xlen and flen.
2579         (riscv_call_info) <xlen, flen>: Update comment.
2580         (riscv_call_arg_struct): Remove invalid assertions
2581         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2582         is removed.
2583         (riscv_gdbarch_init): Gather isa features and abi features
2584         separately, ensure both match on the gdbarch when reusing an old
2585         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2586         a target with 64-bit float hardware.
2587
2588 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2589
2590         * source.c (search_command_helper): Stop reverse search
2591         when line 1 has been searched.
2592
2593 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2594
2595         * record-full.c (record_full_base_target::close): Rewrite
2596         record_full_core_buf_list free logic.
2597
2598 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2599
2600         * break-catch-syscall.c (print_one_catch_syscall): xfree
2601         the last text.
2602
2603 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2604
2605         * top.c (print_gdb_version): Update Copyright year in version
2606         message.
2607
2608 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2609
2610         Update copyright year range in all GDB files.
2611
2612 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2613
2614         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2615
2616 For older changes see ChangeLog-2018.
2617 \f
2618 Local Variables:
2619 mode: change-log
2620 left-margin: 8
2621 fill-column: 74
2622 version-control: never
2623 coding: utf-8
2624 End:
2625