gdb/ChangeLog

   1 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * cp-valprint.c (cp_print_value_fields): Don't print trailing
   4         whitespace when pretty printing is on.
   5
   6 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
   7
   8         * ppc-linux-nat.c: Add include.
   9
  10 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  11
  12         * NEWS: Mention AArch64 Pointer Authentication.
  13
  14 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  15
  16         * arm-linux-nat.c: Add include.
  17
  18 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  19
  20         * source-cache.c (source_cache::get_source_lines): Re-read
  21         fullname after calling open_source_file.
  22
  23 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  24
  25         * NEWS: Mention TLS support for FreeBSD.
  26
  27 2019-03-25  Tom Tromey  <tromey@adacore.com>
  28
  29         * minsyms.c (BUNCH_SIZE): Update comment.
  30         (~minimal_symbol_reader): Remove old comment.
  31         (compact_minimal_symbols): Update comment.
  32         (minimal_symbol_reader::install): Remove old comment.  Update
  33         other comments.
  34
  35 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  36
  37         * s390-linux-nat.c: Add include.
  38
  39 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  40
  41         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  42         Call linux_get_hwcap.
  43         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  44         Likewise.
  45         (aarch64_linux_get_hwcap): Remove function.
  46         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  47         declaration.
  48         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  49         linux_get_hwcap.
  50         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  51         * linux-tdep.c (linux_get_hwcap): Add function.
  52         (linux_get_hwcap2): Likewise.
  53         * linux-tdep.h (linux_get_hwcap): Add declaration.
  54         (linux_get_hwcap2): Likewise.
  55         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  56         (ppc_linux_get_hwcap2): Likewise.
  57         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  58         linux_get_hwcap.
  59         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  60         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  61         (ppc_linux_nat_target::read_description): Likewise.
  62         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  63         * s390-linux-nat.c: Likewise.
  64         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  65
  66 2019-03-24  Tom Tromey  <tom@tromey.com>
  67
  68         * ada-lang.c (standard_lookup): Simplify initialization.
  69         (ada_lookup_symbol_nonlocal): Simplify return.
  70         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  71         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  72         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  73         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  74         initialization.
  75         * solib.c (solib_global_lookup): Simplify.
  76         * symtab.c (null_block_symbol): Remove.
  77         (symbol_cache_lookup): Simplify returns.
  78         (lookup_language_this): Simplify returns.
  79         (lookup_symbol_aux): Simplify return.
  80         (lookup_local_symbol): Simplify returns.
  81         (lookup_global_symbol_from_objfile): Simplify return.
  82         (lookup_symbol_in_objfile_symtabs)
  83         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
  84         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
  85         (lookup_static_symbol, lookup_global_symbol): Simplify return.
  86         * cp-namespace.c (cp_lookup_bare_symbol)
  87         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
  88         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
  89         (cp_lookup_nested_symbol): Don't use null_block_symbol.
  90         (cp_lookup_symbol_via_imports): Simplify initialization.
  91         (find_symbol_in_baseclass): Likewise.
  92         * symtab.h (null_block_symbol): Remove.
  93         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
  94         (d_lookup_nested_symbol, d_lookup_symbol_imports)
  95         (d_lookup_symbol_module): Likewise.
  96         (find_symbol_in_baseclass): Simplify initialization.
  97
  98 2019-03-24  Tom Tromey  <tom@tromey.com>
  99
 100         * expression.h: Don't include symtab.h.
 101         (struct block): Forward declare.
 102
 103 2019-03-24  Tom Tromey  <tom@tromey.com>
 104
 105         * c-exp.y (typebase): Remove casts.
 106         * gdbtypes.c (lookup_unsigned_typename, )
 107         (lookup_signed_typename): Remove cast.
 108         * eval.c (parse_to_comma_and_eval): Remove cast.
 109         * parse.c (write_dollar_variable): Remove cast.
 110         * block.h (struct block) <superblock>: Now const.
 111         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 112         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 113         (map_block): Make "block" const.
 114         * symfile.h (struct quick_symbol_functions)
 115         <map_matching_symbols>: Constify block argument to "callback".
 116         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 117         const.
 118         (find_pc_sect_compunit_symtab): Make "b" const.
 119         (find_symbol_at_address): Likewise.
 120         (search_symbols): Likewise.
 121         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 122         (dw2_debug_names_lookup_symbol): Likewise.
 123         (dw2_map_matching_symbols): Update.
 124         * p-valprint.c (pascal_val_print): Remove "block".
 125         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 126         (aux_add_nonlocal_symbols): Make "block" const.
 127         (resolve_subexp): Remove cast.
 128         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 129         const.
 130         (iterate_over_file_blocks): Likewise.
 131         * f-exp.y (%union) <bval>: Remove.
 132         * coffread.c (patch_opaque_types): Make "b" const.
 133         * spu-tdep.c (spu_catch_start): Make "block" const.
 134         * c-valprint.c (print_unpacked_pointer): Remove "block".
 135         * symmisc.c (dump_symtab_1): Make "b" const.
 136         (block_depth): Make "block" const.
 137         * d-exp.y (%union) <bval>: Remove.
 138         * cp-support.h (cp_lookup_rtti_type): Update.
 139         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 140         * psymtab.c (psym_lookup_symbol): Make "block" const.
 141         (maintenance_check_psymtabs): Make "b" const.
 142         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 143         (enumerate_locals, enumerate_args): Update.
 144         * python/py-symtab.c (stpy_global_block): Make "block" const.
 145         (stpy_static_block): Likewise.
 146         * inline-frame.c (block_starting_point_at): Make "new_block"
 147         const.
 148         * block.c (find_block_in_blockvector): Make return type const.
 149         (blockvector_for_pc_sect): Make "b" const.
 150         (find_block_in_blockvector): Make "b" const.
 151
 152 2019-03-23  Tom Tromey  <tom@tromey.com>
 153
 154         * varobj.c (varobj_create): Update.
 155         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 156         * printcmd.c (display_command, do_one_display): Don't reset
 157         innermost_block.
 158         * parser-defs.h (enum innermost_block_tracker_type): Move to
 159         expression.h.
 160         (innermost_block): Update comment.
 161         * parse.c (parse_exp_1): Add tracker_types parameter.
 162         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 163         tracker_types parameter.  Reset innermost_block.
 164         (parse_exp_in_context): Remove.
 165         (parse_expression_for_completion): Update.
 166         * objfiles.c (~objfile): Don't reset expression_context_block or
 167         innermost_block.
 168         * expression.h (enum innermost_block_tracker_type): Move from
 169         parser-defs.h.
 170         (parse_exp_1): Add tracker_types parameter.
 171         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 172         reset innermost_block.
 173
 174 2019-03-23  Tom Tromey  <tom@tromey.com>
 175
 176         * objfiles.h: Include bcache.h.
 177
 178 2019-03-23  Tom Tromey  <tom@tromey.com>
 179
 180         * linespec.c (get_current_search_block): Use
 181         scoped_restore_current_language.
 182         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 183
 184 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 185             Jiong Wang  <jiong.wang@arm.com>
 186
 187         * aarch64-linux-tdep.c
 188         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 189         section.
 190         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 191
 192 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 193             Jiong Wang  <jiong.wang@arm.com>
 194
 195         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 196         instructions.
 197         (aarch64_analyze_prologue_test): Add PACIASP test.
 198         (aarch64_prologue_prev_register): Unmask PC value.
 199
 200 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 201             Jiong Wang  <jiong.wang@arm.com>
 202
 203         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 204         (aarch64_dwarf2_prev_register): Unmask PC value.
 205         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 206         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 207         DW_CFA_AARCH64_negate_ra_state.
 208         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 209
 210 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 211             Jiong Wang  <jiong.wang@arm.com>
 212
 213         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 214         registers.
 215         (aarch64_pseudo_register_name): Likewise.
 216         (aarch64_pseudo_register_type): Likewise.
 217         (aarch64_pseudo_register_reggroup_p): Likewise.
 218         (aarch64_gdbarch_init): Add pauth registers.
 219         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 220         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 221         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 222         (struct gdbarch_tdep): Add regnum for ra_state.
 223
 224 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 225             Jiong Wang  <jiong.wang@arm.com>
 226
 227         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 228
 229 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 230             Jiong Wang  <jiong.wang@arm.com>
 231
 232         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 233         function.
 234         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 235         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 236         (aarch64_gdbarch_init): Add puth registers.
 237         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 238         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 239         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 240
 241 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 242             Jiong Wang  <jiong.wang@arm.com>
 243
 244         * aarch64-linux-nat.c
 245         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 246         * aarch64-linux-tdep.c
 247         (aarch64_linux_core_read_description): Likewise.
 248         (aarch64_linux_get_hwcap): New function.
 249         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 250         (aarch64_linux_get_hwcap): New declaration.
 251
 252 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 253             Jiong Wang  <jiong.wang@arm.com>
 254
 255         * aarch64-linux-nat.c
 256         (aarch64_linux_nat_target::read_description): Add pauth param.
 257         * aarch64-linux-tdep.c
 258         (aarch64_linux_core_read_description): Likewise.
 259         * aarch64-tdep.c (struct target_desc): Add in pauth.
 260         (aarch64_read_description): Add pauth param.
 261         (aarch64_gdbarch_init): Likewise.
 262         * aarch64-tdep.h (aarch64_read_description): Likewise.
 263         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 264         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 265         * features/Makefile: Add new files.
 266         * features/aarch64-pauth.c: New file.
 267         * features/aarch64-pauth.xml: New file.
 268
 269 2019-03-20  Tom Tromey  <tromey@adacore.com>
 270
 271         * infrun.c (handle_inferior_event): Rename from
 272         handle_inferior_event_1.  Create a scoped_value_mark.
 273         (handle_inferior_event): Remove.
 274
 275 2019-03-19  Tom Tromey  <tromey@adacore.com>
 276
 277         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 278         * infrun.h (print_stop_event): Add "displays" parameter.
 279         * infrun.c (print_stop_event): Add "displays" parameter.
 280
 281 2019-03-19  Pedro Alves  <palves@redhat.com>
 282
 283         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 284         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 285         to -1.  Fix TABs vs spaces.
 286         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 287         * tui/tui-out.h (tui_ui_out) Add intro comments.
 288         <m_line, m_start_of_line>: In-class initialize, and add describing
 289         comment.
 290
 291 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 292
 293         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 294         variable names.
 295         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 296
 297 2019-03-18  Pedro Alves  <palves@redhat.com>
 298             Eli Zaretskii <eliz@gnu.org>
 299
 300         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 301         m_line and m_start_of_line.
 302
 303 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 304
 305         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 306         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 307         it returns a newline.  This fixes a regression in TU mode, whereby
 308         the next line is output on the same screen line as the user input.
 309
 310 2019-03-18  Tom Tromey  <tromey@adacore.com>
 311
 312         * minsyms.c (minimal_symbol_reader::install): Remove call to
 313         obstack_blank.
 314
 315 2019-03-18  Pedro Alves  <palves@redhat.com>
 316
 317         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 318         New globals.
 319         (apply_style): New, factored out from ...
 320         (apply_ansi_escape): ... this.  Handle reverse video mode.
 321         (tui_set_reverse_mode): New function.
 322         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 323         * tui/tui-winsource.c (tui_show_source_line): Use
 324         tui_set_reverse_mode instead of setting A_STANDOUT.
 325         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 326         New setter methods.
 327
 328 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 329
 330         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 331         Handle tabs.
 332
 333 2019-03-18  Tom Tromey  <tromey@adacore.com>
 334
 335         * ada-lang.c (empty_array): Add "high" parameter.
 336         (ada_evaluate_subexp): Update.
 337
 338 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 339
 340         * unittests/string_view-selftests.c: Define
 341         _initialize_string_view_selftests unconditionally.
 342
 343 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 344
 345         PR gdb/24350
 346         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 347
 348 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 349
 350         PR gdb/24351
 351         * windows-nat.c (display_selector): Fix format specifiers.
 352
 353 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 354
 355         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 356         tui_refill_source_window instead of tui_refresh_win, to update the
 357         current execution line.  This fixes redisplay of the current line
 358         when stepping through the code with "next" or "step".
 359
 360 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 361
 362         * source-cache.c (source_cache::get_source_lines): Call
 363         find_source_lines to initialize s->nlines.  This fixes vertical
 364         scrolling of TUI source window when the DOWN arrow is pressed.
 365
 366 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 367
 368         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 369         linux-thread-db.c (_initialize_thread_db): Likewise.
 370
 371 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 372
 373         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 374         wclrtoeol in tui_show_source_line".  This reverts changes made in
 375         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 376
 377 2019-03-15  Tom Tromey  <tom@tromey.com>
 378
 379         * symtab.h (struct minimal_symbol): Derive from
 380         general_symbol_info.
 381         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 382         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 383         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 384         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 385         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 386         (MSYMBOL_SEARCH_NAME): Update.
 387         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 388         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 389         * minsyms.c (minimal_symbol_reader::record_full): Update.
 390
 391 2019-03-15  Tom Tromey  <tom@tromey.com>
 392
 393         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 394
 395 2019-03-15  Tom Tromey  <tom@tromey.com>
 396
 397         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 398         unique_xmalloc_ptr.
 399         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 400         Update.
 401         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 402         (build_minimal_symbol_hash_tables)
 403         (minimal_symbol_reader::install): Update.
 404
 405 2019-03-15  Tom Tromey  <tom@tromey.com>
 406
 407         * symtab.c (create_demangled_names_hash): Update.
 408         (symbol_set_names): Update.
 409         * objfiles.h (struct objfile_per_bfd_storage)
 410         <demangled_names_hash>: Now an htab_up.
 411         * objfiles.c (objfile_per_bfd_storage): Simplify.
 412
 413 2019-03-15  Tom Tromey  <tom@tromey.com>
 414
 415         * objfiles.h (struct objfile_per_bfd_storage): Declare
 416         destructor.
 417         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 418         New.
 419         (get_objfile_bfd_data): Use new.  Don't initialize
 420         language_of_main.
 421         (free_objfile_per_bfd_storage): Remove.
 422         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 423
 424 2019-03-15  Tom Tromey  <tom@tromey.com>
 425
 426         * symfile.c (reread_symbols): Update.
 427         * objfiles.c (objfile::objfile): Update.
 428         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 429         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 430         comment.
 431         (minimal_symbol_reader::install): Update.
 432         (terminate_minimal_symbol_table): Remove.
 433         * jit.c (jit_object_close_impl): Update.
 434
 435 2019-03-15  Tom Tromey  <tom@tromey.com>
 436
 437         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 438         initializations.
 439
 440 2019-03-15  Tom Tromey  <tom@tromey.com>
 441
 442         * objfiles.h (struct objfile_per_bfd_storage)
 443         <demangled_hash_languages>: Now a bitset.
 444         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 445         (lookup_minimal_symbol): Update.
 446
 447 2019-03-15  Tom Tromey  <tom@tromey.com>
 448
 449         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 450         Don't return the symbol.
 451         * coffread.c (record_minimal_symbol): Use record_full.
 452
 453 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 454
 455         The MS-Windows port of ncurses fails to switch to a color pair if
 456         one or both of the colors are the implicit default colors.  This
 457         change records the default colors when TUI is initialized, and
 458         then specifies them explicitly when a color pair uses the default
 459         colors.  This allows color styling in TUI mode on MS-Windows.
 460
 461         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 462         ncurses_norm_attr.
 463         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 464         colors in ncurses_norm_attr.
 465         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 466         "none", replace it with the default color recorded in
 467         ncurses_norm_attr.
 468
 469 2019-03-14  Tom Tromey  <tromey@adacore.com>
 470
 471         * source-cache.h (class source_cache) <get_source_lines>: Return
 472         std::string.
 473         * source-cache.c (source_cache::extract_lines): Handle case where
 474         first_pos==npos.  Return std::string.
 475         (source_cache::get_source_lines): Update.
 476
 477 2019-03-14  Tom Tromey  <tromey@adacore.com>
 478
 479         * NEWS: Add item for "style sources" commands.
 480         * source-cache.c (source_cache::get_source_lines): Check
 481         source_styling.
 482         * cli/cli-style.c (source_styling): New global.
 483         (_initialize_cli_style): Add "style sources" commands.
 484         (show_style_sources): New function.
 485         * cli/cli-style.h (source_styling): Declare.
 486
 487 2019-03-14  Pedro Alves  <palves@redhat.com>
 488             Tom Tromey  <tromey@adacore.com>
 489
 490         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 491         * tui/tui-winsource.c (tui_refill_source_window): New function,
 492         from...
 493         (tui_horizontal_source_scroll): ... here.  Move some logic.
 494         * cli/cli-style.c (set_style_enabled): Notify new observable.
 495         * tui/tui-hooks.c (tui_redisplay_source): New function.
 496         (tui_attach_detach_observers): Attach or detach
 497         tui_redisplay_source.
 498         * observable.h (source_styling_changed): New observable.
 499         * observable.c: Define source_styling_changed observable.
 500
 501 2019-03-13  Tom Tromey  <tromey@adacore.com>
 502
 503         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 504         (i386_gnu_nat_target::store_registers): Update.
 505         * target-debug.h (target_debug_print_std_string): New macro.
 506         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 507         * windows-tdep.c (display_one_tib): Update.
 508         * tui/tui-stack.c (tui_make_status_line): Update.
 509         * top.c (print_inferior_quit_action): Update.
 510         * thread.c (thr_try_catch_cmd): Update.
 511         (add_thread_with_info): Update.
 512         (thread_target_id_str): Update.
 513         (thr_try_catch_cmd): Update.
 514         (thread_command): Update.
 515         (thread_find_command): Update.
 516         * record-btrace.c (record_btrace_target::info_record)
 517         (record_btrace_resume_thread, record_btrace_target::resume)
 518         (record_btrace_cancel_resume, record_btrace_step_thread)
 519         (record_btrace_target::wait, record_btrace_target::wait)
 520         (record_btrace_target::wait, record_btrace_target::stop): Update.
 521         * progspace.c (print_program_space): Update.
 522         * process-stratum-target.c
 523         (process_stratum_target::thread_address_space): Update.
 524         * linux-fork.c (linux_fork_mourn_inferior)
 525         (detach_checkpoint_command, info_checkpoints_command)
 526         (linux_fork_context): Update.
 527         (linux_fork_detach): Update.
 528         (class scoped_switch_fork_info): Update.
 529         (delete_checkpoint_command): Update.
 530         * infrun.c (follow_fork_inferior): Update.
 531         (follow_fork_inferior): Update.
 532         (proceed_after_vfork_done): Update.
 533         (handle_vfork_child_exec_or_exit): Update.
 534         (follow_exec): Update.
 535         (displaced_step_prepare_throw): Update.
 536         (displaced_step_restore): Update.
 537         (start_step_over): Update.
 538         (resume_1): Update.
 539         (clear_proceed_status_thread): Update.
 540         (proceed): Update.
 541         (print_target_wait_results): Update.
 542         (do_target_wait): Update.
 543         (context_switch): Update.
 544         (stop_all_threads): Update.
 545         (restart_threads): Update.
 546         (finish_step_over): Update.
 547         (handle_signal_stop): Update.
 548         (switch_back_to_stepped_thread): Update.
 549         (keep_going_pass_signal): Update.
 550         (print_exited_reason): Update.
 551         (normal_stop): Update.
 552         * inferior.c (inferior_pid_to_str): Change return type.
 553         (print_selected_inferior): Update.
 554         (add_inferior): Update.
 555         (detach_inferior): Update.
 556         * dummy-frame.c (fprint_dummy_frames): Update.
 557         * dcache.c (dcache_info_1): Update.
 558         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 559         (btrace_fetch, btrace_clear): Update.
 560         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 561         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 562         type.
 563         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 564         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 565         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 566         * gdbarch.c, gdbarch.h: Rebuild.
 567         * gdbarch.sh (core_pid_to_str): Change return type.
 568         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 569         return type.
 570         (windows_nat_target::pid_to_str): Change return type.
 571         (windows_delete_thread): Update.
 572         (windows_nat_target::attach): Update.
 573         (windows_nat_target::files_info): Update.
 574         * target-delegates.c: Rebuild.
 575         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 576         return type.
 577         (sol_thread_target::pid_to_str): Change return type.
 578         * remote.c (class remote_target) <pid_to_str>: Change return
 579         type.
 580         (remote_target::pid_to_str): Change return type.
 581         (extended_remote_target::attach, remote_target::remote_stop_ns)
 582         (remote_target::remote_notif_remove_queued_reply)
 583         (remote_target::push_stop_reply, remote_target::disable_btrace):
 584         Update.
 585         (extended_remote_target::attach): Update.
 586         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 587         type.
 588         (gdbsim_target::pid_to_str): Change return type.
 589         * ravenscar-thread.c (struct ravenscar_thread_target)
 590         <pid_to_str>: Change return type.
 591         (ravenscar_thread_target::pid_to_str): Change return type.
 592         * procfs.c (class procfs_target) <pid_to_str>: Change return
 593         type.
 594         (procfs_target::pid_to_str): Change return type.
 595         (procfs_target::attach): Update.
 596         (procfs_target::detach): Update.
 597         (procfs_target::fetch_registers): Update.
 598         (procfs_target::store_registers): Update.
 599         (procfs_target::wait): Update.
 600         (procfs_target::files_info): Update.
 601         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 602         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 603         return type.
 604         (nto_procfs_target::pid_to_str): Change return type.
 605         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 606         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 607         return type.
 608         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 609         (exit_lwp): Update.
 610         (attach_proc_task_lwp_callback, get_detach_signal)
 611         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 612         (linux_nat_target::resume, wait_lwp, stop_callback)
 613         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 614         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 615         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 616         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 617         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 618         type.
 619         (inf_ptrace_target::attach): Update.
 620         (inf_ptrace_target::files_info): Update.
 621         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 622         type.
 623         (go32_nat_target::pid_to_str): Change return type.
 624         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 625         (gnu_nat_target::wait): Update.
 626         (gnu_nat_target::wait): Update.
 627         (gnu_nat_target::resume): Update.
 628         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 629         (fbsd_nat_target::wait): Update.
 630         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 631         type.
 632         (darwin_nat_target::attach): Update.
 633         * corelow.c (class core_target) <pid_to_str>: Change return type.
 634         (core_target::pid_to_str): Change return type.
 635         * target.c (normal_pid_to_str): Change return type.
 636         (default_pid_to_str): Likewise.
 637         (target_pid_to_str): Change return type.
 638         (target_translate_tls_address): Update.
 639         (target_announce_detach): Update.
 640         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 641         return type.
 642         (bsd_uthread_target::pid_to_str): Change return type.
 643         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 644         type.
 645         (bsd_kvm_target::pid_to_str): Change return type.
 646         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 647         return type.
 648         (aix_thread_target::pid_to_str): Change return type.
 649         * target.h (struct target_ops) <pid_to_str>: Change return type.
 650         (target_pid_to_str, normal_pid_to_str): Likewise.
 651         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 652         type.
 653         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 654         type.
 655         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 656         return type.
 657         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 658         type.
 659         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 660         type.
 661         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 662         return type.
 663
 664 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 665
 666         * NEWS: Mention that the new default MI version is 3.  Mention
 667         changes to the output of commands and events that deal with
 668         multi-location breakpoints.
 669         * breakpoint.c: Include "mi/mi-out.h".
 670         (print_one_breakpoint): Change output syntax if using MI version
 671         >= 3.
 672         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 673         New.
 674         (mi_multi_location_breakpoint_output_fixed): New.
 675         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 676         (mi_cmd_fix_multi_location_breakpoint_output): New.
 677         (mi_multi_location_breakpoint_output_fixed): New.
 678         * mi/mi-cmds.c (mi_cmds): Register command
 679         -fix-multi-location-breakpoint-output.
 680         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 681         interpreter "mi".
 682
 683 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 684
 685         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 686         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 687         instantiate mi_ui_out based on interpreter name.
 688         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 689         * mi/mi-main.c (mi_load_progress): Likewise.
 690
 691 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 692
 693         * NEWS: Combine separate "New targets" sections for 8.3.
 694
 695 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 696
 697         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 698         (ppcfbsd_init_abi): Install gdbarch
 699         "fetch_tls_load_module_address" and "get_thread_local_address"
 700         methods.
 701
 702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 703
 704         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 705         (riscv_fbsd_init_abi): Install gdbarch
 706         "fetch_tls_load_module_address" and "get_thread_local_address"
 707         methods.
 708
 709 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 710
 711         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 712         (i386fbsd_init_abi): Install gdbarch
 713         "fetch_tls_load_module_address" and "get_thread_local_address"
 714         methods.
 715
 716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 717
 718         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 719         (amd64fbsd_init_abi): Install gdbarch
 720         "fetch_tls_load_module_address" and "get_thread_local_address"
 721         methods.
 722
 723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 724
 725         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 726         (struct fbsd_pspace_data): New type.
 727         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 728         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 729         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 730         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 731         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 732
 733 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 734
 735         * gdbtypes.c (lookup_struct_elt): New function.
 736         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 737         * gdbtypes.h (struct struct_elt): New type.
 738         (lookup_struct_elt): New prototype.
 739
 740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 741
 742         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 743         remove disabled code block.
 744
 745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 746
 747         * gdbarch.sh (get_thread_local_address): New method.
 748         * gdbarch.h, gdbarch.c: Regenerate.
 749         * target.c (target_translate_tls_address): Use
 750         gdbarch_get_thread_local_address if present instead of
 751         target::get_thread_local_address.
 752
 753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 754
 755         * target.h (target::get_thread_local_address): Update comment.
 756
 757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 758
 759         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 760         objfile->separate_debug_objfile_backlink if not NULL.
 761
 762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 763
 764         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 765         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 766         (amd64bsd_store_inferior_registers): Likewise.
 767         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 768         Enable segment base registers.
 769         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 770         PT_GETFSBASE and PT_GETGSBASE.
 771         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 772         PT_SETGSBASE.
 773         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 774         segment base registers.
 775         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 776
 777 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 778
 779         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 780         Update calls to i386_target_description to add 'segments'
 781         parameter.
 782         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 783         add segment base registers.
 784         * arch/i386.c (i386_create_target_description): Add 'segments'
 785         parameter to enable segment base registers.
 786         * arch/i386.h (i386_create_target_description): Likewise.
 787         * features/i386/32bit-segments.xml: New file.
 788         * features/i386/32bit-segments.c: Generate.
 789         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 790         call to i386_target_description to add 'segments' parameter.
 791         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 792         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 793         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 794         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 795         if feature is present.
 796         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 797         Add 'segments' parameter to call to i386_target_description.
 798         (i386_target_description): Add 'segments' parameter to enable
 799         segment base registers.
 800         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 801         to call to i386_target_description.
 802         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 803         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 804         Define I386_NUM_REGS.
 805         (i386_target_description): Add 'segments' parameter to enable
 806         segment base registers.
 807
 808 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 809
 810         PR/24325
 811         * source-cache.c: #undef open and close, to avoid unresolved
 812         externals during linking.
 813
 814 2019-03-12  Tom Tromey  <tromey@adacore.com>
 815
 816         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 817         const.  Add initializers.
 818         (_initialize_remote): Don't initialize ptid globals.
 819
 820 2019-03-12  Pedro Alves  <palves@redhat.com>
 821
 822         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 823
 824 2019-03-12  Pedro Alves  <palves@redhat.com>
 825
 826         * cp-name-parser.y (main): Remove unused 'len' variable.
 827
 828 2019-03-12  Tom Tromey  <tromey@adacore.com>
 829
 830         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 831         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 832
 833 2019-03-12  Tom Tromey  <tromey@adacore.com>
 834
 835         * linux-nat.c (iterate_over_lwps): Update.
 836         (stop_callback): Remove parameter.
 837         (stop_wait_callback, detach_callback, resume_set_callback)
 838         (select_singlestep_lwp_callback, set_ignore_sigint)
 839         (status_callback, resumed_callback, resume_clear_callback)
 840         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 841         data parameter.
 842         (linux_nat_target::detach, linux_nat_target::resume)
 843         (linux_stop_and_wait_all_lwps, select_event_lwp)
 844         (linux_nat_filter_event, linux_nat_wait_1)
 845         (linux_nat_target::kill, linux_nat_target::stop)
 846         (linux_nat_target::stop): Update.
 847         (linux_nat_resume_callback): Change type.
 848         (resume_stopped_resumed_lwps, count_events_callback)
 849         (select_event_lwp_callback): Likewise.
 850         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 851         * arm-linux-nat.c (struct update_registers_data): Remove.
 852         (update_registers_callback): Change type.
 853         (arm_linux_insert_hw_breakpoint1): Update.
 854         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 855         parameter.
 856         (x86_linux_dr_set_addr): Update.
 857         (x86_linux_dr_set_control): Update.
 858         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 859         (iterate_over_lwps): Use gdb::function_view.
 860         * nat/aarch64-linux-hw-point.c (struct
 861         aarch64_dr_update_callback_param): Remove.
 862         (debug_reg_change_callback): Change type.
 863         (aarch64_notify_debug_reg_change): Update.
 864         * s390-linux-nat.c (s390_refresh_per_info): Update.
 865
 866 2019-03-11  Tom Tromey  <tromey@adacore.com>
 867
 868         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 869         redundant assignment to "this_cu".
 870
 871 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 872
 873         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 874
 875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 876
 877         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 878         from...
 879         (rank_one_type): ... this.
 880
 881 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 882
 883         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 884         from...
 885         (rank_one_type): ... this.
 886
 887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 888
 889         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 890         from...
 891         (rank_one_type): ... this.
 892
 893 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 894
 895         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 896         from...
 897         (rank_one_type): ... this.
 898
 899 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 900
 901         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 902         from...
 903         (rank_one_type): ... this.
 904
 905 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 906
 907         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 908         from...
 909         (rank_one_type): ... this.
 910
 911 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 912
 913         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 914         from...
 915         (rank_one_type): ... this.
 916
 917 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 918
 919         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 920         from...
 921         (rank_one_type): ... this.
 922
 923 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 924
 925         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 926         from...
 927         (rank_one_type): ... this.
 928
 929 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 930
 931         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 932         from...
 933         (rank_one_type): ... this.
 934
 935 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 936
 937         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 938         from...
 939         (rank_one_type): ... this.
 940
 941 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 942
 943         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 944         from...
 945         (rank_one_type): ... this.
 946
 947 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 948
 949         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 950         inferior-events' shows the example events.
 951
 952 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 953
 954         Support styling on native MS-Windows console
 955
 956         PR/24315
 957         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 958         on MS-Windows if $TERM is not defined.
 959
 960         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 961
 962         * posix-hdep.c (gdb_console_fputs):
 963         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 964         functions.
 965         * ui-file.h (gdb_console_fputs): Add prototype.
 966
 967         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 968         back to fputs only if the former returns zero.
 969
 970 2019-03-07  Tom Tromey  <tom@tromey.com>
 971
 972         * symmisc.c (print_symbol_bcache_statistics): Update.
 973         (print_objfile_statistics): Update.
 974         * symfile.c (allocate_symtab): Update.
 975         * stabsread.c: Don't include bcache.h.
 976         * psymtab.h (struct psymbol_bcache): Don't declare.
 977         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 978         (psymbol_bcache_init, psymbol_bcache_free)
 979         (psymbol_bcache_get_bcache): Don't declare.
 980         * psymtab.c (struct psymbol_bcache): Remove.
 981         (psymtab_storage::psymtab_storage): Update.
 982         (psymtab_storage::~psymtab_storage): Update.
 983         (psymbol_bcache_init, psymbol_bcache_free)
 984         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 985         (add_psymbol_to_bcache): Update.
 986         (allocate_psymtab): Update.
 987         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 988         macro_cache>: No longer pointers.
 989         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 990         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 991         * macrotab.c (macro_bcache): Update.
 992         * macroexp.c: Don't include bcache.h.
 993         * gdbtypes.c (check_types_worklist): Update.
 994         (types_deeply_equal): Remove TRY/CATCH.  Update.
 995         * elfread.c (elf_symtab_read): Update.
 996         * dwarf2read.c: Don't include bcache.h.
 997         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 998         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 999         (print_bcache_statistics, bcache_memory_used): Don't declare.
1000         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1001         methods.  Rename all data members.
1002         * bcache.c (struct bcache): Move to bcache.h.
1003         (bcache::expand_hash_table): Rename from expand_hash_table.
1004         (bcache): Remove.
1005         (bcache::insert): Rename from bcache_full.
1006         (bcache::compare): Rename from bcache_compare.
1007         (bcache_xmalloc): Remove.
1008         (bcache::~bcache): Rename from bcache_xfree.
1009         (bcache::print_statistics): Rename from print_bcache_statistics.
1010         (bcache::memory_used): Rename from bcache_memory_used.
1011
1012 2019-03-07  Pedro Alves  <palves@redhat.com>
1013
1014         * infrun.c (normal_stop): Also check for
1015         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1016
1017 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * f-lang.c (value_from_host_double): Moved to...
1020         * value.c (value_from_host_double): ...here.
1021         * value.h (value_from_host_double): Declare.
1022         * guile/scm-math.c (vlscm_convert_typed_number): Use
1023         value_from_host_double.
1024         (vlscm_convert_number): Likewise.
1025         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1026         * python/py-value.c (convert_value_from_python): Likewise.
1027
1028 2019-03-06  Tom Tromey  <tom@tromey.com>
1029
1030         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1031
1032 2019-03-06  Tom Tromey  <tom@tromey.com>
1033
1034         * utils.h (free_current_contents): Don't declare.
1035         * utils.c (free_current_contents): Remove.
1036
1037 2019-03-06  Tom Tromey  <tom@tromey.com>
1038
1039         * top.c (quit_force): Update.
1040         * main.c (captured_command_loop): Update.
1041         * common/new-op.c (operator new): Update.
1042         * common/common-exceptions.c (struct catcher)
1043         <save_cleanup_chain>: Remove member.
1044         (exceptions_state_mc_init): Update.
1045         (exception_try_scope_entry): Return nullptr.
1046         (exception_try_scope_exit, exception_rethrow)
1047         (throw_exception_sjlj, throw_exception_cxx): Update.
1048         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1049         (all_cleanups, do_cleanups, discard_cleanups)
1050         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1051         (restore_cleanups, restore_final_cleanups): Don't declare.
1052         (do_final_cleanups): Remove parameter.
1053         * common/cleanups.c (cleanup_chain, make_cleanup)
1054         (make_cleanup_dtor, all_cleanups, do_cleanups)
1055         (discard_my_cleanups, discard_cleanups)
1056         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1057         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1058         (null_cleanup): Remove.
1059         (do_final_cleanups): Remove parameter.
1060
1061 2019-03-06  Tom Tromey  <tom@tromey.com>
1062
1063         * remote.c (remote_target::remote_parse_stop_reply): Use
1064         unique_xmalloc_ptr.
1065
1066 2019-03-06  Tom Tromey  <tom@tromey.com>
1067
1068         * stabsread.c (struct stabs_field_info): Rename from field_info.
1069         <list, fnlist>: Add initializers.
1070         <obstack>: New member.
1071         (read_member_functions, read_struct_fields, read_baseclasses):
1072         Allocate on obstack.  Don't use cleanups.
1073         (read_one_struct_field, read_member_functions, read_struct_fields)
1074         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1075         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1076         (read_struct_type): Update.
1077
1078 2019-03-06  Tom Tromey  <tom@tromey.com>
1079
1080         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1081         * common/filestuff.h (make_cleanup_close): Don't declare.
1082         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1083         Remove.
1084
1085 2019-03-06  Tom Tromey  <tom@tromey.com>
1086
1087         * solib-aix.c: Use make_scope_exit.
1088
1089 2019-03-06  Tom Tromey  <tom@tromey.com>
1090
1091         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1092         Use make_scope_exit.
1093
1094 2019-03-06  Tom Tromey  <tom@tromey.com>
1095
1096         * solib-svr4.c (disable_probes_interface): Remove parameter.
1097         (svr4_handle_solib_event): Use make_scope_exit.
1098
1099 2019-03-06  Tom Tromey  <tom@tromey.com>
1100
1101         * remote.c (struct stop_reply_deleter): Remove.
1102         (stop_reply_up): Update.
1103         (struct stop_reply): Derive from notif_event.  Don't typedef.
1104         <regcache>: Now a std::vector.
1105         (stop_reply_xfree): Remove.
1106         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1107         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1108         (remote_target::discard_pending_stop_replies): Use delete.
1109         (remote_target::remote_parse_stop_reply): Update.
1110         (remote_target::process_stop_reply): Update.
1111         * remote-notif.h (struct notif_event): Add virtual destructor.
1112         Remove "dtr" member.
1113         (struct notif_client) <alloc_event>: Return a unique_ptr.
1114         (notif_event_xfree): Don't declare.
1115         (notif_event_up): New typedef.
1116         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1117         (notif_event_xfree, do_notif_event_xfree): Remove.
1118         (remote_notif_state_xfree): Update.
1119
1120 2019-03-06  Tom Tromey  <tom@tromey.com>
1121
1122         * infrun.c (displaced_step_clear_cleanup): Now a
1123         forward_scope_exit type.
1124         (displaced_step_prepare_throw): Update.
1125         (displaced_step_fixup): Update.
1126
1127 2019-03-06  Tom Tromey  <tom@tromey.com>
1128
1129         * inferior.h (class inferior): Update comment.
1130         * gdbthread.h (class thread_info): Update comment.
1131
1132 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1133             Tom Tromey  <tom@tromey.com>
1134
1135         * stabsread.h (struct stab_section_list): Remove.
1136         (coffstab_build_psymtabs): Update.
1137         * dbxread.c (symbuf_sections): Now a std::vector.
1138         (sect_idx): New global.
1139         (fill_symbuf): Update.
1140         (coffstab_build_psymtabs): Change type of stabsects parameter.
1141         Update.
1142         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1143         std::vector.
1144         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1145         (coff_locate_sections): Update.
1146         (coff_symfile_read): Remove cleanups.  Update.
1147         (init_stringtab): Add storage parameter.
1148         (free_stringtab, free_stringtab_cleanup): Remove.
1149         (init_lineno): Add storage parameter.
1150         (free_linetab, free_linetab_cleanup): Remove.
1151
1152 2019-03-06  Pedro Alves  <palves@redhat.com>
1153
1154         * linux-fork.c (fork_info::clobber_regs): Delete.
1155         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1156         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1157         comment.  Adjust.
1158         (scoped_switch_fork_info::scoped_switch_fork_info)
1159         (checkpoint_command, linux_fork_context): Adjust
1160         fork_save_infrun_state calls.
1161
1162 2019-03-06  Pedro Alves  <palves@redhat.com>
1163
1164         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1165         (inf_has_multiple_threads): Return 'bool' and rewrite using
1166         inferior_info::threads().
1167
1168 2019-03-06  Pedro Alves  <palves@redhat.com>
1169
1170         * linux-fork.c: Include <list>.
1171         (fork_list): Now a std::list instance.
1172         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1173         (forks_exist_p, find_last_fork): Adjust.
1174         (new_fork): Delete.
1175         (one_fork_p): New.
1176         (add_fork): Adjust.
1177         (free_fork): Delete, folded into fork_info::~fork_info().
1178         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1179         Adjust.
1180         (init_fork_list): Delete.
1181         (linux_fork_killall, linux_fork_mourn_inferior)
1182         (linux_fork_detach, info_checkpoints_command): Adjust.
1183         (_initialize_linux_fork): No longer call init_fork_list.
1184
1185 2019-03-06  Pedro Alves  <palves@redhat.com>
1186
1187         * linux-fork.c (new_fork): New, split out of ...
1188         (add_fork): ... this.  Return void.  Move "first fork" special
1189         case from here, to ...
1190         (checkpoint_command): ... here.
1191         * linux-linux.h (add_fork): Return void.
1192
1193 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1194
1195         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1196
1197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1198             Chris January  <chris.january@arm.com>
1199             David Lecomber  <david.lecomber@arm.com>
1200
1201         * f-exp.y: New token, UNOP_INTRINSIC.
1202         (exp): New pattern using UNOP_INTRINSIC token.
1203         (f77_keywords): Add 'abs' keyword.
1204         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1205         (value_from_host_double): New function.
1206         (evaluate_subexp_f): Support UNOP_ABS.
1207
1208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1211         types.
1212
1213 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1216         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1217         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1218
1219 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1220
1221         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1222
1223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1224             Chris January  <chris.january@arm.com>
1225
1226         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1227         * f-exp.y: Define 'KIND' token.
1228         (exp): New pattern for KIND expressions.
1229         (ptype): Handle types with a kind extension.
1230         (direct_abs_decl): Extend to spot kind extensions.
1231         (f77_keywords): Add 'kind' to the list.
1232         (push_kind_type): New function.
1233         (convert_to_kind_type): New function.
1234         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1235         * parse.c (operator_length_standard): Likewise.
1236         * parser-defs.h (enum type_pieces): Add tp_kind.
1237         * std-operator.def: Add UNOP_KIND.
1238
1239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * f-exp.y (f_parse): Set yydebug.
1242
1243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1244
1245         * f-lang.c (evaluate_subexp_f): New function.
1246         (exp_descriptor_f): New global.
1247         (f_language_defn): Use exp_descriptor_f instead of
1248         exp_descriptor_standard.
1249
1250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * f-exp.y (struct token): Add comments.
1253         (dot_ops): Remove uppercase versions and the end marker.
1254         (f77_keywords): Likewise.
1255         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1256         entries in the dot_ops array are case insensitive, and use
1257         strncasecmp to compare strings.  Also some whitespace cleanup in
1258         this area.  Similar for the f77_keywords array, except entries in
1259         this list might be case sensitive.
1260
1261 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1262
1263         * f-exp.y (struct f77_boolean_val): Add comments.
1264         (boolean_values): Remove uppercase versions, and end marker.
1265         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1266         and use strncasecmp to achieve case insensitivity.  Additionally,
1267         perform whitespace cleanup around this code.
1268
1269 2019-03-06  Tom Tromey  <tromey@adacore.com>
1270
1271         * remote-sim.c (gdbsim_target_open): Use result of
1272         gdb_argv::release.
1273
1274 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1275         Dirk Schubert  <dirk.schubert@arm.com>
1276         Chris January  <chris.january@arm.com>
1277
1278         * eval.c (evaluate_subexp_standard): Call Fortran argument
1279         wrapping logic.
1280         * f-lang.c (struct value): A value which can be passed into a
1281         Fortran function call.
1282         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1283         where appropriate.
1284         (struct type): Value ready for a Fortran function call.
1285         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1286         is needed.
1287         * f-lang.h (fortran_argument_convert): Declaration.
1288         (fortran_preserve_arg_pointer): Declaration.
1289         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1290
1291 2019-03-05  Tom Tromey  <tromey@adacore.com>
1292
1293         * python/py-prettyprint.c (print_string_repr): Remove #if.
1294         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1295
1296 2019-03-05  Tom Tromey  <tromey@adacore.com>
1297
1298         * target.c (the_dummy_target): Move later.  Change type to
1299         "dummy_target".
1300         (initialize_targets): Don't initialize the_dummy_target.
1301
1302 2019-03-05  Tom Tromey  <tromey@adacore.com>
1303
1304         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1305         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1306
1307 2019-03-05  Tom Tromey  <tromey@adacore.com>
1308
1309         * windows-nat.c (windows_nat_target::attach)
1310         (windows_nat_target::detach): Don't call gdb_flush.
1311         * valprint.c (generic_val_print, val_print, val_print_string):
1312         Don't call gdb_flush.
1313         * utils.c (defaulted_query): Don't call gdb_flush.
1314         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1315         * target.c (target_announce_detach): Don't call gdb_flush.
1316         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1317         * remote.c (extended_remote_target::attach): Don't call
1318         gdb_flush.
1319         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1320         * printcmd.c (do_examine): Don't call gdb_flush.
1321         (info_display_command): Don't call gdb_flush.
1322         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1323         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1324         * memattr.c (info_mem_command): Don't call gdb_flush.
1325         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1326         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1327         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1328         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1329         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1330         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1331         (gnu_nat_target::detach): Don't call gdb_flush.
1332         * f-valprint.c (f_val_print): Don't call gdb_flush.
1333         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1334         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1335         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1336         gdb_flush.
1337         * c-valprint.c (c_val_print): Don't call gdb_flush.
1338         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1339
1340 2019-03-05  Tom Tromey  <tromey@adacore.com>
1341
1342         * varobj.c (update_dynamic_varobj_children): Update.
1343         (install_default_visualizer): Use reset, not release.
1344         * value.c (set_internalvar): Update.
1345         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1346         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1347         ATTRIBUTE_UNUSED_RESULT.
1348
1349 2019-03-05  Tom Tromey  <tromey@adacore.com>
1350
1351         * remote.c (class scoped_remote_fd) <release>: Add
1352         ATTRIBUTE_UNUSED_RESULT.
1353
1354 2019-03-05  Tom Tromey  <tromey@adacore.com>
1355
1356         * macroexp.c (struct macro_buffer) <release>: Add
1357         ATTRIBUTE_UNUSED_RESULT.
1358
1359 2019-03-05  Tom Tromey  <tromey@adacore.com>
1360
1361         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1362         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1363         ATTRIBUTE_UNUSED_RESULT.
1364
1365 2019-03-05  Tom Tromey  <tromey@adacore.com>
1366
1367         * common/scoped_fd.h (class scoped_fd) <release>: Add
1368         ATTRIBUTE_UNUSED_RESULT.
1369
1370 2019-03-05  Tom Tromey  <tromey@adacore.com>
1371
1372         * parser-defs.h (struct parser_state) <release>: Add
1373         ATTRIBUTE_UNUSED_RESULT.
1374
1375 2019-03-05  Tom Tromey  <tromey@adacore.com>
1376
1377         * utils.h (class gdb_argv) <release>: Add
1378         ATTRIBUTE_UNUSED_RESULT.
1379         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1380
1381 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1382
1383         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1384         for-loop range, to avoid compiler warnings.
1385
1386         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1387         avoid compiler warnings about unused variables.
1388
1389         * NEWS: Mention end of support for native debugging on MS-Windows
1390         before XP.
1391
1392         PR gdb/24292
1393         * common/netstuff.c:
1394         * gdbserver/gdbreplay.c
1395         * gdbserver/remote-utils.c:
1396         * ser-tcp.c:
1397         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1398         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1399         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1400         'getaddrinfo' and 'freeaddrinfo' were not available before
1401         Windows XP, and mingw.org's MinGW headers by default define
1402         _WIN32_WINNT to 0x500.
1403
1404 2019-03-01  Gary Benson <gbenson@redhat.com>
1405
1406         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1407
1408 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1409             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1410
1411         PR gdb/8527
1412         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1413         set_sigint_trap, clear_sigint_trap.
1414
1415 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1416
1417         * target.c (target_detach): Clear the regcache and the
1418         frame cache.
1419
1420 2019-02-27  Pedro Alves  <palves@redhat.com>
1421
1422         * utils.c (set_screen_size): When we cap the height/width sizes,
1423         tweak the corresponding command variable to show "unlimited":
1424
1425 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1426             Pedro Alves  <palves@redhat.com>
1427
1428         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1429         before calling rl_set_screen_size.
1430
1431 2019-02-27  Tom Tromey  <tromey@adacore.com>
1432
1433         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1434         define.
1435         * python/py-value.c: Remove Python 2.4 workaround.
1436         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1437         workaround.
1438         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1439         Python 2.4 workaround.
1440         * python/python-internal.h: Remove Python 2.4 comment.
1441         (Py_ssize_t): Don't define.
1442         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1443         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1444         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1445         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1446         * python/python.c (do_start_initialization): Remove Python 2.4
1447         workaround.
1448         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1449         (print_children): Remove Python 2.4 workaround.
1450         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1451         workaround.
1452         (CHARBUFFERPROC_NAME): Remove.
1453         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1454         Python 2.4 workaround.
1455
1456 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1457
1458         * NEWS: Note minimum Python version.
1459
1460 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1461
1462         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1463         code from these functions.  Remove corresponding ifdefs.  Use
1464         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1465         Remove gotos and target of gotos.
1466         (infpy_search_memory): Likewise.
1467
1468 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1469
1470         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1471         (hppa_gdbarch_init): Don't register deleted functions with
1472         gdbarch.
1473
1474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1475
1476         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1477         (h8300_unwind_sp): Delete.
1478         (h8300_dummy_id): Delete.
1479         (h8300_gdbarch_init): Don't register deleted functions with
1480         gdbarch.
1481
1482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1483
1484         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1485         (ft32_unwind_pc): Delete.
1486         (ft32_unwind_sp): Delete.
1487         (ft32_gdbarch_init): Don't register deleted functions with
1488         gdbarch.
1489
1490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1491
1492         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1493         (frv_unwind_pc): Delete.
1494         (frv_unwind_sp): Delete.
1495         (frv_gdbarch_init): Don't register deleted functions with
1496         gdbarch.
1497
1498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1499
1500         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1501         (riscv_unwind_pc): Delete.
1502         (riscv_unwind_sp): Delete.
1503         (riscv_gdbarch_init): Don't register deleted functions with
1504         gdbarch.
1505
1506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1507
1508         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1509         (csky_unwind_pc): Delete.
1510         (csky_unwind_sp): Delete.
1511         (csky_gdbarch_init): Don't register deleted functions with
1512         gdbarch.
1513
1514 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1515
1516         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1517         (cris_unwind_pc): Delete.
1518         (cris_unwind_sp): Delete.
1519         (cris_gdbarch_init): Don't register deleted functions with
1520         gdbarch.
1521
1522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1523
1524         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1525         (bfin_unwind_pc): Delete.
1526         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1527
1528 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1529
1530         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1531         (arm_unwind_pc): Delete.
1532         (arm_unwind_sp): Delete.
1533         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1534
1535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1538         (arc_unwind_pc): Delete.
1539         (arc_unwind_sp): Delete.
1540         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1541
1542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1545         (alpha_unwind_pc): Delete.
1546         (alpha_gdbarch_init): Don't register deleted functions with
1547         gdbarch.
1548
1549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1552         (aarch64_unwind_pc): Delete.
1553         (aarch64_unwind_sp): Delete.
1554         (aarch64_gdbarch_init): Don't register deleted functions with
1555         gdbarch.
1556
1557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * gdbtypes.c (type_align): Don't consider static members when
1560         computing structure alignment.
1561
1562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1565         return 0 for other types.
1566         * arch-utils.c (default_type_align): Always return 0.
1567         * gdbarch.h: Regenerate.
1568         * gdbarch.sh (type_align): Extend comment.
1569         * gdbtypes.c (type_align): Add additional comments, always call
1570         gdbarch_type_align before applying the default rules.
1571         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1572         generic code will then apply a suitable default.
1573         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1574         types, return 0 for other types.
1575
1576 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1577
1578         * NEWS: Create a new section for the next release branch.
1579         Rename the section of the current branch, now that it has
1580         been cut.
1581
1582 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1583
1584         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1585         * version.in: Bump version to 8.3.50.DATE-git.
1586
1587 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1588
1589         * aix-thread.c (ptid_cmp): Remove unused variable.
1590         (get_signaled_thread): Likewise.
1591         (store_regs_user_thread): Likewise.
1592         (store_regs_kernel_thread): Likewise.
1593         (fetch_regs_kernel_thread): Remove shadowed variable.
1594
1595 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1596
1597         * features/riscv/32bit-cpu.xml: Add register numbers.
1598         * features/riscv/32bit-fpu.c: Regenerate.
1599         * features/riscv/32bit-fpu.xml: Add register numbers.
1600         * features/riscv/64bit-cpu.xml: Add register numbers.
1601         * features/riscv/64bit-fpu.c: Regenerate.
1602         * features/riscv/64bit-fpu.xml: Add register numbers.
1603
1604 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1605
1606         * NEWS: Mention two argument form of gdb.Value constructor.
1607         * python/py-value.c (convert_buffer_and_type_to_value): New
1608         function.
1609         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1610         Add support for handling an optional second argument.  Call
1611         convert_buffer_and_type_to_value as appropriate.
1612         * python/python-internal.h (Py_buffer_deleter): New struct.
1613         (Py_buffer_up): New typedef.
1614
1615 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1616
1617         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1618         instead of releasing ownership.
1619
1620 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1621
1622         * dwarf2read.c (open_and_init_dwp_file): Call
1623         elf_numsections instead of bfd_count_sections to initialize
1624         dwp_file->num_sections.
1625
1626 2019-02-25  Tom Tromey  <tromey@adacore.com>
1627
1628         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1629
1630 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1631
1632         * gcore.in: Add '--readnever' option when invoking GDB.
1633
1634 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1635
1636         * MAINTAINERS: Update my email address.
1637
1638 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1639
1640         * build-id.c (build_id_to_debug_bfd_1): New function.
1641         (build_id_to_debug_bfd): Look for separate debug file in
1642         sysroot.
1643
1644 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1645
1646         * gdbarch.sh: Update the copyright year range that is placed into
1647         generated files.
1648
1649 2019-02-22  Keith Seitz  <keiths@redhat.com>
1650
1651         PR symtab/23853
1652         * linespec.c (create_sals_line_offset): Search for the default
1653         symtab's filename instead of its fullname.
1654
1655 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1656
1657         * NEWS: Update style defaults.
1658
1659 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1660
1661         * main.c (captured_main_1): Disable styling in batch mode.
1662
1663 2019-02-20  Tom Tromey  <tom@tromey.com>
1664
1665         * symtab.c (symtab_symbol_info): Fix typos.
1666
1667 2019-02-20  Tom Tromey  <tromey@adacore.com>
1668
1669         * findcmd.c (_initialize_mem_search): Use upper case for
1670         metasyntactic variables.
1671
1672 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1673
1674         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1675         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1676
1677 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1678
1679         * top.h (source_file_name): Change to std::string.
1680         * top.c (source_file_name): Likewise.
1681         (command_line_input): Adjust.
1682         * cli/cli-script.c (script_from_file): Adjust.
1683
1684 2019-02-19  Tom Tromey  <tromey@adacore.com>
1685
1686         * ravenscar-thread.c
1687         (ravenscar_thread_target::update_thread_list): Don't call
1688         ada_build_task_list.
1689         * ada-lang.h (ada_build_task_list): Don't declare.
1690         * ada-tasks.c (struct ada_tasks_inferior_data)
1691         <task_list_valid_p>: Now bool.
1692         (read_known_tasks, ada_task_list_changed)
1693         (ada_tasks_invalidate_inferior_data): Update.
1694         (read_known_tasks_array): Return bool.
1695         (read_known_tasks_list): Likewise.
1696         (read_known_tasks): Return void.
1697         (ada_build_task_list): Now static.
1698
1699 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1700
1701         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1702         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1703
1704 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1705
1706         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1707         variant for ada_tasks_pspace_data_handle and
1708         ada_tasks_inferior_data_handle.
1709         (ada_tasks_pspace_data_cleanup): New function.
1710         (ada_tasks_inferior_data_cleanup): New function.
1711
1712 2019-02-17  Tom Tromey  <tom@tromey.com>
1713
1714         * macrotab.h (macro_source_fullname): Return a std::string.
1715         * macrotab.c (macro_include, check_for_redefinition)
1716         (macro_undef, macro_lookup_definition, foreach_macro)
1717         (foreach_macro_in_scope): Update.
1718         (macro_source_fullname): Return a std::string.
1719         * macrocmd.c (show_pp_source_pos): Update.
1720
1721 2019-02-17  Tom Tromey  <tom@tromey.com>
1722
1723         * macrocmd.c (show_pp_source_pos): Style the file names.
1724
1725 2019-02-17  Tom Tromey  <tom@tromey.com>
1726
1727         PR tui/24197:
1728         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1729
1730 2019-02-17  Tom Tromey  <tom@tromey.com>
1731
1732         * ada-lang.c (user_select_syms): Use filtered printing.
1733         * utils.c (wrap_style): New global.
1734         (desired_style): Remove.
1735         (emit_style_escape): Add stream parameter.
1736         (set_output_style, reset_terminal_style, prompt_for_continue):
1737         Update.
1738         (flush_wrap_buffer): Only flush gdb_stdout.
1739         (wrap_here): Set wrap_style.
1740         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1741         treat escape sequences as a character.  Change when wrap buffer is
1742         flushed.
1743         (fputs_styled): Do not set the output style when the default is
1744         requested.
1745         * ui-style.h (struct ui_file_style) <is_default>: New method.
1746         * source.c (print_source_lines_base): Emit escape sequences in one
1747         piece.
1748
1749 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1750
1751         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1752         integers and enumeration types.
1753
1754 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1755
1756         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1757         instead of lookup_symbol_in_language
1758         (do_exact_match): New function.
1759         (ada_get_symbol_name_matcher): Return do_exact_match when
1760         doing a verbatim match.
1761
1762 2019-02-15  Tom Tromey  <tromey@adacore.com>
1763
1764         * ravenscar-thread.c (ravenscar_thread_target::resume)
1765         (ravenscar_thread_target::wait): Special case wildcard requests.
1766
1767 2019-02-15  Tom Tromey  <tromey@adacore.com>
1768
1769         * ravenscar-thread.c (base_ptid): Remove.
1770         (struct ravenscar_thread_target) <close>: New method.
1771         <m_base_ptid>: New member.
1772         <update_inferior_ptid, active_task, task_is_currently_active,
1773         runtime_initialized>: Declare methods.
1774         <ravenscar_thread_target>: Add constructor.
1775         (ravenscar_thread_target::task_is_currently_active)
1776         (ravenscar_thread_target::update_inferior_ptid)
1777         (ravenscar_runtime_initialized): Rename.  Now methods.
1778         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1779         (ravenscar_thread_target::update_thread_list): Update.
1780         (ravenscar_thread_target::active_task): Now method.
1781         (ravenscar_thread_target::store_registers)
1782         (ravenscar_thread_target::prepare_to_store)
1783         (ravenscar_thread_target::prepare_to_store)
1784         (ravenscar_thread_target::mourn_inferior): Update.
1785         (ravenscar_inferior_created): Use "new" to create target.
1786         (ravenscar_thread_target::get_ada_task_ptid): Update.
1787         (_initialize_ravenscar): Don't initialize base_ptid.
1788         (ravenscar_ops): Remove global.
1789
1790 2019-02-15  Tom Tromey  <tromey@adacore.com>
1791
1792         * target.h (push_target): Declare new overload.
1793         * target.c (push_target): New overload, taking an rvalue reference.
1794         * remote.c (remote_target::open_1): Use push_target overload.
1795         * corelow.c (core_target_open): Use push_target overload.
1796
1797 2019-02-15  Tom Tromey  <tromey@adacore.com>
1798
1799         * ravenscar-thread.c (is_ravenscar_task)
1800         (ravenscar_task_is_currently_active): Return bool.
1801         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1802         (_initialize_ravenscar): Remove "(void)".
1803         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1804         Return bool.
1805
1806 2019-02-15  Tom Tromey  <tromey@adacore.com>
1807
1808         * ravenscar-thread.c (ravenscar_runtime_initializer)
1809         (has_ravenscar_runtime, get_running_thread_id)
1810         (ravenscar_thread_target::resume): Fix indentation.
1811
1812 2019-02-15  Tom Tromey  <tromey@adacore.com>
1813
1814         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1815         from ravenscar_arch_ops.
1816         (sparc_ravenscar_ops::fetch_registers)
1817         (sparc_ravenscar_ops::store_registers): Now methods.
1818         (sparc_ravenscar_prepare_to_store): Remove.
1819         (sparc_ravenscar_ops): Redefine.
1820         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1821         methods and destructor.  Remove members.
1822         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1823         (ravenscar_thread_target::store_registers)
1824         (ravenscar_thread_target::prepare_to_store): Update.
1825         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1826         Remove.
1827         (struct ppc_ravenscar_powerpc_ops): Derive from
1828         ravenscar_arch_ops.
1829         (ppc_ravenscar_powerpc_ops::fetch_registers)
1830         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1831         (ppc_ravenscar_powerpc_ops): Redefine.
1832         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1833         (ppc_ravenscar_e500_ops::fetch_registers)
1834         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1835         (ppc_ravenscar_e500_ops): Redefine.
1836         * aarch64-ravenscar-thread.c
1837         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1838         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1839         (aarch64_ravenscar_fetch_registers)
1840         (aarch64_ravenscar_store_registers): Now methods.
1841         (aarch64_ravenscar_ops): Redefine.
1842
1843 2019-02-15  Tom Tromey  <tromey@adacore.com>
1844
1845         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1846         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1847         (ravenscar_thread_target::stopped_by_watchpoint)
1848         (ravenscar_thread_target::stopped_data_address)
1849         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1850
1851 2019-02-15  Tom Tromey  <tromey@adacore.com>
1852
1853         * ravenscar-thread.c: Fix some typos.
1854
1855 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1856             Tom Tromey  <tromey@adacore.com>
1857
1858         * ada-lang.c (ada_exception_sal): Change addr_string to a
1859         std::string.
1860         (create_ada_exception_catchpoint): Update.
1861
1862 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1863             Tom Tromey  <tromey@adacore.com>
1864
1865         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1866         (bp_location_ops): Remove.
1867         (base_breakpoint_allocate_location): Update.
1868         (free_bp_location): Update.
1869         * ada-lang.c (class ada_catchpoint_location)
1870         <ada_catchpoint_location>: Remove ops parameter.
1871         (ada_catchpoint_location_dtor): Remove.
1872         (ada_catchpoint_location_ops): Remove.
1873         (allocate_location_exception): Update.
1874         * breakpoint.h (struct bp_location_ops): Remove.
1875         (class bp_location) <bp_location>: Remove bp_location_ops
1876         parameter.
1877         <~bp_location>: Add destructor.
1878         <ops>: Remove.
1879
1880 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1881             Pedro Alves  <palves@redhat.com>
1882
1883         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1884         'PATH_MAX'.
1885
1886 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1887             Samuel Thibault  <samuel.thibault@gnu.org>
1888             Thomas Schwinge  <thomas@codesourcery.com>
1889
1890         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1891         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1892
1893 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1894
1895         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1896         (check_empty): Use "const char *".
1897
1898         * gnu-nat.c (gnu_nat_target::detach): Instead of
1899         'detach_inferior (pid)' call
1900         'detach_inferior (find_inferior_pid (pid))'.
1901
1902         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1903         'nat/fork-inferior.o'.
1904         * gnu-nat.c: #include "nat/fork-inferior.h".
1905
1906         * gnu-nat.c (gnu_nat_target::detach): Instead of
1907         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1908         * gnu-nat.h: #include "inf-child.h".
1909         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1910         'i386_gnu_nat_target::fetch_registers'.
1911         (gnu_store_registers): Rename/move to
1912         'i386_gnu_nat_target::store_registers'.
1913
1914         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1915         * gnu-nat.h (mach_thread_info): New function.
1916         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1917
1918         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1919
1920 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1921
1922         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1923
1924 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1925
1926         * windows-nat.c (windows_add_thread): Add new parameter
1927         "main_thread_p" with default value set to false.  Update
1928         function documentation as well as all callers.
1929         (windows_delete_thread): Likewise.
1930         (fake_create_process): Update call to windows_add_thread.
1931         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1932         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1933         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1934         call to windows_delete_thread.
1935
1936 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1937
1938         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1939
1940 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1941
1942         * symfile.c (find_separate_debug_file): Use canonical path of
1943         sysroot with child_path instead of gdb_sysroot if it is valid.
1944
1945 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1946
1947         * symfile.c (find_separate_debug_file): Use child_path to
1948         determine if an object file is under a sysroot.
1949
1950 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1951
1952         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1953         unittests/child-path-selftests.c.
1954         * common/pathstuff.c (child_path): New function.
1955         * common/pathstuff.h (child_path): New prototype.
1956         * unittests/child-path-selftests.c: New file.
1957
1958 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1959
1960         * symfile.c (find_separate_debug_file): Look for separate debug
1961         files in debug directories under the sysroot.
1962
1963 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1964
1965         * symtab.h (struct minimal_symbol data_p): New const method.
1966         (struct minimal_symbol text_p): Likewise.
1967         * symtab.c (output_source_filename): Use file name style
1968         to print file name.
1969         (print_symbol_info): Likewise.
1970         (print_msymbol_info): Use address style to print addresses.
1971         Use function name style to print executable text symbols.
1972         (expand_symtab_containing_pc): Use data_p.
1973         (find_pc_sect_compunit_symtab): Likewise.
1974
1975 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1976
1977         * breakpoint.c (describe_other_breakpoints): Use address style
1978         to print addresses.
1979         (say_where): Likewise.
1980
1981 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1982
1983         * ada-typeprint.c (print_func_type): Print function name
1984         style to print function name.
1985         * c-typeprint.c (c_print_type_1): Likewise.
1986
1987 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1988
1989         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1990         for execve.
1991
1992 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1993
1994         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1995         type_stack.
1996
1997 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1998
1999         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2000         TYPE_CODE_REF types.
2001
2002 2019-02-08  Jim Wilson  <jimw@sifive.com>
2003
2004         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2005         (riscv_linux_fregset): New.
2006         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2007
2008 2019-02-07  Tom Tromey  <tom@tromey.com>
2009
2010         * thread.c (thread_cancel_execution_command): Update.
2011         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2012         methods.
2013         (struct thread_fsm_ops): Remove.
2014         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2015         (thread_fsm_should_stop, thread_fsm_return_value)
2016         (thread_fsm_set_finished, thread_fsm_finished_p)
2017         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2018         Don't declare.
2019         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2020         * infrun.c (clear_proceed_status_thread)
2021         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2022         (print_stop_event): Update.
2023         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2024         Add constructor.
2025         (step_command_fsm_ops): Remove.
2026         (new_step_command_fsm): Remove.
2027         (step_1): Update.
2028         (step_command_fsm::should_stop): Rename from
2029         step_command_fsm_should_stop.
2030         (step_command_fsm::clean_up): Rename from
2031         step_command_fsm_clean_up.
2032         (step_command_fsm::do_async_reply_reason): Rename from
2033         step_command_fsm_async_reply_reason.
2034         (struct until_next_fsm): Inherit from thread_fsm.  Add
2035         constructor.
2036         (until_next_fsm_ops): Remove.
2037         (new_until_next_fsm): Remove.
2038         (until_next_fsm::should_stop): Rename from
2039         until_next_fsm_should_stop.
2040         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2041         (until_next_fsm::do_async_reply_reason): Rename from
2042         until_next_fsm_async_reply_reason.
2043         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2044         constructor.  Change type of breakpoint.
2045         (finish_command_fsm_ops): Remove.
2046         (new_finish_command_fsm): Remove.
2047         (finish_command_fsm::should_stop): Rename from
2048         finish_command_fsm_should_stop.
2049         (finish_command_fsm::clean_up): Rename from
2050         finish_command_fsm_clean_up.
2051         (finish_command_fsm::return_value): Rename from
2052         finish_command_fsm_return_value.
2053         (finish_command_fsm::do_async_reply_reason): Rename from
2054         finish_command_fsm_async_reply_reason.
2055         (finish_command): Update.
2056         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2057         Add constructor.
2058         (call_thread_fsm_ops): Remove.
2059         (call_thread_fsm::call_thread_fsm): Rename from
2060         new_call_thread_fsm.
2061         (call_thread_fsm::should_stop): Rename from
2062         call_thread_fsm_should_stop.
2063         (call_thread_fsm::should_notify_stop): Rename from
2064         call_thread_fsm_should_notify_stop.
2065         (run_inferior_call, call_function_by_hand_dummy): Update.
2066         * cli/cli-interp.c (should_print_stop_to_console): Update.
2067         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2068         Add constructor.  Change type of location_breakpoint,
2069         caller_breakpoint.
2070         (until_break_fsm_ops): Remove.
2071         (new_until_break_fsm): Remove.
2072         (until_break_fsm::should_stop): Rename from
2073         until_break_fsm_should_stop.
2074         (until_break_fsm::clean_up): Rename from
2075         until_break_fsm_clean_up.
2076         (until_break_fsm::do_async_reply_reason): Rename from
2077         until_break_fsm_async_reply_reason.
2078         (until_break_command): Update.
2079         * thread-fsm.c: Remove.
2080         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2081
2082 2019-02-07  Tom Tromey  <tom@tromey.com>
2083
2084         * yy-remap.h: Add include guard.
2085         * xtensa-tdep.h: Add include guard.
2086         * xcoffread.h: Rename include guard.
2087         * varobj-iter.h: Add include guard.
2088         * tui/tui.h: Rename include guard.
2089         * tui/tui-winsource.h: Rename include guard.
2090         * tui/tui-wingeneral.h: Rename include guard.
2091         * tui/tui-windata.h: Rename include guard.
2092         * tui/tui-win.h: Rename include guard.
2093         * tui/tui-stack.h: Rename include guard.
2094         * tui/tui-source.h: Rename include guard.
2095         * tui/tui-regs.h: Rename include guard.
2096         * tui/tui-out.h: Rename include guard.
2097         * tui/tui-layout.h: Rename include guard.
2098         * tui/tui-io.h: Rename include guard.
2099         * tui/tui-hooks.h: Rename include guard.
2100         * tui/tui-file.h: Rename include guard.
2101         * tui/tui-disasm.h: Rename include guard.
2102         * tui/tui-data.h: Rename include guard.
2103         * tui/tui-command.h: Rename include guard.
2104         * tic6x-tdep.h: Add include guard.
2105         * target/waitstatus.h: Rename include guard.
2106         * target/wait.h: Rename include guard.
2107         * target/target.h: Rename include guard.
2108         * target/resume.h: Rename include guard.
2109         * target-float.h: Rename include guard.
2110         * stabsread.h: Add include guard.
2111         * rs6000-tdep.h: Add include guard.
2112         * riscv-fbsd-tdep.h: Add include guard.
2113         * regformats/regdef.h: Rename include guard.
2114         * record.h: Rename include guard.
2115         * python/python.h: Rename include guard.
2116         * python/python-internal.h: Rename include guard.
2117         * python/py-stopevent.h: Rename include guard.
2118         * python/py-ref.h: Rename include guard.
2119         * python/py-record.h: Rename include guard.
2120         * python/py-record-full.h: Rename include guard.
2121         * python/py-record-btrace.h: Rename include guard.
2122         * python/py-instruction.h: Rename include guard.
2123         * python/py-events.h: Rename include guard.
2124         * python/py-event.h: Rename include guard.
2125         * procfs.h: Add include guard.
2126         * proc-utils.h: Add include guard.
2127         * p-lang.h: Add include guard.
2128         * or1k-tdep.h: Rename include guard.
2129         * observable.h: Rename include guard.
2130         * nto-tdep.h: Rename include guard.
2131         * nat/x86-linux.h: Rename include guard.
2132         * nat/x86-linux-dregs.h: Rename include guard.
2133         * nat/x86-gcc-cpuid.h: Add include guard.
2134         * nat/x86-dregs.h: Rename include guard.
2135         * nat/x86-cpuid.h: Rename include guard.
2136         * nat/ppc-linux.h: Rename include guard.
2137         * nat/mips-linux-watch.h: Rename include guard.
2138         * nat/linux-waitpid.h: Rename include guard.
2139         * nat/linux-ptrace.h: Rename include guard.
2140         * nat/linux-procfs.h: Rename include guard.
2141         * nat/linux-osdata.h: Rename include guard.
2142         * nat/linux-nat.h: Rename include guard.
2143         * nat/linux-namespaces.h: Rename include guard.
2144         * nat/linux-btrace.h: Rename include guard.
2145         * nat/glibc_thread_db.h: Rename include guard.
2146         * nat/gdb_thread_db.h: Rename include guard.
2147         * nat/gdb_ptrace.h: Rename include guard.
2148         * nat/fork-inferior.h: Rename include guard.
2149         * nat/amd64-linux-siginfo.h: Rename include guard.
2150         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2151         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2152         * nat/aarch64-linux.h: Rename include guard.
2153         * nat/aarch64-linux-hw-point.h: Rename include guard.
2154         * mn10300-tdep.h: Add include guard.
2155         * mips-linux-tdep.h: Add include guard.
2156         * mi/mi-parse.h: Rename include guard.
2157         * mi/mi-out.h: Rename include guard.
2158         * mi/mi-main.h: Rename include guard.
2159         * mi/mi-interp.h: Rename include guard.
2160         * mi/mi-getopt.h: Rename include guard.
2161         * mi/mi-console.h: Rename include guard.
2162         * mi/mi-common.h: Rename include guard.
2163         * mi/mi-cmds.h: Rename include guard.
2164         * mi/mi-cmd-break.h: Rename include guard.
2165         * m2-lang.h: Add include guard.
2166         * location.h: Rename include guard.
2167         * linux-record.h: Rename include guard.
2168         * linux-nat.h: Add include guard.
2169         * linux-fork.h: Add include guard.
2170         * i386-darwin-tdep.h: Rename include guard.
2171         * hppa-linux-offsets.h: Add include guard.
2172         * guile/guile.h: Rename include guard.
2173         * guile/guile-internal.h: Rename include guard.
2174         * gnu-nat.h: Rename include guard.
2175         * gdb-stabs.h: Rename include guard.
2176         * frv-tdep.h: Add include guard.
2177         * f-lang.h: Add include guard.
2178         * event-loop.h: Add include guard.
2179         * darwin-nat.h: Rename include guard.
2180         * cp-abi.h: Rename include guard.
2181         * config/sparc/nm-sol2.h: Rename include guard.
2182         * config/nm-nto.h: Rename include guard.
2183         * config/nm-linux.h: Add include guard.
2184         * config/i386/nm-i386gnu.h: Rename include guard.
2185         * config/djgpp/nl_types.h: Rename include guard.
2186         * config/djgpp/langinfo.h: Rename include guard.
2187         * compile/gcc-cp-plugin.h: Add include guard.
2188         * compile/gcc-c-plugin.h: Add include guard.
2189         * compile/compile.h: Rename include guard.
2190         * compile/compile-object-run.h: Rename include guard.
2191         * compile/compile-object-load.h: Rename include guard.
2192         * compile/compile-internal.h: Rename include guard.
2193         * compile/compile-cplus.h: Rename include guard.
2194         * compile/compile-c.h: Rename include guard.
2195         * common/xml-utils.h: Rename include guard.
2196         * common/x86-xstate.h: Rename include guard.
2197         * common/version.h: Rename include guard.
2198         * common/vec.h: Rename include guard.
2199         * common/tdesc.h: Rename include guard.
2200         * common/selftest.h: Rename include guard.
2201         * common/scoped_restore.h: Rename include guard.
2202         * common/scoped_mmap.h: Rename include guard.
2203         * common/scoped_fd.h: Rename include guard.
2204         * common/safe-iterator.h: Rename include guard.
2205         * common/run-time-clock.h: Rename include guard.
2206         * common/refcounted-object.h: Rename include guard.
2207         * common/queue.h: Rename include guard.
2208         * common/ptid.h: Rename include guard.
2209         * common/print-utils.h: Rename include guard.
2210         * common/preprocessor.h: Rename include guard.
2211         * common/pathstuff.h: Rename include guard.
2212         * common/observable.h: Rename include guard.
2213         * common/netstuff.h: Rename include guard.
2214         * common/job-control.h: Rename include guard.
2215         * common/host-defs.h: Rename include guard.
2216         * common/gdb_wait.h: Rename include guard.
2217         * common/gdb_vecs.h: Rename include guard.
2218         * common/gdb_unlinker.h: Rename include guard.
2219         * common/gdb_unique_ptr.h: Rename include guard.
2220         * common/gdb_tilde_expand.h: Rename include guard.
2221         * common/gdb_sys_time.h: Rename include guard.
2222         * common/gdb_string_view.h: Rename include guard.
2223         * common/gdb_splay_tree.h: Rename include guard.
2224         * common/gdb_setjmp.h: Rename include guard.
2225         * common/gdb_ref_ptr.h: Rename include guard.
2226         * common/gdb_optional.h: Rename include guard.
2227         * common/gdb_locale.h: Rename include guard.
2228         * common/gdb_assert.h: Rename include guard.
2229         * common/filtered-iterator.h: Rename include guard.
2230         * common/filestuff.h: Rename include guard.
2231         * common/fileio.h: Rename include guard.
2232         * common/environ.h: Rename include guard.
2233         * common/common-utils.h: Rename include guard.
2234         * common/common-types.h: Rename include guard.
2235         * common/common-regcache.h: Rename include guard.
2236         * common/common-inferior.h: Rename include guard.
2237         * common/common-gdbthread.h: Rename include guard.
2238         * common/common-exceptions.h: Rename include guard.
2239         * common/common-defs.h: Rename include guard.
2240         * common/common-debug.h: Rename include guard.
2241         * common/cleanups.h: Rename include guard.
2242         * common/buffer.h: Rename include guard.
2243         * common/btrace-common.h: Rename include guard.
2244         * common/break-common.h: Rename include guard.
2245         * cli/cli-utils.h: Rename include guard.
2246         * cli/cli-style.h: Rename include guard.
2247         * cli/cli-setshow.h: Rename include guard.
2248         * cli/cli-script.h: Rename include guard.
2249         * cli/cli-interp.h: Rename include guard.
2250         * cli/cli-decode.h: Rename include guard.
2251         * cli/cli-cmds.h: Rename include guard.
2252         * charset-list.h: Add include guard.
2253         * buildsym-legacy.h: Rename include guard.
2254         * bfin-tdep.h: Add include guard.
2255         * ax.h: Rename include guard.
2256         * arm-linux-tdep.h: Add include guard.
2257         * arm-fbsd-tdep.h: Add include guard.
2258         * arch/xtensa.h: Rename include guard.
2259         * arch/tic6x.h: Add include guard.
2260         * arch/i386.h: Add include guard.
2261         * arch/arm.h: Rename include guard.
2262         * arch/arm-linux.h: Rename include guard.
2263         * arch/arm-get-next-pcs.h: Rename include guard.
2264         * arch/amd64.h: Add include guard.
2265         * arch/aarch64-insn.h: Rename include guard.
2266         * arch-utils.h: Rename include guard.
2267         * annotate.h: Add include guard.
2268         * amd64-darwin-tdep.h: Rename include guard.
2269         * aarch64-linux-tdep.h: Add include guard.
2270         * aarch64-fbsd-tdep.h: Add include guard.
2271         * aarch32-linux-nat.h: Add include guard.
2272
2273 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2274
2275         * macrotab.c (macro_define_internal): New function that
2276         factorizes macro_define_object_internal and macro_define_function
2277         code.
2278         (macro_define_object_internal): Use macro_define_internal.
2279         (macro_define_function): Likewise.
2280
2281 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2282
2283         * macrocmd.c (extract_identifier): Return
2284         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2285         callers.
2286
2287 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2288
2289         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2290
2291 2019-02-05  Tom Tromey  <tom@tromey.com>
2292
2293         * target.c (target_stack::unpush): Move assertion earlier.
2294
2295 2019-01-30  Tom Tromey  <tom@tromey.com>
2296
2297         PR python/23615:
2298         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2299         (gdbpy_parse_and_eval): Likewise.
2300         * python/python-internal.h (gdbpy_allow_threads): New class.
2301
2302 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2303
2304         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2305         (aarch64_fbsd_fpregmap): Move earlier.
2306         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2307         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2308         instead of individual calls to trad_frame_set_reg_addr.
2309         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2310         earlier.
2311         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2312         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2313         instead of individual calls to trad_frame_set_reg_addr.
2314
2315 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2316
2317         * CONTRIBUTE: Replace contribution list with wiki link.
2318
2319 2019-01-25  Tom Tromey  <tom@tromey.com>
2320
2321         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2322
2323 2019-01-25  Tom Tromey  <tom@tromey.com>
2324
2325         * xtensa-linux-nat.c: Fix common/ includes.
2326         * xml-support.h: Fix common/ includes.
2327         * xml-support.c: Fix common/ includes.
2328         * x86-linux-nat.c: Fix common/ includes.
2329         * windows-nat.c: Fix common/ includes.
2330         * varobj.h: Fix common/ includes.
2331         * varobj.c: Fix common/ includes.
2332         * value.c: Fix common/ includes.
2333         * valops.c: Fix common/ includes.
2334         * utils.c: Fix common/ includes.
2335         * unittests/xml-utils-selftests.c: Fix common/ includes.
2336         * unittests/utils-selftests.c: Fix common/ includes.
2337         * unittests/unpack-selftests.c: Fix common/ includes.
2338         * unittests/tracepoint-selftests.c: Fix common/ includes.
2339         * unittests/style-selftests.c: Fix common/ includes.
2340         * unittests/string_view-selftests.c: Fix common/ includes.
2341         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2342         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2343         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2344         * unittests/rsp-low-selftests.c: Fix common/ includes.
2345         * unittests/parse-connection-spec-selftests.c: Fix common/
2346         includes.
2347         * unittests/optional-selftests.c: Fix common/ includes.
2348         * unittests/offset-type-selftests.c: Fix common/ includes.
2349         * unittests/observable-selftests.c: Fix common/ includes.
2350         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2351         * unittests/memrange-selftests.c: Fix common/ includes.
2352         * unittests/memory-map-selftests.c: Fix common/ includes.
2353         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2354         * unittests/function-view-selftests.c: Fix common/ includes.
2355         * unittests/environ-selftests.c: Fix common/ includes.
2356         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2357         * unittests/common-utils-selftests.c: Fix common/ includes.
2358         * unittests/cli-utils-selftests.c: Fix common/ includes.
2359         * unittests/array-view-selftests.c: Fix common/ includes.
2360         * ui-file.c: Fix common/ includes.
2361         * tui/tui-io.c: Fix common/ includes.
2362         * tracepoint.h: Fix common/ includes.
2363         * tracepoint.c: Fix common/ includes.
2364         * tracefile-tfile.c: Fix common/ includes.
2365         * top.h: Fix common/ includes.
2366         * top.c: Fix common/ includes.
2367         * thread.c: Fix common/ includes.
2368         * target/waitstatus.h: Fix common/ includes.
2369         * target/waitstatus.c: Fix common/ includes.
2370         * target.h: Fix common/ includes.
2371         * target.c: Fix common/ includes.
2372         * target-memory.c: Fix common/ includes.
2373         * target-descriptions.c: Fix common/ includes.
2374         * symtab.h: Fix common/ includes.
2375         * symfile.c: Fix common/ includes.
2376         * stap-probe.c: Fix common/ includes.
2377         * spu-linux-nat.c: Fix common/ includes.
2378         * sparc-nat.c: Fix common/ includes.
2379         * source.c: Fix common/ includes.
2380         * solib.c: Fix common/ includes.
2381         * solib-target.c: Fix common/ includes.
2382         * ser-unix.c: Fix common/ includes.
2383         * ser-tcp.c: Fix common/ includes.
2384         * ser-pipe.c: Fix common/ includes.
2385         * ser-base.c: Fix common/ includes.
2386         * selftest-arch.c: Fix common/ includes.
2387         * s12z-tdep.c: Fix common/ includes.
2388         * rust-exp.y: Fix common/ includes.
2389         * rs6000-aix-tdep.c: Fix common/ includes.
2390         * riscv-tdep.c: Fix common/ includes.
2391         * remote.c: Fix common/ includes.
2392         * remote-notif.h: Fix common/ includes.
2393         * remote-fileio.h: Fix common/ includes.
2394         * remote-fileio.c: Fix common/ includes.
2395         * regcache.h: Fix common/ includes.
2396         * regcache.c: Fix common/ includes.
2397         * record-btrace.c: Fix common/ includes.
2398         * python/python.c: Fix common/ includes.
2399         * python/py-type.c: Fix common/ includes.
2400         * python/py-inferior.c: Fix common/ includes.
2401         * progspace.h: Fix common/ includes.
2402         * producer.c: Fix common/ includes.
2403         * procfs.c: Fix common/ includes.
2404         * proc-api.c: Fix common/ includes.
2405         * printcmd.c: Fix common/ includes.
2406         * ppc-linux-nat.c: Fix common/ includes.
2407         * parser-defs.h: Fix common/ includes.
2408         * osdata.c: Fix common/ includes.
2409         * obsd-nat.c: Fix common/ includes.
2410         * nat/x86-linux.c: Fix common/ includes.
2411         * nat/x86-linux-dregs.c: Fix common/ includes.
2412         * nat/x86-dregs.h: Fix common/ includes.
2413         * nat/x86-dregs.c: Fix common/ includes.
2414         * nat/ppc-linux.c: Fix common/ includes.
2415         * nat/mips-linux-watch.h: Fix common/ includes.
2416         * nat/mips-linux-watch.c: Fix common/ includes.
2417         * nat/linux-waitpid.c: Fix common/ includes.
2418         * nat/linux-ptrace.h: Fix common/ includes.
2419         * nat/linux-ptrace.c: Fix common/ includes.
2420         * nat/linux-procfs.c: Fix common/ includes.
2421         * nat/linux-personality.c: Fix common/ includes.
2422         * nat/linux-osdata.c: Fix common/ includes.
2423         * nat/linux-namespaces.c: Fix common/ includes.
2424         * nat/linux-btrace.h: Fix common/ includes.
2425         * nat/linux-btrace.c: Fix common/ includes.
2426         * nat/fork-inferior.c: Fix common/ includes.
2427         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2428         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2429         * nat/aarch64-linux.c: Fix common/ includes.
2430         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2431         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2432         * namespace.h: Fix common/ includes.
2433         * mips-linux-tdep.c: Fix common/ includes.
2434         * minsyms.c: Fix common/ includes.
2435         * mi/mi-parse.h: Fix common/ includes.
2436         * mi/mi-main.c: Fix common/ includes.
2437         * mi/mi-cmd-env.c: Fix common/ includes.
2438         * memrange.h: Fix common/ includes.
2439         * memattr.c: Fix common/ includes.
2440         * maint.h: Fix common/ includes.
2441         * maint.c: Fix common/ includes.
2442         * main.c: Fix common/ includes.
2443         * machoread.c: Fix common/ includes.
2444         * location.c: Fix common/ includes.
2445         * linux-thread-db.c: Fix common/ includes.
2446         * linux-nat.c: Fix common/ includes.
2447         * linux-fork.c: Fix common/ includes.
2448         * inline-frame.c: Fix common/ includes.
2449         * infrun.c: Fix common/ includes.
2450         * inflow.c: Fix common/ includes.
2451         * inferior.h: Fix common/ includes.
2452         * inferior.c: Fix common/ includes.
2453         * infcmd.c: Fix common/ includes.
2454         * inf-ptrace.c: Fix common/ includes.
2455         * inf-child.c: Fix common/ includes.
2456         * ia64-linux-nat.c: Fix common/ includes.
2457         * i387-tdep.c: Fix common/ includes.
2458         * i386-tdep.c: Fix common/ includes.
2459         * i386-linux-tdep.c: Fix common/ includes.
2460         * i386-linux-nat.c: Fix common/ includes.
2461         * i386-go32-tdep.c: Fix common/ includes.
2462         * i386-fbsd-tdep.c: Fix common/ includes.
2463         * i386-fbsd-nat.c: Fix common/ includes.
2464         * guile/scm-type.c: Fix common/ includes.
2465         * guile/guile.c: Fix common/ includes.
2466         * go32-nat.c: Fix common/ includes.
2467         * gnu-nat.c: Fix common/ includes.
2468         * gdbthread.h: Fix common/ includes.
2469         * gdbarch-selftests.c: Fix common/ includes.
2470         * gdb_usleep.c: Fix common/ includes.
2471         * gdb_select.h: Fix common/ includes.
2472         * gdb_bfd.c: Fix common/ includes.
2473         * gcore.c: Fix common/ includes.
2474         * fork-child.c: Fix common/ includes.
2475         * findvar.c: Fix common/ includes.
2476         * fbsd-nat.c: Fix common/ includes.
2477         * event-top.c: Fix common/ includes.
2478         * event-loop.c: Fix common/ includes.
2479         * dwarf2read.c: Fix common/ includes.
2480         * dwarf2loc.c: Fix common/ includes.
2481         * dwarf2-frame.c: Fix common/ includes.
2482         * dwarf-index-cache.c: Fix common/ includes.
2483         * dtrace-probe.c: Fix common/ includes.
2484         * disasm-selftests.c: Fix common/ includes.
2485         * defs.h: Fix common/ includes.
2486         * csky-tdep.c: Fix common/ includes.
2487         * cp-valprint.c: Fix common/ includes.
2488         * cp-support.h: Fix common/ includes.
2489         * cp-support.c: Fix common/ includes.
2490         * corelow.c: Fix common/ includes.
2491         * completer.h: Fix common/ includes.
2492         * completer.c: Fix common/ includes.
2493         * compile/compile.c: Fix common/ includes.
2494         * compile/compile-loc2c.c: Fix common/ includes.
2495         * compile/compile-cplus-types.c: Fix common/ includes.
2496         * compile/compile-cplus-symbols.c: Fix common/ includes.
2497         * command.h: Fix common/ includes.
2498         * cli/cli-dump.c: Fix common/ includes.
2499         * cli/cli-cmds.c: Fix common/ includes.
2500         * charset.c: Fix common/ includes.
2501         * build-id.c: Fix common/ includes.
2502         * btrace.h: Fix common/ includes.
2503         * btrace.c: Fix common/ includes.
2504         * breakpoint.h: Fix common/ includes.
2505         * breakpoint.c: Fix common/ includes.
2506         * ax.h:
2507         (enum agent_op): Fix common/ includes.
2508         * ax-general.c (struct aop_map): Fix common/ includes.
2509         * ax-gdb.c: Fix common/ includes.
2510         * auxv.c: Fix common/ includes.
2511         * auto-load.c: Fix common/ includes.
2512         * arm-tdep.c: Fix common/ includes.
2513         * arch/riscv.c: Fix common/ includes.
2514         * arch/ppc-linux-common.c: Fix common/ includes.
2515         * arch/i386.c: Fix common/ includes.
2516         * arch/arm.c: Fix common/ includes.
2517         * arch/arm-linux.c: Fix common/ includes.
2518         * arch/arm-get-next-pcs.c: Fix common/ includes.
2519         * arch/amd64.c: Fix common/ includes.
2520         * arch/aarch64.c: Fix common/ includes.
2521         * arch/aarch64-insn.c: Fix common/ includes.
2522         * arch-utils.c: Fix common/ includes.
2523         * amd64-windows-tdep.c: Fix common/ includes.
2524         * amd64-tdep.c: Fix common/ includes.
2525         * amd64-sol2-tdep.c: Fix common/ includes.
2526         * amd64-obsd-tdep.c: Fix common/ includes.
2527         * amd64-nbsd-tdep.c: Fix common/ includes.
2528         * amd64-linux-tdep.c: Fix common/ includes.
2529         * amd64-linux-nat.c: Fix common/ includes.
2530         * amd64-fbsd-tdep.c: Fix common/ includes.
2531         * amd64-fbsd-nat.c: Fix common/ includes.
2532         * amd64-dicos-tdep.c: Fix common/ includes.
2533         * amd64-darwin-tdep.c: Fix common/ includes.
2534         * agent.c: Fix common/ includes.
2535         * ada-lang.h: Fix common/ includes.
2536         * ada-lang.c: Fix common/ includes.
2537         * aarch64-tdep.c: Fix common/ includes.
2538
2539 2019-01-25  Tom Tromey  <tom@tromey.com>
2540
2541         * common/create-version.sh: Use common/version.h.
2542
2543 2019-01-24  Pedro Alves  <palves@redhat.com>
2544
2545         * infrun.c (signal_stop, signal_print, signal_program)
2546         (signal_catch, signal_pass): Now arrays instead of pointers.
2547         (update_signals_program_target, do_target_resume)
2548         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2549         * linux-nat.c (linux_nat_target::pass_signals)
2550         (linux_nat_target::create_inferior, linux_nat_target::attach):
2551         Adjust.
2552         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2553         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2554         * procfs.c (procfs_target::pass_signals): Adjust.
2555         * record-full.c (record_full_target::resume): Adjust.
2556         * remote.c (remote_target::pass_signals)
2557         (remote_target::program_signals): Adjust.
2558         * target-debug.h (target_debug_print_signals): Now takes a
2559         gdb::array_view as parameter.  Adjust.
2560         * target.h (target_ops) <pass_signals, program_signals>: Replace
2561         pointer and length parameters with gdb::array_view.
2562         (target_pass_signals, target_program_signals): Likewise.
2563         * target-delegates.c: Regenerate.
2564
2565 2019-01-24  Pedro Alves  <palves@redhat.com>
2566
2567         * common/forward-scope-exit.h
2568         (forward_scope_exit::forward_scope_exit): Pass arguments to
2569         m_bind_function directly, instead of creating a std::bind and
2570         copying that.
2571
2572 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2573
2574         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2575         for static members.
2576         (pass_in_v_vfp_candidate): Likewise.
2577
2578 2019-01-23  Tom Tromey  <tom@tromey.com>
2579             Pedro Alves  <palves@redhat.com>
2580
2581         * regcache.c (class regcache_invalidator): Remove.
2582         (regcache::raw_write): Use make_scope_exit.
2583
2584 2019-01-23  Tom Tromey  <tom@tromey.com>
2585
2586         * ui-out.h (class ui_out_emit_type): Update comment.
2587
2588 2019-01-23  Tom Tromey  <tom@tromey.com>
2589
2590         * infrun.c (fetch_inferior_event): Update comment.
2591
2592 2019-01-23  Tom Tromey  <tom@tromey.com>
2593             Pedro Alves  <palves@redhat.com>
2594
2595         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2596         parameter.
2597         (fetch_inferior_event): Use SCOPE_EXIT.
2598
2599
2600 2019-01-23  Tom Tromey  <tom@tromey.com>
2601             Pedro Alves  <palves@redhat.com>
2602
2603         * infrun.c (disable_thread_events): Delete.
2604         (stop_all_threads): Use SCOPE_EXIT.
2605
2606 2019-01-23  Tom Tromey  <tom@tromey.com>
2607             Pedro Alves  <palves@redhat.com>
2608
2609         * symfile.c: Include forward-scope-exit.h.
2610         (clear_symtab_users_cleanup): Replace forward declaration with
2611         a FORWARD_SCOPE_EXIT.
2612         (syms_from_objfile_1): Use the forward_scope_exit and
2613         gdb::optional instead of cleanup_function.
2614         (reread_symbols): Use the forward_scope_exit instead of
2615         cleanup_function.
2616         (clear_symtab_users_cleanup): Remove function.
2617
2618 2019-01-23  Tom Tromey  <tom@tromey.com>
2619             Pedro Alves  <palves@redhat.com>
2620
2621         * linux-nat.c: Include scope-exit.h.
2622         (cleanup_target_stop): Remove.
2623         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2624         SCOPE_EXIT.
2625
2626 2019-01-23  Tom Tromey  <tom@tromey.com>
2627             Pedro Alves  <palves@redhat.com>
2628
2629         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2630         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2631
2632 2019-01-23  Tom Tromey  <tom@tromey.com>
2633             Andrew Burgess  <andrew.burgess@embecosm.com>
2634             Pedro Alves  <palves@redhat.com>
2635
2636         * infrun.c (fetch_inferior_event): Use scope_exit.
2637         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2638         * top.c (execute_command): Use scope_exit.
2639         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2640         * utils.c (do_bpstat_clear_actions_cleanup)
2641         (make_bpstat_clear_actions_cleanup): Remove.
2642
2643 2019-01-23  Tom Tromey  <tom@tromey.com>
2644             Pedro Alves  <palves@redhat.com>
2645
2646         * infrun.c: Include "common/scope-exit.h"
2647         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2648         (wait_for_inferior): Use SCOPE_EXIT.
2649         (fetch_inferior_event): Use scope_exit.
2650
2651 2019-01-23  Tom Tromey  <tom@tromey.com>
2652             Pedro Alves  <palves@redhat.com>
2653
2654         * breakpoint.c (create_breakpoint): Remove cleanup.
2655
2656 2019-01-23  Tom Tromey  <tom@tromey.com>
2657             Andrew Burgess  <andrew.burgess@embecosm.com>
2658             Pedro Alves  <palves@redhat.com>
2659
2660 2019-01-23  Pedro Alves  <palves@redhat.com>
2661
2662         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2663
2664 2019-01-23  Pedro Alves  <palves@redhat.com>
2665             Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * gdbthread.h: Include "common/forward-scope-exit.h".
2668         (scoped_finish_thread_state): Redefine custom class in terms of
2669         forward_scope_exit.
2670
2671 2019-01-23  Pedro Alves  <palves@redhat.com>
2672             Andrew Burgess  <andrew.burgess@embecosm.com>
2673
2674         * common/forward-scope-exit.h: New file.
2675
2676 2019-01-23  Pedro Alves  <palves@redhat.com>
2677             Andrew Burgess  <andrew.burgess@embecosm.com>
2678             Tom Tromey  <tom@tromey.com>
2679
2680         * common/scope-exit.h: New file.
2681
2682 2019-01-23  Pedro Alves  <palves@redhat.com>
2683
2684         * common/preprocessor.h (ESC): Rename to ...
2685         (ESC_PARENS): ... this.
2686         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2687         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2688
2689 2019-01-23  Tom Tromey  <tom@tromey.com>
2690
2691         * language.h (class scoped_switch_to_sym_language_if_auto):
2692         Initialize m_lang in both cases.
2693
2694 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2695
2696         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2697         with XCNEW.
2698
2699 2019-01-22  Tom Tromey  <tom@tromey.com>
2700
2701         * corelow.c: Do not include sys/file.h.
2702
2703 2019-01-22  Tom Tromey  <tom@tromey.com>
2704
2705         * tui/tui-wingeneral.h: Include gdb_curses.h.
2706
2707 2019-01-22  Tom Tromey  <tom@tromey.com>
2708
2709         * source-cache.h (class source_cache) <get_source_lines,
2710         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2711
2712 2019-01-22  Tom Tromey  <tom@tromey.com>
2713
2714         * remote-fileio.h (struct remote_target): Declare.
2715
2716 2019-01-22  Tom Tromey  <tom@tromey.com>
2717
2718         * python/py-arch.c: Do not include py-ref.h.
2719         * python/py-bpevent.c: Do not include py-ref.h.
2720         * python/py-cmd.c: Do not include py-ref.h.
2721         * python/py-continueevent.c: Do not include py-ref.h.
2722         * python/py-event.h: Do not include py-ref.h.
2723         * python/py-evtregistry.c: Do not include py-ref.h.
2724         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2725         * python/py-frame.c: Do not include py-ref.h.
2726         * python/py-framefilter.c: Do not include py-ref.h.
2727         * python/py-function.c: Do not include py-ref.h.
2728         * python/py-infevents.c: Do not include py-ref.h.
2729         * python/py-linetable.c: Do not include py-ref.h.
2730         * python/py-objfile.c: Do not include py-ref.h.
2731         * python/py-param.c: Do not include py-ref.h.
2732         * python/py-prettyprint.c: Do not include py-ref.h.
2733         * python/py-progspace.c: Do not include py-ref.h.
2734         * python/py-symbol.c: Do not include py-ref.h.
2735         * python/py-symtab.c: Do not include py-ref.h.
2736         * python/py-type.c: Do not include py-ref.h.
2737         * python/py-unwind.c: Do not include py-ref.h.
2738         * python/py-utils.c: Do not include py-ref.h.
2739         * python/py-value.c: Do not include py-ref.h.
2740         * python/py-varobj.c: Do not include py-ref.h.
2741         * python/py-xmethods.c: Do not include py-ref.h.
2742         * python/python.c: Do not include py-ref.h.
2743         * varobj.c: Do not include py-ref.h.
2744
2745 2019-01-22  Tom Tromey  <tom@tromey.com>
2746
2747         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2748         keyword for bcache.
2749
2750 2019-01-22  Tom Tromey  <tom@tromey.com>
2751
2752         * compile/compile-cplus-types.c: Remove a comment by #include.
2753
2754 2019-01-22  Tom Tromey  <tom@tromey.com>
2755
2756         * compile/gcc-c-plugin.h: Include compile-internal.h.
2757
2758 2019-01-22  Tom Tromey  <tom@tromey.com>
2759
2760         * stabsread.c (EXTERN): Do not define.
2761         (symnum, next_symbol_text_func, processing_gcc_compilation)
2762         (within_function, global_sym_chain, global_stabs)
2763         (previous_stab_code, this_object_header_files)
2764         (n_this_object_header_files)
2765         (n_allocated_this_object_header_files): Define.
2766         * stabsread.h (EXTERN): Never define.  Use "extern".
2767
2768 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2769
2770         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2771         history_value.
2772
2773 2019-01-21  Tom Tromey  <tom@tromey.com>
2774
2775         * ui-out.c: Fix includes.
2776         * tui/tui-source.c: Fix includes.
2777         * target.c: Fix includes.
2778         * remote.c: Fix includes.
2779         * regcache.c: Fix includes.
2780         * python/py-block.c: Fix includes.
2781         * printcmd.c: Fix includes.
2782         * or1k-tdep.c: Fix includes.
2783         * mi/mi-main.c: Fix includes.
2784         * m32r-tdep.c: Fix includes.
2785         * csky-tdep.c: Fix includes.
2786         * compile/compile-cplus-types.c: Fix includes.
2787         * cli/cli-interp.c: Fix includes.
2788
2789 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2790
2791         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2792         for padding.
2793
2794 2019-01-16  Tom Tromey  <tom@tromey.com>
2795
2796         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2797         earlier.
2798         (struct objfile) <msymbols_range>: Move from top level.
2799         <msymbols>: New method.
2800         (class objfile_msymbols): Remove.
2801         * symtab.c (default_collect_symbol_completion_matches_break_on):
2802         Update.
2803         * symmisc.c (dump_msymbols): Update.
2804         * stabsread.c (scan_file_globals): Update.
2805         * objc-lang.c (info_selectors_command, info_classes_command)
2806         (find_methods): Update.
2807         * minsyms.c (find_solib_trampoline_target): Update.
2808         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2809         * coffread.c (coff_symfile_read): Update.
2810         * ada-lang.c (ada_lookup_simple_minsym)
2811         (ada_collect_symbol_completion_matches): Update.
2812
2813 2019-01-16  Tom Tromey  <tom@tromey.com>
2814
2815         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2816         type.  Remove no-argument constructor.
2817         <iterator::operator++>: Simplify.
2818         <begin>: Update.
2819         <end>: Use minimal_symbol_count.
2820
2821 2019-01-16  Tom Tromey  <tom@tromey.com>
2822
2823         * objfiles.h (struct objfile) <psymtabs>: New method.
2824         (class objfile_psymtabs): Remove.
2825         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2826         typedef.
2827         <range>: New method.
2828         (require_partial_symbols): Change return type.
2829         * psymtab.c (require_partial_symbols)
2830         (psym_expand_symtabs_matching): Update.
2831         * mdebugread.c (parse_partial_symbols): Update.
2832         * dbxread.c (dbx_end_psymtab): Update.
2833
2834 2019-01-15  Tom Tromey  <tom@tromey.com>
2835
2836         * symtab.c (lookup_objfile_from_block)
2837         (lookup_symbol_in_objfile_symtabs)
2838         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2839         (find_line_symtab, info_sources_command)
2840         (default_collect_symbol_completion_matches_break_on)
2841         (make_source_files_completion_list): Update.
2842         * symmisc.c (print_objfile_statistics, dump_objfile)
2843         (maintenance_print_symbols, maintenance_info_symtabs)
2844         (maintenance_check_symtabs, maintenance_info_line_tables):
2845         Update.
2846         * source.c (select_source_symtab)
2847         (forget_cached_source_info_for_objfile): Update.
2848         * objfiles.h (class objfile_compunits): Remove.
2849         (struct objfile) <compunits_range>: New typedef.
2850         (compunits): New method.
2851         * objfiles.c (objfile_relocate1): Update.
2852         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2853         * maint.c (count_symtabs_and_blocks): Update.
2854         * linespec.c (iterate_over_all_matching_symtabs): Update.
2855         * cp-support.c (add_symbol_overload_list_qualified): Update.
2856         * coffread.c (coff_symtab_read): Update.
2857         * ada-lang.c (add_nonlocal_symbols)
2858         (ada_collect_symbol_completion_matches)
2859         (ada_add_global_exceptions): Update.
2860
2861 2019-01-15  Tom Tromey  <tom@tromey.com>
2862
2863         * progspace.h (program_space) <objfiles_safe_range>: New
2864         typedef.
2865         <objfiles_safe>: New method.
2866         * objfiles.h (class all_objfiles_safe): Remove.
2867         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2868         * jit.c (jit_inferior_exit_hook): Update.
2869
2870 2019-01-17  Tom Tromey  <tom@tromey.com>
2871
2872         * progspace.h (program_space) <objfiles_range>: New typedef.
2873         <objfiles>: New method.
2874         <objfiles_head>: Rename from objfiles.
2875         (object_files): Update.
2876         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2877         * guile/scm-pretty-print.c
2878         (ppscm_find_pretty_printer_from_objfiles): Update.
2879         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2880         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2881         Update.
2882         * python/py-progspace.c (pspy_get_objfiles): Update.
2883         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2884         Update.
2885         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2886         (objfpy_lookup_objfile_by_build_id): Update.
2887         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2888         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2889         Update.
2890         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2891         (expand_symtab_containing_pc, lookup_objfile_from_block)
2892         (lookup_static_symbol, basic_lookup_transparent_type)
2893         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2894         (find_line_symtab, info_sources_command)
2895         (default_collect_symbol_completion_matches_break_on)
2896         (make_source_files_completion_list, find_main_name): Update.
2897         * symmisc.c (print_symbol_bcache_statistics)
2898         (print_objfile_statistics, maintenance_print_symbols)
2899         (maintenance_print_msymbols, maintenance_print_objfiles)
2900         (maintenance_info_symtabs, maintenance_check_symtabs)
2901         (maintenance_expand_symtabs, maintenance_info_line_tables):
2902         Update.
2903         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2904         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2905         (map_overlay_command, unmap_overlay_command)
2906         (simple_overlay_update, expand_symtabs_matching)
2907         (map_symbol_filenames): Update.
2908         * symfile-debug.c (set_debug_symfile): Update.
2909         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2910         Update.
2911         * source.c (select_source_symtab, forget_cached_source_info):
2912         Update.
2913         * solib.c (solib_read_symbols): Update.
2914         * solib-spu.c (append_ocl_sos): Update.
2915         * psymtab.c (maintenance_print_psymbols)
2916         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2917         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2918         * printcmd.c (info_symbol_command): Update.
2919         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2920         Update.
2921         * objfiles.h (class all_objfiles): Remove.
2922         * objfiles.c (have_partial_symbols, have_full_symbols)
2923         (have_minimal_symbols, qsort_cmp, update_section_map)
2924         (shared_objfile_contains_address_p)
2925         (default_iterate_over_objfiles_in_search_order): Update.
2926         * objc-lang.c (info_selectors_command, info_classes_command)
2927         (find_methods): Update.
2928         * minsyms.c (find_solib_trampoline_target): Update.
2929         * maint.c (maintenance_info_sections)
2930         (maintenance_translate_address, count_symtabs_and_blocks):
2931         Update.
2932         * main.c (captured_main_1): Update.
2933         * linux-thread-db.c (try_thread_db_load_from_pdir)
2934         (has_libpthread): Update.
2935         * linespec.c (iterate_over_all_matching_symtabs)
2936         (search_minsyms_for_name): Update.
2937         * jit.c (jit_find_objf_with_entry_addr): Update.
2938         * hppa-tdep.c (find_unwind_entry)
2939         (hppa_lookup_stub_minimal_symbol): Update.
2940         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2941         Update.
2942         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2943         (elf_gnu_ifunc_resolve_by_got): Update.
2944         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2945         * dwarf-index-write.c (save_gdb_index_command): Update.
2946         * cp-support.c (add_symbol_overload_list_qualified): Update.
2947         * breakpoint.c (create_overlay_event_breakpoint)
2948         (create_longjmp_master_breakpoint)
2949         (create_std_terminate_master_breakpoint)
2950         (create_exception_master_breakpoint): Update.
2951         * blockframe.c (find_pc_partial_function): Update.
2952         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2953         (ada_collect_symbol_completion_matches)
2954         (ada_add_global_exceptions): Update.
2955
2956 2019-01-17  Tom Tromey  <tom@tromey.com>
2957
2958         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2959         declare VEC.
2960         (solib_target_parse_libraries): Change return type.
2961         (library_list_start_segment, library_list_start_section)
2962         (library_list_end_library, library_list_start_library); Update.
2963         (solib_target_free_library_list): Remove.
2964         (solib_target_parse_libraries): Remove cleanup.  Change return
2965         type.
2966         (solib_target_current_sos): Update.
2967
2968 2019-01-17  Tom Tromey  <tromey@bapiya>
2969
2970         * valprint.c: Replace "the the" with "the".
2971         * symtab.c: Replace "the the" with "the".
2972         * solib.c: Replace "the the" with "the".
2973         * solib-dsbt.c: Replace "the the" with "the".
2974         * linespec.c: Replace "the the" with "the".
2975         * dwarf2loc.h: Replace "the the" with "the".
2976         * amd64-windows-tdep.c: Replace "the the" with "the".
2977         * aarch64-tdep.c: Replace "the the" with "the".
2978
2979 2019-01-16  Keith Seitz  <keiths@redhat.com>
2980
2981         PR gdb/23773
2982         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2983         <builder>: Rename to ..
2984         <m_builder>: ... this and make private.
2985         (dwarf2_cu::get_builder): New method.  Change all users of
2986         `builder' to use this method.
2987         (dwarf2_start_symtab): Move to ...
2988         (dwarf2_cu::start_symtab): ... here.  Update all callers
2989         (setup_type_unit_groups): Move to ...
2990         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2991         callers.
2992         (dwarf2_cu::reset_builder): New method.
2993         (process_full_compunit, process_full_type_unit): Use
2994         dwarf2_cu::reset_builder.
2995         (follow_die_offset): Record the ancestor CU if it is different
2996         from the followed DIE's CU.
2997         (follow_die_sig_1): Likewise.
2998
2999 2019-01-15  Tom Tromey  <tom@tromey.com>
3000
3001         * remote.c (class remote_state) <buf>: Now a char_vector.
3002         <buf_size>: Remove.
3003         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3004         parameter.
3005         (remote_target::getpkt_or_notif_sane_1)
3006         (remote_target::getpkt_sane)
3007         (remote_target::getpkt_or_notif_sane): Likewise.
3008         (class remote_target) <putpkt>: New overload.
3009         (remote_target::read_frame): Change type of "buf_p".  Remove
3010         sizeof_p parameter.
3011         (packet_ok): New overload.
3012         (packet_check_result): New overload.
3013         Update all uses.
3014
3015 2019-01-14  Tom Tromey  <tom@tromey.com>
3016
3017         * remote-notif.c (handle_notification, remote_notif_ack)
3018         (remote_notif_parse): Make "buf" const.
3019         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3020         const.
3021         (remote_notif_parse, remote_notif_ack, handle_notification):
3022         Likewise.
3023         * remote.c (remote_notif_stop_parse): Make "buf" const.
3024         (remote_target::remote_parse_stop_reply): Make "buf" const.
3025         (remote_notif_stop_ack): Make "buf" const.
3026
3027 2019-01-14  Tom Tromey  <tom@tromey.com>
3028
3029         * remote.c (remote_console_output): Make parameter const.
3030
3031 2019-01-14  Tom Tromey  <tom@tromey.com>
3032
3033         * target-debug.h (target_debug_print_signals): Constify.
3034         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3035         * procfs.c (procfs_target::pass_signals): Update.
3036         * linux-nat.c (linux_nat_target::pass_signals): Update.
3037         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3038         * target-delegates.c: Rebuild.
3039         * remote.c (remote_target::program_signals): Update.
3040         (remote_target::pass_signals): Update.
3041         * target.c (target_pass_signals): Constify argument.
3042         (target_program_signals): Likewise.
3043         * target.h (struct target_ops) <pass_signals, program_signals>:
3044         Constify argument.
3045         (target_pass_signals, target_program_signals): Constify argument.
3046
3047 2019-01-14  Tom Tromey  <tom@tromey.com>
3048
3049         PR tui/28819:
3050         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3051
3052 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3053
3054         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3055         field.
3056         * rs6000-tdep.c: Include reggroups.h.
3057         (IS_V_ALIAS_PSEUDOREG): Define.
3058         (rs6000_register_name): Return names for the "vX" aliases.
3059         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3060         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3061         aliases.  Call default_register_reggroup_p for all other
3062         pseudo-registers.
3063         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3064         New functions.
3065         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3066         Handle "vX" aliases.
3067         (v_alias_pseudo_register_collect): New function.
3068         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3069         (rs6000_gdbarch_init): Initialize "vX" aliases as
3070         pseudo-registers.  Restore registration of
3071         rs6000_pseudo_register_reggroup_p with
3072         set_tdesc_pseudo_register_reggroup_p.
3073
3074 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3075
3076         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3077         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3078         set_gdbarch_num_pseudo_regs.
3079
3080 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3081
3082         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3083         Remove arg prefixname, add do_set and do_show.
3084         Add member functions set_list and show_list.
3085         * cli/cli-style.c (class cli_style_option): Update accordingly.
3086         (style_set_list): Move to file scope.
3087         (style_show_list): Likewise.
3088         (set_style): Call help_list.
3089         (show_style): Call cmd_show_list.
3090         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3091         Update to use the new macro.
3092
3093 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3094
3095         * ada-lang.c (_initialize_ada_language): Expand the help text
3096         for the "catch exception" command.
3097
3098 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3099
3100         * symtab.c (matching_obj_sections): Initialize obj,
3101         declare it closer to its usage.
3102
3103 2019-01-10  Tom Tromey  <tom@tromey.com>
3104
3105         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3106         (basic_inf_threads_range): Remove.
3107         (inf_threads_range, inf_non_exited_threads_range)
3108         (safe_inf_threads_range): Use next_adapter.
3109
3110 2019-01-10  Keith Seitz  <keiths@redhat.com>
3111
3112         PR gdb/23712
3113         PR symtab/23010
3114         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3115         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3116
3117 2019-01-10  Keith Seitz  <keiths@redhat.com>
3118
3119         PR gdb/23712
3120         PR symtab/23010
3121         * dictionary.c (pending_to_vector): Remove.
3122         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3123         Remove _1 suffix, replacing functions of the same name.  Update
3124         all callers.
3125         (dict_create_hashed, dict_create_hashed_expandable)
3126         (dict_create_linear, dict_create_linear_expandable, dict_free)
3127         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3128         Make functions static.
3129
3130 2019-01-10  Keith Seitz  <keiths@redhat.com>
3131
3132         PR gdb/23712
3133         PR symtab/23010
3134         * dictionary.h (struct dictionary): Replace declaration with
3135         multidictionary.
3136         (dict_create_hashed, dict_create_hashed_expandable)
3137         (dict_create_linear, dict_create_linear_expandable)
3138         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3139         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3140         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3141         taking multidictionary argument.
3142         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3143         * block.h (struct block) <dict>: Change to multidictionary
3144         and rename `multidict'.
3145         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3146         symmisc.c: Update all dictionary references to multidictionary.
3147
3148 2019-01-10  Keith Seitz  <keiths@redhat.com>
3149
3150         PR gdb/23712
3151         PR symtab/23010
3152         * dictionary.c: Include unordered_map.
3153         (pending_to_vector): New function.
3154         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3155         Rewrite the non-"_1" functions to take vector instead
3156         of linked list.
3157         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3158         "new" _1 versions of the same name.
3159         (multidictionary): Define.
3160         (std::hash<enum language): New definition.
3161         (collate_pending_symbols_by_language, mdict_create_hashed)
3162         (mdict_create_hashed_expandable, mdict_create_linear)
3163         (mdict_create_linear_expandable, mdict_free)
3164         (find_language_dictionary, create_new_language_dictionary)
3165         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3166         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3167         (mdict_size, mdict_empty): New functions.
3168         * dictionary.h (mdict_iterator): Define.
3169
3170 2019-01-10  Pedro Alves  <palves@redhat.com>
3171
3172         * breakpoint.c (read_uploaded_action)
3173         (create_tracepoint_from_upload): Adjust to use
3174         gdb::unique_xmalloc_ptr.
3175         * ctf.c (ctf_write_uploaded_tp):
3176         (SET_ARRAY_FIELD): Use emplace_back.
3177         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3178         * tracefile-tfile.c (tfile_write_uploaded_tp):
3179         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3180         gdb::unique_xmalloc_ptr.
3181         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3182         at_string, cond_string, cmd_strings>: Replace char pointers
3183         with gdb::unique_xmalloc_ptr.
3184
3185 2019-01-10  Pedro Alves  <palves@redhat.com>
3186
3187         * solib-target.c (library_list_start_library): Don't xstrdup name.
3188
3189 2019-01-10  Pedro Alves  <palves@redhat.com>
3190
3191         * mdebugread.c (parse_partial_symbols): Use
3192         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3193
3194 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3195
3196         * linux-fork.c (scoped_switch_fork_info)
3197         <~scoped_switch_fork_info>: Fix incorrect variable name.
3198
3199 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3200
3201         * linux-fork.c (scoped_switch_fork_info)
3202         <scoped_switch_fork_info>: Make explicit.
3203         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3204
3205 2019-01-10  Tom Tromey  <tom@tromey.com>
3206
3207         * objfiles.h (objfile::reset_psymtabs): Update.
3208         * objfiles.c (objfile::objfile): Update.
3209         * psymtab.h (psymtab_storage::obstack): Update.
3210         (psymtab_storage::m_obstack): Use gdb::optional.
3211         (class psymtab_storage): Update comment.  Remove objfile
3212         parameter.
3213         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3214
3215 2019-01-10  Tom Tromey  <tom@tromey.com>
3216
3217         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3218         <free_psymtabs>: Now private.
3219         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3220         (allocate_psymtab): Use new method.
3221
3222 2019-01-10  Tom Tromey  <tom@tromey.com>
3223
3224         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3225         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3226         * mdebugread.c (parse_partial_symbols): Use
3227         allocate_dependencies.
3228         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3229         allocate_dependencies.
3230         (process_psymtab_comp_unit_reader)
3231         (build_type_psymtab_dependencies): Likewise.
3232         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3233
3234 2019-01-10  Tom Tromey  <tom@tromey.com>
3235
3236         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3237         PSYMBOL_SET_LANGUAGE.
3238         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3239
3240 2019-01-10  Tom Tromey  <tom@tromey.com>
3241
3242         * psymtab.h (psymtab_storage::obstack): New method.
3243         <m_obstack>: Rename from obstack; now private.
3244         * psymtab.c (psymtab_storage): Update.
3245         * dwarf2read.c (create_addrmap_from_index)
3246         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3247         Update.
3248
3249 2019-01-10  Tom Tromey  <tom@tromey.com>
3250
3251         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3252         * objfiles.h (objfile::reset_psymtabs): New method.
3253
3254 2019-01-10  Tom Tromey  <tom@tromey.com>
3255
3256         * symmisc.c (print_symbol_bcache_statistics): Update.
3257         (print_objfile_statistics): Update.
3258         * symfile.c (reread_symbols): Update.
3259         * psymtab.h (class psymtab_storage): New.
3260         * psymtab.c (psymtab_storage): New constructor.
3261         (~psymtab_storage): New destructor.
3262         (require_partial_symbols): Update.
3263         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3264         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3265         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3266         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3267         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3268         (start_psymtab_common, end_psymtab_common)
3269         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3270         (allocate_psymtab): Update.
3271         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3272         Update.
3273         (dump_psymtab_addrmap, maintenance_print_psymbols)
3274         (maintenance_check_psymtabs): Update.
3275         (class objfile_psymtabs): Move to objfiles.h.
3276         * psympriv.h (discard_psymtab): Now inline.
3277         (psymtab_discarder::psymtab_discarder): Update.
3278         (psymtab_discarder::~psymtab_discarder): Update.
3279         (ALL_OBJFILE_PSYMTABS): Rewrite.
3280         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3281         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3282         Remove fields.
3283         <partial_symtabs>: New field.
3284         (class objfile_psymtabs): Move from psymtab.h.  Update.
3285         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3286         psymbol_cache.
3287         (objfile::~objfile): Don't destroy psymbol_cache.
3288         * mdebugread.c (parse_partial_symbols): Update.
3289         * dwarf2read.c (create_addrmap_from_index)
3290         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3291         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3292         (add_partial_subprogram, dwarf2_ranges_read): Update.
3293         * dwarf-index-write.c (write_address_map)
3294         (write_one_signatured_type, recursively_write_psymbols)
3295         (class debug_names, class debug_names, write_psymtabs_to_index):
3296         Update.
3297
3298 2019-01-10  Tom Tromey  <tom@tromey.com>
3299
3300         * symtab.h (SYMBOL_SET_NAMES): Update.
3301         (symbol_set_names): Update.
3302         (MSYMBOL_SET_NAMES): Update.
3303         * symtab.c (symbol_set_names): Change argument to be an
3304         objfile_per_bfd_storage.
3305         * psymtab.c (add_psymbol_to_bcache): Update.
3306         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3307
3308 2019-01-10  Tom Tromey  <tom@tromey.com>
3309
3310         * symtab.c (create_demangled_names_hash): Change argument to be an
3311         objfile_per_bfd_storage.
3312         (symbol_set_names): Update.
3313
3314 2019-01-10  Tom Tromey  <tom@tromey.com>
3315
3316         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3317         init_psymbol_list.
3318         * psymtab.c (init_psymbol_list): Do nothing if already called.
3319         * psympriv.h (init_psymbol_list): Add comment.
3320         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3321         init_psymbol_list.
3322         * dbxread.c (dbx_symfile_read): Unconditionally call
3323         init_psymbol_list.
3324
3325 2019-01-10  Tom Tromey  <tom@tromey.com>
3326
3327         * xcoffread.c (scan_xcoff_symtab): Update.
3328         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3329         "where".
3330         * mdebugread.c (parse_partial_symbols)
3331         (handle_psymbol_enumerators): Update.
3332         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3333         * dbxread.c (read_dbx_symtab): Update.
3334         * psympriv.h (psymbol_placement): New enum.
3335         (add_psymbol_to_list): Update.
3336
3337 2019-01-10  Tom Tromey  <tom@tromey.com>
3338
3339         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3340         static_psymbols parameters.
3341         (scan_xcoff_symtab): Update.
3342         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3343         static_psymbols parameters.
3344         * psympriv.h (start_psymtab_common): Update.
3345         * mdebugread.c (parse_partial_symbols): Update.
3346         * dwarf2read.c (create_partial_symtab): Update.
3347         * dbxread.c (read_dbx_symtab): Update.
3348         (start_psymtab): Remove global_psymbols and static_psymbols
3349         parameters.
3350
3351 2019-01-10  Tom Tromey  <tom@tromey.com>
3352
3353         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3354         * psymtab.c (allocate_psymtab): Add comment.
3355         * psympriv.h (allocate_psymtab): Add comment.
3356         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3357         initializations.
3358         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3359
3360 2019-01-10  Tom Tromey  <tom@tromey.com>
3361
3362         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3363         Don't declare.
3364         * mipsread.c: Include mdebugread.h.
3365         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3366         Declare.
3367         * elfread.c: Include mdebugread.h.
3368
3369 2019-01-09  Tom Tromey  <tom@tromey.com>
3370
3371         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3372         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3373         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3374         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3375         (psym_lookup_symbol, psym_find_last_source_symtab)
3376         (psym_forget_cached_source_info, psym_print_stats)
3377         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3378         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3379         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3380         (psym_find_compunit_symtab_by_address)
3381         (maintenance_print_psymbols, maintenance_info_psymtabs)
3382         (maintenance_check_psymtabs): Use ranged for.
3383         * psymtab.h (class objfile_psymtabs): New.
3384         (require_partial_symbols): Return objfile_psymtabs.
3385         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3386
3387 2019-01-09  Tom Tromey  <tom@tromey.com>
3388
3389         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3390         (find_pc_mapped_section, list_overlays_command)
3391         (map_overlay_command, unmap_overlay_command)
3392         (simple_overlay_update): Use all_objfiles.
3393         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3394         * printcmd.c (info_symbol_command): Use all_objfiles.
3395         * objfiles.h (ALL_OBJSECTIONS): Remove.
3396         * maint.c (maintenance_translate_address): Use all_objfiles.
3397         * gcore.c (gcore_create_callback): Use all_objfiles.
3398         (objfile_find_memory_regions): Likewise.
3399
3400 2019-01-09  Tom Tromey  <tom@tromey.com>
3401
3402         * symtab.c (find_line_symtab, info_sources_command)
3403         (make_source_files_completion_list): Use objfile_compunits.
3404         * source.c (select_source_symtab): Use objfile_compunits.
3405         * objfiles.h (struct objfile): Update comment.
3406         (ALL_OBJFILES): Remove.
3407         (ALL_FILETABS): Remove.
3408         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3409         objfile_compunits.
3410
3411 2019-01-09  Tom Tromey  <tom@tromey.com>
3412
3413         * symmisc.c (print_objfile_statistics, dump_objfile)
3414         (maintenance_print_symbols): Use compunit_filetabs.
3415         * source.c (forget_cached_source_info_for_objfile): Use
3416         compunit_filetabs.
3417         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3418         (ALL_FILETABS): Use compunit_filetabs.
3419         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3420         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3421
3422 2019-01-09  Tom Tromey  <tom@tromey.com>
3423
3424         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3425         (compunit_filetabs): New.
3426         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3427         compunit_filetabs.
3428         (info_sources_command, make_source_files_completion_list): Remove
3429         declaration.
3430         * symmisc.c (print_objfile_statistics, dump_objfile)
3431         (maintenance_print_symbols): Remove declaration.
3432         (maintenance_info_symtabs): Use compunit_filetabs.
3433         (maintenance_info_line_tables): Likewise.
3434         * source.c (select_source_symtab): Change local variable name.
3435         (forget_cached_source_info_for_objfile): Remove declaration.
3436         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3437         * objfiles.c (objfile_relocate1): Remove declaration.
3438         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3439         declaration.
3440         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3441         * coffread.c (coff_symtab_read): Remove declaration.
3442         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3443         compunit_filetabs.
3444
3445 2019-01-09  Tom Tromey  <tom@tromey.com>
3446
3447         * symtab.c (lookup_objfile_from_block)
3448         (find_pc_sect_compunit_symtab, search_symbols)
3449         (default_collect_symbol_completion_matches_break_on): Use
3450         objfile_compunits.
3451         * objfiles.h (ALL_COMPUNITS): Remove.
3452         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3453         * cp-support.c (add_symbol_overload_list_qualified): Use
3454         objfile_compunits.
3455         * ada-lang.c (ada_collect_symbol_completion_matches)
3456         (ada_add_global_exceptions): Use objfile_compunits.
3457
3458 2019-01-09  Tom Tromey  <tom@tromey.com>
3459
3460         * source.c (select_source_symtab)
3461         (forget_cached_source_info_for_objfile): Remove declaration.
3462         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3463         declaration.
3464         * maint.c (count_symtabs_and_blocks): Remove declaration.
3465         * cp-support.c (add_symbol_overload_list_qualified): Remove
3466         declaration.
3467         * coffread.c (coff_symtab_read): Remove declaration.
3468         * symtab.c (lookup_symbol_in_objfile_symtabs)
3469         (basic_lookup_transparent_type_1): Use objfile_compunits.
3470         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3471         (info_sources_command, search_symbols)
3472         (default_collect_symbol_completion_matches_break_on)
3473         (make_source_files_completion_list): Remove declaration.
3474         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3475         (ada_collect_symbol_completion_matches)
3476         (ada_add_global_exceptions): Remove declaration.
3477         * linespec.c (iterate_over_all_matching_symtabs): Use
3478         objfile_compunits.
3479         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3480         (class objfile_compunits): New.
3481         (ALL_COMPUNITS): Use objfile_compunits.
3482         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3483         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3484         objfile_compunits.
3485         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3486
3487 2019-01-09  Tom Tromey  <tom@tromey.com>
3488
3489         * symtab.c (search_symbols)
3490         (default_collect_symbol_completion_matches_break_on): Use
3491         objfile_msymbols.
3492         * ada-lang.c (ada_lookup_simple_minsym)
3493         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3494         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3495         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3496         objfile_msymbols.
3497         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3498         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3499         * objc-lang.c (find_methods): Use objfile_msymbols.
3500         (info_selectors_command, info_classes_command): Likewise.
3501         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3502         * objfiles.h (class objfile_msymbols): New.
3503         (ALL_OBJFILE_MSYMBOLS): Remove.
3504         (ALL_MSYMBOLS): Remove.
3505
3506 2019-01-09  Tom Tromey  <tom@tromey.com>
3507
3508         * common/next-iterator.h (next_adapter): Add Iterator template
3509         parameter.
3510         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3511         (class all_objfiles_safe): New.
3512         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3513         * objfiles.c (put_objfile_before): Update comment.
3514         (add_separate_debug_objfile): Likewise.
3515         (free_all_objfiles): Use all_objfiles_safe.
3516         (objfile_purge_solibs): Likewise.
3517
3518 2019-01-09  Tom Tromey  <tom@tromey.com>
3519
3520         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3521         (expand_symtab_containing_pc, lookup_static_symbol)
3522         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3523         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3524         all_objfiles.
3525         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3526         * breakpoint.c (create_overlay_event_breakpoint)
3527         (create_longjmp_master_breakpoint)
3528         (create_std_terminate_master_breakpoint)
3529         (create_exception_master_breakpoint): Use all_objfiles.
3530         * linux-thread-db.c (try_thread_db_load_from_pdir)
3531         (has_libpthread): Use all_objfiles.
3532         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3533         * linespec.c (iterate_over_all_matching_symtabs)
3534         (search_minsyms_for_name): Use all_objfiles.
3535         * maint.c (maintenance_info_sections): Use all_objfiles.
3536         * main.c (captured_main_1): Use all_objfiles.
3537         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3538         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3539         * guile/scm-pretty-print.c
3540         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3541         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3542         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3543         (maintenance_print_msymbols): Use all_objfiles.
3544         * source.c (select_source_symtab): Use all_objfiles.
3545         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3546         * symfile.c (remove_symbol_file_command)
3547         (expand_symtabs_matching, map_symbol_filenames): Use
3548         all_objfiles.
3549         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3550         all_objfiles.
3551         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3552         * objc-lang.c (find_methods): Use all_objfiles.
3553         * objfiles.c (have_partial_symbols, have_full_symbols)
3554         (have_minimal_symbols, qsort_cmp)
3555         (default_iterate_over_objfiles_in_search_order): Use
3556         all_objfiles.
3557         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3558         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3559         (maintenance_check_psymtabs): Use all_objfiles.
3560         (ALL_PSYMTABS): Remove.
3561         * compile/compile-object-run.c (do_module_cleanup): Use
3562         all_objfiles.
3563         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3564         * cp-support.c (add_symbol_overload_list_qualified): Use
3565         all_objfiles.
3566         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3567         Use all_objfiles.
3568         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3569         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3570         all_objfiles.
3571         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3572         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3573         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3574         Uses all_objfiles.
3575         * solib.c (solib_read_symbols): Use all_objfiles
3576
3577 2019-01-09  Tom Tromey  <tom@tromey.com>
3578
3579         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3580         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3581         all_objfiles.
3582         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3583         * symmisc.c (print_symbol_bcache_statistics)
3584         (print_objfile_statistics, maintenance_print_objfiles)
3585         (maintenance_info_symtabs, maintenance_check_symtabs)
3586         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3587         all_objfiles.
3588         * source.c (forget_cached_source_info): Use all_objfiles.
3589         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3590         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3591         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3592         * objfiles.c (update_section_map): Use all_objfiles.
3593         (shared_objfile_contains_address_p): Likewise.
3594         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3595         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3596
3597 2019-01-09  Tom Tromey  <tom@tromey.com>
3598
3599         * common/next-iterator.h: New file.
3600         * objfiles.h (class all_objfiles): New.
3601         (struct objfile_iterator): New.
3602
3603 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3604
3605         * NEWS: Move the description of the changed "frame", "select-frame",
3606          and "info frame" commands to the Changed commands section.
3607
3608 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3609
3610         * gdbtypes.c (check_stub_method_group): Remove handling of old
3611         mangling schemes.
3612         * linespec.c (find_methods): Likewise.
3613         * stabsread.c (read_member_functions): Likewise.
3614         * valops.c (search_struct_method): Likewise.
3615         (value_struct_elt_for_reference): Likewise.
3616         * NEWS: Mention this change.
3617
3618 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3619
3620         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3621         print_source_lines.
3622         * source.c (print_source_lines_base): Update line number check.
3623         (print_source_lines): New function.
3624         (source_lines_range::source_lines_range): New function.
3625         * source.h (class source_lines_range): New class.
3626         (print_source_lines): New declaration.
3627
3628 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3629
3630         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3631
3632 2019-01-08  Tom Tromey  <tom@tromey.com>
3633             Simon Marchi  <simon.marchi@ericsson.com>
3634
3635         PR gdb/24060
3636         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3637         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3638         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3639         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3640         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3641         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3642
3643 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3644
3645         * source.c (select_source_symtab): Move header comment to
3646         declaration in source.h.
3647         (forget_cached_source_info_for_objfile): Likewise.
3648         (forget_cached_source_info): Likewise.
3649         (identify_source_line): Likewise.
3650         * source.h (identify_source_line): Move declaration from symtab.h
3651         and add comment from source.c
3652         (print_source_lines): Likewise.
3653         (forget_cached_source_info_for_objfile): Likewise.
3654         (forget_cached_source_info): Likewise.
3655         (select_source_symtab): Likewise.
3656         (enum print_source_lines_flag): Move definition from symtab.h.
3657         * symtab.h (identify_source_line): Move declaration to source.h.
3658         (print_source_lines): Likewise.
3659         (forget_cached_source_info_for_objfile): Likewise.
3660         (forget_cached_source_info): Likewise.
3661         (select_source_symtab): Likewise.
3662         (enum print_source_lines_flag): Move definition to source.h.
3663         * tui/tui-hooks.c: Add 'source.h' include.
3664
3665 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * source.c (print_source_lines_base): Handle requests to print
3668         reverse line number sequences, and guard against empty lines
3669         string.
3670
3671 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3672
3673         * source.c (print_source_lines_base): Fix skip of '\r' if next
3674         character is '\n'.
3675
3676 2019-01-06  Tom Tromey  <tom@tromey.com>
3677
3678         * c-exp.y (struct c_parse_state) <macro_original_text,
3679         expansion_obstack>: New member.
3680         (macro_original_text, expansion_obstack): Remove globals.
3681         (scan_macro_expansion, scanning_macro_expansion)
3682         (finished_macro_expansion): Update.
3683         (scan_macro_cleanup): Remove.
3684         (yylex, c_parse): Update.
3685
3686 2019-01-06  Tom Tromey  <tom@tromey.com>
3687
3688         * c-exp.y (struct c_parse_state) <strings>: New member.
3689         (operator_stoken): Update.
3690
3691 2019-01-06  Tom Tromey  <tom@tromey.com>
3692
3693         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3694         (union type_stack_elt) <typelist_val>: Now a pointer to
3695         std::vector.
3696         (type_stack_cleanup): Don't declare.
3697         (push_typelist): Update.
3698         * parse.c (pop_typelist): Return a std::vector.
3699         (push_typelist): Take a std::vector.
3700         (follow_types): Update.  Do not free args.
3701         (type_stack_cleanup): Remove.
3702         * c-exp.y (struct c_parse_state): New.
3703         (cpstate): New global.
3704         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3705         (nonempty_typelist): Update.
3706         (func_mod): Create a new vector.
3707         (c_parse): Create a c_parse_state.
3708         (check_parameter_typelist): Do not delete params.
3709         (function_method): Update.  Do not delete type_list.
3710
3711 2019-01-06  Tom Tromey  <tom@tromey.com>
3712
3713         PR gdb/28155:
3714         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3715         check_typedef.
3716         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3717         (print_return_value): Likewise.
3718
3719 2019-01-05  Tom Tromey  <tom@tromey.com>
3720
3721         * contrib/cleanup_check.py: Remove.
3722         * contrib/gcc-with-excheck: Remove.
3723         * contrib/exsummary.py: Remove.
3724         * contrib/excheck.py: Remove.
3725
3726 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3727
3728         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3729         NULL. Initialize tpprev to NULL instead of assigning it
3730         to NULL on the next statement.
3731         * windows-nat.c (windows_delete_thread): Remove check for
3732         main_thread_id before printing thread exit notifications.
3733         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3734         Remove thread ID check against main_thread_id.
3735         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3736         windows_delete_thread.
3737         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3738
3739 2019-01-04  Tom Tromey  <tom@tromey.com>
3740
3741         * compile/compile.c (_initialize_compile): Use upper case for
3742         metasyntactic variables.
3743         * symmisc.c (_initialize_symmisc): Use upper case for
3744         metasyntactic variables.
3745         * psymtab.c (_initialize_psymtab): Use upper case for
3746         metasyntactic variables.
3747         * demangle.c (demangle_command): Use upper case for metasyntactic
3748         variables.
3749         (_initialize_demangler): Likewise.
3750         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3751         variables.
3752
3753 2019-01-03  Tom Tromey  <tom@tromey.com>
3754
3755         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3756
3757 2019-01-03  Tom Tromey  <tom@tromey.com>
3758
3759         * python/py-symtab.c (salpy_str): Update.
3760         (struct salpy_sal_object) <symtab>: Now a PyObject.
3761         (salpy_dealloc): Update.
3762         (del_objfile_sal): Use gdbpy_ref.
3763
3764 2019-01-03  Tom Tromey  <tom@tromey.com>
3765
3766         * python/py-type.c (convert_field): Use new_reference.  Return
3767         gdbpy_ref.
3768         (make_fielditem): Return gdbpy_ref.
3769         (typy_fields): Update.
3770         (typy_getitem): Update.
3771         (field_name): Return gdbpy_ref.  Use new_reference.
3772         (typy_iterator_iternext): Update.
3773
3774 2019-01-03  Tom Tromey  <tom@tromey.com>
3775
3776         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3777
3778 2019-01-03  Tom Tromey  <tom@tromey.com>
3779
3780         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3781         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3782         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3783         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3784         (pspy_set_type_printers): Likewise.
3785         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3786         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3787         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3788         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3789         (objfpy_set_type_printers): Likewise.
3790
3791 2019-01-03  Tom Tromey  <tom@tromey.com>
3792
3793         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3794         (gdbpy_print_stack): Use gdbpy_err_fetch.
3795         * python/python-internal.h (class gdbpy_err_fetch): New class.
3796         (class gdbpy_enter) <m_error_type, m_error_value,
3797         m_error_traceback>: Remove.
3798         <m_error>: New member.
3799         (gdbpy_exception_to_string): Don't declare.
3800         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3801         * python/py-value.c (convert_value_from_python): Use
3802         gdbpy_err_fetch.
3803         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3804         gdbpy_exception_to_string.
3805         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3806         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3807         gdbpy_err_fetch.
3808
3809 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3810
3811         * linux-nat.c (delete_lwp_cleanup): Delete.
3812         (struct lwp_deleter): New struct.
3813         (lwp_info_up): New typedef.
3814         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3815         lwp_info_up.
3816
3817 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * linux-fork.c (class scoped_switch_fork_info): New class.
3820         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3821
3822 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * valops.c (find_overload_match): Remove use of null_cleanup, and
3825         calls to do_cleanups.
3826
3827 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3828
3829         * compile/compile-cplus-types.c
3830         (compile_cplus_instance::decl_name): Handle changes to
3831         cp_func_name.
3832         * cp-support.c (cp_func_name): Update header comment, update
3833         return type.
3834         * cp-support.h (cp_func_name): Update return type in declaration.
3835         * valops.c (find_overload_match): Move temp_func local to top
3836         level of function and change its type.  Use temp_func to hold and
3837         delete temporary string obtained from cp_func_name.
3838
3839 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3840
3841         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3842         gdb::char_vector, remove cleanup, and update uses of `msg`.
3843
3844 2019-01-03  Jim Wilson  <jimw@sifive.com>
3845
3846         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3847
3848 2019-01-02  Tom Tromey  <tom@tromey.com>
3849
3850         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3851         (tdesc_parse_xml): Remove cleanups.
3852         * target-descriptions.h (make_cleanup_free_target_description):
3853         Don't declare.
3854         (target_desc_deleter): New struct.
3855         (target_desc_up): New typedef.
3856         * target-descriptions.c (target_desc_deleter::operator()): Rename
3857         from free_target_description.
3858         (make_cleanup_free_target_description): Remove.
3859
3860 2019-01-02  Tom Tromey  <tom@tromey.com>
3861
3862         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3863         constructor, destructor.
3864         (linespec_parser): Remove typedef.
3865         (~linespec_parser): Rename from linespec_parser_delete.
3866         (linespec_lex_to_end, linespec_complete_label)
3867         (linespec_complete): Update.
3868         (decode_line_full): Remove cleanups.
3869         (decode_line_1): Update.
3870
3871 2019-01-02  Tom Tromey  <tom@tromey.com>
3872
3873         * python/python-internal.h (inferior_to_inferior_object): Change
3874         return type.
3875         * python/py-exitedevent.c (create_exited_event_object): Update.
3876         * python/py-inferior.c (inferior_to_inferior_object): Return
3877         gdbpy_ref.
3878         (python_new_inferior, python_inferior_deleted)
3879         (thread_to_thread_object, delete_thread_object)
3880         (build_inferior_list, gdbpy_selected_inferior): Update.
3881         * python/py-infthread.c (create_thread_object): Update.  Also fail
3882         if inferior_to_inferior_object fails.
3883
3884 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3885
3886         * inferior.h (class inferior) <displaced_step_state>: New field.
3887         * infrun.h (struct displaced_step_state): Move here from
3888         infrun.c.  Initialize fields, add constructor.
3889         <inf>: Remove field.
3890         <reset>: New method.
3891         * infrun.c (struct displaced_step_inferior_state): Move to
3892         infrun.h.
3893         (displaced_step_inferior_states): Remove.
3894         (get_displaced_stepping_state): Adust.
3895         (displaced_step_in_progress_any_inferior): Adjust.
3896         (displaced_step_in_progress_thread): Adjust.
3897         (displaced_step_in_progress): Adjust.
3898         (add_displaced_stepping_state): Remove.
3899         (get_displaced_step_closure_by_addr): Adjust.
3900         (remove_displaced_stepping_state): Remove.
3901         (infrun_inferior_exit): Call displaced_step_state.reset.
3902         (use_displaced_stepping): Don't check for NULL.
3903         (displaced_step_prepare_throw): Call
3904         get_displaced_stepping_state.
3905         (displaced_step_fixup): Don't check for NULL.
3906         (prepare_for_detach): Don't check for NULL.
3907
3908 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3909
3910         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3911          in case of call that did not complete.
3912
3913 2019-01-02  Andrey Utkin  <autkin@undo.io>
3914
3915         * symfile.c (find_separate_debug_file): Fix search of debug files for
3916         remote debuggee.
3917
3918 2019-01-02  Tom Tromey  <tom@tromey.com>
3919
3920         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3921         indentation.
3922         * python/py-frame.c (frapy_older): Remove cast.
3923         (frapy_newer): Likewise.
3924         * python/py-breakpoint.c (local_setattro): Remove cast.
3925         * python/py-arch.c (archpy_name): Remove local variable.
3926         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3927
3928 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3929
3930         * unittests/basic_string_view/element_access/char/empty.cc:
3931         Fix year range in copyright header.
3932
3933 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3934
3935         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3936         Delete.
3937         <operator==>: Update with for removed field.
3938         <hash>: Likewise.
3939         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3940         <isa_features>: ...this.
3941         <abi_features>: New field.
3942         (riscv_isa_flen): Update comment.
3943         (riscv_abi_xlen): New declaration.
3944         (riscv_abi_flen): New declaration.
3945         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3946         isa_features.
3947         (riscv_abi_xlen): New function.
3948         (riscv_isa_flen): Update to get answer from isa_features.
3949         (riscv_abi_flen): New function.
3950         (riscv_has_fp_abi): Update to get answer from abi_features.
3951         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3952         xlen and flen.
3953         (riscv_call_info) <xlen, flen>: Update comment.
3954         (riscv_call_arg_struct): Remove invalid assertions
3955         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3956         is removed.
3957         (riscv_gdbarch_init): Gather isa features and abi features
3958         separately, ensure both match on the gdbarch when reusing an old
3959         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3960         a target with 64-bit float hardware.
3961
3962 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3963
3964         * source.c (search_command_helper): Stop reverse search
3965         when line 1 has been searched.
3966
3967 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3968
3969         * record-full.c (record_full_base_target::close): Rewrite
3970         record_full_core_buf_list free logic.
3971
3972 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3973
3974         * break-catch-syscall.c (print_one_catch_syscall): xfree
3975         the last text.
3976
3977 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3978
3979         * top.c (print_gdb_version): Update Copyright year in version
3980         message.
3981
3982 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3983
3984         Update copyright year range in all GDB files.
3985
3986 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3987
3988         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3989
3990 For older changes see ChangeLog-2018.
3991 \f
3992 Local Variables:
3993 mode: change-log
3994 left-margin: 8
3995 fill-column: 74
3996 version-control: never
3997 coding: utf-8
3998 End:
3999