gdb/configure.ac: add --enable-source-highlight
[external/binutils.git] / gdb / ChangeLog
1 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2
3         * configure.ac: add --enable-source-highlight switch.
4         * configure: Regenerate.
5         * top.c (print_gdb_version): plumb --enable-source-highlight
6         status to "show configuration".
7
8 2019-04-19  Tom Tromey  <tromey@adacore.com>
9
10         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11         Check ADA_TYPE_P.
12         (empty_record, ada_template_to_fixed_record_type_1)
13         (template_to_static_fixed_type)
14         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
15         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
16         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
17         macros.
18
19 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
20
21         PR symtab/24423:
22         * source.c (print_source_lines_base): Advance "iter" when a
23         control character is seen.
24
25 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
26
27         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
28         close to the add_com "shell".
29
30 2019-04-18  Tom Tromey  <tromey@adacore.com>
31
32         * process-stratum-target.h (class process_stratum_target)
33         <stratum>: Add "final".
34
35 2019-04-17  Tom Tromey  <tromey@adacore.com>
36
37         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
38         against nullptr before use.
39
40 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
41
42         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
43
44 2019-04-17  Jim Wilson  <jimw@sifive.com>
45             Andrew Burgess  <andrew.burgess@embecosm.com>
46
47         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
48         code read might fail, assume 4-byte breakpoint in that case.
49
50 2019-04-15  Leszek Swirski  <leszeks@google.com>
51
52         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
53         rather than a hand-rolled POD check when checking for forced MEMORY
54         classification.
55
56 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
57
58         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
59         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
60         function.
61         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
62         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
63         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
64         declaration.
65
66 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
67
68         * aarch64-linux-nat.c
69         (aarch64_linux_nat_target::thread_architecture): Add override.
70         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
71         each VQ.
72
73 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
74
75         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
76
77 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
78
79         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
80         target types of size 96-bits, add some additional comments, and
81         check that the builtin type we found was the correct size.
82
83 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
84
85         * utils.c (prompt_for_continue): Don't restore the styling at the
86         end, as applied_style has the wrong value.  This fixes styling in
87         long lists of file names that are interrupted by the "Continue?"
88         prompt.
89
90 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
91
92         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
93         * c-lang.c (c_language_defn): Likewise.
94         (cplus_language_defn): Likewise.
95         (asm_language_defn): Likewise.
96         (minimal_language_defn): Likewise.
97         * d-lang.c (d_language_defn): Likewise.
98         * f-lang.c (f_language_defn): Likewise.
99         * go-lang.c (go_language_defn): Likewise.
100         * language.c (unknown_language_defn): Likewise.
101         (auto_language_defn): Likewise.
102         * language.h (struct language_defn): Remove la_magic field.
103         (LANG_MAGIC): Delete.
104         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
105         * objc-lang.c (objc_language_defn): Likewise.
106         * opencl-lang.c (opencl_language_defn): Likewise.
107         * p-lang.c (pascal_language_defn): Likewise.
108         * rust-lang.c (rust_language_defn): Likewise.
109
110 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
111
112         * riscv-tdep.c (riscv_type_align): New function.
113         (riscv_type_alignment): Delete.
114         (riscv_arg_location): Use 'type_align'.
115         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
116
117 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
118
119         * gdbtypes.c (type_align): A struct with no non-static fields also
120         has alignment of 1.
121
122 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
123
124         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
125         component to 0.
126         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
127         member.
128         (riscv_struct_info::analyse): New implementation using new
129         analyse_inner member function.
130         (riscv_struct_info::field_offset): New member function.
131         (riscv_struct_info::m_offsets): New member variable.
132         (riscv_struct_info::analyse_inner): New private member function,
133         takes the old implementation of riscv_struct_info::analyse but
134         extended to track field offsets.
135         (riscv_call_arg_struct): Update the struct folding special cases
136         to handle cases where empty C++ structs, which are non-zero
137         length, are found.
138         (riscv_arg_location): Initialise the length of each location, a
139         non-zero length now indicates the location is in use.
140         (riscv_push_dummy_call): Allow for the first location having a
141         non-zero offset when setting up arguments.
142         (riscv_return_value): Likewise, but for return values.
143
144 2019-04-11  Tom Tromey  <tromey@adacore.com>
145
146         * utils.c (internal_vproblem): Make "msg" const.
147
148 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
149
150         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
151         * trad-frame.c (trad_frame_reset_saved_regs): New function.
152         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
153         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
154
155 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
156
157         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
158         function.
159         (fill_gregset): Call amd64_linux_collect_native_gregset instead
160         of amd64_collect_native_gregset.
161         (amd64_linux_nat_target::store_registers): Likewise.
162
163 2019-04-10  Tom Tromey  <tom@tromey.com>
164
165         * symtab.c (lookup_global_symbol_from_objfile)
166         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
167         * objfiles.h (class separate_debug_iterator): New.
168         (class separate_debug_range): New.
169         (struct objfile) <separate_debug_objfiles>: New method.
170         (objfile_separate_debug_iterate): Don't declare.
171         * objfiles.c (separate_debug_iterator::operator++): Rename from
172         objfile_separate_debug_iterate.
173         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
174         iterator.
175         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
176         iterator.
177
178 2019-04-10  Tom Tromey  <tom@tromey.com>
179
180         * symfile.c (reread_symbols): Remove old comment.
181         * objfiles.c (free_all_objfiles): Fix a typo.
182
183 2019-04-10  Tom Tromey  <tom@tromey.com>
184
185         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
186         * minsyms.c (lookup_minimal_symbol): Use foreach.
187         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
188         (lookup_minimal_symbol_solib_trampoline): Likewise.
189         * symfile.c (reread_symbols): Use foreach.
190
191 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
192             Tom Tromey  <tromey@adacore.com>
193
194         PR rust/24414:
195         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
196         (rust_lex_int_test): Change "value" to be LONGEST.
197         (rust_lex_tests): Add test for long integer literal.
198
199 2019-04-09  Tom Tromey  <tromey@adacore.com>
200
201         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
202         to bool.
203         (extended_remote_target::attach): Update.
204         (remote_target::remote_notice_new_inferior): Update.
205         (remote_target::add_current_inferior_and_thread): Update.
206         * inferior.c (exit_inferior_1): Use "false".
207         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
208
209 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
210
211         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
212         the "start" command.
213
214 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
215
216         * python/py-inferior.c (infpy_thread_from_thread_handle):
217         Adjust comments to reflect renaming of thread_from_thread_handle
218         to thread_from_handle.  Adjust keywords.  Fix type error message.
219         (inferior_object_methods): Add thread_from_handle.  Retain
220         thread_from_thread_handle, but mark it as deprecated.
221
222 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
223
224         * gdbthread.h (find_thread_by_handle): Revise declaration.
225         * thread.c (find_thread_by_handle): Likewise.  Adjust
226         implementation too.
227         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
228         support for buffer objects as handles.
229
230 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
231
232         * python/py-infthread.c (thpy_thread_handle): New function.
233         (thread_object_methods): Register thpy_thread_handle.
234
235 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
236
237         * gdbthread.h (thread_to_thread_handle): Declare.
238         * thread.c (gdbtypes.h): Include.
239         (thread_to_thread_handle): New function.
240
241         * target.h (struct target_ops): Add thread_info_to_thread_handle.
242         (target_thread_info_to_thread_handle): Declare.
243         * target.c (target_thread_info_to_thread_handle): New function.
244         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
245         * target-delegates.c: Regenerate.
246
247         * linux-thread-db.c (class thread_db_target): Add method
248         thread_info_to_thread_handle.
249         (thread_db_target::thread_info_to_thread_handle): Define.
250         * remote.c (class remote_target): Add new method
251         thread_info_to_thread_handle.
252         (remote_target::thread_info_to_thread_handle): Define.
253
254 2019-04-08  Pedro Alves  <palves@redhat.com>
255
256         * common/common-exceptions.c (throw_exception): Don't create
257         named object to throw; throw directly.
258         (throw_it): Likewise.  Don't initialize gdb_exception::message
259         here, with new; pass FMT and AP to the ctor instead.
260         * common/common-exceptions.h: Include <string>.
261         (gdb_exception::gdb_exception(enum return_reason, enum errors,
262         const char *, va_list)): New ctor.  Use std::make_shared.
263         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
264         errors)): Delete.
265         (gdb_exception_error::gdb_exception_error(enum errors, const char
266         *, va_list)): New.
267         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
268         Add assertion.
269         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
270         errors)): Delete.
271         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
272         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
273         Add assertion.
274
275 2019-04-08  Tom Tromey  <tom@tromey.com>
276
277         * valops.c (value_rtti_indirect_type): Replace throw_exception
278         with throw.
279         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
280         with throw.
281         * thread.c (thr_try_catch_cmd): Replace throw_exception with
282         throw.
283         * target.c (target_translate_tls_address): Replace throw_exception
284         with throw.
285         * stack.c (frame_apply_command_count): Replace throw_exception
286         with throw.
287         * solib-spu.c (append_ocl_sos): Replace throw_exception with
288         throw.
289         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
290         with throw.
291         * rs6000-tdep.c (rs6000_frame_cache)
292         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
293         * remote.c: Replace throw_exception with throw.
294         * record-full.c (record_full_message, record_full_wait_1)
295         (record_full_restore): Replace throw_exception with throw.
296         * record-btrace.c:
297         (get_thread_current_frame_id, record_btrace_start_replaying)
298         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
299         (cmd_record_btrace_start): Replace throw_exception with throw.
300         * parse.c (parse_exp_in_context_1): Replace throw_exception with
301         throw.
302         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
303         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
304         * linespec.c:
305         (find_linespec_symbols): Replace throw_exception with throw.
306         * infrun.c (displaced_step_prepare, resume): Replace
307         throw_exception with throw.
308         * infcmd.c (post_create_inferior): Replace throw_exception with
309         throw.
310         * inf-loop.c (inferior_event_handler): Replace throw_exception
311         with throw.
312         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
313         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
314         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
315         (get_prev_frame_always, get_frame_pc_if_available)
316         (get_frame_address_in_block_if_available, get_frame_language):
317         Replace throw_exception with throw.
318         * frame-unwind.c (frame_unwind_try_unwinder): Replace
319         throw_exception with throw.
320         * eval.c (fetch_subexp_value, evaluate_var_value)
321         (evaluate_funcall, evaluate_subexp_standard): Replace
322         throw_exception with throw.
323         * dwarf2loc.c (call_site_find_chain)
324         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
325         Replace throw_exception with throw.
326         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
327         with throw.
328         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
329         throw.
330         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
331         * completer.c (complete_line_internal): Replace throw_exception
332         with throw.
333         * compile/compile-object-run.c (compile_object_run): Replace
334         throw_exception with throw.
335         * cli/cli-script.c (process_next_line): Replace throw_exception
336         with throw.
337         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
338         (btrace_enable, btrace_maint_update_pt_packets): Replace
339         throw_exception with throw.
340         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
341         throw_exception with throw.
342         * break-catch-throw.c (re_set_exception_catchpoint): Replace
343         throw_exception with throw.
344         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
345         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
346         * aarch64-tdep.c (aarch64_make_prologue_cache)
347         (aarch64_make_stub_cache): Replace throw_exception with throw.
348
349 2019-04-08  Tom Tromey  <tom@tromey.com>
350
351         * common/common-exceptions.c (throw_exception): Rename from
352         throw_exception_cxx.  Remove old copy.  Make argument const.
353         (throw_it): Create and throw exception objects directly.
354         * common/common-exceptions.h (throw_exception): Make argument
355         const.
356         (struct gdb_exception_error): Add constructor.
357         (struct gdb_exception_quit): Add constructor.
358
359 2019-04-08  Tom Tromey  <tom@tromey.com>
360
361         * common/common-exceptions.h (exception_rethrow): Don't declare.
362         (TRY_SJLJ): Update comment.
363         (TRY, CATCH, END_CATCH): Remove.
364         * common/common-exceptions.c (exception_rethrow): Remove.
365
366 2019-04-08  Tom Tromey  <tom@tromey.com>
367
368         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
369         Remove.
370         (gdb_exception_error): Rename from
371         gdb_exception_RETURN_MASK_ERROR.
372         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
373         (gdb_quit_bad_alloc): Update.
374         * aarch64-tdep.c: Update.
375         * ada-lang.c: Update.
376         * ada-typeprint.c: Update.
377         * ada-valprint.c: Update.
378         * amd64-tdep.c: Update.
379         * arch-utils.c: Update.
380         * break-catch-throw.c: Update.
381         * breakpoint.c: Update.
382         * btrace.c: Update.
383         * c-varobj.c: Update.
384         * cli/cli-cmds.c: Update.
385         * cli/cli-interp.c: Update.
386         * cli/cli-script.c: Update.
387         * common/common-exceptions.c: Update.
388         * common/new-op.c: Update.
389         * common/selftest.c: Update.
390         * compile/compile-c-symbols.c: Update.
391         * compile/compile-cplus-symbols.c: Update.
392         * compile/compile-object-load.c: Update.
393         * compile/compile-object-run.c: Update.
394         * completer.c: Update.
395         * corelow.c: Update.
396         * cp-abi.c: Update.
397         * cp-support.c: Update.
398         * cp-valprint.c: Update.
399         * darwin-nat.c: Update.
400         * disasm-selftests.c: Update.
401         * dtrace-probe.c: Update.
402         * dwarf-index-cache.c: Update.
403         * dwarf-index-write.c: Update.
404         * dwarf2-frame-tailcall.c: Update.
405         * dwarf2-frame.c: Update.
406         * dwarf2loc.c: Update.
407         * dwarf2read.c: Update.
408         * eval.c: Update.
409         * event-loop.c: Update.
410         * event-top.c: Update.
411         * exec.c: Update.
412         * f-valprint.c: Update.
413         * fbsd-tdep.c: Update.
414         * frame-unwind.c: Update.
415         * frame.c: Update.
416         * gdbtypes.c: Update.
417         * gnu-v3-abi.c: Update.
418         * guile/guile-internal.h: Update.
419         * guile/scm-block.c: Update.
420         * guile/scm-breakpoint.c: Update.
421         * guile/scm-cmd.c: Update.
422         * guile/scm-disasm.c: Update.
423         * guile/scm-frame.c: Update.
424         * guile/scm-lazy-string.c: Update.
425         * guile/scm-math.c: Update.
426         * guile/scm-param.c: Update.
427         * guile/scm-ports.c: Update.
428         * guile/scm-pretty-print.c: Update.
429         * guile/scm-symbol.c: Update.
430         * guile/scm-symtab.c: Update.
431         * guile/scm-type.c: Update.
432         * guile/scm-value.c: Update.
433         * i386-linux-tdep.c: Update.
434         * i386-tdep.c: Update.
435         * inf-loop.c: Update.
436         * infcall.c: Update.
437         * infcmd.c: Update.
438         * infrun.c: Update.
439         * jit.c: Update.
440         * language.c: Update.
441         * linespec.c: Update.
442         * linux-fork.c: Update.
443         * linux-nat.c: Update.
444         * linux-tdep.c: Update.
445         * linux-thread-db.c: Update.
446         * main.c: Update.
447         * mi/mi-cmd-break.c: Update.
448         * mi/mi-cmd-stack.c: Update.
449         * mi/mi-interp.c: Update.
450         * mi/mi-main.c: Update.
451         * objc-lang.c: Update.
452         * p-valprint.c: Update.
453         * parse.c: Update.
454         * ppc-linux-tdep.c: Update.
455         * printcmd.c: Update.
456         * python/py-arch.c: Update.
457         * python/py-breakpoint.c: Update.
458         * python/py-cmd.c: Update.
459         * python/py-finishbreakpoint.c: Update.
460         * python/py-frame.c: Update.
461         * python/py-framefilter.c: Update.
462         * python/py-gdb-readline.c: Update.
463         * python/py-inferior.c: Update.
464         * python/py-infthread.c: Update.
465         * python/py-lazy-string.c: Update.
466         * python/py-linetable.c: Update.
467         * python/py-objfile.c: Update.
468         * python/py-param.c: Update.
469         * python/py-prettyprint.c: Update.
470         * python/py-progspace.c: Update.
471         * python/py-record-btrace.c: Update.
472         * python/py-record.c: Update.
473         * python/py-symbol.c: Update.
474         * python/py-type.c: Update.
475         * python/py-unwind.c: Update.
476         * python/py-utils.c: Update.
477         * python/py-value.c: Update.
478         * python/python.c: Update.
479         * record-btrace.c: Update.
480         * record-full.c: Update.
481         * remote-fileio.c: Update.
482         * remote.c: Update.
483         * riscv-tdep.c: Update.
484         * rs6000-aix-tdep.c: Update.
485         * rs6000-tdep.c: Update.
486         * rust-exp.y: Update.
487         * rust-lang.c: Update.
488         * s390-tdep.c: Update.
489         * selftest-arch.c: Update.
490         * solib-dsbt.c: Update.
491         * solib-frv.c: Update.
492         * solib-spu.c: Update.
493         * solib-svr4.c: Update.
494         * solib.c: Update.
495         * sparc64-linux-tdep.c: Update.
496         * stack.c: Update.
497         * symfile-mem.c: Update.
498         * symmisc.c: Update.
499         * target.c: Update.
500         * thread.c: Update.
501         * top.c: Update.
502         * tracefile-tfile.c: Update.
503         * tui/tui.c: Update.
504         * typeprint.c: Update.
505         * unittests/cli-utils-selftests.c: Update.
506         * unittests/parse-connection-spec-selftests.c: Update.
507         * valops.c: Update.
508         * valprint.c: Update.
509         * value.c: Update.
510         * varobj.c: Update.
511         * windows-nat.c: Update.
512         * x86-linux-nat.c: Update.
513         * xml-support.c: Update.
514
515 2019-04-08  Tom Tromey  <tom@tromey.com>
516
517         * xml-support.c: Use C++ exception handling.
518         * x86-linux-nat.c: Use C++ exception handling.
519         * windows-nat.c: Use C++ exception handling.
520         * varobj.c: Use C++ exception handling.
521         * value.c: Use C++ exception handling.
522         * valprint.c: Use C++ exception handling.
523         * valops.c: Use C++ exception handling.
524         * unittests/parse-connection-spec-selftests.c: Use C++ exception
525         handling.
526         * unittests/cli-utils-selftests.c: Use C++ exception handling.
527         * typeprint.c: Use C++ exception handling.
528         * tui/tui.c: Use C++ exception handling.
529         * tracefile-tfile.c: Use C++ exception handling.
530         * top.c: Use C++ exception handling.
531         * thread.c: Use C++ exception handling.
532         * target.c: Use C++ exception handling.
533         * symmisc.c: Use C++ exception handling.
534         * symfile-mem.c: Use C++ exception handling.
535         * stack.c: Use C++ exception handling.
536         * sparc64-linux-tdep.c: Use C++ exception handling.
537         * solib.c: Use C++ exception handling.
538         * solib-svr4.c: Use C++ exception handling.
539         * solib-spu.c: Use C++ exception handling.
540         * solib-frv.c: Use C++ exception handling.
541         * solib-dsbt.c: Use C++ exception handling.
542         * selftest-arch.c: Use C++ exception handling.
543         * s390-tdep.c: Use C++ exception handling.
544         * rust-lang.c: Use C++ exception handling.
545         * rust-exp.y: Use C++ exception handling.
546         * rs6000-tdep.c: Use C++ exception handling.
547         * rs6000-aix-tdep.c: Use C++ exception handling.
548         * riscv-tdep.c: Use C++ exception handling.
549         * remote.c: Use C++ exception handling.
550         * remote-fileio.c: Use C++ exception handling.
551         * record-full.c: Use C++ exception handling.
552         * record-btrace.c: Use C++ exception handling.
553         * python/python.c: Use C++ exception handling.
554         * python/py-value.c: Use C++ exception handling.
555         * python/py-utils.c: Use C++ exception handling.
556         * python/py-unwind.c: Use C++ exception handling.
557         * python/py-type.c: Use C++ exception handling.
558         * python/py-symbol.c: Use C++ exception handling.
559         * python/py-record.c: Use C++ exception handling.
560         * python/py-record-btrace.c: Use C++ exception handling.
561         * python/py-progspace.c: Use C++ exception handling.
562         * python/py-prettyprint.c: Use C++ exception handling.
563         * python/py-param.c: Use C++ exception handling.
564         * python/py-objfile.c: Use C++ exception handling.
565         * python/py-linetable.c: Use C++ exception handling.
566         * python/py-lazy-string.c: Use C++ exception handling.
567         * python/py-infthread.c: Use C++ exception handling.
568         * python/py-inferior.c: Use C++ exception handling.
569         * python/py-gdb-readline.c: Use C++ exception handling.
570         * python/py-framefilter.c: Use C++ exception handling.
571         * python/py-frame.c: Use C++ exception handling.
572         * python/py-finishbreakpoint.c: Use C++ exception handling.
573         * python/py-cmd.c: Use C++ exception handling.
574         * python/py-breakpoint.c: Use C++ exception handling.
575         * python/py-arch.c: Use C++ exception handling.
576         * printcmd.c: Use C++ exception handling.
577         * ppc-linux-tdep.c: Use C++ exception handling.
578         * parse.c: Use C++ exception handling.
579         * p-valprint.c: Use C++ exception handling.
580         * objc-lang.c: Use C++ exception handling.
581         * mi/mi-main.c: Use C++ exception handling.
582         * mi/mi-interp.c: Use C++ exception handling.
583         * mi/mi-cmd-stack.c: Use C++ exception handling.
584         * mi/mi-cmd-break.c: Use C++ exception handling.
585         * main.c: Use C++ exception handling.
586         * linux-thread-db.c: Use C++ exception handling.
587         * linux-tdep.c: Use C++ exception handling.
588         * linux-nat.c: Use C++ exception handling.
589         * linux-fork.c: Use C++ exception handling.
590         * linespec.c: Use C++ exception handling.
591         * language.c: Use C++ exception handling.
592         * jit.c: Use C++ exception handling.
593         * infrun.c: Use C++ exception handling.
594         * infcmd.c: Use C++ exception handling.
595         * infcall.c: Use C++ exception handling.
596         * inf-loop.c: Use C++ exception handling.
597         * i386-tdep.c: Use C++ exception handling.
598         * i386-linux-tdep.c: Use C++ exception handling.
599         * guile/scm-value.c: Use C++ exception handling.
600         * guile/scm-type.c: Use C++ exception handling.
601         * guile/scm-symtab.c: Use C++ exception handling.
602         * guile/scm-symbol.c: Use C++ exception handling.
603         * guile/scm-pretty-print.c: Use C++ exception handling.
604         * guile/scm-ports.c: Use C++ exception handling.
605         * guile/scm-param.c: Use C++ exception handling.
606         * guile/scm-math.c: Use C++ exception handling.
607         * guile/scm-lazy-string.c: Use C++ exception handling.
608         * guile/scm-frame.c: Use C++ exception handling.
609         * guile/scm-disasm.c: Use C++ exception handling.
610         * guile/scm-cmd.c: Use C++ exception handling.
611         * guile/scm-breakpoint.c: Use C++ exception handling.
612         * guile/scm-block.c: Use C++ exception handling.
613         * guile/guile-internal.h: Use C++ exception handling.
614         * gnu-v3-abi.c: Use C++ exception handling.
615         * gdbtypes.c: Use C++ exception handling.
616         * frame.c: Use C++ exception handling.
617         * frame-unwind.c: Use C++ exception handling.
618         * fbsd-tdep.c: Use C++ exception handling.
619         * f-valprint.c: Use C++ exception handling.
620         * exec.c: Use C++ exception handling.
621         * event-top.c: Use C++ exception handling.
622         * event-loop.c: Use C++ exception handling.
623         * eval.c: Use C++ exception handling.
624         * dwarf2read.c: Use C++ exception handling.
625         * dwarf2loc.c: Use C++ exception handling.
626         * dwarf2-frame.c: Use C++ exception handling.
627         * dwarf2-frame-tailcall.c: Use C++ exception handling.
628         * dwarf-index-write.c: Use C++ exception handling.
629         * dwarf-index-cache.c: Use C++ exception handling.
630         * dtrace-probe.c: Use C++ exception handling.
631         * disasm-selftests.c: Use C++ exception handling.
632         * darwin-nat.c: Use C++ exception handling.
633         * cp-valprint.c: Use C++ exception handling.
634         * cp-support.c: Use C++ exception handling.
635         * cp-abi.c: Use C++ exception handling.
636         * corelow.c: Use C++ exception handling.
637         * completer.c: Use C++ exception handling.
638         * compile/compile-object-run.c: Use C++ exception handling.
639         * compile/compile-object-load.c: Use C++ exception handling.
640         * compile/compile-cplus-symbols.c: Use C++ exception handling.
641         * compile/compile-c-symbols.c: Use C++ exception handling.
642         * common/selftest.c: Use C++ exception handling.
643         * common/new-op.c: Use C++ exception handling.
644         * cli/cli-script.c: Use C++ exception handling.
645         * cli/cli-interp.c: Use C++ exception handling.
646         * cli/cli-cmds.c: Use C++ exception handling.
647         * c-varobj.c: Use C++ exception handling.
648         * btrace.c: Use C++ exception handling.
649         * breakpoint.c: Use C++ exception handling.
650         * break-catch-throw.c: Use C++ exception handling.
651         * arch-utils.c: Use C++ exception handling.
652         * amd64-tdep.c: Use C++ exception handling.
653         * ada-valprint.c: Use C++ exception handling.
654         * ada-typeprint.c: Use C++ exception handling.
655         * ada-lang.c: Use C++ exception handling.
656         * aarch64-tdep.c: Use C++ exception handling.
657
658 2019-04-08  Tom Tromey  <tom@tromey.com>
659
660         * xml-support.c (gdb_xml_parser::parse): Update.
661         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
662         * value.c (show_convenience): Update.
663         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
664         (test_parse_flags_qcs): Update.
665         * thread.c (thr_try_catch_cmd): Update.
666         * target.c (target_translate_tls_address): Update.
667         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
668         (info_frame_command_core, frame_apply_command_count): Update.
669         * rust-exp.y (rust_lex_exception_test): Update.
670         * riscv-tdep.c (riscv_print_one_register_info): Update.
671         * remote.c (remote_target::enable_btrace): Update.
672         * record-btrace.c (record_btrace_enable_warn): Update.
673         * python/py-utils.c (gdbpy_convert_exception): Update.
674         * printcmd.c (do_one_display, print_variable_and_value): Update.
675         * mi/mi-main.c (mi_print_exception): Update.
676         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
677         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
678         * linux-nat.c (linux_nat_target::attach): Update.
679         * linux-fork.c (class scoped_switch_fork_info): Update.
680         * infrun.c (displaced_step_prepare): Update.
681         * infcall.c (call_function_by_hand_dummy): Update.
682         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
683         * gnu-v3-abi.c (print_one_vtable): Update.
684         * frame.c (get_prev_frame_always): Update.
685         * f-valprint.c (info_common_command_for_block): Update.
686         * exec.c (try_open_exec_file): Update.
687         * exceptions.c (print_exception, exception_print)
688         (exception_fprintf, exception_print_same): Update.
689         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
690         * dwarf-index-cache.c (index_cache::store)
691         (index_cache::lookup_gdb_index): Update.
692         * darwin-nat.c (maybe_cache_shell): Update.
693         * cp-valprint.c (cp_print_value_fields): Update.
694         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
695         (gcc_cplus_symbol_address): Update.
696         * compile/compile-c-symbols.c (gcc_convert_symbol)
697         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
698         * common/selftest.c: Update.
699         * common/common-exceptions.h (struct gdb_exception) <message>: Now
700         a std::string.
701         (exception_try_scope_entry, exception_try_scope_exit): Don't
702         declare.
703         (struct exception_try_scope): Remove.
704         (TRY): Don't use exception_try_scope.
705         (struct gdb_exception): Add constructor, operator=.
706         <what>: New method.
707         (struct gdb_exception_RETURN_MASK_ALL)
708         (struct gdb_exception_RETURN_MASK_ERROR)
709         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
710         (struct gdb_quit_bad_alloc): Update.
711         * common/common-exceptions.c (exception_none): Change
712         initializer.
713         (struct catcher) <state, exception>: Initialize inline.
714         <prev>: Remove member.
715         (current_catcher): Remove.
716         (catchers): New global.
717         (exceptions_state_mc_init): Simplify.
718         (catcher_pop): Remove.
719         (exceptions_state_mc, exceptions_state_mc_catch): Update.
720         (try_scope_depth, exception_try_scope_entry)
721         (exception_try_scope_exit): Remove.
722         (throw_exception_sjlj): Update.
723         (exception_messages, exception_messages_size): Remove.
724         (throw_it): Simplify.
725         (gdb_exception_sliced_copy): Remove.
726         (throw_exception_cxx): Update.
727         * cli/cli-script.c (script_from_file): Update.
728         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
729         Update.
730         * ada-valprint.c (ada_val_print): Update.
731         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
732         (create_excep_cond_exprs): Update.
733
734 2019-04-08  Tom Tromey  <tom@tromey.com>
735
736         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
737         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
738         (TRY, CATCH, END_CATCH): Remove some definitions.
739         * common/common-exceptions.c: Don't use GDB_XCPT.
740         (catcher_list_size): Remove.
741         (throw_exception, throw_it): Simplify.
742
743 2019-04-05  Tom Tromey  <tom@tromey.com>
744
745         Revert the header-sorting patch.
746         * ft32-tdep.c: Revert.
747         * frv-tdep.c: Revert.
748         * frv-linux-tdep.c: Revert.
749         * frame.c: Revert.
750         * frame-unwind.c: Revert.
751         * frame-base.c: Revert.
752         * fork-child.c: Revert.
753         * findvar.c: Revert.
754         * findcmd.c: Revert.
755         * filesystem.c: Revert.
756         * filename-seen-cache.h: Revert.
757         * filename-seen-cache.c: Revert.
758         * fbsd-tdep.c: Revert.
759         * fbsd-nat.h: Revert.
760         * fbsd-nat.c: Revert.
761         * f-valprint.c: Revert.
762         * f-typeprint.c: Revert.
763         * f-lang.c: Revert.
764         * extension.h: Revert.
765         * extension.c: Revert.
766         * extension-priv.h: Revert.
767         * expprint.c: Revert.
768         * exec.h: Revert.
769         * exec.c: Revert.
770         * exceptions.c: Revert.
771         * event-top.c: Revert.
772         * event-loop.c: Revert.
773         * eval.c: Revert.
774         * elfread.c: Revert.
775         * dwarf2read.h: Revert.
776         * dwarf2read.c: Revert.
777         * dwarf2loc.c: Revert.
778         * dwarf2expr.h: Revert.
779         * dwarf2expr.c: Revert.
780         * dwarf2-frame.c: Revert.
781         * dwarf2-frame-tailcall.c: Revert.
782         * dwarf-index-write.h: Revert.
783         * dwarf-index-write.c: Revert.
784         * dwarf-index-common.c: Revert.
785         * dwarf-index-cache.h: Revert.
786         * dwarf-index-cache.c: Revert.
787         * dummy-frame.c: Revert.
788         * dtrace-probe.c: Revert.
789         * disasm.h: Revert.
790         * disasm.c: Revert.
791         * disasm-selftests.c: Revert.
792         * dictionary.c: Revert.
793         * dicos-tdep.c: Revert.
794         * demangle.c: Revert.
795         * dcache.h: Revert.
796         * dcache.c: Revert.
797         * darwin-nat.h: Revert.
798         * darwin-nat.c: Revert.
799         * darwin-nat-info.c: Revert.
800         * d-valprint.c: Revert.
801         * d-namespace.c: Revert.
802         * d-lang.c: Revert.
803         * ctf.c: Revert.
804         * csky-tdep.c: Revert.
805         * csky-linux-tdep.c: Revert.
806         * cris-tdep.c: Revert.
807         * cris-linux-tdep.c: Revert.
808         * cp-valprint.c: Revert.
809         * cp-support.c: Revert.
810         * cp-namespace.c: Revert.
811         * cp-abi.c: Revert.
812         * corelow.c: Revert.
813         * corefile.c: Revert.
814         * continuations.c: Revert.
815         * completer.h: Revert.
816         * completer.c: Revert.
817         * complaints.c: Revert.
818         * coffread.c: Revert.
819         * coff-pe-read.c: Revert.
820         * cli-out.h: Revert.
821         * cli-out.c: Revert.
822         * charset.c: Revert.
823         * c-varobj.c: Revert.
824         * c-valprint.c: Revert.
825         * c-typeprint.c: Revert.
826         * c-lang.c: Revert.
827         * buildsym.c: Revert.
828         * buildsym-legacy.c: Revert.
829         * build-id.h: Revert.
830         * build-id.c: Revert.
831         * btrace.c: Revert.
832         * bsd-uthread.c: Revert.
833         * breakpoint.h: Revert.
834         * breakpoint.c: Revert.
835         * break-catch-throw.c: Revert.
836         * break-catch-syscall.c: Revert.
837         * break-catch-sig.c: Revert.
838         * blockframe.c: Revert.
839         * block.c: Revert.
840         * bfin-tdep.c: Revert.
841         * bfin-linux-tdep.c: Revert.
842         * bfd-target.c: Revert.
843         * bcache.c: Revert.
844         * ax-general.c: Revert.
845         * ax-gdb.h: Revert.
846         * ax-gdb.c: Revert.
847         * avr-tdep.c: Revert.
848         * auxv.c: Revert.
849         * auto-load.c: Revert.
850         * arm-wince-tdep.c: Revert.
851         * arm-tdep.c: Revert.
852         * arm-symbian-tdep.c: Revert.
853         * arm-pikeos-tdep.c: Revert.
854         * arm-obsd-tdep.c: Revert.
855         * arm-nbsd-tdep.c: Revert.
856         * arm-nbsd-nat.c: Revert.
857         * arm-linux-tdep.c: Revert.
858         * arm-linux-nat.c: Revert.
859         * arm-fbsd-tdep.c: Revert.
860         * arm-fbsd-nat.c: Revert.
861         * arm-bsd-tdep.c: Revert.
862         * arch-utils.c: Revert.
863         * arc-tdep.c: Revert.
864         * arc-newlib-tdep.c: Revert.
865         * annotate.h: Revert.
866         * annotate.c: Revert.
867         * amd64-windows-tdep.c: Revert.
868         * amd64-windows-nat.c: Revert.
869         * amd64-tdep.c: Revert.
870         * amd64-sol2-tdep.c: Revert.
871         * amd64-obsd-tdep.c: Revert.
872         * amd64-obsd-nat.c: Revert.
873         * amd64-nbsd-tdep.c: Revert.
874         * amd64-nbsd-nat.c: Revert.
875         * amd64-nat.c: Revert.
876         * amd64-linux-tdep.c: Revert.
877         * amd64-linux-nat.c: Revert.
878         * amd64-fbsd-tdep.c: Revert.
879         * amd64-fbsd-nat.c: Revert.
880         * amd64-dicos-tdep.c: Revert.
881         * amd64-darwin-tdep.c: Revert.
882         * amd64-bsd-nat.c: Revert.
883         * alpha-tdep.c: Revert.
884         * alpha-obsd-tdep.c: Revert.
885         * alpha-nbsd-tdep.c: Revert.
886         * alpha-mdebug-tdep.c: Revert.
887         * alpha-linux-tdep.c: Revert.
888         * alpha-linux-nat.c: Revert.
889         * alpha-bsd-tdep.c: Revert.
890         * alpha-bsd-nat.c: Revert.
891         * aix-thread.c: Revert.
892         * agent.c: Revert.
893         * addrmap.c: Revert.
894         * ada-varobj.c: Revert.
895         * ada-valprint.c: Revert.
896         * ada-typeprint.c: Revert.
897         * ada-tasks.c: Revert.
898         * ada-lang.c: Revert.
899         * aarch64-tdep.c: Revert.
900         * aarch64-ravenscar-thread.c: Revert.
901         * aarch64-newlib-tdep.c: Revert.
902         * aarch64-linux-tdep.c: Revert.
903         * aarch64-linux-nat.c: Revert.
904         * aarch64-fbsd-tdep.c: Revert.
905         * aarch64-fbsd-nat.c: Revert.
906         * aarch32-linux-nat.c: Revert.
907
908 2019-04-05  Tom Tromey  <tom@tromey.com>
909
910         * ft32-tdep.c: Sort headers.
911         * frv-tdep.c: Sort headers.
912         * frv-linux-tdep.c: Sort headers.
913         * frame.c: Sort headers.
914         * frame-unwind.c: Sort headers.
915         * frame-base.c: Sort headers.
916         * fork-child.c: Sort headers.
917         * findvar.c: Sort headers.
918         * findcmd.c: Sort headers.
919         * filesystem.c: Sort headers.
920         * filename-seen-cache.h: Sort headers.
921         * filename-seen-cache.c: Sort headers.
922         * fbsd-tdep.c: Sort headers.
923         * fbsd-nat.h: Sort headers.
924         * fbsd-nat.c: Sort headers.
925         * f-valprint.c: Sort headers.
926         * f-typeprint.c: Sort headers.
927         * f-lang.c: Sort headers.
928         * extension.h: Sort headers.
929         * extension.c: Sort headers.
930         * extension-priv.h: Sort headers.
931         * expprint.c: Sort headers.
932         * exec.h: Sort headers.
933         * exec.c: Sort headers.
934         * exceptions.c: Sort headers.
935         * event-top.c: Sort headers.
936         * event-loop.c: Sort headers.
937         * eval.c: Sort headers.
938         * elfread.c: Sort headers.
939         * dwarf2read.h: Sort headers.
940         * dwarf2read.c: Sort headers.
941         * dwarf2loc.c: Sort headers.
942         * dwarf2expr.h: Sort headers.
943         * dwarf2expr.c: Sort headers.
944         * dwarf2-frame.c: Sort headers.
945         * dwarf2-frame-tailcall.c: Sort headers.
946         * dwarf-index-write.h: Sort headers.
947         * dwarf-index-write.c: Sort headers.
948         * dwarf-index-common.c: Sort headers.
949         * dwarf-index-cache.h: Sort headers.
950         * dwarf-index-cache.c: Sort headers.
951         * dummy-frame.c: Sort headers.
952         * dtrace-probe.c: Sort headers.
953         * disasm.h: Sort headers.
954         * disasm.c: Sort headers.
955         * disasm-selftests.c: Sort headers.
956         * dictionary.c: Sort headers.
957         * dicos-tdep.c: Sort headers.
958         * demangle.c: Sort headers.
959         * dcache.h: Sort headers.
960         * dcache.c: Sort headers.
961         * darwin-nat.h: Sort headers.
962         * darwin-nat.c: Sort headers.
963         * darwin-nat-info.c: Sort headers.
964         * d-valprint.c: Sort headers.
965         * d-namespace.c: Sort headers.
966         * d-lang.c: Sort headers.
967         * ctf.c: Sort headers.
968         * csky-tdep.c: Sort headers.
969         * csky-linux-tdep.c: Sort headers.
970         * cris-tdep.c: Sort headers.
971         * cris-linux-tdep.c: Sort headers.
972         * cp-valprint.c: Sort headers.
973         * cp-support.c: Sort headers.
974         * cp-namespace.c: Sort headers.
975         * cp-abi.c: Sort headers.
976         * corelow.c: Sort headers.
977         * corefile.c: Sort headers.
978         * continuations.c: Sort headers.
979         * completer.h: Sort headers.
980         * completer.c: Sort headers.
981         * complaints.c: Sort headers.
982         * coffread.c: Sort headers.
983         * coff-pe-read.c: Sort headers.
984         * cli-out.h: Sort headers.
985         * cli-out.c: Sort headers.
986         * charset.c: Sort headers.
987         * c-varobj.c: Sort headers.
988         * c-valprint.c: Sort headers.
989         * c-typeprint.c: Sort headers.
990         * c-lang.c: Sort headers.
991         * buildsym.c: Sort headers.
992         * buildsym-legacy.c: Sort headers.
993         * build-id.h: Sort headers.
994         * build-id.c: Sort headers.
995         * btrace.c: Sort headers.
996         * bsd-uthread.c: Sort headers.
997         * breakpoint.h: Sort headers.
998         * breakpoint.c: Sort headers.
999         * break-catch-throw.c: Sort headers.
1000         * break-catch-syscall.c: Sort headers.
1001         * break-catch-sig.c: Sort headers.
1002         * blockframe.c: Sort headers.
1003         * block.c: Sort headers.
1004         * bfin-tdep.c: Sort headers.
1005         * bfin-linux-tdep.c: Sort headers.
1006         * bfd-target.c: Sort headers.
1007         * bcache.c: Sort headers.
1008         * ax-general.c: Sort headers.
1009         * ax-gdb.h: Sort headers.
1010         * ax-gdb.c: Sort headers.
1011         * avr-tdep.c: Sort headers.
1012         * auxv.c: Sort headers.
1013         * auto-load.c: Sort headers.
1014         * arm-wince-tdep.c: Sort headers.
1015         * arm-tdep.c: Sort headers.
1016         * arm-symbian-tdep.c: Sort headers.
1017         * arm-pikeos-tdep.c: Sort headers.
1018         * arm-obsd-tdep.c: Sort headers.
1019         * arm-nbsd-tdep.c: Sort headers.
1020         * arm-nbsd-nat.c: Sort headers.
1021         * arm-linux-tdep.c: Sort headers.
1022         * arm-linux-nat.c: Sort headers.
1023         * arm-fbsd-tdep.c: Sort headers.
1024         * arm-fbsd-nat.c: Sort headers.
1025         * arm-bsd-tdep.c: Sort headers.
1026         * arch-utils.c: Sort headers.
1027         * arc-tdep.c: Sort headers.
1028         * arc-newlib-tdep.c: Sort headers.
1029         * annotate.h: Sort headers.
1030         * annotate.c: Sort headers.
1031         * amd64-windows-tdep.c: Sort headers.
1032         * amd64-windows-nat.c: Sort headers.
1033         * amd64-tdep.c: Sort headers.
1034         * amd64-sol2-tdep.c: Sort headers.
1035         * amd64-obsd-tdep.c: Sort headers.
1036         * amd64-obsd-nat.c: Sort headers.
1037         * amd64-nbsd-tdep.c: Sort headers.
1038         * amd64-nbsd-nat.c: Sort headers.
1039         * amd64-nat.c: Sort headers.
1040         * amd64-linux-tdep.c: Sort headers.
1041         * amd64-linux-nat.c: Sort headers.
1042         * amd64-fbsd-tdep.c: Sort headers.
1043         * amd64-fbsd-nat.c: Sort headers.
1044         * amd64-dicos-tdep.c: Sort headers.
1045         * amd64-darwin-tdep.c: Sort headers.
1046         * amd64-bsd-nat.c: Sort headers.
1047         * alpha-tdep.c: Sort headers.
1048         * alpha-obsd-tdep.c: Sort headers.
1049         * alpha-nbsd-tdep.c: Sort headers.
1050         * alpha-mdebug-tdep.c: Sort headers.
1051         * alpha-linux-tdep.c: Sort headers.
1052         * alpha-linux-nat.c: Sort headers.
1053         * alpha-bsd-tdep.c: Sort headers.
1054         * alpha-bsd-nat.c: Sort headers.
1055         * aix-thread.c: Sort headers.
1056         * agent.c: Sort headers.
1057         * addrmap.c: Sort headers.
1058         * ada-varobj.c: Sort headers.
1059         * ada-valprint.c: Sort headers.
1060         * ada-typeprint.c: Sort headers.
1061         * ada-tasks.c: Sort headers.
1062         * ada-lang.c: Sort headers.
1063         * aarch64-tdep.c: Sort headers.
1064         * aarch64-ravenscar-thread.c: Sort headers.
1065         * aarch64-newlib-tdep.c: Sort headers.
1066         * aarch64-linux-tdep.c: Sort headers.
1067         * aarch64-linux-nat.c: Sort headers.
1068         * aarch64-fbsd-tdep.c: Sort headers.
1069         * aarch64-fbsd-nat.c: Sort headers.
1070         * aarch32-linux-nat.c: Sort headers.
1071
1072 2019-04-04  Tom Tromey  <tom@tromey.com>
1073
1074         * varobj.c (varobj_create): Update.
1075         * rust-exp.y (struct rust_parser) <update_innermost_block,
1076         lookup_symbol>: New methods.
1077         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1078         Rename.
1079         (rust_parser::rust_lookup_type)
1080         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1081         * printcmd.c (display_command, do_one_display): Update.
1082         * parser-defs.h (struct parser_state) <parser_state>: Add
1083         "tracker" parameter.
1084         (block_tracker): New member.
1085         (class innermost_block_tracker) <innermost_block_tracker>: Add
1086         "types" parameter.
1087         <reset>: Remove method.
1088         (innermost_block): Don't declare.
1089         (null_post_parser): Update.
1090         * parse.c (innermost_block): Remove global.
1091         (write_dollar_variable): Update.
1092         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1093         Remove "tracker_types" parameter.
1094         (parse_expression): Add "tracker" parameter.
1095         (parse_expression_for_completion): Update.
1096         (null_post_parser): Add "tracker" parameter.
1097         * p-exp.y: Update rules.
1098         * m2-exp.y: Update rules.
1099         * language.h (struct language_defn) <la_post_parser>: Add
1100         "tracker" parameter.
1101         * go-exp.y: Update rules.
1102         * f-exp.y: Update rules.
1103         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1104         parameter.
1105         * d-exp.y: Update rules.
1106         * c-exp.y: Update rules.
1107         * breakpoint.c (set_breakpoint_condition): Create an
1108         innermost_block_tracker.
1109         (watch_command_1): Likewise.
1110         * ada-lang.c (resolve): Add "tracker" parameter.
1111         (resolve_subexp): Likewise.
1112         * ada-exp.y (write_var_from_sym): Update.
1113
1114 2019-04-04  Tom Tromey  <tom@tromey.com>
1115
1116         * type-stack.h: New file.
1117         * type-stack.c: New file.
1118         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1119         type-stack.h.
1120         (insert_into_type_stack, insert_type, push_type, push_type_int)
1121         (insert_type_address_space, pop_type, pop_type_int)
1122         (pop_typelist, pop_type_stack, append_type_stack)
1123         (push_type_stack, get_type_stack, push_typelist)
1124         (follow_type_instance_flags, follow_types): Don't declare.
1125         * parse.c (type_stack): Remove global.
1126         (parse_exp_in_context): Update.
1127         (insert_into_type_stack, insert_type, push_type, push_type_int)
1128         (insert_type_address_space, pop_type, pop_type_int)
1129         (pop_typelist, pop_type_stack, append_type_stack)
1130         (push_type_stack, get_type_stack, push_typelist)
1131         (follow_type_instance_flags, follow_types): Remove (moved to
1132         type-stack.c).
1133         * f-exp.y (type_stack): New global.
1134         Update rules.
1135         (push_kind_type, f_parse): Update.
1136         * d-exp.y (type_stack): New global.
1137         Update rules.
1138         (d_parse): Update.
1139         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1140         Update rules.
1141         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1142         (HFILES_NO_SRCDIR): Add type-stack.h.
1143
1144 2019-04-04  Tom Tromey  <tom@tromey.com>
1145
1146         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1147         (rust_parser::convert_ast_to_expression, rust_parse)
1148         (rust_lex_test_completion, rust_lex_tests): Update.
1149         * parser-defs.h (struct expr_completion_state): New.
1150         (struct parser_state) <parser_state>: Add completion parameter.
1151         <mark_struct_expression, mark_completion_tag>: New methods.
1152         <parse_completion, m_completion_state>: New members.
1153         (prefixify_expression, null_post_parser): Update.
1154         (mark_struct_expression, mark_completion_tag): Don't declare.
1155         * parse.c (parse_completion, expout_last_struct)
1156         (expout_tag_completion_type, expout_completion_name): Remove
1157         globals.
1158         (parser_state::mark_struct_expression)
1159         (parser_state::mark_completion_tag): Now methods.
1160         (prefixify_expression): Add last_struct parameter.
1161         (prefixify_subexp): Likewise.
1162         (parse_exp_1): Update.
1163         (parse_exp_in_context): Add cstate parameter.  Update.
1164         (parse_expression_for_completion): Create an
1165         expr_completion_state.
1166         (null_post_parser): Add "completion" parameter.
1167         * p-exp.y: Update rules.
1168         (yylex): Update.
1169         * language.h (struct language_defn) <la_post_parser>: Add
1170         "completing" parameter.
1171         * go-exp.y: Update rules.
1172         (lex_one_token): Update.
1173         * expression.h (parse_completion): Don't declare.
1174         * d-exp.y: Update rules.
1175         (lex_one_token): Update rules.
1176         * c-exp.y: Update rules.
1177         (lex_one_token): Update.
1178         * ada-lang.c (resolve): Add "parse_completion" parameter.
1179         (resolve_subexp): Likewise.
1180         (ada_resolve_function): Likewise.
1181
1182 2019-04-04  Tom Tromey  <tom@tromey.com>
1183
1184         * parser-defs.h (struct parser_state) <start_arglist,
1185         end_arglist>: New methods.
1186         <arglist_len, m_funcall_chain>: New members.
1187         (arglist_len, start_arglist, end_arglist): Don't declare.
1188         * parse.c (arglist_len, funcall_chain): Remove global.
1189         (start_arglist, end_arglist): Remove functions.
1190         (parse_exp_in_context): Update.
1191         * p-exp.y: Update rules.
1192         * m2-exp.y: Update rules.
1193         * go-exp.y: Update rules.
1194         * f-exp.y: Update rules.
1195         * d-exp.y: Update rules.
1196         * c-exp.y: Update rules.
1197
1198 2019-04-04  Tom Tromey  <tom@tromey.com>
1199
1200         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1201         lex_operator, push_back>: New methods.
1202         Update all rules.
1203         (rust_parser::lex_hex, lex_escape): Rename and update.
1204         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1205         (rust_parser::lex_operator): Rename and update.
1206         (rust_parser::lex_number, rustyylex, rustyyerror)
1207         (rust_lex_test_init, rust_lex_test_sequence)
1208         (rust_lex_test_push_back, rust_lex_tests): Update.
1209         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1210         parameter.
1211         <lexptr, prev_lexptr>: New members.
1212         (lexptr, prev_lexptr): Don't declare.
1213         * parse.c (lexptr, prev_lexptr): Remove globals.
1214         (parse_exp_in_context): Update.
1215         * p-exp.y (yylex, yyerror): Update.
1216         * m2-exp.y (parse_number, yylex, yyerror): Update.
1217         * go-exp.y (lex_one_token, yyerror): Update.
1218         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1219         * d-exp.y (lex_one_token, yyerror): Update.
1220         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1221         (lex_one_token, yyerror): Update.
1222         * ada-lex.l (YY_INPUT): Update.
1223         (rewind_to_char): Update.
1224         * ada-exp.y (yyerror): Update.
1225
1226 2019-04-04  Tom Tromey  <tom@tromey.com>
1227
1228         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1229         * parser-defs.h (struct parser_state) <parser_state>: Add new
1230         parameter.
1231         <comma_terminates>: New member.
1232         (comma_terminates): Don't declare global.
1233         * parse.c (comma_terminates): Remove global.
1234         (parse_exp_in_context): Update.
1235         * p-exp.y (yylex): Update.
1236         * m2-exp.y (yylex): Update.
1237         * go-exp.y (lex_one_token): Update.
1238         * f-exp.y (yylex): Update.
1239         * d-exp.y (lex_one_token): Update.
1240         * c-exp.y (lex_one_token): Update.
1241         * ada-lex.l: Update.
1242
1243 2019-04-04  Tom Tromey  <tom@tromey.com>
1244
1245         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1246         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1247         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1248         * parser-defs.h (paren_depth): Don't declare.
1249         * parse.c (paren_depth): Remove global.
1250         (parse_exp_in_context): Update.
1251         * p-exp.y (paren_depth): New global.
1252         (pascal_parse): Initialize it.
1253         * m2-exp.y (paren_depth): New global.
1254         (m2_parse): Initialize it.
1255         * go-exp.y (paren_depth): New global.
1256         (go_parse): Initialize it.
1257         * f-exp.y (paren_depth): New global.
1258         (f_parse): Initialize it.
1259         * d-exp.y (paren_depth): New global.
1260         (d_parse): Initialize it.
1261         * c-exp.y (paren_depth): New global.
1262         (c_parse): Initialize it.
1263         * ada-lex.l (paren_depth): New global.
1264         (lexer_init): Initialize it.
1265
1266 2019-04-04  Tom Tromey  <tom@tromey.com>
1267
1268         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1269         (rust_parser::convert_ast_to_type)
1270         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1271         * parser-defs.h (struct parser_state) <parser_state>: Add
1272         parameters.  Initialize new members.
1273         <expression_context_block, expression_context_pc>: New members.
1274         * parse.c (expression_context_block, expression_context_pc):
1275         Remove globals.
1276         (parse_exp_in_context): Update.
1277         * p-exp.y: Update all rules.
1278         (yylex): Update.
1279         * m2-exp.y: Update all rules.
1280         (yylex): Update.
1281         * go-exp.y (yylex): Update.
1282         * f-exp.y (yylex): Update.
1283         * d-exp.y: Update all rules.
1284         (yylex): Update.
1285         * c-exp.y: Update all rules.
1286         (lex_one_token, classify_name, yylex, c_parse): Update.
1287         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1288
1289 2019-04-04  Tom Tromey  <tom@tromey.com>
1290
1291         * gdbarch.h, gdbarch.c: Rebuild.
1292         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1293         * stap-probe.h: 
1294         (struct stap_parse_info): Replace "parser_state" with
1295         "expr_builder".
1296         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1297         (parser_state): New class.
1298         * parse.c (expr_builder): Rename.
1299         (expr_builder::release): Rename.
1300         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1301         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1302         (write_exp_elt_longcst, write_exp_elt_floatcst)
1303         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1304         (write_exp_string_vector, write_exp_bitstring)
1305         (write_exp_msymbol, mark_struct_expression)
1306         (write_dollar_variable)
1307         (insert_type_address_space, increase_expout_size): Replace
1308         "parser_state" with "expr_builder".
1309         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1310         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1311         "parser_state" with "expr_builder".
1312
1313 2019-04-04  Tom Tromey  <tom@tromey.com>
1314
1315         * rust-exp.y: Replace "parse_language" with method call.
1316         * p-exp.y: 
1317         (yylex): Replace "parse_language" with method call.
1318         * m2-exp.y: 
1319         (yylex): Replace "parse_language" with method call.
1320         * go-exp.y (classify_name): Replace "parse_language" with method
1321         call.
1322         * f-exp.y (yylex): Replace "parse_language" with method call.
1323         * d-exp.y (lex_one_token): Replace "parse_language" with method
1324         call.
1325         * c-exp.y: 
1326         (lex_one_token, classify_name, yylex): Replace "parse_language"
1327         with method call.
1328         * ada-exp.y (find_primitive_type, type_char)
1329         (type_system_address): Replace "parse_language" with method call.
1330
1331 2019-04-04  Tom Tromey  <tom@tromey.com>
1332
1333         * rust-exp.y: Replace "parse_gdbarch" with method call.
1334         * parse.c (write_dollar_variable, insert_type_address_space):
1335         Replace "parse_gdbarch" with method call.
1336         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1337         call.
1338         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1339         call.
1340         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1341         "parse_gdbarch" with method call.
1342         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1343         with method call.
1344         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1345         "parse_gdbarch" with method call.
1346         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1347         "parse_gdbarch" with method call.
1348         * c-exp.y (parse_type, parse_number, classify_name): Replace
1349         "parse_gdbarch" with method call.
1350         * ada-lex.l: Replace "parse_gdbarch" with method call.
1351         * ada-exp.y (parse_type, find_primitive_type, type_char)
1352         (type_system_address): Replace "parse_gdbarch" with method call.
1353
1354 2019-04-04  Tom Tromey  <tom@tromey.com>
1355
1356         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1357         * stap-probe.c (stap_parse_argument): Update.
1358         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1359         initial_size parameter.
1360         * rust-exp.y (rust_lex_tests): Update.
1361         * parse.c (parser_state): Update.
1362         (parse_exp_in_context): Update.
1363         * parser-defs.h (struct parser_state) <parser_state>: Remove
1364         "initial_size" parameter.
1365
1366 2019-04-04  Tom Tromey  <tom@tromey.com>
1367
1368         * parser-defs.h (increase_expout_size): Don't declare.
1369         * parse.c (increase_expout_size): Now static.
1370
1371 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1372
1373         * gnu-nat.c (gnu_nat_target::wait): Fix
1374         target_waitstatus_to_string call.
1375
1376 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1377
1378         * eval.c (evaluate_subexp_standard): Handle internal functions
1379         during Fortran function call handling.
1380
1381 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1382
1383         * NEWS: Mention new internal functions.
1384         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1385         (read_base_type): Use dwarf2_init_complex_target_type.
1386         * value.c (creal_internal_fn): New function.
1387         (cimag_internal_fn): New function.
1388         (_initialize_values): Register new internal functions.
1389
1390 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1391
1392         * infrun.c (stop_all_threads): If debug_infrun, always
1393         trace the wait status after wait_one, using
1394         target_waitstatus_to_string and target_pid_to_str.
1395         (handle_inferior_event): Replace various trace of
1396         wait status kind by a single trace.
1397         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1398         wait status kind image by target_waitstatus_to_string.
1399         * target/waitstatus.c (target_waitstatus_to_string): Fix
1400         obsolete comment.
1401
1402 2019-04-01  Tom Tromey  <tromey@adacore.com>
1403
1404         PR symtab/23331:
1405         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1406
1407 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1408             Pedro Alves  <palves@redhat.com>
1409
1410         * top.c (quit_force): Call 'finalize_values'.
1411         * value.c (finalize_values): New function.
1412         * value.h (finalize_values): Declare.
1413
1414 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1415
1416         * NEWS: Announce $_gdb_major and $_gdb_minor.
1417
1418         * top.c (init_gdb_version_vars): New function.
1419         (gdb_init): Call init_gdb_version_vars.
1420
1421 2019-03-29  Tom Tromey  <tromey@adacore.com>
1422
1423         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1424         help text.  Remove dead code.
1425
1426 2019-03-29  Keith Seitz  <keiths@redhat.com>
1427
1428         From Siddhesh Poyarekar:
1429         * f-lang.h (f77_get_upperbound): Return LONGEST.
1430         (f77_get_lowerbound): Likewise.
1431         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1432         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1433         print them.
1434         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1435         plongest to format print it.
1436         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1437         (f77_get_upperbound): Likewise.
1438         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1439         LOWER_BOUND to LONGEST.
1440         (f77_create_arrayprint_offset_tbl): Likewise.
1441
1442 2019-03-29  Keith Seitz  <keiths@redhat.com>
1443
1444         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1445         %s/pulongest for TYPE_LENGTH instead of %d in format
1446         strings.
1447         * ada-typerint.c (ada_print_type): Likewise.
1448         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1449         * compile/compile-c-support.c (generate_register_struct): Likewise.
1450         * gdbtypes.c (recursive_dump_type): Likewise.
1451         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1452         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1453         instead of %d in format strings.
1454         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1455         to std::min to ULONGEST.
1456         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1457         instead of %d in format strings.
1458         * tracepoint.c (info_scope_command): Likewise.
1459         * typeprint.c (print_offset_data::update)
1460         (print_offset_data::finish): Likewise.
1461         * xtensa-tdep.c (xtensa_store_return_value)
1462         (xtensa_push_dummy_call): Likewise.
1463
1464 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1465
1466         * windows-nat.c (display_selector): Fixed format specifications
1467         for 64-bit Cygwin.
1468
1469 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1470
1471         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1472
1473 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1474
1475         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1476         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1477         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1478         (nios2_linux_init_abi): Install it.
1479
1480 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1481
1482         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1483
1484 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1485
1486         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1487
1488 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1489             Tom Tromey  <tromey@adacore.com>
1490
1491         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1492
1493 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1494
1495         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1496         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1497         method to compute the bounds of range types. Also print "[evaluated]"
1498         if the bounds' values come from a dynamic evaluation.
1499
1500 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1501
1502         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1503         whitespace when pretty printing is on.
1504
1505 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1506
1507         * ppc-linux-nat.c: Add include.
1508
1509 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1510
1511         * NEWS: Mention AArch64 Pointer Authentication.
1512
1513 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1514
1515         * arm-linux-nat.c: Add include.
1516
1517 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1518
1519         * source-cache.c (source_cache::get_source_lines): Re-read
1520         fullname after calling open_source_file.
1521
1522 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1523
1524         * NEWS: Mention TLS support for FreeBSD.
1525
1526 2019-03-25  Tom Tromey  <tromey@adacore.com>
1527
1528         * minsyms.c (BUNCH_SIZE): Update comment.
1529         (~minimal_symbol_reader): Remove old comment.
1530         (compact_minimal_symbols): Update comment.
1531         (minimal_symbol_reader::install): Remove old comment.  Update
1532         other comments.
1533
1534 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1535
1536         * s390-linux-nat.c: Add include.
1537
1538 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1539
1540         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1541         Call linux_get_hwcap.
1542         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1543         Likewise.
1544         (aarch64_linux_get_hwcap): Remove function.
1545         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1546         declaration.
1547         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1548         linux_get_hwcap.
1549         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1550         * linux-tdep.c (linux_get_hwcap): Add function.
1551         (linux_get_hwcap2): Likewise.
1552         * linux-tdep.h (linux_get_hwcap): Add declaration.
1553         (linux_get_hwcap2): Likewise.
1554         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1555         (ppc_linux_get_hwcap2): Likewise.
1556         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1557         linux_get_hwcap.
1558         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1559         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1560         (ppc_linux_nat_target::read_description): Likewise.
1561         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1562         * s390-linux-nat.c: Likewise.
1563         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1564
1565 2019-03-24  Tom Tromey  <tom@tromey.com>
1566
1567         * ada-lang.c (standard_lookup): Simplify initialization.
1568         (ada_lookup_symbol_nonlocal): Simplify return.
1569         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1570         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1571         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1572         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1573         initialization.
1574         * solib.c (solib_global_lookup): Simplify.
1575         * symtab.c (null_block_symbol): Remove.
1576         (symbol_cache_lookup): Simplify returns.
1577         (lookup_language_this): Simplify returns.
1578         (lookup_symbol_aux): Simplify return.
1579         (lookup_local_symbol): Simplify returns.
1580         (lookup_global_symbol_from_objfile): Simplify return.
1581         (lookup_symbol_in_objfile_symtabs)
1582         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1583         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1584         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1585         * cp-namespace.c (cp_lookup_bare_symbol)
1586         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1587         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1588         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1589         (cp_lookup_symbol_via_imports): Simplify initialization.
1590         (find_symbol_in_baseclass): Likewise.
1591         * symtab.h (null_block_symbol): Remove.
1592         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1593         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1594         (d_lookup_symbol_module): Likewise.
1595         (find_symbol_in_baseclass): Simplify initialization.
1596
1597 2019-03-24  Tom Tromey  <tom@tromey.com>
1598
1599         * expression.h: Don't include symtab.h.
1600         (struct block): Forward declare.
1601
1602 2019-03-24  Tom Tromey  <tom@tromey.com>
1603
1604         * c-exp.y (typebase): Remove casts.
1605         * gdbtypes.c (lookup_unsigned_typename, )
1606         (lookup_signed_typename): Remove cast.
1607         * eval.c (parse_to_comma_and_eval): Remove cast.
1608         * parse.c (write_dollar_variable): Remove cast.
1609         * block.h (struct block) <superblock>: Now const.
1610         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1611         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1612         (map_block): Make "block" const.
1613         * symfile.h (struct quick_symbol_functions)
1614         <map_matching_symbols>: Constify block argument to "callback".
1615         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1616         const.
1617         (find_pc_sect_compunit_symtab): Make "b" const.
1618         (find_symbol_at_address): Likewise.
1619         (search_symbols): Likewise.
1620         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1621         (dw2_debug_names_lookup_symbol): Likewise.
1622         (dw2_map_matching_symbols): Update.
1623         * p-valprint.c (pascal_val_print): Remove "block".
1624         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1625         (aux_add_nonlocal_symbols): Make "block" const.
1626         (resolve_subexp): Remove cast.
1627         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1628         const.
1629         (iterate_over_file_blocks): Likewise.
1630         * f-exp.y (%union) <bval>: Remove.
1631         * coffread.c (patch_opaque_types): Make "b" const.
1632         * spu-tdep.c (spu_catch_start): Make "block" const.
1633         * c-valprint.c (print_unpacked_pointer): Remove "block".
1634         * symmisc.c (dump_symtab_1): Make "b" const.
1635         (block_depth): Make "block" const.
1636         * d-exp.y (%union) <bval>: Remove.
1637         * cp-support.h (cp_lookup_rtti_type): Update.
1638         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1639         * psymtab.c (psym_lookup_symbol): Make "block" const.
1640         (maintenance_check_psymtabs): Make "b" const.
1641         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1642         (enumerate_locals, enumerate_args): Update.
1643         * python/py-symtab.c (stpy_global_block): Make "block" const.
1644         (stpy_static_block): Likewise.
1645         * inline-frame.c (block_starting_point_at): Make "new_block"
1646         const.
1647         * block.c (find_block_in_blockvector): Make return type const.
1648         (blockvector_for_pc_sect): Make "b" const.
1649         (find_block_in_blockvector): Make "b" const.
1650
1651 2019-03-23  Tom Tromey  <tom@tromey.com>
1652
1653         * varobj.c (varobj_create): Update.
1654         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1655         * printcmd.c (display_command, do_one_display): Don't reset
1656         innermost_block.
1657         * parser-defs.h (enum innermost_block_tracker_type): Move to
1658         expression.h.
1659         (innermost_block): Update comment.
1660         * parse.c (parse_exp_1): Add tracker_types parameter.
1661         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1662         tracker_types parameter.  Reset innermost_block.
1663         (parse_exp_in_context): Remove.
1664         (parse_expression_for_completion): Update.
1665         * objfiles.c (~objfile): Don't reset expression_context_block or
1666         innermost_block.
1667         * expression.h (enum innermost_block_tracker_type): Move from
1668         parser-defs.h.
1669         (parse_exp_1): Add tracker_types parameter.
1670         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1671         reset innermost_block.
1672
1673 2019-03-23  Tom Tromey  <tom@tromey.com>
1674
1675         * objfiles.h: Include bcache.h.
1676
1677 2019-03-23  Tom Tromey  <tom@tromey.com>
1678
1679         * linespec.c (get_current_search_block): Use
1680         scoped_restore_current_language.
1681         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1682
1683 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1684             Jiong Wang  <jiong.wang@arm.com>
1685
1686         * aarch64-linux-tdep.c
1687         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1688         section.
1689         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1690
1691 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1692             Jiong Wang  <jiong.wang@arm.com>
1693
1694         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1695         instructions.
1696         (aarch64_analyze_prologue_test): Add PACIASP test.
1697         (aarch64_prologue_prev_register): Unmask PC value.
1698
1699 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1700             Jiong Wang  <jiong.wang@arm.com>
1701
1702         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1703         (aarch64_dwarf2_prev_register): Unmask PC value.
1704         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1705         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1706         DW_CFA_AARCH64_negate_ra_state.
1707         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1708
1709 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1710             Jiong Wang  <jiong.wang@arm.com>
1711
1712         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1713         registers.
1714         (aarch64_pseudo_register_name): Likewise.
1715         (aarch64_pseudo_register_type): Likewise.
1716         (aarch64_pseudo_register_reggroup_p): Likewise.
1717         (aarch64_gdbarch_init): Add pauth registers.
1718         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1719         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1720         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1721         (struct gdbarch_tdep): Add regnum for ra_state.
1722
1723 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1724             Jiong Wang  <jiong.wang@arm.com>
1725
1726         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1727
1728 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1729             Jiong Wang  <jiong.wang@arm.com>
1730
1731         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1732         function.
1733         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1734         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1735         (aarch64_gdbarch_init): Add puth registers.
1736         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1737         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1738         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1739
1740 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1741             Jiong Wang  <jiong.wang@arm.com>
1742
1743         * aarch64-linux-nat.c
1744         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1745         * aarch64-linux-tdep.c
1746         (aarch64_linux_core_read_description): Likewise.
1747         (aarch64_linux_get_hwcap): New function.
1748         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1749         (aarch64_linux_get_hwcap): New declaration.
1750
1751 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1752             Jiong Wang  <jiong.wang@arm.com>
1753
1754         * aarch64-linux-nat.c
1755         (aarch64_linux_nat_target::read_description): Add pauth param.
1756         * aarch64-linux-tdep.c
1757         (aarch64_linux_core_read_description): Likewise.
1758         * aarch64-tdep.c (struct target_desc): Add in pauth.
1759         (aarch64_read_description): Add pauth param.
1760         (aarch64_gdbarch_init): Likewise.
1761         * aarch64-tdep.h (aarch64_read_description): Likewise.
1762         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1763         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1764         * features/Makefile: Add new files.
1765         * features/aarch64-pauth.c: New file.
1766         * features/aarch64-pauth.xml: New file.
1767
1768 2019-03-20  Tom Tromey  <tromey@adacore.com>
1769
1770         * infrun.c (handle_inferior_event): Rename from
1771         handle_inferior_event_1.  Create a scoped_value_mark.
1772         (handle_inferior_event): Remove.
1773
1774 2019-03-19  Tom Tromey  <tromey@adacore.com>
1775
1776         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1777         * infrun.h (print_stop_event): Add "displays" parameter.
1778         * infrun.c (print_stop_event): Add "displays" parameter.
1779
1780 2019-03-19  Pedro Alves  <palves@redhat.com>
1781
1782         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1783         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1784         to -1.  Fix TABs vs spaces.
1785         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1786         * tui/tui-out.h (tui_ui_out) Add intro comments.
1787         <m_line, m_start_of_line>: In-class initialize, and add describing
1788         comment.
1789
1790 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1791
1792         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1793         variable names.
1794         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1795
1796 2019-03-18  Pedro Alves  <palves@redhat.com>
1797             Eli Zaretskii <eliz@gnu.org>
1798
1799         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1800         m_line and m_start_of_line.
1801
1802 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1803
1804         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1805         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1806         it returns a newline.  This fixes a regression in TU mode, whereby
1807         the next line is output on the same screen line as the user input.
1808
1809 2019-03-18  Tom Tromey  <tromey@adacore.com>
1810
1811         * minsyms.c (minimal_symbol_reader::install): Remove call to
1812         obstack_blank.
1813
1814 2019-03-18  Pedro Alves  <palves@redhat.com>
1815
1816         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1817         New globals.
1818         (apply_style): New, factored out from ...
1819         (apply_ansi_escape): ... this.  Handle reverse video mode.
1820         (tui_set_reverse_mode): New function.
1821         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1822         * tui/tui-winsource.c (tui_show_source_line): Use
1823         tui_set_reverse_mode instead of setting A_STANDOUT.
1824         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1825         New setter methods.
1826
1827 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1828
1829         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1830         Handle tabs.
1831
1832 2019-03-18  Tom Tromey  <tromey@adacore.com>
1833
1834         * ada-lang.c (empty_array): Add "high" parameter.
1835         (ada_evaluate_subexp): Update.
1836
1837 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1838
1839         * unittests/string_view-selftests.c: Define
1840         _initialize_string_view_selftests unconditionally.
1841
1842 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1843
1844         PR gdb/24350
1845         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1846
1847 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1848
1849         PR gdb/24351
1850         * windows-nat.c (display_selector): Fix format specifiers.
1851
1852 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1853
1854         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1855         tui_refill_source_window instead of tui_refresh_win, to update the
1856         current execution line.  This fixes redisplay of the current line
1857         when stepping through the code with "next" or "step".
1858
1859 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1860
1861         * source-cache.c (source_cache::get_source_lines): Call
1862         find_source_lines to initialize s->nlines.  This fixes vertical
1863         scrolling of TUI source window when the DOWN arrow is pressed.
1864
1865 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1866
1867         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1868         linux-thread-db.c (_initialize_thread_db): Likewise.
1869
1870 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1871
1872         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1873         wclrtoeol in tui_show_source_line".  This reverts changes made in
1874         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1875
1876 2019-03-15  Tom Tromey  <tom@tromey.com>
1877
1878         * symtab.h (struct minimal_symbol): Derive from
1879         general_symbol_info.
1880         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1881         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1882         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1883         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1884         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1885         (MSYMBOL_SEARCH_NAME): Update.
1886         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1887         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1888         * minsyms.c (minimal_symbol_reader::record_full): Update.
1889
1890 2019-03-15  Tom Tromey  <tom@tromey.com>
1891
1892         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1893
1894 2019-03-15  Tom Tromey  <tom@tromey.com>
1895
1896         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1897         unique_xmalloc_ptr.
1898         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1899         Update.
1900         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1901         (build_minimal_symbol_hash_tables)
1902         (minimal_symbol_reader::install): Update.
1903
1904 2019-03-15  Tom Tromey  <tom@tromey.com>
1905
1906         * symtab.c (create_demangled_names_hash): Update.
1907         (symbol_set_names): Update.
1908         * objfiles.h (struct objfile_per_bfd_storage)
1909         <demangled_names_hash>: Now an htab_up.
1910         * objfiles.c (objfile_per_bfd_storage): Simplify.
1911
1912 2019-03-15  Tom Tromey  <tom@tromey.com>
1913
1914         * objfiles.h (struct objfile_per_bfd_storage): Declare
1915         destructor.
1916         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1917         New.
1918         (get_objfile_bfd_data): Use new.  Don't initialize
1919         language_of_main.
1920         (free_objfile_per_bfd_storage): Remove.
1921         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1922
1923 2019-03-15  Tom Tromey  <tom@tromey.com>
1924
1925         * symfile.c (reread_symbols): Update.
1926         * objfiles.c (objfile::objfile): Update.
1927         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1928         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1929         comment.
1930         (minimal_symbol_reader::install): Update.
1931         (terminate_minimal_symbol_table): Remove.
1932         * jit.c (jit_object_close_impl): Update.
1933
1934 2019-03-15  Tom Tromey  <tom@tromey.com>
1935
1936         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1937         initializations.
1938
1939 2019-03-15  Tom Tromey  <tom@tromey.com>
1940
1941         * objfiles.h (struct objfile_per_bfd_storage)
1942         <demangled_hash_languages>: Now a bitset.
1943         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1944         (lookup_minimal_symbol): Update.
1945
1946 2019-03-15  Tom Tromey  <tom@tromey.com>
1947
1948         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1949         Don't return the symbol.
1950         * coffread.c (record_minimal_symbol): Use record_full.
1951
1952 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1953
1954         The MS-Windows port of ncurses fails to switch to a color pair if
1955         one or both of the colors are the implicit default colors.  This
1956         change records the default colors when TUI is initialized, and
1957         then specifies them explicitly when a color pair uses the default
1958         colors.  This allows color styling in TUI mode on MS-Windows.
1959
1960         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1961         ncurses_norm_attr.
1962         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1963         colors in ncurses_norm_attr.
1964         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1965         "none", replace it with the default color recorded in
1966         ncurses_norm_attr.
1967
1968 2019-03-14  Tom Tromey  <tromey@adacore.com>
1969
1970         * source-cache.h (class source_cache) <get_source_lines>: Return
1971         std::string.
1972         * source-cache.c (source_cache::extract_lines): Handle case where
1973         first_pos==npos.  Return std::string.
1974         (source_cache::get_source_lines): Update.
1975
1976 2019-03-14  Tom Tromey  <tromey@adacore.com>
1977
1978         * NEWS: Add item for "style sources" commands.
1979         * source-cache.c (source_cache::get_source_lines): Check
1980         source_styling.
1981         * cli/cli-style.c (source_styling): New global.
1982         (_initialize_cli_style): Add "style sources" commands.
1983         (show_style_sources): New function.
1984         * cli/cli-style.h (source_styling): Declare.
1985
1986 2019-03-14  Pedro Alves  <palves@redhat.com>
1987             Tom Tromey  <tromey@adacore.com>
1988
1989         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1990         * tui/tui-winsource.c (tui_refill_source_window): New function,
1991         from...
1992         (tui_horizontal_source_scroll): ... here.  Move some logic.
1993         * cli/cli-style.c (set_style_enabled): Notify new observable.
1994         * tui/tui-hooks.c (tui_redisplay_source): New function.
1995         (tui_attach_detach_observers): Attach or detach
1996         tui_redisplay_source.
1997         * observable.h (source_styling_changed): New observable.
1998         * observable.c: Define source_styling_changed observable.
1999
2000 2019-03-13  Tom Tromey  <tromey@adacore.com>
2001
2002         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2003         (i386_gnu_nat_target::store_registers): Update.
2004         * target-debug.h (target_debug_print_std_string): New macro.
2005         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2006         * windows-tdep.c (display_one_tib): Update.
2007         * tui/tui-stack.c (tui_make_status_line): Update.
2008         * top.c (print_inferior_quit_action): Update.
2009         * thread.c (thr_try_catch_cmd): Update.
2010         (add_thread_with_info): Update.
2011         (thread_target_id_str): Update.
2012         (thr_try_catch_cmd): Update.
2013         (thread_command): Update.
2014         (thread_find_command): Update.
2015         * record-btrace.c (record_btrace_target::info_record)
2016         (record_btrace_resume_thread, record_btrace_target::resume)
2017         (record_btrace_cancel_resume, record_btrace_step_thread)
2018         (record_btrace_target::wait, record_btrace_target::wait)
2019         (record_btrace_target::wait, record_btrace_target::stop): Update.
2020         * progspace.c (print_program_space): Update.
2021         * process-stratum-target.c
2022         (process_stratum_target::thread_address_space): Update.
2023         * linux-fork.c (linux_fork_mourn_inferior)
2024         (detach_checkpoint_command, info_checkpoints_command)
2025         (linux_fork_context): Update.
2026         (linux_fork_detach): Update.
2027         (class scoped_switch_fork_info): Update.
2028         (delete_checkpoint_command): Update.
2029         * infrun.c (follow_fork_inferior): Update.
2030         (follow_fork_inferior): Update.
2031         (proceed_after_vfork_done): Update.
2032         (handle_vfork_child_exec_or_exit): Update.
2033         (follow_exec): Update.
2034         (displaced_step_prepare_throw): Update.
2035         (displaced_step_restore): Update.
2036         (start_step_over): Update.
2037         (resume_1): Update.
2038         (clear_proceed_status_thread): Update.
2039         (proceed): Update.
2040         (print_target_wait_results): Update.
2041         (do_target_wait): Update.
2042         (context_switch): Update.
2043         (stop_all_threads): Update.
2044         (restart_threads): Update.
2045         (finish_step_over): Update.
2046         (handle_signal_stop): Update.
2047         (switch_back_to_stepped_thread): Update.
2048         (keep_going_pass_signal): Update.
2049         (print_exited_reason): Update.
2050         (normal_stop): Update.
2051         * inferior.c (inferior_pid_to_str): Change return type.
2052         (print_selected_inferior): Update.
2053         (add_inferior): Update.
2054         (detach_inferior): Update.
2055         * dummy-frame.c (fprint_dummy_frames): Update.
2056         * dcache.c (dcache_info_1): Update.
2057         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2058         (btrace_fetch, btrace_clear): Update.
2059         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2060         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2061         type.
2062         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2063         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2064         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2065         * gdbarch.c, gdbarch.h: Rebuild.
2066         * gdbarch.sh (core_pid_to_str): Change return type.
2067         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2068         return type.
2069         (windows_nat_target::pid_to_str): Change return type.
2070         (windows_delete_thread): Update.
2071         (windows_nat_target::attach): Update.
2072         (windows_nat_target::files_info): Update.
2073         * target-delegates.c: Rebuild.
2074         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2075         return type.
2076         (sol_thread_target::pid_to_str): Change return type.
2077         * remote.c (class remote_target) <pid_to_str>: Change return
2078         type.
2079         (remote_target::pid_to_str): Change return type.
2080         (extended_remote_target::attach, remote_target::remote_stop_ns)
2081         (remote_target::remote_notif_remove_queued_reply)
2082         (remote_target::push_stop_reply, remote_target::disable_btrace):
2083         Update.
2084         (extended_remote_target::attach): Update.
2085         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2086         type.
2087         (gdbsim_target::pid_to_str): Change return type.
2088         * ravenscar-thread.c (struct ravenscar_thread_target)
2089         <pid_to_str>: Change return type.
2090         (ravenscar_thread_target::pid_to_str): Change return type.
2091         * procfs.c (class procfs_target) <pid_to_str>: Change return
2092         type.
2093         (procfs_target::pid_to_str): Change return type.
2094         (procfs_target::attach): Update.
2095         (procfs_target::detach): Update.
2096         (procfs_target::fetch_registers): Update.
2097         (procfs_target::store_registers): Update.
2098         (procfs_target::wait): Update.
2099         (procfs_target::files_info): Update.
2100         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2101         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2102         return type.
2103         (nto_procfs_target::pid_to_str): Change return type.
2104         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2105         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2106         return type.
2107         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2108         (exit_lwp): Update.
2109         (attach_proc_task_lwp_callback, get_detach_signal)
2110         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2111         (linux_nat_target::resume, wait_lwp, stop_callback)
2112         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2113         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2114         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2115         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2116         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2117         type.
2118         (inf_ptrace_target::attach): Update.
2119         (inf_ptrace_target::files_info): Update.
2120         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2121         type.
2122         (go32_nat_target::pid_to_str): Change return type.
2123         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2124         (gnu_nat_target::wait): Update.
2125         (gnu_nat_target::wait): Update.
2126         (gnu_nat_target::resume): Update.
2127         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2128         (fbsd_nat_target::wait): Update.
2129         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2130         type.
2131         (darwin_nat_target::attach): Update.
2132         * corelow.c (class core_target) <pid_to_str>: Change return type.
2133         (core_target::pid_to_str): Change return type.
2134         * target.c (normal_pid_to_str): Change return type.
2135         (default_pid_to_str): Likewise.
2136         (target_pid_to_str): Change return type.
2137         (target_translate_tls_address): Update.
2138         (target_announce_detach): Update.
2139         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2140         return type.
2141         (bsd_uthread_target::pid_to_str): Change return type.
2142         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2143         type.
2144         (bsd_kvm_target::pid_to_str): Change return type.
2145         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2146         return type.
2147         (aix_thread_target::pid_to_str): Change return type.
2148         * target.h (struct target_ops) <pid_to_str>: Change return type.
2149         (target_pid_to_str, normal_pid_to_str): Likewise.
2150         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2151         type.
2152         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2153         type.
2154         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2155         return type.
2156         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2157         type.
2158         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2159         type.
2160         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2161         return type.
2162
2163 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2164
2165         * NEWS: Mention that the new default MI version is 3.  Mention
2166         changes to the output of commands and events that deal with
2167         multi-location breakpoints.
2168         * breakpoint.c: Include "mi/mi-out.h".
2169         (print_one_breakpoint): Change output syntax if using MI version
2170         >= 3.
2171         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2172         New.
2173         (mi_multi_location_breakpoint_output_fixed): New.
2174         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2175         (mi_cmd_fix_multi_location_breakpoint_output): New.
2176         (mi_multi_location_breakpoint_output_fixed): New.
2177         * mi/mi-cmds.c (mi_cmds): Register command
2178         -fix-multi-location-breakpoint-output.
2179         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2180         interpreter "mi".
2181
2182 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2183
2184         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2185         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2186         instantiate mi_ui_out based on interpreter name.
2187         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2188         * mi/mi-main.c (mi_load_progress): Likewise.
2189
2190 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2191
2192         * NEWS: Combine separate "New targets" sections for 8.3.
2193
2194 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2195
2196         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2197         (ppcfbsd_init_abi): Install gdbarch
2198         "fetch_tls_load_module_address" and "get_thread_local_address"
2199         methods.
2200
2201 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2202
2203         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2204         (riscv_fbsd_init_abi): Install gdbarch
2205         "fetch_tls_load_module_address" and "get_thread_local_address"
2206         methods.
2207
2208 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2209
2210         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2211         (i386fbsd_init_abi): Install gdbarch
2212         "fetch_tls_load_module_address" and "get_thread_local_address"
2213         methods.
2214
2215 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2216
2217         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2218         (amd64fbsd_init_abi): Install gdbarch
2219         "fetch_tls_load_module_address" and "get_thread_local_address"
2220         methods.
2221
2222 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2223
2224         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2225         (struct fbsd_pspace_data): New type.
2226         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2227         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2228         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2229         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2230         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2231
2232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2233
2234         * gdbtypes.c (lookup_struct_elt): New function.
2235         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2236         * gdbtypes.h (struct struct_elt): New type.
2237         (lookup_struct_elt): New prototype.
2238
2239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2240
2241         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2242         remove disabled code block.
2243
2244 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2245
2246         * gdbarch.sh (get_thread_local_address): New method.
2247         * gdbarch.h, gdbarch.c: Regenerate.
2248         * target.c (target_translate_tls_address): Use
2249         gdbarch_get_thread_local_address if present instead of
2250         target::get_thread_local_address.
2251
2252 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2253
2254         * target.h (target::get_thread_local_address): Update comment.
2255
2256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2257
2258         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2259         objfile->separate_debug_objfile_backlink if not NULL.
2260
2261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2262
2263         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2264         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2265         (amd64bsd_store_inferior_registers): Likewise.
2266         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2267         Enable segment base registers.
2268         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2269         PT_GETFSBASE and PT_GETGSBASE.
2270         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2271         PT_SETGSBASE.
2272         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2273         segment base registers.
2274         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2275
2276 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2277
2278         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2279         Update calls to i386_target_description to add 'segments'
2280         parameter.
2281         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2282         add segment base registers.
2283         * arch/i386.c (i386_create_target_description): Add 'segments'
2284         parameter to enable segment base registers.
2285         * arch/i386.h (i386_create_target_description): Likewise.
2286         * features/i386/32bit-segments.xml: New file.
2287         * features/i386/32bit-segments.c: Generate.
2288         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2289         call to i386_target_description to add 'segments' parameter.
2290         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2291         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2292         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2293         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2294         if feature is present.
2295         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2296         Add 'segments' parameter to call to i386_target_description.
2297         (i386_target_description): Add 'segments' parameter to enable
2298         segment base registers.
2299         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2300         to call to i386_target_description.
2301         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2302         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2303         Define I386_NUM_REGS.
2304         (i386_target_description): Add 'segments' parameter to enable
2305         segment base registers.
2306
2307 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2308
2309         PR/24325
2310         * source-cache.c: #undef open and close, to avoid unresolved
2311         externals during linking.
2312
2313 2019-03-12  Tom Tromey  <tromey@adacore.com>
2314
2315         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2316         const.  Add initializers.
2317         (_initialize_remote): Don't initialize ptid globals.
2318
2319 2019-03-12  Pedro Alves  <palves@redhat.com>
2320
2321         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2322
2323 2019-03-12  Pedro Alves  <palves@redhat.com>
2324
2325         * cp-name-parser.y (main): Remove unused 'len' variable.
2326
2327 2019-03-12  Tom Tromey  <tromey@adacore.com>
2328
2329         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2330         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2331
2332 2019-03-12  Tom Tromey  <tromey@adacore.com>
2333
2334         * linux-nat.c (iterate_over_lwps): Update.
2335         (stop_callback): Remove parameter.
2336         (stop_wait_callback, detach_callback, resume_set_callback)
2337         (select_singlestep_lwp_callback, set_ignore_sigint)
2338         (status_callback, resumed_callback, resume_clear_callback)
2339         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2340         data parameter.
2341         (linux_nat_target::detach, linux_nat_target::resume)
2342         (linux_stop_and_wait_all_lwps, select_event_lwp)
2343         (linux_nat_filter_event, linux_nat_wait_1)
2344         (linux_nat_target::kill, linux_nat_target::stop)
2345         (linux_nat_target::stop): Update.
2346         (linux_nat_resume_callback): Change type.
2347         (resume_stopped_resumed_lwps, count_events_callback)
2348         (select_event_lwp_callback): Likewise.
2349         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2350         * arm-linux-nat.c (struct update_registers_data): Remove.
2351         (update_registers_callback): Change type.
2352         (arm_linux_insert_hw_breakpoint1): Update.
2353         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2354         parameter.
2355         (x86_linux_dr_set_addr): Update.
2356         (x86_linux_dr_set_control): Update.
2357         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2358         (iterate_over_lwps): Use gdb::function_view.
2359         * nat/aarch64-linux-hw-point.c (struct
2360         aarch64_dr_update_callback_param): Remove.
2361         (debug_reg_change_callback): Change type.
2362         (aarch64_notify_debug_reg_change): Update.
2363         * s390-linux-nat.c (s390_refresh_per_info): Update.
2364
2365 2019-03-11  Tom Tromey  <tromey@adacore.com>
2366
2367         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2368         redundant assignment to "this_cu".
2369
2370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2371
2372         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2373
2374 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2375
2376         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2377         from...
2378         (rank_one_type): ... this.
2379
2380 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2381
2382         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2383         from...
2384         (rank_one_type): ... this.
2385
2386 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2387
2388         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2389         from...
2390         (rank_one_type): ... this.
2391
2392 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2393
2394         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2395         from...
2396         (rank_one_type): ... this.
2397
2398 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2399
2400         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2401         from...
2402         (rank_one_type): ... this.
2403
2404 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2405
2406         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2407         from...
2408         (rank_one_type): ... this.
2409
2410 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2411
2412         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2413         from...
2414         (rank_one_type): ... this.
2415
2416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2417
2418         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2419         from...
2420         (rank_one_type): ... this.
2421
2422 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2423
2424         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2425         from...
2426         (rank_one_type): ... this.
2427
2428 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2429
2430         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2431         from...
2432         (rank_one_type): ... this.
2433
2434 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2435
2436         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2437         from...
2438         (rank_one_type): ... this.
2439
2440 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2441
2442         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2443         from...
2444         (rank_one_type): ... this.
2445
2446 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2447
2448         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2449         inferior-events' shows the example events.
2450
2451 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2452
2453         Support styling on native MS-Windows console
2454
2455         PR/24315
2456         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2457         on MS-Windows if $TERM is not defined.
2458
2459         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2460
2461         * posix-hdep.c (gdb_console_fputs):
2462         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2463         functions.
2464         * ui-file.h (gdb_console_fputs): Add prototype.
2465
2466         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2467         back to fputs only if the former returns zero.
2468
2469 2019-03-07  Tom Tromey  <tom@tromey.com>
2470
2471         * symmisc.c (print_symbol_bcache_statistics): Update.
2472         (print_objfile_statistics): Update.
2473         * symfile.c (allocate_symtab): Update.
2474         * stabsread.c: Don't include bcache.h.
2475         * psymtab.h (struct psymbol_bcache): Don't declare.
2476         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2477         (psymbol_bcache_init, psymbol_bcache_free)
2478         (psymbol_bcache_get_bcache): Don't declare.
2479         * psymtab.c (struct psymbol_bcache): Remove.
2480         (psymtab_storage::psymtab_storage): Update.
2481         (psymtab_storage::~psymtab_storage): Update.
2482         (psymbol_bcache_init, psymbol_bcache_free)
2483         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2484         (add_psymbol_to_bcache): Update.
2485         (allocate_psymtab): Update.
2486         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2487         macro_cache>: No longer pointers.
2488         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2489         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2490         * macrotab.c (macro_bcache): Update.
2491         * macroexp.c: Don't include bcache.h.
2492         * gdbtypes.c (check_types_worklist): Update.
2493         (types_deeply_equal): Remove TRY/CATCH.  Update.
2494         * elfread.c (elf_symtab_read): Update.
2495         * dwarf2read.c: Don't include bcache.h.
2496         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2497         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2498         (print_bcache_statistics, bcache_memory_used): Don't declare.
2499         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2500         methods.  Rename all data members.
2501         * bcache.c (struct bcache): Move to bcache.h.
2502         (bcache::expand_hash_table): Rename from expand_hash_table.
2503         (bcache): Remove.
2504         (bcache::insert): Rename from bcache_full.
2505         (bcache::compare): Rename from bcache_compare.
2506         (bcache_xmalloc): Remove.
2507         (bcache::~bcache): Rename from bcache_xfree.
2508         (bcache::print_statistics): Rename from print_bcache_statistics.
2509         (bcache::memory_used): Rename from bcache_memory_used.
2510
2511 2019-03-07  Pedro Alves  <palves@redhat.com>
2512
2513         * infrun.c (normal_stop): Also check for
2514         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2515
2516 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2517
2518         * f-lang.c (value_from_host_double): Moved to...
2519         * value.c (value_from_host_double): ...here.
2520         * value.h (value_from_host_double): Declare.
2521         * guile/scm-math.c (vlscm_convert_typed_number): Use
2522         value_from_host_double.
2523         (vlscm_convert_number): Likewise.
2524         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2525         * python/py-value.c (convert_value_from_python): Likewise.
2526
2527 2019-03-06  Tom Tromey  <tom@tromey.com>
2528
2529         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2530
2531 2019-03-06  Tom Tromey  <tom@tromey.com>
2532
2533         * utils.h (free_current_contents): Don't declare.
2534         * utils.c (free_current_contents): Remove.
2535
2536 2019-03-06  Tom Tromey  <tom@tromey.com>
2537
2538         * top.c (quit_force): Update.
2539         * main.c (captured_command_loop): Update.
2540         * common/new-op.c (operator new): Update.
2541         * common/common-exceptions.c (struct catcher)
2542         <save_cleanup_chain>: Remove member.
2543         (exceptions_state_mc_init): Update.
2544         (exception_try_scope_entry): Return nullptr.
2545         (exception_try_scope_exit, exception_rethrow)
2546         (throw_exception_sjlj, throw_exception_cxx): Update.
2547         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2548         (all_cleanups, do_cleanups, discard_cleanups)
2549         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2550         (restore_cleanups, restore_final_cleanups): Don't declare.
2551         (do_final_cleanups): Remove parameter.
2552         * common/cleanups.c (cleanup_chain, make_cleanup)
2553         (make_cleanup_dtor, all_cleanups, do_cleanups)
2554         (discard_my_cleanups, discard_cleanups)
2555         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2556         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2557         (null_cleanup): Remove.
2558         (do_final_cleanups): Remove parameter.
2559
2560 2019-03-06  Tom Tromey  <tom@tromey.com>
2561
2562         * remote.c (remote_target::remote_parse_stop_reply): Use
2563         unique_xmalloc_ptr.
2564
2565 2019-03-06  Tom Tromey  <tom@tromey.com>
2566
2567         * stabsread.c (struct stabs_field_info): Rename from field_info.
2568         <list, fnlist>: Add initializers.
2569         <obstack>: New member.
2570         (read_member_functions, read_struct_fields, read_baseclasses):
2571         Allocate on obstack.  Don't use cleanups.
2572         (read_one_struct_field, read_member_functions, read_struct_fields)
2573         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2574         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2575         (read_struct_type): Update.
2576
2577 2019-03-06  Tom Tromey  <tom@tromey.com>
2578
2579         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2580         * common/filestuff.h (make_cleanup_close): Don't declare.
2581         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2582         Remove.
2583
2584 2019-03-06  Tom Tromey  <tom@tromey.com>
2585
2586         * solib-aix.c: Use make_scope_exit.
2587
2588 2019-03-06  Tom Tromey  <tom@tromey.com>
2589
2590         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2591         Use make_scope_exit.
2592
2593 2019-03-06  Tom Tromey  <tom@tromey.com>
2594
2595         * solib-svr4.c (disable_probes_interface): Remove parameter.
2596         (svr4_handle_solib_event): Use make_scope_exit.
2597
2598 2019-03-06  Tom Tromey  <tom@tromey.com>
2599
2600         * remote.c (struct stop_reply_deleter): Remove.
2601         (stop_reply_up): Update.
2602         (struct stop_reply): Derive from notif_event.  Don't typedef.
2603         <regcache>: Now a std::vector.
2604         (stop_reply_xfree): Remove.
2605         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2606         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2607         (remote_target::discard_pending_stop_replies): Use delete.
2608         (remote_target::remote_parse_stop_reply): Update.
2609         (remote_target::process_stop_reply): Update.
2610         * remote-notif.h (struct notif_event): Add virtual destructor.
2611         Remove "dtr" member.
2612         (struct notif_client) <alloc_event>: Return a unique_ptr.
2613         (notif_event_xfree): Don't declare.
2614         (notif_event_up): New typedef.
2615         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2616         (notif_event_xfree, do_notif_event_xfree): Remove.
2617         (remote_notif_state_xfree): Update.
2618
2619 2019-03-06  Tom Tromey  <tom@tromey.com>
2620
2621         * infrun.c (displaced_step_clear_cleanup): Now a
2622         forward_scope_exit type.
2623         (displaced_step_prepare_throw): Update.
2624         (displaced_step_fixup): Update.
2625
2626 2019-03-06  Tom Tromey  <tom@tromey.com>
2627
2628         * inferior.h (class inferior): Update comment.
2629         * gdbthread.h (class thread_info): Update comment.
2630
2631 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2632             Tom Tromey  <tom@tromey.com>
2633
2634         * stabsread.h (struct stab_section_list): Remove.
2635         (coffstab_build_psymtabs): Update.
2636         * dbxread.c (symbuf_sections): Now a std::vector.
2637         (sect_idx): New global.
2638         (fill_symbuf): Update.
2639         (coffstab_build_psymtabs): Change type of stabsects parameter.
2640         Update.
2641         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2642         std::vector.
2643         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2644         (coff_locate_sections): Update.
2645         (coff_symfile_read): Remove cleanups.  Update.
2646         (init_stringtab): Add storage parameter.
2647         (free_stringtab, free_stringtab_cleanup): Remove.
2648         (init_lineno): Add storage parameter.
2649         (free_linetab, free_linetab_cleanup): Remove.
2650
2651 2019-03-06  Pedro Alves  <palves@redhat.com>
2652
2653         * linux-fork.c (fork_info::clobber_regs): Delete.
2654         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2655         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2656         comment.  Adjust.
2657         (scoped_switch_fork_info::scoped_switch_fork_info)
2658         (checkpoint_command, linux_fork_context): Adjust
2659         fork_save_infrun_state calls.
2660
2661 2019-03-06  Pedro Alves  <palves@redhat.com>
2662
2663         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2664         (inf_has_multiple_threads): Return 'bool' and rewrite using
2665         inferior_info::threads().
2666
2667 2019-03-06  Pedro Alves  <palves@redhat.com>
2668
2669         * linux-fork.c: Include <list>.
2670         (fork_list): Now a std::list instance.
2671         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2672         (forks_exist_p, find_last_fork): Adjust.
2673         (new_fork): Delete.
2674         (one_fork_p): New.
2675         (add_fork): Adjust.
2676         (free_fork): Delete, folded into fork_info::~fork_info().
2677         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2678         Adjust.
2679         (init_fork_list): Delete.
2680         (linux_fork_killall, linux_fork_mourn_inferior)
2681         (linux_fork_detach, info_checkpoints_command): Adjust.
2682         (_initialize_linux_fork): No longer call init_fork_list.
2683
2684 2019-03-06  Pedro Alves  <palves@redhat.com>
2685
2686         * linux-fork.c (new_fork): New, split out of ...
2687         (add_fork): ... this.  Return void.  Move "first fork" special
2688         case from here, to ...
2689         (checkpoint_command): ... here.
2690         * linux-linux.h (add_fork): Return void.
2691
2692 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2693
2694         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2695
2696 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2697             Chris January  <chris.january@arm.com>
2698             David Lecomber  <david.lecomber@arm.com>
2699
2700         * f-exp.y: New token, UNOP_INTRINSIC.
2701         (exp): New pattern using UNOP_INTRINSIC token.
2702         (f77_keywords): Add 'abs' keyword.
2703         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2704         (value_from_host_double): New function.
2705         (evaluate_subexp_f): Support UNOP_ABS.
2706
2707 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2708
2709         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2710         types.
2711
2712 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2713
2714         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2715         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2716         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2717
2718 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2719
2720         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2721
2722 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2723             Chris January  <chris.january@arm.com>
2724
2725         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2726         * f-exp.y: Define 'KIND' token.
2727         (exp): New pattern for KIND expressions.
2728         (ptype): Handle types with a kind extension.
2729         (direct_abs_decl): Extend to spot kind extensions.
2730         (f77_keywords): Add 'kind' to the list.
2731         (push_kind_type): New function.
2732         (convert_to_kind_type): New function.
2733         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2734         * parse.c (operator_length_standard): Likewise.
2735         * parser-defs.h (enum type_pieces): Add tp_kind.
2736         * std-operator.def: Add UNOP_KIND.
2737
2738 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2739
2740         * f-exp.y (f_parse): Set yydebug.
2741
2742 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2743
2744         * f-lang.c (evaluate_subexp_f): New function.
2745         (exp_descriptor_f): New global.
2746         (f_language_defn): Use exp_descriptor_f instead of
2747         exp_descriptor_standard.
2748
2749 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2750
2751         * f-exp.y (struct token): Add comments.
2752         (dot_ops): Remove uppercase versions and the end marker.
2753         (f77_keywords): Likewise.
2754         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2755         entries in the dot_ops array are case insensitive, and use
2756         strncasecmp to compare strings.  Also some whitespace cleanup in
2757         this area.  Similar for the f77_keywords array, except entries in
2758         this list might be case sensitive.
2759
2760 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2761
2762         * f-exp.y (struct f77_boolean_val): Add comments.
2763         (boolean_values): Remove uppercase versions, and end marker.
2764         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2765         and use strncasecmp to achieve case insensitivity.  Additionally,
2766         perform whitespace cleanup around this code.
2767
2768 2019-03-06  Tom Tromey  <tromey@adacore.com>
2769
2770         * remote-sim.c (gdbsim_target_open): Use result of
2771         gdb_argv::release.
2772
2773 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2774         Dirk Schubert  <dirk.schubert@arm.com>
2775         Chris January  <chris.january@arm.com>
2776
2777         * eval.c (evaluate_subexp_standard): Call Fortran argument
2778         wrapping logic.
2779         * f-lang.c (struct value): A value which can be passed into a
2780         Fortran function call.
2781         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2782         where appropriate.
2783         (struct type): Value ready for a Fortran function call.
2784         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2785         is needed.
2786         * f-lang.h (fortran_argument_convert): Declaration.
2787         (fortran_preserve_arg_pointer): Declaration.
2788         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2789
2790 2019-03-05  Tom Tromey  <tromey@adacore.com>
2791
2792         * python/py-prettyprint.c (print_string_repr): Remove #if.
2793         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2794
2795 2019-03-05  Tom Tromey  <tromey@adacore.com>
2796
2797         * target.c (the_dummy_target): Move later.  Change type to
2798         "dummy_target".
2799         (initialize_targets): Don't initialize the_dummy_target.
2800
2801 2019-03-05  Tom Tromey  <tromey@adacore.com>
2802
2803         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2804         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2805
2806 2019-03-05  Tom Tromey  <tromey@adacore.com>
2807
2808         * windows-nat.c (windows_nat_target::attach)
2809         (windows_nat_target::detach): Don't call gdb_flush.
2810         * valprint.c (generic_val_print, val_print, val_print_string):
2811         Don't call gdb_flush.
2812         * utils.c (defaulted_query): Don't call gdb_flush.
2813         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2814         * target.c (target_announce_detach): Don't call gdb_flush.
2815         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2816         * remote.c (extended_remote_target::attach): Don't call
2817         gdb_flush.
2818         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2819         * printcmd.c (do_examine): Don't call gdb_flush.
2820         (info_display_command): Don't call gdb_flush.
2821         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2822         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2823         * memattr.c (info_mem_command): Don't call gdb_flush.
2824         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2825         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2826         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2827         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2828         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2829         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2830         (gnu_nat_target::detach): Don't call gdb_flush.
2831         * f-valprint.c (f_val_print): Don't call gdb_flush.
2832         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2833         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2834         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2835         gdb_flush.
2836         * c-valprint.c (c_val_print): Don't call gdb_flush.
2837         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2838
2839 2019-03-05  Tom Tromey  <tromey@adacore.com>
2840
2841         * varobj.c (update_dynamic_varobj_children): Update.
2842         (install_default_visualizer): Use reset, not release.
2843         * value.c (set_internalvar): Update.
2844         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2845         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2846         ATTRIBUTE_UNUSED_RESULT.
2847
2848 2019-03-05  Tom Tromey  <tromey@adacore.com>
2849
2850         * remote.c (class scoped_remote_fd) <release>: Add
2851         ATTRIBUTE_UNUSED_RESULT.
2852
2853 2019-03-05  Tom Tromey  <tromey@adacore.com>
2854
2855         * macroexp.c (struct macro_buffer) <release>: Add
2856         ATTRIBUTE_UNUSED_RESULT.
2857
2858 2019-03-05  Tom Tromey  <tromey@adacore.com>
2859
2860         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2861         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2862         ATTRIBUTE_UNUSED_RESULT.
2863
2864 2019-03-05  Tom Tromey  <tromey@adacore.com>
2865
2866         * common/scoped_fd.h (class scoped_fd) <release>: Add
2867         ATTRIBUTE_UNUSED_RESULT.
2868
2869 2019-03-05  Tom Tromey  <tromey@adacore.com>
2870
2871         * parser-defs.h (struct parser_state) <release>: Add
2872         ATTRIBUTE_UNUSED_RESULT.
2873
2874 2019-03-05  Tom Tromey  <tromey@adacore.com>
2875
2876         * utils.h (class gdb_argv) <release>: Add
2877         ATTRIBUTE_UNUSED_RESULT.
2878         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2879
2880 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2881
2882         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2883         for-loop range, to avoid compiler warnings.
2884
2885         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2886         avoid compiler warnings about unused variables.
2887
2888         * NEWS: Mention end of support for native debugging on MS-Windows
2889         before XP.
2890
2891         PR gdb/24292
2892         * common/netstuff.c:
2893         * gdbserver/gdbreplay.c
2894         * gdbserver/remote-utils.c:
2895         * ser-tcp.c:
2896         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2897         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2898         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2899         'getaddrinfo' and 'freeaddrinfo' were not available before
2900         Windows XP, and mingw.org's MinGW headers by default define
2901         _WIN32_WINNT to 0x500.
2902
2903 2019-03-01  Gary Benson <gbenson@redhat.com>
2904
2905         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2906
2907 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2908             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2909
2910         PR gdb/8527
2911         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2912         set_sigint_trap, clear_sigint_trap.
2913
2914 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2915
2916         * target.c (target_detach): Clear the regcache and the
2917         frame cache.
2918
2919 2019-02-27  Pedro Alves  <palves@redhat.com>
2920
2921         * utils.c (set_screen_size): When we cap the height/width sizes,
2922         tweak the corresponding command variable to show "unlimited":
2923
2924 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2925             Pedro Alves  <palves@redhat.com>
2926
2927         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2928         before calling rl_set_screen_size.
2929
2930 2019-02-27  Tom Tromey  <tromey@adacore.com>
2931
2932         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2933         define.
2934         * python/py-value.c: Remove Python 2.4 workaround.
2935         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2936         workaround.
2937         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2938         Python 2.4 workaround.
2939         * python/python-internal.h: Remove Python 2.4 comment.
2940         (Py_ssize_t): Don't define.
2941         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2942         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2943         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2944         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2945         * python/python.c (do_start_initialization): Remove Python 2.4
2946         workaround.
2947         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2948         (print_children): Remove Python 2.4 workaround.
2949         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2950         workaround.
2951         (CHARBUFFERPROC_NAME): Remove.
2952         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2953         Python 2.4 workaround.
2954
2955 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2956
2957         * NEWS: Note minimum Python version.
2958
2959 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2960
2961         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2962         code from these functions.  Remove corresponding ifdefs.  Use
2963         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2964         Remove gotos and target of gotos.
2965         (infpy_search_memory): Likewise.
2966
2967 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2968
2969         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2970         (hppa_gdbarch_init): Don't register deleted functions with
2971         gdbarch.
2972
2973 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2974
2975         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2976         (h8300_unwind_sp): Delete.
2977         (h8300_dummy_id): Delete.
2978         (h8300_gdbarch_init): Don't register deleted functions with
2979         gdbarch.
2980
2981 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2982
2983         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2984         (ft32_unwind_pc): Delete.
2985         (ft32_unwind_sp): Delete.
2986         (ft32_gdbarch_init): Don't register deleted functions with
2987         gdbarch.
2988
2989 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2990
2991         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2992         (frv_unwind_pc): Delete.
2993         (frv_unwind_sp): Delete.
2994         (frv_gdbarch_init): Don't register deleted functions with
2995         gdbarch.
2996
2997 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3000         (riscv_unwind_pc): Delete.
3001         (riscv_unwind_sp): Delete.
3002         (riscv_gdbarch_init): Don't register deleted functions with
3003         gdbarch.
3004
3005 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3006
3007         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3008         (csky_unwind_pc): Delete.
3009         (csky_unwind_sp): Delete.
3010         (csky_gdbarch_init): Don't register deleted functions with
3011         gdbarch.
3012
3013 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3014
3015         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3016         (cris_unwind_pc): Delete.
3017         (cris_unwind_sp): Delete.
3018         (cris_gdbarch_init): Don't register deleted functions with
3019         gdbarch.
3020
3021 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3022
3023         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3024         (bfin_unwind_pc): Delete.
3025         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3026
3027 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3028
3029         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3030         (arm_unwind_pc): Delete.
3031         (arm_unwind_sp): Delete.
3032         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3033
3034 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3037         (arc_unwind_pc): Delete.
3038         (arc_unwind_sp): Delete.
3039         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3040
3041 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3042
3043         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3044         (alpha_unwind_pc): Delete.
3045         (alpha_gdbarch_init): Don't register deleted functions with
3046         gdbarch.
3047
3048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3049
3050         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3051         (aarch64_unwind_pc): Delete.
3052         (aarch64_unwind_sp): Delete.
3053         (aarch64_gdbarch_init): Don't register deleted functions with
3054         gdbarch.
3055
3056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3057
3058         * gdbtypes.c (type_align): Don't consider static members when
3059         computing structure alignment.
3060
3061 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3062
3063         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3064         return 0 for other types.
3065         * arch-utils.c (default_type_align): Always return 0.
3066         * gdbarch.h: Regenerate.
3067         * gdbarch.sh (type_align): Extend comment.
3068         * gdbtypes.c (type_align): Add additional comments, always call
3069         gdbarch_type_align before applying the default rules.
3070         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3071         generic code will then apply a suitable default.
3072         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3073         types, return 0 for other types.
3074
3075 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3076
3077         * NEWS: Create a new section for the next release branch.
3078         Rename the section of the current branch, now that it has
3079         been cut.
3080
3081 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3082
3083         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3084         * version.in: Bump version to 8.3.50.DATE-git.
3085
3086 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3087
3088         * aix-thread.c (ptid_cmp): Remove unused variable.
3089         (get_signaled_thread): Likewise.
3090         (store_regs_user_thread): Likewise.
3091         (store_regs_kernel_thread): Likewise.
3092         (fetch_regs_kernel_thread): Remove shadowed variable.
3093
3094 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3095
3096         * features/riscv/32bit-cpu.xml: Add register numbers.
3097         * features/riscv/32bit-fpu.c: Regenerate.
3098         * features/riscv/32bit-fpu.xml: Add register numbers.
3099         * features/riscv/64bit-cpu.xml: Add register numbers.
3100         * features/riscv/64bit-fpu.c: Regenerate.
3101         * features/riscv/64bit-fpu.xml: Add register numbers.
3102
3103 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3104
3105         * NEWS: Mention two argument form of gdb.Value constructor.
3106         * python/py-value.c (convert_buffer_and_type_to_value): New
3107         function.
3108         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3109         Add support for handling an optional second argument.  Call
3110         convert_buffer_and_type_to_value as appropriate.
3111         * python/python-internal.h (Py_buffer_deleter): New struct.
3112         (Py_buffer_up): New typedef.
3113
3114 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3115
3116         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3117         instead of releasing ownership.
3118
3119 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3120
3121         * dwarf2read.c (open_and_init_dwp_file): Call
3122         elf_numsections instead of bfd_count_sections to initialize
3123         dwp_file->num_sections.
3124
3125 2019-02-25  Tom Tromey  <tromey@adacore.com>
3126
3127         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3128
3129 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3130
3131         * gcore.in: Add '--readnever' option when invoking GDB.
3132
3133 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3134
3135         * MAINTAINERS: Update my email address.
3136
3137 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3138
3139         * build-id.c (build_id_to_debug_bfd_1): New function.
3140         (build_id_to_debug_bfd): Look for separate debug file in
3141         sysroot.
3142
3143 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * gdbarch.sh: Update the copyright year range that is placed into
3146         generated files.
3147
3148 2019-02-22  Keith Seitz  <keiths@redhat.com>
3149
3150         PR symtab/23853
3151         * linespec.c (create_sals_line_offset): Search for the default
3152         symtab's filename instead of its fullname.
3153
3154 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3155
3156         * NEWS: Update style defaults.
3157
3158 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3159
3160         * main.c (captured_main_1): Disable styling in batch mode.
3161
3162 2019-02-20  Tom Tromey  <tom@tromey.com>
3163
3164         * symtab.c (symtab_symbol_info): Fix typos.
3165
3166 2019-02-20  Tom Tromey  <tromey@adacore.com>
3167
3168         * findcmd.c (_initialize_mem_search): Use upper case for
3169         metasyntactic variables.
3170
3171 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3172
3173         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3174         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3175
3176 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3177
3178         * top.h (source_file_name): Change to std::string.
3179         * top.c (source_file_name): Likewise.
3180         (command_line_input): Adjust.
3181         * cli/cli-script.c (script_from_file): Adjust.
3182
3183 2019-02-19  Tom Tromey  <tromey@adacore.com>
3184
3185         * ravenscar-thread.c
3186         (ravenscar_thread_target::update_thread_list): Don't call
3187         ada_build_task_list.
3188         * ada-lang.h (ada_build_task_list): Don't declare.
3189         * ada-tasks.c (struct ada_tasks_inferior_data)
3190         <task_list_valid_p>: Now bool.
3191         (read_known_tasks, ada_task_list_changed)
3192         (ada_tasks_invalidate_inferior_data): Update.
3193         (read_known_tasks_array): Return bool.
3194         (read_known_tasks_list): Likewise.
3195         (read_known_tasks): Return void.
3196         (ada_build_task_list): Now static.
3197
3198 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3199
3200         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3201         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3202
3203 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3204
3205         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3206         variant for ada_tasks_pspace_data_handle and
3207         ada_tasks_inferior_data_handle.
3208         (ada_tasks_pspace_data_cleanup): New function.
3209         (ada_tasks_inferior_data_cleanup): New function.
3210
3211 2019-02-17  Tom Tromey  <tom@tromey.com>
3212
3213         * macrotab.h (macro_source_fullname): Return a std::string.
3214         * macrotab.c (macro_include, check_for_redefinition)
3215         (macro_undef, macro_lookup_definition, foreach_macro)
3216         (foreach_macro_in_scope): Update.
3217         (macro_source_fullname): Return a std::string.
3218         * macrocmd.c (show_pp_source_pos): Update.
3219
3220 2019-02-17  Tom Tromey  <tom@tromey.com>
3221
3222         * macrocmd.c (show_pp_source_pos): Style the file names.
3223
3224 2019-02-17  Tom Tromey  <tom@tromey.com>
3225
3226         PR tui/24197:
3227         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3228
3229 2019-02-17  Tom Tromey  <tom@tromey.com>
3230
3231         * ada-lang.c (user_select_syms): Use filtered printing.
3232         * utils.c (wrap_style): New global.
3233         (desired_style): Remove.
3234         (emit_style_escape): Add stream parameter.
3235         (set_output_style, reset_terminal_style, prompt_for_continue):
3236         Update.
3237         (flush_wrap_buffer): Only flush gdb_stdout.
3238         (wrap_here): Set wrap_style.
3239         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3240         treat escape sequences as a character.  Change when wrap buffer is
3241         flushed.
3242         (fputs_styled): Do not set the output style when the default is
3243         requested.
3244         * ui-style.h (struct ui_file_style) <is_default>: New method.
3245         * source.c (print_source_lines_base): Emit escape sequences in one
3246         piece.
3247
3248 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3249
3250         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3251         integers and enumeration types.
3252
3253 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3254
3255         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3256         instead of lookup_symbol_in_language
3257         (do_exact_match): New function.
3258         (ada_get_symbol_name_matcher): Return do_exact_match when
3259         doing a verbatim match.
3260
3261 2019-02-15  Tom Tromey  <tromey@adacore.com>
3262
3263         * ravenscar-thread.c (ravenscar_thread_target::resume)
3264         (ravenscar_thread_target::wait): Special case wildcard requests.
3265
3266 2019-02-15  Tom Tromey  <tromey@adacore.com>
3267
3268         * ravenscar-thread.c (base_ptid): Remove.
3269         (struct ravenscar_thread_target) <close>: New method.
3270         <m_base_ptid>: New member.
3271         <update_inferior_ptid, active_task, task_is_currently_active,
3272         runtime_initialized>: Declare methods.
3273         <ravenscar_thread_target>: Add constructor.
3274         (ravenscar_thread_target::task_is_currently_active)
3275         (ravenscar_thread_target::update_inferior_ptid)
3276         (ravenscar_runtime_initialized): Rename.  Now methods.
3277         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3278         (ravenscar_thread_target::update_thread_list): Update.
3279         (ravenscar_thread_target::active_task): Now method.
3280         (ravenscar_thread_target::store_registers)
3281         (ravenscar_thread_target::prepare_to_store)
3282         (ravenscar_thread_target::prepare_to_store)
3283         (ravenscar_thread_target::mourn_inferior): Update.
3284         (ravenscar_inferior_created): Use "new" to create target.
3285         (ravenscar_thread_target::get_ada_task_ptid): Update.
3286         (_initialize_ravenscar): Don't initialize base_ptid.
3287         (ravenscar_ops): Remove global.
3288
3289 2019-02-15  Tom Tromey  <tromey@adacore.com>
3290
3291         * target.h (push_target): Declare new overload.
3292         * target.c (push_target): New overload, taking an rvalue reference.
3293         * remote.c (remote_target::open_1): Use push_target overload.
3294         * corelow.c (core_target_open): Use push_target overload.
3295
3296 2019-02-15  Tom Tromey  <tromey@adacore.com>
3297
3298         * ravenscar-thread.c (is_ravenscar_task)
3299         (ravenscar_task_is_currently_active): Return bool.
3300         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3301         (_initialize_ravenscar): Remove "(void)".
3302         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3303         Return bool.
3304
3305 2019-02-15  Tom Tromey  <tromey@adacore.com>
3306
3307         * ravenscar-thread.c (ravenscar_runtime_initializer)
3308         (has_ravenscar_runtime, get_running_thread_id)
3309         (ravenscar_thread_target::resume): Fix indentation.
3310
3311 2019-02-15  Tom Tromey  <tromey@adacore.com>
3312
3313         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3314         from ravenscar_arch_ops.
3315         (sparc_ravenscar_ops::fetch_registers)
3316         (sparc_ravenscar_ops::store_registers): Now methods.
3317         (sparc_ravenscar_prepare_to_store): Remove.
3318         (sparc_ravenscar_ops): Redefine.
3319         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3320         methods and destructor.  Remove members.
3321         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3322         (ravenscar_thread_target::store_registers)
3323         (ravenscar_thread_target::prepare_to_store): Update.
3324         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3325         Remove.
3326         (struct ppc_ravenscar_powerpc_ops): Derive from
3327         ravenscar_arch_ops.
3328         (ppc_ravenscar_powerpc_ops::fetch_registers)
3329         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3330         (ppc_ravenscar_powerpc_ops): Redefine.
3331         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3332         (ppc_ravenscar_e500_ops::fetch_registers)
3333         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3334         (ppc_ravenscar_e500_ops): Redefine.
3335         * aarch64-ravenscar-thread.c
3336         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3337         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3338         (aarch64_ravenscar_fetch_registers)
3339         (aarch64_ravenscar_store_registers): Now methods.
3340         (aarch64_ravenscar_ops): Redefine.
3341
3342 2019-02-15  Tom Tromey  <tromey@adacore.com>
3343
3344         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3345         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3346         (ravenscar_thread_target::stopped_by_watchpoint)
3347         (ravenscar_thread_target::stopped_data_address)
3348         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3349
3350 2019-02-15  Tom Tromey  <tromey@adacore.com>
3351
3352         * ravenscar-thread.c: Fix some typos.
3353
3354 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3355             Tom Tromey  <tromey@adacore.com>
3356
3357         * ada-lang.c (ada_exception_sal): Change addr_string to a
3358         std::string.
3359         (create_ada_exception_catchpoint): Update.
3360
3361 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3362             Tom Tromey  <tromey@adacore.com>
3363
3364         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3365         (bp_location_ops): Remove.
3366         (base_breakpoint_allocate_location): Update.
3367         (free_bp_location): Update.
3368         * ada-lang.c (class ada_catchpoint_location)
3369         <ada_catchpoint_location>: Remove ops parameter.
3370         (ada_catchpoint_location_dtor): Remove.
3371         (ada_catchpoint_location_ops): Remove.
3372         (allocate_location_exception): Update.
3373         * breakpoint.h (struct bp_location_ops): Remove.
3374         (class bp_location) <bp_location>: Remove bp_location_ops
3375         parameter.
3376         <~bp_location>: Add destructor.
3377         <ops>: Remove.
3378
3379 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3380             Pedro Alves  <palves@redhat.com>
3381
3382         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3383         'PATH_MAX'.
3384
3385 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3386             Samuel Thibault  <samuel.thibault@gnu.org>
3387             Thomas Schwinge  <thomas@codesourcery.com>
3388
3389         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3390         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3391
3392 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3393
3394         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3395         (check_empty): Use "const char *".
3396
3397         * gnu-nat.c (gnu_nat_target::detach): Instead of
3398         'detach_inferior (pid)' call
3399         'detach_inferior (find_inferior_pid (pid))'.
3400
3401         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3402         'nat/fork-inferior.o'.
3403         * gnu-nat.c: #include "nat/fork-inferior.h".
3404
3405         * gnu-nat.c (gnu_nat_target::detach): Instead of
3406         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3407         * gnu-nat.h: #include "inf-child.h".
3408         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3409         'i386_gnu_nat_target::fetch_registers'.
3410         (gnu_store_registers): Rename/move to
3411         'i386_gnu_nat_target::store_registers'.
3412
3413         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3414         * gnu-nat.h (mach_thread_info): New function.
3415         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3416
3417         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3418
3419 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3420
3421         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3422
3423 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3424
3425         * windows-nat.c (windows_add_thread): Add new parameter
3426         "main_thread_p" with default value set to false.  Update
3427         function documentation as well as all callers.
3428         (windows_delete_thread): Likewise.
3429         (fake_create_process): Update call to windows_add_thread.
3430         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3431         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3432         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3433         call to windows_delete_thread.
3434
3435 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3436
3437         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3438
3439 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3440
3441         * symfile.c (find_separate_debug_file): Use canonical path of
3442         sysroot with child_path instead of gdb_sysroot if it is valid.
3443
3444 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3445
3446         * symfile.c (find_separate_debug_file): Use child_path to
3447         determine if an object file is under a sysroot.
3448
3449 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3450
3451         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3452         unittests/child-path-selftests.c.
3453         * common/pathstuff.c (child_path): New function.
3454         * common/pathstuff.h (child_path): New prototype.
3455         * unittests/child-path-selftests.c: New file.
3456
3457 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3458
3459         * symfile.c (find_separate_debug_file): Look for separate debug
3460         files in debug directories under the sysroot.
3461
3462 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3463
3464         * symtab.h (struct minimal_symbol data_p): New const method.
3465         (struct minimal_symbol text_p): Likewise.
3466         * symtab.c (output_source_filename): Use file name style
3467         to print file name.
3468         (print_symbol_info): Likewise.
3469         (print_msymbol_info): Use address style to print addresses.
3470         Use function name style to print executable text symbols.
3471         (expand_symtab_containing_pc): Use data_p.
3472         (find_pc_sect_compunit_symtab): Likewise.
3473
3474 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3475
3476         * breakpoint.c (describe_other_breakpoints): Use address style
3477         to print addresses.
3478         (say_where): Likewise.
3479
3480 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3481
3482         * ada-typeprint.c (print_func_type): Print function name
3483         style to print function name.
3484         * c-typeprint.c (c_print_type_1): Likewise.
3485
3486 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3487
3488         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3489         for execve.
3490
3491 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3492
3493         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3494         type_stack.
3495
3496 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3497
3498         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3499         TYPE_CODE_REF types.
3500
3501 2019-02-08  Jim Wilson  <jimw@sifive.com>
3502
3503         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3504         (riscv_linux_fregset): New.
3505         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3506
3507 2019-02-07  Tom Tromey  <tom@tromey.com>
3508
3509         * thread.c (thread_cancel_execution_command): Update.
3510         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3511         methods.
3512         (struct thread_fsm_ops): Remove.
3513         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3514         (thread_fsm_should_stop, thread_fsm_return_value)
3515         (thread_fsm_set_finished, thread_fsm_finished_p)
3516         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3517         Don't declare.
3518         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3519         * infrun.c (clear_proceed_status_thread)
3520         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3521         (print_stop_event): Update.
3522         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3523         Add constructor.
3524         (step_command_fsm_ops): Remove.
3525         (new_step_command_fsm): Remove.
3526         (step_1): Update.
3527         (step_command_fsm::should_stop): Rename from
3528         step_command_fsm_should_stop.
3529         (step_command_fsm::clean_up): Rename from
3530         step_command_fsm_clean_up.
3531         (step_command_fsm::do_async_reply_reason): Rename from
3532         step_command_fsm_async_reply_reason.
3533         (struct until_next_fsm): Inherit from thread_fsm.  Add
3534         constructor.
3535         (until_next_fsm_ops): Remove.
3536         (new_until_next_fsm): Remove.
3537         (until_next_fsm::should_stop): Rename from
3538         until_next_fsm_should_stop.
3539         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3540         (until_next_fsm::do_async_reply_reason): Rename from
3541         until_next_fsm_async_reply_reason.
3542         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3543         constructor.  Change type of breakpoint.
3544         (finish_command_fsm_ops): Remove.
3545         (new_finish_command_fsm): Remove.
3546         (finish_command_fsm::should_stop): Rename from
3547         finish_command_fsm_should_stop.
3548         (finish_command_fsm::clean_up): Rename from
3549         finish_command_fsm_clean_up.
3550         (finish_command_fsm::return_value): Rename from
3551         finish_command_fsm_return_value.
3552         (finish_command_fsm::do_async_reply_reason): Rename from
3553         finish_command_fsm_async_reply_reason.
3554         (finish_command): Update.
3555         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3556         Add constructor.
3557         (call_thread_fsm_ops): Remove.
3558         (call_thread_fsm::call_thread_fsm): Rename from
3559         new_call_thread_fsm.
3560         (call_thread_fsm::should_stop): Rename from
3561         call_thread_fsm_should_stop.
3562         (call_thread_fsm::should_notify_stop): Rename from
3563         call_thread_fsm_should_notify_stop.
3564         (run_inferior_call, call_function_by_hand_dummy): Update.
3565         * cli/cli-interp.c (should_print_stop_to_console): Update.
3566         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3567         Add constructor.  Change type of location_breakpoint,
3568         caller_breakpoint.
3569         (until_break_fsm_ops): Remove.
3570         (new_until_break_fsm): Remove.
3571         (until_break_fsm::should_stop): Rename from
3572         until_break_fsm_should_stop.
3573         (until_break_fsm::clean_up): Rename from
3574         until_break_fsm_clean_up.
3575         (until_break_fsm::do_async_reply_reason): Rename from
3576         until_break_fsm_async_reply_reason.
3577         (until_break_command): Update.
3578         * thread-fsm.c: Remove.
3579         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3580
3581 2019-02-07  Tom Tromey  <tom@tromey.com>
3582
3583         * yy-remap.h: Add include guard.
3584         * xtensa-tdep.h: Add include guard.
3585         * xcoffread.h: Rename include guard.
3586         * varobj-iter.h: Add include guard.
3587         * tui/tui.h: Rename include guard.
3588         * tui/tui-winsource.h: Rename include guard.
3589         * tui/tui-wingeneral.h: Rename include guard.
3590         * tui/tui-windata.h: Rename include guard.
3591         * tui/tui-win.h: Rename include guard.
3592         * tui/tui-stack.h: Rename include guard.
3593         * tui/tui-source.h: Rename include guard.
3594         * tui/tui-regs.h: Rename include guard.
3595         * tui/tui-out.h: Rename include guard.
3596         * tui/tui-layout.h: Rename include guard.
3597         * tui/tui-io.h: Rename include guard.
3598         * tui/tui-hooks.h: Rename include guard.
3599         * tui/tui-file.h: Rename include guard.
3600         * tui/tui-disasm.h: Rename include guard.
3601         * tui/tui-data.h: Rename include guard.
3602         * tui/tui-command.h: Rename include guard.
3603         * tic6x-tdep.h: Add include guard.
3604         * target/waitstatus.h: Rename include guard.
3605         * target/wait.h: Rename include guard.
3606         * target/target.h: Rename include guard.
3607         * target/resume.h: Rename include guard.
3608         * target-float.h: Rename include guard.
3609         * stabsread.h: Add include guard.
3610         * rs6000-tdep.h: Add include guard.
3611         * riscv-fbsd-tdep.h: Add include guard.
3612         * regformats/regdef.h: Rename include guard.
3613         * record.h: Rename include guard.
3614         * python/python.h: Rename include guard.
3615         * python/python-internal.h: Rename include guard.
3616         * python/py-stopevent.h: Rename include guard.
3617         * python/py-ref.h: Rename include guard.
3618         * python/py-record.h: Rename include guard.
3619         * python/py-record-full.h: Rename include guard.
3620         * python/py-record-btrace.h: Rename include guard.
3621         * python/py-instruction.h: Rename include guard.
3622         * python/py-events.h: Rename include guard.
3623         * python/py-event.h: Rename include guard.
3624         * procfs.h: Add include guard.
3625         * proc-utils.h: Add include guard.
3626         * p-lang.h: Add include guard.
3627         * or1k-tdep.h: Rename include guard.
3628         * observable.h: Rename include guard.
3629         * nto-tdep.h: Rename include guard.
3630         * nat/x86-linux.h: Rename include guard.
3631         * nat/x86-linux-dregs.h: Rename include guard.
3632         * nat/x86-gcc-cpuid.h: Add include guard.
3633         * nat/x86-dregs.h: Rename include guard.
3634         * nat/x86-cpuid.h: Rename include guard.
3635         * nat/ppc-linux.h: Rename include guard.
3636         * nat/mips-linux-watch.h: Rename include guard.
3637         * nat/linux-waitpid.h: Rename include guard.
3638         * nat/linux-ptrace.h: Rename include guard.
3639         * nat/linux-procfs.h: Rename include guard.
3640         * nat/linux-osdata.h: Rename include guard.
3641         * nat/linux-nat.h: Rename include guard.
3642         * nat/linux-namespaces.h: Rename include guard.
3643         * nat/linux-btrace.h: Rename include guard.
3644         * nat/glibc_thread_db.h: Rename include guard.
3645         * nat/gdb_thread_db.h: Rename include guard.
3646         * nat/gdb_ptrace.h: Rename include guard.
3647         * nat/fork-inferior.h: Rename include guard.
3648         * nat/amd64-linux-siginfo.h: Rename include guard.
3649         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3650         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3651         * nat/aarch64-linux.h: Rename include guard.
3652         * nat/aarch64-linux-hw-point.h: Rename include guard.
3653         * mn10300-tdep.h: Add include guard.
3654         * mips-linux-tdep.h: Add include guard.
3655         * mi/mi-parse.h: Rename include guard.
3656         * mi/mi-out.h: Rename include guard.
3657         * mi/mi-main.h: Rename include guard.
3658         * mi/mi-interp.h: Rename include guard.
3659         * mi/mi-getopt.h: Rename include guard.
3660         * mi/mi-console.h: Rename include guard.
3661         * mi/mi-common.h: Rename include guard.
3662         * mi/mi-cmds.h: Rename include guard.
3663         * mi/mi-cmd-break.h: Rename include guard.
3664         * m2-lang.h: Add include guard.
3665         * location.h: Rename include guard.
3666         * linux-record.h: Rename include guard.
3667         * linux-nat.h: Add include guard.
3668         * linux-fork.h: Add include guard.
3669         * i386-darwin-tdep.h: Rename include guard.
3670         * hppa-linux-offsets.h: Add include guard.
3671         * guile/guile.h: Rename include guard.
3672         * guile/guile-internal.h: Rename include guard.
3673         * gnu-nat.h: Rename include guard.
3674         * gdb-stabs.h: Rename include guard.
3675         * frv-tdep.h: Add include guard.
3676         * f-lang.h: Add include guard.
3677         * event-loop.h: Add include guard.
3678         * darwin-nat.h: Rename include guard.
3679         * cp-abi.h: Rename include guard.
3680         * config/sparc/nm-sol2.h: Rename include guard.
3681         * config/nm-nto.h: Rename include guard.
3682         * config/nm-linux.h: Add include guard.
3683         * config/i386/nm-i386gnu.h: Rename include guard.
3684         * config/djgpp/nl_types.h: Rename include guard.
3685         * config/djgpp/langinfo.h: Rename include guard.
3686         * compile/gcc-cp-plugin.h: Add include guard.
3687         * compile/gcc-c-plugin.h: Add include guard.
3688         * compile/compile.h: Rename include guard.
3689         * compile/compile-object-run.h: Rename include guard.
3690         * compile/compile-object-load.h: Rename include guard.
3691         * compile/compile-internal.h: Rename include guard.
3692         * compile/compile-cplus.h: Rename include guard.
3693         * compile/compile-c.h: Rename include guard.
3694         * common/xml-utils.h: Rename include guard.
3695         * common/x86-xstate.h: Rename include guard.
3696         * common/version.h: Rename include guard.
3697         * common/vec.h: Rename include guard.
3698         * common/tdesc.h: Rename include guard.
3699         * common/selftest.h: Rename include guard.
3700         * common/scoped_restore.h: Rename include guard.
3701         * common/scoped_mmap.h: Rename include guard.
3702         * common/scoped_fd.h: Rename include guard.
3703         * common/safe-iterator.h: Rename include guard.
3704         * common/run-time-clock.h: Rename include guard.
3705         * common/refcounted-object.h: Rename include guard.
3706         * common/queue.h: Rename include guard.
3707         * common/ptid.h: Rename include guard.
3708         * common/print-utils.h: Rename include guard.
3709         * common/preprocessor.h: Rename include guard.
3710         * common/pathstuff.h: Rename include guard.
3711         * common/observable.h: Rename include guard.
3712         * common/netstuff.h: Rename include guard.
3713         * common/job-control.h: Rename include guard.
3714         * common/host-defs.h: Rename include guard.
3715         * common/gdb_wait.h: Rename include guard.
3716         * common/gdb_vecs.h: Rename include guard.
3717         * common/gdb_unlinker.h: Rename include guard.
3718         * common/gdb_unique_ptr.h: Rename include guard.
3719         * common/gdb_tilde_expand.h: Rename include guard.
3720         * common/gdb_sys_time.h: Rename include guard.
3721         * common/gdb_string_view.h: Rename include guard.
3722         * common/gdb_splay_tree.h: Rename include guard.
3723         * common/gdb_setjmp.h: Rename include guard.
3724         * common/gdb_ref_ptr.h: Rename include guard.
3725         * common/gdb_optional.h: Rename include guard.
3726         * common/gdb_locale.h: Rename include guard.
3727         * common/gdb_assert.h: Rename include guard.
3728         * common/filtered-iterator.h: Rename include guard.
3729         * common/filestuff.h: Rename include guard.
3730         * common/fileio.h: Rename include guard.
3731         * common/environ.h: Rename include guard.
3732         * common/common-utils.h: Rename include guard.
3733         * common/common-types.h: Rename include guard.
3734         * common/common-regcache.h: Rename include guard.
3735         * common/common-inferior.h: Rename include guard.
3736         * common/common-gdbthread.h: Rename include guard.
3737         * common/common-exceptions.h: Rename include guard.
3738         * common/common-defs.h: Rename include guard.
3739         * common/common-debug.h: Rename include guard.
3740         * common/cleanups.h: Rename include guard.
3741         * common/buffer.h: Rename include guard.
3742         * common/btrace-common.h: Rename include guard.
3743         * common/break-common.h: Rename include guard.
3744         * cli/cli-utils.h: Rename include guard.
3745         * cli/cli-style.h: Rename include guard.
3746         * cli/cli-setshow.h: Rename include guard.
3747         * cli/cli-script.h: Rename include guard.
3748         * cli/cli-interp.h: Rename include guard.
3749         * cli/cli-decode.h: Rename include guard.
3750         * cli/cli-cmds.h: Rename include guard.
3751         * charset-list.h: Add include guard.
3752         * buildsym-legacy.h: Rename include guard.
3753         * bfin-tdep.h: Add include guard.
3754         * ax.h: Rename include guard.
3755         * arm-linux-tdep.h: Add include guard.
3756         * arm-fbsd-tdep.h: Add include guard.
3757         * arch/xtensa.h: Rename include guard.
3758         * arch/tic6x.h: Add include guard.
3759         * arch/i386.h: Add include guard.
3760         * arch/arm.h: Rename include guard.
3761         * arch/arm-linux.h: Rename include guard.
3762         * arch/arm-get-next-pcs.h: Rename include guard.
3763         * arch/amd64.h: Add include guard.
3764         * arch/aarch64-insn.h: Rename include guard.
3765         * arch-utils.h: Rename include guard.
3766         * annotate.h: Add include guard.
3767         * amd64-darwin-tdep.h: Rename include guard.
3768         * aarch64-linux-tdep.h: Add include guard.
3769         * aarch64-fbsd-tdep.h: Add include guard.
3770         * aarch32-linux-nat.h: Add include guard.
3771
3772 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3773
3774         * macrotab.c (macro_define_internal): New function that
3775         factorizes macro_define_object_internal and macro_define_function
3776         code.
3777         (macro_define_object_internal): Use macro_define_internal.
3778         (macro_define_function): Likewise.
3779
3780 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3781
3782         * macrocmd.c (extract_identifier): Return
3783         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3784         callers.
3785
3786 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3787
3788         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3789
3790 2019-02-05  Tom Tromey  <tom@tromey.com>
3791
3792         * target.c (target_stack::unpush): Move assertion earlier.
3793
3794 2019-01-30  Tom Tromey  <tom@tromey.com>
3795
3796         PR python/23615:
3797         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3798         (gdbpy_parse_and_eval): Likewise.
3799         * python/python-internal.h (gdbpy_allow_threads): New class.
3800
3801 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3802
3803         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3804         (aarch64_fbsd_fpregmap): Move earlier.
3805         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3806         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3807         instead of individual calls to trad_frame_set_reg_addr.
3808         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3809         earlier.
3810         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3811         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3812         instead of individual calls to trad_frame_set_reg_addr.
3813
3814 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3815
3816         * CONTRIBUTE: Replace contribution list with wiki link.
3817
3818 2019-01-25  Tom Tromey  <tom@tromey.com>
3819
3820         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3821
3822 2019-01-25  Tom Tromey  <tom@tromey.com>
3823
3824         * xtensa-linux-nat.c: Fix common/ includes.
3825         * xml-support.h: Fix common/ includes.
3826         * xml-support.c: Fix common/ includes.
3827         * x86-linux-nat.c: Fix common/ includes.
3828         * windows-nat.c: Fix common/ includes.
3829         * varobj.h: Fix common/ includes.
3830         * varobj.c: Fix common/ includes.
3831         * value.c: Fix common/ includes.
3832         * valops.c: Fix common/ includes.
3833         * utils.c: Fix common/ includes.
3834         * unittests/xml-utils-selftests.c: Fix common/ includes.
3835         * unittests/utils-selftests.c: Fix common/ includes.
3836         * unittests/unpack-selftests.c: Fix common/ includes.
3837         * unittests/tracepoint-selftests.c: Fix common/ includes.
3838         * unittests/style-selftests.c: Fix common/ includes.
3839         * unittests/string_view-selftests.c: Fix common/ includes.
3840         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3841         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3842         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3843         * unittests/rsp-low-selftests.c: Fix common/ includes.
3844         * unittests/parse-connection-spec-selftests.c: Fix common/
3845         includes.
3846         * unittests/optional-selftests.c: Fix common/ includes.
3847         * unittests/offset-type-selftests.c: Fix common/ includes.
3848         * unittests/observable-selftests.c: Fix common/ includes.
3849         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3850         * unittests/memrange-selftests.c: Fix common/ includes.
3851         * unittests/memory-map-selftests.c: Fix common/ includes.
3852         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3853         * unittests/function-view-selftests.c: Fix common/ includes.
3854         * unittests/environ-selftests.c: Fix common/ includes.
3855         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3856         * unittests/common-utils-selftests.c: Fix common/ includes.
3857         * unittests/cli-utils-selftests.c: Fix common/ includes.
3858         * unittests/array-view-selftests.c: Fix common/ includes.
3859         * ui-file.c: Fix common/ includes.
3860         * tui/tui-io.c: Fix common/ includes.
3861         * tracepoint.h: Fix common/ includes.
3862         * tracepoint.c: Fix common/ includes.
3863         * tracefile-tfile.c: Fix common/ includes.
3864         * top.h: Fix common/ includes.
3865         * top.c: Fix common/ includes.
3866         * thread.c: Fix common/ includes.
3867         * target/waitstatus.h: Fix common/ includes.
3868         * target/waitstatus.c: Fix common/ includes.
3869         * target.h: Fix common/ includes.
3870         * target.c: Fix common/ includes.
3871         * target-memory.c: Fix common/ includes.
3872         * target-descriptions.c: Fix common/ includes.
3873         * symtab.h: Fix common/ includes.
3874         * symfile.c: Fix common/ includes.
3875         * stap-probe.c: Fix common/ includes.
3876         * spu-linux-nat.c: Fix common/ includes.
3877         * sparc-nat.c: Fix common/ includes.
3878         * source.c: Fix common/ includes.
3879         * solib.c: Fix common/ includes.
3880         * solib-target.c: Fix common/ includes.
3881         * ser-unix.c: Fix common/ includes.
3882         * ser-tcp.c: Fix common/ includes.
3883         * ser-pipe.c: Fix common/ includes.
3884         * ser-base.c: Fix common/ includes.
3885         * selftest-arch.c: Fix common/ includes.
3886         * s12z-tdep.c: Fix common/ includes.
3887         * rust-exp.y: Fix common/ includes.
3888         * rs6000-aix-tdep.c: Fix common/ includes.
3889         * riscv-tdep.c: Fix common/ includes.
3890         * remote.c: Fix common/ includes.
3891         * remote-notif.h: Fix common/ includes.
3892         * remote-fileio.h: Fix common/ includes.
3893         * remote-fileio.c: Fix common/ includes.
3894         * regcache.h: Fix common/ includes.
3895         * regcache.c: Fix common/ includes.
3896         * record-btrace.c: Fix common/ includes.
3897         * python/python.c: Fix common/ includes.
3898         * python/py-type.c: Fix common/ includes.
3899         * python/py-inferior.c: Fix common/ includes.
3900         * progspace.h: Fix common/ includes.
3901         * producer.c: Fix common/ includes.
3902         * procfs.c: Fix common/ includes.
3903         * proc-api.c: Fix common/ includes.
3904         * printcmd.c: Fix common/ includes.
3905         * ppc-linux-nat.c: Fix common/ includes.
3906         * parser-defs.h: Fix common/ includes.
3907         * osdata.c: Fix common/ includes.
3908         * obsd-nat.c: Fix common/ includes.
3909         * nat/x86-linux.c: Fix common/ includes.
3910         * nat/x86-linux-dregs.c: Fix common/ includes.
3911         * nat/x86-dregs.h: Fix common/ includes.
3912         * nat/x86-dregs.c: Fix common/ includes.
3913         * nat/ppc-linux.c: Fix common/ includes.
3914         * nat/mips-linux-watch.h: Fix common/ includes.
3915         * nat/mips-linux-watch.c: Fix common/ includes.
3916         * nat/linux-waitpid.c: Fix common/ includes.
3917         * nat/linux-ptrace.h: Fix common/ includes.
3918         * nat/linux-ptrace.c: Fix common/ includes.
3919         * nat/linux-procfs.c: Fix common/ includes.
3920         * nat/linux-personality.c: Fix common/ includes.
3921         * nat/linux-osdata.c: Fix common/ includes.
3922         * nat/linux-namespaces.c: Fix common/ includes.
3923         * nat/linux-btrace.h: Fix common/ includes.
3924         * nat/linux-btrace.c: Fix common/ includes.
3925         * nat/fork-inferior.c: Fix common/ includes.
3926         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3927         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3928         * nat/aarch64-linux.c: Fix common/ includes.
3929         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3930         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3931         * namespace.h: Fix common/ includes.
3932         * mips-linux-tdep.c: Fix common/ includes.
3933         * minsyms.c: Fix common/ includes.
3934         * mi/mi-parse.h: Fix common/ includes.
3935         * mi/mi-main.c: Fix common/ includes.
3936         * mi/mi-cmd-env.c: Fix common/ includes.
3937         * memrange.h: Fix common/ includes.
3938         * memattr.c: Fix common/ includes.
3939         * maint.h: Fix common/ includes.
3940         * maint.c: Fix common/ includes.
3941         * main.c: Fix common/ includes.
3942         * machoread.c: Fix common/ includes.
3943         * location.c: Fix common/ includes.
3944         * linux-thread-db.c: Fix common/ includes.
3945         * linux-nat.c: Fix common/ includes.
3946         * linux-fork.c: Fix common/ includes.
3947         * inline-frame.c: Fix common/ includes.
3948         * infrun.c: Fix common/ includes.
3949         * inflow.c: Fix common/ includes.
3950         * inferior.h: Fix common/ includes.
3951         * inferior.c: Fix common/ includes.
3952         * infcmd.c: Fix common/ includes.
3953         * inf-ptrace.c: Fix common/ includes.
3954         * inf-child.c: Fix common/ includes.
3955         * ia64-linux-nat.c: Fix common/ includes.
3956         * i387-tdep.c: Fix common/ includes.
3957         * i386-tdep.c: Fix common/ includes.
3958         * i386-linux-tdep.c: Fix common/ includes.
3959         * i386-linux-nat.c: Fix common/ includes.
3960         * i386-go32-tdep.c: Fix common/ includes.
3961         * i386-fbsd-tdep.c: Fix common/ includes.
3962         * i386-fbsd-nat.c: Fix common/ includes.
3963         * guile/scm-type.c: Fix common/ includes.
3964         * guile/guile.c: Fix common/ includes.
3965         * go32-nat.c: Fix common/ includes.
3966         * gnu-nat.c: Fix common/ includes.
3967         * gdbthread.h: Fix common/ includes.
3968         * gdbarch-selftests.c: Fix common/ includes.
3969         * gdb_usleep.c: Fix common/ includes.
3970         * gdb_select.h: Fix common/ includes.
3971         * gdb_bfd.c: Fix common/ includes.
3972         * gcore.c: Fix common/ includes.
3973         * fork-child.c: Fix common/ includes.
3974         * findvar.c: Fix common/ includes.
3975         * fbsd-nat.c: Fix common/ includes.
3976         * event-top.c: Fix common/ includes.
3977         * event-loop.c: Fix common/ includes.
3978         * dwarf2read.c: Fix common/ includes.
3979         * dwarf2loc.c: Fix common/ includes.
3980         * dwarf2-frame.c: Fix common/ includes.
3981         * dwarf-index-cache.c: Fix common/ includes.
3982         * dtrace-probe.c: Fix common/ includes.
3983         * disasm-selftests.c: Fix common/ includes.
3984         * defs.h: Fix common/ includes.
3985         * csky-tdep.c: Fix common/ includes.
3986         * cp-valprint.c: Fix common/ includes.
3987         * cp-support.h: Fix common/ includes.
3988         * cp-support.c: Fix common/ includes.
3989         * corelow.c: Fix common/ includes.
3990         * completer.h: Fix common/ includes.
3991         * completer.c: Fix common/ includes.
3992         * compile/compile.c: Fix common/ includes.
3993         * compile/compile-loc2c.c: Fix common/ includes.
3994         * compile/compile-cplus-types.c: Fix common/ includes.
3995         * compile/compile-cplus-symbols.c: Fix common/ includes.
3996         * command.h: Fix common/ includes.
3997         * cli/cli-dump.c: Fix common/ includes.
3998         * cli/cli-cmds.c: Fix common/ includes.
3999         * charset.c: Fix common/ includes.
4000         * build-id.c: Fix common/ includes.
4001         * btrace.h: Fix common/ includes.
4002         * btrace.c: Fix common/ includes.
4003         * breakpoint.h: Fix common/ includes.
4004         * breakpoint.c: Fix common/ includes.
4005         * ax.h: 
4006         (enum agent_op): Fix common/ includes.
4007         * ax-general.c (struct aop_map): Fix common/ includes.
4008         * ax-gdb.c: Fix common/ includes.
4009         * auxv.c: Fix common/ includes.
4010         * auto-load.c: Fix common/ includes.
4011         * arm-tdep.c: Fix common/ includes.
4012         * arch/riscv.c: Fix common/ includes.
4013         * arch/ppc-linux-common.c: Fix common/ includes.
4014         * arch/i386.c: Fix common/ includes.
4015         * arch/arm.c: Fix common/ includes.
4016         * arch/arm-linux.c: Fix common/ includes.
4017         * arch/arm-get-next-pcs.c: Fix common/ includes.
4018         * arch/amd64.c: Fix common/ includes.
4019         * arch/aarch64.c: Fix common/ includes.
4020         * arch/aarch64-insn.c: Fix common/ includes.
4021         * arch-utils.c: Fix common/ includes.
4022         * amd64-windows-tdep.c: Fix common/ includes.
4023         * amd64-tdep.c: Fix common/ includes.
4024         * amd64-sol2-tdep.c: Fix common/ includes.
4025         * amd64-obsd-tdep.c: Fix common/ includes.
4026         * amd64-nbsd-tdep.c: Fix common/ includes.
4027         * amd64-linux-tdep.c: Fix common/ includes.
4028         * amd64-linux-nat.c: Fix common/ includes.
4029         * amd64-fbsd-tdep.c: Fix common/ includes.
4030         * amd64-fbsd-nat.c: Fix common/ includes.
4031         * amd64-dicos-tdep.c: Fix common/ includes.
4032         * amd64-darwin-tdep.c: Fix common/ includes.
4033         * agent.c: Fix common/ includes.
4034         * ada-lang.h: Fix common/ includes.
4035         * ada-lang.c: Fix common/ includes.
4036         * aarch64-tdep.c: Fix common/ includes.
4037
4038 2019-01-25  Tom Tromey  <tom@tromey.com>
4039
4040         * common/create-version.sh: Use common/version.h.
4041
4042 2019-01-24  Pedro Alves  <palves@redhat.com>
4043
4044         * infrun.c (signal_stop, signal_print, signal_program)
4045         (signal_catch, signal_pass): Now arrays instead of pointers.
4046         (update_signals_program_target, do_target_resume)
4047         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4048         * linux-nat.c (linux_nat_target::pass_signals)
4049         (linux_nat_target::create_inferior, linux_nat_target::attach):
4050         Adjust.
4051         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4052         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4053         * procfs.c (procfs_target::pass_signals): Adjust.
4054         * record-full.c (record_full_target::resume): Adjust.
4055         * remote.c (remote_target::pass_signals)
4056         (remote_target::program_signals): Adjust.
4057         * target-debug.h (target_debug_print_signals): Now takes a
4058         gdb::array_view as parameter.  Adjust.
4059         * target.h (target_ops) <pass_signals, program_signals>: Replace
4060         pointer and length parameters with gdb::array_view.
4061         (target_pass_signals, target_program_signals): Likewise.
4062         * target-delegates.c: Regenerate.
4063
4064 2019-01-24  Pedro Alves  <palves@redhat.com>
4065
4066         * common/forward-scope-exit.h
4067         (forward_scope_exit::forward_scope_exit): Pass arguments to
4068         m_bind_function directly, instead of creating a std::bind and
4069         copying that.
4070
4071 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4072
4073         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4074         for static members.
4075         (pass_in_v_vfp_candidate): Likewise.
4076
4077 2019-01-23  Tom Tromey  <tom@tromey.com>
4078             Pedro Alves  <palves@redhat.com>
4079
4080         * regcache.c (class regcache_invalidator): Remove.
4081         (regcache::raw_write): Use make_scope_exit.
4082
4083 2019-01-23  Tom Tromey  <tom@tromey.com>
4084
4085         * ui-out.h (class ui_out_emit_type): Update comment.
4086
4087 2019-01-23  Tom Tromey  <tom@tromey.com>
4088
4089         * infrun.c (fetch_inferior_event): Update comment.
4090
4091 2019-01-23  Tom Tromey  <tom@tromey.com>
4092             Pedro Alves  <palves@redhat.com>
4093
4094         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4095         parameter.
4096         (fetch_inferior_event): Use SCOPE_EXIT.
4097
4098
4099 2019-01-23  Tom Tromey  <tom@tromey.com>
4100             Pedro Alves  <palves@redhat.com>
4101
4102         * infrun.c (disable_thread_events): Delete.
4103         (stop_all_threads): Use SCOPE_EXIT.
4104
4105 2019-01-23  Tom Tromey  <tom@tromey.com>
4106             Pedro Alves  <palves@redhat.com>
4107
4108         * symfile.c: Include forward-scope-exit.h.
4109         (clear_symtab_users_cleanup): Replace forward declaration with
4110         a FORWARD_SCOPE_EXIT.
4111         (syms_from_objfile_1): Use the forward_scope_exit and
4112         gdb::optional instead of cleanup_function.
4113         (reread_symbols): Use the forward_scope_exit instead of
4114         cleanup_function.
4115         (clear_symtab_users_cleanup): Remove function.
4116
4117 2019-01-23  Tom Tromey  <tom@tromey.com>
4118             Pedro Alves  <palves@redhat.com>
4119
4120         * linux-nat.c: Include scope-exit.h.
4121         (cleanup_target_stop): Remove.
4122         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4123         SCOPE_EXIT.
4124
4125 2019-01-23  Tom Tromey  <tom@tromey.com>
4126             Pedro Alves  <palves@redhat.com>
4127
4128         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4129         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4130
4131 2019-01-23  Tom Tromey  <tom@tromey.com>
4132             Andrew Burgess  <andrew.burgess@embecosm.com>
4133             Pedro Alves  <palves@redhat.com>
4134
4135         * infrun.c (fetch_inferior_event): Use scope_exit.
4136         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4137         * top.c (execute_command): Use scope_exit.
4138         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4139         * utils.c (do_bpstat_clear_actions_cleanup)
4140         (make_bpstat_clear_actions_cleanup): Remove.
4141
4142 2019-01-23  Tom Tromey  <tom@tromey.com>
4143             Pedro Alves  <palves@redhat.com>
4144
4145         * infrun.c: Include "common/scope-exit.h"
4146         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4147         (wait_for_inferior): Use SCOPE_EXIT.
4148         (fetch_inferior_event): Use scope_exit.
4149
4150 2019-01-23  Tom Tromey  <tom@tromey.com>
4151             Pedro Alves  <palves@redhat.com>
4152
4153         * breakpoint.c (create_breakpoint): Remove cleanup.
4154
4155 2019-01-23  Tom Tromey  <tom@tromey.com>
4156             Andrew Burgess  <andrew.burgess@embecosm.com>
4157             Pedro Alves  <palves@redhat.com>
4158
4159 2019-01-23  Pedro Alves  <palves@redhat.com>
4160
4161         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4162
4163 2019-01-23  Pedro Alves  <palves@redhat.com>
4164             Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * gdbthread.h: Include "common/forward-scope-exit.h".
4167         (scoped_finish_thread_state): Redefine custom class in terms of
4168         forward_scope_exit.
4169
4170 2019-01-23  Pedro Alves  <palves@redhat.com>
4171             Andrew Burgess  <andrew.burgess@embecosm.com>
4172
4173         * common/forward-scope-exit.h: New file.
4174
4175 2019-01-23  Pedro Alves  <palves@redhat.com>
4176             Andrew Burgess  <andrew.burgess@embecosm.com>
4177             Tom Tromey  <tom@tromey.com>
4178
4179         * common/scope-exit.h: New file.
4180
4181 2019-01-23  Pedro Alves  <palves@redhat.com>
4182
4183         * common/preprocessor.h (ESC): Rename to ...
4184         (ESC_PARENS): ... this.
4185         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4186         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4187
4188 2019-01-23  Tom Tromey  <tom@tromey.com>
4189
4190         * language.h (class scoped_switch_to_sym_language_if_auto):
4191         Initialize m_lang in both cases.
4192
4193 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4194
4195         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4196         with XCNEW.
4197
4198 2019-01-22  Tom Tromey  <tom@tromey.com>
4199
4200         * corelow.c: Do not include sys/file.h.
4201
4202 2019-01-22  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-wingeneral.h: Include gdb_curses.h.
4205
4206 2019-01-22  Tom Tromey  <tom@tromey.com>
4207
4208         * source-cache.h (class source_cache) <get_source_lines,
4209         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4210
4211 2019-01-22  Tom Tromey  <tom@tromey.com>
4212
4213         * remote-fileio.h (struct remote_target): Declare.
4214
4215 2019-01-22  Tom Tromey  <tom@tromey.com>
4216
4217         * python/py-arch.c: Do not include py-ref.h.
4218         * python/py-bpevent.c: Do not include py-ref.h.
4219         * python/py-cmd.c: Do not include py-ref.h.
4220         * python/py-continueevent.c: Do not include py-ref.h.
4221         * python/py-event.h: Do not include py-ref.h.
4222         * python/py-evtregistry.c: Do not include py-ref.h.
4223         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4224         * python/py-frame.c: Do not include py-ref.h.
4225         * python/py-framefilter.c: Do not include py-ref.h.
4226         * python/py-function.c: Do not include py-ref.h.
4227         * python/py-infevents.c: Do not include py-ref.h.
4228         * python/py-linetable.c: Do not include py-ref.h.
4229         * python/py-objfile.c: Do not include py-ref.h.
4230         * python/py-param.c: Do not include py-ref.h.
4231         * python/py-prettyprint.c: Do not include py-ref.h.
4232         * python/py-progspace.c: Do not include py-ref.h.
4233         * python/py-symbol.c: Do not include py-ref.h.
4234         * python/py-symtab.c: Do not include py-ref.h.
4235         * python/py-type.c: Do not include py-ref.h.
4236         * python/py-unwind.c: Do not include py-ref.h.
4237         * python/py-utils.c: Do not include py-ref.h.
4238         * python/py-value.c: Do not include py-ref.h.
4239         * python/py-varobj.c: Do not include py-ref.h.
4240         * python/py-xmethods.c: Do not include py-ref.h.
4241         * python/python.c: Do not include py-ref.h.
4242         * varobj.c: Do not include py-ref.h.
4243
4244 2019-01-22  Tom Tromey  <tom@tromey.com>
4245
4246         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4247         keyword for bcache.
4248
4249 2019-01-22  Tom Tromey  <tom@tromey.com>
4250
4251         * compile/compile-cplus-types.c: Remove a comment by #include.
4252
4253 2019-01-22  Tom Tromey  <tom@tromey.com>
4254
4255         * compile/gcc-c-plugin.h: Include compile-internal.h.
4256
4257 2019-01-22  Tom Tromey  <tom@tromey.com>
4258
4259         * stabsread.c (EXTERN): Do not define.
4260         (symnum, next_symbol_text_func, processing_gcc_compilation)
4261         (within_function, global_sym_chain, global_stabs)
4262         (previous_stab_code, this_object_header_files)
4263         (n_this_object_header_files)
4264         (n_allocated_this_object_header_files): Define.
4265         * stabsread.h (EXTERN): Never define.  Use "extern".
4266
4267 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4268
4269         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4270         history_value.
4271
4272 2019-01-21  Tom Tromey  <tom@tromey.com>
4273
4274         * ui-out.c: Fix includes.
4275         * tui/tui-source.c: Fix includes.
4276         * target.c: Fix includes.
4277         * remote.c: Fix includes.
4278         * regcache.c: Fix includes.
4279         * python/py-block.c: Fix includes.
4280         * printcmd.c: Fix includes.
4281         * or1k-tdep.c: Fix includes.
4282         * mi/mi-main.c: Fix includes.
4283         * m32r-tdep.c: Fix includes.
4284         * csky-tdep.c: Fix includes.
4285         * compile/compile-cplus-types.c: Fix includes.
4286         * cli/cli-interp.c: Fix includes.
4287
4288 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4289
4290         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4291         for padding.
4292
4293 2019-01-16  Tom Tromey  <tom@tromey.com>
4294
4295         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4296         earlier.
4297         (struct objfile) <msymbols_range>: Move from top level.
4298         <msymbols>: New method.
4299         (class objfile_msymbols): Remove.
4300         * symtab.c (default_collect_symbol_completion_matches_break_on):
4301         Update.
4302         * symmisc.c (dump_msymbols): Update.
4303         * stabsread.c (scan_file_globals): Update.
4304         * objc-lang.c (info_selectors_command, info_classes_command)
4305         (find_methods): Update.
4306         * minsyms.c (find_solib_trampoline_target): Update.
4307         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4308         * coffread.c (coff_symfile_read): Update.
4309         * ada-lang.c (ada_lookup_simple_minsym)
4310         (ada_collect_symbol_completion_matches): Update.
4311
4312 2019-01-16  Tom Tromey  <tom@tromey.com>
4313
4314         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4315         type.  Remove no-argument constructor.
4316         <iterator::operator++>: Simplify.
4317         <begin>: Update.
4318         <end>: Use minimal_symbol_count.
4319
4320 2019-01-16  Tom Tromey  <tom@tromey.com>
4321
4322         * objfiles.h (struct objfile) <psymtabs>: New method.
4323         (class objfile_psymtabs): Remove.
4324         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4325         typedef.
4326         <range>: New method.
4327         (require_partial_symbols): Change return type.
4328         * psymtab.c (require_partial_symbols)
4329         (psym_expand_symtabs_matching): Update.
4330         * mdebugread.c (parse_partial_symbols): Update.
4331         * dbxread.c (dbx_end_psymtab): Update.
4332
4333 2019-01-15  Tom Tromey  <tom@tromey.com>
4334
4335         * symtab.c (lookup_objfile_from_block)
4336         (lookup_symbol_in_objfile_symtabs)
4337         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4338         (find_line_symtab, info_sources_command)
4339         (default_collect_symbol_completion_matches_break_on)
4340         (make_source_files_completion_list): Update.
4341         * symmisc.c (print_objfile_statistics, dump_objfile)
4342         (maintenance_print_symbols, maintenance_info_symtabs)
4343         (maintenance_check_symtabs, maintenance_info_line_tables):
4344         Update.
4345         * source.c (select_source_symtab)
4346         (forget_cached_source_info_for_objfile): Update.
4347         * objfiles.h (class objfile_compunits): Remove.
4348         (struct objfile) <compunits_range>: New typedef.
4349         (compunits): New method.
4350         * objfiles.c (objfile_relocate1): Update.
4351         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4352         * maint.c (count_symtabs_and_blocks): Update.
4353         * linespec.c (iterate_over_all_matching_symtabs): Update.
4354         * cp-support.c (add_symbol_overload_list_qualified): Update.
4355         * coffread.c (coff_symtab_read): Update.
4356         * ada-lang.c (add_nonlocal_symbols)
4357         (ada_collect_symbol_completion_matches)
4358         (ada_add_global_exceptions): Update.
4359
4360 2019-01-15  Tom Tromey  <tom@tromey.com>
4361
4362         * progspace.h (program_space) <objfiles_safe_range>: New
4363         typedef.
4364         <objfiles_safe>: New method.
4365         * objfiles.h (class all_objfiles_safe): Remove.
4366         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4367         * jit.c (jit_inferior_exit_hook): Update.
4368
4369 2019-01-17  Tom Tromey  <tom@tromey.com>
4370
4371         * progspace.h (program_space) <objfiles_range>: New typedef.
4372         <objfiles>: New method.
4373         <objfiles_head>: Rename from objfiles.
4374         (object_files): Update.
4375         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4376         * guile/scm-pretty-print.c
4377         (ppscm_find_pretty_printer_from_objfiles): Update.
4378         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4379         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4380         Update.
4381         * python/py-progspace.c (pspy_get_objfiles): Update.
4382         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4383         Update.
4384         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4385         (objfpy_lookup_objfile_by_build_id): Update.
4386         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4387         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4388         Update.
4389         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4390         (expand_symtab_containing_pc, lookup_objfile_from_block)
4391         (lookup_static_symbol, basic_lookup_transparent_type)
4392         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4393         (find_line_symtab, info_sources_command)
4394         (default_collect_symbol_completion_matches_break_on)
4395         (make_source_files_completion_list, find_main_name): Update.
4396         * symmisc.c (print_symbol_bcache_statistics)
4397         (print_objfile_statistics, maintenance_print_symbols)
4398         (maintenance_print_msymbols, maintenance_print_objfiles)
4399         (maintenance_info_symtabs, maintenance_check_symtabs)
4400         (maintenance_expand_symtabs, maintenance_info_line_tables):
4401         Update.
4402         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4403         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4404         (map_overlay_command, unmap_overlay_command)
4405         (simple_overlay_update, expand_symtabs_matching)
4406         (map_symbol_filenames): Update.
4407         * symfile-debug.c (set_debug_symfile): Update.
4408         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4409         Update.
4410         * source.c (select_source_symtab, forget_cached_source_info):
4411         Update.
4412         * solib.c (solib_read_symbols): Update.
4413         * solib-spu.c (append_ocl_sos): Update.
4414         * psymtab.c (maintenance_print_psymbols)
4415         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4416         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4417         * printcmd.c (info_symbol_command): Update.
4418         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4419         Update.
4420         * objfiles.h (class all_objfiles): Remove.
4421         * objfiles.c (have_partial_symbols, have_full_symbols)
4422         (have_minimal_symbols, qsort_cmp, update_section_map)
4423         (shared_objfile_contains_address_p)
4424         (default_iterate_over_objfiles_in_search_order): Update.
4425         * objc-lang.c (info_selectors_command, info_classes_command)
4426         (find_methods): Update.
4427         * minsyms.c (find_solib_trampoline_target): Update.
4428         * maint.c (maintenance_info_sections)
4429         (maintenance_translate_address, count_symtabs_and_blocks):
4430         Update.
4431         * main.c (captured_main_1): Update.
4432         * linux-thread-db.c (try_thread_db_load_from_pdir)
4433         (has_libpthread): Update.
4434         * linespec.c (iterate_over_all_matching_symtabs)
4435         (search_minsyms_for_name): Update.
4436         * jit.c (jit_find_objf_with_entry_addr): Update.
4437         * hppa-tdep.c (find_unwind_entry)
4438         (hppa_lookup_stub_minimal_symbol): Update.
4439         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4440         Update.
4441         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4442         (elf_gnu_ifunc_resolve_by_got): Update.
4443         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4444         * dwarf-index-write.c (save_gdb_index_command): Update.
4445         * cp-support.c (add_symbol_overload_list_qualified): Update.
4446         * breakpoint.c (create_overlay_event_breakpoint)
4447         (create_longjmp_master_breakpoint)
4448         (create_std_terminate_master_breakpoint)
4449         (create_exception_master_breakpoint): Update.
4450         * blockframe.c (find_pc_partial_function): Update.
4451         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4452         (ada_collect_symbol_completion_matches)
4453         (ada_add_global_exceptions): Update.
4454
4455 2019-01-17  Tom Tromey  <tom@tromey.com>
4456
4457         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4458         declare VEC.
4459         (solib_target_parse_libraries): Change return type.
4460         (library_list_start_segment, library_list_start_section)
4461         (library_list_end_library, library_list_start_library); Update.
4462         (solib_target_free_library_list): Remove.
4463         (solib_target_parse_libraries): Remove cleanup.  Change return
4464         type.
4465         (solib_target_current_sos): Update.
4466
4467 2019-01-17  Tom Tromey  <tromey@bapiya>
4468
4469         * valprint.c: Replace "the the" with "the".
4470         * symtab.c: Replace "the the" with "the".
4471         * solib.c: Replace "the the" with "the".
4472         * solib-dsbt.c: Replace "the the" with "the".
4473         * linespec.c: Replace "the the" with "the".
4474         * dwarf2loc.h: Replace "the the" with "the".
4475         * amd64-windows-tdep.c: Replace "the the" with "the".
4476         * aarch64-tdep.c: Replace "the the" with "the".
4477
4478 2019-01-16  Keith Seitz  <keiths@redhat.com>
4479
4480         PR gdb/23773
4481         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4482         <builder>: Rename to ..
4483         <m_builder>: ... this and make private.
4484         (dwarf2_cu::get_builder): New method.  Change all users of
4485         `builder' to use this method.
4486         (dwarf2_start_symtab): Move to ...
4487         (dwarf2_cu::start_symtab): ... here.  Update all callers
4488         (setup_type_unit_groups): Move to ...
4489         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4490         callers.
4491         (dwarf2_cu::reset_builder): New method.
4492         (process_full_compunit, process_full_type_unit): Use
4493         dwarf2_cu::reset_builder.
4494         (follow_die_offset): Record the ancestor CU if it is different
4495         from the followed DIE's CU.
4496         (follow_die_sig_1): Likewise.
4497
4498 2019-01-15  Tom Tromey  <tom@tromey.com>
4499
4500         * remote.c (class remote_state) <buf>: Now a char_vector.
4501         <buf_size>: Remove.
4502         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4503         parameter.
4504         (remote_target::getpkt_or_notif_sane_1)
4505         (remote_target::getpkt_sane)
4506         (remote_target::getpkt_or_notif_sane): Likewise.
4507         (class remote_target) <putpkt>: New overload.
4508         (remote_target::read_frame): Change type of "buf_p".  Remove
4509         sizeof_p parameter.
4510         (packet_ok): New overload.
4511         (packet_check_result): New overload.
4512         Update all uses.
4513
4514 2019-01-14  Tom Tromey  <tom@tromey.com>
4515
4516         * remote-notif.c (handle_notification, remote_notif_ack)
4517         (remote_notif_parse): Make "buf" const.
4518         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4519         const.
4520         (remote_notif_parse, remote_notif_ack, handle_notification):
4521         Likewise.
4522         * remote.c (remote_notif_stop_parse): Make "buf" const.
4523         (remote_target::remote_parse_stop_reply): Make "buf" const.
4524         (remote_notif_stop_ack): Make "buf" const.
4525
4526 2019-01-14  Tom Tromey  <tom@tromey.com>
4527
4528         * remote.c (remote_console_output): Make parameter const.
4529
4530 2019-01-14  Tom Tromey  <tom@tromey.com>
4531
4532         * target-debug.h (target_debug_print_signals): Constify.
4533         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4534         * procfs.c (procfs_target::pass_signals): Update.
4535         * linux-nat.c (linux_nat_target::pass_signals): Update.
4536         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4537         * target-delegates.c: Rebuild.
4538         * remote.c (remote_target::program_signals): Update.
4539         (remote_target::pass_signals): Update.
4540         * target.c (target_pass_signals): Constify argument.
4541         (target_program_signals): Likewise.
4542         * target.h (struct target_ops) <pass_signals, program_signals>:
4543         Constify argument.
4544         (target_pass_signals, target_program_signals): Constify argument.
4545
4546 2019-01-14  Tom Tromey  <tom@tromey.com>
4547
4548         PR tui/28819:
4549         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4550
4551 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4552
4553         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4554         field.
4555         * rs6000-tdep.c: Include reggroups.h.
4556         (IS_V_ALIAS_PSEUDOREG): Define.
4557         (rs6000_register_name): Return names for the "vX" aliases.
4558         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4559         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4560         aliases.  Call default_register_reggroup_p for all other
4561         pseudo-registers.
4562         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4563         New functions.
4564         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4565         Handle "vX" aliases.
4566         (v_alias_pseudo_register_collect): New function.
4567         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4568         (rs6000_gdbarch_init): Initialize "vX" aliases as
4569         pseudo-registers.  Restore registration of
4570         rs6000_pseudo_register_reggroup_p with
4571         set_tdesc_pseudo_register_reggroup_p.
4572
4573 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4574
4575         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4576         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4577         set_gdbarch_num_pseudo_regs.
4578
4579 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4580
4581         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4582         Remove arg prefixname, add do_set and do_show.
4583         Add member functions set_list and show_list.
4584         * cli/cli-style.c (class cli_style_option): Update accordingly.
4585         (style_set_list): Move to file scope.
4586         (style_show_list): Likewise.
4587         (set_style): Call help_list.
4588         (show_style): Call cmd_show_list.
4589         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4590         Update to use the new macro.
4591
4592 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4593
4594         * ada-lang.c (_initialize_ada_language): Expand the help text
4595         for the "catch exception" command.
4596
4597 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4598
4599         * symtab.c (matching_obj_sections): Initialize obj,
4600         declare it closer to its usage.
4601
4602 2019-01-10  Tom Tromey  <tom@tromey.com>
4603
4604         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4605         (basic_inf_threads_range): Remove.
4606         (inf_threads_range, inf_non_exited_threads_range)
4607         (safe_inf_threads_range): Use next_adapter.
4608
4609 2019-01-10  Keith Seitz  <keiths@redhat.com>
4610
4611         PR gdb/23712
4612         PR symtab/23010
4613         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4614         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4615
4616 2019-01-10  Keith Seitz  <keiths@redhat.com>
4617
4618         PR gdb/23712
4619         PR symtab/23010
4620         * dictionary.c (pending_to_vector): Remove.
4621         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4622         Remove _1 suffix, replacing functions of the same name.  Update
4623         all callers.
4624         (dict_create_hashed, dict_create_hashed_expandable)
4625         (dict_create_linear, dict_create_linear_expandable, dict_free)
4626         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4627         Make functions static.
4628
4629 2019-01-10  Keith Seitz  <keiths@redhat.com>
4630
4631         PR gdb/23712
4632         PR symtab/23010
4633         * dictionary.h (struct dictionary): Replace declaration with
4634         multidictionary.
4635         (dict_create_hashed, dict_create_hashed_expandable)
4636         (dict_create_linear, dict_create_linear_expandable)
4637         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4638         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4639         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4640         taking multidictionary argument.
4641         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4642         * block.h (struct block) <dict>: Change to multidictionary
4643         and rename `multidict'.
4644         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4645         symmisc.c: Update all dictionary references to multidictionary.
4646
4647 2019-01-10  Keith Seitz  <keiths@redhat.com>
4648
4649         PR gdb/23712
4650         PR symtab/23010
4651         * dictionary.c: Include unordered_map.
4652         (pending_to_vector): New function.
4653         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4654         Rewrite the non-"_1" functions to take vector instead
4655         of linked list.
4656         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4657         "new" _1 versions of the same name.
4658         (multidictionary): Define.
4659         (std::hash<enum language): New definition.
4660         (collate_pending_symbols_by_language, mdict_create_hashed)
4661         (mdict_create_hashed_expandable, mdict_create_linear)
4662         (mdict_create_linear_expandable, mdict_free)
4663         (find_language_dictionary, create_new_language_dictionary)
4664         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4665         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4666         (mdict_size, mdict_empty): New functions.
4667         * dictionary.h (mdict_iterator): Define.
4668
4669 2019-01-10  Pedro Alves  <palves@redhat.com>
4670
4671         * breakpoint.c (read_uploaded_action)
4672         (create_tracepoint_from_upload): Adjust to use
4673         gdb::unique_xmalloc_ptr.
4674         * ctf.c (ctf_write_uploaded_tp):
4675         (SET_ARRAY_FIELD): Use emplace_back.
4676         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4677         * tracefile-tfile.c (tfile_write_uploaded_tp):
4678         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4679         gdb::unique_xmalloc_ptr.
4680         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4681         at_string, cond_string, cmd_strings>: Replace char pointers
4682         with gdb::unique_xmalloc_ptr.
4683
4684 2019-01-10  Pedro Alves  <palves@redhat.com>
4685
4686         * solib-target.c (library_list_start_library): Don't xstrdup name.
4687
4688 2019-01-10  Pedro Alves  <palves@redhat.com>
4689
4690         * mdebugread.c (parse_partial_symbols): Use
4691         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4692
4693 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         * linux-fork.c (scoped_switch_fork_info)
4696         <~scoped_switch_fork_info>: Fix incorrect variable name.
4697
4698 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4699
4700         * linux-fork.c (scoped_switch_fork_info)
4701         <scoped_switch_fork_info>: Make explicit.
4702         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4703
4704 2019-01-10  Tom Tromey  <tom@tromey.com>
4705
4706         * objfiles.h (objfile::reset_psymtabs): Update.
4707         * objfiles.c (objfile::objfile): Update.
4708         * psymtab.h (psymtab_storage::obstack): Update.
4709         (psymtab_storage::m_obstack): Use gdb::optional.
4710         (class psymtab_storage): Update comment.  Remove objfile
4711         parameter.
4712         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4713
4714 2019-01-10  Tom Tromey  <tom@tromey.com>
4715
4716         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4717         <free_psymtabs>: Now private.
4718         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4719         (allocate_psymtab): Use new method.
4720
4721 2019-01-10  Tom Tromey  <tom@tromey.com>
4722
4723         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4724         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4725         * mdebugread.c (parse_partial_symbols): Use
4726         allocate_dependencies.
4727         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4728         allocate_dependencies.
4729         (process_psymtab_comp_unit_reader)
4730         (build_type_psymtab_dependencies): Likewise.
4731         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4732
4733 2019-01-10  Tom Tromey  <tom@tromey.com>
4734
4735         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4736         PSYMBOL_SET_LANGUAGE.
4737         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4738
4739 2019-01-10  Tom Tromey  <tom@tromey.com>
4740
4741         * psymtab.h (psymtab_storage::obstack): New method.
4742         <m_obstack>: Rename from obstack; now private.
4743         * psymtab.c (psymtab_storage): Update.
4744         * dwarf2read.c (create_addrmap_from_index)
4745         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4746         Update.
4747
4748 2019-01-10  Tom Tromey  <tom@tromey.com>
4749
4750         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4751         * objfiles.h (objfile::reset_psymtabs): New method.
4752
4753 2019-01-10  Tom Tromey  <tom@tromey.com>
4754
4755         * symmisc.c (print_symbol_bcache_statistics): Update.
4756         (print_objfile_statistics): Update.
4757         * symfile.c (reread_symbols): Update.
4758         * psymtab.h (class psymtab_storage): New.
4759         * psymtab.c (psymtab_storage): New constructor.
4760         (~psymtab_storage): New destructor.
4761         (require_partial_symbols): Update.
4762         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4763         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4764         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4765         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4766         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4767         (start_psymtab_common, end_psymtab_common)
4768         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4769         (allocate_psymtab): Update.
4770         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4771         Update.
4772         (dump_psymtab_addrmap, maintenance_print_psymbols)
4773         (maintenance_check_psymtabs): Update.
4774         (class objfile_psymtabs): Move to objfiles.h.
4775         * psympriv.h (discard_psymtab): Now inline.
4776         (psymtab_discarder::psymtab_discarder): Update.
4777         (psymtab_discarder::~psymtab_discarder): Update.
4778         (ALL_OBJFILE_PSYMTABS): Rewrite.
4779         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4780         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4781         Remove fields.
4782         <partial_symtabs>: New field.
4783         (class objfile_psymtabs): Move from psymtab.h.  Update.
4784         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4785         psymbol_cache.
4786         (objfile::~objfile): Don't destroy psymbol_cache.
4787         * mdebugread.c (parse_partial_symbols): Update.
4788         * dwarf2read.c (create_addrmap_from_index)
4789         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4790         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4791         (add_partial_subprogram, dwarf2_ranges_read): Update.
4792         * dwarf-index-write.c (write_address_map)
4793         (write_one_signatured_type, recursively_write_psymbols)
4794         (class debug_names, class debug_names, write_psymtabs_to_index):
4795         Update.
4796
4797 2019-01-10  Tom Tromey  <tom@tromey.com>
4798
4799         * symtab.h (SYMBOL_SET_NAMES): Update.
4800         (symbol_set_names): Update.
4801         (MSYMBOL_SET_NAMES): Update.
4802         * symtab.c (symbol_set_names): Change argument to be an
4803         objfile_per_bfd_storage.
4804         * psymtab.c (add_psymbol_to_bcache): Update.
4805         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4806
4807 2019-01-10  Tom Tromey  <tom@tromey.com>
4808
4809         * symtab.c (create_demangled_names_hash): Change argument to be an
4810         objfile_per_bfd_storage.
4811         (symbol_set_names): Update.
4812
4813 2019-01-10  Tom Tromey  <tom@tromey.com>
4814
4815         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4816         init_psymbol_list.
4817         * psymtab.c (init_psymbol_list): Do nothing if already called.
4818         * psympriv.h (init_psymbol_list): Add comment.
4819         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4820         init_psymbol_list.
4821         * dbxread.c (dbx_symfile_read): Unconditionally call
4822         init_psymbol_list.
4823
4824 2019-01-10  Tom Tromey  <tom@tromey.com>
4825
4826         * xcoffread.c (scan_xcoff_symtab): Update.
4827         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4828         "where".
4829         * mdebugread.c (parse_partial_symbols)
4830         (handle_psymbol_enumerators): Update.
4831         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4832         * dbxread.c (read_dbx_symtab): Update.
4833         * psympriv.h (psymbol_placement): New enum.
4834         (add_psymbol_to_list): Update.
4835
4836 2019-01-10  Tom Tromey  <tom@tromey.com>
4837
4838         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4839         static_psymbols parameters.
4840         (scan_xcoff_symtab): Update.
4841         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4842         static_psymbols parameters.
4843         * psympriv.h (start_psymtab_common): Update.
4844         * mdebugread.c (parse_partial_symbols): Update.
4845         * dwarf2read.c (create_partial_symtab): Update.
4846         * dbxread.c (read_dbx_symtab): Update.
4847         (start_psymtab): Remove global_psymbols and static_psymbols
4848         parameters.
4849
4850 2019-01-10  Tom Tromey  <tom@tromey.com>
4851
4852         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4853         * psymtab.c (allocate_psymtab): Add comment.
4854         * psympriv.h (allocate_psymtab): Add comment.
4855         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4856         initializations.
4857         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4858
4859 2019-01-10  Tom Tromey  <tom@tromey.com>
4860
4861         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4862         Don't declare.
4863         * mipsread.c: Include mdebugread.h.
4864         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4865         Declare.
4866         * elfread.c: Include mdebugread.h.
4867
4868 2019-01-09  Tom Tromey  <tom@tromey.com>
4869
4870         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4871         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4872         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4873         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4874         (psym_lookup_symbol, psym_find_last_source_symtab)
4875         (psym_forget_cached_source_info, psym_print_stats)
4876         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4877         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4878         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4879         (psym_find_compunit_symtab_by_address)
4880         (maintenance_print_psymbols, maintenance_info_psymtabs)
4881         (maintenance_check_psymtabs): Use ranged for.
4882         * psymtab.h (class objfile_psymtabs): New.
4883         (require_partial_symbols): Return objfile_psymtabs.
4884         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4885
4886 2019-01-09  Tom Tromey  <tom@tromey.com>
4887
4888         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4889         (find_pc_mapped_section, list_overlays_command)
4890         (map_overlay_command, unmap_overlay_command)
4891         (simple_overlay_update): Use all_objfiles.
4892         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4893         * printcmd.c (info_symbol_command): Use all_objfiles.
4894         * objfiles.h (ALL_OBJSECTIONS): Remove.
4895         * maint.c (maintenance_translate_address): Use all_objfiles.
4896         * gcore.c (gcore_create_callback): Use all_objfiles.
4897         (objfile_find_memory_regions): Likewise.
4898
4899 2019-01-09  Tom Tromey  <tom@tromey.com>
4900
4901         * symtab.c (find_line_symtab, info_sources_command)
4902         (make_source_files_completion_list): Use objfile_compunits.
4903         * source.c (select_source_symtab): Use objfile_compunits.
4904         * objfiles.h (struct objfile): Update comment.
4905         (ALL_OBJFILES): Remove.
4906         (ALL_FILETABS): Remove.
4907         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4908         objfile_compunits.
4909
4910 2019-01-09  Tom Tromey  <tom@tromey.com>
4911
4912         * symmisc.c (print_objfile_statistics, dump_objfile)
4913         (maintenance_print_symbols): Use compunit_filetabs.
4914         * source.c (forget_cached_source_info_for_objfile): Use
4915         compunit_filetabs.
4916         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4917         (ALL_FILETABS): Use compunit_filetabs.
4918         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4919         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4920
4921 2019-01-09  Tom Tromey  <tom@tromey.com>
4922
4923         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4924         (compunit_filetabs): New.
4925         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4926         compunit_filetabs.
4927         (info_sources_command, make_source_files_completion_list): Remove
4928         declaration.
4929         * symmisc.c (print_objfile_statistics, dump_objfile)
4930         (maintenance_print_symbols): Remove declaration.
4931         (maintenance_info_symtabs): Use compunit_filetabs.
4932         (maintenance_info_line_tables): Likewise.
4933         * source.c (select_source_symtab): Change local variable name.
4934         (forget_cached_source_info_for_objfile): Remove declaration.
4935         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4936         * objfiles.c (objfile_relocate1): Remove declaration.
4937         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4938         declaration.
4939         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4940         * coffread.c (coff_symtab_read): Remove declaration.
4941         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4942         compunit_filetabs.
4943
4944 2019-01-09  Tom Tromey  <tom@tromey.com>
4945
4946         * symtab.c (lookup_objfile_from_block)
4947         (find_pc_sect_compunit_symtab, search_symbols)
4948         (default_collect_symbol_completion_matches_break_on): Use
4949         objfile_compunits.
4950         * objfiles.h (ALL_COMPUNITS): Remove.
4951         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4952         * cp-support.c (add_symbol_overload_list_qualified): Use
4953         objfile_compunits.
4954         * ada-lang.c (ada_collect_symbol_completion_matches)
4955         (ada_add_global_exceptions): Use objfile_compunits.
4956
4957 2019-01-09  Tom Tromey  <tom@tromey.com>
4958
4959         * source.c (select_source_symtab)
4960         (forget_cached_source_info_for_objfile): Remove declaration.
4961         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4962         declaration.
4963         * maint.c (count_symtabs_and_blocks): Remove declaration.
4964         * cp-support.c (add_symbol_overload_list_qualified): Remove
4965         declaration.
4966         * coffread.c (coff_symtab_read): Remove declaration.
4967         * symtab.c (lookup_symbol_in_objfile_symtabs)
4968         (basic_lookup_transparent_type_1): Use objfile_compunits.
4969         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4970         (info_sources_command, search_symbols)
4971         (default_collect_symbol_completion_matches_break_on)
4972         (make_source_files_completion_list): Remove declaration.
4973         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4974         (ada_collect_symbol_completion_matches)
4975         (ada_add_global_exceptions): Remove declaration.
4976         * linespec.c (iterate_over_all_matching_symtabs): Use
4977         objfile_compunits.
4978         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4979         (class objfile_compunits): New.
4980         (ALL_COMPUNITS): Use objfile_compunits.
4981         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4982         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4983         objfile_compunits.
4984         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4985
4986 2019-01-09  Tom Tromey  <tom@tromey.com>
4987
4988         * symtab.c (search_symbols)
4989         (default_collect_symbol_completion_matches_break_on): Use
4990         objfile_msymbols.
4991         * ada-lang.c (ada_lookup_simple_minsym)
4992         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4993         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4994         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4995         objfile_msymbols.
4996         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4997         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4998         * objc-lang.c (find_methods): Use objfile_msymbols.
4999         (info_selectors_command, info_classes_command): Likewise.
5000         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5001         * objfiles.h (class objfile_msymbols): New.
5002         (ALL_OBJFILE_MSYMBOLS): Remove.
5003         (ALL_MSYMBOLS): Remove.
5004
5005 2019-01-09  Tom Tromey  <tom@tromey.com>
5006
5007         * common/next-iterator.h (next_adapter): Add Iterator template
5008         parameter.
5009         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5010         (class all_objfiles_safe): New.
5011         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5012         * objfiles.c (put_objfile_before): Update comment.
5013         (add_separate_debug_objfile): Likewise.
5014         (free_all_objfiles): Use all_objfiles_safe.
5015         (objfile_purge_solibs): Likewise.
5016
5017 2019-01-09  Tom Tromey  <tom@tromey.com>
5018
5019         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5020         (expand_symtab_containing_pc, lookup_static_symbol)
5021         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5022         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5023         all_objfiles.
5024         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5025         * breakpoint.c (create_overlay_event_breakpoint)
5026         (create_longjmp_master_breakpoint)
5027         (create_std_terminate_master_breakpoint)
5028         (create_exception_master_breakpoint): Use all_objfiles.
5029         * linux-thread-db.c (try_thread_db_load_from_pdir)
5030         (has_libpthread): Use all_objfiles.
5031         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5032         * linespec.c (iterate_over_all_matching_symtabs)
5033         (search_minsyms_for_name): Use all_objfiles.
5034         * maint.c (maintenance_info_sections): Use all_objfiles.
5035         * main.c (captured_main_1): Use all_objfiles.
5036         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5037         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5038         * guile/scm-pretty-print.c
5039         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5040         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5041         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5042         (maintenance_print_msymbols): Use all_objfiles.
5043         * source.c (select_source_symtab): Use all_objfiles.
5044         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5045         * symfile.c (remove_symbol_file_command)
5046         (expand_symtabs_matching, map_symbol_filenames): Use
5047         all_objfiles.
5048         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5049         all_objfiles.
5050         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5051         * objc-lang.c (find_methods): Use all_objfiles.
5052         * objfiles.c (have_partial_symbols, have_full_symbols)
5053         (have_minimal_symbols, qsort_cmp)
5054         (default_iterate_over_objfiles_in_search_order): Use
5055         all_objfiles.
5056         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5057         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5058         (maintenance_check_psymtabs): Use all_objfiles.
5059         (ALL_PSYMTABS): Remove.
5060         * compile/compile-object-run.c (do_module_cleanup): Use
5061         all_objfiles.
5062         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5063         * cp-support.c (add_symbol_overload_list_qualified): Use
5064         all_objfiles.
5065         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5066         Use all_objfiles.
5067         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5068         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5069         all_objfiles.
5070         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5071         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5072         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5073         Uses all_objfiles.
5074         * solib.c (solib_read_symbols): Use all_objfiles
5075
5076 2019-01-09  Tom Tromey  <tom@tromey.com>
5077
5078         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5079         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5080         all_objfiles.
5081         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5082         * symmisc.c (print_symbol_bcache_statistics)
5083         (print_objfile_statistics, maintenance_print_objfiles)
5084         (maintenance_info_symtabs, maintenance_check_symtabs)
5085         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5086         all_objfiles.
5087         * source.c (forget_cached_source_info): Use all_objfiles.
5088         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5089         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5090         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5091         * objfiles.c (update_section_map): Use all_objfiles.
5092         (shared_objfile_contains_address_p): Likewise.
5093         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5094         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5095
5096 2019-01-09  Tom Tromey  <tom@tromey.com>
5097
5098         * common/next-iterator.h: New file.
5099         * objfiles.h (class all_objfiles): New.
5100         (struct objfile_iterator): New.
5101
5102 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5103
5104         * NEWS: Move the description of the changed "frame", "select-frame",
5105          and "info frame" commands to the Changed commands section.
5106
5107 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5108
5109         * gdbtypes.c (check_stub_method_group): Remove handling of old
5110         mangling schemes.
5111         * linespec.c (find_methods): Likewise.
5112         * stabsread.c (read_member_functions): Likewise.
5113         * valops.c (search_struct_method): Likewise.
5114         (value_struct_elt_for_reference): Likewise.
5115         * NEWS: Mention this change.
5116
5117 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5118
5119         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5120         print_source_lines.
5121         * source.c (print_source_lines_base): Update line number check.
5122         (print_source_lines): New function.
5123         (source_lines_range::source_lines_range): New function.
5124         * source.h (class source_lines_range): New class.
5125         (print_source_lines): New declaration.
5126
5127 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5128
5129         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5130
5131 2019-01-08  Tom Tromey  <tom@tromey.com>
5132             Simon Marchi  <simon.marchi@ericsson.com>
5133
5134         PR gdb/24060
5135         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5136         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5137         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5138         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5139         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5140         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5141
5142 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5143
5144         * source.c (select_source_symtab): Move header comment to
5145         declaration in source.h.
5146         (forget_cached_source_info_for_objfile): Likewise.
5147         (forget_cached_source_info): Likewise.
5148         (identify_source_line): Likewise.
5149         * source.h (identify_source_line): Move declaration from symtab.h
5150         and add comment from source.c
5151         (print_source_lines): Likewise.
5152         (forget_cached_source_info_for_objfile): Likewise.
5153         (forget_cached_source_info): Likewise.
5154         (select_source_symtab): Likewise.
5155         (enum print_source_lines_flag): Move definition from symtab.h.
5156         * symtab.h (identify_source_line): Move declaration to source.h.
5157         (print_source_lines): Likewise.
5158         (forget_cached_source_info_for_objfile): Likewise.
5159         (forget_cached_source_info): Likewise.
5160         (select_source_symtab): Likewise.
5161         (enum print_source_lines_flag): Move definition to source.h.
5162         * tui/tui-hooks.c: Add 'source.h' include.
5163
5164 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5165
5166         * source.c (print_source_lines_base): Handle requests to print
5167         reverse line number sequences, and guard against empty lines
5168         string.
5169
5170 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5171
5172         * source.c (print_source_lines_base): Fix skip of '\r' if next
5173         character is '\n'.
5174
5175 2019-01-06  Tom Tromey  <tom@tromey.com>
5176
5177         * c-exp.y (struct c_parse_state) <macro_original_text,
5178         expansion_obstack>: New member.
5179         (macro_original_text, expansion_obstack): Remove globals.
5180         (scan_macro_expansion, scanning_macro_expansion)
5181         (finished_macro_expansion): Update.
5182         (scan_macro_cleanup): Remove.
5183         (yylex, c_parse): Update.
5184
5185 2019-01-06  Tom Tromey  <tom@tromey.com>
5186
5187         * c-exp.y (struct c_parse_state) <strings>: New member.
5188         (operator_stoken): Update.
5189
5190 2019-01-06  Tom Tromey  <tom@tromey.com>
5191
5192         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5193         (union type_stack_elt) <typelist_val>: Now a pointer to
5194         std::vector.
5195         (type_stack_cleanup): Don't declare.
5196         (push_typelist): Update.
5197         * parse.c (pop_typelist): Return a std::vector.
5198         (push_typelist): Take a std::vector.
5199         (follow_types): Update.  Do not free args.
5200         (type_stack_cleanup): Remove.
5201         * c-exp.y (struct c_parse_state): New.
5202         (cpstate): New global.
5203         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5204         (nonempty_typelist): Update.
5205         (func_mod): Create a new vector.
5206         (c_parse): Create a c_parse_state.
5207         (check_parameter_typelist): Do not delete params.
5208         (function_method): Update.  Do not delete type_list.
5209
5210 2019-01-06  Tom Tromey  <tom@tromey.com>
5211
5212         PR gdb/28155:
5213         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5214         check_typedef.
5215         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5216         (print_return_value): Likewise.
5217
5218 2019-01-05  Tom Tromey  <tom@tromey.com>
5219
5220         * contrib/cleanup_check.py: Remove.
5221         * contrib/gcc-with-excheck: Remove.
5222         * contrib/exsummary.py: Remove.
5223         * contrib/excheck.py: Remove.
5224
5225 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5226
5227         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5228         NULL. Initialize tpprev to NULL instead of assigning it
5229         to NULL on the next statement.
5230         * windows-nat.c (windows_delete_thread): Remove check for
5231         main_thread_id before printing thread exit notifications.
5232         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5233         Remove thread ID check against main_thread_id.
5234         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5235         windows_delete_thread.
5236         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5237
5238 2019-01-04  Tom Tromey  <tom@tromey.com>
5239
5240         * compile/compile.c (_initialize_compile): Use upper case for
5241         metasyntactic variables.
5242         * symmisc.c (_initialize_symmisc): Use upper case for
5243         metasyntactic variables.
5244         * psymtab.c (_initialize_psymtab): Use upper case for
5245         metasyntactic variables.
5246         * demangle.c (demangle_command): Use upper case for metasyntactic
5247         variables.
5248         (_initialize_demangler): Likewise.
5249         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5250         variables.
5251
5252 2019-01-03  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5255
5256 2019-01-03  Tom Tromey  <tom@tromey.com>
5257
5258         * python/py-symtab.c (salpy_str): Update.
5259         (struct salpy_sal_object) <symtab>: Now a PyObject.
5260         (salpy_dealloc): Update.
5261         (del_objfile_sal): Use gdbpy_ref.
5262
5263 2019-01-03  Tom Tromey  <tom@tromey.com>
5264
5265         * python/py-type.c (convert_field): Use new_reference.  Return
5266         gdbpy_ref.
5267         (make_fielditem): Return gdbpy_ref.
5268         (typy_fields): Update.
5269         (typy_getitem): Update.
5270         (field_name): Return gdbpy_ref.  Use new_reference.
5271         (typy_iterator_iternext): Update.
5272
5273 2019-01-03  Tom Tromey  <tom@tromey.com>
5274
5275         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5276
5277 2019-01-03  Tom Tromey  <tom@tromey.com>
5278
5279         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5280         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5281         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5282         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5283         (pspy_set_type_printers): Likewise.
5284         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5285         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5286         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5287         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5288         (objfpy_set_type_printers): Likewise.
5289
5290 2019-01-03  Tom Tromey  <tom@tromey.com>
5291
5292         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5293         (gdbpy_print_stack): Use gdbpy_err_fetch.
5294         * python/python-internal.h (class gdbpy_err_fetch): New class.
5295         (class gdbpy_enter) <m_error_type, m_error_value,
5296         m_error_traceback>: Remove.
5297         <m_error>: New member.
5298         (gdbpy_exception_to_string): Don't declare.
5299         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5300         * python/py-value.c (convert_value_from_python): Use
5301         gdbpy_err_fetch.
5302         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5303         gdbpy_exception_to_string.
5304         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5305         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5306         gdbpy_err_fetch.
5307
5308 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5309
5310         * linux-nat.c (delete_lwp_cleanup): Delete.
5311         (struct lwp_deleter): New struct.
5312         (lwp_info_up): New typedef.
5313         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5314         lwp_info_up.
5315
5316 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5317
5318         * linux-fork.c (class scoped_switch_fork_info): New class.
5319         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5320
5321 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5322
5323         * valops.c (find_overload_match): Remove use of null_cleanup, and
5324         calls to do_cleanups.
5325
5326 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * compile/compile-cplus-types.c
5329         (compile_cplus_instance::decl_name): Handle changes to
5330         cp_func_name.
5331         * cp-support.c (cp_func_name): Update header comment, update
5332         return type.
5333         * cp-support.h (cp_func_name): Update return type in declaration.
5334         * valops.c (find_overload_match): Move temp_func local to top
5335         level of function and change its type.  Use temp_func to hold and
5336         delete temporary string obtained from cp_func_name.
5337
5338 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5339
5340         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5341         gdb::char_vector, remove cleanup, and update uses of `msg`.
5342
5343 2019-01-03  Jim Wilson  <jimw@sifive.com>
5344
5345         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5346
5347 2019-01-02  Tom Tromey  <tom@tromey.com>
5348
5349         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5350         (tdesc_parse_xml): Remove cleanups.
5351         * target-descriptions.h (make_cleanup_free_target_description):
5352         Don't declare.
5353         (target_desc_deleter): New struct.
5354         (target_desc_up): New typedef.
5355         * target-descriptions.c (target_desc_deleter::operator()): Rename
5356         from free_target_description.
5357         (make_cleanup_free_target_description): Remove.
5358
5359 2019-01-02  Tom Tromey  <tom@tromey.com>
5360
5361         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5362         constructor, destructor.
5363         (linespec_parser): Remove typedef.
5364         (~linespec_parser): Rename from linespec_parser_delete.
5365         (linespec_lex_to_end, linespec_complete_label)
5366         (linespec_complete): Update.
5367         (decode_line_full): Remove cleanups.
5368         (decode_line_1): Update.
5369
5370 2019-01-02  Tom Tromey  <tom@tromey.com>
5371
5372         * python/python-internal.h (inferior_to_inferior_object): Change
5373         return type.
5374         * python/py-exitedevent.c (create_exited_event_object): Update.
5375         * python/py-inferior.c (inferior_to_inferior_object): Return
5376         gdbpy_ref.
5377         (python_new_inferior, python_inferior_deleted)
5378         (thread_to_thread_object, delete_thread_object)
5379         (build_inferior_list, gdbpy_selected_inferior): Update.
5380         * python/py-infthread.c (create_thread_object): Update.  Also fail
5381         if inferior_to_inferior_object fails.
5382
5383 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5384
5385         * inferior.h (class inferior) <displaced_step_state>: New field.
5386         * infrun.h (struct displaced_step_state): Move here from
5387         infrun.c.  Initialize fields, add constructor.
5388         <inf>: Remove field.
5389         <reset>: New method.
5390         * infrun.c (struct displaced_step_inferior_state): Move to
5391         infrun.h.
5392         (displaced_step_inferior_states): Remove.
5393         (get_displaced_stepping_state): Adust.
5394         (displaced_step_in_progress_any_inferior): Adjust.
5395         (displaced_step_in_progress_thread): Adjust.
5396         (displaced_step_in_progress): Adjust.
5397         (add_displaced_stepping_state): Remove.
5398         (get_displaced_step_closure_by_addr): Adjust.
5399         (remove_displaced_stepping_state): Remove.
5400         (infrun_inferior_exit): Call displaced_step_state.reset.
5401         (use_displaced_stepping): Don't check for NULL.
5402         (displaced_step_prepare_throw): Call
5403         get_displaced_stepping_state.
5404         (displaced_step_fixup): Don't check for NULL.
5405         (prepare_for_detach): Don't check for NULL.
5406
5407 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5408
5409         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5410          in case of call that did not complete.
5411
5412 2019-01-02  Andrey Utkin  <autkin@undo.io>
5413
5414         * symfile.c (find_separate_debug_file): Fix search of debug files for
5415         remote debuggee.
5416
5417 2019-01-02  Tom Tromey  <tom@tromey.com>
5418
5419         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5420         indentation.
5421         * python/py-frame.c (frapy_older): Remove cast.
5422         (frapy_newer): Likewise.
5423         * python/py-breakpoint.c (local_setattro): Remove cast.
5424         * python/py-arch.c (archpy_name): Remove local variable.
5425         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5426
5427 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5428
5429         * unittests/basic_string_view/element_access/char/empty.cc:
5430         Fix year range in copyright header.
5431
5432 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5435         Delete.
5436         <operator==>: Update with for removed field.
5437         <hash>: Likewise.
5438         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5439         <isa_features>: ...this.
5440         <abi_features>: New field.
5441         (riscv_isa_flen): Update comment.
5442         (riscv_abi_xlen): New declaration.
5443         (riscv_abi_flen): New declaration.
5444         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5445         isa_features.
5446         (riscv_abi_xlen): New function.
5447         (riscv_isa_flen): Update to get answer from isa_features.
5448         (riscv_abi_flen): New function.
5449         (riscv_has_fp_abi): Update to get answer from abi_features.
5450         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5451         xlen and flen.
5452         (riscv_call_info) <xlen, flen>: Update comment.
5453         (riscv_call_arg_struct): Remove invalid assertions
5454         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5455         is removed.
5456         (riscv_gdbarch_init): Gather isa features and abi features
5457         separately, ensure both match on the gdbarch when reusing an old
5458         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5459         a target with 64-bit float hardware.
5460
5461 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5462
5463         * source.c (search_command_helper): Stop reverse search
5464         when line 1 has been searched.
5465
5466 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5467
5468         * record-full.c (record_full_base_target::close): Rewrite
5469         record_full_core_buf_list free logic.
5470
5471 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5472
5473         * break-catch-syscall.c (print_one_catch_syscall): xfree
5474         the last text.
5475
5476 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5477
5478         * top.c (print_gdb_version): Update Copyright year in version
5479         message.
5480
5481 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5482
5483         Update copyright year range in all GDB files.
5484
5485 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5486
5487         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5488
5489 For older changes see ChangeLog-2018.
5490 \f
5491 Local Variables:
5492 mode: change-log
5493 left-margin: 8
5494 fill-column: 74
5495 version-control: never
5496 coding: utf-8
5497 End:
5498