gdb/ChangeLog

   1 2019-03-29  Tom Tromey  <tromey@adacore.com>
   2
   3         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
   4         help text.  Remove dead code.
   5
   6 2019-03-29  Keith Seitz  <keiths@redhat.com>
   7
   8         From Siddhesh Poyarekar:
   9         * f-lang.h (f77_get_upperbound): Return LONGEST.
  10         (f77_get_lowerbound): Likewise.
  11         * f-typeprint.c (f_type_print_varspec_suffix): Expand
  12         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
  13         print them.
  14         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
  15         plongest to format print it.
  16         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
  17         (f77_get_upperbound): Likewise.
  18         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
  19         LOWER_BOUND to LONGEST.
  20         (f77_create_arrayprint_offset_tbl): Likewise.
  21
  22 2019-03-29  Keith Seitz  <keiths@redhat.com>
  23
  24         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
  25         %s/pulongest for TYPE_LENGTH instead of %d in format
  26         strings.
  27         * ada-typerint.c (ada_print_type): Likewise.
  28         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
  29         * compile/compile-c-support.c (generate_register_struct): Likewise.
  30         * gdbtypes.c (recursive_dump_type): Likewise.
  31         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  32         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
  33         instead of %d in format strings.
  34         * riscv-tdep.c (riscv_type_alignment): Cast second argument
  35         to std::min to ULONGEST.
  36         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
  37         instead of %d in format strings.
  38         * tracepoint.c (info_scope_command): Likewise.
  39         * typeprint.c (print_offset_data::update)
  40         (print_offset_data::finish): Likewise.
  41         * xtensa-tdep.c (xtensa_store_return_value)
  42         (xtensa_push_dummy_call): Likewise.
  43
  44 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
  45
  46         * windows-nat.c (display_selector): Fixed format specifications
  47         for 64-bit Cygwin.
  48
  49 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  50
  51         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
  52
  53 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
  54
  55         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
  56         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
  57         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
  58         (nios2_linux_init_abi): Install it.
  59
  60 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  61
  62         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
  63
  64 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  65
  66         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
  67
  68 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  69             Tom Tromey  <tromey@adacore.com>
  70
  71         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
  72
  73 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  74
  75         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  76         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  77         method to compute the bounds of range types. Also print "[evaluated]"
  78         if the bounds' values come from a dynamic evaluation.
  79
  80 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  81
  82         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  83         whitespace when pretty printing is on.
  84
  85 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  86
  87         * ppc-linux-nat.c: Add include.
  88
  89 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  90
  91         * NEWS: Mention AArch64 Pointer Authentication.
  92
  93 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  94
  95         * arm-linux-nat.c: Add include.
  96
  97 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  98
  99         * source-cache.c (source_cache::get_source_lines): Re-read
 100         fullname after calling open_source_file.
 101
 102 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 103
 104         * NEWS: Mention TLS support for FreeBSD.
 105
 106 2019-03-25  Tom Tromey  <tromey@adacore.com>
 107
 108         * minsyms.c (BUNCH_SIZE): Update comment.
 109         (~minimal_symbol_reader): Remove old comment.
 110         (compact_minimal_symbols): Update comment.
 111         (minimal_symbol_reader::install): Remove old comment.  Update
 112         other comments.
 113
 114 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 115
 116         * s390-linux-nat.c: Add include.
 117
 118 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 119
 120         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 121         Call linux_get_hwcap.
 122         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 123         Likewise.
 124         (aarch64_linux_get_hwcap): Remove function.
 125         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 126         declaration.
 127         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 128         linux_get_hwcap.
 129         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 130         * linux-tdep.c (linux_get_hwcap): Add function.
 131         (linux_get_hwcap2): Likewise.
 132         * linux-tdep.h (linux_get_hwcap): Add declaration.
 133         (linux_get_hwcap2): Likewise.
 134         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 135         (ppc_linux_get_hwcap2): Likewise.
 136         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 137         linux_get_hwcap.
 138         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 139         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 140         (ppc_linux_nat_target::read_description): Likewise.
 141         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 142         * s390-linux-nat.c: Likewise.
 143         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 144
 145 2019-03-24  Tom Tromey  <tom@tromey.com>
 146
 147         * ada-lang.c (standard_lookup): Simplify initialization.
 148         (ada_lookup_symbol_nonlocal): Simplify return.
 149         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 150         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 151         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 152         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 153         initialization.
 154         * solib.c (solib_global_lookup): Simplify.
 155         * symtab.c (null_block_symbol): Remove.
 156         (symbol_cache_lookup): Simplify returns.
 157         (lookup_language_this): Simplify returns.
 158         (lookup_symbol_aux): Simplify return.
 159         (lookup_local_symbol): Simplify returns.
 160         (lookup_global_symbol_from_objfile): Simplify return.
 161         (lookup_symbol_in_objfile_symtabs)
 162         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 163         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 164         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 165         * cp-namespace.c (cp_lookup_bare_symbol)
 166         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 167         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 168         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 169         (cp_lookup_symbol_via_imports): Simplify initialization.
 170         (find_symbol_in_baseclass): Likewise.
 171         * symtab.h (null_block_symbol): Remove.
 172         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 173         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 174         (d_lookup_symbol_module): Likewise.
 175         (find_symbol_in_baseclass): Simplify initialization.
 176
 177 2019-03-24  Tom Tromey  <tom@tromey.com>
 178
 179         * expression.h: Don't include symtab.h.
 180         (struct block): Forward declare.
 181
 182 2019-03-24  Tom Tromey  <tom@tromey.com>
 183
 184         * c-exp.y (typebase): Remove casts.
 185         * gdbtypes.c (lookup_unsigned_typename, )
 186         (lookup_signed_typename): Remove cast.
 187         * eval.c (parse_to_comma_and_eval): Remove cast.
 188         * parse.c (write_dollar_variable): Remove cast.
 189         * block.h (struct block) <superblock>: Now const.
 190         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 191         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 192         (map_block): Make "block" const.
 193         * symfile.h (struct quick_symbol_functions)
 194         <map_matching_symbols>: Constify block argument to "callback".
 195         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 196         const.
 197         (find_pc_sect_compunit_symtab): Make "b" const.
 198         (find_symbol_at_address): Likewise.
 199         (search_symbols): Likewise.
 200         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 201         (dw2_debug_names_lookup_symbol): Likewise.
 202         (dw2_map_matching_symbols): Update.
 203         * p-valprint.c (pascal_val_print): Remove "block".
 204         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 205         (aux_add_nonlocal_symbols): Make "block" const.
 206         (resolve_subexp): Remove cast.
 207         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 208         const.
 209         (iterate_over_file_blocks): Likewise.
 210         * f-exp.y (%union) <bval>: Remove.
 211         * coffread.c (patch_opaque_types): Make "b" const.
 212         * spu-tdep.c (spu_catch_start): Make "block" const.
 213         * c-valprint.c (print_unpacked_pointer): Remove "block".
 214         * symmisc.c (dump_symtab_1): Make "b" const.
 215         (block_depth): Make "block" const.
 216         * d-exp.y (%union) <bval>: Remove.
 217         * cp-support.h (cp_lookup_rtti_type): Update.
 218         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 219         * psymtab.c (psym_lookup_symbol): Make "block" const.
 220         (maintenance_check_psymtabs): Make "b" const.
 221         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 222         (enumerate_locals, enumerate_args): Update.
 223         * python/py-symtab.c (stpy_global_block): Make "block" const.
 224         (stpy_static_block): Likewise.
 225         * inline-frame.c (block_starting_point_at): Make "new_block"
 226         const.
 227         * block.c (find_block_in_blockvector): Make return type const.
 228         (blockvector_for_pc_sect): Make "b" const.
 229         (find_block_in_blockvector): Make "b" const.
 230
 231 2019-03-23  Tom Tromey  <tom@tromey.com>
 232
 233         * varobj.c (varobj_create): Update.
 234         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 235         * printcmd.c (display_command, do_one_display): Don't reset
 236         innermost_block.
 237         * parser-defs.h (enum innermost_block_tracker_type): Move to
 238         expression.h.
 239         (innermost_block): Update comment.
 240         * parse.c (parse_exp_1): Add tracker_types parameter.
 241         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 242         tracker_types parameter.  Reset innermost_block.
 243         (parse_exp_in_context): Remove.
 244         (parse_expression_for_completion): Update.
 245         * objfiles.c (~objfile): Don't reset expression_context_block or
 246         innermost_block.
 247         * expression.h (enum innermost_block_tracker_type): Move from
 248         parser-defs.h.
 249         (parse_exp_1): Add tracker_types parameter.
 250         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 251         reset innermost_block.
 252
 253 2019-03-23  Tom Tromey  <tom@tromey.com>
 254
 255         * objfiles.h: Include bcache.h.
 256
 257 2019-03-23  Tom Tromey  <tom@tromey.com>
 258
 259         * linespec.c (get_current_search_block): Use
 260         scoped_restore_current_language.
 261         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 262
 263 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 264             Jiong Wang  <jiong.wang@arm.com>
 265
 266         * aarch64-linux-tdep.c
 267         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 268         section.
 269         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 270
 271 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 272             Jiong Wang  <jiong.wang@arm.com>
 273
 274         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 275         instructions.
 276         (aarch64_analyze_prologue_test): Add PACIASP test.
 277         (aarch64_prologue_prev_register): Unmask PC value.
 278
 279 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 280             Jiong Wang  <jiong.wang@arm.com>
 281
 282         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 283         (aarch64_dwarf2_prev_register): Unmask PC value.
 284         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 285         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 286         DW_CFA_AARCH64_negate_ra_state.
 287         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 288
 289 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 290             Jiong Wang  <jiong.wang@arm.com>
 291
 292         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 293         registers.
 294         (aarch64_pseudo_register_name): Likewise.
 295         (aarch64_pseudo_register_type): Likewise.
 296         (aarch64_pseudo_register_reggroup_p): Likewise.
 297         (aarch64_gdbarch_init): Add pauth registers.
 298         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 299         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 300         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 301         (struct gdbarch_tdep): Add regnum for ra_state.
 302
 303 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 304             Jiong Wang  <jiong.wang@arm.com>
 305
 306         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 307
 308 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 309             Jiong Wang  <jiong.wang@arm.com>
 310
 311         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 312         function.
 313         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 314         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 315         (aarch64_gdbarch_init): Add puth registers.
 316         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 317         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 318         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 319
 320 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 321             Jiong Wang  <jiong.wang@arm.com>
 322
 323         * aarch64-linux-nat.c
 324         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 325         * aarch64-linux-tdep.c
 326         (aarch64_linux_core_read_description): Likewise.
 327         (aarch64_linux_get_hwcap): New function.
 328         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 329         (aarch64_linux_get_hwcap): New declaration.
 330
 331 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 332             Jiong Wang  <jiong.wang@arm.com>
 333
 334         * aarch64-linux-nat.c
 335         (aarch64_linux_nat_target::read_description): Add pauth param.
 336         * aarch64-linux-tdep.c
 337         (aarch64_linux_core_read_description): Likewise.
 338         * aarch64-tdep.c (struct target_desc): Add in pauth.
 339         (aarch64_read_description): Add pauth param.
 340         (aarch64_gdbarch_init): Likewise.
 341         * aarch64-tdep.h (aarch64_read_description): Likewise.
 342         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 343         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 344         * features/Makefile: Add new files.
 345         * features/aarch64-pauth.c: New file.
 346         * features/aarch64-pauth.xml: New file.
 347
 348 2019-03-20  Tom Tromey  <tromey@adacore.com>
 349
 350         * infrun.c (handle_inferior_event): Rename from
 351         handle_inferior_event_1.  Create a scoped_value_mark.
 352         (handle_inferior_event): Remove.
 353
 354 2019-03-19  Tom Tromey  <tromey@adacore.com>
 355
 356         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 357         * infrun.h (print_stop_event): Add "displays" parameter.
 358         * infrun.c (print_stop_event): Add "displays" parameter.
 359
 360 2019-03-19  Pedro Alves  <palves@redhat.com>
 361
 362         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 363         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 364         to -1.  Fix TABs vs spaces.
 365         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 366         * tui/tui-out.h (tui_ui_out) Add intro comments.
 367         <m_line, m_start_of_line>: In-class initialize, and add describing
 368         comment.
 369
 370 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 371
 372         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 373         variable names.
 374         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 375
 376 2019-03-18  Pedro Alves  <palves@redhat.com>
 377             Eli Zaretskii <eliz@gnu.org>
 378
 379         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 380         m_line and m_start_of_line.
 381
 382 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 383
 384         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 385         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 386         it returns a newline.  This fixes a regression in TU mode, whereby
 387         the next line is output on the same screen line as the user input.
 388
 389 2019-03-18  Tom Tromey  <tromey@adacore.com>
 390
 391         * minsyms.c (minimal_symbol_reader::install): Remove call to
 392         obstack_blank.
 393
 394 2019-03-18  Pedro Alves  <palves@redhat.com>
 395
 396         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 397         New globals.
 398         (apply_style): New, factored out from ...
 399         (apply_ansi_escape): ... this.  Handle reverse video mode.
 400         (tui_set_reverse_mode): New function.
 401         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 402         * tui/tui-winsource.c (tui_show_source_line): Use
 403         tui_set_reverse_mode instead of setting A_STANDOUT.
 404         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 405         New setter methods.
 406
 407 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 408
 409         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 410         Handle tabs.
 411
 412 2019-03-18  Tom Tromey  <tromey@adacore.com>
 413
 414         * ada-lang.c (empty_array): Add "high" parameter.
 415         (ada_evaluate_subexp): Update.
 416
 417 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 418
 419         * unittests/string_view-selftests.c: Define
 420         _initialize_string_view_selftests unconditionally.
 421
 422 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 423
 424         PR gdb/24350
 425         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 426
 427 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 428
 429         PR gdb/24351
 430         * windows-nat.c (display_selector): Fix format specifiers.
 431
 432 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 433
 434         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 435         tui_refill_source_window instead of tui_refresh_win, to update the
 436         current execution line.  This fixes redisplay of the current line
 437         when stepping through the code with "next" or "step".
 438
 439 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 440
 441         * source-cache.c (source_cache::get_source_lines): Call
 442         find_source_lines to initialize s->nlines.  This fixes vertical
 443         scrolling of TUI source window when the DOWN arrow is pressed.
 444
 445 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 446
 447         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 448         linux-thread-db.c (_initialize_thread_db): Likewise.
 449
 450 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 451
 452         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 453         wclrtoeol in tui_show_source_line".  This reverts changes made in
 454         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 455
 456 2019-03-15  Tom Tromey  <tom@tromey.com>
 457
 458         * symtab.h (struct minimal_symbol): Derive from
 459         general_symbol_info.
 460         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 461         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 462         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 463         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 464         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 465         (MSYMBOL_SEARCH_NAME): Update.
 466         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 467         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 468         * minsyms.c (minimal_symbol_reader::record_full): Update.
 469
 470 2019-03-15  Tom Tromey  <tom@tromey.com>
 471
 472         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 473
 474 2019-03-15  Tom Tromey  <tom@tromey.com>
 475
 476         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 477         unique_xmalloc_ptr.
 478         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 479         Update.
 480         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 481         (build_minimal_symbol_hash_tables)
 482         (minimal_symbol_reader::install): Update.
 483
 484 2019-03-15  Tom Tromey  <tom@tromey.com>
 485
 486         * symtab.c (create_demangled_names_hash): Update.
 487         (symbol_set_names): Update.
 488         * objfiles.h (struct objfile_per_bfd_storage)
 489         <demangled_names_hash>: Now an htab_up.
 490         * objfiles.c (objfile_per_bfd_storage): Simplify.
 491
 492 2019-03-15  Tom Tromey  <tom@tromey.com>
 493
 494         * objfiles.h (struct objfile_per_bfd_storage): Declare
 495         destructor.
 496         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 497         New.
 498         (get_objfile_bfd_data): Use new.  Don't initialize
 499         language_of_main.
 500         (free_objfile_per_bfd_storage): Remove.
 501         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 502
 503 2019-03-15  Tom Tromey  <tom@tromey.com>
 504
 505         * symfile.c (reread_symbols): Update.
 506         * objfiles.c (objfile::objfile): Update.
 507         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 508         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 509         comment.
 510         (minimal_symbol_reader::install): Update.
 511         (terminate_minimal_symbol_table): Remove.
 512         * jit.c (jit_object_close_impl): Update.
 513
 514 2019-03-15  Tom Tromey  <tom@tromey.com>
 515
 516         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 517         initializations.
 518
 519 2019-03-15  Tom Tromey  <tom@tromey.com>
 520
 521         * objfiles.h (struct objfile_per_bfd_storage)
 522         <demangled_hash_languages>: Now a bitset.
 523         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 524         (lookup_minimal_symbol): Update.
 525
 526 2019-03-15  Tom Tromey  <tom@tromey.com>
 527
 528         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 529         Don't return the symbol.
 530         * coffread.c (record_minimal_symbol): Use record_full.
 531
 532 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 533
 534         The MS-Windows port of ncurses fails to switch to a color pair if
 535         one or both of the colors are the implicit default colors.  This
 536         change records the default colors when TUI is initialized, and
 537         then specifies them explicitly when a color pair uses the default
 538         colors.  This allows color styling in TUI mode on MS-Windows.
 539
 540         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 541         ncurses_norm_attr.
 542         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 543         colors in ncurses_norm_attr.
 544         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 545         "none", replace it with the default color recorded in
 546         ncurses_norm_attr.
 547
 548 2019-03-14  Tom Tromey  <tromey@adacore.com>
 549
 550         * source-cache.h (class source_cache) <get_source_lines>: Return
 551         std::string.
 552         * source-cache.c (source_cache::extract_lines): Handle case where
 553         first_pos==npos.  Return std::string.
 554         (source_cache::get_source_lines): Update.
 555
 556 2019-03-14  Tom Tromey  <tromey@adacore.com>
 557
 558         * NEWS: Add item for "style sources" commands.
 559         * source-cache.c (source_cache::get_source_lines): Check
 560         source_styling.
 561         * cli/cli-style.c (source_styling): New global.
 562         (_initialize_cli_style): Add "style sources" commands.
 563         (show_style_sources): New function.
 564         * cli/cli-style.h (source_styling): Declare.
 565
 566 2019-03-14  Pedro Alves  <palves@redhat.com>
 567             Tom Tromey  <tromey@adacore.com>
 568
 569         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 570         * tui/tui-winsource.c (tui_refill_source_window): New function,
 571         from...
 572         (tui_horizontal_source_scroll): ... here.  Move some logic.
 573         * cli/cli-style.c (set_style_enabled): Notify new observable.
 574         * tui/tui-hooks.c (tui_redisplay_source): New function.
 575         (tui_attach_detach_observers): Attach or detach
 576         tui_redisplay_source.
 577         * observable.h (source_styling_changed): New observable.
 578         * observable.c: Define source_styling_changed observable.
 579
 580 2019-03-13  Tom Tromey  <tromey@adacore.com>
 581
 582         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 583         (i386_gnu_nat_target::store_registers): Update.
 584         * target-debug.h (target_debug_print_std_string): New macro.
 585         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 586         * windows-tdep.c (display_one_tib): Update.
 587         * tui/tui-stack.c (tui_make_status_line): Update.
 588         * top.c (print_inferior_quit_action): Update.
 589         * thread.c (thr_try_catch_cmd): Update.
 590         (add_thread_with_info): Update.
 591         (thread_target_id_str): Update.
 592         (thr_try_catch_cmd): Update.
 593         (thread_command): Update.
 594         (thread_find_command): Update.
 595         * record-btrace.c (record_btrace_target::info_record)
 596         (record_btrace_resume_thread, record_btrace_target::resume)
 597         (record_btrace_cancel_resume, record_btrace_step_thread)
 598         (record_btrace_target::wait, record_btrace_target::wait)
 599         (record_btrace_target::wait, record_btrace_target::stop): Update.
 600         * progspace.c (print_program_space): Update.
 601         * process-stratum-target.c
 602         (process_stratum_target::thread_address_space): Update.
 603         * linux-fork.c (linux_fork_mourn_inferior)
 604         (detach_checkpoint_command, info_checkpoints_command)
 605         (linux_fork_context): Update.
 606         (linux_fork_detach): Update.
 607         (class scoped_switch_fork_info): Update.
 608         (delete_checkpoint_command): Update.
 609         * infrun.c (follow_fork_inferior): Update.
 610         (follow_fork_inferior): Update.
 611         (proceed_after_vfork_done): Update.
 612         (handle_vfork_child_exec_or_exit): Update.
 613         (follow_exec): Update.
 614         (displaced_step_prepare_throw): Update.
 615         (displaced_step_restore): Update.
 616         (start_step_over): Update.
 617         (resume_1): Update.
 618         (clear_proceed_status_thread): Update.
 619         (proceed): Update.
 620         (print_target_wait_results): Update.
 621         (do_target_wait): Update.
 622         (context_switch): Update.
 623         (stop_all_threads): Update.
 624         (restart_threads): Update.
 625         (finish_step_over): Update.
 626         (handle_signal_stop): Update.
 627         (switch_back_to_stepped_thread): Update.
 628         (keep_going_pass_signal): Update.
 629         (print_exited_reason): Update.
 630         (normal_stop): Update.
 631         * inferior.c (inferior_pid_to_str): Change return type.
 632         (print_selected_inferior): Update.
 633         (add_inferior): Update.
 634         (detach_inferior): Update.
 635         * dummy-frame.c (fprint_dummy_frames): Update.
 636         * dcache.c (dcache_info_1): Update.
 637         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 638         (btrace_fetch, btrace_clear): Update.
 639         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 640         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 641         type.
 642         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 643         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 644         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 645         * gdbarch.c, gdbarch.h: Rebuild.
 646         * gdbarch.sh (core_pid_to_str): Change return type.
 647         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 648         return type.
 649         (windows_nat_target::pid_to_str): Change return type.
 650         (windows_delete_thread): Update.
 651         (windows_nat_target::attach): Update.
 652         (windows_nat_target::files_info): Update.
 653         * target-delegates.c: Rebuild.
 654         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 655         return type.
 656         (sol_thread_target::pid_to_str): Change return type.
 657         * remote.c (class remote_target) <pid_to_str>: Change return
 658         type.
 659         (remote_target::pid_to_str): Change return type.
 660         (extended_remote_target::attach, remote_target::remote_stop_ns)
 661         (remote_target::remote_notif_remove_queued_reply)
 662         (remote_target::push_stop_reply, remote_target::disable_btrace):
 663         Update.
 664         (extended_remote_target::attach): Update.
 665         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 666         type.
 667         (gdbsim_target::pid_to_str): Change return type.
 668         * ravenscar-thread.c (struct ravenscar_thread_target)
 669         <pid_to_str>: Change return type.
 670         (ravenscar_thread_target::pid_to_str): Change return type.
 671         * procfs.c (class procfs_target) <pid_to_str>: Change return
 672         type.
 673         (procfs_target::pid_to_str): Change return type.
 674         (procfs_target::attach): Update.
 675         (procfs_target::detach): Update.
 676         (procfs_target::fetch_registers): Update.
 677         (procfs_target::store_registers): Update.
 678         (procfs_target::wait): Update.
 679         (procfs_target::files_info): Update.
 680         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 681         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 682         return type.
 683         (nto_procfs_target::pid_to_str): Change return type.
 684         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 685         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 686         return type.
 687         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 688         (exit_lwp): Update.
 689         (attach_proc_task_lwp_callback, get_detach_signal)
 690         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 691         (linux_nat_target::resume, wait_lwp, stop_callback)
 692         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 693         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 694         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 695         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 696         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 697         type.
 698         (inf_ptrace_target::attach): Update.
 699         (inf_ptrace_target::files_info): Update.
 700         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 701         type.
 702         (go32_nat_target::pid_to_str): Change return type.
 703         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 704         (gnu_nat_target::wait): Update.
 705         (gnu_nat_target::wait): Update.
 706         (gnu_nat_target::resume): Update.
 707         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 708         (fbsd_nat_target::wait): Update.
 709         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 710         type.
 711         (darwin_nat_target::attach): Update.
 712         * corelow.c (class core_target) <pid_to_str>: Change return type.
 713         (core_target::pid_to_str): Change return type.
 714         * target.c (normal_pid_to_str): Change return type.
 715         (default_pid_to_str): Likewise.
 716         (target_pid_to_str): Change return type.
 717         (target_translate_tls_address): Update.
 718         (target_announce_detach): Update.
 719         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 720         return type.
 721         (bsd_uthread_target::pid_to_str): Change return type.
 722         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 723         type.
 724         (bsd_kvm_target::pid_to_str): Change return type.
 725         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 726         return type.
 727         (aix_thread_target::pid_to_str): Change return type.
 728         * target.h (struct target_ops) <pid_to_str>: Change return type.
 729         (target_pid_to_str, normal_pid_to_str): Likewise.
 730         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 731         type.
 732         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 733         type.
 734         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 735         return type.
 736         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 737         type.
 738         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 739         type.
 740         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 741         return type.
 742
 743 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 744
 745         * NEWS: Mention that the new default MI version is 3.  Mention
 746         changes to the output of commands and events that deal with
 747         multi-location breakpoints.
 748         * breakpoint.c: Include "mi/mi-out.h".
 749         (print_one_breakpoint): Change output syntax if using MI version
 750         >= 3.
 751         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 752         New.
 753         (mi_multi_location_breakpoint_output_fixed): New.
 754         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 755         (mi_cmd_fix_multi_location_breakpoint_output): New.
 756         (mi_multi_location_breakpoint_output_fixed): New.
 757         * mi/mi-cmds.c (mi_cmds): Register command
 758         -fix-multi-location-breakpoint-output.
 759         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 760         interpreter "mi".
 761
 762 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 763
 764         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 765         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 766         instantiate mi_ui_out based on interpreter name.
 767         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 768         * mi/mi-main.c (mi_load_progress): Likewise.
 769
 770 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 771
 772         * NEWS: Combine separate "New targets" sections for 8.3.
 773
 774 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 775
 776         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 777         (ppcfbsd_init_abi): Install gdbarch
 778         "fetch_tls_load_module_address" and "get_thread_local_address"
 779         methods.
 780
 781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 782
 783         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 784         (riscv_fbsd_init_abi): Install gdbarch
 785         "fetch_tls_load_module_address" and "get_thread_local_address"
 786         methods.
 787
 788 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 789
 790         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 791         (i386fbsd_init_abi): Install gdbarch
 792         "fetch_tls_load_module_address" and "get_thread_local_address"
 793         methods.
 794
 795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 796
 797         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 798         (amd64fbsd_init_abi): Install gdbarch
 799         "fetch_tls_load_module_address" and "get_thread_local_address"
 800         methods.
 801
 802 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 803
 804         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 805         (struct fbsd_pspace_data): New type.
 806         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 807         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 808         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 809         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 810         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 811
 812 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 813
 814         * gdbtypes.c (lookup_struct_elt): New function.
 815         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 816         * gdbtypes.h (struct struct_elt): New type.
 817         (lookup_struct_elt): New prototype.
 818
 819 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 820
 821         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 822         remove disabled code block.
 823
 824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 825
 826         * gdbarch.sh (get_thread_local_address): New method.
 827         * gdbarch.h, gdbarch.c: Regenerate.
 828         * target.c (target_translate_tls_address): Use
 829         gdbarch_get_thread_local_address if present instead of
 830         target::get_thread_local_address.
 831
 832 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 833
 834         * target.h (target::get_thread_local_address): Update comment.
 835
 836 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 837
 838         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 839         objfile->separate_debug_objfile_backlink if not NULL.
 840
 841 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 842
 843         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 844         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 845         (amd64bsd_store_inferior_registers): Likewise.
 846         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 847         Enable segment base registers.
 848         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 849         PT_GETFSBASE and PT_GETGSBASE.
 850         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 851         PT_SETGSBASE.
 852         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 853         segment base registers.
 854         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 855
 856 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 857
 858         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 859         Update calls to i386_target_description to add 'segments'
 860         parameter.
 861         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 862         add segment base registers.
 863         * arch/i386.c (i386_create_target_description): Add 'segments'
 864         parameter to enable segment base registers.
 865         * arch/i386.h (i386_create_target_description): Likewise.
 866         * features/i386/32bit-segments.xml: New file.
 867         * features/i386/32bit-segments.c: Generate.
 868         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 869         call to i386_target_description to add 'segments' parameter.
 870         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 871         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 872         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 873         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 874         if feature is present.
 875         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 876         Add 'segments' parameter to call to i386_target_description.
 877         (i386_target_description): Add 'segments' parameter to enable
 878         segment base registers.
 879         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 880         to call to i386_target_description.
 881         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 882         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 883         Define I386_NUM_REGS.
 884         (i386_target_description): Add 'segments' parameter to enable
 885         segment base registers.
 886
 887 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 888
 889         PR/24325
 890         * source-cache.c: #undef open and close, to avoid unresolved
 891         externals during linking.
 892
 893 2019-03-12  Tom Tromey  <tromey@adacore.com>
 894
 895         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 896         const.  Add initializers.
 897         (_initialize_remote): Don't initialize ptid globals.
 898
 899 2019-03-12  Pedro Alves  <palves@redhat.com>
 900
 901         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 902
 903 2019-03-12  Pedro Alves  <palves@redhat.com>
 904
 905         * cp-name-parser.y (main): Remove unused 'len' variable.
 906
 907 2019-03-12  Tom Tromey  <tromey@adacore.com>
 908
 909         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 910         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 911
 912 2019-03-12  Tom Tromey  <tromey@adacore.com>
 913
 914         * linux-nat.c (iterate_over_lwps): Update.
 915         (stop_callback): Remove parameter.
 916         (stop_wait_callback, detach_callback, resume_set_callback)
 917         (select_singlestep_lwp_callback, set_ignore_sigint)
 918         (status_callback, resumed_callback, resume_clear_callback)
 919         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 920         data parameter.
 921         (linux_nat_target::detach, linux_nat_target::resume)
 922         (linux_stop_and_wait_all_lwps, select_event_lwp)
 923         (linux_nat_filter_event, linux_nat_wait_1)
 924         (linux_nat_target::kill, linux_nat_target::stop)
 925         (linux_nat_target::stop): Update.
 926         (linux_nat_resume_callback): Change type.
 927         (resume_stopped_resumed_lwps, count_events_callback)
 928         (select_event_lwp_callback): Likewise.
 929         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 930         * arm-linux-nat.c (struct update_registers_data): Remove.
 931         (update_registers_callback): Change type.
 932         (arm_linux_insert_hw_breakpoint1): Update.
 933         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 934         parameter.
 935         (x86_linux_dr_set_addr): Update.
 936         (x86_linux_dr_set_control): Update.
 937         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 938         (iterate_over_lwps): Use gdb::function_view.
 939         * nat/aarch64-linux-hw-point.c (struct
 940         aarch64_dr_update_callback_param): Remove.
 941         (debug_reg_change_callback): Change type.
 942         (aarch64_notify_debug_reg_change): Update.
 943         * s390-linux-nat.c (s390_refresh_per_info): Update.
 944
 945 2019-03-11  Tom Tromey  <tromey@adacore.com>
 946
 947         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 948         redundant assignment to "this_cu".
 949
 950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 951
 952         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 953
 954 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 955
 956         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 957         from...
 958         (rank_one_type): ... this.
 959
 960 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 961
 962         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 963         from...
 964         (rank_one_type): ... this.
 965
 966 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 967
 968         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 969         from...
 970         (rank_one_type): ... this.
 971
 972 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 973
 974         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 975         from...
 976         (rank_one_type): ... this.
 977
 978 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 979
 980         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 981         from...
 982         (rank_one_type): ... this.
 983
 984 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 985
 986         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 987         from...
 988         (rank_one_type): ... this.
 989
 990 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 991
 992         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 993         from...
 994         (rank_one_type): ... this.
 995
 996 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 997
 998         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 999         from...
1000         (rank_one_type): ... this.
1001
1002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1003
1004         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1005         from...
1006         (rank_one_type): ... this.
1007
1008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1009
1010         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1011         from...
1012         (rank_one_type): ... this.
1013
1014 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1015
1016         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1017         from...
1018         (rank_one_type): ... this.
1019
1020 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1021
1022         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1023         from...
1024         (rank_one_type): ... this.
1025
1026 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1027
1028         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1029         inferior-events' shows the example events.
1030
1031 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1032
1033         Support styling on native MS-Windows console
1034
1035         PR/24315
1036         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1037         on MS-Windows if $TERM is not defined.
1038
1039         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1040
1041         * posix-hdep.c (gdb_console_fputs):
1042         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1043         functions.
1044         * ui-file.h (gdb_console_fputs): Add prototype.
1045
1046         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1047         back to fputs only if the former returns zero.
1048
1049 2019-03-07  Tom Tromey  <tom@tromey.com>
1050
1051         * symmisc.c (print_symbol_bcache_statistics): Update.
1052         (print_objfile_statistics): Update.
1053         * symfile.c (allocate_symtab): Update.
1054         * stabsread.c: Don't include bcache.h.
1055         * psymtab.h (struct psymbol_bcache): Don't declare.
1056         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1057         (psymbol_bcache_init, psymbol_bcache_free)
1058         (psymbol_bcache_get_bcache): Don't declare.
1059         * psymtab.c (struct psymbol_bcache): Remove.
1060         (psymtab_storage::psymtab_storage): Update.
1061         (psymtab_storage::~psymtab_storage): Update.
1062         (psymbol_bcache_init, psymbol_bcache_free)
1063         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1064         (add_psymbol_to_bcache): Update.
1065         (allocate_psymtab): Update.
1066         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1067         macro_cache>: No longer pointers.
1068         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1069         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1070         * macrotab.c (macro_bcache): Update.
1071         * macroexp.c: Don't include bcache.h.
1072         * gdbtypes.c (check_types_worklist): Update.
1073         (types_deeply_equal): Remove TRY/CATCH.  Update.
1074         * elfread.c (elf_symtab_read): Update.
1075         * dwarf2read.c: Don't include bcache.h.
1076         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1077         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1078         (print_bcache_statistics, bcache_memory_used): Don't declare.
1079         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1080         methods.  Rename all data members.
1081         * bcache.c (struct bcache): Move to bcache.h.
1082         (bcache::expand_hash_table): Rename from expand_hash_table.
1083         (bcache): Remove.
1084         (bcache::insert): Rename from bcache_full.
1085         (bcache::compare): Rename from bcache_compare.
1086         (bcache_xmalloc): Remove.
1087         (bcache::~bcache): Rename from bcache_xfree.
1088         (bcache::print_statistics): Rename from print_bcache_statistics.
1089         (bcache::memory_used): Rename from bcache_memory_used.
1090
1091 2019-03-07  Pedro Alves  <palves@redhat.com>
1092
1093         * infrun.c (normal_stop): Also check for
1094         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1095
1096 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * f-lang.c (value_from_host_double): Moved to...
1099         * value.c (value_from_host_double): ...here.
1100         * value.h (value_from_host_double): Declare.
1101         * guile/scm-math.c (vlscm_convert_typed_number): Use
1102         value_from_host_double.
1103         (vlscm_convert_number): Likewise.
1104         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1105         * python/py-value.c (convert_value_from_python): Likewise.
1106
1107 2019-03-06  Tom Tromey  <tom@tromey.com>
1108
1109         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1110
1111 2019-03-06  Tom Tromey  <tom@tromey.com>
1112
1113         * utils.h (free_current_contents): Don't declare.
1114         * utils.c (free_current_contents): Remove.
1115
1116 2019-03-06  Tom Tromey  <tom@tromey.com>
1117
1118         * top.c (quit_force): Update.
1119         * main.c (captured_command_loop): Update.
1120         * common/new-op.c (operator new): Update.
1121         * common/common-exceptions.c (struct catcher)
1122         <save_cleanup_chain>: Remove member.
1123         (exceptions_state_mc_init): Update.
1124         (exception_try_scope_entry): Return nullptr.
1125         (exception_try_scope_exit, exception_rethrow)
1126         (throw_exception_sjlj, throw_exception_cxx): Update.
1127         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1128         (all_cleanups, do_cleanups, discard_cleanups)
1129         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1130         (restore_cleanups, restore_final_cleanups): Don't declare.
1131         (do_final_cleanups): Remove parameter.
1132         * common/cleanups.c (cleanup_chain, make_cleanup)
1133         (make_cleanup_dtor, all_cleanups, do_cleanups)
1134         (discard_my_cleanups, discard_cleanups)
1135         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1136         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1137         (null_cleanup): Remove.
1138         (do_final_cleanups): Remove parameter.
1139
1140 2019-03-06  Tom Tromey  <tom@tromey.com>
1141
1142         * remote.c (remote_target::remote_parse_stop_reply): Use
1143         unique_xmalloc_ptr.
1144
1145 2019-03-06  Tom Tromey  <tom@tromey.com>
1146
1147         * stabsread.c (struct stabs_field_info): Rename from field_info.
1148         <list, fnlist>: Add initializers.
1149         <obstack>: New member.
1150         (read_member_functions, read_struct_fields, read_baseclasses):
1151         Allocate on obstack.  Don't use cleanups.
1152         (read_one_struct_field, read_member_functions, read_struct_fields)
1153         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1154         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1155         (read_struct_type): Update.
1156
1157 2019-03-06  Tom Tromey  <tom@tromey.com>
1158
1159         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1160         * common/filestuff.h (make_cleanup_close): Don't declare.
1161         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1162         Remove.
1163
1164 2019-03-06  Tom Tromey  <tom@tromey.com>
1165
1166         * solib-aix.c: Use make_scope_exit.
1167
1168 2019-03-06  Tom Tromey  <tom@tromey.com>
1169
1170         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1171         Use make_scope_exit.
1172
1173 2019-03-06  Tom Tromey  <tom@tromey.com>
1174
1175         * solib-svr4.c (disable_probes_interface): Remove parameter.
1176         (svr4_handle_solib_event): Use make_scope_exit.
1177
1178 2019-03-06  Tom Tromey  <tom@tromey.com>
1179
1180         * remote.c (struct stop_reply_deleter): Remove.
1181         (stop_reply_up): Update.
1182         (struct stop_reply): Derive from notif_event.  Don't typedef.
1183         <regcache>: Now a std::vector.
1184         (stop_reply_xfree): Remove.
1185         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1186         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1187         (remote_target::discard_pending_stop_replies): Use delete.
1188         (remote_target::remote_parse_stop_reply): Update.
1189         (remote_target::process_stop_reply): Update.
1190         * remote-notif.h (struct notif_event): Add virtual destructor.
1191         Remove "dtr" member.
1192         (struct notif_client) <alloc_event>: Return a unique_ptr.
1193         (notif_event_xfree): Don't declare.
1194         (notif_event_up): New typedef.
1195         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1196         (notif_event_xfree, do_notif_event_xfree): Remove.
1197         (remote_notif_state_xfree): Update.
1198
1199 2019-03-06  Tom Tromey  <tom@tromey.com>
1200
1201         * infrun.c (displaced_step_clear_cleanup): Now a
1202         forward_scope_exit type.
1203         (displaced_step_prepare_throw): Update.
1204         (displaced_step_fixup): Update.
1205
1206 2019-03-06  Tom Tromey  <tom@tromey.com>
1207
1208         * inferior.h (class inferior): Update comment.
1209         * gdbthread.h (class thread_info): Update comment.
1210
1211 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1212             Tom Tromey  <tom@tromey.com>
1213
1214         * stabsread.h (struct stab_section_list): Remove.
1215         (coffstab_build_psymtabs): Update.
1216         * dbxread.c (symbuf_sections): Now a std::vector.
1217         (sect_idx): New global.
1218         (fill_symbuf): Update.
1219         (coffstab_build_psymtabs): Change type of stabsects parameter.
1220         Update.
1221         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1222         std::vector.
1223         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1224         (coff_locate_sections): Update.
1225         (coff_symfile_read): Remove cleanups.  Update.
1226         (init_stringtab): Add storage parameter.
1227         (free_stringtab, free_stringtab_cleanup): Remove.
1228         (init_lineno): Add storage parameter.
1229         (free_linetab, free_linetab_cleanup): Remove.
1230
1231 2019-03-06  Pedro Alves  <palves@redhat.com>
1232
1233         * linux-fork.c (fork_info::clobber_regs): Delete.
1234         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1235         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1236         comment.  Adjust.
1237         (scoped_switch_fork_info::scoped_switch_fork_info)
1238         (checkpoint_command, linux_fork_context): Adjust
1239         fork_save_infrun_state calls.
1240
1241 2019-03-06  Pedro Alves  <palves@redhat.com>
1242
1243         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1244         (inf_has_multiple_threads): Return 'bool' and rewrite using
1245         inferior_info::threads().
1246
1247 2019-03-06  Pedro Alves  <palves@redhat.com>
1248
1249         * linux-fork.c: Include <list>.
1250         (fork_list): Now a std::list instance.
1251         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1252         (forks_exist_p, find_last_fork): Adjust.
1253         (new_fork): Delete.
1254         (one_fork_p): New.
1255         (add_fork): Adjust.
1256         (free_fork): Delete, folded into fork_info::~fork_info().
1257         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1258         Adjust.
1259         (init_fork_list): Delete.
1260         (linux_fork_killall, linux_fork_mourn_inferior)
1261         (linux_fork_detach, info_checkpoints_command): Adjust.
1262         (_initialize_linux_fork): No longer call init_fork_list.
1263
1264 2019-03-06  Pedro Alves  <palves@redhat.com>
1265
1266         * linux-fork.c (new_fork): New, split out of ...
1267         (add_fork): ... this.  Return void.  Move "first fork" special
1268         case from here, to ...
1269         (checkpoint_command): ... here.
1270         * linux-linux.h (add_fork): Return void.
1271
1272 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1273
1274         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1275
1276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1277             Chris January  <chris.january@arm.com>
1278             David Lecomber  <david.lecomber@arm.com>
1279
1280         * f-exp.y: New token, UNOP_INTRINSIC.
1281         (exp): New pattern using UNOP_INTRINSIC token.
1282         (f77_keywords): Add 'abs' keyword.
1283         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1284         (value_from_host_double): New function.
1285         (evaluate_subexp_f): Support UNOP_ABS.
1286
1287 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1290         types.
1291
1292 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1293
1294         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1295         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1296         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1297
1298 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1299
1300         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1301
1302 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1303             Chris January  <chris.january@arm.com>
1304
1305         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1306         * f-exp.y: Define 'KIND' token.
1307         (exp): New pattern for KIND expressions.
1308         (ptype): Handle types with a kind extension.
1309         (direct_abs_decl): Extend to spot kind extensions.
1310         (f77_keywords): Add 'kind' to the list.
1311         (push_kind_type): New function.
1312         (convert_to_kind_type): New function.
1313         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1314         * parse.c (operator_length_standard): Likewise.
1315         * parser-defs.h (enum type_pieces): Add tp_kind.
1316         * std-operator.def: Add UNOP_KIND.
1317
1318 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1319
1320         * f-exp.y (f_parse): Set yydebug.
1321
1322 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * f-lang.c (evaluate_subexp_f): New function.
1325         (exp_descriptor_f): New global.
1326         (f_language_defn): Use exp_descriptor_f instead of
1327         exp_descriptor_standard.
1328
1329 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * f-exp.y (struct token): Add comments.
1332         (dot_ops): Remove uppercase versions and the end marker.
1333         (f77_keywords): Likewise.
1334         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1335         entries in the dot_ops array are case insensitive, and use
1336         strncasecmp to compare strings.  Also some whitespace cleanup in
1337         this area.  Similar for the f77_keywords array, except entries in
1338         this list might be case sensitive.
1339
1340 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1341
1342         * f-exp.y (struct f77_boolean_val): Add comments.
1343         (boolean_values): Remove uppercase versions, and end marker.
1344         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1345         and use strncasecmp to achieve case insensitivity.  Additionally,
1346         perform whitespace cleanup around this code.
1347
1348 2019-03-06  Tom Tromey  <tromey@adacore.com>
1349
1350         * remote-sim.c (gdbsim_target_open): Use result of
1351         gdb_argv::release.
1352
1353 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1354         Dirk Schubert  <dirk.schubert@arm.com>
1355         Chris January  <chris.january@arm.com>
1356
1357         * eval.c (evaluate_subexp_standard): Call Fortran argument
1358         wrapping logic.
1359         * f-lang.c (struct value): A value which can be passed into a
1360         Fortran function call.
1361         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1362         where appropriate.
1363         (struct type): Value ready for a Fortran function call.
1364         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1365         is needed.
1366         * f-lang.h (fortran_argument_convert): Declaration.
1367         (fortran_preserve_arg_pointer): Declaration.
1368         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1369
1370 2019-03-05  Tom Tromey  <tromey@adacore.com>
1371
1372         * python/py-prettyprint.c (print_string_repr): Remove #if.
1373         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1374
1375 2019-03-05  Tom Tromey  <tromey@adacore.com>
1376
1377         * target.c (the_dummy_target): Move later.  Change type to
1378         "dummy_target".
1379         (initialize_targets): Don't initialize the_dummy_target.
1380
1381 2019-03-05  Tom Tromey  <tromey@adacore.com>
1382
1383         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1384         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1385
1386 2019-03-05  Tom Tromey  <tromey@adacore.com>
1387
1388         * windows-nat.c (windows_nat_target::attach)
1389         (windows_nat_target::detach): Don't call gdb_flush.
1390         * valprint.c (generic_val_print, val_print, val_print_string):
1391         Don't call gdb_flush.
1392         * utils.c (defaulted_query): Don't call gdb_flush.
1393         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1394         * target.c (target_announce_detach): Don't call gdb_flush.
1395         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1396         * remote.c (extended_remote_target::attach): Don't call
1397         gdb_flush.
1398         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1399         * printcmd.c (do_examine): Don't call gdb_flush.
1400         (info_display_command): Don't call gdb_flush.
1401         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1402         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1403         * memattr.c (info_mem_command): Don't call gdb_flush.
1404         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1405         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1406         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1407         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1408         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1409         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1410         (gnu_nat_target::detach): Don't call gdb_flush.
1411         * f-valprint.c (f_val_print): Don't call gdb_flush.
1412         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1413         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1414         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1415         gdb_flush.
1416         * c-valprint.c (c_val_print): Don't call gdb_flush.
1417         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1418
1419 2019-03-05  Tom Tromey  <tromey@adacore.com>
1420
1421         * varobj.c (update_dynamic_varobj_children): Update.
1422         (install_default_visualizer): Use reset, not release.
1423         * value.c (set_internalvar): Update.
1424         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1425         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1426         ATTRIBUTE_UNUSED_RESULT.
1427
1428 2019-03-05  Tom Tromey  <tromey@adacore.com>
1429
1430         * remote.c (class scoped_remote_fd) <release>: Add
1431         ATTRIBUTE_UNUSED_RESULT.
1432
1433 2019-03-05  Tom Tromey  <tromey@adacore.com>
1434
1435         * macroexp.c (struct macro_buffer) <release>: Add
1436         ATTRIBUTE_UNUSED_RESULT.
1437
1438 2019-03-05  Tom Tromey  <tromey@adacore.com>
1439
1440         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1441         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1442         ATTRIBUTE_UNUSED_RESULT.
1443
1444 2019-03-05  Tom Tromey  <tromey@adacore.com>
1445
1446         * common/scoped_fd.h (class scoped_fd) <release>: Add
1447         ATTRIBUTE_UNUSED_RESULT.
1448
1449 2019-03-05  Tom Tromey  <tromey@adacore.com>
1450
1451         * parser-defs.h (struct parser_state) <release>: Add
1452         ATTRIBUTE_UNUSED_RESULT.
1453
1454 2019-03-05  Tom Tromey  <tromey@adacore.com>
1455
1456         * utils.h (class gdb_argv) <release>: Add
1457         ATTRIBUTE_UNUSED_RESULT.
1458         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1459
1460 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1461
1462         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1463         for-loop range, to avoid compiler warnings.
1464
1465         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1466         avoid compiler warnings about unused variables.
1467
1468         * NEWS: Mention end of support for native debugging on MS-Windows
1469         before XP.
1470
1471         PR gdb/24292
1472         * common/netstuff.c:
1473         * gdbserver/gdbreplay.c
1474         * gdbserver/remote-utils.c:
1475         * ser-tcp.c:
1476         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1477         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1478         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1479         'getaddrinfo' and 'freeaddrinfo' were not available before
1480         Windows XP, and mingw.org's MinGW headers by default define
1481         _WIN32_WINNT to 0x500.
1482
1483 2019-03-01  Gary Benson <gbenson@redhat.com>
1484
1485         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1486
1487 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1488             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1489
1490         PR gdb/8527
1491         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1492         set_sigint_trap, clear_sigint_trap.
1493
1494 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1495
1496         * target.c (target_detach): Clear the regcache and the
1497         frame cache.
1498
1499 2019-02-27  Pedro Alves  <palves@redhat.com>
1500
1501         * utils.c (set_screen_size): When we cap the height/width sizes,
1502         tweak the corresponding command variable to show "unlimited":
1503
1504 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1505             Pedro Alves  <palves@redhat.com>
1506
1507         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1508         before calling rl_set_screen_size.
1509
1510 2019-02-27  Tom Tromey  <tromey@adacore.com>
1511
1512         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1513         define.
1514         * python/py-value.c: Remove Python 2.4 workaround.
1515         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1516         workaround.
1517         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1518         Python 2.4 workaround.
1519         * python/python-internal.h: Remove Python 2.4 comment.
1520         (Py_ssize_t): Don't define.
1521         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1522         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1523         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1524         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1525         * python/python.c (do_start_initialization): Remove Python 2.4
1526         workaround.
1527         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1528         (print_children): Remove Python 2.4 workaround.
1529         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1530         workaround.
1531         (CHARBUFFERPROC_NAME): Remove.
1532         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1533         Python 2.4 workaround.
1534
1535 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1536
1537         * NEWS: Note minimum Python version.
1538
1539 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1540
1541         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1542         code from these functions.  Remove corresponding ifdefs.  Use
1543         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1544         Remove gotos and target of gotos.
1545         (infpy_search_memory): Likewise.
1546
1547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1548
1549         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1550         (hppa_gdbarch_init): Don't register deleted functions with
1551         gdbarch.
1552
1553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1554
1555         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1556         (h8300_unwind_sp): Delete.
1557         (h8300_dummy_id): Delete.
1558         (h8300_gdbarch_init): Don't register deleted functions with
1559         gdbarch.
1560
1561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1564         (ft32_unwind_pc): Delete.
1565         (ft32_unwind_sp): Delete.
1566         (ft32_gdbarch_init): Don't register deleted functions with
1567         gdbarch.
1568
1569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1570
1571         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1572         (frv_unwind_pc): Delete.
1573         (frv_unwind_sp): Delete.
1574         (frv_gdbarch_init): Don't register deleted functions with
1575         gdbarch.
1576
1577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1578
1579         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1580         (riscv_unwind_pc): Delete.
1581         (riscv_unwind_sp): Delete.
1582         (riscv_gdbarch_init): Don't register deleted functions with
1583         gdbarch.
1584
1585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1588         (csky_unwind_pc): Delete.
1589         (csky_unwind_sp): Delete.
1590         (csky_gdbarch_init): Don't register deleted functions with
1591         gdbarch.
1592
1593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1594
1595         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1596         (cris_unwind_pc): Delete.
1597         (cris_unwind_sp): Delete.
1598         (cris_gdbarch_init): Don't register deleted functions with
1599         gdbarch.
1600
1601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1602
1603         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1604         (bfin_unwind_pc): Delete.
1605         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1606
1607 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1610         (arm_unwind_pc): Delete.
1611         (arm_unwind_sp): Delete.
1612         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1613
1614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1615
1616         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1617         (arc_unwind_pc): Delete.
1618         (arc_unwind_sp): Delete.
1619         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1620
1621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1622
1623         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1624         (alpha_unwind_pc): Delete.
1625         (alpha_gdbarch_init): Don't register deleted functions with
1626         gdbarch.
1627
1628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1629
1630         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1631         (aarch64_unwind_pc): Delete.
1632         (aarch64_unwind_sp): Delete.
1633         (aarch64_gdbarch_init): Don't register deleted functions with
1634         gdbarch.
1635
1636 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1637
1638         * gdbtypes.c (type_align): Don't consider static members when
1639         computing structure alignment.
1640
1641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1644         return 0 for other types.
1645         * arch-utils.c (default_type_align): Always return 0.
1646         * gdbarch.h: Regenerate.
1647         * gdbarch.sh (type_align): Extend comment.
1648         * gdbtypes.c (type_align): Add additional comments, always call
1649         gdbarch_type_align before applying the default rules.
1650         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1651         generic code will then apply a suitable default.
1652         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1653         types, return 0 for other types.
1654
1655 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1656
1657         * NEWS: Create a new section for the next release branch.
1658         Rename the section of the current branch, now that it has
1659         been cut.
1660
1661 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1662
1663         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1664         * version.in: Bump version to 8.3.50.DATE-git.
1665
1666 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1667
1668         * aix-thread.c (ptid_cmp): Remove unused variable.
1669         (get_signaled_thread): Likewise.
1670         (store_regs_user_thread): Likewise.
1671         (store_regs_kernel_thread): Likewise.
1672         (fetch_regs_kernel_thread): Remove shadowed variable.
1673
1674 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1675
1676         * features/riscv/32bit-cpu.xml: Add register numbers.
1677         * features/riscv/32bit-fpu.c: Regenerate.
1678         * features/riscv/32bit-fpu.xml: Add register numbers.
1679         * features/riscv/64bit-cpu.xml: Add register numbers.
1680         * features/riscv/64bit-fpu.c: Regenerate.
1681         * features/riscv/64bit-fpu.xml: Add register numbers.
1682
1683 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1684
1685         * NEWS: Mention two argument form of gdb.Value constructor.
1686         * python/py-value.c (convert_buffer_and_type_to_value): New
1687         function.
1688         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1689         Add support for handling an optional second argument.  Call
1690         convert_buffer_and_type_to_value as appropriate.
1691         * python/python-internal.h (Py_buffer_deleter): New struct.
1692         (Py_buffer_up): New typedef.
1693
1694 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1695
1696         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1697         instead of releasing ownership.
1698
1699 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1700
1701         * dwarf2read.c (open_and_init_dwp_file): Call
1702         elf_numsections instead of bfd_count_sections to initialize
1703         dwp_file->num_sections.
1704
1705 2019-02-25  Tom Tromey  <tromey@adacore.com>
1706
1707         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1708
1709 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1710
1711         * gcore.in: Add '--readnever' option when invoking GDB.
1712
1713 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1714
1715         * MAINTAINERS: Update my email address.
1716
1717 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1718
1719         * build-id.c (build_id_to_debug_bfd_1): New function.
1720         (build_id_to_debug_bfd): Look for separate debug file in
1721         sysroot.
1722
1723 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1724
1725         * gdbarch.sh: Update the copyright year range that is placed into
1726         generated files.
1727
1728 2019-02-22  Keith Seitz  <keiths@redhat.com>
1729
1730         PR symtab/23853
1731         * linespec.c (create_sals_line_offset): Search for the default
1732         symtab's filename instead of its fullname.
1733
1734 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1735
1736         * NEWS: Update style defaults.
1737
1738 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1739
1740         * main.c (captured_main_1): Disable styling in batch mode.
1741
1742 2019-02-20  Tom Tromey  <tom@tromey.com>
1743
1744         * symtab.c (symtab_symbol_info): Fix typos.
1745
1746 2019-02-20  Tom Tromey  <tromey@adacore.com>
1747
1748         * findcmd.c (_initialize_mem_search): Use upper case for
1749         metasyntactic variables.
1750
1751 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1752
1753         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1754         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1755
1756 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1757
1758         * top.h (source_file_name): Change to std::string.
1759         * top.c (source_file_name): Likewise.
1760         (command_line_input): Adjust.
1761         * cli/cli-script.c (script_from_file): Adjust.
1762
1763 2019-02-19  Tom Tromey  <tromey@adacore.com>
1764
1765         * ravenscar-thread.c
1766         (ravenscar_thread_target::update_thread_list): Don't call
1767         ada_build_task_list.
1768         * ada-lang.h (ada_build_task_list): Don't declare.
1769         * ada-tasks.c (struct ada_tasks_inferior_data)
1770         <task_list_valid_p>: Now bool.
1771         (read_known_tasks, ada_task_list_changed)
1772         (ada_tasks_invalidate_inferior_data): Update.
1773         (read_known_tasks_array): Return bool.
1774         (read_known_tasks_list): Likewise.
1775         (read_known_tasks): Return void.
1776         (ada_build_task_list): Now static.
1777
1778 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1779
1780         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1781         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1782
1783 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1784
1785         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1786         variant for ada_tasks_pspace_data_handle and
1787         ada_tasks_inferior_data_handle.
1788         (ada_tasks_pspace_data_cleanup): New function.
1789         (ada_tasks_inferior_data_cleanup): New function.
1790
1791 2019-02-17  Tom Tromey  <tom@tromey.com>
1792
1793         * macrotab.h (macro_source_fullname): Return a std::string.
1794         * macrotab.c (macro_include, check_for_redefinition)
1795         (macro_undef, macro_lookup_definition, foreach_macro)
1796         (foreach_macro_in_scope): Update.
1797         (macro_source_fullname): Return a std::string.
1798         * macrocmd.c (show_pp_source_pos): Update.
1799
1800 2019-02-17  Tom Tromey  <tom@tromey.com>
1801
1802         * macrocmd.c (show_pp_source_pos): Style the file names.
1803
1804 2019-02-17  Tom Tromey  <tom@tromey.com>
1805
1806         PR tui/24197:
1807         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1808
1809 2019-02-17  Tom Tromey  <tom@tromey.com>
1810
1811         * ada-lang.c (user_select_syms): Use filtered printing.
1812         * utils.c (wrap_style): New global.
1813         (desired_style): Remove.
1814         (emit_style_escape): Add stream parameter.
1815         (set_output_style, reset_terminal_style, prompt_for_continue):
1816         Update.
1817         (flush_wrap_buffer): Only flush gdb_stdout.
1818         (wrap_here): Set wrap_style.
1819         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1820         treat escape sequences as a character.  Change when wrap buffer is
1821         flushed.
1822         (fputs_styled): Do not set the output style when the default is
1823         requested.
1824         * ui-style.h (struct ui_file_style) <is_default>: New method.
1825         * source.c (print_source_lines_base): Emit escape sequences in one
1826         piece.
1827
1828 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1829
1830         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1831         integers and enumeration types.
1832
1833 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1834
1835         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1836         instead of lookup_symbol_in_language
1837         (do_exact_match): New function.
1838         (ada_get_symbol_name_matcher): Return do_exact_match when
1839         doing a verbatim match.
1840
1841 2019-02-15  Tom Tromey  <tromey@adacore.com>
1842
1843         * ravenscar-thread.c (ravenscar_thread_target::resume)
1844         (ravenscar_thread_target::wait): Special case wildcard requests.
1845
1846 2019-02-15  Tom Tromey  <tromey@adacore.com>
1847
1848         * ravenscar-thread.c (base_ptid): Remove.
1849         (struct ravenscar_thread_target) <close>: New method.
1850         <m_base_ptid>: New member.
1851         <update_inferior_ptid, active_task, task_is_currently_active,
1852         runtime_initialized>: Declare methods.
1853         <ravenscar_thread_target>: Add constructor.
1854         (ravenscar_thread_target::task_is_currently_active)
1855         (ravenscar_thread_target::update_inferior_ptid)
1856         (ravenscar_runtime_initialized): Rename.  Now methods.
1857         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1858         (ravenscar_thread_target::update_thread_list): Update.
1859         (ravenscar_thread_target::active_task): Now method.
1860         (ravenscar_thread_target::store_registers)
1861         (ravenscar_thread_target::prepare_to_store)
1862         (ravenscar_thread_target::prepare_to_store)
1863         (ravenscar_thread_target::mourn_inferior): Update.
1864         (ravenscar_inferior_created): Use "new" to create target.
1865         (ravenscar_thread_target::get_ada_task_ptid): Update.
1866         (_initialize_ravenscar): Don't initialize base_ptid.
1867         (ravenscar_ops): Remove global.
1868
1869 2019-02-15  Tom Tromey  <tromey@adacore.com>
1870
1871         * target.h (push_target): Declare new overload.
1872         * target.c (push_target): New overload, taking an rvalue reference.
1873         * remote.c (remote_target::open_1): Use push_target overload.
1874         * corelow.c (core_target_open): Use push_target overload.
1875
1876 2019-02-15  Tom Tromey  <tromey@adacore.com>
1877
1878         * ravenscar-thread.c (is_ravenscar_task)
1879         (ravenscar_task_is_currently_active): Return bool.
1880         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1881         (_initialize_ravenscar): Remove "(void)".
1882         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1883         Return bool.
1884
1885 2019-02-15  Tom Tromey  <tromey@adacore.com>
1886
1887         * ravenscar-thread.c (ravenscar_runtime_initializer)
1888         (has_ravenscar_runtime, get_running_thread_id)
1889         (ravenscar_thread_target::resume): Fix indentation.
1890
1891 2019-02-15  Tom Tromey  <tromey@adacore.com>
1892
1893         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1894         from ravenscar_arch_ops.
1895         (sparc_ravenscar_ops::fetch_registers)
1896         (sparc_ravenscar_ops::store_registers): Now methods.
1897         (sparc_ravenscar_prepare_to_store): Remove.
1898         (sparc_ravenscar_ops): Redefine.
1899         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1900         methods and destructor.  Remove members.
1901         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1902         (ravenscar_thread_target::store_registers)
1903         (ravenscar_thread_target::prepare_to_store): Update.
1904         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1905         Remove.
1906         (struct ppc_ravenscar_powerpc_ops): Derive from
1907         ravenscar_arch_ops.
1908         (ppc_ravenscar_powerpc_ops::fetch_registers)
1909         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1910         (ppc_ravenscar_powerpc_ops): Redefine.
1911         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1912         (ppc_ravenscar_e500_ops::fetch_registers)
1913         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1914         (ppc_ravenscar_e500_ops): Redefine.
1915         * aarch64-ravenscar-thread.c
1916         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1917         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1918         (aarch64_ravenscar_fetch_registers)
1919         (aarch64_ravenscar_store_registers): Now methods.
1920         (aarch64_ravenscar_ops): Redefine.
1921
1922 2019-02-15  Tom Tromey  <tromey@adacore.com>
1923
1924         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1925         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1926         (ravenscar_thread_target::stopped_by_watchpoint)
1927         (ravenscar_thread_target::stopped_data_address)
1928         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1929
1930 2019-02-15  Tom Tromey  <tromey@adacore.com>
1931
1932         * ravenscar-thread.c: Fix some typos.
1933
1934 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1935             Tom Tromey  <tromey@adacore.com>
1936
1937         * ada-lang.c (ada_exception_sal): Change addr_string to a
1938         std::string.
1939         (create_ada_exception_catchpoint): Update.
1940
1941 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1942             Tom Tromey  <tromey@adacore.com>
1943
1944         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1945         (bp_location_ops): Remove.
1946         (base_breakpoint_allocate_location): Update.
1947         (free_bp_location): Update.
1948         * ada-lang.c (class ada_catchpoint_location)
1949         <ada_catchpoint_location>: Remove ops parameter.
1950         (ada_catchpoint_location_dtor): Remove.
1951         (ada_catchpoint_location_ops): Remove.
1952         (allocate_location_exception): Update.
1953         * breakpoint.h (struct bp_location_ops): Remove.
1954         (class bp_location) <bp_location>: Remove bp_location_ops
1955         parameter.
1956         <~bp_location>: Add destructor.
1957         <ops>: Remove.
1958
1959 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1960             Pedro Alves  <palves@redhat.com>
1961
1962         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1963         'PATH_MAX'.
1964
1965 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1966             Samuel Thibault  <samuel.thibault@gnu.org>
1967             Thomas Schwinge  <thomas@codesourcery.com>
1968
1969         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1970         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1971
1972 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1973
1974         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1975         (check_empty): Use "const char *".
1976
1977         * gnu-nat.c (gnu_nat_target::detach): Instead of
1978         'detach_inferior (pid)' call
1979         'detach_inferior (find_inferior_pid (pid))'.
1980
1981         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1982         'nat/fork-inferior.o'.
1983         * gnu-nat.c: #include "nat/fork-inferior.h".
1984
1985         * gnu-nat.c (gnu_nat_target::detach): Instead of
1986         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1987         * gnu-nat.h: #include "inf-child.h".
1988         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1989         'i386_gnu_nat_target::fetch_registers'.
1990         (gnu_store_registers): Rename/move to
1991         'i386_gnu_nat_target::store_registers'.
1992
1993         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1994         * gnu-nat.h (mach_thread_info): New function.
1995         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1996
1997         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1998
1999 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2000
2001         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2002
2003 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2004
2005         * windows-nat.c (windows_add_thread): Add new parameter
2006         "main_thread_p" with default value set to false.  Update
2007         function documentation as well as all callers.
2008         (windows_delete_thread): Likewise.
2009         (fake_create_process): Update call to windows_add_thread.
2010         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2011         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2012         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2013         call to windows_delete_thread.
2014
2015 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2016
2017         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2018
2019 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2020
2021         * symfile.c (find_separate_debug_file): Use canonical path of
2022         sysroot with child_path instead of gdb_sysroot if it is valid.
2023
2024 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2025
2026         * symfile.c (find_separate_debug_file): Use child_path to
2027         determine if an object file is under a sysroot.
2028
2029 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2030
2031         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2032         unittests/child-path-selftests.c.
2033         * common/pathstuff.c (child_path): New function.
2034         * common/pathstuff.h (child_path): New prototype.
2035         * unittests/child-path-selftests.c: New file.
2036
2037 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2038
2039         * symfile.c (find_separate_debug_file): Look for separate debug
2040         files in debug directories under the sysroot.
2041
2042 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2043
2044         * symtab.h (struct minimal_symbol data_p): New const method.
2045         (struct minimal_symbol text_p): Likewise.
2046         * symtab.c (output_source_filename): Use file name style
2047         to print file name.
2048         (print_symbol_info): Likewise.
2049         (print_msymbol_info): Use address style to print addresses.
2050         Use function name style to print executable text symbols.
2051         (expand_symtab_containing_pc): Use data_p.
2052         (find_pc_sect_compunit_symtab): Likewise.
2053
2054 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2055
2056         * breakpoint.c (describe_other_breakpoints): Use address style
2057         to print addresses.
2058         (say_where): Likewise.
2059
2060 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2061
2062         * ada-typeprint.c (print_func_type): Print function name
2063         style to print function name.
2064         * c-typeprint.c (c_print_type_1): Likewise.
2065
2066 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2067
2068         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2069         for execve.
2070
2071 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2072
2073         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2074         type_stack.
2075
2076 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2077
2078         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2079         TYPE_CODE_REF types.
2080
2081 2019-02-08  Jim Wilson  <jimw@sifive.com>
2082
2083         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2084         (riscv_linux_fregset): New.
2085         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2086
2087 2019-02-07  Tom Tromey  <tom@tromey.com>
2088
2089         * thread.c (thread_cancel_execution_command): Update.
2090         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2091         methods.
2092         (struct thread_fsm_ops): Remove.
2093         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2094         (thread_fsm_should_stop, thread_fsm_return_value)
2095         (thread_fsm_set_finished, thread_fsm_finished_p)
2096         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2097         Don't declare.
2098         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2099         * infrun.c (clear_proceed_status_thread)
2100         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2101         (print_stop_event): Update.
2102         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2103         Add constructor.
2104         (step_command_fsm_ops): Remove.
2105         (new_step_command_fsm): Remove.
2106         (step_1): Update.
2107         (step_command_fsm::should_stop): Rename from
2108         step_command_fsm_should_stop.
2109         (step_command_fsm::clean_up): Rename from
2110         step_command_fsm_clean_up.
2111         (step_command_fsm::do_async_reply_reason): Rename from
2112         step_command_fsm_async_reply_reason.
2113         (struct until_next_fsm): Inherit from thread_fsm.  Add
2114         constructor.
2115         (until_next_fsm_ops): Remove.
2116         (new_until_next_fsm): Remove.
2117         (until_next_fsm::should_stop): Rename from
2118         until_next_fsm_should_stop.
2119         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2120         (until_next_fsm::do_async_reply_reason): Rename from
2121         until_next_fsm_async_reply_reason.
2122         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2123         constructor.  Change type of breakpoint.
2124         (finish_command_fsm_ops): Remove.
2125         (new_finish_command_fsm): Remove.
2126         (finish_command_fsm::should_stop): Rename from
2127         finish_command_fsm_should_stop.
2128         (finish_command_fsm::clean_up): Rename from
2129         finish_command_fsm_clean_up.
2130         (finish_command_fsm::return_value): Rename from
2131         finish_command_fsm_return_value.
2132         (finish_command_fsm::do_async_reply_reason): Rename from
2133         finish_command_fsm_async_reply_reason.
2134         (finish_command): Update.
2135         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2136         Add constructor.
2137         (call_thread_fsm_ops): Remove.
2138         (call_thread_fsm::call_thread_fsm): Rename from
2139         new_call_thread_fsm.
2140         (call_thread_fsm::should_stop): Rename from
2141         call_thread_fsm_should_stop.
2142         (call_thread_fsm::should_notify_stop): Rename from
2143         call_thread_fsm_should_notify_stop.
2144         (run_inferior_call, call_function_by_hand_dummy): Update.
2145         * cli/cli-interp.c (should_print_stop_to_console): Update.
2146         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2147         Add constructor.  Change type of location_breakpoint,
2148         caller_breakpoint.
2149         (until_break_fsm_ops): Remove.
2150         (new_until_break_fsm): Remove.
2151         (until_break_fsm::should_stop): Rename from
2152         until_break_fsm_should_stop.
2153         (until_break_fsm::clean_up): Rename from
2154         until_break_fsm_clean_up.
2155         (until_break_fsm::do_async_reply_reason): Rename from
2156         until_break_fsm_async_reply_reason.
2157         (until_break_command): Update.
2158         * thread-fsm.c: Remove.
2159         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2160
2161 2019-02-07  Tom Tromey  <tom@tromey.com>
2162
2163         * yy-remap.h: Add include guard.
2164         * xtensa-tdep.h: Add include guard.
2165         * xcoffread.h: Rename include guard.
2166         * varobj-iter.h: Add include guard.
2167         * tui/tui.h: Rename include guard.
2168         * tui/tui-winsource.h: Rename include guard.
2169         * tui/tui-wingeneral.h: Rename include guard.
2170         * tui/tui-windata.h: Rename include guard.
2171         * tui/tui-win.h: Rename include guard.
2172         * tui/tui-stack.h: Rename include guard.
2173         * tui/tui-source.h: Rename include guard.
2174         * tui/tui-regs.h: Rename include guard.
2175         * tui/tui-out.h: Rename include guard.
2176         * tui/tui-layout.h: Rename include guard.
2177         * tui/tui-io.h: Rename include guard.
2178         * tui/tui-hooks.h: Rename include guard.
2179         * tui/tui-file.h: Rename include guard.
2180         * tui/tui-disasm.h: Rename include guard.
2181         * tui/tui-data.h: Rename include guard.
2182         * tui/tui-command.h: Rename include guard.
2183         * tic6x-tdep.h: Add include guard.
2184         * target/waitstatus.h: Rename include guard.
2185         * target/wait.h: Rename include guard.
2186         * target/target.h: Rename include guard.
2187         * target/resume.h: Rename include guard.
2188         * target-float.h: Rename include guard.
2189         * stabsread.h: Add include guard.
2190         * rs6000-tdep.h: Add include guard.
2191         * riscv-fbsd-tdep.h: Add include guard.
2192         * regformats/regdef.h: Rename include guard.
2193         * record.h: Rename include guard.
2194         * python/python.h: Rename include guard.
2195         * python/python-internal.h: Rename include guard.
2196         * python/py-stopevent.h: Rename include guard.
2197         * python/py-ref.h: Rename include guard.
2198         * python/py-record.h: Rename include guard.
2199         * python/py-record-full.h: Rename include guard.
2200         * python/py-record-btrace.h: Rename include guard.
2201         * python/py-instruction.h: Rename include guard.
2202         * python/py-events.h: Rename include guard.
2203         * python/py-event.h: Rename include guard.
2204         * procfs.h: Add include guard.
2205         * proc-utils.h: Add include guard.
2206         * p-lang.h: Add include guard.
2207         * or1k-tdep.h: Rename include guard.
2208         * observable.h: Rename include guard.
2209         * nto-tdep.h: Rename include guard.
2210         * nat/x86-linux.h: Rename include guard.
2211         * nat/x86-linux-dregs.h: Rename include guard.
2212         * nat/x86-gcc-cpuid.h: Add include guard.
2213         * nat/x86-dregs.h: Rename include guard.
2214         * nat/x86-cpuid.h: Rename include guard.
2215         * nat/ppc-linux.h: Rename include guard.
2216         * nat/mips-linux-watch.h: Rename include guard.
2217         * nat/linux-waitpid.h: Rename include guard.
2218         * nat/linux-ptrace.h: Rename include guard.
2219         * nat/linux-procfs.h: Rename include guard.
2220         * nat/linux-osdata.h: Rename include guard.
2221         * nat/linux-nat.h: Rename include guard.
2222         * nat/linux-namespaces.h: Rename include guard.
2223         * nat/linux-btrace.h: Rename include guard.
2224         * nat/glibc_thread_db.h: Rename include guard.
2225         * nat/gdb_thread_db.h: Rename include guard.
2226         * nat/gdb_ptrace.h: Rename include guard.
2227         * nat/fork-inferior.h: Rename include guard.
2228         * nat/amd64-linux-siginfo.h: Rename include guard.
2229         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2230         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2231         * nat/aarch64-linux.h: Rename include guard.
2232         * nat/aarch64-linux-hw-point.h: Rename include guard.
2233         * mn10300-tdep.h: Add include guard.
2234         * mips-linux-tdep.h: Add include guard.
2235         * mi/mi-parse.h: Rename include guard.
2236         * mi/mi-out.h: Rename include guard.
2237         * mi/mi-main.h: Rename include guard.
2238         * mi/mi-interp.h: Rename include guard.
2239         * mi/mi-getopt.h: Rename include guard.
2240         * mi/mi-console.h: Rename include guard.
2241         * mi/mi-common.h: Rename include guard.
2242         * mi/mi-cmds.h: Rename include guard.
2243         * mi/mi-cmd-break.h: Rename include guard.
2244         * m2-lang.h: Add include guard.
2245         * location.h: Rename include guard.
2246         * linux-record.h: Rename include guard.
2247         * linux-nat.h: Add include guard.
2248         * linux-fork.h: Add include guard.
2249         * i386-darwin-tdep.h: Rename include guard.
2250         * hppa-linux-offsets.h: Add include guard.
2251         * guile/guile.h: Rename include guard.
2252         * guile/guile-internal.h: Rename include guard.
2253         * gnu-nat.h: Rename include guard.
2254         * gdb-stabs.h: Rename include guard.
2255         * frv-tdep.h: Add include guard.
2256         * f-lang.h: Add include guard.
2257         * event-loop.h: Add include guard.
2258         * darwin-nat.h: Rename include guard.
2259         * cp-abi.h: Rename include guard.
2260         * config/sparc/nm-sol2.h: Rename include guard.
2261         * config/nm-nto.h: Rename include guard.
2262         * config/nm-linux.h: Add include guard.
2263         * config/i386/nm-i386gnu.h: Rename include guard.
2264         * config/djgpp/nl_types.h: Rename include guard.
2265         * config/djgpp/langinfo.h: Rename include guard.
2266         * compile/gcc-cp-plugin.h: Add include guard.
2267         * compile/gcc-c-plugin.h: Add include guard.
2268         * compile/compile.h: Rename include guard.
2269         * compile/compile-object-run.h: Rename include guard.
2270         * compile/compile-object-load.h: Rename include guard.
2271         * compile/compile-internal.h: Rename include guard.
2272         * compile/compile-cplus.h: Rename include guard.
2273         * compile/compile-c.h: Rename include guard.
2274         * common/xml-utils.h: Rename include guard.
2275         * common/x86-xstate.h: Rename include guard.
2276         * common/version.h: Rename include guard.
2277         * common/vec.h: Rename include guard.
2278         * common/tdesc.h: Rename include guard.
2279         * common/selftest.h: Rename include guard.
2280         * common/scoped_restore.h: Rename include guard.
2281         * common/scoped_mmap.h: Rename include guard.
2282         * common/scoped_fd.h: Rename include guard.
2283         * common/safe-iterator.h: Rename include guard.
2284         * common/run-time-clock.h: Rename include guard.
2285         * common/refcounted-object.h: Rename include guard.
2286         * common/queue.h: Rename include guard.
2287         * common/ptid.h: Rename include guard.
2288         * common/print-utils.h: Rename include guard.
2289         * common/preprocessor.h: Rename include guard.
2290         * common/pathstuff.h: Rename include guard.
2291         * common/observable.h: Rename include guard.
2292         * common/netstuff.h: Rename include guard.
2293         * common/job-control.h: Rename include guard.
2294         * common/host-defs.h: Rename include guard.
2295         * common/gdb_wait.h: Rename include guard.
2296         * common/gdb_vecs.h: Rename include guard.
2297         * common/gdb_unlinker.h: Rename include guard.
2298         * common/gdb_unique_ptr.h: Rename include guard.
2299         * common/gdb_tilde_expand.h: Rename include guard.
2300         * common/gdb_sys_time.h: Rename include guard.
2301         * common/gdb_string_view.h: Rename include guard.
2302         * common/gdb_splay_tree.h: Rename include guard.
2303         * common/gdb_setjmp.h: Rename include guard.
2304         * common/gdb_ref_ptr.h: Rename include guard.
2305         * common/gdb_optional.h: Rename include guard.
2306         * common/gdb_locale.h: Rename include guard.
2307         * common/gdb_assert.h: Rename include guard.
2308         * common/filtered-iterator.h: Rename include guard.
2309         * common/filestuff.h: Rename include guard.
2310         * common/fileio.h: Rename include guard.
2311         * common/environ.h: Rename include guard.
2312         * common/common-utils.h: Rename include guard.
2313         * common/common-types.h: Rename include guard.
2314         * common/common-regcache.h: Rename include guard.
2315         * common/common-inferior.h: Rename include guard.
2316         * common/common-gdbthread.h: Rename include guard.
2317         * common/common-exceptions.h: Rename include guard.
2318         * common/common-defs.h: Rename include guard.
2319         * common/common-debug.h: Rename include guard.
2320         * common/cleanups.h: Rename include guard.
2321         * common/buffer.h: Rename include guard.
2322         * common/btrace-common.h: Rename include guard.
2323         * common/break-common.h: Rename include guard.
2324         * cli/cli-utils.h: Rename include guard.
2325         * cli/cli-style.h: Rename include guard.
2326         * cli/cli-setshow.h: Rename include guard.
2327         * cli/cli-script.h: Rename include guard.
2328         * cli/cli-interp.h: Rename include guard.
2329         * cli/cli-decode.h: Rename include guard.
2330         * cli/cli-cmds.h: Rename include guard.
2331         * charset-list.h: Add include guard.
2332         * buildsym-legacy.h: Rename include guard.
2333         * bfin-tdep.h: Add include guard.
2334         * ax.h: Rename include guard.
2335         * arm-linux-tdep.h: Add include guard.
2336         * arm-fbsd-tdep.h: Add include guard.
2337         * arch/xtensa.h: Rename include guard.
2338         * arch/tic6x.h: Add include guard.
2339         * arch/i386.h: Add include guard.
2340         * arch/arm.h: Rename include guard.
2341         * arch/arm-linux.h: Rename include guard.
2342         * arch/arm-get-next-pcs.h: Rename include guard.
2343         * arch/amd64.h: Add include guard.
2344         * arch/aarch64-insn.h: Rename include guard.
2345         * arch-utils.h: Rename include guard.
2346         * annotate.h: Add include guard.
2347         * amd64-darwin-tdep.h: Rename include guard.
2348         * aarch64-linux-tdep.h: Add include guard.
2349         * aarch64-fbsd-tdep.h: Add include guard.
2350         * aarch32-linux-nat.h: Add include guard.
2351
2352 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2353
2354         * macrotab.c (macro_define_internal): New function that
2355         factorizes macro_define_object_internal and macro_define_function
2356         code.
2357         (macro_define_object_internal): Use macro_define_internal.
2358         (macro_define_function): Likewise.
2359
2360 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2361
2362         * macrocmd.c (extract_identifier): Return
2363         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2364         callers.
2365
2366 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2367
2368         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2369
2370 2019-02-05  Tom Tromey  <tom@tromey.com>
2371
2372         * target.c (target_stack::unpush): Move assertion earlier.
2373
2374 2019-01-30  Tom Tromey  <tom@tromey.com>
2375
2376         PR python/23615:
2377         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2378         (gdbpy_parse_and_eval): Likewise.
2379         * python/python-internal.h (gdbpy_allow_threads): New class.
2380
2381 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2382
2383         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2384         (aarch64_fbsd_fpregmap): Move earlier.
2385         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2386         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2387         instead of individual calls to trad_frame_set_reg_addr.
2388         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2389         earlier.
2390         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2391         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2392         instead of individual calls to trad_frame_set_reg_addr.
2393
2394 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2395
2396         * CONTRIBUTE: Replace contribution list with wiki link.
2397
2398 2019-01-25  Tom Tromey  <tom@tromey.com>
2399
2400         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2401
2402 2019-01-25  Tom Tromey  <tom@tromey.com>
2403
2404         * xtensa-linux-nat.c: Fix common/ includes.
2405         * xml-support.h: Fix common/ includes.
2406         * xml-support.c: Fix common/ includes.
2407         * x86-linux-nat.c: Fix common/ includes.
2408         * windows-nat.c: Fix common/ includes.
2409         * varobj.h: Fix common/ includes.
2410         * varobj.c: Fix common/ includes.
2411         * value.c: Fix common/ includes.
2412         * valops.c: Fix common/ includes.
2413         * utils.c: Fix common/ includes.
2414         * unittests/xml-utils-selftests.c: Fix common/ includes.
2415         * unittests/utils-selftests.c: Fix common/ includes.
2416         * unittests/unpack-selftests.c: Fix common/ includes.
2417         * unittests/tracepoint-selftests.c: Fix common/ includes.
2418         * unittests/style-selftests.c: Fix common/ includes.
2419         * unittests/string_view-selftests.c: Fix common/ includes.
2420         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2421         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2422         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2423         * unittests/rsp-low-selftests.c: Fix common/ includes.
2424         * unittests/parse-connection-spec-selftests.c: Fix common/
2425         includes.
2426         * unittests/optional-selftests.c: Fix common/ includes.
2427         * unittests/offset-type-selftests.c: Fix common/ includes.
2428         * unittests/observable-selftests.c: Fix common/ includes.
2429         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2430         * unittests/memrange-selftests.c: Fix common/ includes.
2431         * unittests/memory-map-selftests.c: Fix common/ includes.
2432         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2433         * unittests/function-view-selftests.c: Fix common/ includes.
2434         * unittests/environ-selftests.c: Fix common/ includes.
2435         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2436         * unittests/common-utils-selftests.c: Fix common/ includes.
2437         * unittests/cli-utils-selftests.c: Fix common/ includes.
2438         * unittests/array-view-selftests.c: Fix common/ includes.
2439         * ui-file.c: Fix common/ includes.
2440         * tui/tui-io.c: Fix common/ includes.
2441         * tracepoint.h: Fix common/ includes.
2442         * tracepoint.c: Fix common/ includes.
2443         * tracefile-tfile.c: Fix common/ includes.
2444         * top.h: Fix common/ includes.
2445         * top.c: Fix common/ includes.
2446         * thread.c: Fix common/ includes.
2447         * target/waitstatus.h: Fix common/ includes.
2448         * target/waitstatus.c: Fix common/ includes.
2449         * target.h: Fix common/ includes.
2450         * target.c: Fix common/ includes.
2451         * target-memory.c: Fix common/ includes.
2452         * target-descriptions.c: Fix common/ includes.
2453         * symtab.h: Fix common/ includes.
2454         * symfile.c: Fix common/ includes.
2455         * stap-probe.c: Fix common/ includes.
2456         * spu-linux-nat.c: Fix common/ includes.
2457         * sparc-nat.c: Fix common/ includes.
2458         * source.c: Fix common/ includes.
2459         * solib.c: Fix common/ includes.
2460         * solib-target.c: Fix common/ includes.
2461         * ser-unix.c: Fix common/ includes.
2462         * ser-tcp.c: Fix common/ includes.
2463         * ser-pipe.c: Fix common/ includes.
2464         * ser-base.c: Fix common/ includes.
2465         * selftest-arch.c: Fix common/ includes.
2466         * s12z-tdep.c: Fix common/ includes.
2467         * rust-exp.y: Fix common/ includes.
2468         * rs6000-aix-tdep.c: Fix common/ includes.
2469         * riscv-tdep.c: Fix common/ includes.
2470         * remote.c: Fix common/ includes.
2471         * remote-notif.h: Fix common/ includes.
2472         * remote-fileio.h: Fix common/ includes.
2473         * remote-fileio.c: Fix common/ includes.
2474         * regcache.h: Fix common/ includes.
2475         * regcache.c: Fix common/ includes.
2476         * record-btrace.c: Fix common/ includes.
2477         * python/python.c: Fix common/ includes.
2478         * python/py-type.c: Fix common/ includes.
2479         * python/py-inferior.c: Fix common/ includes.
2480         * progspace.h: Fix common/ includes.
2481         * producer.c: Fix common/ includes.
2482         * procfs.c: Fix common/ includes.
2483         * proc-api.c: Fix common/ includes.
2484         * printcmd.c: Fix common/ includes.
2485         * ppc-linux-nat.c: Fix common/ includes.
2486         * parser-defs.h: Fix common/ includes.
2487         * osdata.c: Fix common/ includes.
2488         * obsd-nat.c: Fix common/ includes.
2489         * nat/x86-linux.c: Fix common/ includes.
2490         * nat/x86-linux-dregs.c: Fix common/ includes.
2491         * nat/x86-dregs.h: Fix common/ includes.
2492         * nat/x86-dregs.c: Fix common/ includes.
2493         * nat/ppc-linux.c: Fix common/ includes.
2494         * nat/mips-linux-watch.h: Fix common/ includes.
2495         * nat/mips-linux-watch.c: Fix common/ includes.
2496         * nat/linux-waitpid.c: Fix common/ includes.
2497         * nat/linux-ptrace.h: Fix common/ includes.
2498         * nat/linux-ptrace.c: Fix common/ includes.
2499         * nat/linux-procfs.c: Fix common/ includes.
2500         * nat/linux-personality.c: Fix common/ includes.
2501         * nat/linux-osdata.c: Fix common/ includes.
2502         * nat/linux-namespaces.c: Fix common/ includes.
2503         * nat/linux-btrace.h: Fix common/ includes.
2504         * nat/linux-btrace.c: Fix common/ includes.
2505         * nat/fork-inferior.c: Fix common/ includes.
2506         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2507         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2508         * nat/aarch64-linux.c: Fix common/ includes.
2509         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2510         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2511         * namespace.h: Fix common/ includes.
2512         * mips-linux-tdep.c: Fix common/ includes.
2513         * minsyms.c: Fix common/ includes.
2514         * mi/mi-parse.h: Fix common/ includes.
2515         * mi/mi-main.c: Fix common/ includes.
2516         * mi/mi-cmd-env.c: Fix common/ includes.
2517         * memrange.h: Fix common/ includes.
2518         * memattr.c: Fix common/ includes.
2519         * maint.h: Fix common/ includes.
2520         * maint.c: Fix common/ includes.
2521         * main.c: Fix common/ includes.
2522         * machoread.c: Fix common/ includes.
2523         * location.c: Fix common/ includes.
2524         * linux-thread-db.c: Fix common/ includes.
2525         * linux-nat.c: Fix common/ includes.
2526         * linux-fork.c: Fix common/ includes.
2527         * inline-frame.c: Fix common/ includes.
2528         * infrun.c: Fix common/ includes.
2529         * inflow.c: Fix common/ includes.
2530         * inferior.h: Fix common/ includes.
2531         * inferior.c: Fix common/ includes.
2532         * infcmd.c: Fix common/ includes.
2533         * inf-ptrace.c: Fix common/ includes.
2534         * inf-child.c: Fix common/ includes.
2535         * ia64-linux-nat.c: Fix common/ includes.
2536         * i387-tdep.c: Fix common/ includes.
2537         * i386-tdep.c: Fix common/ includes.
2538         * i386-linux-tdep.c: Fix common/ includes.
2539         * i386-linux-nat.c: Fix common/ includes.
2540         * i386-go32-tdep.c: Fix common/ includes.
2541         * i386-fbsd-tdep.c: Fix common/ includes.
2542         * i386-fbsd-nat.c: Fix common/ includes.
2543         * guile/scm-type.c: Fix common/ includes.
2544         * guile/guile.c: Fix common/ includes.
2545         * go32-nat.c: Fix common/ includes.
2546         * gnu-nat.c: Fix common/ includes.
2547         * gdbthread.h: Fix common/ includes.
2548         * gdbarch-selftests.c: Fix common/ includes.
2549         * gdb_usleep.c: Fix common/ includes.
2550         * gdb_select.h: Fix common/ includes.
2551         * gdb_bfd.c: Fix common/ includes.
2552         * gcore.c: Fix common/ includes.
2553         * fork-child.c: Fix common/ includes.
2554         * findvar.c: Fix common/ includes.
2555         * fbsd-nat.c: Fix common/ includes.
2556         * event-top.c: Fix common/ includes.
2557         * event-loop.c: Fix common/ includes.
2558         * dwarf2read.c: Fix common/ includes.
2559         * dwarf2loc.c: Fix common/ includes.
2560         * dwarf2-frame.c: Fix common/ includes.
2561         * dwarf-index-cache.c: Fix common/ includes.
2562         * dtrace-probe.c: Fix common/ includes.
2563         * disasm-selftests.c: Fix common/ includes.
2564         * defs.h: Fix common/ includes.
2565         * csky-tdep.c: Fix common/ includes.
2566         * cp-valprint.c: Fix common/ includes.
2567         * cp-support.h: Fix common/ includes.
2568         * cp-support.c: Fix common/ includes.
2569         * corelow.c: Fix common/ includes.
2570         * completer.h: Fix common/ includes.
2571         * completer.c: Fix common/ includes.
2572         * compile/compile.c: Fix common/ includes.
2573         * compile/compile-loc2c.c: Fix common/ includes.
2574         * compile/compile-cplus-types.c: Fix common/ includes.
2575         * compile/compile-cplus-symbols.c: Fix common/ includes.
2576         * command.h: Fix common/ includes.
2577         * cli/cli-dump.c: Fix common/ includes.
2578         * cli/cli-cmds.c: Fix common/ includes.
2579         * charset.c: Fix common/ includes.
2580         * build-id.c: Fix common/ includes.
2581         * btrace.h: Fix common/ includes.
2582         * btrace.c: Fix common/ includes.
2583         * breakpoint.h: Fix common/ includes.
2584         * breakpoint.c: Fix common/ includes.
2585         * ax.h:
2586         (enum agent_op): Fix common/ includes.
2587         * ax-general.c (struct aop_map): Fix common/ includes.
2588         * ax-gdb.c: Fix common/ includes.
2589         * auxv.c: Fix common/ includes.
2590         * auto-load.c: Fix common/ includes.
2591         * arm-tdep.c: Fix common/ includes.
2592         * arch/riscv.c: Fix common/ includes.
2593         * arch/ppc-linux-common.c: Fix common/ includes.
2594         * arch/i386.c: Fix common/ includes.
2595         * arch/arm.c: Fix common/ includes.
2596         * arch/arm-linux.c: Fix common/ includes.
2597         * arch/arm-get-next-pcs.c: Fix common/ includes.
2598         * arch/amd64.c: Fix common/ includes.
2599         * arch/aarch64.c: Fix common/ includes.
2600         * arch/aarch64-insn.c: Fix common/ includes.
2601         * arch-utils.c: Fix common/ includes.
2602         * amd64-windows-tdep.c: Fix common/ includes.
2603         * amd64-tdep.c: Fix common/ includes.
2604         * amd64-sol2-tdep.c: Fix common/ includes.
2605         * amd64-obsd-tdep.c: Fix common/ includes.
2606         * amd64-nbsd-tdep.c: Fix common/ includes.
2607         * amd64-linux-tdep.c: Fix common/ includes.
2608         * amd64-linux-nat.c: Fix common/ includes.
2609         * amd64-fbsd-tdep.c: Fix common/ includes.
2610         * amd64-fbsd-nat.c: Fix common/ includes.
2611         * amd64-dicos-tdep.c: Fix common/ includes.
2612         * amd64-darwin-tdep.c: Fix common/ includes.
2613         * agent.c: Fix common/ includes.
2614         * ada-lang.h: Fix common/ includes.
2615         * ada-lang.c: Fix common/ includes.
2616         * aarch64-tdep.c: Fix common/ includes.
2617
2618 2019-01-25  Tom Tromey  <tom@tromey.com>
2619
2620         * common/create-version.sh: Use common/version.h.
2621
2622 2019-01-24  Pedro Alves  <palves@redhat.com>
2623
2624         * infrun.c (signal_stop, signal_print, signal_program)
2625         (signal_catch, signal_pass): Now arrays instead of pointers.
2626         (update_signals_program_target, do_target_resume)
2627         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2628         * linux-nat.c (linux_nat_target::pass_signals)
2629         (linux_nat_target::create_inferior, linux_nat_target::attach):
2630         Adjust.
2631         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2632         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2633         * procfs.c (procfs_target::pass_signals): Adjust.
2634         * record-full.c (record_full_target::resume): Adjust.
2635         * remote.c (remote_target::pass_signals)
2636         (remote_target::program_signals): Adjust.
2637         * target-debug.h (target_debug_print_signals): Now takes a
2638         gdb::array_view as parameter.  Adjust.
2639         * target.h (target_ops) <pass_signals, program_signals>: Replace
2640         pointer and length parameters with gdb::array_view.
2641         (target_pass_signals, target_program_signals): Likewise.
2642         * target-delegates.c: Regenerate.
2643
2644 2019-01-24  Pedro Alves  <palves@redhat.com>
2645
2646         * common/forward-scope-exit.h
2647         (forward_scope_exit::forward_scope_exit): Pass arguments to
2648         m_bind_function directly, instead of creating a std::bind and
2649         copying that.
2650
2651 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2652
2653         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2654         for static members.
2655         (pass_in_v_vfp_candidate): Likewise.
2656
2657 2019-01-23  Tom Tromey  <tom@tromey.com>
2658             Pedro Alves  <palves@redhat.com>
2659
2660         * regcache.c (class regcache_invalidator): Remove.
2661         (regcache::raw_write): Use make_scope_exit.
2662
2663 2019-01-23  Tom Tromey  <tom@tromey.com>
2664
2665         * ui-out.h (class ui_out_emit_type): Update comment.
2666
2667 2019-01-23  Tom Tromey  <tom@tromey.com>
2668
2669         * infrun.c (fetch_inferior_event): Update comment.
2670
2671 2019-01-23  Tom Tromey  <tom@tromey.com>
2672             Pedro Alves  <palves@redhat.com>
2673
2674         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2675         parameter.
2676         (fetch_inferior_event): Use SCOPE_EXIT.
2677
2678
2679 2019-01-23  Tom Tromey  <tom@tromey.com>
2680             Pedro Alves  <palves@redhat.com>
2681
2682         * infrun.c (disable_thread_events): Delete.
2683         (stop_all_threads): Use SCOPE_EXIT.
2684
2685 2019-01-23  Tom Tromey  <tom@tromey.com>
2686             Pedro Alves  <palves@redhat.com>
2687
2688         * symfile.c: Include forward-scope-exit.h.
2689         (clear_symtab_users_cleanup): Replace forward declaration with
2690         a FORWARD_SCOPE_EXIT.
2691         (syms_from_objfile_1): Use the forward_scope_exit and
2692         gdb::optional instead of cleanup_function.
2693         (reread_symbols): Use the forward_scope_exit instead of
2694         cleanup_function.
2695         (clear_symtab_users_cleanup): Remove function.
2696
2697 2019-01-23  Tom Tromey  <tom@tromey.com>
2698             Pedro Alves  <palves@redhat.com>
2699
2700         * linux-nat.c: Include scope-exit.h.
2701         (cleanup_target_stop): Remove.
2702         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2703         SCOPE_EXIT.
2704
2705 2019-01-23  Tom Tromey  <tom@tromey.com>
2706             Pedro Alves  <palves@redhat.com>
2707
2708         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2709         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2710
2711 2019-01-23  Tom Tromey  <tom@tromey.com>
2712             Andrew Burgess  <andrew.burgess@embecosm.com>
2713             Pedro Alves  <palves@redhat.com>
2714
2715         * infrun.c (fetch_inferior_event): Use scope_exit.
2716         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2717         * top.c (execute_command): Use scope_exit.
2718         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2719         * utils.c (do_bpstat_clear_actions_cleanup)
2720         (make_bpstat_clear_actions_cleanup): Remove.
2721
2722 2019-01-23  Tom Tromey  <tom@tromey.com>
2723             Pedro Alves  <palves@redhat.com>
2724
2725         * infrun.c: Include "common/scope-exit.h"
2726         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2727         (wait_for_inferior): Use SCOPE_EXIT.
2728         (fetch_inferior_event): Use scope_exit.
2729
2730 2019-01-23  Tom Tromey  <tom@tromey.com>
2731             Pedro Alves  <palves@redhat.com>
2732
2733         * breakpoint.c (create_breakpoint): Remove cleanup.
2734
2735 2019-01-23  Tom Tromey  <tom@tromey.com>
2736             Andrew Burgess  <andrew.burgess@embecosm.com>
2737             Pedro Alves  <palves@redhat.com>
2738
2739 2019-01-23  Pedro Alves  <palves@redhat.com>
2740
2741         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2742
2743 2019-01-23  Pedro Alves  <palves@redhat.com>
2744             Andrew Burgess  <andrew.burgess@embecosm.com>
2745
2746         * gdbthread.h: Include "common/forward-scope-exit.h".
2747         (scoped_finish_thread_state): Redefine custom class in terms of
2748         forward_scope_exit.
2749
2750 2019-01-23  Pedro Alves  <palves@redhat.com>
2751             Andrew Burgess  <andrew.burgess@embecosm.com>
2752
2753         * common/forward-scope-exit.h: New file.
2754
2755 2019-01-23  Pedro Alves  <palves@redhat.com>
2756             Andrew Burgess  <andrew.burgess@embecosm.com>
2757             Tom Tromey  <tom@tromey.com>
2758
2759         * common/scope-exit.h: New file.
2760
2761 2019-01-23  Pedro Alves  <palves@redhat.com>
2762
2763         * common/preprocessor.h (ESC): Rename to ...
2764         (ESC_PARENS): ... this.
2765         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2766         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2767
2768 2019-01-23  Tom Tromey  <tom@tromey.com>
2769
2770         * language.h (class scoped_switch_to_sym_language_if_auto):
2771         Initialize m_lang in both cases.
2772
2773 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2774
2775         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2776         with XCNEW.
2777
2778 2019-01-22  Tom Tromey  <tom@tromey.com>
2779
2780         * corelow.c: Do not include sys/file.h.
2781
2782 2019-01-22  Tom Tromey  <tom@tromey.com>
2783
2784         * tui/tui-wingeneral.h: Include gdb_curses.h.
2785
2786 2019-01-22  Tom Tromey  <tom@tromey.com>
2787
2788         * source-cache.h (class source_cache) <get_source_lines,
2789         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2790
2791 2019-01-22  Tom Tromey  <tom@tromey.com>
2792
2793         * remote-fileio.h (struct remote_target): Declare.
2794
2795 2019-01-22  Tom Tromey  <tom@tromey.com>
2796
2797         * python/py-arch.c: Do not include py-ref.h.
2798         * python/py-bpevent.c: Do not include py-ref.h.
2799         * python/py-cmd.c: Do not include py-ref.h.
2800         * python/py-continueevent.c: Do not include py-ref.h.
2801         * python/py-event.h: Do not include py-ref.h.
2802         * python/py-evtregistry.c: Do not include py-ref.h.
2803         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2804         * python/py-frame.c: Do not include py-ref.h.
2805         * python/py-framefilter.c: Do not include py-ref.h.
2806         * python/py-function.c: Do not include py-ref.h.
2807         * python/py-infevents.c: Do not include py-ref.h.
2808         * python/py-linetable.c: Do not include py-ref.h.
2809         * python/py-objfile.c: Do not include py-ref.h.
2810         * python/py-param.c: Do not include py-ref.h.
2811         * python/py-prettyprint.c: Do not include py-ref.h.
2812         * python/py-progspace.c: Do not include py-ref.h.
2813         * python/py-symbol.c: Do not include py-ref.h.
2814         * python/py-symtab.c: Do not include py-ref.h.
2815         * python/py-type.c: Do not include py-ref.h.
2816         * python/py-unwind.c: Do not include py-ref.h.
2817         * python/py-utils.c: Do not include py-ref.h.
2818         * python/py-value.c: Do not include py-ref.h.
2819         * python/py-varobj.c: Do not include py-ref.h.
2820         * python/py-xmethods.c: Do not include py-ref.h.
2821         * python/python.c: Do not include py-ref.h.
2822         * varobj.c: Do not include py-ref.h.
2823
2824 2019-01-22  Tom Tromey  <tom@tromey.com>
2825
2826         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2827         keyword for bcache.
2828
2829 2019-01-22  Tom Tromey  <tom@tromey.com>
2830
2831         * compile/compile-cplus-types.c: Remove a comment by #include.
2832
2833 2019-01-22  Tom Tromey  <tom@tromey.com>
2834
2835         * compile/gcc-c-plugin.h: Include compile-internal.h.
2836
2837 2019-01-22  Tom Tromey  <tom@tromey.com>
2838
2839         * stabsread.c (EXTERN): Do not define.
2840         (symnum, next_symbol_text_func, processing_gcc_compilation)
2841         (within_function, global_sym_chain, global_stabs)
2842         (previous_stab_code, this_object_header_files)
2843         (n_this_object_header_files)
2844         (n_allocated_this_object_header_files): Define.
2845         * stabsread.h (EXTERN): Never define.  Use "extern".
2846
2847 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2848
2849         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2850         history_value.
2851
2852 2019-01-21  Tom Tromey  <tom@tromey.com>
2853
2854         * ui-out.c: Fix includes.
2855         * tui/tui-source.c: Fix includes.
2856         * target.c: Fix includes.
2857         * remote.c: Fix includes.
2858         * regcache.c: Fix includes.
2859         * python/py-block.c: Fix includes.
2860         * printcmd.c: Fix includes.
2861         * or1k-tdep.c: Fix includes.
2862         * mi/mi-main.c: Fix includes.
2863         * m32r-tdep.c: Fix includes.
2864         * csky-tdep.c: Fix includes.
2865         * compile/compile-cplus-types.c: Fix includes.
2866         * cli/cli-interp.c: Fix includes.
2867
2868 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2869
2870         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2871         for padding.
2872
2873 2019-01-16  Tom Tromey  <tom@tromey.com>
2874
2875         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2876         earlier.
2877         (struct objfile) <msymbols_range>: Move from top level.
2878         <msymbols>: New method.
2879         (class objfile_msymbols): Remove.
2880         * symtab.c (default_collect_symbol_completion_matches_break_on):
2881         Update.
2882         * symmisc.c (dump_msymbols): Update.
2883         * stabsread.c (scan_file_globals): Update.
2884         * objc-lang.c (info_selectors_command, info_classes_command)
2885         (find_methods): Update.
2886         * minsyms.c (find_solib_trampoline_target): Update.
2887         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2888         * coffread.c (coff_symfile_read): Update.
2889         * ada-lang.c (ada_lookup_simple_minsym)
2890         (ada_collect_symbol_completion_matches): Update.
2891
2892 2019-01-16  Tom Tromey  <tom@tromey.com>
2893
2894         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2895         type.  Remove no-argument constructor.
2896         <iterator::operator++>: Simplify.
2897         <begin>: Update.
2898         <end>: Use minimal_symbol_count.
2899
2900 2019-01-16  Tom Tromey  <tom@tromey.com>
2901
2902         * objfiles.h (struct objfile) <psymtabs>: New method.
2903         (class objfile_psymtabs): Remove.
2904         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2905         typedef.
2906         <range>: New method.
2907         (require_partial_symbols): Change return type.
2908         * psymtab.c (require_partial_symbols)
2909         (psym_expand_symtabs_matching): Update.
2910         * mdebugread.c (parse_partial_symbols): Update.
2911         * dbxread.c (dbx_end_psymtab): Update.
2912
2913 2019-01-15  Tom Tromey  <tom@tromey.com>
2914
2915         * symtab.c (lookup_objfile_from_block)
2916         (lookup_symbol_in_objfile_symtabs)
2917         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2918         (find_line_symtab, info_sources_command)
2919         (default_collect_symbol_completion_matches_break_on)
2920         (make_source_files_completion_list): Update.
2921         * symmisc.c (print_objfile_statistics, dump_objfile)
2922         (maintenance_print_symbols, maintenance_info_symtabs)
2923         (maintenance_check_symtabs, maintenance_info_line_tables):
2924         Update.
2925         * source.c (select_source_symtab)
2926         (forget_cached_source_info_for_objfile): Update.
2927         * objfiles.h (class objfile_compunits): Remove.
2928         (struct objfile) <compunits_range>: New typedef.
2929         (compunits): New method.
2930         * objfiles.c (objfile_relocate1): Update.
2931         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2932         * maint.c (count_symtabs_and_blocks): Update.
2933         * linespec.c (iterate_over_all_matching_symtabs): Update.
2934         * cp-support.c (add_symbol_overload_list_qualified): Update.
2935         * coffread.c (coff_symtab_read): Update.
2936         * ada-lang.c (add_nonlocal_symbols)
2937         (ada_collect_symbol_completion_matches)
2938         (ada_add_global_exceptions): Update.
2939
2940 2019-01-15  Tom Tromey  <tom@tromey.com>
2941
2942         * progspace.h (program_space) <objfiles_safe_range>: New
2943         typedef.
2944         <objfiles_safe>: New method.
2945         * objfiles.h (class all_objfiles_safe): Remove.
2946         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2947         * jit.c (jit_inferior_exit_hook): Update.
2948
2949 2019-01-17  Tom Tromey  <tom@tromey.com>
2950
2951         * progspace.h (program_space) <objfiles_range>: New typedef.
2952         <objfiles>: New method.
2953         <objfiles_head>: Rename from objfiles.
2954         (object_files): Update.
2955         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2956         * guile/scm-pretty-print.c
2957         (ppscm_find_pretty_printer_from_objfiles): Update.
2958         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2959         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2960         Update.
2961         * python/py-progspace.c (pspy_get_objfiles): Update.
2962         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2963         Update.
2964         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2965         (objfpy_lookup_objfile_by_build_id): Update.
2966         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2967         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2968         Update.
2969         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2970         (expand_symtab_containing_pc, lookup_objfile_from_block)
2971         (lookup_static_symbol, basic_lookup_transparent_type)
2972         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2973         (find_line_symtab, info_sources_command)
2974         (default_collect_symbol_completion_matches_break_on)
2975         (make_source_files_completion_list, find_main_name): Update.
2976         * symmisc.c (print_symbol_bcache_statistics)
2977         (print_objfile_statistics, maintenance_print_symbols)
2978         (maintenance_print_msymbols, maintenance_print_objfiles)
2979         (maintenance_info_symtabs, maintenance_check_symtabs)
2980         (maintenance_expand_symtabs, maintenance_info_line_tables):
2981         Update.
2982         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2983         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2984         (map_overlay_command, unmap_overlay_command)
2985         (simple_overlay_update, expand_symtabs_matching)
2986         (map_symbol_filenames): Update.
2987         * symfile-debug.c (set_debug_symfile): Update.
2988         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2989         Update.
2990         * source.c (select_source_symtab, forget_cached_source_info):
2991         Update.
2992         * solib.c (solib_read_symbols): Update.
2993         * solib-spu.c (append_ocl_sos): Update.
2994         * psymtab.c (maintenance_print_psymbols)
2995         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2996         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2997         * printcmd.c (info_symbol_command): Update.
2998         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2999         Update.
3000         * objfiles.h (class all_objfiles): Remove.
3001         * objfiles.c (have_partial_symbols, have_full_symbols)
3002         (have_minimal_symbols, qsort_cmp, update_section_map)
3003         (shared_objfile_contains_address_p)
3004         (default_iterate_over_objfiles_in_search_order): Update.
3005         * objc-lang.c (info_selectors_command, info_classes_command)
3006         (find_methods): Update.
3007         * minsyms.c (find_solib_trampoline_target): Update.
3008         * maint.c (maintenance_info_sections)
3009         (maintenance_translate_address, count_symtabs_and_blocks):
3010         Update.
3011         * main.c (captured_main_1): Update.
3012         * linux-thread-db.c (try_thread_db_load_from_pdir)
3013         (has_libpthread): Update.
3014         * linespec.c (iterate_over_all_matching_symtabs)
3015         (search_minsyms_for_name): Update.
3016         * jit.c (jit_find_objf_with_entry_addr): Update.
3017         * hppa-tdep.c (find_unwind_entry)
3018         (hppa_lookup_stub_minimal_symbol): Update.
3019         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3020         Update.
3021         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3022         (elf_gnu_ifunc_resolve_by_got): Update.
3023         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3024         * dwarf-index-write.c (save_gdb_index_command): Update.
3025         * cp-support.c (add_symbol_overload_list_qualified): Update.
3026         * breakpoint.c (create_overlay_event_breakpoint)
3027         (create_longjmp_master_breakpoint)
3028         (create_std_terminate_master_breakpoint)
3029         (create_exception_master_breakpoint): Update.
3030         * blockframe.c (find_pc_partial_function): Update.
3031         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3032         (ada_collect_symbol_completion_matches)
3033         (ada_add_global_exceptions): Update.
3034
3035 2019-01-17  Tom Tromey  <tom@tromey.com>
3036
3037         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3038         declare VEC.
3039         (solib_target_parse_libraries): Change return type.
3040         (library_list_start_segment, library_list_start_section)
3041         (library_list_end_library, library_list_start_library); Update.
3042         (solib_target_free_library_list): Remove.
3043         (solib_target_parse_libraries): Remove cleanup.  Change return
3044         type.
3045         (solib_target_current_sos): Update.
3046
3047 2019-01-17  Tom Tromey  <tromey@bapiya>
3048
3049         * valprint.c: Replace "the the" with "the".
3050         * symtab.c: Replace "the the" with "the".
3051         * solib.c: Replace "the the" with "the".
3052         * solib-dsbt.c: Replace "the the" with "the".
3053         * linespec.c: Replace "the the" with "the".
3054         * dwarf2loc.h: Replace "the the" with "the".
3055         * amd64-windows-tdep.c: Replace "the the" with "the".
3056         * aarch64-tdep.c: Replace "the the" with "the".
3057
3058 2019-01-16  Keith Seitz  <keiths@redhat.com>
3059
3060         PR gdb/23773
3061         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3062         <builder>: Rename to ..
3063         <m_builder>: ... this and make private.
3064         (dwarf2_cu::get_builder): New method.  Change all users of
3065         `builder' to use this method.
3066         (dwarf2_start_symtab): Move to ...
3067         (dwarf2_cu::start_symtab): ... here.  Update all callers
3068         (setup_type_unit_groups): Move to ...
3069         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3070         callers.
3071         (dwarf2_cu::reset_builder): New method.
3072         (process_full_compunit, process_full_type_unit): Use
3073         dwarf2_cu::reset_builder.
3074         (follow_die_offset): Record the ancestor CU if it is different
3075         from the followed DIE's CU.
3076         (follow_die_sig_1): Likewise.
3077
3078 2019-01-15  Tom Tromey  <tom@tromey.com>
3079
3080         * remote.c (class remote_state) <buf>: Now a char_vector.
3081         <buf_size>: Remove.
3082         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3083         parameter.
3084         (remote_target::getpkt_or_notif_sane_1)
3085         (remote_target::getpkt_sane)
3086         (remote_target::getpkt_or_notif_sane): Likewise.
3087         (class remote_target) <putpkt>: New overload.
3088         (remote_target::read_frame): Change type of "buf_p".  Remove
3089         sizeof_p parameter.
3090         (packet_ok): New overload.
3091         (packet_check_result): New overload.
3092         Update all uses.
3093
3094 2019-01-14  Tom Tromey  <tom@tromey.com>
3095
3096         * remote-notif.c (handle_notification, remote_notif_ack)
3097         (remote_notif_parse): Make "buf" const.
3098         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3099         const.
3100         (remote_notif_parse, remote_notif_ack, handle_notification):
3101         Likewise.
3102         * remote.c (remote_notif_stop_parse): Make "buf" const.
3103         (remote_target::remote_parse_stop_reply): Make "buf" const.
3104         (remote_notif_stop_ack): Make "buf" const.
3105
3106 2019-01-14  Tom Tromey  <tom@tromey.com>
3107
3108         * remote.c (remote_console_output): Make parameter const.
3109
3110 2019-01-14  Tom Tromey  <tom@tromey.com>
3111
3112         * target-debug.h (target_debug_print_signals): Constify.
3113         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3114         * procfs.c (procfs_target::pass_signals): Update.
3115         * linux-nat.c (linux_nat_target::pass_signals): Update.
3116         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3117         * target-delegates.c: Rebuild.
3118         * remote.c (remote_target::program_signals): Update.
3119         (remote_target::pass_signals): Update.
3120         * target.c (target_pass_signals): Constify argument.
3121         (target_program_signals): Likewise.
3122         * target.h (struct target_ops) <pass_signals, program_signals>:
3123         Constify argument.
3124         (target_pass_signals, target_program_signals): Constify argument.
3125
3126 2019-01-14  Tom Tromey  <tom@tromey.com>
3127
3128         PR tui/28819:
3129         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3130
3131 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3132
3133         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3134         field.
3135         * rs6000-tdep.c: Include reggroups.h.
3136         (IS_V_ALIAS_PSEUDOREG): Define.
3137         (rs6000_register_name): Return names for the "vX" aliases.
3138         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3139         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3140         aliases.  Call default_register_reggroup_p for all other
3141         pseudo-registers.
3142         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3143         New functions.
3144         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3145         Handle "vX" aliases.
3146         (v_alias_pseudo_register_collect): New function.
3147         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3148         (rs6000_gdbarch_init): Initialize "vX" aliases as
3149         pseudo-registers.  Restore registration of
3150         rs6000_pseudo_register_reggroup_p with
3151         set_tdesc_pseudo_register_reggroup_p.
3152
3153 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3154
3155         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3156         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3157         set_gdbarch_num_pseudo_regs.
3158
3159 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3160
3161         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3162         Remove arg prefixname, add do_set and do_show.
3163         Add member functions set_list and show_list.
3164         * cli/cli-style.c (class cli_style_option): Update accordingly.
3165         (style_set_list): Move to file scope.
3166         (style_show_list): Likewise.
3167         (set_style): Call help_list.
3168         (show_style): Call cmd_show_list.
3169         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3170         Update to use the new macro.
3171
3172 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3173
3174         * ada-lang.c (_initialize_ada_language): Expand the help text
3175         for the "catch exception" command.
3176
3177 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3178
3179         * symtab.c (matching_obj_sections): Initialize obj,
3180         declare it closer to its usage.
3181
3182 2019-01-10  Tom Tromey  <tom@tromey.com>
3183
3184         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3185         (basic_inf_threads_range): Remove.
3186         (inf_threads_range, inf_non_exited_threads_range)
3187         (safe_inf_threads_range): Use next_adapter.
3188
3189 2019-01-10  Keith Seitz  <keiths@redhat.com>
3190
3191         PR gdb/23712
3192         PR symtab/23010
3193         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3194         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3195
3196 2019-01-10  Keith Seitz  <keiths@redhat.com>
3197
3198         PR gdb/23712
3199         PR symtab/23010
3200         * dictionary.c (pending_to_vector): Remove.
3201         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3202         Remove _1 suffix, replacing functions of the same name.  Update
3203         all callers.
3204         (dict_create_hashed, dict_create_hashed_expandable)
3205         (dict_create_linear, dict_create_linear_expandable, dict_free)
3206         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3207         Make functions static.
3208
3209 2019-01-10  Keith Seitz  <keiths@redhat.com>
3210
3211         PR gdb/23712
3212         PR symtab/23010
3213         * dictionary.h (struct dictionary): Replace declaration with
3214         multidictionary.
3215         (dict_create_hashed, dict_create_hashed_expandable)
3216         (dict_create_linear, dict_create_linear_expandable)
3217         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3218         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3219         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3220         taking multidictionary argument.
3221         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3222         * block.h (struct block) <dict>: Change to multidictionary
3223         and rename `multidict'.
3224         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3225         symmisc.c: Update all dictionary references to multidictionary.
3226
3227 2019-01-10  Keith Seitz  <keiths@redhat.com>
3228
3229         PR gdb/23712
3230         PR symtab/23010
3231         * dictionary.c: Include unordered_map.
3232         (pending_to_vector): New function.
3233         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3234         Rewrite the non-"_1" functions to take vector instead
3235         of linked list.
3236         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3237         "new" _1 versions of the same name.
3238         (multidictionary): Define.
3239         (std::hash<enum language): New definition.
3240         (collate_pending_symbols_by_language, mdict_create_hashed)
3241         (mdict_create_hashed_expandable, mdict_create_linear)
3242         (mdict_create_linear_expandable, mdict_free)
3243         (find_language_dictionary, create_new_language_dictionary)
3244         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3245         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3246         (mdict_size, mdict_empty): New functions.
3247         * dictionary.h (mdict_iterator): Define.
3248
3249 2019-01-10  Pedro Alves  <palves@redhat.com>
3250
3251         * breakpoint.c (read_uploaded_action)
3252         (create_tracepoint_from_upload): Adjust to use
3253         gdb::unique_xmalloc_ptr.
3254         * ctf.c (ctf_write_uploaded_tp):
3255         (SET_ARRAY_FIELD): Use emplace_back.
3256         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3257         * tracefile-tfile.c (tfile_write_uploaded_tp):
3258         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3259         gdb::unique_xmalloc_ptr.
3260         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3261         at_string, cond_string, cmd_strings>: Replace char pointers
3262         with gdb::unique_xmalloc_ptr.
3263
3264 2019-01-10  Pedro Alves  <palves@redhat.com>
3265
3266         * solib-target.c (library_list_start_library): Don't xstrdup name.
3267
3268 2019-01-10  Pedro Alves  <palves@redhat.com>
3269
3270         * mdebugread.c (parse_partial_symbols): Use
3271         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3272
3273 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3274
3275         * linux-fork.c (scoped_switch_fork_info)
3276         <~scoped_switch_fork_info>: Fix incorrect variable name.
3277
3278 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3279
3280         * linux-fork.c (scoped_switch_fork_info)
3281         <scoped_switch_fork_info>: Make explicit.
3282         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3283
3284 2019-01-10  Tom Tromey  <tom@tromey.com>
3285
3286         * objfiles.h (objfile::reset_psymtabs): Update.
3287         * objfiles.c (objfile::objfile): Update.
3288         * psymtab.h (psymtab_storage::obstack): Update.
3289         (psymtab_storage::m_obstack): Use gdb::optional.
3290         (class psymtab_storage): Update comment.  Remove objfile
3291         parameter.
3292         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3293
3294 2019-01-10  Tom Tromey  <tom@tromey.com>
3295
3296         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3297         <free_psymtabs>: Now private.
3298         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3299         (allocate_psymtab): Use new method.
3300
3301 2019-01-10  Tom Tromey  <tom@tromey.com>
3302
3303         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3304         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3305         * mdebugread.c (parse_partial_symbols): Use
3306         allocate_dependencies.
3307         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3308         allocate_dependencies.
3309         (process_psymtab_comp_unit_reader)
3310         (build_type_psymtab_dependencies): Likewise.
3311         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3312
3313 2019-01-10  Tom Tromey  <tom@tromey.com>
3314
3315         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3316         PSYMBOL_SET_LANGUAGE.
3317         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3318
3319 2019-01-10  Tom Tromey  <tom@tromey.com>
3320
3321         * psymtab.h (psymtab_storage::obstack): New method.
3322         <m_obstack>: Rename from obstack; now private.
3323         * psymtab.c (psymtab_storage): Update.
3324         * dwarf2read.c (create_addrmap_from_index)
3325         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3326         Update.
3327
3328 2019-01-10  Tom Tromey  <tom@tromey.com>
3329
3330         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3331         * objfiles.h (objfile::reset_psymtabs): New method.
3332
3333 2019-01-10  Tom Tromey  <tom@tromey.com>
3334
3335         * symmisc.c (print_symbol_bcache_statistics): Update.
3336         (print_objfile_statistics): Update.
3337         * symfile.c (reread_symbols): Update.
3338         * psymtab.h (class psymtab_storage): New.
3339         * psymtab.c (psymtab_storage): New constructor.
3340         (~psymtab_storage): New destructor.
3341         (require_partial_symbols): Update.
3342         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3343         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3344         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3345         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3346         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3347         (start_psymtab_common, end_psymtab_common)
3348         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3349         (allocate_psymtab): Update.
3350         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3351         Update.
3352         (dump_psymtab_addrmap, maintenance_print_psymbols)
3353         (maintenance_check_psymtabs): Update.
3354         (class objfile_psymtabs): Move to objfiles.h.
3355         * psympriv.h (discard_psymtab): Now inline.
3356         (psymtab_discarder::psymtab_discarder): Update.
3357         (psymtab_discarder::~psymtab_discarder): Update.
3358         (ALL_OBJFILE_PSYMTABS): Rewrite.
3359         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3360         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3361         Remove fields.
3362         <partial_symtabs>: New field.
3363         (class objfile_psymtabs): Move from psymtab.h.  Update.
3364         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3365         psymbol_cache.
3366         (objfile::~objfile): Don't destroy psymbol_cache.
3367         * mdebugread.c (parse_partial_symbols): Update.
3368         * dwarf2read.c (create_addrmap_from_index)
3369         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3370         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3371         (add_partial_subprogram, dwarf2_ranges_read): Update.
3372         * dwarf-index-write.c (write_address_map)
3373         (write_one_signatured_type, recursively_write_psymbols)
3374         (class debug_names, class debug_names, write_psymtabs_to_index):
3375         Update.
3376
3377 2019-01-10  Tom Tromey  <tom@tromey.com>
3378
3379         * symtab.h (SYMBOL_SET_NAMES): Update.
3380         (symbol_set_names): Update.
3381         (MSYMBOL_SET_NAMES): Update.
3382         * symtab.c (symbol_set_names): Change argument to be an
3383         objfile_per_bfd_storage.
3384         * psymtab.c (add_psymbol_to_bcache): Update.
3385         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3386
3387 2019-01-10  Tom Tromey  <tom@tromey.com>
3388
3389         * symtab.c (create_demangled_names_hash): Change argument to be an
3390         objfile_per_bfd_storage.
3391         (symbol_set_names): Update.
3392
3393 2019-01-10  Tom Tromey  <tom@tromey.com>
3394
3395         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3396         init_psymbol_list.
3397         * psymtab.c (init_psymbol_list): Do nothing if already called.
3398         * psympriv.h (init_psymbol_list): Add comment.
3399         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3400         init_psymbol_list.
3401         * dbxread.c (dbx_symfile_read): Unconditionally call
3402         init_psymbol_list.
3403
3404 2019-01-10  Tom Tromey  <tom@tromey.com>
3405
3406         * xcoffread.c (scan_xcoff_symtab): Update.
3407         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3408         "where".
3409         * mdebugread.c (parse_partial_symbols)
3410         (handle_psymbol_enumerators): Update.
3411         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3412         * dbxread.c (read_dbx_symtab): Update.
3413         * psympriv.h (psymbol_placement): New enum.
3414         (add_psymbol_to_list): Update.
3415
3416 2019-01-10  Tom Tromey  <tom@tromey.com>
3417
3418         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3419         static_psymbols parameters.
3420         (scan_xcoff_symtab): Update.
3421         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3422         static_psymbols parameters.
3423         * psympriv.h (start_psymtab_common): Update.
3424         * mdebugread.c (parse_partial_symbols): Update.
3425         * dwarf2read.c (create_partial_symtab): Update.
3426         * dbxread.c (read_dbx_symtab): Update.
3427         (start_psymtab): Remove global_psymbols and static_psymbols
3428         parameters.
3429
3430 2019-01-10  Tom Tromey  <tom@tromey.com>
3431
3432         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3433         * psymtab.c (allocate_psymtab): Add comment.
3434         * psympriv.h (allocate_psymtab): Add comment.
3435         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3436         initializations.
3437         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3438
3439 2019-01-10  Tom Tromey  <tom@tromey.com>
3440
3441         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3442         Don't declare.
3443         * mipsread.c: Include mdebugread.h.
3444         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3445         Declare.
3446         * elfread.c: Include mdebugread.h.
3447
3448 2019-01-09  Tom Tromey  <tom@tromey.com>
3449
3450         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3451         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3452         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3453         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3454         (psym_lookup_symbol, psym_find_last_source_symtab)
3455         (psym_forget_cached_source_info, psym_print_stats)
3456         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3457         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3458         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3459         (psym_find_compunit_symtab_by_address)
3460         (maintenance_print_psymbols, maintenance_info_psymtabs)
3461         (maintenance_check_psymtabs): Use ranged for.
3462         * psymtab.h (class objfile_psymtabs): New.
3463         (require_partial_symbols): Return objfile_psymtabs.
3464         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3465
3466 2019-01-09  Tom Tromey  <tom@tromey.com>
3467
3468         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3469         (find_pc_mapped_section, list_overlays_command)
3470         (map_overlay_command, unmap_overlay_command)
3471         (simple_overlay_update): Use all_objfiles.
3472         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3473         * printcmd.c (info_symbol_command): Use all_objfiles.
3474         * objfiles.h (ALL_OBJSECTIONS): Remove.
3475         * maint.c (maintenance_translate_address): Use all_objfiles.
3476         * gcore.c (gcore_create_callback): Use all_objfiles.
3477         (objfile_find_memory_regions): Likewise.
3478
3479 2019-01-09  Tom Tromey  <tom@tromey.com>
3480
3481         * symtab.c (find_line_symtab, info_sources_command)
3482         (make_source_files_completion_list): Use objfile_compunits.
3483         * source.c (select_source_symtab): Use objfile_compunits.
3484         * objfiles.h (struct objfile): Update comment.
3485         (ALL_OBJFILES): Remove.
3486         (ALL_FILETABS): Remove.
3487         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3488         objfile_compunits.
3489
3490 2019-01-09  Tom Tromey  <tom@tromey.com>
3491
3492         * symmisc.c (print_objfile_statistics, dump_objfile)
3493         (maintenance_print_symbols): Use compunit_filetabs.
3494         * source.c (forget_cached_source_info_for_objfile): Use
3495         compunit_filetabs.
3496         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3497         (ALL_FILETABS): Use compunit_filetabs.
3498         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3499         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3500
3501 2019-01-09  Tom Tromey  <tom@tromey.com>
3502
3503         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3504         (compunit_filetabs): New.
3505         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3506         compunit_filetabs.
3507         (info_sources_command, make_source_files_completion_list): Remove
3508         declaration.
3509         * symmisc.c (print_objfile_statistics, dump_objfile)
3510         (maintenance_print_symbols): Remove declaration.
3511         (maintenance_info_symtabs): Use compunit_filetabs.
3512         (maintenance_info_line_tables): Likewise.
3513         * source.c (select_source_symtab): Change local variable name.
3514         (forget_cached_source_info_for_objfile): Remove declaration.
3515         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3516         * objfiles.c (objfile_relocate1): Remove declaration.
3517         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3518         declaration.
3519         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3520         * coffread.c (coff_symtab_read): Remove declaration.
3521         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3522         compunit_filetabs.
3523
3524 2019-01-09  Tom Tromey  <tom@tromey.com>
3525
3526         * symtab.c (lookup_objfile_from_block)
3527         (find_pc_sect_compunit_symtab, search_symbols)
3528         (default_collect_symbol_completion_matches_break_on): Use
3529         objfile_compunits.
3530         * objfiles.h (ALL_COMPUNITS): Remove.
3531         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3532         * cp-support.c (add_symbol_overload_list_qualified): Use
3533         objfile_compunits.
3534         * ada-lang.c (ada_collect_symbol_completion_matches)
3535         (ada_add_global_exceptions): Use objfile_compunits.
3536
3537 2019-01-09  Tom Tromey  <tom@tromey.com>
3538
3539         * source.c (select_source_symtab)
3540         (forget_cached_source_info_for_objfile): Remove declaration.
3541         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3542         declaration.
3543         * maint.c (count_symtabs_and_blocks): Remove declaration.
3544         * cp-support.c (add_symbol_overload_list_qualified): Remove
3545         declaration.
3546         * coffread.c (coff_symtab_read): Remove declaration.
3547         * symtab.c (lookup_symbol_in_objfile_symtabs)
3548         (basic_lookup_transparent_type_1): Use objfile_compunits.
3549         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3550         (info_sources_command, search_symbols)
3551         (default_collect_symbol_completion_matches_break_on)
3552         (make_source_files_completion_list): Remove declaration.
3553         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3554         (ada_collect_symbol_completion_matches)
3555         (ada_add_global_exceptions): Remove declaration.
3556         * linespec.c (iterate_over_all_matching_symtabs): Use
3557         objfile_compunits.
3558         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3559         (class objfile_compunits): New.
3560         (ALL_COMPUNITS): Use objfile_compunits.
3561         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3562         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3563         objfile_compunits.
3564         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3565
3566 2019-01-09  Tom Tromey  <tom@tromey.com>
3567
3568         * symtab.c (search_symbols)
3569         (default_collect_symbol_completion_matches_break_on): Use
3570         objfile_msymbols.
3571         * ada-lang.c (ada_lookup_simple_minsym)
3572         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3573         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3574         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3575         objfile_msymbols.
3576         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3577         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3578         * objc-lang.c (find_methods): Use objfile_msymbols.
3579         (info_selectors_command, info_classes_command): Likewise.
3580         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3581         * objfiles.h (class objfile_msymbols): New.
3582         (ALL_OBJFILE_MSYMBOLS): Remove.
3583         (ALL_MSYMBOLS): Remove.
3584
3585 2019-01-09  Tom Tromey  <tom@tromey.com>
3586
3587         * common/next-iterator.h (next_adapter): Add Iterator template
3588         parameter.
3589         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3590         (class all_objfiles_safe): New.
3591         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3592         * objfiles.c (put_objfile_before): Update comment.
3593         (add_separate_debug_objfile): Likewise.
3594         (free_all_objfiles): Use all_objfiles_safe.
3595         (objfile_purge_solibs): Likewise.
3596
3597 2019-01-09  Tom Tromey  <tom@tromey.com>
3598
3599         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3600         (expand_symtab_containing_pc, lookup_static_symbol)
3601         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3602         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3603         all_objfiles.
3604         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3605         * breakpoint.c (create_overlay_event_breakpoint)
3606         (create_longjmp_master_breakpoint)
3607         (create_std_terminate_master_breakpoint)
3608         (create_exception_master_breakpoint): Use all_objfiles.
3609         * linux-thread-db.c (try_thread_db_load_from_pdir)
3610         (has_libpthread): Use all_objfiles.
3611         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3612         * linespec.c (iterate_over_all_matching_symtabs)
3613         (search_minsyms_for_name): Use all_objfiles.
3614         * maint.c (maintenance_info_sections): Use all_objfiles.
3615         * main.c (captured_main_1): Use all_objfiles.
3616         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3617         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3618         * guile/scm-pretty-print.c
3619         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3620         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3621         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3622         (maintenance_print_msymbols): Use all_objfiles.
3623         * source.c (select_source_symtab): Use all_objfiles.
3624         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3625         * symfile.c (remove_symbol_file_command)
3626         (expand_symtabs_matching, map_symbol_filenames): Use
3627         all_objfiles.
3628         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3629         all_objfiles.
3630         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3631         * objc-lang.c (find_methods): Use all_objfiles.
3632         * objfiles.c (have_partial_symbols, have_full_symbols)
3633         (have_minimal_symbols, qsort_cmp)
3634         (default_iterate_over_objfiles_in_search_order): Use
3635         all_objfiles.
3636         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3637         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3638         (maintenance_check_psymtabs): Use all_objfiles.
3639         (ALL_PSYMTABS): Remove.
3640         * compile/compile-object-run.c (do_module_cleanup): Use
3641         all_objfiles.
3642         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3643         * cp-support.c (add_symbol_overload_list_qualified): Use
3644         all_objfiles.
3645         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3646         Use all_objfiles.
3647         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3648         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3649         all_objfiles.
3650         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3651         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3652         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3653         Uses all_objfiles.
3654         * solib.c (solib_read_symbols): Use all_objfiles
3655
3656 2019-01-09  Tom Tromey  <tom@tromey.com>
3657
3658         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3659         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3660         all_objfiles.
3661         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3662         * symmisc.c (print_symbol_bcache_statistics)
3663         (print_objfile_statistics, maintenance_print_objfiles)
3664         (maintenance_info_symtabs, maintenance_check_symtabs)
3665         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3666         all_objfiles.
3667         * source.c (forget_cached_source_info): Use all_objfiles.
3668         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3669         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3670         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3671         * objfiles.c (update_section_map): Use all_objfiles.
3672         (shared_objfile_contains_address_p): Likewise.
3673         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3674         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3675
3676 2019-01-09  Tom Tromey  <tom@tromey.com>
3677
3678         * common/next-iterator.h: New file.
3679         * objfiles.h (class all_objfiles): New.
3680         (struct objfile_iterator): New.
3681
3682 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3683
3684         * NEWS: Move the description of the changed "frame", "select-frame",
3685          and "info frame" commands to the Changed commands section.
3686
3687 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3688
3689         * gdbtypes.c (check_stub_method_group): Remove handling of old
3690         mangling schemes.
3691         * linespec.c (find_methods): Likewise.
3692         * stabsread.c (read_member_functions): Likewise.
3693         * valops.c (search_struct_method): Likewise.
3694         (value_struct_elt_for_reference): Likewise.
3695         * NEWS: Mention this change.
3696
3697 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3698
3699         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3700         print_source_lines.
3701         * source.c (print_source_lines_base): Update line number check.
3702         (print_source_lines): New function.
3703         (source_lines_range::source_lines_range): New function.
3704         * source.h (class source_lines_range): New class.
3705         (print_source_lines): New declaration.
3706
3707 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3708
3709         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3710
3711 2019-01-08  Tom Tromey  <tom@tromey.com>
3712             Simon Marchi  <simon.marchi@ericsson.com>
3713
3714         PR gdb/24060
3715         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3716         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3717         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3718         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3719         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3720         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3721
3722 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * source.c (select_source_symtab): Move header comment to
3725         declaration in source.h.
3726         (forget_cached_source_info_for_objfile): Likewise.
3727         (forget_cached_source_info): Likewise.
3728         (identify_source_line): Likewise.
3729         * source.h (identify_source_line): Move declaration from symtab.h
3730         and add comment from source.c
3731         (print_source_lines): Likewise.
3732         (forget_cached_source_info_for_objfile): Likewise.
3733         (forget_cached_source_info): Likewise.
3734         (select_source_symtab): Likewise.
3735         (enum print_source_lines_flag): Move definition from symtab.h.
3736         * symtab.h (identify_source_line): Move declaration to source.h.
3737         (print_source_lines): Likewise.
3738         (forget_cached_source_info_for_objfile): Likewise.
3739         (forget_cached_source_info): Likewise.
3740         (select_source_symtab): Likewise.
3741         (enum print_source_lines_flag): Move definition to source.h.
3742         * tui/tui-hooks.c: Add 'source.h' include.
3743
3744 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3745
3746         * source.c (print_source_lines_base): Handle requests to print
3747         reverse line number sequences, and guard against empty lines
3748         string.
3749
3750 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3751
3752         * source.c (print_source_lines_base): Fix skip of '\r' if next
3753         character is '\n'.
3754
3755 2019-01-06  Tom Tromey  <tom@tromey.com>
3756
3757         * c-exp.y (struct c_parse_state) <macro_original_text,
3758         expansion_obstack>: New member.
3759         (macro_original_text, expansion_obstack): Remove globals.
3760         (scan_macro_expansion, scanning_macro_expansion)
3761         (finished_macro_expansion): Update.
3762         (scan_macro_cleanup): Remove.
3763         (yylex, c_parse): Update.
3764
3765 2019-01-06  Tom Tromey  <tom@tromey.com>
3766
3767         * c-exp.y (struct c_parse_state) <strings>: New member.
3768         (operator_stoken): Update.
3769
3770 2019-01-06  Tom Tromey  <tom@tromey.com>
3771
3772         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3773         (union type_stack_elt) <typelist_val>: Now a pointer to
3774         std::vector.
3775         (type_stack_cleanup): Don't declare.
3776         (push_typelist): Update.
3777         * parse.c (pop_typelist): Return a std::vector.
3778         (push_typelist): Take a std::vector.
3779         (follow_types): Update.  Do not free args.
3780         (type_stack_cleanup): Remove.
3781         * c-exp.y (struct c_parse_state): New.
3782         (cpstate): New global.
3783         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3784         (nonempty_typelist): Update.
3785         (func_mod): Create a new vector.
3786         (c_parse): Create a c_parse_state.
3787         (check_parameter_typelist): Do not delete params.
3788         (function_method): Update.  Do not delete type_list.
3789
3790 2019-01-06  Tom Tromey  <tom@tromey.com>
3791
3792         PR gdb/28155:
3793         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3794         check_typedef.
3795         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3796         (print_return_value): Likewise.
3797
3798 2019-01-05  Tom Tromey  <tom@tromey.com>
3799
3800         * contrib/cleanup_check.py: Remove.
3801         * contrib/gcc-with-excheck: Remove.
3802         * contrib/exsummary.py: Remove.
3803         * contrib/excheck.py: Remove.
3804
3805 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3806
3807         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3808         NULL. Initialize tpprev to NULL instead of assigning it
3809         to NULL on the next statement.
3810         * windows-nat.c (windows_delete_thread): Remove check for
3811         main_thread_id before printing thread exit notifications.
3812         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3813         Remove thread ID check against main_thread_id.
3814         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3815         windows_delete_thread.
3816         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3817
3818 2019-01-04  Tom Tromey  <tom@tromey.com>
3819
3820         * compile/compile.c (_initialize_compile): Use upper case for
3821         metasyntactic variables.
3822         * symmisc.c (_initialize_symmisc): Use upper case for
3823         metasyntactic variables.
3824         * psymtab.c (_initialize_psymtab): Use upper case for
3825         metasyntactic variables.
3826         * demangle.c (demangle_command): Use upper case for metasyntactic
3827         variables.
3828         (_initialize_demangler): Likewise.
3829         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3830         variables.
3831
3832 2019-01-03  Tom Tromey  <tom@tromey.com>
3833
3834         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3835
3836 2019-01-03  Tom Tromey  <tom@tromey.com>
3837
3838         * python/py-symtab.c (salpy_str): Update.
3839         (struct salpy_sal_object) <symtab>: Now a PyObject.
3840         (salpy_dealloc): Update.
3841         (del_objfile_sal): Use gdbpy_ref.
3842
3843 2019-01-03  Tom Tromey  <tom@tromey.com>
3844
3845         * python/py-type.c (convert_field): Use new_reference.  Return
3846         gdbpy_ref.
3847         (make_fielditem): Return gdbpy_ref.
3848         (typy_fields): Update.
3849         (typy_getitem): Update.
3850         (field_name): Return gdbpy_ref.  Use new_reference.
3851         (typy_iterator_iternext): Update.
3852
3853 2019-01-03  Tom Tromey  <tom@tromey.com>
3854
3855         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3856
3857 2019-01-03  Tom Tromey  <tom@tromey.com>
3858
3859         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3860         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3861         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3862         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3863         (pspy_set_type_printers): Likewise.
3864         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3865         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3866         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3867         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3868         (objfpy_set_type_printers): Likewise.
3869
3870 2019-01-03  Tom Tromey  <tom@tromey.com>
3871
3872         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3873         (gdbpy_print_stack): Use gdbpy_err_fetch.
3874         * python/python-internal.h (class gdbpy_err_fetch): New class.
3875         (class gdbpy_enter) <m_error_type, m_error_value,
3876         m_error_traceback>: Remove.
3877         <m_error>: New member.
3878         (gdbpy_exception_to_string): Don't declare.
3879         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3880         * python/py-value.c (convert_value_from_python): Use
3881         gdbpy_err_fetch.
3882         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3883         gdbpy_exception_to_string.
3884         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3885         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3886         gdbpy_err_fetch.
3887
3888 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * linux-nat.c (delete_lwp_cleanup): Delete.
3891         (struct lwp_deleter): New struct.
3892         (lwp_info_up): New typedef.
3893         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3894         lwp_info_up.
3895
3896 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * linux-fork.c (class scoped_switch_fork_info): New class.
3899         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3900
3901 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * valops.c (find_overload_match): Remove use of null_cleanup, and
3904         calls to do_cleanups.
3905
3906 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * compile/compile-cplus-types.c
3909         (compile_cplus_instance::decl_name): Handle changes to
3910         cp_func_name.
3911         * cp-support.c (cp_func_name): Update header comment, update
3912         return type.
3913         * cp-support.h (cp_func_name): Update return type in declaration.
3914         * valops.c (find_overload_match): Move temp_func local to top
3915         level of function and change its type.  Use temp_func to hold and
3916         delete temporary string obtained from cp_func_name.
3917
3918 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3921         gdb::char_vector, remove cleanup, and update uses of `msg`.
3922
3923 2019-01-03  Jim Wilson  <jimw@sifive.com>
3924
3925         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3926
3927 2019-01-02  Tom Tromey  <tom@tromey.com>
3928
3929         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3930         (tdesc_parse_xml): Remove cleanups.
3931         * target-descriptions.h (make_cleanup_free_target_description):
3932         Don't declare.
3933         (target_desc_deleter): New struct.
3934         (target_desc_up): New typedef.
3935         * target-descriptions.c (target_desc_deleter::operator()): Rename
3936         from free_target_description.
3937         (make_cleanup_free_target_description): Remove.
3938
3939 2019-01-02  Tom Tromey  <tom@tromey.com>
3940
3941         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3942         constructor, destructor.
3943         (linespec_parser): Remove typedef.
3944         (~linespec_parser): Rename from linespec_parser_delete.
3945         (linespec_lex_to_end, linespec_complete_label)
3946         (linespec_complete): Update.
3947         (decode_line_full): Remove cleanups.
3948         (decode_line_1): Update.
3949
3950 2019-01-02  Tom Tromey  <tom@tromey.com>
3951
3952         * python/python-internal.h (inferior_to_inferior_object): Change
3953         return type.
3954         * python/py-exitedevent.c (create_exited_event_object): Update.
3955         * python/py-inferior.c (inferior_to_inferior_object): Return
3956         gdbpy_ref.
3957         (python_new_inferior, python_inferior_deleted)
3958         (thread_to_thread_object, delete_thread_object)
3959         (build_inferior_list, gdbpy_selected_inferior): Update.
3960         * python/py-infthread.c (create_thread_object): Update.  Also fail
3961         if inferior_to_inferior_object fails.
3962
3963 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3964
3965         * inferior.h (class inferior) <displaced_step_state>: New field.
3966         * infrun.h (struct displaced_step_state): Move here from
3967         infrun.c.  Initialize fields, add constructor.
3968         <inf>: Remove field.
3969         <reset>: New method.
3970         * infrun.c (struct displaced_step_inferior_state): Move to
3971         infrun.h.
3972         (displaced_step_inferior_states): Remove.
3973         (get_displaced_stepping_state): Adust.
3974         (displaced_step_in_progress_any_inferior): Adjust.
3975         (displaced_step_in_progress_thread): Adjust.
3976         (displaced_step_in_progress): Adjust.
3977         (add_displaced_stepping_state): Remove.
3978         (get_displaced_step_closure_by_addr): Adjust.
3979         (remove_displaced_stepping_state): Remove.
3980         (infrun_inferior_exit): Call displaced_step_state.reset.
3981         (use_displaced_stepping): Don't check for NULL.
3982         (displaced_step_prepare_throw): Call
3983         get_displaced_stepping_state.
3984         (displaced_step_fixup): Don't check for NULL.
3985         (prepare_for_detach): Don't check for NULL.
3986
3987 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3988
3989         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3990          in case of call that did not complete.
3991
3992 2019-01-02  Andrey Utkin  <autkin@undo.io>
3993
3994         * symfile.c (find_separate_debug_file): Fix search of debug files for
3995         remote debuggee.
3996
3997 2019-01-02  Tom Tromey  <tom@tromey.com>
3998
3999         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4000         indentation.
4001         * python/py-frame.c (frapy_older): Remove cast.
4002         (frapy_newer): Likewise.
4003         * python/py-breakpoint.c (local_setattro): Remove cast.
4004         * python/py-arch.c (archpy_name): Remove local variable.
4005         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4006
4007 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4008
4009         * unittests/basic_string_view/element_access/char/empty.cc:
4010         Fix year range in copyright header.
4011
4012 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4015         Delete.
4016         <operator==>: Update with for removed field.
4017         <hash>: Likewise.
4018         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4019         <isa_features>: ...this.
4020         <abi_features>: New field.
4021         (riscv_isa_flen): Update comment.
4022         (riscv_abi_xlen): New declaration.
4023         (riscv_abi_flen): New declaration.
4024         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4025         isa_features.
4026         (riscv_abi_xlen): New function.
4027         (riscv_isa_flen): Update to get answer from isa_features.
4028         (riscv_abi_flen): New function.
4029         (riscv_has_fp_abi): Update to get answer from abi_features.
4030         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4031         xlen and flen.
4032         (riscv_call_info) <xlen, flen>: Update comment.
4033         (riscv_call_arg_struct): Remove invalid assertions
4034         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4035         is removed.
4036         (riscv_gdbarch_init): Gather isa features and abi features
4037         separately, ensure both match on the gdbarch when reusing an old
4038         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4039         a target with 64-bit float hardware.
4040
4041 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4042
4043         * source.c (search_command_helper): Stop reverse search
4044         when line 1 has been searched.
4045
4046 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4047
4048         * record-full.c (record_full_base_target::close): Rewrite
4049         record_full_core_buf_list free logic.
4050
4051 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4052
4053         * break-catch-syscall.c (print_one_catch_syscall): xfree
4054         the last text.
4055
4056 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4057
4058         * top.c (print_gdb_version): Update Copyright year in version
4059         message.
4060
4061 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4062
4063         Update copyright year range in all GDB files.
4064
4065 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4066
4067         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4068
4069 For older changes see ChangeLog-2018.
4070 \f
4071 Local Variables:
4072 mode: change-log
4073 left-margin: 8
4074 fill-column: 74
4075 version-control: never
4076 coding: utf-8
4077 End:
4078