gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * remote-sim.c (struct sim_inferior_data): Add initializers,
   4         constructor, and destructor.
   5         (sim_inferior_data_key): Change type.  Move lower.
   6         (check_for_duplicate_sim_descriptor): Update.
   7         (get_sim_inferior_data): Use new.  Update.
   8         (~sim_inferior_data_cleanup): Rename from
   9         sim_inferior_data_cleanup.  Simplify.
  10         (gdbsim_close_inferior, simulator_command)
  11         (sim_command_completer, _initialize_remote_sim): Update.
  12         (next_pid, INITIAL_PID): Move earlier.
  13
  14 2019-07-10  Tom Tromey  <tromey@adacore.com>
  15
  16         * python/python-internal.h (create_thread_object): Return
  17         gdbpy_ref.
  18         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
  19         * python/py-inferior.c (struct threadlist_entry): Add
  20         constructor.
  21         <thread_obj>: Now a gdbpy_ref.
  22         (thread_to_thread_object): Update.
  23         (add_thread_object): Use new.
  24         (delete_thread_object): Use delete.
  25         (infpy_threads): Update.
  26         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
  27         GIL.
  28
  29 2019-07-10  Tom Tromey  <tromey@adacore.com>
  30
  31         * valops.c (value_cast): Specialize error message for Ada.
  32
  33 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  34
  35         * breakpoint.c (breakpoint_1): Update doc and parameter names.
  36
  37 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
  38
  39         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
  40         bpstat_should_step): Return bool, adjust comments.
  41         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
  42         bpstat_should_step): Likewise.
  43
  44 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  45
  46         * features/Makefile: Use feature target descriptions for Arm.
  47         * features/arm/arm-core.c: Generate new file.
  48         * features/arm/arm-fpa.c: Likewise.
  49         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
  50         * features/arm/arm-m-profile.c: Likewise.
  51         * features/arm/arm-vfpv2.c: Likewise.
  52         * features/arm/arm-vfpv3.c: Likewise.
  53         * features/arm/xscale-iwmmxt.c: Likewise.
  54         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
  55
  56 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  57
  58         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
  59         ptrace earlier.
  60
  61 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
  62
  63         * features/aarch64-pauth.c: Regenerate.
  64
  65 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
  66
  67         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
  68         bool.
  69         (bpstat_what): Use false instead of 0.
  70
  71 2019-07-09  Pedro Alves  <palves@redhat.com>
  72
  73         * break-catch-throw.c (is_exception_catchpoint): New.
  74         * breakpoint.c (print_one_breakpoint_location): New parameter
  75         'raw_loc'.  Handle it.  Use
  76         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  77         looking at the breakpoint's type.
  78         (print_one_breakpoint): If handling "maint info breakpoints", also
  79         print locations of exception catchpoints.
  80         * breakpoint.h (is_exception_catchpoint): Declare.
  81
  82 2019-07-09  Pedro Alves  <palves@redhat.com>
  83
  84         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  85         "addr" field.
  86         (allocate_location_exception_catchpoint): New.
  87         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  88         (initialize_throw_catchpoint_ops): Install
  89         allocate_location_exception_catchpoint as allocate_location
  90         method.
  91         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  92         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  93         bp_loc_other.
  94         (breakpoint_address_is_meaningful): Delete.
  95         (bl_address_is_meaningful): New.
  96         (breakpoint_locations_match): Adjust comment.
  97         (bp_location_from_bp_type): New, factored out of...
  98         (bp_location::bp_location(breakpoint *)): ... this.
  99         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 100         factored out of...
 101         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 102         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 103         breakpoint_address_is_meaningful.
 104         (bp_locations_compare): Adjust comment.
 105         (update_global_location_list): Use bl_address_is_meaningful
 106         instead of breakpoint_address_is_meaningful.
 107         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 108         explicit.
 109         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 110         * python/py-breakpoint.c (bppy_get_location): No longer check
 111         whether location is null.
 112
 113 2019-07-09  Pedro Alves  <palves@redhat.com>
 114
 115         PR c++/15468
 116         * breakpoint.c (print_one_breakpoint_location): Remove
 117         single-location assert.
 118
 119 2019-07-09  Tom Tromey  <tom@tromey.com>
 120
 121         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 122         * configure: Rebuild.
 123         * configure.ac: Change common to gdbsupport.
 124         * gdbsupport: Rename from common.
 125         * acinclude.m4: Change common to gdbsupport.
 126         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 127         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 128         gdbsupport.
 129         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 130         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 131         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 132         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 133         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 134         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 135         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 136         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 137         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 138         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 139         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 140         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 141         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 142         coff-pe-read.c, command.h, compile/compile-c-support.c,
 143         compile/compile-c.h, compile/compile-cplus-symbols.c,
 144         compile/compile-cplus-types.c, compile/compile-cplus.h,
 145         compile/compile-loc2c.c, compile/compile.c, completer.c,
 146         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 147         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 148         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 149         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 150         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 151         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 152         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 153         features/aarch64-core.c, features/aarch64-fpu.c,
 154         features/aarch64-pauth.c, features/aarch64-sve.c,
 155         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 156         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 157         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 158         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 159         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 160         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 161         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 162         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 163         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 164         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 165         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 166         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 167         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 168         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 169         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 170         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 171         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 172         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 173         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 174         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 175         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 176         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 177         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 178         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 179         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 180         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 181         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 182         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 183         minsyms.c, mips-linux-tdep.c, namespace.h,
 184         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 185         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 186         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 187         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 188         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 189         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 190         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 191         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 192         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 193         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 194         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 195         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 196         procfs.c, producer.c, progspace.h, psymtab.h,
 197         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 198         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 199         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 200         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 201         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 202         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 203         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 204         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 205         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 206         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 207         target-memory.c, target.c, target.h, target/waitstatus.c,
 208         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 209         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 210         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 211         unittests/array-view-selftests.c,
 212         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 213         unittests/common-utils-selftests.c,
 214         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 215         unittests/format_pieces-selftests.c,
 216         unittests/function-view-selftests.c,
 217         unittests/lookup_name_info-selftests.c,
 218         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 219         unittests/mkdir-recursive-selftests.c,
 220         unittests/observable-selftests.c,
 221         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 222         unittests/parse-connection-spec-selftests.c,
 223         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 224         unittests/scoped_fd-selftests.c,
 225         unittests/scoped_mmap-selftests.c,
 226         unittests/scoped_restore-selftests.c,
 227         unittests/string_view-selftests.c, unittests/style-selftests.c,
 228         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 229         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 230         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 231         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 232         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 233         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 234
 235 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 236
 237         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 238         bool value.
 239         (decode_digits_ordinary): Set explicit_line field in sal.
 240         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 241         symtab_and_line that was set on an explicit line number in
 242         assembler code.  Do always update the recorded symtab and line if
 243         we do skip the prologue.
 244
 245 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 246
 247         * breakpoint.c (set_breakpoint_location_function): Remove
 248         explicit_loc parameter.
 249         (momentary_breakpoint_from_master): Update call to
 250         set_breakpoint_location_function.
 251         (add_location_to_breakpoint): Likewise.
 252
 253 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 254
 255         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 256         required features based on default bfd type when no specific bfd
 257         is present.
 258
 259 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 260
 261         * NEWS: Mention that GDB printf and eval commands can now print
 262         C-style and Ada-style convenience var strings without
 263         calling the inferior.
 264         * printcmd.c (printf_c_string): Locally print GDB internal var
 265         instead of transiting via the inferior.
 266         (printf_wide_c_string): Likewise.
 267
 268 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 269
 270         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 271
 272 2019-07-04  Tom Tromey  <tom@tromey.com>
 273
 274         PR tui/24724:
 275         * tui/tui-winsource.c (tui_clear_source_content): Update.
 276         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 277         (tui_update_breakpoint_info): Update.
 278         (tui_set_exec_info_content): Update.
 279         * tui/tui-source.c (tui_set_source_content_nil): Update.
 280         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 281         has_break.
 282         * tui/tui-data.h (enum tui_bp_flag): New.
 283         (tui_bp_flags): New enum flags type.
 284         (struct tui_source_element) <break_mode>: Change type.  Rename
 285         from has_break.
 286         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 287         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 288         constants.
 289         * tui/tui-winsource.h: Fix comment.
 290
 291 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 292
 293         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 294         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 295         (store_fpregs_to_thread)
 296         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 297         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 298         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 299         (IWMMXT_REGS_SIZE): Add define.
 300         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 301         (fetch_vfp_regs, store_vfp_regs)
 302         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 303         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 304
 305 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 306
 307         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 308         defines.
 309         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 310         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 311         (ARM_INT_REGISTER_SIZE): ...to this.
 312         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 313         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 314         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 315         (arm_linux_collect_gregset, supply_nwfpe_register)
 316         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 317         defines.
 318         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 319         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 320         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 321         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 322         (arm_return_in_memory, arm_store_return_value)
 323         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 324         (arm_record_ld_st_multiple): Likewise.
 325         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 326         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 327
 328 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 329
 330         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 331         AARCH64_DISPLACED_MODIFIED_INSNS.
 332         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 333         (aarch64_displaced_step_copy_insn): Likewise.
 334         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 335         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 336         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 337         ARM_DISPLACED_MODIFIED_INSNS.
 338         * arm-tdep.c (arm_gdbarch_init): Likewise.
 339         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 340         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 341         (struct arm_displaced_step_closure): Use
 342         ARM_DISPLACED_MODIFIED_INSNS.
 343
 344 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 345
 346         * features/Makefile: Remove unused xml files.
 347         * features/aarch64.xml: Remove.
 348         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 349         * features/i386/amd64-avx-avx512.xml: Remove.
 350         * features/i386/amd64-avx-linux.xml: Remove.
 351         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 352         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 353         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 354         * features/i386/amd64-avx-mpx.xml: Remove.
 355         * features/i386/amd64-avx.xml: Remove.
 356         * features/i386/amd64-linux.xml: Remove.
 357         * features/i386/amd64-mpx-linux.xml: Remove.
 358         * features/i386/amd64-mpx.xml: Remove.
 359         * features/i386/amd64.xml: Remove.
 360         * features/i386/i386-avx-avx512-linux.xml: Remove.
 361         * features/i386/i386-avx-avx512.xml: Remove.
 362         * features/i386/i386-avx-linux.xml: Remove.
 363         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 364         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 365         * features/i386/i386-avx-mpx-linux.xml: Remove.
 366         * features/i386/i386-avx-mpx.xml: Remove.
 367         * features/i386/i386-avx.xml: Remove.
 368         * features/i386/i386-linux.xml: Remove.
 369         * features/i386/i386-mmx-linux.xml: Remove.
 370         * features/i386/i386-mmx.xml: Remove.
 371         * features/i386/i386-mpx-linux.xml: Remove.
 372         * features/i386/i386-mpx.xml: Remove.
 373         * features/i386/i386.xml: Remove.
 374         * features/i386/x32-avx-avx512-linux.xml: Remove.
 375         * features/i386/x32-avx-linux.xml: Remove.
 376         * features/i386/x32-linux.xml: Remove.
 377
 378 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 379
 380         * regformats/aarch64.dat: Remove.
 381         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 382         * regformats/i386/amd64-avx-linux.dat: Remove.
 383         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 384         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 385         * regformats/i386/amd64-linux.dat: Remove.
 386         * regformats/i386/amd64-mpx-linux.dat: Remove.
 387         * regformats/i386/amd64.dat: Remove.
 388         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 389         * regformats/i386/i386-avx-linux.dat: Remove.
 390         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 391         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 392         * regformats/i386/i386-linux.dat: Remove.
 393         * regformats/i386/i386-mmx-linux.dat: Remove.
 394         * regformats/i386/i386-mpx-linux.dat: Remove.
 395         * regformats/i386/i386.dat: Remove.
 396         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 397         * regformats/i386/x32-avx-linux.dat: Remove.
 398         * regformats/i386/x32-linux.dat: Remove.
 399
 400 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 401
 402         * aarch64-tdep.c: Remove xml self tests.
 403         * amd64-linux-tdep.c: Likewise.
 404         * amd64-tdep.c: Likewise.
 405         * i386-linux-tdep.c: Likewise.
 406         * i386-tdep.c: Likewise.
 407
 408 2019-07-03  Pedro Alves  <palves@redhat.com>
 409
 410         PR cli/24732
 411         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 412         (pipe_cmd_option_defs): New.
 413         (make_pipe_cmd_options_def_group): New.
 414         (pipe_command): Use gdb::option::process_options.
 415         (pipe_command_completer): New function.
 416         (_initialize_cli_cmds): Install completer for "pipe" command.
 417
 418 2019-07-03  Pedro Alves  <palves@redhat.com>
 419
 420         * cli/cli-option.c (union option_value) <string>: New field.
 421         (struct option_def_and_value): Add ctor, move ctor, dtor and
 422         use DISABLE_COPY_AND_ASSIGN.
 423         (option_def_and_value::clear_value): New.
 424         (parse_option, save_option_value_in_ctx, get_val_type_str)
 425         (add_setshow_cmds_for_options): Handle var_string.
 426         * cli-option.h (union option_def::var_address) <string>: New
 427         field.
 428         (struct string_option_def): New.
 429         * maint-test-options.c (struct test_options_opts): Add default
 430         ctor and use DISABLE_COPY_AND_ASSIGN.
 431         <string_opt>: New field.
 432         (test_options_opts::~test_options_opts): New.
 433         (test_options_opts::dump): Also dump "-string".
 434         (test_options_option_defs): Install "string.
 435
 436 2019-07-03  Pedro Alves  <palves@redhat.com>
 437
 438         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 439         option_value with a null enumeration.
 440         (complete_options): Save the option values in the context.
 441         (save_option_value_in_ctx): New, factored out from ...
 442         (process_options): ... here.
 443         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 444         of the function.
 445         * maint-test-options.c (test_options_opts::dump): New, factored
 446         out from ...
 447         (maintenance_test_options_command_mode): ... here.
 448         (maintenance_test_options_command_completion_result): Delete.
 449         (maintenance_test_options_command_completion_text): Update
 450         comment.
 451         (maintenance_show_test_options_completion_result): Change
 452         prototype.  Just print
 453         maintenance_test_options_command_completion_text.
 454         (save_completion_result): New.
 455         (maintenance_test_options_completer_mode): Pass options context to
 456         complete_options, and then save a dump.
 457         (_initialize_maint_test_options): Use add_cmd to install "maint
 458         show test-options-completion-result".
 459
 460 2019-07-03  Pedro Alves  <palves@redhat.com>
 461
 462         * NEWS (New commands): Mention "with" and "maint with".
 463         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 464         (with_command, with_command_completer): New.
 465         (pipe_command): Adjust to new repeat_previous
 466         interface.
 467         (_initialize_cli_cmds): Install the "with" command and its "w"
 468         alias.
 469         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 470         declarations.
 471         * cli/cli-setshow.c (parse_cli_var_uinteger)
 472         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 473         argument strings for all var_types.
 474         (get_setshow_command_value_string): New, factored out from ...
 475         (do_show_command): ... this.
 476         * cli/cli-setshow.h: Include <string>.
 477         (get_setshow_command_value_string): Declare.
 478         * command.h (repeat_previous): Now returns const char *.  Adjust
 479         comment.
 480         * maint.c: Include "cli/cli-cmds.h".
 481         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 482         (_initialize_maint_cmds): Register the "maintenance with" command.
 483         * top.c (repeat_previous): Move bits from pipe_command here:
 484         Return the saved command line, if any; error out if there's no
 485         command to relaunch.
 486
 487 2019-07-03  Pedro Alves  <palves@redhat.com>
 488
 489         * NEWS (New commands): Mention "maint set/show test-settings"
 490         instead of "maint test-settings".
 491         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 492         (maintenance_test_settings_set_list): Rename to ...
 493         (maintenance_set_test_settings_list): ... this.
 494         (maintenance_test_settings_show_list): Rename to  ...
 495         (maintenance_show_test_settings_list): ... this.
 496         (maintenance_test_settings_cmd): Delete.
 497         (maintenance_test_settings_set_cmd): ...
 498         (maintenance_set_test_settings_cmd): ... this.
 499         (maintenance_test_settings_show_cmd): ...
 500         (maintenance_show_test_settings_cmd): ... this.
 501         (maintenance_test_settings_show_value_cmd):
 502         (maintenance_show_test_settings_value_cmd): ... this.
 503         (_initialize_maint_test_settings): No longer install the "maint
 504         test-settings" prefix command.  Rename "maint test-settings set"
 505         to "maint set test-settings", and "maint test-settings show" to
 506         "maint show test-settings".  Adjust all subcommands.
 507
 508 2019-07-03  Pedro Alves  <palves@redhat.com>
 509
 510         * maint-test-settings.c: Fix file's intro comment.  Replace all
 511         references to "test-options" with references to "test-settings",
 512         in comments.
 513
 514 2019-07-03  Pedro Alves  <palves@redhat.com>
 515
 516         * maint-test-settings.c (maintenance_test_settings_xxx)
 517         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 518         New.
 519         (maintenance_test_settings_enums): Use them.
 520         (maintenance_test_settings_enum): Default to
 521         maintenance_test_settings_xxx.
 522         (_initialize_maint_test_settings): Initialize
 523         MAINTENANCE_TEST_SETTINGS_FILENAME.
 524
 525 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 526
 527         * breakpoint.h (remove_breakpoints_inf): Change return type to
 528         void, move function documentation here.
 529         * breakpoint.c (remove_breakpoints_inf): Change return type to
 530         void, move function documentation to header.
 531
 532 2019-07-02  Pedro Alves  <palves@redhat.com>
 533
 534         * NEWS (Completion improvements): Mention "info threads".
 535         * thread.c (struct info_threads_opts, info_threads_option_defs)
 536         (make_info_threads_options_def_group): New.
 537         (info_threads_command): Use gdb::option::process_options.
 538         (info_threads_command_completer): New.
 539         (_initialize_thread): Use gdb::option::build_help to build the
 540         help text for "info threads".
 541
 542 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 543
 544         * defs.h (generic_load): Move from here...
 545         * symfile.h (generic_load): ... to here.  Rename name parameter
 546         to args.
 547         * symfile.c (generic_load): Add comment.
 548
 549 2019-07-01  Tom Tromey  <tromey@adacore.com>
 550
 551         * dwarf2read.c
 552         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 553         declaration of without_params.  Fix formatting.
 554
 555 2019-07-01  Tom Tromey  <tromey@adacore.com>
 556
 557         * ada-exp.y (find_primitive_type): Update.
 558         * ada-lang.h (ada_lookup_symbol): Update.
 559         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 560         parameter.
 561         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 562
 563 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 564
 565         PR breakpoints/24541
 566         * gdbarch.c: Regenerate.
 567         * gdbarch.h: Regenerate.
 568         * gdbarch.sh: Add 'stap_adjust_register'.
 569         * i386-tdep.c: Include '<unordered_set>'.
 570         (i386_stap_adjust_register): New function.
 571         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 572         * stap-probe.c (stap_parse_register_operand): Call
 573         'gdbarch_stap_adjust_register'.
 574
 575 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 576
 577         PR python/24742
 578         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 579         * python/python.c (do_start_initialization): Use 'xmalloc'
 580         instead of 'PyMem_Malloc'.
 581
 582 2019-06-28  Tom Tromey  <tromey@adacore.com>
 583
 584         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 585         for Ada.
 586
 587 2019-06-27  Tom Tromey  <tromey@adacore.com>
 588
 589         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 590         objfile_key.
 591         (arm_find_mapping_symbol, arm_record_special_symbol)
 592         (_initialize_arm_tdep): Update.
 593         (arm_objfile_data_free): Remove.
 594
 595 2019-06-27  Tom Tromey  <tromey@adacore.com>
 596
 597         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 598         to cp_print_static_field.
 599
 600 2019-06-26  Tom Tromey  <tromey@adacore.com>
 601
 602         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 603         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 604         declare.
 605
 606 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 607
 608         * features/aarch64-core.c (create_feature_aarch64_core):
 609         Regenerate.
 610         * features/aarch64-core.xml: Add cpsr flags.
 611
 612 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 613
 614         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 615         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 616
 617 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 618
 619         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 620         field.
 621         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 622         use.
 623         (arm_record_special_symbol): Don't insert new symbol in sorted
 624         position, push it at the end.
 625
 626 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 627
 628         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 629         (arm_mapping_symbol_s): Remove.
 630         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 631         (arm_mapping_symbol_vec): New typedef.
 632         (struct arm_per_objfile): Add constructor.
 633         <section_maps>: Change type to
 634         std::unique_ptr<arm_mapping_symbol_vec[]>.
 635         (arm_compare_mapping_symbols): Remove.
 636         (arm_find_mapping_symbol): Adjust to section_maps type change.
 637         (arm_objfile_data_free): Call delete on arm_per_objfile.
 638         (arm_record_special_symbol): Adjust to section_maps type change.
 639         Allocate arm_per_objfile with new.
 640
 641 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 642
 643         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 644         with the command prefix.
 645
 646 2019-06-25  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 649         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 650
 651 2019-06-25  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 654         type.
 655         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 656         protected.
 657
 658 2019-06-25  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-winsource.c
 661         (tui_source_window_base::set_is_exec_point_at): Add check against
 662         LOA_ADDRESS.
 663
 664 2019-06-25  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-source.c (tui_set_source_content): Don't check before
 667         xfree.
 668         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 669
 670 2019-06-25  Tom Tromey  <tom@tromey.com>
 671
 672         * tui/tui-winsource.h (tui_update_source_window_as_is)
 673         (tui_alloc_source_buffer, tui_line_is_displayed)
 674         (tui_addr_is_displayed): Change type of win_info.
 675         * tui/tui-winsource.c (tui_update_source_window_as_is)
 676         (tui_clear_source_content, tui_show_source_line)
 677         (tui_show_source_content, tui_source_window_base::refill)
 678         (tui_source_window_base::set_is_exec_point_at)
 679         (tui_source_window_base::set_is_exec_point_at)
 680         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 681         (tui_alloc_source_buffer, tui_line_is_displayed)
 682         (tui_addr_is_displayed): Change type of win_info.  Update.
 683         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 684         (tui_source_window_base::do_make_visible_with_new_height):
 685         Update.
 686         * tui/tui-source.c (tui_set_source_content)
 687         (tui_set_source_content_nil)
 688         (tui_source_window::do_scroll_vertical): Update.
 689         * tui/tui-layout.c (show_layout): Update.
 690         * tui/tui-disasm.c (tui_set_disassem_content)
 691         (tui_disasm_window::do_scroll_vertical): Update.
 692         * tui/tui-data.h (tui_win_content): Remove.
 693         (struct tui_gen_win_info) <content, content_size>: Remove.
 694         (struct tui_source_element): Add initializers and destructor.
 695         (union tui_which_element, struct tui_win_element): Remove.
 696         (struct tui_source_window_base) <content>: New field.
 697         (struct tui_data_window): Remove destructor.
 698         (tui_alloc_content, tui_free_win_content)
 699         (tui_free_all_source_wins_content): Don't declare.
 700         * tui/tui-data.c (tui_initialize_static_data): Update.
 701         (init_content_element, tui_alloc_content): Remove.
 702         (~tui_gen_win_info): Update.
 703         (~tui_data_window, tui_free_all_source_wins_content)
 704         (tui_free_win_content, free_content, free_content_elements):
 705         Remove.
 706
 707 2019-06-25  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-winsource.h (tui_clear_source_content)
 710         (tui_erase_source_content, tui_show_source_content): Change type
 711         of win_info.
 712         * tui/tui-winsource.c (tui_clear_source_content)
 713         (tui_erase_source_content, tui_show_source_content): Change type
 714         of win_info.
 715         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 716         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 717         win_info.
 718         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 719         win_info.
 720         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 721
 722 2019-06-25  Tom Tromey  <tom@tromey.com>
 723
 724         * tui/tui-winsource.c (tui_clear_source_content)
 725         (tui_source_window_base::set_is_exec_point_at): Update.
 726         * tui/tui-source.c (tui_set_source_content_nil): Update.
 727         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 728         a bool.
 729         * tui/tui-data.c (init_content_element): Update.
 730
 731 2019-06-25  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 734         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 735         * tui/tui-layout.c (init_and_make_win): Update.
 736         * tui/tui.h (enum tui_win_type): Update.
 737         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 738         tui_win_is_auxillary.
 739         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 740         tui_win_is_auxillary.
 741
 742 2019-06-25  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 745         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 746         (tui_delete_data_content_windows, tui_display_all_data)
 747         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 748         Update.
 749         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 750         * tui/tui-regs.c (tui_last_regs_line_no)
 751         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 752         (tui_show_registers): Update.
 753         (tui_show_register_group): Return void.  Update.
 754         (tui_display_registers_from, tui_display_reg_element_at_line)
 755         (tui_display_registers_from_line, tui_check_register_values):
 756         Update.
 757         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 758         member.
 759         (struct tui_data_window) <regs_content>: Now a std::vector.
 760         <regs_content_count>: Remove.
 761         (tui_add_content_elements, tui_free_data_content): Don't declare.
 762         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 763         (init_content_element): Remove DATA_WIN case.  Add assert.
 764         (tui_add_content_elements): Remove.
 765         (tui_data_window): Update.
 766         (tui_free_data_content): Remove.
 767         (free_content_elements): Remove DATA_WIN case.
 768
 769 2019-06-25  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-data.c (tui_data_item_window): Update.
 772         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 773         * tui/tui-windata.c (tui_display_all_data)
 774         (tui_display_data_from_line): Update.
 775         (tui_check_data_values): Remove.
 776         * tui/tui-regs.c (tui_show_register_group)
 777         (tui_display_reg_element_at_line): Update.
 778         * tui/tui-hooks.c (tui_register_changed)
 779         (tui_refresh_frame_and_register_information): Call
 780         tui_check_register_values.
 781         * tui/tui-data.h (struct tui_data_window) <data_content,
 782         data_content_count, data_type>: Remove.
 783         (enum tui_data_type): Remove.
 784
 785         * tui/tui-data.c (tui_data_window::clear_detail)
 786         (~tui_data_window): Update.
 787
 788 2019-06-25  Tom Tromey  <tom@tromey.com>
 789
 790         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 791         declare.
 792         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 793         Rename from tui_first_data_item_displayed.  Update.
 794         (tui_data_window::refresh_all)
 795         (tui_data_window::do_scroll_vertical): Update.
 796         * tui/tui-data.h (struct tui_data_window)
 797         <first_data_item_displayed>: Declare new method.
 798
 799 2019-06-25  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 802         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 803         contents...
 804         (tui_initialize_static_data): ...here.
 805
 806 2019-06-25  Tom Tromey  <tom@tromey.com>
 807
 808         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 809         (tui_display_registers_from, tui_check_register_values): Update.
 810         (tui_display_register): Remove win_info parameter; update.
 811         (tui_get_register): Change type of parameters.
 812         * tui/tui-data.h (struct tui_data_element): Remove.
 813         (union tui_which_element) <data>: Remove.
 814         <data_window>: Change type.
 815         (struct tui_data_item_window): New.
 816         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 817         case.  Add assert.
 818         (~tui_data_item_window): New destructor.
 819         (free_content_elements): Remove DATA_ITEM_WIN case.
 820
 821 2019-06-25  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 824         Remove.
 825
 826 2019-06-25  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-data.h (struct tui_command_element): Remove.
 829         (union tui_which_element) <command>: Remove.
 830         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 831         assert.
 832         (free_content_elements): Remove CMD_WIN case.
 833
 834 2019-06-25  Tom Tromey  <tom@tromey.com>
 835
 836         * tui/tui-layout.c (tui_set_layout): Update.
 837         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 838         * tui/tui-data.c (layout_def): Update.
 839
 840 2019-06-25  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 843         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 844         (tui_source_window_base::set_new_height): Update.
 845         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 846         Update.
 847         (tui_set_locator_fullname, tui_set_locator_info)
 848         (tui_show_frame_info): Update.
 849         * tui/tui-source.c (tui_set_source_content)
 850         (tui_source_is_displayed): Update.
 851         * tui/tui-layout.c (show_source_disasm_command, show_data)
 852         (show_source_or_disasm_and_command): Update.
 853         * tui/tui-disasm.c (tui_set_disassem_content)
 854         (tui_get_begin_asm_address): Update.
 855         * tui/tui-data.h (struct tui_locator_element): Remove.
 856         (union tui_which_element) <locator>: Remove.
 857         (struct tui_locator_window): New.
 858         (tui_locator_win_info_ptr): Change return type.
 859         * tui/tui-data.c (_locator): Change type.
 860         (tui_locator_win_info_ptr): Change return type.
 861         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 862         (tui_alloc_content): Add assert.
 863
 864 2019-06-25  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-winsource.c
 867         (tui_exec_info_window::maybe_allocate_content): New method.
 868         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 869         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 870         (make_source_or_disasm_window): Add cast.
 871         * tui/tui-data.h (union tui_which_element) <simple_string>:
 872         Remove.
 873         (struct tui_source_info): New.
 874         (struct tui_source_window_base) <execution_info>: Change type.
 875         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 876         case, and add assert.
 877         (tui_alloc_content): Add assert.
 878
 879 2019-06-25  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 882         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 883         * tui/tui-data.c (tui_alloc_win_info): Remove.
 884
 885 2019-06-25  Tom Tromey  <tom@tromey.com>
 886
 887         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 888         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 889         can_highlight.
 890
 891 2019-06-25  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 894         make_visible_with_new_height method.
 895         (tui_win_info::make_visible_with_new_height): New method.
 896         (tui_source_window_base::do_make_visible_with_new_height)
 897         (tui_data_window::do_make_visible_with_new_height)
 898         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 899         (make_visible_with_new_height): Remove.
 900         (tui_resize_all, tui_adjust_win_heights): Use
 901         make_visible_with_new_height method.
 902         * tui/tui-data.h (struct tui_win_info)
 903         <do_make_visible_with_new_height, make_visible_with_new_height>:
 904         New methods.
 905         (struct tui_source_window_base, struct tui_data_window)
 906         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 907         methods.
 908
 909 2019-06-25  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 912         method.
 913         (update_tab_width): Call update_tab_width method.
 914         * tui/tui-data.h (struct tui_win_info)
 915         (struct tui_source_window_base) <update_tab_width>: New methods.
 916
 917 2019-06-25  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 920         parameter.
 921         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 922         parameter.
 923         (tui_gen_win_info::make_visible): Update.
 924         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 925         parameter.
 926         * tui/tui-data.h (enum tui_box): New enum.
 927         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 928
 929 2019-06-25  Tom Tromey  <tom@tromey.com>
 930
 931         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 932         init_and_make_win for EXEC_INFO_WIN.
 933         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 934         longer inline.
 935         (struct tui_win_info) <~tui_win_info>: Inline.
 936         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 937         Don't declare.
 938         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 939         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 940         Remove.
 941         (tui_initialize_static_data): Update.
 942         (~tui_gen_win_info): Handle more cleanup here.
 943         (~tui_source_window_base): Delete "execution_info".
 944         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 945
 946 2019-06-25  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-layout.c (make_command_window): Don't set
 949         can_highlight.
 950         (show_source_disasm_command): Call the reset method.
 951         (show_data): Don't set can_highlight.  Call the reset method.
 952         (tui_gen_win_info::reset): Rename from init_gen_win_info
 953         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 954         (show_source_or_disasm_and_command): Call the reset method.
 955         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 956         (struct tui_cmd_window): Set can_highlight.
 957
 958 2019-06-25  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 961         from make_visible.
 962         (tui_make_visible, tui_make_invisible): Rewrite.
 963         (tui_win_info::make_visible): Remove.
 964         (tui_source_window_base::make_visible): Update.
 965         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 966         method.  Moved from...
 967         (struct tui_win_info) <make_visible>: ...here.
 968
 969 2019-06-25  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-winsource.c
 972         (tui_source_window_base::do_scroll_horizontal): Remove direction
 973         parameter.
 974         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 975         direction parameter.
 976         * tui/tui-win.c (tui_win_info::forward_scroll)
 977         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 978         (tui_win_info::right_scroll): Update.
 979         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 980         direction parameter.
 981         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 982         direction parameter.
 983         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 984         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 985         Remove direction parameter.
 986         (struct tui_source_window_base, struct tui_source_window)
 987         (struct tui_disasm_window, struct tui_data_window)
 988         (struct tui_cmd_window): Update.
 989
 990 2019-06-25  Tom Tromey  <tom@tromey.com>
 991
 992         * tui/tui-winsource.h (tui_set_exec_info_content)
 993         (tui_show_exec_info_content, tui_erase_exec_info_content)
 994         (tui_clear_exec_info_content, tui_update_exec_info): Change
 995         argument to tui_source_window_base.
 996         * tui/tui-winsource.c (tui_set_exec_info_content)
 997         (tui_show_exec_info_content, tui_erase_exec_info_content)
 998         (tui_clear_exec_info_content, tui_update_exec_info): Change
 999         argument to tui_source_window_base.
1000
1001 2019-06-25  Tom Tromey  <tom@tromey.com>
1002
1003         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1004         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1005
1006 2019-06-25  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1009         check.
1010
1011 2019-06-25  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1014         type to void.
1015         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1016         type to void.
1017         * tui/tui-source.c (tui_set_source_content): Update.
1018         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1019
1020 2019-06-25  Tom Tromey  <tom@tromey.com>
1021
1022         * tui/tui-win.c (window_name_completer, tui_set_focus)
1023         (tui_all_windows_info): Use name method.
1024         * tui/tui-data.h (struct tui_gen_win_info)
1025         (struct tui_source_window, struct tui_disasm_window)
1026         (struct tui_data_window, struct tui_cmd_window) <name>: New
1027         method.
1028         (tui_win_name): Don't declare.
1029         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1030         (tui_win_name): Remove.
1031
1032 2019-06-25  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-winsource.h (tui_update_source_window)
1035         (tui_update_source_window_as_is): Change parameter type.
1036         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1037         to be a tui_source_window_base.
1038         (tui_update_source_window_as_is): Likewise.
1039         * tui/tui-win.c (make_visible_with_new_height): Update.
1040
1041 2019-06-25  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-winsource.c (tui_erase_source_content)
1044         (tui_show_source_content, tui_show_exec_info_content)
1045         (tui_erase_exec_info_content): Use refresh_window method.
1046         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1047         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1048         from tui_refresh_win.
1049         (tui_data_window::refresh_window): New method.
1050         (tui_win_info::refresh, tui_source_window_base::refresh)
1051         (tui_refresh_all): Use refresh_window method.
1052         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1053         method.
1054         * tui/tui-regs.c (tui_display_register): Call refresh_window
1055         method.
1056         * tui/tui-layout.c (show_source_disasm_command)
1057         (show_source_or_disasm_and_command): Call refresh_window method.
1058         * tui/tui-data.h (struct tui_gen_win_info)
1059         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1060         New method.
1061
1062 2019-06-25  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui.c (tui_rl_other_window, tui_enable)
1065         (tui_is_window_visible, tui_get_command_dimension): Update.
1066         * tui/tui-winsource.c (tui_update_source_window_as_is)
1067         (tui_clear_source_content, tui_erase_source_content)
1068         (tui_show_source_line, tui_source_window_base::refill)
1069         (tui_source_window_base::do_scroll_horizontal)
1070         (tui_source_window_base::set_is_exec_point_at)
1071         (tui_update_breakpoint_info, tui_set_exec_info_content)
1072         (tui_alloc_source_buffer, tui_line_is_displayed)
1073         (tui_addr_is_displayed): Update.
1074         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1075         (tui_check_and_display_highlight_if_needed)
1076         (tui_win_info::make_visible, tui_win_info::refresh)
1077         (tui_refresh_all): Update.
1078         * tui/tui-windata.c (tui_first_data_item_displayed)
1079         (tui_delete_data_content_windows, tui_erase_data_content)
1080         (tui_display_all_data, tui_data_window::refresh_all)
1081         (tui_check_data_values): Update.
1082         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1083         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1084         (tui_win_info::backward_scroll, tui_refresh_all_win)
1085         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1086         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1087         (tui_source_window_base::set_new_height)
1088         (tui_data_window::set_new_height)
1089         (make_invisible_and_set_new_height)
1090         (make_visible_with_new_height, new_height_ok)
1091         (parse_scrolling_args): Update.
1092         * tui/tui-stack.c (tui_show_frame_info): Update.
1093         * tui/tui-source.c (tui_set_source_content)
1094         (tui_set_source_content_nil, tui_source_is_displayed)
1095         (tui_source_window::do_scroll_vertical): Update.
1096         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1097         (tui_display_registers_from, tui_display_reg_element_at_line)
1098         (tui_check_register_values, tui_reg_command): Update.
1099         * tui/tui-layout.c (tui_default_win_height)
1100         (show_source_disasm_command, show_data, init_and_make_win)
1101         (show_source_or_disasm_and_command): Update.
1102         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1103         (tui_redisplay_readline, tui_mld_flush)
1104         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1105         (tui_getc): Update.
1106         * tui/tui-disasm.c (tui_set_disassem_content)
1107         (tui_disasm_window::do_scroll_vertical): Update.
1108         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1109         Now virtual.
1110         (struct tui_win_info): Derive from tui_gen_win_info.
1111         <~tui_win_info>: Mark as override.
1112         <generic>: Remove member.
1113         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1114         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1115         (~tui_data_window, ~tui_win_info)
1116         (tui_free_all_source_wins_content): Update.
1117         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1118
1119 2019-06-25  Tom Tromey  <tom@tromey.com>
1120
1121         * tui/tui-layout.c (init_and_make_win): Use new.
1122         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1123         destructor, initializers.
1124         (tui_alloc_generic_win_info): Don't declare.
1125         * tui/tui-data.c (_locator): Add argument to constructor.
1126         (source_win, disasm_win): New globals.
1127         (exec_info): Remove.
1128         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1129         Update.
1130         (tui_alloc_generic_win_info): Remove.
1131         (init_content_element): Use new.
1132         (tui_win_info::tui_win_info): Update.
1133         (free_content_elements) <case DATA_WIN>: Use delete.
1134
1135 2019-06-25  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1138         * tui/tui-windata.c (tui_first_data_item_displayed)
1139         (tui_delete_data_content_windows): Update.
1140         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1141         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1142         (tui_display_registers_from, tui_check_register_values): Update.
1143         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1144         pointer.
1145         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1146         window.
1147         (tui_free_data_content): Update.
1148         (free_content_elements) <case DATA_WIN>: Free the window.
1149
1150 2019-06-25  Tom Tromey  <tom@tromey.com>
1151
1152         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1153         Update.
1154         * tui/tui-layout.c (make_command_window)
1155         (show_source_disasm_command, show_data, init_and_make_win)
1156         (show_source_or_disasm_and_command): Update.
1157         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1158         method.
1159         <can_highight, is_highlighted>: Now bool.
1160         (tui_set_win_highlight): Don't declare.
1161         * tui/tui-data.c (tui_set_win_highlight): Remove.
1162
1163 2019-06-25  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-wingeneral.c (make_visible): Remove check of window
1166         type.
1167
1168 2019-06-25  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-win.c (tui_win_info::max_height)
1171         (tui_cmd_window::max_height): New methods.
1172         (new_height_ok): Call max_height.
1173         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1174         <max_height>: New method.
1175
1176 2019-06-25  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-win.c (tui_source_window_base::set_new_height)
1179         (tui_data_window::set_new_height): New methods.
1180         (make_invisible_and_set_new_height): Call set_new_height method.
1181         * tui/tui-data.h (struct tui_win_info)
1182         (struct tui_source_window_base, struct tui_data_window)
1183         <set_new_height>: New method.
1184
1185 2019-06-25  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1188         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1189         tui_refresh_data_win.
1190         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1191         method.
1192         (tui_refresh_all_win): Call the refresh_all method.
1193         (tui_set_focus): Likewise.
1194         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1195         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1196         Likewise.
1197
1198 2019-06-25  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-winsource.h (tui_refill_source_window)
1201         (tui_set_is_exec_point_at): Don't declare.
1202         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1203         (tui_source_window_base::refill): Rename from
1204         tui_refill_source_window.
1205         (tui_source_window_base::do_scroll_horizontal): Update.
1206         (tui_source_window_base::set_is_exec_point_at): Rename from
1207         tui_set_is_exec_point_at.
1208         (tui_update_all_breakpoint_info): Update.
1209         * tui/tui-stack.c (tui_show_frame_info): Update.
1210         * tui/tui-layout.c (show_data): Add cast.
1211         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1212         * tui/tui-data.h (struct tui_source_window_base) <refill,
1213         set_is_exec_point_at>: New methods.
1214         (tui_source_windows, tui_add_to_source_windows): Update types.
1215         (tui_add_to_source_windows): Remove redundant declaration.
1216         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1217         (tui_source_windows): Change return type.
1218         (tui_clear_source_windows_detail): Update.
1219         (tui_add_to_source_windows): Change type of parameter.
1220         (tui_free_all_source_wins_content): Update.
1221
1222 2019-06-25  Tom Tromey  <tom@tromey.com>
1223
1224         * tui/tui-wingeneral.c (tui_win_info::refresh)
1225         (tui_source_window_base::refresh): New methods.
1226         (tui_refresh_all): Call the refresh method.
1227         * tui/tui-data.h (struct tui_win_info)
1228         (struct tui_source_window_base) <refresh>: New method.
1229
1230 2019-06-25  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui.h (tui_is_window_visible): Return bool.
1233         * tui/tui.c (tui_is_window_visible): Return bool.
1234         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1235         (tui_make_visible, tui_make_invisible)
1236         (tui_win_info::make_visible)
1237         (tui_source_window_base::make_visible, make_all_visible)
1238         (tui_make_all_visible, tui_make_all_invisible): Update.
1239         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1240         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1241         bool.
1242         (struct tui_win_info, struct tui_source_window_base)
1243         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1244         * tui/tui-data.c (tui_init_generic_part): Update.
1245
1246 2019-06-25  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1249         (tui_source_window_base::make_visible): New methods.
1250         (make_all_visible): Make method call.
1251         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1252         (struct tui_source_window_base, struct tui_cmd_window): Override
1253         make_visible.
1254         (tui_win_is_source_type): Don't declare.
1255         * tui/tui-data.c (tui_win_is_source_type): Remove.
1256
1257 2019-06-25  Tom Tromey  <tom@tromey.com>
1258
1259         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1260         NULL check.
1261
1262 2019-06-25  Tom Tromey  <tom@tromey.com>
1263
1264         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1265         Inline constructor.  Add initializers for members.
1266         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1267         constructors; now inline in class.
1268
1269 2019-06-25  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-regs.c (tui_show_registers): Update.
1272         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1273         bool.
1274         * tui/tui-data.c (tui_data_window::clear_detail)
1275         (tui_data_window): Update.
1276
1277 2019-06-25  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-windata.c (tui_display_all_data)
1280         (tui_display_data_from_line, tui_display_data_from)
1281         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1282         Update.
1283         * tui/tui-regs.c (tui_last_regs_line_no)
1284         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1285         (tui_show_registers, tui_show_register_group)
1286         (tui_display_registers_from, tui_display_reg_element_at_line)
1287         (tui_display_registers_from_line, tui_check_register_values)
1288         (tui_reg_next, tui_reg_prev): Update.
1289         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1290         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1291         tui_data_window.
1292         (struct tui_win_info) <detail>: Remove.  Add new fields from
1293         tui_data_info.
1294         (TUI_DATA_WIN): Add cast.
1295         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1296         (~tui_data_window): Simplify.
1297
1298 2019-06-25  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-layout.c (show_source_disasm_command)
1301         (show_source_or_disasm_and_command): Update.
1302         * tui/tui-io.c (update_cmdwin_start_line)
1303         (tui_redisplay_readline): Update.
1304         * tui/tui-data.h (struct tui_command_info): Remove.
1305         (struct tui_win_info) <detail>: Remove command_info member.
1306         (struct tui_data_window) <start_line>: New member, from
1307         tui_command_info.
1308         (TUI_CMD_WIN): Add casts.
1309
1310 2019-06-25  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-winsource.c (tui_update_source_window)
1313         (tui_refill_source_window)
1314         (tui_source_window_base::do_scroll_horizontal)
1315         (tui_update_breakpoint_info, tui_set_exec_info_content)
1316         (tui_show_exec_info_content, tui_erase_exec_info_content)
1317         (tui_clear_exec_info_content): Update.
1318         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1319         Update.
1320         * tui/tui-win.c (make_invisible_and_set_new_height)
1321         (make_visible_with_new_height): Update.
1322         * tui/tui-source.c (tui_set_source_content)
1323         (tui_show_symtab_source): Update.
1324         * tui/tui-layout.c (extract_display_start_addr)
1325         (show_source_disasm_command, show_data)
1326         (make_source_or_disasm_window)
1327         (show_source_or_disasm_and_command): Update.
1328         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1329         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1330         "gdbarch".
1331         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1332         to tui_source_window_base.
1333         (struct tui_win_info) <detail>: Remove source_info member.
1334         (struct tui_source_window_base) <has_locator>: Inline.
1335         Move contents from tui_source_info; rename has_locator member to
1336         m_has_locator.
1337         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1338         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1339         header file.
1340         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1341         Simplify.
1342         (tui_free_all_source_wins_content): Cast to
1343         tui_source_window_base.
1344
1345 2019-06-25  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-win.c (make_invisible_and_set_new_height)
1348         (make_visible_with_new_height): Call has_locator method.
1349         * tui/tui-layout.c (show_source_disasm_command, show_data)
1350         (show_source_or_disasm_and_command): Update for bool change.
1351         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1352         (tui_win_info) <has_locator>: New method.
1353         (struct tui_source_window_base) <has_locator>: New method.
1354         (tui_win_has_locator): Don't declare.
1355         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1356         from tui_win_has_locator.
1357         (tui_source_window_base): Use false, not FALSE.
1358
1359 2019-06-25  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1362         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1363         clear_detail method directly.
1364         (tui_clear_win_detail): Remove.
1365
1366 2019-06-25  Tom Tromey  <tom@tromey.com>
1367
1368         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1369         "this", not TUI_DISASM_WIN.
1370
1371 2019-06-25  Tom Tromey  <tom@tromey.com>
1372
1373         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1374         declare.
1375         * tui/tui-winsource.c
1376         (tui_source_window_base::do_scroll_horizontal): Rename from
1377         tui_horizontal_source_scroll.
1378         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1379         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1380         from tui_vertical_data_scroll.
1381         * tui/tui-win.h (tui_scroll): Don't declare.
1382         * tui/tui-win.c (tui_win_info::forward_scroll)
1383         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1384         (tui_win_info::right_scroll): Rename and update.
1385         (tui_scroll_forward_command, tui_scroll_backward_command)
1386         (tui_scroll_left_command, tui_scroll_right_command): Update.
1387         (tui_scroll): Remove.
1388         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1389         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1390         from tui_vertical_source_scroll.
1391         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1392         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1393         from tui_vertical_disassem_scroll.
1394         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1395         do_scroll_horizontal>: New methods.
1396         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1397         Likewise.
1398         (struct tui_source_window_base): Add do_scroll_horizontal.
1399         (struct tui_source_window, struct tui_disasm_window): Add
1400         do_scroll_vertical.
1401         (struct tui_data_window, struct tui_cmd_window): Add
1402         do_scroll_horizontal and do_scroll_vertical.
1403         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1404
1405 2019-06-25  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-data.h (struct tui_source_window_base): New struct.
1408         (struct tui_source_window): Derive from tui_source_window_base.
1409         (struct tui_disasm_window): New struct.
1410         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1411         from tui_source_window::clear_detail.
1412         (tui_source_window_base): Rename from tui_source_window.
1413         (~tui_source_window_base): Rename from ~tui_source_window.
1414         (tui_alloc_win_info): Create a tui_disasm_window.
1415
1416 2019-06-25  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-data.h (struct tui_source_window)
1419         (struct tui_data_window): Declare destructors.
1420         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1421         destructors.
1422         (tui_win_info): Simplify.
1423
1424 2019-06-25  Tom Tromey  <tom@tromey.com>
1425
1426         * tui/tui-winsource.c (tui_display_main)
1427         (tui_update_source_windows_with_addr)
1428         (tui_update_all_breakpoint_info): Update.
1429         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1430         (new_height_ok, parse_scrolling_args): Update.
1431         * tui/tui-stack.c (tui_show_frame_info): Update.
1432         * tui/tui-data.h (struct tui_list): Remove.
1433         (tui_source_windows): Return a reference to a std::vector.
1434         * tui/tui-data.c (source_windows): Now a std::vector.
1435         (tui_source_windows): Change return type.
1436         (tui_clear_source_windows): Rewrite.
1437         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1438         (tui_free_all_source_wins_content): Rewrite.
1439
1440 2019-06-25  Tom Tromey  <tom@tromey.com>
1441
1442         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1443         (struct tui_data_window, struct tui_cmd_window): Declare
1444         clear_detail method.
1445         * tui/tui-data.c (tui_source_window::clear_detail)
1446         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1447         methods.
1448         (tui_clear_win_detail): Simplify.
1449
1450 2019-06-25  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-layout.c (make_source_window, make_disasm_window)
1453         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1454         Return the new window.
1455         (show_source_disasm_command, show_data)
1456         (show_source_or_disasm_and_command): Update.
1457
1458 2019-06-25  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1461         parameter.  Return the new window.
1462         (show_source_disasm_command): Update and remove NULL check.
1463         (show_source_or_disasm_and_command): Update.
1464
1465 2019-06-25  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1468
1469 2019-06-25  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-data.h (struct tui_win_info): Make constructor
1472         protected.  Make destructor virtual.  Add initializers.
1473         (tui_source_window, tui_data_window, tui_cmd_window): New
1474         classes.
1475         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1476         constructor.  Add "type" parameter.
1477         (tui_source_window, tui_data_window, tui_cmd_window): New
1478         constructors.
1479         (tui_alloc_win_info): Instantiate the appropriate subclass.
1480
1481 2019-06-25  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-win.c (tui_resize_all): Use delete.
1484         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1485         destructor.
1486         (tui_free_window): Don't declare.
1487         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1488         Update.
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-data.h (struct tui_win_info): Add constructor.
1493         * tui/tui-data.c (tui_alloc_win_info): Use new.
1494         (tui_free_window): Use delete.
1495
1496 2019-06-22  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1499         declare.
1500         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1501
1502 2019-06-22  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1505         declare.
1506         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1507
1508 2019-06-22  Tom de Vries  <tdevries@suse.de>
1509
1510         * dwarf2read.c (create_addrmap_from_aranges)
1511         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1512         instead of '%zu'.
1513
1514 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1515
1516         * dwarf2read.h (dwarf2_section_info_def): Remove.
1517         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1518         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1519         std::vector<dwarf2_section_info>.
1520         (struct dwo_file) <~dwo_file>: Remove.
1521         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1522         types field.
1523         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1524         (dwarf2_read_debug_names): Likewise.
1525         (create_debug_types_hash_table): Change parameter type to
1526         array_view, adjust code accordingly.
1527         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1528         (partial_die_info::fixup): Likewise.
1529         (determine_prefix): Likewise.
1530         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1531
1532 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1533
1534         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1535         gdb_bfd_ref_ptr.
1536         <~dwo_file>: Remove call to gdb_bfd_unref.
1537         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1538         gdb_bfd_ref_ptr::get.
1539
1540 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1541
1542         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1543         type to htab_up.
1544         * dwarf2read.c (struct dwo_file): Initialize fields.
1545         <~dwo_file>: New.
1546         (free_dwo_file): Remove, move content to ~dwo_file.
1547         (struct dwo_file_deleter): Remove.
1548         (dwo_file_up>: Remove custom deleter.
1549         (free_dwo_files): Remove.
1550         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1551         dwo_files.
1552         (process_skeletonless_type_units): Call unique_ptr::get.
1553         (allocate_dwo_file_hash_table): Add deleter to created hash
1554         table.  Change return type to htab_up.
1555         (lookup_dwo_file_slot): Don't memset dwo_file, call
1556         unique_ptr::get.
1557         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1558         (create_dwo_unit_in_dwp_v2): Likewise.
1559         (open_and_init_dwo_file): Likewise.
1560         (free_dwo_file_from_slot): Remove.
1561
1562 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1563
1564         * dwarf2read.h (struct dwarf2_section_info) <readin,
1565         is_virtual>: Change type to bool.
1566         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1567         true instead of 1.
1568
1569 2019-06-19  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-data.h (tui_init_content_element): Don't declare.
1572
1573 2019-06-19  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-data.h (tui_init_win_info): Don't declare.
1576
1577 2019-06-19  Tom de Vries  <tdevries@suse.de>
1578
1579         * dwarf2read.h (abstract_to_concrete): Change type to
1580         std::unordered_map<sect_offset, std::vector<sect_offset>,
1581         gdb::hash_enum<sect_offset>>.
1582
1583 2019-06-19  Tom Tromey  <tromey@adacore.com>
1584
1585         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1586         EVAL_AVOID_SIDE_EFFECTS specially.
1587
1588 2019-06-19  Tom Tromey  <tromey@adacore.com>
1589
1590         * source-cache.c (highlighter): New global.
1591         (source_cache::get_source_lines): Create a highlighter on demand.
1592
1593 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1594
1595         * defs.h (deprecated_interactive_hook): Delete declaration.
1596         * interps.c (clear_interpreter_hooks): Remove use of
1597         deprecated_interactive_hook.
1598         * top.c (deprecated_interactive_hook): Delete definition.
1599         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1600
1601 2019-06-18  Tom de Vries  <tdevries@suse.de>
1602
1603         PR gdb/24515
1604         * dwarf2read.h (abstract_to_concrete): Change type from
1605         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1606         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1607         * dwarf2read.c (read_variable): Update.
1608         (dwarf2_fetch_die_loc_sect_off): Update.
1609
1610 2019-06-17  Tom de Vries  <tdevries@suse.de>
1611
1612         PR gdb/24617
1613         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1614         accessing parent[parent_len - 1].
1615
1616 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1617
1618         PR gdb/24364
1619         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1620         call dtrace_process_dof with NULL dof.
1621
1622 2019-06-16  Tom de Vries  <tdevries@suse.de>
1623
1624         PR gdb/24445
1625         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1626
1627 2019-06-16  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1630         (make_all_visible): Use address of member.
1631
1632 2019-06-16  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1635         (tui_free_window, free_content, free_content_elements): Remove
1636         unnecessary cast.
1637         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1638         cast.
1639         * tui/tui-regs.c (tui_show_register_group)
1640         (tui_display_registers_from, tui_display_reg_element_at_line):
1641         Remove unnecessary cast.
1642
1643 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1644
1645         * linux-nat.c (normal_mask): Delete.
1646         (_initialize_linux_nat): Don't initialise normal_mask.
1647
1648 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1649
1650         PR gdb/24445
1651         * dwarf-index-write.h (write_psymtabs_to_index): Add
1652         dwz_basename parameter.
1653         * dwarf-index-write.c (write_gdbindex): Move file writing to
1654         write_gdbindex_1.  Change return type void.
1655         (assert_file_size): Move up, remove filename parameter.
1656         (write_gdbindex_1): New function.
1657         (write_debug_names): Change return type to void, call
1658         assert_file_size.
1659         (struct index_wip_file): New struct.
1660         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1661         file logic to index_wip_file.  Write index for dwz file if
1662         needed.
1663         (save_gdb_index_command): Pass basename of dwz file, if present.
1664         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1665         build-id of dwz file, if present.
1666         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1667         (dwarf2_get_dwz_file): Likewise.
1668         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1669         (dwarf2_get_dwz_file): Likewise.
1670
1671 2019-06-16  Tom Tromey  <tom@tromey.com>
1672
1673         * coffread.c (process_coff_symbol): Use xstrdup.
1674         * value.c (create_internalvar): Use xstrdup.
1675
1676 2019-06-16  Tom Tromey  <tom@tromey.com>
1677
1678         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1679         * breakpoint.c (stopin_command, stopat_command)
1680         (until_break_command, decode_location_default): Remove unnecessary
1681         cast.
1682         * utils.c (subset_compare): Remove unnecessary cast.
1683         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1684         cast.
1685         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1686         cast.
1687         * infcmd.c (path_command): Remove unnecessary cast.
1688         * coffread.c (decode_type): Remove unnecessary cast.
1689         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1690         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1691         * tui/tui-stack.c (tui_show_locator_content)
1692         (tui_show_frame_info): Remove unnecessary cast.
1693         * tui/tui-win.c (tui_scroll_forward_command)
1694         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1695         (parse_scrolling_args): Remove unnecessary cast.
1696         * tui/tui-data.c (init_win_info, tui_del_window)
1697         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1698         (free_content_elements): Remove unnecessary cast.
1699         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1700         unnecessary cast.
1701         * tui/tui-source.c (tui_set_source_content)
1702         (tui_vertical_source_scroll): Remove unnecessary cast.
1703         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1704         cast.
1705         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1706         * tui/tui-regs.c (tui_display_registers_from)
1707         (tui_display_register): Remove unnecessary cast.
1708         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1709         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1710         (make_visible): Remove unnecessary cast.
1711         * tui/tui-winsource.c (tui_erase_source_content)
1712         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1713         unnecessary cast.
1714         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1715         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1716         * stabsread.c (read_type, read_array_type, read_range_type):
1717         Remove unnecessary cast.
1718         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1719         (parse_symbol, parse_type, upgrade_type, parse_external)
1720         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1721         unnecessary cast.
1722         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1723
1724 2019-06-16  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-data.c (tui_alloc_generic_win_info)
1727         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1728         checks.
1729
1730 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1731             Andrew Burgess  <andrew.burgess@embecosm.com>
1732
1733         * f-typeprint.c (f_print_type): Don't return early for not
1734         associated or not allocated types.
1735         (f_type_print_varspec_suffix): Add print_rank parameter and print
1736         ranks of array types in case they dangling.
1737         (f_type_print_base): Add print_rank parameter.
1738
1739 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1740
1741         * NEWS: Mention new MI commands.
1742         * break-catch-throw.c (enum exception_event_kind): Move to
1743         breakpoint.h.
1744         (print_mention_exception_catchpoint): Output text as a single
1745         message.
1746         (catch_exception_command_1): Rename to...
1747         (catch_exception_event): ...this, make non-static, update header
1748         command, and change some parameter types.
1749         (catch_catch_command): Update for changes to
1750         catch_exception_command_1.
1751         (catch_throw_command): Likewise.
1752         (catch_rethrow_command): Likewise.
1753         * breakpoint.c (enum exception_event_kind): Delete.
1754         * breakpoint.h (enum exception_event_kind): Moved here from
1755         break-catch-throw.c.
1756         (catch_exception_event): Declare.
1757         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1758         (mi_cmd_catch_throw): New function.
1759         (mi_cmd_catch_rethrow): New function.
1760         (mi_cmd_catch_catch): New function.
1761         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1762         'catch-catch' entries.
1763         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1764         (mi_cmd_catch_rethrow): Declare.
1765         (mi_cmd_catch_catch): Declare.
1766
1767 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1768
1769         * annotate.c (annotate_source_line): Change return type to void,
1770         update implementation to match.
1771         * annotate.h (annotate_source_line): Change return type to void,
1772         update header comment.
1773         * stack.c (print_frame_info): Don't change what frame information
1774         is printed based on whether annotations are on or not.
1775
1776 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1777
1778         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1779         (annotate_source): Make static.
1780         (annotate_source_line): Moved from source.c and renamed from
1781         identify_source_line.  Update the return type.
1782         * annotate.h (annotate_source): Delete declaration.
1783         (annotate_source_line): Declaration moved from source.h, and
1784         renamed from identify_source_line.  Return type updated.
1785         * source.c (identify_source_line): Moved to annotate.c and renamed
1786         to annotate_source_line.
1787         (info_line_command): Remove check of annotation_level.
1788         * source.h (identify_source_line): Move declaration to annotate.h
1789         and rename to annotate_source_line.
1790         * stack.c: Add 'annotate.h' include.
1791         (print_frame_info): Remove check of annotation_level before
1792         calling annotate_source_line.
1793
1794 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1795
1796         * source-cache.c (source_cache::get_plain_source_lines): Use
1797         open_source_file_with_line_charpos instead of just
1798         open_source_file, remove call to find_source_lines.
1799         (source_cache::get_source_lines): Likewise.
1800         * source.c (find_source_lines): Make static.
1801         (get_filename_and_charpos): Renamed into...
1802         (open_source_file_with_line_charpos): ..this along with changes to
1803         return a scoped_fd, and some other minor clean ups.
1804         (identify_source_line): Use open_source_file_with_line_charpos.
1805         (search_command_helper): Use open_source_file_with_line_charpos
1806         instead of just open_source_file, remove call to
1807         find_source_lines.
1808         * source.h (open_source_file_with_line_charpos): Declare new
1809         function.
1810         (find_source_lines): Delete declaration.
1811
1812 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1813
1814         * source.c (get_filename_and_charpos): Remove fullname
1815         parameter.
1816         (identify_source_line): Update call to get_filename_and_charpos.
1817
1818 2019-06-14  Tom Tromey  <tromey@adacore.com>
1819
1820         PR gdb/24502:
1821         * ui-style.h (skip_ansi_escape): Update comment.
1822         * ui-file.h (class no_terminal_escape_file): New class.
1823         * ui-file.c (no_terminal_escape_file::write)
1824         (no_terminal_escape_file::puts): New methods.
1825         * cli/cli-logging.c (handle_redirections): Use
1826         no_terminal_escape_file.
1827
1828 2019-06-14  Tom Tromey  <tromey@adacore.com>
1829
1830         * NEWS: Move convenience variable news above Python news.
1831
1832 2019-06-14  Tom Tromey  <tom@tromey.com>
1833
1834         * gnulib: Move directory to top-level.
1835         * configure.ac: Don't configure gnulib.
1836         * configure: Rebuild.
1837         * common/common-defs.h: Use new path to gnulib.
1838         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1839         (GNULIB_H): Remove.
1840         (INCGNU): Look in new gnulib location.
1841         (HFILES_NO_SRCDIR): Remove gnulib files.
1842         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1843         (generated_files): Remove GNULIB_H.
1844         ($(LIBGNU), all-lib): Remove targets.
1845         (distclean): Don't mention GNULIB_BUILDDIR.
1846         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1847
1848 2019-06-14  Tom Tromey  <tromey@adacore.com>
1849
1850         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1851         Warn if symbol file does not provide any symbols.
1852
1853 2019-06-14  Tom Tromey  <tromey@adacore.com>
1854
1855         * source.c (find_and_open_source): Respect basenames_may_differ.
1856
1857 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1858
1859         * annotate.c (annotate_breakpoints_invalid): Make use of
1860         scoped_restore_terminal_state.
1861         (annotate_frames_invalid): Likewise.
1862
1863 2019-06-14  Tom Tromey  <tromey@adacore.com>
1864
1865         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1866         allow assignment to an internalvar.
1867
1868 2019-06-14  Tom Tromey  <tromey@adacore.com>
1869
1870         * ada-lex.l: Allow "_" in attribute names.
1871
1872 2019-06-14  Tom Tromey  <tromey@adacore.com>
1873
1874         PR gdb/24653:
1875         * regcache.c (registers_changed): Don't call alloca.
1876         * top.c (execute_command): Don't call alloca.
1877
1878 2019-06-13  Pedro Alves  <palves@redhat.com>
1879
1880         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1881         'expression'.  When parsing an expression, error out if there's
1882         junk after "unlimited".
1883         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1884         (do_set_command): Adjust calls to is_unlimited_literal.
1885
1886 2019-06-13  Pedro Alves  <palves@redhat.com>
1887
1888         * compile/compile.c (make_compile_options_def_group): Add braces
1889         around array_view initializer.
1890         * thread.c (make_thread_apply_all_options_def_group)
1891         (make_thread_apply_all_options_def_group): Likewise.
1892
1893 2019-06-13  Pedro Alves  <palves@redhat.com>
1894
1895         * NEWS (New commands): Mention "maint test-options
1896         require-delimiter", "maint test-options unknown-is-error", "maint
1897         test-options unknown-is-operand" and "maint show
1898         test-options-completion-result".
1899         (New command options, command completion): New section.
1900         (Completion improvements): New section.
1901         Mention that you can abbreviate "unlimited".
1902
1903 2019-06-13  Pedro Alves  <palves@redhat.com>
1904
1905         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1906         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1907         * unittests/cli-utils-selftests.c (test_parse_flags)
1908         (test_parse_flags_qcs): Delete.
1909         (test_cli_utils): Don't call deleted functions.
1910
1911 2019-06-13  Pedro Alves  <palves@redhat.com>
1912
1913         * thread.c: Include "cli/cli-option.h".
1914         (tp_array_compar_ascending): Global.
1915         (tp_array_compar): Delete function.
1916         (tp_array_compar_ascending, tp_array_compar_descending): New
1917         functions.
1918         (ascending_option_def, qcs_flag_option_def)
1919         (thr_qcs_flags_option_defs)
1920         (make_thread_apply_all_options_def_group)
1921         (make_thread_apply_options_def_group): New.
1922         (thread_apply_all_command): Use gdb::option::process_options.
1923         (thread_apply_command_completer)
1924         (thread_apply_all_command_completer): New.
1925         (thread_apply_command): Use gdb::option::process_options.
1926         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1927         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1928         to generate help text of "thread apply".  Adjust "taas"'s help.
1929         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1930         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1931
1932 2019-06-13  Pedro Alves  <palves@redhat.com>
1933
1934         * thread.c (thread_apply_command): Check for invalid TID with
1935         isdigit instead of !isalpha.
1936
1937 2019-06-13  Pedro Alves  <palves@redhat.com>
1938
1939         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1940         (validate_flags_qcs): New.
1941         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1942         (validate_flags_qcs): Declare.
1943         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1944         (make_frame_apply_options_def_group): New.
1945         (frame_apply_command_count): Process options with
1946         gdb::option::process_options.
1947         (frame_apply_completer): New.
1948         (frame_apply_level_completer, frame_apply_all_completer)
1949         (frame_apply_completer): New.
1950         (_initialize_stack): Update help of "frame apply", "frame apply
1951         level", "frame apply all" and "faas" to mention supported options
1952         and install command completers.
1953         * stack.h (frame_apply_all_completer): Declare.
1954         * thread.c: Include "stack.h".
1955         (tfaas_command): Add "--".
1956         (_initialize_thread): Update help "tfaas" to mention supported
1957         options and install command completer.
1958
1959 2019-06-13  Pedro Alves  <palves@redhat.com>
1960
1961         * completer.c (complete_nested_command_line): New.
1962         (gdb_completion_word_break_characters_throw): Add assertion.
1963         * completer.h (complete_nested_command_line): Declare.
1964
1965 2019-06-13  Pedro Alves  <palves@redhat.com>
1966
1967         * stack.c (parse_backtrace_qualifiers): New.
1968         (backtrace_command): Use it.
1969         (backtrace_command_completer): Complete on qualifiers.
1970
1971 2019-06-13  Pedro Alves  <palves@redhat.com>
1972
1973         * frame.c: Include "cli/cli-option.h.
1974         (user_set_backtrace_options): New.
1975         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1976         Delete.
1977         (get_prev_frame): Adjust.
1978         (boolean_option_def, uinteger_option_def)
1979         (set_backtrace_option_defs): New.
1980         (_initialize_frame): Adjust and use
1981         gdb::option::add_setshow_cmds_for_options to install "set
1982         backtrace past-main" and "set backtrace past-entry".
1983         * frame.h: Include "cli/cli-option.h".
1984         (struct frame_print_options): Forward declare.
1985         (print_frame_arguments_all, print_frame_arguments_scalars)
1986         (print_frame_arguments_none): Declare.
1987         (print_entry_values): Delete declaration.
1988         (struct frame_print_options, user_frame_print_options): New.
1989         (struct set_backtrace_options): New.
1990         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1991         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1992         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1993         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1994         (list_args_or_locals): Add frame_print_options parameter.
1995         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1996         * python/py-framefilter.c (enumerate_args): Pass down
1997         USER_FRAME_PRINT_OPTIONS.
1998         * stack.c: Include "cli/cli-option.h".
1999         (print_frame_arguments_all, print_frame_arguments_scalars)
2000         (print_frame_arguments_none): Declare.
2001         (print_raw_frame_arguments, print_entry_values): Delete.
2002         (user_frame_print_options): New.
2003         (boolean_option_def, enum_option_def, frame_print_option_defs):
2004         New.
2005         (struct backtrace_cmd_options): New.
2006         (bt_flag_option_def): New.
2007         (backtrace_command_option_defs): New.
2008         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2009         (print_frame_arg, read_frame_arg, print_frame_args)
2010         (print_frame_info, print_frame): Add frame_print_options parameter
2011         and use it.
2012         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2013         (backtrace_command_1): Add frame_print_options and
2014         backtrace_cmd_options parameters and use them.
2015         (make_backtrace_options_def_group): New.
2016         (backtrace_command): Process command options with
2017         gdb::option::process_options.
2018         (backtrace_command_completer): New.
2019         (_initialize_stack): Extend "backtrace"'s help to mention
2020         supported options.  Install completer for "backtrace".
2021         Install some settings commands with add_setshow_cmds_for_options.
2022
2023 2019-06-13  Pedro Alves  <palves@redhat.com>
2024
2025         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2026         and that "set/show print raw frame-arguments" are now deprecated.
2027
2028         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2029         command.
2030         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2031         * stack.c (_initialize_stack): Install "set/show print
2032         raw-frame-arguments", and deprecate "set/show print raw
2033         frame-arguments".
2034         * valprint.c (_initialize_valprint): Deprecate "set/show print
2035         raw".
2036
2037 2019-06-13  Pedro Alves  <palves@redhat.com>
2038
2039         * compile/compile.c (struct compile_options): New.
2040         (compile_flag_option_def, compile_command_option_defs)
2041         (make_compile_options_def_group): New.
2042         (compile_file_command): Handle options with
2043         gdb::option::process_options.
2044         (compile_file_command_completer): New function.
2045         (compile_code_command): Handle options with
2046         gdb::option::process_options.
2047         (compile_code_command_completer): New function.
2048         (_initialize_compiler): Install completers for "compile code" and
2049         "compile file".  Mention available options in "compile code" and
2050         "compile code"'s help.
2051         * completer.c (advance_to_completion_word): New, factored out from
2052         ...
2053         (advance_to_expression_complete_word_point): ... this.
2054         (advance_to_filename_complete_word_point): New.
2055         * completer.h (advance_to_filename_complete_word_point): New
2056         declaration.
2057
2058 2019-06-13  Pedro Alves  <palves@redhat.com>
2059
2060         * compile/compile.c: Include "cli/cli-option.h".
2061         (compile_print_value): Scope data pointer is now a
2062         value_print_options pointer; adjust.
2063         (compile_print_command): Process options.  Scope data pointer is
2064         now a value_print_options pointer; adjust.
2065         (_initialize_compile): Update "compile print"'s help to include
2066         supported options.  Install a completer for "compile print".
2067         * cp-valprint.c (show_vtblprint, show_objectprint)
2068         (show_static_field_print): Delete.
2069         (_initialize_cp_valprint): Don't install "set print
2070         static-members", "set print vtbl", "set print object" here.
2071         * printcmd.c: Include "cli/cli-option.h" and
2072         "common/gdb_optional.h".
2073         (print_command_parse_format): Rework to fill in a
2074         value_print_options instead of a format_data.
2075         (print_value): Change parameter type from format_data pointer to
2076         value_print_options reference.  Adjust.
2077         (print_command_1): Process options.  Adjust to pass down a
2078         value_print_options.
2079         (print_command_completer): New.
2080         (_initialize_printcmd): Install print_command_completer as
2081         handle_brkchars completer for the "print" command.  Update
2082         "print"'s help to include supported options.
2083         * valprint.c: Include "cli/cli-option.h".
2084         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2085         here from cp-valprint.c.
2086         (boolean_option_def, uinteger_option_def)
2087         (value_print_option_defs, make_value_print_options_def_group):
2088         New.  Use gdb::option::add_setshow_cmds_for_options to install
2089         "set print elements", "set print null-stop", "set print repeats",
2090         "set print pretty", "set print union", "set print array", "set
2091         print address", "set print symbol", "set print array-indexes".
2092         * valprint.h: Include <string> and "cli/cli-option.h".
2093         (make_value_print_options_def_group): Declare.
2094         (print_value): Change parameter type from format_data pointer to
2095         value_print_options reference.
2096         (print_command_completer): Declare.
2097
2098 2019-06-13  Pedro Alves  <palves@redhat.com>
2099
2100         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2101         (COMMON_SFILES): Add maint-test-settings.c.
2102         * cli/cli-decode.c (boolean_enums): New global, factored out from
2103         ...
2104         (add_setshow_boolean_cmd): ... here.
2105         * cli/cli-decode.h (boolean_enums): Declare.
2106         * cli/cli-option.c: New file.
2107         * cli/cli-option.h: New file.
2108         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2109         factored out from ...
2110         (parse_cli_boolean_value(const char *)): ... this.
2111         (is_unlimited_literal): Change parameter type to pointer to
2112         pointer.  Adjust and advance ARG pointer.
2113         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2114         (parse_cli_var_enum): New, factored out from ...
2115         (do_set_command): ... this.  Adjust.
2116         * cli/cli-setshow.h (parse_cli_boolean_value)
2117         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2118         (parse_cli_var_enum): Declare.
2119         * cli/cli-utils.c: Include "cli/cli-option.h".
2120         (get_ulongest): New.
2121         * cli/cli-utils.h (get_ulongest): Declare.
2122         (check_for_argument): New overloads.
2123         * maint-test-options.c: New file.
2124
2125 2019-06-13  Pedro Alves  <palves@redhat.com>
2126
2127         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2128         parse a range if "-" is at the end of the string.
2129
2130 2019-06-13  Pedro Alves  <palves@redhat.com>
2131
2132         * cli/cli-setshow.c (parse_auto_binary_operation)
2133         (parse_cli_boolean_value): Don't allow "o".
2134
2135 2019-06-13  Pedro Alves  <palves@redhat.com>
2136
2137         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2138         * NEWS: Mention maint test-settings KIND.
2139         * maint-test-settings.c: New file.
2140
2141 2019-06-13  Pedro Alves  <palves@redhat.com>
2142
2143         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2144         completer.
2145         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2146         "set" completers.
2147
2148 2019-06-13  Pedro Alves  <palves@redhat.com>
2149
2150         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2151         after item.
2152
2153 2019-06-13  Pedro Alves  <palves@redhat.com>
2154
2155         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2156
2157 2019-06-13  Pedro Alves <palves@redhat.com>
2158
2159         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2160         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2161         call.
2162         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2163         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2164         calls.
2165         (check_for_argument): Skip spaces after argument.
2166
2167 2019-06-13  Pedro Alves  <palves@redhat.com>
2168
2169         * thread.c (thread_apply_command): Adjust TID parsing.
2170         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2171         detected before end of string.
2172         (tid_is_in_list): Error out if LIST is invalid.
2173
2174 2019-06-13  Pedro Alves  <palves@redhat.com>
2175
2176         * completer.c (complete_line_internal_1): Rewind completion word
2177         point.
2178         (completion_tracker::advance_custom_word_point_by): Change
2179         parameter type to int.
2180         * completer.h (completion_tracker::advance_custom_word_point_by):
2181         Likewise.
2182
2183 2019-06-13  Pedro Alves  <palves@redhat.com>
2184
2185         * completer.c (advance_to_completion_word): Handle delimiters.
2186
2187 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2188
2189         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2190
2191 2019-06-11  Tom Tromey  <tom@tromey.com>
2192
2193         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2194         (xmalloc_failed): Move to alloc.c.
2195         * alloc.c: New file.
2196         * Makefile.in (COMMON_SFILES): Add alloc.c.
2197
2198 2019-06-11  Tom Tromey  <tom@tromey.com>
2199
2200         * nat/linux-waitpid.c: Don't include server.h.
2201         (linux_debug): Remove.
2202         (my_waitpid): Update.
2203
2204 2019-06-11  Tom Tromey  <tromey@adacore.com>
2205
2206         * infcall.c (_initialize_infcall): Remove trailing newline from
2207         help.
2208         * user-regs.c (_initialize_user_regs): Remove trailing newline
2209         from help.
2210         * typeprint.c (_initialize_typeprint): Remove trailing newline
2211         from help.
2212         * reverse.c (_initialize_reverse): Remove trailing newlines from
2213         help.
2214         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2215         from help.
2216         * language.c (add_set_language_command): Remove trailing newline
2217         from help.
2218         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2219         help.
2220         * disasm.c (_initialize_disasm): Remove trailing newline from
2221         help.
2222         * top.c (init_main): Remove trailing newline from help.
2223         * interps.c (_initialize_interpreter): Remove trailing newline
2224         from help.
2225         * btrace.c (_initialize_btrace): Remove trailing newlines from
2226         help.
2227         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2228         from help.
2229         * python/python.c (_initialize_python): Remove trailing newline
2230         from help.
2231         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2232         help.
2233         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2234         from help.  Reformat some text.
2235         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2236         from help.
2237         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2238         newline from help.
2239
2240 2019-06-11  Tom Tromey  <tromey@adacore.com>
2241
2242         * darwin-nat.c (darwin_decode_exception_message)
2243         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2244
2245 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2246
2247         * valops.c (value_slice): Check for not allocated or not
2248         associated values.
2249
2250 2019-06-10  Tom de Vries  <tdevries@suse.de>
2251
2252         PR gdb/24618
2253         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2254         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2255         invalid.
2256
2257 2019-06-10  Tom de Vries  <tdevries@suse.de>
2258
2259         PR gdb/24611
2260         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2261         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2262
2263 2019-06-10  Tom de Vries  <tdevries@suse.de>
2264
2265         PR symtab/24545
2266         * symtab.c (struct demangled_name_entry): Add language field.
2267         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2268         static minimal symbol".  Set and use language field.
2269
2270 2019-06-10  Tom Tromey  <tromey@adacore.com>
2271
2272         * ada-lang.c (_initialize_ada_language): Update help text.
2273
2274 2019-06-10  Tom Tromey  <tromey@adacore.com>
2275
2276         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2277         with a newline.
2278         * guile/guile.c (handle_boot_error): Don't end warning with a
2279         newline.
2280         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2281         warning with a newline.
2282         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2283         newline.
2284         (s12z_frame_cache): Likewise.
2285         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2286         a newline.
2287         * solib-svr4.c (disable_probes_interface): Don't end warning with
2288         a newline.
2289         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2290         newline.
2291         * python/python.c (do_finish_initialization): Don't end warning
2292         with a newline.
2293
2294 2019-06-10  Tom Tromey  <tom@tromey.com>
2295
2296         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2297         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2298         gdbpy_enter.
2299
2300 2019-06-10  Tom Tromey  <tromey@adacore.com>
2301
2302         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2303         data.
2304         (elf_new_init): Don't call stabsread_new_init.
2305         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2306         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2307         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2308
2309 2019-06-10  Tom de Vries  <tdevries@suse.de>
2310
2311         PR symtab/16264
2312         PR symtab/24517
2313         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2314
2315 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2316
2317         * source.c (find_and_open_source): Also rewrite relative file
2318         names.
2319
2320 2019-04-26  Amos Bird  <amosbird@gmail.com>
2321
2322         * annotate.c (annotate_thread_exited): Add "thread-exited"
2323         annotation.
2324
2325 2019-06-06  Tom Tromey  <tromey@adacore.com>
2326
2327         * maint.h (class scoped_command_stats): Use
2328         DISABLE_COPY_AND_ASSIGN.
2329         <print_time>: New method.
2330         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2331         print_time.
2332         (scoped_command_stats::print_time): New method.
2333
2334 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2335
2336         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2337         instructions of lengths 6 or 8 bytes.
2338
2339 2019-06-04  Pedro Alves  <palves@redhat.com>
2340
2341         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2342
2343         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2344         * breakpoint.c (condition_completer): Likewise.
2345         * cli/cli-dump.c (scan_expression): Likewise.
2346         * common/filestuff.c (mkdir_recursive): Likewise.
2347         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2348         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2349         (gdb_abspath): Likewise.
2350         * compile/compile-cplus-types.c
2351         (compile_cplus_instance::decl_name): Likewise.
2352         * completer.c (complete_explicit_location):
2353         (signal_completer, reg_or_group_completer_1): Likewise.
2354         * cp-support.c (cp_remove_params_if_any): Likewise.
2355         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2356         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2357         * infcmd.c (strip_bg_char): Likewise.
2358         * linespec.c (copy_token_string): Likewise.
2359         * mi/mi-main.c (output_cores): Likewise.
2360         * psymtab.c (psymtab_search_name):
2361         * symfile.c (test_set_ext_lang_command): Likewise.
2362         * target.c (target_fileio_read_stralloc): Likewise.
2363         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2364         * value.c (complete_internalvar): Likewise.
2365
2366 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2367
2368         Add objfile property to gdb.Type.
2369         * NEWS: Mention Python API addition.
2370         * python/py-type.c (typy_get_objfile): New method.
2371
2372 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2373
2374         * NEWS: Mention the new set|show style [title|highlight].
2375         Mention changes to "show style", "help" and "apropos".
2376
2377 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2378
2379         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2380         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2381         instead of print_help_for_command.
2382         (print_doc_of_command): New function.
2383         (help_list): Add 'apropos -v word' suggestion.
2384         (print_help_for_command): Style the command name using title style.
2385         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2386         (_initialize_cli_cmds): Describe -v in apropos_command help.
2387
2388 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2389
2390         * cli/cli-style.h (cli_style_option): Add name in constructor,
2391         add m_name class member, add constructor with intensity,
2392         add name class function.
2393         (cli_style_option::add_setshow_commands): Remove name argument.
2394         (highlight_style, title_style): New styles.
2395         * cli/cli-style.c (do_show): New function that shows a style
2396         characteristic styling the style name with itself.
2397         (set_style_name): New function.
2398         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2399         Update all callers according to the changes in cli/cli-style.h.
2400         * utils.h (fputs_highlighted): New function.
2401         * utils.c (fputs_highlighted): Likewise.
2402
2403 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2404
2405         * NEWS: Mention new pipe command and new convenience variables.
2406
2407 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2408
2409         * cli/cli-cmds.c (pipe_command): New function.
2410         (_initialize_cli_cmds): Call add_com for pipe_command.
2411         Define | as an alias for pipe.
2412         (exit_status_set_internal_vars): New function.
2413         (shell_escape): Call exit_status_set_internal_vars.
2414         cli/cli-decode.c (find_command_name_length): Recognize | as
2415         a single character command.
2416
2417 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2418
2419         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2420         top.c (execute_command_to_ui_file): New function, mostly a copy
2421         of execute_command_to_string.
2422         (execute_command_to_string): Implement by calling
2423         execute_command_to_ui_file.
2424
2425 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2426
2427         * top.h (saved_command_line): Remove declaration.
2428         * top.c (previous_saved_command_line, previous_repeat_arguments):
2429         New variables.
2430         (saved_command_line): Make static, define together with other
2431         'repeat variables'.
2432         (dont_repeat): Clear repeat_arguments.
2433         (repeat_previous, get_saved_command_line, save_command_line):
2434         New functions.
2435         (gdb_init): Initialize saved_command_line
2436         and previous_saved_command_line.
2437         * main.c (captured_main_1): Remove saved_command_line initialization.
2438         * event-top.c (handle_line_of_input): Update to use
2439         the new 'repeat' related functions instead of direct access to
2440         saved_command_line.
2441         * command.h (repeat_previous, get_saved_command_line,
2442         save_command_line): New declarations.
2443         (dont_repeat): Add comment.
2444
2445 2019-05-30  Tom Tromey  <tromey@adacore.com>
2446
2447         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2448         Fix comment.
2449         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2450
2451 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2452
2453         PR cli/24587
2454         * completer.c (complete): Initialize variable word.
2455
2456 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2457
2458         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2459         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2460         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2461         'body' is NULL to the outter 'if', protecting the '!is_define'
2462         situation as well.
2463
2464 2019-05-29  Tom Tromey  <tromey@adacore.com>
2465
2466         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2467         (dwarf_unknown): New function.
2468         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2469         (dwarf_type_encoding_name): Use dwarf_unknown.
2470
2471 2019-05-29  Tom Tromey  <tromey@adacore.com>
2472
2473         PR c++/20020:
2474         * cp-valprint.c (cp_print_value_fields): Call
2475         cp_print_static_field inside "try".
2476
2477 2019-05-29  Tom Tromey  <tromey@adacore.com>
2478
2479         * inflow.c (struct terminal_info): Add default operator=.
2480         * configure: Rebuild.
2481         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2482         -Wdeprecated-copy-dtor, -Wredundant-move.
2483
2484 2019-05-29  Tom Tromey  <tromey@adacore.com>
2485
2486         * NEWS: Add entry.
2487         * infcmd.c (print_return_value_1): Handle finish_print
2488         option.
2489         (show_print_finish): New function.
2490         (_initialize_infcmd): Add "set/show print finish" commands.
2491         * valprint.c (user_print_options): Initialize new member.
2492         * valprint.h (struct value_print_options) <finish_print>: New
2493         member.
2494
2495 2019-05-28  Tom Tromey  <tromey@adacore.com>
2496
2497         * ada-lang.c (ada_remove_Xbn_suffix)
2498         (find_old_style_renaming_symbol)
2499         (parse_old_style_renaming): Remove.
2500         (ada_find_renaming_symbol): Don't call
2501         find_old_style_renaming_symbol.
2502         (ada_is_renaming_symbol): Rename from
2503         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2504         bool.  Now static.
2505         (ada_read_var_value): Update and simplify.
2506         * ada-exp.y (write_var_or_type): Remove old code.
2507
2508 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2509
2510         * event-top.c: Remove include comment.
2511         * inflow.c (class scoped_ignore_sigttou): Move from here...
2512         * inflow.h (class scoped_ignore_sigttou): ...to here.
2513         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2514         * top.c:  Remove include comment.
2515
2516 2019-05-27  Tom Tromey  <tom@tromey.com>
2517
2518         * NEWS: Fix typo.
2519
2520 2019-05-22  Tom Tromey  <tromey@adacore.com>
2521
2522         * target.c (target_follow_exec): Constify parameter.
2523         * target-delegates.c: Rebuild.
2524         * remote.c (remote_target::follow_exec): Constify parameter.
2525         * infrun.c (follow_exec): Constify parameter.
2526         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2527         (target_follow_exec): Likewise.
2528
2529 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2530
2531         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2532         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2533
2534 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2535
2536         * NEWS: Add debugredirect and testsuite sections.
2537
2538 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2539
2540         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2541         target descriptions using exclusively floating point register name
2542         aliases.
2543
2544 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2545
2546         PR gdb/18644:
2547         * f-lang.c (build_fortran_types): Handle the case where
2548         gdbarch_floatformat_for_type returns a nullptr.
2549
2550 2019-05-21  Tom de Vries  <tdevries@suse.de>
2551
2552         PR cli/24587
2553         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2554
2555 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2556
2557         PR gdb/18644:
2558         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2559         16-byte floats.
2560         * i386-tdep.c (i386_floatformat_for_type): Use
2561         floatformats_ia64_quad for the 16-byte floating point component
2562         within a fortran 32-byte complex number.
2563
2564 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2567         delete default constructor.
2568         (find_partial_die): Update to return const struct.
2569         (partial_die_parent_scope): Move variable declaration into scope
2570         of its use and change its type to auto.
2571         (guess_partial_die_structure_name): Likewise.
2572         (partial_die_info::fixup): Likewise.
2573
2574 2019-05-17  Tom Tromey  <tromey@adacore.com>
2575
2576         * source.c (find_and_open_source): Remove cast.
2577
2578 2019-05-17  Tom Tromey  <tromey@adacore.com>
2579
2580         * annotate.c (annotate_source): Make "filename" const.
2581         * annotate.h (annotate_source): Use const.
2582
2583 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2584
2585         * disasm.c (set_disassembler_options): Send errors to stderr.
2586
2587 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2588
2589         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2590         (cli_interp_base::set_logging): Check debug_redirect.
2591         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2592         * cli/cli-logging.c (debug_redirect): Add static variable.
2593         (pop_output_files): Add default param.
2594         (handle_redirections): Print debug setting.
2595         (show_logging_command): Likewise.
2596         (_initialize_cli_logging): Add debugredirect command.
2597         * interps.c (current_interp_set_logging): Add debug_redirect
2598         parameter.
2599         * interps.h (set_logging): Add debug_redirect parameter.
2600         (current_interp_set_logging): Likewise.
2601         * mi/mi-common.h: Likewise.
2602         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2603
2604 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2605             Tom Tromey  <tromey@adacore.com>
2606
2607         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2608         directly.
2609         * cli/cli-interp.h (make_logging_output): Remove declaration.
2610         * cli/cli-logging.c (make_logging_output): Remove function.
2611         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2612         directly.
2613         * ui-file.c (tee_file::tee_file): Remove bools.
2614         (tee_file::~tee_file): Remove deletes.
2615         * ui-file.h (tee_file): Remove bools.
2616
2617 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2618
2619         * mi/mi-cmds.h (mi_cmd_complete): New function.
2620         * mi/mi-main.c (mi_cmd_complete): Likewise.
2621         * mi/mi-cmds.c: Define new MI command -complete.
2622         * NEWS: Mention new -complete command.
2623
2624 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2625
2626         * completer.h (complete): New function.
2627         * completer.c (complete): Likewise.
2628         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2629         function defined in completer.h.
2630
2631 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2632
2633         * MAINTAINERS (Write After Approval): Add myself.
2634
2635 2019-05-17  Tom de Vries  <tdevries@suse.de>
2636
2637         PR gdb/24094
2638         * dwarf2read.c (struct cu_partial_die_info): New struct.
2639         (find_partial_die): Return cu_partial_die_info.
2640         (partial_die_parent_scope, guess_partial_die_structure_name)
2641         (partial_die_info::fixup): Handle new return type of find_partial_die.
2642
2643 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2644
2645         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2646         "std::string", simplifying the algorithm.
2647
2648 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2649
2650         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2651         (stap_static_probe_ops::get_probes): Likewise.
2652
2653 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2654
2655         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2656         '-')" and "else if".
2657         (stap_parse_single_operand): Join checks for
2658         "gdbarch_stap_parse_special_token_p" and
2659         "gdbarch_stap_parse_special_token" in the same "if" statement.
2660         Invert check when verifying for operation on register
2661         displacement.
2662
2663 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2664
2665         * stap-probe.c (stap_get_opcode): Update comment.
2666         (stap_get_expected_argument_type): Likewise.
2667         (handle_stap_probe): Likewise.
2668
2669 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2670
2671         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2672         return type to 'bool'.  Adjust comment.  Use 'bool' when
2673         appropriate.
2674         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2675         * stap-probe.c (stap_parse_argument_1): Likewise.
2676         (stap_is_operator): Likewise.
2677         (stap_is_generic_prefix): Likewise.
2678         (stap_is_register_prefix): Likewise.
2679         (stap_is_register_indirection_prefix): Likewise.
2680         (stap_is_integer_prefix): Likewise.
2681         (stap_generic_check_suffix): Likewise.
2682         (stap_check_integer_suffix): Likewise.
2683         (stap_check_register_suffix): Likewise.
2684         (stap_check_register_indirection_suffix): Likewise.
2685         (stap_parse_register_operand): Likewise.
2686         (stap_parse_single_operand): Likewise.
2687         (stap_parse_argument_1): Likewise.
2688         (stap_probe::get_argument_count): Likewise.
2689         (stap_is_operator): Likewise.
2690
2691 2019-05-16  Tom Tromey  <tromey@adacore.com>
2692
2693         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2694         keyword to foreach.
2695
2696 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2697
2698         * linux-thread-db.c (try_thread_db_load_1): Change return type
2699         to bool.
2700         (try_thread_db_load): Likewise.
2701         (try_thread_db_load_from_pdir_1): Likewise.
2702         (try_thread_db_load_from_pdir): Likewise.
2703         (try_thread_db_load_from_sdir): Likewise.
2704         (try_thread_db_load_from_dir): Likewise.
2705         (thread_db_load_search): Likewise.
2706         (has_libpthread): Likewise.
2707         (thread_db_load): Likewise.
2708
2709 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2710
2711         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2712         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2713         NULL, and complain/return if that's the case.
2714
2715 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2716
2717         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2718         (advance, posn, abstract_read_memory): New functions.
2719         [struct mem_read_abstraction]: New struct.
2720         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2721
2722 2019-05-14  Tom Tromey  <tromey@adacore.com>
2723
2724         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2725         value is not lval_memory.
2726
2727 2019-05-14  Tom Tromey  <tromey@adacore.com>
2728
2729         * solib.c (info_sharedlibrary_command): Style the file name.
2730
2731 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2732
2733         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2734         (aarch64_vnv_type): Likewise.
2735         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2736         * common/tdesc.c: Likewise.
2737         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2738         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2739         * features/aarch64-fpu.xml: Add ieee half view.
2740         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2741         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2742         * gdbtypes.h (struct builtin_type): Likewise.
2743         (struct objfile_type): Likewise.
2744
2745 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2746
2747         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2748         typo.
2749         * location.h (string_to_event_location): Likewise.
2750
2751 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2752
2753         GDB 8.3 released.
2754
2755 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2756
2757         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2758         New variable declaration.
2759         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2760         New variable.
2761         (print_one_breakpoint): Use ui_out::test_flags and new global
2762         variable to compute use_fixed_output.
2763         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2764         Remove.
2765         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2766         (mi_multi_location_breakpoint_output_fixed): Remove.
2767         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2768         new variable.
2769         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2770         fix_multi_location_breakpoint_output flag if version >= 3.
2771         * ui-out.h (enum ui_out_flag)
2772         <fix_multi_location_breakpoint_output>: New enumerator.
2773
2774 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2775
2776         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2777
2778 2019-05-10  Tom Tromey  <tromey@adacore.com>
2779
2780         * ada-lang.c (catch_ada_completer): New function.
2781         (_initialize_ada_language): Use it.
2782
2783 2019-05-10  Tom Tromey  <tromey@adacore.com>
2784
2785         * thread.c (print_thread_info): Make "requested_threads" const.
2786         * gdbthread.h (print_thread_info): Make "requested_threads"
2787         const.
2788         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2789         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2790
2791 2019-05-08  Tom Tromey  <tom@tromey.com>
2792
2793         * gdbtypes.c (objfile_type_data): Change type.
2794         (objfile_type, _initialize_gdbtypes): Update.
2795
2796 2019-05-08  Tom Tromey  <tom@tromey.com>
2797
2798         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2799         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2800         (_initialize_dwarf2_frame): Update.
2801
2802 2019-05-08  Tom Tromey  <tom@tromey.com>
2803
2804         * objc-lang.c (objc_objfile_data): Change type.
2805         (find_methods): Update.
2806         (_initialize_objc_lang): Remove.
2807
2808 2019-05-08  Tom Tromey  <tom@tromey.com>
2809
2810         * stabsread.c (rs6000_builtin_type_data): Change type.
2811         (rs6000_builtin_type, _initialize_stabsread): Update.
2812
2813 2019-05-08  Tom Tromey  <tom@tromey.com>
2814
2815         * mips-tdep.c (mips_pdr_data): Remove.
2816         (_initialize_mips_tdep): Update.
2817
2818 2019-05-08  Tom Tromey  <tom@tromey.com>
2819
2820         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2821         (hppa_init_objfile_priv_data, read_unwind_info)
2822         (find_unwind_entry, _initialize_hppa_tdep): Update.
2823
2824 2019-05-08  Tom Tromey  <tom@tromey.com>
2825
2826         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2827         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2828         on obstack.
2829         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2830
2831 2019-05-08  Tom Tromey  <tom@tromey.com>
2832
2833         * mdebugread.c (basic_type_data): Change type.
2834         (basic_type, _initialize_mdebugread): Update.
2835
2836 2019-05-08  Tom Tromey  <tom@tromey.com>
2837
2838         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2839
2840 2019-05-08  Tom Tromey  <tom@tromey.com>
2841
2842         * nto-tdep.c (nto_inferior_data_reg): Change type.
2843         (nto_inferior_data): Update.
2844         (nto_inferior_data_cleanup, nto_new_inferior_data)
2845         (_initialize_nto_tdep): Remove.
2846         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2847
2848 2019-05-08  Tom Tromey  <tom@tromey.com>
2849
2850         * ada-lang.c (struct ada_inferior_data): Add initializers.
2851         (ada_inferior_data): Change type.
2852         (ada_inferior_data_cleanup): Remove.
2853         (get_ada_inferior_data, ada_inferior_exit)
2854         (struct ada_pspace_data): Add initializers, destructor.
2855         (ada_pspace_data_handle): Change type.
2856         (get_ada_pspace_data): Update.
2857         (ada_pspace_data_cleanup): Remove.
2858
2859 2019-05-08  Tom Tromey  <tom@tromey.com>
2860
2861         * coffread.c (struct coff_symfile_info): Add initializers.
2862         (coff_objfile_data_key): Move lower.  Change type.
2863         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2864         Update.
2865         (coff_free_info): Remove.
2866
2867 2019-05-08  Tom Tromey  <tom@tromey.com>
2868
2869         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2870         (fbsd_pspace_data_handle): Move lower.  Change type.
2871         (get_fbsd_pspace_data): Update.
2872         (fbsd_pspace_data_cleanup): Remove.
2873         (_initialize_fbsd_tdep): Update.
2874
2875 2019-05-08  Tom Tromey  <tom@tromey.com>
2876
2877         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2878         (get_ada_tasks_pspace_data): Update.
2879         (ada_tasks_pspace_data_cleanup): Remove.
2880         (_initialize_tasks): Update.
2881         (ada_tasks_inferior_data_handle): Change type.
2882         (get_ada_tasks_inferior_data): Update.
2883         (ada_tasks_inferior_data_cleanup): Remove.
2884         (struct ada_tasks_pspace_data): Add initializers.
2885
2886 2019-05-08  Tom Tromey  <tom@tromey.com>
2887
2888         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2889         * symfile-debug.c (debug_sym_get_probes): Change type.
2890         * stap-probe.c (handle_stap_probe):
2891         (stap_static_probe_ops::get_probes): Change type.
2892         * probe.h (class static_probe_ops) <get_probes>: Change type.
2893         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2894         (parse_probes_in_pspace): Update.
2895         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2896         Update.
2897         (any_static_probe_ops::get_probes): Change type.
2898         * elfread.c (elfread_data): New typedef.
2899         (probe_key): Change type.
2900         (elf_get_probes): Likewise.  Update.
2901         (probe_key_free): Remove.
2902         (_initialize_elfread): Update.
2903         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2904         Change type.
2905         (dtrace_process_dof_probe, dtrace_process_dof)
2906         (dtrace_static_probe_ops::get_probe): Change type.
2907
2908 2019-05-08  Tom Tromey  <tom@tromey.com>
2909
2910         * xcoffread.c (struct xcoff_symfile_info): Rename from
2911         coff_symfile_info.  Add initializers.
2912         (xcoff_objfile_data_key): Move lower.  Change type.
2913         (XCOFF_DATA): Rewrite.
2914         (xcoff_free_info): Remove.
2915         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2916         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2917         (xcoff_initial_scan): Update.
2918
2919 2019-05-08  Tom Tromey  <tom@tromey.com>
2920
2921         * solib-svr4.c (struct svr4_info): Add initializers and
2922         destructor.
2923         <probes_table>: Now an htab_up.
2924         (solib_svr4_pspace_data): Change type.
2925         (free_probes_table): Simplify.
2926         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2927         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2928         (probes_table_remove_objfile_probes, register_solib_event_probe)
2929         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2930         (_initialize_svr4_solib): Update.
2931
2932 2019-05-08  Tom Tromey  <tom@tromey.com>
2933
2934         * remote.c (remote_pspace_data): Change type.
2935         (remote_pspace_data_cleanup): Remove.
2936         (get_remote_exec_file, set_pspace_remote_exec_file)
2937         (_initialize_remote): Update.
2938
2939 2019-05-08  Tom Tromey  <tom@tromey.com>
2940
2941         * breakpoint.c (breakpoint_objfile_key): Change type.
2942         (get_breakpoint_objfile_data): Update.
2943         (free_breakpoint_objfile_data): Remove.
2944         (_initialize_breakpoint): Update.
2945
2946 2019-05-08  Tom Tromey  <tom@tromey.com>
2947
2948         * linux-tdep.c (struct linux_info): Add initializers.
2949         (linux_inferior_data): Move.  Change type.
2950         (invalidate_linux_cache_inf): Update.
2951         (linux_inferior_data_cleanup): Remove.
2952         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2953
2954 2019-05-08  Tom Tromey  <tom@tromey.com>
2955
2956         * auxv.c (auxv_inferior_data): Move.  Change type.
2957         (auxv_inferior_data_cleanup): Remove.
2958         (invalidate_auxv_cache_inf): Rewrite.
2959         (get_auxv_inferior_data, _initialize_auxv): Update.
2960
2961 2019-05-08  Tom Tromey  <tom@tromey.com>
2962
2963         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2964         (symfile_debug_objfile_data_key): Change type.
2965         (symfile_debug_installed, debug_qf_has_symbols)
2966         (debug_qf_find_last_source_symtab)
2967         (debug_qf_forget_cached_source_info)
2968         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2969         (debug_qf_print_stats, debug_qf_dump)
2970         (debug_qf_expand_symtabs_for_function)
2971         (debug_qf_expand_all_symtabs)
2972         (debug_qf_expand_symtabs_with_fullname)
2973         (debug_qf_map_matching_symbols)
2974         (debug_qf_expand_symtabs_matching)
2975         (debug_qf_find_pc_sect_compunit_symtab)
2976         (debug_qf_map_symbol_filenames)
2977         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2978         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2979         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2980         (debug_sym_read_linetable, debug_sym_relocate): Update.
2981         (symfile_debug_free_objfile): Remove.
2982         (install_symfile_debug_logging, _initialize_symfile_debug):
2983         Update.
2984
2985 2019-05-08  Tom Tromey  <tom@tromey.com>
2986
2987         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2988         allocate_on_obstack.
2989         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2990         (get_dwarf2_per_objfile): Update.
2991         (set_dwarf2_per_objfile): Remove.
2992         (dwarf2_has_info, dwarf2_get_section_info): Update.
2993         (dwarf2_free_objfile): Remove.
2994         (_initialize_dwarf2_read): Update.
2995
2996 2019-05-08  Tom Tromey  <tom@tromey.com>
2997
2998         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2999         initializers.
3000         <unsupported_script_warning_printed,
3001         script_not_found_warning_printed>: Now bool.
3002         (auto_load_pspace_data): Change type.
3003         (~auto_load_pspace_info): Rename from
3004         auto_load_pspace_data_cleanup.
3005         (get_auto_load_pspace_data, init_loaded_scripts_info)
3006         (clear_section_scripts, maybe_print_unsupported_script_warning)
3007         (maybe_print_script_not_found_warning, _initialize_auto_load):
3008         Update.
3009
3010 2019-05-08  Tom Tromey  <tom@tromey.com>
3011
3012         * objfiles.c (objfile_pspace_info): Add destructor and
3013         initializers.
3014         (objfiles_pspace_data): Change type.
3015         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3016         (get_objfile_pspace_data): Update.
3017         (objfiles_bfd_data): Change type.
3018         (get_objfile_bfd_data): Update.
3019         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3020
3021 2019-05-08  Tom Tromey  <tom@tromey.com>
3022
3023         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3024         Change type.
3025         (get_catch_syscall_inferior_data): Update.
3026         (catch_syscall_inferior_data_cleanup): Remove.
3027         (_initialize_break_catch_syscall): Update.
3028
3029 2019-05-08  Tom Tromey  <tom@tromey.com>
3030
3031         * inflow.c (struct terminal_info): Add destructor and
3032         initializers.
3033         (inflow_inferior_data): Change type.
3034         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3035         (get_inflow_inferior_data, inflow_inferior_exit)
3036         (swap_terminal_info, _initialize_inflow): Update.
3037
3038 2019-05-08  Tom Tromey  <tom@tromey.com>
3039
3040         * target-dcache.c (target_dcache_cleanup): Remove.
3041         (target_dcache_aspace_key): Change type.
3042         (target_dcache_init_p, target_dcache_invalidate)
3043         (target_dcache_get, target_dcache_get_or_init)
3044         (_initialize_target_dcache): Update.
3045         * dcache.h (struct dcache_deleter): New.
3046
3047 2019-05-08  Tom Tromey  <tom@tromey.com>
3048
3049         * symtab.c (struct symbol_cache): Add destructor and
3050         initializers.
3051         (symbol_cache_key): Move.  Change type.
3052         (make_symbol_cache, free_symbol_cache): Remove.
3053         (get_symbol_cache): Update.
3054         (symbol_cache_cleanup): Remove.
3055         (ALL_PSPACES, symbol_cache_flush)
3056         (maintenance_print_symbol_cache)
3057         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3058         Update.
3059
3060 2019-05-08  Tom Tromey  <tom@tromey.com>
3061
3062         * symtab.c (struct main_info): Add destructor and initializers.
3063         (main_progspace_key): Move.  Change type.
3064         (get_main_info): Update.
3065         (main_info_cleanup): Remove.
3066         (_initialize_symtab): Update.
3067
3068 2019-05-08  Tom Tromey  <tom@tromey.com>
3069
3070         * registry.h (DECLARE_REGISTRY): Define the _key class.
3071
3072 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3073
3074         * NEWS: Merge two 'New commands' sections.
3075
3076 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3077
3078         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3079         parameter and use Ada language definition instead.
3080         (ada_val_print_ptr): Remove unused language parameter.
3081         (ada_val_print_num): Remove language parameter and use Ada language
3082         definition instead.
3083         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3084         parameter.
3085         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3086         parameter and use Ada language definition instead.
3087         (ada_val_print_1): Update all ada_val_print_xxx calls.
3088         Remove language parameter.
3089         (ada_val_print): Update ada_val_print_1 call.
3090
3091 2019-05-08  Tom Tromey  <tromey@adacore.com>
3092
3093         * remote.c (remote_hw_watchpoint_limit)
3094         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3095         Now static.
3096
3097 2019-05-08  Tom Tromey  <tromey@adacore.com>
3098
3099         * maint.c (_initialize_maint_cmds): Move initialization code to
3100         remote.c.
3101         (watchdog, show_watchdog): Move to remote.c.
3102         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3103         "watchdog" static.
3104         (_initialize_remote): Move initialization code from maint.c.
3105         * defs.h (watchdog): Don't declare.
3106
3107 2019-05-08  Tom Tromey  <tromey@adacore.com>
3108
3109         * tui/tui-interp.c: Include main.h.
3110         * interps.c: Include main.h.
3111         * main.h (interpreter_p): Declare.
3112         * defs.h (interpreter_p): Don't declare.
3113
3114 2019-05-08  Tom Tromey  <tromey@adacore.com>
3115
3116         * dwarf2loc.c: Include dwarf2read.h.
3117         * defs.h (read_unsigned_leb128): Don't declare.
3118         * dwarf2read.h (read_unsigned_leb128): Declare.
3119
3120 2019-05-08  Tom Tromey  <tromey@adacore.com>
3121
3122         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3123         method.
3124
3125 2019-05-08  Tom Tromey  <tromey@adacore.com>
3126
3127         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3128         when no wrap column is set.
3129
3130 2019-05-08  Tom Tromey  <tromey@adacore.com>
3131
3132         * c-lang.c (c_get_string): Handle non-C-style arrays.
3133
3134 2019-05-08  Tom Tromey  <tromey@adacore.com>
3135
3136         * typeprint.c (print_offset_data::update): Print the bit offset,
3137         not the number of bits remaining.
3138
3139 2019-05-08  Tom Tromey  <tromey@adacore.com>
3140
3141         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3142         padding at end of comment.
3143
3144 2019-05-08  Tom Tromey  <tromey@adacore.com>
3145
3146         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3147         Compare main types.
3148
3149 2019-05-06  Tom Tromey  <tom@tromey.com>
3150
3151         * common/scoped_mmap.c: Include common-defs.h.
3152         * common/scoped_mmap.h: Don't include config.h.
3153
3154 2019-05-04  Tom Tromey  <tom@tromey.com>
3155
3156         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3157         (struct aarch64_call_info): Add initializers.
3158         <si>: Now a std::vector.
3159         (pass_on_stack, aarch64_push_dummy_call): Update.
3160
3161 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3162             Tom Tromey  <tom@tromey.com>
3163
3164         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3165         (ppc_threads): Now a std::vector.  Now static.
3166         (hwdebug_find_thread_points_by_tid)
3167         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3168         Update.
3169
3170 2019-05-04  Tom Tromey  <tom@tromey.com>
3171
3172         * arc-tdep.c (arc_tdesc_init): Return bool.
3173
3174 2019-05-04  Tom Tromey  <tom@tromey.com>
3175
3176         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3177         Use gdb_assert_not_reached.
3178
3179 2019-05-04  Tom Tromey  <tom@tromey.com>
3180
3181         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3182         "false".
3183
3184 2019-05-04  Tom Tromey  <tom@tromey.com>
3185
3186         * arc-tdep.c (arc_tdesc_init): Use bool.
3187
3188 2019-05-04  Tom Tromey  <tom@tromey.com>
3189
3190         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3191
3192 2019-05-04  Tom Tromey  <tom@tromey.com>
3193
3194         * cli/cli-cmds.c (valid_command_p): Return bool.
3195
3196 2019-05-04  Tom Tromey  <tom@tromey.com>
3197
3198         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3199         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3200
3201 2019-05-04  Raul Tambre  <raul@tambre.ee>
3202
3203         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3204         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3205         operator for comparison.
3206
3207 2019-05-04  Tom Tromey  <tom@tromey.com>
3208
3209         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3210         (lookup_partial_symbol, print_partial_symbols)
3211         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3212         (psymbol_compare): Update.
3213         (add_psymbol_to_bcache): Clear the entire psymbol.
3214         (maintenance_check_psymtabs): Update.
3215         * psympriv.h (struct partial_symbol): Don't derive from
3216         general_symbol_info.
3217         <obj_section, unrelocated_address, address,
3218         set_unrelocated_address>: Update.
3219         <ginfo>: New member.
3220         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3221         (debug_names::write_psymbols): Update.
3222
3223 2019-05-04  Tom de Vries  <tdevries@suse.de>
3224
3225         * contrib/cc-with-tweaks.sh: Support -n arg.
3226
3227 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3228
3229         * corelow.c (core_target::detach): Ensure frame cache and
3230         register caches are cleared.
3231         inferior.c (exit_inferior_1): Likewise.
3232
3233 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3234             Tom Tromey  <tom@tromey.com>
3235
3236         * dictionary.c (collate_pending_symbols_by_language): Remove
3237         "struct" from foreach.
3238         * symtab.c (lookup_global_symbol_from_objfile)
3239         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3240         foreach.
3241         * ser-tcp.c (net_open): Remove "struct" from foreach.
3242         * objfiles.c (objfile_relocate, objfile_rebase)
3243         (objfile_has_symbols): Remove "struct" from foreach.
3244         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3245         from foreach.
3246         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3247         foreach.
3248         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3249         "struct" from foreach.
3250         * ada-lang.c (create_excep_cond_exprs)
3251         (ada_exception_catchpoint_cond_string): Remove "struct" from
3252         foreach.
3253
3254 2019-05-03  Tom Tromey  <tromey@adacore.com>
3255
3256         * ada-exp.y (convert_char_literal): Check suffix of each
3257         enumerator.
3258
3259 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3260
3261         PR ada/21406:
3262         * ada-exp.y (yywrap): Don't define.
3263         * ada-lex.l (%option): Add noyywrap
3264         (yywrap): Remove.
3265
3266 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3267
3268         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3269         _WIN32_WINNT to the XP level, unless already defined to a higher
3270         level.
3271
3272         * unittests/parse-connection-spec-selftests.c:
3273         * ser-tcp.c:
3274         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3275         override.
3276
3277         * symfile.c (find_separate_debug_file): Remove colon from the
3278         drive spec of DOS/Windows file names of the target, so that the
3279         file name produced from DEBUGDIR and the target's directory will
3280         be valid on DOS/Windows systems.
3281
3282 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3283
3284         * rust-lang.c (val_print_struct): Handle printing structures
3285         containing strings.
3286
3287 2019-05-02  Tom Tromey  <tromey@adacore.com>
3288
3289         * valarith.c (_initialize_valarith): Remove.
3290
3291 2019-05-01  Tom Tromey  <tromey@adacore.com>
3292
3293         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3294         bitfields.
3295
3296 2019-05-01  Tom Tromey  <tromey@adacore.com>
3297
3298         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3299         for big-endian copies.
3300
3301 2019-04-30  Ali Tamur  <tamur@google.com>
3302         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3303         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3304         (read_3_bytes): New function.
3305
3306 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3307
3308         * windows-nat.c (main_thread_id): Delete.
3309         (handle_output_debug_string): Replace main_thread_id by
3310         current_event.dwThreadId.
3311         (fake_create_process): Likewise.
3312         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3313         Do not set main_thread_id.
3314         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3315         current_event.dwThreadId.
3316         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3317
3318 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3319
3320         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3321         Use current_event.dwThreadId instead of main_thread_id.
3322
3323 2019-04-30  Tom Tromey  <tromey@adacore.com>
3324
3325         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3326         (create_excep_cond_exprs): Iterate over program spaces.
3327         (ada_exception_catchpoint_cond_string): Examine all minimal
3328         symbols for exception types.
3329
3330 2019-04-30  Tom Tromey  <tromey@adacore.com>
3331
3332         PR c++/24470:
3333         * dwarf2read.c (process_structure_scope): Handle case where type
3334         has template parameters but no symbol was created.
3335
3336 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3337             Chris January  <chris.january@arm.com>
3338
3339         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3340         qualifier.
3341         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3342
3343 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3344
3345         * f-typeprint.c (f_print_type): Update rules for printing
3346         whitespace.
3347         (f_type_print_varspec_suffix): Likewise.
3348
3349 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3350             Chris January  <chris.january@arm.com>
3351
3352         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3353         function arguments.
3354
3355 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3356
3357         * f-lang.c (build_fortran_types): Change name of void type to
3358         lower case.
3359         * f-typeprint.c (f_type_print_base): Print the name of the void
3360         type, rather than a fixed string.
3361         * f-valprint.c (f_decorations): Use lower case void string.
3362
3363 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3364             Chris January  <chris.january@arm.com>
3365
3366         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3367         types for Fortran.
3368
3369 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3370             Chris January  <chris.january@arm.com>
3371             David Lecomber  <david.lecomber@arm.com>
3372
3373         * f-exp.y (BINOP_INTRINSIC): New token.
3374         (exp): New parser rule handling BINOP_INTRINSIC.
3375         (f77_keywords): Add new builtin procedures.
3376         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3377         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3378         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3379         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3380         (print_unop_subexp_f): New function.
3381         (print_binop_subexp_f): New function.
3382         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3383         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3384         (dump_subexp_body_f): Likewise.
3385         (operator_check_f): Likewise.
3386         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3387         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3388
3389 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3390
3391         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3392         UNOP_KIND.
3393         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3394         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3395         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3396         (operator_length_f): New fuction.
3397         (print_subexp_f): New function.
3398         (op_name_f): New function.
3399         (dump_subexp_body_f): New function.
3400         (operator_check_f): New function.
3401         (exp_descriptor_f): Replace standard expression handling functions
3402         with new functions.
3403         * gdb/fortran-operator.def: New file.
3404         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3405         * gdb/std-operator.def: Remove UNOP_KIND.
3406
3407 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3408
3409         * std-operator.def: Remove unbalanced, stray double quote
3410         character.
3411
3412 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3413             Chris January  <chris.january@arm.com>
3414             Daniel Everett  <daniel.everett@arm.com>
3415             Nick Forrington  <nick.forrington@arm.com>
3416             Richard Bunt  <richard.bunt@arm.com>
3417
3418         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3419         of depth when printing anonymous structs or unions.
3420         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3421         Don't print either the top-level value, or the children if the
3422         max-depth is exceeded.
3423         (ppscm_print_children): When printing the key of a map, allow one
3424         extra level of depth.
3425         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3426         print either the top-level value, or the children if the max-depth
3427         is exceeded.
3428         (print_children): When printing the key of a map, allow one extra
3429         level of depth.
3430         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3431         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3432         (user_print_options): Initialise max_depth field.
3433         (val_print_scalar_or_string_type_p): New function.
3434         (val_print): Check to see if the max depth has been reached.
3435         (val_print_check_max_depth): Define new function.
3436         (show_print_max_depth): New function.
3437         (_initialize_valprint): Add 'print max-depth' option.
3438         * valprint.h (struct value_print_options) <max_depth>: New field.
3439         (val_print_check_max_depth): Declare new function.
3440         * NEWS: Document new feature.
3441
3442 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3443
3444         * ada-lang.c (ada_language_defn): Initialise new field.
3445         * c-lang.c (c_is_string_type_p): New function.
3446         (c_language_defn): Initialise new field.
3447         (cplus_language_defn): Initialise new field.
3448         (asm_language_defn): Initialise new field.
3449         (minimal_language_defn): Initialise new field.
3450         * c-lang.h (c_is_string_type_p): Declare new function.
3451         * d-lang.c (d_language_defn): Initialise new field.
3452         * f-lang.c (f_is_string_type_p): New function.
3453         (f_language_defn): Initialise new field.
3454         * go-lang.c (go_is_string_type_p): New function.
3455         (go_language_defn): Initialise new field.
3456         * language.c (default_is_string_type_p): New function.
3457         (unknown_language_defn): Initialise new field.
3458         (auto_language_defn): Initialise new field.
3459         * language.h (struct language_defn) <la_is_string_type_p>: New
3460         member variable.
3461         (default_is_string_type_p): Declare new function.
3462         * m2-lang.c (m2_language_defn): Initialise new field.
3463         * objc-lang.c (objc_language_defn): Initialise new field.
3464         * opencl-lang.c (opencl_language_defn): Initialise new field.
3465         * p-lang.c (pascal_is_string_type_p): New function.
3466         (pascal_language_defn): Initialise new field.
3467         * rust-lang.c (rust_is_string_type_p): New function.
3468         (rust_language_defn): Initialise new field.
3469
3470 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3471
3472         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3473         New field.
3474         * ada-lang.c (ada_language_defn): Initialise new field.
3475         * c-lang.c (c_language_defn): Likewise.
3476         (cplus_language_defn): Likewise.
3477         (asm_language_defn): Likewise.
3478         (minimal_language_defn): Likewise.
3479         * d-lang.c (d_language_defn): Likewise.
3480         * f-lang.c (f_language_defn): Likewise.
3481         * go-lang.c (go_language_defn): Likewise.
3482         * language.c (unknown_language_defn): Likewise.
3483         (auto_language_defn): Likewise.
3484         * m2-lang.c (m2_language_defn): Likewise.
3485         * objc-lang.c (objc_language_defn): Likewise.
3486         * opencl-lang.c (opencl_language_defn): Likewise.
3487         * p-lang.c (pascal_language_defn): Likewise.
3488         * rust-lang.c (rust_language_defn): Likewise.
3489
3490 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3491
3492         * ada-lang.c (ada_is_character_type): Change return type to bool.
3493         (ada_is_string_type): Likewise.
3494         * ada-lang.h (ada_is_character_type): Update declaration
3495         (ada_is_string_type): Likewise.
3496
3497 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3498
3499         Support style in 'frame|thread apply'
3500
3501         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3502         * record.c (record_start, record_stop): Update callers of
3503         execute_command_to_string with false.
3504         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3505         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3506         methods.
3507         (class string_file): New constructor with term_out parameter.
3508         Override methods term_out and can_emit_style_escape.  New member
3509         term_out.
3510         (class stdio_file): Override can_emit_style_escape.
3511         (class tee_file): Override term_out and can_emit_style_escape.
3512         * utils.h (can_emit_style_escape): Remove.
3513         * utils.c (can_emit_style_escape): Likewise.
3514         Update all callers of can_emit_style_escape (SOMESTREAM) to
3515         SOMESTREAM->can_emit_style_escape.
3516         * source-cache.c (source_cache::get_source_lines): Likewise.
3517         * stack.c (frame_apply_command_count): Call execute_command_to_string
3518         passing the term_out characteristic of the current gdb_stdout.
3519         * thread.c (thr_try_catch_cmd): Likewise.
3520         * top.c (execute_command_to_string): pass term_out parameter
3521         to construct the string_file for the command output.
3522         * ui-file.c (term_cli_styling): New function (most code moved
3523         from utils.c can_emit_style_escape).
3524         (string_file::string_file, string_file::can_emit_style_escape,
3525         stdio_file::can_emit_style_escape, tee_file::term_out,
3526         tee_file::can_emit_style_escape): New functions.
3527
3528 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3529
3530         * NEWS: Mention the new set|show may-call-functions.
3531         * infcall.c (may_call_functions_p): New variable.
3532         (show_may_call_functions_p): New function.
3533         (call_function_by_hand_dummy): Throws an error if not
3534         may-call-functions.
3535         (_initialize_infcall): Call add_setshow_boolean_cmd for
3536         may-call-functions.
3537
3538 2019-04-25  Keith Seitz  <keiths@redhat.com>
3539
3540         PR c++/24367
3541         * cp-support.c (inspect_type): Don't attempt substitutions
3542         of symbol with the same name.
3543
3544 2019-04-25  Tom Tromey  <tromey@adacore.com>
3545
3546         PR gdb/24475:
3547         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3548         static.
3549
3550 2019-04-25  Tom Tromey  <tromey@adacore.com>
3551
3552         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3553         rvalue reference.
3554         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3555         (gdb_xml_parser::parse): Use std::move.
3556         * python/python-internal.h (gdbpy_convert_exception): Take a const
3557         reference.
3558         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3559         std::move.
3560         * python/py-utils.c (gdbpy_convert_exception): Take a const
3561         reference.
3562         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3563         Use std::move.
3564         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3565         Use std::move.
3566         * mi/mi-main.c (mi_print_exception): Take a const reference.
3567         * main.c (handle_command_errors): Take a const reference.
3568         * linespec.c (parse_linespec): Use std::move.
3569         * infcall.c (run_inferior_call): Use std::move.
3570         (call_function_by_hand_dummy): Use std::move.
3571         * exec.c (try_open_exec_file): Use std::move.
3572         * exceptions.h (exception_print, exception_fprintf)
3573         (exception_print_same): Update.
3574         * exceptions.c (print_exception, exception_print)
3575         (exception_fprintf, exception_print_same): Change parameters to
3576         const reference.
3577         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3578         * common/new-op.c: Use std::move.
3579         * common/common-exceptions.h (struct gdb_exception): Add move
3580         constructor.
3581         (struct gdb_exception_error, struct gdb_exception_quit, struct
3582         gdb_quit_bad_alloc): Change constructor to move constructor.
3583         (throw_exception): Change parameter to rvalue reference.
3584         * common/common-exceptions.c (throw_exception): Take rvalue
3585         reference.
3586         * cli/cli-interp.c (safe_execute_command): Use std::move.
3587         * breakpoint.c (insert_bp_location, location_to_sals): Use
3588         std::move.
3589
3590 2019-04-25  Tom Tromey  <tromey@adacore.com>
3591
3592         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3593         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3594         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3595         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3596         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3597         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3598         guile/scm-value.c: Use unpack.
3599         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3600         gdbscm_gdb_exception.
3601         (gdbscm_throw_gdb_exception): Likewise.
3602         (struct gdbscm_gdb_exception): New.
3603         (unpack): New function.
3604         (gdbscm_wrap): Use unpack.
3605
3606 2019-04-25  Tom Tromey  <tromey@adacore.com>
3607
3608         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3609         (gdb_rl_callback_handler): Use std::move.
3610         * common/common-exceptions.h (struct gdb_exception): Add move
3611         assignment operator.
3612         (throw_exception_sjlj): Change "exception" to const reference.
3613         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3614         (throw_exception_sjlj): Change "exception" to const reference.
3615
3616 2019-04-25  Tom Tromey  <tromey@adacore.com>
3617
3618         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3619         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3620         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3621         Update.
3622         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3623         Update.
3624         * mi/mi-interp.c (mi_interp::exec): Update.
3625         * linespec.c (parse_linespec): Update.
3626         * infcall.c (run_inferior_call): Update.
3627         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3628         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3629         (gdbscm_lookup_global_symbol): Update.
3630         * guile/scm-param.c (gdbscm_parameter_value): Update.
3631         * guile/scm-frame.c (gdbscm_frame_read_register)
3632         (gdbscm_frame_read_var): Update.
3633         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3634         * exec.c (try_open_exec_file): Update.
3635         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3636         (gdb_rl_callback_handler): Update.
3637         * common/common-exceptions.h (exception_none): Don't declare.
3638         * common/common-exceptions.c (exception_none): Don't define.
3639         (struct catcher) <exception>: Update.
3640         * cli/cli-interp.c (safe_execute_command): Update.
3641         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3642
3643 2019-04-25  Ali Tamur  <tamur@google.com>
3644
3645         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3646         (read_attribute_value): Likewise.
3647         (dwarf2_read_addr_index): Update comment.
3648         (read_str_index): Add DW_FORM_strx.
3649         (dwarf2_string_attr): Likewise.
3650         (dwarf2_const_value_attr): Likewise.
3651         (dump_die_shallow): Likewise.
3652         (dwarf2_fetch_constant_bytes): Likewise.
3653         (skip_form_bytes): Likewise.
3654         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3655
3656 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3657
3658         PR corefiles/11608
3659         PR corefiles/18187
3660         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3661         OFFSET.  Verify if current mapping contains an ELF header.
3662         (linux_find_memory_regions_full): Adjust call to
3663         dump_mapping_p.
3664
3665 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3666             Kang Li <kanglictf@gmail.com>
3667
3668         PR gdb/21600
3669
3670         * dwarf2-frame.c (read_initial_length): Be consistent about using
3671         unsigned representation of length.
3672         (decode_frame_entry_1): Likewise.  Check for wraparound of
3673         end pointer as well as buffer overflow.
3674
3675 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3676
3677         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3678         "vq".
3679
3680 2019-04-24  Tom Tromey  <tromey@adacore.com>
3681
3682         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3683
3684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3685
3686         * s12z-tdep.c (s12z_unwind_pc): Delete.
3687         (s12z_unwind_sp): Delete.
3688         (s12z_gdbarch_init): Don't register deleted functions with
3689         gdbarch.
3690
3691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * rl78-tdep.c (rl78_unwind_sp): Delete.
3694         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3695
3696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3697
3698         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3699         (xstormy16_unwind_pc): Delete.
3700         (xstormy16_dummy_id): Delete.
3701         (xstormy16_gdbarch_init): Don't register deleted functions with
3702         gdbarch.
3703
3704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * vax-tdep.c (vax_unwind_pc): Delete.
3707         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3708
3709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3710
3711         * v850-tdep.c (v850_unwind_sp): Delete.
3712         (v850_unwind_pc): Delete.
3713         (v850_dummy_id): Delete.
3714         (v850_gdbarch_init): Don't register deleted functions with
3715         gdbarch.
3716
3717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3718
3719         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3720         (tilegx_unwind_pc): Delete.
3721         (tilegx_unwind_dummy_id): Delete.
3722         (tilegx_gdbarch_init): Don't register deleted functions with
3723         gdbarch.
3724
3725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3728         (tic6x_dummy_id): Delete.
3729         (tic6x_gdbarch_init): Don't register deleted functions with
3730         gdbarch.
3731
3732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3733
3734         * sparc-tdep.c (sparc_unwind_pc): Delete.
3735         (sparc32_gdbarch_init): Don't register deleted function with
3736         gdbarch.
3737
3738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * sh-tdep.c (sh_unwind_sp): Delete.
3741         (sh_unwind_pc): Delete.
3742         (sh_dummy_id): Delete.
3743         (sh_gdbarch_init): Don't register deleted functions with
3744         gdbarch.
3745
3746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * score-tdep.c (score_unwind_sp): Delete.
3749         (score_unwind_pc): Delete.
3750         (score_dummy_id): Delete.
3751         (score_gdbarch_init): Don't register deleted functions with
3752         gdbarch.
3753
3754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3755
3756         * rx-tdep.c (rx_unwind_pc): Delete.
3757         (rx_unwind_sp): Delete.
3758         (rx_dummy_id): Delete.
3759         (rx_gdbarch_init): Don't register deleted functions with
3760         gdbarch.  Update comment.
3761
3762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3763
3764         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3765         (rs6000_dummy_id): Delete.
3766         (rs6000_gdbarch_init): Don't register deleted functions with
3767         gdbarch.
3768
3769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         * or1k-tdep.c (or1k_dummy_id): Delete.
3772         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3773
3774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3775
3776         * nios2-tdep.c (nios2_dummy_id): Delete.
3777         (nios2_unwind_sp): Delete.
3778         (nios2_gdbarch_init): Don't register deleted functions with
3779         gdbarch.
3780
3781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * nds32-tdep.c (nds32_dummy_id): Delete.
3784         (nds32_unwind_pc): Delete.
3785         (nds32_unwind_sp): Delete.
3786         (nds32_gdbarch_init): Don't register deleted functions with
3787         gdbarch.
3788
3789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3790
3791         * msp430-tdep.c (msp430_unwind_pc): Delete.
3792         (msp430_unwind_sp): Delete.
3793         (msp430_dummy_id): Delete.
3794         (msp430_gdbarch_init): Don't register deleted functions with
3795         gdbarch.
3796
3797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3798
3799         * moxie-tdep.c (moxie_unwind_sp): Delete.
3800         (moxie_unwind_pc): Delete.
3801         (moxie_dummy_id): Delete.
3802         (moxie_gdbarch_init): Don't register deleted functions with
3803         gdbarch.
3804
3805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3808         (mn10300_unwind_pc): Delete.
3809         (mn10300_unwind_sp): Delete.
3810         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3811         mn10300_unwind_sp.
3812         (mn10300_frame_unwind_init): Don't register deleted functions with
3813         gdbarch.
3814
3815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3816
3817         * mep-tdep.c (mep_unwind_pc): Delete.
3818         (mep_unwind_sp): Delete.
3819         (mep_dummy_id): Delete.
3820         (mep_gdbarch_init): Don't register deleted functions with
3821         gdbarch.
3822
3823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3826         (m68hc11_unwind_sp): Delete.
3827         (m68hc11_gdbarch_init): Don't register deleted functions with
3828         gdbarch.
3829
3830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * m32r-tdep.c (m32r_unwind_sp): Delete.
3833         (m32r_unwind_pc): Delete.
3834         (m32r_dummy_id): Delete.
3835         (m32r_gdbarch_init): Don't register deleted functions with
3836         gdbarch.
3837
3838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3839
3840         * m32c-tdep.c (m32c_unwind_pc): Delete.
3841         (m32c_unwind_sp): Delete.
3842         (m32c_dummy_id): Delete.
3843         (m32c_gdbarch_init): Don't register deleted functions with
3844         gdbarch.
3845
3846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3847
3848         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3849         (lm32_unwind_pc): Delete.
3850         (lm32_dummy_id): Delete.
3851         (lm32_gdbarch_init): Don't register deleted functions with
3852         gdbarch.
3853
3854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3857         (iq2000_unwind_pc): Delete.
3858         (iq2000_dummy_id): Delete.
3859         (iq2000_gdbarch_init): Don't register deleted functions with
3860         gdbarch.
3861
3862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3863
3864         * nds32-tdep.c (nds32_type_align): Delete.
3865         (nds32_push_dummy_call): Use type_align instead.
3866
3867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * arm-tdep.c (arm_type_align): Only handle vector override case.
3870         (arm_push_dummy_call): Use type_align.
3871         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3872
3873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3874
3875         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3876         case.
3877         (pass_on_stack): Use type_align.
3878         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3879         function.
3880
3881 2019-04-23  Tom Tromey  <tromey@adacore.com>
3882
3883         * dwarf2read.c (line_header::file_name_at): Remove unused
3884         overload.
3885
3886 2019-04-23  Tom de Vries  <tdevries@suse.de>
3887
3888         PR gdb/24438
3889         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3890         invocation.
3891
3892
3893 2019-03-27  Ali Tamur  <tamur@google.com>
3894
3895         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3896         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3897         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3898         (dwarf_expr_context::get_addr_index): Likewise
3899         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3900         (symbol_needs_eval_context::get_addr_index): Likewise
3901         (disassemble_dwarf_expression): Add DW_OP_addrx
3902         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3903         (read_cutu_die_from_dwo): Update comment
3904         (skip_one_die): Add DW_FORM_addrx
3905         (read_attribute_value): Likewise
3906         (var_decode_location): Add DW_OP_addrx
3907         (dwarf2_const_value_attr): Add DW_FORM_addrx
3908         (dump_die_shallow): Likewise
3909         (dwarf2_fetch_constant_bytes): Likewise
3910         (decode_locdesc): Add DW_OP_addrx
3911         (skip_form_bytes): Add DW_FORM_addrx
3912
3913 2019-04-22  Ali Tamur  <tamur@google.com>
3914
3915         * MAINTAINERS (Write After Approval): Add self.
3916
3917 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3918
3919         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3920         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3921         (open_symbol_file_object): Likewise.
3922         (svr4_default_sos): Add info parameter.
3923         (svr4_read_so_list): Likewise.
3924         (svr4_current_sos_direct): Adjust functions calls to pass down
3925         info.
3926         (svr4_current_sos_1): Add info parameter.
3927         (svr4_current_sos): Call get_svr4_info, pass info down to
3928         svr4_current_sos_1.
3929         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3930         get_svr4_info.
3931         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3932         get_svr4_info.
3933         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3934         to get_svr4_info.
3935         (probes_table_remove_objfile_probes): Likewise.
3936         (register_solib_event_probe): Add info parameter.
3937         (solist_update_incremental): Pass info parameter down to
3938         svr4_read_so_list.
3939         (disable_probes_interface): Add info parameter.
3940         (svr4_handle_solib_event): Pass current_program_space to
3941         get_svr4_info.  Adjust disable_probes_interface cleanup.
3942         (svr4_create_probe_breakpoints): Add info parameter, pass it
3943         down to register_solib_event_probe.
3944         (svr4_create_solib_event_breakpoints): Add info parameter,
3945         pass it down to svr4_create_probe_breakpoints.
3946         (enable_break): Pass info down to
3947         svr4_create_solib_event_breakpoints.
3948         (svr4_solib_create_inferior_hook): Pass current_program_space to
3949         get_svr4_info.
3950         (svr4_clear_solib): Likewise.
3951
3952 2019-04-22  Pedro Alves  <palves@redhat.com>
3953
3954         * solib-svr4.c (svr4_free_objfile_observer): New.
3955         (probe_and_action::objfile): New field.
3956         (probes_table_htab_remove_objfile_probes)
3957         (probes_table_remove_objfile_probes): New functions.
3958         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3959         in the new probe_and_action.  Don't store the probe in 'lookup'.
3960         (svr4_create_probe_breakpoints): Pass objfile to
3961         register_solib_event_probe.
3962         (_initialize_svr4_solib): Register a free_objfile observer.
3963
3964 2019-04-19  Tom Tromey  <tom@tromey.com>
3965
3966         * common/queue.h: Remove.
3967
3968 2019-04-19  Tom Tromey  <tom@tromey.com>
3969
3970         * event-loop.c: Don't include "common/queue.h".
3971
3972 2019-04-19  Tom Tromey  <tom@tromey.com>
3973
3974         * remote.c (remote_target): Use delete.
3975         * remote-notif.h: Include <list>, not "common/queue.h".
3976         (notif_client_p): Remove typedef.
3977         (remote_notif_state): Add constructor, destructor, initializer.
3978         <notif_queue>: Now a std::list.
3979         (remote_notif_state_xfree): Don't declare.
3980         * remote-notif.c (remote_notif_process, handle_notification)
3981         (remote_notif_state_allocate): Update.
3982         (~remote_notif_state): Rename from remote_notif_state_xfree.
3983
3984 2019-04-19  Tom Tromey  <tom@tromey.com>
3985
3986         * symfile.c (reread_symbols): Update.
3987         * objfiles.c (objfile_register_static_link)
3988         (objfile_lookup_static_link): Update
3989         (~objfile) Don't delete static_links.
3990         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3991
3992 2019-04-19  Tom Tromey  <tom@tromey.com>
3993
3994         * type-stack.h (struct type_stack) <insert>: Constify string.
3995         * type-stack.c (type_stack::insert): Constify string.
3996         * gdbtypes.h (lookup_template_type): Update.
3997         (address_space_name_to_int): Update.
3998         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3999         const.
4000         (lookup_template_type): Make name const.
4001         * c-exp.y: Update rules.
4002         (lex_one_token, classify_name, classify_inner_name)
4003         (c_print_token): Update.
4004         * p-exp.y: Update rules.
4005         (yylex): Update.
4006         * f-exp.y: Update rules.
4007         (yylex): Update.
4008         * d-exp.y: Update rules.
4009         (lex_one_token, classify_name, classify_inner_name): Update.
4010         * parse.c (write_dollar_variable, copy_name): Return std::string.
4011         * parser-defs.h (copy_name): Change return type.
4012         * m2-exp.y: Update rules.
4013         (yylex): Update.
4014         * go-exp.y (lex_one_token): Update.
4015         Update rules.
4016         (classify_unsafe_function, classify_packaged_name)
4017         (classify_name, yylex): Update.
4018
4019 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4020
4021         * configure.ac: add --enable-source-highlight switch.
4022         * configure: Regenerate.
4023         * top.c (print_gdb_version): plumb --enable-source-highlight
4024         status to "show configuration".
4025
4026 2019-04-19  Tom Tromey  <tromey@adacore.com>
4027
4028         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4029         Check ADA_TYPE_P.
4030         (empty_record, ada_template_to_fixed_record_type_1)
4031         (template_to_static_fixed_type)
4032         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4033         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4034         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4035         macros.
4036
4037 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4038
4039         PR symtab/24423:
4040         * source.c (print_source_lines_base): Advance "iter" when a
4041         control character is seen.
4042
4043 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4044
4045         * inferior.h (struct infcall_suspend_state_deleter):
4046         Catch exception in destructor to avoid crash.
4047
4048 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4049
4050         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4051         close to the add_com "shell".
4052
4053 2019-04-18  Tom Tromey  <tromey@adacore.com>
4054
4055         * process-stratum-target.h (class process_stratum_target)
4056         <stratum>: Add "final".
4057
4058 2019-04-17  Tom Tromey  <tromey@adacore.com>
4059
4060         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4061         against nullptr before use.
4062
4063 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4064
4065         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4066
4067 2019-04-17  Jim Wilson  <jimw@sifive.com>
4068             Andrew Burgess  <andrew.burgess@embecosm.com>
4069
4070         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4071         code read might fail, assume 4-byte breakpoint in that case.
4072
4073 2019-04-15  Leszek Swirski  <leszeks@google.com>
4074
4075         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4076         rather than a hand-rolled POD check when checking for forced MEMORY
4077         classification.
4078
4079 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4080
4081         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4082         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4083         function.
4084         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4085         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4086         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4087         declaration.
4088
4089 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4090
4091         * aarch64-linux-nat.c
4092         (aarch64_linux_nat_target::thread_architecture): Add override.
4093         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4094         each VQ.
4095
4096 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4097
4098         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4099
4100 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4101
4102         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4103         target types of size 96-bits, add some additional comments, and
4104         check that the builtin type we found was the correct size.
4105
4106 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4107
4108         * utils.c (prompt_for_continue): Don't restore the styling at the
4109         end, as applied_style has the wrong value.  This fixes styling in
4110         long lists of file names that are interrupted by the "Continue?"
4111         prompt.
4112
4113 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4116         * c-lang.c (c_language_defn): Likewise.
4117         (cplus_language_defn): Likewise.
4118         (asm_language_defn): Likewise.
4119         (minimal_language_defn): Likewise.
4120         * d-lang.c (d_language_defn): Likewise.
4121         * f-lang.c (f_language_defn): Likewise.
4122         * go-lang.c (go_language_defn): Likewise.
4123         * language.c (unknown_language_defn): Likewise.
4124         (auto_language_defn): Likewise.
4125         * language.h (struct language_defn): Remove la_magic field.
4126         (LANG_MAGIC): Delete.
4127         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4128         * objc-lang.c (objc_language_defn): Likewise.
4129         * opencl-lang.c (opencl_language_defn): Likewise.
4130         * p-lang.c (pascal_language_defn): Likewise.
4131         * rust-lang.c (rust_language_defn): Likewise.
4132
4133 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4134
4135         * riscv-tdep.c (riscv_type_align): New function.
4136         (riscv_type_alignment): Delete.
4137         (riscv_arg_location): Use 'type_align'.
4138         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4139
4140 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4141
4142         * gdbtypes.c (type_align): A struct with no non-static fields also
4143         has alignment of 1.
4144
4145 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4146
4147         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4148         component to 0.
4149         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4150         member.
4151         (riscv_struct_info::analyse): New implementation using new
4152         analyse_inner member function.
4153         (riscv_struct_info::field_offset): New member function.
4154         (riscv_struct_info::m_offsets): New member variable.
4155         (riscv_struct_info::analyse_inner): New private member function,
4156         takes the old implementation of riscv_struct_info::analyse but
4157         extended to track field offsets.
4158         (riscv_call_arg_struct): Update the struct folding special cases
4159         to handle cases where empty C++ structs, which are non-zero
4160         length, are found.
4161         (riscv_arg_location): Initialise the length of each location, a
4162         non-zero length now indicates the location is in use.
4163         (riscv_push_dummy_call): Allow for the first location having a
4164         non-zero offset when setting up arguments.
4165         (riscv_return_value): Likewise, but for return values.
4166
4167 2019-04-11  Tom Tromey  <tromey@adacore.com>
4168
4169         * utils.c (internal_vproblem): Make "msg" const.
4170
4171 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4172
4173         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4174         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4175         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4176         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4177
4178 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4179
4180         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4181         function.
4182         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4183         of amd64_collect_native_gregset.
4184         (amd64_linux_nat_target::store_registers): Likewise.
4185
4186 2019-04-10  Tom Tromey  <tom@tromey.com>
4187
4188         * symtab.c (lookup_global_symbol_from_objfile)
4189         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4190         * objfiles.h (class separate_debug_iterator): New.
4191         (class separate_debug_range): New.
4192         (struct objfile) <separate_debug_objfiles>: New method.
4193         (objfile_separate_debug_iterate): Don't declare.
4194         * objfiles.c (separate_debug_iterator::operator++): Rename from
4195         objfile_separate_debug_iterate.
4196         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4197         iterator.
4198         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4199         iterator.
4200
4201 2019-04-10  Tom Tromey  <tom@tromey.com>
4202
4203         * symfile.c (reread_symbols): Remove old comment.
4204         * objfiles.c (free_all_objfiles): Fix a typo.
4205
4206 2019-04-10  Tom Tromey  <tom@tromey.com>
4207
4208         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4209         * minsyms.c (lookup_minimal_symbol): Use foreach.
4210         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4211         (lookup_minimal_symbol_solib_trampoline): Likewise.
4212         * symfile.c (reread_symbols): Use foreach.
4213
4214 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4215             Tom Tromey  <tromey@adacore.com>
4216
4217         PR rust/24414:
4218         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4219         (rust_lex_int_test): Change "value" to be LONGEST.
4220         (rust_lex_tests): Add test for long integer literal.
4221
4222 2019-04-09  Tom Tromey  <tromey@adacore.com>
4223
4224         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4225         to bool.
4226         (extended_remote_target::attach): Update.
4227         (remote_target::remote_notice_new_inferior): Update.
4228         (remote_target::add_current_inferior_and_thread): Update.
4229         * inferior.c (exit_inferior_1): Use "false".
4230         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4231
4232 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4233
4234         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4235         the "start" command.
4236
4237 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4238
4239         * python/py-inferior.c (infpy_thread_from_thread_handle):
4240         Adjust comments to reflect renaming of thread_from_thread_handle
4241         to thread_from_handle.  Adjust keywords.  Fix type error message.
4242         (inferior_object_methods): Add thread_from_handle.  Retain
4243         thread_from_thread_handle, but mark it as deprecated.
4244
4245 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4246
4247         * gdbthread.h (find_thread_by_handle): Revise declaration.
4248         * thread.c (find_thread_by_handle): Likewise.  Adjust
4249         implementation too.
4250         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4251         support for buffer objects as handles.
4252
4253 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4254
4255         * python/py-infthread.c (thpy_thread_handle): New function.
4256         (thread_object_methods): Register thpy_thread_handle.
4257
4258 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4259
4260         * gdbthread.h (thread_to_thread_handle): Declare.
4261         * thread.c (gdbtypes.h): Include.
4262         (thread_to_thread_handle): New function.
4263
4264         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4265         (target_thread_info_to_thread_handle): Declare.
4266         * target.c (target_thread_info_to_thread_handle): New function.
4267         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4268         * target-delegates.c: Regenerate.
4269
4270         * linux-thread-db.c (class thread_db_target): Add method
4271         thread_info_to_thread_handle.
4272         (thread_db_target::thread_info_to_thread_handle): Define.
4273         * remote.c (class remote_target): Add new method
4274         thread_info_to_thread_handle.
4275         (remote_target::thread_info_to_thread_handle): Define.
4276
4277 2019-04-08  Pedro Alves  <palves@redhat.com>
4278
4279         * common/common-exceptions.c (throw_exception): Don't create
4280         named object to throw; throw directly.
4281         (throw_it): Likewise.  Don't initialize gdb_exception::message
4282         here, with new; pass FMT and AP to the ctor instead.
4283         * common/common-exceptions.h: Include <string>.
4284         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4285         const char *, va_list)): New ctor.  Use std::make_shared.
4286         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4287         errors)): Delete.
4288         (gdb_exception_error::gdb_exception_error(enum errors, const char
4289         *, va_list)): New.
4290         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4291         Add assertion.
4292         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4293         errors)): Delete.
4294         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4295         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4296         Add assertion.
4297
4298 2019-04-08  Tom Tromey  <tom@tromey.com>
4299
4300         * valops.c (value_rtti_indirect_type): Replace throw_exception
4301         with throw.
4302         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4303         with throw.
4304         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4305         throw.
4306         * target.c (target_translate_tls_address): Replace throw_exception
4307         with throw.
4308         * stack.c (frame_apply_command_count): Replace throw_exception
4309         with throw.
4310         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4311         throw.
4312         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4313         with throw.
4314         * rs6000-tdep.c (rs6000_frame_cache)
4315         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4316         * remote.c: Replace throw_exception with throw.
4317         * record-full.c (record_full_message, record_full_wait_1)
4318         (record_full_restore): Replace throw_exception with throw.
4319         * record-btrace.c:
4320         (get_thread_current_frame_id, record_btrace_start_replaying)
4321         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4322         (cmd_record_btrace_start): Replace throw_exception with throw.
4323         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4324         throw.
4325         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4326         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4327         * linespec.c:
4328         (find_linespec_symbols): Replace throw_exception with throw.
4329         * infrun.c (displaced_step_prepare, resume): Replace
4330         throw_exception with throw.
4331         * infcmd.c (post_create_inferior): Replace throw_exception with
4332         throw.
4333         * inf-loop.c (inferior_event_handler): Replace throw_exception
4334         with throw.
4335         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4336         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4337         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4338         (get_prev_frame_always, get_frame_pc_if_available)
4339         (get_frame_address_in_block_if_available, get_frame_language):
4340         Replace throw_exception with throw.
4341         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4342         throw_exception with throw.
4343         * eval.c (fetch_subexp_value, evaluate_var_value)
4344         (evaluate_funcall, evaluate_subexp_standard): Replace
4345         throw_exception with throw.
4346         * dwarf2loc.c (call_site_find_chain)
4347         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4348         Replace throw_exception with throw.
4349         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4350         with throw.
4351         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4352         throw.
4353         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4354         * completer.c (complete_line_internal): Replace throw_exception
4355         with throw.
4356         * compile/compile-object-run.c (compile_object_run): Replace
4357         throw_exception with throw.
4358         * cli/cli-script.c (process_next_line): Replace throw_exception
4359         with throw.
4360         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4361         (btrace_enable, btrace_maint_update_pt_packets): Replace
4362         throw_exception with throw.
4363         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4364         throw_exception with throw.
4365         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4366         throw_exception with throw.
4367         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4368         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4369         * aarch64-tdep.c (aarch64_make_prologue_cache)
4370         (aarch64_make_stub_cache): Replace throw_exception with throw.
4371
4372 2019-04-08  Tom Tromey  <tom@tromey.com>
4373
4374         * common/common-exceptions.c (throw_exception): Rename from
4375         throw_exception_cxx.  Remove old copy.  Make argument const.
4376         (throw_it): Create and throw exception objects directly.
4377         * common/common-exceptions.h (throw_exception): Make argument
4378         const.
4379         (struct gdb_exception_error): Add constructor.
4380         (struct gdb_exception_quit): Add constructor.
4381
4382 2019-04-08  Tom Tromey  <tom@tromey.com>
4383
4384         * common/common-exceptions.h (exception_rethrow): Don't declare.
4385         (TRY_SJLJ): Update comment.
4386         (TRY, CATCH, END_CATCH): Remove.
4387         * common/common-exceptions.c (exception_rethrow): Remove.
4388
4389 2019-04-08  Tom Tromey  <tom@tromey.com>
4390
4391         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4392         Remove.
4393         (gdb_exception_error): Rename from
4394         gdb_exception_RETURN_MASK_ERROR.
4395         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4396         (gdb_quit_bad_alloc): Update.
4397         * aarch64-tdep.c: Update.
4398         * ada-lang.c: Update.
4399         * ada-typeprint.c: Update.
4400         * ada-valprint.c: Update.
4401         * amd64-tdep.c: Update.
4402         * arch-utils.c: Update.
4403         * break-catch-throw.c: Update.
4404         * breakpoint.c: Update.
4405         * btrace.c: Update.
4406         * c-varobj.c: Update.
4407         * cli/cli-cmds.c: Update.
4408         * cli/cli-interp.c: Update.
4409         * cli/cli-script.c: Update.
4410         * common/common-exceptions.c: Update.
4411         * common/new-op.c: Update.
4412         * common/selftest.c: Update.
4413         * compile/compile-c-symbols.c: Update.
4414         * compile/compile-cplus-symbols.c: Update.
4415         * compile/compile-object-load.c: Update.
4416         * compile/compile-object-run.c: Update.
4417         * completer.c: Update.
4418         * corelow.c: Update.
4419         * cp-abi.c: Update.
4420         * cp-support.c: Update.
4421         * cp-valprint.c: Update.
4422         * darwin-nat.c: Update.
4423         * disasm-selftests.c: Update.
4424         * dtrace-probe.c: Update.
4425         * dwarf-index-cache.c: Update.
4426         * dwarf-index-write.c: Update.
4427         * dwarf2-frame-tailcall.c: Update.
4428         * dwarf2-frame.c: Update.
4429         * dwarf2loc.c: Update.
4430         * dwarf2read.c: Update.
4431         * eval.c: Update.
4432         * event-loop.c: Update.
4433         * event-top.c: Update.
4434         * exec.c: Update.
4435         * f-valprint.c: Update.
4436         * fbsd-tdep.c: Update.
4437         * frame-unwind.c: Update.
4438         * frame.c: Update.
4439         * gdbtypes.c: Update.
4440         * gnu-v3-abi.c: Update.
4441         * guile/guile-internal.h: Update.
4442         * guile/scm-block.c: Update.
4443         * guile/scm-breakpoint.c: Update.
4444         * guile/scm-cmd.c: Update.
4445         * guile/scm-disasm.c: Update.
4446         * guile/scm-frame.c: Update.
4447         * guile/scm-lazy-string.c: Update.
4448         * guile/scm-math.c: Update.
4449         * guile/scm-param.c: Update.
4450         * guile/scm-ports.c: Update.
4451         * guile/scm-pretty-print.c: Update.
4452         * guile/scm-symbol.c: Update.
4453         * guile/scm-symtab.c: Update.
4454         * guile/scm-type.c: Update.
4455         * guile/scm-value.c: Update.
4456         * i386-linux-tdep.c: Update.
4457         * i386-tdep.c: Update.
4458         * inf-loop.c: Update.
4459         * infcall.c: Update.
4460         * infcmd.c: Update.
4461         * infrun.c: Update.
4462         * jit.c: Update.
4463         * language.c: Update.
4464         * linespec.c: Update.
4465         * linux-fork.c: Update.
4466         * linux-nat.c: Update.
4467         * linux-tdep.c: Update.
4468         * linux-thread-db.c: Update.
4469         * main.c: Update.
4470         * mi/mi-cmd-break.c: Update.
4471         * mi/mi-cmd-stack.c: Update.
4472         * mi/mi-interp.c: Update.
4473         * mi/mi-main.c: Update.
4474         * objc-lang.c: Update.
4475         * p-valprint.c: Update.
4476         * parse.c: Update.
4477         * ppc-linux-tdep.c: Update.
4478         * printcmd.c: Update.
4479         * python/py-arch.c: Update.
4480         * python/py-breakpoint.c: Update.
4481         * python/py-cmd.c: Update.
4482         * python/py-finishbreakpoint.c: Update.
4483         * python/py-frame.c: Update.
4484         * python/py-framefilter.c: Update.
4485         * python/py-gdb-readline.c: Update.
4486         * python/py-inferior.c: Update.
4487         * python/py-infthread.c: Update.
4488         * python/py-lazy-string.c: Update.
4489         * python/py-linetable.c: Update.
4490         * python/py-objfile.c: Update.
4491         * python/py-param.c: Update.
4492         * python/py-prettyprint.c: Update.
4493         * python/py-progspace.c: Update.
4494         * python/py-record-btrace.c: Update.
4495         * python/py-record.c: Update.
4496         * python/py-symbol.c: Update.
4497         * python/py-type.c: Update.
4498         * python/py-unwind.c: Update.
4499         * python/py-utils.c: Update.
4500         * python/py-value.c: Update.
4501         * python/python.c: Update.
4502         * record-btrace.c: Update.
4503         * record-full.c: Update.
4504         * remote-fileio.c: Update.
4505         * remote.c: Update.
4506         * riscv-tdep.c: Update.
4507         * rs6000-aix-tdep.c: Update.
4508         * rs6000-tdep.c: Update.
4509         * rust-exp.y: Update.
4510         * rust-lang.c: Update.
4511         * s390-tdep.c: Update.
4512         * selftest-arch.c: Update.
4513         * solib-dsbt.c: Update.
4514         * solib-frv.c: Update.
4515         * solib-spu.c: Update.
4516         * solib-svr4.c: Update.
4517         * solib.c: Update.
4518         * sparc64-linux-tdep.c: Update.
4519         * stack.c: Update.
4520         * symfile-mem.c: Update.
4521         * symmisc.c: Update.
4522         * target.c: Update.
4523         * thread.c: Update.
4524         * top.c: Update.
4525         * tracefile-tfile.c: Update.
4526         * tui/tui.c: Update.
4527         * typeprint.c: Update.
4528         * unittests/cli-utils-selftests.c: Update.
4529         * unittests/parse-connection-spec-selftests.c: Update.
4530         * valops.c: Update.
4531         * valprint.c: Update.
4532         * value.c: Update.
4533         * varobj.c: Update.
4534         * windows-nat.c: Update.
4535         * x86-linux-nat.c: Update.
4536         * xml-support.c: Update.
4537
4538 2019-04-08  Tom Tromey  <tom@tromey.com>
4539
4540         * xml-support.c: Use C++ exception handling.
4541         * x86-linux-nat.c: Use C++ exception handling.
4542         * windows-nat.c: Use C++ exception handling.
4543         * varobj.c: Use C++ exception handling.
4544         * value.c: Use C++ exception handling.
4545         * valprint.c: Use C++ exception handling.
4546         * valops.c: Use C++ exception handling.
4547         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4548         handling.
4549         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4550         * typeprint.c: Use C++ exception handling.
4551         * tui/tui.c: Use C++ exception handling.
4552         * tracefile-tfile.c: Use C++ exception handling.
4553         * top.c: Use C++ exception handling.
4554         * thread.c: Use C++ exception handling.
4555         * target.c: Use C++ exception handling.
4556         * symmisc.c: Use C++ exception handling.
4557         * symfile-mem.c: Use C++ exception handling.
4558         * stack.c: Use C++ exception handling.
4559         * sparc64-linux-tdep.c: Use C++ exception handling.
4560         * solib.c: Use C++ exception handling.
4561         * solib-svr4.c: Use C++ exception handling.
4562         * solib-spu.c: Use C++ exception handling.
4563         * solib-frv.c: Use C++ exception handling.
4564         * solib-dsbt.c: Use C++ exception handling.
4565         * selftest-arch.c: Use C++ exception handling.
4566         * s390-tdep.c: Use C++ exception handling.
4567         * rust-lang.c: Use C++ exception handling.
4568         * rust-exp.y: Use C++ exception handling.
4569         * rs6000-tdep.c: Use C++ exception handling.
4570         * rs6000-aix-tdep.c: Use C++ exception handling.
4571         * riscv-tdep.c: Use C++ exception handling.
4572         * remote.c: Use C++ exception handling.
4573         * remote-fileio.c: Use C++ exception handling.
4574         * record-full.c: Use C++ exception handling.
4575         * record-btrace.c: Use C++ exception handling.
4576         * python/python.c: Use C++ exception handling.
4577         * python/py-value.c: Use C++ exception handling.
4578         * python/py-utils.c: Use C++ exception handling.
4579         * python/py-unwind.c: Use C++ exception handling.
4580         * python/py-type.c: Use C++ exception handling.
4581         * python/py-symbol.c: Use C++ exception handling.
4582         * python/py-record.c: Use C++ exception handling.
4583         * python/py-record-btrace.c: Use C++ exception handling.
4584         * python/py-progspace.c: Use C++ exception handling.
4585         * python/py-prettyprint.c: Use C++ exception handling.
4586         * python/py-param.c: Use C++ exception handling.
4587         * python/py-objfile.c: Use C++ exception handling.
4588         * python/py-linetable.c: Use C++ exception handling.
4589         * python/py-lazy-string.c: Use C++ exception handling.
4590         * python/py-infthread.c: Use C++ exception handling.
4591         * python/py-inferior.c: Use C++ exception handling.
4592         * python/py-gdb-readline.c: Use C++ exception handling.
4593         * python/py-framefilter.c: Use C++ exception handling.
4594         * python/py-frame.c: Use C++ exception handling.
4595         * python/py-finishbreakpoint.c: Use C++ exception handling.
4596         * python/py-cmd.c: Use C++ exception handling.
4597         * python/py-breakpoint.c: Use C++ exception handling.
4598         * python/py-arch.c: Use C++ exception handling.
4599         * printcmd.c: Use C++ exception handling.
4600         * ppc-linux-tdep.c: Use C++ exception handling.
4601         * parse.c: Use C++ exception handling.
4602         * p-valprint.c: Use C++ exception handling.
4603         * objc-lang.c: Use C++ exception handling.
4604         * mi/mi-main.c: Use C++ exception handling.
4605         * mi/mi-interp.c: Use C++ exception handling.
4606         * mi/mi-cmd-stack.c: Use C++ exception handling.
4607         * mi/mi-cmd-break.c: Use C++ exception handling.
4608         * main.c: Use C++ exception handling.
4609         * linux-thread-db.c: Use C++ exception handling.
4610         * linux-tdep.c: Use C++ exception handling.
4611         * linux-nat.c: Use C++ exception handling.
4612         * linux-fork.c: Use C++ exception handling.
4613         * linespec.c: Use C++ exception handling.
4614         * language.c: Use C++ exception handling.
4615         * jit.c: Use C++ exception handling.
4616         * infrun.c: Use C++ exception handling.
4617         * infcmd.c: Use C++ exception handling.
4618         * infcall.c: Use C++ exception handling.
4619         * inf-loop.c: Use C++ exception handling.
4620         * i386-tdep.c: Use C++ exception handling.
4621         * i386-linux-tdep.c: Use C++ exception handling.
4622         * guile/scm-value.c: Use C++ exception handling.
4623         * guile/scm-type.c: Use C++ exception handling.
4624         * guile/scm-symtab.c: Use C++ exception handling.
4625         * guile/scm-symbol.c: Use C++ exception handling.
4626         * guile/scm-pretty-print.c: Use C++ exception handling.
4627         * guile/scm-ports.c: Use C++ exception handling.
4628         * guile/scm-param.c: Use C++ exception handling.
4629         * guile/scm-math.c: Use C++ exception handling.
4630         * guile/scm-lazy-string.c: Use C++ exception handling.
4631         * guile/scm-frame.c: Use C++ exception handling.
4632         * guile/scm-disasm.c: Use C++ exception handling.
4633         * guile/scm-cmd.c: Use C++ exception handling.
4634         * guile/scm-breakpoint.c: Use C++ exception handling.
4635         * guile/scm-block.c: Use C++ exception handling.
4636         * guile/guile-internal.h: Use C++ exception handling.
4637         * gnu-v3-abi.c: Use C++ exception handling.
4638         * gdbtypes.c: Use C++ exception handling.
4639         * frame.c: Use C++ exception handling.
4640         * frame-unwind.c: Use C++ exception handling.
4641         * fbsd-tdep.c: Use C++ exception handling.
4642         * f-valprint.c: Use C++ exception handling.
4643         * exec.c: Use C++ exception handling.
4644         * event-top.c: Use C++ exception handling.
4645         * event-loop.c: Use C++ exception handling.
4646         * eval.c: Use C++ exception handling.
4647         * dwarf2read.c: Use C++ exception handling.
4648         * dwarf2loc.c: Use C++ exception handling.
4649         * dwarf2-frame.c: Use C++ exception handling.
4650         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4651         * dwarf-index-write.c: Use C++ exception handling.
4652         * dwarf-index-cache.c: Use C++ exception handling.
4653         * dtrace-probe.c: Use C++ exception handling.
4654         * disasm-selftests.c: Use C++ exception handling.
4655         * darwin-nat.c: Use C++ exception handling.
4656         * cp-valprint.c: Use C++ exception handling.
4657         * cp-support.c: Use C++ exception handling.
4658         * cp-abi.c: Use C++ exception handling.
4659         * corelow.c: Use C++ exception handling.
4660         * completer.c: Use C++ exception handling.
4661         * compile/compile-object-run.c: Use C++ exception handling.
4662         * compile/compile-object-load.c: Use C++ exception handling.
4663         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4664         * compile/compile-c-symbols.c: Use C++ exception handling.
4665         * common/selftest.c: Use C++ exception handling.
4666         * common/new-op.c: Use C++ exception handling.
4667         * cli/cli-script.c: Use C++ exception handling.
4668         * cli/cli-interp.c: Use C++ exception handling.
4669         * cli/cli-cmds.c: Use C++ exception handling.
4670         * c-varobj.c: Use C++ exception handling.
4671         * btrace.c: Use C++ exception handling.
4672         * breakpoint.c: Use C++ exception handling.
4673         * break-catch-throw.c: Use C++ exception handling.
4674         * arch-utils.c: Use C++ exception handling.
4675         * amd64-tdep.c: Use C++ exception handling.
4676         * ada-valprint.c: Use C++ exception handling.
4677         * ada-typeprint.c: Use C++ exception handling.
4678         * ada-lang.c: Use C++ exception handling.
4679         * aarch64-tdep.c: Use C++ exception handling.
4680
4681 2019-04-08  Tom Tromey  <tom@tromey.com>
4682
4683         * xml-support.c (gdb_xml_parser::parse): Update.
4684         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4685         * value.c (show_convenience): Update.
4686         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4687         (test_parse_flags_qcs): Update.
4688         * thread.c (thr_try_catch_cmd): Update.
4689         * target.c (target_translate_tls_address): Update.
4690         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4691         (info_frame_command_core, frame_apply_command_count): Update.
4692         * rust-exp.y (rust_lex_exception_test): Update.
4693         * riscv-tdep.c (riscv_print_one_register_info): Update.
4694         * remote.c (remote_target::enable_btrace): Update.
4695         * record-btrace.c (record_btrace_enable_warn): Update.
4696         * python/py-utils.c (gdbpy_convert_exception): Update.
4697         * printcmd.c (do_one_display, print_variable_and_value): Update.
4698         * mi/mi-main.c (mi_print_exception): Update.
4699         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4700         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4701         * linux-nat.c (linux_nat_target::attach): Update.
4702         * linux-fork.c (class scoped_switch_fork_info): Update.
4703         * infrun.c (displaced_step_prepare): Update.
4704         * infcall.c (call_function_by_hand_dummy): Update.
4705         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4706         * gnu-v3-abi.c (print_one_vtable): Update.
4707         * frame.c (get_prev_frame_always): Update.
4708         * f-valprint.c (info_common_command_for_block): Update.
4709         * exec.c (try_open_exec_file): Update.
4710         * exceptions.c (print_exception, exception_print)
4711         (exception_fprintf, exception_print_same): Update.
4712         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4713         * dwarf-index-cache.c (index_cache::store)
4714         (index_cache::lookup_gdb_index): Update.
4715         * darwin-nat.c (maybe_cache_shell): Update.
4716         * cp-valprint.c (cp_print_value_fields): Update.
4717         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4718         (gcc_cplus_symbol_address): Update.
4719         * compile/compile-c-symbols.c (gcc_convert_symbol)
4720         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4721         * common/selftest.c: Update.
4722         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4723         a std::string.
4724         (exception_try_scope_entry, exception_try_scope_exit): Don't
4725         declare.
4726         (struct exception_try_scope): Remove.
4727         (TRY): Don't use exception_try_scope.
4728         (struct gdb_exception): Add constructor, operator=.
4729         <what>: New method.
4730         (struct gdb_exception_RETURN_MASK_ALL)
4731         (struct gdb_exception_RETURN_MASK_ERROR)
4732         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4733         (struct gdb_quit_bad_alloc): Update.
4734         * common/common-exceptions.c (exception_none): Change
4735         initializer.
4736         (struct catcher) <state, exception>: Initialize inline.
4737         <prev>: Remove member.
4738         (current_catcher): Remove.
4739         (catchers): New global.
4740         (exceptions_state_mc_init): Simplify.
4741         (catcher_pop): Remove.
4742         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4743         (try_scope_depth, exception_try_scope_entry)
4744         (exception_try_scope_exit): Remove.
4745         (throw_exception_sjlj): Update.
4746         (exception_messages, exception_messages_size): Remove.
4747         (throw_it): Simplify.
4748         (gdb_exception_sliced_copy): Remove.
4749         (throw_exception_cxx): Update.
4750         * cli/cli-script.c (script_from_file): Update.
4751         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4752         Update.
4753         * ada-valprint.c (ada_val_print): Update.
4754         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4755         (create_excep_cond_exprs): Update.
4756
4757 2019-04-08  Tom Tromey  <tom@tromey.com>
4758
4759         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4760         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4761         (TRY, CATCH, END_CATCH): Remove some definitions.
4762         * common/common-exceptions.c: Don't use GDB_XCPT.
4763         (catcher_list_size): Remove.
4764         (throw_exception, throw_it): Simplify.
4765
4766 2019-04-05  Tom Tromey  <tom@tromey.com>
4767
4768         Revert the header-sorting patch.
4769         * ft32-tdep.c: Revert.
4770         * frv-tdep.c: Revert.
4771         * frv-linux-tdep.c: Revert.
4772         * frame.c: Revert.
4773         * frame-unwind.c: Revert.
4774         * frame-base.c: Revert.
4775         * fork-child.c: Revert.
4776         * findvar.c: Revert.
4777         * findcmd.c: Revert.
4778         * filesystem.c: Revert.
4779         * filename-seen-cache.h: Revert.
4780         * filename-seen-cache.c: Revert.
4781         * fbsd-tdep.c: Revert.
4782         * fbsd-nat.h: Revert.
4783         * fbsd-nat.c: Revert.
4784         * f-valprint.c: Revert.
4785         * f-typeprint.c: Revert.
4786         * f-lang.c: Revert.
4787         * extension.h: Revert.
4788         * extension.c: Revert.
4789         * extension-priv.h: Revert.
4790         * expprint.c: Revert.
4791         * exec.h: Revert.
4792         * exec.c: Revert.
4793         * exceptions.c: Revert.
4794         * event-top.c: Revert.
4795         * event-loop.c: Revert.
4796         * eval.c: Revert.
4797         * elfread.c: Revert.
4798         * dwarf2read.h: Revert.
4799         * dwarf2read.c: Revert.
4800         * dwarf2loc.c: Revert.
4801         * dwarf2expr.h: Revert.
4802         * dwarf2expr.c: Revert.
4803         * dwarf2-frame.c: Revert.
4804         * dwarf2-frame-tailcall.c: Revert.
4805         * dwarf-index-write.h: Revert.
4806         * dwarf-index-write.c: Revert.
4807         * dwarf-index-common.c: Revert.
4808         * dwarf-index-cache.h: Revert.
4809         * dwarf-index-cache.c: Revert.
4810         * dummy-frame.c: Revert.
4811         * dtrace-probe.c: Revert.
4812         * disasm.h: Revert.
4813         * disasm.c: Revert.
4814         * disasm-selftests.c: Revert.
4815         * dictionary.c: Revert.
4816         * dicos-tdep.c: Revert.
4817         * demangle.c: Revert.
4818         * dcache.h: Revert.
4819         * dcache.c: Revert.
4820         * darwin-nat.h: Revert.
4821         * darwin-nat.c: Revert.
4822         * darwin-nat-info.c: Revert.
4823         * d-valprint.c: Revert.
4824         * d-namespace.c: Revert.
4825         * d-lang.c: Revert.
4826         * ctf.c: Revert.
4827         * csky-tdep.c: Revert.
4828         * csky-linux-tdep.c: Revert.
4829         * cris-tdep.c: Revert.
4830         * cris-linux-tdep.c: Revert.
4831         * cp-valprint.c: Revert.
4832         * cp-support.c: Revert.
4833         * cp-namespace.c: Revert.
4834         * cp-abi.c: Revert.
4835         * corelow.c: Revert.
4836         * corefile.c: Revert.
4837         * continuations.c: Revert.
4838         * completer.h: Revert.
4839         * completer.c: Revert.
4840         * complaints.c: Revert.
4841         * coffread.c: Revert.
4842         * coff-pe-read.c: Revert.
4843         * cli-out.h: Revert.
4844         * cli-out.c: Revert.
4845         * charset.c: Revert.
4846         * c-varobj.c: Revert.
4847         * c-valprint.c: Revert.
4848         * c-typeprint.c: Revert.
4849         * c-lang.c: Revert.
4850         * buildsym.c: Revert.
4851         * buildsym-legacy.c: Revert.
4852         * build-id.h: Revert.
4853         * build-id.c: Revert.
4854         * btrace.c: Revert.
4855         * bsd-uthread.c: Revert.
4856         * breakpoint.h: Revert.
4857         * breakpoint.c: Revert.
4858         * break-catch-throw.c: Revert.
4859         * break-catch-syscall.c: Revert.
4860         * break-catch-sig.c: Revert.
4861         * blockframe.c: Revert.
4862         * block.c: Revert.
4863         * bfin-tdep.c: Revert.
4864         * bfin-linux-tdep.c: Revert.
4865         * bfd-target.c: Revert.
4866         * bcache.c: Revert.
4867         * ax-general.c: Revert.
4868         * ax-gdb.h: Revert.
4869         * ax-gdb.c: Revert.
4870         * avr-tdep.c: Revert.
4871         * auxv.c: Revert.
4872         * auto-load.c: Revert.
4873         * arm-wince-tdep.c: Revert.
4874         * arm-tdep.c: Revert.
4875         * arm-symbian-tdep.c: Revert.
4876         * arm-pikeos-tdep.c: Revert.
4877         * arm-obsd-tdep.c: Revert.
4878         * arm-nbsd-tdep.c: Revert.
4879         * arm-nbsd-nat.c: Revert.
4880         * arm-linux-tdep.c: Revert.
4881         * arm-linux-nat.c: Revert.
4882         * arm-fbsd-tdep.c: Revert.
4883         * arm-fbsd-nat.c: Revert.
4884         * arm-bsd-tdep.c: Revert.
4885         * arch-utils.c: Revert.
4886         * arc-tdep.c: Revert.
4887         * arc-newlib-tdep.c: Revert.
4888         * annotate.h: Revert.
4889         * annotate.c: Revert.
4890         * amd64-windows-tdep.c: Revert.
4891         * amd64-windows-nat.c: Revert.
4892         * amd64-tdep.c: Revert.
4893         * amd64-sol2-tdep.c: Revert.
4894         * amd64-obsd-tdep.c: Revert.
4895         * amd64-obsd-nat.c: Revert.
4896         * amd64-nbsd-tdep.c: Revert.
4897         * amd64-nbsd-nat.c: Revert.
4898         * amd64-nat.c: Revert.
4899         * amd64-linux-tdep.c: Revert.
4900         * amd64-linux-nat.c: Revert.
4901         * amd64-fbsd-tdep.c: Revert.
4902         * amd64-fbsd-nat.c: Revert.
4903         * amd64-dicos-tdep.c: Revert.
4904         * amd64-darwin-tdep.c: Revert.
4905         * amd64-bsd-nat.c: Revert.
4906         * alpha-tdep.c: Revert.
4907         * alpha-obsd-tdep.c: Revert.
4908         * alpha-nbsd-tdep.c: Revert.
4909         * alpha-mdebug-tdep.c: Revert.
4910         * alpha-linux-tdep.c: Revert.
4911         * alpha-linux-nat.c: Revert.
4912         * alpha-bsd-tdep.c: Revert.
4913         * alpha-bsd-nat.c: Revert.
4914         * aix-thread.c: Revert.
4915         * agent.c: Revert.
4916         * addrmap.c: Revert.
4917         * ada-varobj.c: Revert.
4918         * ada-valprint.c: Revert.
4919         * ada-typeprint.c: Revert.
4920         * ada-tasks.c: Revert.
4921         * ada-lang.c: Revert.
4922         * aarch64-tdep.c: Revert.
4923         * aarch64-ravenscar-thread.c: Revert.
4924         * aarch64-newlib-tdep.c: Revert.
4925         * aarch64-linux-tdep.c: Revert.
4926         * aarch64-linux-nat.c: Revert.
4927         * aarch64-fbsd-tdep.c: Revert.
4928         * aarch64-fbsd-nat.c: Revert.
4929         * aarch32-linux-nat.c: Revert.
4930
4931 2019-04-05  Tom Tromey  <tom@tromey.com>
4932
4933         * ft32-tdep.c: Sort headers.
4934         * frv-tdep.c: Sort headers.
4935         * frv-linux-tdep.c: Sort headers.
4936         * frame.c: Sort headers.
4937         * frame-unwind.c: Sort headers.
4938         * frame-base.c: Sort headers.
4939         * fork-child.c: Sort headers.
4940         * findvar.c: Sort headers.
4941         * findcmd.c: Sort headers.
4942         * filesystem.c: Sort headers.
4943         * filename-seen-cache.h: Sort headers.
4944         * filename-seen-cache.c: Sort headers.
4945         * fbsd-tdep.c: Sort headers.
4946         * fbsd-nat.h: Sort headers.
4947         * fbsd-nat.c: Sort headers.
4948         * f-valprint.c: Sort headers.
4949         * f-typeprint.c: Sort headers.
4950         * f-lang.c: Sort headers.
4951         * extension.h: Sort headers.
4952         * extension.c: Sort headers.
4953         * extension-priv.h: Sort headers.
4954         * expprint.c: Sort headers.
4955         * exec.h: Sort headers.
4956         * exec.c: Sort headers.
4957         * exceptions.c: Sort headers.
4958         * event-top.c: Sort headers.
4959         * event-loop.c: Sort headers.
4960         * eval.c: Sort headers.
4961         * elfread.c: Sort headers.
4962         * dwarf2read.h: Sort headers.
4963         * dwarf2read.c: Sort headers.
4964         * dwarf2loc.c: Sort headers.
4965         * dwarf2expr.h: Sort headers.
4966         * dwarf2expr.c: Sort headers.
4967         * dwarf2-frame.c: Sort headers.
4968         * dwarf2-frame-tailcall.c: Sort headers.
4969         * dwarf-index-write.h: Sort headers.
4970         * dwarf-index-write.c: Sort headers.
4971         * dwarf-index-common.c: Sort headers.
4972         * dwarf-index-cache.h: Sort headers.
4973         * dwarf-index-cache.c: Sort headers.
4974         * dummy-frame.c: Sort headers.
4975         * dtrace-probe.c: Sort headers.
4976         * disasm.h: Sort headers.
4977         * disasm.c: Sort headers.
4978         * disasm-selftests.c: Sort headers.
4979         * dictionary.c: Sort headers.
4980         * dicos-tdep.c: Sort headers.
4981         * demangle.c: Sort headers.
4982         * dcache.h: Sort headers.
4983         * dcache.c: Sort headers.
4984         * darwin-nat.h: Sort headers.
4985         * darwin-nat.c: Sort headers.
4986         * darwin-nat-info.c: Sort headers.
4987         * d-valprint.c: Sort headers.
4988         * d-namespace.c: Sort headers.
4989         * d-lang.c: Sort headers.
4990         * ctf.c: Sort headers.
4991         * csky-tdep.c: Sort headers.
4992         * csky-linux-tdep.c: Sort headers.
4993         * cris-tdep.c: Sort headers.
4994         * cris-linux-tdep.c: Sort headers.
4995         * cp-valprint.c: Sort headers.
4996         * cp-support.c: Sort headers.
4997         * cp-namespace.c: Sort headers.
4998         * cp-abi.c: Sort headers.
4999         * corelow.c: Sort headers.
5000         * corefile.c: Sort headers.
5001         * continuations.c: Sort headers.
5002         * completer.h: Sort headers.
5003         * completer.c: Sort headers.
5004         * complaints.c: Sort headers.
5005         * coffread.c: Sort headers.
5006         * coff-pe-read.c: Sort headers.
5007         * cli-out.h: Sort headers.
5008         * cli-out.c: Sort headers.
5009         * charset.c: Sort headers.
5010         * c-varobj.c: Sort headers.
5011         * c-valprint.c: Sort headers.
5012         * c-typeprint.c: Sort headers.
5013         * c-lang.c: Sort headers.
5014         * buildsym.c: Sort headers.
5015         * buildsym-legacy.c: Sort headers.
5016         * build-id.h: Sort headers.
5017         * build-id.c: Sort headers.
5018         * btrace.c: Sort headers.
5019         * bsd-uthread.c: Sort headers.
5020         * breakpoint.h: Sort headers.
5021         * breakpoint.c: Sort headers.
5022         * break-catch-throw.c: Sort headers.
5023         * break-catch-syscall.c: Sort headers.
5024         * break-catch-sig.c: Sort headers.
5025         * blockframe.c: Sort headers.
5026         * block.c: Sort headers.
5027         * bfin-tdep.c: Sort headers.
5028         * bfin-linux-tdep.c: Sort headers.
5029         * bfd-target.c: Sort headers.
5030         * bcache.c: Sort headers.
5031         * ax-general.c: Sort headers.
5032         * ax-gdb.h: Sort headers.
5033         * ax-gdb.c: Sort headers.
5034         * avr-tdep.c: Sort headers.
5035         * auxv.c: Sort headers.
5036         * auto-load.c: Sort headers.
5037         * arm-wince-tdep.c: Sort headers.
5038         * arm-tdep.c: Sort headers.
5039         * arm-symbian-tdep.c: Sort headers.
5040         * arm-pikeos-tdep.c: Sort headers.
5041         * arm-obsd-tdep.c: Sort headers.
5042         * arm-nbsd-tdep.c: Sort headers.
5043         * arm-nbsd-nat.c: Sort headers.
5044         * arm-linux-tdep.c: Sort headers.
5045         * arm-linux-nat.c: Sort headers.
5046         * arm-fbsd-tdep.c: Sort headers.
5047         * arm-fbsd-nat.c: Sort headers.
5048         * arm-bsd-tdep.c: Sort headers.
5049         * arch-utils.c: Sort headers.
5050         * arc-tdep.c: Sort headers.
5051         * arc-newlib-tdep.c: Sort headers.
5052         * annotate.h: Sort headers.
5053         * annotate.c: Sort headers.
5054         * amd64-windows-tdep.c: Sort headers.
5055         * amd64-windows-nat.c: Sort headers.
5056         * amd64-tdep.c: Sort headers.
5057         * amd64-sol2-tdep.c: Sort headers.
5058         * amd64-obsd-tdep.c: Sort headers.
5059         * amd64-obsd-nat.c: Sort headers.
5060         * amd64-nbsd-tdep.c: Sort headers.
5061         * amd64-nbsd-nat.c: Sort headers.
5062         * amd64-nat.c: Sort headers.
5063         * amd64-linux-tdep.c: Sort headers.
5064         * amd64-linux-nat.c: Sort headers.
5065         * amd64-fbsd-tdep.c: Sort headers.
5066         * amd64-fbsd-nat.c: Sort headers.
5067         * amd64-dicos-tdep.c: Sort headers.
5068         * amd64-darwin-tdep.c: Sort headers.
5069         * amd64-bsd-nat.c: Sort headers.
5070         * alpha-tdep.c: Sort headers.
5071         * alpha-obsd-tdep.c: Sort headers.
5072         * alpha-nbsd-tdep.c: Sort headers.
5073         * alpha-mdebug-tdep.c: Sort headers.
5074         * alpha-linux-tdep.c: Sort headers.
5075         * alpha-linux-nat.c: Sort headers.
5076         * alpha-bsd-tdep.c: Sort headers.
5077         * alpha-bsd-nat.c: Sort headers.
5078         * aix-thread.c: Sort headers.
5079         * agent.c: Sort headers.
5080         * addrmap.c: Sort headers.
5081         * ada-varobj.c: Sort headers.
5082         * ada-valprint.c: Sort headers.
5083         * ada-typeprint.c: Sort headers.
5084         * ada-tasks.c: Sort headers.
5085         * ada-lang.c: Sort headers.
5086         * aarch64-tdep.c: Sort headers.
5087         * aarch64-ravenscar-thread.c: Sort headers.
5088         * aarch64-newlib-tdep.c: Sort headers.
5089         * aarch64-linux-tdep.c: Sort headers.
5090         * aarch64-linux-nat.c: Sort headers.
5091         * aarch64-fbsd-tdep.c: Sort headers.
5092         * aarch64-fbsd-nat.c: Sort headers.
5093         * aarch32-linux-nat.c: Sort headers.
5094
5095 2019-04-04  Tom Tromey  <tom@tromey.com>
5096
5097         * varobj.c (varobj_create): Update.
5098         * rust-exp.y (struct rust_parser) <update_innermost_block,
5099         lookup_symbol>: New methods.
5100         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5101         Rename.
5102         (rust_parser::rust_lookup_type)
5103         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5104         * printcmd.c (display_command, do_one_display): Update.
5105         * parser-defs.h (struct parser_state) <parser_state>: Add
5106         "tracker" parameter.
5107         (block_tracker): New member.
5108         (class innermost_block_tracker) <innermost_block_tracker>: Add
5109         "types" parameter.
5110         <reset>: Remove method.
5111         (innermost_block): Don't declare.
5112         (null_post_parser): Update.
5113         * parse.c (innermost_block): Remove global.
5114         (write_dollar_variable): Update.
5115         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5116         Remove "tracker_types" parameter.
5117         (parse_expression): Add "tracker" parameter.
5118         (parse_expression_for_completion): Update.
5119         (null_post_parser): Add "tracker" parameter.
5120         * p-exp.y: Update rules.
5121         * m2-exp.y: Update rules.
5122         * language.h (struct language_defn) <la_post_parser>: Add
5123         "tracker" parameter.
5124         * go-exp.y: Update rules.
5125         * f-exp.y: Update rules.
5126         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5127         parameter.
5128         * d-exp.y: Update rules.
5129         * c-exp.y: Update rules.
5130         * breakpoint.c (set_breakpoint_condition): Create an
5131         innermost_block_tracker.
5132         (watch_command_1): Likewise.
5133         * ada-lang.c (resolve): Add "tracker" parameter.
5134         (resolve_subexp): Likewise.
5135         * ada-exp.y (write_var_from_sym): Update.
5136
5137 2019-04-04  Tom Tromey  <tom@tromey.com>
5138
5139         * type-stack.h: New file.
5140         * type-stack.c: New file.
5141         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5142         type-stack.h.
5143         (insert_into_type_stack, insert_type, push_type, push_type_int)
5144         (insert_type_address_space, pop_type, pop_type_int)
5145         (pop_typelist, pop_type_stack, append_type_stack)
5146         (push_type_stack, get_type_stack, push_typelist)
5147         (follow_type_instance_flags, follow_types): Don't declare.
5148         * parse.c (type_stack): Remove global.
5149         (parse_exp_in_context): Update.
5150         (insert_into_type_stack, insert_type, push_type, push_type_int)
5151         (insert_type_address_space, pop_type, pop_type_int)
5152         (pop_typelist, pop_type_stack, append_type_stack)
5153         (push_type_stack, get_type_stack, push_typelist)
5154         (follow_type_instance_flags, follow_types): Remove (moved to
5155         type-stack.c).
5156         * f-exp.y (type_stack): New global.
5157         Update rules.
5158         (push_kind_type, f_parse): Update.
5159         * d-exp.y (type_stack): New global.
5160         Update rules.
5161         (d_parse): Update.
5162         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5163         Update rules.
5164         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5165         (HFILES_NO_SRCDIR): Add type-stack.h.
5166
5167 2019-04-04  Tom Tromey  <tom@tromey.com>
5168
5169         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5170         (rust_parser::convert_ast_to_expression, rust_parse)
5171         (rust_lex_test_completion, rust_lex_tests): Update.
5172         * parser-defs.h (struct expr_completion_state): New.
5173         (struct parser_state) <parser_state>: Add completion parameter.
5174         <mark_struct_expression, mark_completion_tag>: New methods.
5175         <parse_completion, m_completion_state>: New members.
5176         (prefixify_expression, null_post_parser): Update.
5177         (mark_struct_expression, mark_completion_tag): Don't declare.
5178         * parse.c (parse_completion, expout_last_struct)
5179         (expout_tag_completion_type, expout_completion_name): Remove
5180         globals.
5181         (parser_state::mark_struct_expression)
5182         (parser_state::mark_completion_tag): Now methods.
5183         (prefixify_expression): Add last_struct parameter.
5184         (prefixify_subexp): Likewise.
5185         (parse_exp_1): Update.
5186         (parse_exp_in_context): Add cstate parameter.  Update.
5187         (parse_expression_for_completion): Create an
5188         expr_completion_state.
5189         (null_post_parser): Add "completion" parameter.
5190         * p-exp.y: Update rules.
5191         (yylex): Update.
5192         * language.h (struct language_defn) <la_post_parser>: Add
5193         "completing" parameter.
5194         * go-exp.y: Update rules.
5195         (lex_one_token): Update.
5196         * expression.h (parse_completion): Don't declare.
5197         * d-exp.y: Update rules.
5198         (lex_one_token): Update rules.
5199         * c-exp.y: Update rules.
5200         (lex_one_token): Update.
5201         * ada-lang.c (resolve): Add "parse_completion" parameter.
5202         (resolve_subexp): Likewise.
5203         (ada_resolve_function): Likewise.
5204
5205 2019-04-04  Tom Tromey  <tom@tromey.com>
5206
5207         * parser-defs.h (struct parser_state) <start_arglist,
5208         end_arglist>: New methods.
5209         <arglist_len, m_funcall_chain>: New members.
5210         (arglist_len, start_arglist, end_arglist): Don't declare.
5211         * parse.c (arglist_len, funcall_chain): Remove global.
5212         (start_arglist, end_arglist): Remove functions.
5213         (parse_exp_in_context): Update.
5214         * p-exp.y: Update rules.
5215         * m2-exp.y: Update rules.
5216         * go-exp.y: Update rules.
5217         * f-exp.y: Update rules.
5218         * d-exp.y: Update rules.
5219         * c-exp.y: Update rules.
5220
5221 2019-04-04  Tom Tromey  <tom@tromey.com>
5222
5223         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5224         lex_operator, push_back>: New methods.
5225         Update all rules.
5226         (rust_parser::lex_hex, lex_escape): Rename and update.
5227         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5228         (rust_parser::lex_operator): Rename and update.
5229         (rust_parser::lex_number, rustyylex, rustyyerror)
5230         (rust_lex_test_init, rust_lex_test_sequence)
5231         (rust_lex_test_push_back, rust_lex_tests): Update.
5232         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5233         parameter.
5234         <lexptr, prev_lexptr>: New members.
5235         (lexptr, prev_lexptr): Don't declare.
5236         * parse.c (lexptr, prev_lexptr): Remove globals.
5237         (parse_exp_in_context): Update.
5238         * p-exp.y (yylex, yyerror): Update.
5239         * m2-exp.y (parse_number, yylex, yyerror): Update.
5240         * go-exp.y (lex_one_token, yyerror): Update.
5241         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5242         * d-exp.y (lex_one_token, yyerror): Update.
5243         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5244         (lex_one_token, yyerror): Update.
5245         * ada-lex.l (YY_INPUT): Update.
5246         (rewind_to_char): Update.
5247         * ada-exp.y (yyerror): Update.
5248
5249 2019-04-04  Tom Tromey  <tom@tromey.com>
5250
5251         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5252         * parser-defs.h (struct parser_state) <parser_state>: Add new
5253         parameter.
5254         <comma_terminates>: New member.
5255         (comma_terminates): Don't declare global.
5256         * parse.c (comma_terminates): Remove global.
5257         (parse_exp_in_context): Update.
5258         * p-exp.y (yylex): Update.
5259         * m2-exp.y (yylex): Update.
5260         * go-exp.y (lex_one_token): Update.
5261         * f-exp.y (yylex): Update.
5262         * d-exp.y (lex_one_token): Update.
5263         * c-exp.y (lex_one_token): Update.
5264         * ada-lex.l: Update.
5265
5266 2019-04-04  Tom Tromey  <tom@tromey.com>
5267
5268         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5269         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5270         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5271         * parser-defs.h (paren_depth): Don't declare.
5272         * parse.c (paren_depth): Remove global.
5273         (parse_exp_in_context): Update.
5274         * p-exp.y (paren_depth): New global.
5275         (pascal_parse): Initialize it.
5276         * m2-exp.y (paren_depth): New global.
5277         (m2_parse): Initialize it.
5278         * go-exp.y (paren_depth): New global.
5279         (go_parse): Initialize it.
5280         * f-exp.y (paren_depth): New global.
5281         (f_parse): Initialize it.
5282         * d-exp.y (paren_depth): New global.
5283         (d_parse): Initialize it.
5284         * c-exp.y (paren_depth): New global.
5285         (c_parse): Initialize it.
5286         * ada-lex.l (paren_depth): New global.
5287         (lexer_init): Initialize it.
5288
5289 2019-04-04  Tom Tromey  <tom@tromey.com>
5290
5291         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5292         (rust_parser::convert_ast_to_type)
5293         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5294         * parser-defs.h (struct parser_state) <parser_state>: Add
5295         parameters.  Initialize new members.
5296         <expression_context_block, expression_context_pc>: New members.
5297         * parse.c (expression_context_block, expression_context_pc):
5298         Remove globals.
5299         (parse_exp_in_context): Update.
5300         * p-exp.y: Update all rules.
5301         (yylex): Update.
5302         * m2-exp.y: Update all rules.
5303         (yylex): Update.
5304         * go-exp.y (yylex): Update.
5305         * f-exp.y (yylex): Update.
5306         * d-exp.y: Update all rules.
5307         (yylex): Update.
5308         * c-exp.y: Update all rules.
5309         (lex_one_token, classify_name, yylex, c_parse): Update.
5310         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5311
5312 2019-04-04  Tom Tromey  <tom@tromey.com>
5313
5314         * gdbarch.h, gdbarch.c: Rebuild.
5315         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5316         * stap-probe.h:
5317         (struct stap_parse_info): Replace "parser_state" with
5318         "expr_builder".
5319         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5320         (parser_state): New class.
5321         * parse.c (expr_builder): Rename.
5322         (expr_builder::release): Rename.
5323         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5324         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5325         (write_exp_elt_longcst, write_exp_elt_floatcst)
5326         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5327         (write_exp_string_vector, write_exp_bitstring)
5328         (write_exp_msymbol, mark_struct_expression)
5329         (write_dollar_variable)
5330         (insert_type_address_space, increase_expout_size): Replace
5331         "parser_state" with "expr_builder".
5332         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5333         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5334         "parser_state" with "expr_builder".
5335
5336 2019-04-04  Tom Tromey  <tom@tromey.com>
5337
5338         * rust-exp.y: Replace "parse_language" with method call.
5339         * p-exp.y:
5340         (yylex): Replace "parse_language" with method call.
5341         * m2-exp.y:
5342         (yylex): Replace "parse_language" with method call.
5343         * go-exp.y (classify_name): Replace "parse_language" with method
5344         call.
5345         * f-exp.y (yylex): Replace "parse_language" with method call.
5346         * d-exp.y (lex_one_token): Replace "parse_language" with method
5347         call.
5348         * c-exp.y:
5349         (lex_one_token, classify_name, yylex): Replace "parse_language"
5350         with method call.
5351         * ada-exp.y (find_primitive_type, type_char)
5352         (type_system_address): Replace "parse_language" with method call.
5353
5354 2019-04-04  Tom Tromey  <tom@tromey.com>
5355
5356         * rust-exp.y: Replace "parse_gdbarch" with method call.
5357         * parse.c (write_dollar_variable, insert_type_address_space):
5358         Replace "parse_gdbarch" with method call.
5359         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5360         call.
5361         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5362         call.
5363         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5364         "parse_gdbarch" with method call.
5365         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5366         with method call.
5367         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5368         "parse_gdbarch" with method call.
5369         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5370         "parse_gdbarch" with method call.
5371         * c-exp.y (parse_type, parse_number, classify_name): Replace
5372         "parse_gdbarch" with method call.
5373         * ada-lex.l: Replace "parse_gdbarch" with method call.
5374         * ada-exp.y (parse_type, find_primitive_type, type_char)
5375         (type_system_address): Replace "parse_gdbarch" with method call.
5376
5377 2019-04-04  Tom Tromey  <tom@tromey.com>
5378
5379         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5380         * stap-probe.c (stap_parse_argument): Update.
5381         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5382         initial_size parameter.
5383         * rust-exp.y (rust_lex_tests): Update.
5384         * parse.c (parser_state): Update.
5385         (parse_exp_in_context): Update.
5386         * parser-defs.h (struct parser_state) <parser_state>: Remove
5387         "initial_size" parameter.
5388
5389 2019-04-04  Tom Tromey  <tom@tromey.com>
5390
5391         * parser-defs.h (increase_expout_size): Don't declare.
5392         * parse.c (increase_expout_size): Now static.
5393
5394 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5395
5396         * gnu-nat.c (gnu_nat_target::wait): Fix
5397         target_waitstatus_to_string call.
5398
5399 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * eval.c (evaluate_subexp_standard): Handle internal functions
5402         during Fortran function call handling.
5403
5404 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5405
5406         * NEWS: Mention new internal functions.
5407         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5408         (read_base_type): Use dwarf2_init_complex_target_type.
5409         * value.c (creal_internal_fn): New function.
5410         (cimag_internal_fn): New function.
5411         (_initialize_values): Register new internal functions.
5412
5413 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5414
5415         * infrun.c (stop_all_threads): If debug_infrun, always
5416         trace the wait status after wait_one, using
5417         target_waitstatus_to_string and target_pid_to_str.
5418         (handle_inferior_event): Replace various trace of
5419         wait status kind by a single trace.
5420         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5421         wait status kind image by target_waitstatus_to_string.
5422         * target/waitstatus.c (target_waitstatus_to_string): Fix
5423         obsolete comment.
5424
5425 2019-04-01  Tom Tromey  <tromey@adacore.com>
5426
5427         PR symtab/23331:
5428         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5429
5430 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5431             Pedro Alves  <palves@redhat.com>
5432
5433         * top.c (quit_force): Call 'finalize_values'.
5434         * value.c (finalize_values): New function.
5435         * value.h (finalize_values): Declare.
5436
5437 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5438
5439         * NEWS: Announce $_gdb_major and $_gdb_minor.
5440
5441         * top.c (init_gdb_version_vars): New function.
5442         (gdb_init): Call init_gdb_version_vars.
5443
5444 2019-03-29  Tom Tromey  <tromey@adacore.com>
5445
5446         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5447         help text.  Remove dead code.
5448
5449 2019-03-29  Keith Seitz  <keiths@redhat.com>
5450
5451         From Siddhesh Poyarekar:
5452         * f-lang.h (f77_get_upperbound): Return LONGEST.
5453         (f77_get_lowerbound): Likewise.
5454         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5455         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5456         print them.
5457         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5458         plongest to format print it.
5459         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5460         (f77_get_upperbound): Likewise.
5461         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5462         LOWER_BOUND to LONGEST.
5463         (f77_create_arrayprint_offset_tbl): Likewise.
5464
5465 2019-03-29  Keith Seitz  <keiths@redhat.com>
5466
5467         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5468         %s/pulongest for TYPE_LENGTH instead of %d in format
5469         strings.
5470         * ada-typerint.c (ada_print_type): Likewise.
5471         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5472         * compile/compile-c-support.c (generate_register_struct): Likewise.
5473         * gdbtypes.c (recursive_dump_type): Likewise.
5474         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5475         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5476         instead of %d in format strings.
5477         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5478         to std::min to ULONGEST.
5479         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5480         instead of %d in format strings.
5481         * tracepoint.c (info_scope_command): Likewise.
5482         * typeprint.c (print_offset_data::update)
5483         (print_offset_data::finish): Likewise.
5484         * xtensa-tdep.c (xtensa_store_return_value)
5485         (xtensa_push_dummy_call): Likewise.
5486
5487 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5488
5489         * windows-nat.c (display_selector): Fixed format specifications
5490         for 64-bit Cygwin.
5491
5492 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5493
5494         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5495
5496 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5497
5498         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5499         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5500         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5501         (nios2_linux_init_abi): Install it.
5502
5503 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5504
5505         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5506
5507 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5508
5509         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5510
5511 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5512             Tom Tromey  <tromey@adacore.com>
5513
5514         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5515
5516 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5517
5518         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5519         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5520         method to compute the bounds of range types. Also print "[evaluated]"
5521         if the bounds' values come from a dynamic evaluation.
5522
5523 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5524
5525         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5526         whitespace when pretty printing is on.
5527
5528 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5529
5530         * ppc-linux-nat.c: Add include.
5531
5532 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5533
5534         * NEWS: Mention AArch64 Pointer Authentication.
5535
5536 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5537
5538         * arm-linux-nat.c: Add include.
5539
5540 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5541
5542         * source-cache.c (source_cache::get_source_lines): Re-read
5543         fullname after calling open_source_file.
5544
5545 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5546
5547         * NEWS: Mention TLS support for FreeBSD.
5548
5549 2019-03-25  Tom Tromey  <tromey@adacore.com>
5550
5551         * minsyms.c (BUNCH_SIZE): Update comment.
5552         (~minimal_symbol_reader): Remove old comment.
5553         (compact_minimal_symbols): Update comment.
5554         (minimal_symbol_reader::install): Remove old comment.  Update
5555         other comments.
5556
5557 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5558
5559         * s390-linux-nat.c: Add include.
5560
5561 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5562
5563         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5564         Call linux_get_hwcap.
5565         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5566         Likewise.
5567         (aarch64_linux_get_hwcap): Remove function.
5568         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5569         declaration.
5570         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5571         linux_get_hwcap.
5572         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5573         * linux-tdep.c (linux_get_hwcap): Add function.
5574         (linux_get_hwcap2): Likewise.
5575         * linux-tdep.h (linux_get_hwcap): Add declaration.
5576         (linux_get_hwcap2): Likewise.
5577         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5578         (ppc_linux_get_hwcap2): Likewise.
5579         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5580         linux_get_hwcap.
5581         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5582         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5583         (ppc_linux_nat_target::read_description): Likewise.
5584         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5585         * s390-linux-nat.c: Likewise.
5586         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5587
5588 2019-03-24  Tom Tromey  <tom@tromey.com>
5589
5590         * ada-lang.c (standard_lookup): Simplify initialization.
5591         (ada_lookup_symbol_nonlocal): Simplify return.
5592         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5593         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5594         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5595         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5596         initialization.
5597         * solib.c (solib_global_lookup): Simplify.
5598         * symtab.c (null_block_symbol): Remove.
5599         (symbol_cache_lookup): Simplify returns.
5600         (lookup_language_this): Simplify returns.
5601         (lookup_symbol_aux): Simplify return.
5602         (lookup_local_symbol): Simplify returns.
5603         (lookup_global_symbol_from_objfile): Simplify return.
5604         (lookup_symbol_in_objfile_symtabs)
5605         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5606         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5607         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5608         * cp-namespace.c (cp_lookup_bare_symbol)
5609         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5610         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5611         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5612         (cp_lookup_symbol_via_imports): Simplify initialization.
5613         (find_symbol_in_baseclass): Likewise.
5614         * symtab.h (null_block_symbol): Remove.
5615         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5616         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5617         (d_lookup_symbol_module): Likewise.
5618         (find_symbol_in_baseclass): Simplify initialization.
5619
5620 2019-03-24  Tom Tromey  <tom@tromey.com>
5621
5622         * expression.h: Don't include symtab.h.
5623         (struct block): Forward declare.
5624
5625 2019-03-24  Tom Tromey  <tom@tromey.com>
5626
5627         * c-exp.y (typebase): Remove casts.
5628         * gdbtypes.c (lookup_unsigned_typename, )
5629         (lookup_signed_typename): Remove cast.
5630         * eval.c (parse_to_comma_and_eval): Remove cast.
5631         * parse.c (write_dollar_variable): Remove cast.
5632         * block.h (struct block) <superblock>: Now const.
5633         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5634         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5635         (map_block): Make "block" const.
5636         * symfile.h (struct quick_symbol_functions)
5637         <map_matching_symbols>: Constify block argument to "callback".
5638         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5639         const.
5640         (find_pc_sect_compunit_symtab): Make "b" const.
5641         (find_symbol_at_address): Likewise.
5642         (search_symbols): Likewise.
5643         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5644         (dw2_debug_names_lookup_symbol): Likewise.
5645         (dw2_map_matching_symbols): Update.
5646         * p-valprint.c (pascal_val_print): Remove "block".
5647         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5648         (aux_add_nonlocal_symbols): Make "block" const.
5649         (resolve_subexp): Remove cast.
5650         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5651         const.
5652         (iterate_over_file_blocks): Likewise.
5653         * f-exp.y (%union) <bval>: Remove.
5654         * coffread.c (patch_opaque_types): Make "b" const.
5655         * spu-tdep.c (spu_catch_start): Make "block" const.
5656         * c-valprint.c (print_unpacked_pointer): Remove "block".
5657         * symmisc.c (dump_symtab_1): Make "b" const.
5658         (block_depth): Make "block" const.
5659         * d-exp.y (%union) <bval>: Remove.
5660         * cp-support.h (cp_lookup_rtti_type): Update.
5661         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5662         * psymtab.c (psym_lookup_symbol): Make "block" const.
5663         (maintenance_check_psymtabs): Make "b" const.
5664         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5665         (enumerate_locals, enumerate_args): Update.
5666         * python/py-symtab.c (stpy_global_block): Make "block" const.
5667         (stpy_static_block): Likewise.
5668         * inline-frame.c (block_starting_point_at): Make "new_block"
5669         const.
5670         * block.c (find_block_in_blockvector): Make return type const.
5671         (blockvector_for_pc_sect): Make "b" const.
5672         (find_block_in_blockvector): Make "b" const.
5673
5674 2019-03-23  Tom Tromey  <tom@tromey.com>
5675
5676         * varobj.c (varobj_create): Update.
5677         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5678         * printcmd.c (display_command, do_one_display): Don't reset
5679         innermost_block.
5680         * parser-defs.h (enum innermost_block_tracker_type): Move to
5681         expression.h.
5682         (innermost_block): Update comment.
5683         * parse.c (parse_exp_1): Add tracker_types parameter.
5684         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5685         tracker_types parameter.  Reset innermost_block.
5686         (parse_exp_in_context): Remove.
5687         (parse_expression_for_completion): Update.
5688         * objfiles.c (~objfile): Don't reset expression_context_block or
5689         innermost_block.
5690         * expression.h (enum innermost_block_tracker_type): Move from
5691         parser-defs.h.
5692         (parse_exp_1): Add tracker_types parameter.
5693         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5694         reset innermost_block.
5695
5696 2019-03-23  Tom Tromey  <tom@tromey.com>
5697
5698         * objfiles.h: Include bcache.h.
5699
5700 2019-03-23  Tom Tromey  <tom@tromey.com>
5701
5702         * linespec.c (get_current_search_block): Use
5703         scoped_restore_current_language.
5704         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5705
5706 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5707             Jiong Wang  <jiong.wang@arm.com>
5708
5709         * aarch64-linux-tdep.c
5710         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5711         section.
5712         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5713
5714 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5715             Jiong Wang  <jiong.wang@arm.com>
5716
5717         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5718         instructions.
5719         (aarch64_analyze_prologue_test): Add PACIASP test.
5720         (aarch64_prologue_prev_register): Unmask PC value.
5721
5722 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5723             Jiong Wang  <jiong.wang@arm.com>
5724
5725         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5726         (aarch64_dwarf2_prev_register): Unmask PC value.
5727         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5728         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5729         DW_CFA_AARCH64_negate_ra_state.
5730         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5731
5732 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5733             Jiong Wang  <jiong.wang@arm.com>
5734
5735         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5736         registers.
5737         (aarch64_pseudo_register_name): Likewise.
5738         (aarch64_pseudo_register_type): Likewise.
5739         (aarch64_pseudo_register_reggroup_p): Likewise.
5740         (aarch64_gdbarch_init): Add pauth registers.
5741         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5742         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5743         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5744         (struct gdbarch_tdep): Add regnum for ra_state.
5745
5746 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5747             Jiong Wang  <jiong.wang@arm.com>
5748
5749         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5750
5751 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5752             Jiong Wang  <jiong.wang@arm.com>
5753
5754         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5755         function.
5756         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5757         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5758         (aarch64_gdbarch_init): Add puth registers.
5759         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5760         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5761         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5762
5763 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5764             Jiong Wang  <jiong.wang@arm.com>
5765
5766         * aarch64-linux-nat.c
5767         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5768         * aarch64-linux-tdep.c
5769         (aarch64_linux_core_read_description): Likewise.
5770         (aarch64_linux_get_hwcap): New function.
5771         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5772         (aarch64_linux_get_hwcap): New declaration.
5773
5774 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5775             Jiong Wang  <jiong.wang@arm.com>
5776
5777         * aarch64-linux-nat.c
5778         (aarch64_linux_nat_target::read_description): Add pauth param.
5779         * aarch64-linux-tdep.c
5780         (aarch64_linux_core_read_description): Likewise.
5781         * aarch64-tdep.c (struct target_desc): Add in pauth.
5782         (aarch64_read_description): Add pauth param.
5783         (aarch64_gdbarch_init): Likewise.
5784         * aarch64-tdep.h (aarch64_read_description): Likewise.
5785         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5786         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5787         * features/Makefile: Add new files.
5788         * features/aarch64-pauth.c: New file.
5789         * features/aarch64-pauth.xml: New file.
5790
5791 2019-03-20  Tom Tromey  <tromey@adacore.com>
5792
5793         * infrun.c (handle_inferior_event): Rename from
5794         handle_inferior_event_1.  Create a scoped_value_mark.
5795         (handle_inferior_event): Remove.
5796
5797 2019-03-19  Tom Tromey  <tromey@adacore.com>
5798
5799         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5800         * infrun.h (print_stop_event): Add "displays" parameter.
5801         * infrun.c (print_stop_event): Add "displays" parameter.
5802
5803 2019-03-19  Pedro Alves  <palves@redhat.com>
5804
5805         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5806         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5807         to -1.  Fix TABs vs spaces.
5808         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5809         * tui/tui-out.h (tui_ui_out) Add intro comments.
5810         <m_line, m_start_of_line>: In-class initialize, and add describing
5811         comment.
5812
5813 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5814
5815         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5816         variable names.
5817         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5818
5819 2019-03-18  Pedro Alves  <palves@redhat.com>
5820             Eli Zaretskii <eliz@gnu.org>
5821
5822         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5823         m_line and m_start_of_line.
5824
5825 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5826
5827         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5828         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5829         it returns a newline.  This fixes a regression in TU mode, whereby
5830         the next line is output on the same screen line as the user input.
5831
5832 2019-03-18  Tom Tromey  <tromey@adacore.com>
5833
5834         * minsyms.c (minimal_symbol_reader::install): Remove call to
5835         obstack_blank.
5836
5837 2019-03-18  Pedro Alves  <palves@redhat.com>
5838
5839         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5840         New globals.
5841         (apply_style): New, factored out from ...
5842         (apply_ansi_escape): ... this.  Handle reverse video mode.
5843         (tui_set_reverse_mode): New function.
5844         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5845         * tui/tui-winsource.c (tui_show_source_line): Use
5846         tui_set_reverse_mode instead of setting A_STANDOUT.
5847         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5848         New setter methods.
5849
5850 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5851
5852         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5853         Handle tabs.
5854
5855 2019-03-18  Tom Tromey  <tromey@adacore.com>
5856
5857         * ada-lang.c (empty_array): Add "high" parameter.
5858         (ada_evaluate_subexp): Update.
5859
5860 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5861
5862         * unittests/string_view-selftests.c: Define
5863         _initialize_string_view_selftests unconditionally.
5864
5865 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5866
5867         PR gdb/24350
5868         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5869
5870 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5871
5872         PR gdb/24351
5873         * windows-nat.c (display_selector): Fix format specifiers.
5874
5875 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5876
5877         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5878         tui_refill_source_window instead of tui_refresh_win, to update the
5879         current execution line.  This fixes redisplay of the current line
5880         when stepping through the code with "next" or "step".
5881
5882 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5883
5884         * source-cache.c (source_cache::get_source_lines): Call
5885         find_source_lines to initialize s->nlines.  This fixes vertical
5886         scrolling of TUI source window when the DOWN arrow is pressed.
5887
5888 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5889
5890         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5891         linux-thread-db.c (_initialize_thread_db): Likewise.
5892
5893 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5894
5895         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5896         wclrtoeol in tui_show_source_line".  This reverts changes made in
5897         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5898
5899 2019-03-15  Tom Tromey  <tom@tromey.com>
5900
5901         * symtab.h (struct minimal_symbol): Derive from
5902         general_symbol_info.
5903         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5904         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5905         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5906         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5907         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5908         (MSYMBOL_SEARCH_NAME): Update.
5909         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5910         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5911         * minsyms.c (minimal_symbol_reader::record_full): Update.
5912
5913 2019-03-15  Tom Tromey  <tom@tromey.com>
5914
5915         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5916
5917 2019-03-15  Tom Tromey  <tom@tromey.com>
5918
5919         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5920         unique_xmalloc_ptr.
5921         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5922         Update.
5923         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5924         (build_minimal_symbol_hash_tables)
5925         (minimal_symbol_reader::install): Update.
5926
5927 2019-03-15  Tom Tromey  <tom@tromey.com>
5928
5929         * symtab.c (create_demangled_names_hash): Update.
5930         (symbol_set_names): Update.
5931         * objfiles.h (struct objfile_per_bfd_storage)
5932         <demangled_names_hash>: Now an htab_up.
5933         * objfiles.c (objfile_per_bfd_storage): Simplify.
5934
5935 2019-03-15  Tom Tromey  <tom@tromey.com>
5936
5937         * objfiles.h (struct objfile_per_bfd_storage): Declare
5938         destructor.
5939         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5940         New.
5941         (get_objfile_bfd_data): Use new.  Don't initialize
5942         language_of_main.
5943         (free_objfile_per_bfd_storage): Remove.
5944         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5945
5946 2019-03-15  Tom Tromey  <tom@tromey.com>
5947
5948         * symfile.c (reread_symbols): Update.
5949         * objfiles.c (objfile::objfile): Update.
5950         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5951         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5952         comment.
5953         (minimal_symbol_reader::install): Update.
5954         (terminate_minimal_symbol_table): Remove.
5955         * jit.c (jit_object_close_impl): Update.
5956
5957 2019-03-15  Tom Tromey  <tom@tromey.com>
5958
5959         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5960         initializations.
5961
5962 2019-03-15  Tom Tromey  <tom@tromey.com>
5963
5964         * objfiles.h (struct objfile_per_bfd_storage)
5965         <demangled_hash_languages>: Now a bitset.
5966         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5967         (lookup_minimal_symbol): Update.
5968
5969 2019-03-15  Tom Tromey  <tom@tromey.com>
5970
5971         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5972         Don't return the symbol.
5973         * coffread.c (record_minimal_symbol): Use record_full.
5974
5975 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5976
5977         The MS-Windows port of ncurses fails to switch to a color pair if
5978         one or both of the colors are the implicit default colors.  This
5979         change records the default colors when TUI is initialized, and
5980         then specifies them explicitly when a color pair uses the default
5981         colors.  This allows color styling in TUI mode on MS-Windows.
5982
5983         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5984         ncurses_norm_attr.
5985         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5986         colors in ncurses_norm_attr.
5987         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5988         "none", replace it with the default color recorded in
5989         ncurses_norm_attr.
5990
5991 2019-03-14  Tom Tromey  <tromey@adacore.com>
5992
5993         * source-cache.h (class source_cache) <get_source_lines>: Return
5994         std::string.
5995         * source-cache.c (source_cache::extract_lines): Handle case where
5996         first_pos==npos.  Return std::string.
5997         (source_cache::get_source_lines): Update.
5998
5999 2019-03-14  Tom Tromey  <tromey@adacore.com>
6000
6001         * NEWS: Add item for "style sources" commands.
6002         * source-cache.c (source_cache::get_source_lines): Check
6003         source_styling.
6004         * cli/cli-style.c (source_styling): New global.
6005         (_initialize_cli_style): Add "style sources" commands.
6006         (show_style_sources): New function.
6007         * cli/cli-style.h (source_styling): Declare.
6008
6009 2019-03-14  Pedro Alves  <palves@redhat.com>
6010             Tom Tromey  <tromey@adacore.com>
6011
6012         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6013         * tui/tui-winsource.c (tui_refill_source_window): New function,
6014         from...
6015         (tui_horizontal_source_scroll): ... here.  Move some logic.
6016         * cli/cli-style.c (set_style_enabled): Notify new observable.
6017         * tui/tui-hooks.c (tui_redisplay_source): New function.
6018         (tui_attach_detach_observers): Attach or detach
6019         tui_redisplay_source.
6020         * observable.h (source_styling_changed): New observable.
6021         * observable.c: Define source_styling_changed observable.
6022
6023 2019-03-13  Tom Tromey  <tromey@adacore.com>
6024
6025         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6026         (i386_gnu_nat_target::store_registers): Update.
6027         * target-debug.h (target_debug_print_std_string): New macro.
6028         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6029         * windows-tdep.c (display_one_tib): Update.
6030         * tui/tui-stack.c (tui_make_status_line): Update.
6031         * top.c (print_inferior_quit_action): Update.
6032         * thread.c (thr_try_catch_cmd): Update.
6033         (add_thread_with_info): Update.
6034         (thread_target_id_str): Update.
6035         (thr_try_catch_cmd): Update.
6036         (thread_command): Update.
6037         (thread_find_command): Update.
6038         * record-btrace.c (record_btrace_target::info_record)
6039         (record_btrace_resume_thread, record_btrace_target::resume)
6040         (record_btrace_cancel_resume, record_btrace_step_thread)
6041         (record_btrace_target::wait, record_btrace_target::wait)
6042         (record_btrace_target::wait, record_btrace_target::stop): Update.
6043         * progspace.c (print_program_space): Update.
6044         * process-stratum-target.c
6045         (process_stratum_target::thread_address_space): Update.
6046         * linux-fork.c (linux_fork_mourn_inferior)
6047         (detach_checkpoint_command, info_checkpoints_command)
6048         (linux_fork_context): Update.
6049         (linux_fork_detach): Update.
6050         (class scoped_switch_fork_info): Update.
6051         (delete_checkpoint_command): Update.
6052         * infrun.c (follow_fork_inferior): Update.
6053         (follow_fork_inferior): Update.
6054         (proceed_after_vfork_done): Update.
6055         (handle_vfork_child_exec_or_exit): Update.
6056         (follow_exec): Update.
6057         (displaced_step_prepare_throw): Update.
6058         (displaced_step_restore): Update.
6059         (start_step_over): Update.
6060         (resume_1): Update.
6061         (clear_proceed_status_thread): Update.
6062         (proceed): Update.
6063         (print_target_wait_results): Update.
6064         (do_target_wait): Update.
6065         (context_switch): Update.
6066         (stop_all_threads): Update.
6067         (restart_threads): Update.
6068         (finish_step_over): Update.
6069         (handle_signal_stop): Update.
6070         (switch_back_to_stepped_thread): Update.
6071         (keep_going_pass_signal): Update.
6072         (print_exited_reason): Update.
6073         (normal_stop): Update.
6074         * inferior.c (inferior_pid_to_str): Change return type.
6075         (print_selected_inferior): Update.
6076         (add_inferior): Update.
6077         (detach_inferior): Update.
6078         * dummy-frame.c (fprint_dummy_frames): Update.
6079         * dcache.c (dcache_info_1): Update.
6080         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6081         (btrace_fetch, btrace_clear): Update.
6082         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6083         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6084         type.
6085         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6086         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6087         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6088         * gdbarch.c, gdbarch.h: Rebuild.
6089         * gdbarch.sh (core_pid_to_str): Change return type.
6090         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6091         return type.
6092         (windows_nat_target::pid_to_str): Change return type.
6093         (windows_delete_thread): Update.
6094         (windows_nat_target::attach): Update.
6095         (windows_nat_target::files_info): Update.
6096         * target-delegates.c: Rebuild.
6097         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6098         return type.
6099         (sol_thread_target::pid_to_str): Change return type.
6100         * remote.c (class remote_target) <pid_to_str>: Change return
6101         type.
6102         (remote_target::pid_to_str): Change return type.
6103         (extended_remote_target::attach, remote_target::remote_stop_ns)
6104         (remote_target::remote_notif_remove_queued_reply)
6105         (remote_target::push_stop_reply, remote_target::disable_btrace):
6106         Update.
6107         (extended_remote_target::attach): Update.
6108         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6109         type.
6110         (gdbsim_target::pid_to_str): Change return type.
6111         * ravenscar-thread.c (struct ravenscar_thread_target)
6112         <pid_to_str>: Change return type.
6113         (ravenscar_thread_target::pid_to_str): Change return type.
6114         * procfs.c (class procfs_target) <pid_to_str>: Change return
6115         type.
6116         (procfs_target::pid_to_str): Change return type.
6117         (procfs_target::attach): Update.
6118         (procfs_target::detach): Update.
6119         (procfs_target::fetch_registers): Update.
6120         (procfs_target::store_registers): Update.
6121         (procfs_target::wait): Update.
6122         (procfs_target::files_info): Update.
6123         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6124         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6125         return type.
6126         (nto_procfs_target::pid_to_str): Change return type.
6127         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6128         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6129         return type.
6130         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6131         (exit_lwp): Update.
6132         (attach_proc_task_lwp_callback, get_detach_signal)
6133         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6134         (linux_nat_target::resume, wait_lwp, stop_callback)
6135         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6136         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6137         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6138         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6139         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6140         type.
6141         (inf_ptrace_target::attach): Update.
6142         (inf_ptrace_target::files_info): Update.
6143         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6144         type.
6145         (go32_nat_target::pid_to_str): Change return type.
6146         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6147         (gnu_nat_target::wait): Update.
6148         (gnu_nat_target::wait): Update.
6149         (gnu_nat_target::resume): Update.
6150         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6151         (fbsd_nat_target::wait): Update.
6152         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6153         type.
6154         (darwin_nat_target::attach): Update.
6155         * corelow.c (class core_target) <pid_to_str>: Change return type.
6156         (core_target::pid_to_str): Change return type.
6157         * target.c (normal_pid_to_str): Change return type.
6158         (default_pid_to_str): Likewise.
6159         (target_pid_to_str): Change return type.
6160         (target_translate_tls_address): Update.
6161         (target_announce_detach): Update.
6162         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6163         return type.
6164         (bsd_uthread_target::pid_to_str): Change return type.
6165         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6166         type.
6167         (bsd_kvm_target::pid_to_str): Change return type.
6168         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6169         return type.
6170         (aix_thread_target::pid_to_str): Change return type.
6171         * target.h (struct target_ops) <pid_to_str>: Change return type.
6172         (target_pid_to_str, normal_pid_to_str): Likewise.
6173         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6174         type.
6175         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6176         type.
6177         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6178         return type.
6179         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6180         type.
6181         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6182         type.
6183         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6184         return type.
6185
6186 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6187
6188         * NEWS: Mention that the new default MI version is 3.  Mention
6189         changes to the output of commands and events that deal with
6190         multi-location breakpoints.
6191         * breakpoint.c: Include "mi/mi-out.h".
6192         (print_one_breakpoint): Change output syntax if using MI version
6193         >= 3.
6194         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6195         New.
6196         (mi_multi_location_breakpoint_output_fixed): New.
6197         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6198         (mi_cmd_fix_multi_location_breakpoint_output): New.
6199         (mi_multi_location_breakpoint_output_fixed): New.
6200         * mi/mi-cmds.c (mi_cmds): Register command
6201         -fix-multi-location-breakpoint-output.
6202         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6203         interpreter "mi".
6204
6205 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6206
6207         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6208         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6209         instantiate mi_ui_out based on interpreter name.
6210         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6211         * mi/mi-main.c (mi_load_progress): Likewise.
6212
6213 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6214
6215         * NEWS: Combine separate "New targets" sections for 8.3.
6216
6217 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6218
6219         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6220         (ppcfbsd_init_abi): Install gdbarch
6221         "fetch_tls_load_module_address" and "get_thread_local_address"
6222         methods.
6223
6224 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6225
6226         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6227         (riscv_fbsd_init_abi): Install gdbarch
6228         "fetch_tls_load_module_address" and "get_thread_local_address"
6229         methods.
6230
6231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6232
6233         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6234         (i386fbsd_init_abi): Install gdbarch
6235         "fetch_tls_load_module_address" and "get_thread_local_address"
6236         methods.
6237
6238 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6239
6240         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6241         (amd64fbsd_init_abi): Install gdbarch
6242         "fetch_tls_load_module_address" and "get_thread_local_address"
6243         methods.
6244
6245 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6246
6247         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6248         (struct fbsd_pspace_data): New type.
6249         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6250         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6251         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6252         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6253         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6254
6255 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6256
6257         * gdbtypes.c (lookup_struct_elt): New function.
6258         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6259         * gdbtypes.h (struct struct_elt): New type.
6260         (lookup_struct_elt): New prototype.
6261
6262 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6263
6264         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6265         remove disabled code block.
6266
6267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6268
6269         * gdbarch.sh (get_thread_local_address): New method.
6270         * gdbarch.h, gdbarch.c: Regenerate.
6271         * target.c (target_translate_tls_address): Use
6272         gdbarch_get_thread_local_address if present instead of
6273         target::get_thread_local_address.
6274
6275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6276
6277         * target.h (target::get_thread_local_address): Update comment.
6278
6279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6280
6281         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6282         objfile->separate_debug_objfile_backlink if not NULL.
6283
6284 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6285
6286         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6287         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6288         (amd64bsd_store_inferior_registers): Likewise.
6289         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6290         Enable segment base registers.
6291         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6292         PT_GETFSBASE and PT_GETGSBASE.
6293         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6294         PT_SETGSBASE.
6295         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6296         segment base registers.
6297         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6298
6299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6300
6301         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6302         Update calls to i386_target_description to add 'segments'
6303         parameter.
6304         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6305         add segment base registers.
6306         * arch/i386.c (i386_create_target_description): Add 'segments'
6307         parameter to enable segment base registers.
6308         * arch/i386.h (i386_create_target_description): Likewise.
6309         * features/i386/32bit-segments.xml: New file.
6310         * features/i386/32bit-segments.c: Generate.
6311         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6312         call to i386_target_description to add 'segments' parameter.
6313         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6314         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6315         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6316         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6317         if feature is present.
6318         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6319         Add 'segments' parameter to call to i386_target_description.
6320         (i386_target_description): Add 'segments' parameter to enable
6321         segment base registers.
6322         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6323         to call to i386_target_description.
6324         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6325         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6326         Define I386_NUM_REGS.
6327         (i386_target_description): Add 'segments' parameter to enable
6328         segment base registers.
6329
6330 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6331
6332         PR/24325
6333         * source-cache.c: #undef open and close, to avoid unresolved
6334         externals during linking.
6335
6336 2019-03-12  Tom Tromey  <tromey@adacore.com>
6337
6338         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6339         const.  Add initializers.
6340         (_initialize_remote): Don't initialize ptid globals.
6341
6342 2019-03-12  Pedro Alves  <palves@redhat.com>
6343
6344         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6345
6346 2019-03-12  Pedro Alves  <palves@redhat.com>
6347
6348         * cp-name-parser.y (main): Remove unused 'len' variable.
6349
6350 2019-03-12  Tom Tromey  <tromey@adacore.com>
6351
6352         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6353         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6354
6355 2019-03-12  Tom Tromey  <tromey@adacore.com>
6356
6357         * linux-nat.c (iterate_over_lwps): Update.
6358         (stop_callback): Remove parameter.
6359         (stop_wait_callback, detach_callback, resume_set_callback)
6360         (select_singlestep_lwp_callback, set_ignore_sigint)
6361         (status_callback, resumed_callback, resume_clear_callback)
6362         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6363         data parameter.
6364         (linux_nat_target::detach, linux_nat_target::resume)
6365         (linux_stop_and_wait_all_lwps, select_event_lwp)
6366         (linux_nat_filter_event, linux_nat_wait_1)
6367         (linux_nat_target::kill, linux_nat_target::stop)
6368         (linux_nat_target::stop): Update.
6369         (linux_nat_resume_callback): Change type.
6370         (resume_stopped_resumed_lwps, count_events_callback)
6371         (select_event_lwp_callback): Likewise.
6372         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6373         * arm-linux-nat.c (struct update_registers_data): Remove.
6374         (update_registers_callback): Change type.
6375         (arm_linux_insert_hw_breakpoint1): Update.
6376         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6377         parameter.
6378         (x86_linux_dr_set_addr): Update.
6379         (x86_linux_dr_set_control): Update.
6380         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6381         (iterate_over_lwps): Use gdb::function_view.
6382         * nat/aarch64-linux-hw-point.c (struct
6383         aarch64_dr_update_callback_param): Remove.
6384         (debug_reg_change_callback): Change type.
6385         (aarch64_notify_debug_reg_change): Update.
6386         * s390-linux-nat.c (s390_refresh_per_info): Update.
6387
6388 2019-03-11  Tom Tromey  <tromey@adacore.com>
6389
6390         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6391         redundant assignment to "this_cu".
6392
6393 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6394
6395         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6396
6397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6398
6399         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6400         from...
6401         (rank_one_type): ... this.
6402
6403 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6404
6405         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6406         from...
6407         (rank_one_type): ... this.
6408
6409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6410
6411         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6412         from...
6413         (rank_one_type): ... this.
6414
6415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6416
6417         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6418         from...
6419         (rank_one_type): ... this.
6420
6421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6422
6423         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6424         from...
6425         (rank_one_type): ... this.
6426
6427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6428
6429         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6430         from...
6431         (rank_one_type): ... this.
6432
6433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6434
6435         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6436         from...
6437         (rank_one_type): ... this.
6438
6439 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6440
6441         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6442         from...
6443         (rank_one_type): ... this.
6444
6445 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6446
6447         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6448         from...
6449         (rank_one_type): ... this.
6450
6451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6452
6453         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6454         from...
6455         (rank_one_type): ... this.
6456
6457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6458
6459         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6460         from...
6461         (rank_one_type): ... this.
6462
6463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6464
6465         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6466         from...
6467         (rank_one_type): ... this.
6468
6469 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6470
6471         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6472         inferior-events' shows the example events.
6473
6474 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6475
6476         Support styling on native MS-Windows console
6477
6478         PR/24315
6479         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6480         on MS-Windows if $TERM is not defined.
6481
6482         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6483
6484         * posix-hdep.c (gdb_console_fputs):
6485         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6486         functions.
6487         * ui-file.h (gdb_console_fputs): Add prototype.
6488
6489         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6490         back to fputs only if the former returns zero.
6491
6492 2019-03-07  Tom Tromey  <tom@tromey.com>
6493
6494         * symmisc.c (print_symbol_bcache_statistics): Update.
6495         (print_objfile_statistics): Update.
6496         * symfile.c (allocate_symtab): Update.
6497         * stabsread.c: Don't include bcache.h.
6498         * psymtab.h (struct psymbol_bcache): Don't declare.
6499         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6500         (psymbol_bcache_init, psymbol_bcache_free)
6501         (psymbol_bcache_get_bcache): Don't declare.
6502         * psymtab.c (struct psymbol_bcache): Remove.
6503         (psymtab_storage::psymtab_storage): Update.
6504         (psymtab_storage::~psymtab_storage): Update.
6505         (psymbol_bcache_init, psymbol_bcache_free)
6506         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6507         (add_psymbol_to_bcache): Update.
6508         (allocate_psymtab): Update.
6509         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6510         macro_cache>: No longer pointers.
6511         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6512         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6513         * macrotab.c (macro_bcache): Update.
6514         * macroexp.c: Don't include bcache.h.
6515         * gdbtypes.c (check_types_worklist): Update.
6516         (types_deeply_equal): Remove TRY/CATCH.  Update.
6517         * elfread.c (elf_symtab_read): Update.
6518         * dwarf2read.c: Don't include bcache.h.
6519         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6520         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6521         (print_bcache_statistics, bcache_memory_used): Don't declare.
6522         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6523         methods.  Rename all data members.
6524         * bcache.c (struct bcache): Move to bcache.h.
6525         (bcache::expand_hash_table): Rename from expand_hash_table.
6526         (bcache): Remove.
6527         (bcache::insert): Rename from bcache_full.
6528         (bcache::compare): Rename from bcache_compare.
6529         (bcache_xmalloc): Remove.
6530         (bcache::~bcache): Rename from bcache_xfree.
6531         (bcache::print_statistics): Rename from print_bcache_statistics.
6532         (bcache::memory_used): Rename from bcache_memory_used.
6533
6534 2019-03-07  Pedro Alves  <palves@redhat.com>
6535
6536         * infrun.c (normal_stop): Also check for
6537         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6538
6539 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6540
6541         * f-lang.c (value_from_host_double): Moved to...
6542         * value.c (value_from_host_double): ...here.
6543         * value.h (value_from_host_double): Declare.
6544         * guile/scm-math.c (vlscm_convert_typed_number): Use
6545         value_from_host_double.
6546         (vlscm_convert_number): Likewise.
6547         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6548         * python/py-value.c (convert_value_from_python): Likewise.
6549
6550 2019-03-06  Tom Tromey  <tom@tromey.com>
6551
6552         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6553
6554 2019-03-06  Tom Tromey  <tom@tromey.com>
6555
6556         * utils.h (free_current_contents): Don't declare.
6557         * utils.c (free_current_contents): Remove.
6558
6559 2019-03-06  Tom Tromey  <tom@tromey.com>
6560
6561         * top.c (quit_force): Update.
6562         * main.c (captured_command_loop): Update.
6563         * common/new-op.c (operator new): Update.
6564         * common/common-exceptions.c (struct catcher)
6565         <save_cleanup_chain>: Remove member.
6566         (exceptions_state_mc_init): Update.
6567         (exception_try_scope_entry): Return nullptr.
6568         (exception_try_scope_exit, exception_rethrow)
6569         (throw_exception_sjlj, throw_exception_cxx): Update.
6570         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6571         (all_cleanups, do_cleanups, discard_cleanups)
6572         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6573         (restore_cleanups, restore_final_cleanups): Don't declare.
6574         (do_final_cleanups): Remove parameter.
6575         * common/cleanups.c (cleanup_chain, make_cleanup)
6576         (make_cleanup_dtor, all_cleanups, do_cleanups)
6577         (discard_my_cleanups, discard_cleanups)
6578         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6579         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6580         (null_cleanup): Remove.
6581         (do_final_cleanups): Remove parameter.
6582
6583 2019-03-06  Tom Tromey  <tom@tromey.com>
6584
6585         * remote.c (remote_target::remote_parse_stop_reply): Use
6586         unique_xmalloc_ptr.
6587
6588 2019-03-06  Tom Tromey  <tom@tromey.com>
6589
6590         * stabsread.c (struct stabs_field_info): Rename from field_info.
6591         <list, fnlist>: Add initializers.
6592         <obstack>: New member.
6593         (read_member_functions, read_struct_fields, read_baseclasses):
6594         Allocate on obstack.  Don't use cleanups.
6595         (read_one_struct_field, read_member_functions, read_struct_fields)
6596         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6597         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6598         (read_struct_type): Update.
6599
6600 2019-03-06  Tom Tromey  <tom@tromey.com>
6601
6602         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6603         * common/filestuff.h (make_cleanup_close): Don't declare.
6604         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6605         Remove.
6606
6607 2019-03-06  Tom Tromey  <tom@tromey.com>
6608
6609         * solib-aix.c: Use make_scope_exit.
6610
6611 2019-03-06  Tom Tromey  <tom@tromey.com>
6612
6613         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6614         Use make_scope_exit.
6615
6616 2019-03-06  Tom Tromey  <tom@tromey.com>
6617
6618         * solib-svr4.c (disable_probes_interface): Remove parameter.
6619         (svr4_handle_solib_event): Use make_scope_exit.
6620
6621 2019-03-06  Tom Tromey  <tom@tromey.com>
6622
6623         * remote.c (struct stop_reply_deleter): Remove.
6624         (stop_reply_up): Update.
6625         (struct stop_reply): Derive from notif_event.  Don't typedef.
6626         <regcache>: Now a std::vector.
6627         (stop_reply_xfree): Remove.
6628         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6629         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6630         (remote_target::discard_pending_stop_replies): Use delete.
6631         (remote_target::remote_parse_stop_reply): Update.
6632         (remote_target::process_stop_reply): Update.
6633         * remote-notif.h (struct notif_event): Add virtual destructor.
6634         Remove "dtr" member.
6635         (struct notif_client) <alloc_event>: Return a unique_ptr.
6636         (notif_event_xfree): Don't declare.
6637         (notif_event_up): New typedef.
6638         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6639         (notif_event_xfree, do_notif_event_xfree): Remove.
6640         (remote_notif_state_xfree): Update.
6641
6642 2019-03-06  Tom Tromey  <tom@tromey.com>
6643
6644         * infrun.c (displaced_step_clear_cleanup): Now a
6645         forward_scope_exit type.
6646         (displaced_step_prepare_throw): Update.
6647         (displaced_step_fixup): Update.
6648
6649 2019-03-06  Tom Tromey  <tom@tromey.com>
6650
6651         * inferior.h (class inferior): Update comment.
6652         * gdbthread.h (class thread_info): Update comment.
6653
6654 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6655             Tom Tromey  <tom@tromey.com>
6656
6657         * stabsread.h (struct stab_section_list): Remove.
6658         (coffstab_build_psymtabs): Update.
6659         * dbxread.c (symbuf_sections): Now a std::vector.
6660         (sect_idx): New global.
6661         (fill_symbuf): Update.
6662         (coffstab_build_psymtabs): Change type of stabsects parameter.
6663         Update.
6664         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6665         std::vector.
6666         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6667         (coff_locate_sections): Update.
6668         (coff_symfile_read): Remove cleanups.  Update.
6669         (init_stringtab): Add storage parameter.
6670         (free_stringtab, free_stringtab_cleanup): Remove.
6671         (init_lineno): Add storage parameter.
6672         (free_linetab, free_linetab_cleanup): Remove.
6673
6674 2019-03-06  Pedro Alves  <palves@redhat.com>
6675
6676         * linux-fork.c (fork_info::clobber_regs): Delete.
6677         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6678         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6679         comment.  Adjust.
6680         (scoped_switch_fork_info::scoped_switch_fork_info)
6681         (checkpoint_command, linux_fork_context): Adjust
6682         fork_save_infrun_state calls.
6683
6684 2019-03-06  Pedro Alves  <palves@redhat.com>
6685
6686         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6687         (inf_has_multiple_threads): Return 'bool' and rewrite using
6688         inferior_info::threads().
6689
6690 2019-03-06  Pedro Alves  <palves@redhat.com>
6691
6692         * linux-fork.c: Include <list>.
6693         (fork_list): Now a std::list instance.
6694         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6695         (forks_exist_p, find_last_fork): Adjust.
6696         (new_fork): Delete.
6697         (one_fork_p): New.
6698         (add_fork): Adjust.
6699         (free_fork): Delete, folded into fork_info::~fork_info().
6700         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6701         Adjust.
6702         (init_fork_list): Delete.
6703         (linux_fork_killall, linux_fork_mourn_inferior)
6704         (linux_fork_detach, info_checkpoints_command): Adjust.
6705         (_initialize_linux_fork): No longer call init_fork_list.
6706
6707 2019-03-06  Pedro Alves  <palves@redhat.com>
6708
6709         * linux-fork.c (new_fork): New, split out of ...
6710         (add_fork): ... this.  Return void.  Move "first fork" special
6711         case from here, to ...
6712         (checkpoint_command): ... here.
6713         * linux-linux.h (add_fork): Return void.
6714
6715 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6716
6717         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6718
6719 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6720             Chris January  <chris.january@arm.com>
6721             David Lecomber  <david.lecomber@arm.com>
6722
6723         * f-exp.y: New token, UNOP_INTRINSIC.
6724         (exp): New pattern using UNOP_INTRINSIC token.
6725         (f77_keywords): Add 'abs' keyword.
6726         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6727         (value_from_host_double): New function.
6728         (evaluate_subexp_f): Support UNOP_ABS.
6729
6730 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6731
6732         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6733         types.
6734
6735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6736
6737         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6738         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6739         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6740
6741 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6742
6743         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6744
6745 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6746             Chris January  <chris.january@arm.com>
6747
6748         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6749         * f-exp.y: Define 'KIND' token.
6750         (exp): New pattern for KIND expressions.
6751         (ptype): Handle types with a kind extension.
6752         (direct_abs_decl): Extend to spot kind extensions.
6753         (f77_keywords): Add 'kind' to the list.
6754         (push_kind_type): New function.
6755         (convert_to_kind_type): New function.
6756         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6757         * parse.c (operator_length_standard): Likewise.
6758         * parser-defs.h (enum type_pieces): Add tp_kind.
6759         * std-operator.def: Add UNOP_KIND.
6760
6761 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6762
6763         * f-exp.y (f_parse): Set yydebug.
6764
6765 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6766
6767         * f-lang.c (evaluate_subexp_f): New function.
6768         (exp_descriptor_f): New global.
6769         (f_language_defn): Use exp_descriptor_f instead of
6770         exp_descriptor_standard.
6771
6772 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6773
6774         * f-exp.y (struct token): Add comments.
6775         (dot_ops): Remove uppercase versions and the end marker.
6776         (f77_keywords): Likewise.
6777         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6778         entries in the dot_ops array are case insensitive, and use
6779         strncasecmp to compare strings.  Also some whitespace cleanup in
6780         this area.  Similar for the f77_keywords array, except entries in
6781         this list might be case sensitive.
6782
6783 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6784
6785         * f-exp.y (struct f77_boolean_val): Add comments.
6786         (boolean_values): Remove uppercase versions, and end marker.
6787         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6788         and use strncasecmp to achieve case insensitivity.  Additionally,
6789         perform whitespace cleanup around this code.
6790
6791 2019-03-06  Tom Tromey  <tromey@adacore.com>
6792
6793         * remote-sim.c (gdbsim_target_open): Use result of
6794         gdb_argv::release.
6795
6796 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6797         Dirk Schubert  <dirk.schubert@arm.com>
6798         Chris January  <chris.january@arm.com>
6799
6800         * eval.c (evaluate_subexp_standard): Call Fortran argument
6801         wrapping logic.
6802         * f-lang.c (struct value): A value which can be passed into a
6803         Fortran function call.
6804         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6805         where appropriate.
6806         (struct type): Value ready for a Fortran function call.
6807         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6808         is needed.
6809         * f-lang.h (fortran_argument_convert): Declaration.
6810         (fortran_preserve_arg_pointer): Declaration.
6811         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6812
6813 2019-03-05  Tom Tromey  <tromey@adacore.com>
6814
6815         * python/py-prettyprint.c (print_string_repr): Remove #if.
6816         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6817
6818 2019-03-05  Tom Tromey  <tromey@adacore.com>
6819
6820         * target.c (the_dummy_target): Move later.  Change type to
6821         "dummy_target".
6822         (initialize_targets): Don't initialize the_dummy_target.
6823
6824 2019-03-05  Tom Tromey  <tromey@adacore.com>
6825
6826         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6827         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6828
6829 2019-03-05  Tom Tromey  <tromey@adacore.com>
6830
6831         * windows-nat.c (windows_nat_target::attach)
6832         (windows_nat_target::detach): Don't call gdb_flush.
6833         * valprint.c (generic_val_print, val_print, val_print_string):
6834         Don't call gdb_flush.
6835         * utils.c (defaulted_query): Don't call gdb_flush.
6836         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6837         * target.c (target_announce_detach): Don't call gdb_flush.
6838         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6839         * remote.c (extended_remote_target::attach): Don't call
6840         gdb_flush.
6841         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6842         * printcmd.c (do_examine): Don't call gdb_flush.
6843         (info_display_command): Don't call gdb_flush.
6844         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6845         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6846         * memattr.c (info_mem_command): Don't call gdb_flush.
6847         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6848         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6849         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6850         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6851         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6852         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6853         (gnu_nat_target::detach): Don't call gdb_flush.
6854         * f-valprint.c (f_val_print): Don't call gdb_flush.
6855         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6856         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6857         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6858         gdb_flush.
6859         * c-valprint.c (c_val_print): Don't call gdb_flush.
6860         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6861
6862 2019-03-05  Tom Tromey  <tromey@adacore.com>
6863
6864         * varobj.c (update_dynamic_varobj_children): Update.
6865         (install_default_visualizer): Use reset, not release.
6866         * value.c (set_internalvar): Update.
6867         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6868         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6869         ATTRIBUTE_UNUSED_RESULT.
6870
6871 2019-03-05  Tom Tromey  <tromey@adacore.com>
6872
6873         * remote.c (class scoped_remote_fd) <release>: Add
6874         ATTRIBUTE_UNUSED_RESULT.
6875
6876 2019-03-05  Tom Tromey  <tromey@adacore.com>
6877
6878         * macroexp.c (struct macro_buffer) <release>: Add
6879         ATTRIBUTE_UNUSED_RESULT.
6880
6881 2019-03-05  Tom Tromey  <tromey@adacore.com>
6882
6883         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6884         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6885         ATTRIBUTE_UNUSED_RESULT.
6886
6887 2019-03-05  Tom Tromey  <tromey@adacore.com>
6888
6889         * common/scoped_fd.h (class scoped_fd) <release>: Add
6890         ATTRIBUTE_UNUSED_RESULT.
6891
6892 2019-03-05  Tom Tromey  <tromey@adacore.com>
6893
6894         * parser-defs.h (struct parser_state) <release>: Add
6895         ATTRIBUTE_UNUSED_RESULT.
6896
6897 2019-03-05  Tom Tromey  <tromey@adacore.com>
6898
6899         * utils.h (class gdb_argv) <release>: Add
6900         ATTRIBUTE_UNUSED_RESULT.
6901         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6902
6903 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6904
6905         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6906         for-loop range, to avoid compiler warnings.
6907
6908         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6909         avoid compiler warnings about unused variables.
6910
6911         * NEWS: Mention end of support for native debugging on MS-Windows
6912         before XP.
6913
6914         PR gdb/24292
6915         * common/netstuff.c:
6916         * gdbserver/gdbreplay.c
6917         * gdbserver/remote-utils.c:
6918         * ser-tcp.c:
6919         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6920         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6921         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6922         'getaddrinfo' and 'freeaddrinfo' were not available before
6923         Windows XP, and mingw.org's MinGW headers by default define
6924         _WIN32_WINNT to 0x500.
6925
6926 2019-03-01  Gary Benson <gbenson@redhat.com>
6927
6928         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6929
6930 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6931             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6932
6933         PR gdb/8527
6934         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6935         set_sigint_trap, clear_sigint_trap.
6936
6937 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6938
6939         * target.c (target_detach): Clear the regcache and the
6940         frame cache.
6941
6942 2019-02-27  Pedro Alves  <palves@redhat.com>
6943
6944         * utils.c (set_screen_size): When we cap the height/width sizes,
6945         tweak the corresponding command variable to show "unlimited":
6946
6947 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6948             Pedro Alves  <palves@redhat.com>
6949
6950         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6951         before calling rl_set_screen_size.
6952
6953 2019-02-27  Tom Tromey  <tromey@adacore.com>
6954
6955         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6956         define.
6957         * python/py-value.c: Remove Python 2.4 workaround.
6958         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6959         workaround.
6960         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6961         Python 2.4 workaround.
6962         * python/python-internal.h: Remove Python 2.4 comment.
6963         (Py_ssize_t): Don't define.
6964         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6965         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6966         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6967         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6968         * python/python.c (do_start_initialization): Remove Python 2.4
6969         workaround.
6970         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6971         (print_children): Remove Python 2.4 workaround.
6972         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6973         workaround.
6974         (CHARBUFFERPROC_NAME): Remove.
6975         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6976         Python 2.4 workaround.
6977
6978 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6979
6980         * NEWS: Note minimum Python version.
6981
6982 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6983
6984         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6985         code from these functions.  Remove corresponding ifdefs.  Use
6986         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6987         Remove gotos and target of gotos.
6988         (infpy_search_memory): Likewise.
6989
6990 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6991
6992         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6993         (hppa_gdbarch_init): Don't register deleted functions with
6994         gdbarch.
6995
6996 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6997
6998         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6999         (h8300_unwind_sp): Delete.
7000         (h8300_dummy_id): Delete.
7001         (h8300_gdbarch_init): Don't register deleted functions with
7002         gdbarch.
7003
7004 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7005
7006         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7007         (ft32_unwind_pc): Delete.
7008         (ft32_unwind_sp): Delete.
7009         (ft32_gdbarch_init): Don't register deleted functions with
7010         gdbarch.
7011
7012 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7013
7014         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7015         (frv_unwind_pc): Delete.
7016         (frv_unwind_sp): Delete.
7017         (frv_gdbarch_init): Don't register deleted functions with
7018         gdbarch.
7019
7020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7021
7022         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7023         (riscv_unwind_pc): Delete.
7024         (riscv_unwind_sp): Delete.
7025         (riscv_gdbarch_init): Don't register deleted functions with
7026         gdbarch.
7027
7028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7029
7030         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7031         (csky_unwind_pc): Delete.
7032         (csky_unwind_sp): Delete.
7033         (csky_gdbarch_init): Don't register deleted functions with
7034         gdbarch.
7035
7036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7037
7038         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7039         (cris_unwind_pc): Delete.
7040         (cris_unwind_sp): Delete.
7041         (cris_gdbarch_init): Don't register deleted functions with
7042         gdbarch.
7043
7044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7045
7046         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7047         (bfin_unwind_pc): Delete.
7048         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7049
7050 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7051
7052         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7053         (arm_unwind_pc): Delete.
7054         (arm_unwind_sp): Delete.
7055         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7056
7057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7058
7059         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7060         (arc_unwind_pc): Delete.
7061         (arc_unwind_sp): Delete.
7062         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7063
7064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7065
7066         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7067         (alpha_unwind_pc): Delete.
7068         (alpha_gdbarch_init): Don't register deleted functions with
7069         gdbarch.
7070
7071 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7072
7073         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7074         (aarch64_unwind_pc): Delete.
7075         (aarch64_unwind_sp): Delete.
7076         (aarch64_gdbarch_init): Don't register deleted functions with
7077         gdbarch.
7078
7079 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7080
7081         * gdbtypes.c (type_align): Don't consider static members when
7082         computing structure alignment.
7083
7084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7085
7086         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7087         return 0 for other types.
7088         * arch-utils.c (default_type_align): Always return 0.
7089         * gdbarch.h: Regenerate.
7090         * gdbarch.sh (type_align): Extend comment.
7091         * gdbtypes.c (type_align): Add additional comments, always call
7092         gdbarch_type_align before applying the default rules.
7093         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7094         generic code will then apply a suitable default.
7095         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7096         types, return 0 for other types.
7097
7098 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7099
7100         * NEWS: Create a new section for the next release branch.
7101         Rename the section of the current branch, now that it has
7102         been cut.
7103
7104 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7105
7106         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7107         * version.in: Bump version to 8.3.50.DATE-git.
7108
7109 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7110
7111         * aix-thread.c (ptid_cmp): Remove unused variable.
7112         (get_signaled_thread): Likewise.
7113         (store_regs_user_thread): Likewise.
7114         (store_regs_kernel_thread): Likewise.
7115         (fetch_regs_kernel_thread): Remove shadowed variable.
7116
7117 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7118
7119         * features/riscv/32bit-cpu.xml: Add register numbers.
7120         * features/riscv/32bit-fpu.c: Regenerate.
7121         * features/riscv/32bit-fpu.xml: Add register numbers.
7122         * features/riscv/64bit-cpu.xml: Add register numbers.
7123         * features/riscv/64bit-fpu.c: Regenerate.
7124         * features/riscv/64bit-fpu.xml: Add register numbers.
7125
7126 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7127
7128         * NEWS: Mention two argument form of gdb.Value constructor.
7129         * python/py-value.c (convert_buffer_and_type_to_value): New
7130         function.
7131         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7132         Add support for handling an optional second argument.  Call
7133         convert_buffer_and_type_to_value as appropriate.
7134         * python/python-internal.h (Py_buffer_deleter): New struct.
7135         (Py_buffer_up): New typedef.
7136
7137 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7138
7139         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7140         instead of releasing ownership.
7141
7142 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7143
7144         * dwarf2read.c (open_and_init_dwp_file): Call
7145         elf_numsections instead of bfd_count_sections to initialize
7146         dwp_file->num_sections.
7147
7148 2019-02-25  Tom Tromey  <tromey@adacore.com>
7149
7150         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7151
7152 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7153
7154         * gcore.in: Add '--readnever' option when invoking GDB.
7155
7156 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7157
7158         * MAINTAINERS: Update my email address.
7159
7160 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7161
7162         * build-id.c (build_id_to_debug_bfd_1): New function.
7163         (build_id_to_debug_bfd): Look for separate debug file in
7164         sysroot.
7165
7166 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7167
7168         * gdbarch.sh: Update the copyright year range that is placed into
7169         generated files.
7170
7171 2019-02-22  Keith Seitz  <keiths@redhat.com>
7172
7173         PR symtab/23853
7174         * linespec.c (create_sals_line_offset): Search for the default
7175         symtab's filename instead of its fullname.
7176
7177 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7178
7179         * NEWS: Update style defaults.
7180
7181 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7182
7183         * main.c (captured_main_1): Disable styling in batch mode.
7184
7185 2019-02-20  Tom Tromey  <tom@tromey.com>
7186
7187         * symtab.c (symtab_symbol_info): Fix typos.
7188
7189 2019-02-20  Tom Tromey  <tromey@adacore.com>
7190
7191         * findcmd.c (_initialize_mem_search): Use upper case for
7192         metasyntactic variables.
7193
7194 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7195
7196         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7197         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7198
7199 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7200
7201         * top.h (source_file_name): Change to std::string.
7202         * top.c (source_file_name): Likewise.
7203         (command_line_input): Adjust.
7204         * cli/cli-script.c (script_from_file): Adjust.
7205
7206 2019-02-19  Tom Tromey  <tromey@adacore.com>
7207
7208         * ravenscar-thread.c
7209         (ravenscar_thread_target::update_thread_list): Don't call
7210         ada_build_task_list.
7211         * ada-lang.h (ada_build_task_list): Don't declare.
7212         * ada-tasks.c (struct ada_tasks_inferior_data)
7213         <task_list_valid_p>: Now bool.
7214         (read_known_tasks, ada_task_list_changed)
7215         (ada_tasks_invalidate_inferior_data): Update.
7216         (read_known_tasks_array): Return bool.
7217         (read_known_tasks_list): Likewise.
7218         (read_known_tasks): Return void.
7219         (ada_build_task_list): Now static.
7220
7221 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7222
7223         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7224         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7225
7226 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7227
7228         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7229         variant for ada_tasks_pspace_data_handle and
7230         ada_tasks_inferior_data_handle.
7231         (ada_tasks_pspace_data_cleanup): New function.
7232         (ada_tasks_inferior_data_cleanup): New function.
7233
7234 2019-02-17  Tom Tromey  <tom@tromey.com>
7235
7236         * macrotab.h (macro_source_fullname): Return a std::string.
7237         * macrotab.c (macro_include, check_for_redefinition)
7238         (macro_undef, macro_lookup_definition, foreach_macro)
7239         (foreach_macro_in_scope): Update.
7240         (macro_source_fullname): Return a std::string.
7241         * macrocmd.c (show_pp_source_pos): Update.
7242
7243 2019-02-17  Tom Tromey  <tom@tromey.com>
7244
7245         * macrocmd.c (show_pp_source_pos): Style the file names.
7246
7247 2019-02-17  Tom Tromey  <tom@tromey.com>
7248
7249         PR tui/24197:
7250         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7251
7252 2019-02-17  Tom Tromey  <tom@tromey.com>
7253
7254         * ada-lang.c (user_select_syms): Use filtered printing.
7255         * utils.c (wrap_style): New global.
7256         (desired_style): Remove.
7257         (emit_style_escape): Add stream parameter.
7258         (set_output_style, reset_terminal_style, prompt_for_continue):
7259         Update.
7260         (flush_wrap_buffer): Only flush gdb_stdout.
7261         (wrap_here): Set wrap_style.
7262         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7263         treat escape sequences as a character.  Change when wrap buffer is
7264         flushed.
7265         (fputs_styled): Do not set the output style when the default is
7266         requested.
7267         * ui-style.h (struct ui_file_style) <is_default>: New method.
7268         * source.c (print_source_lines_base): Emit escape sequences in one
7269         piece.
7270
7271 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7272
7273         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7274         integers and enumeration types.
7275
7276 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7277
7278         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7279         instead of lookup_symbol_in_language
7280         (do_exact_match): New function.
7281         (ada_get_symbol_name_matcher): Return do_exact_match when
7282         doing a verbatim match.
7283
7284 2019-02-15  Tom Tromey  <tromey@adacore.com>
7285
7286         * ravenscar-thread.c (ravenscar_thread_target::resume)
7287         (ravenscar_thread_target::wait): Special case wildcard requests.
7288
7289 2019-02-15  Tom Tromey  <tromey@adacore.com>
7290
7291         * ravenscar-thread.c (base_ptid): Remove.
7292         (struct ravenscar_thread_target) <close>: New method.
7293         <m_base_ptid>: New member.
7294         <update_inferior_ptid, active_task, task_is_currently_active,
7295         runtime_initialized>: Declare methods.
7296         <ravenscar_thread_target>: Add constructor.
7297         (ravenscar_thread_target::task_is_currently_active)
7298         (ravenscar_thread_target::update_inferior_ptid)
7299         (ravenscar_runtime_initialized): Rename.  Now methods.
7300         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7301         (ravenscar_thread_target::update_thread_list): Update.
7302         (ravenscar_thread_target::active_task): Now method.
7303         (ravenscar_thread_target::store_registers)
7304         (ravenscar_thread_target::prepare_to_store)
7305         (ravenscar_thread_target::prepare_to_store)
7306         (ravenscar_thread_target::mourn_inferior): Update.
7307         (ravenscar_inferior_created): Use "new" to create target.
7308         (ravenscar_thread_target::get_ada_task_ptid): Update.
7309         (_initialize_ravenscar): Don't initialize base_ptid.
7310         (ravenscar_ops): Remove global.
7311
7312 2019-02-15  Tom Tromey  <tromey@adacore.com>
7313
7314         * target.h (push_target): Declare new overload.
7315         * target.c (push_target): New overload, taking an rvalue reference.
7316         * remote.c (remote_target::open_1): Use push_target overload.
7317         * corelow.c (core_target_open): Use push_target overload.
7318
7319 2019-02-15  Tom Tromey  <tromey@adacore.com>
7320
7321         * ravenscar-thread.c (is_ravenscar_task)
7322         (ravenscar_task_is_currently_active): Return bool.
7323         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7324         (_initialize_ravenscar): Remove "(void)".
7325         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7326         Return bool.
7327
7328 2019-02-15  Tom Tromey  <tromey@adacore.com>
7329
7330         * ravenscar-thread.c (ravenscar_runtime_initializer)
7331         (has_ravenscar_runtime, get_running_thread_id)
7332         (ravenscar_thread_target::resume): Fix indentation.
7333
7334 2019-02-15  Tom Tromey  <tromey@adacore.com>
7335
7336         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7337         from ravenscar_arch_ops.
7338         (sparc_ravenscar_ops::fetch_registers)
7339         (sparc_ravenscar_ops::store_registers): Now methods.
7340         (sparc_ravenscar_prepare_to_store): Remove.
7341         (sparc_ravenscar_ops): Redefine.
7342         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7343         methods and destructor.  Remove members.
7344         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7345         (ravenscar_thread_target::store_registers)
7346         (ravenscar_thread_target::prepare_to_store): Update.
7347         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7348         Remove.
7349         (struct ppc_ravenscar_powerpc_ops): Derive from
7350         ravenscar_arch_ops.
7351         (ppc_ravenscar_powerpc_ops::fetch_registers)
7352         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7353         (ppc_ravenscar_powerpc_ops): Redefine.
7354         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7355         (ppc_ravenscar_e500_ops::fetch_registers)
7356         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7357         (ppc_ravenscar_e500_ops): Redefine.
7358         * aarch64-ravenscar-thread.c
7359         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7360         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7361         (aarch64_ravenscar_fetch_registers)
7362         (aarch64_ravenscar_store_registers): Now methods.
7363         (aarch64_ravenscar_ops): Redefine.
7364
7365 2019-02-15  Tom Tromey  <tromey@adacore.com>
7366
7367         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7368         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7369         (ravenscar_thread_target::stopped_by_watchpoint)
7370         (ravenscar_thread_target::stopped_data_address)
7371         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7372
7373 2019-02-15  Tom Tromey  <tromey@adacore.com>
7374
7375         * ravenscar-thread.c: Fix some typos.
7376
7377 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7378             Tom Tromey  <tromey@adacore.com>
7379
7380         * ada-lang.c (ada_exception_sal): Change addr_string to a
7381         std::string.
7382         (create_ada_exception_catchpoint): Update.
7383
7384 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7385             Tom Tromey  <tromey@adacore.com>
7386
7387         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7388         (bp_location_ops): Remove.
7389         (base_breakpoint_allocate_location): Update.
7390         (free_bp_location): Update.
7391         * ada-lang.c (class ada_catchpoint_location)
7392         <ada_catchpoint_location>: Remove ops parameter.
7393         (ada_catchpoint_location_dtor): Remove.
7394         (ada_catchpoint_location_ops): Remove.
7395         (allocate_location_exception): Update.
7396         * breakpoint.h (struct bp_location_ops): Remove.
7397         (class bp_location) <bp_location>: Remove bp_location_ops
7398         parameter.
7399         <~bp_location>: Add destructor.
7400         <ops>: Remove.
7401
7402 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7403             Pedro Alves  <palves@redhat.com>
7404
7405         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7406         'PATH_MAX'.
7407
7408 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7409             Samuel Thibault  <samuel.thibault@gnu.org>
7410             Thomas Schwinge  <thomas@codesourcery.com>
7411
7412         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7413         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7414
7415 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7416
7417         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7418         (check_empty): Use "const char *".
7419
7420         * gnu-nat.c (gnu_nat_target::detach): Instead of
7421         'detach_inferior (pid)' call
7422         'detach_inferior (find_inferior_pid (pid))'.
7423
7424         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7425         'nat/fork-inferior.o'.
7426         * gnu-nat.c: #include "nat/fork-inferior.h".
7427
7428         * gnu-nat.c (gnu_nat_target::detach): Instead of
7429         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7430         * gnu-nat.h: #include "inf-child.h".
7431         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7432         'i386_gnu_nat_target::fetch_registers'.
7433         (gnu_store_registers): Rename/move to
7434         'i386_gnu_nat_target::store_registers'.
7435
7436         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7437         * gnu-nat.h (mach_thread_info): New function.
7438         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7439
7440         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7441
7442 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7443
7444         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7445
7446 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7447
7448         * windows-nat.c (windows_add_thread): Add new parameter
7449         "main_thread_p" with default value set to false.  Update
7450         function documentation as well as all callers.
7451         (windows_delete_thread): Likewise.
7452         (fake_create_process): Update call to windows_add_thread.
7453         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7454         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7455         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7456         call to windows_delete_thread.
7457
7458 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7459
7460         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7461
7462 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7463
7464         * symfile.c (find_separate_debug_file): Use canonical path of
7465         sysroot with child_path instead of gdb_sysroot if it is valid.
7466
7467 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7468
7469         * symfile.c (find_separate_debug_file): Use child_path to
7470         determine if an object file is under a sysroot.
7471
7472 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7473
7474         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7475         unittests/child-path-selftests.c.
7476         * common/pathstuff.c (child_path): New function.
7477         * common/pathstuff.h (child_path): New prototype.
7478         * unittests/child-path-selftests.c: New file.
7479
7480 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7481
7482         * symfile.c (find_separate_debug_file): Look for separate debug
7483         files in debug directories under the sysroot.
7484
7485 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7486
7487         * symtab.h (struct minimal_symbol data_p): New const method.
7488         (struct minimal_symbol text_p): Likewise.
7489         * symtab.c (output_source_filename): Use file name style
7490         to print file name.
7491         (print_symbol_info): Likewise.
7492         (print_msymbol_info): Use address style to print addresses.
7493         Use function name style to print executable text symbols.
7494         (expand_symtab_containing_pc): Use data_p.
7495         (find_pc_sect_compunit_symtab): Likewise.
7496
7497 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7498
7499         * breakpoint.c (describe_other_breakpoints): Use address style
7500         to print addresses.
7501         (say_where): Likewise.
7502
7503 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7504
7505         * ada-typeprint.c (print_func_type): Print function name
7506         style to print function name.
7507         * c-typeprint.c (c_print_type_1): Likewise.
7508
7509 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7510
7511         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7512         for execve.
7513
7514 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7515
7516         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7517         type_stack.
7518
7519 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7520
7521         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7522         TYPE_CODE_REF types.
7523
7524 2019-02-08  Jim Wilson  <jimw@sifive.com>
7525
7526         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7527         (riscv_linux_fregset): New.
7528         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7529
7530 2019-02-07  Tom Tromey  <tom@tromey.com>
7531
7532         * thread.c (thread_cancel_execution_command): Update.
7533         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7534         methods.
7535         (struct thread_fsm_ops): Remove.
7536         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7537         (thread_fsm_should_stop, thread_fsm_return_value)
7538         (thread_fsm_set_finished, thread_fsm_finished_p)
7539         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7540         Don't declare.
7541         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7542         * infrun.c (clear_proceed_status_thread)
7543         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7544         (print_stop_event): Update.
7545         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7546         Add constructor.
7547         (step_command_fsm_ops): Remove.
7548         (new_step_command_fsm): Remove.
7549         (step_1): Update.
7550         (step_command_fsm::should_stop): Rename from
7551         step_command_fsm_should_stop.
7552         (step_command_fsm::clean_up): Rename from
7553         step_command_fsm_clean_up.
7554         (step_command_fsm::do_async_reply_reason): Rename from
7555         step_command_fsm_async_reply_reason.
7556         (struct until_next_fsm): Inherit from thread_fsm.  Add
7557         constructor.
7558         (until_next_fsm_ops): Remove.
7559         (new_until_next_fsm): Remove.
7560         (until_next_fsm::should_stop): Rename from
7561         until_next_fsm_should_stop.
7562         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7563         (until_next_fsm::do_async_reply_reason): Rename from
7564         until_next_fsm_async_reply_reason.
7565         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7566         constructor.  Change type of breakpoint.
7567         (finish_command_fsm_ops): Remove.
7568         (new_finish_command_fsm): Remove.
7569         (finish_command_fsm::should_stop): Rename from
7570         finish_command_fsm_should_stop.
7571         (finish_command_fsm::clean_up): Rename from
7572         finish_command_fsm_clean_up.
7573         (finish_command_fsm::return_value): Rename from
7574         finish_command_fsm_return_value.
7575         (finish_command_fsm::do_async_reply_reason): Rename from
7576         finish_command_fsm_async_reply_reason.
7577         (finish_command): Update.
7578         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7579         Add constructor.
7580         (call_thread_fsm_ops): Remove.
7581         (call_thread_fsm::call_thread_fsm): Rename from
7582         new_call_thread_fsm.
7583         (call_thread_fsm::should_stop): Rename from
7584         call_thread_fsm_should_stop.
7585         (call_thread_fsm::should_notify_stop): Rename from
7586         call_thread_fsm_should_notify_stop.
7587         (run_inferior_call, call_function_by_hand_dummy): Update.
7588         * cli/cli-interp.c (should_print_stop_to_console): Update.
7589         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7590         Add constructor.  Change type of location_breakpoint,
7591         caller_breakpoint.
7592         (until_break_fsm_ops): Remove.
7593         (new_until_break_fsm): Remove.
7594         (until_break_fsm::should_stop): Rename from
7595         until_break_fsm_should_stop.
7596         (until_break_fsm::clean_up): Rename from
7597         until_break_fsm_clean_up.
7598         (until_break_fsm::do_async_reply_reason): Rename from
7599         until_break_fsm_async_reply_reason.
7600         (until_break_command): Update.
7601         * thread-fsm.c: Remove.
7602         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7603
7604 2019-02-07  Tom Tromey  <tom@tromey.com>
7605
7606         * yy-remap.h: Add include guard.
7607         * xtensa-tdep.h: Add include guard.
7608         * xcoffread.h: Rename include guard.
7609         * varobj-iter.h: Add include guard.
7610         * tui/tui.h: Rename include guard.
7611         * tui/tui-winsource.h: Rename include guard.
7612         * tui/tui-wingeneral.h: Rename include guard.
7613         * tui/tui-windata.h: Rename include guard.
7614         * tui/tui-win.h: Rename include guard.
7615         * tui/tui-stack.h: Rename include guard.
7616         * tui/tui-source.h: Rename include guard.
7617         * tui/tui-regs.h: Rename include guard.
7618         * tui/tui-out.h: Rename include guard.
7619         * tui/tui-layout.h: Rename include guard.
7620         * tui/tui-io.h: Rename include guard.
7621         * tui/tui-hooks.h: Rename include guard.
7622         * tui/tui-file.h: Rename include guard.
7623         * tui/tui-disasm.h: Rename include guard.
7624         * tui/tui-data.h: Rename include guard.
7625         * tui/tui-command.h: Rename include guard.
7626         * tic6x-tdep.h: Add include guard.
7627         * target/waitstatus.h: Rename include guard.
7628         * target/wait.h: Rename include guard.
7629         * target/target.h: Rename include guard.
7630         * target/resume.h: Rename include guard.
7631         * target-float.h: Rename include guard.
7632         * stabsread.h: Add include guard.
7633         * rs6000-tdep.h: Add include guard.
7634         * riscv-fbsd-tdep.h: Add include guard.
7635         * regformats/regdef.h: Rename include guard.
7636         * record.h: Rename include guard.
7637         * python/python.h: Rename include guard.
7638         * python/python-internal.h: Rename include guard.
7639         * python/py-stopevent.h: Rename include guard.
7640         * python/py-ref.h: Rename include guard.
7641         * python/py-record.h: Rename include guard.
7642         * python/py-record-full.h: Rename include guard.
7643         * python/py-record-btrace.h: Rename include guard.
7644         * python/py-instruction.h: Rename include guard.
7645         * python/py-events.h: Rename include guard.
7646         * python/py-event.h: Rename include guard.
7647         * procfs.h: Add include guard.
7648         * proc-utils.h: Add include guard.
7649         * p-lang.h: Add include guard.
7650         * or1k-tdep.h: Rename include guard.
7651         * observable.h: Rename include guard.
7652         * nto-tdep.h: Rename include guard.
7653         * nat/x86-linux.h: Rename include guard.
7654         * nat/x86-linux-dregs.h: Rename include guard.
7655         * nat/x86-gcc-cpuid.h: Add include guard.
7656         * nat/x86-dregs.h: Rename include guard.
7657         * nat/x86-cpuid.h: Rename include guard.
7658         * nat/ppc-linux.h: Rename include guard.
7659         * nat/mips-linux-watch.h: Rename include guard.
7660         * nat/linux-waitpid.h: Rename include guard.
7661         * nat/linux-ptrace.h: Rename include guard.
7662         * nat/linux-procfs.h: Rename include guard.
7663         * nat/linux-osdata.h: Rename include guard.
7664         * nat/linux-nat.h: Rename include guard.
7665         * nat/linux-namespaces.h: Rename include guard.
7666         * nat/linux-btrace.h: Rename include guard.
7667         * nat/glibc_thread_db.h: Rename include guard.
7668         * nat/gdb_thread_db.h: Rename include guard.
7669         * nat/gdb_ptrace.h: Rename include guard.
7670         * nat/fork-inferior.h: Rename include guard.
7671         * nat/amd64-linux-siginfo.h: Rename include guard.
7672         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7673         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7674         * nat/aarch64-linux.h: Rename include guard.
7675         * nat/aarch64-linux-hw-point.h: Rename include guard.
7676         * mn10300-tdep.h: Add include guard.
7677         * mips-linux-tdep.h: Add include guard.
7678         * mi/mi-parse.h: Rename include guard.
7679         * mi/mi-out.h: Rename include guard.
7680         * mi/mi-main.h: Rename include guard.
7681         * mi/mi-interp.h: Rename include guard.
7682         * mi/mi-getopt.h: Rename include guard.
7683         * mi/mi-console.h: Rename include guard.
7684         * mi/mi-common.h: Rename include guard.
7685         * mi/mi-cmds.h: Rename include guard.
7686         * mi/mi-cmd-break.h: Rename include guard.
7687         * m2-lang.h: Add include guard.
7688         * location.h: Rename include guard.
7689         * linux-record.h: Rename include guard.
7690         * linux-nat.h: Add include guard.
7691         * linux-fork.h: Add include guard.
7692         * i386-darwin-tdep.h: Rename include guard.
7693         * hppa-linux-offsets.h: Add include guard.
7694         * guile/guile.h: Rename include guard.
7695         * guile/guile-internal.h: Rename include guard.
7696         * gnu-nat.h: Rename include guard.
7697         * gdb-stabs.h: Rename include guard.
7698         * frv-tdep.h: Add include guard.
7699         * f-lang.h: Add include guard.
7700         * event-loop.h: Add include guard.
7701         * darwin-nat.h: Rename include guard.
7702         * cp-abi.h: Rename include guard.
7703         * config/sparc/nm-sol2.h: Rename include guard.
7704         * config/nm-nto.h: Rename include guard.
7705         * config/nm-linux.h: Add include guard.
7706         * config/i386/nm-i386gnu.h: Rename include guard.
7707         * config/djgpp/nl_types.h: Rename include guard.
7708         * config/djgpp/langinfo.h: Rename include guard.
7709         * compile/gcc-cp-plugin.h: Add include guard.
7710         * compile/gcc-c-plugin.h: Add include guard.
7711         * compile/compile.h: Rename include guard.
7712         * compile/compile-object-run.h: Rename include guard.
7713         * compile/compile-object-load.h: Rename include guard.
7714         * compile/compile-internal.h: Rename include guard.
7715         * compile/compile-cplus.h: Rename include guard.
7716         * compile/compile-c.h: Rename include guard.
7717         * common/xml-utils.h: Rename include guard.
7718         * common/x86-xstate.h: Rename include guard.
7719         * common/version.h: Rename include guard.
7720         * common/vec.h: Rename include guard.
7721         * common/tdesc.h: Rename include guard.
7722         * common/selftest.h: Rename include guard.
7723         * common/scoped_restore.h: Rename include guard.
7724         * common/scoped_mmap.h: Rename include guard.
7725         * common/scoped_fd.h: Rename include guard.
7726         * common/safe-iterator.h: Rename include guard.
7727         * common/run-time-clock.h: Rename include guard.
7728         * common/refcounted-object.h: Rename include guard.
7729         * common/queue.h: Rename include guard.
7730         * common/ptid.h: Rename include guard.
7731         * common/print-utils.h: Rename include guard.
7732         * common/preprocessor.h: Rename include guard.
7733         * common/pathstuff.h: Rename include guard.
7734         * common/observable.h: Rename include guard.
7735         * common/netstuff.h: Rename include guard.
7736         * common/job-control.h: Rename include guard.
7737         * common/host-defs.h: Rename include guard.
7738         * common/gdb_wait.h: Rename include guard.
7739         * common/gdb_vecs.h: Rename include guard.
7740         * common/gdb_unlinker.h: Rename include guard.
7741         * common/gdb_unique_ptr.h: Rename include guard.
7742         * common/gdb_tilde_expand.h: Rename include guard.
7743         * common/gdb_sys_time.h: Rename include guard.
7744         * common/gdb_string_view.h: Rename include guard.
7745         * common/gdb_splay_tree.h: Rename include guard.
7746         * common/gdb_setjmp.h: Rename include guard.
7747         * common/gdb_ref_ptr.h: Rename include guard.
7748         * common/gdb_optional.h: Rename include guard.
7749         * common/gdb_locale.h: Rename include guard.
7750         * common/gdb_assert.h: Rename include guard.
7751         * common/filtered-iterator.h: Rename include guard.
7752         * common/filestuff.h: Rename include guard.
7753         * common/fileio.h: Rename include guard.
7754         * common/environ.h: Rename include guard.
7755         * common/common-utils.h: Rename include guard.
7756         * common/common-types.h: Rename include guard.
7757         * common/common-regcache.h: Rename include guard.
7758         * common/common-inferior.h: Rename include guard.
7759         * common/common-gdbthread.h: Rename include guard.
7760         * common/common-exceptions.h: Rename include guard.
7761         * common/common-defs.h: Rename include guard.
7762         * common/common-debug.h: Rename include guard.
7763         * common/cleanups.h: Rename include guard.
7764         * common/buffer.h: Rename include guard.
7765         * common/btrace-common.h: Rename include guard.
7766         * common/break-common.h: Rename include guard.
7767         * cli/cli-utils.h: Rename include guard.
7768         * cli/cli-style.h: Rename include guard.
7769         * cli/cli-setshow.h: Rename include guard.
7770         * cli/cli-script.h: Rename include guard.
7771         * cli/cli-interp.h: Rename include guard.
7772         * cli/cli-decode.h: Rename include guard.
7773         * cli/cli-cmds.h: Rename include guard.
7774         * charset-list.h: Add include guard.
7775         * buildsym-legacy.h: Rename include guard.
7776         * bfin-tdep.h: Add include guard.
7777         * ax.h: Rename include guard.
7778         * arm-linux-tdep.h: Add include guard.
7779         * arm-fbsd-tdep.h: Add include guard.
7780         * arch/xtensa.h: Rename include guard.
7781         * arch/tic6x.h: Add include guard.
7782         * arch/i386.h: Add include guard.
7783         * arch/arm.h: Rename include guard.
7784         * arch/arm-linux.h: Rename include guard.
7785         * arch/arm-get-next-pcs.h: Rename include guard.
7786         * arch/amd64.h: Add include guard.
7787         * arch/aarch64-insn.h: Rename include guard.
7788         * arch-utils.h: Rename include guard.
7789         * annotate.h: Add include guard.
7790         * amd64-darwin-tdep.h: Rename include guard.
7791         * aarch64-linux-tdep.h: Add include guard.
7792         * aarch64-fbsd-tdep.h: Add include guard.
7793         * aarch32-linux-nat.h: Add include guard.
7794
7795 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7796
7797         * macrotab.c (macro_define_internal): New function that
7798         factorizes macro_define_object_internal and macro_define_function
7799         code.
7800         (macro_define_object_internal): Use macro_define_internal.
7801         (macro_define_function): Likewise.
7802
7803 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7804
7805         * macrocmd.c (extract_identifier): Return
7806         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7807         callers.
7808
7809 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7810
7811         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7812
7813 2019-02-05  Tom Tromey  <tom@tromey.com>
7814
7815         * target.c (target_stack::unpush): Move assertion earlier.
7816
7817 2019-01-30  Tom Tromey  <tom@tromey.com>
7818
7819         PR python/23615:
7820         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7821         (gdbpy_parse_and_eval): Likewise.
7822         * python/python-internal.h (gdbpy_allow_threads): New class.
7823
7824 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7825
7826         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7827         (aarch64_fbsd_fpregmap): Move earlier.
7828         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7829         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7830         instead of individual calls to trad_frame_set_reg_addr.
7831         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7832         earlier.
7833         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7834         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7835         instead of individual calls to trad_frame_set_reg_addr.
7836
7837 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7838
7839         * CONTRIBUTE: Replace contribution list with wiki link.
7840
7841 2019-01-25  Tom Tromey  <tom@tromey.com>
7842
7843         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7844
7845 2019-01-25  Tom Tromey  <tom@tromey.com>
7846
7847         * xtensa-linux-nat.c: Fix common/ includes.
7848         * xml-support.h: Fix common/ includes.
7849         * xml-support.c: Fix common/ includes.
7850         * x86-linux-nat.c: Fix common/ includes.
7851         * windows-nat.c: Fix common/ includes.
7852         * varobj.h: Fix common/ includes.
7853         * varobj.c: Fix common/ includes.
7854         * value.c: Fix common/ includes.
7855         * valops.c: Fix common/ includes.
7856         * utils.c: Fix common/ includes.
7857         * unittests/xml-utils-selftests.c: Fix common/ includes.
7858         * unittests/utils-selftests.c: Fix common/ includes.
7859         * unittests/unpack-selftests.c: Fix common/ includes.
7860         * unittests/tracepoint-selftests.c: Fix common/ includes.
7861         * unittests/style-selftests.c: Fix common/ includes.
7862         * unittests/string_view-selftests.c: Fix common/ includes.
7863         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7864         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7865         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7866         * unittests/rsp-low-selftests.c: Fix common/ includes.
7867         * unittests/parse-connection-spec-selftests.c: Fix common/
7868         includes.
7869         * unittests/optional-selftests.c: Fix common/ includes.
7870         * unittests/offset-type-selftests.c: Fix common/ includes.
7871         * unittests/observable-selftests.c: Fix common/ includes.
7872         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7873         * unittests/memrange-selftests.c: Fix common/ includes.
7874         * unittests/memory-map-selftests.c: Fix common/ includes.
7875         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7876         * unittests/function-view-selftests.c: Fix common/ includes.
7877         * unittests/environ-selftests.c: Fix common/ includes.
7878         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7879         * unittests/common-utils-selftests.c: Fix common/ includes.
7880         * unittests/cli-utils-selftests.c: Fix common/ includes.
7881         * unittests/array-view-selftests.c: Fix common/ includes.
7882         * ui-file.c: Fix common/ includes.
7883         * tui/tui-io.c: Fix common/ includes.
7884         * tracepoint.h: Fix common/ includes.
7885         * tracepoint.c: Fix common/ includes.
7886         * tracefile-tfile.c: Fix common/ includes.
7887         * top.h: Fix common/ includes.
7888         * top.c: Fix common/ includes.
7889         * thread.c: Fix common/ includes.
7890         * target/waitstatus.h: Fix common/ includes.
7891         * target/waitstatus.c: Fix common/ includes.
7892         * target.h: Fix common/ includes.
7893         * target.c: Fix common/ includes.
7894         * target-memory.c: Fix common/ includes.
7895         * target-descriptions.c: Fix common/ includes.
7896         * symtab.h: Fix common/ includes.
7897         * symfile.c: Fix common/ includes.
7898         * stap-probe.c: Fix common/ includes.
7899         * spu-linux-nat.c: Fix common/ includes.
7900         * sparc-nat.c: Fix common/ includes.
7901         * source.c: Fix common/ includes.
7902         * solib.c: Fix common/ includes.
7903         * solib-target.c: Fix common/ includes.
7904         * ser-unix.c: Fix common/ includes.
7905         * ser-tcp.c: Fix common/ includes.
7906         * ser-pipe.c: Fix common/ includes.
7907         * ser-base.c: Fix common/ includes.
7908         * selftest-arch.c: Fix common/ includes.
7909         * s12z-tdep.c: Fix common/ includes.
7910         * rust-exp.y: Fix common/ includes.
7911         * rs6000-aix-tdep.c: Fix common/ includes.
7912         * riscv-tdep.c: Fix common/ includes.
7913         * remote.c: Fix common/ includes.
7914         * remote-notif.h: Fix common/ includes.
7915         * remote-fileio.h: Fix common/ includes.
7916         * remote-fileio.c: Fix common/ includes.
7917         * regcache.h: Fix common/ includes.
7918         * regcache.c: Fix common/ includes.
7919         * record-btrace.c: Fix common/ includes.
7920         * python/python.c: Fix common/ includes.
7921         * python/py-type.c: Fix common/ includes.
7922         * python/py-inferior.c: Fix common/ includes.
7923         * progspace.h: Fix common/ includes.
7924         * producer.c: Fix common/ includes.
7925         * procfs.c: Fix common/ includes.
7926         * proc-api.c: Fix common/ includes.
7927         * printcmd.c: Fix common/ includes.
7928         * ppc-linux-nat.c: Fix common/ includes.
7929         * parser-defs.h: Fix common/ includes.
7930         * osdata.c: Fix common/ includes.
7931         * obsd-nat.c: Fix common/ includes.
7932         * nat/x86-linux.c: Fix common/ includes.
7933         * nat/x86-linux-dregs.c: Fix common/ includes.
7934         * nat/x86-dregs.h: Fix common/ includes.
7935         * nat/x86-dregs.c: Fix common/ includes.
7936         * nat/ppc-linux.c: Fix common/ includes.
7937         * nat/mips-linux-watch.h: Fix common/ includes.
7938         * nat/mips-linux-watch.c: Fix common/ includes.
7939         * nat/linux-waitpid.c: Fix common/ includes.
7940         * nat/linux-ptrace.h: Fix common/ includes.
7941         * nat/linux-ptrace.c: Fix common/ includes.
7942         * nat/linux-procfs.c: Fix common/ includes.
7943         * nat/linux-personality.c: Fix common/ includes.
7944         * nat/linux-osdata.c: Fix common/ includes.
7945         * nat/linux-namespaces.c: Fix common/ includes.
7946         * nat/linux-btrace.h: Fix common/ includes.
7947         * nat/linux-btrace.c: Fix common/ includes.
7948         * nat/fork-inferior.c: Fix common/ includes.
7949         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7950         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7951         * nat/aarch64-linux.c: Fix common/ includes.
7952         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7953         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7954         * namespace.h: Fix common/ includes.
7955         * mips-linux-tdep.c: Fix common/ includes.
7956         * minsyms.c: Fix common/ includes.
7957         * mi/mi-parse.h: Fix common/ includes.
7958         * mi/mi-main.c: Fix common/ includes.
7959         * mi/mi-cmd-env.c: Fix common/ includes.
7960         * memrange.h: Fix common/ includes.
7961         * memattr.c: Fix common/ includes.
7962         * maint.h: Fix common/ includes.
7963         * maint.c: Fix common/ includes.
7964         * main.c: Fix common/ includes.
7965         * machoread.c: Fix common/ includes.
7966         * location.c: Fix common/ includes.
7967         * linux-thread-db.c: Fix common/ includes.
7968         * linux-nat.c: Fix common/ includes.
7969         * linux-fork.c: Fix common/ includes.
7970         * inline-frame.c: Fix common/ includes.
7971         * infrun.c: Fix common/ includes.
7972         * inflow.c: Fix common/ includes.
7973         * inferior.h: Fix common/ includes.
7974         * inferior.c: Fix common/ includes.
7975         * infcmd.c: Fix common/ includes.
7976         * inf-ptrace.c: Fix common/ includes.
7977         * inf-child.c: Fix common/ includes.
7978         * ia64-linux-nat.c: Fix common/ includes.
7979         * i387-tdep.c: Fix common/ includes.
7980         * i386-tdep.c: Fix common/ includes.
7981         * i386-linux-tdep.c: Fix common/ includes.
7982         * i386-linux-nat.c: Fix common/ includes.
7983         * i386-go32-tdep.c: Fix common/ includes.
7984         * i386-fbsd-tdep.c: Fix common/ includes.
7985         * i386-fbsd-nat.c: Fix common/ includes.
7986         * guile/scm-type.c: Fix common/ includes.
7987         * guile/guile.c: Fix common/ includes.
7988         * go32-nat.c: Fix common/ includes.
7989         * gnu-nat.c: Fix common/ includes.
7990         * gdbthread.h: Fix common/ includes.
7991         * gdbarch-selftests.c: Fix common/ includes.
7992         * gdb_usleep.c: Fix common/ includes.
7993         * gdb_select.h: Fix common/ includes.
7994         * gdb_bfd.c: Fix common/ includes.
7995         * gcore.c: Fix common/ includes.
7996         * fork-child.c: Fix common/ includes.
7997         * findvar.c: Fix common/ includes.
7998         * fbsd-nat.c: Fix common/ includes.
7999         * event-top.c: Fix common/ includes.
8000         * event-loop.c: Fix common/ includes.
8001         * dwarf2read.c: Fix common/ includes.
8002         * dwarf2loc.c: Fix common/ includes.
8003         * dwarf2-frame.c: Fix common/ includes.
8004         * dwarf-index-cache.c: Fix common/ includes.
8005         * dtrace-probe.c: Fix common/ includes.
8006         * disasm-selftests.c: Fix common/ includes.
8007         * defs.h: Fix common/ includes.
8008         * csky-tdep.c: Fix common/ includes.
8009         * cp-valprint.c: Fix common/ includes.
8010         * cp-support.h: Fix common/ includes.
8011         * cp-support.c: Fix common/ includes.
8012         * corelow.c: Fix common/ includes.
8013         * completer.h: Fix common/ includes.
8014         * completer.c: Fix common/ includes.
8015         * compile/compile.c: Fix common/ includes.
8016         * compile/compile-loc2c.c: Fix common/ includes.
8017         * compile/compile-cplus-types.c: Fix common/ includes.
8018         * compile/compile-cplus-symbols.c: Fix common/ includes.
8019         * command.h: Fix common/ includes.
8020         * cli/cli-dump.c: Fix common/ includes.
8021         * cli/cli-cmds.c: Fix common/ includes.
8022         * charset.c: Fix common/ includes.
8023         * build-id.c: Fix common/ includes.
8024         * btrace.h: Fix common/ includes.
8025         * btrace.c: Fix common/ includes.
8026         * breakpoint.h: Fix common/ includes.
8027         * breakpoint.c: Fix common/ includes.
8028         * ax.h:
8029         (enum agent_op): Fix common/ includes.
8030         * ax-general.c (struct aop_map): Fix common/ includes.
8031         * ax-gdb.c: Fix common/ includes.
8032         * auxv.c: Fix common/ includes.
8033         * auto-load.c: Fix common/ includes.
8034         * arm-tdep.c: Fix common/ includes.
8035         * arch/riscv.c: Fix common/ includes.
8036         * arch/ppc-linux-common.c: Fix common/ includes.
8037         * arch/i386.c: Fix common/ includes.
8038         * arch/arm.c: Fix common/ includes.
8039         * arch/arm-linux.c: Fix common/ includes.
8040         * arch/arm-get-next-pcs.c: Fix common/ includes.
8041         * arch/amd64.c: Fix common/ includes.
8042         * arch/aarch64.c: Fix common/ includes.
8043         * arch/aarch64-insn.c: Fix common/ includes.
8044         * arch-utils.c: Fix common/ includes.
8045         * amd64-windows-tdep.c: Fix common/ includes.
8046         * amd64-tdep.c: Fix common/ includes.
8047         * amd64-sol2-tdep.c: Fix common/ includes.
8048         * amd64-obsd-tdep.c: Fix common/ includes.
8049         * amd64-nbsd-tdep.c: Fix common/ includes.
8050         * amd64-linux-tdep.c: Fix common/ includes.
8051         * amd64-linux-nat.c: Fix common/ includes.
8052         * amd64-fbsd-tdep.c: Fix common/ includes.
8053         * amd64-fbsd-nat.c: Fix common/ includes.
8054         * amd64-dicos-tdep.c: Fix common/ includes.
8055         * amd64-darwin-tdep.c: Fix common/ includes.
8056         * agent.c: Fix common/ includes.
8057         * ada-lang.h: Fix common/ includes.
8058         * ada-lang.c: Fix common/ includes.
8059         * aarch64-tdep.c: Fix common/ includes.
8060
8061 2019-01-25  Tom Tromey  <tom@tromey.com>
8062
8063         * common/create-version.sh: Use common/version.h.
8064
8065 2019-01-24  Pedro Alves  <palves@redhat.com>
8066
8067         * infrun.c (signal_stop, signal_print, signal_program)
8068         (signal_catch, signal_pass): Now arrays instead of pointers.
8069         (update_signals_program_target, do_target_resume)
8070         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8071         * linux-nat.c (linux_nat_target::pass_signals)
8072         (linux_nat_target::create_inferior, linux_nat_target::attach):
8073         Adjust.
8074         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8075         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8076         * procfs.c (procfs_target::pass_signals): Adjust.
8077         * record-full.c (record_full_target::resume): Adjust.
8078         * remote.c (remote_target::pass_signals)
8079         (remote_target::program_signals): Adjust.
8080         * target-debug.h (target_debug_print_signals): Now takes a
8081         gdb::array_view as parameter.  Adjust.
8082         * target.h (target_ops) <pass_signals, program_signals>: Replace
8083         pointer and length parameters with gdb::array_view.
8084         (target_pass_signals, target_program_signals): Likewise.
8085         * target-delegates.c: Regenerate.
8086
8087 2019-01-24  Pedro Alves  <palves@redhat.com>
8088
8089         * common/forward-scope-exit.h
8090         (forward_scope_exit::forward_scope_exit): Pass arguments to
8091         m_bind_function directly, instead of creating a std::bind and
8092         copying that.
8093
8094 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8095
8096         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8097         for static members.
8098         (pass_in_v_vfp_candidate): Likewise.
8099
8100 2019-01-23  Tom Tromey  <tom@tromey.com>
8101             Pedro Alves  <palves@redhat.com>
8102
8103         * regcache.c (class regcache_invalidator): Remove.
8104         (regcache::raw_write): Use make_scope_exit.
8105
8106 2019-01-23  Tom Tromey  <tom@tromey.com>
8107
8108         * ui-out.h (class ui_out_emit_type): Update comment.
8109
8110 2019-01-23  Tom Tromey  <tom@tromey.com>
8111
8112         * infrun.c (fetch_inferior_event): Update comment.
8113
8114 2019-01-23  Tom Tromey  <tom@tromey.com>
8115             Pedro Alves  <palves@redhat.com>
8116
8117         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8118         parameter.
8119         (fetch_inferior_event): Use SCOPE_EXIT.
8120
8121
8122 2019-01-23  Tom Tromey  <tom@tromey.com>
8123             Pedro Alves  <palves@redhat.com>
8124
8125         * infrun.c (disable_thread_events): Delete.
8126         (stop_all_threads): Use SCOPE_EXIT.
8127
8128 2019-01-23  Tom Tromey  <tom@tromey.com>
8129             Pedro Alves  <palves@redhat.com>
8130
8131         * symfile.c: Include forward-scope-exit.h.
8132         (clear_symtab_users_cleanup): Replace forward declaration with
8133         a FORWARD_SCOPE_EXIT.
8134         (syms_from_objfile_1): Use the forward_scope_exit and
8135         gdb::optional instead of cleanup_function.
8136         (reread_symbols): Use the forward_scope_exit instead of
8137         cleanup_function.
8138         (clear_symtab_users_cleanup): Remove function.
8139
8140 2019-01-23  Tom Tromey  <tom@tromey.com>
8141             Pedro Alves  <palves@redhat.com>
8142
8143         * linux-nat.c: Include scope-exit.h.
8144         (cleanup_target_stop): Remove.
8145         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8146         SCOPE_EXIT.
8147
8148 2019-01-23  Tom Tromey  <tom@tromey.com>
8149             Pedro Alves  <palves@redhat.com>
8150
8151         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8152         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8153
8154 2019-01-23  Tom Tromey  <tom@tromey.com>
8155             Andrew Burgess  <andrew.burgess@embecosm.com>
8156             Pedro Alves  <palves@redhat.com>
8157
8158         * infrun.c (fetch_inferior_event): Use scope_exit.
8159         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8160         * top.c (execute_command): Use scope_exit.
8161         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8162         * utils.c (do_bpstat_clear_actions_cleanup)
8163         (make_bpstat_clear_actions_cleanup): Remove.
8164
8165 2019-01-23  Tom Tromey  <tom@tromey.com>
8166             Pedro Alves  <palves@redhat.com>
8167
8168         * infrun.c: Include "common/scope-exit.h"
8169         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8170         (wait_for_inferior): Use SCOPE_EXIT.
8171         (fetch_inferior_event): Use scope_exit.
8172
8173 2019-01-23  Tom Tromey  <tom@tromey.com>
8174             Pedro Alves  <palves@redhat.com>
8175
8176         * breakpoint.c (create_breakpoint): Remove cleanup.
8177
8178 2019-01-23  Tom Tromey  <tom@tromey.com>
8179             Andrew Burgess  <andrew.burgess@embecosm.com>
8180             Pedro Alves  <palves@redhat.com>
8181
8182 2019-01-23  Pedro Alves  <palves@redhat.com>
8183
8184         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8185
8186 2019-01-23  Pedro Alves  <palves@redhat.com>
8187             Andrew Burgess  <andrew.burgess@embecosm.com>
8188
8189         * gdbthread.h: Include "common/forward-scope-exit.h".
8190         (scoped_finish_thread_state): Redefine custom class in terms of
8191         forward_scope_exit.
8192
8193 2019-01-23  Pedro Alves  <palves@redhat.com>
8194             Andrew Burgess  <andrew.burgess@embecosm.com>
8195
8196         * common/forward-scope-exit.h: New file.
8197
8198 2019-01-23  Pedro Alves  <palves@redhat.com>
8199             Andrew Burgess  <andrew.burgess@embecosm.com>
8200             Tom Tromey  <tom@tromey.com>
8201
8202         * common/scope-exit.h: New file.
8203
8204 2019-01-23  Pedro Alves  <palves@redhat.com>
8205
8206         * common/preprocessor.h (ESC): Rename to ...
8207         (ESC_PARENS): ... this.
8208         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8209         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8210
8211 2019-01-23  Tom Tromey  <tom@tromey.com>
8212
8213         * language.h (class scoped_switch_to_sym_language_if_auto):
8214         Initialize m_lang in both cases.
8215
8216 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8217
8218         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8219         with XCNEW.
8220
8221 2019-01-22  Tom Tromey  <tom@tromey.com>
8222
8223         * corelow.c: Do not include sys/file.h.
8224
8225 2019-01-22  Tom Tromey  <tom@tromey.com>
8226
8227         * tui/tui-wingeneral.h: Include gdb_curses.h.
8228
8229 2019-01-22  Tom Tromey  <tom@tromey.com>
8230
8231         * source-cache.h (class source_cache) <get_source_lines,
8232         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8233
8234 2019-01-22  Tom Tromey  <tom@tromey.com>
8235
8236         * remote-fileio.h (struct remote_target): Declare.
8237
8238 2019-01-22  Tom Tromey  <tom@tromey.com>
8239
8240         * python/py-arch.c: Do not include py-ref.h.
8241         * python/py-bpevent.c: Do not include py-ref.h.
8242         * python/py-cmd.c: Do not include py-ref.h.
8243         * python/py-continueevent.c: Do not include py-ref.h.
8244         * python/py-event.h: Do not include py-ref.h.
8245         * python/py-evtregistry.c: Do not include py-ref.h.
8246         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8247         * python/py-frame.c: Do not include py-ref.h.
8248         * python/py-framefilter.c: Do not include py-ref.h.
8249         * python/py-function.c: Do not include py-ref.h.
8250         * python/py-infevents.c: Do not include py-ref.h.
8251         * python/py-linetable.c: Do not include py-ref.h.
8252         * python/py-objfile.c: Do not include py-ref.h.
8253         * python/py-param.c: Do not include py-ref.h.
8254         * python/py-prettyprint.c: Do not include py-ref.h.
8255         * python/py-progspace.c: Do not include py-ref.h.
8256         * python/py-symbol.c: Do not include py-ref.h.
8257         * python/py-symtab.c: Do not include py-ref.h.
8258         * python/py-type.c: Do not include py-ref.h.
8259         * python/py-unwind.c: Do not include py-ref.h.
8260         * python/py-utils.c: Do not include py-ref.h.
8261         * python/py-value.c: Do not include py-ref.h.
8262         * python/py-varobj.c: Do not include py-ref.h.
8263         * python/py-xmethods.c: Do not include py-ref.h.
8264         * python/python.c: Do not include py-ref.h.
8265         * varobj.c: Do not include py-ref.h.
8266
8267 2019-01-22  Tom Tromey  <tom@tromey.com>
8268
8269         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8270         keyword for bcache.
8271
8272 2019-01-22  Tom Tromey  <tom@tromey.com>
8273
8274         * compile/compile-cplus-types.c: Remove a comment by #include.
8275
8276 2019-01-22  Tom Tromey  <tom@tromey.com>
8277
8278         * compile/gcc-c-plugin.h: Include compile-internal.h.
8279
8280 2019-01-22  Tom Tromey  <tom@tromey.com>
8281
8282         * stabsread.c (EXTERN): Do not define.
8283         (symnum, next_symbol_text_func, processing_gcc_compilation)
8284         (within_function, global_sym_chain, global_stabs)
8285         (previous_stab_code, this_object_header_files)
8286         (n_this_object_header_files)
8287         (n_allocated_this_object_header_files): Define.
8288         * stabsread.h (EXTERN): Never define.  Use "extern".
8289
8290 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8291
8292         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8293         history_value.
8294
8295 2019-01-21  Tom Tromey  <tom@tromey.com>
8296
8297         * ui-out.c: Fix includes.
8298         * tui/tui-source.c: Fix includes.
8299         * target.c: Fix includes.
8300         * remote.c: Fix includes.
8301         * regcache.c: Fix includes.
8302         * python/py-block.c: Fix includes.
8303         * printcmd.c: Fix includes.
8304         * or1k-tdep.c: Fix includes.
8305         * mi/mi-main.c: Fix includes.
8306         * m32r-tdep.c: Fix includes.
8307         * csky-tdep.c: Fix includes.
8308         * compile/compile-cplus-types.c: Fix includes.
8309         * cli/cli-interp.c: Fix includes.
8310
8311 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8312
8313         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8314         for padding.
8315
8316 2019-01-16  Tom Tromey  <tom@tromey.com>
8317
8318         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8319         earlier.
8320         (struct objfile) <msymbols_range>: Move from top level.
8321         <msymbols>: New method.
8322         (class objfile_msymbols): Remove.
8323         * symtab.c (default_collect_symbol_completion_matches_break_on):
8324         Update.
8325         * symmisc.c (dump_msymbols): Update.
8326         * stabsread.c (scan_file_globals): Update.
8327         * objc-lang.c (info_selectors_command, info_classes_command)
8328         (find_methods): Update.
8329         * minsyms.c (find_solib_trampoline_target): Update.
8330         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8331         * coffread.c (coff_symfile_read): Update.
8332         * ada-lang.c (ada_lookup_simple_minsym)
8333         (ada_collect_symbol_completion_matches): Update.
8334
8335 2019-01-16  Tom Tromey  <tom@tromey.com>
8336
8337         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8338         type.  Remove no-argument constructor.
8339         <iterator::operator++>: Simplify.
8340         <begin>: Update.
8341         <end>: Use minimal_symbol_count.
8342
8343 2019-01-16  Tom Tromey  <tom@tromey.com>
8344
8345         * objfiles.h (struct objfile) <psymtabs>: New method.
8346         (class objfile_psymtabs): Remove.
8347         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8348         typedef.
8349         <range>: New method.
8350         (require_partial_symbols): Change return type.
8351         * psymtab.c (require_partial_symbols)
8352         (psym_expand_symtabs_matching): Update.
8353         * mdebugread.c (parse_partial_symbols): Update.
8354         * dbxread.c (dbx_end_psymtab): Update.
8355
8356 2019-01-15  Tom Tromey  <tom@tromey.com>
8357
8358         * symtab.c (lookup_objfile_from_block)
8359         (lookup_symbol_in_objfile_symtabs)
8360         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8361         (find_line_symtab, info_sources_command)
8362         (default_collect_symbol_completion_matches_break_on)
8363         (make_source_files_completion_list): Update.
8364         * symmisc.c (print_objfile_statistics, dump_objfile)
8365         (maintenance_print_symbols, maintenance_info_symtabs)
8366         (maintenance_check_symtabs, maintenance_info_line_tables):
8367         Update.
8368         * source.c (select_source_symtab)
8369         (forget_cached_source_info_for_objfile): Update.
8370         * objfiles.h (class objfile_compunits): Remove.
8371         (struct objfile) <compunits_range>: New typedef.
8372         (compunits): New method.
8373         * objfiles.c (objfile_relocate1): Update.
8374         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8375         * maint.c (count_symtabs_and_blocks): Update.
8376         * linespec.c (iterate_over_all_matching_symtabs): Update.
8377         * cp-support.c (add_symbol_overload_list_qualified): Update.
8378         * coffread.c (coff_symtab_read): Update.
8379         * ada-lang.c (add_nonlocal_symbols)
8380         (ada_collect_symbol_completion_matches)
8381         (ada_add_global_exceptions): Update.
8382
8383 2019-01-15  Tom Tromey  <tom@tromey.com>
8384
8385         * progspace.h (program_space) <objfiles_safe_range>: New
8386         typedef.
8387         <objfiles_safe>: New method.
8388         * objfiles.h (class all_objfiles_safe): Remove.
8389         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8390         * jit.c (jit_inferior_exit_hook): Update.
8391
8392 2019-01-17  Tom Tromey  <tom@tromey.com>
8393
8394         * progspace.h (program_space) <objfiles_range>: New typedef.
8395         <objfiles>: New method.
8396         <objfiles_head>: Rename from objfiles.
8397         (object_files): Update.
8398         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8399         * guile/scm-pretty-print.c
8400         (ppscm_find_pretty_printer_from_objfiles): Update.
8401         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8402         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8403         Update.
8404         * python/py-progspace.c (pspy_get_objfiles): Update.
8405         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8406         Update.
8407         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8408         (objfpy_lookup_objfile_by_build_id): Update.
8409         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8410         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8411         Update.
8412         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8413         (expand_symtab_containing_pc, lookup_objfile_from_block)
8414         (lookup_static_symbol, basic_lookup_transparent_type)
8415         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8416         (find_line_symtab, info_sources_command)
8417         (default_collect_symbol_completion_matches_break_on)
8418         (make_source_files_completion_list, find_main_name): Update.
8419         * symmisc.c (print_symbol_bcache_statistics)
8420         (print_objfile_statistics, maintenance_print_symbols)
8421         (maintenance_print_msymbols, maintenance_print_objfiles)
8422         (maintenance_info_symtabs, maintenance_check_symtabs)
8423         (maintenance_expand_symtabs, maintenance_info_line_tables):
8424         Update.
8425         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8426         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8427         (map_overlay_command, unmap_overlay_command)
8428         (simple_overlay_update, expand_symtabs_matching)
8429         (map_symbol_filenames): Update.
8430         * symfile-debug.c (set_debug_symfile): Update.
8431         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8432         Update.
8433         * source.c (select_source_symtab, forget_cached_source_info):
8434         Update.
8435         * solib.c (solib_read_symbols): Update.
8436         * solib-spu.c (append_ocl_sos): Update.
8437         * psymtab.c (maintenance_print_psymbols)
8438         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8439         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8440         * printcmd.c (info_symbol_command): Update.
8441         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8442         Update.
8443         * objfiles.h (class all_objfiles): Remove.
8444         * objfiles.c (have_partial_symbols, have_full_symbols)
8445         (have_minimal_symbols, qsort_cmp, update_section_map)
8446         (shared_objfile_contains_address_p)
8447         (default_iterate_over_objfiles_in_search_order): Update.
8448         * objc-lang.c (info_selectors_command, info_classes_command)
8449         (find_methods): Update.
8450         * minsyms.c (find_solib_trampoline_target): Update.
8451         * maint.c (maintenance_info_sections)
8452         (maintenance_translate_address, count_symtabs_and_blocks):
8453         Update.
8454         * main.c (captured_main_1): Update.
8455         * linux-thread-db.c (try_thread_db_load_from_pdir)
8456         (has_libpthread): Update.
8457         * linespec.c (iterate_over_all_matching_symtabs)
8458         (search_minsyms_for_name): Update.
8459         * jit.c (jit_find_objf_with_entry_addr): Update.
8460         * hppa-tdep.c (find_unwind_entry)
8461         (hppa_lookup_stub_minimal_symbol): Update.
8462         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8463         Update.
8464         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8465         (elf_gnu_ifunc_resolve_by_got): Update.
8466         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8467         * dwarf-index-write.c (save_gdb_index_command): Update.
8468         * cp-support.c (add_symbol_overload_list_qualified): Update.
8469         * breakpoint.c (create_overlay_event_breakpoint)
8470         (create_longjmp_master_breakpoint)
8471         (create_std_terminate_master_breakpoint)
8472         (create_exception_master_breakpoint): Update.
8473         * blockframe.c (find_pc_partial_function): Update.
8474         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8475         (ada_collect_symbol_completion_matches)
8476         (ada_add_global_exceptions): Update.
8477
8478 2019-01-17  Tom Tromey  <tom@tromey.com>
8479
8480         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8481         declare VEC.
8482         (solib_target_parse_libraries): Change return type.
8483         (library_list_start_segment, library_list_start_section)
8484         (library_list_end_library, library_list_start_library); Update.
8485         (solib_target_free_library_list): Remove.
8486         (solib_target_parse_libraries): Remove cleanup.  Change return
8487         type.
8488         (solib_target_current_sos): Update.
8489
8490 2019-01-17  Tom Tromey  <tromey@bapiya>
8491
8492         * valprint.c: Replace "the the" with "the".
8493         * symtab.c: Replace "the the" with "the".
8494         * solib.c: Replace "the the" with "the".
8495         * solib-dsbt.c: Replace "the the" with "the".
8496         * linespec.c: Replace "the the" with "the".
8497         * dwarf2loc.h: Replace "the the" with "the".
8498         * amd64-windows-tdep.c: Replace "the the" with "the".
8499         * aarch64-tdep.c: Replace "the the" with "the".
8500
8501 2019-01-16  Keith Seitz  <keiths@redhat.com>
8502
8503         PR gdb/23773
8504         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8505         <builder>: Rename to ..
8506         <m_builder>: ... this and make private.
8507         (dwarf2_cu::get_builder): New method.  Change all users of
8508         `builder' to use this method.
8509         (dwarf2_start_symtab): Move to ...
8510         (dwarf2_cu::start_symtab): ... here.  Update all callers
8511         (setup_type_unit_groups): Move to ...
8512         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8513         callers.
8514         (dwarf2_cu::reset_builder): New method.
8515         (process_full_compunit, process_full_type_unit): Use
8516         dwarf2_cu::reset_builder.
8517         (follow_die_offset): Record the ancestor CU if it is different
8518         from the followed DIE's CU.
8519         (follow_die_sig_1): Likewise.
8520
8521 2019-01-15  Tom Tromey  <tom@tromey.com>
8522
8523         * remote.c (class remote_state) <buf>: Now a char_vector.
8524         <buf_size>: Remove.
8525         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8526         parameter.
8527         (remote_target::getpkt_or_notif_sane_1)
8528         (remote_target::getpkt_sane)
8529         (remote_target::getpkt_or_notif_sane): Likewise.
8530         (class remote_target) <putpkt>: New overload.
8531         (remote_target::read_frame): Change type of "buf_p".  Remove
8532         sizeof_p parameter.
8533         (packet_ok): New overload.
8534         (packet_check_result): New overload.
8535         Update all uses.
8536
8537 2019-01-14  Tom Tromey  <tom@tromey.com>
8538
8539         * remote-notif.c (handle_notification, remote_notif_ack)
8540         (remote_notif_parse): Make "buf" const.
8541         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8542         const.
8543         (remote_notif_parse, remote_notif_ack, handle_notification):
8544         Likewise.
8545         * remote.c (remote_notif_stop_parse): Make "buf" const.
8546         (remote_target::remote_parse_stop_reply): Make "buf" const.
8547         (remote_notif_stop_ack): Make "buf" const.
8548
8549 2019-01-14  Tom Tromey  <tom@tromey.com>
8550
8551         * remote.c (remote_console_output): Make parameter const.
8552
8553 2019-01-14  Tom Tromey  <tom@tromey.com>
8554
8555         * target-debug.h (target_debug_print_signals): Constify.
8556         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8557         * procfs.c (procfs_target::pass_signals): Update.
8558         * linux-nat.c (linux_nat_target::pass_signals): Update.
8559         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8560         * target-delegates.c: Rebuild.
8561         * remote.c (remote_target::program_signals): Update.
8562         (remote_target::pass_signals): Update.
8563         * target.c (target_pass_signals): Constify argument.
8564         (target_program_signals): Likewise.
8565         * target.h (struct target_ops) <pass_signals, program_signals>:
8566         Constify argument.
8567         (target_pass_signals, target_program_signals): Constify argument.
8568
8569 2019-01-14  Tom Tromey  <tom@tromey.com>
8570
8571         PR tui/28819:
8572         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8573
8574 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8575
8576         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8577         field.
8578         * rs6000-tdep.c: Include reggroups.h.
8579         (IS_V_ALIAS_PSEUDOREG): Define.
8580         (rs6000_register_name): Return names for the "vX" aliases.
8581         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8582         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8583         aliases.  Call default_register_reggroup_p for all other
8584         pseudo-registers.
8585         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8586         New functions.
8587         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8588         Handle "vX" aliases.
8589         (v_alias_pseudo_register_collect): New function.
8590         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8591         (rs6000_gdbarch_init): Initialize "vX" aliases as
8592         pseudo-registers.  Restore registration of
8593         rs6000_pseudo_register_reggroup_p with
8594         set_tdesc_pseudo_register_reggroup_p.
8595
8596 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8597
8598         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8599         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8600         set_gdbarch_num_pseudo_regs.
8601
8602 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8603
8604         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8605         Remove arg prefixname, add do_set and do_show.
8606         Add member functions set_list and show_list.
8607         * cli/cli-style.c (class cli_style_option): Update accordingly.
8608         (style_set_list): Move to file scope.
8609         (style_show_list): Likewise.
8610         (set_style): Call help_list.
8611         (show_style): Call cmd_show_list.
8612         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8613         Update to use the new macro.
8614
8615 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8616
8617         * ada-lang.c (_initialize_ada_language): Expand the help text
8618         for the "catch exception" command.
8619
8620 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8621
8622         * symtab.c (matching_obj_sections): Initialize obj,
8623         declare it closer to its usage.
8624
8625 2019-01-10  Tom Tromey  <tom@tromey.com>
8626
8627         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8628         (basic_inf_threads_range): Remove.
8629         (inf_threads_range, inf_non_exited_threads_range)
8630         (safe_inf_threads_range): Use next_adapter.
8631
8632 2019-01-10  Keith Seitz  <keiths@redhat.com>
8633
8634         PR gdb/23712
8635         PR symtab/23010
8636         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8637         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8638
8639 2019-01-10  Keith Seitz  <keiths@redhat.com>
8640
8641         PR gdb/23712
8642         PR symtab/23010
8643         * dictionary.c (pending_to_vector): Remove.
8644         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8645         Remove _1 suffix, replacing functions of the same name.  Update
8646         all callers.
8647         (dict_create_hashed, dict_create_hashed_expandable)
8648         (dict_create_linear, dict_create_linear_expandable, dict_free)
8649         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8650         Make functions static.
8651
8652 2019-01-10  Keith Seitz  <keiths@redhat.com>
8653
8654         PR gdb/23712
8655         PR symtab/23010
8656         * dictionary.h (struct dictionary): Replace declaration with
8657         multidictionary.
8658         (dict_create_hashed, dict_create_hashed_expandable)
8659         (dict_create_linear, dict_create_linear_expandable)
8660         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8661         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8662         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8663         taking multidictionary argument.
8664         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8665         * block.h (struct block) <dict>: Change to multidictionary
8666         and rename `multidict'.
8667         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8668         symmisc.c: Update all dictionary references to multidictionary.
8669
8670 2019-01-10  Keith Seitz  <keiths@redhat.com>
8671
8672         PR gdb/23712
8673         PR symtab/23010
8674         * dictionary.c: Include unordered_map.
8675         (pending_to_vector): New function.
8676         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8677         Rewrite the non-"_1" functions to take vector instead
8678         of linked list.
8679         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8680         "new" _1 versions of the same name.
8681         (multidictionary): Define.
8682         (std::hash<enum language): New definition.
8683         (collate_pending_symbols_by_language, mdict_create_hashed)
8684         (mdict_create_hashed_expandable, mdict_create_linear)
8685         (mdict_create_linear_expandable, mdict_free)
8686         (find_language_dictionary, create_new_language_dictionary)
8687         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8688         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8689         (mdict_size, mdict_empty): New functions.
8690         * dictionary.h (mdict_iterator): Define.
8691
8692 2019-01-10  Pedro Alves  <palves@redhat.com>
8693
8694         * breakpoint.c (read_uploaded_action)
8695         (create_tracepoint_from_upload): Adjust to use
8696         gdb::unique_xmalloc_ptr.
8697         * ctf.c (ctf_write_uploaded_tp):
8698         (SET_ARRAY_FIELD): Use emplace_back.
8699         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8700         * tracefile-tfile.c (tfile_write_uploaded_tp):
8701         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8702         gdb::unique_xmalloc_ptr.
8703         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8704         at_string, cond_string, cmd_strings>: Replace char pointers
8705         with gdb::unique_xmalloc_ptr.
8706
8707 2019-01-10  Pedro Alves  <palves@redhat.com>
8708
8709         * solib-target.c (library_list_start_library): Don't xstrdup name.
8710
8711 2019-01-10  Pedro Alves  <palves@redhat.com>
8712
8713         * mdebugread.c (parse_partial_symbols): Use
8714         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8715
8716 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8717
8718         * linux-fork.c (scoped_switch_fork_info)
8719         <~scoped_switch_fork_info>: Fix incorrect variable name.
8720
8721 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8722
8723         * linux-fork.c (scoped_switch_fork_info)
8724         <scoped_switch_fork_info>: Make explicit.
8725         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8726
8727 2019-01-10  Tom Tromey  <tom@tromey.com>
8728
8729         * objfiles.h (objfile::reset_psymtabs): Update.
8730         * objfiles.c (objfile::objfile): Update.
8731         * psymtab.h (psymtab_storage::obstack): Update.
8732         (psymtab_storage::m_obstack): Use gdb::optional.
8733         (class psymtab_storage): Update comment.  Remove objfile
8734         parameter.
8735         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8736
8737 2019-01-10  Tom Tromey  <tom@tromey.com>
8738
8739         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8740         <free_psymtabs>: Now private.
8741         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8742         (allocate_psymtab): Use new method.
8743
8744 2019-01-10  Tom Tromey  <tom@tromey.com>
8745
8746         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8747         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8748         * mdebugread.c (parse_partial_symbols): Use
8749         allocate_dependencies.
8750         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8751         allocate_dependencies.
8752         (process_psymtab_comp_unit_reader)
8753         (build_type_psymtab_dependencies): Likewise.
8754         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8755
8756 2019-01-10  Tom Tromey  <tom@tromey.com>
8757
8758         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8759         PSYMBOL_SET_LANGUAGE.
8760         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8761
8762 2019-01-10  Tom Tromey  <tom@tromey.com>
8763
8764         * psymtab.h (psymtab_storage::obstack): New method.
8765         <m_obstack>: Rename from obstack; now private.
8766         * psymtab.c (psymtab_storage): Update.
8767         * dwarf2read.c (create_addrmap_from_index)
8768         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8769         Update.
8770
8771 2019-01-10  Tom Tromey  <tom@tromey.com>
8772
8773         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8774         * objfiles.h (objfile::reset_psymtabs): New method.
8775
8776 2019-01-10  Tom Tromey  <tom@tromey.com>
8777
8778         * symmisc.c (print_symbol_bcache_statistics): Update.
8779         (print_objfile_statistics): Update.
8780         * symfile.c (reread_symbols): Update.
8781         * psymtab.h (class psymtab_storage): New.
8782         * psymtab.c (psymtab_storage): New constructor.
8783         (~psymtab_storage): New destructor.
8784         (require_partial_symbols): Update.
8785         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8786         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8787         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8788         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8789         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8790         (start_psymtab_common, end_psymtab_common)
8791         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8792         (allocate_psymtab): Update.
8793         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8794         Update.
8795         (dump_psymtab_addrmap, maintenance_print_psymbols)
8796         (maintenance_check_psymtabs): Update.
8797         (class objfile_psymtabs): Move to objfiles.h.
8798         * psympriv.h (discard_psymtab): Now inline.
8799         (psymtab_discarder::psymtab_discarder): Update.
8800         (psymtab_discarder::~psymtab_discarder): Update.
8801         (ALL_OBJFILE_PSYMTABS): Rewrite.
8802         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8803         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8804         Remove fields.
8805         <partial_symtabs>: New field.
8806         (class objfile_psymtabs): Move from psymtab.h.  Update.
8807         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8808         psymbol_cache.
8809         (objfile::~objfile): Don't destroy psymbol_cache.
8810         * mdebugread.c (parse_partial_symbols): Update.
8811         * dwarf2read.c (create_addrmap_from_index)
8812         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8813         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8814         (add_partial_subprogram, dwarf2_ranges_read): Update.
8815         * dwarf-index-write.c (write_address_map)
8816         (write_one_signatured_type, recursively_write_psymbols)
8817         (class debug_names, class debug_names, write_psymtabs_to_index):
8818         Update.
8819
8820 2019-01-10  Tom Tromey  <tom@tromey.com>
8821
8822         * symtab.h (SYMBOL_SET_NAMES): Update.
8823         (symbol_set_names): Update.
8824         (MSYMBOL_SET_NAMES): Update.
8825         * symtab.c (symbol_set_names): Change argument to be an
8826         objfile_per_bfd_storage.
8827         * psymtab.c (add_psymbol_to_bcache): Update.
8828         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8829
8830 2019-01-10  Tom Tromey  <tom@tromey.com>
8831
8832         * symtab.c (create_demangled_names_hash): Change argument to be an
8833         objfile_per_bfd_storage.
8834         (symbol_set_names): Update.
8835
8836 2019-01-10  Tom Tromey  <tom@tromey.com>
8837
8838         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8839         init_psymbol_list.
8840         * psymtab.c (init_psymbol_list): Do nothing if already called.
8841         * psympriv.h (init_psymbol_list): Add comment.
8842         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8843         init_psymbol_list.
8844         * dbxread.c (dbx_symfile_read): Unconditionally call
8845         init_psymbol_list.
8846
8847 2019-01-10  Tom Tromey  <tom@tromey.com>
8848
8849         * xcoffread.c (scan_xcoff_symtab): Update.
8850         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8851         "where".
8852         * mdebugread.c (parse_partial_symbols)
8853         (handle_psymbol_enumerators): Update.
8854         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8855         * dbxread.c (read_dbx_symtab): Update.
8856         * psympriv.h (psymbol_placement): New enum.
8857         (add_psymbol_to_list): Update.
8858
8859 2019-01-10  Tom Tromey  <tom@tromey.com>
8860
8861         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8862         static_psymbols parameters.
8863         (scan_xcoff_symtab): Update.
8864         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8865         static_psymbols parameters.
8866         * psympriv.h (start_psymtab_common): Update.
8867         * mdebugread.c (parse_partial_symbols): Update.
8868         * dwarf2read.c (create_partial_symtab): Update.
8869         * dbxread.c (read_dbx_symtab): Update.
8870         (start_psymtab): Remove global_psymbols and static_psymbols
8871         parameters.
8872
8873 2019-01-10  Tom Tromey  <tom@tromey.com>
8874
8875         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8876         * psymtab.c (allocate_psymtab): Add comment.
8877         * psympriv.h (allocate_psymtab): Add comment.
8878         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8879         initializations.
8880         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8881
8882 2019-01-10  Tom Tromey  <tom@tromey.com>
8883
8884         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8885         Don't declare.
8886         * mipsread.c: Include mdebugread.h.
8887         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8888         Declare.
8889         * elfread.c: Include mdebugread.h.
8890
8891 2019-01-09  Tom Tromey  <tom@tromey.com>
8892
8893         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8894         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8895         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8896         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8897         (psym_lookup_symbol, psym_find_last_source_symtab)
8898         (psym_forget_cached_source_info, psym_print_stats)
8899         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8900         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8901         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8902         (psym_find_compunit_symtab_by_address)
8903         (maintenance_print_psymbols, maintenance_info_psymtabs)
8904         (maintenance_check_psymtabs): Use ranged for.
8905         * psymtab.h (class objfile_psymtabs): New.
8906         (require_partial_symbols): Return objfile_psymtabs.
8907         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8908
8909 2019-01-09  Tom Tromey  <tom@tromey.com>
8910
8911         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8912         (find_pc_mapped_section, list_overlays_command)
8913         (map_overlay_command, unmap_overlay_command)
8914         (simple_overlay_update): Use all_objfiles.
8915         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8916         * printcmd.c (info_symbol_command): Use all_objfiles.
8917         * objfiles.h (ALL_OBJSECTIONS): Remove.
8918         * maint.c (maintenance_translate_address): Use all_objfiles.
8919         * gcore.c (gcore_create_callback): Use all_objfiles.
8920         (objfile_find_memory_regions): Likewise.
8921
8922 2019-01-09  Tom Tromey  <tom@tromey.com>
8923
8924         * symtab.c (find_line_symtab, info_sources_command)
8925         (make_source_files_completion_list): Use objfile_compunits.
8926         * source.c (select_source_symtab): Use objfile_compunits.
8927         * objfiles.h (struct objfile): Update comment.
8928         (ALL_OBJFILES): Remove.
8929         (ALL_FILETABS): Remove.
8930         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8931         objfile_compunits.
8932
8933 2019-01-09  Tom Tromey  <tom@tromey.com>
8934
8935         * symmisc.c (print_objfile_statistics, dump_objfile)
8936         (maintenance_print_symbols): Use compunit_filetabs.
8937         * source.c (forget_cached_source_info_for_objfile): Use
8938         compunit_filetabs.
8939         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8940         (ALL_FILETABS): Use compunit_filetabs.
8941         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8942         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8943
8944 2019-01-09  Tom Tromey  <tom@tromey.com>
8945
8946         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8947         (compunit_filetabs): New.
8948         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8949         compunit_filetabs.
8950         (info_sources_command, make_source_files_completion_list): Remove
8951         declaration.
8952         * symmisc.c (print_objfile_statistics, dump_objfile)
8953         (maintenance_print_symbols): Remove declaration.
8954         (maintenance_info_symtabs): Use compunit_filetabs.
8955         (maintenance_info_line_tables): Likewise.
8956         * source.c (select_source_symtab): Change local variable name.
8957         (forget_cached_source_info_for_objfile): Remove declaration.
8958         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8959         * objfiles.c (objfile_relocate1): Remove declaration.
8960         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8961         declaration.
8962         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8963         * coffread.c (coff_symtab_read): Remove declaration.
8964         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8965         compunit_filetabs.
8966
8967 2019-01-09  Tom Tromey  <tom@tromey.com>
8968
8969         * symtab.c (lookup_objfile_from_block)
8970         (find_pc_sect_compunit_symtab, search_symbols)
8971         (default_collect_symbol_completion_matches_break_on): Use
8972         objfile_compunits.
8973         * objfiles.h (ALL_COMPUNITS): Remove.
8974         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8975         * cp-support.c (add_symbol_overload_list_qualified): Use
8976         objfile_compunits.
8977         * ada-lang.c (ada_collect_symbol_completion_matches)
8978         (ada_add_global_exceptions): Use objfile_compunits.
8979
8980 2019-01-09  Tom Tromey  <tom@tromey.com>
8981
8982         * source.c (select_source_symtab)
8983         (forget_cached_source_info_for_objfile): Remove declaration.
8984         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8985         declaration.
8986         * maint.c (count_symtabs_and_blocks): Remove declaration.
8987         * cp-support.c (add_symbol_overload_list_qualified): Remove
8988         declaration.
8989         * coffread.c (coff_symtab_read): Remove declaration.
8990         * symtab.c (lookup_symbol_in_objfile_symtabs)
8991         (basic_lookup_transparent_type_1): Use objfile_compunits.
8992         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8993         (info_sources_command, search_symbols)
8994         (default_collect_symbol_completion_matches_break_on)
8995         (make_source_files_completion_list): Remove declaration.
8996         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8997         (ada_collect_symbol_completion_matches)
8998         (ada_add_global_exceptions): Remove declaration.
8999         * linespec.c (iterate_over_all_matching_symtabs): Use
9000         objfile_compunits.
9001         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9002         (class objfile_compunits): New.
9003         (ALL_COMPUNITS): Use objfile_compunits.
9004         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9005         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9006         objfile_compunits.
9007         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9008
9009 2019-01-09  Tom Tromey  <tom@tromey.com>
9010
9011         * symtab.c (search_symbols)
9012         (default_collect_symbol_completion_matches_break_on): Use
9013         objfile_msymbols.
9014         * ada-lang.c (ada_lookup_simple_minsym)
9015         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9016         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9017         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9018         objfile_msymbols.
9019         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9020         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9021         * objc-lang.c (find_methods): Use objfile_msymbols.
9022         (info_selectors_command, info_classes_command): Likewise.
9023         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9024         * objfiles.h (class objfile_msymbols): New.
9025         (ALL_OBJFILE_MSYMBOLS): Remove.
9026         (ALL_MSYMBOLS): Remove.
9027
9028 2019-01-09  Tom Tromey  <tom@tromey.com>
9029
9030         * common/next-iterator.h (next_adapter): Add Iterator template
9031         parameter.
9032         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9033         (class all_objfiles_safe): New.
9034         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9035         * objfiles.c (put_objfile_before): Update comment.
9036         (add_separate_debug_objfile): Likewise.
9037         (free_all_objfiles): Use all_objfiles_safe.
9038         (objfile_purge_solibs): Likewise.
9039
9040 2019-01-09  Tom Tromey  <tom@tromey.com>
9041
9042         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9043         (expand_symtab_containing_pc, lookup_static_symbol)
9044         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9045         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9046         all_objfiles.
9047         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9048         * breakpoint.c (create_overlay_event_breakpoint)
9049         (create_longjmp_master_breakpoint)
9050         (create_std_terminate_master_breakpoint)
9051         (create_exception_master_breakpoint): Use all_objfiles.
9052         * linux-thread-db.c (try_thread_db_load_from_pdir)
9053         (has_libpthread): Use all_objfiles.
9054         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9055         * linespec.c (iterate_over_all_matching_symtabs)
9056         (search_minsyms_for_name): Use all_objfiles.
9057         * maint.c (maintenance_info_sections): Use all_objfiles.
9058         * main.c (captured_main_1): Use all_objfiles.
9059         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9060         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9061         * guile/scm-pretty-print.c
9062         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9063         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9064         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9065         (maintenance_print_msymbols): Use all_objfiles.
9066         * source.c (select_source_symtab): Use all_objfiles.
9067         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9068         * symfile.c (remove_symbol_file_command)
9069         (expand_symtabs_matching, map_symbol_filenames): Use
9070         all_objfiles.
9071         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9072         all_objfiles.
9073         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9074         * objc-lang.c (find_methods): Use all_objfiles.
9075         * objfiles.c (have_partial_symbols, have_full_symbols)
9076         (have_minimal_symbols, qsort_cmp)
9077         (default_iterate_over_objfiles_in_search_order): Use
9078         all_objfiles.
9079         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9080         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9081         (maintenance_check_psymtabs): Use all_objfiles.
9082         (ALL_PSYMTABS): Remove.
9083         * compile/compile-object-run.c (do_module_cleanup): Use
9084         all_objfiles.
9085         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9086         * cp-support.c (add_symbol_overload_list_qualified): Use
9087         all_objfiles.
9088         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9089         Use all_objfiles.
9090         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9091         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9092         all_objfiles.
9093         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9094         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9095         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9096         Uses all_objfiles.
9097         * solib.c (solib_read_symbols): Use all_objfiles
9098
9099 2019-01-09  Tom Tromey  <tom@tromey.com>
9100
9101         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9102         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9103         all_objfiles.
9104         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9105         * symmisc.c (print_symbol_bcache_statistics)
9106         (print_objfile_statistics, maintenance_print_objfiles)
9107         (maintenance_info_symtabs, maintenance_check_symtabs)
9108         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9109         all_objfiles.
9110         * source.c (forget_cached_source_info): Use all_objfiles.
9111         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9112         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9113         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9114         * objfiles.c (update_section_map): Use all_objfiles.
9115         (shared_objfile_contains_address_p): Likewise.
9116         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9117         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9118
9119 2019-01-09  Tom Tromey  <tom@tromey.com>
9120
9121         * common/next-iterator.h: New file.
9122         * objfiles.h (class all_objfiles): New.
9123         (struct objfile_iterator): New.
9124
9125 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9126
9127         * NEWS: Move the description of the changed "frame", "select-frame",
9128          and "info frame" commands to the Changed commands section.
9129
9130 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9131
9132         * gdbtypes.c (check_stub_method_group): Remove handling of old
9133         mangling schemes.
9134         * linespec.c (find_methods): Likewise.
9135         * stabsread.c (read_member_functions): Likewise.
9136         * valops.c (search_struct_method): Likewise.
9137         (value_struct_elt_for_reference): Likewise.
9138         * NEWS: Mention this change.
9139
9140 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9141
9142         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9143         print_source_lines.
9144         * source.c (print_source_lines_base): Update line number check.
9145         (print_source_lines): New function.
9146         (source_lines_range::source_lines_range): New function.
9147         * source.h (class source_lines_range): New class.
9148         (print_source_lines): New declaration.
9149
9150 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9151
9152         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9153
9154 2019-01-08  Tom Tromey  <tom@tromey.com>
9155             Simon Marchi  <simon.marchi@ericsson.com>
9156
9157         PR gdb/24060
9158         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9159         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9160         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9161         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9162         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9163         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9164
9165 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9166
9167         * source.c (select_source_symtab): Move header comment to
9168         declaration in source.h.
9169         (forget_cached_source_info_for_objfile): Likewise.
9170         (forget_cached_source_info): Likewise.
9171         (identify_source_line): Likewise.
9172         * source.h (identify_source_line): Move declaration from symtab.h
9173         and add comment from source.c
9174         (print_source_lines): Likewise.
9175         (forget_cached_source_info_for_objfile): Likewise.
9176         (forget_cached_source_info): Likewise.
9177         (select_source_symtab): Likewise.
9178         (enum print_source_lines_flag): Move definition from symtab.h.
9179         * symtab.h (identify_source_line): Move declaration to source.h.
9180         (print_source_lines): Likewise.
9181         (forget_cached_source_info_for_objfile): Likewise.
9182         (forget_cached_source_info): Likewise.
9183         (select_source_symtab): Likewise.
9184         (enum print_source_lines_flag): Move definition to source.h.
9185         * tui/tui-hooks.c: Add 'source.h' include.
9186
9187 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9188
9189         * source.c (print_source_lines_base): Handle requests to print
9190         reverse line number sequences, and guard against empty lines
9191         string.
9192
9193 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9194
9195         * source.c (print_source_lines_base): Fix skip of '\r' if next
9196         character is '\n'.
9197
9198 2019-01-06  Tom Tromey  <tom@tromey.com>
9199
9200         * c-exp.y (struct c_parse_state) <macro_original_text,
9201         expansion_obstack>: New member.
9202         (macro_original_text, expansion_obstack): Remove globals.
9203         (scan_macro_expansion, scanning_macro_expansion)
9204         (finished_macro_expansion): Update.
9205         (scan_macro_cleanup): Remove.
9206         (yylex, c_parse): Update.
9207
9208 2019-01-06  Tom Tromey  <tom@tromey.com>
9209
9210         * c-exp.y (struct c_parse_state) <strings>: New member.
9211         (operator_stoken): Update.
9212
9213 2019-01-06  Tom Tromey  <tom@tromey.com>
9214
9215         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9216         (union type_stack_elt) <typelist_val>: Now a pointer to
9217         std::vector.
9218         (type_stack_cleanup): Don't declare.
9219         (push_typelist): Update.
9220         * parse.c (pop_typelist): Return a std::vector.
9221         (push_typelist): Take a std::vector.
9222         (follow_types): Update.  Do not free args.
9223         (type_stack_cleanup): Remove.
9224         * c-exp.y (struct c_parse_state): New.
9225         (cpstate): New global.
9226         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9227         (nonempty_typelist): Update.
9228         (func_mod): Create a new vector.
9229         (c_parse): Create a c_parse_state.
9230         (check_parameter_typelist): Do not delete params.
9231         (function_method): Update.  Do not delete type_list.
9232
9233 2019-01-06  Tom Tromey  <tom@tromey.com>
9234
9235         PR gdb/28155:
9236         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9237         check_typedef.
9238         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9239         (print_return_value): Likewise.
9240
9241 2019-01-05  Tom Tromey  <tom@tromey.com>
9242
9243         * contrib/cleanup_check.py: Remove.
9244         * contrib/gcc-with-excheck: Remove.
9245         * contrib/exsummary.py: Remove.
9246         * contrib/excheck.py: Remove.
9247
9248 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9249
9250         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9251         NULL. Initialize tpprev to NULL instead of assigning it
9252         to NULL on the next statement.
9253         * windows-nat.c (windows_delete_thread): Remove check for
9254         main_thread_id before printing thread exit notifications.
9255         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9256         Remove thread ID check against main_thread_id.
9257         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9258         windows_delete_thread.
9259         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9260
9261 2019-01-04  Tom Tromey  <tom@tromey.com>
9262
9263         * compile/compile.c (_initialize_compile): Use upper case for
9264         metasyntactic variables.
9265         * symmisc.c (_initialize_symmisc): Use upper case for
9266         metasyntactic variables.
9267         * psymtab.c (_initialize_psymtab): Use upper case for
9268         metasyntactic variables.
9269         * demangle.c (demangle_command): Use upper case for metasyntactic
9270         variables.
9271         (_initialize_demangler): Likewise.
9272         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9273         variables.
9274
9275 2019-01-03  Tom Tromey  <tom@tromey.com>
9276
9277         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9278
9279 2019-01-03  Tom Tromey  <tom@tromey.com>
9280
9281         * python/py-symtab.c (salpy_str): Update.
9282         (struct salpy_sal_object) <symtab>: Now a PyObject.
9283         (salpy_dealloc): Update.
9284         (del_objfile_sal): Use gdbpy_ref.
9285
9286 2019-01-03  Tom Tromey  <tom@tromey.com>
9287
9288         * python/py-type.c (convert_field): Use new_reference.  Return
9289         gdbpy_ref.
9290         (make_fielditem): Return gdbpy_ref.
9291         (typy_fields): Update.
9292         (typy_getitem): Update.
9293         (field_name): Return gdbpy_ref.  Use new_reference.
9294         (typy_iterator_iternext): Update.
9295
9296 2019-01-03  Tom Tromey  <tom@tromey.com>
9297
9298         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9299
9300 2019-01-03  Tom Tromey  <tom@tromey.com>
9301
9302         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9303         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9304         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9305         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9306         (pspy_set_type_printers): Likewise.
9307         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9308         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9309         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9310         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9311         (objfpy_set_type_printers): Likewise.
9312
9313 2019-01-03  Tom Tromey  <tom@tromey.com>
9314
9315         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9316         (gdbpy_print_stack): Use gdbpy_err_fetch.
9317         * python/python-internal.h (class gdbpy_err_fetch): New class.
9318         (class gdbpy_enter) <m_error_type, m_error_value,
9319         m_error_traceback>: Remove.
9320         <m_error>: New member.
9321         (gdbpy_exception_to_string): Don't declare.
9322         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9323         * python/py-value.c (convert_value_from_python): Use
9324         gdbpy_err_fetch.
9325         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9326         gdbpy_exception_to_string.
9327         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9328         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9329         gdbpy_err_fetch.
9330
9331 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9332
9333         * linux-nat.c (delete_lwp_cleanup): Delete.
9334         (struct lwp_deleter): New struct.
9335         (lwp_info_up): New typedef.
9336         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9337         lwp_info_up.
9338
9339 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9340
9341         * linux-fork.c (class scoped_switch_fork_info): New class.
9342         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9343
9344 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9345
9346         * valops.c (find_overload_match): Remove use of null_cleanup, and
9347         calls to do_cleanups.
9348
9349 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9350
9351         * compile/compile-cplus-types.c
9352         (compile_cplus_instance::decl_name): Handle changes to
9353         cp_func_name.
9354         * cp-support.c (cp_func_name): Update header comment, update
9355         return type.
9356         * cp-support.h (cp_func_name): Update return type in declaration.
9357         * valops.c (find_overload_match): Move temp_func local to top
9358         level of function and change its type.  Use temp_func to hold and
9359         delete temporary string obtained from cp_func_name.
9360
9361 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9362
9363         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9364         gdb::char_vector, remove cleanup, and update uses of `msg`.
9365
9366 2019-01-03  Jim Wilson  <jimw@sifive.com>
9367
9368         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9369
9370 2019-01-02  Tom Tromey  <tom@tromey.com>
9371
9372         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9373         (tdesc_parse_xml): Remove cleanups.
9374         * target-descriptions.h (make_cleanup_free_target_description):
9375         Don't declare.
9376         (target_desc_deleter): New struct.
9377         (target_desc_up): New typedef.
9378         * target-descriptions.c (target_desc_deleter::operator()): Rename
9379         from free_target_description.
9380         (make_cleanup_free_target_description): Remove.
9381
9382 2019-01-02  Tom Tromey  <tom@tromey.com>
9383
9384         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9385         constructor, destructor.
9386         (linespec_parser): Remove typedef.
9387         (~linespec_parser): Rename from linespec_parser_delete.
9388         (linespec_lex_to_end, linespec_complete_label)
9389         (linespec_complete): Update.
9390         (decode_line_full): Remove cleanups.
9391         (decode_line_1): Update.
9392
9393 2019-01-02  Tom Tromey  <tom@tromey.com>
9394
9395         * python/python-internal.h (inferior_to_inferior_object): Change
9396         return type.
9397         * python/py-exitedevent.c (create_exited_event_object): Update.
9398         * python/py-inferior.c (inferior_to_inferior_object): Return
9399         gdbpy_ref.
9400         (python_new_inferior, python_inferior_deleted)
9401         (thread_to_thread_object, delete_thread_object)
9402         (build_inferior_list, gdbpy_selected_inferior): Update.
9403         * python/py-infthread.c (create_thread_object): Update.  Also fail
9404         if inferior_to_inferior_object fails.
9405
9406 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9407
9408         * inferior.h (class inferior) <displaced_step_state>: New field.
9409         * infrun.h (struct displaced_step_state): Move here from
9410         infrun.c.  Initialize fields, add constructor.
9411         <inf>: Remove field.
9412         <reset>: New method.
9413         * infrun.c (struct displaced_step_inferior_state): Move to
9414         infrun.h.
9415         (displaced_step_inferior_states): Remove.
9416         (get_displaced_stepping_state): Adust.
9417         (displaced_step_in_progress_any_inferior): Adjust.
9418         (displaced_step_in_progress_thread): Adjust.
9419         (displaced_step_in_progress): Adjust.
9420         (add_displaced_stepping_state): Remove.
9421         (get_displaced_step_closure_by_addr): Adjust.
9422         (remove_displaced_stepping_state): Remove.
9423         (infrun_inferior_exit): Call displaced_step_state.reset.
9424         (use_displaced_stepping): Don't check for NULL.
9425         (displaced_step_prepare_throw): Call
9426         get_displaced_stepping_state.
9427         (displaced_step_fixup): Don't check for NULL.
9428         (prepare_for_detach): Don't check for NULL.
9429
9430 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9431
9432         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9433          in case of call that did not complete.
9434
9435 2019-01-02  Andrey Utkin  <autkin@undo.io>
9436
9437         * symfile.c (find_separate_debug_file): Fix search of debug files for
9438         remote debuggee.
9439
9440 2019-01-02  Tom Tromey  <tom@tromey.com>
9441
9442         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9443         indentation.
9444         * python/py-frame.c (frapy_older): Remove cast.
9445         (frapy_newer): Likewise.
9446         * python/py-breakpoint.c (local_setattro): Remove cast.
9447         * python/py-arch.c (archpy_name): Remove local variable.
9448         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9449
9450 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9451
9452         * unittests/basic_string_view/element_access/char/empty.cc:
9453         Fix year range in copyright header.
9454
9455 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9456
9457         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9458         Delete.
9459         <operator==>: Update with for removed field.
9460         <hash>: Likewise.
9461         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9462         <isa_features>: ...this.
9463         <abi_features>: New field.
9464         (riscv_isa_flen): Update comment.
9465         (riscv_abi_xlen): New declaration.
9466         (riscv_abi_flen): New declaration.
9467         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9468         isa_features.
9469         (riscv_abi_xlen): New function.
9470         (riscv_isa_flen): Update to get answer from isa_features.
9471         (riscv_abi_flen): New function.
9472         (riscv_has_fp_abi): Update to get answer from abi_features.
9473         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9474         xlen and flen.
9475         (riscv_call_info) <xlen, flen>: Update comment.
9476         (riscv_call_arg_struct): Remove invalid assertions
9477         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9478         is removed.
9479         (riscv_gdbarch_init): Gather isa features and abi features
9480         separately, ensure both match on the gdbarch when reusing an old
9481         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9482         a target with 64-bit float hardware.
9483
9484 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9485
9486         * source.c (search_command_helper): Stop reverse search
9487         when line 1 has been searched.
9488
9489 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9490
9491         * record-full.c (record_full_base_target::close): Rewrite
9492         record_full_core_buf_list free logic.
9493
9494 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9495
9496         * break-catch-syscall.c (print_one_catch_syscall): xfree
9497         the last text.
9498
9499 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9500
9501         * top.c (print_gdb_version): Update Copyright year in version
9502         message.
9503
9504 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9505
9506         Update copyright year range in all GDB files.
9507
9508 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9509
9510         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9511
9512 For older changes see ChangeLog-2018.
9513 \f
9514 Local Variables:
9515 mode: change-log
9516 left-margin: 8
9517 fill-column: 74
9518 version-control: never
9519 coding: utf-8
9520 End:
9521