gdb/ChangeLog

   1 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
   2             Jiong Wang  <jiong.wang@arm.com>
   3
   4         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
   5         instructions.
   6         (aarch64_analyze_prologue_test): Add PACIASP test.
   7         (aarch64_prologue_prev_register): Unmask PC value.
   8
   9 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  10             Jiong Wang  <jiong.wang@arm.com>
  11
  12         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
  13         (aarch64_dwarf2_prev_register): Unmask PC value.
  14         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
  15         (aarch64_execute_dwarf_cfa_vendor_op): Check for
  16         DW_CFA_AARCH64_negate_ra_state.
  17         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
  18
  19 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  20             Jiong Wang  <jiong.wang@arm.com>
  21
  22         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
  23         registers.
  24         (aarch64_pseudo_register_name): Likewise.
  25         (aarch64_pseudo_register_type): Likewise.
  26         (aarch64_pseudo_register_reggroup_p): Likewise.
  27         (aarch64_gdbarch_init): Add pauth registers.
  28         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
  29         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
  30         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
  31         (struct gdbarch_tdep): Add regnum for ra_state.
  32
  33 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  34             Jiong Wang  <jiong.wang@arm.com>
  35
  36         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
  37
  38 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  39             Jiong Wang  <jiong.wang@arm.com>
  40
  41         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
  42         function.
  43         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
  44         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
  45         (aarch64_gdbarch_init): Add puth registers.
  46         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
  47         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
  48         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
  49
  50 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  51             Jiong Wang  <jiong.wang@arm.com>
  52
  53         * aarch64-linux-nat.c
  54         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
  55         * aarch64-linux-tdep.c
  56         (aarch64_linux_core_read_description): Likewise.
  57         (aarch64_linux_get_hwcap): New function.
  58         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
  59         (aarch64_linux_get_hwcap): New declaration.
  60
  61 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  62             Jiong Wang  <jiong.wang@arm.com>
  63
  64         * aarch64-linux-nat.c
  65         (aarch64_linux_nat_target::read_description): Add pauth param.
  66         * aarch64-linux-tdep.c
  67         (aarch64_linux_core_read_description): Likewise.
  68         * aarch64-tdep.c (struct target_desc): Add in pauth.
  69         (aarch64_read_description): Add pauth param.
  70         (aarch64_gdbarch_init): Likewise.
  71         * aarch64-tdep.h (aarch64_read_description): Likewise.
  72         * arch/aarch64.c (aarch64_create_target_description): Likewise.
  73         * arch/aarch64.h (aarch64_create_target_description): Likewise.
  74         * features/Makefile: Add new files.
  75         * features/aarch64-pauth.c: New file.
  76         * features/aarch64-pauth.xml: New file.
  77
  78 2019-03-20  Tom Tromey  <tromey@adacore.com>
  79
  80         * infrun.c (handle_inferior_event): Rename from
  81         handle_inferior_event_1.  Create a scoped_value_mark.
  82         (handle_inferior_event): Remove.
  83
  84 2019-03-19  Tom Tromey  <tromey@adacore.com>
  85
  86         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
  87         * infrun.h (print_stop_event): Add "displays" parameter.
  88         * infrun.c (print_stop_event): Add "displays" parameter.
  89
  90 2019-03-19  Pedro Alves  <palves@redhat.com>
  91
  92         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
  93         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
  94         to -1.  Fix TABs vs spaces.
  95         (tui_ui_out::tui_ui_out): Don't initialize fields here.
  96         * tui/tui-out.h (tui_ui_out) Add intro comments.
  97         <m_line, m_start_of_line>: In-class initialize, and add describing
  98         comment.
  99
 100 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 101
 102         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 103         variable names.
 104         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 105
 106 2019-03-18  Pedro Alves  <palves@redhat.com>
 107             Eli Zaretskii <eliz@gnu.org>
 108
 109         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 110         m_line and m_start_of_line.
 111
 112 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 113
 114         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 115         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 116         it returns a newline.  This fixes a regression in TU mode, whereby
 117         the next line is output on the same screen line as the user input.
 118
 119 2019-03-18  Tom Tromey  <tromey@adacore.com>
 120
 121         * minsyms.c (minimal_symbol_reader::install): Remove call to
 122         obstack_blank.
 123
 124 2019-03-18  Pedro Alves  <palves@redhat.com>
 125
 126         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 127         New globals.
 128         (apply_style): New, factored out from ...
 129         (apply_ansi_escape): ... this.  Handle reverse video mode.
 130         (tui_set_reverse_mode): New function.
 131         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 132         * tui/tui-winsource.c (tui_show_source_line): Use
 133         tui_set_reverse_mode instead of setting A_STANDOUT.
 134         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 135         New setter methods.
 136
 137 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 138
 139         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 140         Handle tabs.
 141
 142 2019-03-18  Tom Tromey  <tromey@adacore.com>
 143
 144         * ada-lang.c (empty_array): Add "high" parameter.
 145         (ada_evaluate_subexp): Update.
 146
 147 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 148
 149         * unittests/string_view-selftests.c: Define
 150         _initialize_string_view_selftests unconditionally.
 151
 152 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 153
 154         PR gdb/24350
 155         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 156
 157 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 158
 159         PR gdb/24351
 160         * windows-nat.c (display_selector): Fix format specifiers.
 161
 162 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 163
 164         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 165         tui_refill_source_window instead of tui_refresh_win, to update the
 166         current execution line.  This fixes redisplay of the current line
 167         when stepping through the code with "next" or "step".
 168
 169 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 170
 171         * source-cache.c (source_cache::get_source_lines): Call
 172         find_source_lines to initialize s->nlines.  This fixes vertical
 173         scrolling of TUI source window when the DOWN arrow is pressed.
 174
 175 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 176
 177         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 178         linux-thread-db.c (_initialize_thread_db): Likewise.
 179
 180 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 181
 182         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 183         wclrtoeol in tui_show_source_line".  This reverts changes made in
 184         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 185
 186 2019-03-15  Tom Tromey  <tom@tromey.com>
 187
 188         * symtab.h (struct minimal_symbol): Derive from
 189         general_symbol_info.
 190         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 191         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 192         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 193         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 194         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 195         (MSYMBOL_SEARCH_NAME): Update.
 196         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 197         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 198         * minsyms.c (minimal_symbol_reader::record_full): Update.
 199
 200 2019-03-15  Tom Tromey  <tom@tromey.com>
 201
 202         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 203
 204 2019-03-15  Tom Tromey  <tom@tromey.com>
 205
 206         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 207         unique_xmalloc_ptr.
 208         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 209         Update.
 210         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 211         (build_minimal_symbol_hash_tables)
 212         (minimal_symbol_reader::install): Update.
 213
 214 2019-03-15  Tom Tromey  <tom@tromey.com>
 215
 216         * symtab.c (create_demangled_names_hash): Update.
 217         (symbol_set_names): Update.
 218         * objfiles.h (struct objfile_per_bfd_storage)
 219         <demangled_names_hash>: Now an htab_up.
 220         * objfiles.c (objfile_per_bfd_storage): Simplify.
 221
 222 2019-03-15  Tom Tromey  <tom@tromey.com>
 223
 224         * objfiles.h (struct objfile_per_bfd_storage): Declare
 225         destructor.
 226         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 227         New.
 228         (get_objfile_bfd_data): Use new.  Don't initialize
 229         language_of_main.
 230         (free_objfile_per_bfd_storage): Remove.
 231         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 232
 233 2019-03-15  Tom Tromey  <tom@tromey.com>
 234
 235         * symfile.c (reread_symbols): Update.
 236         * objfiles.c (objfile::objfile): Update.
 237         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 238         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 239         comment.
 240         (minimal_symbol_reader::install): Update.
 241         (terminate_minimal_symbol_table): Remove.
 242         * jit.c (jit_object_close_impl): Update.
 243
 244 2019-03-15  Tom Tromey  <tom@tromey.com>
 245
 246         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 247         initializations.
 248
 249 2019-03-15  Tom Tromey  <tom@tromey.com>
 250
 251         * objfiles.h (struct objfile_per_bfd_storage)
 252         <demangled_hash_languages>: Now a bitset.
 253         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 254         (lookup_minimal_symbol): Update.
 255
 256 2019-03-15  Tom Tromey  <tom@tromey.com>
 257
 258         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 259         Don't return the symbol.
 260         * coffread.c (record_minimal_symbol): Use record_full.
 261
 262 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 263
 264         The MS-Windows port of ncurses fails to switch to a color pair if
 265         one or both of the colors are the implicit default colors.  This
 266         change records the default colors when TUI is initialized, and
 267         then specifies them explicitly when a color pair uses the default
 268         colors.  This allows color styling in TUI mode on MS-Windows.
 269
 270         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 271         ncurses_norm_attr.
 272         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 273         colors in ncurses_norm_attr.
 274         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 275         "none", replace it with the default color recorded in
 276         ncurses_norm_attr.
 277
 278 2019-03-14  Tom Tromey  <tromey@adacore.com>
 279
 280         * source-cache.h (class source_cache) <get_source_lines>: Return
 281         std::string.
 282         * source-cache.c (source_cache::extract_lines): Handle case where
 283         first_pos==npos.  Return std::string.
 284         (source_cache::get_source_lines): Update.
 285
 286 2019-03-14  Tom Tromey  <tromey@adacore.com>
 287
 288         * NEWS: Add item for "style sources" commands.
 289         * source-cache.c (source_cache::get_source_lines): Check
 290         source_styling.
 291         * cli/cli-style.c (source_styling): New global.
 292         (_initialize_cli_style): Add "style sources" commands.
 293         (show_style_sources): New function.
 294         * cli/cli-style.h (source_styling): Declare.
 295
 296 2019-03-14  Pedro Alves  <palves@redhat.com>
 297             Tom Tromey  <tromey@adacore.com>
 298
 299         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 300         * tui/tui-winsource.c (tui_refill_source_window): New function,
 301         from...
 302         (tui_horizontal_source_scroll): ... here.  Move some logic.
 303         * cli/cli-style.c (set_style_enabled): Notify new observable.
 304         * tui/tui-hooks.c (tui_redisplay_source): New function.
 305         (tui_attach_detach_observers): Attach or detach
 306         tui_redisplay_source.
 307         * observable.h (source_styling_changed): New observable.
 308         * observable.c: Define source_styling_changed observable.
 309
 310 2019-03-13  Tom Tromey  <tromey@adacore.com>
 311
 312         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 313         (i386_gnu_nat_target::store_registers): Update.
 314         * target-debug.h (target_debug_print_std_string): New macro.
 315         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 316         * windows-tdep.c (display_one_tib): Update.
 317         * tui/tui-stack.c (tui_make_status_line): Update.
 318         * top.c (print_inferior_quit_action): Update.
 319         * thread.c (thr_try_catch_cmd): Update.
 320         (add_thread_with_info): Update.
 321         (thread_target_id_str): Update.
 322         (thr_try_catch_cmd): Update.
 323         (thread_command): Update.
 324         (thread_find_command): Update.
 325         * record-btrace.c (record_btrace_target::info_record)
 326         (record_btrace_resume_thread, record_btrace_target::resume)
 327         (record_btrace_cancel_resume, record_btrace_step_thread)
 328         (record_btrace_target::wait, record_btrace_target::wait)
 329         (record_btrace_target::wait, record_btrace_target::stop): Update.
 330         * progspace.c (print_program_space): Update.
 331         * process-stratum-target.c
 332         (process_stratum_target::thread_address_space): Update.
 333         * linux-fork.c (linux_fork_mourn_inferior)
 334         (detach_checkpoint_command, info_checkpoints_command)
 335         (linux_fork_context): Update.
 336         (linux_fork_detach): Update.
 337         (class scoped_switch_fork_info): Update.
 338         (delete_checkpoint_command): Update.
 339         * infrun.c (follow_fork_inferior): Update.
 340         (follow_fork_inferior): Update.
 341         (proceed_after_vfork_done): Update.
 342         (handle_vfork_child_exec_or_exit): Update.
 343         (follow_exec): Update.
 344         (displaced_step_prepare_throw): Update.
 345         (displaced_step_restore): Update.
 346         (start_step_over): Update.
 347         (resume_1): Update.
 348         (clear_proceed_status_thread): Update.
 349         (proceed): Update.
 350         (print_target_wait_results): Update.
 351         (do_target_wait): Update.
 352         (context_switch): Update.
 353         (stop_all_threads): Update.
 354         (restart_threads): Update.
 355         (finish_step_over): Update.
 356         (handle_signal_stop): Update.
 357         (switch_back_to_stepped_thread): Update.
 358         (keep_going_pass_signal): Update.
 359         (print_exited_reason): Update.
 360         (normal_stop): Update.
 361         * inferior.c (inferior_pid_to_str): Change return type.
 362         (print_selected_inferior): Update.
 363         (add_inferior): Update.
 364         (detach_inferior): Update.
 365         * dummy-frame.c (fprint_dummy_frames): Update.
 366         * dcache.c (dcache_info_1): Update.
 367         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 368         (btrace_fetch, btrace_clear): Update.
 369         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 370         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 371         type.
 372         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 373         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 374         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 375         * gdbarch.c, gdbarch.h: Rebuild.
 376         * gdbarch.sh (core_pid_to_str): Change return type.
 377         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 378         return type.
 379         (windows_nat_target::pid_to_str): Change return type.
 380         (windows_delete_thread): Update.
 381         (windows_nat_target::attach): Update.
 382         (windows_nat_target::files_info): Update.
 383         * target-delegates.c: Rebuild.
 384         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 385         return type.
 386         (sol_thread_target::pid_to_str): Change return type.
 387         * remote.c (class remote_target) <pid_to_str>: Change return
 388         type.
 389         (remote_target::pid_to_str): Change return type.
 390         (extended_remote_target::attach, remote_target::remote_stop_ns)
 391         (remote_target::remote_notif_remove_queued_reply)
 392         (remote_target::push_stop_reply, remote_target::disable_btrace):
 393         Update.
 394         (extended_remote_target::attach): Update.
 395         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 396         type.
 397         (gdbsim_target::pid_to_str): Change return type.
 398         * ravenscar-thread.c (struct ravenscar_thread_target)
 399         <pid_to_str>: Change return type.
 400         (ravenscar_thread_target::pid_to_str): Change return type.
 401         * procfs.c (class procfs_target) <pid_to_str>: Change return
 402         type.
 403         (procfs_target::pid_to_str): Change return type.
 404         (procfs_target::attach): Update.
 405         (procfs_target::detach): Update.
 406         (procfs_target::fetch_registers): Update.
 407         (procfs_target::store_registers): Update.
 408         (procfs_target::wait): Update.
 409         (procfs_target::files_info): Update.
 410         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 411         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 412         return type.
 413         (nto_procfs_target::pid_to_str): Change return type.
 414         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 415         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 416         return type.
 417         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 418         (exit_lwp): Update.
 419         (attach_proc_task_lwp_callback, get_detach_signal)
 420         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 421         (linux_nat_target::resume, wait_lwp, stop_callback)
 422         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 423         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 424         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 425         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 426         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 427         type.
 428         (inf_ptrace_target::attach): Update.
 429         (inf_ptrace_target::files_info): Update.
 430         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 431         type.
 432         (go32_nat_target::pid_to_str): Change return type.
 433         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 434         (gnu_nat_target::wait): Update.
 435         (gnu_nat_target::wait): Update.
 436         (gnu_nat_target::resume): Update.
 437         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 438         (fbsd_nat_target::wait): Update.
 439         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 440         type.
 441         (darwin_nat_target::attach): Update.
 442         * corelow.c (class core_target) <pid_to_str>: Change return type.
 443         (core_target::pid_to_str): Change return type.
 444         * target.c (normal_pid_to_str): Change return type.
 445         (default_pid_to_str): Likewise.
 446         (target_pid_to_str): Change return type.
 447         (target_translate_tls_address): Update.
 448         (target_announce_detach): Update.
 449         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 450         return type.
 451         (bsd_uthread_target::pid_to_str): Change return type.
 452         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 453         type.
 454         (bsd_kvm_target::pid_to_str): Change return type.
 455         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 456         return type.
 457         (aix_thread_target::pid_to_str): Change return type.
 458         * target.h (struct target_ops) <pid_to_str>: Change return type.
 459         (target_pid_to_str, normal_pid_to_str): Likewise.
 460         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 461         type.
 462         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 463         type.
 464         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 465         return type.
 466         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 467         type.
 468         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 469         type.
 470         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 471         return type.
 472
 473 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 474
 475         * NEWS: Mention that the new default MI version is 3.  Mention
 476         changes to the output of commands and events that deal with
 477         multi-location breakpoints.
 478         * breakpoint.c: Include "mi/mi-out.h".
 479         (print_one_breakpoint): Change output syntax if using MI version
 480         >= 3.
 481         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 482         New.
 483         (mi_multi_location_breakpoint_output_fixed): New.
 484         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 485         (mi_cmd_fix_multi_location_breakpoint_output): New.
 486         (mi_multi_location_breakpoint_output_fixed): New.
 487         * mi/mi-cmds.c (mi_cmds): Register command
 488         -fix-multi-location-breakpoint-output.
 489         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 490         interpreter "mi".
 491
 492 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 493
 494         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 495         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 496         instantiate mi_ui_out based on interpreter name.
 497         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 498         * mi/mi-main.c (mi_load_progress): Likewise.
 499
 500 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 501
 502         * NEWS: Combine separate "New targets" sections for 8.3.
 503
 504 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 505
 506         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 507         (ppcfbsd_init_abi): Install gdbarch
 508         "fetch_tls_load_module_address" and "get_thread_local_address"
 509         methods.
 510
 511 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 512
 513         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 514         (riscv_fbsd_init_abi): Install gdbarch
 515         "fetch_tls_load_module_address" and "get_thread_local_address"
 516         methods.
 517
 518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 519
 520         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 521         (i386fbsd_init_abi): Install gdbarch
 522         "fetch_tls_load_module_address" and "get_thread_local_address"
 523         methods.
 524
 525 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 526
 527         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 528         (amd64fbsd_init_abi): Install gdbarch
 529         "fetch_tls_load_module_address" and "get_thread_local_address"
 530         methods.
 531
 532 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 533
 534         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 535         (struct fbsd_pspace_data): New type.
 536         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 537         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 538         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 539         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 540         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 541
 542 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 543
 544         * gdbtypes.c (lookup_struct_elt): New function.
 545         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 546         * gdbtypes.h (struct struct_elt): New type.
 547         (lookup_struct_elt): New prototype.
 548
 549 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 550
 551         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 552         remove disabled code block.
 553
 554 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 555
 556         * gdbarch.sh (get_thread_local_address): New method.
 557         * gdbarch.h, gdbarch.c: Regenerate.
 558         * target.c (target_translate_tls_address): Use
 559         gdbarch_get_thread_local_address if present instead of
 560         target::get_thread_local_address.
 561
 562 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 563
 564         * target.h (target::get_thread_local_address): Update comment.
 565
 566 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 567
 568         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 569         objfile->separate_debug_objfile_backlink if not NULL.
 570
 571 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 572
 573         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 574         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 575         (amd64bsd_store_inferior_registers): Likewise.
 576         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 577         Enable segment base registers.
 578         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 579         PT_GETFSBASE and PT_GETGSBASE.
 580         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 581         PT_SETGSBASE.
 582         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 583         segment base registers.
 584         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 585
 586 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 587
 588         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 589         Update calls to i386_target_description to add 'segments'
 590         parameter.
 591         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 592         add segment base registers.
 593         * arch/i386.c (i386_create_target_description): Add 'segments'
 594         parameter to enable segment base registers.
 595         * arch/i386.h (i386_create_target_description): Likewise.
 596         * features/i386/32bit-segments.xml: New file.
 597         * features/i386/32bit-segments.c: Generate.
 598         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 599         call to i386_target_description to add 'segments' parameter.
 600         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 601         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 602         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 603         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 604         if feature is present.
 605         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 606         Add 'segments' parameter to call to i386_target_description.
 607         (i386_target_description): Add 'segments' parameter to enable
 608         segment base registers.
 609         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 610         to call to i386_target_description.
 611         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 612         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 613         Define I386_NUM_REGS.
 614         (i386_target_description): Add 'segments' parameter to enable
 615         segment base registers.
 616
 617 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 618
 619         PR/24325
 620         * source-cache.c: #undef open and close, to avoid unresolved
 621         externals during linking.
 622
 623 2019-03-12  Tom Tromey  <tromey@adacore.com>
 624
 625         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 626         const.  Add initializers.
 627         (_initialize_remote): Don't initialize ptid globals.
 628
 629 2019-03-12  Pedro Alves  <palves@redhat.com>
 630
 631         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 632
 633 2019-03-12  Pedro Alves  <palves@redhat.com>
 634
 635         * cp-name-parser.y (main): Remove unused 'len' variable.
 636
 637 2019-03-12  Tom Tromey  <tromey@adacore.com>
 638
 639         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 640         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 641
 642 2019-03-12  Tom Tromey  <tromey@adacore.com>
 643
 644         * linux-nat.c (iterate_over_lwps): Update.
 645         (stop_callback): Remove parameter.
 646         (stop_wait_callback, detach_callback, resume_set_callback)
 647         (select_singlestep_lwp_callback, set_ignore_sigint)
 648         (status_callback, resumed_callback, resume_clear_callback)
 649         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 650         data parameter.
 651         (linux_nat_target::detach, linux_nat_target::resume)
 652         (linux_stop_and_wait_all_lwps, select_event_lwp)
 653         (linux_nat_filter_event, linux_nat_wait_1)
 654         (linux_nat_target::kill, linux_nat_target::stop)
 655         (linux_nat_target::stop): Update.
 656         (linux_nat_resume_callback): Change type.
 657         (resume_stopped_resumed_lwps, count_events_callback)
 658         (select_event_lwp_callback): Likewise.
 659         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 660         * arm-linux-nat.c (struct update_registers_data): Remove.
 661         (update_registers_callback): Change type.
 662         (arm_linux_insert_hw_breakpoint1): Update.
 663         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 664         parameter.
 665         (x86_linux_dr_set_addr): Update.
 666         (x86_linux_dr_set_control): Update.
 667         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 668         (iterate_over_lwps): Use gdb::function_view.
 669         * nat/aarch64-linux-hw-point.c (struct
 670         aarch64_dr_update_callback_param): Remove.
 671         (debug_reg_change_callback): Change type.
 672         (aarch64_notify_debug_reg_change): Update.
 673         * s390-linux-nat.c (s390_refresh_per_info): Update.
 674
 675 2019-03-11  Tom Tromey  <tromey@adacore.com>
 676
 677         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 678         redundant assignment to "this_cu".
 679
 680 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 681
 682         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 683
 684 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 685
 686         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 687         from...
 688         (rank_one_type): ... this.
 689
 690 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 691
 692         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 693         from...
 694         (rank_one_type): ... this.
 695
 696 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 697
 698         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 699         from...
 700         (rank_one_type): ... this.
 701
 702 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 703
 704         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 705         from...
 706         (rank_one_type): ... this.
 707
 708 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 709
 710         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 711         from...
 712         (rank_one_type): ... this.
 713
 714 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 715
 716         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 717         from...
 718         (rank_one_type): ... this.
 719
 720 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 721
 722         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 723         from...
 724         (rank_one_type): ... this.
 725
 726 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 727
 728         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 729         from...
 730         (rank_one_type): ... this.
 731
 732 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 733
 734         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 735         from...
 736         (rank_one_type): ... this.
 737
 738 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 739
 740         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 741         from...
 742         (rank_one_type): ... this.
 743
 744 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 745
 746         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 747         from...
 748         (rank_one_type): ... this.
 749
 750 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 751
 752         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 753         from...
 754         (rank_one_type): ... this.
 755
 756 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 757
 758         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 759         inferior-events' shows the example events.
 760
 761 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 762
 763         Support styling on native MS-Windows console
 764
 765         PR/24315
 766         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 767         on MS-Windows if $TERM is not defined.
 768
 769         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 770
 771         * posix-hdep.c (gdb_console_fputs):
 772         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 773         functions.
 774         * ui-file.h (gdb_console_fputs): Add prototype.
 775
 776         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 777         back to fputs only if the former returns zero.
 778
 779 2019-03-07  Tom Tromey  <tom@tromey.com>
 780
 781         * symmisc.c (print_symbol_bcache_statistics): Update.
 782         (print_objfile_statistics): Update.
 783         * symfile.c (allocate_symtab): Update.
 784         * stabsread.c: Don't include bcache.h.
 785         * psymtab.h (struct psymbol_bcache): Don't declare.
 786         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 787         (psymbol_bcache_init, psymbol_bcache_free)
 788         (psymbol_bcache_get_bcache): Don't declare.
 789         * psymtab.c (struct psymbol_bcache): Remove.
 790         (psymtab_storage::psymtab_storage): Update.
 791         (psymtab_storage::~psymtab_storage): Update.
 792         (psymbol_bcache_init, psymbol_bcache_free)
 793         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 794         (add_psymbol_to_bcache): Update.
 795         (allocate_psymtab): Update.
 796         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 797         macro_cache>: No longer pointers.
 798         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 799         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 800         * macrotab.c (macro_bcache): Update.
 801         * macroexp.c: Don't include bcache.h.
 802         * gdbtypes.c (check_types_worklist): Update.
 803         (types_deeply_equal): Remove TRY/CATCH.  Update.
 804         * elfread.c (elf_symtab_read): Update.
 805         * dwarf2read.c: Don't include bcache.h.
 806         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 807         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 808         (print_bcache_statistics, bcache_memory_used): Don't declare.
 809         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 810         methods.  Rename all data members.
 811         * bcache.c (struct bcache): Move to bcache.h.
 812         (bcache::expand_hash_table): Rename from expand_hash_table.
 813         (bcache): Remove.
 814         (bcache::insert): Rename from bcache_full.
 815         (bcache::compare): Rename from bcache_compare.
 816         (bcache_xmalloc): Remove.
 817         (bcache::~bcache): Rename from bcache_xfree.
 818         (bcache::print_statistics): Rename from print_bcache_statistics.
 819         (bcache::memory_used): Rename from bcache_memory_used.
 820
 821 2019-03-07  Pedro Alves  <palves@redhat.com>
 822
 823         * infrun.c (normal_stop): Also check for
 824         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 825
 826 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 827
 828         * f-lang.c (value_from_host_double): Moved to...
 829         * value.c (value_from_host_double): ...here.
 830         * value.h (value_from_host_double): Declare.
 831         * guile/scm-math.c (vlscm_convert_typed_number): Use
 832         value_from_host_double.
 833         (vlscm_convert_number): Likewise.
 834         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 835         * python/py-value.c (convert_value_from_python): Likewise.
 836
 837 2019-03-06  Tom Tromey  <tom@tromey.com>
 838
 839         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 840
 841 2019-03-06  Tom Tromey  <tom@tromey.com>
 842
 843         * utils.h (free_current_contents): Don't declare.
 844         * utils.c (free_current_contents): Remove.
 845
 846 2019-03-06  Tom Tromey  <tom@tromey.com>
 847
 848         * top.c (quit_force): Update.
 849         * main.c (captured_command_loop): Update.
 850         * common/new-op.c (operator new): Update.
 851         * common/common-exceptions.c (struct catcher)
 852         <save_cleanup_chain>: Remove member.
 853         (exceptions_state_mc_init): Update.
 854         (exception_try_scope_entry): Return nullptr.
 855         (exception_try_scope_exit, exception_rethrow)
 856         (throw_exception_sjlj, throw_exception_cxx): Update.
 857         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 858         (all_cleanups, do_cleanups, discard_cleanups)
 859         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 860         (restore_cleanups, restore_final_cleanups): Don't declare.
 861         (do_final_cleanups): Remove parameter.
 862         * common/cleanups.c (cleanup_chain, make_cleanup)
 863         (make_cleanup_dtor, all_cleanups, do_cleanups)
 864         (discard_my_cleanups, discard_cleanups)
 865         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 866         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 867         (null_cleanup): Remove.
 868         (do_final_cleanups): Remove parameter.
 869
 870 2019-03-06  Tom Tromey  <tom@tromey.com>
 871
 872         * remote.c (remote_target::remote_parse_stop_reply): Use
 873         unique_xmalloc_ptr.
 874
 875 2019-03-06  Tom Tromey  <tom@tromey.com>
 876
 877         * stabsread.c (struct stabs_field_info): Rename from field_info.
 878         <list, fnlist>: Add initializers.
 879         <obstack>: New member.
 880         (read_member_functions, read_struct_fields, read_baseclasses):
 881         Allocate on obstack.  Don't use cleanups.
 882         (read_one_struct_field, read_member_functions, read_struct_fields)
 883         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 884         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 885         (read_struct_type): Update.
 886
 887 2019-03-06  Tom Tromey  <tom@tromey.com>
 888
 889         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 890         * common/filestuff.h (make_cleanup_close): Don't declare.
 891         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 892         Remove.
 893
 894 2019-03-06  Tom Tromey  <tom@tromey.com>
 895
 896         * solib-aix.c: Use make_scope_exit.
 897
 898 2019-03-06  Tom Tromey  <tom@tromey.com>
 899
 900         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 901         Use make_scope_exit.
 902
 903 2019-03-06  Tom Tromey  <tom@tromey.com>
 904
 905         * solib-svr4.c (disable_probes_interface): Remove parameter.
 906         (svr4_handle_solib_event): Use make_scope_exit.
 907
 908 2019-03-06  Tom Tromey  <tom@tromey.com>
 909
 910         * remote.c (struct stop_reply_deleter): Remove.
 911         (stop_reply_up): Update.
 912         (struct stop_reply): Derive from notif_event.  Don't typedef.
 913         <regcache>: Now a std::vector.
 914         (stop_reply_xfree): Remove.
 915         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 916         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 917         (remote_target::discard_pending_stop_replies): Use delete.
 918         (remote_target::remote_parse_stop_reply): Update.
 919         (remote_target::process_stop_reply): Update.
 920         * remote-notif.h (struct notif_event): Add virtual destructor.
 921         Remove "dtr" member.
 922         (struct notif_client) <alloc_event>: Return a unique_ptr.
 923         (notif_event_xfree): Don't declare.
 924         (notif_event_up): New typedef.
 925         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 926         (notif_event_xfree, do_notif_event_xfree): Remove.
 927         (remote_notif_state_xfree): Update.
 928
 929 2019-03-06  Tom Tromey  <tom@tromey.com>
 930
 931         * infrun.c (displaced_step_clear_cleanup): Now a
 932         forward_scope_exit type.
 933         (displaced_step_prepare_throw): Update.
 934         (displaced_step_fixup): Update.
 935
 936 2019-03-06  Tom Tromey  <tom@tromey.com>
 937
 938         * inferior.h (class inferior): Update comment.
 939         * gdbthread.h (class thread_info): Update comment.
 940
 941 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 942             Tom Tromey  <tom@tromey.com>
 943
 944         * stabsread.h (struct stab_section_list): Remove.
 945         (coffstab_build_psymtabs): Update.
 946         * dbxread.c (symbuf_sections): Now a std::vector.
 947         (sect_idx): New global.
 948         (fill_symbuf): Update.
 949         (coffstab_build_psymtabs): Change type of stabsects parameter.
 950         Update.
 951         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 952         std::vector.
 953         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 954         (coff_locate_sections): Update.
 955         (coff_symfile_read): Remove cleanups.  Update.
 956         (init_stringtab): Add storage parameter.
 957         (free_stringtab, free_stringtab_cleanup): Remove.
 958         (init_lineno): Add storage parameter.
 959         (free_linetab, free_linetab_cleanup): Remove.
 960
 961 2019-03-06  Pedro Alves  <palves@redhat.com>
 962
 963         * linux-fork.c (fork_info::clobber_regs): Delete.
 964         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 965         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 966         comment.  Adjust.
 967         (scoped_switch_fork_info::scoped_switch_fork_info)
 968         (checkpoint_command, linux_fork_context): Adjust
 969         fork_save_infrun_state calls.
 970
 971 2019-03-06  Pedro Alves  <palves@redhat.com>
 972
 973         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 974         (inf_has_multiple_threads): Return 'bool' and rewrite using
 975         inferior_info::threads().
 976
 977 2019-03-06  Pedro Alves  <palves@redhat.com>
 978
 979         * linux-fork.c: Include <list>.
 980         (fork_list): Now a std::list instance.
 981         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 982         (forks_exist_p, find_last_fork): Adjust.
 983         (new_fork): Delete.
 984         (one_fork_p): New.
 985         (add_fork): Adjust.
 986         (free_fork): Delete, folded into fork_info::~fork_info().
 987         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 988         Adjust.
 989         (init_fork_list): Delete.
 990         (linux_fork_killall, linux_fork_mourn_inferior)
 991         (linux_fork_detach, info_checkpoints_command): Adjust.
 992         (_initialize_linux_fork): No longer call init_fork_list.
 993
 994 2019-03-06  Pedro Alves  <palves@redhat.com>
 995
 996         * linux-fork.c (new_fork): New, split out of ...
 997         (add_fork): ... this.  Return void.  Move "first fork" special
 998         case from here, to ...
 999         (checkpoint_command): ... here.
1000         * linux-linux.h (add_fork): Return void.
1001
1002 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1003
1004         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1005
1006 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1007             Chris January  <chris.january@arm.com>
1008             David Lecomber  <david.lecomber@arm.com>
1009
1010         * f-exp.y: New token, UNOP_INTRINSIC.
1011         (exp): New pattern using UNOP_INTRINSIC token.
1012         (f77_keywords): Add 'abs' keyword.
1013         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1014         (value_from_host_double): New function.
1015         (evaluate_subexp_f): Support UNOP_ABS.
1016
1017 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1020         types.
1021
1022 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1025         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1026         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1027
1028 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1029
1030         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1031
1032 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1033             Chris January  <chris.january@arm.com>
1034
1035         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1036         * f-exp.y: Define 'KIND' token.
1037         (exp): New pattern for KIND expressions.
1038         (ptype): Handle types with a kind extension.
1039         (direct_abs_decl): Extend to spot kind extensions.
1040         (f77_keywords): Add 'kind' to the list.
1041         (push_kind_type): New function.
1042         (convert_to_kind_type): New function.
1043         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1044         * parse.c (operator_length_standard): Likewise.
1045         * parser-defs.h (enum type_pieces): Add tp_kind.
1046         * std-operator.def: Add UNOP_KIND.
1047
1048 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1049
1050         * f-exp.y (f_parse): Set yydebug.
1051
1052 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1053
1054         * f-lang.c (evaluate_subexp_f): New function.
1055         (exp_descriptor_f): New global.
1056         (f_language_defn): Use exp_descriptor_f instead of
1057         exp_descriptor_standard.
1058
1059 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1060
1061         * f-exp.y (struct token): Add comments.
1062         (dot_ops): Remove uppercase versions and the end marker.
1063         (f77_keywords): Likewise.
1064         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1065         entries in the dot_ops array are case insensitive, and use
1066         strncasecmp to compare strings.  Also some whitespace cleanup in
1067         this area.  Similar for the f77_keywords array, except entries in
1068         this list might be case sensitive.
1069
1070 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1071
1072         * f-exp.y (struct f77_boolean_val): Add comments.
1073         (boolean_values): Remove uppercase versions, and end marker.
1074         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1075         and use strncasecmp to achieve case insensitivity.  Additionally,
1076         perform whitespace cleanup around this code.
1077
1078 2019-03-06  Tom Tromey  <tromey@adacore.com>
1079
1080         * remote-sim.c (gdbsim_target_open): Use result of
1081         gdb_argv::release.
1082
1083 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1084         Dirk Schubert  <dirk.schubert@arm.com>
1085         Chris January  <chris.january@arm.com>
1086
1087         * eval.c (evaluate_subexp_standard): Call Fortran argument
1088         wrapping logic.
1089         * f-lang.c (struct value): A value which can be passed into a
1090         Fortran function call.
1091         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1092         where appropriate.
1093         (struct type): Value ready for a Fortran function call.
1094         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1095         is needed.
1096         * f-lang.h (fortran_argument_convert): Declaration.
1097         (fortran_preserve_arg_pointer): Declaration.
1098         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1099
1100 2019-03-05  Tom Tromey  <tromey@adacore.com>
1101
1102         * python/py-prettyprint.c (print_string_repr): Remove #if.
1103         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1104
1105 2019-03-05  Tom Tromey  <tromey@adacore.com>
1106
1107         * target.c (the_dummy_target): Move later.  Change type to
1108         "dummy_target".
1109         (initialize_targets): Don't initialize the_dummy_target.
1110
1111 2019-03-05  Tom Tromey  <tromey@adacore.com>
1112
1113         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1114         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1115
1116 2019-03-05  Tom Tromey  <tromey@adacore.com>
1117
1118         * windows-nat.c (windows_nat_target::attach)
1119         (windows_nat_target::detach): Don't call gdb_flush.
1120         * valprint.c (generic_val_print, val_print, val_print_string):
1121         Don't call gdb_flush.
1122         * utils.c (defaulted_query): Don't call gdb_flush.
1123         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1124         * target.c (target_announce_detach): Don't call gdb_flush.
1125         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1126         * remote.c (extended_remote_target::attach): Don't call
1127         gdb_flush.
1128         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1129         * printcmd.c (do_examine): Don't call gdb_flush.
1130         (info_display_command): Don't call gdb_flush.
1131         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1132         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1133         * memattr.c (info_mem_command): Don't call gdb_flush.
1134         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1135         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1136         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1137         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1138         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1139         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1140         (gnu_nat_target::detach): Don't call gdb_flush.
1141         * f-valprint.c (f_val_print): Don't call gdb_flush.
1142         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1143         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1144         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1145         gdb_flush.
1146         * c-valprint.c (c_val_print): Don't call gdb_flush.
1147         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1148
1149 2019-03-05  Tom Tromey  <tromey@adacore.com>
1150
1151         * varobj.c (update_dynamic_varobj_children): Update.
1152         (install_default_visualizer): Use reset, not release.
1153         * value.c (set_internalvar): Update.
1154         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1155         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1156         ATTRIBUTE_UNUSED_RESULT.
1157
1158 2019-03-05  Tom Tromey  <tromey@adacore.com>
1159
1160         * remote.c (class scoped_remote_fd) <release>: Add
1161         ATTRIBUTE_UNUSED_RESULT.
1162
1163 2019-03-05  Tom Tromey  <tromey@adacore.com>
1164
1165         * macroexp.c (struct macro_buffer) <release>: Add
1166         ATTRIBUTE_UNUSED_RESULT.
1167
1168 2019-03-05  Tom Tromey  <tromey@adacore.com>
1169
1170         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1171         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1172         ATTRIBUTE_UNUSED_RESULT.
1173
1174 2019-03-05  Tom Tromey  <tromey@adacore.com>
1175
1176         * common/scoped_fd.h (class scoped_fd) <release>: Add
1177         ATTRIBUTE_UNUSED_RESULT.
1178
1179 2019-03-05  Tom Tromey  <tromey@adacore.com>
1180
1181         * parser-defs.h (struct parser_state) <release>: Add
1182         ATTRIBUTE_UNUSED_RESULT.
1183
1184 2019-03-05  Tom Tromey  <tromey@adacore.com>
1185
1186         * utils.h (class gdb_argv) <release>: Add
1187         ATTRIBUTE_UNUSED_RESULT.
1188         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1189
1190 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1191
1192         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1193         for-loop range, to avoid compiler warnings.
1194
1195         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1196         avoid compiler warnings about unused variables.
1197
1198         * NEWS: Mention end of support for native debugging on MS-Windows
1199         before XP.
1200
1201         PR gdb/24292
1202         * common/netstuff.c:
1203         * gdbserver/gdbreplay.c
1204         * gdbserver/remote-utils.c:
1205         * ser-tcp.c:
1206         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1207         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1208         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1209         'getaddrinfo' and 'freeaddrinfo' were not available before
1210         Windows XP, and mingw.org's MinGW headers by default define
1211         _WIN32_WINNT to 0x500.
1212
1213 2019-03-01  Gary Benson <gbenson@redhat.com>
1214
1215         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1216
1217 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1218             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1219
1220         PR gdb/8527
1221         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1222         set_sigint_trap, clear_sigint_trap.
1223
1224 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1225
1226         * target.c (target_detach): Clear the regcache and the
1227         frame cache.
1228
1229 2019-02-27  Pedro Alves  <palves@redhat.com>
1230
1231         * utils.c (set_screen_size): When we cap the height/width sizes,
1232         tweak the corresponding command variable to show "unlimited":
1233
1234 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1235             Pedro Alves  <palves@redhat.com>
1236
1237         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1238         before calling rl_set_screen_size.
1239
1240 2019-02-27  Tom Tromey  <tromey@adacore.com>
1241
1242         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1243         define.
1244         * python/py-value.c: Remove Python 2.4 workaround.
1245         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1246         workaround.
1247         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1248         Python 2.4 workaround.
1249         * python/python-internal.h: Remove Python 2.4 comment.
1250         (Py_ssize_t): Don't define.
1251         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1252         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1253         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1254         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1255         * python/python.c (do_start_initialization): Remove Python 2.4
1256         workaround.
1257         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1258         (print_children): Remove Python 2.4 workaround.
1259         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1260         workaround.
1261         (CHARBUFFERPROC_NAME): Remove.
1262         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1263         Python 2.4 workaround.
1264
1265 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1266
1267         * NEWS: Note minimum Python version.
1268
1269 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1270
1271         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1272         code from these functions.  Remove corresponding ifdefs.  Use
1273         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1274         Remove gotos and target of gotos.
1275         (infpy_search_memory): Likewise.
1276
1277 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1280         (hppa_gdbarch_init): Don't register deleted functions with
1281         gdbarch.
1282
1283 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1284
1285         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1286         (h8300_unwind_sp): Delete.
1287         (h8300_dummy_id): Delete.
1288         (h8300_gdbarch_init): Don't register deleted functions with
1289         gdbarch.
1290
1291 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1292
1293         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1294         (ft32_unwind_pc): Delete.
1295         (ft32_unwind_sp): Delete.
1296         (ft32_gdbarch_init): Don't register deleted functions with
1297         gdbarch.
1298
1299 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1302         (frv_unwind_pc): Delete.
1303         (frv_unwind_sp): Delete.
1304         (frv_gdbarch_init): Don't register deleted functions with
1305         gdbarch.
1306
1307 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1308
1309         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1310         (riscv_unwind_pc): Delete.
1311         (riscv_unwind_sp): Delete.
1312         (riscv_gdbarch_init): Don't register deleted functions with
1313         gdbarch.
1314
1315 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1316
1317         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1318         (csky_unwind_pc): Delete.
1319         (csky_unwind_sp): Delete.
1320         (csky_gdbarch_init): Don't register deleted functions with
1321         gdbarch.
1322
1323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1326         (cris_unwind_pc): Delete.
1327         (cris_unwind_sp): Delete.
1328         (cris_gdbarch_init): Don't register deleted functions with
1329         gdbarch.
1330
1331 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1334         (bfin_unwind_pc): Delete.
1335         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1336
1337 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1338
1339         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1340         (arm_unwind_pc): Delete.
1341         (arm_unwind_sp): Delete.
1342         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1343
1344 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1345
1346         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1347         (arc_unwind_pc): Delete.
1348         (arc_unwind_sp): Delete.
1349         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1350
1351 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1352
1353         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1354         (alpha_unwind_pc): Delete.
1355         (alpha_gdbarch_init): Don't register deleted functions with
1356         gdbarch.
1357
1358 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1359
1360         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1361         (aarch64_unwind_pc): Delete.
1362         (aarch64_unwind_sp): Delete.
1363         (aarch64_gdbarch_init): Don't register deleted functions with
1364         gdbarch.
1365
1366 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1367
1368         * gdbtypes.c (type_align): Don't consider static members when
1369         computing structure alignment.
1370
1371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1374         return 0 for other types.
1375         * arch-utils.c (default_type_align): Always return 0.
1376         * gdbarch.h: Regenerate.
1377         * gdbarch.sh (type_align): Extend comment.
1378         * gdbtypes.c (type_align): Add additional comments, always call
1379         gdbarch_type_align before applying the default rules.
1380         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1381         generic code will then apply a suitable default.
1382         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1383         types, return 0 for other types.
1384
1385 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1386
1387         * NEWS: Create a new section for the next release branch.
1388         Rename the section of the current branch, now that it has
1389         been cut.
1390
1391 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1392
1393         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1394         * version.in: Bump version to 8.3.50.DATE-git.
1395
1396 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1397
1398         * aix-thread.c (ptid_cmp): Remove unused variable.
1399         (get_signaled_thread): Likewise.
1400         (store_regs_user_thread): Likewise.
1401         (store_regs_kernel_thread): Likewise.
1402         (fetch_regs_kernel_thread): Remove shadowed variable.
1403
1404 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1405
1406         * features/riscv/32bit-cpu.xml: Add register numbers.
1407         * features/riscv/32bit-fpu.c: Regenerate.
1408         * features/riscv/32bit-fpu.xml: Add register numbers.
1409         * features/riscv/64bit-cpu.xml: Add register numbers.
1410         * features/riscv/64bit-fpu.c: Regenerate.
1411         * features/riscv/64bit-fpu.xml: Add register numbers.
1412
1413 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1414
1415         * NEWS: Mention two argument form of gdb.Value constructor.
1416         * python/py-value.c (convert_buffer_and_type_to_value): New
1417         function.
1418         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1419         Add support for handling an optional second argument.  Call
1420         convert_buffer_and_type_to_value as appropriate.
1421         * python/python-internal.h (Py_buffer_deleter): New struct.
1422         (Py_buffer_up): New typedef.
1423
1424 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1425
1426         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1427         instead of releasing ownership.
1428
1429 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1430
1431         * dwarf2read.c (open_and_init_dwp_file): Call
1432         elf_numsections instead of bfd_count_sections to initialize
1433         dwp_file->num_sections.
1434
1435 2019-02-25  Tom Tromey  <tromey@adacore.com>
1436
1437         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1438
1439 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1440
1441         * gcore.in: Add '--readnever' option when invoking GDB.
1442
1443 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1444
1445         * MAINTAINERS: Update my email address.
1446
1447 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1448
1449         * build-id.c (build_id_to_debug_bfd_1): New function.
1450         (build_id_to_debug_bfd): Look for separate debug file in
1451         sysroot.
1452
1453 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1454
1455         * gdbarch.sh: Update the copyright year range that is placed into
1456         generated files.
1457
1458 2019-02-22  Keith Seitz  <keiths@redhat.com>
1459
1460         PR symtab/23853
1461         * linespec.c (create_sals_line_offset): Search for the default
1462         symtab's filename instead of its fullname.
1463
1464 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1465
1466         * NEWS: Update style defaults.
1467
1468 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1469
1470         * main.c (captured_main_1): Disable styling in batch mode.
1471
1472 2019-02-20  Tom Tromey  <tom@tromey.com>
1473
1474         * symtab.c (symtab_symbol_info): Fix typos.
1475
1476 2019-02-20  Tom Tromey  <tromey@adacore.com>
1477
1478         * findcmd.c (_initialize_mem_search): Use upper case for
1479         metasyntactic variables.
1480
1481 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1482
1483         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1484         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1485
1486 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1487
1488         * top.h (source_file_name): Change to std::string.
1489         * top.c (source_file_name): Likewise.
1490         (command_line_input): Adjust.
1491         * cli/cli-script.c (script_from_file): Adjust.
1492
1493 2019-02-19  Tom Tromey  <tromey@adacore.com>
1494
1495         * ravenscar-thread.c
1496         (ravenscar_thread_target::update_thread_list): Don't call
1497         ada_build_task_list.
1498         * ada-lang.h (ada_build_task_list): Don't declare.
1499         * ada-tasks.c (struct ada_tasks_inferior_data)
1500         <task_list_valid_p>: Now bool.
1501         (read_known_tasks, ada_task_list_changed)
1502         (ada_tasks_invalidate_inferior_data): Update.
1503         (read_known_tasks_array): Return bool.
1504         (read_known_tasks_list): Likewise.
1505         (read_known_tasks): Return void.
1506         (ada_build_task_list): Now static.
1507
1508 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1509
1510         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1511         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1512
1513 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1514
1515         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1516         variant for ada_tasks_pspace_data_handle and
1517         ada_tasks_inferior_data_handle.
1518         (ada_tasks_pspace_data_cleanup): New function.
1519         (ada_tasks_inferior_data_cleanup): New function.
1520
1521 2019-02-17  Tom Tromey  <tom@tromey.com>
1522
1523         * macrotab.h (macro_source_fullname): Return a std::string.
1524         * macrotab.c (macro_include, check_for_redefinition)
1525         (macro_undef, macro_lookup_definition, foreach_macro)
1526         (foreach_macro_in_scope): Update.
1527         (macro_source_fullname): Return a std::string.
1528         * macrocmd.c (show_pp_source_pos): Update.
1529
1530 2019-02-17  Tom Tromey  <tom@tromey.com>
1531
1532         * macrocmd.c (show_pp_source_pos): Style the file names.
1533
1534 2019-02-17  Tom Tromey  <tom@tromey.com>
1535
1536         PR tui/24197:
1537         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1538
1539 2019-02-17  Tom Tromey  <tom@tromey.com>
1540
1541         * ada-lang.c (user_select_syms): Use filtered printing.
1542         * utils.c (wrap_style): New global.
1543         (desired_style): Remove.
1544         (emit_style_escape): Add stream parameter.
1545         (set_output_style, reset_terminal_style, prompt_for_continue):
1546         Update.
1547         (flush_wrap_buffer): Only flush gdb_stdout.
1548         (wrap_here): Set wrap_style.
1549         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1550         treat escape sequences as a character.  Change when wrap buffer is
1551         flushed.
1552         (fputs_styled): Do not set the output style when the default is
1553         requested.
1554         * ui-style.h (struct ui_file_style) <is_default>: New method.
1555         * source.c (print_source_lines_base): Emit escape sequences in one
1556         piece.
1557
1558 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1559
1560         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1561         integers and enumeration types.
1562
1563 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1564
1565         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1566         instead of lookup_symbol_in_language
1567         (do_exact_match): New function.
1568         (ada_get_symbol_name_matcher): Return do_exact_match when
1569         doing a verbatim match.
1570
1571 2019-02-15  Tom Tromey  <tromey@adacore.com>
1572
1573         * ravenscar-thread.c (ravenscar_thread_target::resume)
1574         (ravenscar_thread_target::wait): Special case wildcard requests.
1575
1576 2019-02-15  Tom Tromey  <tromey@adacore.com>
1577
1578         * ravenscar-thread.c (base_ptid): Remove.
1579         (struct ravenscar_thread_target) <close>: New method.
1580         <m_base_ptid>: New member.
1581         <update_inferior_ptid, active_task, task_is_currently_active,
1582         runtime_initialized>: Declare methods.
1583         <ravenscar_thread_target>: Add constructor.
1584         (ravenscar_thread_target::task_is_currently_active)
1585         (ravenscar_thread_target::update_inferior_ptid)
1586         (ravenscar_runtime_initialized): Rename.  Now methods.
1587         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1588         (ravenscar_thread_target::update_thread_list): Update.
1589         (ravenscar_thread_target::active_task): Now method.
1590         (ravenscar_thread_target::store_registers)
1591         (ravenscar_thread_target::prepare_to_store)
1592         (ravenscar_thread_target::prepare_to_store)
1593         (ravenscar_thread_target::mourn_inferior): Update.
1594         (ravenscar_inferior_created): Use "new" to create target.
1595         (ravenscar_thread_target::get_ada_task_ptid): Update.
1596         (_initialize_ravenscar): Don't initialize base_ptid.
1597         (ravenscar_ops): Remove global.
1598
1599 2019-02-15  Tom Tromey  <tromey@adacore.com>
1600
1601         * target.h (push_target): Declare new overload.
1602         * target.c (push_target): New overload, taking an rvalue reference.
1603         * remote.c (remote_target::open_1): Use push_target overload.
1604         * corelow.c (core_target_open): Use push_target overload.
1605
1606 2019-02-15  Tom Tromey  <tromey@adacore.com>
1607
1608         * ravenscar-thread.c (is_ravenscar_task)
1609         (ravenscar_task_is_currently_active): Return bool.
1610         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1611         (_initialize_ravenscar): Remove "(void)".
1612         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1613         Return bool.
1614
1615 2019-02-15  Tom Tromey  <tromey@adacore.com>
1616
1617         * ravenscar-thread.c (ravenscar_runtime_initializer)
1618         (has_ravenscar_runtime, get_running_thread_id)
1619         (ravenscar_thread_target::resume): Fix indentation.
1620
1621 2019-02-15  Tom Tromey  <tromey@adacore.com>
1622
1623         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1624         from ravenscar_arch_ops.
1625         (sparc_ravenscar_ops::fetch_registers)
1626         (sparc_ravenscar_ops::store_registers): Now methods.
1627         (sparc_ravenscar_prepare_to_store): Remove.
1628         (sparc_ravenscar_ops): Redefine.
1629         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1630         methods and destructor.  Remove members.
1631         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1632         (ravenscar_thread_target::store_registers)
1633         (ravenscar_thread_target::prepare_to_store): Update.
1634         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1635         Remove.
1636         (struct ppc_ravenscar_powerpc_ops): Derive from
1637         ravenscar_arch_ops.
1638         (ppc_ravenscar_powerpc_ops::fetch_registers)
1639         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1640         (ppc_ravenscar_powerpc_ops): Redefine.
1641         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1642         (ppc_ravenscar_e500_ops::fetch_registers)
1643         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1644         (ppc_ravenscar_e500_ops): Redefine.
1645         * aarch64-ravenscar-thread.c
1646         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1647         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1648         (aarch64_ravenscar_fetch_registers)
1649         (aarch64_ravenscar_store_registers): Now methods.
1650         (aarch64_ravenscar_ops): Redefine.
1651
1652 2019-02-15  Tom Tromey  <tromey@adacore.com>
1653
1654         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1655         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1656         (ravenscar_thread_target::stopped_by_watchpoint)
1657         (ravenscar_thread_target::stopped_data_address)
1658         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1659
1660 2019-02-15  Tom Tromey  <tromey@adacore.com>
1661
1662         * ravenscar-thread.c: Fix some typos.
1663
1664 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1665             Tom Tromey  <tromey@adacore.com>
1666
1667         * ada-lang.c (ada_exception_sal): Change addr_string to a
1668         std::string.
1669         (create_ada_exception_catchpoint): Update.
1670
1671 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1672             Tom Tromey  <tromey@adacore.com>
1673
1674         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1675         (bp_location_ops): Remove.
1676         (base_breakpoint_allocate_location): Update.
1677         (free_bp_location): Update.
1678         * ada-lang.c (class ada_catchpoint_location)
1679         <ada_catchpoint_location>: Remove ops parameter.
1680         (ada_catchpoint_location_dtor): Remove.
1681         (ada_catchpoint_location_ops): Remove.
1682         (allocate_location_exception): Update.
1683         * breakpoint.h (struct bp_location_ops): Remove.
1684         (class bp_location) <bp_location>: Remove bp_location_ops
1685         parameter.
1686         <~bp_location>: Add destructor.
1687         <ops>: Remove.
1688
1689 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1690             Pedro Alves  <palves@redhat.com>
1691
1692         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1693         'PATH_MAX'.
1694
1695 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1696             Samuel Thibault  <samuel.thibault@gnu.org>
1697             Thomas Schwinge  <thomas@codesourcery.com>
1698
1699         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1700         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1701
1702 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1703
1704         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1705         (check_empty): Use "const char *".
1706
1707         * gnu-nat.c (gnu_nat_target::detach): Instead of
1708         'detach_inferior (pid)' call
1709         'detach_inferior (find_inferior_pid (pid))'.
1710
1711         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1712         'nat/fork-inferior.o'.
1713         * gnu-nat.c: #include "nat/fork-inferior.h".
1714
1715         * gnu-nat.c (gnu_nat_target::detach): Instead of
1716         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1717         * gnu-nat.h: #include "inf-child.h".
1718         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1719         'i386_gnu_nat_target::fetch_registers'.
1720         (gnu_store_registers): Rename/move to
1721         'i386_gnu_nat_target::store_registers'.
1722
1723         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1724         * gnu-nat.h (mach_thread_info): New function.
1725         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1726
1727         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1728
1729 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1730
1731         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1732
1733 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1734
1735         * windows-nat.c (windows_add_thread): Add new parameter
1736         "main_thread_p" with default value set to false.  Update
1737         function documentation as well as all callers.
1738         (windows_delete_thread): Likewise.
1739         (fake_create_process): Update call to windows_add_thread.
1740         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1741         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1742         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1743         call to windows_delete_thread.
1744
1745 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1746
1747         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1748
1749 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1750
1751         * symfile.c (find_separate_debug_file): Use canonical path of
1752         sysroot with child_path instead of gdb_sysroot if it is valid.
1753
1754 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1755
1756         * symfile.c (find_separate_debug_file): Use child_path to
1757         determine if an object file is under a sysroot.
1758
1759 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1760
1761         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1762         unittests/child-path-selftests.c.
1763         * common/pathstuff.c (child_path): New function.
1764         * common/pathstuff.h (child_path): New prototype.
1765         * unittests/child-path-selftests.c: New file.
1766
1767 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1768
1769         * symfile.c (find_separate_debug_file): Look for separate debug
1770         files in debug directories under the sysroot.
1771
1772 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1773
1774         * symtab.h (struct minimal_symbol data_p): New const method.
1775         (struct minimal_symbol text_p): Likewise.
1776         * symtab.c (output_source_filename): Use file name style
1777         to print file name.
1778         (print_symbol_info): Likewise.
1779         (print_msymbol_info): Use address style to print addresses.
1780         Use function name style to print executable text symbols.
1781         (expand_symtab_containing_pc): Use data_p.
1782         (find_pc_sect_compunit_symtab): Likewise.
1783
1784 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1785
1786         * breakpoint.c (describe_other_breakpoints): Use address style
1787         to print addresses.
1788         (say_where): Likewise.
1789
1790 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1791
1792         * ada-typeprint.c (print_func_type): Print function name
1793         style to print function name.
1794         * c-typeprint.c (c_print_type_1): Likewise.
1795
1796 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1797
1798         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1799         for execve.
1800
1801 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1802
1803         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1804         type_stack.
1805
1806 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1807
1808         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1809         TYPE_CODE_REF types.
1810
1811 2019-02-08  Jim Wilson  <jimw@sifive.com>
1812
1813         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1814         (riscv_linux_fregset): New.
1815         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1816
1817 2019-02-07  Tom Tromey  <tom@tromey.com>
1818
1819         * thread.c (thread_cancel_execution_command): Update.
1820         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1821         methods.
1822         (struct thread_fsm_ops): Remove.
1823         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1824         (thread_fsm_should_stop, thread_fsm_return_value)
1825         (thread_fsm_set_finished, thread_fsm_finished_p)
1826         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1827         Don't declare.
1828         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1829         * infrun.c (clear_proceed_status_thread)
1830         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1831         (print_stop_event): Update.
1832         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1833         Add constructor.
1834         (step_command_fsm_ops): Remove.
1835         (new_step_command_fsm): Remove.
1836         (step_1): Update.
1837         (step_command_fsm::should_stop): Rename from
1838         step_command_fsm_should_stop.
1839         (step_command_fsm::clean_up): Rename from
1840         step_command_fsm_clean_up.
1841         (step_command_fsm::do_async_reply_reason): Rename from
1842         step_command_fsm_async_reply_reason.
1843         (struct until_next_fsm): Inherit from thread_fsm.  Add
1844         constructor.
1845         (until_next_fsm_ops): Remove.
1846         (new_until_next_fsm): Remove.
1847         (until_next_fsm::should_stop): Rename from
1848         until_next_fsm_should_stop.
1849         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1850         (until_next_fsm::do_async_reply_reason): Rename from
1851         until_next_fsm_async_reply_reason.
1852         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1853         constructor.  Change type of breakpoint.
1854         (finish_command_fsm_ops): Remove.
1855         (new_finish_command_fsm): Remove.
1856         (finish_command_fsm::should_stop): Rename from
1857         finish_command_fsm_should_stop.
1858         (finish_command_fsm::clean_up): Rename from
1859         finish_command_fsm_clean_up.
1860         (finish_command_fsm::return_value): Rename from
1861         finish_command_fsm_return_value.
1862         (finish_command_fsm::do_async_reply_reason): Rename from
1863         finish_command_fsm_async_reply_reason.
1864         (finish_command): Update.
1865         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1866         Add constructor.
1867         (call_thread_fsm_ops): Remove.
1868         (call_thread_fsm::call_thread_fsm): Rename from
1869         new_call_thread_fsm.
1870         (call_thread_fsm::should_stop): Rename from
1871         call_thread_fsm_should_stop.
1872         (call_thread_fsm::should_notify_stop): Rename from
1873         call_thread_fsm_should_notify_stop.
1874         (run_inferior_call, call_function_by_hand_dummy): Update.
1875         * cli/cli-interp.c (should_print_stop_to_console): Update.
1876         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1877         Add constructor.  Change type of location_breakpoint,
1878         caller_breakpoint.
1879         (until_break_fsm_ops): Remove.
1880         (new_until_break_fsm): Remove.
1881         (until_break_fsm::should_stop): Rename from
1882         until_break_fsm_should_stop.
1883         (until_break_fsm::clean_up): Rename from
1884         until_break_fsm_clean_up.
1885         (until_break_fsm::do_async_reply_reason): Rename from
1886         until_break_fsm_async_reply_reason.
1887         (until_break_command): Update.
1888         * thread-fsm.c: Remove.
1889         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1890
1891 2019-02-07  Tom Tromey  <tom@tromey.com>
1892
1893         * yy-remap.h: Add include guard.
1894         * xtensa-tdep.h: Add include guard.
1895         * xcoffread.h: Rename include guard.
1896         * varobj-iter.h: Add include guard.
1897         * tui/tui.h: Rename include guard.
1898         * tui/tui-winsource.h: Rename include guard.
1899         * tui/tui-wingeneral.h: Rename include guard.
1900         * tui/tui-windata.h: Rename include guard.
1901         * tui/tui-win.h: Rename include guard.
1902         * tui/tui-stack.h: Rename include guard.
1903         * tui/tui-source.h: Rename include guard.
1904         * tui/tui-regs.h: Rename include guard.
1905         * tui/tui-out.h: Rename include guard.
1906         * tui/tui-layout.h: Rename include guard.
1907         * tui/tui-io.h: Rename include guard.
1908         * tui/tui-hooks.h: Rename include guard.
1909         * tui/tui-file.h: Rename include guard.
1910         * tui/tui-disasm.h: Rename include guard.
1911         * tui/tui-data.h: Rename include guard.
1912         * tui/tui-command.h: Rename include guard.
1913         * tic6x-tdep.h: Add include guard.
1914         * target/waitstatus.h: Rename include guard.
1915         * target/wait.h: Rename include guard.
1916         * target/target.h: Rename include guard.
1917         * target/resume.h: Rename include guard.
1918         * target-float.h: Rename include guard.
1919         * stabsread.h: Add include guard.
1920         * rs6000-tdep.h: Add include guard.
1921         * riscv-fbsd-tdep.h: Add include guard.
1922         * regformats/regdef.h: Rename include guard.
1923         * record.h: Rename include guard.
1924         * python/python.h: Rename include guard.
1925         * python/python-internal.h: Rename include guard.
1926         * python/py-stopevent.h: Rename include guard.
1927         * python/py-ref.h: Rename include guard.
1928         * python/py-record.h: Rename include guard.
1929         * python/py-record-full.h: Rename include guard.
1930         * python/py-record-btrace.h: Rename include guard.
1931         * python/py-instruction.h: Rename include guard.
1932         * python/py-events.h: Rename include guard.
1933         * python/py-event.h: Rename include guard.
1934         * procfs.h: Add include guard.
1935         * proc-utils.h: Add include guard.
1936         * p-lang.h: Add include guard.
1937         * or1k-tdep.h: Rename include guard.
1938         * observable.h: Rename include guard.
1939         * nto-tdep.h: Rename include guard.
1940         * nat/x86-linux.h: Rename include guard.
1941         * nat/x86-linux-dregs.h: Rename include guard.
1942         * nat/x86-gcc-cpuid.h: Add include guard.
1943         * nat/x86-dregs.h: Rename include guard.
1944         * nat/x86-cpuid.h: Rename include guard.
1945         * nat/ppc-linux.h: Rename include guard.
1946         * nat/mips-linux-watch.h: Rename include guard.
1947         * nat/linux-waitpid.h: Rename include guard.
1948         * nat/linux-ptrace.h: Rename include guard.
1949         * nat/linux-procfs.h: Rename include guard.
1950         * nat/linux-osdata.h: Rename include guard.
1951         * nat/linux-nat.h: Rename include guard.
1952         * nat/linux-namespaces.h: Rename include guard.
1953         * nat/linux-btrace.h: Rename include guard.
1954         * nat/glibc_thread_db.h: Rename include guard.
1955         * nat/gdb_thread_db.h: Rename include guard.
1956         * nat/gdb_ptrace.h: Rename include guard.
1957         * nat/fork-inferior.h: Rename include guard.
1958         * nat/amd64-linux-siginfo.h: Rename include guard.
1959         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1960         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1961         * nat/aarch64-linux.h: Rename include guard.
1962         * nat/aarch64-linux-hw-point.h: Rename include guard.
1963         * mn10300-tdep.h: Add include guard.
1964         * mips-linux-tdep.h: Add include guard.
1965         * mi/mi-parse.h: Rename include guard.
1966         * mi/mi-out.h: Rename include guard.
1967         * mi/mi-main.h: Rename include guard.
1968         * mi/mi-interp.h: Rename include guard.
1969         * mi/mi-getopt.h: Rename include guard.
1970         * mi/mi-console.h: Rename include guard.
1971         * mi/mi-common.h: Rename include guard.
1972         * mi/mi-cmds.h: Rename include guard.
1973         * mi/mi-cmd-break.h: Rename include guard.
1974         * m2-lang.h: Add include guard.
1975         * location.h: Rename include guard.
1976         * linux-record.h: Rename include guard.
1977         * linux-nat.h: Add include guard.
1978         * linux-fork.h: Add include guard.
1979         * i386-darwin-tdep.h: Rename include guard.
1980         * hppa-linux-offsets.h: Add include guard.
1981         * guile/guile.h: Rename include guard.
1982         * guile/guile-internal.h: Rename include guard.
1983         * gnu-nat.h: Rename include guard.
1984         * gdb-stabs.h: Rename include guard.
1985         * frv-tdep.h: Add include guard.
1986         * f-lang.h: Add include guard.
1987         * event-loop.h: Add include guard.
1988         * darwin-nat.h: Rename include guard.
1989         * cp-abi.h: Rename include guard.
1990         * config/sparc/nm-sol2.h: Rename include guard.
1991         * config/nm-nto.h: Rename include guard.
1992         * config/nm-linux.h: Add include guard.
1993         * config/i386/nm-i386gnu.h: Rename include guard.
1994         * config/djgpp/nl_types.h: Rename include guard.
1995         * config/djgpp/langinfo.h: Rename include guard.
1996         * compile/gcc-cp-plugin.h: Add include guard.
1997         * compile/gcc-c-plugin.h: Add include guard.
1998         * compile/compile.h: Rename include guard.
1999         * compile/compile-object-run.h: Rename include guard.
2000         * compile/compile-object-load.h: Rename include guard.
2001         * compile/compile-internal.h: Rename include guard.
2002         * compile/compile-cplus.h: Rename include guard.
2003         * compile/compile-c.h: Rename include guard.
2004         * common/xml-utils.h: Rename include guard.
2005         * common/x86-xstate.h: Rename include guard.
2006         * common/version.h: Rename include guard.
2007         * common/vec.h: Rename include guard.
2008         * common/tdesc.h: Rename include guard.
2009         * common/selftest.h: Rename include guard.
2010         * common/scoped_restore.h: Rename include guard.
2011         * common/scoped_mmap.h: Rename include guard.
2012         * common/scoped_fd.h: Rename include guard.
2013         * common/safe-iterator.h: Rename include guard.
2014         * common/run-time-clock.h: Rename include guard.
2015         * common/refcounted-object.h: Rename include guard.
2016         * common/queue.h: Rename include guard.
2017         * common/ptid.h: Rename include guard.
2018         * common/print-utils.h: Rename include guard.
2019         * common/preprocessor.h: Rename include guard.
2020         * common/pathstuff.h: Rename include guard.
2021         * common/observable.h: Rename include guard.
2022         * common/netstuff.h: Rename include guard.
2023         * common/job-control.h: Rename include guard.
2024         * common/host-defs.h: Rename include guard.
2025         * common/gdb_wait.h: Rename include guard.
2026         * common/gdb_vecs.h: Rename include guard.
2027         * common/gdb_unlinker.h: Rename include guard.
2028         * common/gdb_unique_ptr.h: Rename include guard.
2029         * common/gdb_tilde_expand.h: Rename include guard.
2030         * common/gdb_sys_time.h: Rename include guard.
2031         * common/gdb_string_view.h: Rename include guard.
2032         * common/gdb_splay_tree.h: Rename include guard.
2033         * common/gdb_setjmp.h: Rename include guard.
2034         * common/gdb_ref_ptr.h: Rename include guard.
2035         * common/gdb_optional.h: Rename include guard.
2036         * common/gdb_locale.h: Rename include guard.
2037         * common/gdb_assert.h: Rename include guard.
2038         * common/filtered-iterator.h: Rename include guard.
2039         * common/filestuff.h: Rename include guard.
2040         * common/fileio.h: Rename include guard.
2041         * common/environ.h: Rename include guard.
2042         * common/common-utils.h: Rename include guard.
2043         * common/common-types.h: Rename include guard.
2044         * common/common-regcache.h: Rename include guard.
2045         * common/common-inferior.h: Rename include guard.
2046         * common/common-gdbthread.h: Rename include guard.
2047         * common/common-exceptions.h: Rename include guard.
2048         * common/common-defs.h: Rename include guard.
2049         * common/common-debug.h: Rename include guard.
2050         * common/cleanups.h: Rename include guard.
2051         * common/buffer.h: Rename include guard.
2052         * common/btrace-common.h: Rename include guard.
2053         * common/break-common.h: Rename include guard.
2054         * cli/cli-utils.h: Rename include guard.
2055         * cli/cli-style.h: Rename include guard.
2056         * cli/cli-setshow.h: Rename include guard.
2057         * cli/cli-script.h: Rename include guard.
2058         * cli/cli-interp.h: Rename include guard.
2059         * cli/cli-decode.h: Rename include guard.
2060         * cli/cli-cmds.h: Rename include guard.
2061         * charset-list.h: Add include guard.
2062         * buildsym-legacy.h: Rename include guard.
2063         * bfin-tdep.h: Add include guard.
2064         * ax.h: Rename include guard.
2065         * arm-linux-tdep.h: Add include guard.
2066         * arm-fbsd-tdep.h: Add include guard.
2067         * arch/xtensa.h: Rename include guard.
2068         * arch/tic6x.h: Add include guard.
2069         * arch/i386.h: Add include guard.
2070         * arch/arm.h: Rename include guard.
2071         * arch/arm-linux.h: Rename include guard.
2072         * arch/arm-get-next-pcs.h: Rename include guard.
2073         * arch/amd64.h: Add include guard.
2074         * arch/aarch64-insn.h: Rename include guard.
2075         * arch-utils.h: Rename include guard.
2076         * annotate.h: Add include guard.
2077         * amd64-darwin-tdep.h: Rename include guard.
2078         * aarch64-linux-tdep.h: Add include guard.
2079         * aarch64-fbsd-tdep.h: Add include guard.
2080         * aarch32-linux-nat.h: Add include guard.
2081
2082 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2083
2084         * macrotab.c (macro_define_internal): New function that
2085         factorizes macro_define_object_internal and macro_define_function
2086         code.
2087         (macro_define_object_internal): Use macro_define_internal.
2088         (macro_define_function): Likewise.
2089
2090 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2091
2092         * macrocmd.c (extract_identifier): Return
2093         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2094         callers.
2095
2096 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2097
2098         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2099
2100 2019-02-05  Tom Tromey  <tom@tromey.com>
2101
2102         * target.c (target_stack::unpush): Move assertion earlier.
2103
2104 2019-01-30  Tom Tromey  <tom@tromey.com>
2105
2106         PR python/23615:
2107         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2108         (gdbpy_parse_and_eval): Likewise.
2109         * python/python-internal.h (gdbpy_allow_threads): New class.
2110
2111 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2112
2113         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2114         (aarch64_fbsd_fpregmap): Move earlier.
2115         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2116         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2117         instead of individual calls to trad_frame_set_reg_addr.
2118         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2119         earlier.
2120         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2121         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2122         instead of individual calls to trad_frame_set_reg_addr.
2123
2124 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2125
2126         * CONTRIBUTE: Replace contribution list with wiki link.
2127
2128 2019-01-25  Tom Tromey  <tom@tromey.com>
2129
2130         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2131
2132 2019-01-25  Tom Tromey  <tom@tromey.com>
2133
2134         * xtensa-linux-nat.c: Fix common/ includes.
2135         * xml-support.h: Fix common/ includes.
2136         * xml-support.c: Fix common/ includes.
2137         * x86-linux-nat.c: Fix common/ includes.
2138         * windows-nat.c: Fix common/ includes.
2139         * varobj.h: Fix common/ includes.
2140         * varobj.c: Fix common/ includes.
2141         * value.c: Fix common/ includes.
2142         * valops.c: Fix common/ includes.
2143         * utils.c: Fix common/ includes.
2144         * unittests/xml-utils-selftests.c: Fix common/ includes.
2145         * unittests/utils-selftests.c: Fix common/ includes.
2146         * unittests/unpack-selftests.c: Fix common/ includes.
2147         * unittests/tracepoint-selftests.c: Fix common/ includes.
2148         * unittests/style-selftests.c: Fix common/ includes.
2149         * unittests/string_view-selftests.c: Fix common/ includes.
2150         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2151         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2152         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2153         * unittests/rsp-low-selftests.c: Fix common/ includes.
2154         * unittests/parse-connection-spec-selftests.c: Fix common/
2155         includes.
2156         * unittests/optional-selftests.c: Fix common/ includes.
2157         * unittests/offset-type-selftests.c: Fix common/ includes.
2158         * unittests/observable-selftests.c: Fix common/ includes.
2159         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2160         * unittests/memrange-selftests.c: Fix common/ includes.
2161         * unittests/memory-map-selftests.c: Fix common/ includes.
2162         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2163         * unittests/function-view-selftests.c: Fix common/ includes.
2164         * unittests/environ-selftests.c: Fix common/ includes.
2165         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2166         * unittests/common-utils-selftests.c: Fix common/ includes.
2167         * unittests/cli-utils-selftests.c: Fix common/ includes.
2168         * unittests/array-view-selftests.c: Fix common/ includes.
2169         * ui-file.c: Fix common/ includes.
2170         * tui/tui-io.c: Fix common/ includes.
2171         * tracepoint.h: Fix common/ includes.
2172         * tracepoint.c: Fix common/ includes.
2173         * tracefile-tfile.c: Fix common/ includes.
2174         * top.h: Fix common/ includes.
2175         * top.c: Fix common/ includes.
2176         * thread.c: Fix common/ includes.
2177         * target/waitstatus.h: Fix common/ includes.
2178         * target/waitstatus.c: Fix common/ includes.
2179         * target.h: Fix common/ includes.
2180         * target.c: Fix common/ includes.
2181         * target-memory.c: Fix common/ includes.
2182         * target-descriptions.c: Fix common/ includes.
2183         * symtab.h: Fix common/ includes.
2184         * symfile.c: Fix common/ includes.
2185         * stap-probe.c: Fix common/ includes.
2186         * spu-linux-nat.c: Fix common/ includes.
2187         * sparc-nat.c: Fix common/ includes.
2188         * source.c: Fix common/ includes.
2189         * solib.c: Fix common/ includes.
2190         * solib-target.c: Fix common/ includes.
2191         * ser-unix.c: Fix common/ includes.
2192         * ser-tcp.c: Fix common/ includes.
2193         * ser-pipe.c: Fix common/ includes.
2194         * ser-base.c: Fix common/ includes.
2195         * selftest-arch.c: Fix common/ includes.
2196         * s12z-tdep.c: Fix common/ includes.
2197         * rust-exp.y: Fix common/ includes.
2198         * rs6000-aix-tdep.c: Fix common/ includes.
2199         * riscv-tdep.c: Fix common/ includes.
2200         * remote.c: Fix common/ includes.
2201         * remote-notif.h: Fix common/ includes.
2202         * remote-fileio.h: Fix common/ includes.
2203         * remote-fileio.c: Fix common/ includes.
2204         * regcache.h: Fix common/ includes.
2205         * regcache.c: Fix common/ includes.
2206         * record-btrace.c: Fix common/ includes.
2207         * python/python.c: Fix common/ includes.
2208         * python/py-type.c: Fix common/ includes.
2209         * python/py-inferior.c: Fix common/ includes.
2210         * progspace.h: Fix common/ includes.
2211         * producer.c: Fix common/ includes.
2212         * procfs.c: Fix common/ includes.
2213         * proc-api.c: Fix common/ includes.
2214         * printcmd.c: Fix common/ includes.
2215         * ppc-linux-nat.c: Fix common/ includes.
2216         * parser-defs.h: Fix common/ includes.
2217         * osdata.c: Fix common/ includes.
2218         * obsd-nat.c: Fix common/ includes.
2219         * nat/x86-linux.c: Fix common/ includes.
2220         * nat/x86-linux-dregs.c: Fix common/ includes.
2221         * nat/x86-dregs.h: Fix common/ includes.
2222         * nat/x86-dregs.c: Fix common/ includes.
2223         * nat/ppc-linux.c: Fix common/ includes.
2224         * nat/mips-linux-watch.h: Fix common/ includes.
2225         * nat/mips-linux-watch.c: Fix common/ includes.
2226         * nat/linux-waitpid.c: Fix common/ includes.
2227         * nat/linux-ptrace.h: Fix common/ includes.
2228         * nat/linux-ptrace.c: Fix common/ includes.
2229         * nat/linux-procfs.c: Fix common/ includes.
2230         * nat/linux-personality.c: Fix common/ includes.
2231         * nat/linux-osdata.c: Fix common/ includes.
2232         * nat/linux-namespaces.c: Fix common/ includes.
2233         * nat/linux-btrace.h: Fix common/ includes.
2234         * nat/linux-btrace.c: Fix common/ includes.
2235         * nat/fork-inferior.c: Fix common/ includes.
2236         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2237         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2238         * nat/aarch64-linux.c: Fix common/ includes.
2239         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2240         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2241         * namespace.h: Fix common/ includes.
2242         * mips-linux-tdep.c: Fix common/ includes.
2243         * minsyms.c: Fix common/ includes.
2244         * mi/mi-parse.h: Fix common/ includes.
2245         * mi/mi-main.c: Fix common/ includes.
2246         * mi/mi-cmd-env.c: Fix common/ includes.
2247         * memrange.h: Fix common/ includes.
2248         * memattr.c: Fix common/ includes.
2249         * maint.h: Fix common/ includes.
2250         * maint.c: Fix common/ includes.
2251         * main.c: Fix common/ includes.
2252         * machoread.c: Fix common/ includes.
2253         * location.c: Fix common/ includes.
2254         * linux-thread-db.c: Fix common/ includes.
2255         * linux-nat.c: Fix common/ includes.
2256         * linux-fork.c: Fix common/ includes.
2257         * inline-frame.c: Fix common/ includes.
2258         * infrun.c: Fix common/ includes.
2259         * inflow.c: Fix common/ includes.
2260         * inferior.h: Fix common/ includes.
2261         * inferior.c: Fix common/ includes.
2262         * infcmd.c: Fix common/ includes.
2263         * inf-ptrace.c: Fix common/ includes.
2264         * inf-child.c: Fix common/ includes.
2265         * ia64-linux-nat.c: Fix common/ includes.
2266         * i387-tdep.c: Fix common/ includes.
2267         * i386-tdep.c: Fix common/ includes.
2268         * i386-linux-tdep.c: Fix common/ includes.
2269         * i386-linux-nat.c: Fix common/ includes.
2270         * i386-go32-tdep.c: Fix common/ includes.
2271         * i386-fbsd-tdep.c: Fix common/ includes.
2272         * i386-fbsd-nat.c: Fix common/ includes.
2273         * guile/scm-type.c: Fix common/ includes.
2274         * guile/guile.c: Fix common/ includes.
2275         * go32-nat.c: Fix common/ includes.
2276         * gnu-nat.c: Fix common/ includes.
2277         * gdbthread.h: Fix common/ includes.
2278         * gdbarch-selftests.c: Fix common/ includes.
2279         * gdb_usleep.c: Fix common/ includes.
2280         * gdb_select.h: Fix common/ includes.
2281         * gdb_bfd.c: Fix common/ includes.
2282         * gcore.c: Fix common/ includes.
2283         * fork-child.c: Fix common/ includes.
2284         * findvar.c: Fix common/ includes.
2285         * fbsd-nat.c: Fix common/ includes.
2286         * event-top.c: Fix common/ includes.
2287         * event-loop.c: Fix common/ includes.
2288         * dwarf2read.c: Fix common/ includes.
2289         * dwarf2loc.c: Fix common/ includes.
2290         * dwarf2-frame.c: Fix common/ includes.
2291         * dwarf-index-cache.c: Fix common/ includes.
2292         * dtrace-probe.c: Fix common/ includes.
2293         * disasm-selftests.c: Fix common/ includes.
2294         * defs.h: Fix common/ includes.
2295         * csky-tdep.c: Fix common/ includes.
2296         * cp-valprint.c: Fix common/ includes.
2297         * cp-support.h: Fix common/ includes.
2298         * cp-support.c: Fix common/ includes.
2299         * corelow.c: Fix common/ includes.
2300         * completer.h: Fix common/ includes.
2301         * completer.c: Fix common/ includes.
2302         * compile/compile.c: Fix common/ includes.
2303         * compile/compile-loc2c.c: Fix common/ includes.
2304         * compile/compile-cplus-types.c: Fix common/ includes.
2305         * compile/compile-cplus-symbols.c: Fix common/ includes.
2306         * command.h: Fix common/ includes.
2307         * cli/cli-dump.c: Fix common/ includes.
2308         * cli/cli-cmds.c: Fix common/ includes.
2309         * charset.c: Fix common/ includes.
2310         * build-id.c: Fix common/ includes.
2311         * btrace.h: Fix common/ includes.
2312         * btrace.c: Fix common/ includes.
2313         * breakpoint.h: Fix common/ includes.
2314         * breakpoint.c: Fix common/ includes.
2315         * ax.h:
2316         (enum agent_op): Fix common/ includes.
2317         * ax-general.c (struct aop_map): Fix common/ includes.
2318         * ax-gdb.c: Fix common/ includes.
2319         * auxv.c: Fix common/ includes.
2320         * auto-load.c: Fix common/ includes.
2321         * arm-tdep.c: Fix common/ includes.
2322         * arch/riscv.c: Fix common/ includes.
2323         * arch/ppc-linux-common.c: Fix common/ includes.
2324         * arch/i386.c: Fix common/ includes.
2325         * arch/arm.c: Fix common/ includes.
2326         * arch/arm-linux.c: Fix common/ includes.
2327         * arch/arm-get-next-pcs.c: Fix common/ includes.
2328         * arch/amd64.c: Fix common/ includes.
2329         * arch/aarch64.c: Fix common/ includes.
2330         * arch/aarch64-insn.c: Fix common/ includes.
2331         * arch-utils.c: Fix common/ includes.
2332         * amd64-windows-tdep.c: Fix common/ includes.
2333         * amd64-tdep.c: Fix common/ includes.
2334         * amd64-sol2-tdep.c: Fix common/ includes.
2335         * amd64-obsd-tdep.c: Fix common/ includes.
2336         * amd64-nbsd-tdep.c: Fix common/ includes.
2337         * amd64-linux-tdep.c: Fix common/ includes.
2338         * amd64-linux-nat.c: Fix common/ includes.
2339         * amd64-fbsd-tdep.c: Fix common/ includes.
2340         * amd64-fbsd-nat.c: Fix common/ includes.
2341         * amd64-dicos-tdep.c: Fix common/ includes.
2342         * amd64-darwin-tdep.c: Fix common/ includes.
2343         * agent.c: Fix common/ includes.
2344         * ada-lang.h: Fix common/ includes.
2345         * ada-lang.c: Fix common/ includes.
2346         * aarch64-tdep.c: Fix common/ includes.
2347
2348 2019-01-25  Tom Tromey  <tom@tromey.com>
2349
2350         * common/create-version.sh: Use common/version.h.
2351
2352 2019-01-24  Pedro Alves  <palves@redhat.com>
2353
2354         * infrun.c (signal_stop, signal_print, signal_program)
2355         (signal_catch, signal_pass): Now arrays instead of pointers.
2356         (update_signals_program_target, do_target_resume)
2357         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2358         * linux-nat.c (linux_nat_target::pass_signals)
2359         (linux_nat_target::create_inferior, linux_nat_target::attach):
2360         Adjust.
2361         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2362         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2363         * procfs.c (procfs_target::pass_signals): Adjust.
2364         * record-full.c (record_full_target::resume): Adjust.
2365         * remote.c (remote_target::pass_signals)
2366         (remote_target::program_signals): Adjust.
2367         * target-debug.h (target_debug_print_signals): Now takes a
2368         gdb::array_view as parameter.  Adjust.
2369         * target.h (target_ops) <pass_signals, program_signals>: Replace
2370         pointer and length parameters with gdb::array_view.
2371         (target_pass_signals, target_program_signals): Likewise.
2372         * target-delegates.c: Regenerate.
2373
2374 2019-01-24  Pedro Alves  <palves@redhat.com>
2375
2376         * common/forward-scope-exit.h
2377         (forward_scope_exit::forward_scope_exit): Pass arguments to
2378         m_bind_function directly, instead of creating a std::bind and
2379         copying that.
2380
2381 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2382
2383         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2384         for static members.
2385         (pass_in_v_vfp_candidate): Likewise.
2386
2387 2019-01-23  Tom Tromey  <tom@tromey.com>
2388             Pedro Alves  <palves@redhat.com>
2389
2390         * regcache.c (class regcache_invalidator): Remove.
2391         (regcache::raw_write): Use make_scope_exit.
2392
2393 2019-01-23  Tom Tromey  <tom@tromey.com>
2394
2395         * ui-out.h (class ui_out_emit_type): Update comment.
2396
2397 2019-01-23  Tom Tromey  <tom@tromey.com>
2398
2399         * infrun.c (fetch_inferior_event): Update comment.
2400
2401 2019-01-23  Tom Tromey  <tom@tromey.com>
2402             Pedro Alves  <palves@redhat.com>
2403
2404         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2405         parameter.
2406         (fetch_inferior_event): Use SCOPE_EXIT.
2407
2408
2409 2019-01-23  Tom Tromey  <tom@tromey.com>
2410             Pedro Alves  <palves@redhat.com>
2411
2412         * infrun.c (disable_thread_events): Delete.
2413         (stop_all_threads): Use SCOPE_EXIT.
2414
2415 2019-01-23  Tom Tromey  <tom@tromey.com>
2416             Pedro Alves  <palves@redhat.com>
2417
2418         * symfile.c: Include forward-scope-exit.h.
2419         (clear_symtab_users_cleanup): Replace forward declaration with
2420         a FORWARD_SCOPE_EXIT.
2421         (syms_from_objfile_1): Use the forward_scope_exit and
2422         gdb::optional instead of cleanup_function.
2423         (reread_symbols): Use the forward_scope_exit instead of
2424         cleanup_function.
2425         (clear_symtab_users_cleanup): Remove function.
2426
2427 2019-01-23  Tom Tromey  <tom@tromey.com>
2428             Pedro Alves  <palves@redhat.com>
2429
2430         * linux-nat.c: Include scope-exit.h.
2431         (cleanup_target_stop): Remove.
2432         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2433         SCOPE_EXIT.
2434
2435 2019-01-23  Tom Tromey  <tom@tromey.com>
2436             Pedro Alves  <palves@redhat.com>
2437
2438         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2439         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2440
2441 2019-01-23  Tom Tromey  <tom@tromey.com>
2442             Andrew Burgess  <andrew.burgess@embecosm.com>
2443             Pedro Alves  <palves@redhat.com>
2444
2445         * infrun.c (fetch_inferior_event): Use scope_exit.
2446         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2447         * top.c (execute_command): Use scope_exit.
2448         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2449         * utils.c (do_bpstat_clear_actions_cleanup)
2450         (make_bpstat_clear_actions_cleanup): Remove.
2451
2452 2019-01-23  Tom Tromey  <tom@tromey.com>
2453             Pedro Alves  <palves@redhat.com>
2454
2455         * infrun.c: Include "common/scope-exit.h"
2456         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2457         (wait_for_inferior): Use SCOPE_EXIT.
2458         (fetch_inferior_event): Use scope_exit.
2459
2460 2019-01-23  Tom Tromey  <tom@tromey.com>
2461             Pedro Alves  <palves@redhat.com>
2462
2463         * breakpoint.c (create_breakpoint): Remove cleanup.
2464
2465 2019-01-23  Tom Tromey  <tom@tromey.com>
2466             Andrew Burgess  <andrew.burgess@embecosm.com>
2467             Pedro Alves  <palves@redhat.com>
2468
2469 2019-01-23  Pedro Alves  <palves@redhat.com>
2470
2471         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2472
2473 2019-01-23  Pedro Alves  <palves@redhat.com>
2474             Andrew Burgess  <andrew.burgess@embecosm.com>
2475
2476         * gdbthread.h: Include "common/forward-scope-exit.h".
2477         (scoped_finish_thread_state): Redefine custom class in terms of
2478         forward_scope_exit.
2479
2480 2019-01-23  Pedro Alves  <palves@redhat.com>
2481             Andrew Burgess  <andrew.burgess@embecosm.com>
2482
2483         * common/forward-scope-exit.h: New file.
2484
2485 2019-01-23  Pedro Alves  <palves@redhat.com>
2486             Andrew Burgess  <andrew.burgess@embecosm.com>
2487             Tom Tromey  <tom@tromey.com>
2488
2489         * common/scope-exit.h: New file.
2490
2491 2019-01-23  Pedro Alves  <palves@redhat.com>
2492
2493         * common/preprocessor.h (ESC): Rename to ...
2494         (ESC_PARENS): ... this.
2495         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2496         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2497
2498 2019-01-23  Tom Tromey  <tom@tromey.com>
2499
2500         * language.h (class scoped_switch_to_sym_language_if_auto):
2501         Initialize m_lang in both cases.
2502
2503 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2504
2505         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2506         with XCNEW.
2507
2508 2019-01-22  Tom Tromey  <tom@tromey.com>
2509
2510         * corelow.c: Do not include sys/file.h.
2511
2512 2019-01-22  Tom Tromey  <tom@tromey.com>
2513
2514         * tui/tui-wingeneral.h: Include gdb_curses.h.
2515
2516 2019-01-22  Tom Tromey  <tom@tromey.com>
2517
2518         * source-cache.h (class source_cache) <get_source_lines,
2519         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2520
2521 2019-01-22  Tom Tromey  <tom@tromey.com>
2522
2523         * remote-fileio.h (struct remote_target): Declare.
2524
2525 2019-01-22  Tom Tromey  <tom@tromey.com>
2526
2527         * python/py-arch.c: Do not include py-ref.h.
2528         * python/py-bpevent.c: Do not include py-ref.h.
2529         * python/py-cmd.c: Do not include py-ref.h.
2530         * python/py-continueevent.c: Do not include py-ref.h.
2531         * python/py-event.h: Do not include py-ref.h.
2532         * python/py-evtregistry.c: Do not include py-ref.h.
2533         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2534         * python/py-frame.c: Do not include py-ref.h.
2535         * python/py-framefilter.c: Do not include py-ref.h.
2536         * python/py-function.c: Do not include py-ref.h.
2537         * python/py-infevents.c: Do not include py-ref.h.
2538         * python/py-linetable.c: Do not include py-ref.h.
2539         * python/py-objfile.c: Do not include py-ref.h.
2540         * python/py-param.c: Do not include py-ref.h.
2541         * python/py-prettyprint.c: Do not include py-ref.h.
2542         * python/py-progspace.c: Do not include py-ref.h.
2543         * python/py-symbol.c: Do not include py-ref.h.
2544         * python/py-symtab.c: Do not include py-ref.h.
2545         * python/py-type.c: Do not include py-ref.h.
2546         * python/py-unwind.c: Do not include py-ref.h.
2547         * python/py-utils.c: Do not include py-ref.h.
2548         * python/py-value.c: Do not include py-ref.h.
2549         * python/py-varobj.c: Do not include py-ref.h.
2550         * python/py-xmethods.c: Do not include py-ref.h.
2551         * python/python.c: Do not include py-ref.h.
2552         * varobj.c: Do not include py-ref.h.
2553
2554 2019-01-22  Tom Tromey  <tom@tromey.com>
2555
2556         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2557         keyword for bcache.
2558
2559 2019-01-22  Tom Tromey  <tom@tromey.com>
2560
2561         * compile/compile-cplus-types.c: Remove a comment by #include.
2562
2563 2019-01-22  Tom Tromey  <tom@tromey.com>
2564
2565         * compile/gcc-c-plugin.h: Include compile-internal.h.
2566
2567 2019-01-22  Tom Tromey  <tom@tromey.com>
2568
2569         * stabsread.c (EXTERN): Do not define.
2570         (symnum, next_symbol_text_func, processing_gcc_compilation)
2571         (within_function, global_sym_chain, global_stabs)
2572         (previous_stab_code, this_object_header_files)
2573         (n_this_object_header_files)
2574         (n_allocated_this_object_header_files): Define.
2575         * stabsread.h (EXTERN): Never define.  Use "extern".
2576
2577 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2578
2579         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2580         history_value.
2581
2582 2019-01-21  Tom Tromey  <tom@tromey.com>
2583
2584         * ui-out.c: Fix includes.
2585         * tui/tui-source.c: Fix includes.
2586         * target.c: Fix includes.
2587         * remote.c: Fix includes.
2588         * regcache.c: Fix includes.
2589         * python/py-block.c: Fix includes.
2590         * printcmd.c: Fix includes.
2591         * or1k-tdep.c: Fix includes.
2592         * mi/mi-main.c: Fix includes.
2593         * m32r-tdep.c: Fix includes.
2594         * csky-tdep.c: Fix includes.
2595         * compile/compile-cplus-types.c: Fix includes.
2596         * cli/cli-interp.c: Fix includes.
2597
2598 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2599
2600         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2601         for padding.
2602
2603 2019-01-16  Tom Tromey  <tom@tromey.com>
2604
2605         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2606         earlier.
2607         (struct objfile) <msymbols_range>: Move from top level.
2608         <msymbols>: New method.
2609         (class objfile_msymbols): Remove.
2610         * symtab.c (default_collect_symbol_completion_matches_break_on):
2611         Update.
2612         * symmisc.c (dump_msymbols): Update.
2613         * stabsread.c (scan_file_globals): Update.
2614         * objc-lang.c (info_selectors_command, info_classes_command)
2615         (find_methods): Update.
2616         * minsyms.c (find_solib_trampoline_target): Update.
2617         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2618         * coffread.c (coff_symfile_read): Update.
2619         * ada-lang.c (ada_lookup_simple_minsym)
2620         (ada_collect_symbol_completion_matches): Update.
2621
2622 2019-01-16  Tom Tromey  <tom@tromey.com>
2623
2624         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2625         type.  Remove no-argument constructor.
2626         <iterator::operator++>: Simplify.
2627         <begin>: Update.
2628         <end>: Use minimal_symbol_count.
2629
2630 2019-01-16  Tom Tromey  <tom@tromey.com>
2631
2632         * objfiles.h (struct objfile) <psymtabs>: New method.
2633         (class objfile_psymtabs): Remove.
2634         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2635         typedef.
2636         <range>: New method.
2637         (require_partial_symbols): Change return type.
2638         * psymtab.c (require_partial_symbols)
2639         (psym_expand_symtabs_matching): Update.
2640         * mdebugread.c (parse_partial_symbols): Update.
2641         * dbxread.c (dbx_end_psymtab): Update.
2642
2643 2019-01-15  Tom Tromey  <tom@tromey.com>
2644
2645         * symtab.c (lookup_objfile_from_block)
2646         (lookup_symbol_in_objfile_symtabs)
2647         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2648         (find_line_symtab, info_sources_command)
2649         (default_collect_symbol_completion_matches_break_on)
2650         (make_source_files_completion_list): Update.
2651         * symmisc.c (print_objfile_statistics, dump_objfile)
2652         (maintenance_print_symbols, maintenance_info_symtabs)
2653         (maintenance_check_symtabs, maintenance_info_line_tables):
2654         Update.
2655         * source.c (select_source_symtab)
2656         (forget_cached_source_info_for_objfile): Update.
2657         * objfiles.h (class objfile_compunits): Remove.
2658         (struct objfile) <compunits_range>: New typedef.
2659         (compunits): New method.
2660         * objfiles.c (objfile_relocate1): Update.
2661         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2662         * maint.c (count_symtabs_and_blocks): Update.
2663         * linespec.c (iterate_over_all_matching_symtabs): Update.
2664         * cp-support.c (add_symbol_overload_list_qualified): Update.
2665         * coffread.c (coff_symtab_read): Update.
2666         * ada-lang.c (add_nonlocal_symbols)
2667         (ada_collect_symbol_completion_matches)
2668         (ada_add_global_exceptions): Update.
2669
2670 2019-01-15  Tom Tromey  <tom@tromey.com>
2671
2672         * progspace.h (program_space) <objfiles_safe_range>: New
2673         typedef.
2674         <objfiles_safe>: New method.
2675         * objfiles.h (class all_objfiles_safe): Remove.
2676         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2677         * jit.c (jit_inferior_exit_hook): Update.
2678
2679 2019-01-17  Tom Tromey  <tom@tromey.com>
2680
2681         * progspace.h (program_space) <objfiles_range>: New typedef.
2682         <objfiles>: New method.
2683         <objfiles_head>: Rename from objfiles.
2684         (object_files): Update.
2685         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2686         * guile/scm-pretty-print.c
2687         (ppscm_find_pretty_printer_from_objfiles): Update.
2688         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2689         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2690         Update.
2691         * python/py-progspace.c (pspy_get_objfiles): Update.
2692         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2693         Update.
2694         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2695         (objfpy_lookup_objfile_by_build_id): Update.
2696         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2697         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2698         Update.
2699         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2700         (expand_symtab_containing_pc, lookup_objfile_from_block)
2701         (lookup_static_symbol, basic_lookup_transparent_type)
2702         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2703         (find_line_symtab, info_sources_command)
2704         (default_collect_symbol_completion_matches_break_on)
2705         (make_source_files_completion_list, find_main_name): Update.
2706         * symmisc.c (print_symbol_bcache_statistics)
2707         (print_objfile_statistics, maintenance_print_symbols)
2708         (maintenance_print_msymbols, maintenance_print_objfiles)
2709         (maintenance_info_symtabs, maintenance_check_symtabs)
2710         (maintenance_expand_symtabs, maintenance_info_line_tables):
2711         Update.
2712         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2713         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2714         (map_overlay_command, unmap_overlay_command)
2715         (simple_overlay_update, expand_symtabs_matching)
2716         (map_symbol_filenames): Update.
2717         * symfile-debug.c (set_debug_symfile): Update.
2718         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2719         Update.
2720         * source.c (select_source_symtab, forget_cached_source_info):
2721         Update.
2722         * solib.c (solib_read_symbols): Update.
2723         * solib-spu.c (append_ocl_sos): Update.
2724         * psymtab.c (maintenance_print_psymbols)
2725         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2726         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2727         * printcmd.c (info_symbol_command): Update.
2728         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2729         Update.
2730         * objfiles.h (class all_objfiles): Remove.
2731         * objfiles.c (have_partial_symbols, have_full_symbols)
2732         (have_minimal_symbols, qsort_cmp, update_section_map)
2733         (shared_objfile_contains_address_p)
2734         (default_iterate_over_objfiles_in_search_order): Update.
2735         * objc-lang.c (info_selectors_command, info_classes_command)
2736         (find_methods): Update.
2737         * minsyms.c (find_solib_trampoline_target): Update.
2738         * maint.c (maintenance_info_sections)
2739         (maintenance_translate_address, count_symtabs_and_blocks):
2740         Update.
2741         * main.c (captured_main_1): Update.
2742         * linux-thread-db.c (try_thread_db_load_from_pdir)
2743         (has_libpthread): Update.
2744         * linespec.c (iterate_over_all_matching_symtabs)
2745         (search_minsyms_for_name): Update.
2746         * jit.c (jit_find_objf_with_entry_addr): Update.
2747         * hppa-tdep.c (find_unwind_entry)
2748         (hppa_lookup_stub_minimal_symbol): Update.
2749         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2750         Update.
2751         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2752         (elf_gnu_ifunc_resolve_by_got): Update.
2753         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2754         * dwarf-index-write.c (save_gdb_index_command): Update.
2755         * cp-support.c (add_symbol_overload_list_qualified): Update.
2756         * breakpoint.c (create_overlay_event_breakpoint)
2757         (create_longjmp_master_breakpoint)
2758         (create_std_terminate_master_breakpoint)
2759         (create_exception_master_breakpoint): Update.
2760         * blockframe.c (find_pc_partial_function): Update.
2761         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2762         (ada_collect_symbol_completion_matches)
2763         (ada_add_global_exceptions): Update.
2764
2765 2019-01-17  Tom Tromey  <tom@tromey.com>
2766
2767         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2768         declare VEC.
2769         (solib_target_parse_libraries): Change return type.
2770         (library_list_start_segment, library_list_start_section)
2771         (library_list_end_library, library_list_start_library); Update.
2772         (solib_target_free_library_list): Remove.
2773         (solib_target_parse_libraries): Remove cleanup.  Change return
2774         type.
2775         (solib_target_current_sos): Update.
2776
2777 2019-01-17  Tom Tromey  <tromey@bapiya>
2778
2779         * valprint.c: Replace "the the" with "the".
2780         * symtab.c: Replace "the the" with "the".
2781         * solib.c: Replace "the the" with "the".
2782         * solib-dsbt.c: Replace "the the" with "the".
2783         * linespec.c: Replace "the the" with "the".
2784         * dwarf2loc.h: Replace "the the" with "the".
2785         * amd64-windows-tdep.c: Replace "the the" with "the".
2786         * aarch64-tdep.c: Replace "the the" with "the".
2787
2788 2019-01-16  Keith Seitz  <keiths@redhat.com>
2789
2790         PR gdb/23773
2791         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2792         <builder>: Rename to ..
2793         <m_builder>: ... this and make private.
2794         (dwarf2_cu::get_builder): New method.  Change all users of
2795         `builder' to use this method.
2796         (dwarf2_start_symtab): Move to ...
2797         (dwarf2_cu::start_symtab): ... here.  Update all callers
2798         (setup_type_unit_groups): Move to ...
2799         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2800         callers.
2801         (dwarf2_cu::reset_builder): New method.
2802         (process_full_compunit, process_full_type_unit): Use
2803         dwarf2_cu::reset_builder.
2804         (follow_die_offset): Record the ancestor CU if it is different
2805         from the followed DIE's CU.
2806         (follow_die_sig_1): Likewise.
2807
2808 2019-01-15  Tom Tromey  <tom@tromey.com>
2809
2810         * remote.c (class remote_state) <buf>: Now a char_vector.
2811         <buf_size>: Remove.
2812         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2813         parameter.
2814         (remote_target::getpkt_or_notif_sane_1)
2815         (remote_target::getpkt_sane)
2816         (remote_target::getpkt_or_notif_sane): Likewise.
2817         (class remote_target) <putpkt>: New overload.
2818         (remote_target::read_frame): Change type of "buf_p".  Remove
2819         sizeof_p parameter.
2820         (packet_ok): New overload.
2821         (packet_check_result): New overload.
2822         Update all uses.
2823
2824 2019-01-14  Tom Tromey  <tom@tromey.com>
2825
2826         * remote-notif.c (handle_notification, remote_notif_ack)
2827         (remote_notif_parse): Make "buf" const.
2828         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2829         const.
2830         (remote_notif_parse, remote_notif_ack, handle_notification):
2831         Likewise.
2832         * remote.c (remote_notif_stop_parse): Make "buf" const.
2833         (remote_target::remote_parse_stop_reply): Make "buf" const.
2834         (remote_notif_stop_ack): Make "buf" const.
2835
2836 2019-01-14  Tom Tromey  <tom@tromey.com>
2837
2838         * remote.c (remote_console_output): Make parameter const.
2839
2840 2019-01-14  Tom Tromey  <tom@tromey.com>
2841
2842         * target-debug.h (target_debug_print_signals): Constify.
2843         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2844         * procfs.c (procfs_target::pass_signals): Update.
2845         * linux-nat.c (linux_nat_target::pass_signals): Update.
2846         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2847         * target-delegates.c: Rebuild.
2848         * remote.c (remote_target::program_signals): Update.
2849         (remote_target::pass_signals): Update.
2850         * target.c (target_pass_signals): Constify argument.
2851         (target_program_signals): Likewise.
2852         * target.h (struct target_ops) <pass_signals, program_signals>:
2853         Constify argument.
2854         (target_pass_signals, target_program_signals): Constify argument.
2855
2856 2019-01-14  Tom Tromey  <tom@tromey.com>
2857
2858         PR tui/28819:
2859         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2860
2861 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2862
2863         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2864         field.
2865         * rs6000-tdep.c: Include reggroups.h.
2866         (IS_V_ALIAS_PSEUDOREG): Define.
2867         (rs6000_register_name): Return names for the "vX" aliases.
2868         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2869         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2870         aliases.  Call default_register_reggroup_p for all other
2871         pseudo-registers.
2872         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2873         New functions.
2874         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2875         Handle "vX" aliases.
2876         (v_alias_pseudo_register_collect): New function.
2877         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2878         (rs6000_gdbarch_init): Initialize "vX" aliases as
2879         pseudo-registers.  Restore registration of
2880         rs6000_pseudo_register_reggroup_p with
2881         set_tdesc_pseudo_register_reggroup_p.
2882
2883 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2884
2885         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2886         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2887         set_gdbarch_num_pseudo_regs.
2888
2889 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2890
2891         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2892         Remove arg prefixname, add do_set and do_show.
2893         Add member functions set_list and show_list.
2894         * cli/cli-style.c (class cli_style_option): Update accordingly.
2895         (style_set_list): Move to file scope.
2896         (style_show_list): Likewise.
2897         (set_style): Call help_list.
2898         (show_style): Call cmd_show_list.
2899         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2900         Update to use the new macro.
2901
2902 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2903
2904         * ada-lang.c (_initialize_ada_language): Expand the help text
2905         for the "catch exception" command.
2906
2907 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2908
2909         * symtab.c (matching_obj_sections): Initialize obj,
2910         declare it closer to its usage.
2911
2912 2019-01-10  Tom Tromey  <tom@tromey.com>
2913
2914         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2915         (basic_inf_threads_range): Remove.
2916         (inf_threads_range, inf_non_exited_threads_range)
2917         (safe_inf_threads_range): Use next_adapter.
2918
2919 2019-01-10  Keith Seitz  <keiths@redhat.com>
2920
2921         PR gdb/23712
2922         PR symtab/23010
2923         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2924         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2925
2926 2019-01-10  Keith Seitz  <keiths@redhat.com>
2927
2928         PR gdb/23712
2929         PR symtab/23010
2930         * dictionary.c (pending_to_vector): Remove.
2931         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2932         Remove _1 suffix, replacing functions of the same name.  Update
2933         all callers.
2934         (dict_create_hashed, dict_create_hashed_expandable)
2935         (dict_create_linear, dict_create_linear_expandable, dict_free)
2936         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2937         Make functions static.
2938
2939 2019-01-10  Keith Seitz  <keiths@redhat.com>
2940
2941         PR gdb/23712
2942         PR symtab/23010
2943         * dictionary.h (struct dictionary): Replace declaration with
2944         multidictionary.
2945         (dict_create_hashed, dict_create_hashed_expandable)
2946         (dict_create_linear, dict_create_linear_expandable)
2947         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2948         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2949         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2950         taking multidictionary argument.
2951         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2952         * block.h (struct block) <dict>: Change to multidictionary
2953         and rename `multidict'.
2954         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2955         symmisc.c: Update all dictionary references to multidictionary.
2956
2957 2019-01-10  Keith Seitz  <keiths@redhat.com>
2958
2959         PR gdb/23712
2960         PR symtab/23010
2961         * dictionary.c: Include unordered_map.
2962         (pending_to_vector): New function.
2963         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2964         Rewrite the non-"_1" functions to take vector instead
2965         of linked list.
2966         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2967         "new" _1 versions of the same name.
2968         (multidictionary): Define.
2969         (std::hash<enum language): New definition.
2970         (collate_pending_symbols_by_language, mdict_create_hashed)
2971         (mdict_create_hashed_expandable, mdict_create_linear)
2972         (mdict_create_linear_expandable, mdict_free)
2973         (find_language_dictionary, create_new_language_dictionary)
2974         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2975         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2976         (mdict_size, mdict_empty): New functions.
2977         * dictionary.h (mdict_iterator): Define.
2978
2979 2019-01-10  Pedro Alves  <palves@redhat.com>
2980
2981         * breakpoint.c (read_uploaded_action)
2982         (create_tracepoint_from_upload): Adjust to use
2983         gdb::unique_xmalloc_ptr.
2984         * ctf.c (ctf_write_uploaded_tp):
2985         (SET_ARRAY_FIELD): Use emplace_back.
2986         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2987         * tracefile-tfile.c (tfile_write_uploaded_tp):
2988         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2989         gdb::unique_xmalloc_ptr.
2990         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2991         at_string, cond_string, cmd_strings>: Replace char pointers
2992         with gdb::unique_xmalloc_ptr.
2993
2994 2019-01-10  Pedro Alves  <palves@redhat.com>
2995
2996         * solib-target.c (library_list_start_library): Don't xstrdup name.
2997
2998 2019-01-10  Pedro Alves  <palves@redhat.com>
2999
3000         * mdebugread.c (parse_partial_symbols): Use
3001         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3002
3003 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3004
3005         * linux-fork.c (scoped_switch_fork_info)
3006         <~scoped_switch_fork_info>: Fix incorrect variable name.
3007
3008 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * linux-fork.c (scoped_switch_fork_info)
3011         <scoped_switch_fork_info>: Make explicit.
3012         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3013
3014 2019-01-10  Tom Tromey  <tom@tromey.com>
3015
3016         * objfiles.h (objfile::reset_psymtabs): Update.
3017         * objfiles.c (objfile::objfile): Update.
3018         * psymtab.h (psymtab_storage::obstack): Update.
3019         (psymtab_storage::m_obstack): Use gdb::optional.
3020         (class psymtab_storage): Update comment.  Remove objfile
3021         parameter.
3022         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3023
3024 2019-01-10  Tom Tromey  <tom@tromey.com>
3025
3026         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3027         <free_psymtabs>: Now private.
3028         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3029         (allocate_psymtab): Use new method.
3030
3031 2019-01-10  Tom Tromey  <tom@tromey.com>
3032
3033         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3034         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3035         * mdebugread.c (parse_partial_symbols): Use
3036         allocate_dependencies.
3037         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3038         allocate_dependencies.
3039         (process_psymtab_comp_unit_reader)
3040         (build_type_psymtab_dependencies): Likewise.
3041         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3042
3043 2019-01-10  Tom Tromey  <tom@tromey.com>
3044
3045         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3046         PSYMBOL_SET_LANGUAGE.
3047         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3048
3049 2019-01-10  Tom Tromey  <tom@tromey.com>
3050
3051         * psymtab.h (psymtab_storage::obstack): New method.
3052         <m_obstack>: Rename from obstack; now private.
3053         * psymtab.c (psymtab_storage): Update.
3054         * dwarf2read.c (create_addrmap_from_index)
3055         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3056         Update.
3057
3058 2019-01-10  Tom Tromey  <tom@tromey.com>
3059
3060         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3061         * objfiles.h (objfile::reset_psymtabs): New method.
3062
3063 2019-01-10  Tom Tromey  <tom@tromey.com>
3064
3065         * symmisc.c (print_symbol_bcache_statistics): Update.
3066         (print_objfile_statistics): Update.
3067         * symfile.c (reread_symbols): Update.
3068         * psymtab.h (class psymtab_storage): New.
3069         * psymtab.c (psymtab_storage): New constructor.
3070         (~psymtab_storage): New destructor.
3071         (require_partial_symbols): Update.
3072         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3073         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3074         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3075         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3076         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3077         (start_psymtab_common, end_psymtab_common)
3078         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3079         (allocate_psymtab): Update.
3080         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3081         Update.
3082         (dump_psymtab_addrmap, maintenance_print_psymbols)
3083         (maintenance_check_psymtabs): Update.
3084         (class objfile_psymtabs): Move to objfiles.h.
3085         * psympriv.h (discard_psymtab): Now inline.
3086         (psymtab_discarder::psymtab_discarder): Update.
3087         (psymtab_discarder::~psymtab_discarder): Update.
3088         (ALL_OBJFILE_PSYMTABS): Rewrite.
3089         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3090         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3091         Remove fields.
3092         <partial_symtabs>: New field.
3093         (class objfile_psymtabs): Move from psymtab.h.  Update.
3094         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3095         psymbol_cache.
3096         (objfile::~objfile): Don't destroy psymbol_cache.
3097         * mdebugread.c (parse_partial_symbols): Update.
3098         * dwarf2read.c (create_addrmap_from_index)
3099         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3100         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3101         (add_partial_subprogram, dwarf2_ranges_read): Update.
3102         * dwarf-index-write.c (write_address_map)
3103         (write_one_signatured_type, recursively_write_psymbols)
3104         (class debug_names, class debug_names, write_psymtabs_to_index):
3105         Update.
3106
3107 2019-01-10  Tom Tromey  <tom@tromey.com>
3108
3109         * symtab.h (SYMBOL_SET_NAMES): Update.
3110         (symbol_set_names): Update.
3111         (MSYMBOL_SET_NAMES): Update.
3112         * symtab.c (symbol_set_names): Change argument to be an
3113         objfile_per_bfd_storage.
3114         * psymtab.c (add_psymbol_to_bcache): Update.
3115         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3116
3117 2019-01-10  Tom Tromey  <tom@tromey.com>
3118
3119         * symtab.c (create_demangled_names_hash): Change argument to be an
3120         objfile_per_bfd_storage.
3121         (symbol_set_names): Update.
3122
3123 2019-01-10  Tom Tromey  <tom@tromey.com>
3124
3125         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3126         init_psymbol_list.
3127         * psymtab.c (init_psymbol_list): Do nothing if already called.
3128         * psympriv.h (init_psymbol_list): Add comment.
3129         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3130         init_psymbol_list.
3131         * dbxread.c (dbx_symfile_read): Unconditionally call
3132         init_psymbol_list.
3133
3134 2019-01-10  Tom Tromey  <tom@tromey.com>
3135
3136         * xcoffread.c (scan_xcoff_symtab): Update.
3137         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3138         "where".
3139         * mdebugread.c (parse_partial_symbols)
3140         (handle_psymbol_enumerators): Update.
3141         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3142         * dbxread.c (read_dbx_symtab): Update.
3143         * psympriv.h (psymbol_placement): New enum.
3144         (add_psymbol_to_list): Update.
3145
3146 2019-01-10  Tom Tromey  <tom@tromey.com>
3147
3148         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3149         static_psymbols parameters.
3150         (scan_xcoff_symtab): Update.
3151         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3152         static_psymbols parameters.
3153         * psympriv.h (start_psymtab_common): Update.
3154         * mdebugread.c (parse_partial_symbols): Update.
3155         * dwarf2read.c (create_partial_symtab): Update.
3156         * dbxread.c (read_dbx_symtab): Update.
3157         (start_psymtab): Remove global_psymbols and static_psymbols
3158         parameters.
3159
3160 2019-01-10  Tom Tromey  <tom@tromey.com>
3161
3162         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3163         * psymtab.c (allocate_psymtab): Add comment.
3164         * psympriv.h (allocate_psymtab): Add comment.
3165         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3166         initializations.
3167         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3168
3169 2019-01-10  Tom Tromey  <tom@tromey.com>
3170
3171         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3172         Don't declare.
3173         * mipsread.c: Include mdebugread.h.
3174         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3175         Declare.
3176         * elfread.c: Include mdebugread.h.
3177
3178 2019-01-09  Tom Tromey  <tom@tromey.com>
3179
3180         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3181         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3182         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3183         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3184         (psym_lookup_symbol, psym_find_last_source_symtab)
3185         (psym_forget_cached_source_info, psym_print_stats)
3186         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3187         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3188         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3189         (psym_find_compunit_symtab_by_address)
3190         (maintenance_print_psymbols, maintenance_info_psymtabs)
3191         (maintenance_check_psymtabs): Use ranged for.
3192         * psymtab.h (class objfile_psymtabs): New.
3193         (require_partial_symbols): Return objfile_psymtabs.
3194         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3195
3196 2019-01-09  Tom Tromey  <tom@tromey.com>
3197
3198         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3199         (find_pc_mapped_section, list_overlays_command)
3200         (map_overlay_command, unmap_overlay_command)
3201         (simple_overlay_update): Use all_objfiles.
3202         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3203         * printcmd.c (info_symbol_command): Use all_objfiles.
3204         * objfiles.h (ALL_OBJSECTIONS): Remove.
3205         * maint.c (maintenance_translate_address): Use all_objfiles.
3206         * gcore.c (gcore_create_callback): Use all_objfiles.
3207         (objfile_find_memory_regions): Likewise.
3208
3209 2019-01-09  Tom Tromey  <tom@tromey.com>
3210
3211         * symtab.c (find_line_symtab, info_sources_command)
3212         (make_source_files_completion_list): Use objfile_compunits.
3213         * source.c (select_source_symtab): Use objfile_compunits.
3214         * objfiles.h (struct objfile): Update comment.
3215         (ALL_OBJFILES): Remove.
3216         (ALL_FILETABS): Remove.
3217         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3218         objfile_compunits.
3219
3220 2019-01-09  Tom Tromey  <tom@tromey.com>
3221
3222         * symmisc.c (print_objfile_statistics, dump_objfile)
3223         (maintenance_print_symbols): Use compunit_filetabs.
3224         * source.c (forget_cached_source_info_for_objfile): Use
3225         compunit_filetabs.
3226         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3227         (ALL_FILETABS): Use compunit_filetabs.
3228         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3229         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3230
3231 2019-01-09  Tom Tromey  <tom@tromey.com>
3232
3233         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3234         (compunit_filetabs): New.
3235         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3236         compunit_filetabs.
3237         (info_sources_command, make_source_files_completion_list): Remove
3238         declaration.
3239         * symmisc.c (print_objfile_statistics, dump_objfile)
3240         (maintenance_print_symbols): Remove declaration.
3241         (maintenance_info_symtabs): Use compunit_filetabs.
3242         (maintenance_info_line_tables): Likewise.
3243         * source.c (select_source_symtab): Change local variable name.
3244         (forget_cached_source_info_for_objfile): Remove declaration.
3245         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3246         * objfiles.c (objfile_relocate1): Remove declaration.
3247         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3248         declaration.
3249         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3250         * coffread.c (coff_symtab_read): Remove declaration.
3251         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3252         compunit_filetabs.
3253
3254 2019-01-09  Tom Tromey  <tom@tromey.com>
3255
3256         * symtab.c (lookup_objfile_from_block)
3257         (find_pc_sect_compunit_symtab, search_symbols)
3258         (default_collect_symbol_completion_matches_break_on): Use
3259         objfile_compunits.
3260         * objfiles.h (ALL_COMPUNITS): Remove.
3261         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3262         * cp-support.c (add_symbol_overload_list_qualified): Use
3263         objfile_compunits.
3264         * ada-lang.c (ada_collect_symbol_completion_matches)
3265         (ada_add_global_exceptions): Use objfile_compunits.
3266
3267 2019-01-09  Tom Tromey  <tom@tromey.com>
3268
3269         * source.c (select_source_symtab)
3270         (forget_cached_source_info_for_objfile): Remove declaration.
3271         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3272         declaration.
3273         * maint.c (count_symtabs_and_blocks): Remove declaration.
3274         * cp-support.c (add_symbol_overload_list_qualified): Remove
3275         declaration.
3276         * coffread.c (coff_symtab_read): Remove declaration.
3277         * symtab.c (lookup_symbol_in_objfile_symtabs)
3278         (basic_lookup_transparent_type_1): Use objfile_compunits.
3279         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3280         (info_sources_command, search_symbols)
3281         (default_collect_symbol_completion_matches_break_on)
3282         (make_source_files_completion_list): Remove declaration.
3283         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3284         (ada_collect_symbol_completion_matches)
3285         (ada_add_global_exceptions): Remove declaration.
3286         * linespec.c (iterate_over_all_matching_symtabs): Use
3287         objfile_compunits.
3288         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3289         (class objfile_compunits): New.
3290         (ALL_COMPUNITS): Use objfile_compunits.
3291         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3292         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3293         objfile_compunits.
3294         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3295
3296 2019-01-09  Tom Tromey  <tom@tromey.com>
3297
3298         * symtab.c (search_symbols)
3299         (default_collect_symbol_completion_matches_break_on): Use
3300         objfile_msymbols.
3301         * ada-lang.c (ada_lookup_simple_minsym)
3302         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3303         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3304         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3305         objfile_msymbols.
3306         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3307         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3308         * objc-lang.c (find_methods): Use objfile_msymbols.
3309         (info_selectors_command, info_classes_command): Likewise.
3310         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3311         * objfiles.h (class objfile_msymbols): New.
3312         (ALL_OBJFILE_MSYMBOLS): Remove.
3313         (ALL_MSYMBOLS): Remove.
3314
3315 2019-01-09  Tom Tromey  <tom@tromey.com>
3316
3317         * common/next-iterator.h (next_adapter): Add Iterator template
3318         parameter.
3319         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3320         (class all_objfiles_safe): New.
3321         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3322         * objfiles.c (put_objfile_before): Update comment.
3323         (add_separate_debug_objfile): Likewise.
3324         (free_all_objfiles): Use all_objfiles_safe.
3325         (objfile_purge_solibs): Likewise.
3326
3327 2019-01-09  Tom Tromey  <tom@tromey.com>
3328
3329         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3330         (expand_symtab_containing_pc, lookup_static_symbol)
3331         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3332         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3333         all_objfiles.
3334         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3335         * breakpoint.c (create_overlay_event_breakpoint)
3336         (create_longjmp_master_breakpoint)
3337         (create_std_terminate_master_breakpoint)
3338         (create_exception_master_breakpoint): Use all_objfiles.
3339         * linux-thread-db.c (try_thread_db_load_from_pdir)
3340         (has_libpthread): Use all_objfiles.
3341         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3342         * linespec.c (iterate_over_all_matching_symtabs)
3343         (search_minsyms_for_name): Use all_objfiles.
3344         * maint.c (maintenance_info_sections): Use all_objfiles.
3345         * main.c (captured_main_1): Use all_objfiles.
3346         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3347         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3348         * guile/scm-pretty-print.c
3349         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3350         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3351         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3352         (maintenance_print_msymbols): Use all_objfiles.
3353         * source.c (select_source_symtab): Use all_objfiles.
3354         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3355         * symfile.c (remove_symbol_file_command)
3356         (expand_symtabs_matching, map_symbol_filenames): Use
3357         all_objfiles.
3358         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3359         all_objfiles.
3360         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3361         * objc-lang.c (find_methods): Use all_objfiles.
3362         * objfiles.c (have_partial_symbols, have_full_symbols)
3363         (have_minimal_symbols, qsort_cmp)
3364         (default_iterate_over_objfiles_in_search_order): Use
3365         all_objfiles.
3366         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3367         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3368         (maintenance_check_psymtabs): Use all_objfiles.
3369         (ALL_PSYMTABS): Remove.
3370         * compile/compile-object-run.c (do_module_cleanup): Use
3371         all_objfiles.
3372         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3373         * cp-support.c (add_symbol_overload_list_qualified): Use
3374         all_objfiles.
3375         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3376         Use all_objfiles.
3377         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3378         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3379         all_objfiles.
3380         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3381         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3382         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3383         Uses all_objfiles.
3384         * solib.c (solib_read_symbols): Use all_objfiles
3385
3386 2019-01-09  Tom Tromey  <tom@tromey.com>
3387
3388         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3389         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3390         all_objfiles.
3391         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3392         * symmisc.c (print_symbol_bcache_statistics)
3393         (print_objfile_statistics, maintenance_print_objfiles)
3394         (maintenance_info_symtabs, maintenance_check_symtabs)
3395         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3396         all_objfiles.
3397         * source.c (forget_cached_source_info): Use all_objfiles.
3398         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3399         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3400         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3401         * objfiles.c (update_section_map): Use all_objfiles.
3402         (shared_objfile_contains_address_p): Likewise.
3403         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3404         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3405
3406 2019-01-09  Tom Tromey  <tom@tromey.com>
3407
3408         * common/next-iterator.h: New file.
3409         * objfiles.h (class all_objfiles): New.
3410         (struct objfile_iterator): New.
3411
3412 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3413
3414         * NEWS: Move the description of the changed "frame", "select-frame",
3415          and "info frame" commands to the Changed commands section.
3416
3417 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3418
3419         * gdbtypes.c (check_stub_method_group): Remove handling of old
3420         mangling schemes.
3421         * linespec.c (find_methods): Likewise.
3422         * stabsread.c (read_member_functions): Likewise.
3423         * valops.c (search_struct_method): Likewise.
3424         (value_struct_elt_for_reference): Likewise.
3425         * NEWS: Mention this change.
3426
3427 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3428
3429         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3430         print_source_lines.
3431         * source.c (print_source_lines_base): Update line number check.
3432         (print_source_lines): New function.
3433         (source_lines_range::source_lines_range): New function.
3434         * source.h (class source_lines_range): New class.
3435         (print_source_lines): New declaration.
3436
3437 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3438
3439         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3440
3441 2019-01-08  Tom Tromey  <tom@tromey.com>
3442             Simon Marchi  <simon.marchi@ericsson.com>
3443
3444         PR gdb/24060
3445         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3446         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3447         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3448         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3449         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3450         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3451
3452 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3453
3454         * source.c (select_source_symtab): Move header comment to
3455         declaration in source.h.
3456         (forget_cached_source_info_for_objfile): Likewise.
3457         (forget_cached_source_info): Likewise.
3458         (identify_source_line): Likewise.
3459         * source.h (identify_source_line): Move declaration from symtab.h
3460         and add comment from source.c
3461         (print_source_lines): Likewise.
3462         (forget_cached_source_info_for_objfile): Likewise.
3463         (forget_cached_source_info): Likewise.
3464         (select_source_symtab): Likewise.
3465         (enum print_source_lines_flag): Move definition from symtab.h.
3466         * symtab.h (identify_source_line): Move declaration to source.h.
3467         (print_source_lines): Likewise.
3468         (forget_cached_source_info_for_objfile): Likewise.
3469         (forget_cached_source_info): Likewise.
3470         (select_source_symtab): Likewise.
3471         (enum print_source_lines_flag): Move definition to source.h.
3472         * tui/tui-hooks.c: Add 'source.h' include.
3473
3474 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3475
3476         * source.c (print_source_lines_base): Handle requests to print
3477         reverse line number sequences, and guard against empty lines
3478         string.
3479
3480 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3481
3482         * source.c (print_source_lines_base): Fix skip of '\r' if next
3483         character is '\n'.
3484
3485 2019-01-06  Tom Tromey  <tom@tromey.com>
3486
3487         * c-exp.y (struct c_parse_state) <macro_original_text,
3488         expansion_obstack>: New member.
3489         (macro_original_text, expansion_obstack): Remove globals.
3490         (scan_macro_expansion, scanning_macro_expansion)
3491         (finished_macro_expansion): Update.
3492         (scan_macro_cleanup): Remove.
3493         (yylex, c_parse): Update.
3494
3495 2019-01-06  Tom Tromey  <tom@tromey.com>
3496
3497         * c-exp.y (struct c_parse_state) <strings>: New member.
3498         (operator_stoken): Update.
3499
3500 2019-01-06  Tom Tromey  <tom@tromey.com>
3501
3502         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3503         (union type_stack_elt) <typelist_val>: Now a pointer to
3504         std::vector.
3505         (type_stack_cleanup): Don't declare.
3506         (push_typelist): Update.
3507         * parse.c (pop_typelist): Return a std::vector.
3508         (push_typelist): Take a std::vector.
3509         (follow_types): Update.  Do not free args.
3510         (type_stack_cleanup): Remove.
3511         * c-exp.y (struct c_parse_state): New.
3512         (cpstate): New global.
3513         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3514         (nonempty_typelist): Update.
3515         (func_mod): Create a new vector.
3516         (c_parse): Create a c_parse_state.
3517         (check_parameter_typelist): Do not delete params.
3518         (function_method): Update.  Do not delete type_list.
3519
3520 2019-01-06  Tom Tromey  <tom@tromey.com>
3521
3522         PR gdb/28155:
3523         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3524         check_typedef.
3525         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3526         (print_return_value): Likewise.
3527
3528 2019-01-05  Tom Tromey  <tom@tromey.com>
3529
3530         * contrib/cleanup_check.py: Remove.
3531         * contrib/gcc-with-excheck: Remove.
3532         * contrib/exsummary.py: Remove.
3533         * contrib/excheck.py: Remove.
3534
3535 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3536
3537         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3538         NULL. Initialize tpprev to NULL instead of assigning it
3539         to NULL on the next statement.
3540         * windows-nat.c (windows_delete_thread): Remove check for
3541         main_thread_id before printing thread exit notifications.
3542         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3543         Remove thread ID check against main_thread_id.
3544         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3545         windows_delete_thread.
3546         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3547
3548 2019-01-04  Tom Tromey  <tom@tromey.com>
3549
3550         * compile/compile.c (_initialize_compile): Use upper case for
3551         metasyntactic variables.
3552         * symmisc.c (_initialize_symmisc): Use upper case for
3553         metasyntactic variables.
3554         * psymtab.c (_initialize_psymtab): Use upper case for
3555         metasyntactic variables.
3556         * demangle.c (demangle_command): Use upper case for metasyntactic
3557         variables.
3558         (_initialize_demangler): Likewise.
3559         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3560         variables.
3561
3562 2019-01-03  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3565
3566 2019-01-03  Tom Tromey  <tom@tromey.com>
3567
3568         * python/py-symtab.c (salpy_str): Update.
3569         (struct salpy_sal_object) <symtab>: Now a PyObject.
3570         (salpy_dealloc): Update.
3571         (del_objfile_sal): Use gdbpy_ref.
3572
3573 2019-01-03  Tom Tromey  <tom@tromey.com>
3574
3575         * python/py-type.c (convert_field): Use new_reference.  Return
3576         gdbpy_ref.
3577         (make_fielditem): Return gdbpy_ref.
3578         (typy_fields): Update.
3579         (typy_getitem): Update.
3580         (field_name): Return gdbpy_ref.  Use new_reference.
3581         (typy_iterator_iternext): Update.
3582
3583 2019-01-03  Tom Tromey  <tom@tromey.com>
3584
3585         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3586
3587 2019-01-03  Tom Tromey  <tom@tromey.com>
3588
3589         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3590         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3591         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3592         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3593         (pspy_set_type_printers): Likewise.
3594         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3595         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3596         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3597         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3598         (objfpy_set_type_printers): Likewise.
3599
3600 2019-01-03  Tom Tromey  <tom@tromey.com>
3601
3602         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3603         (gdbpy_print_stack): Use gdbpy_err_fetch.
3604         * python/python-internal.h (class gdbpy_err_fetch): New class.
3605         (class gdbpy_enter) <m_error_type, m_error_value,
3606         m_error_traceback>: Remove.
3607         <m_error>: New member.
3608         (gdbpy_exception_to_string): Don't declare.
3609         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3610         * python/py-value.c (convert_value_from_python): Use
3611         gdbpy_err_fetch.
3612         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3613         gdbpy_exception_to_string.
3614         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3615         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3616         gdbpy_err_fetch.
3617
3618 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3619
3620         * linux-nat.c (delete_lwp_cleanup): Delete.
3621         (struct lwp_deleter): New struct.
3622         (lwp_info_up): New typedef.
3623         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3624         lwp_info_up.
3625
3626 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3627
3628         * linux-fork.c (class scoped_switch_fork_info): New class.
3629         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3630
3631 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3632
3633         * valops.c (find_overload_match): Remove use of null_cleanup, and
3634         calls to do_cleanups.
3635
3636 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3637
3638         * compile/compile-cplus-types.c
3639         (compile_cplus_instance::decl_name): Handle changes to
3640         cp_func_name.
3641         * cp-support.c (cp_func_name): Update header comment, update
3642         return type.
3643         * cp-support.h (cp_func_name): Update return type in declaration.
3644         * valops.c (find_overload_match): Move temp_func local to top
3645         level of function and change its type.  Use temp_func to hold and
3646         delete temporary string obtained from cp_func_name.
3647
3648 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3649
3650         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3651         gdb::char_vector, remove cleanup, and update uses of `msg`.
3652
3653 2019-01-03  Jim Wilson  <jimw@sifive.com>
3654
3655         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3656
3657 2019-01-02  Tom Tromey  <tom@tromey.com>
3658
3659         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3660         (tdesc_parse_xml): Remove cleanups.
3661         * target-descriptions.h (make_cleanup_free_target_description):
3662         Don't declare.
3663         (target_desc_deleter): New struct.
3664         (target_desc_up): New typedef.
3665         * target-descriptions.c (target_desc_deleter::operator()): Rename
3666         from free_target_description.
3667         (make_cleanup_free_target_description): Remove.
3668
3669 2019-01-02  Tom Tromey  <tom@tromey.com>
3670
3671         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3672         constructor, destructor.
3673         (linespec_parser): Remove typedef.
3674         (~linespec_parser): Rename from linespec_parser_delete.
3675         (linespec_lex_to_end, linespec_complete_label)
3676         (linespec_complete): Update.
3677         (decode_line_full): Remove cleanups.
3678         (decode_line_1): Update.
3679
3680 2019-01-02  Tom Tromey  <tom@tromey.com>
3681
3682         * python/python-internal.h (inferior_to_inferior_object): Change
3683         return type.
3684         * python/py-exitedevent.c (create_exited_event_object): Update.
3685         * python/py-inferior.c (inferior_to_inferior_object): Return
3686         gdbpy_ref.
3687         (python_new_inferior, python_inferior_deleted)
3688         (thread_to_thread_object, delete_thread_object)
3689         (build_inferior_list, gdbpy_selected_inferior): Update.
3690         * python/py-infthread.c (create_thread_object): Update.  Also fail
3691         if inferior_to_inferior_object fails.
3692
3693 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3694
3695         * inferior.h (class inferior) <displaced_step_state>: New field.
3696         * infrun.h (struct displaced_step_state): Move here from
3697         infrun.c.  Initialize fields, add constructor.
3698         <inf>: Remove field.
3699         <reset>: New method.
3700         * infrun.c (struct displaced_step_inferior_state): Move to
3701         infrun.h.
3702         (displaced_step_inferior_states): Remove.
3703         (get_displaced_stepping_state): Adust.
3704         (displaced_step_in_progress_any_inferior): Adjust.
3705         (displaced_step_in_progress_thread): Adjust.
3706         (displaced_step_in_progress): Adjust.
3707         (add_displaced_stepping_state): Remove.
3708         (get_displaced_step_closure_by_addr): Adjust.
3709         (remove_displaced_stepping_state): Remove.
3710         (infrun_inferior_exit): Call displaced_step_state.reset.
3711         (use_displaced_stepping): Don't check for NULL.
3712         (displaced_step_prepare_throw): Call
3713         get_displaced_stepping_state.
3714         (displaced_step_fixup): Don't check for NULL.
3715         (prepare_for_detach): Don't check for NULL.
3716
3717 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3718
3719         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3720          in case of call that did not complete.
3721
3722 2019-01-02  Andrey Utkin  <autkin@undo.io>
3723
3724         * symfile.c (find_separate_debug_file): Fix search of debug files for
3725         remote debuggee.
3726
3727 2019-01-02  Tom Tromey  <tom@tromey.com>
3728
3729         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3730         indentation.
3731         * python/py-frame.c (frapy_older): Remove cast.
3732         (frapy_newer): Likewise.
3733         * python/py-breakpoint.c (local_setattro): Remove cast.
3734         * python/py-arch.c (archpy_name): Remove local variable.
3735         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3736
3737 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3738
3739         * unittests/basic_string_view/element_access/char/empty.cc:
3740         Fix year range in copyright header.
3741
3742 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3745         Delete.
3746         <operator==>: Update with for removed field.
3747         <hash>: Likewise.
3748         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3749         <isa_features>: ...this.
3750         <abi_features>: New field.
3751         (riscv_isa_flen): Update comment.
3752         (riscv_abi_xlen): New declaration.
3753         (riscv_abi_flen): New declaration.
3754         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3755         isa_features.
3756         (riscv_abi_xlen): New function.
3757         (riscv_isa_flen): Update to get answer from isa_features.
3758         (riscv_abi_flen): New function.
3759         (riscv_has_fp_abi): Update to get answer from abi_features.
3760         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3761         xlen and flen.
3762         (riscv_call_info) <xlen, flen>: Update comment.
3763         (riscv_call_arg_struct): Remove invalid assertions
3764         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3765         is removed.
3766         (riscv_gdbarch_init): Gather isa features and abi features
3767         separately, ensure both match on the gdbarch when reusing an old
3768         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3769         a target with 64-bit float hardware.
3770
3771 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3772
3773         * source.c (search_command_helper): Stop reverse search
3774         when line 1 has been searched.
3775
3776 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3777
3778         * record-full.c (record_full_base_target::close): Rewrite
3779         record_full_core_buf_list free logic.
3780
3781 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3782
3783         * break-catch-syscall.c (print_one_catch_syscall): xfree
3784         the last text.
3785
3786 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3787
3788         * top.c (print_gdb_version): Update Copyright year in version
3789         message.
3790
3791 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3792
3793         Update copyright year range in all GDB files.
3794
3795 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3796
3797         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3798
3799 For older changes see ChangeLog-2018.
3800 \f
3801 Local Variables:
3802 mode: change-log
3803 left-margin: 8
3804 fill-column: 74
3805 version-control: never
3806 coding: utf-8
3807 End:
3808