Support styling on native MS-Windows console
[external/binutils.git] / gdb / ChangeLog
1 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2
3         Support styling on native MS-Windows console
4
5         PR/24315
6         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7         on MS-Windows if $TERM is not defined.
8
9         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10
11         * posix-hdep.c (gdb_console_fputs):
12         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13         functions.
14         * ui-file.h (gdb_console_fputs): Add prototype.
15
16         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
17         back to fputs only if the former returns zero.
18
19 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
20             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
21
22         PR gdb/8527
23         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
24         set_sigint_trap, clear_sigint_trap.
25
26 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
27
28         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
29         for-loop range, to avoid compiler warnings.
30
31         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
32         avoid compiler warnings about unused variables.
33
34 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
35
36         * NEWS: Mention end of support for native debugging on MS-Windows
37         before XP.
38
39 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
40
41         PR gdb/24292
42         * common/netstuff.c:
43         * gdbserver/gdbreplay.c
44         * gdbserver/remote-utils.c:
45         * ser-tcp.c:
46         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
47         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
48         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
49         'getaddrinfo' and 'freeaddrinfo' were not available before
50         Windows XP, and mingw.org's MinGW headers by default define
51         _WIN32_WINNT to 0x500.
52
53 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
54     
55         * NEWS: Note minimum Python version.
56
57 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
58
59         * version.in: Set GDB version number to 8.2.90.DATE-git.
60
61 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
62
63         GDB 8.2.90 released.
64
65 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
66
67         * version.in: Set GDB version number to 8.2.90.
68
69 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
70
71         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
72
73 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
74
75         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
76         * version.in: Bump version to 8.2.90.DATE-git.
77
78 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
79
80         * aix-thread.c (ptid_cmp): Remove unused variable.
81         (get_signaled_thread): Likewise.
82         (store_regs_user_thread): Likewise.
83         (store_regs_kernel_thread): Likewise.
84         (fetch_regs_kernel_thread): Remove shadowed variable.
85
86 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
87
88         * features/riscv/32bit-cpu.xml: Add register numbers.
89         * features/riscv/32bit-fpu.c: Regenerate.
90         * features/riscv/32bit-fpu.xml: Add register numbers.
91         * features/riscv/64bit-cpu.xml: Add register numbers.
92         * features/riscv/64bit-fpu.c: Regenerate.
93         * features/riscv/64bit-fpu.xml: Add register numbers.
94
95 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
96
97         * NEWS: Mention two argument form of gdb.Value constructor.
98         * python/py-value.c (convert_buffer_and_type_to_value): New
99         function.
100         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
101         Add support for handling an optional second argument.  Call
102         convert_buffer_and_type_to_value as appropriate.
103         * python/python-internal.h (Py_buffer_deleter): New struct.
104         (Py_buffer_up): New typedef.
105
106 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
107
108         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
109         instead of releasing ownership.
110
111 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
112
113         * dwarf2read.c (open_and_init_dwp_file): Call
114         elf_numsections instead of bfd_count_sections to initialize
115         dwp_file->num_sections.
116
117 2019-02-25  Tom Tromey  <tromey@adacore.com>
118
119         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
120
121 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
122
123         * gcore.in: Add '--readnever' option when invoking GDB.
124
125 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
126
127         * MAINTAINERS: Update my email address.
128
129 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
130
131         * build-id.c (build_id_to_debug_bfd_1): New function.
132         (build_id_to_debug_bfd): Look for separate debug file in
133         sysroot.
134
135 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
136
137         * gdbarch.sh: Update the copyright year range that is placed into
138         generated files.
139
140 2019-02-22  Keith Seitz  <keiths@redhat.com>
141
142         PR symtab/23853
143         * linespec.c (create_sals_line_offset): Search for the default
144         symtab's filename instead of its fullname.
145
146 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
147
148         * NEWS: Update style defaults.
149
150 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
151
152         * main.c (captured_main_1): Disable styling in batch mode.
153
154 2019-02-20  Tom Tromey  <tom@tromey.com>
155
156         * symtab.c (symtab_symbol_info): Fix typos.
157
158 2019-02-20  Tom Tromey  <tromey@adacore.com>
159
160         * findcmd.c (_initialize_mem_search): Use upper case for
161         metasyntactic variables.
162
163 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
164
165         * aarch64-tdep.c (aarch64_add_reggroups): New function.
166         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
167
168 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
169
170         * top.h (source_file_name): Change to std::string.
171         * top.c (source_file_name): Likewise.
172         (command_line_input): Adjust.
173         * cli/cli-script.c (script_from_file): Adjust.
174
175 2019-02-19  Tom Tromey  <tromey@adacore.com>
176
177         * ravenscar-thread.c
178         (ravenscar_thread_target::update_thread_list): Don't call
179         ada_build_task_list.
180         * ada-lang.h (ada_build_task_list): Don't declare.
181         * ada-tasks.c (struct ada_tasks_inferior_data)
182         <task_list_valid_p>: Now bool.
183         (read_known_tasks, ada_task_list_changed)
184         (ada_tasks_invalidate_inferior_data): Update.
185         (read_known_tasks_array): Return bool.
186         (read_known_tasks_list): Likewise.
187         (read_known_tasks): Return void.
188         (ada_build_task_list): Now static.
189
190 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
191
192         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
193         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
194
195 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
196
197         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
198         variant for ada_tasks_pspace_data_handle and
199         ada_tasks_inferior_data_handle.
200         (ada_tasks_pspace_data_cleanup): New function.
201         (ada_tasks_inferior_data_cleanup): New function.
202
203 2019-02-17  Tom Tromey  <tom@tromey.com>
204
205         * macrotab.h (macro_source_fullname): Return a std::string.
206         * macrotab.c (macro_include, check_for_redefinition)
207         (macro_undef, macro_lookup_definition, foreach_macro)
208         (foreach_macro_in_scope): Update.
209         (macro_source_fullname): Return a std::string.
210         * macrocmd.c (show_pp_source_pos): Update.
211
212 2019-02-17  Tom Tromey  <tom@tromey.com>
213
214         * macrocmd.c (show_pp_source_pos): Style the file names.
215
216 2019-02-17  Tom Tromey  <tom@tromey.com>
217
218         PR tui/24197:
219         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
220
221 2019-02-17  Tom Tromey  <tom@tromey.com>
222
223         * ada-lang.c (user_select_syms): Use filtered printing.
224         * utils.c (wrap_style): New global.
225         (desired_style): Remove.
226         (emit_style_escape): Add stream parameter.
227         (set_output_style, reset_terminal_style, prompt_for_continue):
228         Update.
229         (flush_wrap_buffer): Only flush gdb_stdout.
230         (wrap_here): Set wrap_style.
231         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
232         treat escape sequences as a character.  Change when wrap buffer is
233         flushed.
234         (fputs_styled): Do not set the output style when the default is
235         requested.
236         * ui-style.h (struct ui_file_style) <is_default>: New method.
237         * source.c (print_source_lines_base): Emit escape sequences in one
238         piece.
239
240 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
241
242         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
243         integers and enumeration types.
244
245 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
246
247         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
248         instead of lookup_symbol_in_language
249         (do_exact_match): New function.
250         (ada_get_symbol_name_matcher): Return do_exact_match when
251         doing a verbatim match.
252
253 2019-02-15  Tom Tromey  <tromey@adacore.com>
254
255         * ravenscar-thread.c (ravenscar_thread_target::resume)
256         (ravenscar_thread_target::wait): Special case wildcard requests.
257
258 2019-02-15  Tom Tromey  <tromey@adacore.com>
259
260         * ravenscar-thread.c (base_ptid): Remove.
261         (struct ravenscar_thread_target) <close>: New method.
262         <m_base_ptid>: New member.
263         <update_inferior_ptid, active_task, task_is_currently_active,
264         runtime_initialized>: Declare methods.
265         <ravenscar_thread_target>: Add constructor.
266         (ravenscar_thread_target::task_is_currently_active)
267         (ravenscar_thread_target::update_inferior_ptid)
268         (ravenscar_runtime_initialized): Rename.  Now methods.
269         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
270         (ravenscar_thread_target::update_thread_list): Update.
271         (ravenscar_thread_target::active_task): Now method.
272         (ravenscar_thread_target::store_registers)
273         (ravenscar_thread_target::prepare_to_store)
274         (ravenscar_thread_target::prepare_to_store)
275         (ravenscar_thread_target::mourn_inferior): Update.
276         (ravenscar_inferior_created): Use "new" to create target.
277         (ravenscar_thread_target::get_ada_task_ptid): Update.
278         (_initialize_ravenscar): Don't initialize base_ptid.
279         (ravenscar_ops): Remove global.
280
281 2019-02-15  Tom Tromey  <tromey@adacore.com>
282
283         * target.h (push_target): Declare new overload.
284         * target.c (push_target): New overload, taking an rvalue reference.
285         * remote.c (remote_target::open_1): Use push_target overload.
286         * corelow.c (core_target_open): Use push_target overload.
287
288 2019-02-15  Tom Tromey  <tromey@adacore.com>
289
290         * ravenscar-thread.c (is_ravenscar_task)
291         (ravenscar_task_is_currently_active): Return bool.
292         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
293         (_initialize_ravenscar): Remove "(void)".
294         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
295         Return bool.
296
297 2019-02-15  Tom Tromey  <tromey@adacore.com>
298
299         * ravenscar-thread.c (ravenscar_runtime_initializer)
300         (has_ravenscar_runtime, get_running_thread_id)
301         (ravenscar_thread_target::resume): Fix indentation.
302
303 2019-02-15  Tom Tromey  <tromey@adacore.com>
304
305         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
306         from ravenscar_arch_ops.
307         (sparc_ravenscar_ops::fetch_registers)
308         (sparc_ravenscar_ops::store_registers): Now methods.
309         (sparc_ravenscar_prepare_to_store): Remove.
310         (sparc_ravenscar_ops): Redefine.
311         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
312         methods and destructor.  Remove members.
313         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
314         (ravenscar_thread_target::store_registers)
315         (ravenscar_thread_target::prepare_to_store): Update.
316         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
317         Remove.
318         (struct ppc_ravenscar_powerpc_ops): Derive from
319         ravenscar_arch_ops.
320         (ppc_ravenscar_powerpc_ops::fetch_registers)
321         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
322         (ppc_ravenscar_powerpc_ops): Redefine.
323         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
324         (ppc_ravenscar_e500_ops::fetch_registers)
325         (ppc_ravenscar_e500_ops::store_registers): Now methods.
326         (ppc_ravenscar_e500_ops): Redefine.
327         * aarch64-ravenscar-thread.c
328         (aarch64_ravenscar_generic_prepare_to_store): Remove.
329         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
330         (aarch64_ravenscar_fetch_registers)
331         (aarch64_ravenscar_store_registers): Now methods.
332         (aarch64_ravenscar_ops): Redefine.
333
334 2019-02-15  Tom Tromey  <tromey@adacore.com>
335
336         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
337         (ravenscar_thread_target::stopped_by_hw_breakpoint)
338         (ravenscar_thread_target::stopped_by_watchpoint)
339         (ravenscar_thread_target::stopped_data_address)
340         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
341
342 2019-02-15  Tom Tromey  <tromey@adacore.com>
343
344         * ravenscar-thread.c: Fix some typos.
345
346 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
347             Tom Tromey  <tromey@adacore.com>
348
349         * ada-lang.c (ada_exception_sal): Change addr_string to a
350         std::string.
351         (create_ada_exception_catchpoint): Update.
352
353 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
354             Tom Tromey  <tromey@adacore.com>
355
356         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
357         (bp_location_ops): Remove.
358         (base_breakpoint_allocate_location): Update.
359         (free_bp_location): Update.
360         * ada-lang.c (class ada_catchpoint_location)
361         <ada_catchpoint_location>: Remove ops parameter.
362         (ada_catchpoint_location_dtor): Remove.
363         (ada_catchpoint_location_ops): Remove.
364         (allocate_location_exception): Update.
365         * breakpoint.h (struct bp_location_ops): Remove.
366         (class bp_location) <bp_location>: Remove bp_location_ops
367         parameter.
368         <~bp_location>: Add destructor.
369         <ops>: Remove.
370
371 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
372             Pedro Alves  <palves@redhat.com>
373
374         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
375         'PATH_MAX'.
376
377 2019-02-14  David Michael  <fedora.dm0@gmail.com>
378             Samuel Thibault  <samuel.thibault@gnu.org>
379             Thomas Schwinge  <thomas@codesourcery.com>
380
381         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
382         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
383
384 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
385
386         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
387         (check_empty): Use "const char *".
388
389         * gnu-nat.c (gnu_nat_target::detach): Instead of
390         'detach_inferior (pid)' call
391         'detach_inferior (find_inferior_pid (pid))'.
392
393         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
394         'nat/fork-inferior.o'.
395         * gnu-nat.c: #include "nat/fork-inferior.h".
396
397         * gnu-nat.c (gnu_nat_target::detach): Instead of
398         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
399         * gnu-nat.h: #include "inf-child.h".
400         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
401         'i386_gnu_nat_target::fetch_registers'.
402         (gnu_store_registers): Rename/move to
403         'i386_gnu_nat_target::store_registers'.
404
405         * config/i386/nm-i386gnu.h: Don't "#include" any files.
406         * gnu-nat.h (mach_thread_info): New function.
407         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
408
409         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
410
411 2019-02-14  Frederic Konrad  <konrad@adacore.com>
412
413         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
414
415 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
416
417         * windows-nat.c (windows_add_thread): Add new parameter
418         "main_thread_p" with default value set to false.  Update
419         function documentation as well as all callers.
420         (windows_delete_thread): Likewise.
421         (fake_create_process): Update call to windows_add_thread.
422         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
423         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
424         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
425         call to windows_delete_thread.
426
427 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
428
429         * MAINTAINERS: Add Andrew Burgess as global maintainer.
430
431 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
432
433         * symfile.c (find_separate_debug_file): Use canonical path of
434         sysroot with child_path instead of gdb_sysroot if it is valid.
435
436 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
437
438         * symfile.c (find_separate_debug_file): Use child_path to
439         determine if an object file is under a sysroot.
440
441 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
442
443         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
444         unittests/child-path-selftests.c.
445         * common/pathstuff.c (child_path): New function.
446         * common/pathstuff.h (child_path): New prototype.
447         * unittests/child-path-selftests.c: New file.
448
449 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
450
451         * symfile.c (find_separate_debug_file): Look for separate debug
452         files in debug directories under the sysroot.
453
454 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
455
456         * symtab.h (struct minimal_symbol data_p): New const method.
457         (struct minimal_symbol text_p): Likewise.
458         * symtab.c (output_source_filename): Use file name style
459         to print file name.
460         (print_symbol_info): Likewise.
461         (print_msymbol_info): Use address style to print addresses.
462         Use function name style to print executable text symbols.
463         (expand_symtab_containing_pc): Use data_p.
464         (find_pc_sect_compunit_symtab): Likewise.
465
466 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
467
468         * breakpoint.c (describe_other_breakpoints): Use address style
469         to print addresses.
470         (say_where): Likewise.
471
472 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
473
474         * ada-typeprint.c (print_func_type): Print function name
475         style to print function name.
476         * c-typeprint.c (c_print_type_1): Likewise.
477
478 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
479
480         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
481         for execve.
482
483 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
484
485         * c-exp.y (direct_abs_decl): Use emplace_back to record the
486         type_stack.
487
488 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
489
490         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
491         TYPE_CODE_REF types.
492
493 2019-02-08  Jim Wilson  <jimw@sifive.com>
494
495         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
496         (riscv_linux_fregset): New.
497         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
498
499 2019-02-07  Tom Tromey  <tom@tromey.com>
500
501         * thread.c (thread_cancel_execution_command): Update.
502         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
503         methods.
504         (struct thread_fsm_ops): Remove.
505         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
506         (thread_fsm_should_stop, thread_fsm_return_value)
507         (thread_fsm_set_finished, thread_fsm_finished_p)
508         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
509         Don't declare.
510         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
511         * infrun.c (clear_proceed_status_thread)
512         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
513         (print_stop_event): Update.
514         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
515         Add constructor.
516         (step_command_fsm_ops): Remove.
517         (new_step_command_fsm): Remove.
518         (step_1): Update.
519         (step_command_fsm::should_stop): Rename from
520         step_command_fsm_should_stop.
521         (step_command_fsm::clean_up): Rename from
522         step_command_fsm_clean_up.
523         (step_command_fsm::do_async_reply_reason): Rename from
524         step_command_fsm_async_reply_reason.
525         (struct until_next_fsm): Inherit from thread_fsm.  Add
526         constructor.
527         (until_next_fsm_ops): Remove.
528         (new_until_next_fsm): Remove.
529         (until_next_fsm::should_stop): Rename from
530         until_next_fsm_should_stop.
531         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
532         (until_next_fsm::do_async_reply_reason): Rename from
533         until_next_fsm_async_reply_reason.
534         (struct finish_command_fsm): Inherit from thread_fsm.  Add
535         constructor.  Change type of breakpoint.
536         (finish_command_fsm_ops): Remove.
537         (new_finish_command_fsm): Remove.
538         (finish_command_fsm::should_stop): Rename from
539         finish_command_fsm_should_stop.
540         (finish_command_fsm::clean_up): Rename from
541         finish_command_fsm_clean_up.
542         (finish_command_fsm::return_value): Rename from
543         finish_command_fsm_return_value.
544         (finish_command_fsm::do_async_reply_reason): Rename from
545         finish_command_fsm_async_reply_reason.
546         (finish_command): Update.
547         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
548         Add constructor.
549         (call_thread_fsm_ops): Remove.
550         (call_thread_fsm::call_thread_fsm): Rename from
551         new_call_thread_fsm.
552         (call_thread_fsm::should_stop): Rename from
553         call_thread_fsm_should_stop.
554         (call_thread_fsm::should_notify_stop): Rename from
555         call_thread_fsm_should_notify_stop.
556         (run_inferior_call, call_function_by_hand_dummy): Update.
557         * cli/cli-interp.c (should_print_stop_to_console): Update.
558         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
559         Add constructor.  Change type of location_breakpoint,
560         caller_breakpoint.
561         (until_break_fsm_ops): Remove.
562         (new_until_break_fsm): Remove.
563         (until_break_fsm::should_stop): Rename from
564         until_break_fsm_should_stop.
565         (until_break_fsm::clean_up): Rename from
566         until_break_fsm_clean_up.
567         (until_break_fsm::do_async_reply_reason): Rename from
568         until_break_fsm_async_reply_reason.
569         (until_break_command): Update.
570         * thread-fsm.c: Remove.
571         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
572
573 2019-02-07  Tom Tromey  <tom@tromey.com>
574
575         * yy-remap.h: Add include guard.
576         * xtensa-tdep.h: Add include guard.
577         * xcoffread.h: Rename include guard.
578         * varobj-iter.h: Add include guard.
579         * tui/tui.h: Rename include guard.
580         * tui/tui-winsource.h: Rename include guard.
581         * tui/tui-wingeneral.h: Rename include guard.
582         * tui/tui-windata.h: Rename include guard.
583         * tui/tui-win.h: Rename include guard.
584         * tui/tui-stack.h: Rename include guard.
585         * tui/tui-source.h: Rename include guard.
586         * tui/tui-regs.h: Rename include guard.
587         * tui/tui-out.h: Rename include guard.
588         * tui/tui-layout.h: Rename include guard.
589         * tui/tui-io.h: Rename include guard.
590         * tui/tui-hooks.h: Rename include guard.
591         * tui/tui-file.h: Rename include guard.
592         * tui/tui-disasm.h: Rename include guard.
593         * tui/tui-data.h: Rename include guard.
594         * tui/tui-command.h: Rename include guard.
595         * tic6x-tdep.h: Add include guard.
596         * target/waitstatus.h: Rename include guard.
597         * target/wait.h: Rename include guard.
598         * target/target.h: Rename include guard.
599         * target/resume.h: Rename include guard.
600         * target-float.h: Rename include guard.
601         * stabsread.h: Add include guard.
602         * rs6000-tdep.h: Add include guard.
603         * riscv-fbsd-tdep.h: Add include guard.
604         * regformats/regdef.h: Rename include guard.
605         * record.h: Rename include guard.
606         * python/python.h: Rename include guard.
607         * python/python-internal.h: Rename include guard.
608         * python/py-stopevent.h: Rename include guard.
609         * python/py-ref.h: Rename include guard.
610         * python/py-record.h: Rename include guard.
611         * python/py-record-full.h: Rename include guard.
612         * python/py-record-btrace.h: Rename include guard.
613         * python/py-instruction.h: Rename include guard.
614         * python/py-events.h: Rename include guard.
615         * python/py-event.h: Rename include guard.
616         * procfs.h: Add include guard.
617         * proc-utils.h: Add include guard.
618         * p-lang.h: Add include guard.
619         * or1k-tdep.h: Rename include guard.
620         * observable.h: Rename include guard.
621         * nto-tdep.h: Rename include guard.
622         * nat/x86-linux.h: Rename include guard.
623         * nat/x86-linux-dregs.h: Rename include guard.
624         * nat/x86-gcc-cpuid.h: Add include guard.
625         * nat/x86-dregs.h: Rename include guard.
626         * nat/x86-cpuid.h: Rename include guard.
627         * nat/ppc-linux.h: Rename include guard.
628         * nat/mips-linux-watch.h: Rename include guard.
629         * nat/linux-waitpid.h: Rename include guard.
630         * nat/linux-ptrace.h: Rename include guard.
631         * nat/linux-procfs.h: Rename include guard.
632         * nat/linux-osdata.h: Rename include guard.
633         * nat/linux-nat.h: Rename include guard.
634         * nat/linux-namespaces.h: Rename include guard.
635         * nat/linux-btrace.h: Rename include guard.
636         * nat/glibc_thread_db.h: Rename include guard.
637         * nat/gdb_thread_db.h: Rename include guard.
638         * nat/gdb_ptrace.h: Rename include guard.
639         * nat/fork-inferior.h: Rename include guard.
640         * nat/amd64-linux-siginfo.h: Rename include guard.
641         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
642         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
643         * nat/aarch64-linux.h: Rename include guard.
644         * nat/aarch64-linux-hw-point.h: Rename include guard.
645         * mn10300-tdep.h: Add include guard.
646         * mips-linux-tdep.h: Add include guard.
647         * mi/mi-parse.h: Rename include guard.
648         * mi/mi-out.h: Rename include guard.
649         * mi/mi-main.h: Rename include guard.
650         * mi/mi-interp.h: Rename include guard.
651         * mi/mi-getopt.h: Rename include guard.
652         * mi/mi-console.h: Rename include guard.
653         * mi/mi-common.h: Rename include guard.
654         * mi/mi-cmds.h: Rename include guard.
655         * mi/mi-cmd-break.h: Rename include guard.
656         * m2-lang.h: Add include guard.
657         * location.h: Rename include guard.
658         * linux-record.h: Rename include guard.
659         * linux-nat.h: Add include guard.
660         * linux-fork.h: Add include guard.
661         * i386-darwin-tdep.h: Rename include guard.
662         * hppa-linux-offsets.h: Add include guard.
663         * guile/guile.h: Rename include guard.
664         * guile/guile-internal.h: Rename include guard.
665         * gnu-nat.h: Rename include guard.
666         * gdb-stabs.h: Rename include guard.
667         * frv-tdep.h: Add include guard.
668         * f-lang.h: Add include guard.
669         * event-loop.h: Add include guard.
670         * darwin-nat.h: Rename include guard.
671         * cp-abi.h: Rename include guard.
672         * config/sparc/nm-sol2.h: Rename include guard.
673         * config/nm-nto.h: Rename include guard.
674         * config/nm-linux.h: Add include guard.
675         * config/i386/nm-i386gnu.h: Rename include guard.
676         * config/djgpp/nl_types.h: Rename include guard.
677         * config/djgpp/langinfo.h: Rename include guard.
678         * compile/gcc-cp-plugin.h: Add include guard.
679         * compile/gcc-c-plugin.h: Add include guard.
680         * compile/compile.h: Rename include guard.
681         * compile/compile-object-run.h: Rename include guard.
682         * compile/compile-object-load.h: Rename include guard.
683         * compile/compile-internal.h: Rename include guard.
684         * compile/compile-cplus.h: Rename include guard.
685         * compile/compile-c.h: Rename include guard.
686         * common/xml-utils.h: Rename include guard.
687         * common/x86-xstate.h: Rename include guard.
688         * common/version.h: Rename include guard.
689         * common/vec.h: Rename include guard.
690         * common/tdesc.h: Rename include guard.
691         * common/selftest.h: Rename include guard.
692         * common/scoped_restore.h: Rename include guard.
693         * common/scoped_mmap.h: Rename include guard.
694         * common/scoped_fd.h: Rename include guard.
695         * common/safe-iterator.h: Rename include guard.
696         * common/run-time-clock.h: Rename include guard.
697         * common/refcounted-object.h: Rename include guard.
698         * common/queue.h: Rename include guard.
699         * common/ptid.h: Rename include guard.
700         * common/print-utils.h: Rename include guard.
701         * common/preprocessor.h: Rename include guard.
702         * common/pathstuff.h: Rename include guard.
703         * common/observable.h: Rename include guard.
704         * common/netstuff.h: Rename include guard.
705         * common/job-control.h: Rename include guard.
706         * common/host-defs.h: Rename include guard.
707         * common/gdb_wait.h: Rename include guard.
708         * common/gdb_vecs.h: Rename include guard.
709         * common/gdb_unlinker.h: Rename include guard.
710         * common/gdb_unique_ptr.h: Rename include guard.
711         * common/gdb_tilde_expand.h: Rename include guard.
712         * common/gdb_sys_time.h: Rename include guard.
713         * common/gdb_string_view.h: Rename include guard.
714         * common/gdb_splay_tree.h: Rename include guard.
715         * common/gdb_setjmp.h: Rename include guard.
716         * common/gdb_ref_ptr.h: Rename include guard.
717         * common/gdb_optional.h: Rename include guard.
718         * common/gdb_locale.h: Rename include guard.
719         * common/gdb_assert.h: Rename include guard.
720         * common/filtered-iterator.h: Rename include guard.
721         * common/filestuff.h: Rename include guard.
722         * common/fileio.h: Rename include guard.
723         * common/environ.h: Rename include guard.
724         * common/common-utils.h: Rename include guard.
725         * common/common-types.h: Rename include guard.
726         * common/common-regcache.h: Rename include guard.
727         * common/common-inferior.h: Rename include guard.
728         * common/common-gdbthread.h: Rename include guard.
729         * common/common-exceptions.h: Rename include guard.
730         * common/common-defs.h: Rename include guard.
731         * common/common-debug.h: Rename include guard.
732         * common/cleanups.h: Rename include guard.
733         * common/buffer.h: Rename include guard.
734         * common/btrace-common.h: Rename include guard.
735         * common/break-common.h: Rename include guard.
736         * cli/cli-utils.h: Rename include guard.
737         * cli/cli-style.h: Rename include guard.
738         * cli/cli-setshow.h: Rename include guard.
739         * cli/cli-script.h: Rename include guard.
740         * cli/cli-interp.h: Rename include guard.
741         * cli/cli-decode.h: Rename include guard.
742         * cli/cli-cmds.h: Rename include guard.
743         * charset-list.h: Add include guard.
744         * buildsym-legacy.h: Rename include guard.
745         * bfin-tdep.h: Add include guard.
746         * ax.h: Rename include guard.
747         * arm-linux-tdep.h: Add include guard.
748         * arm-fbsd-tdep.h: Add include guard.
749         * arch/xtensa.h: Rename include guard.
750         * arch/tic6x.h: Add include guard.
751         * arch/i386.h: Add include guard.
752         * arch/arm.h: Rename include guard.
753         * arch/arm-linux.h: Rename include guard.
754         * arch/arm-get-next-pcs.h: Rename include guard.
755         * arch/amd64.h: Add include guard.
756         * arch/aarch64-insn.h: Rename include guard.
757         * arch-utils.h: Rename include guard.
758         * annotate.h: Add include guard.
759         * amd64-darwin-tdep.h: Rename include guard.
760         * aarch64-linux-tdep.h: Add include guard.
761         * aarch64-fbsd-tdep.h: Add include guard.
762         * aarch32-linux-nat.h: Add include guard.
763
764 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
765
766         * macrotab.c (macro_define_internal): New function that
767         factorizes macro_define_object_internal and macro_define_function
768         code.
769         (macro_define_object_internal): Use macro_define_internal.
770         (macro_define_function): Likewise.
771
772 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
773
774         * macrocmd.c (extract_identifier): Return
775         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
776         callers.
777
778 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
779
780         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
781
782 2019-02-05  Tom Tromey  <tom@tromey.com>
783
784         * target.c (target_stack::unpush): Move assertion earlier.
785
786 2019-01-30  Tom Tromey  <tom@tromey.com>
787
788         PR python/23615:
789         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
790         (gdbpy_parse_and_eval): Likewise.
791         * python/python-internal.h (gdbpy_allow_threads): New class.
792
793 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
794
795         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
796         (aarch64_fbsd_fpregmap): Move earlier.
797         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
798         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
799         instead of individual calls to trad_frame_set_reg_addr.
800         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
801         earlier.
802         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
803         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
804         instead of individual calls to trad_frame_set_reg_addr.
805
806 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
807
808         * CONTRIBUTE: Replace contribution list with wiki link.
809
810 2019-01-25  Tom Tromey  <tom@tromey.com>
811
812         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
813
814 2019-01-25  Tom Tromey  <tom@tromey.com>
815
816         * xtensa-linux-nat.c: Fix common/ includes.
817         * xml-support.h: Fix common/ includes.
818         * xml-support.c: Fix common/ includes.
819         * x86-linux-nat.c: Fix common/ includes.
820         * windows-nat.c: Fix common/ includes.
821         * varobj.h: Fix common/ includes.
822         * varobj.c: Fix common/ includes.
823         * value.c: Fix common/ includes.
824         * valops.c: Fix common/ includes.
825         * utils.c: Fix common/ includes.
826         * unittests/xml-utils-selftests.c: Fix common/ includes.
827         * unittests/utils-selftests.c: Fix common/ includes.
828         * unittests/unpack-selftests.c: Fix common/ includes.
829         * unittests/tracepoint-selftests.c: Fix common/ includes.
830         * unittests/style-selftests.c: Fix common/ includes.
831         * unittests/string_view-selftests.c: Fix common/ includes.
832         * unittests/scoped_restore-selftests.c: Fix common/ includes.
833         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
834         * unittests/scoped_fd-selftests.c: Fix common/ includes.
835         * unittests/rsp-low-selftests.c: Fix common/ includes.
836         * unittests/parse-connection-spec-selftests.c: Fix common/
837         includes.
838         * unittests/optional-selftests.c: Fix common/ includes.
839         * unittests/offset-type-selftests.c: Fix common/ includes.
840         * unittests/observable-selftests.c: Fix common/ includes.
841         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
842         * unittests/memrange-selftests.c: Fix common/ includes.
843         * unittests/memory-map-selftests.c: Fix common/ includes.
844         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
845         * unittests/function-view-selftests.c: Fix common/ includes.
846         * unittests/environ-selftests.c: Fix common/ includes.
847         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
848         * unittests/common-utils-selftests.c: Fix common/ includes.
849         * unittests/cli-utils-selftests.c: Fix common/ includes.
850         * unittests/array-view-selftests.c: Fix common/ includes.
851         * ui-file.c: Fix common/ includes.
852         * tui/tui-io.c: Fix common/ includes.
853         * tracepoint.h: Fix common/ includes.
854         * tracepoint.c: Fix common/ includes.
855         * tracefile-tfile.c: Fix common/ includes.
856         * top.h: Fix common/ includes.
857         * top.c: Fix common/ includes.
858         * thread.c: Fix common/ includes.
859         * target/waitstatus.h: Fix common/ includes.
860         * target/waitstatus.c: Fix common/ includes.
861         * target.h: Fix common/ includes.
862         * target.c: Fix common/ includes.
863         * target-memory.c: Fix common/ includes.
864         * target-descriptions.c: Fix common/ includes.
865         * symtab.h: Fix common/ includes.
866         * symfile.c: Fix common/ includes.
867         * stap-probe.c: Fix common/ includes.
868         * spu-linux-nat.c: Fix common/ includes.
869         * sparc-nat.c: Fix common/ includes.
870         * source.c: Fix common/ includes.
871         * solib.c: Fix common/ includes.
872         * solib-target.c: Fix common/ includes.
873         * ser-unix.c: Fix common/ includes.
874         * ser-tcp.c: Fix common/ includes.
875         * ser-pipe.c: Fix common/ includes.
876         * ser-base.c: Fix common/ includes.
877         * selftest-arch.c: Fix common/ includes.
878         * s12z-tdep.c: Fix common/ includes.
879         * rust-exp.y: Fix common/ includes.
880         * rs6000-aix-tdep.c: Fix common/ includes.
881         * riscv-tdep.c: Fix common/ includes.
882         * remote.c: Fix common/ includes.
883         * remote-notif.h: Fix common/ includes.
884         * remote-fileio.h: Fix common/ includes.
885         * remote-fileio.c: Fix common/ includes.
886         * regcache.h: Fix common/ includes.
887         * regcache.c: Fix common/ includes.
888         * record-btrace.c: Fix common/ includes.
889         * python/python.c: Fix common/ includes.
890         * python/py-type.c: Fix common/ includes.
891         * python/py-inferior.c: Fix common/ includes.
892         * progspace.h: Fix common/ includes.
893         * producer.c: Fix common/ includes.
894         * procfs.c: Fix common/ includes.
895         * proc-api.c: Fix common/ includes.
896         * printcmd.c: Fix common/ includes.
897         * ppc-linux-nat.c: Fix common/ includes.
898         * parser-defs.h: Fix common/ includes.
899         * osdata.c: Fix common/ includes.
900         * obsd-nat.c: Fix common/ includes.
901         * nat/x86-linux.c: Fix common/ includes.
902         * nat/x86-linux-dregs.c: Fix common/ includes.
903         * nat/x86-dregs.h: Fix common/ includes.
904         * nat/x86-dregs.c: Fix common/ includes.
905         * nat/ppc-linux.c: Fix common/ includes.
906         * nat/mips-linux-watch.h: Fix common/ includes.
907         * nat/mips-linux-watch.c: Fix common/ includes.
908         * nat/linux-waitpid.c: Fix common/ includes.
909         * nat/linux-ptrace.h: Fix common/ includes.
910         * nat/linux-ptrace.c: Fix common/ includes.
911         * nat/linux-procfs.c: Fix common/ includes.
912         * nat/linux-personality.c: Fix common/ includes.
913         * nat/linux-osdata.c: Fix common/ includes.
914         * nat/linux-namespaces.c: Fix common/ includes.
915         * nat/linux-btrace.h: Fix common/ includes.
916         * nat/linux-btrace.c: Fix common/ includes.
917         * nat/fork-inferior.c: Fix common/ includes.
918         * nat/amd64-linux-siginfo.c: Fix common/ includes.
919         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
920         * nat/aarch64-linux.c: Fix common/ includes.
921         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
922         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
923         * namespace.h: Fix common/ includes.
924         * mips-linux-tdep.c: Fix common/ includes.
925         * minsyms.c: Fix common/ includes.
926         * mi/mi-parse.h: Fix common/ includes.
927         * mi/mi-main.c: Fix common/ includes.
928         * mi/mi-cmd-env.c: Fix common/ includes.
929         * memrange.h: Fix common/ includes.
930         * memattr.c: Fix common/ includes.
931         * maint.h: Fix common/ includes.
932         * maint.c: Fix common/ includes.
933         * main.c: Fix common/ includes.
934         * machoread.c: Fix common/ includes.
935         * location.c: Fix common/ includes.
936         * linux-thread-db.c: Fix common/ includes.
937         * linux-nat.c: Fix common/ includes.
938         * linux-fork.c: Fix common/ includes.
939         * inline-frame.c: Fix common/ includes.
940         * infrun.c: Fix common/ includes.
941         * inflow.c: Fix common/ includes.
942         * inferior.h: Fix common/ includes.
943         * inferior.c: Fix common/ includes.
944         * infcmd.c: Fix common/ includes.
945         * inf-ptrace.c: Fix common/ includes.
946         * inf-child.c: Fix common/ includes.
947         * ia64-linux-nat.c: Fix common/ includes.
948         * i387-tdep.c: Fix common/ includes.
949         * i386-tdep.c: Fix common/ includes.
950         * i386-linux-tdep.c: Fix common/ includes.
951         * i386-linux-nat.c: Fix common/ includes.
952         * i386-go32-tdep.c: Fix common/ includes.
953         * i386-fbsd-tdep.c: Fix common/ includes.
954         * i386-fbsd-nat.c: Fix common/ includes.
955         * guile/scm-type.c: Fix common/ includes.
956         * guile/guile.c: Fix common/ includes.
957         * go32-nat.c: Fix common/ includes.
958         * gnu-nat.c: Fix common/ includes.
959         * gdbthread.h: Fix common/ includes.
960         * gdbarch-selftests.c: Fix common/ includes.
961         * gdb_usleep.c: Fix common/ includes.
962         * gdb_select.h: Fix common/ includes.
963         * gdb_bfd.c: Fix common/ includes.
964         * gcore.c: Fix common/ includes.
965         * fork-child.c: Fix common/ includes.
966         * findvar.c: Fix common/ includes.
967         * fbsd-nat.c: Fix common/ includes.
968         * event-top.c: Fix common/ includes.
969         * event-loop.c: Fix common/ includes.
970         * dwarf2read.c: Fix common/ includes.
971         * dwarf2loc.c: Fix common/ includes.
972         * dwarf2-frame.c: Fix common/ includes.
973         * dwarf-index-cache.c: Fix common/ includes.
974         * dtrace-probe.c: Fix common/ includes.
975         * disasm-selftests.c: Fix common/ includes.
976         * defs.h: Fix common/ includes.
977         * csky-tdep.c: Fix common/ includes.
978         * cp-valprint.c: Fix common/ includes.
979         * cp-support.h: Fix common/ includes.
980         * cp-support.c: Fix common/ includes.
981         * corelow.c: Fix common/ includes.
982         * completer.h: Fix common/ includes.
983         * completer.c: Fix common/ includes.
984         * compile/compile.c: Fix common/ includes.
985         * compile/compile-loc2c.c: Fix common/ includes.
986         * compile/compile-cplus-types.c: Fix common/ includes.
987         * compile/compile-cplus-symbols.c: Fix common/ includes.
988         * command.h: Fix common/ includes.
989         * cli/cli-dump.c: Fix common/ includes.
990         * cli/cli-cmds.c: Fix common/ includes.
991         * charset.c: Fix common/ includes.
992         * build-id.c: Fix common/ includes.
993         * btrace.h: Fix common/ includes.
994         * btrace.c: Fix common/ includes.
995         * breakpoint.h: Fix common/ includes.
996         * breakpoint.c: Fix common/ includes.
997         * ax.h: 
998         (enum agent_op): Fix common/ includes.
999         * ax-general.c (struct aop_map): Fix common/ includes.
1000         * ax-gdb.c: Fix common/ includes.
1001         * auxv.c: Fix common/ includes.
1002         * auto-load.c: Fix common/ includes.
1003         * arm-tdep.c: Fix common/ includes.
1004         * arch/riscv.c: Fix common/ includes.
1005         * arch/ppc-linux-common.c: Fix common/ includes.
1006         * arch/i386.c: Fix common/ includes.
1007         * arch/arm.c: Fix common/ includes.
1008         * arch/arm-linux.c: Fix common/ includes.
1009         * arch/arm-get-next-pcs.c: Fix common/ includes.
1010         * arch/amd64.c: Fix common/ includes.
1011         * arch/aarch64.c: Fix common/ includes.
1012         * arch/aarch64-insn.c: Fix common/ includes.
1013         * arch-utils.c: Fix common/ includes.
1014         * amd64-windows-tdep.c: Fix common/ includes.
1015         * amd64-tdep.c: Fix common/ includes.
1016         * amd64-sol2-tdep.c: Fix common/ includes.
1017         * amd64-obsd-tdep.c: Fix common/ includes.
1018         * amd64-nbsd-tdep.c: Fix common/ includes.
1019         * amd64-linux-tdep.c: Fix common/ includes.
1020         * amd64-linux-nat.c: Fix common/ includes.
1021         * amd64-fbsd-tdep.c: Fix common/ includes.
1022         * amd64-fbsd-nat.c: Fix common/ includes.
1023         * amd64-dicos-tdep.c: Fix common/ includes.
1024         * amd64-darwin-tdep.c: Fix common/ includes.
1025         * agent.c: Fix common/ includes.
1026         * ada-lang.h: Fix common/ includes.
1027         * ada-lang.c: Fix common/ includes.
1028         * aarch64-tdep.c: Fix common/ includes.
1029
1030 2019-01-25  Tom Tromey  <tom@tromey.com>
1031
1032         * common/create-version.sh: Use common/version.h.
1033
1034 2019-01-24  Pedro Alves  <palves@redhat.com>
1035
1036         * infrun.c (signal_stop, signal_print, signal_program)
1037         (signal_catch, signal_pass): Now arrays instead of pointers.
1038         (update_signals_program_target, do_target_resume)
1039         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1040         * linux-nat.c (linux_nat_target::pass_signals)
1041         (linux_nat_target::create_inferior, linux_nat_target::attach):
1042         Adjust.
1043         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1044         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1045         * procfs.c (procfs_target::pass_signals): Adjust.
1046         * record-full.c (record_full_target::resume): Adjust.
1047         * remote.c (remote_target::pass_signals)
1048         (remote_target::program_signals): Adjust.
1049         * target-debug.h (target_debug_print_signals): Now takes a
1050         gdb::array_view as parameter.  Adjust.
1051         * target.h (target_ops) <pass_signals, program_signals>: Replace
1052         pointer and length parameters with gdb::array_view.
1053         (target_pass_signals, target_program_signals): Likewise.
1054         * target-delegates.c: Regenerate.
1055
1056 2019-01-24  Pedro Alves  <palves@redhat.com>
1057
1058         * common/forward-scope-exit.h
1059         (forward_scope_exit::forward_scope_exit): Pass arguments to
1060         m_bind_function directly, instead of creating a std::bind and
1061         copying that.
1062
1063 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1064
1065         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1066         for static members.
1067         (pass_in_v_vfp_candidate): Likewise.
1068
1069 2019-01-23  Tom Tromey  <tom@tromey.com>
1070             Pedro Alves  <palves@redhat.com>
1071
1072         * regcache.c (class regcache_invalidator): Remove.
1073         (regcache::raw_write): Use make_scope_exit.
1074
1075 2019-01-23  Tom Tromey  <tom@tromey.com>
1076
1077         * ui-out.h (class ui_out_emit_type): Update comment.
1078
1079 2019-01-23  Tom Tromey  <tom@tromey.com>
1080
1081         * infrun.c (fetch_inferior_event): Update comment.
1082
1083 2019-01-23  Tom Tromey  <tom@tromey.com>
1084             Pedro Alves  <palves@redhat.com>
1085
1086         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1087         parameter.
1088         (fetch_inferior_event): Use SCOPE_EXIT.
1089
1090
1091 2019-01-23  Tom Tromey  <tom@tromey.com>
1092             Pedro Alves  <palves@redhat.com>
1093
1094         * infrun.c (disable_thread_events): Delete.
1095         (stop_all_threads): Use SCOPE_EXIT.
1096
1097 2019-01-23  Tom Tromey  <tom@tromey.com>
1098             Pedro Alves  <palves@redhat.com>
1099
1100         * symfile.c: Include forward-scope-exit.h.
1101         (clear_symtab_users_cleanup): Replace forward declaration with
1102         a FORWARD_SCOPE_EXIT.
1103         (syms_from_objfile_1): Use the forward_scope_exit and
1104         gdb::optional instead of cleanup_function.
1105         (reread_symbols): Use the forward_scope_exit instead of
1106         cleanup_function.
1107         (clear_symtab_users_cleanup): Remove function.
1108
1109 2019-01-23  Tom Tromey  <tom@tromey.com>
1110             Pedro Alves  <palves@redhat.com>
1111
1112         * linux-nat.c: Include scope-exit.h.
1113         (cleanup_target_stop): Remove.
1114         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1115         SCOPE_EXIT.
1116
1117 2019-01-23  Tom Tromey  <tom@tromey.com>
1118             Pedro Alves  <palves@redhat.com>
1119
1120         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1121         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1122
1123 2019-01-23  Tom Tromey  <tom@tromey.com>
1124             Andrew Burgess  <andrew.burgess@embecosm.com>
1125             Pedro Alves  <palves@redhat.com>
1126
1127         * infrun.c (fetch_inferior_event): Use scope_exit.
1128         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1129         * top.c (execute_command): Use scope_exit.
1130         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1131         * utils.c (do_bpstat_clear_actions_cleanup)
1132         (make_bpstat_clear_actions_cleanup): Remove.
1133
1134 2019-01-23  Tom Tromey  <tom@tromey.com>
1135             Pedro Alves  <palves@redhat.com>
1136
1137         * infrun.c: Include "common/scope-exit.h"
1138         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1139         (wait_for_inferior): Use SCOPE_EXIT.
1140         (fetch_inferior_event): Use scope_exit.
1141
1142 2019-01-23  Tom Tromey  <tom@tromey.com>
1143             Pedro Alves  <palves@redhat.com>
1144
1145         * breakpoint.c (create_breakpoint): Remove cleanup.
1146
1147 2019-01-23  Tom Tromey  <tom@tromey.com>
1148             Andrew Burgess  <andrew.burgess@embecosm.com>
1149             Pedro Alves  <palves@redhat.com>
1150
1151 2019-01-23  Pedro Alves  <palves@redhat.com>
1152
1153         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1154
1155 2019-01-23  Pedro Alves  <palves@redhat.com>
1156             Andrew Burgess  <andrew.burgess@embecosm.com>
1157
1158         * gdbthread.h: Include "common/forward-scope-exit.h".
1159         (scoped_finish_thread_state): Redefine custom class in terms of
1160         forward_scope_exit.
1161
1162 2019-01-23  Pedro Alves  <palves@redhat.com>
1163             Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * common/forward-scope-exit.h: New file.
1166
1167 2019-01-23  Pedro Alves  <palves@redhat.com>
1168             Andrew Burgess  <andrew.burgess@embecosm.com>
1169             Tom Tromey  <tom@tromey.com>
1170
1171         * common/scope-exit.h: New file.
1172
1173 2019-01-23  Pedro Alves  <palves@redhat.com>
1174
1175         * common/preprocessor.h (ESC): Rename to ...
1176         (ESC_PARENS): ... this.
1177         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1178         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1179
1180 2019-01-23  Tom Tromey  <tom@tromey.com>
1181
1182         * language.h (class scoped_switch_to_sym_language_if_auto):
1183         Initialize m_lang in both cases.
1184
1185 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1186
1187         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1188         with XCNEW.
1189
1190 2019-01-22  Tom Tromey  <tom@tromey.com>
1191
1192         * corelow.c: Do not include sys/file.h.
1193
1194 2019-01-22  Tom Tromey  <tom@tromey.com>
1195
1196         * tui/tui-wingeneral.h: Include gdb_curses.h.
1197
1198 2019-01-22  Tom Tromey  <tom@tromey.com>
1199
1200         * source-cache.h (class source_cache) <get_source_lines,
1201         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1202
1203 2019-01-22  Tom Tromey  <tom@tromey.com>
1204
1205         * remote-fileio.h (struct remote_target): Declare.
1206
1207 2019-01-22  Tom Tromey  <tom@tromey.com>
1208
1209         * python/py-arch.c: Do not include py-ref.h.
1210         * python/py-bpevent.c: Do not include py-ref.h.
1211         * python/py-cmd.c: Do not include py-ref.h.
1212         * python/py-continueevent.c: Do not include py-ref.h.
1213         * python/py-event.h: Do not include py-ref.h.
1214         * python/py-evtregistry.c: Do not include py-ref.h.
1215         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1216         * python/py-frame.c: Do not include py-ref.h.
1217         * python/py-framefilter.c: Do not include py-ref.h.
1218         * python/py-function.c: Do not include py-ref.h.
1219         * python/py-infevents.c: Do not include py-ref.h.
1220         * python/py-linetable.c: Do not include py-ref.h.
1221         * python/py-objfile.c: Do not include py-ref.h.
1222         * python/py-param.c: Do not include py-ref.h.
1223         * python/py-prettyprint.c: Do not include py-ref.h.
1224         * python/py-progspace.c: Do not include py-ref.h.
1225         * python/py-symbol.c: Do not include py-ref.h.
1226         * python/py-symtab.c: Do not include py-ref.h.
1227         * python/py-type.c: Do not include py-ref.h.
1228         * python/py-unwind.c: Do not include py-ref.h.
1229         * python/py-utils.c: Do not include py-ref.h.
1230         * python/py-value.c: Do not include py-ref.h.
1231         * python/py-varobj.c: Do not include py-ref.h.
1232         * python/py-xmethods.c: Do not include py-ref.h.
1233         * python/python.c: Do not include py-ref.h.
1234         * varobj.c: Do not include py-ref.h.
1235
1236 2019-01-22  Tom Tromey  <tom@tromey.com>
1237
1238         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1239         keyword for bcache.
1240
1241 2019-01-22  Tom Tromey  <tom@tromey.com>
1242
1243         * compile/compile-cplus-types.c: Remove a comment by #include.
1244
1245 2019-01-22  Tom Tromey  <tom@tromey.com>
1246
1247         * compile/gcc-c-plugin.h: Include compile-internal.h.
1248
1249 2019-01-22  Tom Tromey  <tom@tromey.com>
1250
1251         * stabsread.c (EXTERN): Do not define.
1252         (symnum, next_symbol_text_func, processing_gcc_compilation)
1253         (within_function, global_sym_chain, global_stabs)
1254         (previous_stab_code, this_object_header_files)
1255         (n_this_object_header_files)
1256         (n_allocated_this_object_header_files): Define.
1257         * stabsread.h (EXTERN): Never define.  Use "extern".
1258
1259 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1260
1261         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1262         history_value.
1263
1264 2019-01-21  Tom Tromey  <tom@tromey.com>
1265
1266         * ui-out.c: Fix includes.
1267         * tui/tui-source.c: Fix includes.
1268         * target.c: Fix includes.
1269         * remote.c: Fix includes.
1270         * regcache.c: Fix includes.
1271         * python/py-block.c: Fix includes.
1272         * printcmd.c: Fix includes.
1273         * or1k-tdep.c: Fix includes.
1274         * mi/mi-main.c: Fix includes.
1275         * m32r-tdep.c: Fix includes.
1276         * csky-tdep.c: Fix includes.
1277         * compile/compile-cplus-types.c: Fix includes.
1278         * cli/cli-interp.c: Fix includes.
1279
1280 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1281
1282         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1283         for padding.
1284
1285 2019-01-16  Tom Tromey  <tom@tromey.com>
1286
1287         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1288         earlier.
1289         (struct objfile) <msymbols_range>: Move from top level.
1290         <msymbols>: New method.
1291         (class objfile_msymbols): Remove.
1292         * symtab.c (default_collect_symbol_completion_matches_break_on):
1293         Update.
1294         * symmisc.c (dump_msymbols): Update.
1295         * stabsread.c (scan_file_globals): Update.
1296         * objc-lang.c (info_selectors_command, info_classes_command)
1297         (find_methods): Update.
1298         * minsyms.c (find_solib_trampoline_target): Update.
1299         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1300         * coffread.c (coff_symfile_read): Update.
1301         * ada-lang.c (ada_lookup_simple_minsym)
1302         (ada_collect_symbol_completion_matches): Update.
1303
1304 2019-01-16  Tom Tromey  <tom@tromey.com>
1305
1306         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1307         type.  Remove no-argument constructor.
1308         <iterator::operator++>: Simplify.
1309         <begin>: Update.
1310         <end>: Use minimal_symbol_count.
1311
1312 2019-01-16  Tom Tromey  <tom@tromey.com>
1313
1314         * objfiles.h (struct objfile) <psymtabs>: New method.
1315         (class objfile_psymtabs): Remove.
1316         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1317         typedef.
1318         <range>: New method.
1319         (require_partial_symbols): Change return type.
1320         * psymtab.c (require_partial_symbols)
1321         (psym_expand_symtabs_matching): Update.
1322         * mdebugread.c (parse_partial_symbols): Update.
1323         * dbxread.c (dbx_end_psymtab): Update.
1324
1325 2019-01-15  Tom Tromey  <tom@tromey.com>
1326
1327         * symtab.c (lookup_objfile_from_block)
1328         (lookup_symbol_in_objfile_symtabs)
1329         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1330         (find_line_symtab, info_sources_command)
1331         (default_collect_symbol_completion_matches_break_on)
1332         (make_source_files_completion_list): Update.
1333         * symmisc.c (print_objfile_statistics, dump_objfile)
1334         (maintenance_print_symbols, maintenance_info_symtabs)
1335         (maintenance_check_symtabs, maintenance_info_line_tables):
1336         Update.
1337         * source.c (select_source_symtab)
1338         (forget_cached_source_info_for_objfile): Update.
1339         * objfiles.h (class objfile_compunits): Remove.
1340         (struct objfile) <compunits_range>: New typedef.
1341         (compunits): New method.
1342         * objfiles.c (objfile_relocate1): Update.
1343         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1344         * maint.c (count_symtabs_and_blocks): Update.
1345         * linespec.c (iterate_over_all_matching_symtabs): Update.
1346         * cp-support.c (add_symbol_overload_list_qualified): Update.
1347         * coffread.c (coff_symtab_read): Update.
1348         * ada-lang.c (add_nonlocal_symbols)
1349         (ada_collect_symbol_completion_matches)
1350         (ada_add_global_exceptions): Update.
1351
1352 2019-01-15  Tom Tromey  <tom@tromey.com>
1353
1354         * progspace.h (program_space) <objfiles_safe_range>: New
1355         typedef.
1356         <objfiles_safe>: New method.
1357         * objfiles.h (class all_objfiles_safe): Remove.
1358         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1359         * jit.c (jit_inferior_exit_hook): Update.
1360
1361 2019-01-17  Tom Tromey  <tom@tromey.com>
1362
1363         * progspace.h (program_space) <objfiles_range>: New typedef.
1364         <objfiles>: New method.
1365         <objfiles_head>: Rename from objfiles.
1366         (object_files): Update.
1367         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1368         * guile/scm-pretty-print.c
1369         (ppscm_find_pretty_printer_from_objfiles): Update.
1370         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1371         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1372         Update.
1373         * python/py-progspace.c (pspy_get_objfiles): Update.
1374         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1375         Update.
1376         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1377         (objfpy_lookup_objfile_by_build_id): Update.
1378         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1379         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1380         Update.
1381         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1382         (expand_symtab_containing_pc, lookup_objfile_from_block)
1383         (lookup_static_symbol, basic_lookup_transparent_type)
1384         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1385         (find_line_symtab, info_sources_command)
1386         (default_collect_symbol_completion_matches_break_on)
1387         (make_source_files_completion_list, find_main_name): Update.
1388         * symmisc.c (print_symbol_bcache_statistics)
1389         (print_objfile_statistics, maintenance_print_symbols)
1390         (maintenance_print_msymbols, maintenance_print_objfiles)
1391         (maintenance_info_symtabs, maintenance_check_symtabs)
1392         (maintenance_expand_symtabs, maintenance_info_line_tables):
1393         Update.
1394         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1395         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1396         (map_overlay_command, unmap_overlay_command)
1397         (simple_overlay_update, expand_symtabs_matching)
1398         (map_symbol_filenames): Update.
1399         * symfile-debug.c (set_debug_symfile): Update.
1400         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1401         Update.
1402         * source.c (select_source_symtab, forget_cached_source_info):
1403         Update.
1404         * solib.c (solib_read_symbols): Update.
1405         * solib-spu.c (append_ocl_sos): Update.
1406         * psymtab.c (maintenance_print_psymbols)
1407         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1408         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1409         * printcmd.c (info_symbol_command): Update.
1410         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1411         Update.
1412         * objfiles.h (class all_objfiles): Remove.
1413         * objfiles.c (have_partial_symbols, have_full_symbols)
1414         (have_minimal_symbols, qsort_cmp, update_section_map)
1415         (shared_objfile_contains_address_p)
1416         (default_iterate_over_objfiles_in_search_order): Update.
1417         * objc-lang.c (info_selectors_command, info_classes_command)
1418         (find_methods): Update.
1419         * minsyms.c (find_solib_trampoline_target): Update.
1420         * maint.c (maintenance_info_sections)
1421         (maintenance_translate_address, count_symtabs_and_blocks):
1422         Update.
1423         * main.c (captured_main_1): Update.
1424         * linux-thread-db.c (try_thread_db_load_from_pdir)
1425         (has_libpthread): Update.
1426         * linespec.c (iterate_over_all_matching_symtabs)
1427         (search_minsyms_for_name): Update.
1428         * jit.c (jit_find_objf_with_entry_addr): Update.
1429         * hppa-tdep.c (find_unwind_entry)
1430         (hppa_lookup_stub_minimal_symbol): Update.
1431         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1432         Update.
1433         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1434         (elf_gnu_ifunc_resolve_by_got): Update.
1435         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1436         * dwarf-index-write.c (save_gdb_index_command): Update.
1437         * cp-support.c (add_symbol_overload_list_qualified): Update.
1438         * breakpoint.c (create_overlay_event_breakpoint)
1439         (create_longjmp_master_breakpoint)
1440         (create_std_terminate_master_breakpoint)
1441         (create_exception_master_breakpoint): Update.
1442         * blockframe.c (find_pc_partial_function): Update.
1443         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1444         (ada_collect_symbol_completion_matches)
1445         (ada_add_global_exceptions): Update.
1446
1447 2019-01-17  Tom Tromey  <tom@tromey.com>
1448
1449         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1450         declare VEC.
1451         (solib_target_parse_libraries): Change return type.
1452         (library_list_start_segment, library_list_start_section)
1453         (library_list_end_library, library_list_start_library); Update.
1454         (solib_target_free_library_list): Remove.
1455         (solib_target_parse_libraries): Remove cleanup.  Change return
1456         type.
1457         (solib_target_current_sos): Update.
1458
1459 2019-01-17  Tom Tromey  <tromey@bapiya>
1460
1461         * valprint.c: Replace "the the" with "the".
1462         * symtab.c: Replace "the the" with "the".
1463         * solib.c: Replace "the the" with "the".
1464         * solib-dsbt.c: Replace "the the" with "the".
1465         * linespec.c: Replace "the the" with "the".
1466         * dwarf2loc.h: Replace "the the" with "the".
1467         * amd64-windows-tdep.c: Replace "the the" with "the".
1468         * aarch64-tdep.c: Replace "the the" with "the".
1469
1470 2019-01-16  Keith Seitz  <keiths@redhat.com>
1471
1472         PR gdb/23773
1473         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1474         <builder>: Rename to ..
1475         <m_builder>: ... this and make private.
1476         (dwarf2_cu::get_builder): New method.  Change all users of
1477         `builder' to use this method.
1478         (dwarf2_start_symtab): Move to ...
1479         (dwarf2_cu::start_symtab): ... here.  Update all callers
1480         (setup_type_unit_groups): Move to ...
1481         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1482         callers.
1483         (dwarf2_cu::reset_builder): New method.
1484         (process_full_compunit, process_full_type_unit): Use
1485         dwarf2_cu::reset_builder.
1486         (follow_die_offset): Record the ancestor CU if it is different
1487         from the followed DIE's CU.
1488         (follow_die_sig_1): Likewise.
1489
1490 2019-01-15  Tom Tromey  <tom@tromey.com>
1491
1492         * remote.c (class remote_state) <buf>: Now a char_vector.
1493         <buf_size>: Remove.
1494         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1495         parameter.
1496         (remote_target::getpkt_or_notif_sane_1)
1497         (remote_target::getpkt_sane)
1498         (remote_target::getpkt_or_notif_sane): Likewise.
1499         (class remote_target) <putpkt>: New overload.
1500         (remote_target::read_frame): Change type of "buf_p".  Remove
1501         sizeof_p parameter.
1502         (packet_ok): New overload.
1503         (packet_check_result): New overload.
1504         Update all uses.
1505
1506 2019-01-14  Tom Tromey  <tom@tromey.com>
1507
1508         * remote-notif.c (handle_notification, remote_notif_ack)
1509         (remote_notif_parse): Make "buf" const.
1510         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1511         const.
1512         (remote_notif_parse, remote_notif_ack, handle_notification):
1513         Likewise.
1514         * remote.c (remote_notif_stop_parse): Make "buf" const.
1515         (remote_target::remote_parse_stop_reply): Make "buf" const.
1516         (remote_notif_stop_ack): Make "buf" const.
1517
1518 2019-01-14  Tom Tromey  <tom@tromey.com>
1519
1520         * remote.c (remote_console_output): Make parameter const.
1521
1522 2019-01-14  Tom Tromey  <tom@tromey.com>
1523
1524         * target-debug.h (target_debug_print_signals): Constify.
1525         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1526         * procfs.c (procfs_target::pass_signals): Update.
1527         * linux-nat.c (linux_nat_target::pass_signals): Update.
1528         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1529         * target-delegates.c: Rebuild.
1530         * remote.c (remote_target::program_signals): Update.
1531         (remote_target::pass_signals): Update.
1532         * target.c (target_pass_signals): Constify argument.
1533         (target_program_signals): Likewise.
1534         * target.h (struct target_ops) <pass_signals, program_signals>:
1535         Constify argument.
1536         (target_pass_signals, target_program_signals): Constify argument.
1537
1538 2019-01-14  Tom Tromey  <tom@tromey.com>
1539
1540         PR tui/28819:
1541         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1542
1543 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1544
1545         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1546         field.
1547         * rs6000-tdep.c: Include reggroups.h.
1548         (IS_V_ALIAS_PSEUDOREG): Define.
1549         (rs6000_register_name): Return names for the "vX" aliases.
1550         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1551         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1552         aliases.  Call default_register_reggroup_p for all other
1553         pseudo-registers.
1554         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1555         New functions.
1556         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1557         Handle "vX" aliases.
1558         (v_alias_pseudo_register_collect): New function.
1559         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1560         (rs6000_gdbarch_init): Initialize "vX" aliases as
1561         pseudo-registers.  Restore registration of
1562         rs6000_pseudo_register_reggroup_p with
1563         set_tdesc_pseudo_register_reggroup_p.
1564
1565 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1566
1567         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1568         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1569         set_gdbarch_num_pseudo_regs.
1570
1571 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1572
1573         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1574         Remove arg prefixname, add do_set and do_show.
1575         Add member functions set_list and show_list.
1576         * cli/cli-style.c (class cli_style_option): Update accordingly.
1577         (style_set_list): Move to file scope.
1578         (style_show_list): Likewise.
1579         (set_style): Call help_list.
1580         (show_style): Call cmd_show_list.
1581         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1582         Update to use the new macro.
1583
1584 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1585
1586         * ada-lang.c (_initialize_ada_language): Expand the help text
1587         for the "catch exception" command.
1588
1589 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1590
1591         * symtab.c (matching_obj_sections): Initialize obj,
1592         declare it closer to its usage.
1593
1594 2019-01-10  Tom Tromey  <tom@tromey.com>
1595
1596         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1597         (basic_inf_threads_range): Remove.
1598         (inf_threads_range, inf_non_exited_threads_range)
1599         (safe_inf_threads_range): Use next_adapter.
1600
1601 2019-01-10  Keith Seitz  <keiths@redhat.com>
1602
1603         PR gdb/23712
1604         PR symtab/23010
1605         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1606         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1607
1608 2019-01-10  Keith Seitz  <keiths@redhat.com>
1609
1610         PR gdb/23712
1611         PR symtab/23010
1612         * dictionary.c (pending_to_vector): Remove.
1613         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1614         Remove _1 suffix, replacing functions of the same name.  Update
1615         all callers.
1616         (dict_create_hashed, dict_create_hashed_expandable)
1617         (dict_create_linear, dict_create_linear_expandable, dict_free)
1618         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1619         Make functions static.
1620
1621 2019-01-10  Keith Seitz  <keiths@redhat.com>
1622
1623         PR gdb/23712
1624         PR symtab/23010
1625         * dictionary.h (struct dictionary): Replace declaration with
1626         multidictionary.
1627         (dict_create_hashed, dict_create_hashed_expandable)
1628         (dict_create_linear, dict_create_linear_expandable)
1629         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1630         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1631         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1632         taking multidictionary argument.
1633         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1634         * block.h (struct block) <dict>: Change to multidictionary
1635         and rename `multidict'.
1636         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1637         symmisc.c: Update all dictionary references to multidictionary.
1638
1639 2019-01-10  Keith Seitz  <keiths@redhat.com>
1640
1641         PR gdb/23712
1642         PR symtab/23010
1643         * dictionary.c: Include unordered_map.
1644         (pending_to_vector): New function.
1645         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1646         Rewrite the non-"_1" functions to take vector instead
1647         of linked list.
1648         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1649         "new" _1 versions of the same name.
1650         (multidictionary): Define.
1651         (std::hash<enum language): New definition.
1652         (collate_pending_symbols_by_language, mdict_create_hashed)
1653         (mdict_create_hashed_expandable, mdict_create_linear)
1654         (mdict_create_linear_expandable, mdict_free)
1655         (find_language_dictionary, create_new_language_dictionary)
1656         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1657         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1658         (mdict_size, mdict_empty): New functions.
1659         * dictionary.h (mdict_iterator): Define.
1660
1661 2019-01-10  Pedro Alves  <palves@redhat.com>
1662
1663         * breakpoint.c (read_uploaded_action)
1664         (create_tracepoint_from_upload): Adjust to use
1665         gdb::unique_xmalloc_ptr.
1666         * ctf.c (ctf_write_uploaded_tp):
1667         (SET_ARRAY_FIELD): Use emplace_back.
1668         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1669         * tracefile-tfile.c (tfile_write_uploaded_tp):
1670         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1671         gdb::unique_xmalloc_ptr.
1672         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1673         at_string, cond_string, cmd_strings>: Replace char pointers
1674         with gdb::unique_xmalloc_ptr.
1675
1676 2019-01-10  Pedro Alves  <palves@redhat.com>
1677
1678         * solib-target.c (library_list_start_library): Don't xstrdup name.
1679
1680 2019-01-10  Pedro Alves  <palves@redhat.com>
1681
1682         * mdebugread.c (parse_partial_symbols): Use
1683         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1684
1685 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1686
1687         * linux-fork.c (scoped_switch_fork_info)
1688         <~scoped_switch_fork_info>: Fix incorrect variable name.
1689
1690 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1691
1692         * linux-fork.c (scoped_switch_fork_info)
1693         <scoped_switch_fork_info>: Make explicit.
1694         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1695
1696 2019-01-10  Tom Tromey  <tom@tromey.com>
1697
1698         * objfiles.h (objfile::reset_psymtabs): Update.
1699         * objfiles.c (objfile::objfile): Update.
1700         * psymtab.h (psymtab_storage::obstack): Update.
1701         (psymtab_storage::m_obstack): Use gdb::optional.
1702         (class psymtab_storage): Update comment.  Remove objfile
1703         parameter.
1704         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1705
1706 2019-01-10  Tom Tromey  <tom@tromey.com>
1707
1708         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1709         <free_psymtabs>: Now private.
1710         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1711         (allocate_psymtab): Use new method.
1712
1713 2019-01-10  Tom Tromey  <tom@tromey.com>
1714
1715         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1716         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1717         * mdebugread.c (parse_partial_symbols): Use
1718         allocate_dependencies.
1719         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1720         allocate_dependencies.
1721         (process_psymtab_comp_unit_reader)
1722         (build_type_psymtab_dependencies): Likewise.
1723         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1724
1725 2019-01-10  Tom Tromey  <tom@tromey.com>
1726
1727         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1728         PSYMBOL_SET_LANGUAGE.
1729         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1730
1731 2019-01-10  Tom Tromey  <tom@tromey.com>
1732
1733         * psymtab.h (psymtab_storage::obstack): New method.
1734         <m_obstack>: Rename from obstack; now private.
1735         * psymtab.c (psymtab_storage): Update.
1736         * dwarf2read.c (create_addrmap_from_index)
1737         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1738         Update.
1739
1740 2019-01-10  Tom Tromey  <tom@tromey.com>
1741
1742         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1743         * objfiles.h (objfile::reset_psymtabs): New method.
1744
1745 2019-01-10  Tom Tromey  <tom@tromey.com>
1746
1747         * symmisc.c (print_symbol_bcache_statistics): Update.
1748         (print_objfile_statistics): Update.
1749         * symfile.c (reread_symbols): Update.
1750         * psymtab.h (class psymtab_storage): New.
1751         * psymtab.c (psymtab_storage): New constructor.
1752         (~psymtab_storage): New destructor.
1753         (require_partial_symbols): Update.
1754         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1755         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1756         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1757         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1758         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1759         (start_psymtab_common, end_psymtab_common)
1760         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1761         (allocate_psymtab): Update.
1762         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1763         Update.
1764         (dump_psymtab_addrmap, maintenance_print_psymbols)
1765         (maintenance_check_psymtabs): Update.
1766         (class objfile_psymtabs): Move to objfiles.h.
1767         * psympriv.h (discard_psymtab): Now inline.
1768         (psymtab_discarder::psymtab_discarder): Update.
1769         (psymtab_discarder::~psymtab_discarder): Update.
1770         (ALL_OBJFILE_PSYMTABS): Rewrite.
1771         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1772         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1773         Remove fields.
1774         <partial_symtabs>: New field.
1775         (class objfile_psymtabs): Move from psymtab.h.  Update.
1776         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1777         psymbol_cache.
1778         (objfile::~objfile): Don't destroy psymbol_cache.
1779         * mdebugread.c (parse_partial_symbols): Update.
1780         * dwarf2read.c (create_addrmap_from_index)
1781         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1782         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1783         (add_partial_subprogram, dwarf2_ranges_read): Update.
1784         * dwarf-index-write.c (write_address_map)
1785         (write_one_signatured_type, recursively_write_psymbols)
1786         (class debug_names, class debug_names, write_psymtabs_to_index):
1787         Update.
1788
1789 2019-01-10  Tom Tromey  <tom@tromey.com>
1790
1791         * symtab.h (SYMBOL_SET_NAMES): Update.
1792         (symbol_set_names): Update.
1793         (MSYMBOL_SET_NAMES): Update.
1794         * symtab.c (symbol_set_names): Change argument to be an
1795         objfile_per_bfd_storage.
1796         * psymtab.c (add_psymbol_to_bcache): Update.
1797         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1798
1799 2019-01-10  Tom Tromey  <tom@tromey.com>
1800
1801         * symtab.c (create_demangled_names_hash): Change argument to be an
1802         objfile_per_bfd_storage.
1803         (symbol_set_names): Update.
1804
1805 2019-01-10  Tom Tromey  <tom@tromey.com>
1806
1807         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1808         init_psymbol_list.
1809         * psymtab.c (init_psymbol_list): Do nothing if already called.
1810         * psympriv.h (init_psymbol_list): Add comment.
1811         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1812         init_psymbol_list.
1813         * dbxread.c (dbx_symfile_read): Unconditionally call
1814         init_psymbol_list.
1815
1816 2019-01-10  Tom Tromey  <tom@tromey.com>
1817
1818         * xcoffread.c (scan_xcoff_symtab): Update.
1819         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1820         "where".
1821         * mdebugread.c (parse_partial_symbols)
1822         (handle_psymbol_enumerators): Update.
1823         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1824         * dbxread.c (read_dbx_symtab): Update.
1825         * psympriv.h (psymbol_placement): New enum.
1826         (add_psymbol_to_list): Update.
1827
1828 2019-01-10  Tom Tromey  <tom@tromey.com>
1829
1830         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1831         static_psymbols parameters.
1832         (scan_xcoff_symtab): Update.
1833         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1834         static_psymbols parameters.
1835         * psympriv.h (start_psymtab_common): Update.
1836         * mdebugread.c (parse_partial_symbols): Update.
1837         * dwarf2read.c (create_partial_symtab): Update.
1838         * dbxread.c (read_dbx_symtab): Update.
1839         (start_psymtab): Remove global_psymbols and static_psymbols
1840         parameters.
1841
1842 2019-01-10  Tom Tromey  <tom@tromey.com>
1843
1844         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1845         * psymtab.c (allocate_psymtab): Add comment.
1846         * psympriv.h (allocate_psymtab): Add comment.
1847         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1848         initializations.
1849         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1850
1851 2019-01-10  Tom Tromey  <tom@tromey.com>
1852
1853         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1854         Don't declare.
1855         * mipsread.c: Include mdebugread.h.
1856         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1857         Declare.
1858         * elfread.c: Include mdebugread.h.
1859
1860 2019-01-09  Tom Tromey  <tom@tromey.com>
1861
1862         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1863         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1864         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1865         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1866         (psym_lookup_symbol, psym_find_last_source_symtab)
1867         (psym_forget_cached_source_info, psym_print_stats)
1868         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1869         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1870         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1871         (psym_find_compunit_symtab_by_address)
1872         (maintenance_print_psymbols, maintenance_info_psymtabs)
1873         (maintenance_check_psymtabs): Use ranged for.
1874         * psymtab.h (class objfile_psymtabs): New.
1875         (require_partial_symbols): Return objfile_psymtabs.
1876         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1877
1878 2019-01-09  Tom Tromey  <tom@tromey.com>
1879
1880         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1881         (find_pc_mapped_section, list_overlays_command)
1882         (map_overlay_command, unmap_overlay_command)
1883         (simple_overlay_update): Use all_objfiles.
1884         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1885         * printcmd.c (info_symbol_command): Use all_objfiles.
1886         * objfiles.h (ALL_OBJSECTIONS): Remove.
1887         * maint.c (maintenance_translate_address): Use all_objfiles.
1888         * gcore.c (gcore_create_callback): Use all_objfiles.
1889         (objfile_find_memory_regions): Likewise.
1890
1891 2019-01-09  Tom Tromey  <tom@tromey.com>
1892
1893         * symtab.c (find_line_symtab, info_sources_command)
1894         (make_source_files_completion_list): Use objfile_compunits.
1895         * source.c (select_source_symtab): Use objfile_compunits.
1896         * objfiles.h (struct objfile): Update comment.
1897         (ALL_OBJFILES): Remove.
1898         (ALL_FILETABS): Remove.
1899         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1900         objfile_compunits.
1901
1902 2019-01-09  Tom Tromey  <tom@tromey.com>
1903
1904         * symmisc.c (print_objfile_statistics, dump_objfile)
1905         (maintenance_print_symbols): Use compunit_filetabs.
1906         * source.c (forget_cached_source_info_for_objfile): Use
1907         compunit_filetabs.
1908         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1909         (ALL_FILETABS): Use compunit_filetabs.
1910         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1911         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1912
1913 2019-01-09  Tom Tromey  <tom@tromey.com>
1914
1915         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1916         (compunit_filetabs): New.
1917         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1918         compunit_filetabs.
1919         (info_sources_command, make_source_files_completion_list): Remove
1920         declaration.
1921         * symmisc.c (print_objfile_statistics, dump_objfile)
1922         (maintenance_print_symbols): Remove declaration.
1923         (maintenance_info_symtabs): Use compunit_filetabs.
1924         (maintenance_info_line_tables): Likewise.
1925         * source.c (select_source_symtab): Change local variable name.
1926         (forget_cached_source_info_for_objfile): Remove declaration.
1927         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1928         * objfiles.c (objfile_relocate1): Remove declaration.
1929         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1930         declaration.
1931         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1932         * coffread.c (coff_symtab_read): Remove declaration.
1933         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1934         compunit_filetabs.
1935
1936 2019-01-09  Tom Tromey  <tom@tromey.com>
1937
1938         * symtab.c (lookup_objfile_from_block)
1939         (find_pc_sect_compunit_symtab, search_symbols)
1940         (default_collect_symbol_completion_matches_break_on): Use
1941         objfile_compunits.
1942         * objfiles.h (ALL_COMPUNITS): Remove.
1943         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1944         * cp-support.c (add_symbol_overload_list_qualified): Use
1945         objfile_compunits.
1946         * ada-lang.c (ada_collect_symbol_completion_matches)
1947         (ada_add_global_exceptions): Use objfile_compunits.
1948
1949 2019-01-09  Tom Tromey  <tom@tromey.com>
1950
1951         * source.c (select_source_symtab)
1952         (forget_cached_source_info_for_objfile): Remove declaration.
1953         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1954         declaration.
1955         * maint.c (count_symtabs_and_blocks): Remove declaration.
1956         * cp-support.c (add_symbol_overload_list_qualified): Remove
1957         declaration.
1958         * coffread.c (coff_symtab_read): Remove declaration.
1959         * symtab.c (lookup_symbol_in_objfile_symtabs)
1960         (basic_lookup_transparent_type_1): Use objfile_compunits.
1961         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1962         (info_sources_command, search_symbols)
1963         (default_collect_symbol_completion_matches_break_on)
1964         (make_source_files_completion_list): Remove declaration.
1965         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1966         (ada_collect_symbol_completion_matches)
1967         (ada_add_global_exceptions): Remove declaration.
1968         * linespec.c (iterate_over_all_matching_symtabs): Use
1969         objfile_compunits.
1970         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1971         (class objfile_compunits): New.
1972         (ALL_COMPUNITS): Use objfile_compunits.
1973         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1974         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1975         objfile_compunits.
1976         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1977
1978 2019-01-09  Tom Tromey  <tom@tromey.com>
1979
1980         * symtab.c (search_symbols)
1981         (default_collect_symbol_completion_matches_break_on): Use
1982         objfile_msymbols.
1983         * ada-lang.c (ada_lookup_simple_minsym)
1984         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1985         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1986         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1987         objfile_msymbols.
1988         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1989         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1990         * objc-lang.c (find_methods): Use objfile_msymbols.
1991         (info_selectors_command, info_classes_command): Likewise.
1992         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1993         * objfiles.h (class objfile_msymbols): New.
1994         (ALL_OBJFILE_MSYMBOLS): Remove.
1995         (ALL_MSYMBOLS): Remove.
1996
1997 2019-01-09  Tom Tromey  <tom@tromey.com>
1998
1999         * common/next-iterator.h (next_adapter): Add Iterator template
2000         parameter.
2001         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2002         (class all_objfiles_safe): New.
2003         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2004         * objfiles.c (put_objfile_before): Update comment.
2005         (add_separate_debug_objfile): Likewise.
2006         (free_all_objfiles): Use all_objfiles_safe.
2007         (objfile_purge_solibs): Likewise.
2008
2009 2019-01-09  Tom Tromey  <tom@tromey.com>
2010
2011         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2012         (expand_symtab_containing_pc, lookup_static_symbol)
2013         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2014         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2015         all_objfiles.
2016         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2017         * breakpoint.c (create_overlay_event_breakpoint)
2018         (create_longjmp_master_breakpoint)
2019         (create_std_terminate_master_breakpoint)
2020         (create_exception_master_breakpoint): Use all_objfiles.
2021         * linux-thread-db.c (try_thread_db_load_from_pdir)
2022         (has_libpthread): Use all_objfiles.
2023         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2024         * linespec.c (iterate_over_all_matching_symtabs)
2025         (search_minsyms_for_name): Use all_objfiles.
2026         * maint.c (maintenance_info_sections): Use all_objfiles.
2027         * main.c (captured_main_1): Use all_objfiles.
2028         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2029         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2030         * guile/scm-pretty-print.c
2031         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2032         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2033         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2034         (maintenance_print_msymbols): Use all_objfiles.
2035         * source.c (select_source_symtab): Use all_objfiles.
2036         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2037         * symfile.c (remove_symbol_file_command)
2038         (expand_symtabs_matching, map_symbol_filenames): Use
2039         all_objfiles.
2040         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2041         all_objfiles.
2042         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2043         * objc-lang.c (find_methods): Use all_objfiles.
2044         * objfiles.c (have_partial_symbols, have_full_symbols)
2045         (have_minimal_symbols, qsort_cmp)
2046         (default_iterate_over_objfiles_in_search_order): Use
2047         all_objfiles.
2048         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2049         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2050         (maintenance_check_psymtabs): Use all_objfiles.
2051         (ALL_PSYMTABS): Remove.
2052         * compile/compile-object-run.c (do_module_cleanup): Use
2053         all_objfiles.
2054         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2055         * cp-support.c (add_symbol_overload_list_qualified): Use
2056         all_objfiles.
2057         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2058         Use all_objfiles.
2059         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2060         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2061         all_objfiles.
2062         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2063         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2064         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2065         Uses all_objfiles.
2066         * solib.c (solib_read_symbols): Use all_objfiles
2067
2068 2019-01-09  Tom Tromey  <tom@tromey.com>
2069
2070         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2071         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2072         all_objfiles.
2073         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2074         * symmisc.c (print_symbol_bcache_statistics)
2075         (print_objfile_statistics, maintenance_print_objfiles)
2076         (maintenance_info_symtabs, maintenance_check_symtabs)
2077         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2078         all_objfiles.
2079         * source.c (forget_cached_source_info): Use all_objfiles.
2080         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2081         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2082         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2083         * objfiles.c (update_section_map): Use all_objfiles.
2084         (shared_objfile_contains_address_p): Likewise.
2085         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2086         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2087
2088 2019-01-09  Tom Tromey  <tom@tromey.com>
2089
2090         * common/next-iterator.h: New file.
2091         * objfiles.h (class all_objfiles): New.
2092         (struct objfile_iterator): New.
2093
2094 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2095
2096         * NEWS: Move the description of the changed "frame", "select-frame",
2097          and "info frame" commands to the Changed commands section.
2098
2099 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2100
2101         * gdbtypes.c (check_stub_method_group): Remove handling of old
2102         mangling schemes.
2103         * linespec.c (find_methods): Likewise.
2104         * stabsread.c (read_member_functions): Likewise.
2105         * valops.c (search_struct_method): Likewise.
2106         (value_struct_elt_for_reference): Likewise.
2107         * NEWS: Mention this change.
2108
2109 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2110
2111         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2112         print_source_lines.
2113         * source.c (print_source_lines_base): Update line number check.
2114         (print_source_lines): New function.
2115         (source_lines_range::source_lines_range): New function.
2116         * source.h (class source_lines_range): New class.
2117         (print_source_lines): New declaration.
2118
2119 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2120
2121         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2122
2123 2019-01-08  Tom Tromey  <tom@tromey.com>
2124             Simon Marchi  <simon.marchi@ericsson.com>
2125
2126         PR gdb/24060
2127         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2128         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2129         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2130         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2131         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2132         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2133
2134 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2135
2136         * source.c (select_source_symtab): Move header comment to
2137         declaration in source.h.
2138         (forget_cached_source_info_for_objfile): Likewise.
2139         (forget_cached_source_info): Likewise.
2140         (identify_source_line): Likewise.
2141         * source.h (identify_source_line): Move declaration from symtab.h
2142         and add comment from source.c
2143         (print_source_lines): Likewise.
2144         (forget_cached_source_info_for_objfile): Likewise.
2145         (forget_cached_source_info): Likewise.
2146         (select_source_symtab): Likewise.
2147         (enum print_source_lines_flag): Move definition from symtab.h.
2148         * symtab.h (identify_source_line): Move declaration to source.h.
2149         (print_source_lines): Likewise.
2150         (forget_cached_source_info_for_objfile): Likewise.
2151         (forget_cached_source_info): Likewise.
2152         (select_source_symtab): Likewise.
2153         (enum print_source_lines_flag): Move definition to source.h.
2154         * tui/tui-hooks.c: Add 'source.h' include.
2155
2156 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2157
2158         * source.c (print_source_lines_base): Handle requests to print
2159         reverse line number sequences, and guard against empty lines
2160         string.
2161
2162 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2163
2164         * source.c (print_source_lines_base): Fix skip of '\r' if next
2165         character is '\n'.
2166
2167 2019-01-06  Tom Tromey  <tom@tromey.com>
2168
2169         * c-exp.y (struct c_parse_state) <macro_original_text,
2170         expansion_obstack>: New member.
2171         (macro_original_text, expansion_obstack): Remove globals.
2172         (scan_macro_expansion, scanning_macro_expansion)
2173         (finished_macro_expansion): Update.
2174         (scan_macro_cleanup): Remove.
2175         (yylex, c_parse): Update.
2176
2177 2019-01-06  Tom Tromey  <tom@tromey.com>
2178
2179         * c-exp.y (struct c_parse_state) <strings>: New member.
2180         (operator_stoken): Update.
2181
2182 2019-01-06  Tom Tromey  <tom@tromey.com>
2183
2184         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2185         (union type_stack_elt) <typelist_val>: Now a pointer to
2186         std::vector.
2187         (type_stack_cleanup): Don't declare.
2188         (push_typelist): Update.
2189         * parse.c (pop_typelist): Return a std::vector.
2190         (push_typelist): Take a std::vector.
2191         (follow_types): Update.  Do not free args.
2192         (type_stack_cleanup): Remove.
2193         * c-exp.y (struct c_parse_state): New.
2194         (cpstate): New global.
2195         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2196         (nonempty_typelist): Update.
2197         (func_mod): Create a new vector.
2198         (c_parse): Create a c_parse_state.
2199         (check_parameter_typelist): Do not delete params.
2200         (function_method): Update.  Do not delete type_list.
2201
2202 2019-01-06  Tom Tromey  <tom@tromey.com>
2203
2204         PR gdb/28155:
2205         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2206         check_typedef.
2207         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2208         (print_return_value): Likewise.
2209
2210 2019-01-05  Tom Tromey  <tom@tromey.com>
2211
2212         * contrib/cleanup_check.py: Remove.
2213         * contrib/gcc-with-excheck: Remove.
2214         * contrib/exsummary.py: Remove.
2215         * contrib/excheck.py: Remove.
2216
2217 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2218
2219         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2220         NULL. Initialize tpprev to NULL instead of assigning it
2221         to NULL on the next statement.
2222         * windows-nat.c (windows_delete_thread): Remove check for
2223         main_thread_id before printing thread exit notifications.
2224         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2225         Remove thread ID check against main_thread_id.
2226         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2227         windows_delete_thread.
2228         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2229
2230 2019-01-04  Tom Tromey  <tom@tromey.com>
2231
2232         * compile/compile.c (_initialize_compile): Use upper case for
2233         metasyntactic variables.
2234         * symmisc.c (_initialize_symmisc): Use upper case for
2235         metasyntactic variables.
2236         * psymtab.c (_initialize_psymtab): Use upper case for
2237         metasyntactic variables.
2238         * demangle.c (demangle_command): Use upper case for metasyntactic
2239         variables.
2240         (_initialize_demangler): Likewise.
2241         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2242         variables.
2243
2244 2019-01-03  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2247
2248 2019-01-03  Tom Tromey  <tom@tromey.com>
2249
2250         * python/py-symtab.c (salpy_str): Update.
2251         (struct salpy_sal_object) <symtab>: Now a PyObject.
2252         (salpy_dealloc): Update.
2253         (del_objfile_sal): Use gdbpy_ref.
2254
2255 2019-01-03  Tom Tromey  <tom@tromey.com>
2256
2257         * python/py-type.c (convert_field): Use new_reference.  Return
2258         gdbpy_ref.
2259         (make_fielditem): Return gdbpy_ref.
2260         (typy_fields): Update.
2261         (typy_getitem): Update.
2262         (field_name): Return gdbpy_ref.  Use new_reference.
2263         (typy_iterator_iternext): Update.
2264
2265 2019-01-03  Tom Tromey  <tom@tromey.com>
2266
2267         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2268
2269 2019-01-03  Tom Tromey  <tom@tromey.com>
2270
2271         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2272         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2273         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2274         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2275         (pspy_set_type_printers): Likewise.
2276         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2277         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2278         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2279         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2280         (objfpy_set_type_printers): Likewise.
2281
2282 2019-01-03  Tom Tromey  <tom@tromey.com>
2283
2284         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2285         (gdbpy_print_stack): Use gdbpy_err_fetch.
2286         * python/python-internal.h (class gdbpy_err_fetch): New class.
2287         (class gdbpy_enter) <m_error_type, m_error_value,
2288         m_error_traceback>: Remove.
2289         <m_error>: New member.
2290         (gdbpy_exception_to_string): Don't declare.
2291         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2292         * python/py-value.c (convert_value_from_python): Use
2293         gdbpy_err_fetch.
2294         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2295         gdbpy_exception_to_string.
2296         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2297         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2298         gdbpy_err_fetch.
2299
2300 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * linux-nat.c (delete_lwp_cleanup): Delete.
2303         (struct lwp_deleter): New struct.
2304         (lwp_info_up): New typedef.
2305         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2306         lwp_info_up.
2307
2308 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * linux-fork.c (class scoped_switch_fork_info): New class.
2311         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2312
2313 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * valops.c (find_overload_match): Remove use of null_cleanup, and
2316         calls to do_cleanups.
2317
2318 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2319
2320         * compile/compile-cplus-types.c
2321         (compile_cplus_instance::decl_name): Handle changes to
2322         cp_func_name.
2323         * cp-support.c (cp_func_name): Update header comment, update
2324         return type.
2325         * cp-support.h (cp_func_name): Update return type in declaration.
2326         * valops.c (find_overload_match): Move temp_func local to top
2327         level of function and change its type.  Use temp_func to hold and
2328         delete temporary string obtained from cp_func_name.
2329
2330 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2331
2332         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2333         gdb::char_vector, remove cleanup, and update uses of `msg`.
2334
2335 2019-01-03  Jim Wilson  <jimw@sifive.com>
2336
2337         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2338
2339 2019-01-02  Tom Tromey  <tom@tromey.com>
2340
2341         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2342         (tdesc_parse_xml): Remove cleanups.
2343         * target-descriptions.h (make_cleanup_free_target_description):
2344         Don't declare.
2345         (target_desc_deleter): New struct.
2346         (target_desc_up): New typedef.
2347         * target-descriptions.c (target_desc_deleter::operator()): Rename
2348         from free_target_description.
2349         (make_cleanup_free_target_description): Remove.
2350
2351 2019-01-02  Tom Tromey  <tom@tromey.com>
2352
2353         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2354         constructor, destructor.
2355         (linespec_parser): Remove typedef.
2356         (~linespec_parser): Rename from linespec_parser_delete.
2357         (linespec_lex_to_end, linespec_complete_label)
2358         (linespec_complete): Update.
2359         (decode_line_full): Remove cleanups.
2360         (decode_line_1): Update.
2361
2362 2019-01-02  Tom Tromey  <tom@tromey.com>
2363
2364         * python/python-internal.h (inferior_to_inferior_object): Change
2365         return type.
2366         * python/py-exitedevent.c (create_exited_event_object): Update.
2367         * python/py-inferior.c (inferior_to_inferior_object): Return
2368         gdbpy_ref.
2369         (python_new_inferior, python_inferior_deleted)
2370         (thread_to_thread_object, delete_thread_object)
2371         (build_inferior_list, gdbpy_selected_inferior): Update.
2372         * python/py-infthread.c (create_thread_object): Update.  Also fail
2373         if inferior_to_inferior_object fails.
2374
2375 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2376
2377         * inferior.h (class inferior) <displaced_step_state>: New field.
2378         * infrun.h (struct displaced_step_state): Move here from
2379         infrun.c.  Initialize fields, add constructor.
2380         <inf>: Remove field.
2381         <reset>: New method.
2382         * infrun.c (struct displaced_step_inferior_state): Move to
2383         infrun.h.
2384         (displaced_step_inferior_states): Remove.
2385         (get_displaced_stepping_state): Adust.
2386         (displaced_step_in_progress_any_inferior): Adjust.
2387         (displaced_step_in_progress_thread): Adjust.
2388         (displaced_step_in_progress): Adjust.
2389         (add_displaced_stepping_state): Remove.
2390         (get_displaced_step_closure_by_addr): Adjust.
2391         (remove_displaced_stepping_state): Remove.
2392         (infrun_inferior_exit): Call displaced_step_state.reset.
2393         (use_displaced_stepping): Don't check for NULL.
2394         (displaced_step_prepare_throw): Call
2395         get_displaced_stepping_state.
2396         (displaced_step_fixup): Don't check for NULL.
2397         (prepare_for_detach): Don't check for NULL.
2398
2399 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2400
2401         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2402          in case of call that did not complete.
2403
2404 2019-01-02  Andrey Utkin  <autkin@undo.io>
2405
2406         * symfile.c (find_separate_debug_file): Fix search of debug files for
2407         remote debuggee.
2408
2409 2019-01-02  Tom Tromey  <tom@tromey.com>
2410
2411         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2412         indentation.
2413         * python/py-frame.c (frapy_older): Remove cast.
2414         (frapy_newer): Likewise.
2415         * python/py-breakpoint.c (local_setattro): Remove cast.
2416         * python/py-arch.c (archpy_name): Remove local variable.
2417         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2418
2419 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2420
2421         * unittests/basic_string_view/element_access/char/empty.cc:
2422         Fix year range in copyright header.
2423
2424 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2425
2426         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2427         Delete.
2428         <operator==>: Update with for removed field.
2429         <hash>: Likewise.
2430         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2431         <isa_features>: ...this.
2432         <abi_features>: New field.
2433         (riscv_isa_flen): Update comment.
2434         (riscv_abi_xlen): New declaration.
2435         (riscv_abi_flen): New declaration.
2436         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2437         isa_features.
2438         (riscv_abi_xlen): New function.
2439         (riscv_isa_flen): Update to get answer from isa_features.
2440         (riscv_abi_flen): New function.
2441         (riscv_has_fp_abi): Update to get answer from abi_features.
2442         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2443         xlen and flen.
2444         (riscv_call_info) <xlen, flen>: Update comment.
2445         (riscv_call_arg_struct): Remove invalid assertions
2446         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2447         is removed.
2448         (riscv_gdbarch_init): Gather isa features and abi features
2449         separately, ensure both match on the gdbarch when reusing an old
2450         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2451         a target with 64-bit float hardware.
2452
2453 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2454
2455         * source.c (search_command_helper): Stop reverse search
2456         when line 1 has been searched.
2457
2458 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2459
2460         * record-full.c (record_full_base_target::close): Rewrite
2461         record_full_core_buf_list free logic.
2462
2463 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2464
2465         * break-catch-syscall.c (print_one_catch_syscall): xfree
2466         the last text.
2467
2468 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2469
2470         * top.c (print_gdb_version): Update Copyright year in version
2471         message.
2472
2473 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2474
2475         Update copyright year range in all GDB files.
2476
2477 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2478
2479         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2480
2481 For older changes see ChangeLog-2018.
2482 \f
2483 Local Variables:
2484 mode: change-log
2485 left-margin: 8
2486 fill-column: 74
2487 version-control: never
2488 coding: utf-8
2489 End:
2490