Make null_ptid and minus_one_ptid "const"
[external/binutils.git] / gdb / ChangeLog
1 2019-03-12  Tom Tromey  <tromey@adacore.com>
2
3         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5
6 2019-03-12  Tom Tromey  <tromey@adacore.com>
7
8         * linux-nat.c (iterate_over_lwps): Update.
9         (stop_callback): Remove parameter.
10         (stop_wait_callback, detach_callback, resume_set_callback)
11         (select_singlestep_lwp_callback, set_ignore_sigint)
12         (status_callback, resumed_callback, resume_clear_callback)
13         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14         data parameter.
15         (linux_nat_target::detach, linux_nat_target::resume)
16         (linux_stop_and_wait_all_lwps, select_event_lwp)
17         (linux_nat_filter_event, linux_nat_wait_1)
18         (linux_nat_target::kill, linux_nat_target::stop)
19         (linux_nat_target::stop): Update.
20         (linux_nat_resume_callback): Change type.
21         (resume_stopped_resumed_lwps, count_events_callback)
22         (select_event_lwp_callback): Likewise.
23         (linux_stop_lwp, linux_nat_stop_lwp): Update.
24         * arm-linux-nat.c (struct update_registers_data): Remove.
25         (update_registers_callback): Change type.
26         (arm_linux_insert_hw_breakpoint1): Update.
27         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
28         parameter.
29         (x86_linux_dr_set_addr): Update.
30         (x86_linux_dr_set_control): Update.
31         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
32         (iterate_over_lwps): Use gdb::function_view.
33         * nat/aarch64-linux-hw-point.c (struct
34         aarch64_dr_update_callback_param): Remove.
35         (debug_reg_change_callback): Change type.
36         (aarch64_notify_debug_reg_change): Update.
37         * s390-linux-nat.c (s390_refresh_per_info): Update.
38
39 2019-03-11  Tom Tromey  <tromey@adacore.com>
40
41         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
42         redundant assignment to "this_cu".
43
44 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
45
46         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
47
48 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
49
50         * gdbtypes.c (rank_one_type_parm_set): New function extracted
51         from...
52         (rank_one_type): ... this.
53
54 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
55
56         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
57         from...
58         (rank_one_type): ... this.
59
60 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
61
62         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
63         from...
64         (rank_one_type): ... this.
65
66 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
67
68         * gdbtypes.c (rank_one_type_parm_float): New function extracted
69         from...
70         (rank_one_type): ... this.
71
72 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
73
74         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
75         from...
76         (rank_one_type): ... this.
77
78 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
79
80         * gdbtypes.c (rank_one_type_parm_range): New function extracted
81         from...
82         (rank_one_type): ... this.
83
84 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
85
86         * gdbtypes.c (rank_one_type_parm_char): New function extracted
87         from...
88         (rank_one_type): ... this.
89
90 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
91
92         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
93         from...
94         (rank_one_type): ... this.
95
96 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
97
98         * gdbtypes.c (rank_one_type_parm_int): New function extracted
99         from...
100         (rank_one_type): ... this.
101
102 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
103
104         * gdbtypes.c (rank_one_type_parm_func): New function extracted
105         from...
106         (rank_one_type): ... this.
107
108 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
109
110         * gdbtypes.c (rank_one_type_parm_array): New function extracted
111         from...
112         (rank_one_type): ... this.
113
114 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
115
116         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
117         from...
118         (rank_one_type): ... this.
119
120 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
121
122         * inferior.c (initialize_inferiors): Ensure 'help set/show print
123         inferior-events' shows the example events.
124
125 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
126
127         Support styling on native MS-Windows console
128
129         PR/24315
130         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
131         on MS-Windows if $TERM is not defined.
132
133         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
134
135         * posix-hdep.c (gdb_console_fputs):
136         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
137         functions.
138         * ui-file.h (gdb_console_fputs): Add prototype.
139
140         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
141         back to fputs only if the former returns zero.
142
143 2019-03-07  Tom Tromey  <tom@tromey.com>
144
145         * symmisc.c (print_symbol_bcache_statistics): Update.
146         (print_objfile_statistics): Update.
147         * symfile.c (allocate_symtab): Update.
148         * stabsread.c: Don't include bcache.h.
149         * psymtab.h (struct psymbol_bcache): Don't declare.
150         (class psymtab_storage) <psymbol_cache>: Now a bcache.
151         (psymbol_bcache_init, psymbol_bcache_free)
152         (psymbol_bcache_get_bcache): Don't declare.
153         * psymtab.c (struct psymbol_bcache): Remove.
154         (psymtab_storage::psymtab_storage): Update.
155         (psymtab_storage::~psymtab_storage): Update.
156         (psymbol_bcache_init, psymbol_bcache_free)
157         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
158         (add_psymbol_to_bcache): Update.
159         (allocate_psymtab): Update.
160         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
161         macro_cache>: No longer pointers.
162         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
163         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
164         * macrotab.c (macro_bcache): Update.
165         * macroexp.c: Don't include bcache.h.
166         * gdbtypes.c (check_types_worklist): Update.
167         (types_deeply_equal): Remove TRY/CATCH.  Update.
168         * elfread.c (elf_symtab_read): Update.
169         * dwarf2read.c: Don't include bcache.h.
170         * buildsym.c (buildsym_compunit::get_macro_table): Update.
171         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
172         (print_bcache_statistics, bcache_memory_used): Don't declare.
173         (struct bcache): Move from bcache.c.  Add constructor, destructor,
174         methods.  Rename all data members.
175         * bcache.c (struct bcache): Move to bcache.h.
176         (bcache::expand_hash_table): Rename from expand_hash_table.
177         (bcache): Remove.
178         (bcache::insert): Rename from bcache_full.
179         (bcache::compare): Rename from bcache_compare.
180         (bcache_xmalloc): Remove.
181         (bcache::~bcache): Rename from bcache_xfree.
182         (bcache::print_statistics): Rename from print_bcache_statistics.
183         (bcache::memory_used): Rename from bcache_memory_used.
184
185 2019-03-07  Pedro Alves  <palves@redhat.com>
186
187         * infrun.c (normal_stop): Also check for
188         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
189
190 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
191
192         * f-lang.c (value_from_host_double): Moved to...
193         * value.c (value_from_host_double): ...here.
194         * value.h (value_from_host_double): Declare.
195         * guile/scm-math.c (vlscm_convert_typed_number): Use
196         value_from_host_double.
197         (vlscm_convert_number): Likewise.
198         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
199         * python/py-value.c (convert_value_from_python): Likewise.
200
201 2019-03-06  Tom Tromey  <tom@tromey.com>
202
203         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
204
205 2019-03-06  Tom Tromey  <tom@tromey.com>
206
207         * utils.h (free_current_contents): Don't declare.
208         * utils.c (free_current_contents): Remove.
209
210 2019-03-06  Tom Tromey  <tom@tromey.com>
211
212         * top.c (quit_force): Update.
213         * main.c (captured_command_loop): Update.
214         * common/new-op.c (operator new): Update.
215         * common/common-exceptions.c (struct catcher)
216         <save_cleanup_chain>: Remove member.
217         (exceptions_state_mc_init): Update.
218         (exception_try_scope_entry): Return nullptr.
219         (exception_try_scope_exit, exception_rethrow)
220         (throw_exception_sjlj, throw_exception_cxx): Update.
221         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
222         (all_cleanups, do_cleanups, discard_cleanups)
223         (discard_final_cleanups, save_cleanups, save_final_cleanups)
224         (restore_cleanups, restore_final_cleanups): Don't declare.
225         (do_final_cleanups): Remove parameter.
226         * common/cleanups.c (cleanup_chain, make_cleanup)
227         (make_cleanup_dtor, all_cleanups, do_cleanups)
228         (discard_my_cleanups, discard_cleanups)
229         (discard_final_cleanups, save_my_cleanups, save_cleanups)
230         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
231         (null_cleanup): Remove.
232         (do_final_cleanups): Remove parameter.
233
234 2019-03-06  Tom Tromey  <tom@tromey.com>
235
236         * remote.c (remote_target::remote_parse_stop_reply): Use
237         unique_xmalloc_ptr.
238
239 2019-03-06  Tom Tromey  <tom@tromey.com>
240
241         * stabsread.c (struct stabs_field_info): Rename from field_info.
242         <list, fnlist>: Add initializers.
243         <obstack>: New member.
244         (read_member_functions, read_struct_fields, read_baseclasses):
245         Allocate on obstack.  Don't use cleanups.
246         (read_one_struct_field, read_member_functions, read_struct_fields)
247         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
248         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
249         (read_struct_type): Update.
250
251 2019-03-06  Tom Tromey  <tom@tromey.com>
252
253         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
254         * common/filestuff.h (make_cleanup_close): Don't declare.
255         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
256         Remove.
257
258 2019-03-06  Tom Tromey  <tom@tromey.com>
259
260         * solib-aix.c: Use make_scope_exit.
261
262 2019-03-06  Tom Tromey  <tom@tromey.com>
263
264         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
265         Use make_scope_exit.
266
267 2019-03-06  Tom Tromey  <tom@tromey.com>
268
269         * solib-svr4.c (disable_probes_interface): Remove parameter.
270         (svr4_handle_solib_event): Use make_scope_exit.
271
272 2019-03-06  Tom Tromey  <tom@tromey.com>
273
274         * remote.c (struct stop_reply_deleter): Remove.
275         (stop_reply_up): Update.
276         (struct stop_reply): Derive from notif_event.  Don't typedef.
277         <regcache>: Now a std::vector.
278         (stop_reply_xfree): Remove.
279         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
280         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
281         (remote_target::discard_pending_stop_replies): Use delete.
282         (remote_target::remote_parse_stop_reply): Update.
283         (remote_target::process_stop_reply): Update.
284         * remote-notif.h (struct notif_event): Add virtual destructor.
285         Remove "dtr" member.
286         (struct notif_client) <alloc_event>: Return a unique_ptr.
287         (notif_event_xfree): Don't declare.
288         (notif_event_up): New typedef.
289         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
290         (notif_event_xfree, do_notif_event_xfree): Remove.
291         (remote_notif_state_xfree): Update.
292
293 2019-03-06  Tom Tromey  <tom@tromey.com>
294
295         * infrun.c (displaced_step_clear_cleanup): Now a
296         forward_scope_exit type.
297         (displaced_step_prepare_throw): Update.
298         (displaced_step_fixup): Update.
299
300 2019-03-06  Tom Tromey  <tom@tromey.com>
301
302         * inferior.h (class inferior): Update comment.
303         * gdbthread.h (class thread_info): Update comment.
304
305 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
306             Tom Tromey  <tom@tromey.com>
307
308         * stabsread.h (struct stab_section_list): Remove.
309         (coffstab_build_psymtabs): Update.
310         * dbxread.c (symbuf_sections): Now a std::vector.
311         (sect_idx): New global.
312         (fill_symbuf): Update.
313         (coffstab_build_psymtabs): Change type of stabsects parameter.
314         Update.
315         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
316         std::vector.
317         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
318         (coff_locate_sections): Update.
319         (coff_symfile_read): Remove cleanups.  Update.
320         (init_stringtab): Add storage parameter.
321         (free_stringtab, free_stringtab_cleanup): Remove.
322         (init_lineno): Add storage parameter.
323         (free_linetab, free_linetab_cleanup): Remove.
324
325 2019-03-06  Pedro Alves  <palves@redhat.com>
326
327         * linux-fork.c (fork_info::clobber_regs): Delete.
328         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
329         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
330         comment.  Adjust.
331         (scoped_switch_fork_info::scoped_switch_fork_info)
332         (checkpoint_command, linux_fork_context): Adjust
333         fork_save_infrun_state calls.
334
335 2019-03-06  Pedro Alves  <palves@redhat.com>
336
337         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
338         (inf_has_multiple_threads): Return 'bool' and rewrite using
339         inferior_info::threads().
340
341 2019-03-06  Pedro Alves  <palves@redhat.com>
342
343         * linux-fork.c: Include <list>.
344         (fork_list): Now a std::list instance.
345         (fork_info): Add ctor, dtor, and in-class initialize all fields.
346         (forks_exist_p, find_last_fork): Adjust.
347         (new_fork): Delete.
348         (one_fork_p): New.
349         (add_fork): Adjust.
350         (free_fork): Delete, folded into fork_info::~fork_info().
351         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
352         Adjust.
353         (init_fork_list): Delete.
354         (linux_fork_killall, linux_fork_mourn_inferior)
355         (linux_fork_detach, info_checkpoints_command): Adjust.
356         (_initialize_linux_fork): No longer call init_fork_list.
357
358 2019-03-06  Pedro Alves  <palves@redhat.com>
359
360         * linux-fork.c (new_fork): New, split out of ...
361         (add_fork): ... this.  Return void.  Move "first fork" special
362         case from here, to ...
363         (checkpoint_command): ... here.
364         * linux-linux.h (add_fork): Return void.
365
366 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
367
368         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
369
370 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
371             Chris January  <chris.january@arm.com>
372             David Lecomber  <david.lecomber@arm.com>
373
374         * f-exp.y: New token, UNOP_INTRINSIC.
375         (exp): New pattern using UNOP_INTRINSIC token.
376         (f77_keywords): Add 'abs' keyword.
377         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
378         (value_from_host_double): New function.
379         (evaluate_subexp_f): Support UNOP_ABS.
380
381 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
382
383         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
384         types.
385
386 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
387
388         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
389         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
390         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
391
392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
393
394         * f-exp.y (convert_to_kind_type): Handle more type kinds.
395
396 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
397             Chris January  <chris.january@arm.com>
398
399         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
400         * f-exp.y: Define 'KIND' token.
401         (exp): New pattern for KIND expressions.
402         (ptype): Handle types with a kind extension.
403         (direct_abs_decl): Extend to spot kind extensions.
404         (f77_keywords): Add 'kind' to the list.
405         (push_kind_type): New function.
406         (convert_to_kind_type): New function.
407         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
408         * parse.c (operator_length_standard): Likewise.
409         * parser-defs.h (enum type_pieces): Add tp_kind.
410         * std-operator.def: Add UNOP_KIND.
411
412 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
413
414         * f-exp.y (f_parse): Set yydebug.
415
416 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
417
418         * f-lang.c (evaluate_subexp_f): New function.
419         (exp_descriptor_f): New global.
420         (f_language_defn): Use exp_descriptor_f instead of
421         exp_descriptor_standard.
422
423 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
424
425         * f-exp.y (struct token): Add comments.
426         (dot_ops): Remove uppercase versions and the end marker.
427         (f77_keywords): Likewise.
428         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
429         entries in the dot_ops array are case insensitive, and use
430         strncasecmp to compare strings.  Also some whitespace cleanup in
431         this area.  Similar for the f77_keywords array, except entries in
432         this list might be case sensitive.
433
434 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
435
436         * f-exp.y (struct f77_boolean_val): Add comments.
437         (boolean_values): Remove uppercase versions, and end marker.
438         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
439         and use strncasecmp to achieve case insensitivity.  Additionally,
440         perform whitespace cleanup around this code.
441
442 2019-03-06  Tom Tromey  <tromey@adacore.com>
443
444         * remote-sim.c (gdbsim_target_open): Use result of
445         gdb_argv::release.
446
447 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
448         Dirk Schubert  <dirk.schubert@arm.com>
449         Chris January  <chris.january@arm.com>
450
451         * eval.c (evaluate_subexp_standard): Call Fortran argument
452         wrapping logic.
453         * f-lang.c (struct value): A value which can be passed into a
454         Fortran function call.
455         (fortran_argument_convert): Wrap Fortran arguments in a pointer
456         where appropriate.
457         (struct type): Value ready for a Fortran function call.
458         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
459         is needed.
460         * f-lang.h (fortran_argument_convert): Declaration.
461         (fortran_preserve_arg_pointer): Declaration.
462         * infcall.c (value_arg_coerce): Call Fortran argument logic.
463
464 2019-03-05  Tom Tromey  <tromey@adacore.com>
465
466         * python/py-prettyprint.c (print_string_repr): Remove #if.
467         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
468
469 2019-03-05  Tom Tromey  <tromey@adacore.com>
470
471         * target.c (the_dummy_target): Move later.  Change type to
472         "dummy_target".
473         (initialize_targets): Don't initialize the_dummy_target.
474
475 2019-03-05  Tom Tromey  <tromey@adacore.com>
476
477         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
478         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
479
480 2019-03-05  Tom Tromey  <tromey@adacore.com>
481
482         * windows-nat.c (windows_nat_target::attach)
483         (windows_nat_target::detach): Don't call gdb_flush.
484         * valprint.c (generic_val_print, val_print, val_print_string):
485         Don't call gdb_flush.
486         * utils.c (defaulted_query): Don't call gdb_flush.
487         * typeprint.c (print_type_scalar): Don't call gdb_flush.
488         * target.c (target_announce_detach): Don't call gdb_flush.
489         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
490         * remote.c (extended_remote_target::attach): Don't call
491         gdb_flush.
492         * procfs.c (procfs_target::detach): Don't call gdb_flush.
493         * printcmd.c (do_examine): Don't call gdb_flush.
494         (info_display_command): Don't call gdb_flush.
495         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
496         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
497         * memattr.c (info_mem_command): Don't call gdb_flush.
498         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
499         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
500         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
501         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
502         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
503         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
504         (gnu_nat_target::detach): Don't call gdb_flush.
505         * f-valprint.c (f_val_print): Don't call gdb_flush.
506         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
507         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
508         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
509         gdb_flush.
510         * c-valprint.c (c_val_print): Don't call gdb_flush.
511         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
512
513 2019-03-05  Tom Tromey  <tromey@adacore.com>
514
515         * varobj.c (update_dynamic_varobj_children): Update.
516         (install_default_visualizer): Use reset, not release.
517         * value.c (set_internalvar): Update.
518         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
519         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
520         ATTRIBUTE_UNUSED_RESULT.
521
522 2019-03-05  Tom Tromey  <tromey@adacore.com>
523
524         * remote.c (class scoped_remote_fd) <release>: Add
525         ATTRIBUTE_UNUSED_RESULT.
526
527 2019-03-05  Tom Tromey  <tromey@adacore.com>
528
529         * macroexp.c (struct macro_buffer) <release>: Add
530         ATTRIBUTE_UNUSED_RESULT.
531
532 2019-03-05  Tom Tromey  <tromey@adacore.com>
533
534         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
535         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
536         ATTRIBUTE_UNUSED_RESULT.
537
538 2019-03-05  Tom Tromey  <tromey@adacore.com>
539
540         * common/scoped_fd.h (class scoped_fd) <release>: Add
541         ATTRIBUTE_UNUSED_RESULT.
542
543 2019-03-05  Tom Tromey  <tromey@adacore.com>
544
545         * parser-defs.h (struct parser_state) <release>: Add
546         ATTRIBUTE_UNUSED_RESULT.
547
548 2019-03-05  Tom Tromey  <tromey@adacore.com>
549
550         * utils.h (class gdb_argv) <release>: Add
551         ATTRIBUTE_UNUSED_RESULT.
552         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
553
554 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
555
556         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
557         for-loop range, to avoid compiler warnings.
558
559         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
560         avoid compiler warnings about unused variables.
561
562         * NEWS: Mention end of support for native debugging on MS-Windows
563         before XP.
564
565         PR gdb/24292
566         * common/netstuff.c:
567         * gdbserver/gdbreplay.c
568         * gdbserver/remote-utils.c:
569         * ser-tcp.c:
570         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
571         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
572         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
573         'getaddrinfo' and 'freeaddrinfo' were not available before
574         Windows XP, and mingw.org's MinGW headers by default define
575         _WIN32_WINNT to 0x500.
576
577 2019-03-01  Gary Benson <gbenson@redhat.com>
578
579         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
580
581 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
582             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
583
584         PR gdb/8527
585         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
586         set_sigint_trap, clear_sigint_trap.
587
588 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
589
590         * target.c (target_detach): Clear the regcache and the
591         frame cache.
592
593 2019-02-27  Pedro Alves  <palves@redhat.com>
594
595         * utils.c (set_screen_size): When we cap the height/width sizes,
596         tweak the corresponding command variable to show "unlimited":
597
598 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
599             Pedro Alves  <palves@redhat.com>
600
601         * utils.c (set_screen_size): Reduce "infinite" rows and columns
602         before calling rl_set_screen_size.
603
604 2019-02-27  Tom Tromey  <tromey@adacore.com>
605
606         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
607         define.
608         * python/py-value.c: Remove Python 2.4 workaround.
609         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
610         workaround.
611         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
612         Python 2.4 workaround.
613         * python/python-internal.h: Remove Python 2.4 comment.
614         (Py_ssize_t): Don't define.
615         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
616         (gdb_Py_DECREF): Remove Python 2.4 workaround.
617         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
618         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
619         * python/python.c (do_start_initialization): Remove Python 2.4
620         workaround.
621         * python/py-prettyprint.c (class dummy_python_frame): Remove.
622         (print_children): Remove Python 2.4 workaround.
623         * python/py-inferior.c (buffer_procs): Remove Python 2.4
624         workaround.
625         (CHARBUFFERPROC_NAME): Remove.
626         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
627         Python 2.4 workaround.
628
629 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
630
631         * NEWS: Note minimum Python version.
632
633 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
634
635         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
636         code from these functions.  Remove corresponding ifdefs.  Use
637         Py_buffer_up instead of explicit calls to PyBuffer_Release.
638         Remove gotos and target of gotos.
639         (infpy_search_memory): Likewise.
640
641 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
642
643         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
644         (hppa_gdbarch_init): Don't register deleted functions with
645         gdbarch.
646
647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
648
649         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
650         (h8300_unwind_sp): Delete.
651         (h8300_dummy_id): Delete.
652         (h8300_gdbarch_init): Don't register deleted functions with
653         gdbarch.
654
655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
656
657         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
658         (ft32_unwind_pc): Delete.
659         (ft32_unwind_sp): Delete.
660         (ft32_gdbarch_init): Don't register deleted functions with
661         gdbarch.
662
663 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
664
665         * gdb/frv-tdep.c (frv_dummy_id): Delete.
666         (frv_unwind_pc): Delete.
667         (frv_unwind_sp): Delete.
668         (frv_gdbarch_init): Don't register deleted functions with
669         gdbarch.
670
671 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
672
673         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
674         (riscv_unwind_pc): Delete.
675         (riscv_unwind_sp): Delete.
676         (riscv_gdbarch_init): Don't register deleted functions with
677         gdbarch.
678
679 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
680
681         * gdb/csky-tdep.c (csky_dummy_id): Delete.
682         (csky_unwind_pc): Delete.
683         (csky_unwind_sp): Delete.
684         (csky_gdbarch_init): Don't register deleted functions with
685         gdbarch.
686
687 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
688
689         * gdb/cris-tdep.c (cris_dummy_id): Delete.
690         (cris_unwind_pc): Delete.
691         (cris_unwind_sp): Delete.
692         (cris_gdbarch_init): Don't register deleted functions with
693         gdbarch.
694
695 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
696
697         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
698         (bfin_unwind_pc): Delete.
699         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
700
701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
702
703         * gdb/arm-tdep.c (arm_dummy_id): Delete.
704         (arm_unwind_pc): Delete.
705         (arm_unwind_sp): Delete.
706         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
707
708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
709
710         * gdb/arc-tdep.c (arc_dummy_id): Delete.
711         (arc_unwind_pc): Delete.
712         (arc_unwind_sp): Delete.
713         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
714
715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
716
717         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
718         (alpha_unwind_pc): Delete.
719         (alpha_gdbarch_init): Don't register deleted functions with
720         gdbarch.
721
722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
723
724         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
725         (aarch64_unwind_pc): Delete.
726         (aarch64_unwind_sp): Delete.
727         (aarch64_gdbarch_init): Don't register deleted functions with
728         gdbarch.
729
730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
731
732         * gdbtypes.c (type_align): Don't consider static members when
733         computing structure alignment.
734
735 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
736
737         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
738         return 0 for other types.
739         * arch-utils.c (default_type_align): Always return 0.
740         * gdbarch.h: Regenerate.
741         * gdbarch.sh (type_align): Extend comment.
742         * gdbtypes.c (type_align): Add additional comments, always call
743         gdbarch_type_align before applying the default rules.
744         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
745         generic code will then apply a suitable default.
746         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
747         types, return 0 for other types.
748
749 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
750
751         * NEWS: Create a new section for the next release branch.
752         Rename the section of the current branch, now that it has
753         been cut.
754
755 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
756
757         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
758         * version.in: Bump version to 8.3.50.DATE-git.
759
760 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
761
762         * aix-thread.c (ptid_cmp): Remove unused variable.
763         (get_signaled_thread): Likewise.
764         (store_regs_user_thread): Likewise.
765         (store_regs_kernel_thread): Likewise.
766         (fetch_regs_kernel_thread): Remove shadowed variable.
767
768 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
769
770         * features/riscv/32bit-cpu.xml: Add register numbers.
771         * features/riscv/32bit-fpu.c: Regenerate.
772         * features/riscv/32bit-fpu.xml: Add register numbers.
773         * features/riscv/64bit-cpu.xml: Add register numbers.
774         * features/riscv/64bit-fpu.c: Regenerate.
775         * features/riscv/64bit-fpu.xml: Add register numbers.
776
777 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
778
779         * NEWS: Mention two argument form of gdb.Value constructor.
780         * python/py-value.c (convert_buffer_and_type_to_value): New
781         function.
782         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
783         Add support for handling an optional second argument.  Call
784         convert_buffer_and_type_to_value as appropriate.
785         * python/python-internal.h (Py_buffer_deleter): New struct.
786         (Py_buffer_up): New typedef.
787
788 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
789
790         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
791         instead of releasing ownership.
792
793 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
794
795         * dwarf2read.c (open_and_init_dwp_file): Call
796         elf_numsections instead of bfd_count_sections to initialize
797         dwp_file->num_sections.
798
799 2019-02-25  Tom Tromey  <tromey@adacore.com>
800
801         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
802
803 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
804
805         * gcore.in: Add '--readnever' option when invoking GDB.
806
807 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
808
809         * MAINTAINERS: Update my email address.
810
811 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
812
813         * build-id.c (build_id_to_debug_bfd_1): New function.
814         (build_id_to_debug_bfd): Look for separate debug file in
815         sysroot.
816
817 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
818
819         * gdbarch.sh: Update the copyright year range that is placed into
820         generated files.
821
822 2019-02-22  Keith Seitz  <keiths@redhat.com>
823
824         PR symtab/23853
825         * linespec.c (create_sals_line_offset): Search for the default
826         symtab's filename instead of its fullname.
827
828 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
829
830         * NEWS: Update style defaults.
831
832 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
833
834         * main.c (captured_main_1): Disable styling in batch mode.
835
836 2019-02-20  Tom Tromey  <tom@tromey.com>
837
838         * symtab.c (symtab_symbol_info): Fix typos.
839
840 2019-02-20  Tom Tromey  <tromey@adacore.com>
841
842         * findcmd.c (_initialize_mem_search): Use upper case for
843         metasyntactic variables.
844
845 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
846
847         * aarch64-tdep.c (aarch64_add_reggroups): New function.
848         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
849
850 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
851
852         * top.h (source_file_name): Change to std::string.
853         * top.c (source_file_name): Likewise.
854         (command_line_input): Adjust.
855         * cli/cli-script.c (script_from_file): Adjust.
856
857 2019-02-19  Tom Tromey  <tromey@adacore.com>
858
859         * ravenscar-thread.c
860         (ravenscar_thread_target::update_thread_list): Don't call
861         ada_build_task_list.
862         * ada-lang.h (ada_build_task_list): Don't declare.
863         * ada-tasks.c (struct ada_tasks_inferior_data)
864         <task_list_valid_p>: Now bool.
865         (read_known_tasks, ada_task_list_changed)
866         (ada_tasks_invalidate_inferior_data): Update.
867         (read_known_tasks_array): Return bool.
868         (read_known_tasks_list): Likewise.
869         (read_known_tasks): Return void.
870         (ada_build_task_list): Now static.
871
872 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
873
874         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
875         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
876
877 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
878
879         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
880         variant for ada_tasks_pspace_data_handle and
881         ada_tasks_inferior_data_handle.
882         (ada_tasks_pspace_data_cleanup): New function.
883         (ada_tasks_inferior_data_cleanup): New function.
884
885 2019-02-17  Tom Tromey  <tom@tromey.com>
886
887         * macrotab.h (macro_source_fullname): Return a std::string.
888         * macrotab.c (macro_include, check_for_redefinition)
889         (macro_undef, macro_lookup_definition, foreach_macro)
890         (foreach_macro_in_scope): Update.
891         (macro_source_fullname): Return a std::string.
892         * macrocmd.c (show_pp_source_pos): Update.
893
894 2019-02-17  Tom Tromey  <tom@tromey.com>
895
896         * macrocmd.c (show_pp_source_pos): Style the file names.
897
898 2019-02-17  Tom Tromey  <tom@tromey.com>
899
900         PR tui/24197:
901         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
902
903 2019-02-17  Tom Tromey  <tom@tromey.com>
904
905         * ada-lang.c (user_select_syms): Use filtered printing.
906         * utils.c (wrap_style): New global.
907         (desired_style): Remove.
908         (emit_style_escape): Add stream parameter.
909         (set_output_style, reset_terminal_style, prompt_for_continue):
910         Update.
911         (flush_wrap_buffer): Only flush gdb_stdout.
912         (wrap_here): Set wrap_style.
913         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
914         treat escape sequences as a character.  Change when wrap buffer is
915         flushed.
916         (fputs_styled): Do not set the output style when the default is
917         requested.
918         * ui-style.h (struct ui_file_style) <is_default>: New method.
919         * source.c (print_source_lines_base): Emit escape sequences in one
920         piece.
921
922 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
923
924         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
925         integers and enumeration types.
926
927 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
928
929         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
930         instead of lookup_symbol_in_language
931         (do_exact_match): New function.
932         (ada_get_symbol_name_matcher): Return do_exact_match when
933         doing a verbatim match.
934
935 2019-02-15  Tom Tromey  <tromey@adacore.com>
936
937         * ravenscar-thread.c (ravenscar_thread_target::resume)
938         (ravenscar_thread_target::wait): Special case wildcard requests.
939
940 2019-02-15  Tom Tromey  <tromey@adacore.com>
941
942         * ravenscar-thread.c (base_ptid): Remove.
943         (struct ravenscar_thread_target) <close>: New method.
944         <m_base_ptid>: New member.
945         <update_inferior_ptid, active_task, task_is_currently_active,
946         runtime_initialized>: Declare methods.
947         <ravenscar_thread_target>: Add constructor.
948         (ravenscar_thread_target::task_is_currently_active)
949         (ravenscar_thread_target::update_inferior_ptid)
950         (ravenscar_runtime_initialized): Rename.  Now methods.
951         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
952         (ravenscar_thread_target::update_thread_list): Update.
953         (ravenscar_thread_target::active_task): Now method.
954         (ravenscar_thread_target::store_registers)
955         (ravenscar_thread_target::prepare_to_store)
956         (ravenscar_thread_target::prepare_to_store)
957         (ravenscar_thread_target::mourn_inferior): Update.
958         (ravenscar_inferior_created): Use "new" to create target.
959         (ravenscar_thread_target::get_ada_task_ptid): Update.
960         (_initialize_ravenscar): Don't initialize base_ptid.
961         (ravenscar_ops): Remove global.
962
963 2019-02-15  Tom Tromey  <tromey@adacore.com>
964
965         * target.h (push_target): Declare new overload.
966         * target.c (push_target): New overload, taking an rvalue reference.
967         * remote.c (remote_target::open_1): Use push_target overload.
968         * corelow.c (core_target_open): Use push_target overload.
969
970 2019-02-15  Tom Tromey  <tromey@adacore.com>
971
972         * ravenscar-thread.c (is_ravenscar_task)
973         (ravenscar_task_is_currently_active): Return bool.
974         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
975         (_initialize_ravenscar): Remove "(void)".
976         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
977         Return bool.
978
979 2019-02-15  Tom Tromey  <tromey@adacore.com>
980
981         * ravenscar-thread.c (ravenscar_runtime_initializer)
982         (has_ravenscar_runtime, get_running_thread_id)
983         (ravenscar_thread_target::resume): Fix indentation.
984
985 2019-02-15  Tom Tromey  <tromey@adacore.com>
986
987         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
988         from ravenscar_arch_ops.
989         (sparc_ravenscar_ops::fetch_registers)
990         (sparc_ravenscar_ops::store_registers): Now methods.
991         (sparc_ravenscar_prepare_to_store): Remove.
992         (sparc_ravenscar_ops): Redefine.
993         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
994         methods and destructor.  Remove members.
995         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
996         (ravenscar_thread_target::store_registers)
997         (ravenscar_thread_target::prepare_to_store): Update.
998         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
999         Remove.
1000         (struct ppc_ravenscar_powerpc_ops): Derive from
1001         ravenscar_arch_ops.
1002         (ppc_ravenscar_powerpc_ops::fetch_registers)
1003         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1004         (ppc_ravenscar_powerpc_ops): Redefine.
1005         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1006         (ppc_ravenscar_e500_ops::fetch_registers)
1007         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1008         (ppc_ravenscar_e500_ops): Redefine.
1009         * aarch64-ravenscar-thread.c
1010         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1011         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1012         (aarch64_ravenscar_fetch_registers)
1013         (aarch64_ravenscar_store_registers): Now methods.
1014         (aarch64_ravenscar_ops): Redefine.
1015
1016 2019-02-15  Tom Tromey  <tromey@adacore.com>
1017
1018         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1019         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1020         (ravenscar_thread_target::stopped_by_watchpoint)
1021         (ravenscar_thread_target::stopped_data_address)
1022         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1023
1024 2019-02-15  Tom Tromey  <tromey@adacore.com>
1025
1026         * ravenscar-thread.c: Fix some typos.
1027
1028 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1029             Tom Tromey  <tromey@adacore.com>
1030
1031         * ada-lang.c (ada_exception_sal): Change addr_string to a
1032         std::string.
1033         (create_ada_exception_catchpoint): Update.
1034
1035 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1036             Tom Tromey  <tromey@adacore.com>
1037
1038         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1039         (bp_location_ops): Remove.
1040         (base_breakpoint_allocate_location): Update.
1041         (free_bp_location): Update.
1042         * ada-lang.c (class ada_catchpoint_location)
1043         <ada_catchpoint_location>: Remove ops parameter.
1044         (ada_catchpoint_location_dtor): Remove.
1045         (ada_catchpoint_location_ops): Remove.
1046         (allocate_location_exception): Update.
1047         * breakpoint.h (struct bp_location_ops): Remove.
1048         (class bp_location) <bp_location>: Remove bp_location_ops
1049         parameter.
1050         <~bp_location>: Add destructor.
1051         <ops>: Remove.
1052
1053 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1054             Pedro Alves  <palves@redhat.com>
1055
1056         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1057         'PATH_MAX'.
1058
1059 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1060             Samuel Thibault  <samuel.thibault@gnu.org>
1061             Thomas Schwinge  <thomas@codesourcery.com>
1062
1063         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1064         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1065
1066 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1067
1068         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1069         (check_empty): Use "const char *".
1070
1071         * gnu-nat.c (gnu_nat_target::detach): Instead of
1072         'detach_inferior (pid)' call
1073         'detach_inferior (find_inferior_pid (pid))'.
1074
1075         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1076         'nat/fork-inferior.o'.
1077         * gnu-nat.c: #include "nat/fork-inferior.h".
1078
1079         * gnu-nat.c (gnu_nat_target::detach): Instead of
1080         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1081         * gnu-nat.h: #include "inf-child.h".
1082         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1083         'i386_gnu_nat_target::fetch_registers'.
1084         (gnu_store_registers): Rename/move to
1085         'i386_gnu_nat_target::store_registers'.
1086
1087         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1088         * gnu-nat.h (mach_thread_info): New function.
1089         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1090
1091         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1092
1093 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1094
1095         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1096
1097 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1098
1099         * windows-nat.c (windows_add_thread): Add new parameter
1100         "main_thread_p" with default value set to false.  Update
1101         function documentation as well as all callers.
1102         (windows_delete_thread): Likewise.
1103         (fake_create_process): Update call to windows_add_thread.
1104         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1105         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1106         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1107         call to windows_delete_thread.
1108
1109 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1110
1111         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1112
1113 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1114
1115         * symfile.c (find_separate_debug_file): Use canonical path of
1116         sysroot with child_path instead of gdb_sysroot if it is valid.
1117
1118 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1119
1120         * symfile.c (find_separate_debug_file): Use child_path to
1121         determine if an object file is under a sysroot.
1122
1123 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1124
1125         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1126         unittests/child-path-selftests.c.
1127         * common/pathstuff.c (child_path): New function.
1128         * common/pathstuff.h (child_path): New prototype.
1129         * unittests/child-path-selftests.c: New file.
1130
1131 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1132
1133         * symfile.c (find_separate_debug_file): Look for separate debug
1134         files in debug directories under the sysroot.
1135
1136 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1137
1138         * symtab.h (struct minimal_symbol data_p): New const method.
1139         (struct minimal_symbol text_p): Likewise.
1140         * symtab.c (output_source_filename): Use file name style
1141         to print file name.
1142         (print_symbol_info): Likewise.
1143         (print_msymbol_info): Use address style to print addresses.
1144         Use function name style to print executable text symbols.
1145         (expand_symtab_containing_pc): Use data_p.
1146         (find_pc_sect_compunit_symtab): Likewise.
1147
1148 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1149
1150         * breakpoint.c (describe_other_breakpoints): Use address style
1151         to print addresses.
1152         (say_where): Likewise.
1153
1154 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1155
1156         * ada-typeprint.c (print_func_type): Print function name
1157         style to print function name.
1158         * c-typeprint.c (c_print_type_1): Likewise.
1159
1160 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1161
1162         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1163         for execve.
1164
1165 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1166
1167         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1168         type_stack.
1169
1170 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1171
1172         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1173         TYPE_CODE_REF types.
1174
1175 2019-02-08  Jim Wilson  <jimw@sifive.com>
1176
1177         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1178         (riscv_linux_fregset): New.
1179         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1180
1181 2019-02-07  Tom Tromey  <tom@tromey.com>
1182
1183         * thread.c (thread_cancel_execution_command): Update.
1184         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1185         methods.
1186         (struct thread_fsm_ops): Remove.
1187         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1188         (thread_fsm_should_stop, thread_fsm_return_value)
1189         (thread_fsm_set_finished, thread_fsm_finished_p)
1190         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1191         Don't declare.
1192         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1193         * infrun.c (clear_proceed_status_thread)
1194         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1195         (print_stop_event): Update.
1196         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1197         Add constructor.
1198         (step_command_fsm_ops): Remove.
1199         (new_step_command_fsm): Remove.
1200         (step_1): Update.
1201         (step_command_fsm::should_stop): Rename from
1202         step_command_fsm_should_stop.
1203         (step_command_fsm::clean_up): Rename from
1204         step_command_fsm_clean_up.
1205         (step_command_fsm::do_async_reply_reason): Rename from
1206         step_command_fsm_async_reply_reason.
1207         (struct until_next_fsm): Inherit from thread_fsm.  Add
1208         constructor.
1209         (until_next_fsm_ops): Remove.
1210         (new_until_next_fsm): Remove.
1211         (until_next_fsm::should_stop): Rename from
1212         until_next_fsm_should_stop.
1213         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1214         (until_next_fsm::do_async_reply_reason): Rename from
1215         until_next_fsm_async_reply_reason.
1216         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1217         constructor.  Change type of breakpoint.
1218         (finish_command_fsm_ops): Remove.
1219         (new_finish_command_fsm): Remove.
1220         (finish_command_fsm::should_stop): Rename from
1221         finish_command_fsm_should_stop.
1222         (finish_command_fsm::clean_up): Rename from
1223         finish_command_fsm_clean_up.
1224         (finish_command_fsm::return_value): Rename from
1225         finish_command_fsm_return_value.
1226         (finish_command_fsm::do_async_reply_reason): Rename from
1227         finish_command_fsm_async_reply_reason.
1228         (finish_command): Update.
1229         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1230         Add constructor.
1231         (call_thread_fsm_ops): Remove.
1232         (call_thread_fsm::call_thread_fsm): Rename from
1233         new_call_thread_fsm.
1234         (call_thread_fsm::should_stop): Rename from
1235         call_thread_fsm_should_stop.
1236         (call_thread_fsm::should_notify_stop): Rename from
1237         call_thread_fsm_should_notify_stop.
1238         (run_inferior_call, call_function_by_hand_dummy): Update.
1239         * cli/cli-interp.c (should_print_stop_to_console): Update.
1240         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1241         Add constructor.  Change type of location_breakpoint,
1242         caller_breakpoint.
1243         (until_break_fsm_ops): Remove.
1244         (new_until_break_fsm): Remove.
1245         (until_break_fsm::should_stop): Rename from
1246         until_break_fsm_should_stop.
1247         (until_break_fsm::clean_up): Rename from
1248         until_break_fsm_clean_up.
1249         (until_break_fsm::do_async_reply_reason): Rename from
1250         until_break_fsm_async_reply_reason.
1251         (until_break_command): Update.
1252         * thread-fsm.c: Remove.
1253         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1254
1255 2019-02-07  Tom Tromey  <tom@tromey.com>
1256
1257         * yy-remap.h: Add include guard.
1258         * xtensa-tdep.h: Add include guard.
1259         * xcoffread.h: Rename include guard.
1260         * varobj-iter.h: Add include guard.
1261         * tui/tui.h: Rename include guard.
1262         * tui/tui-winsource.h: Rename include guard.
1263         * tui/tui-wingeneral.h: Rename include guard.
1264         * tui/tui-windata.h: Rename include guard.
1265         * tui/tui-win.h: Rename include guard.
1266         * tui/tui-stack.h: Rename include guard.
1267         * tui/tui-source.h: Rename include guard.
1268         * tui/tui-regs.h: Rename include guard.
1269         * tui/tui-out.h: Rename include guard.
1270         * tui/tui-layout.h: Rename include guard.
1271         * tui/tui-io.h: Rename include guard.
1272         * tui/tui-hooks.h: Rename include guard.
1273         * tui/tui-file.h: Rename include guard.
1274         * tui/tui-disasm.h: Rename include guard.
1275         * tui/tui-data.h: Rename include guard.
1276         * tui/tui-command.h: Rename include guard.
1277         * tic6x-tdep.h: Add include guard.
1278         * target/waitstatus.h: Rename include guard.
1279         * target/wait.h: Rename include guard.
1280         * target/target.h: Rename include guard.
1281         * target/resume.h: Rename include guard.
1282         * target-float.h: Rename include guard.
1283         * stabsread.h: Add include guard.
1284         * rs6000-tdep.h: Add include guard.
1285         * riscv-fbsd-tdep.h: Add include guard.
1286         * regformats/regdef.h: Rename include guard.
1287         * record.h: Rename include guard.
1288         * python/python.h: Rename include guard.
1289         * python/python-internal.h: Rename include guard.
1290         * python/py-stopevent.h: Rename include guard.
1291         * python/py-ref.h: Rename include guard.
1292         * python/py-record.h: Rename include guard.
1293         * python/py-record-full.h: Rename include guard.
1294         * python/py-record-btrace.h: Rename include guard.
1295         * python/py-instruction.h: Rename include guard.
1296         * python/py-events.h: Rename include guard.
1297         * python/py-event.h: Rename include guard.
1298         * procfs.h: Add include guard.
1299         * proc-utils.h: Add include guard.
1300         * p-lang.h: Add include guard.
1301         * or1k-tdep.h: Rename include guard.
1302         * observable.h: Rename include guard.
1303         * nto-tdep.h: Rename include guard.
1304         * nat/x86-linux.h: Rename include guard.
1305         * nat/x86-linux-dregs.h: Rename include guard.
1306         * nat/x86-gcc-cpuid.h: Add include guard.
1307         * nat/x86-dregs.h: Rename include guard.
1308         * nat/x86-cpuid.h: Rename include guard.
1309         * nat/ppc-linux.h: Rename include guard.
1310         * nat/mips-linux-watch.h: Rename include guard.
1311         * nat/linux-waitpid.h: Rename include guard.
1312         * nat/linux-ptrace.h: Rename include guard.
1313         * nat/linux-procfs.h: Rename include guard.
1314         * nat/linux-osdata.h: Rename include guard.
1315         * nat/linux-nat.h: Rename include guard.
1316         * nat/linux-namespaces.h: Rename include guard.
1317         * nat/linux-btrace.h: Rename include guard.
1318         * nat/glibc_thread_db.h: Rename include guard.
1319         * nat/gdb_thread_db.h: Rename include guard.
1320         * nat/gdb_ptrace.h: Rename include guard.
1321         * nat/fork-inferior.h: Rename include guard.
1322         * nat/amd64-linux-siginfo.h: Rename include guard.
1323         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1324         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1325         * nat/aarch64-linux.h: Rename include guard.
1326         * nat/aarch64-linux-hw-point.h: Rename include guard.
1327         * mn10300-tdep.h: Add include guard.
1328         * mips-linux-tdep.h: Add include guard.
1329         * mi/mi-parse.h: Rename include guard.
1330         * mi/mi-out.h: Rename include guard.
1331         * mi/mi-main.h: Rename include guard.
1332         * mi/mi-interp.h: Rename include guard.
1333         * mi/mi-getopt.h: Rename include guard.
1334         * mi/mi-console.h: Rename include guard.
1335         * mi/mi-common.h: Rename include guard.
1336         * mi/mi-cmds.h: Rename include guard.
1337         * mi/mi-cmd-break.h: Rename include guard.
1338         * m2-lang.h: Add include guard.
1339         * location.h: Rename include guard.
1340         * linux-record.h: Rename include guard.
1341         * linux-nat.h: Add include guard.
1342         * linux-fork.h: Add include guard.
1343         * i386-darwin-tdep.h: Rename include guard.
1344         * hppa-linux-offsets.h: Add include guard.
1345         * guile/guile.h: Rename include guard.
1346         * guile/guile-internal.h: Rename include guard.
1347         * gnu-nat.h: Rename include guard.
1348         * gdb-stabs.h: Rename include guard.
1349         * frv-tdep.h: Add include guard.
1350         * f-lang.h: Add include guard.
1351         * event-loop.h: Add include guard.
1352         * darwin-nat.h: Rename include guard.
1353         * cp-abi.h: Rename include guard.
1354         * config/sparc/nm-sol2.h: Rename include guard.
1355         * config/nm-nto.h: Rename include guard.
1356         * config/nm-linux.h: Add include guard.
1357         * config/i386/nm-i386gnu.h: Rename include guard.
1358         * config/djgpp/nl_types.h: Rename include guard.
1359         * config/djgpp/langinfo.h: Rename include guard.
1360         * compile/gcc-cp-plugin.h: Add include guard.
1361         * compile/gcc-c-plugin.h: Add include guard.
1362         * compile/compile.h: Rename include guard.
1363         * compile/compile-object-run.h: Rename include guard.
1364         * compile/compile-object-load.h: Rename include guard.
1365         * compile/compile-internal.h: Rename include guard.
1366         * compile/compile-cplus.h: Rename include guard.
1367         * compile/compile-c.h: Rename include guard.
1368         * common/xml-utils.h: Rename include guard.
1369         * common/x86-xstate.h: Rename include guard.
1370         * common/version.h: Rename include guard.
1371         * common/vec.h: Rename include guard.
1372         * common/tdesc.h: Rename include guard.
1373         * common/selftest.h: Rename include guard.
1374         * common/scoped_restore.h: Rename include guard.
1375         * common/scoped_mmap.h: Rename include guard.
1376         * common/scoped_fd.h: Rename include guard.
1377         * common/safe-iterator.h: Rename include guard.
1378         * common/run-time-clock.h: Rename include guard.
1379         * common/refcounted-object.h: Rename include guard.
1380         * common/queue.h: Rename include guard.
1381         * common/ptid.h: Rename include guard.
1382         * common/print-utils.h: Rename include guard.
1383         * common/preprocessor.h: Rename include guard.
1384         * common/pathstuff.h: Rename include guard.
1385         * common/observable.h: Rename include guard.
1386         * common/netstuff.h: Rename include guard.
1387         * common/job-control.h: Rename include guard.
1388         * common/host-defs.h: Rename include guard.
1389         * common/gdb_wait.h: Rename include guard.
1390         * common/gdb_vecs.h: Rename include guard.
1391         * common/gdb_unlinker.h: Rename include guard.
1392         * common/gdb_unique_ptr.h: Rename include guard.
1393         * common/gdb_tilde_expand.h: Rename include guard.
1394         * common/gdb_sys_time.h: Rename include guard.
1395         * common/gdb_string_view.h: Rename include guard.
1396         * common/gdb_splay_tree.h: Rename include guard.
1397         * common/gdb_setjmp.h: Rename include guard.
1398         * common/gdb_ref_ptr.h: Rename include guard.
1399         * common/gdb_optional.h: Rename include guard.
1400         * common/gdb_locale.h: Rename include guard.
1401         * common/gdb_assert.h: Rename include guard.
1402         * common/filtered-iterator.h: Rename include guard.
1403         * common/filestuff.h: Rename include guard.
1404         * common/fileio.h: Rename include guard.
1405         * common/environ.h: Rename include guard.
1406         * common/common-utils.h: Rename include guard.
1407         * common/common-types.h: Rename include guard.
1408         * common/common-regcache.h: Rename include guard.
1409         * common/common-inferior.h: Rename include guard.
1410         * common/common-gdbthread.h: Rename include guard.
1411         * common/common-exceptions.h: Rename include guard.
1412         * common/common-defs.h: Rename include guard.
1413         * common/common-debug.h: Rename include guard.
1414         * common/cleanups.h: Rename include guard.
1415         * common/buffer.h: Rename include guard.
1416         * common/btrace-common.h: Rename include guard.
1417         * common/break-common.h: Rename include guard.
1418         * cli/cli-utils.h: Rename include guard.
1419         * cli/cli-style.h: Rename include guard.
1420         * cli/cli-setshow.h: Rename include guard.
1421         * cli/cli-script.h: Rename include guard.
1422         * cli/cli-interp.h: Rename include guard.
1423         * cli/cli-decode.h: Rename include guard.
1424         * cli/cli-cmds.h: Rename include guard.
1425         * charset-list.h: Add include guard.
1426         * buildsym-legacy.h: Rename include guard.
1427         * bfin-tdep.h: Add include guard.
1428         * ax.h: Rename include guard.
1429         * arm-linux-tdep.h: Add include guard.
1430         * arm-fbsd-tdep.h: Add include guard.
1431         * arch/xtensa.h: Rename include guard.
1432         * arch/tic6x.h: Add include guard.
1433         * arch/i386.h: Add include guard.
1434         * arch/arm.h: Rename include guard.
1435         * arch/arm-linux.h: Rename include guard.
1436         * arch/arm-get-next-pcs.h: Rename include guard.
1437         * arch/amd64.h: Add include guard.
1438         * arch/aarch64-insn.h: Rename include guard.
1439         * arch-utils.h: Rename include guard.
1440         * annotate.h: Add include guard.
1441         * amd64-darwin-tdep.h: Rename include guard.
1442         * aarch64-linux-tdep.h: Add include guard.
1443         * aarch64-fbsd-tdep.h: Add include guard.
1444         * aarch32-linux-nat.h: Add include guard.
1445
1446 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1447
1448         * macrotab.c (macro_define_internal): New function that
1449         factorizes macro_define_object_internal and macro_define_function
1450         code.
1451         (macro_define_object_internal): Use macro_define_internal.
1452         (macro_define_function): Likewise.
1453
1454 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1455
1456         * macrocmd.c (extract_identifier): Return
1457         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1458         callers.
1459
1460 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1461
1462         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1463
1464 2019-02-05  Tom Tromey  <tom@tromey.com>
1465
1466         * target.c (target_stack::unpush): Move assertion earlier.
1467
1468 2019-01-30  Tom Tromey  <tom@tromey.com>
1469
1470         PR python/23615:
1471         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1472         (gdbpy_parse_and_eval): Likewise.
1473         * python/python-internal.h (gdbpy_allow_threads): New class.
1474
1475 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1476
1477         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1478         (aarch64_fbsd_fpregmap): Move earlier.
1479         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1480         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1481         instead of individual calls to trad_frame_set_reg_addr.
1482         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1483         earlier.
1484         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1485         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1486         instead of individual calls to trad_frame_set_reg_addr.
1487
1488 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1489
1490         * CONTRIBUTE: Replace contribution list with wiki link.
1491
1492 2019-01-25  Tom Tromey  <tom@tromey.com>
1493
1494         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1495
1496 2019-01-25  Tom Tromey  <tom@tromey.com>
1497
1498         * xtensa-linux-nat.c: Fix common/ includes.
1499         * xml-support.h: Fix common/ includes.
1500         * xml-support.c: Fix common/ includes.
1501         * x86-linux-nat.c: Fix common/ includes.
1502         * windows-nat.c: Fix common/ includes.
1503         * varobj.h: Fix common/ includes.
1504         * varobj.c: Fix common/ includes.
1505         * value.c: Fix common/ includes.
1506         * valops.c: Fix common/ includes.
1507         * utils.c: Fix common/ includes.
1508         * unittests/xml-utils-selftests.c: Fix common/ includes.
1509         * unittests/utils-selftests.c: Fix common/ includes.
1510         * unittests/unpack-selftests.c: Fix common/ includes.
1511         * unittests/tracepoint-selftests.c: Fix common/ includes.
1512         * unittests/style-selftests.c: Fix common/ includes.
1513         * unittests/string_view-selftests.c: Fix common/ includes.
1514         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1515         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1516         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1517         * unittests/rsp-low-selftests.c: Fix common/ includes.
1518         * unittests/parse-connection-spec-selftests.c: Fix common/
1519         includes.
1520         * unittests/optional-selftests.c: Fix common/ includes.
1521         * unittests/offset-type-selftests.c: Fix common/ includes.
1522         * unittests/observable-selftests.c: Fix common/ includes.
1523         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1524         * unittests/memrange-selftests.c: Fix common/ includes.
1525         * unittests/memory-map-selftests.c: Fix common/ includes.
1526         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1527         * unittests/function-view-selftests.c: Fix common/ includes.
1528         * unittests/environ-selftests.c: Fix common/ includes.
1529         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1530         * unittests/common-utils-selftests.c: Fix common/ includes.
1531         * unittests/cli-utils-selftests.c: Fix common/ includes.
1532         * unittests/array-view-selftests.c: Fix common/ includes.
1533         * ui-file.c: Fix common/ includes.
1534         * tui/tui-io.c: Fix common/ includes.
1535         * tracepoint.h: Fix common/ includes.
1536         * tracepoint.c: Fix common/ includes.
1537         * tracefile-tfile.c: Fix common/ includes.
1538         * top.h: Fix common/ includes.
1539         * top.c: Fix common/ includes.
1540         * thread.c: Fix common/ includes.
1541         * target/waitstatus.h: Fix common/ includes.
1542         * target/waitstatus.c: Fix common/ includes.
1543         * target.h: Fix common/ includes.
1544         * target.c: Fix common/ includes.
1545         * target-memory.c: Fix common/ includes.
1546         * target-descriptions.c: Fix common/ includes.
1547         * symtab.h: Fix common/ includes.
1548         * symfile.c: Fix common/ includes.
1549         * stap-probe.c: Fix common/ includes.
1550         * spu-linux-nat.c: Fix common/ includes.
1551         * sparc-nat.c: Fix common/ includes.
1552         * source.c: Fix common/ includes.
1553         * solib.c: Fix common/ includes.
1554         * solib-target.c: Fix common/ includes.
1555         * ser-unix.c: Fix common/ includes.
1556         * ser-tcp.c: Fix common/ includes.
1557         * ser-pipe.c: Fix common/ includes.
1558         * ser-base.c: Fix common/ includes.
1559         * selftest-arch.c: Fix common/ includes.
1560         * s12z-tdep.c: Fix common/ includes.
1561         * rust-exp.y: Fix common/ includes.
1562         * rs6000-aix-tdep.c: Fix common/ includes.
1563         * riscv-tdep.c: Fix common/ includes.
1564         * remote.c: Fix common/ includes.
1565         * remote-notif.h: Fix common/ includes.
1566         * remote-fileio.h: Fix common/ includes.
1567         * remote-fileio.c: Fix common/ includes.
1568         * regcache.h: Fix common/ includes.
1569         * regcache.c: Fix common/ includes.
1570         * record-btrace.c: Fix common/ includes.
1571         * python/python.c: Fix common/ includes.
1572         * python/py-type.c: Fix common/ includes.
1573         * python/py-inferior.c: Fix common/ includes.
1574         * progspace.h: Fix common/ includes.
1575         * producer.c: Fix common/ includes.
1576         * procfs.c: Fix common/ includes.
1577         * proc-api.c: Fix common/ includes.
1578         * printcmd.c: Fix common/ includes.
1579         * ppc-linux-nat.c: Fix common/ includes.
1580         * parser-defs.h: Fix common/ includes.
1581         * osdata.c: Fix common/ includes.
1582         * obsd-nat.c: Fix common/ includes.
1583         * nat/x86-linux.c: Fix common/ includes.
1584         * nat/x86-linux-dregs.c: Fix common/ includes.
1585         * nat/x86-dregs.h: Fix common/ includes.
1586         * nat/x86-dregs.c: Fix common/ includes.
1587         * nat/ppc-linux.c: Fix common/ includes.
1588         * nat/mips-linux-watch.h: Fix common/ includes.
1589         * nat/mips-linux-watch.c: Fix common/ includes.
1590         * nat/linux-waitpid.c: Fix common/ includes.
1591         * nat/linux-ptrace.h: Fix common/ includes.
1592         * nat/linux-ptrace.c: Fix common/ includes.
1593         * nat/linux-procfs.c: Fix common/ includes.
1594         * nat/linux-personality.c: Fix common/ includes.
1595         * nat/linux-osdata.c: Fix common/ includes.
1596         * nat/linux-namespaces.c: Fix common/ includes.
1597         * nat/linux-btrace.h: Fix common/ includes.
1598         * nat/linux-btrace.c: Fix common/ includes.
1599         * nat/fork-inferior.c: Fix common/ includes.
1600         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1601         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1602         * nat/aarch64-linux.c: Fix common/ includes.
1603         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1604         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1605         * namespace.h: Fix common/ includes.
1606         * mips-linux-tdep.c: Fix common/ includes.
1607         * minsyms.c: Fix common/ includes.
1608         * mi/mi-parse.h: Fix common/ includes.
1609         * mi/mi-main.c: Fix common/ includes.
1610         * mi/mi-cmd-env.c: Fix common/ includes.
1611         * memrange.h: Fix common/ includes.
1612         * memattr.c: Fix common/ includes.
1613         * maint.h: Fix common/ includes.
1614         * maint.c: Fix common/ includes.
1615         * main.c: Fix common/ includes.
1616         * machoread.c: Fix common/ includes.
1617         * location.c: Fix common/ includes.
1618         * linux-thread-db.c: Fix common/ includes.
1619         * linux-nat.c: Fix common/ includes.
1620         * linux-fork.c: Fix common/ includes.
1621         * inline-frame.c: Fix common/ includes.
1622         * infrun.c: Fix common/ includes.
1623         * inflow.c: Fix common/ includes.
1624         * inferior.h: Fix common/ includes.
1625         * inferior.c: Fix common/ includes.
1626         * infcmd.c: Fix common/ includes.
1627         * inf-ptrace.c: Fix common/ includes.
1628         * inf-child.c: Fix common/ includes.
1629         * ia64-linux-nat.c: Fix common/ includes.
1630         * i387-tdep.c: Fix common/ includes.
1631         * i386-tdep.c: Fix common/ includes.
1632         * i386-linux-tdep.c: Fix common/ includes.
1633         * i386-linux-nat.c: Fix common/ includes.
1634         * i386-go32-tdep.c: Fix common/ includes.
1635         * i386-fbsd-tdep.c: Fix common/ includes.
1636         * i386-fbsd-nat.c: Fix common/ includes.
1637         * guile/scm-type.c: Fix common/ includes.
1638         * guile/guile.c: Fix common/ includes.
1639         * go32-nat.c: Fix common/ includes.
1640         * gnu-nat.c: Fix common/ includes.
1641         * gdbthread.h: Fix common/ includes.
1642         * gdbarch-selftests.c: Fix common/ includes.
1643         * gdb_usleep.c: Fix common/ includes.
1644         * gdb_select.h: Fix common/ includes.
1645         * gdb_bfd.c: Fix common/ includes.
1646         * gcore.c: Fix common/ includes.
1647         * fork-child.c: Fix common/ includes.
1648         * findvar.c: Fix common/ includes.
1649         * fbsd-nat.c: Fix common/ includes.
1650         * event-top.c: Fix common/ includes.
1651         * event-loop.c: Fix common/ includes.
1652         * dwarf2read.c: Fix common/ includes.
1653         * dwarf2loc.c: Fix common/ includes.
1654         * dwarf2-frame.c: Fix common/ includes.
1655         * dwarf-index-cache.c: Fix common/ includes.
1656         * dtrace-probe.c: Fix common/ includes.
1657         * disasm-selftests.c: Fix common/ includes.
1658         * defs.h: Fix common/ includes.
1659         * csky-tdep.c: Fix common/ includes.
1660         * cp-valprint.c: Fix common/ includes.
1661         * cp-support.h: Fix common/ includes.
1662         * cp-support.c: Fix common/ includes.
1663         * corelow.c: Fix common/ includes.
1664         * completer.h: Fix common/ includes.
1665         * completer.c: Fix common/ includes.
1666         * compile/compile.c: Fix common/ includes.
1667         * compile/compile-loc2c.c: Fix common/ includes.
1668         * compile/compile-cplus-types.c: Fix common/ includes.
1669         * compile/compile-cplus-symbols.c: Fix common/ includes.
1670         * command.h: Fix common/ includes.
1671         * cli/cli-dump.c: Fix common/ includes.
1672         * cli/cli-cmds.c: Fix common/ includes.
1673         * charset.c: Fix common/ includes.
1674         * build-id.c: Fix common/ includes.
1675         * btrace.h: Fix common/ includes.
1676         * btrace.c: Fix common/ includes.
1677         * breakpoint.h: Fix common/ includes.
1678         * breakpoint.c: Fix common/ includes.
1679         * ax.h: 
1680         (enum agent_op): Fix common/ includes.
1681         * ax-general.c (struct aop_map): Fix common/ includes.
1682         * ax-gdb.c: Fix common/ includes.
1683         * auxv.c: Fix common/ includes.
1684         * auto-load.c: Fix common/ includes.
1685         * arm-tdep.c: Fix common/ includes.
1686         * arch/riscv.c: Fix common/ includes.
1687         * arch/ppc-linux-common.c: Fix common/ includes.
1688         * arch/i386.c: Fix common/ includes.
1689         * arch/arm.c: Fix common/ includes.
1690         * arch/arm-linux.c: Fix common/ includes.
1691         * arch/arm-get-next-pcs.c: Fix common/ includes.
1692         * arch/amd64.c: Fix common/ includes.
1693         * arch/aarch64.c: Fix common/ includes.
1694         * arch/aarch64-insn.c: Fix common/ includes.
1695         * arch-utils.c: Fix common/ includes.
1696         * amd64-windows-tdep.c: Fix common/ includes.
1697         * amd64-tdep.c: Fix common/ includes.
1698         * amd64-sol2-tdep.c: Fix common/ includes.
1699         * amd64-obsd-tdep.c: Fix common/ includes.
1700         * amd64-nbsd-tdep.c: Fix common/ includes.
1701         * amd64-linux-tdep.c: Fix common/ includes.
1702         * amd64-linux-nat.c: Fix common/ includes.
1703         * amd64-fbsd-tdep.c: Fix common/ includes.
1704         * amd64-fbsd-nat.c: Fix common/ includes.
1705         * amd64-dicos-tdep.c: Fix common/ includes.
1706         * amd64-darwin-tdep.c: Fix common/ includes.
1707         * agent.c: Fix common/ includes.
1708         * ada-lang.h: Fix common/ includes.
1709         * ada-lang.c: Fix common/ includes.
1710         * aarch64-tdep.c: Fix common/ includes.
1711
1712 2019-01-25  Tom Tromey  <tom@tromey.com>
1713
1714         * common/create-version.sh: Use common/version.h.
1715
1716 2019-01-24  Pedro Alves  <palves@redhat.com>
1717
1718         * infrun.c (signal_stop, signal_print, signal_program)
1719         (signal_catch, signal_pass): Now arrays instead of pointers.
1720         (update_signals_program_target, do_target_resume)
1721         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1722         * linux-nat.c (linux_nat_target::pass_signals)
1723         (linux_nat_target::create_inferior, linux_nat_target::attach):
1724         Adjust.
1725         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1726         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1727         * procfs.c (procfs_target::pass_signals): Adjust.
1728         * record-full.c (record_full_target::resume): Adjust.
1729         * remote.c (remote_target::pass_signals)
1730         (remote_target::program_signals): Adjust.
1731         * target-debug.h (target_debug_print_signals): Now takes a
1732         gdb::array_view as parameter.  Adjust.
1733         * target.h (target_ops) <pass_signals, program_signals>: Replace
1734         pointer and length parameters with gdb::array_view.
1735         (target_pass_signals, target_program_signals): Likewise.
1736         * target-delegates.c: Regenerate.
1737
1738 2019-01-24  Pedro Alves  <palves@redhat.com>
1739
1740         * common/forward-scope-exit.h
1741         (forward_scope_exit::forward_scope_exit): Pass arguments to
1742         m_bind_function directly, instead of creating a std::bind and
1743         copying that.
1744
1745 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1746
1747         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1748         for static members.
1749         (pass_in_v_vfp_candidate): Likewise.
1750
1751 2019-01-23  Tom Tromey  <tom@tromey.com>
1752             Pedro Alves  <palves@redhat.com>
1753
1754         * regcache.c (class regcache_invalidator): Remove.
1755         (regcache::raw_write): Use make_scope_exit.
1756
1757 2019-01-23  Tom Tromey  <tom@tromey.com>
1758
1759         * ui-out.h (class ui_out_emit_type): Update comment.
1760
1761 2019-01-23  Tom Tromey  <tom@tromey.com>
1762
1763         * infrun.c (fetch_inferior_event): Update comment.
1764
1765 2019-01-23  Tom Tromey  <tom@tromey.com>
1766             Pedro Alves  <palves@redhat.com>
1767
1768         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1769         parameter.
1770         (fetch_inferior_event): Use SCOPE_EXIT.
1771
1772
1773 2019-01-23  Tom Tromey  <tom@tromey.com>
1774             Pedro Alves  <palves@redhat.com>
1775
1776         * infrun.c (disable_thread_events): Delete.
1777         (stop_all_threads): Use SCOPE_EXIT.
1778
1779 2019-01-23  Tom Tromey  <tom@tromey.com>
1780             Pedro Alves  <palves@redhat.com>
1781
1782         * symfile.c: Include forward-scope-exit.h.
1783         (clear_symtab_users_cleanup): Replace forward declaration with
1784         a FORWARD_SCOPE_EXIT.
1785         (syms_from_objfile_1): Use the forward_scope_exit and
1786         gdb::optional instead of cleanup_function.
1787         (reread_symbols): Use the forward_scope_exit instead of
1788         cleanup_function.
1789         (clear_symtab_users_cleanup): Remove function.
1790
1791 2019-01-23  Tom Tromey  <tom@tromey.com>
1792             Pedro Alves  <palves@redhat.com>
1793
1794         * linux-nat.c: Include scope-exit.h.
1795         (cleanup_target_stop): Remove.
1796         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1797         SCOPE_EXIT.
1798
1799 2019-01-23  Tom Tromey  <tom@tromey.com>
1800             Pedro Alves  <palves@redhat.com>
1801
1802         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1803         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1804
1805 2019-01-23  Tom Tromey  <tom@tromey.com>
1806             Andrew Burgess  <andrew.burgess@embecosm.com>
1807             Pedro Alves  <palves@redhat.com>
1808
1809         * infrun.c (fetch_inferior_event): Use scope_exit.
1810         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1811         * top.c (execute_command): Use scope_exit.
1812         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1813         * utils.c (do_bpstat_clear_actions_cleanup)
1814         (make_bpstat_clear_actions_cleanup): Remove.
1815
1816 2019-01-23  Tom Tromey  <tom@tromey.com>
1817             Pedro Alves  <palves@redhat.com>
1818
1819         * infrun.c: Include "common/scope-exit.h"
1820         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1821         (wait_for_inferior): Use SCOPE_EXIT.
1822         (fetch_inferior_event): Use scope_exit.
1823
1824 2019-01-23  Tom Tromey  <tom@tromey.com>
1825             Pedro Alves  <palves@redhat.com>
1826
1827         * breakpoint.c (create_breakpoint): Remove cleanup.
1828
1829 2019-01-23  Tom Tromey  <tom@tromey.com>
1830             Andrew Burgess  <andrew.burgess@embecosm.com>
1831             Pedro Alves  <palves@redhat.com>
1832
1833 2019-01-23  Pedro Alves  <palves@redhat.com>
1834
1835         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1836
1837 2019-01-23  Pedro Alves  <palves@redhat.com>
1838             Andrew Burgess  <andrew.burgess@embecosm.com>
1839
1840         * gdbthread.h: Include "common/forward-scope-exit.h".
1841         (scoped_finish_thread_state): Redefine custom class in terms of
1842         forward_scope_exit.
1843
1844 2019-01-23  Pedro Alves  <palves@redhat.com>
1845             Andrew Burgess  <andrew.burgess@embecosm.com>
1846
1847         * common/forward-scope-exit.h: New file.
1848
1849 2019-01-23  Pedro Alves  <palves@redhat.com>
1850             Andrew Burgess  <andrew.burgess@embecosm.com>
1851             Tom Tromey  <tom@tromey.com>
1852
1853         * common/scope-exit.h: New file.
1854
1855 2019-01-23  Pedro Alves  <palves@redhat.com>
1856
1857         * common/preprocessor.h (ESC): Rename to ...
1858         (ESC_PARENS): ... this.
1859         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1860         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1861
1862 2019-01-23  Tom Tromey  <tom@tromey.com>
1863
1864         * language.h (class scoped_switch_to_sym_language_if_auto):
1865         Initialize m_lang in both cases.
1866
1867 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1868
1869         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1870         with XCNEW.
1871
1872 2019-01-22  Tom Tromey  <tom@tromey.com>
1873
1874         * corelow.c: Do not include sys/file.h.
1875
1876 2019-01-22  Tom Tromey  <tom@tromey.com>
1877
1878         * tui/tui-wingeneral.h: Include gdb_curses.h.
1879
1880 2019-01-22  Tom Tromey  <tom@tromey.com>
1881
1882         * source-cache.h (class source_cache) <get_source_lines,
1883         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1884
1885 2019-01-22  Tom Tromey  <tom@tromey.com>
1886
1887         * remote-fileio.h (struct remote_target): Declare.
1888
1889 2019-01-22  Tom Tromey  <tom@tromey.com>
1890
1891         * python/py-arch.c: Do not include py-ref.h.
1892         * python/py-bpevent.c: Do not include py-ref.h.
1893         * python/py-cmd.c: Do not include py-ref.h.
1894         * python/py-continueevent.c: Do not include py-ref.h.
1895         * python/py-event.h: Do not include py-ref.h.
1896         * python/py-evtregistry.c: Do not include py-ref.h.
1897         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1898         * python/py-frame.c: Do not include py-ref.h.
1899         * python/py-framefilter.c: Do not include py-ref.h.
1900         * python/py-function.c: Do not include py-ref.h.
1901         * python/py-infevents.c: Do not include py-ref.h.
1902         * python/py-linetable.c: Do not include py-ref.h.
1903         * python/py-objfile.c: Do not include py-ref.h.
1904         * python/py-param.c: Do not include py-ref.h.
1905         * python/py-prettyprint.c: Do not include py-ref.h.
1906         * python/py-progspace.c: Do not include py-ref.h.
1907         * python/py-symbol.c: Do not include py-ref.h.
1908         * python/py-symtab.c: Do not include py-ref.h.
1909         * python/py-type.c: Do not include py-ref.h.
1910         * python/py-unwind.c: Do not include py-ref.h.
1911         * python/py-utils.c: Do not include py-ref.h.
1912         * python/py-value.c: Do not include py-ref.h.
1913         * python/py-varobj.c: Do not include py-ref.h.
1914         * python/py-xmethods.c: Do not include py-ref.h.
1915         * python/python.c: Do not include py-ref.h.
1916         * varobj.c: Do not include py-ref.h.
1917
1918 2019-01-22  Tom Tromey  <tom@tromey.com>
1919
1920         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1921         keyword for bcache.
1922
1923 2019-01-22  Tom Tromey  <tom@tromey.com>
1924
1925         * compile/compile-cplus-types.c: Remove a comment by #include.
1926
1927 2019-01-22  Tom Tromey  <tom@tromey.com>
1928
1929         * compile/gcc-c-plugin.h: Include compile-internal.h.
1930
1931 2019-01-22  Tom Tromey  <tom@tromey.com>
1932
1933         * stabsread.c (EXTERN): Do not define.
1934         (symnum, next_symbol_text_func, processing_gcc_compilation)
1935         (within_function, global_sym_chain, global_stabs)
1936         (previous_stab_code, this_object_header_files)
1937         (n_this_object_header_files)
1938         (n_allocated_this_object_header_files): Define.
1939         * stabsread.h (EXTERN): Never define.  Use "extern".
1940
1941 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1942
1943         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1944         history_value.
1945
1946 2019-01-21  Tom Tromey  <tom@tromey.com>
1947
1948         * ui-out.c: Fix includes.
1949         * tui/tui-source.c: Fix includes.
1950         * target.c: Fix includes.
1951         * remote.c: Fix includes.
1952         * regcache.c: Fix includes.
1953         * python/py-block.c: Fix includes.
1954         * printcmd.c: Fix includes.
1955         * or1k-tdep.c: Fix includes.
1956         * mi/mi-main.c: Fix includes.
1957         * m32r-tdep.c: Fix includes.
1958         * csky-tdep.c: Fix includes.
1959         * compile/compile-cplus-types.c: Fix includes.
1960         * cli/cli-interp.c: Fix includes.
1961
1962 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1963
1964         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1965         for padding.
1966
1967 2019-01-16  Tom Tromey  <tom@tromey.com>
1968
1969         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1970         earlier.
1971         (struct objfile) <msymbols_range>: Move from top level.
1972         <msymbols>: New method.
1973         (class objfile_msymbols): Remove.
1974         * symtab.c (default_collect_symbol_completion_matches_break_on):
1975         Update.
1976         * symmisc.c (dump_msymbols): Update.
1977         * stabsread.c (scan_file_globals): Update.
1978         * objc-lang.c (info_selectors_command, info_classes_command)
1979         (find_methods): Update.
1980         * minsyms.c (find_solib_trampoline_target): Update.
1981         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1982         * coffread.c (coff_symfile_read): Update.
1983         * ada-lang.c (ada_lookup_simple_minsym)
1984         (ada_collect_symbol_completion_matches): Update.
1985
1986 2019-01-16  Tom Tromey  <tom@tromey.com>
1987
1988         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1989         type.  Remove no-argument constructor.
1990         <iterator::operator++>: Simplify.
1991         <begin>: Update.
1992         <end>: Use minimal_symbol_count.
1993
1994 2019-01-16  Tom Tromey  <tom@tromey.com>
1995
1996         * objfiles.h (struct objfile) <psymtabs>: New method.
1997         (class objfile_psymtabs): Remove.
1998         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1999         typedef.
2000         <range>: New method.
2001         (require_partial_symbols): Change return type.
2002         * psymtab.c (require_partial_symbols)
2003         (psym_expand_symtabs_matching): Update.
2004         * mdebugread.c (parse_partial_symbols): Update.
2005         * dbxread.c (dbx_end_psymtab): Update.
2006
2007 2019-01-15  Tom Tromey  <tom@tromey.com>
2008
2009         * symtab.c (lookup_objfile_from_block)
2010         (lookup_symbol_in_objfile_symtabs)
2011         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2012         (find_line_symtab, info_sources_command)
2013         (default_collect_symbol_completion_matches_break_on)
2014         (make_source_files_completion_list): Update.
2015         * symmisc.c (print_objfile_statistics, dump_objfile)
2016         (maintenance_print_symbols, maintenance_info_symtabs)
2017         (maintenance_check_symtabs, maintenance_info_line_tables):
2018         Update.
2019         * source.c (select_source_symtab)
2020         (forget_cached_source_info_for_objfile): Update.
2021         * objfiles.h (class objfile_compunits): Remove.
2022         (struct objfile) <compunits_range>: New typedef.
2023         (compunits): New method.
2024         * objfiles.c (objfile_relocate1): Update.
2025         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2026         * maint.c (count_symtabs_and_blocks): Update.
2027         * linespec.c (iterate_over_all_matching_symtabs): Update.
2028         * cp-support.c (add_symbol_overload_list_qualified): Update.
2029         * coffread.c (coff_symtab_read): Update.
2030         * ada-lang.c (add_nonlocal_symbols)
2031         (ada_collect_symbol_completion_matches)
2032         (ada_add_global_exceptions): Update.
2033
2034 2019-01-15  Tom Tromey  <tom@tromey.com>
2035
2036         * progspace.h (program_space) <objfiles_safe_range>: New
2037         typedef.
2038         <objfiles_safe>: New method.
2039         * objfiles.h (class all_objfiles_safe): Remove.
2040         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2041         * jit.c (jit_inferior_exit_hook): Update.
2042
2043 2019-01-17  Tom Tromey  <tom@tromey.com>
2044
2045         * progspace.h (program_space) <objfiles_range>: New typedef.
2046         <objfiles>: New method.
2047         <objfiles_head>: Rename from objfiles.
2048         (object_files): Update.
2049         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2050         * guile/scm-pretty-print.c
2051         (ppscm_find_pretty_printer_from_objfiles): Update.
2052         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2053         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2054         Update.
2055         * python/py-progspace.c (pspy_get_objfiles): Update.
2056         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2057         Update.
2058         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2059         (objfpy_lookup_objfile_by_build_id): Update.
2060         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2061         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2062         Update.
2063         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2064         (expand_symtab_containing_pc, lookup_objfile_from_block)
2065         (lookup_static_symbol, basic_lookup_transparent_type)
2066         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2067         (find_line_symtab, info_sources_command)
2068         (default_collect_symbol_completion_matches_break_on)
2069         (make_source_files_completion_list, find_main_name): Update.
2070         * symmisc.c (print_symbol_bcache_statistics)
2071         (print_objfile_statistics, maintenance_print_symbols)
2072         (maintenance_print_msymbols, maintenance_print_objfiles)
2073         (maintenance_info_symtabs, maintenance_check_symtabs)
2074         (maintenance_expand_symtabs, maintenance_info_line_tables):
2075         Update.
2076         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2077         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2078         (map_overlay_command, unmap_overlay_command)
2079         (simple_overlay_update, expand_symtabs_matching)
2080         (map_symbol_filenames): Update.
2081         * symfile-debug.c (set_debug_symfile): Update.
2082         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2083         Update.
2084         * source.c (select_source_symtab, forget_cached_source_info):
2085         Update.
2086         * solib.c (solib_read_symbols): Update.
2087         * solib-spu.c (append_ocl_sos): Update.
2088         * psymtab.c (maintenance_print_psymbols)
2089         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2090         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2091         * printcmd.c (info_symbol_command): Update.
2092         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2093         Update.
2094         * objfiles.h (class all_objfiles): Remove.
2095         * objfiles.c (have_partial_symbols, have_full_symbols)
2096         (have_minimal_symbols, qsort_cmp, update_section_map)
2097         (shared_objfile_contains_address_p)
2098         (default_iterate_over_objfiles_in_search_order): Update.
2099         * objc-lang.c (info_selectors_command, info_classes_command)
2100         (find_methods): Update.
2101         * minsyms.c (find_solib_trampoline_target): Update.
2102         * maint.c (maintenance_info_sections)
2103         (maintenance_translate_address, count_symtabs_and_blocks):
2104         Update.
2105         * main.c (captured_main_1): Update.
2106         * linux-thread-db.c (try_thread_db_load_from_pdir)
2107         (has_libpthread): Update.
2108         * linespec.c (iterate_over_all_matching_symtabs)
2109         (search_minsyms_for_name): Update.
2110         * jit.c (jit_find_objf_with_entry_addr): Update.
2111         * hppa-tdep.c (find_unwind_entry)
2112         (hppa_lookup_stub_minimal_symbol): Update.
2113         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2114         Update.
2115         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2116         (elf_gnu_ifunc_resolve_by_got): Update.
2117         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2118         * dwarf-index-write.c (save_gdb_index_command): Update.
2119         * cp-support.c (add_symbol_overload_list_qualified): Update.
2120         * breakpoint.c (create_overlay_event_breakpoint)
2121         (create_longjmp_master_breakpoint)
2122         (create_std_terminate_master_breakpoint)
2123         (create_exception_master_breakpoint): Update.
2124         * blockframe.c (find_pc_partial_function): Update.
2125         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2126         (ada_collect_symbol_completion_matches)
2127         (ada_add_global_exceptions): Update.
2128
2129 2019-01-17  Tom Tromey  <tom@tromey.com>
2130
2131         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2132         declare VEC.
2133         (solib_target_parse_libraries): Change return type.
2134         (library_list_start_segment, library_list_start_section)
2135         (library_list_end_library, library_list_start_library); Update.
2136         (solib_target_free_library_list): Remove.
2137         (solib_target_parse_libraries): Remove cleanup.  Change return
2138         type.
2139         (solib_target_current_sos): Update.
2140
2141 2019-01-17  Tom Tromey  <tromey@bapiya>
2142
2143         * valprint.c: Replace "the the" with "the".
2144         * symtab.c: Replace "the the" with "the".
2145         * solib.c: Replace "the the" with "the".
2146         * solib-dsbt.c: Replace "the the" with "the".
2147         * linespec.c: Replace "the the" with "the".
2148         * dwarf2loc.h: Replace "the the" with "the".
2149         * amd64-windows-tdep.c: Replace "the the" with "the".
2150         * aarch64-tdep.c: Replace "the the" with "the".
2151
2152 2019-01-16  Keith Seitz  <keiths@redhat.com>
2153
2154         PR gdb/23773
2155         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2156         <builder>: Rename to ..
2157         <m_builder>: ... this and make private.
2158         (dwarf2_cu::get_builder): New method.  Change all users of
2159         `builder' to use this method.
2160         (dwarf2_start_symtab): Move to ...
2161         (dwarf2_cu::start_symtab): ... here.  Update all callers
2162         (setup_type_unit_groups): Move to ...
2163         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2164         callers.
2165         (dwarf2_cu::reset_builder): New method.
2166         (process_full_compunit, process_full_type_unit): Use
2167         dwarf2_cu::reset_builder.
2168         (follow_die_offset): Record the ancestor CU if it is different
2169         from the followed DIE's CU.
2170         (follow_die_sig_1): Likewise.
2171
2172 2019-01-15  Tom Tromey  <tom@tromey.com>
2173
2174         * remote.c (class remote_state) <buf>: Now a char_vector.
2175         <buf_size>: Remove.
2176         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2177         parameter.
2178         (remote_target::getpkt_or_notif_sane_1)
2179         (remote_target::getpkt_sane)
2180         (remote_target::getpkt_or_notif_sane): Likewise.
2181         (class remote_target) <putpkt>: New overload.
2182         (remote_target::read_frame): Change type of "buf_p".  Remove
2183         sizeof_p parameter.
2184         (packet_ok): New overload.
2185         (packet_check_result): New overload.
2186         Update all uses.
2187
2188 2019-01-14  Tom Tromey  <tom@tromey.com>
2189
2190         * remote-notif.c (handle_notification, remote_notif_ack)
2191         (remote_notif_parse): Make "buf" const.
2192         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2193         const.
2194         (remote_notif_parse, remote_notif_ack, handle_notification):
2195         Likewise.
2196         * remote.c (remote_notif_stop_parse): Make "buf" const.
2197         (remote_target::remote_parse_stop_reply): Make "buf" const.
2198         (remote_notif_stop_ack): Make "buf" const.
2199
2200 2019-01-14  Tom Tromey  <tom@tromey.com>
2201
2202         * remote.c (remote_console_output): Make parameter const.
2203
2204 2019-01-14  Tom Tromey  <tom@tromey.com>
2205
2206         * target-debug.h (target_debug_print_signals): Constify.
2207         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2208         * procfs.c (procfs_target::pass_signals): Update.
2209         * linux-nat.c (linux_nat_target::pass_signals): Update.
2210         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2211         * target-delegates.c: Rebuild.
2212         * remote.c (remote_target::program_signals): Update.
2213         (remote_target::pass_signals): Update.
2214         * target.c (target_pass_signals): Constify argument.
2215         (target_program_signals): Likewise.
2216         * target.h (struct target_ops) <pass_signals, program_signals>:
2217         Constify argument.
2218         (target_pass_signals, target_program_signals): Constify argument.
2219
2220 2019-01-14  Tom Tromey  <tom@tromey.com>
2221
2222         PR tui/28819:
2223         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2224
2225 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2226
2227         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2228         field.
2229         * rs6000-tdep.c: Include reggroups.h.
2230         (IS_V_ALIAS_PSEUDOREG): Define.
2231         (rs6000_register_name): Return names for the "vX" aliases.
2232         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2233         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2234         aliases.  Call default_register_reggroup_p for all other
2235         pseudo-registers.
2236         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2237         New functions.
2238         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2239         Handle "vX" aliases.
2240         (v_alias_pseudo_register_collect): New function.
2241         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2242         (rs6000_gdbarch_init): Initialize "vX" aliases as
2243         pseudo-registers.  Restore registration of
2244         rs6000_pseudo_register_reggroup_p with
2245         set_tdesc_pseudo_register_reggroup_p.
2246
2247 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2248
2249         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2250         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2251         set_gdbarch_num_pseudo_regs.
2252
2253 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2254
2255         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2256         Remove arg prefixname, add do_set and do_show.
2257         Add member functions set_list and show_list.
2258         * cli/cli-style.c (class cli_style_option): Update accordingly.
2259         (style_set_list): Move to file scope.
2260         (style_show_list): Likewise.
2261         (set_style): Call help_list.
2262         (show_style): Call cmd_show_list.
2263         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2264         Update to use the new macro.
2265
2266 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2267
2268         * ada-lang.c (_initialize_ada_language): Expand the help text
2269         for the "catch exception" command.
2270
2271 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2272
2273         * symtab.c (matching_obj_sections): Initialize obj,
2274         declare it closer to its usage.
2275
2276 2019-01-10  Tom Tromey  <tom@tromey.com>
2277
2278         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2279         (basic_inf_threads_range): Remove.
2280         (inf_threads_range, inf_non_exited_threads_range)
2281         (safe_inf_threads_range): Use next_adapter.
2282
2283 2019-01-10  Keith Seitz  <keiths@redhat.com>
2284
2285         PR gdb/23712
2286         PR symtab/23010
2287         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2288         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2289
2290 2019-01-10  Keith Seitz  <keiths@redhat.com>
2291
2292         PR gdb/23712
2293         PR symtab/23010
2294         * dictionary.c (pending_to_vector): Remove.
2295         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2296         Remove _1 suffix, replacing functions of the same name.  Update
2297         all callers.
2298         (dict_create_hashed, dict_create_hashed_expandable)
2299         (dict_create_linear, dict_create_linear_expandable, dict_free)
2300         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2301         Make functions static.
2302
2303 2019-01-10  Keith Seitz  <keiths@redhat.com>
2304
2305         PR gdb/23712
2306         PR symtab/23010
2307         * dictionary.h (struct dictionary): Replace declaration with
2308         multidictionary.
2309         (dict_create_hashed, dict_create_hashed_expandable)
2310         (dict_create_linear, dict_create_linear_expandable)
2311         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2312         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2313         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2314         taking multidictionary argument.
2315         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2316         * block.h (struct block) <dict>: Change to multidictionary
2317         and rename `multidict'.
2318         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2319         symmisc.c: Update all dictionary references to multidictionary.
2320
2321 2019-01-10  Keith Seitz  <keiths@redhat.com>
2322
2323         PR gdb/23712
2324         PR symtab/23010
2325         * dictionary.c: Include unordered_map.
2326         (pending_to_vector): New function.
2327         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2328         Rewrite the non-"_1" functions to take vector instead
2329         of linked list.
2330         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2331         "new" _1 versions of the same name.
2332         (multidictionary): Define.
2333         (std::hash<enum language): New definition.
2334         (collate_pending_symbols_by_language, mdict_create_hashed)
2335         (mdict_create_hashed_expandable, mdict_create_linear)
2336         (mdict_create_linear_expandable, mdict_free)
2337         (find_language_dictionary, create_new_language_dictionary)
2338         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2339         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2340         (mdict_size, mdict_empty): New functions.
2341         * dictionary.h (mdict_iterator): Define.
2342
2343 2019-01-10  Pedro Alves  <palves@redhat.com>
2344
2345         * breakpoint.c (read_uploaded_action)
2346         (create_tracepoint_from_upload): Adjust to use
2347         gdb::unique_xmalloc_ptr.
2348         * ctf.c (ctf_write_uploaded_tp):
2349         (SET_ARRAY_FIELD): Use emplace_back.
2350         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2351         * tracefile-tfile.c (tfile_write_uploaded_tp):
2352         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2353         gdb::unique_xmalloc_ptr.
2354         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2355         at_string, cond_string, cmd_strings>: Replace char pointers
2356         with gdb::unique_xmalloc_ptr.
2357
2358 2019-01-10  Pedro Alves  <palves@redhat.com>
2359
2360         * solib-target.c (library_list_start_library): Don't xstrdup name.
2361
2362 2019-01-10  Pedro Alves  <palves@redhat.com>
2363
2364         * mdebugread.c (parse_partial_symbols): Use
2365         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2366
2367 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2368
2369         * linux-fork.c (scoped_switch_fork_info)
2370         <~scoped_switch_fork_info>: Fix incorrect variable name.
2371
2372 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * linux-fork.c (scoped_switch_fork_info)
2375         <scoped_switch_fork_info>: Make explicit.
2376         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2377
2378 2019-01-10  Tom Tromey  <tom@tromey.com>
2379
2380         * objfiles.h (objfile::reset_psymtabs): Update.
2381         * objfiles.c (objfile::objfile): Update.
2382         * psymtab.h (psymtab_storage::obstack): Update.
2383         (psymtab_storage::m_obstack): Use gdb::optional.
2384         (class psymtab_storage): Update comment.  Remove objfile
2385         parameter.
2386         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2387
2388 2019-01-10  Tom Tromey  <tom@tromey.com>
2389
2390         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2391         <free_psymtabs>: Now private.
2392         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2393         (allocate_psymtab): Use new method.
2394
2395 2019-01-10  Tom Tromey  <tom@tromey.com>
2396
2397         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2398         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2399         * mdebugread.c (parse_partial_symbols): Use
2400         allocate_dependencies.
2401         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2402         allocate_dependencies.
2403         (process_psymtab_comp_unit_reader)
2404         (build_type_psymtab_dependencies): Likewise.
2405         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2406
2407 2019-01-10  Tom Tromey  <tom@tromey.com>
2408
2409         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2410         PSYMBOL_SET_LANGUAGE.
2411         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2412
2413 2019-01-10  Tom Tromey  <tom@tromey.com>
2414
2415         * psymtab.h (psymtab_storage::obstack): New method.
2416         <m_obstack>: Rename from obstack; now private.
2417         * psymtab.c (psymtab_storage): Update.
2418         * dwarf2read.c (create_addrmap_from_index)
2419         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2420         Update.
2421
2422 2019-01-10  Tom Tromey  <tom@tromey.com>
2423
2424         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2425         * objfiles.h (objfile::reset_psymtabs): New method.
2426
2427 2019-01-10  Tom Tromey  <tom@tromey.com>
2428
2429         * symmisc.c (print_symbol_bcache_statistics): Update.
2430         (print_objfile_statistics): Update.
2431         * symfile.c (reread_symbols): Update.
2432         * psymtab.h (class psymtab_storage): New.
2433         * psymtab.c (psymtab_storage): New constructor.
2434         (~psymtab_storage): New destructor.
2435         (require_partial_symbols): Update.
2436         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2437         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2438         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2439         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2440         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2441         (start_psymtab_common, end_psymtab_common)
2442         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2443         (allocate_psymtab): Update.
2444         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2445         Update.
2446         (dump_psymtab_addrmap, maintenance_print_psymbols)
2447         (maintenance_check_psymtabs): Update.
2448         (class objfile_psymtabs): Move to objfiles.h.
2449         * psympriv.h (discard_psymtab): Now inline.
2450         (psymtab_discarder::psymtab_discarder): Update.
2451         (psymtab_discarder::~psymtab_discarder): Update.
2452         (ALL_OBJFILE_PSYMTABS): Rewrite.
2453         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2454         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2455         Remove fields.
2456         <partial_symtabs>: New field.
2457         (class objfile_psymtabs): Move from psymtab.h.  Update.
2458         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2459         psymbol_cache.
2460         (objfile::~objfile): Don't destroy psymbol_cache.
2461         * mdebugread.c (parse_partial_symbols): Update.
2462         * dwarf2read.c (create_addrmap_from_index)
2463         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2464         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2465         (add_partial_subprogram, dwarf2_ranges_read): Update.
2466         * dwarf-index-write.c (write_address_map)
2467         (write_one_signatured_type, recursively_write_psymbols)
2468         (class debug_names, class debug_names, write_psymtabs_to_index):
2469         Update.
2470
2471 2019-01-10  Tom Tromey  <tom@tromey.com>
2472
2473         * symtab.h (SYMBOL_SET_NAMES): Update.
2474         (symbol_set_names): Update.
2475         (MSYMBOL_SET_NAMES): Update.
2476         * symtab.c (symbol_set_names): Change argument to be an
2477         objfile_per_bfd_storage.
2478         * psymtab.c (add_psymbol_to_bcache): Update.
2479         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2480
2481 2019-01-10  Tom Tromey  <tom@tromey.com>
2482
2483         * symtab.c (create_demangled_names_hash): Change argument to be an
2484         objfile_per_bfd_storage.
2485         (symbol_set_names): Update.
2486
2487 2019-01-10  Tom Tromey  <tom@tromey.com>
2488
2489         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2490         init_psymbol_list.
2491         * psymtab.c (init_psymbol_list): Do nothing if already called.
2492         * psympriv.h (init_psymbol_list): Add comment.
2493         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2494         init_psymbol_list.
2495         * dbxread.c (dbx_symfile_read): Unconditionally call
2496         init_psymbol_list.
2497
2498 2019-01-10  Tom Tromey  <tom@tromey.com>
2499
2500         * xcoffread.c (scan_xcoff_symtab): Update.
2501         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2502         "where".
2503         * mdebugread.c (parse_partial_symbols)
2504         (handle_psymbol_enumerators): Update.
2505         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2506         * dbxread.c (read_dbx_symtab): Update.
2507         * psympriv.h (psymbol_placement): New enum.
2508         (add_psymbol_to_list): Update.
2509
2510 2019-01-10  Tom Tromey  <tom@tromey.com>
2511
2512         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2513         static_psymbols parameters.
2514         (scan_xcoff_symtab): Update.
2515         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2516         static_psymbols parameters.
2517         * psympriv.h (start_psymtab_common): Update.
2518         * mdebugread.c (parse_partial_symbols): Update.
2519         * dwarf2read.c (create_partial_symtab): Update.
2520         * dbxread.c (read_dbx_symtab): Update.
2521         (start_psymtab): Remove global_psymbols and static_psymbols
2522         parameters.
2523
2524 2019-01-10  Tom Tromey  <tom@tromey.com>
2525
2526         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2527         * psymtab.c (allocate_psymtab): Add comment.
2528         * psympriv.h (allocate_psymtab): Add comment.
2529         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2530         initializations.
2531         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2532
2533 2019-01-10  Tom Tromey  <tom@tromey.com>
2534
2535         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2536         Don't declare.
2537         * mipsread.c: Include mdebugread.h.
2538         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2539         Declare.
2540         * elfread.c: Include mdebugread.h.
2541
2542 2019-01-09  Tom Tromey  <tom@tromey.com>
2543
2544         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2545         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2546         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2547         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2548         (psym_lookup_symbol, psym_find_last_source_symtab)
2549         (psym_forget_cached_source_info, psym_print_stats)
2550         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2551         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2552         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2553         (psym_find_compunit_symtab_by_address)
2554         (maintenance_print_psymbols, maintenance_info_psymtabs)
2555         (maintenance_check_psymtabs): Use ranged for.
2556         * psymtab.h (class objfile_psymtabs): New.
2557         (require_partial_symbols): Return objfile_psymtabs.
2558         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2559
2560 2019-01-09  Tom Tromey  <tom@tromey.com>
2561
2562         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2563         (find_pc_mapped_section, list_overlays_command)
2564         (map_overlay_command, unmap_overlay_command)
2565         (simple_overlay_update): Use all_objfiles.
2566         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2567         * printcmd.c (info_symbol_command): Use all_objfiles.
2568         * objfiles.h (ALL_OBJSECTIONS): Remove.
2569         * maint.c (maintenance_translate_address): Use all_objfiles.
2570         * gcore.c (gcore_create_callback): Use all_objfiles.
2571         (objfile_find_memory_regions): Likewise.
2572
2573 2019-01-09  Tom Tromey  <tom@tromey.com>
2574
2575         * symtab.c (find_line_symtab, info_sources_command)
2576         (make_source_files_completion_list): Use objfile_compunits.
2577         * source.c (select_source_symtab): Use objfile_compunits.
2578         * objfiles.h (struct objfile): Update comment.
2579         (ALL_OBJFILES): Remove.
2580         (ALL_FILETABS): Remove.
2581         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2582         objfile_compunits.
2583
2584 2019-01-09  Tom Tromey  <tom@tromey.com>
2585
2586         * symmisc.c (print_objfile_statistics, dump_objfile)
2587         (maintenance_print_symbols): Use compunit_filetabs.
2588         * source.c (forget_cached_source_info_for_objfile): Use
2589         compunit_filetabs.
2590         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2591         (ALL_FILETABS): Use compunit_filetabs.
2592         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2593         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2594
2595 2019-01-09  Tom Tromey  <tom@tromey.com>
2596
2597         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2598         (compunit_filetabs): New.
2599         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2600         compunit_filetabs.
2601         (info_sources_command, make_source_files_completion_list): Remove
2602         declaration.
2603         * symmisc.c (print_objfile_statistics, dump_objfile)
2604         (maintenance_print_symbols): Remove declaration.
2605         (maintenance_info_symtabs): Use compunit_filetabs.
2606         (maintenance_info_line_tables): Likewise.
2607         * source.c (select_source_symtab): Change local variable name.
2608         (forget_cached_source_info_for_objfile): Remove declaration.
2609         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2610         * objfiles.c (objfile_relocate1): Remove declaration.
2611         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2612         declaration.
2613         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2614         * coffread.c (coff_symtab_read): Remove declaration.
2615         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2616         compunit_filetabs.
2617
2618 2019-01-09  Tom Tromey  <tom@tromey.com>
2619
2620         * symtab.c (lookup_objfile_from_block)
2621         (find_pc_sect_compunit_symtab, search_symbols)
2622         (default_collect_symbol_completion_matches_break_on): Use
2623         objfile_compunits.
2624         * objfiles.h (ALL_COMPUNITS): Remove.
2625         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2626         * cp-support.c (add_symbol_overload_list_qualified): Use
2627         objfile_compunits.
2628         * ada-lang.c (ada_collect_symbol_completion_matches)
2629         (ada_add_global_exceptions): Use objfile_compunits.
2630
2631 2019-01-09  Tom Tromey  <tom@tromey.com>
2632
2633         * source.c (select_source_symtab)
2634         (forget_cached_source_info_for_objfile): Remove declaration.
2635         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2636         declaration.
2637         * maint.c (count_symtabs_and_blocks): Remove declaration.
2638         * cp-support.c (add_symbol_overload_list_qualified): Remove
2639         declaration.
2640         * coffread.c (coff_symtab_read): Remove declaration.
2641         * symtab.c (lookup_symbol_in_objfile_symtabs)
2642         (basic_lookup_transparent_type_1): Use objfile_compunits.
2643         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2644         (info_sources_command, search_symbols)
2645         (default_collect_symbol_completion_matches_break_on)
2646         (make_source_files_completion_list): Remove declaration.
2647         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2648         (ada_collect_symbol_completion_matches)
2649         (ada_add_global_exceptions): Remove declaration.
2650         * linespec.c (iterate_over_all_matching_symtabs): Use
2651         objfile_compunits.
2652         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2653         (class objfile_compunits): New.
2654         (ALL_COMPUNITS): Use objfile_compunits.
2655         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2656         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2657         objfile_compunits.
2658         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2659
2660 2019-01-09  Tom Tromey  <tom@tromey.com>
2661
2662         * symtab.c (search_symbols)
2663         (default_collect_symbol_completion_matches_break_on): Use
2664         objfile_msymbols.
2665         * ada-lang.c (ada_lookup_simple_minsym)
2666         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2667         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2668         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2669         objfile_msymbols.
2670         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2671         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2672         * objc-lang.c (find_methods): Use objfile_msymbols.
2673         (info_selectors_command, info_classes_command): Likewise.
2674         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2675         * objfiles.h (class objfile_msymbols): New.
2676         (ALL_OBJFILE_MSYMBOLS): Remove.
2677         (ALL_MSYMBOLS): Remove.
2678
2679 2019-01-09  Tom Tromey  <tom@tromey.com>
2680
2681         * common/next-iterator.h (next_adapter): Add Iterator template
2682         parameter.
2683         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2684         (class all_objfiles_safe): New.
2685         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2686         * objfiles.c (put_objfile_before): Update comment.
2687         (add_separate_debug_objfile): Likewise.
2688         (free_all_objfiles): Use all_objfiles_safe.
2689         (objfile_purge_solibs): Likewise.
2690
2691 2019-01-09  Tom Tromey  <tom@tromey.com>
2692
2693         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2694         (expand_symtab_containing_pc, lookup_static_symbol)
2695         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2696         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2697         all_objfiles.
2698         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2699         * breakpoint.c (create_overlay_event_breakpoint)
2700         (create_longjmp_master_breakpoint)
2701         (create_std_terminate_master_breakpoint)
2702         (create_exception_master_breakpoint): Use all_objfiles.
2703         * linux-thread-db.c (try_thread_db_load_from_pdir)
2704         (has_libpthread): Use all_objfiles.
2705         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2706         * linespec.c (iterate_over_all_matching_symtabs)
2707         (search_minsyms_for_name): Use all_objfiles.
2708         * maint.c (maintenance_info_sections): Use all_objfiles.
2709         * main.c (captured_main_1): Use all_objfiles.
2710         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2711         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2712         * guile/scm-pretty-print.c
2713         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2714         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2715         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2716         (maintenance_print_msymbols): Use all_objfiles.
2717         * source.c (select_source_symtab): Use all_objfiles.
2718         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2719         * symfile.c (remove_symbol_file_command)
2720         (expand_symtabs_matching, map_symbol_filenames): Use
2721         all_objfiles.
2722         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2723         all_objfiles.
2724         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2725         * objc-lang.c (find_methods): Use all_objfiles.
2726         * objfiles.c (have_partial_symbols, have_full_symbols)
2727         (have_minimal_symbols, qsort_cmp)
2728         (default_iterate_over_objfiles_in_search_order): Use
2729         all_objfiles.
2730         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2731         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2732         (maintenance_check_psymtabs): Use all_objfiles.
2733         (ALL_PSYMTABS): Remove.
2734         * compile/compile-object-run.c (do_module_cleanup): Use
2735         all_objfiles.
2736         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2737         * cp-support.c (add_symbol_overload_list_qualified): Use
2738         all_objfiles.
2739         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2740         Use all_objfiles.
2741         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2742         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2743         all_objfiles.
2744         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2745         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2746         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2747         Uses all_objfiles.
2748         * solib.c (solib_read_symbols): Use all_objfiles
2749
2750 2019-01-09  Tom Tromey  <tom@tromey.com>
2751
2752         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2753         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2754         all_objfiles.
2755         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2756         * symmisc.c (print_symbol_bcache_statistics)
2757         (print_objfile_statistics, maintenance_print_objfiles)
2758         (maintenance_info_symtabs, maintenance_check_symtabs)
2759         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2760         all_objfiles.
2761         * source.c (forget_cached_source_info): Use all_objfiles.
2762         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2763         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2764         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2765         * objfiles.c (update_section_map): Use all_objfiles.
2766         (shared_objfile_contains_address_p): Likewise.
2767         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2768         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2769
2770 2019-01-09  Tom Tromey  <tom@tromey.com>
2771
2772         * common/next-iterator.h: New file.
2773         * objfiles.h (class all_objfiles): New.
2774         (struct objfile_iterator): New.
2775
2776 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2777
2778         * NEWS: Move the description of the changed "frame", "select-frame",
2779          and "info frame" commands to the Changed commands section.
2780
2781 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2782
2783         * gdbtypes.c (check_stub_method_group): Remove handling of old
2784         mangling schemes.
2785         * linespec.c (find_methods): Likewise.
2786         * stabsread.c (read_member_functions): Likewise.
2787         * valops.c (search_struct_method): Likewise.
2788         (value_struct_elt_for_reference): Likewise.
2789         * NEWS: Mention this change.
2790
2791 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2792
2793         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2794         print_source_lines.
2795         * source.c (print_source_lines_base): Update line number check.
2796         (print_source_lines): New function.
2797         (source_lines_range::source_lines_range): New function.
2798         * source.h (class source_lines_range): New class.
2799         (print_source_lines): New declaration.
2800
2801 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2802
2803         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2804
2805 2019-01-08  Tom Tromey  <tom@tromey.com>
2806             Simon Marchi  <simon.marchi@ericsson.com>
2807
2808         PR gdb/24060
2809         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2810         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2811         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2812         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2813         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2814         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2815
2816 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2817
2818         * source.c (select_source_symtab): Move header comment to
2819         declaration in source.h.
2820         (forget_cached_source_info_for_objfile): Likewise.
2821         (forget_cached_source_info): Likewise.
2822         (identify_source_line): Likewise.
2823         * source.h (identify_source_line): Move declaration from symtab.h
2824         and add comment from source.c
2825         (print_source_lines): Likewise.
2826         (forget_cached_source_info_for_objfile): Likewise.
2827         (forget_cached_source_info): Likewise.
2828         (select_source_symtab): Likewise.
2829         (enum print_source_lines_flag): Move definition from symtab.h.
2830         * symtab.h (identify_source_line): Move declaration to source.h.
2831         (print_source_lines): Likewise.
2832         (forget_cached_source_info_for_objfile): Likewise.
2833         (forget_cached_source_info): Likewise.
2834         (select_source_symtab): Likewise.
2835         (enum print_source_lines_flag): Move definition to source.h.
2836         * tui/tui-hooks.c: Add 'source.h' include.
2837
2838 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2839
2840         * source.c (print_source_lines_base): Handle requests to print
2841         reverse line number sequences, and guard against empty lines
2842         string.
2843
2844 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2845
2846         * source.c (print_source_lines_base): Fix skip of '\r' if next
2847         character is '\n'.
2848
2849 2019-01-06  Tom Tromey  <tom@tromey.com>
2850
2851         * c-exp.y (struct c_parse_state) <macro_original_text,
2852         expansion_obstack>: New member.
2853         (macro_original_text, expansion_obstack): Remove globals.
2854         (scan_macro_expansion, scanning_macro_expansion)
2855         (finished_macro_expansion): Update.
2856         (scan_macro_cleanup): Remove.
2857         (yylex, c_parse): Update.
2858
2859 2019-01-06  Tom Tromey  <tom@tromey.com>
2860
2861         * c-exp.y (struct c_parse_state) <strings>: New member.
2862         (operator_stoken): Update.
2863
2864 2019-01-06  Tom Tromey  <tom@tromey.com>
2865
2866         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2867         (union type_stack_elt) <typelist_val>: Now a pointer to
2868         std::vector.
2869         (type_stack_cleanup): Don't declare.
2870         (push_typelist): Update.
2871         * parse.c (pop_typelist): Return a std::vector.
2872         (push_typelist): Take a std::vector.
2873         (follow_types): Update.  Do not free args.
2874         (type_stack_cleanup): Remove.
2875         * c-exp.y (struct c_parse_state): New.
2876         (cpstate): New global.
2877         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2878         (nonempty_typelist): Update.
2879         (func_mod): Create a new vector.
2880         (c_parse): Create a c_parse_state.
2881         (check_parameter_typelist): Do not delete params.
2882         (function_method): Update.  Do not delete type_list.
2883
2884 2019-01-06  Tom Tromey  <tom@tromey.com>
2885
2886         PR gdb/28155:
2887         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2888         check_typedef.
2889         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2890         (print_return_value): Likewise.
2891
2892 2019-01-05  Tom Tromey  <tom@tromey.com>
2893
2894         * contrib/cleanup_check.py: Remove.
2895         * contrib/gcc-with-excheck: Remove.
2896         * contrib/exsummary.py: Remove.
2897         * contrib/excheck.py: Remove.
2898
2899 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2900
2901         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2902         NULL. Initialize tpprev to NULL instead of assigning it
2903         to NULL on the next statement.
2904         * windows-nat.c (windows_delete_thread): Remove check for
2905         main_thread_id before printing thread exit notifications.
2906         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2907         Remove thread ID check against main_thread_id.
2908         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2909         windows_delete_thread.
2910         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2911
2912 2019-01-04  Tom Tromey  <tom@tromey.com>
2913
2914         * compile/compile.c (_initialize_compile): Use upper case for
2915         metasyntactic variables.
2916         * symmisc.c (_initialize_symmisc): Use upper case for
2917         metasyntactic variables.
2918         * psymtab.c (_initialize_psymtab): Use upper case for
2919         metasyntactic variables.
2920         * demangle.c (demangle_command): Use upper case for metasyntactic
2921         variables.
2922         (_initialize_demangler): Likewise.
2923         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2924         variables.
2925
2926 2019-01-03  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2929
2930 2019-01-03  Tom Tromey  <tom@tromey.com>
2931
2932         * python/py-symtab.c (salpy_str): Update.
2933         (struct salpy_sal_object) <symtab>: Now a PyObject.
2934         (salpy_dealloc): Update.
2935         (del_objfile_sal): Use gdbpy_ref.
2936
2937 2019-01-03  Tom Tromey  <tom@tromey.com>
2938
2939         * python/py-type.c (convert_field): Use new_reference.  Return
2940         gdbpy_ref.
2941         (make_fielditem): Return gdbpy_ref.
2942         (typy_fields): Update.
2943         (typy_getitem): Update.
2944         (field_name): Return gdbpy_ref.  Use new_reference.
2945         (typy_iterator_iternext): Update.
2946
2947 2019-01-03  Tom Tromey  <tom@tromey.com>
2948
2949         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2950
2951 2019-01-03  Tom Tromey  <tom@tromey.com>
2952
2953         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2954         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2955         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2956         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2957         (pspy_set_type_printers): Likewise.
2958         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2959         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2960         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2961         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2962         (objfpy_set_type_printers): Likewise.
2963
2964 2019-01-03  Tom Tromey  <tom@tromey.com>
2965
2966         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2967         (gdbpy_print_stack): Use gdbpy_err_fetch.
2968         * python/python-internal.h (class gdbpy_err_fetch): New class.
2969         (class gdbpy_enter) <m_error_type, m_error_value,
2970         m_error_traceback>: Remove.
2971         <m_error>: New member.
2972         (gdbpy_exception_to_string): Don't declare.
2973         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2974         * python/py-value.c (convert_value_from_python): Use
2975         gdbpy_err_fetch.
2976         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2977         gdbpy_exception_to_string.
2978         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2979         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2980         gdbpy_err_fetch.
2981
2982 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2983
2984         * linux-nat.c (delete_lwp_cleanup): Delete.
2985         (struct lwp_deleter): New struct.
2986         (lwp_info_up): New typedef.
2987         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2988         lwp_info_up.
2989
2990 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * linux-fork.c (class scoped_switch_fork_info): New class.
2993         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2994
2995 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * valops.c (find_overload_match): Remove use of null_cleanup, and
2998         calls to do_cleanups.
2999
3000 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * compile/compile-cplus-types.c
3003         (compile_cplus_instance::decl_name): Handle changes to
3004         cp_func_name.
3005         * cp-support.c (cp_func_name): Update header comment, update
3006         return type.
3007         * cp-support.h (cp_func_name): Update return type in declaration.
3008         * valops.c (find_overload_match): Move temp_func local to top
3009         level of function and change its type.  Use temp_func to hold and
3010         delete temporary string obtained from cp_func_name.
3011
3012 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3015         gdb::char_vector, remove cleanup, and update uses of `msg`.
3016
3017 2019-01-03  Jim Wilson  <jimw@sifive.com>
3018
3019         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3020
3021 2019-01-02  Tom Tromey  <tom@tromey.com>
3022
3023         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3024         (tdesc_parse_xml): Remove cleanups.
3025         * target-descriptions.h (make_cleanup_free_target_description):
3026         Don't declare.
3027         (target_desc_deleter): New struct.
3028         (target_desc_up): New typedef.
3029         * target-descriptions.c (target_desc_deleter::operator()): Rename
3030         from free_target_description.
3031         (make_cleanup_free_target_description): Remove.
3032
3033 2019-01-02  Tom Tromey  <tom@tromey.com>
3034
3035         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3036         constructor, destructor.
3037         (linespec_parser): Remove typedef.
3038         (~linespec_parser): Rename from linespec_parser_delete.
3039         (linespec_lex_to_end, linespec_complete_label)
3040         (linespec_complete): Update.
3041         (decode_line_full): Remove cleanups.
3042         (decode_line_1): Update.
3043
3044 2019-01-02  Tom Tromey  <tom@tromey.com>
3045
3046         * python/python-internal.h (inferior_to_inferior_object): Change
3047         return type.
3048         * python/py-exitedevent.c (create_exited_event_object): Update.
3049         * python/py-inferior.c (inferior_to_inferior_object): Return
3050         gdbpy_ref.
3051         (python_new_inferior, python_inferior_deleted)
3052         (thread_to_thread_object, delete_thread_object)
3053         (build_inferior_list, gdbpy_selected_inferior): Update.
3054         * python/py-infthread.c (create_thread_object): Update.  Also fail
3055         if inferior_to_inferior_object fails.
3056
3057 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3058
3059         * inferior.h (class inferior) <displaced_step_state>: New field.
3060         * infrun.h (struct displaced_step_state): Move here from
3061         infrun.c.  Initialize fields, add constructor.
3062         <inf>: Remove field.
3063         <reset>: New method.
3064         * infrun.c (struct displaced_step_inferior_state): Move to
3065         infrun.h.
3066         (displaced_step_inferior_states): Remove.
3067         (get_displaced_stepping_state): Adust.
3068         (displaced_step_in_progress_any_inferior): Adjust.
3069         (displaced_step_in_progress_thread): Adjust.
3070         (displaced_step_in_progress): Adjust.
3071         (add_displaced_stepping_state): Remove.
3072         (get_displaced_step_closure_by_addr): Adjust.
3073         (remove_displaced_stepping_state): Remove.
3074         (infrun_inferior_exit): Call displaced_step_state.reset.
3075         (use_displaced_stepping): Don't check for NULL.
3076         (displaced_step_prepare_throw): Call
3077         get_displaced_stepping_state.
3078         (displaced_step_fixup): Don't check for NULL.
3079         (prepare_for_detach): Don't check for NULL.
3080
3081 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3082
3083         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3084          in case of call that did not complete.
3085
3086 2019-01-02  Andrey Utkin  <autkin@undo.io>
3087
3088         * symfile.c (find_separate_debug_file): Fix search of debug files for
3089         remote debuggee.
3090
3091 2019-01-02  Tom Tromey  <tom@tromey.com>
3092
3093         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3094         indentation.
3095         * python/py-frame.c (frapy_older): Remove cast.
3096         (frapy_newer): Likewise.
3097         * python/py-breakpoint.c (local_setattro): Remove cast.
3098         * python/py-arch.c (archpy_name): Remove local variable.
3099         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3100
3101 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3102
3103         * unittests/basic_string_view/element_access/char/empty.cc:
3104         Fix year range in copyright header.
3105
3106 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3107
3108         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3109         Delete.
3110         <operator==>: Update with for removed field.
3111         <hash>: Likewise.
3112         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3113         <isa_features>: ...this.
3114         <abi_features>: New field.
3115         (riscv_isa_flen): Update comment.
3116         (riscv_abi_xlen): New declaration.
3117         (riscv_abi_flen): New declaration.
3118         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3119         isa_features.
3120         (riscv_abi_xlen): New function.
3121         (riscv_isa_flen): Update to get answer from isa_features.
3122         (riscv_abi_flen): New function.
3123         (riscv_has_fp_abi): Update to get answer from abi_features.
3124         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3125         xlen and flen.
3126         (riscv_call_info) <xlen, flen>: Update comment.
3127         (riscv_call_arg_struct): Remove invalid assertions
3128         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3129         is removed.
3130         (riscv_gdbarch_init): Gather isa features and abi features
3131         separately, ensure both match on the gdbarch when reusing an old
3132         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3133         a target with 64-bit float hardware.
3134
3135 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3136
3137         * source.c (search_command_helper): Stop reverse search
3138         when line 1 has been searched.
3139
3140 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3141
3142         * record-full.c (record_full_base_target::close): Rewrite
3143         record_full_core_buf_list free logic.
3144
3145 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3146
3147         * break-catch-syscall.c (print_one_catch_syscall): xfree
3148         the last text.
3149
3150 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3151
3152         * top.c (print_gdb_version): Update Copyright year in version
3153         message.
3154
3155 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3156
3157         Update copyright year range in all GDB files.
3158
3159 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3160
3161         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3162
3163 For older changes see ChangeLog-2018.
3164 \f
3165 Local Variables:
3166 mode: change-log
3167 left-margin: 8
3168 fill-column: 74
3169 version-control: never
3170 coding: utf-8
3171 End:
3172