gdb/ChangeLog

   1 2019-02-05  Tom Tromey  <tom@tromey.com>
   2
   3         * target.c (target_stack::unpush): Move assertion earlier.
   4
   5 2019-01-30  Tom Tromey  <tom@tromey.com>
   6
   7         PR python/23615:
   8         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
   9         (gdbpy_parse_and_eval): Likewise.
  10         * python/python-internal.h (gdbpy_allow_threads): New class.
  11
  12 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
  13
  14         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
  15         (aarch64_fbsd_fpregmap): Move earlier.
  16         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
  17         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  18         instead of individual calls to trad_frame_set_reg_addr.
  19         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
  20         earlier.
  21         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
  22         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  23         instead of individual calls to trad_frame_set_reg_addr.
  24
  25 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
  26
  27         * CONTRIBUTE: Replace contribution list with wiki link.
  28
  29 2019-01-25  Tom Tromey  <tom@tromey.com>
  30
  31         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
  32
  33 2019-01-25  Tom Tromey  <tom@tromey.com>
  34
  35         * xtensa-linux-nat.c: Fix common/ includes.
  36         * xml-support.h: Fix common/ includes.
  37         * xml-support.c: Fix common/ includes.
  38         * x86-linux-nat.c: Fix common/ includes.
  39         * windows-nat.c: Fix common/ includes.
  40         * varobj.h: Fix common/ includes.
  41         * varobj.c: Fix common/ includes.
  42         * value.c: Fix common/ includes.
  43         * valops.c: Fix common/ includes.
  44         * utils.c: Fix common/ includes.
  45         * unittests/xml-utils-selftests.c: Fix common/ includes.
  46         * unittests/utils-selftests.c: Fix common/ includes.
  47         * unittests/unpack-selftests.c: Fix common/ includes.
  48         * unittests/tracepoint-selftests.c: Fix common/ includes.
  49         * unittests/style-selftests.c: Fix common/ includes.
  50         * unittests/string_view-selftests.c: Fix common/ includes.
  51         * unittests/scoped_restore-selftests.c: Fix common/ includes.
  52         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
  53         * unittests/scoped_fd-selftests.c: Fix common/ includes.
  54         * unittests/rsp-low-selftests.c: Fix common/ includes.
  55         * unittests/parse-connection-spec-selftests.c: Fix common/
  56         includes.
  57         * unittests/optional-selftests.c: Fix common/ includes.
  58         * unittests/offset-type-selftests.c: Fix common/ includes.
  59         * unittests/observable-selftests.c: Fix common/ includes.
  60         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
  61         * unittests/memrange-selftests.c: Fix common/ includes.
  62         * unittests/memory-map-selftests.c: Fix common/ includes.
  63         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
  64         * unittests/function-view-selftests.c: Fix common/ includes.
  65         * unittests/environ-selftests.c: Fix common/ includes.
  66         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
  67         * unittests/common-utils-selftests.c: Fix common/ includes.
  68         * unittests/cli-utils-selftests.c: Fix common/ includes.
  69         * unittests/array-view-selftests.c: Fix common/ includes.
  70         * ui-file.c: Fix common/ includes.
  71         * tui/tui-io.c: Fix common/ includes.
  72         * tracepoint.h: Fix common/ includes.
  73         * tracepoint.c: Fix common/ includes.
  74         * tracefile-tfile.c: Fix common/ includes.
  75         * top.h: Fix common/ includes.
  76         * top.c: Fix common/ includes.
  77         * thread.c: Fix common/ includes.
  78         * target/waitstatus.h: Fix common/ includes.
  79         * target/waitstatus.c: Fix common/ includes.
  80         * target.h: Fix common/ includes.
  81         * target.c: Fix common/ includes.
  82         * target-memory.c: Fix common/ includes.
  83         * target-descriptions.c: Fix common/ includes.
  84         * symtab.h: Fix common/ includes.
  85         * symfile.c: Fix common/ includes.
  86         * stap-probe.c: Fix common/ includes.
  87         * spu-linux-nat.c: Fix common/ includes.
  88         * sparc-nat.c: Fix common/ includes.
  89         * source.c: Fix common/ includes.
  90         * solib.c: Fix common/ includes.
  91         * solib-target.c: Fix common/ includes.
  92         * ser-unix.c: Fix common/ includes.
  93         * ser-tcp.c: Fix common/ includes.
  94         * ser-pipe.c: Fix common/ includes.
  95         * ser-base.c: Fix common/ includes.
  96         * selftest-arch.c: Fix common/ includes.
  97         * s12z-tdep.c: Fix common/ includes.
  98         * rust-exp.y: Fix common/ includes.
  99         * rs6000-aix-tdep.c: Fix common/ includes.
 100         * riscv-tdep.c: Fix common/ includes.
 101         * remote.c: Fix common/ includes.
 102         * remote-notif.h: Fix common/ includes.
 103         * remote-fileio.h: Fix common/ includes.
 104         * remote-fileio.c: Fix common/ includes.
 105         * regcache.h: Fix common/ includes.
 106         * regcache.c: Fix common/ includes.
 107         * record-btrace.c: Fix common/ includes.
 108         * python/python.c: Fix common/ includes.
 109         * python/py-type.c: Fix common/ includes.
 110         * python/py-inferior.c: Fix common/ includes.
 111         * progspace.h: Fix common/ includes.
 112         * producer.c: Fix common/ includes.
 113         * procfs.c: Fix common/ includes.
 114         * proc-api.c: Fix common/ includes.
 115         * printcmd.c: Fix common/ includes.
 116         * ppc-linux-nat.c: Fix common/ includes.
 117         * parser-defs.h: Fix common/ includes.
 118         * osdata.c: Fix common/ includes.
 119         * obsd-nat.c: Fix common/ includes.
 120         * nat/x86-linux.c: Fix common/ includes.
 121         * nat/x86-linux-dregs.c: Fix common/ includes.
 122         * nat/x86-dregs.h: Fix common/ includes.
 123         * nat/x86-dregs.c: Fix common/ includes.
 124         * nat/ppc-linux.c: Fix common/ includes.
 125         * nat/mips-linux-watch.h: Fix common/ includes.
 126         * nat/mips-linux-watch.c: Fix common/ includes.
 127         * nat/linux-waitpid.c: Fix common/ includes.
 128         * nat/linux-ptrace.h: Fix common/ includes.
 129         * nat/linux-ptrace.c: Fix common/ includes.
 130         * nat/linux-procfs.c: Fix common/ includes.
 131         * nat/linux-personality.c: Fix common/ includes.
 132         * nat/linux-osdata.c: Fix common/ includes.
 133         * nat/linux-namespaces.c: Fix common/ includes.
 134         * nat/linux-btrace.h: Fix common/ includes.
 135         * nat/linux-btrace.c: Fix common/ includes.
 136         * nat/fork-inferior.c: Fix common/ includes.
 137         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 138         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 139         * nat/aarch64-linux.c: Fix common/ includes.
 140         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 141         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 142         * namespace.h: Fix common/ includes.
 143         * mips-linux-tdep.c: Fix common/ includes.
 144         * minsyms.c: Fix common/ includes.
 145         * mi/mi-parse.h: Fix common/ includes.
 146         * mi/mi-main.c: Fix common/ includes.
 147         * mi/mi-cmd-env.c: Fix common/ includes.
 148         * memrange.h: Fix common/ includes.
 149         * memattr.c: Fix common/ includes.
 150         * maint.h: Fix common/ includes.
 151         * maint.c: Fix common/ includes.
 152         * main.c: Fix common/ includes.
 153         * machoread.c: Fix common/ includes.
 154         * location.c: Fix common/ includes.
 155         * linux-thread-db.c: Fix common/ includes.
 156         * linux-nat.c: Fix common/ includes.
 157         * linux-fork.c: Fix common/ includes.
 158         * inline-frame.c: Fix common/ includes.
 159         * infrun.c: Fix common/ includes.
 160         * inflow.c: Fix common/ includes.
 161         * inferior.h: Fix common/ includes.
 162         * inferior.c: Fix common/ includes.
 163         * infcmd.c: Fix common/ includes.
 164         * inf-ptrace.c: Fix common/ includes.
 165         * inf-child.c: Fix common/ includes.
 166         * ia64-linux-nat.c: Fix common/ includes.
 167         * i387-tdep.c: Fix common/ includes.
 168         * i386-tdep.c: Fix common/ includes.
 169         * i386-linux-tdep.c: Fix common/ includes.
 170         * i386-linux-nat.c: Fix common/ includes.
 171         * i386-go32-tdep.c: Fix common/ includes.
 172         * i386-fbsd-tdep.c: Fix common/ includes.
 173         * i386-fbsd-nat.c: Fix common/ includes.
 174         * guile/scm-type.c: Fix common/ includes.
 175         * guile/guile.c: Fix common/ includes.
 176         * go32-nat.c: Fix common/ includes.
 177         * gnu-nat.c: Fix common/ includes.
 178         * gdbthread.h: Fix common/ includes.
 179         * gdbarch-selftests.c: Fix common/ includes.
 180         * gdb_usleep.c: Fix common/ includes.
 181         * gdb_select.h: Fix common/ includes.
 182         * gdb_bfd.c: Fix common/ includes.
 183         * gcore.c: Fix common/ includes.
 184         * fork-child.c: Fix common/ includes.
 185         * findvar.c: Fix common/ includes.
 186         * fbsd-nat.c: Fix common/ includes.
 187         * event-top.c: Fix common/ includes.
 188         * event-loop.c: Fix common/ includes.
 189         * dwarf2read.c: Fix common/ includes.
 190         * dwarf2loc.c: Fix common/ includes.
 191         * dwarf2-frame.c: Fix common/ includes.
 192         * dwarf-index-cache.c: Fix common/ includes.
 193         * dtrace-probe.c: Fix common/ includes.
 194         * disasm-selftests.c: Fix common/ includes.
 195         * defs.h: Fix common/ includes.
 196         * csky-tdep.c: Fix common/ includes.
 197         * cp-valprint.c: Fix common/ includes.
 198         * cp-support.h: Fix common/ includes.
 199         * cp-support.c: Fix common/ includes.
 200         * corelow.c: Fix common/ includes.
 201         * completer.h: Fix common/ includes.
 202         * completer.c: Fix common/ includes.
 203         * compile/compile.c: Fix common/ includes.
 204         * compile/compile-loc2c.c: Fix common/ includes.
 205         * compile/compile-cplus-types.c: Fix common/ includes.
 206         * compile/compile-cplus-symbols.c: Fix common/ includes.
 207         * command.h: Fix common/ includes.
 208         * cli/cli-dump.c: Fix common/ includes.
 209         * cli/cli-cmds.c: Fix common/ includes.
 210         * charset.c: Fix common/ includes.
 211         * build-id.c: Fix common/ includes.
 212         * btrace.h: Fix common/ includes.
 213         * btrace.c: Fix common/ includes.
 214         * breakpoint.h: Fix common/ includes.
 215         * breakpoint.c: Fix common/ includes.
 216         * ax.h:
 217         (enum agent_op): Fix common/ includes.
 218         * ax-general.c (struct aop_map): Fix common/ includes.
 219         * ax-gdb.c: Fix common/ includes.
 220         * auxv.c: Fix common/ includes.
 221         * auto-load.c: Fix common/ includes.
 222         * arm-tdep.c: Fix common/ includes.
 223         * arch/riscv.c: Fix common/ includes.
 224         * arch/ppc-linux-common.c: Fix common/ includes.
 225         * arch/i386.c: Fix common/ includes.
 226         * arch/arm.c: Fix common/ includes.
 227         * arch/arm-linux.c: Fix common/ includes.
 228         * arch/arm-get-next-pcs.c: Fix common/ includes.
 229         * arch/amd64.c: Fix common/ includes.
 230         * arch/aarch64.c: Fix common/ includes.
 231         * arch/aarch64-insn.c: Fix common/ includes.
 232         * arch-utils.c: Fix common/ includes.
 233         * amd64-windows-tdep.c: Fix common/ includes.
 234         * amd64-tdep.c: Fix common/ includes.
 235         * amd64-sol2-tdep.c: Fix common/ includes.
 236         * amd64-obsd-tdep.c: Fix common/ includes.
 237         * amd64-nbsd-tdep.c: Fix common/ includes.
 238         * amd64-linux-tdep.c: Fix common/ includes.
 239         * amd64-linux-nat.c: Fix common/ includes.
 240         * amd64-fbsd-tdep.c: Fix common/ includes.
 241         * amd64-fbsd-nat.c: Fix common/ includes.
 242         * amd64-dicos-tdep.c: Fix common/ includes.
 243         * amd64-darwin-tdep.c: Fix common/ includes.
 244         * agent.c: Fix common/ includes.
 245         * ada-lang.h: Fix common/ includes.
 246         * ada-lang.c: Fix common/ includes.
 247         * aarch64-tdep.c: Fix common/ includes.
 248
 249 2019-01-25  Tom Tromey  <tom@tromey.com>
 250
 251         * common/create-version.sh: Use common/version.h.
 252
 253 2019-01-24  Pedro Alves  <palves@redhat.com>
 254
 255         * infrun.c (signal_stop, signal_print, signal_program)
 256         (signal_catch, signal_pass): Now arrays instead of pointers.
 257         (update_signals_program_target, do_target_resume)
 258         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 259         * linux-nat.c (linux_nat_target::pass_signals)
 260         (linux_nat_target::create_inferior, linux_nat_target::attach):
 261         Adjust.
 262         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 263         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 264         * procfs.c (procfs_target::pass_signals): Adjust.
 265         * record-full.c (record_full_target::resume): Adjust.
 266         * remote.c (remote_target::pass_signals)
 267         (remote_target::program_signals): Adjust.
 268         * target-debug.h (target_debug_print_signals): Now takes a
 269         gdb::array_view as parameter.  Adjust.
 270         * target.h (target_ops) <pass_signals, program_signals>: Replace
 271         pointer and length parameters with gdb::array_view.
 272         (target_pass_signals, target_program_signals): Likewise.
 273         * target-delegates.c: Regenerate.
 274
 275 2019-01-24  Pedro Alves  <palves@redhat.com>
 276
 277         * common/forward-scope-exit.h
 278         (forward_scope_exit::forward_scope_exit): Pass arguments to
 279         m_bind_function directly, instead of creating a std::bind and
 280         copying that.
 281
 282 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 283
 284         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 285         for static members.
 286         (pass_in_v_vfp_candidate): Likewise.
 287
 288 2019-01-23  Tom Tromey  <tom@tromey.com>
 289             Pedro Alves  <palves@redhat.com>
 290
 291         * regcache.c (class regcache_invalidator): Remove.
 292         (regcache::raw_write): Use make_scope_exit.
 293
 294 2019-01-23  Tom Tromey  <tom@tromey.com>
 295
 296         * ui-out.h (class ui_out_emit_type): Update comment.
 297
 298 2019-01-23  Tom Tromey  <tom@tromey.com>
 299
 300         * infrun.c (fetch_inferior_event): Update comment.
 301
 302 2019-01-23  Tom Tromey  <tom@tromey.com>
 303             Pedro Alves  <palves@redhat.com>
 304
 305         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 306         parameter.
 307         (fetch_inferior_event): Use SCOPE_EXIT.
 308
 309
 310 2019-01-23  Tom Tromey  <tom@tromey.com>
 311             Pedro Alves  <palves@redhat.com>
 312
 313         * infrun.c (disable_thread_events): Delete.
 314         (stop_all_threads): Use SCOPE_EXIT.
 315
 316 2019-01-23  Tom Tromey  <tom@tromey.com>
 317             Pedro Alves  <palves@redhat.com>
 318
 319         * symfile.c: Include forward-scope-exit.h.
 320         (clear_symtab_users_cleanup): Replace forward declaration with
 321         a FORWARD_SCOPE_EXIT.
 322         (syms_from_objfile_1): Use the forward_scope_exit and
 323         gdb::optional instead of cleanup_function.
 324         (reread_symbols): Use the forward_scope_exit instead of
 325         cleanup_function.
 326         (clear_symtab_users_cleanup): Remove function.
 327
 328 2019-01-23  Tom Tromey  <tom@tromey.com>
 329             Pedro Alves  <palves@redhat.com>
 330
 331         * linux-nat.c: Include scope-exit.h.
 332         (cleanup_target_stop): Remove.
 333         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 334         SCOPE_EXIT.
 335
 336 2019-01-23  Tom Tromey  <tom@tromey.com>
 337             Pedro Alves  <palves@redhat.com>
 338
 339         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 340         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 341
 342 2019-01-23  Tom Tromey  <tom@tromey.com>
 343             Andrew Burgess  <andrew.burgess@embecosm.com>
 344             Pedro Alves  <palves@redhat.com>
 345
 346         * infrun.c (fetch_inferior_event): Use scope_exit.
 347         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 348         * top.c (execute_command): Use scope_exit.
 349         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 350         * utils.c (do_bpstat_clear_actions_cleanup)
 351         (make_bpstat_clear_actions_cleanup): Remove.
 352
 353 2019-01-23  Tom Tromey  <tom@tromey.com>
 354             Pedro Alves  <palves@redhat.com>
 355
 356         * infrun.c: Include "common/scope-exit.h"
 357         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 358         (wait_for_inferior): Use SCOPE_EXIT.
 359         (fetch_inferior_event): Use scope_exit.
 360
 361 2019-01-23  Tom Tromey  <tom@tromey.com>
 362             Pedro Alves  <palves@redhat.com>
 363
 364         * breakpoint.c (create_breakpoint): Remove cleanup.
 365
 366 2019-01-23  Tom Tromey  <tom@tromey.com>
 367             Andrew Burgess  <andrew.burgess@embecosm.com>
 368             Pedro Alves  <palves@redhat.com>
 369
 370 2019-01-23  Pedro Alves  <palves@redhat.com>
 371
 372         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 373
 374 2019-01-23  Pedro Alves  <palves@redhat.com>
 375             Andrew Burgess  <andrew.burgess@embecosm.com>
 376
 377         * gdbthread.h: Include "common/forward-scope-exit.h".
 378         (scoped_finish_thread_state): Redefine custom class in terms of
 379         forward_scope_exit.
 380
 381 2019-01-23  Pedro Alves  <palves@redhat.com>
 382             Andrew Burgess  <andrew.burgess@embecosm.com>
 383
 384         * common/forward-scope-exit.h: New file.
 385
 386 2019-01-23  Pedro Alves  <palves@redhat.com>
 387             Andrew Burgess  <andrew.burgess@embecosm.com>
 388             Tom Tromey  <tom@tromey.com>
 389
 390         * common/scope-exit.h: New file.
 391
 392 2019-01-23  Pedro Alves  <palves@redhat.com>
 393
 394         * common/preprocessor.h (ESC): Rename to ...
 395         (ESC_PARENS): ... this.
 396         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 397         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 398
 399 2019-01-23  Tom Tromey  <tom@tromey.com>
 400
 401         * language.h (class scoped_switch_to_sym_language_if_auto):
 402         Initialize m_lang in both cases.
 403
 404 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 405
 406         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 407         with XCNEW.
 408
 409 2019-01-22  Tom Tromey  <tom@tromey.com>
 410
 411         * corelow.c: Do not include sys/file.h.
 412
 413 2019-01-22  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-wingeneral.h: Include gdb_curses.h.
 416
 417 2019-01-22  Tom Tromey  <tom@tromey.com>
 418
 419         * source-cache.h (class source_cache) <get_source_lines,
 420         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 421
 422 2019-01-22  Tom Tromey  <tom@tromey.com>
 423
 424         * remote-fileio.h (struct remote_target): Declare.
 425
 426 2019-01-22  Tom Tromey  <tom@tromey.com>
 427
 428         * python/py-arch.c: Do not include py-ref.h.
 429         * python/py-bpevent.c: Do not include py-ref.h.
 430         * python/py-cmd.c: Do not include py-ref.h.
 431         * python/py-continueevent.c: Do not include py-ref.h.
 432         * python/py-event.h: Do not include py-ref.h.
 433         * python/py-evtregistry.c: Do not include py-ref.h.
 434         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 435         * python/py-frame.c: Do not include py-ref.h.
 436         * python/py-framefilter.c: Do not include py-ref.h.
 437         * python/py-function.c: Do not include py-ref.h.
 438         * python/py-infevents.c: Do not include py-ref.h.
 439         * python/py-linetable.c: Do not include py-ref.h.
 440         * python/py-objfile.c: Do not include py-ref.h.
 441         * python/py-param.c: Do not include py-ref.h.
 442         * python/py-prettyprint.c: Do not include py-ref.h.
 443         * python/py-progspace.c: Do not include py-ref.h.
 444         * python/py-symbol.c: Do not include py-ref.h.
 445         * python/py-symtab.c: Do not include py-ref.h.
 446         * python/py-type.c: Do not include py-ref.h.
 447         * python/py-unwind.c: Do not include py-ref.h.
 448         * python/py-utils.c: Do not include py-ref.h.
 449         * python/py-value.c: Do not include py-ref.h.
 450         * python/py-varobj.c: Do not include py-ref.h.
 451         * python/py-xmethods.c: Do not include py-ref.h.
 452         * python/python.c: Do not include py-ref.h.
 453         * varobj.c: Do not include py-ref.h.
 454
 455 2019-01-22  Tom Tromey  <tom@tromey.com>
 456
 457         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 458         keyword for bcache.
 459
 460 2019-01-22  Tom Tromey  <tom@tromey.com>
 461
 462         * compile/compile-cplus-types.c: Remove a comment by #include.
 463
 464 2019-01-22  Tom Tromey  <tom@tromey.com>
 465
 466         * compile/gcc-c-plugin.h: Include compile-internal.h.
 467
 468 2019-01-22  Tom Tromey  <tom@tromey.com>
 469
 470         * stabsread.c (EXTERN): Do not define.
 471         (symnum, next_symbol_text_func, processing_gcc_compilation)
 472         (within_function, global_sym_chain, global_stabs)
 473         (previous_stab_code, this_object_header_files)
 474         (n_this_object_header_files)
 475         (n_allocated_this_object_header_files): Define.
 476         * stabsread.h (EXTERN): Never define.  Use "extern".
 477
 478 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 479
 480         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 481         history_value.
 482
 483 2019-01-21  Tom Tromey  <tom@tromey.com>
 484
 485         * ui-out.c: Fix includes.
 486         * tui/tui-source.c: Fix includes.
 487         * target.c: Fix includes.
 488         * remote.c: Fix includes.
 489         * regcache.c: Fix includes.
 490         * python/py-block.c: Fix includes.
 491         * printcmd.c: Fix includes.
 492         * or1k-tdep.c: Fix includes.
 493         * mi/mi-main.c: Fix includes.
 494         * m32r-tdep.c: Fix includes.
 495         * csky-tdep.c: Fix includes.
 496         * compile/compile-cplus-types.c: Fix includes.
 497         * cli/cli-interp.c: Fix includes.
 498
 499 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 500
 501         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 502         for padding.
 503
 504 2019-01-16  Tom Tromey  <tom@tromey.com>
 505
 506         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 507         earlier.
 508         (struct objfile) <msymbols_range>: Move from top level.
 509         <msymbols>: New method.
 510         (class objfile_msymbols): Remove.
 511         * symtab.c (default_collect_symbol_completion_matches_break_on):
 512         Update.
 513         * symmisc.c (dump_msymbols): Update.
 514         * stabsread.c (scan_file_globals): Update.
 515         * objc-lang.c (info_selectors_command, info_classes_command)
 516         (find_methods): Update.
 517         * minsyms.c (find_solib_trampoline_target): Update.
 518         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 519         * coffread.c (coff_symfile_read): Update.
 520         * ada-lang.c (ada_lookup_simple_minsym)
 521         (ada_collect_symbol_completion_matches): Update.
 522
 523 2019-01-16  Tom Tromey  <tom@tromey.com>
 524
 525         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 526         type.  Remove no-argument constructor.
 527         <iterator::operator++>: Simplify.
 528         <begin>: Update.
 529         <end>: Use minimal_symbol_count.
 530
 531 2019-01-16  Tom Tromey  <tom@tromey.com>
 532
 533         * objfiles.h (struct objfile) <psymtabs>: New method.
 534         (class objfile_psymtabs): Remove.
 535         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 536         typedef.
 537         <range>: New method.
 538         (require_partial_symbols): Change return type.
 539         * psymtab.c (require_partial_symbols)
 540         (psym_expand_symtabs_matching): Update.
 541         * mdebugread.c (parse_partial_symbols): Update.
 542         * dbxread.c (dbx_end_psymtab): Update.
 543
 544 2019-01-15  Tom Tromey  <tom@tromey.com>
 545
 546         * symtab.c (lookup_objfile_from_block)
 547         (lookup_symbol_in_objfile_symtabs)
 548         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 549         (find_line_symtab, info_sources_command)
 550         (default_collect_symbol_completion_matches_break_on)
 551         (make_source_files_completion_list): Update.
 552         * symmisc.c (print_objfile_statistics, dump_objfile)
 553         (maintenance_print_symbols, maintenance_info_symtabs)
 554         (maintenance_check_symtabs, maintenance_info_line_tables):
 555         Update.
 556         * source.c (select_source_symtab)
 557         (forget_cached_source_info_for_objfile): Update.
 558         * objfiles.h (class objfile_compunits): Remove.
 559         (struct objfile) <compunits_range>: New typedef.
 560         (compunits): New method.
 561         * objfiles.c (objfile_relocate1): Update.
 562         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 563         * maint.c (count_symtabs_and_blocks): Update.
 564         * linespec.c (iterate_over_all_matching_symtabs): Update.
 565         * cp-support.c (add_symbol_overload_list_qualified): Update.
 566         * coffread.c (coff_symtab_read): Update.
 567         * ada-lang.c (add_nonlocal_symbols)
 568         (ada_collect_symbol_completion_matches)
 569         (ada_add_global_exceptions): Update.
 570
 571 2019-01-15  Tom Tromey  <tom@tromey.com>
 572
 573         * progspace.h (program_space) <objfiles_safe_range>: New
 574         typedef.
 575         <objfiles_safe>: New method.
 576         * objfiles.h (class all_objfiles_safe): Remove.
 577         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 578         * jit.c (jit_inferior_exit_hook): Update.
 579
 580 2019-01-17  Tom Tromey  <tom@tromey.com>
 581
 582         * progspace.h (program_space) <objfiles_range>: New typedef.
 583         <objfiles>: New method.
 584         <objfiles_head>: Rename from objfiles.
 585         (object_files): Update.
 586         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 587         * guile/scm-pretty-print.c
 588         (ppscm_find_pretty_printer_from_objfiles): Update.
 589         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 590         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 591         Update.
 592         * python/py-progspace.c (pspy_get_objfiles): Update.
 593         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 594         Update.
 595         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 596         (objfpy_lookup_objfile_by_build_id): Update.
 597         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 598         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 599         Update.
 600         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 601         (expand_symtab_containing_pc, lookup_objfile_from_block)
 602         (lookup_static_symbol, basic_lookup_transparent_type)
 603         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 604         (find_line_symtab, info_sources_command)
 605         (default_collect_symbol_completion_matches_break_on)
 606         (make_source_files_completion_list, find_main_name): Update.
 607         * symmisc.c (print_symbol_bcache_statistics)
 608         (print_objfile_statistics, maintenance_print_symbols)
 609         (maintenance_print_msymbols, maintenance_print_objfiles)
 610         (maintenance_info_symtabs, maintenance_check_symtabs)
 611         (maintenance_expand_symtabs, maintenance_info_line_tables):
 612         Update.
 613         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 614         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 615         (map_overlay_command, unmap_overlay_command)
 616         (simple_overlay_update, expand_symtabs_matching)
 617         (map_symbol_filenames): Update.
 618         * symfile-debug.c (set_debug_symfile): Update.
 619         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 620         Update.
 621         * source.c (select_source_symtab, forget_cached_source_info):
 622         Update.
 623         * solib.c (solib_read_symbols): Update.
 624         * solib-spu.c (append_ocl_sos): Update.
 625         * psymtab.c (maintenance_print_psymbols)
 626         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 627         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 628         * printcmd.c (info_symbol_command): Update.
 629         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 630         Update.
 631         * objfiles.h (class all_objfiles): Remove.
 632         * objfiles.c (have_partial_symbols, have_full_symbols)
 633         (have_minimal_symbols, qsort_cmp, update_section_map)
 634         (shared_objfile_contains_address_p)
 635         (default_iterate_over_objfiles_in_search_order): Update.
 636         * objc-lang.c (info_selectors_command, info_classes_command)
 637         (find_methods): Update.
 638         * minsyms.c (find_solib_trampoline_target): Update.
 639         * maint.c (maintenance_info_sections)
 640         (maintenance_translate_address, count_symtabs_and_blocks):
 641         Update.
 642         * main.c (captured_main_1): Update.
 643         * linux-thread-db.c (try_thread_db_load_from_pdir)
 644         (has_libpthread): Update.
 645         * linespec.c (iterate_over_all_matching_symtabs)
 646         (search_minsyms_for_name): Update.
 647         * jit.c (jit_find_objf_with_entry_addr): Update.
 648         * hppa-tdep.c (find_unwind_entry)
 649         (hppa_lookup_stub_minimal_symbol): Update.
 650         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 651         Update.
 652         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 653         (elf_gnu_ifunc_resolve_by_got): Update.
 654         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 655         * dwarf-index-write.c (save_gdb_index_command): Update.
 656         * cp-support.c (add_symbol_overload_list_qualified): Update.
 657         * breakpoint.c (create_overlay_event_breakpoint)
 658         (create_longjmp_master_breakpoint)
 659         (create_std_terminate_master_breakpoint)
 660         (create_exception_master_breakpoint): Update.
 661         * blockframe.c (find_pc_partial_function): Update.
 662         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 663         (ada_collect_symbol_completion_matches)
 664         (ada_add_global_exceptions): Update.
 665
 666 2019-01-17  Tom Tromey  <tom@tromey.com>
 667
 668         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 669         declare VEC.
 670         (solib_target_parse_libraries): Change return type.
 671         (library_list_start_segment, library_list_start_section)
 672         (library_list_end_library, library_list_start_library); Update.
 673         (solib_target_free_library_list): Remove.
 674         (solib_target_parse_libraries): Remove cleanup.  Change return
 675         type.
 676         (solib_target_current_sos): Update.
 677
 678 2019-01-17  Tom Tromey  <tromey@bapiya>
 679
 680         * valprint.c: Replace "the the" with "the".
 681         * symtab.c: Replace "the the" with "the".
 682         * solib.c: Replace "the the" with "the".
 683         * solib-dsbt.c: Replace "the the" with "the".
 684         * linespec.c: Replace "the the" with "the".
 685         * dwarf2loc.h: Replace "the the" with "the".
 686         * amd64-windows-tdep.c: Replace "the the" with "the".
 687         * aarch64-tdep.c: Replace "the the" with "the".
 688
 689 2019-01-16  Keith Seitz  <keiths@redhat.com>
 690
 691         PR gdb/23773
 692         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 693         <builder>: Rename to ..
 694         <m_builder>: ... this and make private.
 695         (dwarf2_cu::get_builder): New method.  Change all users of
 696         `builder' to use this method.
 697         (dwarf2_start_symtab): Move to ...
 698         (dwarf2_cu::start_symtab): ... here.  Update all callers
 699         (setup_type_unit_groups): Move to ...
 700         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 701         callers.
 702         (dwarf2_cu::reset_builder): New method.
 703         (process_full_compunit, process_full_type_unit): Use
 704         dwarf2_cu::reset_builder.
 705         (follow_die_offset): Record the ancestor CU if it is different
 706         from the followed DIE's CU.
 707         (follow_die_sig_1): Likewise.
 708
 709 2019-01-15  Tom Tromey  <tom@tromey.com>
 710
 711         * remote.c (class remote_state) <buf>: Now a char_vector.
 712         <buf_size>: Remove.
 713         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 714         parameter.
 715         (remote_target::getpkt_or_notif_sane_1)
 716         (remote_target::getpkt_sane)
 717         (remote_target::getpkt_or_notif_sane): Likewise.
 718         (class remote_target) <putpkt>: New overload.
 719         (remote_target::read_frame): Change type of "buf_p".  Remove
 720         sizeof_p parameter.
 721         (packet_ok): New overload.
 722         (packet_check_result): New overload.
 723         Update all uses.
 724
 725 2019-01-14  Tom Tromey  <tom@tromey.com>
 726
 727         * remote-notif.c (handle_notification, remote_notif_ack)
 728         (remote_notif_parse): Make "buf" const.
 729         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 730         const.
 731         (remote_notif_parse, remote_notif_ack, handle_notification):
 732         Likewise.
 733         * remote.c (remote_notif_stop_parse): Make "buf" const.
 734         (remote_target::remote_parse_stop_reply): Make "buf" const.
 735         (remote_notif_stop_ack): Make "buf" const.
 736
 737 2019-01-14  Tom Tromey  <tom@tromey.com>
 738
 739         * remote.c (remote_console_output): Make parameter const.
 740
 741 2019-01-14  Tom Tromey  <tom@tromey.com>
 742
 743         * target-debug.h (target_debug_print_signals): Constify.
 744         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 745         * procfs.c (procfs_target::pass_signals): Update.
 746         * linux-nat.c (linux_nat_target::pass_signals): Update.
 747         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 748         * target-delegates.c: Rebuild.
 749         * remote.c (remote_target::program_signals): Update.
 750         (remote_target::pass_signals): Update.
 751         * target.c (target_pass_signals): Constify argument.
 752         (target_program_signals): Likewise.
 753         * target.h (struct target_ops) <pass_signals, program_signals>:
 754         Constify argument.
 755         (target_pass_signals, target_program_signals): Constify argument.
 756
 757 2019-01-14  Tom Tromey  <tom@tromey.com>
 758
 759         PR tui/28819:
 760         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 761
 762 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 763
 764         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 765         field.
 766         * rs6000-tdep.c: Include reggroups.h.
 767         (IS_V_ALIAS_PSEUDOREG): Define.
 768         (rs6000_register_name): Return names for the "vX" aliases.
 769         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 770         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 771         aliases.  Call default_register_reggroup_p for all other
 772         pseudo-registers.
 773         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 774         New functions.
 775         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 776         Handle "vX" aliases.
 777         (v_alias_pseudo_register_collect): New function.
 778         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 779         (rs6000_gdbarch_init): Initialize "vX" aliases as
 780         pseudo-registers.  Restore registration of
 781         rs6000_pseudo_register_reggroup_p with
 782         set_tdesc_pseudo_register_reggroup_p.
 783
 784 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 785
 786         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 787         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 788         set_gdbarch_num_pseudo_regs.
 789
 790 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 791
 792         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 793         Remove arg prefixname, add do_set and do_show.
 794         Add member functions set_list and show_list.
 795         * cli/cli-style.c (class cli_style_option): Update accordingly.
 796         (style_set_list): Move to file scope.
 797         (style_show_list): Likewise.
 798         (set_style): Call help_list.
 799         (show_style): Call cmd_show_list.
 800         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 801         Update to use the new macro.
 802
 803 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 804
 805         * ada-lang.c (_initialize_ada_language): Expand the help text
 806         for the "catch exception" command.
 807
 808 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 809
 810         * symtab.c (matching_obj_sections): Initialize obj,
 811         declare it closer to its usage.
 812
 813 2019-01-10  Tom Tromey  <tom@tromey.com>
 814
 815         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 816         (basic_inf_threads_range): Remove.
 817         (inf_threads_range, inf_non_exited_threads_range)
 818         (safe_inf_threads_range): Use next_adapter.
 819
 820 2019-01-10  Keith Seitz  <keiths@redhat.com>
 821
 822         PR gdb/23712
 823         PR symtab/23010
 824         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 825         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 826
 827 2019-01-10  Keith Seitz  <keiths@redhat.com>
 828
 829         PR gdb/23712
 830         PR symtab/23010
 831         * dictionary.c (pending_to_vector): Remove.
 832         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 833         Remove _1 suffix, replacing functions of the same name.  Update
 834         all callers.
 835         (dict_create_hashed, dict_create_hashed_expandable)
 836         (dict_create_linear, dict_create_linear_expandable, dict_free)
 837         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 838         Make functions static.
 839
 840 2019-01-10  Keith Seitz  <keiths@redhat.com>
 841
 842         PR gdb/23712
 843         PR symtab/23010
 844         * dictionary.h (struct dictionary): Replace declaration with
 845         multidictionary.
 846         (dict_create_hashed, dict_create_hashed_expandable)
 847         (dict_create_linear, dict_create_linear_expandable)
 848         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 849         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 850         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 851         taking multidictionary argument.
 852         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 853         * block.h (struct block) <dict>: Change to multidictionary
 854         and rename `multidict'.
 855         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 856         symmisc.c: Update all dictionary references to multidictionary.
 857
 858 2019-01-10  Keith Seitz  <keiths@redhat.com>
 859
 860         PR gdb/23712
 861         PR symtab/23010
 862         * dictionary.c: Include unordered_map.
 863         (pending_to_vector): New function.
 864         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 865         Rewrite the non-"_1" functions to take vector instead
 866         of linked list.
 867         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 868         "new" _1 versions of the same name.
 869         (multidictionary): Define.
 870         (std::hash<enum language): New definition.
 871         (collate_pending_symbols_by_language, mdict_create_hashed)
 872         (mdict_create_hashed_expandable, mdict_create_linear)
 873         (mdict_create_linear_expandable, mdict_free)
 874         (find_language_dictionary, create_new_language_dictionary)
 875         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 876         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 877         (mdict_size, mdict_empty): New functions.
 878         * dictionary.h (mdict_iterator): Define.
 879
 880 2019-01-10  Pedro Alves  <palves@redhat.com>
 881
 882         * breakpoint.c (read_uploaded_action)
 883         (create_tracepoint_from_upload): Adjust to use
 884         gdb::unique_xmalloc_ptr.
 885         * ctf.c (ctf_write_uploaded_tp):
 886         (SET_ARRAY_FIELD): Use emplace_back.
 887         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 888         * tracefile-tfile.c (tfile_write_uploaded_tp):
 889         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 890         gdb::unique_xmalloc_ptr.
 891         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 892         at_string, cond_string, cmd_strings>: Replace char pointers
 893         with gdb::unique_xmalloc_ptr.
 894
 895 2019-01-10  Pedro Alves  <palves@redhat.com>
 896
 897         * solib-target.c (library_list_start_library): Don't xstrdup name.
 898
 899 2019-01-10  Pedro Alves  <palves@redhat.com>
 900
 901         * mdebugread.c (parse_partial_symbols): Use
 902         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 903
 904 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 905
 906         * linux-fork.c (scoped_switch_fork_info)
 907         <~scoped_switch_fork_info>: Fix incorrect variable name.
 908
 909 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * linux-fork.c (scoped_switch_fork_info)
 912         <scoped_switch_fork_info>: Make explicit.
 913         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 914
 915 2019-01-10  Tom Tromey  <tom@tromey.com>
 916
 917         * objfiles.h (objfile::reset_psymtabs): Update.
 918         * objfiles.c (objfile::objfile): Update.
 919         * psymtab.h (psymtab_storage::obstack): Update.
 920         (psymtab_storage::m_obstack): Use gdb::optional.
 921         (class psymtab_storage): Update comment.  Remove objfile
 922         parameter.
 923         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 924
 925 2019-01-10  Tom Tromey  <tom@tromey.com>
 926
 927         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 928         <free_psymtabs>: Now private.
 929         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 930         (allocate_psymtab): Use new method.
 931
 932 2019-01-10  Tom Tromey  <tom@tromey.com>
 933
 934         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 935         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 936         * mdebugread.c (parse_partial_symbols): Use
 937         allocate_dependencies.
 938         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 939         allocate_dependencies.
 940         (process_psymtab_comp_unit_reader)
 941         (build_type_psymtab_dependencies): Likewise.
 942         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 943
 944 2019-01-10  Tom Tromey  <tom@tromey.com>
 945
 946         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 947         PSYMBOL_SET_LANGUAGE.
 948         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 949
 950 2019-01-10  Tom Tromey  <tom@tromey.com>
 951
 952         * psymtab.h (psymtab_storage::obstack): New method.
 953         <m_obstack>: Rename from obstack; now private.
 954         * psymtab.c (psymtab_storage): Update.
 955         * dwarf2read.c (create_addrmap_from_index)
 956         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 957         Update.
 958
 959 2019-01-10  Tom Tromey  <tom@tromey.com>
 960
 961         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 962         * objfiles.h (objfile::reset_psymtabs): New method.
 963
 964 2019-01-10  Tom Tromey  <tom@tromey.com>
 965
 966         * symmisc.c (print_symbol_bcache_statistics): Update.
 967         (print_objfile_statistics): Update.
 968         * symfile.c (reread_symbols): Update.
 969         * psymtab.h (class psymtab_storage): New.
 970         * psymtab.c (psymtab_storage): New constructor.
 971         (~psymtab_storage): New destructor.
 972         (require_partial_symbols): Update.
 973         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 974         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 975         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 976         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 977         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 978         (start_psymtab_common, end_psymtab_common)
 979         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 980         (allocate_psymtab): Update.
 981         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 982         Update.
 983         (dump_psymtab_addrmap, maintenance_print_psymbols)
 984         (maintenance_check_psymtabs): Update.
 985         (class objfile_psymtabs): Move to objfiles.h.
 986         * psympriv.h (discard_psymtab): Now inline.
 987         (psymtab_discarder::psymtab_discarder): Update.
 988         (psymtab_discarder::~psymtab_discarder): Update.
 989         (ALL_OBJFILE_PSYMTABS): Rewrite.
 990         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 991         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 992         Remove fields.
 993         <partial_symtabs>: New field.
 994         (class objfile_psymtabs): Move from psymtab.h.  Update.
 995         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 996         psymbol_cache.
 997         (objfile::~objfile): Don't destroy psymbol_cache.
 998         * mdebugread.c (parse_partial_symbols): Update.
 999         * dwarf2read.c (create_addrmap_from_index)
1000         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1001         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1002         (add_partial_subprogram, dwarf2_ranges_read): Update.
1003         * dwarf-index-write.c (write_address_map)
1004         (write_one_signatured_type, recursively_write_psymbols)
1005         (class debug_names, class debug_names, write_psymtabs_to_index):
1006         Update.
1007
1008 2019-01-10  Tom Tromey  <tom@tromey.com>
1009
1010         * symtab.h (SYMBOL_SET_NAMES): Update.
1011         (symbol_set_names): Update.
1012         (MSYMBOL_SET_NAMES): Update.
1013         * symtab.c (symbol_set_names): Change argument to be an
1014         objfile_per_bfd_storage.
1015         * psymtab.c (add_psymbol_to_bcache): Update.
1016         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1017
1018 2019-01-10  Tom Tromey  <tom@tromey.com>
1019
1020         * symtab.c (create_demangled_names_hash): Change argument to be an
1021         objfile_per_bfd_storage.
1022         (symbol_set_names): Update.
1023
1024 2019-01-10  Tom Tromey  <tom@tromey.com>
1025
1026         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1027         init_psymbol_list.
1028         * psymtab.c (init_psymbol_list): Do nothing if already called.
1029         * psympriv.h (init_psymbol_list): Add comment.
1030         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1031         init_psymbol_list.
1032         * dbxread.c (dbx_symfile_read): Unconditionally call
1033         init_psymbol_list.
1034
1035 2019-01-10  Tom Tromey  <tom@tromey.com>
1036
1037         * xcoffread.c (scan_xcoff_symtab): Update.
1038         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1039         "where".
1040         * mdebugread.c (parse_partial_symbols)
1041         (handle_psymbol_enumerators): Update.
1042         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1043         * dbxread.c (read_dbx_symtab): Update.
1044         * psympriv.h (psymbol_placement): New enum.
1045         (add_psymbol_to_list): Update.
1046
1047 2019-01-10  Tom Tromey  <tom@tromey.com>
1048
1049         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1050         static_psymbols parameters.
1051         (scan_xcoff_symtab): Update.
1052         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1053         static_psymbols parameters.
1054         * psympriv.h (start_psymtab_common): Update.
1055         * mdebugread.c (parse_partial_symbols): Update.
1056         * dwarf2read.c (create_partial_symtab): Update.
1057         * dbxread.c (read_dbx_symtab): Update.
1058         (start_psymtab): Remove global_psymbols and static_psymbols
1059         parameters.
1060
1061 2019-01-10  Tom Tromey  <tom@tromey.com>
1062
1063         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1064         * psymtab.c (allocate_psymtab): Add comment.
1065         * psympriv.h (allocate_psymtab): Add comment.
1066         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1067         initializations.
1068         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1069
1070 2019-01-10  Tom Tromey  <tom@tromey.com>
1071
1072         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1073         Don't declare.
1074         * mipsread.c: Include mdebugread.h.
1075         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1076         Declare.
1077         * elfread.c: Include mdebugread.h.
1078
1079 2019-01-09  Tom Tromey  <tom@tromey.com>
1080
1081         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1082         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1083         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1084         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1085         (psym_lookup_symbol, psym_find_last_source_symtab)
1086         (psym_forget_cached_source_info, psym_print_stats)
1087         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1088         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1089         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1090         (psym_find_compunit_symtab_by_address)
1091         (maintenance_print_psymbols, maintenance_info_psymtabs)
1092         (maintenance_check_psymtabs): Use ranged for.
1093         * psymtab.h (class objfile_psymtabs): New.
1094         (require_partial_symbols): Return objfile_psymtabs.
1095         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1096
1097 2019-01-09  Tom Tromey  <tom@tromey.com>
1098
1099         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1100         (find_pc_mapped_section, list_overlays_command)
1101         (map_overlay_command, unmap_overlay_command)
1102         (simple_overlay_update): Use all_objfiles.
1103         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1104         * printcmd.c (info_symbol_command): Use all_objfiles.
1105         * objfiles.h (ALL_OBJSECTIONS): Remove.
1106         * maint.c (maintenance_translate_address): Use all_objfiles.
1107         * gcore.c (gcore_create_callback): Use all_objfiles.
1108         (objfile_find_memory_regions): Likewise.
1109
1110 2019-01-09  Tom Tromey  <tom@tromey.com>
1111
1112         * symtab.c (find_line_symtab, info_sources_command)
1113         (make_source_files_completion_list): Use objfile_compunits.
1114         * source.c (select_source_symtab): Use objfile_compunits.
1115         * objfiles.h (struct objfile): Update comment.
1116         (ALL_OBJFILES): Remove.
1117         (ALL_FILETABS): Remove.
1118         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1119         objfile_compunits.
1120
1121 2019-01-09  Tom Tromey  <tom@tromey.com>
1122
1123         * symmisc.c (print_objfile_statistics, dump_objfile)
1124         (maintenance_print_symbols): Use compunit_filetabs.
1125         * source.c (forget_cached_source_info_for_objfile): Use
1126         compunit_filetabs.
1127         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1128         (ALL_FILETABS): Use compunit_filetabs.
1129         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1130         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1131
1132 2019-01-09  Tom Tromey  <tom@tromey.com>
1133
1134         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1135         (compunit_filetabs): New.
1136         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1137         compunit_filetabs.
1138         (info_sources_command, make_source_files_completion_list): Remove
1139         declaration.
1140         * symmisc.c (print_objfile_statistics, dump_objfile)
1141         (maintenance_print_symbols): Remove declaration.
1142         (maintenance_info_symtabs): Use compunit_filetabs.
1143         (maintenance_info_line_tables): Likewise.
1144         * source.c (select_source_symtab): Change local variable name.
1145         (forget_cached_source_info_for_objfile): Remove declaration.
1146         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1147         * objfiles.c (objfile_relocate1): Remove declaration.
1148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1149         declaration.
1150         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1151         * coffread.c (coff_symtab_read): Remove declaration.
1152         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1153         compunit_filetabs.
1154
1155 2019-01-09  Tom Tromey  <tom@tromey.com>
1156
1157         * symtab.c (lookup_objfile_from_block)
1158         (find_pc_sect_compunit_symtab, search_symbols)
1159         (default_collect_symbol_completion_matches_break_on): Use
1160         objfile_compunits.
1161         * objfiles.h (ALL_COMPUNITS): Remove.
1162         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1163         * cp-support.c (add_symbol_overload_list_qualified): Use
1164         objfile_compunits.
1165         * ada-lang.c (ada_collect_symbol_completion_matches)
1166         (ada_add_global_exceptions): Use objfile_compunits.
1167
1168 2019-01-09  Tom Tromey  <tom@tromey.com>
1169
1170         * source.c (select_source_symtab)
1171         (forget_cached_source_info_for_objfile): Remove declaration.
1172         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1173         declaration.
1174         * maint.c (count_symtabs_and_blocks): Remove declaration.
1175         * cp-support.c (add_symbol_overload_list_qualified): Remove
1176         declaration.
1177         * coffread.c (coff_symtab_read): Remove declaration.
1178         * symtab.c (lookup_symbol_in_objfile_symtabs)
1179         (basic_lookup_transparent_type_1): Use objfile_compunits.
1180         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1181         (info_sources_command, search_symbols)
1182         (default_collect_symbol_completion_matches_break_on)
1183         (make_source_files_completion_list): Remove declaration.
1184         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1185         (ada_collect_symbol_completion_matches)
1186         (ada_add_global_exceptions): Remove declaration.
1187         * linespec.c (iterate_over_all_matching_symtabs): Use
1188         objfile_compunits.
1189         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1190         (class objfile_compunits): New.
1191         (ALL_COMPUNITS): Use objfile_compunits.
1192         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1193         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1194         objfile_compunits.
1195         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1196
1197 2019-01-09  Tom Tromey  <tom@tromey.com>
1198
1199         * symtab.c (search_symbols)
1200         (default_collect_symbol_completion_matches_break_on): Use
1201         objfile_msymbols.
1202         * ada-lang.c (ada_lookup_simple_minsym)
1203         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1204         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1205         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1206         objfile_msymbols.
1207         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1208         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1209         * objc-lang.c (find_methods): Use objfile_msymbols.
1210         (info_selectors_command, info_classes_command): Likewise.
1211         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1212         * objfiles.h (class objfile_msymbols): New.
1213         (ALL_OBJFILE_MSYMBOLS): Remove.
1214         (ALL_MSYMBOLS): Remove.
1215
1216 2019-01-09  Tom Tromey  <tom@tromey.com>
1217
1218         * common/next-iterator.h (next_adapter): Add Iterator template
1219         parameter.
1220         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1221         (class all_objfiles_safe): New.
1222         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1223         * objfiles.c (put_objfile_before): Update comment.
1224         (add_separate_debug_objfile): Likewise.
1225         (free_all_objfiles): Use all_objfiles_safe.
1226         (objfile_purge_solibs): Likewise.
1227
1228 2019-01-09  Tom Tromey  <tom@tromey.com>
1229
1230         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1231         (expand_symtab_containing_pc, lookup_static_symbol)
1232         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1233         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1234         all_objfiles.
1235         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1236         * breakpoint.c (create_overlay_event_breakpoint)
1237         (create_longjmp_master_breakpoint)
1238         (create_std_terminate_master_breakpoint)
1239         (create_exception_master_breakpoint): Use all_objfiles.
1240         * linux-thread-db.c (try_thread_db_load_from_pdir)
1241         (has_libpthread): Use all_objfiles.
1242         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1243         * linespec.c (iterate_over_all_matching_symtabs)
1244         (search_minsyms_for_name): Use all_objfiles.
1245         * maint.c (maintenance_info_sections): Use all_objfiles.
1246         * main.c (captured_main_1): Use all_objfiles.
1247         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1248         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1249         * guile/scm-pretty-print.c
1250         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1251         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1252         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1253         (maintenance_print_msymbols): Use all_objfiles.
1254         * source.c (select_source_symtab): Use all_objfiles.
1255         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1256         * symfile.c (remove_symbol_file_command)
1257         (expand_symtabs_matching, map_symbol_filenames): Use
1258         all_objfiles.
1259         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1260         all_objfiles.
1261         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1262         * objc-lang.c (find_methods): Use all_objfiles.
1263         * objfiles.c (have_partial_symbols, have_full_symbols)
1264         (have_minimal_symbols, qsort_cmp)
1265         (default_iterate_over_objfiles_in_search_order): Use
1266         all_objfiles.
1267         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1268         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1269         (maintenance_check_psymtabs): Use all_objfiles.
1270         (ALL_PSYMTABS): Remove.
1271         * compile/compile-object-run.c (do_module_cleanup): Use
1272         all_objfiles.
1273         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1274         * cp-support.c (add_symbol_overload_list_qualified): Use
1275         all_objfiles.
1276         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1277         Use all_objfiles.
1278         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1279         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1280         all_objfiles.
1281         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1282         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1283         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1284         Uses all_objfiles.
1285         * solib.c (solib_read_symbols): Use all_objfiles
1286
1287 2019-01-09  Tom Tromey  <tom@tromey.com>
1288
1289         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1290         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1291         all_objfiles.
1292         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1293         * symmisc.c (print_symbol_bcache_statistics)
1294         (print_objfile_statistics, maintenance_print_objfiles)
1295         (maintenance_info_symtabs, maintenance_check_symtabs)
1296         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1297         all_objfiles.
1298         * source.c (forget_cached_source_info): Use all_objfiles.
1299         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1300         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1301         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1302         * objfiles.c (update_section_map): Use all_objfiles.
1303         (shared_objfile_contains_address_p): Likewise.
1304         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1305         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1306
1307 2019-01-09  Tom Tromey  <tom@tromey.com>
1308
1309         * common/next-iterator.h: New file.
1310         * objfiles.h (class all_objfiles): New.
1311         (struct objfile_iterator): New.
1312
1313 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1314
1315         * NEWS: Move the description of the changed "frame", "select-frame",
1316          and "info frame" commands to the Changed commands section.
1317
1318 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1319
1320         * gdbtypes.c (check_stub_method_group): Remove handling of old
1321         mangling schemes.
1322         * linespec.c (find_methods): Likewise.
1323         * stabsread.c (read_member_functions): Likewise.
1324         * valops.c (search_struct_method): Likewise.
1325         (value_struct_elt_for_reference): Likewise.
1326         * NEWS: Mention this change.
1327
1328 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1329
1330         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1331         print_source_lines.
1332         * source.c (print_source_lines_base): Update line number check.
1333         (print_source_lines): New function.
1334         (source_lines_range::source_lines_range): New function.
1335         * source.h (class source_lines_range): New class.
1336         (print_source_lines): New declaration.
1337
1338 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1339
1340         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1341
1342 2019-01-08  Tom Tromey  <tom@tromey.com>
1343             Simon Marchi  <simon.marchi@ericsson.com>
1344
1345         PR gdb/24060
1346         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1347         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1348         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1349         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1350         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1351         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1352
1353 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * source.c (select_source_symtab): Move header comment to
1356         declaration in source.h.
1357         (forget_cached_source_info_for_objfile): Likewise.
1358         (forget_cached_source_info): Likewise.
1359         (identify_source_line): Likewise.
1360         * source.h (identify_source_line): Move declaration from symtab.h
1361         and add comment from source.c
1362         (print_source_lines): Likewise.
1363         (forget_cached_source_info_for_objfile): Likewise.
1364         (forget_cached_source_info): Likewise.
1365         (select_source_symtab): Likewise.
1366         (enum print_source_lines_flag): Move definition from symtab.h.
1367         * symtab.h (identify_source_line): Move declaration to source.h.
1368         (print_source_lines): Likewise.
1369         (forget_cached_source_info_for_objfile): Likewise.
1370         (forget_cached_source_info): Likewise.
1371         (select_source_symtab): Likewise.
1372         (enum print_source_lines_flag): Move definition to source.h.
1373         * tui/tui-hooks.c: Add 'source.h' include.
1374
1375 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1376
1377         * source.c (print_source_lines_base): Handle requests to print
1378         reverse line number sequences, and guard against empty lines
1379         string.
1380
1381 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1382
1383         * source.c (print_source_lines_base): Fix skip of '\r' if next
1384         character is '\n'.
1385
1386 2019-01-06  Tom Tromey  <tom@tromey.com>
1387
1388         * c-exp.y (struct c_parse_state) <macro_original_text,
1389         expansion_obstack>: New member.
1390         (macro_original_text, expansion_obstack): Remove globals.
1391         (scan_macro_expansion, scanning_macro_expansion)
1392         (finished_macro_expansion): Update.
1393         (scan_macro_cleanup): Remove.
1394         (yylex, c_parse): Update.
1395
1396 2019-01-06  Tom Tromey  <tom@tromey.com>
1397
1398         * c-exp.y (struct c_parse_state) <strings>: New member.
1399         (operator_stoken): Update.
1400
1401 2019-01-06  Tom Tromey  <tom@tromey.com>
1402
1403         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1404         (union type_stack_elt) <typelist_val>: Now a pointer to
1405         std::vector.
1406         (type_stack_cleanup): Don't declare.
1407         (push_typelist): Update.
1408         * parse.c (pop_typelist): Return a std::vector.
1409         (push_typelist): Take a std::vector.
1410         (follow_types): Update.  Do not free args.
1411         (type_stack_cleanup): Remove.
1412         * c-exp.y (struct c_parse_state): New.
1413         (cpstate): New global.
1414         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1415         (nonempty_typelist): Update.
1416         (func_mod): Create a new vector.
1417         (c_parse): Create a c_parse_state.
1418         (check_parameter_typelist): Do not delete params.
1419         (function_method): Update.  Do not delete type_list.
1420
1421 2019-01-06  Tom Tromey  <tom@tromey.com>
1422
1423         PR gdb/28155:
1424         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1425         check_typedef.
1426         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1427         (print_return_value): Likewise.
1428
1429 2019-01-05  Tom Tromey  <tom@tromey.com>
1430
1431         * contrib/cleanup_check.py: Remove.
1432         * contrib/gcc-with-excheck: Remove.
1433         * contrib/exsummary.py: Remove.
1434         * contrib/excheck.py: Remove.
1435
1436 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1437
1438         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1439         NULL. Initialize tpprev to NULL instead of assigning it
1440         to NULL on the next statement.
1441         * windows-nat.c (windows_delete_thread): Remove check for
1442         main_thread_id before printing thread exit notifications.
1443         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1444         Remove thread ID check against main_thread_id.
1445         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1446         windows_delete_thread.
1447         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1448
1449 2019-01-04  Tom Tromey  <tom@tromey.com>
1450
1451         * compile/compile.c (_initialize_compile): Use upper case for
1452         metasyntactic variables.
1453         * symmisc.c (_initialize_symmisc): Use upper case for
1454         metasyntactic variables.
1455         * psymtab.c (_initialize_psymtab): Use upper case for
1456         metasyntactic variables.
1457         * demangle.c (demangle_command): Use upper case for metasyntactic
1458         variables.
1459         (_initialize_demangler): Likewise.
1460         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1461         variables.
1462
1463 2019-01-03  Tom Tromey  <tom@tromey.com>
1464
1465         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1466
1467 2019-01-03  Tom Tromey  <tom@tromey.com>
1468
1469         * python/py-symtab.c (salpy_str): Update.
1470         (struct salpy_sal_object) <symtab>: Now a PyObject.
1471         (salpy_dealloc): Update.
1472         (del_objfile_sal): Use gdbpy_ref.
1473
1474 2019-01-03  Tom Tromey  <tom@tromey.com>
1475
1476         * python/py-type.c (convert_field): Use new_reference.  Return
1477         gdbpy_ref.
1478         (make_fielditem): Return gdbpy_ref.
1479         (typy_fields): Update.
1480         (typy_getitem): Update.
1481         (field_name): Return gdbpy_ref.  Use new_reference.
1482         (typy_iterator_iternext): Update.
1483
1484 2019-01-03  Tom Tromey  <tom@tromey.com>
1485
1486         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1487
1488 2019-01-03  Tom Tromey  <tom@tromey.com>
1489
1490         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1491         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1492         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1493         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1494         (pspy_set_type_printers): Likewise.
1495         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1496         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1497         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1498         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1499         (objfpy_set_type_printers): Likewise.
1500
1501 2019-01-03  Tom Tromey  <tom@tromey.com>
1502
1503         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1504         (gdbpy_print_stack): Use gdbpy_err_fetch.
1505         * python/python-internal.h (class gdbpy_err_fetch): New class.
1506         (class gdbpy_enter) <m_error_type, m_error_value,
1507         m_error_traceback>: Remove.
1508         <m_error>: New member.
1509         (gdbpy_exception_to_string): Don't declare.
1510         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1511         * python/py-value.c (convert_value_from_python): Use
1512         gdbpy_err_fetch.
1513         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1514         gdbpy_exception_to_string.
1515         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1516         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1517         gdbpy_err_fetch.
1518
1519 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1520
1521         * linux-nat.c (delete_lwp_cleanup): Delete.
1522         (struct lwp_deleter): New struct.
1523         (lwp_info_up): New typedef.
1524         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1525         lwp_info_up.
1526
1527 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1528
1529         * linux-fork.c (class scoped_switch_fork_info): New class.
1530         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1531
1532 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1533
1534         * valops.c (find_overload_match): Remove use of null_cleanup, and
1535         calls to do_cleanups.
1536
1537 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * compile/compile-cplus-types.c
1540         (compile_cplus_instance::decl_name): Handle changes to
1541         cp_func_name.
1542         * cp-support.c (cp_func_name): Update header comment, update
1543         return type.
1544         * cp-support.h (cp_func_name): Update return type in declaration.
1545         * valops.c (find_overload_match): Move temp_func local to top
1546         level of function and change its type.  Use temp_func to hold and
1547         delete temporary string obtained from cp_func_name.
1548
1549 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1552         gdb::char_vector, remove cleanup, and update uses of `msg`.
1553
1554 2019-01-03  Jim Wilson  <jimw@sifive.com>
1555
1556         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1557
1558 2019-01-02  Tom Tromey  <tom@tromey.com>
1559
1560         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1561         (tdesc_parse_xml): Remove cleanups.
1562         * target-descriptions.h (make_cleanup_free_target_description):
1563         Don't declare.
1564         (target_desc_deleter): New struct.
1565         (target_desc_up): New typedef.
1566         * target-descriptions.c (target_desc_deleter::operator()): Rename
1567         from free_target_description.
1568         (make_cleanup_free_target_description): Remove.
1569
1570 2019-01-02  Tom Tromey  <tom@tromey.com>
1571
1572         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1573         constructor, destructor.
1574         (linespec_parser): Remove typedef.
1575         (~linespec_parser): Rename from linespec_parser_delete.
1576         (linespec_lex_to_end, linespec_complete_label)
1577         (linespec_complete): Update.
1578         (decode_line_full): Remove cleanups.
1579         (decode_line_1): Update.
1580
1581 2019-01-02  Tom Tromey  <tom@tromey.com>
1582
1583         * python/python-internal.h (inferior_to_inferior_object): Change
1584         return type.
1585         * python/py-exitedevent.c (create_exited_event_object): Update.
1586         * python/py-inferior.c (inferior_to_inferior_object): Return
1587         gdbpy_ref.
1588         (python_new_inferior, python_inferior_deleted)
1589         (thread_to_thread_object, delete_thread_object)
1590         (build_inferior_list, gdbpy_selected_inferior): Update.
1591         * python/py-infthread.c (create_thread_object): Update.  Also fail
1592         if inferior_to_inferior_object fails.
1593
1594 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1595
1596         * inferior.h (class inferior) <displaced_step_state>: New field.
1597         * infrun.h (struct displaced_step_state): Move here from
1598         infrun.c.  Initialize fields, add constructor.
1599         <inf>: Remove field.
1600         <reset>: New method.
1601         * infrun.c (struct displaced_step_inferior_state): Move to
1602         infrun.h.
1603         (displaced_step_inferior_states): Remove.
1604         (get_displaced_stepping_state): Adust.
1605         (displaced_step_in_progress_any_inferior): Adjust.
1606         (displaced_step_in_progress_thread): Adjust.
1607         (displaced_step_in_progress): Adjust.
1608         (add_displaced_stepping_state): Remove.
1609         (get_displaced_step_closure_by_addr): Adjust.
1610         (remove_displaced_stepping_state): Remove.
1611         (infrun_inferior_exit): Call displaced_step_state.reset.
1612         (use_displaced_stepping): Don't check for NULL.
1613         (displaced_step_prepare_throw): Call
1614         get_displaced_stepping_state.
1615         (displaced_step_fixup): Don't check for NULL.
1616         (prepare_for_detach): Don't check for NULL.
1617
1618 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1619
1620         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1621          in case of call that did not complete.
1622
1623 2019-01-02  Andrey Utkin  <autkin@undo.io>
1624
1625         * symfile.c (find_separate_debug_file): Fix search of debug files for
1626         remote debuggee.
1627
1628 2019-01-02  Tom Tromey  <tom@tromey.com>
1629
1630         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1631         indentation.
1632         * python/py-frame.c (frapy_older): Remove cast.
1633         (frapy_newer): Likewise.
1634         * python/py-breakpoint.c (local_setattro): Remove cast.
1635         * python/py-arch.c (archpy_name): Remove local variable.
1636         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1637
1638 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1639
1640         * unittests/basic_string_view/element_access/char/empty.cc:
1641         Fix year range in copyright header.
1642
1643 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1644
1645         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1646         Delete.
1647         <operator==>: Update with for removed field.
1648         <hash>: Likewise.
1649         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1650         <isa_features>: ...this.
1651         <abi_features>: New field.
1652         (riscv_isa_flen): Update comment.
1653         (riscv_abi_xlen): New declaration.
1654         (riscv_abi_flen): New declaration.
1655         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1656         isa_features.
1657         (riscv_abi_xlen): New function.
1658         (riscv_isa_flen): Update to get answer from isa_features.
1659         (riscv_abi_flen): New function.
1660         (riscv_has_fp_abi): Update to get answer from abi_features.
1661         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1662         xlen and flen.
1663         (riscv_call_info) <xlen, flen>: Update comment.
1664         (riscv_call_arg_struct): Remove invalid assertions
1665         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1666         is removed.
1667         (riscv_gdbarch_init): Gather isa features and abi features
1668         separately, ensure both match on the gdbarch when reusing an old
1669         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1670         a target with 64-bit float hardware.
1671
1672 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1673
1674         * source.c (search_command_helper): Stop reverse search
1675         when line 1 has been searched.
1676
1677 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1678
1679         * record-full.c (record_full_base_target::close): Rewrite
1680         record_full_core_buf_list free logic.
1681
1682 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1683
1684         * break-catch-syscall.c (print_one_catch_syscall): xfree
1685         the last text.
1686
1687 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1688
1689         * top.c (print_gdb_version): Update Copyright year in version
1690         message.
1691
1692 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1693
1694         Update copyright year range in all GDB files.
1695
1696 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1697
1698         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1699
1700 For older changes see ChangeLog-2018.
1701 \f
1702 Local Variables:
1703 mode: change-log
1704 left-margin: 8
1705 fill-column: 74
1706 version-control: never
1707 coding: utf-8
1708 End:
1709