gdb/ChangeLog

   1 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
   4         ptrace earlier.
   5
   6 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
   7
   8         * features/aarch64-pauth.c: Regenerate.
   9
  10 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
  11
  12         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
  13         bool.
  14         (bpstat_what): Use false instead of 0.
  15
  16 2019-07-09  Pedro Alves  <palves@redhat.com>
  17
  18         * break-catch-throw.c (is_exception_catchpoint): New.
  19         * breakpoint.c (print_one_breakpoint_location): New parameter
  20         'raw_loc'.  Handle it.  Use
  21         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
  22         looking at the breakpoint's type.
  23         (print_one_breakpoint): If handling "maint info breakpoints", also
  24         print locations of exception catchpoints.
  25         * breakpoint.h (is_exception_catchpoint): Declare.
  26
  27 2019-07-09  Pedro Alves  <palves@redhat.com>
  28
  29         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
  30         "addr" field.
  31         (allocate_location_exception_catchpoint): New.
  32         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
  33         (initialize_throw_catchpoint_ops): Install
  34         allocate_location_exception_catchpoint as allocate_location
  35         method.
  36         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
  37         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
  38         bp_loc_other.
  39         (breakpoint_address_is_meaningful): Delete.
  40         (bl_address_is_meaningful): New.
  41         (breakpoint_locations_match): Adjust comment.
  42         (bp_location_from_bp_type): New, factored out of...
  43         (bp_location::bp_location(breakpoint *)): ... this.
  44         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
  45         factored out of...
  46         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
  47         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
  48         breakpoint_address_is_meaningful.
  49         (bp_locations_compare): Adjust comment.
  50         (update_global_location_list): Use bl_address_is_meaningful
  51         instead of breakpoint_address_is_meaningful.
  52         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
  53         explicit.
  54         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
  55         * python/py-breakpoint.c (bppy_get_location): No longer check
  56         whether location is null.
  57
  58 2019-07-09  Pedro Alves  <palves@redhat.com>
  59
  60         PR c++/15468
  61         * breakpoint.c (print_one_breakpoint_location): Remove
  62         single-location assert.
  63
  64 2019-07-09  Tom Tromey  <tom@tromey.com>
  65
  66         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
  67         * configure: Rebuild.
  68         * configure.ac: Change common to gdbsupport.
  69         * gdbsupport: Rename from common.
  70         * acinclude.m4: Change common to gdbsupport.
  71         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
  72         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
  73         gdbsupport.
  74         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
  75         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
  76         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
  77         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
  78         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
  79         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
  80         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
  81         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
  82         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
  83         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
  84         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
  85         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
  86         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
  87         coff-pe-read.c, command.h, compile/compile-c-support.c,
  88         compile/compile-c.h, compile/compile-cplus-symbols.c,
  89         compile/compile-cplus-types.c, compile/compile-cplus.h,
  90         compile/compile-loc2c.c, compile/compile.c, completer.c,
  91         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
  92         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
  93         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
  94         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
  95         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
  96         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
  97         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
  98         features/aarch64-core.c, features/aarch64-fpu.c,
  99         features/aarch64-pauth.c, features/aarch64-sve.c,
 100         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 101         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 102         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 103         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 104         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 105         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 106         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 107         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 108         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 109         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 110         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 111         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 112         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 113         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 114         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 115         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 116         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 117         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 118         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 119         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 120         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 121         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 122         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 123         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 124         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 125         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 126         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 127         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 128         minsyms.c, mips-linux-tdep.c, namespace.h,
 129         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 130         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 131         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 132         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 133         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 134         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 135         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 136         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 137         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 138         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 139         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 140         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 141         procfs.c, producer.c, progspace.h, psymtab.h,
 142         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 143         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 144         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 145         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 146         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 147         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 148         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 149         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 150         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 151         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 152         target-memory.c, target.c, target.h, target/waitstatus.c,
 153         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 154         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 155         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 156         unittests/array-view-selftests.c,
 157         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 158         unittests/common-utils-selftests.c,
 159         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 160         unittests/format_pieces-selftests.c,
 161         unittests/function-view-selftests.c,
 162         unittests/lookup_name_info-selftests.c,
 163         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 164         unittests/mkdir-recursive-selftests.c,
 165         unittests/observable-selftests.c,
 166         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 167         unittests/parse-connection-spec-selftests.c,
 168         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 169         unittests/scoped_fd-selftests.c,
 170         unittests/scoped_mmap-selftests.c,
 171         unittests/scoped_restore-selftests.c,
 172         unittests/string_view-selftests.c, unittests/style-selftests.c,
 173         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 174         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 175         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 176         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 177         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 178         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 179
 180 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 181
 182         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 183         bool value.
 184         (decode_digits_ordinary): Set explicit_line field in sal.
 185         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 186         symtab_and_line that was set on an explicit line number in
 187         assembler code.  Do always update the recorded symtab and line if
 188         we do skip the prologue.
 189
 190 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 191
 192         * breakpoint.c (set_breakpoint_location_function): Remove
 193         explicit_loc parameter.
 194         (momentary_breakpoint_from_master): Update call to
 195         set_breakpoint_location_function.
 196         (add_location_to_breakpoint): Likewise.
 197
 198 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 199
 200         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 201         required features based on default bfd type when no specific bfd
 202         is present.
 203
 204 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 205
 206         * NEWS: Mention that GDB printf and eval commands can now print
 207         C-style and Ada-style convenience var strings without
 208         calling the inferior.
 209         * printcmd.c (printf_c_string): Locally print GDB internal var
 210         instead of transiting via the inferior.
 211         (printf_wide_c_string): Likewise.
 212
 213 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 214
 215         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 216
 217 2019-07-04  Tom Tromey  <tom@tromey.com>
 218
 219         PR tui/24724:
 220         * tui/tui-winsource.c (tui_clear_source_content): Update.
 221         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 222         (tui_update_breakpoint_info): Update.
 223         (tui_set_exec_info_content): Update.
 224         * tui/tui-source.c (tui_set_source_content_nil): Update.
 225         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 226         has_break.
 227         * tui/tui-data.h (enum tui_bp_flag): New.
 228         (tui_bp_flags): New enum flags type.
 229         (struct tui_source_element) <break_mode>: Change type.  Rename
 230         from has_break.
 231         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 232         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 233         constants.
 234         * tui/tui-winsource.h: Fix comment.
 235
 236 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 237
 238         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 239         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 240         (store_fpregs_to_thread)
 241         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 242         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 243         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 244         (IWMMXT_REGS_SIZE): Add define.
 245         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 246         (fetch_vfp_regs, store_vfp_regs)
 247         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 248         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 249
 250 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 251
 252         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 253         defines.
 254         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 255         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 256         (ARM_INT_REGISTER_SIZE): ...to this.
 257         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 258         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 259         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 260         (arm_linux_collect_gregset, supply_nwfpe_register)
 261         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 262         defines.
 263         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 264         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 265         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 266         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 267         (arm_return_in_memory, arm_store_return_value)
 268         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 269         (arm_record_ld_st_multiple): Likewise.
 270         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 271         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 272
 273 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 274
 275         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 276         AARCH64_DISPLACED_MODIFIED_INSNS.
 277         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 278         (aarch64_displaced_step_copy_insn): Likewise.
 279         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 280         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 281         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 282         ARM_DISPLACED_MODIFIED_INSNS.
 283         * arm-tdep.c (arm_gdbarch_init): Likewise.
 284         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 285         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 286         (struct arm_displaced_step_closure): Use
 287         ARM_DISPLACED_MODIFIED_INSNS.
 288
 289 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 290
 291         * features/Makefile: Remove unused xml files.
 292         * features/aarch64.xml: Remove.
 293         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 294         * features/i386/amd64-avx-avx512.xml: Remove.
 295         * features/i386/amd64-avx-linux.xml: Remove.
 296         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 297         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 298         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 299         * features/i386/amd64-avx-mpx.xml: Remove.
 300         * features/i386/amd64-avx.xml: Remove.
 301         * features/i386/amd64-linux.xml: Remove.
 302         * features/i386/amd64-mpx-linux.xml: Remove.
 303         * features/i386/amd64-mpx.xml: Remove.
 304         * features/i386/amd64.xml: Remove.
 305         * features/i386/i386-avx-avx512-linux.xml: Remove.
 306         * features/i386/i386-avx-avx512.xml: Remove.
 307         * features/i386/i386-avx-linux.xml: Remove.
 308         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 309         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 310         * features/i386/i386-avx-mpx-linux.xml: Remove.
 311         * features/i386/i386-avx-mpx.xml: Remove.
 312         * features/i386/i386-avx.xml: Remove.
 313         * features/i386/i386-linux.xml: Remove.
 314         * features/i386/i386-mmx-linux.xml: Remove.
 315         * features/i386/i386-mmx.xml: Remove.
 316         * features/i386/i386-mpx-linux.xml: Remove.
 317         * features/i386/i386-mpx.xml: Remove.
 318         * features/i386/i386.xml: Remove.
 319         * features/i386/x32-avx-avx512-linux.xml: Remove.
 320         * features/i386/x32-avx-linux.xml: Remove.
 321         * features/i386/x32-linux.xml: Remove.
 322
 323 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 324
 325         * regformats/aarch64.dat: Remove.
 326         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 327         * regformats/i386/amd64-avx-linux.dat: Remove.
 328         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 329         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 330         * regformats/i386/amd64-linux.dat: Remove.
 331         * regformats/i386/amd64-mpx-linux.dat: Remove.
 332         * regformats/i386/amd64.dat: Remove.
 333         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 334         * regformats/i386/i386-avx-linux.dat: Remove.
 335         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 336         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 337         * regformats/i386/i386-linux.dat: Remove.
 338         * regformats/i386/i386-mmx-linux.dat: Remove.
 339         * regformats/i386/i386-mpx-linux.dat: Remove.
 340         * regformats/i386/i386.dat: Remove.
 341         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 342         * regformats/i386/x32-avx-linux.dat: Remove.
 343         * regformats/i386/x32-linux.dat: Remove.
 344
 345 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 346
 347         * aarch64-tdep.c: Remove xml self tests.
 348         * amd64-linux-tdep.c: Likewise.
 349         * amd64-tdep.c: Likewise.
 350         * i386-linux-tdep.c: Likewise.
 351         * i386-tdep.c: Likewise.
 352
 353 2019-07-03  Pedro Alves  <palves@redhat.com>
 354
 355         PR cli/24732
 356         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 357         (pipe_cmd_option_defs): New.
 358         (make_pipe_cmd_options_def_group): New.
 359         (pipe_command): Use gdb::option::process_options.
 360         (pipe_command_completer): New function.
 361         (_initialize_cli_cmds): Install completer for "pipe" command.
 362
 363 2019-07-03  Pedro Alves  <palves@redhat.com>
 364
 365         * cli/cli-option.c (union option_value) <string>: New field.
 366         (struct option_def_and_value): Add ctor, move ctor, dtor and
 367         use DISABLE_COPY_AND_ASSIGN.
 368         (option_def_and_value::clear_value): New.
 369         (parse_option, save_option_value_in_ctx, get_val_type_str)
 370         (add_setshow_cmds_for_options): Handle var_string.
 371         * cli-option.h (union option_def::var_address) <string>: New
 372         field.
 373         (struct string_option_def): New.
 374         * maint-test-options.c (struct test_options_opts): Add default
 375         ctor and use DISABLE_COPY_AND_ASSIGN.
 376         <string_opt>: New field.
 377         (test_options_opts::~test_options_opts): New.
 378         (test_options_opts::dump): Also dump "-string".
 379         (test_options_option_defs): Install "string.
 380
 381 2019-07-03  Pedro Alves  <palves@redhat.com>
 382
 383         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 384         option_value with a null enumeration.
 385         (complete_options): Save the option values in the context.
 386         (save_option_value_in_ctx): New, factored out from ...
 387         (process_options): ... here.
 388         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 389         of the function.
 390         * maint-test-options.c (test_options_opts::dump): New, factored
 391         out from ...
 392         (maintenance_test_options_command_mode): ... here.
 393         (maintenance_test_options_command_completion_result): Delete.
 394         (maintenance_test_options_command_completion_text): Update
 395         comment.
 396         (maintenance_show_test_options_completion_result): Change
 397         prototype.  Just print
 398         maintenance_test_options_command_completion_text.
 399         (save_completion_result): New.
 400         (maintenance_test_options_completer_mode): Pass options context to
 401         complete_options, and then save a dump.
 402         (_initialize_maint_test_options): Use add_cmd to install "maint
 403         show test-options-completion-result".
 404
 405 2019-07-03  Pedro Alves  <palves@redhat.com>
 406
 407         * NEWS (New commands): Mention "with" and "maint with".
 408         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 409         (with_command, with_command_completer): New.
 410         (pipe_command): Adjust to new repeat_previous
 411         interface.
 412         (_initialize_cli_cmds): Install the "with" command and its "w"
 413         alias.
 414         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 415         declarations.
 416         * cli/cli-setshow.c (parse_cli_var_uinteger)
 417         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 418         argument strings for all var_types.
 419         (get_setshow_command_value_string): New, factored out from ...
 420         (do_show_command): ... this.
 421         * cli/cli-setshow.h: Include <string>.
 422         (get_setshow_command_value_string): Declare.
 423         * command.h (repeat_previous): Now returns const char *.  Adjust
 424         comment.
 425         * maint.c: Include "cli/cli-cmds.h".
 426         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 427         (_initialize_maint_cmds): Register the "maintenance with" command.
 428         * top.c (repeat_previous): Move bits from pipe_command here:
 429         Return the saved command line, if any; error out if there's no
 430         command to relaunch.
 431
 432 2019-07-03  Pedro Alves  <palves@redhat.com>
 433
 434         * NEWS (New commands): Mention "maint set/show test-settings"
 435         instead of "maint test-settings".
 436         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 437         (maintenance_test_settings_set_list): Rename to ...
 438         (maintenance_set_test_settings_list): ... this.
 439         (maintenance_test_settings_show_list): Rename to  ...
 440         (maintenance_show_test_settings_list): ... this.
 441         (maintenance_test_settings_cmd): Delete.
 442         (maintenance_test_settings_set_cmd): ...
 443         (maintenance_set_test_settings_cmd): ... this.
 444         (maintenance_test_settings_show_cmd): ...
 445         (maintenance_show_test_settings_cmd): ... this.
 446         (maintenance_test_settings_show_value_cmd):
 447         (maintenance_show_test_settings_value_cmd): ... this.
 448         (_initialize_maint_test_settings): No longer install the "maint
 449         test-settings" prefix command.  Rename "maint test-settings set"
 450         to "maint set test-settings", and "maint test-settings show" to
 451         "maint show test-settings".  Adjust all subcommands.
 452
 453 2019-07-03  Pedro Alves  <palves@redhat.com>
 454
 455         * maint-test-settings.c: Fix file's intro comment.  Replace all
 456         references to "test-options" with references to "test-settings",
 457         in comments.
 458
 459 2019-07-03  Pedro Alves  <palves@redhat.com>
 460
 461         * maint-test-settings.c (maintenance_test_settings_xxx)
 462         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 463         New.
 464         (maintenance_test_settings_enums): Use them.
 465         (maintenance_test_settings_enum): Default to
 466         maintenance_test_settings_xxx.
 467         (_initialize_maint_test_settings): Initialize
 468         MAINTENANCE_TEST_SETTINGS_FILENAME.
 469
 470 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 471
 472         * breakpoint.h (remove_breakpoints_inf): Change return type to
 473         void, move function documentation here.
 474         * breakpoint.c (remove_breakpoints_inf): Change return type to
 475         void, move function documentation to header.
 476
 477 2019-07-02  Pedro Alves  <palves@redhat.com>
 478
 479         * NEWS (Completion improvements): Mention "info threads".
 480         * thread.c (struct info_threads_opts, info_threads_option_defs)
 481         (make_info_threads_options_def_group): New.
 482         (info_threads_command): Use gdb::option::process_options.
 483         (info_threads_command_completer): New.
 484         (_initialize_thread): Use gdb::option::build_help to build the
 485         help text for "info threads".
 486
 487 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 488
 489         * defs.h (generic_load): Move from here...
 490         * symfile.h (generic_load): ... to here.  Rename name parameter
 491         to args.
 492         * symfile.c (generic_load): Add comment.
 493
 494 2019-07-01  Tom Tromey  <tromey@adacore.com>
 495
 496         * dwarf2read.c
 497         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 498         declaration of without_params.  Fix formatting.
 499
 500 2019-07-01  Tom Tromey  <tromey@adacore.com>
 501
 502         * ada-exp.y (find_primitive_type): Update.
 503         * ada-lang.h (ada_lookup_symbol): Update.
 504         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 505         parameter.
 506         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 507
 508 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 509
 510         PR breakpoints/24541
 511         * gdbarch.c: Regenerate.
 512         * gdbarch.h: Regenerate.
 513         * gdbarch.sh: Add 'stap_adjust_register'.
 514         * i386-tdep.c: Include '<unordered_set>'.
 515         (i386_stap_adjust_register): New function.
 516         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 517         * stap-probe.c (stap_parse_register_operand): Call
 518         'gdbarch_stap_adjust_register'.
 519
 520 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 521
 522         PR python/24742
 523         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 524         * python/python.c (do_start_initialization): Use 'xmalloc'
 525         instead of 'PyMem_Malloc'.
 526
 527 2019-06-28  Tom Tromey  <tromey@adacore.com>
 528
 529         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 530         for Ada.
 531
 532 2019-06-27  Tom Tromey  <tromey@adacore.com>
 533
 534         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 535         objfile_key.
 536         (arm_find_mapping_symbol, arm_record_special_symbol)
 537         (_initialize_arm_tdep): Update.
 538         (arm_objfile_data_free): Remove.
 539
 540 2019-06-27  Tom Tromey  <tromey@adacore.com>
 541
 542         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 543         to cp_print_static_field.
 544
 545 2019-06-26  Tom Tromey  <tromey@adacore.com>
 546
 547         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 548         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 549         declare.
 550
 551 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 552
 553         * features/aarch64-core.c (create_feature_aarch64_core):
 554         Regenerate.
 555         * features/aarch64-core.xml: Add cpsr flags.
 556
 557 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 558
 559         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 560         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 561
 562 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 563
 564         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 565         field.
 566         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 567         use.
 568         (arm_record_special_symbol): Don't insert new symbol in sorted
 569         position, push it at the end.
 570
 571 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 572
 573         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 574         (arm_mapping_symbol_s): Remove.
 575         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 576         (arm_mapping_symbol_vec): New typedef.
 577         (struct arm_per_objfile): Add constructor.
 578         <section_maps>: Change type to
 579         std::unique_ptr<arm_mapping_symbol_vec[]>.
 580         (arm_compare_mapping_symbols): Remove.
 581         (arm_find_mapping_symbol): Adjust to section_maps type change.
 582         (arm_objfile_data_free): Call delete on arm_per_objfile.
 583         (arm_record_special_symbol): Adjust to section_maps type change.
 584         Allocate arm_per_objfile with new.
 585
 586 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 587
 588         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 589         with the command prefix.
 590
 591 2019-06-25  Tom Tromey  <tom@tromey.com>
 592
 593         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 594         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 595
 596 2019-06-25  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 599         type.
 600         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 601         protected.
 602
 603 2019-06-25  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-winsource.c
 606         (tui_source_window_base::set_is_exec_point_at): Add check against
 607         LOA_ADDRESS.
 608
 609 2019-06-25  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-source.c (tui_set_source_content): Don't check before
 612         xfree.
 613         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 614
 615 2019-06-25  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-winsource.h (tui_update_source_window_as_is)
 618         (tui_alloc_source_buffer, tui_line_is_displayed)
 619         (tui_addr_is_displayed): Change type of win_info.
 620         * tui/tui-winsource.c (tui_update_source_window_as_is)
 621         (tui_clear_source_content, tui_show_source_line)
 622         (tui_show_source_content, tui_source_window_base::refill)
 623         (tui_source_window_base::set_is_exec_point_at)
 624         (tui_source_window_base::set_is_exec_point_at)
 625         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 626         (tui_alloc_source_buffer, tui_line_is_displayed)
 627         (tui_addr_is_displayed): Change type of win_info.  Update.
 628         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 629         (tui_source_window_base::do_make_visible_with_new_height):
 630         Update.
 631         * tui/tui-source.c (tui_set_source_content)
 632         (tui_set_source_content_nil)
 633         (tui_source_window::do_scroll_vertical): Update.
 634         * tui/tui-layout.c (show_layout): Update.
 635         * tui/tui-disasm.c (tui_set_disassem_content)
 636         (tui_disasm_window::do_scroll_vertical): Update.
 637         * tui/tui-data.h (tui_win_content): Remove.
 638         (struct tui_gen_win_info) <content, content_size>: Remove.
 639         (struct tui_source_element): Add initializers and destructor.
 640         (union tui_which_element, struct tui_win_element): Remove.
 641         (struct tui_source_window_base) <content>: New field.
 642         (struct tui_data_window): Remove destructor.
 643         (tui_alloc_content, tui_free_win_content)
 644         (tui_free_all_source_wins_content): Don't declare.
 645         * tui/tui-data.c (tui_initialize_static_data): Update.
 646         (init_content_element, tui_alloc_content): Remove.
 647         (~tui_gen_win_info): Update.
 648         (~tui_data_window, tui_free_all_source_wins_content)
 649         (tui_free_win_content, free_content, free_content_elements):
 650         Remove.
 651
 652 2019-06-25  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-winsource.h (tui_clear_source_content)
 655         (tui_erase_source_content, tui_show_source_content): Change type
 656         of win_info.
 657         * tui/tui-winsource.c (tui_clear_source_content)
 658         (tui_erase_source_content, tui_show_source_content): Change type
 659         of win_info.
 660         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 661         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 662         win_info.
 663         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 664         win_info.
 665         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 666
 667 2019-06-25  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-winsource.c (tui_clear_source_content)
 670         (tui_source_window_base::set_is_exec_point_at): Update.
 671         * tui/tui-source.c (tui_set_source_content_nil): Update.
 672         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 673         a bool.
 674         * tui/tui-data.c (init_content_element): Update.
 675
 676 2019-06-25  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 679         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 680         * tui/tui-layout.c (init_and_make_win): Update.
 681         * tui/tui.h (enum tui_win_type): Update.
 682         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 683         tui_win_is_auxillary.
 684         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 685         tui_win_is_auxillary.
 686
 687 2019-06-25  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 690         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 691         (tui_delete_data_content_windows, tui_display_all_data)
 692         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 693         Update.
 694         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 695         * tui/tui-regs.c (tui_last_regs_line_no)
 696         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 697         (tui_show_registers): Update.
 698         (tui_show_register_group): Return void.  Update.
 699         (tui_display_registers_from, tui_display_reg_element_at_line)
 700         (tui_display_registers_from_line, tui_check_register_values):
 701         Update.
 702         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 703         member.
 704         (struct tui_data_window) <regs_content>: Now a std::vector.
 705         <regs_content_count>: Remove.
 706         (tui_add_content_elements, tui_free_data_content): Don't declare.
 707         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 708         (init_content_element): Remove DATA_WIN case.  Add assert.
 709         (tui_add_content_elements): Remove.
 710         (tui_data_window): Update.
 711         (tui_free_data_content): Remove.
 712         (free_content_elements): Remove DATA_WIN case.
 713
 714 2019-06-25  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-data.c (tui_data_item_window): Update.
 717         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 718         * tui/tui-windata.c (tui_display_all_data)
 719         (tui_display_data_from_line): Update.
 720         (tui_check_data_values): Remove.
 721         * tui/tui-regs.c (tui_show_register_group)
 722         (tui_display_reg_element_at_line): Update.
 723         * tui/tui-hooks.c (tui_register_changed)
 724         (tui_refresh_frame_and_register_information): Call
 725         tui_check_register_values.
 726         * tui/tui-data.h (struct tui_data_window) <data_content,
 727         data_content_count, data_type>: Remove.
 728         (enum tui_data_type): Remove.
 729
 730         * tui/tui-data.c (tui_data_window::clear_detail)
 731         (~tui_data_window): Update.
 732
 733 2019-06-25  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 736         declare.
 737         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 738         Rename from tui_first_data_item_displayed.  Update.
 739         (tui_data_window::refresh_all)
 740         (tui_data_window::do_scroll_vertical): Update.
 741         * tui/tui-data.h (struct tui_data_window)
 742         <first_data_item_displayed>: Declare new method.
 743
 744 2019-06-25  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 747         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 748         contents...
 749         (tui_initialize_static_data): ...here.
 750
 751 2019-06-25  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 754         (tui_display_registers_from, tui_check_register_values): Update.
 755         (tui_display_register): Remove win_info parameter; update.
 756         (tui_get_register): Change type of parameters.
 757         * tui/tui-data.h (struct tui_data_element): Remove.
 758         (union tui_which_element) <data>: Remove.
 759         <data_window>: Change type.
 760         (struct tui_data_item_window): New.
 761         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 762         case.  Add assert.
 763         (~tui_data_item_window): New destructor.
 764         (free_content_elements): Remove DATA_ITEM_WIN case.
 765
 766 2019-06-25  Tom Tromey  <tom@tromey.com>
 767
 768         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 769         Remove.
 770
 771 2019-06-25  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-data.h (struct tui_command_element): Remove.
 774         (union tui_which_element) <command>: Remove.
 775         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 776         assert.
 777         (free_content_elements): Remove CMD_WIN case.
 778
 779 2019-06-25  Tom Tromey  <tom@tromey.com>
 780
 781         * tui/tui-layout.c (tui_set_layout): Update.
 782         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 783         * tui/tui-data.c (layout_def): Update.
 784
 785 2019-06-25  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 788         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 789         (tui_source_window_base::set_new_height): Update.
 790         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 791         Update.
 792         (tui_set_locator_fullname, tui_set_locator_info)
 793         (tui_show_frame_info): Update.
 794         * tui/tui-source.c (tui_set_source_content)
 795         (tui_source_is_displayed): Update.
 796         * tui/tui-layout.c (show_source_disasm_command, show_data)
 797         (show_source_or_disasm_and_command): Update.
 798         * tui/tui-disasm.c (tui_set_disassem_content)
 799         (tui_get_begin_asm_address): Update.
 800         * tui/tui-data.h (struct tui_locator_element): Remove.
 801         (union tui_which_element) <locator>: Remove.
 802         (struct tui_locator_window): New.
 803         (tui_locator_win_info_ptr): Change return type.
 804         * tui/tui-data.c (_locator): Change type.
 805         (tui_locator_win_info_ptr): Change return type.
 806         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 807         (tui_alloc_content): Add assert.
 808
 809 2019-06-25  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-winsource.c
 812         (tui_exec_info_window::maybe_allocate_content): New method.
 813         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 814         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 815         (make_source_or_disasm_window): Add cast.
 816         * tui/tui-data.h (union tui_which_element) <simple_string>:
 817         Remove.
 818         (struct tui_source_info): New.
 819         (struct tui_source_window_base) <execution_info>: Change type.
 820         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 821         case, and add assert.
 822         (tui_alloc_content): Add assert.
 823
 824 2019-06-25  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 827         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 828         * tui/tui-data.c (tui_alloc_win_info): Remove.
 829
 830 2019-06-25  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 833         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 834         can_highlight.
 835
 836 2019-06-25  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 839         make_visible_with_new_height method.
 840         (tui_win_info::make_visible_with_new_height): New method.
 841         (tui_source_window_base::do_make_visible_with_new_height)
 842         (tui_data_window::do_make_visible_with_new_height)
 843         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 844         (make_visible_with_new_height): Remove.
 845         (tui_resize_all, tui_adjust_win_heights): Use
 846         make_visible_with_new_height method.
 847         * tui/tui-data.h (struct tui_win_info)
 848         <do_make_visible_with_new_height, make_visible_with_new_height>:
 849         New methods.
 850         (struct tui_source_window_base, struct tui_data_window)
 851         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 852         methods.
 853
 854 2019-06-25  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 857         method.
 858         (update_tab_width): Call update_tab_width method.
 859         * tui/tui-data.h (struct tui_win_info)
 860         (struct tui_source_window_base) <update_tab_width>: New methods.
 861
 862 2019-06-25  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 865         parameter.
 866         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 867         parameter.
 868         (tui_gen_win_info::make_visible): Update.
 869         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 870         parameter.
 871         * tui/tui-data.h (enum tui_box): New enum.
 872         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 873
 874 2019-06-25  Tom Tromey  <tom@tromey.com>
 875
 876         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 877         init_and_make_win for EXEC_INFO_WIN.
 878         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 879         longer inline.
 880         (struct tui_win_info) <~tui_win_info>: Inline.
 881         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 882         Don't declare.
 883         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 884         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 885         Remove.
 886         (tui_initialize_static_data): Update.
 887         (~tui_gen_win_info): Handle more cleanup here.
 888         (~tui_source_window_base): Delete "execution_info".
 889         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 890
 891 2019-06-25  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-layout.c (make_command_window): Don't set
 894         can_highlight.
 895         (show_source_disasm_command): Call the reset method.
 896         (show_data): Don't set can_highlight.  Call the reset method.
 897         (tui_gen_win_info::reset): Rename from init_gen_win_info
 898         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 899         (show_source_or_disasm_and_command): Call the reset method.
 900         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 901         (struct tui_cmd_window): Set can_highlight.
 902
 903 2019-06-25  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 906         from make_visible.
 907         (tui_make_visible, tui_make_invisible): Rewrite.
 908         (tui_win_info::make_visible): Remove.
 909         (tui_source_window_base::make_visible): Update.
 910         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 911         method.  Moved from...
 912         (struct tui_win_info) <make_visible>: ...here.
 913
 914 2019-06-25  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-winsource.c
 917         (tui_source_window_base::do_scroll_horizontal): Remove direction
 918         parameter.
 919         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 920         direction parameter.
 921         * tui/tui-win.c (tui_win_info::forward_scroll)
 922         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 923         (tui_win_info::right_scroll): Update.
 924         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 925         direction parameter.
 926         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 927         direction parameter.
 928         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 929         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 930         Remove direction parameter.
 931         (struct tui_source_window_base, struct tui_source_window)
 932         (struct tui_disasm_window, struct tui_data_window)
 933         (struct tui_cmd_window): Update.
 934
 935 2019-06-25  Tom Tromey  <tom@tromey.com>
 936
 937         * tui/tui-winsource.h (tui_set_exec_info_content)
 938         (tui_show_exec_info_content, tui_erase_exec_info_content)
 939         (tui_clear_exec_info_content, tui_update_exec_info): Change
 940         argument to tui_source_window_base.
 941         * tui/tui-winsource.c (tui_set_exec_info_content)
 942         (tui_show_exec_info_content, tui_erase_exec_info_content)
 943         (tui_clear_exec_info_content, tui_update_exec_info): Change
 944         argument to tui_source_window_base.
 945
 946 2019-06-25  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 949         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 950
 951 2019-06-25  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 954         check.
 955
 956 2019-06-25  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 959         type to void.
 960         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 961         type to void.
 962         * tui/tui-source.c (tui_set_source_content): Update.
 963         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 964
 965 2019-06-25  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-win.c (window_name_completer, tui_set_focus)
 968         (tui_all_windows_info): Use name method.
 969         * tui/tui-data.h (struct tui_gen_win_info)
 970         (struct tui_source_window, struct tui_disasm_window)
 971         (struct tui_data_window, struct tui_cmd_window) <name>: New
 972         method.
 973         (tui_win_name): Don't declare.
 974         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 975         (tui_win_name): Remove.
 976
 977 2019-06-25  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-winsource.h (tui_update_source_window)
 980         (tui_update_source_window_as_is): Change parameter type.
 981         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 982         to be a tui_source_window_base.
 983         (tui_update_source_window_as_is): Likewise.
 984         * tui/tui-win.c (make_visible_with_new_height): Update.
 985
 986 2019-06-25  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-winsource.c (tui_erase_source_content)
 989         (tui_show_source_content, tui_show_exec_info_content)
 990         (tui_erase_exec_info_content): Use refresh_window method.
 991         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 992         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 993         from tui_refresh_win.
 994         (tui_data_window::refresh_window): New method.
 995         (tui_win_info::refresh, tui_source_window_base::refresh)
 996         (tui_refresh_all): Use refresh_window method.
 997         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 998         method.
 999         * tui/tui-regs.c (tui_display_register): Call refresh_window
1000         method.
1001         * tui/tui-layout.c (show_source_disasm_command)
1002         (show_source_or_disasm_and_command): Call refresh_window method.
1003         * tui/tui-data.h (struct tui_gen_win_info)
1004         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1005         New method.
1006
1007 2019-06-25  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui.c (tui_rl_other_window, tui_enable)
1010         (tui_is_window_visible, tui_get_command_dimension): Update.
1011         * tui/tui-winsource.c (tui_update_source_window_as_is)
1012         (tui_clear_source_content, tui_erase_source_content)
1013         (tui_show_source_line, tui_source_window_base::refill)
1014         (tui_source_window_base::do_scroll_horizontal)
1015         (tui_source_window_base::set_is_exec_point_at)
1016         (tui_update_breakpoint_info, tui_set_exec_info_content)
1017         (tui_alloc_source_buffer, tui_line_is_displayed)
1018         (tui_addr_is_displayed): Update.
1019         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1020         (tui_check_and_display_highlight_if_needed)
1021         (tui_win_info::make_visible, tui_win_info::refresh)
1022         (tui_refresh_all): Update.
1023         * tui/tui-windata.c (tui_first_data_item_displayed)
1024         (tui_delete_data_content_windows, tui_erase_data_content)
1025         (tui_display_all_data, tui_data_window::refresh_all)
1026         (tui_check_data_values): Update.
1027         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1028         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1029         (tui_win_info::backward_scroll, tui_refresh_all_win)
1030         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1031         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1032         (tui_source_window_base::set_new_height)
1033         (tui_data_window::set_new_height)
1034         (make_invisible_and_set_new_height)
1035         (make_visible_with_new_height, new_height_ok)
1036         (parse_scrolling_args): Update.
1037         * tui/tui-stack.c (tui_show_frame_info): Update.
1038         * tui/tui-source.c (tui_set_source_content)
1039         (tui_set_source_content_nil, tui_source_is_displayed)
1040         (tui_source_window::do_scroll_vertical): Update.
1041         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1042         (tui_display_registers_from, tui_display_reg_element_at_line)
1043         (tui_check_register_values, tui_reg_command): Update.
1044         * tui/tui-layout.c (tui_default_win_height)
1045         (show_source_disasm_command, show_data, init_and_make_win)
1046         (show_source_or_disasm_and_command): Update.
1047         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1048         (tui_redisplay_readline, tui_mld_flush)
1049         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1050         (tui_getc): Update.
1051         * tui/tui-disasm.c (tui_set_disassem_content)
1052         (tui_disasm_window::do_scroll_vertical): Update.
1053         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1054         Now virtual.
1055         (struct tui_win_info): Derive from tui_gen_win_info.
1056         <~tui_win_info>: Mark as override.
1057         <generic>: Remove member.
1058         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1059         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1060         (~tui_data_window, ~tui_win_info)
1061         (tui_free_all_source_wins_content): Update.
1062         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1063
1064 2019-06-25  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-layout.c (init_and_make_win): Use new.
1067         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1068         destructor, initializers.
1069         (tui_alloc_generic_win_info): Don't declare.
1070         * tui/tui-data.c (_locator): Add argument to constructor.
1071         (source_win, disasm_win): New globals.
1072         (exec_info): Remove.
1073         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1074         Update.
1075         (tui_alloc_generic_win_info): Remove.
1076         (init_content_element): Use new.
1077         (tui_win_info::tui_win_info): Update.
1078         (free_content_elements) <case DATA_WIN>: Use delete.
1079
1080 2019-06-25  Tom Tromey  <tom@tromey.com>
1081
1082         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1083         * tui/tui-windata.c (tui_first_data_item_displayed)
1084         (tui_delete_data_content_windows): Update.
1085         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1086         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1087         (tui_display_registers_from, tui_check_register_values): Update.
1088         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1089         pointer.
1090         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1091         window.
1092         (tui_free_data_content): Update.
1093         (free_content_elements) <case DATA_WIN>: Free the window.
1094
1095 2019-06-25  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1098         Update.
1099         * tui/tui-layout.c (make_command_window)
1100         (show_source_disasm_command, show_data, init_and_make_win)
1101         (show_source_or_disasm_and_command): Update.
1102         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1103         method.
1104         <can_highight, is_highlighted>: Now bool.
1105         (tui_set_win_highlight): Don't declare.
1106         * tui/tui-data.c (tui_set_win_highlight): Remove.
1107
1108 2019-06-25  Tom Tromey  <tom@tromey.com>
1109
1110         * tui/tui-wingeneral.c (make_visible): Remove check of window
1111         type.
1112
1113 2019-06-25  Tom Tromey  <tom@tromey.com>
1114
1115         * tui/tui-win.c (tui_win_info::max_height)
1116         (tui_cmd_window::max_height): New methods.
1117         (new_height_ok): Call max_height.
1118         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1119         <max_height>: New method.
1120
1121 2019-06-25  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-win.c (tui_source_window_base::set_new_height)
1124         (tui_data_window::set_new_height): New methods.
1125         (make_invisible_and_set_new_height): Call set_new_height method.
1126         * tui/tui-data.h (struct tui_win_info)
1127         (struct tui_source_window_base, struct tui_data_window)
1128         <set_new_height>: New method.
1129
1130 2019-06-25  Tom Tromey  <tom@tromey.com>
1131
1132         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1133         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1134         tui_refresh_data_win.
1135         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1136         method.
1137         (tui_refresh_all_win): Call the refresh_all method.
1138         (tui_set_focus): Likewise.
1139         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1140         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1141         Likewise.
1142
1143 2019-06-25  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-winsource.h (tui_refill_source_window)
1146         (tui_set_is_exec_point_at): Don't declare.
1147         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1148         (tui_source_window_base::refill): Rename from
1149         tui_refill_source_window.
1150         (tui_source_window_base::do_scroll_horizontal): Update.
1151         (tui_source_window_base::set_is_exec_point_at): Rename from
1152         tui_set_is_exec_point_at.
1153         (tui_update_all_breakpoint_info): Update.
1154         * tui/tui-stack.c (tui_show_frame_info): Update.
1155         * tui/tui-layout.c (show_data): Add cast.
1156         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1157         * tui/tui-data.h (struct tui_source_window_base) <refill,
1158         set_is_exec_point_at>: New methods.
1159         (tui_source_windows, tui_add_to_source_windows): Update types.
1160         (tui_add_to_source_windows): Remove redundant declaration.
1161         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1162         (tui_source_windows): Change return type.
1163         (tui_clear_source_windows_detail): Update.
1164         (tui_add_to_source_windows): Change type of parameter.
1165         (tui_free_all_source_wins_content): Update.
1166
1167 2019-06-25  Tom Tromey  <tom@tromey.com>
1168
1169         * tui/tui-wingeneral.c (tui_win_info::refresh)
1170         (tui_source_window_base::refresh): New methods.
1171         (tui_refresh_all): Call the refresh method.
1172         * tui/tui-data.h (struct tui_win_info)
1173         (struct tui_source_window_base) <refresh>: New method.
1174
1175 2019-06-25  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui.h (tui_is_window_visible): Return bool.
1178         * tui/tui.c (tui_is_window_visible): Return bool.
1179         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1180         (tui_make_visible, tui_make_invisible)
1181         (tui_win_info::make_visible)
1182         (tui_source_window_base::make_visible, make_all_visible)
1183         (tui_make_all_visible, tui_make_all_invisible): Update.
1184         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1185         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1186         bool.
1187         (struct tui_win_info, struct tui_source_window_base)
1188         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1189         * tui/tui-data.c (tui_init_generic_part): Update.
1190
1191 2019-06-25  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1194         (tui_source_window_base::make_visible): New methods.
1195         (make_all_visible): Make method call.
1196         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1197         (struct tui_source_window_base, struct tui_cmd_window): Override
1198         make_visible.
1199         (tui_win_is_source_type): Don't declare.
1200         * tui/tui-data.c (tui_win_is_source_type): Remove.
1201
1202 2019-06-25  Tom Tromey  <tom@tromey.com>
1203
1204         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1205         NULL check.
1206
1207 2019-06-25  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1210         Inline constructor.  Add initializers for members.
1211         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1212         constructors; now inline in class.
1213
1214 2019-06-25  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-regs.c (tui_show_registers): Update.
1217         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1218         bool.
1219         * tui/tui-data.c (tui_data_window::clear_detail)
1220         (tui_data_window): Update.
1221
1222 2019-06-25  Tom Tromey  <tom@tromey.com>
1223
1224         * tui/tui-windata.c (tui_display_all_data)
1225         (tui_display_data_from_line, tui_display_data_from)
1226         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1227         Update.
1228         * tui/tui-regs.c (tui_last_regs_line_no)
1229         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1230         (tui_show_registers, tui_show_register_group)
1231         (tui_display_registers_from, tui_display_reg_element_at_line)
1232         (tui_display_registers_from_line, tui_check_register_values)
1233         (tui_reg_next, tui_reg_prev): Update.
1234         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1235         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1236         tui_data_window.
1237         (struct tui_win_info) <detail>: Remove.  Add new fields from
1238         tui_data_info.
1239         (TUI_DATA_WIN): Add cast.
1240         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1241         (~tui_data_window): Simplify.
1242
1243 2019-06-25  Tom Tromey  <tom@tromey.com>
1244
1245         * tui/tui-layout.c (show_source_disasm_command)
1246         (show_source_or_disasm_and_command): Update.
1247         * tui/tui-io.c (update_cmdwin_start_line)
1248         (tui_redisplay_readline): Update.
1249         * tui/tui-data.h (struct tui_command_info): Remove.
1250         (struct tui_win_info) <detail>: Remove command_info member.
1251         (struct tui_data_window) <start_line>: New member, from
1252         tui_command_info.
1253         (TUI_CMD_WIN): Add casts.
1254
1255 2019-06-25  Tom Tromey  <tom@tromey.com>
1256
1257         * tui/tui-winsource.c (tui_update_source_window)
1258         (tui_refill_source_window)
1259         (tui_source_window_base::do_scroll_horizontal)
1260         (tui_update_breakpoint_info, tui_set_exec_info_content)
1261         (tui_show_exec_info_content, tui_erase_exec_info_content)
1262         (tui_clear_exec_info_content): Update.
1263         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1264         Update.
1265         * tui/tui-win.c (make_invisible_and_set_new_height)
1266         (make_visible_with_new_height): Update.
1267         * tui/tui-source.c (tui_set_source_content)
1268         (tui_show_symtab_source): Update.
1269         * tui/tui-layout.c (extract_display_start_addr)
1270         (show_source_disasm_command, show_data)
1271         (make_source_or_disasm_window)
1272         (show_source_or_disasm_and_command): Update.
1273         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1274         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1275         "gdbarch".
1276         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1277         to tui_source_window_base.
1278         (struct tui_win_info) <detail>: Remove source_info member.
1279         (struct tui_source_window_base) <has_locator>: Inline.
1280         Move contents from tui_source_info; rename has_locator member to
1281         m_has_locator.
1282         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1283         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1284         header file.
1285         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1286         Simplify.
1287         (tui_free_all_source_wins_content): Cast to
1288         tui_source_window_base.
1289
1290 2019-06-25  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-win.c (make_invisible_and_set_new_height)
1293         (make_visible_with_new_height): Call has_locator method.
1294         * tui/tui-layout.c (show_source_disasm_command, show_data)
1295         (show_source_or_disasm_and_command): Update for bool change.
1296         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1297         (tui_win_info) <has_locator>: New method.
1298         (struct tui_source_window_base) <has_locator>: New method.
1299         (tui_win_has_locator): Don't declare.
1300         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1301         from tui_win_has_locator.
1302         (tui_source_window_base): Use false, not FALSE.
1303
1304 2019-06-25  Tom Tromey  <tom@tromey.com>
1305
1306         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1307         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1308         clear_detail method directly.
1309         (tui_clear_win_detail): Remove.
1310
1311 2019-06-25  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1314         "this", not TUI_DISASM_WIN.
1315
1316 2019-06-25  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1319         declare.
1320         * tui/tui-winsource.c
1321         (tui_source_window_base::do_scroll_horizontal): Rename from
1322         tui_horizontal_source_scroll.
1323         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1324         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1325         from tui_vertical_data_scroll.
1326         * tui/tui-win.h (tui_scroll): Don't declare.
1327         * tui/tui-win.c (tui_win_info::forward_scroll)
1328         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1329         (tui_win_info::right_scroll): Rename and update.
1330         (tui_scroll_forward_command, tui_scroll_backward_command)
1331         (tui_scroll_left_command, tui_scroll_right_command): Update.
1332         (tui_scroll): Remove.
1333         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1334         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1335         from tui_vertical_source_scroll.
1336         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1337         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1338         from tui_vertical_disassem_scroll.
1339         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1340         do_scroll_horizontal>: New methods.
1341         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1342         Likewise.
1343         (struct tui_source_window_base): Add do_scroll_horizontal.
1344         (struct tui_source_window, struct tui_disasm_window): Add
1345         do_scroll_vertical.
1346         (struct tui_data_window, struct tui_cmd_window): Add
1347         do_scroll_horizontal and do_scroll_vertical.
1348         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1349
1350 2019-06-25  Tom Tromey  <tom@tromey.com>
1351
1352         * tui/tui-data.h (struct tui_source_window_base): New struct.
1353         (struct tui_source_window): Derive from tui_source_window_base.
1354         (struct tui_disasm_window): New struct.
1355         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1356         from tui_source_window::clear_detail.
1357         (tui_source_window_base): Rename from tui_source_window.
1358         (~tui_source_window_base): Rename from ~tui_source_window.
1359         (tui_alloc_win_info): Create a tui_disasm_window.
1360
1361 2019-06-25  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-data.h (struct tui_source_window)
1364         (struct tui_data_window): Declare destructors.
1365         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1366         destructors.
1367         (tui_win_info): Simplify.
1368
1369 2019-06-25  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-winsource.c (tui_display_main)
1372         (tui_update_source_windows_with_addr)
1373         (tui_update_all_breakpoint_info): Update.
1374         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1375         (new_height_ok, parse_scrolling_args): Update.
1376         * tui/tui-stack.c (tui_show_frame_info): Update.
1377         * tui/tui-data.h (struct tui_list): Remove.
1378         (tui_source_windows): Return a reference to a std::vector.
1379         * tui/tui-data.c (source_windows): Now a std::vector.
1380         (tui_source_windows): Change return type.
1381         (tui_clear_source_windows): Rewrite.
1382         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1383         (tui_free_all_source_wins_content): Rewrite.
1384
1385 2019-06-25  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1388         (struct tui_data_window, struct tui_cmd_window): Declare
1389         clear_detail method.
1390         * tui/tui-data.c (tui_source_window::clear_detail)
1391         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1392         methods.
1393         (tui_clear_win_detail): Simplify.
1394
1395 2019-06-25  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui-layout.c (make_source_window, make_disasm_window)
1398         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1399         Return the new window.
1400         (show_source_disasm_command, show_data)
1401         (show_source_or_disasm_and_command): Update.
1402
1403 2019-06-25  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1406         parameter.  Return the new window.
1407         (show_source_disasm_command): Update and remove NULL check.
1408         (show_source_or_disasm_and_command): Update.
1409
1410 2019-06-25  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1413
1414 2019-06-25  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-data.h (struct tui_win_info): Make constructor
1417         protected.  Make destructor virtual.  Add initializers.
1418         (tui_source_window, tui_data_window, tui_cmd_window): New
1419         classes.
1420         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1421         constructor.  Add "type" parameter.
1422         (tui_source_window, tui_data_window, tui_cmd_window): New
1423         constructors.
1424         (tui_alloc_win_info): Instantiate the appropriate subclass.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-win.c (tui_resize_all): Use delete.
1429         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1430         destructor.
1431         (tui_free_window): Don't declare.
1432         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1433         Update.
1434
1435 2019-06-25  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-data.h (struct tui_win_info): Add constructor.
1438         * tui/tui-data.c (tui_alloc_win_info): Use new.
1439         (tui_free_window): Use delete.
1440
1441 2019-06-22  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1444         declare.
1445         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1446
1447 2019-06-22  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1450         declare.
1451         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1452
1453 2019-06-22  Tom de Vries  <tdevries@suse.de>
1454
1455         * dwarf2read.c (create_addrmap_from_aranges)
1456         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1457         instead of '%zu'.
1458
1459 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1460
1461         * dwarf2read.h (dwarf2_section_info_def): Remove.
1462         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1463         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1464         std::vector<dwarf2_section_info>.
1465         (struct dwo_file) <~dwo_file>: Remove.
1466         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1467         types field.
1468         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1469         (dwarf2_read_debug_names): Likewise.
1470         (create_debug_types_hash_table): Change parameter type to
1471         array_view, adjust code accordingly.
1472         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1473         (partial_die_info::fixup): Likewise.
1474         (determine_prefix): Likewise.
1475         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1476
1477 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1478
1479         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1480         gdb_bfd_ref_ptr.
1481         <~dwo_file>: Remove call to gdb_bfd_unref.
1482         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1483         gdb_bfd_ref_ptr::get.
1484
1485 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1486
1487         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1488         type to htab_up.
1489         * dwarf2read.c (struct dwo_file): Initialize fields.
1490         <~dwo_file>: New.
1491         (free_dwo_file): Remove, move content to ~dwo_file.
1492         (struct dwo_file_deleter): Remove.
1493         (dwo_file_up>: Remove custom deleter.
1494         (free_dwo_files): Remove.
1495         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1496         dwo_files.
1497         (process_skeletonless_type_units): Call unique_ptr::get.
1498         (allocate_dwo_file_hash_table): Add deleter to created hash
1499         table.  Change return type to htab_up.
1500         (lookup_dwo_file_slot): Don't memset dwo_file, call
1501         unique_ptr::get.
1502         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1503         (create_dwo_unit_in_dwp_v2): Likewise.
1504         (open_and_init_dwo_file): Likewise.
1505         (free_dwo_file_from_slot): Remove.
1506
1507 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1508
1509         * dwarf2read.h (struct dwarf2_section_info) <readin,
1510         is_virtual>: Change type to bool.
1511         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1512         true instead of 1.
1513
1514 2019-06-19  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-data.h (tui_init_content_element): Don't declare.
1517
1518 2019-06-19  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-data.h (tui_init_win_info): Don't declare.
1521
1522 2019-06-19  Tom de Vries  <tdevries@suse.de>
1523
1524         * dwarf2read.h (abstract_to_concrete): Change type to
1525         std::unordered_map<sect_offset, std::vector<sect_offset>,
1526         gdb::hash_enum<sect_offset>>.
1527
1528 2019-06-19  Tom Tromey  <tromey@adacore.com>
1529
1530         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1531         EVAL_AVOID_SIDE_EFFECTS specially.
1532
1533 2019-06-19  Tom Tromey  <tromey@adacore.com>
1534
1535         * source-cache.c (highlighter): New global.
1536         (source_cache::get_source_lines): Create a highlighter on demand.
1537
1538 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * defs.h (deprecated_interactive_hook): Delete declaration.
1541         * interps.c (clear_interpreter_hooks): Remove use of
1542         deprecated_interactive_hook.
1543         * top.c (deprecated_interactive_hook): Delete definition.
1544         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1545
1546 2019-06-18  Tom de Vries  <tdevries@suse.de>
1547
1548         PR gdb/24515
1549         * dwarf2read.h (abstract_to_concrete): Change type from
1550         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1551         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1552         * dwarf2read.c (read_variable): Update.
1553         (dwarf2_fetch_die_loc_sect_off): Update.
1554
1555 2019-06-17  Tom de Vries  <tdevries@suse.de>
1556
1557         PR gdb/24617
1558         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1559         accessing parent[parent_len - 1].
1560
1561 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1562
1563         PR gdb/24364
1564         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1565         call dtrace_process_dof with NULL dof.
1566
1567 2019-06-16  Tom de Vries  <tdevries@suse.de>
1568
1569         PR gdb/24445
1570         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1571
1572 2019-06-16  Tom Tromey  <tom@tromey.com>
1573
1574         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1575         (make_all_visible): Use address of member.
1576
1577 2019-06-16  Tom Tromey  <tom@tromey.com>
1578
1579         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1580         (tui_free_window, free_content, free_content_elements): Remove
1581         unnecessary cast.
1582         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1583         cast.
1584         * tui/tui-regs.c (tui_show_register_group)
1585         (tui_display_registers_from, tui_display_reg_element_at_line):
1586         Remove unnecessary cast.
1587
1588 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * linux-nat.c (normal_mask): Delete.
1591         (_initialize_linux_nat): Don't initialise normal_mask.
1592
1593 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1594
1595         PR gdb/24445
1596         * dwarf-index-write.h (write_psymtabs_to_index): Add
1597         dwz_basename parameter.
1598         * dwarf-index-write.c (write_gdbindex): Move file writing to
1599         write_gdbindex_1.  Change return type void.
1600         (assert_file_size): Move up, remove filename parameter.
1601         (write_gdbindex_1): New function.
1602         (write_debug_names): Change return type to void, call
1603         assert_file_size.
1604         (struct index_wip_file): New struct.
1605         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1606         file logic to index_wip_file.  Write index for dwz file if
1607         needed.
1608         (save_gdb_index_command): Pass basename of dwz file, if present.
1609         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1610         build-id of dwz file, if present.
1611         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1612         (dwarf2_get_dwz_file): Likewise.
1613         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1614         (dwarf2_get_dwz_file): Likewise.
1615
1616 2019-06-16  Tom Tromey  <tom@tromey.com>
1617
1618         * coffread.c (process_coff_symbol): Use xstrdup.
1619         * value.c (create_internalvar): Use xstrdup.
1620
1621 2019-06-16  Tom Tromey  <tom@tromey.com>
1622
1623         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1624         * breakpoint.c (stopin_command, stopat_command)
1625         (until_break_command, decode_location_default): Remove unnecessary
1626         cast.
1627         * utils.c (subset_compare): Remove unnecessary cast.
1628         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1629         cast.
1630         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1631         cast.
1632         * infcmd.c (path_command): Remove unnecessary cast.
1633         * coffread.c (decode_type): Remove unnecessary cast.
1634         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1635         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1636         * tui/tui-stack.c (tui_show_locator_content)
1637         (tui_show_frame_info): Remove unnecessary cast.
1638         * tui/tui-win.c (tui_scroll_forward_command)
1639         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1640         (parse_scrolling_args): Remove unnecessary cast.
1641         * tui/tui-data.c (init_win_info, tui_del_window)
1642         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1643         (free_content_elements): Remove unnecessary cast.
1644         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1645         unnecessary cast.
1646         * tui/tui-source.c (tui_set_source_content)
1647         (tui_vertical_source_scroll): Remove unnecessary cast.
1648         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1649         cast.
1650         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1651         * tui/tui-regs.c (tui_display_registers_from)
1652         (tui_display_register): Remove unnecessary cast.
1653         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1654         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1655         (make_visible): Remove unnecessary cast.
1656         * tui/tui-winsource.c (tui_erase_source_content)
1657         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1658         unnecessary cast.
1659         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1660         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1661         * stabsread.c (read_type, read_array_type, read_range_type):
1662         Remove unnecessary cast.
1663         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1664         (parse_symbol, parse_type, upgrade_type, parse_external)
1665         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1666         unnecessary cast.
1667         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1668
1669 2019-06-16  Tom Tromey  <tom@tromey.com>
1670
1671         * tui/tui-data.c (tui_alloc_generic_win_info)
1672         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1673         checks.
1674
1675 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1676             Andrew Burgess  <andrew.burgess@embecosm.com>
1677
1678         * f-typeprint.c (f_print_type): Don't return early for not
1679         associated or not allocated types.
1680         (f_type_print_varspec_suffix): Add print_rank parameter and print
1681         ranks of array types in case they dangling.
1682         (f_type_print_base): Add print_rank parameter.
1683
1684 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1685
1686         * NEWS: Mention new MI commands.
1687         * break-catch-throw.c (enum exception_event_kind): Move to
1688         breakpoint.h.
1689         (print_mention_exception_catchpoint): Output text as a single
1690         message.
1691         (catch_exception_command_1): Rename to...
1692         (catch_exception_event): ...this, make non-static, update header
1693         command, and change some parameter types.
1694         (catch_catch_command): Update for changes to
1695         catch_exception_command_1.
1696         (catch_throw_command): Likewise.
1697         (catch_rethrow_command): Likewise.
1698         * breakpoint.c (enum exception_event_kind): Delete.
1699         * breakpoint.h (enum exception_event_kind): Moved here from
1700         break-catch-throw.c.
1701         (catch_exception_event): Declare.
1702         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1703         (mi_cmd_catch_throw): New function.
1704         (mi_cmd_catch_rethrow): New function.
1705         (mi_cmd_catch_catch): New function.
1706         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1707         'catch-catch' entries.
1708         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1709         (mi_cmd_catch_rethrow): Declare.
1710         (mi_cmd_catch_catch): Declare.
1711
1712 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1713
1714         * annotate.c (annotate_source_line): Change return type to void,
1715         update implementation to match.
1716         * annotate.h (annotate_source_line): Change return type to void,
1717         update header comment.
1718         * stack.c (print_frame_info): Don't change what frame information
1719         is printed based on whether annotations are on or not.
1720
1721 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1722
1723         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1724         (annotate_source): Make static.
1725         (annotate_source_line): Moved from source.c and renamed from
1726         identify_source_line.  Update the return type.
1727         * annotate.h (annotate_source): Delete declaration.
1728         (annotate_source_line): Declaration moved from source.h, and
1729         renamed from identify_source_line.  Return type updated.
1730         * source.c (identify_source_line): Moved to annotate.c and renamed
1731         to annotate_source_line.
1732         (info_line_command): Remove check of annotation_level.
1733         * source.h (identify_source_line): Move declaration to annotate.h
1734         and rename to annotate_source_line.
1735         * stack.c: Add 'annotate.h' include.
1736         (print_frame_info): Remove check of annotation_level before
1737         calling annotate_source_line.
1738
1739 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1740
1741         * source-cache.c (source_cache::get_plain_source_lines): Use
1742         open_source_file_with_line_charpos instead of just
1743         open_source_file, remove call to find_source_lines.
1744         (source_cache::get_source_lines): Likewise.
1745         * source.c (find_source_lines): Make static.
1746         (get_filename_and_charpos): Renamed into...
1747         (open_source_file_with_line_charpos): ..this along with changes to
1748         return a scoped_fd, and some other minor clean ups.
1749         (identify_source_line): Use open_source_file_with_line_charpos.
1750         (search_command_helper): Use open_source_file_with_line_charpos
1751         instead of just open_source_file, remove call to
1752         find_source_lines.
1753         * source.h (open_source_file_with_line_charpos): Declare new
1754         function.
1755         (find_source_lines): Delete declaration.
1756
1757 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1758
1759         * source.c (get_filename_and_charpos): Remove fullname
1760         parameter.
1761         (identify_source_line): Update call to get_filename_and_charpos.
1762
1763 2019-06-14  Tom Tromey  <tromey@adacore.com>
1764
1765         PR gdb/24502:
1766         * ui-style.h (skip_ansi_escape): Update comment.
1767         * ui-file.h (class no_terminal_escape_file): New class.
1768         * ui-file.c (no_terminal_escape_file::write)
1769         (no_terminal_escape_file::puts): New methods.
1770         * cli/cli-logging.c (handle_redirections): Use
1771         no_terminal_escape_file.
1772
1773 2019-06-14  Tom Tromey  <tromey@adacore.com>
1774
1775         * NEWS: Move convenience variable news above Python news.
1776
1777 2019-06-14  Tom Tromey  <tom@tromey.com>
1778
1779         * gnulib: Move directory to top-level.
1780         * configure.ac: Don't configure gnulib.
1781         * configure: Rebuild.
1782         * common/common-defs.h: Use new path to gnulib.
1783         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1784         (GNULIB_H): Remove.
1785         (INCGNU): Look in new gnulib location.
1786         (HFILES_NO_SRCDIR): Remove gnulib files.
1787         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1788         (generated_files): Remove GNULIB_H.
1789         ($(LIBGNU), all-lib): Remove targets.
1790         (distclean): Don't mention GNULIB_BUILDDIR.
1791         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1792
1793 2019-06-14  Tom Tromey  <tromey@adacore.com>
1794
1795         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1796         Warn if symbol file does not provide any symbols.
1797
1798 2019-06-14  Tom Tromey  <tromey@adacore.com>
1799
1800         * source.c (find_and_open_source): Respect basenames_may_differ.
1801
1802 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1803
1804         * annotate.c (annotate_breakpoints_invalid): Make use of
1805         scoped_restore_terminal_state.
1806         (annotate_frames_invalid): Likewise.
1807
1808 2019-06-14  Tom Tromey  <tromey@adacore.com>
1809
1810         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1811         allow assignment to an internalvar.
1812
1813 2019-06-14  Tom Tromey  <tromey@adacore.com>
1814
1815         * ada-lex.l: Allow "_" in attribute names.
1816
1817 2019-06-14  Tom Tromey  <tromey@adacore.com>
1818
1819         PR gdb/24653:
1820         * regcache.c (registers_changed): Don't call alloca.
1821         * top.c (execute_command): Don't call alloca.
1822
1823 2019-06-13  Pedro Alves  <palves@redhat.com>
1824
1825         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1826         'expression'.  When parsing an expression, error out if there's
1827         junk after "unlimited".
1828         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1829         (do_set_command): Adjust calls to is_unlimited_literal.
1830
1831 2019-06-13  Pedro Alves  <palves@redhat.com>
1832
1833         * compile/compile.c (make_compile_options_def_group): Add braces
1834         around array_view initializer.
1835         * thread.c (make_thread_apply_all_options_def_group)
1836         (make_thread_apply_all_options_def_group): Likewise.
1837
1838 2019-06-13  Pedro Alves  <palves@redhat.com>
1839
1840         * NEWS (New commands): Mention "maint test-options
1841         require-delimiter", "maint test-options unknown-is-error", "maint
1842         test-options unknown-is-operand" and "maint show
1843         test-options-completion-result".
1844         (New command options, command completion): New section.
1845         (Completion improvements): New section.
1846         Mention that you can abbreviate "unlimited".
1847
1848 2019-06-13  Pedro Alves  <palves@redhat.com>
1849
1850         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1851         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1852         * unittests/cli-utils-selftests.c (test_parse_flags)
1853         (test_parse_flags_qcs): Delete.
1854         (test_cli_utils): Don't call deleted functions.
1855
1856 2019-06-13  Pedro Alves  <palves@redhat.com>
1857
1858         * thread.c: Include "cli/cli-option.h".
1859         (tp_array_compar_ascending): Global.
1860         (tp_array_compar): Delete function.
1861         (tp_array_compar_ascending, tp_array_compar_descending): New
1862         functions.
1863         (ascending_option_def, qcs_flag_option_def)
1864         (thr_qcs_flags_option_defs)
1865         (make_thread_apply_all_options_def_group)
1866         (make_thread_apply_options_def_group): New.
1867         (thread_apply_all_command): Use gdb::option::process_options.
1868         (thread_apply_command_completer)
1869         (thread_apply_all_command_completer): New.
1870         (thread_apply_command): Use gdb::option::process_options.
1871         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1872         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1873         to generate help text of "thread apply".  Adjust "taas"'s help.
1874         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1875         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1876
1877 2019-06-13  Pedro Alves  <palves@redhat.com>
1878
1879         * thread.c (thread_apply_command): Check for invalid TID with
1880         isdigit instead of !isalpha.
1881
1882 2019-06-13  Pedro Alves  <palves@redhat.com>
1883
1884         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1885         (validate_flags_qcs): New.
1886         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1887         (validate_flags_qcs): Declare.
1888         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1889         (make_frame_apply_options_def_group): New.
1890         (frame_apply_command_count): Process options with
1891         gdb::option::process_options.
1892         (frame_apply_completer): New.
1893         (frame_apply_level_completer, frame_apply_all_completer)
1894         (frame_apply_completer): New.
1895         (_initialize_stack): Update help of "frame apply", "frame apply
1896         level", "frame apply all" and "faas" to mention supported options
1897         and install command completers.
1898         * stack.h (frame_apply_all_completer): Declare.
1899         * thread.c: Include "stack.h".
1900         (tfaas_command): Add "--".
1901         (_initialize_thread): Update help "tfaas" to mention supported
1902         options and install command completer.
1903
1904 2019-06-13  Pedro Alves  <palves@redhat.com>
1905
1906         * completer.c (complete_nested_command_line): New.
1907         (gdb_completion_word_break_characters_throw): Add assertion.
1908         * completer.h (complete_nested_command_line): Declare.
1909
1910 2019-06-13  Pedro Alves  <palves@redhat.com>
1911
1912         * stack.c (parse_backtrace_qualifiers): New.
1913         (backtrace_command): Use it.
1914         (backtrace_command_completer): Complete on qualifiers.
1915
1916 2019-06-13  Pedro Alves  <palves@redhat.com>
1917
1918         * frame.c: Include "cli/cli-option.h.
1919         (user_set_backtrace_options): New.
1920         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1921         Delete.
1922         (get_prev_frame): Adjust.
1923         (boolean_option_def, uinteger_option_def)
1924         (set_backtrace_option_defs): New.
1925         (_initialize_frame): Adjust and use
1926         gdb::option::add_setshow_cmds_for_options to install "set
1927         backtrace past-main" and "set backtrace past-entry".
1928         * frame.h: Include "cli/cli-option.h".
1929         (struct frame_print_options): Forward declare.
1930         (print_frame_arguments_all, print_frame_arguments_scalars)
1931         (print_frame_arguments_none): Declare.
1932         (print_entry_values): Delete declaration.
1933         (struct frame_print_options, user_frame_print_options): New.
1934         (struct set_backtrace_options): New.
1935         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1936         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1937         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1938         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1939         (list_args_or_locals): Add frame_print_options parameter.
1940         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1941         * python/py-framefilter.c (enumerate_args): Pass down
1942         USER_FRAME_PRINT_OPTIONS.
1943         * stack.c: Include "cli/cli-option.h".
1944         (print_frame_arguments_all, print_frame_arguments_scalars)
1945         (print_frame_arguments_none): Declare.
1946         (print_raw_frame_arguments, print_entry_values): Delete.
1947         (user_frame_print_options): New.
1948         (boolean_option_def, enum_option_def, frame_print_option_defs):
1949         New.
1950         (struct backtrace_cmd_options): New.
1951         (bt_flag_option_def): New.
1952         (backtrace_command_option_defs): New.
1953         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1954         (print_frame_arg, read_frame_arg, print_frame_args)
1955         (print_frame_info, print_frame): Add frame_print_options parameter
1956         and use it.
1957         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1958         (backtrace_command_1): Add frame_print_options and
1959         backtrace_cmd_options parameters and use them.
1960         (make_backtrace_options_def_group): New.
1961         (backtrace_command): Process command options with
1962         gdb::option::process_options.
1963         (backtrace_command_completer): New.
1964         (_initialize_stack): Extend "backtrace"'s help to mention
1965         supported options.  Install completer for "backtrace".
1966         Install some settings commands with add_setshow_cmds_for_options.
1967
1968 2019-06-13  Pedro Alves  <palves@redhat.com>
1969
1970         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1971         and that "set/show print raw frame-arguments" are now deprecated.
1972
1973         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1974         command.
1975         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1976         * stack.c (_initialize_stack): Install "set/show print
1977         raw-frame-arguments", and deprecate "set/show print raw
1978         frame-arguments".
1979         * valprint.c (_initialize_valprint): Deprecate "set/show print
1980         raw".
1981
1982 2019-06-13  Pedro Alves  <palves@redhat.com>
1983
1984         * compile/compile.c (struct compile_options): New.
1985         (compile_flag_option_def, compile_command_option_defs)
1986         (make_compile_options_def_group): New.
1987         (compile_file_command): Handle options with
1988         gdb::option::process_options.
1989         (compile_file_command_completer): New function.
1990         (compile_code_command): Handle options with
1991         gdb::option::process_options.
1992         (compile_code_command_completer): New function.
1993         (_initialize_compiler): Install completers for "compile code" and
1994         "compile file".  Mention available options in "compile code" and
1995         "compile code"'s help.
1996         * completer.c (advance_to_completion_word): New, factored out from
1997         ...
1998         (advance_to_expression_complete_word_point): ... this.
1999         (advance_to_filename_complete_word_point): New.
2000         * completer.h (advance_to_filename_complete_word_point): New
2001         declaration.
2002
2003 2019-06-13  Pedro Alves  <palves@redhat.com>
2004
2005         * compile/compile.c: Include "cli/cli-option.h".
2006         (compile_print_value): Scope data pointer is now a
2007         value_print_options pointer; adjust.
2008         (compile_print_command): Process options.  Scope data pointer is
2009         now a value_print_options pointer; adjust.
2010         (_initialize_compile): Update "compile print"'s help to include
2011         supported options.  Install a completer for "compile print".
2012         * cp-valprint.c (show_vtblprint, show_objectprint)
2013         (show_static_field_print): Delete.
2014         (_initialize_cp_valprint): Don't install "set print
2015         static-members", "set print vtbl", "set print object" here.
2016         * printcmd.c: Include "cli/cli-option.h" and
2017         "common/gdb_optional.h".
2018         (print_command_parse_format): Rework to fill in a
2019         value_print_options instead of a format_data.
2020         (print_value): Change parameter type from format_data pointer to
2021         value_print_options reference.  Adjust.
2022         (print_command_1): Process options.  Adjust to pass down a
2023         value_print_options.
2024         (print_command_completer): New.
2025         (_initialize_printcmd): Install print_command_completer as
2026         handle_brkchars completer for the "print" command.  Update
2027         "print"'s help to include supported options.
2028         * valprint.c: Include "cli/cli-option.h".
2029         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2030         here from cp-valprint.c.
2031         (boolean_option_def, uinteger_option_def)
2032         (value_print_option_defs, make_value_print_options_def_group):
2033         New.  Use gdb::option::add_setshow_cmds_for_options to install
2034         "set print elements", "set print null-stop", "set print repeats",
2035         "set print pretty", "set print union", "set print array", "set
2036         print address", "set print symbol", "set print array-indexes".
2037         * valprint.h: Include <string> and "cli/cli-option.h".
2038         (make_value_print_options_def_group): Declare.
2039         (print_value): Change parameter type from format_data pointer to
2040         value_print_options reference.
2041         (print_command_completer): Declare.
2042
2043 2019-06-13  Pedro Alves  <palves@redhat.com>
2044
2045         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2046         (COMMON_SFILES): Add maint-test-settings.c.
2047         * cli/cli-decode.c (boolean_enums): New global, factored out from
2048         ...
2049         (add_setshow_boolean_cmd): ... here.
2050         * cli/cli-decode.h (boolean_enums): Declare.
2051         * cli/cli-option.c: New file.
2052         * cli/cli-option.h: New file.
2053         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2054         factored out from ...
2055         (parse_cli_boolean_value(const char *)): ... this.
2056         (is_unlimited_literal): Change parameter type to pointer to
2057         pointer.  Adjust and advance ARG pointer.
2058         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2059         (parse_cli_var_enum): New, factored out from ...
2060         (do_set_command): ... this.  Adjust.
2061         * cli/cli-setshow.h (parse_cli_boolean_value)
2062         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2063         (parse_cli_var_enum): Declare.
2064         * cli/cli-utils.c: Include "cli/cli-option.h".
2065         (get_ulongest): New.
2066         * cli/cli-utils.h (get_ulongest): Declare.
2067         (check_for_argument): New overloads.
2068         * maint-test-options.c: New file.
2069
2070 2019-06-13  Pedro Alves  <palves@redhat.com>
2071
2072         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2073         parse a range if "-" is at the end of the string.
2074
2075 2019-06-13  Pedro Alves  <palves@redhat.com>
2076
2077         * cli/cli-setshow.c (parse_auto_binary_operation)
2078         (parse_cli_boolean_value): Don't allow "o".
2079
2080 2019-06-13  Pedro Alves  <palves@redhat.com>
2081
2082         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2083         * NEWS: Mention maint test-settings KIND.
2084         * maint-test-settings.c: New file.
2085
2086 2019-06-13  Pedro Alves  <palves@redhat.com>
2087
2088         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2089         completer.
2090         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2091         "set" completers.
2092
2093 2019-06-13  Pedro Alves  <palves@redhat.com>
2094
2095         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2096         after item.
2097
2098 2019-06-13  Pedro Alves  <palves@redhat.com>
2099
2100         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2101
2102 2019-06-13  Pedro Alves <palves@redhat.com>
2103
2104         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2105         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2106         call.
2107         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2108         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2109         calls.
2110         (check_for_argument): Skip spaces after argument.
2111
2112 2019-06-13  Pedro Alves  <palves@redhat.com>
2113
2114         * thread.c (thread_apply_command): Adjust TID parsing.
2115         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2116         detected before end of string.
2117         (tid_is_in_list): Error out if LIST is invalid.
2118
2119 2019-06-13  Pedro Alves  <palves@redhat.com>
2120
2121         * completer.c (complete_line_internal_1): Rewind completion word
2122         point.
2123         (completion_tracker::advance_custom_word_point_by): Change
2124         parameter type to int.
2125         * completer.h (completion_tracker::advance_custom_word_point_by):
2126         Likewise.
2127
2128 2019-06-13  Pedro Alves  <palves@redhat.com>
2129
2130         * completer.c (advance_to_completion_word): Handle delimiters.
2131
2132 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2133
2134         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2135
2136 2019-06-11  Tom Tromey  <tom@tromey.com>
2137
2138         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2139         (xmalloc_failed): Move to alloc.c.
2140         * alloc.c: New file.
2141         * Makefile.in (COMMON_SFILES): Add alloc.c.
2142
2143 2019-06-11  Tom Tromey  <tom@tromey.com>
2144
2145         * nat/linux-waitpid.c: Don't include server.h.
2146         (linux_debug): Remove.
2147         (my_waitpid): Update.
2148
2149 2019-06-11  Tom Tromey  <tromey@adacore.com>
2150
2151         * infcall.c (_initialize_infcall): Remove trailing newline from
2152         help.
2153         * user-regs.c (_initialize_user_regs): Remove trailing newline
2154         from help.
2155         * typeprint.c (_initialize_typeprint): Remove trailing newline
2156         from help.
2157         * reverse.c (_initialize_reverse): Remove trailing newlines from
2158         help.
2159         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2160         from help.
2161         * language.c (add_set_language_command): Remove trailing newline
2162         from help.
2163         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2164         help.
2165         * disasm.c (_initialize_disasm): Remove trailing newline from
2166         help.
2167         * top.c (init_main): Remove trailing newline from help.
2168         * interps.c (_initialize_interpreter): Remove trailing newline
2169         from help.
2170         * btrace.c (_initialize_btrace): Remove trailing newlines from
2171         help.
2172         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2173         from help.
2174         * python/python.c (_initialize_python): Remove trailing newline
2175         from help.
2176         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2177         help.
2178         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2179         from help.  Reformat some text.
2180         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2181         from help.
2182         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2183         newline from help.
2184
2185 2019-06-11  Tom Tromey  <tromey@adacore.com>
2186
2187         * darwin-nat.c (darwin_decode_exception_message)
2188         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2189
2190 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2191
2192         * valops.c (value_slice): Check for not allocated or not
2193         associated values.
2194
2195 2019-06-10  Tom de Vries  <tdevries@suse.de>
2196
2197         PR gdb/24618
2198         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2199         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2200         invalid.
2201
2202 2019-06-10  Tom de Vries  <tdevries@suse.de>
2203
2204         PR gdb/24611
2205         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2206         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2207
2208 2019-06-10  Tom de Vries  <tdevries@suse.de>
2209
2210         PR symtab/24545
2211         * symtab.c (struct demangled_name_entry): Add language field.
2212         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2213         static minimal symbol".  Set and use language field.
2214
2215 2019-06-10  Tom Tromey  <tromey@adacore.com>
2216
2217         * ada-lang.c (_initialize_ada_language): Update help text.
2218
2219 2019-06-10  Tom Tromey  <tromey@adacore.com>
2220
2221         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2222         with a newline.
2223         * guile/guile.c (handle_boot_error): Don't end warning with a
2224         newline.
2225         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2226         warning with a newline.
2227         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2228         newline.
2229         (s12z_frame_cache): Likewise.
2230         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2231         a newline.
2232         * solib-svr4.c (disable_probes_interface): Don't end warning with
2233         a newline.
2234         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2235         newline.
2236         * python/python.c (do_finish_initialization): Don't end warning
2237         with a newline.
2238
2239 2019-06-10  Tom Tromey  <tom@tromey.com>
2240
2241         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2242         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2243         gdbpy_enter.
2244
2245 2019-06-10  Tom Tromey  <tromey@adacore.com>
2246
2247         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2248         data.
2249         (elf_new_init): Don't call stabsread_new_init.
2250         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2251         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2252         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2253
2254 2019-06-10  Tom de Vries  <tdevries@suse.de>
2255
2256         PR symtab/16264
2257         PR symtab/24517
2258         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2259
2260 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2261
2262         * source.c (find_and_open_source): Also rewrite relative file
2263         names.
2264
2265 2019-04-26  Amos Bird  <amosbird@gmail.com>
2266
2267         * annotate.c (annotate_thread_exited): Add "thread-exited"
2268         annotation.
2269
2270 2019-06-06  Tom Tromey  <tromey@adacore.com>
2271
2272         * maint.h (class scoped_command_stats): Use
2273         DISABLE_COPY_AND_ASSIGN.
2274         <print_time>: New method.
2275         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2276         print_time.
2277         (scoped_command_stats::print_time): New method.
2278
2279 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2282         instructions of lengths 6 or 8 bytes.
2283
2284 2019-06-04  Pedro Alves  <palves@redhat.com>
2285
2286         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2287
2288         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2289         * breakpoint.c (condition_completer): Likewise.
2290         * cli/cli-dump.c (scan_expression): Likewise.
2291         * common/filestuff.c (mkdir_recursive): Likewise.
2292         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2293         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2294         (gdb_abspath): Likewise.
2295         * compile/compile-cplus-types.c
2296         (compile_cplus_instance::decl_name): Likewise.
2297         * completer.c (complete_explicit_location):
2298         (signal_completer, reg_or_group_completer_1): Likewise.
2299         * cp-support.c (cp_remove_params_if_any): Likewise.
2300         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2301         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2302         * infcmd.c (strip_bg_char): Likewise.
2303         * linespec.c (copy_token_string): Likewise.
2304         * mi/mi-main.c (output_cores): Likewise.
2305         * psymtab.c (psymtab_search_name):
2306         * symfile.c (test_set_ext_lang_command): Likewise.
2307         * target.c (target_fileio_read_stralloc): Likewise.
2308         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2309         * value.c (complete_internalvar): Likewise.
2310
2311 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2312
2313         Add objfile property to gdb.Type.
2314         * NEWS: Mention Python API addition.
2315         * python/py-type.c (typy_get_objfile): New method.
2316
2317 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2318
2319         * NEWS: Mention the new set|show style [title|highlight].
2320         Mention changes to "show style", "help" and "apropos".
2321
2322 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2323
2324         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2325         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2326         instead of print_help_for_command.
2327         (print_doc_of_command): New function.
2328         (help_list): Add 'apropos -v word' suggestion.
2329         (print_help_for_command): Style the command name using title style.
2330         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2331         (_initialize_cli_cmds): Describe -v in apropos_command help.
2332
2333 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2334
2335         * cli/cli-style.h (cli_style_option): Add name in constructor,
2336         add m_name class member, add constructor with intensity,
2337         add name class function.
2338         (cli_style_option::add_setshow_commands): Remove name argument.
2339         (highlight_style, title_style): New styles.
2340         * cli/cli-style.c (do_show): New function that shows a style
2341         characteristic styling the style name with itself.
2342         (set_style_name): New function.
2343         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2344         Update all callers according to the changes in cli/cli-style.h.
2345         * utils.h (fputs_highlighted): New function.
2346         * utils.c (fputs_highlighted): Likewise.
2347
2348 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2349
2350         * NEWS: Mention new pipe command and new convenience variables.
2351
2352 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2353
2354         * cli/cli-cmds.c (pipe_command): New function.
2355         (_initialize_cli_cmds): Call add_com for pipe_command.
2356         Define | as an alias for pipe.
2357         (exit_status_set_internal_vars): New function.
2358         (shell_escape): Call exit_status_set_internal_vars.
2359         cli/cli-decode.c (find_command_name_length): Recognize | as
2360         a single character command.
2361
2362 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2363
2364         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2365         top.c (execute_command_to_ui_file): New function, mostly a copy
2366         of execute_command_to_string.
2367         (execute_command_to_string): Implement by calling
2368         execute_command_to_ui_file.
2369
2370 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2371
2372         * top.h (saved_command_line): Remove declaration.
2373         * top.c (previous_saved_command_line, previous_repeat_arguments):
2374         New variables.
2375         (saved_command_line): Make static, define together with other
2376         'repeat variables'.
2377         (dont_repeat): Clear repeat_arguments.
2378         (repeat_previous, get_saved_command_line, save_command_line):
2379         New functions.
2380         (gdb_init): Initialize saved_command_line
2381         and previous_saved_command_line.
2382         * main.c (captured_main_1): Remove saved_command_line initialization.
2383         * event-top.c (handle_line_of_input): Update to use
2384         the new 'repeat' related functions instead of direct access to
2385         saved_command_line.
2386         * command.h (repeat_previous, get_saved_command_line,
2387         save_command_line): New declarations.
2388         (dont_repeat): Add comment.
2389
2390 2019-05-30  Tom Tromey  <tromey@adacore.com>
2391
2392         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2393         Fix comment.
2394         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2395
2396 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2397
2398         PR cli/24587
2399         * completer.c (complete): Initialize variable word.
2400
2401 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2402
2403         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2404         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2405         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2406         'body' is NULL to the outter 'if', protecting the '!is_define'
2407         situation as well.
2408
2409 2019-05-29  Tom Tromey  <tromey@adacore.com>
2410
2411         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2412         (dwarf_unknown): New function.
2413         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2414         (dwarf_type_encoding_name): Use dwarf_unknown.
2415
2416 2019-05-29  Tom Tromey  <tromey@adacore.com>
2417
2418         PR c++/20020:
2419         * cp-valprint.c (cp_print_value_fields): Call
2420         cp_print_static_field inside "try".
2421
2422 2019-05-29  Tom Tromey  <tromey@adacore.com>
2423
2424         * inflow.c (struct terminal_info): Add default operator=.
2425         * configure: Rebuild.
2426         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2427         -Wdeprecated-copy-dtor, -Wredundant-move.
2428
2429 2019-05-29  Tom Tromey  <tromey@adacore.com>
2430
2431         * NEWS: Add entry.
2432         * infcmd.c (print_return_value_1): Handle finish_print
2433         option.
2434         (show_print_finish): New function.
2435         (_initialize_infcmd): Add "set/show print finish" commands.
2436         * valprint.c (user_print_options): Initialize new member.
2437         * valprint.h (struct value_print_options) <finish_print>: New
2438         member.
2439
2440 2019-05-28  Tom Tromey  <tromey@adacore.com>
2441
2442         * ada-lang.c (ada_remove_Xbn_suffix)
2443         (find_old_style_renaming_symbol)
2444         (parse_old_style_renaming): Remove.
2445         (ada_find_renaming_symbol): Don't call
2446         find_old_style_renaming_symbol.
2447         (ada_is_renaming_symbol): Rename from
2448         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2449         bool.  Now static.
2450         (ada_read_var_value): Update and simplify.
2451         * ada-exp.y (write_var_or_type): Remove old code.
2452
2453 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2454
2455         * event-top.c: Remove include comment.
2456         * inflow.c (class scoped_ignore_sigttou): Move from here...
2457         * inflow.h (class scoped_ignore_sigttou): ...to here.
2458         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2459         * top.c:  Remove include comment.
2460
2461 2019-05-27  Tom Tromey  <tom@tromey.com>
2462
2463         * NEWS: Fix typo.
2464
2465 2019-05-22  Tom Tromey  <tromey@adacore.com>
2466
2467         * target.c (target_follow_exec): Constify parameter.
2468         * target-delegates.c: Rebuild.
2469         * remote.c (remote_target::follow_exec): Constify parameter.
2470         * infrun.c (follow_exec): Constify parameter.
2471         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2472         (target_follow_exec): Likewise.
2473
2474 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2475
2476         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2477         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2478
2479 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2480
2481         * NEWS: Add debugredirect and testsuite sections.
2482
2483 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2484
2485         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2486         target descriptions using exclusively floating point register name
2487         aliases.
2488
2489 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2490
2491         PR gdb/18644:
2492         * f-lang.c (build_fortran_types): Handle the case where
2493         gdbarch_floatformat_for_type returns a nullptr.
2494
2495 2019-05-21  Tom de Vries  <tdevries@suse.de>
2496
2497         PR cli/24587
2498         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2499
2500 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2501
2502         PR gdb/18644:
2503         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2504         16-byte floats.
2505         * i386-tdep.c (i386_floatformat_for_type): Use
2506         floatformats_ia64_quad for the 16-byte floating point component
2507         within a fortran 32-byte complex number.
2508
2509 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2510
2511         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2512         delete default constructor.
2513         (find_partial_die): Update to return const struct.
2514         (partial_die_parent_scope): Move variable declaration into scope
2515         of its use and change its type to auto.
2516         (guess_partial_die_structure_name): Likewise.
2517         (partial_die_info::fixup): Likewise.
2518
2519 2019-05-17  Tom Tromey  <tromey@adacore.com>
2520
2521         * source.c (find_and_open_source): Remove cast.
2522
2523 2019-05-17  Tom Tromey  <tromey@adacore.com>
2524
2525         * annotate.c (annotate_source): Make "filename" const.
2526         * annotate.h (annotate_source): Use const.
2527
2528 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2529
2530         * disasm.c (set_disassembler_options): Send errors to stderr.
2531
2532 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2533
2534         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2535         (cli_interp_base::set_logging): Check debug_redirect.
2536         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2537         * cli/cli-logging.c (debug_redirect): Add static variable.
2538         (pop_output_files): Add default param.
2539         (handle_redirections): Print debug setting.
2540         (show_logging_command): Likewise.
2541         (_initialize_cli_logging): Add debugredirect command.
2542         * interps.c (current_interp_set_logging): Add debug_redirect
2543         parameter.
2544         * interps.h (set_logging): Add debug_redirect parameter.
2545         (current_interp_set_logging): Likewise.
2546         * mi/mi-common.h: Likewise.
2547         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2548
2549 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2550             Tom Tromey  <tromey@adacore.com>
2551
2552         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2553         directly.
2554         * cli/cli-interp.h (make_logging_output): Remove declaration.
2555         * cli/cli-logging.c (make_logging_output): Remove function.
2556         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2557         directly.
2558         * ui-file.c (tee_file::tee_file): Remove bools.
2559         (tee_file::~tee_file): Remove deletes.
2560         * ui-file.h (tee_file): Remove bools.
2561
2562 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2563
2564         * mi/mi-cmds.h (mi_cmd_complete): New function.
2565         * mi/mi-main.c (mi_cmd_complete): Likewise.
2566         * mi/mi-cmds.c: Define new MI command -complete.
2567         * NEWS: Mention new -complete command.
2568
2569 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2570
2571         * completer.h (complete): New function.
2572         * completer.c (complete): Likewise.
2573         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2574         function defined in completer.h.
2575
2576 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2577
2578         * MAINTAINERS (Write After Approval): Add myself.
2579
2580 2019-05-17  Tom de Vries  <tdevries@suse.de>
2581
2582         PR gdb/24094
2583         * dwarf2read.c (struct cu_partial_die_info): New struct.
2584         (find_partial_die): Return cu_partial_die_info.
2585         (partial_die_parent_scope, guess_partial_die_structure_name)
2586         (partial_die_info::fixup): Handle new return type of find_partial_die.
2587
2588 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2589
2590         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2591         "std::string", simplifying the algorithm.
2592
2593 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2594
2595         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2596         (stap_static_probe_ops::get_probes): Likewise.
2597
2598 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2599
2600         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2601         '-')" and "else if".
2602         (stap_parse_single_operand): Join checks for
2603         "gdbarch_stap_parse_special_token_p" and
2604         "gdbarch_stap_parse_special_token" in the same "if" statement.
2605         Invert check when verifying for operation on register
2606         displacement.
2607
2608 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2609
2610         * stap-probe.c (stap_get_opcode): Update comment.
2611         (stap_get_expected_argument_type): Likewise.
2612         (handle_stap_probe): Likewise.
2613
2614 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2615
2616         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2617         return type to 'bool'.  Adjust comment.  Use 'bool' when
2618         appropriate.
2619         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2620         * stap-probe.c (stap_parse_argument_1): Likewise.
2621         (stap_is_operator): Likewise.
2622         (stap_is_generic_prefix): Likewise.
2623         (stap_is_register_prefix): Likewise.
2624         (stap_is_register_indirection_prefix): Likewise.
2625         (stap_is_integer_prefix): Likewise.
2626         (stap_generic_check_suffix): Likewise.
2627         (stap_check_integer_suffix): Likewise.
2628         (stap_check_register_suffix): Likewise.
2629         (stap_check_register_indirection_suffix): Likewise.
2630         (stap_parse_register_operand): Likewise.
2631         (stap_parse_single_operand): Likewise.
2632         (stap_parse_argument_1): Likewise.
2633         (stap_probe::get_argument_count): Likewise.
2634         (stap_is_operator): Likewise.
2635
2636 2019-05-16  Tom Tromey  <tromey@adacore.com>
2637
2638         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2639         keyword to foreach.
2640
2641 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2642
2643         * linux-thread-db.c (try_thread_db_load_1): Change return type
2644         to bool.
2645         (try_thread_db_load): Likewise.
2646         (try_thread_db_load_from_pdir_1): Likewise.
2647         (try_thread_db_load_from_pdir): Likewise.
2648         (try_thread_db_load_from_sdir): Likewise.
2649         (try_thread_db_load_from_dir): Likewise.
2650         (thread_db_load_search): Likewise.
2651         (has_libpthread): Likewise.
2652         (thread_db_load): Likewise.
2653
2654 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2655
2656         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2657         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2658         NULL, and complain/return if that's the case.
2659
2660 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2661
2662         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2663         (advance, posn, abstract_read_memory): New functions.
2664         [struct mem_read_abstraction]: New struct.
2665         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2666
2667 2019-05-14  Tom Tromey  <tromey@adacore.com>
2668
2669         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2670         value is not lval_memory.
2671
2672 2019-05-14  Tom Tromey  <tromey@adacore.com>
2673
2674         * solib.c (info_sharedlibrary_command): Style the file name.
2675
2676 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2677
2678         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2679         (aarch64_vnv_type): Likewise.
2680         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2681         * common/tdesc.c: Likewise.
2682         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2683         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2684         * features/aarch64-fpu.xml: Add ieee half view.
2685         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2686         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2687         * gdbtypes.h (struct builtin_type): Likewise.
2688         (struct objfile_type): Likewise.
2689
2690 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2691
2692         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2693         typo.
2694         * location.h (string_to_event_location): Likewise.
2695
2696 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2697
2698         GDB 8.3 released.
2699
2700 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2701
2702         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2703         New variable declaration.
2704         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2705         New variable.
2706         (print_one_breakpoint): Use ui_out::test_flags and new global
2707         variable to compute use_fixed_output.
2708         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2709         Remove.
2710         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2711         (mi_multi_location_breakpoint_output_fixed): Remove.
2712         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2713         new variable.
2714         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2715         fix_multi_location_breakpoint_output flag if version >= 3.
2716         * ui-out.h (enum ui_out_flag)
2717         <fix_multi_location_breakpoint_output>: New enumerator.
2718
2719 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2720
2721         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2722
2723 2019-05-10  Tom Tromey  <tromey@adacore.com>
2724
2725         * ada-lang.c (catch_ada_completer): New function.
2726         (_initialize_ada_language): Use it.
2727
2728 2019-05-10  Tom Tromey  <tromey@adacore.com>
2729
2730         * thread.c (print_thread_info): Make "requested_threads" const.
2731         * gdbthread.h (print_thread_info): Make "requested_threads"
2732         const.
2733         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2734         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2735
2736 2019-05-08  Tom Tromey  <tom@tromey.com>
2737
2738         * gdbtypes.c (objfile_type_data): Change type.
2739         (objfile_type, _initialize_gdbtypes): Update.
2740
2741 2019-05-08  Tom Tromey  <tom@tromey.com>
2742
2743         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2744         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2745         (_initialize_dwarf2_frame): Update.
2746
2747 2019-05-08  Tom Tromey  <tom@tromey.com>
2748
2749         * objc-lang.c (objc_objfile_data): Change type.
2750         (find_methods): Update.
2751         (_initialize_objc_lang): Remove.
2752
2753 2019-05-08  Tom Tromey  <tom@tromey.com>
2754
2755         * stabsread.c (rs6000_builtin_type_data): Change type.
2756         (rs6000_builtin_type, _initialize_stabsread): Update.
2757
2758 2019-05-08  Tom Tromey  <tom@tromey.com>
2759
2760         * mips-tdep.c (mips_pdr_data): Remove.
2761         (_initialize_mips_tdep): Update.
2762
2763 2019-05-08  Tom Tromey  <tom@tromey.com>
2764
2765         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2766         (hppa_init_objfile_priv_data, read_unwind_info)
2767         (find_unwind_entry, _initialize_hppa_tdep): Update.
2768
2769 2019-05-08  Tom Tromey  <tom@tromey.com>
2770
2771         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2772         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2773         on obstack.
2774         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2775
2776 2019-05-08  Tom Tromey  <tom@tromey.com>
2777
2778         * mdebugread.c (basic_type_data): Change type.
2779         (basic_type, _initialize_mdebugread): Update.
2780
2781 2019-05-08  Tom Tromey  <tom@tromey.com>
2782
2783         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2784
2785 2019-05-08  Tom Tromey  <tom@tromey.com>
2786
2787         * nto-tdep.c (nto_inferior_data_reg): Change type.
2788         (nto_inferior_data): Update.
2789         (nto_inferior_data_cleanup, nto_new_inferior_data)
2790         (_initialize_nto_tdep): Remove.
2791         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2792
2793 2019-05-08  Tom Tromey  <tom@tromey.com>
2794
2795         * ada-lang.c (struct ada_inferior_data): Add initializers.
2796         (ada_inferior_data): Change type.
2797         (ada_inferior_data_cleanup): Remove.
2798         (get_ada_inferior_data, ada_inferior_exit)
2799         (struct ada_pspace_data): Add initializers, destructor.
2800         (ada_pspace_data_handle): Change type.
2801         (get_ada_pspace_data): Update.
2802         (ada_pspace_data_cleanup): Remove.
2803
2804 2019-05-08  Tom Tromey  <tom@tromey.com>
2805
2806         * coffread.c (struct coff_symfile_info): Add initializers.
2807         (coff_objfile_data_key): Move lower.  Change type.
2808         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2809         Update.
2810         (coff_free_info): Remove.
2811
2812 2019-05-08  Tom Tromey  <tom@tromey.com>
2813
2814         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2815         (fbsd_pspace_data_handle): Move lower.  Change type.
2816         (get_fbsd_pspace_data): Update.
2817         (fbsd_pspace_data_cleanup): Remove.
2818         (_initialize_fbsd_tdep): Update.
2819
2820 2019-05-08  Tom Tromey  <tom@tromey.com>
2821
2822         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2823         (get_ada_tasks_pspace_data): Update.
2824         (ada_tasks_pspace_data_cleanup): Remove.
2825         (_initialize_tasks): Update.
2826         (ada_tasks_inferior_data_handle): Change type.
2827         (get_ada_tasks_inferior_data): Update.
2828         (ada_tasks_inferior_data_cleanup): Remove.
2829         (struct ada_tasks_pspace_data): Add initializers.
2830
2831 2019-05-08  Tom Tromey  <tom@tromey.com>
2832
2833         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2834         * symfile-debug.c (debug_sym_get_probes): Change type.
2835         * stap-probe.c (handle_stap_probe):
2836         (stap_static_probe_ops::get_probes): Change type.
2837         * probe.h (class static_probe_ops) <get_probes>: Change type.
2838         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2839         (parse_probes_in_pspace): Update.
2840         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2841         Update.
2842         (any_static_probe_ops::get_probes): Change type.
2843         * elfread.c (elfread_data): New typedef.
2844         (probe_key): Change type.
2845         (elf_get_probes): Likewise.  Update.
2846         (probe_key_free): Remove.
2847         (_initialize_elfread): Update.
2848         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2849         Change type.
2850         (dtrace_process_dof_probe, dtrace_process_dof)
2851         (dtrace_static_probe_ops::get_probe): Change type.
2852
2853 2019-05-08  Tom Tromey  <tom@tromey.com>
2854
2855         * xcoffread.c (struct xcoff_symfile_info): Rename from
2856         coff_symfile_info.  Add initializers.
2857         (xcoff_objfile_data_key): Move lower.  Change type.
2858         (XCOFF_DATA): Rewrite.
2859         (xcoff_free_info): Remove.
2860         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2861         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2862         (xcoff_initial_scan): Update.
2863
2864 2019-05-08  Tom Tromey  <tom@tromey.com>
2865
2866         * solib-svr4.c (struct svr4_info): Add initializers and
2867         destructor.
2868         <probes_table>: Now an htab_up.
2869         (solib_svr4_pspace_data): Change type.
2870         (free_probes_table): Simplify.
2871         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2872         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2873         (probes_table_remove_objfile_probes, register_solib_event_probe)
2874         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2875         (_initialize_svr4_solib): Update.
2876
2877 2019-05-08  Tom Tromey  <tom@tromey.com>
2878
2879         * remote.c (remote_pspace_data): Change type.
2880         (remote_pspace_data_cleanup): Remove.
2881         (get_remote_exec_file, set_pspace_remote_exec_file)
2882         (_initialize_remote): Update.
2883
2884 2019-05-08  Tom Tromey  <tom@tromey.com>
2885
2886         * breakpoint.c (breakpoint_objfile_key): Change type.
2887         (get_breakpoint_objfile_data): Update.
2888         (free_breakpoint_objfile_data): Remove.
2889         (_initialize_breakpoint): Update.
2890
2891 2019-05-08  Tom Tromey  <tom@tromey.com>
2892
2893         * linux-tdep.c (struct linux_info): Add initializers.
2894         (linux_inferior_data): Move.  Change type.
2895         (invalidate_linux_cache_inf): Update.
2896         (linux_inferior_data_cleanup): Remove.
2897         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2898
2899 2019-05-08  Tom Tromey  <tom@tromey.com>
2900
2901         * auxv.c (auxv_inferior_data): Move.  Change type.
2902         (auxv_inferior_data_cleanup): Remove.
2903         (invalidate_auxv_cache_inf): Rewrite.
2904         (get_auxv_inferior_data, _initialize_auxv): Update.
2905
2906 2019-05-08  Tom Tromey  <tom@tromey.com>
2907
2908         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2909         (symfile_debug_objfile_data_key): Change type.
2910         (symfile_debug_installed, debug_qf_has_symbols)
2911         (debug_qf_find_last_source_symtab)
2912         (debug_qf_forget_cached_source_info)
2913         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2914         (debug_qf_print_stats, debug_qf_dump)
2915         (debug_qf_expand_symtabs_for_function)
2916         (debug_qf_expand_all_symtabs)
2917         (debug_qf_expand_symtabs_with_fullname)
2918         (debug_qf_map_matching_symbols)
2919         (debug_qf_expand_symtabs_matching)
2920         (debug_qf_find_pc_sect_compunit_symtab)
2921         (debug_qf_map_symbol_filenames)
2922         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2923         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2924         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2925         (debug_sym_read_linetable, debug_sym_relocate): Update.
2926         (symfile_debug_free_objfile): Remove.
2927         (install_symfile_debug_logging, _initialize_symfile_debug):
2928         Update.
2929
2930 2019-05-08  Tom Tromey  <tom@tromey.com>
2931
2932         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2933         allocate_on_obstack.
2934         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2935         (get_dwarf2_per_objfile): Update.
2936         (set_dwarf2_per_objfile): Remove.
2937         (dwarf2_has_info, dwarf2_get_section_info): Update.
2938         (dwarf2_free_objfile): Remove.
2939         (_initialize_dwarf2_read): Update.
2940
2941 2019-05-08  Tom Tromey  <tom@tromey.com>
2942
2943         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2944         initializers.
2945         <unsupported_script_warning_printed,
2946         script_not_found_warning_printed>: Now bool.
2947         (auto_load_pspace_data): Change type.
2948         (~auto_load_pspace_info): Rename from
2949         auto_load_pspace_data_cleanup.
2950         (get_auto_load_pspace_data, init_loaded_scripts_info)
2951         (clear_section_scripts, maybe_print_unsupported_script_warning)
2952         (maybe_print_script_not_found_warning, _initialize_auto_load):
2953         Update.
2954
2955 2019-05-08  Tom Tromey  <tom@tromey.com>
2956
2957         * objfiles.c (objfile_pspace_info): Add destructor and
2958         initializers.
2959         (objfiles_pspace_data): Change type.
2960         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2961         (get_objfile_pspace_data): Update.
2962         (objfiles_bfd_data): Change type.
2963         (get_objfile_bfd_data): Update.
2964         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2965
2966 2019-05-08  Tom Tromey  <tom@tromey.com>
2967
2968         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2969         Change type.
2970         (get_catch_syscall_inferior_data): Update.
2971         (catch_syscall_inferior_data_cleanup): Remove.
2972         (_initialize_break_catch_syscall): Update.
2973
2974 2019-05-08  Tom Tromey  <tom@tromey.com>
2975
2976         * inflow.c (struct terminal_info): Add destructor and
2977         initializers.
2978         (inflow_inferior_data): Change type.
2979         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2980         (get_inflow_inferior_data, inflow_inferior_exit)
2981         (swap_terminal_info, _initialize_inflow): Update.
2982
2983 2019-05-08  Tom Tromey  <tom@tromey.com>
2984
2985         * target-dcache.c (target_dcache_cleanup): Remove.
2986         (target_dcache_aspace_key): Change type.
2987         (target_dcache_init_p, target_dcache_invalidate)
2988         (target_dcache_get, target_dcache_get_or_init)
2989         (_initialize_target_dcache): Update.
2990         * dcache.h (struct dcache_deleter): New.
2991
2992 2019-05-08  Tom Tromey  <tom@tromey.com>
2993
2994         * symtab.c (struct symbol_cache): Add destructor and
2995         initializers.
2996         (symbol_cache_key): Move.  Change type.
2997         (make_symbol_cache, free_symbol_cache): Remove.
2998         (get_symbol_cache): Update.
2999         (symbol_cache_cleanup): Remove.
3000         (ALL_PSPACES, symbol_cache_flush)
3001         (maintenance_print_symbol_cache)
3002         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3003         Update.
3004
3005 2019-05-08  Tom Tromey  <tom@tromey.com>
3006
3007         * symtab.c (struct main_info): Add destructor and initializers.
3008         (main_progspace_key): Move.  Change type.
3009         (get_main_info): Update.
3010         (main_info_cleanup): Remove.
3011         (_initialize_symtab): Update.
3012
3013 2019-05-08  Tom Tromey  <tom@tromey.com>
3014
3015         * registry.h (DECLARE_REGISTRY): Define the _key class.
3016
3017 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3018
3019         * NEWS: Merge two 'New commands' sections.
3020
3021 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3022
3023         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3024         parameter and use Ada language definition instead.
3025         (ada_val_print_ptr): Remove unused language parameter.
3026         (ada_val_print_num): Remove language parameter and use Ada language
3027         definition instead.
3028         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3029         parameter.
3030         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3031         parameter and use Ada language definition instead.
3032         (ada_val_print_1): Update all ada_val_print_xxx calls.
3033         Remove language parameter.
3034         (ada_val_print): Update ada_val_print_1 call.
3035
3036 2019-05-08  Tom Tromey  <tromey@adacore.com>
3037
3038         * remote.c (remote_hw_watchpoint_limit)
3039         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3040         Now static.
3041
3042 2019-05-08  Tom Tromey  <tromey@adacore.com>
3043
3044         * maint.c (_initialize_maint_cmds): Move initialization code to
3045         remote.c.
3046         (watchdog, show_watchdog): Move to remote.c.
3047         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3048         "watchdog" static.
3049         (_initialize_remote): Move initialization code from maint.c.
3050         * defs.h (watchdog): Don't declare.
3051
3052 2019-05-08  Tom Tromey  <tromey@adacore.com>
3053
3054         * tui/tui-interp.c: Include main.h.
3055         * interps.c: Include main.h.
3056         * main.h (interpreter_p): Declare.
3057         * defs.h (interpreter_p): Don't declare.
3058
3059 2019-05-08  Tom Tromey  <tromey@adacore.com>
3060
3061         * dwarf2loc.c: Include dwarf2read.h.
3062         * defs.h (read_unsigned_leb128): Don't declare.
3063         * dwarf2read.h (read_unsigned_leb128): Declare.
3064
3065 2019-05-08  Tom Tromey  <tromey@adacore.com>
3066
3067         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3068         method.
3069
3070 2019-05-08  Tom Tromey  <tromey@adacore.com>
3071
3072         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3073         when no wrap column is set.
3074
3075 2019-05-08  Tom Tromey  <tromey@adacore.com>
3076
3077         * c-lang.c (c_get_string): Handle non-C-style arrays.
3078
3079 2019-05-08  Tom Tromey  <tromey@adacore.com>
3080
3081         * typeprint.c (print_offset_data::update): Print the bit offset,
3082         not the number of bits remaining.
3083
3084 2019-05-08  Tom Tromey  <tromey@adacore.com>
3085
3086         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3087         padding at end of comment.
3088
3089 2019-05-08  Tom Tromey  <tromey@adacore.com>
3090
3091         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3092         Compare main types.
3093
3094 2019-05-06  Tom Tromey  <tom@tromey.com>
3095
3096         * common/scoped_mmap.c: Include common-defs.h.
3097         * common/scoped_mmap.h: Don't include config.h.
3098
3099 2019-05-04  Tom Tromey  <tom@tromey.com>
3100
3101         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3102         (struct aarch64_call_info): Add initializers.
3103         <si>: Now a std::vector.
3104         (pass_on_stack, aarch64_push_dummy_call): Update.
3105
3106 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3107             Tom Tromey  <tom@tromey.com>
3108
3109         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3110         (ppc_threads): Now a std::vector.  Now static.
3111         (hwdebug_find_thread_points_by_tid)
3112         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3113         Update.
3114
3115 2019-05-04  Tom Tromey  <tom@tromey.com>
3116
3117         * arc-tdep.c (arc_tdesc_init): Return bool.
3118
3119 2019-05-04  Tom Tromey  <tom@tromey.com>
3120
3121         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3122         Use gdb_assert_not_reached.
3123
3124 2019-05-04  Tom Tromey  <tom@tromey.com>
3125
3126         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3127         "false".
3128
3129 2019-05-04  Tom Tromey  <tom@tromey.com>
3130
3131         * arc-tdep.c (arc_tdesc_init): Use bool.
3132
3133 2019-05-04  Tom Tromey  <tom@tromey.com>
3134
3135         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3136
3137 2019-05-04  Tom Tromey  <tom@tromey.com>
3138
3139         * cli/cli-cmds.c (valid_command_p): Return bool.
3140
3141 2019-05-04  Tom Tromey  <tom@tromey.com>
3142
3143         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3144         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3145
3146 2019-05-04  Raul Tambre  <raul@tambre.ee>
3147
3148         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3149         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3150         operator for comparison.
3151
3152 2019-05-04  Tom Tromey  <tom@tromey.com>
3153
3154         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3155         (lookup_partial_symbol, print_partial_symbols)
3156         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3157         (psymbol_compare): Update.
3158         (add_psymbol_to_bcache): Clear the entire psymbol.
3159         (maintenance_check_psymtabs): Update.
3160         * psympriv.h (struct partial_symbol): Don't derive from
3161         general_symbol_info.
3162         <obj_section, unrelocated_address, address,
3163         set_unrelocated_address>: Update.
3164         <ginfo>: New member.
3165         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3166         (debug_names::write_psymbols): Update.
3167
3168 2019-05-04  Tom de Vries  <tdevries@suse.de>
3169
3170         * contrib/cc-with-tweaks.sh: Support -n arg.
3171
3172 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3173
3174         * corelow.c (core_target::detach): Ensure frame cache and
3175         register caches are cleared.
3176         inferior.c (exit_inferior_1): Likewise.
3177
3178 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3179             Tom Tromey  <tom@tromey.com>
3180
3181         * dictionary.c (collate_pending_symbols_by_language): Remove
3182         "struct" from foreach.
3183         * symtab.c (lookup_global_symbol_from_objfile)
3184         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3185         foreach.
3186         * ser-tcp.c (net_open): Remove "struct" from foreach.
3187         * objfiles.c (objfile_relocate, objfile_rebase)
3188         (objfile_has_symbols): Remove "struct" from foreach.
3189         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3190         from foreach.
3191         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3192         foreach.
3193         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3194         "struct" from foreach.
3195         * ada-lang.c (create_excep_cond_exprs)
3196         (ada_exception_catchpoint_cond_string): Remove "struct" from
3197         foreach.
3198
3199 2019-05-03  Tom Tromey  <tromey@adacore.com>
3200
3201         * ada-exp.y (convert_char_literal): Check suffix of each
3202         enumerator.
3203
3204 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3205
3206         PR ada/21406:
3207         * ada-exp.y (yywrap): Don't define.
3208         * ada-lex.l (%option): Add noyywrap
3209         (yywrap): Remove.
3210
3211 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3212
3213         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3214         _WIN32_WINNT to the XP level, unless already defined to a higher
3215         level.
3216
3217         * unittests/parse-connection-spec-selftests.c:
3218         * ser-tcp.c:
3219         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3220         override.
3221
3222         * symfile.c (find_separate_debug_file): Remove colon from the
3223         drive spec of DOS/Windows file names of the target, so that the
3224         file name produced from DEBUGDIR and the target's directory will
3225         be valid on DOS/Windows systems.
3226
3227 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3228
3229         * rust-lang.c (val_print_struct): Handle printing structures
3230         containing strings.
3231
3232 2019-05-02  Tom Tromey  <tromey@adacore.com>
3233
3234         * valarith.c (_initialize_valarith): Remove.
3235
3236 2019-05-01  Tom Tromey  <tromey@adacore.com>
3237
3238         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3239         bitfields.
3240
3241 2019-05-01  Tom Tromey  <tromey@adacore.com>
3242
3243         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3244         for big-endian copies.
3245
3246 2019-04-30  Ali Tamur  <tamur@google.com>
3247         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3248         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3249         (read_3_bytes): New function.
3250
3251 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3252
3253         * windows-nat.c (main_thread_id): Delete.
3254         (handle_output_debug_string): Replace main_thread_id by
3255         current_event.dwThreadId.
3256         (fake_create_process): Likewise.
3257         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3258         Do not set main_thread_id.
3259         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3260         current_event.dwThreadId.
3261         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3262
3263 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3264
3265         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3266         Use current_event.dwThreadId instead of main_thread_id.
3267
3268 2019-04-30  Tom Tromey  <tromey@adacore.com>
3269
3270         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3271         (create_excep_cond_exprs): Iterate over program spaces.
3272         (ada_exception_catchpoint_cond_string): Examine all minimal
3273         symbols for exception types.
3274
3275 2019-04-30  Tom Tromey  <tromey@adacore.com>
3276
3277         PR c++/24470:
3278         * dwarf2read.c (process_structure_scope): Handle case where type
3279         has template parameters but no symbol was created.
3280
3281 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3282             Chris January  <chris.january@arm.com>
3283
3284         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3285         qualifier.
3286         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3287
3288 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3289
3290         * f-typeprint.c (f_print_type): Update rules for printing
3291         whitespace.
3292         (f_type_print_varspec_suffix): Likewise.
3293
3294 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3295             Chris January  <chris.january@arm.com>
3296
3297         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3298         function arguments.
3299
3300 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3301
3302         * f-lang.c (build_fortran_types): Change name of void type to
3303         lower case.
3304         * f-typeprint.c (f_type_print_base): Print the name of the void
3305         type, rather than a fixed string.
3306         * f-valprint.c (f_decorations): Use lower case void string.
3307
3308 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3309             Chris January  <chris.january@arm.com>
3310
3311         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3312         types for Fortran.
3313
3314 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3315             Chris January  <chris.january@arm.com>
3316             David Lecomber  <david.lecomber@arm.com>
3317
3318         * f-exp.y (BINOP_INTRINSIC): New token.
3319         (exp): New parser rule handling BINOP_INTRINSIC.
3320         (f77_keywords): Add new builtin procedures.
3321         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3322         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3323         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3324         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3325         (print_unop_subexp_f): New function.
3326         (print_binop_subexp_f): New function.
3327         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3328         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3329         (dump_subexp_body_f): Likewise.
3330         (operator_check_f): Likewise.
3331         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3332         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3333
3334 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3335
3336         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3337         UNOP_KIND.
3338         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3339         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3340         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3341         (operator_length_f): New fuction.
3342         (print_subexp_f): New function.
3343         (op_name_f): New function.
3344         (dump_subexp_body_f): New function.
3345         (operator_check_f): New function.
3346         (exp_descriptor_f): Replace standard expression handling functions
3347         with new functions.
3348         * gdb/fortran-operator.def: New file.
3349         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3350         * gdb/std-operator.def: Remove UNOP_KIND.
3351
3352 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3353
3354         * std-operator.def: Remove unbalanced, stray double quote
3355         character.
3356
3357 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3358             Chris January  <chris.january@arm.com>
3359             Daniel Everett  <daniel.everett@arm.com>
3360             Nick Forrington  <nick.forrington@arm.com>
3361             Richard Bunt  <richard.bunt@arm.com>
3362
3363         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3364         of depth when printing anonymous structs or unions.
3365         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3366         Don't print either the top-level value, or the children if the
3367         max-depth is exceeded.
3368         (ppscm_print_children): When printing the key of a map, allow one
3369         extra level of depth.
3370         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3371         print either the top-level value, or the children if the max-depth
3372         is exceeded.
3373         (print_children): When printing the key of a map, allow one extra
3374         level of depth.
3375         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3376         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3377         (user_print_options): Initialise max_depth field.
3378         (val_print_scalar_or_string_type_p): New function.
3379         (val_print): Check to see if the max depth has been reached.
3380         (val_print_check_max_depth): Define new function.
3381         (show_print_max_depth): New function.
3382         (_initialize_valprint): Add 'print max-depth' option.
3383         * valprint.h (struct value_print_options) <max_depth>: New field.
3384         (val_print_check_max_depth): Declare new function.
3385         * NEWS: Document new feature.
3386
3387 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3388
3389         * ada-lang.c (ada_language_defn): Initialise new field.
3390         * c-lang.c (c_is_string_type_p): New function.
3391         (c_language_defn): Initialise new field.
3392         (cplus_language_defn): Initialise new field.
3393         (asm_language_defn): Initialise new field.
3394         (minimal_language_defn): Initialise new field.
3395         * c-lang.h (c_is_string_type_p): Declare new function.
3396         * d-lang.c (d_language_defn): Initialise new field.
3397         * f-lang.c (f_is_string_type_p): New function.
3398         (f_language_defn): Initialise new field.
3399         * go-lang.c (go_is_string_type_p): New function.
3400         (go_language_defn): Initialise new field.
3401         * language.c (default_is_string_type_p): New function.
3402         (unknown_language_defn): Initialise new field.
3403         (auto_language_defn): Initialise new field.
3404         * language.h (struct language_defn) <la_is_string_type_p>: New
3405         member variable.
3406         (default_is_string_type_p): Declare new function.
3407         * m2-lang.c (m2_language_defn): Initialise new field.
3408         * objc-lang.c (objc_language_defn): Initialise new field.
3409         * opencl-lang.c (opencl_language_defn): Initialise new field.
3410         * p-lang.c (pascal_is_string_type_p): New function.
3411         (pascal_language_defn): Initialise new field.
3412         * rust-lang.c (rust_is_string_type_p): New function.
3413         (rust_language_defn): Initialise new field.
3414
3415 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3416
3417         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3418         New field.
3419         * ada-lang.c (ada_language_defn): Initialise new field.
3420         * c-lang.c (c_language_defn): Likewise.
3421         (cplus_language_defn): Likewise.
3422         (asm_language_defn): Likewise.
3423         (minimal_language_defn): Likewise.
3424         * d-lang.c (d_language_defn): Likewise.
3425         * f-lang.c (f_language_defn): Likewise.
3426         * go-lang.c (go_language_defn): Likewise.
3427         * language.c (unknown_language_defn): Likewise.
3428         (auto_language_defn): Likewise.
3429         * m2-lang.c (m2_language_defn): Likewise.
3430         * objc-lang.c (objc_language_defn): Likewise.
3431         * opencl-lang.c (opencl_language_defn): Likewise.
3432         * p-lang.c (pascal_language_defn): Likewise.
3433         * rust-lang.c (rust_language_defn): Likewise.
3434
3435 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3436
3437         * ada-lang.c (ada_is_character_type): Change return type to bool.
3438         (ada_is_string_type): Likewise.
3439         * ada-lang.h (ada_is_character_type): Update declaration
3440         (ada_is_string_type): Likewise.
3441
3442 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3443
3444         Support style in 'frame|thread apply'
3445
3446         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3447         * record.c (record_start, record_stop): Update callers of
3448         execute_command_to_string with false.
3449         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3450         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3451         methods.
3452         (class string_file): New constructor with term_out parameter.
3453         Override methods term_out and can_emit_style_escape.  New member
3454         term_out.
3455         (class stdio_file): Override can_emit_style_escape.
3456         (class tee_file): Override term_out and can_emit_style_escape.
3457         * utils.h (can_emit_style_escape): Remove.
3458         * utils.c (can_emit_style_escape): Likewise.
3459         Update all callers of can_emit_style_escape (SOMESTREAM) to
3460         SOMESTREAM->can_emit_style_escape.
3461         * source-cache.c (source_cache::get_source_lines): Likewise.
3462         * stack.c (frame_apply_command_count): Call execute_command_to_string
3463         passing the term_out characteristic of the current gdb_stdout.
3464         * thread.c (thr_try_catch_cmd): Likewise.
3465         * top.c (execute_command_to_string): pass term_out parameter
3466         to construct the string_file for the command output.
3467         * ui-file.c (term_cli_styling): New function (most code moved
3468         from utils.c can_emit_style_escape).
3469         (string_file::string_file, string_file::can_emit_style_escape,
3470         stdio_file::can_emit_style_escape, tee_file::term_out,
3471         tee_file::can_emit_style_escape): New functions.
3472
3473 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3474
3475         * NEWS: Mention the new set|show may-call-functions.
3476         * infcall.c (may_call_functions_p): New variable.
3477         (show_may_call_functions_p): New function.
3478         (call_function_by_hand_dummy): Throws an error if not
3479         may-call-functions.
3480         (_initialize_infcall): Call add_setshow_boolean_cmd for
3481         may-call-functions.
3482
3483 2019-04-25  Keith Seitz  <keiths@redhat.com>
3484
3485         PR c++/24367
3486         * cp-support.c (inspect_type): Don't attempt substitutions
3487         of symbol with the same name.
3488
3489 2019-04-25  Tom Tromey  <tromey@adacore.com>
3490
3491         PR gdb/24475:
3492         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3493         static.
3494
3495 2019-04-25  Tom Tromey  <tromey@adacore.com>
3496
3497         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3498         rvalue reference.
3499         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3500         (gdb_xml_parser::parse): Use std::move.
3501         * python/python-internal.h (gdbpy_convert_exception): Take a const
3502         reference.
3503         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3504         std::move.
3505         * python/py-utils.c (gdbpy_convert_exception): Take a const
3506         reference.
3507         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3508         Use std::move.
3509         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3510         Use std::move.
3511         * mi/mi-main.c (mi_print_exception): Take a const reference.
3512         * main.c (handle_command_errors): Take a const reference.
3513         * linespec.c (parse_linespec): Use std::move.
3514         * infcall.c (run_inferior_call): Use std::move.
3515         (call_function_by_hand_dummy): Use std::move.
3516         * exec.c (try_open_exec_file): Use std::move.
3517         * exceptions.h (exception_print, exception_fprintf)
3518         (exception_print_same): Update.
3519         * exceptions.c (print_exception, exception_print)
3520         (exception_fprintf, exception_print_same): Change parameters to
3521         const reference.
3522         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3523         * common/new-op.c: Use std::move.
3524         * common/common-exceptions.h (struct gdb_exception): Add move
3525         constructor.
3526         (struct gdb_exception_error, struct gdb_exception_quit, struct
3527         gdb_quit_bad_alloc): Change constructor to move constructor.
3528         (throw_exception): Change parameter to rvalue reference.
3529         * common/common-exceptions.c (throw_exception): Take rvalue
3530         reference.
3531         * cli/cli-interp.c (safe_execute_command): Use std::move.
3532         * breakpoint.c (insert_bp_location, location_to_sals): Use
3533         std::move.
3534
3535 2019-04-25  Tom Tromey  <tromey@adacore.com>
3536
3537         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3538         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3539         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3540         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3541         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3542         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3543         guile/scm-value.c: Use unpack.
3544         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3545         gdbscm_gdb_exception.
3546         (gdbscm_throw_gdb_exception): Likewise.
3547         (struct gdbscm_gdb_exception): New.
3548         (unpack): New function.
3549         (gdbscm_wrap): Use unpack.
3550
3551 2019-04-25  Tom Tromey  <tromey@adacore.com>
3552
3553         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3554         (gdb_rl_callback_handler): Use std::move.
3555         * common/common-exceptions.h (struct gdb_exception): Add move
3556         assignment operator.
3557         (throw_exception_sjlj): Change "exception" to const reference.
3558         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3559         (throw_exception_sjlj): Change "exception" to const reference.
3560
3561 2019-04-25  Tom Tromey  <tromey@adacore.com>
3562
3563         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3564         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3565         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3566         Update.
3567         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3568         Update.
3569         * mi/mi-interp.c (mi_interp::exec): Update.
3570         * linespec.c (parse_linespec): Update.
3571         * infcall.c (run_inferior_call): Update.
3572         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3573         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3574         (gdbscm_lookup_global_symbol): Update.
3575         * guile/scm-param.c (gdbscm_parameter_value): Update.
3576         * guile/scm-frame.c (gdbscm_frame_read_register)
3577         (gdbscm_frame_read_var): Update.
3578         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3579         * exec.c (try_open_exec_file): Update.
3580         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3581         (gdb_rl_callback_handler): Update.
3582         * common/common-exceptions.h (exception_none): Don't declare.
3583         * common/common-exceptions.c (exception_none): Don't define.
3584         (struct catcher) <exception>: Update.
3585         * cli/cli-interp.c (safe_execute_command): Update.
3586         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3587
3588 2019-04-25  Ali Tamur  <tamur@google.com>
3589
3590         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3591         (read_attribute_value): Likewise.
3592         (dwarf2_read_addr_index): Update comment.
3593         (read_str_index): Add DW_FORM_strx.
3594         (dwarf2_string_attr): Likewise.
3595         (dwarf2_const_value_attr): Likewise.
3596         (dump_die_shallow): Likewise.
3597         (dwarf2_fetch_constant_bytes): Likewise.
3598         (skip_form_bytes): Likewise.
3599         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3600
3601 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3602
3603         PR corefiles/11608
3604         PR corefiles/18187
3605         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3606         OFFSET.  Verify if current mapping contains an ELF header.
3607         (linux_find_memory_regions_full): Adjust call to
3608         dump_mapping_p.
3609
3610 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3611             Kang Li <kanglictf@gmail.com>
3612
3613         PR gdb/21600
3614
3615         * dwarf2-frame.c (read_initial_length): Be consistent about using
3616         unsigned representation of length.
3617         (decode_frame_entry_1): Likewise.  Check for wraparound of
3618         end pointer as well as buffer overflow.
3619
3620 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3621
3622         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3623         "vq".
3624
3625 2019-04-24  Tom Tromey  <tromey@adacore.com>
3626
3627         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3628
3629 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3630
3631         * s12z-tdep.c (s12z_unwind_pc): Delete.
3632         (s12z_unwind_sp): Delete.
3633         (s12z_gdbarch_init): Don't register deleted functions with
3634         gdbarch.
3635
3636 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3637
3638         * rl78-tdep.c (rl78_unwind_sp): Delete.
3639         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3640
3641 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3642
3643         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3644         (xstormy16_unwind_pc): Delete.
3645         (xstormy16_dummy_id): Delete.
3646         (xstormy16_gdbarch_init): Don't register deleted functions with
3647         gdbarch.
3648
3649 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3650
3651         * vax-tdep.c (vax_unwind_pc): Delete.
3652         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3653
3654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * v850-tdep.c (v850_unwind_sp): Delete.
3657         (v850_unwind_pc): Delete.
3658         (v850_dummy_id): Delete.
3659         (v850_gdbarch_init): Don't register deleted functions with
3660         gdbarch.
3661
3662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3663
3664         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3665         (tilegx_unwind_pc): Delete.
3666         (tilegx_unwind_dummy_id): Delete.
3667         (tilegx_gdbarch_init): Don't register deleted functions with
3668         gdbarch.
3669
3670 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3671
3672         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3673         (tic6x_dummy_id): Delete.
3674         (tic6x_gdbarch_init): Don't register deleted functions with
3675         gdbarch.
3676
3677 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3678
3679         * sparc-tdep.c (sparc_unwind_pc): Delete.
3680         (sparc32_gdbarch_init): Don't register deleted function with
3681         gdbarch.
3682
3683 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3684
3685         * sh-tdep.c (sh_unwind_sp): Delete.
3686         (sh_unwind_pc): Delete.
3687         (sh_dummy_id): Delete.
3688         (sh_gdbarch_init): Don't register deleted functions with
3689         gdbarch.
3690
3691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3692
3693         * score-tdep.c (score_unwind_sp): Delete.
3694         (score_unwind_pc): Delete.
3695         (score_dummy_id): Delete.
3696         (score_gdbarch_init): Don't register deleted functions with
3697         gdbarch.
3698
3699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3700
3701         * rx-tdep.c (rx_unwind_pc): Delete.
3702         (rx_unwind_sp): Delete.
3703         (rx_dummy_id): Delete.
3704         (rx_gdbarch_init): Don't register deleted functions with
3705         gdbarch.  Update comment.
3706
3707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3708
3709         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3710         (rs6000_dummy_id): Delete.
3711         (rs6000_gdbarch_init): Don't register deleted functions with
3712         gdbarch.
3713
3714 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3715
3716         * or1k-tdep.c (or1k_dummy_id): Delete.
3717         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3718
3719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * nios2-tdep.c (nios2_dummy_id): Delete.
3722         (nios2_unwind_sp): Delete.
3723         (nios2_gdbarch_init): Don't register deleted functions with
3724         gdbarch.
3725
3726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3727
3728         * nds32-tdep.c (nds32_dummy_id): Delete.
3729         (nds32_unwind_pc): Delete.
3730         (nds32_unwind_sp): Delete.
3731         (nds32_gdbarch_init): Don't register deleted functions with
3732         gdbarch.
3733
3734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3735
3736         * msp430-tdep.c (msp430_unwind_pc): Delete.
3737         (msp430_unwind_sp): Delete.
3738         (msp430_dummy_id): Delete.
3739         (msp430_gdbarch_init): Don't register deleted functions with
3740         gdbarch.
3741
3742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3743
3744         * moxie-tdep.c (moxie_unwind_sp): Delete.
3745         (moxie_unwind_pc): Delete.
3746         (moxie_dummy_id): Delete.
3747         (moxie_gdbarch_init): Don't register deleted functions with
3748         gdbarch.
3749
3750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3751
3752         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3753         (mn10300_unwind_pc): Delete.
3754         (mn10300_unwind_sp): Delete.
3755         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3756         mn10300_unwind_sp.
3757         (mn10300_frame_unwind_init): Don't register deleted functions with
3758         gdbarch.
3759
3760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3761
3762         * mep-tdep.c (mep_unwind_pc): Delete.
3763         (mep_unwind_sp): Delete.
3764         (mep_dummy_id): Delete.
3765         (mep_gdbarch_init): Don't register deleted functions with
3766         gdbarch.
3767
3768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3769
3770         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3771         (m68hc11_unwind_sp): Delete.
3772         (m68hc11_gdbarch_init): Don't register deleted functions with
3773         gdbarch.
3774
3775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3776
3777         * m32r-tdep.c (m32r_unwind_sp): Delete.
3778         (m32r_unwind_pc): Delete.
3779         (m32r_dummy_id): Delete.
3780         (m32r_gdbarch_init): Don't register deleted functions with
3781         gdbarch.
3782
3783 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3784
3785         * m32c-tdep.c (m32c_unwind_pc): Delete.
3786         (m32c_unwind_sp): Delete.
3787         (m32c_dummy_id): Delete.
3788         (m32c_gdbarch_init): Don't register deleted functions with
3789         gdbarch.
3790
3791 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3792
3793         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3794         (lm32_unwind_pc): Delete.
3795         (lm32_dummy_id): Delete.
3796         (lm32_gdbarch_init): Don't register deleted functions with
3797         gdbarch.
3798
3799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3802         (iq2000_unwind_pc): Delete.
3803         (iq2000_dummy_id): Delete.
3804         (iq2000_gdbarch_init): Don't register deleted functions with
3805         gdbarch.
3806
3807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3808
3809         * nds32-tdep.c (nds32_type_align): Delete.
3810         (nds32_push_dummy_call): Use type_align instead.
3811
3812 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * arm-tdep.c (arm_type_align): Only handle vector override case.
3815         (arm_push_dummy_call): Use type_align.
3816         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3817
3818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3819
3820         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3821         case.
3822         (pass_on_stack): Use type_align.
3823         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3824         function.
3825
3826 2019-04-23  Tom Tromey  <tromey@adacore.com>
3827
3828         * dwarf2read.c (line_header::file_name_at): Remove unused
3829         overload.
3830
3831 2019-04-23  Tom de Vries  <tdevries@suse.de>
3832
3833         PR gdb/24438
3834         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3835         invocation.
3836
3837
3838 2019-03-27  Ali Tamur  <tamur@google.com>
3839
3840         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3841         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3842         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3843         (dwarf_expr_context::get_addr_index): Likewise
3844         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3845         (symbol_needs_eval_context::get_addr_index): Likewise
3846         (disassemble_dwarf_expression): Add DW_OP_addrx
3847         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3848         (read_cutu_die_from_dwo): Update comment
3849         (skip_one_die): Add DW_FORM_addrx
3850         (read_attribute_value): Likewise
3851         (var_decode_location): Add DW_OP_addrx
3852         (dwarf2_const_value_attr): Add DW_FORM_addrx
3853         (dump_die_shallow): Likewise
3854         (dwarf2_fetch_constant_bytes): Likewise
3855         (decode_locdesc): Add DW_OP_addrx
3856         (skip_form_bytes): Add DW_FORM_addrx
3857
3858 2019-04-22  Ali Tamur  <tamur@google.com>
3859
3860         * MAINTAINERS (Write After Approval): Add self.
3861
3862 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3863
3864         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3865         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3866         (open_symbol_file_object): Likewise.
3867         (svr4_default_sos): Add info parameter.
3868         (svr4_read_so_list): Likewise.
3869         (svr4_current_sos_direct): Adjust functions calls to pass down
3870         info.
3871         (svr4_current_sos_1): Add info parameter.
3872         (svr4_current_sos): Call get_svr4_info, pass info down to
3873         svr4_current_sos_1.
3874         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3875         get_svr4_info.
3876         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3877         get_svr4_info.
3878         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3879         to get_svr4_info.
3880         (probes_table_remove_objfile_probes): Likewise.
3881         (register_solib_event_probe): Add info parameter.
3882         (solist_update_incremental): Pass info parameter down to
3883         svr4_read_so_list.
3884         (disable_probes_interface): Add info parameter.
3885         (svr4_handle_solib_event): Pass current_program_space to
3886         get_svr4_info.  Adjust disable_probes_interface cleanup.
3887         (svr4_create_probe_breakpoints): Add info parameter, pass it
3888         down to register_solib_event_probe.
3889         (svr4_create_solib_event_breakpoints): Add info parameter,
3890         pass it down to svr4_create_probe_breakpoints.
3891         (enable_break): Pass info down to
3892         svr4_create_solib_event_breakpoints.
3893         (svr4_solib_create_inferior_hook): Pass current_program_space to
3894         get_svr4_info.
3895         (svr4_clear_solib): Likewise.
3896
3897 2019-04-22  Pedro Alves  <palves@redhat.com>
3898
3899         * solib-svr4.c (svr4_free_objfile_observer): New.
3900         (probe_and_action::objfile): New field.
3901         (probes_table_htab_remove_objfile_probes)
3902         (probes_table_remove_objfile_probes): New functions.
3903         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3904         in the new probe_and_action.  Don't store the probe in 'lookup'.
3905         (svr4_create_probe_breakpoints): Pass objfile to
3906         register_solib_event_probe.
3907         (_initialize_svr4_solib): Register a free_objfile observer.
3908
3909 2019-04-19  Tom Tromey  <tom@tromey.com>
3910
3911         * common/queue.h: Remove.
3912
3913 2019-04-19  Tom Tromey  <tom@tromey.com>
3914
3915         * event-loop.c: Don't include "common/queue.h".
3916
3917 2019-04-19  Tom Tromey  <tom@tromey.com>
3918
3919         * remote.c (remote_target): Use delete.
3920         * remote-notif.h: Include <list>, not "common/queue.h".
3921         (notif_client_p): Remove typedef.
3922         (remote_notif_state): Add constructor, destructor, initializer.
3923         <notif_queue>: Now a std::list.
3924         (remote_notif_state_xfree): Don't declare.
3925         * remote-notif.c (remote_notif_process, handle_notification)
3926         (remote_notif_state_allocate): Update.
3927         (~remote_notif_state): Rename from remote_notif_state_xfree.
3928
3929 2019-04-19  Tom Tromey  <tom@tromey.com>
3930
3931         * symfile.c (reread_symbols): Update.
3932         * objfiles.c (objfile_register_static_link)
3933         (objfile_lookup_static_link): Update
3934         (~objfile) Don't delete static_links.
3935         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3936
3937 2019-04-19  Tom Tromey  <tom@tromey.com>
3938
3939         * type-stack.h (struct type_stack) <insert>: Constify string.
3940         * type-stack.c (type_stack::insert): Constify string.
3941         * gdbtypes.h (lookup_template_type): Update.
3942         (address_space_name_to_int): Update.
3943         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3944         const.
3945         (lookup_template_type): Make name const.
3946         * c-exp.y: Update rules.
3947         (lex_one_token, classify_name, classify_inner_name)
3948         (c_print_token): Update.
3949         * p-exp.y: Update rules.
3950         (yylex): Update.
3951         * f-exp.y: Update rules.
3952         (yylex): Update.
3953         * d-exp.y: Update rules.
3954         (lex_one_token, classify_name, classify_inner_name): Update.
3955         * parse.c (write_dollar_variable, copy_name): Return std::string.
3956         * parser-defs.h (copy_name): Change return type.
3957         * m2-exp.y: Update rules.
3958         (yylex): Update.
3959         * go-exp.y (lex_one_token): Update.
3960         Update rules.
3961         (classify_unsafe_function, classify_packaged_name)
3962         (classify_name, yylex): Update.
3963
3964 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3965
3966         * configure.ac: add --enable-source-highlight switch.
3967         * configure: Regenerate.
3968         * top.c (print_gdb_version): plumb --enable-source-highlight
3969         status to "show configuration".
3970
3971 2019-04-19  Tom Tromey  <tromey@adacore.com>
3972
3973         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3974         Check ADA_TYPE_P.
3975         (empty_record, ada_template_to_fixed_record_type_1)
3976         (template_to_static_fixed_type)
3977         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3978         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3979         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3980         macros.
3981
3982 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3983
3984         PR symtab/24423:
3985         * source.c (print_source_lines_base): Advance "iter" when a
3986         control character is seen.
3987
3988 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3989
3990         * inferior.h (struct infcall_suspend_state_deleter):
3991         Catch exception in destructor to avoid crash.
3992
3993 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3994
3995         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3996         close to the add_com "shell".
3997
3998 2019-04-18  Tom Tromey  <tromey@adacore.com>
3999
4000         * process-stratum-target.h (class process_stratum_target)
4001         <stratum>: Add "final".
4002
4003 2019-04-17  Tom Tromey  <tromey@adacore.com>
4004
4005         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4006         against nullptr before use.
4007
4008 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4009
4010         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4011
4012 2019-04-17  Jim Wilson  <jimw@sifive.com>
4013             Andrew Burgess  <andrew.burgess@embecosm.com>
4014
4015         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4016         code read might fail, assume 4-byte breakpoint in that case.
4017
4018 2019-04-15  Leszek Swirski  <leszeks@google.com>
4019
4020         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4021         rather than a hand-rolled POD check when checking for forced MEMORY
4022         classification.
4023
4024 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4025
4026         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4027         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4028         function.
4029         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4030         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4031         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4032         declaration.
4033
4034 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4035
4036         * aarch64-linux-nat.c
4037         (aarch64_linux_nat_target::thread_architecture): Add override.
4038         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4039         each VQ.
4040
4041 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4042
4043         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4044
4045 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4048         target types of size 96-bits, add some additional comments, and
4049         check that the builtin type we found was the correct size.
4050
4051 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4052
4053         * utils.c (prompt_for_continue): Don't restore the styling at the
4054         end, as applied_style has the wrong value.  This fixes styling in
4055         long lists of file names that are interrupted by the "Continue?"
4056         prompt.
4057
4058 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4059
4060         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4061         * c-lang.c (c_language_defn): Likewise.
4062         (cplus_language_defn): Likewise.
4063         (asm_language_defn): Likewise.
4064         (minimal_language_defn): Likewise.
4065         * d-lang.c (d_language_defn): Likewise.
4066         * f-lang.c (f_language_defn): Likewise.
4067         * go-lang.c (go_language_defn): Likewise.
4068         * language.c (unknown_language_defn): Likewise.
4069         (auto_language_defn): Likewise.
4070         * language.h (struct language_defn): Remove la_magic field.
4071         (LANG_MAGIC): Delete.
4072         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4073         * objc-lang.c (objc_language_defn): Likewise.
4074         * opencl-lang.c (opencl_language_defn): Likewise.
4075         * p-lang.c (pascal_language_defn): Likewise.
4076         * rust-lang.c (rust_language_defn): Likewise.
4077
4078 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4079
4080         * riscv-tdep.c (riscv_type_align): New function.
4081         (riscv_type_alignment): Delete.
4082         (riscv_arg_location): Use 'type_align'.
4083         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4084
4085 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4086
4087         * gdbtypes.c (type_align): A struct with no non-static fields also
4088         has alignment of 1.
4089
4090 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4091
4092         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4093         component to 0.
4094         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4095         member.
4096         (riscv_struct_info::analyse): New implementation using new
4097         analyse_inner member function.
4098         (riscv_struct_info::field_offset): New member function.
4099         (riscv_struct_info::m_offsets): New member variable.
4100         (riscv_struct_info::analyse_inner): New private member function,
4101         takes the old implementation of riscv_struct_info::analyse but
4102         extended to track field offsets.
4103         (riscv_call_arg_struct): Update the struct folding special cases
4104         to handle cases where empty C++ structs, which are non-zero
4105         length, are found.
4106         (riscv_arg_location): Initialise the length of each location, a
4107         non-zero length now indicates the location is in use.
4108         (riscv_push_dummy_call): Allow for the first location having a
4109         non-zero offset when setting up arguments.
4110         (riscv_return_value): Likewise, but for return values.
4111
4112 2019-04-11  Tom Tromey  <tromey@adacore.com>
4113
4114         * utils.c (internal_vproblem): Make "msg" const.
4115
4116 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4117
4118         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4119         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4120         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4121         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4122
4123 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4124
4125         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4126         function.
4127         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4128         of amd64_collect_native_gregset.
4129         (amd64_linux_nat_target::store_registers): Likewise.
4130
4131 2019-04-10  Tom Tromey  <tom@tromey.com>
4132
4133         * symtab.c (lookup_global_symbol_from_objfile)
4134         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4135         * objfiles.h (class separate_debug_iterator): New.
4136         (class separate_debug_range): New.
4137         (struct objfile) <separate_debug_objfiles>: New method.
4138         (objfile_separate_debug_iterate): Don't declare.
4139         * objfiles.c (separate_debug_iterator::operator++): Rename from
4140         objfile_separate_debug_iterate.
4141         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4142         iterator.
4143         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4144         iterator.
4145
4146 2019-04-10  Tom Tromey  <tom@tromey.com>
4147
4148         * symfile.c (reread_symbols): Remove old comment.
4149         * objfiles.c (free_all_objfiles): Fix a typo.
4150
4151 2019-04-10  Tom Tromey  <tom@tromey.com>
4152
4153         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4154         * minsyms.c (lookup_minimal_symbol): Use foreach.
4155         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4156         (lookup_minimal_symbol_solib_trampoline): Likewise.
4157         * symfile.c (reread_symbols): Use foreach.
4158
4159 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4160             Tom Tromey  <tromey@adacore.com>
4161
4162         PR rust/24414:
4163         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4164         (rust_lex_int_test): Change "value" to be LONGEST.
4165         (rust_lex_tests): Add test for long integer literal.
4166
4167 2019-04-09  Tom Tromey  <tromey@adacore.com>
4168
4169         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4170         to bool.
4171         (extended_remote_target::attach): Update.
4172         (remote_target::remote_notice_new_inferior): Update.
4173         (remote_target::add_current_inferior_and_thread): Update.
4174         * inferior.c (exit_inferior_1): Use "false".
4175         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4176
4177 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4178
4179         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4180         the "start" command.
4181
4182 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4183
4184         * python/py-inferior.c (infpy_thread_from_thread_handle):
4185         Adjust comments to reflect renaming of thread_from_thread_handle
4186         to thread_from_handle.  Adjust keywords.  Fix type error message.
4187         (inferior_object_methods): Add thread_from_handle.  Retain
4188         thread_from_thread_handle, but mark it as deprecated.
4189
4190 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4191
4192         * gdbthread.h (find_thread_by_handle): Revise declaration.
4193         * thread.c (find_thread_by_handle): Likewise.  Adjust
4194         implementation too.
4195         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4196         support for buffer objects as handles.
4197
4198 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4199
4200         * python/py-infthread.c (thpy_thread_handle): New function.
4201         (thread_object_methods): Register thpy_thread_handle.
4202
4203 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4204
4205         * gdbthread.h (thread_to_thread_handle): Declare.
4206         * thread.c (gdbtypes.h): Include.
4207         (thread_to_thread_handle): New function.
4208
4209         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4210         (target_thread_info_to_thread_handle): Declare.
4211         * target.c (target_thread_info_to_thread_handle): New function.
4212         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4213         * target-delegates.c: Regenerate.
4214
4215         * linux-thread-db.c (class thread_db_target): Add method
4216         thread_info_to_thread_handle.
4217         (thread_db_target::thread_info_to_thread_handle): Define.
4218         * remote.c (class remote_target): Add new method
4219         thread_info_to_thread_handle.
4220         (remote_target::thread_info_to_thread_handle): Define.
4221
4222 2019-04-08  Pedro Alves  <palves@redhat.com>
4223
4224         * common/common-exceptions.c (throw_exception): Don't create
4225         named object to throw; throw directly.
4226         (throw_it): Likewise.  Don't initialize gdb_exception::message
4227         here, with new; pass FMT and AP to the ctor instead.
4228         * common/common-exceptions.h: Include <string>.
4229         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4230         const char *, va_list)): New ctor.  Use std::make_shared.
4231         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4232         errors)): Delete.
4233         (gdb_exception_error::gdb_exception_error(enum errors, const char
4234         *, va_list)): New.
4235         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4236         Add assertion.
4237         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4238         errors)): Delete.
4239         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4240         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4241         Add assertion.
4242
4243 2019-04-08  Tom Tromey  <tom@tromey.com>
4244
4245         * valops.c (value_rtti_indirect_type): Replace throw_exception
4246         with throw.
4247         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4248         with throw.
4249         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4250         throw.
4251         * target.c (target_translate_tls_address): Replace throw_exception
4252         with throw.
4253         * stack.c (frame_apply_command_count): Replace throw_exception
4254         with throw.
4255         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4256         throw.
4257         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4258         with throw.
4259         * rs6000-tdep.c (rs6000_frame_cache)
4260         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4261         * remote.c: Replace throw_exception with throw.
4262         * record-full.c (record_full_message, record_full_wait_1)
4263         (record_full_restore): Replace throw_exception with throw.
4264         * record-btrace.c:
4265         (get_thread_current_frame_id, record_btrace_start_replaying)
4266         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4267         (cmd_record_btrace_start): Replace throw_exception with throw.
4268         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4269         throw.
4270         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4271         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4272         * linespec.c:
4273         (find_linespec_symbols): Replace throw_exception with throw.
4274         * infrun.c (displaced_step_prepare, resume): Replace
4275         throw_exception with throw.
4276         * infcmd.c (post_create_inferior): Replace throw_exception with
4277         throw.
4278         * inf-loop.c (inferior_event_handler): Replace throw_exception
4279         with throw.
4280         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4281         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4282         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4283         (get_prev_frame_always, get_frame_pc_if_available)
4284         (get_frame_address_in_block_if_available, get_frame_language):
4285         Replace throw_exception with throw.
4286         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4287         throw_exception with throw.
4288         * eval.c (fetch_subexp_value, evaluate_var_value)
4289         (evaluate_funcall, evaluate_subexp_standard): Replace
4290         throw_exception with throw.
4291         * dwarf2loc.c (call_site_find_chain)
4292         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4293         Replace throw_exception with throw.
4294         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4295         with throw.
4296         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4297         throw.
4298         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4299         * completer.c (complete_line_internal): Replace throw_exception
4300         with throw.
4301         * compile/compile-object-run.c (compile_object_run): Replace
4302         throw_exception with throw.
4303         * cli/cli-script.c (process_next_line): Replace throw_exception
4304         with throw.
4305         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4306         (btrace_enable, btrace_maint_update_pt_packets): Replace
4307         throw_exception with throw.
4308         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4309         throw_exception with throw.
4310         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4311         throw_exception with throw.
4312         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4313         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4314         * aarch64-tdep.c (aarch64_make_prologue_cache)
4315         (aarch64_make_stub_cache): Replace throw_exception with throw.
4316
4317 2019-04-08  Tom Tromey  <tom@tromey.com>
4318
4319         * common/common-exceptions.c (throw_exception): Rename from
4320         throw_exception_cxx.  Remove old copy.  Make argument const.
4321         (throw_it): Create and throw exception objects directly.
4322         * common/common-exceptions.h (throw_exception): Make argument
4323         const.
4324         (struct gdb_exception_error): Add constructor.
4325         (struct gdb_exception_quit): Add constructor.
4326
4327 2019-04-08  Tom Tromey  <tom@tromey.com>
4328
4329         * common/common-exceptions.h (exception_rethrow): Don't declare.
4330         (TRY_SJLJ): Update comment.
4331         (TRY, CATCH, END_CATCH): Remove.
4332         * common/common-exceptions.c (exception_rethrow): Remove.
4333
4334 2019-04-08  Tom Tromey  <tom@tromey.com>
4335
4336         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4337         Remove.
4338         (gdb_exception_error): Rename from
4339         gdb_exception_RETURN_MASK_ERROR.
4340         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4341         (gdb_quit_bad_alloc): Update.
4342         * aarch64-tdep.c: Update.
4343         * ada-lang.c: Update.
4344         * ada-typeprint.c: Update.
4345         * ada-valprint.c: Update.
4346         * amd64-tdep.c: Update.
4347         * arch-utils.c: Update.
4348         * break-catch-throw.c: Update.
4349         * breakpoint.c: Update.
4350         * btrace.c: Update.
4351         * c-varobj.c: Update.
4352         * cli/cli-cmds.c: Update.
4353         * cli/cli-interp.c: Update.
4354         * cli/cli-script.c: Update.
4355         * common/common-exceptions.c: Update.
4356         * common/new-op.c: Update.
4357         * common/selftest.c: Update.
4358         * compile/compile-c-symbols.c: Update.
4359         * compile/compile-cplus-symbols.c: Update.
4360         * compile/compile-object-load.c: Update.
4361         * compile/compile-object-run.c: Update.
4362         * completer.c: Update.
4363         * corelow.c: Update.
4364         * cp-abi.c: Update.
4365         * cp-support.c: Update.
4366         * cp-valprint.c: Update.
4367         * darwin-nat.c: Update.
4368         * disasm-selftests.c: Update.
4369         * dtrace-probe.c: Update.
4370         * dwarf-index-cache.c: Update.
4371         * dwarf-index-write.c: Update.
4372         * dwarf2-frame-tailcall.c: Update.
4373         * dwarf2-frame.c: Update.
4374         * dwarf2loc.c: Update.
4375         * dwarf2read.c: Update.
4376         * eval.c: Update.
4377         * event-loop.c: Update.
4378         * event-top.c: Update.
4379         * exec.c: Update.
4380         * f-valprint.c: Update.
4381         * fbsd-tdep.c: Update.
4382         * frame-unwind.c: Update.
4383         * frame.c: Update.
4384         * gdbtypes.c: Update.
4385         * gnu-v3-abi.c: Update.
4386         * guile/guile-internal.h: Update.
4387         * guile/scm-block.c: Update.
4388         * guile/scm-breakpoint.c: Update.
4389         * guile/scm-cmd.c: Update.
4390         * guile/scm-disasm.c: Update.
4391         * guile/scm-frame.c: Update.
4392         * guile/scm-lazy-string.c: Update.
4393         * guile/scm-math.c: Update.
4394         * guile/scm-param.c: Update.
4395         * guile/scm-ports.c: Update.
4396         * guile/scm-pretty-print.c: Update.
4397         * guile/scm-symbol.c: Update.
4398         * guile/scm-symtab.c: Update.
4399         * guile/scm-type.c: Update.
4400         * guile/scm-value.c: Update.
4401         * i386-linux-tdep.c: Update.
4402         * i386-tdep.c: Update.
4403         * inf-loop.c: Update.
4404         * infcall.c: Update.
4405         * infcmd.c: Update.
4406         * infrun.c: Update.
4407         * jit.c: Update.
4408         * language.c: Update.
4409         * linespec.c: Update.
4410         * linux-fork.c: Update.
4411         * linux-nat.c: Update.
4412         * linux-tdep.c: Update.
4413         * linux-thread-db.c: Update.
4414         * main.c: Update.
4415         * mi/mi-cmd-break.c: Update.
4416         * mi/mi-cmd-stack.c: Update.
4417         * mi/mi-interp.c: Update.
4418         * mi/mi-main.c: Update.
4419         * objc-lang.c: Update.
4420         * p-valprint.c: Update.
4421         * parse.c: Update.
4422         * ppc-linux-tdep.c: Update.
4423         * printcmd.c: Update.
4424         * python/py-arch.c: Update.
4425         * python/py-breakpoint.c: Update.
4426         * python/py-cmd.c: Update.
4427         * python/py-finishbreakpoint.c: Update.
4428         * python/py-frame.c: Update.
4429         * python/py-framefilter.c: Update.
4430         * python/py-gdb-readline.c: Update.
4431         * python/py-inferior.c: Update.
4432         * python/py-infthread.c: Update.
4433         * python/py-lazy-string.c: Update.
4434         * python/py-linetable.c: Update.
4435         * python/py-objfile.c: Update.
4436         * python/py-param.c: Update.
4437         * python/py-prettyprint.c: Update.
4438         * python/py-progspace.c: Update.
4439         * python/py-record-btrace.c: Update.
4440         * python/py-record.c: Update.
4441         * python/py-symbol.c: Update.
4442         * python/py-type.c: Update.
4443         * python/py-unwind.c: Update.
4444         * python/py-utils.c: Update.
4445         * python/py-value.c: Update.
4446         * python/python.c: Update.
4447         * record-btrace.c: Update.
4448         * record-full.c: Update.
4449         * remote-fileio.c: Update.
4450         * remote.c: Update.
4451         * riscv-tdep.c: Update.
4452         * rs6000-aix-tdep.c: Update.
4453         * rs6000-tdep.c: Update.
4454         * rust-exp.y: Update.
4455         * rust-lang.c: Update.
4456         * s390-tdep.c: Update.
4457         * selftest-arch.c: Update.
4458         * solib-dsbt.c: Update.
4459         * solib-frv.c: Update.
4460         * solib-spu.c: Update.
4461         * solib-svr4.c: Update.
4462         * solib.c: Update.
4463         * sparc64-linux-tdep.c: Update.
4464         * stack.c: Update.
4465         * symfile-mem.c: Update.
4466         * symmisc.c: Update.
4467         * target.c: Update.
4468         * thread.c: Update.
4469         * top.c: Update.
4470         * tracefile-tfile.c: Update.
4471         * tui/tui.c: Update.
4472         * typeprint.c: Update.
4473         * unittests/cli-utils-selftests.c: Update.
4474         * unittests/parse-connection-spec-selftests.c: Update.
4475         * valops.c: Update.
4476         * valprint.c: Update.
4477         * value.c: Update.
4478         * varobj.c: Update.
4479         * windows-nat.c: Update.
4480         * x86-linux-nat.c: Update.
4481         * xml-support.c: Update.
4482
4483 2019-04-08  Tom Tromey  <tom@tromey.com>
4484
4485         * xml-support.c: Use C++ exception handling.
4486         * x86-linux-nat.c: Use C++ exception handling.
4487         * windows-nat.c: Use C++ exception handling.
4488         * varobj.c: Use C++ exception handling.
4489         * value.c: Use C++ exception handling.
4490         * valprint.c: Use C++ exception handling.
4491         * valops.c: Use C++ exception handling.
4492         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4493         handling.
4494         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4495         * typeprint.c: Use C++ exception handling.
4496         * tui/tui.c: Use C++ exception handling.
4497         * tracefile-tfile.c: Use C++ exception handling.
4498         * top.c: Use C++ exception handling.
4499         * thread.c: Use C++ exception handling.
4500         * target.c: Use C++ exception handling.
4501         * symmisc.c: Use C++ exception handling.
4502         * symfile-mem.c: Use C++ exception handling.
4503         * stack.c: Use C++ exception handling.
4504         * sparc64-linux-tdep.c: Use C++ exception handling.
4505         * solib.c: Use C++ exception handling.
4506         * solib-svr4.c: Use C++ exception handling.
4507         * solib-spu.c: Use C++ exception handling.
4508         * solib-frv.c: Use C++ exception handling.
4509         * solib-dsbt.c: Use C++ exception handling.
4510         * selftest-arch.c: Use C++ exception handling.
4511         * s390-tdep.c: Use C++ exception handling.
4512         * rust-lang.c: Use C++ exception handling.
4513         * rust-exp.y: Use C++ exception handling.
4514         * rs6000-tdep.c: Use C++ exception handling.
4515         * rs6000-aix-tdep.c: Use C++ exception handling.
4516         * riscv-tdep.c: Use C++ exception handling.
4517         * remote.c: Use C++ exception handling.
4518         * remote-fileio.c: Use C++ exception handling.
4519         * record-full.c: Use C++ exception handling.
4520         * record-btrace.c: Use C++ exception handling.
4521         * python/python.c: Use C++ exception handling.
4522         * python/py-value.c: Use C++ exception handling.
4523         * python/py-utils.c: Use C++ exception handling.
4524         * python/py-unwind.c: Use C++ exception handling.
4525         * python/py-type.c: Use C++ exception handling.
4526         * python/py-symbol.c: Use C++ exception handling.
4527         * python/py-record.c: Use C++ exception handling.
4528         * python/py-record-btrace.c: Use C++ exception handling.
4529         * python/py-progspace.c: Use C++ exception handling.
4530         * python/py-prettyprint.c: Use C++ exception handling.
4531         * python/py-param.c: Use C++ exception handling.
4532         * python/py-objfile.c: Use C++ exception handling.
4533         * python/py-linetable.c: Use C++ exception handling.
4534         * python/py-lazy-string.c: Use C++ exception handling.
4535         * python/py-infthread.c: Use C++ exception handling.
4536         * python/py-inferior.c: Use C++ exception handling.
4537         * python/py-gdb-readline.c: Use C++ exception handling.
4538         * python/py-framefilter.c: Use C++ exception handling.
4539         * python/py-frame.c: Use C++ exception handling.
4540         * python/py-finishbreakpoint.c: Use C++ exception handling.
4541         * python/py-cmd.c: Use C++ exception handling.
4542         * python/py-breakpoint.c: Use C++ exception handling.
4543         * python/py-arch.c: Use C++ exception handling.
4544         * printcmd.c: Use C++ exception handling.
4545         * ppc-linux-tdep.c: Use C++ exception handling.
4546         * parse.c: Use C++ exception handling.
4547         * p-valprint.c: Use C++ exception handling.
4548         * objc-lang.c: Use C++ exception handling.
4549         * mi/mi-main.c: Use C++ exception handling.
4550         * mi/mi-interp.c: Use C++ exception handling.
4551         * mi/mi-cmd-stack.c: Use C++ exception handling.
4552         * mi/mi-cmd-break.c: Use C++ exception handling.
4553         * main.c: Use C++ exception handling.
4554         * linux-thread-db.c: Use C++ exception handling.
4555         * linux-tdep.c: Use C++ exception handling.
4556         * linux-nat.c: Use C++ exception handling.
4557         * linux-fork.c: Use C++ exception handling.
4558         * linespec.c: Use C++ exception handling.
4559         * language.c: Use C++ exception handling.
4560         * jit.c: Use C++ exception handling.
4561         * infrun.c: Use C++ exception handling.
4562         * infcmd.c: Use C++ exception handling.
4563         * infcall.c: Use C++ exception handling.
4564         * inf-loop.c: Use C++ exception handling.
4565         * i386-tdep.c: Use C++ exception handling.
4566         * i386-linux-tdep.c: Use C++ exception handling.
4567         * guile/scm-value.c: Use C++ exception handling.
4568         * guile/scm-type.c: Use C++ exception handling.
4569         * guile/scm-symtab.c: Use C++ exception handling.
4570         * guile/scm-symbol.c: Use C++ exception handling.
4571         * guile/scm-pretty-print.c: Use C++ exception handling.
4572         * guile/scm-ports.c: Use C++ exception handling.
4573         * guile/scm-param.c: Use C++ exception handling.
4574         * guile/scm-math.c: Use C++ exception handling.
4575         * guile/scm-lazy-string.c: Use C++ exception handling.
4576         * guile/scm-frame.c: Use C++ exception handling.
4577         * guile/scm-disasm.c: Use C++ exception handling.
4578         * guile/scm-cmd.c: Use C++ exception handling.
4579         * guile/scm-breakpoint.c: Use C++ exception handling.
4580         * guile/scm-block.c: Use C++ exception handling.
4581         * guile/guile-internal.h: Use C++ exception handling.
4582         * gnu-v3-abi.c: Use C++ exception handling.
4583         * gdbtypes.c: Use C++ exception handling.
4584         * frame.c: Use C++ exception handling.
4585         * frame-unwind.c: Use C++ exception handling.
4586         * fbsd-tdep.c: Use C++ exception handling.
4587         * f-valprint.c: Use C++ exception handling.
4588         * exec.c: Use C++ exception handling.
4589         * event-top.c: Use C++ exception handling.
4590         * event-loop.c: Use C++ exception handling.
4591         * eval.c: Use C++ exception handling.
4592         * dwarf2read.c: Use C++ exception handling.
4593         * dwarf2loc.c: Use C++ exception handling.
4594         * dwarf2-frame.c: Use C++ exception handling.
4595         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4596         * dwarf-index-write.c: Use C++ exception handling.
4597         * dwarf-index-cache.c: Use C++ exception handling.
4598         * dtrace-probe.c: Use C++ exception handling.
4599         * disasm-selftests.c: Use C++ exception handling.
4600         * darwin-nat.c: Use C++ exception handling.
4601         * cp-valprint.c: Use C++ exception handling.
4602         * cp-support.c: Use C++ exception handling.
4603         * cp-abi.c: Use C++ exception handling.
4604         * corelow.c: Use C++ exception handling.
4605         * completer.c: Use C++ exception handling.
4606         * compile/compile-object-run.c: Use C++ exception handling.
4607         * compile/compile-object-load.c: Use C++ exception handling.
4608         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4609         * compile/compile-c-symbols.c: Use C++ exception handling.
4610         * common/selftest.c: Use C++ exception handling.
4611         * common/new-op.c: Use C++ exception handling.
4612         * cli/cli-script.c: Use C++ exception handling.
4613         * cli/cli-interp.c: Use C++ exception handling.
4614         * cli/cli-cmds.c: Use C++ exception handling.
4615         * c-varobj.c: Use C++ exception handling.
4616         * btrace.c: Use C++ exception handling.
4617         * breakpoint.c: Use C++ exception handling.
4618         * break-catch-throw.c: Use C++ exception handling.
4619         * arch-utils.c: Use C++ exception handling.
4620         * amd64-tdep.c: Use C++ exception handling.
4621         * ada-valprint.c: Use C++ exception handling.
4622         * ada-typeprint.c: Use C++ exception handling.
4623         * ada-lang.c: Use C++ exception handling.
4624         * aarch64-tdep.c: Use C++ exception handling.
4625
4626 2019-04-08  Tom Tromey  <tom@tromey.com>
4627
4628         * xml-support.c (gdb_xml_parser::parse): Update.
4629         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4630         * value.c (show_convenience): Update.
4631         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4632         (test_parse_flags_qcs): Update.
4633         * thread.c (thr_try_catch_cmd): Update.
4634         * target.c (target_translate_tls_address): Update.
4635         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4636         (info_frame_command_core, frame_apply_command_count): Update.
4637         * rust-exp.y (rust_lex_exception_test): Update.
4638         * riscv-tdep.c (riscv_print_one_register_info): Update.
4639         * remote.c (remote_target::enable_btrace): Update.
4640         * record-btrace.c (record_btrace_enable_warn): Update.
4641         * python/py-utils.c (gdbpy_convert_exception): Update.
4642         * printcmd.c (do_one_display, print_variable_and_value): Update.
4643         * mi/mi-main.c (mi_print_exception): Update.
4644         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4645         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4646         * linux-nat.c (linux_nat_target::attach): Update.
4647         * linux-fork.c (class scoped_switch_fork_info): Update.
4648         * infrun.c (displaced_step_prepare): Update.
4649         * infcall.c (call_function_by_hand_dummy): Update.
4650         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4651         * gnu-v3-abi.c (print_one_vtable): Update.
4652         * frame.c (get_prev_frame_always): Update.
4653         * f-valprint.c (info_common_command_for_block): Update.
4654         * exec.c (try_open_exec_file): Update.
4655         * exceptions.c (print_exception, exception_print)
4656         (exception_fprintf, exception_print_same): Update.
4657         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4658         * dwarf-index-cache.c (index_cache::store)
4659         (index_cache::lookup_gdb_index): Update.
4660         * darwin-nat.c (maybe_cache_shell): Update.
4661         * cp-valprint.c (cp_print_value_fields): Update.
4662         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4663         (gcc_cplus_symbol_address): Update.
4664         * compile/compile-c-symbols.c (gcc_convert_symbol)
4665         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4666         * common/selftest.c: Update.
4667         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4668         a std::string.
4669         (exception_try_scope_entry, exception_try_scope_exit): Don't
4670         declare.
4671         (struct exception_try_scope): Remove.
4672         (TRY): Don't use exception_try_scope.
4673         (struct gdb_exception): Add constructor, operator=.
4674         <what>: New method.
4675         (struct gdb_exception_RETURN_MASK_ALL)
4676         (struct gdb_exception_RETURN_MASK_ERROR)
4677         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4678         (struct gdb_quit_bad_alloc): Update.
4679         * common/common-exceptions.c (exception_none): Change
4680         initializer.
4681         (struct catcher) <state, exception>: Initialize inline.
4682         <prev>: Remove member.
4683         (current_catcher): Remove.
4684         (catchers): New global.
4685         (exceptions_state_mc_init): Simplify.
4686         (catcher_pop): Remove.
4687         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4688         (try_scope_depth, exception_try_scope_entry)
4689         (exception_try_scope_exit): Remove.
4690         (throw_exception_sjlj): Update.
4691         (exception_messages, exception_messages_size): Remove.
4692         (throw_it): Simplify.
4693         (gdb_exception_sliced_copy): Remove.
4694         (throw_exception_cxx): Update.
4695         * cli/cli-script.c (script_from_file): Update.
4696         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4697         Update.
4698         * ada-valprint.c (ada_val_print): Update.
4699         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4700         (create_excep_cond_exprs): Update.
4701
4702 2019-04-08  Tom Tromey  <tom@tromey.com>
4703
4704         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4705         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4706         (TRY, CATCH, END_CATCH): Remove some definitions.
4707         * common/common-exceptions.c: Don't use GDB_XCPT.
4708         (catcher_list_size): Remove.
4709         (throw_exception, throw_it): Simplify.
4710
4711 2019-04-05  Tom Tromey  <tom@tromey.com>
4712
4713         Revert the header-sorting patch.
4714         * ft32-tdep.c: Revert.
4715         * frv-tdep.c: Revert.
4716         * frv-linux-tdep.c: Revert.
4717         * frame.c: Revert.
4718         * frame-unwind.c: Revert.
4719         * frame-base.c: Revert.
4720         * fork-child.c: Revert.
4721         * findvar.c: Revert.
4722         * findcmd.c: Revert.
4723         * filesystem.c: Revert.
4724         * filename-seen-cache.h: Revert.
4725         * filename-seen-cache.c: Revert.
4726         * fbsd-tdep.c: Revert.
4727         * fbsd-nat.h: Revert.
4728         * fbsd-nat.c: Revert.
4729         * f-valprint.c: Revert.
4730         * f-typeprint.c: Revert.
4731         * f-lang.c: Revert.
4732         * extension.h: Revert.
4733         * extension.c: Revert.
4734         * extension-priv.h: Revert.
4735         * expprint.c: Revert.
4736         * exec.h: Revert.
4737         * exec.c: Revert.
4738         * exceptions.c: Revert.
4739         * event-top.c: Revert.
4740         * event-loop.c: Revert.
4741         * eval.c: Revert.
4742         * elfread.c: Revert.
4743         * dwarf2read.h: Revert.
4744         * dwarf2read.c: Revert.
4745         * dwarf2loc.c: Revert.
4746         * dwarf2expr.h: Revert.
4747         * dwarf2expr.c: Revert.
4748         * dwarf2-frame.c: Revert.
4749         * dwarf2-frame-tailcall.c: Revert.
4750         * dwarf-index-write.h: Revert.
4751         * dwarf-index-write.c: Revert.
4752         * dwarf-index-common.c: Revert.
4753         * dwarf-index-cache.h: Revert.
4754         * dwarf-index-cache.c: Revert.
4755         * dummy-frame.c: Revert.
4756         * dtrace-probe.c: Revert.
4757         * disasm.h: Revert.
4758         * disasm.c: Revert.
4759         * disasm-selftests.c: Revert.
4760         * dictionary.c: Revert.
4761         * dicos-tdep.c: Revert.
4762         * demangle.c: Revert.
4763         * dcache.h: Revert.
4764         * dcache.c: Revert.
4765         * darwin-nat.h: Revert.
4766         * darwin-nat.c: Revert.
4767         * darwin-nat-info.c: Revert.
4768         * d-valprint.c: Revert.
4769         * d-namespace.c: Revert.
4770         * d-lang.c: Revert.
4771         * ctf.c: Revert.
4772         * csky-tdep.c: Revert.
4773         * csky-linux-tdep.c: Revert.
4774         * cris-tdep.c: Revert.
4775         * cris-linux-tdep.c: Revert.
4776         * cp-valprint.c: Revert.
4777         * cp-support.c: Revert.
4778         * cp-namespace.c: Revert.
4779         * cp-abi.c: Revert.
4780         * corelow.c: Revert.
4781         * corefile.c: Revert.
4782         * continuations.c: Revert.
4783         * completer.h: Revert.
4784         * completer.c: Revert.
4785         * complaints.c: Revert.
4786         * coffread.c: Revert.
4787         * coff-pe-read.c: Revert.
4788         * cli-out.h: Revert.
4789         * cli-out.c: Revert.
4790         * charset.c: Revert.
4791         * c-varobj.c: Revert.
4792         * c-valprint.c: Revert.
4793         * c-typeprint.c: Revert.
4794         * c-lang.c: Revert.
4795         * buildsym.c: Revert.
4796         * buildsym-legacy.c: Revert.
4797         * build-id.h: Revert.
4798         * build-id.c: Revert.
4799         * btrace.c: Revert.
4800         * bsd-uthread.c: Revert.
4801         * breakpoint.h: Revert.
4802         * breakpoint.c: Revert.
4803         * break-catch-throw.c: Revert.
4804         * break-catch-syscall.c: Revert.
4805         * break-catch-sig.c: Revert.
4806         * blockframe.c: Revert.
4807         * block.c: Revert.
4808         * bfin-tdep.c: Revert.
4809         * bfin-linux-tdep.c: Revert.
4810         * bfd-target.c: Revert.
4811         * bcache.c: Revert.
4812         * ax-general.c: Revert.
4813         * ax-gdb.h: Revert.
4814         * ax-gdb.c: Revert.
4815         * avr-tdep.c: Revert.
4816         * auxv.c: Revert.
4817         * auto-load.c: Revert.
4818         * arm-wince-tdep.c: Revert.
4819         * arm-tdep.c: Revert.
4820         * arm-symbian-tdep.c: Revert.
4821         * arm-pikeos-tdep.c: Revert.
4822         * arm-obsd-tdep.c: Revert.
4823         * arm-nbsd-tdep.c: Revert.
4824         * arm-nbsd-nat.c: Revert.
4825         * arm-linux-tdep.c: Revert.
4826         * arm-linux-nat.c: Revert.
4827         * arm-fbsd-tdep.c: Revert.
4828         * arm-fbsd-nat.c: Revert.
4829         * arm-bsd-tdep.c: Revert.
4830         * arch-utils.c: Revert.
4831         * arc-tdep.c: Revert.
4832         * arc-newlib-tdep.c: Revert.
4833         * annotate.h: Revert.
4834         * annotate.c: Revert.
4835         * amd64-windows-tdep.c: Revert.
4836         * amd64-windows-nat.c: Revert.
4837         * amd64-tdep.c: Revert.
4838         * amd64-sol2-tdep.c: Revert.
4839         * amd64-obsd-tdep.c: Revert.
4840         * amd64-obsd-nat.c: Revert.
4841         * amd64-nbsd-tdep.c: Revert.
4842         * amd64-nbsd-nat.c: Revert.
4843         * amd64-nat.c: Revert.
4844         * amd64-linux-tdep.c: Revert.
4845         * amd64-linux-nat.c: Revert.
4846         * amd64-fbsd-tdep.c: Revert.
4847         * amd64-fbsd-nat.c: Revert.
4848         * amd64-dicos-tdep.c: Revert.
4849         * amd64-darwin-tdep.c: Revert.
4850         * amd64-bsd-nat.c: Revert.
4851         * alpha-tdep.c: Revert.
4852         * alpha-obsd-tdep.c: Revert.
4853         * alpha-nbsd-tdep.c: Revert.
4854         * alpha-mdebug-tdep.c: Revert.
4855         * alpha-linux-tdep.c: Revert.
4856         * alpha-linux-nat.c: Revert.
4857         * alpha-bsd-tdep.c: Revert.
4858         * alpha-bsd-nat.c: Revert.
4859         * aix-thread.c: Revert.
4860         * agent.c: Revert.
4861         * addrmap.c: Revert.
4862         * ada-varobj.c: Revert.
4863         * ada-valprint.c: Revert.
4864         * ada-typeprint.c: Revert.
4865         * ada-tasks.c: Revert.
4866         * ada-lang.c: Revert.
4867         * aarch64-tdep.c: Revert.
4868         * aarch64-ravenscar-thread.c: Revert.
4869         * aarch64-newlib-tdep.c: Revert.
4870         * aarch64-linux-tdep.c: Revert.
4871         * aarch64-linux-nat.c: Revert.
4872         * aarch64-fbsd-tdep.c: Revert.
4873         * aarch64-fbsd-nat.c: Revert.
4874         * aarch32-linux-nat.c: Revert.
4875
4876 2019-04-05  Tom Tromey  <tom@tromey.com>
4877
4878         * ft32-tdep.c: Sort headers.
4879         * frv-tdep.c: Sort headers.
4880         * frv-linux-tdep.c: Sort headers.
4881         * frame.c: Sort headers.
4882         * frame-unwind.c: Sort headers.
4883         * frame-base.c: Sort headers.
4884         * fork-child.c: Sort headers.
4885         * findvar.c: Sort headers.
4886         * findcmd.c: Sort headers.
4887         * filesystem.c: Sort headers.
4888         * filename-seen-cache.h: Sort headers.
4889         * filename-seen-cache.c: Sort headers.
4890         * fbsd-tdep.c: Sort headers.
4891         * fbsd-nat.h: Sort headers.
4892         * fbsd-nat.c: Sort headers.
4893         * f-valprint.c: Sort headers.
4894         * f-typeprint.c: Sort headers.
4895         * f-lang.c: Sort headers.
4896         * extension.h: Sort headers.
4897         * extension.c: Sort headers.
4898         * extension-priv.h: Sort headers.
4899         * expprint.c: Sort headers.
4900         * exec.h: Sort headers.
4901         * exec.c: Sort headers.
4902         * exceptions.c: Sort headers.
4903         * event-top.c: Sort headers.
4904         * event-loop.c: Sort headers.
4905         * eval.c: Sort headers.
4906         * elfread.c: Sort headers.
4907         * dwarf2read.h: Sort headers.
4908         * dwarf2read.c: Sort headers.
4909         * dwarf2loc.c: Sort headers.
4910         * dwarf2expr.h: Sort headers.
4911         * dwarf2expr.c: Sort headers.
4912         * dwarf2-frame.c: Sort headers.
4913         * dwarf2-frame-tailcall.c: Sort headers.
4914         * dwarf-index-write.h: Sort headers.
4915         * dwarf-index-write.c: Sort headers.
4916         * dwarf-index-common.c: Sort headers.
4917         * dwarf-index-cache.h: Sort headers.
4918         * dwarf-index-cache.c: Sort headers.
4919         * dummy-frame.c: Sort headers.
4920         * dtrace-probe.c: Sort headers.
4921         * disasm.h: Sort headers.
4922         * disasm.c: Sort headers.
4923         * disasm-selftests.c: Sort headers.
4924         * dictionary.c: Sort headers.
4925         * dicos-tdep.c: Sort headers.
4926         * demangle.c: Sort headers.
4927         * dcache.h: Sort headers.
4928         * dcache.c: Sort headers.
4929         * darwin-nat.h: Sort headers.
4930         * darwin-nat.c: Sort headers.
4931         * darwin-nat-info.c: Sort headers.
4932         * d-valprint.c: Sort headers.
4933         * d-namespace.c: Sort headers.
4934         * d-lang.c: Sort headers.
4935         * ctf.c: Sort headers.
4936         * csky-tdep.c: Sort headers.
4937         * csky-linux-tdep.c: Sort headers.
4938         * cris-tdep.c: Sort headers.
4939         * cris-linux-tdep.c: Sort headers.
4940         * cp-valprint.c: Sort headers.
4941         * cp-support.c: Sort headers.
4942         * cp-namespace.c: Sort headers.
4943         * cp-abi.c: Sort headers.
4944         * corelow.c: Sort headers.
4945         * corefile.c: Sort headers.
4946         * continuations.c: Sort headers.
4947         * completer.h: Sort headers.
4948         * completer.c: Sort headers.
4949         * complaints.c: Sort headers.
4950         * coffread.c: Sort headers.
4951         * coff-pe-read.c: Sort headers.
4952         * cli-out.h: Sort headers.
4953         * cli-out.c: Sort headers.
4954         * charset.c: Sort headers.
4955         * c-varobj.c: Sort headers.
4956         * c-valprint.c: Sort headers.
4957         * c-typeprint.c: Sort headers.
4958         * c-lang.c: Sort headers.
4959         * buildsym.c: Sort headers.
4960         * buildsym-legacy.c: Sort headers.
4961         * build-id.h: Sort headers.
4962         * build-id.c: Sort headers.
4963         * btrace.c: Sort headers.
4964         * bsd-uthread.c: Sort headers.
4965         * breakpoint.h: Sort headers.
4966         * breakpoint.c: Sort headers.
4967         * break-catch-throw.c: Sort headers.
4968         * break-catch-syscall.c: Sort headers.
4969         * break-catch-sig.c: Sort headers.
4970         * blockframe.c: Sort headers.
4971         * block.c: Sort headers.
4972         * bfin-tdep.c: Sort headers.
4973         * bfin-linux-tdep.c: Sort headers.
4974         * bfd-target.c: Sort headers.
4975         * bcache.c: Sort headers.
4976         * ax-general.c: Sort headers.
4977         * ax-gdb.h: Sort headers.
4978         * ax-gdb.c: Sort headers.
4979         * avr-tdep.c: Sort headers.
4980         * auxv.c: Sort headers.
4981         * auto-load.c: Sort headers.
4982         * arm-wince-tdep.c: Sort headers.
4983         * arm-tdep.c: Sort headers.
4984         * arm-symbian-tdep.c: Sort headers.
4985         * arm-pikeos-tdep.c: Sort headers.
4986         * arm-obsd-tdep.c: Sort headers.
4987         * arm-nbsd-tdep.c: Sort headers.
4988         * arm-nbsd-nat.c: Sort headers.
4989         * arm-linux-tdep.c: Sort headers.
4990         * arm-linux-nat.c: Sort headers.
4991         * arm-fbsd-tdep.c: Sort headers.
4992         * arm-fbsd-nat.c: Sort headers.
4993         * arm-bsd-tdep.c: Sort headers.
4994         * arch-utils.c: Sort headers.
4995         * arc-tdep.c: Sort headers.
4996         * arc-newlib-tdep.c: Sort headers.
4997         * annotate.h: Sort headers.
4998         * annotate.c: Sort headers.
4999         * amd64-windows-tdep.c: Sort headers.
5000         * amd64-windows-nat.c: Sort headers.
5001         * amd64-tdep.c: Sort headers.
5002         * amd64-sol2-tdep.c: Sort headers.
5003         * amd64-obsd-tdep.c: Sort headers.
5004         * amd64-obsd-nat.c: Sort headers.
5005         * amd64-nbsd-tdep.c: Sort headers.
5006         * amd64-nbsd-nat.c: Sort headers.
5007         * amd64-nat.c: Sort headers.
5008         * amd64-linux-tdep.c: Sort headers.
5009         * amd64-linux-nat.c: Sort headers.
5010         * amd64-fbsd-tdep.c: Sort headers.
5011         * amd64-fbsd-nat.c: Sort headers.
5012         * amd64-dicos-tdep.c: Sort headers.
5013         * amd64-darwin-tdep.c: Sort headers.
5014         * amd64-bsd-nat.c: Sort headers.
5015         * alpha-tdep.c: Sort headers.
5016         * alpha-obsd-tdep.c: Sort headers.
5017         * alpha-nbsd-tdep.c: Sort headers.
5018         * alpha-mdebug-tdep.c: Sort headers.
5019         * alpha-linux-tdep.c: Sort headers.
5020         * alpha-linux-nat.c: Sort headers.
5021         * alpha-bsd-tdep.c: Sort headers.
5022         * alpha-bsd-nat.c: Sort headers.
5023         * aix-thread.c: Sort headers.
5024         * agent.c: Sort headers.
5025         * addrmap.c: Sort headers.
5026         * ada-varobj.c: Sort headers.
5027         * ada-valprint.c: Sort headers.
5028         * ada-typeprint.c: Sort headers.
5029         * ada-tasks.c: Sort headers.
5030         * ada-lang.c: Sort headers.
5031         * aarch64-tdep.c: Sort headers.
5032         * aarch64-ravenscar-thread.c: Sort headers.
5033         * aarch64-newlib-tdep.c: Sort headers.
5034         * aarch64-linux-tdep.c: Sort headers.
5035         * aarch64-linux-nat.c: Sort headers.
5036         * aarch64-fbsd-tdep.c: Sort headers.
5037         * aarch64-fbsd-nat.c: Sort headers.
5038         * aarch32-linux-nat.c: Sort headers.
5039
5040 2019-04-04  Tom Tromey  <tom@tromey.com>
5041
5042         * varobj.c (varobj_create): Update.
5043         * rust-exp.y (struct rust_parser) <update_innermost_block,
5044         lookup_symbol>: New methods.
5045         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5046         Rename.
5047         (rust_parser::rust_lookup_type)
5048         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5049         * printcmd.c (display_command, do_one_display): Update.
5050         * parser-defs.h (struct parser_state) <parser_state>: Add
5051         "tracker" parameter.
5052         (block_tracker): New member.
5053         (class innermost_block_tracker) <innermost_block_tracker>: Add
5054         "types" parameter.
5055         <reset>: Remove method.
5056         (innermost_block): Don't declare.
5057         (null_post_parser): Update.
5058         * parse.c (innermost_block): Remove global.
5059         (write_dollar_variable): Update.
5060         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5061         Remove "tracker_types" parameter.
5062         (parse_expression): Add "tracker" parameter.
5063         (parse_expression_for_completion): Update.
5064         (null_post_parser): Add "tracker" parameter.
5065         * p-exp.y: Update rules.
5066         * m2-exp.y: Update rules.
5067         * language.h (struct language_defn) <la_post_parser>: Add
5068         "tracker" parameter.
5069         * go-exp.y: Update rules.
5070         * f-exp.y: Update rules.
5071         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5072         parameter.
5073         * d-exp.y: Update rules.
5074         * c-exp.y: Update rules.
5075         * breakpoint.c (set_breakpoint_condition): Create an
5076         innermost_block_tracker.
5077         (watch_command_1): Likewise.
5078         * ada-lang.c (resolve): Add "tracker" parameter.
5079         (resolve_subexp): Likewise.
5080         * ada-exp.y (write_var_from_sym): Update.
5081
5082 2019-04-04  Tom Tromey  <tom@tromey.com>
5083
5084         * type-stack.h: New file.
5085         * type-stack.c: New file.
5086         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5087         type-stack.h.
5088         (insert_into_type_stack, insert_type, push_type, push_type_int)
5089         (insert_type_address_space, pop_type, pop_type_int)
5090         (pop_typelist, pop_type_stack, append_type_stack)
5091         (push_type_stack, get_type_stack, push_typelist)
5092         (follow_type_instance_flags, follow_types): Don't declare.
5093         * parse.c (type_stack): Remove global.
5094         (parse_exp_in_context): Update.
5095         (insert_into_type_stack, insert_type, push_type, push_type_int)
5096         (insert_type_address_space, pop_type, pop_type_int)
5097         (pop_typelist, pop_type_stack, append_type_stack)
5098         (push_type_stack, get_type_stack, push_typelist)
5099         (follow_type_instance_flags, follow_types): Remove (moved to
5100         type-stack.c).
5101         * f-exp.y (type_stack): New global.
5102         Update rules.
5103         (push_kind_type, f_parse): Update.
5104         * d-exp.y (type_stack): New global.
5105         Update rules.
5106         (d_parse): Update.
5107         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5108         Update rules.
5109         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5110         (HFILES_NO_SRCDIR): Add type-stack.h.
5111
5112 2019-04-04  Tom Tromey  <tom@tromey.com>
5113
5114         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5115         (rust_parser::convert_ast_to_expression, rust_parse)
5116         (rust_lex_test_completion, rust_lex_tests): Update.
5117         * parser-defs.h (struct expr_completion_state): New.
5118         (struct parser_state) <parser_state>: Add completion parameter.
5119         <mark_struct_expression, mark_completion_tag>: New methods.
5120         <parse_completion, m_completion_state>: New members.
5121         (prefixify_expression, null_post_parser): Update.
5122         (mark_struct_expression, mark_completion_tag): Don't declare.
5123         * parse.c (parse_completion, expout_last_struct)
5124         (expout_tag_completion_type, expout_completion_name): Remove
5125         globals.
5126         (parser_state::mark_struct_expression)
5127         (parser_state::mark_completion_tag): Now methods.
5128         (prefixify_expression): Add last_struct parameter.
5129         (prefixify_subexp): Likewise.
5130         (parse_exp_1): Update.
5131         (parse_exp_in_context): Add cstate parameter.  Update.
5132         (parse_expression_for_completion): Create an
5133         expr_completion_state.
5134         (null_post_parser): Add "completion" parameter.
5135         * p-exp.y: Update rules.
5136         (yylex): Update.
5137         * language.h (struct language_defn) <la_post_parser>: Add
5138         "completing" parameter.
5139         * go-exp.y: Update rules.
5140         (lex_one_token): Update.
5141         * expression.h (parse_completion): Don't declare.
5142         * d-exp.y: Update rules.
5143         (lex_one_token): Update rules.
5144         * c-exp.y: Update rules.
5145         (lex_one_token): Update.
5146         * ada-lang.c (resolve): Add "parse_completion" parameter.
5147         (resolve_subexp): Likewise.
5148         (ada_resolve_function): Likewise.
5149
5150 2019-04-04  Tom Tromey  <tom@tromey.com>
5151
5152         * parser-defs.h (struct parser_state) <start_arglist,
5153         end_arglist>: New methods.
5154         <arglist_len, m_funcall_chain>: New members.
5155         (arglist_len, start_arglist, end_arglist): Don't declare.
5156         * parse.c (arglist_len, funcall_chain): Remove global.
5157         (start_arglist, end_arglist): Remove functions.
5158         (parse_exp_in_context): Update.
5159         * p-exp.y: Update rules.
5160         * m2-exp.y: Update rules.
5161         * go-exp.y: Update rules.
5162         * f-exp.y: Update rules.
5163         * d-exp.y: Update rules.
5164         * c-exp.y: Update rules.
5165
5166 2019-04-04  Tom Tromey  <tom@tromey.com>
5167
5168         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5169         lex_operator, push_back>: New methods.
5170         Update all rules.
5171         (rust_parser::lex_hex, lex_escape): Rename and update.
5172         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5173         (rust_parser::lex_operator): Rename and update.
5174         (rust_parser::lex_number, rustyylex, rustyyerror)
5175         (rust_lex_test_init, rust_lex_test_sequence)
5176         (rust_lex_test_push_back, rust_lex_tests): Update.
5177         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5178         parameter.
5179         <lexptr, prev_lexptr>: New members.
5180         (lexptr, prev_lexptr): Don't declare.
5181         * parse.c (lexptr, prev_lexptr): Remove globals.
5182         (parse_exp_in_context): Update.
5183         * p-exp.y (yylex, yyerror): Update.
5184         * m2-exp.y (parse_number, yylex, yyerror): Update.
5185         * go-exp.y (lex_one_token, yyerror): Update.
5186         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5187         * d-exp.y (lex_one_token, yyerror): Update.
5188         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5189         (lex_one_token, yyerror): Update.
5190         * ada-lex.l (YY_INPUT): Update.
5191         (rewind_to_char): Update.
5192         * ada-exp.y (yyerror): Update.
5193
5194 2019-04-04  Tom Tromey  <tom@tromey.com>
5195
5196         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5197         * parser-defs.h (struct parser_state) <parser_state>: Add new
5198         parameter.
5199         <comma_terminates>: New member.
5200         (comma_terminates): Don't declare global.
5201         * parse.c (comma_terminates): Remove global.
5202         (parse_exp_in_context): Update.
5203         * p-exp.y (yylex): Update.
5204         * m2-exp.y (yylex): Update.
5205         * go-exp.y (lex_one_token): Update.
5206         * f-exp.y (yylex): Update.
5207         * d-exp.y (lex_one_token): Update.
5208         * c-exp.y (lex_one_token): Update.
5209         * ada-lex.l: Update.
5210
5211 2019-04-04  Tom Tromey  <tom@tromey.com>
5212
5213         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5214         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5215         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5216         * parser-defs.h (paren_depth): Don't declare.
5217         * parse.c (paren_depth): Remove global.
5218         (parse_exp_in_context): Update.
5219         * p-exp.y (paren_depth): New global.
5220         (pascal_parse): Initialize it.
5221         * m2-exp.y (paren_depth): New global.
5222         (m2_parse): Initialize it.
5223         * go-exp.y (paren_depth): New global.
5224         (go_parse): Initialize it.
5225         * f-exp.y (paren_depth): New global.
5226         (f_parse): Initialize it.
5227         * d-exp.y (paren_depth): New global.
5228         (d_parse): Initialize it.
5229         * c-exp.y (paren_depth): New global.
5230         (c_parse): Initialize it.
5231         * ada-lex.l (paren_depth): New global.
5232         (lexer_init): Initialize it.
5233
5234 2019-04-04  Tom Tromey  <tom@tromey.com>
5235
5236         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5237         (rust_parser::convert_ast_to_type)
5238         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5239         * parser-defs.h (struct parser_state) <parser_state>: Add
5240         parameters.  Initialize new members.
5241         <expression_context_block, expression_context_pc>: New members.
5242         * parse.c (expression_context_block, expression_context_pc):
5243         Remove globals.
5244         (parse_exp_in_context): Update.
5245         * p-exp.y: Update all rules.
5246         (yylex): Update.
5247         * m2-exp.y: Update all rules.
5248         (yylex): Update.
5249         * go-exp.y (yylex): Update.
5250         * f-exp.y (yylex): Update.
5251         * d-exp.y: Update all rules.
5252         (yylex): Update.
5253         * c-exp.y: Update all rules.
5254         (lex_one_token, classify_name, yylex, c_parse): Update.
5255         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5256
5257 2019-04-04  Tom Tromey  <tom@tromey.com>
5258
5259         * gdbarch.h, gdbarch.c: Rebuild.
5260         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5261         * stap-probe.h:
5262         (struct stap_parse_info): Replace "parser_state" with
5263         "expr_builder".
5264         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5265         (parser_state): New class.
5266         * parse.c (expr_builder): Rename.
5267         (expr_builder::release): Rename.
5268         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5269         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5270         (write_exp_elt_longcst, write_exp_elt_floatcst)
5271         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5272         (write_exp_string_vector, write_exp_bitstring)
5273         (write_exp_msymbol, mark_struct_expression)
5274         (write_dollar_variable)
5275         (insert_type_address_space, increase_expout_size): Replace
5276         "parser_state" with "expr_builder".
5277         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5278         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5279         "parser_state" with "expr_builder".
5280
5281 2019-04-04  Tom Tromey  <tom@tromey.com>
5282
5283         * rust-exp.y: Replace "parse_language" with method call.
5284         * p-exp.y:
5285         (yylex): Replace "parse_language" with method call.
5286         * m2-exp.y:
5287         (yylex): Replace "parse_language" with method call.
5288         * go-exp.y (classify_name): Replace "parse_language" with method
5289         call.
5290         * f-exp.y (yylex): Replace "parse_language" with method call.
5291         * d-exp.y (lex_one_token): Replace "parse_language" with method
5292         call.
5293         * c-exp.y:
5294         (lex_one_token, classify_name, yylex): Replace "parse_language"
5295         with method call.
5296         * ada-exp.y (find_primitive_type, type_char)
5297         (type_system_address): Replace "parse_language" with method call.
5298
5299 2019-04-04  Tom Tromey  <tom@tromey.com>
5300
5301         * rust-exp.y: Replace "parse_gdbarch" with method call.
5302         * parse.c (write_dollar_variable, insert_type_address_space):
5303         Replace "parse_gdbarch" with method call.
5304         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5305         call.
5306         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5307         call.
5308         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5309         "parse_gdbarch" with method call.
5310         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5311         with method call.
5312         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5313         "parse_gdbarch" with method call.
5314         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5315         "parse_gdbarch" with method call.
5316         * c-exp.y (parse_type, parse_number, classify_name): Replace
5317         "parse_gdbarch" with method call.
5318         * ada-lex.l: Replace "parse_gdbarch" with method call.
5319         * ada-exp.y (parse_type, find_primitive_type, type_char)
5320         (type_system_address): Replace "parse_gdbarch" with method call.
5321
5322 2019-04-04  Tom Tromey  <tom@tromey.com>
5323
5324         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5325         * stap-probe.c (stap_parse_argument): Update.
5326         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5327         initial_size parameter.
5328         * rust-exp.y (rust_lex_tests): Update.
5329         * parse.c (parser_state): Update.
5330         (parse_exp_in_context): Update.
5331         * parser-defs.h (struct parser_state) <parser_state>: Remove
5332         "initial_size" parameter.
5333
5334 2019-04-04  Tom Tromey  <tom@tromey.com>
5335
5336         * parser-defs.h (increase_expout_size): Don't declare.
5337         * parse.c (increase_expout_size): Now static.
5338
5339 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5340
5341         * gnu-nat.c (gnu_nat_target::wait): Fix
5342         target_waitstatus_to_string call.
5343
5344 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5345
5346         * eval.c (evaluate_subexp_standard): Handle internal functions
5347         during Fortran function call handling.
5348
5349 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5350
5351         * NEWS: Mention new internal functions.
5352         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5353         (read_base_type): Use dwarf2_init_complex_target_type.
5354         * value.c (creal_internal_fn): New function.
5355         (cimag_internal_fn): New function.
5356         (_initialize_values): Register new internal functions.
5357
5358 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5359
5360         * infrun.c (stop_all_threads): If debug_infrun, always
5361         trace the wait status after wait_one, using
5362         target_waitstatus_to_string and target_pid_to_str.
5363         (handle_inferior_event): Replace various trace of
5364         wait status kind by a single trace.
5365         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5366         wait status kind image by target_waitstatus_to_string.
5367         * target/waitstatus.c (target_waitstatus_to_string): Fix
5368         obsolete comment.
5369
5370 2019-04-01  Tom Tromey  <tromey@adacore.com>
5371
5372         PR symtab/23331:
5373         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5374
5375 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5376             Pedro Alves  <palves@redhat.com>
5377
5378         * top.c (quit_force): Call 'finalize_values'.
5379         * value.c (finalize_values): New function.
5380         * value.h (finalize_values): Declare.
5381
5382 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5383
5384         * NEWS: Announce $_gdb_major and $_gdb_minor.
5385
5386         * top.c (init_gdb_version_vars): New function.
5387         (gdb_init): Call init_gdb_version_vars.
5388
5389 2019-03-29  Tom Tromey  <tromey@adacore.com>
5390
5391         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5392         help text.  Remove dead code.
5393
5394 2019-03-29  Keith Seitz  <keiths@redhat.com>
5395
5396         From Siddhesh Poyarekar:
5397         * f-lang.h (f77_get_upperbound): Return LONGEST.
5398         (f77_get_lowerbound): Likewise.
5399         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5400         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5401         print them.
5402         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5403         plongest to format print it.
5404         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5405         (f77_get_upperbound): Likewise.
5406         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5407         LOWER_BOUND to LONGEST.
5408         (f77_create_arrayprint_offset_tbl): Likewise.
5409
5410 2019-03-29  Keith Seitz  <keiths@redhat.com>
5411
5412         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5413         %s/pulongest for TYPE_LENGTH instead of %d in format
5414         strings.
5415         * ada-typerint.c (ada_print_type): Likewise.
5416         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5417         * compile/compile-c-support.c (generate_register_struct): Likewise.
5418         * gdbtypes.c (recursive_dump_type): Likewise.
5419         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5420         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5421         instead of %d in format strings.
5422         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5423         to std::min to ULONGEST.
5424         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5425         instead of %d in format strings.
5426         * tracepoint.c (info_scope_command): Likewise.
5427         * typeprint.c (print_offset_data::update)
5428         (print_offset_data::finish): Likewise.
5429         * xtensa-tdep.c (xtensa_store_return_value)
5430         (xtensa_push_dummy_call): Likewise.
5431
5432 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5433
5434         * windows-nat.c (display_selector): Fixed format specifications
5435         for 64-bit Cygwin.
5436
5437 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5438
5439         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5440
5441 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5442
5443         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5444         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5445         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5446         (nios2_linux_init_abi): Install it.
5447
5448 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5449
5450         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5451
5452 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5453
5454         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5455
5456 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5457             Tom Tromey  <tromey@adacore.com>
5458
5459         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5460
5461 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5462
5463         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5464         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5465         method to compute the bounds of range types. Also print "[evaluated]"
5466         if the bounds' values come from a dynamic evaluation.
5467
5468 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5469
5470         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5471         whitespace when pretty printing is on.
5472
5473 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5474
5475         * ppc-linux-nat.c: Add include.
5476
5477 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5478
5479         * NEWS: Mention AArch64 Pointer Authentication.
5480
5481 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5482
5483         * arm-linux-nat.c: Add include.
5484
5485 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5486
5487         * source-cache.c (source_cache::get_source_lines): Re-read
5488         fullname after calling open_source_file.
5489
5490 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5491
5492         * NEWS: Mention TLS support for FreeBSD.
5493
5494 2019-03-25  Tom Tromey  <tromey@adacore.com>
5495
5496         * minsyms.c (BUNCH_SIZE): Update comment.
5497         (~minimal_symbol_reader): Remove old comment.
5498         (compact_minimal_symbols): Update comment.
5499         (minimal_symbol_reader::install): Remove old comment.  Update
5500         other comments.
5501
5502 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5503
5504         * s390-linux-nat.c: Add include.
5505
5506 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5507
5508         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5509         Call linux_get_hwcap.
5510         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5511         Likewise.
5512         (aarch64_linux_get_hwcap): Remove function.
5513         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5514         declaration.
5515         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5516         linux_get_hwcap.
5517         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5518         * linux-tdep.c (linux_get_hwcap): Add function.
5519         (linux_get_hwcap2): Likewise.
5520         * linux-tdep.h (linux_get_hwcap): Add declaration.
5521         (linux_get_hwcap2): Likewise.
5522         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5523         (ppc_linux_get_hwcap2): Likewise.
5524         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5525         linux_get_hwcap.
5526         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5527         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5528         (ppc_linux_nat_target::read_description): Likewise.
5529         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5530         * s390-linux-nat.c: Likewise.
5531         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5532
5533 2019-03-24  Tom Tromey  <tom@tromey.com>
5534
5535         * ada-lang.c (standard_lookup): Simplify initialization.
5536         (ada_lookup_symbol_nonlocal): Simplify return.
5537         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5538         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5539         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5540         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5541         initialization.
5542         * solib.c (solib_global_lookup): Simplify.
5543         * symtab.c (null_block_symbol): Remove.
5544         (symbol_cache_lookup): Simplify returns.
5545         (lookup_language_this): Simplify returns.
5546         (lookup_symbol_aux): Simplify return.
5547         (lookup_local_symbol): Simplify returns.
5548         (lookup_global_symbol_from_objfile): Simplify return.
5549         (lookup_symbol_in_objfile_symtabs)
5550         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5551         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5552         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5553         * cp-namespace.c (cp_lookup_bare_symbol)
5554         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5555         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5556         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5557         (cp_lookup_symbol_via_imports): Simplify initialization.
5558         (find_symbol_in_baseclass): Likewise.
5559         * symtab.h (null_block_symbol): Remove.
5560         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5561         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5562         (d_lookup_symbol_module): Likewise.
5563         (find_symbol_in_baseclass): Simplify initialization.
5564
5565 2019-03-24  Tom Tromey  <tom@tromey.com>
5566
5567         * expression.h: Don't include symtab.h.
5568         (struct block): Forward declare.
5569
5570 2019-03-24  Tom Tromey  <tom@tromey.com>
5571
5572         * c-exp.y (typebase): Remove casts.
5573         * gdbtypes.c (lookup_unsigned_typename, )
5574         (lookup_signed_typename): Remove cast.
5575         * eval.c (parse_to_comma_and_eval): Remove cast.
5576         * parse.c (write_dollar_variable): Remove cast.
5577         * block.h (struct block) <superblock>: Now const.
5578         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5579         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5580         (map_block): Make "block" const.
5581         * symfile.h (struct quick_symbol_functions)
5582         <map_matching_symbols>: Constify block argument to "callback".
5583         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5584         const.
5585         (find_pc_sect_compunit_symtab): Make "b" const.
5586         (find_symbol_at_address): Likewise.
5587         (search_symbols): Likewise.
5588         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5589         (dw2_debug_names_lookup_symbol): Likewise.
5590         (dw2_map_matching_symbols): Update.
5591         * p-valprint.c (pascal_val_print): Remove "block".
5592         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5593         (aux_add_nonlocal_symbols): Make "block" const.
5594         (resolve_subexp): Remove cast.
5595         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5596         const.
5597         (iterate_over_file_blocks): Likewise.
5598         * f-exp.y (%union) <bval>: Remove.
5599         * coffread.c (patch_opaque_types): Make "b" const.
5600         * spu-tdep.c (spu_catch_start): Make "block" const.
5601         * c-valprint.c (print_unpacked_pointer): Remove "block".
5602         * symmisc.c (dump_symtab_1): Make "b" const.
5603         (block_depth): Make "block" const.
5604         * d-exp.y (%union) <bval>: Remove.
5605         * cp-support.h (cp_lookup_rtti_type): Update.
5606         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5607         * psymtab.c (psym_lookup_symbol): Make "block" const.
5608         (maintenance_check_psymtabs): Make "b" const.
5609         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5610         (enumerate_locals, enumerate_args): Update.
5611         * python/py-symtab.c (stpy_global_block): Make "block" const.
5612         (stpy_static_block): Likewise.
5613         * inline-frame.c (block_starting_point_at): Make "new_block"
5614         const.
5615         * block.c (find_block_in_blockvector): Make return type const.
5616         (blockvector_for_pc_sect): Make "b" const.
5617         (find_block_in_blockvector): Make "b" const.
5618
5619 2019-03-23  Tom Tromey  <tom@tromey.com>
5620
5621         * varobj.c (varobj_create): Update.
5622         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5623         * printcmd.c (display_command, do_one_display): Don't reset
5624         innermost_block.
5625         * parser-defs.h (enum innermost_block_tracker_type): Move to
5626         expression.h.
5627         (innermost_block): Update comment.
5628         * parse.c (parse_exp_1): Add tracker_types parameter.
5629         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5630         tracker_types parameter.  Reset innermost_block.
5631         (parse_exp_in_context): Remove.
5632         (parse_expression_for_completion): Update.
5633         * objfiles.c (~objfile): Don't reset expression_context_block or
5634         innermost_block.
5635         * expression.h (enum innermost_block_tracker_type): Move from
5636         parser-defs.h.
5637         (parse_exp_1): Add tracker_types parameter.
5638         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5639         reset innermost_block.
5640
5641 2019-03-23  Tom Tromey  <tom@tromey.com>
5642
5643         * objfiles.h: Include bcache.h.
5644
5645 2019-03-23  Tom Tromey  <tom@tromey.com>
5646
5647         * linespec.c (get_current_search_block): Use
5648         scoped_restore_current_language.
5649         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5650
5651 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5652             Jiong Wang  <jiong.wang@arm.com>
5653
5654         * aarch64-linux-tdep.c
5655         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5656         section.
5657         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5658
5659 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5660             Jiong Wang  <jiong.wang@arm.com>
5661
5662         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5663         instructions.
5664         (aarch64_analyze_prologue_test): Add PACIASP test.
5665         (aarch64_prologue_prev_register): Unmask PC value.
5666
5667 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5668             Jiong Wang  <jiong.wang@arm.com>
5669
5670         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5671         (aarch64_dwarf2_prev_register): Unmask PC value.
5672         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5673         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5674         DW_CFA_AARCH64_negate_ra_state.
5675         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5676
5677 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5678             Jiong Wang  <jiong.wang@arm.com>
5679
5680         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5681         registers.
5682         (aarch64_pseudo_register_name): Likewise.
5683         (aarch64_pseudo_register_type): Likewise.
5684         (aarch64_pseudo_register_reggroup_p): Likewise.
5685         (aarch64_gdbarch_init): Add pauth registers.
5686         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5687         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5688         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5689         (struct gdbarch_tdep): Add regnum for ra_state.
5690
5691 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5692             Jiong Wang  <jiong.wang@arm.com>
5693
5694         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5695
5696 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5697             Jiong Wang  <jiong.wang@arm.com>
5698
5699         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5700         function.
5701         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5702         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5703         (aarch64_gdbarch_init): Add puth registers.
5704         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5705         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5706         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5707
5708 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5709             Jiong Wang  <jiong.wang@arm.com>
5710
5711         * aarch64-linux-nat.c
5712         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5713         * aarch64-linux-tdep.c
5714         (aarch64_linux_core_read_description): Likewise.
5715         (aarch64_linux_get_hwcap): New function.
5716         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5717         (aarch64_linux_get_hwcap): New declaration.
5718
5719 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5720             Jiong Wang  <jiong.wang@arm.com>
5721
5722         * aarch64-linux-nat.c
5723         (aarch64_linux_nat_target::read_description): Add pauth param.
5724         * aarch64-linux-tdep.c
5725         (aarch64_linux_core_read_description): Likewise.
5726         * aarch64-tdep.c (struct target_desc): Add in pauth.
5727         (aarch64_read_description): Add pauth param.
5728         (aarch64_gdbarch_init): Likewise.
5729         * aarch64-tdep.h (aarch64_read_description): Likewise.
5730         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5731         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5732         * features/Makefile: Add new files.
5733         * features/aarch64-pauth.c: New file.
5734         * features/aarch64-pauth.xml: New file.
5735
5736 2019-03-20  Tom Tromey  <tromey@adacore.com>
5737
5738         * infrun.c (handle_inferior_event): Rename from
5739         handle_inferior_event_1.  Create a scoped_value_mark.
5740         (handle_inferior_event): Remove.
5741
5742 2019-03-19  Tom Tromey  <tromey@adacore.com>
5743
5744         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5745         * infrun.h (print_stop_event): Add "displays" parameter.
5746         * infrun.c (print_stop_event): Add "displays" parameter.
5747
5748 2019-03-19  Pedro Alves  <palves@redhat.com>
5749
5750         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5751         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5752         to -1.  Fix TABs vs spaces.
5753         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5754         * tui/tui-out.h (tui_ui_out) Add intro comments.
5755         <m_line, m_start_of_line>: In-class initialize, and add describing
5756         comment.
5757
5758 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5759
5760         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5761         variable names.
5762         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5763
5764 2019-03-18  Pedro Alves  <palves@redhat.com>
5765             Eli Zaretskii <eliz@gnu.org>
5766
5767         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5768         m_line and m_start_of_line.
5769
5770 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5771
5772         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5773         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5774         it returns a newline.  This fixes a regression in TU mode, whereby
5775         the next line is output on the same screen line as the user input.
5776
5777 2019-03-18  Tom Tromey  <tromey@adacore.com>
5778
5779         * minsyms.c (minimal_symbol_reader::install): Remove call to
5780         obstack_blank.
5781
5782 2019-03-18  Pedro Alves  <palves@redhat.com>
5783
5784         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5785         New globals.
5786         (apply_style): New, factored out from ...
5787         (apply_ansi_escape): ... this.  Handle reverse video mode.
5788         (tui_set_reverse_mode): New function.
5789         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5790         * tui/tui-winsource.c (tui_show_source_line): Use
5791         tui_set_reverse_mode instead of setting A_STANDOUT.
5792         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5793         New setter methods.
5794
5795 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5796
5797         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5798         Handle tabs.
5799
5800 2019-03-18  Tom Tromey  <tromey@adacore.com>
5801
5802         * ada-lang.c (empty_array): Add "high" parameter.
5803         (ada_evaluate_subexp): Update.
5804
5805 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5806
5807         * unittests/string_view-selftests.c: Define
5808         _initialize_string_view_selftests unconditionally.
5809
5810 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5811
5812         PR gdb/24350
5813         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5814
5815 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5816
5817         PR gdb/24351
5818         * windows-nat.c (display_selector): Fix format specifiers.
5819
5820 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5821
5822         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5823         tui_refill_source_window instead of tui_refresh_win, to update the
5824         current execution line.  This fixes redisplay of the current line
5825         when stepping through the code with "next" or "step".
5826
5827 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5828
5829         * source-cache.c (source_cache::get_source_lines): Call
5830         find_source_lines to initialize s->nlines.  This fixes vertical
5831         scrolling of TUI source window when the DOWN arrow is pressed.
5832
5833 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5834
5835         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5836         linux-thread-db.c (_initialize_thread_db): Likewise.
5837
5838 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5839
5840         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5841         wclrtoeol in tui_show_source_line".  This reverts changes made in
5842         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5843
5844 2019-03-15  Tom Tromey  <tom@tromey.com>
5845
5846         * symtab.h (struct minimal_symbol): Derive from
5847         general_symbol_info.
5848         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5849         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5850         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5851         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5852         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5853         (MSYMBOL_SEARCH_NAME): Update.
5854         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5855         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5856         * minsyms.c (minimal_symbol_reader::record_full): Update.
5857
5858 2019-03-15  Tom Tromey  <tom@tromey.com>
5859
5860         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5861
5862 2019-03-15  Tom Tromey  <tom@tromey.com>
5863
5864         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5865         unique_xmalloc_ptr.
5866         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5867         Update.
5868         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5869         (build_minimal_symbol_hash_tables)
5870         (minimal_symbol_reader::install): Update.
5871
5872 2019-03-15  Tom Tromey  <tom@tromey.com>
5873
5874         * symtab.c (create_demangled_names_hash): Update.
5875         (symbol_set_names): Update.
5876         * objfiles.h (struct objfile_per_bfd_storage)
5877         <demangled_names_hash>: Now an htab_up.
5878         * objfiles.c (objfile_per_bfd_storage): Simplify.
5879
5880 2019-03-15  Tom Tromey  <tom@tromey.com>
5881
5882         * objfiles.h (struct objfile_per_bfd_storage): Declare
5883         destructor.
5884         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5885         New.
5886         (get_objfile_bfd_data): Use new.  Don't initialize
5887         language_of_main.
5888         (free_objfile_per_bfd_storage): Remove.
5889         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5890
5891 2019-03-15  Tom Tromey  <tom@tromey.com>
5892
5893         * symfile.c (reread_symbols): Update.
5894         * objfiles.c (objfile::objfile): Update.
5895         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5896         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5897         comment.
5898         (minimal_symbol_reader::install): Update.
5899         (terminate_minimal_symbol_table): Remove.
5900         * jit.c (jit_object_close_impl): Update.
5901
5902 2019-03-15  Tom Tromey  <tom@tromey.com>
5903
5904         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5905         initializations.
5906
5907 2019-03-15  Tom Tromey  <tom@tromey.com>
5908
5909         * objfiles.h (struct objfile_per_bfd_storage)
5910         <demangled_hash_languages>: Now a bitset.
5911         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5912         (lookup_minimal_symbol): Update.
5913
5914 2019-03-15  Tom Tromey  <tom@tromey.com>
5915
5916         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5917         Don't return the symbol.
5918         * coffread.c (record_minimal_symbol): Use record_full.
5919
5920 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5921
5922         The MS-Windows port of ncurses fails to switch to a color pair if
5923         one or both of the colors are the implicit default colors.  This
5924         change records the default colors when TUI is initialized, and
5925         then specifies them explicitly when a color pair uses the default
5926         colors.  This allows color styling in TUI mode on MS-Windows.
5927
5928         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5929         ncurses_norm_attr.
5930         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5931         colors in ncurses_norm_attr.
5932         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5933         "none", replace it with the default color recorded in
5934         ncurses_norm_attr.
5935
5936 2019-03-14  Tom Tromey  <tromey@adacore.com>
5937
5938         * source-cache.h (class source_cache) <get_source_lines>: Return
5939         std::string.
5940         * source-cache.c (source_cache::extract_lines): Handle case where
5941         first_pos==npos.  Return std::string.
5942         (source_cache::get_source_lines): Update.
5943
5944 2019-03-14  Tom Tromey  <tromey@adacore.com>
5945
5946         * NEWS: Add item for "style sources" commands.
5947         * source-cache.c (source_cache::get_source_lines): Check
5948         source_styling.
5949         * cli/cli-style.c (source_styling): New global.
5950         (_initialize_cli_style): Add "style sources" commands.
5951         (show_style_sources): New function.
5952         * cli/cli-style.h (source_styling): Declare.
5953
5954 2019-03-14  Pedro Alves  <palves@redhat.com>
5955             Tom Tromey  <tromey@adacore.com>
5956
5957         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5958         * tui/tui-winsource.c (tui_refill_source_window): New function,
5959         from...
5960         (tui_horizontal_source_scroll): ... here.  Move some logic.
5961         * cli/cli-style.c (set_style_enabled): Notify new observable.
5962         * tui/tui-hooks.c (tui_redisplay_source): New function.
5963         (tui_attach_detach_observers): Attach or detach
5964         tui_redisplay_source.
5965         * observable.h (source_styling_changed): New observable.
5966         * observable.c: Define source_styling_changed observable.
5967
5968 2019-03-13  Tom Tromey  <tromey@adacore.com>
5969
5970         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5971         (i386_gnu_nat_target::store_registers): Update.
5972         * target-debug.h (target_debug_print_std_string): New macro.
5973         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5974         * windows-tdep.c (display_one_tib): Update.
5975         * tui/tui-stack.c (tui_make_status_line): Update.
5976         * top.c (print_inferior_quit_action): Update.
5977         * thread.c (thr_try_catch_cmd): Update.
5978         (add_thread_with_info): Update.
5979         (thread_target_id_str): Update.
5980         (thr_try_catch_cmd): Update.
5981         (thread_command): Update.
5982         (thread_find_command): Update.
5983         * record-btrace.c (record_btrace_target::info_record)
5984         (record_btrace_resume_thread, record_btrace_target::resume)
5985         (record_btrace_cancel_resume, record_btrace_step_thread)
5986         (record_btrace_target::wait, record_btrace_target::wait)
5987         (record_btrace_target::wait, record_btrace_target::stop): Update.
5988         * progspace.c (print_program_space): Update.
5989         * process-stratum-target.c
5990         (process_stratum_target::thread_address_space): Update.
5991         * linux-fork.c (linux_fork_mourn_inferior)
5992         (detach_checkpoint_command, info_checkpoints_command)
5993         (linux_fork_context): Update.
5994         (linux_fork_detach): Update.
5995         (class scoped_switch_fork_info): Update.
5996         (delete_checkpoint_command): Update.
5997         * infrun.c (follow_fork_inferior): Update.
5998         (follow_fork_inferior): Update.
5999         (proceed_after_vfork_done): Update.
6000         (handle_vfork_child_exec_or_exit): Update.
6001         (follow_exec): Update.
6002         (displaced_step_prepare_throw): Update.
6003         (displaced_step_restore): Update.
6004         (start_step_over): Update.
6005         (resume_1): Update.
6006         (clear_proceed_status_thread): Update.
6007         (proceed): Update.
6008         (print_target_wait_results): Update.
6009         (do_target_wait): Update.
6010         (context_switch): Update.
6011         (stop_all_threads): Update.
6012         (restart_threads): Update.
6013         (finish_step_over): Update.
6014         (handle_signal_stop): Update.
6015         (switch_back_to_stepped_thread): Update.
6016         (keep_going_pass_signal): Update.
6017         (print_exited_reason): Update.
6018         (normal_stop): Update.
6019         * inferior.c (inferior_pid_to_str): Change return type.
6020         (print_selected_inferior): Update.
6021         (add_inferior): Update.
6022         (detach_inferior): Update.
6023         * dummy-frame.c (fprint_dummy_frames): Update.
6024         * dcache.c (dcache_info_1): Update.
6025         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6026         (btrace_fetch, btrace_clear): Update.
6027         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6028         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6029         type.
6030         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6031         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6032         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6033         * gdbarch.c, gdbarch.h: Rebuild.
6034         * gdbarch.sh (core_pid_to_str): Change return type.
6035         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6036         return type.
6037         (windows_nat_target::pid_to_str): Change return type.
6038         (windows_delete_thread): Update.
6039         (windows_nat_target::attach): Update.
6040         (windows_nat_target::files_info): Update.
6041         * target-delegates.c: Rebuild.
6042         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6043         return type.
6044         (sol_thread_target::pid_to_str): Change return type.
6045         * remote.c (class remote_target) <pid_to_str>: Change return
6046         type.
6047         (remote_target::pid_to_str): Change return type.
6048         (extended_remote_target::attach, remote_target::remote_stop_ns)
6049         (remote_target::remote_notif_remove_queued_reply)
6050         (remote_target::push_stop_reply, remote_target::disable_btrace):
6051         Update.
6052         (extended_remote_target::attach): Update.
6053         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6054         type.
6055         (gdbsim_target::pid_to_str): Change return type.
6056         * ravenscar-thread.c (struct ravenscar_thread_target)
6057         <pid_to_str>: Change return type.
6058         (ravenscar_thread_target::pid_to_str): Change return type.
6059         * procfs.c (class procfs_target) <pid_to_str>: Change return
6060         type.
6061         (procfs_target::pid_to_str): Change return type.
6062         (procfs_target::attach): Update.
6063         (procfs_target::detach): Update.
6064         (procfs_target::fetch_registers): Update.
6065         (procfs_target::store_registers): Update.
6066         (procfs_target::wait): Update.
6067         (procfs_target::files_info): Update.
6068         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6069         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6070         return type.
6071         (nto_procfs_target::pid_to_str): Change return type.
6072         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6073         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6074         return type.
6075         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6076         (exit_lwp): Update.
6077         (attach_proc_task_lwp_callback, get_detach_signal)
6078         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6079         (linux_nat_target::resume, wait_lwp, stop_callback)
6080         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6081         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6082         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6083         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6084         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6085         type.
6086         (inf_ptrace_target::attach): Update.
6087         (inf_ptrace_target::files_info): Update.
6088         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6089         type.
6090         (go32_nat_target::pid_to_str): Change return type.
6091         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6092         (gnu_nat_target::wait): Update.
6093         (gnu_nat_target::wait): Update.
6094         (gnu_nat_target::resume): Update.
6095         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6096         (fbsd_nat_target::wait): Update.
6097         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6098         type.
6099         (darwin_nat_target::attach): Update.
6100         * corelow.c (class core_target) <pid_to_str>: Change return type.
6101         (core_target::pid_to_str): Change return type.
6102         * target.c (normal_pid_to_str): Change return type.
6103         (default_pid_to_str): Likewise.
6104         (target_pid_to_str): Change return type.
6105         (target_translate_tls_address): Update.
6106         (target_announce_detach): Update.
6107         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6108         return type.
6109         (bsd_uthread_target::pid_to_str): Change return type.
6110         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6111         type.
6112         (bsd_kvm_target::pid_to_str): Change return type.
6113         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6114         return type.
6115         (aix_thread_target::pid_to_str): Change return type.
6116         * target.h (struct target_ops) <pid_to_str>: Change return type.
6117         (target_pid_to_str, normal_pid_to_str): Likewise.
6118         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6119         type.
6120         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6121         type.
6122         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6123         return type.
6124         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6125         type.
6126         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6127         type.
6128         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6129         return type.
6130
6131 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6132
6133         * NEWS: Mention that the new default MI version is 3.  Mention
6134         changes to the output of commands and events that deal with
6135         multi-location breakpoints.
6136         * breakpoint.c: Include "mi/mi-out.h".
6137         (print_one_breakpoint): Change output syntax if using MI version
6138         >= 3.
6139         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6140         New.
6141         (mi_multi_location_breakpoint_output_fixed): New.
6142         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6143         (mi_cmd_fix_multi_location_breakpoint_output): New.
6144         (mi_multi_location_breakpoint_output_fixed): New.
6145         * mi/mi-cmds.c (mi_cmds): Register command
6146         -fix-multi-location-breakpoint-output.
6147         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6148         interpreter "mi".
6149
6150 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6151
6152         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6153         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6154         instantiate mi_ui_out based on interpreter name.
6155         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6156         * mi/mi-main.c (mi_load_progress): Likewise.
6157
6158 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6159
6160         * NEWS: Combine separate "New targets" sections for 8.3.
6161
6162 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6163
6164         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6165         (ppcfbsd_init_abi): Install gdbarch
6166         "fetch_tls_load_module_address" and "get_thread_local_address"
6167         methods.
6168
6169 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6170
6171         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6172         (riscv_fbsd_init_abi): Install gdbarch
6173         "fetch_tls_load_module_address" and "get_thread_local_address"
6174         methods.
6175
6176 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6177
6178         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6179         (i386fbsd_init_abi): Install gdbarch
6180         "fetch_tls_load_module_address" and "get_thread_local_address"
6181         methods.
6182
6183 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6184
6185         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6186         (amd64fbsd_init_abi): Install gdbarch
6187         "fetch_tls_load_module_address" and "get_thread_local_address"
6188         methods.
6189
6190 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6191
6192         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6193         (struct fbsd_pspace_data): New type.
6194         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6195         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6196         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6197         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6198         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6199
6200 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6201
6202         * gdbtypes.c (lookup_struct_elt): New function.
6203         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6204         * gdbtypes.h (struct struct_elt): New type.
6205         (lookup_struct_elt): New prototype.
6206
6207 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6208
6209         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6210         remove disabled code block.
6211
6212 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6213
6214         * gdbarch.sh (get_thread_local_address): New method.
6215         * gdbarch.h, gdbarch.c: Regenerate.
6216         * target.c (target_translate_tls_address): Use
6217         gdbarch_get_thread_local_address if present instead of
6218         target::get_thread_local_address.
6219
6220 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6221
6222         * target.h (target::get_thread_local_address): Update comment.
6223
6224 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6225
6226         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6227         objfile->separate_debug_objfile_backlink if not NULL.
6228
6229 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6230
6231         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6232         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6233         (amd64bsd_store_inferior_registers): Likewise.
6234         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6235         Enable segment base registers.
6236         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6237         PT_GETFSBASE and PT_GETGSBASE.
6238         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6239         PT_SETGSBASE.
6240         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6241         segment base registers.
6242         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6243
6244 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6245
6246         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6247         Update calls to i386_target_description to add 'segments'
6248         parameter.
6249         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6250         add segment base registers.
6251         * arch/i386.c (i386_create_target_description): Add 'segments'
6252         parameter to enable segment base registers.
6253         * arch/i386.h (i386_create_target_description): Likewise.
6254         * features/i386/32bit-segments.xml: New file.
6255         * features/i386/32bit-segments.c: Generate.
6256         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6257         call to i386_target_description to add 'segments' parameter.
6258         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6259         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6260         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6261         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6262         if feature is present.
6263         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6264         Add 'segments' parameter to call to i386_target_description.
6265         (i386_target_description): Add 'segments' parameter to enable
6266         segment base registers.
6267         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6268         to call to i386_target_description.
6269         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6270         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6271         Define I386_NUM_REGS.
6272         (i386_target_description): Add 'segments' parameter to enable
6273         segment base registers.
6274
6275 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6276
6277         PR/24325
6278         * source-cache.c: #undef open and close, to avoid unresolved
6279         externals during linking.
6280
6281 2019-03-12  Tom Tromey  <tromey@adacore.com>
6282
6283         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6284         const.  Add initializers.
6285         (_initialize_remote): Don't initialize ptid globals.
6286
6287 2019-03-12  Pedro Alves  <palves@redhat.com>
6288
6289         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6290
6291 2019-03-12  Pedro Alves  <palves@redhat.com>
6292
6293         * cp-name-parser.y (main): Remove unused 'len' variable.
6294
6295 2019-03-12  Tom Tromey  <tromey@adacore.com>
6296
6297         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6298         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6299
6300 2019-03-12  Tom Tromey  <tromey@adacore.com>
6301
6302         * linux-nat.c (iterate_over_lwps): Update.
6303         (stop_callback): Remove parameter.
6304         (stop_wait_callback, detach_callback, resume_set_callback)
6305         (select_singlestep_lwp_callback, set_ignore_sigint)
6306         (status_callback, resumed_callback, resume_clear_callback)
6307         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6308         data parameter.
6309         (linux_nat_target::detach, linux_nat_target::resume)
6310         (linux_stop_and_wait_all_lwps, select_event_lwp)
6311         (linux_nat_filter_event, linux_nat_wait_1)
6312         (linux_nat_target::kill, linux_nat_target::stop)
6313         (linux_nat_target::stop): Update.
6314         (linux_nat_resume_callback): Change type.
6315         (resume_stopped_resumed_lwps, count_events_callback)
6316         (select_event_lwp_callback): Likewise.
6317         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6318         * arm-linux-nat.c (struct update_registers_data): Remove.
6319         (update_registers_callback): Change type.
6320         (arm_linux_insert_hw_breakpoint1): Update.
6321         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6322         parameter.
6323         (x86_linux_dr_set_addr): Update.
6324         (x86_linux_dr_set_control): Update.
6325         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6326         (iterate_over_lwps): Use gdb::function_view.
6327         * nat/aarch64-linux-hw-point.c (struct
6328         aarch64_dr_update_callback_param): Remove.
6329         (debug_reg_change_callback): Change type.
6330         (aarch64_notify_debug_reg_change): Update.
6331         * s390-linux-nat.c (s390_refresh_per_info): Update.
6332
6333 2019-03-11  Tom Tromey  <tromey@adacore.com>
6334
6335         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6336         redundant assignment to "this_cu".
6337
6338 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6339
6340         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6341
6342 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6343
6344         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6345         from...
6346         (rank_one_type): ... this.
6347
6348 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6349
6350         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6351         from...
6352         (rank_one_type): ... this.
6353
6354 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6355
6356         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6357         from...
6358         (rank_one_type): ... this.
6359
6360 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6361
6362         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6363         from...
6364         (rank_one_type): ... this.
6365
6366 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6367
6368         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6369         from...
6370         (rank_one_type): ... this.
6371
6372 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6373
6374         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6375         from...
6376         (rank_one_type): ... this.
6377
6378 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6379
6380         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6381         from...
6382         (rank_one_type): ... this.
6383
6384 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6385
6386         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6387         from...
6388         (rank_one_type): ... this.
6389
6390 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6391
6392         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6393         from...
6394         (rank_one_type): ... this.
6395
6396 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6397
6398         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6399         from...
6400         (rank_one_type): ... this.
6401
6402 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6403
6404         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6405         from...
6406         (rank_one_type): ... this.
6407
6408 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6409
6410         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6411         from...
6412         (rank_one_type): ... this.
6413
6414 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6415
6416         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6417         inferior-events' shows the example events.
6418
6419 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6420
6421         Support styling on native MS-Windows console
6422
6423         PR/24315
6424         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6425         on MS-Windows if $TERM is not defined.
6426
6427         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6428
6429         * posix-hdep.c (gdb_console_fputs):
6430         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6431         functions.
6432         * ui-file.h (gdb_console_fputs): Add prototype.
6433
6434         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6435         back to fputs only if the former returns zero.
6436
6437 2019-03-07  Tom Tromey  <tom@tromey.com>
6438
6439         * symmisc.c (print_symbol_bcache_statistics): Update.
6440         (print_objfile_statistics): Update.
6441         * symfile.c (allocate_symtab): Update.
6442         * stabsread.c: Don't include bcache.h.
6443         * psymtab.h (struct psymbol_bcache): Don't declare.
6444         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6445         (psymbol_bcache_init, psymbol_bcache_free)
6446         (psymbol_bcache_get_bcache): Don't declare.
6447         * psymtab.c (struct psymbol_bcache): Remove.
6448         (psymtab_storage::psymtab_storage): Update.
6449         (psymtab_storage::~psymtab_storage): Update.
6450         (psymbol_bcache_init, psymbol_bcache_free)
6451         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6452         (add_psymbol_to_bcache): Update.
6453         (allocate_psymtab): Update.
6454         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6455         macro_cache>: No longer pointers.
6456         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6457         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6458         * macrotab.c (macro_bcache): Update.
6459         * macroexp.c: Don't include bcache.h.
6460         * gdbtypes.c (check_types_worklist): Update.
6461         (types_deeply_equal): Remove TRY/CATCH.  Update.
6462         * elfread.c (elf_symtab_read): Update.
6463         * dwarf2read.c: Don't include bcache.h.
6464         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6465         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6466         (print_bcache_statistics, bcache_memory_used): Don't declare.
6467         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6468         methods.  Rename all data members.
6469         * bcache.c (struct bcache): Move to bcache.h.
6470         (bcache::expand_hash_table): Rename from expand_hash_table.
6471         (bcache): Remove.
6472         (bcache::insert): Rename from bcache_full.
6473         (bcache::compare): Rename from bcache_compare.
6474         (bcache_xmalloc): Remove.
6475         (bcache::~bcache): Rename from bcache_xfree.
6476         (bcache::print_statistics): Rename from print_bcache_statistics.
6477         (bcache::memory_used): Rename from bcache_memory_used.
6478
6479 2019-03-07  Pedro Alves  <palves@redhat.com>
6480
6481         * infrun.c (normal_stop): Also check for
6482         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6483
6484 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6485
6486         * f-lang.c (value_from_host_double): Moved to...
6487         * value.c (value_from_host_double): ...here.
6488         * value.h (value_from_host_double): Declare.
6489         * guile/scm-math.c (vlscm_convert_typed_number): Use
6490         value_from_host_double.
6491         (vlscm_convert_number): Likewise.
6492         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6493         * python/py-value.c (convert_value_from_python): Likewise.
6494
6495 2019-03-06  Tom Tromey  <tom@tromey.com>
6496
6497         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6498
6499 2019-03-06  Tom Tromey  <tom@tromey.com>
6500
6501         * utils.h (free_current_contents): Don't declare.
6502         * utils.c (free_current_contents): Remove.
6503
6504 2019-03-06  Tom Tromey  <tom@tromey.com>
6505
6506         * top.c (quit_force): Update.
6507         * main.c (captured_command_loop): Update.
6508         * common/new-op.c (operator new): Update.
6509         * common/common-exceptions.c (struct catcher)
6510         <save_cleanup_chain>: Remove member.
6511         (exceptions_state_mc_init): Update.
6512         (exception_try_scope_entry): Return nullptr.
6513         (exception_try_scope_exit, exception_rethrow)
6514         (throw_exception_sjlj, throw_exception_cxx): Update.
6515         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6516         (all_cleanups, do_cleanups, discard_cleanups)
6517         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6518         (restore_cleanups, restore_final_cleanups): Don't declare.
6519         (do_final_cleanups): Remove parameter.
6520         * common/cleanups.c (cleanup_chain, make_cleanup)
6521         (make_cleanup_dtor, all_cleanups, do_cleanups)
6522         (discard_my_cleanups, discard_cleanups)
6523         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6524         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6525         (null_cleanup): Remove.
6526         (do_final_cleanups): Remove parameter.
6527
6528 2019-03-06  Tom Tromey  <tom@tromey.com>
6529
6530         * remote.c (remote_target::remote_parse_stop_reply): Use
6531         unique_xmalloc_ptr.
6532
6533 2019-03-06  Tom Tromey  <tom@tromey.com>
6534
6535         * stabsread.c (struct stabs_field_info): Rename from field_info.
6536         <list, fnlist>: Add initializers.
6537         <obstack>: New member.
6538         (read_member_functions, read_struct_fields, read_baseclasses):
6539         Allocate on obstack.  Don't use cleanups.
6540         (read_one_struct_field, read_member_functions, read_struct_fields)
6541         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6542         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6543         (read_struct_type): Update.
6544
6545 2019-03-06  Tom Tromey  <tom@tromey.com>
6546
6547         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6548         * common/filestuff.h (make_cleanup_close): Don't declare.
6549         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6550         Remove.
6551
6552 2019-03-06  Tom Tromey  <tom@tromey.com>
6553
6554         * solib-aix.c: Use make_scope_exit.
6555
6556 2019-03-06  Tom Tromey  <tom@tromey.com>
6557
6558         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6559         Use make_scope_exit.
6560
6561 2019-03-06  Tom Tromey  <tom@tromey.com>
6562
6563         * solib-svr4.c (disable_probes_interface): Remove parameter.
6564         (svr4_handle_solib_event): Use make_scope_exit.
6565
6566 2019-03-06  Tom Tromey  <tom@tromey.com>
6567
6568         * remote.c (struct stop_reply_deleter): Remove.
6569         (stop_reply_up): Update.
6570         (struct stop_reply): Derive from notif_event.  Don't typedef.
6571         <regcache>: Now a std::vector.
6572         (stop_reply_xfree): Remove.
6573         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6574         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6575         (remote_target::discard_pending_stop_replies): Use delete.
6576         (remote_target::remote_parse_stop_reply): Update.
6577         (remote_target::process_stop_reply): Update.
6578         * remote-notif.h (struct notif_event): Add virtual destructor.
6579         Remove "dtr" member.
6580         (struct notif_client) <alloc_event>: Return a unique_ptr.
6581         (notif_event_xfree): Don't declare.
6582         (notif_event_up): New typedef.
6583         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6584         (notif_event_xfree, do_notif_event_xfree): Remove.
6585         (remote_notif_state_xfree): Update.
6586
6587 2019-03-06  Tom Tromey  <tom@tromey.com>
6588
6589         * infrun.c (displaced_step_clear_cleanup): Now a
6590         forward_scope_exit type.
6591         (displaced_step_prepare_throw): Update.
6592         (displaced_step_fixup): Update.
6593
6594 2019-03-06  Tom Tromey  <tom@tromey.com>
6595
6596         * inferior.h (class inferior): Update comment.
6597         * gdbthread.h (class thread_info): Update comment.
6598
6599 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6600             Tom Tromey  <tom@tromey.com>
6601
6602         * stabsread.h (struct stab_section_list): Remove.
6603         (coffstab_build_psymtabs): Update.
6604         * dbxread.c (symbuf_sections): Now a std::vector.
6605         (sect_idx): New global.
6606         (fill_symbuf): Update.
6607         (coffstab_build_psymtabs): Change type of stabsects parameter.
6608         Update.
6609         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6610         std::vector.
6611         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6612         (coff_locate_sections): Update.
6613         (coff_symfile_read): Remove cleanups.  Update.
6614         (init_stringtab): Add storage parameter.
6615         (free_stringtab, free_stringtab_cleanup): Remove.
6616         (init_lineno): Add storage parameter.
6617         (free_linetab, free_linetab_cleanup): Remove.
6618
6619 2019-03-06  Pedro Alves  <palves@redhat.com>
6620
6621         * linux-fork.c (fork_info::clobber_regs): Delete.
6622         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6623         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6624         comment.  Adjust.
6625         (scoped_switch_fork_info::scoped_switch_fork_info)
6626         (checkpoint_command, linux_fork_context): Adjust
6627         fork_save_infrun_state calls.
6628
6629 2019-03-06  Pedro Alves  <palves@redhat.com>
6630
6631         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6632         (inf_has_multiple_threads): Return 'bool' and rewrite using
6633         inferior_info::threads().
6634
6635 2019-03-06  Pedro Alves  <palves@redhat.com>
6636
6637         * linux-fork.c: Include <list>.
6638         (fork_list): Now a std::list instance.
6639         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6640         (forks_exist_p, find_last_fork): Adjust.
6641         (new_fork): Delete.
6642         (one_fork_p): New.
6643         (add_fork): Adjust.
6644         (free_fork): Delete, folded into fork_info::~fork_info().
6645         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6646         Adjust.
6647         (init_fork_list): Delete.
6648         (linux_fork_killall, linux_fork_mourn_inferior)
6649         (linux_fork_detach, info_checkpoints_command): Adjust.
6650         (_initialize_linux_fork): No longer call init_fork_list.
6651
6652 2019-03-06  Pedro Alves  <palves@redhat.com>
6653
6654         * linux-fork.c (new_fork): New, split out of ...
6655         (add_fork): ... this.  Return void.  Move "first fork" special
6656         case from here, to ...
6657         (checkpoint_command): ... here.
6658         * linux-linux.h (add_fork): Return void.
6659
6660 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6661
6662         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6663
6664 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6665             Chris January  <chris.january@arm.com>
6666             David Lecomber  <david.lecomber@arm.com>
6667
6668         * f-exp.y: New token, UNOP_INTRINSIC.
6669         (exp): New pattern using UNOP_INTRINSIC token.
6670         (f77_keywords): Add 'abs' keyword.
6671         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6672         (value_from_host_double): New function.
6673         (evaluate_subexp_f): Support UNOP_ABS.
6674
6675 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6676
6677         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6678         types.
6679
6680 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6683         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6684         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6685
6686 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6687
6688         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6689
6690 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6691             Chris January  <chris.january@arm.com>
6692
6693         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6694         * f-exp.y: Define 'KIND' token.
6695         (exp): New pattern for KIND expressions.
6696         (ptype): Handle types with a kind extension.
6697         (direct_abs_decl): Extend to spot kind extensions.
6698         (f77_keywords): Add 'kind' to the list.
6699         (push_kind_type): New function.
6700         (convert_to_kind_type): New function.
6701         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6702         * parse.c (operator_length_standard): Likewise.
6703         * parser-defs.h (enum type_pieces): Add tp_kind.
6704         * std-operator.def: Add UNOP_KIND.
6705
6706 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6707
6708         * f-exp.y (f_parse): Set yydebug.
6709
6710 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6711
6712         * f-lang.c (evaluate_subexp_f): New function.
6713         (exp_descriptor_f): New global.
6714         (f_language_defn): Use exp_descriptor_f instead of
6715         exp_descriptor_standard.
6716
6717 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6718
6719         * f-exp.y (struct token): Add comments.
6720         (dot_ops): Remove uppercase versions and the end marker.
6721         (f77_keywords): Likewise.
6722         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6723         entries in the dot_ops array are case insensitive, and use
6724         strncasecmp to compare strings.  Also some whitespace cleanup in
6725         this area.  Similar for the f77_keywords array, except entries in
6726         this list might be case sensitive.
6727
6728 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6729
6730         * f-exp.y (struct f77_boolean_val): Add comments.
6731         (boolean_values): Remove uppercase versions, and end marker.
6732         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6733         and use strncasecmp to achieve case insensitivity.  Additionally,
6734         perform whitespace cleanup around this code.
6735
6736 2019-03-06  Tom Tromey  <tromey@adacore.com>
6737
6738         * remote-sim.c (gdbsim_target_open): Use result of
6739         gdb_argv::release.
6740
6741 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6742         Dirk Schubert  <dirk.schubert@arm.com>
6743         Chris January  <chris.january@arm.com>
6744
6745         * eval.c (evaluate_subexp_standard): Call Fortran argument
6746         wrapping logic.
6747         * f-lang.c (struct value): A value which can be passed into a
6748         Fortran function call.
6749         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6750         where appropriate.
6751         (struct type): Value ready for a Fortran function call.
6752         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6753         is needed.
6754         * f-lang.h (fortran_argument_convert): Declaration.
6755         (fortran_preserve_arg_pointer): Declaration.
6756         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6757
6758 2019-03-05  Tom Tromey  <tromey@adacore.com>
6759
6760         * python/py-prettyprint.c (print_string_repr): Remove #if.
6761         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6762
6763 2019-03-05  Tom Tromey  <tromey@adacore.com>
6764
6765         * target.c (the_dummy_target): Move later.  Change type to
6766         "dummy_target".
6767         (initialize_targets): Don't initialize the_dummy_target.
6768
6769 2019-03-05  Tom Tromey  <tromey@adacore.com>
6770
6771         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6772         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6773
6774 2019-03-05  Tom Tromey  <tromey@adacore.com>
6775
6776         * windows-nat.c (windows_nat_target::attach)
6777         (windows_nat_target::detach): Don't call gdb_flush.
6778         * valprint.c (generic_val_print, val_print, val_print_string):
6779         Don't call gdb_flush.
6780         * utils.c (defaulted_query): Don't call gdb_flush.
6781         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6782         * target.c (target_announce_detach): Don't call gdb_flush.
6783         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6784         * remote.c (extended_remote_target::attach): Don't call
6785         gdb_flush.
6786         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6787         * printcmd.c (do_examine): Don't call gdb_flush.
6788         (info_display_command): Don't call gdb_flush.
6789         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6790         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6791         * memattr.c (info_mem_command): Don't call gdb_flush.
6792         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6793         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6794         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6795         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6796         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6797         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6798         (gnu_nat_target::detach): Don't call gdb_flush.
6799         * f-valprint.c (f_val_print): Don't call gdb_flush.
6800         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6801         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6802         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6803         gdb_flush.
6804         * c-valprint.c (c_val_print): Don't call gdb_flush.
6805         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6806
6807 2019-03-05  Tom Tromey  <tromey@adacore.com>
6808
6809         * varobj.c (update_dynamic_varobj_children): Update.
6810         (install_default_visualizer): Use reset, not release.
6811         * value.c (set_internalvar): Update.
6812         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6813         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6814         ATTRIBUTE_UNUSED_RESULT.
6815
6816 2019-03-05  Tom Tromey  <tromey@adacore.com>
6817
6818         * remote.c (class scoped_remote_fd) <release>: Add
6819         ATTRIBUTE_UNUSED_RESULT.
6820
6821 2019-03-05  Tom Tromey  <tromey@adacore.com>
6822
6823         * macroexp.c (struct macro_buffer) <release>: Add
6824         ATTRIBUTE_UNUSED_RESULT.
6825
6826 2019-03-05  Tom Tromey  <tromey@adacore.com>
6827
6828         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6829         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6830         ATTRIBUTE_UNUSED_RESULT.
6831
6832 2019-03-05  Tom Tromey  <tromey@adacore.com>
6833
6834         * common/scoped_fd.h (class scoped_fd) <release>: Add
6835         ATTRIBUTE_UNUSED_RESULT.
6836
6837 2019-03-05  Tom Tromey  <tromey@adacore.com>
6838
6839         * parser-defs.h (struct parser_state) <release>: Add
6840         ATTRIBUTE_UNUSED_RESULT.
6841
6842 2019-03-05  Tom Tromey  <tromey@adacore.com>
6843
6844         * utils.h (class gdb_argv) <release>: Add
6845         ATTRIBUTE_UNUSED_RESULT.
6846         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6847
6848 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6849
6850         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6851         for-loop range, to avoid compiler warnings.
6852
6853         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6854         avoid compiler warnings about unused variables.
6855
6856         * NEWS: Mention end of support for native debugging on MS-Windows
6857         before XP.
6858
6859         PR gdb/24292
6860         * common/netstuff.c:
6861         * gdbserver/gdbreplay.c
6862         * gdbserver/remote-utils.c:
6863         * ser-tcp.c:
6864         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6865         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6866         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6867         'getaddrinfo' and 'freeaddrinfo' were not available before
6868         Windows XP, and mingw.org's MinGW headers by default define
6869         _WIN32_WINNT to 0x500.
6870
6871 2019-03-01  Gary Benson <gbenson@redhat.com>
6872
6873         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6874
6875 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6876             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6877
6878         PR gdb/8527
6879         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6880         set_sigint_trap, clear_sigint_trap.
6881
6882 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6883
6884         * target.c (target_detach): Clear the regcache and the
6885         frame cache.
6886
6887 2019-02-27  Pedro Alves  <palves@redhat.com>
6888
6889         * utils.c (set_screen_size): When we cap the height/width sizes,
6890         tweak the corresponding command variable to show "unlimited":
6891
6892 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6893             Pedro Alves  <palves@redhat.com>
6894
6895         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6896         before calling rl_set_screen_size.
6897
6898 2019-02-27  Tom Tromey  <tromey@adacore.com>
6899
6900         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6901         define.
6902         * python/py-value.c: Remove Python 2.4 workaround.
6903         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6904         workaround.
6905         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6906         Python 2.4 workaround.
6907         * python/python-internal.h: Remove Python 2.4 comment.
6908         (Py_ssize_t): Don't define.
6909         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6910         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6911         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6912         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6913         * python/python.c (do_start_initialization): Remove Python 2.4
6914         workaround.
6915         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6916         (print_children): Remove Python 2.4 workaround.
6917         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6918         workaround.
6919         (CHARBUFFERPROC_NAME): Remove.
6920         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6921         Python 2.4 workaround.
6922
6923 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6924
6925         * NEWS: Note minimum Python version.
6926
6927 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6928
6929         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6930         code from these functions.  Remove corresponding ifdefs.  Use
6931         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6932         Remove gotos and target of gotos.
6933         (infpy_search_memory): Likewise.
6934
6935 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6936
6937         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6938         (hppa_gdbarch_init): Don't register deleted functions with
6939         gdbarch.
6940
6941 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6942
6943         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6944         (h8300_unwind_sp): Delete.
6945         (h8300_dummy_id): Delete.
6946         (h8300_gdbarch_init): Don't register deleted functions with
6947         gdbarch.
6948
6949 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6950
6951         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6952         (ft32_unwind_pc): Delete.
6953         (ft32_unwind_sp): Delete.
6954         (ft32_gdbarch_init): Don't register deleted functions with
6955         gdbarch.
6956
6957 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6958
6959         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6960         (frv_unwind_pc): Delete.
6961         (frv_unwind_sp): Delete.
6962         (frv_gdbarch_init): Don't register deleted functions with
6963         gdbarch.
6964
6965 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6966
6967         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6968         (riscv_unwind_pc): Delete.
6969         (riscv_unwind_sp): Delete.
6970         (riscv_gdbarch_init): Don't register deleted functions with
6971         gdbarch.
6972
6973 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6974
6975         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6976         (csky_unwind_pc): Delete.
6977         (csky_unwind_sp): Delete.
6978         (csky_gdbarch_init): Don't register deleted functions with
6979         gdbarch.
6980
6981 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6982
6983         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6984         (cris_unwind_pc): Delete.
6985         (cris_unwind_sp): Delete.
6986         (cris_gdbarch_init): Don't register deleted functions with
6987         gdbarch.
6988
6989 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6990
6991         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6992         (bfin_unwind_pc): Delete.
6993         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6994
6995 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6996
6997         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6998         (arm_unwind_pc): Delete.
6999         (arm_unwind_sp): Delete.
7000         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7001
7002 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7003
7004         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7005         (arc_unwind_pc): Delete.
7006         (arc_unwind_sp): Delete.
7007         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7008
7009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7010
7011         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7012         (alpha_unwind_pc): Delete.
7013         (alpha_gdbarch_init): Don't register deleted functions with
7014         gdbarch.
7015
7016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7017
7018         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7019         (aarch64_unwind_pc): Delete.
7020         (aarch64_unwind_sp): Delete.
7021         (aarch64_gdbarch_init): Don't register deleted functions with
7022         gdbarch.
7023
7024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7025
7026         * gdbtypes.c (type_align): Don't consider static members when
7027         computing structure alignment.
7028
7029 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7030
7031         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7032         return 0 for other types.
7033         * arch-utils.c (default_type_align): Always return 0.
7034         * gdbarch.h: Regenerate.
7035         * gdbarch.sh (type_align): Extend comment.
7036         * gdbtypes.c (type_align): Add additional comments, always call
7037         gdbarch_type_align before applying the default rules.
7038         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7039         generic code will then apply a suitable default.
7040         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7041         types, return 0 for other types.
7042
7043 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7044
7045         * NEWS: Create a new section for the next release branch.
7046         Rename the section of the current branch, now that it has
7047         been cut.
7048
7049 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7050
7051         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7052         * version.in: Bump version to 8.3.50.DATE-git.
7053
7054 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7055
7056         * aix-thread.c (ptid_cmp): Remove unused variable.
7057         (get_signaled_thread): Likewise.
7058         (store_regs_user_thread): Likewise.
7059         (store_regs_kernel_thread): Likewise.
7060         (fetch_regs_kernel_thread): Remove shadowed variable.
7061
7062 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7063
7064         * features/riscv/32bit-cpu.xml: Add register numbers.
7065         * features/riscv/32bit-fpu.c: Regenerate.
7066         * features/riscv/32bit-fpu.xml: Add register numbers.
7067         * features/riscv/64bit-cpu.xml: Add register numbers.
7068         * features/riscv/64bit-fpu.c: Regenerate.
7069         * features/riscv/64bit-fpu.xml: Add register numbers.
7070
7071 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7072
7073         * NEWS: Mention two argument form of gdb.Value constructor.
7074         * python/py-value.c (convert_buffer_and_type_to_value): New
7075         function.
7076         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7077         Add support for handling an optional second argument.  Call
7078         convert_buffer_and_type_to_value as appropriate.
7079         * python/python-internal.h (Py_buffer_deleter): New struct.
7080         (Py_buffer_up): New typedef.
7081
7082 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7083
7084         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7085         instead of releasing ownership.
7086
7087 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7088
7089         * dwarf2read.c (open_and_init_dwp_file): Call
7090         elf_numsections instead of bfd_count_sections to initialize
7091         dwp_file->num_sections.
7092
7093 2019-02-25  Tom Tromey  <tromey@adacore.com>
7094
7095         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7096
7097 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7098
7099         * gcore.in: Add '--readnever' option when invoking GDB.
7100
7101 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7102
7103         * MAINTAINERS: Update my email address.
7104
7105 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7106
7107         * build-id.c (build_id_to_debug_bfd_1): New function.
7108         (build_id_to_debug_bfd): Look for separate debug file in
7109         sysroot.
7110
7111 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7112
7113         * gdbarch.sh: Update the copyright year range that is placed into
7114         generated files.
7115
7116 2019-02-22  Keith Seitz  <keiths@redhat.com>
7117
7118         PR symtab/23853
7119         * linespec.c (create_sals_line_offset): Search for the default
7120         symtab's filename instead of its fullname.
7121
7122 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7123
7124         * NEWS: Update style defaults.
7125
7126 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7127
7128         * main.c (captured_main_1): Disable styling in batch mode.
7129
7130 2019-02-20  Tom Tromey  <tom@tromey.com>
7131
7132         * symtab.c (symtab_symbol_info): Fix typos.
7133
7134 2019-02-20  Tom Tromey  <tromey@adacore.com>
7135
7136         * findcmd.c (_initialize_mem_search): Use upper case for
7137         metasyntactic variables.
7138
7139 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7140
7141         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7142         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7143
7144 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7145
7146         * top.h (source_file_name): Change to std::string.
7147         * top.c (source_file_name): Likewise.
7148         (command_line_input): Adjust.
7149         * cli/cli-script.c (script_from_file): Adjust.
7150
7151 2019-02-19  Tom Tromey  <tromey@adacore.com>
7152
7153         * ravenscar-thread.c
7154         (ravenscar_thread_target::update_thread_list): Don't call
7155         ada_build_task_list.
7156         * ada-lang.h (ada_build_task_list): Don't declare.
7157         * ada-tasks.c (struct ada_tasks_inferior_data)
7158         <task_list_valid_p>: Now bool.
7159         (read_known_tasks, ada_task_list_changed)
7160         (ada_tasks_invalidate_inferior_data): Update.
7161         (read_known_tasks_array): Return bool.
7162         (read_known_tasks_list): Likewise.
7163         (read_known_tasks): Return void.
7164         (ada_build_task_list): Now static.
7165
7166 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7167
7168         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7169         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7170
7171 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7172
7173         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7174         variant for ada_tasks_pspace_data_handle and
7175         ada_tasks_inferior_data_handle.
7176         (ada_tasks_pspace_data_cleanup): New function.
7177         (ada_tasks_inferior_data_cleanup): New function.
7178
7179 2019-02-17  Tom Tromey  <tom@tromey.com>
7180
7181         * macrotab.h (macro_source_fullname): Return a std::string.
7182         * macrotab.c (macro_include, check_for_redefinition)
7183         (macro_undef, macro_lookup_definition, foreach_macro)
7184         (foreach_macro_in_scope): Update.
7185         (macro_source_fullname): Return a std::string.
7186         * macrocmd.c (show_pp_source_pos): Update.
7187
7188 2019-02-17  Tom Tromey  <tom@tromey.com>
7189
7190         * macrocmd.c (show_pp_source_pos): Style the file names.
7191
7192 2019-02-17  Tom Tromey  <tom@tromey.com>
7193
7194         PR tui/24197:
7195         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7196
7197 2019-02-17  Tom Tromey  <tom@tromey.com>
7198
7199         * ada-lang.c (user_select_syms): Use filtered printing.
7200         * utils.c (wrap_style): New global.
7201         (desired_style): Remove.
7202         (emit_style_escape): Add stream parameter.
7203         (set_output_style, reset_terminal_style, prompt_for_continue):
7204         Update.
7205         (flush_wrap_buffer): Only flush gdb_stdout.
7206         (wrap_here): Set wrap_style.
7207         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7208         treat escape sequences as a character.  Change when wrap buffer is
7209         flushed.
7210         (fputs_styled): Do not set the output style when the default is
7211         requested.
7212         * ui-style.h (struct ui_file_style) <is_default>: New method.
7213         * source.c (print_source_lines_base): Emit escape sequences in one
7214         piece.
7215
7216 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7217
7218         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7219         integers and enumeration types.
7220
7221 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7222
7223         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7224         instead of lookup_symbol_in_language
7225         (do_exact_match): New function.
7226         (ada_get_symbol_name_matcher): Return do_exact_match when
7227         doing a verbatim match.
7228
7229 2019-02-15  Tom Tromey  <tromey@adacore.com>
7230
7231         * ravenscar-thread.c (ravenscar_thread_target::resume)
7232         (ravenscar_thread_target::wait): Special case wildcard requests.
7233
7234 2019-02-15  Tom Tromey  <tromey@adacore.com>
7235
7236         * ravenscar-thread.c (base_ptid): Remove.
7237         (struct ravenscar_thread_target) <close>: New method.
7238         <m_base_ptid>: New member.
7239         <update_inferior_ptid, active_task, task_is_currently_active,
7240         runtime_initialized>: Declare methods.
7241         <ravenscar_thread_target>: Add constructor.
7242         (ravenscar_thread_target::task_is_currently_active)
7243         (ravenscar_thread_target::update_inferior_ptid)
7244         (ravenscar_runtime_initialized): Rename.  Now methods.
7245         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7246         (ravenscar_thread_target::update_thread_list): Update.
7247         (ravenscar_thread_target::active_task): Now method.
7248         (ravenscar_thread_target::store_registers)
7249         (ravenscar_thread_target::prepare_to_store)
7250         (ravenscar_thread_target::prepare_to_store)
7251         (ravenscar_thread_target::mourn_inferior): Update.
7252         (ravenscar_inferior_created): Use "new" to create target.
7253         (ravenscar_thread_target::get_ada_task_ptid): Update.
7254         (_initialize_ravenscar): Don't initialize base_ptid.
7255         (ravenscar_ops): Remove global.
7256
7257 2019-02-15  Tom Tromey  <tromey@adacore.com>
7258
7259         * target.h (push_target): Declare new overload.
7260         * target.c (push_target): New overload, taking an rvalue reference.
7261         * remote.c (remote_target::open_1): Use push_target overload.
7262         * corelow.c (core_target_open): Use push_target overload.
7263
7264 2019-02-15  Tom Tromey  <tromey@adacore.com>
7265
7266         * ravenscar-thread.c (is_ravenscar_task)
7267         (ravenscar_task_is_currently_active): Return bool.
7268         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7269         (_initialize_ravenscar): Remove "(void)".
7270         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7271         Return bool.
7272
7273 2019-02-15  Tom Tromey  <tromey@adacore.com>
7274
7275         * ravenscar-thread.c (ravenscar_runtime_initializer)
7276         (has_ravenscar_runtime, get_running_thread_id)
7277         (ravenscar_thread_target::resume): Fix indentation.
7278
7279 2019-02-15  Tom Tromey  <tromey@adacore.com>
7280
7281         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7282         from ravenscar_arch_ops.
7283         (sparc_ravenscar_ops::fetch_registers)
7284         (sparc_ravenscar_ops::store_registers): Now methods.
7285         (sparc_ravenscar_prepare_to_store): Remove.
7286         (sparc_ravenscar_ops): Redefine.
7287         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7288         methods and destructor.  Remove members.
7289         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7290         (ravenscar_thread_target::store_registers)
7291         (ravenscar_thread_target::prepare_to_store): Update.
7292         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7293         Remove.
7294         (struct ppc_ravenscar_powerpc_ops): Derive from
7295         ravenscar_arch_ops.
7296         (ppc_ravenscar_powerpc_ops::fetch_registers)
7297         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7298         (ppc_ravenscar_powerpc_ops): Redefine.
7299         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7300         (ppc_ravenscar_e500_ops::fetch_registers)
7301         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7302         (ppc_ravenscar_e500_ops): Redefine.
7303         * aarch64-ravenscar-thread.c
7304         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7305         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7306         (aarch64_ravenscar_fetch_registers)
7307         (aarch64_ravenscar_store_registers): Now methods.
7308         (aarch64_ravenscar_ops): Redefine.
7309
7310 2019-02-15  Tom Tromey  <tromey@adacore.com>
7311
7312         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7313         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7314         (ravenscar_thread_target::stopped_by_watchpoint)
7315         (ravenscar_thread_target::stopped_data_address)
7316         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7317
7318 2019-02-15  Tom Tromey  <tromey@adacore.com>
7319
7320         * ravenscar-thread.c: Fix some typos.
7321
7322 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7323             Tom Tromey  <tromey@adacore.com>
7324
7325         * ada-lang.c (ada_exception_sal): Change addr_string to a
7326         std::string.
7327         (create_ada_exception_catchpoint): Update.
7328
7329 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7330             Tom Tromey  <tromey@adacore.com>
7331
7332         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7333         (bp_location_ops): Remove.
7334         (base_breakpoint_allocate_location): Update.
7335         (free_bp_location): Update.
7336         * ada-lang.c (class ada_catchpoint_location)
7337         <ada_catchpoint_location>: Remove ops parameter.
7338         (ada_catchpoint_location_dtor): Remove.
7339         (ada_catchpoint_location_ops): Remove.
7340         (allocate_location_exception): Update.
7341         * breakpoint.h (struct bp_location_ops): Remove.
7342         (class bp_location) <bp_location>: Remove bp_location_ops
7343         parameter.
7344         <~bp_location>: Add destructor.
7345         <ops>: Remove.
7346
7347 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7348             Pedro Alves  <palves@redhat.com>
7349
7350         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7351         'PATH_MAX'.
7352
7353 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7354             Samuel Thibault  <samuel.thibault@gnu.org>
7355             Thomas Schwinge  <thomas@codesourcery.com>
7356
7357         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7358         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7359
7360 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7361
7362         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7363         (check_empty): Use "const char *".
7364
7365         * gnu-nat.c (gnu_nat_target::detach): Instead of
7366         'detach_inferior (pid)' call
7367         'detach_inferior (find_inferior_pid (pid))'.
7368
7369         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7370         'nat/fork-inferior.o'.
7371         * gnu-nat.c: #include "nat/fork-inferior.h".
7372
7373         * gnu-nat.c (gnu_nat_target::detach): Instead of
7374         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7375         * gnu-nat.h: #include "inf-child.h".
7376         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7377         'i386_gnu_nat_target::fetch_registers'.
7378         (gnu_store_registers): Rename/move to
7379         'i386_gnu_nat_target::store_registers'.
7380
7381         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7382         * gnu-nat.h (mach_thread_info): New function.
7383         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7384
7385         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7386
7387 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7388
7389         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7390
7391 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7392
7393         * windows-nat.c (windows_add_thread): Add new parameter
7394         "main_thread_p" with default value set to false.  Update
7395         function documentation as well as all callers.
7396         (windows_delete_thread): Likewise.
7397         (fake_create_process): Update call to windows_add_thread.
7398         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7399         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7400         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7401         call to windows_delete_thread.
7402
7403 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7404
7405         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7406
7407 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7408
7409         * symfile.c (find_separate_debug_file): Use canonical path of
7410         sysroot with child_path instead of gdb_sysroot if it is valid.
7411
7412 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7413
7414         * symfile.c (find_separate_debug_file): Use child_path to
7415         determine if an object file is under a sysroot.
7416
7417 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7418
7419         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7420         unittests/child-path-selftests.c.
7421         * common/pathstuff.c (child_path): New function.
7422         * common/pathstuff.h (child_path): New prototype.
7423         * unittests/child-path-selftests.c: New file.
7424
7425 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7426
7427         * symfile.c (find_separate_debug_file): Look for separate debug
7428         files in debug directories under the sysroot.
7429
7430 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7431
7432         * symtab.h (struct minimal_symbol data_p): New const method.
7433         (struct minimal_symbol text_p): Likewise.
7434         * symtab.c (output_source_filename): Use file name style
7435         to print file name.
7436         (print_symbol_info): Likewise.
7437         (print_msymbol_info): Use address style to print addresses.
7438         Use function name style to print executable text symbols.
7439         (expand_symtab_containing_pc): Use data_p.
7440         (find_pc_sect_compunit_symtab): Likewise.
7441
7442 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7443
7444         * breakpoint.c (describe_other_breakpoints): Use address style
7445         to print addresses.
7446         (say_where): Likewise.
7447
7448 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7449
7450         * ada-typeprint.c (print_func_type): Print function name
7451         style to print function name.
7452         * c-typeprint.c (c_print_type_1): Likewise.
7453
7454 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7455
7456         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7457         for execve.
7458
7459 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7460
7461         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7462         type_stack.
7463
7464 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7465
7466         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7467         TYPE_CODE_REF types.
7468
7469 2019-02-08  Jim Wilson  <jimw@sifive.com>
7470
7471         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7472         (riscv_linux_fregset): New.
7473         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7474
7475 2019-02-07  Tom Tromey  <tom@tromey.com>
7476
7477         * thread.c (thread_cancel_execution_command): Update.
7478         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7479         methods.
7480         (struct thread_fsm_ops): Remove.
7481         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7482         (thread_fsm_should_stop, thread_fsm_return_value)
7483         (thread_fsm_set_finished, thread_fsm_finished_p)
7484         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7485         Don't declare.
7486         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7487         * infrun.c (clear_proceed_status_thread)
7488         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7489         (print_stop_event): Update.
7490         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7491         Add constructor.
7492         (step_command_fsm_ops): Remove.
7493         (new_step_command_fsm): Remove.
7494         (step_1): Update.
7495         (step_command_fsm::should_stop): Rename from
7496         step_command_fsm_should_stop.
7497         (step_command_fsm::clean_up): Rename from
7498         step_command_fsm_clean_up.
7499         (step_command_fsm::do_async_reply_reason): Rename from
7500         step_command_fsm_async_reply_reason.
7501         (struct until_next_fsm): Inherit from thread_fsm.  Add
7502         constructor.
7503         (until_next_fsm_ops): Remove.
7504         (new_until_next_fsm): Remove.
7505         (until_next_fsm::should_stop): Rename from
7506         until_next_fsm_should_stop.
7507         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7508         (until_next_fsm::do_async_reply_reason): Rename from
7509         until_next_fsm_async_reply_reason.
7510         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7511         constructor.  Change type of breakpoint.
7512         (finish_command_fsm_ops): Remove.
7513         (new_finish_command_fsm): Remove.
7514         (finish_command_fsm::should_stop): Rename from
7515         finish_command_fsm_should_stop.
7516         (finish_command_fsm::clean_up): Rename from
7517         finish_command_fsm_clean_up.
7518         (finish_command_fsm::return_value): Rename from
7519         finish_command_fsm_return_value.
7520         (finish_command_fsm::do_async_reply_reason): Rename from
7521         finish_command_fsm_async_reply_reason.
7522         (finish_command): Update.
7523         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7524         Add constructor.
7525         (call_thread_fsm_ops): Remove.
7526         (call_thread_fsm::call_thread_fsm): Rename from
7527         new_call_thread_fsm.
7528         (call_thread_fsm::should_stop): Rename from
7529         call_thread_fsm_should_stop.
7530         (call_thread_fsm::should_notify_stop): Rename from
7531         call_thread_fsm_should_notify_stop.
7532         (run_inferior_call, call_function_by_hand_dummy): Update.
7533         * cli/cli-interp.c (should_print_stop_to_console): Update.
7534         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7535         Add constructor.  Change type of location_breakpoint,
7536         caller_breakpoint.
7537         (until_break_fsm_ops): Remove.
7538         (new_until_break_fsm): Remove.
7539         (until_break_fsm::should_stop): Rename from
7540         until_break_fsm_should_stop.
7541         (until_break_fsm::clean_up): Rename from
7542         until_break_fsm_clean_up.
7543         (until_break_fsm::do_async_reply_reason): Rename from
7544         until_break_fsm_async_reply_reason.
7545         (until_break_command): Update.
7546         * thread-fsm.c: Remove.
7547         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7548
7549 2019-02-07  Tom Tromey  <tom@tromey.com>
7550
7551         * yy-remap.h: Add include guard.
7552         * xtensa-tdep.h: Add include guard.
7553         * xcoffread.h: Rename include guard.
7554         * varobj-iter.h: Add include guard.
7555         * tui/tui.h: Rename include guard.
7556         * tui/tui-winsource.h: Rename include guard.
7557         * tui/tui-wingeneral.h: Rename include guard.
7558         * tui/tui-windata.h: Rename include guard.
7559         * tui/tui-win.h: Rename include guard.
7560         * tui/tui-stack.h: Rename include guard.
7561         * tui/tui-source.h: Rename include guard.
7562         * tui/tui-regs.h: Rename include guard.
7563         * tui/tui-out.h: Rename include guard.
7564         * tui/tui-layout.h: Rename include guard.
7565         * tui/tui-io.h: Rename include guard.
7566         * tui/tui-hooks.h: Rename include guard.
7567         * tui/tui-file.h: Rename include guard.
7568         * tui/tui-disasm.h: Rename include guard.
7569         * tui/tui-data.h: Rename include guard.
7570         * tui/tui-command.h: Rename include guard.
7571         * tic6x-tdep.h: Add include guard.
7572         * target/waitstatus.h: Rename include guard.
7573         * target/wait.h: Rename include guard.
7574         * target/target.h: Rename include guard.
7575         * target/resume.h: Rename include guard.
7576         * target-float.h: Rename include guard.
7577         * stabsread.h: Add include guard.
7578         * rs6000-tdep.h: Add include guard.
7579         * riscv-fbsd-tdep.h: Add include guard.
7580         * regformats/regdef.h: Rename include guard.
7581         * record.h: Rename include guard.
7582         * python/python.h: Rename include guard.
7583         * python/python-internal.h: Rename include guard.
7584         * python/py-stopevent.h: Rename include guard.
7585         * python/py-ref.h: Rename include guard.
7586         * python/py-record.h: Rename include guard.
7587         * python/py-record-full.h: Rename include guard.
7588         * python/py-record-btrace.h: Rename include guard.
7589         * python/py-instruction.h: Rename include guard.
7590         * python/py-events.h: Rename include guard.
7591         * python/py-event.h: Rename include guard.
7592         * procfs.h: Add include guard.
7593         * proc-utils.h: Add include guard.
7594         * p-lang.h: Add include guard.
7595         * or1k-tdep.h: Rename include guard.
7596         * observable.h: Rename include guard.
7597         * nto-tdep.h: Rename include guard.
7598         * nat/x86-linux.h: Rename include guard.
7599         * nat/x86-linux-dregs.h: Rename include guard.
7600         * nat/x86-gcc-cpuid.h: Add include guard.
7601         * nat/x86-dregs.h: Rename include guard.
7602         * nat/x86-cpuid.h: Rename include guard.
7603         * nat/ppc-linux.h: Rename include guard.
7604         * nat/mips-linux-watch.h: Rename include guard.
7605         * nat/linux-waitpid.h: Rename include guard.
7606         * nat/linux-ptrace.h: Rename include guard.
7607         * nat/linux-procfs.h: Rename include guard.
7608         * nat/linux-osdata.h: Rename include guard.
7609         * nat/linux-nat.h: Rename include guard.
7610         * nat/linux-namespaces.h: Rename include guard.
7611         * nat/linux-btrace.h: Rename include guard.
7612         * nat/glibc_thread_db.h: Rename include guard.
7613         * nat/gdb_thread_db.h: Rename include guard.
7614         * nat/gdb_ptrace.h: Rename include guard.
7615         * nat/fork-inferior.h: Rename include guard.
7616         * nat/amd64-linux-siginfo.h: Rename include guard.
7617         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7618         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7619         * nat/aarch64-linux.h: Rename include guard.
7620         * nat/aarch64-linux-hw-point.h: Rename include guard.
7621         * mn10300-tdep.h: Add include guard.
7622         * mips-linux-tdep.h: Add include guard.
7623         * mi/mi-parse.h: Rename include guard.
7624         * mi/mi-out.h: Rename include guard.
7625         * mi/mi-main.h: Rename include guard.
7626         * mi/mi-interp.h: Rename include guard.
7627         * mi/mi-getopt.h: Rename include guard.
7628         * mi/mi-console.h: Rename include guard.
7629         * mi/mi-common.h: Rename include guard.
7630         * mi/mi-cmds.h: Rename include guard.
7631         * mi/mi-cmd-break.h: Rename include guard.
7632         * m2-lang.h: Add include guard.
7633         * location.h: Rename include guard.
7634         * linux-record.h: Rename include guard.
7635         * linux-nat.h: Add include guard.
7636         * linux-fork.h: Add include guard.
7637         * i386-darwin-tdep.h: Rename include guard.
7638         * hppa-linux-offsets.h: Add include guard.
7639         * guile/guile.h: Rename include guard.
7640         * guile/guile-internal.h: Rename include guard.
7641         * gnu-nat.h: Rename include guard.
7642         * gdb-stabs.h: Rename include guard.
7643         * frv-tdep.h: Add include guard.
7644         * f-lang.h: Add include guard.
7645         * event-loop.h: Add include guard.
7646         * darwin-nat.h: Rename include guard.
7647         * cp-abi.h: Rename include guard.
7648         * config/sparc/nm-sol2.h: Rename include guard.
7649         * config/nm-nto.h: Rename include guard.
7650         * config/nm-linux.h: Add include guard.
7651         * config/i386/nm-i386gnu.h: Rename include guard.
7652         * config/djgpp/nl_types.h: Rename include guard.
7653         * config/djgpp/langinfo.h: Rename include guard.
7654         * compile/gcc-cp-plugin.h: Add include guard.
7655         * compile/gcc-c-plugin.h: Add include guard.
7656         * compile/compile.h: Rename include guard.
7657         * compile/compile-object-run.h: Rename include guard.
7658         * compile/compile-object-load.h: Rename include guard.
7659         * compile/compile-internal.h: Rename include guard.
7660         * compile/compile-cplus.h: Rename include guard.
7661         * compile/compile-c.h: Rename include guard.
7662         * common/xml-utils.h: Rename include guard.
7663         * common/x86-xstate.h: Rename include guard.
7664         * common/version.h: Rename include guard.
7665         * common/vec.h: Rename include guard.
7666         * common/tdesc.h: Rename include guard.
7667         * common/selftest.h: Rename include guard.
7668         * common/scoped_restore.h: Rename include guard.
7669         * common/scoped_mmap.h: Rename include guard.
7670         * common/scoped_fd.h: Rename include guard.
7671         * common/safe-iterator.h: Rename include guard.
7672         * common/run-time-clock.h: Rename include guard.
7673         * common/refcounted-object.h: Rename include guard.
7674         * common/queue.h: Rename include guard.
7675         * common/ptid.h: Rename include guard.
7676         * common/print-utils.h: Rename include guard.
7677         * common/preprocessor.h: Rename include guard.
7678         * common/pathstuff.h: Rename include guard.
7679         * common/observable.h: Rename include guard.
7680         * common/netstuff.h: Rename include guard.
7681         * common/job-control.h: Rename include guard.
7682         * common/host-defs.h: Rename include guard.
7683         * common/gdb_wait.h: Rename include guard.
7684         * common/gdb_vecs.h: Rename include guard.
7685         * common/gdb_unlinker.h: Rename include guard.
7686         * common/gdb_unique_ptr.h: Rename include guard.
7687         * common/gdb_tilde_expand.h: Rename include guard.
7688         * common/gdb_sys_time.h: Rename include guard.
7689         * common/gdb_string_view.h: Rename include guard.
7690         * common/gdb_splay_tree.h: Rename include guard.
7691         * common/gdb_setjmp.h: Rename include guard.
7692         * common/gdb_ref_ptr.h: Rename include guard.
7693         * common/gdb_optional.h: Rename include guard.
7694         * common/gdb_locale.h: Rename include guard.
7695         * common/gdb_assert.h: Rename include guard.
7696         * common/filtered-iterator.h: Rename include guard.
7697         * common/filestuff.h: Rename include guard.
7698         * common/fileio.h: Rename include guard.
7699         * common/environ.h: Rename include guard.
7700         * common/common-utils.h: Rename include guard.
7701         * common/common-types.h: Rename include guard.
7702         * common/common-regcache.h: Rename include guard.
7703         * common/common-inferior.h: Rename include guard.
7704         * common/common-gdbthread.h: Rename include guard.
7705         * common/common-exceptions.h: Rename include guard.
7706         * common/common-defs.h: Rename include guard.
7707         * common/common-debug.h: Rename include guard.
7708         * common/cleanups.h: Rename include guard.
7709         * common/buffer.h: Rename include guard.
7710         * common/btrace-common.h: Rename include guard.
7711         * common/break-common.h: Rename include guard.
7712         * cli/cli-utils.h: Rename include guard.
7713         * cli/cli-style.h: Rename include guard.
7714         * cli/cli-setshow.h: Rename include guard.
7715         * cli/cli-script.h: Rename include guard.
7716         * cli/cli-interp.h: Rename include guard.
7717         * cli/cli-decode.h: Rename include guard.
7718         * cli/cli-cmds.h: Rename include guard.
7719         * charset-list.h: Add include guard.
7720         * buildsym-legacy.h: Rename include guard.
7721         * bfin-tdep.h: Add include guard.
7722         * ax.h: Rename include guard.
7723         * arm-linux-tdep.h: Add include guard.
7724         * arm-fbsd-tdep.h: Add include guard.
7725         * arch/xtensa.h: Rename include guard.
7726         * arch/tic6x.h: Add include guard.
7727         * arch/i386.h: Add include guard.
7728         * arch/arm.h: Rename include guard.
7729         * arch/arm-linux.h: Rename include guard.
7730         * arch/arm-get-next-pcs.h: Rename include guard.
7731         * arch/amd64.h: Add include guard.
7732         * arch/aarch64-insn.h: Rename include guard.
7733         * arch-utils.h: Rename include guard.
7734         * annotate.h: Add include guard.
7735         * amd64-darwin-tdep.h: Rename include guard.
7736         * aarch64-linux-tdep.h: Add include guard.
7737         * aarch64-fbsd-tdep.h: Add include guard.
7738         * aarch32-linux-nat.h: Add include guard.
7739
7740 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7741
7742         * macrotab.c (macro_define_internal): New function that
7743         factorizes macro_define_object_internal and macro_define_function
7744         code.
7745         (macro_define_object_internal): Use macro_define_internal.
7746         (macro_define_function): Likewise.
7747
7748 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7749
7750         * macrocmd.c (extract_identifier): Return
7751         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7752         callers.
7753
7754 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7755
7756         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7757
7758 2019-02-05  Tom Tromey  <tom@tromey.com>
7759
7760         * target.c (target_stack::unpush): Move assertion earlier.
7761
7762 2019-01-30  Tom Tromey  <tom@tromey.com>
7763
7764         PR python/23615:
7765         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7766         (gdbpy_parse_and_eval): Likewise.
7767         * python/python-internal.h (gdbpy_allow_threads): New class.
7768
7769 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7770
7771         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7772         (aarch64_fbsd_fpregmap): Move earlier.
7773         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7774         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7775         instead of individual calls to trad_frame_set_reg_addr.
7776         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7777         earlier.
7778         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7779         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7780         instead of individual calls to trad_frame_set_reg_addr.
7781
7782 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7783
7784         * CONTRIBUTE: Replace contribution list with wiki link.
7785
7786 2019-01-25  Tom Tromey  <tom@tromey.com>
7787
7788         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7789
7790 2019-01-25  Tom Tromey  <tom@tromey.com>
7791
7792         * xtensa-linux-nat.c: Fix common/ includes.
7793         * xml-support.h: Fix common/ includes.
7794         * xml-support.c: Fix common/ includes.
7795         * x86-linux-nat.c: Fix common/ includes.
7796         * windows-nat.c: Fix common/ includes.
7797         * varobj.h: Fix common/ includes.
7798         * varobj.c: Fix common/ includes.
7799         * value.c: Fix common/ includes.
7800         * valops.c: Fix common/ includes.
7801         * utils.c: Fix common/ includes.
7802         * unittests/xml-utils-selftests.c: Fix common/ includes.
7803         * unittests/utils-selftests.c: Fix common/ includes.
7804         * unittests/unpack-selftests.c: Fix common/ includes.
7805         * unittests/tracepoint-selftests.c: Fix common/ includes.
7806         * unittests/style-selftests.c: Fix common/ includes.
7807         * unittests/string_view-selftests.c: Fix common/ includes.
7808         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7809         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7810         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7811         * unittests/rsp-low-selftests.c: Fix common/ includes.
7812         * unittests/parse-connection-spec-selftests.c: Fix common/
7813         includes.
7814         * unittests/optional-selftests.c: Fix common/ includes.
7815         * unittests/offset-type-selftests.c: Fix common/ includes.
7816         * unittests/observable-selftests.c: Fix common/ includes.
7817         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7818         * unittests/memrange-selftests.c: Fix common/ includes.
7819         * unittests/memory-map-selftests.c: Fix common/ includes.
7820         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7821         * unittests/function-view-selftests.c: Fix common/ includes.
7822         * unittests/environ-selftests.c: Fix common/ includes.
7823         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7824         * unittests/common-utils-selftests.c: Fix common/ includes.
7825         * unittests/cli-utils-selftests.c: Fix common/ includes.
7826         * unittests/array-view-selftests.c: Fix common/ includes.
7827         * ui-file.c: Fix common/ includes.
7828         * tui/tui-io.c: Fix common/ includes.
7829         * tracepoint.h: Fix common/ includes.
7830         * tracepoint.c: Fix common/ includes.
7831         * tracefile-tfile.c: Fix common/ includes.
7832         * top.h: Fix common/ includes.
7833         * top.c: Fix common/ includes.
7834         * thread.c: Fix common/ includes.
7835         * target/waitstatus.h: Fix common/ includes.
7836         * target/waitstatus.c: Fix common/ includes.
7837         * target.h: Fix common/ includes.
7838         * target.c: Fix common/ includes.
7839         * target-memory.c: Fix common/ includes.
7840         * target-descriptions.c: Fix common/ includes.
7841         * symtab.h: Fix common/ includes.
7842         * symfile.c: Fix common/ includes.
7843         * stap-probe.c: Fix common/ includes.
7844         * spu-linux-nat.c: Fix common/ includes.
7845         * sparc-nat.c: Fix common/ includes.
7846         * source.c: Fix common/ includes.
7847         * solib.c: Fix common/ includes.
7848         * solib-target.c: Fix common/ includes.
7849         * ser-unix.c: Fix common/ includes.
7850         * ser-tcp.c: Fix common/ includes.
7851         * ser-pipe.c: Fix common/ includes.
7852         * ser-base.c: Fix common/ includes.
7853         * selftest-arch.c: Fix common/ includes.
7854         * s12z-tdep.c: Fix common/ includes.
7855         * rust-exp.y: Fix common/ includes.
7856         * rs6000-aix-tdep.c: Fix common/ includes.
7857         * riscv-tdep.c: Fix common/ includes.
7858         * remote.c: Fix common/ includes.
7859         * remote-notif.h: Fix common/ includes.
7860         * remote-fileio.h: Fix common/ includes.
7861         * remote-fileio.c: Fix common/ includes.
7862         * regcache.h: Fix common/ includes.
7863         * regcache.c: Fix common/ includes.
7864         * record-btrace.c: Fix common/ includes.
7865         * python/python.c: Fix common/ includes.
7866         * python/py-type.c: Fix common/ includes.
7867         * python/py-inferior.c: Fix common/ includes.
7868         * progspace.h: Fix common/ includes.
7869         * producer.c: Fix common/ includes.
7870         * procfs.c: Fix common/ includes.
7871         * proc-api.c: Fix common/ includes.
7872         * printcmd.c: Fix common/ includes.
7873         * ppc-linux-nat.c: Fix common/ includes.
7874         * parser-defs.h: Fix common/ includes.
7875         * osdata.c: Fix common/ includes.
7876         * obsd-nat.c: Fix common/ includes.
7877         * nat/x86-linux.c: Fix common/ includes.
7878         * nat/x86-linux-dregs.c: Fix common/ includes.
7879         * nat/x86-dregs.h: Fix common/ includes.
7880         * nat/x86-dregs.c: Fix common/ includes.
7881         * nat/ppc-linux.c: Fix common/ includes.
7882         * nat/mips-linux-watch.h: Fix common/ includes.
7883         * nat/mips-linux-watch.c: Fix common/ includes.
7884         * nat/linux-waitpid.c: Fix common/ includes.
7885         * nat/linux-ptrace.h: Fix common/ includes.
7886         * nat/linux-ptrace.c: Fix common/ includes.
7887         * nat/linux-procfs.c: Fix common/ includes.
7888         * nat/linux-personality.c: Fix common/ includes.
7889         * nat/linux-osdata.c: Fix common/ includes.
7890         * nat/linux-namespaces.c: Fix common/ includes.
7891         * nat/linux-btrace.h: Fix common/ includes.
7892         * nat/linux-btrace.c: Fix common/ includes.
7893         * nat/fork-inferior.c: Fix common/ includes.
7894         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7895         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7896         * nat/aarch64-linux.c: Fix common/ includes.
7897         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7898         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7899         * namespace.h: Fix common/ includes.
7900         * mips-linux-tdep.c: Fix common/ includes.
7901         * minsyms.c: Fix common/ includes.
7902         * mi/mi-parse.h: Fix common/ includes.
7903         * mi/mi-main.c: Fix common/ includes.
7904         * mi/mi-cmd-env.c: Fix common/ includes.
7905         * memrange.h: Fix common/ includes.
7906         * memattr.c: Fix common/ includes.
7907         * maint.h: Fix common/ includes.
7908         * maint.c: Fix common/ includes.
7909         * main.c: Fix common/ includes.
7910         * machoread.c: Fix common/ includes.
7911         * location.c: Fix common/ includes.
7912         * linux-thread-db.c: Fix common/ includes.
7913         * linux-nat.c: Fix common/ includes.
7914         * linux-fork.c: Fix common/ includes.
7915         * inline-frame.c: Fix common/ includes.
7916         * infrun.c: Fix common/ includes.
7917         * inflow.c: Fix common/ includes.
7918         * inferior.h: Fix common/ includes.
7919         * inferior.c: Fix common/ includes.
7920         * infcmd.c: Fix common/ includes.
7921         * inf-ptrace.c: Fix common/ includes.
7922         * inf-child.c: Fix common/ includes.
7923         * ia64-linux-nat.c: Fix common/ includes.
7924         * i387-tdep.c: Fix common/ includes.
7925         * i386-tdep.c: Fix common/ includes.
7926         * i386-linux-tdep.c: Fix common/ includes.
7927         * i386-linux-nat.c: Fix common/ includes.
7928         * i386-go32-tdep.c: Fix common/ includes.
7929         * i386-fbsd-tdep.c: Fix common/ includes.
7930         * i386-fbsd-nat.c: Fix common/ includes.
7931         * guile/scm-type.c: Fix common/ includes.
7932         * guile/guile.c: Fix common/ includes.
7933         * go32-nat.c: Fix common/ includes.
7934         * gnu-nat.c: Fix common/ includes.
7935         * gdbthread.h: Fix common/ includes.
7936         * gdbarch-selftests.c: Fix common/ includes.
7937         * gdb_usleep.c: Fix common/ includes.
7938         * gdb_select.h: Fix common/ includes.
7939         * gdb_bfd.c: Fix common/ includes.
7940         * gcore.c: Fix common/ includes.
7941         * fork-child.c: Fix common/ includes.
7942         * findvar.c: Fix common/ includes.
7943         * fbsd-nat.c: Fix common/ includes.
7944         * event-top.c: Fix common/ includes.
7945         * event-loop.c: Fix common/ includes.
7946         * dwarf2read.c: Fix common/ includes.
7947         * dwarf2loc.c: Fix common/ includes.
7948         * dwarf2-frame.c: Fix common/ includes.
7949         * dwarf-index-cache.c: Fix common/ includes.
7950         * dtrace-probe.c: Fix common/ includes.
7951         * disasm-selftests.c: Fix common/ includes.
7952         * defs.h: Fix common/ includes.
7953         * csky-tdep.c: Fix common/ includes.
7954         * cp-valprint.c: Fix common/ includes.
7955         * cp-support.h: Fix common/ includes.
7956         * cp-support.c: Fix common/ includes.
7957         * corelow.c: Fix common/ includes.
7958         * completer.h: Fix common/ includes.
7959         * completer.c: Fix common/ includes.
7960         * compile/compile.c: Fix common/ includes.
7961         * compile/compile-loc2c.c: Fix common/ includes.
7962         * compile/compile-cplus-types.c: Fix common/ includes.
7963         * compile/compile-cplus-symbols.c: Fix common/ includes.
7964         * command.h: Fix common/ includes.
7965         * cli/cli-dump.c: Fix common/ includes.
7966         * cli/cli-cmds.c: Fix common/ includes.
7967         * charset.c: Fix common/ includes.
7968         * build-id.c: Fix common/ includes.
7969         * btrace.h: Fix common/ includes.
7970         * btrace.c: Fix common/ includes.
7971         * breakpoint.h: Fix common/ includes.
7972         * breakpoint.c: Fix common/ includes.
7973         * ax.h:
7974         (enum agent_op): Fix common/ includes.
7975         * ax-general.c (struct aop_map): Fix common/ includes.
7976         * ax-gdb.c: Fix common/ includes.
7977         * auxv.c: Fix common/ includes.
7978         * auto-load.c: Fix common/ includes.
7979         * arm-tdep.c: Fix common/ includes.
7980         * arch/riscv.c: Fix common/ includes.
7981         * arch/ppc-linux-common.c: Fix common/ includes.
7982         * arch/i386.c: Fix common/ includes.
7983         * arch/arm.c: Fix common/ includes.
7984         * arch/arm-linux.c: Fix common/ includes.
7985         * arch/arm-get-next-pcs.c: Fix common/ includes.
7986         * arch/amd64.c: Fix common/ includes.
7987         * arch/aarch64.c: Fix common/ includes.
7988         * arch/aarch64-insn.c: Fix common/ includes.
7989         * arch-utils.c: Fix common/ includes.
7990         * amd64-windows-tdep.c: Fix common/ includes.
7991         * amd64-tdep.c: Fix common/ includes.
7992         * amd64-sol2-tdep.c: Fix common/ includes.
7993         * amd64-obsd-tdep.c: Fix common/ includes.
7994         * amd64-nbsd-tdep.c: Fix common/ includes.
7995         * amd64-linux-tdep.c: Fix common/ includes.
7996         * amd64-linux-nat.c: Fix common/ includes.
7997         * amd64-fbsd-tdep.c: Fix common/ includes.
7998         * amd64-fbsd-nat.c: Fix common/ includes.
7999         * amd64-dicos-tdep.c: Fix common/ includes.
8000         * amd64-darwin-tdep.c: Fix common/ includes.
8001         * agent.c: Fix common/ includes.
8002         * ada-lang.h: Fix common/ includes.
8003         * ada-lang.c: Fix common/ includes.
8004         * aarch64-tdep.c: Fix common/ includes.
8005
8006 2019-01-25  Tom Tromey  <tom@tromey.com>
8007
8008         * common/create-version.sh: Use common/version.h.
8009
8010 2019-01-24  Pedro Alves  <palves@redhat.com>
8011
8012         * infrun.c (signal_stop, signal_print, signal_program)
8013         (signal_catch, signal_pass): Now arrays instead of pointers.
8014         (update_signals_program_target, do_target_resume)
8015         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8016         * linux-nat.c (linux_nat_target::pass_signals)
8017         (linux_nat_target::create_inferior, linux_nat_target::attach):
8018         Adjust.
8019         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8020         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8021         * procfs.c (procfs_target::pass_signals): Adjust.
8022         * record-full.c (record_full_target::resume): Adjust.
8023         * remote.c (remote_target::pass_signals)
8024         (remote_target::program_signals): Adjust.
8025         * target-debug.h (target_debug_print_signals): Now takes a
8026         gdb::array_view as parameter.  Adjust.
8027         * target.h (target_ops) <pass_signals, program_signals>: Replace
8028         pointer and length parameters with gdb::array_view.
8029         (target_pass_signals, target_program_signals): Likewise.
8030         * target-delegates.c: Regenerate.
8031
8032 2019-01-24  Pedro Alves  <palves@redhat.com>
8033
8034         * common/forward-scope-exit.h
8035         (forward_scope_exit::forward_scope_exit): Pass arguments to
8036         m_bind_function directly, instead of creating a std::bind and
8037         copying that.
8038
8039 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8040
8041         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8042         for static members.
8043         (pass_in_v_vfp_candidate): Likewise.
8044
8045 2019-01-23  Tom Tromey  <tom@tromey.com>
8046             Pedro Alves  <palves@redhat.com>
8047
8048         * regcache.c (class regcache_invalidator): Remove.
8049         (regcache::raw_write): Use make_scope_exit.
8050
8051 2019-01-23  Tom Tromey  <tom@tromey.com>
8052
8053         * ui-out.h (class ui_out_emit_type): Update comment.
8054
8055 2019-01-23  Tom Tromey  <tom@tromey.com>
8056
8057         * infrun.c (fetch_inferior_event): Update comment.
8058
8059 2019-01-23  Tom Tromey  <tom@tromey.com>
8060             Pedro Alves  <palves@redhat.com>
8061
8062         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8063         parameter.
8064         (fetch_inferior_event): Use SCOPE_EXIT.
8065
8066
8067 2019-01-23  Tom Tromey  <tom@tromey.com>
8068             Pedro Alves  <palves@redhat.com>
8069
8070         * infrun.c (disable_thread_events): Delete.
8071         (stop_all_threads): Use SCOPE_EXIT.
8072
8073 2019-01-23  Tom Tromey  <tom@tromey.com>
8074             Pedro Alves  <palves@redhat.com>
8075
8076         * symfile.c: Include forward-scope-exit.h.
8077         (clear_symtab_users_cleanup): Replace forward declaration with
8078         a FORWARD_SCOPE_EXIT.
8079         (syms_from_objfile_1): Use the forward_scope_exit and
8080         gdb::optional instead of cleanup_function.
8081         (reread_symbols): Use the forward_scope_exit instead of
8082         cleanup_function.
8083         (clear_symtab_users_cleanup): Remove function.
8084
8085 2019-01-23  Tom Tromey  <tom@tromey.com>
8086             Pedro Alves  <palves@redhat.com>
8087
8088         * linux-nat.c: Include scope-exit.h.
8089         (cleanup_target_stop): Remove.
8090         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8091         SCOPE_EXIT.
8092
8093 2019-01-23  Tom Tromey  <tom@tromey.com>
8094             Pedro Alves  <palves@redhat.com>
8095
8096         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8097         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8098
8099 2019-01-23  Tom Tromey  <tom@tromey.com>
8100             Andrew Burgess  <andrew.burgess@embecosm.com>
8101             Pedro Alves  <palves@redhat.com>
8102
8103         * infrun.c (fetch_inferior_event): Use scope_exit.
8104         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8105         * top.c (execute_command): Use scope_exit.
8106         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8107         * utils.c (do_bpstat_clear_actions_cleanup)
8108         (make_bpstat_clear_actions_cleanup): Remove.
8109
8110 2019-01-23  Tom Tromey  <tom@tromey.com>
8111             Pedro Alves  <palves@redhat.com>
8112
8113         * infrun.c: Include "common/scope-exit.h"
8114         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8115         (wait_for_inferior): Use SCOPE_EXIT.
8116         (fetch_inferior_event): Use scope_exit.
8117
8118 2019-01-23  Tom Tromey  <tom@tromey.com>
8119             Pedro Alves  <palves@redhat.com>
8120
8121         * breakpoint.c (create_breakpoint): Remove cleanup.
8122
8123 2019-01-23  Tom Tromey  <tom@tromey.com>
8124             Andrew Burgess  <andrew.burgess@embecosm.com>
8125             Pedro Alves  <palves@redhat.com>
8126
8127 2019-01-23  Pedro Alves  <palves@redhat.com>
8128
8129         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8130
8131 2019-01-23  Pedro Alves  <palves@redhat.com>
8132             Andrew Burgess  <andrew.burgess@embecosm.com>
8133
8134         * gdbthread.h: Include "common/forward-scope-exit.h".
8135         (scoped_finish_thread_state): Redefine custom class in terms of
8136         forward_scope_exit.
8137
8138 2019-01-23  Pedro Alves  <palves@redhat.com>
8139             Andrew Burgess  <andrew.burgess@embecosm.com>
8140
8141         * common/forward-scope-exit.h: New file.
8142
8143 2019-01-23  Pedro Alves  <palves@redhat.com>
8144             Andrew Burgess  <andrew.burgess@embecosm.com>
8145             Tom Tromey  <tom@tromey.com>
8146
8147         * common/scope-exit.h: New file.
8148
8149 2019-01-23  Pedro Alves  <palves@redhat.com>
8150
8151         * common/preprocessor.h (ESC): Rename to ...
8152         (ESC_PARENS): ... this.
8153         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8154         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8155
8156 2019-01-23  Tom Tromey  <tom@tromey.com>
8157
8158         * language.h (class scoped_switch_to_sym_language_if_auto):
8159         Initialize m_lang in both cases.
8160
8161 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8162
8163         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8164         with XCNEW.
8165
8166 2019-01-22  Tom Tromey  <tom@tromey.com>
8167
8168         * corelow.c: Do not include sys/file.h.
8169
8170 2019-01-22  Tom Tromey  <tom@tromey.com>
8171
8172         * tui/tui-wingeneral.h: Include gdb_curses.h.
8173
8174 2019-01-22  Tom Tromey  <tom@tromey.com>
8175
8176         * source-cache.h (class source_cache) <get_source_lines,
8177         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8178
8179 2019-01-22  Tom Tromey  <tom@tromey.com>
8180
8181         * remote-fileio.h (struct remote_target): Declare.
8182
8183 2019-01-22  Tom Tromey  <tom@tromey.com>
8184
8185         * python/py-arch.c: Do not include py-ref.h.
8186         * python/py-bpevent.c: Do not include py-ref.h.
8187         * python/py-cmd.c: Do not include py-ref.h.
8188         * python/py-continueevent.c: Do not include py-ref.h.
8189         * python/py-event.h: Do not include py-ref.h.
8190         * python/py-evtregistry.c: Do not include py-ref.h.
8191         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8192         * python/py-frame.c: Do not include py-ref.h.
8193         * python/py-framefilter.c: Do not include py-ref.h.
8194         * python/py-function.c: Do not include py-ref.h.
8195         * python/py-infevents.c: Do not include py-ref.h.
8196         * python/py-linetable.c: Do not include py-ref.h.
8197         * python/py-objfile.c: Do not include py-ref.h.
8198         * python/py-param.c: Do not include py-ref.h.
8199         * python/py-prettyprint.c: Do not include py-ref.h.
8200         * python/py-progspace.c: Do not include py-ref.h.
8201         * python/py-symbol.c: Do not include py-ref.h.
8202         * python/py-symtab.c: Do not include py-ref.h.
8203         * python/py-type.c: Do not include py-ref.h.
8204         * python/py-unwind.c: Do not include py-ref.h.
8205         * python/py-utils.c: Do not include py-ref.h.
8206         * python/py-value.c: Do not include py-ref.h.
8207         * python/py-varobj.c: Do not include py-ref.h.
8208         * python/py-xmethods.c: Do not include py-ref.h.
8209         * python/python.c: Do not include py-ref.h.
8210         * varobj.c: Do not include py-ref.h.
8211
8212 2019-01-22  Tom Tromey  <tom@tromey.com>
8213
8214         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8215         keyword for bcache.
8216
8217 2019-01-22  Tom Tromey  <tom@tromey.com>
8218
8219         * compile/compile-cplus-types.c: Remove a comment by #include.
8220
8221 2019-01-22  Tom Tromey  <tom@tromey.com>
8222
8223         * compile/gcc-c-plugin.h: Include compile-internal.h.
8224
8225 2019-01-22  Tom Tromey  <tom@tromey.com>
8226
8227         * stabsread.c (EXTERN): Do not define.
8228         (symnum, next_symbol_text_func, processing_gcc_compilation)
8229         (within_function, global_sym_chain, global_stabs)
8230         (previous_stab_code, this_object_header_files)
8231         (n_this_object_header_files)
8232         (n_allocated_this_object_header_files): Define.
8233         * stabsread.h (EXTERN): Never define.  Use "extern".
8234
8235 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8236
8237         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8238         history_value.
8239
8240 2019-01-21  Tom Tromey  <tom@tromey.com>
8241
8242         * ui-out.c: Fix includes.
8243         * tui/tui-source.c: Fix includes.
8244         * target.c: Fix includes.
8245         * remote.c: Fix includes.
8246         * regcache.c: Fix includes.
8247         * python/py-block.c: Fix includes.
8248         * printcmd.c: Fix includes.
8249         * or1k-tdep.c: Fix includes.
8250         * mi/mi-main.c: Fix includes.
8251         * m32r-tdep.c: Fix includes.
8252         * csky-tdep.c: Fix includes.
8253         * compile/compile-cplus-types.c: Fix includes.
8254         * cli/cli-interp.c: Fix includes.
8255
8256 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8257
8258         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8259         for padding.
8260
8261 2019-01-16  Tom Tromey  <tom@tromey.com>
8262
8263         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8264         earlier.
8265         (struct objfile) <msymbols_range>: Move from top level.
8266         <msymbols>: New method.
8267         (class objfile_msymbols): Remove.
8268         * symtab.c (default_collect_symbol_completion_matches_break_on):
8269         Update.
8270         * symmisc.c (dump_msymbols): Update.
8271         * stabsread.c (scan_file_globals): Update.
8272         * objc-lang.c (info_selectors_command, info_classes_command)
8273         (find_methods): Update.
8274         * minsyms.c (find_solib_trampoline_target): Update.
8275         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8276         * coffread.c (coff_symfile_read): Update.
8277         * ada-lang.c (ada_lookup_simple_minsym)
8278         (ada_collect_symbol_completion_matches): Update.
8279
8280 2019-01-16  Tom Tromey  <tom@tromey.com>
8281
8282         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8283         type.  Remove no-argument constructor.
8284         <iterator::operator++>: Simplify.
8285         <begin>: Update.
8286         <end>: Use minimal_symbol_count.
8287
8288 2019-01-16  Tom Tromey  <tom@tromey.com>
8289
8290         * objfiles.h (struct objfile) <psymtabs>: New method.
8291         (class objfile_psymtabs): Remove.
8292         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8293         typedef.
8294         <range>: New method.
8295         (require_partial_symbols): Change return type.
8296         * psymtab.c (require_partial_symbols)
8297         (psym_expand_symtabs_matching): Update.
8298         * mdebugread.c (parse_partial_symbols): Update.
8299         * dbxread.c (dbx_end_psymtab): Update.
8300
8301 2019-01-15  Tom Tromey  <tom@tromey.com>
8302
8303         * symtab.c (lookup_objfile_from_block)
8304         (lookup_symbol_in_objfile_symtabs)
8305         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8306         (find_line_symtab, info_sources_command)
8307         (default_collect_symbol_completion_matches_break_on)
8308         (make_source_files_completion_list): Update.
8309         * symmisc.c (print_objfile_statistics, dump_objfile)
8310         (maintenance_print_symbols, maintenance_info_symtabs)
8311         (maintenance_check_symtabs, maintenance_info_line_tables):
8312         Update.
8313         * source.c (select_source_symtab)
8314         (forget_cached_source_info_for_objfile): Update.
8315         * objfiles.h (class objfile_compunits): Remove.
8316         (struct objfile) <compunits_range>: New typedef.
8317         (compunits): New method.
8318         * objfiles.c (objfile_relocate1): Update.
8319         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8320         * maint.c (count_symtabs_and_blocks): Update.
8321         * linespec.c (iterate_over_all_matching_symtabs): Update.
8322         * cp-support.c (add_symbol_overload_list_qualified): Update.
8323         * coffread.c (coff_symtab_read): Update.
8324         * ada-lang.c (add_nonlocal_symbols)
8325         (ada_collect_symbol_completion_matches)
8326         (ada_add_global_exceptions): Update.
8327
8328 2019-01-15  Tom Tromey  <tom@tromey.com>
8329
8330         * progspace.h (program_space) <objfiles_safe_range>: New
8331         typedef.
8332         <objfiles_safe>: New method.
8333         * objfiles.h (class all_objfiles_safe): Remove.
8334         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8335         * jit.c (jit_inferior_exit_hook): Update.
8336
8337 2019-01-17  Tom Tromey  <tom@tromey.com>
8338
8339         * progspace.h (program_space) <objfiles_range>: New typedef.
8340         <objfiles>: New method.
8341         <objfiles_head>: Rename from objfiles.
8342         (object_files): Update.
8343         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8344         * guile/scm-pretty-print.c
8345         (ppscm_find_pretty_printer_from_objfiles): Update.
8346         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8347         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8348         Update.
8349         * python/py-progspace.c (pspy_get_objfiles): Update.
8350         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8351         Update.
8352         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8353         (objfpy_lookup_objfile_by_build_id): Update.
8354         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8355         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8356         Update.
8357         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8358         (expand_symtab_containing_pc, lookup_objfile_from_block)
8359         (lookup_static_symbol, basic_lookup_transparent_type)
8360         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8361         (find_line_symtab, info_sources_command)
8362         (default_collect_symbol_completion_matches_break_on)
8363         (make_source_files_completion_list, find_main_name): Update.
8364         * symmisc.c (print_symbol_bcache_statistics)
8365         (print_objfile_statistics, maintenance_print_symbols)
8366         (maintenance_print_msymbols, maintenance_print_objfiles)
8367         (maintenance_info_symtabs, maintenance_check_symtabs)
8368         (maintenance_expand_symtabs, maintenance_info_line_tables):
8369         Update.
8370         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8371         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8372         (map_overlay_command, unmap_overlay_command)
8373         (simple_overlay_update, expand_symtabs_matching)
8374         (map_symbol_filenames): Update.
8375         * symfile-debug.c (set_debug_symfile): Update.
8376         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8377         Update.
8378         * source.c (select_source_symtab, forget_cached_source_info):
8379         Update.
8380         * solib.c (solib_read_symbols): Update.
8381         * solib-spu.c (append_ocl_sos): Update.
8382         * psymtab.c (maintenance_print_psymbols)
8383         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8384         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8385         * printcmd.c (info_symbol_command): Update.
8386         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8387         Update.
8388         * objfiles.h (class all_objfiles): Remove.
8389         * objfiles.c (have_partial_symbols, have_full_symbols)
8390         (have_minimal_symbols, qsort_cmp, update_section_map)
8391         (shared_objfile_contains_address_p)
8392         (default_iterate_over_objfiles_in_search_order): Update.
8393         * objc-lang.c (info_selectors_command, info_classes_command)
8394         (find_methods): Update.
8395         * minsyms.c (find_solib_trampoline_target): Update.
8396         * maint.c (maintenance_info_sections)
8397         (maintenance_translate_address, count_symtabs_and_blocks):
8398         Update.
8399         * main.c (captured_main_1): Update.
8400         * linux-thread-db.c (try_thread_db_load_from_pdir)
8401         (has_libpthread): Update.
8402         * linespec.c (iterate_over_all_matching_symtabs)
8403         (search_minsyms_for_name): Update.
8404         * jit.c (jit_find_objf_with_entry_addr): Update.
8405         * hppa-tdep.c (find_unwind_entry)
8406         (hppa_lookup_stub_minimal_symbol): Update.
8407         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8408         Update.
8409         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8410         (elf_gnu_ifunc_resolve_by_got): Update.
8411         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8412         * dwarf-index-write.c (save_gdb_index_command): Update.
8413         * cp-support.c (add_symbol_overload_list_qualified): Update.
8414         * breakpoint.c (create_overlay_event_breakpoint)
8415         (create_longjmp_master_breakpoint)
8416         (create_std_terminate_master_breakpoint)
8417         (create_exception_master_breakpoint): Update.
8418         * blockframe.c (find_pc_partial_function): Update.
8419         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8420         (ada_collect_symbol_completion_matches)
8421         (ada_add_global_exceptions): Update.
8422
8423 2019-01-17  Tom Tromey  <tom@tromey.com>
8424
8425         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8426         declare VEC.
8427         (solib_target_parse_libraries): Change return type.
8428         (library_list_start_segment, library_list_start_section)
8429         (library_list_end_library, library_list_start_library); Update.
8430         (solib_target_free_library_list): Remove.
8431         (solib_target_parse_libraries): Remove cleanup.  Change return
8432         type.
8433         (solib_target_current_sos): Update.
8434
8435 2019-01-17  Tom Tromey  <tromey@bapiya>
8436
8437         * valprint.c: Replace "the the" with "the".
8438         * symtab.c: Replace "the the" with "the".
8439         * solib.c: Replace "the the" with "the".
8440         * solib-dsbt.c: Replace "the the" with "the".
8441         * linespec.c: Replace "the the" with "the".
8442         * dwarf2loc.h: Replace "the the" with "the".
8443         * amd64-windows-tdep.c: Replace "the the" with "the".
8444         * aarch64-tdep.c: Replace "the the" with "the".
8445
8446 2019-01-16  Keith Seitz  <keiths@redhat.com>
8447
8448         PR gdb/23773
8449         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8450         <builder>: Rename to ..
8451         <m_builder>: ... this and make private.
8452         (dwarf2_cu::get_builder): New method.  Change all users of
8453         `builder' to use this method.
8454         (dwarf2_start_symtab): Move to ...
8455         (dwarf2_cu::start_symtab): ... here.  Update all callers
8456         (setup_type_unit_groups): Move to ...
8457         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8458         callers.
8459         (dwarf2_cu::reset_builder): New method.
8460         (process_full_compunit, process_full_type_unit): Use
8461         dwarf2_cu::reset_builder.
8462         (follow_die_offset): Record the ancestor CU if it is different
8463         from the followed DIE's CU.
8464         (follow_die_sig_1): Likewise.
8465
8466 2019-01-15  Tom Tromey  <tom@tromey.com>
8467
8468         * remote.c (class remote_state) <buf>: Now a char_vector.
8469         <buf_size>: Remove.
8470         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8471         parameter.
8472         (remote_target::getpkt_or_notif_sane_1)
8473         (remote_target::getpkt_sane)
8474         (remote_target::getpkt_or_notif_sane): Likewise.
8475         (class remote_target) <putpkt>: New overload.
8476         (remote_target::read_frame): Change type of "buf_p".  Remove
8477         sizeof_p parameter.
8478         (packet_ok): New overload.
8479         (packet_check_result): New overload.
8480         Update all uses.
8481
8482 2019-01-14  Tom Tromey  <tom@tromey.com>
8483
8484         * remote-notif.c (handle_notification, remote_notif_ack)
8485         (remote_notif_parse): Make "buf" const.
8486         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8487         const.
8488         (remote_notif_parse, remote_notif_ack, handle_notification):
8489         Likewise.
8490         * remote.c (remote_notif_stop_parse): Make "buf" const.
8491         (remote_target::remote_parse_stop_reply): Make "buf" const.
8492         (remote_notif_stop_ack): Make "buf" const.
8493
8494 2019-01-14  Tom Tromey  <tom@tromey.com>
8495
8496         * remote.c (remote_console_output): Make parameter const.
8497
8498 2019-01-14  Tom Tromey  <tom@tromey.com>
8499
8500         * target-debug.h (target_debug_print_signals): Constify.
8501         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8502         * procfs.c (procfs_target::pass_signals): Update.
8503         * linux-nat.c (linux_nat_target::pass_signals): Update.
8504         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8505         * target-delegates.c: Rebuild.
8506         * remote.c (remote_target::program_signals): Update.
8507         (remote_target::pass_signals): Update.
8508         * target.c (target_pass_signals): Constify argument.
8509         (target_program_signals): Likewise.
8510         * target.h (struct target_ops) <pass_signals, program_signals>:
8511         Constify argument.
8512         (target_pass_signals, target_program_signals): Constify argument.
8513
8514 2019-01-14  Tom Tromey  <tom@tromey.com>
8515
8516         PR tui/28819:
8517         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8518
8519 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8520
8521         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8522         field.
8523         * rs6000-tdep.c: Include reggroups.h.
8524         (IS_V_ALIAS_PSEUDOREG): Define.
8525         (rs6000_register_name): Return names for the "vX" aliases.
8526         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8527         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8528         aliases.  Call default_register_reggroup_p for all other
8529         pseudo-registers.
8530         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8531         New functions.
8532         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8533         Handle "vX" aliases.
8534         (v_alias_pseudo_register_collect): New function.
8535         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8536         (rs6000_gdbarch_init): Initialize "vX" aliases as
8537         pseudo-registers.  Restore registration of
8538         rs6000_pseudo_register_reggroup_p with
8539         set_tdesc_pseudo_register_reggroup_p.
8540
8541 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8542
8543         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8544         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8545         set_gdbarch_num_pseudo_regs.
8546
8547 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8548
8549         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8550         Remove arg prefixname, add do_set and do_show.
8551         Add member functions set_list and show_list.
8552         * cli/cli-style.c (class cli_style_option): Update accordingly.
8553         (style_set_list): Move to file scope.
8554         (style_show_list): Likewise.
8555         (set_style): Call help_list.
8556         (show_style): Call cmd_show_list.
8557         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8558         Update to use the new macro.
8559
8560 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8561
8562         * ada-lang.c (_initialize_ada_language): Expand the help text
8563         for the "catch exception" command.
8564
8565 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8566
8567         * symtab.c (matching_obj_sections): Initialize obj,
8568         declare it closer to its usage.
8569
8570 2019-01-10  Tom Tromey  <tom@tromey.com>
8571
8572         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8573         (basic_inf_threads_range): Remove.
8574         (inf_threads_range, inf_non_exited_threads_range)
8575         (safe_inf_threads_range): Use next_adapter.
8576
8577 2019-01-10  Keith Seitz  <keiths@redhat.com>
8578
8579         PR gdb/23712
8580         PR symtab/23010
8581         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8582         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8583
8584 2019-01-10  Keith Seitz  <keiths@redhat.com>
8585
8586         PR gdb/23712
8587         PR symtab/23010
8588         * dictionary.c (pending_to_vector): Remove.
8589         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8590         Remove _1 suffix, replacing functions of the same name.  Update
8591         all callers.
8592         (dict_create_hashed, dict_create_hashed_expandable)
8593         (dict_create_linear, dict_create_linear_expandable, dict_free)
8594         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8595         Make functions static.
8596
8597 2019-01-10  Keith Seitz  <keiths@redhat.com>
8598
8599         PR gdb/23712
8600         PR symtab/23010
8601         * dictionary.h (struct dictionary): Replace declaration with
8602         multidictionary.
8603         (dict_create_hashed, dict_create_hashed_expandable)
8604         (dict_create_linear, dict_create_linear_expandable)
8605         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8606         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8607         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8608         taking multidictionary argument.
8609         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8610         * block.h (struct block) <dict>: Change to multidictionary
8611         and rename `multidict'.
8612         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8613         symmisc.c: Update all dictionary references to multidictionary.
8614
8615 2019-01-10  Keith Seitz  <keiths@redhat.com>
8616
8617         PR gdb/23712
8618         PR symtab/23010
8619         * dictionary.c: Include unordered_map.
8620         (pending_to_vector): New function.
8621         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8622         Rewrite the non-"_1" functions to take vector instead
8623         of linked list.
8624         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8625         "new" _1 versions of the same name.
8626         (multidictionary): Define.
8627         (std::hash<enum language): New definition.
8628         (collate_pending_symbols_by_language, mdict_create_hashed)
8629         (mdict_create_hashed_expandable, mdict_create_linear)
8630         (mdict_create_linear_expandable, mdict_free)
8631         (find_language_dictionary, create_new_language_dictionary)
8632         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8633         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8634         (mdict_size, mdict_empty): New functions.
8635         * dictionary.h (mdict_iterator): Define.
8636
8637 2019-01-10  Pedro Alves  <palves@redhat.com>
8638
8639         * breakpoint.c (read_uploaded_action)
8640         (create_tracepoint_from_upload): Adjust to use
8641         gdb::unique_xmalloc_ptr.
8642         * ctf.c (ctf_write_uploaded_tp):
8643         (SET_ARRAY_FIELD): Use emplace_back.
8644         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8645         * tracefile-tfile.c (tfile_write_uploaded_tp):
8646         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8647         gdb::unique_xmalloc_ptr.
8648         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8649         at_string, cond_string, cmd_strings>: Replace char pointers
8650         with gdb::unique_xmalloc_ptr.
8651
8652 2019-01-10  Pedro Alves  <palves@redhat.com>
8653
8654         * solib-target.c (library_list_start_library): Don't xstrdup name.
8655
8656 2019-01-10  Pedro Alves  <palves@redhat.com>
8657
8658         * mdebugread.c (parse_partial_symbols): Use
8659         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8660
8661 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8662
8663         * linux-fork.c (scoped_switch_fork_info)
8664         <~scoped_switch_fork_info>: Fix incorrect variable name.
8665
8666 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8667
8668         * linux-fork.c (scoped_switch_fork_info)
8669         <scoped_switch_fork_info>: Make explicit.
8670         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8671
8672 2019-01-10  Tom Tromey  <tom@tromey.com>
8673
8674         * objfiles.h (objfile::reset_psymtabs): Update.
8675         * objfiles.c (objfile::objfile): Update.
8676         * psymtab.h (psymtab_storage::obstack): Update.
8677         (psymtab_storage::m_obstack): Use gdb::optional.
8678         (class psymtab_storage): Update comment.  Remove objfile
8679         parameter.
8680         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8681
8682 2019-01-10  Tom Tromey  <tom@tromey.com>
8683
8684         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8685         <free_psymtabs>: Now private.
8686         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8687         (allocate_psymtab): Use new method.
8688
8689 2019-01-10  Tom Tromey  <tom@tromey.com>
8690
8691         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8692         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8693         * mdebugread.c (parse_partial_symbols): Use
8694         allocate_dependencies.
8695         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8696         allocate_dependencies.
8697         (process_psymtab_comp_unit_reader)
8698         (build_type_psymtab_dependencies): Likewise.
8699         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8700
8701 2019-01-10  Tom Tromey  <tom@tromey.com>
8702
8703         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8704         PSYMBOL_SET_LANGUAGE.
8705         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8706
8707 2019-01-10  Tom Tromey  <tom@tromey.com>
8708
8709         * psymtab.h (psymtab_storage::obstack): New method.
8710         <m_obstack>: Rename from obstack; now private.
8711         * psymtab.c (psymtab_storage): Update.
8712         * dwarf2read.c (create_addrmap_from_index)
8713         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8714         Update.
8715
8716 2019-01-10  Tom Tromey  <tom@tromey.com>
8717
8718         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8719         * objfiles.h (objfile::reset_psymtabs): New method.
8720
8721 2019-01-10  Tom Tromey  <tom@tromey.com>
8722
8723         * symmisc.c (print_symbol_bcache_statistics): Update.
8724         (print_objfile_statistics): Update.
8725         * symfile.c (reread_symbols): Update.
8726         * psymtab.h (class psymtab_storage): New.
8727         * psymtab.c (psymtab_storage): New constructor.
8728         (~psymtab_storage): New destructor.
8729         (require_partial_symbols): Update.
8730         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8731         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8732         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8733         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8734         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8735         (start_psymtab_common, end_psymtab_common)
8736         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8737         (allocate_psymtab): Update.
8738         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8739         Update.
8740         (dump_psymtab_addrmap, maintenance_print_psymbols)
8741         (maintenance_check_psymtabs): Update.
8742         (class objfile_psymtabs): Move to objfiles.h.
8743         * psympriv.h (discard_psymtab): Now inline.
8744         (psymtab_discarder::psymtab_discarder): Update.
8745         (psymtab_discarder::~psymtab_discarder): Update.
8746         (ALL_OBJFILE_PSYMTABS): Rewrite.
8747         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8748         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8749         Remove fields.
8750         <partial_symtabs>: New field.
8751         (class objfile_psymtabs): Move from psymtab.h.  Update.
8752         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8753         psymbol_cache.
8754         (objfile::~objfile): Don't destroy psymbol_cache.
8755         * mdebugread.c (parse_partial_symbols): Update.
8756         * dwarf2read.c (create_addrmap_from_index)
8757         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8758         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8759         (add_partial_subprogram, dwarf2_ranges_read): Update.
8760         * dwarf-index-write.c (write_address_map)
8761         (write_one_signatured_type, recursively_write_psymbols)
8762         (class debug_names, class debug_names, write_psymtabs_to_index):
8763         Update.
8764
8765 2019-01-10  Tom Tromey  <tom@tromey.com>
8766
8767         * symtab.h (SYMBOL_SET_NAMES): Update.
8768         (symbol_set_names): Update.
8769         (MSYMBOL_SET_NAMES): Update.
8770         * symtab.c (symbol_set_names): Change argument to be an
8771         objfile_per_bfd_storage.
8772         * psymtab.c (add_psymbol_to_bcache): Update.
8773         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8774
8775 2019-01-10  Tom Tromey  <tom@tromey.com>
8776
8777         * symtab.c (create_demangled_names_hash): Change argument to be an
8778         objfile_per_bfd_storage.
8779         (symbol_set_names): Update.
8780
8781 2019-01-10  Tom Tromey  <tom@tromey.com>
8782
8783         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8784         init_psymbol_list.
8785         * psymtab.c (init_psymbol_list): Do nothing if already called.
8786         * psympriv.h (init_psymbol_list): Add comment.
8787         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8788         init_psymbol_list.
8789         * dbxread.c (dbx_symfile_read): Unconditionally call
8790         init_psymbol_list.
8791
8792 2019-01-10  Tom Tromey  <tom@tromey.com>
8793
8794         * xcoffread.c (scan_xcoff_symtab): Update.
8795         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8796         "where".
8797         * mdebugread.c (parse_partial_symbols)
8798         (handle_psymbol_enumerators): Update.
8799         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8800         * dbxread.c (read_dbx_symtab): Update.
8801         * psympriv.h (psymbol_placement): New enum.
8802         (add_psymbol_to_list): Update.
8803
8804 2019-01-10  Tom Tromey  <tom@tromey.com>
8805
8806         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8807         static_psymbols parameters.
8808         (scan_xcoff_symtab): Update.
8809         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8810         static_psymbols parameters.
8811         * psympriv.h (start_psymtab_common): Update.
8812         * mdebugread.c (parse_partial_symbols): Update.
8813         * dwarf2read.c (create_partial_symtab): Update.
8814         * dbxread.c (read_dbx_symtab): Update.
8815         (start_psymtab): Remove global_psymbols and static_psymbols
8816         parameters.
8817
8818 2019-01-10  Tom Tromey  <tom@tromey.com>
8819
8820         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8821         * psymtab.c (allocate_psymtab): Add comment.
8822         * psympriv.h (allocate_psymtab): Add comment.
8823         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8824         initializations.
8825         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8826
8827 2019-01-10  Tom Tromey  <tom@tromey.com>
8828
8829         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8830         Don't declare.
8831         * mipsread.c: Include mdebugread.h.
8832         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8833         Declare.
8834         * elfread.c: Include mdebugread.h.
8835
8836 2019-01-09  Tom Tromey  <tom@tromey.com>
8837
8838         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8839         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8840         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8841         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8842         (psym_lookup_symbol, psym_find_last_source_symtab)
8843         (psym_forget_cached_source_info, psym_print_stats)
8844         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8845         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8846         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8847         (psym_find_compunit_symtab_by_address)
8848         (maintenance_print_psymbols, maintenance_info_psymtabs)
8849         (maintenance_check_psymtabs): Use ranged for.
8850         * psymtab.h (class objfile_psymtabs): New.
8851         (require_partial_symbols): Return objfile_psymtabs.
8852         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8853
8854 2019-01-09  Tom Tromey  <tom@tromey.com>
8855
8856         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8857         (find_pc_mapped_section, list_overlays_command)
8858         (map_overlay_command, unmap_overlay_command)
8859         (simple_overlay_update): Use all_objfiles.
8860         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8861         * printcmd.c (info_symbol_command): Use all_objfiles.
8862         * objfiles.h (ALL_OBJSECTIONS): Remove.
8863         * maint.c (maintenance_translate_address): Use all_objfiles.
8864         * gcore.c (gcore_create_callback): Use all_objfiles.
8865         (objfile_find_memory_regions): Likewise.
8866
8867 2019-01-09  Tom Tromey  <tom@tromey.com>
8868
8869         * symtab.c (find_line_symtab, info_sources_command)
8870         (make_source_files_completion_list): Use objfile_compunits.
8871         * source.c (select_source_symtab): Use objfile_compunits.
8872         * objfiles.h (struct objfile): Update comment.
8873         (ALL_OBJFILES): Remove.
8874         (ALL_FILETABS): Remove.
8875         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8876         objfile_compunits.
8877
8878 2019-01-09  Tom Tromey  <tom@tromey.com>
8879
8880         * symmisc.c (print_objfile_statistics, dump_objfile)
8881         (maintenance_print_symbols): Use compunit_filetabs.
8882         * source.c (forget_cached_source_info_for_objfile): Use
8883         compunit_filetabs.
8884         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8885         (ALL_FILETABS): Use compunit_filetabs.
8886         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8887         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8888
8889 2019-01-09  Tom Tromey  <tom@tromey.com>
8890
8891         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8892         (compunit_filetabs): New.
8893         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8894         compunit_filetabs.
8895         (info_sources_command, make_source_files_completion_list): Remove
8896         declaration.
8897         * symmisc.c (print_objfile_statistics, dump_objfile)
8898         (maintenance_print_symbols): Remove declaration.
8899         (maintenance_info_symtabs): Use compunit_filetabs.
8900         (maintenance_info_line_tables): Likewise.
8901         * source.c (select_source_symtab): Change local variable name.
8902         (forget_cached_source_info_for_objfile): Remove declaration.
8903         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8904         * objfiles.c (objfile_relocate1): Remove declaration.
8905         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8906         declaration.
8907         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8908         * coffread.c (coff_symtab_read): Remove declaration.
8909         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8910         compunit_filetabs.
8911
8912 2019-01-09  Tom Tromey  <tom@tromey.com>
8913
8914         * symtab.c (lookup_objfile_from_block)
8915         (find_pc_sect_compunit_symtab, search_symbols)
8916         (default_collect_symbol_completion_matches_break_on): Use
8917         objfile_compunits.
8918         * objfiles.h (ALL_COMPUNITS): Remove.
8919         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8920         * cp-support.c (add_symbol_overload_list_qualified): Use
8921         objfile_compunits.
8922         * ada-lang.c (ada_collect_symbol_completion_matches)
8923         (ada_add_global_exceptions): Use objfile_compunits.
8924
8925 2019-01-09  Tom Tromey  <tom@tromey.com>
8926
8927         * source.c (select_source_symtab)
8928         (forget_cached_source_info_for_objfile): Remove declaration.
8929         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8930         declaration.
8931         * maint.c (count_symtabs_and_blocks): Remove declaration.
8932         * cp-support.c (add_symbol_overload_list_qualified): Remove
8933         declaration.
8934         * coffread.c (coff_symtab_read): Remove declaration.
8935         * symtab.c (lookup_symbol_in_objfile_symtabs)
8936         (basic_lookup_transparent_type_1): Use objfile_compunits.
8937         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8938         (info_sources_command, search_symbols)
8939         (default_collect_symbol_completion_matches_break_on)
8940         (make_source_files_completion_list): Remove declaration.
8941         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8942         (ada_collect_symbol_completion_matches)
8943         (ada_add_global_exceptions): Remove declaration.
8944         * linespec.c (iterate_over_all_matching_symtabs): Use
8945         objfile_compunits.
8946         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8947         (class objfile_compunits): New.
8948         (ALL_COMPUNITS): Use objfile_compunits.
8949         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8950         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8951         objfile_compunits.
8952         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8953
8954 2019-01-09  Tom Tromey  <tom@tromey.com>
8955
8956         * symtab.c (search_symbols)
8957         (default_collect_symbol_completion_matches_break_on): Use
8958         objfile_msymbols.
8959         * ada-lang.c (ada_lookup_simple_minsym)
8960         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8961         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8962         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8963         objfile_msymbols.
8964         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8965         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8966         * objc-lang.c (find_methods): Use objfile_msymbols.
8967         (info_selectors_command, info_classes_command): Likewise.
8968         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8969         * objfiles.h (class objfile_msymbols): New.
8970         (ALL_OBJFILE_MSYMBOLS): Remove.
8971         (ALL_MSYMBOLS): Remove.
8972
8973 2019-01-09  Tom Tromey  <tom@tromey.com>
8974
8975         * common/next-iterator.h (next_adapter): Add Iterator template
8976         parameter.
8977         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8978         (class all_objfiles_safe): New.
8979         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8980         * objfiles.c (put_objfile_before): Update comment.
8981         (add_separate_debug_objfile): Likewise.
8982         (free_all_objfiles): Use all_objfiles_safe.
8983         (objfile_purge_solibs): Likewise.
8984
8985 2019-01-09  Tom Tromey  <tom@tromey.com>
8986
8987         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8988         (expand_symtab_containing_pc, lookup_static_symbol)
8989         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8990         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8991         all_objfiles.
8992         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8993         * breakpoint.c (create_overlay_event_breakpoint)
8994         (create_longjmp_master_breakpoint)
8995         (create_std_terminate_master_breakpoint)
8996         (create_exception_master_breakpoint): Use all_objfiles.
8997         * linux-thread-db.c (try_thread_db_load_from_pdir)
8998         (has_libpthread): Use all_objfiles.
8999         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9000         * linespec.c (iterate_over_all_matching_symtabs)
9001         (search_minsyms_for_name): Use all_objfiles.
9002         * maint.c (maintenance_info_sections): Use all_objfiles.
9003         * main.c (captured_main_1): Use all_objfiles.
9004         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9005         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9006         * guile/scm-pretty-print.c
9007         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9008         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9009         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9010         (maintenance_print_msymbols): Use all_objfiles.
9011         * source.c (select_source_symtab): Use all_objfiles.
9012         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9013         * symfile.c (remove_symbol_file_command)
9014         (expand_symtabs_matching, map_symbol_filenames): Use
9015         all_objfiles.
9016         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9017         all_objfiles.
9018         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9019         * objc-lang.c (find_methods): Use all_objfiles.
9020         * objfiles.c (have_partial_symbols, have_full_symbols)
9021         (have_minimal_symbols, qsort_cmp)
9022         (default_iterate_over_objfiles_in_search_order): Use
9023         all_objfiles.
9024         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9025         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9026         (maintenance_check_psymtabs): Use all_objfiles.
9027         (ALL_PSYMTABS): Remove.
9028         * compile/compile-object-run.c (do_module_cleanup): Use
9029         all_objfiles.
9030         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9031         * cp-support.c (add_symbol_overload_list_qualified): Use
9032         all_objfiles.
9033         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9034         Use all_objfiles.
9035         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9036         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9037         all_objfiles.
9038         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9039         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9040         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9041         Uses all_objfiles.
9042         * solib.c (solib_read_symbols): Use all_objfiles
9043
9044 2019-01-09  Tom Tromey  <tom@tromey.com>
9045
9046         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9047         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9048         all_objfiles.
9049         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9050         * symmisc.c (print_symbol_bcache_statistics)
9051         (print_objfile_statistics, maintenance_print_objfiles)
9052         (maintenance_info_symtabs, maintenance_check_symtabs)
9053         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9054         all_objfiles.
9055         * source.c (forget_cached_source_info): Use all_objfiles.
9056         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9057         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9058         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9059         * objfiles.c (update_section_map): Use all_objfiles.
9060         (shared_objfile_contains_address_p): Likewise.
9061         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9062         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9063
9064 2019-01-09  Tom Tromey  <tom@tromey.com>
9065
9066         * common/next-iterator.h: New file.
9067         * objfiles.h (class all_objfiles): New.
9068         (struct objfile_iterator): New.
9069
9070 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9071
9072         * NEWS: Move the description of the changed "frame", "select-frame",
9073          and "info frame" commands to the Changed commands section.
9074
9075 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9076
9077         * gdbtypes.c (check_stub_method_group): Remove handling of old
9078         mangling schemes.
9079         * linespec.c (find_methods): Likewise.
9080         * stabsread.c (read_member_functions): Likewise.
9081         * valops.c (search_struct_method): Likewise.
9082         (value_struct_elt_for_reference): Likewise.
9083         * NEWS: Mention this change.
9084
9085 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9086
9087         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9088         print_source_lines.
9089         * source.c (print_source_lines_base): Update line number check.
9090         (print_source_lines): New function.
9091         (source_lines_range::source_lines_range): New function.
9092         * source.h (class source_lines_range): New class.
9093         (print_source_lines): New declaration.
9094
9095 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9096
9097         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9098
9099 2019-01-08  Tom Tromey  <tom@tromey.com>
9100             Simon Marchi  <simon.marchi@ericsson.com>
9101
9102         PR gdb/24060
9103         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9104         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9105         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9106         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9107         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9108         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9109
9110 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9111
9112         * source.c (select_source_symtab): Move header comment to
9113         declaration in source.h.
9114         (forget_cached_source_info_for_objfile): Likewise.
9115         (forget_cached_source_info): Likewise.
9116         (identify_source_line): Likewise.
9117         * source.h (identify_source_line): Move declaration from symtab.h
9118         and add comment from source.c
9119         (print_source_lines): Likewise.
9120         (forget_cached_source_info_for_objfile): Likewise.
9121         (forget_cached_source_info): Likewise.
9122         (select_source_symtab): Likewise.
9123         (enum print_source_lines_flag): Move definition from symtab.h.
9124         * symtab.h (identify_source_line): Move declaration to source.h.
9125         (print_source_lines): Likewise.
9126         (forget_cached_source_info_for_objfile): Likewise.
9127         (forget_cached_source_info): Likewise.
9128         (select_source_symtab): Likewise.
9129         (enum print_source_lines_flag): Move definition to source.h.
9130         * tui/tui-hooks.c: Add 'source.h' include.
9131
9132 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9133
9134         * source.c (print_source_lines_base): Handle requests to print
9135         reverse line number sequences, and guard against empty lines
9136         string.
9137
9138 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9139
9140         * source.c (print_source_lines_base): Fix skip of '\r' if next
9141         character is '\n'.
9142
9143 2019-01-06  Tom Tromey  <tom@tromey.com>
9144
9145         * c-exp.y (struct c_parse_state) <macro_original_text,
9146         expansion_obstack>: New member.
9147         (macro_original_text, expansion_obstack): Remove globals.
9148         (scan_macro_expansion, scanning_macro_expansion)
9149         (finished_macro_expansion): Update.
9150         (scan_macro_cleanup): Remove.
9151         (yylex, c_parse): Update.
9152
9153 2019-01-06  Tom Tromey  <tom@tromey.com>
9154
9155         * c-exp.y (struct c_parse_state) <strings>: New member.
9156         (operator_stoken): Update.
9157
9158 2019-01-06  Tom Tromey  <tom@tromey.com>
9159
9160         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9161         (union type_stack_elt) <typelist_val>: Now a pointer to
9162         std::vector.
9163         (type_stack_cleanup): Don't declare.
9164         (push_typelist): Update.
9165         * parse.c (pop_typelist): Return a std::vector.
9166         (push_typelist): Take a std::vector.
9167         (follow_types): Update.  Do not free args.
9168         (type_stack_cleanup): Remove.
9169         * c-exp.y (struct c_parse_state): New.
9170         (cpstate): New global.
9171         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9172         (nonempty_typelist): Update.
9173         (func_mod): Create a new vector.
9174         (c_parse): Create a c_parse_state.
9175         (check_parameter_typelist): Do not delete params.
9176         (function_method): Update.  Do not delete type_list.
9177
9178 2019-01-06  Tom Tromey  <tom@tromey.com>
9179
9180         PR gdb/28155:
9181         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9182         check_typedef.
9183         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9184         (print_return_value): Likewise.
9185
9186 2019-01-05  Tom Tromey  <tom@tromey.com>
9187
9188         * contrib/cleanup_check.py: Remove.
9189         * contrib/gcc-with-excheck: Remove.
9190         * contrib/exsummary.py: Remove.
9191         * contrib/excheck.py: Remove.
9192
9193 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9194
9195         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9196         NULL. Initialize tpprev to NULL instead of assigning it
9197         to NULL on the next statement.
9198         * windows-nat.c (windows_delete_thread): Remove check for
9199         main_thread_id before printing thread exit notifications.
9200         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9201         Remove thread ID check against main_thread_id.
9202         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9203         windows_delete_thread.
9204         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9205
9206 2019-01-04  Tom Tromey  <tom@tromey.com>
9207
9208         * compile/compile.c (_initialize_compile): Use upper case for
9209         metasyntactic variables.
9210         * symmisc.c (_initialize_symmisc): Use upper case for
9211         metasyntactic variables.
9212         * psymtab.c (_initialize_psymtab): Use upper case for
9213         metasyntactic variables.
9214         * demangle.c (demangle_command): Use upper case for metasyntactic
9215         variables.
9216         (_initialize_demangler): Likewise.
9217         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9218         variables.
9219
9220 2019-01-03  Tom Tromey  <tom@tromey.com>
9221
9222         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9223
9224 2019-01-03  Tom Tromey  <tom@tromey.com>
9225
9226         * python/py-symtab.c (salpy_str): Update.
9227         (struct salpy_sal_object) <symtab>: Now a PyObject.
9228         (salpy_dealloc): Update.
9229         (del_objfile_sal): Use gdbpy_ref.
9230
9231 2019-01-03  Tom Tromey  <tom@tromey.com>
9232
9233         * python/py-type.c (convert_field): Use new_reference.  Return
9234         gdbpy_ref.
9235         (make_fielditem): Return gdbpy_ref.
9236         (typy_fields): Update.
9237         (typy_getitem): Update.
9238         (field_name): Return gdbpy_ref.  Use new_reference.
9239         (typy_iterator_iternext): Update.
9240
9241 2019-01-03  Tom Tromey  <tom@tromey.com>
9242
9243         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9244
9245 2019-01-03  Tom Tromey  <tom@tromey.com>
9246
9247         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9248         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9249         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9250         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9251         (pspy_set_type_printers): Likewise.
9252         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9253         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9254         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9255         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9256         (objfpy_set_type_printers): Likewise.
9257
9258 2019-01-03  Tom Tromey  <tom@tromey.com>
9259
9260         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9261         (gdbpy_print_stack): Use gdbpy_err_fetch.
9262         * python/python-internal.h (class gdbpy_err_fetch): New class.
9263         (class gdbpy_enter) <m_error_type, m_error_value,
9264         m_error_traceback>: Remove.
9265         <m_error>: New member.
9266         (gdbpy_exception_to_string): Don't declare.
9267         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9268         * python/py-value.c (convert_value_from_python): Use
9269         gdbpy_err_fetch.
9270         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9271         gdbpy_exception_to_string.
9272         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9273         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9274         gdbpy_err_fetch.
9275
9276 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9277
9278         * linux-nat.c (delete_lwp_cleanup): Delete.
9279         (struct lwp_deleter): New struct.
9280         (lwp_info_up): New typedef.
9281         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9282         lwp_info_up.
9283
9284 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9285
9286         * linux-fork.c (class scoped_switch_fork_info): New class.
9287         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9288
9289 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9290
9291         * valops.c (find_overload_match): Remove use of null_cleanup, and
9292         calls to do_cleanups.
9293
9294 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9295
9296         * compile/compile-cplus-types.c
9297         (compile_cplus_instance::decl_name): Handle changes to
9298         cp_func_name.
9299         * cp-support.c (cp_func_name): Update header comment, update
9300         return type.
9301         * cp-support.h (cp_func_name): Update return type in declaration.
9302         * valops.c (find_overload_match): Move temp_func local to top
9303         level of function and change its type.  Use temp_func to hold and
9304         delete temporary string obtained from cp_func_name.
9305
9306 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9307
9308         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9309         gdb::char_vector, remove cleanup, and update uses of `msg`.
9310
9311 2019-01-03  Jim Wilson  <jimw@sifive.com>
9312
9313         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9314
9315 2019-01-02  Tom Tromey  <tom@tromey.com>
9316
9317         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9318         (tdesc_parse_xml): Remove cleanups.
9319         * target-descriptions.h (make_cleanup_free_target_description):
9320         Don't declare.
9321         (target_desc_deleter): New struct.
9322         (target_desc_up): New typedef.
9323         * target-descriptions.c (target_desc_deleter::operator()): Rename
9324         from free_target_description.
9325         (make_cleanup_free_target_description): Remove.
9326
9327 2019-01-02  Tom Tromey  <tom@tromey.com>
9328
9329         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9330         constructor, destructor.
9331         (linespec_parser): Remove typedef.
9332         (~linespec_parser): Rename from linespec_parser_delete.
9333         (linespec_lex_to_end, linespec_complete_label)
9334         (linespec_complete): Update.
9335         (decode_line_full): Remove cleanups.
9336         (decode_line_1): Update.
9337
9338 2019-01-02  Tom Tromey  <tom@tromey.com>
9339
9340         * python/python-internal.h (inferior_to_inferior_object): Change
9341         return type.
9342         * python/py-exitedevent.c (create_exited_event_object): Update.
9343         * python/py-inferior.c (inferior_to_inferior_object): Return
9344         gdbpy_ref.
9345         (python_new_inferior, python_inferior_deleted)
9346         (thread_to_thread_object, delete_thread_object)
9347         (build_inferior_list, gdbpy_selected_inferior): Update.
9348         * python/py-infthread.c (create_thread_object): Update.  Also fail
9349         if inferior_to_inferior_object fails.
9350
9351 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9352
9353         * inferior.h (class inferior) <displaced_step_state>: New field.
9354         * infrun.h (struct displaced_step_state): Move here from
9355         infrun.c.  Initialize fields, add constructor.
9356         <inf>: Remove field.
9357         <reset>: New method.
9358         * infrun.c (struct displaced_step_inferior_state): Move to
9359         infrun.h.
9360         (displaced_step_inferior_states): Remove.
9361         (get_displaced_stepping_state): Adust.
9362         (displaced_step_in_progress_any_inferior): Adjust.
9363         (displaced_step_in_progress_thread): Adjust.
9364         (displaced_step_in_progress): Adjust.
9365         (add_displaced_stepping_state): Remove.
9366         (get_displaced_step_closure_by_addr): Adjust.
9367         (remove_displaced_stepping_state): Remove.
9368         (infrun_inferior_exit): Call displaced_step_state.reset.
9369         (use_displaced_stepping): Don't check for NULL.
9370         (displaced_step_prepare_throw): Call
9371         get_displaced_stepping_state.
9372         (displaced_step_fixup): Don't check for NULL.
9373         (prepare_for_detach): Don't check for NULL.
9374
9375 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9376
9377         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9378          in case of call that did not complete.
9379
9380 2019-01-02  Andrey Utkin  <autkin@undo.io>
9381
9382         * symfile.c (find_separate_debug_file): Fix search of debug files for
9383         remote debuggee.
9384
9385 2019-01-02  Tom Tromey  <tom@tromey.com>
9386
9387         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9388         indentation.
9389         * python/py-frame.c (frapy_older): Remove cast.
9390         (frapy_newer): Likewise.
9391         * python/py-breakpoint.c (local_setattro): Remove cast.
9392         * python/py-arch.c (archpy_name): Remove local variable.
9393         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9394
9395 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9396
9397         * unittests/basic_string_view/element_access/char/empty.cc:
9398         Fix year range in copyright header.
9399
9400 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9401
9402         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9403         Delete.
9404         <operator==>: Update with for removed field.
9405         <hash>: Likewise.
9406         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9407         <isa_features>: ...this.
9408         <abi_features>: New field.
9409         (riscv_isa_flen): Update comment.
9410         (riscv_abi_xlen): New declaration.
9411         (riscv_abi_flen): New declaration.
9412         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9413         isa_features.
9414         (riscv_abi_xlen): New function.
9415         (riscv_isa_flen): Update to get answer from isa_features.
9416         (riscv_abi_flen): New function.
9417         (riscv_has_fp_abi): Update to get answer from abi_features.
9418         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9419         xlen and flen.
9420         (riscv_call_info) <xlen, flen>: Update comment.
9421         (riscv_call_arg_struct): Remove invalid assertions
9422         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9423         is removed.
9424         (riscv_gdbarch_init): Gather isa features and abi features
9425         separately, ensure both match on the gdbarch when reusing an old
9426         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9427         a target with 64-bit float hardware.
9428
9429 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9430
9431         * source.c (search_command_helper): Stop reverse search
9432         when line 1 has been searched.
9433
9434 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9435
9436         * record-full.c (record_full_base_target::close): Rewrite
9437         record_full_core_buf_list free logic.
9438
9439 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9440
9441         * break-catch-syscall.c (print_one_catch_syscall): xfree
9442         the last text.
9443
9444 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9445
9446         * top.c (print_gdb_version): Update Copyright year in version
9447         message.
9448
9449 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9450
9451         Update copyright year range in all GDB files.
9452
9453 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9454
9455         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9456
9457 For older changes see ChangeLog-2018.
9458 \f
9459 Local Variables:
9460 mode: change-log
9461 left-margin: 8
9462 fill-column: 74
9463 version-control: never
9464 coding: utf-8
9465 End:
9466