Fix use-after-free in source_cache::get_source_lines
[external/binutils.git] / gdb / ChangeLog
1 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2
3         * source-cache.c (source_cache::get_source_lines): Re-read
4         fullname after calling open_source_file.
5
6 2019-03-18  Pedro Alves  <palves@redhat.com>
7             Eli Zaretskii <eliz@gnu.org>
8
9         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10         m_line and m_start_of_line.
11
12 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13
14         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
15         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
16         it returns a newline.  This fixes a regression in TU mode, whereby
17         the next line is output on the same screen line as the user input.
18
19 2019-03-18  Pedro Alves  <palves@redhat.com>
20
21         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
22         New globals.
23         (apply_style): New, factored out from ...
24         (apply_ansi_escape): ... this.  Handle reverse video mode.
25         (tui_set_reverse_mode): New function.
26         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
27         * tui/tui-winsource.c (tui_show_source_line): Use
28         tui_set_reverse_mode instead of setting A_STANDOUT.
29         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
30         New setter methods.
31
32 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
33
34         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
35         Handle tabs.
36
37 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
38
39         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
40         tui_refill_source_window instead of tui_refresh_win, to update the
41         current execution line.  This fixes redisplay of the current line
42         when stepping through the code with "next" or "step".
43
44 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
45
46         * source-cache.c (source_cache::get_source_lines): Call
47         find_source_lines to initialize s->nlines.  This fixes vertical
48         scrolling of TUI source window when the DOWN arrow is pressed.
49
50 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
51
52         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
53         wclrtoeol in tui_show_source_line".  This reverts changes made in
54         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
55
56 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
57
58         * NEWS: Combine separate "New targets" sections for 8.3.
59
60 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
61
62         The MS-Windows port of ncurses fails to switch to a color pair if
63         one or both of the colors are the implicit default colors.  This
64         change records the default colors when TUI is initialized, and
65         then specifies them explicitly when a color pair uses the default
66         colors.  This allows color styling in TUI mode on MS-Windows.
67
68         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
69         ncurses_norm_attr.
70         (tui_initialize_io) [__MINGW32__]: Record the default terminal
71         colors in ncurses_norm_attr.
72         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
73         "none", replace it with the default color recorded in
74         ncurses_norm_attr.
75
76 2019-03-14  Tom Tromey  <tromey@adacore.com>
77
78         * source-cache.h (class source_cache) <get_source_lines>: Return
79         std::string.
80         * source-cache.c (source_cache::extract_lines): Handle case where
81         first_pos==npos.  Return std::string.
82         (source_cache::get_source_lines): Update.
83
84 2019-03-14  Tom Tromey  <tromey@adacore.com>
85
86         * NEWS: Add item for "style sources" commands.
87         * source-cache.c (source_cache::get_source_lines): Check
88         source_styling.
89         * cli/cli-style.c (source_styling): New global.
90         (_initialize_cli_style): Add "style sources" commands.
91         (show_style_sources): New function.
92         * cli/cli-style.h (source_styling): Declare.
93
94 2019-03-14  Pedro Alves  <palves@redhat.com>
95             Tom Tromey  <tromey@adacore.com>
96
97         * tui/tui-winsource.h (tui_refill_source_window): Declare.
98         * tui/tui-winsource.c (tui_refill_source_window): New function,
99         from...
100         (tui_horizontal_source_scroll): ... here.  Move some logic.
101         * cli/cli-style.c (set_style_enabled): Notify new observable.
102         * tui/tui-hooks.c (tui_redisplay_source): New function.
103         (tui_attach_detach_observers): Attach or detach
104         tui_redisplay_source.
105         * observable.h (source_styling_changed): New observable.
106         * observable.c: Define source_styling_changed observable.
107
108 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
109
110         PR/24325
111         * source-cache.c: #undef open and close, to avoid unresolved
112         externals during linking.
113
114 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
115
116         Support styling on native MS-Windows console
117
118         PR/24315
119         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
120         on MS-Windows if $TERM is not defined.
121
122         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
123
124         * posix-hdep.c (gdb_console_fputs):
125         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
126         functions.
127         * ui-file.h (gdb_console_fputs): Add prototype.
128
129         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
130         back to fputs only if the former returns zero.
131
132 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
133             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
134
135         PR gdb/8527
136         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
137         set_sigint_trap, clear_sigint_trap.
138
139 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
140
141         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
142         for-loop range, to avoid compiler warnings.
143
144         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
145         avoid compiler warnings about unused variables.
146
147 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
148
149         * NEWS: Mention end of support for native debugging on MS-Windows
150         before XP.
151
152 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
153
154         PR gdb/24292
155         * common/netstuff.c:
156         * gdbserver/gdbreplay.c
157         * gdbserver/remote-utils.c:
158         * ser-tcp.c:
159         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
160         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
161         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
162         'getaddrinfo' and 'freeaddrinfo' were not available before
163         Windows XP, and mingw.org's MinGW headers by default define
164         _WIN32_WINNT to 0x500.
165
166 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
167     
168         * NEWS: Note minimum Python version.
169
170 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
171
172         * version.in: Set GDB version number to 8.2.90.DATE-git.
173
174 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
175
176         GDB 8.2.90 released.
177
178 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
179
180         * version.in: Set GDB version number to 8.2.90.
181
182 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
183
184         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
185
186 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
187
188         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
189         * version.in: Bump version to 8.2.90.DATE-git.
190
191 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
192
193         * aix-thread.c (ptid_cmp): Remove unused variable.
194         (get_signaled_thread): Likewise.
195         (store_regs_user_thread): Likewise.
196         (store_regs_kernel_thread): Likewise.
197         (fetch_regs_kernel_thread): Remove shadowed variable.
198
199 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
200
201         * features/riscv/32bit-cpu.xml: Add register numbers.
202         * features/riscv/32bit-fpu.c: Regenerate.
203         * features/riscv/32bit-fpu.xml: Add register numbers.
204         * features/riscv/64bit-cpu.xml: Add register numbers.
205         * features/riscv/64bit-fpu.c: Regenerate.
206         * features/riscv/64bit-fpu.xml: Add register numbers.
207
208 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
209
210         * NEWS: Mention two argument form of gdb.Value constructor.
211         * python/py-value.c (convert_buffer_and_type_to_value): New
212         function.
213         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
214         Add support for handling an optional second argument.  Call
215         convert_buffer_and_type_to_value as appropriate.
216         * python/python-internal.h (Py_buffer_deleter): New struct.
217         (Py_buffer_up): New typedef.
218
219 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
220
221         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
222         instead of releasing ownership.
223
224 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
225
226         * dwarf2read.c (open_and_init_dwp_file): Call
227         elf_numsections instead of bfd_count_sections to initialize
228         dwp_file->num_sections.
229
230 2019-02-25  Tom Tromey  <tromey@adacore.com>
231
232         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
233
234 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
235
236         * gcore.in: Add '--readnever' option when invoking GDB.
237
238 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
239
240         * MAINTAINERS: Update my email address.
241
242 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
243
244         * build-id.c (build_id_to_debug_bfd_1): New function.
245         (build_id_to_debug_bfd): Look for separate debug file in
246         sysroot.
247
248 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
249
250         * gdbarch.sh: Update the copyright year range that is placed into
251         generated files.
252
253 2019-02-22  Keith Seitz  <keiths@redhat.com>
254
255         PR symtab/23853
256         * linespec.c (create_sals_line_offset): Search for the default
257         symtab's filename instead of its fullname.
258
259 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
260
261         * NEWS: Update style defaults.
262
263 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
264
265         * main.c (captured_main_1): Disable styling in batch mode.
266
267 2019-02-20  Tom Tromey  <tom@tromey.com>
268
269         * symtab.c (symtab_symbol_info): Fix typos.
270
271 2019-02-20  Tom Tromey  <tromey@adacore.com>
272
273         * findcmd.c (_initialize_mem_search): Use upper case for
274         metasyntactic variables.
275
276 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
277
278         * aarch64-tdep.c (aarch64_add_reggroups): New function.
279         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
280
281 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
282
283         * top.h (source_file_name): Change to std::string.
284         * top.c (source_file_name): Likewise.
285         (command_line_input): Adjust.
286         * cli/cli-script.c (script_from_file): Adjust.
287
288 2019-02-19  Tom Tromey  <tromey@adacore.com>
289
290         * ravenscar-thread.c
291         (ravenscar_thread_target::update_thread_list): Don't call
292         ada_build_task_list.
293         * ada-lang.h (ada_build_task_list): Don't declare.
294         * ada-tasks.c (struct ada_tasks_inferior_data)
295         <task_list_valid_p>: Now bool.
296         (read_known_tasks, ada_task_list_changed)
297         (ada_tasks_invalidate_inferior_data): Update.
298         (read_known_tasks_array): Return bool.
299         (read_known_tasks_list): Likewise.
300         (read_known_tasks): Return void.
301         (ada_build_task_list): Now static.
302
303 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
304
305         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
306         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
307
308 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
309
310         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
311         variant for ada_tasks_pspace_data_handle and
312         ada_tasks_inferior_data_handle.
313         (ada_tasks_pspace_data_cleanup): New function.
314         (ada_tasks_inferior_data_cleanup): New function.
315
316 2019-02-17  Tom Tromey  <tom@tromey.com>
317
318         * macrotab.h (macro_source_fullname): Return a std::string.
319         * macrotab.c (macro_include, check_for_redefinition)
320         (macro_undef, macro_lookup_definition, foreach_macro)
321         (foreach_macro_in_scope): Update.
322         (macro_source_fullname): Return a std::string.
323         * macrocmd.c (show_pp_source_pos): Update.
324
325 2019-02-17  Tom Tromey  <tom@tromey.com>
326
327         * macrocmd.c (show_pp_source_pos): Style the file names.
328
329 2019-02-17  Tom Tromey  <tom@tromey.com>
330
331         PR tui/24197:
332         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
333
334 2019-02-17  Tom Tromey  <tom@tromey.com>
335
336         * ada-lang.c (user_select_syms): Use filtered printing.
337         * utils.c (wrap_style): New global.
338         (desired_style): Remove.
339         (emit_style_escape): Add stream parameter.
340         (set_output_style, reset_terminal_style, prompt_for_continue):
341         Update.
342         (flush_wrap_buffer): Only flush gdb_stdout.
343         (wrap_here): Set wrap_style.
344         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
345         treat escape sequences as a character.  Change when wrap buffer is
346         flushed.
347         (fputs_styled): Do not set the output style when the default is
348         requested.
349         * ui-style.h (struct ui_file_style) <is_default>: New method.
350         * source.c (print_source_lines_base): Emit escape sequences in one
351         piece.
352
353 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
354
355         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
356         integers and enumeration types.
357
358 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
359
360         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
361         instead of lookup_symbol_in_language
362         (do_exact_match): New function.
363         (ada_get_symbol_name_matcher): Return do_exact_match when
364         doing a verbatim match.
365
366 2019-02-15  Tom Tromey  <tromey@adacore.com>
367
368         * ravenscar-thread.c (ravenscar_thread_target::resume)
369         (ravenscar_thread_target::wait): Special case wildcard requests.
370
371 2019-02-15  Tom Tromey  <tromey@adacore.com>
372
373         * ravenscar-thread.c (base_ptid): Remove.
374         (struct ravenscar_thread_target) <close>: New method.
375         <m_base_ptid>: New member.
376         <update_inferior_ptid, active_task, task_is_currently_active,
377         runtime_initialized>: Declare methods.
378         <ravenscar_thread_target>: Add constructor.
379         (ravenscar_thread_target::task_is_currently_active)
380         (ravenscar_thread_target::update_inferior_ptid)
381         (ravenscar_runtime_initialized): Rename.  Now methods.
382         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
383         (ravenscar_thread_target::update_thread_list): Update.
384         (ravenscar_thread_target::active_task): Now method.
385         (ravenscar_thread_target::store_registers)
386         (ravenscar_thread_target::prepare_to_store)
387         (ravenscar_thread_target::prepare_to_store)
388         (ravenscar_thread_target::mourn_inferior): Update.
389         (ravenscar_inferior_created): Use "new" to create target.
390         (ravenscar_thread_target::get_ada_task_ptid): Update.
391         (_initialize_ravenscar): Don't initialize base_ptid.
392         (ravenscar_ops): Remove global.
393
394 2019-02-15  Tom Tromey  <tromey@adacore.com>
395
396         * target.h (push_target): Declare new overload.
397         * target.c (push_target): New overload, taking an rvalue reference.
398         * remote.c (remote_target::open_1): Use push_target overload.
399         * corelow.c (core_target_open): Use push_target overload.
400
401 2019-02-15  Tom Tromey  <tromey@adacore.com>
402
403         * ravenscar-thread.c (is_ravenscar_task)
404         (ravenscar_task_is_currently_active): Return bool.
405         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
406         (_initialize_ravenscar): Remove "(void)".
407         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
408         Return bool.
409
410 2019-02-15  Tom Tromey  <tromey@adacore.com>
411
412         * ravenscar-thread.c (ravenscar_runtime_initializer)
413         (has_ravenscar_runtime, get_running_thread_id)
414         (ravenscar_thread_target::resume): Fix indentation.
415
416 2019-02-15  Tom Tromey  <tromey@adacore.com>
417
418         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
419         from ravenscar_arch_ops.
420         (sparc_ravenscar_ops::fetch_registers)
421         (sparc_ravenscar_ops::store_registers): Now methods.
422         (sparc_ravenscar_prepare_to_store): Remove.
423         (sparc_ravenscar_ops): Redefine.
424         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
425         methods and destructor.  Remove members.
426         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
427         (ravenscar_thread_target::store_registers)
428         (ravenscar_thread_target::prepare_to_store): Update.
429         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
430         Remove.
431         (struct ppc_ravenscar_powerpc_ops): Derive from
432         ravenscar_arch_ops.
433         (ppc_ravenscar_powerpc_ops::fetch_registers)
434         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
435         (ppc_ravenscar_powerpc_ops): Redefine.
436         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
437         (ppc_ravenscar_e500_ops::fetch_registers)
438         (ppc_ravenscar_e500_ops::store_registers): Now methods.
439         (ppc_ravenscar_e500_ops): Redefine.
440         * aarch64-ravenscar-thread.c
441         (aarch64_ravenscar_generic_prepare_to_store): Remove.
442         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
443         (aarch64_ravenscar_fetch_registers)
444         (aarch64_ravenscar_store_registers): Now methods.
445         (aarch64_ravenscar_ops): Redefine.
446
447 2019-02-15  Tom Tromey  <tromey@adacore.com>
448
449         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
450         (ravenscar_thread_target::stopped_by_hw_breakpoint)
451         (ravenscar_thread_target::stopped_by_watchpoint)
452         (ravenscar_thread_target::stopped_data_address)
453         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
454
455 2019-02-15  Tom Tromey  <tromey@adacore.com>
456
457         * ravenscar-thread.c: Fix some typos.
458
459 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
460             Tom Tromey  <tromey@adacore.com>
461
462         * ada-lang.c (ada_exception_sal): Change addr_string to a
463         std::string.
464         (create_ada_exception_catchpoint): Update.
465
466 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
467             Tom Tromey  <tromey@adacore.com>
468
469         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
470         (bp_location_ops): Remove.
471         (base_breakpoint_allocate_location): Update.
472         (free_bp_location): Update.
473         * ada-lang.c (class ada_catchpoint_location)
474         <ada_catchpoint_location>: Remove ops parameter.
475         (ada_catchpoint_location_dtor): Remove.
476         (ada_catchpoint_location_ops): Remove.
477         (allocate_location_exception): Update.
478         * breakpoint.h (struct bp_location_ops): Remove.
479         (class bp_location) <bp_location>: Remove bp_location_ops
480         parameter.
481         <~bp_location>: Add destructor.
482         <ops>: Remove.
483
484 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
485             Pedro Alves  <palves@redhat.com>
486
487         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
488         'PATH_MAX'.
489
490 2019-02-14  David Michael  <fedora.dm0@gmail.com>
491             Samuel Thibault  <samuel.thibault@gnu.org>
492             Thomas Schwinge  <thomas@codesourcery.com>
493
494         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
495         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
496
497 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
498
499         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
500         (check_empty): Use "const char *".
501
502         * gnu-nat.c (gnu_nat_target::detach): Instead of
503         'detach_inferior (pid)' call
504         'detach_inferior (find_inferior_pid (pid))'.
505
506         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
507         'nat/fork-inferior.o'.
508         * gnu-nat.c: #include "nat/fork-inferior.h".
509
510         * gnu-nat.c (gnu_nat_target::detach): Instead of
511         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
512         * gnu-nat.h: #include "inf-child.h".
513         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
514         'i386_gnu_nat_target::fetch_registers'.
515         (gnu_store_registers): Rename/move to
516         'i386_gnu_nat_target::store_registers'.
517
518         * config/i386/nm-i386gnu.h: Don't "#include" any files.
519         * gnu-nat.h (mach_thread_info): New function.
520         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
521
522         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
523
524 2019-02-14  Frederic Konrad  <konrad@adacore.com>
525
526         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
527
528 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
529
530         * windows-nat.c (windows_add_thread): Add new parameter
531         "main_thread_p" with default value set to false.  Update
532         function documentation as well as all callers.
533         (windows_delete_thread): Likewise.
534         (fake_create_process): Update call to windows_add_thread.
535         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
536         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
537         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
538         call to windows_delete_thread.
539
540 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
541
542         * MAINTAINERS: Add Andrew Burgess as global maintainer.
543
544 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
545
546         * symfile.c (find_separate_debug_file): Use canonical path of
547         sysroot with child_path instead of gdb_sysroot if it is valid.
548
549 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
550
551         * symfile.c (find_separate_debug_file): Use child_path to
552         determine if an object file is under a sysroot.
553
554 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
555
556         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
557         unittests/child-path-selftests.c.
558         * common/pathstuff.c (child_path): New function.
559         * common/pathstuff.h (child_path): New prototype.
560         * unittests/child-path-selftests.c: New file.
561
562 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
563
564         * symfile.c (find_separate_debug_file): Look for separate debug
565         files in debug directories under the sysroot.
566
567 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
568
569         * symtab.h (struct minimal_symbol data_p): New const method.
570         (struct minimal_symbol text_p): Likewise.
571         * symtab.c (output_source_filename): Use file name style
572         to print file name.
573         (print_symbol_info): Likewise.
574         (print_msymbol_info): Use address style to print addresses.
575         Use function name style to print executable text symbols.
576         (expand_symtab_containing_pc): Use data_p.
577         (find_pc_sect_compunit_symtab): Likewise.
578
579 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
580
581         * breakpoint.c (describe_other_breakpoints): Use address style
582         to print addresses.
583         (say_where): Likewise.
584
585 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
586
587         * ada-typeprint.c (print_func_type): Print function name
588         style to print function name.
589         * c-typeprint.c (c_print_type_1): Likewise.
590
591 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
592
593         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
594         for execve.
595
596 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
597
598         * c-exp.y (direct_abs_decl): Use emplace_back to record the
599         type_stack.
600
601 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
602
603         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
604         TYPE_CODE_REF types.
605
606 2019-02-08  Jim Wilson  <jimw@sifive.com>
607
608         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
609         (riscv_linux_fregset): New.
610         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
611
612 2019-02-07  Tom Tromey  <tom@tromey.com>
613
614         * thread.c (thread_cancel_execution_command): Update.
615         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
616         methods.
617         (struct thread_fsm_ops): Remove.
618         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
619         (thread_fsm_should_stop, thread_fsm_return_value)
620         (thread_fsm_set_finished, thread_fsm_finished_p)
621         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
622         Don't declare.
623         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
624         * infrun.c (clear_proceed_status_thread)
625         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
626         (print_stop_event): Update.
627         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
628         Add constructor.
629         (step_command_fsm_ops): Remove.
630         (new_step_command_fsm): Remove.
631         (step_1): Update.
632         (step_command_fsm::should_stop): Rename from
633         step_command_fsm_should_stop.
634         (step_command_fsm::clean_up): Rename from
635         step_command_fsm_clean_up.
636         (step_command_fsm::do_async_reply_reason): Rename from
637         step_command_fsm_async_reply_reason.
638         (struct until_next_fsm): Inherit from thread_fsm.  Add
639         constructor.
640         (until_next_fsm_ops): Remove.
641         (new_until_next_fsm): Remove.
642         (until_next_fsm::should_stop): Rename from
643         until_next_fsm_should_stop.
644         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
645         (until_next_fsm::do_async_reply_reason): Rename from
646         until_next_fsm_async_reply_reason.
647         (struct finish_command_fsm): Inherit from thread_fsm.  Add
648         constructor.  Change type of breakpoint.
649         (finish_command_fsm_ops): Remove.
650         (new_finish_command_fsm): Remove.
651         (finish_command_fsm::should_stop): Rename from
652         finish_command_fsm_should_stop.
653         (finish_command_fsm::clean_up): Rename from
654         finish_command_fsm_clean_up.
655         (finish_command_fsm::return_value): Rename from
656         finish_command_fsm_return_value.
657         (finish_command_fsm::do_async_reply_reason): Rename from
658         finish_command_fsm_async_reply_reason.
659         (finish_command): Update.
660         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
661         Add constructor.
662         (call_thread_fsm_ops): Remove.
663         (call_thread_fsm::call_thread_fsm): Rename from
664         new_call_thread_fsm.
665         (call_thread_fsm::should_stop): Rename from
666         call_thread_fsm_should_stop.
667         (call_thread_fsm::should_notify_stop): Rename from
668         call_thread_fsm_should_notify_stop.
669         (run_inferior_call, call_function_by_hand_dummy): Update.
670         * cli/cli-interp.c (should_print_stop_to_console): Update.
671         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
672         Add constructor.  Change type of location_breakpoint,
673         caller_breakpoint.
674         (until_break_fsm_ops): Remove.
675         (new_until_break_fsm): Remove.
676         (until_break_fsm::should_stop): Rename from
677         until_break_fsm_should_stop.
678         (until_break_fsm::clean_up): Rename from
679         until_break_fsm_clean_up.
680         (until_break_fsm::do_async_reply_reason): Rename from
681         until_break_fsm_async_reply_reason.
682         (until_break_command): Update.
683         * thread-fsm.c: Remove.
684         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
685
686 2019-02-07  Tom Tromey  <tom@tromey.com>
687
688         * yy-remap.h: Add include guard.
689         * xtensa-tdep.h: Add include guard.
690         * xcoffread.h: Rename include guard.
691         * varobj-iter.h: Add include guard.
692         * tui/tui.h: Rename include guard.
693         * tui/tui-winsource.h: Rename include guard.
694         * tui/tui-wingeneral.h: Rename include guard.
695         * tui/tui-windata.h: Rename include guard.
696         * tui/tui-win.h: Rename include guard.
697         * tui/tui-stack.h: Rename include guard.
698         * tui/tui-source.h: Rename include guard.
699         * tui/tui-regs.h: Rename include guard.
700         * tui/tui-out.h: Rename include guard.
701         * tui/tui-layout.h: Rename include guard.
702         * tui/tui-io.h: Rename include guard.
703         * tui/tui-hooks.h: Rename include guard.
704         * tui/tui-file.h: Rename include guard.
705         * tui/tui-disasm.h: Rename include guard.
706         * tui/tui-data.h: Rename include guard.
707         * tui/tui-command.h: Rename include guard.
708         * tic6x-tdep.h: Add include guard.
709         * target/waitstatus.h: Rename include guard.
710         * target/wait.h: Rename include guard.
711         * target/target.h: Rename include guard.
712         * target/resume.h: Rename include guard.
713         * target-float.h: Rename include guard.
714         * stabsread.h: Add include guard.
715         * rs6000-tdep.h: Add include guard.
716         * riscv-fbsd-tdep.h: Add include guard.
717         * regformats/regdef.h: Rename include guard.
718         * record.h: Rename include guard.
719         * python/python.h: Rename include guard.
720         * python/python-internal.h: Rename include guard.
721         * python/py-stopevent.h: Rename include guard.
722         * python/py-ref.h: Rename include guard.
723         * python/py-record.h: Rename include guard.
724         * python/py-record-full.h: Rename include guard.
725         * python/py-record-btrace.h: Rename include guard.
726         * python/py-instruction.h: Rename include guard.
727         * python/py-events.h: Rename include guard.
728         * python/py-event.h: Rename include guard.
729         * procfs.h: Add include guard.
730         * proc-utils.h: Add include guard.
731         * p-lang.h: Add include guard.
732         * or1k-tdep.h: Rename include guard.
733         * observable.h: Rename include guard.
734         * nto-tdep.h: Rename include guard.
735         * nat/x86-linux.h: Rename include guard.
736         * nat/x86-linux-dregs.h: Rename include guard.
737         * nat/x86-gcc-cpuid.h: Add include guard.
738         * nat/x86-dregs.h: Rename include guard.
739         * nat/x86-cpuid.h: Rename include guard.
740         * nat/ppc-linux.h: Rename include guard.
741         * nat/mips-linux-watch.h: Rename include guard.
742         * nat/linux-waitpid.h: Rename include guard.
743         * nat/linux-ptrace.h: Rename include guard.
744         * nat/linux-procfs.h: Rename include guard.
745         * nat/linux-osdata.h: Rename include guard.
746         * nat/linux-nat.h: Rename include guard.
747         * nat/linux-namespaces.h: Rename include guard.
748         * nat/linux-btrace.h: Rename include guard.
749         * nat/glibc_thread_db.h: Rename include guard.
750         * nat/gdb_thread_db.h: Rename include guard.
751         * nat/gdb_ptrace.h: Rename include guard.
752         * nat/fork-inferior.h: Rename include guard.
753         * nat/amd64-linux-siginfo.h: Rename include guard.
754         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
755         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
756         * nat/aarch64-linux.h: Rename include guard.
757         * nat/aarch64-linux-hw-point.h: Rename include guard.
758         * mn10300-tdep.h: Add include guard.
759         * mips-linux-tdep.h: Add include guard.
760         * mi/mi-parse.h: Rename include guard.
761         * mi/mi-out.h: Rename include guard.
762         * mi/mi-main.h: Rename include guard.
763         * mi/mi-interp.h: Rename include guard.
764         * mi/mi-getopt.h: Rename include guard.
765         * mi/mi-console.h: Rename include guard.
766         * mi/mi-common.h: Rename include guard.
767         * mi/mi-cmds.h: Rename include guard.
768         * mi/mi-cmd-break.h: Rename include guard.
769         * m2-lang.h: Add include guard.
770         * location.h: Rename include guard.
771         * linux-record.h: Rename include guard.
772         * linux-nat.h: Add include guard.
773         * linux-fork.h: Add include guard.
774         * i386-darwin-tdep.h: Rename include guard.
775         * hppa-linux-offsets.h: Add include guard.
776         * guile/guile.h: Rename include guard.
777         * guile/guile-internal.h: Rename include guard.
778         * gnu-nat.h: Rename include guard.
779         * gdb-stabs.h: Rename include guard.
780         * frv-tdep.h: Add include guard.
781         * f-lang.h: Add include guard.
782         * event-loop.h: Add include guard.
783         * darwin-nat.h: Rename include guard.
784         * cp-abi.h: Rename include guard.
785         * config/sparc/nm-sol2.h: Rename include guard.
786         * config/nm-nto.h: Rename include guard.
787         * config/nm-linux.h: Add include guard.
788         * config/i386/nm-i386gnu.h: Rename include guard.
789         * config/djgpp/nl_types.h: Rename include guard.
790         * config/djgpp/langinfo.h: Rename include guard.
791         * compile/gcc-cp-plugin.h: Add include guard.
792         * compile/gcc-c-plugin.h: Add include guard.
793         * compile/compile.h: Rename include guard.
794         * compile/compile-object-run.h: Rename include guard.
795         * compile/compile-object-load.h: Rename include guard.
796         * compile/compile-internal.h: Rename include guard.
797         * compile/compile-cplus.h: Rename include guard.
798         * compile/compile-c.h: Rename include guard.
799         * common/xml-utils.h: Rename include guard.
800         * common/x86-xstate.h: Rename include guard.
801         * common/version.h: Rename include guard.
802         * common/vec.h: Rename include guard.
803         * common/tdesc.h: Rename include guard.
804         * common/selftest.h: Rename include guard.
805         * common/scoped_restore.h: Rename include guard.
806         * common/scoped_mmap.h: Rename include guard.
807         * common/scoped_fd.h: Rename include guard.
808         * common/safe-iterator.h: Rename include guard.
809         * common/run-time-clock.h: Rename include guard.
810         * common/refcounted-object.h: Rename include guard.
811         * common/queue.h: Rename include guard.
812         * common/ptid.h: Rename include guard.
813         * common/print-utils.h: Rename include guard.
814         * common/preprocessor.h: Rename include guard.
815         * common/pathstuff.h: Rename include guard.
816         * common/observable.h: Rename include guard.
817         * common/netstuff.h: Rename include guard.
818         * common/job-control.h: Rename include guard.
819         * common/host-defs.h: Rename include guard.
820         * common/gdb_wait.h: Rename include guard.
821         * common/gdb_vecs.h: Rename include guard.
822         * common/gdb_unlinker.h: Rename include guard.
823         * common/gdb_unique_ptr.h: Rename include guard.
824         * common/gdb_tilde_expand.h: Rename include guard.
825         * common/gdb_sys_time.h: Rename include guard.
826         * common/gdb_string_view.h: Rename include guard.
827         * common/gdb_splay_tree.h: Rename include guard.
828         * common/gdb_setjmp.h: Rename include guard.
829         * common/gdb_ref_ptr.h: Rename include guard.
830         * common/gdb_optional.h: Rename include guard.
831         * common/gdb_locale.h: Rename include guard.
832         * common/gdb_assert.h: Rename include guard.
833         * common/filtered-iterator.h: Rename include guard.
834         * common/filestuff.h: Rename include guard.
835         * common/fileio.h: Rename include guard.
836         * common/environ.h: Rename include guard.
837         * common/common-utils.h: Rename include guard.
838         * common/common-types.h: Rename include guard.
839         * common/common-regcache.h: Rename include guard.
840         * common/common-inferior.h: Rename include guard.
841         * common/common-gdbthread.h: Rename include guard.
842         * common/common-exceptions.h: Rename include guard.
843         * common/common-defs.h: Rename include guard.
844         * common/common-debug.h: Rename include guard.
845         * common/cleanups.h: Rename include guard.
846         * common/buffer.h: Rename include guard.
847         * common/btrace-common.h: Rename include guard.
848         * common/break-common.h: Rename include guard.
849         * cli/cli-utils.h: Rename include guard.
850         * cli/cli-style.h: Rename include guard.
851         * cli/cli-setshow.h: Rename include guard.
852         * cli/cli-script.h: Rename include guard.
853         * cli/cli-interp.h: Rename include guard.
854         * cli/cli-decode.h: Rename include guard.
855         * cli/cli-cmds.h: Rename include guard.
856         * charset-list.h: Add include guard.
857         * buildsym-legacy.h: Rename include guard.
858         * bfin-tdep.h: Add include guard.
859         * ax.h: Rename include guard.
860         * arm-linux-tdep.h: Add include guard.
861         * arm-fbsd-tdep.h: Add include guard.
862         * arch/xtensa.h: Rename include guard.
863         * arch/tic6x.h: Add include guard.
864         * arch/i386.h: Add include guard.
865         * arch/arm.h: Rename include guard.
866         * arch/arm-linux.h: Rename include guard.
867         * arch/arm-get-next-pcs.h: Rename include guard.
868         * arch/amd64.h: Add include guard.
869         * arch/aarch64-insn.h: Rename include guard.
870         * arch-utils.h: Rename include guard.
871         * annotate.h: Add include guard.
872         * amd64-darwin-tdep.h: Rename include guard.
873         * aarch64-linux-tdep.h: Add include guard.
874         * aarch64-fbsd-tdep.h: Add include guard.
875         * aarch32-linux-nat.h: Add include guard.
876
877 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
878
879         * macrotab.c (macro_define_internal): New function that
880         factorizes macro_define_object_internal and macro_define_function
881         code.
882         (macro_define_object_internal): Use macro_define_internal.
883         (macro_define_function): Likewise.
884
885 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
886
887         * macrocmd.c (extract_identifier): Return
888         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
889         callers.
890
891 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
892
893         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
894
895 2019-02-05  Tom Tromey  <tom@tromey.com>
896
897         * target.c (target_stack::unpush): Move assertion earlier.
898
899 2019-01-30  Tom Tromey  <tom@tromey.com>
900
901         PR python/23615:
902         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
903         (gdbpy_parse_and_eval): Likewise.
904         * python/python-internal.h (gdbpy_allow_threads): New class.
905
906 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
907
908         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
909         (aarch64_fbsd_fpregmap): Move earlier.
910         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
911         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
912         instead of individual calls to trad_frame_set_reg_addr.
913         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
914         earlier.
915         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
916         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
917         instead of individual calls to trad_frame_set_reg_addr.
918
919 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
920
921         * CONTRIBUTE: Replace contribution list with wiki link.
922
923 2019-01-25  Tom Tromey  <tom@tromey.com>
924
925         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
926
927 2019-01-25  Tom Tromey  <tom@tromey.com>
928
929         * xtensa-linux-nat.c: Fix common/ includes.
930         * xml-support.h: Fix common/ includes.
931         * xml-support.c: Fix common/ includes.
932         * x86-linux-nat.c: Fix common/ includes.
933         * windows-nat.c: Fix common/ includes.
934         * varobj.h: Fix common/ includes.
935         * varobj.c: Fix common/ includes.
936         * value.c: Fix common/ includes.
937         * valops.c: Fix common/ includes.
938         * utils.c: Fix common/ includes.
939         * unittests/xml-utils-selftests.c: Fix common/ includes.
940         * unittests/utils-selftests.c: Fix common/ includes.
941         * unittests/unpack-selftests.c: Fix common/ includes.
942         * unittests/tracepoint-selftests.c: Fix common/ includes.
943         * unittests/style-selftests.c: Fix common/ includes.
944         * unittests/string_view-selftests.c: Fix common/ includes.
945         * unittests/scoped_restore-selftests.c: Fix common/ includes.
946         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
947         * unittests/scoped_fd-selftests.c: Fix common/ includes.
948         * unittests/rsp-low-selftests.c: Fix common/ includes.
949         * unittests/parse-connection-spec-selftests.c: Fix common/
950         includes.
951         * unittests/optional-selftests.c: Fix common/ includes.
952         * unittests/offset-type-selftests.c: Fix common/ includes.
953         * unittests/observable-selftests.c: Fix common/ includes.
954         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
955         * unittests/memrange-selftests.c: Fix common/ includes.
956         * unittests/memory-map-selftests.c: Fix common/ includes.
957         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
958         * unittests/function-view-selftests.c: Fix common/ includes.
959         * unittests/environ-selftests.c: Fix common/ includes.
960         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
961         * unittests/common-utils-selftests.c: Fix common/ includes.
962         * unittests/cli-utils-selftests.c: Fix common/ includes.
963         * unittests/array-view-selftests.c: Fix common/ includes.
964         * ui-file.c: Fix common/ includes.
965         * tui/tui-io.c: Fix common/ includes.
966         * tracepoint.h: Fix common/ includes.
967         * tracepoint.c: Fix common/ includes.
968         * tracefile-tfile.c: Fix common/ includes.
969         * top.h: Fix common/ includes.
970         * top.c: Fix common/ includes.
971         * thread.c: Fix common/ includes.
972         * target/waitstatus.h: Fix common/ includes.
973         * target/waitstatus.c: Fix common/ includes.
974         * target.h: Fix common/ includes.
975         * target.c: Fix common/ includes.
976         * target-memory.c: Fix common/ includes.
977         * target-descriptions.c: Fix common/ includes.
978         * symtab.h: Fix common/ includes.
979         * symfile.c: Fix common/ includes.
980         * stap-probe.c: Fix common/ includes.
981         * spu-linux-nat.c: Fix common/ includes.
982         * sparc-nat.c: Fix common/ includes.
983         * source.c: Fix common/ includes.
984         * solib.c: Fix common/ includes.
985         * solib-target.c: Fix common/ includes.
986         * ser-unix.c: Fix common/ includes.
987         * ser-tcp.c: Fix common/ includes.
988         * ser-pipe.c: Fix common/ includes.
989         * ser-base.c: Fix common/ includes.
990         * selftest-arch.c: Fix common/ includes.
991         * s12z-tdep.c: Fix common/ includes.
992         * rust-exp.y: Fix common/ includes.
993         * rs6000-aix-tdep.c: Fix common/ includes.
994         * riscv-tdep.c: Fix common/ includes.
995         * remote.c: Fix common/ includes.
996         * remote-notif.h: Fix common/ includes.
997         * remote-fileio.h: Fix common/ includes.
998         * remote-fileio.c: Fix common/ includes.
999         * regcache.h: Fix common/ includes.
1000         * regcache.c: Fix common/ includes.
1001         * record-btrace.c: Fix common/ includes.
1002         * python/python.c: Fix common/ includes.
1003         * python/py-type.c: Fix common/ includes.
1004         * python/py-inferior.c: Fix common/ includes.
1005         * progspace.h: Fix common/ includes.
1006         * producer.c: Fix common/ includes.
1007         * procfs.c: Fix common/ includes.
1008         * proc-api.c: Fix common/ includes.
1009         * printcmd.c: Fix common/ includes.
1010         * ppc-linux-nat.c: Fix common/ includes.
1011         * parser-defs.h: Fix common/ includes.
1012         * osdata.c: Fix common/ includes.
1013         * obsd-nat.c: Fix common/ includes.
1014         * nat/x86-linux.c: Fix common/ includes.
1015         * nat/x86-linux-dregs.c: Fix common/ includes.
1016         * nat/x86-dregs.h: Fix common/ includes.
1017         * nat/x86-dregs.c: Fix common/ includes.
1018         * nat/ppc-linux.c: Fix common/ includes.
1019         * nat/mips-linux-watch.h: Fix common/ includes.
1020         * nat/mips-linux-watch.c: Fix common/ includes.
1021         * nat/linux-waitpid.c: Fix common/ includes.
1022         * nat/linux-ptrace.h: Fix common/ includes.
1023         * nat/linux-ptrace.c: Fix common/ includes.
1024         * nat/linux-procfs.c: Fix common/ includes.
1025         * nat/linux-personality.c: Fix common/ includes.
1026         * nat/linux-osdata.c: Fix common/ includes.
1027         * nat/linux-namespaces.c: Fix common/ includes.
1028         * nat/linux-btrace.h: Fix common/ includes.
1029         * nat/linux-btrace.c: Fix common/ includes.
1030         * nat/fork-inferior.c: Fix common/ includes.
1031         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1032         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1033         * nat/aarch64-linux.c: Fix common/ includes.
1034         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1035         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1036         * namespace.h: Fix common/ includes.
1037         * mips-linux-tdep.c: Fix common/ includes.
1038         * minsyms.c: Fix common/ includes.
1039         * mi/mi-parse.h: Fix common/ includes.
1040         * mi/mi-main.c: Fix common/ includes.
1041         * mi/mi-cmd-env.c: Fix common/ includes.
1042         * memrange.h: Fix common/ includes.
1043         * memattr.c: Fix common/ includes.
1044         * maint.h: Fix common/ includes.
1045         * maint.c: Fix common/ includes.
1046         * main.c: Fix common/ includes.
1047         * machoread.c: Fix common/ includes.
1048         * location.c: Fix common/ includes.
1049         * linux-thread-db.c: Fix common/ includes.
1050         * linux-nat.c: Fix common/ includes.
1051         * linux-fork.c: Fix common/ includes.
1052         * inline-frame.c: Fix common/ includes.
1053         * infrun.c: Fix common/ includes.
1054         * inflow.c: Fix common/ includes.
1055         * inferior.h: Fix common/ includes.
1056         * inferior.c: Fix common/ includes.
1057         * infcmd.c: Fix common/ includes.
1058         * inf-ptrace.c: Fix common/ includes.
1059         * inf-child.c: Fix common/ includes.
1060         * ia64-linux-nat.c: Fix common/ includes.
1061         * i387-tdep.c: Fix common/ includes.
1062         * i386-tdep.c: Fix common/ includes.
1063         * i386-linux-tdep.c: Fix common/ includes.
1064         * i386-linux-nat.c: Fix common/ includes.
1065         * i386-go32-tdep.c: Fix common/ includes.
1066         * i386-fbsd-tdep.c: Fix common/ includes.
1067         * i386-fbsd-nat.c: Fix common/ includes.
1068         * guile/scm-type.c: Fix common/ includes.
1069         * guile/guile.c: Fix common/ includes.
1070         * go32-nat.c: Fix common/ includes.
1071         * gnu-nat.c: Fix common/ includes.
1072         * gdbthread.h: Fix common/ includes.
1073         * gdbarch-selftests.c: Fix common/ includes.
1074         * gdb_usleep.c: Fix common/ includes.
1075         * gdb_select.h: Fix common/ includes.
1076         * gdb_bfd.c: Fix common/ includes.
1077         * gcore.c: Fix common/ includes.
1078         * fork-child.c: Fix common/ includes.
1079         * findvar.c: Fix common/ includes.
1080         * fbsd-nat.c: Fix common/ includes.
1081         * event-top.c: Fix common/ includes.
1082         * event-loop.c: Fix common/ includes.
1083         * dwarf2read.c: Fix common/ includes.
1084         * dwarf2loc.c: Fix common/ includes.
1085         * dwarf2-frame.c: Fix common/ includes.
1086         * dwarf-index-cache.c: Fix common/ includes.
1087         * dtrace-probe.c: Fix common/ includes.
1088         * disasm-selftests.c: Fix common/ includes.
1089         * defs.h: Fix common/ includes.
1090         * csky-tdep.c: Fix common/ includes.
1091         * cp-valprint.c: Fix common/ includes.
1092         * cp-support.h: Fix common/ includes.
1093         * cp-support.c: Fix common/ includes.
1094         * corelow.c: Fix common/ includes.
1095         * completer.h: Fix common/ includes.
1096         * completer.c: Fix common/ includes.
1097         * compile/compile.c: Fix common/ includes.
1098         * compile/compile-loc2c.c: Fix common/ includes.
1099         * compile/compile-cplus-types.c: Fix common/ includes.
1100         * compile/compile-cplus-symbols.c: Fix common/ includes.
1101         * command.h: Fix common/ includes.
1102         * cli/cli-dump.c: Fix common/ includes.
1103         * cli/cli-cmds.c: Fix common/ includes.
1104         * charset.c: Fix common/ includes.
1105         * build-id.c: Fix common/ includes.
1106         * btrace.h: Fix common/ includes.
1107         * btrace.c: Fix common/ includes.
1108         * breakpoint.h: Fix common/ includes.
1109         * breakpoint.c: Fix common/ includes.
1110         * ax.h: 
1111         (enum agent_op): Fix common/ includes.
1112         * ax-general.c (struct aop_map): Fix common/ includes.
1113         * ax-gdb.c: Fix common/ includes.
1114         * auxv.c: Fix common/ includes.
1115         * auto-load.c: Fix common/ includes.
1116         * arm-tdep.c: Fix common/ includes.
1117         * arch/riscv.c: Fix common/ includes.
1118         * arch/ppc-linux-common.c: Fix common/ includes.
1119         * arch/i386.c: Fix common/ includes.
1120         * arch/arm.c: Fix common/ includes.
1121         * arch/arm-linux.c: Fix common/ includes.
1122         * arch/arm-get-next-pcs.c: Fix common/ includes.
1123         * arch/amd64.c: Fix common/ includes.
1124         * arch/aarch64.c: Fix common/ includes.
1125         * arch/aarch64-insn.c: Fix common/ includes.
1126         * arch-utils.c: Fix common/ includes.
1127         * amd64-windows-tdep.c: Fix common/ includes.
1128         * amd64-tdep.c: Fix common/ includes.
1129         * amd64-sol2-tdep.c: Fix common/ includes.
1130         * amd64-obsd-tdep.c: Fix common/ includes.
1131         * amd64-nbsd-tdep.c: Fix common/ includes.
1132         * amd64-linux-tdep.c: Fix common/ includes.
1133         * amd64-linux-nat.c: Fix common/ includes.
1134         * amd64-fbsd-tdep.c: Fix common/ includes.
1135         * amd64-fbsd-nat.c: Fix common/ includes.
1136         * amd64-dicos-tdep.c: Fix common/ includes.
1137         * amd64-darwin-tdep.c: Fix common/ includes.
1138         * agent.c: Fix common/ includes.
1139         * ada-lang.h: Fix common/ includes.
1140         * ada-lang.c: Fix common/ includes.
1141         * aarch64-tdep.c: Fix common/ includes.
1142
1143 2019-01-25  Tom Tromey  <tom@tromey.com>
1144
1145         * common/create-version.sh: Use common/version.h.
1146
1147 2019-01-24  Pedro Alves  <palves@redhat.com>
1148
1149         * infrun.c (signal_stop, signal_print, signal_program)
1150         (signal_catch, signal_pass): Now arrays instead of pointers.
1151         (update_signals_program_target, do_target_resume)
1152         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1153         * linux-nat.c (linux_nat_target::pass_signals)
1154         (linux_nat_target::create_inferior, linux_nat_target::attach):
1155         Adjust.
1156         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1157         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1158         * procfs.c (procfs_target::pass_signals): Adjust.
1159         * record-full.c (record_full_target::resume): Adjust.
1160         * remote.c (remote_target::pass_signals)
1161         (remote_target::program_signals): Adjust.
1162         * target-debug.h (target_debug_print_signals): Now takes a
1163         gdb::array_view as parameter.  Adjust.
1164         * target.h (target_ops) <pass_signals, program_signals>: Replace
1165         pointer and length parameters with gdb::array_view.
1166         (target_pass_signals, target_program_signals): Likewise.
1167         * target-delegates.c: Regenerate.
1168
1169 2019-01-24  Pedro Alves  <palves@redhat.com>
1170
1171         * common/forward-scope-exit.h
1172         (forward_scope_exit::forward_scope_exit): Pass arguments to
1173         m_bind_function directly, instead of creating a std::bind and
1174         copying that.
1175
1176 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1177
1178         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1179         for static members.
1180         (pass_in_v_vfp_candidate): Likewise.
1181
1182 2019-01-23  Tom Tromey  <tom@tromey.com>
1183             Pedro Alves  <palves@redhat.com>
1184
1185         * regcache.c (class regcache_invalidator): Remove.
1186         (regcache::raw_write): Use make_scope_exit.
1187
1188 2019-01-23  Tom Tromey  <tom@tromey.com>
1189
1190         * ui-out.h (class ui_out_emit_type): Update comment.
1191
1192 2019-01-23  Tom Tromey  <tom@tromey.com>
1193
1194         * infrun.c (fetch_inferior_event): Update comment.
1195
1196 2019-01-23  Tom Tromey  <tom@tromey.com>
1197             Pedro Alves  <palves@redhat.com>
1198
1199         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1200         parameter.
1201         (fetch_inferior_event): Use SCOPE_EXIT.
1202
1203
1204 2019-01-23  Tom Tromey  <tom@tromey.com>
1205             Pedro Alves  <palves@redhat.com>
1206
1207         * infrun.c (disable_thread_events): Delete.
1208         (stop_all_threads): Use SCOPE_EXIT.
1209
1210 2019-01-23  Tom Tromey  <tom@tromey.com>
1211             Pedro Alves  <palves@redhat.com>
1212
1213         * symfile.c: Include forward-scope-exit.h.
1214         (clear_symtab_users_cleanup): Replace forward declaration with
1215         a FORWARD_SCOPE_EXIT.
1216         (syms_from_objfile_1): Use the forward_scope_exit and
1217         gdb::optional instead of cleanup_function.
1218         (reread_symbols): Use the forward_scope_exit instead of
1219         cleanup_function.
1220         (clear_symtab_users_cleanup): Remove function.
1221
1222 2019-01-23  Tom Tromey  <tom@tromey.com>
1223             Pedro Alves  <palves@redhat.com>
1224
1225         * linux-nat.c: Include scope-exit.h.
1226         (cleanup_target_stop): Remove.
1227         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1228         SCOPE_EXIT.
1229
1230 2019-01-23  Tom Tromey  <tom@tromey.com>
1231             Pedro Alves  <palves@redhat.com>
1232
1233         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1234         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1235
1236 2019-01-23  Tom Tromey  <tom@tromey.com>
1237             Andrew Burgess  <andrew.burgess@embecosm.com>
1238             Pedro Alves  <palves@redhat.com>
1239
1240         * infrun.c (fetch_inferior_event): Use scope_exit.
1241         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1242         * top.c (execute_command): Use scope_exit.
1243         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1244         * utils.c (do_bpstat_clear_actions_cleanup)
1245         (make_bpstat_clear_actions_cleanup): Remove.
1246
1247 2019-01-23  Tom Tromey  <tom@tromey.com>
1248             Pedro Alves  <palves@redhat.com>
1249
1250         * infrun.c: Include "common/scope-exit.h"
1251         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1252         (wait_for_inferior): Use SCOPE_EXIT.
1253         (fetch_inferior_event): Use scope_exit.
1254
1255 2019-01-23  Tom Tromey  <tom@tromey.com>
1256             Pedro Alves  <palves@redhat.com>
1257
1258         * breakpoint.c (create_breakpoint): Remove cleanup.
1259
1260 2019-01-23  Tom Tromey  <tom@tromey.com>
1261             Andrew Burgess  <andrew.burgess@embecosm.com>
1262             Pedro Alves  <palves@redhat.com>
1263
1264 2019-01-23  Pedro Alves  <palves@redhat.com>
1265
1266         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1267
1268 2019-01-23  Pedro Alves  <palves@redhat.com>
1269             Andrew Burgess  <andrew.burgess@embecosm.com>
1270
1271         * gdbthread.h: Include "common/forward-scope-exit.h".
1272         (scoped_finish_thread_state): Redefine custom class in terms of
1273         forward_scope_exit.
1274
1275 2019-01-23  Pedro Alves  <palves@redhat.com>
1276             Andrew Burgess  <andrew.burgess@embecosm.com>
1277
1278         * common/forward-scope-exit.h: New file.
1279
1280 2019-01-23  Pedro Alves  <palves@redhat.com>
1281             Andrew Burgess  <andrew.burgess@embecosm.com>
1282             Tom Tromey  <tom@tromey.com>
1283
1284         * common/scope-exit.h: New file.
1285
1286 2019-01-23  Pedro Alves  <palves@redhat.com>
1287
1288         * common/preprocessor.h (ESC): Rename to ...
1289         (ESC_PARENS): ... this.
1290         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1291         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1292
1293 2019-01-23  Tom Tromey  <tom@tromey.com>
1294
1295         * language.h (class scoped_switch_to_sym_language_if_auto):
1296         Initialize m_lang in both cases.
1297
1298 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1299
1300         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1301         with XCNEW.
1302
1303 2019-01-22  Tom Tromey  <tom@tromey.com>
1304
1305         * corelow.c: Do not include sys/file.h.
1306
1307 2019-01-22  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-wingeneral.h: Include gdb_curses.h.
1310
1311 2019-01-22  Tom Tromey  <tom@tromey.com>
1312
1313         * source-cache.h (class source_cache) <get_source_lines,
1314         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1315
1316 2019-01-22  Tom Tromey  <tom@tromey.com>
1317
1318         * remote-fileio.h (struct remote_target): Declare.
1319
1320 2019-01-22  Tom Tromey  <tom@tromey.com>
1321
1322         * python/py-arch.c: Do not include py-ref.h.
1323         * python/py-bpevent.c: Do not include py-ref.h.
1324         * python/py-cmd.c: Do not include py-ref.h.
1325         * python/py-continueevent.c: Do not include py-ref.h.
1326         * python/py-event.h: Do not include py-ref.h.
1327         * python/py-evtregistry.c: Do not include py-ref.h.
1328         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1329         * python/py-frame.c: Do not include py-ref.h.
1330         * python/py-framefilter.c: Do not include py-ref.h.
1331         * python/py-function.c: Do not include py-ref.h.
1332         * python/py-infevents.c: Do not include py-ref.h.
1333         * python/py-linetable.c: Do not include py-ref.h.
1334         * python/py-objfile.c: Do not include py-ref.h.
1335         * python/py-param.c: Do not include py-ref.h.
1336         * python/py-prettyprint.c: Do not include py-ref.h.
1337         * python/py-progspace.c: Do not include py-ref.h.
1338         * python/py-symbol.c: Do not include py-ref.h.
1339         * python/py-symtab.c: Do not include py-ref.h.
1340         * python/py-type.c: Do not include py-ref.h.
1341         * python/py-unwind.c: Do not include py-ref.h.
1342         * python/py-utils.c: Do not include py-ref.h.
1343         * python/py-value.c: Do not include py-ref.h.
1344         * python/py-varobj.c: Do not include py-ref.h.
1345         * python/py-xmethods.c: Do not include py-ref.h.
1346         * python/python.c: Do not include py-ref.h.
1347         * varobj.c: Do not include py-ref.h.
1348
1349 2019-01-22  Tom Tromey  <tom@tromey.com>
1350
1351         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1352         keyword for bcache.
1353
1354 2019-01-22  Tom Tromey  <tom@tromey.com>
1355
1356         * compile/compile-cplus-types.c: Remove a comment by #include.
1357
1358 2019-01-22  Tom Tromey  <tom@tromey.com>
1359
1360         * compile/gcc-c-plugin.h: Include compile-internal.h.
1361
1362 2019-01-22  Tom Tromey  <tom@tromey.com>
1363
1364         * stabsread.c (EXTERN): Do not define.
1365         (symnum, next_symbol_text_func, processing_gcc_compilation)
1366         (within_function, global_sym_chain, global_stabs)
1367         (previous_stab_code, this_object_header_files)
1368         (n_this_object_header_files)
1369         (n_allocated_this_object_header_files): Define.
1370         * stabsread.h (EXTERN): Never define.  Use "extern".
1371
1372 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1373
1374         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1375         history_value.
1376
1377 2019-01-21  Tom Tromey  <tom@tromey.com>
1378
1379         * ui-out.c: Fix includes.
1380         * tui/tui-source.c: Fix includes.
1381         * target.c: Fix includes.
1382         * remote.c: Fix includes.
1383         * regcache.c: Fix includes.
1384         * python/py-block.c: Fix includes.
1385         * printcmd.c: Fix includes.
1386         * or1k-tdep.c: Fix includes.
1387         * mi/mi-main.c: Fix includes.
1388         * m32r-tdep.c: Fix includes.
1389         * csky-tdep.c: Fix includes.
1390         * compile/compile-cplus-types.c: Fix includes.
1391         * cli/cli-interp.c: Fix includes.
1392
1393 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1394
1395         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1396         for padding.
1397
1398 2019-01-16  Tom Tromey  <tom@tromey.com>
1399
1400         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1401         earlier.
1402         (struct objfile) <msymbols_range>: Move from top level.
1403         <msymbols>: New method.
1404         (class objfile_msymbols): Remove.
1405         * symtab.c (default_collect_symbol_completion_matches_break_on):
1406         Update.
1407         * symmisc.c (dump_msymbols): Update.
1408         * stabsread.c (scan_file_globals): Update.
1409         * objc-lang.c (info_selectors_command, info_classes_command)
1410         (find_methods): Update.
1411         * minsyms.c (find_solib_trampoline_target): Update.
1412         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1413         * coffread.c (coff_symfile_read): Update.
1414         * ada-lang.c (ada_lookup_simple_minsym)
1415         (ada_collect_symbol_completion_matches): Update.
1416
1417 2019-01-16  Tom Tromey  <tom@tromey.com>
1418
1419         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1420         type.  Remove no-argument constructor.
1421         <iterator::operator++>: Simplify.
1422         <begin>: Update.
1423         <end>: Use minimal_symbol_count.
1424
1425 2019-01-16  Tom Tromey  <tom@tromey.com>
1426
1427         * objfiles.h (struct objfile) <psymtabs>: New method.
1428         (class objfile_psymtabs): Remove.
1429         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1430         typedef.
1431         <range>: New method.
1432         (require_partial_symbols): Change return type.
1433         * psymtab.c (require_partial_symbols)
1434         (psym_expand_symtabs_matching): Update.
1435         * mdebugread.c (parse_partial_symbols): Update.
1436         * dbxread.c (dbx_end_psymtab): Update.
1437
1438 2019-01-15  Tom Tromey  <tom@tromey.com>
1439
1440         * symtab.c (lookup_objfile_from_block)
1441         (lookup_symbol_in_objfile_symtabs)
1442         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1443         (find_line_symtab, info_sources_command)
1444         (default_collect_symbol_completion_matches_break_on)
1445         (make_source_files_completion_list): Update.
1446         * symmisc.c (print_objfile_statistics, dump_objfile)
1447         (maintenance_print_symbols, maintenance_info_symtabs)
1448         (maintenance_check_symtabs, maintenance_info_line_tables):
1449         Update.
1450         * source.c (select_source_symtab)
1451         (forget_cached_source_info_for_objfile): Update.
1452         * objfiles.h (class objfile_compunits): Remove.
1453         (struct objfile) <compunits_range>: New typedef.
1454         (compunits): New method.
1455         * objfiles.c (objfile_relocate1): Update.
1456         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1457         * maint.c (count_symtabs_and_blocks): Update.
1458         * linespec.c (iterate_over_all_matching_symtabs): Update.
1459         * cp-support.c (add_symbol_overload_list_qualified): Update.
1460         * coffread.c (coff_symtab_read): Update.
1461         * ada-lang.c (add_nonlocal_symbols)
1462         (ada_collect_symbol_completion_matches)
1463         (ada_add_global_exceptions): Update.
1464
1465 2019-01-15  Tom Tromey  <tom@tromey.com>
1466
1467         * progspace.h (program_space) <objfiles_safe_range>: New
1468         typedef.
1469         <objfiles_safe>: New method.
1470         * objfiles.h (class all_objfiles_safe): Remove.
1471         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1472         * jit.c (jit_inferior_exit_hook): Update.
1473
1474 2019-01-17  Tom Tromey  <tom@tromey.com>
1475
1476         * progspace.h (program_space) <objfiles_range>: New typedef.
1477         <objfiles>: New method.
1478         <objfiles_head>: Rename from objfiles.
1479         (object_files): Update.
1480         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1481         * guile/scm-pretty-print.c
1482         (ppscm_find_pretty_printer_from_objfiles): Update.
1483         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1484         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1485         Update.
1486         * python/py-progspace.c (pspy_get_objfiles): Update.
1487         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1488         Update.
1489         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1490         (objfpy_lookup_objfile_by_build_id): Update.
1491         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1492         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1493         Update.
1494         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1495         (expand_symtab_containing_pc, lookup_objfile_from_block)
1496         (lookup_static_symbol, basic_lookup_transparent_type)
1497         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1498         (find_line_symtab, info_sources_command)
1499         (default_collect_symbol_completion_matches_break_on)
1500         (make_source_files_completion_list, find_main_name): Update.
1501         * symmisc.c (print_symbol_bcache_statistics)
1502         (print_objfile_statistics, maintenance_print_symbols)
1503         (maintenance_print_msymbols, maintenance_print_objfiles)
1504         (maintenance_info_symtabs, maintenance_check_symtabs)
1505         (maintenance_expand_symtabs, maintenance_info_line_tables):
1506         Update.
1507         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1508         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1509         (map_overlay_command, unmap_overlay_command)
1510         (simple_overlay_update, expand_symtabs_matching)
1511         (map_symbol_filenames): Update.
1512         * symfile-debug.c (set_debug_symfile): Update.
1513         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1514         Update.
1515         * source.c (select_source_symtab, forget_cached_source_info):
1516         Update.
1517         * solib.c (solib_read_symbols): Update.
1518         * solib-spu.c (append_ocl_sos): Update.
1519         * psymtab.c (maintenance_print_psymbols)
1520         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1521         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1522         * printcmd.c (info_symbol_command): Update.
1523         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1524         Update.
1525         * objfiles.h (class all_objfiles): Remove.
1526         * objfiles.c (have_partial_symbols, have_full_symbols)
1527         (have_minimal_symbols, qsort_cmp, update_section_map)
1528         (shared_objfile_contains_address_p)
1529         (default_iterate_over_objfiles_in_search_order): Update.
1530         * objc-lang.c (info_selectors_command, info_classes_command)
1531         (find_methods): Update.
1532         * minsyms.c (find_solib_trampoline_target): Update.
1533         * maint.c (maintenance_info_sections)
1534         (maintenance_translate_address, count_symtabs_and_blocks):
1535         Update.
1536         * main.c (captured_main_1): Update.
1537         * linux-thread-db.c (try_thread_db_load_from_pdir)
1538         (has_libpthread): Update.
1539         * linespec.c (iterate_over_all_matching_symtabs)
1540         (search_minsyms_for_name): Update.
1541         * jit.c (jit_find_objf_with_entry_addr): Update.
1542         * hppa-tdep.c (find_unwind_entry)
1543         (hppa_lookup_stub_minimal_symbol): Update.
1544         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1545         Update.
1546         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1547         (elf_gnu_ifunc_resolve_by_got): Update.
1548         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1549         * dwarf-index-write.c (save_gdb_index_command): Update.
1550         * cp-support.c (add_symbol_overload_list_qualified): Update.
1551         * breakpoint.c (create_overlay_event_breakpoint)
1552         (create_longjmp_master_breakpoint)
1553         (create_std_terminate_master_breakpoint)
1554         (create_exception_master_breakpoint): Update.
1555         * blockframe.c (find_pc_partial_function): Update.
1556         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1557         (ada_collect_symbol_completion_matches)
1558         (ada_add_global_exceptions): Update.
1559
1560 2019-01-17  Tom Tromey  <tom@tromey.com>
1561
1562         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1563         declare VEC.
1564         (solib_target_parse_libraries): Change return type.
1565         (library_list_start_segment, library_list_start_section)
1566         (library_list_end_library, library_list_start_library); Update.
1567         (solib_target_free_library_list): Remove.
1568         (solib_target_parse_libraries): Remove cleanup.  Change return
1569         type.
1570         (solib_target_current_sos): Update.
1571
1572 2019-01-17  Tom Tromey  <tromey@bapiya>
1573
1574         * valprint.c: Replace "the the" with "the".
1575         * symtab.c: Replace "the the" with "the".
1576         * solib.c: Replace "the the" with "the".
1577         * solib-dsbt.c: Replace "the the" with "the".
1578         * linespec.c: Replace "the the" with "the".
1579         * dwarf2loc.h: Replace "the the" with "the".
1580         * amd64-windows-tdep.c: Replace "the the" with "the".
1581         * aarch64-tdep.c: Replace "the the" with "the".
1582
1583 2019-01-16  Keith Seitz  <keiths@redhat.com>
1584
1585         PR gdb/23773
1586         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1587         <builder>: Rename to ..
1588         <m_builder>: ... this and make private.
1589         (dwarf2_cu::get_builder): New method.  Change all users of
1590         `builder' to use this method.
1591         (dwarf2_start_symtab): Move to ...
1592         (dwarf2_cu::start_symtab): ... here.  Update all callers
1593         (setup_type_unit_groups): Move to ...
1594         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1595         callers.
1596         (dwarf2_cu::reset_builder): New method.
1597         (process_full_compunit, process_full_type_unit): Use
1598         dwarf2_cu::reset_builder.
1599         (follow_die_offset): Record the ancestor CU if it is different
1600         from the followed DIE's CU.
1601         (follow_die_sig_1): Likewise.
1602
1603 2019-01-15  Tom Tromey  <tom@tromey.com>
1604
1605         * remote.c (class remote_state) <buf>: Now a char_vector.
1606         <buf_size>: Remove.
1607         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1608         parameter.
1609         (remote_target::getpkt_or_notif_sane_1)
1610         (remote_target::getpkt_sane)
1611         (remote_target::getpkt_or_notif_sane): Likewise.
1612         (class remote_target) <putpkt>: New overload.
1613         (remote_target::read_frame): Change type of "buf_p".  Remove
1614         sizeof_p parameter.
1615         (packet_ok): New overload.
1616         (packet_check_result): New overload.
1617         Update all uses.
1618
1619 2019-01-14  Tom Tromey  <tom@tromey.com>
1620
1621         * remote-notif.c (handle_notification, remote_notif_ack)
1622         (remote_notif_parse): Make "buf" const.
1623         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1624         const.
1625         (remote_notif_parse, remote_notif_ack, handle_notification):
1626         Likewise.
1627         * remote.c (remote_notif_stop_parse): Make "buf" const.
1628         (remote_target::remote_parse_stop_reply): Make "buf" const.
1629         (remote_notif_stop_ack): Make "buf" const.
1630
1631 2019-01-14  Tom Tromey  <tom@tromey.com>
1632
1633         * remote.c (remote_console_output): Make parameter const.
1634
1635 2019-01-14  Tom Tromey  <tom@tromey.com>
1636
1637         * target-debug.h (target_debug_print_signals): Constify.
1638         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1639         * procfs.c (procfs_target::pass_signals): Update.
1640         * linux-nat.c (linux_nat_target::pass_signals): Update.
1641         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1642         * target-delegates.c: Rebuild.
1643         * remote.c (remote_target::program_signals): Update.
1644         (remote_target::pass_signals): Update.
1645         * target.c (target_pass_signals): Constify argument.
1646         (target_program_signals): Likewise.
1647         * target.h (struct target_ops) <pass_signals, program_signals>:
1648         Constify argument.
1649         (target_pass_signals, target_program_signals): Constify argument.
1650
1651 2019-01-14  Tom Tromey  <tom@tromey.com>
1652
1653         PR tui/28819:
1654         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1655
1656 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1657
1658         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1659         field.
1660         * rs6000-tdep.c: Include reggroups.h.
1661         (IS_V_ALIAS_PSEUDOREG): Define.
1662         (rs6000_register_name): Return names for the "vX" aliases.
1663         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1664         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1665         aliases.  Call default_register_reggroup_p for all other
1666         pseudo-registers.
1667         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1668         New functions.
1669         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1670         Handle "vX" aliases.
1671         (v_alias_pseudo_register_collect): New function.
1672         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1673         (rs6000_gdbarch_init): Initialize "vX" aliases as
1674         pseudo-registers.  Restore registration of
1675         rs6000_pseudo_register_reggroup_p with
1676         set_tdesc_pseudo_register_reggroup_p.
1677
1678 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1679
1680         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1681         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1682         set_gdbarch_num_pseudo_regs.
1683
1684 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1685
1686         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1687         Remove arg prefixname, add do_set and do_show.
1688         Add member functions set_list and show_list.
1689         * cli/cli-style.c (class cli_style_option): Update accordingly.
1690         (style_set_list): Move to file scope.
1691         (style_show_list): Likewise.
1692         (set_style): Call help_list.
1693         (show_style): Call cmd_show_list.
1694         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1695         Update to use the new macro.
1696
1697 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1698
1699         * ada-lang.c (_initialize_ada_language): Expand the help text
1700         for the "catch exception" command.
1701
1702 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1703
1704         * symtab.c (matching_obj_sections): Initialize obj,
1705         declare it closer to its usage.
1706
1707 2019-01-10  Tom Tromey  <tom@tromey.com>
1708
1709         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1710         (basic_inf_threads_range): Remove.
1711         (inf_threads_range, inf_non_exited_threads_range)
1712         (safe_inf_threads_range): Use next_adapter.
1713
1714 2019-01-10  Keith Seitz  <keiths@redhat.com>
1715
1716         PR gdb/23712
1717         PR symtab/23010
1718         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1719         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1720
1721 2019-01-10  Keith Seitz  <keiths@redhat.com>
1722
1723         PR gdb/23712
1724         PR symtab/23010
1725         * dictionary.c (pending_to_vector): Remove.
1726         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1727         Remove _1 suffix, replacing functions of the same name.  Update
1728         all callers.
1729         (dict_create_hashed, dict_create_hashed_expandable)
1730         (dict_create_linear, dict_create_linear_expandable, dict_free)
1731         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1732         Make functions static.
1733
1734 2019-01-10  Keith Seitz  <keiths@redhat.com>
1735
1736         PR gdb/23712
1737         PR symtab/23010
1738         * dictionary.h (struct dictionary): Replace declaration with
1739         multidictionary.
1740         (dict_create_hashed, dict_create_hashed_expandable)
1741         (dict_create_linear, dict_create_linear_expandable)
1742         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1743         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1744         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1745         taking multidictionary argument.
1746         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1747         * block.h (struct block) <dict>: Change to multidictionary
1748         and rename `multidict'.
1749         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1750         symmisc.c: Update all dictionary references to multidictionary.
1751
1752 2019-01-10  Keith Seitz  <keiths@redhat.com>
1753
1754         PR gdb/23712
1755         PR symtab/23010
1756         * dictionary.c: Include unordered_map.
1757         (pending_to_vector): New function.
1758         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1759         Rewrite the non-"_1" functions to take vector instead
1760         of linked list.
1761         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1762         "new" _1 versions of the same name.
1763         (multidictionary): Define.
1764         (std::hash<enum language): New definition.
1765         (collate_pending_symbols_by_language, mdict_create_hashed)
1766         (mdict_create_hashed_expandable, mdict_create_linear)
1767         (mdict_create_linear_expandable, mdict_free)
1768         (find_language_dictionary, create_new_language_dictionary)
1769         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1770         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1771         (mdict_size, mdict_empty): New functions.
1772         * dictionary.h (mdict_iterator): Define.
1773
1774 2019-01-10  Pedro Alves  <palves@redhat.com>
1775
1776         * breakpoint.c (read_uploaded_action)
1777         (create_tracepoint_from_upload): Adjust to use
1778         gdb::unique_xmalloc_ptr.
1779         * ctf.c (ctf_write_uploaded_tp):
1780         (SET_ARRAY_FIELD): Use emplace_back.
1781         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1782         * tracefile-tfile.c (tfile_write_uploaded_tp):
1783         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1784         gdb::unique_xmalloc_ptr.
1785         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1786         at_string, cond_string, cmd_strings>: Replace char pointers
1787         with gdb::unique_xmalloc_ptr.
1788
1789 2019-01-10  Pedro Alves  <palves@redhat.com>
1790
1791         * solib-target.c (library_list_start_library): Don't xstrdup name.
1792
1793 2019-01-10  Pedro Alves  <palves@redhat.com>
1794
1795         * mdebugread.c (parse_partial_symbols): Use
1796         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1797
1798 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1799
1800         * linux-fork.c (scoped_switch_fork_info)
1801         <~scoped_switch_fork_info>: Fix incorrect variable name.
1802
1803 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1804
1805         * linux-fork.c (scoped_switch_fork_info)
1806         <scoped_switch_fork_info>: Make explicit.
1807         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1808
1809 2019-01-10  Tom Tromey  <tom@tromey.com>
1810
1811         * objfiles.h (objfile::reset_psymtabs): Update.
1812         * objfiles.c (objfile::objfile): Update.
1813         * psymtab.h (psymtab_storage::obstack): Update.
1814         (psymtab_storage::m_obstack): Use gdb::optional.
1815         (class psymtab_storage): Update comment.  Remove objfile
1816         parameter.
1817         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1818
1819 2019-01-10  Tom Tromey  <tom@tromey.com>
1820
1821         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1822         <free_psymtabs>: Now private.
1823         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1824         (allocate_psymtab): Use new method.
1825
1826 2019-01-10  Tom Tromey  <tom@tromey.com>
1827
1828         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1829         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1830         * mdebugread.c (parse_partial_symbols): Use
1831         allocate_dependencies.
1832         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1833         allocate_dependencies.
1834         (process_psymtab_comp_unit_reader)
1835         (build_type_psymtab_dependencies): Likewise.
1836         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1837
1838 2019-01-10  Tom Tromey  <tom@tromey.com>
1839
1840         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1841         PSYMBOL_SET_LANGUAGE.
1842         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1843
1844 2019-01-10  Tom Tromey  <tom@tromey.com>
1845
1846         * psymtab.h (psymtab_storage::obstack): New method.
1847         <m_obstack>: Rename from obstack; now private.
1848         * psymtab.c (psymtab_storage): Update.
1849         * dwarf2read.c (create_addrmap_from_index)
1850         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1851         Update.
1852
1853 2019-01-10  Tom Tromey  <tom@tromey.com>
1854
1855         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1856         * objfiles.h (objfile::reset_psymtabs): New method.
1857
1858 2019-01-10  Tom Tromey  <tom@tromey.com>
1859
1860         * symmisc.c (print_symbol_bcache_statistics): Update.
1861         (print_objfile_statistics): Update.
1862         * symfile.c (reread_symbols): Update.
1863         * psymtab.h (class psymtab_storage): New.
1864         * psymtab.c (psymtab_storage): New constructor.
1865         (~psymtab_storage): New destructor.
1866         (require_partial_symbols): Update.
1867         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1868         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1869         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1870         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1871         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1872         (start_psymtab_common, end_psymtab_common)
1873         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1874         (allocate_psymtab): Update.
1875         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1876         Update.
1877         (dump_psymtab_addrmap, maintenance_print_psymbols)
1878         (maintenance_check_psymtabs): Update.
1879         (class objfile_psymtabs): Move to objfiles.h.
1880         * psympriv.h (discard_psymtab): Now inline.
1881         (psymtab_discarder::psymtab_discarder): Update.
1882         (psymtab_discarder::~psymtab_discarder): Update.
1883         (ALL_OBJFILE_PSYMTABS): Rewrite.
1884         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1885         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1886         Remove fields.
1887         <partial_symtabs>: New field.
1888         (class objfile_psymtabs): Move from psymtab.h.  Update.
1889         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1890         psymbol_cache.
1891         (objfile::~objfile): Don't destroy psymbol_cache.
1892         * mdebugread.c (parse_partial_symbols): Update.
1893         * dwarf2read.c (create_addrmap_from_index)
1894         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1895         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1896         (add_partial_subprogram, dwarf2_ranges_read): Update.
1897         * dwarf-index-write.c (write_address_map)
1898         (write_one_signatured_type, recursively_write_psymbols)
1899         (class debug_names, class debug_names, write_psymtabs_to_index):
1900         Update.
1901
1902 2019-01-10  Tom Tromey  <tom@tromey.com>
1903
1904         * symtab.h (SYMBOL_SET_NAMES): Update.
1905         (symbol_set_names): Update.
1906         (MSYMBOL_SET_NAMES): Update.
1907         * symtab.c (symbol_set_names): Change argument to be an
1908         objfile_per_bfd_storage.
1909         * psymtab.c (add_psymbol_to_bcache): Update.
1910         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1911
1912 2019-01-10  Tom Tromey  <tom@tromey.com>
1913
1914         * symtab.c (create_demangled_names_hash): Change argument to be an
1915         objfile_per_bfd_storage.
1916         (symbol_set_names): Update.
1917
1918 2019-01-10  Tom Tromey  <tom@tromey.com>
1919
1920         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1921         init_psymbol_list.
1922         * psymtab.c (init_psymbol_list): Do nothing if already called.
1923         * psympriv.h (init_psymbol_list): Add comment.
1924         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1925         init_psymbol_list.
1926         * dbxread.c (dbx_symfile_read): Unconditionally call
1927         init_psymbol_list.
1928
1929 2019-01-10  Tom Tromey  <tom@tromey.com>
1930
1931         * xcoffread.c (scan_xcoff_symtab): Update.
1932         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1933         "where".
1934         * mdebugread.c (parse_partial_symbols)
1935         (handle_psymbol_enumerators): Update.
1936         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1937         * dbxread.c (read_dbx_symtab): Update.
1938         * psympriv.h (psymbol_placement): New enum.
1939         (add_psymbol_to_list): Update.
1940
1941 2019-01-10  Tom Tromey  <tom@tromey.com>
1942
1943         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1944         static_psymbols parameters.
1945         (scan_xcoff_symtab): Update.
1946         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1947         static_psymbols parameters.
1948         * psympriv.h (start_psymtab_common): Update.
1949         * mdebugread.c (parse_partial_symbols): Update.
1950         * dwarf2read.c (create_partial_symtab): Update.
1951         * dbxread.c (read_dbx_symtab): Update.
1952         (start_psymtab): Remove global_psymbols and static_psymbols
1953         parameters.
1954
1955 2019-01-10  Tom Tromey  <tom@tromey.com>
1956
1957         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1958         * psymtab.c (allocate_psymtab): Add comment.
1959         * psympriv.h (allocate_psymtab): Add comment.
1960         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1961         initializations.
1962         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1963
1964 2019-01-10  Tom Tromey  <tom@tromey.com>
1965
1966         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1967         Don't declare.
1968         * mipsread.c: Include mdebugread.h.
1969         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1970         Declare.
1971         * elfread.c: Include mdebugread.h.
1972
1973 2019-01-09  Tom Tromey  <tom@tromey.com>
1974
1975         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1976         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1977         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1978         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1979         (psym_lookup_symbol, psym_find_last_source_symtab)
1980         (psym_forget_cached_source_info, psym_print_stats)
1981         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1982         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1983         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1984         (psym_find_compunit_symtab_by_address)
1985         (maintenance_print_psymbols, maintenance_info_psymtabs)
1986         (maintenance_check_psymtabs): Use ranged for.
1987         * psymtab.h (class objfile_psymtabs): New.
1988         (require_partial_symbols): Return objfile_psymtabs.
1989         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1990
1991 2019-01-09  Tom Tromey  <tom@tromey.com>
1992
1993         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1994         (find_pc_mapped_section, list_overlays_command)
1995         (map_overlay_command, unmap_overlay_command)
1996         (simple_overlay_update): Use all_objfiles.
1997         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1998         * printcmd.c (info_symbol_command): Use all_objfiles.
1999         * objfiles.h (ALL_OBJSECTIONS): Remove.
2000         * maint.c (maintenance_translate_address): Use all_objfiles.
2001         * gcore.c (gcore_create_callback): Use all_objfiles.
2002         (objfile_find_memory_regions): Likewise.
2003
2004 2019-01-09  Tom Tromey  <tom@tromey.com>
2005
2006         * symtab.c (find_line_symtab, info_sources_command)
2007         (make_source_files_completion_list): Use objfile_compunits.
2008         * source.c (select_source_symtab): Use objfile_compunits.
2009         * objfiles.h (struct objfile): Update comment.
2010         (ALL_OBJFILES): Remove.
2011         (ALL_FILETABS): Remove.
2012         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2013         objfile_compunits.
2014
2015 2019-01-09  Tom Tromey  <tom@tromey.com>
2016
2017         * symmisc.c (print_objfile_statistics, dump_objfile)
2018         (maintenance_print_symbols): Use compunit_filetabs.
2019         * source.c (forget_cached_source_info_for_objfile): Use
2020         compunit_filetabs.
2021         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2022         (ALL_FILETABS): Use compunit_filetabs.
2023         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2024         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2025
2026 2019-01-09  Tom Tromey  <tom@tromey.com>
2027
2028         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2029         (compunit_filetabs): New.
2030         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2031         compunit_filetabs.
2032         (info_sources_command, make_source_files_completion_list): Remove
2033         declaration.
2034         * symmisc.c (print_objfile_statistics, dump_objfile)
2035         (maintenance_print_symbols): Remove declaration.
2036         (maintenance_info_symtabs): Use compunit_filetabs.
2037         (maintenance_info_line_tables): Likewise.
2038         * source.c (select_source_symtab): Change local variable name.
2039         (forget_cached_source_info_for_objfile): Remove declaration.
2040         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2041         * objfiles.c (objfile_relocate1): Remove declaration.
2042         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2043         declaration.
2044         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2045         * coffread.c (coff_symtab_read): Remove declaration.
2046         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2047         compunit_filetabs.
2048
2049 2019-01-09  Tom Tromey  <tom@tromey.com>
2050
2051         * symtab.c (lookup_objfile_from_block)
2052         (find_pc_sect_compunit_symtab, search_symbols)
2053         (default_collect_symbol_completion_matches_break_on): Use
2054         objfile_compunits.
2055         * objfiles.h (ALL_COMPUNITS): Remove.
2056         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2057         * cp-support.c (add_symbol_overload_list_qualified): Use
2058         objfile_compunits.
2059         * ada-lang.c (ada_collect_symbol_completion_matches)
2060         (ada_add_global_exceptions): Use objfile_compunits.
2061
2062 2019-01-09  Tom Tromey  <tom@tromey.com>
2063
2064         * source.c (select_source_symtab)
2065         (forget_cached_source_info_for_objfile): Remove declaration.
2066         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2067         declaration.
2068         * maint.c (count_symtabs_and_blocks): Remove declaration.
2069         * cp-support.c (add_symbol_overload_list_qualified): Remove
2070         declaration.
2071         * coffread.c (coff_symtab_read): Remove declaration.
2072         * symtab.c (lookup_symbol_in_objfile_symtabs)
2073         (basic_lookup_transparent_type_1): Use objfile_compunits.
2074         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2075         (info_sources_command, search_symbols)
2076         (default_collect_symbol_completion_matches_break_on)
2077         (make_source_files_completion_list): Remove declaration.
2078         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2079         (ada_collect_symbol_completion_matches)
2080         (ada_add_global_exceptions): Remove declaration.
2081         * linespec.c (iterate_over_all_matching_symtabs): Use
2082         objfile_compunits.
2083         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2084         (class objfile_compunits): New.
2085         (ALL_COMPUNITS): Use objfile_compunits.
2086         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2087         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2088         objfile_compunits.
2089         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2090
2091 2019-01-09  Tom Tromey  <tom@tromey.com>
2092
2093         * symtab.c (search_symbols)
2094         (default_collect_symbol_completion_matches_break_on): Use
2095         objfile_msymbols.
2096         * ada-lang.c (ada_lookup_simple_minsym)
2097         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2098         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2099         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2100         objfile_msymbols.
2101         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2102         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2103         * objc-lang.c (find_methods): Use objfile_msymbols.
2104         (info_selectors_command, info_classes_command): Likewise.
2105         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2106         * objfiles.h (class objfile_msymbols): New.
2107         (ALL_OBJFILE_MSYMBOLS): Remove.
2108         (ALL_MSYMBOLS): Remove.
2109
2110 2019-01-09  Tom Tromey  <tom@tromey.com>
2111
2112         * common/next-iterator.h (next_adapter): Add Iterator template
2113         parameter.
2114         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2115         (class all_objfiles_safe): New.
2116         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2117         * objfiles.c (put_objfile_before): Update comment.
2118         (add_separate_debug_objfile): Likewise.
2119         (free_all_objfiles): Use all_objfiles_safe.
2120         (objfile_purge_solibs): Likewise.
2121
2122 2019-01-09  Tom Tromey  <tom@tromey.com>
2123
2124         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2125         (expand_symtab_containing_pc, lookup_static_symbol)
2126         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2127         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2128         all_objfiles.
2129         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2130         * breakpoint.c (create_overlay_event_breakpoint)
2131         (create_longjmp_master_breakpoint)
2132         (create_std_terminate_master_breakpoint)
2133         (create_exception_master_breakpoint): Use all_objfiles.
2134         * linux-thread-db.c (try_thread_db_load_from_pdir)
2135         (has_libpthread): Use all_objfiles.
2136         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2137         * linespec.c (iterate_over_all_matching_symtabs)
2138         (search_minsyms_for_name): Use all_objfiles.
2139         * maint.c (maintenance_info_sections): Use all_objfiles.
2140         * main.c (captured_main_1): Use all_objfiles.
2141         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2142         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2143         * guile/scm-pretty-print.c
2144         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2145         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2146         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2147         (maintenance_print_msymbols): Use all_objfiles.
2148         * source.c (select_source_symtab): Use all_objfiles.
2149         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2150         * symfile.c (remove_symbol_file_command)
2151         (expand_symtabs_matching, map_symbol_filenames): Use
2152         all_objfiles.
2153         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2154         all_objfiles.
2155         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2156         * objc-lang.c (find_methods): Use all_objfiles.
2157         * objfiles.c (have_partial_symbols, have_full_symbols)
2158         (have_minimal_symbols, qsort_cmp)
2159         (default_iterate_over_objfiles_in_search_order): Use
2160         all_objfiles.
2161         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2162         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2163         (maintenance_check_psymtabs): Use all_objfiles.
2164         (ALL_PSYMTABS): Remove.
2165         * compile/compile-object-run.c (do_module_cleanup): Use
2166         all_objfiles.
2167         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2168         * cp-support.c (add_symbol_overload_list_qualified): Use
2169         all_objfiles.
2170         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2171         Use all_objfiles.
2172         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2173         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2174         all_objfiles.
2175         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2176         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2177         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2178         Uses all_objfiles.
2179         * solib.c (solib_read_symbols): Use all_objfiles
2180
2181 2019-01-09  Tom Tromey  <tom@tromey.com>
2182
2183         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2184         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2185         all_objfiles.
2186         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2187         * symmisc.c (print_symbol_bcache_statistics)
2188         (print_objfile_statistics, maintenance_print_objfiles)
2189         (maintenance_info_symtabs, maintenance_check_symtabs)
2190         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2191         all_objfiles.
2192         * source.c (forget_cached_source_info): Use all_objfiles.
2193         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2194         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2195         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2196         * objfiles.c (update_section_map): Use all_objfiles.
2197         (shared_objfile_contains_address_p): Likewise.
2198         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2199         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2200
2201 2019-01-09  Tom Tromey  <tom@tromey.com>
2202
2203         * common/next-iterator.h: New file.
2204         * objfiles.h (class all_objfiles): New.
2205         (struct objfile_iterator): New.
2206
2207 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2208
2209         * NEWS: Move the description of the changed "frame", "select-frame",
2210          and "info frame" commands to the Changed commands section.
2211
2212 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2213
2214         * gdbtypes.c (check_stub_method_group): Remove handling of old
2215         mangling schemes.
2216         * linespec.c (find_methods): Likewise.
2217         * stabsread.c (read_member_functions): Likewise.
2218         * valops.c (search_struct_method): Likewise.
2219         (value_struct_elt_for_reference): Likewise.
2220         * NEWS: Mention this change.
2221
2222 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2223
2224         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2225         print_source_lines.
2226         * source.c (print_source_lines_base): Update line number check.
2227         (print_source_lines): New function.
2228         (source_lines_range::source_lines_range): New function.
2229         * source.h (class source_lines_range): New class.
2230         (print_source_lines): New declaration.
2231
2232 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2233
2234         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2235
2236 2019-01-08  Tom Tromey  <tom@tromey.com>
2237             Simon Marchi  <simon.marchi@ericsson.com>
2238
2239         PR gdb/24060
2240         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2241         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2242         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2243         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2244         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2245         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2246
2247 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2248
2249         * source.c (select_source_symtab): Move header comment to
2250         declaration in source.h.
2251         (forget_cached_source_info_for_objfile): Likewise.
2252         (forget_cached_source_info): Likewise.
2253         (identify_source_line): Likewise.
2254         * source.h (identify_source_line): Move declaration from symtab.h
2255         and add comment from source.c
2256         (print_source_lines): Likewise.
2257         (forget_cached_source_info_for_objfile): Likewise.
2258         (forget_cached_source_info): Likewise.
2259         (select_source_symtab): Likewise.
2260         (enum print_source_lines_flag): Move definition from symtab.h.
2261         * symtab.h (identify_source_line): Move declaration to source.h.
2262         (print_source_lines): Likewise.
2263         (forget_cached_source_info_for_objfile): Likewise.
2264         (forget_cached_source_info): Likewise.
2265         (select_source_symtab): Likewise.
2266         (enum print_source_lines_flag): Move definition to source.h.
2267         * tui/tui-hooks.c: Add 'source.h' include.
2268
2269 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2270
2271         * source.c (print_source_lines_base): Handle requests to print
2272         reverse line number sequences, and guard against empty lines
2273         string.
2274
2275 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2276
2277         * source.c (print_source_lines_base): Fix skip of '\r' if next
2278         character is '\n'.
2279
2280 2019-01-06  Tom Tromey  <tom@tromey.com>
2281
2282         * c-exp.y (struct c_parse_state) <macro_original_text,
2283         expansion_obstack>: New member.
2284         (macro_original_text, expansion_obstack): Remove globals.
2285         (scan_macro_expansion, scanning_macro_expansion)
2286         (finished_macro_expansion): Update.
2287         (scan_macro_cleanup): Remove.
2288         (yylex, c_parse): Update.
2289
2290 2019-01-06  Tom Tromey  <tom@tromey.com>
2291
2292         * c-exp.y (struct c_parse_state) <strings>: New member.
2293         (operator_stoken): Update.
2294
2295 2019-01-06  Tom Tromey  <tom@tromey.com>
2296
2297         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2298         (union type_stack_elt) <typelist_val>: Now a pointer to
2299         std::vector.
2300         (type_stack_cleanup): Don't declare.
2301         (push_typelist): Update.
2302         * parse.c (pop_typelist): Return a std::vector.
2303         (push_typelist): Take a std::vector.
2304         (follow_types): Update.  Do not free args.
2305         (type_stack_cleanup): Remove.
2306         * c-exp.y (struct c_parse_state): New.
2307         (cpstate): New global.
2308         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2309         (nonempty_typelist): Update.
2310         (func_mod): Create a new vector.
2311         (c_parse): Create a c_parse_state.
2312         (check_parameter_typelist): Do not delete params.
2313         (function_method): Update.  Do not delete type_list.
2314
2315 2019-01-06  Tom Tromey  <tom@tromey.com>
2316
2317         PR gdb/28155:
2318         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2319         check_typedef.
2320         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2321         (print_return_value): Likewise.
2322
2323 2019-01-05  Tom Tromey  <tom@tromey.com>
2324
2325         * contrib/cleanup_check.py: Remove.
2326         * contrib/gcc-with-excheck: Remove.
2327         * contrib/exsummary.py: Remove.
2328         * contrib/excheck.py: Remove.
2329
2330 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2331
2332         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2333         NULL. Initialize tpprev to NULL instead of assigning it
2334         to NULL on the next statement.
2335         * windows-nat.c (windows_delete_thread): Remove check for
2336         main_thread_id before printing thread exit notifications.
2337         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2338         Remove thread ID check against main_thread_id.
2339         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2340         windows_delete_thread.
2341         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2342
2343 2019-01-04  Tom Tromey  <tom@tromey.com>
2344
2345         * compile/compile.c (_initialize_compile): Use upper case for
2346         metasyntactic variables.
2347         * symmisc.c (_initialize_symmisc): Use upper case for
2348         metasyntactic variables.
2349         * psymtab.c (_initialize_psymtab): Use upper case for
2350         metasyntactic variables.
2351         * demangle.c (demangle_command): Use upper case for metasyntactic
2352         variables.
2353         (_initialize_demangler): Likewise.
2354         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2355         variables.
2356
2357 2019-01-03  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2360
2361 2019-01-03  Tom Tromey  <tom@tromey.com>
2362
2363         * python/py-symtab.c (salpy_str): Update.
2364         (struct salpy_sal_object) <symtab>: Now a PyObject.
2365         (salpy_dealloc): Update.
2366         (del_objfile_sal): Use gdbpy_ref.
2367
2368 2019-01-03  Tom Tromey  <tom@tromey.com>
2369
2370         * python/py-type.c (convert_field): Use new_reference.  Return
2371         gdbpy_ref.
2372         (make_fielditem): Return gdbpy_ref.
2373         (typy_fields): Update.
2374         (typy_getitem): Update.
2375         (field_name): Return gdbpy_ref.  Use new_reference.
2376         (typy_iterator_iternext): Update.
2377
2378 2019-01-03  Tom Tromey  <tom@tromey.com>
2379
2380         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2381
2382 2019-01-03  Tom Tromey  <tom@tromey.com>
2383
2384         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2385         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2386         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2387         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2388         (pspy_set_type_printers): Likewise.
2389         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2390         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2391         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2392         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2393         (objfpy_set_type_printers): Likewise.
2394
2395 2019-01-03  Tom Tromey  <tom@tromey.com>
2396
2397         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2398         (gdbpy_print_stack): Use gdbpy_err_fetch.
2399         * python/python-internal.h (class gdbpy_err_fetch): New class.
2400         (class gdbpy_enter) <m_error_type, m_error_value,
2401         m_error_traceback>: Remove.
2402         <m_error>: New member.
2403         (gdbpy_exception_to_string): Don't declare.
2404         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2405         * python/py-value.c (convert_value_from_python): Use
2406         gdbpy_err_fetch.
2407         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2408         gdbpy_exception_to_string.
2409         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2410         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2411         gdbpy_err_fetch.
2412
2413 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2414
2415         * linux-nat.c (delete_lwp_cleanup): Delete.
2416         (struct lwp_deleter): New struct.
2417         (lwp_info_up): New typedef.
2418         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2419         lwp_info_up.
2420
2421 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2422
2423         * linux-fork.c (class scoped_switch_fork_info): New class.
2424         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2425
2426 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2427
2428         * valops.c (find_overload_match): Remove use of null_cleanup, and
2429         calls to do_cleanups.
2430
2431 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2432
2433         * compile/compile-cplus-types.c
2434         (compile_cplus_instance::decl_name): Handle changes to
2435         cp_func_name.
2436         * cp-support.c (cp_func_name): Update header comment, update
2437         return type.
2438         * cp-support.h (cp_func_name): Update return type in declaration.
2439         * valops.c (find_overload_match): Move temp_func local to top
2440         level of function and change its type.  Use temp_func to hold and
2441         delete temporary string obtained from cp_func_name.
2442
2443 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2444
2445         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2446         gdb::char_vector, remove cleanup, and update uses of `msg`.
2447
2448 2019-01-03  Jim Wilson  <jimw@sifive.com>
2449
2450         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2451
2452 2019-01-02  Tom Tromey  <tom@tromey.com>
2453
2454         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2455         (tdesc_parse_xml): Remove cleanups.
2456         * target-descriptions.h (make_cleanup_free_target_description):
2457         Don't declare.
2458         (target_desc_deleter): New struct.
2459         (target_desc_up): New typedef.
2460         * target-descriptions.c (target_desc_deleter::operator()): Rename
2461         from free_target_description.
2462         (make_cleanup_free_target_description): Remove.
2463
2464 2019-01-02  Tom Tromey  <tom@tromey.com>
2465
2466         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2467         constructor, destructor.
2468         (linespec_parser): Remove typedef.
2469         (~linespec_parser): Rename from linespec_parser_delete.
2470         (linespec_lex_to_end, linespec_complete_label)
2471         (linespec_complete): Update.
2472         (decode_line_full): Remove cleanups.
2473         (decode_line_1): Update.
2474
2475 2019-01-02  Tom Tromey  <tom@tromey.com>
2476
2477         * python/python-internal.h (inferior_to_inferior_object): Change
2478         return type.
2479         * python/py-exitedevent.c (create_exited_event_object): Update.
2480         * python/py-inferior.c (inferior_to_inferior_object): Return
2481         gdbpy_ref.
2482         (python_new_inferior, python_inferior_deleted)
2483         (thread_to_thread_object, delete_thread_object)
2484         (build_inferior_list, gdbpy_selected_inferior): Update.
2485         * python/py-infthread.c (create_thread_object): Update.  Also fail
2486         if inferior_to_inferior_object fails.
2487
2488 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2489
2490         * inferior.h (class inferior) <displaced_step_state>: New field.
2491         * infrun.h (struct displaced_step_state): Move here from
2492         infrun.c.  Initialize fields, add constructor.
2493         <inf>: Remove field.
2494         <reset>: New method.
2495         * infrun.c (struct displaced_step_inferior_state): Move to
2496         infrun.h.
2497         (displaced_step_inferior_states): Remove.
2498         (get_displaced_stepping_state): Adust.
2499         (displaced_step_in_progress_any_inferior): Adjust.
2500         (displaced_step_in_progress_thread): Adjust.
2501         (displaced_step_in_progress): Adjust.
2502         (add_displaced_stepping_state): Remove.
2503         (get_displaced_step_closure_by_addr): Adjust.
2504         (remove_displaced_stepping_state): Remove.
2505         (infrun_inferior_exit): Call displaced_step_state.reset.
2506         (use_displaced_stepping): Don't check for NULL.
2507         (displaced_step_prepare_throw): Call
2508         get_displaced_stepping_state.
2509         (displaced_step_fixup): Don't check for NULL.
2510         (prepare_for_detach): Don't check for NULL.
2511
2512 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2513
2514         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2515          in case of call that did not complete.
2516
2517 2019-01-02  Andrey Utkin  <autkin@undo.io>
2518
2519         * symfile.c (find_separate_debug_file): Fix search of debug files for
2520         remote debuggee.
2521
2522 2019-01-02  Tom Tromey  <tom@tromey.com>
2523
2524         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2525         indentation.
2526         * python/py-frame.c (frapy_older): Remove cast.
2527         (frapy_newer): Likewise.
2528         * python/py-breakpoint.c (local_setattro): Remove cast.
2529         * python/py-arch.c (archpy_name): Remove local variable.
2530         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2531
2532 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2533
2534         * unittests/basic_string_view/element_access/char/empty.cc:
2535         Fix year range in copyright header.
2536
2537 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2538
2539         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2540         Delete.
2541         <operator==>: Update with for removed field.
2542         <hash>: Likewise.
2543         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2544         <isa_features>: ...this.
2545         <abi_features>: New field.
2546         (riscv_isa_flen): Update comment.
2547         (riscv_abi_xlen): New declaration.
2548         (riscv_abi_flen): New declaration.
2549         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2550         isa_features.
2551         (riscv_abi_xlen): New function.
2552         (riscv_isa_flen): Update to get answer from isa_features.
2553         (riscv_abi_flen): New function.
2554         (riscv_has_fp_abi): Update to get answer from abi_features.
2555         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2556         xlen and flen.
2557         (riscv_call_info) <xlen, flen>: Update comment.
2558         (riscv_call_arg_struct): Remove invalid assertions
2559         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2560         is removed.
2561         (riscv_gdbarch_init): Gather isa features and abi features
2562         separately, ensure both match on the gdbarch when reusing an old
2563         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2564         a target with 64-bit float hardware.
2565
2566 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2567
2568         * source.c (search_command_helper): Stop reverse search
2569         when line 1 has been searched.
2570
2571 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2572
2573         * record-full.c (record_full_base_target::close): Rewrite
2574         record_full_core_buf_list free logic.
2575
2576 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2577
2578         * break-catch-syscall.c (print_one_catch_syscall): xfree
2579         the last text.
2580
2581 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2582
2583         * top.c (print_gdb_version): Update Copyright year in version
2584         message.
2585
2586 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2587
2588         Update copyright year range in all GDB files.
2589
2590 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2591
2592         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2593
2594 For older changes see ChangeLog-2018.
2595 \f
2596 Local Variables:
2597 mode: change-log
2598 left-margin: 8
2599 fill-column: 74
2600 version-control: never
2601 coding: utf-8
2602 End:
2603