gdb/ChangeLog

   1 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * aix-thread.c (ptid_cmp): Remove unused variable.
   4         (get_signaled_thread): Likewise.
   5         (store_regs_user_thread): Likewise.
   6         (store_regs_kernel_thread): Likewise.
   7         (fetch_regs_kernel_thread): Remove shadowed variable.
   8
   9 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  10
  11         * features/riscv/32bit-cpu.xml: Add register numbers.
  12         * features/riscv/32bit-fpu.c: Regenerate.
  13         * features/riscv/32bit-fpu.xml: Add register numbers.
  14         * features/riscv/64bit-cpu.xml: Add register numbers.
  15         * features/riscv/64bit-fpu.c: Regenerate.
  16         * features/riscv/64bit-fpu.xml: Add register numbers.
  17
  18 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
  19
  20         * NEWS: Mention two argument form of gdb.Value constructor.
  21         * python/py-value.c (convert_buffer_and_type_to_value): New
  22         function.
  23         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
  24         Add support for handling an optional second argument.  Call
  25         convert_buffer_and_type_to_value as appropriate.
  26         * python/python-internal.h (Py_buffer_deleter): New struct.
  27         (Py_buffer_up): New typedef.
  28
  29 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  30
  31         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  32         instead of releasing ownership.
  33
  34 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  35
  36         * dwarf2read.c (open_and_init_dwp_file): Call
  37         elf_numsections instead of bfd_count_sections to initialize
  38         dwp_file->num_sections.
  39
  40 2019-02-25  Tom Tromey  <tromey@adacore.com>
  41
  42         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  43
  44 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  45
  46         * gcore.in: Add '--readnever' option when invoking GDB.
  47
  48 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  49
  50         * MAINTAINERS: Update my email address.
  51
  52 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  53
  54         * build-id.c (build_id_to_debug_bfd_1): New function.
  55         (build_id_to_debug_bfd): Look for separate debug file in
  56         sysroot.
  57
  58 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  59
  60         * gdbarch.sh: Update the copyright year range that is placed into
  61         generated files.
  62
  63 2019-02-22  Keith Seitz  <keiths@redhat.com>
  64
  65         PR symtab/23853
  66         * linespec.c (create_sals_line_offset): Search for the default
  67         symtab's filename instead of its fullname.
  68
  69 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  70
  71         * NEWS: Update style defaults.
  72
  73 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  74
  75         * main.c (captured_main_1): Disable styling in batch mode.
  76
  77 2019-02-20  Tom Tromey  <tom@tromey.com>
  78
  79         * symtab.c (symtab_symbol_info): Fix typos.
  80
  81 2019-02-20  Tom Tromey  <tromey@adacore.com>
  82
  83         * findcmd.c (_initialize_mem_search): Use upper case for
  84         metasyntactic variables.
  85
  86 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  87
  88         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  89         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  90
  91 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  92
  93         * top.h (source_file_name): Change to std::string.
  94         * top.c (source_file_name): Likewise.
  95         (command_line_input): Adjust.
  96         * cli/cli-script.c (script_from_file): Adjust.
  97
  98 2019-02-19  Tom Tromey  <tromey@adacore.com>
  99
 100         * ravenscar-thread.c
 101         (ravenscar_thread_target::update_thread_list): Don't call
 102         ada_build_task_list.
 103         * ada-lang.h (ada_build_task_list): Don't declare.
 104         * ada-tasks.c (struct ada_tasks_inferior_data)
 105         <task_list_valid_p>: Now bool.
 106         (read_known_tasks, ada_task_list_changed)
 107         (ada_tasks_invalidate_inferior_data): Update.
 108         (read_known_tasks_array): Return bool.
 109         (read_known_tasks_list): Likewise.
 110         (read_known_tasks): Return void.
 111         (ada_build_task_list): Now static.
 112
 113 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 114
 115         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 116         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 117
 118 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 119
 120         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 121         variant for ada_tasks_pspace_data_handle and
 122         ada_tasks_inferior_data_handle.
 123         (ada_tasks_pspace_data_cleanup): New function.
 124         (ada_tasks_inferior_data_cleanup): New function.
 125
 126 2019-02-17  Tom Tromey  <tom@tromey.com>
 127
 128         * macrotab.h (macro_source_fullname): Return a std::string.
 129         * macrotab.c (macro_include, check_for_redefinition)
 130         (macro_undef, macro_lookup_definition, foreach_macro)
 131         (foreach_macro_in_scope): Update.
 132         (macro_source_fullname): Return a std::string.
 133         * macrocmd.c (show_pp_source_pos): Update.
 134
 135 2019-02-17  Tom Tromey  <tom@tromey.com>
 136
 137         * macrocmd.c (show_pp_source_pos): Style the file names.
 138
 139 2019-02-17  Tom Tromey  <tom@tromey.com>
 140
 141         PR tui/24197:
 142         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 143
 144 2019-02-17  Tom Tromey  <tom@tromey.com>
 145
 146         * ada-lang.c (user_select_syms): Use filtered printing.
 147         * utils.c (wrap_style): New global.
 148         (desired_style): Remove.
 149         (emit_style_escape): Add stream parameter.
 150         (set_output_style, reset_terminal_style, prompt_for_continue):
 151         Update.
 152         (flush_wrap_buffer): Only flush gdb_stdout.
 153         (wrap_here): Set wrap_style.
 154         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 155         treat escape sequences as a character.  Change when wrap buffer is
 156         flushed.
 157         (fputs_styled): Do not set the output style when the default is
 158         requested.
 159         * ui-style.h (struct ui_file_style) <is_default>: New method.
 160         * source.c (print_source_lines_base): Emit escape sequences in one
 161         piece.
 162
 163 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 164
 165         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 166         integers and enumeration types.
 167
 168 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 169
 170         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 171         instead of lookup_symbol_in_language
 172         (do_exact_match): New function.
 173         (ada_get_symbol_name_matcher): Return do_exact_match when
 174         doing a verbatim match.
 175
 176 2019-02-15  Tom Tromey  <tromey@adacore.com>
 177
 178         * ravenscar-thread.c (ravenscar_thread_target::resume)
 179         (ravenscar_thread_target::wait): Special case wildcard requests.
 180
 181 2019-02-15  Tom Tromey  <tromey@adacore.com>
 182
 183         * ravenscar-thread.c (base_ptid): Remove.
 184         (struct ravenscar_thread_target) <close>: New method.
 185         <m_base_ptid>: New member.
 186         <update_inferior_ptid, active_task, task_is_currently_active,
 187         runtime_initialized>: Declare methods.
 188         <ravenscar_thread_target>: Add constructor.
 189         (ravenscar_thread_target::task_is_currently_active)
 190         (ravenscar_thread_target::update_inferior_ptid)
 191         (ravenscar_runtime_initialized): Rename.  Now methods.
 192         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 193         (ravenscar_thread_target::update_thread_list): Update.
 194         (ravenscar_thread_target::active_task): Now method.
 195         (ravenscar_thread_target::store_registers)
 196         (ravenscar_thread_target::prepare_to_store)
 197         (ravenscar_thread_target::prepare_to_store)
 198         (ravenscar_thread_target::mourn_inferior): Update.
 199         (ravenscar_inferior_created): Use "new" to create target.
 200         (ravenscar_thread_target::get_ada_task_ptid): Update.
 201         (_initialize_ravenscar): Don't initialize base_ptid.
 202         (ravenscar_ops): Remove global.
 203
 204 2019-02-15  Tom Tromey  <tromey@adacore.com>
 205
 206         * target.h (push_target): Declare new overload.
 207         * target.c (push_target): New overload, taking an rvalue reference.
 208         * remote.c (remote_target::open_1): Use push_target overload.
 209         * corelow.c (core_target_open): Use push_target overload.
 210
 211 2019-02-15  Tom Tromey  <tromey@adacore.com>
 212
 213         * ravenscar-thread.c (is_ravenscar_task)
 214         (ravenscar_task_is_currently_active): Return bool.
 215         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 216         (_initialize_ravenscar): Remove "(void)".
 217         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 218         Return bool.
 219
 220 2019-02-15  Tom Tromey  <tromey@adacore.com>
 221
 222         * ravenscar-thread.c (ravenscar_runtime_initializer)
 223         (has_ravenscar_runtime, get_running_thread_id)
 224         (ravenscar_thread_target::resume): Fix indentation.
 225
 226 2019-02-15  Tom Tromey  <tromey@adacore.com>
 227
 228         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 229         from ravenscar_arch_ops.
 230         (sparc_ravenscar_ops::fetch_registers)
 231         (sparc_ravenscar_ops::store_registers): Now methods.
 232         (sparc_ravenscar_prepare_to_store): Remove.
 233         (sparc_ravenscar_ops): Redefine.
 234         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 235         methods and destructor.  Remove members.
 236         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 237         (ravenscar_thread_target::store_registers)
 238         (ravenscar_thread_target::prepare_to_store): Update.
 239         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 240         Remove.
 241         (struct ppc_ravenscar_powerpc_ops): Derive from
 242         ravenscar_arch_ops.
 243         (ppc_ravenscar_powerpc_ops::fetch_registers)
 244         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 245         (ppc_ravenscar_powerpc_ops): Redefine.
 246         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 247         (ppc_ravenscar_e500_ops::fetch_registers)
 248         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 249         (ppc_ravenscar_e500_ops): Redefine.
 250         * aarch64-ravenscar-thread.c
 251         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 252         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 253         (aarch64_ravenscar_fetch_registers)
 254         (aarch64_ravenscar_store_registers): Now methods.
 255         (aarch64_ravenscar_ops): Redefine.
 256
 257 2019-02-15  Tom Tromey  <tromey@adacore.com>
 258
 259         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 260         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 261         (ravenscar_thread_target::stopped_by_watchpoint)
 262         (ravenscar_thread_target::stopped_data_address)
 263         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 264
 265 2019-02-15  Tom Tromey  <tromey@adacore.com>
 266
 267         * ravenscar-thread.c: Fix some typos.
 268
 269 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 270             Tom Tromey  <tromey@adacore.com>
 271
 272         * ada-lang.c (ada_exception_sal): Change addr_string to a
 273         std::string.
 274         (create_ada_exception_catchpoint): Update.
 275
 276 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 277             Tom Tromey  <tromey@adacore.com>
 278
 279         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 280         (bp_location_ops): Remove.
 281         (base_breakpoint_allocate_location): Update.
 282         (free_bp_location): Update.
 283         * ada-lang.c (class ada_catchpoint_location)
 284         <ada_catchpoint_location>: Remove ops parameter.
 285         (ada_catchpoint_location_dtor): Remove.
 286         (ada_catchpoint_location_ops): Remove.
 287         (allocate_location_exception): Update.
 288         * breakpoint.h (struct bp_location_ops): Remove.
 289         (class bp_location) <bp_location>: Remove bp_location_ops
 290         parameter.
 291         <~bp_location>: Add destructor.
 292         <ops>: Remove.
 293
 294 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 295             Pedro Alves  <palves@redhat.com>
 296
 297         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 298         'PATH_MAX'.
 299
 300 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 301             Samuel Thibault  <samuel.thibault@gnu.org>
 302             Thomas Schwinge  <thomas@codesourcery.com>
 303
 304         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 305         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 306
 307 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 308
 309         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 310         (check_empty): Use "const char *".
 311
 312         * gnu-nat.c (gnu_nat_target::detach): Instead of
 313         'detach_inferior (pid)' call
 314         'detach_inferior (find_inferior_pid (pid))'.
 315
 316         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 317         'nat/fork-inferior.o'.
 318         * gnu-nat.c: #include "nat/fork-inferior.h".
 319
 320         * gnu-nat.c (gnu_nat_target::detach): Instead of
 321         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 322         * gnu-nat.h: #include "inf-child.h".
 323         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 324         'i386_gnu_nat_target::fetch_registers'.
 325         (gnu_store_registers): Rename/move to
 326         'i386_gnu_nat_target::store_registers'.
 327
 328         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 329         * gnu-nat.h (mach_thread_info): New function.
 330         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 331
 332         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 333
 334 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 335
 336         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 337
 338 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 339
 340         * windows-nat.c (windows_add_thread): Add new parameter
 341         "main_thread_p" with default value set to false.  Update
 342         function documentation as well as all callers.
 343         (windows_delete_thread): Likewise.
 344         (fake_create_process): Update call to windows_add_thread.
 345         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 346         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 347         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 348         call to windows_delete_thread.
 349
 350 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 351
 352         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 353
 354 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 355
 356         * symfile.c (find_separate_debug_file): Use canonical path of
 357         sysroot with child_path instead of gdb_sysroot if it is valid.
 358
 359 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 360
 361         * symfile.c (find_separate_debug_file): Use child_path to
 362         determine if an object file is under a sysroot.
 363
 364 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 365
 366         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 367         unittests/child-path-selftests.c.
 368         * common/pathstuff.c (child_path): New function.
 369         * common/pathstuff.h (child_path): New prototype.
 370         * unittests/child-path-selftests.c: New file.
 371
 372 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 373
 374         * symfile.c (find_separate_debug_file): Look for separate debug
 375         files in debug directories under the sysroot.
 376
 377 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 378
 379         * symtab.h (struct minimal_symbol data_p): New const method.
 380         (struct minimal_symbol text_p): Likewise.
 381         * symtab.c (output_source_filename): Use file name style
 382         to print file name.
 383         (print_symbol_info): Likewise.
 384         (print_msymbol_info): Use address style to print addresses.
 385         Use function name style to print executable text symbols.
 386         (expand_symtab_containing_pc): Use data_p.
 387         (find_pc_sect_compunit_symtab): Likewise.
 388
 389 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 390
 391         * breakpoint.c (describe_other_breakpoints): Use address style
 392         to print addresses.
 393         (say_where): Likewise.
 394
 395 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 396
 397         * ada-typeprint.c (print_func_type): Print function name
 398         style to print function name.
 399         * c-typeprint.c (c_print_type_1): Likewise.
 400
 401 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 402
 403         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 404         for execve.
 405
 406 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 407
 408         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 409         type_stack.
 410
 411 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 412
 413         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 414         TYPE_CODE_REF types.
 415
 416 2019-02-08  Jim Wilson  <jimw@sifive.com>
 417
 418         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 419         (riscv_linux_fregset): New.
 420         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 421
 422 2019-02-07  Tom Tromey  <tom@tromey.com>
 423
 424         * thread.c (thread_cancel_execution_command): Update.
 425         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 426         methods.
 427         (struct thread_fsm_ops): Remove.
 428         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 429         (thread_fsm_should_stop, thread_fsm_return_value)
 430         (thread_fsm_set_finished, thread_fsm_finished_p)
 431         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 432         Don't declare.
 433         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 434         * infrun.c (clear_proceed_status_thread)
 435         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 436         (print_stop_event): Update.
 437         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 438         Add constructor.
 439         (step_command_fsm_ops): Remove.
 440         (new_step_command_fsm): Remove.
 441         (step_1): Update.
 442         (step_command_fsm::should_stop): Rename from
 443         step_command_fsm_should_stop.
 444         (step_command_fsm::clean_up): Rename from
 445         step_command_fsm_clean_up.
 446         (step_command_fsm::do_async_reply_reason): Rename from
 447         step_command_fsm_async_reply_reason.
 448         (struct until_next_fsm): Inherit from thread_fsm.  Add
 449         constructor.
 450         (until_next_fsm_ops): Remove.
 451         (new_until_next_fsm): Remove.
 452         (until_next_fsm::should_stop): Rename from
 453         until_next_fsm_should_stop.
 454         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 455         (until_next_fsm::do_async_reply_reason): Rename from
 456         until_next_fsm_async_reply_reason.
 457         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 458         constructor.  Change type of breakpoint.
 459         (finish_command_fsm_ops): Remove.
 460         (new_finish_command_fsm): Remove.
 461         (finish_command_fsm::should_stop): Rename from
 462         finish_command_fsm_should_stop.
 463         (finish_command_fsm::clean_up): Rename from
 464         finish_command_fsm_clean_up.
 465         (finish_command_fsm::return_value): Rename from
 466         finish_command_fsm_return_value.
 467         (finish_command_fsm::do_async_reply_reason): Rename from
 468         finish_command_fsm_async_reply_reason.
 469         (finish_command): Update.
 470         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 471         Add constructor.
 472         (call_thread_fsm_ops): Remove.
 473         (call_thread_fsm::call_thread_fsm): Rename from
 474         new_call_thread_fsm.
 475         (call_thread_fsm::should_stop): Rename from
 476         call_thread_fsm_should_stop.
 477         (call_thread_fsm::should_notify_stop): Rename from
 478         call_thread_fsm_should_notify_stop.
 479         (run_inferior_call, call_function_by_hand_dummy): Update.
 480         * cli/cli-interp.c (should_print_stop_to_console): Update.
 481         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 482         Add constructor.  Change type of location_breakpoint,
 483         caller_breakpoint.
 484         (until_break_fsm_ops): Remove.
 485         (new_until_break_fsm): Remove.
 486         (until_break_fsm::should_stop): Rename from
 487         until_break_fsm_should_stop.
 488         (until_break_fsm::clean_up): Rename from
 489         until_break_fsm_clean_up.
 490         (until_break_fsm::do_async_reply_reason): Rename from
 491         until_break_fsm_async_reply_reason.
 492         (until_break_command): Update.
 493         * thread-fsm.c: Remove.
 494         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 495
 496 2019-02-07  Tom Tromey  <tom@tromey.com>
 497
 498         * yy-remap.h: Add include guard.
 499         * xtensa-tdep.h: Add include guard.
 500         * xcoffread.h: Rename include guard.
 501         * varobj-iter.h: Add include guard.
 502         * tui/tui.h: Rename include guard.
 503         * tui/tui-winsource.h: Rename include guard.
 504         * tui/tui-wingeneral.h: Rename include guard.
 505         * tui/tui-windata.h: Rename include guard.
 506         * tui/tui-win.h: Rename include guard.
 507         * tui/tui-stack.h: Rename include guard.
 508         * tui/tui-source.h: Rename include guard.
 509         * tui/tui-regs.h: Rename include guard.
 510         * tui/tui-out.h: Rename include guard.
 511         * tui/tui-layout.h: Rename include guard.
 512         * tui/tui-io.h: Rename include guard.
 513         * tui/tui-hooks.h: Rename include guard.
 514         * tui/tui-file.h: Rename include guard.
 515         * tui/tui-disasm.h: Rename include guard.
 516         * tui/tui-data.h: Rename include guard.
 517         * tui/tui-command.h: Rename include guard.
 518         * tic6x-tdep.h: Add include guard.
 519         * target/waitstatus.h: Rename include guard.
 520         * target/wait.h: Rename include guard.
 521         * target/target.h: Rename include guard.
 522         * target/resume.h: Rename include guard.
 523         * target-float.h: Rename include guard.
 524         * stabsread.h: Add include guard.
 525         * rs6000-tdep.h: Add include guard.
 526         * riscv-fbsd-tdep.h: Add include guard.
 527         * regformats/regdef.h: Rename include guard.
 528         * record.h: Rename include guard.
 529         * python/python.h: Rename include guard.
 530         * python/python-internal.h: Rename include guard.
 531         * python/py-stopevent.h: Rename include guard.
 532         * python/py-ref.h: Rename include guard.
 533         * python/py-record.h: Rename include guard.
 534         * python/py-record-full.h: Rename include guard.
 535         * python/py-record-btrace.h: Rename include guard.
 536         * python/py-instruction.h: Rename include guard.
 537         * python/py-events.h: Rename include guard.
 538         * python/py-event.h: Rename include guard.
 539         * procfs.h: Add include guard.
 540         * proc-utils.h: Add include guard.
 541         * p-lang.h: Add include guard.
 542         * or1k-tdep.h: Rename include guard.
 543         * observable.h: Rename include guard.
 544         * nto-tdep.h: Rename include guard.
 545         * nat/x86-linux.h: Rename include guard.
 546         * nat/x86-linux-dregs.h: Rename include guard.
 547         * nat/x86-gcc-cpuid.h: Add include guard.
 548         * nat/x86-dregs.h: Rename include guard.
 549         * nat/x86-cpuid.h: Rename include guard.
 550         * nat/ppc-linux.h: Rename include guard.
 551         * nat/mips-linux-watch.h: Rename include guard.
 552         * nat/linux-waitpid.h: Rename include guard.
 553         * nat/linux-ptrace.h: Rename include guard.
 554         * nat/linux-procfs.h: Rename include guard.
 555         * nat/linux-osdata.h: Rename include guard.
 556         * nat/linux-nat.h: Rename include guard.
 557         * nat/linux-namespaces.h: Rename include guard.
 558         * nat/linux-btrace.h: Rename include guard.
 559         * nat/glibc_thread_db.h: Rename include guard.
 560         * nat/gdb_thread_db.h: Rename include guard.
 561         * nat/gdb_ptrace.h: Rename include guard.
 562         * nat/fork-inferior.h: Rename include guard.
 563         * nat/amd64-linux-siginfo.h: Rename include guard.
 564         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 565         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 566         * nat/aarch64-linux.h: Rename include guard.
 567         * nat/aarch64-linux-hw-point.h: Rename include guard.
 568         * mn10300-tdep.h: Add include guard.
 569         * mips-linux-tdep.h: Add include guard.
 570         * mi/mi-parse.h: Rename include guard.
 571         * mi/mi-out.h: Rename include guard.
 572         * mi/mi-main.h: Rename include guard.
 573         * mi/mi-interp.h: Rename include guard.
 574         * mi/mi-getopt.h: Rename include guard.
 575         * mi/mi-console.h: Rename include guard.
 576         * mi/mi-common.h: Rename include guard.
 577         * mi/mi-cmds.h: Rename include guard.
 578         * mi/mi-cmd-break.h: Rename include guard.
 579         * m2-lang.h: Add include guard.
 580         * location.h: Rename include guard.
 581         * linux-record.h: Rename include guard.
 582         * linux-nat.h: Add include guard.
 583         * linux-fork.h: Add include guard.
 584         * i386-darwin-tdep.h: Rename include guard.
 585         * hppa-linux-offsets.h: Add include guard.
 586         * guile/guile.h: Rename include guard.
 587         * guile/guile-internal.h: Rename include guard.
 588         * gnu-nat.h: Rename include guard.
 589         * gdb-stabs.h: Rename include guard.
 590         * frv-tdep.h: Add include guard.
 591         * f-lang.h: Add include guard.
 592         * event-loop.h: Add include guard.
 593         * darwin-nat.h: Rename include guard.
 594         * cp-abi.h: Rename include guard.
 595         * config/sparc/nm-sol2.h: Rename include guard.
 596         * config/nm-nto.h: Rename include guard.
 597         * config/nm-linux.h: Add include guard.
 598         * config/i386/nm-i386gnu.h: Rename include guard.
 599         * config/djgpp/nl_types.h: Rename include guard.
 600         * config/djgpp/langinfo.h: Rename include guard.
 601         * compile/gcc-cp-plugin.h: Add include guard.
 602         * compile/gcc-c-plugin.h: Add include guard.
 603         * compile/compile.h: Rename include guard.
 604         * compile/compile-object-run.h: Rename include guard.
 605         * compile/compile-object-load.h: Rename include guard.
 606         * compile/compile-internal.h: Rename include guard.
 607         * compile/compile-cplus.h: Rename include guard.
 608         * compile/compile-c.h: Rename include guard.
 609         * common/xml-utils.h: Rename include guard.
 610         * common/x86-xstate.h: Rename include guard.
 611         * common/version.h: Rename include guard.
 612         * common/vec.h: Rename include guard.
 613         * common/tdesc.h: Rename include guard.
 614         * common/selftest.h: Rename include guard.
 615         * common/scoped_restore.h: Rename include guard.
 616         * common/scoped_mmap.h: Rename include guard.
 617         * common/scoped_fd.h: Rename include guard.
 618         * common/safe-iterator.h: Rename include guard.
 619         * common/run-time-clock.h: Rename include guard.
 620         * common/refcounted-object.h: Rename include guard.
 621         * common/queue.h: Rename include guard.
 622         * common/ptid.h: Rename include guard.
 623         * common/print-utils.h: Rename include guard.
 624         * common/preprocessor.h: Rename include guard.
 625         * common/pathstuff.h: Rename include guard.
 626         * common/observable.h: Rename include guard.
 627         * common/netstuff.h: Rename include guard.
 628         * common/job-control.h: Rename include guard.
 629         * common/host-defs.h: Rename include guard.
 630         * common/gdb_wait.h: Rename include guard.
 631         * common/gdb_vecs.h: Rename include guard.
 632         * common/gdb_unlinker.h: Rename include guard.
 633         * common/gdb_unique_ptr.h: Rename include guard.
 634         * common/gdb_tilde_expand.h: Rename include guard.
 635         * common/gdb_sys_time.h: Rename include guard.
 636         * common/gdb_string_view.h: Rename include guard.
 637         * common/gdb_splay_tree.h: Rename include guard.
 638         * common/gdb_setjmp.h: Rename include guard.
 639         * common/gdb_ref_ptr.h: Rename include guard.
 640         * common/gdb_optional.h: Rename include guard.
 641         * common/gdb_locale.h: Rename include guard.
 642         * common/gdb_assert.h: Rename include guard.
 643         * common/filtered-iterator.h: Rename include guard.
 644         * common/filestuff.h: Rename include guard.
 645         * common/fileio.h: Rename include guard.
 646         * common/environ.h: Rename include guard.
 647         * common/common-utils.h: Rename include guard.
 648         * common/common-types.h: Rename include guard.
 649         * common/common-regcache.h: Rename include guard.
 650         * common/common-inferior.h: Rename include guard.
 651         * common/common-gdbthread.h: Rename include guard.
 652         * common/common-exceptions.h: Rename include guard.
 653         * common/common-defs.h: Rename include guard.
 654         * common/common-debug.h: Rename include guard.
 655         * common/cleanups.h: Rename include guard.
 656         * common/buffer.h: Rename include guard.
 657         * common/btrace-common.h: Rename include guard.
 658         * common/break-common.h: Rename include guard.
 659         * cli/cli-utils.h: Rename include guard.
 660         * cli/cli-style.h: Rename include guard.
 661         * cli/cli-setshow.h: Rename include guard.
 662         * cli/cli-script.h: Rename include guard.
 663         * cli/cli-interp.h: Rename include guard.
 664         * cli/cli-decode.h: Rename include guard.
 665         * cli/cli-cmds.h: Rename include guard.
 666         * charset-list.h: Add include guard.
 667         * buildsym-legacy.h: Rename include guard.
 668         * bfin-tdep.h: Add include guard.
 669         * ax.h: Rename include guard.
 670         * arm-linux-tdep.h: Add include guard.
 671         * arm-fbsd-tdep.h: Add include guard.
 672         * arch/xtensa.h: Rename include guard.
 673         * arch/tic6x.h: Add include guard.
 674         * arch/i386.h: Add include guard.
 675         * arch/arm.h: Rename include guard.
 676         * arch/arm-linux.h: Rename include guard.
 677         * arch/arm-get-next-pcs.h: Rename include guard.
 678         * arch/amd64.h: Add include guard.
 679         * arch/aarch64-insn.h: Rename include guard.
 680         * arch-utils.h: Rename include guard.
 681         * annotate.h: Add include guard.
 682         * amd64-darwin-tdep.h: Rename include guard.
 683         * aarch64-linux-tdep.h: Add include guard.
 684         * aarch64-fbsd-tdep.h: Add include guard.
 685         * aarch32-linux-nat.h: Add include guard.
 686
 687 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 688
 689         * macrotab.c (macro_define_internal): New function that
 690         factorizes macro_define_object_internal and macro_define_function
 691         code.
 692         (macro_define_object_internal): Use macro_define_internal.
 693         (macro_define_function): Likewise.
 694
 695 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 696
 697         * macrocmd.c (extract_identifier): Return
 698         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 699         callers.
 700
 701 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 702
 703         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 704
 705 2019-02-05  Tom Tromey  <tom@tromey.com>
 706
 707         * target.c (target_stack::unpush): Move assertion earlier.
 708
 709 2019-01-30  Tom Tromey  <tom@tromey.com>
 710
 711         PR python/23615:
 712         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 713         (gdbpy_parse_and_eval): Likewise.
 714         * python/python-internal.h (gdbpy_allow_threads): New class.
 715
 716 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 717
 718         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 719         (aarch64_fbsd_fpregmap): Move earlier.
 720         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 721         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 722         instead of individual calls to trad_frame_set_reg_addr.
 723         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 724         earlier.
 725         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 726         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 727         instead of individual calls to trad_frame_set_reg_addr.
 728
 729 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 730
 731         * CONTRIBUTE: Replace contribution list with wiki link.
 732
 733 2019-01-25  Tom Tromey  <tom@tromey.com>
 734
 735         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 736
 737 2019-01-25  Tom Tromey  <tom@tromey.com>
 738
 739         * xtensa-linux-nat.c: Fix common/ includes.
 740         * xml-support.h: Fix common/ includes.
 741         * xml-support.c: Fix common/ includes.
 742         * x86-linux-nat.c: Fix common/ includes.
 743         * windows-nat.c: Fix common/ includes.
 744         * varobj.h: Fix common/ includes.
 745         * varobj.c: Fix common/ includes.
 746         * value.c: Fix common/ includes.
 747         * valops.c: Fix common/ includes.
 748         * utils.c: Fix common/ includes.
 749         * unittests/xml-utils-selftests.c: Fix common/ includes.
 750         * unittests/utils-selftests.c: Fix common/ includes.
 751         * unittests/unpack-selftests.c: Fix common/ includes.
 752         * unittests/tracepoint-selftests.c: Fix common/ includes.
 753         * unittests/style-selftests.c: Fix common/ includes.
 754         * unittests/string_view-selftests.c: Fix common/ includes.
 755         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 756         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 757         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 758         * unittests/rsp-low-selftests.c: Fix common/ includes.
 759         * unittests/parse-connection-spec-selftests.c: Fix common/
 760         includes.
 761         * unittests/optional-selftests.c: Fix common/ includes.
 762         * unittests/offset-type-selftests.c: Fix common/ includes.
 763         * unittests/observable-selftests.c: Fix common/ includes.
 764         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 765         * unittests/memrange-selftests.c: Fix common/ includes.
 766         * unittests/memory-map-selftests.c: Fix common/ includes.
 767         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 768         * unittests/function-view-selftests.c: Fix common/ includes.
 769         * unittests/environ-selftests.c: Fix common/ includes.
 770         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 771         * unittests/common-utils-selftests.c: Fix common/ includes.
 772         * unittests/cli-utils-selftests.c: Fix common/ includes.
 773         * unittests/array-view-selftests.c: Fix common/ includes.
 774         * ui-file.c: Fix common/ includes.
 775         * tui/tui-io.c: Fix common/ includes.
 776         * tracepoint.h: Fix common/ includes.
 777         * tracepoint.c: Fix common/ includes.
 778         * tracefile-tfile.c: Fix common/ includes.
 779         * top.h: Fix common/ includes.
 780         * top.c: Fix common/ includes.
 781         * thread.c: Fix common/ includes.
 782         * target/waitstatus.h: Fix common/ includes.
 783         * target/waitstatus.c: Fix common/ includes.
 784         * target.h: Fix common/ includes.
 785         * target.c: Fix common/ includes.
 786         * target-memory.c: Fix common/ includes.
 787         * target-descriptions.c: Fix common/ includes.
 788         * symtab.h: Fix common/ includes.
 789         * symfile.c: Fix common/ includes.
 790         * stap-probe.c: Fix common/ includes.
 791         * spu-linux-nat.c: Fix common/ includes.
 792         * sparc-nat.c: Fix common/ includes.
 793         * source.c: Fix common/ includes.
 794         * solib.c: Fix common/ includes.
 795         * solib-target.c: Fix common/ includes.
 796         * ser-unix.c: Fix common/ includes.
 797         * ser-tcp.c: Fix common/ includes.
 798         * ser-pipe.c: Fix common/ includes.
 799         * ser-base.c: Fix common/ includes.
 800         * selftest-arch.c: Fix common/ includes.
 801         * s12z-tdep.c: Fix common/ includes.
 802         * rust-exp.y: Fix common/ includes.
 803         * rs6000-aix-tdep.c: Fix common/ includes.
 804         * riscv-tdep.c: Fix common/ includes.
 805         * remote.c: Fix common/ includes.
 806         * remote-notif.h: Fix common/ includes.
 807         * remote-fileio.h: Fix common/ includes.
 808         * remote-fileio.c: Fix common/ includes.
 809         * regcache.h: Fix common/ includes.
 810         * regcache.c: Fix common/ includes.
 811         * record-btrace.c: Fix common/ includes.
 812         * python/python.c: Fix common/ includes.
 813         * python/py-type.c: Fix common/ includes.
 814         * python/py-inferior.c: Fix common/ includes.
 815         * progspace.h: Fix common/ includes.
 816         * producer.c: Fix common/ includes.
 817         * procfs.c: Fix common/ includes.
 818         * proc-api.c: Fix common/ includes.
 819         * printcmd.c: Fix common/ includes.
 820         * ppc-linux-nat.c: Fix common/ includes.
 821         * parser-defs.h: Fix common/ includes.
 822         * osdata.c: Fix common/ includes.
 823         * obsd-nat.c: Fix common/ includes.
 824         * nat/x86-linux.c: Fix common/ includes.
 825         * nat/x86-linux-dregs.c: Fix common/ includes.
 826         * nat/x86-dregs.h: Fix common/ includes.
 827         * nat/x86-dregs.c: Fix common/ includes.
 828         * nat/ppc-linux.c: Fix common/ includes.
 829         * nat/mips-linux-watch.h: Fix common/ includes.
 830         * nat/mips-linux-watch.c: Fix common/ includes.
 831         * nat/linux-waitpid.c: Fix common/ includes.
 832         * nat/linux-ptrace.h: Fix common/ includes.
 833         * nat/linux-ptrace.c: Fix common/ includes.
 834         * nat/linux-procfs.c: Fix common/ includes.
 835         * nat/linux-personality.c: Fix common/ includes.
 836         * nat/linux-osdata.c: Fix common/ includes.
 837         * nat/linux-namespaces.c: Fix common/ includes.
 838         * nat/linux-btrace.h: Fix common/ includes.
 839         * nat/linux-btrace.c: Fix common/ includes.
 840         * nat/fork-inferior.c: Fix common/ includes.
 841         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 842         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 843         * nat/aarch64-linux.c: Fix common/ includes.
 844         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 845         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 846         * namespace.h: Fix common/ includes.
 847         * mips-linux-tdep.c: Fix common/ includes.
 848         * minsyms.c: Fix common/ includes.
 849         * mi/mi-parse.h: Fix common/ includes.
 850         * mi/mi-main.c: Fix common/ includes.
 851         * mi/mi-cmd-env.c: Fix common/ includes.
 852         * memrange.h: Fix common/ includes.
 853         * memattr.c: Fix common/ includes.
 854         * maint.h: Fix common/ includes.
 855         * maint.c: Fix common/ includes.
 856         * main.c: Fix common/ includes.
 857         * machoread.c: Fix common/ includes.
 858         * location.c: Fix common/ includes.
 859         * linux-thread-db.c: Fix common/ includes.
 860         * linux-nat.c: Fix common/ includes.
 861         * linux-fork.c: Fix common/ includes.
 862         * inline-frame.c: Fix common/ includes.
 863         * infrun.c: Fix common/ includes.
 864         * inflow.c: Fix common/ includes.
 865         * inferior.h: Fix common/ includes.
 866         * inferior.c: Fix common/ includes.
 867         * infcmd.c: Fix common/ includes.
 868         * inf-ptrace.c: Fix common/ includes.
 869         * inf-child.c: Fix common/ includes.
 870         * ia64-linux-nat.c: Fix common/ includes.
 871         * i387-tdep.c: Fix common/ includes.
 872         * i386-tdep.c: Fix common/ includes.
 873         * i386-linux-tdep.c: Fix common/ includes.
 874         * i386-linux-nat.c: Fix common/ includes.
 875         * i386-go32-tdep.c: Fix common/ includes.
 876         * i386-fbsd-tdep.c: Fix common/ includes.
 877         * i386-fbsd-nat.c: Fix common/ includes.
 878         * guile/scm-type.c: Fix common/ includes.
 879         * guile/guile.c: Fix common/ includes.
 880         * go32-nat.c: Fix common/ includes.
 881         * gnu-nat.c: Fix common/ includes.
 882         * gdbthread.h: Fix common/ includes.
 883         * gdbarch-selftests.c: Fix common/ includes.
 884         * gdb_usleep.c: Fix common/ includes.
 885         * gdb_select.h: Fix common/ includes.
 886         * gdb_bfd.c: Fix common/ includes.
 887         * gcore.c: Fix common/ includes.
 888         * fork-child.c: Fix common/ includes.
 889         * findvar.c: Fix common/ includes.
 890         * fbsd-nat.c: Fix common/ includes.
 891         * event-top.c: Fix common/ includes.
 892         * event-loop.c: Fix common/ includes.
 893         * dwarf2read.c: Fix common/ includes.
 894         * dwarf2loc.c: Fix common/ includes.
 895         * dwarf2-frame.c: Fix common/ includes.
 896         * dwarf-index-cache.c: Fix common/ includes.
 897         * dtrace-probe.c: Fix common/ includes.
 898         * disasm-selftests.c: Fix common/ includes.
 899         * defs.h: Fix common/ includes.
 900         * csky-tdep.c: Fix common/ includes.
 901         * cp-valprint.c: Fix common/ includes.
 902         * cp-support.h: Fix common/ includes.
 903         * cp-support.c: Fix common/ includes.
 904         * corelow.c: Fix common/ includes.
 905         * completer.h: Fix common/ includes.
 906         * completer.c: Fix common/ includes.
 907         * compile/compile.c: Fix common/ includes.
 908         * compile/compile-loc2c.c: Fix common/ includes.
 909         * compile/compile-cplus-types.c: Fix common/ includes.
 910         * compile/compile-cplus-symbols.c: Fix common/ includes.
 911         * command.h: Fix common/ includes.
 912         * cli/cli-dump.c: Fix common/ includes.
 913         * cli/cli-cmds.c: Fix common/ includes.
 914         * charset.c: Fix common/ includes.
 915         * build-id.c: Fix common/ includes.
 916         * btrace.h: Fix common/ includes.
 917         * btrace.c: Fix common/ includes.
 918         * breakpoint.h: Fix common/ includes.
 919         * breakpoint.c: Fix common/ includes.
 920         * ax.h:
 921         (enum agent_op): Fix common/ includes.
 922         * ax-general.c (struct aop_map): Fix common/ includes.
 923         * ax-gdb.c: Fix common/ includes.
 924         * auxv.c: Fix common/ includes.
 925         * auto-load.c: Fix common/ includes.
 926         * arm-tdep.c: Fix common/ includes.
 927         * arch/riscv.c: Fix common/ includes.
 928         * arch/ppc-linux-common.c: Fix common/ includes.
 929         * arch/i386.c: Fix common/ includes.
 930         * arch/arm.c: Fix common/ includes.
 931         * arch/arm-linux.c: Fix common/ includes.
 932         * arch/arm-get-next-pcs.c: Fix common/ includes.
 933         * arch/amd64.c: Fix common/ includes.
 934         * arch/aarch64.c: Fix common/ includes.
 935         * arch/aarch64-insn.c: Fix common/ includes.
 936         * arch-utils.c: Fix common/ includes.
 937         * amd64-windows-tdep.c: Fix common/ includes.
 938         * amd64-tdep.c: Fix common/ includes.
 939         * amd64-sol2-tdep.c: Fix common/ includes.
 940         * amd64-obsd-tdep.c: Fix common/ includes.
 941         * amd64-nbsd-tdep.c: Fix common/ includes.
 942         * amd64-linux-tdep.c: Fix common/ includes.
 943         * amd64-linux-nat.c: Fix common/ includes.
 944         * amd64-fbsd-tdep.c: Fix common/ includes.
 945         * amd64-fbsd-nat.c: Fix common/ includes.
 946         * amd64-dicos-tdep.c: Fix common/ includes.
 947         * amd64-darwin-tdep.c: Fix common/ includes.
 948         * agent.c: Fix common/ includes.
 949         * ada-lang.h: Fix common/ includes.
 950         * ada-lang.c: Fix common/ includes.
 951         * aarch64-tdep.c: Fix common/ includes.
 952
 953 2019-01-25  Tom Tromey  <tom@tromey.com>
 954
 955         * common/create-version.sh: Use common/version.h.
 956
 957 2019-01-24  Pedro Alves  <palves@redhat.com>
 958
 959         * infrun.c (signal_stop, signal_print, signal_program)
 960         (signal_catch, signal_pass): Now arrays instead of pointers.
 961         (update_signals_program_target, do_target_resume)
 962         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 963         * linux-nat.c (linux_nat_target::pass_signals)
 964         (linux_nat_target::create_inferior, linux_nat_target::attach):
 965         Adjust.
 966         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 967         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 968         * procfs.c (procfs_target::pass_signals): Adjust.
 969         * record-full.c (record_full_target::resume): Adjust.
 970         * remote.c (remote_target::pass_signals)
 971         (remote_target::program_signals): Adjust.
 972         * target-debug.h (target_debug_print_signals): Now takes a
 973         gdb::array_view as parameter.  Adjust.
 974         * target.h (target_ops) <pass_signals, program_signals>: Replace
 975         pointer and length parameters with gdb::array_view.
 976         (target_pass_signals, target_program_signals): Likewise.
 977         * target-delegates.c: Regenerate.
 978
 979 2019-01-24  Pedro Alves  <palves@redhat.com>
 980
 981         * common/forward-scope-exit.h
 982         (forward_scope_exit::forward_scope_exit): Pass arguments to
 983         m_bind_function directly, instead of creating a std::bind and
 984         copying that.
 985
 986 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 987
 988         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 989         for static members.
 990         (pass_in_v_vfp_candidate): Likewise.
 991
 992 2019-01-23  Tom Tromey  <tom@tromey.com>
 993             Pedro Alves  <palves@redhat.com>
 994
 995         * regcache.c (class regcache_invalidator): Remove.
 996         (regcache::raw_write): Use make_scope_exit.
 997
 998 2019-01-23  Tom Tromey  <tom@tromey.com>
 999
1000         * ui-out.h (class ui_out_emit_type): Update comment.
1001
1002 2019-01-23  Tom Tromey  <tom@tromey.com>
1003
1004         * infrun.c (fetch_inferior_event): Update comment.
1005
1006 2019-01-23  Tom Tromey  <tom@tromey.com>
1007             Pedro Alves  <palves@redhat.com>
1008
1009         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1010         parameter.
1011         (fetch_inferior_event): Use SCOPE_EXIT.
1012
1013
1014 2019-01-23  Tom Tromey  <tom@tromey.com>
1015             Pedro Alves  <palves@redhat.com>
1016
1017         * infrun.c (disable_thread_events): Delete.
1018         (stop_all_threads): Use SCOPE_EXIT.
1019
1020 2019-01-23  Tom Tromey  <tom@tromey.com>
1021             Pedro Alves  <palves@redhat.com>
1022
1023         * symfile.c: Include forward-scope-exit.h.
1024         (clear_symtab_users_cleanup): Replace forward declaration with
1025         a FORWARD_SCOPE_EXIT.
1026         (syms_from_objfile_1): Use the forward_scope_exit and
1027         gdb::optional instead of cleanup_function.
1028         (reread_symbols): Use the forward_scope_exit instead of
1029         cleanup_function.
1030         (clear_symtab_users_cleanup): Remove function.
1031
1032 2019-01-23  Tom Tromey  <tom@tromey.com>
1033             Pedro Alves  <palves@redhat.com>
1034
1035         * linux-nat.c: Include scope-exit.h.
1036         (cleanup_target_stop): Remove.
1037         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1038         SCOPE_EXIT.
1039
1040 2019-01-23  Tom Tromey  <tom@tromey.com>
1041             Pedro Alves  <palves@redhat.com>
1042
1043         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1044         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1045
1046 2019-01-23  Tom Tromey  <tom@tromey.com>
1047             Andrew Burgess  <andrew.burgess@embecosm.com>
1048             Pedro Alves  <palves@redhat.com>
1049
1050         * infrun.c (fetch_inferior_event): Use scope_exit.
1051         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1052         * top.c (execute_command): Use scope_exit.
1053         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1054         * utils.c (do_bpstat_clear_actions_cleanup)
1055         (make_bpstat_clear_actions_cleanup): Remove.
1056
1057 2019-01-23  Tom Tromey  <tom@tromey.com>
1058             Pedro Alves  <palves@redhat.com>
1059
1060         * infrun.c: Include "common/scope-exit.h"
1061         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1062         (wait_for_inferior): Use SCOPE_EXIT.
1063         (fetch_inferior_event): Use scope_exit.
1064
1065 2019-01-23  Tom Tromey  <tom@tromey.com>
1066             Pedro Alves  <palves@redhat.com>
1067
1068         * breakpoint.c (create_breakpoint): Remove cleanup.
1069
1070 2019-01-23  Tom Tromey  <tom@tromey.com>
1071             Andrew Burgess  <andrew.burgess@embecosm.com>
1072             Pedro Alves  <palves@redhat.com>
1073
1074 2019-01-23  Pedro Alves  <palves@redhat.com>
1075
1076         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1077
1078 2019-01-23  Pedro Alves  <palves@redhat.com>
1079             Andrew Burgess  <andrew.burgess@embecosm.com>
1080
1081         * gdbthread.h: Include "common/forward-scope-exit.h".
1082         (scoped_finish_thread_state): Redefine custom class in terms of
1083         forward_scope_exit.
1084
1085 2019-01-23  Pedro Alves  <palves@redhat.com>
1086             Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * common/forward-scope-exit.h: New file.
1089
1090 2019-01-23  Pedro Alves  <palves@redhat.com>
1091             Andrew Burgess  <andrew.burgess@embecosm.com>
1092             Tom Tromey  <tom@tromey.com>
1093
1094         * common/scope-exit.h: New file.
1095
1096 2019-01-23  Pedro Alves  <palves@redhat.com>
1097
1098         * common/preprocessor.h (ESC): Rename to ...
1099         (ESC_PARENS): ... this.
1100         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1101         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1102
1103 2019-01-23  Tom Tromey  <tom@tromey.com>
1104
1105         * language.h (class scoped_switch_to_sym_language_if_auto):
1106         Initialize m_lang in both cases.
1107
1108 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1109
1110         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1111         with XCNEW.
1112
1113 2019-01-22  Tom Tromey  <tom@tromey.com>
1114
1115         * corelow.c: Do not include sys/file.h.
1116
1117 2019-01-22  Tom Tromey  <tom@tromey.com>
1118
1119         * tui/tui-wingeneral.h: Include gdb_curses.h.
1120
1121 2019-01-22  Tom Tromey  <tom@tromey.com>
1122
1123         * source-cache.h (class source_cache) <get_source_lines,
1124         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1125
1126 2019-01-22  Tom Tromey  <tom@tromey.com>
1127
1128         * remote-fileio.h (struct remote_target): Declare.
1129
1130 2019-01-22  Tom Tromey  <tom@tromey.com>
1131
1132         * python/py-arch.c: Do not include py-ref.h.
1133         * python/py-bpevent.c: Do not include py-ref.h.
1134         * python/py-cmd.c: Do not include py-ref.h.
1135         * python/py-continueevent.c: Do not include py-ref.h.
1136         * python/py-event.h: Do not include py-ref.h.
1137         * python/py-evtregistry.c: Do not include py-ref.h.
1138         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1139         * python/py-frame.c: Do not include py-ref.h.
1140         * python/py-framefilter.c: Do not include py-ref.h.
1141         * python/py-function.c: Do not include py-ref.h.
1142         * python/py-infevents.c: Do not include py-ref.h.
1143         * python/py-linetable.c: Do not include py-ref.h.
1144         * python/py-objfile.c: Do not include py-ref.h.
1145         * python/py-param.c: Do not include py-ref.h.
1146         * python/py-prettyprint.c: Do not include py-ref.h.
1147         * python/py-progspace.c: Do not include py-ref.h.
1148         * python/py-symbol.c: Do not include py-ref.h.
1149         * python/py-symtab.c: Do not include py-ref.h.
1150         * python/py-type.c: Do not include py-ref.h.
1151         * python/py-unwind.c: Do not include py-ref.h.
1152         * python/py-utils.c: Do not include py-ref.h.
1153         * python/py-value.c: Do not include py-ref.h.
1154         * python/py-varobj.c: Do not include py-ref.h.
1155         * python/py-xmethods.c: Do not include py-ref.h.
1156         * python/python.c: Do not include py-ref.h.
1157         * varobj.c: Do not include py-ref.h.
1158
1159 2019-01-22  Tom Tromey  <tom@tromey.com>
1160
1161         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1162         keyword for bcache.
1163
1164 2019-01-22  Tom Tromey  <tom@tromey.com>
1165
1166         * compile/compile-cplus-types.c: Remove a comment by #include.
1167
1168 2019-01-22  Tom Tromey  <tom@tromey.com>
1169
1170         * compile/gcc-c-plugin.h: Include compile-internal.h.
1171
1172 2019-01-22  Tom Tromey  <tom@tromey.com>
1173
1174         * stabsread.c (EXTERN): Do not define.
1175         (symnum, next_symbol_text_func, processing_gcc_compilation)
1176         (within_function, global_sym_chain, global_stabs)
1177         (previous_stab_code, this_object_header_files)
1178         (n_this_object_header_files)
1179         (n_allocated_this_object_header_files): Define.
1180         * stabsread.h (EXTERN): Never define.  Use "extern".
1181
1182 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1183
1184         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1185         history_value.
1186
1187 2019-01-21  Tom Tromey  <tom@tromey.com>
1188
1189         * ui-out.c: Fix includes.
1190         * tui/tui-source.c: Fix includes.
1191         * target.c: Fix includes.
1192         * remote.c: Fix includes.
1193         * regcache.c: Fix includes.
1194         * python/py-block.c: Fix includes.
1195         * printcmd.c: Fix includes.
1196         * or1k-tdep.c: Fix includes.
1197         * mi/mi-main.c: Fix includes.
1198         * m32r-tdep.c: Fix includes.
1199         * csky-tdep.c: Fix includes.
1200         * compile/compile-cplus-types.c: Fix includes.
1201         * cli/cli-interp.c: Fix includes.
1202
1203 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1204
1205         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1206         for padding.
1207
1208 2019-01-16  Tom Tromey  <tom@tromey.com>
1209
1210         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1211         earlier.
1212         (struct objfile) <msymbols_range>: Move from top level.
1213         <msymbols>: New method.
1214         (class objfile_msymbols): Remove.
1215         * symtab.c (default_collect_symbol_completion_matches_break_on):
1216         Update.
1217         * symmisc.c (dump_msymbols): Update.
1218         * stabsread.c (scan_file_globals): Update.
1219         * objc-lang.c (info_selectors_command, info_classes_command)
1220         (find_methods): Update.
1221         * minsyms.c (find_solib_trampoline_target): Update.
1222         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1223         * coffread.c (coff_symfile_read): Update.
1224         * ada-lang.c (ada_lookup_simple_minsym)
1225         (ada_collect_symbol_completion_matches): Update.
1226
1227 2019-01-16  Tom Tromey  <tom@tromey.com>
1228
1229         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1230         type.  Remove no-argument constructor.
1231         <iterator::operator++>: Simplify.
1232         <begin>: Update.
1233         <end>: Use minimal_symbol_count.
1234
1235 2019-01-16  Tom Tromey  <tom@tromey.com>
1236
1237         * objfiles.h (struct objfile) <psymtabs>: New method.
1238         (class objfile_psymtabs): Remove.
1239         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1240         typedef.
1241         <range>: New method.
1242         (require_partial_symbols): Change return type.
1243         * psymtab.c (require_partial_symbols)
1244         (psym_expand_symtabs_matching): Update.
1245         * mdebugread.c (parse_partial_symbols): Update.
1246         * dbxread.c (dbx_end_psymtab): Update.
1247
1248 2019-01-15  Tom Tromey  <tom@tromey.com>
1249
1250         * symtab.c (lookup_objfile_from_block)
1251         (lookup_symbol_in_objfile_symtabs)
1252         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1253         (find_line_symtab, info_sources_command)
1254         (default_collect_symbol_completion_matches_break_on)
1255         (make_source_files_completion_list): Update.
1256         * symmisc.c (print_objfile_statistics, dump_objfile)
1257         (maintenance_print_symbols, maintenance_info_symtabs)
1258         (maintenance_check_symtabs, maintenance_info_line_tables):
1259         Update.
1260         * source.c (select_source_symtab)
1261         (forget_cached_source_info_for_objfile): Update.
1262         * objfiles.h (class objfile_compunits): Remove.
1263         (struct objfile) <compunits_range>: New typedef.
1264         (compunits): New method.
1265         * objfiles.c (objfile_relocate1): Update.
1266         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1267         * maint.c (count_symtabs_and_blocks): Update.
1268         * linespec.c (iterate_over_all_matching_symtabs): Update.
1269         * cp-support.c (add_symbol_overload_list_qualified): Update.
1270         * coffread.c (coff_symtab_read): Update.
1271         * ada-lang.c (add_nonlocal_symbols)
1272         (ada_collect_symbol_completion_matches)
1273         (ada_add_global_exceptions): Update.
1274
1275 2019-01-15  Tom Tromey  <tom@tromey.com>
1276
1277         * progspace.h (program_space) <objfiles_safe_range>: New
1278         typedef.
1279         <objfiles_safe>: New method.
1280         * objfiles.h (class all_objfiles_safe): Remove.
1281         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1282         * jit.c (jit_inferior_exit_hook): Update.
1283
1284 2019-01-17  Tom Tromey  <tom@tromey.com>
1285
1286         * progspace.h (program_space) <objfiles_range>: New typedef.
1287         <objfiles>: New method.
1288         <objfiles_head>: Rename from objfiles.
1289         (object_files): Update.
1290         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1291         * guile/scm-pretty-print.c
1292         (ppscm_find_pretty_printer_from_objfiles): Update.
1293         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1294         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1295         Update.
1296         * python/py-progspace.c (pspy_get_objfiles): Update.
1297         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1298         Update.
1299         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1300         (objfpy_lookup_objfile_by_build_id): Update.
1301         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1302         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1303         Update.
1304         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1305         (expand_symtab_containing_pc, lookup_objfile_from_block)
1306         (lookup_static_symbol, basic_lookup_transparent_type)
1307         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1308         (find_line_symtab, info_sources_command)
1309         (default_collect_symbol_completion_matches_break_on)
1310         (make_source_files_completion_list, find_main_name): Update.
1311         * symmisc.c (print_symbol_bcache_statistics)
1312         (print_objfile_statistics, maintenance_print_symbols)
1313         (maintenance_print_msymbols, maintenance_print_objfiles)
1314         (maintenance_info_symtabs, maintenance_check_symtabs)
1315         (maintenance_expand_symtabs, maintenance_info_line_tables):
1316         Update.
1317         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1318         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1319         (map_overlay_command, unmap_overlay_command)
1320         (simple_overlay_update, expand_symtabs_matching)
1321         (map_symbol_filenames): Update.
1322         * symfile-debug.c (set_debug_symfile): Update.
1323         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1324         Update.
1325         * source.c (select_source_symtab, forget_cached_source_info):
1326         Update.
1327         * solib.c (solib_read_symbols): Update.
1328         * solib-spu.c (append_ocl_sos): Update.
1329         * psymtab.c (maintenance_print_psymbols)
1330         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1331         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1332         * printcmd.c (info_symbol_command): Update.
1333         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1334         Update.
1335         * objfiles.h (class all_objfiles): Remove.
1336         * objfiles.c (have_partial_symbols, have_full_symbols)
1337         (have_minimal_symbols, qsort_cmp, update_section_map)
1338         (shared_objfile_contains_address_p)
1339         (default_iterate_over_objfiles_in_search_order): Update.
1340         * objc-lang.c (info_selectors_command, info_classes_command)
1341         (find_methods): Update.
1342         * minsyms.c (find_solib_trampoline_target): Update.
1343         * maint.c (maintenance_info_sections)
1344         (maintenance_translate_address, count_symtabs_and_blocks):
1345         Update.
1346         * main.c (captured_main_1): Update.
1347         * linux-thread-db.c (try_thread_db_load_from_pdir)
1348         (has_libpthread): Update.
1349         * linespec.c (iterate_over_all_matching_symtabs)
1350         (search_minsyms_for_name): Update.
1351         * jit.c (jit_find_objf_with_entry_addr): Update.
1352         * hppa-tdep.c (find_unwind_entry)
1353         (hppa_lookup_stub_minimal_symbol): Update.
1354         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1355         Update.
1356         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1357         (elf_gnu_ifunc_resolve_by_got): Update.
1358         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1359         * dwarf-index-write.c (save_gdb_index_command): Update.
1360         * cp-support.c (add_symbol_overload_list_qualified): Update.
1361         * breakpoint.c (create_overlay_event_breakpoint)
1362         (create_longjmp_master_breakpoint)
1363         (create_std_terminate_master_breakpoint)
1364         (create_exception_master_breakpoint): Update.
1365         * blockframe.c (find_pc_partial_function): Update.
1366         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1367         (ada_collect_symbol_completion_matches)
1368         (ada_add_global_exceptions): Update.
1369
1370 2019-01-17  Tom Tromey  <tom@tromey.com>
1371
1372         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1373         declare VEC.
1374         (solib_target_parse_libraries): Change return type.
1375         (library_list_start_segment, library_list_start_section)
1376         (library_list_end_library, library_list_start_library); Update.
1377         (solib_target_free_library_list): Remove.
1378         (solib_target_parse_libraries): Remove cleanup.  Change return
1379         type.
1380         (solib_target_current_sos): Update.
1381
1382 2019-01-17  Tom Tromey  <tromey@bapiya>
1383
1384         * valprint.c: Replace "the the" with "the".
1385         * symtab.c: Replace "the the" with "the".
1386         * solib.c: Replace "the the" with "the".
1387         * solib-dsbt.c: Replace "the the" with "the".
1388         * linespec.c: Replace "the the" with "the".
1389         * dwarf2loc.h: Replace "the the" with "the".
1390         * amd64-windows-tdep.c: Replace "the the" with "the".
1391         * aarch64-tdep.c: Replace "the the" with "the".
1392
1393 2019-01-16  Keith Seitz  <keiths@redhat.com>
1394
1395         PR gdb/23773
1396         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1397         <builder>: Rename to ..
1398         <m_builder>: ... this and make private.
1399         (dwarf2_cu::get_builder): New method.  Change all users of
1400         `builder' to use this method.
1401         (dwarf2_start_symtab): Move to ...
1402         (dwarf2_cu::start_symtab): ... here.  Update all callers
1403         (setup_type_unit_groups): Move to ...
1404         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1405         callers.
1406         (dwarf2_cu::reset_builder): New method.
1407         (process_full_compunit, process_full_type_unit): Use
1408         dwarf2_cu::reset_builder.
1409         (follow_die_offset): Record the ancestor CU if it is different
1410         from the followed DIE's CU.
1411         (follow_die_sig_1): Likewise.
1412
1413 2019-01-15  Tom Tromey  <tom@tromey.com>
1414
1415         * remote.c (class remote_state) <buf>: Now a char_vector.
1416         <buf_size>: Remove.
1417         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1418         parameter.
1419         (remote_target::getpkt_or_notif_sane_1)
1420         (remote_target::getpkt_sane)
1421         (remote_target::getpkt_or_notif_sane): Likewise.
1422         (class remote_target) <putpkt>: New overload.
1423         (remote_target::read_frame): Change type of "buf_p".  Remove
1424         sizeof_p parameter.
1425         (packet_ok): New overload.
1426         (packet_check_result): New overload.
1427         Update all uses.
1428
1429 2019-01-14  Tom Tromey  <tom@tromey.com>
1430
1431         * remote-notif.c (handle_notification, remote_notif_ack)
1432         (remote_notif_parse): Make "buf" const.
1433         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1434         const.
1435         (remote_notif_parse, remote_notif_ack, handle_notification):
1436         Likewise.
1437         * remote.c (remote_notif_stop_parse): Make "buf" const.
1438         (remote_target::remote_parse_stop_reply): Make "buf" const.
1439         (remote_notif_stop_ack): Make "buf" const.
1440
1441 2019-01-14  Tom Tromey  <tom@tromey.com>
1442
1443         * remote.c (remote_console_output): Make parameter const.
1444
1445 2019-01-14  Tom Tromey  <tom@tromey.com>
1446
1447         * target-debug.h (target_debug_print_signals): Constify.
1448         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1449         * procfs.c (procfs_target::pass_signals): Update.
1450         * linux-nat.c (linux_nat_target::pass_signals): Update.
1451         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1452         * target-delegates.c: Rebuild.
1453         * remote.c (remote_target::program_signals): Update.
1454         (remote_target::pass_signals): Update.
1455         * target.c (target_pass_signals): Constify argument.
1456         (target_program_signals): Likewise.
1457         * target.h (struct target_ops) <pass_signals, program_signals>:
1458         Constify argument.
1459         (target_pass_signals, target_program_signals): Constify argument.
1460
1461 2019-01-14  Tom Tromey  <tom@tromey.com>
1462
1463         PR tui/28819:
1464         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1465
1466 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1467
1468         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1469         field.
1470         * rs6000-tdep.c: Include reggroups.h.
1471         (IS_V_ALIAS_PSEUDOREG): Define.
1472         (rs6000_register_name): Return names for the "vX" aliases.
1473         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1474         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1475         aliases.  Call default_register_reggroup_p for all other
1476         pseudo-registers.
1477         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1478         New functions.
1479         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1480         Handle "vX" aliases.
1481         (v_alias_pseudo_register_collect): New function.
1482         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1483         (rs6000_gdbarch_init): Initialize "vX" aliases as
1484         pseudo-registers.  Restore registration of
1485         rs6000_pseudo_register_reggroup_p with
1486         set_tdesc_pseudo_register_reggroup_p.
1487
1488 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1489
1490         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1491         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1492         set_gdbarch_num_pseudo_regs.
1493
1494 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1495
1496         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1497         Remove arg prefixname, add do_set and do_show.
1498         Add member functions set_list and show_list.
1499         * cli/cli-style.c (class cli_style_option): Update accordingly.
1500         (style_set_list): Move to file scope.
1501         (style_show_list): Likewise.
1502         (set_style): Call help_list.
1503         (show_style): Call cmd_show_list.
1504         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1505         Update to use the new macro.
1506
1507 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1508
1509         * ada-lang.c (_initialize_ada_language): Expand the help text
1510         for the "catch exception" command.
1511
1512 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1513
1514         * symtab.c (matching_obj_sections): Initialize obj,
1515         declare it closer to its usage.
1516
1517 2019-01-10  Tom Tromey  <tom@tromey.com>
1518
1519         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1520         (basic_inf_threads_range): Remove.
1521         (inf_threads_range, inf_non_exited_threads_range)
1522         (safe_inf_threads_range): Use next_adapter.
1523
1524 2019-01-10  Keith Seitz  <keiths@redhat.com>
1525
1526         PR gdb/23712
1527         PR symtab/23010
1528         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1529         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1530
1531 2019-01-10  Keith Seitz  <keiths@redhat.com>
1532
1533         PR gdb/23712
1534         PR symtab/23010
1535         * dictionary.c (pending_to_vector): Remove.
1536         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1537         Remove _1 suffix, replacing functions of the same name.  Update
1538         all callers.
1539         (dict_create_hashed, dict_create_hashed_expandable)
1540         (dict_create_linear, dict_create_linear_expandable, dict_free)
1541         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1542         Make functions static.
1543
1544 2019-01-10  Keith Seitz  <keiths@redhat.com>
1545
1546         PR gdb/23712
1547         PR symtab/23010
1548         * dictionary.h (struct dictionary): Replace declaration with
1549         multidictionary.
1550         (dict_create_hashed, dict_create_hashed_expandable)
1551         (dict_create_linear, dict_create_linear_expandable)
1552         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1553         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1554         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1555         taking multidictionary argument.
1556         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1557         * block.h (struct block) <dict>: Change to multidictionary
1558         and rename `multidict'.
1559         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1560         symmisc.c: Update all dictionary references to multidictionary.
1561
1562 2019-01-10  Keith Seitz  <keiths@redhat.com>
1563
1564         PR gdb/23712
1565         PR symtab/23010
1566         * dictionary.c: Include unordered_map.
1567         (pending_to_vector): New function.
1568         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1569         Rewrite the non-"_1" functions to take vector instead
1570         of linked list.
1571         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1572         "new" _1 versions of the same name.
1573         (multidictionary): Define.
1574         (std::hash<enum language): New definition.
1575         (collate_pending_symbols_by_language, mdict_create_hashed)
1576         (mdict_create_hashed_expandable, mdict_create_linear)
1577         (mdict_create_linear_expandable, mdict_free)
1578         (find_language_dictionary, create_new_language_dictionary)
1579         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1580         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1581         (mdict_size, mdict_empty): New functions.
1582         * dictionary.h (mdict_iterator): Define.
1583
1584 2019-01-10  Pedro Alves  <palves@redhat.com>
1585
1586         * breakpoint.c (read_uploaded_action)
1587         (create_tracepoint_from_upload): Adjust to use
1588         gdb::unique_xmalloc_ptr.
1589         * ctf.c (ctf_write_uploaded_tp):
1590         (SET_ARRAY_FIELD): Use emplace_back.
1591         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1592         * tracefile-tfile.c (tfile_write_uploaded_tp):
1593         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1594         gdb::unique_xmalloc_ptr.
1595         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1596         at_string, cond_string, cmd_strings>: Replace char pointers
1597         with gdb::unique_xmalloc_ptr.
1598
1599 2019-01-10  Pedro Alves  <palves@redhat.com>
1600
1601         * solib-target.c (library_list_start_library): Don't xstrdup name.
1602
1603 2019-01-10  Pedro Alves  <palves@redhat.com>
1604
1605         * mdebugread.c (parse_partial_symbols): Use
1606         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1607
1608 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1609
1610         * linux-fork.c (scoped_switch_fork_info)
1611         <~scoped_switch_fork_info>: Fix incorrect variable name.
1612
1613 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1614
1615         * linux-fork.c (scoped_switch_fork_info)
1616         <scoped_switch_fork_info>: Make explicit.
1617         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1618
1619 2019-01-10  Tom Tromey  <tom@tromey.com>
1620
1621         * objfiles.h (objfile::reset_psymtabs): Update.
1622         * objfiles.c (objfile::objfile): Update.
1623         * psymtab.h (psymtab_storage::obstack): Update.
1624         (psymtab_storage::m_obstack): Use gdb::optional.
1625         (class psymtab_storage): Update comment.  Remove objfile
1626         parameter.
1627         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1628
1629 2019-01-10  Tom Tromey  <tom@tromey.com>
1630
1631         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1632         <free_psymtabs>: Now private.
1633         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1634         (allocate_psymtab): Use new method.
1635
1636 2019-01-10  Tom Tromey  <tom@tromey.com>
1637
1638         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1639         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1640         * mdebugread.c (parse_partial_symbols): Use
1641         allocate_dependencies.
1642         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1643         allocate_dependencies.
1644         (process_psymtab_comp_unit_reader)
1645         (build_type_psymtab_dependencies): Likewise.
1646         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1647
1648 2019-01-10  Tom Tromey  <tom@tromey.com>
1649
1650         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1651         PSYMBOL_SET_LANGUAGE.
1652         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1653
1654 2019-01-10  Tom Tromey  <tom@tromey.com>
1655
1656         * psymtab.h (psymtab_storage::obstack): New method.
1657         <m_obstack>: Rename from obstack; now private.
1658         * psymtab.c (psymtab_storage): Update.
1659         * dwarf2read.c (create_addrmap_from_index)
1660         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1661         Update.
1662
1663 2019-01-10  Tom Tromey  <tom@tromey.com>
1664
1665         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1666         * objfiles.h (objfile::reset_psymtabs): New method.
1667
1668 2019-01-10  Tom Tromey  <tom@tromey.com>
1669
1670         * symmisc.c (print_symbol_bcache_statistics): Update.
1671         (print_objfile_statistics): Update.
1672         * symfile.c (reread_symbols): Update.
1673         * psymtab.h (class psymtab_storage): New.
1674         * psymtab.c (psymtab_storage): New constructor.
1675         (~psymtab_storage): New destructor.
1676         (require_partial_symbols): Update.
1677         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1678         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1679         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1680         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1681         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1682         (start_psymtab_common, end_psymtab_common)
1683         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1684         (allocate_psymtab): Update.
1685         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1686         Update.
1687         (dump_psymtab_addrmap, maintenance_print_psymbols)
1688         (maintenance_check_psymtabs): Update.
1689         (class objfile_psymtabs): Move to objfiles.h.
1690         * psympriv.h (discard_psymtab): Now inline.
1691         (psymtab_discarder::psymtab_discarder): Update.
1692         (psymtab_discarder::~psymtab_discarder): Update.
1693         (ALL_OBJFILE_PSYMTABS): Rewrite.
1694         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1695         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1696         Remove fields.
1697         <partial_symtabs>: New field.
1698         (class objfile_psymtabs): Move from psymtab.h.  Update.
1699         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1700         psymbol_cache.
1701         (objfile::~objfile): Don't destroy psymbol_cache.
1702         * mdebugread.c (parse_partial_symbols): Update.
1703         * dwarf2read.c (create_addrmap_from_index)
1704         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1705         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1706         (add_partial_subprogram, dwarf2_ranges_read): Update.
1707         * dwarf-index-write.c (write_address_map)
1708         (write_one_signatured_type, recursively_write_psymbols)
1709         (class debug_names, class debug_names, write_psymtabs_to_index):
1710         Update.
1711
1712 2019-01-10  Tom Tromey  <tom@tromey.com>
1713
1714         * symtab.h (SYMBOL_SET_NAMES): Update.
1715         (symbol_set_names): Update.
1716         (MSYMBOL_SET_NAMES): Update.
1717         * symtab.c (symbol_set_names): Change argument to be an
1718         objfile_per_bfd_storage.
1719         * psymtab.c (add_psymbol_to_bcache): Update.
1720         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1721
1722 2019-01-10  Tom Tromey  <tom@tromey.com>
1723
1724         * symtab.c (create_demangled_names_hash): Change argument to be an
1725         objfile_per_bfd_storage.
1726         (symbol_set_names): Update.
1727
1728 2019-01-10  Tom Tromey  <tom@tromey.com>
1729
1730         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1731         init_psymbol_list.
1732         * psymtab.c (init_psymbol_list): Do nothing if already called.
1733         * psympriv.h (init_psymbol_list): Add comment.
1734         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1735         init_psymbol_list.
1736         * dbxread.c (dbx_symfile_read): Unconditionally call
1737         init_psymbol_list.
1738
1739 2019-01-10  Tom Tromey  <tom@tromey.com>
1740
1741         * xcoffread.c (scan_xcoff_symtab): Update.
1742         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1743         "where".
1744         * mdebugread.c (parse_partial_symbols)
1745         (handle_psymbol_enumerators): Update.
1746         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1747         * dbxread.c (read_dbx_symtab): Update.
1748         * psympriv.h (psymbol_placement): New enum.
1749         (add_psymbol_to_list): Update.
1750
1751 2019-01-10  Tom Tromey  <tom@tromey.com>
1752
1753         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1754         static_psymbols parameters.
1755         (scan_xcoff_symtab): Update.
1756         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1757         static_psymbols parameters.
1758         * psympriv.h (start_psymtab_common): Update.
1759         * mdebugread.c (parse_partial_symbols): Update.
1760         * dwarf2read.c (create_partial_symtab): Update.
1761         * dbxread.c (read_dbx_symtab): Update.
1762         (start_psymtab): Remove global_psymbols and static_psymbols
1763         parameters.
1764
1765 2019-01-10  Tom Tromey  <tom@tromey.com>
1766
1767         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1768         * psymtab.c (allocate_psymtab): Add comment.
1769         * psympriv.h (allocate_psymtab): Add comment.
1770         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1771         initializations.
1772         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1773
1774 2019-01-10  Tom Tromey  <tom@tromey.com>
1775
1776         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1777         Don't declare.
1778         * mipsread.c: Include mdebugread.h.
1779         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1780         Declare.
1781         * elfread.c: Include mdebugread.h.
1782
1783 2019-01-09  Tom Tromey  <tom@tromey.com>
1784
1785         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1786         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1787         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1788         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1789         (psym_lookup_symbol, psym_find_last_source_symtab)
1790         (psym_forget_cached_source_info, psym_print_stats)
1791         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1792         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1793         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1794         (psym_find_compunit_symtab_by_address)
1795         (maintenance_print_psymbols, maintenance_info_psymtabs)
1796         (maintenance_check_psymtabs): Use ranged for.
1797         * psymtab.h (class objfile_psymtabs): New.
1798         (require_partial_symbols): Return objfile_psymtabs.
1799         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1800
1801 2019-01-09  Tom Tromey  <tom@tromey.com>
1802
1803         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1804         (find_pc_mapped_section, list_overlays_command)
1805         (map_overlay_command, unmap_overlay_command)
1806         (simple_overlay_update): Use all_objfiles.
1807         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1808         * printcmd.c (info_symbol_command): Use all_objfiles.
1809         * objfiles.h (ALL_OBJSECTIONS): Remove.
1810         * maint.c (maintenance_translate_address): Use all_objfiles.
1811         * gcore.c (gcore_create_callback): Use all_objfiles.
1812         (objfile_find_memory_regions): Likewise.
1813
1814 2019-01-09  Tom Tromey  <tom@tromey.com>
1815
1816         * symtab.c (find_line_symtab, info_sources_command)
1817         (make_source_files_completion_list): Use objfile_compunits.
1818         * source.c (select_source_symtab): Use objfile_compunits.
1819         * objfiles.h (struct objfile): Update comment.
1820         (ALL_OBJFILES): Remove.
1821         (ALL_FILETABS): Remove.
1822         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1823         objfile_compunits.
1824
1825 2019-01-09  Tom Tromey  <tom@tromey.com>
1826
1827         * symmisc.c (print_objfile_statistics, dump_objfile)
1828         (maintenance_print_symbols): Use compunit_filetabs.
1829         * source.c (forget_cached_source_info_for_objfile): Use
1830         compunit_filetabs.
1831         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1832         (ALL_FILETABS): Use compunit_filetabs.
1833         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1834         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1835
1836 2019-01-09  Tom Tromey  <tom@tromey.com>
1837
1838         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1839         (compunit_filetabs): New.
1840         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1841         compunit_filetabs.
1842         (info_sources_command, make_source_files_completion_list): Remove
1843         declaration.
1844         * symmisc.c (print_objfile_statistics, dump_objfile)
1845         (maintenance_print_symbols): Remove declaration.
1846         (maintenance_info_symtabs): Use compunit_filetabs.
1847         (maintenance_info_line_tables): Likewise.
1848         * source.c (select_source_symtab): Change local variable name.
1849         (forget_cached_source_info_for_objfile): Remove declaration.
1850         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1851         * objfiles.c (objfile_relocate1): Remove declaration.
1852         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1853         declaration.
1854         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1855         * coffread.c (coff_symtab_read): Remove declaration.
1856         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1857         compunit_filetabs.
1858
1859 2019-01-09  Tom Tromey  <tom@tromey.com>
1860
1861         * symtab.c (lookup_objfile_from_block)
1862         (find_pc_sect_compunit_symtab, search_symbols)
1863         (default_collect_symbol_completion_matches_break_on): Use
1864         objfile_compunits.
1865         * objfiles.h (ALL_COMPUNITS): Remove.
1866         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1867         * cp-support.c (add_symbol_overload_list_qualified): Use
1868         objfile_compunits.
1869         * ada-lang.c (ada_collect_symbol_completion_matches)
1870         (ada_add_global_exceptions): Use objfile_compunits.
1871
1872 2019-01-09  Tom Tromey  <tom@tromey.com>
1873
1874         * source.c (select_source_symtab)
1875         (forget_cached_source_info_for_objfile): Remove declaration.
1876         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1877         declaration.
1878         * maint.c (count_symtabs_and_blocks): Remove declaration.
1879         * cp-support.c (add_symbol_overload_list_qualified): Remove
1880         declaration.
1881         * coffread.c (coff_symtab_read): Remove declaration.
1882         * symtab.c (lookup_symbol_in_objfile_symtabs)
1883         (basic_lookup_transparent_type_1): Use objfile_compunits.
1884         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1885         (info_sources_command, search_symbols)
1886         (default_collect_symbol_completion_matches_break_on)
1887         (make_source_files_completion_list): Remove declaration.
1888         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1889         (ada_collect_symbol_completion_matches)
1890         (ada_add_global_exceptions): Remove declaration.
1891         * linespec.c (iterate_over_all_matching_symtabs): Use
1892         objfile_compunits.
1893         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1894         (class objfile_compunits): New.
1895         (ALL_COMPUNITS): Use objfile_compunits.
1896         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1897         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1898         objfile_compunits.
1899         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1900
1901 2019-01-09  Tom Tromey  <tom@tromey.com>
1902
1903         * symtab.c (search_symbols)
1904         (default_collect_symbol_completion_matches_break_on): Use
1905         objfile_msymbols.
1906         * ada-lang.c (ada_lookup_simple_minsym)
1907         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1908         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1909         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1910         objfile_msymbols.
1911         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1912         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1913         * objc-lang.c (find_methods): Use objfile_msymbols.
1914         (info_selectors_command, info_classes_command): Likewise.
1915         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1916         * objfiles.h (class objfile_msymbols): New.
1917         (ALL_OBJFILE_MSYMBOLS): Remove.
1918         (ALL_MSYMBOLS): Remove.
1919
1920 2019-01-09  Tom Tromey  <tom@tromey.com>
1921
1922         * common/next-iterator.h (next_adapter): Add Iterator template
1923         parameter.
1924         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1925         (class all_objfiles_safe): New.
1926         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1927         * objfiles.c (put_objfile_before): Update comment.
1928         (add_separate_debug_objfile): Likewise.
1929         (free_all_objfiles): Use all_objfiles_safe.
1930         (objfile_purge_solibs): Likewise.
1931
1932 2019-01-09  Tom Tromey  <tom@tromey.com>
1933
1934         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1935         (expand_symtab_containing_pc, lookup_static_symbol)
1936         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1937         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1938         all_objfiles.
1939         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1940         * breakpoint.c (create_overlay_event_breakpoint)
1941         (create_longjmp_master_breakpoint)
1942         (create_std_terminate_master_breakpoint)
1943         (create_exception_master_breakpoint): Use all_objfiles.
1944         * linux-thread-db.c (try_thread_db_load_from_pdir)
1945         (has_libpthread): Use all_objfiles.
1946         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1947         * linespec.c (iterate_over_all_matching_symtabs)
1948         (search_minsyms_for_name): Use all_objfiles.
1949         * maint.c (maintenance_info_sections): Use all_objfiles.
1950         * main.c (captured_main_1): Use all_objfiles.
1951         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1952         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1953         * guile/scm-pretty-print.c
1954         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1955         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1956         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1957         (maintenance_print_msymbols): Use all_objfiles.
1958         * source.c (select_source_symtab): Use all_objfiles.
1959         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1960         * symfile.c (remove_symbol_file_command)
1961         (expand_symtabs_matching, map_symbol_filenames): Use
1962         all_objfiles.
1963         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1964         all_objfiles.
1965         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1966         * objc-lang.c (find_methods): Use all_objfiles.
1967         * objfiles.c (have_partial_symbols, have_full_symbols)
1968         (have_minimal_symbols, qsort_cmp)
1969         (default_iterate_over_objfiles_in_search_order): Use
1970         all_objfiles.
1971         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1972         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1973         (maintenance_check_psymtabs): Use all_objfiles.
1974         (ALL_PSYMTABS): Remove.
1975         * compile/compile-object-run.c (do_module_cleanup): Use
1976         all_objfiles.
1977         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1978         * cp-support.c (add_symbol_overload_list_qualified): Use
1979         all_objfiles.
1980         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1981         Use all_objfiles.
1982         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1983         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1984         all_objfiles.
1985         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1986         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1987         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1988         Uses all_objfiles.
1989         * solib.c (solib_read_symbols): Use all_objfiles
1990
1991 2019-01-09  Tom Tromey  <tom@tromey.com>
1992
1993         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1994         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1995         all_objfiles.
1996         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1997         * symmisc.c (print_symbol_bcache_statistics)
1998         (print_objfile_statistics, maintenance_print_objfiles)
1999         (maintenance_info_symtabs, maintenance_check_symtabs)
2000         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2001         all_objfiles.
2002         * source.c (forget_cached_source_info): Use all_objfiles.
2003         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2004         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2005         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2006         * objfiles.c (update_section_map): Use all_objfiles.
2007         (shared_objfile_contains_address_p): Likewise.
2008         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2009         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2010
2011 2019-01-09  Tom Tromey  <tom@tromey.com>
2012
2013         * common/next-iterator.h: New file.
2014         * objfiles.h (class all_objfiles): New.
2015         (struct objfile_iterator): New.
2016
2017 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2018
2019         * NEWS: Move the description of the changed "frame", "select-frame",
2020          and "info frame" commands to the Changed commands section.
2021
2022 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2023
2024         * gdbtypes.c (check_stub_method_group): Remove handling of old
2025         mangling schemes.
2026         * linespec.c (find_methods): Likewise.
2027         * stabsread.c (read_member_functions): Likewise.
2028         * valops.c (search_struct_method): Likewise.
2029         (value_struct_elt_for_reference): Likewise.
2030         * NEWS: Mention this change.
2031
2032 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2033
2034         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2035         print_source_lines.
2036         * source.c (print_source_lines_base): Update line number check.
2037         (print_source_lines): New function.
2038         (source_lines_range::source_lines_range): New function.
2039         * source.h (class source_lines_range): New class.
2040         (print_source_lines): New declaration.
2041
2042 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2043
2044         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2045
2046 2019-01-08  Tom Tromey  <tom@tromey.com>
2047             Simon Marchi  <simon.marchi@ericsson.com>
2048
2049         PR gdb/24060
2050         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2051         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2052         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2053         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2054         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2055         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2056
2057 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2058
2059         * source.c (select_source_symtab): Move header comment to
2060         declaration in source.h.
2061         (forget_cached_source_info_for_objfile): Likewise.
2062         (forget_cached_source_info): Likewise.
2063         (identify_source_line): Likewise.
2064         * source.h (identify_source_line): Move declaration from symtab.h
2065         and add comment from source.c
2066         (print_source_lines): Likewise.
2067         (forget_cached_source_info_for_objfile): Likewise.
2068         (forget_cached_source_info): Likewise.
2069         (select_source_symtab): Likewise.
2070         (enum print_source_lines_flag): Move definition from symtab.h.
2071         * symtab.h (identify_source_line): Move declaration to source.h.
2072         (print_source_lines): Likewise.
2073         (forget_cached_source_info_for_objfile): Likewise.
2074         (forget_cached_source_info): Likewise.
2075         (select_source_symtab): Likewise.
2076         (enum print_source_lines_flag): Move definition to source.h.
2077         * tui/tui-hooks.c: Add 'source.h' include.
2078
2079 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2080
2081         * source.c (print_source_lines_base): Handle requests to print
2082         reverse line number sequences, and guard against empty lines
2083         string.
2084
2085 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2086
2087         * source.c (print_source_lines_base): Fix skip of '\r' if next
2088         character is '\n'.
2089
2090 2019-01-06  Tom Tromey  <tom@tromey.com>
2091
2092         * c-exp.y (struct c_parse_state) <macro_original_text,
2093         expansion_obstack>: New member.
2094         (macro_original_text, expansion_obstack): Remove globals.
2095         (scan_macro_expansion, scanning_macro_expansion)
2096         (finished_macro_expansion): Update.
2097         (scan_macro_cleanup): Remove.
2098         (yylex, c_parse): Update.
2099
2100 2019-01-06  Tom Tromey  <tom@tromey.com>
2101
2102         * c-exp.y (struct c_parse_state) <strings>: New member.
2103         (operator_stoken): Update.
2104
2105 2019-01-06  Tom Tromey  <tom@tromey.com>
2106
2107         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2108         (union type_stack_elt) <typelist_val>: Now a pointer to
2109         std::vector.
2110         (type_stack_cleanup): Don't declare.
2111         (push_typelist): Update.
2112         * parse.c (pop_typelist): Return a std::vector.
2113         (push_typelist): Take a std::vector.
2114         (follow_types): Update.  Do not free args.
2115         (type_stack_cleanup): Remove.
2116         * c-exp.y (struct c_parse_state): New.
2117         (cpstate): New global.
2118         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2119         (nonempty_typelist): Update.
2120         (func_mod): Create a new vector.
2121         (c_parse): Create a c_parse_state.
2122         (check_parameter_typelist): Do not delete params.
2123         (function_method): Update.  Do not delete type_list.
2124
2125 2019-01-06  Tom Tromey  <tom@tromey.com>
2126
2127         PR gdb/28155:
2128         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2129         check_typedef.
2130         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2131         (print_return_value): Likewise.
2132
2133 2019-01-05  Tom Tromey  <tom@tromey.com>
2134
2135         * contrib/cleanup_check.py: Remove.
2136         * contrib/gcc-with-excheck: Remove.
2137         * contrib/exsummary.py: Remove.
2138         * contrib/excheck.py: Remove.
2139
2140 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2141
2142         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2143         NULL. Initialize tpprev to NULL instead of assigning it
2144         to NULL on the next statement.
2145         * windows-nat.c (windows_delete_thread): Remove check for
2146         main_thread_id before printing thread exit notifications.
2147         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2148         Remove thread ID check against main_thread_id.
2149         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2150         windows_delete_thread.
2151         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2152
2153 2019-01-04  Tom Tromey  <tom@tromey.com>
2154
2155         * compile/compile.c (_initialize_compile): Use upper case for
2156         metasyntactic variables.
2157         * symmisc.c (_initialize_symmisc): Use upper case for
2158         metasyntactic variables.
2159         * psymtab.c (_initialize_psymtab): Use upper case for
2160         metasyntactic variables.
2161         * demangle.c (demangle_command): Use upper case for metasyntactic
2162         variables.
2163         (_initialize_demangler): Likewise.
2164         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2165         variables.
2166
2167 2019-01-03  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2170
2171 2019-01-03  Tom Tromey  <tom@tromey.com>
2172
2173         * python/py-symtab.c (salpy_str): Update.
2174         (struct salpy_sal_object) <symtab>: Now a PyObject.
2175         (salpy_dealloc): Update.
2176         (del_objfile_sal): Use gdbpy_ref.
2177
2178 2019-01-03  Tom Tromey  <tom@tromey.com>
2179
2180         * python/py-type.c (convert_field): Use new_reference.  Return
2181         gdbpy_ref.
2182         (make_fielditem): Return gdbpy_ref.
2183         (typy_fields): Update.
2184         (typy_getitem): Update.
2185         (field_name): Return gdbpy_ref.  Use new_reference.
2186         (typy_iterator_iternext): Update.
2187
2188 2019-01-03  Tom Tromey  <tom@tromey.com>
2189
2190         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2191
2192 2019-01-03  Tom Tromey  <tom@tromey.com>
2193
2194         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2195         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2196         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2197         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2198         (pspy_set_type_printers): Likewise.
2199         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2200         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2201         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2202         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2203         (objfpy_set_type_printers): Likewise.
2204
2205 2019-01-03  Tom Tromey  <tom@tromey.com>
2206
2207         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2208         (gdbpy_print_stack): Use gdbpy_err_fetch.
2209         * python/python-internal.h (class gdbpy_err_fetch): New class.
2210         (class gdbpy_enter) <m_error_type, m_error_value,
2211         m_error_traceback>: Remove.
2212         <m_error>: New member.
2213         (gdbpy_exception_to_string): Don't declare.
2214         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2215         * python/py-value.c (convert_value_from_python): Use
2216         gdbpy_err_fetch.
2217         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2218         gdbpy_exception_to_string.
2219         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2220         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2221         gdbpy_err_fetch.
2222
2223 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * linux-nat.c (delete_lwp_cleanup): Delete.
2226         (struct lwp_deleter): New struct.
2227         (lwp_info_up): New typedef.
2228         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2229         lwp_info_up.
2230
2231 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * linux-fork.c (class scoped_switch_fork_info): New class.
2234         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2235
2236 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * valops.c (find_overload_match): Remove use of null_cleanup, and
2239         calls to do_cleanups.
2240
2241 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2242
2243         * compile/compile-cplus-types.c
2244         (compile_cplus_instance::decl_name): Handle changes to
2245         cp_func_name.
2246         * cp-support.c (cp_func_name): Update header comment, update
2247         return type.
2248         * cp-support.h (cp_func_name): Update return type in declaration.
2249         * valops.c (find_overload_match): Move temp_func local to top
2250         level of function and change its type.  Use temp_func to hold and
2251         delete temporary string obtained from cp_func_name.
2252
2253 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2254
2255         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2256         gdb::char_vector, remove cleanup, and update uses of `msg`.
2257
2258 2019-01-03  Jim Wilson  <jimw@sifive.com>
2259
2260         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2261
2262 2019-01-02  Tom Tromey  <tom@tromey.com>
2263
2264         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2265         (tdesc_parse_xml): Remove cleanups.
2266         * target-descriptions.h (make_cleanup_free_target_description):
2267         Don't declare.
2268         (target_desc_deleter): New struct.
2269         (target_desc_up): New typedef.
2270         * target-descriptions.c (target_desc_deleter::operator()): Rename
2271         from free_target_description.
2272         (make_cleanup_free_target_description): Remove.
2273
2274 2019-01-02  Tom Tromey  <tom@tromey.com>
2275
2276         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2277         constructor, destructor.
2278         (linespec_parser): Remove typedef.
2279         (~linespec_parser): Rename from linespec_parser_delete.
2280         (linespec_lex_to_end, linespec_complete_label)
2281         (linespec_complete): Update.
2282         (decode_line_full): Remove cleanups.
2283         (decode_line_1): Update.
2284
2285 2019-01-02  Tom Tromey  <tom@tromey.com>
2286
2287         * python/python-internal.h (inferior_to_inferior_object): Change
2288         return type.
2289         * python/py-exitedevent.c (create_exited_event_object): Update.
2290         * python/py-inferior.c (inferior_to_inferior_object): Return
2291         gdbpy_ref.
2292         (python_new_inferior, python_inferior_deleted)
2293         (thread_to_thread_object, delete_thread_object)
2294         (build_inferior_list, gdbpy_selected_inferior): Update.
2295         * python/py-infthread.c (create_thread_object): Update.  Also fail
2296         if inferior_to_inferior_object fails.
2297
2298 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2299
2300         * inferior.h (class inferior) <displaced_step_state>: New field.
2301         * infrun.h (struct displaced_step_state): Move here from
2302         infrun.c.  Initialize fields, add constructor.
2303         <inf>: Remove field.
2304         <reset>: New method.
2305         * infrun.c (struct displaced_step_inferior_state): Move to
2306         infrun.h.
2307         (displaced_step_inferior_states): Remove.
2308         (get_displaced_stepping_state): Adust.
2309         (displaced_step_in_progress_any_inferior): Adjust.
2310         (displaced_step_in_progress_thread): Adjust.
2311         (displaced_step_in_progress): Adjust.
2312         (add_displaced_stepping_state): Remove.
2313         (get_displaced_step_closure_by_addr): Adjust.
2314         (remove_displaced_stepping_state): Remove.
2315         (infrun_inferior_exit): Call displaced_step_state.reset.
2316         (use_displaced_stepping): Don't check for NULL.
2317         (displaced_step_prepare_throw): Call
2318         get_displaced_stepping_state.
2319         (displaced_step_fixup): Don't check for NULL.
2320         (prepare_for_detach): Don't check for NULL.
2321
2322 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2323
2324         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2325          in case of call that did not complete.
2326
2327 2019-01-02  Andrey Utkin  <autkin@undo.io>
2328
2329         * symfile.c (find_separate_debug_file): Fix search of debug files for
2330         remote debuggee.
2331
2332 2019-01-02  Tom Tromey  <tom@tromey.com>
2333
2334         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2335         indentation.
2336         * python/py-frame.c (frapy_older): Remove cast.
2337         (frapy_newer): Likewise.
2338         * python/py-breakpoint.c (local_setattro): Remove cast.
2339         * python/py-arch.c (archpy_name): Remove local variable.
2340         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2341
2342 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2343
2344         * unittests/basic_string_view/element_access/char/empty.cc:
2345         Fix year range in copyright header.
2346
2347 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2348
2349         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2350         Delete.
2351         <operator==>: Update with for removed field.
2352         <hash>: Likewise.
2353         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2354         <isa_features>: ...this.
2355         <abi_features>: New field.
2356         (riscv_isa_flen): Update comment.
2357         (riscv_abi_xlen): New declaration.
2358         (riscv_abi_flen): New declaration.
2359         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2360         isa_features.
2361         (riscv_abi_xlen): New function.
2362         (riscv_isa_flen): Update to get answer from isa_features.
2363         (riscv_abi_flen): New function.
2364         (riscv_has_fp_abi): Update to get answer from abi_features.
2365         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2366         xlen and flen.
2367         (riscv_call_info) <xlen, flen>: Update comment.
2368         (riscv_call_arg_struct): Remove invalid assertions
2369         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2370         is removed.
2371         (riscv_gdbarch_init): Gather isa features and abi features
2372         separately, ensure both match on the gdbarch when reusing an old
2373         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2374         a target with 64-bit float hardware.
2375
2376 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2377
2378         * source.c (search_command_helper): Stop reverse search
2379         when line 1 has been searched.
2380
2381 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2382
2383         * record-full.c (record_full_base_target::close): Rewrite
2384         record_full_core_buf_list free logic.
2385
2386 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2387
2388         * break-catch-syscall.c (print_one_catch_syscall): xfree
2389         the last text.
2390
2391 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2392
2393         * top.c (print_gdb_version): Update Copyright year in version
2394         message.
2395
2396 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2397
2398         Update copyright year range in all GDB files.
2399
2400 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2401
2402         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2403
2404 For older changes see ChangeLog-2018.
2405 \f
2406 Local Variables:
2407 mode: change-log
2408 left-margin: 8
2409 fill-column: 74
2410 version-control: never
2411 coding: utf-8
2412 End:
2413