Implement show | set may-call-functions [on|off]
[external/binutils.git] / gdb / ChangeLog
1 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2
3         * NEWS: Mention the new set|show may-call-functions.
4         * infcall.c (may_call_functions_p): New variable.
5         (show_may_call_functions_p): New function.
6         (call_function_by_hand_dummy): Throws an error if not
7         may-call-functions.
8         (_initialize_infcall): Call add_setshow_boolean_cmd for
9         may-call-functions.
10
11 2019-04-25  Keith Seitz  <keiths@redhat.com>
12
13         PR c++/24367
14         * cp-support.c (inspect_type): Don't attempt substitutions
15         of symbol with the same name.
16
17 2019-04-25  Tom Tromey  <tromey@adacore.com>
18
19         PR gdb/24475:
20         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
21         static.
22
23 2019-04-25  Tom Tromey  <tromey@adacore.com>
24
25         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
26         rvalue reference.
27         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
28         (gdb_xml_parser::parse): Use std::move.
29         * python/python-internal.h (gdbpy_convert_exception): Take a const
30         reference.
31         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
32         std::move.
33         * python/py-utils.c (gdbpy_convert_exception): Take a const
34         reference.
35         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
36         Use std::move.
37         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
38         Use std::move.
39         * mi/mi-main.c (mi_print_exception): Take a const reference.
40         * main.c (handle_command_errors): Take a const reference.
41         * linespec.c (parse_linespec): Use std::move.
42         * infcall.c (run_inferior_call): Use std::move.
43         (call_function_by_hand_dummy): Use std::move.
44         * exec.c (try_open_exec_file): Use std::move.
45         * exceptions.h (exception_print, exception_fprintf)
46         (exception_print_same): Update.
47         * exceptions.c (print_exception, exception_print)
48         (exception_fprintf, exception_print_same): Change parameters to
49         const reference.
50         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
51         * common/new-op.c: Use std::move.
52         * common/common-exceptions.h (struct gdb_exception): Add move
53         constructor.
54         (struct gdb_exception_error, struct gdb_exception_quit, struct
55         gdb_quit_bad_alloc): Change constructor to move constructor.
56         (throw_exception): Change parameter to rvalue reference.
57         * common/common-exceptions.c (throw_exception): Take rvalue
58         reference.
59         * cli/cli-interp.c (safe_execute_command): Use std::move.
60         * breakpoint.c (insert_bp_location, location_to_sals): Use
61         std::move.
62
63 2019-04-25  Tom Tromey  <tromey@adacore.com>
64
65         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
66         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
67         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
68         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
69         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
70         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
71         guile/scm-value.c: Use unpack.
72         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
73         gdbscm_gdb_exception.
74         (gdbscm_throw_gdb_exception): Likewise.
75         (struct gdbscm_gdb_exception): New.
76         (unpack): New function.
77         (gdbscm_wrap): Use unpack.
78
79 2019-04-25  Tom Tromey  <tromey@adacore.com>
80
81         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
82         (gdb_rl_callback_handler): Use std::move.
83         * common/common-exceptions.h (struct gdb_exception): Add move
84         assignment operator.
85         (throw_exception_sjlj): Change "exception" to const reference.
86         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
87         (throw_exception_sjlj): Change "exception" to const reference.
88
89 2019-04-25  Tom Tromey  <tromey@adacore.com>
90
91         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
92         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
93         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
94         Update.
95         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
96         Update.
97         * mi/mi-interp.c (mi_interp::exec): Update.
98         * linespec.c (parse_linespec): Update.
99         * infcall.c (run_inferior_call): Update.
100         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
101         * guile/scm-symbol.c (gdbscm_lookup_symbol)
102         (gdbscm_lookup_global_symbol): Update.
103         * guile/scm-param.c (gdbscm_parameter_value): Update.
104         * guile/scm-frame.c (gdbscm_frame_read_register)
105         (gdbscm_frame_read_var): Update.
106         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
107         * exec.c (try_open_exec_file): Update.
108         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
109         (gdb_rl_callback_handler): Update.
110         * common/common-exceptions.h (exception_none): Don't declare.
111         * common/common-exceptions.c (exception_none): Don't define.
112         (struct catcher) <exception>: Update.
113         * cli/cli-interp.c (safe_execute_command): Update.
114         * breakpoint.c (insert_bp_location, location_to_sals): Update.
115
116 2019-04-25  Ali Tamur  <tamur@google.com>
117
118         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
119         (read_attribute_value): Likewise.
120         (dwarf2_read_addr_index): Update comment.
121         (read_str_index): Add DW_FORM_strx.
122         (dwarf2_string_attr): Likewise.
123         (dwarf2_const_value_attr): Likewise.
124         (dump_die_shallow): Likewise.
125         (dwarf2_fetch_constant_bytes): Likewise.
126         (skip_form_bytes): Likewise.
127         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
128
129 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
130
131         PR corefiles/11608
132         PR corefiles/18187
133         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
134         OFFSET.  Verify if current mapping contains an ELF header.
135         (linux_find_memory_regions_full): Adjust call to
136         dump_mapping_p.
137
138 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
139             Kang Li <kanglictf@gmail.com>
140
141         PR gdb/21600
142
143         * dwarf2-frame.c (read_initial_length): Be consistent about using
144         unsigned representation of length.
145         (decode_frame_entry_1): Likewise.  Check for wraparound of
146         end pointer as well as buffer overflow.
147
148 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
149
150         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
151         "vq".
152
153 2019-04-24  Tom Tromey  <tromey@adacore.com>
154
155         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
156
157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
158
159         * s12z-tdep.c (s12z_unwind_pc): Delete.
160         (s12z_unwind_sp): Delete.
161         (s12z_gdbarch_init): Don't register deleted functions with
162         gdbarch.
163
164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
165
166         * rl78-tdep.c (rl78_unwind_sp): Delete.
167         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
168
169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
170
171         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
172         (xstormy16_unwind_pc): Delete.
173         (xstormy16_dummy_id): Delete.
174         (xstormy16_gdbarch_init): Don't register deleted functions with
175         gdbarch.
176
177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
178
179         * vax-tdep.c (vax_unwind_pc): Delete.
180         (vax_gdbarch_init): Don't register deleted function with gdbarch.
181
182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
183
184         * v850-tdep.c (v850_unwind_sp): Delete.
185         (v850_unwind_pc): Delete.
186         (v850_dummy_id): Delete.
187         (v850_gdbarch_init): Don't register deleted functions with
188         gdbarch.
189
190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
191
192         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
193         (tilegx_unwind_pc): Delete.
194         (tilegx_unwind_dummy_id): Delete.
195         (tilegx_gdbarch_init): Don't register deleted functions with
196         gdbarch.
197
198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
199
200         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
201         (tic6x_dummy_id): Delete.
202         (tic6x_gdbarch_init): Don't register deleted functions with
203         gdbarch.
204
205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
206
207         * sparc-tdep.c (sparc_unwind_pc): Delete.
208         (sparc32_gdbarch_init): Don't register deleted function with
209         gdbarch.
210
211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
212
213         * sh-tdep.c (sh_unwind_sp): Delete.
214         (sh_unwind_pc): Delete.
215         (sh_dummy_id): Delete.
216         (sh_gdbarch_init): Don't register deleted functions with
217         gdbarch.
218
219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
220
221         * score-tdep.c (score_unwind_sp): Delete.
222         (score_unwind_pc): Delete.
223         (score_dummy_id): Delete.
224         (score_gdbarch_init): Don't register deleted functions with
225         gdbarch.
226
227 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
228
229         * rx-tdep.c (rx_unwind_pc): Delete.
230         (rx_unwind_sp): Delete.
231         (rx_dummy_id): Delete.
232         (rx_gdbarch_init): Don't register deleted functions with
233         gdbarch.  Update comment.
234
235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
236
237         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
238         (rs6000_dummy_id): Delete.
239         (rs6000_gdbarch_init): Don't register deleted functions with
240         gdbarch.
241
242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
243
244         * or1k-tdep.c (or1k_dummy_id): Delete.
245         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
246
247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
248
249         * nios2-tdep.c (nios2_dummy_id): Delete.
250         (nios2_unwind_sp): Delete.
251         (nios2_gdbarch_init): Don't register deleted functions with
252         gdbarch.
253
254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
255
256         * nds32-tdep.c (nds32_dummy_id): Delete.
257         (nds32_unwind_pc): Delete.
258         (nds32_unwind_sp): Delete.
259         (nds32_gdbarch_init): Don't register deleted functions with
260         gdbarch.
261
262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
263
264         * msp430-tdep.c (msp430_unwind_pc): Delete.
265         (msp430_unwind_sp): Delete.
266         (msp430_dummy_id): Delete.
267         (msp430_gdbarch_init): Don't register deleted functions with
268         gdbarch.
269
270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
271
272         * moxie-tdep.c (moxie_unwind_sp): Delete.
273         (moxie_unwind_pc): Delete.
274         (moxie_dummy_id): Delete.
275         (moxie_gdbarch_init): Don't register deleted functions with
276         gdbarch.
277
278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
279
280         * mn10300-tdep.c (mn10300_dummy_id): Delete.
281         (mn10300_unwind_pc): Delete.
282         (mn10300_unwind_sp): Delete.
283         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
284         mn10300_unwind_sp.
285         (mn10300_frame_unwind_init): Don't register deleted functions with
286         gdbarch.
287
288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
289
290         * mep-tdep.c (mep_unwind_pc): Delete.
291         (mep_unwind_sp): Delete.
292         (mep_dummy_id): Delete.
293         (mep_gdbarch_init): Don't register deleted functions with
294         gdbarch.
295
296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
297
298         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
299         (m68hc11_unwind_sp): Delete.
300         (m68hc11_gdbarch_init): Don't register deleted functions with
301         gdbarch.
302
303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
304
305         * m32r-tdep.c (m32r_unwind_sp): Delete.
306         (m32r_unwind_pc): Delete.
307         (m32r_dummy_id): Delete.
308         (m32r_gdbarch_init): Don't register deleted functions with
309         gdbarch.
310
311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
312
313         * m32c-tdep.c (m32c_unwind_pc): Delete.
314         (m32c_unwind_sp): Delete.
315         (m32c_dummy_id): Delete.
316         (m32c_gdbarch_init): Don't register deleted functions with
317         gdbarch.
318
319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
320
321         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
322         (lm32_unwind_pc): Delete.
323         (lm32_dummy_id): Delete.
324         (lm32_gdbarch_init): Don't register deleted functions with
325         gdbarch.
326
327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
328
329         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
330         (iq2000_unwind_pc): Delete.
331         (iq2000_dummy_id): Delete.
332         (iq2000_gdbarch_init): Don't register deleted functions with
333         gdbarch.
334
335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
336
337         * nds32-tdep.c (nds32_type_align): Delete.
338         (nds32_push_dummy_call): Use type_align instead.
339
340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
341
342         * arm-tdep.c (arm_type_align): Only handle vector override case.
343         (arm_push_dummy_call): Use type_align.
344         (arm_gdbarch_init): Register arm_type_align gdbarch function.
345
346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
347
348         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
349         case.
350         (pass_on_stack): Use type_align.
351         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
352         function.
353
354 2019-04-23  Tom Tromey  <tromey@adacore.com>
355
356         * dwarf2read.c (line_header::file_name_at): Remove unused
357         overload.
358
359 2019-04-23  Tom de Vries  <tdevries@suse.de>
360
361         PR gdb/24438
362         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
363         invocation.
364
365
366 2019-03-27  Ali Tamur  <tamur@google.com>
367
368         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
369         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
370         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
371         (dwarf_expr_context::get_addr_index): Likewise
372         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
373         (symbol_needs_eval_context::get_addr_index): Likewise
374         (disassemble_dwarf_expression): Add DW_OP_addrx
375         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
376         (read_cutu_die_from_dwo): Update comment
377         (skip_one_die): Add DW_FORM_addrx
378         (read_attribute_value): Likewise
379         (var_decode_location): Add DW_OP_addrx
380         (dwarf2_const_value_attr): Add DW_FORM_addrx
381         (dump_die_shallow): Likewise
382         (dwarf2_fetch_constant_bytes): Likewise
383         (decode_locdesc): Add DW_OP_addrx
384         (skip_form_bytes): Add DW_FORM_addrx
385
386 2019-04-22  Ali Tamur  <tamur@google.com>
387
388         * MAINTAINERS (Write After Approval): Add self.
389
390 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
391
392         * solib-svr4.c (get_svr4_info): Add pspace parameter.
393         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
394         (open_symbol_file_object): Likewise.
395         (svr4_default_sos): Add info parameter.
396         (svr4_read_so_list): Likewise.
397         (svr4_current_sos_direct): Adjust functions calls to pass down
398         info.
399         (svr4_current_sos_1): Add info parameter.
400         (svr4_current_sos): Call get_svr4_info, pass info down to
401         svr4_current_sos_1.
402         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
403         get_svr4_info.
404         (svr4_in_dynsym_resolve_code): Pass current_program_space to
405         get_svr4_info.
406         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
407         to get_svr4_info.
408         (probes_table_remove_objfile_probes): Likewise.
409         (register_solib_event_probe): Add info parameter.
410         (solist_update_incremental): Pass info parameter down to
411         svr4_read_so_list.
412         (disable_probes_interface): Add info parameter.
413         (svr4_handle_solib_event): Pass current_program_space to
414         get_svr4_info.  Adjust disable_probes_interface cleanup.
415         (svr4_create_probe_breakpoints): Add info parameter, pass it
416         down to register_solib_event_probe.
417         (svr4_create_solib_event_breakpoints): Add info parameter,
418         pass it down to svr4_create_probe_breakpoints.
419         (enable_break): Pass info down to
420         svr4_create_solib_event_breakpoints.
421         (svr4_solib_create_inferior_hook): Pass current_program_space to
422         get_svr4_info.
423         (svr4_clear_solib): Likewise.
424
425 2019-04-22  Pedro Alves  <palves@redhat.com>
426
427         * solib-svr4.c (svr4_free_objfile_observer): New.
428         (probe_and_action::objfile): New field.
429         (probes_table_htab_remove_objfile_probes)
430         (probes_table_remove_objfile_probes): New functions.
431         (register_solib_event_probe): Add 'objfile' parameter.  Store it
432         in the new probe_and_action.  Don't store the probe in 'lookup'.
433         (svr4_create_probe_breakpoints): Pass objfile to
434         register_solib_event_probe.
435         (_initialize_svr4_solib): Register a free_objfile observer.
436
437 2019-04-19  Tom Tromey  <tom@tromey.com>
438
439         * common/queue.h: Remove.
440
441 2019-04-19  Tom Tromey  <tom@tromey.com>
442
443         * event-loop.c: Don't include "common/queue.h".
444
445 2019-04-19  Tom Tromey  <tom@tromey.com>
446
447         * remote.c (remote_target): Use delete.
448         * remote-notif.h: Include <list>, not "common/queue.h".
449         (notif_client_p): Remove typedef.
450         (remote_notif_state): Add constructor, destructor, initializer.
451         <notif_queue>: Now a std::list.
452         (remote_notif_state_xfree): Don't declare.
453         * remote-notif.c (remote_notif_process, handle_notification)
454         (remote_notif_state_allocate): Update.
455         (~remote_notif_state): Rename from remote_notif_state_xfree.
456
457 2019-04-19  Tom Tromey  <tom@tromey.com>
458
459         * symfile.c (reread_symbols): Update.
460         * objfiles.c (objfile_register_static_link)
461         (objfile_lookup_static_link): Update
462         (~objfile) Don't delete static_links.
463         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
464
465 2019-04-19  Tom Tromey  <tom@tromey.com>
466
467         * type-stack.h (struct type_stack) <insert>: Constify string.
468         * type-stack.c (type_stack::insert): Constify string.
469         * gdbtypes.h (lookup_template_type): Update.
470         (address_space_name_to_int): Update.
471         * gdbtypes.c (address_space_name_to_int): Make space_identifier
472         const.
473         (lookup_template_type): Make name const.
474         * c-exp.y: Update rules.
475         (lex_one_token, classify_name, classify_inner_name)
476         (c_print_token): Update.
477         * p-exp.y: Update rules.
478         (yylex): Update.
479         * f-exp.y: Update rules.
480         (yylex): Update.
481         * d-exp.y: Update rules.
482         (lex_one_token, classify_name, classify_inner_name): Update.
483         * parse.c (write_dollar_variable, copy_name): Return std::string.
484         * parser-defs.h (copy_name): Change return type.
485         * m2-exp.y: Update rules.
486         (yylex): Update.
487         * go-exp.y (lex_one_token): Update.
488         Update rules.
489         (classify_unsafe_function, classify_packaged_name)
490         (classify_name, yylex): Update.
491
492 2019-04-19  Sergei Trofimovich <siarheit@google.com>
493
494         * configure.ac: add --enable-source-highlight switch.
495         * configure: Regenerate.
496         * top.c (print_gdb_version): plumb --enable-source-highlight
497         status to "show configuration".
498
499 2019-04-19  Tom Tromey  <tromey@adacore.com>
500
501         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
502         Check ADA_TYPE_P.
503         (empty_record, ada_template_to_fixed_record_type_1)
504         (template_to_static_fixed_type)
505         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
506         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
507         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
508         macros.
509
510 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
511
512         PR symtab/24423:
513         * source.c (print_source_lines_base): Advance "iter" when a
514         control character is seen.
515
516 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
517
518         * inferior.h (struct infcall_suspend_state_deleter):
519         Catch exception in destructor to avoid crash.
520
521 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
522
523         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
524         close to the add_com "shell".
525
526 2019-04-18  Tom Tromey  <tromey@adacore.com>
527
528         * process-stratum-target.h (class process_stratum_target)
529         <stratum>: Add "final".
530
531 2019-04-17  Tom Tromey  <tromey@adacore.com>
532
533         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
534         against nullptr before use.
535
536 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
537
538         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
539
540 2019-04-17  Jim Wilson  <jimw@sifive.com>
541             Andrew Burgess  <andrew.burgess@embecosm.com>
542
543         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
544         code read might fail, assume 4-byte breakpoint in that case.
545
546 2019-04-15  Leszek Swirski  <leszeks@google.com>
547
548         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
549         rather than a hand-rolled POD check when checking for forced MEMORY
550         classification.
551
552 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
553
554         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
555         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
556         function.
557         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
558         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
559         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
560         declaration.
561
562 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
563
564         * aarch64-linux-nat.c
565         (aarch64_linux_nat_target::thread_architecture): Add override.
566         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
567         each VQ.
568
569 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
570
571         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
572
573 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
574
575         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
576         target types of size 96-bits, add some additional comments, and
577         check that the builtin type we found was the correct size.
578
579 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
580
581         * utils.c (prompt_for_continue): Don't restore the styling at the
582         end, as applied_style has the wrong value.  This fixes styling in
583         long lists of file names that are interrupted by the "Continue?"
584         prompt.
585
586 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
587
588         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
589         * c-lang.c (c_language_defn): Likewise.
590         (cplus_language_defn): Likewise.
591         (asm_language_defn): Likewise.
592         (minimal_language_defn): Likewise.
593         * d-lang.c (d_language_defn): Likewise.
594         * f-lang.c (f_language_defn): Likewise.
595         * go-lang.c (go_language_defn): Likewise.
596         * language.c (unknown_language_defn): Likewise.
597         (auto_language_defn): Likewise.
598         * language.h (struct language_defn): Remove la_magic field.
599         (LANG_MAGIC): Delete.
600         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
601         * objc-lang.c (objc_language_defn): Likewise.
602         * opencl-lang.c (opencl_language_defn): Likewise.
603         * p-lang.c (pascal_language_defn): Likewise.
604         * rust-lang.c (rust_language_defn): Likewise.
605
606 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
607
608         * riscv-tdep.c (riscv_type_align): New function.
609         (riscv_type_alignment): Delete.
610         (riscv_arg_location): Use 'type_align'.
611         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
612
613 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
614
615         * gdbtypes.c (type_align): A struct with no non-static fields also
616         has alignment of 1.
617
618 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
619
620         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
621         component to 0.
622         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
623         member.
624         (riscv_struct_info::analyse): New implementation using new
625         analyse_inner member function.
626         (riscv_struct_info::field_offset): New member function.
627         (riscv_struct_info::m_offsets): New member variable.
628         (riscv_struct_info::analyse_inner): New private member function,
629         takes the old implementation of riscv_struct_info::analyse but
630         extended to track field offsets.
631         (riscv_call_arg_struct): Update the struct folding special cases
632         to handle cases where empty C++ structs, which are non-zero
633         length, are found.
634         (riscv_arg_location): Initialise the length of each location, a
635         non-zero length now indicates the location is in use.
636         (riscv_push_dummy_call): Allow for the first location having a
637         non-zero offset when setting up arguments.
638         (riscv_return_value): Likewise, but for return values.
639
640 2019-04-11  Tom Tromey  <tromey@adacore.com>
641
642         * utils.c (internal_vproblem): Make "msg" const.
643
644 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
645
646         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
647         * trad-frame.c (trad_frame_reset_saved_regs): New function.
648         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
649         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
650
651 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
652
653         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
654         function.
655         (fill_gregset): Call amd64_linux_collect_native_gregset instead
656         of amd64_collect_native_gregset.
657         (amd64_linux_nat_target::store_registers): Likewise.
658
659 2019-04-10  Tom Tromey  <tom@tromey.com>
660
661         * symtab.c (lookup_global_symbol_from_objfile)
662         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
663         * objfiles.h (class separate_debug_iterator): New.
664         (class separate_debug_range): New.
665         (struct objfile) <separate_debug_objfiles>: New method.
666         (objfile_separate_debug_iterate): Don't declare.
667         * objfiles.c (separate_debug_iterator::operator++): Rename from
668         objfile_separate_debug_iterate.
669         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
670         iterator.
671         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
672         iterator.
673
674 2019-04-10  Tom Tromey  <tom@tromey.com>
675
676         * symfile.c (reread_symbols): Remove old comment.
677         * objfiles.c (free_all_objfiles): Fix a typo.
678
679 2019-04-10  Tom Tromey  <tom@tromey.com>
680
681         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
682         * minsyms.c (lookup_minimal_symbol): Use foreach.
683         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
684         (lookup_minimal_symbol_solib_trampoline): Likewise.
685         * symfile.c (reread_symbols): Use foreach.
686
687 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
688             Tom Tromey  <tromey@adacore.com>
689
690         PR rust/24414:
691         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
692         (rust_lex_int_test): Change "value" to be LONGEST.
693         (rust_lex_tests): Add test for long integer literal.
694
695 2019-04-09  Tom Tromey  <tromey@adacore.com>
696
697         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
698         to bool.
699         (extended_remote_target::attach): Update.
700         (remote_target::remote_notice_new_inferior): Update.
701         (remote_target::add_current_inferior_and_thread): Update.
702         * inferior.c (exit_inferior_1): Use "false".
703         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
704
705 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
706
707         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
708         the "start" command.
709
710 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
711
712         * python/py-inferior.c (infpy_thread_from_thread_handle):
713         Adjust comments to reflect renaming of thread_from_thread_handle
714         to thread_from_handle.  Adjust keywords.  Fix type error message.
715         (inferior_object_methods): Add thread_from_handle.  Retain
716         thread_from_thread_handle, but mark it as deprecated.
717
718 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
719
720         * gdbthread.h (find_thread_by_handle): Revise declaration.
721         * thread.c (find_thread_by_handle): Likewise.  Adjust
722         implementation too.
723         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
724         support for buffer objects as handles.
725
726 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
727
728         * python/py-infthread.c (thpy_thread_handle): New function.
729         (thread_object_methods): Register thpy_thread_handle.
730
731 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
732
733         * gdbthread.h (thread_to_thread_handle): Declare.
734         * thread.c (gdbtypes.h): Include.
735         (thread_to_thread_handle): New function.
736
737         * target.h (struct target_ops): Add thread_info_to_thread_handle.
738         (target_thread_info_to_thread_handle): Declare.
739         * target.c (target_thread_info_to_thread_handle): New function.
740         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
741         * target-delegates.c: Regenerate.
742
743         * linux-thread-db.c (class thread_db_target): Add method
744         thread_info_to_thread_handle.
745         (thread_db_target::thread_info_to_thread_handle): Define.
746         * remote.c (class remote_target): Add new method
747         thread_info_to_thread_handle.
748         (remote_target::thread_info_to_thread_handle): Define.
749
750 2019-04-08  Pedro Alves  <palves@redhat.com>
751
752         * common/common-exceptions.c (throw_exception): Don't create
753         named object to throw; throw directly.
754         (throw_it): Likewise.  Don't initialize gdb_exception::message
755         here, with new; pass FMT and AP to the ctor instead.
756         * common/common-exceptions.h: Include <string>.
757         (gdb_exception::gdb_exception(enum return_reason, enum errors,
758         const char *, va_list)): New ctor.  Use std::make_shared.
759         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
760         errors)): Delete.
761         (gdb_exception_error::gdb_exception_error(enum errors, const char
762         *, va_list)): New.
763         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
764         Add assertion.
765         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
766         errors)): Delete.
767         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
768         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
769         Add assertion.
770
771 2019-04-08  Tom Tromey  <tom@tromey.com>
772
773         * valops.c (value_rtti_indirect_type): Replace throw_exception
774         with throw.
775         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
776         with throw.
777         * thread.c (thr_try_catch_cmd): Replace throw_exception with
778         throw.
779         * target.c (target_translate_tls_address): Replace throw_exception
780         with throw.
781         * stack.c (frame_apply_command_count): Replace throw_exception
782         with throw.
783         * solib-spu.c (append_ocl_sos): Replace throw_exception with
784         throw.
785         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
786         with throw.
787         * rs6000-tdep.c (rs6000_frame_cache)
788         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
789         * remote.c: Replace throw_exception with throw.
790         * record-full.c (record_full_message, record_full_wait_1)
791         (record_full_restore): Replace throw_exception with throw.
792         * record-btrace.c:
793         (get_thread_current_frame_id, record_btrace_start_replaying)
794         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
795         (cmd_record_btrace_start): Replace throw_exception with throw.
796         * parse.c (parse_exp_in_context_1): Replace throw_exception with
797         throw.
798         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
799         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
800         * linespec.c:
801         (find_linespec_symbols): Replace throw_exception with throw.
802         * infrun.c (displaced_step_prepare, resume): Replace
803         throw_exception with throw.
804         * infcmd.c (post_create_inferior): Replace throw_exception with
805         throw.
806         * inf-loop.c (inferior_event_handler): Replace throw_exception
807         with throw.
808         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
809         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
810         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
811         (get_prev_frame_always, get_frame_pc_if_available)
812         (get_frame_address_in_block_if_available, get_frame_language):
813         Replace throw_exception with throw.
814         * frame-unwind.c (frame_unwind_try_unwinder): Replace
815         throw_exception with throw.
816         * eval.c (fetch_subexp_value, evaluate_var_value)
817         (evaluate_funcall, evaluate_subexp_standard): Replace
818         throw_exception with throw.
819         * dwarf2loc.c (call_site_find_chain)
820         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
821         Replace throw_exception with throw.
822         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
823         with throw.
824         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
825         throw.
826         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
827         * completer.c (complete_line_internal): Replace throw_exception
828         with throw.
829         * compile/compile-object-run.c (compile_object_run): Replace
830         throw_exception with throw.
831         * cli/cli-script.c (process_next_line): Replace throw_exception
832         with throw.
833         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
834         (btrace_enable, btrace_maint_update_pt_packets): Replace
835         throw_exception with throw.
836         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
837         throw_exception with throw.
838         * break-catch-throw.c (re_set_exception_catchpoint): Replace
839         throw_exception with throw.
840         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
841         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
842         * aarch64-tdep.c (aarch64_make_prologue_cache)
843         (aarch64_make_stub_cache): Replace throw_exception with throw.
844
845 2019-04-08  Tom Tromey  <tom@tromey.com>
846
847         * common/common-exceptions.c (throw_exception): Rename from
848         throw_exception_cxx.  Remove old copy.  Make argument const.
849         (throw_it): Create and throw exception objects directly.
850         * common/common-exceptions.h (throw_exception): Make argument
851         const.
852         (struct gdb_exception_error): Add constructor.
853         (struct gdb_exception_quit): Add constructor.
854
855 2019-04-08  Tom Tromey  <tom@tromey.com>
856
857         * common/common-exceptions.h (exception_rethrow): Don't declare.
858         (TRY_SJLJ): Update comment.
859         (TRY, CATCH, END_CATCH): Remove.
860         * common/common-exceptions.c (exception_rethrow): Remove.
861
862 2019-04-08  Tom Tromey  <tom@tromey.com>
863
864         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
865         Remove.
866         (gdb_exception_error): Rename from
867         gdb_exception_RETURN_MASK_ERROR.
868         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
869         (gdb_quit_bad_alloc): Update.
870         * aarch64-tdep.c: Update.
871         * ada-lang.c: Update.
872         * ada-typeprint.c: Update.
873         * ada-valprint.c: Update.
874         * amd64-tdep.c: Update.
875         * arch-utils.c: Update.
876         * break-catch-throw.c: Update.
877         * breakpoint.c: Update.
878         * btrace.c: Update.
879         * c-varobj.c: Update.
880         * cli/cli-cmds.c: Update.
881         * cli/cli-interp.c: Update.
882         * cli/cli-script.c: Update.
883         * common/common-exceptions.c: Update.
884         * common/new-op.c: Update.
885         * common/selftest.c: Update.
886         * compile/compile-c-symbols.c: Update.
887         * compile/compile-cplus-symbols.c: Update.
888         * compile/compile-object-load.c: Update.
889         * compile/compile-object-run.c: Update.
890         * completer.c: Update.
891         * corelow.c: Update.
892         * cp-abi.c: Update.
893         * cp-support.c: Update.
894         * cp-valprint.c: Update.
895         * darwin-nat.c: Update.
896         * disasm-selftests.c: Update.
897         * dtrace-probe.c: Update.
898         * dwarf-index-cache.c: Update.
899         * dwarf-index-write.c: Update.
900         * dwarf2-frame-tailcall.c: Update.
901         * dwarf2-frame.c: Update.
902         * dwarf2loc.c: Update.
903         * dwarf2read.c: Update.
904         * eval.c: Update.
905         * event-loop.c: Update.
906         * event-top.c: Update.
907         * exec.c: Update.
908         * f-valprint.c: Update.
909         * fbsd-tdep.c: Update.
910         * frame-unwind.c: Update.
911         * frame.c: Update.
912         * gdbtypes.c: Update.
913         * gnu-v3-abi.c: Update.
914         * guile/guile-internal.h: Update.
915         * guile/scm-block.c: Update.
916         * guile/scm-breakpoint.c: Update.
917         * guile/scm-cmd.c: Update.
918         * guile/scm-disasm.c: Update.
919         * guile/scm-frame.c: Update.
920         * guile/scm-lazy-string.c: Update.
921         * guile/scm-math.c: Update.
922         * guile/scm-param.c: Update.
923         * guile/scm-ports.c: Update.
924         * guile/scm-pretty-print.c: Update.
925         * guile/scm-symbol.c: Update.
926         * guile/scm-symtab.c: Update.
927         * guile/scm-type.c: Update.
928         * guile/scm-value.c: Update.
929         * i386-linux-tdep.c: Update.
930         * i386-tdep.c: Update.
931         * inf-loop.c: Update.
932         * infcall.c: Update.
933         * infcmd.c: Update.
934         * infrun.c: Update.
935         * jit.c: Update.
936         * language.c: Update.
937         * linespec.c: Update.
938         * linux-fork.c: Update.
939         * linux-nat.c: Update.
940         * linux-tdep.c: Update.
941         * linux-thread-db.c: Update.
942         * main.c: Update.
943         * mi/mi-cmd-break.c: Update.
944         * mi/mi-cmd-stack.c: Update.
945         * mi/mi-interp.c: Update.
946         * mi/mi-main.c: Update.
947         * objc-lang.c: Update.
948         * p-valprint.c: Update.
949         * parse.c: Update.
950         * ppc-linux-tdep.c: Update.
951         * printcmd.c: Update.
952         * python/py-arch.c: Update.
953         * python/py-breakpoint.c: Update.
954         * python/py-cmd.c: Update.
955         * python/py-finishbreakpoint.c: Update.
956         * python/py-frame.c: Update.
957         * python/py-framefilter.c: Update.
958         * python/py-gdb-readline.c: Update.
959         * python/py-inferior.c: Update.
960         * python/py-infthread.c: Update.
961         * python/py-lazy-string.c: Update.
962         * python/py-linetable.c: Update.
963         * python/py-objfile.c: Update.
964         * python/py-param.c: Update.
965         * python/py-prettyprint.c: Update.
966         * python/py-progspace.c: Update.
967         * python/py-record-btrace.c: Update.
968         * python/py-record.c: Update.
969         * python/py-symbol.c: Update.
970         * python/py-type.c: Update.
971         * python/py-unwind.c: Update.
972         * python/py-utils.c: Update.
973         * python/py-value.c: Update.
974         * python/python.c: Update.
975         * record-btrace.c: Update.
976         * record-full.c: Update.
977         * remote-fileio.c: Update.
978         * remote.c: Update.
979         * riscv-tdep.c: Update.
980         * rs6000-aix-tdep.c: Update.
981         * rs6000-tdep.c: Update.
982         * rust-exp.y: Update.
983         * rust-lang.c: Update.
984         * s390-tdep.c: Update.
985         * selftest-arch.c: Update.
986         * solib-dsbt.c: Update.
987         * solib-frv.c: Update.
988         * solib-spu.c: Update.
989         * solib-svr4.c: Update.
990         * solib.c: Update.
991         * sparc64-linux-tdep.c: Update.
992         * stack.c: Update.
993         * symfile-mem.c: Update.
994         * symmisc.c: Update.
995         * target.c: Update.
996         * thread.c: Update.
997         * top.c: Update.
998         * tracefile-tfile.c: Update.
999         * tui/tui.c: Update.
1000         * typeprint.c: Update.
1001         * unittests/cli-utils-selftests.c: Update.
1002         * unittests/parse-connection-spec-selftests.c: Update.
1003         * valops.c: Update.
1004         * valprint.c: Update.
1005         * value.c: Update.
1006         * varobj.c: Update.
1007         * windows-nat.c: Update.
1008         * x86-linux-nat.c: Update.
1009         * xml-support.c: Update.
1010
1011 2019-04-08  Tom Tromey  <tom@tromey.com>
1012
1013         * xml-support.c: Use C++ exception handling.
1014         * x86-linux-nat.c: Use C++ exception handling.
1015         * windows-nat.c: Use C++ exception handling.
1016         * varobj.c: Use C++ exception handling.
1017         * value.c: Use C++ exception handling.
1018         * valprint.c: Use C++ exception handling.
1019         * valops.c: Use C++ exception handling.
1020         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1021         handling.
1022         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1023         * typeprint.c: Use C++ exception handling.
1024         * tui/tui.c: Use C++ exception handling.
1025         * tracefile-tfile.c: Use C++ exception handling.
1026         * top.c: Use C++ exception handling.
1027         * thread.c: Use C++ exception handling.
1028         * target.c: Use C++ exception handling.
1029         * symmisc.c: Use C++ exception handling.
1030         * symfile-mem.c: Use C++ exception handling.
1031         * stack.c: Use C++ exception handling.
1032         * sparc64-linux-tdep.c: Use C++ exception handling.
1033         * solib.c: Use C++ exception handling.
1034         * solib-svr4.c: Use C++ exception handling.
1035         * solib-spu.c: Use C++ exception handling.
1036         * solib-frv.c: Use C++ exception handling.
1037         * solib-dsbt.c: Use C++ exception handling.
1038         * selftest-arch.c: Use C++ exception handling.
1039         * s390-tdep.c: Use C++ exception handling.
1040         * rust-lang.c: Use C++ exception handling.
1041         * rust-exp.y: Use C++ exception handling.
1042         * rs6000-tdep.c: Use C++ exception handling.
1043         * rs6000-aix-tdep.c: Use C++ exception handling.
1044         * riscv-tdep.c: Use C++ exception handling.
1045         * remote.c: Use C++ exception handling.
1046         * remote-fileio.c: Use C++ exception handling.
1047         * record-full.c: Use C++ exception handling.
1048         * record-btrace.c: Use C++ exception handling.
1049         * python/python.c: Use C++ exception handling.
1050         * python/py-value.c: Use C++ exception handling.
1051         * python/py-utils.c: Use C++ exception handling.
1052         * python/py-unwind.c: Use C++ exception handling.
1053         * python/py-type.c: Use C++ exception handling.
1054         * python/py-symbol.c: Use C++ exception handling.
1055         * python/py-record.c: Use C++ exception handling.
1056         * python/py-record-btrace.c: Use C++ exception handling.
1057         * python/py-progspace.c: Use C++ exception handling.
1058         * python/py-prettyprint.c: Use C++ exception handling.
1059         * python/py-param.c: Use C++ exception handling.
1060         * python/py-objfile.c: Use C++ exception handling.
1061         * python/py-linetable.c: Use C++ exception handling.
1062         * python/py-lazy-string.c: Use C++ exception handling.
1063         * python/py-infthread.c: Use C++ exception handling.
1064         * python/py-inferior.c: Use C++ exception handling.
1065         * python/py-gdb-readline.c: Use C++ exception handling.
1066         * python/py-framefilter.c: Use C++ exception handling.
1067         * python/py-frame.c: Use C++ exception handling.
1068         * python/py-finishbreakpoint.c: Use C++ exception handling.
1069         * python/py-cmd.c: Use C++ exception handling.
1070         * python/py-breakpoint.c: Use C++ exception handling.
1071         * python/py-arch.c: Use C++ exception handling.
1072         * printcmd.c: Use C++ exception handling.
1073         * ppc-linux-tdep.c: Use C++ exception handling.
1074         * parse.c: Use C++ exception handling.
1075         * p-valprint.c: Use C++ exception handling.
1076         * objc-lang.c: Use C++ exception handling.
1077         * mi/mi-main.c: Use C++ exception handling.
1078         * mi/mi-interp.c: Use C++ exception handling.
1079         * mi/mi-cmd-stack.c: Use C++ exception handling.
1080         * mi/mi-cmd-break.c: Use C++ exception handling.
1081         * main.c: Use C++ exception handling.
1082         * linux-thread-db.c: Use C++ exception handling.
1083         * linux-tdep.c: Use C++ exception handling.
1084         * linux-nat.c: Use C++ exception handling.
1085         * linux-fork.c: Use C++ exception handling.
1086         * linespec.c: Use C++ exception handling.
1087         * language.c: Use C++ exception handling.
1088         * jit.c: Use C++ exception handling.
1089         * infrun.c: Use C++ exception handling.
1090         * infcmd.c: Use C++ exception handling.
1091         * infcall.c: Use C++ exception handling.
1092         * inf-loop.c: Use C++ exception handling.
1093         * i386-tdep.c: Use C++ exception handling.
1094         * i386-linux-tdep.c: Use C++ exception handling.
1095         * guile/scm-value.c: Use C++ exception handling.
1096         * guile/scm-type.c: Use C++ exception handling.
1097         * guile/scm-symtab.c: Use C++ exception handling.
1098         * guile/scm-symbol.c: Use C++ exception handling.
1099         * guile/scm-pretty-print.c: Use C++ exception handling.
1100         * guile/scm-ports.c: Use C++ exception handling.
1101         * guile/scm-param.c: Use C++ exception handling.
1102         * guile/scm-math.c: Use C++ exception handling.
1103         * guile/scm-lazy-string.c: Use C++ exception handling.
1104         * guile/scm-frame.c: Use C++ exception handling.
1105         * guile/scm-disasm.c: Use C++ exception handling.
1106         * guile/scm-cmd.c: Use C++ exception handling.
1107         * guile/scm-breakpoint.c: Use C++ exception handling.
1108         * guile/scm-block.c: Use C++ exception handling.
1109         * guile/guile-internal.h: Use C++ exception handling.
1110         * gnu-v3-abi.c: Use C++ exception handling.
1111         * gdbtypes.c: Use C++ exception handling.
1112         * frame.c: Use C++ exception handling.
1113         * frame-unwind.c: Use C++ exception handling.
1114         * fbsd-tdep.c: Use C++ exception handling.
1115         * f-valprint.c: Use C++ exception handling.
1116         * exec.c: Use C++ exception handling.
1117         * event-top.c: Use C++ exception handling.
1118         * event-loop.c: Use C++ exception handling.
1119         * eval.c: Use C++ exception handling.
1120         * dwarf2read.c: Use C++ exception handling.
1121         * dwarf2loc.c: Use C++ exception handling.
1122         * dwarf2-frame.c: Use C++ exception handling.
1123         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1124         * dwarf-index-write.c: Use C++ exception handling.
1125         * dwarf-index-cache.c: Use C++ exception handling.
1126         * dtrace-probe.c: Use C++ exception handling.
1127         * disasm-selftests.c: Use C++ exception handling.
1128         * darwin-nat.c: Use C++ exception handling.
1129         * cp-valprint.c: Use C++ exception handling.
1130         * cp-support.c: Use C++ exception handling.
1131         * cp-abi.c: Use C++ exception handling.
1132         * corelow.c: Use C++ exception handling.
1133         * completer.c: Use C++ exception handling.
1134         * compile/compile-object-run.c: Use C++ exception handling.
1135         * compile/compile-object-load.c: Use C++ exception handling.
1136         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1137         * compile/compile-c-symbols.c: Use C++ exception handling.
1138         * common/selftest.c: Use C++ exception handling.
1139         * common/new-op.c: Use C++ exception handling.
1140         * cli/cli-script.c: Use C++ exception handling.
1141         * cli/cli-interp.c: Use C++ exception handling.
1142         * cli/cli-cmds.c: Use C++ exception handling.
1143         * c-varobj.c: Use C++ exception handling.
1144         * btrace.c: Use C++ exception handling.
1145         * breakpoint.c: Use C++ exception handling.
1146         * break-catch-throw.c: Use C++ exception handling.
1147         * arch-utils.c: Use C++ exception handling.
1148         * amd64-tdep.c: Use C++ exception handling.
1149         * ada-valprint.c: Use C++ exception handling.
1150         * ada-typeprint.c: Use C++ exception handling.
1151         * ada-lang.c: Use C++ exception handling.
1152         * aarch64-tdep.c: Use C++ exception handling.
1153
1154 2019-04-08  Tom Tromey  <tom@tromey.com>
1155
1156         * xml-support.c (gdb_xml_parser::parse): Update.
1157         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1158         * value.c (show_convenience): Update.
1159         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1160         (test_parse_flags_qcs): Update.
1161         * thread.c (thr_try_catch_cmd): Update.
1162         * target.c (target_translate_tls_address): Update.
1163         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1164         (info_frame_command_core, frame_apply_command_count): Update.
1165         * rust-exp.y (rust_lex_exception_test): Update.
1166         * riscv-tdep.c (riscv_print_one_register_info): Update.
1167         * remote.c (remote_target::enable_btrace): Update.
1168         * record-btrace.c (record_btrace_enable_warn): Update.
1169         * python/py-utils.c (gdbpy_convert_exception): Update.
1170         * printcmd.c (do_one_display, print_variable_and_value): Update.
1171         * mi/mi-main.c (mi_print_exception): Update.
1172         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1173         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1174         * linux-nat.c (linux_nat_target::attach): Update.
1175         * linux-fork.c (class scoped_switch_fork_info): Update.
1176         * infrun.c (displaced_step_prepare): Update.
1177         * infcall.c (call_function_by_hand_dummy): Update.
1178         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1179         * gnu-v3-abi.c (print_one_vtable): Update.
1180         * frame.c (get_prev_frame_always): Update.
1181         * f-valprint.c (info_common_command_for_block): Update.
1182         * exec.c (try_open_exec_file): Update.
1183         * exceptions.c (print_exception, exception_print)
1184         (exception_fprintf, exception_print_same): Update.
1185         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1186         * dwarf-index-cache.c (index_cache::store)
1187         (index_cache::lookup_gdb_index): Update.
1188         * darwin-nat.c (maybe_cache_shell): Update.
1189         * cp-valprint.c (cp_print_value_fields): Update.
1190         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1191         (gcc_cplus_symbol_address): Update.
1192         * compile/compile-c-symbols.c (gcc_convert_symbol)
1193         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1194         * common/selftest.c: Update.
1195         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1196         a std::string.
1197         (exception_try_scope_entry, exception_try_scope_exit): Don't
1198         declare.
1199         (struct exception_try_scope): Remove.
1200         (TRY): Don't use exception_try_scope.
1201         (struct gdb_exception): Add constructor, operator=.
1202         <what>: New method.
1203         (struct gdb_exception_RETURN_MASK_ALL)
1204         (struct gdb_exception_RETURN_MASK_ERROR)
1205         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1206         (struct gdb_quit_bad_alloc): Update.
1207         * common/common-exceptions.c (exception_none): Change
1208         initializer.
1209         (struct catcher) <state, exception>: Initialize inline.
1210         <prev>: Remove member.
1211         (current_catcher): Remove.
1212         (catchers): New global.
1213         (exceptions_state_mc_init): Simplify.
1214         (catcher_pop): Remove.
1215         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1216         (try_scope_depth, exception_try_scope_entry)
1217         (exception_try_scope_exit): Remove.
1218         (throw_exception_sjlj): Update.
1219         (exception_messages, exception_messages_size): Remove.
1220         (throw_it): Simplify.
1221         (gdb_exception_sliced_copy): Remove.
1222         (throw_exception_cxx): Update.
1223         * cli/cli-script.c (script_from_file): Update.
1224         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1225         Update.
1226         * ada-valprint.c (ada_val_print): Update.
1227         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1228         (create_excep_cond_exprs): Update.
1229
1230 2019-04-08  Tom Tromey  <tom@tromey.com>
1231
1232         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1233         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1234         (TRY, CATCH, END_CATCH): Remove some definitions.
1235         * common/common-exceptions.c: Don't use GDB_XCPT.
1236         (catcher_list_size): Remove.
1237         (throw_exception, throw_it): Simplify.
1238
1239 2019-04-05  Tom Tromey  <tom@tromey.com>
1240
1241         Revert the header-sorting patch.
1242         * ft32-tdep.c: Revert.
1243         * frv-tdep.c: Revert.
1244         * frv-linux-tdep.c: Revert.
1245         * frame.c: Revert.
1246         * frame-unwind.c: Revert.
1247         * frame-base.c: Revert.
1248         * fork-child.c: Revert.
1249         * findvar.c: Revert.
1250         * findcmd.c: Revert.
1251         * filesystem.c: Revert.
1252         * filename-seen-cache.h: Revert.
1253         * filename-seen-cache.c: Revert.
1254         * fbsd-tdep.c: Revert.
1255         * fbsd-nat.h: Revert.
1256         * fbsd-nat.c: Revert.
1257         * f-valprint.c: Revert.
1258         * f-typeprint.c: Revert.
1259         * f-lang.c: Revert.
1260         * extension.h: Revert.
1261         * extension.c: Revert.
1262         * extension-priv.h: Revert.
1263         * expprint.c: Revert.
1264         * exec.h: Revert.
1265         * exec.c: Revert.
1266         * exceptions.c: Revert.
1267         * event-top.c: Revert.
1268         * event-loop.c: Revert.
1269         * eval.c: Revert.
1270         * elfread.c: Revert.
1271         * dwarf2read.h: Revert.
1272         * dwarf2read.c: Revert.
1273         * dwarf2loc.c: Revert.
1274         * dwarf2expr.h: Revert.
1275         * dwarf2expr.c: Revert.
1276         * dwarf2-frame.c: Revert.
1277         * dwarf2-frame-tailcall.c: Revert.
1278         * dwarf-index-write.h: Revert.
1279         * dwarf-index-write.c: Revert.
1280         * dwarf-index-common.c: Revert.
1281         * dwarf-index-cache.h: Revert.
1282         * dwarf-index-cache.c: Revert.
1283         * dummy-frame.c: Revert.
1284         * dtrace-probe.c: Revert.
1285         * disasm.h: Revert.
1286         * disasm.c: Revert.
1287         * disasm-selftests.c: Revert.
1288         * dictionary.c: Revert.
1289         * dicos-tdep.c: Revert.
1290         * demangle.c: Revert.
1291         * dcache.h: Revert.
1292         * dcache.c: Revert.
1293         * darwin-nat.h: Revert.
1294         * darwin-nat.c: Revert.
1295         * darwin-nat-info.c: Revert.
1296         * d-valprint.c: Revert.
1297         * d-namespace.c: Revert.
1298         * d-lang.c: Revert.
1299         * ctf.c: Revert.
1300         * csky-tdep.c: Revert.
1301         * csky-linux-tdep.c: Revert.
1302         * cris-tdep.c: Revert.
1303         * cris-linux-tdep.c: Revert.
1304         * cp-valprint.c: Revert.
1305         * cp-support.c: Revert.
1306         * cp-namespace.c: Revert.
1307         * cp-abi.c: Revert.
1308         * corelow.c: Revert.
1309         * corefile.c: Revert.
1310         * continuations.c: Revert.
1311         * completer.h: Revert.
1312         * completer.c: Revert.
1313         * complaints.c: Revert.
1314         * coffread.c: Revert.
1315         * coff-pe-read.c: Revert.
1316         * cli-out.h: Revert.
1317         * cli-out.c: Revert.
1318         * charset.c: Revert.
1319         * c-varobj.c: Revert.
1320         * c-valprint.c: Revert.
1321         * c-typeprint.c: Revert.
1322         * c-lang.c: Revert.
1323         * buildsym.c: Revert.
1324         * buildsym-legacy.c: Revert.
1325         * build-id.h: Revert.
1326         * build-id.c: Revert.
1327         * btrace.c: Revert.
1328         * bsd-uthread.c: Revert.
1329         * breakpoint.h: Revert.
1330         * breakpoint.c: Revert.
1331         * break-catch-throw.c: Revert.
1332         * break-catch-syscall.c: Revert.
1333         * break-catch-sig.c: Revert.
1334         * blockframe.c: Revert.
1335         * block.c: Revert.
1336         * bfin-tdep.c: Revert.
1337         * bfin-linux-tdep.c: Revert.
1338         * bfd-target.c: Revert.
1339         * bcache.c: Revert.
1340         * ax-general.c: Revert.
1341         * ax-gdb.h: Revert.
1342         * ax-gdb.c: Revert.
1343         * avr-tdep.c: Revert.
1344         * auxv.c: Revert.
1345         * auto-load.c: Revert.
1346         * arm-wince-tdep.c: Revert.
1347         * arm-tdep.c: Revert.
1348         * arm-symbian-tdep.c: Revert.
1349         * arm-pikeos-tdep.c: Revert.
1350         * arm-obsd-tdep.c: Revert.
1351         * arm-nbsd-tdep.c: Revert.
1352         * arm-nbsd-nat.c: Revert.
1353         * arm-linux-tdep.c: Revert.
1354         * arm-linux-nat.c: Revert.
1355         * arm-fbsd-tdep.c: Revert.
1356         * arm-fbsd-nat.c: Revert.
1357         * arm-bsd-tdep.c: Revert.
1358         * arch-utils.c: Revert.
1359         * arc-tdep.c: Revert.
1360         * arc-newlib-tdep.c: Revert.
1361         * annotate.h: Revert.
1362         * annotate.c: Revert.
1363         * amd64-windows-tdep.c: Revert.
1364         * amd64-windows-nat.c: Revert.
1365         * amd64-tdep.c: Revert.
1366         * amd64-sol2-tdep.c: Revert.
1367         * amd64-obsd-tdep.c: Revert.
1368         * amd64-obsd-nat.c: Revert.
1369         * amd64-nbsd-tdep.c: Revert.
1370         * amd64-nbsd-nat.c: Revert.
1371         * amd64-nat.c: Revert.
1372         * amd64-linux-tdep.c: Revert.
1373         * amd64-linux-nat.c: Revert.
1374         * amd64-fbsd-tdep.c: Revert.
1375         * amd64-fbsd-nat.c: Revert.
1376         * amd64-dicos-tdep.c: Revert.
1377         * amd64-darwin-tdep.c: Revert.
1378         * amd64-bsd-nat.c: Revert.
1379         * alpha-tdep.c: Revert.
1380         * alpha-obsd-tdep.c: Revert.
1381         * alpha-nbsd-tdep.c: Revert.
1382         * alpha-mdebug-tdep.c: Revert.
1383         * alpha-linux-tdep.c: Revert.
1384         * alpha-linux-nat.c: Revert.
1385         * alpha-bsd-tdep.c: Revert.
1386         * alpha-bsd-nat.c: Revert.
1387         * aix-thread.c: Revert.
1388         * agent.c: Revert.
1389         * addrmap.c: Revert.
1390         * ada-varobj.c: Revert.
1391         * ada-valprint.c: Revert.
1392         * ada-typeprint.c: Revert.
1393         * ada-tasks.c: Revert.
1394         * ada-lang.c: Revert.
1395         * aarch64-tdep.c: Revert.
1396         * aarch64-ravenscar-thread.c: Revert.
1397         * aarch64-newlib-tdep.c: Revert.
1398         * aarch64-linux-tdep.c: Revert.
1399         * aarch64-linux-nat.c: Revert.
1400         * aarch64-fbsd-tdep.c: Revert.
1401         * aarch64-fbsd-nat.c: Revert.
1402         * aarch32-linux-nat.c: Revert.
1403
1404 2019-04-05  Tom Tromey  <tom@tromey.com>
1405
1406         * ft32-tdep.c: Sort headers.
1407         * frv-tdep.c: Sort headers.
1408         * frv-linux-tdep.c: Sort headers.
1409         * frame.c: Sort headers.
1410         * frame-unwind.c: Sort headers.
1411         * frame-base.c: Sort headers.
1412         * fork-child.c: Sort headers.
1413         * findvar.c: Sort headers.
1414         * findcmd.c: Sort headers.
1415         * filesystem.c: Sort headers.
1416         * filename-seen-cache.h: Sort headers.
1417         * filename-seen-cache.c: Sort headers.
1418         * fbsd-tdep.c: Sort headers.
1419         * fbsd-nat.h: Sort headers.
1420         * fbsd-nat.c: Sort headers.
1421         * f-valprint.c: Sort headers.
1422         * f-typeprint.c: Sort headers.
1423         * f-lang.c: Sort headers.
1424         * extension.h: Sort headers.
1425         * extension.c: Sort headers.
1426         * extension-priv.h: Sort headers.
1427         * expprint.c: Sort headers.
1428         * exec.h: Sort headers.
1429         * exec.c: Sort headers.
1430         * exceptions.c: Sort headers.
1431         * event-top.c: Sort headers.
1432         * event-loop.c: Sort headers.
1433         * eval.c: Sort headers.
1434         * elfread.c: Sort headers.
1435         * dwarf2read.h: Sort headers.
1436         * dwarf2read.c: Sort headers.
1437         * dwarf2loc.c: Sort headers.
1438         * dwarf2expr.h: Sort headers.
1439         * dwarf2expr.c: Sort headers.
1440         * dwarf2-frame.c: Sort headers.
1441         * dwarf2-frame-tailcall.c: Sort headers.
1442         * dwarf-index-write.h: Sort headers.
1443         * dwarf-index-write.c: Sort headers.
1444         * dwarf-index-common.c: Sort headers.
1445         * dwarf-index-cache.h: Sort headers.
1446         * dwarf-index-cache.c: Sort headers.
1447         * dummy-frame.c: Sort headers.
1448         * dtrace-probe.c: Sort headers.
1449         * disasm.h: Sort headers.
1450         * disasm.c: Sort headers.
1451         * disasm-selftests.c: Sort headers.
1452         * dictionary.c: Sort headers.
1453         * dicos-tdep.c: Sort headers.
1454         * demangle.c: Sort headers.
1455         * dcache.h: Sort headers.
1456         * dcache.c: Sort headers.
1457         * darwin-nat.h: Sort headers.
1458         * darwin-nat.c: Sort headers.
1459         * darwin-nat-info.c: Sort headers.
1460         * d-valprint.c: Sort headers.
1461         * d-namespace.c: Sort headers.
1462         * d-lang.c: Sort headers.
1463         * ctf.c: Sort headers.
1464         * csky-tdep.c: Sort headers.
1465         * csky-linux-tdep.c: Sort headers.
1466         * cris-tdep.c: Sort headers.
1467         * cris-linux-tdep.c: Sort headers.
1468         * cp-valprint.c: Sort headers.
1469         * cp-support.c: Sort headers.
1470         * cp-namespace.c: Sort headers.
1471         * cp-abi.c: Sort headers.
1472         * corelow.c: Sort headers.
1473         * corefile.c: Sort headers.
1474         * continuations.c: Sort headers.
1475         * completer.h: Sort headers.
1476         * completer.c: Sort headers.
1477         * complaints.c: Sort headers.
1478         * coffread.c: Sort headers.
1479         * coff-pe-read.c: Sort headers.
1480         * cli-out.h: Sort headers.
1481         * cli-out.c: Sort headers.
1482         * charset.c: Sort headers.
1483         * c-varobj.c: Sort headers.
1484         * c-valprint.c: Sort headers.
1485         * c-typeprint.c: Sort headers.
1486         * c-lang.c: Sort headers.
1487         * buildsym.c: Sort headers.
1488         * buildsym-legacy.c: Sort headers.
1489         * build-id.h: Sort headers.
1490         * build-id.c: Sort headers.
1491         * btrace.c: Sort headers.
1492         * bsd-uthread.c: Sort headers.
1493         * breakpoint.h: Sort headers.
1494         * breakpoint.c: Sort headers.
1495         * break-catch-throw.c: Sort headers.
1496         * break-catch-syscall.c: Sort headers.
1497         * break-catch-sig.c: Sort headers.
1498         * blockframe.c: Sort headers.
1499         * block.c: Sort headers.
1500         * bfin-tdep.c: Sort headers.
1501         * bfin-linux-tdep.c: Sort headers.
1502         * bfd-target.c: Sort headers.
1503         * bcache.c: Sort headers.
1504         * ax-general.c: Sort headers.
1505         * ax-gdb.h: Sort headers.
1506         * ax-gdb.c: Sort headers.
1507         * avr-tdep.c: Sort headers.
1508         * auxv.c: Sort headers.
1509         * auto-load.c: Sort headers.
1510         * arm-wince-tdep.c: Sort headers.
1511         * arm-tdep.c: Sort headers.
1512         * arm-symbian-tdep.c: Sort headers.
1513         * arm-pikeos-tdep.c: Sort headers.
1514         * arm-obsd-tdep.c: Sort headers.
1515         * arm-nbsd-tdep.c: Sort headers.
1516         * arm-nbsd-nat.c: Sort headers.
1517         * arm-linux-tdep.c: Sort headers.
1518         * arm-linux-nat.c: Sort headers.
1519         * arm-fbsd-tdep.c: Sort headers.
1520         * arm-fbsd-nat.c: Sort headers.
1521         * arm-bsd-tdep.c: Sort headers.
1522         * arch-utils.c: Sort headers.
1523         * arc-tdep.c: Sort headers.
1524         * arc-newlib-tdep.c: Sort headers.
1525         * annotate.h: Sort headers.
1526         * annotate.c: Sort headers.
1527         * amd64-windows-tdep.c: Sort headers.
1528         * amd64-windows-nat.c: Sort headers.
1529         * amd64-tdep.c: Sort headers.
1530         * amd64-sol2-tdep.c: Sort headers.
1531         * amd64-obsd-tdep.c: Sort headers.
1532         * amd64-obsd-nat.c: Sort headers.
1533         * amd64-nbsd-tdep.c: Sort headers.
1534         * amd64-nbsd-nat.c: Sort headers.
1535         * amd64-nat.c: Sort headers.
1536         * amd64-linux-tdep.c: Sort headers.
1537         * amd64-linux-nat.c: Sort headers.
1538         * amd64-fbsd-tdep.c: Sort headers.
1539         * amd64-fbsd-nat.c: Sort headers.
1540         * amd64-dicos-tdep.c: Sort headers.
1541         * amd64-darwin-tdep.c: Sort headers.
1542         * amd64-bsd-nat.c: Sort headers.
1543         * alpha-tdep.c: Sort headers.
1544         * alpha-obsd-tdep.c: Sort headers.
1545         * alpha-nbsd-tdep.c: Sort headers.
1546         * alpha-mdebug-tdep.c: Sort headers.
1547         * alpha-linux-tdep.c: Sort headers.
1548         * alpha-linux-nat.c: Sort headers.
1549         * alpha-bsd-tdep.c: Sort headers.
1550         * alpha-bsd-nat.c: Sort headers.
1551         * aix-thread.c: Sort headers.
1552         * agent.c: Sort headers.
1553         * addrmap.c: Sort headers.
1554         * ada-varobj.c: Sort headers.
1555         * ada-valprint.c: Sort headers.
1556         * ada-typeprint.c: Sort headers.
1557         * ada-tasks.c: Sort headers.
1558         * ada-lang.c: Sort headers.
1559         * aarch64-tdep.c: Sort headers.
1560         * aarch64-ravenscar-thread.c: Sort headers.
1561         * aarch64-newlib-tdep.c: Sort headers.
1562         * aarch64-linux-tdep.c: Sort headers.
1563         * aarch64-linux-nat.c: Sort headers.
1564         * aarch64-fbsd-tdep.c: Sort headers.
1565         * aarch64-fbsd-nat.c: Sort headers.
1566         * aarch32-linux-nat.c: Sort headers.
1567
1568 2019-04-04  Tom Tromey  <tom@tromey.com>
1569
1570         * varobj.c (varobj_create): Update.
1571         * rust-exp.y (struct rust_parser) <update_innermost_block,
1572         lookup_symbol>: New methods.
1573         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1574         Rename.
1575         (rust_parser::rust_lookup_type)
1576         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1577         * printcmd.c (display_command, do_one_display): Update.
1578         * parser-defs.h (struct parser_state) <parser_state>: Add
1579         "tracker" parameter.
1580         (block_tracker): New member.
1581         (class innermost_block_tracker) <innermost_block_tracker>: Add
1582         "types" parameter.
1583         <reset>: Remove method.
1584         (innermost_block): Don't declare.
1585         (null_post_parser): Update.
1586         * parse.c (innermost_block): Remove global.
1587         (write_dollar_variable): Update.
1588         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1589         Remove "tracker_types" parameter.
1590         (parse_expression): Add "tracker" parameter.
1591         (parse_expression_for_completion): Update.
1592         (null_post_parser): Add "tracker" parameter.
1593         * p-exp.y: Update rules.
1594         * m2-exp.y: Update rules.
1595         * language.h (struct language_defn) <la_post_parser>: Add
1596         "tracker" parameter.
1597         * go-exp.y: Update rules.
1598         * f-exp.y: Update rules.
1599         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1600         parameter.
1601         * d-exp.y: Update rules.
1602         * c-exp.y: Update rules.
1603         * breakpoint.c (set_breakpoint_condition): Create an
1604         innermost_block_tracker.
1605         (watch_command_1): Likewise.
1606         * ada-lang.c (resolve): Add "tracker" parameter.
1607         (resolve_subexp): Likewise.
1608         * ada-exp.y (write_var_from_sym): Update.
1609
1610 2019-04-04  Tom Tromey  <tom@tromey.com>
1611
1612         * type-stack.h: New file.
1613         * type-stack.c: New file.
1614         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1615         type-stack.h.
1616         (insert_into_type_stack, insert_type, push_type, push_type_int)
1617         (insert_type_address_space, pop_type, pop_type_int)
1618         (pop_typelist, pop_type_stack, append_type_stack)
1619         (push_type_stack, get_type_stack, push_typelist)
1620         (follow_type_instance_flags, follow_types): Don't declare.
1621         * parse.c (type_stack): Remove global.
1622         (parse_exp_in_context): Update.
1623         (insert_into_type_stack, insert_type, push_type, push_type_int)
1624         (insert_type_address_space, pop_type, pop_type_int)
1625         (pop_typelist, pop_type_stack, append_type_stack)
1626         (push_type_stack, get_type_stack, push_typelist)
1627         (follow_type_instance_flags, follow_types): Remove (moved to
1628         type-stack.c).
1629         * f-exp.y (type_stack): New global.
1630         Update rules.
1631         (push_kind_type, f_parse): Update.
1632         * d-exp.y (type_stack): New global.
1633         Update rules.
1634         (d_parse): Update.
1635         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1636         Update rules.
1637         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1638         (HFILES_NO_SRCDIR): Add type-stack.h.
1639
1640 2019-04-04  Tom Tromey  <tom@tromey.com>
1641
1642         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1643         (rust_parser::convert_ast_to_expression, rust_parse)
1644         (rust_lex_test_completion, rust_lex_tests): Update.
1645         * parser-defs.h (struct expr_completion_state): New.
1646         (struct parser_state) <parser_state>: Add completion parameter.
1647         <mark_struct_expression, mark_completion_tag>: New methods.
1648         <parse_completion, m_completion_state>: New members.
1649         (prefixify_expression, null_post_parser): Update.
1650         (mark_struct_expression, mark_completion_tag): Don't declare.
1651         * parse.c (parse_completion, expout_last_struct)
1652         (expout_tag_completion_type, expout_completion_name): Remove
1653         globals.
1654         (parser_state::mark_struct_expression)
1655         (parser_state::mark_completion_tag): Now methods.
1656         (prefixify_expression): Add last_struct parameter.
1657         (prefixify_subexp): Likewise.
1658         (parse_exp_1): Update.
1659         (parse_exp_in_context): Add cstate parameter.  Update.
1660         (parse_expression_for_completion): Create an
1661         expr_completion_state.
1662         (null_post_parser): Add "completion" parameter.
1663         * p-exp.y: Update rules.
1664         (yylex): Update.
1665         * language.h (struct language_defn) <la_post_parser>: Add
1666         "completing" parameter.
1667         * go-exp.y: Update rules.
1668         (lex_one_token): Update.
1669         * expression.h (parse_completion): Don't declare.
1670         * d-exp.y: Update rules.
1671         (lex_one_token): Update rules.
1672         * c-exp.y: Update rules.
1673         (lex_one_token): Update.
1674         * ada-lang.c (resolve): Add "parse_completion" parameter.
1675         (resolve_subexp): Likewise.
1676         (ada_resolve_function): Likewise.
1677
1678 2019-04-04  Tom Tromey  <tom@tromey.com>
1679
1680         * parser-defs.h (struct parser_state) <start_arglist,
1681         end_arglist>: New methods.
1682         <arglist_len, m_funcall_chain>: New members.
1683         (arglist_len, start_arglist, end_arglist): Don't declare.
1684         * parse.c (arglist_len, funcall_chain): Remove global.
1685         (start_arglist, end_arglist): Remove functions.
1686         (parse_exp_in_context): Update.
1687         * p-exp.y: Update rules.
1688         * m2-exp.y: Update rules.
1689         * go-exp.y: Update rules.
1690         * f-exp.y: Update rules.
1691         * d-exp.y: Update rules.
1692         * c-exp.y: Update rules.
1693
1694 2019-04-04  Tom Tromey  <tom@tromey.com>
1695
1696         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1697         lex_operator, push_back>: New methods.
1698         Update all rules.
1699         (rust_parser::lex_hex, lex_escape): Rename and update.
1700         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1701         (rust_parser::lex_operator): Rename and update.
1702         (rust_parser::lex_number, rustyylex, rustyyerror)
1703         (rust_lex_test_init, rust_lex_test_sequence)
1704         (rust_lex_test_push_back, rust_lex_tests): Update.
1705         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1706         parameter.
1707         <lexptr, prev_lexptr>: New members.
1708         (lexptr, prev_lexptr): Don't declare.
1709         * parse.c (lexptr, prev_lexptr): Remove globals.
1710         (parse_exp_in_context): Update.
1711         * p-exp.y (yylex, yyerror): Update.
1712         * m2-exp.y (parse_number, yylex, yyerror): Update.
1713         * go-exp.y (lex_one_token, yyerror): Update.
1714         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1715         * d-exp.y (lex_one_token, yyerror): Update.
1716         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1717         (lex_one_token, yyerror): Update.
1718         * ada-lex.l (YY_INPUT): Update.
1719         (rewind_to_char): Update.
1720         * ada-exp.y (yyerror): Update.
1721
1722 2019-04-04  Tom Tromey  <tom@tromey.com>
1723
1724         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1725         * parser-defs.h (struct parser_state) <parser_state>: Add new
1726         parameter.
1727         <comma_terminates>: New member.
1728         (comma_terminates): Don't declare global.
1729         * parse.c (comma_terminates): Remove global.
1730         (parse_exp_in_context): Update.
1731         * p-exp.y (yylex): Update.
1732         * m2-exp.y (yylex): Update.
1733         * go-exp.y (lex_one_token): Update.
1734         * f-exp.y (yylex): Update.
1735         * d-exp.y (lex_one_token): Update.
1736         * c-exp.y (lex_one_token): Update.
1737         * ada-lex.l: Update.
1738
1739 2019-04-04  Tom Tromey  <tom@tromey.com>
1740
1741         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1742         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1743         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1744         * parser-defs.h (paren_depth): Don't declare.
1745         * parse.c (paren_depth): Remove global.
1746         (parse_exp_in_context): Update.
1747         * p-exp.y (paren_depth): New global.
1748         (pascal_parse): Initialize it.
1749         * m2-exp.y (paren_depth): New global.
1750         (m2_parse): Initialize it.
1751         * go-exp.y (paren_depth): New global.
1752         (go_parse): Initialize it.
1753         * f-exp.y (paren_depth): New global.
1754         (f_parse): Initialize it.
1755         * d-exp.y (paren_depth): New global.
1756         (d_parse): Initialize it.
1757         * c-exp.y (paren_depth): New global.
1758         (c_parse): Initialize it.
1759         * ada-lex.l (paren_depth): New global.
1760         (lexer_init): Initialize it.
1761
1762 2019-04-04  Tom Tromey  <tom@tromey.com>
1763
1764         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1765         (rust_parser::convert_ast_to_type)
1766         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1767         * parser-defs.h (struct parser_state) <parser_state>: Add
1768         parameters.  Initialize new members.
1769         <expression_context_block, expression_context_pc>: New members.
1770         * parse.c (expression_context_block, expression_context_pc):
1771         Remove globals.
1772         (parse_exp_in_context): Update.
1773         * p-exp.y: Update all rules.
1774         (yylex): Update.
1775         * m2-exp.y: Update all rules.
1776         (yylex): Update.
1777         * go-exp.y (yylex): Update.
1778         * f-exp.y (yylex): Update.
1779         * d-exp.y: Update all rules.
1780         (yylex): Update.
1781         * c-exp.y: Update all rules.
1782         (lex_one_token, classify_name, yylex, c_parse): Update.
1783         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1784
1785 2019-04-04  Tom Tromey  <tom@tromey.com>
1786
1787         * gdbarch.h, gdbarch.c: Rebuild.
1788         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1789         * stap-probe.h: 
1790         (struct stap_parse_info): Replace "parser_state" with
1791         "expr_builder".
1792         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1793         (parser_state): New class.
1794         * parse.c (expr_builder): Rename.
1795         (expr_builder::release): Rename.
1796         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1797         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1798         (write_exp_elt_longcst, write_exp_elt_floatcst)
1799         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1800         (write_exp_string_vector, write_exp_bitstring)
1801         (write_exp_msymbol, mark_struct_expression)
1802         (write_dollar_variable)
1803         (insert_type_address_space, increase_expout_size): Replace
1804         "parser_state" with "expr_builder".
1805         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1806         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1807         "parser_state" with "expr_builder".
1808
1809 2019-04-04  Tom Tromey  <tom@tromey.com>
1810
1811         * rust-exp.y: Replace "parse_language" with method call.
1812         * p-exp.y: 
1813         (yylex): Replace "parse_language" with method call.
1814         * m2-exp.y: 
1815         (yylex): Replace "parse_language" with method call.
1816         * go-exp.y (classify_name): Replace "parse_language" with method
1817         call.
1818         * f-exp.y (yylex): Replace "parse_language" with method call.
1819         * d-exp.y (lex_one_token): Replace "parse_language" with method
1820         call.
1821         * c-exp.y: 
1822         (lex_one_token, classify_name, yylex): Replace "parse_language"
1823         with method call.
1824         * ada-exp.y (find_primitive_type, type_char)
1825         (type_system_address): Replace "parse_language" with method call.
1826
1827 2019-04-04  Tom Tromey  <tom@tromey.com>
1828
1829         * rust-exp.y: Replace "parse_gdbarch" with method call.
1830         * parse.c (write_dollar_variable, insert_type_address_space):
1831         Replace "parse_gdbarch" with method call.
1832         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1833         call.
1834         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1835         call.
1836         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1837         "parse_gdbarch" with method call.
1838         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1839         with method call.
1840         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1841         "parse_gdbarch" with method call.
1842         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1843         "parse_gdbarch" with method call.
1844         * c-exp.y (parse_type, parse_number, classify_name): Replace
1845         "parse_gdbarch" with method call.
1846         * ada-lex.l: Replace "parse_gdbarch" with method call.
1847         * ada-exp.y (parse_type, find_primitive_type, type_char)
1848         (type_system_address): Replace "parse_gdbarch" with method call.
1849
1850 2019-04-04  Tom Tromey  <tom@tromey.com>
1851
1852         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1853         * stap-probe.c (stap_parse_argument): Update.
1854         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1855         initial_size parameter.
1856         * rust-exp.y (rust_lex_tests): Update.
1857         * parse.c (parser_state): Update.
1858         (parse_exp_in_context): Update.
1859         * parser-defs.h (struct parser_state) <parser_state>: Remove
1860         "initial_size" parameter.
1861
1862 2019-04-04  Tom Tromey  <tom@tromey.com>
1863
1864         * parser-defs.h (increase_expout_size): Don't declare.
1865         * parse.c (increase_expout_size): Now static.
1866
1867 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1868
1869         * gnu-nat.c (gnu_nat_target::wait): Fix
1870         target_waitstatus_to_string call.
1871
1872 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1873
1874         * eval.c (evaluate_subexp_standard): Handle internal functions
1875         during Fortran function call handling.
1876
1877 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1878
1879         * NEWS: Mention new internal functions.
1880         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1881         (read_base_type): Use dwarf2_init_complex_target_type.
1882         * value.c (creal_internal_fn): New function.
1883         (cimag_internal_fn): New function.
1884         (_initialize_values): Register new internal functions.
1885
1886 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1887
1888         * infrun.c (stop_all_threads): If debug_infrun, always
1889         trace the wait status after wait_one, using
1890         target_waitstatus_to_string and target_pid_to_str.
1891         (handle_inferior_event): Replace various trace of
1892         wait status kind by a single trace.
1893         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1894         wait status kind image by target_waitstatus_to_string.
1895         * target/waitstatus.c (target_waitstatus_to_string): Fix
1896         obsolete comment.
1897
1898 2019-04-01  Tom Tromey  <tromey@adacore.com>
1899
1900         PR symtab/23331:
1901         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1902
1903 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1904             Pedro Alves  <palves@redhat.com>
1905
1906         * top.c (quit_force): Call 'finalize_values'.
1907         * value.c (finalize_values): New function.
1908         * value.h (finalize_values): Declare.
1909
1910 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1911
1912         * NEWS: Announce $_gdb_major and $_gdb_minor.
1913
1914         * top.c (init_gdb_version_vars): New function.
1915         (gdb_init): Call init_gdb_version_vars.
1916
1917 2019-03-29  Tom Tromey  <tromey@adacore.com>
1918
1919         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1920         help text.  Remove dead code.
1921
1922 2019-03-29  Keith Seitz  <keiths@redhat.com>
1923
1924         From Siddhesh Poyarekar:
1925         * f-lang.h (f77_get_upperbound): Return LONGEST.
1926         (f77_get_lowerbound): Likewise.
1927         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1928         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1929         print them.
1930         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1931         plongest to format print it.
1932         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1933         (f77_get_upperbound): Likewise.
1934         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1935         LOWER_BOUND to LONGEST.
1936         (f77_create_arrayprint_offset_tbl): Likewise.
1937
1938 2019-03-29  Keith Seitz  <keiths@redhat.com>
1939
1940         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1941         %s/pulongest for TYPE_LENGTH instead of %d in format
1942         strings.
1943         * ada-typerint.c (ada_print_type): Likewise.
1944         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1945         * compile/compile-c-support.c (generate_register_struct): Likewise.
1946         * gdbtypes.c (recursive_dump_type): Likewise.
1947         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1948         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1949         instead of %d in format strings.
1950         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1951         to std::min to ULONGEST.
1952         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1953         instead of %d in format strings.
1954         * tracepoint.c (info_scope_command): Likewise.
1955         * typeprint.c (print_offset_data::update)
1956         (print_offset_data::finish): Likewise.
1957         * xtensa-tdep.c (xtensa_store_return_value)
1958         (xtensa_push_dummy_call): Likewise.
1959
1960 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1961
1962         * windows-nat.c (display_selector): Fixed format specifications
1963         for 64-bit Cygwin.
1964
1965 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1966
1967         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1968
1969 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1970
1971         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1972         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1973         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1974         (nios2_linux_init_abi): Install it.
1975
1976 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1977
1978         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1979
1980 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1981
1982         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1983
1984 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1985             Tom Tromey  <tromey@adacore.com>
1986
1987         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1988
1989 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1990
1991         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1992         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1993         method to compute the bounds of range types. Also print "[evaluated]"
1994         if the bounds' values come from a dynamic evaluation.
1995
1996 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1997
1998         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1999         whitespace when pretty printing is on.
2000
2001 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2002
2003         * ppc-linux-nat.c: Add include.
2004
2005 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2006
2007         * NEWS: Mention AArch64 Pointer Authentication.
2008
2009 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2010
2011         * arm-linux-nat.c: Add include.
2012
2013 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2014
2015         * source-cache.c (source_cache::get_source_lines): Re-read
2016         fullname after calling open_source_file.
2017
2018 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2019
2020         * NEWS: Mention TLS support for FreeBSD.
2021
2022 2019-03-25  Tom Tromey  <tromey@adacore.com>
2023
2024         * minsyms.c (BUNCH_SIZE): Update comment.
2025         (~minimal_symbol_reader): Remove old comment.
2026         (compact_minimal_symbols): Update comment.
2027         (minimal_symbol_reader::install): Remove old comment.  Update
2028         other comments.
2029
2030 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2031
2032         * s390-linux-nat.c: Add include.
2033
2034 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2035
2036         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2037         Call linux_get_hwcap.
2038         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2039         Likewise.
2040         (aarch64_linux_get_hwcap): Remove function.
2041         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2042         declaration.
2043         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2044         linux_get_hwcap.
2045         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2046         * linux-tdep.c (linux_get_hwcap): Add function.
2047         (linux_get_hwcap2): Likewise.
2048         * linux-tdep.h (linux_get_hwcap): Add declaration.
2049         (linux_get_hwcap2): Likewise.
2050         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2051         (ppc_linux_get_hwcap2): Likewise.
2052         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2053         linux_get_hwcap.
2054         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2055         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2056         (ppc_linux_nat_target::read_description): Likewise.
2057         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2058         * s390-linux-nat.c: Likewise.
2059         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2060
2061 2019-03-24  Tom Tromey  <tom@tromey.com>
2062
2063         * ada-lang.c (standard_lookup): Simplify initialization.
2064         (ada_lookup_symbol_nonlocal): Simplify return.
2065         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2066         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2067         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2068         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2069         initialization.
2070         * solib.c (solib_global_lookup): Simplify.
2071         * symtab.c (null_block_symbol): Remove.
2072         (symbol_cache_lookup): Simplify returns.
2073         (lookup_language_this): Simplify returns.
2074         (lookup_symbol_aux): Simplify return.
2075         (lookup_local_symbol): Simplify returns.
2076         (lookup_global_symbol_from_objfile): Simplify return.
2077         (lookup_symbol_in_objfile_symtabs)
2078         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2079         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2080         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2081         * cp-namespace.c (cp_lookup_bare_symbol)
2082         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2083         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2084         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2085         (cp_lookup_symbol_via_imports): Simplify initialization.
2086         (find_symbol_in_baseclass): Likewise.
2087         * symtab.h (null_block_symbol): Remove.
2088         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2089         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2090         (d_lookup_symbol_module): Likewise.
2091         (find_symbol_in_baseclass): Simplify initialization.
2092
2093 2019-03-24  Tom Tromey  <tom@tromey.com>
2094
2095         * expression.h: Don't include symtab.h.
2096         (struct block): Forward declare.
2097
2098 2019-03-24  Tom Tromey  <tom@tromey.com>
2099
2100         * c-exp.y (typebase): Remove casts.
2101         * gdbtypes.c (lookup_unsigned_typename, )
2102         (lookup_signed_typename): Remove cast.
2103         * eval.c (parse_to_comma_and_eval): Remove cast.
2104         * parse.c (write_dollar_variable): Remove cast.
2105         * block.h (struct block) <superblock>: Now const.
2106         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2107         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2108         (map_block): Make "block" const.
2109         * symfile.h (struct quick_symbol_functions)
2110         <map_matching_symbols>: Constify block argument to "callback".
2111         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2112         const.
2113         (find_pc_sect_compunit_symtab): Make "b" const.
2114         (find_symbol_at_address): Likewise.
2115         (search_symbols): Likewise.
2116         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2117         (dw2_debug_names_lookup_symbol): Likewise.
2118         (dw2_map_matching_symbols): Update.
2119         * p-valprint.c (pascal_val_print): Remove "block".
2120         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2121         (aux_add_nonlocal_symbols): Make "block" const.
2122         (resolve_subexp): Remove cast.
2123         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2124         const.
2125         (iterate_over_file_blocks): Likewise.
2126         * f-exp.y (%union) <bval>: Remove.
2127         * coffread.c (patch_opaque_types): Make "b" const.
2128         * spu-tdep.c (spu_catch_start): Make "block" const.
2129         * c-valprint.c (print_unpacked_pointer): Remove "block".
2130         * symmisc.c (dump_symtab_1): Make "b" const.
2131         (block_depth): Make "block" const.
2132         * d-exp.y (%union) <bval>: Remove.
2133         * cp-support.h (cp_lookup_rtti_type): Update.
2134         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2135         * psymtab.c (psym_lookup_symbol): Make "block" const.
2136         (maintenance_check_psymtabs): Make "b" const.
2137         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2138         (enumerate_locals, enumerate_args): Update.
2139         * python/py-symtab.c (stpy_global_block): Make "block" const.
2140         (stpy_static_block): Likewise.
2141         * inline-frame.c (block_starting_point_at): Make "new_block"
2142         const.
2143         * block.c (find_block_in_blockvector): Make return type const.
2144         (blockvector_for_pc_sect): Make "b" const.
2145         (find_block_in_blockvector): Make "b" const.
2146
2147 2019-03-23  Tom Tromey  <tom@tromey.com>
2148
2149         * varobj.c (varobj_create): Update.
2150         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2151         * printcmd.c (display_command, do_one_display): Don't reset
2152         innermost_block.
2153         * parser-defs.h (enum innermost_block_tracker_type): Move to
2154         expression.h.
2155         (innermost_block): Update comment.
2156         * parse.c (parse_exp_1): Add tracker_types parameter.
2157         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2158         tracker_types parameter.  Reset innermost_block.
2159         (parse_exp_in_context): Remove.
2160         (parse_expression_for_completion): Update.
2161         * objfiles.c (~objfile): Don't reset expression_context_block or
2162         innermost_block.
2163         * expression.h (enum innermost_block_tracker_type): Move from
2164         parser-defs.h.
2165         (parse_exp_1): Add tracker_types parameter.
2166         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2167         reset innermost_block.
2168
2169 2019-03-23  Tom Tromey  <tom@tromey.com>
2170
2171         * objfiles.h: Include bcache.h.
2172
2173 2019-03-23  Tom Tromey  <tom@tromey.com>
2174
2175         * linespec.c (get_current_search_block): Use
2176         scoped_restore_current_language.
2177         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2178
2179 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2180             Jiong Wang  <jiong.wang@arm.com>
2181
2182         * aarch64-linux-tdep.c
2183         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2184         section.
2185         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2186
2187 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2188             Jiong Wang  <jiong.wang@arm.com>
2189
2190         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2191         instructions.
2192         (aarch64_analyze_prologue_test): Add PACIASP test.
2193         (aarch64_prologue_prev_register): Unmask PC value.
2194
2195 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2196             Jiong Wang  <jiong.wang@arm.com>
2197
2198         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2199         (aarch64_dwarf2_prev_register): Unmask PC value.
2200         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2201         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2202         DW_CFA_AARCH64_negate_ra_state.
2203         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2204
2205 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2206             Jiong Wang  <jiong.wang@arm.com>
2207
2208         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2209         registers.
2210         (aarch64_pseudo_register_name): Likewise.
2211         (aarch64_pseudo_register_type): Likewise.
2212         (aarch64_pseudo_register_reggroup_p): Likewise.
2213         (aarch64_gdbarch_init): Add pauth registers.
2214         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2215         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2216         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2217         (struct gdbarch_tdep): Add regnum for ra_state.
2218
2219 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2220             Jiong Wang  <jiong.wang@arm.com>
2221
2222         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2223
2224 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2225             Jiong Wang  <jiong.wang@arm.com>
2226
2227         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2228         function.
2229         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2230         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2231         (aarch64_gdbarch_init): Add puth registers.
2232         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2233         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2234         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2235
2236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2237             Jiong Wang  <jiong.wang@arm.com>
2238
2239         * aarch64-linux-nat.c
2240         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2241         * aarch64-linux-tdep.c
2242         (aarch64_linux_core_read_description): Likewise.
2243         (aarch64_linux_get_hwcap): New function.
2244         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2245         (aarch64_linux_get_hwcap): New declaration.
2246
2247 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2248             Jiong Wang  <jiong.wang@arm.com>
2249
2250         * aarch64-linux-nat.c
2251         (aarch64_linux_nat_target::read_description): Add pauth param.
2252         * aarch64-linux-tdep.c
2253         (aarch64_linux_core_read_description): Likewise.
2254         * aarch64-tdep.c (struct target_desc): Add in pauth.
2255         (aarch64_read_description): Add pauth param.
2256         (aarch64_gdbarch_init): Likewise.
2257         * aarch64-tdep.h (aarch64_read_description): Likewise.
2258         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2259         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2260         * features/Makefile: Add new files.
2261         * features/aarch64-pauth.c: New file.
2262         * features/aarch64-pauth.xml: New file.
2263
2264 2019-03-20  Tom Tromey  <tromey@adacore.com>
2265
2266         * infrun.c (handle_inferior_event): Rename from
2267         handle_inferior_event_1.  Create a scoped_value_mark.
2268         (handle_inferior_event): Remove.
2269
2270 2019-03-19  Tom Tromey  <tromey@adacore.com>
2271
2272         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2273         * infrun.h (print_stop_event): Add "displays" parameter.
2274         * infrun.c (print_stop_event): Add "displays" parameter.
2275
2276 2019-03-19  Pedro Alves  <palves@redhat.com>
2277
2278         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2279         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2280         to -1.  Fix TABs vs spaces.
2281         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2282         * tui/tui-out.h (tui_ui_out) Add intro comments.
2283         <m_line, m_start_of_line>: In-class initialize, and add describing
2284         comment.
2285
2286 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2287
2288         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2289         variable names.
2290         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2291
2292 2019-03-18  Pedro Alves  <palves@redhat.com>
2293             Eli Zaretskii <eliz@gnu.org>
2294
2295         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2296         m_line and m_start_of_line.
2297
2298 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2299
2300         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2301         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2302         it returns a newline.  This fixes a regression in TU mode, whereby
2303         the next line is output on the same screen line as the user input.
2304
2305 2019-03-18  Tom Tromey  <tromey@adacore.com>
2306
2307         * minsyms.c (minimal_symbol_reader::install): Remove call to
2308         obstack_blank.
2309
2310 2019-03-18  Pedro Alves  <palves@redhat.com>
2311
2312         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2313         New globals.
2314         (apply_style): New, factored out from ...
2315         (apply_ansi_escape): ... this.  Handle reverse video mode.
2316         (tui_set_reverse_mode): New function.
2317         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2318         * tui/tui-winsource.c (tui_show_source_line): Use
2319         tui_set_reverse_mode instead of setting A_STANDOUT.
2320         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2321         New setter methods.
2322
2323 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2324
2325         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2326         Handle tabs.
2327
2328 2019-03-18  Tom Tromey  <tromey@adacore.com>
2329
2330         * ada-lang.c (empty_array): Add "high" parameter.
2331         (ada_evaluate_subexp): Update.
2332
2333 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2334
2335         * unittests/string_view-selftests.c: Define
2336         _initialize_string_view_selftests unconditionally.
2337
2338 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2339
2340         PR gdb/24350
2341         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2342
2343 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2344
2345         PR gdb/24351
2346         * windows-nat.c (display_selector): Fix format specifiers.
2347
2348 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2349
2350         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2351         tui_refill_source_window instead of tui_refresh_win, to update the
2352         current execution line.  This fixes redisplay of the current line
2353         when stepping through the code with "next" or "step".
2354
2355 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2356
2357         * source-cache.c (source_cache::get_source_lines): Call
2358         find_source_lines to initialize s->nlines.  This fixes vertical
2359         scrolling of TUI source window when the DOWN arrow is pressed.
2360
2361 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2362
2363         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2364         linux-thread-db.c (_initialize_thread_db): Likewise.
2365
2366 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2367
2368         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2369         wclrtoeol in tui_show_source_line".  This reverts changes made in
2370         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2371
2372 2019-03-15  Tom Tromey  <tom@tromey.com>
2373
2374         * symtab.h (struct minimal_symbol): Derive from
2375         general_symbol_info.
2376         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2377         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2378         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2379         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2380         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2381         (MSYMBOL_SEARCH_NAME): Update.
2382         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2383         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2384         * minsyms.c (minimal_symbol_reader::record_full): Update.
2385
2386 2019-03-15  Tom Tromey  <tom@tromey.com>
2387
2388         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2389
2390 2019-03-15  Tom Tromey  <tom@tromey.com>
2391
2392         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2393         unique_xmalloc_ptr.
2394         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2395         Update.
2396         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2397         (build_minimal_symbol_hash_tables)
2398         (minimal_symbol_reader::install): Update.
2399
2400 2019-03-15  Tom Tromey  <tom@tromey.com>
2401
2402         * symtab.c (create_demangled_names_hash): Update.
2403         (symbol_set_names): Update.
2404         * objfiles.h (struct objfile_per_bfd_storage)
2405         <demangled_names_hash>: Now an htab_up.
2406         * objfiles.c (objfile_per_bfd_storage): Simplify.
2407
2408 2019-03-15  Tom Tromey  <tom@tromey.com>
2409
2410         * objfiles.h (struct objfile_per_bfd_storage): Declare
2411         destructor.
2412         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2413         New.
2414         (get_objfile_bfd_data): Use new.  Don't initialize
2415         language_of_main.
2416         (free_objfile_per_bfd_storage): Remove.
2417         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2418
2419 2019-03-15  Tom Tromey  <tom@tromey.com>
2420
2421         * symfile.c (reread_symbols): Update.
2422         * objfiles.c (objfile::objfile): Update.
2423         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2424         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2425         comment.
2426         (minimal_symbol_reader::install): Update.
2427         (terminate_minimal_symbol_table): Remove.
2428         * jit.c (jit_object_close_impl): Update.
2429
2430 2019-03-15  Tom Tromey  <tom@tromey.com>
2431
2432         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2433         initializations.
2434
2435 2019-03-15  Tom Tromey  <tom@tromey.com>
2436
2437         * objfiles.h (struct objfile_per_bfd_storage)
2438         <demangled_hash_languages>: Now a bitset.
2439         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2440         (lookup_minimal_symbol): Update.
2441
2442 2019-03-15  Tom Tromey  <tom@tromey.com>
2443
2444         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2445         Don't return the symbol.
2446         * coffread.c (record_minimal_symbol): Use record_full.
2447
2448 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2449
2450         The MS-Windows port of ncurses fails to switch to a color pair if
2451         one or both of the colors are the implicit default colors.  This
2452         change records the default colors when TUI is initialized, and
2453         then specifies them explicitly when a color pair uses the default
2454         colors.  This allows color styling in TUI mode on MS-Windows.
2455
2456         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2457         ncurses_norm_attr.
2458         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2459         colors in ncurses_norm_attr.
2460         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2461         "none", replace it with the default color recorded in
2462         ncurses_norm_attr.
2463
2464 2019-03-14  Tom Tromey  <tromey@adacore.com>
2465
2466         * source-cache.h (class source_cache) <get_source_lines>: Return
2467         std::string.
2468         * source-cache.c (source_cache::extract_lines): Handle case where
2469         first_pos==npos.  Return std::string.
2470         (source_cache::get_source_lines): Update.
2471
2472 2019-03-14  Tom Tromey  <tromey@adacore.com>
2473
2474         * NEWS: Add item for "style sources" commands.
2475         * source-cache.c (source_cache::get_source_lines): Check
2476         source_styling.
2477         * cli/cli-style.c (source_styling): New global.
2478         (_initialize_cli_style): Add "style sources" commands.
2479         (show_style_sources): New function.
2480         * cli/cli-style.h (source_styling): Declare.
2481
2482 2019-03-14  Pedro Alves  <palves@redhat.com>
2483             Tom Tromey  <tromey@adacore.com>
2484
2485         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2486         * tui/tui-winsource.c (tui_refill_source_window): New function,
2487         from...
2488         (tui_horizontal_source_scroll): ... here.  Move some logic.
2489         * cli/cli-style.c (set_style_enabled): Notify new observable.
2490         * tui/tui-hooks.c (tui_redisplay_source): New function.
2491         (tui_attach_detach_observers): Attach or detach
2492         tui_redisplay_source.
2493         * observable.h (source_styling_changed): New observable.
2494         * observable.c: Define source_styling_changed observable.
2495
2496 2019-03-13  Tom Tromey  <tromey@adacore.com>
2497
2498         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2499         (i386_gnu_nat_target::store_registers): Update.
2500         * target-debug.h (target_debug_print_std_string): New macro.
2501         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2502         * windows-tdep.c (display_one_tib): Update.
2503         * tui/tui-stack.c (tui_make_status_line): Update.
2504         * top.c (print_inferior_quit_action): Update.
2505         * thread.c (thr_try_catch_cmd): Update.
2506         (add_thread_with_info): Update.
2507         (thread_target_id_str): Update.
2508         (thr_try_catch_cmd): Update.
2509         (thread_command): Update.
2510         (thread_find_command): Update.
2511         * record-btrace.c (record_btrace_target::info_record)
2512         (record_btrace_resume_thread, record_btrace_target::resume)
2513         (record_btrace_cancel_resume, record_btrace_step_thread)
2514         (record_btrace_target::wait, record_btrace_target::wait)
2515         (record_btrace_target::wait, record_btrace_target::stop): Update.
2516         * progspace.c (print_program_space): Update.
2517         * process-stratum-target.c
2518         (process_stratum_target::thread_address_space): Update.
2519         * linux-fork.c (linux_fork_mourn_inferior)
2520         (detach_checkpoint_command, info_checkpoints_command)
2521         (linux_fork_context): Update.
2522         (linux_fork_detach): Update.
2523         (class scoped_switch_fork_info): Update.
2524         (delete_checkpoint_command): Update.
2525         * infrun.c (follow_fork_inferior): Update.
2526         (follow_fork_inferior): Update.
2527         (proceed_after_vfork_done): Update.
2528         (handle_vfork_child_exec_or_exit): Update.
2529         (follow_exec): Update.
2530         (displaced_step_prepare_throw): Update.
2531         (displaced_step_restore): Update.
2532         (start_step_over): Update.
2533         (resume_1): Update.
2534         (clear_proceed_status_thread): Update.
2535         (proceed): Update.
2536         (print_target_wait_results): Update.
2537         (do_target_wait): Update.
2538         (context_switch): Update.
2539         (stop_all_threads): Update.
2540         (restart_threads): Update.
2541         (finish_step_over): Update.
2542         (handle_signal_stop): Update.
2543         (switch_back_to_stepped_thread): Update.
2544         (keep_going_pass_signal): Update.
2545         (print_exited_reason): Update.
2546         (normal_stop): Update.
2547         * inferior.c (inferior_pid_to_str): Change return type.
2548         (print_selected_inferior): Update.
2549         (add_inferior): Update.
2550         (detach_inferior): Update.
2551         * dummy-frame.c (fprint_dummy_frames): Update.
2552         * dcache.c (dcache_info_1): Update.
2553         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2554         (btrace_fetch, btrace_clear): Update.
2555         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2556         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2557         type.
2558         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2559         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2560         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2561         * gdbarch.c, gdbarch.h: Rebuild.
2562         * gdbarch.sh (core_pid_to_str): Change return type.
2563         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2564         return type.
2565         (windows_nat_target::pid_to_str): Change return type.
2566         (windows_delete_thread): Update.
2567         (windows_nat_target::attach): Update.
2568         (windows_nat_target::files_info): Update.
2569         * target-delegates.c: Rebuild.
2570         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2571         return type.
2572         (sol_thread_target::pid_to_str): Change return type.
2573         * remote.c (class remote_target) <pid_to_str>: Change return
2574         type.
2575         (remote_target::pid_to_str): Change return type.
2576         (extended_remote_target::attach, remote_target::remote_stop_ns)
2577         (remote_target::remote_notif_remove_queued_reply)
2578         (remote_target::push_stop_reply, remote_target::disable_btrace):
2579         Update.
2580         (extended_remote_target::attach): Update.
2581         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2582         type.
2583         (gdbsim_target::pid_to_str): Change return type.
2584         * ravenscar-thread.c (struct ravenscar_thread_target)
2585         <pid_to_str>: Change return type.
2586         (ravenscar_thread_target::pid_to_str): Change return type.
2587         * procfs.c (class procfs_target) <pid_to_str>: Change return
2588         type.
2589         (procfs_target::pid_to_str): Change return type.
2590         (procfs_target::attach): Update.
2591         (procfs_target::detach): Update.
2592         (procfs_target::fetch_registers): Update.
2593         (procfs_target::store_registers): Update.
2594         (procfs_target::wait): Update.
2595         (procfs_target::files_info): Update.
2596         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2597         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2598         return type.
2599         (nto_procfs_target::pid_to_str): Change return type.
2600         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2601         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2602         return type.
2603         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2604         (exit_lwp): Update.
2605         (attach_proc_task_lwp_callback, get_detach_signal)
2606         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2607         (linux_nat_target::resume, wait_lwp, stop_callback)
2608         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2609         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2610         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2611         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2612         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2613         type.
2614         (inf_ptrace_target::attach): Update.
2615         (inf_ptrace_target::files_info): Update.
2616         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2617         type.
2618         (go32_nat_target::pid_to_str): Change return type.
2619         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2620         (gnu_nat_target::wait): Update.
2621         (gnu_nat_target::wait): Update.
2622         (gnu_nat_target::resume): Update.
2623         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2624         (fbsd_nat_target::wait): Update.
2625         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2626         type.
2627         (darwin_nat_target::attach): Update.
2628         * corelow.c (class core_target) <pid_to_str>: Change return type.
2629         (core_target::pid_to_str): Change return type.
2630         * target.c (normal_pid_to_str): Change return type.
2631         (default_pid_to_str): Likewise.
2632         (target_pid_to_str): Change return type.
2633         (target_translate_tls_address): Update.
2634         (target_announce_detach): Update.
2635         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2636         return type.
2637         (bsd_uthread_target::pid_to_str): Change return type.
2638         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2639         type.
2640         (bsd_kvm_target::pid_to_str): Change return type.
2641         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2642         return type.
2643         (aix_thread_target::pid_to_str): Change return type.
2644         * target.h (struct target_ops) <pid_to_str>: Change return type.
2645         (target_pid_to_str, normal_pid_to_str): Likewise.
2646         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2647         type.
2648         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2649         type.
2650         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2651         return type.
2652         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2653         type.
2654         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2655         type.
2656         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2657         return type.
2658
2659 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2660
2661         * NEWS: Mention that the new default MI version is 3.  Mention
2662         changes to the output of commands and events that deal with
2663         multi-location breakpoints.
2664         * breakpoint.c: Include "mi/mi-out.h".
2665         (print_one_breakpoint): Change output syntax if using MI version
2666         >= 3.
2667         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2668         New.
2669         (mi_multi_location_breakpoint_output_fixed): New.
2670         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2671         (mi_cmd_fix_multi_location_breakpoint_output): New.
2672         (mi_multi_location_breakpoint_output_fixed): New.
2673         * mi/mi-cmds.c (mi_cmds): Register command
2674         -fix-multi-location-breakpoint-output.
2675         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2676         interpreter "mi".
2677
2678 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2679
2680         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2681         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2682         instantiate mi_ui_out based on interpreter name.
2683         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2684         * mi/mi-main.c (mi_load_progress): Likewise.
2685
2686 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2687
2688         * NEWS: Combine separate "New targets" sections for 8.3.
2689
2690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2691
2692         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2693         (ppcfbsd_init_abi): Install gdbarch
2694         "fetch_tls_load_module_address" and "get_thread_local_address"
2695         methods.
2696
2697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2698
2699         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2700         (riscv_fbsd_init_abi): Install gdbarch
2701         "fetch_tls_load_module_address" and "get_thread_local_address"
2702         methods.
2703
2704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2705
2706         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2707         (i386fbsd_init_abi): Install gdbarch
2708         "fetch_tls_load_module_address" and "get_thread_local_address"
2709         methods.
2710
2711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2712
2713         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2714         (amd64fbsd_init_abi): Install gdbarch
2715         "fetch_tls_load_module_address" and "get_thread_local_address"
2716         methods.
2717
2718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2719
2720         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2721         (struct fbsd_pspace_data): New type.
2722         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2723         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2724         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2725         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2726         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2727
2728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2729
2730         * gdbtypes.c (lookup_struct_elt): New function.
2731         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2732         * gdbtypes.h (struct struct_elt): New type.
2733         (lookup_struct_elt): New prototype.
2734
2735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2736
2737         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2738         remove disabled code block.
2739
2740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2741
2742         * gdbarch.sh (get_thread_local_address): New method.
2743         * gdbarch.h, gdbarch.c: Regenerate.
2744         * target.c (target_translate_tls_address): Use
2745         gdbarch_get_thread_local_address if present instead of
2746         target::get_thread_local_address.
2747
2748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2749
2750         * target.h (target::get_thread_local_address): Update comment.
2751
2752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2753
2754         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2755         objfile->separate_debug_objfile_backlink if not NULL.
2756
2757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2758
2759         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2760         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2761         (amd64bsd_store_inferior_registers): Likewise.
2762         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2763         Enable segment base registers.
2764         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2765         PT_GETFSBASE and PT_GETGSBASE.
2766         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2767         PT_SETGSBASE.
2768         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2769         segment base registers.
2770         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2771
2772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2773
2774         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2775         Update calls to i386_target_description to add 'segments'
2776         parameter.
2777         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2778         add segment base registers.
2779         * arch/i386.c (i386_create_target_description): Add 'segments'
2780         parameter to enable segment base registers.
2781         * arch/i386.h (i386_create_target_description): Likewise.
2782         * features/i386/32bit-segments.xml: New file.
2783         * features/i386/32bit-segments.c: Generate.
2784         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2785         call to i386_target_description to add 'segments' parameter.
2786         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2787         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2788         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2789         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2790         if feature is present.
2791         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2792         Add 'segments' parameter to call to i386_target_description.
2793         (i386_target_description): Add 'segments' parameter to enable
2794         segment base registers.
2795         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2796         to call to i386_target_description.
2797         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2798         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2799         Define I386_NUM_REGS.
2800         (i386_target_description): Add 'segments' parameter to enable
2801         segment base registers.
2802
2803 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2804
2805         PR/24325
2806         * source-cache.c: #undef open and close, to avoid unresolved
2807         externals during linking.
2808
2809 2019-03-12  Tom Tromey  <tromey@adacore.com>
2810
2811         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2812         const.  Add initializers.
2813         (_initialize_remote): Don't initialize ptid globals.
2814
2815 2019-03-12  Pedro Alves  <palves@redhat.com>
2816
2817         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2818
2819 2019-03-12  Pedro Alves  <palves@redhat.com>
2820
2821         * cp-name-parser.y (main): Remove unused 'len' variable.
2822
2823 2019-03-12  Tom Tromey  <tromey@adacore.com>
2824
2825         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2826         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2827
2828 2019-03-12  Tom Tromey  <tromey@adacore.com>
2829
2830         * linux-nat.c (iterate_over_lwps): Update.
2831         (stop_callback): Remove parameter.
2832         (stop_wait_callback, detach_callback, resume_set_callback)
2833         (select_singlestep_lwp_callback, set_ignore_sigint)
2834         (status_callback, resumed_callback, resume_clear_callback)
2835         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2836         data parameter.
2837         (linux_nat_target::detach, linux_nat_target::resume)
2838         (linux_stop_and_wait_all_lwps, select_event_lwp)
2839         (linux_nat_filter_event, linux_nat_wait_1)
2840         (linux_nat_target::kill, linux_nat_target::stop)
2841         (linux_nat_target::stop): Update.
2842         (linux_nat_resume_callback): Change type.
2843         (resume_stopped_resumed_lwps, count_events_callback)
2844         (select_event_lwp_callback): Likewise.
2845         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2846         * arm-linux-nat.c (struct update_registers_data): Remove.
2847         (update_registers_callback): Change type.
2848         (arm_linux_insert_hw_breakpoint1): Update.
2849         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2850         parameter.
2851         (x86_linux_dr_set_addr): Update.
2852         (x86_linux_dr_set_control): Update.
2853         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2854         (iterate_over_lwps): Use gdb::function_view.
2855         * nat/aarch64-linux-hw-point.c (struct
2856         aarch64_dr_update_callback_param): Remove.
2857         (debug_reg_change_callback): Change type.
2858         (aarch64_notify_debug_reg_change): Update.
2859         * s390-linux-nat.c (s390_refresh_per_info): Update.
2860
2861 2019-03-11  Tom Tromey  <tromey@adacore.com>
2862
2863         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2864         redundant assignment to "this_cu".
2865
2866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2867
2868         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2869
2870 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2871
2872         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2873         from...
2874         (rank_one_type): ... this.
2875
2876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2877
2878         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2879         from...
2880         (rank_one_type): ... this.
2881
2882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2883
2884         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2885         from...
2886         (rank_one_type): ... this.
2887
2888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2889
2890         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2891         from...
2892         (rank_one_type): ... this.
2893
2894 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2895
2896         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2897         from...
2898         (rank_one_type): ... this.
2899
2900 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2901
2902         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2903         from...
2904         (rank_one_type): ... this.
2905
2906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2907
2908         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2909         from...
2910         (rank_one_type): ... this.
2911
2912 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2913
2914         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2915         from...
2916         (rank_one_type): ... this.
2917
2918 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2919
2920         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2921         from...
2922         (rank_one_type): ... this.
2923
2924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2925
2926         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2927         from...
2928         (rank_one_type): ... this.
2929
2930 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2931
2932         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2933         from...
2934         (rank_one_type): ... this.
2935
2936 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2937
2938         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2939         from...
2940         (rank_one_type): ... this.
2941
2942 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2943
2944         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2945         inferior-events' shows the example events.
2946
2947 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2948
2949         Support styling on native MS-Windows console
2950
2951         PR/24315
2952         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2953         on MS-Windows if $TERM is not defined.
2954
2955         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2956
2957         * posix-hdep.c (gdb_console_fputs):
2958         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2959         functions.
2960         * ui-file.h (gdb_console_fputs): Add prototype.
2961
2962         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2963         back to fputs only if the former returns zero.
2964
2965 2019-03-07  Tom Tromey  <tom@tromey.com>
2966
2967         * symmisc.c (print_symbol_bcache_statistics): Update.
2968         (print_objfile_statistics): Update.
2969         * symfile.c (allocate_symtab): Update.
2970         * stabsread.c: Don't include bcache.h.
2971         * psymtab.h (struct psymbol_bcache): Don't declare.
2972         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2973         (psymbol_bcache_init, psymbol_bcache_free)
2974         (psymbol_bcache_get_bcache): Don't declare.
2975         * psymtab.c (struct psymbol_bcache): Remove.
2976         (psymtab_storage::psymtab_storage): Update.
2977         (psymtab_storage::~psymtab_storage): Update.
2978         (psymbol_bcache_init, psymbol_bcache_free)
2979         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2980         (add_psymbol_to_bcache): Update.
2981         (allocate_psymtab): Update.
2982         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2983         macro_cache>: No longer pointers.
2984         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2985         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2986         * macrotab.c (macro_bcache): Update.
2987         * macroexp.c: Don't include bcache.h.
2988         * gdbtypes.c (check_types_worklist): Update.
2989         (types_deeply_equal): Remove TRY/CATCH.  Update.
2990         * elfread.c (elf_symtab_read): Update.
2991         * dwarf2read.c: Don't include bcache.h.
2992         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2993         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2994         (print_bcache_statistics, bcache_memory_used): Don't declare.
2995         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2996         methods.  Rename all data members.
2997         * bcache.c (struct bcache): Move to bcache.h.
2998         (bcache::expand_hash_table): Rename from expand_hash_table.
2999         (bcache): Remove.
3000         (bcache::insert): Rename from bcache_full.
3001         (bcache::compare): Rename from bcache_compare.
3002         (bcache_xmalloc): Remove.
3003         (bcache::~bcache): Rename from bcache_xfree.
3004         (bcache::print_statistics): Rename from print_bcache_statistics.
3005         (bcache::memory_used): Rename from bcache_memory_used.
3006
3007 2019-03-07  Pedro Alves  <palves@redhat.com>
3008
3009         * infrun.c (normal_stop): Also check for
3010         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3011
3012 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3013
3014         * f-lang.c (value_from_host_double): Moved to...
3015         * value.c (value_from_host_double): ...here.
3016         * value.h (value_from_host_double): Declare.
3017         * guile/scm-math.c (vlscm_convert_typed_number): Use
3018         value_from_host_double.
3019         (vlscm_convert_number): Likewise.
3020         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3021         * python/py-value.c (convert_value_from_python): Likewise.
3022
3023 2019-03-06  Tom Tromey  <tom@tromey.com>
3024
3025         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3026
3027 2019-03-06  Tom Tromey  <tom@tromey.com>
3028
3029         * utils.h (free_current_contents): Don't declare.
3030         * utils.c (free_current_contents): Remove.
3031
3032 2019-03-06  Tom Tromey  <tom@tromey.com>
3033
3034         * top.c (quit_force): Update.
3035         * main.c (captured_command_loop): Update.
3036         * common/new-op.c (operator new): Update.
3037         * common/common-exceptions.c (struct catcher)
3038         <save_cleanup_chain>: Remove member.
3039         (exceptions_state_mc_init): Update.
3040         (exception_try_scope_entry): Return nullptr.
3041         (exception_try_scope_exit, exception_rethrow)
3042         (throw_exception_sjlj, throw_exception_cxx): Update.
3043         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3044         (all_cleanups, do_cleanups, discard_cleanups)
3045         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3046         (restore_cleanups, restore_final_cleanups): Don't declare.
3047         (do_final_cleanups): Remove parameter.
3048         * common/cleanups.c (cleanup_chain, make_cleanup)
3049         (make_cleanup_dtor, all_cleanups, do_cleanups)
3050         (discard_my_cleanups, discard_cleanups)
3051         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3052         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3053         (null_cleanup): Remove.
3054         (do_final_cleanups): Remove parameter.
3055
3056 2019-03-06  Tom Tromey  <tom@tromey.com>
3057
3058         * remote.c (remote_target::remote_parse_stop_reply): Use
3059         unique_xmalloc_ptr.
3060
3061 2019-03-06  Tom Tromey  <tom@tromey.com>
3062
3063         * stabsread.c (struct stabs_field_info): Rename from field_info.
3064         <list, fnlist>: Add initializers.
3065         <obstack>: New member.
3066         (read_member_functions, read_struct_fields, read_baseclasses):
3067         Allocate on obstack.  Don't use cleanups.
3068         (read_one_struct_field, read_member_functions, read_struct_fields)
3069         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3070         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3071         (read_struct_type): Update.
3072
3073 2019-03-06  Tom Tromey  <tom@tromey.com>
3074
3075         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3076         * common/filestuff.h (make_cleanup_close): Don't declare.
3077         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3078         Remove.
3079
3080 2019-03-06  Tom Tromey  <tom@tromey.com>
3081
3082         * solib-aix.c: Use make_scope_exit.
3083
3084 2019-03-06  Tom Tromey  <tom@tromey.com>
3085
3086         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3087         Use make_scope_exit.
3088
3089 2019-03-06  Tom Tromey  <tom@tromey.com>
3090
3091         * solib-svr4.c (disable_probes_interface): Remove parameter.
3092         (svr4_handle_solib_event): Use make_scope_exit.
3093
3094 2019-03-06  Tom Tromey  <tom@tromey.com>
3095
3096         * remote.c (struct stop_reply_deleter): Remove.
3097         (stop_reply_up): Update.
3098         (struct stop_reply): Derive from notif_event.  Don't typedef.
3099         <regcache>: Now a std::vector.
3100         (stop_reply_xfree): Remove.
3101         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3102         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3103         (remote_target::discard_pending_stop_replies): Use delete.
3104         (remote_target::remote_parse_stop_reply): Update.
3105         (remote_target::process_stop_reply): Update.
3106         * remote-notif.h (struct notif_event): Add virtual destructor.
3107         Remove "dtr" member.
3108         (struct notif_client) <alloc_event>: Return a unique_ptr.
3109         (notif_event_xfree): Don't declare.
3110         (notif_event_up): New typedef.
3111         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3112         (notif_event_xfree, do_notif_event_xfree): Remove.
3113         (remote_notif_state_xfree): Update.
3114
3115 2019-03-06  Tom Tromey  <tom@tromey.com>
3116
3117         * infrun.c (displaced_step_clear_cleanup): Now a
3118         forward_scope_exit type.
3119         (displaced_step_prepare_throw): Update.
3120         (displaced_step_fixup): Update.
3121
3122 2019-03-06  Tom Tromey  <tom@tromey.com>
3123
3124         * inferior.h (class inferior): Update comment.
3125         * gdbthread.h (class thread_info): Update comment.
3126
3127 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3128             Tom Tromey  <tom@tromey.com>
3129
3130         * stabsread.h (struct stab_section_list): Remove.
3131         (coffstab_build_psymtabs): Update.
3132         * dbxread.c (symbuf_sections): Now a std::vector.
3133         (sect_idx): New global.
3134         (fill_symbuf): Update.
3135         (coffstab_build_psymtabs): Change type of stabsects parameter.
3136         Update.
3137         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3138         std::vector.
3139         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3140         (coff_locate_sections): Update.
3141         (coff_symfile_read): Remove cleanups.  Update.
3142         (init_stringtab): Add storage parameter.
3143         (free_stringtab, free_stringtab_cleanup): Remove.
3144         (init_lineno): Add storage parameter.
3145         (free_linetab, free_linetab_cleanup): Remove.
3146
3147 2019-03-06  Pedro Alves  <palves@redhat.com>
3148
3149         * linux-fork.c (fork_info::clobber_regs): Delete.
3150         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3151         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3152         comment.  Adjust.
3153         (scoped_switch_fork_info::scoped_switch_fork_info)
3154         (checkpoint_command, linux_fork_context): Adjust
3155         fork_save_infrun_state calls.
3156
3157 2019-03-06  Pedro Alves  <palves@redhat.com>
3158
3159         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3160         (inf_has_multiple_threads): Return 'bool' and rewrite using
3161         inferior_info::threads().
3162
3163 2019-03-06  Pedro Alves  <palves@redhat.com>
3164
3165         * linux-fork.c: Include <list>.
3166         (fork_list): Now a std::list instance.
3167         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3168         (forks_exist_p, find_last_fork): Adjust.
3169         (new_fork): Delete.
3170         (one_fork_p): New.
3171         (add_fork): Adjust.
3172         (free_fork): Delete, folded into fork_info::~fork_info().
3173         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3174         Adjust.
3175         (init_fork_list): Delete.
3176         (linux_fork_killall, linux_fork_mourn_inferior)
3177         (linux_fork_detach, info_checkpoints_command): Adjust.
3178         (_initialize_linux_fork): No longer call init_fork_list.
3179
3180 2019-03-06  Pedro Alves  <palves@redhat.com>
3181
3182         * linux-fork.c (new_fork): New, split out of ...
3183         (add_fork): ... this.  Return void.  Move "first fork" special
3184         case from here, to ...
3185         (checkpoint_command): ... here.
3186         * linux-linux.h (add_fork): Return void.
3187
3188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3189
3190         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3191
3192 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3193             Chris January  <chris.january@arm.com>
3194             David Lecomber  <david.lecomber@arm.com>
3195
3196         * f-exp.y: New token, UNOP_INTRINSIC.
3197         (exp): New pattern using UNOP_INTRINSIC token.
3198         (f77_keywords): Add 'abs' keyword.
3199         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3200         (value_from_host_double): New function.
3201         (evaluate_subexp_f): Support UNOP_ABS.
3202
3203 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3204
3205         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3206         types.
3207
3208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3209
3210         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3211         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3212         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3213
3214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3215
3216         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3217
3218 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3219             Chris January  <chris.january@arm.com>
3220
3221         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3222         * f-exp.y: Define 'KIND' token.
3223         (exp): New pattern for KIND expressions.
3224         (ptype): Handle types with a kind extension.
3225         (direct_abs_decl): Extend to spot kind extensions.
3226         (f77_keywords): Add 'kind' to the list.
3227         (push_kind_type): New function.
3228         (convert_to_kind_type): New function.
3229         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3230         * parse.c (operator_length_standard): Likewise.
3231         * parser-defs.h (enum type_pieces): Add tp_kind.
3232         * std-operator.def: Add UNOP_KIND.
3233
3234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3235
3236         * f-exp.y (f_parse): Set yydebug.
3237
3238 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3239
3240         * f-lang.c (evaluate_subexp_f): New function.
3241         (exp_descriptor_f): New global.
3242         (f_language_defn): Use exp_descriptor_f instead of
3243         exp_descriptor_standard.
3244
3245 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3246
3247         * f-exp.y (struct token): Add comments.
3248         (dot_ops): Remove uppercase versions and the end marker.
3249         (f77_keywords): Likewise.
3250         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3251         entries in the dot_ops array are case insensitive, and use
3252         strncasecmp to compare strings.  Also some whitespace cleanup in
3253         this area.  Similar for the f77_keywords array, except entries in
3254         this list might be case sensitive.
3255
3256 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3257
3258         * f-exp.y (struct f77_boolean_val): Add comments.
3259         (boolean_values): Remove uppercase versions, and end marker.
3260         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3261         and use strncasecmp to achieve case insensitivity.  Additionally,
3262         perform whitespace cleanup around this code.
3263
3264 2019-03-06  Tom Tromey  <tromey@adacore.com>
3265
3266         * remote-sim.c (gdbsim_target_open): Use result of
3267         gdb_argv::release.
3268
3269 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3270         Dirk Schubert  <dirk.schubert@arm.com>
3271         Chris January  <chris.january@arm.com>
3272
3273         * eval.c (evaluate_subexp_standard): Call Fortran argument
3274         wrapping logic.
3275         * f-lang.c (struct value): A value which can be passed into a
3276         Fortran function call.
3277         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3278         where appropriate.
3279         (struct type): Value ready for a Fortran function call.
3280         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3281         is needed.
3282         * f-lang.h (fortran_argument_convert): Declaration.
3283         (fortran_preserve_arg_pointer): Declaration.
3284         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3285
3286 2019-03-05  Tom Tromey  <tromey@adacore.com>
3287
3288         * python/py-prettyprint.c (print_string_repr): Remove #if.
3289         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3290
3291 2019-03-05  Tom Tromey  <tromey@adacore.com>
3292
3293         * target.c (the_dummy_target): Move later.  Change type to
3294         "dummy_target".
3295         (initialize_targets): Don't initialize the_dummy_target.
3296
3297 2019-03-05  Tom Tromey  <tromey@adacore.com>
3298
3299         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3300         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3301
3302 2019-03-05  Tom Tromey  <tromey@adacore.com>
3303
3304         * windows-nat.c (windows_nat_target::attach)
3305         (windows_nat_target::detach): Don't call gdb_flush.
3306         * valprint.c (generic_val_print, val_print, val_print_string):
3307         Don't call gdb_flush.
3308         * utils.c (defaulted_query): Don't call gdb_flush.
3309         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3310         * target.c (target_announce_detach): Don't call gdb_flush.
3311         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3312         * remote.c (extended_remote_target::attach): Don't call
3313         gdb_flush.
3314         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3315         * printcmd.c (do_examine): Don't call gdb_flush.
3316         (info_display_command): Don't call gdb_flush.
3317         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3318         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3319         * memattr.c (info_mem_command): Don't call gdb_flush.
3320         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3321         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3322         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3323         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3324         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3325         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3326         (gnu_nat_target::detach): Don't call gdb_flush.
3327         * f-valprint.c (f_val_print): Don't call gdb_flush.
3328         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3329         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3330         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3331         gdb_flush.
3332         * c-valprint.c (c_val_print): Don't call gdb_flush.
3333         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3334
3335 2019-03-05  Tom Tromey  <tromey@adacore.com>
3336
3337         * varobj.c (update_dynamic_varobj_children): Update.
3338         (install_default_visualizer): Use reset, not release.
3339         * value.c (set_internalvar): Update.
3340         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3341         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3342         ATTRIBUTE_UNUSED_RESULT.
3343
3344 2019-03-05  Tom Tromey  <tromey@adacore.com>
3345
3346         * remote.c (class scoped_remote_fd) <release>: Add
3347         ATTRIBUTE_UNUSED_RESULT.
3348
3349 2019-03-05  Tom Tromey  <tromey@adacore.com>
3350
3351         * macroexp.c (struct macro_buffer) <release>: Add
3352         ATTRIBUTE_UNUSED_RESULT.
3353
3354 2019-03-05  Tom Tromey  <tromey@adacore.com>
3355
3356         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3357         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3358         ATTRIBUTE_UNUSED_RESULT.
3359
3360 2019-03-05  Tom Tromey  <tromey@adacore.com>
3361
3362         * common/scoped_fd.h (class scoped_fd) <release>: Add
3363         ATTRIBUTE_UNUSED_RESULT.
3364
3365 2019-03-05  Tom Tromey  <tromey@adacore.com>
3366
3367         * parser-defs.h (struct parser_state) <release>: Add
3368         ATTRIBUTE_UNUSED_RESULT.
3369
3370 2019-03-05  Tom Tromey  <tromey@adacore.com>
3371
3372         * utils.h (class gdb_argv) <release>: Add
3373         ATTRIBUTE_UNUSED_RESULT.
3374         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3375
3376 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3377
3378         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3379         for-loop range, to avoid compiler warnings.
3380
3381         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3382         avoid compiler warnings about unused variables.
3383
3384         * NEWS: Mention end of support for native debugging on MS-Windows
3385         before XP.
3386
3387         PR gdb/24292
3388         * common/netstuff.c:
3389         * gdbserver/gdbreplay.c
3390         * gdbserver/remote-utils.c:
3391         * ser-tcp.c:
3392         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3393         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3394         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3395         'getaddrinfo' and 'freeaddrinfo' were not available before
3396         Windows XP, and mingw.org's MinGW headers by default define
3397         _WIN32_WINNT to 0x500.
3398
3399 2019-03-01  Gary Benson <gbenson@redhat.com>
3400
3401         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3402
3403 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3404             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3405
3406         PR gdb/8527
3407         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3408         set_sigint_trap, clear_sigint_trap.
3409
3410 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3411
3412         * target.c (target_detach): Clear the regcache and the
3413         frame cache.
3414
3415 2019-02-27  Pedro Alves  <palves@redhat.com>
3416
3417         * utils.c (set_screen_size): When we cap the height/width sizes,
3418         tweak the corresponding command variable to show "unlimited":
3419
3420 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3421             Pedro Alves  <palves@redhat.com>
3422
3423         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3424         before calling rl_set_screen_size.
3425
3426 2019-02-27  Tom Tromey  <tromey@adacore.com>
3427
3428         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3429         define.
3430         * python/py-value.c: Remove Python 2.4 workaround.
3431         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3432         workaround.
3433         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3434         Python 2.4 workaround.
3435         * python/python-internal.h: Remove Python 2.4 comment.
3436         (Py_ssize_t): Don't define.
3437         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3438         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3439         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3440         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3441         * python/python.c (do_start_initialization): Remove Python 2.4
3442         workaround.
3443         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3444         (print_children): Remove Python 2.4 workaround.
3445         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3446         workaround.
3447         (CHARBUFFERPROC_NAME): Remove.
3448         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3449         Python 2.4 workaround.
3450
3451 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3452
3453         * NEWS: Note minimum Python version.
3454
3455 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3456
3457         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3458         code from these functions.  Remove corresponding ifdefs.  Use
3459         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3460         Remove gotos and target of gotos.
3461         (infpy_search_memory): Likewise.
3462
3463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3464
3465         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3466         (hppa_gdbarch_init): Don't register deleted functions with
3467         gdbarch.
3468
3469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3470
3471         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3472         (h8300_unwind_sp): Delete.
3473         (h8300_dummy_id): Delete.
3474         (h8300_gdbarch_init): Don't register deleted functions with
3475         gdbarch.
3476
3477 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3478
3479         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3480         (ft32_unwind_pc): Delete.
3481         (ft32_unwind_sp): Delete.
3482         (ft32_gdbarch_init): Don't register deleted functions with
3483         gdbarch.
3484
3485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3486
3487         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3488         (frv_unwind_pc): Delete.
3489         (frv_unwind_sp): Delete.
3490         (frv_gdbarch_init): Don't register deleted functions with
3491         gdbarch.
3492
3493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3494
3495         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3496         (riscv_unwind_pc): Delete.
3497         (riscv_unwind_sp): Delete.
3498         (riscv_gdbarch_init): Don't register deleted functions with
3499         gdbarch.
3500
3501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3502
3503         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3504         (csky_unwind_pc): Delete.
3505         (csky_unwind_sp): Delete.
3506         (csky_gdbarch_init): Don't register deleted functions with
3507         gdbarch.
3508
3509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3510
3511         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3512         (cris_unwind_pc): Delete.
3513         (cris_unwind_sp): Delete.
3514         (cris_gdbarch_init): Don't register deleted functions with
3515         gdbarch.
3516
3517 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3518
3519         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3520         (bfin_unwind_pc): Delete.
3521         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3522
3523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3524
3525         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3526         (arm_unwind_pc): Delete.
3527         (arm_unwind_sp): Delete.
3528         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3529
3530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3531
3532         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3533         (arc_unwind_pc): Delete.
3534         (arc_unwind_sp): Delete.
3535         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3536
3537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3538
3539         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3540         (alpha_unwind_pc): Delete.
3541         (alpha_gdbarch_init): Don't register deleted functions with
3542         gdbarch.
3543
3544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3545
3546         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3547         (aarch64_unwind_pc): Delete.
3548         (aarch64_unwind_sp): Delete.
3549         (aarch64_gdbarch_init): Don't register deleted functions with
3550         gdbarch.
3551
3552 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3553
3554         * gdbtypes.c (type_align): Don't consider static members when
3555         computing structure alignment.
3556
3557 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3558
3559         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3560         return 0 for other types.
3561         * arch-utils.c (default_type_align): Always return 0.
3562         * gdbarch.h: Regenerate.
3563         * gdbarch.sh (type_align): Extend comment.
3564         * gdbtypes.c (type_align): Add additional comments, always call
3565         gdbarch_type_align before applying the default rules.
3566         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3567         generic code will then apply a suitable default.
3568         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3569         types, return 0 for other types.
3570
3571 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3572
3573         * NEWS: Create a new section for the next release branch.
3574         Rename the section of the current branch, now that it has
3575         been cut.
3576
3577 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3578
3579         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3580         * version.in: Bump version to 8.3.50.DATE-git.
3581
3582 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3583
3584         * aix-thread.c (ptid_cmp): Remove unused variable.
3585         (get_signaled_thread): Likewise.
3586         (store_regs_user_thread): Likewise.
3587         (store_regs_kernel_thread): Likewise.
3588         (fetch_regs_kernel_thread): Remove shadowed variable.
3589
3590 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3591
3592         * features/riscv/32bit-cpu.xml: Add register numbers.
3593         * features/riscv/32bit-fpu.c: Regenerate.
3594         * features/riscv/32bit-fpu.xml: Add register numbers.
3595         * features/riscv/64bit-cpu.xml: Add register numbers.
3596         * features/riscv/64bit-fpu.c: Regenerate.
3597         * features/riscv/64bit-fpu.xml: Add register numbers.
3598
3599 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3600
3601         * NEWS: Mention two argument form of gdb.Value constructor.
3602         * python/py-value.c (convert_buffer_and_type_to_value): New
3603         function.
3604         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3605         Add support for handling an optional second argument.  Call
3606         convert_buffer_and_type_to_value as appropriate.
3607         * python/python-internal.h (Py_buffer_deleter): New struct.
3608         (Py_buffer_up): New typedef.
3609
3610 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3611
3612         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3613         instead of releasing ownership.
3614
3615 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3616
3617         * dwarf2read.c (open_and_init_dwp_file): Call
3618         elf_numsections instead of bfd_count_sections to initialize
3619         dwp_file->num_sections.
3620
3621 2019-02-25  Tom Tromey  <tromey@adacore.com>
3622
3623         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3624
3625 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3626
3627         * gcore.in: Add '--readnever' option when invoking GDB.
3628
3629 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3630
3631         * MAINTAINERS: Update my email address.
3632
3633 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3634
3635         * build-id.c (build_id_to_debug_bfd_1): New function.
3636         (build_id_to_debug_bfd): Look for separate debug file in
3637         sysroot.
3638
3639 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3640
3641         * gdbarch.sh: Update the copyright year range that is placed into
3642         generated files.
3643
3644 2019-02-22  Keith Seitz  <keiths@redhat.com>
3645
3646         PR symtab/23853
3647         * linespec.c (create_sals_line_offset): Search for the default
3648         symtab's filename instead of its fullname.
3649
3650 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3651
3652         * NEWS: Update style defaults.
3653
3654 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3655
3656         * main.c (captured_main_1): Disable styling in batch mode.
3657
3658 2019-02-20  Tom Tromey  <tom@tromey.com>
3659
3660         * symtab.c (symtab_symbol_info): Fix typos.
3661
3662 2019-02-20  Tom Tromey  <tromey@adacore.com>
3663
3664         * findcmd.c (_initialize_mem_search): Use upper case for
3665         metasyntactic variables.
3666
3667 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3668
3669         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3670         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3671
3672 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3673
3674         * top.h (source_file_name): Change to std::string.
3675         * top.c (source_file_name): Likewise.
3676         (command_line_input): Adjust.
3677         * cli/cli-script.c (script_from_file): Adjust.
3678
3679 2019-02-19  Tom Tromey  <tromey@adacore.com>
3680
3681         * ravenscar-thread.c
3682         (ravenscar_thread_target::update_thread_list): Don't call
3683         ada_build_task_list.
3684         * ada-lang.h (ada_build_task_list): Don't declare.
3685         * ada-tasks.c (struct ada_tasks_inferior_data)
3686         <task_list_valid_p>: Now bool.
3687         (read_known_tasks, ada_task_list_changed)
3688         (ada_tasks_invalidate_inferior_data): Update.
3689         (read_known_tasks_array): Return bool.
3690         (read_known_tasks_list): Likewise.
3691         (read_known_tasks): Return void.
3692         (ada_build_task_list): Now static.
3693
3694 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3695
3696         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3697         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3698
3699 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3700
3701         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3702         variant for ada_tasks_pspace_data_handle and
3703         ada_tasks_inferior_data_handle.
3704         (ada_tasks_pspace_data_cleanup): New function.
3705         (ada_tasks_inferior_data_cleanup): New function.
3706
3707 2019-02-17  Tom Tromey  <tom@tromey.com>
3708
3709         * macrotab.h (macro_source_fullname): Return a std::string.
3710         * macrotab.c (macro_include, check_for_redefinition)
3711         (macro_undef, macro_lookup_definition, foreach_macro)
3712         (foreach_macro_in_scope): Update.
3713         (macro_source_fullname): Return a std::string.
3714         * macrocmd.c (show_pp_source_pos): Update.
3715
3716 2019-02-17  Tom Tromey  <tom@tromey.com>
3717
3718         * macrocmd.c (show_pp_source_pos): Style the file names.
3719
3720 2019-02-17  Tom Tromey  <tom@tromey.com>
3721
3722         PR tui/24197:
3723         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3724
3725 2019-02-17  Tom Tromey  <tom@tromey.com>
3726
3727         * ada-lang.c (user_select_syms): Use filtered printing.
3728         * utils.c (wrap_style): New global.
3729         (desired_style): Remove.
3730         (emit_style_escape): Add stream parameter.
3731         (set_output_style, reset_terminal_style, prompt_for_continue):
3732         Update.
3733         (flush_wrap_buffer): Only flush gdb_stdout.
3734         (wrap_here): Set wrap_style.
3735         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3736         treat escape sequences as a character.  Change when wrap buffer is
3737         flushed.
3738         (fputs_styled): Do not set the output style when the default is
3739         requested.
3740         * ui-style.h (struct ui_file_style) <is_default>: New method.
3741         * source.c (print_source_lines_base): Emit escape sequences in one
3742         piece.
3743
3744 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3745
3746         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3747         integers and enumeration types.
3748
3749 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3750
3751         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3752         instead of lookup_symbol_in_language
3753         (do_exact_match): New function.
3754         (ada_get_symbol_name_matcher): Return do_exact_match when
3755         doing a verbatim match.
3756
3757 2019-02-15  Tom Tromey  <tromey@adacore.com>
3758
3759         * ravenscar-thread.c (ravenscar_thread_target::resume)
3760         (ravenscar_thread_target::wait): Special case wildcard requests.
3761
3762 2019-02-15  Tom Tromey  <tromey@adacore.com>
3763
3764         * ravenscar-thread.c (base_ptid): Remove.
3765         (struct ravenscar_thread_target) <close>: New method.
3766         <m_base_ptid>: New member.
3767         <update_inferior_ptid, active_task, task_is_currently_active,
3768         runtime_initialized>: Declare methods.
3769         <ravenscar_thread_target>: Add constructor.
3770         (ravenscar_thread_target::task_is_currently_active)
3771         (ravenscar_thread_target::update_inferior_ptid)
3772         (ravenscar_runtime_initialized): Rename.  Now methods.
3773         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3774         (ravenscar_thread_target::update_thread_list): Update.
3775         (ravenscar_thread_target::active_task): Now method.
3776         (ravenscar_thread_target::store_registers)
3777         (ravenscar_thread_target::prepare_to_store)
3778         (ravenscar_thread_target::prepare_to_store)
3779         (ravenscar_thread_target::mourn_inferior): Update.
3780         (ravenscar_inferior_created): Use "new" to create target.
3781         (ravenscar_thread_target::get_ada_task_ptid): Update.
3782         (_initialize_ravenscar): Don't initialize base_ptid.
3783         (ravenscar_ops): Remove global.
3784
3785 2019-02-15  Tom Tromey  <tromey@adacore.com>
3786
3787         * target.h (push_target): Declare new overload.
3788         * target.c (push_target): New overload, taking an rvalue reference.
3789         * remote.c (remote_target::open_1): Use push_target overload.
3790         * corelow.c (core_target_open): Use push_target overload.
3791
3792 2019-02-15  Tom Tromey  <tromey@adacore.com>
3793
3794         * ravenscar-thread.c (is_ravenscar_task)
3795         (ravenscar_task_is_currently_active): Return bool.
3796         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3797         (_initialize_ravenscar): Remove "(void)".
3798         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3799         Return bool.
3800
3801 2019-02-15  Tom Tromey  <tromey@adacore.com>
3802
3803         * ravenscar-thread.c (ravenscar_runtime_initializer)
3804         (has_ravenscar_runtime, get_running_thread_id)
3805         (ravenscar_thread_target::resume): Fix indentation.
3806
3807 2019-02-15  Tom Tromey  <tromey@adacore.com>
3808
3809         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3810         from ravenscar_arch_ops.
3811         (sparc_ravenscar_ops::fetch_registers)
3812         (sparc_ravenscar_ops::store_registers): Now methods.
3813         (sparc_ravenscar_prepare_to_store): Remove.
3814         (sparc_ravenscar_ops): Redefine.
3815         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3816         methods and destructor.  Remove members.
3817         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3818         (ravenscar_thread_target::store_registers)
3819         (ravenscar_thread_target::prepare_to_store): Update.
3820         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3821         Remove.
3822         (struct ppc_ravenscar_powerpc_ops): Derive from
3823         ravenscar_arch_ops.
3824         (ppc_ravenscar_powerpc_ops::fetch_registers)
3825         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3826         (ppc_ravenscar_powerpc_ops): Redefine.
3827         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3828         (ppc_ravenscar_e500_ops::fetch_registers)
3829         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3830         (ppc_ravenscar_e500_ops): Redefine.
3831         * aarch64-ravenscar-thread.c
3832         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3833         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3834         (aarch64_ravenscar_fetch_registers)
3835         (aarch64_ravenscar_store_registers): Now methods.
3836         (aarch64_ravenscar_ops): Redefine.
3837
3838 2019-02-15  Tom Tromey  <tromey@adacore.com>
3839
3840         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3841         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3842         (ravenscar_thread_target::stopped_by_watchpoint)
3843         (ravenscar_thread_target::stopped_data_address)
3844         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3845
3846 2019-02-15  Tom Tromey  <tromey@adacore.com>
3847
3848         * ravenscar-thread.c: Fix some typos.
3849
3850 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3851             Tom Tromey  <tromey@adacore.com>
3852
3853         * ada-lang.c (ada_exception_sal): Change addr_string to a
3854         std::string.
3855         (create_ada_exception_catchpoint): Update.
3856
3857 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3858             Tom Tromey  <tromey@adacore.com>
3859
3860         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3861         (bp_location_ops): Remove.
3862         (base_breakpoint_allocate_location): Update.
3863         (free_bp_location): Update.
3864         * ada-lang.c (class ada_catchpoint_location)
3865         <ada_catchpoint_location>: Remove ops parameter.
3866         (ada_catchpoint_location_dtor): Remove.
3867         (ada_catchpoint_location_ops): Remove.
3868         (allocate_location_exception): Update.
3869         * breakpoint.h (struct bp_location_ops): Remove.
3870         (class bp_location) <bp_location>: Remove bp_location_ops
3871         parameter.
3872         <~bp_location>: Add destructor.
3873         <ops>: Remove.
3874
3875 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3876             Pedro Alves  <palves@redhat.com>
3877
3878         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3879         'PATH_MAX'.
3880
3881 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3882             Samuel Thibault  <samuel.thibault@gnu.org>
3883             Thomas Schwinge  <thomas@codesourcery.com>
3884
3885         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3886         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3887
3888 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3889
3890         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3891         (check_empty): Use "const char *".
3892
3893         * gnu-nat.c (gnu_nat_target::detach): Instead of
3894         'detach_inferior (pid)' call
3895         'detach_inferior (find_inferior_pid (pid))'.
3896
3897         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3898         'nat/fork-inferior.o'.
3899         * gnu-nat.c: #include "nat/fork-inferior.h".
3900
3901         * gnu-nat.c (gnu_nat_target::detach): Instead of
3902         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3903         * gnu-nat.h: #include "inf-child.h".
3904         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3905         'i386_gnu_nat_target::fetch_registers'.
3906         (gnu_store_registers): Rename/move to
3907         'i386_gnu_nat_target::store_registers'.
3908
3909         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3910         * gnu-nat.h (mach_thread_info): New function.
3911         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3912
3913         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3914
3915 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3916
3917         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3918
3919 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3920
3921         * windows-nat.c (windows_add_thread): Add new parameter
3922         "main_thread_p" with default value set to false.  Update
3923         function documentation as well as all callers.
3924         (windows_delete_thread): Likewise.
3925         (fake_create_process): Update call to windows_add_thread.
3926         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3927         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3928         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3929         call to windows_delete_thread.
3930
3931 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3932
3933         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3934
3935 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3936
3937         * symfile.c (find_separate_debug_file): Use canonical path of
3938         sysroot with child_path instead of gdb_sysroot if it is valid.
3939
3940 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3941
3942         * symfile.c (find_separate_debug_file): Use child_path to
3943         determine if an object file is under a sysroot.
3944
3945 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3946
3947         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3948         unittests/child-path-selftests.c.
3949         * common/pathstuff.c (child_path): New function.
3950         * common/pathstuff.h (child_path): New prototype.
3951         * unittests/child-path-selftests.c: New file.
3952
3953 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3954
3955         * symfile.c (find_separate_debug_file): Look for separate debug
3956         files in debug directories under the sysroot.
3957
3958 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3959
3960         * symtab.h (struct minimal_symbol data_p): New const method.
3961         (struct minimal_symbol text_p): Likewise.
3962         * symtab.c (output_source_filename): Use file name style
3963         to print file name.
3964         (print_symbol_info): Likewise.
3965         (print_msymbol_info): Use address style to print addresses.
3966         Use function name style to print executable text symbols.
3967         (expand_symtab_containing_pc): Use data_p.
3968         (find_pc_sect_compunit_symtab): Likewise.
3969
3970 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3971
3972         * breakpoint.c (describe_other_breakpoints): Use address style
3973         to print addresses.
3974         (say_where): Likewise.
3975
3976 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3977
3978         * ada-typeprint.c (print_func_type): Print function name
3979         style to print function name.
3980         * c-typeprint.c (c_print_type_1): Likewise.
3981
3982 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3983
3984         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3985         for execve.
3986
3987 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3988
3989         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3990         type_stack.
3991
3992 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3993
3994         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3995         TYPE_CODE_REF types.
3996
3997 2019-02-08  Jim Wilson  <jimw@sifive.com>
3998
3999         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4000         (riscv_linux_fregset): New.
4001         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4002
4003 2019-02-07  Tom Tromey  <tom@tromey.com>
4004
4005         * thread.c (thread_cancel_execution_command): Update.
4006         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4007         methods.
4008         (struct thread_fsm_ops): Remove.
4009         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4010         (thread_fsm_should_stop, thread_fsm_return_value)
4011         (thread_fsm_set_finished, thread_fsm_finished_p)
4012         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4013         Don't declare.
4014         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4015         * infrun.c (clear_proceed_status_thread)
4016         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4017         (print_stop_event): Update.
4018         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4019         Add constructor.
4020         (step_command_fsm_ops): Remove.
4021         (new_step_command_fsm): Remove.
4022         (step_1): Update.
4023         (step_command_fsm::should_stop): Rename from
4024         step_command_fsm_should_stop.
4025         (step_command_fsm::clean_up): Rename from
4026         step_command_fsm_clean_up.
4027         (step_command_fsm::do_async_reply_reason): Rename from
4028         step_command_fsm_async_reply_reason.
4029         (struct until_next_fsm): Inherit from thread_fsm.  Add
4030         constructor.
4031         (until_next_fsm_ops): Remove.
4032         (new_until_next_fsm): Remove.
4033         (until_next_fsm::should_stop): Rename from
4034         until_next_fsm_should_stop.
4035         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4036         (until_next_fsm::do_async_reply_reason): Rename from
4037         until_next_fsm_async_reply_reason.
4038         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4039         constructor.  Change type of breakpoint.
4040         (finish_command_fsm_ops): Remove.
4041         (new_finish_command_fsm): Remove.
4042         (finish_command_fsm::should_stop): Rename from
4043         finish_command_fsm_should_stop.
4044         (finish_command_fsm::clean_up): Rename from
4045         finish_command_fsm_clean_up.
4046         (finish_command_fsm::return_value): Rename from
4047         finish_command_fsm_return_value.
4048         (finish_command_fsm::do_async_reply_reason): Rename from
4049         finish_command_fsm_async_reply_reason.
4050         (finish_command): Update.
4051         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4052         Add constructor.
4053         (call_thread_fsm_ops): Remove.
4054         (call_thread_fsm::call_thread_fsm): Rename from
4055         new_call_thread_fsm.
4056         (call_thread_fsm::should_stop): Rename from
4057         call_thread_fsm_should_stop.
4058         (call_thread_fsm::should_notify_stop): Rename from
4059         call_thread_fsm_should_notify_stop.
4060         (run_inferior_call, call_function_by_hand_dummy): Update.
4061         * cli/cli-interp.c (should_print_stop_to_console): Update.
4062         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4063         Add constructor.  Change type of location_breakpoint,
4064         caller_breakpoint.
4065         (until_break_fsm_ops): Remove.
4066         (new_until_break_fsm): Remove.
4067         (until_break_fsm::should_stop): Rename from
4068         until_break_fsm_should_stop.
4069         (until_break_fsm::clean_up): Rename from
4070         until_break_fsm_clean_up.
4071         (until_break_fsm::do_async_reply_reason): Rename from
4072         until_break_fsm_async_reply_reason.
4073         (until_break_command): Update.
4074         * thread-fsm.c: Remove.
4075         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4076
4077 2019-02-07  Tom Tromey  <tom@tromey.com>
4078
4079         * yy-remap.h: Add include guard.
4080         * xtensa-tdep.h: Add include guard.
4081         * xcoffread.h: Rename include guard.
4082         * varobj-iter.h: Add include guard.
4083         * tui/tui.h: Rename include guard.
4084         * tui/tui-winsource.h: Rename include guard.
4085         * tui/tui-wingeneral.h: Rename include guard.
4086         * tui/tui-windata.h: Rename include guard.
4087         * tui/tui-win.h: Rename include guard.
4088         * tui/tui-stack.h: Rename include guard.
4089         * tui/tui-source.h: Rename include guard.
4090         * tui/tui-regs.h: Rename include guard.
4091         * tui/tui-out.h: Rename include guard.
4092         * tui/tui-layout.h: Rename include guard.
4093         * tui/tui-io.h: Rename include guard.
4094         * tui/tui-hooks.h: Rename include guard.
4095         * tui/tui-file.h: Rename include guard.
4096         * tui/tui-disasm.h: Rename include guard.
4097         * tui/tui-data.h: Rename include guard.
4098         * tui/tui-command.h: Rename include guard.
4099         * tic6x-tdep.h: Add include guard.
4100         * target/waitstatus.h: Rename include guard.
4101         * target/wait.h: Rename include guard.
4102         * target/target.h: Rename include guard.
4103         * target/resume.h: Rename include guard.
4104         * target-float.h: Rename include guard.
4105         * stabsread.h: Add include guard.
4106         * rs6000-tdep.h: Add include guard.
4107         * riscv-fbsd-tdep.h: Add include guard.
4108         * regformats/regdef.h: Rename include guard.
4109         * record.h: Rename include guard.
4110         * python/python.h: Rename include guard.
4111         * python/python-internal.h: Rename include guard.
4112         * python/py-stopevent.h: Rename include guard.
4113         * python/py-ref.h: Rename include guard.
4114         * python/py-record.h: Rename include guard.
4115         * python/py-record-full.h: Rename include guard.
4116         * python/py-record-btrace.h: Rename include guard.
4117         * python/py-instruction.h: Rename include guard.
4118         * python/py-events.h: Rename include guard.
4119         * python/py-event.h: Rename include guard.
4120         * procfs.h: Add include guard.
4121         * proc-utils.h: Add include guard.
4122         * p-lang.h: Add include guard.
4123         * or1k-tdep.h: Rename include guard.
4124         * observable.h: Rename include guard.
4125         * nto-tdep.h: Rename include guard.
4126         * nat/x86-linux.h: Rename include guard.
4127         * nat/x86-linux-dregs.h: Rename include guard.
4128         * nat/x86-gcc-cpuid.h: Add include guard.
4129         * nat/x86-dregs.h: Rename include guard.
4130         * nat/x86-cpuid.h: Rename include guard.
4131         * nat/ppc-linux.h: Rename include guard.
4132         * nat/mips-linux-watch.h: Rename include guard.
4133         * nat/linux-waitpid.h: Rename include guard.
4134         * nat/linux-ptrace.h: Rename include guard.
4135         * nat/linux-procfs.h: Rename include guard.
4136         * nat/linux-osdata.h: Rename include guard.
4137         * nat/linux-nat.h: Rename include guard.
4138         * nat/linux-namespaces.h: Rename include guard.
4139         * nat/linux-btrace.h: Rename include guard.
4140         * nat/glibc_thread_db.h: Rename include guard.
4141         * nat/gdb_thread_db.h: Rename include guard.
4142         * nat/gdb_ptrace.h: Rename include guard.
4143         * nat/fork-inferior.h: Rename include guard.
4144         * nat/amd64-linux-siginfo.h: Rename include guard.
4145         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4146         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4147         * nat/aarch64-linux.h: Rename include guard.
4148         * nat/aarch64-linux-hw-point.h: Rename include guard.
4149         * mn10300-tdep.h: Add include guard.
4150         * mips-linux-tdep.h: Add include guard.
4151         * mi/mi-parse.h: Rename include guard.
4152         * mi/mi-out.h: Rename include guard.
4153         * mi/mi-main.h: Rename include guard.
4154         * mi/mi-interp.h: Rename include guard.
4155         * mi/mi-getopt.h: Rename include guard.
4156         * mi/mi-console.h: Rename include guard.
4157         * mi/mi-common.h: Rename include guard.
4158         * mi/mi-cmds.h: Rename include guard.
4159         * mi/mi-cmd-break.h: Rename include guard.
4160         * m2-lang.h: Add include guard.
4161         * location.h: Rename include guard.
4162         * linux-record.h: Rename include guard.
4163         * linux-nat.h: Add include guard.
4164         * linux-fork.h: Add include guard.
4165         * i386-darwin-tdep.h: Rename include guard.
4166         * hppa-linux-offsets.h: Add include guard.
4167         * guile/guile.h: Rename include guard.
4168         * guile/guile-internal.h: Rename include guard.
4169         * gnu-nat.h: Rename include guard.
4170         * gdb-stabs.h: Rename include guard.
4171         * frv-tdep.h: Add include guard.
4172         * f-lang.h: Add include guard.
4173         * event-loop.h: Add include guard.
4174         * darwin-nat.h: Rename include guard.
4175         * cp-abi.h: Rename include guard.
4176         * config/sparc/nm-sol2.h: Rename include guard.
4177         * config/nm-nto.h: Rename include guard.
4178         * config/nm-linux.h: Add include guard.
4179         * config/i386/nm-i386gnu.h: Rename include guard.
4180         * config/djgpp/nl_types.h: Rename include guard.
4181         * config/djgpp/langinfo.h: Rename include guard.
4182         * compile/gcc-cp-plugin.h: Add include guard.
4183         * compile/gcc-c-plugin.h: Add include guard.
4184         * compile/compile.h: Rename include guard.
4185         * compile/compile-object-run.h: Rename include guard.
4186         * compile/compile-object-load.h: Rename include guard.
4187         * compile/compile-internal.h: Rename include guard.
4188         * compile/compile-cplus.h: Rename include guard.
4189         * compile/compile-c.h: Rename include guard.
4190         * common/xml-utils.h: Rename include guard.
4191         * common/x86-xstate.h: Rename include guard.
4192         * common/version.h: Rename include guard.
4193         * common/vec.h: Rename include guard.
4194         * common/tdesc.h: Rename include guard.
4195         * common/selftest.h: Rename include guard.
4196         * common/scoped_restore.h: Rename include guard.
4197         * common/scoped_mmap.h: Rename include guard.
4198         * common/scoped_fd.h: Rename include guard.
4199         * common/safe-iterator.h: Rename include guard.
4200         * common/run-time-clock.h: Rename include guard.
4201         * common/refcounted-object.h: Rename include guard.
4202         * common/queue.h: Rename include guard.
4203         * common/ptid.h: Rename include guard.
4204         * common/print-utils.h: Rename include guard.
4205         * common/preprocessor.h: Rename include guard.
4206         * common/pathstuff.h: Rename include guard.
4207         * common/observable.h: Rename include guard.
4208         * common/netstuff.h: Rename include guard.
4209         * common/job-control.h: Rename include guard.
4210         * common/host-defs.h: Rename include guard.
4211         * common/gdb_wait.h: Rename include guard.
4212         * common/gdb_vecs.h: Rename include guard.
4213         * common/gdb_unlinker.h: Rename include guard.
4214         * common/gdb_unique_ptr.h: Rename include guard.
4215         * common/gdb_tilde_expand.h: Rename include guard.
4216         * common/gdb_sys_time.h: Rename include guard.
4217         * common/gdb_string_view.h: Rename include guard.
4218         * common/gdb_splay_tree.h: Rename include guard.
4219         * common/gdb_setjmp.h: Rename include guard.
4220         * common/gdb_ref_ptr.h: Rename include guard.
4221         * common/gdb_optional.h: Rename include guard.
4222         * common/gdb_locale.h: Rename include guard.
4223         * common/gdb_assert.h: Rename include guard.
4224         * common/filtered-iterator.h: Rename include guard.
4225         * common/filestuff.h: Rename include guard.
4226         * common/fileio.h: Rename include guard.
4227         * common/environ.h: Rename include guard.
4228         * common/common-utils.h: Rename include guard.
4229         * common/common-types.h: Rename include guard.
4230         * common/common-regcache.h: Rename include guard.
4231         * common/common-inferior.h: Rename include guard.
4232         * common/common-gdbthread.h: Rename include guard.
4233         * common/common-exceptions.h: Rename include guard.
4234         * common/common-defs.h: Rename include guard.
4235         * common/common-debug.h: Rename include guard.
4236         * common/cleanups.h: Rename include guard.
4237         * common/buffer.h: Rename include guard.
4238         * common/btrace-common.h: Rename include guard.
4239         * common/break-common.h: Rename include guard.
4240         * cli/cli-utils.h: Rename include guard.
4241         * cli/cli-style.h: Rename include guard.
4242         * cli/cli-setshow.h: Rename include guard.
4243         * cli/cli-script.h: Rename include guard.
4244         * cli/cli-interp.h: Rename include guard.
4245         * cli/cli-decode.h: Rename include guard.
4246         * cli/cli-cmds.h: Rename include guard.
4247         * charset-list.h: Add include guard.
4248         * buildsym-legacy.h: Rename include guard.
4249         * bfin-tdep.h: Add include guard.
4250         * ax.h: Rename include guard.
4251         * arm-linux-tdep.h: Add include guard.
4252         * arm-fbsd-tdep.h: Add include guard.
4253         * arch/xtensa.h: Rename include guard.
4254         * arch/tic6x.h: Add include guard.
4255         * arch/i386.h: Add include guard.
4256         * arch/arm.h: Rename include guard.
4257         * arch/arm-linux.h: Rename include guard.
4258         * arch/arm-get-next-pcs.h: Rename include guard.
4259         * arch/amd64.h: Add include guard.
4260         * arch/aarch64-insn.h: Rename include guard.
4261         * arch-utils.h: Rename include guard.
4262         * annotate.h: Add include guard.
4263         * amd64-darwin-tdep.h: Rename include guard.
4264         * aarch64-linux-tdep.h: Add include guard.
4265         * aarch64-fbsd-tdep.h: Add include guard.
4266         * aarch32-linux-nat.h: Add include guard.
4267
4268 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4269
4270         * macrotab.c (macro_define_internal): New function that
4271         factorizes macro_define_object_internal and macro_define_function
4272         code.
4273         (macro_define_object_internal): Use macro_define_internal.
4274         (macro_define_function): Likewise.
4275
4276 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4277
4278         * macrocmd.c (extract_identifier): Return
4279         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4280         callers.
4281
4282 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4283
4284         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4285
4286 2019-02-05  Tom Tromey  <tom@tromey.com>
4287
4288         * target.c (target_stack::unpush): Move assertion earlier.
4289
4290 2019-01-30  Tom Tromey  <tom@tromey.com>
4291
4292         PR python/23615:
4293         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4294         (gdbpy_parse_and_eval): Likewise.
4295         * python/python-internal.h (gdbpy_allow_threads): New class.
4296
4297 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4298
4299         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4300         (aarch64_fbsd_fpregmap): Move earlier.
4301         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4302         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4303         instead of individual calls to trad_frame_set_reg_addr.
4304         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4305         earlier.
4306         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4307         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4308         instead of individual calls to trad_frame_set_reg_addr.
4309
4310 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4311
4312         * CONTRIBUTE: Replace contribution list with wiki link.
4313
4314 2019-01-25  Tom Tromey  <tom@tromey.com>
4315
4316         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4317
4318 2019-01-25  Tom Tromey  <tom@tromey.com>
4319
4320         * xtensa-linux-nat.c: Fix common/ includes.
4321         * xml-support.h: Fix common/ includes.
4322         * xml-support.c: Fix common/ includes.
4323         * x86-linux-nat.c: Fix common/ includes.
4324         * windows-nat.c: Fix common/ includes.
4325         * varobj.h: Fix common/ includes.
4326         * varobj.c: Fix common/ includes.
4327         * value.c: Fix common/ includes.
4328         * valops.c: Fix common/ includes.
4329         * utils.c: Fix common/ includes.
4330         * unittests/xml-utils-selftests.c: Fix common/ includes.
4331         * unittests/utils-selftests.c: Fix common/ includes.
4332         * unittests/unpack-selftests.c: Fix common/ includes.
4333         * unittests/tracepoint-selftests.c: Fix common/ includes.
4334         * unittests/style-selftests.c: Fix common/ includes.
4335         * unittests/string_view-selftests.c: Fix common/ includes.
4336         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4337         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4338         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4339         * unittests/rsp-low-selftests.c: Fix common/ includes.
4340         * unittests/parse-connection-spec-selftests.c: Fix common/
4341         includes.
4342         * unittests/optional-selftests.c: Fix common/ includes.
4343         * unittests/offset-type-selftests.c: Fix common/ includes.
4344         * unittests/observable-selftests.c: Fix common/ includes.
4345         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4346         * unittests/memrange-selftests.c: Fix common/ includes.
4347         * unittests/memory-map-selftests.c: Fix common/ includes.
4348         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4349         * unittests/function-view-selftests.c: Fix common/ includes.
4350         * unittests/environ-selftests.c: Fix common/ includes.
4351         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4352         * unittests/common-utils-selftests.c: Fix common/ includes.
4353         * unittests/cli-utils-selftests.c: Fix common/ includes.
4354         * unittests/array-view-selftests.c: Fix common/ includes.
4355         * ui-file.c: Fix common/ includes.
4356         * tui/tui-io.c: Fix common/ includes.
4357         * tracepoint.h: Fix common/ includes.
4358         * tracepoint.c: Fix common/ includes.
4359         * tracefile-tfile.c: Fix common/ includes.
4360         * top.h: Fix common/ includes.
4361         * top.c: Fix common/ includes.
4362         * thread.c: Fix common/ includes.
4363         * target/waitstatus.h: Fix common/ includes.
4364         * target/waitstatus.c: Fix common/ includes.
4365         * target.h: Fix common/ includes.
4366         * target.c: Fix common/ includes.
4367         * target-memory.c: Fix common/ includes.
4368         * target-descriptions.c: Fix common/ includes.
4369         * symtab.h: Fix common/ includes.
4370         * symfile.c: Fix common/ includes.
4371         * stap-probe.c: Fix common/ includes.
4372         * spu-linux-nat.c: Fix common/ includes.
4373         * sparc-nat.c: Fix common/ includes.
4374         * source.c: Fix common/ includes.
4375         * solib.c: Fix common/ includes.
4376         * solib-target.c: Fix common/ includes.
4377         * ser-unix.c: Fix common/ includes.
4378         * ser-tcp.c: Fix common/ includes.
4379         * ser-pipe.c: Fix common/ includes.
4380         * ser-base.c: Fix common/ includes.
4381         * selftest-arch.c: Fix common/ includes.
4382         * s12z-tdep.c: Fix common/ includes.
4383         * rust-exp.y: Fix common/ includes.
4384         * rs6000-aix-tdep.c: Fix common/ includes.
4385         * riscv-tdep.c: Fix common/ includes.
4386         * remote.c: Fix common/ includes.
4387         * remote-notif.h: Fix common/ includes.
4388         * remote-fileio.h: Fix common/ includes.
4389         * remote-fileio.c: Fix common/ includes.
4390         * regcache.h: Fix common/ includes.
4391         * regcache.c: Fix common/ includes.
4392         * record-btrace.c: Fix common/ includes.
4393         * python/python.c: Fix common/ includes.
4394         * python/py-type.c: Fix common/ includes.
4395         * python/py-inferior.c: Fix common/ includes.
4396         * progspace.h: Fix common/ includes.
4397         * producer.c: Fix common/ includes.
4398         * procfs.c: Fix common/ includes.
4399         * proc-api.c: Fix common/ includes.
4400         * printcmd.c: Fix common/ includes.
4401         * ppc-linux-nat.c: Fix common/ includes.
4402         * parser-defs.h: Fix common/ includes.
4403         * osdata.c: Fix common/ includes.
4404         * obsd-nat.c: Fix common/ includes.
4405         * nat/x86-linux.c: Fix common/ includes.
4406         * nat/x86-linux-dregs.c: Fix common/ includes.
4407         * nat/x86-dregs.h: Fix common/ includes.
4408         * nat/x86-dregs.c: Fix common/ includes.
4409         * nat/ppc-linux.c: Fix common/ includes.
4410         * nat/mips-linux-watch.h: Fix common/ includes.
4411         * nat/mips-linux-watch.c: Fix common/ includes.
4412         * nat/linux-waitpid.c: Fix common/ includes.
4413         * nat/linux-ptrace.h: Fix common/ includes.
4414         * nat/linux-ptrace.c: Fix common/ includes.
4415         * nat/linux-procfs.c: Fix common/ includes.
4416         * nat/linux-personality.c: Fix common/ includes.
4417         * nat/linux-osdata.c: Fix common/ includes.
4418         * nat/linux-namespaces.c: Fix common/ includes.
4419         * nat/linux-btrace.h: Fix common/ includes.
4420         * nat/linux-btrace.c: Fix common/ includes.
4421         * nat/fork-inferior.c: Fix common/ includes.
4422         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4423         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4424         * nat/aarch64-linux.c: Fix common/ includes.
4425         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4426         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4427         * namespace.h: Fix common/ includes.
4428         * mips-linux-tdep.c: Fix common/ includes.
4429         * minsyms.c: Fix common/ includes.
4430         * mi/mi-parse.h: Fix common/ includes.
4431         * mi/mi-main.c: Fix common/ includes.
4432         * mi/mi-cmd-env.c: Fix common/ includes.
4433         * memrange.h: Fix common/ includes.
4434         * memattr.c: Fix common/ includes.
4435         * maint.h: Fix common/ includes.
4436         * maint.c: Fix common/ includes.
4437         * main.c: Fix common/ includes.
4438         * machoread.c: Fix common/ includes.
4439         * location.c: Fix common/ includes.
4440         * linux-thread-db.c: Fix common/ includes.
4441         * linux-nat.c: Fix common/ includes.
4442         * linux-fork.c: Fix common/ includes.
4443         * inline-frame.c: Fix common/ includes.
4444         * infrun.c: Fix common/ includes.
4445         * inflow.c: Fix common/ includes.
4446         * inferior.h: Fix common/ includes.
4447         * inferior.c: Fix common/ includes.
4448         * infcmd.c: Fix common/ includes.
4449         * inf-ptrace.c: Fix common/ includes.
4450         * inf-child.c: Fix common/ includes.
4451         * ia64-linux-nat.c: Fix common/ includes.
4452         * i387-tdep.c: Fix common/ includes.
4453         * i386-tdep.c: Fix common/ includes.
4454         * i386-linux-tdep.c: Fix common/ includes.
4455         * i386-linux-nat.c: Fix common/ includes.
4456         * i386-go32-tdep.c: Fix common/ includes.
4457         * i386-fbsd-tdep.c: Fix common/ includes.
4458         * i386-fbsd-nat.c: Fix common/ includes.
4459         * guile/scm-type.c: Fix common/ includes.
4460         * guile/guile.c: Fix common/ includes.
4461         * go32-nat.c: Fix common/ includes.
4462         * gnu-nat.c: Fix common/ includes.
4463         * gdbthread.h: Fix common/ includes.
4464         * gdbarch-selftests.c: Fix common/ includes.
4465         * gdb_usleep.c: Fix common/ includes.
4466         * gdb_select.h: Fix common/ includes.
4467         * gdb_bfd.c: Fix common/ includes.
4468         * gcore.c: Fix common/ includes.
4469         * fork-child.c: Fix common/ includes.
4470         * findvar.c: Fix common/ includes.
4471         * fbsd-nat.c: Fix common/ includes.
4472         * event-top.c: Fix common/ includes.
4473         * event-loop.c: Fix common/ includes.
4474         * dwarf2read.c: Fix common/ includes.
4475         * dwarf2loc.c: Fix common/ includes.
4476         * dwarf2-frame.c: Fix common/ includes.
4477         * dwarf-index-cache.c: Fix common/ includes.
4478         * dtrace-probe.c: Fix common/ includes.
4479         * disasm-selftests.c: Fix common/ includes.
4480         * defs.h: Fix common/ includes.
4481         * csky-tdep.c: Fix common/ includes.
4482         * cp-valprint.c: Fix common/ includes.
4483         * cp-support.h: Fix common/ includes.
4484         * cp-support.c: Fix common/ includes.
4485         * corelow.c: Fix common/ includes.
4486         * completer.h: Fix common/ includes.
4487         * completer.c: Fix common/ includes.
4488         * compile/compile.c: Fix common/ includes.
4489         * compile/compile-loc2c.c: Fix common/ includes.
4490         * compile/compile-cplus-types.c: Fix common/ includes.
4491         * compile/compile-cplus-symbols.c: Fix common/ includes.
4492         * command.h: Fix common/ includes.
4493         * cli/cli-dump.c: Fix common/ includes.
4494         * cli/cli-cmds.c: Fix common/ includes.
4495         * charset.c: Fix common/ includes.
4496         * build-id.c: Fix common/ includes.
4497         * btrace.h: Fix common/ includes.
4498         * btrace.c: Fix common/ includes.
4499         * breakpoint.h: Fix common/ includes.
4500         * breakpoint.c: Fix common/ includes.
4501         * ax.h: 
4502         (enum agent_op): Fix common/ includes.
4503         * ax-general.c (struct aop_map): Fix common/ includes.
4504         * ax-gdb.c: Fix common/ includes.
4505         * auxv.c: Fix common/ includes.
4506         * auto-load.c: Fix common/ includes.
4507         * arm-tdep.c: Fix common/ includes.
4508         * arch/riscv.c: Fix common/ includes.
4509         * arch/ppc-linux-common.c: Fix common/ includes.
4510         * arch/i386.c: Fix common/ includes.
4511         * arch/arm.c: Fix common/ includes.
4512         * arch/arm-linux.c: Fix common/ includes.
4513         * arch/arm-get-next-pcs.c: Fix common/ includes.
4514         * arch/amd64.c: Fix common/ includes.
4515         * arch/aarch64.c: Fix common/ includes.
4516         * arch/aarch64-insn.c: Fix common/ includes.
4517         * arch-utils.c: Fix common/ includes.
4518         * amd64-windows-tdep.c: Fix common/ includes.
4519         * amd64-tdep.c: Fix common/ includes.
4520         * amd64-sol2-tdep.c: Fix common/ includes.
4521         * amd64-obsd-tdep.c: Fix common/ includes.
4522         * amd64-nbsd-tdep.c: Fix common/ includes.
4523         * amd64-linux-tdep.c: Fix common/ includes.
4524         * amd64-linux-nat.c: Fix common/ includes.
4525         * amd64-fbsd-tdep.c: Fix common/ includes.
4526         * amd64-fbsd-nat.c: Fix common/ includes.
4527         * amd64-dicos-tdep.c: Fix common/ includes.
4528         * amd64-darwin-tdep.c: Fix common/ includes.
4529         * agent.c: Fix common/ includes.
4530         * ada-lang.h: Fix common/ includes.
4531         * ada-lang.c: Fix common/ includes.
4532         * aarch64-tdep.c: Fix common/ includes.
4533
4534 2019-01-25  Tom Tromey  <tom@tromey.com>
4535
4536         * common/create-version.sh: Use common/version.h.
4537
4538 2019-01-24  Pedro Alves  <palves@redhat.com>
4539
4540         * infrun.c (signal_stop, signal_print, signal_program)
4541         (signal_catch, signal_pass): Now arrays instead of pointers.
4542         (update_signals_program_target, do_target_resume)
4543         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4544         * linux-nat.c (linux_nat_target::pass_signals)
4545         (linux_nat_target::create_inferior, linux_nat_target::attach):
4546         Adjust.
4547         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4548         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4549         * procfs.c (procfs_target::pass_signals): Adjust.
4550         * record-full.c (record_full_target::resume): Adjust.
4551         * remote.c (remote_target::pass_signals)
4552         (remote_target::program_signals): Adjust.
4553         * target-debug.h (target_debug_print_signals): Now takes a
4554         gdb::array_view as parameter.  Adjust.
4555         * target.h (target_ops) <pass_signals, program_signals>: Replace
4556         pointer and length parameters with gdb::array_view.
4557         (target_pass_signals, target_program_signals): Likewise.
4558         * target-delegates.c: Regenerate.
4559
4560 2019-01-24  Pedro Alves  <palves@redhat.com>
4561
4562         * common/forward-scope-exit.h
4563         (forward_scope_exit::forward_scope_exit): Pass arguments to
4564         m_bind_function directly, instead of creating a std::bind and
4565         copying that.
4566
4567 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4568
4569         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4570         for static members.
4571         (pass_in_v_vfp_candidate): Likewise.
4572
4573 2019-01-23  Tom Tromey  <tom@tromey.com>
4574             Pedro Alves  <palves@redhat.com>
4575
4576         * regcache.c (class regcache_invalidator): Remove.
4577         (regcache::raw_write): Use make_scope_exit.
4578
4579 2019-01-23  Tom Tromey  <tom@tromey.com>
4580
4581         * ui-out.h (class ui_out_emit_type): Update comment.
4582
4583 2019-01-23  Tom Tromey  <tom@tromey.com>
4584
4585         * infrun.c (fetch_inferior_event): Update comment.
4586
4587 2019-01-23  Tom Tromey  <tom@tromey.com>
4588             Pedro Alves  <palves@redhat.com>
4589
4590         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4591         parameter.
4592         (fetch_inferior_event): Use SCOPE_EXIT.
4593
4594
4595 2019-01-23  Tom Tromey  <tom@tromey.com>
4596             Pedro Alves  <palves@redhat.com>
4597
4598         * infrun.c (disable_thread_events): Delete.
4599         (stop_all_threads): Use SCOPE_EXIT.
4600
4601 2019-01-23  Tom Tromey  <tom@tromey.com>
4602             Pedro Alves  <palves@redhat.com>
4603
4604         * symfile.c: Include forward-scope-exit.h.
4605         (clear_symtab_users_cleanup): Replace forward declaration with
4606         a FORWARD_SCOPE_EXIT.
4607         (syms_from_objfile_1): Use the forward_scope_exit and
4608         gdb::optional instead of cleanup_function.
4609         (reread_symbols): Use the forward_scope_exit instead of
4610         cleanup_function.
4611         (clear_symtab_users_cleanup): Remove function.
4612
4613 2019-01-23  Tom Tromey  <tom@tromey.com>
4614             Pedro Alves  <palves@redhat.com>
4615
4616         * linux-nat.c: Include scope-exit.h.
4617         (cleanup_target_stop): Remove.
4618         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4619         SCOPE_EXIT.
4620
4621 2019-01-23  Tom Tromey  <tom@tromey.com>
4622             Pedro Alves  <palves@redhat.com>
4623
4624         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4625         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4626
4627 2019-01-23  Tom Tromey  <tom@tromey.com>
4628             Andrew Burgess  <andrew.burgess@embecosm.com>
4629             Pedro Alves  <palves@redhat.com>
4630
4631         * infrun.c (fetch_inferior_event): Use scope_exit.
4632         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4633         * top.c (execute_command): Use scope_exit.
4634         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4635         * utils.c (do_bpstat_clear_actions_cleanup)
4636         (make_bpstat_clear_actions_cleanup): Remove.
4637
4638 2019-01-23  Tom Tromey  <tom@tromey.com>
4639             Pedro Alves  <palves@redhat.com>
4640
4641         * infrun.c: Include "common/scope-exit.h"
4642         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4643         (wait_for_inferior): Use SCOPE_EXIT.
4644         (fetch_inferior_event): Use scope_exit.
4645
4646 2019-01-23  Tom Tromey  <tom@tromey.com>
4647             Pedro Alves  <palves@redhat.com>
4648
4649         * breakpoint.c (create_breakpoint): Remove cleanup.
4650
4651 2019-01-23  Tom Tromey  <tom@tromey.com>
4652             Andrew Burgess  <andrew.burgess@embecosm.com>
4653             Pedro Alves  <palves@redhat.com>
4654
4655 2019-01-23  Pedro Alves  <palves@redhat.com>
4656
4657         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4658
4659 2019-01-23  Pedro Alves  <palves@redhat.com>
4660             Andrew Burgess  <andrew.burgess@embecosm.com>
4661
4662         * gdbthread.h: Include "common/forward-scope-exit.h".
4663         (scoped_finish_thread_state): Redefine custom class in terms of
4664         forward_scope_exit.
4665
4666 2019-01-23  Pedro Alves  <palves@redhat.com>
4667             Andrew Burgess  <andrew.burgess@embecosm.com>
4668
4669         * common/forward-scope-exit.h: New file.
4670
4671 2019-01-23  Pedro Alves  <palves@redhat.com>
4672             Andrew Burgess  <andrew.burgess@embecosm.com>
4673             Tom Tromey  <tom@tromey.com>
4674
4675         * common/scope-exit.h: New file.
4676
4677 2019-01-23  Pedro Alves  <palves@redhat.com>
4678
4679         * common/preprocessor.h (ESC): Rename to ...
4680         (ESC_PARENS): ... this.
4681         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4682         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4683
4684 2019-01-23  Tom Tromey  <tom@tromey.com>
4685
4686         * language.h (class scoped_switch_to_sym_language_if_auto):
4687         Initialize m_lang in both cases.
4688
4689 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4690
4691         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4692         with XCNEW.
4693
4694 2019-01-22  Tom Tromey  <tom@tromey.com>
4695
4696         * corelow.c: Do not include sys/file.h.
4697
4698 2019-01-22  Tom Tromey  <tom@tromey.com>
4699
4700         * tui/tui-wingeneral.h: Include gdb_curses.h.
4701
4702 2019-01-22  Tom Tromey  <tom@tromey.com>
4703
4704         * source-cache.h (class source_cache) <get_source_lines,
4705         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4706
4707 2019-01-22  Tom Tromey  <tom@tromey.com>
4708
4709         * remote-fileio.h (struct remote_target): Declare.
4710
4711 2019-01-22  Tom Tromey  <tom@tromey.com>
4712
4713         * python/py-arch.c: Do not include py-ref.h.
4714         * python/py-bpevent.c: Do not include py-ref.h.
4715         * python/py-cmd.c: Do not include py-ref.h.
4716         * python/py-continueevent.c: Do not include py-ref.h.
4717         * python/py-event.h: Do not include py-ref.h.
4718         * python/py-evtregistry.c: Do not include py-ref.h.
4719         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4720         * python/py-frame.c: Do not include py-ref.h.
4721         * python/py-framefilter.c: Do not include py-ref.h.
4722         * python/py-function.c: Do not include py-ref.h.
4723         * python/py-infevents.c: Do not include py-ref.h.
4724         * python/py-linetable.c: Do not include py-ref.h.
4725         * python/py-objfile.c: Do not include py-ref.h.
4726         * python/py-param.c: Do not include py-ref.h.
4727         * python/py-prettyprint.c: Do not include py-ref.h.
4728         * python/py-progspace.c: Do not include py-ref.h.
4729         * python/py-symbol.c: Do not include py-ref.h.
4730         * python/py-symtab.c: Do not include py-ref.h.
4731         * python/py-type.c: Do not include py-ref.h.
4732         * python/py-unwind.c: Do not include py-ref.h.
4733         * python/py-utils.c: Do not include py-ref.h.
4734         * python/py-value.c: Do not include py-ref.h.
4735         * python/py-varobj.c: Do not include py-ref.h.
4736         * python/py-xmethods.c: Do not include py-ref.h.
4737         * python/python.c: Do not include py-ref.h.
4738         * varobj.c: Do not include py-ref.h.
4739
4740 2019-01-22  Tom Tromey  <tom@tromey.com>
4741
4742         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4743         keyword for bcache.
4744
4745 2019-01-22  Tom Tromey  <tom@tromey.com>
4746
4747         * compile/compile-cplus-types.c: Remove a comment by #include.
4748
4749 2019-01-22  Tom Tromey  <tom@tromey.com>
4750
4751         * compile/gcc-c-plugin.h: Include compile-internal.h.
4752
4753 2019-01-22  Tom Tromey  <tom@tromey.com>
4754
4755         * stabsread.c (EXTERN): Do not define.
4756         (symnum, next_symbol_text_func, processing_gcc_compilation)
4757         (within_function, global_sym_chain, global_stabs)
4758         (previous_stab_code, this_object_header_files)
4759         (n_this_object_header_files)
4760         (n_allocated_this_object_header_files): Define.
4761         * stabsread.h (EXTERN): Never define.  Use "extern".
4762
4763 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4764
4765         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4766         history_value.
4767
4768 2019-01-21  Tom Tromey  <tom@tromey.com>
4769
4770         * ui-out.c: Fix includes.
4771         * tui/tui-source.c: Fix includes.
4772         * target.c: Fix includes.
4773         * remote.c: Fix includes.
4774         * regcache.c: Fix includes.
4775         * python/py-block.c: Fix includes.
4776         * printcmd.c: Fix includes.
4777         * or1k-tdep.c: Fix includes.
4778         * mi/mi-main.c: Fix includes.
4779         * m32r-tdep.c: Fix includes.
4780         * csky-tdep.c: Fix includes.
4781         * compile/compile-cplus-types.c: Fix includes.
4782         * cli/cli-interp.c: Fix includes.
4783
4784 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4785
4786         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4787         for padding.
4788
4789 2019-01-16  Tom Tromey  <tom@tromey.com>
4790
4791         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4792         earlier.
4793         (struct objfile) <msymbols_range>: Move from top level.
4794         <msymbols>: New method.
4795         (class objfile_msymbols): Remove.
4796         * symtab.c (default_collect_symbol_completion_matches_break_on):
4797         Update.
4798         * symmisc.c (dump_msymbols): Update.
4799         * stabsread.c (scan_file_globals): Update.
4800         * objc-lang.c (info_selectors_command, info_classes_command)
4801         (find_methods): Update.
4802         * minsyms.c (find_solib_trampoline_target): Update.
4803         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4804         * coffread.c (coff_symfile_read): Update.
4805         * ada-lang.c (ada_lookup_simple_minsym)
4806         (ada_collect_symbol_completion_matches): Update.
4807
4808 2019-01-16  Tom Tromey  <tom@tromey.com>
4809
4810         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4811         type.  Remove no-argument constructor.
4812         <iterator::operator++>: Simplify.
4813         <begin>: Update.
4814         <end>: Use minimal_symbol_count.
4815
4816 2019-01-16  Tom Tromey  <tom@tromey.com>
4817
4818         * objfiles.h (struct objfile) <psymtabs>: New method.
4819         (class objfile_psymtabs): Remove.
4820         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4821         typedef.
4822         <range>: New method.
4823         (require_partial_symbols): Change return type.
4824         * psymtab.c (require_partial_symbols)
4825         (psym_expand_symtabs_matching): Update.
4826         * mdebugread.c (parse_partial_symbols): Update.
4827         * dbxread.c (dbx_end_psymtab): Update.
4828
4829 2019-01-15  Tom Tromey  <tom@tromey.com>
4830
4831         * symtab.c (lookup_objfile_from_block)
4832         (lookup_symbol_in_objfile_symtabs)
4833         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4834         (find_line_symtab, info_sources_command)
4835         (default_collect_symbol_completion_matches_break_on)
4836         (make_source_files_completion_list): Update.
4837         * symmisc.c (print_objfile_statistics, dump_objfile)
4838         (maintenance_print_symbols, maintenance_info_symtabs)
4839         (maintenance_check_symtabs, maintenance_info_line_tables):
4840         Update.
4841         * source.c (select_source_symtab)
4842         (forget_cached_source_info_for_objfile): Update.
4843         * objfiles.h (class objfile_compunits): Remove.
4844         (struct objfile) <compunits_range>: New typedef.
4845         (compunits): New method.
4846         * objfiles.c (objfile_relocate1): Update.
4847         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4848         * maint.c (count_symtabs_and_blocks): Update.
4849         * linespec.c (iterate_over_all_matching_symtabs): Update.
4850         * cp-support.c (add_symbol_overload_list_qualified): Update.
4851         * coffread.c (coff_symtab_read): Update.
4852         * ada-lang.c (add_nonlocal_symbols)
4853         (ada_collect_symbol_completion_matches)
4854         (ada_add_global_exceptions): Update.
4855
4856 2019-01-15  Tom Tromey  <tom@tromey.com>
4857
4858         * progspace.h (program_space) <objfiles_safe_range>: New
4859         typedef.
4860         <objfiles_safe>: New method.
4861         * objfiles.h (class all_objfiles_safe): Remove.
4862         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4863         * jit.c (jit_inferior_exit_hook): Update.
4864
4865 2019-01-17  Tom Tromey  <tom@tromey.com>
4866
4867         * progspace.h (program_space) <objfiles_range>: New typedef.
4868         <objfiles>: New method.
4869         <objfiles_head>: Rename from objfiles.
4870         (object_files): Update.
4871         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4872         * guile/scm-pretty-print.c
4873         (ppscm_find_pretty_printer_from_objfiles): Update.
4874         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4875         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4876         Update.
4877         * python/py-progspace.c (pspy_get_objfiles): Update.
4878         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4879         Update.
4880         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4881         (objfpy_lookup_objfile_by_build_id): Update.
4882         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4883         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4884         Update.
4885         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4886         (expand_symtab_containing_pc, lookup_objfile_from_block)
4887         (lookup_static_symbol, basic_lookup_transparent_type)
4888         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4889         (find_line_symtab, info_sources_command)
4890         (default_collect_symbol_completion_matches_break_on)
4891         (make_source_files_completion_list, find_main_name): Update.
4892         * symmisc.c (print_symbol_bcache_statistics)
4893         (print_objfile_statistics, maintenance_print_symbols)
4894         (maintenance_print_msymbols, maintenance_print_objfiles)
4895         (maintenance_info_symtabs, maintenance_check_symtabs)
4896         (maintenance_expand_symtabs, maintenance_info_line_tables):
4897         Update.
4898         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4899         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4900         (map_overlay_command, unmap_overlay_command)
4901         (simple_overlay_update, expand_symtabs_matching)
4902         (map_symbol_filenames): Update.
4903         * symfile-debug.c (set_debug_symfile): Update.
4904         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4905         Update.
4906         * source.c (select_source_symtab, forget_cached_source_info):
4907         Update.
4908         * solib.c (solib_read_symbols): Update.
4909         * solib-spu.c (append_ocl_sos): Update.
4910         * psymtab.c (maintenance_print_psymbols)
4911         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4912         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4913         * printcmd.c (info_symbol_command): Update.
4914         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4915         Update.
4916         * objfiles.h (class all_objfiles): Remove.
4917         * objfiles.c (have_partial_symbols, have_full_symbols)
4918         (have_minimal_symbols, qsort_cmp, update_section_map)
4919         (shared_objfile_contains_address_p)
4920         (default_iterate_over_objfiles_in_search_order): Update.
4921         * objc-lang.c (info_selectors_command, info_classes_command)
4922         (find_methods): Update.
4923         * minsyms.c (find_solib_trampoline_target): Update.
4924         * maint.c (maintenance_info_sections)
4925         (maintenance_translate_address, count_symtabs_and_blocks):
4926         Update.
4927         * main.c (captured_main_1): Update.
4928         * linux-thread-db.c (try_thread_db_load_from_pdir)
4929         (has_libpthread): Update.
4930         * linespec.c (iterate_over_all_matching_symtabs)
4931         (search_minsyms_for_name): Update.
4932         * jit.c (jit_find_objf_with_entry_addr): Update.
4933         * hppa-tdep.c (find_unwind_entry)
4934         (hppa_lookup_stub_minimal_symbol): Update.
4935         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4936         Update.
4937         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4938         (elf_gnu_ifunc_resolve_by_got): Update.
4939         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4940         * dwarf-index-write.c (save_gdb_index_command): Update.
4941         * cp-support.c (add_symbol_overload_list_qualified): Update.
4942         * breakpoint.c (create_overlay_event_breakpoint)
4943         (create_longjmp_master_breakpoint)
4944         (create_std_terminate_master_breakpoint)
4945         (create_exception_master_breakpoint): Update.
4946         * blockframe.c (find_pc_partial_function): Update.
4947         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4948         (ada_collect_symbol_completion_matches)
4949         (ada_add_global_exceptions): Update.
4950
4951 2019-01-17  Tom Tromey  <tom@tromey.com>
4952
4953         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4954         declare VEC.
4955         (solib_target_parse_libraries): Change return type.
4956         (library_list_start_segment, library_list_start_section)
4957         (library_list_end_library, library_list_start_library); Update.
4958         (solib_target_free_library_list): Remove.
4959         (solib_target_parse_libraries): Remove cleanup.  Change return
4960         type.
4961         (solib_target_current_sos): Update.
4962
4963 2019-01-17  Tom Tromey  <tromey@bapiya>
4964
4965         * valprint.c: Replace "the the" with "the".
4966         * symtab.c: Replace "the the" with "the".
4967         * solib.c: Replace "the the" with "the".
4968         * solib-dsbt.c: Replace "the the" with "the".
4969         * linespec.c: Replace "the the" with "the".
4970         * dwarf2loc.h: Replace "the the" with "the".
4971         * amd64-windows-tdep.c: Replace "the the" with "the".
4972         * aarch64-tdep.c: Replace "the the" with "the".
4973
4974 2019-01-16  Keith Seitz  <keiths@redhat.com>
4975
4976         PR gdb/23773
4977         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4978         <builder>: Rename to ..
4979         <m_builder>: ... this and make private.
4980         (dwarf2_cu::get_builder): New method.  Change all users of
4981         `builder' to use this method.
4982         (dwarf2_start_symtab): Move to ...
4983         (dwarf2_cu::start_symtab): ... here.  Update all callers
4984         (setup_type_unit_groups): Move to ...
4985         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4986         callers.
4987         (dwarf2_cu::reset_builder): New method.
4988         (process_full_compunit, process_full_type_unit): Use
4989         dwarf2_cu::reset_builder.
4990         (follow_die_offset): Record the ancestor CU if it is different
4991         from the followed DIE's CU.
4992         (follow_die_sig_1): Likewise.
4993
4994 2019-01-15  Tom Tromey  <tom@tromey.com>
4995
4996         * remote.c (class remote_state) <buf>: Now a char_vector.
4997         <buf_size>: Remove.
4998         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4999         parameter.
5000         (remote_target::getpkt_or_notif_sane_1)
5001         (remote_target::getpkt_sane)
5002         (remote_target::getpkt_or_notif_sane): Likewise.
5003         (class remote_target) <putpkt>: New overload.
5004         (remote_target::read_frame): Change type of "buf_p".  Remove
5005         sizeof_p parameter.
5006         (packet_ok): New overload.
5007         (packet_check_result): New overload.
5008         Update all uses.
5009
5010 2019-01-14  Tom Tromey  <tom@tromey.com>
5011
5012         * remote-notif.c (handle_notification, remote_notif_ack)
5013         (remote_notif_parse): Make "buf" const.
5014         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5015         const.
5016         (remote_notif_parse, remote_notif_ack, handle_notification):
5017         Likewise.
5018         * remote.c (remote_notif_stop_parse): Make "buf" const.
5019         (remote_target::remote_parse_stop_reply): Make "buf" const.
5020         (remote_notif_stop_ack): Make "buf" const.
5021
5022 2019-01-14  Tom Tromey  <tom@tromey.com>
5023
5024         * remote.c (remote_console_output): Make parameter const.
5025
5026 2019-01-14  Tom Tromey  <tom@tromey.com>
5027
5028         * target-debug.h (target_debug_print_signals): Constify.
5029         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5030         * procfs.c (procfs_target::pass_signals): Update.
5031         * linux-nat.c (linux_nat_target::pass_signals): Update.
5032         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5033         * target-delegates.c: Rebuild.
5034         * remote.c (remote_target::program_signals): Update.
5035         (remote_target::pass_signals): Update.
5036         * target.c (target_pass_signals): Constify argument.
5037         (target_program_signals): Likewise.
5038         * target.h (struct target_ops) <pass_signals, program_signals>:
5039         Constify argument.
5040         (target_pass_signals, target_program_signals): Constify argument.
5041
5042 2019-01-14  Tom Tromey  <tom@tromey.com>
5043
5044         PR tui/28819:
5045         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5046
5047 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5048
5049         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5050         field.
5051         * rs6000-tdep.c: Include reggroups.h.
5052         (IS_V_ALIAS_PSEUDOREG): Define.
5053         (rs6000_register_name): Return names for the "vX" aliases.
5054         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5055         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5056         aliases.  Call default_register_reggroup_p for all other
5057         pseudo-registers.
5058         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5059         New functions.
5060         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5061         Handle "vX" aliases.
5062         (v_alias_pseudo_register_collect): New function.
5063         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5064         (rs6000_gdbarch_init): Initialize "vX" aliases as
5065         pseudo-registers.  Restore registration of
5066         rs6000_pseudo_register_reggroup_p with
5067         set_tdesc_pseudo_register_reggroup_p.
5068
5069 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5070
5071         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5072         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5073         set_gdbarch_num_pseudo_regs.
5074
5075 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5076
5077         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5078         Remove arg prefixname, add do_set and do_show.
5079         Add member functions set_list and show_list.
5080         * cli/cli-style.c (class cli_style_option): Update accordingly.
5081         (style_set_list): Move to file scope.
5082         (style_show_list): Likewise.
5083         (set_style): Call help_list.
5084         (show_style): Call cmd_show_list.
5085         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5086         Update to use the new macro.
5087
5088 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5089
5090         * ada-lang.c (_initialize_ada_language): Expand the help text
5091         for the "catch exception" command.
5092
5093 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5094
5095         * symtab.c (matching_obj_sections): Initialize obj,
5096         declare it closer to its usage.
5097
5098 2019-01-10  Tom Tromey  <tom@tromey.com>
5099
5100         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5101         (basic_inf_threads_range): Remove.
5102         (inf_threads_range, inf_non_exited_threads_range)
5103         (safe_inf_threads_range): Use next_adapter.
5104
5105 2019-01-10  Keith Seitz  <keiths@redhat.com>
5106
5107         PR gdb/23712
5108         PR symtab/23010
5109         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5110         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5111
5112 2019-01-10  Keith Seitz  <keiths@redhat.com>
5113
5114         PR gdb/23712
5115         PR symtab/23010
5116         * dictionary.c (pending_to_vector): Remove.
5117         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5118         Remove _1 suffix, replacing functions of the same name.  Update
5119         all callers.
5120         (dict_create_hashed, dict_create_hashed_expandable)
5121         (dict_create_linear, dict_create_linear_expandable, dict_free)
5122         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5123         Make functions static.
5124
5125 2019-01-10  Keith Seitz  <keiths@redhat.com>
5126
5127         PR gdb/23712
5128         PR symtab/23010
5129         * dictionary.h (struct dictionary): Replace declaration with
5130         multidictionary.
5131         (dict_create_hashed, dict_create_hashed_expandable)
5132         (dict_create_linear, dict_create_linear_expandable)
5133         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5134         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5135         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5136         taking multidictionary argument.
5137         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5138         * block.h (struct block) <dict>: Change to multidictionary
5139         and rename `multidict'.
5140         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5141         symmisc.c: Update all dictionary references to multidictionary.
5142
5143 2019-01-10  Keith Seitz  <keiths@redhat.com>
5144
5145         PR gdb/23712
5146         PR symtab/23010
5147         * dictionary.c: Include unordered_map.
5148         (pending_to_vector): New function.
5149         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5150         Rewrite the non-"_1" functions to take vector instead
5151         of linked list.
5152         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5153         "new" _1 versions of the same name.
5154         (multidictionary): Define.
5155         (std::hash<enum language): New definition.
5156         (collate_pending_symbols_by_language, mdict_create_hashed)
5157         (mdict_create_hashed_expandable, mdict_create_linear)
5158         (mdict_create_linear_expandable, mdict_free)
5159         (find_language_dictionary, create_new_language_dictionary)
5160         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5161         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5162         (mdict_size, mdict_empty): New functions.
5163         * dictionary.h (mdict_iterator): Define.
5164
5165 2019-01-10  Pedro Alves  <palves@redhat.com>
5166
5167         * breakpoint.c (read_uploaded_action)
5168         (create_tracepoint_from_upload): Adjust to use
5169         gdb::unique_xmalloc_ptr.
5170         * ctf.c (ctf_write_uploaded_tp):
5171         (SET_ARRAY_FIELD): Use emplace_back.
5172         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5173         * tracefile-tfile.c (tfile_write_uploaded_tp):
5174         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5175         gdb::unique_xmalloc_ptr.
5176         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5177         at_string, cond_string, cmd_strings>: Replace char pointers
5178         with gdb::unique_xmalloc_ptr.
5179
5180 2019-01-10  Pedro Alves  <palves@redhat.com>
5181
5182         * solib-target.c (library_list_start_library): Don't xstrdup name.
5183
5184 2019-01-10  Pedro Alves  <palves@redhat.com>
5185
5186         * mdebugread.c (parse_partial_symbols): Use
5187         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5188
5189 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5190
5191         * linux-fork.c (scoped_switch_fork_info)
5192         <~scoped_switch_fork_info>: Fix incorrect variable name.
5193
5194 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5195
5196         * linux-fork.c (scoped_switch_fork_info)
5197         <scoped_switch_fork_info>: Make explicit.
5198         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5199
5200 2019-01-10  Tom Tromey  <tom@tromey.com>
5201
5202         * objfiles.h (objfile::reset_psymtabs): Update.
5203         * objfiles.c (objfile::objfile): Update.
5204         * psymtab.h (psymtab_storage::obstack): Update.
5205         (psymtab_storage::m_obstack): Use gdb::optional.
5206         (class psymtab_storage): Update comment.  Remove objfile
5207         parameter.
5208         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5209
5210 2019-01-10  Tom Tromey  <tom@tromey.com>
5211
5212         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5213         <free_psymtabs>: Now private.
5214         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5215         (allocate_psymtab): Use new method.
5216
5217 2019-01-10  Tom Tromey  <tom@tromey.com>
5218
5219         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5220         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5221         * mdebugread.c (parse_partial_symbols): Use
5222         allocate_dependencies.
5223         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5224         allocate_dependencies.
5225         (process_psymtab_comp_unit_reader)
5226         (build_type_psymtab_dependencies): Likewise.
5227         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5228
5229 2019-01-10  Tom Tromey  <tom@tromey.com>
5230
5231         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5232         PSYMBOL_SET_LANGUAGE.
5233         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5234
5235 2019-01-10  Tom Tromey  <tom@tromey.com>
5236
5237         * psymtab.h (psymtab_storage::obstack): New method.
5238         <m_obstack>: Rename from obstack; now private.
5239         * psymtab.c (psymtab_storage): Update.
5240         * dwarf2read.c (create_addrmap_from_index)
5241         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5242         Update.
5243
5244 2019-01-10  Tom Tromey  <tom@tromey.com>
5245
5246         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5247         * objfiles.h (objfile::reset_psymtabs): New method.
5248
5249 2019-01-10  Tom Tromey  <tom@tromey.com>
5250
5251         * symmisc.c (print_symbol_bcache_statistics): Update.
5252         (print_objfile_statistics): Update.
5253         * symfile.c (reread_symbols): Update.
5254         * psymtab.h (class psymtab_storage): New.
5255         * psymtab.c (psymtab_storage): New constructor.
5256         (~psymtab_storage): New destructor.
5257         (require_partial_symbols): Update.
5258         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5259         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5260         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5261         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5262         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5263         (start_psymtab_common, end_psymtab_common)
5264         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5265         (allocate_psymtab): Update.
5266         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5267         Update.
5268         (dump_psymtab_addrmap, maintenance_print_psymbols)
5269         (maintenance_check_psymtabs): Update.
5270         (class objfile_psymtabs): Move to objfiles.h.
5271         * psympriv.h (discard_psymtab): Now inline.
5272         (psymtab_discarder::psymtab_discarder): Update.
5273         (psymtab_discarder::~psymtab_discarder): Update.
5274         (ALL_OBJFILE_PSYMTABS): Rewrite.
5275         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5276         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5277         Remove fields.
5278         <partial_symtabs>: New field.
5279         (class objfile_psymtabs): Move from psymtab.h.  Update.
5280         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5281         psymbol_cache.
5282         (objfile::~objfile): Don't destroy psymbol_cache.
5283         * mdebugread.c (parse_partial_symbols): Update.
5284         * dwarf2read.c (create_addrmap_from_index)
5285         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5286         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5287         (add_partial_subprogram, dwarf2_ranges_read): Update.
5288         * dwarf-index-write.c (write_address_map)
5289         (write_one_signatured_type, recursively_write_psymbols)
5290         (class debug_names, class debug_names, write_psymtabs_to_index):
5291         Update.
5292
5293 2019-01-10  Tom Tromey  <tom@tromey.com>
5294
5295         * symtab.h (SYMBOL_SET_NAMES): Update.
5296         (symbol_set_names): Update.
5297         (MSYMBOL_SET_NAMES): Update.
5298         * symtab.c (symbol_set_names): Change argument to be an
5299         objfile_per_bfd_storage.
5300         * psymtab.c (add_psymbol_to_bcache): Update.
5301         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5302
5303 2019-01-10  Tom Tromey  <tom@tromey.com>
5304
5305         * symtab.c (create_demangled_names_hash): Change argument to be an
5306         objfile_per_bfd_storage.
5307         (symbol_set_names): Update.
5308
5309 2019-01-10  Tom Tromey  <tom@tromey.com>
5310
5311         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5312         init_psymbol_list.
5313         * psymtab.c (init_psymbol_list): Do nothing if already called.
5314         * psympriv.h (init_psymbol_list): Add comment.
5315         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5316         init_psymbol_list.
5317         * dbxread.c (dbx_symfile_read): Unconditionally call
5318         init_psymbol_list.
5319
5320 2019-01-10  Tom Tromey  <tom@tromey.com>
5321
5322         * xcoffread.c (scan_xcoff_symtab): Update.
5323         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5324         "where".
5325         * mdebugread.c (parse_partial_symbols)
5326         (handle_psymbol_enumerators): Update.
5327         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5328         * dbxread.c (read_dbx_symtab): Update.
5329         * psympriv.h (psymbol_placement): New enum.
5330         (add_psymbol_to_list): Update.
5331
5332 2019-01-10  Tom Tromey  <tom@tromey.com>
5333
5334         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5335         static_psymbols parameters.
5336         (scan_xcoff_symtab): Update.
5337         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5338         static_psymbols parameters.
5339         * psympriv.h (start_psymtab_common): Update.
5340         * mdebugread.c (parse_partial_symbols): Update.
5341         * dwarf2read.c (create_partial_symtab): Update.
5342         * dbxread.c (read_dbx_symtab): Update.
5343         (start_psymtab): Remove global_psymbols and static_psymbols
5344         parameters.
5345
5346 2019-01-10  Tom Tromey  <tom@tromey.com>
5347
5348         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5349         * psymtab.c (allocate_psymtab): Add comment.
5350         * psympriv.h (allocate_psymtab): Add comment.
5351         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5352         initializations.
5353         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5354
5355 2019-01-10  Tom Tromey  <tom@tromey.com>
5356
5357         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5358         Don't declare.
5359         * mipsread.c: Include mdebugread.h.
5360         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5361         Declare.
5362         * elfread.c: Include mdebugread.h.
5363
5364 2019-01-09  Tom Tromey  <tom@tromey.com>
5365
5366         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5367         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5368         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5369         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5370         (psym_lookup_symbol, psym_find_last_source_symtab)
5371         (psym_forget_cached_source_info, psym_print_stats)
5372         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5373         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5374         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5375         (psym_find_compunit_symtab_by_address)
5376         (maintenance_print_psymbols, maintenance_info_psymtabs)
5377         (maintenance_check_psymtabs): Use ranged for.
5378         * psymtab.h (class objfile_psymtabs): New.
5379         (require_partial_symbols): Return objfile_psymtabs.
5380         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5381
5382 2019-01-09  Tom Tromey  <tom@tromey.com>
5383
5384         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5385         (find_pc_mapped_section, list_overlays_command)
5386         (map_overlay_command, unmap_overlay_command)
5387         (simple_overlay_update): Use all_objfiles.
5388         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5389         * printcmd.c (info_symbol_command): Use all_objfiles.
5390         * objfiles.h (ALL_OBJSECTIONS): Remove.
5391         * maint.c (maintenance_translate_address): Use all_objfiles.
5392         * gcore.c (gcore_create_callback): Use all_objfiles.
5393         (objfile_find_memory_regions): Likewise.
5394
5395 2019-01-09  Tom Tromey  <tom@tromey.com>
5396
5397         * symtab.c (find_line_symtab, info_sources_command)
5398         (make_source_files_completion_list): Use objfile_compunits.
5399         * source.c (select_source_symtab): Use objfile_compunits.
5400         * objfiles.h (struct objfile): Update comment.
5401         (ALL_OBJFILES): Remove.
5402         (ALL_FILETABS): Remove.
5403         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5404         objfile_compunits.
5405
5406 2019-01-09  Tom Tromey  <tom@tromey.com>
5407
5408         * symmisc.c (print_objfile_statistics, dump_objfile)
5409         (maintenance_print_symbols): Use compunit_filetabs.
5410         * source.c (forget_cached_source_info_for_objfile): Use
5411         compunit_filetabs.
5412         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5413         (ALL_FILETABS): Use compunit_filetabs.
5414         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5415         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5416
5417 2019-01-09  Tom Tromey  <tom@tromey.com>
5418
5419         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5420         (compunit_filetabs): New.
5421         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5422         compunit_filetabs.
5423         (info_sources_command, make_source_files_completion_list): Remove
5424         declaration.
5425         * symmisc.c (print_objfile_statistics, dump_objfile)
5426         (maintenance_print_symbols): Remove declaration.
5427         (maintenance_info_symtabs): Use compunit_filetabs.
5428         (maintenance_info_line_tables): Likewise.
5429         * source.c (select_source_symtab): Change local variable name.
5430         (forget_cached_source_info_for_objfile): Remove declaration.
5431         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5432         * objfiles.c (objfile_relocate1): Remove declaration.
5433         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5434         declaration.
5435         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5436         * coffread.c (coff_symtab_read): Remove declaration.
5437         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5438         compunit_filetabs.
5439
5440 2019-01-09  Tom Tromey  <tom@tromey.com>
5441
5442         * symtab.c (lookup_objfile_from_block)
5443         (find_pc_sect_compunit_symtab, search_symbols)
5444         (default_collect_symbol_completion_matches_break_on): Use
5445         objfile_compunits.
5446         * objfiles.h (ALL_COMPUNITS): Remove.
5447         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5448         * cp-support.c (add_symbol_overload_list_qualified): Use
5449         objfile_compunits.
5450         * ada-lang.c (ada_collect_symbol_completion_matches)
5451         (ada_add_global_exceptions): Use objfile_compunits.
5452
5453 2019-01-09  Tom Tromey  <tom@tromey.com>
5454
5455         * source.c (select_source_symtab)
5456         (forget_cached_source_info_for_objfile): Remove declaration.
5457         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5458         declaration.
5459         * maint.c (count_symtabs_and_blocks): Remove declaration.
5460         * cp-support.c (add_symbol_overload_list_qualified): Remove
5461         declaration.
5462         * coffread.c (coff_symtab_read): Remove declaration.
5463         * symtab.c (lookup_symbol_in_objfile_symtabs)
5464         (basic_lookup_transparent_type_1): Use objfile_compunits.
5465         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5466         (info_sources_command, search_symbols)
5467         (default_collect_symbol_completion_matches_break_on)
5468         (make_source_files_completion_list): Remove declaration.
5469         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5470         (ada_collect_symbol_completion_matches)
5471         (ada_add_global_exceptions): Remove declaration.
5472         * linespec.c (iterate_over_all_matching_symtabs): Use
5473         objfile_compunits.
5474         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5475         (class objfile_compunits): New.
5476         (ALL_COMPUNITS): Use objfile_compunits.
5477         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5478         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5479         objfile_compunits.
5480         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5481
5482 2019-01-09  Tom Tromey  <tom@tromey.com>
5483
5484         * symtab.c (search_symbols)
5485         (default_collect_symbol_completion_matches_break_on): Use
5486         objfile_msymbols.
5487         * ada-lang.c (ada_lookup_simple_minsym)
5488         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5489         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5490         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5491         objfile_msymbols.
5492         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5493         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5494         * objc-lang.c (find_methods): Use objfile_msymbols.
5495         (info_selectors_command, info_classes_command): Likewise.
5496         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5497         * objfiles.h (class objfile_msymbols): New.
5498         (ALL_OBJFILE_MSYMBOLS): Remove.
5499         (ALL_MSYMBOLS): Remove.
5500
5501 2019-01-09  Tom Tromey  <tom@tromey.com>
5502
5503         * common/next-iterator.h (next_adapter): Add Iterator template
5504         parameter.
5505         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5506         (class all_objfiles_safe): New.
5507         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5508         * objfiles.c (put_objfile_before): Update comment.
5509         (add_separate_debug_objfile): Likewise.
5510         (free_all_objfiles): Use all_objfiles_safe.
5511         (objfile_purge_solibs): Likewise.
5512
5513 2019-01-09  Tom Tromey  <tom@tromey.com>
5514
5515         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5516         (expand_symtab_containing_pc, lookup_static_symbol)
5517         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5518         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5519         all_objfiles.
5520         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5521         * breakpoint.c (create_overlay_event_breakpoint)
5522         (create_longjmp_master_breakpoint)
5523         (create_std_terminate_master_breakpoint)
5524         (create_exception_master_breakpoint): Use all_objfiles.
5525         * linux-thread-db.c (try_thread_db_load_from_pdir)
5526         (has_libpthread): Use all_objfiles.
5527         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5528         * linespec.c (iterate_over_all_matching_symtabs)
5529         (search_minsyms_for_name): Use all_objfiles.
5530         * maint.c (maintenance_info_sections): Use all_objfiles.
5531         * main.c (captured_main_1): Use all_objfiles.
5532         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5533         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5534         * guile/scm-pretty-print.c
5535         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5536         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5537         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5538         (maintenance_print_msymbols): Use all_objfiles.
5539         * source.c (select_source_symtab): Use all_objfiles.
5540         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5541         * symfile.c (remove_symbol_file_command)
5542         (expand_symtabs_matching, map_symbol_filenames): Use
5543         all_objfiles.
5544         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5545         all_objfiles.
5546         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5547         * objc-lang.c (find_methods): Use all_objfiles.
5548         * objfiles.c (have_partial_symbols, have_full_symbols)
5549         (have_minimal_symbols, qsort_cmp)
5550         (default_iterate_over_objfiles_in_search_order): Use
5551         all_objfiles.
5552         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5553         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5554         (maintenance_check_psymtabs): Use all_objfiles.
5555         (ALL_PSYMTABS): Remove.
5556         * compile/compile-object-run.c (do_module_cleanup): Use
5557         all_objfiles.
5558         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5559         * cp-support.c (add_symbol_overload_list_qualified): Use
5560         all_objfiles.
5561         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5562         Use all_objfiles.
5563         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5564         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5565         all_objfiles.
5566         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5567         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5568         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5569         Uses all_objfiles.
5570         * solib.c (solib_read_symbols): Use all_objfiles
5571
5572 2019-01-09  Tom Tromey  <tom@tromey.com>
5573
5574         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5575         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5576         all_objfiles.
5577         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5578         * symmisc.c (print_symbol_bcache_statistics)
5579         (print_objfile_statistics, maintenance_print_objfiles)
5580         (maintenance_info_symtabs, maintenance_check_symtabs)
5581         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5582         all_objfiles.
5583         * source.c (forget_cached_source_info): Use all_objfiles.
5584         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5585         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5586         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5587         * objfiles.c (update_section_map): Use all_objfiles.
5588         (shared_objfile_contains_address_p): Likewise.
5589         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5590         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5591
5592 2019-01-09  Tom Tromey  <tom@tromey.com>
5593
5594         * common/next-iterator.h: New file.
5595         * objfiles.h (class all_objfiles): New.
5596         (struct objfile_iterator): New.
5597
5598 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5599
5600         * NEWS: Move the description of the changed "frame", "select-frame",
5601          and "info frame" commands to the Changed commands section.
5602
5603 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5604
5605         * gdbtypes.c (check_stub_method_group): Remove handling of old
5606         mangling schemes.
5607         * linespec.c (find_methods): Likewise.
5608         * stabsread.c (read_member_functions): Likewise.
5609         * valops.c (search_struct_method): Likewise.
5610         (value_struct_elt_for_reference): Likewise.
5611         * NEWS: Mention this change.
5612
5613 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5614
5615         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5616         print_source_lines.
5617         * source.c (print_source_lines_base): Update line number check.
5618         (print_source_lines): New function.
5619         (source_lines_range::source_lines_range): New function.
5620         * source.h (class source_lines_range): New class.
5621         (print_source_lines): New declaration.
5622
5623 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5624
5625         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5626
5627 2019-01-08  Tom Tromey  <tom@tromey.com>
5628             Simon Marchi  <simon.marchi@ericsson.com>
5629
5630         PR gdb/24060
5631         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5632         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5633         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5634         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5635         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5636         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5637
5638 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5639
5640         * source.c (select_source_symtab): Move header comment to
5641         declaration in source.h.
5642         (forget_cached_source_info_for_objfile): Likewise.
5643         (forget_cached_source_info): Likewise.
5644         (identify_source_line): Likewise.
5645         * source.h (identify_source_line): Move declaration from symtab.h
5646         and add comment from source.c
5647         (print_source_lines): Likewise.
5648         (forget_cached_source_info_for_objfile): Likewise.
5649         (forget_cached_source_info): Likewise.
5650         (select_source_symtab): Likewise.
5651         (enum print_source_lines_flag): Move definition from symtab.h.
5652         * symtab.h (identify_source_line): Move declaration to source.h.
5653         (print_source_lines): Likewise.
5654         (forget_cached_source_info_for_objfile): Likewise.
5655         (forget_cached_source_info): Likewise.
5656         (select_source_symtab): Likewise.
5657         (enum print_source_lines_flag): Move definition to source.h.
5658         * tui/tui-hooks.c: Add 'source.h' include.
5659
5660 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5661
5662         * source.c (print_source_lines_base): Handle requests to print
5663         reverse line number sequences, and guard against empty lines
5664         string.
5665
5666 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5667
5668         * source.c (print_source_lines_base): Fix skip of '\r' if next
5669         character is '\n'.
5670
5671 2019-01-06  Tom Tromey  <tom@tromey.com>
5672
5673         * c-exp.y (struct c_parse_state) <macro_original_text,
5674         expansion_obstack>: New member.
5675         (macro_original_text, expansion_obstack): Remove globals.
5676         (scan_macro_expansion, scanning_macro_expansion)
5677         (finished_macro_expansion): Update.
5678         (scan_macro_cleanup): Remove.
5679         (yylex, c_parse): Update.
5680
5681 2019-01-06  Tom Tromey  <tom@tromey.com>
5682
5683         * c-exp.y (struct c_parse_state) <strings>: New member.
5684         (operator_stoken): Update.
5685
5686 2019-01-06  Tom Tromey  <tom@tromey.com>
5687
5688         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5689         (union type_stack_elt) <typelist_val>: Now a pointer to
5690         std::vector.
5691         (type_stack_cleanup): Don't declare.
5692         (push_typelist): Update.
5693         * parse.c (pop_typelist): Return a std::vector.
5694         (push_typelist): Take a std::vector.
5695         (follow_types): Update.  Do not free args.
5696         (type_stack_cleanup): Remove.
5697         * c-exp.y (struct c_parse_state): New.
5698         (cpstate): New global.
5699         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5700         (nonempty_typelist): Update.
5701         (func_mod): Create a new vector.
5702         (c_parse): Create a c_parse_state.
5703         (check_parameter_typelist): Do not delete params.
5704         (function_method): Update.  Do not delete type_list.
5705
5706 2019-01-06  Tom Tromey  <tom@tromey.com>
5707
5708         PR gdb/28155:
5709         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5710         check_typedef.
5711         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5712         (print_return_value): Likewise.
5713
5714 2019-01-05  Tom Tromey  <tom@tromey.com>
5715
5716         * contrib/cleanup_check.py: Remove.
5717         * contrib/gcc-with-excheck: Remove.
5718         * contrib/exsummary.py: Remove.
5719         * contrib/excheck.py: Remove.
5720
5721 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5722
5723         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5724         NULL. Initialize tpprev to NULL instead of assigning it
5725         to NULL on the next statement.
5726         * windows-nat.c (windows_delete_thread): Remove check for
5727         main_thread_id before printing thread exit notifications.
5728         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5729         Remove thread ID check against main_thread_id.
5730         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5731         windows_delete_thread.
5732         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5733
5734 2019-01-04  Tom Tromey  <tom@tromey.com>
5735
5736         * compile/compile.c (_initialize_compile): Use upper case for
5737         metasyntactic variables.
5738         * symmisc.c (_initialize_symmisc): Use upper case for
5739         metasyntactic variables.
5740         * psymtab.c (_initialize_psymtab): Use upper case for
5741         metasyntactic variables.
5742         * demangle.c (demangle_command): Use upper case for metasyntactic
5743         variables.
5744         (_initialize_demangler): Likewise.
5745         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5746         variables.
5747
5748 2019-01-03  Tom Tromey  <tom@tromey.com>
5749
5750         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5751
5752 2019-01-03  Tom Tromey  <tom@tromey.com>
5753
5754         * python/py-symtab.c (salpy_str): Update.
5755         (struct salpy_sal_object) <symtab>: Now a PyObject.
5756         (salpy_dealloc): Update.
5757         (del_objfile_sal): Use gdbpy_ref.
5758
5759 2019-01-03  Tom Tromey  <tom@tromey.com>
5760
5761         * python/py-type.c (convert_field): Use new_reference.  Return
5762         gdbpy_ref.
5763         (make_fielditem): Return gdbpy_ref.
5764         (typy_fields): Update.
5765         (typy_getitem): Update.
5766         (field_name): Return gdbpy_ref.  Use new_reference.
5767         (typy_iterator_iternext): Update.
5768
5769 2019-01-03  Tom Tromey  <tom@tromey.com>
5770
5771         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5772
5773 2019-01-03  Tom Tromey  <tom@tromey.com>
5774
5775         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5776         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5777         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5778         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5779         (pspy_set_type_printers): Likewise.
5780         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5781         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5782         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5783         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5784         (objfpy_set_type_printers): Likewise.
5785
5786 2019-01-03  Tom Tromey  <tom@tromey.com>
5787
5788         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5789         (gdbpy_print_stack): Use gdbpy_err_fetch.
5790         * python/python-internal.h (class gdbpy_err_fetch): New class.
5791         (class gdbpy_enter) <m_error_type, m_error_value,
5792         m_error_traceback>: Remove.
5793         <m_error>: New member.
5794         (gdbpy_exception_to_string): Don't declare.
5795         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5796         * python/py-value.c (convert_value_from_python): Use
5797         gdbpy_err_fetch.
5798         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5799         gdbpy_exception_to_string.
5800         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5801         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5802         gdbpy_err_fetch.
5803
5804 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5805
5806         * linux-nat.c (delete_lwp_cleanup): Delete.
5807         (struct lwp_deleter): New struct.
5808         (lwp_info_up): New typedef.
5809         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5810         lwp_info_up.
5811
5812 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5813
5814         * linux-fork.c (class scoped_switch_fork_info): New class.
5815         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5816
5817 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5818
5819         * valops.c (find_overload_match): Remove use of null_cleanup, and
5820         calls to do_cleanups.
5821
5822 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5823
5824         * compile/compile-cplus-types.c
5825         (compile_cplus_instance::decl_name): Handle changes to
5826         cp_func_name.
5827         * cp-support.c (cp_func_name): Update header comment, update
5828         return type.
5829         * cp-support.h (cp_func_name): Update return type in declaration.
5830         * valops.c (find_overload_match): Move temp_func local to top
5831         level of function and change its type.  Use temp_func to hold and
5832         delete temporary string obtained from cp_func_name.
5833
5834 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5835
5836         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5837         gdb::char_vector, remove cleanup, and update uses of `msg`.
5838
5839 2019-01-03  Jim Wilson  <jimw@sifive.com>
5840
5841         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5842
5843 2019-01-02  Tom Tromey  <tom@tromey.com>
5844
5845         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5846         (tdesc_parse_xml): Remove cleanups.
5847         * target-descriptions.h (make_cleanup_free_target_description):
5848         Don't declare.
5849         (target_desc_deleter): New struct.
5850         (target_desc_up): New typedef.
5851         * target-descriptions.c (target_desc_deleter::operator()): Rename
5852         from free_target_description.
5853         (make_cleanup_free_target_description): Remove.
5854
5855 2019-01-02  Tom Tromey  <tom@tromey.com>
5856
5857         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5858         constructor, destructor.
5859         (linespec_parser): Remove typedef.
5860         (~linespec_parser): Rename from linespec_parser_delete.
5861         (linespec_lex_to_end, linespec_complete_label)
5862         (linespec_complete): Update.
5863         (decode_line_full): Remove cleanups.
5864         (decode_line_1): Update.
5865
5866 2019-01-02  Tom Tromey  <tom@tromey.com>
5867
5868         * python/python-internal.h (inferior_to_inferior_object): Change
5869         return type.
5870         * python/py-exitedevent.c (create_exited_event_object): Update.
5871         * python/py-inferior.c (inferior_to_inferior_object): Return
5872         gdbpy_ref.
5873         (python_new_inferior, python_inferior_deleted)
5874         (thread_to_thread_object, delete_thread_object)
5875         (build_inferior_list, gdbpy_selected_inferior): Update.
5876         * python/py-infthread.c (create_thread_object): Update.  Also fail
5877         if inferior_to_inferior_object fails.
5878
5879 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5880
5881         * inferior.h (class inferior) <displaced_step_state>: New field.
5882         * infrun.h (struct displaced_step_state): Move here from
5883         infrun.c.  Initialize fields, add constructor.
5884         <inf>: Remove field.
5885         <reset>: New method.
5886         * infrun.c (struct displaced_step_inferior_state): Move to
5887         infrun.h.
5888         (displaced_step_inferior_states): Remove.
5889         (get_displaced_stepping_state): Adust.
5890         (displaced_step_in_progress_any_inferior): Adjust.
5891         (displaced_step_in_progress_thread): Adjust.
5892         (displaced_step_in_progress): Adjust.
5893         (add_displaced_stepping_state): Remove.
5894         (get_displaced_step_closure_by_addr): Adjust.
5895         (remove_displaced_stepping_state): Remove.
5896         (infrun_inferior_exit): Call displaced_step_state.reset.
5897         (use_displaced_stepping): Don't check for NULL.
5898         (displaced_step_prepare_throw): Call
5899         get_displaced_stepping_state.
5900         (displaced_step_fixup): Don't check for NULL.
5901         (prepare_for_detach): Don't check for NULL.
5902
5903 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5904
5905         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5906          in case of call that did not complete.
5907
5908 2019-01-02  Andrey Utkin  <autkin@undo.io>
5909
5910         * symfile.c (find_separate_debug_file): Fix search of debug files for
5911         remote debuggee.
5912
5913 2019-01-02  Tom Tromey  <tom@tromey.com>
5914
5915         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5916         indentation.
5917         * python/py-frame.c (frapy_older): Remove cast.
5918         (frapy_newer): Likewise.
5919         * python/py-breakpoint.c (local_setattro): Remove cast.
5920         * python/py-arch.c (archpy_name): Remove local variable.
5921         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5922
5923 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5924
5925         * unittests/basic_string_view/element_access/char/empty.cc:
5926         Fix year range in copyright header.
5927
5928 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5929
5930         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5931         Delete.
5932         <operator==>: Update with for removed field.
5933         <hash>: Likewise.
5934         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5935         <isa_features>: ...this.
5936         <abi_features>: New field.
5937         (riscv_isa_flen): Update comment.
5938         (riscv_abi_xlen): New declaration.
5939         (riscv_abi_flen): New declaration.
5940         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5941         isa_features.
5942         (riscv_abi_xlen): New function.
5943         (riscv_isa_flen): Update to get answer from isa_features.
5944         (riscv_abi_flen): New function.
5945         (riscv_has_fp_abi): Update to get answer from abi_features.
5946         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5947         xlen and flen.
5948         (riscv_call_info) <xlen, flen>: Update comment.
5949         (riscv_call_arg_struct): Remove invalid assertions
5950         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5951         is removed.
5952         (riscv_gdbarch_init): Gather isa features and abi features
5953         separately, ensure both match on the gdbarch when reusing an old
5954         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5955         a target with 64-bit float hardware.
5956
5957 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5958
5959         * source.c (search_command_helper): Stop reverse search
5960         when line 1 has been searched.
5961
5962 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5963
5964         * record-full.c (record_full_base_target::close): Rewrite
5965         record_full_core_buf_list free logic.
5966
5967 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5968
5969         * break-catch-syscall.c (print_one_catch_syscall): xfree
5970         the last text.
5971
5972 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5973
5974         * top.c (print_gdb_version): Update Copyright year in version
5975         message.
5976
5977 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5978
5979         Update copyright year range in all GDB files.
5980
5981 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5982
5983         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5984
5985 For older changes see ChangeLog-2018.
5986 \f
5987 Local Variables:
5988 mode: change-log
5989 left-margin: 8
5990 fill-column: 74
5991 version-control: never
5992 coding: utf-8
5993 End:
5994