Function for reading the Aarch64 SVE vector length
[external/binutils.git] / gdb / ChangeLog
1 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
2
3         * Makefile.in: Add new header.
4         * gdb/arch/aarch64.h (sve_vg_from_vl): New macro.
5         (sve_vl_from_vg): Likewise.
6         (sve_vq_from_vl): Likewise.
7         (sve_vl_from_vq): Likewise.
8         (sve_vq_from_vg): Likewise.
9         (sve_vg_from_vq): Likewise.
10         * configure.nat: Add new c file.
11         * nat/aarch64-sve-linux-ptrace.c: New file.
12         * nat/aarch64-sve-linux-ptrace.h: New file.
13
14 2018-05-31  Alan Hayward  <alan.hayward@arm.com>
15
16         * aarch64-linux-nat.c (aarch64_linux_read_description):
17         Add parmeter zero.
18         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
19         Likewise.
20         * aarch64-tdep.c (tdesc_aarch64_list): Add.
21         (aarch64_read_description): Use VQ to index tdesc_aarch64_list.
22         (aarch64_gdbarch_init): Add parmeter zero.
23         * aarch64-tdep.h (aarch64_read_description): Add VQ parmeter.
24         * arch/aarch64.c (aarch64_create_target_description): Check VQ.
25         * arch/aarch64.h (aarch64_create_target_description): Add VQ.
26         parmeter.
27         * doc/gdb.texinfo: Describe SVE feature
28         * features/aarch64-sve.c: New file.
29
30 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
31
32         PR gdb/23210
33         * gdbarch.sh (significant_addr_bit): Default to zero when
34         not set by target architecture.
35         * gdbarch.c: Re-generated.
36         * utils.c (address_significant): Update.
37
38 2018-05-30  Joel Brobecker  <brobecker@adacore.com>
39
40         * stack.c (func_command): Remove trailing newline in call to error.
41
42 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
43
44         * regcache.h (regcache_raw_collect): Remove, update callers to
45         use regcache::raw_collect.
46         * regcache.c (regcache_raw_collect): Remove.
47
48 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
49
50         * regcache.h (regcache_raw_supply): Remove, update callers to
51         use detached_regcache::raw_supply.
52         * regcache.c (regcache_raw_supply): Remove.
53
54 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
55
56         * regcache.h (regcache_cooked_write_part): Remove, update
57         callers to use regcache::cooked_write_part.
58         * regcache.c (regcache_cooked_write_part): Remove.
59
60 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
61
62         * regcache.h (regcache_cooked_read_part): Remove, update callers
63         to use readable_regcache::cooked_read_part.
64         * regcache.c (regcache_cooked_read_part): Remove.
65
66 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
67
68         * regcache.h (regcache_cooked_read_value): Remove, update
69         callers to use readable_regcache::cooked_read_value.
70         * regcache.c (regcache_cooked_read_value): Remove.
71
72 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
73
74         * regcache.h (regcache_cooked_write): Remove, update callers to
75         use regcache::cooked_write.
76         * regcache.c (regcache_cooked_write): Remove.
77
78 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
79
80         * regcache.h (regcache_invalidate): Remove, update callers to
81         use detached_regcache::invalidate instead.
82         * regcache.c (regcache_invalidate): Remove.
83
84 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
85
86         * regcache.h (regcache_raw_write_part): Remove, update callers
87         to use regcache::raw_write_part instead.
88         * regcache.c (regcache_raw_write_part): Remove.
89
90 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
91
92         * regcache.h (regcache_raw_read_part): Remove, update callers to
93         use readable_regcache::raw_read_part instead.
94         * regcache.c (regcache_raw_read_part): Remove.
95
96 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
97
98         * regcache.h (regcache_cooked_read): Remove, update callers to
99         use readable_regcache::cooked_read instead.
100         * regcache.c (regcache_cooked_read): Remove.
101
102 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
103
104         * regcache.h (regcache_raw_write): Remove, update callers to use
105         regcache::raw_write instead.
106         * regcache.c (regcache_raw_write): Remove.
107
108 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
109
110         * regcache.h (regcache_raw_read): Remove, update callers to use
111         readable_regcache::raw_read instead.
112         * regcache.c (regcache_raw_read): Remove.
113
114 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
115
116         * regcache.h (regcache_raw_update): Remove, update callers to
117         use readable_regcache::raw_update instead.
118         * regcache.c (regcache_raw_update): Remove.
119
120 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
121
122         * regcache.h (regcache_register_status): Remove, update callers
123         to use reg_buffer::get_register_status directly instead.
124         * regcache.c (regcache_register_status): Remove.
125
126 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
127
128         * regcache.h (regcache_get_ptid): Remove, update all callers to
129         call regcache::ptid instead.
130         * regcache.c (regcache_get_ptid): Remove.
131
132 2018-05-30  Simon Marchi  <simon.marchi@ericsson.com>
133
134         * Makefile.in (ALL_TARGET_OBS): Add or1k-tdep.o.
135
136 2018-05-30  Pedro Alves  <palves@redhat.com>
137
138         * common/common-exceptions.h (exception_rethrow): Use
139         ATTRIBUTE_NORETURN.
140
141 2018-05-29  Simon Marchi  <simon.marchi@polymtl.ca>
142
143         * breakpoint.c (print_solib_event, check_status_catch_solib):
144         Remove struct keyword in range-based for loops.
145         * dbxread.c (find_corresponding_bincl_psymtab): Likewise.
146         * dwarf2read.c (compute_delayed_physnames, rust_union_quirks);
147         Likewise.
148         * linespec.c (find_superclass_methods, search_minsyms_for_name):
149         Likewise.
150         * symfile.c (addr_info_make_relative): Likewise.
151         * thread.c (value_in_thread_stack_temporaries): Likewise.
152
153 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
154
155         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
156         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
157         * coff-pe-read.c (add_pe_forwarded_sym): Replace
158         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
159         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
160         * jit.c (jit_breakpoint_re_set_internal): Likewise.
161         * printcmd.c (info_address_command): Likewise.
162
163 2018-05-29  Tom Tromey  <tom@tromey.com>
164
165         * windows-nat.c (handle_exception): Update fall-through comment.
166
167 2018-05-29  Tom Tromey  <tom@tromey.com>
168
169         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
170         (struct program_space) <added_solibs>: Now a std::vector.
171         * breakpoint.c (print_solib_event): Update.
172         (check_status_catch_solib): Update.
173         * progspace.c (clear_program_space_solib_cache): Update.
174         * solib.c (update_solib_list): Update.
175
176 2018-05-29  Tom Tromey  <tom@tromey.com>
177
178         * python/py-type.c (typy_richcompare): Update.
179         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
180         * gdbtypes.h (types_deeply_equal): Return bool.
181         (types_equal): Likewise.
182         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
183         declare VEC.
184         (check_types_equal): Change worklist to std::vector.  Return
185         bool.
186         (struct type_equality_entry): Add constructor.
187         (compare_maybe_null_strings): Return bool.
188         (check_types_worklist): Return bool.  Change worklist to
189         std::vector.
190         (types_deeply_equal): Use std::vector.
191         (types_equal): Return bool.
192         (compare_maybe_null_strings): Simplify.
193
194 2018-05-29  Tom Tromey  <tom@tromey.com>
195
196         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
197
198 2018-05-29  Tom Tromey  <tom@tromey.com>
199
200         * objc-lang.h: Don't include cp-support.h.
201         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
202         declare VEC.
203
204 2018-05-27  Tom Tromey  <tom@tromey.com>
205
206         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
207
208 2018-05-25  Tom Tromey  <tom@tromey.com>
209
210         * value.c (value::location): Initialize.
211
212 2018-05-25  Tom Tromey  <tom@tromey.com>
213
214         * dbxread.c (init_bincl_list): Remove.
215         (bincl_list): Now a std::vector.
216         (bincls_allocated, next_bincl): Remove.
217         (free_bincl_list, do_free_bincl_list_cleanup)
218         (make_cleanup_free_bincl_list): Remove.
219         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
220         unique_xmalloc_ptr.
221         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
222         (struct header_file_location): Add constructor.
223         (add_bincl_to_list): Remove.
224
225 2018-05-25  Tom Tromey  <tom@tromey.com>
226
227         * tui/tui.c (tui_enable): Update.
228         * mi/mi-interp.c (mi_interp::init): Update.
229         * interps.h (class interp) <name>: New method.
230         <m_name>: Rename from name.
231         (~scoped_restore_interp): Update.
232         * interps.c (interp::interp): Update.
233         (interp_add, interp_set, interp_lookup_existing)
234         (current_interp_named_p): Update.
235
236 2018-05-25  Tom Tromey  <tom@tromey.com>
237
238         * interps.c (interp_name): Remove.
239         * mi/mi-interp.c (mi_interp::init): Update.
240         * interps.h (interp_name): Remove.
241         (~scoped_restore_interp): Update.
242         * tui/tui.c (tui_enable): Update.
243
244 2018-05-25  Tom Tromey  <tom@tromey.com>
245
246         * utils.c (fputs_maybe_filtered): Update.
247         * linespec.c (decode_line_full): Update.
248         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
249         (mi_print_breakpoint_for_event, mi_solib_loaded)
250         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
251         (mi_user_selected_context_changed): Update.
252         * mi/mi-main.c (mi_execute_command): Update.
253         * cli/cli-script.c (execute_control_command): Update.
254         * python/python.c (execute_gdb_command): Update.
255         * solib.c (info_sharedlibrary_command): Update.
256         * interps.c (interp_ui_out): Remove.
257         * interps.h (interp_ui_out): Remove.
258
259 2018-05-25  Tom Tromey  <tom@tromey.com>
260
261         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
262         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
263         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
264
265 2018-05-25  Tom Tromey  <tom@tromey.com>
266
267         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
268         * interps.c (interp_exec): Use scoped_restore.
269
270 2018-05-25  Tom Tromey  <tom@tromey.com>
271
272         * remote.c (remote_target::remote_file_get): Use
273         gdb::byte_vector.
274         (remote_target::remote_file_put): Likewise.
275
276 2018-05-25  Tom Tromey  <tom@tromey.com>
277
278         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
279         a std::string.
280         (get_pe_section_index, add_pe_exported_sym): Update.
281         (read_pe_exported_syms): Use gdb::def_vector.
282
283 2018-05-25  Tom Tromey  <tom@tromey.com>
284
285         * frame.c (remove_prev_frame): Remove.
286         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
287
288 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
289
290         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
291         Remove prototypes.
292         * mips-linux-nat.c (supply_fpregset): Always call
293         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
294         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
295         `mips_fill_fpregset'.
296         * mips-linux-tdep.c (mips_supply_fpregset)
297         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
298         (mips_fill_fpregset_wrapper): Remove functions.
299         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
300         (mips_linux_fpregset): Remove variable.
301         (mips_linux_iterate_over_regset_sections): Use
302         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
303         (mips_linux_o32_sigframe_init): Remove comment.
304
305 2018-05-25  Pedro Alves  <palves@redhat.com>
306
307         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
308         (struct readahead_cache, struct packet_reg, struct
309         remote_arch_state, class remote_state): Move higher up in the
310         file.
311         (remote_target::m_remote_state): Now an object instead of a pointer.
312         (remote_target::get_remote_state): Adjust.
313
314 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
315
316         * stack.c (select_and_print_frame): Delete.
317         (struct function_bounds): Move struct within function.
318         (func_command): Most content moved into new function
319         find_frame_for_function, use new function, print result, add
320         function comment.
321         (find_frame_for_function): New function, now returns a result.
322
323 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
324
325         * stack.c (iterate_over_block_arg_vars): Fix comment.
326         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
327
328 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
329
330         PR gdb/23203
331         * frame.c
332         (scoped_restore_selected_frame::scoped_restore_selected_frame):
333         Define.
334         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
335         Define.
336         * frame.h (class scoped_restore_selected_frame): New class.
337         * stack.c (print_frame_local_vars): Remove catching and rethrowing
338         of any exception, use scoped_restore_selected_frame to restore the
339         frame instead.
340
341 2018-05-24  Pedro Alves  <palves@redhat.com>
342
343         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
344         override.
345
346 2018-05-23  Tom Tromey  <tom@tromey.com>
347
348         * complaints.c (struct complaints): Remove.
349         (symfile_complaint_book): Remove.
350         (series): New global.
351         (complaint_internal): Update.
352         (clear_complaints): Update.
353
354 2018-05-23  Tom Tromey  <tom@tromey.com>
355
356         * complaints.c (counters): New global.
357         (struct complain): Remove.
358         (struct complaints) <root>: Remove.
359         (complaint_sentinel): Remove.
360         (symfile_complaint_book): Update.
361         (find_complaint) Remove.
362         (complaint_internal, clear_complaints): Update.
363
364 2018-05-23  Tom Tromey  <tom@tromey.com>
365
366         * complaints.c (struct complain) <file, line>: Remove.
367         (find_complaint): Remove file, line parameters.
368         (complaint_internal): Update.
369
370 2018-05-23  Tom Tromey  <tom@tromey.com>
371
372         * complaints.c (vcomplaint): Remove.
373         (complaint_internal) Merge in contents of vcomplaint.
374
375 2018-05-23  Tom Tromey  <tom@tromey.com>
376
377         * complaints.c (struct complaints) <explanation>: Remove.
378         (symfile_explanations): Remove.
379         (symfile_complaint_book): Update.
380         (vcomplaint): Update.
381         (struct explanation): Remove.
382
383 2018-05-23  Tom Tromey  <tom@tromey.com>
384
385         * complaints.c (symfile_complaints): Remove.
386         (complaint_internal): Remove "complaints" parameter.
387         (clear_complaints, vcomplaint): Remove "c" parameter.
388         (get_complaints): Remove.
389         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
390         (dwarf2_debug_line_missing_file_complaint)
391         (dwarf2_debug_line_missing_end_sequence_complaint)
392         (dwarf2_complex_location_expr_complaint)
393         (dwarf2_const_value_length_mismatch_complaint)
394         (dwarf2_section_buffer_overflow_complaint)
395         (dwarf2_macro_malformed_definition_complaint)
396         (dwarf2_invalid_attrib_class_complaint)
397         (create_addrmap_from_index, dw2_symtab_iter_next)
398         (dw2_expand_marked_cus)
399         (dw2_debug_names_iterator::find_vec_in_debug_names)
400         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
401         (create_debug_type_hash_table, init_cutu_and_read_dies)
402         (partial_die_parent_scope, add_partial_enumeration)
403         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
404         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
405         (read_import_statement, read_file_scope, create_dwo_cu_reader)
406         (create_cus_hash_table, create_dwp_hash_table)
407         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
408         (dwarf2_rnglists_process, dwarf2_ranges_process)
409         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
410         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
411         (handle_struct_member_die, process_structure_scope)
412         (read_array_type, read_common_block, read_module_type)
413         (read_tag_pointer_type, read_typedef, read_base_type)
414         (read_subrange_type, load_partial_dies, partial_die_info::read)
415         (partial_die_info::read, partial_die_info::read)
416         (partial_die_info::read, read_checked_initial_length_and_offset)
417         (dwarf2_string_attr, read_formatted_entries)
418         (dwarf_decode_line_header)
419         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
420         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
421         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
422         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
423         (get_signatured_type, get_DW_AT_signature_type)
424         (decode_locdesc, file_file_name, consume_improper_spaces)
425         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
426         (dwarf_decode_macro_bytes, dwarf_decode_macros)
427         (dwarf2_symbol_mark_computed, set_die_type)
428         (read_attribute_value): Update.
429         * stap-probe.c (handle_stap_probe, get_stap_base_address):
430         Update.
431         * dbxread.c (unknown_symtype_complaint)
432         (lbrac_mismatch_complaint, repeated_header_complaint)
433         (set_namestring, function_outside_compilation_unit_complaint)
434         (read_dbx_symtab, process_one_symbol): Update.
435         * gdbtypes.c (stub_noname_complaint): Update.
436         * windows-nat.c (handle_unload_dll): Update.
437         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
438         (decode_base_type): Update.
439         * xcoffread.c (bf_notfound_complaint, ef_complaint)
440         (eb_complaint, record_include_begin, record_include_end)
441         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
442         (process_xcoff_symbol, read_symbol)
443         (function_outside_compilation_unit_complaint)
444         (scan_xcoff_symtab): Update.
445         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
446         * buildsym.c (finish_block_internal, make_blockvector)
447         (end_symtab_get_static_block, augment_type_symtab): Update.
448         * dtrace-probe.c (dtrace_process_dof)
449         (dtrace_static_probe_ops::get_probes): Update.
450         * complaints.h (struct complaint): Don't declare.
451         (symfile_complaints): Remove.
452         (complaint_internal): Remove "complaints" parameter.
453         (complaint): Likewise.
454         (clear_complaints): Likewise.
455         * symfile.c (syms_from_objfile_1, finish_new_objfile)
456         (reread_symbols): Update.
457         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
458         (dwarf2_frame_cache, decode_frame_entry): Update.
459         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
460         * objc-lang.c (lookup_objc_class, lookup_child_selector)
461         (info_selectors_command): Update.
462         * macrotab.c (macro_include, check_for_redefinition)
463         (macro_undef): Update.
464         * objfiles.c (filter_overlapping_sections): Update.
465         * stabsread.c (invalid_cpp_abbrev_complaint)
466         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
467         (define_symbol, error_type, read_type, rs6000_builtin_type)
468         (stabs_method_name_from_physname, read_member_functions)
469         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
470         (attach_fields_to_type, complain_about_struct_wipeout)
471         (read_range_type, read_args, common_block_start)
472         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
473         Update.
474         * mdebugread.c (index_complaint, unknown_ext_complaint)
475         (basic_type_complaint, bad_tag_guess_complaint)
476         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
477         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
478         (parse_procedure, parse_lines)
479         (function_outside_compilation_unit_complaint)
480         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
481         (bad_tag_guess_complaint, reg_value_complaint): Update.
482         * cp-support.c (demangled_name_complaint): Update.
483         * macroscope.c (sal_macro_scope): Update.
484         * dwarf-index-write.c (class debug_names): Update.
485
486 2018-05-23  Tom Tromey  <tom@tromey.com>
487
488         * complaints.c (clear_complaints): Remove "noisy" parameter.
489         * complaints.h (clear_complaints): Update.
490         * symfile.c (syms_from_objfile_1, finish_new_objfile)
491         (reread_symbols): Update.
492
493 2018-05-23  Tom Tromey  <tom@tromey.com>
494
495         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
496         SUBSEQUENT_MESSAGE.
497         (vcomplaint, clear_complaints): Update.
498         (symfile_explanations): Remove some messages.
499
500 2018-05-23  Tom Tromey  <tom@tromey.com>
501
502         * complaints.c (internal_complaint): Remove.
503         * complaints.h (internal_complaint): Remove.
504
505 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
506
507         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
508
509 2018-05-22  Pedro Alves  <palves@redhat.com>
510
511         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
512         (remote_fileio_badfd, remote_fileio_return_errno)
513         (remote_fileio_return_success, remote_fileio_func_open)
514         (remote_fileio_func_open, remote_fileio_func_close)
515         (remote_fileio_func_read, remote_fileio_func_write)
516         (remote_fileio_func_lseek, remote_fileio_func_rename)
517         (remote_fileio_func_unlink, remote_fileio_func_stat)
518         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
519         (remote_fileio_func_isatty, remote_fileio_func_system): Add
520         remote_target parameter.
521         (remote_fio_func_map) <func>: Add remote_target parameter.
522         (do_remote_fileio_request, remote_fileio_request):
523         * remote-fileio.h (remote_fileio_request):
524         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
525         remote_target parameter.
526         (remote_notif_process, handle_notification): Adjust to pass down
527         the remote.
528         (remote_notif_state_allocate): Add remote_target parameter.  Save
529         it.
530         * remote-notif.h (struct remote_target): Forward declare.
531         (struct notif_client) <parse, ack, can_get_pending_events>: Add
532         remote_target parameter.
533         (struct remote_notif_state) <remote>: New field.
534         (remote_notif_ack, remote_notif_parse): Add remote_target
535         parameter.
536         (remote_notif_state_allocate, remote_notif_state_allocate): Add
537         remote_target parameter.
538         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
539         (threads_listing_context, rmt_thread_action, protocol_feature)
540         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
541         (packet_result, struct threads_listing_context, remote_state):
542         Move definitions and declarations higher up.
543         (remote_target) <~remote_target>: Declare.
544         (remote_download_command_source, remote_file_put, remote_file_get)
545         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
546         (remote_hostio_pread_vFile, remote_hostio_send_command)
547         (remote_hostio_set_filesystem, remote_hostio_open)
548         (remote_hostio_close, remote_hostio_unlink, remote_state)
549         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
550         (get_memory_write_packet_size, get_memory_read_packet_size)
551         (append_pending_thread_resumptions, remote_detach_1)
552         (append_resumption, remote_resume_with_vcont)
553         (add_current_inferior_and_thread, wait_ns, wait_as)
554         (process_stop_reply, remote_notice_new_inferior)
555         (process_initial_stop_replies, remote_add_thread)
556         (btrace_sync_conf, remote_btrace_maybe_reopen)
557         (remove_new_fork_children, kill_new_fork_children)
558         (discard_pending_stop_replies, stop_reply_queue_length)
559         (check_pending_events_prevent_wildcard_vcont)
560         (discard_pending_stop_replies_in_queue, stop_reply)
561         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
562         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
563         (remote_interrupt_as, remote_interrupt_ns)
564         (remote_get_noisy_reply, remote_query_attached)
565         (remote_add_inferior, remote_current_thread, get_current_thread)
566         (set_thread, set_general_thread, set_continue_thread)
567         (set_general_process, write_ptid)
568         (remote_unpack_thread_info_response, remote_get_threadinfo)
569         (parse_threadlist_response, remote_get_threadlist)
570         (remote_threadlist_iterator, remote_get_threads_with_ql)
571         (remote_get_threads_with_qxfer)
572         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
573         (get_offsets, remote_check_symbols, remote_supported_packet)
574         (remote_query_supported, remote_packet_size)
575         (remote_serial_quit_handler, remote_detach_pid)
576         (remote_vcont_probe, remote_resume_with_hc)
577         (send_interrupt_sequence, interrupt_query)
578         (remote_notif_get_pending_events, fetch_register_using_p)
579         (send_g_packet, process_g_packet, fetch_registers_using_g)
580         (store_register_using_P, store_registers_using_G)
581         (set_remote_traceframe, check_binary_download)
582         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
583         (remote_xfer_live_readonly_partial, remote_read_bytes)
584         (remote_send_printf, remote_flash_write, readchar)
585         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
586         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
587         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
588         (extended_remote_disable_randomization, extended_remote_run)
589         (send_environment_packet, extended_remote_environment_support)
590         (extended_remote_set_inferior_cwd, remote_write_qxfer)
591         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
592         (packet_command): Now methods of ...
593         (remote_target): ... this class.
594         (m_remote_state) <remote_target>: New field.
595         (struct remote_state) <stop_reply_queue,
596         remote_async_inferior_event_token, wait_forever_enabled_p>: New
597         fields.
598         (remote_state::remote_state): Allocate stop_reply_queue.
599         (remote_state): Delete global.
600         (get_remote_state_raw): Delete.
601         (remote_target::get_remote_state): Allocate m_remote_state on
602         demand.
603         (get_current_remote_target): New.
604         (remote_ops, extended_remote_ops): Delete.
605         (wait_forever_enabled_p, remote_async_inferior_event_token):
606         Delete, moved to struct remote_state.
607         (remote_target::close): Delete self.  Destruction bits split to
608         ...
609         (remote_target::~remote_target): ... this.
610         (show_memory_packet_size): Adjust to use
611         get_current_remote_target.
612         (struct protocol_feature) <func>: Add remote_target parameter.
613         All callers adjusted.
614         (curr_quit_handler_target): New.
615         (remote_serial_quit_handler): Reimplement.
616         (remote_target::open_1): Adjust to use get_current_remote_target.
617         Heap-allocate remote_target/extended_remote_target instances.
618         (vcont_builder::vcont_builder): Add remote_target parameter, and
619         save it in m_remote.  All callers adjusted.
620         (vcont_builder::m_remote): New field.
621         (vcont_builder::restart, vcont_builder::flush)
622         (vcont_builder::push_action): Use it.
623         (remote_target::commit_resume): Use it.
624         (struct queue_iter_param) <remote>: New field.
625         (remote_target::remove_new_fork_children): Fill in 'remote' field.
626         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
627         (check_pending_event_prevents_wildcard_vcont_callback)
628         (remote_target::check_pending_events_prevent_wildcard_vcont)
629         (remote_target::discard_pending_stop_replies)
630         (remote_target::discard_pending_stop_replies_in_queue)
631         (remote_target::remote_notif_remove_queued_reply): Fill in
632         'remote' field.
633         (remote_notif_get_pending_events): New.
634         (remote_target::readchar, remote_target::remote_serial_write):
635         Save/restore curr_quit_handler_target.
636         (putpkt): New.
637         (kill_new_fork_children): Fill in 'remote' field.
638         (packet_command): Use get_current_remote_target, defer to
639         remote_target method of same name.
640         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
641         parameter, and save it in m_remote.  All callers adjusted.
642         (scoped_remote_fd::release): Use m_remote.
643         (scoped_remote_fd::m_remote): New field.
644         (remote_file_put, remote_file_get, remote_file_delete): Use
645         get_current_remote_target, defer to remote_target method of same
646         name.
647         (remote_btrace_reset): Add remote_state paremeter.  Update all
648         callers.
649         (remote_async_inferior_event_handler). Pass down 'data'.
650         (remote_new_objfile): Use get_current_remote_target.
651         (remote_target::vcont_r_supported): New.
652         (set_range_stepping): Use get_current_remote_target and
653         remote_target::vcont_r_supported.
654         (_initialize_remote): Don't allocate 'remote_state' and
655         'stop_reply_queue' globals.
656         * remote.h (struct remote_target): Forward declare.
657         (getpkt, putpkt, remote_notif_get_pending_events): Add
658         'remote_target' parameter.
659
660 2018-05-22  Pedro Alves  <palves@redhat.com>
661
662         * remote.c (vcont_builder): Now a class.  Make all data members
663         private.
664         (vcont_builder) <vcont_builder, restart, flush, push_action>:
665         Declare methods.
666         (vcont_builder_restart): Rename to ...
667         (vcont_builder::restart): ... this.
668         (vcont_builder_flush): Rename to ...
669         (vcont_builder::flush): ... this.
670         (vcont_builder_push_action): Rename to ...
671         (vcont_builder::push_action): ... this.
672         (remote_target::commit_resume): Adjust.
673
674 2018-05-22  Pedro Alves  <palves@redhat.com>
675
676         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
677         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
678         (get_fixed_memory_packet_size): New.
679         (get_memory_packet_size): Use it.
680         (set_memory_packet_size): Don't override the config size with
681         DEFAULT_MAX_MEMORY_PACKET_SIZE.
682         (show_memory_packet_size): Use get_fixed_memory_packet_size.
683         Don't refer to get_memory_packet_size if not connected to a remote
684         target.  Show "(default)" if configured size is 0.
685
686 2018-05-22  Pedro Alves  <palves@redhat.com>
687
688         * remote.c (remote_target::mourn_inferior): Move
689         discard_pending_stop_replies call here from ...
690         (_initialize_remote): ... here.
691
692 2018-05-22  Pedro Alves  <palves@redhat.com>
693
694         * remote.c (compare_section_command): Remove set_general_process
695         call.
696
697 2018-05-22  Pedro Alves  <palves@redhat.com>
698
699         * remote.c (struct packet_reg, struct remote_arch_state):
700         Move higher up in the file.
701         (remote_state) <m_arch_states>: Store remote_arch_state values
702         instead of remote_arch_state pointers.
703         (remote_state::get_remote_arch_state): Adjust.
704
705 2018-05-22  Pedro Alves  <palves@redhat.com>
706
707         * remote.c: Include <unordered_map>.
708         (remote_state): Now a class.
709         (remote_state) <get_remote_arch_state>: Declare method.
710         <get_remote_arch_state>: New field.
711         (remote_arch_state) <remote_arch_state>: Declare ctor.
712         <regs>: Now a unique_ptr.
713         (remote_gdbarch_data_handle): Delete.
714         (get_remote_arch_state): Delete.
715         (remote_state::get_remote_arch_state): New.
716         (get_remote_state): Adjust to call remote_state's
717         get_remote_arch_state method.
718         (init_remote_state): Delete, bits factored out to ...
719         (remote_arch_state::remote_arch_state): ... this new method.
720         (get_remote_packet_size, get_memory_packet_size)
721         (process_g_packet, remote_target::fetch_registers)
722         (remote_target::prepare_to_store, store_registers_using_G)
723         (remote_target::store_registers, remote_target::get_trace_status):
724         Adjust to call remote_state's method.
725         (_initialize_remote): Remove reference to
726         remote_gdbarch_data_handle.
727
728 2018-05-22  Pedro Alves  <palves@redhat.com>
729
730         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
731         pread>: New method declarations.
732         (remote_target::open_1): Adjust.
733         (readahead_cache_invalidate): Rename to ...
734         (readahead_cache::invalidate): ... this, and adjust to be a class
735         method.
736         (readahead_cache_invalidate_fd): Rename to ...
737         (readahead_cache::invalidate_fd): ... this, and adjust to be a
738         class method.
739         (remote_hostio_pwrite): Adjust.
740         (remote_hostio_pread_from_cache): Rename to ...
741         (readahead_cache::pread): ... this, and adjust to be a class
742         method.
743         (remote_hostio_close): Adjust.
744
745 2018-05-22  Pedro Alves  <palves@redhat.com>
746
747         * remote.c (remote_hostio_close_cleanup): Delete.
748         (class scoped_remote_fd): New.
749         (remote_file_put, remote_file_get): Use it.
750
751 2018-05-22  Pedro Alves  <palves@redhat.com>
752
753         (struct vCont_action_support): Use bool and initialize all fields.
754         (struct readahead_cache): Initialize all fields.
755         (remote_state): Use bool and initialize all fields.
756         (remote_state::remote_state, remote_state::~remote_state): New.
757         (new_remote_state): Delete.
758         (_initialize_remote): Use new to allocate remote_state.
759
760 2018-05-22  Pedro Alves  <palves@redhat.com>
761             張俊芝  <zjz@zjz.name>
762
763         PR gdb/22973
764         * c-exp.y: Include "c-support.h".
765         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
766         of tolower.  Use c_ident_is_alpha to scan names.
767         * c-lang.c: Include "c-support.h".
768         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
769         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
770         * c-support.h: New file, with bits factored out from ...
771         * cp-name-parser.y: ... this file.
772         Include "c-support.h".
773         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
774         c-support.h and renamed.
775         (symbol_end, yylex): Adjust.
776
777 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
778
779         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
780         parameter type to CORE_ADDR.
781         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
782         parameter type in declaration to CORE_ADDR.
783         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
784         target_auxv_search to get AT_HWCAP and use the result to get the
785         target description.
786         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
787         to CORE_ADDR. Remove the cast of the return value to unsigned
788         long. Fix error predicate of target_auxv_search.
789         (ppc_linux_nat_target::read_description): Change the type of the
790         hwcap variable to CORE_ADDR.
791
792 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
793
794         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
795         if the size of fpscr is larger than 32 bits.
796
797 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
798
799         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
800         (ppc32_linux_vsxregmap): New global.
801         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
802         regcache_supply_regset, and regcache_collect_regset.
803         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
804         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
805         (fetch_vsx_register, store_vsx_register): Remove.
806         (fetch_vsx_registers): Add regno parameter. Get regset using
807         ppc_linux_vsxregset. Use regset to supply registers.
808         (store_vsx_registers): Add regno parameter. Get regset using
809         ppc_linux_vsxregset. Use regset to collect registers.
810         (fetch_register): Call fetch_vsx_registers instead of
811         fetch_vsx_register.
812         (store_register): Call store_vsx_registers instead of
813         store_vsx_register.
814         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
815         new regno parameter.
816         (store_ppc_registers): Call store_vsx_registers with -1 for the
817         new regno parameter.
818         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
819         (ppc_collect_vsxregset): Remove.
820
821 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
822
823         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
824         offset fields.
825         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
826         for vector register offset fields.
827         (ppc64_fbsd_reg_offsets): Likewise.
828         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
829         to vector register offset fields.
830         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
831         to vector register offset fields.
832         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
833         vector register offset fields.
834         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
835         initializers for vector register offset fields.
836         (rs6000_aix64_reg_offsets): Likewise.
837         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
838         (ppc_supply_vrregset): Remove.
839         (ppc_collect_vrregset): Remove.
840         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
841         (ppc_linux_vrregset) : New function.
842         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
843         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
844         (ppc32_linux_vrregset): Remove.
845         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
846         and use result instead of ppc32_linux_vrregset.
847         (ppc32_linux_reg_offsets): Remove initializers for vector register
848         offset fields.
849         (ppc64_linux_reg_offsets): Likewise.
850         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
851         * ppc-linux-nat.c: Include regset.h.
852         (gdb_vrregset_t): Adjust comment to account for little-endian
853         mode.
854         (supply_vrregset, fill_vrregset): Remove.
855         (fetch_altivec_register, store_altivec_register): Remove.
856         (fetch_altivec_registers): Add regno parameter. Get regset using
857         ppc_linux_vrregset. Use regset to supply registers.
858         (store_altivec_registers): Add regno parameter. Get regset using
859         ppc_linux_vrregset. Use regset to collect registers.
860         (fetch_register): Call fetch_altivec_registers instead of
861         fetch_altivec_register.
862         (store_register): Call store_altivec_registers instead of
863         store_altivec_register.
864         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
865         the new regno parameter.
866         (store_ppc_registers): Call store_altivec_registers with -1 for
867         the new regno parameter.
868
869 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
870
871         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
872         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
873         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
874         (gdb_vrregset_t): Change array type size to
875         PPC_LINUX_SIZEOF_VRREGSET.
876         (gdb_vsxregset_t): Change array type size to
877         PPC_LINUX_SIZEOF_VSXREGSET.
878         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
879         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
880         PPC_LINUX_SIZEOF_VSXREGSET.
881
882 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
883
884         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
885         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
886         nat/ppc-linux.c.
887         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
888         ppc_linux_target_wordsize with tid.
889         (ppc_linux_nat_target::read_description): Call ppc_linux_target
890         wordsize with tid.
891         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
892         (ppc64_64bit_inferior_p): Add static and inline specifiers.
893         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
894         tid parameter. Remove static specifier.
895         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
896         (ppc_linux_target_wordsize): New declaration.
897
898 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
899
900         * arch/ppc-linux-common.c: New file.
901         * arch/ppc-linux-common.h: New file.
902         * arch/ppc-linux-tdesc.h: New file.
903         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
904         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
905         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
906         arch/ppc-linux-tdesc.h.
907         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
908         arch/ppc-linux-tdesc.h.
909         (ppc_linux_nat_target::read_description): Remove target
910         description matching code. Fill a ppc_linux_features struct and
911         call ppc_linux_match_description with it. Move comment about ISA
912         2.05 to ppc-linux-common.c.
913         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
914         arch/ppc-linux-tdesc.h.
915         (ppc_linux_core_read_description): Remove target description
916         matching code. Fill a ppc_linux_features struct and call
917         ppc_linux_match_description with it.
918         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
919         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
920         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
921         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
922         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
923         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
924         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
925         (tdesc_powerpc_e500l): Remove.
926
927 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
928
929         * ada-lang.c (catch_assert_command): Pass empty string instead
930         of NULL for excep_string argument.
931
932 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
933
934         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
935         the width of the requested register exceeds the width of the
936         `ptrace' data type.
937
938 2018-05-21  Tom Tromey  <tom@tromey.com>
939
940         * printcmd.c (output_command): Remove.
941         (output_command_const): Rename to output_command.
942         * valprint.h (output_command): Rename from output_command_const.
943         * tracepoint.c (trace_dump_actions): Call output_command.
944
945 2018-05-21  Tom Tromey  <tom@tromey.com>
946
947         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
948         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
949         * ada-lang.h (create_ada_exception_catchpoint): Update.
950         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
951         std::string.
952         (create_excep_cond_exprs, ~ada_catchpoint)
953         (should_stop_exception, print_one_exception)
954         (print_mention_exception, print_recreate_exception): Update.
955         (ada_get_next_arg): Remove.
956         (catch_ada_exception_command_split): Use std::string.  Change type
957         of "excep_string", "cond_string".
958         (catch_ada_exception_command): Update.
959         (create_ada_exception_catchpoint): Change type of excep_string.
960         (ada_exception_sal): Remove excep_string parameter.
961         (~ada_catchpoint): Remove.
962
963 2018-05-21  Tom Tromey  <tom@tromey.com>
964
965         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
966         cleanup.
967
968 2018-05-21  Tom Tromey  <tom@tromey.com>
969
970         * ada-lang.c (ada_exception_message_1, ada_exception_message):
971         Return unique_xmalloc_ptr.
972         (print_it_exception): Update.
973
974 2018-05-21  Tom Tromey  <tom@tromey.com>
975
976         * tracepoint.c (trace_dump_actions): Use std::string.
977
978 2018-05-21  Tom Tromey  <tom@tromey.com>
979
980         * symfile.c (reread_symbols): Use std::string for original_name.
981
982 2018-05-21  Tom Tromey  <tom@tromey.com>
983
984         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
985         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
986         constructor.
987
988 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
989
990         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
991         instance to...
992         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
993         * objfiles.c (get_objfile_bfd_data): Allocate
994         objfile_per_bfd_storage with obstack_new when allocating on
995         obstack.
996
997 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
998
999         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
1000         OBSTACK_ZALLOC.
1001         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
1002         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
1003         * mdebugread.c (mdebug_build_psymtabs): Likewise.
1004         (add_pending): Likewise.
1005         (parse_symbol): Likewise.
1006         (parse_partial_symbols): Likewise.
1007         (psymtab_to_symtab_1): Likewise.
1008         (new_psymtab): Likewise.
1009         (elfmdebug_build_psymtabs): Likewise.
1010         * minsyms.c (terminate_minimal_symbol_table): Likewise.
1011         * objfiles.c (get_objfile_bfd_data): Likewise.
1012         (objfile_register_static_link): Likewise.
1013         * psymtab.c (allocate_psymtab): Likewise.
1014         * stabsread.c (read_member_functions): Likewise.
1015         * xcoffread.c (xcoff_end_psymtab): Likewise.
1016
1017 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
1018
1019         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
1020         compiler supports std::is_trivially_constructible.
1021         * common/poison.h: Include obstack.h.
1022         (IsMallocable): Define to is_trivially_constructible if the
1023         compiler supports it, define to true_type otherwise.
1024         (xobnew): New.
1025         (XOBNEW): Redefine.
1026         (xobnewvec): New.
1027         (XOBNEWVEC): Redefine.
1028         * gdb_obstack.h (obstack_zalloc): New.
1029         (OBSTACK_ZALLOC): Redefine.
1030         (obstack_calloc): New.
1031         (OBSTACK_CALLOC): Redefine.
1032         (obstack_new): New.
1033         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
1034         (gdbarch_obstack): New declaration in gdbarch.h, definition in
1035         gdbarch.c.
1036         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
1037         obstack_calloc/obstack_zalloc.
1038         (gdbarch_obstack_zalloc): Remove.
1039         * target-descriptions.c (tdesc_data_init): Use obstack_new.
1040
1041 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1042
1043         * stack.c (backtrace_command_1): Remove useless variable int i.
1044
1045 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1046
1047         * stack.c (print_frame_info): Fix comment.
1048
1049 2018-05-18  Tom Tromey  <tom@tromey.com>
1050
1051         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
1052         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
1053         (~dwarf2_per_objfile): Update
1054         (dwarf2_get_dwz_file): Use new.
1055         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
1056         unique_ptr.
1057
1058 2018-05-18  Tom Tromey  <tom@tromey.com>
1059
1060         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
1061         unique_ptr.
1062         * dwarf2read.c (struct dwp_file): Add constructor and
1063         initializers.
1064         (open_and_init_dwp_file): Return a unique_ptr.
1065         (dwarf2_per_objfile, create_dwp_hash_table)
1066         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
1067         (lookup_dwo_unit_in_dwp): Update.
1068         (open_and_init_dwp_file, get_dwp_file): Update.
1069
1070 2018-05-18  Tom Tromey  <tom@tromey.com>
1071
1072         * dwarf2read.c (dwarf2_per_objfile): Update.
1073         (struct mapped_index): Add initializers.
1074         (dwarf2_read_index): Use new.
1075         (dw2_symtab_iter_init): Update.
1076         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
1077         unique_ptr.
1078
1079 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
1080
1081         * dwarf2read.c (mapped_index) <total_size>: Remove.
1082
1083 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
1084
1085         * unittests/format_pieces-selftests.c (test_format_specifier):
1086         Add ARI comments.
1087
1088 2018-05-18  Tom Tromey  <tom@tromey.com>
1089
1090         * c-typeprint.c (maybe_print_hole): New function.
1091         (c_print_type_struct_field_offset): Update.
1092         (c_type_print_base_struct_union): Call maybe_print_hole.
1093
1094 2018-05-17  Keith Seitz  <keiths@redhat.com>
1095
1096         * breakpoint.c (build_bpstat_chain): New function, moved from
1097         bpstat_stop_status.
1098         (bpstat_stop_status): Add optional parameter, `stop_chain'.
1099         If no stop chain is passed, call build_bpstat_chain to build it.
1100         * breakpoint.h (build_bpstat_chain): Declare.
1101         (bpstat_stop_status): Move documentation here from breakpoint.c.
1102         * infrun.c (handle_signal_stop): Before eliding inlined frames,
1103         build the stop chain and pass it to skip_inline_frames.
1104         Pass this stop chain to bpstat_stop_status.
1105         * inline-frame.c: Include breakpoint.h.
1106         (stopped_by_user_bp_inline_frame): New function.
1107         (skip_inline_frames): Add parameter `stop_chain'.
1108         Move documention to inline-frame.h.
1109         If non-NULL, use stopped_by_user_bp_inline_frame to determine
1110         whether the frame should be elided.
1111         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
1112         Add moved documentation and update for new parameter.
1113
1114 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1115
1116         PR cli/14975
1117         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1118         unittests/format_pieces-selftests.c.
1119         * common/format.h (format_piece) <operator==>: New.
1120         (format_pieces) <operator[]>: Remove.
1121         * common/format.c (format_pieces::format_pieces): Handle \e.
1122         * unittests/format_pieces-selftests.c: New.
1123
1124 2018-05-17  Tom Tromey  <tom@tromey.com>
1125
1126         PR symtab/23010:
1127         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
1128         (dw2_instantiate_symtab): Add skip_partial parameter.
1129         (dw2_find_last_source_symtab, dw2_map_expand_apply)
1130         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
1131         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
1132         (dw2_expand_symtabs_matching_one)
1133         (dw2_find_pc_sect_compunit_symtab)
1134         (dw2_debug_names_lookup_symbol)
1135         (dw2_debug_names_expand_symtabs_for_function): Update.
1136         (init_cutu_and_read_dies): Add skip_partial parameter.
1137         (process_psymtab_comp_unit, build_type_psymtabs_1)
1138         (process_skeletonless_type_unit, load_partial_comp_unit)
1139         (psymtab_to_symtab_1): Update.
1140         (load_full_comp_unit): Add skip_partial parameter.
1141         (process_imported_unit_die, dwarf2_read_addr_index)
1142         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
1143         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
1144         (read_signatured_type): Update.
1145
1146 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
1147
1148         * value.c (release_value): Remove unused variable.
1149         (record_latest_value): Likewise.
1150         (access_value_history): Likewise.
1151         (preserve_values): Likewise.
1152
1153 2018-05-17  Tom Tromey  <tom@tromey.com>
1154
1155         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
1156         Initialize.
1157
1158 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
1159
1160         PR gdb/22286
1161         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
1162         Also handle registers whose width is not a multiple of
1163         PTRACE_TYPE_RET.
1164         (linux_nat_trad_target::store_register): Likewise.
1165
1166 2018-05-16  Tom Tromey  <tom@tromey.com>
1167
1168         * gdbcore.h (core_bfd): Redefine.
1169         * corelow.c (core_target::close): Update.
1170         (core_target_open): Update.
1171         * progspace.h (struct program_space) <cbfd>: Now a
1172         gdb_bfd_ref_ptr.
1173
1174 2018-05-16  Tom Tromey  <tom@tromey.com>
1175
1176         PR cli/19551:
1177         * symfile-add-flags.h (enum symfile_add_flags)
1178         <SYMFILE_NOT_FILENAME>: New constant.
1179         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
1180         objfile name from BFD.
1181         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
1182         * minidebug.c (find_separate_debug_file_in_section): Put
1183         ".gnu_debugdata" into BFD's file name.
1184
1185 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
1186
1187         * regcache.c (regcache_read_ftype, regcache_write_ftype):
1188         Remove.
1189
1190 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
1191
1192         PR binutils/21446
1193         * aarch64-tdep.c (aarch64_analyze_prologue,
1194         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
1195         Indicate not interested in errors.
1196
1197 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1198
1199         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
1200         Supply the MIPS_ZERO_REGNUM register.
1201
1202 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1203
1204         * mips-tdep.c (mask_address_var): Make variable static.
1205
1206 2018-05-14  Tom Tromey  <tom@tromey.com>
1207
1208         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
1209
1210 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
1213         FXSAVE_ADDR for the mxcsr register.
1214
1215 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
1216
1217         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
1218
1219 2018-05-11  Pedro Alves  <palves@redhat.com>
1220
1221         * corelow.c (core_target) <core_target>: No longer inline.
1222         Initialize m_core_gdbarch, m_core_vec and build the section table
1223         here.
1224         <~core_target>: New.
1225         <core_gdbarch, get_core_register_section>: New methods.
1226         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
1227         factored out from ...
1228         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
1229         (core_ops): Delete.
1230         (sniff_core_bfd): Add gdbarch parameter.
1231         (core_close): Delete, merged into ...
1232         (core_target::close): ... here.  Delete self.
1233         (core_close_cleanup): Delete.
1234         (core_target_open): Allocate a core_target on the heap.  Use a
1235         unique_ptr instead of a cleanup.  Bits moved into the core_target
1236         ctor.  Adjust to use core_target methods instead of globals.
1237         (get_core_register_section): Rename to ...
1238         (core_target::get_core_register_section): ... this and adjust.
1239         (struct get_core_registers_cb_data): New.
1240         (get_core_registers_cb): Use it.  Use bool.
1241         (core_target::fetch_registers, core_target::files_info)
1242         (core_target::xfer_partial, core_target::read_description)
1243         (core_target::pid_to, core_target::thread_name): Adjust to
1244         reference class fields instead of globals.
1245         * target.h (struct target_ops_deleter, target_ops_up): New.
1246
1247 2018-05-11  Pedro Alves  <palves@redhat.com>
1248
1249         * corefile.c (core_file_command): Move to corelow.c.
1250         * corelow.c (the_core_target): Delete.
1251         (core_file_command): Moved from corefile.c.  Check exec_bfd
1252         instead of the_core_target.  Use target_detach instead of calling
1253         into the_core_target directly.
1254         (maybe_say_no_core_file_now): New.
1255         (core_target::detach): Use it.
1256         (_initialize_corelow): Remove references to the_core_target.
1257         * gdbcore.h (the_core_target): Delete.
1258
1259 2018-05-11  Tom Tromey  <tromey@redhat.com>
1260             Pedro Alves  <palves@redhat.com>
1261
1262         * corefile.c (core_bfd): Remove.
1263         * gdbcore.h (core_bfd): Now a macro.
1264         * progspace.h (struct program_space) <cbfd>: New field.
1265
1266 2018-05-11  Tom Tromey  <tom@tromey.com>
1267
1268         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1269         gdb::def_vector.
1270
1271 2018-05-10  Tom Tromey  <tom@tromey.com>
1272
1273         * configure: Rebuild.
1274         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1275
1276 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1277
1278         PR server/23158:
1279         * regformats/regdat.sh: Adjust script, following the addition
1280         of the new expedite_regs parameter to init_target_desc.
1281
1282 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1283     
1284         PR gdb/23127
1285         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1286         set_gdbarch_significant_addr_bit.
1287         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1288         set_gdbarch_significant_addr_bit.
1289         * utils.c (address_significant): Update to sign extend addr.
1290
1291 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1292
1293         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1294         (xtensa_linux_init_abi): Limit tdep->num_regs by
1295         tdep->num_nopriv_regs.
1296         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1297         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1298         not initialized.
1299
1300 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1301
1302         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1303
1304 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1305
1306         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1307         (I387_MXCSR_INIT_VAL): New constant.
1308         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1309         buffer if it was supplied by the inferior.
1310         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1311         (i387_xsave_get_clear_bv): New function.
1312         (i387_supply_xsave): Only read x87 control registers from the
1313         xsave buffer if the feature is enabled, and the state will have
1314         been written, otherwise, provide a suitable default.
1315         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1316         including x87 control registers.  Update control registers if they
1317         have changed from the default value, and mark features as enabled
1318         as required.
1319         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1320
1321 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1322
1323         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1324
1325 2018-05-07  Tom Tromey  <tom@tromey.com>
1326
1327         * configure: Rebuild.
1328         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1329
1330 2018-05-07  Tom Tromey  <tom@tromey.com>
1331
1332         PR tdep/20362:
1333         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1334         bit.  Use correct value for VDIV.
1335
1336 2018-05-04  Tom Tromey  <tom@tromey.com>
1337
1338         * configure: Rebuild.
1339         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1340
1341 2018-05-04  Tom Tromey  <tom@tromey.com>
1342
1343         * linux-record.c (record_linux_system_call) <case
1344         RECORD_SYS_RECVFROM>: Add "break".
1345
1346 2018-05-04  Tom Tromey  <tom@tromey.com>
1347
1348         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1349         Add missing "break".
1350         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1351         Add missing "break".
1352
1353 2018-05-04  Tom Tromey  <tom@tromey.com>
1354
1355         * rs6000-tdep.c (ppc_process_record_op4)
1356         (ppc_process_record_op63): Add fall-through comment.
1357
1358 2018-05-04  Tom Tromey  <tom@tromey.com>
1359
1360         * i386-tdep.c (i386_process_record): Add fall-through comment.
1361
1362 2018-05-04  Tom Tromey  <tom@tromey.com>
1363
1364         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1365         comment.
1366
1367 2018-05-04  Tom Tromey  <tom@tromey.com>
1368
1369         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1370         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1371         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1372         comment.
1373         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1374         comment.
1375         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1376         comment.
1377
1378 2018-05-04  Tom Tromey  <tom@tromey.com>
1379
1380         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1381
1382 2018-05-04  Tom Tromey  <tom@tromey.com>
1383
1384         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1385         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1386         * symfile.c (section_is_mapped): Fix fall-through comment.
1387         * stabsread.c (define_symbol, read_member_functions): Fix
1388         fall-through comment.
1389         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1390         comment.
1391         * remote.c (remote_wait_as): Fix fall-through comment.
1392         * p-exp.y (yylex): Fix fall-through comment.
1393         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1394         comment.
1395         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1396         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1397         * jv-exp.y (yylex): Fix fall-through comment.
1398         * go-exp.y (lex_one_token): Fix fall-through comment.
1399         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1400         fall-through comment.
1401         * f-exp.y (yylex): Fix fall-through comment.
1402         * dwarf2read.c (process_die): Fix fall-through comments.
1403         * dbxread.c (process_one_symbol): Fix fall-through comment.
1404         * d-exp.y (lex_one_token): Fix fall-through comment.
1405         * cp-name-parser.y (yylex): Fix fall-through comment.
1406         * coffread.c (coff_symtab_read): Fix fall-through comment.
1407         * c-exp.y (lex_one_token): Fix fall-through comment.
1408         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1409         comment.
1410         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1411         comment.
1412
1413 2018-05-04  Tom Tromey  <tom@tromey.com>
1414
1415         PR python/22730:
1416         * NEWS: Mention gdb.execute change.
1417         * gdbcmd.h (execute_control_command): Don't declare.
1418         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1419         execute_control_commands, execute_control_commands_to_string.
1420         * cli/cli-script.h (execute_control_commands)
1421         (execute_control_commands_to_string): Declare.
1422         (execute_control_command): Add from_tty parameter.
1423         * cli/cli-script.c (execute_control_commands)
1424         (execute_control_commands_to_string): New functions.
1425         (execute_user_command): Use execute_control_commands.
1426         (execute_control_command_1): Add "from_tty" parameter.  Update.
1427         (execute_control_command): Likewise.
1428
1429 2018-05-04  Tom Tromey  <tom@tromey.com>
1430
1431         PR python/22731:
1432         * NEWS: Mention that breakpoint commands are writable.
1433         * python/py-breakpoint.c (bppy_set_commands): New function.
1434         (breakpoint_object_getset) <"commands">: Use it.
1435
1436 2018-05-04  Tom Tromey  <tom@tromey.com>
1437
1438         * tracepoint.c (actions_command): Update.
1439         * mi/mi-cmd-break.c (mi_command_line_array)
1440         (mi_command_line_array_cnt, mi_command_line_array_ptr)
1441         (mi_read_next_line): Remove.
1442         (mi_cmd_break_commands): Update.
1443         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
1444         function_view.
1445         * cli/cli-script.c (get_command_line): Update.
1446         (process_next_line): Use function_view.  Constify.
1447         (recurse_read_control_structure, read_command_lines)
1448         (read_command_lines_1): Change argument types to function_view.
1449         (do_define_command, document_command): Update.
1450         * breakpoint.h (check_tracepoint_command): Don't declare.
1451         * breakpoint.c (check_tracepoint_command): Remove.
1452         (commands_command_1, create_tracepoint_from_upload): Update.
1453
1454 2018-05-04  Tom Tromey  <tom@tromey.com>
1455
1456         PR gdb/11750:
1457         * cli/cli-script.h (enum command_control_type) <define_control>:
1458         New constant.
1459         * cli/cli-script.c (multi_line_command_p): Handle define_control.
1460         (build_command_line, execute_control_command_1)
1461         (process_next_line): Likewise.
1462         (do_define_command): New function, extracted from define_command.
1463         (define_command): Use it.
1464
1465 2018-05-04  Tom Tromey  <tom@tromey.com>
1466
1467         * tracepoint.c (actions_command): Update.
1468         * cli/cli-script.h (read_command_lines): Update.
1469         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
1470         (MAX_TMPBUF): Remove define.
1471         (define_command): Use string_printf.
1472         (document_command): Likewise.
1473         * breakpoint.c (commands_command_1): Update.
1474
1475 2018-05-04  Tom Tromey  <tom@tromey.com>
1476
1477         * top.c (execute_command): Update.
1478         * cli/cli-script.h (print_command_lines): Now varargs.
1479         * cli/cli-script.c (print_command_lines): Now varargs.
1480         (execute_control_command_1) <case while_control, case if_control>:
1481         Update.
1482
1483 2018-05-04  Tom Tromey  <tom@tromey.com>
1484
1485         * tracepoint.c (all_tracepoint_actions): Rename from
1486         all_tracepoint_actions_and_cleanup.  Change return type.
1487         (actions_command, encode_actions_1, encode_actions)
1488         (trace_dump_actions, tdump_command): Update.
1489         * remote.c (remote_download_command_source): Update.
1490         * python/python.c (gdbpy_eval_from_control_command)
1491         (python_command, python_interactive_command): Update.
1492         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1493         * guile/guile.c (guile_command)
1494         (gdbscm_eval_from_control_command, guile_command): Update.
1495         * compile/compile.c (compile_code_command)
1496         (compile_print_command, compile_to_object): Update.
1497         * cli/cli-script.h (struct command_lines_deleter): New.
1498         (counted_command_line): New typedef.
1499         (struct command_line): Add constructor, destructor.
1500         <body_list>: Remove.
1501         <body_list_0, body_list_1>: New members.
1502         (command_line_up): Remove typedef.
1503         (read_command_lines, read_command_lines_1, get_command_line):
1504         Update.
1505         (copy_command_lines): Don't declare.
1506         * cli/cli-script.c (build_command_line): Use "new".
1507         (get_command_line): Return counted_command_line.
1508         (print_command_lines, execute_user_command)
1509         (execute_control_command_1, while_command, if_command): Update.
1510         (realloc_body_list): Remove.
1511         (process_next_line, recurse_read_control_structure): Update.
1512         (read_command_lines, read_command_lines_1): Return counted_command_line.
1513         (free_command_lines): Use "delete".
1514         (copy_command_lines): Remove.
1515         (define_command, document_command, show_user_1): Update.
1516         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1517         a counted_command_line.
1518         * breakpoint.h (counted_command_line): Remove typedef.
1519         (breakpoint_set_commands): Update.
1520         * breakpoint.c (check_no_tracepoint_commands)
1521         (validate_commands_for_breakpoint): Update.
1522         (breakpoint_set_commands): Change commands to be a
1523         counted_command_line.
1524         (commands_command_1, update_dprintf_command_list)
1525         (create_tracepoint_from_upload): Update.
1526
1527 2018-05-04  Tom Tromey  <tom@tromey.com>
1528
1529         * cli/cli-decode.h (cmd_list_element): New constructor.
1530         (~cmd_list_element): New destructor.
1531         (struct cmd_list_element): Add initializers.
1532         * cli/cli-decode.c (do_add_cmd): Use "new".
1533         (delete_cmd): Use "delete".
1534
1535 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1536             Pedro Alves <palves@redhat.com>
1537
1538         PR breakpoints/19806 and support for PR external/20207.
1539         * NEWS: Mention Aarch64 watchpoint improvements.
1540         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1541         watchpoints and PR external/20207 watchpoints.
1542         * nat/aarch64-linux-hw-point.c
1543         (kernel_supports_any_contiguous_range): New.
1544         (aarch64_watchpoint_offset): New.
1545         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1546         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1547         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1548         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1549         next_addr_orig_p.  Support PR external/20207 watchpoints.
1550         (aarch64_downgrade_regs): New.
1551         (aarch64_dr_state_insert_one_point): New parameters offset and
1552         addr_orig.
1553         (aarch64_dr_state_remove_one_point): Likewise.
1554         (aarch64_handle_breakpoint): Update caller.
1555         (aarch64_handle_aligned_watchpoint): Likewise.
1556         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1557         aligned_offset.
1558         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1559         aarch64_downgrade_regs.
1560         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1561         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1562         (DR_CONTROL_MASK): ... this.
1563         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1564         (unsigned int aarch64_watchpoint_offset): New prototype.
1565         (aarch64_linux_set_debug_regs): Remove const from state.
1566         * utils.c (align_up, align_down): Move to ...
1567         * common/common-utils.c (align_up, align_down): ... here.
1568         * utils.h (align_up, align_down): Move to ...
1569         * common/common-utils.h (align_up, align_down): ... here.
1570
1571 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1572
1573         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1574         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1575         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1576         Re-implement to match the ABI as summarized in GCC's
1577         gcc/config/sparc/sparc.c.  All callers updated.
1578         (sparc32_store_arguments): Remove assertion.
1579
1580 2018-05-04  Tom Tromey  <tom@tromey.com>
1581
1582         * printcmd.c: Don't include tui.h.
1583         (decode_format): Use skip_spaces.
1584
1585 2018-05-04  Tom Tromey  <tom@tromey.com>
1586
1587         PR gdb/22619:
1588         * printcmd.c (last_count): New global.
1589         (x_command): Use saved count when repeating.
1590
1591 2018-05-04  Tom Tromey  <tom@tromey.com>
1592
1593         * nto-procfs.c (do_closedir_cleanup): Remove.
1594         (procfs_pidlist): Use gdb_dir_up.
1595         * procfs.c (do_closedir_cleanup): Remove.
1596         (proc_update_threads): Use gdb_dir_up.
1597         * common/filestuff.h (struct gdb_dir_deleter): New.
1598         (gdb_dir_up): New typedef.
1599
1600 2018-05-04  Tom Tromey  <tom@tromey.com>
1601
1602         * ada-lang.c (print_mention_exception): Use std::string.
1603
1604 2018-05-04  Tom Tromey  <tom@tromey.com>
1605
1606         * ada-lang.c (create_excep_cond_exprs): Update.
1607         (ada_exception_catchpoint_cond_string): Use std::string.
1608
1609 2018-05-04  Tom Tromey  <tom@tromey.com>
1610
1611         * ada-lang.c (xget_renaming_scope): Return std::string.
1612         (old_renaming_is_invisible): Update.
1613
1614 2018-05-04  Tom Tromey  <tom@tromey.com>
1615
1616         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1617         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1618
1619 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1620
1621         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1622
1623 2018-05-04  Tom Tromey  <tom@tromey.com>
1624
1625         * remote.c (remote_query_supported_append): Change type.
1626         (remote_check_symbols): Update.
1627
1628 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1629
1630         PR gdb/11420
1631         * configure.ac: Prepend libpython.
1632         * python/python-config.py: Likewise.
1633         * configure: Regenerate.
1634
1635 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1636
1637         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1638
1639 2018-05-03  Pedro Alves  <palves@redhat.com>
1640
1641         * s390-linux-nat.c
1642         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1643         override.  Write 'true' instead of '1'.
1644         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1645         declaration.
1646
1647 2018-05-02  Pedro Alves  <palves@redhat.com>
1648
1649         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1650         add_inf_child_target.
1651         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1652         add_inf_child_target.
1653         * aix-thread.c (aix_thread_target_info): New.
1654         (aix_thread_target) <shortname, longname, doc>: Delete.
1655         <info>: New.
1656         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1657         add_inf_child_target.
1658         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1659         add_inf_child_target.
1660         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1661         add_inf_child_target.
1662         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1663         add_inf_child_target.
1664         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1665         add_inf_child_target.
1666         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1667         add_inf_child_target.
1668         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1669         add_inf_child_target.
1670         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1671         add_inf_child_target.
1672         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1673         add_inf_child_target.
1674         * bfd-target.c (target_bfd_target_info): New.
1675         (target_bfd) <shortname, longname, doc>: Delete.
1676         <info>: New.
1677         * bsd-kvm.c (bsd_kvm_target_info): New.
1678         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1679         <info>: New.
1680         (bsd_kvm_target::open): Rename to ...
1681         (bsd_kvm_target_open): ... this.  Adjust.
1682         * bsd-uthread.c (bsd_uthread_target_info): New.
1683         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1684         <info>: New.
1685         * corefile.c (core_file_command): Adjust.
1686         * corelow.c (core_target_info): New.
1687         (core_target) <shortname, longname, doc>: Delete.
1688         <info>: New.
1689         (core_target::open): Rename to ...
1690         (core_target_open): ... this.  Adjust.
1691         * ctf.c (ctf_target_info): New.
1692         (ctf_target) <shortname, longname, doc>: Delete.
1693         <info>: New.
1694         (ctf_target::open): Rename to ...
1695         (ctf_target_open): ... this.
1696         (_initialize_ctf): Adjust.
1697         * exec.c (exec_target_info): New.
1698         (exec_target) <shortname, longname, doc>: Delete.
1699         <info>: New.
1700         (exec_target::open): Rename to ...
1701         (exec_target_open): ... this.
1702         * gdbcore.h (core_target_open): Declare.
1703         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1704         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1705         add_inf_child_target.
1706         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1707         add_inf_child_target.
1708         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1709         add_inf_child_target.
1710         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1711         add_inf_child_target.
1712         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1713         add_inf_child_target.
1714         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1715         add_inf_child_target.
1716         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1717         add_inf_child_target.
1718         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1719         add_inf_child_target.
1720         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1721         add_inf_child_target.
1722         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1723         add_inf_child_target.
1724         * inf-child.c (inf_child_target_info): New.
1725         (inf_child_target::info): New.
1726         (inf_child_open_target): Remove 'target' parameter.  Use
1727         get_native_target instead.
1728         (inf_child_target::open): Delete.
1729         (add_inf_child_target): New.
1730         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1731         Delete.
1732         <info>: New.
1733         (add_inf_child_target): Declare.
1734         (inf_child_open_target): Declare.
1735         * linux-thread-db.c (thread_db_target_info): New.
1736         (thread_db_target) <shortname, longname, doc>: Delete.
1737         <info>: New.
1738         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1739         add_inf_child_target.
1740         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1741         add_inf_child_target.
1742         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1743         add_inf_child_target.
1744         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1745         add_inf_child_target.
1746         * make-target-delegates (print_class): Adjust.
1747         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1748         add_inf_child_target.
1749         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1750         add_inf_child_target.
1751         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1752         add_inf_child_target.
1753         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1754         add_inf_child_target.
1755         * nto-procfs.c (nto_native_target_info): New.
1756         (nto_procfs_target_native) <shortname, longname, doc>:
1757         Delete.
1758         <info>: New.
1759         (nto_procfs_target_info): New.
1760         (nto_procfs_target_procfs) <shortname, longname, doc>:
1761         Delete.
1762         <info>: New.
1763         (init_procfs_targets): Adjust.
1764         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1765         add_inf_child_target.
1766         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1767         add_inf_child_target.
1768         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1769         add_inf_child_target.
1770         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1771         add_inf_child_target.
1772         * ravenscar-thread.c (ravenscar_target_info): New.
1773         (ravenscar_thread_target) <shortname, longname, doc>:
1774         Delete.
1775         <info>: New.
1776         * record-btrace.c (record_btrace_target_info):
1777         (record_btrace_target) <shortname, longname, doc>: Delete.
1778         <info>: New.
1779         (record_btrace_target::open): Rename to ...
1780         (record_btrace_target_open): ... this.  Adjust.
1781         * record-full.c (record_longname, record_doc): New.
1782         (record_full_base_target) <shortname, longname, doc>: Delete.
1783         <info>: New.
1784         (record_full_target_info): New.
1785         (record_full_target): <shortname>: Delete.
1786         <info>: New.
1787         (record_full_core_open_1, record_full_open_1): Update comments.
1788         (record_full_base_target::open): Rename to ...
1789         (record_full_open): ... this.
1790         (cmd_record_full_restore): Update.
1791         (_initialize_record_full): Update.
1792         * remote-sim.c (remote_sim_target_info): New.
1793         (gdbsim_target) <shortname, longname, doc>: Delete.
1794         <info>: New.
1795         (gdbsim_target::open): Rename to ...
1796         (gdbsim_target_open): ... this.
1797         (_initialize_remote_sim): Adjust.
1798         * remote.c (remote_doc): New.
1799         (remote_target_info): New.
1800         (remote_target) <shortname, longname, doc>: Delete.
1801         <info>: New.
1802         (extended_remote_target_info): New.
1803         (extended_remote_target) <shortname, longname, doc>: Delete.
1804         <info>: New.
1805         (remote_target::open_1): Make static.  Adjust.
1806         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1807         * s390-linux-nat.c (_initialize_s390_nat): Use
1808         add_inf_child_target.
1809         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1810         add_inf_child_target.
1811         * sol-thread.c (thread_db_target_info): New.
1812         (sol_thread_target) <shortname, longname, doc>: Delete.
1813         <info>: New.
1814         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1815         add_inf_child_target.
1816         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1817         add_inf_child_target.
1818         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1819         add_inf_child_target.
1820         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1821         add_inf_child_target.
1822         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1823         add_inf_child_target.
1824         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1825         add_inf_child_target.
1826         * spu-linux-nat.c (_initialize_spu_nat): Use
1827         add_inf_child_target.
1828         * spu-multiarch.c (spu_multiarch_target_info): New.
1829         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1830         <info>: New.
1831         * target-delegates.c: Regenerate.
1832         * target.c: Include <unordered_map>.
1833         (target_ops_p): Delete.
1834         (DEF_VEC_P(target_ops_p)): Delete.
1835         (target_factories): New.
1836         (test_target_info): New.
1837         (test_target_ops::info): New.
1838         (open_target): Adjust to use target_factories.
1839         (add_target_with_completer): Rename to ...
1840         (add_target): ... this.  Change prototype.  Register target_info
1841         and open callback in target_factories.  Register target_info in
1842         command context instead of target_ops.
1843         (add_target): Delete old implementation.
1844         (add_deprecated_target_alias): Change prototype.  Adjust.
1845         (the_native_target): New.
1846         (set_native_target, get_native_target): New.
1847         (find_default_run_target): Use the_native_target.
1848         (find_attach_target, find_run_target): Simplify.
1849         (target_ops::open): Delete.
1850         (dummy_target_info): New.
1851         (dummy_target::shortname, dummy_target::longname)
1852         (dummy_target::doc): Delete.
1853         (dummy_target::info): New.
1854         (debug_target::shortname, debug_target::longname)
1855         (debug_target::doc): Delete.
1856         (debug_target::info): New.
1857         * target.h (struct target_info): New.
1858         (target_ops::~target_ops): Add comment.
1859         (target_ops::info): New.
1860         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1861         longer virtual.  Implement in terms of target_info.
1862         (set_native_target, get_native_target): Declare.
1863         (target_open_ftype): New.
1864         (add_target, add_target_with_completer)
1865         (add_deprecated_target_alias): Change prototype.
1866         (test_target) <shortname, longname, doc>: Delete.
1867         <info>: New.
1868         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1869         add_inf_child_target.
1870         * tracefile-tfile.c (tfile_target_info): New.
1871         (tfile_target) <shortname, longname, doc>: Delete.
1872         <info>: New.
1873         (tfile_target::open): Rename to ...
1874         (tfile_target_open): ... this.
1875         (_initialize_tracefile_tfile): Adjust.
1876         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1877         add_inf_child_target.
1878         * windows-nat.c (_initialize_windows_nat): Use
1879         add_inf_child_target.
1880         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1881         add_inf_child_target.
1882
1883 2018-05-02  Pedro Alves  <palves@redhat.com>
1884
1885         * linux-nat.h (linux_nat_target) <low_new_thread,
1886         low_delete_thread, low_new_fork, low_forget_process,
1887         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1888         New virtual methods.
1889         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1890         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1891         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1892         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1893         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1894         Delete.
1895         * linux-fork.c (delete_fork): Adjust to call low method.
1896         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1897         (linux_nat_new_fork, linux_nat_forget_process_hook)
1898         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1899         (linux_nat_status_is_event):
1900         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1901         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1902         to call low method.
1903         (sigtrap_is_event): Rename to ...
1904         (linux_nat_target::low_status_is_event): ... this.
1905         (linux_nat_set_status_is_event): Delete.
1906         (save_stop_reason, linux_nat_wait_1)
1907         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1908         low methods.
1909         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1910         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1911         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1912         (linux_nat_set_prepare_to_resume): Delete.
1913         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1914         low virtual methods.
1915         * amd64-linux-nat.c: Likewise.
1916         * arm-linux-nat.c: Likewise.
1917         * i386-linux-nat.c: Likewise.
1918         * ia64-linux-nat.c: Likewise.
1919         * mips-linux-nat.c: Likewise.
1920         * ppc-linux-nat.c: Likewise.
1921         * s390-linux-nat.c: Likewise.
1922         * sparc64-linux-nat.c: Likewise.
1923         * x86-linux-nat.c: Likewise.
1924         * x86-linux-nat.h: Include "nat/x86-linux.h".
1925         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1926         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1927         Override methods.
1928
1929 2018-05-02  Pedro Alves  <palves@redhat.com>
1930
1931         * target.h (target_ops)
1932         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1933         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1934         stopped_by_watchpoint, have_continuable_watchpoint,
1935         stopped_data_address, watchpoint_addr_within_range,
1936         can_accel_watchpoint_condition, can_run, thread_alive,
1937         has_all_memory, has_memory, has_stack, has_registers,
1938         has_execution, can_async_p, is_async_p, supports_non_stop,
1939         always_non_stop_p, can_execute_reverse, supports_multi_process,
1940         supports_enable_disable_tracepoint,
1941         supports_disable_randomization, supports_string_tracing,
1942         supports_evaluation_of_breakpoint_conditions,
1943         can_run_breakpoint_commands, filesystem_is_local,
1944         can_download_tracepoint, get_trace_state_variable_value,
1945         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1946         record_is_replaying, record_will_replay,
1947         augmented_libraries_svr4_read>: Adjust to return bool.
1948         * aarch64-linux-nat.c: All implementations adjusted.
1949         * aix-thread.c: All implementations adjusted.
1950         * arm-linux-nat.c: All implementations adjusted.
1951         * breakpoint.c: All implementations adjusted.
1952         * bsd-kvm.c: All implementations adjusted.
1953         * bsd-uthread.c: All implementations adjusted.
1954         * corelow.c: All implementations adjusted.
1955         * ctf.c: All implementations adjusted.
1956         * darwin-nat.c: All implementations adjusted.
1957         * darwin-nat.h: All implementations adjusted.
1958         * exec.c: All implementations adjusted.
1959         * fbsd-nat.c: All implementations adjusted.
1960         * fbsd-nat.h: All implementations adjusted.
1961         * gnu-nat.c: All implementations adjusted.
1962         * gnu-nat.h: All implementations adjusted.
1963         * go32-nat.c: All implementations adjusted.
1964         * ia64-linux-nat.c: All implementations adjusted.
1965         * inf-child.c: All implementations adjusted.
1966         * inf-child.h: All implementations adjusted.
1967         * inf-ptrace.c: All implementations adjusted.
1968         * inf-ptrace.h: All implementations adjusted.
1969         * linux-nat.c: All implementations adjusted.
1970         * linux-nat.h: All implementations adjusted.
1971         * mips-linux-nat.c: All implementations adjusted.
1972         * nto-procfs.c: All implementations adjusted.
1973         * ppc-linux-nat.c: All implementations adjusted.
1974         * procfs.c: All implementations adjusted.
1975         * ravenscar-thread.c: All implementations adjusted.
1976         * record-btrace.c: All implementations adjusted.
1977         * record-full.c: All implementations adjusted.
1978         * remote-sim.c: All implementations adjusted.
1979         * remote.c: All implementations adjusted.
1980         * s390-linux-nat.c: All implementations adjusted.
1981         * sol-thread.c: All implementations adjusted.
1982         * spu-multiarch.c: All implementations adjusted.
1983         * target-delegates.c: All implementations adjusted.
1984         * target.c: All implementations adjusted.
1985         * target.h: All implementations adjusted.
1986         * tracefile-tfile.c: All implementations adjusted.
1987         * tracefile.c: All implementations adjusted.
1988         * tracefile.h: All implementations adjusted.
1989         * windows-nat.c: All implementations adjusted.
1990         * x86-linux-nat.h: All implementations adjusted.
1991         * x86-nat.h: All implementations adjusted.
1992
1993 2018-05-02  Pedro Alves  <palves@redhat.com>
1994
1995         * make-target-delegates (scan_target_h): Don't trim lines here.
1996         Replace sequences of tabs and/or whitespace with a single
1997         whitespace.
1998         (top level, parsing methods): Trim each line before processing it
1999         here.
2000
2001 2018-05-02  Pedro Alves  <palves@redhat.com>
2002             John Baldwin  <jhb@freebsd.org>
2003
2004         * target.h (enum strata) <debug_stratum>: New.
2005         (struct target_ops) <all delegation methods>: Replace by C++
2006         virtual methods, and drop "to_" prefix.  All references updated
2007         throughout.
2008         <to_shortname, to_longname, to_doc, to_data,
2009         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
2010         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
2011         virtual methods.  All references updated throughout.
2012         <can_attach, supports_terminal_ours, can_create_inferior,
2013         get_thread_control_capabilities, attach_no_wait>: New
2014         virtual methods.
2015         <insert_breakpoint, remove_breakpoint>: Now
2016         TARGET_DEFAULT_NORETURN methods.
2017         <info_proc>: Now returns bool.
2018         <to_magic>: Delete.
2019         (OPS_MAGIC): Delete.
2020         (current_target): Delete.  All references replaced by references
2021         to ...
2022         (target_stack): ... this.  New.
2023         (target_shortname, target_longname): Adjust.
2024         (target_can_run): Now a function declaration.
2025         (default_child_has_all_memory, default_child_has_memory)
2026         (default_child_has_stack, default_child_has_registers)
2027         (default_child_has_execution): Remove target_ops parameter.
2028         (complete_target_initialization): Delete.
2029         (memory_breakpoint_target): New template class.
2030         (test_target_ops): Refactor as a C++ class with virtual methods.
2031         * make-target-delegates (NAME_PART): Tighten.
2032         (POINTER_PART, CP_SYMBOL): New.
2033         (SIMPLE_RETURN_PART): Reimplement.
2034         (VEC_RETURN_PART): Expect less.
2035         (RETURN_PART, VIRTUAL_PART): New.
2036         (METHOD): Adjust to C++ virtual methods.
2037         (scan_target_h): Remove reference to C99.
2038         (dname): Output "target_ops::" prefix.
2039         (write_function_header): Adjust to output a C++ class method.
2040         (write_declaration): New.
2041         (write_delegator): Adjust to output a C++ class method.
2042         (tdname): Output "dummy_target::" prefix.
2043         (write_tdefault, write_debugmethod): Adjust to output a C++ class
2044         method.
2045         (tdefault_names, debug_names): Delete.
2046         (return_types, tdefaults, styles, argtypes_array): New.
2047         (top level): All methods are delegators.
2048         (print_class): New.
2049         (top level): Print dummy_target and debug_target classes.
2050         * target-delegates.c: Regenerate.
2051         * target-debug.h (target_debug_print_enum_info_proc_what)
2052         (target_debug_print_thread_control_capabilities)
2053         (target_debug_print_thread_info_p): New.
2054         * target.c (dummy_target): Delete.
2055         (the_dummy_target, the_debug_target): New.
2056         (target_stack): Now extern.
2057         (set_targetdebug): Push/unpush debug target.
2058         (default_child_has_all_memory, default_child_has_memory)
2059         (default_child_has_stack, default_child_has_registers)
2060         (default_child_has_execution): Remove target_ops parameter.
2061         (complete_target_initialization): Delete.
2062         (add_target_with_completer): No longer call
2063         complete_target_initialization.
2064         (target_supports_terminal_ours): Use regular delegation.
2065         (update_current_target): Delete.
2066         (push_target): No longer check magic number.  Don't call
2067         update_current_target.
2068         (unpush_target): Don't call update_current_target.
2069         (target_is_pushed): No longer check magic number.
2070         (target_require_runnable): Skip for all stratums over
2071         process_stratum.
2072         (target_ops::info_proc): New.
2073         (target_info_proc): Use find_target_at and
2074         find_default_run_target.
2075         (target_supports_disable_randomization): Use regular delegation.
2076         (target_get_osdata): Use find_target_at.
2077         (target_ops::open, target_ops::close, target_ops::can_attach)
2078         (target_ops::attach, target_ops::can_create_inferior)
2079         (target_ops::create_inferior, target_ops::can_run)
2080         (target_can_run): New.
2081         (default_fileio_target): Use regular delegation.
2082         (target_ops::fileio_open, target_ops::fileio_pwrite)
2083         (target_ops::fileio_pread, target_ops::fileio_fstat)
2084         (target_ops::fileio_close, target_ops::fileio_unlink)
2085         (target_ops::fileio_readlink): New.
2086         (target_fileio_open_1, target_fileio_unlink)
2087         (target_fileio_readlink): Always call the target method.  Handle
2088         FILEIO_ENOSYS.
2089         (return_zero, return_zero_has_execution): Delete.
2090         (init_dummy_target): Delete.
2091         (dummy_target::dummy_target, dummy_target::shortname)
2092         (dummy_target::longname, dummy_target::doc)
2093         (debug_target::debug_target, debug_target::shortname)
2094         (debug_target::longname, debug_target::doc): New.
2095         (target_supports_delete_record): Use regular delegation.
2096         (setup_target_debug): Delete.
2097         (maintenance_print_target_stack): Skip debug_stratum.
2098         (initialize_targets): Instantiate the_dummy_target and
2099         the_debug_target.
2100         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
2101         use target_stack.
2102         (target_auxv_search, fprint_target_auxv): Adjust.
2103         (info_auxv_command): Adjust to use target_stack.
2104         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
2105         * exceptions.c (print_flush): Handle a NULL target_stack.
2106         * regcache.c (target_ops_no_register): Refactor as class with
2107         virtual methods.
2108
2109         * exec.c (exec_target): New class.
2110         (exec_ops): Now an exec_target.
2111         (exec_open, exec_close_1, exec_get_section_table)
2112         (exec_xfer_partial, exec_files_info, exec_has_memory)
2113         (exec_make_note_section): Refactor as exec_target methods.
2114         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
2115         Delete.
2116         (exec_target::find_memory_regions): New.
2117         (_initialize_exec): Don't call init_exec_ops.
2118         * gdbcore.h (exec_file_clear): Delete.
2119
2120         * corefile.c (core_target): Delete.
2121         (core_file_command): Adjust.
2122         * corelow.c (core_target): New class.
2123         (the_core_target): New.
2124         (core_close): Remove target_ops parameter.
2125         (core_close_cleanup): Adjust.
2126         (core_target::close): New.
2127         (core_open, core_detach, get_core_registers, core_files_info)
2128         (core_xfer_partial, core_thread_alive, core_read_description)
2129         (core_pid_to_str, core_thread_name, core_has_memory)
2130         (core_has_stack, core_has_registers, core_info_proc): Rework as
2131         core_target methods.
2132         (ignore, core_remove_breakpoint, init_core_ops): Delete.
2133         (_initialize_corelow): Initialize the_core_target.
2134         * gdbcore.h (core_target): Delete.
2135         (the_core_target): New.
2136
2137         * ctf.c: (ctf_target): New class.
2138         (ctf_ops): Now a ctf_target.
2139         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
2140         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
2141         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
2142         methods.
2143         (init_ctf_ops): Delete.
2144         (_initialize_ctf): Don't call it.
2145         * tracefile-tfile.c (tfile_target): New class.
2146         (tfile_ops): Now a tfile_target.
2147         (tfile_open, tfile_close, tfile_files_info)
2148         (tfile_get_tracepoint_status, tfile_trace_find)
2149         (tfile_fetch_registers, tfile_xfer_partial)
2150         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
2151         Refactor as tfile_target methods.
2152         (tfile_xfer_partial_features): Remove target_ops parameter.
2153         (init_tfile_ops): Delete.
2154         (_initialize_tracefile_tfile): Don't call it.
2155         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
2156         (tracefile_has_stack, tracefile_has_registers)
2157         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
2158         tracefile_target methods.
2159         (init_tracefile_ops): Delete.
2160         (tracefile_target::tracefile_target): New.
2161         * tracefile.h: Include "target.h".
2162         (tracefile_target): New class.
2163         (init_tracefile_ops): Delete.
2164
2165         * spu-multiarch.c (spu_multiarch_target): New class.
2166         (spu_ops): Now a spu_multiarch_target.
2167         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
2168         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
2169         (spu_search_memory, spu_mourn_inferior): Refactor as
2170         spu_multiarch_target methods.
2171         (init_spu_ops): Delete.
2172         (_initialize_spu_multiarch): Remove references to init_spu_ops,
2173         complete_target_initialization.
2174
2175         * ravenscar-thread.c (ravenscar_thread_target): New class.
2176         (ravenscar_ops): Now a ravenscar_thread_target.
2177         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
2178         (ravenscar_thread_alive, ravenscar_pid_to_str)
2179         (ravenscar_fetch_registers, ravenscar_store_registers)
2180         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
2181         (ravenscar_stopped_by_hw_breakpoint)
2182         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
2183         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
2184         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
2185         methods.
2186         (init_ravenscar_thread_ops): Delete.
2187         (_initialize_ravenscar): Remove references to
2188         init_ravenscar_thread_ops and complete_target_initialization.
2189
2190         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
2191         (bsd_uthread_target): New class.
2192         (bsd_uthread_ops): Now a bsd_uthread_target.
2193         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
2194         (bsd_uthread_close, bsd_uthread_mourn_inferior)
2195         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
2196         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
2197         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
2198         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
2199         (bsd_uthread_target): Delete function.
2200         (_initialize_bsd_uthread): Remove reference to
2201         complete_target_initialization.
2202
2203         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
2204         (target_bfd): ... this new class.
2205         (target_bfd_xfer_partial, target_bfd_get_section_table)
2206         (target_bfd_close): Refactor as target_bfd methods.
2207         (target_bfd::~target_bfd): New.
2208         (target_bfd_reopen): Adjust.
2209         (target_bfd::close): New.
2210
2211         * record-btrace.c (record_btrace_target): New class.
2212         (record_btrace_ops): Now a record_btrace_target.
2213         (record_btrace_open, record_btrace_stop_recording)
2214         (record_btrace_disconnect, record_btrace_close)
2215         (record_btrace_async, record_btrace_info)
2216         (record_btrace_insn_history, record_btrace_insn_history_range)
2217         (record_btrace_insn_history_from, record_btrace_call_history)
2218         (record_btrace_call_history_range)
2219         (record_btrace_call_history_from, record_btrace_record_method)
2220         (record_btrace_is_replaying, record_btrace_will_replay)
2221         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
2222         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
2223         (record_btrace_store_registers, record_btrace_prepare_to_store)
2224         (record_btrace_to_get_unwinder)
2225         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
2226         (record_btrace_commit_resume, record_btrace_wait)
2227         (record_btrace_stop, record_btrace_can_execute_reverse)
2228         (record_btrace_stopped_by_sw_breakpoint)
2229         (record_btrace_supports_stopped_by_sw_breakpoint)
2230         (record_btrace_stopped_by_hw_breakpoint)
2231         (record_btrace_supports_stopped_by_hw_breakpoint)
2232         (record_btrace_update_thread_list, record_btrace_thread_alive)
2233         (record_btrace_goto_begin, record_btrace_goto_end)
2234         (record_btrace_goto, record_btrace_stop_replaying_all)
2235         (record_btrace_execution_direction)
2236         (record_btrace_prepare_to_generate_core)
2237         (record_btrace_done_generating_core): Refactor as
2238         record_btrace_target methods.
2239         (init_record_btrace_ops): Delete.
2240         (_initialize_record_btrace): Remove reference to
2241         init_record_btrace_ops.
2242         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
2243         the execution_direction global.
2244         (record_full_base_target, record_full_target)
2245         (record_full_core_target): New classes.
2246         (record_full_ops): Now a record_full_target.
2247         (record_full_core_ops): Now a record_full_core_target.
2248         (record_full_target::detach, record_full_target::disconnect)
2249         (record_full_core_target::disconnect)
2250         (record_full_target::mourn_inferior, record_full_target::kill):
2251         New.
2252         (record_full_open, record_full_close, record_full_async): Refactor
2253         as methods of the record_full_base_target class.
2254         (record_full_resume, record_full_commit_resume): Refactor
2255         as methods of the record_full_target class.
2256         (record_full_wait, record_full_stopped_by_watchpoint)
2257         (record_full_stopped_data_address)
2258         (record_full_stopped_by_sw_breakpoint)
2259         (record_full_supports_stopped_by_sw_breakpoint)
2260         (record_full_stopped_by_hw_breakpoint)
2261         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
2262         methods of the record_full_base_target class.
2263         (record_full_store_registers, record_full_xfer_partial)
2264         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2265         Refactor as methods of the record_full_target class.
2266         (record_full_can_execute_reverse, record_full_get_bookmark)
2267         (record_full_goto_bookmark, record_full_execution_direction)
2268         (record_full_record_method, record_full_info, record_full_delete)
2269         (record_full_is_replaying, record_full_will_replay)
2270         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2271         (record_full_stop_replaying): Refactor as methods of the
2272         record_full_base_target class.
2273         (record_full_core_resume, record_full_core_kill)
2274         (record_full_core_fetch_registers)
2275         (record_full_core_prepare_to_store)
2276         (record_full_core_store_registers, record_full_core_xfer_partial)
2277         (record_full_core_insert_breakpoint)
2278         (record_full_core_remove_breakpoint)
2279         (record_full_core_has_execution): Refactor
2280         as methods of the record_full_core_target class.
2281         (record_full_base_target::supports_delete_record): New.
2282         (init_record_full_ops): Delete.
2283         (init_record_full_core_ops): Delete.
2284         (record_full_save): Refactor as method of the
2285         record_full_base_target class.
2286         (_initialize_record_full): Remove references to
2287         init_record_full_ops and init_record_full_core_ops.
2288
2289         * remote.c (remote_target, extended_remote_target): New classes.
2290         (remote_ops): Now a remote_target.
2291         (extended_remote_ops): Now an extended_remote_target.
2292         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2293         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2294         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2295         (remote_pass_signals, remote_set_syscall_catchpoint)
2296         (remote_program_signals, )
2297         (remote_thread_always_alive): Remove target_ops parameter.
2298         (remote_thread_alive, remote_thread_name)
2299         (remote_update_thread_list, remote_threads_extra_info)
2300         (remote_static_tracepoint_marker_at)
2301         (remote_static_tracepoint_markers_by_strid)
2302         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2303         (remote_open): Refactor as methods of remote_target.
2304         (extended_remote_open, extended_remote_detach)
2305         (extended_remote_attach, extended_remote_post_attach):
2306         (extended_remote_supports_disable_randomization)
2307         (extended_remote_create_inferior): : Refactor as method of
2308         extended_remote_target.
2309         (remote_set_permissions, remote_open_1, remote_detach)
2310         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2311         (remote_resume, remote_commit_resume, remote_stop)
2312         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2313         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2314         (remote_prepare_to_store, remote_store_registers)
2315         (remote_flash_erase, remote_flash_done, remote_files_info)
2316         (remote_kill, remote_mourn, remote_insert_breakpoint)
2317         (remote_remove_breakpoint, remote_insert_watchpoint)
2318         (remote_watchpoint_addr_within_range)
2319         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2320         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2321         (remote_supports_stopped_by_sw_breakpoint)
2322         (remote_stopped_by_hw_breakpoint)
2323         (remote_supports_stopped_by_hw_breakpoint)
2324         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2325         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2326         (remote_verify_memory): Refactor as methods of remote_target.
2327         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2328         parameter.
2329         (remote_xfer_partial, remote_get_memory_xfer_limit)
2330         (remote_search_memory, remote_rcmd, remote_memory_map)
2331         (remote_pid_to_str, remote_get_thread_local_address)
2332         (remote_get_tib_address, remote_read_description): Refactor as
2333         methods of remote_target.
2334         (remote_target::fileio_open, remote_target::fileio_pwrite)
2335         (remote_target::fileio_pread, remote_target::fileio_close): New.
2336         (remote_hostio_readlink, remote_hostio_fstat)
2337         (remote_filesystem_is_local, remote_can_execute_reverse)
2338         (remote_supports_non_stop, remote_supports_disable_randomization)
2339         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2340         (remote_supports_enable_disable_tracepoint)
2341         (remote_supports_string_tracing)
2342         (remote_can_run_breakpoint_commands, remote_trace_init)
2343         (remote_download_tracepoint, remote_can_download_tracepoint)
2344         (remote_download_trace_state_variable, remote_enable_tracepoint)
2345         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2346         (remote_trace_start, remote_get_trace_status)
2347         (remote_get_tracepoint_status, remote_trace_stop)
2348         (remote_trace_find, remote_get_trace_state_variable_value)
2349         (remote_save_trace_data, remote_get_raw_trace_data)
2350         (remote_set_disconnected_tracing, remote_core_of_thread)
2351         (remote_set_circular_trace_buffer, remote_traceframe_info)
2352         (remote_get_min_fast_tracepoint_insn_len)
2353         (remote_set_trace_buffer_size, remote_set_trace_notes)
2354         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2355         (remote_disable_btrace, remote_teardown_btrace)
2356         (remote_read_btrace, remote_btrace_conf)
2357         (remote_augmented_libraries_svr4_read, remote_load)
2358         (remote_pid_to_exec_file, remote_can_do_single_step)
2359         (remote_execution_direction, remote_thread_handle_to_thread_info):
2360         Refactor as methods of remote_target.
2361         (init_remote_ops, init_extended_remote_ops): Delete.
2362         (remote_can_async_p, remote_is_async_p, remote_async)
2363         (remote_thread_events, remote_upload_tracepoints)
2364         (remote_upload_trace_state_variables): Refactor as methods of
2365         remote_target.
2366         (_initialize_remote): Remove references to init_remote_ops and
2367         init_extended_remote_ops.
2368
2369         * remote-sim.c (gdbsim_target): New class.
2370         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2371         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2372         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2373         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2374         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2375         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2376         Refactor as methods of gdbsim_target.
2377         (gdbsim_ops): Now a gdbsim_target.
2378         (init_gdbsim_ops): Delete.
2379         (gdbsim_cntrl_c): Adjust.
2380         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2381
2382         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2383         (the_amd64_linux_nat_target): New.
2384         (amd64_linux_fetch_inferior_registers)
2385         (amd64_linux_store_inferior_registers): Refactor as methods of
2386         amd64_linux_nat_target.
2387         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2388         * i386-linux-nat.c: Don't include "linux-nat.h".
2389         (i386_linux_nat_target): New class.
2390         (the_i386_linux_nat_target): New.
2391         (i386_linux_fetch_inferior_registers)
2392         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2393         as methods of i386_linux_nat_target.
2394         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2395         * inf-child.c (inf_child_ops): Delete.
2396         (inf_child_fetch_inferior_registers)
2397         (inf_child_store_inferior_registers): Delete.
2398         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2399         methods of inf_child_target.
2400         (inf_child_target::supports_terminal_ours)
2401         (inf_child_target::terminal_init)
2402         (inf_child_target::terminal_inferior)
2403         (inf_child_target::terminal_ours_for_output)
2404         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2405         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2406         New.
2407         (inf_child_open, inf_child_disconnect, inf_child_close)
2408         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2409         (inf_child_post_startup_inferior, inf_child_can_run)
2410         (inf_child_pid_to_exec_file): Refactor as methods of
2411         inf_child_target.
2412         (inf_child_follow_fork): Delete.
2413         (inf_child_target::can_create_inferior)
2414         (inf_child_target::can_attach): New.
2415         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2416         (inf_child_target::has_stack, inf_child_target::has_registers)
2417         (inf_child_target::has_execution): New.
2418         (inf_child_fileio_open, inf_child_fileio_pwrite)
2419         (inf_child_fileio_pread, inf_child_fileio_fstat)
2420         (inf_child_fileio_close, inf_child_fileio_unlink)
2421         (inf_child_fileio_readlink, inf_child_use_agent)
2422         (inf_child_can_use_agent): Refactor as methods of
2423         inf_child_target.
2424         (return_zero, inf_child_target): Delete.
2425         (inf_child_target::inf_child_target): New.
2426         * inf-child.h: Include "target.h".
2427         (inf_child_target): Delete function prototype.
2428         (inf_child_target): New class.
2429         (inf_child_open_target, inf_child_mourn_inferior)
2430         (inf_child_maybe_unpush_target): Delete.
2431         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2432         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2433         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2434         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2435         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2436         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2437         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2438         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2439         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2440         methods of inf_ptrace_target.
2441         (inf_ptrace_target): Delete function.
2442         * inf-ptrace.h: Include "inf-child.h".
2443         (inf_ptrace_target): Delete function declaration.
2444         (inf_ptrace_target): New class.
2445         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
2446         * linux-nat.c (linux_target): New.
2447         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
2448         (linux_nat_target::~linux_nat_target): New.
2449         (linux_child_post_attach, linux_child_post_startup_inferior)
2450         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
2451         (linux_child_remove_fork_catchpoint)
2452         (linux_child_insert_vfork_catchpoint)
2453         (linux_child_remove_vfork_catchpoint)
2454         (linux_child_insert_exec_catchpoint)
2455         (linux_child_remove_exec_catchpoint)
2456         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
2457         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
2458         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
2459         (linux_nat_stopped_data_address)
2460         (linux_nat_stopped_by_sw_breakpoint)
2461         (linux_nat_supports_stopped_by_sw_breakpoint)
2462         (linux_nat_stopped_by_hw_breakpoint)
2463         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
2464         (linux_nat_kill, linux_nat_mourn_inferior)
2465         (linux_nat_xfer_partial, linux_nat_thread_alive)
2466         (linux_nat_update_thread_list, linux_nat_pid_to_str)
2467         (linux_nat_thread_name, linux_child_pid_to_exec_file)
2468         (linux_child_static_tracepoint_markers_by_strid)
2469         (linux_nat_is_async_p, linux_nat_can_async_p)
2470         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
2471         (linux_nat_supports_multi_process)
2472         (linux_nat_supports_disable_randomization, linux_nat_async)
2473         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
2474         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
2475         (linux_nat_fileio_open, linux_nat_fileio_readlink)
2476         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
2477         methods of linux_nat_target.
2478         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
2479         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
2480         parameter.
2481         (check_stopped_by_watchpoint): Adjust.
2482         (linux_xfer_partial): Delete.
2483         (linux_target_install_ops, linux_target, linux_nat_add_target):
2484         Delete.
2485         (linux_nat_target::linux_nat_target): New.
2486         * linux-nat.h: Include "inf-ptrace.h".
2487         (linux_nat_target): New.
2488         (linux_target, linux_target_install_ops, linux_nat_add_target):
2489         Delete function declarations.
2490         (linux_target): Declare global.
2491         * linux-thread-db.c (thread_db_target): New.
2492         (thread_db_target::thread_db_target): New.
2493         (thread_db_ops): Delete.
2494         (the_thread_db_target): New.
2495         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2496         (thread_db_update_thread_list, thread_db_pid_to_str)
2497         (thread_db_extra_thread_info)
2498         (thread_db_thread_handle_to_thread_info)
2499         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2500         (thread_db_resume): Refactor as methods of thread_db_target.
2501         (init_thread_db_ops): Delete.
2502         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2503         * x86-linux-nat.c: Don't include "linux-nat.h".
2504         (super_post_startup_inferior): Delete.
2505         (x86_linux_nat_target::~x86_linux_nat_target): New.
2506         (x86_linux_child_post_startup_inferior)
2507         (x86_linux_read_description, x86_linux_enable_btrace)
2508         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2509         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2510         methods of x86_linux_nat_target.
2511         (x86_linux_create_target): Delete.  Bits folded ...
2512         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2513         pointer.
2514         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2515         (x86_linux_nat_target): New class.
2516         (x86_linux_create_target): Delete.
2517         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2518         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2519         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2520         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2521         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2522         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2523         make extern.
2524         (x86_use_watchpoints): Delete.
2525         * x86-nat.h: Include "breakpoint.h" and "target.h".
2526         (x86_use_watchpoints): Delete.
2527         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2528         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2529         (x86_insert_watchpoint, x86_remove_watchpoint)
2530         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2531         (x86_stopped_by_hw_breakpoint): New declarations.
2532         (x86_nat_target): New template class.
2533
2534         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2535         (the_ppc_linux_nat_target): New.
2536         (ppc_linux_fetch_inferior_registers)
2537         (ppc_linux_can_use_hw_breakpoint)
2538         (ppc_linux_region_ok_for_hw_watchpoint)
2539         (ppc_linux_ranged_break_num_registers)
2540         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2541         (ppc_linux_insert_mask_watchpoint)
2542         (ppc_linux_remove_mask_watchpoint)
2543         (ppc_linux_can_accel_watchpoint_condition)
2544         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2545         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2546         (ppc_linux_watchpoint_addr_within_range)
2547         (ppc_linux_masked_watch_num_registers)
2548         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2549         (ppc_linux_read_description): Refactor as methods of
2550         ppc_linux_nat_target.
2551         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2552
2553         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2554         (procfs_target): New class.
2555         (the_procfs_target): New.
2556         (procfs_target): Delete function.
2557         (procfs_auxv_parse, procfs_attach, procfs_detach)
2558         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2559         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2560         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2561         (procfs_create_inferior, procfs_update_thread_list)
2562         (procfs_thread_alive, procfs_pid_to_str)
2563         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2564         (procfs_stopped_data_address, procfs_insert_watchpoint)
2565         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2566         (proc_find_memory_regions, procfs_info_proc)
2567         (procfs_make_note_section): Refactor as methods of procfs_target.
2568         (_initialize_procfs): Adjust.
2569         * sol-thread.c (sol_thread_target): New class.
2570         (sol_thread_ops): Now a sol_thread_target.
2571         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2572         (sol_thread_fetch_registers, sol_thread_store_registers)
2573         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2574         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2575         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2576         (init_sol_thread_ops): Delete.
2577         (_initialize_sol_thread): Adjust.  Remove references to
2578         init_sol_thread_ops and complete_target_initialization.
2579
2580         * windows-nat.c (windows_nat_target): New class.
2581         (windows_fetch_inferior_registers)
2582         (windows_store_inferior_registers, windows_resume, windows_wait)
2583         (windows_attach, windows_detach, windows_pid_to_exec_file)
2584         (windows_files_info, windows_create_inferior)
2585         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2586         (windows_close, windows_pid_to_str, windows_xfer_partial)
2587         (windows_get_tib_address, windows_get_ada_task_ptid)
2588         (windows_thread_name, windows_thread_alive): Refactor as
2589         windows_nat_target methods.
2590         (do_initial_windows_stuff): Adjust.
2591         (windows_target): Delete function.
2592         (_initialize_windows_nat): Adjust.
2593
2594         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2595         (darwin_mourn_inferior, darwin_kill_inferior)
2596         (darwin_create_inferior, darwin_attach, darwin_detach)
2597         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2598         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2599         (darwin_supports_multi_process): Refactor as darwin_nat_target
2600         methods.
2601         (darwin_resume_to, darwin_files_info): Delete.
2602         (_initialize_darwin_inferior): Rename to ...
2603         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2604         * darwin-nat.h: Include "inf-child.h".
2605         (darwin_nat_target): New class.
2606         (darwin_complete_target): Delete.
2607         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2608         (darwin_target): New.
2609         (i386_darwin_fetch_inferior_registers)
2610         (i386_darwin_store_inferior_registers): Refactor as methods of
2611         darwin_nat_target.
2612         (darwin_complete_target): Delete, with ...
2613         (_initialize_i386_darwin_nat): ... bits factored out here.
2614
2615         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2616         (the_alpha_linux_nat_target): New.
2617         (alpha_linux_register_u_offset): Refactor as
2618         alpha_linux_nat_target method.
2619         (_initialize_alpha_linux_nat): Adjust.
2620         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2621         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2622         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2623         methods of linux_nat_trad_target.
2624         (linux_trad_target): Delete.
2625         * linux-nat-trad.h (linux_trad_target): Delete function.
2626         (linux_nat_trad_target): New class.
2627         * mips-linux-nat.c (mips_linux_nat_target): New class.
2628         (super_fetch_registers, super_store_registers, super_close):
2629         Delete.
2630         (the_mips_linux_nat_target): New.
2631         (mips64_linux_regsets_fetch_registers)
2632         (mips64_linux_regsets_store_registers)
2633         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2634         (mips_linux_register_u_offset, mips_linux_read_description)
2635         (mips_linux_can_use_hw_breakpoint)
2636         (mips_linux_stopped_by_watchpoint)
2637         (mips_linux_stopped_data_address)
2638         (mips_linux_region_ok_for_hw_watchpoint)
2639         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2640         (mips_linux_close): Refactor as methods of mips_linux_nat.
2641         (_initialize_mips_linux_nat): Adjust to C++ification.
2642
2643         * aix-thread.c (aix_thread_target): New class.
2644         (aix_thread_ops): Now an aix_thread_target.
2645         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2646         (aix_thread_fetch_registers, aix_thread_store_registers)
2647         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2648         (aix_thread_thread_alive, aix_thread_pid_to_str)
2649         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2650         Refactor as methods of aix_thread_target.
2651         (init_aix_thread_ops): Delete.
2652         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2653         and complete_target_initialization.
2654         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2655         (rs6000_nat_target): New class.
2656         (the_rs6000_nat_target): New.
2657         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2658         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2659         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2660         (super_create_inferior): Delete.
2661         (_initialize_rs6000_nat): Adjust to C++ification.
2662
2663         * arm-linux-nat.c (arm_linux_nat_target): New class.
2664         (the_arm_linux_nat_target): New.
2665         (arm_linux_fetch_inferior_registers)
2666         (arm_linux_store_inferior_registers, arm_linux_read_description)
2667         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2668         (arm_linux_remove_hw_breakpoint)
2669         (arm_linux_region_ok_for_hw_watchpoint)
2670         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2671         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2672         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2673         arm_linux_nat_target.
2674         (_initialize_arm_linux_nat): Adjust to C++ification.
2675
2676         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2677         (the_aarch64_linux_nat_target): New.
2678         (aarch64_linux_fetch_inferior_registers)
2679         (aarch64_linux_store_inferior_registers)
2680         (aarch64_linux_child_post_startup_inferior)
2681         (aarch64_linux_read_description)
2682         (aarch64_linux_can_use_hw_breakpoint)
2683         (aarch64_linux_insert_hw_breakpoint)
2684         (aarch64_linux_remove_hw_breakpoint)
2685         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2686         (aarch64_linux_region_ok_for_hw_watchpoint)
2687         (aarch64_linux_stopped_data_address)
2688         (aarch64_linux_stopped_by_watchpoint)
2689         (aarch64_linux_watchpoint_addr_within_range)
2690         (aarch64_linux_can_do_single_step): Refactor as methods of
2691         aarch64_linux_nat_target.
2692         (super_post_startup_inferior): Delete.
2693         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2694
2695         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2696         (the_hppa_linux_nat_target): New.
2697         (hppa_linux_fetch_inferior_registers)
2698         (hppa_linux_store_inferior_registers): Refactor as methods of
2699         hppa_linux_nat_target.
2700         (_initialize_hppa_linux_nat): Adjust to C++ification.
2701
2702         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2703         (the_ia64_linux_nat_target): New.
2704         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2705         (ia64_linux_stopped_data_address)
2706         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2707         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2708         ia64_linux_nat_target methods.
2709         (super_xfer_partial): Delete.
2710         (_initialize_ia64_linux_nat): Adjust to C++ification.
2711
2712         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2713         (the_m32r_linux_nat_target): New.
2714         (m32r_linux_fetch_inferior_registers)
2715         (m32r_linux_store_inferior_registers): Refactor as
2716         m32r_linux_nat_target methods.
2717         (_initialize_m32r_linux_nat): Adjust to C++ification.
2718
2719         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2720         (the_m68k_linux_nat_target): New.
2721         (m68k_linux_fetch_inferior_registers)
2722         (m68k_linux_store_inferior_registers): Refactor as
2723         m68k_linux_nat_target methods.
2724         (_initialize_m68k_linux_nat): Adjust to C++ification.
2725
2726         * s390-linux-nat.c (s390_linux_nat_target): New class.
2727         (the_s390_linux_nat_target): New.
2728         (s390_linux_fetch_inferior_registers)
2729         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2730         (s390_insert_watchpoint, s390_remove_watchpoint)
2731         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2732         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2733         (s390_auxv_parse, s390_read_description): Refactor as methods of
2734         s390_linux_nat_target.
2735         (_initialize_s390_nat): Adjust to C++ification.
2736
2737         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2738         (the_sparc_linux_nat_target): New.
2739         (_initialize_sparc_linux_nat): Adjust to C++ification.
2740         * sparc-nat.c (sparc_fetch_inferior_registers)
2741         (sparc_store_inferior_registers): Remove target_ops parameter.
2742         * sparc-nat.h (sparc_fetch_inferior_registers)
2743         (sparc_store_inferior_registers): Remove target_ops parameter.
2744         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2745         (the_sparc64_linux_nat_target): New.
2746         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2747
2748         * spu-linux-nat.c (spu_linux_nat_target): New class.
2749         (the_spu_linux_nat_target): New.
2750         (spu_child_post_startup_inferior, spu_child_post_attach)
2751         (spu_child_wait, spu_fetch_inferior_registers)
2752         (spu_store_inferior_registers, spu_xfer_partial)
2753         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2754         methods.
2755         (_initialize_spu_nat): Adjust to C++ification.
2756
2757         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2758         (the_tilegx_linux_nat_target): New.
2759         (fetch_inferior_registers, store_inferior_registers):
2760         Refactor as methods.
2761         (_initialize_tile_linux_nat): Adjust to C++ification.
2762
2763         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2764         (the_xtensa_linux_nat_target): New.
2765         (xtensa_linux_fetch_inferior_registers)
2766         (xtensa_linux_store_inferior_registers): Refactor as
2767         xtensa_linux_nat_target methods.
2768         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2769
2770         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2771         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2772         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2773         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2774         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2775         (fbsd_stopped_by_sw_breakpoint)
2776         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2777         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2778         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2779         (fbsd_post_startup_inferior, fbsd_post_attach)
2780         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2781         (fbsd_set_syscall_catchpoint)
2782         (super_xfer_partial, super_resume, super_wait)
2783         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2784         (fbsd_handle_debug_trap): Remove target_ops parameter.
2785         (fbsd_nat_add_target): Delete.
2786         * fbsd-nat.h: Include "inf-ptrace.h".
2787         (fbsd_nat_add_target): Delete.
2788         (USE_SIGTRAP_SIGINFO): Define.
2789         (fbsd_nat_target): New class.
2790
2791         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2792         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2793         (amd64bsd_target): Delete.
2794         * amd64-bsd-nat.h: New file.
2795         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2796         "x86-bsd-nat.h".
2797         (amd64_fbsd_nat_target): New class.
2798         (the_amd64_fbsd_nat_target): New.
2799         (amd64fbsd_read_description): Refactor as method of
2800         amd64_fbsd_nat_target.
2801         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2802         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2803         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2804         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2805         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2806         (i386bsd_target): Delete.
2807         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2808         (i386bsd_fetch_inferior_registers)
2809         (i386bsd_store_inferior_registers): Declare.
2810         (i386_bsd_nat_target): New class.
2811         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2812         (the_i386_fbsd_nat_target): New.
2813         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2814         i386_fbsd_nat_target methods.
2815         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2816         (_initialize_i386fbsd_nat): Adjust to C++ification.
2817         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2818         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2819         (_initialize_x86_bsd_nat): Adjust to C++ification.
2820         * x86-bsd-nat.h: Include "x86-nat.h".
2821         (x86bsd_target): Delete declaration.
2822         (x86bsd_nat_target): New class.
2823
2824         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2825         (the_aarch64_fbsd_nat_target): New.
2826         (aarch64_fbsd_fetch_inferior_registers)
2827         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2828         aarch64_fbsd_nat_target.
2829         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2830         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2831         (the_alpha_bsd_nat_target): New.
2832         (alphabsd_fetch_inferior_registers)
2833         (alphabsd_store_inferior_registers): Refactor as
2834         alpha_bsd_nat_target methods.
2835         (_initialize_alphabsd_nat): Refactor as methods of
2836         alpha_bsd_nat_target.
2837         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2838         (the_amd64_nbsd_nat_target): New.
2839         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2840         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2841         (the_amd64_obsd_nat_target): New.
2842         (_initialize_amd64obsd_nat): Adjust to C++ification.
2843         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2844         (the_arm_fbsd_nat_target): New.
2845         (arm_fbsd_fetch_inferior_registers)
2846         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2847         (_initialize_arm_fbsd_nat): Refactor as methods of
2848         arm_fbsd_nat_target.
2849         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2850         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2851         (the_arm_netbsd_nat_target): New.
2852         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2853         arm_netbsd_nat_target.
2854         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2855         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2856         (the_hppa_nbsd_nat_target): New.
2857         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2858         hppa_nbsd_nat_target methods.
2859         (_initialize_hppanbsd_nat): Adjust to C++ification.
2860         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2861         (the_hppa_obsd_nat_target): New.
2862         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2863         methods of hppa_obsd_nat_target.
2864         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2865         add_target.
2866         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2867         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2868         add_target.
2869         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2870         (_initialize_i386obsd_nat): Use add_target.
2871         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2872         (the_m68k_bsd_nat_target): New.
2873         (m68kbsd_fetch_inferior_registers)
2874         (m68kbsd_store_inferior_registers): Refactor as methods of
2875         m68k_bsd_nat_target.
2876         (_initialize_m68kbsd_nat): Adjust to C++ification.
2877         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2878         (the_mips_fbsd_nat_target): New.
2879         (mips_fbsd_fetch_inferior_registers)
2880         (mips_fbsd_store_inferior_registers): Refactor as methods of
2881         mips_fbsd_nat_target.
2882         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2883         add_target.
2884         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2885         (the_mips_nbsd_nat_target): New.
2886         (mipsnbsd_fetch_inferior_registers)
2887         (mipsnbsd_store_inferior_registers): Refactor as methods of
2888         mips_nbsd_nat_target.
2889         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2890         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2891         (the_mips64_obsd_nat_target): New.
2892         (mips64obsd_fetch_inferior_registers)
2893         (mips64obsd_store_inferior_registers): Refactor as methods of
2894         mips64_obsd_nat_target.
2895         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2896         add_target.
2897         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2898         nbsd_nat_target.
2899         * nbsd-nat.h: Include "inf-ptrace.h".
2900         (nbsd_nat_target): New class.
2901         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2902         (obsd_wait): Refactor as methods of obsd_nat_target.
2903         (obsd_add_target): Delete.
2904         * obsd-nat.h: Include "inf-ptrace.h".
2905         (obsd_nat_target): New class.
2906         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2907         (the_ppc_fbsd_nat_target): New.
2908         (ppcfbsd_fetch_inferior_registers)
2909         (ppcfbsd_store_inferior_registers): Refactor as methods of
2910         ppc_fbsd_nat_target.
2911         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2912         add_target.
2913         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2914         (the_ppc_nbsd_nat_target): New.
2915         (ppcnbsd_fetch_inferior_registers)
2916         (ppcnbsd_store_inferior_registers): Refactor as methods of
2917         ppc_nbsd_nat_target.
2918         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2919         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2920         (the_ppc_obsd_nat_target): New.
2921         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2922         methods of ppc_obsd_nat_target.
2923         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2924         add_target.
2925         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2926         (the_sh_nbsd_nat_target): New.
2927         (shnbsd_fetch_inferior_registers)
2928         (shnbsd_store_inferior_registers): Refactor as methods of
2929         sh_nbsd_nat_target.
2930         (_initialize_shnbsd_nat): Adjust to C++ification.
2931         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2932         (inf_ptrace_xfer_partial): Delete.
2933         (sparc_xfer_partial, sparc_target): Delete.
2934         * sparc-nat.h (sparc_fetch_inferior_registers)
2935         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2936         (sparc_target): Delete function declaration.
2937         (sparc_target): New template class.
2938         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2939         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2940         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2941         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2942         add_target.
2943         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2944         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2945         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2946         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2947         add_target.
2948         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2949         (the_vax_bsd_nat_target): New.
2950         (vaxbsd_fetch_inferior_registers)
2951         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2952         methods.
2953         (_initialize_vaxbsd_nat): Adjust to C++ification.
2954
2955         * bsd-kvm.c (bsd_kvm_target): New class.
2956         (bsd_kvm_ops): Now a bsd_kvm_target.
2957         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2958         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2959         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2960         bsd_kvm_target.
2961         (bsd_kvm_return_one): Delete.
2962         (bsd_kvm_add_target): Adjust to C++ification.
2963
2964         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2965         (nto_procfs_target_procfs): New classes.
2966         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2967         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2968         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2969         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2970         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2971         (procfs_remove_hw_breakpoint, procfs_resume)
2972         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2973         (procfs_kill_inferior, procfs_store_registers)
2974         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2975         as methods of nto_procfs_target.
2976         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2977         (nto_native_ops): Delete.
2978         (procfs_open, procfs_native_open): Delete.
2979         (nto_native_ops): Now an nto_procfs_target_native.
2980         (init_procfs_targets): Adjust to C++ification.
2981         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2982         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2983         Refactor as methods of nto_procfs_target.
2984
2985         * go32-nat.c (go32_nat_target): New class.
2986         (the_go32_nat_target): New.
2987         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2988         (go32_store_registers, go32_xfer_partial, go32_files_info)
2989         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2990         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2991         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2992         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2993         (go32_target): Delete.
2994         (_initialize_go32_nat): Adjust to C++ification.
2995
2996         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2997         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2998         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2999         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
3000         gnu_nat_target.
3001         (gnu_target): Delete.
3002         * gnu-nat.h (gnu_target): Delete.
3003         (gnu_nat_target): New class.
3004         * i386-gnu-nat.c (gnu_base_target): New.
3005         (i386_gnu_nat_target): New class.
3006         (the_i386_gnu_nat_target): New.
3007         (_initialize_i386gnu_nat): Adjust to C++ification.
3008
3009 2018-05-02  Pedro Alves  <palves@redhat.com>
3010
3011         * bfd-target.c (target_bfd_xclose): Rename to ...
3012         (target_bfd_close): ... this.
3013         (target_bfd_reopen): Adjust.
3014         * target.c (target_close): Remove references to to_xclose.
3015         * target.h (target_ops::to_xclose): Delete.
3016         (target_ops::to_close): Update comments.
3017
3018 2018-05-02  Pedro Alves  <palves@redhat.com>
3019
3020         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
3021         "linux-nat.h".
3022         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
3023         * inf-ptrace.c (inf_ptrace_register_u_offset)
3024         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
3025         (inf_ptrace_store_register, inf_ptrace_store_registers)
3026         (inf_ptrace_trad_target): Move to ...
3027         * linux-nat-trad.c: ... this new file.
3028         * linux-nat-trad.h: New file.
3029         * linux-nat.c (linux_target_install_ops): Make extern.
3030         (linux_trad_target): Delete.
3031         * linux-nat.h (linux_trad_target): Delete declaration.
3032         (linux_target_install_ops): Declare.
3033         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
3034         "linux-nat.h".
3035
3036 2018-05-02  Pedro Alves  <palves@redhat.com>
3037
3038         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
3039         procfs_target/add_target here.
3040         * procfs.c (procfs_target): Make static.
3041         (_initialize_procfs): Call add_target here.
3042         * procfs.h (struct target_ops): Remove forward declaration.
3043         (procfs_target): Remove declaration.
3044         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
3045
3046 2018-05-02  Pedro Alves  <palves@redhat.com>
3047
3048         * procfs.c (procfs_stopped_by_watchpoint)
3049         (procfs_insert_watchpoint, procfs_remove_watchpoint)
3050         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
3051         Forward declare.
3052         (procfs_use_watchpoints): Delete, move contents...
3053         (procfs_target): ... here.
3054         * procfs.h (procfs_use_watchpoints): Delete declaration.
3055         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
3056         procfs_use_watchpoints.
3057         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
3058         procfs_use_watchpoints.
3059
3060 2018-05-02  Tom Tromey  <tom@tromey.com>
3061
3062         PR python/20084:
3063         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
3064         and var_zuinteger_unlimited.
3065         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
3066         and PARAM_ZUINTEGER_UNLIMITED.
3067         (set_parameter_value): Handle var_zuinteger and
3068         var_zuinteger_unlimited.
3069         (add_setshow_generic): Likewise.
3070         (parmpy_init): Likewise.
3071
3072 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
3073
3074         PR rust/23124
3075         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
3076         pointer is not null before dereferencing it.
3077
3078 2018-04-30  Tom Tromey  <tom@tromey.com>
3079
3080         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
3081         is_mi_like_p.
3082
3083 2018-04-30  Tom Tromey  <tom@tromey.com>
3084
3085         * breakpoint.c (mention): Remove use of is_mi_like_p.
3086         (print_mention_ranged_breakpoint): Likewise.
3087         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
3088         of is_mi_like_p.
3089
3090 2018-04-30  Tom Tromey  <tom@tromey.com>
3091
3092         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
3093
3094 2018-04-30  Tom Tromey  <tom@tromey.com>
3095
3096         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
3097         (info_spu_event_command): Remove some uses of is_mi_like_p.
3098
3099 2018-04-30  Tom Tromey  <tom@tromey.com>
3100
3101         * python/py-framefilter.c (py_print_single_arg)
3102         (enumerate_locals, py_print_args, py_print_frame): Remove some
3103         uses of is_mi_like_p.
3104
3105 2018-04-30  Tom Tromey  <tom@tromey.com>
3106
3107         * ui-out.c: Update.
3108         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
3109         * ui-out.h (ui_out::is_mi_like_p): Now const.
3110         (ui_out::do_is_mi_like_p): Now const.
3111         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
3112
3113 2018-04-30  Tom Tromey  <tom@tromey.com>
3114
3115         * varobj.c (varobj_set_visualizer): Use new_reference.
3116         * python/python.c (gdbpy_decode_line): Use new_reference.
3117         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
3118         new_reference.
3119
3120 2018-04-30  Tom Tromey  <tom@tromey.com>
3121
3122         * varobj.c (install_new_value): Use new_reference.
3123         * value.h (value_incref): Return void.  Swap intro comment with
3124         value_decref.
3125         * value.c (set_value_parent): Use new_reference.
3126         (value_incref): Return void.  Update intro comment.
3127         (release_value): Use new_reference.
3128         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
3129
3130 2018-04-30  Tom Tromey  <tom@tromey.com>
3131
3132         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
3133         * gdb_bfd.h (new_bfd_ref): Remove.
3134         (gdb_bfd_open): Update comment.
3135         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
3136         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
3137         (gdb_bfd_fdopenr): Use new_reference.
3138         * exec.c (exec_file_attach): Use new_reference.
3139
3140 2018-04-30  Tom Tromey  <tom@tromey.com>
3141
3142         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
3143         method.
3144
3145 2018-04-30  Tom Tromey  <tom@tromey.com>
3146
3147         * jit.c (jit_read_code_entry): Use type_align.
3148         * i386-tdep.c (i386_gdbarch_init): Don't call
3149         set_gdbarch_long_long_align_bit.
3150         * gdbarch.sh: Remove long_long_align_bit.
3151         * gdbarch.c, gdbarch.h: Rebuild.
3152         * arc-tdep.c (arc_type_align): New function.
3153         (arc_gdbarch_init): Use arc_type_align.  Don't call
3154         set_gdbarch_long_long_align_bit.
3155
3156 2018-04-30  Tom Tromey  <tom@tromey.com>
3157
3158         * rust-lang.c (rust_type_alignment): Remove.
3159         (rust_composite_type): Use type_align.
3160
3161 2018-04-30  Tom Tromey  <tom@tromey.com>
3162
3163         * NEWS: Mention Type.align.
3164         * python/py-type.c (typy_get_alignof): New function.
3165         (type_object_getset): Add "alignof".
3166
3167 2018-04-30  Tom Tromey  <tom@tromey.com>
3168
3169         PR exp/17095:
3170         * NEWS: Update.
3171         * std-operator.def (UNOP_ALIGNOF): New operator.
3172         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
3173         New.
3174         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
3175         * c-lang.c (c_op_print_tab): Add alignof.
3176         * c-exp.y (ALIGNOF): New token.
3177         (exp): Add "ALIGNOF" production.
3178         (ident_tokens): Add _Alignof and alignof.
3179
3180 2018-04-30  Tom Tromey  <tom@tromey.com>
3181
3182         * i386-tdep.c (i386_type_align): New function.
3183         (i386_gdbarch_init): Update.
3184         * gdbarch.sh (type_align): New method.
3185         * gdbarch.c, gdbarch.h: Rebuild.
3186         * arch-utils.h (default_type_align): Declare.
3187         * arch-utils.c (default_type_align): New function.
3188         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
3189         (struct type) <align_log2>: New field.
3190         <instance_flags>: Now a bitfield.
3191         (TYPE_RAW_ALIGN): New macro.
3192         (type_align, type_raw_align, set_type_align): Declare.
3193         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
3194         functions.
3195         * dwarf2read.c (quirk_rust_enum): Set type alignment.
3196         (get_alignment, maybe_set_alignment): New functions.
3197         (read_structure_type, read_enumeration_type, read_array_type)
3198         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
3199         (read_subrange_type, read_base_type): Set type alignment.
3200
3201 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
3202
3203         * dwarf2read.c (read_index_from_section): Use bool.
3204
3205 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
3206
3207         PR gdb/22950
3208         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
3209         with #ifdef.
3210
3211 2018-04-29  John Reiser  <jreiser@BitWagon.com>
3212
3213         PR build/22873
3214         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
3215         last step, and do it atomically.
3216
3217 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
3218
3219         * compile/compile-c-types.c (convert_int, convert_float):
3220         Update for C FE v1.
3221
3222 2018-04-27  Tom Tromey  <tom@tromey.com>
3223
3224         PR rust/22545:
3225         * rust-lang.c (rust_inclusive_range_type_p): New function.
3226         (rust_range): Handle inclusive ranges.
3227         (rust_compute_range): Likewise.
3228         * rust-exp.y (struct rust_op) <inclusive>: New field.
3229         (DOTDOTEQ): New constant.
3230         (range_expr): Add "..=" productions.
3231         (operator_tokens): Add "..=" token.
3232         (ast_range): Add "inclusive" parameter.
3233         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
3234         ranges.
3235         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
3236         bounds values.
3237         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
3238         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
3239         Update comments.
3240         * expprint.c (print_subexp_standard): Handle new bounds values.
3241         (dump_subexp_body_standard): Likewise.
3242
3243 2018-04-27  Tom Tromey  <tom@tromey.com>
3244
3245         * configure: Rebuild.
3246         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
3247         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
3248         "OVERRIDE".
3249         (class symbol_needs_eval_context): Likewise.
3250         * dwarf2read.c (mock_mapped_index::symbol_name_count)
3251         (mock_mapped_index::symbol_name_at): Use "override".  Remove
3252         "virtual".
3253         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
3254         "override".
3255         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
3256         * aarch64-tdep.c (instruction_reader::read): Use "override".
3257         (instruction_reader_test::read): Likewise.
3258         * arm-tdep.c (instruction_reader::read): Use "override".
3259         (instruction_reader_thumb::read): Likewise.
3260
3261 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
3262
3263         PR remote/9665
3264         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3265         instead of remote_send.
3266         (remote_send): Remove.
3267
3268 2018-04-26  Pedro Alves  <palves@redhat.com>
3269
3270         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3271         find_function_start_sal instead of find_pc_line.
3272
3273 2018-04-26  Pedro Alves  <palves@redhat.com>
3274
3275         * breakpoint.c (set_breakpoint_location_function): Handle
3276         mst_data_gnu_ifunc.
3277         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3278         * elfread.c (elf_symtab_read): Give data symbols with
3279         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3280         (elf_rel_plt_read): Update comment.
3281         * linespec.c (convert_linespec_to_sals): Handle
3282         mst_data_gnu_ifunc.
3283         (minsym_found): Handle mst_data_gnu_ifunc.
3284         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3285         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3286         * parse.c (find_minsym_type_and_address): Handle
3287         mst_data_gnu_ifunc.
3288         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3289         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3290         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3291         comment.
3292         <mst_data_gnu_ifunc>: New enumerator.
3293
3294 2018-04-26  Pedro Alves  <palves@redhat.com>
3295
3296         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3297         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3298         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3299         Handle it.
3300         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3301         (lookup_minimal_symbol_by_pc): Adjust.
3302         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3303         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3304         * minsyms.h (lookup_msym_prefer): New enum.
3305         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3306         parameter by a lookup_msym_prefer parameter.
3307
3308 2018-04-26  Pedro Alves  <palves@redhat.com>
3309
3310         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3311         ends in "@plt" instead of looking at the symbol's section.
3312
3313 2018-04-26  Pedro Alves  <palves@redhat.com>
3314
3315         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3316         all references.
3317         (find_pc_partial_function_gnu_ifunc): Rename to ...
3318         (find_pc_partial_function): ... this, and remove references to
3319         'is_gnu_ifunc_p'.
3320         (find_pc_partial_function): Delete old implementation.
3321         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3322
3323 2018-04-26  Pedro Alves  <palves@redhat.com>
3324
3325         * linespec.c (struct bound_minimal_symbol_search_key): New.
3326         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3327         skip first line if we found a GNU ifunc minimal symbol by name.
3328         (compare_msymbols): Change parameters to work with a destructured
3329         lhs minsym.
3330         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3331         functions.
3332
3333 2018-04-26  Pedro Alves  <palves@redhat.com>
3334
3335         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3336         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3337         address/name.
3338         (add_location_to_breakpoint): Store the minsym and the objfile in
3339         the breakpoint location.
3340         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3341         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3342         Record the minsym in the sal.
3343         * symtab.h (symtab_and_line) <msymbol>: New field.
3344
3345 2018-04-26  Pedro Alves  <palves@redhat.com>
3346
3347         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3348         unless we actually resolved the ifunc.
3349
3350 2018-04-26  Pedro Alves  <palves@redhat.com>
3351
3352         * c-exp.y (variable production): Prefer ifunc minsyms over
3353         regular function symbols.
3354         * symtab.c (find_gnu_ifunc): New function.
3355         * minsyms.h (lookup_msym_prefer): New enum.
3356         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3357         parameter by a lookup_msym_prefer parameter.
3358         * symtab.h (find_gnu_ifunc): New declaration.
3359
3360 2018-04-26  Pedro Alves  <palves@redhat.com>
3361
3362         * blockframe.c (find_gnu_ifunc_target_type): New function.
3363         (find_function_type): New.
3364         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3365         return a value with a memory address.
3366         (eval_call): For calls to GNU ifunc functions, try to find the
3367         type of the target function from the type that the resolver
3368         returns.
3369         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3370         symbols.
3371         * infcall.c (find_function_return_type): Delete.
3372         (find_function_addr): Add 'function_type' parameter.  For calls to
3373         GNU ifunc functions, try to find the type of the target function
3374         from the type that the resolver returns, and return it via
3375         FUNCTION_TYPE.
3376         (call_function_by_hand_dummy): Adjust to use the function type
3377         returned by find_function_addr.
3378         (find_function_addr): Add 'function_type' parameter and move
3379         description here.
3380         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3381         declarations.
3382
3383 2018-04-26  Pedro Alves  <palves@redhat.com>
3384
3385         * c-exp.y (variable production): Skip finding an alias for ifunc
3386         symbols.
3387
3388 2018-04-26  Pedro Alves  <palves@redhat.com>
3389
3390         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3391
3392 2018-04-25  Pedro Alves  <palves@redhat.com>
3393
3394         * infcmd.c (kill_command): Print the pid as string, not the whole
3395         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3396         message.
3397         * remote.c (remote_detach_1): Print the pid as string, not the
3398         whole thread's ptid.
3399
3400 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3401             Sergio Durigan Junior  <sergiodj@redhat.com>
3402             Pedro Alves  <palves@redhat.com>
3403
3404         * infcmd.c (kill_command): Print message when inferior has
3405         been killed.
3406         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3407         '1'.
3408         (add_inferior): Improve message printed when
3409         'print_inferior_events' is on.
3410         (exit_inferior): Remove message printed when
3411         'print_inferior_events' is on.
3412         (detach_inferior): Improve message printed when
3413         'print_inferior_events' is on.
3414         (initialize_inferiors): Use 'add_inferior_silent' to set
3415         'current_inferior_'.
3416         * inferior.h (print_inferior_events): Declare here as
3417         'extern'.
3418         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3419         '[Detaching...]' messages when 'print_inferior_events' is on.
3420         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3421         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3422         'Detaching after fork from child...', replace it by '... from
3423         parent...'.
3424         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3425         prefix/suffix when printing 'Detaching...' messages.  Print
3426         them when 'print_inferior_events' is on.
3427         * remote.c (remote_detach_1): Print message when detaching
3428         from inferior and '!is_fork_parent'.
3429
3430 2018-04-24  Tom Tromey  <tom@tromey.com>
3431
3432         * cli-out.h: Reindent.
3433
3434 2018-04-24  Tom Tromey  <tom@tromey.com>
3435
3436         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3437         (cli_ui_out::do_field_string): Use fputs_filtered.
3438         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3439
3440 2018-04-23  Tom Tromey  <tom@tromey.com>
3441
3442         * guile/scm-frame.c (gdbscm_frame_read_var): Use
3443         gdb::unique_xmalloc_ptr.
3444
3445 2018-04-23  Tom Tromey  <tom@tromey.com>
3446
3447         * configure: Rebuild.
3448
3449 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
3450
3451         PR gdb/23095
3452         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
3453         prepare_for_testing.  Set normal_bp to r_debug_state if target
3454         is bsd.
3455
3456 2018-04-21  Pedro Alves  <palves@redhat.com>
3457             Rajendra SY  <rajendra.sy@gmail.com>
3458
3459         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
3460         * remote.c (extended_remote_attach): In all-stop mode, mark the
3461         thread as executing.
3462
3463 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3464
3465         * thread.c (thread_apply_all_command): Fix comment.
3466         (thread_command): Fix comment.
3467
3468 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
3469
3470         * common/tdesc.h (tdesc_create_feature): Remove xml filename
3471         parameter.
3472         * features/aarch64-core.c (create_feature_aarch64_core):
3473         Regenerate.
3474         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
3475         Likewise.
3476         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
3477         Likewise.
3478         * features/i386/32bit-avx512.c
3479         (create_feature_i386_32bit_avx512): Likewise.
3480         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
3481         Likewise.
3482         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
3483         Likewise.
3484         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3485         Likewise.
3486         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3487         Likewise.
3488         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3489         Likewise.
3490         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3491         Likewise.
3492         * features/i386/64bit-avx512.c
3493         (create_feature_i386_64bit_avx512): Likewise.
3494         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3495         Likewise.
3496         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3497         Likewise.
3498         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3499         Likewise.
3500         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3501         Likewise.
3502         * features/i386/64bit-segments.c
3503         (create_feature_i386_64bit_segments): Likewise.
3504         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3505         Likewise.
3506         * features/i386/x32-core.c
3507         (create_feature_i386_x32_core): Likewise.
3508         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3509         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3510         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3511         * target-descriptions.c: In generated code, don't pass xml
3512         filename.
3513
3514 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3515
3516         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3517         (print_xml_feature::visit_post): Likewise.
3518         (print_xml_feature::visit): Likewise.
3519         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3520         (print_xml_feature): Add new class.
3521         * regformats/regdat.sh: Null xmltarget on feature targets.
3522         * target-descriptions.c (struct target_desc): Add xmltarget.
3523         (maintenance_check_tdesc_xml_convert): Add unittest function.
3524         (tdesc_get_features_xml): Add function to get xml.
3525         (maintenance_check_xml_descriptions): Test xml generation.
3526         * xml-tdesc.c (string_read_description_xml): Add function.
3527         * xml-tdesc.h (string_read_description_xml): Add declaration.
3528
3529 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3530
3531         * features/Makefile: Add feature marker to targets with new style
3532         target descriptions.
3533         * regformats/aarch64.dat: Regenerate.
3534         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3535         * regformats/i386/amd64-avx-linux.dat: Likewise.
3536         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3537         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3538         * regformats/i386/amd64-linux.dat: Likewise.
3539         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3540         * regformats/i386/amd64.dat: Likewise.
3541         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3542         * regformats/i386/i386-avx-linux.dat: Likewise.
3543         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3544         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3545         * regformats/i386/i386-linux.dat: Likewise.
3546         * regformats/i386/i386-mmx-linux.dat: Likewise.
3547         * regformats/i386/i386-mpx-linux.dat: Likewise.
3548         * regformats/i386/i386.dat: Likewise.
3549         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3550         * regformats/i386/x32-avx-linux.dat: Likewise.
3551         * regformats/i386/x32-linux.dat: Likewise.
3552         * regformats/tic6x-c62x-linux.dat: Likewise.
3553         * regformats/tic6x-c64x-linux.dat: Likewise.
3554         * regformats/tic6x-c64xp-linux.dat: Likewise.
3555         * regformats/regdat.sh: Parse feature marker.
3556
3557 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3558
3559         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3560         (tdesc_osabi_name): Likewise.
3561         * target-descriptions.c (tdesc_architecture_name): Add new
3562         function.
3563         (tdesc_osabi_name): Likewise.
3564
3565 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3566
3567         * common/tdesc.c (tdesc_predefined_type): Move to here.
3568         (tdesc_named_type): Likewise.
3569         (tdesc_create_vector): Likewise.
3570         (tdesc_create_struct): Likewise.
3571         (tdesc_set_struct_size): Likewise.
3572         (tdesc_create_union): Likewise.
3573         (tdesc_create_flags): Likewise.
3574         (tdesc_create_enum): Likewise.
3575         (tdesc_add_field): Likewise.
3576         (tdesc_add_typed_bitfield): Likewise.
3577         (tdesc_add_bitfield): Likewise.
3578         (tdesc_add_flag): Likewise.
3579         (tdesc_add_enum_value): Likewise.
3580         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3581         (struct tdesc_type_vector): Likewise.
3582         (struct tdesc_type_field): Likewise.
3583         (struct tdesc_type_with_fields): Likewise.
3584         (tdesc_create_enum): Add declaration.
3585         (tdesc_add_typed_bitfield): Likewise.
3586         (tdesc_add_enum_value): Likewise.
3587         * target-descriptions.c (tdesc_type_field): Move from here.
3588         (tdesc_type_builtin): Likewise.
3589         (tdesc_type_vector): Likewise.
3590         (tdesc_type_with_fields): Likewise.
3591         (tdesc_predefined_types): Likewise.
3592         (tdesc_named_type): Likewise.
3593         (tdesc_create_vector): Likewise.
3594         (tdesc_create_struct): Likewise.
3595         (tdesc_set_struct_size): Likewise.
3596         (tdesc_create_union): Likewise.
3597         (tdesc_create_flags): Likewise.
3598         (tdesc_create_enum): Likewise.
3599         (tdesc_add_field): Likewise.
3600         (tdesc_add_typed_bitfield): Likewise.
3601         (tdesc_add_bitfield): Likewise.
3602         (tdesc_add_flag): Likewise.
3603         (tdesc_add_enum_value): Likewise.
3604         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3605         (tdesc_add_typed_bitfield): Likewise.
3606         (tdesc_add_enum_value): Likewise.
3607
3608 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3609
3610         * common/tdesc.c (tdesc_feature::accept): Move to here.
3611         (tdesc_feature::operator==): Likewise.
3612         (tdesc_create_reg): Likewise.
3613         * common/tdesc.h (tdesc_type_kind): Likewise.
3614         (struct tdesc_type): Likewise.
3615         (struct tdesc_feature): Likewise.
3616         * regformats/regdat.sh: Create a feature.
3617         * target-descriptions.c (tdesc_type_kind): Move from here.
3618         (tdesc_type): Likewise.
3619         (tdesc_type_up): Likewise.
3620         (tdesc_feature): Likewise.
3621         (tdesc_create_reg): Likewise.
3622
3623 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3624
3625         * Makefile.in: Add arch/tdesc.c
3626         * common/tdesc.c: New file.
3627         * common/tdesc.h (tdesc_element_visitor): Move to here.
3628         (tdesc_element): Likewise.
3629         (tdesc_reg): Likewise.
3630         (tdesc_reg_up): Likewise.
3631         * regformats/regdef.h (reg): Add offset to constructors.
3632         * target-descriptions.c (tdesc_element_visitor): Move from here.
3633         (tdesc_element): Likewise.
3634         (tdesc_reg): Likewise.
3635         (tdesc_reg_up): Likewise.
3636
3637 2018-04-17  Tom Tromey  <tom@tromey.com>
3638
3639         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3640         discriminant field.
3641
3642 2018-04-17  Tom Tromey  <tom@tromey.com>
3643
3644         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3645
3646 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3647
3648         * symtab.c (print_symbol_info): Skip printing filename and line
3649         number when `last' is NULL.
3650         (symtab_symbol_info): Use empty string instead of NULL for first
3651         invocation of print_symbol_info.
3652         (rbreak_command): Pass NULL to `last' parameter of
3653         print_symbol_info.
3654
3655 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3656
3657         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3658         instead of nullptr.
3659
3660 2018-04-16  Pedro Alves  <palves@redhat.com>
3661
3662         * MAINTAINERS (sh): Remove.
3663         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3664         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3665         (ALLDEPFILES): Remove sh64-tdep.c.
3666         * NEWS: Mentions that support for SH-5/SH64 is removed.
3667         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3668         (sh*-*-openbsd*): Ditto.
3669         (sh64-*-elf*): Remove.
3670         (sh*): Remove.
3671         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3672         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3673         * sh-tdep.c: No longer include "sh64-tdep.h".
3674         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3675         * sh64-tdep.c, sh64-tdep.h: Remove files.
3676
3677 2018-04-16  Pedro Alves  <palves@redhat.com>
3678
3679         * MAINTAINERS: Remove m88k.
3680         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3681         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3682         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3683         * NEWS: Mention that support for m88k was removed.
3684         * configure.host (m88*-*-*): Remove support.
3685         * configure.nat (m88k-*-*): Remove support.
3686         * configure.tgt (m88*-*-openbsd*): Remove.
3687         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3688
3689 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3690
3691         * configure.tgt (x86_tobjs): New variable.
3692         (amd64_tobjs, i386_tobjs): Use it.
3693
3694 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3695
3696         * symtab.c (print_symbol_info): Precede the symbol definition by
3697         the line number when available.
3698         * NEWS: Advertise this enhancement.
3699
3700 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3701
3702         * NEWS (New options): announce set/show record btrace cpu.
3703         * btrace.c: Include record-btrace.h.
3704         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3705         the vendor is unknown.
3706         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3707         Maybe overwrite the btrace configuration's cpu.
3708         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3709         (btrace_fetch): Add cpu parameter.  Update callers.
3710         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3711         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3712         errata workarounds if the vendor is unknown.
3713         * python/py-record-btrace.c: Include record-btrace.h.
3714         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3715         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3716         * record-btrace.c (record_btrace_cpu_state_kind): New.
3717         (record_btrace_cpu): New.
3718         (set_record_btrace_cpu_cmdlist): New.
3719         (record_btrace_get_cpu): New.
3720         (require_btrace_thread, record_btrace_info)
3721         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3722         (cmd_set_record_btrace_cpu_none): New.
3723         (cmd_set_record_btrace_cpu_auto): New.
3724         (cmd_set_record_btrace_cpu): New.
3725         (cmd_show_record_btrace_cpu): New.
3726         (_initialize_record_btrace): Initialize set/show record btrace cpu
3727         commands.
3728         * record-btrace.h (record_btrace_get_cpu): New.
3729
3730 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3731
3732         * record.c (set_record_command): Fix typo in message.
3733
3734 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3735
3736         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3737
3738 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3739
3740         * infrun.c (process_event_stop_test): Call
3741         gdbarch_in_indirect_branch_thunk.
3742         * gdbarch.sh (in_indirect_branch_thunk): New.
3743         * gdbarch.c: Regenerated.
3744         * gdbarch.h: Regenerated.
3745         * x86-tdep.h: New.
3746         * x86-tdep.c: New.
3747         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3748         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3749         (ALLDEPFILES): Add x86-tdep.c.
3750         * arch-utils.h (default_in_indirect_branch_thunk): New.
3751         * arch-utils.c (default_in_indirect_branch_thunk): New.
3752         * i386-tdep: Include x86-tdep.h.
3753         (i386_in_indirect_branch_thunk): New.
3754         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3755         function.
3756         * amd64-tdep: Include x86-tdep.h.
3757         (amd64_in_indirect_branch_thunk): New.
3758         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3759
3760 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3761
3762         PR gdb/23053
3763         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3764         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3765         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3766         regression.
3767
3768 2018-04-12  Tom Tromey  <tom@tromey.com>
3769
3770         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3771         (rust_evaluate_subexp): Likewise.
3772
3773 2018-04-12  Pedro Alves  <palves@redhat.com>
3774
3775         * procfs.c (procfs_detach): Make forward declaration's prototype
3776         match definition's protototype.
3777         (proc_get_LDT_entry): Remove stale do_cleanups call.
3778
3779 2018-04-12  Pedro Alves  <palves@redhat.com>
3780
3781         * target.h (target_ops::to_has_exited): Delete.
3782         (target_has_exited): Delete.
3783         * target-delegates.c: Regenerate.
3784
3785 2018-04-11  Pedro Alves  <palves@redhat.com>
3786
3787         * target.c (fileio_fh_t::t): Add comment.
3788         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3789         (target_fileio_close): Handle a NULL target.
3790         (invalidate_fileio_fh): New.
3791         (target_close): Call it.
3792         * remote.c (remote_hostio_send_command): No longer check whether
3793         remote_desc is open.
3794
3795 2018-04-11  Pedro Alves  <palves@redhat.com>
3796
3797         * target.c (fileio_fh_t): Make it a named struct instead of a
3798         typedef.
3799         (fileio_fh_t::is_closed): New method.
3800         (DEF_VEC_O (fileio_fh_t)): Remove.
3801         (fileio_fhandles): Now a std::vector.
3802         (is_closed_fileio_fh): Delete.
3803         (acquire_fileio_fd): Adjust.  Rename parameters.
3804         (release_fileio_fd): Adjust.
3805         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3806         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3807         (target_fileio_close): Adjust.
3808
3809 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3810
3811         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3812         index.
3813
3814 2018-04-10  Pedro Alves  <palves@redhat.com>
3815
3816         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3817         (scoped_finish_thread_state): New class.
3818         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3819         cleanup.
3820         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3821         (fetch_inferior_event, normal_stop): Likewise.
3822         * thread.c (finish_thread_state_cleanup): Delete.
3823
3824 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3825             Pedro Alves  <palves@redhat.com>
3826
3827         * value.c: Include "selftest.h" and "common/array-view.h".
3828         (struct range) <operator ==>: New.
3829         (test_ranges_contain): New.
3830         (check_ranges_vector): New.
3831         (test_insert_into_bit_range_vector): New.
3832         (_initialize_values): Register selftests.
3833         * common/array-view.h (operator==, operator!=): New.
3834
3835 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3836
3837         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3838         an iterator.
3839         * inline-frame.c: Include <algorithm>.
3840         (struct inline_state): Add constructor.
3841         (inline_state_s): Remove.
3842         (DEF_VEC_O(inline_state_s)): Remove.
3843         (inline_states): Change type to std::vector.
3844         (find_inline_frame_state): Adjust to std::vector.
3845         (allocate_inline_frame_state): Remove.
3846         (clear_inline_frame_state): Adjust to std::vector.
3847         (skip_inline_frames): Adjust to std::vector.
3848
3849 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3850
3851         * tracepoint.h (struct trace_state_variable): Add constructor.
3852         <name>: Change type to std::string.
3853         * tracepoint.c (tsv_s): Remove.
3854         (DEF_VEC_O(tsv_s)): Remove.
3855         (tvariables): Change to std::vector.
3856         (create_trace_state_variable): Adjust to std::vector.
3857         (find_trace_state_variable): Likewise.
3858         (find_trace_state_variable_by_number): Likewise.
3859         (delete_trace_state_variable): Likewise.
3860         (trace_variable_command): Adjust to std::string.
3861         (delete_trace_variable_command): Likewise.
3862         (tvariables_info_1): Adjust to std::vector.
3863         (save_trace_state_variables): Likewise.
3864         (start_tracing): Likewise.
3865         (merge_uploaded_trace_state_variables): Adjust to std::vector
3866         and std::string.
3867         * target.h (struct target_ops)
3868         <to_download_trace_state_variable>: Pass reference to
3869         trace_state_variable.
3870         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3871         * target-delegates.c: Re-generate.
3872         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3873         (mi_tsv_deleted): Likewise.
3874         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3875         * remote.c (remote_download_trace_state_variable): Change
3876         pointer to reference and adjust.
3877         * make-target-delegates (parse_argtypes): Handle references.
3878         (write_function_header): Likewise.
3879         (munge_type): Likewise.
3880
3881 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3882
3883         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3884         string_view-selftests.c.
3885         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3886         testsuite.
3887         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3888         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3889         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3890         * unittests/basic_string_view/element_access/char/1.cc:
3891         Likewise.
3892         * unittests/basic_string_view/element_access/char/empty.cc:
3893         Likewise.
3894         * unittests/basic_string_view/element_access/char/front_back.cc:
3895         Likewise.
3896         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3897         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3898         Likewise.
3899         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3900         Likewise.
3901         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3902         Likewise.
3903         * unittests/basic_string_view/operations/compare/char/1.cc:
3904         Likewise.
3905         * unittests/basic_string_view/operations/compare/char/13650.cc:
3906         Likewise.
3907         * unittests/basic_string_view/operations/copy/char/1.cc:
3908         Likewise.
3909         * unittests/basic_string_view/operations/data/char/1.cc:
3910         Likewise.
3911         * unittests/basic_string_view/operations/find/char/1.cc:
3912         Likewise.
3913         * unittests/basic_string_view/operations/find/char/2.cc:
3914         Likewise.
3915         * unittests/basic_string_view/operations/find/char/3.cc:
3916         Likewise.
3917         * unittests/basic_string_view/operations/find/char/4.cc:
3918         Likewise.
3919         * unittests/basic_string_view/operations/rfind/char/1.cc:
3920         Likewise.
3921         * unittests/basic_string_view/operations/rfind/char/2.cc:
3922         Likewise.
3923         * unittests/basic_string_view/operations/rfind/char/3.cc:
3924         Likewise.
3925         * unittests/basic_string_view/operations/substr/char/1.cc:
3926         Likewise.
3927         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3928         * unittests/string_view-selftests.c: New file.
3929
3930 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3931
3932         * unittests/basic_string_view/capacity/1.cc: New file.
3933         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3934         * unittests/basic_string_view/cons/char/1.cc: New file.
3935         * unittests/basic_string_view/cons/char/2.cc: New file.
3936         * unittests/basic_string_view/cons/char/3.cc: New file.
3937         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3938         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3939         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3940         * unittests/basic_string_view/element_access/char/1.cc: New file.
3941         * unittests/basic_string_view/element_access/char/2.cc: New file.
3942         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3943         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3944         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3945         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3946         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3947         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3948         * unittests/basic_string_view/include.cc: New file.
3949         * unittests/basic_string_view/inserters/char/1.cc: New file.
3950         * unittests/basic_string_view/inserters/char/2.cc: New file.
3951         * unittests/basic_string_view/inserters/char/3.cc: New file.
3952         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3953         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3954         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3955         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3956         * unittests/basic_string_view/literals/types.cc: New file.
3957         * unittests/basic_string_view/literals/values.cc: New file.
3958         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3959         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3960         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3961         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3962         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3963         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3964         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3965         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3966         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3967         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3968         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3969         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3970         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3971         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3972         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3973         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3974         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3975         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3976         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3977         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3978         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3979         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3980         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3981         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3982         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3983         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3984         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3985         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3986         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3987         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3988         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3989         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3990         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3991         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3992         * unittests/basic_string_view/operators/char/2.cc: New file.
3993         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3994         * unittests/basic_string_view/range_access/char/1.cc: New file.
3995         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3996         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3997         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3998         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3999         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
4000         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
4001         * unittests/basic_string_view/requirements/typedefs.cc: New file.
4002         * unittests/basic_string_view/typedefs.cc: New file.
4003         * unittests/basic_string_view/types/1.cc: New file.
4004
4005 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4006
4007         * common/gdb_string_view.h: Remove libstdc++ implementation
4008         details, adjust to gdb reality.
4009         * common/gdb_string_view.tcc: Likewise.
4010         * cli/cli-script.c (struct string_view): Remove.
4011         (user_args) <m_args>: Change element type to gdb::string_view.
4012         (user_args::insert_args): Adjust.
4013
4014 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4015
4016         * common/gdb_string_view.h: New file.
4017         * common/gdb_string_view.tcc: New file.
4018
4019 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4020
4021         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
4022         * configure: Re-generate.
4023
4024 2018-04-09  Pedro Alves  <palves@redhat.com>
4025
4026         * gdbarch.sh: Include "observable.h" instead of "observer.h".
4027         (set_target_gdbarch): Call
4028         gdb::observers::architecture_changed.notify instead of
4029         observer_notify_architecture_changed.
4030
4031 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4032
4033         * tracepoint.c (struct current_traceframe_cleanup): Remove.
4034         (do_restore_current_traceframe_cleanup): Remove.
4035         (restore_current_traceframe_cleanup_dtor): Remove.
4036         (make_cleanup_restore_current_traceframe): Remove.
4037         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
4038         New.
4039         * tracepoint.h (struct scoped_restore_current_traceframe): New.
4040         * infrun.c (fetch_inferior_event): Use
4041         scoped_restore_current_traceframe.
4042
4043 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4044
4045         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
4046         Remove.
4047         <n_allocated_type_units>: Remove.
4048         <all_type_units>: Change to std::vector.
4049         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
4050         to std::vector change.
4051         (dwarf2_per_objfile::get_cutu): Likewise.
4052         (dwarf2_per_objfile::get_tu): Likewise.
4053         (create_signatured_type_table_from_index): Likewise.
4054         (create_signatured_type_table_from_debug_names): Likewise.
4055         (dw2_symtab_iter_next): Likewise.
4056         (dw2_print_stats): Likewise.
4057         (dw2_expand_all_symtabs): Likewise.
4058         (dw2_expand_marked_cus): Likewise.
4059         (dw2_debug_names_iterator::next): Likewise.
4060         (dwarf2_initialize_objfile): Likewise.
4061         (add_signatured_type_cu_to_table): Likewise.
4062         (create_all_type_units): Likewise.
4063         (add_type_unit): Likewise.
4064         (struct tu_abbrev_offset): Add constructor.
4065         (build_type_psymtabs_1): Adjust to std::vector change.
4066         (print_tu_stats): Likewise.
4067         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
4068         (write_debug_names): Likewise.
4069
4070 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4071
4072         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
4073         Make an std::vector.
4074         <n_comp_units>: Remove.
4075         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
4076         to std::vector change.
4077         (dwarf2_per_objfile::get_cutu): Likewise.
4078         (dwarf2_per_objfile::get_cu): Likewise.
4079         (create_cus_from_index): Likewise.
4080         (create_addrmap_from_index): Likewise.
4081         (create_addrmap_from_aranges): Likewise.
4082         (dwarf2_read_index): Likewise.
4083         (dw2_find_last_source_symtab): Likewise.
4084         (dw2_map_symtabs_matching_filename): Likewise.
4085         (dw2_symtab_iter_next): Likewise.
4086         (dw2_print_stats): Likewise.
4087         (dw2_expand_all_symtabs): Likewise.
4088         (dw2_expand_symtabs_with_fullname): Likewise.
4089         (dw2_expand_marked_cus): Likewise.
4090         (dw2_map_symbol_filenames): Likewise.
4091         (create_cus_from_debug_names): Likewise.
4092         (dwarf2_read_debug_names): Likewise.
4093         (dw2_debug_names_iterator::next): Likewise.
4094         (dwarf2_initialize_objfile): Likewise.
4095         (set_partial_user): Likewise.
4096         (dwarf2_build_psymtabs_hard): Likewise.
4097         (read_comp_units_from_section): Remove arguments, adjust to
4098         std::vector change.
4099         (create_all_comp_units): Adjust to std::vector and
4100         read_comp_units_from_section changes.
4101         (dwarf2_find_containing_comp_unit): Adjust to std::vector
4102         change.
4103         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
4104         (psyms_seen_size): Likewise.
4105         (write_gdbindex): Likewise.
4106         (write_debug_names): Likewise.
4107
4108 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4109
4110         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
4111         with dwarf2_per_objfile.
4112         (create_cus_from_index): Likewise.
4113         (create_signatured_type_table_from_index): Likewise.
4114         (dwarf2_read_index): Likewise.
4115         (dwarf2_initialize_objfile): Likewise.
4116         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
4117         per_cu rather than get_dwarf2_per_objfile.
4118
4119 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4120
4121         * dwarf2read.h (struct signatured_type): Forward declare.
4122         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
4123         New methods.
4124         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
4125         (dw2_get_cutu): ...this.
4126         (dwarf2_per_objfile::get_cu): Rename from...
4127         (dw2_get_cu): ...this.
4128         (dwarf2_per_objfile::get_tu): New.
4129         (create_addrmap_from_index): Adjust.
4130         (create_addrmap_from_aranges): Adjust.
4131         (dw2_find_last_source_symtab): Adjust.
4132         (dw2_map_symtabs_matching_filename): Adjust.
4133         (dw2_symtab_iter_next): Adjust.
4134         (dw2_print_stats): Adjust.
4135         (dw2_expand_all_symtabs): Adjust.
4136         (dw2_expand_symtabs_with_fullname): Adjust.
4137         (dw2_expand_marked_cus): Adjust.
4138         (dw_expand_symtabs_matching_file_matcher): Adjust.
4139         (dw2_map_symbol_filenames): Adjust.
4140         (dw2_debug_names_iterator::next): Adjust.
4141         (dwarf2_initialize_objfile): Adjust.
4142         (set_partial_user): Adjust.
4143         (dwarf2_build_psymtabs_hard): Adjust.
4144
4145 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4146
4147         * dwarf2read.c (create_signatured_type_table_from_debug_names):
4148         Remove unused variables.
4149         (dw2_map_symtabs_matching_filename): Likewise.
4150         (dwarf2_record_block_ranges): Likewise.
4151         (dwarf2_read_addr_index): Likewise.
4152         (follow_die_offset): Likewise.
4153
4154 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4155
4156         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
4157         to symbol_file_add_main.
4158
4159 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4160
4161         PR mi/22299
4162         * mi/mi-console.c (do_fputc_async_safe): New.
4163         (mi_console_file::write_async_safe): New.
4164         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
4165         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
4166         New.
4167         * ui-file.c (ui_file::putstrn): Adjust call to
4168         fputstrn_unfiltered.
4169         * utils.c (printchar): Replace do_fputs and do_fprintf
4170         parameters by do_fputc.
4171         (fputstr_filtered): Adjust call to printchar.
4172         (fputstr_unfiltered): Likewise.
4173         (fputstrn_filtered): Likewise.
4174         (fputstrn_unfiltered): Add do_fputc parameter, pass to
4175         printchar.
4176         * utils.h (do_fputc_ftype): New typedef.
4177         (fputstrn_unfiltered): Add do_fputc parameter.
4178
4179 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4180
4181         * regformats/i386/i386-avx.dat: Remove.
4182
4183 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4184
4185         PR gdb/22979
4186         * amd64-tdep.c (amd64_none_init_abi): New function.
4187         (amd64_x32_none_init_abi): New function.
4188         (_initialize_amd64_tdep): Register handlers for x86-64 and
4189         x64_32 with GDB_OSABI_NONE.
4190         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
4191         GDB_OSABI_NONE osabi.
4192
4193 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4194
4195         PR gdb/22980
4196         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
4197         GDB_OSABI_NONE.
4198         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
4199         * osabi.c (gdb_osabi_names): Add "unknown" entry.
4200
4201 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4202
4203         * common/byte-vector.h (char_vector): New type.
4204         * target.h (target_read_alloc): Return
4205         gdb::optional<byte_vector>.
4206         (target_read_stralloc): Return gdb::optional<char_vector>.
4207         (target_get_osdata): Return gdb::optional<char_vector>.
4208         * target.c (target_read_alloc_1): Templatize.  Replacement
4209         manual memory management with vector.
4210         (target_read_alloc): Change return type, adjust.
4211         (target_read_stralloc): Change return type, adjust.
4212         (target_get_osdata): Change return type, adjust.
4213         * auxv.c (struct auxv_info) <length>: Remove.
4214         <data>: Change type to gdb::optional<byte_vector>.
4215         (auxv_inferior_data_cleanup): Free auxv_info with delete.
4216         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
4217         (target_auxv_search): Adjust.
4218         (fprint_target_auxv): Adjust.
4219         * avr-tdep.c (avr_io_reg_read_command): Adjust.
4220         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
4221         (linux_make_corefile_notes): Adjust.
4222         * osdata.c (get_osdata): Adjust.
4223         * remote.c (remote_get_threads_with_qxfer): Adjust.
4224         (remote_memory_map): Adjust.
4225         (remote_traceframe_info): Adjust.
4226         (btrace_read_config): Adjust.
4227         (remote_read_btrace): Adjust.
4228         (remote_pid_to_exec_file): Adjust.
4229         * solib-aix.c (solib_aix_get_library_list): Adjust.
4230         * solib-dsbt.c (decode_loadmap): Don't free buf.
4231         (dsbt_get_initial_loadmaps): Adjust.
4232         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
4233         * solib-target.c (solib_target_current_sos): Adjust.
4234         * tracepoint.c (sdata_make_value): Adjust.
4235         * xml-support.c (xinclude_start_include): Adjust.
4236         (xml_fetch_content_from_file): Adjust.
4237         * xml-support.h (xml_fetch_another): Change return type.
4238         (xml_fetch_content_from_file): Change return type.
4239         * xml-syscall.c (xml_init_syscalls_info): Adjust.
4240         * xml-tdesc.c (file_read_description_xml): Adjust.
4241         (fetch_available_features_from_target): Change return type.
4242         (target_fetch_description_xml): Adjust.
4243         (target_read_description_xml): Adjust.
4244
4245 2018-04-06  Tom Tromey  <tom@tromey.com>
4246
4247         * value.c (~value): Update.
4248         (struct value) <contents>: Now unique_xmalloc_ptr.
4249         (value_contents_bits_eq, allocate_value_contents)
4250         (value_contents_raw, value_contents_all_raw)
4251         (value_contents_for_printing, value_contents_for_printing_const)
4252         (set_value_enclosing_type): Update.
4253
4254 2018-04-06  Tom Tromey  <tom@tromey.com>
4255
4256         * value.c (range_s): Remove typedef, VEC.
4257         (struct range): Add operator<.
4258         (range_lessthan): Remove.
4259         (ranges_contain): Change type.
4260         (~value): Update.
4261         (struct value) <unavailable, optimized_out>: Now std::vector.
4262         (value_entirely_available)
4263         (value_entirely_covered_by_range_vector)
4264         (value_entirely_unavailable, value_entirely_optimized_out):
4265         Update.
4266         (insert_into_bit_range_vector): Change argument type.
4267         (find_first_range_overlap): Likewise.
4268         (struct ranges_and_idx, value_contents_bits_eq)
4269         (require_not_optimized_out, require_available): Update.
4270         (ranges_copy_adjusted): Change argument types.
4271         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4272
4273 2018-04-06  Tom Tromey  <tom@tromey.com>
4274
4275         * value.c (~value): Update.
4276         (struct value) <parent>: Now a value_ref_ptr.
4277         (value_parent, set_value_parent, value_address, value_copy):
4278         Update.
4279
4280 2018-04-06  Tom Tromey  <tom@tromey.com>
4281
4282         * value.c (struct value): Add constructor, destructor, and member
4283         initializers.
4284         (allocate_value_lazy, value_decref): Update.
4285
4286 2018-04-06  Tom Tromey  <tom@tromey.com>
4287
4288         * value.c (struct value) <released, next>: Remove.
4289         (all_values): Now a std::vector.
4290         (allocate_value_lazy): Update.
4291         (value_next): Remove.
4292         (value_mark, value_free_to_mark, release_value)
4293         (value_release_to_mark): Update.
4294
4295 2018-04-06  Tom Tromey  <tom@tromey.com>
4296
4297         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4298         (free_value_chain): Remove.
4299         * value.c (free_value_chain): Remove.
4300         (value_release_to_mark): Return a std::vector.
4301         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4302         std::vector.
4303         (check_condition): Update.
4304         * eval.c (fetch_subexp_value): Change "val_chain" to a
4305         std::vector.
4306         * breakpoint.c (update_watchpoint): Update.
4307         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4308
4309 2018-04-06  Tom Tromey  <tom@tromey.com>
4310
4311         * value.h (free_all_values): Remove.
4312         * value.c (free_all_values): Remove.
4313
4314 2018-04-06  Tom Tromey  <tom@tromey.com>
4315
4316         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4317         (value_history_chain, value_history_count): Remove.
4318         (value_history): New global.
4319         (record_latest_value, access_value_history, show_values)
4320         (preserve_values): Update.
4321
4322 2018-04-06  Tom Tromey  <tom@tromey.com>
4323
4324         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4325         * varobj.c (varobj_set_display_format, varobj_set_value)
4326         (install_default_visualizer, construct_visualizer)
4327         (install_new_value, ~varobj, varobj_get_value_type)
4328         (my_value_of_variable, varobj_editable_p): Update.
4329         * c-varobj.c (c_describe_child, c_value_of_variable)
4330         (cplus_number_of_children, cplus_describe_child): Update.
4331         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4332         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4333         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4334
4335 2018-04-06  Tom Tromey  <tom@tromey.com>
4336
4337         * printcmd.c (last_examine_address): Change type to
4338         value_ref_ptr.
4339         (do_examine, x_command): Update.
4340
4341 2018-04-06  Tom Tromey  <tom@tromey.com>
4342
4343         * value.c (release_value): Update.
4344         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4345         (struct bpstats) <val>: Now a value_ref_ptr.
4346         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4347         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4348         (~watchpoint, print_it_watchpoint, watch_command_1)
4349         (invalidate_bp_value_on_memory_change): Update.
4350
4351 2018-04-06  Tom Tromey  <tom@tromey.com>
4352
4353         * varobj.c (varobj_clear_saved_item)
4354         (update_dynamic_varobj_children, install_new_value, ~varobj):
4355         Update.
4356         * value.h (value_incref): Move declaration earlier.
4357         (value_decref): Rename from value_free.
4358         (struct value_ref_policy): New.
4359         (value_ref_ptr): New typedef.
4360         (struct value_deleter): Remove.
4361         (gdb_value_up): Remove typedef.
4362         (release_value): Change return type.
4363         (release_value_or_incref): Remove.
4364         * value.c (set_value_parent): Update.
4365         (value_incref): Change return type.
4366         (value_decref): Rename from value_free.
4367         (value_free_to_mark, free_all_values, free_value_chain): Update.
4368         (release_value): Return value_ref_ptr.
4369         (release_value_or_incref): Remove.
4370         (record_latest_value, set_internalvar, clear_internalvar):
4371         Update.
4372         * stack.c (info_frame_command): Don't call value_free.
4373         * python/py-value.c (valpy_dealloc, valpy_new)
4374         (value_to_value_object): Update.
4375         * printcmd.c (do_examine): Update.
4376         * opencl-lang.c (lval_func_free_closure): Update.
4377         * mi/mi-main.c (register_changed_p): Don't call value_free.
4378         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4379         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4380         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4381         value_free.
4382         * guile/scm-value.c (vlscm_free_value_smob)
4383         (vlscm_scm_from_value): Update.
4384         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4385         (frame_unwind_register_unsigned, get_frame_register_bytes)
4386         (put_frame_register_bytes): Don't call value_free.
4387         * findvar.c (address_from_register): Don't call value_free.
4388         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4389         * dwarf2loc.c (entry_data_value_free_closure)
4390         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4391         (dwarf2_evaluate_loc_desc_full): Update.
4392         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4393         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4394         (~watchpoint, watch_command_1)
4395         (invalidate_bp_value_on_memory_change): Update.
4396         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4397
4398 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4399
4400         PR gdb/23022
4401         * warning.m4: Add -Wno-error=deprecated-register.
4402         * configure: Re-generate.
4403
4404 2018-04-05  Tom Tromey  <tom@tromey.com>
4405
4406         * linespec.h: Remove include of "vec.h".
4407
4408 2018-04-05  Tom Tromey  <tom@tromey.com>
4409
4410         * linespec.c (typep): Remove typedef.
4411         (find_methods, find_superclass_methods): Take a std::vector.
4412         (find_method): Use std::vector.
4413
4414 2018-04-05  Tom Tromey  <tom@tromey.com>
4415
4416         * utils.c (compare_strings): Remove.
4417         * utils.h (compare_strings): Remove.
4418         * objc-lang.h (find_imps): Update.
4419         * objc-lang.c (find_methods): Take a std::vector.
4420         (uniquify_strings, find_imps): Likewise.
4421         * linespec.c (find_methods): Take a std::vector.
4422         (decode_objc): Use std::vector.
4423         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4424         a std::vector.
4425         (find_method, find_function_symbols): Use std::vector.
4426
4427 2018-04-05  Tom Tromey  <tom@tromey.com>
4428
4429         * completer.c (completion_tracker::completion_tracker): Remove
4430         cast.
4431         (completion_tracker::discard_completions): Likewise.
4432         * breakpoint.c (ambiguous_names_p): Remove cast.
4433         * ada-lang.c (_initialize_ada_language): Remove cast.
4434         * utils.h (streq): Update.
4435         (streq_hash): Add new declaration.
4436         * utils.c (streq): Return bool.
4437         (streq_hash): New function.
4438
4439 2018-04-05  Tom Tromey  <tom@tromey.com>
4440
4441         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
4442         Remove a string copy.
4443
4444 2018-04-05  Tom Tromey  <tom@tromey.com>
4445
4446         * linespec.c (filter_results): Use std::vector.
4447         (decode_line_2, decode_line_full): Update.
4448
4449 2018-04-05  Tom Tromey  <tom@tromey.com>
4450
4451         * linespec.c (canonical_to_fullform): Return std::string.
4452         (filter_results): Update.
4453         (struct decode_line_2_item): Add constructor.
4454         <fullform, displayform>: Now std::string.
4455         (decode_line_2_compare_items): Now a std::sort comparator.
4456         (decode_line_2): Update.
4457
4458 2018-04-05  Tom Tromey  <tom@tromey.com>
4459
4460         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
4461         (unexpected_linespec_error): Update.
4462         (linespec_parse_basic, parse_linespec): Update.
4463
4464 2018-04-05  Tom Tromey  <tom@tromey.com>
4465
4466         * linespec.c (linespec_parse_basic): Reindent.
4467
4468 2018-04-05  Tom Tromey  <tom@tromey.com>
4469
4470         * minsyms.h (iterate_over_minimal_symbols): Update.
4471         * minsyms.c (iterate_over_minimal_symbols): Take a
4472         gdb::function_view.
4473         * linespec.c (struct collect_minsyms): Remove.
4474         (compare_msyms): Now a std::sort comparator.
4475         (add_minsym): Add parameters.
4476         (search_minsyms_for_name): Update.  Use std::vector.
4477
4478 2018-04-03  Tom Tromey  <tom@tromey.com>
4479
4480         * mipsread.c (read_alphacoff_dynamic_symtab): Use
4481         gdb::byte_vector.
4482
4483 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4484
4485         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4486
4487 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4488
4489         PR gdb/16959
4490         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
4491         printing static type.
4492
4493 2018-04-01  Tom Tromey  <tom@tromey.com>
4494
4495         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4496         (rs6000_xfer_shared_libraries): Update.
4497
4498 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4499
4500         * common/gdb_vecs.h (char_ptr): Remove.
4501         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4502
4503 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4504
4505         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4506         with std::vector.
4507         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4508
4509 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4510
4511         * tracepoint.h (struct uploaded_tp): Initialize fields.
4512         <actions, step_actions, cmd_strings>: Change type to
4513         std::vector<char *>.
4514         * tracepoint.c (get_uploaded_tp): Allocate with new.
4515         (free_uploaded_tps): Free with delete.
4516         (parse_tracepoint_definition): Adjust to std::vector change.
4517         * breakpoint.c (read_uploaded_action): Likewise.
4518         (create_tracepoint_from_upload): Likewise.
4519         * ctf.c (ctf_write_uploaded_tp): Likewise.
4520         (SET_ARRAY_FIELD): Likewise.
4521         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4522
4523 2018-03-30  Tom Tromey  <tom@tromey.com>
4524
4525         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4526         std::unique_ptr.
4527         (svr4_keep_data_in_core): Update.
4528         (svr4_read_so_list): Update.
4529
4530 2018-03-30  Tom Tromey  <tom@tromey.com>
4531
4532         * windows-nat.c (handle_output_debug_string, handle_exception):
4533         Update.
4534         * target.h (target_read_string): Update.
4535         * target.c (target_read_string): Change "string" to
4536         unique_xmalloc_ptr.
4537         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4538         Update.
4539         * solib-frv.c (frv_current_sos): Update.
4540         * solib-dsbt.c (dsbt_current_sos): Update.
4541         * solib-darwin.c (darwin_current_sos): Update.
4542         * linux-thread-db.c (inferior_has_bug): Update.
4543         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4544         Update.  Remove alloca.
4545         * ada-lang.c (ada_main_name): Update.
4546
4547 2018-03-30  Tom Tromey  <tom@tromey.com>
4548
4549         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4550         (struct dwo_file_deleter): New.
4551         (dwo_file_up): New typedef.
4552         (open_and_init_dwo_file): Use dwo_file_up.
4553         (free_dwo_file_cleanup): Remove.
4554
4555 2018-03-30  Tom Tromey  <tom@tromey.com>
4556
4557         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4558         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4559
4560 2018-03-30  Tom Tromey  <tom@tromey.com>
4561
4562         * dwarf2read.c (class free_cached_comp_units): New class.
4563         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4564         (free_cached_comp_units): Remove function.
4565
4566 2018-03-30  Tom Tromey  <tom@tromey.com>
4567
4568         * utils.h (make_cleanup_unpush_target): Remove.
4569         * inf-ptrace.c (struct target_unpusher): New.
4570         (target_unpush_up) New typedef.
4571         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4572         target_unpush_up.
4573         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4574
4575 2018-03-27  Tom Tromey  <tom@tromey.com>
4576
4577         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4578
4579 2018-03-27  Pedro Alves  <palves@redhat.com>
4580             Tom Tromey  <tom@tromey.com>
4581
4582         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4583         destructor.  Now a class.
4584         (gdb_readline_wrapper_cleanup): Remove function.
4585         (gdb_readline_wrapper): Remove cleanups.
4586
4587 2018-03-27  Tom Tromey  <tom@tromey.com>
4588
4589         * typeprint.h (struct type_print_options) <local_typedefs,
4590         global_typedefs>: Remove "struct" keyword.
4591         (class typedef_hash_table): New class.
4592         (recursively_update_typedef_hash, add_template_parameters)
4593         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4594         (find_typedef_in_hash): Don't declare.
4595         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4596         (typedef_hash_table::recursively_update): Rename from
4597         recursively_update_typedef_hash.  Now a member.
4598         (typedef_hash_table::add_template_parameters): Rename from
4599         add_template_parameters.  Now a member.
4600         (typedef_hash_table::typedef_hash_table): Now a constructor;
4601         rename from create_typedef_hash.
4602         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4603         rename from free_typedef_hash.
4604         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4605         (do_free_global_table): Remove.
4606         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4607         from copy_type_recursive.
4608         (create_global_typedef_table): Remove.
4609         (typedef_hash_table::find_global_typedef): Now a member of
4610         typedef_hash_table.
4611         (typedef_hash_table::find_typedef): Rename from
4612         find_typedef_in_hash; now a member.
4613         (whatis_exp): Update.
4614         * extension.h (struct ext_lang_type_printers): Add constructor and
4615         destructor.
4616         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4617         declare.
4618         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4619         Now a constructor; rename from start_ext_lang_type_printers.
4620         (ext_lang_type_printers): Now a destructor; rename from
4621         free_ext_lang_type_printers.
4622         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4623         Update.
4624         (c_type_print_base_struct_union): Update.  Remove cleanups.
4625
4626 2018-03-27  Tom Tromey  <tom@tromey.com>
4627
4628         * dwarf-index-write.c: Include <cmath>.
4629
4630 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4631
4632         * NEWS: Add entry describing new "set|show varsize-limit" command.
4633         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4634         command.
4635         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4636         "set variable".
4637
4638 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4639
4640         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4641         dwarf-index-write.c
4642         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4643         * dwarf-index-common.c: New file.
4644         * dwarf-index-common.h: New file.
4645         * dwarf-index-write.c: New file.
4646         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4647         (struct dwarf2_section_info): Move from here.
4648         (dwarf2_section_info_def): Likewise.
4649         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4650         (offset_type): Likewise.
4651         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4652         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4653         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4654         (byte_swap): Likewise.
4655         (MAYBE_SWAP): Likewise.
4656         (dwarf2_per_cu_ptr): Likewise.
4657         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4658         (struct tu_stats): Likewise.
4659         (struct dwarf2_per_objfile): Likewise.
4660         (struct dwarf2_per_cu_data): Likewise.
4661         (struct signatured_type): Likewise.
4662         (sig_type_ptr): Likewise.
4663         (DEF_VEC_P (sig_type_ptr)): Likewise.
4664         (INDEX4_SUFFIX): Likewise.
4665         (INDEX5_SUFFIX): Likewise.
4666         (DEBUG_STR_SUFFIX): Likewise.
4667         (dwarf2_read_section): Make non-static.
4668         (mapped_index_string_hash): Move from here.
4669         (dwarf5_djb_hash): Likewise.
4670         (file_write): Likewise.
4671         (class data_buf): Likewise.
4672         (struct symtab_index_entry): Likewise.
4673         (struct mapped_symtab): Likewise.
4674         (find_slot): Likewise.
4675         (hash_expand): Likewise.
4676         (add_index_entry): Likewise.
4677         (uniquify_cu_indices): Likewise.
4678         (class c_str_view): Likewise.
4679         (class c_str_view_hasher): Likewise.
4680         (class vector_hasher): Likewise.
4681         (write_hash_table): Likewise.
4682         (psym_index_map): Likewise.
4683         (struct addrmap_index_data): Likewise.
4684         (add_address_entry): Likewise.
4685         (add_address_entry_worker): Likewise.
4686         (write_address_map): Likewise.
4687         (symbol_kind): Likewise.
4688         (write_psymbols): Likewise.
4689         (struct signatured_type_index_data): Likewise.
4690         (write_one_signatured_type): Likewise.
4691         (recursively_count_psymbols): Likewise.
4692         (recursively_write_psymbols): Likewise.
4693         (class debug_names): Likewise.
4694         (check_dwarf64_offsets): Likewise.
4695         (psyms_seen_size): Likewise.
4696         (write_gdbindex): Likewise.
4697         (write_debug_names): Likewise.
4698         (assert_file_size): Likewise.
4699         (write_psymtabs_to_index): Likewise.
4700         (save_gdb_index_command): Likewise.
4701         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4702         command.
4703         * dwarf2read.h: New file.
4704
4705 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4706
4707         PR gdb/22670
4708         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4709         symbol name if the CU's language stores symbol names in linkage
4710         format.
4711         * language.h (struct language_defn)
4712         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4713         all instances of this struct.
4714
4715 2018-03-26  Tom Tromey  <tom@tromey.com>
4716
4717         * stack.c (backtrace_command_1): Remove verbose code.
4718
4719 2018-03-26  Tom Tromey  <tom@tromey.com>
4720
4721         * python/py-framefilter.c (py_print_type): Don't catch
4722         exceptions.  Return void.
4723         (py_print_value): Likewise.
4724         (py_print_single_arg): Likewise.
4725         (enumerate_args): Don't catch exceptions.
4726         (py_print_args): Likewise.
4727         (py_print_frame): Likewise.
4728         (gdbpy_apply_frame_filter): Catch exceptions here.
4729
4730 2018-03-26  Tom Tromey  <tom@tromey.com>
4731
4732         * stack.c (_initialize_stack): Remove trailing newlines from help
4733         text.  Add "Usage" line to "backtrace" help.
4734
4735 2018-03-26  Tom Tromey  <tom@tromey.com>
4736
4737         PR python/16486:
4738         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4739
4740 2018-03-26  Tom Tromey  <tom@tromey.com>
4741
4742         * python/py-framefilter.c (py_print_single_arg): Return
4743         EXT_LANG_BT_ERROR from catch.
4744
4745 2018-03-26  Tom Tromey  <tom@tromey.com>
4746
4747         PR backtrace/15584:
4748         * stack.c (backtrace_command_1): Move some code into no-filters
4749         "if".
4750
4751 2018-03-26  Tom Tromey  <tom@tromey.com>
4752
4753         * python/py-framefilter.c (throw_quit_or_print_exception): New
4754         function.
4755         (gdbpy_apply_frame_filter): Use it.
4756
4757 2018-03-26  Tom Tromey  <tom@tromey.com>
4758
4759         PR cli/17716:
4760         * python/py-framefilter.c (py_print_type, py_print_value)
4761         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4762         RETURN_MASK_ERROR.
4763
4764 2018-03-26  Tom Tromey  <tom@tromey.com>
4765
4766         * python/py-framefilter.c (enumerate_args): Use
4767         gdb::unique_xmalloc_ptr.
4768
4769 2018-03-26  Tom Tromey  <tom@tromey.com>
4770
4771         * python/py-framefilter.c (py_print_frame): Return
4772         EXT_LANG_BT_OK.
4773         (gdbpy_apply_frame_filter): Update comment.
4774         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4775         Remove.
4776         <EXT_LANG_BT_NO_FILTERS>: Change value.
4777
4778 2018-03-26  Tom Tromey  <tom@tromey.com>
4779
4780         PR backtrace/15582:
4781         * stack.c (backtrace_command): Parse "hide" argument.
4782         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4783         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4784         constant.
4785
4786 2018-03-26  Tom Tromey  <tom@tromey.com>
4787
4788         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4789         add "flags".
4790         (backtrace_command): Remove "fulltrace", add "flags".
4791
4792 2018-03-26  Tom Tromey  <tom@tromey.com>
4793
4794         * stack.c (backtrace_command): Rewrite command line parsing.
4795
4796 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4797
4798         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4799
4800 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4801
4802         * filename-seen-cache.h: Add include guard.
4803
4804 2018-03-26  Keith Seitz  <keiths@redhat.com>
4805
4806         * symfile.c (place_section): Remove "struct" from section_addr_info
4807         in comment.
4808         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4809         "struct" keyword from section_addr_info.
4810
4811 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4812
4813         * regformats/regdef.h (reg): Add constructors.
4814
4815 2018-03-25  Pedro Alves  <palves@redhat.com>
4816
4817         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4818         if then/else bodies in var_func_name extraction.
4819
4820 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4821
4822         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4823         lookup_minimal_symbol() to find symbol entry.
4824         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4825
4826 2018-03-23  Keith Seitz  <keiths@redhat.com>
4827
4828         PR c++/22968
4829         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4830         nested type definitions for C++, too.
4831
4832 2018-03-23  Tom Tromey  <tom@tromey.com>
4833
4834         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4835         a typedef.
4836         (macho_register_oso): Remove.
4837         (macho_symtab_read): Take a std::vector.
4838         (oso_el_compare_name): Now a std::sort comparator.
4839         (macho_symfile_read_all_oso): Take a std::vector.
4840         (macho_symfile_read): Use std::vector.  Remove cleanups.
4841
4842 2018-03-22  Tom Tromey  <tom@tromey.com>
4843
4844         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4845         (record_full_goto_bookmark): Use std::string.
4846
4847 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4848
4849         PR tdep/18295
4850         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4851         a single mask.
4852
4853 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4854
4855         * rs6000-tdep.c (store_insn_p): New function.
4856         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4857         and cr_reg to their unshifted values. Use store_insn_p to
4858         match LR saves using either R1 or fdata->alloca_reg. Use
4859         store_insn_p to match CR saves. Set alloca_reg_offset
4860         when alloca_reg and framep are set. Remove lr_reg shift
4861         when assigning to fdata->lr_register.
4862
4863 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4864
4865         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4866         command line args instead of emitting a warning.
4867
4868 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4869
4870         * tracepoint.h (struct static_tracepoint_marker): Initialize
4871         fields, define default constructor, move constructor and move
4872         assignment, disable the rest.
4873         <str_id, extra>: Make std::string.
4874         (release_static_tracepoint_marker): Remove.
4875         (free_current_marker): Remove.
4876         * tracepoint.c (free_current_marker): Remove.
4877         (parse_static_tracepoint_marker_definition): Adjust to
4878         std::string, use new hex2str overload.
4879         (release_static_tracepoint_marker): Remove.
4880         (print_one_static_tracepoint_marker): Get marker by reference
4881         and adjust to std::string.
4882         (info_static_tracepoint_markers_command): Adjust to std::vector
4883         changes
4884         * target.h (static_tracepoint_marker_p): Remove typedef.
4885         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4886         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4887         bool.
4888         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4889         * target-debug.h
4890         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4891         (target_debug_print_std_vector_static_tracepoint_marker): New.
4892         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4893         to...
4894         (target_debug_print_static_tracepoint_marker_p): ... this.
4895         * target-delegates.c: Re-generate.
4896         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4897         Make std::string.
4898         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4899         (decode_static_tracepoint_spec): Adjust to std::vector.
4900         (tracepoint_print_one_detail): Adjust to std::string.
4901         (strace_marker_decode_location): Adjust to std::string.
4902         (update_static_tracepoint): Adjust to std::string, remove call
4903         to release_static_tracepoint_marker.
4904         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4905         Adjust to std::vector.
4906         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4907         (remote_static_tracepoint_markers_by_strid): Adjust to
4908         std::vector.
4909         * common/rsp-low.h (hex2str): New overload with explicit count
4910         of bytes.
4911         * common/rsp-low.c (hex2str): New overload with explicit count
4912         of bytes.
4913         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4914         (_initialize_rsp_low_selftests): Add test_hex2str test.
4915         * unittests/tracepoint-selftests.c
4916         (test_parse_static_tracepoint_marker_definition): Adjust to
4917         std::string.
4918
4919 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4920
4921         * tracepoint.c (parse_static_tracepoint_marker_definition):
4922         Consider case where the definition is followed by more
4923         definitions.
4924         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4925         tracepoint-selftests.c.
4926         * unittests/tracepoint-selftests.c: New.
4927
4928 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4929
4930         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4931         Carvalho.
4932
4933 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4934
4935         * symtab.c (find_pc_sect_line): fixed indentation.
4936
4937 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4938
4939         * symtab.c (find_pc_sect_line): now uses binary search.
4940
4941 2018-03-19  Tom Tromey  <tom@tromey.com>
4942
4943         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4944         "IDENT" production.
4945
4946 2018-03-19  Pedro Alves  <palves@redhat.com>
4947             Tom Tromey  <tom@tromey.com>
4948
4949         * unittests/observable-selftests.c: New file.
4950         * common/observable.h: New file.
4951         * observable.h: New file.
4952         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4953         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4954         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4955         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4956         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4957         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4958         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4959         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4960         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4961         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4962         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4963         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4964         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4965         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4966         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4967         tui/tui-interp.c, valops.c: Update all users.
4968         * tui/tui-hooks.c (tui_bp_created_observer)
4969         (tui_bp_deleted_observer, tui_bp_modified_observer)
4970         (tui_inferior_exit_observer, tui_before_prompt_observer)
4971         (tui_normal_stop_observer, tui_register_changed_observer):
4972         Remove.
4973         (tui_observers_token): New global.
4974         (attach_or_detach, tui_attach_detach_observers): New functions.
4975         (tui_install_hooks, tui_remove_hooks): Use
4976         tui_attach_detach_observers.
4977         * record-btrace.c (record_btrace_thread_observer): Remove.
4978         (record_btrace_thread_observer_token): New global.
4979         * observer.sh: Remove.
4980         * observer.c: Rename to observable.c.
4981         * observable.c (namespace gdb_observers): Define new objects.
4982         (observer_debug): Move into gdb_observers namespace.
4983         (struct observer, struct observer_list, xalloc_observer_list_node)
4984         (xfree_observer_list_node, generic_observer_attach)
4985         (generic_observer_detach, generic_observer_notify): Remove.
4986         (_initialize_observer): Update.
4987         Don't include observer.inc.
4988         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4989         (clean mostlyclean): Likewise.
4990         (observer.h, observer.inc): Remove targets.
4991         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4992         (COMMON_SFILES): Use observable.c, not observer.c.
4993         * .gitignore: Remove observer.h.
4994
4995 2018-03-18  Tom Tromey  <tom@tromey.com>
4996
4997         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4998         gdb::def_vector.
4999         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
5000
5001 2018-03-17  Tom Tromey  <tom@tromey.com>
5002
5003         * auto-load.c (auto_load_objfile_script_1): Use std::string.
5004
5005 2018-03-17  Tom Tromey  <tom@tromey.com>
5006
5007         * target.c (class scoped_target_fd): New.
5008         (target_fileio_close_cleanup): Remove.
5009         (target_fileio_read_alloc_1): Use scoped_target_fd.
5010
5011 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
5012
5013         * silent-rules.mk: New.
5014         * Makefile.in: Include silent-rules.mk
5015         (srcdir, VPATH, top_srcdir): Move up.
5016         (COMPILE): Add ECHO_CXX.
5017         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
5018         (init.c): Add ECHO_INIT_C.
5019         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
5020         (version.c): Add ECHO_GEN.
5021         (printcmd.o): Add ECHO_CXX.
5022         (target-float.o): Add ECHO_CXX.
5023         (ada-exp.o): Add ECHO_CXX.
5024         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
5025         (insight$(EXEEXT)): Add ECHO_CXXLD.
5026         * gnulib/configure.ac: Add AM_SILENT_RULES.
5027         * gnulib/aclocal.m4: Re-generate.
5028         * gnulib/configure: Re-generate.
5029         * gnulib/import/Makefile.in: Re-generate.
5030
5031 2018-03-16  Tom Tromey  <tom@tromey.com>
5032
5033         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
5034         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
5035         * utils.c (do_free_section_addr_info)
5036         (make_cleanup_free_section_addr_info): Remove.
5037         * symfile.h (struct other_sections): Add constructor.
5038         (struct section_addr_info): Remove.
5039         (section_addr_info): New typedef.
5040         (struct sym_fns) <sym_offsets>: Change type of parameter.
5041         (build_section_addr_info_from_objfile)
5042         (relative_addr_info_to_section_offsets, addr_info_make_relative)
5043         (default_symfile_offsets, symbol_file_add)
5044         (symbol_file_add_from_bfd)
5045         (build_section_addr_info_from_section_table): Update.
5046         (alloc_section_addr_info, free_section_addr_info): Don't declare.
5047         * symfile.c (alloc_section_addr_info): Remove.
5048         (build_section_addr_info_from_section_table): Change return type.
5049         Update.
5050         (build_section_addr_info_from_bfd)
5051         (build_section_addr_info_from_objfile): Likewise.
5052         (free_section_addr_info): Remove.
5053         (relative_addr_info_to_section_offsets): Change type of "addrs".
5054         (addrs_section_compar): Now a std::sort comparator.
5055         (addrs_section_sort): Change return type.
5056         (addr_info_make_relative): Change type of "addrs".  Update.
5057         (default_symfile_offsets, syms_from_objfile_1)
5058         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
5059         (symbol_file_add_separate): Update.
5060         (symbol_file_add): Change type of "addrs".  Update.
5061         (add_symbol_file_command): Update.  Remove cleanups.
5062         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
5063         cleanups.
5064         * symfile-debug.c (debug_sym_offsets): Change type of "info".
5065         * solib.c (solib_read_symbols): Update.
5066         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
5067         * machoread.c (macho_symfile_offsets): Update.
5068         * jit.c (jit_bfd_try_read_symtab): Update.
5069
5070 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
5071
5072         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5073         unittests/utils-selftests.c.
5074         * unittests/utils-selftests.c: New file.
5075
5076 2018-03-14  Tom Tromey  <tom@tromey.com>
5077
5078         PR cli/14977:
5079         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
5080         for NULL.
5081
5082 2018-03-14  Tom Tromey  <tom@tromey.com>
5083
5084         PR cli/19918:
5085         * printcmd.c (printf_pointer): Allow "-" in format.
5086
5087 2018-03-14  Tom Tromey  <tom@tromey.com>
5088
5089         * printcmd.c (_initialize_printcmd): Add usage to printf.
5090
5091 2018-03-14  Yao Qi  <qiyao@sourceware.org>
5092
5093         * MAINTAINERS: Update my email address.
5094
5095 2018-03-13  Tom Tromey  <tom@tromey.com>
5096
5097         * machoread.c (macho_check_dsym): Change filenamep to a
5098         std::string*.
5099         (macho_symfile_read): Update.
5100         * symfile.c (load_command): Use std::string.
5101
5102 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5103
5104         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
5105         to error message string.
5106         (riscv_register_name): Use xsnprintf instead of sprintf.
5107         (riscv_insn::fetch_instruction): Use gdb_assert instead of
5108         internal_error.
5109         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
5110         error.
5111         (riscv_push_dummy_call): Likewise.
5112
5113 2018-03-12  Tom Tromey  <tom@tromey.com>
5114
5115         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
5116         Use gdb::byte_vector.
5117         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
5118
5119 2018-03-12  Yao Qi  <yao.qi@linaro.org>
5120
5121         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
5122         parameter type to readable_regcache.
5123         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
5124         the declaration.
5125
5126 2018-03-11  Tom Tromey  <tom@tromey.com>
5127
5128         * dwarf2read.c (struct nextfield): Add initializers.
5129         (struct nextfnfield): Remove.
5130         (struct fnfieldlist): Add initializers.  Remove "length" and
5131         "head", use std::vector.
5132         (struct decl_field_list): Remove.
5133         (struct field_info): Add initializers.
5134         <fields, baseclasses>: Now std::vector.
5135         <nbaseclasses, nfnfields, typedef_field_list_count,
5136         nested_types_list_count>: Remove.
5137         (dwarf2_add_field, dwarf2_add_type_defn)
5138         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
5139         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
5140         (process_structure_scope): Update.
5141
5142 2018-03-11  Tom Tromey  <tom@tromey.com>
5143
5144         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
5145         for use by std::sort.
5146         (build_type_psymtabs_1): Use std::vector.
5147
5148 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
5149
5150         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
5151         and LIBMPFR in the printed configuration.
5152
5153 2018-03-08  Tom Tromey  <tom@tromey.com>
5154
5155         * source.c (get_filename_and_charpos): Use scoped_fd.
5156         * nto-procfs.c (procfs_open_1): Use scoped_fd.
5157         (procfs_pidlist): Likewise.
5158         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
5159         (iterate_over_mappings): Likewise.
5160
5161 2018-03-08  Tom Tromey  <tom@tromey.com>
5162
5163         * infcall.c (struct call_return_meta_info)
5164         <stack_temporaries_enabled>: Remove.
5165         (get_call_return_value, call_function_by_hand_dummy): Update.
5166         * thread.c (disable_thread_stack_temporaries): Remove.
5167         (enable_thread_stack_temporaries): Remove.
5168         (thread_stack_temporaries_enabled_p): Return bool.
5169         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
5170         (get_last_thread_stack_temporary): Update.
5171         * eval.c (evaluate_subexp): Update.
5172         * gdbthread.h (class enable_thread_stack_temporaries): Now a
5173         class, not a function.
5174         (value_ptr, value_vec): Remove typedefs.
5175         (class thread_info) <stack_temporaries_enabled>: Now bool.
5176         <stack_temporaries>: Now a std::vector.
5177         (thread_stack_temporaries_enabled_p)
5178         (value_in_thread_stack_temporaries): Return bool.
5179
5180 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
5181
5182         * remote.c (putpkt_binary): Fix omitted bytes reporting.
5183         (getpkt_or_notif_sane_1): Likewise.
5184
5185 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5186
5187         * build-id.c (build_id_to_debug_bfd): Use std::string.
5188
5189 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5190
5191         * build-id.c (find_separate_debug_file_by_buildid): Return
5192         std::string.
5193         * build-id.h (find_separate_debug_file_by_buildid): Return
5194         std::string.
5195         * coffread.c (coff_symfile_read): Adjust to std::string.
5196         * elfread.c (elf_symfile_read): Adjust to std::string.
5197         * symfile.c (separate_debug_file_exists): Change parameter to
5198         std::string.
5199         (find_separate_debug_file): Return std::string.
5200         (find_separate_debug_file_by_debuglink): Return std::string.
5201         * symfile.h (find_separate_debug_file_by_debuglink): Return
5202         std::string.
5203
5204 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5205
5206         * common/xml-utils.c (xml_escape_text): Move code to...
5207         (xml_escape_text_append): ... this new function.
5208         * common/xml-utils.h (xml_escape_text_append): New declaration.
5209         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
5210         New function.
5211         (_initialize_xml_utils): register test_xml_escape_text_append as
5212         a selftest.
5213
5214 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
5215
5216         * defs.h: Remove MAX_REGISTER_SIZE.
5217         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
5218         asserts.
5219         * python/py-unwind.c (pyuw_sniffer): Likewise.
5220
5221 2018-03-07  Tom Tromey  <tom@tromey.com>
5222
5223         * linux-tdep.c (linux_info_proc): Update.
5224         * target.h (struct target_ops) <to_fileio_readlink>: Return
5225         optional<string>.
5226         (target_fileio_readlink): Return optional<string>.
5227         * remote.c (remote_hostio_readlink): Return optional<string>.
5228         * inf-child.c (inf_child_fileio_readlink): Return
5229         optional<string>.
5230         * target.c (target_fileio_readlink): Return optional<string>.
5231
5232 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5233
5234         * regcache.c (cooked_read_test): Add riscv to the list of
5235         architectures that have a save_reggroup.
5236
5237 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5238
5239         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
5240         value is not a dynamic class object.
5241
5242 2018-03-06  Tom Tromey  <tom@tromey.com>
5243
5244         * rust-exp.y: Formatting fixes.
5245
5246 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5247
5248         * riscv-tdep.c (riscv_register_name): Remove target description
5249         support.
5250         (riscv_gdbarch_init): Remove target description check.
5251
5252 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5253
5254         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
5255         comment.
5256         * riscv-tdep.h: Likewise.
5257
5258 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5259
5260         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
5261         (riscv_pseudo_register_write): Delete.
5262         (riscv_gdbarch_init): Remove all use of pseudo registers.
5263
5264 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5265
5266         * record-btrace.c (btrace_print_lines): Replace cleanup
5267         parameter with RAII equivalents.
5268         (btrace_insn_history): Replace cleanup with RAII equivalents.
5269         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5270         make_cleanup_ui_out_tuple_begin_end): Remove.
5271         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5272         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5273         make_cleanup_ui_out_list_begin_end): Remove.
5274
5275 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5276
5277         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5278         parameter types to std::vector.  Use bool.
5279         (record_btrace_wait): Replace VEC(tp_t) with
5280         std::vector<thread_info *>.
5281         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5282
5283 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5284
5285         * record-btrace.c (record_btrace_disable_callback): Remove.
5286         (struct scoped_btrace_disable): New.
5287         (record_btrace_open): Use scoped_btrace_disable.
5288
5289 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5290
5291         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5292         reading values from registers.
5293
5294 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5295
5296         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5297         where appropriate.
5298
5299 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5300
5301         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5302         change parameter type.  Use GDB's print functions, and use
5303         core_addr_to_string where appropriate.
5304         (riscv_push_dummy_call): Use core_addr_to_string where
5305         appropriate, update call to riscv_print_arg_location, and reindent
5306         a few lines.
5307         (riscv_return_value): Update call to riscv_print_arg_location.
5308
5309 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5310             Tim Newsome <tim@sifive.com>
5311             Albert Ou <a0u@eecs.berkeley.edu>
5312             Darius Rad <darius@bluespec.com>
5313
5314         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5315         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5316         (ALLDEPFILES): Add riscv-tdep.c
5317         * configure.tgt: Add riscv support.
5318         * riscv-tdep.c: New file.
5319         * riscv-tdep.h: New file.
5320         * NEWS: Mention new target.
5321         * MAINTAINERS: Add entry for riscv.
5322
5323 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5324
5325         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5326         fields within aggregates.
5327
5328 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5329
5330         * record-btrace.c (btrace_print_lines): Change type of flags to
5331         gdb_disassembly_flags.
5332
5333 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5334
5335         * fbsd-nat.c: Include "inf-ptrace.h".
5336         (USE_SIGTRAP_SIGINFO): Conditionally define.
5337         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5338         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5339         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5340         function.
5341         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5342         Likewise.
5343         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5344         Likewise.
5345         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5346         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5347         "supports_stopped_by_hw_breakpoint" target methods.
5348
5349 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5350
5351         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5352         * fbsd-nat.c (debug_fbsd_nat): New variable.
5353         (show_fbsd_nat_debug): New function.
5354         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5355         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5356
5357 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5358
5359         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5360         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5361         prototype.
5362         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5363         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5364         method.
5365
5366 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5367
5368         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5369         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5370
5371 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5372
5373         * charset.c (struct charset_vector): New.
5374         (charsets): Change type to charset_vector.
5375         (find_charset_names): Adjust.
5376         (add_one): Adjust.
5377         (_initialize_charset): Adjust.
5378
5379 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5380
5381         * progspace.h (struct program_space) <deleted_solibs>: Change
5382         type to std::vector<std::string>.
5383         * progspace.c (clear_program_space_solib_cache): Adjust.
5384         * breakpoint.c (print_solib_event): Adjust.
5385         (check_status_catch_solib): Adjust.
5386         * solib.c (update_solib_list): Adjust.
5387         * ui-out.h (class ui_out) <field_string>: New overload.
5388         * ui-out.c (ui_out::field_string): New overload.
5389
5390 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5391
5392         * progspace.h (struct program_space): Add constructor and
5393         destructor, initialize fields.
5394         (add_program_space): Remove.
5395         * progspace.c (add_program_space): Rename to...
5396         (program_space::program_space): ... this.
5397         (release_program_space): Rename to...
5398         (program_space::~program_space): ... this.
5399         (delete_program_space): Use delete to delete program_space.
5400         (initialize_progspace): Use new to allocate program_space.
5401         * inferior.c (add_inferior_with_spaces): Likewise.
5402         (clone_inferior_command): Likewise.
5403         * infrun.c (follow_fork_inferior): Likewise.
5404         (handle_vfork_child_exec_or_exit): Likewise.
5405
5406 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5407
5408         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5409         (delim_string_to_char_ptr_vec): Return std::vector of
5410         gdb::unique_xmalloc_ptr.
5411         (dirnames_to_char_ptr_vec_append): Take std::vector of
5412         gdb::unique_xmalloc_ptr.
5413         (dirnames_to_char_ptr_vec): Return std::vector of
5414         gdb::unique_xmalloc_ptr.
5415         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5416         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5417         (delim_string_to_char_ptr_vec): Return an std::vector of
5418         gdb::unique_xmalloc_ptr, adjust the code.
5419         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5420         gdb::unique_xmalloc_ptr, adjust the code.
5421         (dirnames_to_char_ptr_vec): Return an std::vector of
5422         gdb::unique_xmalloc_ptr, adjust the code.
5423         * auto-load.c (auto_load_safe_path_vec): Change type to
5424         std::vector of gdb::unique_xmalloc_ptr.
5425         (auto_load_expand_dir_vars): Return an std::vector of
5426         gdb::unique_xmalloc_ptr, adjust the code.
5427         (auto_load_safe_path_vec_update): Adjust.
5428         (filename_is_in_auto_load_safe_path_vec): Adjust.
5429         (auto_load_objfile_script_1): Adjust.
5430         * build-id.c (build_id_to_debug_bfd): Adjust.
5431         * linux-thread-db.c (thread_db_load_search): Adjust.
5432         * source.c (add_path): Adjust.
5433         (openp): Adjust.
5434         * symfile.c (find_separate_debug_file): Adjust.
5435         * utils.c (do_free_char_ptr_vec): Remove.
5436         (make_cleanup_free_char_ptr_vec): Remove.
5437
5438 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5439
5440         PR gdb/22907
5441         * common/pathstuff.c: Conditionally include "<windows.h>".
5442
5443 2018-03-01  Georg Sauthoff  <mail@georg.so>
5444
5445         PR gdb/22888
5446         * gcore.in: Quote variables and switch interpreter to bash.
5447
5448 2018-03-01  Tom Tromey  <tom@tromey.com>
5449
5450         * dwarf2read.c (alloc_discriminant_info): Fix default_index
5451         assertion.  Add assertion for discriminant_index.
5452         (quirk_rust_enum): Use correct base type name in univariant case.
5453
5454 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
5455
5456         * record.c (get_call_history_modifiers): Return a
5457         record_print_flags.
5458         (cmd_record_call_history): Adjust.
5459         * record-btrace.c (record_btrace_call_history): Adjust.
5460         (record_btrace_call_history_range): Adjust.
5461         (record_btrace_call_history_from): Adjust.
5462         * target-debug.h (target_debug_print_record_print_flags): New.
5463         * target-delegates.c: Re-generate.
5464         * target.c (target_call_history): Change flags type.
5465         (target_call_history_from): Likewise.
5466         (target_call_history_range): Likewise.
5467         * target.h (struct target_ops) <target_call_history>: Likewise.
5468         (target_call_history_from): Likewise.
5469         (target_call_history_range): Likewise.
5470
5471 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5472             Simon Marchi  <simon.marchi@polymtl.ca>
5473
5474         * common/common-utils.c: Include "sys/stat.h".
5475         (is_regular_file): Move here from "source.c"; change return
5476         type to "bool".
5477         * common/common-utils.h (is_regular_file): New prototype.
5478         * common/pathstuff.c (contains_dir_separator): New function.
5479         * common/pathstuff.h (contains_dir_separator): New prototype.
5480         * source.c: Don't include "sys/stat.h".
5481         (is_regular_file): Move to "common/common-utils.c".
5482
5483 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5484
5485         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5486         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5487         * auto-load.c: Include "common/pathstuff.h".
5488         * common/common-def.h (current_directory): Move here.
5489         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5490         function.
5491         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5492         prototype.
5493         * common/pathstuff.c: New file.
5494         * common/pathstuff.h: New file.
5495         * compile/compile.c: Include "common/pathstuff.h".
5496         * defs.h (current_directory): Move to "common/common-defs.h".
5497         * dwarf2read.c: Include "common/pathstuff.h".
5498         * exec.c: Likewise.
5499         * guile/scm-safe-call.c: Likewise.
5500         * linux-thread-db.c: Likewise.
5501         * main.c: Likewise.
5502         * nto-tdep.c: Likewise.
5503         * objfiles.c: Likewise.
5504         * source.c: Likewise.
5505         * symtab.c: Likewise.
5506         * utils.c: Include "common/pathstuff.h".
5507         (gdb_realpath): Move to "common/pathstuff.c".
5508         (gdb_realpath_keepfile): Likewise.
5509         (gdb_abspath): Likewise.
5510         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5511         (gdb_realpath_keepfile): Likewise.
5512         (gdb_abspath): Likewise.
5513
5514 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5515
5516         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5517         wildcard process pid for super_resume for kernels with a
5518         specific bug.
5519
5520 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5521
5522         * compile/compile.c (get_args): Add additional comments
5523         explaining function.
5524
5525 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5526             Tom Tromey  <tom@tromey.com>
5527
5528         * target.h (memory_write_request_s): Remove typedef.  Don't define
5529         VEC.
5530         (target_write_memory_blocks): Change argument to std::vector.
5531         (struct memory_write_request): Add constructor.
5532         * target-memory.c (compare_block_starting_address): Return bool.
5533         Change argument types.
5534         (claim_memory): Change arguments to use std::vector.
5535         (split_regular_and_flash_blocks, blocks_to_erase)
5536         (compute_garbled_blocks): Likewise.
5537         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5538         (target_write_memory_blocks): Change argument to std::vector.
5539         * symfile.c (struct load_section_data): Add constructor and
5540         destructor.  Use std::vector for "requests".
5541         (struct load_progress_data): Add initializers.
5542         (load_section_callback): Update.  Use "new".
5543         (clear_memory_write_data): Remove.
5544         (generic_load): Update.
5545
5546 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5547
5548         * arch/aarch64.h: Use common/tdesc.h.
5549
5550 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5551
5552         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5553         architecture with a 64-bit ABI.
5554
5555 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5556
5557         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5558         ahead of target description loading.
5559
5560 2018-02-26  Tom Tromey  <tom@tromey.com>
5561
5562         * stack.c (backtrace_command_1): Update.
5563         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5564         of "flags".
5565         * python/py-framefilter.c (py_print_frame)
5566         (gdbpy_apply_frame_filter): Change type of "flags".
5567         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5568         of "flags".
5569         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5570         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5571         * extension.h (enum frame_filter_flag): Rename from
5572         frame_filter_flags.
5573         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5574         (apply_ext_lang_frame_filter): Change type of "flags".
5575         * extension.c (apply_ext_lang_frame_filter): Change type of
5576         "flags".
5577         * extension-priv.h (struct extension_language_ops)
5578         <apply_frame_filter>: Change type of "flags".
5579
5580 2018-02-26  Tom Tromey  <tom@tromey.com>
5581
5582         PR python/16497:
5583         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5584         off-by-one in py_end computation.
5585         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5586         PRINT_MORE_FRAMES.
5587         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5588         constant.
5589
5590 2018-02-26  Tom Tromey  <tom@tromey.com>
5591
5592         * dwarf2read.c (struct variant_field): New.
5593         (struct nextfield) <variant>: New field.
5594         (dwarf2_add_field): Handle DW_TAG_variant_part.
5595         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5596         discriminated union.
5597         (read_structure_type): Handle DW_TAG_variant_part.
5598         (handle_struct_member_die): New function, extracted from
5599         process_structure_scope.  Handle DW_TAG_variant.
5600         (process_structure_scope): Handle discriminated unions.  Call
5601         handle_struct_member_die.
5602
5603 2018-02-26  Tom Tromey  <tom@tromey.com>
5604
5605         * rust-lang.h (rust_last_path_segment): Declare.
5606         * rust-lang.c (rust_last_path_segment): Now public.  Change
5607         contract.
5608         (struct disr_info): Remove.
5609         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5610         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5611         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5612         (rust_enum_p, rust_enum_variant): New function.
5613         (rust_underscore_fields): Remove "offset" parameter.
5614         (rust_print_enum): New function.
5615         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5616         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5617         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5618         enums.
5619         (rust_internal_print_type): New function, from rust_print_type.
5620         Remove enum code.
5621         (rust_print_type): Call rust_internal_print_type.
5622         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5623         Update enum handling.
5624         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5625         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5626         (rust_union_quirks): New functions.
5627         (process_full_comp_unit, process_full_type_unit): Call
5628         rust_union_quirks.
5629         (process_structure_scope): Update rust_unions if necessary.
5630
5631 2018-02-26  Tom Tromey  <tom@tromey.com>
5632
5633         * value.h (value_union_variant): Declare.
5634         * valops.c (value_union_variant): New function.
5635         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5636         (struct discriminant_info): New.
5637         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5638         enumerator.
5639         (struct main_type) <flag_discriminated_union>: New field.
5640
5641 2018-02-26  Tom Tromey  <tom@tromey.com>
5642
5643         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5644         unittests/unpack-selftests.c.
5645         * unittests/unpack-selftests.c: New file.
5646         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5647
5648 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5649
5650         * dwarf2read.c (struct partial_die_info) <read>: New method.
5651         (read_partial_die): Remove the declaration.
5652         (load_partial_dies): Update.
5653         (partial_die_info::partial_die_info):
5654         (read_partial_die): Change it to partial_die_info::read.
5655
5656 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5657
5658         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5659         (fixup_partial_die): Remove declaration.
5660         (scan_partial_symbols): Update.
5661         (partial_die_parent_scope): Likewise.
5662         (partial_die_full_name): Likewise.
5663         (fixup_partial_die): Change it to partial_die_info::fixup.
5664
5665 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5666
5667         * dwarf2read.c (read_partial_die): Update the declaration.
5668         (load_partial_dies): Caller update.
5669         (read_partial_die): Remove one argument abbrev_len.
5670
5671 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5672
5673         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5674         assignment operator.
5675         (load_partial_dies): Use ctor and copy ctor.
5676         (read_partial_die): Update.
5677         (dwarf2_cu::find_partial_die): Use ctor.
5678
5679 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5680
5681         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5682         (find_partial_die_in_comp_unit): Change it to
5683         dwarf2_cu::find_partial_die.
5684         (find_partial_die): Update.
5685
5686 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5687
5688         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5689         is NULL.
5690
5691 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5692
5693         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5694
5695 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5696
5697         * arch/amd64.h: Use common/tdesc.h.
5698         * arch/i386.c: Likewise.
5699         * arch/i386.h: Likewise.
5700         * arch/tic6x.c: Likewise.
5701         * arch/tdesc.h: Move file from here...
5702         * common/tdesc.h: ...to here.
5703         * features/aarch64-core.c: Regenerate.
5704         * features/aarch64-fpu.c: Regenerate.
5705         * features/i386/32bit-avx.c: Regenerate.
5706         * features/i386/32bit-avx512.c: Regenerate.
5707         * features/i386/32bit-core.c: Regenerate.
5708         * features/i386/32bit-linux.c: Regenerate.
5709         * features/i386/32bit-mpx.c: Regenerate.
5710         * features/i386/32bit-pkeys.c: Regenerate.
5711         * features/i386/32bit-sse.c: Regenerate.
5712         * features/i386/64bit-avx.c: Regenerate.
5713         * features/i386/64bit-avx512.c: Regenerate.
5714         * features/i386/64bit-core.c: Regenerate.
5715         * features/i386/64bit-linux.c: Regenerate.
5716         * features/i386/64bit-mpx.c: Regenerate.
5717         * features/i386/64bit-pkeys.c: Regenerate.
5718         * features/i386/64bit-segments.c: Regenerate.
5719         * features/i386/64bit-sse.c: Regenerate.
5720         * features/i386/x32-core.c: Regenerate.
5721         * features/tic6x-c6xp.c: Regenerate.
5722         * features/tic6x-core.c: Regenerate.
5723         * features/tic6x-gp.c: Regenerate.
5724         * target-descriptions.c: Use common/tdesc.h.
5725         * target-descriptions.h: Likewise.
5726
5727 2018-02-24  Tom Tromey  <tom@tromey.com>
5728
5729         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5730         (try_thread_db_load_from_dir, thread_db_load_search): Use
5731         std::string.
5732         (info_auto_load_libthread_db_compare): Return bool.  Change
5733         argument types.
5734         (info_auto_load_libthread_db): Use std::vector, std::string.
5735         Remove cleanups.
5736
5737 2018-02-24  Tom Tromey  <tom@tromey.com>
5738
5739         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5740         std::string.
5741         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5742         std::string*.
5743         * gdbarch.c: Rebuild.
5744         * gdbarch.h: Rebuild.
5745         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5746         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5747         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5748         std::string*.
5749
5750 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5751
5752         * gdbtypes.h (sect_offset): Change type to uint64_t.
5753         (sect_offset_str): New function.
5754         * dwarf2read.c (create_addrmap_from_aranges): Use
5755         sect_offset_str.
5756         (error_check_comp_unit_head): Likewise.
5757         (create_debug_type_hash_table): Likewise.
5758         (read_cutu_die_from_dwo): Likewise.
5759         (init_cutu_and_read_dies): Likewise.
5760         (init_cutu_and_read_dies_no_follow): Likewise.
5761         (process_psymtab_comp_unit_reader): Likewise.
5762         (partial_die_parent_scope): Likewise.
5763         (peek_die_abbrev): Likewise.
5764         (process_queue): Likewise.
5765         (dwarf2_physname): Likewise.
5766         (read_namespace_alias): Likewise.
5767         (read_import_statement): Likewise.
5768         (create_dwo_cu_reader): Likewise.
5769         (create_cus_hash_table): Likewise.
5770         (lookup_dwo_cutu): Likewise.
5771         (inherit_abstract_dies): Likewise.
5772         (read_func_scope): Likewise.
5773         (read_call_site_scope): Likewise.
5774         (dwarf2_add_member_fn): Likewise.
5775         (read_common_block): Likewise.
5776         (read_module_type): Likewise.
5777         (read_typedef): Likewise.
5778         (read_subrange_type): Likewise.
5779         (load_partial_dies): Likewise.
5780         (read_partial_die): Likewise.
5781         (find_partial_die): Likewise.
5782         (read_str_index): Likewise.
5783         (dwarf2_string_attr): Likewise.
5784         (build_error_marker_type): Likewise.
5785         (lookup_die_type): Likewise.
5786         (dump_die_shallow): Likewise.
5787         (follow_die_ref): Likewise.
5788         (dwarf2_fetch_die_loc_sect_off): Likewise.
5789         (dwarf2_fetch_constant_bytes): Likewise.
5790         (follow_die_sig): Likewise.
5791         (get_signatured_type): Likewise.
5792         (get_DW_AT_signature_type): Likewise.
5793         (dwarf2_find_containing_comp_unit): Likewise.
5794         (set_die_type): Likewise.
5795
5796 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5797
5798         * arch/aarch64.c: Include "common-defs.h".
5799         * arch/amd64.c: Likewise.
5800         * arch/i386.c: Likewise.
5801
5802 2018-02-21  Tom Tromey  <tom@tromey.com>
5803
5804         * value.h: (extract_field_op): Update.
5805         * eval.c (extract_field_op): Return a const char *.
5806         * expression.h (parse_expression_for_completion): Update.
5807         * completer.c (complete_expression): Update.
5808         (add_struct_fields): Make fieldname const.
5809         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5810         (mark_completion_tag, parse_exp_in_context_1): Update.
5811         (parse_expression_for_completion): Change "name" to
5812         unique_xmalloc_ptr*.
5813
5814 2018-02-21  Tom Tromey  <tom@tromey.com>
5815
5816         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5817
5818 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5819
5820         * avr-tdep.c (avr_read_pc): Change parameter type to
5821         readable_regcache.
5822         * gdbarch.sh (read_pc): Likewise.
5823         * gdbarch.c: Re-generated.
5824         * gdbarch.h: Re-generated.
5825         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5826         readable_regcache.
5827         * ia64-tdep.c (ia64_read_pc): Likewise.
5828         * mips-tdep.c (mips_read_pc): Likewise.
5829         * spu-tdep.c (spu_read_pc): Likewise.
5830
5831 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5832
5833         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5834         * regcache-dump.c: New file.
5835         * regcache.c: Move register_dump to regcache-dump.c.
5836         (maintenance_print_registers): Likewise.
5837         (maintenance_print_raw_registers): Likewise.
5838         (maintenance_print_cooked_registers): Likewise.
5839         (maintenance_print_register_groups): Likewise.
5840         (maintenance_print_remote_registers): Likewise.
5841         (_initialize_regcache): Likewise.
5842         * regcache.h (register_dump): Moved from regcache.c.
5843
5844 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5845
5846         * regcache.c (regcache::regcache): Update.
5847         (regcache::invalidate): Move it to detached_regcache::invalidate.
5848         (get_thread_arch_aspace_regcache): Update.
5849         (regcache::raw_update): Update.
5850         (regcache::cooked_read): Remove some code.
5851         (regcache::cooked_read_value): Likewise.
5852         (regcache::raw_write): Remove assert on m_readonly_p.
5853         (regcache::raw_supply_integer): Move it to
5854         detached_regcache::raw_supply_integer.
5855         (regcache::raw_supply_zeroed): Likewise.
5856         * regcache.h (detached_regcache) <raw_supply_integer>: New
5857         declaration.
5858         <raw_supply_zeroed, invalidate>: Likewise.
5859         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5860         <invalidate>: Likewise.
5861         <m_readonly_p>: Removed.
5862
5863 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5864
5865         * infcmd.c (get_return_value): Let stop_regs point to
5866         get_current_regcache.
5867         * regcache.c (regcache::regcache): Remove.
5868         (register_dump_reg_buffer): New class.
5869         (regcache_print): Adjust.
5870         * regcache.h (regcache): Remove constructors.
5871
5872 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5873
5874         * regcache.c (class register_dump): New class.
5875         (register_dump_regcache, register_dump_none): New class.
5876         (register_dump_remote, register_dump_groups): New class.
5877         (regcache_print): Update.
5878         * regcache.h (regcache_dump_what): Move it to regcache.c.
5879         (regcache) <dump>: Remove.
5880
5881 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5882
5883         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5884          reg_buffer_rw *.
5885         (jit_unwind_reg_set_impl): Call raw_supply.
5886         (jit_frame_sniffer): Use reg_buffer_rw.
5887         * record-full.c (record_full_core_regbuf): Change its type.
5888         (record_full_core_open_1): Use reg_buffer_rw.
5889         (record_full_close): Likewise.
5890         (record_full_core_fetch_registers): Use regcache->raw_supply.
5891         (record_full_core_store_registers): Likewise.
5892         * regcache.c (regcache::get_register_status): Move it to
5893         reg_buffer.
5894         (regcache_raw_set_cached_value): Remove.
5895         (regcache::raw_set_cached_value): Remove.
5896         (regcache::raw_write): Call raw_supply.
5897         (regcache::raw_supply): Move it to reg_buffer_rw.
5898         * regcache.h (regcache_raw_set_cached_value): Remove.
5899         (reg_buffer_rw): New class.
5900
5901 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5902
5903         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5904         readonly_detached_regcache.
5905         (dummy_frame_prev_register): Use regcache->cooked_read.
5906         * frame.c (frame_save_as_regcache): Change return type.
5907         (frame_pop): Update.
5908         * frame.h (frame_save_as_regcache): Update declaration.
5909         * inferior.h (get_infcall_suspend_state_regcache): Update
5910         declaration.
5911         * infrun.c (infcall_suspend_state) <registers>: use
5912         readonly_detached_regcache.
5913         (save_infcall_suspend_state): Don't use regcache_dup.
5914         (get_infcall_suspend_state_regcache): Change return type.
5915         * linux-fork.c (struct fork_info) <savedregs>: Change to
5916         readonly_detached_regcache.
5917         <pc>: New field.
5918         (fork_save_infrun_state): Don't use regcache_dup.
5919         (info_checkpoints_command): Adjust.
5920         * mi/mi-main.c (register_changed_p): Update declaration.
5921         (mi_cmd_data_list_changed_registers): Use
5922         readonly_detached_regcache.
5923         (register_changed_p): Change parameter type to
5924         readonly_detached_regcache.
5925         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5926         readonly_detached_regcache.
5927         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5928         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5929         New.
5930         (regcache::save): Move it to reg_buffer.
5931         (regcache::restore): Change parameter type.
5932         (regcache_dup): Remove.
5933         * regcache.h (reg_buffer) <save>: New method.
5934         (readonly_detached_regcache): New class.
5935         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5936         readonly_detached_regcache.
5937         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5938
5939 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5940
5941         * frame.c (frame_save_as_regcache): Use regcache method save.
5942         (frame_pop): Use regcache method restore.
5943         * infrun.c (restore_infcall_suspend_state): Likewise.
5944         * linux-fork.c (fork_load_infrun_state): Likewise.
5945         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5946         save.
5947         * regcache.c (regcache_save): Remove.
5948         (regcache::restore): More asserts.
5949         (regcache_cpy): Remove.
5950         * regcache.h (regcache_save): Remove the declaration.
5951         (regcache::restore): Move from private to public.
5952         Remove the friend declaration of regcache_cpy.
5953         (regcache_cpy): Remove declaration.
5954
5955 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5956
5957         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5958         parameter type to 'readable_regcache *'.
5959         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5960         * arm-tdep.c (arm_neon_quad_read): Likewise.
5961         (arm_pseudo_read): Likewise.
5962         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5963         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5964         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5965         * gdbarch.c: Re-generated.
5966         * gdbarch.h: Re-generated.
5967         * gdbarch.sh (pseudo_register_read): Change parameter type to
5968         'readable_regcache *'.
5969         (pseudo_register_read_value): Likewise.
5970         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5971         (h8300_pseudo_register_read): Likewise.
5972         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5973         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5974         (i386_pseudo_register_read_into_value): Likewise.
5975         (i386_pseudo_register_read_value): Likewise.
5976         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5977         declaration.
5978         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5979         * m32c-tdep.c (m32c_raw_read): Likewise.
5980         (m32c_read_flg): Likewise.
5981         (m32c_banked_register): Likewise.
5982         (m32c_banked_read): Likewise.
5983         (m32c_sb_read): Likewise.
5984         (m32c_part_read): Likewise.
5985         (m32c_cat_read): Likewise.
5986         (m32c_r3r2r1r0_read): Likewise.
5987         (m32c_pseudo_register_read): Likewise.
5988         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5989         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5990         (mep_pseudo_cr64_read): Likewise.
5991         (mep_pseudo_register_read): Likewise.
5992         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5993         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5994         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5995         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5996         (regcache::cooked_read): Likewise.
5997         (regcache::cooked_read_value): Likewise.
5998         (regcache_cooked_read_signed):
5999         (regcache::cooked_read): Likewise.
6000         * regcache.h (readable_regcache): New class.
6001         (regcache): Inherit readable_regcache.  Move some methods to
6002         readable_regcache.
6003         * rl78-tdep.c (rl78_pseudo_register_read): Change
6004         parameter type to 'readable_regcache *'.
6005         * rs6000-tdep.c (do_regcache_raw_read): Remove.
6006         (e500_pseudo_register_read): Change parameter type to
6007         'readable_regcache *'.
6008         (dfp_pseudo_register_read): Likewise.
6009         (vsx_pseudo_register_read): Likewise.
6010         (efpr_pseudo_register_read): Likewise.
6011         * s390-tdep.c (s390_pseudo_register_read): Likewise.
6012         * sh-tdep.c (sh_pseudo_register_read): Likewise.
6013         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
6014         (sh64_pseudo_register_read): Likewise.
6015         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
6016         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6017         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
6018         (spu_pseudo_register_read): Likewise.
6019         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6020         (xtensa_pseudo_register_read): Likewise.
6021
6022 2018-02-21  Yao Qi  <yao.qi@linaro.org>
6023
6024         * regcache.c (regcache::regcache): Call reg_buffer ctor.
6025         (regcache::arch): Move it to reg_buffer::arch.
6026         (regcache::register_buffer): Likewise.
6027         (regcache::assert_regnum): Likewise.
6028         (regcache::num_raw_registers): Likewise.
6029         * regcache.h (reg_buffer): New class.
6030         (regcache): Inherit reg_buffer.
6031
6032 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
6033
6034         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
6035         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
6036
6037 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
6038
6039         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
6040
6041 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
6042
6043         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
6044         (SFILES): Remove common/*.c files.
6045         (COMMON_OBS): Remove some *.o files built from common/*.c files.
6046         * common/common.host: Add common reference.
6047         * configure.ac: Likewise.
6048         * configure: Regenerate.
6049
6050 2018-02-16  Yao Qi  <yao.qi@linaro.org>
6051
6052         * block.c (block_namespace_info): Inherit allocate_on_obstack.
6053         (block_initialize_namespace): Use new.
6054         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
6055         (dwarf2_free_objfile): Use delete.
6056         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
6057         (copy_type_recursive): Use new.
6058         * gdb_obstack.h (allocate_on_obstack): New.
6059
6060 2018-02-15  Yao Qi  <yao.qi@linaro.org>
6061
6062         PR gdb/22849
6063         * inferior.c (exit_inferior_1): Reset inf->control.
6064
6065 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
6066
6067         * ada-lang.c (ada_to_fixed_value_create): Delete advance
6068         declaration.
6069
6070 2018-02-14  Pedro Alves  <palves@redhat.com>
6071
6072         * frame-unwind.c (frame_unwind_try_unwinder): Always call
6073         frame_cleanup_after_sniffer on exception.
6074
6075 2018-02-14  Tom Tromey  <tom@tromey.com>
6076
6077         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
6078         const.
6079         (solib_bfd_open): Make pathname const.
6080         * solib.c (solib_bfd_open): Make pathname const.
6081         * solib-spu.c (spu_bfd_fopen): Make name const.
6082         (spu_bfd_open): Make pathname const.
6083         * solib-darwin.c (darwin_bfd_open): Make pathname const.
6084         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
6085
6086 2018-02-14  Tom Tromey  <tom@tromey.com>
6087
6088         * symfile.c (symfile_bfd_open): Update.
6089         * source.h (openp, source_full_path_of, find_and_open_source):
6090         Change argument type to unique_xmalloc_ptr.
6091         * source.c (openp): Take a unique_xmalloc_ptr.
6092         (source_full_path_of, find_and_open_source): Likewise.
6093         (open_source_file, symtab_to_fullname): Update.
6094         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
6095         unique_xmalloc_ptr.
6096         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
6097         (exec_file_find): Update.
6098         * psymtab.c (psymtab_to_fullname): Update.
6099         * nto-tdep.h (nto_find_and_open_solib): Update.
6100         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
6101         unique_xmalloc_ptr.
6102         * exec.c (exec_file_attach): Update.
6103         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
6104         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
6105
6106 2018-02-14  Tom Tromey  <tom@tromey.com>
6107
6108         * solib.c: Include source.h.
6109         * nto-tdep.c: Include source.h.
6110         * mi/mi-cmd-env.c: Include source.h.
6111         * infcmd.c: Include source.h.
6112         * exec.c: Include source.h.
6113         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
6114         (add_path, directory_switch, source_path, init_source_path): Move
6115         declarations...
6116         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
6117         (add_path, directory_switch, source_path, init_source_path):
6118         ...here.
6119
6120 2018-02-14  Tom Tromey  <tom@tromey.com>
6121
6122         * solist.h (exec_file_find, solib_find): Return
6123         unique_xmalloc_ptr.
6124         (solib_bfd_fopen): Take a const char *.
6125         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
6126         (exec_file_find, solib_find): Likewise.
6127         (solib_bfd_fopen): Do not take ownership of "pathname".
6128         (solib_bfd_open): Use unique_xmalloc_ptr.
6129         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
6130         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
6131         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
6132         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
6133
6134 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
6135
6136         * ada-lang.c (name_match_type_from_name): Remove reference to
6137         ada_name_for_lookup in function's documentation.
6138         * ada-lang.h (ada_name_for_lookup): Delete declaration.
6139
6140 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6141
6142         * defs.h (enum openp_flags): New enum.
6143         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
6144         Move to enum openp_flags.
6145         (openp_flags): New enum flags.
6146         (openp): Change parameter type to openp_flags.
6147         * source.c (openp): Change parameter type to openp_flags.
6148         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
6149         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
6150
6151 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6152
6153         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
6154         per-command.
6155
6156 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6157
6158         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
6159         into...
6160         (class dwarf2_queue_guard): ...the destructor of this new class.
6161         (dw2_do_instantiate_symtab): Create instance of the new class
6162         dwarf2_queue_guard, remove cleanup.
6163
6164 2018-02-09  Tom Tromey  <tom@tromey.com>
6165
6166         * source.c (find_source_lines): Don't reference past the end of
6167         the vector.
6168
6169 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6170
6171         * remote.c (remote_btrace_maybe_reopen): Change error message.
6172         * btrace.c (btrace_enable): Likewise.
6173         (parse_xml_btrace): Likewise.
6174         (parse_xml_btrace_conf): Likewise.
6175
6176 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6177
6178         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
6179         (linux_enable_pt, linux_enable_bts): Call
6180         diagnose_perf_event_open_fail.
6181
6182 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6183
6184         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
6185         Remove parameter and change return type.  Update callers.  Move it.
6186         (linux_enable_bts, linux_enable_pt): Improve error message.
6187         (linux_enable_pt): Remove zero buffer size check.
6188         (linux_enable_btrace): Improve error messages.  Remove NULL return
6189         check.
6190
6191 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6192
6193         * btrace.c (btrace_enable): Remove target_supports_btrace call.
6194         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
6195         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
6196         (linux_supports_pt, linux_supports_btrace): Remove.
6197         (linux_enable_bts): Call cpu_supports_bts.
6198         * nat/linux-btrace.h (linux_supports_btrace): Remove.
6199         * remote.c (remote_supports_btrace): Remove.
6200         (init_remote_ops): Remove remote_supports_btrace.
6201         * target-delegates.c: Regenerated.
6202         * target.c (target_supports_btrace): Remove.
6203         * target.h (target_ops) <to_supports_btrace>: Remove
6204         (target_supports_btrace): Remove.
6205         * x86-linux-nat.c (x86_linux_create_target): Remove
6206         linux_supports_btrace.
6207
6208 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6209
6210         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
6211         btrace failed.
6212         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
6213         exception and use message in own exception.
6214
6215 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6216
6217         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
6218         (perf_event_pt_event_type): Use gdb_file_up.
6219         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
6220         scoped_fd, and scoped_mmap.
6221
6222 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6223
6224         * common/scoped_mmap.h: New.
6225         * unittests/scoped_mmap-selftest.c: New.
6226         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6227         unittests/scoped_mmap-selftest.c.
6228
6229 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6230
6231         * common/scoped_fd.h: New.
6232         * unittests/scoped_fd-selftest.c: New.
6233         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6234         unittests/scoped_fd-selftest.c.
6235
6236 2018-02-09  Tom Tromey  <tom@tromey.com>
6237
6238         * auto-load.c (auto_load_section_scripts): Use
6239         gdb::unique_xmalloc_ptr.
6240
6241 2018-02-09  Tom Tromey  <tom@tromey.com>
6242
6243         * auto-load.c (execute_script_contents): Use std::string.
6244
6245 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
6246
6247         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
6248         Python function, rather than a new command.
6249
6250 2018-02-08  Tom Tromey  <tom@tromey.com>
6251
6252         * solib.c (solib_find_1): Use std::string.
6253         (solib_bfd_fopen): Use unique_xmalloc_ptr.
6254
6255 2018-02-08  Tom Tromey  <tom@tromey.com>
6256
6257         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
6258
6259 2018-02-08  Tom Tromey  <tom@tromey.com>
6260
6261         * source.c (find_source_lines): Use gdb::def_vector.
6262
6263 2018-02-08  Tom Tromey  <tom@tromey.com>
6264
6265         * macrocmd.c (struct temporary_macro_definition): New.
6266         (macro_define_command): Use temporary_macro_definition.  Remove
6267         cleanups.
6268         (free_macro_definition_ptr): Remove.
6269
6270 2018-02-08  Tom Tromey  <tom@tromey.com>
6271
6272         * macroexp.c (maybe_expand): Use std::string.
6273
6274 2018-02-08  Tom Tromey  <tom@tromey.com>
6275
6276         * macroexp.c (struct macro_buffer): Add initializers for some
6277         members.
6278         (init_buffer, init_shared_buffer, free_buffer)
6279         (free_buffer_return_text): Remove.
6280         (macro_buffer): New constructors.
6281         (~macro_buffer): New destructor.
6282         (macro_buffer::set_shared): New method.
6283         (macro_buffer::resize_buffer, macro_buffer::appendc)
6284         (macro_buffer::appendmem): Now methods, not free functions.
6285         (set_token, append_tokens_without_splicing, stringify)
6286         (macro_stringify): Update.
6287         (gather_arguments): Change return type.  Remove argc_p argument,
6288         add args_ptr argument.  Use std::vector.
6289         (substitute_args): Remove argc argument.  Accept std::vector.
6290         (expand): Update.  Use std::vector.
6291         (scan, macro_expand, macro_expand_next): Update.
6292
6293 2018-02-08  Tom Tromey  <tom@tromey.com>
6294
6295         * symtab.c (default_collect_symbol_completion_matches_break_on):
6296         Use unique_xmalloc_ptr.
6297         * macroscope.h: (sal_macro_scope, user_macro_scope)
6298         (default_macro_scope): Return unique_xmalloc_ptr.
6299         * macroscope.c (sal_macro_scope, user_macro_scope)
6300         (default_macro_scope): Return unique_xmalloc_ptr.
6301         * macroexp.h (macro_expand, macro_expand_once): Return
6302         unique_xmalloc_ptr.
6303         * macroexp.c (macro_expand, macro_expand_once): Return
6304         unique_xmalloc_ptr.
6305         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6306         (info_macro_command, info_macros_command): Use
6307         unique_xmalloc_ptr.
6308         * compile/compile-c-support.c (write_macro_definitions): Use
6309         unique_xmalloc_ptr.
6310         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6311
6312 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6313
6314         * value.c (value_static_field): Assign field type instead of
6315         containing type when returning an optimized out value.
6316
6317 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6318
6319         * ft32-tdep.c (ft32_read_pc): Remove.
6320         (ft32_write_pc): Remove.
6321         (ft32_gdbarch_init): Update.
6322         * m32r-tdep.c (m32r_read_pc): Remove.
6323         (m32r_gdbarch_init): Update.
6324         * mep-tdep.c (mep_read_pc): Remove.
6325         (mep_gdbarch_init): Update.
6326         * microblaze-tdep.c (microblaze_write_pc): Remove.
6327         (microblaze_gdbarch_init): Update.
6328         * mn10300-tdep.c (mn10300_read_pc): Remove.
6329         (mn10300_write_pc): Remove.
6330         (mn10300_gdbarch_init): Update.
6331         * moxie-tdep.c (moxie_read_pc): Remove.
6332         (moxie_write_pc): Remove.
6333         (moxie_gdbarch_init): Update.
6334
6335 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6336
6337         * expprint.c (print_subexp_standard): Handle
6338         OP_F77_UNDETERMINED_ARGLIST.
6339         (dump_subexp_body_standard): Likewise.
6340
6341 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6342
6343         * target-descriptions.c (tdesc_element_visitor) Add empty
6344         implementations.
6345         (tdesc_type): Move make_gdb_type from here.
6346         (tdesc_type_builtin): Likewise.
6347         (tdesc_type_vector): Likewise.
6348         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6349         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6350         (make_gdb_type_union): Likewise.
6351         (make_gdb_type_flags): Likewise.
6352         (make_gdb_type_enum): Likewise.
6353         (make_gdb_type): New function.
6354         (tdesc_register_type): Use static make_gdb_type.
6355
6356 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6357
6358         * infcmd.c (default_print_one_register_info): Align natural-format
6359         column values consistently one under another.
6360         (pad_to_column): New function.
6361
6362 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6363
6364         * dwarf2read.c (dwarf2_physname): Move commment.
6365
6366 2018-02-01  Leszek Swirski  <leszeks@google.com>
6367
6368         * varobj.c (varobj_formatted_print_options): Allow recursive
6369         pretty printing if pretty printing is enabled.
6370
6371 2018-02-01  Leszek Swirski  <leszeks@google.com>
6372
6373         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6374         names after a structop as a filename.
6375
6376 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6377
6378         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6379         (arm_record_coproc_data_proc): Likewise.
6380
6381 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6382
6383         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6384
6385 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6386
6387         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6388         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6389
6390 2018-01-31  Pedro Alves  <palves@redhat.com>
6391
6392         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6393         * inflow.c (child_terminal_save_inferior): Wrap reference to
6394         tcgetpgrp in HAVE_TERMIOS_H.
6395         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6396         _WIN32.
6397         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6398         always iterate over all inferiors.
6399         (gdbsim_cntrl_c): Adjust.
6400         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6401
6402 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6403
6404         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6405         index type is objfile-owned if the element type is as well.
6406
6407 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6408
6409         GDB 8.1 released.
6410
6411 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6412
6413         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6414         "features/s390x-linux64.c".
6415         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6416         s390_linux32 and s390x_linux64.
6417         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6418         default tdesc.
6419         * s390-tdep.c: Include "features/s390-linux32.c" and
6420         "features/s390x-linux64.c".
6421         (s390_tdesc_valid): Add check for tdesc_has_registers.
6422         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6423         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6424         tdesc_s390x_linux64.
6425         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6426         tdesc_s390x_linux64 to...
6427         * s390-tdep.h: ...here.
6428
6429 2018-01-30  Pedro Alves  <palves@redhat.com>
6430
6431         PR gdb/13211
6432         * config.in, configure: Regenerate.
6433         * configure.ac: Check for getpgid.
6434         * go32-nat.c (go32_pass_ctrlc): New.
6435         (go32_target): Install it.
6436         * inf-child.c (inf_child_target): Install
6437         child_terminal_save_inferior, child_pass_ctrlc and
6438         child_interrupt.
6439         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6440         (inf_ptrace_target): No longer install it.
6441         * infcmd.c (interrupt_target_1): Adjust.
6442         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
6443         (child_interrupt): Declare.
6444         (inferior::terminal_state): New.
6445         * inflow.c (struct terminal_info): Update comments.
6446         (inferior_process_group): Delete.
6447         (terminal_is_ours): Delete.
6448         (gdb_tty_state): New.
6449         (child_terminal_init): Adjust.
6450         (is_gdb_terminal, sharing_input_terminal_1)
6451         (sharing_input_terminal): New functions.
6452         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
6453         Set the process's actual process group in the foreground if
6454         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
6455         mark terminal as the inferior's if not sharing GDB's terminal.
6456         Don't check attach_flag.
6457         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
6458         pass down a target_terminal_state.
6459         (child_terminal_save_inferior): New, factored out from ...
6460         (child_terminal_ours_1): ... this.  Handle
6461         target_terminal_state::is_ours_for_output.
6462         (child_interrupt, child_pass_ctrlc): New.
6463         (inflow_inferior_exit): Clear the inferior's terminal_state.
6464         (copy_terminal_info): Copy the inferior's terminal state.
6465         (_initialize_inflow): Remove reference to terminal_is_ours.
6466         * inflow.h (inferior_process_group): Delete.
6467         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
6468         * procfs.c (procfs_target): Don't install procfs_interrupt.
6469         (procfs_interrupt): Delete.
6470         * remote.c (remote_serial_quit_handler): Adjust.
6471         (remote_interrupt): Remove ptid parameter.  Adjust.
6472         * target-delegates.c: Regenerate.
6473         * target.c: Include "terminal.h".
6474         (target_terminal::terminal_state): Rename to ...
6475         (target_terminal::m_terminal_state): ... this.
6476         (target_terminal::init): Adjust.
6477         (target_terminal::inferior): Adjust to per-inferior
6478         terminal_state.
6479         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
6480         (target_terminal::ours, target_terminal::ours_for_output): Use
6481         target_terminal_is_ours_kind.
6482         (target_interrupt): Remove ptid parameter.  Adjust.
6483         (default_target_pass_ctrlc): Adjust.
6484         * target.h (target_ops::to_terminal_save_inferior): New field.
6485         (target_ops::to_interrupt): Remove ptid_t parameter.
6486         (target_interrupt): Remove ptid_t parameter.  Update comment.
6487         (target_pass_ctrlc): Update comment.
6488         * target/target.h (target_terminal_state): New scoped enum,
6489         factored out of ...
6490         (target_terminal::terminal_state): ... here.
6491         (target_terminal::inferior): Update comments.
6492         (target_terminal::restore_inferior): New.
6493         (target_terminal::is_inferior, target_terminal::is_ours)
6494         (target_terminal::is_ours_for_output): Adjust.
6495         (target_terminal::scoped_restore_terminal_state): Adjust to
6496         rename, and call restore_inferior() instead of inferior().
6497         (target_terminal::scoped_restore_terminal_state::m_state): Change
6498         type.
6499         (target_terminal::terminal_state): Rename to ...
6500         (target_terminal::m_terminal_state): ... this and change type.
6501
6502 2018-01-30  Pedro Alves  <palves@redhat.com>
6503
6504         * linux-nat.c (wait_for_signal): New function.
6505         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6506         directly.
6507         (async_terminal_is_ours)
6508         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6509         (linux_nat_add_target): Don't override
6510         to_terminal_inferior/to_terminal_ours.
6511
6512 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6513
6514         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6515
6516 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6517
6518         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6519         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6520         dwarf2_per_objfile_free here.
6521         (dwarf2_per_objfile_free): Remove.
6522         (_initialize_dwarf2_read): Don't register
6523         dwarf2_per_objfile_free as a registry cleanup.
6524
6525 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6526
6527         Avoid compilation errors in MinGW native builds
6528
6529         The error is triggered by including python-internal.h, and the
6530         error message is:
6531
6532              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6533                       from build-gnulib/import/math.h:27,
6534                       from d:/usr/Python26/include/pyport.h:235,
6535                       from d:/usr/Python26/include/Python.h:58,
6536                       from python/python-internal.h:94,
6537                       from python/py-arch.c:24:
6538              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6539         using ::hypot;
6540                 ^~~~~
6541
6542         This happens because Python headers define 'hypot' to expand t
6543         '_hypot' in the Windows builds.
6544         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6545         'hypoth'.  This avoids a compilation error.
6546
6547 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6548
6549         * MAINTAINERS (Write After Approval): Fix ordering.
6550
6551 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6552
6553         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6554
6555 2018-01-26  Alan Modra  <amodra@gmail.com>
6556
6557         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6558         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6559         Remove nop.  Make const.  Comment.
6560         (powerpc32_plt_stub_so_2): New.
6561         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6562         Correct count.  Update uses.
6563         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6564         Move common code reading PLT entry word.  Correct
6565         powerpc32_plt_stub PLT address calculation.
6566         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6567         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6568         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6569         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6570         (ppc64_standard_linkage8): Likewise.
6571         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6572         Correct insns description.
6573         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6574
6575 2018-01-24  Pedro Alves  <palves@redhat.com>
6576
6577         GCC PR libstdc++/83906
6578         * gdbtypes.c (operator==(const dynamic_prop &,
6579         const dynamic_prop &)): New.
6580         (operator==(const range_bounds &, const range_bounds &)): New.
6581         (check_types_equal): Use them instead of memcmp.
6582         * gdbtypes.h (operator==(const dynamic_prop &,
6583         const dynamic_prop &)): Declare.
6584         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6585         (operator==(const range_bounds &, const range_bounds &)): Declare.
6586         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6587
6588 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6589
6590         * s390-linux-tdep.c (s390_record_address_mask)
6591         (s390_record_calc_disp_common, s390_record_calc_disp)
6592         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6593         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6594         (s390_process_record): Move to s390-tdep.c.
6595         (s390_linux_init_abi_any): Adjust.
6596         * s390-tdep.c (s390_record_address_mask)
6597         (s390_record_calc_disp_common, s390_record_calc_disp)
6598         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6599         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6600         (s390_process_record): Moved from s390-linux-tdep.c
6601         (s390_gdbarch_init): Adjust.
6602
6603 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6604
6605         * s390-linux-nat.c (s390-tdep.h): New include.
6606         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6607         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6608         (ALLDEPFILES): Add s390-tdep.c.
6609         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6610         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6611         * s390-tdep.h: ...this.  New file.
6612         * s390-linux-tdep.c (s390-tdep.h): New include.
6613         (_initialize_s390_tdep): Rename to...
6614         (_initialize_s390_linux_tdep): ...this and adjust.
6615         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6616         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6617         s390-tdep.h.
6618         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6619         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6620         (s390_is_partial_instruction, s390_software_single_step)
6621         (is_non_branch_ril, s390_displaced_step_copy_insn)
6622         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6623         (s390_prologue_data, s390_addr, s390_store, s390_load)
6624         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6625         (s390_register_call_saved, s390_guess_tracepoint_registers)
6626         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6627         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6628         (s390_pseudo_register_name, s390_pseudo_register_type)
6629         (s390_pseudo_register_read, s390_pseudo_register_write)
6630         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6631         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6632         (s390_addr_bits_remove, s390_address_class_type_flags)
6633         (s390_address_class_type_flags_to_name)
6634         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6635         (s390_function_arg_float, s390_function_arg_vector)
6636         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6637         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6638         (s390_frame_align, s390_register_return_value, s390_return_value)
6639         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6640         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6641         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6642         (s390_trad_frame_prev_register, s390_unwind_cache)
6643         (s390_prologue_frame_unwind_cache)
6644         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6645         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6646         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6647         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6648         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6649         (s390_frame_base_address, s390_local_base_address)
6650         (s390_frame_base, s390_gcc_target_options)
6651         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6652         (s390_validate_reg_range, s390_tdesc_valid)
6653         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6654         * s390-tdep.c: ...this.  New file.
6655
6656 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6657
6658         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6659         (s390_process_record, s390_gdbarch_tdep_alloc)
6660         (s390_linux_init_abi_any): Use/set new hook.
6661
6662 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6663
6664         * s390-linux-tdep.c (osabi.h): New include.
6665         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6666         (s390_linux_init_abi_any): New functions.
6667         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6668
6669 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6670
6671         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6672         tdesc_has_registers check
6673
6674 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6675
6676         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6677         (s390_validate_reg_range): New macro.
6678         (s390_gdbarch_init): Adjust.
6679
6680 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6681
6682         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6683         (s390_gdbarch_tdep_alloc): Adjust.
6684         (s390_gdbarch_init): Adjust.
6685
6686 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6687
6688         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6689         <have_tdb>: Change type to bool.
6690         (s390_gdbarch_tdep_alloc): Adjust.
6691         (s390_gdbarch_init): Adjust.
6692
6693 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6694
6695         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6696         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6697         (s390_gdbarch_tdep_alloc): New function.
6698         (s390_gdbarch_init): Allocate tdep at start and use its fields
6699         instead of separate variables.
6700
6701 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6702
6703         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6704         when looking for cached gdbarch and add comment for remaining.
6705
6706 2018-01-22  Pedro Alves  <palves@redhat.com>
6707             Sergio Durigan Junior  <sergiodj@redhat.com>
6708
6709         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6710         case.
6711
6712 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6713
6714         * MAINTAINERS: Update my company e-mail address.
6715
6716 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6717
6718         * regcache.c (cooked_write_test): New function.
6719         (_initialize_regcache): Register the test.
6720
6721 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6722
6723         * ia64-tdep.c (ia64_pseudo_register_read): Call
6724         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6725         * m32c-tdep.c (m32c_cat_read): Likewise.
6726         (m32c_r3r2r1r0_read): Likewise.
6727         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6728         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6729
6730 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6731
6732         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6733         method raw_read instead of regcache_raw_read.
6734         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6735         * arm-tdep.c (arm_neon_quad_read): Likewise.
6736         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6737         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6738         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6739         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6740         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6741         (i386_pseudo_register_read_into_value): Likewise.
6742         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6743         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6744         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6745         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6746         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6747         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6748         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6749         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6750         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6751
6752 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6753
6754         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6755         * configure.tgt: Remove target mt.
6756         * mt-tdep.c: Remove.
6757         * regcache.c (cooked_read_test): Remove the check for mt.
6758
6759 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6760
6761         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6762         instead of gdbarch_pseudo_register_read_value.
6763
6764 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6765
6766         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6767         language is Ada.
6768
6769 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6770
6771         * linespec.c (create_sals_line_offset): Remove code that preserved
6772         the symtab_and_line's line number.
6773
6774 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6775
6776         * varobj.c (varobj_create): Don't set valid_block when creating a
6777         floating varobj.
6778
6779 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6780
6781         * varobj.c (varobj_create): Remove out of date comment.
6782
6783 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6784
6785         PR mi/20395
6786         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6787         updating innermost block.
6788         * parse.c (innermost_block_tracker::update): Take extra type
6789         parameter, and check types match before updating innermost block.
6790         (write_dollar_variable): Update innermost block for registers.
6791         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6792         (innermost_block_tracker::innermost_block_tracker): Initialise
6793         m_types member.
6794         (innermost_block_tracker::reset): Take type parameter.
6795         (innermost_block_tracker::update): Take type parameter, and pass
6796         type through as needed.
6797         (innermost_block_tracker::m_types): New member.
6798         * varobj.c (varobj_create): Pass type when reseting innermost
6799         block.
6800
6801 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6802
6803         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6804         * ada-lang.c (resolve_subexp): Likewise.
6805         * breakpoint.c (set_breakpoint_condition) Likewise.
6806         (watch_command_1) Likewise.
6807         * c-exp.y (variable): Likewise.
6808         * d-exp.y (PrimaryExpression): Likewise.
6809         * f-exp.y (variable): Likewise.
6810         * go-exp.y (variable): Likewise.
6811         * m2-exp.y (variable): Likewise.
6812         * objfiles.c (objfile::~objfile): Likewise.
6813         * p-exp.y (variable): Likewise.
6814         * parse.c (innermost_block): Change type.
6815         * parser-defs.h (class innermost_block_tracker): New.
6816         (innermost_block): Change to innermost_block_tracker.
6817         * printcmd.c (display_command): Switch to innermost_block API.
6818         (do_one_display): Likewise.
6819         * rust-exp.y (do_one_display): Likewise.
6820         * symfile.c (clear_symtab_users): Likewise.
6821         * varobj.c (varobj_create): Switch to innermost_block API, replace
6822         use of innermost_block with block stored on varobj object.
6823
6824 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6825
6826         * expression.h (innermost_block): Remove declaration.
6827         * varobj.c: Add 'parser-defs.h' include.
6828
6829 2018-01-19  Tom Tromey  <tom@tromey.com>
6830
6831         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6832         symbols in the static and global blocks.
6833
6834 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6835
6836         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6837         gdb_ptrace.h, and move including gdb_wait.h ...
6838         * nat/linux-ptrace.h: ... to here.
6839
6840 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6841
6842         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6843         inf_ptrace_detach_success.
6844         (inf_ptrace_detach_success): Add inferior parameter, use it
6845         instead of inferior_ptid, pass it to detach_inferior.
6846         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6847         parameter.
6848         * inferior.c (detach_inferior): Add overload that takes an
6849         inferior object.
6850         * inferior.h (detach_inferior): Likewise.
6851         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6852         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6853         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6854
6855 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6856
6857         * target.h (struct target_ops) <to_detach>: Add inferior
6858         parameter.
6859         (target_detach): Likewise.
6860         * target.c (dispose_inferior): Pass inferior down.
6861         (target_detach): Pass inferior down.  Assert that it is equal to
6862         the current inferior.
6863         * aix-thread.c (aix_thread_detach): Pass inferior down.
6864         * corefile.c (core_file_command): Pass current_inferior() down.
6865         * corelow.c (core_detach): Add inferior parameter.
6866         * darwin-nat.c (darwin_detach): Likewise.
6867         * gnu-nat.c (gnu_detach): Likewise.
6868         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6869         * infcmd.c (detach_command): Pass current_inferior() down to
6870         target_detach.
6871         * infrun.c (follow_fork_inferior): Pass parent_inf to
6872         target_detach.
6873         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6874         target_detach.
6875         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6876         * linux-thread-db.c (thread_db_detach): Likewise.
6877         * nto-procfs.c (procfs_detach): Likewise.
6878         * procfs.c (procfs_detach): Likewise.
6879         * record.c (record_detach): Likewise.
6880         * record.h (struct inferior): Forward-declare.
6881         (record_detach): Add inferior parameter.
6882         * remote-sim.c (gdbsim_detach): Likewise.
6883         * remote.c (remote_detach_1): Likewise.
6884         (remote_detach): Likewise.
6885         (extended_remote_detach): Likewise.
6886         * sol-thread.c (sol_thread_detach): Likewise.
6887         * target-debug.h (target_debug_print_inferior_p): New macro.
6888         * target-delegates.c: Re-generate.
6889         * top.c (kill_or_detach): Pass inferior down to target_detach.
6890         * windows-nat.c (windows_detach): Add inferior parameter.
6891
6892 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6893
6894         * target.h (struct target_ops) <to_detach>: Remove args
6895         parameter.
6896         (target_detach): Likewise.
6897         * target.c (dispose_inferior): Adjust.
6898         (target_detach): Remove args parameter, adjust.
6899         * aix-thread.c (aix_thread_detach): Adjust.
6900         * corefile.c (core_file_command): Adjust.
6901         * corelow.c (core_detach): Adjust.
6902         * darwin-nat.c (darwin_detach): Adjust.
6903         * gnu-nat.c (gnu_detach): Adjust.
6904         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6905         * infcmd.c (detach_command): Adjust
6906         * infrun.c (follow_fork_inferior): Adjust.
6907         (handle_vfork_child_exec_or_exit): Adjust.
6908         * linux-fork.c (linux_fork_detach): Remove args parameter.
6909         * linux-fork.h (linux_fork_detach): Likewise.
6910         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6911         * linux-thread-db.c (thread_db_detach): Likewise.
6912         * nto-procfs.c (procfs_detach): Likewise.
6913         * procfs.c (procfs_detach): Likewise.
6914         (do_detach): Remove signo parameter.
6915         * record.c (record_detach): Remove args parameter.
6916         * record.h (record_detach): Likewise.
6917         * remote-sim.c (gdbsim_detach): Likewise.
6918         * remote.c (remote_detach_1): Likewise.
6919         (remote_detach): Likewise.
6920         (extended_remote_detach): Likewise.
6921         * sol-thread.c (sol_thread_detach): Likewise.
6922         * target-delegates.c: Re-generate.
6923         * top.c (struct qt_args) <args>: Remove field.
6924         (kill_or_detach): Don't pass args.
6925         (quit_force): Don't set args.
6926         * windows-nat.c (windows_detach): Remove args parameter.
6927
6928 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6929
6930         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6931         (arm_linux_init_abi): Install it.
6932
6933 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6934
6935         * osabi.c (gdb_osabi_names): Extend the regexp for
6936         arm-linux-gnueabihf.
6937
6938 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6939
6940         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6941         m_abbrevs.
6942         (abbrev_table::add_abbrev): Update.
6943         (abbrev_table::lookup_abbrev): Update.
6944
6945 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6946
6947         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6948
6949 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6950
6951         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6952         to "std::string".
6953
6954 2018-01-17  Tom Tromey  <tom@tromey.com>
6955
6956         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6957
6958 2018-01-17  Tom Tromey  <tom@tromey.com>
6959
6960         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6961         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6962         (create_array_type_with_stride): Update.
6963         * dwarf2read.c (set_die_type): Update.
6964
6965 2018-01-17  Tom Tromey  <tom@tromey.com>
6966
6967         * dwarf2read.c (delayed_method_info): Remove typedef.
6968         (dwarf2_cu::method_info): Now a std::vector.
6969         (add_to_method_list): Update.
6970         (free_delayed_list): Remove.
6971         (compute_delayed_physnames): Update.
6972         (process_full_comp_unit, process_full_type_unit): Clear the method
6973         list.  Remove cleanups.
6974         (psymtab_include_file_name): Add name_holder parameter.  Use
6975         unique_xmalloc_ptr.
6976         (dwarf_decode_lines): Update.
6977
6978 2018-01-17  Tom Tromey  <tom@tromey.com>
6979             Simon Marchi  <simon.marchi@ericsson.com>
6980
6981         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6982         (dwarf2_per_objfile::free_cached_comp_units)
6983         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6984         (init_cutu_and_read_dies_no_follow): Update.
6985         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6986         (dwarf2_cu::~dwarf2_cu): New.
6987         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6988         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6989
6990 2018-01-17  Tom Tromey  <tom@tromey.com>
6991             Simon Marchi  <simon.marchi@ericsson.com>
6992
6993         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6994         (struct die_reader_specs) <abbrev_table>: New member.
6995         (struct abbrev_table): Add constructor.
6996         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6997         <abbrev_obstack>: Now an auto_obstack.
6998         (abbrev_table_up): New typedef.
6999         (init_cu_die_reader): Add abbrev_table parameter.
7000         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
7001         Add result_dwo_abbrev_table.
7002         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
7003         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
7004         Update.
7005         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
7006         parameter.
7007         (skip_children): Update.
7008         (abbrev_table::alloc_abbrev): Rename from
7009         abbrev_table_alloc_abbrev.
7010         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
7011         (abbrev_table::lookup_abbrev): Rename from
7012         abbrev_table_lookup_abbrev.
7013         (abbrev_table_read_table): Return abbrev_table_up.
7014         (abbrev_table_free, abbrev_table_free_cleanup)
7015         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
7016         (load_partial_dies): Update.
7017
7018 2018-01-17  Tom Tromey  <tom@tromey.com>
7019
7020         * dwarf2read.c (dwarf2_compute_name): Update comment.
7021         (read_func_scope, read_variable): Update.
7022         (new_symbol): Remove.
7023         (new_symbol_full): Rename to new_symbol.
7024
7025 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
7026
7027         PR gdb/16577
7028         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
7029         a warning instead of throwing an error, set section size to 0 and return
7030         NULL.
7031         * gdb_bfd.h (gdb_bfd_map_section): Update description.
7032
7033 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
7034
7035         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
7036         std::string.
7037         (linux_ptrace_attach_fail_reason_string): Likewise.
7038         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
7039         Likewise.
7040         (linux_ptrace_attach_fail_reason_string): Likewise.
7041         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
7042
7043 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
7044
7045         * linux-nat.c (linux_nat_attach): Remove xstrdup.
7046
7047 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
7048
7049         PR gdb/21559
7050         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
7051         checking for fs_base/gs_base fields in struct user_regs_struct.
7052         * configure: Regenerate.
7053
7054 2018-01-17  Yao Qi  <yao.qi@linaro.org>
7055
7056         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
7057         function.
7058         (aarch64_linux_init_abi): Install it to gdbarch hook
7059         gcc_target_options.
7060
7061 2018-01-15  Pedro Alves  <palves@redhat.com>
7062
7063         * common/signals-state-save-restore.c
7064         (save_original_signals_state): Fix typos.
7065
7066 2017-01-12  Tom Tromey  <tom@tromey.com>
7067             Sergio Durigan Junior  <sergiodj@redhat.com>
7068
7069         * Makefile.in (install-only): Install gdb-add-index.
7070
7071 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
7072
7073         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
7074
7075 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
7076
7077         * infrun.c (keep_going_pass_signal): Clear step-over info when
7078         insert_breakpoints fails.
7079
7080 2018-01-11  Pedro Alves  <palves@redhat.com>
7081
7082         PR gdb/22583
7083         * infrun.c (resume): Rename to ...
7084         (resume_1): ... this.
7085         (resume): Reimplement as wrapper around resume_1.
7086
7087 2018-01-11  Pedro Alves  <palves@redhat.com>
7088
7089         PR remote/22597
7090         * remote.c (remote_parse_stop_reply): Default to the last-set
7091         general thread instead of to 'magic_null_ptid'.
7092
7093 2018-01-10  Pedro Alves  <palves@redhat.com>
7094
7095         * language.h (language_get_symbol_name_matcher): Rename ...
7096         (get_symbol_name_matcher): ... this.
7097         * language.c (language_get_symbol_name_matcher): Ditto.
7098         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
7099         callers adjusted.
7100
7101 2018-01-10  Pedro Alves  <palves@redhat.com>
7102
7103         PR gdb/22670
7104         * dwarf2read.c
7105         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
7106         Adjust to use language_get_symbol_name_matcher instead of
7107         language_defn::la_get_symbol_name_matcher.
7108         * language.c (language_get_symbol_name_matcher): If in Ada mode
7109         and the lookup name is a verbatim match, return Ada's matcher.
7110         * language.h (language_get_symbol_name_matcher): Adjust comment.
7111         (ada_lookup_name_info::verbatim_p):: New method.
7112
7113 2018-01-10  Pedro Alves  <palves@redhat.com>
7114
7115         PR gdb/22670
7116         * ada-lang.c (ada_collect_symbol_completion_matches): If the
7117         minsym's language is language_auto or language_cplus, pass down
7118         language_ada instead.
7119         * symtab.c (compare_symbol_name): Don't frob symbol language here.
7120
7121 2018-01-10  Pedro Alves  <palves@redhat.com>
7122
7123         PR gdb/22670
7124         * minsyms.c (linkage_name_str): New function.
7125         (iterate_over_minimal_symbols): Use it.
7126
7127 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7128
7129         * NEWS: Document that 'info proc' now works on FreeBSD.
7130
7131 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7132
7133         * configure.ac: Check for kinfo_getfile in libutil.
7134         * configure: Regenerate.
7135         * config.in: Regenerate.
7136         * fbsd-nat.c: Include "fbsd-tdep.h".
7137         (fbsd_fetch_cmdline): New.
7138         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
7139         rather than calling error.
7140         (fbsd_info_proc): New.
7141         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
7142         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
7143         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
7144
7145 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7146
7147         * fbsd-nat.c (struct free_deleter): Remove.
7148         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
7149
7150 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7151
7152         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
7153         NULL for an empty pathname.
7154
7155 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7156
7157         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
7158         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
7159         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
7160         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
7161         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
7162         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
7163         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
7164         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
7165         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
7166         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
7167         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
7168         (fbsd_core_fetch_timeval, fbsd_print_sigset)
7169         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
7170         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
7171         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
7172
7173 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
7174
7175         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
7176         (gnu_xfer_auxv): New function.
7177         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
7178         TARGET_OBJECT_AUXV.
7179
7180 2018-01-08  Yao Qi  <yao.qi@linaro.org>
7181             Simon Marchi  <simon.marchi@ericsson.com>
7182
7183         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
7184         common/selftest.c.
7185         (COMMON_OBS): Remove selftest.o.
7186         * configure.ac: Append selftest-arch.c and common/selftest.c to
7187         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
7188         * configure: Re-generated.
7189         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
7190         GDB_SELF_TEST.
7191         (maintenance_info_selftests): Likewise.
7192
7193 2018-01-08  Xavier Roirand  <roirand@adacore.com>
7194
7195         * ada-valprint.c (val_print_packed_array_elements): Use
7196         proper number of elements when printing an array indexed
7197         by an enumeration type.
7198
7199 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7200
7201         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
7202         (dw2_get_file_names_reader): Adjust.
7203         (lookup_dwo_signatured_type): Adjust.
7204         (lookup_dwp_signatured_type): Adjust.
7205         (lookup_signatured_type): Adjust.
7206         (create_type_unit_group): Adjust.
7207         (get_type_unit_group): Adjust.
7208         (process_psymtab_comp_unit_reader): Adjust.
7209         (build_type_psymtabs_reader): Adjust.
7210         (scan_partial_symbols): Adjust.
7211         (add_partial_symbol): Adjust.
7212         (add_partial_subprogram): Adjust.
7213         (peek_die_abbrev): Adjust.
7214         (fixup_go_packaging): Adjust.
7215         (process_imported_unit_die): Adjust.
7216         (dwarf2_compute_name): Adjust.
7217         (dwarf2_physname): Adjust.
7218         (read_import_statement): Adjust.
7219         (handle_DW_AT_stmt_list): Adjust.
7220         (read_file_scope): Adjust.
7221         (read_func_scope): Adjust.
7222         (read_lexical_block_scope): Adjust.
7223         (read_call_site_scope): Adjust.
7224         (read_variable): Adjust.
7225         (dwarf2_rnglists_process): Adjust.
7226         (dwarf2_ranges_process): Adjust.
7227         (dwarf2_ranges_read): Adjust.
7228         (dwarf2_get_pc_bounds): Adjust.
7229         (dwarf2_record_block_ranges): Adjust.
7230         (dwarf2_add_field): Adjust.
7231         (dwarf2_add_member_fn): Adjust.
7232         (read_structure_type): Adjust.
7233         (process_structure_scope): Adjust.
7234         (read_enumeration_type): Adjust.
7235         (read_array_type): Adjust.
7236         (mark_common_block_symbol_computed): Adjust.
7237         (read_common_block): Adjust.
7238         (read_namespace_type): Adjust.
7239         (read_namespace): Adjust.
7240         (read_module_type): Adjust.
7241         (read_tag_pointer_type): Adjust.
7242         (read_tag_ptr_to_member_type): Adjust.
7243         (read_tag_string_type): Adjust.
7244         (read_subroutine_type): Adjust.
7245         (read_typedef): Adjust.
7246         (read_base_type): Adjust.
7247         (attr_to_dynamic_prop): Adjust.
7248         (read_subrange_type): Adjust.
7249         (read_unspecified_type): Adjust.
7250         (dwarf2_read_abbrevs): Adjust.
7251         (load_partial_dies): Adjust.
7252         (read_partial_die): Adjust.
7253         (find_partial_die): Adjust.
7254         (guess_partial_die_structure_name): Adjust.
7255         (fixup_partial_die): Adjust.
7256         (read_attribute_value): Adjust.
7257         (read_addr_index): Adjust.
7258         (read_addr_index_from_leb128): Adjust.
7259         (read_str_index): Adjust.
7260         (dwarf2_string_attr): Adjust.
7261         (get_debug_line_section): Adjust.
7262         (dwarf_decode_line_header): Adjust.
7263         (lnp_state_machine::check_line_address): Adjust.
7264         (dwarf_decode_lines_1): Adjust.
7265         (dwarf_decode_lines): Adjust.
7266         (dwarf2_start_symtab): Adjust.
7267         (var_decode_location): Adjust.
7268         (new_symbol_full): Adjust.
7269         (dwarf2_const_value_data): Adjust.
7270         (dwarf2_const_value_attr): Adjust.
7271         (dwarf2_const_value): Adjust.
7272         (die_type): Adjust.
7273         (die_containing_type): Adjust.
7274         (build_error_marker_type): Adjust.
7275         (lookup_die_type): Adjust.
7276         (guess_full_die_structure_name): Adjust.
7277         (anonymous_struct_prefix): Adjust.
7278         (determine_prefix): Adjust.
7279         (dwarf2_name): Adjust.
7280         (follow_die_ref_or_sig): Adjust.
7281         (follow_die_offset): Adjust.
7282         (follow_die_ref): Adjust.
7283         (follow_die_sig_1): Adjust.
7284         (follow_die_sig): Adjust.
7285         (get_signatured_type): Adjust.
7286         (get_DW_AT_signature_type): Adjust.
7287         (decode_locdesc): Adjust.
7288         (dwarf_decode_macros): Adjust.
7289         (cu_debug_loc_section): Adjust.
7290         (fill_in_loclist_baton): Adjust.
7291         (dwarf2_symbol_mark_computed): Adjust.
7292         (init_one_comp_unit): Don't assign
7293         dwarf2_cu::dwarf2_per_objfile.
7294         (set_die_type): Adjust.
7295
7296 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7297
7298         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7299         <dwarf2_per_objfile>: New field.
7300         (dwarf2_per_objfile): Remove global.
7301         (get_dwarf2_per_objfile): New function.
7302         (set_dwarf2_per_objfile): New function.
7303         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7304         dwarf2_per_objfile.
7305         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7306         (read_abbrev_offset): Likewise.
7307         (read_indirect_string): Likewise.
7308         (read_indirect_line_string): Likewise.
7309         (read_indirect_string_at_offset): Likewise.
7310         (read_indirect_string_from_dwz): Likewise.
7311         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7312         dwarf2_per_objfile.
7313         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7314         (create_all_comp_units): Change objfile parameter to
7315         dwarf2_per_objfile.
7316         (create_all_type_units): Likewise.
7317         (process_queue): Add dwarf2_per_objfile parameter.
7318         (read_and_check_comp_unit_head): Likewise.
7319         (lookup_dwo_unit_in_dwp): Likewise.
7320         (get_dwp_file): Likewise.
7321         (process_cu_includes): Likewise.
7322         (struct free_dwo_file_cleanup_data): New struct.
7323         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7324         set_dwarf2_per_objfile.
7325         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7326         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7327         context, adjust calls.
7328         (dw2_instantiate_symtab): Likewise.
7329         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7330         (dw2_get_cu): Likewise.
7331         (create_cu_from_index_list): Change objfile parameter to
7332         dwarf2_per_objfile.
7333         (create_cus_from_index_list): Get dwarf2_per_objfile from
7334         context, adjust calls.
7335         (create_cus_from_index): Likewise.
7336         (create_signatured_type_table_from_index): Change objfile
7337         parameter to dwarf2_per_objfile.
7338         (create_signatured_type_table_from_debug_names): Change objfile
7339         parameter to dwarf2_per_objfile.
7340         (create_addrmap_from_index): Likewise.
7341         (create_addrmap_from_aranges): Likewise.
7342         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7343         (dw2_setup): Remove.
7344         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7345         context.
7346         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7347         get_dwarf2_per_objfile.
7348         (dw2_forget_cached_source_info): Likewise.
7349         (dw2_map_symtabs_matching_filename): Likewise.
7350         (struct dw2_symtab_iterator) <index>: Remove.
7351         <dwarf2_per_objfile>: New field.
7352         (dw2_symtab_iter_init): Replace index parameter with
7353         dwarf2_per_objfile.
7354         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7355         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7356         (dw2_print_stats): Likewise.
7357         (dw2_dump): Likewise.
7358         (dw2_expand_symtabs_for_function): Likewise.
7359         (dw2_expand_all_symtabs): Likewise.
7360         (dw2_expand_symtabs_with_fullname): Likewise.
7361         (dw2_expand_marked_cus): Replace index and objfile parameters
7362         with dwarf2_per_objfile.
7363         (dw_expand_symtabs_matching_file_matcher): Add
7364         dwarf2_per_objfile parameter and adjust calls.
7365         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7366         adjust calls.
7367         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7368         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7369         adjust calls.
7370         (create_cus_from_debug_names_list): Replace objfile parameter
7371         with dwarf2_per_objfile and adjust calls.
7372         (create_cus_from_debug_names): Likewise.
7373         (dwarf2_read_debug_names): Likewise.
7374         (mapped_debug_names::namei_to_name): Adjust call.
7375         (dw2_debug_names_iterator::next): Likewise.
7376         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7377         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7378         (dw2_debug_names_dump): Likewise.
7379         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7380         (dw2_debug_names_expand_symtabs_matching): Likewise.
7381         (dwarf2_initialize_objfile): Likewise.
7382         (dwarf2_build_psymtabs): Likewise.
7383         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7384         this_cu.
7385         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7386         (read_and_check_comp_unit_head): Likewise.
7387         (read_abbrev_offset): Likewise.
7388         (create_debug_type_hash_table): Likewise.
7389         (create_debug_types_hash_table): Likewise.
7390         (create_all_type_units): Replace objfile parameter with
7391         dwarf2_per_objfile.
7392         (add_type_unit): Add dwarf2_per_objfile parameter.
7393         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7394         with dwarf2_per_objfile.
7395         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7396         (lookup_dwp_signatured_type): Likewise.
7397         (lookup_signatured_type): Likewise.
7398         (read_cutu_die_from_dwo): Likewise.
7399         (init_tu_and_read_dwo_dies): Likewise.
7400         (init_cutu_and_read_dies): Likewise.
7401         (init_cutu_and_read_dies_no_follow): Likewise.
7402         (allocate_type_unit_groups_table): Add objfile parameter.
7403         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7404         (get_type_unit_group): Likewise.
7405         (process_psymtab_comp_unit): Update call.
7406         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7407         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7408         (print_tu_stats): Likewise.
7409         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7410         in void* parameter.
7411         (build_type_psymtabs): Change objfile parameter to
7412         dwarf2_per_objfile.
7413         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7414         passed in void* parameter.
7415         (process_skeletonless_type_units): Change objfile parameter to
7416         dwarf2_per_objfile.
7417         (set_partial_user): Likewise.
7418         (dwarf2_build_psymtabs_hard): Likewise.
7419         (read_comp_units_from_section): Likewise.
7420         (create_all_comp_units): Likewise.
7421         (scan_partial_symbols): Update calls.
7422         (add_partial_symbol): Likewise.
7423         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7424         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7425         (process_queue): Add dwarf2_per_objfile parameter.
7426         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7427         (compute_compunit_symtab_includes): Likewise.
7428         (process_cu_includes): Add dwarf2_per_objfile parameter.
7429         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7430         (process_full_type_unit): Likewise.
7431         (process_imported_unit_die): Update call.
7432         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7433         (read_file_scope): Likewise.
7434         (allocate_dwo_file_hash_table): Add objfile parameter.
7435         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7436         (create_cus_hash_table): Likewise.
7437         (create_dwp_hash_table): Likewise.
7438         (create_dwo_unit_in_dwp_v1): Likewise.
7439         (create_dwp_v2_section): Likewise.
7440         (create_dwo_unit_in_dwp_v2): Likewise.
7441         (lookup_dwo_unit_in_dwp): Likewise.
7442         (try_open_dwop_file): Likewise.
7443         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
7444         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
7445         cleanup to include a reference to dwarf2_per_objfile.
7446         (open_dwp_file): Add dwarf2_per_objfile parameter.
7447         (open_and_init_dwp_file): Likewise.
7448         (get_dwp_file): Likewise.
7449         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
7450         (queue_and_load_all_dwo_tus): Update call.
7451         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
7452         data.
7453         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
7454         (dwarf2_ranges_process): Likewise.
7455         (dwarf2_get_pc_bounds): Likewise.
7456         (mark_common_block_symbol_computed): Likewise.
7457         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7458         (dwarf2_read_abbrevs): Update call.
7459         (read_partial_die): Use dwarf2_per_objfile from cu.
7460         (find_partial_die): Likewise.
7461         (fixup_partial_die): Likewise.
7462         (read_attribute_value): Likewise.
7463         (read_indirect_string_at_offset_from): Add objfile parameter.
7464         (read_indirect_string_at_offset): Add dwarf2_per_objfile
7465         parameter.
7466         (read_indirect_string_from_dwz): Add objfile parameter.
7467         (read_indirect_string): Add objfile parameter.
7468         (read_addr_index_1): Add dwarf2_per_objfile parameter.
7469         (read_addr_index): Use dwarf2_per_objfile from cu.
7470         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
7471         call dw2_setup.
7472         (read_str_index): Use dwarf2_per_objfile from cu.
7473         (get_debug_line_section): Likewise.
7474         (read_formatted_entries): Add dwarf2_per_objfile parameter.
7475         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
7476         (new_symbol_full): Use dwarf2_per_objfile from cu.
7477         (build_error_marker_type): Likewise.
7478         (lookup_die_type): Likewise.
7479         (determine_prefix): Likewise.
7480         (follow_die_offset): Likewise.
7481         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
7482         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
7483         (dwarf2_fetch_die_type_sect_off): Likewise.
7484         (dwarf2_get_die_type): Likewise.
7485         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7486         (get_signatured_type): Likewise.
7487         (get_DW_AT_signature_type): Likewise.
7488         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7489         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7490         (cu_debug_loc_section): Likewise.
7491         (fill_in_loclist_baton): Likewise.
7492         (dwarf2_symbol_mark_computed): Likewise.
7493         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7494         dwarf2_per_objfile.
7495         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7496         parameter.
7497         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7498         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7499         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7500         (set_die_type): Use dwarf2_free_objfile from cu.
7501         (get_die_type_at_offset): Likewise.
7502         (dwarf2_per_objfile_free): Don't assign global variable.
7503         (debug_names) <constructor>: Add dwarf2_per_objfile
7504         parameter, update m_debugstrlookup construction.
7505         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7506         parameter.
7507         <m_dwarf2_per_objfile>: New field.
7508         <lookup>: Use m_dwarf2_per_objfile.
7509         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7510         (psyms_seen_size): Likewise.
7511         (write_gdbindex): Replace objfile parameter with
7512         dwarf2_per_objfile.
7513         (write_debug_names): Likewise.
7514         (write_psymtabs_to_index): Likewise.
7515         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7516         calls.
7517
7518 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7519
7520         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7521         <dwarf2_per_objfile>: New field.
7522         (struct dwarf2_per_cu_data) <objfile>: Remove.
7523         <dwarf2_per_objfile>: New field.
7524         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7525         of objfile.
7526         (create_signatured_type_table_from_index): Likewise.
7527         (create_debug_type_hash_table): Likewise.
7528         (fill_in_sig_entry_from_dwo_entry): Likewise.
7529         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7530         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7531         objfile.
7532         (create_partial_symtab): Access objfile through
7533         dwarf2_per_objfile.
7534         (process_psymtab_comp_unit_reader): Likewise.
7535         (read_comp_units_from_section): Likewise.
7536         (scan_partial_symbols): Likewise.
7537         (add_partial_symbol): Likewise.
7538         (add_partial_subprogram): Likewise.
7539         (peek_die_abbrev): Likewise.
7540         (fixup_go_packaging): Likewise.
7541         (process_full_comp_unit): Likewise.
7542         (process_full_type_unit): Likewise.
7543         (process_imported_unit_die): Likewise.
7544         (dwarf2_compute_name): Likewise.
7545         (dwarf2_physname): Likewise.
7546         (read_import_statement): Likewise.
7547         (create_cus_hash_table): Assign dwarf2_physname instead of
7548         objfile.
7549         (read_func_scope): Access objfile through dwarf2_per_objfile.
7550         (read_lexical_block_scope): Likewise.
7551         (read_call_site_scope): Likewise.
7552         (read_variable): Likewise.
7553         (dwarf2_rnglists_process): Likewise.
7554         (dwarf2_ranges_process): Likewise.
7555         (dwarf2_ranges_read): Likewise.
7556         (dwarf2_record_block_ranges): Likewise.
7557         (dwarf2_add_field): Likewise.
7558         (dwarf2_add_member_fn): Likewise.
7559         (read_structure_type): Likewise.
7560         (process_structure_scope): Likewise.
7561         (read_enumeration_type): Likewise.
7562         (read_array_type): Likewise.
7563         (read_common_block): Likewise.
7564         (read_namespace_type): Likewise.
7565         (read_namespace): Likewise.
7566         (read_module_type): Likewise.
7567         (read_tag_pointer_type): Likewise.
7568         (read_tag_ptr_to_member_type): Likewise.
7569         (read_tag_string_type): Likewise.
7570         (read_subroutine_type): Likewise.
7571         (read_typedef): Likewise.
7572         (read_base_type): Likewise.
7573         (attr_to_dynamic_prop): Likewise.
7574         (read_subrange_type): Likewise.
7575         (read_unspecified_type): Likewise.
7576         (load_partial_dies): Likewise.
7577         (read_partial_die): Likewise.
7578         (find_partial_die): Likewise.
7579         (guess_partial_die_structure_name): Likewise.
7580         (fixup_partial_die): Likewise.
7581         (read_attribute_value): Likewise.
7582         (read_addr_index_from_leb128): Likewise.
7583         (dwarf2_read_addr_index): Likewise.
7584         (dwarf2_string_attr): Likewise.
7585         (lnp_state_machine::check_line_address): Likewise.
7586         (dwarf_decode_lines_1): Likewise.
7587         (dwarf_decode_lines): Likewise.
7588         (dwarf2_start_symtab): Likewise.
7589         (var_decode_location): Likewise.
7590         (new_symbol_full): Likewise.
7591         (dwarf2_const_value_data): Likewise.
7592         (dwarf2_const_value_attr): Likewise.
7593         (dwarf2_const_value): Likewise.
7594         (die_type): Likewise.
7595         (die_containing_type): Likewise.
7596         (lookup_die_type): Likewise.
7597         (guess_full_die_structure_name): Likewise.
7598         (anonymous_struct_prefix): Likewise.
7599         (dwarf2_name): Likewise.
7600         (follow_die_ref_or_sig): Likewise.
7601         (follow_die_offset): Likewise.
7602         (follow_die_ref): Likewise.
7603         (dwarf2_fetch_die_loc_sect_off): Likewise.
7604         (dwarf2_fetch_constant_bytes): Likewise.
7605         (dwarf2_fetch_die_type_sect_off): Likewise.
7606         (dwarf2_get_die_type): Likewise.
7607         (follow_die_sig): Likewise.
7608         (decode_locdesc): Likewise.
7609         (dwarf2_per_cu_objfile): Likewise.
7610         (dwarf2_per_cu_text_offset): Likewise.
7611         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7612         objfile.
7613         (set_die_type): Access objfile through
7614         dwarf2_per_objfile.
7615
7616 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7617
7618         * valprint.c (converted_character_d): Remove typedef.
7619         (DEF_VEC_O (converted_character_d)): Remove.
7620         (count_next_character): Use std::vector.
7621         (print_converted_chars_to_obstack): Likewise.
7622         (generic_printstr): Likewise.
7623
7624 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7625
7626         * xml-support.h (struct gdb_xml_value): Add constructor.
7627         <value>: Change type to unique_xmalloc_ptr.
7628         (gdb_xml_value_s): Remove typedef.
7629         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7630         (gdb_xml_element_start_handler): Change parameter type to
7631         std::vector.
7632         (xml_find_attribute): Likewise.
7633         * xml-support.c (xml_find_attribute): Change parameter type to
7634         std::vector and adjust.
7635         (gdb_xml_values_cleanup): Remove.
7636         (gdb_xml_parser::start_element): Adjust to std::vector.
7637         (xinclude_start_include): Change paraeter type to std::vector
7638         and adjust.
7639         * btrace.c (check_xml_btrace_version): Likewise.
7640         (parse_xml_btrace_block): Likewise.
7641         (parse_xml_btrace_pt_config_cpu): Likewise.
7642         (parse_xml_btrace_pt): Likewise.
7643         (parse_xml_btrace_conf_bts): Likewise.
7644         (parse_xml_btrace_conf_pt): Likewise.
7645         * memory-map.c (memory_map_start_memory): Likewise.
7646         (memory_map_start_property): Likewise.
7647         * osdata.c (osdata_start_osdata): Likewise.
7648         (osdata_start_item): Likewise.
7649         (osdata_start_column): Likewise.
7650         * remote.c (start_thread): Likewise.
7651         * solib-aix.c (library_list_start_library): Likewise.
7652         (library_list_start_list): Likewise.
7653         * solib-svr4.c (library_list_start_library): Likewise.
7654         (svr4_library_list_start_list): Likewise.
7655         * solib-target.c (library_list_start_segment): Likewise.
7656         (library_list_start_section): Likewise.
7657         (library_list_start_library): Likewise.
7658         (library_list_start_list): Likewise.
7659         * tracepoint.c (traceframe_info_start_memory): Likewise.
7660         (traceframe_info_start_tvar): Likewise.
7661         * xml-syscall.c (syscall_start_syscall): Likewise.
7662         * xml-tdesc.c (tdesc_start_target): Likewise.
7663         (tdesc_start_feature): Likewise.
7664         (tdesc_start_reg): Likewise.
7665         (tdesc_start_union): Likewise.
7666         (tdesc_start_struct): Likewise.
7667         (tdesc_start_flags): Likewise.
7668         (tdesc_start_enum): Likewise.
7669         (tdesc_start_field): Likewise.
7670         (tdesc_start_enum_value): Likewise.
7671         (tdesc_start_vector): Likewise.
7672
7673 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7674
7675         * extension.h (struct xmethod_worker) <clone>: Remove.
7676         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7677         Remove.
7678         (python_xmethod_worker::clone): Remove.
7679         * valops.c (find_overload_match): Use std::move instead of
7680         clone.
7681
7682 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7683
7684         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7685         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7686         <free_xmethod_worker_data>: Remove.
7687         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7688         <get_xmethod_arg_types>: Remove.
7689         <get_xmethod_result_type>: Remove.
7690         <invoke_xmethod>: Remove.
7691         * extension.c (new_xmethod_worker): Remove.
7692         (clone_xmethod_worker): Remove.
7693         (get_matching_xmethod_workers): Return void, pass std::vector by
7694         pointer.
7695         (get_xmethod_arg_types): Rename to...
7696         (xmethod_worker::get_arg_types): ... this, and adjust.
7697         (get_xmethod_result_type): Rename to...
7698         (xmethod_worker::get_result_type): ... this, and adjust.
7699         (invoke_xmethod): Remove.
7700         (free_xmethod_worker): Remove.
7701         (free_xmethod_worker_vec): Remove.
7702         * extension.h (enum ext_lang_rc): Move here from
7703         extension-priv.h.
7704         (struct xmethod_worker): Add constructor and destructor.
7705         <data>: Remove.
7706         <value>: Remove.
7707         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7708         virtual pure methods.
7709         <get_arg_types, get_result_type>: New methods.
7710         (xmethod_worker_ptr): Remove typedef.
7711         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7712         (xmethod_worker_vec): Remove typedef.
7713         (xmethod_worker_up): New typedef.
7714         (invoke_xmethod): Remove.
7715         (clone_xmethod_worker): Remove.
7716         (free_xmethod_worker): Remove.
7717         (free_xmethod_worker_vec): Remove.
7718         (get_xmethod_arg_types): Remove.
7719         (get_xmethod_result_type): Remove.
7720         * valops.c (find_method_list): Use std::vector, don't use
7721         intermediate vector.
7722         (value_find_oload_method_list): Use std::vector.
7723         (find_overload_match): Use std::vector.
7724         (find_oload_champ): Use std::vector.
7725         * value.c (value_free): Use operator delete.
7726         (value_of_xmethod): Rename to...
7727         (value_from_xmethod): ... this.  Don't assign
7728         xmethod_worker::value, take rvalue-reference.
7729         (result_type_of_xmethod): Adjust.
7730         (call_xmethod): Adjust.
7731         * value.h: Include extension.h.
7732         (struct xmethod_worker): Don't forward-declare.
7733         (value_of_xmethod): Rename to...
7734         (value_from_xmethod): ... this, take rvalue-reference.
7735         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7736         (struct python_xmethod_worker): ... this, add constructor and
7737         destructor.
7738         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7739         (gdbpy_free_xmethod_worker_data): Rename to...
7740         (python_xmethod_worker::~python_xmethod_worker): ... this and
7741         adjust.
7742         (gdbpy_clone_xmethod_worker_data): Rename to...
7743         (python_xmethod_worker::clone): ... this and adjust.
7744         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7745         temporary vector.
7746         (gdbpy_get_xmethod_arg_types): Rename to...
7747         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7748         (gdbpy_get_xmethod_result_type): Rename to...
7749         (python_xmethod_worker::do_get_result_type): ... this and
7750         adjust.
7751         (gdbpy_invoke_xmethod): Rename to...
7752         (python_xmethod_worker::invoke): ... this and adjust.
7753         (new_python_xmethod_worker): Rename to...
7754         (python_xmethod_worker::python_xmethod_worker): ... this and
7755         adjust.
7756         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7757         Remove.
7758         (gdbpy_free_xmethod_worker_data): Remove.
7759         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7760         (gdbpy_get_xmethod_arg_types): Remove.
7761         (gdbpy_get_xmethod_result_type): Remove.
7762         (gdbpy_invoke_xmethod): Remove.
7763         * python/python.c (python_extension_ops): Remove obsolete
7764         callbacks.
7765
7766 2018-01-05  Pedro Alves  <palves@redhat.com>
7767
7768         PR gdb/18653
7769         * common/signals-state-save-restore.c
7770         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7771         find a custom handler preinstalled, instead of internal erroring.
7772         But only warn if !quiet.
7773         * common/signals-state-save-restore.h
7774         (save_original_signals_state): New parameter 'quiet'.
7775         * main.c (captured_main_1): Move save_original_signals_state call
7776         after option handling, and pass QUIET.
7777
7778 2018-01-05  Pedro Alves  <palves@redhat.com>
7779
7780         * spu-tdep.c (spu_catch_start): Pass
7781         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7782
7783 2018-01-05  Pedro Alves  <palves@redhat.com>
7784
7785         PR gdb/22670
7786         * ada-lang.c (literal_symbol_name_matcher): New function.
7787         (ada_get_symbol_name_matcher): Use it for
7788         symbol_name_match_type::SEARCH_NAME.
7789         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7790         it down instead of assuming symbol_name_match_type::FULL.
7791         * block.h (block_lookup_symbol): New parameter 'match_type'.
7792         * c-valprint.c (print_unpacked_pointer): Use
7793         lookup_symbol_search_name instead of lookup_symbol.
7794         * compile/compile-object-load.c (get_out_value_type): Pass down
7795         symbol_name_match_type::SEARCH_NAME.
7796         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7797         symbol_name_match_type::FULL.
7798         * cp-support.c (cp_get_symbol_name_matcher): Handle
7799         symbol_name_match_type::SEARCH_NAME.
7800         * infrun.c (insert_exception_resume_breakpoint): Use
7801         lookup_symbol_search_name.
7802         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7803         * psymtab.c (maintenance_check_psymtabs): Use
7804         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7805         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7806         SYMBOL_SEARCH_NAME.
7807         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7808         if symbol_name_match_type::SEARCH_NAME.
7809         (lookup_symbol_in_language): Pass down
7810         symbol_name_match_type::FULL.
7811         (lookup_symbol_search_name): New.
7812         (lookup_language_this): Pass down
7813         symbol_name_match_type::SEARCH_NAME.
7814         (lookup_symbol_aux, lookup_local_symbol): New parameter
7815         'match_type'.  Pass it down.
7816         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7817         (lookup_symbol_search_name): New declaration.
7818         (lookup_symbol_in_block): New 'match_type' parameter.
7819
7820 2018-01-05  Pedro Alves  <palves@redhat.com>
7821
7822         PR gdb/22670
7823         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7824         ada_lookup_symbol.
7825         (ada_lookup_symbol): Reimplement in terms of
7826         ada_lookup_symbol_list, bits factored out from
7827         ada_lookup_encoded_symbol.
7828
7829 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7830
7831         * ada-exp.y (write_object_renaming): When subscripting an array
7832         using a symbol as the index, pass the block in call to
7833         ada_lookup_encoded_symbol when looking that symbol up.
7834
7835 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7836
7837         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7838         TYPE_INDEX_TYPE.
7839
7840 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7841
7842         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7843         the case where VALUE_LVAL (val0) is not lval_memory.
7844
7845 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7846
7847         * ada-valprint.c (print_optional_low_bound): Handle
7848         character-indexed array printing like boolean-indexed array
7849         printing.
7850
7851 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7852
7853         * NEWS: Create a new section for the next release branch.
7854         Rename the section of the current branch, now that it has
7855         been cut.
7856
7857 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7858
7859         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7860         * version.in: Bump version to 8.1.50.DATE-git.
7861
7862 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7863
7864         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7865         Add field.
7866         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7867         Add field.
7868         (default_exception_support_info) <catch_handlers_sym>: Add field.
7869         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7870         (ada_exception_name_addr_1): Add "catch handlers" handling.
7871         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7872         Update all callers.
7873         (create_excep_cond_exprs) <ex>: Add parameter.
7874         (re_set_exception): Update create_excep_cond_exprs call.
7875         (print_it_exception, print_one_exception, print_mention_exception)
7876         (print_recreate_exception): Add "catch handler" handling.
7877         (allocate_location_catch_handlers, re_set_catch_handlers)
7878         (check_status_catch_handlers, print_it_catch_handlers)
7879         (print_one_catch_handlers, print_mention_catch_handlers)
7880         (print_recreate_catch_handlers): New function.
7881         (catch_handlers_breakpoint_ops): New variable.
7882         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7883         Add parameter.  Add "catch handler" handling.
7884         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7885         Add "catch handler" handling.
7886         (ada_exception_catchpoint_cond_string): Add "catch handler"
7887         handling.
7888         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7889         call.
7890         (catch_ada_handlers_command): New function.
7891         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7892         operations structure.
7893         (_initialize_ada_language): Add "catch handlers" command entry.
7894         * NEWS: Document "catch handlers" feature.
7895
7896 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7897
7898         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7899         account when creating the array type of the slice.
7900         (ada_value_slice): Likewise.
7901
7902 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7903
7904         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7905         New enum value.
7906         (create_array_type_with_stride): Add byte_stride_prop parameter.
7907         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7908         New parameter.  Update all callers in this file.
7909         (array_type_has_dynamic_stride): New function.
7910         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7911         of arrays with dynamic byte strides.
7912         * dwarf2read.c (read_array_type): Add support for dynamic
7913         DW_AT_byte_stride attributes.
7914
7915 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7916
7917         * dwarf2read.c (read_unspecified_type): Treat
7918         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7919
7920 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7921
7922         Update copyright year range in all GDB files.
7923
7924 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7925
7926         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7927         and gdb/testsuite/gdb.base/step-line.c.
7928
7929 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7930
7931         * copyright.py (main): Dump the contents of
7932         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7933         even if BY_HAND is empty.
7934
7935 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7936
7937         * top.c (print_gdb_version): Update Copyright year in version
7938         message.
7939
7940 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7941
7942         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7943
7944 For older changes see ChangeLog-2017.
7945 \f
7946 Local Variables:
7947 mode: change-log
7948 left-margin: 8
7949 fill-column: 74
7950 version-control: never
7951 coding: utf-8
7952 End: