gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
   4         * stap-probe.c (stap_parse_argument): Update.
   5         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
   6         initial_size parameter.
   7         * rust-exp.y (rust_lex_tests): Update.
   8         * parse.c (parser_state): Update.
   9         (parse_exp_in_context): Update.
  10         * parser-defs.h (struct parser_state) <parser_state>: Remove
  11         "initial_size" parameter.
  12
  13 2019-04-04  Tom Tromey  <tom@tromey.com>
  14
  15         * parser-defs.h (increase_expout_size): Don't declare.
  16         * parse.c (increase_expout_size): Now static.
  17
  18 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
  19
  20         * gnu-nat.c (gnu_nat_target::wait): Fix
  21         target_waitstatus_to_string call.
  22
  23 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  24
  25         * eval.c (evaluate_subexp_standard): Handle internal functions
  26         during Fortran function call handling.
  27
  28 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  29
  30         * NEWS: Mention new internal functions.
  31         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
  32         (read_base_type): Use dwarf2_init_complex_target_type.
  33         * value.c (creal_internal_fn): New function.
  34         (cimag_internal_fn): New function.
  35         (_initialize_values): Register new internal functions.
  36
  37 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  38
  39         * infrun.c (stop_all_threads): If debug_infrun, always
  40         trace the wait status after wait_one, using
  41         target_waitstatus_to_string and target_pid_to_str.
  42         (handle_inferior_event): Replace various trace of
  43         wait status kind by a single trace.
  44         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
  45         wait status kind image by target_waitstatus_to_string.
  46         * target/waitstatus.c (target_waitstatus_to_string): Fix
  47         obsolete comment.
  48
  49 2019-04-01  Tom Tromey  <tromey@adacore.com>
  50
  51         PR symtab/23331:
  52         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
  53
  54 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
  55             Pedro Alves  <palves@redhat.com>
  56
  57         * top.c (quit_force): Call 'finalize_values'.
  58         * value.c (finalize_values): New function.
  59         * value.h (finalize_values): Declare.
  60
  61 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
  62
  63         * NEWS: Announce $_gdb_major and $_gdb_minor.
  64
  65         * top.c (init_gdb_version_vars): New function.
  66         (gdb_init): Call init_gdb_version_vars.
  67
  68 2019-03-29  Tom Tromey  <tromey@adacore.com>
  69
  70         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
  71         help text.  Remove dead code.
  72
  73 2019-03-29  Keith Seitz  <keiths@redhat.com>
  74
  75         From Siddhesh Poyarekar:
  76         * f-lang.h (f77_get_upperbound): Return LONGEST.
  77         (f77_get_lowerbound): Likewise.
  78         * f-typeprint.c (f_type_print_varspec_suffix): Expand
  79         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
  80         print them.
  81         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
  82         plongest to format print it.
  83         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
  84         (f77_get_upperbound): Likewise.
  85         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
  86         LOWER_BOUND to LONGEST.
  87         (f77_create_arrayprint_offset_tbl): Likewise.
  88
  89 2019-03-29  Keith Seitz  <keiths@redhat.com>
  90
  91         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
  92         %s/pulongest for TYPE_LENGTH instead of %d in format
  93         strings.
  94         * ada-typerint.c (ada_print_type): Likewise.
  95         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
  96         * compile/compile-c-support.c (generate_register_struct): Likewise.
  97         * gdbtypes.c (recursive_dump_type): Likewise.
  98         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
  99         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 100         instead of %d in format strings.
 101         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 102         to std::min to ULONGEST.
 103         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 104         instead of %d in format strings.
 105         * tracepoint.c (info_scope_command): Likewise.
 106         * typeprint.c (print_offset_data::update)
 107         (print_offset_data::finish): Likewise.
 108         * xtensa-tdep.c (xtensa_store_return_value)
 109         (xtensa_push_dummy_call): Likewise.
 110
 111 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 112
 113         * windows-nat.c (display_selector): Fixed format specifications
 114         for 64-bit Cygwin.
 115
 116 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 117
 118         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 119
 120 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 121
 122         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 123         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 124         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 125         (nios2_linux_init_abi): Install it.
 126
 127 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 128
 129         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 130
 131 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 132
 133         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 134
 135 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 136             Tom Tromey  <tromey@adacore.com>
 137
 138         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 139
 140 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 141
 142         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 143         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 144         method to compute the bounds of range types. Also print "[evaluated]"
 145         if the bounds' values come from a dynamic evaluation.
 146
 147 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 148
 149         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 150         whitespace when pretty printing is on.
 151
 152 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 153
 154         * ppc-linux-nat.c: Add include.
 155
 156 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 157
 158         * NEWS: Mention AArch64 Pointer Authentication.
 159
 160 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 161
 162         * arm-linux-nat.c: Add include.
 163
 164 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 165
 166         * source-cache.c (source_cache::get_source_lines): Re-read
 167         fullname after calling open_source_file.
 168
 169 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 170
 171         * NEWS: Mention TLS support for FreeBSD.
 172
 173 2019-03-25  Tom Tromey  <tromey@adacore.com>
 174
 175         * minsyms.c (BUNCH_SIZE): Update comment.
 176         (~minimal_symbol_reader): Remove old comment.
 177         (compact_minimal_symbols): Update comment.
 178         (minimal_symbol_reader::install): Remove old comment.  Update
 179         other comments.
 180
 181 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 182
 183         * s390-linux-nat.c: Add include.
 184
 185 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 186
 187         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 188         Call linux_get_hwcap.
 189         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 190         Likewise.
 191         (aarch64_linux_get_hwcap): Remove function.
 192         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 193         declaration.
 194         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 195         linux_get_hwcap.
 196         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 197         * linux-tdep.c (linux_get_hwcap): Add function.
 198         (linux_get_hwcap2): Likewise.
 199         * linux-tdep.h (linux_get_hwcap): Add declaration.
 200         (linux_get_hwcap2): Likewise.
 201         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 202         (ppc_linux_get_hwcap2): Likewise.
 203         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 204         linux_get_hwcap.
 205         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 206         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 207         (ppc_linux_nat_target::read_description): Likewise.
 208         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 209         * s390-linux-nat.c: Likewise.
 210         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 211
 212 2019-03-24  Tom Tromey  <tom@tromey.com>
 213
 214         * ada-lang.c (standard_lookup): Simplify initialization.
 215         (ada_lookup_symbol_nonlocal): Simplify return.
 216         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 217         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 218         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 219         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 220         initialization.
 221         * solib.c (solib_global_lookup): Simplify.
 222         * symtab.c (null_block_symbol): Remove.
 223         (symbol_cache_lookup): Simplify returns.
 224         (lookup_language_this): Simplify returns.
 225         (lookup_symbol_aux): Simplify return.
 226         (lookup_local_symbol): Simplify returns.
 227         (lookup_global_symbol_from_objfile): Simplify return.
 228         (lookup_symbol_in_objfile_symtabs)
 229         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 230         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 231         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 232         * cp-namespace.c (cp_lookup_bare_symbol)
 233         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 234         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 235         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 236         (cp_lookup_symbol_via_imports): Simplify initialization.
 237         (find_symbol_in_baseclass): Likewise.
 238         * symtab.h (null_block_symbol): Remove.
 239         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 240         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 241         (d_lookup_symbol_module): Likewise.
 242         (find_symbol_in_baseclass): Simplify initialization.
 243
 244 2019-03-24  Tom Tromey  <tom@tromey.com>
 245
 246         * expression.h: Don't include symtab.h.
 247         (struct block): Forward declare.
 248
 249 2019-03-24  Tom Tromey  <tom@tromey.com>
 250
 251         * c-exp.y (typebase): Remove casts.
 252         * gdbtypes.c (lookup_unsigned_typename, )
 253         (lookup_signed_typename): Remove cast.
 254         * eval.c (parse_to_comma_and_eval): Remove cast.
 255         * parse.c (write_dollar_variable): Remove cast.
 256         * block.h (struct block) <superblock>: Now const.
 257         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 258         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 259         (map_block): Make "block" const.
 260         * symfile.h (struct quick_symbol_functions)
 261         <map_matching_symbols>: Constify block argument to "callback".
 262         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 263         const.
 264         (find_pc_sect_compunit_symtab): Make "b" const.
 265         (find_symbol_at_address): Likewise.
 266         (search_symbols): Likewise.
 267         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 268         (dw2_debug_names_lookup_symbol): Likewise.
 269         (dw2_map_matching_symbols): Update.
 270         * p-valprint.c (pascal_val_print): Remove "block".
 271         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 272         (aux_add_nonlocal_symbols): Make "block" const.
 273         (resolve_subexp): Remove cast.
 274         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 275         const.
 276         (iterate_over_file_blocks): Likewise.
 277         * f-exp.y (%union) <bval>: Remove.
 278         * coffread.c (patch_opaque_types): Make "b" const.
 279         * spu-tdep.c (spu_catch_start): Make "block" const.
 280         * c-valprint.c (print_unpacked_pointer): Remove "block".
 281         * symmisc.c (dump_symtab_1): Make "b" const.
 282         (block_depth): Make "block" const.
 283         * d-exp.y (%union) <bval>: Remove.
 284         * cp-support.h (cp_lookup_rtti_type): Update.
 285         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 286         * psymtab.c (psym_lookup_symbol): Make "block" const.
 287         (maintenance_check_psymtabs): Make "b" const.
 288         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 289         (enumerate_locals, enumerate_args): Update.
 290         * python/py-symtab.c (stpy_global_block): Make "block" const.
 291         (stpy_static_block): Likewise.
 292         * inline-frame.c (block_starting_point_at): Make "new_block"
 293         const.
 294         * block.c (find_block_in_blockvector): Make return type const.
 295         (blockvector_for_pc_sect): Make "b" const.
 296         (find_block_in_blockvector): Make "b" const.
 297
 298 2019-03-23  Tom Tromey  <tom@tromey.com>
 299
 300         * varobj.c (varobj_create): Update.
 301         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 302         * printcmd.c (display_command, do_one_display): Don't reset
 303         innermost_block.
 304         * parser-defs.h (enum innermost_block_tracker_type): Move to
 305         expression.h.
 306         (innermost_block): Update comment.
 307         * parse.c (parse_exp_1): Add tracker_types parameter.
 308         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 309         tracker_types parameter.  Reset innermost_block.
 310         (parse_exp_in_context): Remove.
 311         (parse_expression_for_completion): Update.
 312         * objfiles.c (~objfile): Don't reset expression_context_block or
 313         innermost_block.
 314         * expression.h (enum innermost_block_tracker_type): Move from
 315         parser-defs.h.
 316         (parse_exp_1): Add tracker_types parameter.
 317         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 318         reset innermost_block.
 319
 320 2019-03-23  Tom Tromey  <tom@tromey.com>
 321
 322         * objfiles.h: Include bcache.h.
 323
 324 2019-03-23  Tom Tromey  <tom@tromey.com>
 325
 326         * linespec.c (get_current_search_block): Use
 327         scoped_restore_current_language.
 328         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 329
 330 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 331             Jiong Wang  <jiong.wang@arm.com>
 332
 333         * aarch64-linux-tdep.c
 334         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 335         section.
 336         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 337
 338 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 339             Jiong Wang  <jiong.wang@arm.com>
 340
 341         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 342         instructions.
 343         (aarch64_analyze_prologue_test): Add PACIASP test.
 344         (aarch64_prologue_prev_register): Unmask PC value.
 345
 346 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 347             Jiong Wang  <jiong.wang@arm.com>
 348
 349         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 350         (aarch64_dwarf2_prev_register): Unmask PC value.
 351         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 352         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 353         DW_CFA_AARCH64_negate_ra_state.
 354         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 355
 356 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 357             Jiong Wang  <jiong.wang@arm.com>
 358
 359         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 360         registers.
 361         (aarch64_pseudo_register_name): Likewise.
 362         (aarch64_pseudo_register_type): Likewise.
 363         (aarch64_pseudo_register_reggroup_p): Likewise.
 364         (aarch64_gdbarch_init): Add pauth registers.
 365         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 366         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 367         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 368         (struct gdbarch_tdep): Add regnum for ra_state.
 369
 370 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 371             Jiong Wang  <jiong.wang@arm.com>
 372
 373         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 374
 375 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 376             Jiong Wang  <jiong.wang@arm.com>
 377
 378         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 379         function.
 380         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 381         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 382         (aarch64_gdbarch_init): Add puth registers.
 383         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 384         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 385         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 386
 387 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 388             Jiong Wang  <jiong.wang@arm.com>
 389
 390         * aarch64-linux-nat.c
 391         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 392         * aarch64-linux-tdep.c
 393         (aarch64_linux_core_read_description): Likewise.
 394         (aarch64_linux_get_hwcap): New function.
 395         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 396         (aarch64_linux_get_hwcap): New declaration.
 397
 398 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 399             Jiong Wang  <jiong.wang@arm.com>
 400
 401         * aarch64-linux-nat.c
 402         (aarch64_linux_nat_target::read_description): Add pauth param.
 403         * aarch64-linux-tdep.c
 404         (aarch64_linux_core_read_description): Likewise.
 405         * aarch64-tdep.c (struct target_desc): Add in pauth.
 406         (aarch64_read_description): Add pauth param.
 407         (aarch64_gdbarch_init): Likewise.
 408         * aarch64-tdep.h (aarch64_read_description): Likewise.
 409         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 410         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 411         * features/Makefile: Add new files.
 412         * features/aarch64-pauth.c: New file.
 413         * features/aarch64-pauth.xml: New file.
 414
 415 2019-03-20  Tom Tromey  <tromey@adacore.com>
 416
 417         * infrun.c (handle_inferior_event): Rename from
 418         handle_inferior_event_1.  Create a scoped_value_mark.
 419         (handle_inferior_event): Remove.
 420
 421 2019-03-19  Tom Tromey  <tromey@adacore.com>
 422
 423         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 424         * infrun.h (print_stop_event): Add "displays" parameter.
 425         * infrun.c (print_stop_event): Add "displays" parameter.
 426
 427 2019-03-19  Pedro Alves  <palves@redhat.com>
 428
 429         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 430         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 431         to -1.  Fix TABs vs spaces.
 432         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 433         * tui/tui-out.h (tui_ui_out) Add intro comments.
 434         <m_line, m_start_of_line>: In-class initialize, and add describing
 435         comment.
 436
 437 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 438
 439         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 440         variable names.
 441         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 442
 443 2019-03-18  Pedro Alves  <palves@redhat.com>
 444             Eli Zaretskii <eliz@gnu.org>
 445
 446         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 447         m_line and m_start_of_line.
 448
 449 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 450
 451         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 452         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 453         it returns a newline.  This fixes a regression in TU mode, whereby
 454         the next line is output on the same screen line as the user input.
 455
 456 2019-03-18  Tom Tromey  <tromey@adacore.com>
 457
 458         * minsyms.c (minimal_symbol_reader::install): Remove call to
 459         obstack_blank.
 460
 461 2019-03-18  Pedro Alves  <palves@redhat.com>
 462
 463         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 464         New globals.
 465         (apply_style): New, factored out from ...
 466         (apply_ansi_escape): ... this.  Handle reverse video mode.
 467         (tui_set_reverse_mode): New function.
 468         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 469         * tui/tui-winsource.c (tui_show_source_line): Use
 470         tui_set_reverse_mode instead of setting A_STANDOUT.
 471         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 472         New setter methods.
 473
 474 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 475
 476         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 477         Handle tabs.
 478
 479 2019-03-18  Tom Tromey  <tromey@adacore.com>
 480
 481         * ada-lang.c (empty_array): Add "high" parameter.
 482         (ada_evaluate_subexp): Update.
 483
 484 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 485
 486         * unittests/string_view-selftests.c: Define
 487         _initialize_string_view_selftests unconditionally.
 488
 489 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 490
 491         PR gdb/24350
 492         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 493
 494 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 495
 496         PR gdb/24351
 497         * windows-nat.c (display_selector): Fix format specifiers.
 498
 499 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 500
 501         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 502         tui_refill_source_window instead of tui_refresh_win, to update the
 503         current execution line.  This fixes redisplay of the current line
 504         when stepping through the code with "next" or "step".
 505
 506 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 507
 508         * source-cache.c (source_cache::get_source_lines): Call
 509         find_source_lines to initialize s->nlines.  This fixes vertical
 510         scrolling of TUI source window when the DOWN arrow is pressed.
 511
 512 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 513
 514         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 515         linux-thread-db.c (_initialize_thread_db): Likewise.
 516
 517 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 518
 519         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 520         wclrtoeol in tui_show_source_line".  This reverts changes made in
 521         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 522
 523 2019-03-15  Tom Tromey  <tom@tromey.com>
 524
 525         * symtab.h (struct minimal_symbol): Derive from
 526         general_symbol_info.
 527         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 528         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 529         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 530         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 531         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 532         (MSYMBOL_SEARCH_NAME): Update.
 533         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 534         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 535         * minsyms.c (minimal_symbol_reader::record_full): Update.
 536
 537 2019-03-15  Tom Tromey  <tom@tromey.com>
 538
 539         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 540
 541 2019-03-15  Tom Tromey  <tom@tromey.com>
 542
 543         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 544         unique_xmalloc_ptr.
 545         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 546         Update.
 547         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 548         (build_minimal_symbol_hash_tables)
 549         (minimal_symbol_reader::install): Update.
 550
 551 2019-03-15  Tom Tromey  <tom@tromey.com>
 552
 553         * symtab.c (create_demangled_names_hash): Update.
 554         (symbol_set_names): Update.
 555         * objfiles.h (struct objfile_per_bfd_storage)
 556         <demangled_names_hash>: Now an htab_up.
 557         * objfiles.c (objfile_per_bfd_storage): Simplify.
 558
 559 2019-03-15  Tom Tromey  <tom@tromey.com>
 560
 561         * objfiles.h (struct objfile_per_bfd_storage): Declare
 562         destructor.
 563         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 564         New.
 565         (get_objfile_bfd_data): Use new.  Don't initialize
 566         language_of_main.
 567         (free_objfile_per_bfd_storage): Remove.
 568         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 569
 570 2019-03-15  Tom Tromey  <tom@tromey.com>
 571
 572         * symfile.c (reread_symbols): Update.
 573         * objfiles.c (objfile::objfile): Update.
 574         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 575         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 576         comment.
 577         (minimal_symbol_reader::install): Update.
 578         (terminate_minimal_symbol_table): Remove.
 579         * jit.c (jit_object_close_impl): Update.
 580
 581 2019-03-15  Tom Tromey  <tom@tromey.com>
 582
 583         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 584         initializations.
 585
 586 2019-03-15  Tom Tromey  <tom@tromey.com>
 587
 588         * objfiles.h (struct objfile_per_bfd_storage)
 589         <demangled_hash_languages>: Now a bitset.
 590         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 591         (lookup_minimal_symbol): Update.
 592
 593 2019-03-15  Tom Tromey  <tom@tromey.com>
 594
 595         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 596         Don't return the symbol.
 597         * coffread.c (record_minimal_symbol): Use record_full.
 598
 599 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 600
 601         The MS-Windows port of ncurses fails to switch to a color pair if
 602         one or both of the colors are the implicit default colors.  This
 603         change records the default colors when TUI is initialized, and
 604         then specifies them explicitly when a color pair uses the default
 605         colors.  This allows color styling in TUI mode on MS-Windows.
 606
 607         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 608         ncurses_norm_attr.
 609         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 610         colors in ncurses_norm_attr.
 611         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 612         "none", replace it with the default color recorded in
 613         ncurses_norm_attr.
 614
 615 2019-03-14  Tom Tromey  <tromey@adacore.com>
 616
 617         * source-cache.h (class source_cache) <get_source_lines>: Return
 618         std::string.
 619         * source-cache.c (source_cache::extract_lines): Handle case where
 620         first_pos==npos.  Return std::string.
 621         (source_cache::get_source_lines): Update.
 622
 623 2019-03-14  Tom Tromey  <tromey@adacore.com>
 624
 625         * NEWS: Add item for "style sources" commands.
 626         * source-cache.c (source_cache::get_source_lines): Check
 627         source_styling.
 628         * cli/cli-style.c (source_styling): New global.
 629         (_initialize_cli_style): Add "style sources" commands.
 630         (show_style_sources): New function.
 631         * cli/cli-style.h (source_styling): Declare.
 632
 633 2019-03-14  Pedro Alves  <palves@redhat.com>
 634             Tom Tromey  <tromey@adacore.com>
 635
 636         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 637         * tui/tui-winsource.c (tui_refill_source_window): New function,
 638         from...
 639         (tui_horizontal_source_scroll): ... here.  Move some logic.
 640         * cli/cli-style.c (set_style_enabled): Notify new observable.
 641         * tui/tui-hooks.c (tui_redisplay_source): New function.
 642         (tui_attach_detach_observers): Attach or detach
 643         tui_redisplay_source.
 644         * observable.h (source_styling_changed): New observable.
 645         * observable.c: Define source_styling_changed observable.
 646
 647 2019-03-13  Tom Tromey  <tromey@adacore.com>
 648
 649         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 650         (i386_gnu_nat_target::store_registers): Update.
 651         * target-debug.h (target_debug_print_std_string): New macro.
 652         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 653         * windows-tdep.c (display_one_tib): Update.
 654         * tui/tui-stack.c (tui_make_status_line): Update.
 655         * top.c (print_inferior_quit_action): Update.
 656         * thread.c (thr_try_catch_cmd): Update.
 657         (add_thread_with_info): Update.
 658         (thread_target_id_str): Update.
 659         (thr_try_catch_cmd): Update.
 660         (thread_command): Update.
 661         (thread_find_command): Update.
 662         * record-btrace.c (record_btrace_target::info_record)
 663         (record_btrace_resume_thread, record_btrace_target::resume)
 664         (record_btrace_cancel_resume, record_btrace_step_thread)
 665         (record_btrace_target::wait, record_btrace_target::wait)
 666         (record_btrace_target::wait, record_btrace_target::stop): Update.
 667         * progspace.c (print_program_space): Update.
 668         * process-stratum-target.c
 669         (process_stratum_target::thread_address_space): Update.
 670         * linux-fork.c (linux_fork_mourn_inferior)
 671         (detach_checkpoint_command, info_checkpoints_command)
 672         (linux_fork_context): Update.
 673         (linux_fork_detach): Update.
 674         (class scoped_switch_fork_info): Update.
 675         (delete_checkpoint_command): Update.
 676         * infrun.c (follow_fork_inferior): Update.
 677         (follow_fork_inferior): Update.
 678         (proceed_after_vfork_done): Update.
 679         (handle_vfork_child_exec_or_exit): Update.
 680         (follow_exec): Update.
 681         (displaced_step_prepare_throw): Update.
 682         (displaced_step_restore): Update.
 683         (start_step_over): Update.
 684         (resume_1): Update.
 685         (clear_proceed_status_thread): Update.
 686         (proceed): Update.
 687         (print_target_wait_results): Update.
 688         (do_target_wait): Update.
 689         (context_switch): Update.
 690         (stop_all_threads): Update.
 691         (restart_threads): Update.
 692         (finish_step_over): Update.
 693         (handle_signal_stop): Update.
 694         (switch_back_to_stepped_thread): Update.
 695         (keep_going_pass_signal): Update.
 696         (print_exited_reason): Update.
 697         (normal_stop): Update.
 698         * inferior.c (inferior_pid_to_str): Change return type.
 699         (print_selected_inferior): Update.
 700         (add_inferior): Update.
 701         (detach_inferior): Update.
 702         * dummy-frame.c (fprint_dummy_frames): Update.
 703         * dcache.c (dcache_info_1): Update.
 704         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 705         (btrace_fetch, btrace_clear): Update.
 706         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 707         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 708         type.
 709         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 710         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 711         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 712         * gdbarch.c, gdbarch.h: Rebuild.
 713         * gdbarch.sh (core_pid_to_str): Change return type.
 714         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 715         return type.
 716         (windows_nat_target::pid_to_str): Change return type.
 717         (windows_delete_thread): Update.
 718         (windows_nat_target::attach): Update.
 719         (windows_nat_target::files_info): Update.
 720         * target-delegates.c: Rebuild.
 721         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 722         return type.
 723         (sol_thread_target::pid_to_str): Change return type.
 724         * remote.c (class remote_target) <pid_to_str>: Change return
 725         type.
 726         (remote_target::pid_to_str): Change return type.
 727         (extended_remote_target::attach, remote_target::remote_stop_ns)
 728         (remote_target::remote_notif_remove_queued_reply)
 729         (remote_target::push_stop_reply, remote_target::disable_btrace):
 730         Update.
 731         (extended_remote_target::attach): Update.
 732         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 733         type.
 734         (gdbsim_target::pid_to_str): Change return type.
 735         * ravenscar-thread.c (struct ravenscar_thread_target)
 736         <pid_to_str>: Change return type.
 737         (ravenscar_thread_target::pid_to_str): Change return type.
 738         * procfs.c (class procfs_target) <pid_to_str>: Change return
 739         type.
 740         (procfs_target::pid_to_str): Change return type.
 741         (procfs_target::attach): Update.
 742         (procfs_target::detach): Update.
 743         (procfs_target::fetch_registers): Update.
 744         (procfs_target::store_registers): Update.
 745         (procfs_target::wait): Update.
 746         (procfs_target::files_info): Update.
 747         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 748         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 749         return type.
 750         (nto_procfs_target::pid_to_str): Change return type.
 751         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 752         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 753         return type.
 754         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 755         (exit_lwp): Update.
 756         (attach_proc_task_lwp_callback, get_detach_signal)
 757         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 758         (linux_nat_target::resume, wait_lwp, stop_callback)
 759         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 760         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 761         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 762         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 763         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 764         type.
 765         (inf_ptrace_target::attach): Update.
 766         (inf_ptrace_target::files_info): Update.
 767         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 768         type.
 769         (go32_nat_target::pid_to_str): Change return type.
 770         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 771         (gnu_nat_target::wait): Update.
 772         (gnu_nat_target::wait): Update.
 773         (gnu_nat_target::resume): Update.
 774         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 775         (fbsd_nat_target::wait): Update.
 776         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 777         type.
 778         (darwin_nat_target::attach): Update.
 779         * corelow.c (class core_target) <pid_to_str>: Change return type.
 780         (core_target::pid_to_str): Change return type.
 781         * target.c (normal_pid_to_str): Change return type.
 782         (default_pid_to_str): Likewise.
 783         (target_pid_to_str): Change return type.
 784         (target_translate_tls_address): Update.
 785         (target_announce_detach): Update.
 786         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 787         return type.
 788         (bsd_uthread_target::pid_to_str): Change return type.
 789         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 790         type.
 791         (bsd_kvm_target::pid_to_str): Change return type.
 792         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 793         return type.
 794         (aix_thread_target::pid_to_str): Change return type.
 795         * target.h (struct target_ops) <pid_to_str>: Change return type.
 796         (target_pid_to_str, normal_pid_to_str): Likewise.
 797         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 798         type.
 799         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 800         type.
 801         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 802         return type.
 803         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 804         type.
 805         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 806         type.
 807         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 808         return type.
 809
 810 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 811
 812         * NEWS: Mention that the new default MI version is 3.  Mention
 813         changes to the output of commands and events that deal with
 814         multi-location breakpoints.
 815         * breakpoint.c: Include "mi/mi-out.h".
 816         (print_one_breakpoint): Change output syntax if using MI version
 817         >= 3.
 818         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 819         New.
 820         (mi_multi_location_breakpoint_output_fixed): New.
 821         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 822         (mi_cmd_fix_multi_location_breakpoint_output): New.
 823         (mi_multi_location_breakpoint_output_fixed): New.
 824         * mi/mi-cmds.c (mi_cmds): Register command
 825         -fix-multi-location-breakpoint-output.
 826         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 827         interpreter "mi".
 828
 829 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 830
 831         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 832         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 833         instantiate mi_ui_out based on interpreter name.
 834         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 835         * mi/mi-main.c (mi_load_progress): Likewise.
 836
 837 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 838
 839         * NEWS: Combine separate "New targets" sections for 8.3.
 840
 841 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 842
 843         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 844         (ppcfbsd_init_abi): Install gdbarch
 845         "fetch_tls_load_module_address" and "get_thread_local_address"
 846         methods.
 847
 848 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 849
 850         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 851         (riscv_fbsd_init_abi): Install gdbarch
 852         "fetch_tls_load_module_address" and "get_thread_local_address"
 853         methods.
 854
 855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 856
 857         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 858         (i386fbsd_init_abi): Install gdbarch
 859         "fetch_tls_load_module_address" and "get_thread_local_address"
 860         methods.
 861
 862 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 863
 864         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 865         (amd64fbsd_init_abi): Install gdbarch
 866         "fetch_tls_load_module_address" and "get_thread_local_address"
 867         methods.
 868
 869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 870
 871         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 872         (struct fbsd_pspace_data): New type.
 873         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 874         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 875         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 876         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 877         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 878
 879 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 880
 881         * gdbtypes.c (lookup_struct_elt): New function.
 882         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 883         * gdbtypes.h (struct struct_elt): New type.
 884         (lookup_struct_elt): New prototype.
 885
 886 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 887
 888         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 889         remove disabled code block.
 890
 891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 892
 893         * gdbarch.sh (get_thread_local_address): New method.
 894         * gdbarch.h, gdbarch.c: Regenerate.
 895         * target.c (target_translate_tls_address): Use
 896         gdbarch_get_thread_local_address if present instead of
 897         target::get_thread_local_address.
 898
 899 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 900
 901         * target.h (target::get_thread_local_address): Update comment.
 902
 903 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 904
 905         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 906         objfile->separate_debug_objfile_backlink if not NULL.
 907
 908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 909
 910         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 911         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 912         (amd64bsd_store_inferior_registers): Likewise.
 913         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 914         Enable segment base registers.
 915         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 916         PT_GETFSBASE and PT_GETGSBASE.
 917         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 918         PT_SETGSBASE.
 919         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 920         segment base registers.
 921         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 922
 923 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 924
 925         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 926         Update calls to i386_target_description to add 'segments'
 927         parameter.
 928         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 929         add segment base registers.
 930         * arch/i386.c (i386_create_target_description): Add 'segments'
 931         parameter to enable segment base registers.
 932         * arch/i386.h (i386_create_target_description): Likewise.
 933         * features/i386/32bit-segments.xml: New file.
 934         * features/i386/32bit-segments.c: Generate.
 935         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 936         call to i386_target_description to add 'segments' parameter.
 937         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 938         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 939         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 940         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 941         if feature is present.
 942         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 943         Add 'segments' parameter to call to i386_target_description.
 944         (i386_target_description): Add 'segments' parameter to enable
 945         segment base registers.
 946         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 947         to call to i386_target_description.
 948         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 949         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 950         Define I386_NUM_REGS.
 951         (i386_target_description): Add 'segments' parameter to enable
 952         segment base registers.
 953
 954 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 955
 956         PR/24325
 957         * source-cache.c: #undef open and close, to avoid unresolved
 958         externals during linking.
 959
 960 2019-03-12  Tom Tromey  <tromey@adacore.com>
 961
 962         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 963         const.  Add initializers.
 964         (_initialize_remote): Don't initialize ptid globals.
 965
 966 2019-03-12  Pedro Alves  <palves@redhat.com>
 967
 968         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 969
 970 2019-03-12  Pedro Alves  <palves@redhat.com>
 971
 972         * cp-name-parser.y (main): Remove unused 'len' variable.
 973
 974 2019-03-12  Tom Tromey  <tromey@adacore.com>
 975
 976         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 977         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 978
 979 2019-03-12  Tom Tromey  <tromey@adacore.com>
 980
 981         * linux-nat.c (iterate_over_lwps): Update.
 982         (stop_callback): Remove parameter.
 983         (stop_wait_callback, detach_callback, resume_set_callback)
 984         (select_singlestep_lwp_callback, set_ignore_sigint)
 985         (status_callback, resumed_callback, resume_clear_callback)
 986         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 987         data parameter.
 988         (linux_nat_target::detach, linux_nat_target::resume)
 989         (linux_stop_and_wait_all_lwps, select_event_lwp)
 990         (linux_nat_filter_event, linux_nat_wait_1)
 991         (linux_nat_target::kill, linux_nat_target::stop)
 992         (linux_nat_target::stop): Update.
 993         (linux_nat_resume_callback): Change type.
 994         (resume_stopped_resumed_lwps, count_events_callback)
 995         (select_event_lwp_callback): Likewise.
 996         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 997         * arm-linux-nat.c (struct update_registers_data): Remove.
 998         (update_registers_callback): Change type.
 999         (arm_linux_insert_hw_breakpoint1): Update.
1000         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1001         parameter.
1002         (x86_linux_dr_set_addr): Update.
1003         (x86_linux_dr_set_control): Update.
1004         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1005         (iterate_over_lwps): Use gdb::function_view.
1006         * nat/aarch64-linux-hw-point.c (struct
1007         aarch64_dr_update_callback_param): Remove.
1008         (debug_reg_change_callback): Change type.
1009         (aarch64_notify_debug_reg_change): Update.
1010         * s390-linux-nat.c (s390_refresh_per_info): Update.
1011
1012 2019-03-11  Tom Tromey  <tromey@adacore.com>
1013
1014         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1015         redundant assignment to "this_cu".
1016
1017 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1018
1019         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1020
1021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1022
1023         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1024         from...
1025         (rank_one_type): ... this.
1026
1027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1028
1029         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1030         from...
1031         (rank_one_type): ... this.
1032
1033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1034
1035         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1036         from...
1037         (rank_one_type): ... this.
1038
1039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1040
1041         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1042         from...
1043         (rank_one_type): ... this.
1044
1045 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1046
1047         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1048         from...
1049         (rank_one_type): ... this.
1050
1051 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1052
1053         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1054         from...
1055         (rank_one_type): ... this.
1056
1057 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1058
1059         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1060         from...
1061         (rank_one_type): ... this.
1062
1063 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1064
1065         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1066         from...
1067         (rank_one_type): ... this.
1068
1069 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1070
1071         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1072         from...
1073         (rank_one_type): ... this.
1074
1075 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1076
1077         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1078         from...
1079         (rank_one_type): ... this.
1080
1081 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1082
1083         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1084         from...
1085         (rank_one_type): ... this.
1086
1087 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1088
1089         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1090         from...
1091         (rank_one_type): ... this.
1092
1093 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1094
1095         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1096         inferior-events' shows the example events.
1097
1098 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1099
1100         Support styling on native MS-Windows console
1101
1102         PR/24315
1103         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1104         on MS-Windows if $TERM is not defined.
1105
1106         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1107
1108         * posix-hdep.c (gdb_console_fputs):
1109         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1110         functions.
1111         * ui-file.h (gdb_console_fputs): Add prototype.
1112
1113         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1114         back to fputs only if the former returns zero.
1115
1116 2019-03-07  Tom Tromey  <tom@tromey.com>
1117
1118         * symmisc.c (print_symbol_bcache_statistics): Update.
1119         (print_objfile_statistics): Update.
1120         * symfile.c (allocate_symtab): Update.
1121         * stabsread.c: Don't include bcache.h.
1122         * psymtab.h (struct psymbol_bcache): Don't declare.
1123         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1124         (psymbol_bcache_init, psymbol_bcache_free)
1125         (psymbol_bcache_get_bcache): Don't declare.
1126         * psymtab.c (struct psymbol_bcache): Remove.
1127         (psymtab_storage::psymtab_storage): Update.
1128         (psymtab_storage::~psymtab_storage): Update.
1129         (psymbol_bcache_init, psymbol_bcache_free)
1130         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1131         (add_psymbol_to_bcache): Update.
1132         (allocate_psymtab): Update.
1133         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1134         macro_cache>: No longer pointers.
1135         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1136         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1137         * macrotab.c (macro_bcache): Update.
1138         * macroexp.c: Don't include bcache.h.
1139         * gdbtypes.c (check_types_worklist): Update.
1140         (types_deeply_equal): Remove TRY/CATCH.  Update.
1141         * elfread.c (elf_symtab_read): Update.
1142         * dwarf2read.c: Don't include bcache.h.
1143         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1144         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1145         (print_bcache_statistics, bcache_memory_used): Don't declare.
1146         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1147         methods.  Rename all data members.
1148         * bcache.c (struct bcache): Move to bcache.h.
1149         (bcache::expand_hash_table): Rename from expand_hash_table.
1150         (bcache): Remove.
1151         (bcache::insert): Rename from bcache_full.
1152         (bcache::compare): Rename from bcache_compare.
1153         (bcache_xmalloc): Remove.
1154         (bcache::~bcache): Rename from bcache_xfree.
1155         (bcache::print_statistics): Rename from print_bcache_statistics.
1156         (bcache::memory_used): Rename from bcache_memory_used.
1157
1158 2019-03-07  Pedro Alves  <palves@redhat.com>
1159
1160         * infrun.c (normal_stop): Also check for
1161         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1162
1163 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * f-lang.c (value_from_host_double): Moved to...
1166         * value.c (value_from_host_double): ...here.
1167         * value.h (value_from_host_double): Declare.
1168         * guile/scm-math.c (vlscm_convert_typed_number): Use
1169         value_from_host_double.
1170         (vlscm_convert_number): Likewise.
1171         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1172         * python/py-value.c (convert_value_from_python): Likewise.
1173
1174 2019-03-06  Tom Tromey  <tom@tromey.com>
1175
1176         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1177
1178 2019-03-06  Tom Tromey  <tom@tromey.com>
1179
1180         * utils.h (free_current_contents): Don't declare.
1181         * utils.c (free_current_contents): Remove.
1182
1183 2019-03-06  Tom Tromey  <tom@tromey.com>
1184
1185         * top.c (quit_force): Update.
1186         * main.c (captured_command_loop): Update.
1187         * common/new-op.c (operator new): Update.
1188         * common/common-exceptions.c (struct catcher)
1189         <save_cleanup_chain>: Remove member.
1190         (exceptions_state_mc_init): Update.
1191         (exception_try_scope_entry): Return nullptr.
1192         (exception_try_scope_exit, exception_rethrow)
1193         (throw_exception_sjlj, throw_exception_cxx): Update.
1194         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1195         (all_cleanups, do_cleanups, discard_cleanups)
1196         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1197         (restore_cleanups, restore_final_cleanups): Don't declare.
1198         (do_final_cleanups): Remove parameter.
1199         * common/cleanups.c (cleanup_chain, make_cleanup)
1200         (make_cleanup_dtor, all_cleanups, do_cleanups)
1201         (discard_my_cleanups, discard_cleanups)
1202         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1203         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1204         (null_cleanup): Remove.
1205         (do_final_cleanups): Remove parameter.
1206
1207 2019-03-06  Tom Tromey  <tom@tromey.com>
1208
1209         * remote.c (remote_target::remote_parse_stop_reply): Use
1210         unique_xmalloc_ptr.
1211
1212 2019-03-06  Tom Tromey  <tom@tromey.com>
1213
1214         * stabsread.c (struct stabs_field_info): Rename from field_info.
1215         <list, fnlist>: Add initializers.
1216         <obstack>: New member.
1217         (read_member_functions, read_struct_fields, read_baseclasses):
1218         Allocate on obstack.  Don't use cleanups.
1219         (read_one_struct_field, read_member_functions, read_struct_fields)
1220         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1221         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1222         (read_struct_type): Update.
1223
1224 2019-03-06  Tom Tromey  <tom@tromey.com>
1225
1226         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1227         * common/filestuff.h (make_cleanup_close): Don't declare.
1228         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1229         Remove.
1230
1231 2019-03-06  Tom Tromey  <tom@tromey.com>
1232
1233         * solib-aix.c: Use make_scope_exit.
1234
1235 2019-03-06  Tom Tromey  <tom@tromey.com>
1236
1237         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1238         Use make_scope_exit.
1239
1240 2019-03-06  Tom Tromey  <tom@tromey.com>
1241
1242         * solib-svr4.c (disable_probes_interface): Remove parameter.
1243         (svr4_handle_solib_event): Use make_scope_exit.
1244
1245 2019-03-06  Tom Tromey  <tom@tromey.com>
1246
1247         * remote.c (struct stop_reply_deleter): Remove.
1248         (stop_reply_up): Update.
1249         (struct stop_reply): Derive from notif_event.  Don't typedef.
1250         <regcache>: Now a std::vector.
1251         (stop_reply_xfree): Remove.
1252         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1253         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1254         (remote_target::discard_pending_stop_replies): Use delete.
1255         (remote_target::remote_parse_stop_reply): Update.
1256         (remote_target::process_stop_reply): Update.
1257         * remote-notif.h (struct notif_event): Add virtual destructor.
1258         Remove "dtr" member.
1259         (struct notif_client) <alloc_event>: Return a unique_ptr.
1260         (notif_event_xfree): Don't declare.
1261         (notif_event_up): New typedef.
1262         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1263         (notif_event_xfree, do_notif_event_xfree): Remove.
1264         (remote_notif_state_xfree): Update.
1265
1266 2019-03-06  Tom Tromey  <tom@tromey.com>
1267
1268         * infrun.c (displaced_step_clear_cleanup): Now a
1269         forward_scope_exit type.
1270         (displaced_step_prepare_throw): Update.
1271         (displaced_step_fixup): Update.
1272
1273 2019-03-06  Tom Tromey  <tom@tromey.com>
1274
1275         * inferior.h (class inferior): Update comment.
1276         * gdbthread.h (class thread_info): Update comment.
1277
1278 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1279             Tom Tromey  <tom@tromey.com>
1280
1281         * stabsread.h (struct stab_section_list): Remove.
1282         (coffstab_build_psymtabs): Update.
1283         * dbxread.c (symbuf_sections): Now a std::vector.
1284         (sect_idx): New global.
1285         (fill_symbuf): Update.
1286         (coffstab_build_psymtabs): Change type of stabsects parameter.
1287         Update.
1288         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1289         std::vector.
1290         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1291         (coff_locate_sections): Update.
1292         (coff_symfile_read): Remove cleanups.  Update.
1293         (init_stringtab): Add storage parameter.
1294         (free_stringtab, free_stringtab_cleanup): Remove.
1295         (init_lineno): Add storage parameter.
1296         (free_linetab, free_linetab_cleanup): Remove.
1297
1298 2019-03-06  Pedro Alves  <palves@redhat.com>
1299
1300         * linux-fork.c (fork_info::clobber_regs): Delete.
1301         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1302         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1303         comment.  Adjust.
1304         (scoped_switch_fork_info::scoped_switch_fork_info)
1305         (checkpoint_command, linux_fork_context): Adjust
1306         fork_save_infrun_state calls.
1307
1308 2019-03-06  Pedro Alves  <palves@redhat.com>
1309
1310         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1311         (inf_has_multiple_threads): Return 'bool' and rewrite using
1312         inferior_info::threads().
1313
1314 2019-03-06  Pedro Alves  <palves@redhat.com>
1315
1316         * linux-fork.c: Include <list>.
1317         (fork_list): Now a std::list instance.
1318         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1319         (forks_exist_p, find_last_fork): Adjust.
1320         (new_fork): Delete.
1321         (one_fork_p): New.
1322         (add_fork): Adjust.
1323         (free_fork): Delete, folded into fork_info::~fork_info().
1324         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1325         Adjust.
1326         (init_fork_list): Delete.
1327         (linux_fork_killall, linux_fork_mourn_inferior)
1328         (linux_fork_detach, info_checkpoints_command): Adjust.
1329         (_initialize_linux_fork): No longer call init_fork_list.
1330
1331 2019-03-06  Pedro Alves  <palves@redhat.com>
1332
1333         * linux-fork.c (new_fork): New, split out of ...
1334         (add_fork): ... this.  Return void.  Move "first fork" special
1335         case from here, to ...
1336         (checkpoint_command): ... here.
1337         * linux-linux.h (add_fork): Return void.
1338
1339 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1340
1341         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1342
1343 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1344             Chris January  <chris.january@arm.com>
1345             David Lecomber  <david.lecomber@arm.com>
1346
1347         * f-exp.y: New token, UNOP_INTRINSIC.
1348         (exp): New pattern using UNOP_INTRINSIC token.
1349         (f77_keywords): Add 'abs' keyword.
1350         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1351         (value_from_host_double): New function.
1352         (evaluate_subexp_f): Support UNOP_ABS.
1353
1354 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1355
1356         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1357         types.
1358
1359 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1360
1361         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1362         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1363         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1364
1365 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1366
1367         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1368
1369 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1370             Chris January  <chris.january@arm.com>
1371
1372         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1373         * f-exp.y: Define 'KIND' token.
1374         (exp): New pattern for KIND expressions.
1375         (ptype): Handle types with a kind extension.
1376         (direct_abs_decl): Extend to spot kind extensions.
1377         (f77_keywords): Add 'kind' to the list.
1378         (push_kind_type): New function.
1379         (convert_to_kind_type): New function.
1380         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1381         * parse.c (operator_length_standard): Likewise.
1382         * parser-defs.h (enum type_pieces): Add tp_kind.
1383         * std-operator.def: Add UNOP_KIND.
1384
1385 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * f-exp.y (f_parse): Set yydebug.
1388
1389 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1390
1391         * f-lang.c (evaluate_subexp_f): New function.
1392         (exp_descriptor_f): New global.
1393         (f_language_defn): Use exp_descriptor_f instead of
1394         exp_descriptor_standard.
1395
1396 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1397
1398         * f-exp.y (struct token): Add comments.
1399         (dot_ops): Remove uppercase versions and the end marker.
1400         (f77_keywords): Likewise.
1401         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1402         entries in the dot_ops array are case insensitive, and use
1403         strncasecmp to compare strings.  Also some whitespace cleanup in
1404         this area.  Similar for the f77_keywords array, except entries in
1405         this list might be case sensitive.
1406
1407 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1408
1409         * f-exp.y (struct f77_boolean_val): Add comments.
1410         (boolean_values): Remove uppercase versions, and end marker.
1411         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1412         and use strncasecmp to achieve case insensitivity.  Additionally,
1413         perform whitespace cleanup around this code.
1414
1415 2019-03-06  Tom Tromey  <tromey@adacore.com>
1416
1417         * remote-sim.c (gdbsim_target_open): Use result of
1418         gdb_argv::release.
1419
1420 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1421         Dirk Schubert  <dirk.schubert@arm.com>
1422         Chris January  <chris.january@arm.com>
1423
1424         * eval.c (evaluate_subexp_standard): Call Fortran argument
1425         wrapping logic.
1426         * f-lang.c (struct value): A value which can be passed into a
1427         Fortran function call.
1428         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1429         where appropriate.
1430         (struct type): Value ready for a Fortran function call.
1431         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1432         is needed.
1433         * f-lang.h (fortran_argument_convert): Declaration.
1434         (fortran_preserve_arg_pointer): Declaration.
1435         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1436
1437 2019-03-05  Tom Tromey  <tromey@adacore.com>
1438
1439         * python/py-prettyprint.c (print_string_repr): Remove #if.
1440         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1441
1442 2019-03-05  Tom Tromey  <tromey@adacore.com>
1443
1444         * target.c (the_dummy_target): Move later.  Change type to
1445         "dummy_target".
1446         (initialize_targets): Don't initialize the_dummy_target.
1447
1448 2019-03-05  Tom Tromey  <tromey@adacore.com>
1449
1450         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1451         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1452
1453 2019-03-05  Tom Tromey  <tromey@adacore.com>
1454
1455         * windows-nat.c (windows_nat_target::attach)
1456         (windows_nat_target::detach): Don't call gdb_flush.
1457         * valprint.c (generic_val_print, val_print, val_print_string):
1458         Don't call gdb_flush.
1459         * utils.c (defaulted_query): Don't call gdb_flush.
1460         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1461         * target.c (target_announce_detach): Don't call gdb_flush.
1462         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1463         * remote.c (extended_remote_target::attach): Don't call
1464         gdb_flush.
1465         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1466         * printcmd.c (do_examine): Don't call gdb_flush.
1467         (info_display_command): Don't call gdb_flush.
1468         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1469         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1470         * memattr.c (info_mem_command): Don't call gdb_flush.
1471         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1472         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1473         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1474         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1475         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1476         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1477         (gnu_nat_target::detach): Don't call gdb_flush.
1478         * f-valprint.c (f_val_print): Don't call gdb_flush.
1479         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1480         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1481         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1482         gdb_flush.
1483         * c-valprint.c (c_val_print): Don't call gdb_flush.
1484         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1485
1486 2019-03-05  Tom Tromey  <tromey@adacore.com>
1487
1488         * varobj.c (update_dynamic_varobj_children): Update.
1489         (install_default_visualizer): Use reset, not release.
1490         * value.c (set_internalvar): Update.
1491         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1492         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1493         ATTRIBUTE_UNUSED_RESULT.
1494
1495 2019-03-05  Tom Tromey  <tromey@adacore.com>
1496
1497         * remote.c (class scoped_remote_fd) <release>: Add
1498         ATTRIBUTE_UNUSED_RESULT.
1499
1500 2019-03-05  Tom Tromey  <tromey@adacore.com>
1501
1502         * macroexp.c (struct macro_buffer) <release>: Add
1503         ATTRIBUTE_UNUSED_RESULT.
1504
1505 2019-03-05  Tom Tromey  <tromey@adacore.com>
1506
1507         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1508         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1509         ATTRIBUTE_UNUSED_RESULT.
1510
1511 2019-03-05  Tom Tromey  <tromey@adacore.com>
1512
1513         * common/scoped_fd.h (class scoped_fd) <release>: Add
1514         ATTRIBUTE_UNUSED_RESULT.
1515
1516 2019-03-05  Tom Tromey  <tromey@adacore.com>
1517
1518         * parser-defs.h (struct parser_state) <release>: Add
1519         ATTRIBUTE_UNUSED_RESULT.
1520
1521 2019-03-05  Tom Tromey  <tromey@adacore.com>
1522
1523         * utils.h (class gdb_argv) <release>: Add
1524         ATTRIBUTE_UNUSED_RESULT.
1525         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1526
1527 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1528
1529         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1530         for-loop range, to avoid compiler warnings.
1531
1532         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1533         avoid compiler warnings about unused variables.
1534
1535         * NEWS: Mention end of support for native debugging on MS-Windows
1536         before XP.
1537
1538         PR gdb/24292
1539         * common/netstuff.c:
1540         * gdbserver/gdbreplay.c
1541         * gdbserver/remote-utils.c:
1542         * ser-tcp.c:
1543         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1544         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1545         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1546         'getaddrinfo' and 'freeaddrinfo' were not available before
1547         Windows XP, and mingw.org's MinGW headers by default define
1548         _WIN32_WINNT to 0x500.
1549
1550 2019-03-01  Gary Benson <gbenson@redhat.com>
1551
1552         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1553
1554 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1555             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1556
1557         PR gdb/8527
1558         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1559         set_sigint_trap, clear_sigint_trap.
1560
1561 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1562
1563         * target.c (target_detach): Clear the regcache and the
1564         frame cache.
1565
1566 2019-02-27  Pedro Alves  <palves@redhat.com>
1567
1568         * utils.c (set_screen_size): When we cap the height/width sizes,
1569         tweak the corresponding command variable to show "unlimited":
1570
1571 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1572             Pedro Alves  <palves@redhat.com>
1573
1574         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1575         before calling rl_set_screen_size.
1576
1577 2019-02-27  Tom Tromey  <tromey@adacore.com>
1578
1579         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1580         define.
1581         * python/py-value.c: Remove Python 2.4 workaround.
1582         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1583         workaround.
1584         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1585         Python 2.4 workaround.
1586         * python/python-internal.h: Remove Python 2.4 comment.
1587         (Py_ssize_t): Don't define.
1588         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1589         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1590         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1591         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1592         * python/python.c (do_start_initialization): Remove Python 2.4
1593         workaround.
1594         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1595         (print_children): Remove Python 2.4 workaround.
1596         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1597         workaround.
1598         (CHARBUFFERPROC_NAME): Remove.
1599         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1600         Python 2.4 workaround.
1601
1602 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1603
1604         * NEWS: Note minimum Python version.
1605
1606 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1607
1608         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1609         code from these functions.  Remove corresponding ifdefs.  Use
1610         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1611         Remove gotos and target of gotos.
1612         (infpy_search_memory): Likewise.
1613
1614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1615
1616         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1617         (hppa_gdbarch_init): Don't register deleted functions with
1618         gdbarch.
1619
1620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1621
1622         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1623         (h8300_unwind_sp): Delete.
1624         (h8300_dummy_id): Delete.
1625         (h8300_gdbarch_init): Don't register deleted functions with
1626         gdbarch.
1627
1628 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1629
1630         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1631         (ft32_unwind_pc): Delete.
1632         (ft32_unwind_sp): Delete.
1633         (ft32_gdbarch_init): Don't register deleted functions with
1634         gdbarch.
1635
1636 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1637
1638         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1639         (frv_unwind_pc): Delete.
1640         (frv_unwind_sp): Delete.
1641         (frv_gdbarch_init): Don't register deleted functions with
1642         gdbarch.
1643
1644 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1645
1646         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1647         (riscv_unwind_pc): Delete.
1648         (riscv_unwind_sp): Delete.
1649         (riscv_gdbarch_init): Don't register deleted functions with
1650         gdbarch.
1651
1652 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1655         (csky_unwind_pc): Delete.
1656         (csky_unwind_sp): Delete.
1657         (csky_gdbarch_init): Don't register deleted functions with
1658         gdbarch.
1659
1660 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1661
1662         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1663         (cris_unwind_pc): Delete.
1664         (cris_unwind_sp): Delete.
1665         (cris_gdbarch_init): Don't register deleted functions with
1666         gdbarch.
1667
1668 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1669
1670         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1671         (bfin_unwind_pc): Delete.
1672         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1673
1674 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1675
1676         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1677         (arm_unwind_pc): Delete.
1678         (arm_unwind_sp): Delete.
1679         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1680
1681 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1682
1683         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1684         (arc_unwind_pc): Delete.
1685         (arc_unwind_sp): Delete.
1686         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1687
1688 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1689
1690         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1691         (alpha_unwind_pc): Delete.
1692         (alpha_gdbarch_init): Don't register deleted functions with
1693         gdbarch.
1694
1695 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1696
1697         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1698         (aarch64_unwind_pc): Delete.
1699         (aarch64_unwind_sp): Delete.
1700         (aarch64_gdbarch_init): Don't register deleted functions with
1701         gdbarch.
1702
1703 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1704
1705         * gdbtypes.c (type_align): Don't consider static members when
1706         computing structure alignment.
1707
1708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1709
1710         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1711         return 0 for other types.
1712         * arch-utils.c (default_type_align): Always return 0.
1713         * gdbarch.h: Regenerate.
1714         * gdbarch.sh (type_align): Extend comment.
1715         * gdbtypes.c (type_align): Add additional comments, always call
1716         gdbarch_type_align before applying the default rules.
1717         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1718         generic code will then apply a suitable default.
1719         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1720         types, return 0 for other types.
1721
1722 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1723
1724         * NEWS: Create a new section for the next release branch.
1725         Rename the section of the current branch, now that it has
1726         been cut.
1727
1728 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1729
1730         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1731         * version.in: Bump version to 8.3.50.DATE-git.
1732
1733 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1734
1735         * aix-thread.c (ptid_cmp): Remove unused variable.
1736         (get_signaled_thread): Likewise.
1737         (store_regs_user_thread): Likewise.
1738         (store_regs_kernel_thread): Likewise.
1739         (fetch_regs_kernel_thread): Remove shadowed variable.
1740
1741 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1742
1743         * features/riscv/32bit-cpu.xml: Add register numbers.
1744         * features/riscv/32bit-fpu.c: Regenerate.
1745         * features/riscv/32bit-fpu.xml: Add register numbers.
1746         * features/riscv/64bit-cpu.xml: Add register numbers.
1747         * features/riscv/64bit-fpu.c: Regenerate.
1748         * features/riscv/64bit-fpu.xml: Add register numbers.
1749
1750 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1751
1752         * NEWS: Mention two argument form of gdb.Value constructor.
1753         * python/py-value.c (convert_buffer_and_type_to_value): New
1754         function.
1755         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1756         Add support for handling an optional second argument.  Call
1757         convert_buffer_and_type_to_value as appropriate.
1758         * python/python-internal.h (Py_buffer_deleter): New struct.
1759         (Py_buffer_up): New typedef.
1760
1761 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1762
1763         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1764         instead of releasing ownership.
1765
1766 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1767
1768         * dwarf2read.c (open_and_init_dwp_file): Call
1769         elf_numsections instead of bfd_count_sections to initialize
1770         dwp_file->num_sections.
1771
1772 2019-02-25  Tom Tromey  <tromey@adacore.com>
1773
1774         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1775
1776 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1777
1778         * gcore.in: Add '--readnever' option when invoking GDB.
1779
1780 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1781
1782         * MAINTAINERS: Update my email address.
1783
1784 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1785
1786         * build-id.c (build_id_to_debug_bfd_1): New function.
1787         (build_id_to_debug_bfd): Look for separate debug file in
1788         sysroot.
1789
1790 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1791
1792         * gdbarch.sh: Update the copyright year range that is placed into
1793         generated files.
1794
1795 2019-02-22  Keith Seitz  <keiths@redhat.com>
1796
1797         PR symtab/23853
1798         * linespec.c (create_sals_line_offset): Search for the default
1799         symtab's filename instead of its fullname.
1800
1801 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1802
1803         * NEWS: Update style defaults.
1804
1805 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1806
1807         * main.c (captured_main_1): Disable styling in batch mode.
1808
1809 2019-02-20  Tom Tromey  <tom@tromey.com>
1810
1811         * symtab.c (symtab_symbol_info): Fix typos.
1812
1813 2019-02-20  Tom Tromey  <tromey@adacore.com>
1814
1815         * findcmd.c (_initialize_mem_search): Use upper case for
1816         metasyntactic variables.
1817
1818 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1819
1820         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1821         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1822
1823 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1824
1825         * top.h (source_file_name): Change to std::string.
1826         * top.c (source_file_name): Likewise.
1827         (command_line_input): Adjust.
1828         * cli/cli-script.c (script_from_file): Adjust.
1829
1830 2019-02-19  Tom Tromey  <tromey@adacore.com>
1831
1832         * ravenscar-thread.c
1833         (ravenscar_thread_target::update_thread_list): Don't call
1834         ada_build_task_list.
1835         * ada-lang.h (ada_build_task_list): Don't declare.
1836         * ada-tasks.c (struct ada_tasks_inferior_data)
1837         <task_list_valid_p>: Now bool.
1838         (read_known_tasks, ada_task_list_changed)
1839         (ada_tasks_invalidate_inferior_data): Update.
1840         (read_known_tasks_array): Return bool.
1841         (read_known_tasks_list): Likewise.
1842         (read_known_tasks): Return void.
1843         (ada_build_task_list): Now static.
1844
1845 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1846
1847         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1848         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1849
1850 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1851
1852         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1853         variant for ada_tasks_pspace_data_handle and
1854         ada_tasks_inferior_data_handle.
1855         (ada_tasks_pspace_data_cleanup): New function.
1856         (ada_tasks_inferior_data_cleanup): New function.
1857
1858 2019-02-17  Tom Tromey  <tom@tromey.com>
1859
1860         * macrotab.h (macro_source_fullname): Return a std::string.
1861         * macrotab.c (macro_include, check_for_redefinition)
1862         (macro_undef, macro_lookup_definition, foreach_macro)
1863         (foreach_macro_in_scope): Update.
1864         (macro_source_fullname): Return a std::string.
1865         * macrocmd.c (show_pp_source_pos): Update.
1866
1867 2019-02-17  Tom Tromey  <tom@tromey.com>
1868
1869         * macrocmd.c (show_pp_source_pos): Style the file names.
1870
1871 2019-02-17  Tom Tromey  <tom@tromey.com>
1872
1873         PR tui/24197:
1874         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1875
1876 2019-02-17  Tom Tromey  <tom@tromey.com>
1877
1878         * ada-lang.c (user_select_syms): Use filtered printing.
1879         * utils.c (wrap_style): New global.
1880         (desired_style): Remove.
1881         (emit_style_escape): Add stream parameter.
1882         (set_output_style, reset_terminal_style, prompt_for_continue):
1883         Update.
1884         (flush_wrap_buffer): Only flush gdb_stdout.
1885         (wrap_here): Set wrap_style.
1886         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1887         treat escape sequences as a character.  Change when wrap buffer is
1888         flushed.
1889         (fputs_styled): Do not set the output style when the default is
1890         requested.
1891         * ui-style.h (struct ui_file_style) <is_default>: New method.
1892         * source.c (print_source_lines_base): Emit escape sequences in one
1893         piece.
1894
1895 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1896
1897         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1898         integers and enumeration types.
1899
1900 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1901
1902         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1903         instead of lookup_symbol_in_language
1904         (do_exact_match): New function.
1905         (ada_get_symbol_name_matcher): Return do_exact_match when
1906         doing a verbatim match.
1907
1908 2019-02-15  Tom Tromey  <tromey@adacore.com>
1909
1910         * ravenscar-thread.c (ravenscar_thread_target::resume)
1911         (ravenscar_thread_target::wait): Special case wildcard requests.
1912
1913 2019-02-15  Tom Tromey  <tromey@adacore.com>
1914
1915         * ravenscar-thread.c (base_ptid): Remove.
1916         (struct ravenscar_thread_target) <close>: New method.
1917         <m_base_ptid>: New member.
1918         <update_inferior_ptid, active_task, task_is_currently_active,
1919         runtime_initialized>: Declare methods.
1920         <ravenscar_thread_target>: Add constructor.
1921         (ravenscar_thread_target::task_is_currently_active)
1922         (ravenscar_thread_target::update_inferior_ptid)
1923         (ravenscar_runtime_initialized): Rename.  Now methods.
1924         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1925         (ravenscar_thread_target::update_thread_list): Update.
1926         (ravenscar_thread_target::active_task): Now method.
1927         (ravenscar_thread_target::store_registers)
1928         (ravenscar_thread_target::prepare_to_store)
1929         (ravenscar_thread_target::prepare_to_store)
1930         (ravenscar_thread_target::mourn_inferior): Update.
1931         (ravenscar_inferior_created): Use "new" to create target.
1932         (ravenscar_thread_target::get_ada_task_ptid): Update.
1933         (_initialize_ravenscar): Don't initialize base_ptid.
1934         (ravenscar_ops): Remove global.
1935
1936 2019-02-15  Tom Tromey  <tromey@adacore.com>
1937
1938         * target.h (push_target): Declare new overload.
1939         * target.c (push_target): New overload, taking an rvalue reference.
1940         * remote.c (remote_target::open_1): Use push_target overload.
1941         * corelow.c (core_target_open): Use push_target overload.
1942
1943 2019-02-15  Tom Tromey  <tromey@adacore.com>
1944
1945         * ravenscar-thread.c (is_ravenscar_task)
1946         (ravenscar_task_is_currently_active): Return bool.
1947         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1948         (_initialize_ravenscar): Remove "(void)".
1949         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1950         Return bool.
1951
1952 2019-02-15  Tom Tromey  <tromey@adacore.com>
1953
1954         * ravenscar-thread.c (ravenscar_runtime_initializer)
1955         (has_ravenscar_runtime, get_running_thread_id)
1956         (ravenscar_thread_target::resume): Fix indentation.
1957
1958 2019-02-15  Tom Tromey  <tromey@adacore.com>
1959
1960         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1961         from ravenscar_arch_ops.
1962         (sparc_ravenscar_ops::fetch_registers)
1963         (sparc_ravenscar_ops::store_registers): Now methods.
1964         (sparc_ravenscar_prepare_to_store): Remove.
1965         (sparc_ravenscar_ops): Redefine.
1966         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1967         methods and destructor.  Remove members.
1968         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1969         (ravenscar_thread_target::store_registers)
1970         (ravenscar_thread_target::prepare_to_store): Update.
1971         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1972         Remove.
1973         (struct ppc_ravenscar_powerpc_ops): Derive from
1974         ravenscar_arch_ops.
1975         (ppc_ravenscar_powerpc_ops::fetch_registers)
1976         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1977         (ppc_ravenscar_powerpc_ops): Redefine.
1978         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1979         (ppc_ravenscar_e500_ops::fetch_registers)
1980         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1981         (ppc_ravenscar_e500_ops): Redefine.
1982         * aarch64-ravenscar-thread.c
1983         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1984         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1985         (aarch64_ravenscar_fetch_registers)
1986         (aarch64_ravenscar_store_registers): Now methods.
1987         (aarch64_ravenscar_ops): Redefine.
1988
1989 2019-02-15  Tom Tromey  <tromey@adacore.com>
1990
1991         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1992         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1993         (ravenscar_thread_target::stopped_by_watchpoint)
1994         (ravenscar_thread_target::stopped_data_address)
1995         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1996
1997 2019-02-15  Tom Tromey  <tromey@adacore.com>
1998
1999         * ravenscar-thread.c: Fix some typos.
2000
2001 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2002             Tom Tromey  <tromey@adacore.com>
2003
2004         * ada-lang.c (ada_exception_sal): Change addr_string to a
2005         std::string.
2006         (create_ada_exception_catchpoint): Update.
2007
2008 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2009             Tom Tromey  <tromey@adacore.com>
2010
2011         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2012         (bp_location_ops): Remove.
2013         (base_breakpoint_allocate_location): Update.
2014         (free_bp_location): Update.
2015         * ada-lang.c (class ada_catchpoint_location)
2016         <ada_catchpoint_location>: Remove ops parameter.
2017         (ada_catchpoint_location_dtor): Remove.
2018         (ada_catchpoint_location_ops): Remove.
2019         (allocate_location_exception): Update.
2020         * breakpoint.h (struct bp_location_ops): Remove.
2021         (class bp_location) <bp_location>: Remove bp_location_ops
2022         parameter.
2023         <~bp_location>: Add destructor.
2024         <ops>: Remove.
2025
2026 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2027             Pedro Alves  <palves@redhat.com>
2028
2029         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2030         'PATH_MAX'.
2031
2032 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2033             Samuel Thibault  <samuel.thibault@gnu.org>
2034             Thomas Schwinge  <thomas@codesourcery.com>
2035
2036         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2037         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2038
2039 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2040
2041         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2042         (check_empty): Use "const char *".
2043
2044         * gnu-nat.c (gnu_nat_target::detach): Instead of
2045         'detach_inferior (pid)' call
2046         'detach_inferior (find_inferior_pid (pid))'.
2047
2048         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2049         'nat/fork-inferior.o'.
2050         * gnu-nat.c: #include "nat/fork-inferior.h".
2051
2052         * gnu-nat.c (gnu_nat_target::detach): Instead of
2053         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2054         * gnu-nat.h: #include "inf-child.h".
2055         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2056         'i386_gnu_nat_target::fetch_registers'.
2057         (gnu_store_registers): Rename/move to
2058         'i386_gnu_nat_target::store_registers'.
2059
2060         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2061         * gnu-nat.h (mach_thread_info): New function.
2062         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2063
2064         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2065
2066 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2067
2068         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2069
2070 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2071
2072         * windows-nat.c (windows_add_thread): Add new parameter
2073         "main_thread_p" with default value set to false.  Update
2074         function documentation as well as all callers.
2075         (windows_delete_thread): Likewise.
2076         (fake_create_process): Update call to windows_add_thread.
2077         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2078         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2079         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2080         call to windows_delete_thread.
2081
2082 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2083
2084         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2085
2086 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2087
2088         * symfile.c (find_separate_debug_file): Use canonical path of
2089         sysroot with child_path instead of gdb_sysroot if it is valid.
2090
2091 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2092
2093         * symfile.c (find_separate_debug_file): Use child_path to
2094         determine if an object file is under a sysroot.
2095
2096 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2097
2098         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2099         unittests/child-path-selftests.c.
2100         * common/pathstuff.c (child_path): New function.
2101         * common/pathstuff.h (child_path): New prototype.
2102         * unittests/child-path-selftests.c: New file.
2103
2104 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2105
2106         * symfile.c (find_separate_debug_file): Look for separate debug
2107         files in debug directories under the sysroot.
2108
2109 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2110
2111         * symtab.h (struct minimal_symbol data_p): New const method.
2112         (struct minimal_symbol text_p): Likewise.
2113         * symtab.c (output_source_filename): Use file name style
2114         to print file name.
2115         (print_symbol_info): Likewise.
2116         (print_msymbol_info): Use address style to print addresses.
2117         Use function name style to print executable text symbols.
2118         (expand_symtab_containing_pc): Use data_p.
2119         (find_pc_sect_compunit_symtab): Likewise.
2120
2121 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2122
2123         * breakpoint.c (describe_other_breakpoints): Use address style
2124         to print addresses.
2125         (say_where): Likewise.
2126
2127 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2128
2129         * ada-typeprint.c (print_func_type): Print function name
2130         style to print function name.
2131         * c-typeprint.c (c_print_type_1): Likewise.
2132
2133 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2134
2135         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2136         for execve.
2137
2138 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2139
2140         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2141         type_stack.
2142
2143 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2144
2145         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2146         TYPE_CODE_REF types.
2147
2148 2019-02-08  Jim Wilson  <jimw@sifive.com>
2149
2150         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2151         (riscv_linux_fregset): New.
2152         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2153
2154 2019-02-07  Tom Tromey  <tom@tromey.com>
2155
2156         * thread.c (thread_cancel_execution_command): Update.
2157         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2158         methods.
2159         (struct thread_fsm_ops): Remove.
2160         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2161         (thread_fsm_should_stop, thread_fsm_return_value)
2162         (thread_fsm_set_finished, thread_fsm_finished_p)
2163         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2164         Don't declare.
2165         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2166         * infrun.c (clear_proceed_status_thread)
2167         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2168         (print_stop_event): Update.
2169         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2170         Add constructor.
2171         (step_command_fsm_ops): Remove.
2172         (new_step_command_fsm): Remove.
2173         (step_1): Update.
2174         (step_command_fsm::should_stop): Rename from
2175         step_command_fsm_should_stop.
2176         (step_command_fsm::clean_up): Rename from
2177         step_command_fsm_clean_up.
2178         (step_command_fsm::do_async_reply_reason): Rename from
2179         step_command_fsm_async_reply_reason.
2180         (struct until_next_fsm): Inherit from thread_fsm.  Add
2181         constructor.
2182         (until_next_fsm_ops): Remove.
2183         (new_until_next_fsm): Remove.
2184         (until_next_fsm::should_stop): Rename from
2185         until_next_fsm_should_stop.
2186         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2187         (until_next_fsm::do_async_reply_reason): Rename from
2188         until_next_fsm_async_reply_reason.
2189         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2190         constructor.  Change type of breakpoint.
2191         (finish_command_fsm_ops): Remove.
2192         (new_finish_command_fsm): Remove.
2193         (finish_command_fsm::should_stop): Rename from
2194         finish_command_fsm_should_stop.
2195         (finish_command_fsm::clean_up): Rename from
2196         finish_command_fsm_clean_up.
2197         (finish_command_fsm::return_value): Rename from
2198         finish_command_fsm_return_value.
2199         (finish_command_fsm::do_async_reply_reason): Rename from
2200         finish_command_fsm_async_reply_reason.
2201         (finish_command): Update.
2202         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2203         Add constructor.
2204         (call_thread_fsm_ops): Remove.
2205         (call_thread_fsm::call_thread_fsm): Rename from
2206         new_call_thread_fsm.
2207         (call_thread_fsm::should_stop): Rename from
2208         call_thread_fsm_should_stop.
2209         (call_thread_fsm::should_notify_stop): Rename from
2210         call_thread_fsm_should_notify_stop.
2211         (run_inferior_call, call_function_by_hand_dummy): Update.
2212         * cli/cli-interp.c (should_print_stop_to_console): Update.
2213         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2214         Add constructor.  Change type of location_breakpoint,
2215         caller_breakpoint.
2216         (until_break_fsm_ops): Remove.
2217         (new_until_break_fsm): Remove.
2218         (until_break_fsm::should_stop): Rename from
2219         until_break_fsm_should_stop.
2220         (until_break_fsm::clean_up): Rename from
2221         until_break_fsm_clean_up.
2222         (until_break_fsm::do_async_reply_reason): Rename from
2223         until_break_fsm_async_reply_reason.
2224         (until_break_command): Update.
2225         * thread-fsm.c: Remove.
2226         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2227
2228 2019-02-07  Tom Tromey  <tom@tromey.com>
2229
2230         * yy-remap.h: Add include guard.
2231         * xtensa-tdep.h: Add include guard.
2232         * xcoffread.h: Rename include guard.
2233         * varobj-iter.h: Add include guard.
2234         * tui/tui.h: Rename include guard.
2235         * tui/tui-winsource.h: Rename include guard.
2236         * tui/tui-wingeneral.h: Rename include guard.
2237         * tui/tui-windata.h: Rename include guard.
2238         * tui/tui-win.h: Rename include guard.
2239         * tui/tui-stack.h: Rename include guard.
2240         * tui/tui-source.h: Rename include guard.
2241         * tui/tui-regs.h: Rename include guard.
2242         * tui/tui-out.h: Rename include guard.
2243         * tui/tui-layout.h: Rename include guard.
2244         * tui/tui-io.h: Rename include guard.
2245         * tui/tui-hooks.h: Rename include guard.
2246         * tui/tui-file.h: Rename include guard.
2247         * tui/tui-disasm.h: Rename include guard.
2248         * tui/tui-data.h: Rename include guard.
2249         * tui/tui-command.h: Rename include guard.
2250         * tic6x-tdep.h: Add include guard.
2251         * target/waitstatus.h: Rename include guard.
2252         * target/wait.h: Rename include guard.
2253         * target/target.h: Rename include guard.
2254         * target/resume.h: Rename include guard.
2255         * target-float.h: Rename include guard.
2256         * stabsread.h: Add include guard.
2257         * rs6000-tdep.h: Add include guard.
2258         * riscv-fbsd-tdep.h: Add include guard.
2259         * regformats/regdef.h: Rename include guard.
2260         * record.h: Rename include guard.
2261         * python/python.h: Rename include guard.
2262         * python/python-internal.h: Rename include guard.
2263         * python/py-stopevent.h: Rename include guard.
2264         * python/py-ref.h: Rename include guard.
2265         * python/py-record.h: Rename include guard.
2266         * python/py-record-full.h: Rename include guard.
2267         * python/py-record-btrace.h: Rename include guard.
2268         * python/py-instruction.h: Rename include guard.
2269         * python/py-events.h: Rename include guard.
2270         * python/py-event.h: Rename include guard.
2271         * procfs.h: Add include guard.
2272         * proc-utils.h: Add include guard.
2273         * p-lang.h: Add include guard.
2274         * or1k-tdep.h: Rename include guard.
2275         * observable.h: Rename include guard.
2276         * nto-tdep.h: Rename include guard.
2277         * nat/x86-linux.h: Rename include guard.
2278         * nat/x86-linux-dregs.h: Rename include guard.
2279         * nat/x86-gcc-cpuid.h: Add include guard.
2280         * nat/x86-dregs.h: Rename include guard.
2281         * nat/x86-cpuid.h: Rename include guard.
2282         * nat/ppc-linux.h: Rename include guard.
2283         * nat/mips-linux-watch.h: Rename include guard.
2284         * nat/linux-waitpid.h: Rename include guard.
2285         * nat/linux-ptrace.h: Rename include guard.
2286         * nat/linux-procfs.h: Rename include guard.
2287         * nat/linux-osdata.h: Rename include guard.
2288         * nat/linux-nat.h: Rename include guard.
2289         * nat/linux-namespaces.h: Rename include guard.
2290         * nat/linux-btrace.h: Rename include guard.
2291         * nat/glibc_thread_db.h: Rename include guard.
2292         * nat/gdb_thread_db.h: Rename include guard.
2293         * nat/gdb_ptrace.h: Rename include guard.
2294         * nat/fork-inferior.h: Rename include guard.
2295         * nat/amd64-linux-siginfo.h: Rename include guard.
2296         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2297         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2298         * nat/aarch64-linux.h: Rename include guard.
2299         * nat/aarch64-linux-hw-point.h: Rename include guard.
2300         * mn10300-tdep.h: Add include guard.
2301         * mips-linux-tdep.h: Add include guard.
2302         * mi/mi-parse.h: Rename include guard.
2303         * mi/mi-out.h: Rename include guard.
2304         * mi/mi-main.h: Rename include guard.
2305         * mi/mi-interp.h: Rename include guard.
2306         * mi/mi-getopt.h: Rename include guard.
2307         * mi/mi-console.h: Rename include guard.
2308         * mi/mi-common.h: Rename include guard.
2309         * mi/mi-cmds.h: Rename include guard.
2310         * mi/mi-cmd-break.h: Rename include guard.
2311         * m2-lang.h: Add include guard.
2312         * location.h: Rename include guard.
2313         * linux-record.h: Rename include guard.
2314         * linux-nat.h: Add include guard.
2315         * linux-fork.h: Add include guard.
2316         * i386-darwin-tdep.h: Rename include guard.
2317         * hppa-linux-offsets.h: Add include guard.
2318         * guile/guile.h: Rename include guard.
2319         * guile/guile-internal.h: Rename include guard.
2320         * gnu-nat.h: Rename include guard.
2321         * gdb-stabs.h: Rename include guard.
2322         * frv-tdep.h: Add include guard.
2323         * f-lang.h: Add include guard.
2324         * event-loop.h: Add include guard.
2325         * darwin-nat.h: Rename include guard.
2326         * cp-abi.h: Rename include guard.
2327         * config/sparc/nm-sol2.h: Rename include guard.
2328         * config/nm-nto.h: Rename include guard.
2329         * config/nm-linux.h: Add include guard.
2330         * config/i386/nm-i386gnu.h: Rename include guard.
2331         * config/djgpp/nl_types.h: Rename include guard.
2332         * config/djgpp/langinfo.h: Rename include guard.
2333         * compile/gcc-cp-plugin.h: Add include guard.
2334         * compile/gcc-c-plugin.h: Add include guard.
2335         * compile/compile.h: Rename include guard.
2336         * compile/compile-object-run.h: Rename include guard.
2337         * compile/compile-object-load.h: Rename include guard.
2338         * compile/compile-internal.h: Rename include guard.
2339         * compile/compile-cplus.h: Rename include guard.
2340         * compile/compile-c.h: Rename include guard.
2341         * common/xml-utils.h: Rename include guard.
2342         * common/x86-xstate.h: Rename include guard.
2343         * common/version.h: Rename include guard.
2344         * common/vec.h: Rename include guard.
2345         * common/tdesc.h: Rename include guard.
2346         * common/selftest.h: Rename include guard.
2347         * common/scoped_restore.h: Rename include guard.
2348         * common/scoped_mmap.h: Rename include guard.
2349         * common/scoped_fd.h: Rename include guard.
2350         * common/safe-iterator.h: Rename include guard.
2351         * common/run-time-clock.h: Rename include guard.
2352         * common/refcounted-object.h: Rename include guard.
2353         * common/queue.h: Rename include guard.
2354         * common/ptid.h: Rename include guard.
2355         * common/print-utils.h: Rename include guard.
2356         * common/preprocessor.h: Rename include guard.
2357         * common/pathstuff.h: Rename include guard.
2358         * common/observable.h: Rename include guard.
2359         * common/netstuff.h: Rename include guard.
2360         * common/job-control.h: Rename include guard.
2361         * common/host-defs.h: Rename include guard.
2362         * common/gdb_wait.h: Rename include guard.
2363         * common/gdb_vecs.h: Rename include guard.
2364         * common/gdb_unlinker.h: Rename include guard.
2365         * common/gdb_unique_ptr.h: Rename include guard.
2366         * common/gdb_tilde_expand.h: Rename include guard.
2367         * common/gdb_sys_time.h: Rename include guard.
2368         * common/gdb_string_view.h: Rename include guard.
2369         * common/gdb_splay_tree.h: Rename include guard.
2370         * common/gdb_setjmp.h: Rename include guard.
2371         * common/gdb_ref_ptr.h: Rename include guard.
2372         * common/gdb_optional.h: Rename include guard.
2373         * common/gdb_locale.h: Rename include guard.
2374         * common/gdb_assert.h: Rename include guard.
2375         * common/filtered-iterator.h: Rename include guard.
2376         * common/filestuff.h: Rename include guard.
2377         * common/fileio.h: Rename include guard.
2378         * common/environ.h: Rename include guard.
2379         * common/common-utils.h: Rename include guard.
2380         * common/common-types.h: Rename include guard.
2381         * common/common-regcache.h: Rename include guard.
2382         * common/common-inferior.h: Rename include guard.
2383         * common/common-gdbthread.h: Rename include guard.
2384         * common/common-exceptions.h: Rename include guard.
2385         * common/common-defs.h: Rename include guard.
2386         * common/common-debug.h: Rename include guard.
2387         * common/cleanups.h: Rename include guard.
2388         * common/buffer.h: Rename include guard.
2389         * common/btrace-common.h: Rename include guard.
2390         * common/break-common.h: Rename include guard.
2391         * cli/cli-utils.h: Rename include guard.
2392         * cli/cli-style.h: Rename include guard.
2393         * cli/cli-setshow.h: Rename include guard.
2394         * cli/cli-script.h: Rename include guard.
2395         * cli/cli-interp.h: Rename include guard.
2396         * cli/cli-decode.h: Rename include guard.
2397         * cli/cli-cmds.h: Rename include guard.
2398         * charset-list.h: Add include guard.
2399         * buildsym-legacy.h: Rename include guard.
2400         * bfin-tdep.h: Add include guard.
2401         * ax.h: Rename include guard.
2402         * arm-linux-tdep.h: Add include guard.
2403         * arm-fbsd-tdep.h: Add include guard.
2404         * arch/xtensa.h: Rename include guard.
2405         * arch/tic6x.h: Add include guard.
2406         * arch/i386.h: Add include guard.
2407         * arch/arm.h: Rename include guard.
2408         * arch/arm-linux.h: Rename include guard.
2409         * arch/arm-get-next-pcs.h: Rename include guard.
2410         * arch/amd64.h: Add include guard.
2411         * arch/aarch64-insn.h: Rename include guard.
2412         * arch-utils.h: Rename include guard.
2413         * annotate.h: Add include guard.
2414         * amd64-darwin-tdep.h: Rename include guard.
2415         * aarch64-linux-tdep.h: Add include guard.
2416         * aarch64-fbsd-tdep.h: Add include guard.
2417         * aarch32-linux-nat.h: Add include guard.
2418
2419 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2420
2421         * macrotab.c (macro_define_internal): New function that
2422         factorizes macro_define_object_internal and macro_define_function
2423         code.
2424         (macro_define_object_internal): Use macro_define_internal.
2425         (macro_define_function): Likewise.
2426
2427 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2428
2429         * macrocmd.c (extract_identifier): Return
2430         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2431         callers.
2432
2433 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2434
2435         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2436
2437 2019-02-05  Tom Tromey  <tom@tromey.com>
2438
2439         * target.c (target_stack::unpush): Move assertion earlier.
2440
2441 2019-01-30  Tom Tromey  <tom@tromey.com>
2442
2443         PR python/23615:
2444         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2445         (gdbpy_parse_and_eval): Likewise.
2446         * python/python-internal.h (gdbpy_allow_threads): New class.
2447
2448 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2449
2450         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2451         (aarch64_fbsd_fpregmap): Move earlier.
2452         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2453         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2454         instead of individual calls to trad_frame_set_reg_addr.
2455         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2456         earlier.
2457         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2458         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2459         instead of individual calls to trad_frame_set_reg_addr.
2460
2461 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2462
2463         * CONTRIBUTE: Replace contribution list with wiki link.
2464
2465 2019-01-25  Tom Tromey  <tom@tromey.com>
2466
2467         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2468
2469 2019-01-25  Tom Tromey  <tom@tromey.com>
2470
2471         * xtensa-linux-nat.c: Fix common/ includes.
2472         * xml-support.h: Fix common/ includes.
2473         * xml-support.c: Fix common/ includes.
2474         * x86-linux-nat.c: Fix common/ includes.
2475         * windows-nat.c: Fix common/ includes.
2476         * varobj.h: Fix common/ includes.
2477         * varobj.c: Fix common/ includes.
2478         * value.c: Fix common/ includes.
2479         * valops.c: Fix common/ includes.
2480         * utils.c: Fix common/ includes.
2481         * unittests/xml-utils-selftests.c: Fix common/ includes.
2482         * unittests/utils-selftests.c: Fix common/ includes.
2483         * unittests/unpack-selftests.c: Fix common/ includes.
2484         * unittests/tracepoint-selftests.c: Fix common/ includes.
2485         * unittests/style-selftests.c: Fix common/ includes.
2486         * unittests/string_view-selftests.c: Fix common/ includes.
2487         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2488         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2489         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2490         * unittests/rsp-low-selftests.c: Fix common/ includes.
2491         * unittests/parse-connection-spec-selftests.c: Fix common/
2492         includes.
2493         * unittests/optional-selftests.c: Fix common/ includes.
2494         * unittests/offset-type-selftests.c: Fix common/ includes.
2495         * unittests/observable-selftests.c: Fix common/ includes.
2496         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2497         * unittests/memrange-selftests.c: Fix common/ includes.
2498         * unittests/memory-map-selftests.c: Fix common/ includes.
2499         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2500         * unittests/function-view-selftests.c: Fix common/ includes.
2501         * unittests/environ-selftests.c: Fix common/ includes.
2502         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2503         * unittests/common-utils-selftests.c: Fix common/ includes.
2504         * unittests/cli-utils-selftests.c: Fix common/ includes.
2505         * unittests/array-view-selftests.c: Fix common/ includes.
2506         * ui-file.c: Fix common/ includes.
2507         * tui/tui-io.c: Fix common/ includes.
2508         * tracepoint.h: Fix common/ includes.
2509         * tracepoint.c: Fix common/ includes.
2510         * tracefile-tfile.c: Fix common/ includes.
2511         * top.h: Fix common/ includes.
2512         * top.c: Fix common/ includes.
2513         * thread.c: Fix common/ includes.
2514         * target/waitstatus.h: Fix common/ includes.
2515         * target/waitstatus.c: Fix common/ includes.
2516         * target.h: Fix common/ includes.
2517         * target.c: Fix common/ includes.
2518         * target-memory.c: Fix common/ includes.
2519         * target-descriptions.c: Fix common/ includes.
2520         * symtab.h: Fix common/ includes.
2521         * symfile.c: Fix common/ includes.
2522         * stap-probe.c: Fix common/ includes.
2523         * spu-linux-nat.c: Fix common/ includes.
2524         * sparc-nat.c: Fix common/ includes.
2525         * source.c: Fix common/ includes.
2526         * solib.c: Fix common/ includes.
2527         * solib-target.c: Fix common/ includes.
2528         * ser-unix.c: Fix common/ includes.
2529         * ser-tcp.c: Fix common/ includes.
2530         * ser-pipe.c: Fix common/ includes.
2531         * ser-base.c: Fix common/ includes.
2532         * selftest-arch.c: Fix common/ includes.
2533         * s12z-tdep.c: Fix common/ includes.
2534         * rust-exp.y: Fix common/ includes.
2535         * rs6000-aix-tdep.c: Fix common/ includes.
2536         * riscv-tdep.c: Fix common/ includes.
2537         * remote.c: Fix common/ includes.
2538         * remote-notif.h: Fix common/ includes.
2539         * remote-fileio.h: Fix common/ includes.
2540         * remote-fileio.c: Fix common/ includes.
2541         * regcache.h: Fix common/ includes.
2542         * regcache.c: Fix common/ includes.
2543         * record-btrace.c: Fix common/ includes.
2544         * python/python.c: Fix common/ includes.
2545         * python/py-type.c: Fix common/ includes.
2546         * python/py-inferior.c: Fix common/ includes.
2547         * progspace.h: Fix common/ includes.
2548         * producer.c: Fix common/ includes.
2549         * procfs.c: Fix common/ includes.
2550         * proc-api.c: Fix common/ includes.
2551         * printcmd.c: Fix common/ includes.
2552         * ppc-linux-nat.c: Fix common/ includes.
2553         * parser-defs.h: Fix common/ includes.
2554         * osdata.c: Fix common/ includes.
2555         * obsd-nat.c: Fix common/ includes.
2556         * nat/x86-linux.c: Fix common/ includes.
2557         * nat/x86-linux-dregs.c: Fix common/ includes.
2558         * nat/x86-dregs.h: Fix common/ includes.
2559         * nat/x86-dregs.c: Fix common/ includes.
2560         * nat/ppc-linux.c: Fix common/ includes.
2561         * nat/mips-linux-watch.h: Fix common/ includes.
2562         * nat/mips-linux-watch.c: Fix common/ includes.
2563         * nat/linux-waitpid.c: Fix common/ includes.
2564         * nat/linux-ptrace.h: Fix common/ includes.
2565         * nat/linux-ptrace.c: Fix common/ includes.
2566         * nat/linux-procfs.c: Fix common/ includes.
2567         * nat/linux-personality.c: Fix common/ includes.
2568         * nat/linux-osdata.c: Fix common/ includes.
2569         * nat/linux-namespaces.c: Fix common/ includes.
2570         * nat/linux-btrace.h: Fix common/ includes.
2571         * nat/linux-btrace.c: Fix common/ includes.
2572         * nat/fork-inferior.c: Fix common/ includes.
2573         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2574         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2575         * nat/aarch64-linux.c: Fix common/ includes.
2576         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2577         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2578         * namespace.h: Fix common/ includes.
2579         * mips-linux-tdep.c: Fix common/ includes.
2580         * minsyms.c: Fix common/ includes.
2581         * mi/mi-parse.h: Fix common/ includes.
2582         * mi/mi-main.c: Fix common/ includes.
2583         * mi/mi-cmd-env.c: Fix common/ includes.
2584         * memrange.h: Fix common/ includes.
2585         * memattr.c: Fix common/ includes.
2586         * maint.h: Fix common/ includes.
2587         * maint.c: Fix common/ includes.
2588         * main.c: Fix common/ includes.
2589         * machoread.c: Fix common/ includes.
2590         * location.c: Fix common/ includes.
2591         * linux-thread-db.c: Fix common/ includes.
2592         * linux-nat.c: Fix common/ includes.
2593         * linux-fork.c: Fix common/ includes.
2594         * inline-frame.c: Fix common/ includes.
2595         * infrun.c: Fix common/ includes.
2596         * inflow.c: Fix common/ includes.
2597         * inferior.h: Fix common/ includes.
2598         * inferior.c: Fix common/ includes.
2599         * infcmd.c: Fix common/ includes.
2600         * inf-ptrace.c: Fix common/ includes.
2601         * inf-child.c: Fix common/ includes.
2602         * ia64-linux-nat.c: Fix common/ includes.
2603         * i387-tdep.c: Fix common/ includes.
2604         * i386-tdep.c: Fix common/ includes.
2605         * i386-linux-tdep.c: Fix common/ includes.
2606         * i386-linux-nat.c: Fix common/ includes.
2607         * i386-go32-tdep.c: Fix common/ includes.
2608         * i386-fbsd-tdep.c: Fix common/ includes.
2609         * i386-fbsd-nat.c: Fix common/ includes.
2610         * guile/scm-type.c: Fix common/ includes.
2611         * guile/guile.c: Fix common/ includes.
2612         * go32-nat.c: Fix common/ includes.
2613         * gnu-nat.c: Fix common/ includes.
2614         * gdbthread.h: Fix common/ includes.
2615         * gdbarch-selftests.c: Fix common/ includes.
2616         * gdb_usleep.c: Fix common/ includes.
2617         * gdb_select.h: Fix common/ includes.
2618         * gdb_bfd.c: Fix common/ includes.
2619         * gcore.c: Fix common/ includes.
2620         * fork-child.c: Fix common/ includes.
2621         * findvar.c: Fix common/ includes.
2622         * fbsd-nat.c: Fix common/ includes.
2623         * event-top.c: Fix common/ includes.
2624         * event-loop.c: Fix common/ includes.
2625         * dwarf2read.c: Fix common/ includes.
2626         * dwarf2loc.c: Fix common/ includes.
2627         * dwarf2-frame.c: Fix common/ includes.
2628         * dwarf-index-cache.c: Fix common/ includes.
2629         * dtrace-probe.c: Fix common/ includes.
2630         * disasm-selftests.c: Fix common/ includes.
2631         * defs.h: Fix common/ includes.
2632         * csky-tdep.c: Fix common/ includes.
2633         * cp-valprint.c: Fix common/ includes.
2634         * cp-support.h: Fix common/ includes.
2635         * cp-support.c: Fix common/ includes.
2636         * corelow.c: Fix common/ includes.
2637         * completer.h: Fix common/ includes.
2638         * completer.c: Fix common/ includes.
2639         * compile/compile.c: Fix common/ includes.
2640         * compile/compile-loc2c.c: Fix common/ includes.
2641         * compile/compile-cplus-types.c: Fix common/ includes.
2642         * compile/compile-cplus-symbols.c: Fix common/ includes.
2643         * command.h: Fix common/ includes.
2644         * cli/cli-dump.c: Fix common/ includes.
2645         * cli/cli-cmds.c: Fix common/ includes.
2646         * charset.c: Fix common/ includes.
2647         * build-id.c: Fix common/ includes.
2648         * btrace.h: Fix common/ includes.
2649         * btrace.c: Fix common/ includes.
2650         * breakpoint.h: Fix common/ includes.
2651         * breakpoint.c: Fix common/ includes.
2652         * ax.h:
2653         (enum agent_op): Fix common/ includes.
2654         * ax-general.c (struct aop_map): Fix common/ includes.
2655         * ax-gdb.c: Fix common/ includes.
2656         * auxv.c: Fix common/ includes.
2657         * auto-load.c: Fix common/ includes.
2658         * arm-tdep.c: Fix common/ includes.
2659         * arch/riscv.c: Fix common/ includes.
2660         * arch/ppc-linux-common.c: Fix common/ includes.
2661         * arch/i386.c: Fix common/ includes.
2662         * arch/arm.c: Fix common/ includes.
2663         * arch/arm-linux.c: Fix common/ includes.
2664         * arch/arm-get-next-pcs.c: Fix common/ includes.
2665         * arch/amd64.c: Fix common/ includes.
2666         * arch/aarch64.c: Fix common/ includes.
2667         * arch/aarch64-insn.c: Fix common/ includes.
2668         * arch-utils.c: Fix common/ includes.
2669         * amd64-windows-tdep.c: Fix common/ includes.
2670         * amd64-tdep.c: Fix common/ includes.
2671         * amd64-sol2-tdep.c: Fix common/ includes.
2672         * amd64-obsd-tdep.c: Fix common/ includes.
2673         * amd64-nbsd-tdep.c: Fix common/ includes.
2674         * amd64-linux-tdep.c: Fix common/ includes.
2675         * amd64-linux-nat.c: Fix common/ includes.
2676         * amd64-fbsd-tdep.c: Fix common/ includes.
2677         * amd64-fbsd-nat.c: Fix common/ includes.
2678         * amd64-dicos-tdep.c: Fix common/ includes.
2679         * amd64-darwin-tdep.c: Fix common/ includes.
2680         * agent.c: Fix common/ includes.
2681         * ada-lang.h: Fix common/ includes.
2682         * ada-lang.c: Fix common/ includes.
2683         * aarch64-tdep.c: Fix common/ includes.
2684
2685 2019-01-25  Tom Tromey  <tom@tromey.com>
2686
2687         * common/create-version.sh: Use common/version.h.
2688
2689 2019-01-24  Pedro Alves  <palves@redhat.com>
2690
2691         * infrun.c (signal_stop, signal_print, signal_program)
2692         (signal_catch, signal_pass): Now arrays instead of pointers.
2693         (update_signals_program_target, do_target_resume)
2694         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2695         * linux-nat.c (linux_nat_target::pass_signals)
2696         (linux_nat_target::create_inferior, linux_nat_target::attach):
2697         Adjust.
2698         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2699         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2700         * procfs.c (procfs_target::pass_signals): Adjust.
2701         * record-full.c (record_full_target::resume): Adjust.
2702         * remote.c (remote_target::pass_signals)
2703         (remote_target::program_signals): Adjust.
2704         * target-debug.h (target_debug_print_signals): Now takes a
2705         gdb::array_view as parameter.  Adjust.
2706         * target.h (target_ops) <pass_signals, program_signals>: Replace
2707         pointer and length parameters with gdb::array_view.
2708         (target_pass_signals, target_program_signals): Likewise.
2709         * target-delegates.c: Regenerate.
2710
2711 2019-01-24  Pedro Alves  <palves@redhat.com>
2712
2713         * common/forward-scope-exit.h
2714         (forward_scope_exit::forward_scope_exit): Pass arguments to
2715         m_bind_function directly, instead of creating a std::bind and
2716         copying that.
2717
2718 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2719
2720         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2721         for static members.
2722         (pass_in_v_vfp_candidate): Likewise.
2723
2724 2019-01-23  Tom Tromey  <tom@tromey.com>
2725             Pedro Alves  <palves@redhat.com>
2726
2727         * regcache.c (class regcache_invalidator): Remove.
2728         (regcache::raw_write): Use make_scope_exit.
2729
2730 2019-01-23  Tom Tromey  <tom@tromey.com>
2731
2732         * ui-out.h (class ui_out_emit_type): Update comment.
2733
2734 2019-01-23  Tom Tromey  <tom@tromey.com>
2735
2736         * infrun.c (fetch_inferior_event): Update comment.
2737
2738 2019-01-23  Tom Tromey  <tom@tromey.com>
2739             Pedro Alves  <palves@redhat.com>
2740
2741         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2742         parameter.
2743         (fetch_inferior_event): Use SCOPE_EXIT.
2744
2745
2746 2019-01-23  Tom Tromey  <tom@tromey.com>
2747             Pedro Alves  <palves@redhat.com>
2748
2749         * infrun.c (disable_thread_events): Delete.
2750         (stop_all_threads): Use SCOPE_EXIT.
2751
2752 2019-01-23  Tom Tromey  <tom@tromey.com>
2753             Pedro Alves  <palves@redhat.com>
2754
2755         * symfile.c: Include forward-scope-exit.h.
2756         (clear_symtab_users_cleanup): Replace forward declaration with
2757         a FORWARD_SCOPE_EXIT.
2758         (syms_from_objfile_1): Use the forward_scope_exit and
2759         gdb::optional instead of cleanup_function.
2760         (reread_symbols): Use the forward_scope_exit instead of
2761         cleanup_function.
2762         (clear_symtab_users_cleanup): Remove function.
2763
2764 2019-01-23  Tom Tromey  <tom@tromey.com>
2765             Pedro Alves  <palves@redhat.com>
2766
2767         * linux-nat.c: Include scope-exit.h.
2768         (cleanup_target_stop): Remove.
2769         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2770         SCOPE_EXIT.
2771
2772 2019-01-23  Tom Tromey  <tom@tromey.com>
2773             Pedro Alves  <palves@redhat.com>
2774
2775         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2776         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2777
2778 2019-01-23  Tom Tromey  <tom@tromey.com>
2779             Andrew Burgess  <andrew.burgess@embecosm.com>
2780             Pedro Alves  <palves@redhat.com>
2781
2782         * infrun.c (fetch_inferior_event): Use scope_exit.
2783         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2784         * top.c (execute_command): Use scope_exit.
2785         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2786         * utils.c (do_bpstat_clear_actions_cleanup)
2787         (make_bpstat_clear_actions_cleanup): Remove.
2788
2789 2019-01-23  Tom Tromey  <tom@tromey.com>
2790             Pedro Alves  <palves@redhat.com>
2791
2792         * infrun.c: Include "common/scope-exit.h"
2793         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2794         (wait_for_inferior): Use SCOPE_EXIT.
2795         (fetch_inferior_event): Use scope_exit.
2796
2797 2019-01-23  Tom Tromey  <tom@tromey.com>
2798             Pedro Alves  <palves@redhat.com>
2799
2800         * breakpoint.c (create_breakpoint): Remove cleanup.
2801
2802 2019-01-23  Tom Tromey  <tom@tromey.com>
2803             Andrew Burgess  <andrew.burgess@embecosm.com>
2804             Pedro Alves  <palves@redhat.com>
2805
2806 2019-01-23  Pedro Alves  <palves@redhat.com>
2807
2808         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2809
2810 2019-01-23  Pedro Alves  <palves@redhat.com>
2811             Andrew Burgess  <andrew.burgess@embecosm.com>
2812
2813         * gdbthread.h: Include "common/forward-scope-exit.h".
2814         (scoped_finish_thread_state): Redefine custom class in terms of
2815         forward_scope_exit.
2816
2817 2019-01-23  Pedro Alves  <palves@redhat.com>
2818             Andrew Burgess  <andrew.burgess@embecosm.com>
2819
2820         * common/forward-scope-exit.h: New file.
2821
2822 2019-01-23  Pedro Alves  <palves@redhat.com>
2823             Andrew Burgess  <andrew.burgess@embecosm.com>
2824             Tom Tromey  <tom@tromey.com>
2825
2826         * common/scope-exit.h: New file.
2827
2828 2019-01-23  Pedro Alves  <palves@redhat.com>
2829
2830         * common/preprocessor.h (ESC): Rename to ...
2831         (ESC_PARENS): ... this.
2832         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2833         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2834
2835 2019-01-23  Tom Tromey  <tom@tromey.com>
2836
2837         * language.h (class scoped_switch_to_sym_language_if_auto):
2838         Initialize m_lang in both cases.
2839
2840 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2841
2842         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2843         with XCNEW.
2844
2845 2019-01-22  Tom Tromey  <tom@tromey.com>
2846
2847         * corelow.c: Do not include sys/file.h.
2848
2849 2019-01-22  Tom Tromey  <tom@tromey.com>
2850
2851         * tui/tui-wingeneral.h: Include gdb_curses.h.
2852
2853 2019-01-22  Tom Tromey  <tom@tromey.com>
2854
2855         * source-cache.h (class source_cache) <get_source_lines,
2856         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2857
2858 2019-01-22  Tom Tromey  <tom@tromey.com>
2859
2860         * remote-fileio.h (struct remote_target): Declare.
2861
2862 2019-01-22  Tom Tromey  <tom@tromey.com>
2863
2864         * python/py-arch.c: Do not include py-ref.h.
2865         * python/py-bpevent.c: Do not include py-ref.h.
2866         * python/py-cmd.c: Do not include py-ref.h.
2867         * python/py-continueevent.c: Do not include py-ref.h.
2868         * python/py-event.h: Do not include py-ref.h.
2869         * python/py-evtregistry.c: Do not include py-ref.h.
2870         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2871         * python/py-frame.c: Do not include py-ref.h.
2872         * python/py-framefilter.c: Do not include py-ref.h.
2873         * python/py-function.c: Do not include py-ref.h.
2874         * python/py-infevents.c: Do not include py-ref.h.
2875         * python/py-linetable.c: Do not include py-ref.h.
2876         * python/py-objfile.c: Do not include py-ref.h.
2877         * python/py-param.c: Do not include py-ref.h.
2878         * python/py-prettyprint.c: Do not include py-ref.h.
2879         * python/py-progspace.c: Do not include py-ref.h.
2880         * python/py-symbol.c: Do not include py-ref.h.
2881         * python/py-symtab.c: Do not include py-ref.h.
2882         * python/py-type.c: Do not include py-ref.h.
2883         * python/py-unwind.c: Do not include py-ref.h.
2884         * python/py-utils.c: Do not include py-ref.h.
2885         * python/py-value.c: Do not include py-ref.h.
2886         * python/py-varobj.c: Do not include py-ref.h.
2887         * python/py-xmethods.c: Do not include py-ref.h.
2888         * python/python.c: Do not include py-ref.h.
2889         * varobj.c: Do not include py-ref.h.
2890
2891 2019-01-22  Tom Tromey  <tom@tromey.com>
2892
2893         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2894         keyword for bcache.
2895
2896 2019-01-22  Tom Tromey  <tom@tromey.com>
2897
2898         * compile/compile-cplus-types.c: Remove a comment by #include.
2899
2900 2019-01-22  Tom Tromey  <tom@tromey.com>
2901
2902         * compile/gcc-c-plugin.h: Include compile-internal.h.
2903
2904 2019-01-22  Tom Tromey  <tom@tromey.com>
2905
2906         * stabsread.c (EXTERN): Do not define.
2907         (symnum, next_symbol_text_func, processing_gcc_compilation)
2908         (within_function, global_sym_chain, global_stabs)
2909         (previous_stab_code, this_object_header_files)
2910         (n_this_object_header_files)
2911         (n_allocated_this_object_header_files): Define.
2912         * stabsread.h (EXTERN): Never define.  Use "extern".
2913
2914 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2915
2916         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2917         history_value.
2918
2919 2019-01-21  Tom Tromey  <tom@tromey.com>
2920
2921         * ui-out.c: Fix includes.
2922         * tui/tui-source.c: Fix includes.
2923         * target.c: Fix includes.
2924         * remote.c: Fix includes.
2925         * regcache.c: Fix includes.
2926         * python/py-block.c: Fix includes.
2927         * printcmd.c: Fix includes.
2928         * or1k-tdep.c: Fix includes.
2929         * mi/mi-main.c: Fix includes.
2930         * m32r-tdep.c: Fix includes.
2931         * csky-tdep.c: Fix includes.
2932         * compile/compile-cplus-types.c: Fix includes.
2933         * cli/cli-interp.c: Fix includes.
2934
2935 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2936
2937         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2938         for padding.
2939
2940 2019-01-16  Tom Tromey  <tom@tromey.com>
2941
2942         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2943         earlier.
2944         (struct objfile) <msymbols_range>: Move from top level.
2945         <msymbols>: New method.
2946         (class objfile_msymbols): Remove.
2947         * symtab.c (default_collect_symbol_completion_matches_break_on):
2948         Update.
2949         * symmisc.c (dump_msymbols): Update.
2950         * stabsread.c (scan_file_globals): Update.
2951         * objc-lang.c (info_selectors_command, info_classes_command)
2952         (find_methods): Update.
2953         * minsyms.c (find_solib_trampoline_target): Update.
2954         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2955         * coffread.c (coff_symfile_read): Update.
2956         * ada-lang.c (ada_lookup_simple_minsym)
2957         (ada_collect_symbol_completion_matches): Update.
2958
2959 2019-01-16  Tom Tromey  <tom@tromey.com>
2960
2961         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2962         type.  Remove no-argument constructor.
2963         <iterator::operator++>: Simplify.
2964         <begin>: Update.
2965         <end>: Use minimal_symbol_count.
2966
2967 2019-01-16  Tom Tromey  <tom@tromey.com>
2968
2969         * objfiles.h (struct objfile) <psymtabs>: New method.
2970         (class objfile_psymtabs): Remove.
2971         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2972         typedef.
2973         <range>: New method.
2974         (require_partial_symbols): Change return type.
2975         * psymtab.c (require_partial_symbols)
2976         (psym_expand_symtabs_matching): Update.
2977         * mdebugread.c (parse_partial_symbols): Update.
2978         * dbxread.c (dbx_end_psymtab): Update.
2979
2980 2019-01-15  Tom Tromey  <tom@tromey.com>
2981
2982         * symtab.c (lookup_objfile_from_block)
2983         (lookup_symbol_in_objfile_symtabs)
2984         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2985         (find_line_symtab, info_sources_command)
2986         (default_collect_symbol_completion_matches_break_on)
2987         (make_source_files_completion_list): Update.
2988         * symmisc.c (print_objfile_statistics, dump_objfile)
2989         (maintenance_print_symbols, maintenance_info_symtabs)
2990         (maintenance_check_symtabs, maintenance_info_line_tables):
2991         Update.
2992         * source.c (select_source_symtab)
2993         (forget_cached_source_info_for_objfile): Update.
2994         * objfiles.h (class objfile_compunits): Remove.
2995         (struct objfile) <compunits_range>: New typedef.
2996         (compunits): New method.
2997         * objfiles.c (objfile_relocate1): Update.
2998         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2999         * maint.c (count_symtabs_and_blocks): Update.
3000         * linespec.c (iterate_over_all_matching_symtabs): Update.
3001         * cp-support.c (add_symbol_overload_list_qualified): Update.
3002         * coffread.c (coff_symtab_read): Update.
3003         * ada-lang.c (add_nonlocal_symbols)
3004         (ada_collect_symbol_completion_matches)
3005         (ada_add_global_exceptions): Update.
3006
3007 2019-01-15  Tom Tromey  <tom@tromey.com>
3008
3009         * progspace.h (program_space) <objfiles_safe_range>: New
3010         typedef.
3011         <objfiles_safe>: New method.
3012         * objfiles.h (class all_objfiles_safe): Remove.
3013         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3014         * jit.c (jit_inferior_exit_hook): Update.
3015
3016 2019-01-17  Tom Tromey  <tom@tromey.com>
3017
3018         * progspace.h (program_space) <objfiles_range>: New typedef.
3019         <objfiles>: New method.
3020         <objfiles_head>: Rename from objfiles.
3021         (object_files): Update.
3022         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3023         * guile/scm-pretty-print.c
3024         (ppscm_find_pretty_printer_from_objfiles): Update.
3025         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3026         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3027         Update.
3028         * python/py-progspace.c (pspy_get_objfiles): Update.
3029         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3030         Update.
3031         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3032         (objfpy_lookup_objfile_by_build_id): Update.
3033         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3034         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3035         Update.
3036         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3037         (expand_symtab_containing_pc, lookup_objfile_from_block)
3038         (lookup_static_symbol, basic_lookup_transparent_type)
3039         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3040         (find_line_symtab, info_sources_command)
3041         (default_collect_symbol_completion_matches_break_on)
3042         (make_source_files_completion_list, find_main_name): Update.
3043         * symmisc.c (print_symbol_bcache_statistics)
3044         (print_objfile_statistics, maintenance_print_symbols)
3045         (maintenance_print_msymbols, maintenance_print_objfiles)
3046         (maintenance_info_symtabs, maintenance_check_symtabs)
3047         (maintenance_expand_symtabs, maintenance_info_line_tables):
3048         Update.
3049         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3050         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3051         (map_overlay_command, unmap_overlay_command)
3052         (simple_overlay_update, expand_symtabs_matching)
3053         (map_symbol_filenames): Update.
3054         * symfile-debug.c (set_debug_symfile): Update.
3055         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3056         Update.
3057         * source.c (select_source_symtab, forget_cached_source_info):
3058         Update.
3059         * solib.c (solib_read_symbols): Update.
3060         * solib-spu.c (append_ocl_sos): Update.
3061         * psymtab.c (maintenance_print_psymbols)
3062         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3063         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3064         * printcmd.c (info_symbol_command): Update.
3065         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3066         Update.
3067         * objfiles.h (class all_objfiles): Remove.
3068         * objfiles.c (have_partial_symbols, have_full_symbols)
3069         (have_minimal_symbols, qsort_cmp, update_section_map)
3070         (shared_objfile_contains_address_p)
3071         (default_iterate_over_objfiles_in_search_order): Update.
3072         * objc-lang.c (info_selectors_command, info_classes_command)
3073         (find_methods): Update.
3074         * minsyms.c (find_solib_trampoline_target): Update.
3075         * maint.c (maintenance_info_sections)
3076         (maintenance_translate_address, count_symtabs_and_blocks):
3077         Update.
3078         * main.c (captured_main_1): Update.
3079         * linux-thread-db.c (try_thread_db_load_from_pdir)
3080         (has_libpthread): Update.
3081         * linespec.c (iterate_over_all_matching_symtabs)
3082         (search_minsyms_for_name): Update.
3083         * jit.c (jit_find_objf_with_entry_addr): Update.
3084         * hppa-tdep.c (find_unwind_entry)
3085         (hppa_lookup_stub_minimal_symbol): Update.
3086         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3087         Update.
3088         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3089         (elf_gnu_ifunc_resolve_by_got): Update.
3090         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3091         * dwarf-index-write.c (save_gdb_index_command): Update.
3092         * cp-support.c (add_symbol_overload_list_qualified): Update.
3093         * breakpoint.c (create_overlay_event_breakpoint)
3094         (create_longjmp_master_breakpoint)
3095         (create_std_terminate_master_breakpoint)
3096         (create_exception_master_breakpoint): Update.
3097         * blockframe.c (find_pc_partial_function): Update.
3098         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3099         (ada_collect_symbol_completion_matches)
3100         (ada_add_global_exceptions): Update.
3101
3102 2019-01-17  Tom Tromey  <tom@tromey.com>
3103
3104         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3105         declare VEC.
3106         (solib_target_parse_libraries): Change return type.
3107         (library_list_start_segment, library_list_start_section)
3108         (library_list_end_library, library_list_start_library); Update.
3109         (solib_target_free_library_list): Remove.
3110         (solib_target_parse_libraries): Remove cleanup.  Change return
3111         type.
3112         (solib_target_current_sos): Update.
3113
3114 2019-01-17  Tom Tromey  <tromey@bapiya>
3115
3116         * valprint.c: Replace "the the" with "the".
3117         * symtab.c: Replace "the the" with "the".
3118         * solib.c: Replace "the the" with "the".
3119         * solib-dsbt.c: Replace "the the" with "the".
3120         * linespec.c: Replace "the the" with "the".
3121         * dwarf2loc.h: Replace "the the" with "the".
3122         * amd64-windows-tdep.c: Replace "the the" with "the".
3123         * aarch64-tdep.c: Replace "the the" with "the".
3124
3125 2019-01-16  Keith Seitz  <keiths@redhat.com>
3126
3127         PR gdb/23773
3128         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3129         <builder>: Rename to ..
3130         <m_builder>: ... this and make private.
3131         (dwarf2_cu::get_builder): New method.  Change all users of
3132         `builder' to use this method.
3133         (dwarf2_start_symtab): Move to ...
3134         (dwarf2_cu::start_symtab): ... here.  Update all callers
3135         (setup_type_unit_groups): Move to ...
3136         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3137         callers.
3138         (dwarf2_cu::reset_builder): New method.
3139         (process_full_compunit, process_full_type_unit): Use
3140         dwarf2_cu::reset_builder.
3141         (follow_die_offset): Record the ancestor CU if it is different
3142         from the followed DIE's CU.
3143         (follow_die_sig_1): Likewise.
3144
3145 2019-01-15  Tom Tromey  <tom@tromey.com>
3146
3147         * remote.c (class remote_state) <buf>: Now a char_vector.
3148         <buf_size>: Remove.
3149         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3150         parameter.
3151         (remote_target::getpkt_or_notif_sane_1)
3152         (remote_target::getpkt_sane)
3153         (remote_target::getpkt_or_notif_sane): Likewise.
3154         (class remote_target) <putpkt>: New overload.
3155         (remote_target::read_frame): Change type of "buf_p".  Remove
3156         sizeof_p parameter.
3157         (packet_ok): New overload.
3158         (packet_check_result): New overload.
3159         Update all uses.
3160
3161 2019-01-14  Tom Tromey  <tom@tromey.com>
3162
3163         * remote-notif.c (handle_notification, remote_notif_ack)
3164         (remote_notif_parse): Make "buf" const.
3165         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3166         const.
3167         (remote_notif_parse, remote_notif_ack, handle_notification):
3168         Likewise.
3169         * remote.c (remote_notif_stop_parse): Make "buf" const.
3170         (remote_target::remote_parse_stop_reply): Make "buf" const.
3171         (remote_notif_stop_ack): Make "buf" const.
3172
3173 2019-01-14  Tom Tromey  <tom@tromey.com>
3174
3175         * remote.c (remote_console_output): Make parameter const.
3176
3177 2019-01-14  Tom Tromey  <tom@tromey.com>
3178
3179         * target-debug.h (target_debug_print_signals): Constify.
3180         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3181         * procfs.c (procfs_target::pass_signals): Update.
3182         * linux-nat.c (linux_nat_target::pass_signals): Update.
3183         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3184         * target-delegates.c: Rebuild.
3185         * remote.c (remote_target::program_signals): Update.
3186         (remote_target::pass_signals): Update.
3187         * target.c (target_pass_signals): Constify argument.
3188         (target_program_signals): Likewise.
3189         * target.h (struct target_ops) <pass_signals, program_signals>:
3190         Constify argument.
3191         (target_pass_signals, target_program_signals): Constify argument.
3192
3193 2019-01-14  Tom Tromey  <tom@tromey.com>
3194
3195         PR tui/28819:
3196         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3197
3198 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3199
3200         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3201         field.
3202         * rs6000-tdep.c: Include reggroups.h.
3203         (IS_V_ALIAS_PSEUDOREG): Define.
3204         (rs6000_register_name): Return names for the "vX" aliases.
3205         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3206         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3207         aliases.  Call default_register_reggroup_p for all other
3208         pseudo-registers.
3209         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3210         New functions.
3211         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3212         Handle "vX" aliases.
3213         (v_alias_pseudo_register_collect): New function.
3214         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3215         (rs6000_gdbarch_init): Initialize "vX" aliases as
3216         pseudo-registers.  Restore registration of
3217         rs6000_pseudo_register_reggroup_p with
3218         set_tdesc_pseudo_register_reggroup_p.
3219
3220 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3221
3222         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3223         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3224         set_gdbarch_num_pseudo_regs.
3225
3226 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3227
3228         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3229         Remove arg prefixname, add do_set and do_show.
3230         Add member functions set_list and show_list.
3231         * cli/cli-style.c (class cli_style_option): Update accordingly.
3232         (style_set_list): Move to file scope.
3233         (style_show_list): Likewise.
3234         (set_style): Call help_list.
3235         (show_style): Call cmd_show_list.
3236         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3237         Update to use the new macro.
3238
3239 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3240
3241         * ada-lang.c (_initialize_ada_language): Expand the help text
3242         for the "catch exception" command.
3243
3244 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3245
3246         * symtab.c (matching_obj_sections): Initialize obj,
3247         declare it closer to its usage.
3248
3249 2019-01-10  Tom Tromey  <tom@tromey.com>
3250
3251         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3252         (basic_inf_threads_range): Remove.
3253         (inf_threads_range, inf_non_exited_threads_range)
3254         (safe_inf_threads_range): Use next_adapter.
3255
3256 2019-01-10  Keith Seitz  <keiths@redhat.com>
3257
3258         PR gdb/23712
3259         PR symtab/23010
3260         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3261         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3262
3263 2019-01-10  Keith Seitz  <keiths@redhat.com>
3264
3265         PR gdb/23712
3266         PR symtab/23010
3267         * dictionary.c (pending_to_vector): Remove.
3268         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3269         Remove _1 suffix, replacing functions of the same name.  Update
3270         all callers.
3271         (dict_create_hashed, dict_create_hashed_expandable)
3272         (dict_create_linear, dict_create_linear_expandable, dict_free)
3273         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3274         Make functions static.
3275
3276 2019-01-10  Keith Seitz  <keiths@redhat.com>
3277
3278         PR gdb/23712
3279         PR symtab/23010
3280         * dictionary.h (struct dictionary): Replace declaration with
3281         multidictionary.
3282         (dict_create_hashed, dict_create_hashed_expandable)
3283         (dict_create_linear, dict_create_linear_expandable)
3284         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3285         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3286         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3287         taking multidictionary argument.
3288         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3289         * block.h (struct block) <dict>: Change to multidictionary
3290         and rename `multidict'.
3291         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3292         symmisc.c: Update all dictionary references to multidictionary.
3293
3294 2019-01-10  Keith Seitz  <keiths@redhat.com>
3295
3296         PR gdb/23712
3297         PR symtab/23010
3298         * dictionary.c: Include unordered_map.
3299         (pending_to_vector): New function.
3300         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3301         Rewrite the non-"_1" functions to take vector instead
3302         of linked list.
3303         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3304         "new" _1 versions of the same name.
3305         (multidictionary): Define.
3306         (std::hash<enum language): New definition.
3307         (collate_pending_symbols_by_language, mdict_create_hashed)
3308         (mdict_create_hashed_expandable, mdict_create_linear)
3309         (mdict_create_linear_expandable, mdict_free)
3310         (find_language_dictionary, create_new_language_dictionary)
3311         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3312         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3313         (mdict_size, mdict_empty): New functions.
3314         * dictionary.h (mdict_iterator): Define.
3315
3316 2019-01-10  Pedro Alves  <palves@redhat.com>
3317
3318         * breakpoint.c (read_uploaded_action)
3319         (create_tracepoint_from_upload): Adjust to use
3320         gdb::unique_xmalloc_ptr.
3321         * ctf.c (ctf_write_uploaded_tp):
3322         (SET_ARRAY_FIELD): Use emplace_back.
3323         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3324         * tracefile-tfile.c (tfile_write_uploaded_tp):
3325         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3326         gdb::unique_xmalloc_ptr.
3327         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3328         at_string, cond_string, cmd_strings>: Replace char pointers
3329         with gdb::unique_xmalloc_ptr.
3330
3331 2019-01-10  Pedro Alves  <palves@redhat.com>
3332
3333         * solib-target.c (library_list_start_library): Don't xstrdup name.
3334
3335 2019-01-10  Pedro Alves  <palves@redhat.com>
3336
3337         * mdebugread.c (parse_partial_symbols): Use
3338         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3339
3340 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3341
3342         * linux-fork.c (scoped_switch_fork_info)
3343         <~scoped_switch_fork_info>: Fix incorrect variable name.
3344
3345 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3346
3347         * linux-fork.c (scoped_switch_fork_info)
3348         <scoped_switch_fork_info>: Make explicit.
3349         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3350
3351 2019-01-10  Tom Tromey  <tom@tromey.com>
3352
3353         * objfiles.h (objfile::reset_psymtabs): Update.
3354         * objfiles.c (objfile::objfile): Update.
3355         * psymtab.h (psymtab_storage::obstack): Update.
3356         (psymtab_storage::m_obstack): Use gdb::optional.
3357         (class psymtab_storage): Update comment.  Remove objfile
3358         parameter.
3359         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3360
3361 2019-01-10  Tom Tromey  <tom@tromey.com>
3362
3363         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3364         <free_psymtabs>: Now private.
3365         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3366         (allocate_psymtab): Use new method.
3367
3368 2019-01-10  Tom Tromey  <tom@tromey.com>
3369
3370         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3371         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3372         * mdebugread.c (parse_partial_symbols): Use
3373         allocate_dependencies.
3374         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3375         allocate_dependencies.
3376         (process_psymtab_comp_unit_reader)
3377         (build_type_psymtab_dependencies): Likewise.
3378         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3379
3380 2019-01-10  Tom Tromey  <tom@tromey.com>
3381
3382         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3383         PSYMBOL_SET_LANGUAGE.
3384         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3385
3386 2019-01-10  Tom Tromey  <tom@tromey.com>
3387
3388         * psymtab.h (psymtab_storage::obstack): New method.
3389         <m_obstack>: Rename from obstack; now private.
3390         * psymtab.c (psymtab_storage): Update.
3391         * dwarf2read.c (create_addrmap_from_index)
3392         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3393         Update.
3394
3395 2019-01-10  Tom Tromey  <tom@tromey.com>
3396
3397         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3398         * objfiles.h (objfile::reset_psymtabs): New method.
3399
3400 2019-01-10  Tom Tromey  <tom@tromey.com>
3401
3402         * symmisc.c (print_symbol_bcache_statistics): Update.
3403         (print_objfile_statistics): Update.
3404         * symfile.c (reread_symbols): Update.
3405         * psymtab.h (class psymtab_storage): New.
3406         * psymtab.c (psymtab_storage): New constructor.
3407         (~psymtab_storage): New destructor.
3408         (require_partial_symbols): Update.
3409         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3410         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3411         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3412         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3413         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3414         (start_psymtab_common, end_psymtab_common)
3415         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3416         (allocate_psymtab): Update.
3417         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3418         Update.
3419         (dump_psymtab_addrmap, maintenance_print_psymbols)
3420         (maintenance_check_psymtabs): Update.
3421         (class objfile_psymtabs): Move to objfiles.h.
3422         * psympriv.h (discard_psymtab): Now inline.
3423         (psymtab_discarder::psymtab_discarder): Update.
3424         (psymtab_discarder::~psymtab_discarder): Update.
3425         (ALL_OBJFILE_PSYMTABS): Rewrite.
3426         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3427         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3428         Remove fields.
3429         <partial_symtabs>: New field.
3430         (class objfile_psymtabs): Move from psymtab.h.  Update.
3431         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3432         psymbol_cache.
3433         (objfile::~objfile): Don't destroy psymbol_cache.
3434         * mdebugread.c (parse_partial_symbols): Update.
3435         * dwarf2read.c (create_addrmap_from_index)
3436         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3437         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3438         (add_partial_subprogram, dwarf2_ranges_read): Update.
3439         * dwarf-index-write.c (write_address_map)
3440         (write_one_signatured_type, recursively_write_psymbols)
3441         (class debug_names, class debug_names, write_psymtabs_to_index):
3442         Update.
3443
3444 2019-01-10  Tom Tromey  <tom@tromey.com>
3445
3446         * symtab.h (SYMBOL_SET_NAMES): Update.
3447         (symbol_set_names): Update.
3448         (MSYMBOL_SET_NAMES): Update.
3449         * symtab.c (symbol_set_names): Change argument to be an
3450         objfile_per_bfd_storage.
3451         * psymtab.c (add_psymbol_to_bcache): Update.
3452         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3453
3454 2019-01-10  Tom Tromey  <tom@tromey.com>
3455
3456         * symtab.c (create_demangled_names_hash): Change argument to be an
3457         objfile_per_bfd_storage.
3458         (symbol_set_names): Update.
3459
3460 2019-01-10  Tom Tromey  <tom@tromey.com>
3461
3462         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3463         init_psymbol_list.
3464         * psymtab.c (init_psymbol_list): Do nothing if already called.
3465         * psympriv.h (init_psymbol_list): Add comment.
3466         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3467         init_psymbol_list.
3468         * dbxread.c (dbx_symfile_read): Unconditionally call
3469         init_psymbol_list.
3470
3471 2019-01-10  Tom Tromey  <tom@tromey.com>
3472
3473         * xcoffread.c (scan_xcoff_symtab): Update.
3474         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3475         "where".
3476         * mdebugread.c (parse_partial_symbols)
3477         (handle_psymbol_enumerators): Update.
3478         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3479         * dbxread.c (read_dbx_symtab): Update.
3480         * psympriv.h (psymbol_placement): New enum.
3481         (add_psymbol_to_list): Update.
3482
3483 2019-01-10  Tom Tromey  <tom@tromey.com>
3484
3485         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3486         static_psymbols parameters.
3487         (scan_xcoff_symtab): Update.
3488         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3489         static_psymbols parameters.
3490         * psympriv.h (start_psymtab_common): Update.
3491         * mdebugread.c (parse_partial_symbols): Update.
3492         * dwarf2read.c (create_partial_symtab): Update.
3493         * dbxread.c (read_dbx_symtab): Update.
3494         (start_psymtab): Remove global_psymbols and static_psymbols
3495         parameters.
3496
3497 2019-01-10  Tom Tromey  <tom@tromey.com>
3498
3499         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3500         * psymtab.c (allocate_psymtab): Add comment.
3501         * psympriv.h (allocate_psymtab): Add comment.
3502         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3503         initializations.
3504         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3505
3506 2019-01-10  Tom Tromey  <tom@tromey.com>
3507
3508         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3509         Don't declare.
3510         * mipsread.c: Include mdebugread.h.
3511         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3512         Declare.
3513         * elfread.c: Include mdebugread.h.
3514
3515 2019-01-09  Tom Tromey  <tom@tromey.com>
3516
3517         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3518         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3519         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3520         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3521         (psym_lookup_symbol, psym_find_last_source_symtab)
3522         (psym_forget_cached_source_info, psym_print_stats)
3523         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3524         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3525         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3526         (psym_find_compunit_symtab_by_address)
3527         (maintenance_print_psymbols, maintenance_info_psymtabs)
3528         (maintenance_check_psymtabs): Use ranged for.
3529         * psymtab.h (class objfile_psymtabs): New.
3530         (require_partial_symbols): Return objfile_psymtabs.
3531         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3532
3533 2019-01-09  Tom Tromey  <tom@tromey.com>
3534
3535         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3536         (find_pc_mapped_section, list_overlays_command)
3537         (map_overlay_command, unmap_overlay_command)
3538         (simple_overlay_update): Use all_objfiles.
3539         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3540         * printcmd.c (info_symbol_command): Use all_objfiles.
3541         * objfiles.h (ALL_OBJSECTIONS): Remove.
3542         * maint.c (maintenance_translate_address): Use all_objfiles.
3543         * gcore.c (gcore_create_callback): Use all_objfiles.
3544         (objfile_find_memory_regions): Likewise.
3545
3546 2019-01-09  Tom Tromey  <tom@tromey.com>
3547
3548         * symtab.c (find_line_symtab, info_sources_command)
3549         (make_source_files_completion_list): Use objfile_compunits.
3550         * source.c (select_source_symtab): Use objfile_compunits.
3551         * objfiles.h (struct objfile): Update comment.
3552         (ALL_OBJFILES): Remove.
3553         (ALL_FILETABS): Remove.
3554         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3555         objfile_compunits.
3556
3557 2019-01-09  Tom Tromey  <tom@tromey.com>
3558
3559         * symmisc.c (print_objfile_statistics, dump_objfile)
3560         (maintenance_print_symbols): Use compunit_filetabs.
3561         * source.c (forget_cached_source_info_for_objfile): Use
3562         compunit_filetabs.
3563         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3564         (ALL_FILETABS): Use compunit_filetabs.
3565         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3566         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3567
3568 2019-01-09  Tom Tromey  <tom@tromey.com>
3569
3570         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3571         (compunit_filetabs): New.
3572         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3573         compunit_filetabs.
3574         (info_sources_command, make_source_files_completion_list): Remove
3575         declaration.
3576         * symmisc.c (print_objfile_statistics, dump_objfile)
3577         (maintenance_print_symbols): Remove declaration.
3578         (maintenance_info_symtabs): Use compunit_filetabs.
3579         (maintenance_info_line_tables): Likewise.
3580         * source.c (select_source_symtab): Change local variable name.
3581         (forget_cached_source_info_for_objfile): Remove declaration.
3582         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3583         * objfiles.c (objfile_relocate1): Remove declaration.
3584         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3585         declaration.
3586         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3587         * coffread.c (coff_symtab_read): Remove declaration.
3588         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3589         compunit_filetabs.
3590
3591 2019-01-09  Tom Tromey  <tom@tromey.com>
3592
3593         * symtab.c (lookup_objfile_from_block)
3594         (find_pc_sect_compunit_symtab, search_symbols)
3595         (default_collect_symbol_completion_matches_break_on): Use
3596         objfile_compunits.
3597         * objfiles.h (ALL_COMPUNITS): Remove.
3598         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3599         * cp-support.c (add_symbol_overload_list_qualified): Use
3600         objfile_compunits.
3601         * ada-lang.c (ada_collect_symbol_completion_matches)
3602         (ada_add_global_exceptions): Use objfile_compunits.
3603
3604 2019-01-09  Tom Tromey  <tom@tromey.com>
3605
3606         * source.c (select_source_symtab)
3607         (forget_cached_source_info_for_objfile): Remove declaration.
3608         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3609         declaration.
3610         * maint.c (count_symtabs_and_blocks): Remove declaration.
3611         * cp-support.c (add_symbol_overload_list_qualified): Remove
3612         declaration.
3613         * coffread.c (coff_symtab_read): Remove declaration.
3614         * symtab.c (lookup_symbol_in_objfile_symtabs)
3615         (basic_lookup_transparent_type_1): Use objfile_compunits.
3616         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3617         (info_sources_command, search_symbols)
3618         (default_collect_symbol_completion_matches_break_on)
3619         (make_source_files_completion_list): Remove declaration.
3620         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3621         (ada_collect_symbol_completion_matches)
3622         (ada_add_global_exceptions): Remove declaration.
3623         * linespec.c (iterate_over_all_matching_symtabs): Use
3624         objfile_compunits.
3625         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3626         (class objfile_compunits): New.
3627         (ALL_COMPUNITS): Use objfile_compunits.
3628         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3629         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3630         objfile_compunits.
3631         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3632
3633 2019-01-09  Tom Tromey  <tom@tromey.com>
3634
3635         * symtab.c (search_symbols)
3636         (default_collect_symbol_completion_matches_break_on): Use
3637         objfile_msymbols.
3638         * ada-lang.c (ada_lookup_simple_minsym)
3639         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3640         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3641         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3642         objfile_msymbols.
3643         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3644         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3645         * objc-lang.c (find_methods): Use objfile_msymbols.
3646         (info_selectors_command, info_classes_command): Likewise.
3647         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3648         * objfiles.h (class objfile_msymbols): New.
3649         (ALL_OBJFILE_MSYMBOLS): Remove.
3650         (ALL_MSYMBOLS): Remove.
3651
3652 2019-01-09  Tom Tromey  <tom@tromey.com>
3653
3654         * common/next-iterator.h (next_adapter): Add Iterator template
3655         parameter.
3656         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3657         (class all_objfiles_safe): New.
3658         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3659         * objfiles.c (put_objfile_before): Update comment.
3660         (add_separate_debug_objfile): Likewise.
3661         (free_all_objfiles): Use all_objfiles_safe.
3662         (objfile_purge_solibs): Likewise.
3663
3664 2019-01-09  Tom Tromey  <tom@tromey.com>
3665
3666         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3667         (expand_symtab_containing_pc, lookup_static_symbol)
3668         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3669         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3670         all_objfiles.
3671         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3672         * breakpoint.c (create_overlay_event_breakpoint)
3673         (create_longjmp_master_breakpoint)
3674         (create_std_terminate_master_breakpoint)
3675         (create_exception_master_breakpoint): Use all_objfiles.
3676         * linux-thread-db.c (try_thread_db_load_from_pdir)
3677         (has_libpthread): Use all_objfiles.
3678         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3679         * linespec.c (iterate_over_all_matching_symtabs)
3680         (search_minsyms_for_name): Use all_objfiles.
3681         * maint.c (maintenance_info_sections): Use all_objfiles.
3682         * main.c (captured_main_1): Use all_objfiles.
3683         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3684         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3685         * guile/scm-pretty-print.c
3686         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3687         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3688         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3689         (maintenance_print_msymbols): Use all_objfiles.
3690         * source.c (select_source_symtab): Use all_objfiles.
3691         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3692         * symfile.c (remove_symbol_file_command)
3693         (expand_symtabs_matching, map_symbol_filenames): Use
3694         all_objfiles.
3695         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3696         all_objfiles.
3697         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3698         * objc-lang.c (find_methods): Use all_objfiles.
3699         * objfiles.c (have_partial_symbols, have_full_symbols)
3700         (have_minimal_symbols, qsort_cmp)
3701         (default_iterate_over_objfiles_in_search_order): Use
3702         all_objfiles.
3703         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3704         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3705         (maintenance_check_psymtabs): Use all_objfiles.
3706         (ALL_PSYMTABS): Remove.
3707         * compile/compile-object-run.c (do_module_cleanup): Use
3708         all_objfiles.
3709         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3710         * cp-support.c (add_symbol_overload_list_qualified): Use
3711         all_objfiles.
3712         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3713         Use all_objfiles.
3714         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3715         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3716         all_objfiles.
3717         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3718         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3719         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3720         Uses all_objfiles.
3721         * solib.c (solib_read_symbols): Use all_objfiles
3722
3723 2019-01-09  Tom Tromey  <tom@tromey.com>
3724
3725         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3726         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3727         all_objfiles.
3728         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3729         * symmisc.c (print_symbol_bcache_statistics)
3730         (print_objfile_statistics, maintenance_print_objfiles)
3731         (maintenance_info_symtabs, maintenance_check_symtabs)
3732         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3733         all_objfiles.
3734         * source.c (forget_cached_source_info): Use all_objfiles.
3735         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3736         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3737         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3738         * objfiles.c (update_section_map): Use all_objfiles.
3739         (shared_objfile_contains_address_p): Likewise.
3740         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3741         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3742
3743 2019-01-09  Tom Tromey  <tom@tromey.com>
3744
3745         * common/next-iterator.h: New file.
3746         * objfiles.h (class all_objfiles): New.
3747         (struct objfile_iterator): New.
3748
3749 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3750
3751         * NEWS: Move the description of the changed "frame", "select-frame",
3752          and "info frame" commands to the Changed commands section.
3753
3754 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3755
3756         * gdbtypes.c (check_stub_method_group): Remove handling of old
3757         mangling schemes.
3758         * linespec.c (find_methods): Likewise.
3759         * stabsread.c (read_member_functions): Likewise.
3760         * valops.c (search_struct_method): Likewise.
3761         (value_struct_elt_for_reference): Likewise.
3762         * NEWS: Mention this change.
3763
3764 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3767         print_source_lines.
3768         * source.c (print_source_lines_base): Update line number check.
3769         (print_source_lines): New function.
3770         (source_lines_range::source_lines_range): New function.
3771         * source.h (class source_lines_range): New class.
3772         (print_source_lines): New declaration.
3773
3774 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3775
3776         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3777
3778 2019-01-08  Tom Tromey  <tom@tromey.com>
3779             Simon Marchi  <simon.marchi@ericsson.com>
3780
3781         PR gdb/24060
3782         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3783         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3784         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3785         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3786         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3787         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3788
3789 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3790
3791         * source.c (select_source_symtab): Move header comment to
3792         declaration in source.h.
3793         (forget_cached_source_info_for_objfile): Likewise.
3794         (forget_cached_source_info): Likewise.
3795         (identify_source_line): Likewise.
3796         * source.h (identify_source_line): Move declaration from symtab.h
3797         and add comment from source.c
3798         (print_source_lines): Likewise.
3799         (forget_cached_source_info_for_objfile): Likewise.
3800         (forget_cached_source_info): Likewise.
3801         (select_source_symtab): Likewise.
3802         (enum print_source_lines_flag): Move definition from symtab.h.
3803         * symtab.h (identify_source_line): Move declaration to source.h.
3804         (print_source_lines): Likewise.
3805         (forget_cached_source_info_for_objfile): Likewise.
3806         (forget_cached_source_info): Likewise.
3807         (select_source_symtab): Likewise.
3808         (enum print_source_lines_flag): Move definition to source.h.
3809         * tui/tui-hooks.c: Add 'source.h' include.
3810
3811 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3812
3813         * source.c (print_source_lines_base): Handle requests to print
3814         reverse line number sequences, and guard against empty lines
3815         string.
3816
3817 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * source.c (print_source_lines_base): Fix skip of '\r' if next
3820         character is '\n'.
3821
3822 2019-01-06  Tom Tromey  <tom@tromey.com>
3823
3824         * c-exp.y (struct c_parse_state) <macro_original_text,
3825         expansion_obstack>: New member.
3826         (macro_original_text, expansion_obstack): Remove globals.
3827         (scan_macro_expansion, scanning_macro_expansion)
3828         (finished_macro_expansion): Update.
3829         (scan_macro_cleanup): Remove.
3830         (yylex, c_parse): Update.
3831
3832 2019-01-06  Tom Tromey  <tom@tromey.com>
3833
3834         * c-exp.y (struct c_parse_state) <strings>: New member.
3835         (operator_stoken): Update.
3836
3837 2019-01-06  Tom Tromey  <tom@tromey.com>
3838
3839         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3840         (union type_stack_elt) <typelist_val>: Now a pointer to
3841         std::vector.
3842         (type_stack_cleanup): Don't declare.
3843         (push_typelist): Update.
3844         * parse.c (pop_typelist): Return a std::vector.
3845         (push_typelist): Take a std::vector.
3846         (follow_types): Update.  Do not free args.
3847         (type_stack_cleanup): Remove.
3848         * c-exp.y (struct c_parse_state): New.
3849         (cpstate): New global.
3850         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3851         (nonempty_typelist): Update.
3852         (func_mod): Create a new vector.
3853         (c_parse): Create a c_parse_state.
3854         (check_parameter_typelist): Do not delete params.
3855         (function_method): Update.  Do not delete type_list.
3856
3857 2019-01-06  Tom Tromey  <tom@tromey.com>
3858
3859         PR gdb/28155:
3860         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3861         check_typedef.
3862         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3863         (print_return_value): Likewise.
3864
3865 2019-01-05  Tom Tromey  <tom@tromey.com>
3866
3867         * contrib/cleanup_check.py: Remove.
3868         * contrib/gcc-with-excheck: Remove.
3869         * contrib/exsummary.py: Remove.
3870         * contrib/excheck.py: Remove.
3871
3872 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3873
3874         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3875         NULL. Initialize tpprev to NULL instead of assigning it
3876         to NULL on the next statement.
3877         * windows-nat.c (windows_delete_thread): Remove check for
3878         main_thread_id before printing thread exit notifications.
3879         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3880         Remove thread ID check against main_thread_id.
3881         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3882         windows_delete_thread.
3883         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3884
3885 2019-01-04  Tom Tromey  <tom@tromey.com>
3886
3887         * compile/compile.c (_initialize_compile): Use upper case for
3888         metasyntactic variables.
3889         * symmisc.c (_initialize_symmisc): Use upper case for
3890         metasyntactic variables.
3891         * psymtab.c (_initialize_psymtab): Use upper case for
3892         metasyntactic variables.
3893         * demangle.c (demangle_command): Use upper case for metasyntactic
3894         variables.
3895         (_initialize_demangler): Likewise.
3896         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3897         variables.
3898
3899 2019-01-03  Tom Tromey  <tom@tromey.com>
3900
3901         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3902
3903 2019-01-03  Tom Tromey  <tom@tromey.com>
3904
3905         * python/py-symtab.c (salpy_str): Update.
3906         (struct salpy_sal_object) <symtab>: Now a PyObject.
3907         (salpy_dealloc): Update.
3908         (del_objfile_sal): Use gdbpy_ref.
3909
3910 2019-01-03  Tom Tromey  <tom@tromey.com>
3911
3912         * python/py-type.c (convert_field): Use new_reference.  Return
3913         gdbpy_ref.
3914         (make_fielditem): Return gdbpy_ref.
3915         (typy_fields): Update.
3916         (typy_getitem): Update.
3917         (field_name): Return gdbpy_ref.  Use new_reference.
3918         (typy_iterator_iternext): Update.
3919
3920 2019-01-03  Tom Tromey  <tom@tromey.com>
3921
3922         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3923
3924 2019-01-03  Tom Tromey  <tom@tromey.com>
3925
3926         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3927         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3928         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3929         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3930         (pspy_set_type_printers): Likewise.
3931         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3932         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3933         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3934         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3935         (objfpy_set_type_printers): Likewise.
3936
3937 2019-01-03  Tom Tromey  <tom@tromey.com>
3938
3939         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3940         (gdbpy_print_stack): Use gdbpy_err_fetch.
3941         * python/python-internal.h (class gdbpy_err_fetch): New class.
3942         (class gdbpy_enter) <m_error_type, m_error_value,
3943         m_error_traceback>: Remove.
3944         <m_error>: New member.
3945         (gdbpy_exception_to_string): Don't declare.
3946         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3947         * python/py-value.c (convert_value_from_python): Use
3948         gdbpy_err_fetch.
3949         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3950         gdbpy_exception_to_string.
3951         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3952         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3953         gdbpy_err_fetch.
3954
3955 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3956
3957         * linux-nat.c (delete_lwp_cleanup): Delete.
3958         (struct lwp_deleter): New struct.
3959         (lwp_info_up): New typedef.
3960         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3961         lwp_info_up.
3962
3963 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3964
3965         * linux-fork.c (class scoped_switch_fork_info): New class.
3966         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3967
3968 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3969
3970         * valops.c (find_overload_match): Remove use of null_cleanup, and
3971         calls to do_cleanups.
3972
3973 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3974
3975         * compile/compile-cplus-types.c
3976         (compile_cplus_instance::decl_name): Handle changes to
3977         cp_func_name.
3978         * cp-support.c (cp_func_name): Update header comment, update
3979         return type.
3980         * cp-support.h (cp_func_name): Update return type in declaration.
3981         * valops.c (find_overload_match): Move temp_func local to top
3982         level of function and change its type.  Use temp_func to hold and
3983         delete temporary string obtained from cp_func_name.
3984
3985 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3986
3987         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3988         gdb::char_vector, remove cleanup, and update uses of `msg`.
3989
3990 2019-01-03  Jim Wilson  <jimw@sifive.com>
3991
3992         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3993
3994 2019-01-02  Tom Tromey  <tom@tromey.com>
3995
3996         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3997         (tdesc_parse_xml): Remove cleanups.
3998         * target-descriptions.h (make_cleanup_free_target_description):
3999         Don't declare.
4000         (target_desc_deleter): New struct.
4001         (target_desc_up): New typedef.
4002         * target-descriptions.c (target_desc_deleter::operator()): Rename
4003         from free_target_description.
4004         (make_cleanup_free_target_description): Remove.
4005
4006 2019-01-02  Tom Tromey  <tom@tromey.com>
4007
4008         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4009         constructor, destructor.
4010         (linespec_parser): Remove typedef.
4011         (~linespec_parser): Rename from linespec_parser_delete.
4012         (linespec_lex_to_end, linespec_complete_label)
4013         (linespec_complete): Update.
4014         (decode_line_full): Remove cleanups.
4015         (decode_line_1): Update.
4016
4017 2019-01-02  Tom Tromey  <tom@tromey.com>
4018
4019         * python/python-internal.h (inferior_to_inferior_object): Change
4020         return type.
4021         * python/py-exitedevent.c (create_exited_event_object): Update.
4022         * python/py-inferior.c (inferior_to_inferior_object): Return
4023         gdbpy_ref.
4024         (python_new_inferior, python_inferior_deleted)
4025         (thread_to_thread_object, delete_thread_object)
4026         (build_inferior_list, gdbpy_selected_inferior): Update.
4027         * python/py-infthread.c (create_thread_object): Update.  Also fail
4028         if inferior_to_inferior_object fails.
4029
4030 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4031
4032         * inferior.h (class inferior) <displaced_step_state>: New field.
4033         * infrun.h (struct displaced_step_state): Move here from
4034         infrun.c.  Initialize fields, add constructor.
4035         <inf>: Remove field.
4036         <reset>: New method.
4037         * infrun.c (struct displaced_step_inferior_state): Move to
4038         infrun.h.
4039         (displaced_step_inferior_states): Remove.
4040         (get_displaced_stepping_state): Adust.
4041         (displaced_step_in_progress_any_inferior): Adjust.
4042         (displaced_step_in_progress_thread): Adjust.
4043         (displaced_step_in_progress): Adjust.
4044         (add_displaced_stepping_state): Remove.
4045         (get_displaced_step_closure_by_addr): Adjust.
4046         (remove_displaced_stepping_state): Remove.
4047         (infrun_inferior_exit): Call displaced_step_state.reset.
4048         (use_displaced_stepping): Don't check for NULL.
4049         (displaced_step_prepare_throw): Call
4050         get_displaced_stepping_state.
4051         (displaced_step_fixup): Don't check for NULL.
4052         (prepare_for_detach): Don't check for NULL.
4053
4054 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4055
4056         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4057          in case of call that did not complete.
4058
4059 2019-01-02  Andrey Utkin  <autkin@undo.io>
4060
4061         * symfile.c (find_separate_debug_file): Fix search of debug files for
4062         remote debuggee.
4063
4064 2019-01-02  Tom Tromey  <tom@tromey.com>
4065
4066         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4067         indentation.
4068         * python/py-frame.c (frapy_older): Remove cast.
4069         (frapy_newer): Likewise.
4070         * python/py-breakpoint.c (local_setattro): Remove cast.
4071         * python/py-arch.c (archpy_name): Remove local variable.
4072         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4073
4074 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4075
4076         * unittests/basic_string_view/element_access/char/empty.cc:
4077         Fix year range in copyright header.
4078
4079 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4080
4081         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4082         Delete.
4083         <operator==>: Update with for removed field.
4084         <hash>: Likewise.
4085         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4086         <isa_features>: ...this.
4087         <abi_features>: New field.
4088         (riscv_isa_flen): Update comment.
4089         (riscv_abi_xlen): New declaration.
4090         (riscv_abi_flen): New declaration.
4091         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4092         isa_features.
4093         (riscv_abi_xlen): New function.
4094         (riscv_isa_flen): Update to get answer from isa_features.
4095         (riscv_abi_flen): New function.
4096         (riscv_has_fp_abi): Update to get answer from abi_features.
4097         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4098         xlen and flen.
4099         (riscv_call_info) <xlen, flen>: Update comment.
4100         (riscv_call_arg_struct): Remove invalid assertions
4101         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4102         is removed.
4103         (riscv_gdbarch_init): Gather isa features and abi features
4104         separately, ensure both match on the gdbarch when reusing an old
4105         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4106         a target with 64-bit float hardware.
4107
4108 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4109
4110         * source.c (search_command_helper): Stop reverse search
4111         when line 1 has been searched.
4112
4113 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4114
4115         * record-full.c (record_full_base_target::close): Rewrite
4116         record_full_core_buf_list free logic.
4117
4118 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4119
4120         * break-catch-syscall.c (print_one_catch_syscall): xfree
4121         the last text.
4122
4123 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4124
4125         * top.c (print_gdb_version): Update Copyright year in version
4126         message.
4127
4128 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4129
4130         Update copyright year range in all GDB files.
4131
4132 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4133
4134         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4135
4136 For older changes see ChangeLog-2018.
4137 \f
4138 Local Variables:
4139 mode: change-log
4140 left-margin: 8
4141 fill-column: 74
4142 version-control: never
4143 coding: utf-8
4144 End:
4145