gdb/ChangeLog

   1 2019-06-28  Tom Tromey  <tromey@adacore.com>
   2
   3         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
   4         for Ada.
   5
   6 2019-06-27  Tom Tromey  <tromey@adacore.com>
   7
   8         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
   9         objfile_key.
  10         (arm_find_mapping_symbol, arm_record_special_symbol)
  11         (_initialize_arm_tdep): Update.
  12         (arm_objfile_data_free): Remove.
  13
  14 2019-06-27  Tom Tromey  <tromey@adacore.com>
  15
  16         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
  17         to cp_print_static_field.
  18
  19 2019-06-26  Tom Tromey  <tromey@adacore.com>
  20
  21         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
  22         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
  23         declare.
  24
  25 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  26
  27         * features/aarch64-core.c (create_feature_aarch64_core):
  28         Regenerate.
  29         * features/aarch64-core.xml: Add cpsr flags.
  30
  31 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  32
  33         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
  34         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
  35
  36 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  37
  38         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
  39         field.
  40         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
  41         use.
  42         (arm_record_special_symbol): Don't insert new symbol in sorted
  43         position, push it at the end.
  44
  45 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  46
  47         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
  48         (arm_mapping_symbol_s): Remove.
  49         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
  50         (arm_mapping_symbol_vec): New typedef.
  51         (struct arm_per_objfile): Add constructor.
  52         <section_maps>: Change type to
  53         std::unique_ptr<arm_mapping_symbol_vec[]>.
  54         (arm_compare_mapping_symbols): Remove.
  55         (arm_find_mapping_symbol): Adjust to section_maps type change.
  56         (arm_objfile_data_free): Call delete on arm_per_objfile.
  57         (arm_record_special_symbol): Adjust to section_maps type change.
  58         Allocate arm_per_objfile with new.
  59
  60 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  61
  62         * cli/cli-cmds.c (alias_command): Compare the alias prefix
  63         with the command prefix.
  64
  65 2019-06-25  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
  68         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
  69
  70 2019-06-25  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
  73         type.
  74         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
  75         protected.
  76
  77 2019-06-25  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-winsource.c
  80         (tui_source_window_base::set_is_exec_point_at): Add check against
  81         LOA_ADDRESS.
  82
  83 2019-06-25  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-source.c (tui_set_source_content): Don't check before
  86         xfree.
  87         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
  88
  89 2019-06-25  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-winsource.h (tui_update_source_window_as_is)
  92         (tui_alloc_source_buffer, tui_line_is_displayed)
  93         (tui_addr_is_displayed): Change type of win_info.
  94         * tui/tui-winsource.c (tui_update_source_window_as_is)
  95         (tui_clear_source_content, tui_show_source_line)
  96         (tui_show_source_content, tui_source_window_base::refill)
  97         (tui_source_window_base::set_is_exec_point_at)
  98         (tui_source_window_base::set_is_exec_point_at)
  99         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 100         (tui_alloc_source_buffer, tui_line_is_displayed)
 101         (tui_addr_is_displayed): Change type of win_info.  Update.
 102         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 103         (tui_source_window_base::do_make_visible_with_new_height):
 104         Update.
 105         * tui/tui-source.c (tui_set_source_content)
 106         (tui_set_source_content_nil)
 107         (tui_source_window::do_scroll_vertical): Update.
 108         * tui/tui-layout.c (show_layout): Update.
 109         * tui/tui-disasm.c (tui_set_disassem_content)
 110         (tui_disasm_window::do_scroll_vertical): Update.
 111         * tui/tui-data.h (tui_win_content): Remove.
 112         (struct tui_gen_win_info) <content, content_size>: Remove.
 113         (struct tui_source_element): Add initializers and destructor.
 114         (union tui_which_element, struct tui_win_element): Remove.
 115         (struct tui_source_window_base) <content>: New field.
 116         (struct tui_data_window): Remove destructor.
 117         (tui_alloc_content, tui_free_win_content)
 118         (tui_free_all_source_wins_content): Don't declare.
 119         * tui/tui-data.c (tui_initialize_static_data): Update.
 120         (init_content_element, tui_alloc_content): Remove.
 121         (~tui_gen_win_info): Update.
 122         (~tui_data_window, tui_free_all_source_wins_content)
 123         (tui_free_win_content, free_content, free_content_elements):
 124         Remove.
 125
 126 2019-06-25  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-winsource.h (tui_clear_source_content)
 129         (tui_erase_source_content, tui_show_source_content): Change type
 130         of win_info.
 131         * tui/tui-winsource.c (tui_clear_source_content)
 132         (tui_erase_source_content, tui_show_source_content): Change type
 133         of win_info.
 134         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 135         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 136         win_info.
 137         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 138         win_info.
 139         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 140
 141 2019-06-25  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-winsource.c (tui_clear_source_content)
 144         (tui_source_window_base::set_is_exec_point_at): Update.
 145         * tui/tui-source.c (tui_set_source_content_nil): Update.
 146         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 147         a bool.
 148         * tui/tui-data.c (init_content_element): Update.
 149
 150 2019-06-25  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 153         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 154         * tui/tui-layout.c (init_and_make_win): Update.
 155         * tui/tui.h (enum tui_win_type): Update.
 156         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 157         tui_win_is_auxillary.
 158         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 159         tui_win_is_auxillary.
 160
 161 2019-06-25  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 164         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 165         (tui_delete_data_content_windows, tui_display_all_data)
 166         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 167         Update.
 168         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 169         * tui/tui-regs.c (tui_last_regs_line_no)
 170         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 171         (tui_show_registers): Update.
 172         (tui_show_register_group): Return void.  Update.
 173         (tui_display_registers_from, tui_display_reg_element_at_line)
 174         (tui_display_registers_from_line, tui_check_register_values):
 175         Update.
 176         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 177         member.
 178         (struct tui_data_window) <regs_content>: Now a std::vector.
 179         <regs_content_count>: Remove.
 180         (tui_add_content_elements, tui_free_data_content): Don't declare.
 181         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 182         (init_content_element): Remove DATA_WIN case.  Add assert.
 183         (tui_add_content_elements): Remove.
 184         (tui_data_window): Update.
 185         (tui_free_data_content): Remove.
 186         (free_content_elements): Remove DATA_WIN case.
 187
 188 2019-06-25  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-data.c (tui_data_item_window): Update.
 191         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 192         * tui/tui-windata.c (tui_display_all_data)
 193         (tui_display_data_from_line): Update.
 194         (tui_check_data_values): Remove.
 195         * tui/tui-regs.c (tui_show_register_group)
 196         (tui_display_reg_element_at_line): Update.
 197         * tui/tui-hooks.c (tui_register_changed)
 198         (tui_refresh_frame_and_register_information): Call
 199         tui_check_register_values.
 200         * tui/tui-data.h (struct tui_data_window) <data_content,
 201         data_content_count, data_type>: Remove.
 202         (enum tui_data_type): Remove.
 203
 204         * tui/tui-data.c (tui_data_window::clear_detail)
 205         (~tui_data_window): Update.
 206
 207 2019-06-25  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 210         declare.
 211         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 212         Rename from tui_first_data_item_displayed.  Update.
 213         (tui_data_window::refresh_all)
 214         (tui_data_window::do_scroll_vertical): Update.
 215         * tui/tui-data.h (struct tui_data_window)
 216         <first_data_item_displayed>: Declare new method.
 217
 218 2019-06-25  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 221         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 222         contents...
 223         (tui_initialize_static_data): ...here.
 224
 225 2019-06-25  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 228         (tui_display_registers_from, tui_check_register_values): Update.
 229         (tui_display_register): Remove win_info parameter; update.
 230         (tui_get_register): Change type of parameters.
 231         * tui/tui-data.h (struct tui_data_element): Remove.
 232         (union tui_which_element) <data>: Remove.
 233         <data_window>: Change type.
 234         (struct tui_data_item_window): New.
 235         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 236         case.  Add assert.
 237         (~tui_data_item_window): New destructor.
 238         (free_content_elements): Remove DATA_ITEM_WIN case.
 239
 240 2019-06-25  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 243         Remove.
 244
 245 2019-06-25  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-data.h (struct tui_command_element): Remove.
 248         (union tui_which_element) <command>: Remove.
 249         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 250         assert.
 251         (free_content_elements): Remove CMD_WIN case.
 252
 253 2019-06-25  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-layout.c (tui_set_layout): Update.
 256         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 257         * tui/tui-data.c (layout_def): Update.
 258
 259 2019-06-25  Tom Tromey  <tom@tromey.com>
 260
 261         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 262         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 263         (tui_source_window_base::set_new_height): Update.
 264         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 265         Update.
 266         (tui_set_locator_fullname, tui_set_locator_info)
 267         (tui_show_frame_info): Update.
 268         * tui/tui-source.c (tui_set_source_content)
 269         (tui_source_is_displayed): Update.
 270         * tui/tui-layout.c (show_source_disasm_command, show_data)
 271         (show_source_or_disasm_and_command): Update.
 272         * tui/tui-disasm.c (tui_set_disassem_content)
 273         (tui_get_begin_asm_address): Update.
 274         * tui/tui-data.h (struct tui_locator_element): Remove.
 275         (union tui_which_element) <locator>: Remove.
 276         (struct tui_locator_window): New.
 277         (tui_locator_win_info_ptr): Change return type.
 278         * tui/tui-data.c (_locator): Change type.
 279         (tui_locator_win_info_ptr): Change return type.
 280         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 281         (tui_alloc_content): Add assert.
 282
 283 2019-06-25  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-winsource.c
 286         (tui_exec_info_window::maybe_allocate_content): New method.
 287         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 288         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 289         (make_source_or_disasm_window): Add cast.
 290         * tui/tui-data.h (union tui_which_element) <simple_string>:
 291         Remove.
 292         (struct tui_source_info): New.
 293         (struct tui_source_window_base) <execution_info>: Change type.
 294         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 295         case, and add assert.
 296         (tui_alloc_content): Add assert.
 297
 298 2019-06-25  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 301         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 302         * tui/tui-data.c (tui_alloc_win_info): Remove.
 303
 304 2019-06-25  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 307         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 308         can_highlight.
 309
 310 2019-06-25  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 313         make_visible_with_new_height method.
 314         (tui_win_info::make_visible_with_new_height): New method.
 315         (tui_source_window_base::do_make_visible_with_new_height)
 316         (tui_data_window::do_make_visible_with_new_height)
 317         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 318         (make_visible_with_new_height): Remove.
 319         (tui_resize_all, tui_adjust_win_heights): Use
 320         make_visible_with_new_height method.
 321         * tui/tui-data.h (struct tui_win_info)
 322         <do_make_visible_with_new_height, make_visible_with_new_height>:
 323         New methods.
 324         (struct tui_source_window_base, struct tui_data_window)
 325         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 326         methods.
 327
 328 2019-06-25  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 331         method.
 332         (update_tab_width): Call update_tab_width method.
 333         * tui/tui-data.h (struct tui_win_info)
 334         (struct tui_source_window_base) <update_tab_width>: New methods.
 335
 336 2019-06-25  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 339         parameter.
 340         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 341         parameter.
 342         (tui_gen_win_info::make_visible): Update.
 343         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 344         parameter.
 345         * tui/tui-data.h (enum tui_box): New enum.
 346         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 347
 348 2019-06-25  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 351         init_and_make_win for EXEC_INFO_WIN.
 352         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 353         longer inline.
 354         (struct tui_win_info) <~tui_win_info>: Inline.
 355         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 356         Don't declare.
 357         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 358         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 359         Remove.
 360         (tui_initialize_static_data): Update.
 361         (~tui_gen_win_info): Handle more cleanup here.
 362         (~tui_source_window_base): Delete "execution_info".
 363         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 364
 365 2019-06-25  Tom Tromey  <tom@tromey.com>
 366
 367         * tui/tui-layout.c (make_command_window): Don't set
 368         can_highlight.
 369         (show_source_disasm_command): Call the reset method.
 370         (show_data): Don't set can_highlight.  Call the reset method.
 371         (tui_gen_win_info::reset): Rename from init_gen_win_info
 372         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 373         (show_source_or_disasm_and_command): Call the reset method.
 374         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 375         (struct tui_cmd_window): Set can_highlight.
 376
 377 2019-06-25  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 380         from make_visible.
 381         (tui_make_visible, tui_make_invisible): Rewrite.
 382         (tui_win_info::make_visible): Remove.
 383         (tui_source_window_base::make_visible): Update.
 384         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 385         method.  Moved from...
 386         (struct tui_win_info) <make_visible>: ...here.
 387
 388 2019-06-25  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-winsource.c
 391         (tui_source_window_base::do_scroll_horizontal): Remove direction
 392         parameter.
 393         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 394         direction parameter.
 395         * tui/tui-win.c (tui_win_info::forward_scroll)
 396         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 397         (tui_win_info::right_scroll): Update.
 398         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 399         direction parameter.
 400         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 401         direction parameter.
 402         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 403         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 404         Remove direction parameter.
 405         (struct tui_source_window_base, struct tui_source_window)
 406         (struct tui_disasm_window, struct tui_data_window)
 407         (struct tui_cmd_window): Update.
 408
 409 2019-06-25  Tom Tromey  <tom@tromey.com>
 410
 411         * tui/tui-winsource.h (tui_set_exec_info_content)
 412         (tui_show_exec_info_content, tui_erase_exec_info_content)
 413         (tui_clear_exec_info_content, tui_update_exec_info): Change
 414         argument to tui_source_window_base.
 415         * tui/tui-winsource.c (tui_set_exec_info_content)
 416         (tui_show_exec_info_content, tui_erase_exec_info_content)
 417         (tui_clear_exec_info_content, tui_update_exec_info): Change
 418         argument to tui_source_window_base.
 419
 420 2019-06-25  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 423         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 424
 425 2019-06-25  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 428         check.
 429
 430 2019-06-25  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 433         type to void.
 434         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 435         type to void.
 436         * tui/tui-source.c (tui_set_source_content): Update.
 437         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 438
 439 2019-06-25  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-win.c (window_name_completer, tui_set_focus)
 442         (tui_all_windows_info): Use name method.
 443         * tui/tui-data.h (struct tui_gen_win_info)
 444         (struct tui_source_window, struct tui_disasm_window)
 445         (struct tui_data_window, struct tui_cmd_window) <name>: New
 446         method.
 447         (tui_win_name): Don't declare.
 448         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 449         (tui_win_name): Remove.
 450
 451 2019-06-25  Tom Tromey  <tom@tromey.com>
 452
 453         * tui/tui-winsource.h (tui_update_source_window)
 454         (tui_update_source_window_as_is): Change parameter type.
 455         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 456         to be a tui_source_window_base.
 457         (tui_update_source_window_as_is): Likewise.
 458         * tui/tui-win.c (make_visible_with_new_height): Update.
 459
 460 2019-06-25  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-winsource.c (tui_erase_source_content)
 463         (tui_show_source_content, tui_show_exec_info_content)
 464         (tui_erase_exec_info_content): Use refresh_window method.
 465         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 466         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 467         from tui_refresh_win.
 468         (tui_data_window::refresh_window): New method.
 469         (tui_win_info::refresh, tui_source_window_base::refresh)
 470         (tui_refresh_all): Use refresh_window method.
 471         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 472         method.
 473         * tui/tui-regs.c (tui_display_register): Call refresh_window
 474         method.
 475         * tui/tui-layout.c (show_source_disasm_command)
 476         (show_source_or_disasm_and_command): Call refresh_window method.
 477         * tui/tui-data.h (struct tui_gen_win_info)
 478         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 479         New method.
 480
 481 2019-06-25  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui.c (tui_rl_other_window, tui_enable)
 484         (tui_is_window_visible, tui_get_command_dimension): Update.
 485         * tui/tui-winsource.c (tui_update_source_window_as_is)
 486         (tui_clear_source_content, tui_erase_source_content)
 487         (tui_show_source_line, tui_source_window_base::refill)
 488         (tui_source_window_base::do_scroll_horizontal)
 489         (tui_source_window_base::set_is_exec_point_at)
 490         (tui_update_breakpoint_info, tui_set_exec_info_content)
 491         (tui_alloc_source_buffer, tui_line_is_displayed)
 492         (tui_addr_is_displayed): Update.
 493         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 494         (tui_check_and_display_highlight_if_needed)
 495         (tui_win_info::make_visible, tui_win_info::refresh)
 496         (tui_refresh_all): Update.
 497         * tui/tui-windata.c (tui_first_data_item_displayed)
 498         (tui_delete_data_content_windows, tui_erase_data_content)
 499         (tui_display_all_data, tui_data_window::refresh_all)
 500         (tui_check_data_values): Update.
 501         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 502         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 503         (tui_win_info::backward_scroll, tui_refresh_all_win)
 504         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 505         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 506         (tui_source_window_base::set_new_height)
 507         (tui_data_window::set_new_height)
 508         (make_invisible_and_set_new_height)
 509         (make_visible_with_new_height, new_height_ok)
 510         (parse_scrolling_args): Update.
 511         * tui/tui-stack.c (tui_show_frame_info): Update.
 512         * tui/tui-source.c (tui_set_source_content)
 513         (tui_set_source_content_nil, tui_source_is_displayed)
 514         (tui_source_window::do_scroll_vertical): Update.
 515         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 516         (tui_display_registers_from, tui_display_reg_element_at_line)
 517         (tui_check_register_values, tui_reg_command): Update.
 518         * tui/tui-layout.c (tui_default_win_height)
 519         (show_source_disasm_command, show_data, init_and_make_win)
 520         (show_source_or_disasm_and_command): Update.
 521         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 522         (tui_redisplay_readline, tui_mld_flush)
 523         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 524         (tui_getc): Update.
 525         * tui/tui-disasm.c (tui_set_disassem_content)
 526         (tui_disasm_window::do_scroll_vertical): Update.
 527         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 528         Now virtual.
 529         (struct tui_win_info): Derive from tui_gen_win_info.
 530         <~tui_win_info>: Mark as override.
 531         <generic>: Remove member.
 532         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 533         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 534         (~tui_data_window, ~tui_win_info)
 535         (tui_free_all_source_wins_content): Update.
 536         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 537
 538 2019-06-25  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-layout.c (init_and_make_win): Use new.
 541         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 542         destructor, initializers.
 543         (tui_alloc_generic_win_info): Don't declare.
 544         * tui/tui-data.c (_locator): Add argument to constructor.
 545         (source_win, disasm_win): New globals.
 546         (exec_info): Remove.
 547         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 548         Update.
 549         (tui_alloc_generic_win_info): Remove.
 550         (init_content_element): Use new.
 551         (tui_win_info::tui_win_info): Update.
 552         (free_content_elements) <case DATA_WIN>: Use delete.
 553
 554 2019-06-25  Tom Tromey  <tom@tromey.com>
 555
 556         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 557         * tui/tui-windata.c (tui_first_data_item_displayed)
 558         (tui_delete_data_content_windows): Update.
 559         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 560         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 561         (tui_display_registers_from, tui_check_register_values): Update.
 562         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 563         pointer.
 564         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 565         window.
 566         (tui_free_data_content): Update.
 567         (free_content_elements) <case DATA_WIN>: Free the window.
 568
 569 2019-06-25  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 572         Update.
 573         * tui/tui-layout.c (make_command_window)
 574         (show_source_disasm_command, show_data, init_and_make_win)
 575         (show_source_or_disasm_and_command): Update.
 576         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 577         method.
 578         <can_highight, is_highlighted>: Now bool.
 579         (tui_set_win_highlight): Don't declare.
 580         * tui/tui-data.c (tui_set_win_highlight): Remove.
 581
 582 2019-06-25  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-wingeneral.c (make_visible): Remove check of window
 585         type.
 586
 587 2019-06-25  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-win.c (tui_win_info::max_height)
 590         (tui_cmd_window::max_height): New methods.
 591         (new_height_ok): Call max_height.
 592         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 593         <max_height>: New method.
 594
 595 2019-06-25  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-win.c (tui_source_window_base::set_new_height)
 598         (tui_data_window::set_new_height): New methods.
 599         (make_invisible_and_set_new_height): Call set_new_height method.
 600         * tui/tui-data.h (struct tui_win_info)
 601         (struct tui_source_window_base, struct tui_data_window)
 602         <set_new_height>: New method.
 603
 604 2019-06-25  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 607         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 608         tui_refresh_data_win.
 609         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 610         method.
 611         (tui_refresh_all_win): Call the refresh_all method.
 612         (tui_set_focus): Likewise.
 613         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 614         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 615         Likewise.
 616
 617 2019-06-25  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-winsource.h (tui_refill_source_window)
 620         (tui_set_is_exec_point_at): Don't declare.
 621         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 622         (tui_source_window_base::refill): Rename from
 623         tui_refill_source_window.
 624         (tui_source_window_base::do_scroll_horizontal): Update.
 625         (tui_source_window_base::set_is_exec_point_at): Rename from
 626         tui_set_is_exec_point_at.
 627         (tui_update_all_breakpoint_info): Update.
 628         * tui/tui-stack.c (tui_show_frame_info): Update.
 629         * tui/tui-layout.c (show_data): Add cast.
 630         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 631         * tui/tui-data.h (struct tui_source_window_base) <refill,
 632         set_is_exec_point_at>: New methods.
 633         (tui_source_windows, tui_add_to_source_windows): Update types.
 634         (tui_add_to_source_windows): Remove redundant declaration.
 635         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 636         (tui_source_windows): Change return type.
 637         (tui_clear_source_windows_detail): Update.
 638         (tui_add_to_source_windows): Change type of parameter.
 639         (tui_free_all_source_wins_content): Update.
 640
 641 2019-06-25  Tom Tromey  <tom@tromey.com>
 642
 643         * tui/tui-wingeneral.c (tui_win_info::refresh)
 644         (tui_source_window_base::refresh): New methods.
 645         (tui_refresh_all): Call the refresh method.
 646         * tui/tui-data.h (struct tui_win_info)
 647         (struct tui_source_window_base) <refresh>: New method.
 648
 649 2019-06-25  Tom Tromey  <tom@tromey.com>
 650
 651         * tui/tui.h (tui_is_window_visible): Return bool.
 652         * tui/tui.c (tui_is_window_visible): Return bool.
 653         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 654         (tui_make_visible, tui_make_invisible)
 655         (tui_win_info::make_visible)
 656         (tui_source_window_base::make_visible, make_all_visible)
 657         (tui_make_all_visible, tui_make_all_invisible): Update.
 658         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 659         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 660         bool.
 661         (struct tui_win_info, struct tui_source_window_base)
 662         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 663         * tui/tui-data.c (tui_init_generic_part): Update.
 664
 665 2019-06-25  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 668         (tui_source_window_base::make_visible): New methods.
 669         (make_all_visible): Make method call.
 670         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 671         (struct tui_source_window_base, struct tui_cmd_window): Override
 672         make_visible.
 673         (tui_win_is_source_type): Don't declare.
 674         * tui/tui-data.c (tui_win_is_source_type): Remove.
 675
 676 2019-06-25  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 679         NULL check.
 680
 681 2019-06-25  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 684         Inline constructor.  Add initializers for members.
 685         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 686         constructors; now inline in class.
 687
 688 2019-06-25  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-regs.c (tui_show_registers): Update.
 691         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 692         bool.
 693         * tui/tui-data.c (tui_data_window::clear_detail)
 694         (tui_data_window): Update.
 695
 696 2019-06-25  Tom Tromey  <tom@tromey.com>
 697
 698         * tui/tui-windata.c (tui_display_all_data)
 699         (tui_display_data_from_line, tui_display_data_from)
 700         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 701         Update.
 702         * tui/tui-regs.c (tui_last_regs_line_no)
 703         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 704         (tui_show_registers, tui_show_register_group)
 705         (tui_display_registers_from, tui_display_reg_element_at_line)
 706         (tui_display_registers_from_line, tui_check_register_values)
 707         (tui_reg_next, tui_reg_prev): Update.
 708         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 709         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 710         tui_data_window.
 711         (struct tui_win_info) <detail>: Remove.  Add new fields from
 712         tui_data_info.
 713         (TUI_DATA_WIN): Add cast.
 714         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 715         (~tui_data_window): Simplify.
 716
 717 2019-06-25  Tom Tromey  <tom@tromey.com>
 718
 719         * tui/tui-layout.c (show_source_disasm_command)
 720         (show_source_or_disasm_and_command): Update.
 721         * tui/tui-io.c (update_cmdwin_start_line)
 722         (tui_redisplay_readline): Update.
 723         * tui/tui-data.h (struct tui_command_info): Remove.
 724         (struct tui_win_info) <detail>: Remove command_info member.
 725         (struct tui_data_window) <start_line>: New member, from
 726         tui_command_info.
 727         (TUI_CMD_WIN): Add casts.
 728
 729 2019-06-25  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-winsource.c (tui_update_source_window)
 732         (tui_refill_source_window)
 733         (tui_source_window_base::do_scroll_horizontal)
 734         (tui_update_breakpoint_info, tui_set_exec_info_content)
 735         (tui_show_exec_info_content, tui_erase_exec_info_content)
 736         (tui_clear_exec_info_content): Update.
 737         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 738         Update.
 739         * tui/tui-win.c (make_invisible_and_set_new_height)
 740         (make_visible_with_new_height): Update.
 741         * tui/tui-source.c (tui_set_source_content)
 742         (tui_show_symtab_source): Update.
 743         * tui/tui-layout.c (extract_display_start_addr)
 744         (show_source_disasm_command, show_data)
 745         (make_source_or_disasm_window)
 746         (show_source_or_disasm_and_command): Update.
 747         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 748         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 749         "gdbarch".
 750         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 751         to tui_source_window_base.
 752         (struct tui_win_info) <detail>: Remove source_info member.
 753         (struct tui_source_window_base) <has_locator>: Inline.
 754         Move contents from tui_source_info; rename has_locator member to
 755         m_has_locator.
 756         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 757         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 758         header file.
 759         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 760         Simplify.
 761         (tui_free_all_source_wins_content): Cast to
 762         tui_source_window_base.
 763
 764 2019-06-25  Tom Tromey  <tom@tromey.com>
 765
 766         * tui/tui-win.c (make_invisible_and_set_new_height)
 767         (make_visible_with_new_height): Call has_locator method.
 768         * tui/tui-layout.c (show_source_disasm_command, show_data)
 769         (show_source_or_disasm_and_command): Update for bool change.
 770         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 771         (tui_win_info) <has_locator>: New method.
 772         (struct tui_source_window_base) <has_locator>: New method.
 773         (tui_win_has_locator): Don't declare.
 774         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 775         from tui_win_has_locator.
 776         (tui_source_window_base): Use false, not FALSE.
 777
 778 2019-06-25  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 781         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 782         clear_detail method directly.
 783         (tui_clear_win_detail): Remove.
 784
 785 2019-06-25  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 788         "this", not TUI_DISASM_WIN.
 789
 790 2019-06-25  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 793         declare.
 794         * tui/tui-winsource.c
 795         (tui_source_window_base::do_scroll_horizontal): Rename from
 796         tui_horizontal_source_scroll.
 797         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 798         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 799         from tui_vertical_data_scroll.
 800         * tui/tui-win.h (tui_scroll): Don't declare.
 801         * tui/tui-win.c (tui_win_info::forward_scroll)
 802         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 803         (tui_win_info::right_scroll): Rename and update.
 804         (tui_scroll_forward_command, tui_scroll_backward_command)
 805         (tui_scroll_left_command, tui_scroll_right_command): Update.
 806         (tui_scroll): Remove.
 807         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 808         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 809         from tui_vertical_source_scroll.
 810         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 811         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 812         from tui_vertical_disassem_scroll.
 813         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 814         do_scroll_horizontal>: New methods.
 815         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 816         Likewise.
 817         (struct tui_source_window_base): Add do_scroll_horizontal.
 818         (struct tui_source_window, struct tui_disasm_window): Add
 819         do_scroll_vertical.
 820         (struct tui_data_window, struct tui_cmd_window): Add
 821         do_scroll_horizontal and do_scroll_vertical.
 822         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 823
 824 2019-06-25  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-data.h (struct tui_source_window_base): New struct.
 827         (struct tui_source_window): Derive from tui_source_window_base.
 828         (struct tui_disasm_window): New struct.
 829         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 830         from tui_source_window::clear_detail.
 831         (tui_source_window_base): Rename from tui_source_window.
 832         (~tui_source_window_base): Rename from ~tui_source_window.
 833         (tui_alloc_win_info): Create a tui_disasm_window.
 834
 835 2019-06-25  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-data.h (struct tui_source_window)
 838         (struct tui_data_window): Declare destructors.
 839         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 840         destructors.
 841         (tui_win_info): Simplify.
 842
 843 2019-06-25  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-winsource.c (tui_display_main)
 846         (tui_update_source_windows_with_addr)
 847         (tui_update_all_breakpoint_info): Update.
 848         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 849         (new_height_ok, parse_scrolling_args): Update.
 850         * tui/tui-stack.c (tui_show_frame_info): Update.
 851         * tui/tui-data.h (struct tui_list): Remove.
 852         (tui_source_windows): Return a reference to a std::vector.
 853         * tui/tui-data.c (source_windows): Now a std::vector.
 854         (tui_source_windows): Change return type.
 855         (tui_clear_source_windows): Rewrite.
 856         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 857         (tui_free_all_source_wins_content): Rewrite.
 858
 859 2019-06-25  Tom Tromey  <tom@tromey.com>
 860
 861         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 862         (struct tui_data_window, struct tui_cmd_window): Declare
 863         clear_detail method.
 864         * tui/tui-data.c (tui_source_window::clear_detail)
 865         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 866         methods.
 867         (tui_clear_win_detail): Simplify.
 868
 869 2019-06-25  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-layout.c (make_source_window, make_disasm_window)
 872         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 873         Return the new window.
 874         (show_source_disasm_command, show_data)
 875         (show_source_or_disasm_and_command): Update.
 876
 877 2019-06-25  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 880         parameter.  Return the new window.
 881         (show_source_disasm_command): Update and remove NULL check.
 882         (show_source_or_disasm_and_command): Update.
 883
 884 2019-06-25  Tom Tromey  <tom@tromey.com>
 885
 886         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 887
 888 2019-06-25  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-data.h (struct tui_win_info): Make constructor
 891         protected.  Make destructor virtual.  Add initializers.
 892         (tui_source_window, tui_data_window, tui_cmd_window): New
 893         classes.
 894         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 895         constructor.  Add "type" parameter.
 896         (tui_source_window, tui_data_window, tui_cmd_window): New
 897         constructors.
 898         (tui_alloc_win_info): Instantiate the appropriate subclass.
 899
 900 2019-06-25  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-win.c (tui_resize_all): Use delete.
 903         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 904         destructor.
 905         (tui_free_window): Don't declare.
 906         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 907         Update.
 908
 909 2019-06-25  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-data.h (struct tui_win_info): Add constructor.
 912         * tui/tui-data.c (tui_alloc_win_info): Use new.
 913         (tui_free_window): Use delete.
 914
 915 2019-06-22  Tom Tromey  <tom@tromey.com>
 916
 917         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 918         declare.
 919         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 920
 921 2019-06-22  Tom Tromey  <tom@tromey.com>
 922
 923         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 924         declare.
 925         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 926
 927 2019-06-22  Tom de Vries  <tdevries@suse.de>
 928
 929         * dwarf2read.c (create_addrmap_from_aranges)
 930         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 931         instead of '%zu'.
 932
 933 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 934
 935         * dwarf2read.h (dwarf2_section_info_def): Remove.
 936         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 937         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 938         std::vector<dwarf2_section_info>.
 939         (struct dwo_file) <~dwo_file>: Remove.
 940         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 941         types field.
 942         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 943         (dwarf2_read_debug_names): Likewise.
 944         (create_debug_types_hash_table): Change parameter type to
 945         array_view, adjust code accordingly.
 946         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 947         (partial_die_info::fixup): Likewise.
 948         (determine_prefix): Likewise.
 949         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 950
 951 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 952
 953         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 954         gdb_bfd_ref_ptr.
 955         <~dwo_file>: Remove call to gdb_bfd_unref.
 956         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 957         gdb_bfd_ref_ptr::get.
 958
 959 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 960
 961         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 962         type to htab_up.
 963         * dwarf2read.c (struct dwo_file): Initialize fields.
 964         <~dwo_file>: New.
 965         (free_dwo_file): Remove, move content to ~dwo_file.
 966         (struct dwo_file_deleter): Remove.
 967         (dwo_file_up>: Remove custom deleter.
 968         (free_dwo_files): Remove.
 969         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 970         dwo_files.
 971         (process_skeletonless_type_units): Call unique_ptr::get.
 972         (allocate_dwo_file_hash_table): Add deleter to created hash
 973         table.  Change return type to htab_up.
 974         (lookup_dwo_file_slot): Don't memset dwo_file, call
 975         unique_ptr::get.
 976         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 977         (create_dwo_unit_in_dwp_v2): Likewise.
 978         (open_and_init_dwo_file): Likewise.
 979         (free_dwo_file_from_slot): Remove.
 980
 981 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 982
 983         * dwarf2read.h (struct dwarf2_section_info) <readin,
 984         is_virtual>: Change type to bool.
 985         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 986         true instead of 1.
 987
 988 2019-06-19  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-data.h (tui_init_content_element): Don't declare.
 991
 992 2019-06-19  Tom Tromey  <tom@tromey.com>
 993
 994         * tui/tui-data.h (tui_init_win_info): Don't declare.
 995
 996 2019-06-19  Tom de Vries  <tdevries@suse.de>
 997
 998         * dwarf2read.h (abstract_to_concrete): Change type to
 999         std::unordered_map<sect_offset, std::vector<sect_offset>,
1000         gdb::hash_enum<sect_offset>>.
1001
1002 2019-06-19  Tom Tromey  <tromey@adacore.com>
1003
1004         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1005         EVAL_AVOID_SIDE_EFFECTS specially.
1006
1007 2019-06-19  Tom Tromey  <tromey@adacore.com>
1008
1009         * source-cache.c (highlighter): New global.
1010         (source_cache::get_source_lines): Create a highlighter on demand.
1011
1012 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1013
1014         * defs.h (deprecated_interactive_hook): Delete declaration.
1015         * interps.c (clear_interpreter_hooks): Remove use of
1016         deprecated_interactive_hook.
1017         * top.c (deprecated_interactive_hook): Delete definition.
1018         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1019
1020 2019-06-18  Tom de Vries  <tdevries@suse.de>
1021
1022         PR gdb/24515
1023         * dwarf2read.h (abstract_to_concrete): Change type from
1024         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1025         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1026         * dwarf2read.c (read_variable): Update.
1027         (dwarf2_fetch_die_loc_sect_off): Update.
1028
1029 2019-06-17  Tom de Vries  <tdevries@suse.de>
1030
1031         PR gdb/24617
1032         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1033         accessing parent[parent_len - 1].
1034
1035 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1036
1037         PR gdb/24364
1038         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1039         call dtrace_process_dof with NULL dof.
1040
1041 2019-06-16  Tom de Vries  <tdevries@suse.de>
1042
1043         PR gdb/24445
1044         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1045
1046 2019-06-16  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1049         (make_all_visible): Use address of member.
1050
1051 2019-06-16  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1054         (tui_free_window, free_content, free_content_elements): Remove
1055         unnecessary cast.
1056         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1057         cast.
1058         * tui/tui-regs.c (tui_show_register_group)
1059         (tui_display_registers_from, tui_display_reg_element_at_line):
1060         Remove unnecessary cast.
1061
1062 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * linux-nat.c (normal_mask): Delete.
1065         (_initialize_linux_nat): Don't initialise normal_mask.
1066
1067 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1068
1069         PR gdb/24445
1070         * dwarf-index-write.h (write_psymtabs_to_index): Add
1071         dwz_basename parameter.
1072         * dwarf-index-write.c (write_gdbindex): Move file writing to
1073         write_gdbindex_1.  Change return type void.
1074         (assert_file_size): Move up, remove filename parameter.
1075         (write_gdbindex_1): New function.
1076         (write_debug_names): Change return type to void, call
1077         assert_file_size.
1078         (struct index_wip_file): New struct.
1079         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1080         file logic to index_wip_file.  Write index for dwz file if
1081         needed.
1082         (save_gdb_index_command): Pass basename of dwz file, if present.
1083         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1084         build-id of dwz file, if present.
1085         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1086         (dwarf2_get_dwz_file): Likewise.
1087         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1088         (dwarf2_get_dwz_file): Likewise.
1089
1090 2019-06-16  Tom Tromey  <tom@tromey.com>
1091
1092         * coffread.c (process_coff_symbol): Use xstrdup.
1093         * value.c (create_internalvar): Use xstrdup.
1094
1095 2019-06-16  Tom Tromey  <tom@tromey.com>
1096
1097         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1098         * breakpoint.c (stopin_command, stopat_command)
1099         (until_break_command, decode_location_default): Remove unnecessary
1100         cast.
1101         * utils.c (subset_compare): Remove unnecessary cast.
1102         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1103         cast.
1104         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1105         cast.
1106         * infcmd.c (path_command): Remove unnecessary cast.
1107         * coffread.c (decode_type): Remove unnecessary cast.
1108         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1109         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1110         * tui/tui-stack.c (tui_show_locator_content)
1111         (tui_show_frame_info): Remove unnecessary cast.
1112         * tui/tui-win.c (tui_scroll_forward_command)
1113         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1114         (parse_scrolling_args): Remove unnecessary cast.
1115         * tui/tui-data.c (init_win_info, tui_del_window)
1116         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1117         (free_content_elements): Remove unnecessary cast.
1118         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1119         unnecessary cast.
1120         * tui/tui-source.c (tui_set_source_content)
1121         (tui_vertical_source_scroll): Remove unnecessary cast.
1122         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1123         cast.
1124         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1125         * tui/tui-regs.c (tui_display_registers_from)
1126         (tui_display_register): Remove unnecessary cast.
1127         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1128         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1129         (make_visible): Remove unnecessary cast.
1130         * tui/tui-winsource.c (tui_erase_source_content)
1131         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1132         unnecessary cast.
1133         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1134         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1135         * stabsread.c (read_type, read_array_type, read_range_type):
1136         Remove unnecessary cast.
1137         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1138         (parse_symbol, parse_type, upgrade_type, parse_external)
1139         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1140         unnecessary cast.
1141         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1142
1143 2019-06-16  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-data.c (tui_alloc_generic_win_info)
1146         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1147         checks.
1148
1149 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1150             Andrew Burgess  <andrew.burgess@embecosm.com>
1151
1152         * f-typeprint.c (f_print_type): Don't return early for not
1153         associated or not allocated types.
1154         (f_type_print_varspec_suffix): Add print_rank parameter and print
1155         ranks of array types in case they dangling.
1156         (f_type_print_base): Add print_rank parameter.
1157
1158 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1159
1160         * NEWS: Mention new MI commands.
1161         * break-catch-throw.c (enum exception_event_kind): Move to
1162         breakpoint.h.
1163         (print_mention_exception_catchpoint): Output text as a single
1164         message.
1165         (catch_exception_command_1): Rename to...
1166         (catch_exception_event): ...this, make non-static, update header
1167         command, and change some parameter types.
1168         (catch_catch_command): Update for changes to
1169         catch_exception_command_1.
1170         (catch_throw_command): Likewise.
1171         (catch_rethrow_command): Likewise.
1172         * breakpoint.c (enum exception_event_kind): Delete.
1173         * breakpoint.h (enum exception_event_kind): Moved here from
1174         break-catch-throw.c.
1175         (catch_exception_event): Declare.
1176         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1177         (mi_cmd_catch_throw): New function.
1178         (mi_cmd_catch_rethrow): New function.
1179         (mi_cmd_catch_catch): New function.
1180         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1181         'catch-catch' entries.
1182         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1183         (mi_cmd_catch_rethrow): Declare.
1184         (mi_cmd_catch_catch): Declare.
1185
1186 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1187
1188         * annotate.c (annotate_source_line): Change return type to void,
1189         update implementation to match.
1190         * annotate.h (annotate_source_line): Change return type to void,
1191         update header comment.
1192         * stack.c (print_frame_info): Don't change what frame information
1193         is printed based on whether annotations are on or not.
1194
1195 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1196
1197         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1198         (annotate_source): Make static.
1199         (annotate_source_line): Moved from source.c and renamed from
1200         identify_source_line.  Update the return type.
1201         * annotate.h (annotate_source): Delete declaration.
1202         (annotate_source_line): Declaration moved from source.h, and
1203         renamed from identify_source_line.  Return type updated.
1204         * source.c (identify_source_line): Moved to annotate.c and renamed
1205         to annotate_source_line.
1206         (info_line_command): Remove check of annotation_level.
1207         * source.h (identify_source_line): Move declaration to annotate.h
1208         and rename to annotate_source_line.
1209         * stack.c: Add 'annotate.h' include.
1210         (print_frame_info): Remove check of annotation_level before
1211         calling annotate_source_line.
1212
1213 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1214
1215         * source-cache.c (source_cache::get_plain_source_lines): Use
1216         open_source_file_with_line_charpos instead of just
1217         open_source_file, remove call to find_source_lines.
1218         (source_cache::get_source_lines): Likewise.
1219         * source.c (find_source_lines): Make static.
1220         (get_filename_and_charpos): Renamed into...
1221         (open_source_file_with_line_charpos): ..this along with changes to
1222         return a scoped_fd, and some other minor clean ups.
1223         (identify_source_line): Use open_source_file_with_line_charpos.
1224         (search_command_helper): Use open_source_file_with_line_charpos
1225         instead of just open_source_file, remove call to
1226         find_source_lines.
1227         * source.h (open_source_file_with_line_charpos): Declare new
1228         function.
1229         (find_source_lines): Delete declaration.
1230
1231 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * source.c (get_filename_and_charpos): Remove fullname
1234         parameter.
1235         (identify_source_line): Update call to get_filename_and_charpos.
1236
1237 2019-06-14  Tom Tromey  <tromey@adacore.com>
1238
1239         PR gdb/24502:
1240         * ui-style.h (skip_ansi_escape): Update comment.
1241         * ui-file.h (class no_terminal_escape_file): New class.
1242         * ui-file.c (no_terminal_escape_file::write)
1243         (no_terminal_escape_file::puts): New methods.
1244         * cli/cli-logging.c (handle_redirections): Use
1245         no_terminal_escape_file.
1246
1247 2019-06-14  Tom Tromey  <tromey@adacore.com>
1248
1249         * NEWS: Move convenience variable news above Python news.
1250
1251 2019-06-14  Tom Tromey  <tom@tromey.com>
1252
1253         * gnulib: Move directory to top-level.
1254         * configure.ac: Don't configure gnulib.
1255         * configure: Rebuild.
1256         * common/common-defs.h: Use new path to gnulib.
1257         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1258         (GNULIB_H): Remove.
1259         (INCGNU): Look in new gnulib location.
1260         (HFILES_NO_SRCDIR): Remove gnulib files.
1261         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1262         (generated_files): Remove GNULIB_H.
1263         ($(LIBGNU), all-lib): Remove targets.
1264         (distclean): Don't mention GNULIB_BUILDDIR.
1265         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1266
1267 2019-06-14  Tom Tromey  <tromey@adacore.com>
1268
1269         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1270         Warn if symbol file does not provide any symbols.
1271
1272 2019-06-14  Tom Tromey  <tromey@adacore.com>
1273
1274         * source.c (find_and_open_source): Respect basenames_may_differ.
1275
1276 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1277
1278         * annotate.c (annotate_breakpoints_invalid): Make use of
1279         scoped_restore_terminal_state.
1280         (annotate_frames_invalid): Likewise.
1281
1282 2019-06-14  Tom Tromey  <tromey@adacore.com>
1283
1284         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1285         allow assignment to an internalvar.
1286
1287 2019-06-14  Tom Tromey  <tromey@adacore.com>
1288
1289         * ada-lex.l: Allow "_" in attribute names.
1290
1291 2019-06-14  Tom Tromey  <tromey@adacore.com>
1292
1293         PR gdb/24653:
1294         * regcache.c (registers_changed): Don't call alloca.
1295         * top.c (execute_command): Don't call alloca.
1296
1297 2019-06-13  Pedro Alves  <palves@redhat.com>
1298
1299         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1300         'expression'.  When parsing an expression, error out if there's
1301         junk after "unlimited".
1302         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1303         (do_set_command): Adjust calls to is_unlimited_literal.
1304
1305 2019-06-13  Pedro Alves  <palves@redhat.com>
1306
1307         * compile/compile.c (make_compile_options_def_group): Add braces
1308         around array_view initializer.
1309         * thread.c (make_thread_apply_all_options_def_group)
1310         (make_thread_apply_all_options_def_group): Likewise.
1311
1312 2019-06-13  Pedro Alves  <palves@redhat.com>
1313
1314         * NEWS (New commands): Mention "maint test-options
1315         require-delimiter", "maint test-options unknown-is-error", "maint
1316         test-options unknown-is-operand" and "maint show
1317         test-options-completion-result".
1318         (New command options, command completion): New section.
1319         (Completion improvements): New section.
1320         Mention that you can abbreviate "unlimited".
1321
1322 2019-06-13  Pedro Alves  <palves@redhat.com>
1323
1324         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1325         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1326         * unittests/cli-utils-selftests.c (test_parse_flags)
1327         (test_parse_flags_qcs): Delete.
1328         (test_cli_utils): Don't call deleted functions.
1329
1330 2019-06-13  Pedro Alves  <palves@redhat.com>
1331
1332         * thread.c: Include "cli/cli-option.h".
1333         (tp_array_compar_ascending): Global.
1334         (tp_array_compar): Delete function.
1335         (tp_array_compar_ascending, tp_array_compar_descending): New
1336         functions.
1337         (ascending_option_def, qcs_flag_option_def)
1338         (thr_qcs_flags_option_defs)
1339         (make_thread_apply_all_options_def_group)
1340         (make_thread_apply_options_def_group): New.
1341         (thread_apply_all_command): Use gdb::option::process_options.
1342         (thread_apply_command_completer)
1343         (thread_apply_all_command_completer): New.
1344         (thread_apply_command): Use gdb::option::process_options.
1345         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1346         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1347         to generate help text of "thread apply".  Adjust "taas"'s help.
1348         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1349         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1350
1351 2019-06-13  Pedro Alves  <palves@redhat.com>
1352
1353         * thread.c (thread_apply_command): Check for invalid TID with
1354         isdigit instead of !isalpha.
1355
1356 2019-06-13  Pedro Alves  <palves@redhat.com>
1357
1358         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1359         (validate_flags_qcs): New.
1360         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1361         (validate_flags_qcs): Declare.
1362         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1363         (make_frame_apply_options_def_group): New.
1364         (frame_apply_command_count): Process options with
1365         gdb::option::process_options.
1366         (frame_apply_completer): New.
1367         (frame_apply_level_completer, frame_apply_all_completer)
1368         (frame_apply_completer): New.
1369         (_initialize_stack): Update help of "frame apply", "frame apply
1370         level", "frame apply all" and "faas" to mention supported options
1371         and install command completers.
1372         * stack.h (frame_apply_all_completer): Declare.
1373         * thread.c: Include "stack.h".
1374         (tfaas_command): Add "--".
1375         (_initialize_thread): Update help "tfaas" to mention supported
1376         options and install command completer.
1377
1378 2019-06-13  Pedro Alves  <palves@redhat.com>
1379
1380         * completer.c (complete_nested_command_line): New.
1381         (gdb_completion_word_break_characters_throw): Add assertion.
1382         * completer.h (complete_nested_command_line): Declare.
1383
1384 2019-06-13  Pedro Alves  <palves@redhat.com>
1385
1386         * stack.c (parse_backtrace_qualifiers): New.
1387         (backtrace_command): Use it.
1388         (backtrace_command_completer): Complete on qualifiers.
1389
1390 2019-06-13  Pedro Alves  <palves@redhat.com>
1391
1392         * frame.c: Include "cli/cli-option.h.
1393         (user_set_backtrace_options): New.
1394         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1395         Delete.
1396         (get_prev_frame): Adjust.
1397         (boolean_option_def, uinteger_option_def)
1398         (set_backtrace_option_defs): New.
1399         (_initialize_frame): Adjust and use
1400         gdb::option::add_setshow_cmds_for_options to install "set
1401         backtrace past-main" and "set backtrace past-entry".
1402         * frame.h: Include "cli/cli-option.h".
1403         (struct frame_print_options): Forward declare.
1404         (print_frame_arguments_all, print_frame_arguments_scalars)
1405         (print_frame_arguments_none): Declare.
1406         (print_entry_values): Delete declaration.
1407         (struct frame_print_options, user_frame_print_options): New.
1408         (struct set_backtrace_options): New.
1409         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1410         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1411         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1412         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1413         (list_args_or_locals): Add frame_print_options parameter.
1414         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1415         * python/py-framefilter.c (enumerate_args): Pass down
1416         USER_FRAME_PRINT_OPTIONS.
1417         * stack.c: Include "cli/cli-option.h".
1418         (print_frame_arguments_all, print_frame_arguments_scalars)
1419         (print_frame_arguments_none): Declare.
1420         (print_raw_frame_arguments, print_entry_values): Delete.
1421         (user_frame_print_options): New.
1422         (boolean_option_def, enum_option_def, frame_print_option_defs):
1423         New.
1424         (struct backtrace_cmd_options): New.
1425         (bt_flag_option_def): New.
1426         (backtrace_command_option_defs): New.
1427         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1428         (print_frame_arg, read_frame_arg, print_frame_args)
1429         (print_frame_info, print_frame): Add frame_print_options parameter
1430         and use it.
1431         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1432         (backtrace_command_1): Add frame_print_options and
1433         backtrace_cmd_options parameters and use them.
1434         (make_backtrace_options_def_group): New.
1435         (backtrace_command): Process command options with
1436         gdb::option::process_options.
1437         (backtrace_command_completer): New.
1438         (_initialize_stack): Extend "backtrace"'s help to mention
1439         supported options.  Install completer for "backtrace".
1440         Install some settings commands with add_setshow_cmds_for_options.
1441
1442 2019-06-13  Pedro Alves  <palves@redhat.com>
1443
1444         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1445         and that "set/show print raw frame-arguments" are now deprecated.
1446
1447         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1448         command.
1449         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1450         * stack.c (_initialize_stack): Install "set/show print
1451         raw-frame-arguments", and deprecate "set/show print raw
1452         frame-arguments".
1453         * valprint.c (_initialize_valprint): Deprecate "set/show print
1454         raw".
1455
1456 2019-06-13  Pedro Alves  <palves@redhat.com>
1457
1458         * compile/compile.c (struct compile_options): New.
1459         (compile_flag_option_def, compile_command_option_defs)
1460         (make_compile_options_def_group): New.
1461         (compile_file_command): Handle options with
1462         gdb::option::process_options.
1463         (compile_file_command_completer): New function.
1464         (compile_code_command): Handle options with
1465         gdb::option::process_options.
1466         (compile_code_command_completer): New function.
1467         (_initialize_compiler): Install completers for "compile code" and
1468         "compile file".  Mention available options in "compile code" and
1469         "compile code"'s help.
1470         * completer.c (advance_to_completion_word): New, factored out from
1471         ...
1472         (advance_to_expression_complete_word_point): ... this.
1473         (advance_to_filename_complete_word_point): New.
1474         * completer.h (advance_to_filename_complete_word_point): New
1475         declaration.
1476
1477 2019-06-13  Pedro Alves  <palves@redhat.com>
1478
1479         * compile/compile.c: Include "cli/cli-option.h".
1480         (compile_print_value): Scope data pointer is now a
1481         value_print_options pointer; adjust.
1482         (compile_print_command): Process options.  Scope data pointer is
1483         now a value_print_options pointer; adjust.
1484         (_initialize_compile): Update "compile print"'s help to include
1485         supported options.  Install a completer for "compile print".
1486         * cp-valprint.c (show_vtblprint, show_objectprint)
1487         (show_static_field_print): Delete.
1488         (_initialize_cp_valprint): Don't install "set print
1489         static-members", "set print vtbl", "set print object" here.
1490         * printcmd.c: Include "cli/cli-option.h" and
1491         "common/gdb_optional.h".
1492         (print_command_parse_format): Rework to fill in a
1493         value_print_options instead of a format_data.
1494         (print_value): Change parameter type from format_data pointer to
1495         value_print_options reference.  Adjust.
1496         (print_command_1): Process options.  Adjust to pass down a
1497         value_print_options.
1498         (print_command_completer): New.
1499         (_initialize_printcmd): Install print_command_completer as
1500         handle_brkchars completer for the "print" command.  Update
1501         "print"'s help to include supported options.
1502         * valprint.c: Include "cli/cli-option.h".
1503         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1504         here from cp-valprint.c.
1505         (boolean_option_def, uinteger_option_def)
1506         (value_print_option_defs, make_value_print_options_def_group):
1507         New.  Use gdb::option::add_setshow_cmds_for_options to install
1508         "set print elements", "set print null-stop", "set print repeats",
1509         "set print pretty", "set print union", "set print array", "set
1510         print address", "set print symbol", "set print array-indexes".
1511         * valprint.h: Include <string> and "cli/cli-option.h".
1512         (make_value_print_options_def_group): Declare.
1513         (print_value): Change parameter type from format_data pointer to
1514         value_print_options reference.
1515         (print_command_completer): Declare.
1516
1517 2019-06-13  Pedro Alves  <palves@redhat.com>
1518
1519         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1520         (COMMON_SFILES): Add maint-test-settings.c.
1521         * cli/cli-decode.c (boolean_enums): New global, factored out from
1522         ...
1523         (add_setshow_boolean_cmd): ... here.
1524         * cli/cli-decode.h (boolean_enums): Declare.
1525         * cli/cli-option.c: New file.
1526         * cli/cli-option.h: New file.
1527         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1528         factored out from ...
1529         (parse_cli_boolean_value(const char *)): ... this.
1530         (is_unlimited_literal): Change parameter type to pointer to
1531         pointer.  Adjust and advance ARG pointer.
1532         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1533         (parse_cli_var_enum): New, factored out from ...
1534         (do_set_command): ... this.  Adjust.
1535         * cli/cli-setshow.h (parse_cli_boolean_value)
1536         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1537         (parse_cli_var_enum): Declare.
1538         * cli/cli-utils.c: Include "cli/cli-option.h".
1539         (get_ulongest): New.
1540         * cli/cli-utils.h (get_ulongest): Declare.
1541         (check_for_argument): New overloads.
1542         * maint-test-options.c: New file.
1543
1544 2019-06-13  Pedro Alves  <palves@redhat.com>
1545
1546         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1547         parse a range if "-" is at the end of the string.
1548
1549 2019-06-13  Pedro Alves  <palves@redhat.com>
1550
1551         * cli/cli-setshow.c (parse_auto_binary_operation)
1552         (parse_cli_boolean_value): Don't allow "o".
1553
1554 2019-06-13  Pedro Alves  <palves@redhat.com>
1555
1556         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1557         * NEWS: Mention maint test-settings KIND.
1558         * maint-test-settings.c: New file.
1559
1560 2019-06-13  Pedro Alves  <palves@redhat.com>
1561
1562         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1563         completer.
1564         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1565         "set" completers.
1566
1567 2019-06-13  Pedro Alves  <palves@redhat.com>
1568
1569         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1570         after item.
1571
1572 2019-06-13  Pedro Alves  <palves@redhat.com>
1573
1574         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1575
1576 2019-06-13  Pedro Alves <palves@redhat.com>
1577
1578         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1579         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1580         call.
1581         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1582         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1583         calls.
1584         (check_for_argument): Skip spaces after argument.
1585
1586 2019-06-13  Pedro Alves  <palves@redhat.com>
1587
1588         * thread.c (thread_apply_command): Adjust TID parsing.
1589         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1590         detected before end of string.
1591         (tid_is_in_list): Error out if LIST is invalid.
1592
1593 2019-06-13  Pedro Alves  <palves@redhat.com>
1594
1595         * completer.c (complete_line_internal_1): Rewind completion word
1596         point.
1597         (completion_tracker::advance_custom_word_point_by): Change
1598         parameter type to int.
1599         * completer.h (completion_tracker::advance_custom_word_point_by):
1600         Likewise.
1601
1602 2019-06-13  Pedro Alves  <palves@redhat.com>
1603
1604         * completer.c (advance_to_completion_word): Handle delimiters.
1605
1606 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1607
1608         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1609
1610 2019-06-11  Tom Tromey  <tom@tromey.com>
1611
1612         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1613         (xmalloc_failed): Move to alloc.c.
1614         * alloc.c: New file.
1615         * Makefile.in (COMMON_SFILES): Add alloc.c.
1616
1617 2019-06-11  Tom Tromey  <tom@tromey.com>
1618
1619         * nat/linux-waitpid.c: Don't include server.h.
1620         (linux_debug): Remove.
1621         (my_waitpid): Update.
1622
1623 2019-06-11  Tom Tromey  <tromey@adacore.com>
1624
1625         * infcall.c (_initialize_infcall): Remove trailing newline from
1626         help.
1627         * user-regs.c (_initialize_user_regs): Remove trailing newline
1628         from help.
1629         * typeprint.c (_initialize_typeprint): Remove trailing newline
1630         from help.
1631         * reverse.c (_initialize_reverse): Remove trailing newlines from
1632         help.
1633         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1634         from help.
1635         * language.c (add_set_language_command): Remove trailing newline
1636         from help.
1637         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1638         help.
1639         * disasm.c (_initialize_disasm): Remove trailing newline from
1640         help.
1641         * top.c (init_main): Remove trailing newline from help.
1642         * interps.c (_initialize_interpreter): Remove trailing newline
1643         from help.
1644         * btrace.c (_initialize_btrace): Remove trailing newlines from
1645         help.
1646         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1647         from help.
1648         * python/python.c (_initialize_python): Remove trailing newline
1649         from help.
1650         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1651         help.
1652         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1653         from help.  Reformat some text.
1654         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1655         from help.
1656         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1657         newline from help.
1658
1659 2019-06-11  Tom Tromey  <tromey@adacore.com>
1660
1661         * darwin-nat.c (darwin_decode_exception_message)
1662         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1663
1664 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1665
1666         * valops.c (value_slice): Check for not allocated or not
1667         associated values.
1668
1669 2019-06-10  Tom de Vries  <tdevries@suse.de>
1670
1671         PR gdb/24618
1672         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1673         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1674         invalid.
1675
1676 2019-06-10  Tom de Vries  <tdevries@suse.de>
1677
1678         PR gdb/24611
1679         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1680         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1681
1682 2019-06-10  Tom de Vries  <tdevries@suse.de>
1683
1684         PR symtab/24545
1685         * symtab.c (struct demangled_name_entry): Add language field.
1686         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1687         static minimal symbol".  Set and use language field.
1688
1689 2019-06-10  Tom Tromey  <tromey@adacore.com>
1690
1691         * ada-lang.c (_initialize_ada_language): Update help text.
1692
1693 2019-06-10  Tom Tromey  <tromey@adacore.com>
1694
1695         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1696         with a newline.
1697         * guile/guile.c (handle_boot_error): Don't end warning with a
1698         newline.
1699         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1700         warning with a newline.
1701         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1702         newline.
1703         (s12z_frame_cache): Likewise.
1704         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1705         a newline.
1706         * solib-svr4.c (disable_probes_interface): Don't end warning with
1707         a newline.
1708         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1709         newline.
1710         * python/python.c (do_finish_initialization): Don't end warning
1711         with a newline.
1712
1713 2019-06-10  Tom Tromey  <tom@tromey.com>
1714
1715         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1716         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1717         gdbpy_enter.
1718
1719 2019-06-10  Tom Tromey  <tromey@adacore.com>
1720
1721         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1722         data.
1723         (elf_new_init): Don't call stabsread_new_init.
1724         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1725         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1726         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1727
1728 2019-06-10  Tom de Vries  <tdevries@suse.de>
1729
1730         PR symtab/16264
1731         PR symtab/24517
1732         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1733
1734 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1735
1736         * source.c (find_and_open_source): Also rewrite relative file
1737         names.
1738
1739 2019-04-26  Amos Bird  <amosbird@gmail.com>
1740
1741         * annotate.c (annotate_thread_exited): Add "thread-exited"
1742         annotation.
1743
1744 2019-06-06  Tom Tromey  <tromey@adacore.com>
1745
1746         * maint.h (class scoped_command_stats): Use
1747         DISABLE_COPY_AND_ASSIGN.
1748         <print_time>: New method.
1749         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1750         print_time.
1751         (scoped_command_stats::print_time): New method.
1752
1753 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1754
1755         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1756         instructions of lengths 6 or 8 bytes.
1757
1758 2019-06-04  Pedro Alves  <palves@redhat.com>
1759
1760         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1761
1762         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1763         * breakpoint.c (condition_completer): Likewise.
1764         * cli/cli-dump.c (scan_expression): Likewise.
1765         * common/filestuff.c (mkdir_recursive): Likewise.
1766         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1767         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1768         (gdb_abspath): Likewise.
1769         * compile/compile-cplus-types.c
1770         (compile_cplus_instance::decl_name): Likewise.
1771         * completer.c (complete_explicit_location):
1772         (signal_completer, reg_or_group_completer_1): Likewise.
1773         * cp-support.c (cp_remove_params_if_any): Likewise.
1774         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1775         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1776         * infcmd.c (strip_bg_char): Likewise.
1777         * linespec.c (copy_token_string): Likewise.
1778         * mi/mi-main.c (output_cores): Likewise.
1779         * psymtab.c (psymtab_search_name):
1780         * symfile.c (test_set_ext_lang_command): Likewise.
1781         * target.c (target_fileio_read_stralloc): Likewise.
1782         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1783         * value.c (complete_internalvar): Likewise.
1784
1785 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1786
1787         Add objfile property to gdb.Type.
1788         * NEWS: Mention Python API addition.
1789         * python/py-type.c (typy_get_objfile): New method.
1790
1791 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1792
1793         * NEWS: Mention the new set|show style [title|highlight].
1794         Mention changes to "show style", "help" and "apropos".
1795
1796 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1797
1798         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1799         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1800         instead of print_help_for_command.
1801         (print_doc_of_command): New function.
1802         (help_list): Add 'apropos -v word' suggestion.
1803         (print_help_for_command): Style the command name using title style.
1804         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1805         (_initialize_cli_cmds): Describe -v in apropos_command help.
1806
1807 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1808
1809         * cli/cli-style.h (cli_style_option): Add name in constructor,
1810         add m_name class member, add constructor with intensity,
1811         add name class function.
1812         (cli_style_option::add_setshow_commands): Remove name argument.
1813         (highlight_style, title_style): New styles.
1814         * cli/cli-style.c (do_show): New function that shows a style
1815         characteristic styling the style name with itself.
1816         (set_style_name): New function.
1817         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1818         Update all callers according to the changes in cli/cli-style.h.
1819         * utils.h (fputs_highlighted): New function.
1820         * utils.c (fputs_highlighted): Likewise.
1821
1822 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1823
1824         * NEWS: Mention new pipe command and new convenience variables.
1825
1826 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1827
1828         * cli/cli-cmds.c (pipe_command): New function.
1829         (_initialize_cli_cmds): Call add_com for pipe_command.
1830         Define | as an alias for pipe.
1831         (exit_status_set_internal_vars): New function.
1832         (shell_escape): Call exit_status_set_internal_vars.
1833         cli/cli-decode.c (find_command_name_length): Recognize | as
1834         a single character command.
1835
1836 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1837
1838         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1839         top.c (execute_command_to_ui_file): New function, mostly a copy
1840         of execute_command_to_string.
1841         (execute_command_to_string): Implement by calling
1842         execute_command_to_ui_file.
1843
1844 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1845
1846         * top.h (saved_command_line): Remove declaration.
1847         * top.c (previous_saved_command_line, previous_repeat_arguments):
1848         New variables.
1849         (saved_command_line): Make static, define together with other
1850         'repeat variables'.
1851         (dont_repeat): Clear repeat_arguments.
1852         (repeat_previous, get_saved_command_line, save_command_line):
1853         New functions.
1854         (gdb_init): Initialize saved_command_line
1855         and previous_saved_command_line.
1856         * main.c (captured_main_1): Remove saved_command_line initialization.
1857         * event-top.c (handle_line_of_input): Update to use
1858         the new 'repeat' related functions instead of direct access to
1859         saved_command_line.
1860         * command.h (repeat_previous, get_saved_command_line,
1861         save_command_line): New declarations.
1862         (dont_repeat): Add comment.
1863
1864 2019-05-30  Tom Tromey  <tromey@adacore.com>
1865
1866         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1867         Fix comment.
1868         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1869
1870 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1871
1872         PR cli/24587
1873         * completer.c (complete): Initialize variable word.
1874
1875 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1876
1877         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1878         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1879         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1880         'body' is NULL to the outter 'if', protecting the '!is_define'
1881         situation as well.
1882
1883 2019-05-29  Tom Tromey  <tromey@adacore.com>
1884
1885         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1886         (dwarf_unknown): New function.
1887         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1888         (dwarf_type_encoding_name): Use dwarf_unknown.
1889
1890 2019-05-29  Tom Tromey  <tromey@adacore.com>
1891
1892         PR c++/20020:
1893         * cp-valprint.c (cp_print_value_fields): Call
1894         cp_print_static_field inside "try".
1895
1896 2019-05-29  Tom Tromey  <tromey@adacore.com>
1897
1898         * inflow.c (struct terminal_info): Add default operator=.
1899         * configure: Rebuild.
1900         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1901         -Wdeprecated-copy-dtor, -Wredundant-move.
1902
1903 2019-05-29  Tom Tromey  <tromey@adacore.com>
1904
1905         * NEWS: Add entry.
1906         * infcmd.c (print_return_value_1): Handle finish_print
1907         option.
1908         (show_print_finish): New function.
1909         (_initialize_infcmd): Add "set/show print finish" commands.
1910         * valprint.c (user_print_options): Initialize new member.
1911         * valprint.h (struct value_print_options) <finish_print>: New
1912         member.
1913
1914 2019-05-28  Tom Tromey  <tromey@adacore.com>
1915
1916         * ada-lang.c (ada_remove_Xbn_suffix)
1917         (find_old_style_renaming_symbol)
1918         (parse_old_style_renaming): Remove.
1919         (ada_find_renaming_symbol): Don't call
1920         find_old_style_renaming_symbol.
1921         (ada_is_renaming_symbol): Rename from
1922         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1923         bool.  Now static.
1924         (ada_read_var_value): Update and simplify.
1925         * ada-exp.y (write_var_or_type): Remove old code.
1926
1927 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1928
1929         * event-top.c: Remove include comment.
1930         * inflow.c (class scoped_ignore_sigttou): Move from here...
1931         * inflow.h (class scoped_ignore_sigttou): ...to here.
1932         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1933         * top.c:  Remove include comment.
1934
1935 2019-05-27  Tom Tromey  <tom@tromey.com>
1936
1937         * NEWS: Fix typo.
1938
1939 2019-05-22  Tom Tromey  <tromey@adacore.com>
1940
1941         * target.c (target_follow_exec): Constify parameter.
1942         * target-delegates.c: Rebuild.
1943         * remote.c (remote_target::follow_exec): Constify parameter.
1944         * infrun.c (follow_exec): Constify parameter.
1945         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1946         (target_follow_exec): Likewise.
1947
1948 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1949
1950         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1951         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1952
1953 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1954
1955         * NEWS: Add debugredirect and testsuite sections.
1956
1957 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1958
1959         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1960         target descriptions using exclusively floating point register name
1961         aliases.
1962
1963 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1964
1965         PR gdb/18644:
1966         * f-lang.c (build_fortran_types): Handle the case where
1967         gdbarch_floatformat_for_type returns a nullptr.
1968
1969 2019-05-21  Tom de Vries  <tdevries@suse.de>
1970
1971         PR cli/24587
1972         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1973
1974 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         PR gdb/18644:
1977         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1978         16-byte floats.
1979         * i386-tdep.c (i386_floatformat_for_type): Use
1980         floatformats_ia64_quad for the 16-byte floating point component
1981         within a fortran 32-byte complex number.
1982
1983 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1984
1985         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1986         delete default constructor.
1987         (find_partial_die): Update to return const struct.
1988         (partial_die_parent_scope): Move variable declaration into scope
1989         of its use and change its type to auto.
1990         (guess_partial_die_structure_name): Likewise.
1991         (partial_die_info::fixup): Likewise.
1992
1993 2019-05-17  Tom Tromey  <tromey@adacore.com>
1994
1995         * source.c (find_and_open_source): Remove cast.
1996
1997 2019-05-17  Tom Tromey  <tromey@adacore.com>
1998
1999         * annotate.c (annotate_source): Make "filename" const.
2000         * annotate.h (annotate_source): Use const.
2001
2002 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2003
2004         * disasm.c (set_disassembler_options): Send errors to stderr.
2005
2006 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2007
2008         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2009         (cli_interp_base::set_logging): Check debug_redirect.
2010         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2011         * cli/cli-logging.c (debug_redirect): Add static variable.
2012         (pop_output_files): Add default param.
2013         (handle_redirections): Print debug setting.
2014         (show_logging_command): Likewise.
2015         (_initialize_cli_logging): Add debugredirect command.
2016         * interps.c (current_interp_set_logging): Add debug_redirect
2017         parameter.
2018         * interps.h (set_logging): Add debug_redirect parameter.
2019         (current_interp_set_logging): Likewise.
2020         * mi/mi-common.h: Likewise.
2021         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2022
2023 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2024             Tom Tromey  <tromey@adacore.com>
2025
2026         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2027         directly.
2028         * cli/cli-interp.h (make_logging_output): Remove declaration.
2029         * cli/cli-logging.c (make_logging_output): Remove function.
2030         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2031         directly.
2032         * ui-file.c (tee_file::tee_file): Remove bools.
2033         (tee_file::~tee_file): Remove deletes.
2034         * ui-file.h (tee_file): Remove bools.
2035
2036 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2037
2038         * mi/mi-cmds.h (mi_cmd_complete): New function.
2039         * mi/mi-main.c (mi_cmd_complete): Likewise.
2040         * mi/mi-cmds.c: Define new MI command -complete.
2041         * NEWS: Mention new -complete command.
2042
2043 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2044
2045         * completer.h (complete): New function.
2046         * completer.c (complete): Likewise.
2047         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2048         function defined in completer.h.
2049
2050 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2051
2052         * MAINTAINERS (Write After Approval): Add myself.
2053
2054 2019-05-17  Tom de Vries  <tdevries@suse.de>
2055
2056         PR gdb/24094
2057         * dwarf2read.c (struct cu_partial_die_info): New struct.
2058         (find_partial_die): Return cu_partial_die_info.
2059         (partial_die_parent_scope, guess_partial_die_structure_name)
2060         (partial_die_info::fixup): Handle new return type of find_partial_die.
2061
2062 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2063
2064         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2065         "std::string", simplifying the algorithm.
2066
2067 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2068
2069         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2070         (stap_static_probe_ops::get_probes): Likewise.
2071
2072 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2073
2074         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2075         '-')" and "else if".
2076         (stap_parse_single_operand): Join checks for
2077         "gdbarch_stap_parse_special_token_p" and
2078         "gdbarch_stap_parse_special_token" in the same "if" statement.
2079         Invert check when verifying for operation on register
2080         displacement.
2081
2082 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2083
2084         * stap-probe.c (stap_get_opcode): Update comment.
2085         (stap_get_expected_argument_type): Likewise.
2086         (handle_stap_probe): Likewise.
2087
2088 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2089
2090         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2091         return type to 'bool'.  Adjust comment.  Use 'bool' when
2092         appropriate.
2093         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2094         * stap-probe.c (stap_parse_argument_1): Likewise.
2095         (stap_is_operator): Likewise.
2096         (stap_is_generic_prefix): Likewise.
2097         (stap_is_register_prefix): Likewise.
2098         (stap_is_register_indirection_prefix): Likewise.
2099         (stap_is_integer_prefix): Likewise.
2100         (stap_generic_check_suffix): Likewise.
2101         (stap_check_integer_suffix): Likewise.
2102         (stap_check_register_suffix): Likewise.
2103         (stap_check_register_indirection_suffix): Likewise.
2104         (stap_parse_register_operand): Likewise.
2105         (stap_parse_single_operand): Likewise.
2106         (stap_parse_argument_1): Likewise.
2107         (stap_probe::get_argument_count): Likewise.
2108         (stap_is_operator): Likewise.
2109
2110 2019-05-16  Tom Tromey  <tromey@adacore.com>
2111
2112         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2113         keyword to foreach.
2114
2115 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2116
2117         * linux-thread-db.c (try_thread_db_load_1): Change return type
2118         to bool.
2119         (try_thread_db_load): Likewise.
2120         (try_thread_db_load_from_pdir_1): Likewise.
2121         (try_thread_db_load_from_pdir): Likewise.
2122         (try_thread_db_load_from_sdir): Likewise.
2123         (try_thread_db_load_from_dir): Likewise.
2124         (thread_db_load_search): Likewise.
2125         (has_libpthread): Likewise.
2126         (thread_db_load): Likewise.
2127
2128 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2129
2130         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2131         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2132         NULL, and complain/return if that's the case.
2133
2134 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2135
2136         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2137         (advance, posn, abstract_read_memory): New functions.
2138         [struct mem_read_abstraction]: New struct.
2139         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2140
2141 2019-05-14  Tom Tromey  <tromey@adacore.com>
2142
2143         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2144         value is not lval_memory.
2145
2146 2019-05-14  Tom Tromey  <tromey@adacore.com>
2147
2148         * solib.c (info_sharedlibrary_command): Style the file name.
2149
2150 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2151
2152         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2153         (aarch64_vnv_type): Likewise.
2154         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2155         * common/tdesc.c: Likewise.
2156         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2157         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2158         * features/aarch64-fpu.xml: Add ieee half view.
2159         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2160         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2161         * gdbtypes.h (struct builtin_type): Likewise.
2162         (struct objfile_type): Likewise.
2163
2164 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2165
2166         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2167         typo.
2168         * location.h (string_to_event_location): Likewise.
2169
2170 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2171
2172         GDB 8.3 released.
2173
2174 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2175
2176         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2177         New variable declaration.
2178         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2179         New variable.
2180         (print_one_breakpoint): Use ui_out::test_flags and new global
2181         variable to compute use_fixed_output.
2182         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2183         Remove.
2184         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2185         (mi_multi_location_breakpoint_output_fixed): Remove.
2186         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2187         new variable.
2188         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2189         fix_multi_location_breakpoint_output flag if version >= 3.
2190         * ui-out.h (enum ui_out_flag)
2191         <fix_multi_location_breakpoint_output>: New enumerator.
2192
2193 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2194
2195         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2196
2197 2019-05-10  Tom Tromey  <tromey@adacore.com>
2198
2199         * ada-lang.c (catch_ada_completer): New function.
2200         (_initialize_ada_language): Use it.
2201
2202 2019-05-10  Tom Tromey  <tromey@adacore.com>
2203
2204         * thread.c (print_thread_info): Make "requested_threads" const.
2205         * gdbthread.h (print_thread_info): Make "requested_threads"
2206         const.
2207         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2208         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2209
2210 2019-05-08  Tom Tromey  <tom@tromey.com>
2211
2212         * gdbtypes.c (objfile_type_data): Change type.
2213         (objfile_type, _initialize_gdbtypes): Update.
2214
2215 2019-05-08  Tom Tromey  <tom@tromey.com>
2216
2217         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2218         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2219         (_initialize_dwarf2_frame): Update.
2220
2221 2019-05-08  Tom Tromey  <tom@tromey.com>
2222
2223         * objc-lang.c (objc_objfile_data): Change type.
2224         (find_methods): Update.
2225         (_initialize_objc_lang): Remove.
2226
2227 2019-05-08  Tom Tromey  <tom@tromey.com>
2228
2229         * stabsread.c (rs6000_builtin_type_data): Change type.
2230         (rs6000_builtin_type, _initialize_stabsread): Update.
2231
2232 2019-05-08  Tom Tromey  <tom@tromey.com>
2233
2234         * mips-tdep.c (mips_pdr_data): Remove.
2235         (_initialize_mips_tdep): Update.
2236
2237 2019-05-08  Tom Tromey  <tom@tromey.com>
2238
2239         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2240         (hppa_init_objfile_priv_data, read_unwind_info)
2241         (find_unwind_entry, _initialize_hppa_tdep): Update.
2242
2243 2019-05-08  Tom Tromey  <tom@tromey.com>
2244
2245         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2246         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2247         on obstack.
2248         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2249
2250 2019-05-08  Tom Tromey  <tom@tromey.com>
2251
2252         * mdebugread.c (basic_type_data): Change type.
2253         (basic_type, _initialize_mdebugread): Update.
2254
2255 2019-05-08  Tom Tromey  <tom@tromey.com>
2256
2257         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2258
2259 2019-05-08  Tom Tromey  <tom@tromey.com>
2260
2261         * nto-tdep.c (nto_inferior_data_reg): Change type.
2262         (nto_inferior_data): Update.
2263         (nto_inferior_data_cleanup, nto_new_inferior_data)
2264         (_initialize_nto_tdep): Remove.
2265         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2266
2267 2019-05-08  Tom Tromey  <tom@tromey.com>
2268
2269         * ada-lang.c (struct ada_inferior_data): Add initializers.
2270         (ada_inferior_data): Change type.
2271         (ada_inferior_data_cleanup): Remove.
2272         (get_ada_inferior_data, ada_inferior_exit)
2273         (struct ada_pspace_data): Add initializers, destructor.
2274         (ada_pspace_data_handle): Change type.
2275         (get_ada_pspace_data): Update.
2276         (ada_pspace_data_cleanup): Remove.
2277
2278 2019-05-08  Tom Tromey  <tom@tromey.com>
2279
2280         * coffread.c (struct coff_symfile_info): Add initializers.
2281         (coff_objfile_data_key): Move lower.  Change type.
2282         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2283         Update.
2284         (coff_free_info): Remove.
2285
2286 2019-05-08  Tom Tromey  <tom@tromey.com>
2287
2288         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2289         (fbsd_pspace_data_handle): Move lower.  Change type.
2290         (get_fbsd_pspace_data): Update.
2291         (fbsd_pspace_data_cleanup): Remove.
2292         (_initialize_fbsd_tdep): Update.
2293
2294 2019-05-08  Tom Tromey  <tom@tromey.com>
2295
2296         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2297         (get_ada_tasks_pspace_data): Update.
2298         (ada_tasks_pspace_data_cleanup): Remove.
2299         (_initialize_tasks): Update.
2300         (ada_tasks_inferior_data_handle): Change type.
2301         (get_ada_tasks_inferior_data): Update.
2302         (ada_tasks_inferior_data_cleanup): Remove.
2303         (struct ada_tasks_pspace_data): Add initializers.
2304
2305 2019-05-08  Tom Tromey  <tom@tromey.com>
2306
2307         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2308         * symfile-debug.c (debug_sym_get_probes): Change type.
2309         * stap-probe.c (handle_stap_probe):
2310         (stap_static_probe_ops::get_probes): Change type.
2311         * probe.h (class static_probe_ops) <get_probes>: Change type.
2312         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2313         (parse_probes_in_pspace): Update.
2314         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2315         Update.
2316         (any_static_probe_ops::get_probes): Change type.
2317         * elfread.c (elfread_data): New typedef.
2318         (probe_key): Change type.
2319         (elf_get_probes): Likewise.  Update.
2320         (probe_key_free): Remove.
2321         (_initialize_elfread): Update.
2322         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2323         Change type.
2324         (dtrace_process_dof_probe, dtrace_process_dof)
2325         (dtrace_static_probe_ops::get_probe): Change type.
2326
2327 2019-05-08  Tom Tromey  <tom@tromey.com>
2328
2329         * xcoffread.c (struct xcoff_symfile_info): Rename from
2330         coff_symfile_info.  Add initializers.
2331         (xcoff_objfile_data_key): Move lower.  Change type.
2332         (XCOFF_DATA): Rewrite.
2333         (xcoff_free_info): Remove.
2334         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2335         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2336         (xcoff_initial_scan): Update.
2337
2338 2019-05-08  Tom Tromey  <tom@tromey.com>
2339
2340         * solib-svr4.c (struct svr4_info): Add initializers and
2341         destructor.
2342         <probes_table>: Now an htab_up.
2343         (solib_svr4_pspace_data): Change type.
2344         (free_probes_table): Simplify.
2345         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2346         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2347         (probes_table_remove_objfile_probes, register_solib_event_probe)
2348         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2349         (_initialize_svr4_solib): Update.
2350
2351 2019-05-08  Tom Tromey  <tom@tromey.com>
2352
2353         * remote.c (remote_pspace_data): Change type.
2354         (remote_pspace_data_cleanup): Remove.
2355         (get_remote_exec_file, set_pspace_remote_exec_file)
2356         (_initialize_remote): Update.
2357
2358 2019-05-08  Tom Tromey  <tom@tromey.com>
2359
2360         * breakpoint.c (breakpoint_objfile_key): Change type.
2361         (get_breakpoint_objfile_data): Update.
2362         (free_breakpoint_objfile_data): Remove.
2363         (_initialize_breakpoint): Update.
2364
2365 2019-05-08  Tom Tromey  <tom@tromey.com>
2366
2367         * linux-tdep.c (struct linux_info): Add initializers.
2368         (linux_inferior_data): Move.  Change type.
2369         (invalidate_linux_cache_inf): Update.
2370         (linux_inferior_data_cleanup): Remove.
2371         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2372
2373 2019-05-08  Tom Tromey  <tom@tromey.com>
2374
2375         * auxv.c (auxv_inferior_data): Move.  Change type.
2376         (auxv_inferior_data_cleanup): Remove.
2377         (invalidate_auxv_cache_inf): Rewrite.
2378         (get_auxv_inferior_data, _initialize_auxv): Update.
2379
2380 2019-05-08  Tom Tromey  <tom@tromey.com>
2381
2382         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2383         (symfile_debug_objfile_data_key): Change type.
2384         (symfile_debug_installed, debug_qf_has_symbols)
2385         (debug_qf_find_last_source_symtab)
2386         (debug_qf_forget_cached_source_info)
2387         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2388         (debug_qf_print_stats, debug_qf_dump)
2389         (debug_qf_expand_symtabs_for_function)
2390         (debug_qf_expand_all_symtabs)
2391         (debug_qf_expand_symtabs_with_fullname)
2392         (debug_qf_map_matching_symbols)
2393         (debug_qf_expand_symtabs_matching)
2394         (debug_qf_find_pc_sect_compunit_symtab)
2395         (debug_qf_map_symbol_filenames)
2396         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2397         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2398         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2399         (debug_sym_read_linetable, debug_sym_relocate): Update.
2400         (symfile_debug_free_objfile): Remove.
2401         (install_symfile_debug_logging, _initialize_symfile_debug):
2402         Update.
2403
2404 2019-05-08  Tom Tromey  <tom@tromey.com>
2405
2406         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2407         allocate_on_obstack.
2408         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2409         (get_dwarf2_per_objfile): Update.
2410         (set_dwarf2_per_objfile): Remove.
2411         (dwarf2_has_info, dwarf2_get_section_info): Update.
2412         (dwarf2_free_objfile): Remove.
2413         (_initialize_dwarf2_read): Update.
2414
2415 2019-05-08  Tom Tromey  <tom@tromey.com>
2416
2417         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2418         initializers.
2419         <unsupported_script_warning_printed,
2420         script_not_found_warning_printed>: Now bool.
2421         (auto_load_pspace_data): Change type.
2422         (~auto_load_pspace_info): Rename from
2423         auto_load_pspace_data_cleanup.
2424         (get_auto_load_pspace_data, init_loaded_scripts_info)
2425         (clear_section_scripts, maybe_print_unsupported_script_warning)
2426         (maybe_print_script_not_found_warning, _initialize_auto_load):
2427         Update.
2428
2429 2019-05-08  Tom Tromey  <tom@tromey.com>
2430
2431         * objfiles.c (objfile_pspace_info): Add destructor and
2432         initializers.
2433         (objfiles_pspace_data): Change type.
2434         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2435         (get_objfile_pspace_data): Update.
2436         (objfiles_bfd_data): Change type.
2437         (get_objfile_bfd_data): Update.
2438         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2439
2440 2019-05-08  Tom Tromey  <tom@tromey.com>
2441
2442         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2443         Change type.
2444         (get_catch_syscall_inferior_data): Update.
2445         (catch_syscall_inferior_data_cleanup): Remove.
2446         (_initialize_break_catch_syscall): Update.
2447
2448 2019-05-08  Tom Tromey  <tom@tromey.com>
2449
2450         * inflow.c (struct terminal_info): Add destructor and
2451         initializers.
2452         (inflow_inferior_data): Change type.
2453         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2454         (get_inflow_inferior_data, inflow_inferior_exit)
2455         (swap_terminal_info, _initialize_inflow): Update.
2456
2457 2019-05-08  Tom Tromey  <tom@tromey.com>
2458
2459         * target-dcache.c (target_dcache_cleanup): Remove.
2460         (target_dcache_aspace_key): Change type.
2461         (target_dcache_init_p, target_dcache_invalidate)
2462         (target_dcache_get, target_dcache_get_or_init)
2463         (_initialize_target_dcache): Update.
2464         * dcache.h (struct dcache_deleter): New.
2465
2466 2019-05-08  Tom Tromey  <tom@tromey.com>
2467
2468         * symtab.c (struct symbol_cache): Add destructor and
2469         initializers.
2470         (symbol_cache_key): Move.  Change type.
2471         (make_symbol_cache, free_symbol_cache): Remove.
2472         (get_symbol_cache): Update.
2473         (symbol_cache_cleanup): Remove.
2474         (ALL_PSPACES, symbol_cache_flush)
2475         (maintenance_print_symbol_cache)
2476         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2477         Update.
2478
2479 2019-05-08  Tom Tromey  <tom@tromey.com>
2480
2481         * symtab.c (struct main_info): Add destructor and initializers.
2482         (main_progspace_key): Move.  Change type.
2483         (get_main_info): Update.
2484         (main_info_cleanup): Remove.
2485         (_initialize_symtab): Update.
2486
2487 2019-05-08  Tom Tromey  <tom@tromey.com>
2488
2489         * registry.h (DECLARE_REGISTRY): Define the _key class.
2490
2491 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2492
2493         * NEWS: Merge two 'New commands' sections.
2494
2495 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2496
2497         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2498         parameter and use Ada language definition instead.
2499         (ada_val_print_ptr): Remove unused language parameter.
2500         (ada_val_print_num): Remove language parameter and use Ada language
2501         definition instead.
2502         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2503         parameter.
2504         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2505         parameter and use Ada language definition instead.
2506         (ada_val_print_1): Update all ada_val_print_xxx calls.
2507         Remove language parameter.
2508         (ada_val_print): Update ada_val_print_1 call.
2509
2510 2019-05-08  Tom Tromey  <tromey@adacore.com>
2511
2512         * remote.c (remote_hw_watchpoint_limit)
2513         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2514         Now static.
2515
2516 2019-05-08  Tom Tromey  <tromey@adacore.com>
2517
2518         * maint.c (_initialize_maint_cmds): Move initialization code to
2519         remote.c.
2520         (watchdog, show_watchdog): Move to remote.c.
2521         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2522         "watchdog" static.
2523         (_initialize_remote): Move initialization code from maint.c.
2524         * defs.h (watchdog): Don't declare.
2525
2526 2019-05-08  Tom Tromey  <tromey@adacore.com>
2527
2528         * tui/tui-interp.c: Include main.h.
2529         * interps.c: Include main.h.
2530         * main.h (interpreter_p): Declare.
2531         * defs.h (interpreter_p): Don't declare.
2532
2533 2019-05-08  Tom Tromey  <tromey@adacore.com>
2534
2535         * dwarf2loc.c: Include dwarf2read.h.
2536         * defs.h (read_unsigned_leb128): Don't declare.
2537         * dwarf2read.h (read_unsigned_leb128): Declare.
2538
2539 2019-05-08  Tom Tromey  <tromey@adacore.com>
2540
2541         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2542         method.
2543
2544 2019-05-08  Tom Tromey  <tromey@adacore.com>
2545
2546         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2547         when no wrap column is set.
2548
2549 2019-05-08  Tom Tromey  <tromey@adacore.com>
2550
2551         * c-lang.c (c_get_string): Handle non-C-style arrays.
2552
2553 2019-05-08  Tom Tromey  <tromey@adacore.com>
2554
2555         * typeprint.c (print_offset_data::update): Print the bit offset,
2556         not the number of bits remaining.
2557
2558 2019-05-08  Tom Tromey  <tromey@adacore.com>
2559
2560         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2561         padding at end of comment.
2562
2563 2019-05-08  Tom Tromey  <tromey@adacore.com>
2564
2565         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2566         Compare main types.
2567
2568 2019-05-06  Tom Tromey  <tom@tromey.com>
2569
2570         * common/scoped_mmap.c: Include common-defs.h.
2571         * common/scoped_mmap.h: Don't include config.h.
2572
2573 2019-05-04  Tom Tromey  <tom@tromey.com>
2574
2575         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2576         (struct aarch64_call_info): Add initializers.
2577         <si>: Now a std::vector.
2578         (pass_on_stack, aarch64_push_dummy_call): Update.
2579
2580 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2581             Tom Tromey  <tom@tromey.com>
2582
2583         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2584         (ppc_threads): Now a std::vector.  Now static.
2585         (hwdebug_find_thread_points_by_tid)
2586         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2587         Update.
2588
2589 2019-05-04  Tom Tromey  <tom@tromey.com>
2590
2591         * arc-tdep.c (arc_tdesc_init): Return bool.
2592
2593 2019-05-04  Tom Tromey  <tom@tromey.com>
2594
2595         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2596         Use gdb_assert_not_reached.
2597
2598 2019-05-04  Tom Tromey  <tom@tromey.com>
2599
2600         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2601         "false".
2602
2603 2019-05-04  Tom Tromey  <tom@tromey.com>
2604
2605         * arc-tdep.c (arc_tdesc_init): Use bool.
2606
2607 2019-05-04  Tom Tromey  <tom@tromey.com>
2608
2609         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2610
2611 2019-05-04  Tom Tromey  <tom@tromey.com>
2612
2613         * cli/cli-cmds.c (valid_command_p): Return bool.
2614
2615 2019-05-04  Tom Tromey  <tom@tromey.com>
2616
2617         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2618         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2619
2620 2019-05-04  Raul Tambre  <raul@tambre.ee>
2621
2622         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2623         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2624         operator for comparison.
2625
2626 2019-05-04  Tom Tromey  <tom@tromey.com>
2627
2628         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2629         (lookup_partial_symbol, print_partial_symbols)
2630         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2631         (psymbol_compare): Update.
2632         (add_psymbol_to_bcache): Clear the entire psymbol.
2633         (maintenance_check_psymtabs): Update.
2634         * psympriv.h (struct partial_symbol): Don't derive from
2635         general_symbol_info.
2636         <obj_section, unrelocated_address, address,
2637         set_unrelocated_address>: Update.
2638         <ginfo>: New member.
2639         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2640         (debug_names::write_psymbols): Update.
2641
2642 2019-05-04  Tom de Vries  <tdevries@suse.de>
2643
2644         * contrib/cc-with-tweaks.sh: Support -n arg.
2645
2646 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2647
2648         * corelow.c (core_target::detach): Ensure frame cache and
2649         register caches are cleared.
2650         inferior.c (exit_inferior_1): Likewise.
2651
2652 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2653             Tom Tromey  <tom@tromey.com>
2654
2655         * dictionary.c (collate_pending_symbols_by_language): Remove
2656         "struct" from foreach.
2657         * symtab.c (lookup_global_symbol_from_objfile)
2658         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2659         foreach.
2660         * ser-tcp.c (net_open): Remove "struct" from foreach.
2661         * objfiles.c (objfile_relocate, objfile_rebase)
2662         (objfile_has_symbols): Remove "struct" from foreach.
2663         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2664         from foreach.
2665         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2666         foreach.
2667         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2668         "struct" from foreach.
2669         * ada-lang.c (create_excep_cond_exprs)
2670         (ada_exception_catchpoint_cond_string): Remove "struct" from
2671         foreach.
2672
2673 2019-05-03  Tom Tromey  <tromey@adacore.com>
2674
2675         * ada-exp.y (convert_char_literal): Check suffix of each
2676         enumerator.
2677
2678 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2679
2680         PR ada/21406:
2681         * ada-exp.y (yywrap): Don't define.
2682         * ada-lex.l (%option): Add noyywrap
2683         (yywrap): Remove.
2684
2685 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2686
2687         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2688         _WIN32_WINNT to the XP level, unless already defined to a higher
2689         level.
2690
2691         * unittests/parse-connection-spec-selftests.c:
2692         * ser-tcp.c:
2693         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2694         override.
2695
2696         * symfile.c (find_separate_debug_file): Remove colon from the
2697         drive spec of DOS/Windows file names of the target, so that the
2698         file name produced from DEBUGDIR and the target's directory will
2699         be valid on DOS/Windows systems.
2700
2701 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2702
2703         * rust-lang.c (val_print_struct): Handle printing structures
2704         containing strings.
2705
2706 2019-05-02  Tom Tromey  <tromey@adacore.com>
2707
2708         * valarith.c (_initialize_valarith): Remove.
2709
2710 2019-05-01  Tom Tromey  <tromey@adacore.com>
2711
2712         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2713         bitfields.
2714
2715 2019-05-01  Tom Tromey  <tromey@adacore.com>
2716
2717         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2718         for big-endian copies.
2719
2720 2019-04-30  Ali Tamur  <tamur@google.com>
2721         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2722         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2723         (read_3_bytes): New function.
2724
2725 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2726
2727         * windows-nat.c (main_thread_id): Delete.
2728         (handle_output_debug_string): Replace main_thread_id by
2729         current_event.dwThreadId.
2730         (fake_create_process): Likewise.
2731         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2732         Do not set main_thread_id.
2733         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2734         current_event.dwThreadId.
2735         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2736
2737 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2738
2739         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2740         Use current_event.dwThreadId instead of main_thread_id.
2741
2742 2019-04-30  Tom Tromey  <tromey@adacore.com>
2743
2744         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2745         (create_excep_cond_exprs): Iterate over program spaces.
2746         (ada_exception_catchpoint_cond_string): Examine all minimal
2747         symbols for exception types.
2748
2749 2019-04-30  Tom Tromey  <tromey@adacore.com>
2750
2751         PR c++/24470:
2752         * dwarf2read.c (process_structure_scope): Handle case where type
2753         has template parameters but no symbol was created.
2754
2755 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2756             Chris January  <chris.january@arm.com>
2757
2758         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2759         qualifier.
2760         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2761
2762 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2763
2764         * f-typeprint.c (f_print_type): Update rules for printing
2765         whitespace.
2766         (f_type_print_varspec_suffix): Likewise.
2767
2768 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2769             Chris January  <chris.january@arm.com>
2770
2771         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2772         function arguments.
2773
2774 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2775
2776         * f-lang.c (build_fortran_types): Change name of void type to
2777         lower case.
2778         * f-typeprint.c (f_type_print_base): Print the name of the void
2779         type, rather than a fixed string.
2780         * f-valprint.c (f_decorations): Use lower case void string.
2781
2782 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2783             Chris January  <chris.january@arm.com>
2784
2785         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2786         types for Fortran.
2787
2788 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2789             Chris January  <chris.january@arm.com>
2790             David Lecomber  <david.lecomber@arm.com>
2791
2792         * f-exp.y (BINOP_INTRINSIC): New token.
2793         (exp): New parser rule handling BINOP_INTRINSIC.
2794         (f77_keywords): Add new builtin procedures.
2795         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2796         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2797         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2798         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2799         (print_unop_subexp_f): New function.
2800         (print_binop_subexp_f): New function.
2801         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2802         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2803         (dump_subexp_body_f): Likewise.
2804         (operator_check_f): Likewise.
2805         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2806         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2807
2808 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2809
2810         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2811         UNOP_KIND.
2812         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2813         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2814         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2815         (operator_length_f): New fuction.
2816         (print_subexp_f): New function.
2817         (op_name_f): New function.
2818         (dump_subexp_body_f): New function.
2819         (operator_check_f): New function.
2820         (exp_descriptor_f): Replace standard expression handling functions
2821         with new functions.
2822         * gdb/fortran-operator.def: New file.
2823         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2824         * gdb/std-operator.def: Remove UNOP_KIND.
2825
2826 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2827
2828         * std-operator.def: Remove unbalanced, stray double quote
2829         character.
2830
2831 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2832             Chris January  <chris.january@arm.com>
2833             Daniel Everett  <daniel.everett@arm.com>
2834             Nick Forrington  <nick.forrington@arm.com>
2835             Richard Bunt  <richard.bunt@arm.com>
2836
2837         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2838         of depth when printing anonymous structs or unions.
2839         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2840         Don't print either the top-level value, or the children if the
2841         max-depth is exceeded.
2842         (ppscm_print_children): When printing the key of a map, allow one
2843         extra level of depth.
2844         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2845         print either the top-level value, or the children if the max-depth
2846         is exceeded.
2847         (print_children): When printing the key of a map, allow one extra
2848         level of depth.
2849         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2850         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2851         (user_print_options): Initialise max_depth field.
2852         (val_print_scalar_or_string_type_p): New function.
2853         (val_print): Check to see if the max depth has been reached.
2854         (val_print_check_max_depth): Define new function.
2855         (show_print_max_depth): New function.
2856         (_initialize_valprint): Add 'print max-depth' option.
2857         * valprint.h (struct value_print_options) <max_depth>: New field.
2858         (val_print_check_max_depth): Declare new function.
2859         * NEWS: Document new feature.
2860
2861 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2862
2863         * ada-lang.c (ada_language_defn): Initialise new field.
2864         * c-lang.c (c_is_string_type_p): New function.
2865         (c_language_defn): Initialise new field.
2866         (cplus_language_defn): Initialise new field.
2867         (asm_language_defn): Initialise new field.
2868         (minimal_language_defn): Initialise new field.
2869         * c-lang.h (c_is_string_type_p): Declare new function.
2870         * d-lang.c (d_language_defn): Initialise new field.
2871         * f-lang.c (f_is_string_type_p): New function.
2872         (f_language_defn): Initialise new field.
2873         * go-lang.c (go_is_string_type_p): New function.
2874         (go_language_defn): Initialise new field.
2875         * language.c (default_is_string_type_p): New function.
2876         (unknown_language_defn): Initialise new field.
2877         (auto_language_defn): Initialise new field.
2878         * language.h (struct language_defn) <la_is_string_type_p>: New
2879         member variable.
2880         (default_is_string_type_p): Declare new function.
2881         * m2-lang.c (m2_language_defn): Initialise new field.
2882         * objc-lang.c (objc_language_defn): Initialise new field.
2883         * opencl-lang.c (opencl_language_defn): Initialise new field.
2884         * p-lang.c (pascal_is_string_type_p): New function.
2885         (pascal_language_defn): Initialise new field.
2886         * rust-lang.c (rust_is_string_type_p): New function.
2887         (rust_language_defn): Initialise new field.
2888
2889 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2890
2891         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2892         New field.
2893         * ada-lang.c (ada_language_defn): Initialise new field.
2894         * c-lang.c (c_language_defn): Likewise.
2895         (cplus_language_defn): Likewise.
2896         (asm_language_defn): Likewise.
2897         (minimal_language_defn): Likewise.
2898         * d-lang.c (d_language_defn): Likewise.
2899         * f-lang.c (f_language_defn): Likewise.
2900         * go-lang.c (go_language_defn): Likewise.
2901         * language.c (unknown_language_defn): Likewise.
2902         (auto_language_defn): Likewise.
2903         * m2-lang.c (m2_language_defn): Likewise.
2904         * objc-lang.c (objc_language_defn): Likewise.
2905         * opencl-lang.c (opencl_language_defn): Likewise.
2906         * p-lang.c (pascal_language_defn): Likewise.
2907         * rust-lang.c (rust_language_defn): Likewise.
2908
2909 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2910
2911         * ada-lang.c (ada_is_character_type): Change return type to bool.
2912         (ada_is_string_type): Likewise.
2913         * ada-lang.h (ada_is_character_type): Update declaration
2914         (ada_is_string_type): Likewise.
2915
2916 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2917
2918         Support style in 'frame|thread apply'
2919
2920         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2921         * record.c (record_start, record_stop): Update callers of
2922         execute_command_to_string with false.
2923         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2924         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2925         methods.
2926         (class string_file): New constructor with term_out parameter.
2927         Override methods term_out and can_emit_style_escape.  New member
2928         term_out.
2929         (class stdio_file): Override can_emit_style_escape.
2930         (class tee_file): Override term_out and can_emit_style_escape.
2931         * utils.h (can_emit_style_escape): Remove.
2932         * utils.c (can_emit_style_escape): Likewise.
2933         Update all callers of can_emit_style_escape (SOMESTREAM) to
2934         SOMESTREAM->can_emit_style_escape.
2935         * source-cache.c (source_cache::get_source_lines): Likewise.
2936         * stack.c (frame_apply_command_count): Call execute_command_to_string
2937         passing the term_out characteristic of the current gdb_stdout.
2938         * thread.c (thr_try_catch_cmd): Likewise.
2939         * top.c (execute_command_to_string): pass term_out parameter
2940         to construct the string_file for the command output.
2941         * ui-file.c (term_cli_styling): New function (most code moved
2942         from utils.c can_emit_style_escape).
2943         (string_file::string_file, string_file::can_emit_style_escape,
2944         stdio_file::can_emit_style_escape, tee_file::term_out,
2945         tee_file::can_emit_style_escape): New functions.
2946
2947 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2948
2949         * NEWS: Mention the new set|show may-call-functions.
2950         * infcall.c (may_call_functions_p): New variable.
2951         (show_may_call_functions_p): New function.
2952         (call_function_by_hand_dummy): Throws an error if not
2953         may-call-functions.
2954         (_initialize_infcall): Call add_setshow_boolean_cmd for
2955         may-call-functions.
2956
2957 2019-04-25  Keith Seitz  <keiths@redhat.com>
2958
2959         PR c++/24367
2960         * cp-support.c (inspect_type): Don't attempt substitutions
2961         of symbol with the same name.
2962
2963 2019-04-25  Tom Tromey  <tromey@adacore.com>
2964
2965         PR gdb/24475:
2966         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2967         static.
2968
2969 2019-04-25  Tom Tromey  <tromey@adacore.com>
2970
2971         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2972         rvalue reference.
2973         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2974         (gdb_xml_parser::parse): Use std::move.
2975         * python/python-internal.h (gdbpy_convert_exception): Take a const
2976         reference.
2977         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2978         std::move.
2979         * python/py-utils.c (gdbpy_convert_exception): Take a const
2980         reference.
2981         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2982         Use std::move.
2983         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2984         Use std::move.
2985         * mi/mi-main.c (mi_print_exception): Take a const reference.
2986         * main.c (handle_command_errors): Take a const reference.
2987         * linespec.c (parse_linespec): Use std::move.
2988         * infcall.c (run_inferior_call): Use std::move.
2989         (call_function_by_hand_dummy): Use std::move.
2990         * exec.c (try_open_exec_file): Use std::move.
2991         * exceptions.h (exception_print, exception_fprintf)
2992         (exception_print_same): Update.
2993         * exceptions.c (print_exception, exception_print)
2994         (exception_fprintf, exception_print_same): Change parameters to
2995         const reference.
2996         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2997         * common/new-op.c: Use std::move.
2998         * common/common-exceptions.h (struct gdb_exception): Add move
2999         constructor.
3000         (struct gdb_exception_error, struct gdb_exception_quit, struct
3001         gdb_quit_bad_alloc): Change constructor to move constructor.
3002         (throw_exception): Change parameter to rvalue reference.
3003         * common/common-exceptions.c (throw_exception): Take rvalue
3004         reference.
3005         * cli/cli-interp.c (safe_execute_command): Use std::move.
3006         * breakpoint.c (insert_bp_location, location_to_sals): Use
3007         std::move.
3008
3009 2019-04-25  Tom Tromey  <tromey@adacore.com>
3010
3011         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3012         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3013         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3014         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3015         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3016         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3017         guile/scm-value.c: Use unpack.
3018         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3019         gdbscm_gdb_exception.
3020         (gdbscm_throw_gdb_exception): Likewise.
3021         (struct gdbscm_gdb_exception): New.
3022         (unpack): New function.
3023         (gdbscm_wrap): Use unpack.
3024
3025 2019-04-25  Tom Tromey  <tromey@adacore.com>
3026
3027         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3028         (gdb_rl_callback_handler): Use std::move.
3029         * common/common-exceptions.h (struct gdb_exception): Add move
3030         assignment operator.
3031         (throw_exception_sjlj): Change "exception" to const reference.
3032         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3033         (throw_exception_sjlj): Change "exception" to const reference.
3034
3035 2019-04-25  Tom Tromey  <tromey@adacore.com>
3036
3037         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3038         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3039         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3040         Update.
3041         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3042         Update.
3043         * mi/mi-interp.c (mi_interp::exec): Update.
3044         * linespec.c (parse_linespec): Update.
3045         * infcall.c (run_inferior_call): Update.
3046         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3047         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3048         (gdbscm_lookup_global_symbol): Update.
3049         * guile/scm-param.c (gdbscm_parameter_value): Update.
3050         * guile/scm-frame.c (gdbscm_frame_read_register)
3051         (gdbscm_frame_read_var): Update.
3052         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3053         * exec.c (try_open_exec_file): Update.
3054         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3055         (gdb_rl_callback_handler): Update.
3056         * common/common-exceptions.h (exception_none): Don't declare.
3057         * common/common-exceptions.c (exception_none): Don't define.
3058         (struct catcher) <exception>: Update.
3059         * cli/cli-interp.c (safe_execute_command): Update.
3060         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3061
3062 2019-04-25  Ali Tamur  <tamur@google.com>
3063
3064         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3065         (read_attribute_value): Likewise.
3066         (dwarf2_read_addr_index): Update comment.
3067         (read_str_index): Add DW_FORM_strx.
3068         (dwarf2_string_attr): Likewise.
3069         (dwarf2_const_value_attr): Likewise.
3070         (dump_die_shallow): Likewise.
3071         (dwarf2_fetch_constant_bytes): Likewise.
3072         (skip_form_bytes): Likewise.
3073         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3074
3075 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3076
3077         PR corefiles/11608
3078         PR corefiles/18187
3079         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3080         OFFSET.  Verify if current mapping contains an ELF header.
3081         (linux_find_memory_regions_full): Adjust call to
3082         dump_mapping_p.
3083
3084 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3085             Kang Li <kanglictf@gmail.com>
3086
3087         PR gdb/21600
3088
3089         * dwarf2-frame.c (read_initial_length): Be consistent about using
3090         unsigned representation of length.
3091         (decode_frame_entry_1): Likewise.  Check for wraparound of
3092         end pointer as well as buffer overflow.
3093
3094 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3095
3096         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3097         "vq".
3098
3099 2019-04-24  Tom Tromey  <tromey@adacore.com>
3100
3101         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3102
3103 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3104
3105         * s12z-tdep.c (s12z_unwind_pc): Delete.
3106         (s12z_unwind_sp): Delete.
3107         (s12z_gdbarch_init): Don't register deleted functions with
3108         gdbarch.
3109
3110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3111
3112         * rl78-tdep.c (rl78_unwind_sp): Delete.
3113         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3114
3115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3116
3117         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3118         (xstormy16_unwind_pc): Delete.
3119         (xstormy16_dummy_id): Delete.
3120         (xstormy16_gdbarch_init): Don't register deleted functions with
3121         gdbarch.
3122
3123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3124
3125         * vax-tdep.c (vax_unwind_pc): Delete.
3126         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3127
3128 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3129
3130         * v850-tdep.c (v850_unwind_sp): Delete.
3131         (v850_unwind_pc): Delete.
3132         (v850_dummy_id): Delete.
3133         (v850_gdbarch_init): Don't register deleted functions with
3134         gdbarch.
3135
3136 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3137
3138         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3139         (tilegx_unwind_pc): Delete.
3140         (tilegx_unwind_dummy_id): Delete.
3141         (tilegx_gdbarch_init): Don't register deleted functions with
3142         gdbarch.
3143
3144 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3145
3146         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3147         (tic6x_dummy_id): Delete.
3148         (tic6x_gdbarch_init): Don't register deleted functions with
3149         gdbarch.
3150
3151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3152
3153         * sparc-tdep.c (sparc_unwind_pc): Delete.
3154         (sparc32_gdbarch_init): Don't register deleted function with
3155         gdbarch.
3156
3157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3158
3159         * sh-tdep.c (sh_unwind_sp): Delete.
3160         (sh_unwind_pc): Delete.
3161         (sh_dummy_id): Delete.
3162         (sh_gdbarch_init): Don't register deleted functions with
3163         gdbarch.
3164
3165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3166
3167         * score-tdep.c (score_unwind_sp): Delete.
3168         (score_unwind_pc): Delete.
3169         (score_dummy_id): Delete.
3170         (score_gdbarch_init): Don't register deleted functions with
3171         gdbarch.
3172
3173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * rx-tdep.c (rx_unwind_pc): Delete.
3176         (rx_unwind_sp): Delete.
3177         (rx_dummy_id): Delete.
3178         (rx_gdbarch_init): Don't register deleted functions with
3179         gdbarch.  Update comment.
3180
3181 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3182
3183         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3184         (rs6000_dummy_id): Delete.
3185         (rs6000_gdbarch_init): Don't register deleted functions with
3186         gdbarch.
3187
3188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3189
3190         * or1k-tdep.c (or1k_dummy_id): Delete.
3191         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3192
3193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3194
3195         * nios2-tdep.c (nios2_dummy_id): Delete.
3196         (nios2_unwind_sp): Delete.
3197         (nios2_gdbarch_init): Don't register deleted functions with
3198         gdbarch.
3199
3200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3201
3202         * nds32-tdep.c (nds32_dummy_id): Delete.
3203         (nds32_unwind_pc): Delete.
3204         (nds32_unwind_sp): Delete.
3205         (nds32_gdbarch_init): Don't register deleted functions with
3206         gdbarch.
3207
3208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3209
3210         * msp430-tdep.c (msp430_unwind_pc): Delete.
3211         (msp430_unwind_sp): Delete.
3212         (msp430_dummy_id): Delete.
3213         (msp430_gdbarch_init): Don't register deleted functions with
3214         gdbarch.
3215
3216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3217
3218         * moxie-tdep.c (moxie_unwind_sp): Delete.
3219         (moxie_unwind_pc): Delete.
3220         (moxie_dummy_id): Delete.
3221         (moxie_gdbarch_init): Don't register deleted functions with
3222         gdbarch.
3223
3224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3225
3226         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3227         (mn10300_unwind_pc): Delete.
3228         (mn10300_unwind_sp): Delete.
3229         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3230         mn10300_unwind_sp.
3231         (mn10300_frame_unwind_init): Don't register deleted functions with
3232         gdbarch.
3233
3234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3235
3236         * mep-tdep.c (mep_unwind_pc): Delete.
3237         (mep_unwind_sp): Delete.
3238         (mep_dummy_id): Delete.
3239         (mep_gdbarch_init): Don't register deleted functions with
3240         gdbarch.
3241
3242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3243
3244         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3245         (m68hc11_unwind_sp): Delete.
3246         (m68hc11_gdbarch_init): Don't register deleted functions with
3247         gdbarch.
3248
3249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3250
3251         * m32r-tdep.c (m32r_unwind_sp): Delete.
3252         (m32r_unwind_pc): Delete.
3253         (m32r_dummy_id): Delete.
3254         (m32r_gdbarch_init): Don't register deleted functions with
3255         gdbarch.
3256
3257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3258
3259         * m32c-tdep.c (m32c_unwind_pc): Delete.
3260         (m32c_unwind_sp): Delete.
3261         (m32c_dummy_id): Delete.
3262         (m32c_gdbarch_init): Don't register deleted functions with
3263         gdbarch.
3264
3265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3266
3267         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3268         (lm32_unwind_pc): Delete.
3269         (lm32_dummy_id): Delete.
3270         (lm32_gdbarch_init): Don't register deleted functions with
3271         gdbarch.
3272
3273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3274
3275         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3276         (iq2000_unwind_pc): Delete.
3277         (iq2000_dummy_id): Delete.
3278         (iq2000_gdbarch_init): Don't register deleted functions with
3279         gdbarch.
3280
3281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3282
3283         * nds32-tdep.c (nds32_type_align): Delete.
3284         (nds32_push_dummy_call): Use type_align instead.
3285
3286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3287
3288         * arm-tdep.c (arm_type_align): Only handle vector override case.
3289         (arm_push_dummy_call): Use type_align.
3290         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3291
3292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3295         case.
3296         (pass_on_stack): Use type_align.
3297         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3298         function.
3299
3300 2019-04-23  Tom Tromey  <tromey@adacore.com>
3301
3302         * dwarf2read.c (line_header::file_name_at): Remove unused
3303         overload.
3304
3305 2019-04-23  Tom de Vries  <tdevries@suse.de>
3306
3307         PR gdb/24438
3308         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3309         invocation.
3310
3311
3312 2019-03-27  Ali Tamur  <tamur@google.com>
3313
3314         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3315         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3316         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3317         (dwarf_expr_context::get_addr_index): Likewise
3318         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3319         (symbol_needs_eval_context::get_addr_index): Likewise
3320         (disassemble_dwarf_expression): Add DW_OP_addrx
3321         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3322         (read_cutu_die_from_dwo): Update comment
3323         (skip_one_die): Add DW_FORM_addrx
3324         (read_attribute_value): Likewise
3325         (var_decode_location): Add DW_OP_addrx
3326         (dwarf2_const_value_attr): Add DW_FORM_addrx
3327         (dump_die_shallow): Likewise
3328         (dwarf2_fetch_constant_bytes): Likewise
3329         (decode_locdesc): Add DW_OP_addrx
3330         (skip_form_bytes): Add DW_FORM_addrx
3331
3332 2019-04-22  Ali Tamur  <tamur@google.com>
3333
3334         * MAINTAINERS (Write After Approval): Add self.
3335
3336 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3337
3338         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3339         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3340         (open_symbol_file_object): Likewise.
3341         (svr4_default_sos): Add info parameter.
3342         (svr4_read_so_list): Likewise.
3343         (svr4_current_sos_direct): Adjust functions calls to pass down
3344         info.
3345         (svr4_current_sos_1): Add info parameter.
3346         (svr4_current_sos): Call get_svr4_info, pass info down to
3347         svr4_current_sos_1.
3348         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3349         get_svr4_info.
3350         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3351         get_svr4_info.
3352         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3353         to get_svr4_info.
3354         (probes_table_remove_objfile_probes): Likewise.
3355         (register_solib_event_probe): Add info parameter.
3356         (solist_update_incremental): Pass info parameter down to
3357         svr4_read_so_list.
3358         (disable_probes_interface): Add info parameter.
3359         (svr4_handle_solib_event): Pass current_program_space to
3360         get_svr4_info.  Adjust disable_probes_interface cleanup.
3361         (svr4_create_probe_breakpoints): Add info parameter, pass it
3362         down to register_solib_event_probe.
3363         (svr4_create_solib_event_breakpoints): Add info parameter,
3364         pass it down to svr4_create_probe_breakpoints.
3365         (enable_break): Pass info down to
3366         svr4_create_solib_event_breakpoints.
3367         (svr4_solib_create_inferior_hook): Pass current_program_space to
3368         get_svr4_info.
3369         (svr4_clear_solib): Likewise.
3370
3371 2019-04-22  Pedro Alves  <palves@redhat.com>
3372
3373         * solib-svr4.c (svr4_free_objfile_observer): New.
3374         (probe_and_action::objfile): New field.
3375         (probes_table_htab_remove_objfile_probes)
3376         (probes_table_remove_objfile_probes): New functions.
3377         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3378         in the new probe_and_action.  Don't store the probe in 'lookup'.
3379         (svr4_create_probe_breakpoints): Pass objfile to
3380         register_solib_event_probe.
3381         (_initialize_svr4_solib): Register a free_objfile observer.
3382
3383 2019-04-19  Tom Tromey  <tom@tromey.com>
3384
3385         * common/queue.h: Remove.
3386
3387 2019-04-19  Tom Tromey  <tom@tromey.com>
3388
3389         * event-loop.c: Don't include "common/queue.h".
3390
3391 2019-04-19  Tom Tromey  <tom@tromey.com>
3392
3393         * remote.c (remote_target): Use delete.
3394         * remote-notif.h: Include <list>, not "common/queue.h".
3395         (notif_client_p): Remove typedef.
3396         (remote_notif_state): Add constructor, destructor, initializer.
3397         <notif_queue>: Now a std::list.
3398         (remote_notif_state_xfree): Don't declare.
3399         * remote-notif.c (remote_notif_process, handle_notification)
3400         (remote_notif_state_allocate): Update.
3401         (~remote_notif_state): Rename from remote_notif_state_xfree.
3402
3403 2019-04-19  Tom Tromey  <tom@tromey.com>
3404
3405         * symfile.c (reread_symbols): Update.
3406         * objfiles.c (objfile_register_static_link)
3407         (objfile_lookup_static_link): Update
3408         (~objfile) Don't delete static_links.
3409         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3410
3411 2019-04-19  Tom Tromey  <tom@tromey.com>
3412
3413         * type-stack.h (struct type_stack) <insert>: Constify string.
3414         * type-stack.c (type_stack::insert): Constify string.
3415         * gdbtypes.h (lookup_template_type): Update.
3416         (address_space_name_to_int): Update.
3417         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3418         const.
3419         (lookup_template_type): Make name const.
3420         * c-exp.y: Update rules.
3421         (lex_one_token, classify_name, classify_inner_name)
3422         (c_print_token): Update.
3423         * p-exp.y: Update rules.
3424         (yylex): Update.
3425         * f-exp.y: Update rules.
3426         (yylex): Update.
3427         * d-exp.y: Update rules.
3428         (lex_one_token, classify_name, classify_inner_name): Update.
3429         * parse.c (write_dollar_variable, copy_name): Return std::string.
3430         * parser-defs.h (copy_name): Change return type.
3431         * m2-exp.y: Update rules.
3432         (yylex): Update.
3433         * go-exp.y (lex_one_token): Update.
3434         Update rules.
3435         (classify_unsafe_function, classify_packaged_name)
3436         (classify_name, yylex): Update.
3437
3438 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3439
3440         * configure.ac: add --enable-source-highlight switch.
3441         * configure: Regenerate.
3442         * top.c (print_gdb_version): plumb --enable-source-highlight
3443         status to "show configuration".
3444
3445 2019-04-19  Tom Tromey  <tromey@adacore.com>
3446
3447         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3448         Check ADA_TYPE_P.
3449         (empty_record, ada_template_to_fixed_record_type_1)
3450         (template_to_static_fixed_type)
3451         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3452         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3453         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3454         macros.
3455
3456 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3457
3458         PR symtab/24423:
3459         * source.c (print_source_lines_base): Advance "iter" when a
3460         control character is seen.
3461
3462 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3463
3464         * inferior.h (struct infcall_suspend_state_deleter):
3465         Catch exception in destructor to avoid crash.
3466
3467 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3468
3469         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3470         close to the add_com "shell".
3471
3472 2019-04-18  Tom Tromey  <tromey@adacore.com>
3473
3474         * process-stratum-target.h (class process_stratum_target)
3475         <stratum>: Add "final".
3476
3477 2019-04-17  Tom Tromey  <tromey@adacore.com>
3478
3479         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3480         against nullptr before use.
3481
3482 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3483
3484         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3485
3486 2019-04-17  Jim Wilson  <jimw@sifive.com>
3487             Andrew Burgess  <andrew.burgess@embecosm.com>
3488
3489         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3490         code read might fail, assume 4-byte breakpoint in that case.
3491
3492 2019-04-15  Leszek Swirski  <leszeks@google.com>
3493
3494         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3495         rather than a hand-rolled POD check when checking for forced MEMORY
3496         classification.
3497
3498 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3499
3500         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3501         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3502         function.
3503         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3504         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3505         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3506         declaration.
3507
3508 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3509
3510         * aarch64-linux-nat.c
3511         (aarch64_linux_nat_target::thread_architecture): Add override.
3512         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3513         each VQ.
3514
3515 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3516
3517         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3518
3519 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3520
3521         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3522         target types of size 96-bits, add some additional comments, and
3523         check that the builtin type we found was the correct size.
3524
3525 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3526
3527         * utils.c (prompt_for_continue): Don't restore the styling at the
3528         end, as applied_style has the wrong value.  This fixes styling in
3529         long lists of file names that are interrupted by the "Continue?"
3530         prompt.
3531
3532 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3533
3534         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3535         * c-lang.c (c_language_defn): Likewise.
3536         (cplus_language_defn): Likewise.
3537         (asm_language_defn): Likewise.
3538         (minimal_language_defn): Likewise.
3539         * d-lang.c (d_language_defn): Likewise.
3540         * f-lang.c (f_language_defn): Likewise.
3541         * go-lang.c (go_language_defn): Likewise.
3542         * language.c (unknown_language_defn): Likewise.
3543         (auto_language_defn): Likewise.
3544         * language.h (struct language_defn): Remove la_magic field.
3545         (LANG_MAGIC): Delete.
3546         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3547         * objc-lang.c (objc_language_defn): Likewise.
3548         * opencl-lang.c (opencl_language_defn): Likewise.
3549         * p-lang.c (pascal_language_defn): Likewise.
3550         * rust-lang.c (rust_language_defn): Likewise.
3551
3552 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3553
3554         * riscv-tdep.c (riscv_type_align): New function.
3555         (riscv_type_alignment): Delete.
3556         (riscv_arg_location): Use 'type_align'.
3557         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3558
3559 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         * gdbtypes.c (type_align): A struct with no non-static fields also
3562         has alignment of 1.
3563
3564 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3565
3566         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3567         component to 0.
3568         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3569         member.
3570         (riscv_struct_info::analyse): New implementation using new
3571         analyse_inner member function.
3572         (riscv_struct_info::field_offset): New member function.
3573         (riscv_struct_info::m_offsets): New member variable.
3574         (riscv_struct_info::analyse_inner): New private member function,
3575         takes the old implementation of riscv_struct_info::analyse but
3576         extended to track field offsets.
3577         (riscv_call_arg_struct): Update the struct folding special cases
3578         to handle cases where empty C++ structs, which are non-zero
3579         length, are found.
3580         (riscv_arg_location): Initialise the length of each location, a
3581         non-zero length now indicates the location is in use.
3582         (riscv_push_dummy_call): Allow for the first location having a
3583         non-zero offset when setting up arguments.
3584         (riscv_return_value): Likewise, but for return values.
3585
3586 2019-04-11  Tom Tromey  <tromey@adacore.com>
3587
3588         * utils.c (internal_vproblem): Make "msg" const.
3589
3590 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3591
3592         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3593         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3594         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3595         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3596
3597 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3598
3599         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3600         function.
3601         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3602         of amd64_collect_native_gregset.
3603         (amd64_linux_nat_target::store_registers): Likewise.
3604
3605 2019-04-10  Tom Tromey  <tom@tromey.com>
3606
3607         * symtab.c (lookup_global_symbol_from_objfile)
3608         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3609         * objfiles.h (class separate_debug_iterator): New.
3610         (class separate_debug_range): New.
3611         (struct objfile) <separate_debug_objfiles>: New method.
3612         (objfile_separate_debug_iterate): Don't declare.
3613         * objfiles.c (separate_debug_iterator::operator++): Rename from
3614         objfile_separate_debug_iterate.
3615         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3616         iterator.
3617         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3618         iterator.
3619
3620 2019-04-10  Tom Tromey  <tom@tromey.com>
3621
3622         * symfile.c (reread_symbols): Remove old comment.
3623         * objfiles.c (free_all_objfiles): Fix a typo.
3624
3625 2019-04-10  Tom Tromey  <tom@tromey.com>
3626
3627         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3628         * minsyms.c (lookup_minimal_symbol): Use foreach.
3629         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3630         (lookup_minimal_symbol_solib_trampoline): Likewise.
3631         * symfile.c (reread_symbols): Use foreach.
3632
3633 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3634             Tom Tromey  <tromey@adacore.com>
3635
3636         PR rust/24414:
3637         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3638         (rust_lex_int_test): Change "value" to be LONGEST.
3639         (rust_lex_tests): Add test for long integer literal.
3640
3641 2019-04-09  Tom Tromey  <tromey@adacore.com>
3642
3643         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3644         to bool.
3645         (extended_remote_target::attach): Update.
3646         (remote_target::remote_notice_new_inferior): Update.
3647         (remote_target::add_current_inferior_and_thread): Update.
3648         * inferior.c (exit_inferior_1): Use "false".
3649         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3650
3651 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3652
3653         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3654         the "start" command.
3655
3656 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3657
3658         * python/py-inferior.c (infpy_thread_from_thread_handle):
3659         Adjust comments to reflect renaming of thread_from_thread_handle
3660         to thread_from_handle.  Adjust keywords.  Fix type error message.
3661         (inferior_object_methods): Add thread_from_handle.  Retain
3662         thread_from_thread_handle, but mark it as deprecated.
3663
3664 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3665
3666         * gdbthread.h (find_thread_by_handle): Revise declaration.
3667         * thread.c (find_thread_by_handle): Likewise.  Adjust
3668         implementation too.
3669         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3670         support for buffer objects as handles.
3671
3672 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3673
3674         * python/py-infthread.c (thpy_thread_handle): New function.
3675         (thread_object_methods): Register thpy_thread_handle.
3676
3677 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3678
3679         * gdbthread.h (thread_to_thread_handle): Declare.
3680         * thread.c (gdbtypes.h): Include.
3681         (thread_to_thread_handle): New function.
3682
3683         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3684         (target_thread_info_to_thread_handle): Declare.
3685         * target.c (target_thread_info_to_thread_handle): New function.
3686         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3687         * target-delegates.c: Regenerate.
3688
3689         * linux-thread-db.c (class thread_db_target): Add method
3690         thread_info_to_thread_handle.
3691         (thread_db_target::thread_info_to_thread_handle): Define.
3692         * remote.c (class remote_target): Add new method
3693         thread_info_to_thread_handle.
3694         (remote_target::thread_info_to_thread_handle): Define.
3695
3696 2019-04-08  Pedro Alves  <palves@redhat.com>
3697
3698         * common/common-exceptions.c (throw_exception): Don't create
3699         named object to throw; throw directly.
3700         (throw_it): Likewise.  Don't initialize gdb_exception::message
3701         here, with new; pass FMT and AP to the ctor instead.
3702         * common/common-exceptions.h: Include <string>.
3703         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3704         const char *, va_list)): New ctor.  Use std::make_shared.
3705         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3706         errors)): Delete.
3707         (gdb_exception_error::gdb_exception_error(enum errors, const char
3708         *, va_list)): New.
3709         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3710         Add assertion.
3711         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3712         errors)): Delete.
3713         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3714         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3715         Add assertion.
3716
3717 2019-04-08  Tom Tromey  <tom@tromey.com>
3718
3719         * valops.c (value_rtti_indirect_type): Replace throw_exception
3720         with throw.
3721         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3722         with throw.
3723         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3724         throw.
3725         * target.c (target_translate_tls_address): Replace throw_exception
3726         with throw.
3727         * stack.c (frame_apply_command_count): Replace throw_exception
3728         with throw.
3729         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3730         throw.
3731         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3732         with throw.
3733         * rs6000-tdep.c (rs6000_frame_cache)
3734         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3735         * remote.c: Replace throw_exception with throw.
3736         * record-full.c (record_full_message, record_full_wait_1)
3737         (record_full_restore): Replace throw_exception with throw.
3738         * record-btrace.c:
3739         (get_thread_current_frame_id, record_btrace_start_replaying)
3740         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3741         (cmd_record_btrace_start): Replace throw_exception with throw.
3742         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3743         throw.
3744         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3745         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3746         * linespec.c:
3747         (find_linespec_symbols): Replace throw_exception with throw.
3748         * infrun.c (displaced_step_prepare, resume): Replace
3749         throw_exception with throw.
3750         * infcmd.c (post_create_inferior): Replace throw_exception with
3751         throw.
3752         * inf-loop.c (inferior_event_handler): Replace throw_exception
3753         with throw.
3754         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3755         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3756         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3757         (get_prev_frame_always, get_frame_pc_if_available)
3758         (get_frame_address_in_block_if_available, get_frame_language):
3759         Replace throw_exception with throw.
3760         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3761         throw_exception with throw.
3762         * eval.c (fetch_subexp_value, evaluate_var_value)
3763         (evaluate_funcall, evaluate_subexp_standard): Replace
3764         throw_exception with throw.
3765         * dwarf2loc.c (call_site_find_chain)
3766         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3767         Replace throw_exception with throw.
3768         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3769         with throw.
3770         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3771         throw.
3772         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3773         * completer.c (complete_line_internal): Replace throw_exception
3774         with throw.
3775         * compile/compile-object-run.c (compile_object_run): Replace
3776         throw_exception with throw.
3777         * cli/cli-script.c (process_next_line): Replace throw_exception
3778         with throw.
3779         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3780         (btrace_enable, btrace_maint_update_pt_packets): Replace
3781         throw_exception with throw.
3782         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3783         throw_exception with throw.
3784         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3785         throw_exception with throw.
3786         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3787         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3788         * aarch64-tdep.c (aarch64_make_prologue_cache)
3789         (aarch64_make_stub_cache): Replace throw_exception with throw.
3790
3791 2019-04-08  Tom Tromey  <tom@tromey.com>
3792
3793         * common/common-exceptions.c (throw_exception): Rename from
3794         throw_exception_cxx.  Remove old copy.  Make argument const.
3795         (throw_it): Create and throw exception objects directly.
3796         * common/common-exceptions.h (throw_exception): Make argument
3797         const.
3798         (struct gdb_exception_error): Add constructor.
3799         (struct gdb_exception_quit): Add constructor.
3800
3801 2019-04-08  Tom Tromey  <tom@tromey.com>
3802
3803         * common/common-exceptions.h (exception_rethrow): Don't declare.
3804         (TRY_SJLJ): Update comment.
3805         (TRY, CATCH, END_CATCH): Remove.
3806         * common/common-exceptions.c (exception_rethrow): Remove.
3807
3808 2019-04-08  Tom Tromey  <tom@tromey.com>
3809
3810         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3811         Remove.
3812         (gdb_exception_error): Rename from
3813         gdb_exception_RETURN_MASK_ERROR.
3814         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3815         (gdb_quit_bad_alloc): Update.
3816         * aarch64-tdep.c: Update.
3817         * ada-lang.c: Update.
3818         * ada-typeprint.c: Update.
3819         * ada-valprint.c: Update.
3820         * amd64-tdep.c: Update.
3821         * arch-utils.c: Update.
3822         * break-catch-throw.c: Update.
3823         * breakpoint.c: Update.
3824         * btrace.c: Update.
3825         * c-varobj.c: Update.
3826         * cli/cli-cmds.c: Update.
3827         * cli/cli-interp.c: Update.
3828         * cli/cli-script.c: Update.
3829         * common/common-exceptions.c: Update.
3830         * common/new-op.c: Update.
3831         * common/selftest.c: Update.
3832         * compile/compile-c-symbols.c: Update.
3833         * compile/compile-cplus-symbols.c: Update.
3834         * compile/compile-object-load.c: Update.
3835         * compile/compile-object-run.c: Update.
3836         * completer.c: Update.
3837         * corelow.c: Update.
3838         * cp-abi.c: Update.
3839         * cp-support.c: Update.
3840         * cp-valprint.c: Update.
3841         * darwin-nat.c: Update.
3842         * disasm-selftests.c: Update.
3843         * dtrace-probe.c: Update.
3844         * dwarf-index-cache.c: Update.
3845         * dwarf-index-write.c: Update.
3846         * dwarf2-frame-tailcall.c: Update.
3847         * dwarf2-frame.c: Update.
3848         * dwarf2loc.c: Update.
3849         * dwarf2read.c: Update.
3850         * eval.c: Update.
3851         * event-loop.c: Update.
3852         * event-top.c: Update.
3853         * exec.c: Update.
3854         * f-valprint.c: Update.
3855         * fbsd-tdep.c: Update.
3856         * frame-unwind.c: Update.
3857         * frame.c: Update.
3858         * gdbtypes.c: Update.
3859         * gnu-v3-abi.c: Update.
3860         * guile/guile-internal.h: Update.
3861         * guile/scm-block.c: Update.
3862         * guile/scm-breakpoint.c: Update.
3863         * guile/scm-cmd.c: Update.
3864         * guile/scm-disasm.c: Update.
3865         * guile/scm-frame.c: Update.
3866         * guile/scm-lazy-string.c: Update.
3867         * guile/scm-math.c: Update.
3868         * guile/scm-param.c: Update.
3869         * guile/scm-ports.c: Update.
3870         * guile/scm-pretty-print.c: Update.
3871         * guile/scm-symbol.c: Update.
3872         * guile/scm-symtab.c: Update.
3873         * guile/scm-type.c: Update.
3874         * guile/scm-value.c: Update.
3875         * i386-linux-tdep.c: Update.
3876         * i386-tdep.c: Update.
3877         * inf-loop.c: Update.
3878         * infcall.c: Update.
3879         * infcmd.c: Update.
3880         * infrun.c: Update.
3881         * jit.c: Update.
3882         * language.c: Update.
3883         * linespec.c: Update.
3884         * linux-fork.c: Update.
3885         * linux-nat.c: Update.
3886         * linux-tdep.c: Update.
3887         * linux-thread-db.c: Update.
3888         * main.c: Update.
3889         * mi/mi-cmd-break.c: Update.
3890         * mi/mi-cmd-stack.c: Update.
3891         * mi/mi-interp.c: Update.
3892         * mi/mi-main.c: Update.
3893         * objc-lang.c: Update.
3894         * p-valprint.c: Update.
3895         * parse.c: Update.
3896         * ppc-linux-tdep.c: Update.
3897         * printcmd.c: Update.
3898         * python/py-arch.c: Update.
3899         * python/py-breakpoint.c: Update.
3900         * python/py-cmd.c: Update.
3901         * python/py-finishbreakpoint.c: Update.
3902         * python/py-frame.c: Update.
3903         * python/py-framefilter.c: Update.
3904         * python/py-gdb-readline.c: Update.
3905         * python/py-inferior.c: Update.
3906         * python/py-infthread.c: Update.
3907         * python/py-lazy-string.c: Update.
3908         * python/py-linetable.c: Update.
3909         * python/py-objfile.c: Update.
3910         * python/py-param.c: Update.
3911         * python/py-prettyprint.c: Update.
3912         * python/py-progspace.c: Update.
3913         * python/py-record-btrace.c: Update.
3914         * python/py-record.c: Update.
3915         * python/py-symbol.c: Update.
3916         * python/py-type.c: Update.
3917         * python/py-unwind.c: Update.
3918         * python/py-utils.c: Update.
3919         * python/py-value.c: Update.
3920         * python/python.c: Update.
3921         * record-btrace.c: Update.
3922         * record-full.c: Update.
3923         * remote-fileio.c: Update.
3924         * remote.c: Update.
3925         * riscv-tdep.c: Update.
3926         * rs6000-aix-tdep.c: Update.
3927         * rs6000-tdep.c: Update.
3928         * rust-exp.y: Update.
3929         * rust-lang.c: Update.
3930         * s390-tdep.c: Update.
3931         * selftest-arch.c: Update.
3932         * solib-dsbt.c: Update.
3933         * solib-frv.c: Update.
3934         * solib-spu.c: Update.
3935         * solib-svr4.c: Update.
3936         * solib.c: Update.
3937         * sparc64-linux-tdep.c: Update.
3938         * stack.c: Update.
3939         * symfile-mem.c: Update.
3940         * symmisc.c: Update.
3941         * target.c: Update.
3942         * thread.c: Update.
3943         * top.c: Update.
3944         * tracefile-tfile.c: Update.
3945         * tui/tui.c: Update.
3946         * typeprint.c: Update.
3947         * unittests/cli-utils-selftests.c: Update.
3948         * unittests/parse-connection-spec-selftests.c: Update.
3949         * valops.c: Update.
3950         * valprint.c: Update.
3951         * value.c: Update.
3952         * varobj.c: Update.
3953         * windows-nat.c: Update.
3954         * x86-linux-nat.c: Update.
3955         * xml-support.c: Update.
3956
3957 2019-04-08  Tom Tromey  <tom@tromey.com>
3958
3959         * xml-support.c: Use C++ exception handling.
3960         * x86-linux-nat.c: Use C++ exception handling.
3961         * windows-nat.c: Use C++ exception handling.
3962         * varobj.c: Use C++ exception handling.
3963         * value.c: Use C++ exception handling.
3964         * valprint.c: Use C++ exception handling.
3965         * valops.c: Use C++ exception handling.
3966         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3967         handling.
3968         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3969         * typeprint.c: Use C++ exception handling.
3970         * tui/tui.c: Use C++ exception handling.
3971         * tracefile-tfile.c: Use C++ exception handling.
3972         * top.c: Use C++ exception handling.
3973         * thread.c: Use C++ exception handling.
3974         * target.c: Use C++ exception handling.
3975         * symmisc.c: Use C++ exception handling.
3976         * symfile-mem.c: Use C++ exception handling.
3977         * stack.c: Use C++ exception handling.
3978         * sparc64-linux-tdep.c: Use C++ exception handling.
3979         * solib.c: Use C++ exception handling.
3980         * solib-svr4.c: Use C++ exception handling.
3981         * solib-spu.c: Use C++ exception handling.
3982         * solib-frv.c: Use C++ exception handling.
3983         * solib-dsbt.c: Use C++ exception handling.
3984         * selftest-arch.c: Use C++ exception handling.
3985         * s390-tdep.c: Use C++ exception handling.
3986         * rust-lang.c: Use C++ exception handling.
3987         * rust-exp.y: Use C++ exception handling.
3988         * rs6000-tdep.c: Use C++ exception handling.
3989         * rs6000-aix-tdep.c: Use C++ exception handling.
3990         * riscv-tdep.c: Use C++ exception handling.
3991         * remote.c: Use C++ exception handling.
3992         * remote-fileio.c: Use C++ exception handling.
3993         * record-full.c: Use C++ exception handling.
3994         * record-btrace.c: Use C++ exception handling.
3995         * python/python.c: Use C++ exception handling.
3996         * python/py-value.c: Use C++ exception handling.
3997         * python/py-utils.c: Use C++ exception handling.
3998         * python/py-unwind.c: Use C++ exception handling.
3999         * python/py-type.c: Use C++ exception handling.
4000         * python/py-symbol.c: Use C++ exception handling.
4001         * python/py-record.c: Use C++ exception handling.
4002         * python/py-record-btrace.c: Use C++ exception handling.
4003         * python/py-progspace.c: Use C++ exception handling.
4004         * python/py-prettyprint.c: Use C++ exception handling.
4005         * python/py-param.c: Use C++ exception handling.
4006         * python/py-objfile.c: Use C++ exception handling.
4007         * python/py-linetable.c: Use C++ exception handling.
4008         * python/py-lazy-string.c: Use C++ exception handling.
4009         * python/py-infthread.c: Use C++ exception handling.
4010         * python/py-inferior.c: Use C++ exception handling.
4011         * python/py-gdb-readline.c: Use C++ exception handling.
4012         * python/py-framefilter.c: Use C++ exception handling.
4013         * python/py-frame.c: Use C++ exception handling.
4014         * python/py-finishbreakpoint.c: Use C++ exception handling.
4015         * python/py-cmd.c: Use C++ exception handling.
4016         * python/py-breakpoint.c: Use C++ exception handling.
4017         * python/py-arch.c: Use C++ exception handling.
4018         * printcmd.c: Use C++ exception handling.
4019         * ppc-linux-tdep.c: Use C++ exception handling.
4020         * parse.c: Use C++ exception handling.
4021         * p-valprint.c: Use C++ exception handling.
4022         * objc-lang.c: Use C++ exception handling.
4023         * mi/mi-main.c: Use C++ exception handling.
4024         * mi/mi-interp.c: Use C++ exception handling.
4025         * mi/mi-cmd-stack.c: Use C++ exception handling.
4026         * mi/mi-cmd-break.c: Use C++ exception handling.
4027         * main.c: Use C++ exception handling.
4028         * linux-thread-db.c: Use C++ exception handling.
4029         * linux-tdep.c: Use C++ exception handling.
4030         * linux-nat.c: Use C++ exception handling.
4031         * linux-fork.c: Use C++ exception handling.
4032         * linespec.c: Use C++ exception handling.
4033         * language.c: Use C++ exception handling.
4034         * jit.c: Use C++ exception handling.
4035         * infrun.c: Use C++ exception handling.
4036         * infcmd.c: Use C++ exception handling.
4037         * infcall.c: Use C++ exception handling.
4038         * inf-loop.c: Use C++ exception handling.
4039         * i386-tdep.c: Use C++ exception handling.
4040         * i386-linux-tdep.c: Use C++ exception handling.
4041         * guile/scm-value.c: Use C++ exception handling.
4042         * guile/scm-type.c: Use C++ exception handling.
4043         * guile/scm-symtab.c: Use C++ exception handling.
4044         * guile/scm-symbol.c: Use C++ exception handling.
4045         * guile/scm-pretty-print.c: Use C++ exception handling.
4046         * guile/scm-ports.c: Use C++ exception handling.
4047         * guile/scm-param.c: Use C++ exception handling.
4048         * guile/scm-math.c: Use C++ exception handling.
4049         * guile/scm-lazy-string.c: Use C++ exception handling.
4050         * guile/scm-frame.c: Use C++ exception handling.
4051         * guile/scm-disasm.c: Use C++ exception handling.
4052         * guile/scm-cmd.c: Use C++ exception handling.
4053         * guile/scm-breakpoint.c: Use C++ exception handling.
4054         * guile/scm-block.c: Use C++ exception handling.
4055         * guile/guile-internal.h: Use C++ exception handling.
4056         * gnu-v3-abi.c: Use C++ exception handling.
4057         * gdbtypes.c: Use C++ exception handling.
4058         * frame.c: Use C++ exception handling.
4059         * frame-unwind.c: Use C++ exception handling.
4060         * fbsd-tdep.c: Use C++ exception handling.
4061         * f-valprint.c: Use C++ exception handling.
4062         * exec.c: Use C++ exception handling.
4063         * event-top.c: Use C++ exception handling.
4064         * event-loop.c: Use C++ exception handling.
4065         * eval.c: Use C++ exception handling.
4066         * dwarf2read.c: Use C++ exception handling.
4067         * dwarf2loc.c: Use C++ exception handling.
4068         * dwarf2-frame.c: Use C++ exception handling.
4069         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4070         * dwarf-index-write.c: Use C++ exception handling.
4071         * dwarf-index-cache.c: Use C++ exception handling.
4072         * dtrace-probe.c: Use C++ exception handling.
4073         * disasm-selftests.c: Use C++ exception handling.
4074         * darwin-nat.c: Use C++ exception handling.
4075         * cp-valprint.c: Use C++ exception handling.
4076         * cp-support.c: Use C++ exception handling.
4077         * cp-abi.c: Use C++ exception handling.
4078         * corelow.c: Use C++ exception handling.
4079         * completer.c: Use C++ exception handling.
4080         * compile/compile-object-run.c: Use C++ exception handling.
4081         * compile/compile-object-load.c: Use C++ exception handling.
4082         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4083         * compile/compile-c-symbols.c: Use C++ exception handling.
4084         * common/selftest.c: Use C++ exception handling.
4085         * common/new-op.c: Use C++ exception handling.
4086         * cli/cli-script.c: Use C++ exception handling.
4087         * cli/cli-interp.c: Use C++ exception handling.
4088         * cli/cli-cmds.c: Use C++ exception handling.
4089         * c-varobj.c: Use C++ exception handling.
4090         * btrace.c: Use C++ exception handling.
4091         * breakpoint.c: Use C++ exception handling.
4092         * break-catch-throw.c: Use C++ exception handling.
4093         * arch-utils.c: Use C++ exception handling.
4094         * amd64-tdep.c: Use C++ exception handling.
4095         * ada-valprint.c: Use C++ exception handling.
4096         * ada-typeprint.c: Use C++ exception handling.
4097         * ada-lang.c: Use C++ exception handling.
4098         * aarch64-tdep.c: Use C++ exception handling.
4099
4100 2019-04-08  Tom Tromey  <tom@tromey.com>
4101
4102         * xml-support.c (gdb_xml_parser::parse): Update.
4103         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4104         * value.c (show_convenience): Update.
4105         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4106         (test_parse_flags_qcs): Update.
4107         * thread.c (thr_try_catch_cmd): Update.
4108         * target.c (target_translate_tls_address): Update.
4109         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4110         (info_frame_command_core, frame_apply_command_count): Update.
4111         * rust-exp.y (rust_lex_exception_test): Update.
4112         * riscv-tdep.c (riscv_print_one_register_info): Update.
4113         * remote.c (remote_target::enable_btrace): Update.
4114         * record-btrace.c (record_btrace_enable_warn): Update.
4115         * python/py-utils.c (gdbpy_convert_exception): Update.
4116         * printcmd.c (do_one_display, print_variable_and_value): Update.
4117         * mi/mi-main.c (mi_print_exception): Update.
4118         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4119         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4120         * linux-nat.c (linux_nat_target::attach): Update.
4121         * linux-fork.c (class scoped_switch_fork_info): Update.
4122         * infrun.c (displaced_step_prepare): Update.
4123         * infcall.c (call_function_by_hand_dummy): Update.
4124         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4125         * gnu-v3-abi.c (print_one_vtable): Update.
4126         * frame.c (get_prev_frame_always): Update.
4127         * f-valprint.c (info_common_command_for_block): Update.
4128         * exec.c (try_open_exec_file): Update.
4129         * exceptions.c (print_exception, exception_print)
4130         (exception_fprintf, exception_print_same): Update.
4131         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4132         * dwarf-index-cache.c (index_cache::store)
4133         (index_cache::lookup_gdb_index): Update.
4134         * darwin-nat.c (maybe_cache_shell): Update.
4135         * cp-valprint.c (cp_print_value_fields): Update.
4136         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4137         (gcc_cplus_symbol_address): Update.
4138         * compile/compile-c-symbols.c (gcc_convert_symbol)
4139         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4140         * common/selftest.c: Update.
4141         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4142         a std::string.
4143         (exception_try_scope_entry, exception_try_scope_exit): Don't
4144         declare.
4145         (struct exception_try_scope): Remove.
4146         (TRY): Don't use exception_try_scope.
4147         (struct gdb_exception): Add constructor, operator=.
4148         <what>: New method.
4149         (struct gdb_exception_RETURN_MASK_ALL)
4150         (struct gdb_exception_RETURN_MASK_ERROR)
4151         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4152         (struct gdb_quit_bad_alloc): Update.
4153         * common/common-exceptions.c (exception_none): Change
4154         initializer.
4155         (struct catcher) <state, exception>: Initialize inline.
4156         <prev>: Remove member.
4157         (current_catcher): Remove.
4158         (catchers): New global.
4159         (exceptions_state_mc_init): Simplify.
4160         (catcher_pop): Remove.
4161         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4162         (try_scope_depth, exception_try_scope_entry)
4163         (exception_try_scope_exit): Remove.
4164         (throw_exception_sjlj): Update.
4165         (exception_messages, exception_messages_size): Remove.
4166         (throw_it): Simplify.
4167         (gdb_exception_sliced_copy): Remove.
4168         (throw_exception_cxx): Update.
4169         * cli/cli-script.c (script_from_file): Update.
4170         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4171         Update.
4172         * ada-valprint.c (ada_val_print): Update.
4173         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4174         (create_excep_cond_exprs): Update.
4175
4176 2019-04-08  Tom Tromey  <tom@tromey.com>
4177
4178         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4179         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4180         (TRY, CATCH, END_CATCH): Remove some definitions.
4181         * common/common-exceptions.c: Don't use GDB_XCPT.
4182         (catcher_list_size): Remove.
4183         (throw_exception, throw_it): Simplify.
4184
4185 2019-04-05  Tom Tromey  <tom@tromey.com>
4186
4187         Revert the header-sorting patch.
4188         * ft32-tdep.c: Revert.
4189         * frv-tdep.c: Revert.
4190         * frv-linux-tdep.c: Revert.
4191         * frame.c: Revert.
4192         * frame-unwind.c: Revert.
4193         * frame-base.c: Revert.
4194         * fork-child.c: Revert.
4195         * findvar.c: Revert.
4196         * findcmd.c: Revert.
4197         * filesystem.c: Revert.
4198         * filename-seen-cache.h: Revert.
4199         * filename-seen-cache.c: Revert.
4200         * fbsd-tdep.c: Revert.
4201         * fbsd-nat.h: Revert.
4202         * fbsd-nat.c: Revert.
4203         * f-valprint.c: Revert.
4204         * f-typeprint.c: Revert.
4205         * f-lang.c: Revert.
4206         * extension.h: Revert.
4207         * extension.c: Revert.
4208         * extension-priv.h: Revert.
4209         * expprint.c: Revert.
4210         * exec.h: Revert.
4211         * exec.c: Revert.
4212         * exceptions.c: Revert.
4213         * event-top.c: Revert.
4214         * event-loop.c: Revert.
4215         * eval.c: Revert.
4216         * elfread.c: Revert.
4217         * dwarf2read.h: Revert.
4218         * dwarf2read.c: Revert.
4219         * dwarf2loc.c: Revert.
4220         * dwarf2expr.h: Revert.
4221         * dwarf2expr.c: Revert.
4222         * dwarf2-frame.c: Revert.
4223         * dwarf2-frame-tailcall.c: Revert.
4224         * dwarf-index-write.h: Revert.
4225         * dwarf-index-write.c: Revert.
4226         * dwarf-index-common.c: Revert.
4227         * dwarf-index-cache.h: Revert.
4228         * dwarf-index-cache.c: Revert.
4229         * dummy-frame.c: Revert.
4230         * dtrace-probe.c: Revert.
4231         * disasm.h: Revert.
4232         * disasm.c: Revert.
4233         * disasm-selftests.c: Revert.
4234         * dictionary.c: Revert.
4235         * dicos-tdep.c: Revert.
4236         * demangle.c: Revert.
4237         * dcache.h: Revert.
4238         * dcache.c: Revert.
4239         * darwin-nat.h: Revert.
4240         * darwin-nat.c: Revert.
4241         * darwin-nat-info.c: Revert.
4242         * d-valprint.c: Revert.
4243         * d-namespace.c: Revert.
4244         * d-lang.c: Revert.
4245         * ctf.c: Revert.
4246         * csky-tdep.c: Revert.
4247         * csky-linux-tdep.c: Revert.
4248         * cris-tdep.c: Revert.
4249         * cris-linux-tdep.c: Revert.
4250         * cp-valprint.c: Revert.
4251         * cp-support.c: Revert.
4252         * cp-namespace.c: Revert.
4253         * cp-abi.c: Revert.
4254         * corelow.c: Revert.
4255         * corefile.c: Revert.
4256         * continuations.c: Revert.
4257         * completer.h: Revert.
4258         * completer.c: Revert.
4259         * complaints.c: Revert.
4260         * coffread.c: Revert.
4261         * coff-pe-read.c: Revert.
4262         * cli-out.h: Revert.
4263         * cli-out.c: Revert.
4264         * charset.c: Revert.
4265         * c-varobj.c: Revert.
4266         * c-valprint.c: Revert.
4267         * c-typeprint.c: Revert.
4268         * c-lang.c: Revert.
4269         * buildsym.c: Revert.
4270         * buildsym-legacy.c: Revert.
4271         * build-id.h: Revert.
4272         * build-id.c: Revert.
4273         * btrace.c: Revert.
4274         * bsd-uthread.c: Revert.
4275         * breakpoint.h: Revert.
4276         * breakpoint.c: Revert.
4277         * break-catch-throw.c: Revert.
4278         * break-catch-syscall.c: Revert.
4279         * break-catch-sig.c: Revert.
4280         * blockframe.c: Revert.
4281         * block.c: Revert.
4282         * bfin-tdep.c: Revert.
4283         * bfin-linux-tdep.c: Revert.
4284         * bfd-target.c: Revert.
4285         * bcache.c: Revert.
4286         * ax-general.c: Revert.
4287         * ax-gdb.h: Revert.
4288         * ax-gdb.c: Revert.
4289         * avr-tdep.c: Revert.
4290         * auxv.c: Revert.
4291         * auto-load.c: Revert.
4292         * arm-wince-tdep.c: Revert.
4293         * arm-tdep.c: Revert.
4294         * arm-symbian-tdep.c: Revert.
4295         * arm-pikeos-tdep.c: Revert.
4296         * arm-obsd-tdep.c: Revert.
4297         * arm-nbsd-tdep.c: Revert.
4298         * arm-nbsd-nat.c: Revert.
4299         * arm-linux-tdep.c: Revert.
4300         * arm-linux-nat.c: Revert.
4301         * arm-fbsd-tdep.c: Revert.
4302         * arm-fbsd-nat.c: Revert.
4303         * arm-bsd-tdep.c: Revert.
4304         * arch-utils.c: Revert.
4305         * arc-tdep.c: Revert.
4306         * arc-newlib-tdep.c: Revert.
4307         * annotate.h: Revert.
4308         * annotate.c: Revert.
4309         * amd64-windows-tdep.c: Revert.
4310         * amd64-windows-nat.c: Revert.
4311         * amd64-tdep.c: Revert.
4312         * amd64-sol2-tdep.c: Revert.
4313         * amd64-obsd-tdep.c: Revert.
4314         * amd64-obsd-nat.c: Revert.
4315         * amd64-nbsd-tdep.c: Revert.
4316         * amd64-nbsd-nat.c: Revert.
4317         * amd64-nat.c: Revert.
4318         * amd64-linux-tdep.c: Revert.
4319         * amd64-linux-nat.c: Revert.
4320         * amd64-fbsd-tdep.c: Revert.
4321         * amd64-fbsd-nat.c: Revert.
4322         * amd64-dicos-tdep.c: Revert.
4323         * amd64-darwin-tdep.c: Revert.
4324         * amd64-bsd-nat.c: Revert.
4325         * alpha-tdep.c: Revert.
4326         * alpha-obsd-tdep.c: Revert.
4327         * alpha-nbsd-tdep.c: Revert.
4328         * alpha-mdebug-tdep.c: Revert.
4329         * alpha-linux-tdep.c: Revert.
4330         * alpha-linux-nat.c: Revert.
4331         * alpha-bsd-tdep.c: Revert.
4332         * alpha-bsd-nat.c: Revert.
4333         * aix-thread.c: Revert.
4334         * agent.c: Revert.
4335         * addrmap.c: Revert.
4336         * ada-varobj.c: Revert.
4337         * ada-valprint.c: Revert.
4338         * ada-typeprint.c: Revert.
4339         * ada-tasks.c: Revert.
4340         * ada-lang.c: Revert.
4341         * aarch64-tdep.c: Revert.
4342         * aarch64-ravenscar-thread.c: Revert.
4343         * aarch64-newlib-tdep.c: Revert.
4344         * aarch64-linux-tdep.c: Revert.
4345         * aarch64-linux-nat.c: Revert.
4346         * aarch64-fbsd-tdep.c: Revert.
4347         * aarch64-fbsd-nat.c: Revert.
4348         * aarch32-linux-nat.c: Revert.
4349
4350 2019-04-05  Tom Tromey  <tom@tromey.com>
4351
4352         * ft32-tdep.c: Sort headers.
4353         * frv-tdep.c: Sort headers.
4354         * frv-linux-tdep.c: Sort headers.
4355         * frame.c: Sort headers.
4356         * frame-unwind.c: Sort headers.
4357         * frame-base.c: Sort headers.
4358         * fork-child.c: Sort headers.
4359         * findvar.c: Sort headers.
4360         * findcmd.c: Sort headers.
4361         * filesystem.c: Sort headers.
4362         * filename-seen-cache.h: Sort headers.
4363         * filename-seen-cache.c: Sort headers.
4364         * fbsd-tdep.c: Sort headers.
4365         * fbsd-nat.h: Sort headers.
4366         * fbsd-nat.c: Sort headers.
4367         * f-valprint.c: Sort headers.
4368         * f-typeprint.c: Sort headers.
4369         * f-lang.c: Sort headers.
4370         * extension.h: Sort headers.
4371         * extension.c: Sort headers.
4372         * extension-priv.h: Sort headers.
4373         * expprint.c: Sort headers.
4374         * exec.h: Sort headers.
4375         * exec.c: Sort headers.
4376         * exceptions.c: Sort headers.
4377         * event-top.c: Sort headers.
4378         * event-loop.c: Sort headers.
4379         * eval.c: Sort headers.
4380         * elfread.c: Sort headers.
4381         * dwarf2read.h: Sort headers.
4382         * dwarf2read.c: Sort headers.
4383         * dwarf2loc.c: Sort headers.
4384         * dwarf2expr.h: Sort headers.
4385         * dwarf2expr.c: Sort headers.
4386         * dwarf2-frame.c: Sort headers.
4387         * dwarf2-frame-tailcall.c: Sort headers.
4388         * dwarf-index-write.h: Sort headers.
4389         * dwarf-index-write.c: Sort headers.
4390         * dwarf-index-common.c: Sort headers.
4391         * dwarf-index-cache.h: Sort headers.
4392         * dwarf-index-cache.c: Sort headers.
4393         * dummy-frame.c: Sort headers.
4394         * dtrace-probe.c: Sort headers.
4395         * disasm.h: Sort headers.
4396         * disasm.c: Sort headers.
4397         * disasm-selftests.c: Sort headers.
4398         * dictionary.c: Sort headers.
4399         * dicos-tdep.c: Sort headers.
4400         * demangle.c: Sort headers.
4401         * dcache.h: Sort headers.
4402         * dcache.c: Sort headers.
4403         * darwin-nat.h: Sort headers.
4404         * darwin-nat.c: Sort headers.
4405         * darwin-nat-info.c: Sort headers.
4406         * d-valprint.c: Sort headers.
4407         * d-namespace.c: Sort headers.
4408         * d-lang.c: Sort headers.
4409         * ctf.c: Sort headers.
4410         * csky-tdep.c: Sort headers.
4411         * csky-linux-tdep.c: Sort headers.
4412         * cris-tdep.c: Sort headers.
4413         * cris-linux-tdep.c: Sort headers.
4414         * cp-valprint.c: Sort headers.
4415         * cp-support.c: Sort headers.
4416         * cp-namespace.c: Sort headers.
4417         * cp-abi.c: Sort headers.
4418         * corelow.c: Sort headers.
4419         * corefile.c: Sort headers.
4420         * continuations.c: Sort headers.
4421         * completer.h: Sort headers.
4422         * completer.c: Sort headers.
4423         * complaints.c: Sort headers.
4424         * coffread.c: Sort headers.
4425         * coff-pe-read.c: Sort headers.
4426         * cli-out.h: Sort headers.
4427         * cli-out.c: Sort headers.
4428         * charset.c: Sort headers.
4429         * c-varobj.c: Sort headers.
4430         * c-valprint.c: Sort headers.
4431         * c-typeprint.c: Sort headers.
4432         * c-lang.c: Sort headers.
4433         * buildsym.c: Sort headers.
4434         * buildsym-legacy.c: Sort headers.
4435         * build-id.h: Sort headers.
4436         * build-id.c: Sort headers.
4437         * btrace.c: Sort headers.
4438         * bsd-uthread.c: Sort headers.
4439         * breakpoint.h: Sort headers.
4440         * breakpoint.c: Sort headers.
4441         * break-catch-throw.c: Sort headers.
4442         * break-catch-syscall.c: Sort headers.
4443         * break-catch-sig.c: Sort headers.
4444         * blockframe.c: Sort headers.
4445         * block.c: Sort headers.
4446         * bfin-tdep.c: Sort headers.
4447         * bfin-linux-tdep.c: Sort headers.
4448         * bfd-target.c: Sort headers.
4449         * bcache.c: Sort headers.
4450         * ax-general.c: Sort headers.
4451         * ax-gdb.h: Sort headers.
4452         * ax-gdb.c: Sort headers.
4453         * avr-tdep.c: Sort headers.
4454         * auxv.c: Sort headers.
4455         * auto-load.c: Sort headers.
4456         * arm-wince-tdep.c: Sort headers.
4457         * arm-tdep.c: Sort headers.
4458         * arm-symbian-tdep.c: Sort headers.
4459         * arm-pikeos-tdep.c: Sort headers.
4460         * arm-obsd-tdep.c: Sort headers.
4461         * arm-nbsd-tdep.c: Sort headers.
4462         * arm-nbsd-nat.c: Sort headers.
4463         * arm-linux-tdep.c: Sort headers.
4464         * arm-linux-nat.c: Sort headers.
4465         * arm-fbsd-tdep.c: Sort headers.
4466         * arm-fbsd-nat.c: Sort headers.
4467         * arm-bsd-tdep.c: Sort headers.
4468         * arch-utils.c: Sort headers.
4469         * arc-tdep.c: Sort headers.
4470         * arc-newlib-tdep.c: Sort headers.
4471         * annotate.h: Sort headers.
4472         * annotate.c: Sort headers.
4473         * amd64-windows-tdep.c: Sort headers.
4474         * amd64-windows-nat.c: Sort headers.
4475         * amd64-tdep.c: Sort headers.
4476         * amd64-sol2-tdep.c: Sort headers.
4477         * amd64-obsd-tdep.c: Sort headers.
4478         * amd64-obsd-nat.c: Sort headers.
4479         * amd64-nbsd-tdep.c: Sort headers.
4480         * amd64-nbsd-nat.c: Sort headers.
4481         * amd64-nat.c: Sort headers.
4482         * amd64-linux-tdep.c: Sort headers.
4483         * amd64-linux-nat.c: Sort headers.
4484         * amd64-fbsd-tdep.c: Sort headers.
4485         * amd64-fbsd-nat.c: Sort headers.
4486         * amd64-dicos-tdep.c: Sort headers.
4487         * amd64-darwin-tdep.c: Sort headers.
4488         * amd64-bsd-nat.c: Sort headers.
4489         * alpha-tdep.c: Sort headers.
4490         * alpha-obsd-tdep.c: Sort headers.
4491         * alpha-nbsd-tdep.c: Sort headers.
4492         * alpha-mdebug-tdep.c: Sort headers.
4493         * alpha-linux-tdep.c: Sort headers.
4494         * alpha-linux-nat.c: Sort headers.
4495         * alpha-bsd-tdep.c: Sort headers.
4496         * alpha-bsd-nat.c: Sort headers.
4497         * aix-thread.c: Sort headers.
4498         * agent.c: Sort headers.
4499         * addrmap.c: Sort headers.
4500         * ada-varobj.c: Sort headers.
4501         * ada-valprint.c: Sort headers.
4502         * ada-typeprint.c: Sort headers.
4503         * ada-tasks.c: Sort headers.
4504         * ada-lang.c: Sort headers.
4505         * aarch64-tdep.c: Sort headers.
4506         * aarch64-ravenscar-thread.c: Sort headers.
4507         * aarch64-newlib-tdep.c: Sort headers.
4508         * aarch64-linux-tdep.c: Sort headers.
4509         * aarch64-linux-nat.c: Sort headers.
4510         * aarch64-fbsd-tdep.c: Sort headers.
4511         * aarch64-fbsd-nat.c: Sort headers.
4512         * aarch32-linux-nat.c: Sort headers.
4513
4514 2019-04-04  Tom Tromey  <tom@tromey.com>
4515
4516         * varobj.c (varobj_create): Update.
4517         * rust-exp.y (struct rust_parser) <update_innermost_block,
4518         lookup_symbol>: New methods.
4519         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4520         Rename.
4521         (rust_parser::rust_lookup_type)
4522         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4523         * printcmd.c (display_command, do_one_display): Update.
4524         * parser-defs.h (struct parser_state) <parser_state>: Add
4525         "tracker" parameter.
4526         (block_tracker): New member.
4527         (class innermost_block_tracker) <innermost_block_tracker>: Add
4528         "types" parameter.
4529         <reset>: Remove method.
4530         (innermost_block): Don't declare.
4531         (null_post_parser): Update.
4532         * parse.c (innermost_block): Remove global.
4533         (write_dollar_variable): Update.
4534         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4535         Remove "tracker_types" parameter.
4536         (parse_expression): Add "tracker" parameter.
4537         (parse_expression_for_completion): Update.
4538         (null_post_parser): Add "tracker" parameter.
4539         * p-exp.y: Update rules.
4540         * m2-exp.y: Update rules.
4541         * language.h (struct language_defn) <la_post_parser>: Add
4542         "tracker" parameter.
4543         * go-exp.y: Update rules.
4544         * f-exp.y: Update rules.
4545         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4546         parameter.
4547         * d-exp.y: Update rules.
4548         * c-exp.y: Update rules.
4549         * breakpoint.c (set_breakpoint_condition): Create an
4550         innermost_block_tracker.
4551         (watch_command_1): Likewise.
4552         * ada-lang.c (resolve): Add "tracker" parameter.
4553         (resolve_subexp): Likewise.
4554         * ada-exp.y (write_var_from_sym): Update.
4555
4556 2019-04-04  Tom Tromey  <tom@tromey.com>
4557
4558         * type-stack.h: New file.
4559         * type-stack.c: New file.
4560         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4561         type-stack.h.
4562         (insert_into_type_stack, insert_type, push_type, push_type_int)
4563         (insert_type_address_space, pop_type, pop_type_int)
4564         (pop_typelist, pop_type_stack, append_type_stack)
4565         (push_type_stack, get_type_stack, push_typelist)
4566         (follow_type_instance_flags, follow_types): Don't declare.
4567         * parse.c (type_stack): Remove global.
4568         (parse_exp_in_context): Update.
4569         (insert_into_type_stack, insert_type, push_type, push_type_int)
4570         (insert_type_address_space, pop_type, pop_type_int)
4571         (pop_typelist, pop_type_stack, append_type_stack)
4572         (push_type_stack, get_type_stack, push_typelist)
4573         (follow_type_instance_flags, follow_types): Remove (moved to
4574         type-stack.c).
4575         * f-exp.y (type_stack): New global.
4576         Update rules.
4577         (push_kind_type, f_parse): Update.
4578         * d-exp.y (type_stack): New global.
4579         Update rules.
4580         (d_parse): Update.
4581         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4582         Update rules.
4583         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4584         (HFILES_NO_SRCDIR): Add type-stack.h.
4585
4586 2019-04-04  Tom Tromey  <tom@tromey.com>
4587
4588         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4589         (rust_parser::convert_ast_to_expression, rust_parse)
4590         (rust_lex_test_completion, rust_lex_tests): Update.
4591         * parser-defs.h (struct expr_completion_state): New.
4592         (struct parser_state) <parser_state>: Add completion parameter.
4593         <mark_struct_expression, mark_completion_tag>: New methods.
4594         <parse_completion, m_completion_state>: New members.
4595         (prefixify_expression, null_post_parser): Update.
4596         (mark_struct_expression, mark_completion_tag): Don't declare.
4597         * parse.c (parse_completion, expout_last_struct)
4598         (expout_tag_completion_type, expout_completion_name): Remove
4599         globals.
4600         (parser_state::mark_struct_expression)
4601         (parser_state::mark_completion_tag): Now methods.
4602         (prefixify_expression): Add last_struct parameter.
4603         (prefixify_subexp): Likewise.
4604         (parse_exp_1): Update.
4605         (parse_exp_in_context): Add cstate parameter.  Update.
4606         (parse_expression_for_completion): Create an
4607         expr_completion_state.
4608         (null_post_parser): Add "completion" parameter.
4609         * p-exp.y: Update rules.
4610         (yylex): Update.
4611         * language.h (struct language_defn) <la_post_parser>: Add
4612         "completing" parameter.
4613         * go-exp.y: Update rules.
4614         (lex_one_token): Update.
4615         * expression.h (parse_completion): Don't declare.
4616         * d-exp.y: Update rules.
4617         (lex_one_token): Update rules.
4618         * c-exp.y: Update rules.
4619         (lex_one_token): Update.
4620         * ada-lang.c (resolve): Add "parse_completion" parameter.
4621         (resolve_subexp): Likewise.
4622         (ada_resolve_function): Likewise.
4623
4624 2019-04-04  Tom Tromey  <tom@tromey.com>
4625
4626         * parser-defs.h (struct parser_state) <start_arglist,
4627         end_arglist>: New methods.
4628         <arglist_len, m_funcall_chain>: New members.
4629         (arglist_len, start_arglist, end_arglist): Don't declare.
4630         * parse.c (arglist_len, funcall_chain): Remove global.
4631         (start_arglist, end_arglist): Remove functions.
4632         (parse_exp_in_context): Update.
4633         * p-exp.y: Update rules.
4634         * m2-exp.y: Update rules.
4635         * go-exp.y: Update rules.
4636         * f-exp.y: Update rules.
4637         * d-exp.y: Update rules.
4638         * c-exp.y: Update rules.
4639
4640 2019-04-04  Tom Tromey  <tom@tromey.com>
4641
4642         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4643         lex_operator, push_back>: New methods.
4644         Update all rules.
4645         (rust_parser::lex_hex, lex_escape): Rename and update.
4646         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4647         (rust_parser::lex_operator): Rename and update.
4648         (rust_parser::lex_number, rustyylex, rustyyerror)
4649         (rust_lex_test_init, rust_lex_test_sequence)
4650         (rust_lex_test_push_back, rust_lex_tests): Update.
4651         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4652         parameter.
4653         <lexptr, prev_lexptr>: New members.
4654         (lexptr, prev_lexptr): Don't declare.
4655         * parse.c (lexptr, prev_lexptr): Remove globals.
4656         (parse_exp_in_context): Update.
4657         * p-exp.y (yylex, yyerror): Update.
4658         * m2-exp.y (parse_number, yylex, yyerror): Update.
4659         * go-exp.y (lex_one_token, yyerror): Update.
4660         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4661         * d-exp.y (lex_one_token, yyerror): Update.
4662         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4663         (lex_one_token, yyerror): Update.
4664         * ada-lex.l (YY_INPUT): Update.
4665         (rewind_to_char): Update.
4666         * ada-exp.y (yyerror): Update.
4667
4668 2019-04-04  Tom Tromey  <tom@tromey.com>
4669
4670         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4671         * parser-defs.h (struct parser_state) <parser_state>: Add new
4672         parameter.
4673         <comma_terminates>: New member.
4674         (comma_terminates): Don't declare global.
4675         * parse.c (comma_terminates): Remove global.
4676         (parse_exp_in_context): Update.
4677         * p-exp.y (yylex): Update.
4678         * m2-exp.y (yylex): Update.
4679         * go-exp.y (lex_one_token): Update.
4680         * f-exp.y (yylex): Update.
4681         * d-exp.y (lex_one_token): Update.
4682         * c-exp.y (lex_one_token): Update.
4683         * ada-lex.l: Update.
4684
4685 2019-04-04  Tom Tromey  <tom@tromey.com>
4686
4687         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4688         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4689         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4690         * parser-defs.h (paren_depth): Don't declare.
4691         * parse.c (paren_depth): Remove global.
4692         (parse_exp_in_context): Update.
4693         * p-exp.y (paren_depth): New global.
4694         (pascal_parse): Initialize it.
4695         * m2-exp.y (paren_depth): New global.
4696         (m2_parse): Initialize it.
4697         * go-exp.y (paren_depth): New global.
4698         (go_parse): Initialize it.
4699         * f-exp.y (paren_depth): New global.
4700         (f_parse): Initialize it.
4701         * d-exp.y (paren_depth): New global.
4702         (d_parse): Initialize it.
4703         * c-exp.y (paren_depth): New global.
4704         (c_parse): Initialize it.
4705         * ada-lex.l (paren_depth): New global.
4706         (lexer_init): Initialize it.
4707
4708 2019-04-04  Tom Tromey  <tom@tromey.com>
4709
4710         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4711         (rust_parser::convert_ast_to_type)
4712         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4713         * parser-defs.h (struct parser_state) <parser_state>: Add
4714         parameters.  Initialize new members.
4715         <expression_context_block, expression_context_pc>: New members.
4716         * parse.c (expression_context_block, expression_context_pc):
4717         Remove globals.
4718         (parse_exp_in_context): Update.
4719         * p-exp.y: Update all rules.
4720         (yylex): Update.
4721         * m2-exp.y: Update all rules.
4722         (yylex): Update.
4723         * go-exp.y (yylex): Update.
4724         * f-exp.y (yylex): Update.
4725         * d-exp.y: Update all rules.
4726         (yylex): Update.
4727         * c-exp.y: Update all rules.
4728         (lex_one_token, classify_name, yylex, c_parse): Update.
4729         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4730
4731 2019-04-04  Tom Tromey  <tom@tromey.com>
4732
4733         * gdbarch.h, gdbarch.c: Rebuild.
4734         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4735         * stap-probe.h:
4736         (struct stap_parse_info): Replace "parser_state" with
4737         "expr_builder".
4738         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4739         (parser_state): New class.
4740         * parse.c (expr_builder): Rename.
4741         (expr_builder::release): Rename.
4742         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4743         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4744         (write_exp_elt_longcst, write_exp_elt_floatcst)
4745         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4746         (write_exp_string_vector, write_exp_bitstring)
4747         (write_exp_msymbol, mark_struct_expression)
4748         (write_dollar_variable)
4749         (insert_type_address_space, increase_expout_size): Replace
4750         "parser_state" with "expr_builder".
4751         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4752         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4753         "parser_state" with "expr_builder".
4754
4755 2019-04-04  Tom Tromey  <tom@tromey.com>
4756
4757         * rust-exp.y: Replace "parse_language" with method call.
4758         * p-exp.y:
4759         (yylex): Replace "parse_language" with method call.
4760         * m2-exp.y:
4761         (yylex): Replace "parse_language" with method call.
4762         * go-exp.y (classify_name): Replace "parse_language" with method
4763         call.
4764         * f-exp.y (yylex): Replace "parse_language" with method call.
4765         * d-exp.y (lex_one_token): Replace "parse_language" with method
4766         call.
4767         * c-exp.y:
4768         (lex_one_token, classify_name, yylex): Replace "parse_language"
4769         with method call.
4770         * ada-exp.y (find_primitive_type, type_char)
4771         (type_system_address): Replace "parse_language" with method call.
4772
4773 2019-04-04  Tom Tromey  <tom@tromey.com>
4774
4775         * rust-exp.y: Replace "parse_gdbarch" with method call.
4776         * parse.c (write_dollar_variable, insert_type_address_space):
4777         Replace "parse_gdbarch" with method call.
4778         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4779         call.
4780         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4781         call.
4782         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4783         "parse_gdbarch" with method call.
4784         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4785         with method call.
4786         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4787         "parse_gdbarch" with method call.
4788         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4789         "parse_gdbarch" with method call.
4790         * c-exp.y (parse_type, parse_number, classify_name): Replace
4791         "parse_gdbarch" with method call.
4792         * ada-lex.l: Replace "parse_gdbarch" with method call.
4793         * ada-exp.y (parse_type, find_primitive_type, type_char)
4794         (type_system_address): Replace "parse_gdbarch" with method call.
4795
4796 2019-04-04  Tom Tromey  <tom@tromey.com>
4797
4798         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4799         * stap-probe.c (stap_parse_argument): Update.
4800         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4801         initial_size parameter.
4802         * rust-exp.y (rust_lex_tests): Update.
4803         * parse.c (parser_state): Update.
4804         (parse_exp_in_context): Update.
4805         * parser-defs.h (struct parser_state) <parser_state>: Remove
4806         "initial_size" parameter.
4807
4808 2019-04-04  Tom Tromey  <tom@tromey.com>
4809
4810         * parser-defs.h (increase_expout_size): Don't declare.
4811         * parse.c (increase_expout_size): Now static.
4812
4813 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4814
4815         * gnu-nat.c (gnu_nat_target::wait): Fix
4816         target_waitstatus_to_string call.
4817
4818 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4819
4820         * eval.c (evaluate_subexp_standard): Handle internal functions
4821         during Fortran function call handling.
4822
4823 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4824
4825         * NEWS: Mention new internal functions.
4826         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4827         (read_base_type): Use dwarf2_init_complex_target_type.
4828         * value.c (creal_internal_fn): New function.
4829         (cimag_internal_fn): New function.
4830         (_initialize_values): Register new internal functions.
4831
4832 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4833
4834         * infrun.c (stop_all_threads): If debug_infrun, always
4835         trace the wait status after wait_one, using
4836         target_waitstatus_to_string and target_pid_to_str.
4837         (handle_inferior_event): Replace various trace of
4838         wait status kind by a single trace.
4839         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4840         wait status kind image by target_waitstatus_to_string.
4841         * target/waitstatus.c (target_waitstatus_to_string): Fix
4842         obsolete comment.
4843
4844 2019-04-01  Tom Tromey  <tromey@adacore.com>
4845
4846         PR symtab/23331:
4847         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4848
4849 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4850             Pedro Alves  <palves@redhat.com>
4851
4852         * top.c (quit_force): Call 'finalize_values'.
4853         * value.c (finalize_values): New function.
4854         * value.h (finalize_values): Declare.
4855
4856 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4857
4858         * NEWS: Announce $_gdb_major and $_gdb_minor.
4859
4860         * top.c (init_gdb_version_vars): New function.
4861         (gdb_init): Call init_gdb_version_vars.
4862
4863 2019-03-29  Tom Tromey  <tromey@adacore.com>
4864
4865         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4866         help text.  Remove dead code.
4867
4868 2019-03-29  Keith Seitz  <keiths@redhat.com>
4869
4870         From Siddhesh Poyarekar:
4871         * f-lang.h (f77_get_upperbound): Return LONGEST.
4872         (f77_get_lowerbound): Likewise.
4873         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4874         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4875         print them.
4876         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4877         plongest to format print it.
4878         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4879         (f77_get_upperbound): Likewise.
4880         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4881         LOWER_BOUND to LONGEST.
4882         (f77_create_arrayprint_offset_tbl): Likewise.
4883
4884 2019-03-29  Keith Seitz  <keiths@redhat.com>
4885
4886         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4887         %s/pulongest for TYPE_LENGTH instead of %d in format
4888         strings.
4889         * ada-typerint.c (ada_print_type): Likewise.
4890         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4891         * compile/compile-c-support.c (generate_register_struct): Likewise.
4892         * gdbtypes.c (recursive_dump_type): Likewise.
4893         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4894         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4895         instead of %d in format strings.
4896         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4897         to std::min to ULONGEST.
4898         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4899         instead of %d in format strings.
4900         * tracepoint.c (info_scope_command): Likewise.
4901         * typeprint.c (print_offset_data::update)
4902         (print_offset_data::finish): Likewise.
4903         * xtensa-tdep.c (xtensa_store_return_value)
4904         (xtensa_push_dummy_call): Likewise.
4905
4906 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4907
4908         * windows-nat.c (display_selector): Fixed format specifications
4909         for 64-bit Cygwin.
4910
4911 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4912
4913         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4914
4915 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4916
4917         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4918         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4919         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4920         (nios2_linux_init_abi): Install it.
4921
4922 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4923
4924         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4925
4926 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4927
4928         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4929
4930 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4931             Tom Tromey  <tromey@adacore.com>
4932
4933         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4934
4935 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4936
4937         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4938         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4939         method to compute the bounds of range types. Also print "[evaluated]"
4940         if the bounds' values come from a dynamic evaluation.
4941
4942 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4943
4944         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4945         whitespace when pretty printing is on.
4946
4947 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4948
4949         * ppc-linux-nat.c: Add include.
4950
4951 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4952
4953         * NEWS: Mention AArch64 Pointer Authentication.
4954
4955 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4956
4957         * arm-linux-nat.c: Add include.
4958
4959 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4960
4961         * source-cache.c (source_cache::get_source_lines): Re-read
4962         fullname after calling open_source_file.
4963
4964 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4965
4966         * NEWS: Mention TLS support for FreeBSD.
4967
4968 2019-03-25  Tom Tromey  <tromey@adacore.com>
4969
4970         * minsyms.c (BUNCH_SIZE): Update comment.
4971         (~minimal_symbol_reader): Remove old comment.
4972         (compact_minimal_symbols): Update comment.
4973         (minimal_symbol_reader::install): Remove old comment.  Update
4974         other comments.
4975
4976 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4977
4978         * s390-linux-nat.c: Add include.
4979
4980 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4981
4982         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4983         Call linux_get_hwcap.
4984         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4985         Likewise.
4986         (aarch64_linux_get_hwcap): Remove function.
4987         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4988         declaration.
4989         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4990         linux_get_hwcap.
4991         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4992         * linux-tdep.c (linux_get_hwcap): Add function.
4993         (linux_get_hwcap2): Likewise.
4994         * linux-tdep.h (linux_get_hwcap): Add declaration.
4995         (linux_get_hwcap2): Likewise.
4996         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4997         (ppc_linux_get_hwcap2): Likewise.
4998         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4999         linux_get_hwcap.
5000         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5001         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5002         (ppc_linux_nat_target::read_description): Likewise.
5003         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5004         * s390-linux-nat.c: Likewise.
5005         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5006
5007 2019-03-24  Tom Tromey  <tom@tromey.com>
5008
5009         * ada-lang.c (standard_lookup): Simplify initialization.
5010         (ada_lookup_symbol_nonlocal): Simplify return.
5011         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5012         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5013         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5014         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5015         initialization.
5016         * solib.c (solib_global_lookup): Simplify.
5017         * symtab.c (null_block_symbol): Remove.
5018         (symbol_cache_lookup): Simplify returns.
5019         (lookup_language_this): Simplify returns.
5020         (lookup_symbol_aux): Simplify return.
5021         (lookup_local_symbol): Simplify returns.
5022         (lookup_global_symbol_from_objfile): Simplify return.
5023         (lookup_symbol_in_objfile_symtabs)
5024         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5025         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5026         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5027         * cp-namespace.c (cp_lookup_bare_symbol)
5028         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5029         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5030         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5031         (cp_lookup_symbol_via_imports): Simplify initialization.
5032         (find_symbol_in_baseclass): Likewise.
5033         * symtab.h (null_block_symbol): Remove.
5034         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5035         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5036         (d_lookup_symbol_module): Likewise.
5037         (find_symbol_in_baseclass): Simplify initialization.
5038
5039 2019-03-24  Tom Tromey  <tom@tromey.com>
5040
5041         * expression.h: Don't include symtab.h.
5042         (struct block): Forward declare.
5043
5044 2019-03-24  Tom Tromey  <tom@tromey.com>
5045
5046         * c-exp.y (typebase): Remove casts.
5047         * gdbtypes.c (lookup_unsigned_typename, )
5048         (lookup_signed_typename): Remove cast.
5049         * eval.c (parse_to_comma_and_eval): Remove cast.
5050         * parse.c (write_dollar_variable): Remove cast.
5051         * block.h (struct block) <superblock>: Now const.
5052         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5053         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5054         (map_block): Make "block" const.
5055         * symfile.h (struct quick_symbol_functions)
5056         <map_matching_symbols>: Constify block argument to "callback".
5057         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5058         const.
5059         (find_pc_sect_compunit_symtab): Make "b" const.
5060         (find_symbol_at_address): Likewise.
5061         (search_symbols): Likewise.
5062         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5063         (dw2_debug_names_lookup_symbol): Likewise.
5064         (dw2_map_matching_symbols): Update.
5065         * p-valprint.c (pascal_val_print): Remove "block".
5066         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5067         (aux_add_nonlocal_symbols): Make "block" const.
5068         (resolve_subexp): Remove cast.
5069         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5070         const.
5071         (iterate_over_file_blocks): Likewise.
5072         * f-exp.y (%union) <bval>: Remove.
5073         * coffread.c (patch_opaque_types): Make "b" const.
5074         * spu-tdep.c (spu_catch_start): Make "block" const.
5075         * c-valprint.c (print_unpacked_pointer): Remove "block".
5076         * symmisc.c (dump_symtab_1): Make "b" const.
5077         (block_depth): Make "block" const.
5078         * d-exp.y (%union) <bval>: Remove.
5079         * cp-support.h (cp_lookup_rtti_type): Update.
5080         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5081         * psymtab.c (psym_lookup_symbol): Make "block" const.
5082         (maintenance_check_psymtabs): Make "b" const.
5083         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5084         (enumerate_locals, enumerate_args): Update.
5085         * python/py-symtab.c (stpy_global_block): Make "block" const.
5086         (stpy_static_block): Likewise.
5087         * inline-frame.c (block_starting_point_at): Make "new_block"
5088         const.
5089         * block.c (find_block_in_blockvector): Make return type const.
5090         (blockvector_for_pc_sect): Make "b" const.
5091         (find_block_in_blockvector): Make "b" const.
5092
5093 2019-03-23  Tom Tromey  <tom@tromey.com>
5094
5095         * varobj.c (varobj_create): Update.
5096         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5097         * printcmd.c (display_command, do_one_display): Don't reset
5098         innermost_block.
5099         * parser-defs.h (enum innermost_block_tracker_type): Move to
5100         expression.h.
5101         (innermost_block): Update comment.
5102         * parse.c (parse_exp_1): Add tracker_types parameter.
5103         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5104         tracker_types parameter.  Reset innermost_block.
5105         (parse_exp_in_context): Remove.
5106         (parse_expression_for_completion): Update.
5107         * objfiles.c (~objfile): Don't reset expression_context_block or
5108         innermost_block.
5109         * expression.h (enum innermost_block_tracker_type): Move from
5110         parser-defs.h.
5111         (parse_exp_1): Add tracker_types parameter.
5112         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5113         reset innermost_block.
5114
5115 2019-03-23  Tom Tromey  <tom@tromey.com>
5116
5117         * objfiles.h: Include bcache.h.
5118
5119 2019-03-23  Tom Tromey  <tom@tromey.com>
5120
5121         * linespec.c (get_current_search_block): Use
5122         scoped_restore_current_language.
5123         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5124
5125 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5126             Jiong Wang  <jiong.wang@arm.com>
5127
5128         * aarch64-linux-tdep.c
5129         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5130         section.
5131         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5132
5133 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5134             Jiong Wang  <jiong.wang@arm.com>
5135
5136         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5137         instructions.
5138         (aarch64_analyze_prologue_test): Add PACIASP test.
5139         (aarch64_prologue_prev_register): Unmask PC value.
5140
5141 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5142             Jiong Wang  <jiong.wang@arm.com>
5143
5144         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5145         (aarch64_dwarf2_prev_register): Unmask PC value.
5146         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5147         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5148         DW_CFA_AARCH64_negate_ra_state.
5149         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5150
5151 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5152             Jiong Wang  <jiong.wang@arm.com>
5153
5154         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5155         registers.
5156         (aarch64_pseudo_register_name): Likewise.
5157         (aarch64_pseudo_register_type): Likewise.
5158         (aarch64_pseudo_register_reggroup_p): Likewise.
5159         (aarch64_gdbarch_init): Add pauth registers.
5160         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5161         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5162         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5163         (struct gdbarch_tdep): Add regnum for ra_state.
5164
5165 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5166             Jiong Wang  <jiong.wang@arm.com>
5167
5168         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5169
5170 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5171             Jiong Wang  <jiong.wang@arm.com>
5172
5173         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5174         function.
5175         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5176         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5177         (aarch64_gdbarch_init): Add puth registers.
5178         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5179         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5180         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5181
5182 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5183             Jiong Wang  <jiong.wang@arm.com>
5184
5185         * aarch64-linux-nat.c
5186         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5187         * aarch64-linux-tdep.c
5188         (aarch64_linux_core_read_description): Likewise.
5189         (aarch64_linux_get_hwcap): New function.
5190         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5191         (aarch64_linux_get_hwcap): New declaration.
5192
5193 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5194             Jiong Wang  <jiong.wang@arm.com>
5195
5196         * aarch64-linux-nat.c
5197         (aarch64_linux_nat_target::read_description): Add pauth param.
5198         * aarch64-linux-tdep.c
5199         (aarch64_linux_core_read_description): Likewise.
5200         * aarch64-tdep.c (struct target_desc): Add in pauth.
5201         (aarch64_read_description): Add pauth param.
5202         (aarch64_gdbarch_init): Likewise.
5203         * aarch64-tdep.h (aarch64_read_description): Likewise.
5204         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5205         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5206         * features/Makefile: Add new files.
5207         * features/aarch64-pauth.c: New file.
5208         * features/aarch64-pauth.xml: New file.
5209
5210 2019-03-20  Tom Tromey  <tromey@adacore.com>
5211
5212         * infrun.c (handle_inferior_event): Rename from
5213         handle_inferior_event_1.  Create a scoped_value_mark.
5214         (handle_inferior_event): Remove.
5215
5216 2019-03-19  Tom Tromey  <tromey@adacore.com>
5217
5218         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5219         * infrun.h (print_stop_event): Add "displays" parameter.
5220         * infrun.c (print_stop_event): Add "displays" parameter.
5221
5222 2019-03-19  Pedro Alves  <palves@redhat.com>
5223
5224         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5225         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5226         to -1.  Fix TABs vs spaces.
5227         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5228         * tui/tui-out.h (tui_ui_out) Add intro comments.
5229         <m_line, m_start_of_line>: In-class initialize, and add describing
5230         comment.
5231
5232 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5233
5234         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5235         variable names.
5236         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5237
5238 2019-03-18  Pedro Alves  <palves@redhat.com>
5239             Eli Zaretskii <eliz@gnu.org>
5240
5241         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5242         m_line and m_start_of_line.
5243
5244 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5245
5246         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5247         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5248         it returns a newline.  This fixes a regression in TU mode, whereby
5249         the next line is output on the same screen line as the user input.
5250
5251 2019-03-18  Tom Tromey  <tromey@adacore.com>
5252
5253         * minsyms.c (minimal_symbol_reader::install): Remove call to
5254         obstack_blank.
5255
5256 2019-03-18  Pedro Alves  <palves@redhat.com>
5257
5258         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5259         New globals.
5260         (apply_style): New, factored out from ...
5261         (apply_ansi_escape): ... this.  Handle reverse video mode.
5262         (tui_set_reverse_mode): New function.
5263         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5264         * tui/tui-winsource.c (tui_show_source_line): Use
5265         tui_set_reverse_mode instead of setting A_STANDOUT.
5266         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5267         New setter methods.
5268
5269 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5270
5271         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5272         Handle tabs.
5273
5274 2019-03-18  Tom Tromey  <tromey@adacore.com>
5275
5276         * ada-lang.c (empty_array): Add "high" parameter.
5277         (ada_evaluate_subexp): Update.
5278
5279 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5280
5281         * unittests/string_view-selftests.c: Define
5282         _initialize_string_view_selftests unconditionally.
5283
5284 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5285
5286         PR gdb/24350
5287         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5288
5289 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5290
5291         PR gdb/24351
5292         * windows-nat.c (display_selector): Fix format specifiers.
5293
5294 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5295
5296         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5297         tui_refill_source_window instead of tui_refresh_win, to update the
5298         current execution line.  This fixes redisplay of the current line
5299         when stepping through the code with "next" or "step".
5300
5301 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5302
5303         * source-cache.c (source_cache::get_source_lines): Call
5304         find_source_lines to initialize s->nlines.  This fixes vertical
5305         scrolling of TUI source window when the DOWN arrow is pressed.
5306
5307 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5308
5309         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5310         linux-thread-db.c (_initialize_thread_db): Likewise.
5311
5312 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5313
5314         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5315         wclrtoeol in tui_show_source_line".  This reverts changes made in
5316         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5317
5318 2019-03-15  Tom Tromey  <tom@tromey.com>
5319
5320         * symtab.h (struct minimal_symbol): Derive from
5321         general_symbol_info.
5322         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5323         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5324         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5325         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5326         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5327         (MSYMBOL_SEARCH_NAME): Update.
5328         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5329         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5330         * minsyms.c (minimal_symbol_reader::record_full): Update.
5331
5332 2019-03-15  Tom Tromey  <tom@tromey.com>
5333
5334         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5335
5336 2019-03-15  Tom Tromey  <tom@tromey.com>
5337
5338         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5339         unique_xmalloc_ptr.
5340         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5341         Update.
5342         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5343         (build_minimal_symbol_hash_tables)
5344         (minimal_symbol_reader::install): Update.
5345
5346 2019-03-15  Tom Tromey  <tom@tromey.com>
5347
5348         * symtab.c (create_demangled_names_hash): Update.
5349         (symbol_set_names): Update.
5350         * objfiles.h (struct objfile_per_bfd_storage)
5351         <demangled_names_hash>: Now an htab_up.
5352         * objfiles.c (objfile_per_bfd_storage): Simplify.
5353
5354 2019-03-15  Tom Tromey  <tom@tromey.com>
5355
5356         * objfiles.h (struct objfile_per_bfd_storage): Declare
5357         destructor.
5358         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5359         New.
5360         (get_objfile_bfd_data): Use new.  Don't initialize
5361         language_of_main.
5362         (free_objfile_per_bfd_storage): Remove.
5363         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5364
5365 2019-03-15  Tom Tromey  <tom@tromey.com>
5366
5367         * symfile.c (reread_symbols): Update.
5368         * objfiles.c (objfile::objfile): Update.
5369         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5370         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5371         comment.
5372         (minimal_symbol_reader::install): Update.
5373         (terminate_minimal_symbol_table): Remove.
5374         * jit.c (jit_object_close_impl): Update.
5375
5376 2019-03-15  Tom Tromey  <tom@tromey.com>
5377
5378         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5379         initializations.
5380
5381 2019-03-15  Tom Tromey  <tom@tromey.com>
5382
5383         * objfiles.h (struct objfile_per_bfd_storage)
5384         <demangled_hash_languages>: Now a bitset.
5385         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5386         (lookup_minimal_symbol): Update.
5387
5388 2019-03-15  Tom Tromey  <tom@tromey.com>
5389
5390         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5391         Don't return the symbol.
5392         * coffread.c (record_minimal_symbol): Use record_full.
5393
5394 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5395
5396         The MS-Windows port of ncurses fails to switch to a color pair if
5397         one or both of the colors are the implicit default colors.  This
5398         change records the default colors when TUI is initialized, and
5399         then specifies them explicitly when a color pair uses the default
5400         colors.  This allows color styling in TUI mode on MS-Windows.
5401
5402         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5403         ncurses_norm_attr.
5404         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5405         colors in ncurses_norm_attr.
5406         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5407         "none", replace it with the default color recorded in
5408         ncurses_norm_attr.
5409
5410 2019-03-14  Tom Tromey  <tromey@adacore.com>
5411
5412         * source-cache.h (class source_cache) <get_source_lines>: Return
5413         std::string.
5414         * source-cache.c (source_cache::extract_lines): Handle case where
5415         first_pos==npos.  Return std::string.
5416         (source_cache::get_source_lines): Update.
5417
5418 2019-03-14  Tom Tromey  <tromey@adacore.com>
5419
5420         * NEWS: Add item for "style sources" commands.
5421         * source-cache.c (source_cache::get_source_lines): Check
5422         source_styling.
5423         * cli/cli-style.c (source_styling): New global.
5424         (_initialize_cli_style): Add "style sources" commands.
5425         (show_style_sources): New function.
5426         * cli/cli-style.h (source_styling): Declare.
5427
5428 2019-03-14  Pedro Alves  <palves@redhat.com>
5429             Tom Tromey  <tromey@adacore.com>
5430
5431         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5432         * tui/tui-winsource.c (tui_refill_source_window): New function,
5433         from...
5434         (tui_horizontal_source_scroll): ... here.  Move some logic.
5435         * cli/cli-style.c (set_style_enabled): Notify new observable.
5436         * tui/tui-hooks.c (tui_redisplay_source): New function.
5437         (tui_attach_detach_observers): Attach or detach
5438         tui_redisplay_source.
5439         * observable.h (source_styling_changed): New observable.
5440         * observable.c: Define source_styling_changed observable.
5441
5442 2019-03-13  Tom Tromey  <tromey@adacore.com>
5443
5444         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5445         (i386_gnu_nat_target::store_registers): Update.
5446         * target-debug.h (target_debug_print_std_string): New macro.
5447         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5448         * windows-tdep.c (display_one_tib): Update.
5449         * tui/tui-stack.c (tui_make_status_line): Update.
5450         * top.c (print_inferior_quit_action): Update.
5451         * thread.c (thr_try_catch_cmd): Update.
5452         (add_thread_with_info): Update.
5453         (thread_target_id_str): Update.
5454         (thr_try_catch_cmd): Update.
5455         (thread_command): Update.
5456         (thread_find_command): Update.
5457         * record-btrace.c (record_btrace_target::info_record)
5458         (record_btrace_resume_thread, record_btrace_target::resume)
5459         (record_btrace_cancel_resume, record_btrace_step_thread)
5460         (record_btrace_target::wait, record_btrace_target::wait)
5461         (record_btrace_target::wait, record_btrace_target::stop): Update.
5462         * progspace.c (print_program_space): Update.
5463         * process-stratum-target.c
5464         (process_stratum_target::thread_address_space): Update.
5465         * linux-fork.c (linux_fork_mourn_inferior)
5466         (detach_checkpoint_command, info_checkpoints_command)
5467         (linux_fork_context): Update.
5468         (linux_fork_detach): Update.
5469         (class scoped_switch_fork_info): Update.
5470         (delete_checkpoint_command): Update.
5471         * infrun.c (follow_fork_inferior): Update.
5472         (follow_fork_inferior): Update.
5473         (proceed_after_vfork_done): Update.
5474         (handle_vfork_child_exec_or_exit): Update.
5475         (follow_exec): Update.
5476         (displaced_step_prepare_throw): Update.
5477         (displaced_step_restore): Update.
5478         (start_step_over): Update.
5479         (resume_1): Update.
5480         (clear_proceed_status_thread): Update.
5481         (proceed): Update.
5482         (print_target_wait_results): Update.
5483         (do_target_wait): Update.
5484         (context_switch): Update.
5485         (stop_all_threads): Update.
5486         (restart_threads): Update.
5487         (finish_step_over): Update.
5488         (handle_signal_stop): Update.
5489         (switch_back_to_stepped_thread): Update.
5490         (keep_going_pass_signal): Update.
5491         (print_exited_reason): Update.
5492         (normal_stop): Update.
5493         * inferior.c (inferior_pid_to_str): Change return type.
5494         (print_selected_inferior): Update.
5495         (add_inferior): Update.
5496         (detach_inferior): Update.
5497         * dummy-frame.c (fprint_dummy_frames): Update.
5498         * dcache.c (dcache_info_1): Update.
5499         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5500         (btrace_fetch, btrace_clear): Update.
5501         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5502         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5503         type.
5504         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5505         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5506         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5507         * gdbarch.c, gdbarch.h: Rebuild.
5508         * gdbarch.sh (core_pid_to_str): Change return type.
5509         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5510         return type.
5511         (windows_nat_target::pid_to_str): Change return type.
5512         (windows_delete_thread): Update.
5513         (windows_nat_target::attach): Update.
5514         (windows_nat_target::files_info): Update.
5515         * target-delegates.c: Rebuild.
5516         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5517         return type.
5518         (sol_thread_target::pid_to_str): Change return type.
5519         * remote.c (class remote_target) <pid_to_str>: Change return
5520         type.
5521         (remote_target::pid_to_str): Change return type.
5522         (extended_remote_target::attach, remote_target::remote_stop_ns)
5523         (remote_target::remote_notif_remove_queued_reply)
5524         (remote_target::push_stop_reply, remote_target::disable_btrace):
5525         Update.
5526         (extended_remote_target::attach): Update.
5527         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5528         type.
5529         (gdbsim_target::pid_to_str): Change return type.
5530         * ravenscar-thread.c (struct ravenscar_thread_target)
5531         <pid_to_str>: Change return type.
5532         (ravenscar_thread_target::pid_to_str): Change return type.
5533         * procfs.c (class procfs_target) <pid_to_str>: Change return
5534         type.
5535         (procfs_target::pid_to_str): Change return type.
5536         (procfs_target::attach): Update.
5537         (procfs_target::detach): Update.
5538         (procfs_target::fetch_registers): Update.
5539         (procfs_target::store_registers): Update.
5540         (procfs_target::wait): Update.
5541         (procfs_target::files_info): Update.
5542         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5543         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5544         return type.
5545         (nto_procfs_target::pid_to_str): Change return type.
5546         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5547         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5548         return type.
5549         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5550         (exit_lwp): Update.
5551         (attach_proc_task_lwp_callback, get_detach_signal)
5552         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5553         (linux_nat_target::resume, wait_lwp, stop_callback)
5554         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5555         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5556         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5557         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5558         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5559         type.
5560         (inf_ptrace_target::attach): Update.
5561         (inf_ptrace_target::files_info): Update.
5562         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5563         type.
5564         (go32_nat_target::pid_to_str): Change return type.
5565         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5566         (gnu_nat_target::wait): Update.
5567         (gnu_nat_target::wait): Update.
5568         (gnu_nat_target::resume): Update.
5569         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5570         (fbsd_nat_target::wait): Update.
5571         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5572         type.
5573         (darwin_nat_target::attach): Update.
5574         * corelow.c (class core_target) <pid_to_str>: Change return type.
5575         (core_target::pid_to_str): Change return type.
5576         * target.c (normal_pid_to_str): Change return type.
5577         (default_pid_to_str): Likewise.
5578         (target_pid_to_str): Change return type.
5579         (target_translate_tls_address): Update.
5580         (target_announce_detach): Update.
5581         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5582         return type.
5583         (bsd_uthread_target::pid_to_str): Change return type.
5584         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5585         type.
5586         (bsd_kvm_target::pid_to_str): Change return type.
5587         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5588         return type.
5589         (aix_thread_target::pid_to_str): Change return type.
5590         * target.h (struct target_ops) <pid_to_str>: Change return type.
5591         (target_pid_to_str, normal_pid_to_str): Likewise.
5592         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5593         type.
5594         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5595         type.
5596         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5597         return type.
5598         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5599         type.
5600         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5601         type.
5602         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5603         return type.
5604
5605 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5606
5607         * NEWS: Mention that the new default MI version is 3.  Mention
5608         changes to the output of commands and events that deal with
5609         multi-location breakpoints.
5610         * breakpoint.c: Include "mi/mi-out.h".
5611         (print_one_breakpoint): Change output syntax if using MI version
5612         >= 3.
5613         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5614         New.
5615         (mi_multi_location_breakpoint_output_fixed): New.
5616         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5617         (mi_cmd_fix_multi_location_breakpoint_output): New.
5618         (mi_multi_location_breakpoint_output_fixed): New.
5619         * mi/mi-cmds.c (mi_cmds): Register command
5620         -fix-multi-location-breakpoint-output.
5621         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5622         interpreter "mi".
5623
5624 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5625
5626         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5627         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5628         instantiate mi_ui_out based on interpreter name.
5629         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5630         * mi/mi-main.c (mi_load_progress): Likewise.
5631
5632 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5633
5634         * NEWS: Combine separate "New targets" sections for 8.3.
5635
5636 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5637
5638         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5639         (ppcfbsd_init_abi): Install gdbarch
5640         "fetch_tls_load_module_address" and "get_thread_local_address"
5641         methods.
5642
5643 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5644
5645         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5646         (riscv_fbsd_init_abi): Install gdbarch
5647         "fetch_tls_load_module_address" and "get_thread_local_address"
5648         methods.
5649
5650 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5651
5652         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5653         (i386fbsd_init_abi): Install gdbarch
5654         "fetch_tls_load_module_address" and "get_thread_local_address"
5655         methods.
5656
5657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5658
5659         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5660         (amd64fbsd_init_abi): Install gdbarch
5661         "fetch_tls_load_module_address" and "get_thread_local_address"
5662         methods.
5663
5664 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5665
5666         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5667         (struct fbsd_pspace_data): New type.
5668         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5669         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5670         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5671         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5672         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5673
5674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5675
5676         * gdbtypes.c (lookup_struct_elt): New function.
5677         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5678         * gdbtypes.h (struct struct_elt): New type.
5679         (lookup_struct_elt): New prototype.
5680
5681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5682
5683         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5684         remove disabled code block.
5685
5686 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5687
5688         * gdbarch.sh (get_thread_local_address): New method.
5689         * gdbarch.h, gdbarch.c: Regenerate.
5690         * target.c (target_translate_tls_address): Use
5691         gdbarch_get_thread_local_address if present instead of
5692         target::get_thread_local_address.
5693
5694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5695
5696         * target.h (target::get_thread_local_address): Update comment.
5697
5698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5699
5700         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5701         objfile->separate_debug_objfile_backlink if not NULL.
5702
5703 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5704
5705         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5706         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5707         (amd64bsd_store_inferior_registers): Likewise.
5708         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5709         Enable segment base registers.
5710         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5711         PT_GETFSBASE and PT_GETGSBASE.
5712         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5713         PT_SETGSBASE.
5714         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5715         segment base registers.
5716         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5717
5718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5719
5720         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5721         Update calls to i386_target_description to add 'segments'
5722         parameter.
5723         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5724         add segment base registers.
5725         * arch/i386.c (i386_create_target_description): Add 'segments'
5726         parameter to enable segment base registers.
5727         * arch/i386.h (i386_create_target_description): Likewise.
5728         * features/i386/32bit-segments.xml: New file.
5729         * features/i386/32bit-segments.c: Generate.
5730         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5731         call to i386_target_description to add 'segments' parameter.
5732         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5733         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5734         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5735         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5736         if feature is present.
5737         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5738         Add 'segments' parameter to call to i386_target_description.
5739         (i386_target_description): Add 'segments' parameter to enable
5740         segment base registers.
5741         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5742         to call to i386_target_description.
5743         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5744         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5745         Define I386_NUM_REGS.
5746         (i386_target_description): Add 'segments' parameter to enable
5747         segment base registers.
5748
5749 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5750
5751         PR/24325
5752         * source-cache.c: #undef open and close, to avoid unresolved
5753         externals during linking.
5754
5755 2019-03-12  Tom Tromey  <tromey@adacore.com>
5756
5757         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5758         const.  Add initializers.
5759         (_initialize_remote): Don't initialize ptid globals.
5760
5761 2019-03-12  Pedro Alves  <palves@redhat.com>
5762
5763         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5764
5765 2019-03-12  Pedro Alves  <palves@redhat.com>
5766
5767         * cp-name-parser.y (main): Remove unused 'len' variable.
5768
5769 2019-03-12  Tom Tromey  <tromey@adacore.com>
5770
5771         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5772         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5773
5774 2019-03-12  Tom Tromey  <tromey@adacore.com>
5775
5776         * linux-nat.c (iterate_over_lwps): Update.
5777         (stop_callback): Remove parameter.
5778         (stop_wait_callback, detach_callback, resume_set_callback)
5779         (select_singlestep_lwp_callback, set_ignore_sigint)
5780         (status_callback, resumed_callback, resume_clear_callback)
5781         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5782         data parameter.
5783         (linux_nat_target::detach, linux_nat_target::resume)
5784         (linux_stop_and_wait_all_lwps, select_event_lwp)
5785         (linux_nat_filter_event, linux_nat_wait_1)
5786         (linux_nat_target::kill, linux_nat_target::stop)
5787         (linux_nat_target::stop): Update.
5788         (linux_nat_resume_callback): Change type.
5789         (resume_stopped_resumed_lwps, count_events_callback)
5790         (select_event_lwp_callback): Likewise.
5791         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5792         * arm-linux-nat.c (struct update_registers_data): Remove.
5793         (update_registers_callback): Change type.
5794         (arm_linux_insert_hw_breakpoint1): Update.
5795         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5796         parameter.
5797         (x86_linux_dr_set_addr): Update.
5798         (x86_linux_dr_set_control): Update.
5799         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5800         (iterate_over_lwps): Use gdb::function_view.
5801         * nat/aarch64-linux-hw-point.c (struct
5802         aarch64_dr_update_callback_param): Remove.
5803         (debug_reg_change_callback): Change type.
5804         (aarch64_notify_debug_reg_change): Update.
5805         * s390-linux-nat.c (s390_refresh_per_info): Update.
5806
5807 2019-03-11  Tom Tromey  <tromey@adacore.com>
5808
5809         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5810         redundant assignment to "this_cu".
5811
5812 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5813
5814         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5815
5816 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5817
5818         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5819         from...
5820         (rank_one_type): ... this.
5821
5822 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5823
5824         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5825         from...
5826         (rank_one_type): ... this.
5827
5828 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5829
5830         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5831         from...
5832         (rank_one_type): ... this.
5833
5834 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5835
5836         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5837         from...
5838         (rank_one_type): ... this.
5839
5840 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5841
5842         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5843         from...
5844         (rank_one_type): ... this.
5845
5846 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5847
5848         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5849         from...
5850         (rank_one_type): ... this.
5851
5852 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5853
5854         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5855         from...
5856         (rank_one_type): ... this.
5857
5858 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5859
5860         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5861         from...
5862         (rank_one_type): ... this.
5863
5864 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5865
5866         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5867         from...
5868         (rank_one_type): ... this.
5869
5870 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5871
5872         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5873         from...
5874         (rank_one_type): ... this.
5875
5876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5877
5878         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5879         from...
5880         (rank_one_type): ... this.
5881
5882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5883
5884         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5885         from...
5886         (rank_one_type): ... this.
5887
5888 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5889
5890         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5891         inferior-events' shows the example events.
5892
5893 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5894
5895         Support styling on native MS-Windows console
5896
5897         PR/24315
5898         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5899         on MS-Windows if $TERM is not defined.
5900
5901         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5902
5903         * posix-hdep.c (gdb_console_fputs):
5904         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5905         functions.
5906         * ui-file.h (gdb_console_fputs): Add prototype.
5907
5908         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5909         back to fputs only if the former returns zero.
5910
5911 2019-03-07  Tom Tromey  <tom@tromey.com>
5912
5913         * symmisc.c (print_symbol_bcache_statistics): Update.
5914         (print_objfile_statistics): Update.
5915         * symfile.c (allocate_symtab): Update.
5916         * stabsread.c: Don't include bcache.h.
5917         * psymtab.h (struct psymbol_bcache): Don't declare.
5918         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5919         (psymbol_bcache_init, psymbol_bcache_free)
5920         (psymbol_bcache_get_bcache): Don't declare.
5921         * psymtab.c (struct psymbol_bcache): Remove.
5922         (psymtab_storage::psymtab_storage): Update.
5923         (psymtab_storage::~psymtab_storage): Update.
5924         (psymbol_bcache_init, psymbol_bcache_free)
5925         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5926         (add_psymbol_to_bcache): Update.
5927         (allocate_psymtab): Update.
5928         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5929         macro_cache>: No longer pointers.
5930         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5931         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5932         * macrotab.c (macro_bcache): Update.
5933         * macroexp.c: Don't include bcache.h.
5934         * gdbtypes.c (check_types_worklist): Update.
5935         (types_deeply_equal): Remove TRY/CATCH.  Update.
5936         * elfread.c (elf_symtab_read): Update.
5937         * dwarf2read.c: Don't include bcache.h.
5938         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5939         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5940         (print_bcache_statistics, bcache_memory_used): Don't declare.
5941         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5942         methods.  Rename all data members.
5943         * bcache.c (struct bcache): Move to bcache.h.
5944         (bcache::expand_hash_table): Rename from expand_hash_table.
5945         (bcache): Remove.
5946         (bcache::insert): Rename from bcache_full.
5947         (bcache::compare): Rename from bcache_compare.
5948         (bcache_xmalloc): Remove.
5949         (bcache::~bcache): Rename from bcache_xfree.
5950         (bcache::print_statistics): Rename from print_bcache_statistics.
5951         (bcache::memory_used): Rename from bcache_memory_used.
5952
5953 2019-03-07  Pedro Alves  <palves@redhat.com>
5954
5955         * infrun.c (normal_stop): Also check for
5956         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5957
5958 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5959
5960         * f-lang.c (value_from_host_double): Moved to...
5961         * value.c (value_from_host_double): ...here.
5962         * value.h (value_from_host_double): Declare.
5963         * guile/scm-math.c (vlscm_convert_typed_number): Use
5964         value_from_host_double.
5965         (vlscm_convert_number): Likewise.
5966         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5967         * python/py-value.c (convert_value_from_python): Likewise.
5968
5969 2019-03-06  Tom Tromey  <tom@tromey.com>
5970
5971         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5972
5973 2019-03-06  Tom Tromey  <tom@tromey.com>
5974
5975         * utils.h (free_current_contents): Don't declare.
5976         * utils.c (free_current_contents): Remove.
5977
5978 2019-03-06  Tom Tromey  <tom@tromey.com>
5979
5980         * top.c (quit_force): Update.
5981         * main.c (captured_command_loop): Update.
5982         * common/new-op.c (operator new): Update.
5983         * common/common-exceptions.c (struct catcher)
5984         <save_cleanup_chain>: Remove member.
5985         (exceptions_state_mc_init): Update.
5986         (exception_try_scope_entry): Return nullptr.
5987         (exception_try_scope_exit, exception_rethrow)
5988         (throw_exception_sjlj, throw_exception_cxx): Update.
5989         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5990         (all_cleanups, do_cleanups, discard_cleanups)
5991         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5992         (restore_cleanups, restore_final_cleanups): Don't declare.
5993         (do_final_cleanups): Remove parameter.
5994         * common/cleanups.c (cleanup_chain, make_cleanup)
5995         (make_cleanup_dtor, all_cleanups, do_cleanups)
5996         (discard_my_cleanups, discard_cleanups)
5997         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5998         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5999         (null_cleanup): Remove.
6000         (do_final_cleanups): Remove parameter.
6001
6002 2019-03-06  Tom Tromey  <tom@tromey.com>
6003
6004         * remote.c (remote_target::remote_parse_stop_reply): Use
6005         unique_xmalloc_ptr.
6006
6007 2019-03-06  Tom Tromey  <tom@tromey.com>
6008
6009         * stabsread.c (struct stabs_field_info): Rename from field_info.
6010         <list, fnlist>: Add initializers.
6011         <obstack>: New member.
6012         (read_member_functions, read_struct_fields, read_baseclasses):
6013         Allocate on obstack.  Don't use cleanups.
6014         (read_one_struct_field, read_member_functions, read_struct_fields)
6015         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6016         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6017         (read_struct_type): Update.
6018
6019 2019-03-06  Tom Tromey  <tom@tromey.com>
6020
6021         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6022         * common/filestuff.h (make_cleanup_close): Don't declare.
6023         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6024         Remove.
6025
6026 2019-03-06  Tom Tromey  <tom@tromey.com>
6027
6028         * solib-aix.c: Use make_scope_exit.
6029
6030 2019-03-06  Tom Tromey  <tom@tromey.com>
6031
6032         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6033         Use make_scope_exit.
6034
6035 2019-03-06  Tom Tromey  <tom@tromey.com>
6036
6037         * solib-svr4.c (disable_probes_interface): Remove parameter.
6038         (svr4_handle_solib_event): Use make_scope_exit.
6039
6040 2019-03-06  Tom Tromey  <tom@tromey.com>
6041
6042         * remote.c (struct stop_reply_deleter): Remove.
6043         (stop_reply_up): Update.
6044         (struct stop_reply): Derive from notif_event.  Don't typedef.
6045         <regcache>: Now a std::vector.
6046         (stop_reply_xfree): Remove.
6047         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6048         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6049         (remote_target::discard_pending_stop_replies): Use delete.
6050         (remote_target::remote_parse_stop_reply): Update.
6051         (remote_target::process_stop_reply): Update.
6052         * remote-notif.h (struct notif_event): Add virtual destructor.
6053         Remove "dtr" member.
6054         (struct notif_client) <alloc_event>: Return a unique_ptr.
6055         (notif_event_xfree): Don't declare.
6056         (notif_event_up): New typedef.
6057         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6058         (notif_event_xfree, do_notif_event_xfree): Remove.
6059         (remote_notif_state_xfree): Update.
6060
6061 2019-03-06  Tom Tromey  <tom@tromey.com>
6062
6063         * infrun.c (displaced_step_clear_cleanup): Now a
6064         forward_scope_exit type.
6065         (displaced_step_prepare_throw): Update.
6066         (displaced_step_fixup): Update.
6067
6068 2019-03-06  Tom Tromey  <tom@tromey.com>
6069
6070         * inferior.h (class inferior): Update comment.
6071         * gdbthread.h (class thread_info): Update comment.
6072
6073 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6074             Tom Tromey  <tom@tromey.com>
6075
6076         * stabsread.h (struct stab_section_list): Remove.
6077         (coffstab_build_psymtabs): Update.
6078         * dbxread.c (symbuf_sections): Now a std::vector.
6079         (sect_idx): New global.
6080         (fill_symbuf): Update.
6081         (coffstab_build_psymtabs): Change type of stabsects parameter.
6082         Update.
6083         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6084         std::vector.
6085         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6086         (coff_locate_sections): Update.
6087         (coff_symfile_read): Remove cleanups.  Update.
6088         (init_stringtab): Add storage parameter.
6089         (free_stringtab, free_stringtab_cleanup): Remove.
6090         (init_lineno): Add storage parameter.
6091         (free_linetab, free_linetab_cleanup): Remove.
6092
6093 2019-03-06  Pedro Alves  <palves@redhat.com>
6094
6095         * linux-fork.c (fork_info::clobber_regs): Delete.
6096         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6097         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6098         comment.  Adjust.
6099         (scoped_switch_fork_info::scoped_switch_fork_info)
6100         (checkpoint_command, linux_fork_context): Adjust
6101         fork_save_infrun_state calls.
6102
6103 2019-03-06  Pedro Alves  <palves@redhat.com>
6104
6105         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6106         (inf_has_multiple_threads): Return 'bool' and rewrite using
6107         inferior_info::threads().
6108
6109 2019-03-06  Pedro Alves  <palves@redhat.com>
6110
6111         * linux-fork.c: Include <list>.
6112         (fork_list): Now a std::list instance.
6113         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6114         (forks_exist_p, find_last_fork): Adjust.
6115         (new_fork): Delete.
6116         (one_fork_p): New.
6117         (add_fork): Adjust.
6118         (free_fork): Delete, folded into fork_info::~fork_info().
6119         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6120         Adjust.
6121         (init_fork_list): Delete.
6122         (linux_fork_killall, linux_fork_mourn_inferior)
6123         (linux_fork_detach, info_checkpoints_command): Adjust.
6124         (_initialize_linux_fork): No longer call init_fork_list.
6125
6126 2019-03-06  Pedro Alves  <palves@redhat.com>
6127
6128         * linux-fork.c (new_fork): New, split out of ...
6129         (add_fork): ... this.  Return void.  Move "first fork" special
6130         case from here, to ...
6131         (checkpoint_command): ... here.
6132         * linux-linux.h (add_fork): Return void.
6133
6134 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6135
6136         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6137
6138 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6139             Chris January  <chris.january@arm.com>
6140             David Lecomber  <david.lecomber@arm.com>
6141
6142         * f-exp.y: New token, UNOP_INTRINSIC.
6143         (exp): New pattern using UNOP_INTRINSIC token.
6144         (f77_keywords): Add 'abs' keyword.
6145         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6146         (value_from_host_double): New function.
6147         (evaluate_subexp_f): Support UNOP_ABS.
6148
6149 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6150
6151         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6152         types.
6153
6154 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6155
6156         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6157         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6158         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6159
6160 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6161
6162         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6163
6164 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6165             Chris January  <chris.january@arm.com>
6166
6167         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6168         * f-exp.y: Define 'KIND' token.
6169         (exp): New pattern for KIND expressions.
6170         (ptype): Handle types with a kind extension.
6171         (direct_abs_decl): Extend to spot kind extensions.
6172         (f77_keywords): Add 'kind' to the list.
6173         (push_kind_type): New function.
6174         (convert_to_kind_type): New function.
6175         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6176         * parse.c (operator_length_standard): Likewise.
6177         * parser-defs.h (enum type_pieces): Add tp_kind.
6178         * std-operator.def: Add UNOP_KIND.
6179
6180 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6181
6182         * f-exp.y (f_parse): Set yydebug.
6183
6184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6185
6186         * f-lang.c (evaluate_subexp_f): New function.
6187         (exp_descriptor_f): New global.
6188         (f_language_defn): Use exp_descriptor_f instead of
6189         exp_descriptor_standard.
6190
6191 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6192
6193         * f-exp.y (struct token): Add comments.
6194         (dot_ops): Remove uppercase versions and the end marker.
6195         (f77_keywords): Likewise.
6196         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6197         entries in the dot_ops array are case insensitive, and use
6198         strncasecmp to compare strings.  Also some whitespace cleanup in
6199         this area.  Similar for the f77_keywords array, except entries in
6200         this list might be case sensitive.
6201
6202 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6203
6204         * f-exp.y (struct f77_boolean_val): Add comments.
6205         (boolean_values): Remove uppercase versions, and end marker.
6206         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6207         and use strncasecmp to achieve case insensitivity.  Additionally,
6208         perform whitespace cleanup around this code.
6209
6210 2019-03-06  Tom Tromey  <tromey@adacore.com>
6211
6212         * remote-sim.c (gdbsim_target_open): Use result of
6213         gdb_argv::release.
6214
6215 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6216         Dirk Schubert  <dirk.schubert@arm.com>
6217         Chris January  <chris.january@arm.com>
6218
6219         * eval.c (evaluate_subexp_standard): Call Fortran argument
6220         wrapping logic.
6221         * f-lang.c (struct value): A value which can be passed into a
6222         Fortran function call.
6223         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6224         where appropriate.
6225         (struct type): Value ready for a Fortran function call.
6226         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6227         is needed.
6228         * f-lang.h (fortran_argument_convert): Declaration.
6229         (fortran_preserve_arg_pointer): Declaration.
6230         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6231
6232 2019-03-05  Tom Tromey  <tromey@adacore.com>
6233
6234         * python/py-prettyprint.c (print_string_repr): Remove #if.
6235         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6236
6237 2019-03-05  Tom Tromey  <tromey@adacore.com>
6238
6239         * target.c (the_dummy_target): Move later.  Change type to
6240         "dummy_target".
6241         (initialize_targets): Don't initialize the_dummy_target.
6242
6243 2019-03-05  Tom Tromey  <tromey@adacore.com>
6244
6245         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6246         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6247
6248 2019-03-05  Tom Tromey  <tromey@adacore.com>
6249
6250         * windows-nat.c (windows_nat_target::attach)
6251         (windows_nat_target::detach): Don't call gdb_flush.
6252         * valprint.c (generic_val_print, val_print, val_print_string):
6253         Don't call gdb_flush.
6254         * utils.c (defaulted_query): Don't call gdb_flush.
6255         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6256         * target.c (target_announce_detach): Don't call gdb_flush.
6257         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6258         * remote.c (extended_remote_target::attach): Don't call
6259         gdb_flush.
6260         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6261         * printcmd.c (do_examine): Don't call gdb_flush.
6262         (info_display_command): Don't call gdb_flush.
6263         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6264         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6265         * memattr.c (info_mem_command): Don't call gdb_flush.
6266         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6267         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6268         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6269         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6270         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6271         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6272         (gnu_nat_target::detach): Don't call gdb_flush.
6273         * f-valprint.c (f_val_print): Don't call gdb_flush.
6274         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6275         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6276         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6277         gdb_flush.
6278         * c-valprint.c (c_val_print): Don't call gdb_flush.
6279         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6280
6281 2019-03-05  Tom Tromey  <tromey@adacore.com>
6282
6283         * varobj.c (update_dynamic_varobj_children): Update.
6284         (install_default_visualizer): Use reset, not release.
6285         * value.c (set_internalvar): Update.
6286         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6287         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6288         ATTRIBUTE_UNUSED_RESULT.
6289
6290 2019-03-05  Tom Tromey  <tromey@adacore.com>
6291
6292         * remote.c (class scoped_remote_fd) <release>: Add
6293         ATTRIBUTE_UNUSED_RESULT.
6294
6295 2019-03-05  Tom Tromey  <tromey@adacore.com>
6296
6297         * macroexp.c (struct macro_buffer) <release>: Add
6298         ATTRIBUTE_UNUSED_RESULT.
6299
6300 2019-03-05  Tom Tromey  <tromey@adacore.com>
6301
6302         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6303         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6304         ATTRIBUTE_UNUSED_RESULT.
6305
6306 2019-03-05  Tom Tromey  <tromey@adacore.com>
6307
6308         * common/scoped_fd.h (class scoped_fd) <release>: Add
6309         ATTRIBUTE_UNUSED_RESULT.
6310
6311 2019-03-05  Tom Tromey  <tromey@adacore.com>
6312
6313         * parser-defs.h (struct parser_state) <release>: Add
6314         ATTRIBUTE_UNUSED_RESULT.
6315
6316 2019-03-05  Tom Tromey  <tromey@adacore.com>
6317
6318         * utils.h (class gdb_argv) <release>: Add
6319         ATTRIBUTE_UNUSED_RESULT.
6320         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6321
6322 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6323
6324         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6325         for-loop range, to avoid compiler warnings.
6326
6327         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6328         avoid compiler warnings about unused variables.
6329
6330         * NEWS: Mention end of support for native debugging on MS-Windows
6331         before XP.
6332
6333         PR gdb/24292
6334         * common/netstuff.c:
6335         * gdbserver/gdbreplay.c
6336         * gdbserver/remote-utils.c:
6337         * ser-tcp.c:
6338         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6339         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6340         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6341         'getaddrinfo' and 'freeaddrinfo' were not available before
6342         Windows XP, and mingw.org's MinGW headers by default define
6343         _WIN32_WINNT to 0x500.
6344
6345 2019-03-01  Gary Benson <gbenson@redhat.com>
6346
6347         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6348
6349 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6350             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6351
6352         PR gdb/8527
6353         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6354         set_sigint_trap, clear_sigint_trap.
6355
6356 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6357
6358         * target.c (target_detach): Clear the regcache and the
6359         frame cache.
6360
6361 2019-02-27  Pedro Alves  <palves@redhat.com>
6362
6363         * utils.c (set_screen_size): When we cap the height/width sizes,
6364         tweak the corresponding command variable to show "unlimited":
6365
6366 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6367             Pedro Alves  <palves@redhat.com>
6368
6369         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6370         before calling rl_set_screen_size.
6371
6372 2019-02-27  Tom Tromey  <tromey@adacore.com>
6373
6374         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6375         define.
6376         * python/py-value.c: Remove Python 2.4 workaround.
6377         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6378         workaround.
6379         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6380         Python 2.4 workaround.
6381         * python/python-internal.h: Remove Python 2.4 comment.
6382         (Py_ssize_t): Don't define.
6383         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6384         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6385         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6386         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6387         * python/python.c (do_start_initialization): Remove Python 2.4
6388         workaround.
6389         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6390         (print_children): Remove Python 2.4 workaround.
6391         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6392         workaround.
6393         (CHARBUFFERPROC_NAME): Remove.
6394         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6395         Python 2.4 workaround.
6396
6397 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6398
6399         * NEWS: Note minimum Python version.
6400
6401 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6402
6403         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6404         code from these functions.  Remove corresponding ifdefs.  Use
6405         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6406         Remove gotos and target of gotos.
6407         (infpy_search_memory): Likewise.
6408
6409 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6410
6411         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6412         (hppa_gdbarch_init): Don't register deleted functions with
6413         gdbarch.
6414
6415 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6416
6417         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6418         (h8300_unwind_sp): Delete.
6419         (h8300_dummy_id): Delete.
6420         (h8300_gdbarch_init): Don't register deleted functions with
6421         gdbarch.
6422
6423 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6424
6425         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6426         (ft32_unwind_pc): Delete.
6427         (ft32_unwind_sp): Delete.
6428         (ft32_gdbarch_init): Don't register deleted functions with
6429         gdbarch.
6430
6431 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6432
6433         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6434         (frv_unwind_pc): Delete.
6435         (frv_unwind_sp): Delete.
6436         (frv_gdbarch_init): Don't register deleted functions with
6437         gdbarch.
6438
6439 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6440
6441         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6442         (riscv_unwind_pc): Delete.
6443         (riscv_unwind_sp): Delete.
6444         (riscv_gdbarch_init): Don't register deleted functions with
6445         gdbarch.
6446
6447 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6448
6449         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6450         (csky_unwind_pc): Delete.
6451         (csky_unwind_sp): Delete.
6452         (csky_gdbarch_init): Don't register deleted functions with
6453         gdbarch.
6454
6455 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6456
6457         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6458         (cris_unwind_pc): Delete.
6459         (cris_unwind_sp): Delete.
6460         (cris_gdbarch_init): Don't register deleted functions with
6461         gdbarch.
6462
6463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6464
6465         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6466         (bfin_unwind_pc): Delete.
6467         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6468
6469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6470
6471         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6472         (arm_unwind_pc): Delete.
6473         (arm_unwind_sp): Delete.
6474         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6475
6476 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6477
6478         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6479         (arc_unwind_pc): Delete.
6480         (arc_unwind_sp): Delete.
6481         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6482
6483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6484
6485         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6486         (alpha_unwind_pc): Delete.
6487         (alpha_gdbarch_init): Don't register deleted functions with
6488         gdbarch.
6489
6490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6491
6492         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6493         (aarch64_unwind_pc): Delete.
6494         (aarch64_unwind_sp): Delete.
6495         (aarch64_gdbarch_init): Don't register deleted functions with
6496         gdbarch.
6497
6498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6499
6500         * gdbtypes.c (type_align): Don't consider static members when
6501         computing structure alignment.
6502
6503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6504
6505         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6506         return 0 for other types.
6507         * arch-utils.c (default_type_align): Always return 0.
6508         * gdbarch.h: Regenerate.
6509         * gdbarch.sh (type_align): Extend comment.
6510         * gdbtypes.c (type_align): Add additional comments, always call
6511         gdbarch_type_align before applying the default rules.
6512         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6513         generic code will then apply a suitable default.
6514         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6515         types, return 0 for other types.
6516
6517 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6518
6519         * NEWS: Create a new section for the next release branch.
6520         Rename the section of the current branch, now that it has
6521         been cut.
6522
6523 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6524
6525         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6526         * version.in: Bump version to 8.3.50.DATE-git.
6527
6528 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6529
6530         * aix-thread.c (ptid_cmp): Remove unused variable.
6531         (get_signaled_thread): Likewise.
6532         (store_regs_user_thread): Likewise.
6533         (store_regs_kernel_thread): Likewise.
6534         (fetch_regs_kernel_thread): Remove shadowed variable.
6535
6536 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6537
6538         * features/riscv/32bit-cpu.xml: Add register numbers.
6539         * features/riscv/32bit-fpu.c: Regenerate.
6540         * features/riscv/32bit-fpu.xml: Add register numbers.
6541         * features/riscv/64bit-cpu.xml: Add register numbers.
6542         * features/riscv/64bit-fpu.c: Regenerate.
6543         * features/riscv/64bit-fpu.xml: Add register numbers.
6544
6545 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6546
6547         * NEWS: Mention two argument form of gdb.Value constructor.
6548         * python/py-value.c (convert_buffer_and_type_to_value): New
6549         function.
6550         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6551         Add support for handling an optional second argument.  Call
6552         convert_buffer_and_type_to_value as appropriate.
6553         * python/python-internal.h (Py_buffer_deleter): New struct.
6554         (Py_buffer_up): New typedef.
6555
6556 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6557
6558         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6559         instead of releasing ownership.
6560
6561 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6562
6563         * dwarf2read.c (open_and_init_dwp_file): Call
6564         elf_numsections instead of bfd_count_sections to initialize
6565         dwp_file->num_sections.
6566
6567 2019-02-25  Tom Tromey  <tromey@adacore.com>
6568
6569         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6570
6571 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6572
6573         * gcore.in: Add '--readnever' option when invoking GDB.
6574
6575 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6576
6577         * MAINTAINERS: Update my email address.
6578
6579 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6580
6581         * build-id.c (build_id_to_debug_bfd_1): New function.
6582         (build_id_to_debug_bfd): Look for separate debug file in
6583         sysroot.
6584
6585 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6586
6587         * gdbarch.sh: Update the copyright year range that is placed into
6588         generated files.
6589
6590 2019-02-22  Keith Seitz  <keiths@redhat.com>
6591
6592         PR symtab/23853
6593         * linespec.c (create_sals_line_offset): Search for the default
6594         symtab's filename instead of its fullname.
6595
6596 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6597
6598         * NEWS: Update style defaults.
6599
6600 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6601
6602         * main.c (captured_main_1): Disable styling in batch mode.
6603
6604 2019-02-20  Tom Tromey  <tom@tromey.com>
6605
6606         * symtab.c (symtab_symbol_info): Fix typos.
6607
6608 2019-02-20  Tom Tromey  <tromey@adacore.com>
6609
6610         * findcmd.c (_initialize_mem_search): Use upper case for
6611         metasyntactic variables.
6612
6613 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6614
6615         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6616         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6617
6618 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6619
6620         * top.h (source_file_name): Change to std::string.
6621         * top.c (source_file_name): Likewise.
6622         (command_line_input): Adjust.
6623         * cli/cli-script.c (script_from_file): Adjust.
6624
6625 2019-02-19  Tom Tromey  <tromey@adacore.com>
6626
6627         * ravenscar-thread.c
6628         (ravenscar_thread_target::update_thread_list): Don't call
6629         ada_build_task_list.
6630         * ada-lang.h (ada_build_task_list): Don't declare.
6631         * ada-tasks.c (struct ada_tasks_inferior_data)
6632         <task_list_valid_p>: Now bool.
6633         (read_known_tasks, ada_task_list_changed)
6634         (ada_tasks_invalidate_inferior_data): Update.
6635         (read_known_tasks_array): Return bool.
6636         (read_known_tasks_list): Likewise.
6637         (read_known_tasks): Return void.
6638         (ada_build_task_list): Now static.
6639
6640 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6641
6642         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6643         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6644
6645 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6646
6647         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6648         variant for ada_tasks_pspace_data_handle and
6649         ada_tasks_inferior_data_handle.
6650         (ada_tasks_pspace_data_cleanup): New function.
6651         (ada_tasks_inferior_data_cleanup): New function.
6652
6653 2019-02-17  Tom Tromey  <tom@tromey.com>
6654
6655         * macrotab.h (macro_source_fullname): Return a std::string.
6656         * macrotab.c (macro_include, check_for_redefinition)
6657         (macro_undef, macro_lookup_definition, foreach_macro)
6658         (foreach_macro_in_scope): Update.
6659         (macro_source_fullname): Return a std::string.
6660         * macrocmd.c (show_pp_source_pos): Update.
6661
6662 2019-02-17  Tom Tromey  <tom@tromey.com>
6663
6664         * macrocmd.c (show_pp_source_pos): Style the file names.
6665
6666 2019-02-17  Tom Tromey  <tom@tromey.com>
6667
6668         PR tui/24197:
6669         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6670
6671 2019-02-17  Tom Tromey  <tom@tromey.com>
6672
6673         * ada-lang.c (user_select_syms): Use filtered printing.
6674         * utils.c (wrap_style): New global.
6675         (desired_style): Remove.
6676         (emit_style_escape): Add stream parameter.
6677         (set_output_style, reset_terminal_style, prompt_for_continue):
6678         Update.
6679         (flush_wrap_buffer): Only flush gdb_stdout.
6680         (wrap_here): Set wrap_style.
6681         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6682         treat escape sequences as a character.  Change when wrap buffer is
6683         flushed.
6684         (fputs_styled): Do not set the output style when the default is
6685         requested.
6686         * ui-style.h (struct ui_file_style) <is_default>: New method.
6687         * source.c (print_source_lines_base): Emit escape sequences in one
6688         piece.
6689
6690 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6691
6692         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6693         integers and enumeration types.
6694
6695 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6696
6697         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6698         instead of lookup_symbol_in_language
6699         (do_exact_match): New function.
6700         (ada_get_symbol_name_matcher): Return do_exact_match when
6701         doing a verbatim match.
6702
6703 2019-02-15  Tom Tromey  <tromey@adacore.com>
6704
6705         * ravenscar-thread.c (ravenscar_thread_target::resume)
6706         (ravenscar_thread_target::wait): Special case wildcard requests.
6707
6708 2019-02-15  Tom Tromey  <tromey@adacore.com>
6709
6710         * ravenscar-thread.c (base_ptid): Remove.
6711         (struct ravenscar_thread_target) <close>: New method.
6712         <m_base_ptid>: New member.
6713         <update_inferior_ptid, active_task, task_is_currently_active,
6714         runtime_initialized>: Declare methods.
6715         <ravenscar_thread_target>: Add constructor.
6716         (ravenscar_thread_target::task_is_currently_active)
6717         (ravenscar_thread_target::update_inferior_ptid)
6718         (ravenscar_runtime_initialized): Rename.  Now methods.
6719         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6720         (ravenscar_thread_target::update_thread_list): Update.
6721         (ravenscar_thread_target::active_task): Now method.
6722         (ravenscar_thread_target::store_registers)
6723         (ravenscar_thread_target::prepare_to_store)
6724         (ravenscar_thread_target::prepare_to_store)
6725         (ravenscar_thread_target::mourn_inferior): Update.
6726         (ravenscar_inferior_created): Use "new" to create target.
6727         (ravenscar_thread_target::get_ada_task_ptid): Update.
6728         (_initialize_ravenscar): Don't initialize base_ptid.
6729         (ravenscar_ops): Remove global.
6730
6731 2019-02-15  Tom Tromey  <tromey@adacore.com>
6732
6733         * target.h (push_target): Declare new overload.
6734         * target.c (push_target): New overload, taking an rvalue reference.
6735         * remote.c (remote_target::open_1): Use push_target overload.
6736         * corelow.c (core_target_open): Use push_target overload.
6737
6738 2019-02-15  Tom Tromey  <tromey@adacore.com>
6739
6740         * ravenscar-thread.c (is_ravenscar_task)
6741         (ravenscar_task_is_currently_active): Return bool.
6742         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6743         (_initialize_ravenscar): Remove "(void)".
6744         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6745         Return bool.
6746
6747 2019-02-15  Tom Tromey  <tromey@adacore.com>
6748
6749         * ravenscar-thread.c (ravenscar_runtime_initializer)
6750         (has_ravenscar_runtime, get_running_thread_id)
6751         (ravenscar_thread_target::resume): Fix indentation.
6752
6753 2019-02-15  Tom Tromey  <tromey@adacore.com>
6754
6755         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6756         from ravenscar_arch_ops.
6757         (sparc_ravenscar_ops::fetch_registers)
6758         (sparc_ravenscar_ops::store_registers): Now methods.
6759         (sparc_ravenscar_prepare_to_store): Remove.
6760         (sparc_ravenscar_ops): Redefine.
6761         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6762         methods and destructor.  Remove members.
6763         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6764         (ravenscar_thread_target::store_registers)
6765         (ravenscar_thread_target::prepare_to_store): Update.
6766         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6767         Remove.
6768         (struct ppc_ravenscar_powerpc_ops): Derive from
6769         ravenscar_arch_ops.
6770         (ppc_ravenscar_powerpc_ops::fetch_registers)
6771         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6772         (ppc_ravenscar_powerpc_ops): Redefine.
6773         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6774         (ppc_ravenscar_e500_ops::fetch_registers)
6775         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6776         (ppc_ravenscar_e500_ops): Redefine.
6777         * aarch64-ravenscar-thread.c
6778         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6779         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6780         (aarch64_ravenscar_fetch_registers)
6781         (aarch64_ravenscar_store_registers): Now methods.
6782         (aarch64_ravenscar_ops): Redefine.
6783
6784 2019-02-15  Tom Tromey  <tromey@adacore.com>
6785
6786         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6787         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6788         (ravenscar_thread_target::stopped_by_watchpoint)
6789         (ravenscar_thread_target::stopped_data_address)
6790         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6791
6792 2019-02-15  Tom Tromey  <tromey@adacore.com>
6793
6794         * ravenscar-thread.c: Fix some typos.
6795
6796 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6797             Tom Tromey  <tromey@adacore.com>
6798
6799         * ada-lang.c (ada_exception_sal): Change addr_string to a
6800         std::string.
6801         (create_ada_exception_catchpoint): Update.
6802
6803 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6804             Tom Tromey  <tromey@adacore.com>
6805
6806         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6807         (bp_location_ops): Remove.
6808         (base_breakpoint_allocate_location): Update.
6809         (free_bp_location): Update.
6810         * ada-lang.c (class ada_catchpoint_location)
6811         <ada_catchpoint_location>: Remove ops parameter.
6812         (ada_catchpoint_location_dtor): Remove.
6813         (ada_catchpoint_location_ops): Remove.
6814         (allocate_location_exception): Update.
6815         * breakpoint.h (struct bp_location_ops): Remove.
6816         (class bp_location) <bp_location>: Remove bp_location_ops
6817         parameter.
6818         <~bp_location>: Add destructor.
6819         <ops>: Remove.
6820
6821 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6822             Pedro Alves  <palves@redhat.com>
6823
6824         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6825         'PATH_MAX'.
6826
6827 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6828             Samuel Thibault  <samuel.thibault@gnu.org>
6829             Thomas Schwinge  <thomas@codesourcery.com>
6830
6831         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6832         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6833
6834 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6835
6836         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6837         (check_empty): Use "const char *".
6838
6839         * gnu-nat.c (gnu_nat_target::detach): Instead of
6840         'detach_inferior (pid)' call
6841         'detach_inferior (find_inferior_pid (pid))'.
6842
6843         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6844         'nat/fork-inferior.o'.
6845         * gnu-nat.c: #include "nat/fork-inferior.h".
6846
6847         * gnu-nat.c (gnu_nat_target::detach): Instead of
6848         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6849         * gnu-nat.h: #include "inf-child.h".
6850         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6851         'i386_gnu_nat_target::fetch_registers'.
6852         (gnu_store_registers): Rename/move to
6853         'i386_gnu_nat_target::store_registers'.
6854
6855         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6856         * gnu-nat.h (mach_thread_info): New function.
6857         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6858
6859         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6860
6861 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6862
6863         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6864
6865 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6866
6867         * windows-nat.c (windows_add_thread): Add new parameter
6868         "main_thread_p" with default value set to false.  Update
6869         function documentation as well as all callers.
6870         (windows_delete_thread): Likewise.
6871         (fake_create_process): Update call to windows_add_thread.
6872         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6873         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6874         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6875         call to windows_delete_thread.
6876
6877 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6878
6879         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6880
6881 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6882
6883         * symfile.c (find_separate_debug_file): Use canonical path of
6884         sysroot with child_path instead of gdb_sysroot if it is valid.
6885
6886 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6887
6888         * symfile.c (find_separate_debug_file): Use child_path to
6889         determine if an object file is under a sysroot.
6890
6891 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6892
6893         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6894         unittests/child-path-selftests.c.
6895         * common/pathstuff.c (child_path): New function.
6896         * common/pathstuff.h (child_path): New prototype.
6897         * unittests/child-path-selftests.c: New file.
6898
6899 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6900
6901         * symfile.c (find_separate_debug_file): Look for separate debug
6902         files in debug directories under the sysroot.
6903
6904 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6905
6906         * symtab.h (struct minimal_symbol data_p): New const method.
6907         (struct minimal_symbol text_p): Likewise.
6908         * symtab.c (output_source_filename): Use file name style
6909         to print file name.
6910         (print_symbol_info): Likewise.
6911         (print_msymbol_info): Use address style to print addresses.
6912         Use function name style to print executable text symbols.
6913         (expand_symtab_containing_pc): Use data_p.
6914         (find_pc_sect_compunit_symtab): Likewise.
6915
6916 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6917
6918         * breakpoint.c (describe_other_breakpoints): Use address style
6919         to print addresses.
6920         (say_where): Likewise.
6921
6922 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6923
6924         * ada-typeprint.c (print_func_type): Print function name
6925         style to print function name.
6926         * c-typeprint.c (c_print_type_1): Likewise.
6927
6928 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6929
6930         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6931         for execve.
6932
6933 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6934
6935         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6936         type_stack.
6937
6938 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6939
6940         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6941         TYPE_CODE_REF types.
6942
6943 2019-02-08  Jim Wilson  <jimw@sifive.com>
6944
6945         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6946         (riscv_linux_fregset): New.
6947         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6948
6949 2019-02-07  Tom Tromey  <tom@tromey.com>
6950
6951         * thread.c (thread_cancel_execution_command): Update.
6952         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6953         methods.
6954         (struct thread_fsm_ops): Remove.
6955         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6956         (thread_fsm_should_stop, thread_fsm_return_value)
6957         (thread_fsm_set_finished, thread_fsm_finished_p)
6958         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6959         Don't declare.
6960         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6961         * infrun.c (clear_proceed_status_thread)
6962         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6963         (print_stop_event): Update.
6964         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6965         Add constructor.
6966         (step_command_fsm_ops): Remove.
6967         (new_step_command_fsm): Remove.
6968         (step_1): Update.
6969         (step_command_fsm::should_stop): Rename from
6970         step_command_fsm_should_stop.
6971         (step_command_fsm::clean_up): Rename from
6972         step_command_fsm_clean_up.
6973         (step_command_fsm::do_async_reply_reason): Rename from
6974         step_command_fsm_async_reply_reason.
6975         (struct until_next_fsm): Inherit from thread_fsm.  Add
6976         constructor.
6977         (until_next_fsm_ops): Remove.
6978         (new_until_next_fsm): Remove.
6979         (until_next_fsm::should_stop): Rename from
6980         until_next_fsm_should_stop.
6981         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6982         (until_next_fsm::do_async_reply_reason): Rename from
6983         until_next_fsm_async_reply_reason.
6984         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6985         constructor.  Change type of breakpoint.
6986         (finish_command_fsm_ops): Remove.
6987         (new_finish_command_fsm): Remove.
6988         (finish_command_fsm::should_stop): Rename from
6989         finish_command_fsm_should_stop.
6990         (finish_command_fsm::clean_up): Rename from
6991         finish_command_fsm_clean_up.
6992         (finish_command_fsm::return_value): Rename from
6993         finish_command_fsm_return_value.
6994         (finish_command_fsm::do_async_reply_reason): Rename from
6995         finish_command_fsm_async_reply_reason.
6996         (finish_command): Update.
6997         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6998         Add constructor.
6999         (call_thread_fsm_ops): Remove.
7000         (call_thread_fsm::call_thread_fsm): Rename from
7001         new_call_thread_fsm.
7002         (call_thread_fsm::should_stop): Rename from
7003         call_thread_fsm_should_stop.
7004         (call_thread_fsm::should_notify_stop): Rename from
7005         call_thread_fsm_should_notify_stop.
7006         (run_inferior_call, call_function_by_hand_dummy): Update.
7007         * cli/cli-interp.c (should_print_stop_to_console): Update.
7008         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7009         Add constructor.  Change type of location_breakpoint,
7010         caller_breakpoint.
7011         (until_break_fsm_ops): Remove.
7012         (new_until_break_fsm): Remove.
7013         (until_break_fsm::should_stop): Rename from
7014         until_break_fsm_should_stop.
7015         (until_break_fsm::clean_up): Rename from
7016         until_break_fsm_clean_up.
7017         (until_break_fsm::do_async_reply_reason): Rename from
7018         until_break_fsm_async_reply_reason.
7019         (until_break_command): Update.
7020         * thread-fsm.c: Remove.
7021         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7022
7023 2019-02-07  Tom Tromey  <tom@tromey.com>
7024
7025         * yy-remap.h: Add include guard.
7026         * xtensa-tdep.h: Add include guard.
7027         * xcoffread.h: Rename include guard.
7028         * varobj-iter.h: Add include guard.
7029         * tui/tui.h: Rename include guard.
7030         * tui/tui-winsource.h: Rename include guard.
7031         * tui/tui-wingeneral.h: Rename include guard.
7032         * tui/tui-windata.h: Rename include guard.
7033         * tui/tui-win.h: Rename include guard.
7034         * tui/tui-stack.h: Rename include guard.
7035         * tui/tui-source.h: Rename include guard.
7036         * tui/tui-regs.h: Rename include guard.
7037         * tui/tui-out.h: Rename include guard.
7038         * tui/tui-layout.h: Rename include guard.
7039         * tui/tui-io.h: Rename include guard.
7040         * tui/tui-hooks.h: Rename include guard.
7041         * tui/tui-file.h: Rename include guard.
7042         * tui/tui-disasm.h: Rename include guard.
7043         * tui/tui-data.h: Rename include guard.
7044         * tui/tui-command.h: Rename include guard.
7045         * tic6x-tdep.h: Add include guard.
7046         * target/waitstatus.h: Rename include guard.
7047         * target/wait.h: Rename include guard.
7048         * target/target.h: Rename include guard.
7049         * target/resume.h: Rename include guard.
7050         * target-float.h: Rename include guard.
7051         * stabsread.h: Add include guard.
7052         * rs6000-tdep.h: Add include guard.
7053         * riscv-fbsd-tdep.h: Add include guard.
7054         * regformats/regdef.h: Rename include guard.
7055         * record.h: Rename include guard.
7056         * python/python.h: Rename include guard.
7057         * python/python-internal.h: Rename include guard.
7058         * python/py-stopevent.h: Rename include guard.
7059         * python/py-ref.h: Rename include guard.
7060         * python/py-record.h: Rename include guard.
7061         * python/py-record-full.h: Rename include guard.
7062         * python/py-record-btrace.h: Rename include guard.
7063         * python/py-instruction.h: Rename include guard.
7064         * python/py-events.h: Rename include guard.
7065         * python/py-event.h: Rename include guard.
7066         * procfs.h: Add include guard.
7067         * proc-utils.h: Add include guard.
7068         * p-lang.h: Add include guard.
7069         * or1k-tdep.h: Rename include guard.
7070         * observable.h: Rename include guard.
7071         * nto-tdep.h: Rename include guard.
7072         * nat/x86-linux.h: Rename include guard.
7073         * nat/x86-linux-dregs.h: Rename include guard.
7074         * nat/x86-gcc-cpuid.h: Add include guard.
7075         * nat/x86-dregs.h: Rename include guard.
7076         * nat/x86-cpuid.h: Rename include guard.
7077         * nat/ppc-linux.h: Rename include guard.
7078         * nat/mips-linux-watch.h: Rename include guard.
7079         * nat/linux-waitpid.h: Rename include guard.
7080         * nat/linux-ptrace.h: Rename include guard.
7081         * nat/linux-procfs.h: Rename include guard.
7082         * nat/linux-osdata.h: Rename include guard.
7083         * nat/linux-nat.h: Rename include guard.
7084         * nat/linux-namespaces.h: Rename include guard.
7085         * nat/linux-btrace.h: Rename include guard.
7086         * nat/glibc_thread_db.h: Rename include guard.
7087         * nat/gdb_thread_db.h: Rename include guard.
7088         * nat/gdb_ptrace.h: Rename include guard.
7089         * nat/fork-inferior.h: Rename include guard.
7090         * nat/amd64-linux-siginfo.h: Rename include guard.
7091         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7092         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7093         * nat/aarch64-linux.h: Rename include guard.
7094         * nat/aarch64-linux-hw-point.h: Rename include guard.
7095         * mn10300-tdep.h: Add include guard.
7096         * mips-linux-tdep.h: Add include guard.
7097         * mi/mi-parse.h: Rename include guard.
7098         * mi/mi-out.h: Rename include guard.
7099         * mi/mi-main.h: Rename include guard.
7100         * mi/mi-interp.h: Rename include guard.
7101         * mi/mi-getopt.h: Rename include guard.
7102         * mi/mi-console.h: Rename include guard.
7103         * mi/mi-common.h: Rename include guard.
7104         * mi/mi-cmds.h: Rename include guard.
7105         * mi/mi-cmd-break.h: Rename include guard.
7106         * m2-lang.h: Add include guard.
7107         * location.h: Rename include guard.
7108         * linux-record.h: Rename include guard.
7109         * linux-nat.h: Add include guard.
7110         * linux-fork.h: Add include guard.
7111         * i386-darwin-tdep.h: Rename include guard.
7112         * hppa-linux-offsets.h: Add include guard.
7113         * guile/guile.h: Rename include guard.
7114         * guile/guile-internal.h: Rename include guard.
7115         * gnu-nat.h: Rename include guard.
7116         * gdb-stabs.h: Rename include guard.
7117         * frv-tdep.h: Add include guard.
7118         * f-lang.h: Add include guard.
7119         * event-loop.h: Add include guard.
7120         * darwin-nat.h: Rename include guard.
7121         * cp-abi.h: Rename include guard.
7122         * config/sparc/nm-sol2.h: Rename include guard.
7123         * config/nm-nto.h: Rename include guard.
7124         * config/nm-linux.h: Add include guard.
7125         * config/i386/nm-i386gnu.h: Rename include guard.
7126         * config/djgpp/nl_types.h: Rename include guard.
7127         * config/djgpp/langinfo.h: Rename include guard.
7128         * compile/gcc-cp-plugin.h: Add include guard.
7129         * compile/gcc-c-plugin.h: Add include guard.
7130         * compile/compile.h: Rename include guard.
7131         * compile/compile-object-run.h: Rename include guard.
7132         * compile/compile-object-load.h: Rename include guard.
7133         * compile/compile-internal.h: Rename include guard.
7134         * compile/compile-cplus.h: Rename include guard.
7135         * compile/compile-c.h: Rename include guard.
7136         * common/xml-utils.h: Rename include guard.
7137         * common/x86-xstate.h: Rename include guard.
7138         * common/version.h: Rename include guard.
7139         * common/vec.h: Rename include guard.
7140         * common/tdesc.h: Rename include guard.
7141         * common/selftest.h: Rename include guard.
7142         * common/scoped_restore.h: Rename include guard.
7143         * common/scoped_mmap.h: Rename include guard.
7144         * common/scoped_fd.h: Rename include guard.
7145         * common/safe-iterator.h: Rename include guard.
7146         * common/run-time-clock.h: Rename include guard.
7147         * common/refcounted-object.h: Rename include guard.
7148         * common/queue.h: Rename include guard.
7149         * common/ptid.h: Rename include guard.
7150         * common/print-utils.h: Rename include guard.
7151         * common/preprocessor.h: Rename include guard.
7152         * common/pathstuff.h: Rename include guard.
7153         * common/observable.h: Rename include guard.
7154         * common/netstuff.h: Rename include guard.
7155         * common/job-control.h: Rename include guard.
7156         * common/host-defs.h: Rename include guard.
7157         * common/gdb_wait.h: Rename include guard.
7158         * common/gdb_vecs.h: Rename include guard.
7159         * common/gdb_unlinker.h: Rename include guard.
7160         * common/gdb_unique_ptr.h: Rename include guard.
7161         * common/gdb_tilde_expand.h: Rename include guard.
7162         * common/gdb_sys_time.h: Rename include guard.
7163         * common/gdb_string_view.h: Rename include guard.
7164         * common/gdb_splay_tree.h: Rename include guard.
7165         * common/gdb_setjmp.h: Rename include guard.
7166         * common/gdb_ref_ptr.h: Rename include guard.
7167         * common/gdb_optional.h: Rename include guard.
7168         * common/gdb_locale.h: Rename include guard.
7169         * common/gdb_assert.h: Rename include guard.
7170         * common/filtered-iterator.h: Rename include guard.
7171         * common/filestuff.h: Rename include guard.
7172         * common/fileio.h: Rename include guard.
7173         * common/environ.h: Rename include guard.
7174         * common/common-utils.h: Rename include guard.
7175         * common/common-types.h: Rename include guard.
7176         * common/common-regcache.h: Rename include guard.
7177         * common/common-inferior.h: Rename include guard.
7178         * common/common-gdbthread.h: Rename include guard.
7179         * common/common-exceptions.h: Rename include guard.
7180         * common/common-defs.h: Rename include guard.
7181         * common/common-debug.h: Rename include guard.
7182         * common/cleanups.h: Rename include guard.
7183         * common/buffer.h: Rename include guard.
7184         * common/btrace-common.h: Rename include guard.
7185         * common/break-common.h: Rename include guard.
7186         * cli/cli-utils.h: Rename include guard.
7187         * cli/cli-style.h: Rename include guard.
7188         * cli/cli-setshow.h: Rename include guard.
7189         * cli/cli-script.h: Rename include guard.
7190         * cli/cli-interp.h: Rename include guard.
7191         * cli/cli-decode.h: Rename include guard.
7192         * cli/cli-cmds.h: Rename include guard.
7193         * charset-list.h: Add include guard.
7194         * buildsym-legacy.h: Rename include guard.
7195         * bfin-tdep.h: Add include guard.
7196         * ax.h: Rename include guard.
7197         * arm-linux-tdep.h: Add include guard.
7198         * arm-fbsd-tdep.h: Add include guard.
7199         * arch/xtensa.h: Rename include guard.
7200         * arch/tic6x.h: Add include guard.
7201         * arch/i386.h: Add include guard.
7202         * arch/arm.h: Rename include guard.
7203         * arch/arm-linux.h: Rename include guard.
7204         * arch/arm-get-next-pcs.h: Rename include guard.
7205         * arch/amd64.h: Add include guard.
7206         * arch/aarch64-insn.h: Rename include guard.
7207         * arch-utils.h: Rename include guard.
7208         * annotate.h: Add include guard.
7209         * amd64-darwin-tdep.h: Rename include guard.
7210         * aarch64-linux-tdep.h: Add include guard.
7211         * aarch64-fbsd-tdep.h: Add include guard.
7212         * aarch32-linux-nat.h: Add include guard.
7213
7214 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7215
7216         * macrotab.c (macro_define_internal): New function that
7217         factorizes macro_define_object_internal and macro_define_function
7218         code.
7219         (macro_define_object_internal): Use macro_define_internal.
7220         (macro_define_function): Likewise.
7221
7222 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7223
7224         * macrocmd.c (extract_identifier): Return
7225         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7226         callers.
7227
7228 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7229
7230         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7231
7232 2019-02-05  Tom Tromey  <tom@tromey.com>
7233
7234         * target.c (target_stack::unpush): Move assertion earlier.
7235
7236 2019-01-30  Tom Tromey  <tom@tromey.com>
7237
7238         PR python/23615:
7239         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7240         (gdbpy_parse_and_eval): Likewise.
7241         * python/python-internal.h (gdbpy_allow_threads): New class.
7242
7243 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7244
7245         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7246         (aarch64_fbsd_fpregmap): Move earlier.
7247         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7248         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7249         instead of individual calls to trad_frame_set_reg_addr.
7250         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7251         earlier.
7252         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7253         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7254         instead of individual calls to trad_frame_set_reg_addr.
7255
7256 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7257
7258         * CONTRIBUTE: Replace contribution list with wiki link.
7259
7260 2019-01-25  Tom Tromey  <tom@tromey.com>
7261
7262         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7263
7264 2019-01-25  Tom Tromey  <tom@tromey.com>
7265
7266         * xtensa-linux-nat.c: Fix common/ includes.
7267         * xml-support.h: Fix common/ includes.
7268         * xml-support.c: Fix common/ includes.
7269         * x86-linux-nat.c: Fix common/ includes.
7270         * windows-nat.c: Fix common/ includes.
7271         * varobj.h: Fix common/ includes.
7272         * varobj.c: Fix common/ includes.
7273         * value.c: Fix common/ includes.
7274         * valops.c: Fix common/ includes.
7275         * utils.c: Fix common/ includes.
7276         * unittests/xml-utils-selftests.c: Fix common/ includes.
7277         * unittests/utils-selftests.c: Fix common/ includes.
7278         * unittests/unpack-selftests.c: Fix common/ includes.
7279         * unittests/tracepoint-selftests.c: Fix common/ includes.
7280         * unittests/style-selftests.c: Fix common/ includes.
7281         * unittests/string_view-selftests.c: Fix common/ includes.
7282         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7283         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7284         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7285         * unittests/rsp-low-selftests.c: Fix common/ includes.
7286         * unittests/parse-connection-spec-selftests.c: Fix common/
7287         includes.
7288         * unittests/optional-selftests.c: Fix common/ includes.
7289         * unittests/offset-type-selftests.c: Fix common/ includes.
7290         * unittests/observable-selftests.c: Fix common/ includes.
7291         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7292         * unittests/memrange-selftests.c: Fix common/ includes.
7293         * unittests/memory-map-selftests.c: Fix common/ includes.
7294         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7295         * unittests/function-view-selftests.c: Fix common/ includes.
7296         * unittests/environ-selftests.c: Fix common/ includes.
7297         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7298         * unittests/common-utils-selftests.c: Fix common/ includes.
7299         * unittests/cli-utils-selftests.c: Fix common/ includes.
7300         * unittests/array-view-selftests.c: Fix common/ includes.
7301         * ui-file.c: Fix common/ includes.
7302         * tui/tui-io.c: Fix common/ includes.
7303         * tracepoint.h: Fix common/ includes.
7304         * tracepoint.c: Fix common/ includes.
7305         * tracefile-tfile.c: Fix common/ includes.
7306         * top.h: Fix common/ includes.
7307         * top.c: Fix common/ includes.
7308         * thread.c: Fix common/ includes.
7309         * target/waitstatus.h: Fix common/ includes.
7310         * target/waitstatus.c: Fix common/ includes.
7311         * target.h: Fix common/ includes.
7312         * target.c: Fix common/ includes.
7313         * target-memory.c: Fix common/ includes.
7314         * target-descriptions.c: Fix common/ includes.
7315         * symtab.h: Fix common/ includes.
7316         * symfile.c: Fix common/ includes.
7317         * stap-probe.c: Fix common/ includes.
7318         * spu-linux-nat.c: Fix common/ includes.
7319         * sparc-nat.c: Fix common/ includes.
7320         * source.c: Fix common/ includes.
7321         * solib.c: Fix common/ includes.
7322         * solib-target.c: Fix common/ includes.
7323         * ser-unix.c: Fix common/ includes.
7324         * ser-tcp.c: Fix common/ includes.
7325         * ser-pipe.c: Fix common/ includes.
7326         * ser-base.c: Fix common/ includes.
7327         * selftest-arch.c: Fix common/ includes.
7328         * s12z-tdep.c: Fix common/ includes.
7329         * rust-exp.y: Fix common/ includes.
7330         * rs6000-aix-tdep.c: Fix common/ includes.
7331         * riscv-tdep.c: Fix common/ includes.
7332         * remote.c: Fix common/ includes.
7333         * remote-notif.h: Fix common/ includes.
7334         * remote-fileio.h: Fix common/ includes.
7335         * remote-fileio.c: Fix common/ includes.
7336         * regcache.h: Fix common/ includes.
7337         * regcache.c: Fix common/ includes.
7338         * record-btrace.c: Fix common/ includes.
7339         * python/python.c: Fix common/ includes.
7340         * python/py-type.c: Fix common/ includes.
7341         * python/py-inferior.c: Fix common/ includes.
7342         * progspace.h: Fix common/ includes.
7343         * producer.c: Fix common/ includes.
7344         * procfs.c: Fix common/ includes.
7345         * proc-api.c: Fix common/ includes.
7346         * printcmd.c: Fix common/ includes.
7347         * ppc-linux-nat.c: Fix common/ includes.
7348         * parser-defs.h: Fix common/ includes.
7349         * osdata.c: Fix common/ includes.
7350         * obsd-nat.c: Fix common/ includes.
7351         * nat/x86-linux.c: Fix common/ includes.
7352         * nat/x86-linux-dregs.c: Fix common/ includes.
7353         * nat/x86-dregs.h: Fix common/ includes.
7354         * nat/x86-dregs.c: Fix common/ includes.
7355         * nat/ppc-linux.c: Fix common/ includes.
7356         * nat/mips-linux-watch.h: Fix common/ includes.
7357         * nat/mips-linux-watch.c: Fix common/ includes.
7358         * nat/linux-waitpid.c: Fix common/ includes.
7359         * nat/linux-ptrace.h: Fix common/ includes.
7360         * nat/linux-ptrace.c: Fix common/ includes.
7361         * nat/linux-procfs.c: Fix common/ includes.
7362         * nat/linux-personality.c: Fix common/ includes.
7363         * nat/linux-osdata.c: Fix common/ includes.
7364         * nat/linux-namespaces.c: Fix common/ includes.
7365         * nat/linux-btrace.h: Fix common/ includes.
7366         * nat/linux-btrace.c: Fix common/ includes.
7367         * nat/fork-inferior.c: Fix common/ includes.
7368         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7369         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7370         * nat/aarch64-linux.c: Fix common/ includes.
7371         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7372         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7373         * namespace.h: Fix common/ includes.
7374         * mips-linux-tdep.c: Fix common/ includes.
7375         * minsyms.c: Fix common/ includes.
7376         * mi/mi-parse.h: Fix common/ includes.
7377         * mi/mi-main.c: Fix common/ includes.
7378         * mi/mi-cmd-env.c: Fix common/ includes.
7379         * memrange.h: Fix common/ includes.
7380         * memattr.c: Fix common/ includes.
7381         * maint.h: Fix common/ includes.
7382         * maint.c: Fix common/ includes.
7383         * main.c: Fix common/ includes.
7384         * machoread.c: Fix common/ includes.
7385         * location.c: Fix common/ includes.
7386         * linux-thread-db.c: Fix common/ includes.
7387         * linux-nat.c: Fix common/ includes.
7388         * linux-fork.c: Fix common/ includes.
7389         * inline-frame.c: Fix common/ includes.
7390         * infrun.c: Fix common/ includes.
7391         * inflow.c: Fix common/ includes.
7392         * inferior.h: Fix common/ includes.
7393         * inferior.c: Fix common/ includes.
7394         * infcmd.c: Fix common/ includes.
7395         * inf-ptrace.c: Fix common/ includes.
7396         * inf-child.c: Fix common/ includes.
7397         * ia64-linux-nat.c: Fix common/ includes.
7398         * i387-tdep.c: Fix common/ includes.
7399         * i386-tdep.c: Fix common/ includes.
7400         * i386-linux-tdep.c: Fix common/ includes.
7401         * i386-linux-nat.c: Fix common/ includes.
7402         * i386-go32-tdep.c: Fix common/ includes.
7403         * i386-fbsd-tdep.c: Fix common/ includes.
7404         * i386-fbsd-nat.c: Fix common/ includes.
7405         * guile/scm-type.c: Fix common/ includes.
7406         * guile/guile.c: Fix common/ includes.
7407         * go32-nat.c: Fix common/ includes.
7408         * gnu-nat.c: Fix common/ includes.
7409         * gdbthread.h: Fix common/ includes.
7410         * gdbarch-selftests.c: Fix common/ includes.
7411         * gdb_usleep.c: Fix common/ includes.
7412         * gdb_select.h: Fix common/ includes.
7413         * gdb_bfd.c: Fix common/ includes.
7414         * gcore.c: Fix common/ includes.
7415         * fork-child.c: Fix common/ includes.
7416         * findvar.c: Fix common/ includes.
7417         * fbsd-nat.c: Fix common/ includes.
7418         * event-top.c: Fix common/ includes.
7419         * event-loop.c: Fix common/ includes.
7420         * dwarf2read.c: Fix common/ includes.
7421         * dwarf2loc.c: Fix common/ includes.
7422         * dwarf2-frame.c: Fix common/ includes.
7423         * dwarf-index-cache.c: Fix common/ includes.
7424         * dtrace-probe.c: Fix common/ includes.
7425         * disasm-selftests.c: Fix common/ includes.
7426         * defs.h: Fix common/ includes.
7427         * csky-tdep.c: Fix common/ includes.
7428         * cp-valprint.c: Fix common/ includes.
7429         * cp-support.h: Fix common/ includes.
7430         * cp-support.c: Fix common/ includes.
7431         * corelow.c: Fix common/ includes.
7432         * completer.h: Fix common/ includes.
7433         * completer.c: Fix common/ includes.
7434         * compile/compile.c: Fix common/ includes.
7435         * compile/compile-loc2c.c: Fix common/ includes.
7436         * compile/compile-cplus-types.c: Fix common/ includes.
7437         * compile/compile-cplus-symbols.c: Fix common/ includes.
7438         * command.h: Fix common/ includes.
7439         * cli/cli-dump.c: Fix common/ includes.
7440         * cli/cli-cmds.c: Fix common/ includes.
7441         * charset.c: Fix common/ includes.
7442         * build-id.c: Fix common/ includes.
7443         * btrace.h: Fix common/ includes.
7444         * btrace.c: Fix common/ includes.
7445         * breakpoint.h: Fix common/ includes.
7446         * breakpoint.c: Fix common/ includes.
7447         * ax.h:
7448         (enum agent_op): Fix common/ includes.
7449         * ax-general.c (struct aop_map): Fix common/ includes.
7450         * ax-gdb.c: Fix common/ includes.
7451         * auxv.c: Fix common/ includes.
7452         * auto-load.c: Fix common/ includes.
7453         * arm-tdep.c: Fix common/ includes.
7454         * arch/riscv.c: Fix common/ includes.
7455         * arch/ppc-linux-common.c: Fix common/ includes.
7456         * arch/i386.c: Fix common/ includes.
7457         * arch/arm.c: Fix common/ includes.
7458         * arch/arm-linux.c: Fix common/ includes.
7459         * arch/arm-get-next-pcs.c: Fix common/ includes.
7460         * arch/amd64.c: Fix common/ includes.
7461         * arch/aarch64.c: Fix common/ includes.
7462         * arch/aarch64-insn.c: Fix common/ includes.
7463         * arch-utils.c: Fix common/ includes.
7464         * amd64-windows-tdep.c: Fix common/ includes.
7465         * amd64-tdep.c: Fix common/ includes.
7466         * amd64-sol2-tdep.c: Fix common/ includes.
7467         * amd64-obsd-tdep.c: Fix common/ includes.
7468         * amd64-nbsd-tdep.c: Fix common/ includes.
7469         * amd64-linux-tdep.c: Fix common/ includes.
7470         * amd64-linux-nat.c: Fix common/ includes.
7471         * amd64-fbsd-tdep.c: Fix common/ includes.
7472         * amd64-fbsd-nat.c: Fix common/ includes.
7473         * amd64-dicos-tdep.c: Fix common/ includes.
7474         * amd64-darwin-tdep.c: Fix common/ includes.
7475         * agent.c: Fix common/ includes.
7476         * ada-lang.h: Fix common/ includes.
7477         * ada-lang.c: Fix common/ includes.
7478         * aarch64-tdep.c: Fix common/ includes.
7479
7480 2019-01-25  Tom Tromey  <tom@tromey.com>
7481
7482         * common/create-version.sh: Use common/version.h.
7483
7484 2019-01-24  Pedro Alves  <palves@redhat.com>
7485
7486         * infrun.c (signal_stop, signal_print, signal_program)
7487         (signal_catch, signal_pass): Now arrays instead of pointers.
7488         (update_signals_program_target, do_target_resume)
7489         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7490         * linux-nat.c (linux_nat_target::pass_signals)
7491         (linux_nat_target::create_inferior, linux_nat_target::attach):
7492         Adjust.
7493         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7494         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7495         * procfs.c (procfs_target::pass_signals): Adjust.
7496         * record-full.c (record_full_target::resume): Adjust.
7497         * remote.c (remote_target::pass_signals)
7498         (remote_target::program_signals): Adjust.
7499         * target-debug.h (target_debug_print_signals): Now takes a
7500         gdb::array_view as parameter.  Adjust.
7501         * target.h (target_ops) <pass_signals, program_signals>: Replace
7502         pointer and length parameters with gdb::array_view.
7503         (target_pass_signals, target_program_signals): Likewise.
7504         * target-delegates.c: Regenerate.
7505
7506 2019-01-24  Pedro Alves  <palves@redhat.com>
7507
7508         * common/forward-scope-exit.h
7509         (forward_scope_exit::forward_scope_exit): Pass arguments to
7510         m_bind_function directly, instead of creating a std::bind and
7511         copying that.
7512
7513 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7514
7515         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7516         for static members.
7517         (pass_in_v_vfp_candidate): Likewise.
7518
7519 2019-01-23  Tom Tromey  <tom@tromey.com>
7520             Pedro Alves  <palves@redhat.com>
7521
7522         * regcache.c (class regcache_invalidator): Remove.
7523         (regcache::raw_write): Use make_scope_exit.
7524
7525 2019-01-23  Tom Tromey  <tom@tromey.com>
7526
7527         * ui-out.h (class ui_out_emit_type): Update comment.
7528
7529 2019-01-23  Tom Tromey  <tom@tromey.com>
7530
7531         * infrun.c (fetch_inferior_event): Update comment.
7532
7533 2019-01-23  Tom Tromey  <tom@tromey.com>
7534             Pedro Alves  <palves@redhat.com>
7535
7536         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7537         parameter.
7538         (fetch_inferior_event): Use SCOPE_EXIT.
7539
7540
7541 2019-01-23  Tom Tromey  <tom@tromey.com>
7542             Pedro Alves  <palves@redhat.com>
7543
7544         * infrun.c (disable_thread_events): Delete.
7545         (stop_all_threads): Use SCOPE_EXIT.
7546
7547 2019-01-23  Tom Tromey  <tom@tromey.com>
7548             Pedro Alves  <palves@redhat.com>
7549
7550         * symfile.c: Include forward-scope-exit.h.
7551         (clear_symtab_users_cleanup): Replace forward declaration with
7552         a FORWARD_SCOPE_EXIT.
7553         (syms_from_objfile_1): Use the forward_scope_exit and
7554         gdb::optional instead of cleanup_function.
7555         (reread_symbols): Use the forward_scope_exit instead of
7556         cleanup_function.
7557         (clear_symtab_users_cleanup): Remove function.
7558
7559 2019-01-23  Tom Tromey  <tom@tromey.com>
7560             Pedro Alves  <palves@redhat.com>
7561
7562         * linux-nat.c: Include scope-exit.h.
7563         (cleanup_target_stop): Remove.
7564         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7565         SCOPE_EXIT.
7566
7567 2019-01-23  Tom Tromey  <tom@tromey.com>
7568             Pedro Alves  <palves@redhat.com>
7569
7570         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7571         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7572
7573 2019-01-23  Tom Tromey  <tom@tromey.com>
7574             Andrew Burgess  <andrew.burgess@embecosm.com>
7575             Pedro Alves  <palves@redhat.com>
7576
7577         * infrun.c (fetch_inferior_event): Use scope_exit.
7578         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7579         * top.c (execute_command): Use scope_exit.
7580         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7581         * utils.c (do_bpstat_clear_actions_cleanup)
7582         (make_bpstat_clear_actions_cleanup): Remove.
7583
7584 2019-01-23  Tom Tromey  <tom@tromey.com>
7585             Pedro Alves  <palves@redhat.com>
7586
7587         * infrun.c: Include "common/scope-exit.h"
7588         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7589         (wait_for_inferior): Use SCOPE_EXIT.
7590         (fetch_inferior_event): Use scope_exit.
7591
7592 2019-01-23  Tom Tromey  <tom@tromey.com>
7593             Pedro Alves  <palves@redhat.com>
7594
7595         * breakpoint.c (create_breakpoint): Remove cleanup.
7596
7597 2019-01-23  Tom Tromey  <tom@tromey.com>
7598             Andrew Burgess  <andrew.burgess@embecosm.com>
7599             Pedro Alves  <palves@redhat.com>
7600
7601 2019-01-23  Pedro Alves  <palves@redhat.com>
7602
7603         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7604
7605 2019-01-23  Pedro Alves  <palves@redhat.com>
7606             Andrew Burgess  <andrew.burgess@embecosm.com>
7607
7608         * gdbthread.h: Include "common/forward-scope-exit.h".
7609         (scoped_finish_thread_state): Redefine custom class in terms of
7610         forward_scope_exit.
7611
7612 2019-01-23  Pedro Alves  <palves@redhat.com>
7613             Andrew Burgess  <andrew.burgess@embecosm.com>
7614
7615         * common/forward-scope-exit.h: New file.
7616
7617 2019-01-23  Pedro Alves  <palves@redhat.com>
7618             Andrew Burgess  <andrew.burgess@embecosm.com>
7619             Tom Tromey  <tom@tromey.com>
7620
7621         * common/scope-exit.h: New file.
7622
7623 2019-01-23  Pedro Alves  <palves@redhat.com>
7624
7625         * common/preprocessor.h (ESC): Rename to ...
7626         (ESC_PARENS): ... this.
7627         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7628         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7629
7630 2019-01-23  Tom Tromey  <tom@tromey.com>
7631
7632         * language.h (class scoped_switch_to_sym_language_if_auto):
7633         Initialize m_lang in both cases.
7634
7635 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7636
7637         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7638         with XCNEW.
7639
7640 2019-01-22  Tom Tromey  <tom@tromey.com>
7641
7642         * corelow.c: Do not include sys/file.h.
7643
7644 2019-01-22  Tom Tromey  <tom@tromey.com>
7645
7646         * tui/tui-wingeneral.h: Include gdb_curses.h.
7647
7648 2019-01-22  Tom Tromey  <tom@tromey.com>
7649
7650         * source-cache.h (class source_cache) <get_source_lines,
7651         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7652
7653 2019-01-22  Tom Tromey  <tom@tromey.com>
7654
7655         * remote-fileio.h (struct remote_target): Declare.
7656
7657 2019-01-22  Tom Tromey  <tom@tromey.com>
7658
7659         * python/py-arch.c: Do not include py-ref.h.
7660         * python/py-bpevent.c: Do not include py-ref.h.
7661         * python/py-cmd.c: Do not include py-ref.h.
7662         * python/py-continueevent.c: Do not include py-ref.h.
7663         * python/py-event.h: Do not include py-ref.h.
7664         * python/py-evtregistry.c: Do not include py-ref.h.
7665         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7666         * python/py-frame.c: Do not include py-ref.h.
7667         * python/py-framefilter.c: Do not include py-ref.h.
7668         * python/py-function.c: Do not include py-ref.h.
7669         * python/py-infevents.c: Do not include py-ref.h.
7670         * python/py-linetable.c: Do not include py-ref.h.
7671         * python/py-objfile.c: Do not include py-ref.h.
7672         * python/py-param.c: Do not include py-ref.h.
7673         * python/py-prettyprint.c: Do not include py-ref.h.
7674         * python/py-progspace.c: Do not include py-ref.h.
7675         * python/py-symbol.c: Do not include py-ref.h.
7676         * python/py-symtab.c: Do not include py-ref.h.
7677         * python/py-type.c: Do not include py-ref.h.
7678         * python/py-unwind.c: Do not include py-ref.h.
7679         * python/py-utils.c: Do not include py-ref.h.
7680         * python/py-value.c: Do not include py-ref.h.
7681         * python/py-varobj.c: Do not include py-ref.h.
7682         * python/py-xmethods.c: Do not include py-ref.h.
7683         * python/python.c: Do not include py-ref.h.
7684         * varobj.c: Do not include py-ref.h.
7685
7686 2019-01-22  Tom Tromey  <tom@tromey.com>
7687
7688         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7689         keyword for bcache.
7690
7691 2019-01-22  Tom Tromey  <tom@tromey.com>
7692
7693         * compile/compile-cplus-types.c: Remove a comment by #include.
7694
7695 2019-01-22  Tom Tromey  <tom@tromey.com>
7696
7697         * compile/gcc-c-plugin.h: Include compile-internal.h.
7698
7699 2019-01-22  Tom Tromey  <tom@tromey.com>
7700
7701         * stabsread.c (EXTERN): Do not define.
7702         (symnum, next_symbol_text_func, processing_gcc_compilation)
7703         (within_function, global_sym_chain, global_stabs)
7704         (previous_stab_code, this_object_header_files)
7705         (n_this_object_header_files)
7706         (n_allocated_this_object_header_files): Define.
7707         * stabsread.h (EXTERN): Never define.  Use "extern".
7708
7709 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7710
7711         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7712         history_value.
7713
7714 2019-01-21  Tom Tromey  <tom@tromey.com>
7715
7716         * ui-out.c: Fix includes.
7717         * tui/tui-source.c: Fix includes.
7718         * target.c: Fix includes.
7719         * remote.c: Fix includes.
7720         * regcache.c: Fix includes.
7721         * python/py-block.c: Fix includes.
7722         * printcmd.c: Fix includes.
7723         * or1k-tdep.c: Fix includes.
7724         * mi/mi-main.c: Fix includes.
7725         * m32r-tdep.c: Fix includes.
7726         * csky-tdep.c: Fix includes.
7727         * compile/compile-cplus-types.c: Fix includes.
7728         * cli/cli-interp.c: Fix includes.
7729
7730 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7731
7732         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7733         for padding.
7734
7735 2019-01-16  Tom Tromey  <tom@tromey.com>
7736
7737         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7738         earlier.
7739         (struct objfile) <msymbols_range>: Move from top level.
7740         <msymbols>: New method.
7741         (class objfile_msymbols): Remove.
7742         * symtab.c (default_collect_symbol_completion_matches_break_on):
7743         Update.
7744         * symmisc.c (dump_msymbols): Update.
7745         * stabsread.c (scan_file_globals): Update.
7746         * objc-lang.c (info_selectors_command, info_classes_command)
7747         (find_methods): Update.
7748         * minsyms.c (find_solib_trampoline_target): Update.
7749         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7750         * coffread.c (coff_symfile_read): Update.
7751         * ada-lang.c (ada_lookup_simple_minsym)
7752         (ada_collect_symbol_completion_matches): Update.
7753
7754 2019-01-16  Tom Tromey  <tom@tromey.com>
7755
7756         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7757         type.  Remove no-argument constructor.
7758         <iterator::operator++>: Simplify.
7759         <begin>: Update.
7760         <end>: Use minimal_symbol_count.
7761
7762 2019-01-16  Tom Tromey  <tom@tromey.com>
7763
7764         * objfiles.h (struct objfile) <psymtabs>: New method.
7765         (class objfile_psymtabs): Remove.
7766         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7767         typedef.
7768         <range>: New method.
7769         (require_partial_symbols): Change return type.
7770         * psymtab.c (require_partial_symbols)
7771         (psym_expand_symtabs_matching): Update.
7772         * mdebugread.c (parse_partial_symbols): Update.
7773         * dbxread.c (dbx_end_psymtab): Update.
7774
7775 2019-01-15  Tom Tromey  <tom@tromey.com>
7776
7777         * symtab.c (lookup_objfile_from_block)
7778         (lookup_symbol_in_objfile_symtabs)
7779         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7780         (find_line_symtab, info_sources_command)
7781         (default_collect_symbol_completion_matches_break_on)
7782         (make_source_files_completion_list): Update.
7783         * symmisc.c (print_objfile_statistics, dump_objfile)
7784         (maintenance_print_symbols, maintenance_info_symtabs)
7785         (maintenance_check_symtabs, maintenance_info_line_tables):
7786         Update.
7787         * source.c (select_source_symtab)
7788         (forget_cached_source_info_for_objfile): Update.
7789         * objfiles.h (class objfile_compunits): Remove.
7790         (struct objfile) <compunits_range>: New typedef.
7791         (compunits): New method.
7792         * objfiles.c (objfile_relocate1): Update.
7793         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7794         * maint.c (count_symtabs_and_blocks): Update.
7795         * linespec.c (iterate_over_all_matching_symtabs): Update.
7796         * cp-support.c (add_symbol_overload_list_qualified): Update.
7797         * coffread.c (coff_symtab_read): Update.
7798         * ada-lang.c (add_nonlocal_symbols)
7799         (ada_collect_symbol_completion_matches)
7800         (ada_add_global_exceptions): Update.
7801
7802 2019-01-15  Tom Tromey  <tom@tromey.com>
7803
7804         * progspace.h (program_space) <objfiles_safe_range>: New
7805         typedef.
7806         <objfiles_safe>: New method.
7807         * objfiles.h (class all_objfiles_safe): Remove.
7808         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7809         * jit.c (jit_inferior_exit_hook): Update.
7810
7811 2019-01-17  Tom Tromey  <tom@tromey.com>
7812
7813         * progspace.h (program_space) <objfiles_range>: New typedef.
7814         <objfiles>: New method.
7815         <objfiles_head>: Rename from objfiles.
7816         (object_files): Update.
7817         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7818         * guile/scm-pretty-print.c
7819         (ppscm_find_pretty_printer_from_objfiles): Update.
7820         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7821         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7822         Update.
7823         * python/py-progspace.c (pspy_get_objfiles): Update.
7824         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7825         Update.
7826         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7827         (objfpy_lookup_objfile_by_build_id): Update.
7828         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7829         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7830         Update.
7831         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7832         (expand_symtab_containing_pc, lookup_objfile_from_block)
7833         (lookup_static_symbol, basic_lookup_transparent_type)
7834         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7835         (find_line_symtab, info_sources_command)
7836         (default_collect_symbol_completion_matches_break_on)
7837         (make_source_files_completion_list, find_main_name): Update.
7838         * symmisc.c (print_symbol_bcache_statistics)
7839         (print_objfile_statistics, maintenance_print_symbols)
7840         (maintenance_print_msymbols, maintenance_print_objfiles)
7841         (maintenance_info_symtabs, maintenance_check_symtabs)
7842         (maintenance_expand_symtabs, maintenance_info_line_tables):
7843         Update.
7844         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7845         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7846         (map_overlay_command, unmap_overlay_command)
7847         (simple_overlay_update, expand_symtabs_matching)
7848         (map_symbol_filenames): Update.
7849         * symfile-debug.c (set_debug_symfile): Update.
7850         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7851         Update.
7852         * source.c (select_source_symtab, forget_cached_source_info):
7853         Update.
7854         * solib.c (solib_read_symbols): Update.
7855         * solib-spu.c (append_ocl_sos): Update.
7856         * psymtab.c (maintenance_print_psymbols)
7857         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7858         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7859         * printcmd.c (info_symbol_command): Update.
7860         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7861         Update.
7862         * objfiles.h (class all_objfiles): Remove.
7863         * objfiles.c (have_partial_symbols, have_full_symbols)
7864         (have_minimal_symbols, qsort_cmp, update_section_map)
7865         (shared_objfile_contains_address_p)
7866         (default_iterate_over_objfiles_in_search_order): Update.
7867         * objc-lang.c (info_selectors_command, info_classes_command)
7868         (find_methods): Update.
7869         * minsyms.c (find_solib_trampoline_target): Update.
7870         * maint.c (maintenance_info_sections)
7871         (maintenance_translate_address, count_symtabs_and_blocks):
7872         Update.
7873         * main.c (captured_main_1): Update.
7874         * linux-thread-db.c (try_thread_db_load_from_pdir)
7875         (has_libpthread): Update.
7876         * linespec.c (iterate_over_all_matching_symtabs)
7877         (search_minsyms_for_name): Update.
7878         * jit.c (jit_find_objf_with_entry_addr): Update.
7879         * hppa-tdep.c (find_unwind_entry)
7880         (hppa_lookup_stub_minimal_symbol): Update.
7881         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7882         Update.
7883         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7884         (elf_gnu_ifunc_resolve_by_got): Update.
7885         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7886         * dwarf-index-write.c (save_gdb_index_command): Update.
7887         * cp-support.c (add_symbol_overload_list_qualified): Update.
7888         * breakpoint.c (create_overlay_event_breakpoint)
7889         (create_longjmp_master_breakpoint)
7890         (create_std_terminate_master_breakpoint)
7891         (create_exception_master_breakpoint): Update.
7892         * blockframe.c (find_pc_partial_function): Update.
7893         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7894         (ada_collect_symbol_completion_matches)
7895         (ada_add_global_exceptions): Update.
7896
7897 2019-01-17  Tom Tromey  <tom@tromey.com>
7898
7899         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7900         declare VEC.
7901         (solib_target_parse_libraries): Change return type.
7902         (library_list_start_segment, library_list_start_section)
7903         (library_list_end_library, library_list_start_library); Update.
7904         (solib_target_free_library_list): Remove.
7905         (solib_target_parse_libraries): Remove cleanup.  Change return
7906         type.
7907         (solib_target_current_sos): Update.
7908
7909 2019-01-17  Tom Tromey  <tromey@bapiya>
7910
7911         * valprint.c: Replace "the the" with "the".
7912         * symtab.c: Replace "the the" with "the".
7913         * solib.c: Replace "the the" with "the".
7914         * solib-dsbt.c: Replace "the the" with "the".
7915         * linespec.c: Replace "the the" with "the".
7916         * dwarf2loc.h: Replace "the the" with "the".
7917         * amd64-windows-tdep.c: Replace "the the" with "the".
7918         * aarch64-tdep.c: Replace "the the" with "the".
7919
7920 2019-01-16  Keith Seitz  <keiths@redhat.com>
7921
7922         PR gdb/23773
7923         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7924         <builder>: Rename to ..
7925         <m_builder>: ... this and make private.
7926         (dwarf2_cu::get_builder): New method.  Change all users of
7927         `builder' to use this method.
7928         (dwarf2_start_symtab): Move to ...
7929         (dwarf2_cu::start_symtab): ... here.  Update all callers
7930         (setup_type_unit_groups): Move to ...
7931         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7932         callers.
7933         (dwarf2_cu::reset_builder): New method.
7934         (process_full_compunit, process_full_type_unit): Use
7935         dwarf2_cu::reset_builder.
7936         (follow_die_offset): Record the ancestor CU if it is different
7937         from the followed DIE's CU.
7938         (follow_die_sig_1): Likewise.
7939
7940 2019-01-15  Tom Tromey  <tom@tromey.com>
7941
7942         * remote.c (class remote_state) <buf>: Now a char_vector.
7943         <buf_size>: Remove.
7944         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7945         parameter.
7946         (remote_target::getpkt_or_notif_sane_1)
7947         (remote_target::getpkt_sane)
7948         (remote_target::getpkt_or_notif_sane): Likewise.
7949         (class remote_target) <putpkt>: New overload.
7950         (remote_target::read_frame): Change type of "buf_p".  Remove
7951         sizeof_p parameter.
7952         (packet_ok): New overload.
7953         (packet_check_result): New overload.
7954         Update all uses.
7955
7956 2019-01-14  Tom Tromey  <tom@tromey.com>
7957
7958         * remote-notif.c (handle_notification, remote_notif_ack)
7959         (remote_notif_parse): Make "buf" const.
7960         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7961         const.
7962         (remote_notif_parse, remote_notif_ack, handle_notification):
7963         Likewise.
7964         * remote.c (remote_notif_stop_parse): Make "buf" const.
7965         (remote_target::remote_parse_stop_reply): Make "buf" const.
7966         (remote_notif_stop_ack): Make "buf" const.
7967
7968 2019-01-14  Tom Tromey  <tom@tromey.com>
7969
7970         * remote.c (remote_console_output): Make parameter const.
7971
7972 2019-01-14  Tom Tromey  <tom@tromey.com>
7973
7974         * target-debug.h (target_debug_print_signals): Constify.
7975         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7976         * procfs.c (procfs_target::pass_signals): Update.
7977         * linux-nat.c (linux_nat_target::pass_signals): Update.
7978         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7979         * target-delegates.c: Rebuild.
7980         * remote.c (remote_target::program_signals): Update.
7981         (remote_target::pass_signals): Update.
7982         * target.c (target_pass_signals): Constify argument.
7983         (target_program_signals): Likewise.
7984         * target.h (struct target_ops) <pass_signals, program_signals>:
7985         Constify argument.
7986         (target_pass_signals, target_program_signals): Constify argument.
7987
7988 2019-01-14  Tom Tromey  <tom@tromey.com>
7989
7990         PR tui/28819:
7991         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7992
7993 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7994
7995         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7996         field.
7997         * rs6000-tdep.c: Include reggroups.h.
7998         (IS_V_ALIAS_PSEUDOREG): Define.
7999         (rs6000_register_name): Return names for the "vX" aliases.
8000         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8001         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8002         aliases.  Call default_register_reggroup_p for all other
8003         pseudo-registers.
8004         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8005         New functions.
8006         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8007         Handle "vX" aliases.
8008         (v_alias_pseudo_register_collect): New function.
8009         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8010         (rs6000_gdbarch_init): Initialize "vX" aliases as
8011         pseudo-registers.  Restore registration of
8012         rs6000_pseudo_register_reggroup_p with
8013         set_tdesc_pseudo_register_reggroup_p.
8014
8015 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8016
8017         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8018         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8019         set_gdbarch_num_pseudo_regs.
8020
8021 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8022
8023         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8024         Remove arg prefixname, add do_set and do_show.
8025         Add member functions set_list and show_list.
8026         * cli/cli-style.c (class cli_style_option): Update accordingly.
8027         (style_set_list): Move to file scope.
8028         (style_show_list): Likewise.
8029         (set_style): Call help_list.
8030         (show_style): Call cmd_show_list.
8031         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8032         Update to use the new macro.
8033
8034 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8035
8036         * ada-lang.c (_initialize_ada_language): Expand the help text
8037         for the "catch exception" command.
8038
8039 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8040
8041         * symtab.c (matching_obj_sections): Initialize obj,
8042         declare it closer to its usage.
8043
8044 2019-01-10  Tom Tromey  <tom@tromey.com>
8045
8046         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8047         (basic_inf_threads_range): Remove.
8048         (inf_threads_range, inf_non_exited_threads_range)
8049         (safe_inf_threads_range): Use next_adapter.
8050
8051 2019-01-10  Keith Seitz  <keiths@redhat.com>
8052
8053         PR gdb/23712
8054         PR symtab/23010
8055         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8056         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8057
8058 2019-01-10  Keith Seitz  <keiths@redhat.com>
8059
8060         PR gdb/23712
8061         PR symtab/23010
8062         * dictionary.c (pending_to_vector): Remove.
8063         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8064         Remove _1 suffix, replacing functions of the same name.  Update
8065         all callers.
8066         (dict_create_hashed, dict_create_hashed_expandable)
8067         (dict_create_linear, dict_create_linear_expandable, dict_free)
8068         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8069         Make functions static.
8070
8071 2019-01-10  Keith Seitz  <keiths@redhat.com>
8072
8073         PR gdb/23712
8074         PR symtab/23010
8075         * dictionary.h (struct dictionary): Replace declaration with
8076         multidictionary.
8077         (dict_create_hashed, dict_create_hashed_expandable)
8078         (dict_create_linear, dict_create_linear_expandable)
8079         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8080         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8081         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8082         taking multidictionary argument.
8083         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8084         * block.h (struct block) <dict>: Change to multidictionary
8085         and rename `multidict'.
8086         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8087         symmisc.c: Update all dictionary references to multidictionary.
8088
8089 2019-01-10  Keith Seitz  <keiths@redhat.com>
8090
8091         PR gdb/23712
8092         PR symtab/23010
8093         * dictionary.c: Include unordered_map.
8094         (pending_to_vector): New function.
8095         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8096         Rewrite the non-"_1" functions to take vector instead
8097         of linked list.
8098         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8099         "new" _1 versions of the same name.
8100         (multidictionary): Define.
8101         (std::hash<enum language): New definition.
8102         (collate_pending_symbols_by_language, mdict_create_hashed)
8103         (mdict_create_hashed_expandable, mdict_create_linear)
8104         (mdict_create_linear_expandable, mdict_free)
8105         (find_language_dictionary, create_new_language_dictionary)
8106         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8107         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8108         (mdict_size, mdict_empty): New functions.
8109         * dictionary.h (mdict_iterator): Define.
8110
8111 2019-01-10  Pedro Alves  <palves@redhat.com>
8112
8113         * breakpoint.c (read_uploaded_action)
8114         (create_tracepoint_from_upload): Adjust to use
8115         gdb::unique_xmalloc_ptr.
8116         * ctf.c (ctf_write_uploaded_tp):
8117         (SET_ARRAY_FIELD): Use emplace_back.
8118         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8119         * tracefile-tfile.c (tfile_write_uploaded_tp):
8120         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8121         gdb::unique_xmalloc_ptr.
8122         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8123         at_string, cond_string, cmd_strings>: Replace char pointers
8124         with gdb::unique_xmalloc_ptr.
8125
8126 2019-01-10  Pedro Alves  <palves@redhat.com>
8127
8128         * solib-target.c (library_list_start_library): Don't xstrdup name.
8129
8130 2019-01-10  Pedro Alves  <palves@redhat.com>
8131
8132         * mdebugread.c (parse_partial_symbols): Use
8133         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8134
8135 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8136
8137         * linux-fork.c (scoped_switch_fork_info)
8138         <~scoped_switch_fork_info>: Fix incorrect variable name.
8139
8140 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8141
8142         * linux-fork.c (scoped_switch_fork_info)
8143         <scoped_switch_fork_info>: Make explicit.
8144         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8145
8146 2019-01-10  Tom Tromey  <tom@tromey.com>
8147
8148         * objfiles.h (objfile::reset_psymtabs): Update.
8149         * objfiles.c (objfile::objfile): Update.
8150         * psymtab.h (psymtab_storage::obstack): Update.
8151         (psymtab_storage::m_obstack): Use gdb::optional.
8152         (class psymtab_storage): Update comment.  Remove objfile
8153         parameter.
8154         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8155
8156 2019-01-10  Tom Tromey  <tom@tromey.com>
8157
8158         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8159         <free_psymtabs>: Now private.
8160         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8161         (allocate_psymtab): Use new method.
8162
8163 2019-01-10  Tom Tromey  <tom@tromey.com>
8164
8165         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8166         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8167         * mdebugread.c (parse_partial_symbols): Use
8168         allocate_dependencies.
8169         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8170         allocate_dependencies.
8171         (process_psymtab_comp_unit_reader)
8172         (build_type_psymtab_dependencies): Likewise.
8173         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8174
8175 2019-01-10  Tom Tromey  <tom@tromey.com>
8176
8177         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8178         PSYMBOL_SET_LANGUAGE.
8179         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8180
8181 2019-01-10  Tom Tromey  <tom@tromey.com>
8182
8183         * psymtab.h (psymtab_storage::obstack): New method.
8184         <m_obstack>: Rename from obstack; now private.
8185         * psymtab.c (psymtab_storage): Update.
8186         * dwarf2read.c (create_addrmap_from_index)
8187         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8188         Update.
8189
8190 2019-01-10  Tom Tromey  <tom@tromey.com>
8191
8192         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8193         * objfiles.h (objfile::reset_psymtabs): New method.
8194
8195 2019-01-10  Tom Tromey  <tom@tromey.com>
8196
8197         * symmisc.c (print_symbol_bcache_statistics): Update.
8198         (print_objfile_statistics): Update.
8199         * symfile.c (reread_symbols): Update.
8200         * psymtab.h (class psymtab_storage): New.
8201         * psymtab.c (psymtab_storage): New constructor.
8202         (~psymtab_storage): New destructor.
8203         (require_partial_symbols): Update.
8204         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8205         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8206         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8207         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8208         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8209         (start_psymtab_common, end_psymtab_common)
8210         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8211         (allocate_psymtab): Update.
8212         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8213         Update.
8214         (dump_psymtab_addrmap, maintenance_print_psymbols)
8215         (maintenance_check_psymtabs): Update.
8216         (class objfile_psymtabs): Move to objfiles.h.
8217         * psympriv.h (discard_psymtab): Now inline.
8218         (psymtab_discarder::psymtab_discarder): Update.
8219         (psymtab_discarder::~psymtab_discarder): Update.
8220         (ALL_OBJFILE_PSYMTABS): Rewrite.
8221         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8222         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8223         Remove fields.
8224         <partial_symtabs>: New field.
8225         (class objfile_psymtabs): Move from psymtab.h.  Update.
8226         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8227         psymbol_cache.
8228         (objfile::~objfile): Don't destroy psymbol_cache.
8229         * mdebugread.c (parse_partial_symbols): Update.
8230         * dwarf2read.c (create_addrmap_from_index)
8231         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8232         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8233         (add_partial_subprogram, dwarf2_ranges_read): Update.
8234         * dwarf-index-write.c (write_address_map)
8235         (write_one_signatured_type, recursively_write_psymbols)
8236         (class debug_names, class debug_names, write_psymtabs_to_index):
8237         Update.
8238
8239 2019-01-10  Tom Tromey  <tom@tromey.com>
8240
8241         * symtab.h (SYMBOL_SET_NAMES): Update.
8242         (symbol_set_names): Update.
8243         (MSYMBOL_SET_NAMES): Update.
8244         * symtab.c (symbol_set_names): Change argument to be an
8245         objfile_per_bfd_storage.
8246         * psymtab.c (add_psymbol_to_bcache): Update.
8247         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8248
8249 2019-01-10  Tom Tromey  <tom@tromey.com>
8250
8251         * symtab.c (create_demangled_names_hash): Change argument to be an
8252         objfile_per_bfd_storage.
8253         (symbol_set_names): Update.
8254
8255 2019-01-10  Tom Tromey  <tom@tromey.com>
8256
8257         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8258         init_psymbol_list.
8259         * psymtab.c (init_psymbol_list): Do nothing if already called.
8260         * psympriv.h (init_psymbol_list): Add comment.
8261         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8262         init_psymbol_list.
8263         * dbxread.c (dbx_symfile_read): Unconditionally call
8264         init_psymbol_list.
8265
8266 2019-01-10  Tom Tromey  <tom@tromey.com>
8267
8268         * xcoffread.c (scan_xcoff_symtab): Update.
8269         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8270         "where".
8271         * mdebugread.c (parse_partial_symbols)
8272         (handle_psymbol_enumerators): Update.
8273         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8274         * dbxread.c (read_dbx_symtab): Update.
8275         * psympriv.h (psymbol_placement): New enum.
8276         (add_psymbol_to_list): Update.
8277
8278 2019-01-10  Tom Tromey  <tom@tromey.com>
8279
8280         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8281         static_psymbols parameters.
8282         (scan_xcoff_symtab): Update.
8283         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8284         static_psymbols parameters.
8285         * psympriv.h (start_psymtab_common): Update.
8286         * mdebugread.c (parse_partial_symbols): Update.
8287         * dwarf2read.c (create_partial_symtab): Update.
8288         * dbxread.c (read_dbx_symtab): Update.
8289         (start_psymtab): Remove global_psymbols and static_psymbols
8290         parameters.
8291
8292 2019-01-10  Tom Tromey  <tom@tromey.com>
8293
8294         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8295         * psymtab.c (allocate_psymtab): Add comment.
8296         * psympriv.h (allocate_psymtab): Add comment.
8297         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8298         initializations.
8299         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8300
8301 2019-01-10  Tom Tromey  <tom@tromey.com>
8302
8303         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8304         Don't declare.
8305         * mipsread.c: Include mdebugread.h.
8306         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8307         Declare.
8308         * elfread.c: Include mdebugread.h.
8309
8310 2019-01-09  Tom Tromey  <tom@tromey.com>
8311
8312         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8313         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8314         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8315         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8316         (psym_lookup_symbol, psym_find_last_source_symtab)
8317         (psym_forget_cached_source_info, psym_print_stats)
8318         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8319         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8320         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8321         (psym_find_compunit_symtab_by_address)
8322         (maintenance_print_psymbols, maintenance_info_psymtabs)
8323         (maintenance_check_psymtabs): Use ranged for.
8324         * psymtab.h (class objfile_psymtabs): New.
8325         (require_partial_symbols): Return objfile_psymtabs.
8326         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8327
8328 2019-01-09  Tom Tromey  <tom@tromey.com>
8329
8330         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8331         (find_pc_mapped_section, list_overlays_command)
8332         (map_overlay_command, unmap_overlay_command)
8333         (simple_overlay_update): Use all_objfiles.
8334         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8335         * printcmd.c (info_symbol_command): Use all_objfiles.
8336         * objfiles.h (ALL_OBJSECTIONS): Remove.
8337         * maint.c (maintenance_translate_address): Use all_objfiles.
8338         * gcore.c (gcore_create_callback): Use all_objfiles.
8339         (objfile_find_memory_regions): Likewise.
8340
8341 2019-01-09  Tom Tromey  <tom@tromey.com>
8342
8343         * symtab.c (find_line_symtab, info_sources_command)
8344         (make_source_files_completion_list): Use objfile_compunits.
8345         * source.c (select_source_symtab): Use objfile_compunits.
8346         * objfiles.h (struct objfile): Update comment.
8347         (ALL_OBJFILES): Remove.
8348         (ALL_FILETABS): Remove.
8349         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8350         objfile_compunits.
8351
8352 2019-01-09  Tom Tromey  <tom@tromey.com>
8353
8354         * symmisc.c (print_objfile_statistics, dump_objfile)
8355         (maintenance_print_symbols): Use compunit_filetabs.
8356         * source.c (forget_cached_source_info_for_objfile): Use
8357         compunit_filetabs.
8358         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8359         (ALL_FILETABS): Use compunit_filetabs.
8360         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8361         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8362
8363 2019-01-09  Tom Tromey  <tom@tromey.com>
8364
8365         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8366         (compunit_filetabs): New.
8367         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8368         compunit_filetabs.
8369         (info_sources_command, make_source_files_completion_list): Remove
8370         declaration.
8371         * symmisc.c (print_objfile_statistics, dump_objfile)
8372         (maintenance_print_symbols): Remove declaration.
8373         (maintenance_info_symtabs): Use compunit_filetabs.
8374         (maintenance_info_line_tables): Likewise.
8375         * source.c (select_source_symtab): Change local variable name.
8376         (forget_cached_source_info_for_objfile): Remove declaration.
8377         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8378         * objfiles.c (objfile_relocate1): Remove declaration.
8379         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8380         declaration.
8381         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8382         * coffread.c (coff_symtab_read): Remove declaration.
8383         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8384         compunit_filetabs.
8385
8386 2019-01-09  Tom Tromey  <tom@tromey.com>
8387
8388         * symtab.c (lookup_objfile_from_block)
8389         (find_pc_sect_compunit_symtab, search_symbols)
8390         (default_collect_symbol_completion_matches_break_on): Use
8391         objfile_compunits.
8392         * objfiles.h (ALL_COMPUNITS): Remove.
8393         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8394         * cp-support.c (add_symbol_overload_list_qualified): Use
8395         objfile_compunits.
8396         * ada-lang.c (ada_collect_symbol_completion_matches)
8397         (ada_add_global_exceptions): Use objfile_compunits.
8398
8399 2019-01-09  Tom Tromey  <tom@tromey.com>
8400
8401         * source.c (select_source_symtab)
8402         (forget_cached_source_info_for_objfile): Remove declaration.
8403         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8404         declaration.
8405         * maint.c (count_symtabs_and_blocks): Remove declaration.
8406         * cp-support.c (add_symbol_overload_list_qualified): Remove
8407         declaration.
8408         * coffread.c (coff_symtab_read): Remove declaration.
8409         * symtab.c (lookup_symbol_in_objfile_symtabs)
8410         (basic_lookup_transparent_type_1): Use objfile_compunits.
8411         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8412         (info_sources_command, search_symbols)
8413         (default_collect_symbol_completion_matches_break_on)
8414         (make_source_files_completion_list): Remove declaration.
8415         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8416         (ada_collect_symbol_completion_matches)
8417         (ada_add_global_exceptions): Remove declaration.
8418         * linespec.c (iterate_over_all_matching_symtabs): Use
8419         objfile_compunits.
8420         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8421         (class objfile_compunits): New.
8422         (ALL_COMPUNITS): Use objfile_compunits.
8423         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8424         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8425         objfile_compunits.
8426         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8427
8428 2019-01-09  Tom Tromey  <tom@tromey.com>
8429
8430         * symtab.c (search_symbols)
8431         (default_collect_symbol_completion_matches_break_on): Use
8432         objfile_msymbols.
8433         * ada-lang.c (ada_lookup_simple_minsym)
8434         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8435         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8436         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8437         objfile_msymbols.
8438         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8439         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8440         * objc-lang.c (find_methods): Use objfile_msymbols.
8441         (info_selectors_command, info_classes_command): Likewise.
8442         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8443         * objfiles.h (class objfile_msymbols): New.
8444         (ALL_OBJFILE_MSYMBOLS): Remove.
8445         (ALL_MSYMBOLS): Remove.
8446
8447 2019-01-09  Tom Tromey  <tom@tromey.com>
8448
8449         * common/next-iterator.h (next_adapter): Add Iterator template
8450         parameter.
8451         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8452         (class all_objfiles_safe): New.
8453         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8454         * objfiles.c (put_objfile_before): Update comment.
8455         (add_separate_debug_objfile): Likewise.
8456         (free_all_objfiles): Use all_objfiles_safe.
8457         (objfile_purge_solibs): Likewise.
8458
8459 2019-01-09  Tom Tromey  <tom@tromey.com>
8460
8461         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8462         (expand_symtab_containing_pc, lookup_static_symbol)
8463         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8464         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8465         all_objfiles.
8466         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8467         * breakpoint.c (create_overlay_event_breakpoint)
8468         (create_longjmp_master_breakpoint)
8469         (create_std_terminate_master_breakpoint)
8470         (create_exception_master_breakpoint): Use all_objfiles.
8471         * linux-thread-db.c (try_thread_db_load_from_pdir)
8472         (has_libpthread): Use all_objfiles.
8473         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8474         * linespec.c (iterate_over_all_matching_symtabs)
8475         (search_minsyms_for_name): Use all_objfiles.
8476         * maint.c (maintenance_info_sections): Use all_objfiles.
8477         * main.c (captured_main_1): Use all_objfiles.
8478         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8479         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8480         * guile/scm-pretty-print.c
8481         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8482         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8483         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8484         (maintenance_print_msymbols): Use all_objfiles.
8485         * source.c (select_source_symtab): Use all_objfiles.
8486         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8487         * symfile.c (remove_symbol_file_command)
8488         (expand_symtabs_matching, map_symbol_filenames): Use
8489         all_objfiles.
8490         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8491         all_objfiles.
8492         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8493         * objc-lang.c (find_methods): Use all_objfiles.
8494         * objfiles.c (have_partial_symbols, have_full_symbols)
8495         (have_minimal_symbols, qsort_cmp)
8496         (default_iterate_over_objfiles_in_search_order): Use
8497         all_objfiles.
8498         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8499         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8500         (maintenance_check_psymtabs): Use all_objfiles.
8501         (ALL_PSYMTABS): Remove.
8502         * compile/compile-object-run.c (do_module_cleanup): Use
8503         all_objfiles.
8504         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8505         * cp-support.c (add_symbol_overload_list_qualified): Use
8506         all_objfiles.
8507         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8508         Use all_objfiles.
8509         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8510         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8511         all_objfiles.
8512         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8513         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8514         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8515         Uses all_objfiles.
8516         * solib.c (solib_read_symbols): Use all_objfiles
8517
8518 2019-01-09  Tom Tromey  <tom@tromey.com>
8519
8520         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8521         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8522         all_objfiles.
8523         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8524         * symmisc.c (print_symbol_bcache_statistics)
8525         (print_objfile_statistics, maintenance_print_objfiles)
8526         (maintenance_info_symtabs, maintenance_check_symtabs)
8527         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8528         all_objfiles.
8529         * source.c (forget_cached_source_info): Use all_objfiles.
8530         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8531         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8532         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8533         * objfiles.c (update_section_map): Use all_objfiles.
8534         (shared_objfile_contains_address_p): Likewise.
8535         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8536         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8537
8538 2019-01-09  Tom Tromey  <tom@tromey.com>
8539
8540         * common/next-iterator.h: New file.
8541         * objfiles.h (class all_objfiles): New.
8542         (struct objfile_iterator): New.
8543
8544 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8545
8546         * NEWS: Move the description of the changed "frame", "select-frame",
8547          and "info frame" commands to the Changed commands section.
8548
8549 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8550
8551         * gdbtypes.c (check_stub_method_group): Remove handling of old
8552         mangling schemes.
8553         * linespec.c (find_methods): Likewise.
8554         * stabsread.c (read_member_functions): Likewise.
8555         * valops.c (search_struct_method): Likewise.
8556         (value_struct_elt_for_reference): Likewise.
8557         * NEWS: Mention this change.
8558
8559 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8560
8561         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8562         print_source_lines.
8563         * source.c (print_source_lines_base): Update line number check.
8564         (print_source_lines): New function.
8565         (source_lines_range::source_lines_range): New function.
8566         * source.h (class source_lines_range): New class.
8567         (print_source_lines): New declaration.
8568
8569 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8570
8571         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8572
8573 2019-01-08  Tom Tromey  <tom@tromey.com>
8574             Simon Marchi  <simon.marchi@ericsson.com>
8575
8576         PR gdb/24060
8577         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8578         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8579         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8580         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8581         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8582         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8583
8584 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8585
8586         * source.c (select_source_symtab): Move header comment to
8587         declaration in source.h.
8588         (forget_cached_source_info_for_objfile): Likewise.
8589         (forget_cached_source_info): Likewise.
8590         (identify_source_line): Likewise.
8591         * source.h (identify_source_line): Move declaration from symtab.h
8592         and add comment from source.c
8593         (print_source_lines): Likewise.
8594         (forget_cached_source_info_for_objfile): Likewise.
8595         (forget_cached_source_info): Likewise.
8596         (select_source_symtab): Likewise.
8597         (enum print_source_lines_flag): Move definition from symtab.h.
8598         * symtab.h (identify_source_line): Move declaration to source.h.
8599         (print_source_lines): Likewise.
8600         (forget_cached_source_info_for_objfile): Likewise.
8601         (forget_cached_source_info): Likewise.
8602         (select_source_symtab): Likewise.
8603         (enum print_source_lines_flag): Move definition to source.h.
8604         * tui/tui-hooks.c: Add 'source.h' include.
8605
8606 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8607
8608         * source.c (print_source_lines_base): Handle requests to print
8609         reverse line number sequences, and guard against empty lines
8610         string.
8611
8612 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8613
8614         * source.c (print_source_lines_base): Fix skip of '\r' if next
8615         character is '\n'.
8616
8617 2019-01-06  Tom Tromey  <tom@tromey.com>
8618
8619         * c-exp.y (struct c_parse_state) <macro_original_text,
8620         expansion_obstack>: New member.
8621         (macro_original_text, expansion_obstack): Remove globals.
8622         (scan_macro_expansion, scanning_macro_expansion)
8623         (finished_macro_expansion): Update.
8624         (scan_macro_cleanup): Remove.
8625         (yylex, c_parse): Update.
8626
8627 2019-01-06  Tom Tromey  <tom@tromey.com>
8628
8629         * c-exp.y (struct c_parse_state) <strings>: New member.
8630         (operator_stoken): Update.
8631
8632 2019-01-06  Tom Tromey  <tom@tromey.com>
8633
8634         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8635         (union type_stack_elt) <typelist_val>: Now a pointer to
8636         std::vector.
8637         (type_stack_cleanup): Don't declare.
8638         (push_typelist): Update.
8639         * parse.c (pop_typelist): Return a std::vector.
8640         (push_typelist): Take a std::vector.
8641         (follow_types): Update.  Do not free args.
8642         (type_stack_cleanup): Remove.
8643         * c-exp.y (struct c_parse_state): New.
8644         (cpstate): New global.
8645         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8646         (nonempty_typelist): Update.
8647         (func_mod): Create a new vector.
8648         (c_parse): Create a c_parse_state.
8649         (check_parameter_typelist): Do not delete params.
8650         (function_method): Update.  Do not delete type_list.
8651
8652 2019-01-06  Tom Tromey  <tom@tromey.com>
8653
8654         PR gdb/28155:
8655         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8656         check_typedef.
8657         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8658         (print_return_value): Likewise.
8659
8660 2019-01-05  Tom Tromey  <tom@tromey.com>
8661
8662         * contrib/cleanup_check.py: Remove.
8663         * contrib/gcc-with-excheck: Remove.
8664         * contrib/exsummary.py: Remove.
8665         * contrib/excheck.py: Remove.
8666
8667 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8668
8669         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8670         NULL. Initialize tpprev to NULL instead of assigning it
8671         to NULL on the next statement.
8672         * windows-nat.c (windows_delete_thread): Remove check for
8673         main_thread_id before printing thread exit notifications.
8674         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8675         Remove thread ID check against main_thread_id.
8676         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8677         windows_delete_thread.
8678         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8679
8680 2019-01-04  Tom Tromey  <tom@tromey.com>
8681
8682         * compile/compile.c (_initialize_compile): Use upper case for
8683         metasyntactic variables.
8684         * symmisc.c (_initialize_symmisc): Use upper case for
8685         metasyntactic variables.
8686         * psymtab.c (_initialize_psymtab): Use upper case for
8687         metasyntactic variables.
8688         * demangle.c (demangle_command): Use upper case for metasyntactic
8689         variables.
8690         (_initialize_demangler): Likewise.
8691         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8692         variables.
8693
8694 2019-01-03  Tom Tromey  <tom@tromey.com>
8695
8696         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8697
8698 2019-01-03  Tom Tromey  <tom@tromey.com>
8699
8700         * python/py-symtab.c (salpy_str): Update.
8701         (struct salpy_sal_object) <symtab>: Now a PyObject.
8702         (salpy_dealloc): Update.
8703         (del_objfile_sal): Use gdbpy_ref.
8704
8705 2019-01-03  Tom Tromey  <tom@tromey.com>
8706
8707         * python/py-type.c (convert_field): Use new_reference.  Return
8708         gdbpy_ref.
8709         (make_fielditem): Return gdbpy_ref.
8710         (typy_fields): Update.
8711         (typy_getitem): Update.
8712         (field_name): Return gdbpy_ref.  Use new_reference.
8713         (typy_iterator_iternext): Update.
8714
8715 2019-01-03  Tom Tromey  <tom@tromey.com>
8716
8717         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8718
8719 2019-01-03  Tom Tromey  <tom@tromey.com>
8720
8721         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8722         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8723         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8724         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8725         (pspy_set_type_printers): Likewise.
8726         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8727         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8728         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8729         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8730         (objfpy_set_type_printers): Likewise.
8731
8732 2019-01-03  Tom Tromey  <tom@tromey.com>
8733
8734         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8735         (gdbpy_print_stack): Use gdbpy_err_fetch.
8736         * python/python-internal.h (class gdbpy_err_fetch): New class.
8737         (class gdbpy_enter) <m_error_type, m_error_value,
8738         m_error_traceback>: Remove.
8739         <m_error>: New member.
8740         (gdbpy_exception_to_string): Don't declare.
8741         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8742         * python/py-value.c (convert_value_from_python): Use
8743         gdbpy_err_fetch.
8744         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8745         gdbpy_exception_to_string.
8746         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8747         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8748         gdbpy_err_fetch.
8749
8750 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8751
8752         * linux-nat.c (delete_lwp_cleanup): Delete.
8753         (struct lwp_deleter): New struct.
8754         (lwp_info_up): New typedef.
8755         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8756         lwp_info_up.
8757
8758 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8759
8760         * linux-fork.c (class scoped_switch_fork_info): New class.
8761         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8762
8763 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8764
8765         * valops.c (find_overload_match): Remove use of null_cleanup, and
8766         calls to do_cleanups.
8767
8768 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8769
8770         * compile/compile-cplus-types.c
8771         (compile_cplus_instance::decl_name): Handle changes to
8772         cp_func_name.
8773         * cp-support.c (cp_func_name): Update header comment, update
8774         return type.
8775         * cp-support.h (cp_func_name): Update return type in declaration.
8776         * valops.c (find_overload_match): Move temp_func local to top
8777         level of function and change its type.  Use temp_func to hold and
8778         delete temporary string obtained from cp_func_name.
8779
8780 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8781
8782         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8783         gdb::char_vector, remove cleanup, and update uses of `msg`.
8784
8785 2019-01-03  Jim Wilson  <jimw@sifive.com>
8786
8787         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8788
8789 2019-01-02  Tom Tromey  <tom@tromey.com>
8790
8791         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8792         (tdesc_parse_xml): Remove cleanups.
8793         * target-descriptions.h (make_cleanup_free_target_description):
8794         Don't declare.
8795         (target_desc_deleter): New struct.
8796         (target_desc_up): New typedef.
8797         * target-descriptions.c (target_desc_deleter::operator()): Rename
8798         from free_target_description.
8799         (make_cleanup_free_target_description): Remove.
8800
8801 2019-01-02  Tom Tromey  <tom@tromey.com>
8802
8803         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8804         constructor, destructor.
8805         (linespec_parser): Remove typedef.
8806         (~linespec_parser): Rename from linespec_parser_delete.
8807         (linespec_lex_to_end, linespec_complete_label)
8808         (linespec_complete): Update.
8809         (decode_line_full): Remove cleanups.
8810         (decode_line_1): Update.
8811
8812 2019-01-02  Tom Tromey  <tom@tromey.com>
8813
8814         * python/python-internal.h (inferior_to_inferior_object): Change
8815         return type.
8816         * python/py-exitedevent.c (create_exited_event_object): Update.
8817         * python/py-inferior.c (inferior_to_inferior_object): Return
8818         gdbpy_ref.
8819         (python_new_inferior, python_inferior_deleted)
8820         (thread_to_thread_object, delete_thread_object)
8821         (build_inferior_list, gdbpy_selected_inferior): Update.
8822         * python/py-infthread.c (create_thread_object): Update.  Also fail
8823         if inferior_to_inferior_object fails.
8824
8825 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8826
8827         * inferior.h (class inferior) <displaced_step_state>: New field.
8828         * infrun.h (struct displaced_step_state): Move here from
8829         infrun.c.  Initialize fields, add constructor.
8830         <inf>: Remove field.
8831         <reset>: New method.
8832         * infrun.c (struct displaced_step_inferior_state): Move to
8833         infrun.h.
8834         (displaced_step_inferior_states): Remove.
8835         (get_displaced_stepping_state): Adust.
8836         (displaced_step_in_progress_any_inferior): Adjust.
8837         (displaced_step_in_progress_thread): Adjust.
8838         (displaced_step_in_progress): Adjust.
8839         (add_displaced_stepping_state): Remove.
8840         (get_displaced_step_closure_by_addr): Adjust.
8841         (remove_displaced_stepping_state): Remove.
8842         (infrun_inferior_exit): Call displaced_step_state.reset.
8843         (use_displaced_stepping): Don't check for NULL.
8844         (displaced_step_prepare_throw): Call
8845         get_displaced_stepping_state.
8846         (displaced_step_fixup): Don't check for NULL.
8847         (prepare_for_detach): Don't check for NULL.
8848
8849 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8850
8851         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8852          in case of call that did not complete.
8853
8854 2019-01-02  Andrey Utkin  <autkin@undo.io>
8855
8856         * symfile.c (find_separate_debug_file): Fix search of debug files for
8857         remote debuggee.
8858
8859 2019-01-02  Tom Tromey  <tom@tromey.com>
8860
8861         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8862         indentation.
8863         * python/py-frame.c (frapy_older): Remove cast.
8864         (frapy_newer): Likewise.
8865         * python/py-breakpoint.c (local_setattro): Remove cast.
8866         * python/py-arch.c (archpy_name): Remove local variable.
8867         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8868
8869 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8870
8871         * unittests/basic_string_view/element_access/char/empty.cc:
8872         Fix year range in copyright header.
8873
8874 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8875
8876         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8877         Delete.
8878         <operator==>: Update with for removed field.
8879         <hash>: Likewise.
8880         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8881         <isa_features>: ...this.
8882         <abi_features>: New field.
8883         (riscv_isa_flen): Update comment.
8884         (riscv_abi_xlen): New declaration.
8885         (riscv_abi_flen): New declaration.
8886         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8887         isa_features.
8888         (riscv_abi_xlen): New function.
8889         (riscv_isa_flen): Update to get answer from isa_features.
8890         (riscv_abi_flen): New function.
8891         (riscv_has_fp_abi): Update to get answer from abi_features.
8892         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8893         xlen and flen.
8894         (riscv_call_info) <xlen, flen>: Update comment.
8895         (riscv_call_arg_struct): Remove invalid assertions
8896         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8897         is removed.
8898         (riscv_gdbarch_init): Gather isa features and abi features
8899         separately, ensure both match on the gdbarch when reusing an old
8900         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8901         a target with 64-bit float hardware.
8902
8903 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8904
8905         * source.c (search_command_helper): Stop reverse search
8906         when line 1 has been searched.
8907
8908 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8909
8910         * record-full.c (record_full_base_target::close): Rewrite
8911         record_full_core_buf_list free logic.
8912
8913 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8914
8915         * break-catch-syscall.c (print_one_catch_syscall): xfree
8916         the last text.
8917
8918 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8919
8920         * top.c (print_gdb_version): Update Copyright year in version
8921         message.
8922
8923 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8924
8925         Update copyright year range in all GDB files.
8926
8927 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8928
8929         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8930
8931 For older changes see ChangeLog-2018.
8932 \f
8933 Local Variables:
8934 mode: change-log
8935 left-margin: 8
8936 fill-column: 74
8937 version-control: never
8938 coding: utf-8
8939 End:
8940